Repository: richardkiss/pycoin

Issue:
LTC p2sh address prefix `3` vs `M`
I noticed that the address prefix for LTC results in the old `3` address format. Would a patch to change that to the new `M` format be welcome?

Discussion:
richardkiss: This is great, but could you fix the LTC test too?
keepkeyjon: oops. sure!
codecov-io: # [Codecov](https://codecov.io/gh/richardkiss/pycoin/pull/353?src=pr&el=h1) Report
> Merging [#353](https://codecov.io/gh/richardkiss/pycoin/pull/353?src=pr&el=desc) into [master](https://codecov.io/gh/richardkiss/pycoin/commit/bd9491fd4cfa7285a695f52d7964ecc72afa3763?src=pr&el=desc) will **increase** coverage by `0.05%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/richardkiss/pycoin/pull/353/graphs/tree.svg?width=650&token=RDxRtP4EqL&height=150&src=pr)](https://codecov.io/gh/richardkiss/pycoin/pull/353?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master     #353      +/-   ##
==========================================
+ Coverage   88.51%   88.56%   +0.05%     
==========================================
  Files         218      218              
  Lines        9982     9982              
==========================================
+ Hits         8836     8841       +5     
+ Misses       1146     1141       -5
```


| [Impacted Files](https://codecov.io/gh/richardkiss/pycoin/pull/353?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pycoin/symbols/ltc.py](https://codecov.io/gh/richardkiss/pycoin/pull/353/diff?src=pr&el=tree#diff-cHljb2luL3N5bWJvbHMvbHRjLnB5) | `100% <ø> (ø)` | :arrow_up: |
| [pycoin/solve/ConstraintSolver.py](https://codecov.io/gh/richardkiss/pycoin/pull/353/diff?src=pr&el=tree#diff-cHljb2luL3NvbHZlL0NvbnN0cmFpbnRTb2x2ZXIucHk=) | `97.82% <0%> (+2.17%)` | :arrow_up: |
| [tests/cmds/cmdline\_test.py](https://codecov.io/gh/richardkiss/pycoin/pull/353/diff?src=pr&el=tree#diff-dGVzdHMvY21kcy9jbWRsaW5lX3Rlc3QucHk=) | `88.7% <0%> (+6.45%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/richardkiss/pycoin/pull/353?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/richardkiss/pycoin/pull/353?src=pr&el=footer). Last update [bd9491f...431671a](https://codecov.io/gh/richardkiss/pycoin/pull/353?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


Patch:
diff --git a/pycoin/symbols/ltc.py b/pycoin/symbols/ltc.py
index 37fddc1..9dd5bdb 100644
--- a/pycoin/symbols/ltc.py
+++ b/pycoin/symbols/ltc.py
@@ -3,5 +3,5 @@ from pycoin.networks.bitcoinish import create_bitcoinish_network
 
 network = create_bitcoinish_network(
     network_name="Litecoin", symbol="LTC", subnet_name="mainnet",
-    wif_prefix_hex="b0", sec_prefix="LTCSEC:", address_prefix_hex="30", pay_to_script_prefix_hex="05",
+    wif_prefix_hex="b0", sec_prefix="LTCSEC:", address_prefix_hex="30", pay_to_script_prefix_hex="32",
     bip32_prv_prefix_hex="019d9cfe", bip32_pub_prefix_hex="019da462", bech32_hrp="ltc")


Test patch:
diff --git a/tests/cmds/test_cases/ku/bip32_subpaths_ltc.txt b/tests/cmds/test_cases/ku/bip32_subpaths_ltc.txt
index dcbac64..5f77114 100644
--- a/tests/cmds/test_cases/ku/bip32_subpaths_ltc.txt
+++ b/tests/cmds/test_cases/ku/bip32_subpaths_ltc.txt
@@ -15,7 +15,7 @@ ku -n LTC -j P:foo -s 5-10
    "key_pair_as_sec": "0378a0d972953591dcf8f6220a0e1e5a2291b0a503604095d64a1e046ec8c0bfa8",
    "key_pair_as_sec_uncompressed": "0478a0d972953591dcf8f6220a0e1e5a2291b0a503604095d64a1e046ec8c0bfa81e81dde9b0926b2b0587286684670938d0f995a00b11bd1cf78320c38f7da863",
    "network": "Litecoin mainnet",
-   "p2sh_segwit": "3ELJbuAHwifoBaCWExbJcy5t9Za1PLjEzB",
+   "p2sh_segwit": "MLYSunaFtqXDz5UQLqaeScLHUGATNq7ibZ",
    "p2sh_segwit_script": "0014639c2e98539808eb087fa64543efc4dd7aaa5e4e",
    "parent_fingerprint": "5d353a2e",
    "private_key": "yes",
@@ -49,7 +49,7 @@ ku -n LTC -j P:foo -s 5-10
    "key_pair_as_sec": "0342009b6607d46faa21abd7e71ecc8fa83b5f9add661aba2af65e997fb7f107e0",
    "key_pair_as_sec_uncompressed": "0442009b6607d46faa21abd7e71ecc8fa83b5f9add661aba2af65e997fb7f107e02735caaecc69ac891afbe2cc61a2f163c5f437bbdf8674c1dbbe34e9e3c67b7f",
    "network": "Litecoin mainnet",
-   "p2sh_segwit": "3MGZvnJLZfAzEo1kiS45W6EpcHWhzzFSM8",
+   "p2sh_segwit": "MTUiEfiJWn2R3JHepK3RKjVDvz79zx6nbx",
    "p2sh_segwit_script": "0014f39a290b7a6ff88c8c61cecc9a8e7b742a23ef6e",
    "parent_fingerprint": "5d353a2e",
    "private_key": "yes",
@@ -83,7 +83,7 @@ ku -n LTC -j P:foo -s 5-10
    "key_pair_as_sec": "032a881c9182821c7153663572cb657cdaa69128f555bec8982d443f427c717f39",
    "key_pair_as_sec_uncompressed": "042a881c9182821c7153663572cb657cdaa69128f555bec8982d443f427c717f396a45e73f0b46c4d431b054b99cda747608950a1dbbc17d2c59439f558a822d71",
    "network": "Litecoin mainnet",
-   "p2sh_segwit": "3BEmuNdXqK5XdG4g5Ypz8XUTJc2hSRbE9N",
+   "p2sh_segwit": "MHSvDG3VnRvxRmLaBRpKxAirdJd9NQ9Ckf",
    "p2sh_segwit_script": "00149c6b340312237006369bba466eb846ff3b5c62f5",
    "parent_fingerprint": "5d353a2e",
    "private_key": "yes",
@@ -117,7 +117,7 @@ ku -n LTC -j P:foo -s 5-10
    "key_pair_as_sec": "02288828380f4a40619ab1c54f7490f52306835e7bd5e8c540f884f9f4e3157171",
    "key_pair_as_sec_uncompressed": "04288828380f4a40619ab1c54f7490f52306835e7bd5e8c540f884f9f4e3157171e1b22857caa0aeff5067a0f20acdc3d2d5aca73db7f0a7b2049faaa439677ba0",
    "network": "Litecoin mainnet",
-   "p2sh_segwit": "3KRpSzFGdEr1me3ApDurGUKbSXtF7NP728",
+   "p2sh_segwit": "MRdxksfEaMhSa9K4v6uC67ZzmEUh89FD5e",
    "p2sh_segwit_script": "00141e71ebce1b3f50ecd78b44598dab4351ae426a20",
    "parent_fingerprint": "5d353a2e",
    "private_key": "yes",
@@ -151,7 +151,7 @@ ku -n LTC -j P:foo -s 5-10
    "key_pair_as_sec": "02bc7c9c4b6a3944d3c8f9b1dc8fe362172a7dbe724aad6363c3f82910e41e1428",
    "key_pair_as_sec_uncompressed": "04bc7c9c4b6a3944d3c8f9b1dc8fe362172a7dbe724aad6363c3f82910e41e14287ea63b21525757e89a6b7ef3ec2b9714bdaafc46b1cabf8fe46e9ae2c841a754",
    "network": "Litecoin mainnet",
-   "p2sh_segwit": "32LXf368At98ibdWwLrW6pJt5PBXq9QTVo",
+   "p2sh_segwit": "M8YfxvW67zzZX6uR3DqqvTZHQ5myui1FeA",
    "p2sh_segwit_script": "0014ef264fe68474d1955d41d2e0645f2df88f569739",
    "parent_fingerprint": "5d353a2e",
    "private_key": "yes",
@@ -185,7 +185,7 @@ ku -n LTC -j P:foo -s 5-10
    "key_pair_as_sec": "026f2ac6865005d4e6c1e6605d4fb3d67df4ceabd582aa84d98e668c2cbbeac6cc",
    "key_pair_as_sec_uncompressed": "046f2ac6865005d4e6c1e6605d4fb3d67df4ceabd582aa84d98e668c2cbbeac6cc062011ce1d912338c1c3ed6ed64f7b566bebd22eb6c1865a7e34f7628171beea",
    "network": "Litecoin mainnet",
-   "p2sh_segwit": "33xCsFEYVijkrQkynb9gfsJEkLZRudGnUr",
+   "p2sh_segwit": "MAAMB8eWSqbBev2stU92VWYe539stALF7d",
    "p2sh_segwit_script": "00147d423c8fb2af77053c30219f6257dbfa0737ba0d",
    "parent_fingerprint": "5d353a2e",
    "private_key": "yes",