Repository: planetlabs/planet-client-python

Issue:
Remove reported data from CLI download
Currently, when requesting a download, the CLI reports the number of files in an order. 

For example, for an order with 12 files here's what one would see to stdout:

```
❯ planet orders download my-oid
Downloaded 12 files.
```

**Proposal:**
After [lengthy discussions](https://github.com/planetlabs/planet-client-python/pull/355#issuecomment-1010215231), I propose that the CLI should remain silent upon a download request. Specifically, the download request should not output to stdout nor stderr, but using the INFO log, which already exists in `body.write()`, to communicate the files downloaded.

**To do:**
1) Remove `click.echo(f'Downloaded {len(filenames)} files.')` in `planet.cli.orders.download()` (line 126)
2) Update the CLI's test in `tests.unit.test_cli_orders.test_cli_orders_download()` to no longer expect "`'Downloaded 4 files.\n'`"

Discussion:

Patch:
diff --git a/planet/cli/orders.py b/planet/cli/orders.py
index ab03c78..a30b561 100644
--- a/planet/cli/orders.py
+++ b/planet/cli/orders.py
@@ -118,12 +118,11 @@ async def download(ctx, order_id, quiet, overwrite, dest):
         with planet.reporting.StateBar(order_id=order_id,
                                        disable=quiet) as bar:
             await cl.poll(str(order_id), report=bar.update)
-            filenames = await cl.download_order(
+            _ = await cl.download_order(
                     str(order_id),
                     directory=dest,
                     overwrite=overwrite,
                     progress_bar=not quiet)
-    click.echo(f'Downloaded {len(filenames)} files.')
 
 
 def split_id_list(ctx, param, value):


Test patch:
diff --git a/tests/unit/test_cli_orders.py b/tests/unit/test_cli_orders.py
index ff9c16a..ee1f4a0 100644
--- a/tests/unit/test_cli_orders.py
+++ b/tests/unit/test_cli_orders.py
@@ -89,8 +89,8 @@ def test_cli_orders_download(runner, patch_ordersclient, oid):
         return
     patch_ordersclient('poll', poll)
 
-    # Number of files in all_test_files
-    expected = 'Downloaded 4 files.\n'
+    # Download should not report anything
+    expected = ''
 
     # allow for some progress reporting
     result = runner.invoke(