Repository: zalando-stups/senza

Issue:
Discrepancy between README and error messages
README.md states:
`sudo pip3 install --upgrade stups-senza`

But if you have an old version of senza installed, the reported message is:
`...Please install the new one using 'sudo pip install --upgrade stups-senza'`

Note that `pip3` is specified in README and `pip` is specified in the error message.


Discussion:

Patch:
diff --git a/senza/subcommands/root.py b/senza/subcommands/root.py
index a121009..e163658 100644
--- a/senza/subcommands/root.py
+++ b/senza/subcommands/root.py
@@ -99,9 +99,9 @@ def check_senza_version(current_version: str):
     if latest_version is not None and current_version < latest_version:
         if __file__.startswith('/home'):
             # if it's installed in the user folder
-            cmd = "pip install --upgrade stups-senza"
+            cmd = "pip3 install --upgrade stups-senza"
         else:
-            cmd = "sudo pip install --upgrade stups-senza"
+            cmd = "sudo pip3 install --upgrade stups-senza"
         warning("Your senza version ({current}) is outdated. "
                 "Please install the new one using '{cmd}'".format(current=current_version,
                                                                   cmd=cmd))


Test patch:
diff --git a/tests/test_subcommands/test_root.py b/tests/test_subcommands/test_root.py
index 86f5a4f..c16be12 100644
--- a/tests/test_subcommands/test_root.py
+++ b/tests/test_subcommands/test_root.py
@@ -71,7 +71,7 @@ def test_check_senza_version(monkeypatch,
         check_senza_version("0.40")
         mock_warning.assert_called_once_with(
             "Your senza version (0.40) is outdated. "
-            "Please install the new one using 'pip install --upgrade stups-senza'"
+            "Please install the new one using 'pip3 install --upgrade stups-senza'"
         )
 
     with TemporaryDirectory() as temp_dir_4:
@@ -83,7 +83,7 @@ def test_check_senza_version(monkeypatch,
         mock_warning.assert_called_once_with(
             "Your senza version (0.40) is outdated. "
             "Please install the new one using "
-            "'sudo pip install --upgrade stups-senza'"
+            "'sudo pip3 install --upgrade stups-senza'"
         )
 
 
@@ -115,7 +115,7 @@ def test_check_senza_version_outdated_cache(monkeypatch,  # noqa: F811
         mock_warning.assert_called_once_with(
             "Your senza version (0.40) is outdated. "
             "Please install the new one using "
-            "'sudo pip install --upgrade stups-senza'"
+            "'sudo pip3 install --upgrade stups-senza'"
         )