Repository: pvlib/pvanalytics

Issue:
Unused parameter in qcrad irradiance consistency check
The `dni_extra` parameter to `quality.irrandiance.check_irradiance_consistency_qcrad()` is unused and should be removed.

Discussion:

Patch:
diff --git a/pvanalytics/quality/irradiance.py b/pvanalytics/quality/irradiance.py
index 3730a10..fecf607 100644
--- a/pvanalytics/quality/irradiance.py
+++ b/pvanalytics/quality/irradiance.py
@@ -244,7 +244,7 @@ def _check_irrad_ratio(ratio, ghi, sza, bounds):
     )
 
 
-def check_irradiance_consistency_qcrad(ghi, solar_zenith, dni_extra, dhi, dni,
+def check_irradiance_consistency_qcrad(ghi, solar_zenith, dhi, dni,
                                        param=None):
     """Check consistency of GHI, DHI and DNI using QCRad criteria.
 
@@ -261,8 +261,6 @@ def check_irradiance_consistency_qcrad(ghi, solar_zenith, dni_extra, dhi, dni,
         Global horizontal irradiance in :math:`W/m^2`
     solar_zenith : Series
         Solar zenith angle in degrees
-    dni_extra : Series
-        Extraterrestrial normal irradiance in :math:`W/m^2`
     dhi : Series
         Diffuse horizontal irradiance in :math:`W/m^2`
     dni : Series


Test patch:
diff --git a/pvanalytics/tests/quality/test_irradiance.py b/pvanalytics/tests/quality/test_irradiance.py
index 6bfca71..85290b1 100644
--- a/pvanalytics/tests/quality/test_irradiance.py
+++ b/pvanalytics/tests/quality/test_irradiance.py
@@ -93,7 +93,7 @@ def test_check_irradiance_consistency_qcrad(irradiance_qcrad):
     """Test that QCRad identifies consistent irradiance measurements."""
     expected = irradiance_qcrad
     cons_comp, diffuse = irradiance.check_irradiance_consistency_qcrad(
-        expected['ghi'], expected['solar_zenith'], expected['dni_extra'],
+        expected['ghi'], expected['solar_zenith'],
         expected['dhi'], expected['dni'])
     assert_series_equal(cons_comp, expected['consistent_components'],
                         check_names=False)