Repository: exxamalte/python-georss-qld-bushfire-alert-client

Issue:
XML URL appears to have been changed.
The URL specified in feed.py ("https://www.qfes.qld.gov.au/data/alerts/bushfireAlert.xml") doesn't appear to be valid currently.

The Current bushfire warnings and incidents page on the Queensland Fire Department's website presently links to an XML file located at "https://publiccontent-gis-psba-qld-gov-au.s3.amazonaws.com/content/Feeds/BushfireCurrentIncidents/bushfireAlert.xml".

I've swapped the URL over in my feed.py file and everything seems to work no wukkas, not sure why they changed the location or if they'll change it back though.

Discussion:

Patch:
diff --git a/georss_qld_bushfire_alert_client/feed.py b/georss_qld_bushfire_alert_client/feed.py
index 6623a7d..3eb700f 100644
--- a/georss_qld_bushfire_alert_client/feed.py
+++ b/georss_qld_bushfire_alert_client/feed.py
@@ -8,7 +8,8 @@ from georss_client.feed import GeoRssFeed
 
 from .feed_entry import QldBushfireAlertFeedEntry
 
-URL: Final = "https://www.qfes.qld.gov.au/data/alerts/bushfireAlert.xml"
+# URL as published here: https://www.fire.qld.gov.au/Current-Incidents
+URL: Final = "https://publiccontent-gis-psba-qld-gov-au.s3.amazonaws.com/content/Feeds/BushfireCurrentIncidents/bushfireAlert.xml"
 
 
 class QldBushfireAlertFeed(GeoRssFeed):


Test patch:
diff --git a/tests/test_feed.py b/tests/test_feed.py
index bf1c1f7..08b5192 100644
--- a/tests/test_feed.py
+++ b/tests/test_feed.py
@@ -23,8 +23,8 @@ def test_update_ok(mock_session, mock_request):
     feed = QldBushfireAlertFeed(HOME_COORDINATES)
     assert (
         repr(feed) == "<QldBushfireAlertFeed(home=(-31.0, 151.0), "
-        "url=https://www.qfes.qld.gov.au/data/alerts/"
-        "bushfireAlert.xml, radius=None, categories="
+        "url=https://publiccontent-gis-psba-qld-gov-au.s3.amazonaws.com/content/"
+        "Feeds/BushfireCurrentIncidents/bushfireAlert.xml, radius=None, categories="
         "None)>"
     )
     status, entries = feed.update()
diff --git a/tests/test_feed_manager.py b/tests/test_feed_manager.py
index 872afbb..d093007 100644
--- a/tests/test_feed_manager.py
+++ b/tests/test_feed_manager.py
@@ -40,9 +40,8 @@ def test_feed_manager(mock_session, mock_request):
     assert (
         repr(feed_manager) == "<QldBushfireAlertFeedManager("
         "feed=<QldBushfireAlertFeed(home="
-        "(-31.0, 151.0), url=https://www."
-        "qfes.qld.gov.au/data/alerts/"
-        "bushfireAlert.xml, "
+        "(-31.0, 151.0), url=https://publiccontent-gis-psba-qld-gov-au.s3.amazonaws.com/"
+        "content/Feeds/BushfireCurrentIncidents/bushfireAlert.xml, "
         "radius=None, categories=None)>)>"
     )
     feed_manager.update()