Repository: kratsg/itksn

Issue:
Pixel FE wafer/chip codes
HI @kratsg 

as of today the pixel FE wafer/chip numbering has changed. The last 7 digits is the decimal presentation of 0xBWWXY, where B  is the batch indicator and the 2 was reserved for CROC but is used for ITkPix v2 now. See the screenshot attached. Here is the link to the numbering document: https://edms.cern.ch/document/2649105/1

![image](https://github.com/kratsg/itksn/assets/8101850/3fa58d02-181a-48a6-8b15-39df3c39b2a4)


Discussion:

Patch:
diff --git a/src/itksn/pixels.py b/src/itksn/pixels.py
index 2233e46..cc96f3e 100644
--- a/src/itksn/pixels.py
+++ b/src/itksn/pixels.py
@@ -23,7 +23,7 @@ fe_chip_wafer = Struct(
         Bytes(1),
         RD53A=b"0",
         ITkpix_v1=b"1",
-        CROC=b"2",
+        ITkpix_v2=b"2",
     ),
     "number" / Bytes(6),
 )


Test patch:
diff --git a/tests/test_core.py b/tests/test_core.py
index 8490dfe..b9e6c23 100644
--- a/tests/test_core.py
+++ b/tests/test_core.py
@@ -40,7 +40,7 @@ def test_parse_fe_wafer():
     assert parsed.system_code == "phaseII_upgrade"
     assert parsed.project_code == "pixel_general"
     assert parsed.subproject_code == "FE_chip_wafer"
-    assert parsed.identifier.batch_number == "CROC"
+    assert parsed.identifier.batch_number == "ITkpix_v2"
     assert parsed.identifier.number == b"123456"