Repository: ECCO-GROUP/ECCOv4-py

Issue:
'Faroe Scotland' is included in the get_available_sections() but not included in get_section_endpoints()
get_section_endpoints() returns and error for 'Faroe Scotland'. I think this is because the coordinates for this section is actually not included in the function. I assume that the info exists but was accidentally removed.

Discussion:

Patch:
diff --git a/ecco_v4_py/get_section_masks.py b/ecco_v4_py/get_section_masks.py
index a03db6f..6ffa665 100644
--- a/ecco_v4_py/get_section_masks.py
+++ b/ecco_v4_py/get_section_masks.py
@@ -90,6 +90,9 @@ def get_section_endpoints(section_name):
     elif section_name == 'icelandfaroe':
         pt1 = [-16, 65]
         pt2 = [ -7, 62.5]
+    elif section_name == 'faroescotland':
+        pt1 = [-6.5, 62.5]
+        pt2 = [-4, 57]
     elif section_name == 'scotlandnorway':
         pt1 = [-4, 57]
         pt2 = [ 8, 62]


Test patch:
diff --git a/ecco_v4_py/test/test_section_masks.py b/ecco_v4_py/test/test_section_masks.py
new file mode 100644
index 0000000..9610842
--- /dev/null
+++ b/ecco_v4_py/test/test_section_masks.py
@@ -0,0 +1,11 @@
+
+from __future__ import division, print_function
+import ecco_v4_py as ecco
+
+
+def test_section_endpoints():
+    """Ensure that the listed available sections are actually there
+    """
+
+    for section in ecco.get_available_sections():
+        assert ecco.get_section_endpoints(section) is not None