Repository: HECBioSim/Longbow

Issue:
spelling in docs
--verbose is spelled wrong in the dis-connectable session docs

Discussion:

Patch:
diff --git a/docs/usr-running-jobs.rst b/docs/usr-running-jobs.rst
index 847ae49..41f3784 100644
--- a/docs/usr-running-jobs.rst
+++ b/docs/usr-running-jobs.rst
@@ -300,7 +300,7 @@ A useful feature is the ability for Longbow to disconnect itself shortly after s
 
 Longbow will simply submit your jobs and then write out the details to a recovery file, by doing this the user always has the option to reconnect to the session later to automatically download files or to continue polling if desired. To initiate this feature one just simply adds the --disconnect flag to the Longbow part of the command-line::
 
-    longbow --versbose --disconnect --log new.log namd2 ">" output.out
+    longbow --verbose --disconnect --log new.log namd2 ">" output.out
 
 Persistent Reconnect/Recover Sessions
 =====================================
diff --git a/longbow/entrypoints.py b/longbow/entrypoints.py
index 741d850..f413500 100644
--- a/longbow/entrypoints.py
+++ b/longbow/entrypoints.py
@@ -317,8 +317,6 @@ def launcher():
 
             LOG.error(err)
 
-        exit(1)
-
     # Show nice exit message.
     finally:
 
diff --git a/setup.py b/setup.py
index 87f6cc5..54471cf 100644
--- a/setup.py
+++ b/setup.py
@@ -178,7 +178,7 @@ try:
         if not any('source ~/.longbow/bash_completion'
                    in bashline for bashline in BASHFILE.readlines()):
 
-            BASHFILE.write('source ~/.longbow/bash_completion\n')
+            BASHFILE.write('source ~/.longbow/bash_completion')
 
 except IOError:
 


Test patch:
diff --git a/tests/unit/entrypoints/test_launcher.py b/tests/unit/entrypoints/test_launcher.py
index 0747316..17bdaeb 100644
--- a/tests/unit/entrypoints/test_launcher.py
+++ b/tests/unit/entrypoints/test_launcher.py
@@ -36,7 +36,6 @@ entrypoint module.
 """
 
 import os
-import pytest
 
 try:
 
@@ -246,14 +245,12 @@ def test_main_test5(m_isfile, m_update, m_recovery, m_longbow):
             "--log", "new-log.file", "--verbose"]
 
     with mock.patch('sys.argv', args):
-        with pytest.raises(SystemExit) as err:
-            launcher()
+
+        launcher()
 
     assert m_longbow.call_count == 0
     assert m_recovery.call_count == 0
     assert m_update.call_count == 0
-    assert err.type == SystemExit
-    assert err.value.code == 1
 
 
 @mock.patch('longbow.entrypoints.longbow')
@@ -273,8 +270,8 @@ def test_main_test6(m_isfile, m_longbowmain):
     m_longbowmain.side_effect = exceptions.PluginattributeError
 
     with mock.patch('sys.argv', args):
-        with pytest.raises(SystemExit) as err:
-            launcher()
+
+        launcher()
 
     params = m_longbowmain.call_args[0][1]
 
@@ -292,8 +289,6 @@ def test_main_test6(m_isfile, m_longbowmain):
     assert params["resource"] == "big-machine"
     assert params["replicates"] == ""
     assert params["verbose"] is False
-    assert err.type == SystemExit
-    assert err.value.code == 1
 
 
 @mock.patch('longbow.entrypoints.longbow')
@@ -313,8 +308,8 @@ def test_main_test7(m_isfile, m_longbowmain):
     m_longbowmain.side_effect = exceptions.PluginattributeError
 
     with mock.patch('sys.argv', args):
-        with pytest.raises(SystemExit) as err:
-            launcher()
+
+        launcher()
 
     params = m_longbowmain.call_args[0][1]
 
@@ -332,8 +327,6 @@ def test_main_test7(m_isfile, m_longbowmain):
     assert params["resource"] == "big-machine"
     assert params["replicates"] == ""
     assert params["verbose"] is False
-    assert err.type == SystemExit
-    assert err.value.code == 1
 
 
 @mock.patch('longbow.entrypoints.recovery')
@@ -351,13 +344,11 @@ def test_main_test8(m_isfile, m_longbowmain, m_recovery):
             "--debug"]
 
     with mock.patch('sys.argv', args):
-        with pytest.raises(SystemExit) as err:
-            launcher()
+
+        launcher()
 
     assert m_longbowmain.call_count == 0
     assert m_recovery.call_count == 0
-    assert err.type == SystemExit
-    assert err.value.code == 1
 
 
 @mock.patch('longbow.staging.cleanup')