Repository: CODAIT/exchange-metadata-converter

Issue:
Non-compliant metadata.name in the generated DLF YAML
The `metadata.name` in the generated DLF YAML does not comply with the Kubernetes spec for DNS-1123 subdomain names.


```JSON
{
  "kind": "Status",
  "apiVersion": "v1",
  "metadata": {},
  "status": "Failure",
  "message": "Dataset.com.ie.ibm.hpsys \"Finance Proposition Bank\" is invalid: metadata.name: Invalid value: \"Finance Proposition Bank\": a DNS-1123 subdomain must consist of lower case alphanumeric characters, '-' or '.', and must start and end with an alphanumeric character (e.g. 'example.com', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?(\\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*')",
  "reason": "Invalid",
  "details": {
    "name": "Finance Proposition Bank",
    "group": "com.ie.ibm.hpsys",
    "kind": "Dataset",
    "causes": [
      {
        "reason": "FieldValueInvalid",
        "message": "Invalid value: \"Finance Proposition Bank\": a DNS-1123 subdomain must consist of lower case alphanumeric characters, '-' or '.', and must start and end with an alphanumeric character (e.g. 'example.com', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?(\\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*')",
        "field": "metadata.name"
      }
    ]
  },
  "code": 422
}
```

@ptitzler 

Discussion:

Patch:
diff --git a/setup.py b/setup.py
index 1e62eb5..afb9bf4 100644
--- a/setup.py
+++ b/setup.py
@@ -22,7 +22,7 @@ with open('README.md') as readme:
 setup(
   name='exchange-metadata-converter',
   packages=find_packages(),
-  version='0.0.8',
+  version='0.0.9',
   license='Apache-2.0',
   description='exchange metadata converters',
   long_description=README,
diff --git a/templates/dlf_out.yaml b/templates/dlf_out.yaml
index b440965..0e8427a 100644
--- a/templates/dlf_out.yaml
+++ b/templates/dlf_out.yaml
@@ -14,7 +14,7 @@
 apiVersion: com.ie.ibm.hpsys/v1alpha1
 kind: Dataset
 metadata:
-  name: '{{name}}'
+  name: '{{id}}'
   labels:
     version: '{{version}}'
 spec:


Test patch:
diff --git a/tests/test_dlf.py b/tests/test_dlf.py
index 9e37f60..e593f79 100644
--- a/tests/test_dlf.py
+++ b/tests/test_dlf.py
@@ -48,7 +48,7 @@ class TestDLF(unittest.TestCase):
                              'com.ie.ibm.hpsys/v1alpha1')
             self.assertEqual(out_dict['kind'], 'Dataset')
             self.assertEqual(out_dict['metadata']['name'],
-                             self.in_yamls['name'])
+                             self.in_yamls['id'])
             self.assertEqual(out_dict['metadata']['labels']['version'],
                              self.in_yamls['version'])
             self.assertEqual(out_dict['spec']['type'],