Repository: Informasjonsforvaltning/dsop-api-spesifikasjoner

Issue:
Legge til endepunkt i produksjonsmiljø - Sparebank 1 Helgeland
Hei,
Kan dere tilgjengeliggjøre endepunktet for Sparebank 1 Helgeland - 937904029 i produksjonsmiljø?

Endepunkt: 
https://api.sparebank1.no/dsopaccountcontrolinfo/v2/AccountControlInfoService/v2/937904029

Discussion:

Patch:
diff --git a/README.md b/README.md
index cb9e1a3..2e4a9ae 100644
--- a/README.md
+++ b/README.md
@@ -19,14 +19,17 @@ A simple script is made to do the generation based on the banker.csv file and th
   - the name of the master specification file.
 
 ## Development
+
 ### Requirements
+
 - python3
 - [pyenv](https://github.com/pyenv/pyenv) (recommended)
 - [poetry](https://python-poetry.org/)
 - [nox](https://nox.thea.codes/en/stable/)
 
 ### Install
-```
+
+```shell
 % git clone https://github.com/Informasjonsforvaltning/dsop-api-spesifikasjoner.git
 % cd dsop-api-spesifikasjoner
 % pyenv install 3.9.6
@@ -34,24 +37,35 @@ A simple script is made to do the generation based on the banker.csv file and th
 % pyenv local 3.9.6 3.7.9
 % poetry install
 ```
+
 ### Run all sessions
-```
+
+```shell
 % nox
 ```
+
 ### Run all tests with coverage reporting
-```
+
+```shell
 % nox -rs tests
+
 ```
+
 ## Run cli script
-```
+
+```shell
 % poetry shell
 % dsop_api_spesifikasjoner --help
-```
+
+```shell
 Alternatively you can use `poetry run`:
-```
+
+```shell
 % poetry run dsop_api_spesifikasjoner --help
 ```
+
 Example:
-```
+
+```shell
 % dsop_api_spesifikasjoner -d specs template/Accounts\ API\ openapi\ v1.0.0.yaml banker.csv
 ```
diff --git a/banker.csv b/banker.csv
index 4364972..733dd38 100644
--- a/banker.csv
+++ b/banker.csv
@@ -98,7 +98,7 @@ OrgNummer,Navn,Filnavn,EndepunktProduksjon,EndepunktTest
 937895054,Søgne og Greipstad Sparebank,Sogne_og_Greipstad_Sparebank_937895054_Accounts-API.json,https://bf-esb-internet.edb.com/secesb/rest/era-dsop/v1/3090,
 937897286,Voss Sparebank,Voss_Sparebank_937897286_Accounts-API.json,https://bf-esb-internet.edb.com/secesb/rest/era-dsop/v1/3489,
 990323429,Gjensidige Bank,Gjensidige_Bank_990323429_Accounts-API.json,https://bf-esb-internet.edb.com/secesb/rest/era-dsop/v1/9776,
-937904029,Helgeland Sparebank,Helgeland_Sparebank_937904029_Accounts-API.json,https://bf-esb-internet.edb.com/secesb/rest/era-dsop/v1/4519,
+937904029,Helgeland Sparebank,Helgeland_Sparebank_937904029_Accounts-API.json,https://api.sparebank1.no/dsopaccountcontrolinfo/v2/AccountControlInfoService/v2/937904029,
 980374181,Landkreditt Bank,Landkreditt_Bank_980374181_Accounts-API.json,https://bf-esb-internet.edb.com/secesb/rest/era-dsop/v1/9360,
 911986884,OBOS-banken,OBOS-banken_911986884_Accounts-API.json,https://bf-esb-internet.edb.com/secesb/rest/era-dsop/v1/9824,
 937899319,Sparebanken Møre,Sparebanken_More_937899319_Accounts-API.json,https://bf-esb-internet.edb.com/secesb/rest/era-dsop/v1/3914,
diff --git a/specs/Helgeland_Sparebank_937904029_Accounts-API.json b/specs/Helgeland_Sparebank_937904029_Accounts-API.json
index 6e738a9..d09cfa3 100644
--- a/specs/Helgeland_Sparebank_937904029_Accounts-API.json
+++ b/specs/Helgeland_Sparebank_937904029_Accounts-API.json
@@ -7,7 +7,7 @@
   },
   "servers": [
     {
-      "url": "https://bf-esb-internet.edb.com/secesb/rest/era-dsop/v1/4519",
+      "url": "https://api.sparebank1.no/dsopaccountcontrolinfo/v2/AccountControlInfoService/v2/937904029",
       "description": "production"
     }
   ],
diff --git a/src/dsop_api_spesifikasjoner/generateSpecification.py b/src/dsop_api_spesifikasjoner/generateSpecification.py
index 66250c9..1205371 100644
--- a/src/dsop_api_spesifikasjoner/generateSpecification.py
+++ b/src/dsop_api_spesifikasjoner/generateSpecification.py
@@ -98,7 +98,7 @@ def _add_spec_to_catalog(
     )
     api = API(url)
     api.publisher = f"https://organization-catalogue.fellesdatakatalog.digdir.no/organizations/{orgnummer}"  # noqa: B950
-    api.conformsTo.append("https://bitsnorge.github.io/dsop-accounts-api/")
+    api.conformsTo.append("https://bitsnorge.github.io/dsop-accounts-api")
     catalog.apis.append(api)
 
 


Test patch:
diff --git a/tests/test_generateSpecification.py b/tests/test_generateSpecification.py
index c76c529..0a81564 100644
--- a/tests/test_generateSpecification.py
+++ b/tests/test_generateSpecification.py
@@ -157,7 +157,7 @@ def test_main(mocker: MockerFixture, runner: CliRunner) -> None:
             "publisher": "https://organization-catalogue.fellesdatakatalog.digdir.no/organizations/837884942",
             "url": "%s",
             "conformsTo": [
-               "https://bitsnorge.github.io/dsop-accounts-api/"
+               "https://bitsnorge.github.io/dsop-accounts-api"
             ]
            }
           ]
@@ -199,7 +199,7 @@ def test_main(mocker: MockerFixture, runner: CliRunner) -> None:
             "publisher": "https://organization-catalogue.fellesdatakatalog.digdir.no/organizations/837884942",
             "url": "%s",
             "conformsTo": [
-               "https://bitsnorge.github.io/dsop-accounts-api/"
+               "https://bitsnorge.github.io/dsop-accounts-api"
             ]
            }
           ]