Repository: dr-prodigy/python-holidays

Issue:
2 april 2021 in spain
hi, 
dt.date(2021, 4, 2) in holidays.ES() don't work

Discussion:

Patch:
diff --git a/.github/workflows/ci-cd.yml b/.github/workflows/ci-cd.yml
index d9f561c6..91493ede 100644
--- a/.github/workflows/ci-cd.yml
+++ b/.github/workflows/ci-cd.yml
@@ -11,7 +11,7 @@ jobs:
       - name: Set up Python
         uses: actions/setup-python@v2
       - name: Run pre-commit
-        uses: pre-commit/action@v2.0.3
+        uses: pre-commit/action@v2.0.0
 
   test:
     name: "Test: python=${{ matrix.python-version }} on ${{ matrix.os }}"
diff --git a/CHANGES b/CHANGES
index 4d38f383..c7ff0f2a 100644
--- a/CHANGES
+++ b/CHANGES
@@ -1,13 +1,3 @@
-Version 0.11.2
-==============
-
-Released ????, ????
-
-- Poland fix #464 (m-ganko)
-- Singapore updates for 2022 #456 (mborsetti)
-- .gitignore fix #462 (TheLastProject)
-- Pre-commit v.2.0.3 (dr-p)
-
 Version 0.11.1
 ==============
 
diff --git a/holidays/__init__.py b/holidays/__init__.py
index 72e68808..e43e3ee2 100644
--- a/holidays/__init__.py
+++ b/holidays/__init__.py
@@ -29,4 +29,4 @@ from holidays.constants import (
 from holidays.holiday_base import HolidayBase, createHolidaySum
 from holidays.utils import list_supported_countries, CountryHoliday
 
-__version__ = "0.11.2"
+__version__ = "0.11.1"
diff --git a/holidays/countries/poland.py b/holidays/countries/poland.py
index 4b41b161..2ba6cd83 100644
--- a/holidays/countries/poland.py
+++ b/holidays/countries/poland.py
@@ -50,9 +50,6 @@ class Poland(HolidayBase):
         self[date(year, NOV, 1)] = "Uroczystość Wszystkich świętych"
         if (1937 <= year <= 1945) or year >= 1989:
             self[date(year, NOV, 11)] = "Narodowe Święto Niepodległości"
-        if year == 2018:
-            name = "Narodowe Święto Niepodległości - 100-lecie"
-            self[date(year, NOV, 12)] = name
 
         self[date(year, DEC, 25)] = "Boże Narodzenie (pierwszy dzień)"
         self[date(year, DEC, 26)] = "Boże Narodzenie (drugi dzień)"
diff --git a/holidays/countries/singapore.py b/holidays/countries/singapore.py
index 65d4fedf..30640382 100644
--- a/holidays/countries/singapore.py
+++ b/holidays/countries/singapore.py
@@ -45,7 +45,7 @@ class Singapore(HolidayBase):
 
     # Holidays prior to 2000 may not be accurate.
 
-    # Holidays after 2022: the following four moving date holidays whose exact
+    # Holidays after 2021: the following four moving date holidays whose exact
     # date is announced yearly are estimated (and so denoted):
     # - Hari Raya Puasa*
     # - Hari Raya Haji*
@@ -94,7 +94,6 @@ class Singapore(HolidayBase):
             2019: [(JUN, 5)],
             2020: [(MAY, 24)],
             2021: [(MAY, 13)],
-            2022: [(MAY, 2)],
         }
         if year in dates_obs:
             for date_obs in dates_obs[year]:
@@ -142,7 +141,6 @@ class Singapore(HolidayBase):
             2019: [(AUG, 11)],
             2020: [(JUL, 31)],
             2021: [(JUL, 20)],
-            2022: [(JUL, 9)],
         }
         if year in dates_obs:
             for date_obs in dates_obs[year]:
@@ -192,7 +190,6 @@ class Singapore(HolidayBase):
             2019: (MAY, 19),
             2020: (MAY, 7),
             2021: (MAY, 26),
-            2022: (MAY, 15),
         }
         if year in dates_obs:
             hol_date = date(year, *dates_obs[year])
@@ -229,7 +226,6 @@ class Singapore(HolidayBase):
             2019: (OCT, 27),
             2020: (NOV, 14),
             2021: (NOV, 4),
-            2022: (NOV, 24),
         }
         if year in dates_obs:
             hol_date = date(year, *dates_obs[year])
diff --git a/holidays/countries/spain.py b/holidays/countries/spain.py
index 794032b1..6b2c8dd0 100644
--- a/holidays/countries/spain.py
+++ b/holidays/countries/spain.py
@@ -117,7 +117,7 @@ class Spain(HolidayBase):
             self._is_observed(date(year, MAR, 19), "San José")
         if self.prov and self.prov not in ["CT", "VC"]:
             self[easter(year) + rd(weeks=-1, weekday=TH)] = "Jueves Santo"
-            self[easter(year) + rd(weeks=-1, weekday=FR)] = "Viernes Santo"
+        self[easter(year) + rd(weeks=-1, weekday=FR)] = "Viernes Santo"
         if self.prov and self.prov in ["CT", "PV", "NC", "VC", "IB", "CM"]:
             self[easter(year) + rd(weekday=MO)] = "Lunes de Pascua"
         self._is_observed(date(year, MAY, 1), "Día del Trabajador")


Test patch:
diff --git a/test/countries/test_poland.py b/test/countries/test_poland.py
index 32dd55c4..e1f08601 100644
--- a/test/countries/test_poland.py
+++ b/test/countries/test_poland.py
@@ -39,11 +39,6 @@ class TestPL(unittest.TestCase):
         self.assertIn(date(2017, 12, 25), self.holidays)
         self.assertIn(date(2017, 12, 26), self.holidays)
 
-        self.assertNotIn(date(2017, 11, 12), self.holidays)
-
-    def test_2018(self):
-        self.assertIn(date(2018, 11, 12), self.holidays)
-
     def test_polish_deprecated(self):
         with warnings.catch_warnings(record=True) as w:
             warnings.simplefilter("always")
diff --git a/test/countries/test_singapore.py b/test/countries/test_singapore.py
index ea8d28a2..e22628d8 100644
--- a/test/countries/test_singapore.py
+++ b/test/countries/test_singapore.py
@@ -48,7 +48,7 @@ class TestSingapore(unittest.TestCase):
         self.assertIn(date(2018, 8, 22), self.holidays)
         self.assertIn(date(2018, 11, 6), self.holidays)
         self.assertIn(date(2018, 12, 25), self.holidays)
-        # 2018: total holidays (11 + 0 falling on a Sunday)
+        # total holidays (11 + 0 falling on a Sunday)
         self.assertEqual(len(holidays.Singapore(years=[2018])), 11 + 0)
         # 2019
         self.assertIn(date(2019, 1, 1), self.holidays)
@@ -62,7 +62,7 @@ class TestSingapore(unittest.TestCase):
         self.assertIn(date(2019, 8, 11), self.holidays)
         self.assertIn(date(2019, 10, 27), self.holidays)
         self.assertIn(date(2019, 12, 25), self.holidays)
-        # 2019: total holidays (11 + 3 falling on a Sunday)
+        # total holidays (11 + 3 falling on a Sunday)
         self.assertEqual(len(holidays.Singapore(years=[2019])), 11 + 3)
         # 2020
         self.assertIn(date(2020, 1, 1), self.holidays)
@@ -76,43 +76,11 @@ class TestSingapore(unittest.TestCase):
         self.assertIn(date(2020, 8, 9), self.holidays)
         self.assertIn(date(2020, 11, 14), self.holidays)
         self.assertIn(date(2020, 12, 25), self.holidays)
-        # 2020: total holidays (11 + 3 falling on a Sunday)
+        # total holidays (11 + 3 falling on a Sunday)
         self.assertEqual(len(holidays.Singapore(years=[2020])), 11 + 4)
-        # 2021
-        self.assertIn(date(2021, 1, 1), self.holidays)
-        self.assertIn(date(2021, 2, 12), self.holidays)
-        self.assertIn(date(2021, 2, 13), self.holidays)
-        self.assertIn(date(2021, 4, 2), self.holidays)
-        self.assertIn(date(2021, 5, 1), self.holidays)
-        self.assertIn(date(2021, 5, 13), self.holidays)
+        # holidays estimated using lunar calendar
         self.assertIn(date(2021, 5, 26), self.holidays)
-        self.assertIn(date(2021, 7, 20), self.holidays)
-        self.assertIn(date(2021, 8, 9), self.holidays)
         self.assertIn(date(2021, 11, 4), self.holidays)
-        self.assertIn(date(2021, 12, 25), self.holidays)
-        # 2021: total holidays (11)
-        self.assertEqual(len(holidays.Singapore(years=[2021])), 11)
-        # 2022
-        self.assertIn(date(2022, 1, 1), self.holidays)
-        self.assertIn(date(2022, 2, 1), self.holidays)
-        self.assertIn(date(2022, 2, 2), self.holidays)
-        self.assertIn(date(2022, 4, 15), self.holidays)
-        self.assertIn(date(2022, 5, 1), self.holidays)
-        self.assertIn(date(2022, 5, 2), self.holidays)
-        self.assertIn(date(2022, 5, 3), self.holidays)
-        self.assertIn(date(2022, 5, 15), self.holidays)
-        self.assertIn(date(2022, 5, 16), self.holidays)
-        self.assertIn(date(2022, 7, 9), self.holidays)
-        self.assertIn(date(2022, 8, 9), self.holidays)
-        self.assertIn(date(2022, 11, 24), self.holidays)
-        self.assertIn(date(2022, 12, 25), self.holidays)
-        self.assertIn(date(2022, 12, 26), self.holidays)
-        # 2022: total holidays (11 + 3 falling on a Sunday)
-        self.assertEqual(len(holidays.Singapore(years=[2022])), 11 + 3)
-
-        # holidays estimated using lunar calendar
-        self.assertIn(date(2023, 6, 2), self.holidays)  # Vesak Day
-        self.assertIn(date(2023, 11, 11), self.holidays)  # Deepavali
         # holidays estimated using library hijri-converter
         if sys.version_info >= (3, 6):
             import importlib.util
@@ -121,9 +89,5 @@ class TestSingapore(unittest.TestCase):
                 # <= 1968 holidays
                 self.assertIn(date(1968, 1, 2), self.holidays)
                 # 2021
-                self.assertIn(
-                    date(2023, 4, 21), self.holidays
-                )  # Hari Raya Puasa
-                self.assertIn(
-                    date(2023, 6, 28), self.holidays
-                )  # Hari Raya Haji
+                self.assertIn(date(2021, 5, 13), self.holidays)
+                self.assertIn(date(2021, 7, 20), self.holidays)
diff --git a/test/countries/test_spain.py b/test/countries/test_spain.py
index 7e8baaa5..355e1359 100644
--- a/test/countries/test_spain.py
+++ b/test/countries/test_spain.py
@@ -63,9 +63,7 @@ class TestES(unittest.TestCase):
             self.assertEqual(
                 date(2016, 3, 24) in prov_holidays, prov not in ["CT", "VC"]
             )
-            self.assertEqual(
-                date(2016, 3, 25) in prov_holidays, prov not in ["CT", "VC"]
-            )
+            assert date(2016, 3, 25) in prov_holidays
             self.assertEqual(
                 date(2016, 3, 28) in prov_holidays,
                 prov in ["CT", "PV", "NC", "VC", "IB", "CM"],