Repository: ESMValGroup/ESMValCore

Issue:
An issue in ACCESS-ESM extra_facets
**Describe the bug**
In file (https://github.com/ESMValGroup/ESMValCore/tree/main/esmvalcore/config/extra_facets/access-mappings.yml)

the title `ACCESS_ESM` should be changed to `ACCESS-ESM1-5`.


**Please attach**
  - The recipe that you are trying to run, you can find a copy in the `run` directory in the output directory
  - The `main_log_debug.txt` file, this can also be found in the `run` directory in the output directory


Discussion:
rbeucher: Thanks @rhaegar325. Why this was not picked by the tests?
rbeucher: Tests are failing. @rhaegar325 please have a loop as soon as possible.
rbeucher: Also. Can you explain the bug in more details, please? for the records
rbeucher: @rhaegar325 We usually use `dataset: ACCESS-ESM1-5` not `ACCESS_ESM1_5`
rhaegar325: @rbeucher, now this error has been fixed. The bug is caused by we deside to change the file name of our cmoriser from `access_esm.py` to `access_esm1_5.py`. but I did not change the title in  extra_facets `access-mapping.yml`, so when we use the cmoriser it can not load the extra_facets. Also, in `test_access_esm1_5.py`, I did not change the dataset name tp `ACCESS-ESM1-5`, so the tast didn't pick this error up. silly mistake, won't happen again.


Patch:
diff --git a/esmvalcore/config/extra_facets/access-mappings.yml b/esmvalcore/config/extra_facets/access-mappings.yml
index acb5dd156..9d4eb0621 100644
--- a/esmvalcore/config/extra_facets/access-mappings.yml
+++ b/esmvalcore/config/extra_facets/access-mappings.yml
@@ -4,7 +4,7 @@
 # ESMValCore/doc/quickstart/find_data.rst).
 ---
 
-ACCESS_ESM:
+ACCESS-ESM1-5:
 
   '*':
    


Test patch:
diff --git a/tests/integration/cmor/_fixes/access/test_access_esm1_5.py b/tests/integration/cmor/_fixes/access/test_access_esm1_5.py
index ef124e712..01fb0e052 100644
--- a/tests/integration/cmor/_fixes/access/test_access_esm1_5.py
+++ b/tests/integration/cmor/_fixes/access/test_access_esm1_5.py
@@ -55,7 +55,7 @@ def _get_fix(mip, frequency, short_name, fix_name):
     """Load a fix from :mod:`esmvalcore.cmor._fixes.access.access_esm1_5`."""
     dataset = Dataset(
         project='ACCESS',
-        dataset='ACCESS_ESM',
+        dataset='ACCESS-ESM1-5',
         mip=mip,
         short_name=short_name,
     )
@@ -98,11 +98,11 @@ def check_tas_metadata(cubes):
     return cube
 
 
-def check_hus_metadata(cubes):
-    """Check hus metadata."""
+def check_pr_metadata(cubes):
+    """Check pr metadata."""
     assert len(cubes) == 1
     cube = cubes[0]
-    assert cube.var_name == 'hus'
+    assert cube.var_name == 'pr'
     assert cube.standard_name == 'precipitation_flux'
     assert cube.long_name == 'Precipitation'
     assert cube.units == 'kg m-2 s-1'
@@ -162,7 +162,7 @@ def assert_plev_metadata(cube):
 
 def test_only_time(monkeypatch, cubes_2d):
     """Test fix."""
-    fix = get_fix_allvar('Amon', 'mon', 'tas')
+    fix = get_fix_allvar('Amon', 'mon', 'pr')
 
     coord_info = CoordinateInfo('time')
     coord_info.standard_name = 'time'
@@ -172,7 +172,7 @@ def test_only_time(monkeypatch, cubes_2d):
     fixed_cubes = fix.fix_metadata(cubes)
 
     # Check cube metadata
-    cube = check_tas_metadata(fixed_cubes)
+    cube = check_pr_metadata(fixed_cubes)
 
     # Check cube data
     assert cube.shape == (1, 145, 192)
@@ -186,7 +186,7 @@ def test_only_time(monkeypatch, cubes_2d):
 
 def test_only_latitude(monkeypatch, cubes_2d):
     """Test fix."""
-    fix = get_fix_allvar('Amon', 'mon', 'tas')
+    fix = get_fix_allvar('Amon', 'mon', 'pr')
 
     coord_info = CoordinateInfo('latitude')
     coord_info.standard_name = 'latitude'
@@ -196,7 +196,7 @@ def test_only_latitude(monkeypatch, cubes_2d):
     fixed_cubes = fix.fix_metadata(cubes)
 
     # Check cube metadata
-    cube = check_tas_metadata(fixed_cubes)
+    cube = check_pr_metadata(fixed_cubes)
 
     # Check cube data
     assert cube.shape == (1, 145, 192)
@@ -211,7 +211,7 @@ def test_only_latitude(monkeypatch, cubes_2d):
 
 def test_only_longitude(monkeypatch, cubes_2d):
     """Test fix."""
-    fix = get_fix_allvar('Amon', 'mon', 'tas')
+    fix = get_fix_allvar('Amon', 'mon', 'pr')
 
     coord_info = CoordinateInfo('longitude')
     coord_info.standard_name = 'longitude'
@@ -221,7 +221,7 @@ def test_only_longitude(monkeypatch, cubes_2d):
     fixed_cubes = fix.fix_metadata(cubes)
 
     # Check cube metadata
-    cube = check_tas_metadata(fixed_cubes)
+    cube = check_pr_metadata(fixed_cubes)
 
     # Check cube data
     assert cube.shape == (1, 145, 192)