Repository: codecov/uploader (ts)

Issue:
Uploader does not allow all possible values to be passed as override urls.
**Describe the bug**
A clear and concise description of what the bug is.

Uploader does not allow all possible values to be passed as override urls.

**To Reproduce**
Steps to reproduce the behavior:

`-v -u 10.10.5.20`
`-v -u localhost`

**Expected behavior**
A clear and concise description of what you expected to happen.

I would expect both of those examples to correctly try to override. Both default to codecov.io. There may be other cases as well, these were the ones I tested 

Pull request description:
fix: remove unnecessary validation
A future PR could
- use the ECMAScript URL class constructor to validate URLs passed by the user
- modify the upload-related functions to accept ECMAScript URL objects in place of their current string parameters

Fixes #452

Patch:
diff --git a/.circleci/config.yml b/.circleci/config.yml
index 1b8e733..5d80523 100644
--- a/.circleci/config.yml
+++ b/.circleci/config.yml
@@ -443,7 +443,7 @@ jobs:
             - release_tag
   release:
     docker:
-      - image: google/cloud-sdk:362.0.0-slim
+      - image: google/cloud-sdk:361.0.0-slim
     steps:
       - attach_workspace:
           # Must be absolute path or relative path from working_directory
@@ -462,9 +462,6 @@ jobs:
     machine: true
     steps:
       - checkout
-      - attach_workspace:
-          # Must be absolute path or relative path from working_directory
-          at: .
       - run:
           name: Clone Autotest and Start Acceptance Testing Containers
           command: |
@@ -487,8 +484,6 @@ workflows:
           context:
             - 'DockerHub Push Context'
             - 'Github Checkout'
-          requires:
-            - build-alpine
       - build-linux-and-osx
       - build-alpine:
           requires:
diff --git a/CHANGELOG.md b/CHANGELOG.md
index a17f3f7..76562d2 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -2,20 +2,6 @@
 
 All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.
 
-### [0.1.9](https://github.com/codecov/uploader/compare/v0.1.8...v0.1.9) (2021-11-01)
-
-### Features
-
-- add herokuci provider ([fdabd2e](https://github.com/codecov/uploader/commit/fdabd2ee3fc94a0d03565017bf54e18010b9daf6))
-- add network filter ([3bbc222](https://github.com/codecov/uploader/commit/3bbc22247f76d6ea33e6061fad22857c222a2ac0))
-- add network prefix ([4d5ee16](https://github.com/codecov/uploader/commit/4d5ee16bc0d96bca7b477017ba664f602b80b11f))
-- ignore `*.egg-info` ([54060a8](https://github.com/codecov/uploader/commit/54060a86a52bbeb6763454f4284fe290cb8760ef))
-
-### Bug Fixes
-
-- enable `dot` ([549894c](https://github.com/codecov/uploader/commit/549894ce2a2a0f2a3b93f4e88861d419f7b2a0be))
-- use correct variable for args so verbose logs show ([e8455ef](https://github.com/codecov/uploader/commit/e8455ef3cf717eeedceb2c43221a29f64264b077))
-
 ### [0.1.8](https://github.com/codecov/uploader/compare/v0.1.7...v0.1.8) (2021-10-21)
 
 ### Features
diff --git a/Makefile b/Makefile
index 22c36b2..ba1cfdf 100644
--- a/Makefile
+++ b/Makefile
@@ -32,4 +32,4 @@ build_alpine:
 .PHONY: run-standards-comparison
 run-standards-comparison:
 	docker pull codecov/autotest:standards-latest > /dev/null 2>&1
-	docker run --network autotest_codecov -e HOST_URL=http://web.local:5000 -e IS_UPLOADER=true -it -v "$(PWD)/out:/usr/app/out" codecov/autotest:standards-latest
+	docker run --network autotest_codecov -e HOST_URL=http://web.local:5000 codecov/autotest:standards-latest
diff --git a/npm-shrinkwrap.json b/npm-shrinkwrap.json
index aa12abc..b34219d 100644
--- a/npm-shrinkwrap.json
+++ b/npm-shrinkwrap.json
@@ -1,12 +1,12 @@
 {
   "name": "codecov",
-  "version": "0.1.9",
+  "version": "0.1.8",
   "lockfileVersion": 2,
   "requires": true,
   "packages": {
     "": {
       "name": "codecov",
-      "version": "0.1.9",
+      "version": "0.1.8",
       "license": "ISC",
       "dependencies": {
         "fast-glob": "3.2.7",
diff --git a/package.json b/package.json
index 5a8250c..7d6ceb7 100644
--- a/package.json
+++ b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "codecov",
-  "version": "0.1.9",
+  "version": "0.1.8",
   "description": "Codecov Report Uploader",
   "private": true,
   "bin": "dist/bin/codecov.js",
diff --git a/src/ci_providers/index.ts b/src/ci_providers/index.ts
index 797b99c..d5a547e 100644
--- a/src/ci_providers/index.ts
+++ b/src/ci_providers/index.ts
@@ -10,7 +10,6 @@ import * as providerCodeBuild from './provider_codebuild'
 import * as providerDrone from './provider_drone'
 import * as providerGitHubactions from './provider_githubactions'
 import * as providerGitLabci from './provider_gitlabci'
-import * as providerHerokuci from './provider_herokuci'
 import * as providerJenkinsci from './provider_jenkinsci'
 import * as providerLocal from './provider_local'
 import * as providerTeamCity from './provider_teamcity'
@@ -29,7 +28,6 @@ const providerList: IProvider[] = [
   providerDrone,
   providerGitHubactions,
   providerGitLabci,
-  providerHerokuci,
   providerJenkinsci,
   providerTeamCity,
   providerTravisci,
diff --git a/src/ci_providers/provider_appveyorci.ts b/src/ci_providers/provider_appveyorci.ts
index 88cb4dd..53a8575 100644
--- a/src/ci_providers/provider_appveyorci.ts
+++ b/src/ci_providers/provider_appveyorci.ts
@@ -52,7 +52,7 @@ function _getService() {
   return 'appveyor'
 }
 
-export function getServiceName(): string {
+export function getServiceName() {
   return 'Appveyor CI'
 }
 
diff --git a/src/ci_providers/provider_buildkite.ts b/src/ci_providers/provider_buildkite.ts
index a2d79f2..67f57fd 100644
--- a/src/ci_providers/provider_buildkite.ts
+++ b/src/ci_providers/provider_buildkite.ts
@@ -101,8 +101,8 @@ function _getSHA(inputs: UploaderInputs): string {
  */
 function _getSlug(inputs: UploaderInputs): string {
   const { args, environment: envs } = inputs
-  if (args.slug || envs.BUILDKITE_PIPELINE_SLUG) {
-    return args.slug || envs.BUILDKITE_PIPELINE_SLUG || ''
+  if (args.slug || envs.BUILDKITE_PROJECT_SLUG) {
+    return args.slug || envs.BUILDKITE_PROJECT_SLUG || ''
   }
   throw new Error('Unable to detect slug, please set manually with the -r flag')
 }
@@ -125,7 +125,7 @@ export function getServiceParams(inputs: UploaderInputs): IServiceParams {
   }
 }
 
-export function getEnvVarNames(): string[] {
+export function getEnvVarNames() {
   return [
     'BUILDKITE',
     'BUILDKITE_BRANCH',
diff --git a/src/ci_providers/provider_herokuci.ts b/src/ci_providers/provider_herokuci.ts
deleted file mode 100644
index 09a4e5d..0000000
--- a/src/ci_providers/provider_herokuci.ts
+++ /dev/null
@@ -1,69 +0,0 @@
-import { parseSlugFromRemoteAddr } from '../helpers/git'
-import { IServiceParams, UploaderEnvs, UploaderInputs } from '../types'
-
-export function detect(envs: UploaderEnvs): boolean {
-  return Boolean(envs.CI) && envs.HEROKU_TEST_RUN_BRANCH != ''
-}
-
-function _getBuild(inputs: UploaderInputs): string {
-  const { args, environment: envs} = inputs
-  return args.build || envs.HEROKU_TEST_RUN_ID || ''
-}
-
-function _getBuildURL(): string {
-  return ''
-}
-
-function _getBranch(inputs: UploaderInputs): string {
-  const { args, environment: envs} = inputs
-  return args.branch || envs.HEROKU_TEST_RUN_BRANCH || ''
-}
-
-function _getJob() {
-  return ''
-}
-
-function _getPR(inputs: UploaderInputs): string {
-  const { args } = inputs
-  return args.pr || ''
-}
-
-function _getService(): string {
-  return 'heroku'
-}
-
-export function getServiceName(): string {
-  return 'Heroku CI'
-}
-
-function _getSHA(inputs: UploaderInputs): string {
-  const { args, environment: envs} = inputs
-  return args.sha || envs.HEROKU_TEST_RUN_COMMIT_VERSION || ''
-}
-
-function _getSlug(inputs: UploaderInputs): string {
-  const { args } = inputs
-  return args.slug || parseSlugFromRemoteAddr('') || ''
-}
-
-export function getServiceParams(inputs: UploaderInputs): IServiceParams {
-  return {
-    branch: _getBranch(inputs),
-    build: _getBuild(inputs),
-    buildURL: _getBuildURL(),
-    commit: _getSHA(inputs),
-    job: _getJob(),
-    pr: _getPR(inputs),
-    service: _getService(),
-    slug: _getSlug(inputs),
-  }
-}
-
-export function getEnvVarNames(): string[] {
-  return [
-    'CI',
-    'HEROKU_TEST_RUN_BRANCH',
-    'HEROKU_TEST_RUN_COMMIT_VERSION',
-    'HEROKU_TEST_RUN_ID',
-  ]
-}
diff --git a/src/ci_providers/provider_template.ts b/src/ci_providers/provider_template.js
similarity index 77%
rename from src/ci_providers/provider_template.ts
rename to src/ci_providers/provider_template.js
index 95acfde..c5feecf 100644
--- a/src/ci_providers/provider_template.ts
+++ b/src/ci_providers/provider_template.js
@@ -1,5 +1,3 @@
-import { IServiceParams, UploaderEnvs, UploaderInputs } from '../types'
-
 /**
  * Detects if this CI provider is being used
  *
@@ -7,8 +5,8 @@ import { IServiceParams, UploaderEnvs, UploaderInputs } from '../types'
  * @returns boolean
  */
 
-// eslint-disable-next-line @typescript-eslint/no-unused-vars
-export function detect(envs: UploaderEnvs): boolean {
+// eslint-disable-next-line no-unused-vars
+function detect(envs) {
   return false
 }
 
@@ -18,7 +16,7 @@ export function detect(envs: UploaderEnvs): boolean {
  * @param {args: {}, envs: {}} inputs an object of arguments and enviromental variable key/value pairs
  * @returns {string}
  */
-function _getBuild(inputs: UploaderInputs): string {
+function _getBuild(inputs) {
   const { args } = inputs
   return args.build || ''
 }
@@ -29,8 +27,8 @@ function _getBuild(inputs: UploaderInputs): string {
  * @param {args: {}, envs: {}} inputs an object of arguments and enviromental variable key/value pairs
  * @returns {string}
  */
-// eslint-disable-next-line @typescript-eslint/no-unused-vars
-function _getBuildURL(inputs: UploaderInputs): string {
+// eslint-disable-next-line no-unused-vars
+function _getBuildURL(inputs) {
   return ''
 }
 
@@ -40,7 +38,7 @@ function _getBuildURL(inputs: UploaderInputs): string {
  * @param {args: {}, envs: {}} inputs an object of arguments and enviromental variable key/value pairs
  * @returns {string}
  */
-function _getBranch(inputs: UploaderInputs): string {
+function _getBranch(inputs) {
   const { args } = inputs
   try {
     return args.branch || ''
@@ -57,8 +55,8 @@ function _getBranch(inputs: UploaderInputs): string {
  * @param {*} envs an object of enviromental variable key/value pairs
  * @returns {string}
  */
-// eslint-disable-next-line @typescript-eslint/no-unused-vars
-function _getJob(envs: UploaderEnvs): string {
+// eslint-disable-next-line no-unused-vars
+function _getJob(envs) {
   return ''
 }
 
@@ -68,8 +66,8 @@ function _getJob(envs: UploaderEnvs): string {
  * @param {args: {}, envs: {}} inputs an object of arguments and enviromental variable key/value pairs
  * @returns {string}
  */
-// eslint-disable-next-line @typescript-eslint/no-unused-vars
-function _getPR(inputs: UploaderInputs): string {
+// eslint-disable-next-line no-unused-vars
+function _getPR(inputs) {
   const { args } = inputs
   try {
     return args.pr || ''
@@ -83,7 +81,7 @@ function _getPR(inputs: UploaderInputs): string {
  *
  * @returns {string}
  */
-function _getService(): string {
+function _getService() {
   return ''
 }
 
@@ -92,7 +90,7 @@ function _getService(): string {
  *
  * @returns
  */
-export function getServiceName(): string {
+function getServiceName() {
   return ''
 }
 /**
@@ -101,7 +99,7 @@ export function getServiceName(): string {
  * @param {args: {}, envs: {}} inputs an object of arguments and enviromental variable key/value pairs
  * @returns {string}
  */
-function _getSHA(inputs: UploaderInputs): string {
+function _getSHA(inputs) {
   const { args } = inputs
   try {
     return args.sha || ''
@@ -117,7 +115,7 @@ function _getSHA(inputs: UploaderInputs): string {
  * @param {args: {}, envs: {}} inputs an object of arguments and enviromental variable key/value pairs
  * @returns {string}
  */
-function _getSlug(inputs: UploaderInputs): string {
+function _getSlug(inputs) {
   const { args } = inputs
   try {
     return args.slug || ''
@@ -131,13 +129,13 @@ function _getSlug(inputs: UploaderInputs): string {
  * @param {args: {}, envs: {}} inputs an object of arguments and enviromental variable key/value pairs
  * @returns {{ branch: string, build: string, buildURL: string, commit: string, job: string, pr: string, service: string, slug: string }}
  */
-export function getServiceParams(inputs: UploaderInputs): IServiceParams {
+function getServiceParams(inputs) {
   return {
     branch: _getBranch(inputs),
     build: _getBuild(inputs),
     buildURL: _getBuildURL(inputs),
     commit: _getSHA(inputs),
-    job: _getJob(inputs.environment),
+    job: _getJob(inputs.envs),
     pr: _getPR(inputs),
     service: _getService(),
     slug: _getSlug(inputs),
diff --git a/src/helpers/cli.ts b/src/helpers/cli.ts
index 2d08b58..f3da199 100644
--- a/src/helpers/cli.ts
+++ b/src/helpers/cli.ts
@@ -122,18 +122,6 @@ const args: ICLIArgument[] = [
     default: false,
     description: 'Move discovered coverage reports to the trash',
   },
-  {
-    alias: 'i',
-    name: 'networkFiler',
-    type: 'string',
-    description: 'Specify a filter on the files listed in the network section of the Codecov report. Useful for upload-specific path fixing',
-  },
-  {
-    alias: 'k',
-    name: 'networkPrefix',
-    type: 'string',
-    description: 'Specify a prefix on files listed in the network section of the Codecov report. Useful to help resolve path fixing',
-  },
   {
     alias: 'X',
     name: 'feature',
diff --git a/src/helpers/files.ts b/src/helpers/files.ts
index 70bafcb..1acb135 100644
--- a/src/helpers/files.ts
+++ b/src/helpers/files.ts
@@ -241,26 +241,13 @@ export function getAllFiles(
     error,
   } = spawnSync('git', ['-C', dirPath, 'ls-files'], { encoding: 'utf8' })
 
-  let files = []
-  if (error instanceof Error || status !== 0) {
-    files = glob
+  return error instanceof Error || status !== 0
+    ? glob
       .sync(['**/*', '**/.[!.]*'], {
         cwd: dirPath,
         ignore: manualBlacklist().map(globstar),
       })
-  } else {
-    files = stdout.split(/[\r\n]+/)
-  }
-
-  if (args.networkFilter) {
-    files = files.filter(file => file.startsWith(String(args.networkFilter)))
-  }
-
-  if (args.networkPrefix) {
-    files = files.map(file => String(args.networkPrefix) + file)
-  }
-  
-  return files
+    : stdout.split(/[\r\n]+/)
 }
 
 /**
diff --git a/src/index.ts b/src/index.ts
index 865a6fe..6b533e4 100644
--- a/src/index.ts
+++ b/src/index.ts
@@ -57,8 +57,6 @@ function dryRun(
  * @param {string} args.file Target file(s) to upload
  * @param {string} args.flags Flag the upload to group coverage metrics
  * @param {string} args.name Custom defined name of the upload. Visible in Codecov UI
- * @param {string} args.networkFilter Specify a filter on the files listed in the network section of the Codecov report. Useful for upload-specific path fixing
- * @param {string} args.networkPrefix Specify a prefix on files listed in the network section of the Codecov report. Useful to help resolve path fixing
  * @param {string} args.parent The commit SHA of the parent for which you are uploading coverage.
  * @param {string} args.pr Specify the pull request number mannually
  * @param {string} args.token Codecov upload token
@@ -100,7 +98,7 @@ export async function main(
   const inputs: UploaderInputs = { args, environment: envs }
 
   let uploadHost: string
-  if (args.url && validateHelpers.validateURL(args.url)) {
+  if (args.url) {
     uploadHost = args.url
   } else {
     uploadHost = 'https://codecov.io'
diff --git a/src/types.ts b/src/types.ts
index eb4d207..ad2df8a 100644
--- a/src/types.ts
+++ b/src/types.ts
@@ -7,8 +7,6 @@ export interface UploaderArgs {
   file?: string | string[] // Target file(s) to upload
   flags: string | string[] // Flag the upload to group coverage metrics
   name?: string // Custom defined name of the upload. Visible in Codecov UI
-  networkFilter?: string // Specify a prefix on the files listed in the network section of the Codecov report. Useful for upload-specific path fixing
-  networkPrefix?: string // Specify a prefix on files listed in the network section of the Codecov report. Useful to help resolve path fixing
   parent?: string // The commit SHA of the parent for which you are uploading coverage.
   pr?: string // Specify the pull request number mannually
   token?: string // Codecov upload token


Test patch:
diff --git a/test/helpers/files.test.ts b/test/helpers/files.test.ts
index 939eaa0..9d65428 100644
--- a/test/helpers/files.test.ts
+++ b/test/helpers/files.test.ts
@@ -56,34 +56,6 @@ describe('File Helpers', () => {
     ).toBe(files.join('\n'))
   })
 
-  it('can get a file listing with a file filter', async () => {
-    const files = ['npm-shrinkwrap.json', 'package.json', 'package-lock.json', 'src/file.js']
-    td.replace(childProcess, 'spawnSync', () => {
-      return {
-        stdout: files.join('\n'),
-        status: 0,
-        error: undefined,
-      }
-    })
-    expect(
-      await fileHelpers.getFileListing('.', { flags: '', networkFilter: 'package', verbose: 'true' }),
-    ).toBe(['package.json', 'package-lock.json'].join('\n'))
-  })
-
-  it('can get a file listing with a dir filter', async () => {
-    const files = ['npm-shrinkwrap.json', 'package.json', 'src/file.js']
-    td.replace(childProcess, 'spawnSync', () => {
-      return {
-        stdout: files.join('\n'),
-        status: 0,
-        error: undefined,
-      }
-    })
-    expect(
-      await fileHelpers.getFileListing('.', { flags: '', networkFilter: 'src/', verbose: 'true' }),
-    ).toBe(['src/file.js'].join('\n'))
-  })
-
   it('can get a file listing when git is unavailable', async () => {
     td.replace(childProcess, 'spawnSync', () => {
       return { stdout: '', status: null, error: new Error() }
@@ -93,52 +65,6 @@ describe('File Helpers', () => {
     ).toMatch('npm-shrinkwrap.json')
   })
 
-  it('can get a file listing with a file filter and prefix', async () => {
-    const files = ['npm-shrinkwrap.json', 'package.json', 'package-lock.json', 'src/file.js']
-    td.replace(childProcess, 'spawnSync', () => {
-      return {
-        stdout: files.join('\n'),
-        status: 0,
-        error: undefined,
-      }
-    })
-    expect(
-      await fileHelpers.getFileListing('.', { flags: '', networkFilter: 'package', networkPrefix: 'build/', verbose: 'true' }),
-    ).toBe(['build/package.json', 'build/package-lock.json'].join('\n'))
-  })
-
-  it('can get a file listing with a dir filter and prefix', async () => {
-    const files = ['npm-shrinkwrap.json', 'package.json', 'src/file.js']
-    td.replace(childProcess, 'spawnSync', () => {
-      return {
-        stdout: files.join('\n'),
-        status: 0,
-        error: undefined,
-      }
-    })
-    expect(
-      await fileHelpers.getFileListing('.', { flags: '', networkFilter: 'src/', networkPrefix: 'build/', verbose: 'true' }),
-    ).toBe(['build/src/file.js'].join('\n'))
-  })
-
-  it('can get a file listing when git is unavailable with a filter', async () => {
-    td.replace(childProcess, 'spawnSync', () => {
-      return { stdout: '', status: null, error: new Error() }
-    })
-    expect(
-      await fileHelpers.getFileListing('.', { flags: '', networkFilter: 'npm', verbose: 'true' }),
-    ).toMatch('npm-shrinkwrap.json')
-  })
-
-  it('can get a file listing when git is unavailable with a filter without matches', async () => {
-    td.replace(childProcess, 'spawnSync', () => {
-      return { stdout: '', status: null, error: new Error() }
-    })
-    expect(
-      await fileHelpers.getFileListing('.', { flags: '', networkFilter: 'src', verbose: 'true' }),
-    ).toMatch('')
-  })
-
   describe('Coverage report handling', () => {
     it('can generate report file header', () => {
       expect(fileHelpers.fileHeader('test-coverage-file.xml')).toBe(
diff --git a/test/providers/provider_buildkite.test.ts b/test/providers/provider_buildkite.test.ts
index 1d8a01b..752a21f 100644
--- a/test/providers/provider_buildkite.test.ts
+++ b/test/providers/provider_buildkite.test.ts
@@ -43,7 +43,7 @@ describe('Buildkite Params', () => {
         BUILDKITE: 'true',
         BUILDKITE_BUILD_NUMBER: '1',
         BUILDKITE_JOB_ID: '3',
-        BUILDKITE_PIPELINE_SLUG: 'testRepo',
+        BUILDKITE_PROJECT_SLUG: 'testRepo',
         BUILDKITE_BRANCH: 'main',
         BUILDKITE_COMMIT: 'testingsha',
         BUILDKITE_BUILD_URL: 'https://buildkite.com/testOrg/testRepo',
diff --git a/test/providers/provider_herokuci.test.ts b/test/providers/provider_herokuci.test.ts
deleted file mode 100644
index 5336ee9..0000000
--- a/test/providers/provider_herokuci.test.ts
+++ /dev/null
@@ -1,122 +0,0 @@
-import td from 'testdouble'
-import childProcess from 'child_process'
-import { IServiceParams, UploaderInputs } from '../../src/types'
-
-const providerHerokuci = require('../../src/ci_providers//provider_herokuci')
-
-describe('HerokuCI Params', () => {
-  afterEach(() => {
-    td.reset()
-  })
-
-  describe('detect()', () => {
-    it('does not run without HerokuCI env variable', () => {
-      const inputs: UploaderInputs = {
-        args: {
-          flags: ''
-        },
-        environment: {},
-      }
-      const detected = providerHerokuci.detect(inputs.environment)
-      expect(detected).toBeFalsy()
-    })
-
-    it('does run with Herokuci env variable', () => {
-      const inputs: UploaderInputs= {
-        args: {
-          flags: ''
-        },
-        environment: {
-          CI: 'true',
-          HEROKU_TEST_RUN_BRANCH: 'test',
-        },
-      }
-      const detected = providerHerokuci.detect(inputs.environment)
-      expect(detected).toBeTruthy()
-    })
-  })
-
-  // This should test that the provider outputs proper default values
-  it('gets the correct params on no env variables', () => {
-    const inputs: UploaderInputs = {
-      args: { tag: '', url: '', source: '', flags: '' },
-      environment: {},
-    }
-    const expected: IServiceParams = {
-      branch: '',
-      build: '',
-      buildURL: '',
-      commit: '',
-      job: '',
-      pr: '',
-      service: 'heroku',
-      slug: '',
-    }
-    const spawnSync = td.replace(childProcess, 'spawnSync')
-    td.when(
-      spawnSync('git', ['config', '--get', 'remote.origin.url']),
-    ).thenReturn({ stdout: '' })
-    const params = providerHerokuci.getServiceParams(inputs)
-    expect(params).toMatchObject(expected)
-  })
-
-  // This should test that the provider outputs proper parameters when a push event is created
-  it('gets the correct params on push', () => {
-    const inputs: UploaderInputs = {
-      args: { tag: '', url: '', source: '', flags: '' },
-      environment: {
-        CI: 'true',
-        HEROKU_TEST_RUN_BRANCH: 'testBranch',
-        HEROKU_TEST_RUN_COMMIT_VERSION: 'testSha',
-        HEROKU_TEST_RUN_ID: '2',
-      },
-    }
-    const expected: IServiceParams = {
-      branch: 'testBranch',
-      build: '2',
-      buildURL: '',
-      commit: 'testSha',
-      job: '',
-      pr: '',
-      service: 'heroku',
-      slug: 'testOrg/testRepo',
-    }
-    const spawnSync = td.replace(childProcess, 'spawnSync')
-    td.when(
-      spawnSync('git', ['config', '--get', 'remote.origin.url']),
-    ).thenReturn({ stdout: 'https://github.com/testOrg/testRepo.git' })
-    const params = providerHerokuci.getServiceParams(inputs)
-    expect(params).toMatchObject(expected)
-  })
-
-  // This should test that the provider outputs proper parameters when given overrides
-  it('gets the correct params on overrides', () => {
-    const inputs: UploaderInputs = {
-      args: {
-        branch: 'branch',
-        build: '3',
-        pr: '2',
-        sha: 'testsha',
-        slug: 'testOrg/testRepo',
-        tag: '',
-        url: '',
-        source: '',
-        flags: '',
-      },
-      environment: {},
-    }
-    const expected: IServiceParams = {
-      branch: 'branch',
-      build: '3',
-      buildURL: '',
-      commit: 'testsha',
-      job: '',
-      pr: '2',
-      service: 'heroku',
-      slug: 'testOrg/testRepo',
-    }
-    const params = providerHerokuci.getServiceParams(inputs)
-    expect(expected).toBeTruthy()
-    expect(params).toMatchObject(expected)
-  })
-})