Repository: detekt/detekt (kotlin)

Issue:
CLI says "Run detekt CLI with --debug" even when flag is set
<!-- The bug you're experiencing might have already be reported! -->
<!-- Please search in the [issues](https://github.com/detekt/detekt/issues) before creating one. -->

## Expected Behavior
When `--debug` flag is passed to CLI the message regarding compiler errors found during analysis should not say to "Run detekt CLI with --debug or set `detekt { debug = true }` in Gradle to see the error messages."

## Observed Behavior
```
C:/Users/snafu/IdeaProjects/detekt/detekt-api/src/main/kotlin/dev/detekt/api/internal/Versions.kt:23:29: error: cannot access 'object BuildConfig : Any': it is internal in file.
fun whichDetekt(): String = BuildConfig.DETEKT_VERSION
                            ^^^^^^^^^^^
C:/Users/snafu/IdeaProjects/detekt/detekt-api/src/main/kotlin/dev/detekt/api/internal/Versions.kt:23:41: error: cannot access 'val DETEKT_VERSION: String': it is internal in 'dev/detekt/detekt_api/BuildConfig'.
fun whichDetekt(): String = BuildConfig.DETEKT_VERSION
                                        ^^^^^^^^^^^^^^
C:/Users/snafu/IdeaProjects/detekt/detekt-api/src/main/kotlin/dev/detekt/api/internal/Versions.kt:18:29: error: cannot access 'object BuildConfig : Any': it is internal in file.
fun whichKotlin(): String = BuildConfig.KOTLIN_IMPLEMENTATION_VERSION
                            ^^^^^^^^^^^
C:/Users/snafu/IdeaProjects/detekt/detekt-api/src/main/kotlin/dev/detekt/api/internal/Versions.kt:18:41: error: cannot access 'val KOTLIN_IMPLEMENTATION_VERSION: String': it is internal in 'dev/detekt/detekt_api/BuildConfig'.
fun whichKotlin(): String = BuildConfig.KOTLIN_IMPLEMENTATION_VERSION
                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
C:/Users/snafu/IdeaProjects/detekt/detekt-api/src/main/kotlin/dev/detekt/api/internal/Versions.kt:3:30: error: cannot access 'object BuildConfig : Any': it is internal in file.
import dev.detekt.detekt_api.BuildConfig
                             ^^^^^^^^^^^
There were 5 compiler errors found during analysis. This affects accuracy of reporting.
Run detekt CLI with --debug or set `detekt { debug = true }` in Gradle to see the error messages.
```

## Steps to Reproduce
Create a configuration where compiler errors are generated during analysis and pass ``--debug` flag to CLI or set `debug = true` in `detekt` extension in Gradle.

## Context
<!-- How has this issue affected you? What are you trying to accomplish? -->
<!-- Providing context helps us come up with a solution that is most useful in the real world -->

## Your Environment
<!-- Include as many relevant details about the environment you experienced the bug in -->
* Version of detekt used: `main`
* Version of Gradle used (if applicable): N/A
* Gradle scan link (add `--scan` option when running the gradle task):
* Operating System and version:
* Link to your project (if it's a public repository):

Pull request description:
## Description

When running detekt with --debug flag, the tool still shows this confusing message:

```
Run detekt CLI with --debug or set `detekt { debug = true }` in Gradle to see the error messages.
```

## Solution

Modified DetektMessageCollector.printIssuesCountIfAny() to check if debug mode is already enabled. If it is, skip the suggestion text.

- Updated printIssuesCountIfAny() method to conditionally show debug suggestion
- Added test cases to verify the behavior
- Works for both CLI --debug flag and Gradle debug = true setting

Fixed: #8567

Patch:
diff --git a/detekt-core/src/main/kotlin/dev/detekt/core/tooling/Lifecycle.kt b/detekt-core/src/main/kotlin/dev/detekt/core/tooling/Lifecycle.kt
index c39e807c75eb..7e748864dda1 100644
--- a/detekt-core/src/main/kotlin/dev/detekt/core/tooling/Lifecycle.kt
+++ b/detekt-core/src/main/kotlin/dev/detekt/core/tooling/Lifecycle.kt
@@ -16,6 +16,7 @@ import dev.detekt.core.rules.createRuleProviders
 import dev.detekt.core.util.PerformanceMonitor.Phase
 import dev.detekt.core.util.getOrCreateMonitor
 import dev.detekt.parser.DetektMessageCollector
+import dev.detekt.parser.GenerateBindingContextOptions
 import dev.detekt.parser.generateBindingContext
 import dev.detekt.tooling.api.AnalysisMode
 import org.jetbrains.kotlin.analysis.api.analyze
@@ -74,7 +75,12 @@ internal class DefaultLifecycle(
     override val bindingProvider: (files: List<KtFile>) -> BindingContext =
         {
             if (settings.spec.projectSpec.analysisMode == AnalysisMode.full) {
-                val collector = DetektMessageCollector(CompilerMessageSeverity.ERROR, settings::debug, settings::info)
+                val collector = DetektMessageCollector(
+                    minSeverity = CompilerMessageSeverity.ERROR,
+                    debugPrinter = settings::debug,
+                    warningPrinter = settings::info,
+                    isDebugEnabled = settings.spec.loggingSpec.debug
+                )
 
                 it.forEach { file: KtFile ->
                     analyze(file) {
@@ -102,11 +108,14 @@ internal class DefaultLifecycle(
                 collector.printIssuesCountIfAny(k2Mode = true)
 
                 generateBindingContext(
-                    settings.project,
-                    settings.configuration,
-                    it,
-                    settings::debug,
-                    settings::info
+                    project = settings.project,
+                    configuration = settings.configuration,
+                    files = it,
+                    options = GenerateBindingContextOptions(
+                        debugPrinter = settings::debug,
+                        warningPrinter = settings::info,
+                        isDebugEnabled = settings.spec.loggingSpec.debug,
+                    ),
                 )
             } else {
                 BindingContext.EMPTY
diff --git a/detekt-parser/src/main/kotlin/dev/detekt/parser/BindingContextUtils.kt b/detekt-parser/src/main/kotlin/dev/detekt/parser/BindingContextUtils.kt
index f8af19f070e9..b5e507b972fc 100644
--- a/detekt-parser/src/main/kotlin/dev/detekt/parser/BindingContextUtils.kt
+++ b/detekt-parser/src/main/kotlin/dev/detekt/parser/BindingContextUtils.kt
@@ -18,17 +18,24 @@ import org.jetbrains.kotlin.config.languageVersionSettings
 import org.jetbrains.kotlin.psi.KtFile
 import org.jetbrains.kotlin.resolve.BindingContext
 
+// Avoid exceeding 5 parameters in the function call below
+data class GenerateBindingContextOptions(
+    val debugPrinter: (() -> String) -> Unit,
+    val warningPrinter: (String) -> Unit,
+    val isDebugEnabled: Boolean,
+)
+
 fun generateBindingContext(
     project: Project,
     configuration: CompilerConfiguration,
     files: List<KtFile>,
-    debugPrinter: (() -> String) -> Unit,
-    warningPrinter: (String) -> Unit,
+    options: GenerateBindingContextOptions,
 ): BindingContext {
     val messageCollector = DetektMessageCollector(
         minSeverity = CompilerMessageSeverity.ERROR,
-        debugPrinter = debugPrinter,
-        warningPrinter = warningPrinter,
+        debugPrinter = options.debugPrinter,
+        warningPrinter = options.warningPrinter,
+        isDebugEnabled = options.isDebugEnabled,
     )
 
     val analyzer = AnalyzerWithCompilerReport(
@@ -74,6 +81,7 @@ class DetektMessageCollector(
     private val minSeverity: CompilerMessageSeverity,
     private val debugPrinter: (() -> String) -> Unit,
     private val warningPrinter: (String) -> Unit,
+    private val isDebugEnabled: Boolean,
 ) : MessageCollector by MessageCollector.NONE {
     private var messages = 0
 
@@ -86,11 +94,15 @@ class DetektMessageCollector(
 
     fun printIssuesCountIfAny(k2Mode: Boolean = false) {
         if (messages > 0) {
-            warningPrinter(
+            val header =
                 "There were $messages compiler errors found during ${if (!k2Mode) "legacy compiler " else ""}" +
-                    "analysis. This affects accuracy of reporting.\n" +
-                    "Run detekt CLI with --debug or set `detekt { debug = true }` in Gradle to see the error messages."
-            )
+                    "analysis. This affects accuracy of reporting."
+            val suggestion = if (!isDebugEnabled) {
+                "\nRun detekt CLI with --debug or set `detekt { debug = true }` in Gradle to see the error messages."
+            } else {
+                ""
+            }
+            warningPrinter(header + suggestion)
         }
     }
 }


Test patch:
diff --git a/detekt-parser/src/test/kotlin/dev/detekt/parser/DetektMessageCollectorSpec.kt b/detekt-parser/src/test/kotlin/dev/detekt/parser/DetektMessageCollectorSpec.kt
index 60aaa9caf296..1424917468ec 100644
--- a/detekt-parser/src/test/kotlin/dev/detekt/parser/DetektMessageCollectorSpec.kt
+++ b/detekt-parser/src/test/kotlin/dev/detekt/parser/DetektMessageCollectorSpec.kt
@@ -15,10 +15,12 @@ class DetektMessageCollectorSpec {
     @BeforeEach
     fun setupFakesAndSubject() {
         debugPrinter.messages.clear()
+        warningPrinter.messages.clear()
         subject = DetektMessageCollector(
             minSeverity = CompilerMessageSeverity.INFO,
             debugPrinter = debugPrinter,
             warningPrinter = warningPrinter,
+            isDebugEnabled = false,
         )
     }
 
@@ -92,6 +94,30 @@ class DetektMessageCollectorSpec {
         assertThat(warningPrinter.messages).isEmpty()
     }
 
+    @Nested
+    inner class `debug enabled omits suggestion` {
+        @BeforeEach
+        fun setUp() {
+            debugPrinter.messages.clear()
+            warningPrinter.messages.clear()
+            subject = DetektMessageCollector(
+                minSeverity = CompilerMessageSeverity.INFO,
+                debugPrinter = debugPrinter,
+                warningPrinter = warningPrinter,
+                isDebugEnabled = true,
+            )
+            subject.report(CompilerMessageSeverity.ERROR, "boom", null)
+        }
+
+        @Test
+        fun `prints header without suggestion`() {
+            subject.printIssuesCountIfAny(k2Mode = false)
+            assertThat(warningPrinter.messages).containsExactly(
+                "There were 1 compiler errors found during legacy compiler analysis. This affects accuracy of reporting."
+            )
+        }
+    }
+
     class FakePrinter : (() -> String) -> Unit {
         val messages = mutableListOf<String>()
         override fun invoke(param: () -> String) {