Repository: elastic/go-libaudit (go)

Issue:
Rename removed-use-role-from to removed-user-role-from
From:
https://github.com/elastic/go-libaudit/blob/master/aucoalesce/normalizations.yaml#L585

Rename:

```ts
removed-use-role-from
```

to
```
removed-user-role-from
```



Pull request description:
Fix typo in event.action for AUDIT_ROLE_REMOVE
This fixes a typo in `removed-use-role-from` to `removed-user-role-from`.

Closes #54

Patch:
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 84da0b0..7a34810 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -8,12 +8,14 @@ This project adheres to [Semantic Versioning](http://semver.org/).
 ### Added
 
 - Vagrantfile for development ease. #61
+- Added enrichment of arch, syscall, and sig to type=SECCOMP messages. #64
 
 ### Changed
 
 - Added support for big endian. #48
 - Added semantic versioning support via go modules. #61
-- Add ECS categorization support for events by record type and syscall. #62
+- Added ECS categorization support for events by record type and syscall. #62
+- Fixed a typo in the action value associated with ROLE_REMOVE messages. #65
 
 ### Removed
 
diff --git a/aucoalesce/normalizations.yaml b/aucoalesce/normalizations.yaml
index 4162f0d..061d4c4 100644
--- a/aucoalesce/normalizations.yaml
+++ b/aucoalesce/normalizations.yaml
@@ -914,7 +914,7 @@ normalizations:
         - change
   # AUDIT_ROLE_REMOVE - Admin removed user from role
   - record_types: ROLE_REMOVE
-    action: removed-use-role-from
+    action: removed-user-role-from
     object:
       primary: [id, acct]
       what: account
diff --git a/auparse/auparse.go b/auparse/auparse.go
index 6953af5..74c9271 100644
--- a/auparse/auparse.go
+++ b/auparse/auparse.go
@@ -23,9 +23,11 @@ import (
 	"regexp"
 	"strconv"
 	"strings"
+	"syscall"
 	"time"
 
 	"github.com/pkg/errors"
+	"golang.org/x/sys/unix"
 )
 
 //go:generate sh -c "go run mk_audit_msg_types.go && gofmt -s -w zaudit_msg_types.go"
@@ -332,11 +334,16 @@ func enrichData(msg *AuditMessage) error {
 	hexDecode("cwd", msg.fields)
 
 	switch msg.RecordType {
+	case AUDIT_SECCOMP:
+		if err := setSignalName(msg.fields); err != nil {
+			return err
+		}
+		fallthrough
 	case AUDIT_SYSCALL:
 		if err := arch(msg.fields); err != nil {
 			return err
 		}
-		if err := syscall(msg.fields); err != nil {
+		if err := setSyscallName(msg.fields); err != nil {
 			return err
 		}
 		if err := hexDecode("exe", msg.fields); err != nil {
@@ -388,7 +395,7 @@ func arch(data map[string]*field) error {
 	return nil
 }
 
-func syscall(data map[string]*field) error {
+func setSyscallName(data map[string]*field) error {
 	field, found := data["syscall"]
 	if !found {
 		return errors.New("syscall key not found")
@@ -410,6 +417,23 @@ func syscall(data map[string]*field) error {
 	return nil
 }
 
+func setSignalName(data map[string]*field) error {
+	field, found := data["sig"]
+	if !found {
+		return errors.New("sig key not found")
+	}
+
+	signalNum, err := strconv.Atoi(field.Value())
+	if err != nil {
+		return errors.Wrap(err, "failed to parse sig")
+	}
+
+	if signalName := unix.SignalName(syscall.Signal(signalNum)); signalName != "" {
+		field.Set(signalName)
+	}
+	return nil
+}
+
 func saddr(data map[string]*field) error {
 	field, found := data["saddr"]
 	if !found {
diff --git a/go.mod b/go.mod
index 638fb24..671280a 100644
--- a/go.mod
+++ b/go.mod
@@ -8,6 +8,6 @@ require (
 	github.com/pkg/errors v0.8.1-0.20170505043639-c605e284fe17
 	github.com/pmezard/go-difflib v1.0.0 // indirect
 	github.com/stretchr/testify v1.1.5-0.20170601210322-f6abca593680
-	golang.org/x/sys v0.0.0-20170608164803-0b25a408a500 // indirect
+	golang.org/x/sys v0.0.0-20200615200032-f1bc736245b1
 	gopkg.in/yaml.v2 v2.3.0
 )
diff --git a/go.sum b/go.sum
index 1c14f17..5fdfd16 100644
--- a/go.sum
+++ b/go.sum
@@ -8,8 +8,8 @@ github.com/pmezard/go-difflib v1.0.0 h1:4DBwDE0NGyQoBHbLQYPwSUPoCMWR5BEzIk/f1lZb
 github.com/pmezard/go-difflib v1.0.0/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4=
 github.com/stretchr/testify v1.1.5-0.20170601210322-f6abca593680 h1:oAXco1Ts88F75L1qvG3BAa4ChXI3EZDfxbB+p+y8+gE=
 github.com/stretchr/testify v1.1.5-0.20170601210322-f6abca593680/go.mod h1:a8OnRcib4nhh0OaRAV+Yts87kKdq0PP7pXfy6kDkUVs=
-golang.org/x/sys v0.0.0-20170608164803-0b25a408a500 h1:fhpo4nhRTq7HDlHaX8W7357HRWFlwsS1IAkGNCmoZ+E=
-golang.org/x/sys v0.0.0-20170608164803-0b25a408a500/go.mod h1:STP8DvDyc/dI5b8T5hshtkjS+E42TnysNCUPdjciGhY=
+golang.org/x/sys v0.0.0-20200615200032-f1bc736245b1 h1:ogLJMz+qpzav7lGMh10LMvAkM/fAoGlaiiHYiFYdm80=
+golang.org/x/sys v0.0.0-20200615200032-f1bc736245b1/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
 gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405 h1:yhCVgyC4o1eVCa2tZl7eS0r+SDo693bJlVdllGtEeKM=
 gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0=
 gopkg.in/yaml.v2 v2.3.0 h1:clyUAQHOM3G0M3f5vQj7LuJrETvjVot3Z5el9nffUtU=


Test patch:
diff --git a/auparse/testdata/test3.log b/auparse/testdata/test3.log
index c7d3fd9..99a4d31 100644
--- a/auparse/testdata/test3.log
+++ b/auparse/testdata/test3.log
@@ -14,3 +14,4 @@ type=PROCTITLE msg=audit(1451781471.394:194438): proctitle="bash"
 type=PROCTITLE msg=audit(1451781471.394:194440): proctitle=737368643A206275726E205B707269765D
 type=ADD_GROUP msg=audit(1451781471.602:194894): pid=1321 uid=0 auid=1000 ses=1 subj=unconfined_u:unconfined_r:unconfined_t:s0-s0:c0.c1023 msg='op=add-group acct="frodo" exe="/usr/sbin/useradd" hostname=? addr=? terminal=pts/0 res=success'
 type=EXECVE msg=audit(1507304439.922:1865): argc=5 a0="useradd" a1="-u" a2="3005" a3="-m" a4="trainer5"
+type=SECCOMP msg=audit(1433785727.186:10262): auid=20003 uid=22 gid=22 ses=21 pid=11217 comm="sshd" exe="/usr/sbin/sshd" sig=31 arch=40000003 syscall=132 compat=0 ip=0xb7670aac code=0x0
diff --git a/auparse/testdata/test3.log.golden b/auparse/testdata/test3.log.golden
index ec54a41..1642b2f 100644
--- a/auparse/testdata/test3.log.golden
+++ b/auparse/testdata/test3.log.golden
@@ -356,5 +356,26 @@
       "a4": "trainer5",
       "argc": "5"
     }
+  },
+  {
+    "@timestamp": "2015-06-08T17:48:47.186Z",
+    "record_type": "seccomp",
+    "sequence": 10262,
+    "raw_msg": "audit(1433785727.186:10262): auid=20003 uid=22 gid=22 ses=21 pid=11217 comm=\"sshd\" exe=\"/usr/sbin/sshd\" sig=31 arch=40000003 syscall=132 compat=0 ip=0xb7670aac code=0x0",
+    "data": {
+      "arch": "i386",
+      "auid": "20003",
+      "code": "0x0",
+      "comm": "sshd",
+      "compat": "0",
+      "exe": "/usr/sbin/sshd",
+      "gid": "22",
+      "ip": "0xb7670aac",
+      "pid": "11217",
+      "ses": "21",
+      "sig": "SIGSYS",
+      "syscall": "getpgid",
+      "uid": "22"
+    }
   }
 ]