Repository: skupperproject/skupper (go)

Issue:
V2 nonkube platform rename from systemd to linux
**Is your feature request related to a problem? Please describe.**

Nonkube bootstrap allow namespaces to use a local skupper-router installation, and the respective
platform is identified as `systemd`. The name is not appropriate, considering that container engine
sites (podman and docker) also use systemd.

**Describe the solution you'd like**

Rename the V2 platform from `systemd` to `linux`.


Pull request description:
Renamed systemd platform to linux
Fixes #1765 

Patch:
diff --git a/api/types/types.go b/api/types/types.go
index e326aa66..afc422e4 100644
--- a/api/types/types.go
+++ b/api/types/types.go
@@ -322,7 +322,7 @@ const (
 	PlatformKubernetes Platform = "kubernetes"
 	PlatformPodman     Platform = "podman"
 	PlatformDocker     Platform = "docker"
-	PlatformSystemd    Platform = "systemd"
+	PlatformLinux      Platform = "linux"
 )
 
 func (p Platform) IsKubernetes() bool {
diff --git a/cmd/bootstrap/README.md b/cmd/bootstrap/README.md
index 1d181ef5..de856334 100644
--- a/cmd/bootstrap/README.md
+++ b/cmd/bootstrap/README.md
@@ -31,7 +31,7 @@ allowed values:
 
 * podman
 * docker
-* systemd
+* linux
 
 ### Container engine platforms
 
@@ -39,9 +39,9 @@ When `podman` or `docker` platform is used, then the bootstrap procedure will
 require that the respective container engine endpoint is available. The default
 unix socket will be used based on the current user and platform selected.
 
-### Systemd
+### Linux
 
-The `systemd` platform actually requires that you have a local installation of
+The `linux` platform actually requires that you have a local installation of
 the `skupper-router` (`skrouterd` binary must be available in your PATH).
 
 ## Bootstrap usage
@@ -170,7 +170,7 @@ The bundle installation script accepts the following flags:
 
 ```
 -h               help
--p <platform>    podman, docker, systemd
+-p <platform>    podman, docker, linux
 -n <namespace>   if not provided, the namespace defined in the bundle is used (if none, default is used)
 -x               remove site and namespace
 -d <directory>   dump static links into the provided directory 
diff --git a/cmd/bootstrap/bootstrap.sh b/cmd/bootstrap/bootstrap.sh
index 6a0e3616..46f7e63d 100755
--- a/cmd/bootstrap/bootstrap.sh
+++ b/cmd/bootstrap/bootstrap.sh
@@ -51,9 +51,9 @@ container_env() {
     export CONTAINER_ENGINE="${CONTAINER_ENGINE:-podman}"
     # Determining if the respective binaries are available
     case "${SKUPPER_PLATFORM}" in
-        systemd)
-            command -v skrouterd > /dev/null || exit_error "SystemD platform cannot be used: skrouterd not found"
-            command -v "${CONTAINER_ENGINE}" > /dev/null || exit_error "SystemD platform cannot be used: ${CONTAINER_ENGINE} (container engine) not found"
+        linux)
+            command -v skrouterd > /dev/null || exit_error "Linux platform cannot be used: skrouterd not found"
+            command -v "${CONTAINER_ENGINE}" > /dev/null || exit_error "Linux platform cannot be used: ${CONTAINER_ENGINE} (container engine) not found"
             ;;
         docker)
             command -v docker > /dev/null || exit_error "Docker platform cannot be used: docker not found"
diff --git a/cmd/network-observer/internal/api/types_gen.go b/cmd/network-observer/internal/api/types_gen.go
index 6c1fdad3..7bd9b593 100644
--- a/cmd/network-observer/internal/api/types_gen.go
+++ b/cmd/network-observer/internal/api/types_gen.go
@@ -54,7 +54,7 @@ const (
 	SitePlatformTypeDocker     SitePlatformType = "docker"
 	SitePlatformTypeKubernetes SitePlatformType = "kubernetes"
 	SitePlatformTypePodman     SitePlatformType = "podman"
-	SitePlatformTypeSystemd    SitePlatformType = "systemd"
+	SitePlatformTypeLinux      SitePlatformType = "linux"
 	SitePlatformTypeUnknown    SitePlatformType = "unknown"
 )
 
diff --git a/cmd/network-observer/internal/server/views/views.go b/cmd/network-observer/internal/server/views/views.go
index b364a554..dd89702c 100644
--- a/cmd/network-observer/internal/server/views/views.go
+++ b/cmd/network-observer/internal/server/views/views.go
@@ -690,8 +690,8 @@ func NewSiteProvider(graph collector.Graph) func(vanflow.SiteRecord) api.SiteRec
 				s.Platform = api.SitePlatformTypeDocker
 			case strings.EqualFold(platform, string(api.SitePlatformTypePodman)):
 				s.Platform = api.SitePlatformTypePodman
-			case strings.EqualFold(platform, string(api.SitePlatformTypeSystemd)):
-				s.Platform = api.SitePlatformTypeSystemd
+			case strings.EqualFold(platform, string(api.SitePlatformTypeLinux)):
+				s.Platform = api.SitePlatformTypeLinux
 			}
 		}
 		s.RouterCount = len(graph.Site(site.ID).Routers())
diff --git a/cmd/network-observer/spec/openapi.yaml b/cmd/network-observer/spec/openapi.yaml
index f3046a7d..54f87c8d 100644
--- a/cmd/network-observer/spec/openapi.yaml
+++ b/cmd/network-observer/spec/openapi.yaml
@@ -835,7 +835,7 @@ components:
         - kubernetes
         - podman
         - docker
-        - systemd
+        - linux
         - unknown
     processBindingType:
       type: string
diff --git a/internal/cmd/skupper/common/command.go b/internal/cmd/skupper/common/command.go
index 1b37f1d0..feea41b1 100644
--- a/internal/cmd/skupper/common/command.go
+++ b/internal/cmd/skupper/common/command.go
@@ -2,6 +2,7 @@ package common
 
 import (
 	"fmt"
+
 	"github.com/skupperproject/skupper/api/types"
 	"github.com/skupperproject/skupper/internal/cmd/skupper/common/utils"
 	"github.com/spf13/cobra"
@@ -41,7 +42,7 @@ func ConfigureCobraCommand(configuredPlatform types.Platform, description Skuppe
 			switch platform {
 			case "kubernetes":
 				skupperCommand = kubeImpl
-			case "podman", "docker", "systemd":
+			case "podman", "docker", "linux":
 				skupperCommand = nonKubeImpl
 			default:
 				return fmt.Errorf("platform %q not supported", platform)
diff --git a/internal/cmd/skupper/common/flags.go b/internal/cmd/skupper/common/flags.go
index f7520297..13cc0eaa 100644
--- a/internal/cmd/skupper/common/flags.go
+++ b/internal/cmd/skupper/common/flags.go
@@ -6,7 +6,7 @@ import (
 
 const (
 	FlagNamePlatform   = "platform"
-	FlagDescPlatform   = "Set the platform type to use [kubernetes, podman, docker, systemd]"
+	FlagDescPlatform   = "Set the platform type to use [kubernetes, podman, docker, linux]"
 	FlagNameNamespace  = "namespace"
 	FlagDescNamespace  = "Set the namespace"
 	FlagNameContext    = "context"
diff --git a/internal/cmd/skupper/system/nonkube/system_reload.go b/internal/cmd/skupper/system/nonkube/system_reload.go
index 9a2a731e..250d3c45 100644
--- a/internal/cmd/skupper/system/nonkube/system_reload.go
+++ b/internal/cmd/skupper/system/nonkube/system_reload.go
@@ -58,7 +58,7 @@ func (cmd *CmdSystemReload) InputToOptions() {
 	}
 
 	switch selectedPlatform {
-	case types.PlatformSystemd:
+	case types.PlatformLinux:
 		binary = "skrouterd"
 	case types.PlatformDocker:
 		binary = "docker"
diff --git a/internal/cmd/skupper/system/nonkube/system_setup.go b/internal/cmd/skupper/system/nonkube/system_setup.go
index 1194ab35..17e2c1a1 100644
--- a/internal/cmd/skupper/system/nonkube/system_setup.go
+++ b/internal/cmd/skupper/system/nonkube/system_setup.go
@@ -104,7 +104,7 @@ func (cmd *CmdSystemSetup) InputToOptions() {
 
 	if !isBundle {
 		switch selectedPlatform {
-		case types.PlatformSystemd:
+		case types.PlatformLinux:
 			binary = "skrouterd"
 		case types.PlatformDocker:
 			binary = "docker"
diff --git a/internal/config/platform.go b/internal/config/platform.go
index bfd1e0e6..5417a680 100644
--- a/internal/config/platform.go
+++ b/internal/config/platform.go
@@ -44,8 +44,8 @@ func GetPlatform() types.Platform {
 		return types.PlatformPodman
 	case types.PlatformDocker:
 		return types.PlatformDocker
-	case types.PlatformSystemd:
-		return types.PlatformSystemd
+	case types.PlatformLinux:
+		return types.PlatformLinux
 	default:
 		return types.PlatformKubernetes
 	}
diff --git a/internal/nonkube/bundle/install.sh.template b/internal/nonkube/bundle/install.sh.template
index 6f495fe1..164f5f1a 100644
--- a/internal/nonkube/bundle/install.sh.template
+++ b/internal/nonkube/bundle/install.sh.template
@@ -49,8 +49,8 @@ exit_error() {
 }
 
 usage() {
-    echo "Usage: $0 [-p <podman|docker|systemd>] [-x] [-d <output-dir>]" >&2
-    echo "    -p    the platform to use: podman, docker, systemd (default: ${SOURCE_PLATFORM})" >&2
+    echo "Usage: $0 [-p <podman|docker|linux>] [-x] [-d <output-dir>]" >&2
+    echo "    -p    the platform to use: podman, docker, linux (default: ${SOURCE_PLATFORM})" >&2
     echo "    -n    target namespace (default: ${SOURCE_NAMESPACE})" >&2
     echo "    -x    remove existing site definition" >&2
     echo "    -d    dump static links from bundle into the provide output directory" >&2
@@ -61,7 +61,7 @@ parse_opts() {
     while getopts "xhd:p:n:" opt; do
         case "${opt}" in
             p)
-                valid_platforms="podman docker systemd"
+                valid_platforms="podman docker linux"
                 export SKUPPER_PLATFORM="${OPTARG}"
                 is_platform_valid=false
                 for valid_platform in ${valid_platforms}; do
@@ -70,7 +70,7 @@ parse_opts() {
                         break
                     fi
                 done
-                if [ ! "${is_platform_valid}" ]; then
+                if [ "${is_platform_valid}" = "false" ]; then
                     echo "Invalid platform: ${SKUPPER_PLATFORM}"
                     usage
                 fi
@@ -113,7 +113,7 @@ parse_opts() {
         fi
         docker_gid=$(getent group docker | cut -d: -f3)
         export RUNAS="${UID}:${docker_gid}"
-    elif [ "${SKUPPER_PLATFORM}" = "systemd" ]; then
+    elif [ "${SKUPPER_PLATFORM}" = "linux" ]; then
         export PLATFORM_COMMAND="skrouterd"
     fi
 
@@ -124,7 +124,7 @@ create_service() {
     ${SYSTEMCTL} list-units > /dev/null 2>&1 || return
     service_name="skupper-${NAMESPACE}.service"
     service_file_suffix="container"
-    [ "${SKUPPER_PLATFORM}" = "systemd" ] && service_file_suffix="systemd"
+    [ "${SKUPPER_PLATFORM}" = "linux" ] && service_file_suffix="linux"
     service_file="${SKUPPER_OUTPUT_PATH}/namespaces/${NAMESPACE}/internal/scripts/skupper.service.${service_file_suffix}"
 
     if [ ! -f "${service_file}" ]; then
@@ -172,7 +172,7 @@ remove_site() {
 
     echo "Removing Skupper site definition for ${SITE_NAME} from namespace ${NAMESPACE}"
     SKUPPER_PLATFORM=$(grep '^platform: ' "${PLATFORM_FILE}" | sed -e 's/.*: //g')
-    if [ "${SKUPPER_PLATFORM}" != "systemd" ]; then
+    if [ "${SKUPPER_PLATFORM}" != "linux" ]; then
         # removing router container
         ${SKUPPER_PLATFORM} rm -f "${NAMESPACE}-skupper-router"
     fi
@@ -199,9 +199,9 @@ set_router_access_port() {
 
 create_sed_script() {
     ssl_profile_base_path="\${SSL_PROFILE_BASE_PATH}"
-    [ "${SKUPPER_PLATFORM}" = "systemd" ] && ssl_profile_base_path="${NAMESPACES_PATH}/${NAMESPACE}"
+    [ "${SKUPPER_PLATFORM}" = "linux" ] && ssl_profile_base_path="${NAMESPACES_PATH}/${NAMESPACE}"
     container_engine="podman"
-    [ "${SKUPPER_PLATFORM}" != "systemd" ] && container_engine="${SKUPPER_PLATFORM}"
+    [ "${SKUPPER_PLATFORM}" != "linux" ] && container_engine="${SKUPPER_PLATFORM}"
     # populating sed script
     # note that this is processed a golang template prior to
     # being inserted into the bundle
@@ -237,7 +237,7 @@ show_token_info() {
 }
 
 create_containers() {
-    [ "${SKUPPER_PLATFORM}" = "systemd" ] && return
+    [ "${SKUPPER_PLATFORM}" = "linux" ] && return
     "${NAMESPACES_PATH:?}/${NAMESPACE:?}/internal/scripts/containers_create.sh"
 }
 
diff --git a/pkg/nonkube/bootstrap/bootstrap.go b/pkg/nonkube/bootstrap/bootstrap.go
index b6ff0f6f..18bba171 100644
--- a/pkg/nonkube/bootstrap/bootstrap.go
+++ b/pkg/nonkube/bootstrap/bootstrap.go
@@ -13,7 +13,7 @@ import (
 	"github.com/skupperproject/skupper/pkg/nonkube/bundle"
 	"github.com/skupperproject/skupper/pkg/nonkube/common"
 	"github.com/skupperproject/skupper/pkg/nonkube/compat"
-	"github.com/skupperproject/skupper/pkg/nonkube/systemd"
+	"github.com/skupperproject/skupper/pkg/nonkube/linux"
 	"github.com/skupperproject/skupper/pkg/utils"
 )
 
@@ -126,8 +126,8 @@ func Bootstrap(config *Config) (*api.SiteState, error) {
 			Strategy: internalbundle.BundleStrategy(config.BundleStrategy),
 			Platform: config.Platform,
 		}
-	} else if config.Platform == types.PlatformSystemd {
-		siteStateRenderer = &systemd.SiteStateRenderer{}
+	} else if config.Platform == types.PlatformLinux {
+		siteStateRenderer = &linux.SiteStateRenderer{}
 	} else {
 		siteStateRenderer = &compat.SiteStateRenderer{
 			Platform: config.Platform,
diff --git a/pkg/nonkube/bundle/systemd.go b/pkg/nonkube/bundle/systemd.go
index 9b2200f1..192fd8a1 100644
--- a/pkg/nonkube/bundle/systemd.go
+++ b/pkg/nonkube/bundle/systemd.go
@@ -18,7 +18,7 @@ func CreateSystemdServices(siteState *api.SiteState) error {
 	var err error
 	var logger = common.NewLogger()
 	serviceTemplates := map[string]string{
-		"systemd":   common.SystemdServiceTemplate,
+		"linux":     common.SystemdServiceTemplate,
 		"container": common.SystemdContainerServiceTemplate,
 	}
 	scriptsPath := api.GetInternalBundleOutputPath(siteState.Site.Namespace, api.ScriptsPath)
diff --git a/pkg/nonkube/common/systemd.go b/pkg/nonkube/common/systemd.go
index 18f2cddb..0cd3340b 100644
--- a/pkg/nonkube/common/systemd.go
+++ b/pkg/nonkube/common/systemd.go
@@ -90,7 +90,7 @@ func (s *systemdServiceInfo) Create() error {
 	var buf = new(bytes.Buffer)
 	var service *template.Template
 	logger.Debug("using service template for:", slog.String("platform", s.platform))
-	if s.platform == string(types.PlatformSystemd) {
+	if s.platform == string(types.PlatformLinux) {
 		service = template.Must(template.New(s.GetServiceName()).Parse(SystemdServiceTemplate))
 	} else {
 		service = template.Must(template.New(s.GetServiceName()).Parse(SystemdContainerServiceTemplate))
diff --git a/pkg/nonkube/systemd/site_state_renderer.go b/pkg/nonkube/linux/site_state_renderer.go
similarity index 96%
rename from pkg/nonkube/systemd/site_state_renderer.go
rename to pkg/nonkube/linux/site_state_renderer.go
index 6f1d42f9..e33c4ef6 100644
--- a/pkg/nonkube/systemd/site_state_renderer.go
+++ b/pkg/nonkube/linux/site_state_renderer.go
@@ -1,4 +1,4 @@
-package systemd
+package linux
 
 import (
 	"fmt"
@@ -87,7 +87,7 @@ func (s *SiteStateRenderer) Render(loadedSiteState *api.SiteState, reload bool)
 	siteHome := api.GetHostSiteHome(s.siteState.Site)
 	s.configRenderer = &common.FileSystemConfigurationRenderer{
 		SslProfileBasePath: siteHome,
-		Platform:           string(types.PlatformSystemd),
+		Platform:           string(types.PlatformLinux),
 	}
 	err = s.configRenderer.Render(s.siteState)
 	if err != nil {
@@ -119,7 +119,7 @@ func (s *SiteStateRenderer) loadExistingSiteId(siteState *api.SiteState) error {
 
 func (s *SiteStateRenderer) createSystemdService() error {
 	// Creating systemd user service
-	systemd, err := common.NewSystemdServiceInfo(s.siteState, string(types.PlatformSystemd))
+	systemd, err := common.NewSystemdServiceInfo(s.siteState, string(types.PlatformLinux))
 	if err != nil {
 		return err
 	}
@@ -140,7 +140,7 @@ func (s *SiteStateRenderer) createSystemdService() error {
 
 func (s *SiteStateRenderer) removeSystemdService() error {
 	// Removing systemd user service
-	systemd, err := common.NewSystemdServiceInfo(s.loadedSiteState, string(types.PlatformSystemd))
+	systemd, err := common.NewSystemdServiceInfo(s.loadedSiteState, string(types.PlatformLinux))
 	if err != nil {
 		return err
 	}


Test patch:
diff --git a/internal/cmd/skupper/system/nonkube/system_reload_test.go b/internal/cmd/skupper/system/nonkube/system_reload_test.go
index f4f6ea51..4fac99b3 100644
--- a/internal/cmd/skupper/system/nonkube/system_reload_test.go
+++ b/internal/cmd/skupper/system/nonkube/system_reload_test.go
@@ -31,7 +31,7 @@ func TestCmdSystemReload_ValidateInput(t *testing.T) {
 		t.Run(test.name, func(t *testing.T) {
 
 			command := &CmdSystemReload{}
-			command.CobraCmd = common.ConfigureCobraCommand(types.PlatformSystemd, common.SkupperCmdDescription{}, command, nil)
+			command.CobraCmd = common.ConfigureCobraCommand(types.PlatformLinux, common.SkupperCmdDescription{}, command, nil)
 
 			actualErrors := command.ValidateInput(test.args)
 			actualErrorsMessages := utils.ErrorsToMessages(actualErrors)
@@ -59,9 +59,9 @@ func TestCmdSystemReload_InputToOptions(t *testing.T) {
 			expectedNamespace: "default",
 		},
 		{
-			name:              "systemd",
+			name:              "linux",
 			namespace:         "east",
-			platform:          "systemd",
+			platform:          "linux",
 			expectedBinary:    "skrouterd",
 			expectedNamespace: "east",
 		},
diff --git a/internal/cmd/skupper/system/nonkube/system_setup_test.go b/internal/cmd/skupper/system/nonkube/system_setup_test.go
index c911a0a7..4c93554a 100644
--- a/internal/cmd/skupper/system/nonkube/system_setup_test.go
+++ b/internal/cmd/skupper/system/nonkube/system_setup_test.go
@@ -40,7 +40,7 @@ func TestCmdSystemSetup_ValidateInput(t *testing.T) {
 		t.Run(test.name, func(t *testing.T) {
 
 			command := &CmdSystemSetup{}
-			command.CobraCmd = common.ConfigureCobraCommand(types.PlatformSystemd, common.SkupperCmdDescription{}, command, nil)
+			command.CobraCmd = common.ConfigureCobraCommand(types.PlatformLinux, common.SkupperCmdDescription{}, command, nil)
 
 			if test.flags != nil {
 				command.Flags = test.flags
@@ -76,12 +76,12 @@ func TestCmdSystemSetup_InputToOptions(t *testing.T) {
 			expectedNamespace: "default",
 		},
 		{
-			name: "systemd",
+			name: "linux",
 			flags: common.CommandSystemSetupFlags{
 				Path: "input-path",
 			},
 			namespace:         "east",
-			platform:          "systemd",
+			platform:          "linux",
 			expectedBinary:    "skrouterd",
 			expectedNamespace: "east",
 		},
diff --git a/internal/cmd/skupper/system/nonkube/system_start_test.go b/internal/cmd/skupper/system/nonkube/system_start_test.go
index 9f8db1c4..e6852ca6 100644
--- a/internal/cmd/skupper/system/nonkube/system_start_test.go
+++ b/internal/cmd/skupper/system/nonkube/system_start_test.go
@@ -28,7 +28,7 @@ func TestCmdSystemStart_ValidateInput(t *testing.T) {
 		t.Run(test.name, func(t *testing.T) {
 
 			command := &CmdSystemStart{}
-			command.CobraCmd = common.ConfigureCobraCommand(types.PlatformSystemd, common.SkupperCmdDescription{}, command, nil)
+			command.CobraCmd = common.ConfigureCobraCommand(types.PlatformLinux, common.SkupperCmdDescription{}, command, nil)
 
 			actualErrors := command.ValidateInput(test.args)
 			actualErrorsMessages := utils.ErrorsToMessages(actualErrors)
diff --git a/internal/cmd/skupper/system/nonkube/system_stop_test.go b/internal/cmd/skupper/system/nonkube/system_stop_test.go
index 6a133b03..82436df3 100644
--- a/internal/cmd/skupper/system/nonkube/system_stop_test.go
+++ b/internal/cmd/skupper/system/nonkube/system_stop_test.go
@@ -29,7 +29,7 @@ func TestCmdSystemStop_ValidateInput(t *testing.T) {
 		t.Run(test.name, func(t *testing.T) {
 
 			command := &CmdSystemStop{}
-			command.CobraCmd = common.ConfigureCobraCommand(types.PlatformSystemd, common.SkupperCmdDescription{}, command, nil)
+			command.CobraCmd = common.ConfigureCobraCommand(types.PlatformLinux, common.SkupperCmdDescription{}, command, nil)
 
 			actualErrors := command.ValidateInput(test.args)
 			actualErrorsMessages := utils.ErrorsToMessages(actualErrors)
diff --git a/internal/cmd/skupper/system/nonkube/system_teardown_test.go b/internal/cmd/skupper/system/nonkube/system_teardown_test.go
index 0bcd81ec..df977689 100644
--- a/internal/cmd/skupper/system/nonkube/system_teardown_test.go
+++ b/internal/cmd/skupper/system/nonkube/system_teardown_test.go
@@ -29,7 +29,7 @@ func TestCmdSystemTearDown_ValidateInput(t *testing.T) {
 		t.Run(test.name, func(t *testing.T) {
 
 			command := &CmdSystemTeardown{}
-			command.CobraCmd = common.ConfigureCobraCommand(types.PlatformSystemd, common.SkupperCmdDescription{}, command, nil)
+			command.CobraCmd = common.ConfigureCobraCommand(types.PlatformLinux, common.SkupperCmdDescription{}, command, nil)
 
 			actualErrors := command.ValidateInput(test.args)
 			actualErrorsMessages := utils.ErrorsToMessages(actualErrors)
diff --git a/pkg/nonkube/common/systemd_test.go b/pkg/nonkube/common/systemd_test.go
index e3d0345f..65c75d77 100644
--- a/pkg/nonkube/common/systemd_test.go
+++ b/pkg/nonkube/common/systemd_test.go
@@ -29,7 +29,7 @@ func TestSystemdService(t *testing.T) {
 	t.Setenv("SKUPPER_OUTPUT_PATH", outputPath)
 	t.Setenv("XDG_CONFIG_HOME", outputPath)
 
-	for _, platform := range []string{"systemd", "podman", "docker"} {
+	for _, platform := range []string{"linux", "podman", "docker"} {
 		for _, uid := range []int{0, 1000} {
 			//assert.Assert(t, t.Setenv("SKUPPER_PLATFORM", platform))
 			systemdService, err := NewSystemdServiceInfo(siteState, platform)
@@ -54,7 +54,7 @@ func TestSystemdService(t *testing.T) {
 				var startCmd string
 				var stopCmd string
 				switch platform {
-				case "systemd":
+				case "linux":
 					startCmd = fmt.Sprintf("ExecStart=skrouterd -c %s/skrouterd.json", systemdServiceImpl.SiteConfigPath)
 					stopCmd = ""
 					assert.Assert(t, strings.Contains(string(serviceFile), `Environment="SKUPPER_SITE_ID=site-id"`), string(serviceFile))