Repository: malloydata/malloy (ts)

Issue:
Better error messages for invalid SQL in sql blocks
Since we are wrapping an exception, and have no idea what the error message in the exception looks like, we just preface it with "schema error", but that ends up making it hard to understand what is going on ....

```
Schema error: Syntax error: Unexpected string literal 'bigquery-public-data.san_francisco.`sfpd_incidents
```

and then the sql interpreter gives back a line number, but it is the line in the SQL Query ... I'm thinking

```
SQL Execution Error in SQL block
    Syntax error: Unexpected string literal 'bigquery-public-data.san_francisco.`sfpd_incidents
```

Pull request description:
Make understandable sql errors in blocks
`Schema Error: Syntax Error:` is a little confusing. The word schema there is related to an internal detail, that the error occured when requesting the schema for a block.

Decided to drop the `:`, and emphasize that this error is in the SQL, not in the Malloy.

Fixes #967 

```
Invalid SQL, Syntax error: Unexpected string literal 'bigquery-public-data.san_francisco.`sfpd_incidents
```

Or in the case where there are multiple lines in the server error message

```
Invalid SQL, FIRST LINE
  SECOND LINE
  THIRD LINE
```

Patch:
diff --git a/packages/malloy/src/lang/ast/ast-main.ts b/packages/malloy/src/lang/ast/ast-main.ts
index 026814e4..5d79304b 100644
--- a/packages/malloy/src/lang/ast/ast-main.ts
+++ b/packages/malloy/src/lang/ast/ast-main.ts
@@ -2393,7 +2393,8 @@ export class SQLStatement extends MalloyElement implements DocStatement {
     sqlDefEntry.reference(sql.name, this.location);
     const lookup = sqlDefEntry.getEntry(sql.name);
     if (lookup.status == "error") {
-      this.select.log(`'Schema error: ${lookup.message}`);
+      const msgLines = lookup.message.split(/\r?\n/);
+      this.select.log("Invalid SQL, " + msgLines.join("\n    "));
       return undefined;
     }
     if (lookup.status == "present") {


Test patch:
diff --git a/packages/malloy/src/lang/test/parse.spec.ts b/packages/malloy/src/lang/test/parse.spec.ts
index 68967089..7afafe74 100644
--- a/packages/malloy/src/lang/test/parse.spec.ts
+++ b/packages/malloy/src/lang/test/parse.spec.ts
@@ -1583,6 +1583,23 @@ describe("error handling", () => {
       "extraneous input '}%' expecting {<EOF>, EXPLORE, QUERY, SOURCE, SQL, IMPORT, ';'}"
     );
   });
+
+  test("bad sql in sql block", () => {
+    const badModel = new BetaModel(`sql: { select: """)""" }`);
+    expect(badModel).modelParsed();
+    const needSchema = badModel.translate();
+    expect(needSchema.compileSQL).toBeDefined();
+    if (needSchema.compileSQL) {
+      badModel.update({
+        errors: {
+          compileSQL: {
+            [needSchema.compileSQL.name]: "ZZZZ",
+          },
+        },
+      });
+    }
+    expect(badModel).compileToFailWith("Invalid SQL, ZZZZ");
+  });
 });
 
 function getSelectOneStruct(sqlBlock: SQLBlockSource): SQLBlockStructDef {