Repository: milvus-io/milvus-sdk-go
Pull request #780 (2024-07-02 10:28:16)

enhance: Remove the logic to set replica_number=1 by default
issue: milvus-io/milvus#34355

sre-ci-robot: [APPROVALNOTIFIER] This PR is **NOT APPROVED**

This pull-request has been approved by: *<a href="https://github.com/milvus-io/milvus-sdk-go/pull/780#" title="Author self-approved">weiliu1031</a>*
To complete the [pull request process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process), please assign **sunby** after the PR has been reviewed.
You can assign the PR to them by writing `/assign @sunby` in a comment when ready.

The full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=milvus-io%2Fmilvus-sdk-go).

<details open>
Needs approval from an approver in each of these files:

- **[OWNERS](https://github.com/milvus-io/milvus-sdk-go/blob/master/OWNERS)**

Approvers can indicate their approval by writing `/approve` in a comment
Approvers can cancel approval by writing `/approve cancel` in a comment
</details>
<!-- META={"approvers":["sunby"]} -->

Patch:
diff --git a/client/collection.go b/client/collection.go
index bf5fdec..cbf6b58 100644
--- a/client/collection.go
+++ b/client/collection.go
@@ -431,7 +431,6 @@ func (c *GrpcClient) LoadCollection(ctx context.Context, collName string, async
 
 	req := &milvuspb.LoadCollectionRequest{
 		CollectionName: collName,
-		ReplicaNumber:  1, // default replica number
 	}
 
 	for _, opt := range opts {
diff --git a/entity/index.go b/entity/index.go
index 76adcac..eafdade 100644
--- a/entity/index.go
+++ b/entity/index.go
@@ -54,6 +54,7 @@ const (
 	Trie     IndexType = "Trie"
 	Sorted   IndexType = "STL_SORT"
 	Inverted IndexType = "INVERTED"
+	Bitmap   IndexType = "BITMAP"
 )
 
 // Metric Constants


Test patch:
diff --git a/client/collection_test.go b/client/collection_test.go
index 6fb3dd1..d0021e9 100644
--- a/client/collection_test.go
+++ b/client/collection_test.go
@@ -50,7 +50,6 @@ func (s *CollectionSuite) TestListCollections() {
 			tc.names = append(tc.names, fmt.Sprintf("coll_%d", base))
 			inMem := rand.Intn(100)
 			if inMem%2 == 0 {
-
 				tc.inMem = append(tc.inMem, 100)
 			} else {
 				tc.inMem = append(tc.inMem, 0)
@@ -148,7 +147,6 @@ func (s *CollectionSuite) TestCreateCollection() {
 				}
 				s.Equal(shardsNum, req.GetShardsNum())
 				s.Equal(commonpb.ConsistencyLevel_Eventually, req.GetConsistencyLevel())
-
 			}).
 			Return(&commonpb.Status{ErrorCode: commonpb.ErrorCode_Success}, nil)
 		s.mock.EXPECT().HasCollection(mock.Anything, &milvuspb.HasCollectionRequest{CollectionName: testCollectionName}).Return(&milvuspb.BoolResponse{Status: &commonpb.Status{}, Value: false}, nil)
@@ -158,7 +156,6 @@ func (s *CollectionSuite) TestCreateCollection() {
 	})
 
 	s.Run("invalid_schemas", func() {
-
 		type testCase struct {
 			name   string
 			schema *entity.Schema
@@ -533,7 +530,7 @@ func (s *CollectionSuite) TestLoadCollection() {
 			Return(&milvuspb.BoolResponse{Status: &commonpb.Status{}, Value: true}, nil)
 
 		s.mock.EXPECT().LoadCollection(mock.Anything, mock.Anything).Run(func(_ context.Context, req *milvuspb.LoadCollectionRequest) {
-			s.Equal(testDefaultReplicaNumber, req.GetReplicaNumber())
+			s.Equal(int32(0), req.GetReplicaNumber())
 			s.Equal(testCollectionName, req.GetCollectionName())
 		}).Return(&commonpb.Status{ErrorCode: commonpb.ErrorCode_Success}, nil)
 
diff --git a/entity/index_scalar_test.go b/entity/index_scalar_test.go
index 5442f0d..8cd01a7 100644
--- a/entity/index_scalar_test.go
+++ b/entity/index_scalar_test.go
@@ -22,4 +22,14 @@ func TestScalarIndex(t *testing.T) {
 
 	assert.EqualValues(t, Trie, idxWithType.IndexType())
 	assert.EqualValues(t, Trie, idxWithType.Params()[tIndexType])
+
+	idxWithType = NewScalarIndexWithType(Inverted)
+
+	assert.EqualValues(t, Inverted, idxWithType.IndexType())
+	assert.EqualValues(t, Inverted, idxWithType.Params()[tIndexType])
+
+	idxWithType = NewScalarIndexWithType(Bitmap)
+
+	assert.EqualValues(t, Bitmap, idxWithType.IndexType())
+	assert.EqualValues(t, Bitmap, idxWithType.Params()[tIndexType])
 }
diff --git a/test/common/response_check.go b/test/common/response_check.go
index 3d58b3d..1a5840d 100644
--- a/test/common/response_check.go
+++ b/test/common/response_check.go
@@ -340,3 +340,13 @@ func CheckNotContainsDb(t *testing.T, dbs []entity.Database, dbName string) {
 	allDbNames := getDbNames(dbs)
 	require.NotContainsf(t, allDbNames, dbName, fmt.Sprintf("%s db should not be in dbs: %v", dbName, dbs))
 }
+
+// Checks whether the list contains the specified value
+func CheckContainsValue(fieldNames []interface{}, fieldName interface{}) bool {
+	for _, v := range fieldNames {
+		if v == fieldName {
+			return true
+		}
+	}
+	return false
+}
diff --git a/test/common/utils.go b/test/common/utils.go
index 80e6bfb..3e6fe14 100644
--- a/test/common/utils.go
+++ b/test/common/utils.go
@@ -149,6 +149,20 @@ func GetAllFieldsName(enableDynamicField bool, onlyScalar bool) []string {
 	return allFieldName
 }
 
+func GetInt64FloatVecArrayFieldsName(enableDynamicField bool) []string {
+	allFieldName := []string{
+		DefaultIntFieldName,
+		DefaultFloatFieldName,
+		DefaultFloatVecFieldName,
+	}
+	allFieldName = append(allFieldName, AllArrayFieldsName...)
+
+	if enableDynamicField {
+		allFieldName = append(allFieldName, DefaultDynamicFieldName)
+	}
+	return allFieldName
+}
+
 var r *rand.Rand
 
 func init() {
diff --git a/test/testcases/index_test.go b/test/testcases/index_test.go
index fb98229..3e30051 100644
--- a/test/testcases/index_test.go
+++ b/test/testcases/index_test.go
@@ -338,6 +338,62 @@ func TestCreateInvertedScalarIndex(t *testing.T) {
 	common.CheckOutputFields(t, searchRes[0].Fields, common.GetAllFieldsName(false, false))
 }
 
+// create Bitmap index for all scalar fields
+func TestCreateBitmapScalarIndex(t *testing.T) {
+	// t.Skip("https://github.com/milvus-io/milvus/issues/34314")
+	ctx := createContext(t, time.Second*common.DefaultTimeout*2)
+	// connect
+	mc := createMilvusClient(ctx, t)
+
+	// create -> insert [0, 3000) -> flush -> index -> load
+	cp := CollectionParams{CollectionFieldsType: AllFields, AutoID: false, EnableDynamicField: false,
+		ShardsNum: common.DefaultShards, Dim: common.DefaultDim}
+
+	dp := DataParams{DoInsert: true, CollectionFieldsType: AllFields, start: 0, nb: common.DefaultNb,
+		dim: common.DefaultDim, EnableDynamicField: false}
+
+	// index params
+	ips := GenDefaultIndexParamsForAllVectors()
+	lp := LoadParams{DoLoad: false}
+	collName := prepareCollection(ctx, t, mc, cp, WithDataParams(dp), WithIndexParams(ips), WithLoadParams(lp),
+		WithCreateOption(client.WithConsistencyLevel(entity.ClStrong)))
+
+	// create BITMAP scalar index
+	coll, _ := mc.DescribeCollection(ctx, collName)
+	idx := entity.NewScalarIndexWithType(entity.Bitmap)
+	// `bool` type needs fixed by: https://github.com/milvus-io/milvus/issues/34314
+	BitmapNotSupport := []interface{}{entity.FieldTypeBool, entity.FieldTypeJSON, entity.FieldTypeDouble, entity.FieldTypeFloat}
+	for _, field := range coll.Schema.Fields {
+		if supportScalarIndexFieldType(field.DataType) {
+			log.Println(field.Name, field.DataType)
+			if common.CheckContainsValue(BitmapNotSupport, field.DataType) {
+				err := mc.CreateIndex(ctx, collName, field.Name, idx, false, client.WithIndexName(field.Name))
+				// `float` and `double` types need fixed
+				common.CheckErr(t, err, !(field.DataType != entity.FieldTypeFloat && field.DataType != entity.FieldTypeDouble), "bitmap index are only supported")
+			} else {
+				err := mc.CreateIndex(ctx, collName, field.Name, idx, false, client.WithIndexName(field.Name))
+				common.CheckErr(t, err, true)
+
+				// describe index
+				indexes, _ := mc.DescribeIndex(ctx, collName, field.Name)
+				require.Len(t, indexes, 1)
+				log.Println(indexes[0].Name(), indexes[0].IndexType(), indexes[0].Params())
+				expIndex := entity.NewGenericIndex(field.Name, entity.Bitmap, idx.Params())
+				common.CheckIndexResult(t, indexes, expIndex)
+			}
+		}
+	}
+	// load -> search and output all fields
+	err := mc.LoadCollection(ctx, collName, false)
+	common.CheckErr(t, err, true)
+	queryVec := common.GenSearchVectors(common.DefaultNq, common.DefaultDim, entity.FieldTypeFloatVector)
+	sp, _ := entity.NewIndexHNSWSearchParam(74)
+	expr := fmt.Sprintf("%s > 10 && %s >= 0 && %s <= 3000 || %s > 10 || %s == true", common.DefaultIntFieldName, common.DefaultInt8FieldName, common.DefaultInt16FieldName, common.DefaultInt32FieldName, common.DefaultBoolFieldName)
+	searchRes, _ := mc.Search(ctx, collName, []string{}, expr, []string{"*"}, queryVec, common.DefaultFloatVecFieldName,
+		entity.L2, common.DefaultTopK, sp)
+	common.CheckOutputFields(t, searchRes[0].Fields, common.GetAllFieldsName(false, false))
+}
+
 // test create index on vector field
 func TestCreateScalarIndexVectorField(t *testing.T) {
 	ctx := createContext(t, time.Second*common.DefaultTimeout*2)
@@ -357,7 +413,7 @@ func TestCreateScalarIndexVectorField(t *testing.T) {
 	collName := prepareCollection(ctx, t, mc, cp, WithDataParams(dp), WithIndexParams(ips), WithLoadParams(lp),
 		WithCreateOption(client.WithConsistencyLevel(entity.ClStrong)))
 
-	for _, ip := range []entity.IndexType{entity.Sorted, entity.Trie, entity.Inverted} {
+	for _, ip := range []entity.IndexType{entity.Sorted, entity.Trie, entity.Inverted, entity.Bitmap} {
 		idx := entity.NewScalarIndexWithType(ip)
 		for _, fieldName := range common.AllVectorsFieldsName {
 			err := mc.CreateIndex(ctx, collName, fieldName, idx, false)
@@ -423,6 +479,7 @@ func TestCreateIndexJsonField(t *testing.T) {
 		errMsg    string
 	}
 	inxError := []scalarIndexError{
+		{entity.Bitmap, "bitmap index are only supported"},
 		{entity.Inverted, "INVERTED are not supported on JSON field"},
 		{entity.Sorted, "STL_SORT are only supported on numeric field"},
 		{entity.Trie, "TRIE are only supported on varchar field"},
@@ -483,6 +540,59 @@ func TestCreateIndexArrayField(t *testing.T) {
 	}
 }
 
+func TestCreateBitmapIndexOnArrayField(t *testing.T) {
+	// t.Skip("https://github.com/milvus-io/milvus/issues/34314")
+	ctx := createContext(t, time.Second*common.DefaultTimeout)
+	// connect
+	mc := createMilvusClient(ctx, t)
+
+	// create collection
+	cp := CollectionParams{CollectionFieldsType: Int64FloatVecArray, AutoID: false, EnableDynamicField: true,
+		ShardsNum: common.DefaultShards, Dim: common.DefaultDim, MaxCapacity: common.TestCapacity}
+	collName := createCollection(ctx, t, mc, cp)
+
+	// prepare and insert data
+	dp := DataParams{CollectionName: collName, PartitionName: "", CollectionFieldsType: Int64FloatVecArray,
+		start: 0, nb: common.DefaultNb, dim: common.DefaultDim, EnableDynamicField: true, WithRows: false}
+	_, _ = insertData(ctx, t, mc, dp, common.WithArrayCapacity(common.TestCapacity))
+
+	// flush and check row count
+	errFlush := mc.Flush(ctx, collName, false)
+	common.CheckErr(t, errFlush, true)
+
+	// create vector field index
+	idx, _ := entity.NewIndexHNSW(entity.L2, 8, 96)
+	err := mc.CreateIndex(ctx, collName, common.DefaultFloatVecFieldName, idx, false)
+	common.CheckErr(t, err, true)
+
+	// create BITMAP and SCANN index on array field
+	vectorIdx, _ := entity.NewIndexSCANN(entity.L2, 10, false)
+	// need fixed `int16Array`, `int32Array`, `int64Array`, `varcharArray`
+	BitmapNotSupportFiledNames := []interface{}{common.DefaultFloatArrayField, common.DefaultDoubleArrayField, common.DefaultInt16ArrayField, common.DefaultInt32ArrayField, common.DefaultInt64ArrayField, common.DefaultVarcharArrayField}
+	scalarIdx := entity.NewScalarIndexWithType(entity.Bitmap)
+	collection, _ := mc.DescribeCollection(ctx, collName)
+	for _, field := range collection.Schema.Fields {
+		if field.DataType == entity.FieldTypeArray {
+			// create scalar index
+			err := mc.CreateIndex(ctx, collName, field.Name, scalarIdx, false, client.WithIndexName(field.Name+"scalar_index"))
+			common.CheckErr(t, err, !common.CheckContainsValue(BitmapNotSupportFiledNames, field.Name), "bitmap index are only supported", "failed to create index")
+			// create vector index
+			err1 := mc.CreateIndex(ctx, collName, field.Name, vectorIdx, false, client.WithIndexName("vector_index"))
+			common.CheckErr(t, err1, false, "data type should be FloatVector, Float16Vector or BFloat16Vector")
+		}
+	}
+
+	// load -> search and output all fields
+	errLoad := mc.LoadCollection(ctx, collName, false)
+	common.CheckErr(t, errLoad, true)
+	queryVec := common.GenSearchVectors(common.DefaultNq, common.DefaultDim, entity.FieldTypeFloatVector)
+	sp, _ := entity.NewIndexHNSWSearchParam(74)
+	expr := fmt.Sprintf("%s > 10 && array_length(%s) == 100", common.DefaultIntFieldName, common.DefaultInt8ArrayField)
+	searchRes, _ := mc.Search(ctx, collName, []string{}, expr, []string{"*"}, queryVec, common.DefaultFloatVecFieldName,
+		entity.L2, common.DefaultTopK, sp)
+	common.CheckOutputFields(t, searchRes[0].Fields, common.GetInt64FloatVecArrayFieldsName(true))
+}
+
 // test create index with supported binary vector index
 func TestCreateIndexBinaryFlat(t *testing.T) {
 	t.Parallel()
@@ -858,6 +968,7 @@ func TestCreateSparseUnsupportedIndex(t *testing.T) {
 		entity.NewScalarIndexWithType(entity.Trie),
 		entity.NewScalarIndexWithType(entity.Sorted),
 		entity.NewScalarIndexWithType(entity.Inverted),
+		entity.NewScalarIndexWithType(entity.Bitmap),
 	} {
 		err := mc.CreateIndex(ctx, collName, common.DefaultSparseVecFieldName, idx, false)
 		common.CheckErr(t, err, false, "metric type not set for vector index")
diff --git a/test/testcases/query_test.go b/test/testcases/query_test.go
index 7dd9cd8..1e0bf89 100644
--- a/test/testcases/query_test.go
+++ b/test/testcases/query_test.go
@@ -769,6 +769,7 @@ func TestQueryCountJsonDynamicExpr(t *testing.T) {
 
 // test query with all kinds of array expr
 func TestQueryArrayFieldExpr(t *testing.T) {
+	t.Skip("https://github.com/milvus-io/milvus/issues/34404")
 	ctx := createContext(t, time.Second*common.DefaultTimeout)
 	// connect
 	mc := createMilvusClient(ctx, t)
@@ -836,6 +837,36 @@ func TestQueryArrayFieldExpr(t *testing.T) {
 			common.CheckErr(t, err, true)
 			require.Equal(t, _exprCount.count, countRes.GetColumn(common.QueryCountFieldName).(*entity.ColumnInt64).Data()[0])
 		}
+
+		// build BITMAP scalar index and query
+		// release collection
+		errRelease := mc.ReleaseCollection(ctx, "collName")
+		common.CheckErr(t, errRelease, false, "not exist")
+
+		// need fixed `int16Array`, `int32Array`, `int64Array`, `varcharArray`
+		BitmapNotSupportFiledNames := []interface{}{common.DefaultFloatArrayField, common.DefaultDoubleArrayField, common.DefaultInt16ArrayField, common.DefaultInt32ArrayField, common.DefaultInt64ArrayField, common.DefaultVarcharArrayField}
+		scalarIdx := entity.NewScalarIndexWithType(entity.Bitmap)
+		collection, _ := mc.DescribeCollection(ctx, collName)
+		for _, field := range collection.Schema.Fields {
+			if field.DataType == entity.FieldTypeArray && !common.CheckContainsValue(BitmapNotSupportFiledNames, field.Name) {
+				// create BITMAP scalar index
+				err := mc.CreateIndex(ctx, collName, field.Name, scalarIdx, false, client.WithIndexName(field.Name+"scalar_index"))
+				common.CheckErr(t, err, true)
+			}
+		}
+
+		//load collection
+		errLoad = mc.LoadCollection(ctx, collName, true)
+		common.CheckErr(t, errLoad, true)
+
+		for _, _exprCount := range exprCounts {
+			log.Println(_exprCount.expr)
+			countRes, err := mc.Query(ctx, collName,
+				[]string{}, _exprCount.expr, []string{common.QueryCountFieldName})
+			log.Println(countRes.GetColumn(common.QueryCountFieldName).FieldData())
+			common.CheckErr(t, err, true)
+			require.Equal(t, _exprCount.count, countRes.GetColumn(common.QueryCountFieldName).(*entity.ColumnInt64).Data()[0])
+		}
 	}
 }