Repository: knative-sandbox/eventing-kafka-broker
Pull request #2460 (2022-08-03 07:49:56)

[release-1.6] Align backoff delay to old source
This is an automated cherry-pick of #2452

knative-prow[bot]: [APPROVALNOTIFIER] This PR is **NOT APPROVED**

This pull-request has been approved by: *<a href="https://github.com/knative-sandbox/eventing-kafka-broker/pull/2460#" title="Author self-approved">knative-prow-robot</a>*
**Once this PR has been reviewed and has the lgtm label**, please assign evankanderson for approval by writing `/assign @evankanderson` in a comment. For more information see:[The Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).

The full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=knative-sandbox%2Feventing-kafka-broker).

<details open>
Needs approval from an approver in each of these files:

- **[OWNERS](https://github.com/knative-sandbox/eventing-kafka-broker/blob/release-1.6/OWNERS)**

Approvers can indicate their approval by writing `/approve` in a comment
Approvers can cancel approval by writing `/approve cancel` in a comment
</details>
<!-- META={"approvers":["evankanderson"]} -->
codecov[bot]: # [Codecov](https://codecov.io/gh/knative-sandbox/eventing-kafka-broker/pull/2460?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=knative-sandbox) Report
> Merging [#2460](https://codecov.io/gh/knative-sandbox/eventing-kafka-broker/pull/2460?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=knative-sandbox) (09a8a60) into [release-1.6](https://codecov.io/gh/knative-sandbox/eventing-kafka-broker/commit/7bbec96ce653b333e4da1d61f8f64d109039eddd?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=knative-sandbox) (7bbec96) will **not change** coverage.
> The diff coverage is `100.00%`.

```diff
@@             Coverage Diff              @@
##           release-1.6    #2460   +/-   ##
============================================
  Coverage        59.95%   59.95%           
============================================
  Files               69       69           
  Lines             6972     6972           
============================================
  Hits              4180     4180           
  Misses            2496     2496           
  Partials           296      296           
```


| [Impacted Files](https://codecov.io/gh/knative-sandbox/eventing-kafka-broker/pull/2460?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=knative-sandbox) | Coverage Δ | |
|---|---|---|
| [control-plane/pkg/reconciler/source/source.go](https://codecov.io/gh/knative-sandbox/eventing-kafka-broker/pull/2460/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=knative-sandbox#diff-Y29udHJvbC1wbGFuZS9wa2cvcmVjb25jaWxlci9zb3VyY2Uvc291cmNlLmdv) | `87.59% <100.00%> (ø)` | |

Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=knative-sandbox). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=knative-sandbox)

knative-prow[bot]: @knative-prow-robot: The following test **failed**, say `/retest` to rerun all failed tests or `/retest-required` to rerun all mandatory failed tests:

Test name | Commit | Details | Required | Rerun command
--- | --- | --- | --- | ---
reconciler-tests_eventing-kafka-broker_release-1.6 | 09a8a600abd0c7b64173dbb88941047bff1b5f29 | [link](https://prow.knative.dev/view/gs/knative-prow/pr-logs/pull/knative-sandbox_eventing-kafka-broker/2460/reconciler-tests_eventing-kafka-broker_release-1.6/1554736317273739264) | true | `/test reconciler-tests_eventing-kafka-broker_release-1.6`

[Your PR dashboard](https://prow.knative.dev/pr).

<details>

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
</details>
<!-- test report -->
knative-prow[bot]: @knative-prow-robot: The following tests **failed**, say `/retest` to rerun all failed tests or `/retest-required` to rerun all mandatory failed tests:

Test name | Commit | Details | Required | Rerun command
--- | --- | --- | --- | ---
reconciler-tests_eventing-kafka-broker_release-1.6 | 09a8a600abd0c7b64173dbb88941047bff1b5f29 | [link](https://prow.knative.dev/view/gs/knative-prow/pr-logs/pull/knative-sandbox_eventing-kafka-broker/2460/reconciler-tests_eventing-kafka-broker_release-1.6/1554736317273739264) | true | `/test reconciler-tests_eventing-kafka-broker_release-1.6`
upgrade-tests_eventing-kafka-broker_release-1.6 | 09a8a600abd0c7b64173dbb88941047bff1b5f29 | [link](https://prow.knative.dev/view/gs/knative-prow/pr-logs/pull/knative-sandbox_eventing-kafka-broker/2460/upgrade-tests_eventing-kafka-broker_release-1.6/1554736317219213312) | true | `/test upgrade-tests_eventing-kafka-broker_release-1.6`

[Your PR dashboard](https://prow.knative.dev/pr).

<details>

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
</details>
<!-- test report -->
knative-prow[bot]: [APPROVALNOTIFIER] This PR is **APPROVED**

This pull-request has been approved by: *<a href="https://github.com/knative-sandbox/eventing-kafka-broker/pull/2460#" title="Author self-approved">knative-prow-robot</a>*, *<a href="https://github.com/knative-sandbox/eventing-kafka-broker/pull/2460#pullrequestreview-1059982180" title="Approved">pierDipi</a>*

The full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=knative-sandbox%2Feventing-kafka-broker).

The pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)

<details >
Needs approval from an approver in each of these files:

- ~~[OWNERS](https://github.com/knative-sandbox/eventing-kafka-broker/blob/release-1.6/OWNERS)~~ [pierDipi]

Approvers can indicate their approval by writing `/approve` in a comment
Approvers can cancel approval by writing `/approve cancel` in a comment
</details>
<!-- META={"approvers":[]} -->

Patch:
diff --git a/control-plane/pkg/reconciler/source/source.go b/control-plane/pkg/reconciler/source/source.go
index 2e3a7b2d3..c3536ce35 100644
--- a/control-plane/pkg/reconciler/source/source.go
+++ b/control-plane/pkg/reconciler/source/source.go
@@ -126,7 +126,7 @@ func (r Reconciler) reconcileConsumerGroup(ctx context.Context, ks *sources.Kafk
 						DeliverySpec: &eventingduck.DeliverySpec{
 							Retry:         pointer.Int32(10),
 							BackoffPolicy: &backoffPolicy,
-							BackoffDelay:  pointer.String("PT10S"),
+							BackoffDelay:  pointer.String("PT0.3S"),
 							Timeout:       pointer.String("PT600S"),
 						},
 						Ordering: DefaultDeliveryOrder,


Test patch:
diff --git a/control-plane/pkg/reconciler/source/source_test.go b/control-plane/pkg/reconciler/source/source_test.go
index 09d333442..2ace88d4a 100644
--- a/control-plane/pkg/reconciler/source/source_test.go
+++ b/control-plane/pkg/reconciler/source/source_test.go
@@ -112,7 +112,7 @@ func TestReconcileKind(t *testing.T) {
 								internals.Ordered,
 								NewConsumerTimeout("PT600S"),
 								NewConsumerRetry(10),
-								NewConsumerBackoffDelay("PT10S"),
+								NewConsumerBackoffDelay("PT0.3S"),
 								NewConsumerBackoffPolicy(eventingduck.BackoffPolicyExponential),
 							),
 						),
@@ -158,7 +158,7 @@ func TestReconcileKind(t *testing.T) {
 								internals.Ordered,
 								NewConsumerTimeout("PT600S"),
 								NewConsumerRetry(10),
-								NewConsumerBackoffDelay("PT10S"),
+								NewConsumerBackoffDelay("PT0.3S"),
 								NewConsumerBackoffPolicy(eventingduck.BackoffPolicyExponential),
 							),
 						),
@@ -286,7 +286,7 @@ func TestReconcileKind(t *testing.T) {
 								internals.Ordered,
 								NewConsumerTimeout("PT600S"),
 								NewConsumerRetry(10),
-								NewConsumerBackoffDelay("PT10S"),
+								NewConsumerBackoffDelay("PT0.3S"),
 								NewConsumerBackoffPolicy(eventingduck.BackoffPolicyExponential),
 							),
 						),
@@ -398,7 +398,7 @@ func TestReconcileKind(t *testing.T) {
 								internals.Ordered,
 								NewConsumerTimeout("PT600S"),
 								NewConsumerRetry(10),
-								NewConsumerBackoffDelay("PT10S"),
+								NewConsumerBackoffDelay("PT0.3S"),
 								NewConsumerBackoffPolicy(eventingduck.BackoffPolicyExponential),
 							),
 						),
@@ -447,7 +447,7 @@ func TestReconcileKind(t *testing.T) {
 								internals.Ordered,
 								NewConsumerTimeout("PT600S"),
 								NewConsumerRetry(10),
-								NewConsumerBackoffDelay("PT10S"),
+								NewConsumerBackoffDelay("PT0.3S"),
 								NewConsumerBackoffPolicy(eventingduck.BackoffPolicyExponential),
 							),
 						),
@@ -495,7 +495,7 @@ func TestReconcileKind(t *testing.T) {
 								internals.Ordered,
 								NewConsumerTimeout("PT600S"),
 								NewConsumerRetry(10),
-								NewConsumerBackoffDelay("PT10S"),
+								NewConsumerBackoffDelay("PT0.3S"),
 								NewConsumerBackoffPolicy(eventingduck.BackoffPolicyExponential),
 							),
 						),
@@ -527,7 +527,7 @@ func TestReconcileKind(t *testing.T) {
 									internals.Ordered,
 									NewConsumerTimeout("PT600S"),
 									NewConsumerRetry(10),
-									NewConsumerBackoffDelay("PT10S"),
+									NewConsumerBackoffDelay("PT0.3S"),
 									NewConsumerBackoffPolicy(eventingduck.BackoffPolicyExponential),
 								),
 							),
@@ -585,7 +585,7 @@ func TestReconcileKind(t *testing.T) {
 									internals.Ordered,
 									NewConsumerTimeout("PT600S"),
 									NewConsumerRetry(10),
-									NewConsumerBackoffDelay("PT10S"),
+									NewConsumerBackoffDelay("PT0.3S"),
 									NewConsumerBackoffPolicy(eventingduck.BackoffPolicyExponential),
 								),
 							),
@@ -642,7 +642,7 @@ func TestReconcileKind(t *testing.T) {
 									internals.Ordered,
 									NewConsumerTimeout("PT600S"),
 									NewConsumerRetry(10),
-									NewConsumerBackoffDelay("PT10S"),
+									NewConsumerBackoffDelay("PT0.3S"),
 									NewConsumerBackoffPolicy(eventingduck.BackoffPolicyExponential),
 								),
 							),
@@ -685,7 +685,7 @@ func TestReconcileKind(t *testing.T) {
 								internals.Ordered,
 								NewConsumerTimeout("PT600S"),
 								NewConsumerRetry(10),
-								NewConsumerBackoffDelay("PT10S"),
+								NewConsumerBackoffDelay("PT0.3S"),
 								NewConsumerBackoffPolicy(eventingduck.BackoffPolicyExponential),
 							),
 						),
@@ -729,7 +729,7 @@ func TestReconcileKind(t *testing.T) {
 								internals.Ordered,
 								NewConsumerTimeout("PT600S"),
 								NewConsumerRetry(10),
-								NewConsumerBackoffDelay("PT10S"),
+								NewConsumerBackoffDelay("PT0.3S"),
 								NewConsumerBackoffPolicy(eventingduck.BackoffPolicyExponential),
 							),
 						),
@@ -773,7 +773,7 @@ func TestReconcileKind(t *testing.T) {
 								internals.Ordered,
 								NewConsumerTimeout("PT600S"),
 								NewConsumerRetry(10),
-								NewConsumerBackoffDelay("PT10S"),
+								NewConsumerBackoffDelay("PT0.3S"),
 								NewConsumerBackoffPolicy(eventingduck.BackoffPolicyExponential),
 							),
 						),
@@ -818,7 +818,7 @@ func TestReconcileKind(t *testing.T) {
 								internals.Ordered,
 								NewConsumerTimeout("PT600S"),
 								NewConsumerRetry(10),
-								NewConsumerBackoffDelay("PT10S"),
+								NewConsumerBackoffDelay("PT0.3S"),
 								NewConsumerBackoffPolicy(eventingduck.BackoffPolicyExponential),
 							),
 						),