Repository: knative-sandbox/eventing-kafka
Pull request #103 (2020-10-13 19:40:50)

Move constants to common for clean dependency graph.
The KafkaChannel `pkg/apis/` content has a couple of dependencies into the `pkg/channel/consolidated/` implementation which results in a circular dependency chain.  This is not causing a problem (build or otherwise), but is just generally wrong and should be de-tangled.  It's only a couple constant values that need to be moved - just basic cleanup : )




knative-prow-robot: [APPROVALNOTIFIER] This PR is **APPROVED**

This pull-request has been approved by: *<a href="https://github.com/knative-sandbox/eventing-kafka/pull/103#" title="Author self-approved">travis-minke-sap</a>*

The full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=knative-sandbox%2Feventing-kafka).

The pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)

<details >
Needs approval from an approver in each of these files:

- ~~[OWNERS](https://github.com/knative-sandbox/eventing-kafka/blob/master/OWNERS)~~ [travis-minke-sap]

Approvers can indicate their approval by writing `/approve` in a comment
Approvers can cancel approval by writing `/approve cancel` in a comment
</details>
<!-- META={"approvers":[]} -->
knative-prow-robot: @travis-minke-sap: The following test **failed**, say `/retest` to rerun all failed tests:

Test name | Commit | Details | Rerun command
--- | --- | --- | ---
pull-knative-sandbox-eventing-kafka-integration-tests | 4364b6875f00143d56d52b34ea2e52a6ed8cafaf | [link](https://prow.knative.dev/view/gs/knative-prow/pr-logs/pull/knative-sandbox_eventing-kafka/103/pull-knative-sandbox-eventing-kafka-integration-tests/1316791132755070976) | `/test pull-knative-sandbox-eventing-kafka-integration-tests`

[Full PR test history](https://gubernator.knative.dev/pr/knative-sandbox_eventing-kafka/103). [Your PR dashboard](https://gubernator.knative.dev/pr/travis-minke-sap).

<details>

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
</details>
<!-- test report -->
travis-minke-sap: /test pull-knative-sandbox-eventing-kafka-integration-tests

grrr... flaky integration tests...
knative-prow-robot: @travis-minke-sap: The following test **failed**, say `/retest` to rerun all failed tests:

Test name | Commit | Details | Rerun command
--- | --- | --- | ---
pull-knative-sandbox-eventing-kafka-integration-tests | 4364b6875f00143d56d52b34ea2e52a6ed8cafaf | [link](https://prow.knative.dev/view/gs/knative-prow/pr-logs/pull/knative-sandbox_eventing-kafka/103/pull-knative-sandbox-eventing-kafka-integration-tests/1316802709029916672) | `/test pull-knative-sandbox-eventing-kafka-integration-tests`

[Full PR test history](https://gubernator.knative.dev/pr/knative-sandbox_eventing-kafka/103). [Your PR dashboard](https://gubernator.knative.dev/pr/travis-minke-sap).

<details>

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
</details>
<!-- test report -->

Patch:
diff --git a/hack/tools.go b/hack/tools.go
index a50064f6e..858759b3a 100644
--- a/hack/tools.go
+++ b/hack/tools.go
@@ -29,6 +29,4 @@ import (
 	_ "knative.dev/eventing/test/test_images/performance"
 	_ "knative.dev/eventing/test/test_images/print"
 	_ "knative.dev/eventing/test/test_images/recordevents"
-	_ "knative.dev/eventing/test/test_images/sequencestepper"
-	_ "knative.dev/eventing/test/test_images/transformevents"
 )
diff --git a/pkg/apis/messaging/v1alpha1/kafka_channel_defaults.go b/pkg/apis/messaging/v1alpha1/kafka_channel_defaults.go
index 38559eef0..6180798a1 100644
--- a/pkg/apis/messaging/v1alpha1/kafka_channel_defaults.go
+++ b/pkg/apis/messaging/v1alpha1/kafka_channel_defaults.go
@@ -19,9 +19,8 @@ package v1alpha1
 import (
 	"context"
 
+	"knative.dev/eventing-kafka/pkg/common/constants"
 	"knative.dev/eventing/pkg/apis/messaging"
-
-	"knative.dev/eventing-kafka/pkg/channel/consolidated/utils"
 )
 
 func (c *KafkaChannel) SetDefaults(ctx context.Context) {
@@ -40,11 +39,11 @@ func (c *KafkaChannel) SetDefaults(ctx context.Context) {
 	c.Spec.SetDefaults(ctx)
 }
 
-func (cs *KafkaChannelSpec) SetDefaults(ctx context.Context) {
+func (cs *KafkaChannelSpec) SetDefaults(_ context.Context) {
 	if cs.NumPartitions == 0 {
-		cs.NumPartitions = utils.DefaultNumPartitions
+		cs.NumPartitions = constants.DefaultNumPartitions
 	}
 	if cs.ReplicationFactor == 0 {
-		cs.ReplicationFactor = utils.DefaultReplicationFactor
+		cs.ReplicationFactor = constants.DefaultReplicationFactor
 	}
 }
diff --git a/pkg/apis/messaging/v1beta1/kafka_channel_defaults.go b/pkg/apis/messaging/v1beta1/kafka_channel_defaults.go
index 7438adb08..ae04a447c 100644
--- a/pkg/apis/messaging/v1beta1/kafka_channel_defaults.go
+++ b/pkg/apis/messaging/v1beta1/kafka_channel_defaults.go
@@ -19,9 +19,8 @@ package v1beta1
 import (
 	"context"
 
+	"knative.dev/eventing-kafka/pkg/common/constants"
 	"knative.dev/eventing/pkg/apis/messaging"
-
-	"knative.dev/eventing-kafka/pkg/channel/consolidated/utils"
 )
 
 func (c *KafkaChannel) SetDefaults(ctx context.Context) {
@@ -42,9 +41,9 @@ func (c *KafkaChannel) SetDefaults(ctx context.Context) {
 
 func (cs *KafkaChannelSpec) SetDefaults(ctx context.Context) {
 	if cs.NumPartitions == 0 {
-		cs.NumPartitions = utils.DefaultNumPartitions
+		cs.NumPartitions = constants.DefaultNumPartitions
 	}
 	if cs.ReplicationFactor == 0 {
-		cs.ReplicationFactor = utils.DefaultReplicationFactor
+		cs.ReplicationFactor = constants.DefaultReplicationFactor
 	}
 }
diff --git a/pkg/channel/consolidated/utils/util.go b/pkg/channel/consolidated/utils/util.go
index 58687d57d..a4423918e 100644
--- a/pkg/channel/consolidated/utils/util.go
+++ b/pkg/channel/consolidated/utils/util.go
@@ -34,12 +34,6 @@ const (
 
 	KafkaChannelSeparator = "."
 
-	// DefaultNumPartitions defines the default number of partitions
-	DefaultNumPartitions = 1
-
-	// DefaultReplicationFactor defines the default number of replications
-	DefaultReplicationFactor = 1
-
 	knativeKafkaTopicPrefix = "knative-messaging-kafka"
 
 	DefaultMaxIdleConns        = 1000
diff --git a/pkg/common/constants/constants.go b/pkg/common/constants/constants.go
new file mode 100644
index 000000000..2534edc89
--- /dev/null
+++ b/pkg/common/constants/constants.go
@@ -0,0 +1,24 @@
+/*
+Copyright 2020 The Knative Authors
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package constants
+
+const (
+
+	// KafkaChannel Spec Defaults
+	DefaultNumPartitions     = 1
+	DefaultReplicationFactor = 1
+)
diff --git a/vendor/modules.txt b/vendor/modules.txt
index a08b16341..1d00d2fbd 100644
--- a/vendor/modules.txt
+++ b/vendor/modules.txt
@@ -1177,8 +1177,6 @@ knative.dev/eventing/test/test_images/heartbeats
 knative.dev/eventing/test/test_images/performance
 knative.dev/eventing/test/test_images/print
 knative.dev/eventing/test/test_images/recordevents
-knative.dev/eventing/test/test_images/sequencestepper
-knative.dev/eventing/test/test_images/transformevents
 # knative.dev/pkg v0.0.0-20201014184531-9e655c6b02f6
 ## explicit
 knative.dev/pkg/apis


Test patch:
diff --git a/pkg/apis/messaging/v1alpha1/kafka_channel_defaults_test.go b/pkg/apis/messaging/v1alpha1/kafka_channel_defaults_test.go
index c48693f3d..f5151a6fb 100644
--- a/pkg/apis/messaging/v1alpha1/kafka_channel_defaults_test.go
+++ b/pkg/apis/messaging/v1alpha1/kafka_channel_defaults_test.go
@@ -17,11 +17,9 @@ import (
 	"context"
 	"testing"
 
-	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
-
-	"knative.dev/eventing-kafka/pkg/channel/consolidated/utils"
-
 	"github.com/google/go-cmp/cmp"
+	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+	"knative.dev/eventing-kafka/pkg/common/constants"
 )
 
 const (
@@ -41,8 +39,8 @@ func TestKafkaChannelDefaults(t *testing.T) {
 					Annotations: map[string]string{"messaging.knative.dev/subscribable": "v1alpha1"},
 				},
 				Spec: KafkaChannelSpec{
-					NumPartitions:     utils.DefaultNumPartitions,
-					ReplicationFactor: utils.DefaultReplicationFactor,
+					NumPartitions:     constants.DefaultNumPartitions,
+					ReplicationFactor: constants.DefaultReplicationFactor,
 				},
 			},
 		},
@@ -57,7 +55,7 @@ func TestKafkaChannelDefaults(t *testing.T) {
 					Annotations: map[string]string{"messaging.knative.dev/subscribable": "v1alpha1"},
 				},
 				Spec: KafkaChannelSpec{
-					NumPartitions:     utils.DefaultNumPartitions,
+					NumPartitions:     constants.DefaultNumPartitions,
 					ReplicationFactor: testReplicationFactor,
 				},
 			},
@@ -74,7 +72,7 @@ func TestKafkaChannelDefaults(t *testing.T) {
 				},
 				Spec: KafkaChannelSpec{
 					NumPartitions:     testNumPartitions,
-					ReplicationFactor: utils.DefaultReplicationFactor,
+					ReplicationFactor: constants.DefaultReplicationFactor,
 				},
 			},
 		},
diff --git a/pkg/apis/messaging/v1beta1/kafka_channel_defaults_test.go b/pkg/apis/messaging/v1beta1/kafka_channel_defaults_test.go
index cac1ca396..9e2a86ae4 100644
--- a/pkg/apis/messaging/v1beta1/kafka_channel_defaults_test.go
+++ b/pkg/apis/messaging/v1beta1/kafka_channel_defaults_test.go
@@ -17,11 +17,9 @@ import (
 	"context"
 	"testing"
 
-	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
-
-	"knative.dev/eventing-kafka/pkg/channel/consolidated/utils"
-
 	"github.com/google/go-cmp/cmp"
+	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+	"knative.dev/eventing-kafka/pkg/common/constants"
 )
 
 const (
@@ -41,8 +39,8 @@ func TestKafkaChannelDefaults(t *testing.T) {
 					Annotations: map[string]string{"messaging.knative.dev/subscribable": "v1"},
 				},
 				Spec: KafkaChannelSpec{
-					NumPartitions:     utils.DefaultNumPartitions,
-					ReplicationFactor: utils.DefaultReplicationFactor,
+					NumPartitions:     constants.DefaultNumPartitions,
+					ReplicationFactor: constants.DefaultReplicationFactor,
 				},
 			},
 		},
@@ -57,7 +55,7 @@ func TestKafkaChannelDefaults(t *testing.T) {
 					Annotations: map[string]string{"messaging.knative.dev/subscribable": "v1"},
 				},
 				Spec: KafkaChannelSpec{
-					NumPartitions:     utils.DefaultNumPartitions,
+					NumPartitions:     constants.DefaultNumPartitions,
 					ReplicationFactor: testReplicationFactor,
 				},
 			},
@@ -74,7 +72,7 @@ func TestKafkaChannelDefaults(t *testing.T) {
 				},
 				Spec: KafkaChannelSpec{
 					NumPartitions:     testNumPartitions,
-					ReplicationFactor: utils.DefaultReplicationFactor,
+					ReplicationFactor: constants.DefaultReplicationFactor,
 				},
 			},
 		},
diff --git a/test/config/config-tracing.yaml b/test/config/config-tracing.yaml
index 01cf5039e..35b08ea09 100644
--- a/test/config/config-tracing.yaml
+++ b/test/config/config-tracing.yaml
@@ -19,6 +19,6 @@ metadata:
   namespace: knative-eventing
 data:
   backend: "zipkin"
-  zipkin-endpoint: "http://zipkin.istio-system.svc.cluster.local:9411/api/v2/spans"
+  zipkin-endpoint: "http://zipkin.knative-eventing.svc.cluster.local:9411/api/v2/spans"
   debug: "true"
   sample-rate: "1.0"
diff --git a/test/config/monitoring.yaml b/test/config/monitoring.yaml
new file mode 100644
index 000000000..f219821aa
--- /dev/null
+++ b/test/config/monitoring.yaml
@@ -0,0 +1,62 @@
+# Copyright 2018 The Knative Authors
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+apiVersion: v1
+kind: Service
+metadata:
+  name: zipkin
+  namespace: knative-eventing
+spec:
+  ports:
+  - name: http
+    port: 9411
+  selector:
+    app: zipkin
+---
+apiVersion: apps/v1
+kind: Deployment
+metadata:
+  name: zipkin
+  namespace: knative-eventing
+spec:
+  replicas: 1
+  selector:
+    matchLabels:
+      app: zipkin
+  template:
+    metadata:
+      labels:
+        app: zipkin
+      annotations:
+        sidecar.istio.io/inject: "false"
+    spec:
+      containers:
+      - name: zipkin
+        image: docker.io/openzipkin/zipkin:2.13.0
+        imagePullPolicy: IfNotPresent
+        ports:
+        - containerPort: 9411
+        env:
+        - name: POD_NAMESPACE
+          valueFrom:
+            fieldRef:
+              apiVersion: v1
+              fieldPath: metadata.namespace
+        resources:
+          limits:
+            memory: 1000Mi
+          requests:
+            memory: 256Mi
+
+---
diff --git a/test/e2e-tests.sh b/test/e2e-tests.sh
index ad2d5c80f..f864895df 100755
--- a/test/e2e-tests.sh
+++ b/test/e2e-tests.sh
@@ -65,6 +65,12 @@ readonly KAFKA_CRD_CONFIG_DIR="$(mktemp -d)"
 # Kafka channel CRD config template directory.
 readonly KAFKA_SOURCE_CRD_CONFIG_DIR="config/source"
 
+# Namespace where we install Eventing components
+readonly SYSTEM_NAMESPACE="knative-eventing"
+
+# Zipking setup
+readonly KNATIVE_EVENTING_MONITORING_YAML="test/config/monitoring.yaml"
+
 function knative_setup() {
   if is_release_branch; then
     echo ">> Install Knative Eventing from ${KNATIVE_EVENTING_RELEASE}"
@@ -84,17 +90,12 @@ function knative_setup() {
   fi
   wait_until_pods_running knative-eventing || fail_test "Knative Eventing did not come up"
 
+  # Setup zipkin
+  kubectl apply -f $KNATIVE_EVENTING_MONITORING_YAML
+  wait_until_pods_running knative-eventing || fail_test "Zipkin inside eventing did not come up"
+
   # Setup config tracing for tracing tests
   kubectl replace -f $CONFIG_TRACING_CONFIG
-
-  # TODO install head if !is_release_branch
-  echo "Installing Knative Monitoring"
-  # Hack hack hack. Why is this namespace not created as part of monitoring release.
-  # https://github.com/knative/eventing/issues/3469
-  kubectl create ns knative-monitoring
-  kubectl create namespace istio-system
-  kubectl apply --filename "${KNATIVE_MONITORING_RELEASE}" || return 1
-  wait_until_pods_running istio-system || fail_test "Knative Monitoring did not come up"
 }
 
 function knative_teardown() {
diff --git a/vendor/knative.dev/eventing/test/test_images/sequencestepper/main.go b/vendor/knative.dev/eventing/test/test_images/sequencestepper/main.go
deleted file mode 100644
index 02dfa946b..000000000
--- a/vendor/knative.dev/eventing/test/test_images/sequencestepper/main.go
+++ /dev/null
@@ -1,86 +0,0 @@
-/*
-Copyright 2019 The Knative Authors
-
-Licensed under the Apache License, Version 2.0 (the "License");
-you may not use this file except in compliance with the License.
-You may obtain a copy of the License at
-
-	https://www.apache.org/licenses/LICENSE-2.0
-
-Unless required by applicable law or agreed to in writing, software
-distributed under the License is distributed on an "AS IS" BASIS,
-WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-See the License for the specific language governing permissions and
-limitations under the License.
-*/
-
-package main
-
-import (
-	"context"
-	"encoding/json"
-	"flag"
-	"log"
-
-	"knative.dev/eventing/pkg/kncloudevents"
-
-	cloudevents "github.com/cloudevents/sdk-go/v2"
-)
-
-var (
-	eventMsgAppender string
-)
-
-func init() {
-	flag.StringVar(&eventMsgAppender, "msg-appender", "", "a string we want to append on the event message")
-}
-
-func gotEvent(event cloudevents.Event) (*cloudevents.Event, error) {
-	log.Println("Received a new event: ")
-	log.Printf("[%s] %s %s: %s", event.Time().String(), event.Source(), event.Type(), string(event.Data()))
-
-	outputEvent := event.Clone()
-
-	// append eventMsgAppender to message of the data
-	var data map[string]interface{}
-	if err := json.Unmarshal(event.Data(), &data); err != nil {
-		return nil, err
-	}
-	data["msg"] = data["msg"].(string) + eventMsgAppender
-	if eventData, err := json.Marshal(&data); err != nil {
-		return nil, err
-	} else if err := outputEvent.SetData(cloudevents.ApplicationJSON, eventData); err != nil {
-		return nil, err
-	}
-
-	log.Println("Transform the event to: ")
-	log.Printf("[%s] %s %s: %s", outputEvent.Time().String(), outputEvent.Source(), outputEvent.Type(), string(outputEvent.Data()))
-
-	return &outputEvent, nil
-}
-
-func main() {
-	// parse the command line flags
-	flag.Parse()
-
-	t, err := cloudevents.NewHTTP(
-		cloudevents.WithPort(8080),
-		cloudevents.WithMiddleware(kncloudevents.CreateHandler),
-	)
-	if err != nil {
-		log.Fatalf("failed to create transport, %v", err)
-	}
-
-	c, err := cloudevents.NewClient(t,
-		cloudevents.WithTimeNow(),
-		cloudevents.WithUUIDs(),
-	)
-	if err != nil {
-		log.Fatalf("failed to create client, %v", err)
-	}
-
-	log.Printf("listening on 8080")
-	if err := c.StartReceiver(context.Background(), gotEvent); err != nil {
-		log.Fatalf("failed to start receiver: %s", err)
-	}
-}
diff --git a/vendor/knative.dev/eventing/test/test_images/sequencestepper/pod.yaml b/vendor/knative.dev/eventing/test/test_images/sequencestepper/pod.yaml
deleted file mode 100644
index 3224132df..000000000
--- a/vendor/knative.dev/eventing/test/test_images/sequencestepper/pod.yaml
+++ /dev/null
@@ -1,9 +0,0 @@
-apiVersion: v1
-kind: Pod
-metadata:
-  name: sequencestepper
-spec:
-  containers:
-    - name: sequencestepper
-      image: ko://knative.dev/eventing/test/test_images/sequencestepper
-
diff --git a/vendor/knative.dev/eventing/test/test_images/transformevents/main.go b/vendor/knative.dev/eventing/test/test_images/transformevents/main.go
deleted file mode 100644
index 651787eea..000000000
--- a/vendor/knative.dev/eventing/test/test_images/transformevents/main.go
+++ /dev/null
@@ -1,95 +0,0 @@
-/*
-Copyright 2019 The Knative Authors
-
-Licensed under the Apache License, Version 2.0 (the "License");
-you may not use this file except in compliance with the License.
-You may obtain a copy of the License at
-
-	https://www.apache.org/licenses/LICENSE-2.0
-
-Unless required by applicable law or agreed to in writing, software
-distributed under the License is distributed on an "AS IS" BASIS,
-WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-See the License for the specific language governing permissions and
-limitations under the License.
-*/
-
-package main
-
-import (
-	"context"
-	"flag"
-	"log"
-
-	"knative.dev/eventing/pkg/kncloudevents"
-	"knative.dev/eventing/test/test_images"
-
-	cloudevents "github.com/cloudevents/sdk-go/v2"
-	"go.uber.org/zap"
-)
-
-var (
-	eventType   string
-	eventSource string
-	eventData   string
-)
-
-func init() {
-	flag.StringVar(&eventType, "event-type", "", "The Event Type to use.")
-	flag.StringVar(&eventSource, "event-source", "", "Source URI to use. Defaults to the current machine's hostname")
-	flag.StringVar(&eventData, "event-data", "", "Cloudevent data body.")
-}
-
-func gotEvent(event cloudevents.Event) (*cloudevents.Event, error) {
-	log.Println("Received a new event: ")
-	log.Printf("[%s] %s %s: %s", event.Time().String(), event.Source(), event.Type(), string(event.Data()))
-
-	outputEvent := event.Clone()
-
-	if eventSource != "" {
-		outputEvent.SetSource(eventSource)
-	}
-	if eventType != "" {
-		outputEvent.SetType(eventType)
-	}
-	if eventData != "" {
-		if err := outputEvent.SetData(cloudevents.ApplicationJSON, []byte(eventData)); err != nil {
-			return nil, err
-		}
-	}
-
-	log.Println("Transform the event to: ")
-	log.Printf("[%s] %s %s: %s", outputEvent.Time().String(), outputEvent.Source(), outputEvent.Type(), string(outputEvent.Data()))
-
-	return &outputEvent, nil
-}
-
-func main() {
-	// parse the command line flags
-	flag.Parse()
-
-	logger, _ := zap.NewDevelopment()
-	if err := test_images.ConfigureTracing(logger.Sugar(), ""); err != nil {
-		log.Fatalf("Unable to setup trace publishing: %v", err)
-	}
-
-	t, err := cloudevents.NewHTTP(
-		cloudevents.WithPort(8080),
-		cloudevents.WithMiddleware(kncloudevents.CreateHandler),
-	)
-	if err != nil {
-		log.Fatalf("failed to create transport, %v", err)
-	}
-
-	c, err := cloudevents.NewClientObserved(t,
-		cloudevents.WithTracePropagation,
-	)
-	if err != nil {
-		log.Fatalf("failed to create client, %v", err)
-	}
-
-	log.Printf("listening on 8080")
-	if err := c.StartReceiver(context.Background(), gotEvent); err != nil {
-		log.Fatalf("failed to start receiver: %s", err)
-	}
-}
diff --git a/vendor/knative.dev/eventing/test/test_images/transformevents/pod.yaml b/vendor/knative.dev/eventing/test/test_images/transformevents/pod.yaml
deleted file mode 100644
index 82cc59042..000000000
--- a/vendor/knative.dev/eventing/test/test_images/transformevents/pod.yaml
+++ /dev/null
@@ -1,9 +0,0 @@
-apiVersion: v1
-kind: Pod
-metadata:
-  name: transformevents
-spec:
-  containers:
-    - name: transformevents
-      image: ko://knative.dev/eventing/test/test_images/transformevents
-