Repository: goreleaser/goreleaser
Pull request #1565 (2020-05-26 03:53:57)

chore(deps): bump github.com/goreleaser/nfpm from 1.2.1 to 1.3.0
upgraded and removed now unused field.

vercel-for-github[bot]: 
This pull request is being automatically deployed with Vercel ([learn more](https://zeit.ink/github-learn-more)).
To see the status of your deployment, click below or on the icon next to each commit.
		
  🔍 Inspect: https://vercel.com/goreleaser/goreleaser/fwtzbvhrs
  ✅ Preview: *In Progress*
		
_([b3d0dce](https://github.com/goreleaser/goreleaser/commit/b3d0dce8de7676b9ba2458152d6a64938a1fab61), update in progress)_
codecov[bot]: # [Codecov](https://codecov.io/gh/goreleaser/goreleaser/pull/1565?src=pr&el=h1) Report
> Merging [#1565](https://codecov.io/gh/goreleaser/goreleaser/pull/1565?src=pr&el=desc) into [master](https://codecov.io/gh/goreleaser/goreleaser/commit/4ac3927693661f4ccfe0ccdc8932f0b4caa3e810&el=desc) will **decrease** coverage by `0.00%`.
> The diff coverage is `89.65%`.

[![Impacted file tree graph](https://codecov.io/gh/goreleaser/goreleaser/pull/1565/graphs/tree.svg?width=650&height=150&src=pr&token=3bJvv6b7hN)](https://codecov.io/gh/goreleaser/goreleaser/pull/1565?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master    #1565      +/-   ##
==========================================
- Coverage   85.59%   85.58%   -0.01%     
==========================================
  Files          70       70              
  Lines        3852     3851       -1     
==========================================
- Hits         3297     3296       -1     
  Misses        459      459              
  Partials       96       96              
```


| [Impacted Files](https://codecov.io/gh/goreleaser/goreleaser/pull/1565?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [internal/builders/golang/build.go](https://codecov.io/gh/goreleaser/goreleaser/pull/1565/diff?src=pr&el=tree#diff-aW50ZXJuYWwvYnVpbGRlcnMvZ29sYW5nL2J1aWxkLmdv) | `98.54% <ø> (ø)` | |
| [internal/client/client.go](https://codecov.io/gh/goreleaser/goreleaser/pull/1565/diff?src=pr&el=tree#diff-aW50ZXJuYWwvY2xpZW50L2NsaWVudC5nbw==) | `100.00% <ø> (ø)` | |
| [internal/client/gitea.go](https://codecov.io/gh/goreleaser/goreleaser/pull/1565/diff?src=pr&el=tree#diff-aW50ZXJuYWwvY2xpZW50L2dpdGVhLmdv) | `100.00% <ø> (ø)` | |
| [internal/client/github.go](https://codecov.io/gh/goreleaser/goreleaser/pull/1565/diff?src=pr&el=tree#diff-aW50ZXJuYWwvY2xpZW50L2dpdGh1Yi5nbw==) | `27.43% <ø> (ø)` | |
| [internal/client/gitlab.go](https://codecov.io/gh/goreleaser/goreleaser/pull/1565/diff?src=pr&el=tree#diff-aW50ZXJuYWwvY2xpZW50L2dpdGxhYi5nbw==) | `11.82% <ø> (ø)` | |
| [internal/deprecate/deprecate.go](https://codecov.io/gh/goreleaser/goreleaser/pull/1565/diff?src=pr&el=tree#diff-aW50ZXJuYWwvZGVwcmVjYXRlL2RlcHJlY2F0ZS5nbw==) | `100.00% <ø> (ø)` | |
| [internal/exec/exec.go](https://codecov.io/gh/goreleaser/goreleaser/pull/1565/diff?src=pr&el=tree#diff-aW50ZXJuYWwvZXhlYy9leGVjLmdv) | `86.66% <ø> (ø)` | |
| [internal/git/git.go](https://codecov.io/gh/goreleaser/goreleaser/pull/1565/diff?src=pr&el=tree#diff-aW50ZXJuYWwvZ2l0L2dpdC5nbw==) | `100.00% <ø> (ø)` | |
| [internal/ids/ids.go](https://codecov.io/gh/goreleaser/goreleaser/pull/1565/diff?src=pr&el=tree#diff-aW50ZXJuYWwvaWRzL2lkcy5nbw==) | `100.00% <ø> (ø)` | |
| [internal/linux/arch.go](https://codecov.io/gh/goreleaser/goreleaser/pull/1565/diff?src=pr&el=tree#diff-aW50ZXJuYWwvbGludXgvYXJjaC5nbw==) | `100.00% <ø> (ø)` | |
| ... and [49 more](https://codecov.io/gh/goreleaser/goreleaser/pull/1565/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/goreleaser/goreleaser/pull/1565?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/goreleaser/goreleaser/pull/1565?src=pr&el=footer). Last update [69c8a50...446930a](https://codecov.io/gh/goreleaser/goreleaser/pull/1565?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


Patch:
diff --git a/go.mod b/go.mod
index 06fc28f9..19a011bf 100644
--- a/go.mod
+++ b/go.mod
@@ -13,7 +13,7 @@ require (
 	github.com/fatih/color v1.9.0
 	github.com/golangci/golangci-lint v1.27.0
 	github.com/google/go-github/v28 v28.1.1
-	github.com/goreleaser/nfpm v1.2.1
+	github.com/goreleaser/nfpm v1.3.0
 	github.com/imdario/mergo v0.3.9
 	github.com/jarcoal/httpmock v1.0.5
 	github.com/mattn/go-shellwords v1.0.10
diff --git a/go.sum b/go.sum
index a080f46d..3193a710 100644
--- a/go.sum
+++ b/go.sum
@@ -32,7 +32,6 @@ github.com/BurntSushi/xgb v0.0.0-20160522181843-27f122750802/go.mod h1:IVnqGOEym
 github.com/Djarvur/go-err113 v0.0.0-20200410182137-af658d038157 h1:hY39LwQHh+1kaovmIjOrlqnXNX6tygSRfLkkK33IkZU=
 github.com/Djarvur/go-err113 v0.0.0-20200410182137-af658d038157/go.mod h1:4UJr5HIiMZrwgkSPdsjy2uOQExX/WEILpIrO9UPGuXs=
 github.com/GoogleCloudPlatform/cloudsql-proxy v0.0.0-20191009163259-e802c2cb94ae/go.mod h1:mjwGPas4yKduTyubHvD1Atl9r1rUq8DfVy+gkVvZ+oo=
-github.com/Masterminds/semver/v3 v3.0.3/go.mod h1:VPu/7SZ7ePZ3QOrcuXROw5FAcLl4a0cBrbBpGY/8hQs=
 github.com/Masterminds/semver/v3 v3.1.0 h1:Y2lUDsFKVRSYGojLJ1yLxSXdMmMYTYls0rCvoqmMUQk=
 github.com/Masterminds/semver/v3 v3.1.0/go.mod h1:VPu/7SZ7ePZ3QOrcuXROw5FAcLl4a0cBrbBpGY/8hQs=
 github.com/OneOfOne/xxhash v1.2.2/go.mod h1:HSdplMjZKSmBqAxg5vPj2TmRDmfkzw+cTzAElWljhcU=
@@ -219,8 +218,8 @@ github.com/googleapis/gax-go/v2 v2.0.5/go.mod h1:DWXyrwAJ9X0FpwwEdw+IPEYBICEFu5m
 github.com/gookit/color v1.2.4/go.mod h1:AhIE+pS6D4Ql0SQWbBeXPHw7gY0/sjHoA4s/n1KB7xg=
 github.com/gopherjs/gopherjs v0.0.0-20181017120253-0766667cb4d1 h1:EGx4pi6eqNxGaHF6qqu48+N2wcFQ5qg5FXgOdqsJ5d8=
 github.com/gopherjs/gopherjs v0.0.0-20181017120253-0766667cb4d1/go.mod h1:wJfORRmW1u3UXTncJ5qlYoELFm8eSnnEO6hX4iZ3EWY=
-github.com/goreleaser/nfpm v1.2.1 h1:AEnu9XVmupRDTR930Z2rAs31Mj6sLIPxFcR9ESYvgDA=
-github.com/goreleaser/nfpm v1.2.1/go.mod h1:TtWrABZozuLOttX2uDlYyECfQX7x5XYkVxhjYcR6G9w=
+github.com/goreleaser/nfpm v1.3.0 h1:BPwIomC+e+yuDX9poJowzV7JFVcYA0+LwGSkbAPs2Hw=
+github.com/goreleaser/nfpm v1.3.0/go.mod h1:w0p7Kc9TAUgWMyrub63ex3M2Mgw88M4GZXoTq5UCb40=
 github.com/gorilla/websocket v1.4.0/go.mod h1:E7qHFY5m1UJ88s3WnNqhKjPHQ0heANvMoAMk2YaljkQ=
 github.com/gostaticanalysis/analysisutil v0.0.0-20190318220348-4088753ea4d3 h1:JVnpOZS+qxli+rgVl98ILOXVNbW+kb5wcxeGx8ShUIw=
 github.com/gostaticanalysis/analysisutil v0.0.0-20190318220348-4088753ea4d3/go.mod h1:eEOZF4jCKGi+aprrirO9e7WKB3beBRtWgqGunKl6pKE=
@@ -244,7 +243,6 @@ github.com/hashicorp/hcl v1.0.0 h1:0Anlzjpi4vEasTeNFn2mLJgTSwt0+6sfsiTG8qcWGx4=
 github.com/hashicorp/hcl v1.0.0/go.mod h1:E5yfLk+7swimpb2L/Alb/PJmXilQ/rhwaUYs4T20WEQ=
 github.com/hpcloud/tail v1.0.0 h1:nfCOvKYfkgYP8hkirhJocXT2+zOD8yUNjXaWfTlyFKI=
 github.com/hpcloud/tail v1.0.0/go.mod h1:ab1qPbhIpdTxEkNHXyeSf5vhxWSCs/tWer42PpOxQnU=
-github.com/imdario/mergo v0.3.8/go.mod h1:2EnlNZ0deacrJVfApfmtdGgDfMuh/nq6Ok1EcJh5FfA=
 github.com/imdario/mergo v0.3.9 h1:UauaLniWCFHWd+Jp9oCEkTBj8VO/9DKg3PV3VCNMDIg=
 github.com/imdario/mergo v0.3.9/go.mod h1:2EnlNZ0deacrJVfApfmtdGgDfMuh/nq6Ok1EcJh5FfA=
 github.com/inconshreveable/mousetrap v1.0.0 h1:Z8tu5sraLXCXIcARxBp/8cbvlwVa7Z1NHg9XEKhtSvM=
@@ -468,7 +466,6 @@ golang.org/x/crypto v0.0.0-20190308221718-c2843e01d9a2/go.mod h1:djNgcEr1/C05ACk
 golang.org/x/crypto v0.0.0-20190426145343-a29dc8fdc734/go.mod h1:yigFU9vqHzYiE8UmvKecakEJjdnWj3jj499lnFckfCI=
 golang.org/x/crypto v0.0.0-20190510104115-cbcb75029529/go.mod h1:yigFU9vqHzYiE8UmvKecakEJjdnWj3jj499lnFckfCI=
 golang.org/x/crypto v0.0.0-20190605123033-f99c8df09eb5/go.mod h1:yigFU9vqHzYiE8UmvKecakEJjdnWj3jj499lnFckfCI=
-golang.org/x/crypto v0.0.0-20191002192127-34f69633bfdc/go.mod h1:yigFU9vqHzYiE8UmvKecakEJjdnWj3jj499lnFckfCI=
 golang.org/x/crypto v0.0.0-20191011191535-87dc89f01550 h1:ObdrDkeb4kJdCP557AjRjq69pTHfNouLtWZG7j9rPN8=
 golang.org/x/crypto v0.0.0-20191011191535-87dc89f01550/go.mod h1:yigFU9vqHzYiE8UmvKecakEJjdnWj3jj499lnFckfCI=
 golang.org/x/exp v0.0.0-20190121172915-509febef88a4/go.mod h1:CJ0aWSM057203Lf6IL+f9T1iT9GByDxfZKAQTCR3kQA=
diff --git a/internal/pipe/nfpm/nfpm.go b/internal/pipe/nfpm/nfpm.go
index 86d851cc..b9fdd067 100644
--- a/internal/pipe/nfpm/nfpm.go
+++ b/internal/pipe/nfpm/nfpm.go
@@ -156,7 +156,6 @@ func create(ctx *context.Context, fpm config.NFPM, format, arch string, binaries
 		Vendor:      fpm.Vendor,
 		Homepage:    fpm.Homepage,
 		License:     fpm.License,
-		Bindir:      fpm.Bindir,
 		Overridables: nfpm.Overridables{
 			Conflicts:    overridden.Conflicts,
 			Depends:      overridden.Dependencies,


Test patch:
diff --git a/internal/pipe/nfpm/nfpm_test.go b/internal/pipe/nfpm/nfpm_test.go
index f7998c09..9efa2176 100644
--- a/internal/pipe/nfpm/nfpm_test.go
+++ b/internal/pipe/nfpm/nfpm_test.go
@@ -273,7 +273,7 @@ func TestInvalidConfig(t *testing.T) {
 			"ID": "default",
 		},
 	})
-	require.Contains(t, Pipe{}.Run(ctx).Error(), `invalid nfpm config: package name cannot be empty`)
+	require.Contains(t, Pipe{}.Run(ctx).Error(), `invalid nfpm config: package name must be provided`)
 }
 
 func TestDefault(t *testing.T) {