Repository: lightningnetwork/lnd
Pull request #8729 (2024-05-05 20:19:24)

Add new  functions to the fn package
## Change Description
This adds new functions to the fn packages.
Changes include:
- A new file for map functions accompanied with a test file.
- Added new functions for slice accompanied with test.

This is required for this PR: https://github.com/lightningnetwork/lnd/pull/8516/
## Steps to Test
Steps for reviewers to follow to test the change.

## Pull Request Checklist
### Testing
- [ ] Your PR passes all CI checks.
- [ ] Tests covering the positive and negative (error paths) are included.
- [ ] Bug fixes contain tests triggering the bug to prevent regressions.

### Code Style and Documentation
- [ ] The change obeys the [Code Documentation and Commenting](https://github.com/lightningnetwork/lnd/blob/master/docs/code_contribution_guidelines.md#CodeDocumentation) guidelines, and lines wrap at 80.
- [ ] Commits follow the [Ideal Git Commit Structure](https://github.com/lightningnetwork/lnd/blob/master/docs/code_contribution_guidelines.md#IdealGitCommitStructure).
- [ ] Any new logging statements use an appropriate subsystem and logging level.
- [ ] Any new lncli commands have appropriate tags in the comments for the rpc in the proto file.
- [ ]  [There is a change description in the release notes](https://github.com/lightningnetwork/lnd/tree/master/docs/release-notes), or `[skip ci]` in the commit message for small changes.

📝 Please see our  [Contribution Guidelines](https://github.com/lightningnetwork/lnd/blob/master/docs/code_contribution_guidelines.md) for further guidance.


coderabbitai[bot]: <!-- This is an auto-generated comment: summarize by coderabbit.ai -->
<!-- This is an auto-generated comment: skip review by coderabbit.ai -->

> [!IMPORTANT]
> ## Auto Review Skipped
> 
> Auto reviews are disabled on this repository.
> 
> Please check the settings in the CodeRabbit UI or the `.coderabbit.yaml` file in this repository. To trigger a single review, invoke the `@coderabbitai review` command.
> 
> You can disable this status message by setting the `reviews.review_status` to `false` in the CodeRabbit configuration file.

<!-- end of auto-generated comment: skip review by coderabbit.ai --><!-- tips_start -->

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

<details>
<summary>Share</summary>

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai)
- [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai)
- [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai)
- [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

</details>

<details>
<summary>Tips</summary>

### Chat

There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai):

- Review comments: Directly reply to a review comment made by CodeRabbit. Example:
	- `I pushed a fix in commit <commit_id>.`
	- `Generate unit testing code for this file.`
	- `Open a follow-up GitHub issue for this discussion.`
- Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples:
	- `@coderabbitai generate unit testing code for this file.`
	-	`@coderabbitai modularize this function.`
- PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
	- `@coderabbitai generate interesting stats about this repository and render them as a table.`
	- `@coderabbitai show all the console.log statements in this repository.`
	- `@coderabbitai read src/utils.ts and generate unit testing code.`
	- `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.`

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

### CodeRabbit Commands (invoked as PR comments)

- `@coderabbitai pause` to pause the reviews on a PR.
- `@coderabbitai resume` to resume the paused reviews.
- `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository.
- `@coderabbitai resolve` resolve all the CodeRabbit review comments.
- `@coderabbitai help` to get help.


Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed.

### CodeRabbit Configration File (`.coderabbit.yaml`)

- You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository.
- Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information.
- If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json`

### Documentation and Community

- Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit.
- Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback.
- Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

</details>

<!-- tips_end -->
Chinwendu20: Does this need a release note? could not find anything about `fn` in the other release notes.
Roasbeef: Are you aware of this package: https://pkg.go.dev/golang.org/x/exp/maps? Most of what you've added is already here. 
Chinwendu20: > Are you aware of this package: https://pkg.go.dev/golang.org/x/exp/maps? Most of what you've added is already here.

Not really, I just checked it and it seems that is that is the case. Thanks for pointing it out would be closing this now.
Chinwendu20: Thanks for the feedback @ProofOfKeags. I would rework and open another PR.
Oops just looked down while typing this and realised that I can reopen this PR.

Patch:
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index 6d23cf8d9..429b09171 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -225,7 +225,6 @@ jobs:
         if: matrix.unit_type == 'btcd unit-cover'
         with:
           path-to-profile: coverage.txt
-          flag-name: 'unit'
           parallel: true
 
 
@@ -242,13 +241,13 @@ jobs:
       matrix:
         include:
           - name: btcd
-            args: backend=btcd cover=1
+            args: backend=btcd
           - name: bitcoind
-            args: backend=bitcoind cover=1
+            args: backend=bitcoind
           - name: bitcoind-notxindex
             args: backend="bitcoind notxindex"
           - name: bitcoind-rpcpolling
-            args: backend="bitcoind rpcpolling" cover=1
+            args: backend="bitcoind rpcpolling"
           - name: bitcoind-etcd
             args: backend=bitcoind dbbackend=etcd
           - name: bitcoind-postgres
@@ -260,7 +259,7 @@ jobs:
           - name: bitcoind-sqlite-nativesql
             args: backend=bitcoind dbbackend=sqlite nativesql=true
           - name: neutrino
-            args: backend=neutrino cover=1
+            args: backend=neutrino
     steps:
       - name: git checkout
         uses: actions/checkout@v3
@@ -277,14 +276,6 @@ jobs:
       - name: run ${{ matrix.name }}
         run: make itest-parallel ${{ matrix.args }}
 
-      - name: Send coverage
-        if: ${{ contains(matrix.args, 'cover=1') }}
-        uses: shogo82148/actions-goveralls@v1
-        with:
-          path-to-profile: coverage.txt
-          flag-name: 'itest-${{ matrix.name }}'
-          parallel: true
-
       - name: Zip log files on failure
         if: ${{ failure() }}
         timeout-minutes: 5 # timeout after 5 minute
@@ -410,13 +401,3 @@ jobs:
 
       - name: release notes check
         run: scripts/check-release-notes.sh
-  
-  # Notify about the completion of all coverage collecting jobs.
-  finish:
-    if: ${{ always() }}
-    needs: [unit-test, ubuntu-integration-test]
-    runs-on: ubuntu-latest
-    steps:
-      - uses: shogo82148/actions-goveralls@v1
-        with:
-          parallel-finished: true
diff --git a/.gitignore b/.gitignore
index a44a7b8f5..16d33c142 100644
--- a/.gitignore
+++ b/.gitignore
@@ -38,7 +38,6 @@ itest/.minerlogs
 itest/lnd-itest
 itest/btcd-itest
 itest/.logs-*
-itest/cover
 
 cmd/cmd
 *.key
diff --git a/Makefile b/Makefile
index 5ea087892..088bb4880 100644
--- a/Makefile
+++ b/Makefile
@@ -111,7 +111,7 @@ build:
 build-itest:
 	@$(call print, "Building itest btcd and lnd.")
 	CGO_ENABLED=0 $(GOBUILD) -tags="integration" -o itest/btcd-itest$(EXEC_SUFFIX) $(DEV_LDFLAGS) $(BTCD_PKG)
-	CGO_ENABLED=0 $(GOBUILD) -tags="$(ITEST_TAGS)" $(ITEST_COVERAGE) -o itest/lnd-itest$(EXEC_SUFFIX) $(DEV_LDFLAGS) $(PKG)/cmd/lnd
+	CGO_ENABLED=0 $(GOBUILD) -tags="$(ITEST_TAGS)" -o itest/lnd-itest$(EXEC_SUFFIX) $(DEV_LDFLAGS) $(PKG)/cmd/lnd
 
 	@$(call print, "Building itest binary for ${backend} backend.")
 	CGO_ENABLED=0 $(GOTEST) -v ./itest -tags="$(DEV_TAGS) $(RPC_TAGS) integration $(backend)" -c -o itest/itest.test$(EXEC_SUFFIX)
@@ -136,13 +136,8 @@ manpages:
 	@$(call print, "Generating man pages lncli.1 and lnd.1.")
 	./scripts/gen_man_pages.sh $(DESTDIR) $(PREFIX)
 
-#? install: Build and install lnd and lncli binaries and place them in $GOPATH/bin.
-install: install-binaries
-
-#? install-all: Performs all the same tasks as the install command along with generating and
-# installing the man pages for the lnd and lncli binaries. This command is useful in an
-# environment where a user has root access and so has write access to the man page directory.
-install-all: install manpages
+#? install: Build and install lnd and lncli binaries, place them in $GOPATH/bin, generate and install man pages
+install: install-binaries manpages
 
 #? release-install: Build and install lnd and lncli release binaries, place them in $GOPATH/bin
 release-install:
@@ -203,7 +198,6 @@ itest-only: db-instance
 	@$(call print, "Running integration tests with ${backend} backend.")
 	rm -rf itest/*.log itest/.logs-*; date
 	EXEC_SUFFIX=$(EXEC_SUFFIX) scripts/itest_part.sh 0 1 $(TEST_FLAGS) $(ITEST_FLAGS)
-	$(COLLECT_ITEST_COVERAGE)
 
 #? itest: Build and run integration tests
 itest: build-itest itest-only
@@ -216,7 +210,6 @@ itest-parallel: build-itest db-instance
 	@$(call print, "Running tests")
 	rm -rf itest/*.log itest/.logs-*; date
 	EXEC_SUFFIX=$(EXEC_SUFFIX) scripts/itest_parallel.sh $(ITEST_PARALLELISM) $(NUM_ITEST_TRANCHES) $(TEST_FLAGS) $(ITEST_FLAGS)
-	$(COLLECT_ITEST_COVERAGE)
 
 #? itest-clean: Kill all running itest processes
 itest-clean:
diff --git a/build/version.go b/build/version.go
index 9ff734a2b..62aece381 100644
--- a/build/version.go
+++ b/build/version.go
@@ -47,7 +47,7 @@ const (
 
 	// AppPreRelease MUST only contain characters from semanticAlphabet per
 	// the semantic versioning spec.
-	AppPreRelease = "beta.rc2"
+	AppPreRelease = "beta.rc1"
 )
 
 func init() {
diff --git a/chainreg/chainregistry.go b/chainreg/chainregistry.go
index 37e72fdee..8b562e87a 100644
--- a/chainreg/chainregistry.go
+++ b/chainreg/chainregistry.go
@@ -77,13 +77,9 @@ type Config struct {
 	// ActiveNetParams details the current chain we are on.
 	ActiveNetParams BitcoinNetParams
 
-	// Deprecated: Use Fee.URL. FeeURL defines the URL for fee estimation
-	// we will use. This field is optional.
-	FeeURL string
-
-	// Fee defines settings for the web fee estimator. This field is
+	// FeeURL defines the URL for fee estimation we will use. This field is
 	// optional.
-	Fee *lncfg.Fee
+	FeeURL string
 
 	// Dialer is a function closure that will be used to establish outbound
 	// TCP connections to Bitcoin peers in the event of a pruned block being
@@ -247,16 +243,6 @@ func NewPartialChainControl(cfg *Config) (*PartialChainControl, func(), error) {
 			"cache: %v", err)
 	}
 
-	// Map the deprecated feeurl flag to fee.url.
-	if cfg.FeeURL != "" {
-		if cfg.Fee.URL != "" {
-			return nil, nil, errors.New("fee.url and " +
-				"feeurl are mutually exclusive")
-		}
-
-		cfg.Fee.URL = cfg.FeeURL
-	}
-
 	// If spv mode is active, then we'll be using a distinct set of
 	// chainControl interfaces that interface directly with the p2p network
 	// of the selected chain.
@@ -275,6 +261,18 @@ func NewPartialChainControl(cfg *Config) (*PartialChainControl, func(), error) {
 			return nil, nil, err
 		}
 
+		// Map the deprecated neutrino feeurl flag to the general fee
+		// url.
+		if cfg.NeutrinoMode.FeeURL != "" {
+			if cfg.FeeURL != "" {
+				return nil, nil, errors.New("feeurl and " +
+					"neutrino.feeurl are mutually " +
+					"exclusive")
+			}
+
+			cfg.FeeURL = cfg.NeutrinoMode.FeeURL
+		}
+
 		cc.ChainSource = chain.NewNeutrinoClient(
 			cfg.ActiveNetParams.Params, cfg.NeutrinoCS,
 		)
@@ -696,34 +694,27 @@ func NewPartialChainControl(cfg *Config) (*PartialChainControl, func(), error) {
 	// If the fee URL isn't set, and the user is running mainnet, then
 	// we'll return an error to instruct them to set a proper fee
 	// estimator.
-	case cfg.Fee.URL == "" && cfg.Bitcoin.MainNet &&
+	case cfg.FeeURL == "" && cfg.Bitcoin.MainNet &&
 		cfg.Bitcoin.Node == "neutrino":
 
-		return nil, nil, fmt.Errorf("--fee.url parameter required " +
+		return nil, nil, fmt.Errorf("--feeurl parameter required " +
 			"when running neutrino on mainnet")
 
 	// Override default fee estimator if an external service is specified.
-	case cfg.Fee.URL != "":
+	case cfg.FeeURL != "":
 		// Do not cache fees on regtest to make it easier to execute
 		// manual or automated test cases.
 		cacheFees := !cfg.Bitcoin.RegTest
 
-		log.Infof("Using external fee estimator %v: cached=%v: "+
-			"min update timeout=%v, max update timeout=%v",
-			cfg.Fee.URL, cacheFees, cfg.Fee.MinUpdateTimeout,
-			cfg.Fee.MaxUpdateTimeout)
+		log.Infof("Using external fee estimator %v: cached=%v",
+			cfg.FeeURL, cacheFees)
 
-		cc.FeeEstimator, err = chainfee.NewWebAPIEstimator(
+		cc.FeeEstimator = chainfee.NewWebAPIEstimator(
 			chainfee.SparseConfFeeSource{
-				URL: cfg.Fee.URL,
+				URL: cfg.FeeURL,
 			},
 			!cacheFees,
-			cfg.Fee.MinUpdateTimeout,
-			cfg.Fee.MaxUpdateTimeout,
 		)
-		if err != nil {
-			return nil, nil, err
-		}
 	}
 
 	ccCleanup := func() {
diff --git a/cmd/lncli/cmd_payments.go b/cmd/lncli/cmd_payments.go
index a554b9dec..4288b0f01 100644
--- a/cmd/lncli/cmd_payments.go
+++ b/cmd/lncli/cmd_payments.go
@@ -886,7 +886,6 @@ func payInvoice(ctx *cli.Context) error {
 		PaymentRequest:    stripPrefix(payReq),
 		Amt:               ctx.Int64("amt"),
 		DestCustomRecords: make(map[uint64][]byte),
-		Amp:               ctx.Bool(ampFlag.Name),
 	}
 
 	return sendPaymentRequest(ctx, req)
diff --git a/config.go b/config.go
index a8b609deb..6c8df62dd 100644
--- a/config.go
+++ b/config.go
@@ -350,7 +350,7 @@ type Config struct {
 	MaxPendingChannels int    `long:"maxpendingchannels" description:"The maximum number of incoming pending channels permitted per peer."`
 	BackupFilePath     string `long:"backupfilepath" description:"The target location of the channel backup file"`
 
-	FeeURL string `long:"feeurl" description:"DEPRECATED: Use 'fee.url' option. Optional URL for external fee estimation. If no URL is specified, the method for fee estimation will depend on the chosen backend and network. Must be set for neutrino on mainnet." hidden:"true"`
+	FeeURL string `long:"feeurl" description:"Optional URL for external fee estimation. If no URL is specified, the method for fee estimation will depend on the chosen backend and network. Must be set for neutrino on mainnet."`
 
 	Bitcoin      *lncfg.Chain    `group:"Bitcoin" namespace:"bitcoin"`
 	BtcdMode     *lncfg.Btcd     `group:"btcd" namespace:"btcd"`
@@ -442,8 +442,6 @@ type Config struct {
 
 	DustThreshold uint64 `long:"dust-threshold" description:"Sets the dust sum threshold in satoshis for a channel after which dust HTLC's will be failed."`
 
-	Fee *lncfg.Fee `group:"fee" namespace:"fee"`
-
 	Invoices *lncfg.Invoices `group:"invoices" namespace:"invoices"`
 
 	Routing *lncfg.Routing `group:"routing" namespace:"routing"`
@@ -584,12 +582,6 @@ func DefaultConfig() Config {
 		MinBackoff:         defaultMinBackoff,
 		MaxBackoff:         defaultMaxBackoff,
 		ConnectionTimeout:  tor.DefaultConnTimeout,
-
-		Fee: &lncfg.Fee{
-			MinUpdateTimeout: lncfg.DefaultMinUpdateTimeout,
-			MaxUpdateTimeout: lncfg.DefaultMaxUpdateTimeout,
-		},
-
 		SubRPCServers: &subRPCServerConfigs{
 			SignRPC:   &signrpc.Config{},
 			RouterRPC: routerrpc.DefaultConfig(),
diff --git a/config_builder.go b/config_builder.go
index 49a0b6c50..895f7e4ad 100644
--- a/config_builder.go
+++ b/config_builder.go
@@ -550,11 +550,6 @@ func (d *DefaultWalletImpl) BuildWalletConfig(ctx context.Context,
 		NeutrinoCS:                  neutrinoCS,
 		ActiveNetParams:             d.cfg.ActiveNetParams,
 		FeeURL:                      d.cfg.FeeURL,
-		Fee: &lncfg.Fee{
-			URL:              d.cfg.Fee.URL,
-			MinUpdateTimeout: d.cfg.Fee.MinUpdateTimeout,
-			MaxUpdateTimeout: d.cfg.Fee.MaxUpdateTimeout,
-		},
 		Dialer: func(addr string) (net.Conn, error) {
 			return d.cfg.net.Dial(
 				"tcp", addr, d.cfg.ConnectionTimeout,
diff --git a/dev.Dockerfile b/dev.Dockerfile
index bb7c67312..d3ef269de 100644
--- a/dev.Dockerfile
+++ b/dev.Dockerfile
@@ -24,7 +24,7 @@ COPY . /go/src/github.com/lightningnetwork/lnd
 #  Install/build lnd.
 RUN cd /go/src/github.com/lightningnetwork/lnd \
 &&  make \
-&&  make install-all tags="signrpc walletrpc chainrpc invoicesrpc peersrpc"
+&&  make install tags="signrpc walletrpc chainrpc invoicesrpc peersrpc"
 
 # Start a new, final image to reduce size.
 FROM alpine as final
diff --git a/docs/release-notes/release-notes-0.18.0.md b/docs/release-notes/release-notes-0.18.0.md
index 7628726ef..7e9f1e616 100644
--- a/docs/release-notes/release-notes-0.18.0.md
+++ b/docs/release-notes/release-notes-0.18.0.md
@@ -209,17 +209,6 @@
   its bitcoin peers' `feefilter` values into
   account](https://github.com/lightningnetwork/lnd/pull/8418).
 
-* Web fee estimator settings have been moved into a new `fee` config group.
-  A new `fee.url` option has been added within this group that replaces the old
-  `feeurl` option, which is now deprecated. Additionally, [two new config values,
-  fee.min-update-timeout and fee.max-update-timeout](https://github.com/lightningnetwork/lnd/pull/8484)
-  are added to allow users to specify the minimum and maximum time between fee
-  updates from the web fee estimator. The default values are 5 minutes and 20
-  minutes respectively. These values are used to prevent the fee estimator from
-  being queried too frequently. This replaces previously hardcoded values that
-  were set to the same values as the new defaults. The previously deprecated
-  `neutrino.feeurl` option has been removed.
-
 * [Preparatory work](https://github.com/lightningnetwork/lnd/pull/8159) for 
   forwarding of blinded routes was added, along with [support](https://github.com/lightningnetwork/lnd/pull/8160)
   for forwarding blinded payments and [error handling](https://github.com/lightningnetwork/lnd/pull/8485).
@@ -284,9 +273,7 @@
 
 * [Man pages](https://github.com/lightningnetwork/lnd/pull/8525) Generate man
   pages automatically using `lncli generatemanpage` command for both `lncli`
-  and `lnd` commands when running 
-  [`make install-all`](https://github.com/lightningnetwork/lnd/pull/8739) in 
-  the Makefile.
+  and `lnd` commands when running `make install` in the Makefile.
 
 # Improvements
 ## Functional Updates
@@ -446,9 +433,6 @@
   logged](https://github.com/lightningnetwork/lnd/pull/8693) when no values are
   specified.
 
-* Removed deprecated `neutrino.feeurl` option. Please use the newer `fee.url`
-  option instead.
-
 ## Performance Improvements
 
 * Watchtower client DB migration to massively [improve the start-up 
@@ -585,7 +569,6 @@
 * testwill
 * Thabokani
 * threewebcode
-* Tom Kirkpatrick
 * Turtle
 * twofaktor
 * vuittont60
diff --git a/fn/map.go b/fn/map.go
new file mode 100644
index 000000000..071da9872
--- /dev/null
+++ b/fn/map.go
@@ -0,0 +1,44 @@
+package fn
+
+import (
+	"fmt"
+
+	"golang.org/x/exp/maps"
+)
+
+// KeySet converts a map into a Set containing the keys of the map.
+func KeySet[K comparable, V any](m map[K]V) Set[K] {
+	return NewSet(maps.Keys(m)...)
+}
+
+// NewSubMapIntersect returns a sub-map of `m` containing only the keys found in
+// both `m` and the `keys` slice.
+func NewSubMapIntersect[K comparable, V any](m map[K]V, keys []K) map[K]V {
+	result := make(map[K]V)
+	for _, k := range keys {
+		v, ok := m[k]
+		if !ok {
+			continue
+		}
+
+		result[k] = v
+	}
+
+	return result
+}
+
+// NewSubMap creates a sub-map from a given map using specified keys. It errors
+// if any of the keys is not found in the map.
+func NewSubMap[K comparable, V any](m map[K]V, keys []K) (map[K]V, error) {
+	result := make(map[K]V, len(keys))
+	for _, k := range keys {
+		v, ok := m[k]
+		if !ok {
+			return nil, fmt.Errorf("NewSubMap: missing key %v", k)
+		}
+
+		result[k] = v
+	}
+
+	return result, nil
+}
diff --git a/fn/slice.go b/fn/slice.go
index fe821bff7..2e27acc45 100644
--- a/fn/slice.go
+++ b/fn/slice.go
@@ -1,5 +1,13 @@
 package fn
 
+import "golang.org/x/exp/constraints"
+
+// Number is a type constraint for all numeric types in Go (integers,
+// float and complex numbers)
+type Number interface {
+	constraints.Integer | constraints.Float | constraints.Complex
+}
+
 // All returns true when the supplied predicate evaluates to true for all of
 // the values in the slice.
 func All[A any](pred func(A) bool, s []A) bool {
@@ -168,3 +176,25 @@ func ZipWith[A, B, C any](f func(A, B) C, a []A, b []B) []C {
 
 	return res
 }
+
+// SliceToMap converts a slice to a map using the provided key and value
+// functions.
+func SliceToMap[A any, K comparable, V any](s []A, keyFunc func(A) K,
+	valueFunc func(A) V) map[K]V {
+
+	res := make(map[K]V, len(s))
+	for _, val := range s {
+		key := keyFunc(val)
+		value := valueFunc(val)
+		res[key] = value
+	}
+
+	return res
+}
+
+// Sum calculates the sum of a slice of numbers, `items`.
+func Sum[B Number](items []B) B {
+	return Foldl(func(a, b B) B {
+		return a + b
+	}, 0, items)
+}
diff --git a/htlcswitch/link.go b/htlcswitch/link.go
index c0c828f83..ed3151728 100644
--- a/htlcswitch/link.go
+++ b/htlcswitch/link.go
@@ -202,15 +202,15 @@ type ChannelLinkConfig struct {
 	// receiving node is persistent.
 	UnsafeReplay bool
 
-	// MinUpdateTimeout represents the minimum interval in which a link
+	// MinFeeUpdateTimeout represents the minimum interval in which a link
 	// will propose to update its commitment fee rate. A random timeout will
-	// be selected between this and MaxUpdateTimeout.
-	MinUpdateTimeout time.Duration
+	// be selected between this and MaxFeeUpdateTimeout.
+	MinFeeUpdateTimeout time.Duration
 
-	// MaxUpdateTimeout represents the maximum interval in which a link
+	// MaxFeeUpdateTimeout represents the maximum interval in which a link
 	// will propose to update its commitment fee rate. A random timeout will
-	// be selected between this and MinUpdateTimeout.
-	MaxUpdateTimeout time.Duration
+	// be selected between this and MinFeeUpdateTimeout.
+	MaxFeeUpdateTimeout time.Duration
 
 	// OutgoingCltvRejectDelta defines the number of blocks before expiry of
 	// an htlc where we don't offer an htlc anymore. This should be at least
@@ -1558,8 +1558,8 @@ func getResolutionFailure(resolution *invoices.HtlcFailResolution,
 // within the link's configuration that will be used to determine when the link
 // should propose an update to its commitment fee rate.
 func (l *channelLink) randomFeeUpdateTimeout() time.Duration {
-	lower := int64(l.cfg.MinUpdateTimeout)
-	upper := int64(l.cfg.MaxUpdateTimeout)
+	lower := int64(l.cfg.MinFeeUpdateTimeout)
+	upper := int64(l.cfg.MaxFeeUpdateTimeout)
 	return time.Duration(prand.Int63n(upper-lower) + lower)
 }
 
diff --git a/lncfg/fee.go b/lncfg/fee.go
deleted file mode 100644
index 200ae9e81..000000000
--- a/lncfg/fee.go
+++ /dev/null
@@ -1,20 +0,0 @@
-package lncfg
-
-import "time"
-
-// DefaultMinUpdateTimeout represents the minimum interval in which a
-// WebAPIEstimator will request fresh fees from its API.
-const DefaultMinUpdateTimeout = 5 * time.Minute
-
-// DefaultMaxUpdateTimeout represents the maximum interval in which a
-// WebAPIEstimator will request fresh fees from its API.
-const DefaultMaxUpdateTimeout = 20 * time.Minute
-
-// Fee holds the configuration options for fee estimation.
-//
-//nolint:lll
-type Fee struct {
-	URL              string        `long:"url" description:"Optional URL for external fee estimation. If no URL is specified, the method for fee estimation will depend on the chosen backend and network. Must be set for neutrino on mainnet."`
-	MinUpdateTimeout time.Duration `long:"min-update-timeout" description:"The minimum interval in which fees will be updated from the specified fee URL."`
-	MaxUpdateTimeout time.Duration `long:"max-update-timeout" description:"The maximum interval in which fees will be updated from the specified fee URL."`
-}
diff --git a/lncfg/neutrino.go b/lncfg/neutrino.go
index e46c292dc..09a66312a 100644
--- a/lncfg/neutrino.go
+++ b/lncfg/neutrino.go
@@ -12,6 +12,7 @@ type Neutrino struct {
 	MaxPeers           int           `long:"maxpeers" description:"Max number of inbound and outbound peers"`
 	BanDuration        time.Duration `long:"banduration" description:"How long to ban misbehaving peers.  Valid time units are {s, m, h}.  Minimum 1 second"`
 	BanThreshold       uint32        `long:"banthreshold" description:"Maximum allowed ban score before disconnecting and banning misbehaving peers."`
+	FeeURL             string        `long:"feeurl" description:"DEPRECATED: Use top level 'feeurl' option. Optional URL for fee estimation. If a URL is not specified, static fees will be used for estimation." hidden:"true"`
 	AssertFilterHeader string        `long:"assertfilterheader" description:"Optional filter header in height:hash format to assert the state of neutrino's filter header chain on startup. If the assertion does not hold, then the filter header chain will be re-synced from the genesis block."`
 	UserAgentName      string        `long:"useragentname" description:"Used to help identify ourselves to other bitcoin peers"`
 	UserAgentVersion   string        `long:"useragentversion" description:"Used to help identify ourselves to other bitcoin peers"`
diff --git a/lnwallet/chainfee/estimator.go b/lnwallet/chainfee/estimator.go
index 0ce9ae9b8..76c235d1b 100644
--- a/lnwallet/chainfee/estimator.go
+++ b/lnwallet/chainfee/estimator.go
@@ -28,6 +28,14 @@ const (
 	// less than this will result in an error.
 	minBlockTarget uint32 = 1
 
+	// minFeeUpdateTimeout represents the minimum interval in which a
+	// WebAPIEstimator will request fresh fees from its API.
+	minFeeUpdateTimeout = 5 * time.Minute
+
+	// maxFeeUpdateTimeout represents the maximum interval in which a
+	// WebAPIEstimator will request fresh fees from its API.
+	maxFeeUpdateTimeout = 20 * time.Minute
+
 	// WebAPIConnectionTimeout specifies the timeout value for connecting
 	// to the api source.
 	WebAPIConnectionTimeout = 5 * time.Second
@@ -731,43 +739,19 @@ type WebAPIEstimator struct {
 	// estimates.
 	noCache bool
 
-	// minFeeUpdateTimeout represents the minimum interval in which the
-	// web estimator will request fresh fees from its API.
-	minFeeUpdateTimeout time.Duration
-
-	// minFeeUpdateTimeout represents the maximum interval in which the
-	// web estimator will request fresh fees from its API.
-	maxFeeUpdateTimeout time.Duration
-
 	quit chan struct{}
 	wg   sync.WaitGroup
 }
 
 // NewWebAPIEstimator creates a new WebAPIEstimator from a given URL and a
 // fallback default fee. The fees are updated whenever a new block is mined.
-func NewWebAPIEstimator(api WebAPIFeeSource, noCache bool,
-	minFeeUpdateTimeout time.Duration,
-	maxFeeUpdateTimeout time.Duration) (*WebAPIEstimator, error) {
-
-	if minFeeUpdateTimeout == 0 || maxFeeUpdateTimeout == 0 {
-		return nil, fmt.Errorf("minFeeUpdateTimeout and " +
-			"maxFeeUpdateTimeout must be greater than 0")
-	}
-
-	if minFeeUpdateTimeout >= maxFeeUpdateTimeout {
-		return nil, fmt.Errorf("minFeeUpdateTimeout target of %v "+
-			"cannot be greater than maxFeeUpdateTimeout of %v",
-			minFeeUpdateTimeout, maxFeeUpdateTimeout)
-	}
-
+func NewWebAPIEstimator(api WebAPIFeeSource, noCache bool) *WebAPIEstimator {
 	return &WebAPIEstimator{
-		apiSource:           api,
-		feeByBlockTarget:    make(map[uint32]uint32),
-		noCache:             noCache,
-		quit:                make(chan struct{}),
-		minFeeUpdateTimeout: minFeeUpdateTimeout,
-		maxFeeUpdateTimeout: maxFeeUpdateTimeout,
-	}, nil
+		apiSource:        api,
+		feeByBlockTarget: make(map[uint32]uint32),
+		noCache:          noCache,
+		quit:             make(chan struct{}),
+	}
 }
 
 // EstimateFeePerKW takes in a target for the number of blocks until an initial
@@ -825,12 +809,7 @@ func (w *WebAPIEstimator) Start() error {
 	w.started.Do(func() {
 		log.Infof("Starting web API fee estimator")
 
-		feeUpdateTimeout := w.randomFeeUpdateTimeout()
-
-		log.Infof("Web API fee estimator using update timeout of %v",
-			feeUpdateTimeout)
-
-		w.updateFeeTicker = time.NewTicker(feeUpdateTimeout)
+		w.updateFeeTicker = time.NewTicker(w.randomFeeUpdateTimeout())
 		w.updateFeeEstimates()
 
 		w.wg.Add(1)
@@ -873,11 +852,9 @@ func (w *WebAPIEstimator) RelayFeePerKW() SatPerKWeight {
 // and maxFeeUpdateTimeout that will be used to determine how often the Estimator
 // should retrieve fresh fees from its API.
 func (w *WebAPIEstimator) randomFeeUpdateTimeout() time.Duration {
-	lower := int64(w.minFeeUpdateTimeout)
-	upper := int64(w.maxFeeUpdateTimeout)
-	return time.Duration(
-		prand.Int63n(upper-lower) + lower, //nolint:gosec
-	).Round(time.Second)
+	lower := int64(minFeeUpdateTimeout)
+	upper := int64(maxFeeUpdateTimeout)
+	return time.Duration(prand.Int63n(upper-lower) + lower)
 }
 
 // getCachedFee takes a conf target and returns the cached fee rate. When the
diff --git a/peer/brontide.go b/peer/brontide.go
index 1fa6c1311..984a52809 100644
--- a/peer/brontide.go
+++ b/peer/brontide.go
@@ -1146,8 +1146,8 @@ func (p *Brontide) addLink(chanPoint *wire.OutPoint,
 		),
 		BatchSize:               p.cfg.ChannelCommitBatchSize,
 		UnsafeReplay:            p.cfg.UnsafeReplay,
-		MinUpdateTimeout:        htlcswitch.DefaultMinLinkFeeUpdateTimeout,
-		MaxUpdateTimeout:        htlcswitch.DefaultMaxLinkFeeUpdateTimeout,
+		MinFeeUpdateTimeout:     htlcswitch.DefaultMinLinkFeeUpdateTimeout,
+		MaxFeeUpdateTimeout:     htlcswitch.DefaultMaxLinkFeeUpdateTimeout,
 		OutgoingCltvRejectDelta: p.cfg.OutgoingCltvRejectDelta,
 		TowerClient:             p.cfg.TowerClient,
 		MaxOutgoingCltvExpiry:   p.cfg.MaxOutgoingCltvExpiry,
diff --git a/sample-lnd.conf b/sample-lnd.conf
index 2783c58fd..d6bc83d4b 100644
--- a/sample-lnd.conf
+++ b/sample-lnd.conf
@@ -305,9 +305,9 @@
 ; The default value below is 20 MB (1024 * 1024 * 20)
 ; blockcachesize=20971520
 
-; DEPRECATED: Use 'fee.url' option. Optional URL for external fee estimation.
-; If no URL is specified, the method for fee estimation will depend on the
-; chosen backend and network. Must be set for neutrino on mainnet.
+; Optional URL for external fee estimation. If no URL is specified, the method
+; for fee estimation will depend on the chosen backend and network. Must be set
+; for neutrino on mainnet.
 ; Default:
 ;   feeurl=
 ; Example:
@@ -530,24 +530,6 @@
 ; the headers of an HTTP request.
 ; http-header-timeout=5s
 
-
-[fee]
-
-; Optional URL for external fee estimation. If no URL is specified, the method
-; for fee estimation will depend on the chosen backend and network. Must be set
-; for neutrino on mainnet.
-; Default:
-;   fee.url=
-; Example:
-;   fee.url=https://nodes.lightning.computer/fees/v1/btc-fee-estimates.json
-
-; The minimum interval in which fees will be updated from the specified fee URL.
-; fee.min-update-timeout=5m
-
-; The maximum interval in which fees will be updated from the specified fee URL.
-; fee.max-update-timeout=20m
-
-
 [prometheus]
 
 ; If true, lnd will start the Prometheus exporter. Prometheus flags are
@@ -820,6 +802,10 @@
 ; NOTE: This value is currently unused.
 ; neutrino.banthreshold=
 
+; DEPRECATED: Use top level 'feeurl' option. Optional URL for fee estimation. If
+; a URL is not specified, static fees will be used for estimation.
+; neutrino.feeurl=
+
 ; Optional filter header in height:hash format to assert the state of neutrino's
 ; filter header chain on startup. If the assertion does not hold, then the
 ; filter header chain will be re-synced from the genesis block.


Test patch:
diff --git a/fn/map_test.go b/fn/map_test.go
new file mode 100644
index 000000000..b0694bde6
--- /dev/null
+++ b/fn/map_test.go
@@ -0,0 +1,135 @@
+package fn
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/require"
+)
+
+func TestKeySet(t *testing.T) {
+	testMap := map[string]int{"a": 1, "b": 2, "c": 3}
+	expected := NewSet([]string{"a", "b", "c"}...)
+
+	require.Equal(t, expected, KeySet(testMap))
+}
+
+// TestNewSubMap tests the NewSubMap function with various input cases.
+func TestNewSubMap(t *testing.T) {
+	tests := []struct {
+		name     string
+		original map[int]string
+		keys     []int
+		expected map[int]string
+		wantErr  bool
+	}{
+		{
+			name: "Successful submap creation",
+			original: map[int]string{
+				1: "apple",
+				2: "banana",
+				3: "cherry",
+			},
+			keys: []int{1, 3},
+			expected: map[int]string{
+				1: "apple",
+				3: "cherry",
+			},
+			wantErr: false,
+		},
+		{
+			name: "Key not found",
+			original: map[int]string{
+				1: "apple",
+				2: "banana",
+			},
+			keys:     []int{1, 4},
+			expected: nil,
+			wantErr:  true,
+		},
+		{
+			name: "Empty keys list",
+			original: map[int]string{
+				1: "apple",
+				2: "banana",
+			},
+			keys:     []int{},
+			expected: map[int]string{},
+			wantErr:  false,
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			result, err := NewSubMap(tt.original, tt.keys)
+			if tt.wantErr {
+				require.ErrorContains(
+					t, err, "NewSubMap: missing key",
+				)
+
+				require.Nil(t, result)
+
+				return
+			}
+
+			require.NoError(t, err)
+			require.Equal(t, tt.expected, result)
+		})
+	}
+}
+
+// TestNewSubMapIntersect tests the NewSubMapIntersect function for correctness.
+func TestNewSubMapIntersect(t *testing.T) {
+	tests := []struct {
+		name     string
+		original map[int]string
+		keys     []int
+		expected map[int]string
+	}{
+		{
+			name: "Successful intersection",
+			original: map[int]string{
+				1: "apple",
+				2: "banana",
+				3: "cherry",
+				4: "date",
+			},
+			keys: []int{2, 3, 5},
+			expected: map[int]string{
+				2: "banana",
+				3: "cherry",
+			},
+		},
+		{
+			name: "No intersection",
+			original: map[int]string{
+				1: "apple",
+				2: "banana",
+			},
+			keys:     []int{3, 4},
+			expected: map[int]string{},
+		},
+		{
+			name:     "Empty original map",
+			original: map[int]string{},
+			keys:     []int{1, 2},
+			expected: map[int]string{},
+		},
+		{
+			name: "Empty keys list",
+			original: map[int]string{
+				1: "apple",
+				2: "banana",
+			},
+			keys:     []int{},
+			expected: map[int]string{},
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			require.Equal(
+				t, tt.expected,
+				NewSubMapIntersect(tt.original, tt.keys))
+		})
+	}
+}
diff --git a/fn/slice_test.go b/fn/slice_test.go
index 0178cc946..de02be836 100644
--- a/fn/slice_test.go
+++ b/fn/slice_test.go
@@ -1,6 +1,7 @@
 package fn
 
 import (
+	"fmt"
 	"slices"
 	"testing"
 
@@ -136,3 +137,107 @@ func TestZipWith(t *testing.T) {
 		z, []bool{false, true, false, false, false},
 	))
 }
+
+// TestSum checks if the Sum function correctly calculates the sum of the
+// numbers in the slice.
+func TestSum(t *testing.T) {
+	tests := []struct {
+		name   string
+		items  interface{}
+		result interface{}
+	}{
+		{
+			name:   "Sum of positive integers",
+			items:  []int{1, 2, 3},
+			result: 6,
+		},
+		{
+			name:   "Sum of negative integers",
+			items:  []int{-1, -2, -3},
+			result: -6,
+		},
+		{
+			name:   "Sum of float numbers",
+			items:  []float64{1.1, 2.2, 3.3},
+			result: 6.6,
+		},
+		{
+			name: "Sum of complex numbers",
+			items: []complex128{
+				complex(1, 1),
+				complex(2, 2),
+				complex(3, 3),
+			},
+			result: complex(6, 6),
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			switch v := tt.items.(type) {
+			case []int:
+				require.Equal(t, tt.result, Sum(v))
+			case []float64:
+				require.Equal(t, tt.result, Sum(v))
+			case []complex128:
+				require.Equal(t, tt.result, Sum(v))
+			}
+		})
+	}
+}
+
+// TestSliceToMap tests the SliceToMap function.
+func TestSliceToMap(t *testing.T) {
+	tests := []struct {
+		name      string
+		slice     []int
+		keyFunc   func(int) int
+		valueFunc func(int) string
+		expected  map[int]string
+	}{
+		{
+			name:    "Integers to string map",
+			slice:   []int{1, 2, 3},
+			keyFunc: func(a int) int { return a },
+			valueFunc: func(a int) string {
+				return fmt.Sprintf("Value%d", a)
+			},
+			expected: map[int]string{
+				1: "Value1",
+				2: "Value2",
+				3: "Value3",
+			},
+		},
+		{
+			name:    "Duplicates in slice",
+			slice:   []int{1, 2, 2, 3},
+			keyFunc: func(a int) int { return a },
+			valueFunc: func(a int) string {
+				return fmt.Sprintf("Value%d", a)
+			},
+			expected: map[int]string{
+				1: "Value1",
+				2: "Value2",
+				3: "Value3",
+			},
+		},
+		{
+			name:    "Empty slice",
+			slice:   []int{},
+			keyFunc: func(a int) int { return a },
+			valueFunc: func(a int) string {
+				return fmt.Sprintf("Value%d", a)
+			},
+			expected: map[int]string{},
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			require.Equal(
+				t, tt.expected,
+				SliceToMap(tt.slice, tt.keyFunc, tt.valueFunc),
+			)
+		})
+	}
+}
diff --git a/htlcswitch/link_test.go b/htlcswitch/link_test.go
index 6963bf708..4db22d173 100644
--- a/htlcswitch/link_test.go
+++ b/htlcswitch/link_test.go
@@ -2220,11 +2220,11 @@ func newSingleLinkTestHarness(t *testing.T, chanAmt,
 		BatchTicker:          bticker,
 		FwdPkgGCTicker:       ticker.NewForce(15 * time.Second),
 		PendingCommitTicker:  ticker.New(time.Minute),
-		// Make the BatchSize and Min/MaxUpdateTimeout large enough
+		// Make the BatchSize and Min/MaxFeeUpdateTimeout large enough
 		// to not trigger commit updates automatically during tests.
 		BatchSize:               10000,
-		MinUpdateTimeout:        30 * time.Minute,
-		MaxUpdateTimeout:        40 * time.Minute,
+		MinFeeUpdateTimeout:     30 * time.Minute,
+		MaxFeeUpdateTimeout:     40 * time.Minute,
 		MaxOutgoingCltvExpiry:   DefaultMaxOutgoingCltvExpiry,
 		MaxFeeAllocation:        DefaultMaxLinkFeeAllocation,
 		NotifyActiveLink:        func(wire.OutPoint) {},
@@ -4881,11 +4881,11 @@ func (h *persistentLinkHarness) restartLink(
 		BatchTicker:          bticker,
 		FwdPkgGCTicker:       ticker.New(5 * time.Second),
 		PendingCommitTicker:  ticker.New(time.Minute),
-		// Make the BatchSize and Min/MaxUpdateTimeout large enough
+		// Make the BatchSize and Min/MaxFeeUpdateTimeout large enough
 		// to not trigger commit updates automatically during tests.
-		BatchSize:        10000,
-		MinUpdateTimeout: 30 * time.Minute,
-		MaxUpdateTimeout: 40 * time.Minute,
+		BatchSize:           10000,
+		MinFeeUpdateTimeout: 30 * time.Minute,
+		MaxFeeUpdateTimeout: 40 * time.Minute,
 		// Set any hodl flags requested for the new link.
 		HodlMask:                hodl.MaskFromFlags(hodlFlags...),
 		MaxOutgoingCltvExpiry:   DefaultMaxOutgoingCltvExpiry,
diff --git a/htlcswitch/test_utils.go b/htlcswitch/test_utils.go
index 9a72197ec..0c98fa4fe 100644
--- a/htlcswitch/test_utils.go
+++ b/htlcswitch/test_utils.go
@@ -1155,8 +1155,8 @@ func (h *hopNetwork) createChannelLink(server, peer *mockServer,
 			BatchTicker:             ticker.NewForce(testBatchTimeout),
 			FwdPkgGCTicker:          ticker.NewForce(fwdPkgTimeout),
 			PendingCommitTicker:     ticker.New(2 * time.Minute),
-			MinUpdateTimeout:        minFeeUpdateTimeout,
-			MaxUpdateTimeout:        maxFeeUpdateTimeout,
+			MinFeeUpdateTimeout:     minFeeUpdateTimeout,
+			MaxFeeUpdateTimeout:     maxFeeUpdateTimeout,
 			OnChannelFailure:        func(lnwire.ChannelID, lnwire.ShortChannelID, LinkFailureError) {},
 			OutgoingCltvRejectDelta: 3,
 			MaxOutgoingCltvExpiry:   DefaultMaxOutgoingCltvExpiry,
diff --git a/invoices/invoiceregistry_test.go b/invoices/invoiceregistry_test.go
index 4a76d58aa..b0c019522 100644
--- a/invoices/invoiceregistry_test.go
+++ b/invoices/invoiceregistry_test.go
@@ -6,7 +6,6 @@ import (
 	"database/sql"
 	"fmt"
 	"math"
-	"sync"
 	"testing"
 	"testing/quick"
 	"time"
@@ -24,12 +23,6 @@ import (
 	"github.com/stretchr/testify/require"
 )
 
-// sqliteConstructorMu is used to ensure that only one thread can call the
-// sqldb.NewTestSqliteDB constructor at a time. This is a temporary workaround
-// that can be removed once this race condition in the sqlite repo is resolved:
-// https://gitlab.com/cznic/sqlite/-/issues/180
-var sqliteConstructorMu sync.Mutex
-
 // TestInvoiceRegistry is a master test which encompasses all tests using an
 // InvoiceDB instance. The purpose of this test is to be able to run all tests
 // with a custom DB instance, so that we can test the same logic with different
@@ -137,9 +130,7 @@ func TestInvoiceRegistry(t *testing.T) {
 
 		var db *sqldb.BaseDB
 		if sqlite {
-			sqliteConstructorMu.Lock()
 			db = sqldb.NewTestSqliteDB(t).BaseDB
-			sqliteConstructorMu.Unlock()
 		} else {
 			db = sqldb.NewTestPostgresDB(t, pgFixture).BaseDB
 		}
diff --git a/invoices/invoices_test.go b/invoices/invoices_test.go
index 71da38571..c9e204571 100644
--- a/invoices/invoices_test.go
+++ b/invoices/invoices_test.go
@@ -234,9 +234,7 @@ func TestInvoices(t *testing.T) {
 	makeSQLDB := func(t *testing.T, sqlite bool) invpkg.InvoiceDB {
 		var db *sqldb.BaseDB
 		if sqlite {
-			sqliteConstructorMu.Lock()
 			db = sqldb.NewTestSqliteDB(t).BaseDB
-			sqliteConstructorMu.Unlock()
 		} else {
 			db = sqldb.NewTestPostgresDB(t, pgFixture).BaseDB
 		}
diff --git a/lntest/fee_service.go b/lntest/fee_service.go
index cee9ae0ab..d96bd7588 100644
--- a/lntest/fee_service.go
+++ b/lntest/fee_service.go
@@ -17,7 +17,7 @@ import (
 
 // WebFeeService defines an interface that's used to provide fee estimation
 // service used in the integration tests. It must provide an URL so that a lnd
-// node can be started with the flag `--fee.url` and uses the customized fee
+// node can be started with the flag `--feeurl` and uses the customized fee
 // estimator.
 type WebFeeService interface {
 	// Start starts the service.
diff --git a/lntest/node/config.go b/lntest/node/config.go
index de1ea92ec..d0de2fdd4 100644
--- a/lntest/node/config.go
+++ b/lntest/node/config.go
@@ -279,7 +279,7 @@ func (cfg *BaseNodeConfig) GenArgs() []string {
 	}
 
 	if cfg.FeeURL != "" {
-		args = append(args, "--fee.url="+cfg.FeeURL)
+		args = append(args, "--feeurl="+cfg.FeeURL)
 	}
 
 	// Put extra args in the end so the args can be overwritten.
diff --git a/lnwallet/chainfee/estimator_test.go b/lnwallet/chainfee/estimator_test.go
index 51ab5bf29..fc16c9b12 100644
--- a/lnwallet/chainfee/estimator_test.go
+++ b/lnwallet/chainfee/estimator_test.go
@@ -4,7 +4,6 @@ import (
 	"bytes"
 	"encoding/json"
 	"testing"
-	"time"
 
 	"github.com/btcsuite/btcd/btcutil"
 	"github.com/stretchr/testify/require"
@@ -143,9 +142,6 @@ func TestWebAPIFeeEstimator(t *testing.T) {
 		// Fee rates are in sat/kb.
 		minFeeRate uint32 = 2000 // 500 sat/kw
 		maxFeeRate uint32 = 4000 // 1000 sat/kw
-
-		minFeeUpdateTimeout = 5 * time.Minute
-		maxFeeUpdateTimeout = 20 * time.Minute
 	)
 
 	testCases := []struct {
@@ -203,9 +199,7 @@ func TestWebAPIFeeEstimator(t *testing.T) {
 	feeSource := &mockFeeSource{}
 	feeSource.On("GetFeeMap").Return(feeRateResp, nil)
 
-	estimator, _ := NewWebAPIEstimator(
-		feeSource, false, minFeeUpdateTimeout, maxFeeUpdateTimeout,
-	)
+	estimator := NewWebAPIEstimator(feeSource, false)
 
 	// Test that requesting a fee when no fees have been cached won't fail.
 	feeRate, err := estimator.EstimateFeePerKW(5)
@@ -253,15 +247,10 @@ func TestGetCachedFee(t *testing.T) {
 
 		minFeeRate uint32 = 100
 		maxFeeRate uint32 = 1000
-
-		minFeeUpdateTimeout = 5 * time.Minute
-		maxFeeUpdateTimeout = 20 * time.Minute
 	)
 
 	// Create a dummy estimator without WebAPIFeeSource.
-	estimator, _ := NewWebAPIEstimator(
-		nil, false, minFeeUpdateTimeout, maxFeeUpdateTimeout,
-	)
+	estimator := NewWebAPIEstimator(nil, false)
 
 	// When the cache is empty, an error should be returned.
 	cachedFee, err := estimator.getCachedFee(minTarget)
@@ -326,38 +315,3 @@ func TestGetCachedFee(t *testing.T) {
 		})
 	}
 }
-
-func TestRandomFeeUpdateTimeout(t *testing.T) {
-	t.Parallel()
-
-	var (
-		minFeeUpdateTimeout = 1 * time.Minute
-		maxFeeUpdateTimeout = 2 * time.Minute
-	)
-
-	estimator, _ := NewWebAPIEstimator(
-		nil, false, minFeeUpdateTimeout, maxFeeUpdateTimeout,
-	)
-
-	for i := 0; i < 1000; i++ {
-		timeout := estimator.randomFeeUpdateTimeout()
-
-		require.GreaterOrEqual(t, timeout, minFeeUpdateTimeout)
-		require.LessOrEqual(t, timeout, maxFeeUpdateTimeout)
-	}
-}
-
-func TestInvalidFeeUpdateTimeout(t *testing.T) {
-	t.Parallel()
-
-	var (
-		minFeeUpdateTimeout = 2 * time.Minute
-		maxFeeUpdateTimeout = 1 * time.Minute
-	)
-
-	_, err := NewWebAPIEstimator(
-		nil, false, minFeeUpdateTimeout, maxFeeUpdateTimeout,
-	)
-	require.Error(t, err, "NewWebAPIEstimator should return an error "+
-		"when minFeeUpdateTimeout > maxFeeUpdateTimeout")
-}
diff --git a/make/testing_flags.mk b/make/testing_flags.mk
index b2db6861c..3fecb073a 100644
--- a/make/testing_flags.mk
+++ b/make/testing_flags.mk
@@ -2,9 +2,7 @@ DEV_TAGS = dev
 RPC_TAGS = autopilotrpc chainrpc invoicesrpc neutrinorpc peersrpc routerrpc signrpc verrpc walletrpc watchtowerrpc wtclientrpc
 LOG_TAGS =
 TEST_FLAGS =
-ITEST_FLAGS =
-ITEST_COVERAGE =
-COLLECT_ITEST_COVERAGE =
+ITEST_FLAGS = 
 EXEC_SUFFIX =
 COVER_PKG = $$(go list -deps -tags="$(DEV_TAGS)" ./... | grep '$(PKG)' | grep -v lnrpc)
 NUM_ITEST_TRANCHES = 4
@@ -79,12 +77,6 @@ ifneq ($(tags),)
 DEV_TAGS += ${tags}
 endif
 
-# Enable integration test coverage (requires Go >= 1.20.0).
-ifneq ($(cover),)
-ITEST_COVERAGE = -cover
-COLLECT_ITEST_COVERAGE = go tool covdata textfmt -i=itest/cover -o coverage.txt
-endif
-
 # Define the log tags that will be applied only when running unit tests. If none
 # are provided, we default to "nolog" which will be silent.
 ifneq ($(log),)
diff --git a/scripts/itest_part.sh b/scripts/itest_part.sh
index bdf4ecdf5..312e13a01 100755
--- a/scripts/itest_part.sh
+++ b/scripts/itest_part.sh
@@ -16,8 +16,6 @@ shift
 EXEC="$WORKDIR"/itest.test"$EXEC_SUFFIX"
 LND_EXEC="$WORKDIR"/lnd-itest"$EXEC_SUFFIX"
 BTCD_EXEC="$WORKDIR"/btcd-itest"$EXEC_SUFFIX"
-export GOCOVERDIR="$WORKDIR/cover"
-mkdir -p "$GOCOVERDIR"
 echo $EXEC -test.v "$@" -logoutput -logdir=.logs-tranche$TRANCHE -lndexec=$LND_EXEC -btcdexec=$BTCD_EXEC -splittranches=$NUM_TRANCHES -runtranche=$TRANCHE
 
 # Exit code 255 causes the parallel jobs to abort, so if one part fails the