Repository: hyrodium/BasicBSpline.jl
Pull request #243 (2022-08-08 09:16:21)

Add Aqua.jl in runtests.jl

codecov[bot]: # [Codecov](https://codecov.io/gh/hyrodium/BasicBSpline.jl/pull/243?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yuto+Horikawa) Report
> Merging [#243](https://codecov.io/gh/hyrodium/BasicBSpline.jl/pull/243?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yuto+Horikawa) (60932ca) into [master](https://codecov.io/gh/hyrodium/BasicBSpline.jl/commit/fae9396eeebc13cba5cf8f5428917db5a915e3fd?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yuto+Horikawa) (fae9396) will **increase** coverage by `0.14%`.
> The diff coverage is `n/a`.

```diff
@@            Coverage Diff             @@
##           master     #243      +/-   ##
==========================================
+ Coverage   98.68%   98.83%   +0.14%     
==========================================
  Files          15       15              
  Lines        1372     1370       -2     
==========================================
  Hits         1354     1354              
+ Misses         18       16       -2     
```


| [Impacted Files](https://codecov.io/gh/hyrodium/BasicBSpline.jl/pull/243?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yuto+Horikawa) | Coverage Δ | |
|---|---|---|
| [src/\_DerivativeSpace.jl](https://codecov.io/gh/hyrodium/BasicBSpline.jl/pull/243/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yuto+Horikawa#diff-c3JjL19EZXJpdmF0aXZlU3BhY2Uuamw=) | `100.00% <ø> (+4.34%)` | :arrow_up: |

Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yuto+Horikawa). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yuto+Horikawa)


Patch:
diff --git a/Project.toml b/Project.toml
index 543ade1d..addfccb6 100644
--- a/Project.toml
+++ b/Project.toml
@@ -18,10 +18,11 @@ StaticArrays = "1"
 julia = "^1.6"
 
 [extras]
+Aqua = "4c88cf16-eb10-579e-8560-4a9242c79595"
 GeometryBasics = "5c1252a2-5f33-56bf-86c9-59e7332b4326"
 Plots = "91a5bcdd-55d7-5caf-9e0b-520d859cae80"
 Random = "9a3f8284-a2c9-5f02-9a11-845980a1fd5c"
 Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
 
 [targets]
-test = ["Test", "Random", "GeometryBasics", "Plots"]
+test = ["Test", "Random", "GeometryBasics", "Plots", "Aqua"]
diff --git a/src/_DerivativeSpace.jl b/src/_DerivativeSpace.jl
index 85b39036..bcdd1c01 100644
--- a/src/_DerivativeSpace.jl
+++ b/src/_DerivativeSpace.jl
@@ -24,9 +24,6 @@ end
 function BSplineDerivativeSpace{r,S}(dP::BSplineDerivativeSpace{r}) where {r,S}
     BSplineDerivativeSpace{r,S}(S(bsplinespace(dP)))
 end
-function Base.convert(::Type{BSplineDerivativeSpace{r,S}}, dP) where {r,S}
-    BSplineDerivativeSpace{r,S}(dP)
-end
 
 # Broadcast like a scalar
 Base.Broadcast.broadcastable(dP::BSplineDerivativeSpace) = Ref(dP)


Test patch:
diff --git a/test/runtests.jl b/test/runtests.jl
index 2a53f900..65ba3f60 100644
--- a/test/runtests.jl
+++ b/test/runtests.jl
@@ -6,20 +6,21 @@ using Random
 using StaticArrays
 using GeometryBasics
 using Plots
+using Aqua
 
-@testset "BasicBSpline.jl" begin
-    include("test_util.jl")
-    include("test_KnotVector.jl")
-    include("test_BSplineSpace.jl")
-    include("test_BSplineBasis.jl")
-    include("test_UniformKnotVector.jl")
-    include("test_UniformBSplineSpace.jl")
-    include("test_UniformBSplineBasis.jl")
-    include("test_Derivative.jl")
-    include("test_ChangeBasis.jl")
-    include("test_BSplineManifold.jl")
-    include("test_RationalBSplineManifold.jl")
-    include("test_Refinement.jl")
-    include("test_Fitting.jl")
-    include("test_Plots.jl")
-end
+Aqua.test_all(BasicBSpline)
+
+include("test_util.jl")
+include("test_KnotVector.jl")
+include("test_BSplineSpace.jl")
+include("test_BSplineBasis.jl")
+include("test_UniformKnotVector.jl")
+include("test_UniformBSplineSpace.jl")
+include("test_UniformBSplineBasis.jl")
+include("test_Derivative.jl")
+include("test_ChangeBasis.jl")
+include("test_BSplineManifold.jl")
+include("test_RationalBSplineManifold.jl")
+include("test_Refinement.jl")
+include("test_Fitting.jl")
+include("test_Plots.jl")