Repository: fluid-cloudnative/fluid
Pull request #3826 (2024-04-09 02:25:06)

Fix `fluid.io/node-publish-method` typo
<!-- 
Please make sure you have read and understood the contributing guidelines;
https://github.com/fluid-cloudnative/fluid/blob/master/CONTRIBUTING.md-->

### Ⅰ. Describe what this PR does
Change `fluid.io/node-puhlish-method` typo to `fluid.io/node-publish-method`, as it is a typo.

### Ⅱ. Does this pull request fix one issue?
<!--If so, add "fixes #xxxx" so that the issue will be closed when this PR is merged (for example, "fixes #15" to close Issue #15). Otherwise, add "NONE" -->
NONE

### Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.


### Ⅳ. Describe how to verify it


### Ⅴ. Special notes for reviews

fluid-e2e-bot[bot]: [APPROVALNOTIFIER] This PR is **NOT APPROVED**

This pull-request has been approved by:
**Once this PR has been reviewed and has the lgtm label**, please ask for approval from trafalgarzzz by writing `/assign @trafalgarzzz` in a comment. For more information see:[The Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).

The full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=fluid-cloudnative%2Ffluid).

<details open>
Needs approval from an approver in each of these files:

- **[OWNERS](https://github.com/fluid-cloudnative/fluid/blob/master/OWNERS)**

Approvers can indicate their approval by writing `/approve` in a comment
Approvers can cancel approval by writing `/approve cancel` in a comment
</details>
<!-- META={"approvers":["trafalgarzzz"]} -->
sonarcloud[bot]: ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.io/dashboard?id=fluid-cloudnative_fluid&pullRequest=3826) **Quality Gate passed**  
Issues  
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0 New issues](https://sonarcloud.io/project/issues?id=fluid-cloudnative_fluid&pullRequest=3826&resolved=false&inNewCodePeriod=true)  
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png '') [0 Accepted issues](https://sonarcloud.io/component_measures?id=fluid-cloudnative_fluid&pullRequest=3826&metric=new_accepted_issues&view=list)

Measures  
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=fluid-cloudnative_fluid&pullRequest=3826&resolved=false&inNewCodePeriod=true)  
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/no-data-16px.png '') No data about Coverage  
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=fluid-cloudnative_fluid&pullRequest=3826&metric=new_duplicated_lines_density&view=list)  
  
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=fluid-cloudnative_fluid&pullRequest=3826)


TrafalgarZZZ: /test fluid-e2e
fluid-e2e-bot[bot]: [APPROVALNOTIFIER] This PR is **APPROVED**

This pull-request has been approved by: *<a href="https://github.com/fluid-cloudnative/fluid/pull/3826#pullrequestreview-1988012284" title="Approved">cheyang</a>*

The full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=fluid-cloudnative%2Ffluid).

The pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)

<details >
Needs approval from an approver in each of these files:

- ~~[OWNERS](https://github.com/fluid-cloudnative/fluid/blob/master/OWNERS)~~ [cheyang]

Approvers can indicate their approval by writing `/approve` in a comment
Approvers can cancel approval by writing `/approve cancel` in a comment
</details>
<!-- META={"approvers":[]} -->

Patch:
diff --git a/pkg/common/label.go b/pkg/common/label.go
index 057a9573..f5888218 100644
--- a/pkg/common/label.go
+++ b/pkg/common/label.go
@@ -47,7 +47,7 @@ const (
 	RuntimeControllerReplicas = "controller.runtime." + LabelAnnotationPrefix + "replicas"
 
 	// LabelNodePublishMothod is a pv label that indicates the method nodePuhlishVolume use
-	LabelNodePublishMothod = LabelAnnotationPrefix + "node-puhlish-method"
+	LabelNodePublishMothod = LabelAnnotationPrefix + "node-publish-method"
 )
 
 var (
diff --git a/pkg/ddc/vineyard/runtime_info.go b/pkg/ddc/vineyard/runtime_info.go
index cda4028c..9144989e 100644
--- a/pkg/ddc/vineyard/runtime_info.go
+++ b/pkg/ddc/vineyard/runtime_info.go
@@ -29,7 +29,7 @@ func (e *VineyardEngine) getRuntimeInfo() (base.RuntimeInfoInterface, error) {
 		if runtime.ObjectMeta.Annotations == nil {
 			runtime.ObjectMeta.Annotations = make(map[string]string)
 		}
-		runtime.ObjectMeta.Annotations["data.fluid.io/metadataList"] = `[{"Labels": {"fluid.io/node-puhlish-method": "symlink"}, "selector": { "kind": "PersistentVolume"}}]`
+		runtime.ObjectMeta.Annotations["data.fluid.io/metadataList"] = `[{"Labels": {"fluid.io/node-publish-method": "symlink"}, "selector": { "kind": "PersistentVolume"}}]`
 		tieredStore := runtime.Spec.TieredStore
 		e.runtimeInfo, err = base.BuildRuntimeInfo(e.name, e.namespace, e.runtimeType, tieredStore, base.WithMetadataList(base.GetMetadataListFromAnnotation(runtime)))
 		if err != nil {


Test patch:
diff --git a/pkg/ddc/vineyard/runtime_info_test.go b/pkg/ddc/vineyard/runtime_info_test.go
index 9b035986..da890a3b 100644
--- a/pkg/ddc/vineyard/runtime_info_test.go
+++ b/pkg/ddc/vineyard/runtime_info_test.go
@@ -51,7 +51,7 @@ func TestGetRuntimeInfo(t *testing.T) {
 	addedMeta := []v1alpha1.Metadata{
 		{
 			PodMetadata: v1alpha1.PodMetadata{
-				Labels: map[string]string{"fluid.io/node-puhlish-method": "symlink"},
+				Labels: map[string]string{"fluid.io/node-publish-method": "symlink"},
 			},
 			Selector: metav1.GroupKind{Kind: "PersistentVolume"},
 		},
diff --git a/test/prow/testcases/common/csi_nodepublish_symlink.py b/test/prow/testcases/common/csi_nodepublish_symlink.py
index 97cee2a0..63b4cade 100644
--- a/test/prow/testcases/common/csi_nodepublish_symlink.py
+++ b/test/prow/testcases/common/csi_nodepublish_symlink.py
@@ -48,7 +48,7 @@ def main():
     dataset = fluidapi.assemble_dataset("alluxio-webufs").set_namespaced_name(namespace, name)
     runtime = fluidapi.assemble_runtime("alluxio-webufs").set_namespaced_name(namespace, name)
 
-    csi_symlink_annotation = "[{\"Labels\": {\"fluid.io/node-puhlish-method\": \"symlink\"}, \"selector\": { \"kind\": \"PersistentVolume\"}}]"
+    csi_symlink_annotation = "[{\"Labels\": {\"fluid.io/node-publish-method\": \"symlink\"}, \"selector\": { \"kind\": \"PersistentVolume\"}}]"
     runtime.set_annotation("data.fluid.io/metadataList", csi_symlink_annotation)
 
     flow = TestFlow("Common - Test CSI NodePublishVolume symlink")