nebius/SWE-rebench-V2-PRs huggingface dataset:
Repository: gomods/athens
Pull request #1569 (2020-03-10 21:40:28)

"sumdbPoxy" ==> "sumdbProxy"
<!-- 
    Welcome, Athenian! Can you do us two quick favors before you submit your PR?
    
    1. Briefly fill out the sections below. It will make it easy for us to review your code
    2. Put "[WIP]" at the beginning of your PR title if you're not ready to have this merged yet (we have a bot that will tell everyone that it's a work in progress)
-->

## What is the problem I am trying to address?

The function to create the new checksum DB proxy was called
`sumdbPoxy`. It should be called `sumdbProxy`

## How is the fix applied?

I've renamed the function and its usage everywhere.

## What GitHub issue(s) does this PR fix or close?

<!--
    If it doesn't fix any issues, that's ok. You can leave this blank.

    If it does, then use the below "Fixes #<issue number>" notation below
-->

None

<!-- 
example: Fixes #123
-->

arschles: @marwan-at-work if this looks cool, can you merge after netlify is done?

Patch:
diff --git a/cmd/proxy/actions/app_proxy.go b/cmd/proxy/actions/app_proxy.go
index 79995049..c3e74b8a 100644
--- a/cmd/proxy/actions/app_proxy.go
+++ b/cmd/proxy/actions/app_proxy.go
@@ -44,7 +44,7 @@ func addProxyRoutes(
 		r.HandleFunc(supportPath, func(w http.ResponseWriter, r *http.Request) {
 			w.WriteHeader(200)
 		})
-		sumHandler := sumdbPoxy(sumdbURL, c.NoSumPatterns)
+		sumHandler := sumdbProxy(sumdbURL, c.NoSumPatterns)
 		pathPrefix := "/sumdb/" + sumdbURL.Host
 		r.PathPrefix(pathPrefix + "/").Handler(
 			http.StripPrefix(pathPrefix, sumHandler),
diff --git a/cmd/proxy/actions/sumdb.go b/cmd/proxy/actions/sumdb.go
index 491081d8..24018b1c 100644
--- a/cmd/proxy/actions/sumdb.go
+++ b/cmd/proxy/actions/sumdb.go
@@ -9,7 +9,7 @@ import (
 	"github.com/gomods/athens/pkg/paths"
 )
 
-func sumdbPoxy(url *url.URL, nosumPatterns []string) http.Handler {
+func sumdbProxy(url *url.URL, nosumPatterns []string) http.Handler {
 	rp := httputil.NewSingleHostReverseProxy(url)
 	rp.Director = func(req *http.Request) {
 		req.Host = url.Host


Test patch:
diff --git a/cmd/proxy/actions/sumdb_test.go b/cmd/proxy/actions/sumdb_test.go
index 7b668718..195b9176 100644
--- a/cmd/proxy/actions/sumdb_test.go
+++ b/cmd/proxy/actions/sumdb_test.go
@@ -20,7 +20,7 @@ func TestSumdbProxy(t *testing.T) {
 		panic(err)
 	}
 	pathPrefix := "/sumdb/" + surl.Host
-	h := sumdbPoxy(surl, nil)
+	h := sumdbProxy(surl, nil)
 	h = http.StripPrefix(pathPrefix, h)
 
 	targetURL := "/sumdb/" + surl.Host + "/latest"
Repository: marigold-ui/marigold
Pull request #2636 (2022-11-11 10:44:21)

chore: add columns test
ref: #2634 

changeset-bot[bot]: ###  ⚠️  No Changeset found

Latest commit: c62a26b0bf8a3a197aa3e949e378d48f48ac33c6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. **If these changes should result in a version bump, you need to add a changeset.**

<details><summary>This PR includes no changesets</summary>

  When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

</details>

[Click here to learn what changesets are, and how to add one](https://github.com/changesets/changesets/blob/master/docs/adding-a-changeset.md).

[Click here if you're a maintainer who wants to add a changeset to this PR](https://github.com/marigold-ui/marigold/new/columns-test?filename=.changeset/flat-goats-design.md&value=---%0A%22%40marigold%2Fcomponents%22%3A%20patch%0A---%0A%0Achore%3A%20add%20columns%20test%0A)



Patch:
diff --git a/packages/components/src/Columns/Columns.tsx b/packages/components/src/Columns/Columns.tsx
index 95d20905d..94576a0f0 100755
--- a/packages/components/src/Columns/Columns.tsx
+++ b/packages/components/src/Columns/Columns.tsx
@@ -59,7 +59,7 @@ export const Columns = ({
             flexGrow: columns[idx],
           }}
         >
-          {isValidElement(child) ? cloneElement(child) : null}
+          {isValidElement(child) ? cloneElement(child) : child}
         </Box>
       ))}
     </Box>


Test patch:
diff --git a/packages/components/src/Columns/Columns.test.tsx b/packages/components/src/Columns/Columns.test.tsx
index 2496611b4..1e33816aa 100644
--- a/packages/components/src/Columns/Columns.test.tsx
+++ b/packages/components/src/Columns/Columns.test.tsx
@@ -132,3 +132,13 @@ test('supports stretching to full height', () => {
   const container = screen.getByTestId(/columns/);
   expect(container).toHaveStyle(`height: 100%`);
 });
+
+test('does work with non react elements', () => {
+  render(
+    <Columns columns={[1]} data-testid="columns">
+      hello
+    </Columns>
+  );
+  const container = screen.getByTestId(/columns/);
+  expect(container).toHaveTextContent('hello');
+});
Repository: marigold-ui/marigold
Pull request #2845 (2023-03-03 08:47:18)

refa: `<SVG>` css prop can overrde size (height/width)

changeset-bot[bot]: ###  ⚠️  No Changeset found

Latest commit: 9f838d895d41a17e8681bccf5f477ae32b4e7e37

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. **If these changes should result in a version bump, you need to add a changeset.**

<details><summary>This PR includes no changesets</summary>

  When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

</details>

[Click here to learn what changesets are, and how to add one](https://github.com/changesets/changesets/blob/master/docs/adding-a-changeset.md).

[Click here if you're a maintainer who wants to add a changeset to this PR](https://github.com/marigold-ui/marigold/new/svg-css-prop-overrides?filename=.changeset/calm-tools-jump.md&value=---%0A%22%40marigold%2Fsystem%22%3A%20patch%0A---%0A%0Arefa%3A%20%60%3CSVG%3E%60%20css%20prop%20can%20overrde%20size%20(height%2Fwidth)%0A)



Patch:
diff --git a/.changeset/calm-tools-jump.md b/.changeset/calm-tools-jump.md
new file mode 100644
index 000000000..9c8e2f82d
--- /dev/null
+++ b/.changeset/calm-tools-jump.md
@@ -0,0 +1,5 @@
+---
+"@marigold/system": minor
+---
+
+refa: `<SVG>` css prop can overrde size (height/width)
diff --git a/packages/system/src/components/SVG/SVG.tsx b/packages/system/src/components/SVG/SVG.tsx
index d378c55c4..676ec4830 100644
--- a/packages/system/src/components/SVG/SVG.tsx
+++ b/packages/system/src/components/SVG/SVG.tsx
@@ -25,11 +25,11 @@ export const SVG = forwardRef<SVGElement, SVGProps>(
       {
         ...props,
         css: css({
+          width: toDimension(props.width || size),
+          height: toDimension(props.height || size),
           ...styles,
           fill,
           flex: '0 0 auto',
-          width: toDimension(props.width || size),
-          height: toDimension(props.height || size),
         }),
         ref,
       },


Test patch:
diff --git a/packages/system/src/components/SVG/SVG.test.tsx b/packages/system/src/components/SVG/SVG.test.tsx
index 801eb145b..bf7d34fdc 100644
--- a/packages/system/src/components/SVG/SVG.test.tsx
+++ b/packages/system/src/components/SVG/SVG.test.tsx
@@ -198,3 +198,15 @@ test('css prop', () => {
 
   expect(svg).toHaveStyle(`color: ${theme.colors.red}`);
 });
+
+test('css prop overrides size prop', () => {
+  render(
+    <ThemeProvider theme={theme}>
+      <SVG size={30} css={{ height: 8 }} data-testid="svg" />
+    </ThemeProvider>
+  );
+  const svg = screen.getByTestId('svg');
+
+  expect(svg).toHaveStyle(`height: 8px`);
+  expect(svg).toHaveStyle(`width: 30px`);
+});