Repository: ember-cli/ember-cli
Pull request #9597 (2021-08-23 18:43:21)

update embroider

stefanpenner: oh boy, the embroider tests passed!!!!! 🦖 

Patch:
diff --git a/blueprints/addon/additional-dev-dependencies.json b/blueprints/addon/additional-dev-dependencies.json
index 3f2fab91c..748ad661a 100644
--- a/blueprints/addon/additional-dev-dependencies.json
+++ b/blueprints/addon/additional-dev-dependencies.json
@@ -1,6 +1,6 @@
 {
   "devDependencies": {
-    "@embroider/test-setup": "^0.42.2",
+    "@embroider/test-setup": "^0.44.1",
     "ember-disable-prototype-extensions": "^1.1.3",
     "ember-try": "^1.4.0",
     "ember-source-channel-url": "^3.0.0"
diff --git a/blueprints/app/files/package.json b/blueprints/app/files/package.json
index 249fe11a0..e77025639 100644
--- a/blueprints/app/files/package.json
+++ b/blueprints/app/files/package.json
@@ -25,9 +25,9 @@
   "devDependencies": {
     "@ember/optional-features": "^2.0.0",
     "@ember/test-helpers": "^2.2.8<% if (embroider) { %>",
-    "@embroider/compat": "^0.42.2",
-    "@embroider/core": "^0.42.2",
-    "@embroider/webpack": "^0.42.2<% } %>",
+    "@embroider/compat": "^0.44.1",
+    "@embroider/core": "^0.44.1",
+    "@embroider/webpack": "^0.44.1<% } %>",
     "@glimmer/component": "^1.0.4",
     "@glimmer/tracking": "^1.0.4",
     "babel-eslint": "^10.1.0",


Test patch:
diff --git a/tests/fixtures/addon/defaults/package.json b/tests/fixtures/addon/defaults/package.json
index bfa7e36f3..5baeeac42 100644
--- a/tests/fixtures/addon/defaults/package.json
+++ b/tests/fixtures/addon/defaults/package.json
@@ -32,7 +32,7 @@
   "devDependencies": {
     "@ember/optional-features": "^2.0.0",
     "@ember/test-helpers": "^2.2.8",
-    "@embroider/test-setup": "^0.42.2",
+    "@embroider/test-setup": "^0.44.1",
     "@glimmer/component": "^1.0.4",
     "@glimmer/tracking": "^1.0.4",
     "babel-eslint": "^10.1.0",
diff --git a/tests/fixtures/addon/yarn/package.json b/tests/fixtures/addon/yarn/package.json
index 5bec89957..b7fa28f62 100644
--- a/tests/fixtures/addon/yarn/package.json
+++ b/tests/fixtures/addon/yarn/package.json
@@ -32,7 +32,7 @@
   "devDependencies": {
     "@ember/optional-features": "^2.0.0",
     "@ember/test-helpers": "^2.2.8",
-    "@embroider/test-setup": "^0.42.2",
+    "@embroider/test-setup": "^0.44.1",
     "@glimmer/component": "^1.0.4",
     "@glimmer/tracking": "^1.0.4",
     "babel-eslint": "^10.1.0",
diff --git a/tests/fixtures/app/embroider-no-welcome/package.json b/tests/fixtures/app/embroider-no-welcome/package.json
index d41e0da8c..c80d474f7 100644
--- a/tests/fixtures/app/embroider-no-welcome/package.json
+++ b/tests/fixtures/app/embroider-no-welcome/package.json
@@ -25,9 +25,9 @@
   "devDependencies": {
     "@ember/optional-features": "^2.0.0",
     "@ember/test-helpers": "^2.2.8",
-    "@embroider/compat": "^0.42.2",
-    "@embroider/core": "^0.42.2",
-    "@embroider/webpack": "^0.42.2",
+    "@embroider/compat": "^0.44.1",
+    "@embroider/core": "^0.44.1",
+    "@embroider/webpack": "^0.44.1",
     "@glimmer/component": "^1.0.4",
     "@glimmer/tracking": "^1.0.4",
     "babel-eslint": "^10.1.0",
diff --git a/tests/fixtures/app/embroider-yarn/package.json b/tests/fixtures/app/embroider-yarn/package.json
index 994c6d8c4..a0b1666d1 100644
--- a/tests/fixtures/app/embroider-yarn/package.json
+++ b/tests/fixtures/app/embroider-yarn/package.json
@@ -25,9 +25,9 @@
   "devDependencies": {
     "@ember/optional-features": "^2.0.0",
     "@ember/test-helpers": "^2.2.8",
-    "@embroider/compat": "^0.42.2",
-    "@embroider/core": "^0.42.2",
-    "@embroider/webpack": "^0.42.2",
+    "@embroider/compat": "^0.44.1",
+    "@embroider/core": "^0.44.1",
+    "@embroider/webpack": "^0.44.1",
     "@glimmer/component": "^1.0.4",
     "@glimmer/tracking": "^1.0.4",
     "babel-eslint": "^10.1.0",
diff --git a/tests/fixtures/app/embroider/package.json b/tests/fixtures/app/embroider/package.json
index 994c6d8c4..a0b1666d1 100644
--- a/tests/fixtures/app/embroider/package.json
+++ b/tests/fixtures/app/embroider/package.json
@@ -25,9 +25,9 @@
   "devDependencies": {
     "@ember/optional-features": "^2.0.0",
     "@ember/test-helpers": "^2.2.8",
-    "@embroider/compat": "^0.42.2",
-    "@embroider/core": "^0.42.2",
-    "@embroider/webpack": "^0.42.2",
+    "@embroider/compat": "^0.44.1",
+    "@embroider/core": "^0.44.1",
+    "@embroider/webpack": "^0.44.1",
     "@glimmer/component": "^1.0.4",
     "@glimmer/tracking": "^1.0.4",
     "babel-eslint": "^10.1.0",
diff --git a/tests/helpers/dist-checker.js b/tests/helpers/dist-checker.js
index 12e540e99..df7bf4237 100644
--- a/tests/helpers/dist-checker.js
+++ b/tests/helpers/dist-checker.js
@@ -4,6 +4,7 @@ const fs = require('fs');
 const path = require('path');
 // eslint-disable-next-line node/no-unpublished-require
 const jsdom = require('jsdom');
+const { AssertionError } = require('assert');
 
 class CustomResourceLoader extends jsdom.ResourceLoader {
   constructor(distPath) {
@@ -41,7 +42,26 @@ class DistChecker {
     this.dom.window.crypto = () => {};
     return new Promise((resolve, reject) => {
       // reject if the scripts take longer than 15 seconds to load.
-      let timeoutId = setTimeout(reject, timeout);
+      let timeoutId = setTimeout(() => {
+        reject(
+          new AssertionError({
+            operator: 'evalScripts[Timeout]',
+            message: `[dist-checker:${this.distPath}] timeout exceeded: ${timeout}`,
+            stackStartFn: this.evalScripts,
+          })
+        );
+      }, timeout);
+
+      this.dom.window.addEventListener('error', (e) => {
+        reject(
+          new AssertionError({
+            operator: 'evalScripts',
+            // this `e` has no stack, so we must make due
+            message: `error thrown during evalScript of '${this.distPath}' \n error details: \n   message: '${e.message}'\n   file: '${e.filename}:${e.colno}'`,
+            stackStartFn: this.evalScripts,
+          })
+        );
+      });
 
       this.dom.window.addEventListener('load', () => {
         clearTimeout(timeoutId);