Repository: ember-cli/ember-cli
Pull request #8572 (2019-04-09 12:10:04)

use eslint-plugin-node v8 in blueprints
Requested https://github.com/ember-cli/ember-cli/pull/8205#discussion_r273137782


Patch:
diff --git a/blueprints/addon/index.js b/blueprints/addon/index.js
index 50ebe5331..25eae64be 100644
--- a/blueprints/addon/index.js
+++ b/blueprints/addon/index.js
@@ -70,7 +70,7 @@ module.exports = {
     contents.devDependencies['ember-disable-prototype-extensions'] = '^1.1.3';
 
     // add `eslint-plugin-node` to addons by default
-    contents.devDependencies['eslint-plugin-node'] = '^7.0.1';
+    contents.devDependencies['eslint-plugin-node'] = '^8.0.1';
 
     // add ember-try
     contents.devDependencies['ember-try'] = '^1.0.0';


Test patch:
diff --git a/tests/fixtures/addon/npm/package.json b/tests/fixtures/addon/npm/package.json
index af33ca7fe..5c3a60f4e 100644
--- a/tests/fixtures/addon/npm/package.json
+++ b/tests/fixtures/addon/npm/package.json
@@ -45,7 +45,7 @@
     "ember-source-channel-url": "^1.1.0",
     "ember-try": "^1.0.0",
     "eslint-plugin-ember": "^6.2.0",
-    "eslint-plugin-node": "^7.0.1",
+    "eslint-plugin-node": "^8.0.1",
     "loader.js": "^4.7.0",
     "qunit-dom": "^0.8.4"
   },
diff --git a/tests/fixtures/addon/yarn/package.json b/tests/fixtures/addon/yarn/package.json
index b10f5e0f0..ca29ccab2 100644
--- a/tests/fixtures/addon/yarn/package.json
+++ b/tests/fixtures/addon/yarn/package.json
@@ -46,7 +46,7 @@
     "ember-try": "^1.0.0",
     "ember-welcome-page": "^4.0.0",
     "eslint-plugin-ember": "^6.2.0",
-    "eslint-plugin-node": "^7.0.1",
+    "eslint-plugin-node": "^8.0.1",
     "loader.js": "^4.7.0",
     "qunit-dom": "^0.8.4"
   },
diff --git a/tests/fixtures/module-unification-addon/npm/package.json b/tests/fixtures/module-unification-addon/npm/package.json
index 0103fab37..6d4f70521 100644
--- a/tests/fixtures/module-unification-addon/npm/package.json
+++ b/tests/fixtures/module-unification-addon/npm/package.json
@@ -45,7 +45,7 @@
     "ember-source-channel-url": "^1.1.0",
     "ember-try": "^1.0.0",
     "eslint-plugin-ember": "^6.2.0",
-    "eslint-plugin-node": "^7.0.1",
+    "eslint-plugin-node": "^8.0.1",
     "loader.js": "^4.7.0",
     "qunit-dom": "^0.8.4"
   },
diff --git a/tests/fixtures/module-unification-addon/yarn/package.json b/tests/fixtures/module-unification-addon/yarn/package.json
index 6c982b3d5..daca38545 100644
--- a/tests/fixtures/module-unification-addon/yarn/package.json
+++ b/tests/fixtures/module-unification-addon/yarn/package.json
@@ -46,7 +46,7 @@
     "ember-try": "^1.0.0",
     "ember-welcome-page": "^4.0.0",
     "eslint-plugin-ember": "^6.2.0",
-    "eslint-plugin-node": "^7.0.1",
+    "eslint-plugin-node": "^8.0.1",
     "loader.js": "^4.7.0",
     "qunit-dom": "^0.8.4"
   },
diff --git a/tests/unit/blueprints/addon-test.js b/tests/unit/blueprints/addon-test.js
index 7be6afba4..d3eb777e9 100644
--- a/tests/unit/blueprints/addon-test.js
+++ b/tests/unit/blueprints/addon-test.js
@@ -83,7 +83,7 @@ describe('blueprint - addon', function() {
     "ember-disable-prototype-extensions": "^1.1.3",\n\
     "ember-source-channel-url": "^1.1.0",\n\
     "ember-try": "^1.0.0",\n\
-    "eslint-plugin-node": "^7.0.1"\n\
+    "eslint-plugin-node": "^8.0.1"\n\
   },\n\
   "ember-addon": {\n\
     "configPath": "tests/dummy/config"\n\