Repository: microsoft/vscode-edge-devtools
Pull request #1230 (2022-10-20 02:21:43)

Changed docs.microsoft.com to learn.microsoft.com
Please inspect removal of /en-us in code listings.

captainbrosset: @codepo8 should we merge this now?
codepo8: sure

From: Patrick Brosset ***@***.***>
Date: Tuesday, 25 October 2022 at 10:18
To: microsoft/vscode-edge-devtools ***@***.***>
Cc: Chris Heilmann ***@***.***>, Mention ***@***.***>
Subject: Re: [microsoft/vscode-edge-devtools] Changed docs.microsoft.com to learn.microsoft.com (PR #1230)

@codepo8<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fcodepo8&data=05%7C01%7Cchristian.heilmann%40microsoft.com%7Ccbce67c4183d412f066308dab6618878%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C638022827308512524%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=rr7edLjI7QAfUdfB0sdR4EATu1%2FSfXlBYVIzHD6CR0w%3D&reserved=0> should we merge this now?

—
Reply to this email directly, view it on GitHub<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fvscode-edge-devtools%2Fpull%2F1230%23issuecomment-1290169105&data=05%7C01%7Cchristian.heilmann%40microsoft.com%7Ccbce67c4183d412f066308dab6618878%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C638022827308512524%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=Eg4M35%2BHOI%2BhIS6hWPYjiGm9v%2Fpbwomzk06Ca1fClyo%3D&reserved=0>, or unsubscribe<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAADJRFM2JIEH6IVTTC54D3WE6JWJANCNFSM6AAAAAARJVVV2Y&data=05%7C01%7Cchristian.heilmann%40microsoft.com%7Ccbce67c4183d412f066308dab6618878%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C638022827308512524%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=HJqUa8cU5FN%2BsIU7Oh2JThWg179bVG5dMftSJpYNbNE%3D&reserved=0>.
You are receiving this because you were mentioned.Message ID: ***@***.***>


Patch:
diff --git a/README.md b/README.md
index f514c0d..aeac03d 100644
--- a/README.md
+++ b/README.md
@@ -12,11 +12,11 @@ Features:
 * Console and Application tool
 * Breakpoint support
 
-**Note**: This extension needs Microsoft Edge to be on your computer. Windows machines already come with it, for Mac and Linux, please [download and install a version of Edge](https://www.microsoft.com/en-us/edge).
+**Note**: This extension needs Microsoft Edge to be on your computer. Windows machines already come with it, for Mac and Linux, please [download and install a version of Edge](https://www.microsoft.com/edge).
 
 ## Documentation
 
-For more details on how to use and customize the extension, [refer to the documentation](https://docs.microsoft.com/microsoft-edge/visual-studio-code/microsoft-edge-devtools-extension).
+For more details on how to use and customize the extension, [refer to the documentation](https://learn.microsoft.com/microsoft-edge/visual-studio-code/microsoft-edge-devtools-extension).
 
 ## Contributing
 
diff --git a/azure-pipelines.yml b/azure-pipelines.yml
index 6758912..f36bcb9 100644
--- a/azure-pipelines.yml
+++ b/azure-pipelines.yml
@@ -1,7 +1,7 @@
 # Node.js
 # Build a general Node.js project with npm.
 # Add steps that analyze code, save build artifacts, deploy, and more:
-# https://docs.microsoft.com/azure/devops/pipelines/languages/javascript
+# https://learn.microsoft.com/azure/devops/pipelines/languages/javascript
 
 trigger:
 - main
diff --git a/src/cdpTargetsProvider.ts b/src/cdpTargetsProvider.ts
index fd0d5a2..523b8b0 100644
--- a/src/cdpTargetsProvider.ts
+++ b/src/cdpTargetsProvider.ts
@@ -107,7 +107,7 @@ export class CDPTargetsProvider implements vscode.TreeDataProvider<CDPTarget> {
         }
         const faviconRegex = /((?:\/\/|\.)([^\.]*)\.[^\.^\/]+\/).*/;
 
-        // Example regex match: https://docs.microsoft.com/en-us/microsoft-edge/
+        // Example regex match: https://learn.microsoft.com/en-us/microsoft-edge/
         // urlMatch[0] = .microsoft.com/en-us/microsoft-edge/
         // urlMatch[1] = .microsoft.com/
         // urlMatch[2] = microsoft
diff --git a/src/extension.ts b/src/extension.ts
index fc665ac..83fc178 100644
--- a/src/extension.ts
+++ b/src/extension.ts
@@ -231,7 +231,7 @@ export function activate(context: vscode.ExtensionContext): void {
         }));
     context.subscriptions.push(vscode.commands.registerCommand(`${SETTINGS_VIEW_NAME}.viewDocumentation`, () => {
             telemetryReporter.sendTelemetryEvent('user/buttonPress', { 'VSCode.buttonCode': buttonCode.viewDocumentation });
-            void vscode.env.openExternal(vscode.Uri.parse('https://docs.microsoft.com/en-us/microsoft-edge/visual-studio-code/microsoft-edge-devtools-extension'));
+            void vscode.env.openExternal(vscode.Uri.parse('https://learn.microsoft.com/microsoft-edge/visual-studio-code/microsoft-edge-devtools-extension'));
         }));
 
     context.subscriptions.push(vscode.commands.registerCommand(`${SETTINGS_VIEW_NAME}.cssMirrorContent`, () => {
diff --git a/src/screencast/input.ts b/src/screencast/input.ts
index 394688e..b50aff7 100644
--- a/src/screencast/input.ts
+++ b/src/screencast/input.ts
@@ -34,7 +34,7 @@ export class ScreencastInputHandler {
         }
         this.cdpConnection.sendMessageToBackend('Input.dispatchMouseEvent', {
             type: eventType,
-            clickCount: mouseEvent.detail, // per https://developer.mozilla.org/en-US/docs/Web/API/UIEvent/detail
+            clickCount: mouseEvent.detail, // per https://developer.mozilla.org/docs/Web/API/UIEvent/detail
             x: Math.round(mouseEvent.offsetX / scale),
             y: Math.round(mouseEvent.offsetY / scale),
             modifiers: this.modifiersForEvent(mouseEvent),
diff --git a/startpage/index.html b/startpage/index.html
index cb4acd6..60d8750 100644
--- a/startpage/index.html
+++ b/startpage/index.html
@@ -71,7 +71,7 @@
     <section>
         <h2>Success!</h2>
         <p>You have successfully started an instance of Microsoft Edge inside your Visual Studio Code editor.</p>
-        <p>You can now use the <a href="https://docs.microsoft.com/microsoft-edge/devtools-guide-chromium">Edge Developer Tools</a> inside your editor to inspect, change and debug any web project.</p>
+        <p>You can now use the <a href="https://learn.microsoft.com/microsoft-edge/devtools-guide-chromium">Edge Developer Tools</a> inside your editor to inspect, change and debug any web project.</p>
         <p>Use the URL bar above to navigate to your project or start changing the styles of this document.</p>
         <!-- <p id="headless"></p> -->
         <p>If you have any questions or concerns, please head over to the <a href="https://github.com/microsoft/vscode-edge-devtools/issues">GitHub repository</a>, read up on how to use the extension or report us your problems and ideas. We're happy to listen! 


Test patch:
diff --git a/test/cdpTargetsProvider.test.ts b/test/cdpTargetsProvider.test.ts
index c560b19..66619ff 100644
--- a/test/cdpTargetsProvider.test.ts
+++ b/test/cdpTargetsProvider.test.ts
@@ -120,7 +120,7 @@ describe("CDPTargetsProvider", () => {
             url: '',
             webSocketDebuggerUrl: ''
         }
-        template.url = "https://learn.microsoft.com/en-us/microsoft-edge/";
+        template.url = "https://learn.microsoft.com/microsoft-edge/";
         await provider.downloadFaviconFromSitePromise(template);
         const microsoftIcon = template.faviconUrl;
         template.url = "https://www.bing.com/";