Repository: ember-cli/ember-cli
Pull request #9481 (2021-03-09 16:53:41)

Pin QUnit to 2.13.0 due to strict mode regression in 2.14.0.
QUnit 2.14 introduced issues when using QUnit in strict mode (in https://github.com/qunitjs/qunit/commit/2671d3f6c1c2b72a5fb9299bdce6eab70f2876a6), which causes errors during Embroider builds.

The issue has been fixed (in https://github.com/qunitjs/qunit/pull/1558) but is not yet released. This pins QUnit to `~2.13.0` while we wait for a new release with the fix. This change should be reverted (and the minimum version updated) once https://github.com/qunitjs/qunit/pull/1558 is released.



Patch:
diff --git a/blueprints/app/files/package.json b/blueprints/app/files/package.json
index 00881532b..ce8fa9de6 100644
--- a/blueprints/app/files/package.json
+++ b/blueprints/app/files/package.json
@@ -47,7 +47,7 @@
     "ember-load-initializers": "^2.1.2",
     "ember-maybe-import-regenerator": "^0.1.6",
     "ember-page-title": "^6.2.1",
-    "ember-qunit": "^5.1.2",
+    "ember-qunit": "^5.1.4",
     "ember-resolver": "^8.0.2",
     "ember-source": "~3.26.0-beta.2",
     "ember-template-lint": "^2.18.1<% if (welcome) { %>",
@@ -61,7 +61,7 @@
     "loader.js": "^4.7.0",
     "npm-run-all": "^4.1.5",
     "prettier": "^2.2.1",
-    "qunit": "^2.14.0",
+    "qunit": "~2.13.0",
     "qunit-dom": "^1.6.0"
   },
   "engines": {


Test patch:
diff --git a/tests/fixtures/addon/defaults/package.json b/tests/fixtures/addon/defaults/package.json
index d6de0f21e..65ae8cce1 100644
--- a/tests/fixtures/addon/defaults/package.json
+++ b/tests/fixtures/addon/defaults/package.json
@@ -48,7 +48,7 @@
     "ember-load-initializers": "^2.1.2",
     "ember-maybe-import-regenerator": "^0.1.6",
     "ember-page-title": "^6.2.1",
-    "ember-qunit": "^5.1.2",
+    "ember-qunit": "^5.1.4",
     "ember-resolver": "^8.0.2",
     "ember-source": "~3.26.0-beta.2",
     "ember-source-channel-url": "^3.0.0",
@@ -63,7 +63,7 @@
     "loader.js": "^4.7.0",
     "npm-run-all": "^4.1.5",
     "prettier": "^2.2.1",
-    "qunit": "^2.14.0",
+    "qunit": "~2.13.0",
     "qunit-dom": "^1.6.0"
   },
   "engines": {
diff --git a/tests/fixtures/addon/yarn/package.json b/tests/fixtures/addon/yarn/package.json
index cc6158660..c8b69284d 100644
--- a/tests/fixtures/addon/yarn/package.json
+++ b/tests/fixtures/addon/yarn/package.json
@@ -48,7 +48,7 @@
     "ember-load-initializers": "^2.1.2",
     "ember-maybe-import-regenerator": "^0.1.6",
     "ember-page-title": "^6.2.1",
-    "ember-qunit": "^5.1.2",
+    "ember-qunit": "^5.1.4",
     "ember-resolver": "^8.0.2",
     "ember-source": "~3.26.0-beta.2",
     "ember-source-channel-url": "^3.0.0",
@@ -64,7 +64,7 @@
     "loader.js": "^4.7.0",
     "npm-run-all": "^4.1.5",
     "prettier": "^2.2.1",
-    "qunit": "^2.14.0",
+    "qunit": "~2.13.0",
     "qunit-dom": "^1.6.0"
   },
   "engines": {
diff --git a/tests/fixtures/app/defaults/package.json b/tests/fixtures/app/defaults/package.json
index a6a808d81..e4dbec59e 100644
--- a/tests/fixtures/app/defaults/package.json
+++ b/tests/fixtures/app/defaults/package.json
@@ -44,7 +44,7 @@
     "ember-load-initializers": "^2.1.2",
     "ember-maybe-import-regenerator": "^0.1.6",
     "ember-page-title": "^6.2.1",
-    "ember-qunit": "^5.1.2",
+    "ember-qunit": "^5.1.4",
     "ember-resolver": "^8.0.2",
     "ember-source": "~3.26.0-beta.2",
     "ember-template-lint": "^2.18.1",
@@ -58,7 +58,7 @@
     "loader.js": "^4.7.0",
     "npm-run-all": "^4.1.5",
     "prettier": "^2.2.1",
-    "qunit": "^2.14.0",
+    "qunit": "~2.13.0",
     "qunit-dom": "^1.6.0"
   },
   "engines": {
diff --git a/tests/fixtures/app/embroider-no-welcome/package.json b/tests/fixtures/app/embroider-no-welcome/package.json
index 8b0fc2e43..81596fe1b 100644
--- a/tests/fixtures/app/embroider-no-welcome/package.json
+++ b/tests/fixtures/app/embroider-no-welcome/package.json
@@ -47,7 +47,7 @@
     "ember-load-initializers": "^2.1.2",
     "ember-maybe-import-regenerator": "^0.1.6",
     "ember-page-title": "^6.2.1",
-    "ember-qunit": "^5.1.2",
+    "ember-qunit": "^5.1.4",
     "ember-resolver": "^8.0.2",
     "ember-source": "~3.26.0-beta.2",
     "ember-template-lint": "^2.18.1",
@@ -60,7 +60,7 @@
     "loader.js": "^4.7.0",
     "npm-run-all": "^4.1.5",
     "prettier": "^2.2.1",
-    "qunit": "^2.14.0",
+    "qunit": "~2.13.0",
     "qunit-dom": "^1.6.0"
   },
   "engines": {
diff --git a/tests/fixtures/app/embroider/package.json b/tests/fixtures/app/embroider/package.json
index 422b6cc5d..a5bbdfccb 100644
--- a/tests/fixtures/app/embroider/package.json
+++ b/tests/fixtures/app/embroider/package.json
@@ -47,7 +47,7 @@
     "ember-load-initializers": "^2.1.2",
     "ember-maybe-import-regenerator": "^0.1.6",
     "ember-page-title": "^6.2.1",
-    "ember-qunit": "^5.1.2",
+    "ember-qunit": "^5.1.4",
     "ember-resolver": "^8.0.2",
     "ember-source": "~3.26.0-beta.2",
     "ember-template-lint": "^2.18.1",
@@ -61,7 +61,7 @@
     "loader.js": "^4.7.0",
     "npm-run-all": "^4.1.5",
     "prettier": "^2.2.1",
-    "qunit": "^2.14.0",
+    "qunit": "~2.13.0",
     "qunit-dom": "^1.6.0"
   },
   "engines": {
diff --git a/tests/fixtures/app/npm/package.json b/tests/fixtures/app/npm/package.json
index 23cb47193..9424291fa 100644
--- a/tests/fixtures/app/npm/package.json
+++ b/tests/fixtures/app/npm/package.json
@@ -44,7 +44,7 @@
     "ember-load-initializers": "^2.1.2",
     "ember-maybe-import-regenerator": "^0.1.6",
     "ember-page-title": "^6.2.1",
-    "ember-qunit": "^5.1.2",
+    "ember-qunit": "^5.1.4",
     "ember-resolver": "^8.0.2",
     "ember-source": "~3.26.0-beta.2",
     "ember-template-lint": "^2.18.1",
@@ -57,7 +57,7 @@
     "loader.js": "^4.7.0",
     "npm-run-all": "^4.1.5",
     "prettier": "^2.2.1",
-    "qunit": "^2.14.0",
+    "qunit": "~2.13.0",
     "qunit-dom": "^1.6.0"
   },
   "engines": {
diff --git a/tests/fixtures/app/with-blueprint-override-lint-fail/package.json b/tests/fixtures/app/with-blueprint-override-lint-fail/package.json
index 887ab0ad5..8bebe0d2a 100644
--- a/tests/fixtures/app/with-blueprint-override-lint-fail/package.json
+++ b/tests/fixtures/app/with-blueprint-override-lint-fail/package.json
@@ -57,7 +57,7 @@
     "loader.js": "^4.7.0",
     "npm-run-all": "^4.1.5",
     "prettier": "^2.2.1",
-    "qunit": "^2.14.0",
+    "qunit": "~2.13.0",
     "qunit-dom": "^1.6.0"
   },
   "engines": {
diff --git a/tests/fixtures/app/yarn/package.json b/tests/fixtures/app/yarn/package.json
index a6a808d81..e4dbec59e 100644
--- a/tests/fixtures/app/yarn/package.json
+++ b/tests/fixtures/app/yarn/package.json
@@ -44,7 +44,7 @@
     "ember-load-initializers": "^2.1.2",
     "ember-maybe-import-regenerator": "^0.1.6",
     "ember-page-title": "^6.2.1",
-    "ember-qunit": "^5.1.2",
+    "ember-qunit": "^5.1.4",
     "ember-resolver": "^8.0.2",
     "ember-source": "~3.26.0-beta.2",
     "ember-template-lint": "^2.18.1",
@@ -58,7 +58,7 @@
     "loader.js": "^4.7.0",
     "npm-run-all": "^4.1.5",
     "prettier": "^2.2.1",
-    "qunit": "^2.14.0",
+    "qunit": "~2.13.0",
     "qunit-dom": "^1.6.0"
   },
   "engines": {