Repository: ember-cli/ember-cli
Pull request #10134 (2023-01-18 21:36:21)

Fix beta CI?
This commit makes tests pass locally, but no idea why


Patch:
diff --git a/blueprints/addon/index.js b/blueprints/addon/index.js
index 457a23eee..2af52390c 100644
--- a/blueprints/addon/index.js
+++ b/blueprints/addon/index.js
@@ -66,6 +66,14 @@ module.exports = {
     delete contents.devDependencies['ember-data'];
     delete contents.devDependencies['ember-fetch'];
 
+    // Per RFC #811, addons should not have this dependency.
+    // @see https://github.com/emberjs/rfcs/blob/master/text/0811-element-modifiers.md#detailed-design
+    delete contents.devDependencies['ember-modifier'];
+
+    // Per RFC #812, addons should not have this dependency.
+    // @see https://github.com/emberjs/rfcs/blob/master/text/0812-tracked-built-ins.md#detailed-design
+    delete contents.devDependencies['tracked-built-ins'];
+
     // 100% of addons don't need ember-cli-app-version, make it opt-in instead
     delete contents.devDependencies['ember-cli-app-version'];
 
diff --git a/blueprints/app/files/package.json b/blueprints/app/files/package.json
index 307110c01..f633d6a59 100644
--- a/blueprints/app/files/package.json
+++ b/blueprints/app/files/package.json
@@ -64,6 +64,7 @@
     "prettier": "^2.8.1",
     "qunit": "^2.19.3",
     "qunit-dom": "^2.0.0",
+    "tracked-built-ins": "^3.1.0",
     "webpack": "^5.75.0"
   },
   "engines": {


Test patch:
diff --git a/tests/acceptance/addon-smoke-test-slow.js b/tests/acceptance/addon-smoke-test-slow.js
index 6ab3c4cc6..8e1f2aa40 100644
--- a/tests/acceptance/addon-smoke-test-slow.js
+++ b/tests/acceptance/addon-smoke-test-slow.js
@@ -7,7 +7,6 @@ const execa = require('execa');
 const chalk = require('chalk');
 
 const runCommand = require('../helpers/run-command');
-const ember = require('../helpers/ember');
 const copyFixtureFiles = require('../helpers/copy-fixture-files');
 const acceptance = require('../helpers/acceptance');
 let createTestTargets = acceptance.createTestTargets;
@@ -59,8 +58,9 @@ describe('Acceptance: addon-smoke-test', function () {
     expect(packageContents['ember-addon']).to.deep.equal({ configPath: 'tests/dummy/config' });
   });
 
-  it('ember addon foo, clean from scratch', function () {
-    return ember(['test']);
+  it('ember addon foo, clean from scratch', async function () {
+    let result = await runCommand('node_modules/ember-cli/bin/ember', 'test');
+    expect(result.code).to.eql(0);
   });
 
   it('works in most common scenarios for an example addon', async function () {
diff --git a/tests/fixtures/app/defaults/package.json b/tests/fixtures/app/defaults/package.json
index f9d3955bb..fda3a69fe 100644
--- a/tests/fixtures/app/defaults/package.json
+++ b/tests/fixtures/app/defaults/package.json
@@ -58,6 +58,7 @@
     "prettier": "^2.8.1",
     "qunit": "^2.19.3",
     "qunit-dom": "^2.0.0",
+    "tracked-built-ins": "^3.1.0",
     "webpack": "^5.75.0"
   },
   "engines": {
diff --git a/tests/fixtures/app/embroider-no-welcome/package.json b/tests/fixtures/app/embroider-no-welcome/package.json
index c20cbab42..74eba072a 100644
--- a/tests/fixtures/app/embroider-no-welcome/package.json
+++ b/tests/fixtures/app/embroider-no-welcome/package.json
@@ -60,6 +60,7 @@
     "prettier": "^2.8.1",
     "qunit": "^2.19.3",
     "qunit-dom": "^2.0.0",
+    "tracked-built-ins": "^3.1.0",
     "webpack": "^5.75.0"
   },
   "engines": {
diff --git a/tests/fixtures/app/embroider-yarn/package.json b/tests/fixtures/app/embroider-yarn/package.json
index 93cd34e69..64c8d83a6 100644
--- a/tests/fixtures/app/embroider-yarn/package.json
+++ b/tests/fixtures/app/embroider-yarn/package.json
@@ -61,6 +61,7 @@
     "prettier": "^2.8.1",
     "qunit": "^2.19.3",
     "qunit-dom": "^2.0.0",
+    "tracked-built-ins": "^3.1.0",
     "webpack": "^5.75.0"
   },
   "engines": {
diff --git a/tests/fixtures/app/embroider/package.json b/tests/fixtures/app/embroider/package.json
index 93cd34e69..64c8d83a6 100644
--- a/tests/fixtures/app/embroider/package.json
+++ b/tests/fixtures/app/embroider/package.json
@@ -61,6 +61,7 @@
     "prettier": "^2.8.1",
     "qunit": "^2.19.3",
     "qunit-dom": "^2.0.0",
+    "tracked-built-ins": "^3.1.0",
     "webpack": "^5.75.0"
   },
   "engines": {
diff --git a/tests/fixtures/app/npm-travis/package.json b/tests/fixtures/app/npm-travis/package.json
index 92771d9cf..d0af23f15 100644
--- a/tests/fixtures/app/npm-travis/package.json
+++ b/tests/fixtures/app/npm-travis/package.json
@@ -57,7 +57,8 @@
     "loader.js": "^4.7.0",
     "prettier": "^2.3.0",
     "qunit": "^2.15.0",
-    "qunit-dom": "^1.6.0"
+    "qunit-dom": "^1.6.0",
+    "tracked-built-ins": "^3.1.0"
   },
   "engines": {
     "node": "14.* || 16.* || >= 18"
diff --git a/tests/fixtures/app/npm/package.json b/tests/fixtures/app/npm/package.json
index 34d987b58..958ebbb13 100644
--- a/tests/fixtures/app/npm/package.json
+++ b/tests/fixtures/app/npm/package.json
@@ -57,6 +57,7 @@
     "prettier": "^2.8.1",
     "qunit": "^2.19.3",
     "qunit-dom": "^2.0.0",
+    "tracked-built-ins": "^3.1.0",
     "webpack": "^5.75.0"
   },
   "engines": {
diff --git a/tests/fixtures/app/with-blueprint-override-lint-fail/package.json b/tests/fixtures/app/with-blueprint-override-lint-fail/package.json
index 6cc607ab4..551aef3db 100644
--- a/tests/fixtures/app/with-blueprint-override-lint-fail/package.json
+++ b/tests/fixtures/app/with-blueprint-override-lint-fail/package.json
@@ -56,7 +56,8 @@
     "loader.js": "^4.7.0",
     "prettier": "^2.2.1",
     "qunit": "^2.14.1",
-    "qunit-dom": "^1.6.0"
+    "qunit-dom": "^1.6.0",
+    "tracked-built-ins": "^3.1.0"
   },
   "engines": {
     "node": "14.* || 16.* || >= 18"
diff --git a/tests/fixtures/app/yarn-travis/package.json b/tests/fixtures/app/yarn-travis/package.json
index f8b6af620..a2466f334 100644
--- a/tests/fixtures/app/yarn-travis/package.json
+++ b/tests/fixtures/app/yarn-travis/package.json
@@ -58,7 +58,8 @@
     "loader.js": "^4.7.0",
     "prettier": "^2.3.0",
     "qunit": "^2.15.0",
-    "qunit-dom": "^1.6.0"
+    "qunit-dom": "^1.6.0",
+    "tracked-built-ins": "^3.1.0"
   },
   "engines": {
     "node": "14.* || 16.* || >= 18"
diff --git a/tests/fixtures/app/yarn/package.json b/tests/fixtures/app/yarn/package.json
index f9d3955bb..fda3a69fe 100644
--- a/tests/fixtures/app/yarn/package.json
+++ b/tests/fixtures/app/yarn/package.json
@@ -58,6 +58,7 @@
     "prettier": "^2.8.1",
     "qunit": "^2.19.3",
     "qunit-dom": "^2.0.0",
+    "tracked-built-ins": "^3.1.0",
     "webpack": "^5.75.0"
   },
   "engines": {