Repository: ember-cli/ember-cli
Pull request #8288 (2018-12-12 20:48:27)

Revert #8165
Removing the default scenario from `ember-try.js` omits it from tests runs initiated via `yarn test:all` or `ember try:each`, and potentially creates holes in test coverage for users that use CI services other than travis.

Reverts #8165

rwjblue: Since https://github.com/ember-cli/ember-cli/pull/8165 landed in release, we should target this at release. 

Can you:

* update target branch in GH
* rebase dropping all commits other than the one you are introducing
* force update your remote branch

I’m happy to do ^ when I’m back at a computer, just let me know if you’d like help there...
kellyselden: Also please add a comment so this doesn't happen again.

Patch:
diff --git a/blueprints/addon/files/addon-config/ember-try.js b/blueprints/addon/files/addon-config/ember-try.js
index df19d1fce..06d72f7f7 100644
--- a/blueprints/addon/files/addon-config/ember-try.js
+++ b/blueprints/addon/files/addon-config/ember-try.js
@@ -59,6 +59,16 @@ module.exports = function() {
             }
           }
         },
+        // The default `.travis.yml` runs this scenario via `<% if (yarn) { %>yarn<% } else { %>npm<% } %> test`,
+        // not via `ember try`. It's still included here so that running
+        // `ember try:each` manually or from a customized CI config will run it
+        // along with all the other scenarios.
+        {
+          name: 'ember-default',
+          npm: {
+            devDependencies: {}
+          }
+        },
         {
           name: 'ember-default-with-jquery',
           env: {


Test patch:
diff --git a/tests/fixtures/addon/npm/config/ember-try.js b/tests/fixtures/addon/npm/config/ember-try.js
index a18fc9605..4d0ae0e4e 100644
--- a/tests/fixtures/addon/npm/config/ember-try.js
+++ b/tests/fixtures/addon/npm/config/ember-try.js
@@ -58,6 +58,16 @@ module.exports = function() {
             }
           }
         },
+        // The default `.travis.yml` runs this scenario via `npm test`,
+        // not via `ember try`. It's still included here so that running
+        // `ember try:each` manually or from a customized CI config will run it
+        // along with all the other scenarios.
+        {
+          name: 'ember-default',
+          npm: {
+            devDependencies: {}
+          }
+        },
         {
           name: 'ember-default-with-jquery',
           env: {
diff --git a/tests/fixtures/addon/yarn/config/ember-try.js b/tests/fixtures/addon/yarn/config/ember-try.js
index 976c8f7a6..2a894f869 100644
--- a/tests/fixtures/addon/yarn/config/ember-try.js
+++ b/tests/fixtures/addon/yarn/config/ember-try.js
@@ -59,6 +59,16 @@ module.exports = function() {
             }
           }
         },
+        // The default `.travis.yml` runs this scenario via `yarn test`,
+        // not via `ember try`. It's still included here so that running
+        // `ember try:each` manually or from a customized CI config will run it
+        // along with all the other scenarios.
+        {
+          name: 'ember-default',
+          npm: {
+            devDependencies: {}
+          }
+        },
         {
           name: 'ember-default-with-jquery',
           env: {