Repository: ember-cli/ember-cli
Pull request #10109 (2022-12-13 03:04:08)

[RFC 811] Add `ember-modifier` dependency to app blueprint
RFC link: https://github.com/emberjs/rfcs/pull/811


Patch:
diff --git a/blueprints/addon/index.js b/blueprints/addon/index.js
index 457a23eee..ad3c3aad8 100644
--- a/blueprints/addon/index.js
+++ b/blueprints/addon/index.js
@@ -66,6 +66,10 @@ module.exports = {
     delete contents.devDependencies['ember-data'];
     delete contents.devDependencies['ember-fetch'];
 
+    // Per RFC #811, addons should not have this dependency.
+    // @see https://github.com/emberjs/rfcs/blob/master/text/0811-element-modifiers.md#detailed-design
+    delete contents.devDependencies['ember-modifier'];
+
     // 100% of addons don't need ember-cli-app-version, make it opt-in instead
     delete contents.devDependencies['ember-cli-app-version'];
 
diff --git a/blueprints/app/files/package.json b/blueprints/app/files/package.json
index 307110c01..c45ac227b 100644
--- a/blueprints/app/files/package.json
+++ b/blueprints/app/files/package.json
@@ -48,6 +48,7 @@
     "ember-data": "~4.10.0-beta.2",
     "ember-fetch": "^8.1.2",
     "ember-load-initializers": "^2.1.2",
+    "ember-modifier": "^4.0.0",
     "ember-page-title": "^7.0.0",
     "ember-qunit": "^6.0.0",
     "ember-resolver": "^8.0.3",


Test patch:
diff --git a/tests/fixtures/app/defaults/package.json b/tests/fixtures/app/defaults/package.json
index f9d3955bb..9475f489a 100644
--- a/tests/fixtures/app/defaults/package.json
+++ b/tests/fixtures/app/defaults/package.json
@@ -42,6 +42,7 @@
     "ember-data": "~4.10.0-beta.2",
     "ember-fetch": "^8.1.2",
     "ember-load-initializers": "^2.1.2",
+    "ember-modifier": "^4.0.0",
     "ember-page-title": "^7.0.0",
     "ember-qunit": "^6.0.0",
     "ember-resolver": "^8.0.3",
diff --git a/tests/fixtures/app/embroider-no-welcome/package.json b/tests/fixtures/app/embroider-no-welcome/package.json
index c20cbab42..8e781fea5 100644
--- a/tests/fixtures/app/embroider-no-welcome/package.json
+++ b/tests/fixtures/app/embroider-no-welcome/package.json
@@ -45,6 +45,7 @@
     "ember-data": "~4.10.0-beta.2",
     "ember-fetch": "^8.1.2",
     "ember-load-initializers": "^2.1.2",
+    "ember-modifier": "^4.0.0",
     "ember-page-title": "^7.0.0",
     "ember-qunit": "^6.0.0",
     "ember-resolver": "^8.0.3",
diff --git a/tests/fixtures/app/embroider-yarn/package.json b/tests/fixtures/app/embroider-yarn/package.json
index 93cd34e69..7df0b576f 100644
--- a/tests/fixtures/app/embroider-yarn/package.json
+++ b/tests/fixtures/app/embroider-yarn/package.json
@@ -45,6 +45,7 @@
     "ember-data": "~4.10.0-beta.2",
     "ember-fetch": "^8.1.2",
     "ember-load-initializers": "^2.1.2",
+    "ember-modifier": "^4.0.0",
     "ember-page-title": "^7.0.0",
     "ember-qunit": "^6.0.0",
     "ember-resolver": "^8.0.3",
diff --git a/tests/fixtures/app/embroider/package.json b/tests/fixtures/app/embroider/package.json
index 93cd34e69..7df0b576f 100644
--- a/tests/fixtures/app/embroider/package.json
+++ b/tests/fixtures/app/embroider/package.json
@@ -45,6 +45,7 @@
     "ember-data": "~4.10.0-beta.2",
     "ember-fetch": "^8.1.2",
     "ember-load-initializers": "^2.1.2",
+    "ember-modifier": "^4.0.0",
     "ember-page-title": "^7.0.0",
     "ember-qunit": "^6.0.0",
     "ember-resolver": "^8.0.3",
diff --git a/tests/fixtures/app/npm-travis/package.json b/tests/fixtures/app/npm-travis/package.json
index 92771d9cf..95fdc6360 100644
--- a/tests/fixtures/app/npm-travis/package.json
+++ b/tests/fixtures/app/npm-travis/package.json
@@ -42,6 +42,7 @@
     "ember-data": "~3.27.1",
     "ember-fetch": "^8.0.4",
     "ember-load-initializers": "^2.1.2",
+    "ember-modifier": "^4.0.0",
     "ember-maybe-import-regenerator": "^0.1.6",
     "ember-page-title": "^7.0.0",
     "ember-qunit": "^5.1.4",
diff --git a/tests/fixtures/app/npm/package.json b/tests/fixtures/app/npm/package.json
index 34d987b58..a696a4c3c 100644
--- a/tests/fixtures/app/npm/package.json
+++ b/tests/fixtures/app/npm/package.json
@@ -42,6 +42,7 @@
     "ember-data": "~4.10.0-beta.2",
     "ember-fetch": "^8.1.2",
     "ember-load-initializers": "^2.1.2",
+    "ember-modifier": "^4.0.0",
     "ember-page-title": "^7.0.0",
     "ember-qunit": "^6.0.0",
     "ember-resolver": "^8.0.3",
diff --git a/tests/fixtures/app/with-blueprint-override-lint-fail/package.json b/tests/fixtures/app/with-blueprint-override-lint-fail/package.json
index 6cc607ab4..de24e0c00 100644
--- a/tests/fixtures/app/with-blueprint-override-lint-fail/package.json
+++ b/tests/fixtures/app/with-blueprint-override-lint-fail/package.json
@@ -42,6 +42,7 @@
     "ember-data": "~3.26.0-beta.0",
     "ember-fetch": "^8.0.4",
     "ember-load-initializers": "^2.1.2",
+    "ember-modifier": "^4.0.0",
     "ember-page-title": "^7.0.0",
     "ember-qunit": "^5.1.2",
     "ember-resolver": "^8.0.2",
diff --git a/tests/fixtures/app/yarn-travis/package.json b/tests/fixtures/app/yarn-travis/package.json
index f8b6af620..e6e0dbbc1 100644
--- a/tests/fixtures/app/yarn-travis/package.json
+++ b/tests/fixtures/app/yarn-travis/package.json
@@ -42,6 +42,7 @@
     "ember-data": "~3.27.1",
     "ember-fetch": "^8.0.4",
     "ember-load-initializers": "^2.1.2",
+    "ember-modifier": "^4.0.0",
     "ember-maybe-import-regenerator": "^0.1.6",
     "ember-page-title": "^7.0.0",
     "ember-qunit": "^5.1.4",
diff --git a/tests/fixtures/app/yarn/package.json b/tests/fixtures/app/yarn/package.json
index f9d3955bb..9475f489a 100644
--- a/tests/fixtures/app/yarn/package.json
+++ b/tests/fixtures/app/yarn/package.json
@@ -42,6 +42,7 @@
     "ember-data": "~4.10.0-beta.2",
     "ember-fetch": "^8.1.2",
     "ember-load-initializers": "^2.1.2",
+    "ember-modifier": "^4.0.0",
     "ember-page-title": "^7.0.0",
     "ember-qunit": "^6.0.0",
     "ember-resolver": "^8.0.3",