Repository: kythe/kythe
Pull request #4162 (2019-10-25 22:07:20)

chore: Add sources without required inputs to kzip info count


Patch:
diff --git a/kythe/go/platform/kzip/info/info.go b/kythe/go/platform/kzip/info/info.go
index 1da4de869..cd4020f37 100644
--- a/kythe/go/platform/kzip/info/info.go
+++ b/kythe/go/platform/kzip/info/info.go
@@ -57,14 +57,21 @@ func KzipInfo(f kzip.File, fileSize int64, scanOpts ...kzip.ScanOption) (*apb.Kz
 		cuInfo.Count++
 
 		var srcCorpora stringset.Set
+		srcsWithRI := stringset.New()
 		for _, ri := range u.Proto.RequiredInput {
 			riCorpus := requiredInputCorpus(u, ri)
 			requiredInputInfo(riCorpus, cuLang, kzipInfo).Count++
 			if srcs.Contains(ri.Info.Path) {
 				sourceInfo(riCorpus, cuLang, kzipInfo).Count++
 				srcCorpora.Add(riCorpus)
+				srcsWithRI.Add(ri.Info.Path)
 			}
 		}
+		srcsWithoutRI := srcs.Diff(srcsWithRI)
+		for path := range srcsWithoutRI {
+			msg := fmt.Sprintf("source %q in CU %v doesn't have a required_input entry", path, u.Proto.GetVName())
+			kzipInfo.CriticalKzipErrors = append(kzipInfo.CriticalKzipErrors, msg)
+		}
 		if srcCorpora.Len() != 1 {
 			// This is a warning for now, but may become an error.
 			log.Printf("Multiple corpora in unit. unit vname={%v}; src corpora=%v; srcs=%v", u.Proto.GetVName(), srcCorpora, u.Proto.SourceFile)
@@ -146,6 +153,7 @@ func MergeKzipInfo(infos []*apb.KzipInfo) *apb.KzipInfo {
 				c.Count += sources.GetCount()
 			}
 		}
+		kzipInfo.CriticalKzipErrors = append(kzipInfo.GetCriticalKzipErrors(), i.GetCriticalKzipErrors()...)
 		kzipInfo.Size += i.Size
 	}
 	return kzipInfo
diff --git a/kythe/proto/analysis.proto b/kythe/proto/analysis.proto
index 00868a7a5..e9fc6bc25 100644
--- a/kythe/proto/analysis.proto
+++ b/kythe/proto/analysis.proto
@@ -215,6 +215,10 @@ message KzipInfo {
   map<string, CorpusInfo> corpora = 1;
   // Size in bytes of all the kzips that contributed to this KzipInfo.
   int64 size = 4;
+  // Error messages detected when computing KzipInfo. For example, source files
+  // with no corresponding required_input. If there are any items in this field,
+  // it indicates that this kzip has serious problems and should not be used.
+  repeated string critical_kzip_errors = 5;
 }
 
 // A FilesRequest specifies a collection of files to be fetched from a
diff --git a/kythe/proto/analysis_go_proto/analysis.pb.go b/kythe/proto/analysis_go_proto/analysis.pb.go
index a7c205d2a..fe4a9ee4b 100644
--- a/kythe/proto/analysis_go_proto/analysis.pb.go
+++ b/kythe/proto/analysis_go_proto/analysis.pb.go
@@ -423,6 +423,7 @@ func (m *CompilationUnit_Env) GetValue() string {
 type KzipInfo struct {
 	Corpora              map[string]*KzipInfo_CorpusInfo `protobuf:"bytes,1,rep,name=corpora,proto3" json:"corpora,omitempty" protobuf_key:"bytes,1,opt,name=key,proto3" protobuf_val:"bytes,2,opt,name=value,proto3"`
 	Size                 int64                           `protobuf:"varint,4,opt,name=size,proto3" json:"size,omitempty"`
+	CriticalKzipErrors   []string                        `protobuf:"bytes,5,rep,name=critical_kzip_errors,json=criticalKzipErrors,proto3" json:"critical_kzip_errors,omitempty"`
 	XXX_NoUnkeyedLiteral struct{}                        `json:"-"`
 	XXX_unrecognized     []byte                          `json:"-"`
 	XXX_sizecache        int32                           `json:"-"`
@@ -467,6 +468,13 @@ func (m *KzipInfo) GetSize() int64 {
 	return 0
 }
 
+func (m *KzipInfo) GetCriticalKzipErrors() []string {
+	if m != nil {
+		return m.CriticalKzipErrors
+	}
+	return nil
+}
+
 type KzipInfo_CorpusInfo struct {
 	LanguageCompilationUnits map[string]*KzipInfo_CorpusInfo_CompilationUnits `protobuf:"bytes,3,rep,name=language_compilation_units,json=languageCompilationUnits,proto3" json:"language_compilation_units,omitempty" protobuf_key:"bytes,1,opt,name=key,proto3" protobuf_val:"bytes,2,opt,name=value,proto3"`
 	LanguageRequiredInputs   map[string]*KzipInfo_CorpusInfo_RequiredInputs   `protobuf:"bytes,4,rep,name=language_required_inputs,json=languageRequiredInputs,proto3" json:"language_required_inputs,omitempty" protobuf_key:"bytes,1,opt,name=key,proto3" protobuf_val:"bytes,2,opt,name=value,proto3"`
@@ -901,16 +909,16 @@ func init() {
 func init() { proto.RegisterFile("kythe/proto/analysis.proto", fileDescriptor_8e4ea7eca60afe48) }
 
 var fileDescriptor_8e4ea7eca60afe48 = []byte{
-	// 1101 bytes of a gzipped FileDescriptorProto
+	// 1125 bytes of a gzipped FileDescriptorProto
 	0x1f, 0x8b, 0x08, 0x00, 0x00, 0x00, 0x00, 0x00, 0x02, 0xff, 0xb4, 0x56, 0x5b, 0x6f, 0x1b, 0x45,
 	0x14, 0x66, 0x7d, 0x5d, 0x1f, 0xbb, 0x89, 0x33, 0x84, 0x6a, 0xbb, 0x6d, 0x55, 0xcb, 0xa8, 0x55,
 	0x4b, 0x91, 0x03, 0x06, 0x0a, 0x6a, 0xaa, 0x48, 0xb9, 0x18, 0xe4, 0x34, 0x4d, 0x61, 0xd3, 0xf6,
-	0x01, 0x21, 0x2d, 0x13, 0xef, 0xd8, 0x19, 0x65, 0x3d, 0xe3, 0xee, 0xcc, 0x9a, 0x3a, 0x42, 0x3c,
-	0xf3, 0x0f, 0xf8, 0x01, 0xbc, 0x21, 0x1e, 0x79, 0xe7, 0x6f, 0xf1, 0x88, 0x66, 0x66, 0xd7, 0xde,
+	0x01, 0x21, 0x2d, 0x13, 0xef, 0xd8, 0x19, 0x65, 0x3d, 0xe3, 0xee, 0xcc, 0x9a, 0x3a, 0x42, 0xfc,
+	0x0d, 0x7e, 0x00, 0x6f, 0x88, 0x47, 0x9e, 0x78, 0xe1, 0x6f, 0xf1, 0x88, 0x66, 0x66, 0xd7, 0xde,
 	0x4d, 0x73, 0x2b, 0x12, 0x4f, 0x3b, 0xe7, 0xfa, 0x9d, 0x39, 0xb7, 0x1d, 0x70, 0x8f, 0x67, 0xf2,
 	0x88, 0xac, 0x4d, 0x22, 0x2e, 0xf9, 0x1a, 0x66, 0x38, 0x9c, 0x09, 0x2a, 0x3a, 0x9a, 0x44, 0x75,
 	0x2d, 0x33, 0x84, 0x7b, 0x63, 0xc4, 0xf9, 0x28, 0x4c, 0x34, 0x0f, 0xe3, 0xe1, 0x1a, 0x66, 0xb3,
-	0x54, 0x94, 0xf5, 0x21, 0x24, 0x8f, 0xf0, 0x28, 0xb1, 0x6a, 0xff, 0x65, 0xc1, 0xf2, 0x66, 0xe2,
+	0x54, 0x94, 0xf5, 0x21, 0x24, 0x8f, 0xf0, 0x28, 0xb1, 0x6a, 0xff, 0x69, 0xc1, 0xf2, 0x66, 0xe2,
 	0xd5, 0x23, 0xaf, 0x63, 0x22, 0x24, 0xda, 0x80, 0xfa, 0x80, 0x8f, 0x27, 0x34, 0xc4, 0x92, 0x72,
 	0xe6, 0x58, 0x2d, 0xeb, 0x7e, 0xbd, 0x7b, 0xab, 0x93, 0x01, 0xeb, 0x6c, 0x2f, 0xe4, 0x2f, 0x19,
 	0x95, 0x5e, 0xd6, 0x00, 0x7d, 0x04, 0x2b, 0x43, 0x1a, 0x12, 0x3f, 0xc0, 0x12, 0xfb, 0x82, 0x44,
@@ -919,13 +927,13 @@ var fileDescriptor_8e4ea7eca60afe48 = []byte{
 	0x61, 0x4c, 0xc3, 0xc0, 0xa7, 0x81, 0x53, 0xd2, 0xb2, 0xaa, 0xa6, 0xfb, 0x41, 0x7b, 0x08, 0x4b,
 	0x69, 0xd4, 0xcf, 0x63, 0x39, 0x89, 0x25, 0x5a, 0x85, 0xf2, 0x14, 0x87, 0x31, 0xd1, 0xe1, 0x36,
 	0x3c, 0x43, 0xa0, 0x0d, 0x68, 0x0c, 0x29, 0xc3, 0xa1, 0x1f, 0x11, 0x11, 0x87, 0xd2, 0x01, 0x7d,
-	0x97, 0x9b, 0xb9, 0xbb, 0x2c, 0xae, 0xaf, 0x54, 0xbc, 0xba, 0x36, 0x30, 0x44, 0xfb, 0x77, 0x6b,
+	0x97, 0x9b, 0xb9, 0xbb, 0x2c, 0xae, 0xaf, 0x54, 0xbc, 0xba, 0x36, 0x30, 0x44, 0xfb, 0x37, 0x6b,
 	0x01, 0x64, 0x58, 0xe8, 0x31, 0x54, 0x84, 0xc4, 0x32, 0x16, 0x1a, 0x69, 0xa9, 0xdb, 0xbe, 0xc0,
 	0x59, 0xe7, 0x40, 0x6b, 0x7a, 0x89, 0x05, 0x72, 0xa0, 0x2a, 0xe2, 0xf1, 0x18, 0x47, 0xb3, 0x24,
 	0x1f, 0x29, 0xd9, 0x5e, 0x87, 0x8a, 0xd1, 0x45, 0x0d, 0xb0, 0xb7, 0x9f, 0x3f, 0xfb, 0x76, 0xaf,
 	0xf7, 0xa2, 0xd7, 0x7c, 0x0f, 0x2d, 0x01, 0xf4, 0xf7, 0xe7, 0xb4, 0x85, 0xde, 0x87, 0xe5, 0xfe,
 	0xfe, 0xab, 0xcd, 0xbd, 0xfe, 0x8e, 0xef, 0xf5, 0xbe, 0x7b, 0xd9, 0x3b, 0x78, 0xd1, 0x2c, 0xb4,
-	0xff, 0x2c, 0xc3, 0xf2, 0xa9, 0x8a, 0xa0, 0x07, 0x50, 0x99, 0xfa, 0x0c, 0x8f, 0x49, 0x52, 0x3f,
+	0xff, 0x28, 0xc3, 0xf2, 0xa9, 0x8a, 0xa0, 0x07, 0x50, 0x99, 0xfa, 0x0c, 0x8f, 0x49, 0x52, 0x3f,
 	0x94, 0x0b, 0xf3, 0xd5, 0x3e, 0x1e, 0x13, 0xaf, 0x3c, 0x55, 0x1f, 0xf4, 0x0c, 0x96, 0x22, 0xf2,
 	0x3a, 0xa6, 0x11, 0x09, 0x7c, 0xca, 0x26, 0xb1, 0x74, 0x8a, 0xad, 0xe2, 0xfd, 0x7a, 0xf7, 0xde,
 	0x45, 0x25, 0xef, 0x7c, 0x4d, 0x43, 0xd2, 0x57, 0xda, 0xde, 0xb5, 0xd4, 0x5a, 0x93, 0xe8, 0x63,
@@ -939,36 +947,38 @@ var fileDescriptor_8e4ea7eca60afe48 = []byte{
 	0x62, 0x43, 0x33, 0xb7, 0x0d, 0x0f, 0x6d, 0x41, 0x9d, 0xb0, 0x29, 0x8d, 0x38, 0xd3, 0x01, 0x83,
 	0xce, 0x53, 0xeb, 0xc2, 0x3c, 0xf5, 0xd8, 0xd4, 0xcb, 0x1a, 0xa1, 0x0e, 0x54, 0x03, 0x22, 0x31,
 	0x0d, 0x85, 0x53, 0xd7, 0xf6, 0xab, 0x1d, 0x33, 0xba, 0x9d, 0x74, 0x74, 0x3b, 0x9b, 0x6c, 0xe6,
-	0xa5, 0x4a, 0xee, 0x6f, 0x16, 0xd4, 0xe6, 0xc9, 0x7e, 0x97, 0xba, 0x3e, 0x80, 0x12, 0x65, 0x43,
+	0xa5, 0x4a, 0xee, 0xaf, 0x16, 0xd4, 0xe6, 0xc9, 0x7e, 0x97, 0xba, 0x3e, 0x80, 0x12, 0x65, 0x43,
 	0xae, 0x5b, 0xad, 0xde, 0xfd, 0x20, 0xa7, 0x68, 0x1c, 0x0e, 0xb9, 0xa7, 0x55, 0xb2, 0x31, 0x95,
 	0xae, 0x10, 0xd3, 0x6e, 0xc9, 0x2e, 0x36, 0x4b, 0xee, 0x1a, 0x14, 0x7b, 0x6c, 0x8a, 0x10, 0x94,
 	0xe6, 0x01, 0xd5, 0x3c, 0x7d, 0x5e, 0x8c, 0xa3, 0xe9, 0x73, 0x43, 0xec, 0x96, 0xec, 0x42, 0xb3,
-	0xd8, 0xfe, 0xd5, 0x06, 0xfb, 0xe9, 0x09, 0x9d, 0x28, 0x7c, 0xf4, 0x04, 0xaa, 0x03, 0x1e, 0x4d,
+	0xd8, 0xfe, 0xcb, 0x06, 0xfb, 0xe9, 0x09, 0x9d, 0x28, 0x7c, 0xf4, 0x04, 0xaa, 0x03, 0x1e, 0x4d,
 	0x78, 0x84, 0x1d, 0x4b, 0x23, 0xe7, 0xe7, 0x29, 0xd5, 0xeb, 0x6c, 0x1b, 0xa5, 0x9e, 0xaa, 0x86,
-	0x97, 0x9a, 0x28, 0x68, 0x41, 0x4f, 0x88, 0xee, 0xae, 0xa2, 0xa7, 0xcf, 0xee, 0xdf, 0x15, 0x00,
-	0xa5, 0x1d, 0x0b, 0x0d, 0xf0, 0x33, 0xb8, 0x21, 0x66, 0xa3, 0x18, 0x8f, 0x88, 0x9f, 0xd9, 0x52,
-	0x7e, 0xcc, 0xa8, 0x14, 0x49, 0xa7, 0x6f, 0x9c, 0x8f, 0x69, 0xbc, 0x74, 0xf6, 0x12, 0x17, 0xa7,
-	0xaa, 0x2b, 0x4c, 0x3c, 0x4e, 0x78, 0x8e, 0x18, 0x4d, 0x61, 0x2e, 0xf3, 0xf3, 0x43, 0x96, 0x66,
-	0xfa, 0xc9, 0x95, 0xb1, 0xbd, 0xec, 0x98, 0x25, 0xc8, 0xd7, 0xc3, 0x33, 0x85, 0xe8, 0x47, 0x68,
-	0xce, 0x71, 0xcd, 0xc0, 0x08, 0x3d, 0x5e, 0xf5, 0xee, 0x17, 0x57, 0xc6, 0x3b, 0x30, 0x76, 0x06,
-	0x68, 0x39, 0xcc, 0x73, 0xdd, 0xcf, 0xa1, 0xf9, 0xd6, 0x6d, 0x57, 0xa1, 0x3c, 0xe0, 0x31, 0x93,
-	0xba, 0x15, 0xca, 0x9e, 0x21, 0x4c, 0xd5, 0x93, 0x96, 0xf9, 0x05, 0x6e, 0x5f, 0x98, 0x4a, 0xd4,
-	0x84, 0xa2, 0x9a, 0x65, 0xd3, 0x4b, 0xea, 0x88, 0xbe, 0xc9, 0xb6, 0x52, 0xbd, 0xfb, 0xe9, 0xa5,
-	0xf1, 0x9f, 0x76, 0x9c, 0x74, 0xdf, 0xe3, 0xc2, 0x57, 0x96, 0x7b, 0x0f, 0x96, 0x4e, 0x65, 0xea,
-	0xcc, 0x98, 0xdd, 0x13, 0xb8, 0x79, 0x41, 0xda, 0xcf, 0x88, 0xb2, 0x97, 0x8f, 0x72, 0xed, 0xd2,
-	0x28, 0xf3, 0x6e, 0xb3, 0x31, 0x0a, 0x58, 0x3d, 0xab, 0x04, 0xff, 0x2b, 0xe8, 0x6e, 0xc9, 0xb6,
-	0x9a, 0x05, 0x53, 0x2a, 0xf7, 0x07, 0x68, 0x64, 0xc7, 0xed, 0x0c, 0xe0, 0x47, 0x79, 0xe0, 0xd6,
-	0x65, 0xc0, 0x79, 0xa4, 0x79, 0x3b, 0xb4, 0xd7, 0xa1, 0xa1, 0x36, 0xd1, 0xfc, 0xe9, 0xf1, 0x10,
-	0xca, 0x6a, 0xd5, 0x8b, 0x64, 0x17, 0x9c, 0xb3, 0xb3, 0x8c, 0x4e, 0xfb, 0x11, 0xd8, 0x29, 0x4b,
-	0x2d, 0x82, 0x09, 0x96, 0x47, 0xe9, 0x0e, 0x52, 0x67, 0x74, 0x1d, 0x2a, 0x01, 0x1d, 0x11, 0x21,
-	0x93, 0x25, 0x94, 0x50, 0x6d, 0x6a, 0xec, 0xd4, 0x33, 0x44, 0xfd, 0x91, 0xf5, 0xbe, 0x4f, 0xea,
-	0xdf, 0xf0, 0x52, 0xf2, 0x5d, 0xb6, 0xa7, 0x03, 0xd5, 0x31, 0x15, 0x82, 0xb2, 0x91, 0x7e, 0xc3,
-	0xd8, 0x5e, 0x4a, 0xb6, 0x23, 0x58, 0xc9, 0x74, 0xe3, 0x56, 0xcc, 0x82, 0x90, 0xa0, 0x4f, 0xa0,
-	0xa4, 0x96, 0xcf, 0x95, 0x1e, 0x56, 0x5a, 0x73, 0x91, 0x96, 0xc2, 0x39, 0x69, 0x51, 0x77, 0x49,
-	0xd3, 0xf2, 0x87, 0x05, 0xa8, 0xcf, 0x02, 0xf2, 0x86, 0x04, 0x19, 0x6f, 0xff, 0x01, 0x75, 0x1d,
-	0xca, 0x54, 0xf9, 0x49, 0x52, 0x70, 0x37, 0x67, 0xf2, 0x36, 0x82, 0x61, 0x79, 0xc6, 0xc6, 0xbd,
-	0x0b, 0x65, 0x4d, 0xa3, 0x5b, 0x50, 0x4b, 0x5f, 0x74, 0xa6, 0xac, 0x35, 0x6f, 0xc1, 0xd8, 0xfa,
-	0x12, 0xee, 0x0c, 0xf8, 0x38, 0xfd, 0xd9, 0x04, 0x64, 0x2a, 0x39, 0x0f, 0x45, 0x16, 0xe9, 0xfb,
-	0x95, 0xf4, 0xd5, 0xeb, 0x8f, 0xb8, 0xaf, 0x59, 0xff, 0x58, 0xd6, 0x61, 0x45, 0x9f, 0x3e, 0xfb,
-	0x37, 0x00, 0x00, 0xff, 0xff, 0x6f, 0x60, 0xfd, 0x00, 0x20, 0x0b, 0x00, 0x00,
+	0x97, 0x9a, 0x28, 0x68, 0x41, 0x4f, 0x88, 0xee, 0xae, 0xa2, 0xa7, 0xcf, 0xe8, 0x13, 0x58, 0x1d,
+	0x44, 0x54, 0xd2, 0x01, 0x0e, 0xfd, 0xe3, 0x13, 0x3a, 0x49, 0x3b, 0xd0, 0x74, 0x17, 0x4a, 0x65,
+	0xca, 0xb3, 0xe9, 0x41, 0xf7, 0xef, 0x0a, 0x80, 0xf2, 0x1f, 0x0b, 0x1d, 0xd2, 0xcf, 0xe0, 0x86,
+	0x98, 0x8d, 0x62, 0x3c, 0x22, 0x7e, 0x66, 0xaf, 0xf9, 0x31, 0xa3, 0x52, 0x24, 0xb3, 0xb1, 0x71,
+	0x7e, 0x94, 0xc6, 0x4b, 0x67, 0x2f, 0x71, 0x71, 0xaa, 0x1f, 0x84, 0xb9, 0x81, 0x13, 0x9e, 0x23,
+	0x46, 0x53, 0x98, 0xcb, 0xfc, 0xfc, 0x58, 0xa6, 0xb5, 0x79, 0x72, 0x65, 0x6c, 0x2f, 0x3b, 0x98,
+	0x09, 0xf2, 0xf5, 0xf0, 0x4c, 0x21, 0xfa, 0x11, 0x9a, 0x73, 0x5c, 0x33, 0x62, 0x26, 0x65, 0xf5,
+	0xee, 0x17, 0x57, 0xc6, 0x3b, 0x30, 0x76, 0x06, 0x68, 0x39, 0xcc, 0x73, 0xdd, 0xcf, 0xa1, 0xf9,
+	0xd6, 0x6d, 0x57, 0xa1, 0x3c, 0xe0, 0x31, 0x93, 0xba, 0x79, 0xca, 0x9e, 0x21, 0x4c, 0x9f, 0x24,
+	0x4d, 0xf6, 0x0b, 0xdc, 0xbe, 0x30, 0x95, 0xa8, 0x09, 0x45, 0x35, 0xfd, 0xa6, 0xfb, 0xd4, 0x11,
+	0x7d, 0x93, 0x6d, 0xbe, 0x7a, 0xf7, 0xd3, 0x4b, 0xe3, 0x3f, 0xed, 0x38, 0xe9, 0xd7, 0xc7, 0x85,
+	0xaf, 0x2c, 0xf7, 0x1e, 0x2c, 0x9d, 0xca, 0xd4, 0x99, 0x31, 0xbb, 0x27, 0x70, 0xf3, 0x82, 0xb4,
+	0x9f, 0x11, 0x65, 0x2f, 0x1f, 0xe5, 0xda, 0xa5, 0x51, 0xe6, 0xdd, 0x66, 0x63, 0x14, 0xb0, 0x7a,
+	0x56, 0x09, 0xfe, 0x57, 0xd0, 0xdd, 0x92, 0x6d, 0x35, 0x0b, 0xa6, 0x54, 0xee, 0x0f, 0xd0, 0xc8,
+	0x0e, 0xe8, 0x19, 0xc0, 0x8f, 0xf2, 0xc0, 0xad, 0xcb, 0x80, 0xf3, 0x48, 0xf3, 0x76, 0x68, 0xaf,
+	0x43, 0x43, 0xed, 0xae, 0xf9, 0x63, 0xe5, 0x21, 0x94, 0xd5, 0xcf, 0x41, 0x24, 0xdb, 0xe3, 0x9c,
+	0x2d, 0x67, 0x74, 0xda, 0x8f, 0xc0, 0x4e, 0x59, 0x6a, 0x75, 0x4c, 0xb0, 0x3c, 0x4a, 0xb7, 0x96,
+	0x3a, 0xa3, 0xeb, 0x50, 0x09, 0xe8, 0x88, 0x08, 0x99, 0xac, 0xad, 0x84, 0x6a, 0x53, 0x63, 0xa7,
+	0x1e, 0x2e, 0xea, 0x1f, 0xae, 0xff, 0x10, 0x49, 0xfd, 0x1b, 0x5e, 0x4a, 0xbe, 0xcb, 0xbe, 0x75,
+	0xa0, 0x3a, 0xa6, 0x42, 0x50, 0x36, 0xd2, 0xaf, 0x1e, 0xdb, 0x4b, 0xc9, 0x76, 0x04, 0x2b, 0x99,
+	0x6e, 0xdc, 0x8a, 0x59, 0x10, 0xaa, 0x95, 0x56, 0x52, 0xcb, 0xe7, 0x4a, 0x4f, 0x31, 0xad, 0xb9,
+	0x48, 0x4b, 0xe1, 0x9c, 0xb4, 0xa8, 0xbb, 0xa4, 0x69, 0xf9, 0xdd, 0x02, 0xd4, 0x67, 0x01, 0x79,
+	0x43, 0x82, 0x8c, 0xb7, 0xff, 0x80, 0xba, 0x0e, 0x65, 0xaa, 0xfc, 0x24, 0x29, 0xb8, 0x9b, 0x33,
+	0x79, 0x1b, 0xc1, 0xb0, 0x3c, 0x63, 0xe3, 0xde, 0x85, 0xb2, 0xa6, 0xd1, 0x2d, 0xa8, 0xa5, 0x6f,
+	0x40, 0x53, 0xd6, 0x9a, 0xb7, 0x60, 0x6c, 0x7d, 0x09, 0x77, 0x06, 0x7c, 0x9c, 0xfe, 0x9e, 0x02,
+	0x32, 0x95, 0x9c, 0x87, 0x22, 0x8b, 0xf4, 0xfd, 0x4a, 0xfa, 0x4e, 0xf6, 0x47, 0xdc, 0xd7, 0xac,
+	0x7f, 0x2c, 0xeb, 0xb0, 0xa2, 0x4f, 0x9f, 0xfd, 0x1b, 0x00, 0x00, 0xff, 0xff, 0xa5, 0x23, 0x92,
+	0xc1, 0x52, 0x0b, 0x00, 0x00,
 }


Test patch:
diff --git a/kythe/go/platform/kzip/info/info_test.go b/kythe/go/platform/kzip/info/info_test.go
index b789b0398..8690f0579 100644
--- a/kythe/go/platform/kzip/info/info_test.go
+++ b/kythe/go/platform/kzip/info/info_test.go
@@ -46,7 +46,8 @@ func TestMergeKzipInfo(t *testing.T) {
 					},
 				},
 			},
-			Size: 10,
+			CriticalKzipErrors: []string{"foo.py doesn't have a required_input"},
+			Size:               10,
 		},
 		{
 			Corpora: map[string]*apb.KzipInfo_CorpusInfo{
@@ -97,7 +98,8 @@ func TestMergeKzipInfo(t *testing.T) {
 					},
 				},
 			},
-			Size: 30,
+			CriticalKzipErrors: []string{"foo2.py doesn't have a required_input"},
+			Size:               30,
 		},
 	}
 
@@ -155,7 +157,8 @@ func TestMergeKzipInfo(t *testing.T) {
 				},
 			},
 		},
-		Size: 40,
+		CriticalKzipErrors: []string{"foo.py doesn't have a required_input", "foo2.py doesn't have a required_input"},
+		Size:               40,
 	}
 	wantTotal := apb.KzipInfo_CorpusInfo{
 		LanguageCompilationUnits: map[string]*apb.KzipInfo_CorpusInfo_CompilationUnits{