Repository: kopia/kopia
Pull request #3245 (2023-08-23 01:42:02)

chore(ci): reenable check-locks after the fix was merged upstream
https://github.com/google/gvisor/pull/8807

codecov[bot]: ## [Codecov](https://app.codecov.io/gh/kopia/kopia/pull/3245?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kopia) Report
Patch coverage has no change and project coverage change: **`+0.02%`** :tada:
> Comparison is base [(`42c251f`)](https://app.codecov.io/gh/kopia/kopia/commit/42c251f4da3d8cfae092f3354107ac14bb3bd48f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kopia) 75.45% compared to head [(`4e20bb0`)](https://app.codecov.io/gh/kopia/kopia/pull/3245?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kopia) 75.47%.

<details><summary>Additional details and impacted files</summary>


```diff
@@            Coverage Diff             @@
##           master    #3245      +/-   ##
==========================================
+ Coverage   75.45%   75.47%   +0.02%     
==========================================
  Files         459      459              
  Lines       36549    36549              
==========================================
+ Hits        27577    27586       +9     
+ Misses       7052     7047       -5     
+ Partials     1920     1916       -4     
```


| [Files Changed](https://app.codecov.io/gh/kopia/kopia/pull/3245?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kopia) | Coverage Δ | |
|---|---|---|
| [internal/cache/persistent\_lru\_cache.go](https://app.codecov.io/gh/kopia/kopia/pull/3245?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kopia#diff-aW50ZXJuYWwvY2FjaGUvcGVyc2lzdGVudF9scnVfY2FjaGUuZ28=) | `91.56% <ø> (ø)` | |

... and [10 files with indirect coverage changes](https://app.codecov.io/gh/kopia/kopia/pull/3245/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kopia)


</details>

[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/kopia/kopia/pull/3245?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kopia).   
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kopia).


Patch:
diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
index 5f014e43..211693e7 100644
--- a/.github/workflows/lint.yml
+++ b/.github/workflows/lint.yml
@@ -37,3 +37,5 @@ jobs:
       if: ${{ !contains(matrix.os, 'ARMHF') }}
     - name: Lint
       run: make lint
+    - name: Check Locks
+      run: make check-locks
diff --git a/internal/cache/persistent_lru_cache.go b/internal/cache/persistent_lru_cache.go
index c56b2261..4148264f 100644
--- a/internal/cache/persistent_lru_cache.go
+++ b/internal/cache/persistent_lru_cache.go
@@ -37,7 +37,9 @@ type PersistentCache struct {
 	storageProtection cacheprot.StorageProtection
 	sweep             SweepSettings
 	timeNow           func() time.Time
-	lastCacheWarning  time.Time
+
+	// +checklocks:listCacheMutex
+	lastCacheWarning time.Time
 
 	description string
 
diff --git a/tools/tools.mk b/tools/tools.mk
index c2eb8507..e9647666 100644
--- a/tools/tools.mk
+++ b/tools/tools.mk
@@ -103,7 +103,7 @@ endif
 
 # tool versions
 GOLANGCI_LINT_VERSION=1.54.0
-CHECKLOCKS_VERSION=release-20221026.0
+CHECKLOCKS_VERSION=e8c1fff214d0ecf02cfe5aa9c62d11174130c339
 NODE_VERSION=18.16.0
 HUGO_VERSION=0.113.0
 GOTESTSUM_VERSION=1.10.0


Test patch:
diff --git a/internal/blobtesting/object_locking_map.go b/internal/blobtesting/object_locking_map.go
index eb71b74e..6fbb20c3 100644
--- a/internal/blobtesting/object_locking_map.go
+++ b/internal/blobtesting/object_locking_map.go
@@ -14,7 +14,7 @@
 	"github.com/kopia/kopia/repo/blob"
 )
 
-var ErrBlobLocked = errors.New("cannot alter object before retention period expires")
+var ErrBlobLocked = errors.New("cannot alter object before retention period expires") // +checklocksignore
 
 type entry struct {
 	value          []byte