Repository: ember-cli/ember-cli
Pull request #9012 (2020-01-14 21:58:40)

Drop support for Node v8
In line with the Node support policy this drops support for Node v8
which reached end of life on December 31st 2019.  Also updated
blueprints to match.

jrjohnson: I'm assuming that the appveyor test timeout isn't related to this PR, but if I'm wrong about that let me know.

Patch:
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 98ffde610..8401bf288 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -48,7 +48,7 @@ jobs:
 
     strategy:
       matrix:
-        node-version: [8.x, 10.x, 12.x]
+        node-version: [10.x, 12.x]
 
     steps:
       - uses: actions/checkout@v1
diff --git a/.travis.yml b/.travis.yml
index 079a2bd5a..02170bd89 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -37,10 +37,7 @@ jobs:
         - yarn test
 
     - stage: additional tests
-      name: Node.js 8
-      node_js: 8
-
-    - name: Node.js 10
+      name: Node.js 10
       node_js: 10
 
     - name: Node.js 12
diff --git a/appveyor.yml b/appveyor.yml
index a30c3b0c1..391275b37 100644
--- a/appveyor.yml
+++ b/appveyor.yml
@@ -6,7 +6,6 @@ image: Visual Studio 2017
 environment:
   MOCHA_REPORTER: "mocha-appveyor-reporter"
   matrix:
-    - nodejs_version: "8"
     - nodejs_version: "10"
     - nodejs_version: "12"
     - nodejs_version: "13"
diff --git a/blueprints/addon/files/.travis.yml b/blueprints/addon/files/.travis.yml
index f16c639c3..73292278d 100644
--- a/blueprints/addon/files/.travis.yml
+++ b/blueprints/addon/files/.travis.yml
@@ -3,7 +3,7 @@ language: node_js
 node_js:
   # we recommend testing addons with the same minimum supported node version as Ember CLI
   # so that your addon works for all apps
-  - "8"
+  - "10"
 
 dist: trusty
 
diff --git a/blueprints/addon/files/README.md b/blueprints/addon/files/README.md
index 44d6428a6..881e5e70e 100644
--- a/blueprints/addon/files/README.md
+++ b/blueprints/addon/files/README.md
@@ -9,7 +9,7 @@ Compatibility
 
 * Ember.js v3.12 or above
 * Ember CLI v2.13 or above
-* Node.js v8 or above
+* Node.js v10 or above
 
 
 Installation
diff --git a/blueprints/app/files/.travis.yml b/blueprints/app/files/.travis.yml
index cd094a356..2079213f4 100644
--- a/blueprints/app/files/.travis.yml
+++ b/blueprints/app/files/.travis.yml
@@ -1,7 +1,7 @@
 ---
 language: node_js
 node_js:
-  - "8"
+  - "10"
 
 dist: trusty
 
diff --git a/blueprints/app/files/package.json b/blueprints/app/files/package.json
index 21c0a53b0..9021fa1c9 100644
--- a/blueprints/app/files/package.json
+++ b/blueprints/app/files/package.json
@@ -48,7 +48,7 @@
     "qunit-dom": "^0.9.2"
   },
   "engines": {
-    "node": "8.* || 10.* || >= 12"
+    "node": "10.* || >= 12"
   },
   "ember": {
     "edition": "octane"
diff --git a/docs/node-support.md b/docs/node-support.md
index 50313a888..0edfb68a2 100644
--- a/docs/node-support.md
+++ b/docs/node-support.md
@@ -10,7 +10,7 @@
 | 5.x              | 1.13.9 - 2.6.3               |
 | 6.x              | 2.9.0 - 3.9.x                |
 | 7.x              | 2.10.0 - 2.16.x              |
-| 8.x              | 2.13.3 - Current             |
+| 8.x              | 2.13.3 - 3.16.x             |
 | 9.x              | 2.16.2 - 3.2.x               |
 | 10.x             | 3.1.3 - Current              |
 | 11.x             | 3.9.0 - 3.13.0               |
diff --git a/package.json b/package.json
index 949dacaf1..ae40cacf0 100644
--- a/package.json
+++ b/package.json
@@ -161,7 +161,7 @@
     "yuidocjs": "0.10.2"
   },
   "engines": {
-    "node": "8.* || 10.* || >= 12"
+    "node": "10.* || >= 12"
   },
   "trackingCode": "UA-49225444-1",
   "greenkeeper": {


Test patch:
diff --git a/tests/fixtures/addon/npm/.travis.yml b/tests/fixtures/addon/npm/.travis.yml
index 3b5464379..b1b71a965 100644
--- a/tests/fixtures/addon/npm/.travis.yml
+++ b/tests/fixtures/addon/npm/.travis.yml
@@ -3,7 +3,7 @@ language: node_js
 node_js:
   # we recommend testing addons with the same minimum supported node version as Ember CLI
   # so that your addon works for all apps
-  - "8"
+  - "10"
 
 dist: trusty
 
diff --git a/tests/fixtures/addon/npm/README.md b/tests/fixtures/addon/npm/README.md
index cf2820ead..955cce6cf 100644
--- a/tests/fixtures/addon/npm/README.md
+++ b/tests/fixtures/addon/npm/README.md
@@ -9,7 +9,7 @@ Compatibility
 
 * Ember.js v3.12 or above
 * Ember CLI v2.13 or above
-* Node.js v8 or above
+* Node.js v10 or above
 
 
 Installation
diff --git a/tests/fixtures/addon/npm/package.json b/tests/fixtures/addon/npm/package.json
index 943d0544c..3fce47580 100644
--- a/tests/fixtures/addon/npm/package.json
+++ b/tests/fixtures/addon/npm/package.json
@@ -52,7 +52,7 @@
     "qunit-dom": "^0.9.2"
   },
   "engines": {
-    "node": "8.* || 10.* || >= 12"
+    "node": "10.* || >= 12"
   },
   "ember": {
     "edition": "octane"
diff --git a/tests/fixtures/addon/yarn/.travis.yml b/tests/fixtures/addon/yarn/.travis.yml
index af96b6307..f5df21049 100644
--- a/tests/fixtures/addon/yarn/.travis.yml
+++ b/tests/fixtures/addon/yarn/.travis.yml
@@ -3,7 +3,7 @@ language: node_js
 node_js:
   # we recommend testing addons with the same minimum supported node version as Ember CLI
   # so that your addon works for all apps
-  - "8"
+  - "10"
 
 dist: trusty
 
diff --git a/tests/fixtures/addon/yarn/README.md b/tests/fixtures/addon/yarn/README.md
index cf2820ead..955cce6cf 100644
--- a/tests/fixtures/addon/yarn/README.md
+++ b/tests/fixtures/addon/yarn/README.md
@@ -9,7 +9,7 @@ Compatibility
 
 * Ember.js v3.12 or above
 * Ember CLI v2.13 or above
-* Node.js v8 or above
+* Node.js v10 or above
 
 
 Installation
diff --git a/tests/fixtures/addon/yarn/package.json b/tests/fixtures/addon/yarn/package.json
index 07e7bd213..17fb9ce1a 100644
--- a/tests/fixtures/addon/yarn/package.json
+++ b/tests/fixtures/addon/yarn/package.json
@@ -53,7 +53,7 @@
     "qunit-dom": "^0.9.2"
   },
   "engines": {
-    "node": "8.* || 10.* || >= 12"
+    "node": "10.* || >= 12"
   },
   "ember": {
     "edition": "octane"
diff --git a/tests/fixtures/app/npm/.travis.yml b/tests/fixtures/app/npm/.travis.yml
index 8339c408e..a0208ca37 100644
--- a/tests/fixtures/app/npm/.travis.yml
+++ b/tests/fixtures/app/npm/.travis.yml
@@ -1,7 +1,7 @@
 ---
 language: node_js
 node_js:
-  - "8"
+  - "10"
 
 dist: trusty
 
diff --git a/tests/fixtures/app/npm/package.json b/tests/fixtures/app/npm/package.json
index 3edb2e1d1..52cdfc25b 100644
--- a/tests/fixtures/app/npm/package.json
+++ b/tests/fixtures/app/npm/package.json
@@ -47,7 +47,7 @@
     "qunit-dom": "^0.9.2"
   },
   "engines": {
-    "node": "8.* || 10.* || >= 12"
+    "node": "10.* || >= 12"
   },
   "ember": {
     "edition": "octane"
diff --git a/tests/fixtures/app/yarn/.travis.yml b/tests/fixtures/app/yarn/.travis.yml
index b05f2ddba..b1f2a2c3b 100644
--- a/tests/fixtures/app/yarn/.travis.yml
+++ b/tests/fixtures/app/yarn/.travis.yml
@@ -1,7 +1,7 @@
 ---
 language: node_js
 node_js:
-  - "8"
+  - "10"
 
 dist: trusty
 
diff --git a/tests/fixtures/app/yarn/package.json b/tests/fixtures/app/yarn/package.json
index 9bbe31735..2093bcf4e 100644
--- a/tests/fixtures/app/yarn/package.json
+++ b/tests/fixtures/app/yarn/package.json
@@ -48,7 +48,7 @@
     "qunit-dom": "^0.9.2"
   },
   "engines": {
-    "node": "8.* || 10.* || >= 12"
+    "node": "10.* || >= 12"
   },
   "ember": {
     "edition": "octane"