Repository: helm/helm
Pull request #13444 (2024-11-14 22:25:46)

fix(status): remove --show-desc and --show-resources flags
<!--  Thanks for sending a pull request!  Here are some tips for you:
1. Make sure to read the Contributing Guide before submitting your PR: https://github.com/helm/helm/blob/main/CONTRIBUTING.md
2. If this PR closes another issue, add 'closes #<issue number>' somewhere in the PR summary. GitHub will automatically close that issue when this PR gets merged. Alternatively, adding 'refs #<issue number>' will not close the issue, but help provide the reviewer more context.-->

**What this PR does / why we need it**:

Resolves two `TODO Helm 4` items.

**Special notes for your reviewer**:

**If applicable**:
- [x] this PR contains user facing changes (the `docs needed` label should be applied if so)
- [ ] this PR contains unit tests
- [ ] this PR has been tested for backwards compatibility



Patch:
diff --git a/cmd/helm/get_all.go b/cmd/helm/get_all.go
index f7af68213..12f1c2540 100644
--- a/cmd/helm/get_all.go
+++ b/cmd/helm/get_all.go
@@ -58,7 +58,12 @@ func newGetAllCmd(cfg *action.Configuration, out io.Writer) *cobra.Command {
 				}
 				return tpl(template, data, out)
 			}
-			return output.Table.Write(out, &statusPrinter{res, true, false, false, true, false})
+			return output.Table.Write(out, &statusPrinter{
+				release:      res,
+				debug:        true,
+				showMetadata: true,
+				hideNotes:    false,
+			})
 		},
 	}
 
@@ -70,7 +75,6 @@ func newGetAllCmd(cfg *action.Configuration, out io.Writer) *cobra.Command {
 		}
 		return nil, cobra.ShellCompDirectiveNoFileComp
 	})
-
 	if err != nil {
 		log.Fatal(err)
 	}
diff --git a/cmd/helm/install.go b/cmd/helm/install.go
index 23ff29d95..f74d74a3a 100644
--- a/cmd/helm/install.go
+++ b/cmd/helm/install.go
@@ -158,7 +158,12 @@ func newInstallCmd(cfg *action.Configuration, out io.Writer) *cobra.Command {
 				return errors.Wrap(err, "INSTALLATION FAILED")
 			}
 
-			return outfmt.Write(out, &statusPrinter{rel, settings.Debug, false, false, false, client.HideNotes})
+			return outfmt.Write(out, &statusPrinter{
+				release:      rel,
+				debug:        settings.Debug,
+				showMetadata: false,
+				hideNotes:    client.HideNotes,
+			})
 		},
 	}
 
@@ -214,7 +219,6 @@ func addInstallFlags(cmd *cobra.Command, f *pflag.FlagSet, client *action.Instal
 		}
 		return compVersionFlag(args[requiredArgs-1], toComplete)
 	})
-
 	if err != nil {
 		log.Fatal(err)
 	}
diff --git a/cmd/helm/status.go b/cmd/helm/status.go
index 725b3f367..2bee5db44 100644
--- a/cmd/helm/status.go
+++ b/cmd/helm/status.go
@@ -43,8 +43,8 @@ The status consists of:
 - k8s namespace in which the release lives
 - state of the release (can be: unknown, deployed, uninstalled, superseded, failed, uninstalling, pending-install, pending-upgrade or pending-rollback)
 - revision of the release
-- description of the release (can be completion message or error message, need to enable --show-desc)
-- list of resources that this release consists of (need to enable --show-resources)
+- description of the release (can be completion message or error message)
+- list of resources that this release consists of
 - details on last test suite run, if applicable
 - additional notes provided by the chart
 `
@@ -65,7 +65,6 @@ func newStatusCmd(cfg *action.Configuration, out io.Writer) *cobra.Command {
 			return compListReleases(toComplete, args, cfg)
 		},
 		RunE: func(_ *cobra.Command, args []string) error {
-
 			// When the output format is a table the resources should be fetched
 			// and displayed as a table. When YAML or JSON the resources will be
 			// returned. This mirrors the handling in kubectl.
@@ -80,7 +79,12 @@ func newStatusCmd(cfg *action.Configuration, out io.Writer) *cobra.Command {
 			// strip chart metadata from the output
 			rel.Chart = nil
 
-			return outfmt.Write(out, &statusPrinter{rel, false, client.ShowDescription, client.ShowResources, false, false})
+			return outfmt.Write(out, &statusPrinter{
+				release:      rel,
+				debug:        false,
+				showMetadata: false,
+				hideNotes:    false,
+			})
 		},
 	}
 
@@ -94,26 +98,20 @@ func newStatusCmd(cfg *action.Configuration, out io.Writer) *cobra.Command {
 		}
 		return nil, cobra.ShellCompDirectiveNoFileComp
 	})
-
 	if err != nil {
 		log.Fatal(err)
 	}
 
 	bindOutputFlag(cmd, &outfmt)
-	f.BoolVar(&client.ShowDescription, "show-desc", false, "if set, display the description message of the named release")
-
-	f.BoolVar(&client.ShowResources, "show-resources", false, "if set, display the resources of the named release")
 
 	return cmd
 }
 
 type statusPrinter struct {
-	release         *release.Release
-	debug           bool
-	showDescription bool
-	showResources   bool
-	showMetadata    bool
-	hideNotes       bool
+	release      *release.Release
+	debug        bool
+	showMetadata bool
+	hideNotes    bool
 }
 
 func (s statusPrinter) WriteJSON(out io.Writer) error {
@@ -140,11 +138,9 @@ func (s statusPrinter) WriteTable(out io.Writer) error {
 		_, _ = fmt.Fprintf(out, "VERSION: %s\n", s.release.Chart.Metadata.Version)
 		_, _ = fmt.Fprintf(out, "APP_VERSION: %s\n", s.release.Chart.Metadata.AppVersion)
 	}
-	if s.showDescription {
-		_, _ = fmt.Fprintf(out, "DESCRIPTION: %s\n", s.release.Info.Description)
-	}
+	_, _ = fmt.Fprintf(out, "DESCRIPTION: %s\n", s.release.Info.Description)
 
-	if s.showResources && s.release.Info.Resources != nil && len(s.release.Info.Resources) > 0 {
+	if s.release.Info.Resources != nil && len(s.release.Info.Resources) > 0 {
 		buf := new(bytes.Buffer)
 		printFlags := get.NewHumanPrintFlags()
 		typePrinter, _ := printFlags.ToPrinter("")
diff --git a/cmd/helm/upgrade.go b/cmd/helm/upgrade.go
index 108550cbf..cd1bdbb06 100644
--- a/cmd/helm/upgrade.go
+++ b/cmd/helm/upgrade.go
@@ -160,7 +160,12 @@ func newUpgradeCmd(cfg *action.Configuration, out io.Writer) *cobra.Command {
 					if err != nil {
 						return err
 					}
-					return outfmt.Write(out, &statusPrinter{rel, settings.Debug, false, false, false, instClient.HideNotes})
+					return outfmt.Write(out, &statusPrinter{
+						release:      rel,
+						debug:        settings.Debug,
+						showMetadata: false,
+						hideNotes:    instClient.HideNotes,
+					})
 				} else if err != nil {
 					return err
 				}
@@ -238,7 +243,6 @@ func newUpgradeCmd(cfg *action.Configuration, out io.Writer) *cobra.Command {
 			}()
 
 			rel, err := client.RunWithContext(ctx, args[0], ch, vals)
-
 			if err != nil {
 				return errors.Wrap(err, "UPGRADE FAILED")
 			}
@@ -247,7 +251,12 @@ func newUpgradeCmd(cfg *action.Configuration, out io.Writer) *cobra.Command {
 				fmt.Fprintf(out, "Release %q has been upgraded. Happy Helming!\n", args[0])
 			}
 
-			return outfmt.Write(out, &statusPrinter{rel, settings.Debug, false, false, false, client.HideNotes})
+			return outfmt.Write(out, &statusPrinter{
+				release:      rel,
+				debug:        settings.Debug,
+				showMetadata: false,
+				hideNotes:    client.HideNotes,
+			})
 		},
 	}
 
@@ -291,7 +300,6 @@ func newUpgradeCmd(cfg *action.Configuration, out io.Writer) *cobra.Command {
 		}
 		return compVersionFlag(args[1], toComplete)
 	})
-
 	if err != nil {
 		log.Fatal(err)
 	}
diff --git a/pkg/action/status.go b/pkg/action/status.go
index ee1c9d613..101f7d348 100644
--- a/pkg/action/status.go
+++ b/pkg/action/status.go
@@ -32,15 +32,6 @@ type Status struct {
 
 	Version int
 
-	// If true, display description to output format,
-	// only affect print type table.
-	// TODO Helm 4: Remove this flag and output the description by default.
-	ShowDescription bool
-
-	// ShowResources sets if the resources should be retrieved with the status.
-	// TODO Helm 4: Remove this flag and output the resources by default.
-	ShowResources bool
-
 	// ShowResourcesTable is used with ShowResources. When true this will cause
 	// the resulting objects to be retrieved as a kind=table.
 	ShowResourcesTable bool
@@ -59,10 +50,6 @@ func (s *Status) Run(name string) (*release.Release, error) {
 		return nil, err
 	}
 
-	if !s.ShowResources {
-		return s.cfg.releaseContent(name, s.Version)
-	}
-
 	rel, err := s.cfg.releaseContent(name, s.Version)
 	if err != nil {
 		return nil, err


Test patch:
diff --git a/cmd/helm/release_testing.go b/cmd/helm/release_testing.go
index 136d785d1..efd507cf4 100644
--- a/cmd/helm/release_testing.go
+++ b/cmd/helm/release_testing.go
@@ -39,7 +39,7 @@ The tests to be run are defined in the chart that was installed.
 
 func newReleaseTestCmd(cfg *action.Configuration, out io.Writer) *cobra.Command {
 	client := action.NewReleaseTesting(cfg)
-	var outfmt = output.Table
+	outfmt := output.Table
 	var outputLogs bool
 	var filter []string
 
@@ -72,7 +72,12 @@ func newReleaseTestCmd(cfg *action.Configuration, out io.Writer) *cobra.Command
 				return runErr
 			}
 
-			if err := outfmt.Write(out, &statusPrinter{rel, settings.Debug, false, false, false, client.HideNotes}); err != nil {
+			if err := outfmt.Write(out, &statusPrinter{
+				release:      rel,
+				debug:        settings.Debug,
+				showMetadata: false,
+				hideNotes:    client.HideNotes,
+			}); err != nil {
 				return err
 			}
 
diff --git a/cmd/helm/status_test.go b/cmd/helm/status_test.go
index 6722bf949..155e27481 100644
--- a/cmd/helm/status_test.go
+++ b/cmd/helm/status_test.go
@@ -46,7 +46,7 @@ func TestStatusCmd(t *testing.T) {
 		}),
 	}, {
 		name:   "get status of a deployed release, with desc",
-		cmd:    "status --show-desc flummoxed-chickadee",
+		cmd:    "status flummoxed-chickadee",
 		golden: "output/status-with-desc.txt",
 		rels: releasesMockWithStatus(&release.Info{
 			Status:      release.StatusDeployed,
@@ -70,7 +70,7 @@ func TestStatusCmd(t *testing.T) {
 		}),
 	}, {
 		name:   "get status of a deployed release with resources",
-		cmd:    "status --show-resources flummoxed-chickadee",
+		cmd:    "status flummoxed-chickadee",
 		golden: "output/status-with-resources.txt",
 		rels: releasesMockWithStatus(
 			&release.Info{
@@ -79,7 +79,7 @@ func TestStatusCmd(t *testing.T) {
 		),
 	}, {
 		name:   "get status of a deployed release with resources in json",
-		cmd:    "status --show-resources flummoxed-chickadee -o json",
+		cmd:    "status flummoxed-chickadee -o json",
 		golden: "output/status-with-resources.json",
 		rels: releasesMockWithStatus(
 			&release.Info{
diff --git a/cmd/helm/testdata/output/chart-with-subchart-update.txt b/cmd/helm/testdata/output/chart-with-subchart-update.txt
index a4135c782..5b2083e1d 100644
--- a/cmd/helm/testdata/output/chart-with-subchart-update.txt
+++ b/cmd/helm/testdata/output/chart-with-subchart-update.txt
@@ -3,6 +3,7 @@ LAST DEPLOYED: Fri Sep  2 22:04:05 1977
 NAMESPACE: default
 STATUS: deployed
 REVISION: 1
+DESCRIPTION: Install complete
 TEST SUITE: None
 NOTES:
 PARENT NOTES
diff --git a/cmd/helm/testdata/output/deprecated-chart.txt b/cmd/helm/testdata/output/deprecated-chart.txt
index 039d6aef6..fcf5cc0ef 100644
--- a/cmd/helm/testdata/output/deprecated-chart.txt
+++ b/cmd/helm/testdata/output/deprecated-chart.txt
@@ -3,4 +3,5 @@ LAST DEPLOYED: Fri Sep  2 22:04:05 1977
 NAMESPACE: default
 STATUS: deployed
 REVISION: 1
+DESCRIPTION: Install complete
 TEST SUITE: None
diff --git a/cmd/helm/testdata/output/get-release.txt b/cmd/helm/testdata/output/get-release.txt
index 12b4a407a..dbca662c5 100644
--- a/cmd/helm/testdata/output/get-release.txt
+++ b/cmd/helm/testdata/output/get-release.txt
@@ -6,6 +6,7 @@ REVISION: 1
 CHART: foo
 VERSION: 0.1.0-beta.1
 APP_VERSION: 1.0
+DESCRIPTION: Release mock
 TEST SUITE: None
 USER-SUPPLIED VALUES:
 name: value
diff --git a/cmd/helm/testdata/output/install-and-replace.txt b/cmd/helm/testdata/output/install-and-replace.txt
index 039d6aef6..fcf5cc0ef 100644
--- a/cmd/helm/testdata/output/install-and-replace.txt
+++ b/cmd/helm/testdata/output/install-and-replace.txt
@@ -3,4 +3,5 @@ LAST DEPLOYED: Fri Sep  2 22:04:05 1977
 NAMESPACE: default
 STATUS: deployed
 REVISION: 1
+DESCRIPTION: Install complete
 TEST SUITE: None
diff --git a/cmd/helm/testdata/output/install-dry-run-with-secret-hidden.txt b/cmd/helm/testdata/output/install-dry-run-with-secret-hidden.txt
index 2f928c3dc..eb770967f 100644
--- a/cmd/helm/testdata/output/install-dry-run-with-secret-hidden.txt
+++ b/cmd/helm/testdata/output/install-dry-run-with-secret-hidden.txt
@@ -3,6 +3,7 @@ LAST DEPLOYED: Fri Sep  2 22:04:05 1977
 NAMESPACE: default
 STATUS: pending-install
 REVISION: 1
+DESCRIPTION: Dry run complete
 TEST SUITE: None
 HOOKS:
 MANIFEST:
diff --git a/cmd/helm/testdata/output/install-dry-run-with-secret.txt b/cmd/helm/testdata/output/install-dry-run-with-secret.txt
index 6c094ef6a..d22c1437f 100644
--- a/cmd/helm/testdata/output/install-dry-run-with-secret.txt
+++ b/cmd/helm/testdata/output/install-dry-run-with-secret.txt
@@ -3,6 +3,7 @@ LAST DEPLOYED: Fri Sep  2 22:04:05 1977
 NAMESPACE: default
 STATUS: pending-install
 REVISION: 1
+DESCRIPTION: Dry run complete
 TEST SUITE: None
 HOOKS:
 MANIFEST:
diff --git a/cmd/helm/testdata/output/install-name-template.txt b/cmd/helm/testdata/output/install-name-template.txt
index 19952e3c2..bcc5f87ba 100644
--- a/cmd/helm/testdata/output/install-name-template.txt
+++ b/cmd/helm/testdata/output/install-name-template.txt
@@ -3,4 +3,5 @@ LAST DEPLOYED: Fri Sep  2 22:04:05 1977
 NAMESPACE: default
 STATUS: deployed
 REVISION: 1
+DESCRIPTION: Install complete
 TEST SUITE: None
diff --git a/cmd/helm/testdata/output/install-no-hooks.txt b/cmd/helm/testdata/output/install-no-hooks.txt
index 039d6aef6..fcf5cc0ef 100644
--- a/cmd/helm/testdata/output/install-no-hooks.txt
+++ b/cmd/helm/testdata/output/install-no-hooks.txt
@@ -3,4 +3,5 @@ LAST DEPLOYED: Fri Sep  2 22:04:05 1977
 NAMESPACE: default
 STATUS: deployed
 REVISION: 1
+DESCRIPTION: Install complete
 TEST SUITE: None
diff --git a/cmd/helm/testdata/output/install-with-multiple-values-files.txt b/cmd/helm/testdata/output/install-with-multiple-values-files.txt
index 406e522a9..1116cb907 100644
--- a/cmd/helm/testdata/output/install-with-multiple-values-files.txt
+++ b/cmd/helm/testdata/output/install-with-multiple-values-files.txt
@@ -3,4 +3,5 @@ LAST DEPLOYED: Fri Sep  2 22:04:05 1977
 NAMESPACE: default
 STATUS: deployed
 REVISION: 1
+DESCRIPTION: Install complete
 TEST SUITE: None
diff --git a/cmd/helm/testdata/output/install-with-multiple-values.txt b/cmd/helm/testdata/output/install-with-multiple-values.txt
index 406e522a9..1116cb907 100644
--- a/cmd/helm/testdata/output/install-with-multiple-values.txt
+++ b/cmd/helm/testdata/output/install-with-multiple-values.txt
@@ -3,4 +3,5 @@ LAST DEPLOYED: Fri Sep  2 22:04:05 1977
 NAMESPACE: default
 STATUS: deployed
 REVISION: 1
+DESCRIPTION: Install complete
 TEST SUITE: None
diff --git a/cmd/helm/testdata/output/install-with-timeout.txt b/cmd/helm/testdata/output/install-with-timeout.txt
index 19952e3c2..bcc5f87ba 100644
--- a/cmd/helm/testdata/output/install-with-timeout.txt
+++ b/cmd/helm/testdata/output/install-with-timeout.txt
@@ -3,4 +3,5 @@ LAST DEPLOYED: Fri Sep  2 22:04:05 1977
 NAMESPACE: default
 STATUS: deployed
 REVISION: 1
+DESCRIPTION: Install complete
 TEST SUITE: None
diff --git a/cmd/helm/testdata/output/install-with-values-file.txt b/cmd/helm/testdata/output/install-with-values-file.txt
index 406e522a9..1116cb907 100644
--- a/cmd/helm/testdata/output/install-with-values-file.txt
+++ b/cmd/helm/testdata/output/install-with-values-file.txt
@@ -3,4 +3,5 @@ LAST DEPLOYED: Fri Sep  2 22:04:05 1977
 NAMESPACE: default
 STATUS: deployed
 REVISION: 1
+DESCRIPTION: Install complete
 TEST SUITE: None
diff --git a/cmd/helm/testdata/output/install-with-values.txt b/cmd/helm/testdata/output/install-with-values.txt
index 406e522a9..1116cb907 100644
--- a/cmd/helm/testdata/output/install-with-values.txt
+++ b/cmd/helm/testdata/output/install-with-values.txt
@@ -3,4 +3,5 @@ LAST DEPLOYED: Fri Sep  2 22:04:05 1977
 NAMESPACE: default
 STATUS: deployed
 REVISION: 1
+DESCRIPTION: Install complete
 TEST SUITE: None
diff --git a/cmd/helm/testdata/output/install-with-wait-for-jobs.txt b/cmd/helm/testdata/output/install-with-wait-for-jobs.txt
index 7ce22d4ec..c5676c610 100644
--- a/cmd/helm/testdata/output/install-with-wait-for-jobs.txt
+++ b/cmd/helm/testdata/output/install-with-wait-for-jobs.txt
@@ -3,4 +3,5 @@ LAST DEPLOYED: Fri Sep  2 22:04:05 1977
 NAMESPACE: default
 STATUS: deployed
 REVISION: 1
+DESCRIPTION: Install complete
 TEST SUITE: None
diff --git a/cmd/helm/testdata/output/install-with-wait.txt b/cmd/helm/testdata/output/install-with-wait.txt
index 7ce22d4ec..c5676c610 100644
--- a/cmd/helm/testdata/output/install-with-wait.txt
+++ b/cmd/helm/testdata/output/install-with-wait.txt
@@ -3,4 +3,5 @@ LAST DEPLOYED: Fri Sep  2 22:04:05 1977
 NAMESPACE: default
 STATUS: deployed
 REVISION: 1
+DESCRIPTION: Install complete
 TEST SUITE: None
diff --git a/cmd/helm/testdata/output/install.txt b/cmd/helm/testdata/output/install.txt
index 039d6aef6..fcf5cc0ef 100644
--- a/cmd/helm/testdata/output/install.txt
+++ b/cmd/helm/testdata/output/install.txt
@@ -3,4 +3,5 @@ LAST DEPLOYED: Fri Sep  2 22:04:05 1977
 NAMESPACE: default
 STATUS: deployed
 REVISION: 1
+DESCRIPTION: Install complete
 TEST SUITE: None
diff --git a/cmd/helm/testdata/output/schema.txt b/cmd/helm/testdata/output/schema.txt
index 22a94b3f4..f5fe63768 100644
--- a/cmd/helm/testdata/output/schema.txt
+++ b/cmd/helm/testdata/output/schema.txt
@@ -3,4 +3,5 @@ LAST DEPLOYED: Fri Sep  2 22:04:05 1977
 NAMESPACE: default
 STATUS: deployed
 REVISION: 1
+DESCRIPTION: Install complete
 TEST SUITE: None
diff --git a/cmd/helm/testdata/output/status-with-notes.txt b/cmd/helm/testdata/output/status-with-notes.txt
index e992ce91e..f05be6c18 100644
--- a/cmd/helm/testdata/output/status-with-notes.txt
+++ b/cmd/helm/testdata/output/status-with-notes.txt
@@ -3,6 +3,7 @@ LAST DEPLOYED: Sat Jan 16 00:00:00 2016
 NAMESPACE: default
 STATUS: deployed
 REVISION: 0
+DESCRIPTION: 
 TEST SUITE: None
 NOTES:
 release notes
diff --git a/cmd/helm/testdata/output/status-with-resources.txt b/cmd/helm/testdata/output/status-with-resources.txt
index a326c3db0..20763acda 100644
--- a/cmd/helm/testdata/output/status-with-resources.txt
+++ b/cmd/helm/testdata/output/status-with-resources.txt
@@ -3,4 +3,5 @@ LAST DEPLOYED: Sat Jan 16 00:00:00 2016
 NAMESPACE: default
 STATUS: deployed
 REVISION: 0
+DESCRIPTION: 
 TEST SUITE: None
diff --git a/cmd/helm/testdata/output/status-with-test-suite.txt b/cmd/helm/testdata/output/status-with-test-suite.txt
index 58c67e103..7c1ade450 100644
--- a/cmd/helm/testdata/output/status-with-test-suite.txt
+++ b/cmd/helm/testdata/output/status-with-test-suite.txt
@@ -3,6 +3,7 @@ LAST DEPLOYED: Sat Jan 16 00:00:00 2016
 NAMESPACE: default
 STATUS: deployed
 REVISION: 0
+DESCRIPTION: 
 TEST SUITE:     passing-test
 Last Started:   Mon Jan  2 15:04:05 2006
 Last Completed: Mon Jan  2 15:04:07 2006
diff --git a/cmd/helm/testdata/output/status.txt b/cmd/helm/testdata/output/status.txt
index a326c3db0..20763acda 100644
--- a/cmd/helm/testdata/output/status.txt
+++ b/cmd/helm/testdata/output/status.txt
@@ -3,4 +3,5 @@ LAST DEPLOYED: Sat Jan 16 00:00:00 2016
 NAMESPACE: default
 STATUS: deployed
 REVISION: 0
+DESCRIPTION: 
 TEST SUITE: None
diff --git a/cmd/helm/testdata/output/subchart-schema-cli.txt b/cmd/helm/testdata/output/subchart-schema-cli.txt
index 22a94b3f4..f5fe63768 100644
--- a/cmd/helm/testdata/output/subchart-schema-cli.txt
+++ b/cmd/helm/testdata/output/subchart-schema-cli.txt
@@ -3,4 +3,5 @@ LAST DEPLOYED: Fri Sep  2 22:04:05 1977
 NAMESPACE: default
 STATUS: deployed
 REVISION: 1
+DESCRIPTION: Install complete
 TEST SUITE: None
diff --git a/cmd/helm/testdata/output/upgrade-uninstalled-with-keep-history.txt b/cmd/helm/testdata/output/upgrade-uninstalled-with-keep-history.txt
index f53b8715a..d5c42d15c 100644
--- a/cmd/helm/testdata/output/upgrade-uninstalled-with-keep-history.txt
+++ b/cmd/helm/testdata/output/upgrade-uninstalled-with-keep-history.txt
@@ -4,4 +4,5 @@ LAST DEPLOYED: Fri Sep  2 22:04:05 1977
 NAMESPACE: default
 STATUS: deployed
 REVISION: 3
+DESCRIPTION: Install complete
 TEST SUITE: None
diff --git a/cmd/helm/testdata/output/upgrade-with-dependency-update.txt b/cmd/helm/testdata/output/upgrade-with-dependency-update.txt
index 0e7e5842e..d1517a686 100644
--- a/cmd/helm/testdata/output/upgrade-with-dependency-update.txt
+++ b/cmd/helm/testdata/output/upgrade-with-dependency-update.txt
@@ -4,6 +4,7 @@ LAST DEPLOYED: Fri Sep  2 22:04:05 1977
 NAMESPACE: default
 STATUS: deployed
 REVISION: 3
+DESCRIPTION: Upgrade complete
 TEST SUITE: None
 NOTES:
 PARENT NOTES
diff --git a/cmd/helm/testdata/output/upgrade-with-install-timeout.txt b/cmd/helm/testdata/output/upgrade-with-install-timeout.txt
index 5d8d3a4ea..b159dc3bc 100644
--- a/cmd/helm/testdata/output/upgrade-with-install-timeout.txt
+++ b/cmd/helm/testdata/output/upgrade-with-install-timeout.txt
@@ -4,4 +4,5 @@ LAST DEPLOYED: Fri Sep  2 22:04:05 1977
 NAMESPACE: default
 STATUS: deployed
 REVISION: 2
+DESCRIPTION: Upgrade complete
 TEST SUITE: None
diff --git a/cmd/helm/testdata/output/upgrade-with-install.txt b/cmd/helm/testdata/output/upgrade-with-install.txt
index af61212bd..7dc2fce69 100644
--- a/cmd/helm/testdata/output/upgrade-with-install.txt
+++ b/cmd/helm/testdata/output/upgrade-with-install.txt
@@ -4,4 +4,5 @@ LAST DEPLOYED: Fri Sep  2 22:04:05 1977
 NAMESPACE: default
 STATUS: deployed
 REVISION: 2
+DESCRIPTION: Upgrade complete
 TEST SUITE: None
diff --git a/cmd/helm/testdata/output/upgrade-with-reset-values.txt b/cmd/helm/testdata/output/upgrade-with-reset-values.txt
index 01f1c0ac8..d02993a5c 100644
--- a/cmd/helm/testdata/output/upgrade-with-reset-values.txt
+++ b/cmd/helm/testdata/output/upgrade-with-reset-values.txt
@@ -4,4 +4,5 @@ LAST DEPLOYED: Fri Sep  2 22:04:05 1977
 NAMESPACE: default
 STATUS: deployed
 REVISION: 5
+DESCRIPTION: Upgrade complete
 TEST SUITE: None
diff --git a/cmd/helm/testdata/output/upgrade-with-reset-values2.txt b/cmd/helm/testdata/output/upgrade-with-reset-values2.txt
index fdd1d2db7..7780c4fdc 100644
--- a/cmd/helm/testdata/output/upgrade-with-reset-values2.txt
+++ b/cmd/helm/testdata/output/upgrade-with-reset-values2.txt
@@ -4,4 +4,5 @@ LAST DEPLOYED: Fri Sep  2 22:04:05 1977
 NAMESPACE: default
 STATUS: deployed
 REVISION: 6
+DESCRIPTION: Upgrade complete
 TEST SUITE: None
diff --git a/cmd/helm/testdata/output/upgrade-with-timeout.txt b/cmd/helm/testdata/output/upgrade-with-timeout.txt
index be3a42368..b1edac3af 100644
--- a/cmd/helm/testdata/output/upgrade-with-timeout.txt
+++ b/cmd/helm/testdata/output/upgrade-with-timeout.txt
@@ -4,4 +4,5 @@ LAST DEPLOYED: Fri Sep  2 22:04:05 1977
 NAMESPACE: default
 STATUS: deployed
 REVISION: 4
+DESCRIPTION: Upgrade complete
 TEST SUITE: None
diff --git a/cmd/helm/testdata/output/upgrade-with-wait-for-jobs.txt b/cmd/helm/testdata/output/upgrade-with-wait-for-jobs.txt
index 500d07a11..21784413c 100644
--- a/cmd/helm/testdata/output/upgrade-with-wait-for-jobs.txt
+++ b/cmd/helm/testdata/output/upgrade-with-wait-for-jobs.txt
@@ -4,4 +4,5 @@ LAST DEPLOYED: Fri Sep  2 22:04:05 1977
 NAMESPACE: default
 STATUS: deployed
 REVISION: 3
+DESCRIPTION: Upgrade complete
 TEST SUITE: None
diff --git a/cmd/helm/testdata/output/upgrade-with-wait.txt b/cmd/helm/testdata/output/upgrade-with-wait.txt
index 500d07a11..21784413c 100644
--- a/cmd/helm/testdata/output/upgrade-with-wait.txt
+++ b/cmd/helm/testdata/output/upgrade-with-wait.txt
@@ -4,4 +4,5 @@ LAST DEPLOYED: Fri Sep  2 22:04:05 1977
 NAMESPACE: default
 STATUS: deployed
 REVISION: 3
+DESCRIPTION: Upgrade complete
 TEST SUITE: None
diff --git a/cmd/helm/testdata/output/upgrade.txt b/cmd/helm/testdata/output/upgrade.txt
index bea42db54..59267651f 100644
--- a/cmd/helm/testdata/output/upgrade.txt
+++ b/cmd/helm/testdata/output/upgrade.txt
@@ -4,4 +4,5 @@ LAST DEPLOYED: Fri Sep  2 22:04:05 1977
 NAMESPACE: default
 STATUS: deployed
 REVISION: 3
+DESCRIPTION: Upgrade complete
 TEST SUITE: None