nebius/SWE-rebench-V2-PRs huggingface dataset:
Repository: ember-cli/ember-cli
Pull request #7631 (2018-02-16 12:30:26)

Fix failing tests on `beta` branch
see commit messages

/cc @mixonic 


Patch:
diff --git a/lib/experiments/index.js b/lib/experiments/index.js
index d0f5d14ce..0796b231c 100644
--- a/lib/experiments/index.js
+++ b/lib/experiments/index.js
@@ -1,4 +1,6 @@
 'use strict';
+
+// eslint-disable-next-line no-unused-vars
 const symbol = require('../utilities/symbol');
 
 let experiments = {


Test patch:
diff --git a/tests/unit/models/project-test.js b/tests/unit/models/project-test.js
index 0331be5dc..111477e6b 100644
--- a/tests/unit/models/project-test.js
+++ b/tests/unit/models/project-test.js
@@ -10,6 +10,7 @@ const expect = require('chai').expect;
 const emberCLIVersion = require('../../../lib/utilities/version-utils').emberCLIVersion;
 const td = require('testdouble');
 const MockCLI = require('../../helpers/mock-cli');
+const experiments = require('../../../lib/experiments');
 
 describe('models/project.js', function() {
   let project, projectPath, packageContents;
@@ -522,24 +523,26 @@ describe('models/project.js', function() {
     });
   });
 
-  describe('isModuleUnification', function() {
-    beforeEach(function() {
-      projectPath = `${process.cwd()}/tmp/test-app`;
+  if (experiments.MODULE_UNIFICATION) {
+    describe('isModuleUnification', function() {
+      beforeEach(function() {
+        projectPath = `${process.cwd()}/tmp/test-app`;
 
-      makeProject();
-    });
+        makeProject();
+      });
 
-    it('returns false when `./src` does not exist', function() {
-      expect(project.isModuleUnification()).to.equal(false);
-    });
+      it('returns false when `./src` does not exist', function() {
+        expect(project.isModuleUnification()).to.equal(false);
+      });
 
-    it('returns true when `./src` exists', function() {
-      let srcPath = path.join(projectPath, 'src');
-      fs.ensureDirSync(srcPath);
+      it('returns true when `./src` exists', function() {
+        let srcPath = path.join(projectPath, 'src');
+        fs.ensureDirSync(srcPath);
 
-      expect(project.isModuleUnification()).to.equal(true);
+        expect(project.isModuleUnification()).to.equal(true);
+      });
     });
-  });
+  }
 
   describe('findAddonByName', function() {
     beforeEach(function() {
Repository: ember-cli/ember-cli
Pull request #7685 (2018-03-17 00:20:24)

fix the shims messaging
It was missing the termination condition when `addons` is empty causing it to always be false.

stefanpenner: do we need a test?
rwjblue: Yeah, probably 

Patch:
diff --git a/lib/broccoli/ember-app.js b/lib/broccoli/ember-app.js
index 9c9ce99aa..d5e52d899 100644
--- a/lib/broccoli/ember-app.js
+++ b/lib/broccoli/ember-app.js
@@ -543,7 +543,7 @@ class EmberApp {
       }
     }
 
-    return addons.some(addon => this._checkEmberCliBabel(addon.addons, result, roots));
+    return addons.some(addon => this._checkEmberCliBabel(addon.addons, result, roots)) || result;
   }
 
   /**


Test patch:
diff --git a/tests/fixtures/addon/simple/package.json b/tests/fixtures/addon/simple/package.json
index 18dbcf5cb..27992b0ef 100644
--- a/tests/fixtures/addon/simple/package.json
+++ b/tests/fixtures/addon/simple/package.json
@@ -7,7 +7,7 @@
   "ember-addon": {
     "paths": ["./lib/ember-super-button"]
   },
-    "devDependencies": {
+  "devDependencies": {
     "ember-resolver": "^2.0.2",
     "ember-cli": "latest",
     "ember-random-addon": "latest",
diff --git a/tests/unit/broccoli/ember-app-test.js b/tests/unit/broccoli/ember-app-test.js
index 11e922a1e..d3c49f458 100644
--- a/tests/unit/broccoli/ember-app-test.js
+++ b/tests/unit/broccoli/ember-app-test.js
@@ -1008,4 +1008,28 @@ describe('EmberApp', function() {
       });
     });
   });
+
+  it('shows ember-cli-shims deprecation', function() {
+    let root = path.resolve(__dirname, '../../fixtures/app/npm');
+    let project = setupProject(root);
+    project.require = function() {
+      return {
+        version: '5.0.0',
+      };
+    };
+    project.initializeAddons = function() {
+      this.addons = [
+        {
+          name: 'ember-cli-babel',
+          pkg: { version: '5.0.0' },
+        },
+      ];
+    };
+
+    app = new EmberApp({
+      project,
+    });
+
+    expect(project.ui.output).to.contain("You have not included `ember-cli-shims` in your project's `bower.json` or `package.json`.");
+  });
 });
Repository: ember-cli/ember-cli
Pull request #7721 (2018-04-02 05:21:25)

update eslint-plugin-node for addons
nothing too extreme in the breaking changes/rules


Patch:
diff --git a/blueprints/addon/index.js b/blueprints/addon/index.js
index 89c18c65e..4ce875cf2 100644
--- a/blueprints/addon/index.js
+++ b/blueprints/addon/index.js
@@ -63,7 +63,7 @@ module.exports = {
     contents.devDependencies['ember-disable-prototype-extensions'] = '^1.1.2';
 
     // add `eslint-plugin-node` to addons by default
-    contents.devDependencies['eslint-plugin-node'] = '^5.2.1';
+    contents.devDependencies['eslint-plugin-node'] = '^6.0.1';
 
     // add ember-try
     contents.devDependencies['ember-try'] = '^0.2.23';


Test patch:
diff --git a/tests/fixtures/addon/npm/package.json b/tests/fixtures/addon/npm/package.json
index 400d1536a..332b98d97 100644
--- a/tests/fixtures/addon/npm/package.json
+++ b/tests/fixtures/addon/npm/package.json
@@ -43,7 +43,7 @@
     "ember-source-channel-url": "^1.0.1",
     "ember-try": "^0.2.23",
     "eslint-plugin-ember": "^5.0.0",
-    "eslint-plugin-node": "^5.2.1",
+    "eslint-plugin-node": "^6.0.1",
     "loader.js": "^4.2.3"
   },
   "engines": {
diff --git a/tests/fixtures/addon/yarn/package.json b/tests/fixtures/addon/yarn/package.json
index 40845bdd0..2bbf0cb95 100644
--- a/tests/fixtures/addon/yarn/package.json
+++ b/tests/fixtures/addon/yarn/package.json
@@ -44,7 +44,7 @@
     "ember-try": "^0.2.23",
     "ember-welcome-page": "^3.0.0",
     "eslint-plugin-ember": "^5.0.0",
-    "eslint-plugin-node": "^5.2.1",
+    "eslint-plugin-node": "^6.0.1",
     "loader.js": "^4.2.3"
   },
   "engines": {
diff --git a/tests/unit/blueprints/addon-test.js b/tests/unit/blueprints/addon-test.js
index e41f23558..6118b87c0 100644
--- a/tests/unit/blueprints/addon-test.js
+++ b/tests/unit/blueprints/addon-test.js
@@ -78,7 +78,7 @@ describe('blueprint - addon', function() {
     "ember-disable-prototype-extensions": "^1.1.2",\n\
     "ember-source-channel-url": "^1.0.1",\n\
     "ember-try": "^0.2.23",\n\
-    "eslint-plugin-node": "^5.2.1"\n\
+    "eslint-plugin-node": "^6.0.1"\n\
   },\n\
   "ember-addon": {\n\
     "configPath": "tests/dummy/config"\n\
Repository: ember-cli/ember-cli
Pull request #7736 (2018-04-04 20:26:42)

add addon-test-support/index.js to eslint glob bug mitigation


Patch:
diff --git a/blueprints/app/files/.eslintrc.js b/blueprints/app/files/.eslintrc.js
index 110480669..db5870eb9 100644
--- a/blueprints/app/files/.eslintrc.js
+++ b/blueprints/app/files/.eslintrc.js
@@ -28,8 +28,9 @@ module.exports = {
         'tests/dummy/config/**/*.js'<% } %>
       ],<% if (blueprint !== 'app') { %>
       excludedFiles: [
-        'app/**',
         'addon/**',
+        'addon-test-support/**',
+        'app/**',
         'tests/dummy/app/**'
       ],<% } %>
       parserOptions: {


Test patch:
diff --git a/tests/fixtures/addon/npm/.eslintrc.js b/tests/fixtures/addon/npm/.eslintrc.js
index 803203efc..466bbee39 100644
--- a/tests/fixtures/addon/npm/.eslintrc.js
+++ b/tests/fixtures/addon/npm/.eslintrc.js
@@ -27,8 +27,9 @@ module.exports = {
         'tests/dummy/config/**/*.js'
       ],
       excludedFiles: [
-        'app/**',
         'addon/**',
+        'addon-test-support/**',
+        'app/**',
         'tests/dummy/app/**'
       ],
       parserOptions: {
diff --git a/tests/fixtures/addon/yarn/.eslintrc.js b/tests/fixtures/addon/yarn/.eslintrc.js
index 803203efc..466bbee39 100644
--- a/tests/fixtures/addon/yarn/.eslintrc.js
+++ b/tests/fixtures/addon/yarn/.eslintrc.js
@@ -27,8 +27,9 @@ module.exports = {
         'tests/dummy/config/**/*.js'
       ],
       excludedFiles: [
-        'app/**',
         'addon/**',
+        'addon-test-support/**',
+        'app/**',
         'tests/dummy/app/**'
       ],
       parserOptions: {
Repository: ember-cli/ember-cli
Pull request #7749 (2018-04-12 20:48:45)

remove trailing comma
Accidentally targeted master on the last one.

twokul: https://github.com/ember-cli/ember-cli/pull/7747
kellyselden: It's probably the same issue, but the release branch. beta branch might suffer as well.
Turbo87: was this already published with the trailing comma? I'm not sure it's worth the churn to fix it unless we enable the trailing comma rule of ESLint by default.
kellyselden: > was this already published with the trailing comma?

yes.

> I'm not sure it's worth the churn to fix

I don't think churn is as much of a concern now that we have ember-cli-update. Also, I think it is worth it because projects that have a trailing-comma rule (all of mine) now get eslint errors with this version. I don't think it's worth putting in an exclusion everywhere for a file that accidentally violated a convention.

Patch:
diff --git a/blueprints/addon/files/addon-config/ember-try.js b/blueprints/addon/files/addon-config/ember-try.js
index f607ff6ad..26c3ea95e 100644
--- a/blueprints/addon/files/addon-config/ember-try.js
+++ b/blueprints/addon/files/addon-config/ember-try.js
@@ -6,7 +6,7 @@ module.exports = function() {
   return Promise.all([
     getChannelURL('release'),
     getChannelURL('beta'),
-    getChannelURL('canary'),
+    getChannelURL('canary')
   ]).then((urls) => {
     return {
       <% if (yarn) { %>useYarn: true,


Test patch:
diff --git a/tests/fixtures/addon/npm/config/ember-try.js b/tests/fixtures/addon/npm/config/ember-try.js
index 08e0dd918..644b02b30 100644
--- a/tests/fixtures/addon/npm/config/ember-try.js
+++ b/tests/fixtures/addon/npm/config/ember-try.js
@@ -6,7 +6,7 @@ module.exports = function() {
   return Promise.all([
     getChannelURL('release'),
     getChannelURL('beta'),
-    getChannelURL('canary'),
+    getChannelURL('canary')
   ]).then((urls) => {
     return {
       scenarios: [
diff --git a/tests/fixtures/addon/yarn/config/ember-try.js b/tests/fixtures/addon/yarn/config/ember-try.js
index 6c7a816e2..fb2231112 100644
--- a/tests/fixtures/addon/yarn/config/ember-try.js
+++ b/tests/fixtures/addon/yarn/config/ember-try.js
@@ -6,7 +6,7 @@ module.exports = function() {
   return Promise.all([
     getChannelURL('release'),
     getChannelURL('beta'),
-    getChannelURL('canary'),
+    getChannelURL('canary')
   ]).then((urls) => {
     return {
       useYarn: true,
Repository: ember-cli/ember-cli
Pull request #7753 (2018-04-13 07:56:17)

Update `qunit-dom` dependency
... from 0.5.0 to 0.6.2


Patch:
diff --git a/blueprints/app/files/package.json b/blueprints/app/files/package.json
index 5d95585f8..ce5db85a6 100644
--- a/blueprints/app/files/package.json
+++ b/blueprints/app/files/package.json
@@ -40,7 +40,7 @@
     "ember-welcome-page": "^3.0.0<% } %>",
     "eslint-plugin-ember": "^5.0.0",
     "loader.js": "^4.2.3",
-    "qunit-dom": "^0.5.0"
+    "qunit-dom": "^0.6.2"
   },
   "engines": {
     "node": "^4.5 || 6.* || >= 7.*"


Test patch:
diff --git a/tests/fixtures/addon/npm/package.json b/tests/fixtures/addon/npm/package.json
index 26dc5bec1..10024cba8 100644
--- a/tests/fixtures/addon/npm/package.json
+++ b/tests/fixtures/addon/npm/package.json
@@ -46,7 +46,7 @@
     "eslint-plugin-ember": "^5.0.0",
     "eslint-plugin-node": "^6.0.1",
     "loader.js": "^4.2.3",
-    "qunit-dom": "^0.5.0"
+    "qunit-dom": "^0.6.2"
   },
   "engines": {
     "node": "^4.5 || 6.* || >= 7.*"
diff --git a/tests/fixtures/addon/yarn/package.json b/tests/fixtures/addon/yarn/package.json
index 53962abf0..a2786b3a9 100644
--- a/tests/fixtures/addon/yarn/package.json
+++ b/tests/fixtures/addon/yarn/package.json
@@ -47,7 +47,7 @@
     "eslint-plugin-ember": "^5.0.0",
     "eslint-plugin-node": "^6.0.1",
     "loader.js": "^4.2.3",
-    "qunit-dom": "^0.5.0"
+    "qunit-dom": "^0.6.2"
   },
   "engines": {
     "node": "^4.5 || 6.* || >= 7.*"
diff --git a/tests/fixtures/app/npm/package.json b/tests/fixtures/app/npm/package.json
index 93feb6df3..d12be9e98 100644
--- a/tests/fixtures/app/npm/package.json
+++ b/tests/fixtures/app/npm/package.json
@@ -39,7 +39,7 @@
     "ember-source": "~3.1.0",
     "eslint-plugin-ember": "^5.0.0",
     "loader.js": "^4.2.3",
-    "qunit-dom": "^0.5.0"
+    "qunit-dom": "^0.6.2"
   },
   "engines": {
     "node": "^4.5 || 6.* || >= 7.*"
diff --git a/tests/fixtures/app/yarn/package.json b/tests/fixtures/app/yarn/package.json
index cde43aba3..a4166c839 100644
--- a/tests/fixtures/app/yarn/package.json
+++ b/tests/fixtures/app/yarn/package.json
@@ -40,7 +40,7 @@
     "ember-welcome-page": "^3.0.0",
     "eslint-plugin-ember": "^5.0.0",
     "loader.js": "^4.2.3",
-    "qunit-dom": "^0.5.0"
+    "qunit-dom": "^0.6.2"
   },
   "engines": {
     "node": "^4.5 || 6.* || >= 7.*"
Repository: ember-cli/ember-cli
Pull request #7756 (2018-04-13 16:53:41)

Merge release to beta


Patch:
diff --git a/blueprints/addon/files/addon-config/ember-try.js b/blueprints/addon/files/addon-config/ember-try.js
index f607ff6ad..26c3ea95e 100644
--- a/blueprints/addon/files/addon-config/ember-try.js
+++ b/blueprints/addon/files/addon-config/ember-try.js
@@ -6,7 +6,7 @@ module.exports = function() {
   return Promise.all([
     getChannelURL('release'),
     getChannelURL('beta'),
-    getChannelURL('canary'),
+    getChannelURL('canary')
   ]).then((urls) => {
     return {
       <% if (yarn) { %>useYarn: true,


Test patch:
diff --git a/tests/fixtures/addon/npm/config/ember-try.js b/tests/fixtures/addon/npm/config/ember-try.js
index 08e0dd918..644b02b30 100644
--- a/tests/fixtures/addon/npm/config/ember-try.js
+++ b/tests/fixtures/addon/npm/config/ember-try.js
@@ -6,7 +6,7 @@ module.exports = function() {
   return Promise.all([
     getChannelURL('release'),
     getChannelURL('beta'),
-    getChannelURL('canary'),
+    getChannelURL('canary')
   ]).then((urls) => {
     return {
       scenarios: [
diff --git a/tests/fixtures/addon/yarn/config/ember-try.js b/tests/fixtures/addon/yarn/config/ember-try.js
index 6c7a816e2..fb2231112 100644
--- a/tests/fixtures/addon/yarn/config/ember-try.js
+++ b/tests/fixtures/addon/yarn/config/ember-try.js
@@ -6,7 +6,7 @@ module.exports = function() {
   return Promise.all([
     getChannelURL('release'),
     getChannelURL('beta'),
-    getChannelURL('canary'),
+    getChannelURL('canary')
   ]).then((urls) => {
     return {
       useYarn: true,
Repository: ember-cli/ember-cli
Pull request #7829 (2018-05-14 04:17:49)

Move styles from add-ons under `app-name`
Before this change the structure of the tree that is passed in to `package` hook was

```
addon-modules/
vendor/
bower_components/
app-name/
app/
  styles/
    ...
```

This change will ensure we don't have an orphan `app/styles` folder since it's confusing and inconsistent. 

kellyselden: Can we have a little rationale is to why this is needed?
twokul: @kellyselden updated the description
twokul: @kellyselden `addonStyles` returns files that are automatically re-exported as a part of app's namespace. 

added test coverage for `getAddonStyles`

Patch:
diff --git a/lib/broccoli/ember-app.js b/lib/broccoli/ember-app.js
index 25f5bc167..11332546f 100644
--- a/lib/broccoli/ember-app.js
+++ b/lib/broccoli/ember-app.js
@@ -1006,10 +1006,14 @@ class EmberApp {
    * @return {BroccoliTree}
   */
   getAddonStyles() {
-    return mergeTrees(this.addonTreesFor('styles'), {
+    let mergedAddonStyles = mergeTrees(this.addonTreesFor('styles'), {
       overwrite: true,
       annotation: 'Addon Styles',
     });
+
+    return new Funnel(mergedAddonStyles, {
+      destDir: this.name,
+    });
   }
 
   /*


Test patch:
diff --git a/tests/unit/broccoli/ember-app-test.js b/tests/unit/broccoli/ember-app-test.js
index e4b720b74..d21c7e23f 100644
--- a/tests/unit/broccoli/ember-app-test.js
+++ b/tests/unit/broccoli/ember-app-test.js
@@ -194,6 +194,54 @@ describe('EmberApp', function() {
     });
   }
 
+  describe('getAddonStyles()', function() {
+    it('returns add-ons styles files', co.wrap(function *() {
+      let addonFooStyles = yield createTempDir();
+      let addonBarStyles = yield createTempDir();
+
+      addonFooStyles.write({
+        app: {
+          styles: {
+            'foo.css': 'foo',
+          },
+        },
+      });
+      addonBarStyles.write({
+        app: {
+          styles: {
+            'bar.css': 'bar',
+          },
+        },
+      });
+
+      let app = new EmberApp({
+        project,
+      });
+      app.addonTreesFor = function() {
+        return [
+          addonFooStyles.path(),
+          addonBarStyles.path(),
+        ];
+      };
+
+      let output = yield buildOutput(app.getAddonStyles());
+      let outputFiles = output.read();
+
+      expect(outputFiles['test-project']).to.deep.equal({
+        app: {
+          styles: {
+            'foo.css': 'foo',
+            'bar.css': 'bar',
+          },
+        },
+      });
+
+      yield addonFooStyles.dispose();
+      yield addonBarStyles.dispose();
+      yield output.dispose();
+    }));
+  });
+
   describe('getPublic()', function() {
     it('returns public files for app and add-ons', co.wrap(function *() {
       let input = yield createTempDir();
@@ -211,9 +259,6 @@ describe('EmberApp', function() {
         'bar': 'bar',
       });
 
-      let app = new EmberApp({
-        project,
-      });
       app.trees.public = input.path();
       app.addonTreesFor = function() {
         return [
Repository: ember-cli/ember-cli
Pull request #7974 (2018-08-07 22:51:13)

Prevent double builds in CI for branches pushed by owner.
Prior to this change, the addon author (unless the addon was in an org) would always end up with _two_ CI builds for every PR. One for the branch push and one for the PR update.

This change prevents branch builds for branches other than `master`, therefore avoiding the issue.


Patch:
diff --git a/blueprints/addon/files/.travis.yml b/blueprints/addon/files/.travis.yml
index 7732e8a6a..270798415 100644
--- a/blueprints/addon/files/.travis.yml
+++ b/blueprints/addon/files/.travis.yml
@@ -23,6 +23,12 @@ env:
     # See https://git.io/vdao3 for details.
     - JOBS=1
 
+branches:
+  only:
+    - master
+    # npm version tags
+    - /^v\d+\.\d+\.\d+/
+
 jobs:
   fail_fast: true
   allow_failures:


Test patch:
diff --git a/tests/fixtures/addon/npm/.travis.yml b/tests/fixtures/addon/npm/.travis.yml
index d1b971ca6..957b0f666 100644
--- a/tests/fixtures/addon/npm/.travis.yml
+++ b/tests/fixtures/addon/npm/.travis.yml
@@ -20,6 +20,12 @@ env:
     # See https://git.io/vdao3 for details.
     - JOBS=1
 
+branches:
+  only:
+    - master
+    # npm version tags
+    - /^v\d+\.\d+\.\d+/
+
 jobs:
   fail_fast: true
   allow_failures:
diff --git a/tests/fixtures/addon/yarn/.travis.yml b/tests/fixtures/addon/yarn/.travis.yml
index 593c1743f..93701ae26 100644
--- a/tests/fixtures/addon/yarn/.travis.yml
+++ b/tests/fixtures/addon/yarn/.travis.yml
@@ -19,6 +19,12 @@ env:
     # See https://git.io/vdao3 for details.
     - JOBS=1
 
+branches:
+  only:
+    - master
+    # npm version tags
+    - /^v\d+\.\d+\.\d+/
+
 jobs:
   fail_fast: true
   allow_failures:
Repository: ember-cli/ember-cli
Pull request #8004 (2018-08-30 20:48:20)

Update version of ember-try to 1.0.0

rwjblue: Looks good, can you rebase and target beta branch?

Patch:
diff --git a/blueprints/addon/index.js b/blueprints/addon/index.js
index 683920468..1b6a4020b 100644
--- a/blueprints/addon/index.js
+++ b/blueprints/addon/index.js
@@ -70,7 +70,7 @@ module.exports = {
     contents.devDependencies['eslint-plugin-node'] = '^7.0.1';
 
     // add ember-try
-    contents.devDependencies['ember-try'] = '^1.0.0-beta.3';
+    contents.devDependencies['ember-try'] = '^1.0.0';
 
     // add ember-source-channel-url
     contents.devDependencies['ember-source-channel-url'] = '^1.1.0';


Test patch:
diff --git a/tests/fixtures/addon/npm/package.json b/tests/fixtures/addon/npm/package.json
index 2f589582d..8f62567f9 100644
--- a/tests/fixtures/addon/npm/package.json
+++ b/tests/fixtures/addon/npm/package.json
@@ -44,7 +44,7 @@
     "ember-resolver": "^5.0.1",
     "ember-source": "~3.4.0-beta.1",
     "ember-source-channel-url": "^1.1.0",
-    "ember-try": "^1.0.0-beta.3",
+    "ember-try": "^1.0.0",
     "eslint-plugin-ember": "^5.2.0",
     "eslint-plugin-node": "^7.0.1",
     "loader.js": "^4.7.0",
diff --git a/tests/fixtures/addon/yarn/package.json b/tests/fixtures/addon/yarn/package.json
index 127bd3140..7a082d73a 100644
--- a/tests/fixtures/addon/yarn/package.json
+++ b/tests/fixtures/addon/yarn/package.json
@@ -44,7 +44,7 @@
     "ember-resolver": "^5.0.1",
     "ember-source": "~3.4.0-beta.1",
     "ember-source-channel-url": "^1.1.0",
-    "ember-try": "^1.0.0-beta.3",
+    "ember-try": "^1.0.0",
     "ember-welcome-page": "^3.2.0",
     "eslint-plugin-ember": "^5.2.0",
     "eslint-plugin-node": "^7.0.1",
diff --git a/tests/unit/blueprints/addon-test.js b/tests/unit/blueprints/addon-test.js
index 142380a59..9fc340c7f 100644
--- a/tests/unit/blueprints/addon-test.js
+++ b/tests/unit/blueprints/addon-test.js
@@ -76,7 +76,7 @@ describe('blueprint - addon', function() {
   "devDependencies": {\n\
     "ember-disable-prototype-extensions": "^1.1.3",\n\
     "ember-source-channel-url": "^1.1.0",\n\
-    "ember-try": "^1.0.0-beta.3",\n\
+    "ember-try": "^1.0.0",\n\
     "eslint-plugin-node": "^7.0.1"\n\
   },\n\
   "ember-addon": {\n\
Repository: ember-cli/ember-cli
Pull request #8024 (2018-09-06 10:15:13)

[BUGFIX] Remove 2.12 scenario from travis.yml
In https://github.com/ember-cli/ember-cli/pull/8005 I removed 2.12 from `config/ember-try.js` but I forgot to remove it from the `.travis.yml` too.


Patch:
diff --git a/blueprints/addon/files/.travis.yml b/blueprints/addon/files/.travis.yml
index 7732e8a6a..2f4f94a44 100644
--- a/blueprints/addon/files/.travis.yml
+++ b/blueprints/addon/files/.travis.yml
@@ -47,8 +47,7 @@ jobs:
     # we recommend new addons test the current and previous LTS
     # as well as latest stable release (bonus points to beta/canary)
     - stage: "Additional Tests"
-      env: EMBER_TRY_SCENARIO=ember-lts-2.12
-    - env: EMBER_TRY_SCENARIO=ember-lts-2.16
+      env: EMBER_TRY_SCENARIO=ember-lts-2.16
     - env: EMBER_TRY_SCENARIO=ember-lts-2.18
     - env: EMBER_TRY_SCENARIO=ember-release
     - env: EMBER_TRY_SCENARIO=ember-beta


Test patch:
diff --git a/tests/fixtures/addon/npm/.travis.yml b/tests/fixtures/addon/npm/.travis.yml
index d1b971ca6..f904298f5 100644
--- a/tests/fixtures/addon/npm/.travis.yml
+++ b/tests/fixtures/addon/npm/.travis.yml
@@ -38,8 +38,7 @@ jobs:
     # we recommend new addons test the current and previous LTS
     # as well as latest stable release (bonus points to beta/canary)
     - stage: "Additional Tests"
-      env: EMBER_TRY_SCENARIO=ember-lts-2.12
-    - env: EMBER_TRY_SCENARIO=ember-lts-2.16
+      env: EMBER_TRY_SCENARIO=ember-lts-2.16
     - env: EMBER_TRY_SCENARIO=ember-lts-2.18
     - env: EMBER_TRY_SCENARIO=ember-release
     - env: EMBER_TRY_SCENARIO=ember-beta
diff --git a/tests/fixtures/addon/yarn/.travis.yml b/tests/fixtures/addon/yarn/.travis.yml
index 593c1743f..00af6f0e1 100644
--- a/tests/fixtures/addon/yarn/.travis.yml
+++ b/tests/fixtures/addon/yarn/.travis.yml
@@ -43,8 +43,7 @@ jobs:
     # we recommend new addons test the current and previous LTS
     # as well as latest stable release (bonus points to beta/canary)
     - stage: "Additional Tests"
-      env: EMBER_TRY_SCENARIO=ember-lts-2.12
-    - env: EMBER_TRY_SCENARIO=ember-lts-2.16
+      env: EMBER_TRY_SCENARIO=ember-lts-2.16
     - env: EMBER_TRY_SCENARIO=ember-lts-2.18
     - env: EMBER_TRY_SCENARIO=ember-release
     - env: EMBER_TRY_SCENARIO=ember-beta