Repository: reviewdog/reviewdog
Pull request #263 (2019-09-05 06:18:38)

fixup go.mod and go-github usage
google/go-github was upgraded to v28 in #259, however due to semantic
import versioning, you continued consuming v27. All import statements
are now migrated to /v27/, and no breakage occurred.

The pseudo-version declared for the reviewdog/errorformat module had an
incorrect timestamp. This is a fatal issue in go1.13, see release notes,
thus that too is fixed.

Since this module builds successfully with go1.13, I have upgraded the
go directive.


Patch:
diff --git a/cmd/reviewdog/main.go b/cmd/reviewdog/main.go
index 930ed509..d0341ce3 100644
--- a/cmd/reviewdog/main.go
+++ b/cmd/reviewdog/main.go
@@ -18,7 +18,7 @@ import (
 
 	"golang.org/x/oauth2"
 
-	"github.com/google/go-github/v27/github"
+	"github.com/google/go-github/v28/github"
 	shellwords "github.com/mattn/go-shellwords"
 	"github.com/reviewdog/errorformat/fmts"
 	"github.com/reviewdog/reviewdog"
@@ -27,7 +27,7 @@ import (
 	"github.com/reviewdog/reviewdog/project"
 	githubservice "github.com/reviewdog/reviewdog/service/github"
 	gitlabservice "github.com/reviewdog/reviewdog/service/gitlab"
-	"github.com/xanzy/go-gitlab"
+	gitlab "github.com/xanzy/go-gitlab"
 )
 
 const usageMessage = "" +
diff --git a/doghouse/appengine/github.go b/doghouse/appengine/github.go
index b2ee2cfb..7163b6bb 100644
--- a/doghouse/appengine/github.go
+++ b/doghouse/appengine/github.go
@@ -13,7 +13,7 @@ import (
 	"net/url"
 	"strings"
 
-	"github.com/google/go-github/v27/github"
+	"github.com/google/go-github/v28/github"
 	"github.com/justinas/nosurf"
 	"github.com/reviewdog/reviewdog/doghouse/server"
 	"github.com/reviewdog/reviewdog/doghouse/server/cookieman"
diff --git a/doghouse/appengine/github_webhook.go b/doghouse/appengine/github_webhook.go
index d0990ce2..1caf7cfc 100644
--- a/doghouse/appengine/github_webhook.go
+++ b/doghouse/appengine/github_webhook.go
@@ -7,7 +7,7 @@ import (
 	"io/ioutil"
 	"net/http"
 
-	"github.com/google/go-github/v27/github"
+	"github.com/google/go-github/v28/github"
 	"github.com/reviewdog/reviewdog/doghouse/server/storage"
 	"google.golang.org/appengine"
 )
diff --git a/doghouse/server/doghouse.go b/doghouse/server/doghouse.go
index ec2ca5b3..29d9984e 100644
--- a/doghouse/server/doghouse.go
+++ b/doghouse/server/doghouse.go
@@ -7,7 +7,7 @@ import (
 	"strings"
 	"time"
 
-	"github.com/google/go-github/v27/github"
+	"github.com/google/go-github/v28/github"
 	"github.com/reviewdog/reviewdog"
 	"github.com/reviewdog/reviewdog/diff"
 	"github.com/reviewdog/reviewdog/doghouse"
diff --git a/doghouse/server/github.go b/doghouse/server/github.go
index 7c3e53ae..e06c3f2f 100644
--- a/doghouse/server/github.go
+++ b/doghouse/server/github.go
@@ -7,7 +7,7 @@ import (
 	"net/http"
 
 	"github.com/bradleyfalzon/ghinstallation"
-	"github.com/google/go-github/v27/github"
+	"github.com/google/go-github/v28/github"
 	"github.com/reviewdog/reviewdog/doghouse/server/storage"
 )
 
diff --git a/doghouse/server/github_checker.go b/doghouse/server/github_checker.go
index 3309de04..2e899105 100644
--- a/doghouse/server/github_checker.go
+++ b/doghouse/server/github_checker.go
@@ -3,7 +3,7 @@ package server
 import (
 	"context"
 
-	"github.com/google/go-github/v27/github"
+	"github.com/google/go-github/v28/github"
 )
 
 type checkerGitHubClientInterface interface {
diff --git a/go.mod b/go.mod
index ca87a8f7..5dc5e0cf 100644
--- a/go.mod
+++ b/go.mod
@@ -15,7 +15,7 @@ require (
 	github.com/kylelemons/godebug v1.1.0
 	github.com/mattn/go-shellwords v1.0.5
 	github.com/rakyll/statik v0.1.6
-	github.com/reviewdog/errorformat v0.0.0-20190717122822-b91f67eef36b
+	github.com/reviewdog/errorformat v0.0.0-20190716162959-b91f67eef36b
 	github.com/xanzy/go-gitlab v0.19.0
 	golang.org/x/crypto v0.0.0-20190701094942-4def268fd1a4 // indirect
 	golang.org/x/net v0.0.0-20190724013045-ca1201d0de80
diff --git a/go.sum b/go.sum
index 89095e6d..9f5c83b2 100644
--- a/go.sum
+++ b/go.sum
@@ -15,8 +15,7 @@ github.com/golang/protobuf v1.3.2 h1:6nsPYzhq5kReh6QImI3k5qWzO4PEbvbIW2cwSfR/6xs
 github.com/golang/protobuf v1.3.2/go.mod h1:6lQm79b+lXiMfvg/cZm0SGofjICqVBUtrP5yJMmIC1U=
 github.com/google/go-cmp v0.3.1 h1:Xye71clBPdm5HgqGwUkwhbynsUJZhDbS20FvLhQ2izg=
 github.com/google/go-cmp v0.3.1/go.mod h1:8QqcDgzrUqlUb/G2PQTWiueGozuR1884gddMywk6iLU=
-github.com/google/go-github/v27 v27.0.4 h1:N/EEqsvJLgqTbepTiMBz+12KhwLovv6YvwpRezd+4Fg=
-github.com/google/go-github/v27 v27.0.4/go.mod h1:/0Gr8pJ55COkmv+S/yPKCczSkUPIM/LnFyubufRNIS0=
+github.com/google/go-github/v28 v28.0.1 h1:SoHeOf40H2xIQpNzGHFeOJwDqPxvEVMyz97hDafpk0Y=
 github.com/google/go-github/v28 v28.0.1/go.mod h1:+5GboIspo7F0NG2qsvfYh7en6F3EK37uyqv+c35AR3s=
 github.com/google/go-querystring v1.0.0 h1:Xkwi/a1rcvNg1PPYe5vI8GbeBY/jrVuDX5ASuANWTrk=
 github.com/google/go-querystring v1.0.0/go.mod h1:odCYkC5MyYFN7vkCjXpyrEuKhc/BUO6wN/zVPAxq5ck=
@@ -37,8 +36,8 @@ github.com/pmezard/go-difflib v1.0.0 h1:4DBwDE0NGyQoBHbLQYPwSUPoCMWR5BEzIk/f1lZb
 github.com/pmezard/go-difflib v1.0.0/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4=
 github.com/rakyll/statik v0.1.6 h1:uICcfUXpgqtw2VopbIncslhAmE5hwc4g20TEyEENBNs=
 github.com/rakyll/statik v0.1.6/go.mod h1:OEi9wJV/fMUAGx1eNjq75DKDsJVuEv1U0oYdX6GX8Zs=
-github.com/reviewdog/errorformat v0.0.0-20190717122822-b91f67eef36b h1:4lZUJiXbPsoBcP2WB6b2NtuuO+EVWE9gm7UjmdUJ5Ho=
-github.com/reviewdog/errorformat v0.0.0-20190717122822-b91f67eef36b/go.mod h1:4luFKE7i+JWca3IkiS0pim24VEyZ4evpd2UXOuqqOhY=
+github.com/reviewdog/errorformat v0.0.0-20190716162959-b91f67eef36b h1:MB02qZVBl1qUV/Z5yChdxwo9znGMWPxX6/EuEgUpNzo=
+github.com/reviewdog/errorformat v0.0.0-20190716162959-b91f67eef36b/go.mod h1:4luFKE7i+JWca3IkiS0pim24VEyZ4evpd2UXOuqqOhY=
 github.com/stretchr/objx v0.1.0/go.mod h1:HFkY916IF+rwdDfMAkV7OtwuqBVzrE8GR6GFx+wExME=
 github.com/stretchr/testify v1.3.0 h1:TivCn/peBQ7UY8ooIcPgZFpTNSz0Q2U6UrFlUfqbe0Q=
 github.com/stretchr/testify v1.3.0/go.mod h1:M5WIy9Dh21IEIfnGCwXGc5bZfKNJtfHm1UVUgZn+9EI=
diff --git a/service/github/github.go b/service/github/github.go
index fabdd98d..2c0463e2 100644
--- a/service/github/github.go
+++ b/service/github/github.go
@@ -6,7 +6,7 @@ import (
 	"path/filepath"
 	"sync"
 
-	"github.com/google/go-github/v27/github"
+	"github.com/google/go-github/v28/github"
 	"github.com/reviewdog/reviewdog"
 	"github.com/reviewdog/reviewdog/service/serviceutil"
 )


Test patch:
diff --git a/doghouse/server/doghouse_test.go b/doghouse/server/doghouse_test.go
index 2b2fa5fe..d442c912 100644
--- a/doghouse/server/doghouse_test.go
+++ b/doghouse/server/doghouse_test.go
@@ -6,7 +6,7 @@ import (
 	"testing"
 
 	"github.com/google/go-cmp/cmp"
-	"github.com/google/go-github/v27/github"
+	"github.com/google/go-github/v28/github"
 	"github.com/reviewdog/reviewdog/doghouse"
 )
 
diff --git a/service/github/github_test.go b/service/github/github_test.go
index 697dd9f3..6a282e6b 100644
--- a/service/github/github_test.go
+++ b/service/github/github_test.go
@@ -10,7 +10,7 @@ import (
 	"strings"
 	"testing"
 
-	"github.com/google/go-github/v27/github"
+	"github.com/google/go-github/v28/github"
 	"github.com/kylelemons/godebug/pretty"
 	"github.com/reviewdog/reviewdog"
 	"github.com/reviewdog/reviewdog/service/serviceutil"