nebius/SWE-rebench-V2-PRs huggingface dataset:
Repository: prebid/prebid-server
Pull request #3531 (2024-02-21 19:14:24)

DSA: Use seat nonbid code 300
Seat nonbid code 305 has not been formally approved yet so we will use 300 until then.
This PR also adds a DSA specific warning code as I don't think the invalid bid response error code makes sense since this is not a server error nor is it a malformed bid response. Instead it is a validation error.


Patch:
diff --git a/errortypes/code.go b/errortypes/code.go
index 1de5e648..399dd663 100644
--- a/errortypes/code.go
+++ b/errortypes/code.go
@@ -31,6 +31,7 @@ const (
 	AdServerTargetingWarningCode
 	BidAdjustmentWarningCode
 	FloorBidRejectionWarningCode
+	InvalidBidResponseDSAWarningCode
 )
 
 // Coder provides an error or warning code with severity.
diff --git a/exchange/exchange.go b/exchange/exchange.go
index ffd3b2e8..b9dae672 100644
--- a/exchange/exchange.go
+++ b/exchange/exchange.go
@@ -1247,12 +1247,12 @@ func (e *exchange) makeBid(bids []*entities.PbsOrtbBid, auc *auction, returnCrea
 	for _, bid := range bids {
 		if !dsa.Validate(bidRequest, bid) {
 			RequiredError := openrtb_ext.ExtBidderMessage{
-				Code:    errortypes.BadServerResponseErrorCode,
-				Message: "bidResponse rejected: DSA object missing when required",
+				Code:    errortypes.InvalidBidResponseDSAWarningCode,
+				Message: "bid response rejected: DSA object missing when required",
 			}
 			bidResponseExt.Warnings[adapter] = append(bidResponseExt.Warnings[adapter], RequiredError)
 
-			seatNonBids.addBid(bid, int(ResponseRejectedPrivacy), adapter.String())
+			seatNonBids.addBid(bid, int(ResponseRejectedGeneral), adapter.String())
 			continue // Don't add bid to result
 		}
 		if e.bidValidationEnforcement.BannerCreativeMaxSize == config.ValidationEnforce && bid.BidType == openrtb_ext.BidTypeBanner {
diff --git a/exchange/non_bid_reason.go b/exchange/non_bid_reason.go
index f105d0ad..2dff2dfb 100644
--- a/exchange/non_bid_reason.go
+++ b/exchange/non_bid_reason.go
@@ -6,9 +6,9 @@ package exchange
 type NonBidReason int
 
 const (
-	NoBidUnknownError                      NonBidReason = 0   // No Bid - General
+	NoBidUnknownError                      NonBidReason = 0 // No Bid - General
+	ResponseRejectedGeneral                NonBidReason = 300
 	ResponseRejectedCategoryMappingInvalid NonBidReason = 303 // Response Rejected - Category Mapping Invalid
-	ResponseRejectedPrivacy                NonBidReason = 305
 	ResponseRejectedCreativeSizeNotAllowed NonBidReason = 351 // Response Rejected - Invalid Creative (Size Not Allowed)
 	ResponseRejectedCreativeNotSecure      NonBidReason = 352 // Response Rejected - Invalid Creative (Not Secure)
 )


Test patch:
diff --git a/exchange/exchange_test.go b/exchange/exchange_test.go
index 44baaf8d..e484e21a 100644
--- a/exchange/exchange_test.go
+++ b/exchange/exchange_test.go
@@ -4765,7 +4765,7 @@ func TestMakeBidWithValidation(t *testing.T) {
 				seatNonBidsMap: map[string][]openrtb_ext.NonBid{
 					"pubmatic": {
 						{
-							StatusCode: 305,
+							StatusCode: 300,
 							Ext: openrtb_ext.NonBidExt{
 								Prebid: openrtb_ext.ExtResponseNonBidPrebid{
 									Bid: openrtb_ext.NonBidObject{},
Repository: hyperledger/firefly
Pull request #942 (2022-08-08 20:38:59)

Advertise full node name (with suffix) to DX
Depends on https://github.com/hyperledger/firefly-dataexchange-https/pull/67


Patch:
diff --git a/internal/dataexchange/ffdx/ffdx.go b/internal/dataexchange/ffdx/ffdx.go
index 6317a8f8a..12e79b4b4 100644
--- a/internal/dataexchange/ffdx/ffdx.go
+++ b/internal/dataexchange/ffdx/ffdx.go
@@ -251,11 +251,7 @@ func (h *FFDX) checkInitialized(ctx context.Context) error {
 }
 
 func (h *FFDX) GetPeerID(peer fftypes.JSONObject) string {
-	id := peer.GetString("nodeID")
-	if id == "" {
-		id = peer.GetString("id")
-	}
-	return id
+	return peer.GetString("id")
 }
 
 func (h *FFDX) GetEndpointInfo(ctx context.Context, nodeName string) (peer fftypes.JSONObject, err error) {
@@ -270,7 +266,7 @@ func (h *FFDX) GetEndpointInfo(ctx context.Context, nodeName string) (peer fftyp
 		log.L(ctx).Errorf("Invalid DX info: %s", peer.String())
 		return nil, i18n.NewError(ctx, coremsgs.MsgDXInfoMissingID)
 	}
-	peer["nodeID"] = fmt.Sprintf("%s%s%s", id, DXIDSeparator, nodeName)
+	peer["id"] = fmt.Sprintf("%s%s%s", id, DXIDSeparator, nodeName)
 	return peer, nil
 }
 
diff --git a/manifest.json b/manifest.json
index 48ce43099..fe46a43d3 100644
--- a/manifest.json
+++ b/manifest.json
@@ -11,8 +11,8 @@
   },
   "dataexchange-https": {
     "image": "ghcr.io/hyperledger/firefly-dataexchange-https",
-    "tag": "v1.0.0-20220801-11",
-    "sha": "f113ccbd1ad166c3a382ec744af93b0701e1741fc97be2f4c60c3edb29767570"
+    "tag": "v1.0.0-20220810-13",
+    "sha": "3d6ae0c37065c590ed872c96b004854fa1bf89c52b8a5c1fca676d6bb4bf31d6"
   },
   "tokens-erc1155": {
     "image": "ghcr.io/hyperledger/firefly-tokens-erc1155",


Test patch:
diff --git a/internal/dataexchange/ffdx/ffdx_test.go b/internal/dataexchange/ffdx/ffdx_test.go
index 46e09784c..86542474f 100644
--- a/internal/dataexchange/ffdx/ffdx_test.go
+++ b/internal/dataexchange/ffdx/ffdx_test.go
@@ -155,8 +155,7 @@ func TestGetEndpointInfo(t *testing.T) {
 	peer, err := h.GetEndpointInfo(context.Background(), "node1")
 	assert.NoError(t, err)
 	assert.Equal(t, fftypes.JSONObject{
-		"nodeID":   "peer1/node1",
-		"id":       "peer1",
+		"id":       "peer1/node1",
 		"endpoint": "https://peer1.example.com",
 		"cert":     "cert data...",
 	}, peer)
Repository: hyperledger/firefly
Pull request #946 (2022-08-10 00:00:27)

Add deprecation warning for old node config


Patch:
diff --git a/internal/namespace/manager.go b/internal/namespace/manager.go
index 2dca5d5a0..e82ad3e98 100644
--- a/internal/namespace/manager.go
+++ b/internal/namespace/manager.go
@@ -811,6 +811,9 @@ func (nm *namespaceManager) loadNamespace(ctx context.Context, name string, inde
 	if deprecatedOrgName != "" || deprecatedOrgKey != "" || deprecatedOrgDesc != "" {
 		log.L(ctx).Warnf("Your org config uses a deprecated configuration structure - the org configuration has been moved under the 'namespaces.predefined[].multiparty' section")
 	}
+	if deprecatedNodeName != "" || deprecatedNodeDesc != "" {
+		log.L(ctx).Warnf("Your node config uses a deprecated configuration structure - the node configuration has been moved under the 'namespaces.predefined[].multiparty' section")
+	}
 	if orgName == "" {
 		orgName = deprecatedOrgName
 	}


Test patch:
diff --git a/internal/namespace/manager_test.go b/internal/namespace/manager_test.go
index ae9e02a93..e2b2e9fbc 100644
--- a/internal/namespace/manager_test.go
+++ b/internal/namespace/manager_test.go
@@ -1251,6 +1251,8 @@ func TestLoadNamespacesUseDefaults(t *testing.T) {
     - name: ns1
   org:
     name: org1
+  node:
+    name: node1
   `))
 	assert.NoError(t, err)