Repository: eslint/eslint
Pull request #8358 (2017-03-29 20:02:33)

Fix: don't modify operator precedence in operator-assignment autofixer
**What is the purpose of this pull request? (put an "X" next to item)**

[x] Bug fix

**Tell us about your environment**

* **ESLint Version:** master
* **Node Version:** 7.8.0
* **npm Version:** 4.2.0

**What parser (default, Babel-ESLint, etc.) are you using?**

default

**Please show your full configuration:**

```yml
rules:
  operator-assignment: [error, never]
```

**What did you do? Please include the actual source code causing the issue.**

```js
foo *= bar + baz
```

**What did you expect to happen?**

I expected the code to be autofixed to

```js
foo = foo * (bar + baz)
```

**What actually happened? Please include the actual, raw output from ESLint.**

The code was autofixed to

```js
foo = foo * bar + baz
```

<!--
    If the item you've checked above has a template, please paste the template questions below and answer them. (If this pull request is addressing an issue, you can just paste a link to the issue here instead.)
-->

<!--
    Please ensure your pull request is ready:

    - Read the pull request guide (http://eslint.org/docs/developer-guide/contributing/pull-requests)
    - Include tests for this change
    - Update documentation for this change (if appropriate)
-->

<!--
    The following is required for all pull requests:
-->

**What changes did you make? (Give an overview)**

Previously, the operator-assignment autofixer could sometimes modify semantics or produce a syntax error due to different operator precedence. This commit updates the fixer to surround the right side of an assignment with parentheses if it has lower precedence than its new neighbor.

**Is there anything you'd like reviewers to focus on?**

Nothing in particular

eslintbot: LGTM
eslintbot: LGTM

Patch:
diff --git a/README.md b/README.md
index a08f276fc..1ccdbb9bf 100644
--- a/README.md
+++ b/README.md
@@ -130,6 +130,7 @@ These folks keep the project moving and are resources for help.
 * Kevin Partington ([@platinumazure](https://github.com/platinumazure))
 * Vitor Balocco ([@vitorbal](https://github.com/vitorbal))
 * James Henry ([@JamesHenry](https://github.com/JamesHenry))
+* Reyad Attiyat ([@soda0289](https://github.com/soda0289))
 
 ## Releases
 
diff --git a/docs/rules/linebreak-style.md b/docs/rules/linebreak-style.md
index 9b7580e00..96f6c9f50 100644
--- a/docs/rules/linebreak-style.md
+++ b/docs/rules/linebreak-style.md
@@ -67,9 +67,19 @@ function foo(params) { // \r\n
 } // \r\n
 ```
 
+## Using this rule with version control systems
+
+Version control systems sometimes have special behavior for linebreaks. To make it easy for developers to contribute to your codebase from different platforms, you may want to configure your VCS to handle linebreaks appropriately.
+
+For example, the default behavior of [git](https://git-scm.com/) on Windows systems is to convert LF linebreaks to CRLF when checking out files, but to store the linebreaks as LF when committing a change. This will cause the `linebreak-style` rule to report errors if configured with the `"unix"` setting, because the files that ESLint sees will have CRLF linebreaks. If you use git, you may want to add a line to your [`.gitattributes` file](https://git-scm.com/docs/gitattributes) to prevent git from converting linebreaks in `.js` files:
+
+```
+*.js text eol=lf
+```
+
 ## When Not To Use It
 
-If you aren't concerned about having different line endings within you code, then you can safely turn this rule off.
+If you aren't concerned about having different line endings within your code, then you can safely turn this rule off.
 
 ## Compatibility
 
diff --git a/lib/config/plugins.js b/lib/config/plugins.js
index 5073d564a..e28a77929 100644
--- a/lib/config/plugins.js
+++ b/lib/config/plugins.js
@@ -127,14 +127,25 @@ module.exports = {
         if (!plugins[shortName]) {
             try {
                 plugin = require(longName);
-            } catch (err) {
-                debug(`Failed to load plugin ${longName}.`);
-                err.message = `Failed to load plugin ${pluginName}: ${err.message}`;
-                err.messageTemplate = "plugin-missing";
-                err.messageData = {
-                    pluginName: longName
-                };
-                throw err;
+            } catch (pluginLoadErr) {
+                try {
+
+                    // Check whether the plugin exists
+                    require.resolve(longName);
+                } catch (missingPluginErr) {
+
+                    // If the plugin can't be resolved, display the missing plugin error (usually a config or install error)
+                    debug(`Failed to load plugin ${longName}.`);
+                    missingPluginErr.message = `Failed to load plugin ${pluginName}: ${missingPluginErr.message}`;
+                    missingPluginErr.messageTemplate = "plugin-missing";
+                    missingPluginErr.messageData = {
+                        pluginName: longName
+                    };
+                    throw missingPluginErr;
+                }
+
+                // Otherwise, the plugin exists and is throwing on module load for some reason, so print the stack trace.
+                throw pluginLoadErr;
             }
 
             this.define(pluginName, plugin);
diff --git a/lib/rules/no-native-reassign.js b/lib/rules/no-native-reassign.js
index f721fc278..d3dfefbaf 100644
--- a/lib/rules/no-native-reassign.js
+++ b/lib/rules/no-native-reassign.js
@@ -15,7 +15,7 @@ module.exports = {
         docs: {
             description: "disallow assignments to native objects or read-only global variables",
             category: "Best Practices",
-            recommended: true,
+            recommended: false,
             replacedBy: ["no-global-assign"]
         },
 
diff --git a/lib/rules/no-negated-in-lhs.js b/lib/rules/no-negated-in-lhs.js
index 143518060..495cbc160 100644
--- a/lib/rules/no-negated-in-lhs.js
+++ b/lib/rules/no-negated-in-lhs.js
@@ -15,7 +15,7 @@ module.exports = {
         docs: {
             description: "disallow negating the left operand in `in` expressions",
             category: "Possible Errors",
-            recommended: true,
+            recommended: false,
             replacedBy: ["no-unsafe-negation"]
         },
         deprecated: true,
diff --git a/lib/rules/no-unsafe-negation.js b/lib/rules/no-unsafe-negation.js
index 4e2378d4d..761dc0338 100644
--- a/lib/rules/no-unsafe-negation.js
+++ b/lib/rules/no-unsafe-negation.js
@@ -44,7 +44,7 @@ module.exports = {
         docs: {
             description: "disallow negating the left operand of relational operators",
             category: "Possible Errors",
-            recommended: false
+            recommended: true
         },
         schema: [],
         fixable: "code"
diff --git a/lib/rules/operator-assignment.js b/lib/rules/operator-assignment.js
index 1c40eed15..99cca356f 100644
--- a/lib/rules/operator-assignment.js
+++ b/lib/rules/operator-assignment.js
@@ -4,6 +4,12 @@
  */
 "use strict";
 
+//------------------------------------------------------------------------------
+// Requirements
+//------------------------------------------------------------------------------
+
+const astUtils = require("../ast-utils");
+
 //------------------------------------------------------------------------------
 // Helpers
 //------------------------------------------------------------------------------
@@ -171,9 +177,20 @@ module.exports = {
                         if (canBeFixed(node.left)) {
                             const operatorToken = getOperatorToken(node);
                             const leftText = sourceCode.getText().slice(node.range[0], operatorToken.range[0]);
-                            const rightText = sourceCode.getText().slice(operatorToken.range[1], node.range[1]);
+                            const newOperator = node.operator.slice(0, -1);
+                            let rightText;
+
+                            // If this change would modify precedence (e.g. `foo *= bar + 1` => `foo = foo * (bar + 1)`), parenthesize the right side.
+                            if (
+                                astUtils.getPrecedence(node.right) <= astUtils.getPrecedence({ type: "BinaryExpression", operator: newOperator }) &&
+                                !astUtils.isParenthesised(sourceCode, node.right)
+                            ) {
+                                rightText = `${sourceCode.text.slice(operatorToken.range[1], node.right.range[0])}(${sourceCode.getText(node.right)})`;
+                            } else {
+                                rightText = sourceCode.text.slice(operatorToken.range[1], node.range[1]);
+                            }
 
-                            return fixer.replaceText(node, `${leftText}= ${leftText}${node.operator.slice(0, -1)}${rightText}`);
+                            return fixer.replaceText(node, `${leftText}= ${leftText}${newOperator}${rightText}`);
                         }
                         return null;
                     }
diff --git a/lib/rules/prefer-const.js b/lib/rules/prefer-const.js
index 07d8da82a..53bdc2ab7 100644
--- a/lib/rules/prefer-const.js
+++ b/lib/rules/prefer-const.js
@@ -9,7 +9,7 @@
 // Helpers
 //------------------------------------------------------------------------------
 
-const PATTERN_TYPE = /^(?:.+?Pattern|RestElement|Property)$/;
+const PATTERN_TYPE = /^(?:.+?Pattern|RestElement|SpreadProperty|ExperimentalRestProperty|Property)$/;
 const DECLARATION_HOST_TYPE = /^(?:Program|BlockStatement|SwitchCase)$/;
 const DESTRUCTURING_HOST_TYPE = /^(?:VariableDeclarator|AssignmentExpression)$/;
 
diff --git a/lib/util/glob-util.js b/lib/util/glob-util.js
index d414f783f..4c21fc551 100644
--- a/lib/util/glob-util.js
+++ b/lib/util/glob-util.js
@@ -86,7 +86,7 @@ function resolveFileGlobPatterns(patterns, options) {
 
     const processPathExtensions = processPath(options);
 
-    return patterns.map(processPathExtensions);
+    return patterns.filter(p => p.length).map(processPathExtensions);
 }
 
 /**


Test patch:
diff --git a/tests/fixtures/parsers/babel-eslint5/destructuring-object-spread.js b/tests/fixtures/parsers/babel-eslint5/destructuring-object-spread.js
new file mode 100644
index 000000000..985446c22
--- /dev/null
+++ b/tests/fixtures/parsers/babel-eslint5/destructuring-object-spread.js
@@ -0,0 +1,1726 @@
+"use strict";
+
+// The AST from babel-eslint version 5.x, for the following code:
+//
+//     let { name, ...otherStuff } = obj; otherStuff = {};
+//
+
+exports.parse = function() {
+    return {
+        type: "Program",
+        start: 0,
+        end: 53,
+        loc: {
+            start: {
+                line: 1,
+                column: 0
+            },
+            end: {
+                line: 3,
+                column: 0
+            }
+        },
+        sourceType: "module",
+        body: [
+            {
+                type: "VariableDeclaration",
+                start: 0,
+                end: 34,
+                loc: {
+                    start: {
+                        line: 1,
+                        column: 0
+                    },
+                    end: {
+                        line: 1,
+                        column: 34
+                    }
+                },
+                declarations: [
+                    {
+                        type: "VariableDeclarator",
+                        start: 4,
+                        end: 33,
+                        loc: {
+                            start: {
+                                line: 1,
+                                column: 4
+                            },
+                            end: {
+                                line: 1,
+                                column: 33
+                            }
+                        },
+                        id: {
+                            type: "ObjectPattern",
+                            start: 4,
+                            end: 27,
+                            loc: {
+                                start: {
+                                    line: 1,
+                                    column: 4
+                                },
+                                end: {
+                                    line: 1,
+                                    column: 27
+                                }
+                            },
+                            properties: [
+                                {
+                                    type: "Property",
+                                    start: 6,
+                                    end: 10,
+                                    loc: {
+                                        start: {
+                                            line: 1,
+                                            column: 6
+                                        },
+                                        end: {
+                                            line: 1,
+                                            column: 10
+                                        }
+                                    },
+                                    method: false,
+                                    shorthand: true,
+                                    computed: false,
+                                    key: {
+                                        type: "Identifier",
+                                        start: 6,
+                                        end: 10,
+                                        loc: {
+                                            start: {
+                                                line: 1,
+                                                column: 6
+                                            },
+                                            end: {
+                                                line: 1,
+                                                column: 10
+                                            }
+                                        },
+                                        name: "name",
+                                        range: [
+                                            6,
+                                            10
+                                        ],
+                                        _babelType: "Identifier"
+                                    },
+                                    kind: "init",
+                                    value: {
+                                        type: "Identifier",
+                                        start: 6,
+                                        end: 10,
+                                        loc: {
+                                            start: {
+                                                line: 1,
+                                                column: 6
+                                            },
+                                            end: {
+                                                line: 1,
+                                                column: 10
+                                            }
+                                        },
+                                        name: "name",
+                                        range: [
+                                            6,
+                                            10
+                                        ],
+                                        _babelType: "Identifier"
+                                    },
+                                    range: [
+                                        6,
+                                        10
+                                    ],
+                                    _babelType: "Property"
+                                },
+                                {
+                                    type: "SpreadProperty",
+                                    start: 12,
+                                    end: 25,
+                                    loc: {
+                                        start: {
+                                            line: 1,
+                                            column: 12
+                                        },
+                                        end: {
+                                            line: 1,
+                                            column: 25
+                                        }
+                                    },
+                                    argument: {
+                                        type: "Identifier",
+                                        start: 15,
+                                        end: 25,
+                                        loc: {
+                                            start: {
+                                                line: 1,
+                                                column: 15
+                                            },
+                                            end: {
+                                                line: 1,
+                                                column: 25
+                                            }
+                                        },
+                                        name: "otherStuff",
+                                        range: [
+                                            15,
+                                            25
+                                        ],
+                                        _babelType: "Identifier"
+                                    },
+                                    range: [
+                                        12,
+                                        25
+                                    ],
+                                    _babelType: "SpreadProperty",
+                                    value: {
+                                        type: "Identifier",
+                                        start: 15,
+                                        end: 25,
+                                        loc: {
+                                            start: {
+                                                line: 1,
+                                                column: 15
+                                            },
+                                            end: {
+                                                line: 1,
+                                                column: 25
+                                            }
+                                        },
+                                        name: "otherStuff",
+                                        range: [
+                                            15,
+                                            25
+                                        ],
+                                        _babelType: "Identifier"
+                                    },
+                                    key: {
+                                        type: "Identifier",
+                                        start: 15,
+                                        end: 25,
+                                        loc: {
+                                            start: {
+                                                line: 1,
+                                                column: 15
+                                            },
+                                            end: {
+                                                line: 1,
+                                                column: 25
+                                            }
+                                        },
+                                        name: "otherStuff",
+                                        range: [
+                                            15,
+                                            25
+                                        ],
+                                        _babelType: "Identifier"
+                                    }
+                                }
+                            ],
+                            range: [
+                                4,
+                                27
+                            ],
+                            _babelType: "ObjectPattern"
+                        },
+                        init: {
+                            type: "Identifier",
+                            start: 30,
+                            end: 33,
+                            loc: {
+                                start: {
+                                    line: 1,
+                                    column: 30
+                                },
+                                end: {
+                                    line: 1,
+                                    column: 33
+                                }
+                            },
+                            name: "obj",
+                            range: [
+                                30,
+                                33
+                            ],
+                            _babelType: "Identifier"
+                        },
+                        range: [
+                            4,
+                            33
+                        ],
+                        _babelType: "VariableDeclarator"
+                    }
+                ],
+                kind: "let",
+                range: [
+                    0,
+                    34
+                ],
+                _babelType: "VariableDeclaration"
+            },
+            {
+                type: "ExpressionStatement",
+                start: 35,
+                end: 51,
+                loc: {
+                    start: {
+                        line: 1,
+                        column: 35
+                    },
+                    end: {
+                        line: 1,
+                        column: 51
+                    }
+                },
+                expression: {
+                    type: "AssignmentExpression",
+                    start: 35,
+                    end: 50,
+                    loc: {
+                        start: {
+                            line: 1,
+                            column: 35
+                        },
+                        end: {
+                            line: 1,
+                            column: 50
+                        }
+                    },
+                    operator: "=",
+                    left: {
+                        type: "Identifier",
+                        start: 35,
+                        end: 45,
+                        loc: {
+                            start: {
+                                line: 1,
+                                column: 35
+                            },
+                            end: {
+                                line: 1,
+                                column: 45
+                            }
+                        },
+                        name: "otherStuff",
+                        range: [
+                            35,
+                            45
+                        ],
+                        _babelType: "Identifier"
+                    },
+                    right: {
+                        type: "ObjectExpression",
+                        start: 48,
+                        end: 50,
+                        loc: {
+                            start: {
+                                line: 1,
+                                column: 48
+                            },
+                            end: {
+                                line: 1,
+                                column: 50
+                            }
+                        },
+                        properties: [],
+                        range: [
+                            48,
+                            50
+                        ],
+                        _babelType: "ObjectExpression"
+                    },
+                    range: [
+                        35,
+                        50
+                    ],
+                    _babelType: "AssignmentExpression"
+                },
+                range: [
+                    35,
+                    51
+                ],
+                _babelType: "ExpressionStatement"
+            }
+        ],
+        tokens: [
+            {
+                type: "Keyword",
+                value: "let",
+                start: 0,
+                end: 3,
+                loc: {
+                    start: {
+                        line: 1,
+                        column: 0
+                    },
+                    end: {
+                        line: 1,
+                        column: 3
+                    }
+                },
+                range: [
+                    0,
+                    3
+                ]
+            },
+            {
+                type: "Punctuator",
+                value: "{",
+                start: 4,
+                end: 5,
+                loc: {
+                    start: {
+                        line: 1,
+                        column: 4
+                    },
+                    end: {
+                        line: 1,
+                        column: 5
+                    }
+                },
+                range: [
+                    4,
+                    5
+                ]
+            },
+            {
+                type: "Identifier",
+                value: "name",
+                start: 6,
+                end: 10,
+                loc: {
+                    start: {
+                        line: 1,
+                        column: 6
+                    },
+                    end: {
+                        line: 1,
+                        column: 10
+                    }
+                },
+                range: [
+                    6,
+                    10
+                ]
+            },
+            {
+                type: "Punctuator",
+                value: ",",
+                start: 10,
+                end: 11,
+                loc: {
+                    start: {
+                        line: 1,
+                        column: 10
+                    },
+                    end: {
+                        line: 1,
+                        column: 11
+                    }
+                },
+                range: [
+                    10,
+                    11
+                ]
+            },
+            {
+                type: "Punctuator",
+                value: "...",
+                start: 12,
+                end: 15,
+                loc: {
+                    start: {
+                        line: 1,
+                        column: 12
+                    },
+                    end: {
+                        line: 1,
+                        column: 15
+                    }
+                },
+                range: [
+                    12,
+                    15
+                ]
+            },
+            {
+                type: "Identifier",
+                value: "otherStuff",
+                start: 15,
+                end: 25,
+                loc: {
+                    start: {
+                        line: 1,
+                        column: 15
+                    },
+                    end: {
+                        line: 1,
+                        column: 25
+                    }
+                },
+                range: [
+                    15,
+                    25
+                ]
+            },
+            {
+                type: "Punctuator",
+                value: "}",
+                start: 26,
+                end: 27,
+                loc: {
+                    start: {
+                        line: 1,
+                        column: 26
+                    },
+                    end: {
+                        line: 1,
+                        column: 27
+                    }
+                },
+                range: [
+                    26,
+                    27
+                ]
+            },
+            {
+                type: "Punctuator",
+                value: "=",
+                start: 28,
+                end: 29,
+                loc: {
+                    start: {
+                        line: 1,
+                        column: 28
+                    },
+                    end: {
+                        line: 1,
+                        column: 29
+                    }
+                },
+                range: [
+                    28,
+                    29
+                ]
+            },
+            {
+                type: "Identifier",
+                value: "obj",
+                start: 30,
+                end: 33,
+                loc: {
+                    start: {
+                        line: 1,
+                        column: 30
+                    },
+                    end: {
+                        line: 1,
+                        column: 33
+                    }
+                },
+                range: [
+                    30,
+                    33
+                ]
+            },
+            {
+                type: "Punctuator",
+                value: ";",
+                start: 33,
+                end: 34,
+                loc: {
+                    start: {
+                        line: 1,
+                        column: 33
+                    },
+                    end: {
+                        line: 1,
+                        column: 34
+                    }
+                },
+                range: [
+                    33,
+                    34
+                ]
+            },
+            {
+                type: "Identifier",
+                value: "otherStuff",
+                start: 35,
+                end: 45,
+                loc: {
+                    start: {
+                        line: 1,
+                        column: 35
+                    },
+                    end: {
+                        line: 1,
+                        column: 45
+                    }
+                },
+                range: [
+                    35,
+                    45
+                ]
+            },
+            {
+                type: "Punctuator",
+                value: "=",
+                start: 46,
+                end: 47,
+                loc: {
+                    start: {
+                        line: 1,
+                        column: 46
+                    },
+                    end: {
+                        line: 1,
+                        column: 47
+                    }
+                },
+                range: [
+                    46,
+                    47
+                ]
+            },
+            {
+                type: "Punctuator",
+                value: "{",
+                start: 48,
+                end: 49,
+                loc: {
+                    start: {
+                        line: 1,
+                        column: 48
+                    },
+                    end: {
+                        line: 1,
+                        column: 49
+                    }
+                },
+                range: [
+                    48,
+                    49
+                ]
+            },
+            {
+                type: "Punctuator",
+                value: "}",
+                start: 49,
+                end: 50,
+                loc: {
+                    start: {
+                        line: 1,
+                        column: 49
+                    },
+                    end: {
+                        line: 1,
+                        column: 50
+                    }
+                },
+                range: [
+                    49,
+                    50
+                ]
+            },
+            {
+                type: "Punctuator",
+                value: ";",
+                start: 50,
+                end: 51,
+                loc: {
+                    start: {
+                        line: 1,
+                        column: 50
+                    },
+                    end: {
+                        line: 1,
+                        column: 51
+                    }
+                },
+                range: [
+                    50,
+                    51
+                ]
+            },
+            {
+                type: {
+                    label: "eof",
+                    beforeExpr: false,
+                    startsExpr: false,
+                    rightAssociative: false,
+                    isLoop: false,
+                    isAssign: false,
+                    prefix: false,
+                    postfix: false,
+                    binop: null,
+                    updateContext: null
+                },
+                start: 53,
+                end: 53,
+                loc: {
+                    start: {
+                        line: 3,
+                        column: 0
+                    },
+                    end: {
+                        line: 3,
+                        column: 0
+                    }
+                },
+                range: [
+                    53,
+                    53
+                ]
+            }
+        ],
+        comments: [],
+        range: [
+            0,
+            53
+        ],
+        _paths: [
+            {
+                contexts: [],
+                parent: "[Circular ~]",
+                data: {},
+                shouldSkip: false,
+                shouldStop: false,
+                removed: false,
+                opts: {
+                    noScope: true,
+                    enter: [
+                        null
+                    ],
+                    exit: [
+                        null
+                    ],
+                    _exploded: true,
+                    _verified: true
+                },
+                skipKeys: {},
+                parentPath: null,
+                context: {
+                    queue: null,
+                    opts: {
+                        noScope: true,
+                        enter: [
+                            null
+                        ],
+                        exit: [
+                            null
+                        ],
+                        _exploded: true,
+                        _verified: true
+                    }
+                },
+                container: [
+                    {
+                        type: "VariableDeclaration",
+                        start: 0,
+                        end: 34,
+                        loc: {
+                            start: {
+                                line: 1,
+                                column: 0
+                            },
+                            end: {
+                                line: 1,
+                                column: 34
+                            }
+                        },
+                        declarations: [
+                            {
+                                type: "VariableDeclarator",
+                                start: 4,
+                                end: 33,
+                                loc: {
+                                    start: {
+                                        line: 1,
+                                        column: 4
+                                    },
+                                    end: {
+                                        line: 1,
+                                        column: 33
+                                    }
+                                },
+                                id: {
+                                    type: "ObjectPattern",
+                                    start: 4,
+                                    end: 27,
+                                    loc: {
+                                        start: {
+                                            line: 1,
+                                            column: 4
+                                        },
+                                        end: {
+                                            line: 1,
+                                            column: 27
+                                        }
+                                    },
+                                    properties: [
+                                        {
+                                            type: "Property",
+                                            start: 6,
+                                            end: 10,
+                                            loc: {
+                                                start: {
+                                                    line: 1,
+                                                    column: 6
+                                                },
+                                                end: {
+                                                    line: 1,
+                                                    column: 10
+                                                }
+                                            },
+                                            method: false,
+                                            shorthand: true,
+                                            computed: false,
+                                            key: {
+                                                type: "Identifier",
+                                                start: 6,
+                                                end: 10,
+                                                loc: {
+                                                    start: {
+                                                        line: 1,
+                                                        column: 6
+                                                    },
+                                                    end: {
+                                                        line: 1,
+                                                        column: 10
+                                                    }
+                                                },
+                                                name: "name",
+                                                range: [
+                                                    6,
+                                                    10
+                                                ],
+                                                _babelType: "Identifier"
+                                            },
+                                            kind: "init",
+                                            value: {
+                                                type: "Identifier",
+                                                start: 6,
+                                                end: 10,
+                                                loc: {
+                                                    start: {
+                                                        line: 1,
+                                                        column: 6
+                                                    },
+                                                    end: {
+                                                        line: 1,
+                                                        column: 10
+                                                    }
+                                                },
+                                                name: "name",
+                                                range: [
+                                                    6,
+                                                    10
+                                                ],
+                                                _babelType: "Identifier"
+                                            },
+                                            range: [
+                                                6,
+                                                10
+                                            ],
+                                            _babelType: "Property"
+                                        },
+                                        {
+                                            type: "SpreadProperty",
+                                            start: 12,
+                                            end: 25,
+                                            loc: {
+                                                start: {
+                                                    line: 1,
+                                                    column: 12
+                                                },
+                                                end: {
+                                                    line: 1,
+                                                    column: 25
+                                                }
+                                            },
+                                            argument: {
+                                                type: "Identifier",
+                                                start: 15,
+                                                end: 25,
+                                                loc: {
+                                                    start: {
+                                                        line: 1,
+                                                        column: 15
+                                                    },
+                                                    end: {
+                                                        line: 1,
+                                                        column: 25
+                                                    }
+                                                },
+                                                name: "otherStuff",
+                                                range: [
+                                                    15,
+                                                    25
+                                                ],
+                                                _babelType: "Identifier"
+                                            },
+                                            range: [
+                                                12,
+                                                25
+                                            ],
+                                            _babelType: "SpreadProperty",
+                                            value: {
+                                                type: "Identifier",
+                                                start: 15,
+                                                end: 25,
+                                                loc: {
+                                                    start: {
+                                                        line: 1,
+                                                        column: 15
+                                                    },
+                                                    end: {
+                                                        line: 1,
+                                                        column: 25
+                                                    }
+                                                },
+                                                name: "otherStuff",
+                                                range: [
+                                                    15,
+                                                    25
+                                                ],
+                                                _babelType: "Identifier"
+                                            },
+                                            key: {
+                                                type: "Identifier",
+                                                start: 15,
+                                                end: 25,
+                                                loc: {
+                                                    start: {
+                                                        line: 1,
+                                                        column: 15
+                                                    },
+                                                    end: {
+                                                        line: 1,
+                                                        column: 25
+                                                    }
+                                                },
+                                                name: "otherStuff",
+                                                range: [
+                                                    15,
+                                                    25
+                                                ],
+                                                _babelType: "Identifier"
+                                            }
+                                        }
+                                    ],
+                                    range: [
+                                        4,
+                                        27
+                                    ],
+                                    _babelType: "ObjectPattern"
+                                },
+                                init: {
+                                    type: "Identifier",
+                                    start: 30,
+                                    end: 33,
+                                    loc: {
+                                        start: {
+                                            line: 1,
+                                            column: 30
+                                        },
+                                        end: {
+                                            line: 1,
+                                            column: 33
+                                        }
+                                    },
+                                    name: "obj",
+                                    range: [
+                                        30,
+                                        33
+                                    ],
+                                    _babelType: "Identifier"
+                                },
+                                range: [
+                                    4,
+                                    33
+                                ],
+                                _babelType: "VariableDeclarator"
+                            }
+                        ],
+                        kind: "let",
+                        range: [
+                            0,
+                            34
+                        ],
+                        _babelType: "VariableDeclaration"
+                    },
+                    {
+                        type: "ExpressionStatement",
+                        start: 35,
+                        end: 51,
+                        loc: {
+                            start: {
+                                line: 1,
+                                column: 35
+                            },
+                            end: {
+                                line: 1,
+                                column: 51
+                            }
+                        },
+                        expression: {
+                            type: "AssignmentExpression",
+                            start: 35,
+                            end: 50,
+                            loc: {
+                                start: {
+                                    line: 1,
+                                    column: 35
+                                },
+                                end: {
+                                    line: 1,
+                                    column: 50
+                                }
+                            },
+                            operator: "=",
+                            left: {
+                                type: "Identifier",
+                                start: 35,
+                                end: 45,
+                                loc: {
+                                    start: {
+                                        line: 1,
+                                        column: 35
+                                    },
+                                    end: {
+                                        line: 1,
+                                        column: 45
+                                    }
+                                },
+                                name: "otherStuff",
+                                range: [
+                                    35,
+                                    45
+                                ],
+                                _babelType: "Identifier"
+                            },
+                            right: {
+                                type: "ObjectExpression",
+                                start: 48,
+                                end: 50,
+                                loc: {
+                                    start: {
+                                        line: 1,
+                                        column: 48
+                                    },
+                                    end: {
+                                        line: 1,
+                                        column: 50
+                                    }
+                                },
+                                properties: [],
+                                range: [
+                                    48,
+                                    50
+                                ],
+                                _babelType: "ObjectExpression"
+                            },
+                            range: [
+                                35,
+                                50
+                            ],
+                            _babelType: "AssignmentExpression"
+                        },
+                        range: [
+                            35,
+                            51
+                        ],
+                        _babelType: "ExpressionStatement"
+                    }
+                ],
+                listKey: "body",
+                inList: true,
+                parentKey: "body",
+                key: 0,
+                node: {
+                    type: "VariableDeclaration",
+                    start: 0,
+                    end: 34,
+                    loc: {
+                        start: {
+                            line: 1,
+                            column: 0
+                        },
+                        end: {
+                            line: 1,
+                            column: 34
+                        }
+                    },
+                    declarations: [
+                        {
+                            type: "VariableDeclarator",
+                            start: 4,
+                            end: 33,
+                            loc: {
+                                start: {
+                                    line: 1,
+                                    column: 4
+                                },
+                                end: {
+                                    line: 1,
+                                    column: 33
+                                }
+                            },
+                            id: {
+                                type: "ObjectPattern",
+                                start: 4,
+                                end: 27,
+                                loc: {
+                                    start: {
+                                        line: 1,
+                                        column: 4
+                                    },
+                                    end: {
+                                        line: 1,
+                                        column: 27
+                                    }
+                                },
+                                properties: [
+                                    {
+                                        type: "Property",
+                                        start: 6,
+                                        end: 10,
+                                        loc: {
+                                            start: {
+                                                line: 1,
+                                                column: 6
+                                            },
+                                            end: {
+                                                line: 1,
+                                                column: 10
+                                            }
+                                        },
+                                        method: false,
+                                        shorthand: true,
+                                        computed: false,
+                                        key: {
+                                            type: "Identifier",
+                                            start: 6,
+                                            end: 10,
+                                            loc: {
+                                                start: {
+                                                    line: 1,
+                                                    column: 6
+                                                },
+                                                end: {
+                                                    line: 1,
+                                                    column: 10
+                                                }
+                                            },
+                                            name: "name",
+                                            range: [
+                                                6,
+                                                10
+                                            ],
+                                            _babelType: "Identifier"
+                                        },
+                                        kind: "init",
+                                        value: {
+                                            type: "Identifier",
+                                            start: 6,
+                                            end: 10,
+                                            loc: {
+                                                start: {
+                                                    line: 1,
+                                                    column: 6
+                                                },
+                                                end: {
+                                                    line: 1,
+                                                    column: 10
+                                                }
+                                            },
+                                            name: "name",
+                                            range: [
+                                                6,
+                                                10
+                                            ],
+                                            _babelType: "Identifier"
+                                        },
+                                        range: [
+                                            6,
+                                            10
+                                        ],
+                                        _babelType: "Property"
+                                    },
+                                    {
+                                        type: "SpreadProperty",
+                                        start: 12,
+                                        end: 25,
+                                        loc: {
+                                            start: {
+                                                line: 1,
+                                                column: 12
+                                            },
+                                            end: {
+                                                line: 1,
+                                                column: 25
+                                            }
+                                        },
+                                        argument: {
+                                            type: "Identifier",
+                                            start: 15,
+                                            end: 25,
+                                            loc: {
+                                                start: {
+                                                    line: 1,
+                                                    column: 15
+                                                },
+                                                end: {
+                                                    line: 1,
+                                                    column: 25
+                                                }
+                                            },
+                                            name: "otherStuff",
+                                            range: [
+                                                15,
+                                                25
+                                            ],
+                                            _babelType: "Identifier"
+                                        },
+                                        range: [
+                                            12,
+                                            25
+                                        ],
+                                        _babelType: "SpreadProperty",
+                                        value: {
+                                            type: "Identifier",
+                                            start: 15,
+                                            end: 25,
+                                            loc: {
+                                                start: {
+                                                    line: 1,
+                                                    column: 15
+                                                },
+                                                end: {
+                                                    line: 1,
+                                                    column: 25
+                                                }
+                                            },
+                                            name: "otherStuff",
+                                            range: [
+                                                15,
+                                                25
+                                            ],
+                                            _babelType: "Identifier"
+                                        },
+                                        key: {
+                                            type: "Identifier",
+                                            start: 15,
+                                            end: 25,
+                                            loc: {
+                                                start: {
+                                                    line: 1,
+                                                    column: 15
+                                                },
+                                                end: {
+                                                    line: 1,
+                                                    column: 25
+                                                }
+                                            },
+                                            name: "otherStuff",
+                                            range: [
+                                                15,
+                                                25
+                                            ],
+                                            _babelType: "Identifier"
+                                        }
+                                    }
+                                ],
+                                range: [
+                                    4,
+                                    27
+                                ],
+                                _babelType: "ObjectPattern"
+                            },
+                            init: {
+                                type: "Identifier",
+                                start: 30,
+                                end: 33,
+                                loc: {
+                                    start: {
+                                        line: 1,
+                                        column: 30
+                                    },
+                                    end: {
+                                        line: 1,
+                                        column: 33
+                                    }
+                                },
+                                name: "obj",
+                                range: [
+                                    30,
+                                    33
+                                ],
+                                _babelType: "Identifier"
+                            },
+                            range: [
+                                4,
+                                33
+                            ],
+                            _babelType: "VariableDeclarator"
+                        }
+                    ],
+                    kind: "let",
+                    range: [
+                        0,
+                        34
+                    ],
+                    _babelType: "VariableDeclaration"
+                },
+                scope: null,
+                type: "VariableDeclaration",
+                typeAnnotation: null
+            },
+            {
+                contexts: [],
+                parent: "[Circular ~]",
+                data: {},
+                shouldSkip: false,
+                shouldStop: false,
+                removed: false,
+                opts: {
+                    noScope: true,
+                    enter: [
+                        null
+                    ],
+                    exit: [
+                        null
+                    ],
+                    _exploded: true,
+                    _verified: true
+                },
+                skipKeys: {},
+                parentPath: null,
+                context: {
+                    queue: null,
+                    opts: {
+                        noScope: true,
+                        enter: [
+                            null
+                        ],
+                        exit: [
+                            null
+                        ],
+                        _exploded: true,
+                        _verified: true
+                    }
+                },
+                container: [
+                    {
+                        type: "VariableDeclaration",
+                        start: 0,
+                        end: 34,
+                        loc: {
+                            start: {
+                                line: 1,
+                                column: 0
+                            },
+                            end: {
+                                line: 1,
+                                column: 34
+                            }
+                        },
+                        declarations: [
+                            {
+                                type: "VariableDeclarator",
+                                start: 4,
+                                end: 33,
+                                loc: {
+                                    start: {
+                                        line: 1,
+                                        column: 4
+                                    },
+                                    end: {
+                                        line: 1,
+                                        column: 33
+                                    }
+                                },
+                                id: {
+                                    type: "ObjectPattern",
+                                    start: 4,
+                                    end: 27,
+                                    loc: {
+                                        start: {
+                                            line: 1,
+                                            column: 4
+                                        },
+                                        end: {
+                                            line: 1,
+                                            column: 27
+                                        }
+                                    },
+                                    properties: [
+                                        {
+                                            type: "Property",
+                                            start: 6,
+                                            end: 10,
+                                            loc: {
+                                                start: {
+                                                    line: 1,
+                                                    column: 6
+                                                },
+                                                end: {
+                                                    line: 1,
+                                                    column: 10
+                                                }
+                                            },
+                                            method: false,
+                                            shorthand: true,
+                                            computed: false,
+                                            key: {
+                                                type: "Identifier",
+                                                start: 6,
+                                                end: 10,
+                                                loc: {
+                                                    start: {
+                                                        line: 1,
+                                                        column: 6
+                                                    },
+                                                    end: {
+                                                        line: 1,
+                                                        column: 10
+                                                    }
+                                                },
+                                                name: "name",
+                                                range: [
+                                                    6,
+                                                    10
+                                                ],
+                                                _babelType: "Identifier"
+                                            },
+                                            kind: "init",
+                                            value: {
+                                                type: "Identifier",
+                                                start: 6,
+                                                end: 10,
+                                                loc: {
+                                                    start: {
+                                                        line: 1,
+                                                        column: 6
+                                                    },
+                                                    end: {
+                                                        line: 1,
+                                                        column: 10
+                                                    }
+                                                },
+                                                name: "name",
+                                                range: [
+                                                    6,
+                                                    10
+                                                ],
+                                                _babelType: "Identifier"
+                                            },
+                                            range: [
+                                                6,
+                                                10
+                                            ],
+                                            _babelType: "Property"
+                                        },
+                                        {
+                                            type: "SpreadProperty",
+                                            start: 12,
+                                            end: 25,
+                                            loc: {
+                                                start: {
+                                                    line: 1,
+                                                    column: 12
+                                                },
+                                                end: {
+                                                    line: 1,
+                                                    column: 25
+                                                }
+                                            },
+                                            argument: {
+                                                type: "Identifier",
+                                                start: 15,
+                                                end: 25,
+                                                loc: {
+                                                    start: {
+                                                        line: 1,
+                                                        column: 15
+                                                    },
+                                                    end: {
+                                                        line: 1,
+                                                        column: 25
+                                                    }
+                                                },
+                                                name: "otherStuff",
+                                                range: [
+                                                    15,
+                                                    25
+                                                ],
+                                                _babelType: "Identifier"
+                                            },
+                                            range: [
+                                                12,
+                                                25
+                                            ],
+                                            _babelType: "SpreadProperty",
+                                            value: {
+                                                type: "Identifier",
+                                                start: 15,
+                                                end: 25,
+                                                loc: {
+                                                    start: {
+                                                        line: 1,
+                                                        column: 15
+                                                    },
+                                                    end: {
+                                                        line: 1,
+                                                        column: 25
+                                                    }
+                                                },
+                                                name: "otherStuff",
+                                                range: [
+                                                    15,
+                                                    25
+                                                ],
+                                                _babelType: "Identifier"
+                                            },
+                                            key: {
+                                                type: "Identifier",
+                                                start: 15,
+                                                end: 25,
+                                                loc: {
+                                                    start: {
+                                                        line: 1,
+                                                        column: 15
+                                                    },
+                                                    end: {
+                                                        line: 1,
+                                                        column: 25
+                                                    }
+                                                },
+                                                name: "otherStuff",
+                                                range: [
+                                                    15,
+                                                    25
+                                                ],
+                                                _babelType: "Identifier"
+                                            }
+                                        }
+                                    ],
+                                    range: [
+                                        4,
+                                        27
+                                    ],
+                                    _babelType: "ObjectPattern"
+                                },
+                                init: {
+                                    type: "Identifier",
+                                    start: 30,
+                                    end: 33,
+                                    loc: {
+                                        start: {
+                                            line: 1,
+                                            column: 30
+                                        },
+                                        end: {
+                                            line: 1,
+                                            column: 33
+                                        }
+                                    },
+                                    name: "obj",
+                                    range: [
+                                        30,
+                                        33
+                                    ],
+                                    _babelType: "Identifier"
+                                },
+                                range: [
+                                    4,
+                                    33
+                                ],
+                                _babelType: "VariableDeclarator"
+                            }
+                        ],
+                        kind: "let",
+                        range: [
+                            0,
+                            34
+                        ],
+                        _babelType: "VariableDeclaration"
+                    },
+                    {
+                        type: "ExpressionStatement",
+                        start: 35,
+                        end: 51,
+                        loc: {
+                            start: {
+                                line: 1,
+                                column: 35
+                            },
+                            end: {
+                                line: 1,
+                                column: 51
+                            }
+                        },
+                        expression: {
+                            type: "AssignmentExpression",
+                            start: 35,
+                            end: 50,
+                            loc: {
+                                start: {
+                                    line: 1,
+                                    column: 35
+                                },
+                                end: {
+                                    line: 1,
+                                    column: 50
+                                }
+                            },
+                            operator: "=",
+                            left: {
+                                type: "Identifier",
+                                start: 35,
+                                end: 45,
+                                loc: {
+                                    start: {
+                                        line: 1,
+                                        column: 35
+                                    },
+                                    end: {
+                                        line: 1,
+                                        column: 45
+                                    }
+                                },
+                                name: "otherStuff",
+                                range: [
+                                    35,
+                                    45
+                                ],
+                                _babelType: "Identifier"
+                            },
+                            right: {
+                                type: "ObjectExpression",
+                                start: 48,
+                                end: 50,
+                                loc: {
+                                    start: {
+                                        line: 1,
+                                        column: 48
+                                    },
+                                    end: {
+                                        line: 1,
+                                        column: 50
+                                    }
+                                },
+                                properties: [],
+                                range: [
+                                    48,
+                                    50
+                                ],
+                                _babelType: "ObjectExpression"
+                            },
+                            range: [
+                                35,
+                                50
+                            ],
+                            _babelType: "AssignmentExpression"
+                        },
+                        range: [
+                            35,
+                            51
+                        ],
+                        _babelType: "ExpressionStatement"
+                    }
+                ],
+                listKey: "body",
+                inList: true,
+                parentKey: "body",
+                key: 1,
+                node: {
+                    type: "ExpressionStatement",
+                    start: 35,
+                    end: 51,
+                    loc: {
+                        start: {
+                            line: 1,
+                            column: 35
+                        },
+                        end: {
+                            line: 1,
+                            column: 51
+                        }
+                    },
+                    expression: {
+                        type: "AssignmentExpression",
+                        start: 35,
+                        end: 50,
+                        loc: {
+                            start: {
+                                line: 1,
+                                column: 35
+                            },
+                            end: {
+                                line: 1,
+                                column: 50
+                            }
+                        },
+                        operator: "=",
+                        left: {
+                            type: "Identifier",
+                            start: 35,
+                            end: 45,
+                            loc: {
+                                start: {
+                                    line: 1,
+                                    column: 35
+                                },
+                                end: {
+                                    line: 1,
+                                    column: 45
+                                }
+                            },
+                            name: "otherStuff",
+                            range: [
+                                35,
+                                45
+                            ],
+                            _babelType: "Identifier"
+                        },
+                        right: {
+                            type: "ObjectExpression",
+                            start: 48,
+                            end: 50,
+                            loc: {
+                                start: {
+                                    line: 1,
+                                    column: 48
+                                },
+                                end: {
+                                    line: 1,
+                                    column: 50
+                                }
+                            },
+                            properties: [],
+                            range: [
+                                48,
+                                50
+                            ],
+                            _babelType: "ObjectExpression"
+                        },
+                        range: [
+                            35,
+                            50
+                        ],
+                        _babelType: "AssignmentExpression"
+                    },
+                    range: [
+                        35,
+                        51
+                    ],
+                    _babelType: "ExpressionStatement"
+                },
+                scope: null,
+                type: "ExpressionStatement",
+                typeAnnotation: null
+            }
+        ]
+    };
+};
diff --git a/tests/lib/config/plugins.js b/tests/lib/config/plugins.js
index 06b2bcd38..61b759797 100644
--- a/tests/lib/config/plugins.js
+++ b/tests/lib/config/plugins.js
@@ -43,7 +43,12 @@ describe("Plugins", () => {
                 "eslint-plugin-example": plugin,
                 "@scope/eslint-plugin-example": scopedPlugin,
                 "./environments": Environments,
-                "../rules": Rules
+                "../rules": Rules,
+                "eslint-plugin-throws-on-load": {
+                    get rules() {
+                        throw new Error("error thrown while loading this module");
+                    }
+                }
             });
         });
 
@@ -106,6 +111,21 @@ describe("Plugins", () => {
             }, /Failed to load plugin/);
         });
 
+        it("should rethrow an error that a plugin throws on load", () => {
+            try {
+                StubbedPlugins.load("throws-on-load");
+            } catch (err) {
+                assert.strictEqual(
+                    err.message,
+                    "error thrown while loading this module",
+                    "should rethrow the same error that was thrown on plugin load"
+                );
+
+                return;
+            }
+            assert.fail(null, null, "should throw an error if a plugin fails to load");
+        });
+
         it("should load a scoped plugin when referenced by short name", () => {
             StubbedPlugins.load("@scope/example");
             assert.equal(StubbedPlugins.get("@scope/example"), scopedPlugin);
diff --git a/tests/lib/rules/no-param-reassign.js b/tests/lib/rules/no-param-reassign.js
index caecb5adc..a98a6dfe1 100644
--- a/tests/lib/rules/no-param-reassign.js
+++ b/tests/lib/rules/no-param-reassign.js
@@ -37,7 +37,7 @@ ruleTester.run("no-param-reassign", rule, {
         { code: "function foo(a, z) { a.b = 0; x.y = 0; }", options: [{ props: true, ignorePropertyModificationsFor: ["a", "x"] }] },
         { code: "function foo(a) { a.b.c = 0;}", options: [{ props: true, ignorePropertyModificationsFor: ["a"] }] },
         {
-            code: "function foo(a) { ({ [a]: variable }) = value }",
+            code: "function foo(a) { ({ [a]: variable } = value) }",
             options: [{ props: true }],
             parserOptions: { ecmaVersion: 6 }
         }
diff --git a/tests/lib/rules/operator-assignment.js b/tests/lib/rules/operator-assignment.js
index 5e5e65564..fb1ff889e 100644
--- a/tests/lib/rules/operator-assignment.js
+++ b/tests/lib/rules/operator-assignment.js
@@ -81,7 +81,8 @@ ruleTester.run("operator-assignment", rule, {
         "x = x === y",
         "x = x !== y",
         "x = x && y",
-        "x = x || y"
+        "x = x || y",
+        "x = x * y + z"
     ],
 
     invalid: [{
@@ -214,6 +215,31 @@ ruleTester.run("operator-assignment", rule, {
         output: "foo = foo ** bar",
         options: ["never"],
         errors: UNEXPECTED_OPERATOR_ASSIGNMENT
+    }, {
+        code: "foo *= bar + 1",
+        output: "foo = foo * (bar + 1)",
+        options: ["never"],
+        errors: UNEXPECTED_OPERATOR_ASSIGNMENT
+    }, {
+        code: "foo -= bar - baz",
+        output: "foo = foo - (bar - baz)",
+        options: ["never"],
+        errors: UNEXPECTED_OPERATOR_ASSIGNMENT
+    }, {
+        code: "foo += bar + baz",
+        output: "foo = foo + (bar + baz)", // addition is not associative in JS, e.g. (1 + 2) + '3' !== 1 + (2 + '3')
+        options: ["never"],
+        errors: UNEXPECTED_OPERATOR_ASSIGNMENT
+    }, {
+        code: "foo += bar = 1",
+        output: "foo = foo + (bar = 1)",
+        options: ["never"],
+        errors: UNEXPECTED_OPERATOR_ASSIGNMENT
+    }, {
+        code: "foo *= (bar + 1)",
+        output: "foo = foo * (bar + 1)",
+        options: ["never"],
+        errors: UNEXPECTED_OPERATOR_ASSIGNMENT
     }]
 
 });
diff --git a/tests/lib/rules/prefer-const.js b/tests/lib/rules/prefer-const.js
index 75821f95a..984649cb4 100644
--- a/tests/lib/rules/prefer-const.js
+++ b/tests/lib/rules/prefer-const.js
@@ -10,6 +10,7 @@
 //------------------------------------------------------------------------------
 
 const rule = require("../../../lib/rules/prefer-const"),
+    fixtureParser = require("../../fixtures/fixture-parser"),
     RuleTester = require("../../../lib/testers/rule-tester");
 
 //------------------------------------------------------------------------------
@@ -88,6 +89,18 @@ ruleTester.run("prefer-const", rule, {
             options: [{ destructuring: "all" }]
         },
 
+        // https://github.com/eslint/eslint/issues/8187
+        {
+            code: "let { name, ...otherStuff } = obj; otherStuff = {};",
+            options: [{ destructuring: "all" }],
+            parserOptions: { ecmaFeatures: { experimentalObjectRestSpread: true } }
+        },
+        {
+            code: "let { name, ...otherStuff } = obj; otherStuff = {};",
+            options: [{ destructuring: "all" }],
+            parser: fixtureParser("babel-eslint5/destructuring-object-spread")
+        },
+
         // ignoreReadBeforeAssign
         {
             code: "let x; function foo() { bar(x); } x = 0;",
@@ -290,6 +303,22 @@ ruleTester.run("prefer-const", rule, {
             errors: [{ message: "'c' is never reassigned. Use 'const' instead.", type: "Identifier" }]
         },
 
+        // https://github.com/eslint/eslint/issues/8187
+        {
+            code: "let { name, ...otherStuff } = obj; otherStuff = {};",
+            output: null,
+            options: [{ destructuring: "any" }],
+            parserOptions: { ecmaFeatures: { experimentalObjectRestSpread: true } },
+            errors: [{ message: "'name' is never reassigned. Use 'const' instead.", type: "Identifier", column: 7 }]
+        },
+        {
+            code: "let { name, ...otherStuff } = obj; otherStuff = {};",
+            output: null,
+            options: [{ destructuring: "any" }],
+            parser: fixtureParser("babel-eslint5/destructuring-object-spread"),
+            errors: [{ message: "'name' is never reassigned. Use 'const' instead.", type: "Identifier", column: 7 }]
+        },
+
         // Warnings are located at declaration if there are reading references before assignments.
         {
             code: "let x; function foo() { bar(x); } x = 0;",
diff --git a/tests/lib/util/glob-util.js b/tests/lib/util/glob-util.js
index 452ca06b2..47175848f 100644
--- a/tests/lib/util/glob-util.js
+++ b/tests/lib/util/glob-util.js
@@ -144,6 +144,16 @@ describe("globUtil", () => {
             assert.deepEqual(result, ["one-js-file/example.js"]);
         });
 
+        it("should ignore empty patterns", () => {
+            const patterns = [""];
+            const opts = {
+                cwd: getFixturePath()
+            };
+            const result = globUtil.resolveFileGlobPatterns(patterns, opts);
+
+            assert.deepEqual(result, []);
+        });
+
     });
 
     describe("listFilesToProcess()", () => {