Repository: knative/client
Pull request #1391 (2021-07-20 01:44:12)

[main] Upgrade to latest dependencies
Cron -knative-prow-robot

/cc knative/client-wg-leads
/assign knative/client-wg-leads

Produced by: knative-sandbox/knobots/actions/update-deps

Details:
```
bumping knative.dev/serving ee022f4...11abffd:
  > 11abffd Update net-istio nightly (# 11702)
  > fe60cdd add tests for kubernetes.containerspec-addcapabilities feature flag (# 11700)
  > 1ec1414 Update net-kourier nightly (# 11696)
  > 2575a92 Update net-certmanager nightly (# 11697)
bumping knative.dev/eventing 25bd8ef...003a8a2:
  > 003a8a2 upgrade to latest dependencies (# 5595)
  > 48112db Change Result->Reply in comments, left over cruft (# 5600)
```

knative-prow-robot: [APPROVALNOTIFIER] This PR is **NOT APPROVED**

This pull-request has been approved by: *<a href="https://github.com/knative/client/pull/1391#" title="Author self-approved">knative-automation</a>*
To complete the [pull request process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process), please assign **navidshaikh** after the PR has been reviewed.
You can assign the PR to them by writing `/assign @navidshaikh` in a comment when ready.

The full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=knative%2Fclient).

<details open>
Needs approval from an approver in each of these files:

- **[OWNERS](https://github.com/knative/client/blob/main/OWNERS)**

Approvers can indicate their approval by writing `/approve` in a comment
Approvers can cancel approval by writing `/approve cancel` in a comment
</details>
<!-- META={"approvers":["navidshaikh"]} -->
codecov[bot]: # [Codecov](https://codecov.io/gh/knative/client/pull/1391?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=knative) Report
> Merging [#1391](https://codecov.io/gh/knative/client/pull/1391?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=knative) (948c7bb) into [main](https://codecov.io/gh/knative/client/commit/2164243458b53414dcf95c6b349c85245596cd66?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=knative) (2164243) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/knative/client/pull/1391/graphs/tree.svg?width=650&height=150&src=pr&token=bkTp6BzJiV&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=knative)](https://codecov.io/gh/knative/client/pull/1391?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=knative)

```diff
@@           Coverage Diff           @@
##             main    #1391   +/-   ##
=======================================
  Coverage   76.51%   76.51%           
=======================================
  Files         160      160           
  Lines        8234     8234           
=======================================
  Hits         6300     6300           
  Misses       1229     1229           
  Partials      705      705           
```



------

[Continue to review full report at Codecov](https://codecov.io/gh/knative/client/pull/1391?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=knative).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=knative)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/knative/client/pull/1391?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=knative). Last update [2164243...948c7bb](https://codecov.io/gh/knative/client/pull/1391?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=knative). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=knative).

knative-prow-robot: @knative-automation: The following test **failed**, say `/retest` to rerun all failed tests or `/retest-required` to rerun all mandatory failed tests:

Test name | Commit | Details | Rerun command
--- | --- | --- | ---
pull-knative-client-integration-tests-latest-release | 0e5720026b355318217e895eaceb34ae94fe7bae | [link](https://prow.knative.dev/view/gs/knative-prow/pr-logs/pull/knative_client/1391/pull-knative-client-integration-tests-latest-release/1417661920093147136) | `/test pull-knative-client-integration-tests-latest-release`

[Full PR test history](https://gubernator.knative.dev/pr/knative_client/1391). [Your PR dashboard](https://gubernator.knative.dev/pr/knative-automation).

<details>

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
</details>
<!-- test report -->

Patch:
diff --git a/OWNERS_ALIASES b/OWNERS_ALIASES
index e6538dd7..7e6d3221 100644
--- a/OWNERS_ALIASES
+++ b/OWNERS_ALIASES
@@ -54,7 +54,6 @@ aliases:
   eventing-wg-leads:
   - devguyio
   - lionelvillard
-  - vaikas
   eventing-writers:
   - akashrv
   - aliok
@@ -65,7 +64,6 @@ aliases:
   - matzew
   - n3wscott
   - pierDipi
-  - vaikas
   knative-admin:
   - RichieEscarez
   - bsnchan
diff --git a/cmd/kn/main.go b/cmd/kn/main.go
index dc3d6780..5eac2913 100644
--- a/cmd/kn/main.go
+++ b/cmd/kn/main.go
@@ -193,7 +193,7 @@ func printError(err error) {
 // by checking a pattern like 'kn service' in the error message. If not found, return the
 // base command name.
 func extractCommandPathFromErrorMessage(errorMsg string, arg0 string) string {
-	extractPattern := regexp.MustCompile(fmt.Sprintf("'(%s\\s.+?)'", arg0))
+	extractPattern := regexp.MustCompile(fmt.Sprintf("'(%s\\s.+?)'", regexp.QuoteMeta(arg0)))
 	command := extractPattern.FindSubmatch([]byte(errorMsg))
 	if command != nil {
 		return string(command[1])
diff --git a/go.mod b/go.mod
index 181dbb5a..313c17dc 100644
--- a/go.mod
+++ b/go.mod
@@ -18,11 +18,11 @@ require (
 	k8s.io/cli-runtime v0.20.7
 	k8s.io/client-go v0.20.7
 	k8s.io/code-generator v0.20.7
-	knative.dev/eventing v0.24.1-0.20210714200632-25bd8efb7179
+	knative.dev/eventing v0.24.1-0.20210720191312-003a8a2d4ef5
 	knative.dev/hack v0.0.0-20210622141627-e28525d8d260
 	knative.dev/networking v0.0.0-20210719003653-7390d8cf09e3
 	knative.dev/pkg v0.0.0-20210715175632-d9b7180af6f2
-	knative.dev/serving v0.24.1-0.20210719094053-ee022f47dadd
+	knative.dev/serving v0.24.1-0.20210721125539-11abffdc6f0d
 	sigs.k8s.io/yaml v1.2.0
 )
 
diff --git a/go.sum b/go.sum
index 3932af35..632824f3 100644
--- a/go.sum
+++ b/go.sum
@@ -1630,22 +1630,21 @@ k8s.io/utils v0.0.0-20201110183641-67b214c5f920/go.mod h1:jPW/WVKK9YHAvNhRxK0md/
 k8s.io/utils v0.0.0-20210111153108-fddb29f9d009 h1:0T5IaWHO3sJTEmCP6mUlBvMukxPKUQWqiI/YuiBNMiQ=
 k8s.io/utils v0.0.0-20210111153108-fddb29f9d009/go.mod h1:jPW/WVKK9YHAvNhRxK0md/EJ228hCsBRufyofKtW8HA=
 knative.dev/caching v0.0.0-20210715062632-201766006aee/go.mod h1:eXLaNJZlrpZRCDqx+KnS1GqS3uED4+fEUDKZkmh5QWU=
-knative.dev/eventing v0.24.1-0.20210714200632-25bd8efb7179 h1:Woxh2PxduptsCQk0DGuGh1Ly89hAgIR3nnMD+1NLSLw=
-knative.dev/eventing v0.24.1-0.20210714200632-25bd8efb7179/go.mod h1:IgKlFOoi1SgLJP6Vje8HTD+rBPnnDT6QenW8i0tkuD4=
+knative.dev/eventing v0.24.1-0.20210720191312-003a8a2d4ef5 h1:12mJt7L8s+qzlR+Gb14mKioELrK7A+GOFGL4jCvng6Y=
+knative.dev/eventing v0.24.1-0.20210720191312-003a8a2d4ef5/go.mod h1:RhRbB4NJUWNSAsktOPy5buIuzDWfZik3wVEG533PrQA=
 knative.dev/hack v0.0.0-20210622141627-e28525d8d260 h1:f2eMtOubAOc/Q7JlvFPDKXiPlJVK+VpX2Cot8hRzCgQ=
 knative.dev/hack v0.0.0-20210622141627-e28525d8d260/go.mod h1:PHt8x8yX5Z9pPquBEfIj0X66f8iWkWfR0S/sarACJrI=
 knative.dev/hack/schema v0.0.0-20210622141627-e28525d8d260/go.mod h1:ffjwmdcrH5vN3mPhO8RrF2KfNnbHeCE2C60A+2cv3U0=
 knative.dev/networking v0.0.0-20210715062632-8925a5091ec7/go.mod h1:o2bPzMLFYvArfopSBqOrrS+SvoVRuTx/id0UCccK4xs=
 knative.dev/networking v0.0.0-20210719003653-7390d8cf09e3 h1:qmgmG+AD/sxyhLr2iu6g+vcksSFtHTjq+UkhbpVNa9A=
 knative.dev/networking v0.0.0-20210719003653-7390d8cf09e3/go.mod h1:JS1XZNYQ8hAdf+ySlQJr9F8KcdThKDYFdH2klpaumiY=
-knative.dev/pkg v0.0.0-20210712150822-e8973c6acbf7/go.mod h1:d06VsGUT2grnlhA8GcUjsoePok8P859AYcIqWISMGtY=
 knative.dev/pkg v0.0.0-20210713175550-7d1b0f19ef71/go.mod h1:d06VsGUT2grnlhA8GcUjsoePok8P859AYcIqWISMGtY=
 knative.dev/pkg v0.0.0-20210714200831-7764284cfa9a/go.mod h1:NYZRIPU+Pv39VfbZV1BtMIe4kCavNle1udsPrvOLm+Y=
 knative.dev/pkg v0.0.0-20210715175632-d9b7180af6f2 h1:dmyRXdB2IZkY8c3R58GVnbIfBLeRYvwSNTWqth+W/Pg=
 knative.dev/pkg v0.0.0-20210715175632-d9b7180af6f2/go.mod h1:NYZRIPU+Pv39VfbZV1BtMIe4kCavNle1udsPrvOLm+Y=
-knative.dev/reconciler-test v0.0.0-20210713145651-ebe91f96fea0/go.mod h1:/VaYF+w2nv0JQaSNMV1fFhhWgxHlZIBiGHnq6HdECtU=
-knative.dev/serving v0.24.1-0.20210719094053-ee022f47dadd h1:jn/9Hnb7pmm/95Ak/9K+tm5/MQlzoQzCQLrwAdhM/BE=
-knative.dev/serving v0.24.1-0.20210719094053-ee022f47dadd/go.mod h1:TxQDJl/M6xR09eCjGgu63RPbJmy62vDaOiJBwcfzWis=
+knative.dev/reconciler-test v0.0.0-20210714231231-91e5b206e1d5/go.mod h1:Zp2WHfJuh6+rOpOAq78My82drT4Bxjm/K4etmKcA7ko=
+knative.dev/serving v0.24.1-0.20210721125539-11abffdc6f0d h1:NtS72w/3MGDnIFHl3lsOE5ITr5eH0u2XH80qOtNOTmo=
+knative.dev/serving v0.24.1-0.20210721125539-11abffdc6f0d/go.mod h1:TxQDJl/M6xR09eCjGgu63RPbJmy62vDaOiJBwcfzWis=
 modernc.org/cc v1.0.0/go.mod h1:1Sk4//wdnYJiUIxnW8ddKpaOJCF37yAdqYnkxUpaYxw=
 modernc.org/golex v1.0.0/go.mod h1:b/QX9oBD/LhixY6NDh+IdGv17hgB+51fET1i2kPSmvk=
 modernc.org/mathutil v1.0.0/go.mod h1:wU0vUrJsVWBZ4P6e7xtFJEhFSNsfRLJ8H458uRjg03k=
diff --git a/vendor/knative.dev/eventing/pkg/apis/messaging/v1/subscription_types.go b/vendor/knative.dev/eventing/pkg/apis/messaging/v1/subscription_types.go
index 8add6a98..b093269d 100644
--- a/vendor/knative.dev/eventing/pkg/apis/messaging/v1/subscription_types.go
+++ b/vendor/knative.dev/eventing/pkg/apis/messaging/v1/subscription_types.go
@@ -61,9 +61,9 @@ var (
 // SubscriptionSpec specifies the Channel for incoming events, a Subscriber target
 // for processing those events and where to put the result of the processing. Only
 // From (where the events are coming from) is always required. You can optionally
-// only Process the events (results in no output events) by leaving out the Result.
+// only Process the events (results in no output events) by leaving out the Reply.
 // You can also perform an identity transformation on the incoming events by leaving
-// out the Subscriber and only specifying Result.
+// out the Subscriber and only specifying Reply.
 //
 // The following are all valid specifications:
 // channel --[subscriber]--> reply
diff --git a/vendor/modules.txt b/vendor/modules.txt
index 22429599..8b79fee7 100644
--- a/vendor/modules.txt
+++ b/vendor/modules.txt
@@ -685,7 +685,7 @@ k8s.io/utils/buffer
 k8s.io/utils/integer
 k8s.io/utils/pointer
 k8s.io/utils/trace
-# knative.dev/eventing v0.24.1-0.20210714200632-25bd8efb7179
+# knative.dev/eventing v0.24.1-0.20210720191312-003a8a2d4ef5
 ## explicit
 knative.dev/eventing/pkg/apis/config
 knative.dev/eventing/pkg/apis/duck
@@ -765,7 +765,7 @@ knative.dev/pkg/tracing/propagation
 knative.dev/pkg/tracing/propagation/tracecontextb3
 knative.dev/pkg/tracker
 knative.dev/pkg/unstructured
-# knative.dev/serving v0.24.1-0.20210719094053-ee022f47dadd
+# knative.dev/serving v0.24.1-0.20210721125539-11abffdc6f0d
 ## explicit
 knative.dev/serving/pkg/apis/autoscaling
 knative.dev/serving/pkg/apis/autoscaling/v1alpha1


Test patch:
diff --git a/cmd/kn/main_test.go b/cmd/kn/main_test.go
index d7c8cd35..57729f01 100644
--- a/cmd/kn/main_test.go
+++ b/cmd/kn/main_test.go
@@ -335,6 +335,15 @@ func TestRunWithExit(t *testing.T) {
 	}
 }
 
+func TestExtractCommandPathFromErrorMessage(t *testing.T) {
+	for _, d := range []struct{ arg0, errMsg, expected string }{
+		{"kn", "Invalid argument for 'kn service'", "kn service"},
+		{"C:\\Users\\hudson.DESKTOP-T61GB27\\Documents\\foo-with-revisions", "Invalid argument for 'C:\\Users\\hudson.DESKTOP-T61GB27\\Documents\\foo-with-revisions test'", "C:\\Users\\hudson.DESKTOP-T61GB27\\Documents\\foo-with-revisions test"},
+	} {
+		assert.Equal(t, extractCommandPathFromErrorMessage(d.errMsg, d.arg0), d.expected)
+	}
+}
+
 type internalPlugin struct {
 	executeError func() error
 	commandParts []string