Repository: jorgecarleitao/arrow2
Pull request #276 (2021-08-11 16:20:10)

Reduce dependencies from confi-table and enable wasm on io_print feature.
Hat tip to @roee88 for the ping :)

codecov[bot]: # [Codecov](https://codecov.io/gh/jorgecarleitao/arrow2/pull/276?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao) Report
> Merging [#276](https://codecov.io/gh/jorgecarleitao/arrow2/pull/276?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao) (783e72f) into [main](https://codecov.io/gh/jorgecarleitao/arrow2/commit/4c18c0ad88d24afa7854b3ef0584c357511ff9ce?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao) (4c18c0a) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.

> :exclamation: Current head 783e72f differs from pull request most recent head 39d5f60. Consider uploading reports for the commit 39d5f60 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/jorgecarleitao/arrow2/pull/276/graphs/tree.svg?width=650&height=150&src=pr&token=AgyTF60R3D&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao)](https://codecov.io/gh/jorgecarleitao/arrow2/pull/276?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao)

```diff
@@           Coverage Diff           @@
##             main     #276   +/-   ##
=======================================
  Coverage   77.14%   77.15%           
=======================================
  Files         254      254           
  Lines       20648    20648           
=======================================
+ Hits        15929    15931    +2     
+ Misses       4719     4717    -2     
```


| [Impacted Files](https://codecov.io/gh/jorgecarleitao/arrow2/pull/276?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao) | Coverage Δ | |
|---|---|---|
| [src/compute/arithmetics/mod.rs](https://codecov.io/gh/jorgecarleitao/arrow2/pull/276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao#diff-c3JjL2NvbXB1dGUvYXJpdGhtZXRpY3MvbW9kLnJz) | `51.87% <0.00%> (+0.75%)` | :arrow_up: |
| [src/compute/nullif.rs](https://codecov.io/gh/jorgecarleitao/arrow2/pull/276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao#diff-c3JjL2NvbXB1dGUvbnVsbGlmLnJz) | `1.81% <0.00%> (+1.81%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/jorgecarleitao/arrow2/pull/276?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/jorgecarleitao/arrow2/pull/276?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao). Last update [4c18c0a...39d5f60](https://codecov.io/gh/jorgecarleitao/arrow2/pull/276?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao).


Patch:
diff --git a/Cargo.toml b/Cargo.toml
index 0775ae6a8d..253e4ad7a7 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -33,7 +33,7 @@ serde_json = { version = "^1.0", features = ["preserve_order"], optional = true
 indexmap = { version = "^1.6", optional = true }
 
 # used to print columns in a nice columnar format
-comfy-table = { version = "4.0", optional = true }
+comfy-table = { version = "4.0", optional = true, default-features = false }
 
 flatbuffers = { version = "=2.0.0", optional = true }
 hex = { version = "^0.4", optional = true }


Test patch:
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index 4655dd4afc..987589d9f3 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -271,7 +271,7 @@ jobs:
           export CARGO_HOME="/github/home/.cargo"
           export CARGO_TARGET_DIR="/github/home/target"
           # no need 
-          cargo build --no-default-features --features=merge_sort,io_ipc,io_csv,io_json,io_parquet --target wasm32-unknown-unknown
+          cargo build --no-default-features --features=merge_sort,io_ipc,io_csv,io_print,io_json,io_parquet --target wasm32-unknown-unknown
 
   linux-simd-test:
     name: SIMD