Repository: ember-cli/ember-cli
Pull request #7863 (2018-06-02 16:26:54)

Bump minimum Node version for addons.
Node 4 is completely unsupported now, there is no reason to attempt to run it in CI still. Addons generated by ember-cli@3.2.0 should not try to use Node 4...

Note: targets beta branch...

TODO:

- [x] Fix `engines` support in `package.json` to drop Node 4 (and 7).
- [x] Update ember-cli's own `package.json` for supported Node engines.

Turbo87: I'm wondering if we should include a note somewhere that people should bump majors when doing this. Especially with ember-cli-update this is an easy to miss change. 

Patch:
diff --git a/.travis.yml b/.travis.yml
index a53a48efd..691563fbf 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -6,10 +6,8 @@ addons:
 
 language: node_js
 node_js:
-  - "4"
   - "6"
   - "8"
-  - "9"
   - "10"
 
 branches:
diff --git a/appveyor.yml b/appveyor.yml
index 4c06ae57b..1e00d1aa0 100644
--- a/appveyor.yml
+++ b/appveyor.yml
@@ -4,10 +4,8 @@
 environment:
   MOCHA_REPORTER: "mocha-appveyor-reporter"
   matrix:
-    - nodejs_version: "4"
     - nodejs_version: "6"
     - nodejs_version: "8"
-    - nodejs_version: "9"
     - nodejs_version: "10"
 
 branches:
diff --git a/blueprints/addon/files/.travis.yml b/blueprints/addon/files/.travis.yml
index 9c5f18cba..b600ad0c1 100644
--- a/blueprints/addon/files/.travis.yml
+++ b/blueprints/addon/files/.travis.yml
@@ -3,7 +3,7 @@ language: node_js
 node_js:
   # we recommend testing addons with the same minimum supported node version as Ember CLI
   # so that your addon works for all apps
-  - "4"
+  - "6"
 
 sudo: false
 dist: trusty
diff --git a/blueprints/app/files/package.json b/blueprints/app/files/package.json
index 1fb5078de..1b7559599 100644
--- a/blueprints/app/files/package.json
+++ b/blueprints/app/files/package.json
@@ -43,6 +43,6 @@
     "qunit-dom": "^0.6.2"
   },
   "engines": {
-    "node": "^4.5 || 6.* || >= 7.*"
+    "node": "6.* || 8.* || >= 10.*"
   }
 }
diff --git a/blueprints/module-unification-addon/files/.travis.yml b/blueprints/module-unification-addon/files/.travis.yml
index c9db7e0dd..c9e48c674 100644
--- a/blueprints/module-unification-addon/files/.travis.yml
+++ b/blueprints/module-unification-addon/files/.travis.yml
@@ -3,7 +3,7 @@ language: node_js
 node_js:
   # we recommend testing addons with the same minimum supported node version as Ember CLI
   # so that your addon works for all apps
-  - "4"
+  - "6"
 
 sudo: false
 dist: trusty
diff --git a/package.json b/package.json
index d30e47614..7a6ebf7ff 100644
--- a/package.json
+++ b/package.json
@@ -148,7 +148,7 @@
     "yuidocjs": "0.10.2"
   },
   "engines": {
-    "node": "^4.5 || 6.* || >= 7.*"
+    "node": "6.* || 8.* || >= 10.*"
   },
   "trackingCode": "UA-49225444-1",
   "greenkeeper": {


Test patch:
diff --git a/tests/fixtures/addon/npm/.travis.yml b/tests/fixtures/addon/npm/.travis.yml
index c9db7e0dd..c9e48c674 100644
--- a/tests/fixtures/addon/npm/.travis.yml
+++ b/tests/fixtures/addon/npm/.travis.yml
@@ -3,7 +3,7 @@ language: node_js
 node_js:
   # we recommend testing addons with the same minimum supported node version as Ember CLI
   # so that your addon works for all apps
-  - "4"
+  - "6"
 
 sudo: false
 dist: trusty
diff --git a/tests/fixtures/addon/npm/package.json b/tests/fixtures/addon/npm/package.json
index ca7a6d3eb..43189e6c0 100644
--- a/tests/fixtures/addon/npm/package.json
+++ b/tests/fixtures/addon/npm/package.json
@@ -49,7 +49,7 @@
     "qunit-dom": "^0.6.2"
   },
   "engines": {
-    "node": "^4.5 || 6.* || >= 7.*"
+    "node": "6.* || 8.* || >= 10.*"
   },
   "ember-addon": {
     "configPath": "tests/dummy/config"
diff --git a/tests/fixtures/addon/yarn/.travis.yml b/tests/fixtures/addon/yarn/.travis.yml
index 79a51a767..0207afa54 100644
--- a/tests/fixtures/addon/yarn/.travis.yml
+++ b/tests/fixtures/addon/yarn/.travis.yml
@@ -3,7 +3,7 @@ language: node_js
 node_js:
   # we recommend testing addons with the same minimum supported node version as Ember CLI
   # so that your addon works for all apps
-  - "4"
+  - "6"
 
 sudo: false
 dist: trusty
diff --git a/tests/fixtures/addon/yarn/package.json b/tests/fixtures/addon/yarn/package.json
index 254a6a26c..54f134a45 100644
--- a/tests/fixtures/addon/yarn/package.json
+++ b/tests/fixtures/addon/yarn/package.json
@@ -50,7 +50,7 @@
     "qunit-dom": "^0.6.2"
   },
   "engines": {
-    "node": "^4.5 || 6.* || >= 7.*"
+    "node": "6.* || 8.* || >= 10.*"
   },
   "ember-addon": {
     "configPath": "tests/dummy/config"
diff --git a/tests/fixtures/app/npm/package.json b/tests/fixtures/app/npm/package.json
index 37af09e02..51bb9c201 100644
--- a/tests/fixtures/app/npm/package.json
+++ b/tests/fixtures/app/npm/package.json
@@ -42,6 +42,6 @@
     "qunit-dom": "^0.6.2"
   },
   "engines": {
-    "node": "^4.5 || 6.* || >= 7.*"
+    "node": "6.* || 8.* || >= 10.*"
   }
 }
diff --git a/tests/fixtures/app/yarn/package.json b/tests/fixtures/app/yarn/package.json
index 413045273..4007d2f8e 100644
--- a/tests/fixtures/app/yarn/package.json
+++ b/tests/fixtures/app/yarn/package.json
@@ -43,6 +43,6 @@
     "qunit-dom": "^0.6.2"
   },
   "engines": {
-    "node": "^4.5 || 6.* || >= 7.*"
+    "node": "6.* || 8.* || >= 10.*"
   }
 }
diff --git a/tests/fixtures/module-unification-addon/.travis.yml b/tests/fixtures/module-unification-addon/.travis.yml
index c9db7e0dd..c9e48c674 100644
--- a/tests/fixtures/module-unification-addon/.travis.yml
+++ b/tests/fixtures/module-unification-addon/.travis.yml
@@ -3,7 +3,7 @@ language: node_js
 node_js:
   # we recommend testing addons with the same minimum supported node version as Ember CLI
   # so that your addon works for all apps
-  - "4"
+  - "6"
 
 sudo: false
 dist: trusty