Repository: urfave/cli
Pull request #1940 (2024-06-29 21:47:12)

docs: fix broken links
<!--
  This template provides some ideas of things to include in your PR description.
  To start, try providing a short summary of your changes in the Title above.
  If a section of the PR template does not apply to this PR, then delete that section.
 -->

## What type of PR is this?

_(REQUIRED)_

<!--
  Delete any of the following that do not apply:
 -->

- documentation

## What this PR does / why we need it:

_(REQUIRED)_

<!--
  What goal is this change working towards?
  Provide a bullet pointed summary of how each file was changed.
  Briefly explain any decisions you made with respect to the changes.
  Include anything here that you didn't include in *Release Notes*
  above, such as changes to CI or changes to internal methods.
-->

This pull request fixes some broken (404) links.

## Which issue(s) this PR fixes:

_(REQUIRED)_

<!--
If this PR fixes one of more issues, list them here.
One line each, like so:

Fixes #123
Fixes #39
-->

This pull request is related to https://github.com/urfave/cli/issues/1939 , but this pull request doesn't resolve the issue completely.

## Special notes for your reviewer:

_(fill-in or delete this section)_

<!--
   Is there any particular feedback you would / wouldn't like?
   Which parts of the code should reviewers focus on?
-->

## Testing

_(fill-in or delete this section)_

<!--
  Describe how you tested this change.
-->

## Release Notes

_(REQUIRED)_
<!--
  If this PR makes user facing changes, please describe them here. This
  description will be copied into the release notes/changelog, whenever the
  next version is released. Keep this section short, and focus on high level
  changes.

  Put your text between the block. To omit notes, use NONE within the block.
-->

```release-note

```



Patch:
diff --git a/.github/ISSUE_TEMPLATE/v1-bug-report.md b/.github/ISSUE_TEMPLATE/v1-bug-report.md
index cb9e865..9b649e2 100644
--- a/.github/ISSUE_TEMPLATE/v1-bug-report.md
+++ b/.github/ISSUE_TEMPLATE/v1-bug-report.md
@@ -14,7 +14,7 @@ _**( Put the version of urfave/cli that you are using here )**_
 ## Checklist
 
 - [ ] Are you running the latest v1 release? The list of releases is [here](https://github.com/urfave/cli/releases).
-- [ ] Did you check the manual for your release? The v1 manual is [here](https://github.com/urfave/cli/blob/main/docs/v1/manual.md).
+- [ ] Did you check the manual for your release? The v1 manual is [here](https://cli.urfave.org/v1/getting-started/).
 - [ ] Did you perform a search about this problem? Here's the [GitHub guide](https://help.github.com/en/github/managing-your-work-on-github/using-search-to-filter-issues-and-pull-requests) about searching.
 
 ## Dependency Management
diff --git a/.github/ISSUE_TEMPLATE/v2-bug-report.md b/.github/ISSUE_TEMPLATE/v2-bug-report.md
index cce2667..4f9b1e6 100644
--- a/.github/ISSUE_TEMPLATE/v2-bug-report.md
+++ b/.github/ISSUE_TEMPLATE/v2-bug-report.md
@@ -14,7 +14,7 @@ _**( Put the version of urfave/cli that you are using here )**_
 ## Checklist
 
 - [ ] Are you running the latest v2 release? The list of releases is [here](https://github.com/urfave/cli/releases).
-- [ ] Did you check the manual for your release? The v2 manual is [here](https://github.com/urfave/cli/blob/main/docs/v2/manual.md)
+- [ ] Did you check the manual for your release? The v2 manual is [here](https://cli.urfave.org/v2/getting-started/)
 - [ ] Did you perform a search about this problem? Here's the [GitHub guide](https://help.github.com/en/github/managing-your-work-on-github/using-search-to-filter-issues-and-pull-requests) about searching.
 
 ## Dependency Management
diff --git a/.github/ISSUE_TEMPLATE/v3-feature-request.md b/.github/ISSUE_TEMPLATE/v3-feature-request.md
index f706c68..ab70d0e 100644
--- a/.github/ISSUE_TEMPLATE/v3-feature-request.md
+++ b/.github/ISSUE_TEMPLATE/v3-feature-request.md
@@ -10,7 +10,7 @@ assignees: ''
 ## Checklist
 
 * [ ] Are you running the latest v3 release? The list of releases is [here](https://github.com/urfave/cli/releases).
-* [ ] Did you check the manual for your release? The v3 manual is [here](https://github.com/urfave/cli/blob/main/docs/v3/manual.md).
+* [ ] Did you check the manual for your release? The v3 manual is [here](https://github.com/urfave/cli/blob/main/docs/v3/index.md).
 * [ ] Did you perform a search about this feature? Here's the [GitHub guide](https://help.github.com/en/github/managing-your-work-on-github/using-search-to-filter-issues-and-pull-requests) about searching.
 
 ## What problem does this solve?
diff --git a/docs/CONTRIBUTING.md b/docs/CONTRIBUTING.md
index 349929f..c0054eb 100644
--- a/docs/CONTRIBUTING.md
+++ b/docs/CONTRIBUTING.md
@@ -63,7 +63,7 @@ make
 Running the default `make` target (`all`) will ensure all of the critical steps are run to
 verify one's changes are harmonious in nature. The same steps are also run during the
 [continuous integration
-phase](https://github.com/urfave/cli/blob/main/.github/workflows/cli.yml).
+phase](https://github.com/urfave/cli/blob/main/.github/workflows/test.yml).
 
 In the event that the `v3diff` target exits non-zero, this is a signal that the public API
 surface area has changed. If the changes are acceptable, then manually running the
@@ -81,7 +81,7 @@ step.
 #### docs output
 
 The documentation in the `docs` directory is automatically built via `mkdocs` into a
-static site and published when releases are pushed (see [RELEASING](./RELEASING/)). There
+static site and published when releases are pushed (see [RELEASING](./RELEASING.md)). There
 is no strict requirement to build the documentation when developing locally, but the
 following `make` targets may be used if desired:
 
diff --git a/docs/index.md b/docs/index.md
index bf7f7d7..3d1a051 100644
--- a/docs/index.md
+++ b/docs/index.md
@@ -4,7 +4,7 @@ https://github.com/urfave/cli/blob/main/README.md
 -->
 # Welcome to urfave/cli
 
-[![Run Tests](https://github.com/urfave/cli/actions/workflows/cli.yml/badge.svg)](https://github.com/urfave/cli/actions/workflows/cli.yml)
+[![Run Tests](https://github.com/urfave/cli/actions/workflows/test.yml/badge.svg)](https://github.com/urfave/cli/actions/workflows/test.yml)
 [![Go Reference](https://pkg.go.dev/badge/github.com/urfave/cli/v3.svg)](https://pkg.go.dev/github.com/urfave/cli/v3)
 [![Go Report Card](https://goreportcard.com/badge/github.com/urfave/cli/v3)](https://goreportcard.com/report/github.com/urfave/cli/v3)
 [![codecov](https://codecov.io/gh/urfave/cli/branch/main/graph/badge.svg?token=t9YGWLh05g)](https://codecov.io/gh/urfave/cli)
@@ -94,4 +94,4 @@ cli is tested against multiple versions of Go on Linux, and against the latest
 released version of Go on OS X and Windows. This project uses GitHub Actions
 for builds. To see our currently supported go versions and platforms, look at
 the [github workflow
-configuration](https://github.com/urfave/cli/blob/main/.github/workflows/cli.yml).
+configuration](https://github.com/urfave/cli/blob/main/.github/workflows/test.yml).
diff --git a/flag.go b/flag.go
index f7c64c8..f5c24b0 100644
--- a/flag.go
+++ b/flag.go
@@ -35,20 +35,18 @@ var GenerateShellCompletionFlag Flag = &BoolFlag{
 
 // VersionFlag prints the version for the application
 var VersionFlag Flag = &BoolFlag{
-	Name:        "version",
-	Aliases:     []string{"v"},
-	Usage:       "print the version",
-	HideDefault: true,
+	Name:    "version",
+	Aliases: []string{"v"},
+	Usage:   "print the version",
 }
 
 // HelpFlag prints the help for all commands and subcommands.
 // Set to nil to disable the flag.  The subcommand
 // will still be added unless HideHelp or HideHelpCommand is set to true.
 var HelpFlag Flag = &BoolFlag{
-	Name:        "help",
-	Aliases:     []string{"h"},
-	Usage:       "show help",
-	HideDefault: true,
+	Name:    "help",
+	Aliases: []string{"h"},
+	Usage:   "show help",
 }
 
 // FlagStringer converts a flag definition to a string. This is used by help
@@ -137,10 +135,6 @@ type DocGenerationFlag interface {
 
 	// GetEnvVars returns the env vars for this flag
 	GetEnvVars() []string
-
-	// IsDefaultVisible returns whether the default value should be shown in
-	// help text
-	IsDefaultVisible() bool
 }
 
 // DocGenerationMultiValueFlag extends DocGenerationFlag for slice/map based flags.
@@ -179,11 +173,6 @@ type PersistentFlag interface {
 	IsPersistent() bool
 }
 
-// IsDefaultVisible returns true if the flag is not hidden, otherwise false
-func (f *FlagBase[T, C, V]) IsDefaultVisible() bool {
-	return !f.HideDefault
-}
-
 func newFlagSet(name string, flags []Flag) (*flag.FlagSet, error) {
 	set := flag.NewFlagSet(name, flag.ContinueOnError)
 
@@ -358,12 +347,8 @@ func stringifyFlag(f Flag) string {
 
 	defaultValueString := ""
 
-	// don't print default text for required flags
-	if rf, ok := f.(RequiredFlag); !ok || !rf.IsRequired() {
-		isVisible := df.IsDefaultVisible()
-		if s := df.GetDefaultText(); isVisible && s != "" {
-			defaultValueString = fmt.Sprintf(formatDefault("%s"), s)
-		}
+	if s := df.GetDefaultText(); s != "" {
+		defaultValueString = fmt.Sprintf(formatDefault("%s"), s)
 	}
 
 	usageWithDefault := strings.TrimSpace(usage + defaultValueString)
diff --git a/flag_impl.go b/flag_impl.go
index a6de390..36edcc9 100644
--- a/flag_impl.go
+++ b/flag_impl.go
@@ -72,7 +72,6 @@ type FlagBase[T any, C any, VC ValueCreator[T, C]] struct {
 	Name        string                                   `json:"name"`         // name of the flag
 	Category    string                                   `json:"category"`     // category of the flag, if any
 	DefaultText string                                   `json:"defaultText"`  // default text of the flag for usage purposes
-	HideDefault bool                                     `json:"hideDefault"`  // whether to hide the default value in output
 	Usage       string                                   `json:"usage"`        // usage string for help output
 	Sources     ValueSourceChain                         `json:"-"`            // sources to load flag value from
 	Required    bool                                     `json:"required"`     // whether the flag is required or not
diff --git a/godoc-current.txt b/godoc-current.txt
index 07bd07e..70b692a 100644
--- a/godoc-current.txt
+++ b/godoc-current.txt
@@ -557,10 +557,6 @@ type DocGenerationFlag interface {
 
 	// GetEnvVars returns the env vars for this flag
 	GetEnvVars() []string
-
-	// IsDefaultVisible returns whether the default value should be shown in
-	// help text
-	IsDefaultVisible() bool
 }
     DocGenerationFlag is an interface that allows documentation generation for
     the flag
@@ -624,20 +620,18 @@ var GenerateShellCompletionFlag Flag = &BoolFlag{
     GenerateShellCompletionFlag enables shell completion
 
 var HelpFlag Flag = &BoolFlag{
-	Name:        "help",
-	Aliases:     []string{"h"},
-	Usage:       "show help",
-	HideDefault: true,
+	Name:    "help",
+	Aliases: []string{"h"},
+	Usage:   "show help",
 }
     HelpFlag prints the help for all commands and subcommands. Set to nil to
     disable the flag. The subcommand will still be added unless HideHelp or
     HideHelpCommand is set to true.
 
 var VersionFlag Flag = &BoolFlag{
-	Name:        "version",
-	Aliases:     []string{"v"},
-	Usage:       "print the version",
-	HideDefault: true,
+	Name:    "version",
+	Aliases: []string{"v"},
+	Usage:   "print the version",
 }
     VersionFlag prints the version for the application
 
@@ -645,7 +639,6 @@ type FlagBase[T any, C any, VC ValueCreator[T, C]] struct {
 	Name        string                                   `json:"name"`         // name of the flag
 	Category    string                                   `json:"category"`     // category of the flag, if any
 	DefaultText string                                   `json:"defaultText"`  // default text of the flag for usage purposes
-	HideDefault bool                                     `json:"hideDefault"`  // whether to hide the default value in output
 	Usage       string                                   `json:"usage"`        // usage string for help output
 	Sources     ValueSourceChain                         `json:"-"`            // sources to load flag value from
 	Required    bool                                     `json:"required"`     // whether the flag is required or not
@@ -691,9 +684,6 @@ func (f *FlagBase[T, C, V]) GetValue() string
     GetValue returns the flags value as string representation and an empty
     string if the flag takes no value at all.
 
-func (f *FlagBase[T, C, V]) IsDefaultVisible() bool
-    IsDefaultVisible returns true if the flag is not hidden, otherwise false
-
 func (f *FlagBase[T, C, VC]) IsMultiValueFlag() bool
     IsMultiValueFlag returns true if the value type T can take multiple values
     from cmd line. This is true for slice and map type flags
diff --git a/help.go b/help.go
index 1d2938c..7384eb1 100644
--- a/help.go
+++ b/help.go
@@ -454,15 +454,6 @@ func checkShellCompleteFlag(c *Command, arguments []string) (bool, []string) {
 		return false, arguments
 	}
 
-	for _, arg := range arguments {
-		// If arguments include "--", shell completion is disabled
-		// because after "--" only positional arguments are accepted.
-		// https://unix.stackexchange.com/a/11382
-		if arg == "--" {
-			return false, arguments
-		}
-	}
-
 	return true, arguments[:pos]
 }
 


Test patch:
diff --git a/command_test.go b/command_test.go
index 20abfb7..094bfec 100644
--- a/command_test.go
+++ b/command_test.go
@@ -3919,7 +3919,6 @@ func TestJSONExportCommand(t *testing.T) {
 					"usage": "",
 					"required": false,
 					"hidden": false,
-					"hideDefault": false,
 					"persistent": false,
 					"defaultValue": "",
 					"aliases": [
@@ -3939,7 +3938,6 @@ func TestJSONExportCommand(t *testing.T) {
 					"usage": "some usage text",
 					"required": false,
 					"hidden": false,
-					"hideDefault": false,
 					"persistent": false,
 					"defaultValue": false,
 					"aliases": [
@@ -3979,7 +3977,6 @@ func TestJSONExportCommand(t *testing.T) {
 				"usage": "",
 				"required": false,
 				"hidden": false,
-				"hideDefault": false,
 				"persistent": false,
 				"defaultValue": "",
 				"aliases": [
@@ -3999,7 +3996,6 @@ func TestJSONExportCommand(t *testing.T) {
 				"usage": "another usage text",
 				"required": false,
 				"hidden": false,
-				"hideDefault": false,
 				"persistent": false,
 				"defaultValue": false,
 				"aliases": [
@@ -4157,7 +4153,6 @@ func TestJSONExportCommand(t *testing.T) {
 					"usage": "some usage text",
 					"required": false,
 					"hidden": false,
-					"hideDefault": false,
 					"persistent": false,
 					"defaultValue": false,
 					"aliases": [
@@ -4197,7 +4192,6 @@ func TestJSONExportCommand(t *testing.T) {
 				"usage": "",
 				"required": false,
 				"hidden": false,
-				"hideDefault": false,
 				"persistent": false,
 				"defaultValue": "",
 				"aliases": [
@@ -4217,7 +4211,6 @@ func TestJSONExportCommand(t *testing.T) {
 				"usage": "another usage text",
 				"required": false,
 				"hidden": false,
-				"hideDefault": false,
 				"persistent": false,
 				"defaultValue": false,
 				"aliases": [
@@ -4257,7 +4250,6 @@ func TestJSONExportCommand(t *testing.T) {
 			"usage": "some 'usage' text",
 			"required": false,
 			"hidden": false,
-			"hideDefault": false,
 			"persistent": false,
 			"defaultValue": "value",
 			"aliases": [
@@ -4276,7 +4268,6 @@ func TestJSONExportCommand(t *testing.T) {
 			"usage": "",
 			"required": false,
 			"hidden": false,
-			"hideDefault": false,
 			"persistent": false,
 			"defaultValue": "",
 			"aliases": [
@@ -4296,7 +4287,6 @@ func TestJSONExportCommand(t *testing.T) {
 			"usage": "another usage text",
 			"required": false,
 			"hidden": false,
-			"hideDefault": false,
 			"persistent": false,
 			"defaultValue": false,
 			"aliases": [
@@ -4315,7 +4305,6 @@ func TestJSONExportCommand(t *testing.T) {
 			"usage": "",
 			"required": false,
 			"hidden": true,
-			"hideDefault": false,
 			"persistent": false,
 			"defaultValue": false,
 			"aliases": null,
diff --git a/examples_test.go b/examples_test.go
index 8802d54..b7050b8 100644
--- a/examples_test.go
+++ b/examples_test.go
@@ -143,8 +143,8 @@ func ExampleCommand_Run_appHelp() {
 	//
 	// GLOBAL OPTIONS:
 	//    --name value   a name to say (default: "bob")
-	//    --help, -h     show help
-	//    --version, -v  print the version
+	//    --help, -h     show help (default: false)
+	//    --version, -v  print the version (default: false)
 }
 
 func ExampleCommand_Run_commandHelp() {
@@ -190,7 +190,7 @@ func ExampleCommand_Run_commandHelp() {
 	//    help, h  Shows a list of commands or help for one command
 	//
 	// OPTIONS:
-	//    --help, -h  show help
+	//    --help, -h  show help (default: false)
 }
 
 func ExampleCommand_Run_noAction() {
@@ -211,7 +211,7 @@ func ExampleCommand_Run_noAction() {
 	//    help, h  Shows a list of commands or help for one command
 	//
 	// GLOBAL OPTIONS:
-	//    --help, -h  show help
+	//    --help, -h  show help (default: false)
 }
 
 func ExampleCommand_Run_subcommandNoAction() {
@@ -243,7 +243,7 @@ func ExampleCommand_Run_subcommandNoAction() {
 	//    This is how we describe describeit the function
 	//
 	// OPTIONS:
-	//    --help, -h  show help
+	//    --help, -h  show help (default: false)
 }
 
 func ExampleCommand_Run_shellComplete_bash_withShortFlag() {
diff --git a/help_test.go b/help_test.go
index 91e8e65..b45e0d2 100644
--- a/help_test.go
+++ b/help_test.go
@@ -65,36 +65,6 @@ func Test_ShowAppHelp_MultiLineDescription(t *testing.T) {
 	}
 }
 
-func Test_Help_RequiredFlagsNoDefault(t *testing.T) {
-	output := new(bytes.Buffer)
-
-	cmd := &Command{
-		Flags: []Flag{
-			&IntFlag{Name: "foo", Aliases: []string{"f"}, Required: true},
-		},
-		Writer: output,
-	}
-
-	_ = cmd.Run(buildTestContext(t), []string{"test", "-h"})
-
-	expected := `NAME:
-   test - A new cli application
-
-USAGE:
-   test [global options] [command [command options]] [arguments...]
-
-COMMANDS:
-   help, h  Shows a list of commands or help for one command
-
-GLOBAL OPTIONS:
-   --foo value, -f value  
-   --help, -h             show help
-`
-
-	assert.Contains(t, output.String(), expected,
-		"expected output to include usage text")
-}
-
 func Test_Help_Custom_Flags(t *testing.T) {
 	oldFlag := HelpFlag
 	defer func() {
@@ -1428,7 +1398,8 @@ COMMANDS:
             for one command
 
 OPTIONS:
-   --help, -h  show help
+   --help, -h show help
+      (default: false)
 `,
 		output.String(),
 	)
@@ -1493,7 +1464,8 @@ USAGE:
    even more
 
 OPTIONS:
-   --help, -h  show help
+   --help, -h show help
+      (default: false)
 `
 
 	assert.Equal(t, expected, output.String(), "Unexpected wrapping")
@@ -1573,7 +1545,8 @@ COMMANDS:
 OPTIONS:
    --test-f value my test
       usage
-   --help, -h  show help
+   --help, -h show help
+      (default: false)
 `,
 		output.String(),
 	)
@@ -1651,7 +1624,7 @@ COMMANDS:
             for one command
 
 GLOBAL OPTIONS:
-   --help, -h    show help
+   --help, -h    show help (default: false)
    --m2 value    
    --strd value  
 
@@ -1662,68 +1635,3 @@ GLOBAL OPTIONS:
 
 `, output.String())
 }
-
-func Test_checkShellCompleteFlag(t *testing.T) {
-	t.Parallel()
-	tests := []struct {
-		name                string
-		cmd                 *Command
-		arguments           []string
-		wantShellCompletion bool
-		wantArgs            []string
-	}{
-		{
-			name:                "disable-shell-completion",
-			arguments:           []string{"--generate-shell-completion"},
-			cmd:                 &Command{},
-			wantShellCompletion: false,
-			wantArgs:            []string{"--generate-shell-completion"},
-		},
-		{
-			name:      "child-disable-shell-completion",
-			arguments: []string{"--generate-shell-completion"},
-			cmd: &Command{
-				parent: &Command{},
-			},
-			wantShellCompletion: false,
-			wantArgs:            []string{"--generate-shell-completion"},
-		},
-		{
-			name:      "last argument isn't --generate-shell-completion",
-			arguments: []string{"foo"},
-			cmd: &Command{
-				EnableShellCompletion: true,
-			},
-			wantShellCompletion: false,
-			wantArgs:            []string{"foo"},
-		},
-		{
-			name:      "arguments include double dash",
-			arguments: []string{"--", "foo", "--generate-shell-completion"},
-			cmd: &Command{
-				EnableShellCompletion: true,
-			},
-			wantShellCompletion: false,
-			wantArgs:            []string{"--", "foo", "--generate-shell-completion"},
-		},
-		{
-			name:      "shell completion",
-			arguments: []string{"foo", "--generate-shell-completion"},
-			cmd: &Command{
-				EnableShellCompletion: true,
-			},
-			wantShellCompletion: true,
-			wantArgs:            []string{"foo"},
-		},
-	}
-
-	for _, tt := range tests {
-		tt := tt
-		t.Run(tt.name, func(t *testing.T) {
-			t.Parallel()
-			shellCompletion, args := checkShellCompleteFlag(tt.cmd, tt.arguments)
-			assert.Equal(t, tt.wantShellCompletion, shellCompletion)
-			assert.Equal(t, tt.wantArgs, args)
-		})
-	}
-}
diff --git a/testdata/godoc-v3.x.txt b/testdata/godoc-v3.x.txt
index 07bd07e..70b692a 100644
--- a/testdata/godoc-v3.x.txt
+++ b/testdata/godoc-v3.x.txt
@@ -557,10 +557,6 @@ type DocGenerationFlag interface {
 
 	// GetEnvVars returns the env vars for this flag
 	GetEnvVars() []string
-
-	// IsDefaultVisible returns whether the default value should be shown in
-	// help text
-	IsDefaultVisible() bool
 }
     DocGenerationFlag is an interface that allows documentation generation for
     the flag
@@ -624,20 +620,18 @@ var GenerateShellCompletionFlag Flag = &BoolFlag{
     GenerateShellCompletionFlag enables shell completion
 
 var HelpFlag Flag = &BoolFlag{
-	Name:        "help",
-	Aliases:     []string{"h"},
-	Usage:       "show help",
-	HideDefault: true,
+	Name:    "help",
+	Aliases: []string{"h"},
+	Usage:   "show help",
 }
     HelpFlag prints the help for all commands and subcommands. Set to nil to
     disable the flag. The subcommand will still be added unless HideHelp or
     HideHelpCommand is set to true.
 
 var VersionFlag Flag = &BoolFlag{
-	Name:        "version",
-	Aliases:     []string{"v"},
-	Usage:       "print the version",
-	HideDefault: true,
+	Name:    "version",
+	Aliases: []string{"v"},
+	Usage:   "print the version",
 }
     VersionFlag prints the version for the application
 
@@ -645,7 +639,6 @@ type FlagBase[T any, C any, VC ValueCreator[T, C]] struct {
 	Name        string                                   `json:"name"`         // name of the flag
 	Category    string                                   `json:"category"`     // category of the flag, if any
 	DefaultText string                                   `json:"defaultText"`  // default text of the flag for usage purposes
-	HideDefault bool                                     `json:"hideDefault"`  // whether to hide the default value in output
 	Usage       string                                   `json:"usage"`        // usage string for help output
 	Sources     ValueSourceChain                         `json:"-"`            // sources to load flag value from
 	Required    bool                                     `json:"required"`     // whether the flag is required or not
@@ -691,9 +684,6 @@ func (f *FlagBase[T, C, V]) GetValue() string
     GetValue returns the flags value as string representation and an empty
     string if the flag takes no value at all.
 
-func (f *FlagBase[T, C, V]) IsDefaultVisible() bool
-    IsDefaultVisible returns true if the flag is not hidden, otherwise false
-
 func (f *FlagBase[T, C, VC]) IsMultiValueFlag() bool
     IsMultiValueFlag returns true if the value type T can take multiple values
     from cmd line. This is true for slice and map type flags