Repository: chanzuckerberg/fogg
Pull request #388 (2019-12-14 00:31:26)

[fix] syntax for version to download

### Test Plan
* did a test run on 1 repo internally

### References


codecov[bot]: # [Codecov](https://codecov.io/gh/chanzuckerberg/fogg/pull/388?src=pr&el=h1) Report
> Merging [#388](https://codecov.io/gh/chanzuckerberg/fogg/pull/388?src=pr&el=desc) into [master](https://codecov.io/gh/chanzuckerberg/fogg/commit/700bc286627aad17740572d3eb2a04a2311ba9be?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/chanzuckerberg/fogg/pull/388/graphs/tree.svg?width=650&token=57DhtZ7g2A&height=150&src=pr)](https://codecov.io/gh/chanzuckerberg/fogg/pull/388?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master     #388   +/-   ##
=======================================
  Coverage   79.04%   79.04%           
=======================================
  Files          25       25           
  Lines        2009     2009           
=======================================
  Hits         1588     1588           
  Misses        278      278           
  Partials      143      143
```



------

[Continue to review full report at Codecov](https://codecov.io/gh/chanzuckerberg/fogg/pull/388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/chanzuckerberg/fogg/pull/388?src=pr&el=footer). Last update [700bc28...3f83747](https://codecov.io/gh/chanzuckerberg/fogg/pull/388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


Patch:
diff --git a/templates/repo/Makefile.tmpl b/templates/repo/Makefile.tmpl
index 42c63166..a2ebd1d4 100644
--- a/templates/repo/Makefile.tmpl
+++ b/templates/repo/Makefile.tmpl
@@ -10,7 +10,7 @@ ACCOUNTS={{ .Accounts | dict | keys | sortAlpha | join " "}}
 all: check
 
 setup: ## set up working directory by installing dependencies
-	curl -s https://raw.githubusercontent.com/chanzuckerberg/fogg/master/download.sh | bash -s -- -b .fogg/bin {{.Version}}
+	curl -s https://raw.githubusercontent.com/chanzuckerberg/fogg/master/download.sh | bash -s -- -b .fogg/bin v{{.Version}}
 	.fogg/bin/fogg setup
 .PHONY: setup
 


Test patch:
diff --git a/testdata/bless_provider/Makefile b/testdata/bless_provider/Makefile
index 44a77de6..6182b632 100644
--- a/testdata/bless_provider/Makefile
+++ b/testdata/bless_provider/Makefile
@@ -10,7 +10,7 @@ ACCOUNTS=foo
 all: check
 
 setup: ## set up working directory by installing dependencies
-	curl -s https://raw.githubusercontent.com/chanzuckerberg/fogg/master/download.sh | bash -s -- -b .fogg/bin undefined+undefined+dirty
+	curl -s https://raw.githubusercontent.com/chanzuckerberg/fogg/master/download.sh | bash -s -- -b .fogg/bin vundefined+undefined+dirty
 	.fogg/bin/fogg setup
 .PHONY: setup
 
diff --git a/testdata/github_provider/Makefile b/testdata/github_provider/Makefile
index 44a77de6..6182b632 100644
--- a/testdata/github_provider/Makefile
+++ b/testdata/github_provider/Makefile
@@ -10,7 +10,7 @@ ACCOUNTS=foo
 all: check
 
 setup: ## set up working directory by installing dependencies
-	curl -s https://raw.githubusercontent.com/chanzuckerberg/fogg/master/download.sh | bash -s -- -b .fogg/bin undefined+undefined+dirty
+	curl -s https://raw.githubusercontent.com/chanzuckerberg/fogg/master/download.sh | bash -s -- -b .fogg/bin vundefined+undefined+dirty
 	.fogg/bin/fogg setup
 .PHONY: setup
 
diff --git a/testdata/okta_provider/Makefile b/testdata/okta_provider/Makefile
index 44a77de6..6182b632 100644
--- a/testdata/okta_provider/Makefile
+++ b/testdata/okta_provider/Makefile
@@ -10,7 +10,7 @@ ACCOUNTS=foo
 all: check
 
 setup: ## set up working directory by installing dependencies
-	curl -s https://raw.githubusercontent.com/chanzuckerberg/fogg/master/download.sh | bash -s -- -b .fogg/bin undefined+undefined+dirty
+	curl -s https://raw.githubusercontent.com/chanzuckerberg/fogg/master/download.sh | bash -s -- -b .fogg/bin vundefined+undefined+dirty
 	.fogg/bin/fogg setup
 .PHONY: setup
 
diff --git a/testdata/snowflake_provider/Makefile b/testdata/snowflake_provider/Makefile
index 44a77de6..6182b632 100644
--- a/testdata/snowflake_provider/Makefile
+++ b/testdata/snowflake_provider/Makefile
@@ -10,7 +10,7 @@ ACCOUNTS=foo
 all: check
 
 setup: ## set up working directory by installing dependencies
-	curl -s https://raw.githubusercontent.com/chanzuckerberg/fogg/master/download.sh | bash -s -- -b .fogg/bin undefined+undefined+dirty
+	curl -s https://raw.githubusercontent.com/chanzuckerberg/fogg/master/download.sh | bash -s -- -b .fogg/bin vundefined+undefined+dirty
 	.fogg/bin/fogg setup
 .PHONY: setup
 
diff --git a/testdata/v1_full/Makefile b/testdata/v1_full/Makefile
index bcc24eff..57160d3f 100644
--- a/testdata/v1_full/Makefile
+++ b/testdata/v1_full/Makefile
@@ -10,7 +10,7 @@ ACCOUNTS=bar foo
 all: check
 
 setup: ## set up working directory by installing dependencies
-	curl -s https://raw.githubusercontent.com/chanzuckerberg/fogg/master/download.sh | bash -s -- -b .fogg/bin undefined+undefined+dirty
+	curl -s https://raw.githubusercontent.com/chanzuckerberg/fogg/master/download.sh | bash -s -- -b .fogg/bin vundefined+undefined+dirty
 	.fogg/bin/fogg setup
 .PHONY: setup
 
diff --git a/testdata/v2_full/Makefile b/testdata/v2_full/Makefile
index 77ca71a8..9107110d 100644
--- a/testdata/v2_full/Makefile
+++ b/testdata/v2_full/Makefile
@@ -10,7 +10,7 @@ ACCOUNTS=bar foo
 all: check
 
 setup: ## set up working directory by installing dependencies
-	curl -s https://raw.githubusercontent.com/chanzuckerberg/fogg/master/download.sh | bash -s -- -b .fogg/bin undefined+undefined+dirty
+	curl -s https://raw.githubusercontent.com/chanzuckerberg/fogg/master/download.sh | bash -s -- -b .fogg/bin vundefined+undefined+dirty
 	.fogg/bin/fogg setup
 .PHONY: setup
 
diff --git a/testdata/v2_minimal_valid/Makefile b/testdata/v2_minimal_valid/Makefile
index 699d91d0..daf62166 100644
--- a/testdata/v2_minimal_valid/Makefile
+++ b/testdata/v2_minimal_valid/Makefile
@@ -10,7 +10,7 @@ ACCOUNTS=
 all: check
 
 setup: ## set up working directory by installing dependencies
-	curl -s https://raw.githubusercontent.com/chanzuckerberg/fogg/master/download.sh | bash -s -- -b .fogg/bin undefined+undefined+dirty
+	curl -s https://raw.githubusercontent.com/chanzuckerberg/fogg/master/download.sh | bash -s -- -b .fogg/bin vundefined+undefined+dirty
 	.fogg/bin/fogg setup
 .PHONY: setup
 
diff --git a/testdata/v2_no_aws_provider/Makefile b/testdata/v2_no_aws_provider/Makefile
index 77ca71a8..9107110d 100644
--- a/testdata/v2_no_aws_provider/Makefile
+++ b/testdata/v2_no_aws_provider/Makefile
@@ -10,7 +10,7 @@ ACCOUNTS=bar foo
 all: check
 
 setup: ## set up working directory by installing dependencies
-	curl -s https://raw.githubusercontent.com/chanzuckerberg/fogg/master/download.sh | bash -s -- -b .fogg/bin undefined+undefined+dirty
+	curl -s https://raw.githubusercontent.com/chanzuckerberg/fogg/master/download.sh | bash -s -- -b .fogg/bin vundefined+undefined+dirty
 	.fogg/bin/fogg setup
 .PHONY: setup