Repository: GoogleChrome/lighthouse
Pull request #12701 (2021-06-25 01:59:40)

tests: tweak variability assertion for load-things transferSize
This upstreams a change created by the JS web build team.  🔒  http://cl/379821904 THANK YOU to Elena and Jan! 😻

As noted by them:

> **For the `document` resource**: the new transfer size is just outside current bounds of `'2200±100'`
> The transfer size differences appear to be caused by header changes (where with the node14 upgrade, there is an additional header, `Keep-Alive: timeout=5`).




Patch:
diff --git a/.github/ISSUE_TEMPLATE/Bug_report.md b/.github/ISSUE_TEMPLATE/Bug_report.md
deleted file mode 100644
index cf8bfe299..000000000
--- a/.github/ISSUE_TEMPLATE/Bug_report.md
+++ /dev/null
@@ -1,28 +0,0 @@
----
-name: Bug report
-about: Report something working incorrectly
-
----
-
-<!-- Before creating an issue please make sure you are using the latest version and have checked for duplicate issues. -->
-
-<!-- Before creating an Accessibility issue please test that it is reproducible upstream with axe (https://www.deque.com/axe/) first and file the issue there if necessary. -->
-
-#### Provide the steps to reproduce
-1. Run LH on <affected url>
-  
-<!-- If your page is only local, or is liable to change, consider uploading a repro so that we can more easily debug the problem. Some services that will help are: https://jsbin.com/, https://surge.sh/ -->
-
-#### What is the current behavior?
-
-#### What is the expected behavior?
-
-
-#### Environment Information
-* Affected Channels: <!-- CLI, Node, Extension, DevTools -->
-* Lighthouse version:
-* Chrome version: <!-- chrome://version/ -->
-* Node.js version:
-* Operating System:
-
-**Related issues**
diff --git a/.github/ISSUE_TEMPLATE/bug-report.yml b/.github/ISSUE_TEMPLATE/bug-report.yml
new file mode 100644
index 000000000..1a7ffc9ba
--- /dev/null
+++ b/.github/ISSUE_TEMPLATE/bug-report.yml
@@ -0,0 +1,91 @@
+name: Bug Report
+description: Report something working incorrectly
+labels: [bug]
+body:
+  - type: markdown
+    attributes:
+      value: |
+        Thanks for taking the time to fill out this bug report!
+  - type: checkboxes
+    id: faq
+    attributes:
+      label: FAQ
+      description: Please double check that this isn't one of our most common questions already answered by [documentation]((https://github.com/GoogleChrome/lighthouse/blob/master/docs).
+      options:
+        - label: Yes, my issue is not about [variability](https://github.com/GoogleChrome/lighthouse/blob/master/docs/variability.md) or [throttling](https://github.com/GoogleChrome/lighthouse/blob/master/docs/throttling.md).
+          required: true
+        - label: Yes, my issue is not about a specific accessibility audit (file with [axe-core](https://github.com/dequelabs/axe-core) instead).
+          required: true
+  - type: input
+    id: url
+    attributes:
+      label: URL
+      description: What URL did you run Lighthouse on? If this happened locally, please upload a minimal repro to a public location (e.g. https://glitch.com/, http://jsbin.com/, etc)
+      placeholder: https://example.com
+    validations:
+      required: true
+  - type: textarea
+    id: what-happened
+    attributes:
+      label: What happened?
+      description: A brief description of the behavior you observed.
+      placeholder: Tell us what you saw!
+    validations:
+      required: true
+  - type: textarea
+    id: what-expected
+    attributes:
+      label: What did you expect?
+      description: A brief description of the behavior you _expected_.
+      placeholder: Tell us what you expected to see instead!
+    validations:
+      required: true
+  - type: textarea
+    id: what-debug
+    attributes:
+      label: What have you tried?
+      description: A brief description of the steps you have already taken to debug the behavior.
+      placeholder: Tell us what you've already tried to know it is a Lighthouse bug.
+    validations:
+      required: false
+  - type: dropdown
+    id: channels
+    attributes:
+      label: How were you running Lighthouse?
+      description: Where were you running Lighthouse when you observed this behavior?
+      multiple: true
+      options:
+        - CLI
+        - node
+        - PageSpeed Insights
+        - Chrome DevTools
+        - WebPageTest
+    validations:
+      required: true
+  - type: input
+    id: version
+    attributes:
+      label: Lighthouse Version
+      description: What version of Lighthouse were you using? The version of Lighthouse can be found at the bottom of every report.
+    validations:
+      required: true
+  - type: input
+    id: chromeversion
+    attributes:
+      label: Chrome Version
+      description: What version of Chrome were you using? (Only applicable if you ran locally)
+    validations:
+      required: false
+  - type: input
+    id: nodeversion
+    attributes:
+      label: Node Version
+      description: What version of node.js were you using? (Only applicable to CLI and node)
+    validations:
+      required: false
+  - type: textarea
+    id: logs
+    attributes:
+      label: Relevant log output
+      description: Please copy and paste any relevant log output. This will be automatically formatted into code, so no need for backticks.
+      render: shell


Test patch:
diff --git a/lighthouse-cli/test/smokehouse/test-definitions/perf/expectations.js b/lighthouse-cli/test/smokehouse/test-definitions/perf/expectations.js
index bdfc3b3d1..80b611ba8 100644
--- a/lighthouse-cli/test/smokehouse/test-definitions/perf/expectations.js
+++ b/lighthouse-cli/test/smokehouse/test-definitions/perf/expectations.js
@@ -82,7 +82,7 @@ module.exports = [
               {resourceType: 'font', requestCount: 2, transferSize: '81000±1000'},
               {resourceType: 'script', requestCount: 3, transferSize: '55000±1000'},
               {resourceType: 'image', requestCount: 2, transferSize: '28000±1000'},
-              {resourceType: 'document', requestCount: 1, transferSize: '2200±100'},
+              {resourceType: 'document', requestCount: 1, transferSize: '2200±150'},
               {resourceType: 'other', requestCount: 1, transferSize: '1030±100'},
               {resourceType: 'stylesheet', requestCount: 1, transferSize: '450±100'},
               {resourceType: 'media', requestCount: 0, transferSize: 0},