Repository: kubernetes-sigs/security-profiles-operator
Pull request #1115 (2022-08-24 10:22:54)

Move hasheddan and cmurphy to emeritus state
#### What type of PR is this?


/kind cleanup


#### What this PR does / why we need it:
Both have been great support to this project but are inactive over a year now. I guess it's time to reflect that in the `OWNERS` file.

#### Which issue(s) this PR fixes:

<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.

Fixes #

or

None
-->
None
#### Does this PR have test?
None
<!--
If tests aren't applicable just write N/A.
-->

#### Special notes for your reviewer:
cc @hasheddan @cmurphy 
#### Does this PR introduce a user-facing change?

<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".

For more information on release notes see: https://git.k8s.io/community/contributors/guide/release-notes.md
-->

```release-note
None
```


k8s-ci-robot: [Keywords](https://help.github.com/articles/closing-issues-using-keywords) which can automatically close issues and at(@) or hashtag(#) mentions are not allowed in commit messages.

**The list of commits with invalid commit messages**:

- [9ba67ea](https://github.com/kubernetes-sigs/security-profiles-operator/commits/9ba67eaa0f3ad587193174c6850974dbf5cd969c) Move @hasheddan and @cmurphy to emeritus state

<details>

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
</details>

k8s-ci-robot: [Keywords](https://help.github.com/articles/closing-issues-using-keywords) which can automatically close issues and at(@) mentions are not allowed in the title of a Pull Request.

You can edit the title by writing **/retitle <new-title>** in a comment.

<details>
When GitHub merges a Pull Request, the title is included in the merge commit. To avoid invalid keywords in the merge commit, please edit the title of the PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
</details>

k8s-ci-robot: [APPROVALNOTIFIER] This PR is **APPROVED**

This pull-request has been approved by: *<a href="https://github.com/kubernetes-sigs/security-profiles-operator/pull/1115#" title="Author self-approved">saschagrunert</a>*

The full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes-sigs%2Fsecurity-profiles-operator).

The pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)

<details >
Needs approval from an approver in each of these files:

- ~~[OWNERS](https://github.com/kubernetes-sigs/security-profiles-operator/blob/main/OWNERS)~~ [saschagrunert]

Approvers can indicate their approval by writing `/approve` in a comment
Approvers can cancel approval by writing `/approve cancel` in a comment
</details>
<!-- META={"approvers":[]} -->
k8s-ci-robot: [Keywords](https://help.github.com/articles/closing-issues-using-keywords) which can automatically close issues and at(@) mentions are not allowed in the title of a Pull Request.

You can edit the title by writing **/retitle <new-title>** in a comment.

<details>
When GitHub merges a Pull Request, the title is included in the merge commit. To avoid invalid keywords in the merge commit, please edit the title of the PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
</details>

k8s-ci-robot: [Keywords](https://help.github.com/articles/closing-issues-using-keywords) which can automatically close issues and at(@) mentions are not allowed in the title of a Pull Request.

You can edit the title by writing **/retitle <new-title>** in a comment.

<details>
When GitHub merges a Pull Request, the title is included in the merge commit. To avoid invalid keywords in the merge commit, please edit the title of the PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
</details>

k8s-ci-robot: [Keywords](https://help.github.com/articles/closing-issues-using-keywords) which can automatically close issues and at(@) mentions are not allowed in the title of a Pull Request.

You can edit the title by writing **/retitle <new-title>** in a comment.

<details>
When GitHub merges a Pull Request, the title is included in the merge commit. To avoid invalid keywords in the merge commit, please edit the title of the PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
</details>

codecov-commenter: # [Codecov](https://codecov.io/gh/kubernetes-sigs/security-profiles-operator/pull/1115?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) Report
> Merging [#1115](https://codecov.io/gh/kubernetes-sigs/security-profiles-operator/pull/1115?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) (9ba67ea) into [main](https://codecov.io/gh/kubernetes-sigs/security-profiles-operator/commit/202d89c4511ae61b08f35fd058fd28ae5c3227e1?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) (202d89c) will **not change** coverage.
> The diff coverage is `n/a`.

> :exclamation: Current head 9ba67ea differs from pull request most recent head 7f762b9. Consider uploading reports for the commit 7f762b9 to get more accurate results

```diff
@@           Coverage Diff           @@
##             main    #1115   +/-   ##
=======================================
  Coverage   50.68%   50.68%           
=======================================
  Files          42       42           
  Lines        4735     4735           
=======================================
  Hits         2400     2400           
  Misses       2259     2259           
  Partials       76       76           
```

k8s-ci-robot: [APPROVALNOTIFIER] This PR is **APPROVED**

This pull-request has been approved by: *<a href="https://github.com/kubernetes-sigs/security-profiles-operator/pull/1115#pullrequestreview-1083551165" title="LGTM">JAORMX</a>*, *<a href="https://github.com/kubernetes-sigs/security-profiles-operator/pull/1115#" title="Author self-approved">saschagrunert</a>*

The full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes-sigs%2Fsecurity-profiles-operator).

The pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)

<details >
Needs approval from an approver in each of these files:

- ~~[OWNERS](https://github.com/kubernetes-sigs/security-profiles-operator/blob/main/OWNERS)~~ [JAORMX,saschagrunert]

Approvers can indicate their approval by writing `/approve` in a comment
Approvers can cancel approval by writing `/approve cancel` in a comment
</details>
<!-- META={"approvers":[]} -->
k8s-ci-robot: @saschagrunert: The following test **failed**, say `/retest` to rerun all failed tests or `/retest-required` to rerun all mandatory failed tests:

Test name | Commit | Details | Required | Rerun command
--- | --- | --- | --- | ---
pull-security-profiles-operator-test-e2e | 7f762b9e52a87d00a8c2a32a2e77c808be10a5a0 | [link](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_security-profiles-operator/1115/pull-security-profiles-operator-test-e2e/1562385548176265216) | true | `/test pull-security-profiles-operator-test-e2e`

[Full PR test history](https://prow.k8s.io/pr-history?org=kubernetes-sigs&repo=security-profiles-operator&pr=1115). [Your PR dashboard](https://prow.k8s.io/pr?query=is%3Apr%20state%3Aopen%20author%3Asaschagrunert). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/sig-testing/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes-sigs/security-profiles-operator/issues?q=is:issue+is:open) when you hit one in your PR.

<details>

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
</details>
<!-- test report -->
JAORMX: /retest

Patch:
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 945fafa08..314f9c62c 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -5,7 +5,7 @@ on:
       - main
   pull_request:
 env:
-  GO_VERSION: '1.18'
+  GO_VERSION: '1.19'
 permissions:
   actions: none
   checks: none
diff --git a/OWNERS b/OWNERS
index 06c1fa0a8..05016f01f 100644
--- a/OWNERS
+++ b/OWNERS
@@ -1,10 +1,10 @@
 # See the OWNERS docs at https://go.k8s.io/owners
 
 approvers:
-  - hasheddan
   - pjbgf
   - saschagrunert
   - JAORMX
   - jhrozek
-reviewers:
+emeritus_approvers:
   - cmurphy
+  - hasheddan
diff --git a/dependencies.yaml b/dependencies.yaml
index 92427bebf..7bc3227a9 100644
--- a/dependencies.yaml
+++ b/dependencies.yaml
@@ -1,6 +1,6 @@
 dependencies:
   - name: go
-    version: 1.18
+    version: 1.19
     refPaths:
     - path: .github/workflows/build.yml
       match: GO_VERSION
@@ -12,6 +12,8 @@ dependencies:
       match: GO_VERSION
     - path: hack/ci/Vagrantfile-ubuntu
       match: GO_VERSION
+    - path: hack/ci/Vagrantfile-flatcar
+      match: GO_VERSION
 
   - name: golangci-lint
     version: 1.48.0
diff --git a/go.mod b/go.mod
index 13dc9da89..445fb7301 100644
--- a/go.mod
+++ b/go.mod
@@ -1,6 +1,6 @@
 module sigs.k8s.io/security-profiles-operator
 
-go 1.18
+go 1.19
 
 require (
 	github.com/acobaugh/osrelease v0.0.0-20181218015638-a93a0a55a249
diff --git a/hack/ci/Vagrantfile-fedora b/hack/ci/Vagrantfile-fedora
index 52e7c6400..eb7640ff5 100644
--- a/hack/ci/Vagrantfile-fedora
+++ b/hack/ci/Vagrantfile-fedora
@@ -24,7 +24,7 @@ Vagrant.configure("2") do |config|
       # Use a non-localhost DNS to avoid cluster DNS lookup loops
       echo "nameserver 8.8.8.8" > /etc/resolv.conf
 
-      GO_VERSION=1.18
+      GO_VERSION=1.19
       curl -sSfL -o- https://dl.google.com/go/go"$GO_VERSION".linux-amd64.tar.gz |
         tar xfz - -C /usr/local
 
diff --git a/hack/ci/Vagrantfile-flatcar b/hack/ci/Vagrantfile-flatcar
index ae2f99e9a..045a71e46 100644
--- a/hack/ci/Vagrantfile-flatcar
+++ b/hack/ci/Vagrantfile-flatcar
@@ -6,14 +6,14 @@ Vagrant.configure("2") do |config|
   config.vm.box_check_update = true
   config.vm.box_url = "https://lts.release.flatcar-linux.net/amd64-usr/current/flatcar_production_vagrant.json"
   memory = 8192
-  cpus = 4 
+  cpus = 4
 
   config.vm.provider :virtualbox do |v|
      v.customize [
       "modifyvm", :id,
       "--memory", memory,
       "--paravirtprovider", "default",
-      "--cpus", cpus 
+      "--cpus", cpus
     ]
     v.check_guest_additions = false
     v.functional_vboxsf = false
@@ -53,12 +53,12 @@ Vagrant.configure("2") do |config|
       systemctl enable --now containerd
       systemctl restart containerd.service
 
-      # Import the test image of security profiles operator 
+      # Import the test image of security profiles operator
       ctr -n=k8s.io image import /vagrant/image.tar
       crictl --runtime-endpoint="unix:///run/containerd/containerd.sock" images
 
       # Install Go
-      GO_VERSION=1.18
+      GO_VERSION=1.19
       mkdir /opt/go
       curl -sSfL -o- https://golang.org/dl/go$GO_VERSION.linux-amd64.tar.gz | tar xfz - -C /opt
 
@@ -68,7 +68,7 @@ Vagrant.configure("2") do |config|
       br_netfilter
       EOF
 
-      # Setup Networking 
+      # Setup Networking
       cat <<EOF | sudo tee /etc/sysctl.d/99-kubernetes-cri.conf
       net.bridge.bridge-nf-call-iptables  = 1
       net.ipv4.ip_forward                 = 1
diff --git a/hack/ci/Vagrantfile-ubuntu b/hack/ci/Vagrantfile-ubuntu
index 6b5ed1b48..358d1d7b8 100644
--- a/hack/ci/Vagrantfile-ubuntu
+++ b/hack/ci/Vagrantfile-ubuntu
@@ -25,7 +25,7 @@ Vagrant.configure("2") do |config|
       # Use a non-localhost DNS to avoid cluster DNS lookup loops
       echo "nameserver 8.8.8.8" > /etc/resolv.conf
 
-      GO_VERSION=1.18
+      GO_VERSION=1.19
       curl -sSfL -o- https://dl.google.com/go/go"$GO_VERSION".linux-amd64.tar.gz |
         tar xfz - -C /usr/local
 
diff --git a/nix/derivation-bpf.nix b/nix/derivation-bpf.nix
index f0c70a7a9..8febeb639 100644
--- a/nix/derivation-bpf.nix
+++ b/nix/derivation-bpf.nix
@@ -1,5 +1,5 @@
 { pkgs, buildGoModule, arch ? "x86" }:
-with pkgs; buildGo118Module rec {
+with pkgs; buildGo119Module rec {
   name = "security-profiles-operator";
   src = builtins.filterSource
     (path: type: !(type == "directory" && baseNameOf path == "build")) ./..;
@@ -15,7 +15,10 @@ with pkgs; buildGo118Module rec {
     which
   ];
   buildInputs = [
-    (libseccomp.overrideAttrs (x: { dontDisableStatic = true; }))
+    (libseccomp.overrideAttrs (x: {
+      doCheck = false;
+      dontDisableStatic = true;
+    }))
     glibc
     glibc.static
     libbpf
diff --git a/nix/derivation.nix b/nix/derivation.nix
index 5a300cc5b..e11ead52a 100644
--- a/nix/derivation.nix
+++ b/nix/derivation.nix
@@ -1,5 +1,5 @@
 { pkgs, buildGoModule }:
-with pkgs; buildGo118Module rec {
+with pkgs; buildGo119Module rec {
   name = "security-profiles-operator";
   src = builtins.filterSource
     (path: type: !(type == "directory" && baseNameOf path == "build")) ./..;
@@ -12,7 +12,10 @@ with pkgs; buildGo118Module rec {
     which
   ];
   buildInputs = [
-    (libseccomp.overrideAttrs (x: { dontDisableStatic = true; }))
+    (libseccomp.overrideAttrs (x: {
+      doCheck = false;
+      dontDisableStatic = true;
+    }))
     elfutils
     glibc
     glibc.static
diff --git a/nix/nixpkgs.json b/nix/nixpkgs.json
index 2003b66b5..caeff42ba 100644
--- a/nix/nixpkgs.json
+++ b/nix/nixpkgs.json
@@ -1,9 +1,9 @@
 {
   "url": "https://github.com/nixos/nixpkgs",
-  "rev": "df8f580137e9120ffc60b2cc85d62fcc928c2eab",
-  "date": "2022-07-12T06:23:42+00:00",
-  "path": "/nix/store/7ddkc6rqgnvvhxwi0dqzsga49jrhwqwx-nixpkgs",
-  "sha256": "1ih3xk0vmnr2ywga2fmisvyaz4nrqf647821r811zl7hv37qhv75",
+  "rev": "9d48848775e34286e67a283c0b2c5bcf0e3272e3",
+  "date": "2022-08-23T11:32:36+02:00",
+  "path": "/nix/store/vffk9jif083qi0f59l396i1g6nhhh05p-nixpkgs",
+  "sha256": "0v0mdnp9zlgavhc7ikfxaa2a5xw79x97f8fy5y8z332ayksnb433",
   "fetchLFS": false,
   "fetchSubmodules": false,
   "deepClone": false,


Test patch:
diff --git a/.github/workflows/olm_tests.yaml b/.github/workflows/olm_tests.yaml
index e7c072c7e..f8b8487cd 100644
--- a/.github/workflows/olm_tests.yaml
+++ b/.github/workflows/olm_tests.yaml
@@ -5,7 +5,7 @@ on:
       - main
   pull_request:
 env:
-  GO_VERSION: '1.18'
+  GO_VERSION: '1.19'
   KIND_IMG_TAG: v1.23.4
 permissions:
   actions: none
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index 777ec1b63..ccacdf2b8 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -5,7 +5,7 @@ on:
       - main
   pull_request:
 env:
-  GO_VERSION: '1.18'
+  GO_VERSION: '1.19'
 permissions:
   actions: none
   checks: none