Repository: kubernetes-sigs/security-profiles-operator
Pull request #1126 (2022-08-26 12:58:39)

Remove unused env variable

<!--  Thanks for sending a pull request!  Here are some tips for you:

- If this is your first time, please read our contributor guidelines: https://git.k8s.io/community/contributors/guide#your-first-contribution and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide
- Please label this pull request according to what type of issue you are addressing, especially if this is a release targeted pull request. For reference on required PR/issue labels, read here:
https://git.k8s.io/community/contributors/devel/sig-release/release.md#issuepr-kind-label
- If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/guide/pull-requests.md#best-practices-for-faster-reviews
- If the PR is unfinished, see how to mark it: https://git.k8s.io/community/contributors/guide/pull-requests.md#marking-unfinished-pull-requests
-->

#### What type of PR is this?
/kind cleanup

<!--
Add one of the following kinds:
/kind bug
/kind documentation
/kind feature
/kind design

Optionally add one or more of the following kinds if applicable:
/kind api-change
/kind deprecation
/kind failing-test
/kind flake
/kind regression
-->

#### What this PR does / why we need it:
A little cleanup.

#### Which issue(s) this PR fixes:
None

<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.

Fixes #

or

None
-->

#### Does this PR have test?
N/A

<!--
If tests aren't applicable just write N/A.
-->

#### Special notes for your reviewer:
N/A

#### Does this PR introduce a user-facing change?

<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".

For more information on release notes see: https://git.k8s.io/community/contributors/guide/release-notes.md
-->

```release-note
NONE
```


k8s-ci-robot: [APPROVALNOTIFIER] This PR is **APPROVED**

This pull-request has been approved by: *<a href="https://github.com/kubernetes-sigs/security-profiles-operator/pull/1126#" title="Author self-approved">jhrozek</a>*

The full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes-sigs%2Fsecurity-profiles-operator).

The pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)

<details >
Needs approval from an approver in each of these files:

- ~~[OWNERS](https://github.com/kubernetes-sigs/security-profiles-operator/blob/main/OWNERS)~~ [jhrozek]

Approvers can indicate their approval by writing `/approve` in a comment
Approvers can cancel approval by writing `/approve cancel` in a comment
</details>
<!-- META={"approvers":[]} -->
k8s-ci-robot: [APPROVALNOTIFIER] This PR is **APPROVED**

This pull-request has been approved by: *<a href="https://github.com/kubernetes-sigs/security-profiles-operator/pull/1126#pullrequestreview-1086981982" title="LGTM">JAORMX</a>*, *<a href="https://github.com/kubernetes-sigs/security-profiles-operator/pull/1126#" title="Author self-approved">jhrozek</a>*

The full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes-sigs%2Fsecurity-profiles-operator).

The pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)

<details >
Needs approval from an approver in each of these files:

- ~~[OWNERS](https://github.com/kubernetes-sigs/security-profiles-operator/blob/main/OWNERS)~~ [JAORMX,jhrozek]

Approvers can indicate their approval by writing `/approve` in a comment
Approvers can cancel approval by writing `/approve cancel` in a comment
</details>
<!-- META={"approvers":[]} -->

Patch:
diff --git a/hacking.md b/hacking.md
index 36f401390..9d4d76fb3 100644
--- a/hacking.md
+++ b/hacking.md
@@ -228,8 +228,6 @@ source file:
    use the `oci-seccomp-bpf-hook`.
 - `E2E_TEST_BPF_RECORDER` - Whether to test recording of seccomp profiles
    using our eBPF recorder. Currently, enabled for Fedora only.
-- `E2E_TEST_LABEL_POD_DENIALS` - Whether to test that pods which trigger policy
-   denials are labeled. Currently, enabled for Fedora only.
 
 ### Running the Fedora or Ubuntu e2e tests on a local VM
 Some e2e tests, especially the SELinux based ones require a VM,


Test patch:
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index 9980173ac..5a166498f 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -97,9 +97,9 @@ jobs:
         run: $RUN hack/ci/e2e-fedora.sh
       - name: Run Flaky E2E tests
         continue-on-error: true
-        run: $RUN hack/ci/e2e-fedora.sh
-        env:
-          E2E_TEST_FLAKY_TESTS_ONLY: true
+        run: |
+          $RUN "echo \"export E2E_TEST_FLAKY_TESTS_ONLY=true\" >> /vagrant/hack/ci/env-fedora.sh"
+          $RUN hack/ci/e2e-fedora.sh
       - name: Print generated RBAC rules
         run: $RUN hack/ci/print-rbac.sh
 
@@ -135,9 +135,9 @@ jobs:
         run: $RUN hack/ci/e2e-ubuntu.sh
       - name: Run Flaky E2E tests
         continue-on-error: true
-        run: $RUN hack/ci/e2e-ubuntu.sh
-        env:
-          E2E_TEST_FLAKY_TESTS_ONLY: true
+        run: |
+          $RUN "echo \"export E2E_TEST_FLAKY_TESTS_ONLY=true\" >> /vagrant/hack/ci/env-ubuntu.sh"
+          $RUN hack/ci/e2e-ubuntu.sh
 
   e2e-flatcar:
    needs: image
@@ -177,6 +177,6 @@ jobs:
         run: $RUN hack/ci/e2e-flatcar-dev-container.sh
       - name: Run Flaky E2E tests
         continue-on-error: true
-        run: $RUN hack/ci/e2e-flatcar-dev-container.sh
-        env:
-          E2E_TEST_FLAKY_TESTS_ONLY: true
+        run: |
+          $RUN "echo \"export E2E_TEST_FLAKY_TESTS_ONLY=true\" >> /vagrant/hack/ci/env-flatcar.sh"
+          $RUN hack/ci/e2e-flatcar-dev-container.sh
diff --git a/hack/ci/e2e-fedora.sh b/hack/ci/e2e-fedora.sh
index 31645b78a..e16cf4971 100755
--- a/hack/ci/e2e-fedora.sh
+++ b/hack/ci/e2e-fedora.sh
@@ -18,7 +18,6 @@ set -euo pipefail
 export E2E_CLUSTER_TYPE=vanilla
 export E2E_TEST_SELINUX=true
 export E2E_TEST_LOG_ENRICHER=true
-export E2E_TEST_LABEL_POD_DENIALS=true
 export E2E_TEST_BPF_RECORDER=true
 export E2E_TEST_PROFILE_RECORDING=true
 export E2E_TEST_FLAKY_TESTS_ONLY=${E2E_TEST_FLAKY_TESTS_ONLY:-false}
diff --git a/hack/ci/e2e-static-webhook.sh b/hack/ci/e2e-static-webhook.sh
index ae8b646fa..ada3186ae 100755
--- a/hack/ci/e2e-static-webhook.sh
+++ b/hack/ci/e2e-static-webhook.sh
@@ -19,7 +19,6 @@ export E2E_CLUSTER_TYPE=vanilla
 export OPERATOR_MANIFEST="deploy/webhook-operator.yaml" 
 export E2E_TEST_SELINUX=true
 export E2E_TEST_LOG_ENRICHER=true
-export E2E_TEST_LABEL_POD_DENIALS=true
 export E2E_TEST_BPF_RECORDER=true
 export E2E_TEST_PROFILE_RECORDING=true
 export E2E_SKIP_NAMESPACED_TESTS=true