Repository: gitify-app/gitify
Pull request #1287 (2024-06-20 01:58:10)

refactor(avatar): remove cursor style
No need to cursor to be on the Avatar component itself.  


Patch:
diff --git a/src/components/icons/AvatarIcon.tsx b/src/components/icons/AvatarIcon.tsx
index b867a733..cd0e53e1 100644
--- a/src/components/icons/AvatarIcon.tsx
+++ b/src/components/icons/AvatarIcon.tsx
@@ -15,7 +15,7 @@ export const AvatarIcon: FC<IAvatarIcon> = (props: IAvatarIcon) => {
     return (
       <img
         className={cn(
-          'cursor-pointer rounded-full object-cover',
+          'rounded-full object-cover',
           props.size === Size.XSMALL
             ? 'size-4'
             : props.size === Size.SMALL


Test patch:
diff --git a/src/components/__snapshots__/AccountNotifications.test.tsx.snap b/src/components/__snapshots__/AccountNotifications.test.tsx.snap
index 8f120478..c041d6ed 100644
--- a/src/components/__snapshots__/AccountNotifications.test.tsx.snap
+++ b/src/components/__snapshots__/AccountNotifications.test.tsx.snap
@@ -102,7 +102,7 @@ exports[`components/AccountNotifications.tsx should render itself (github.com wi
             <span>
               <img
                 alt="gitify-app/notifications-test's avatar"
-                class="cursor-pointer rounded-full object-cover size-5"
+                class="rounded-full object-cover size-5"
                 src="https://avatars.githubusercontent.com/u/133795385?s=200&v=4"
               />
             </span>
@@ -130,7 +130,7 @@ exports[`components/AccountNotifications.tsx should render itself (github.com wi
             >
               <img
                 alt="gitify-app's avatar"
-                class="cursor-pointer rounded-full object-cover size-4"
+                class="rounded-full object-cover size-4"
                 src="https://avatars.githubusercontent.com/u/133795385?s=200&v=4"
               />
             </button>
@@ -299,7 +299,7 @@ exports[`components/AccountNotifications.tsx should render itself (github.com wi
             <span>
               <img
                 alt="gitify-app/notifications-test's avatar"
-                class="cursor-pointer rounded-full object-cover size-5"
+                class="rounded-full object-cover size-5"
                 src="https://avatars.githubusercontent.com/u/133795385?s=200&v=4"
               />
             </span>
@@ -519,7 +519,7 @@ exports[`components/AccountNotifications.tsx should render itself (github.com wi
           <span>
             <img
               alt="gitify-app/notifications-test's avatar"
-              class="cursor-pointer rounded-full object-cover size-5"
+              class="rounded-full object-cover size-5"
               src="https://avatars.githubusercontent.com/u/133795385?s=200&v=4"
             />
           </span>
@@ -547,7 +547,7 @@ exports[`components/AccountNotifications.tsx should render itself (github.com wi
           >
             <img
               alt="gitify-app's avatar"
-              class="cursor-pointer rounded-full object-cover size-4"
+              class="rounded-full object-cover size-4"
               src="https://avatars.githubusercontent.com/u/133795385?s=200&v=4"
             />
           </button>
@@ -716,7 +716,7 @@ exports[`components/AccountNotifications.tsx should render itself (github.com wi
           <span>
             <img
               alt="gitify-app/notifications-test's avatar"
-              class="cursor-pointer rounded-full object-cover size-5"
+              class="rounded-full object-cover size-5"
               src="https://avatars.githubusercontent.com/u/133795385?s=200&v=4"
             />
           </span>
diff --git a/src/components/__snapshots__/NotificationRow.test.tsx.snap b/src/components/__snapshots__/NotificationRow.test.tsx.snap
index 0db30480..76a85056 100644
--- a/src/components/__snapshots__/NotificationRow.test.tsx.snap
+++ b/src/components/__snapshots__/NotificationRow.test.tsx.snap
@@ -4673,7 +4673,7 @@ exports[`components/NotificationRow.tsx should render itself & its children - gr
             <span>
               <img
                 alt="gitify-app/notifications-test's avatar"
-                class="cursor-pointer rounded-full object-cover size-5"
+                class="rounded-full object-cover size-5"
                 src="https://avatars.githubusercontent.com/u/133795385?s=200&v=4"
               />
             </span>
@@ -4701,7 +4701,7 @@ exports[`components/NotificationRow.tsx should render itself & its children - gr
             >
               <img
                 alt="gitify-app's avatar"
-                class="cursor-pointer rounded-full object-cover size-4"
+                class="rounded-full object-cover size-4"
                 src="https://avatars.githubusercontent.com/u/133795385?s=200&v=4"
               />
             </button>
@@ -4873,7 +4873,7 @@ exports[`components/NotificationRow.tsx should render itself & its children - gr
           <span>
             <img
               alt="gitify-app/notifications-test's avatar"
-              class="cursor-pointer rounded-full object-cover size-5"
+              class="rounded-full object-cover size-5"
               src="https://avatars.githubusercontent.com/u/133795385?s=200&v=4"
             />
           </span>
@@ -4901,7 +4901,7 @@ exports[`components/NotificationRow.tsx should render itself & its children - gr
           >
             <img
               alt="gitify-app's avatar"
-              class="cursor-pointer rounded-full object-cover size-4"
+              class="rounded-full object-cover size-4"
               src="https://avatars.githubusercontent.com/u/133795385?s=200&v=4"
             />
           </button>
@@ -5140,7 +5140,7 @@ exports[`components/NotificationRow.tsx should render itself & its children - gr
             >
               <img
                 alt="gitify-app's avatar"
-                class="cursor-pointer rounded-full object-cover size-4"
+                class="rounded-full object-cover size-4"
                 src="https://avatars.githubusercontent.com/u/133795385?s=200&v=4"
               />
             </button>
@@ -5322,7 +5322,7 @@ exports[`components/NotificationRow.tsx should render itself & its children - gr
           >
             <img
               alt="gitify-app's avatar"
-              class="cursor-pointer rounded-full object-cover size-4"
+              class="rounded-full object-cover size-4"
               src="https://avatars.githubusercontent.com/u/133795385?s=200&v=4"
             />
           </button>
@@ -5561,7 +5561,7 @@ exports[`components/NotificationRow.tsx should render itself & its children when
             >
               <img
                 alt="gitify-app's avatar"
-                class="cursor-pointer rounded-full object-cover size-4"
+                class="rounded-full object-cover size-4"
                 src="https://avatars.githubusercontent.com/u/133795385?s=200&v=4"
               />
             </button>
@@ -5743,7 +5743,7 @@ exports[`components/NotificationRow.tsx should render itself & its children when
           >
             <img
               alt="gitify-app's avatar"
-              class="cursor-pointer rounded-full object-cover size-4"
+              class="rounded-full object-cover size-4"
               src="https://avatars.githubusercontent.com/u/133795385?s=200&v=4"
             />
           </button>
diff --git a/src/components/__snapshots__/RepositoryNotifications.test.tsx.snap b/src/components/__snapshots__/RepositoryNotifications.test.tsx.snap
index f9d7f0d8..9a5c686d 100644
--- a/src/components/__snapshots__/RepositoryNotifications.test.tsx.snap
+++ b/src/components/__snapshots__/RepositoryNotifications.test.tsx.snap
@@ -13,7 +13,7 @@ exports[`components/Repository.tsx should render itself & its children 1`] = `
         >
           <img
             alt="gitify-app/notifications-test's avatar"
-            class="cursor-pointer rounded-full object-cover size-6"
+            class="rounded-full object-cover size-6"
             src="https://avatars.githubusercontent.com/u/133795385?s=200&v=4"
           />
           <span
@@ -107,7 +107,7 @@ exports[`components/Repository.tsx should render itself & its children 1`] = `
       >
         <img
           alt="gitify-app/notifications-test's avatar"
-          class="cursor-pointer rounded-full object-cover size-6"
+          class="rounded-full object-cover size-6"
           src="https://avatars.githubusercontent.com/u/133795385?s=200&v=4"
         />
         <span
diff --git a/src/components/icons/__snapshots__/AvatarIcon.test.tsx.snap b/src/components/icons/__snapshots__/AvatarIcon.test.tsx.snap
index f455c2b5..83144063 100644
--- a/src/components/icons/__snapshots__/AvatarIcon.test.tsx.snap
+++ b/src/components/icons/__snapshots__/AvatarIcon.test.tsx.snap
@@ -98,7 +98,7 @@ exports[`components/icons/AvatarIcon.tsx should render medium avatar 1`] = `
     <div>
       <img
         alt="test's avatar"
-        class="cursor-pointer rounded-full object-cover size-6"
+        class="rounded-full object-cover size-6"
         src="https://avatars.githubusercontent.com/u/583231?v=4"
       />
     </div>
@@ -106,7 +106,7 @@ exports[`components/icons/AvatarIcon.tsx should render medium avatar 1`] = `
   "container": <div>
     <img
       alt="test's avatar"
-      class="cursor-pointer rounded-full object-cover size-6"
+      class="rounded-full object-cover size-6"
       src="https://avatars.githubusercontent.com/u/583231?v=4"
     />
   </div>,
@@ -171,7 +171,7 @@ exports[`components/icons/AvatarIcon.tsx should render medium avatar 2`] = `
     <div>
       <img
         alt="test's avatar"
-        class="cursor-pointer rounded-full object-cover size-6"
+        class="rounded-full object-cover size-6"
         src="https://avatars.githubusercontent.com/u/583231?v=4"
       />
     </div>
@@ -179,7 +179,7 @@ exports[`components/icons/AvatarIcon.tsx should render medium avatar 2`] = `
   "container": <div>
     <img
       alt="test's avatar"
-      class="cursor-pointer rounded-full object-cover size-6"
+      class="rounded-full object-cover size-6"
       src="https://avatars.githubusercontent.com/u/583231?v=4"
     />
   </div>,
@@ -244,7 +244,7 @@ exports[`components/icons/AvatarIcon.tsx should render small avatar 1`] = `
     <div>
       <img
         alt="test's avatar"
-        class="cursor-pointer rounded-full object-cover size-4"
+        class="rounded-full object-cover size-4"
         src="https://avatars.githubusercontent.com/u/583231?v=4"
       />
     </div>
@@ -252,7 +252,7 @@ exports[`components/icons/AvatarIcon.tsx should render small avatar 1`] = `
   "container": <div>
     <img
       alt="test's avatar"
-      class="cursor-pointer rounded-full object-cover size-4"
+      class="rounded-full object-cover size-4"
       src="https://avatars.githubusercontent.com/u/583231?v=4"
     />
   </div>,