Repository: hyperjumptech/monika
Pull request #1128 (2023-10-02 07:21:42)

Refactor: Remove isProbeResponsive Field
# Monika Pull Request (PR)

## What feature/issue does this PR add
Remove `isProbeResponsive` field since it is redundant with `probeRequestResult`.

## How did you implement / how did you fix it
1. Search `isProbeResponsive` and remove it.

## How to test
1. Run Monika as usual
2. Run the tests


codecov[bot]: ## [Codecov](https://app.codecov.io/gh/hyperjumptech/monika/pull/1128?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hyperjumptech) Report
> Merging [#1128](https://app.codecov.io/gh/hyperjumptech/monika/pull/1128?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hyperjumptech) (ca46d22) into [main](https://app.codecov.io/gh/hyperjumptech/monika/commit/c44344fec4e2a3beae6653b1ddff99f32abba513?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hyperjumptech) (c44344f) will **increase** coverage by `0.26%`.
> Report is 1 commits behind head on main.
> The diff coverage is `n/a`.

> :exclamation: Current head ca46d22 differs from pull request most recent head 1cdd663. Consider uploading reports for the commit 1cdd663 to get more accurate results

```diff
@@            Coverage Diff             @@
##             main    #1128      +/-   ##
==========================================
+ Coverage   60.58%   60.84%   +0.26%     
==========================================
  Files         111      111              
  Lines        3217     3213       -4     
  Branches      633      633              
==========================================
+ Hits         1949     1955       +6     
+ Misses        996      983      -13     
- Partials      272      275       +3     
```


| [Files](https://app.codecov.io/gh/hyperjumptech/monika/pull/1128?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hyperjumptech) | Coverage Δ | |
|---|---|---|
| [src/components/probe/prober/http/request.ts](https://app.codecov.io/gh/hyperjumptech/monika/pull/1128?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hyperjumptech#diff-c3JjL2NvbXBvbmVudHMvcHJvYmUvcHJvYmVyL2h0dHAvcmVxdWVzdC50cw==) | `68.68% <ø> (ø)` | |
| [src/components/probe/prober/icmp/request.ts](https://app.codecov.io/gh/hyperjumptech/monika/pull/1128?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hyperjumptech#diff-c3JjL2NvbXBvbmVudHMvcHJvYmUvcHJvYmVyL2ljbXAvcmVxdWVzdC50cw==) | `15.38% <ø> (ø)` | |
| [src/components/probe/prober/mariadb/request.ts](https://app.codecov.io/gh/hyperjumptech/monika/pull/1128?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hyperjumptech#diff-c3JjL2NvbXBvbmVudHMvcHJvYmUvcHJvYmVyL21hcmlhZGIvcmVxdWVzdC50cw==) | `82.75% <ø> (-0.58%)` | :arrow_down: |
| [src/components/probe/prober/mongo/request.ts](https://app.codecov.io/gh/hyperjumptech/monika/pull/1128?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hyperjumptech#diff-c3JjL2NvbXBvbmVudHMvcHJvYmUvcHJvYmVyL21vbmdvL3JlcXVlc3QudHM=) | `82.60% <ø> (-0.38%)` | :arrow_down: |
| [src/components/probe/prober/postgres/request.ts](https://app.codecov.io/gh/hyperjumptech/monika/pull/1128?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hyperjumptech#diff-c3JjL2NvbXBvbmVudHMvcHJvYmUvcHJvYmVyL3Bvc3RncmVzL3JlcXVlc3QudHM=) | `76.47% <ø> (-0.68%)` | :arrow_down: |
| [src/components/probe/prober/redis/request.ts](https://app.codecov.io/gh/hyperjumptech/monika/pull/1128?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hyperjumptech#diff-c3JjL2NvbXBvbmVudHMvcHJvYmUvcHJvYmVyL3JlZGlzL3JlcXVlc3QudHM=) | `78.12% <ø> (-0.67%)` | :arrow_down: |
| [src/components/probe/prober/socket/request.ts](https://app.codecov.io/gh/hyperjumptech/monika/pull/1128?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hyperjumptech#diff-c3JjL2NvbXBvbmVudHMvcHJvYmUvcHJvYmVyL3NvY2tldC9yZXF1ZXN0LnRz) | `63.15% <ø> (ø)` | |
| [src/interfaces/request.ts](https://app.codecov.io/gh/hyperjumptech/monika/pull/1128?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hyperjumptech#diff-c3JjL2ludGVyZmFjZXMvcmVxdWVzdC50cw==) | `100.00% <ø> (ø)` | |
| [src/jobs/tls-check.ts](https://app.codecov.io/gh/hyperjumptech/monika/pull/1128?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hyperjumptech#diff-c3JjL2pvYnMvdGxzLWNoZWNrLnRz) | `29.41% <ø> (ø)` | |

... and [2 files with indirect coverage changes](https://app.codecov.io/gh/hyperjumptech/monika/pull/1128/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hyperjumptech)

:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hyperjumptech)


Patch:
diff --git a/src/components/probe/prober/http/request.ts b/src/components/probe/prober/http/request.ts
index 61adc529..de6abd10 100644
--- a/src/components/probe/prober/http/request.ts
+++ b/src/components/probe/prober/http/request.ts
@@ -167,7 +167,6 @@ export async function httpRequest({
       headers,
       responseTime,
       result: probeRequestResult.success,
-      isProbeResponsive: true,
     }
   } catch (error: any) {
     const responseTime = Date.now() - requestStartedAt
@@ -182,7 +181,6 @@ export async function httpRequest({
         headers: error?.response?.headers,
         responseTime,
         result: probeRequestResult.success,
-        isProbeResponsive: true, // http status received, so connection ok
       }
     }
 
@@ -198,7 +196,6 @@ export async function httpRequest({
         headers: '',
         responseTime,
         result: probeRequestResult.failed,
-        isProbeResponsive: false,
         errMessage: error?.code,
       }
     }
@@ -211,7 +208,6 @@ export async function httpRequest({
       headers: '',
       responseTime,
       result: probeRequestResult.failed,
-      isProbeResponsive: false,
       errMessage: error.code || 'Unknown error',
     }
   }
diff --git a/src/components/probe/prober/icmp/index.ts b/src/components/probe/prober/icmp/index.ts
index e2307d6f..79c80619 100644
--- a/src/components/probe/prober/icmp/index.ts
+++ b/src/components/probe/prober/icmp/index.ts
@@ -25,6 +25,7 @@
 import type { Ping } from '../../../../interfaces/probe'
 import { BaseProber, type ProbeResult } from '..'
 import { icmpRequest } from './request'
+import { probeRequestResult } from '../../../../interfaces/request'
 
 export class PingProber extends BaseProber {
   async probe(): Promise<void> {
@@ -83,9 +84,9 @@ export async function probePing({
 
   for await (const { uri } of pings) {
     const requestResponse = await icmpRequest({ host: uri })
-    const { isProbeResponsive, responseTime, body } = requestResponse
+    const { responseTime, result, body } = requestResponse
 
-    const isAlertTriggered = isProbeResponsive
+    const isAlertTriggered = result !== probeRequestResult.success
     const timeNow = new Date().toISOString()
     const logMessage = `${timeNow} ${checkOrder} id:${id} ${body} responseTime:${responseTime}`
 
diff --git a/src/components/probe/prober/icmp/request.ts b/src/components/probe/prober/icmp/request.ts
index 4e054672..563fb0f2 100644
--- a/src/components/probe/prober/icmp/request.ts
+++ b/src/components/probe/prober/icmp/request.ts
@@ -60,7 +60,6 @@ export async function icmpRequest(
     result: probeRequestResult.unknown,
     headers: '',
     responseTime: 0,
-    isProbeResponsive: false,
   }
 
   try {
@@ -102,7 +101,5 @@ export function processICMPRequestResult(
     body: msg,
     headers: {},
     responseTime: params.average || 0,
-
-    isProbeResponsive: true,
   }
 }
diff --git a/src/components/probe/prober/mariadb/request.ts b/src/components/probe/prober/mariadb/request.ts
index f59b1631..cf3e8868 100644
--- a/src/components/probe/prober/mariadb/request.ts
+++ b/src/components/probe/prober/mariadb/request.ts
@@ -47,7 +47,6 @@ export async function mariaRequest(
     result: probeRequestResult.unknown,
     headers: '',
     responseTime: 0,
-    isProbeResponsive: false,
   }
 
   const startTime = new Date()
@@ -75,7 +74,6 @@ export async function mariaRequest(
     baseResponse.body = 'database ok'
     baseResponse.status = 200
     baseResponse.result = probeRequestResult.success
-    baseResponse.isProbeResponsive = true
   }
 
   return baseResponse
diff --git a/src/components/probe/prober/mongo/request.ts b/src/components/probe/prober/mongo/request.ts
index f2c6edee..52a5eccf 100644
--- a/src/components/probe/prober/mongo/request.ts
+++ b/src/components/probe/prober/mongo/request.ts
@@ -58,7 +58,6 @@ export async function mongoRequest(
     result: probeRequestResult.unknown,
     headers: '',
     responseTime: 0,
-    isProbeResponsive: false,
   }
   const startTime = new Date()
   const result = await sendMongoRequest(params)
@@ -70,7 +69,6 @@ export async function mongoRequest(
     baseResponse.body = result.message
     baseResponse.status = 200
     baseResponse.result = probeRequestResult.success
-    baseResponse.isProbeResponsive = true
   } else {
     baseResponse.result = probeRequestResult.failed
     baseResponse.body = result.message
diff --git a/src/components/probe/prober/postgres/request.ts b/src/components/probe/prober/postgres/request.ts
index 14924b2c..8e85b0c1 100644
--- a/src/components/probe/prober/postgres/request.ts
+++ b/src/components/probe/prober/postgres/request.ts
@@ -53,7 +53,6 @@ export async function postgresRequest(
     headers: '',
     responseTime: 0,
     result: probeRequestResult.unknown,
-    isProbeResponsive: false,
   }
   const startTime = new Date()
   const result = await sendPsqlRequest(params)
@@ -65,7 +64,6 @@ export async function postgresRequest(
     baseResponse.body = result.message
     baseResponse.status = 200
     baseResponse.result = probeRequestResult.success
-    baseResponse.isProbeResponsive = result.isAlive
   } else {
     baseResponse.result = probeRequestResult.failed
     baseResponse.body = result.message
diff --git a/src/components/probe/prober/redis/request.ts b/src/components/probe/prober/redis/request.ts
index 7d04df5f..bf452f89 100644
--- a/src/components/probe/prober/redis/request.ts
+++ b/src/components/probe/prober/redis/request.ts
@@ -50,7 +50,6 @@ export async function redisRequest(
     headers: '',
     responseTime: 0,
     result: probeRequestResult.unknown,
-    isProbeResponsive: false,
   }
   const startTime = new Date()
   const result = await sendRedisRequest(params)
@@ -61,7 +60,6 @@ export async function redisRequest(
     baseResponse.responseTime = duration
     baseResponse.body = result.message
     baseResponse.status = 200
-    baseResponse.isProbeResponsive = true
     baseResponse.result = probeRequestResult.success
   } else {
     baseResponse.body = result.message
diff --git a/src/components/probe/prober/socket/request.ts b/src/components/probe/prober/socket/request.ts
index 40d39026..d764c3af 100644
--- a/src/components/probe/prober/socket/request.ts
+++ b/src/components/probe/prober/socket/request.ts
@@ -61,8 +61,6 @@ export async function tcpRequest(
         : probeRequestResult.success,
     headers: {},
     responseTime: tcpResp.duration,
-
-    isProbeResponsive: tcpResp.status === 'UP', // map success flag
     errMessage: tcpResp.message, // map message if any
   }
 
diff --git a/src/interfaces/request.ts b/src/interfaces/request.ts
index 4dfcb42b..2373f894 100644
--- a/src/interfaces/request.ts
+++ b/src/interfaces/request.ts
@@ -50,13 +50,9 @@ export interface ProbeRequestResponse<T = any> {
   data: T
   body: T
   status: number
-
   headers: any
   responseTime: number
-
-  isProbeResponsive: boolean // did the command/request response to requests/queries?
   errMessage?: string // any error message from drivers
-
   result: probeRequestResult // did the probe succeed or fail?
 }
 
diff --git a/src/jobs/tls-check.ts b/src/jobs/tls-check.ts
index c848891b..ec573b6a 100644
--- a/src/jobs/tls-check.ts
+++ b/src/jobs/tls-check.ts
@@ -106,7 +106,6 @@ function sendTLSErrorNotification({
         body: {},
         headers: {},
         result: probeRequestResult.success,
-        isProbeResponsive: true,
       },
     }
 


Test patch:
diff --git a/src/components/notification/__tests__/alert-message.test.ts b/src/components/notification/__tests__/alert-message.test.ts
index 29ebeab9..f77c347e 100644
--- a/src/components/notification/__tests__/alert-message.test.ts
+++ b/src/components/notification/__tests__/alert-message.test.ts
@@ -54,7 +54,6 @@ describe('Alert message', () => {
           headers: '',
           responseTime: 1000,
           result: probeRequestResult.success,
-          isProbeResponsive: true,
         },
       })
 
@@ -84,7 +83,6 @@ describe('Alert message', () => {
           headers: '',
           responseTime: 1000,
           result: probeRequestResult.success,
-          isProbeResponsive: true,
         },
       })
 
@@ -122,7 +120,6 @@ describe('Alert message', () => {
           headers: '',
           responseTime: 1000,
           result: probeRequestResult.success,
-          isProbeResponsive: true,
         },
       })
 
@@ -178,7 +175,6 @@ describe('Alert message', () => {
           headers: '',
           responseTime: 1000,
           result: probeRequestResult.success,
-          isProbeResponsive: true,
         },
       })
 
diff --git a/src/components/probe/prober/icmp/index.test.ts b/src/components/probe/prober/icmp/index.test.ts
index b59fbdf5..9ad9c2b9 100644
--- a/src/components/probe/prober/icmp/index.test.ts
+++ b/src/components/probe/prober/icmp/index.test.ts
@@ -45,7 +45,6 @@ describe('Ping/ICMP Prober', () => {
           result: probeRequestResult.failed,
           headers: '',
           responseTime: 0,
-          isProbeResponsive: false,
         }
       })
   })
@@ -119,7 +118,6 @@ describe('Ping/ICMP Prober', () => {
           headers: '',
           responseTime: 0,
           result: probeRequestResult.failed,
-          isProbeResponsive: true,
         }
       })
     const pingParams = {
diff --git a/src/components/probe/prober/mariadb/index.test.ts b/src/components/probe/prober/mariadb/index.test.ts
index 6bc13104..bd6fef08 100644
--- a/src/components/probe/prober/mariadb/index.test.ts
+++ b/src/components/probe/prober/mariadb/index.test.ts
@@ -22,7 +22,6 @@ describe('Maria DB/MySQL Prober', () => {
           headers: '',
           responseTime: 0,
           result: probeRequestResult.failed,
-          isProbeResponsive: false,
         }
       })
   })
@@ -169,7 +168,6 @@ describe('Maria DB/MySQL Prober', () => {
           headers: '',
           responseTime: 0,
           result: probeRequestResult.failed,
-          isProbeResponsive: false,
         }
       })
     const probeParams = {
diff --git a/src/components/probe/prober/mongo/index.test.ts b/src/components/probe/prober/mongo/index.test.ts
index 7b8ace35..c835490c 100644
--- a/src/components/probe/prober/mongo/index.test.ts
+++ b/src/components/probe/prober/mongo/index.test.ts
@@ -22,7 +22,6 @@ describe('MongoDB Prober', () => {
           headers: '',
           responseTime: 0,
           result: probeRequestResult.failed,
-          isProbeResponsive: false,
         }
       })
   })
@@ -100,7 +99,6 @@ describe('MongoDB Prober', () => {
           headers: '',
           responseTime: 0,
           result: probeRequestResult.failed,
-          isProbeResponsive: false,
         }
       })
     const probeParams = {
@@ -138,7 +136,6 @@ describe('MongoDB Prober', () => {
           headers: '',
           responseTime: 0,
           result: probeRequestResult.failed,
-          isProbeResponsive: false,
         }
       })
     const probeParams = {
diff --git a/src/components/probe/prober/postgres/index.test.ts b/src/components/probe/prober/postgres/index.test.ts
index f295df07..5ea0e958 100644
--- a/src/components/probe/prober/postgres/index.test.ts
+++ b/src/components/probe/prober/postgres/index.test.ts
@@ -22,7 +22,6 @@ describe('PostgreSQL Prober', () => {
           headers: '',
           responseTime: 0,
           result: probeRequestResult.failed,
-          isProbeResponsive: false,
         }
       })
   })
@@ -104,7 +103,6 @@ describe('PostgreSQL Prober', () => {
           headers: '',
           responseTime: 0,
           result: probeRequestResult.failed,
-          isProbeResponsive: false,
         }
       })
     const probeParams = {
@@ -144,7 +142,6 @@ describe('PostgreSQL Prober', () => {
           headers: '',
           responseTime: 0,
           result: probeRequestResult.failed,
-          isProbeResponsive: false,
         }
       })
     const probeParams = {
diff --git a/src/components/probe/prober/redis/redis.test.ts b/src/components/probe/prober/redis/redis.test.ts
index 2125973b..45070aa6 100644
--- a/src/components/probe/prober/redis/redis.test.ts
+++ b/src/components/probe/prober/redis/redis.test.ts
@@ -22,7 +22,6 @@ describe('Redis Prober', () => {
           headers: '',
           responseTime: 0,
           result: probeRequestResult.failed,
-          isProbeResponsive: false,
         }
       })
   })
@@ -113,7 +112,6 @@ describe('Redis Prober', () => {
           headers: '',
           responseTime: 0,
           result: probeRequestResult.failed,
-          isProbeResponsive: false,
         }
       })
     const probeParams = {
diff --git a/src/components/probe/prober/socket/index.test.ts b/src/components/probe/prober/socket/index.test.ts
index 77d3229b..44f09d74 100644
--- a/src/components/probe/prober/socket/index.test.ts
+++ b/src/components/probe/prober/socket/index.test.ts
@@ -22,7 +22,6 @@ describe('TCP Prober', () => {
           headers: '',
           responseTime: 0,
           result: probeRequestResult.failed,
-          isProbeResponsive: false,
         }
       })
   })
@@ -66,7 +65,6 @@ describe('TCP Prober', () => {
           headers: '',
           responseTime: 0,
           result: probeRequestResult.failed,
-          isProbeResponsive: false,
         }
       })
     const probeParams = {
diff --git a/src/plugins/metrics/prometheus/collector.test.ts b/src/plugins/metrics/prometheus/collector.test.ts
index a6af72a1..c45a1949 100644
--- a/src/plugins/metrics/prometheus/collector.test.ts
+++ b/src/plugins/metrics/prometheus/collector.test.ts
@@ -78,7 +78,6 @@ describe('Prometheus collector', () => {
           headers: '',
           responseTime: 0,
           result: probeRequestResult.failed,
-          isProbeResponsive: false,
         },
       }
 
@@ -109,7 +108,6 @@ describe('Prometheus collector', () => {
           headers: '',
           responseTime: 0,
           result: probeRequestResult.failed,
-          isProbeResponsive: false,
         },
       }
 
@@ -142,7 +140,6 @@ describe('Prometheus collector', () => {
           status: 0,
           headers: '',
           responseTime: 0,
-          isProbeResponsive: false,
         },
       } as ProbeResult
 
diff --git a/src/plugins/validate-response/checkers/__tests__/index.test.ts b/src/plugins/validate-response/checkers/__tests__/index.test.ts
index c558cfe3..c45d5c4e 100644
--- a/src/plugins/validate-response/checkers/__tests__/index.test.ts
+++ b/src/plugins/validate-response/checkers/__tests__/index.test.ts
@@ -46,7 +46,6 @@ describe('responseChecker', () => {
     it('should handle when response status is 200', () => {
       const res = generateMockedResponse({
         status: 200,
-        isProbeResponsive: true,
       })
       const data = responseChecker(
         {
@@ -63,7 +62,6 @@ describe('responseChecker', () => {
     it('should handle when response status is 201', () => {
       const res = generateMockedResponse({
         status: 201,
-        isProbeResponsive: true,
       })
       const data = responseChecker(
         {
@@ -80,7 +78,6 @@ describe('responseChecker', () => {
     it('should handle when response status is 300', () => {
       const res = generateMockedResponse({
         status: 300,
-        isProbeResponsive: true,
       })
       const data = responseChecker(
         {
@@ -97,7 +94,6 @@ describe('responseChecker', () => {
     it('should handle when response status is 400', () => {
       const res = generateMockedResponse({
         status: 400,
-        isProbeResponsive: true,
       })
       const data = responseChecker(
         {
@@ -114,7 +110,6 @@ describe('responseChecker', () => {
     it('should handle when response status is 500', () => {
       const res = generateMockedResponse({
         status: 500,
-        isProbeResponsive: true,
       })
       const data = responseChecker(
         {
@@ -131,7 +126,6 @@ describe('responseChecker', () => {
     it('should handle query field', () => {
       const res = generateMockedResponse({
         status: 200,
-        isProbeResponsive: true,
       })
       const data = responseChecker(
         {
@@ -159,7 +153,6 @@ describe('responseChecker', () => {
     it('seconds - should handle when response time is less than alert defined response time', () => {
       const res = generateMockedResponse({
         responseTime: 10_000,
-        isProbeResponsive: true,
       })
       const data = responseChecker(
         { id: 'jFQBd', assertion: 'response.time > 20000', message: '' },
@@ -172,7 +165,6 @@ describe('responseChecker', () => {
     it('milliseconds - should handle when response time is greater than alert defined response time', () => {
       const res = generateMockedResponse({
         responseTime: 20,
-        isProbeResponsive: true,
       })
       const data = responseChecker(
         { id: 'jFQBd', assertion: 'response.time > 10', message: '' },
@@ -185,7 +177,6 @@ describe('responseChecker', () => {
     it('milliseconds - should handle when response time is less than alert defined response time', () => {
       const res = generateMockedResponse({
         responseTime: 10,
-        isProbeResponsive: true,
       })
       const data = responseChecker(
         { id: 'jFQBd', assertion: 'response.time > 20', message: '' },
diff --git a/src/plugins/validate-response/checkers/__tests__/query-expression.test.ts b/src/plugins/validate-response/checkers/__tests__/query-expression.test.ts
index 08a9d2cb..a0578682 100644
--- a/src/plugins/validate-response/checkers/__tests__/query-expression.test.ts
+++ b/src/plugins/validate-response/checkers/__tests__/query-expression.test.ts
@@ -35,7 +35,6 @@ describe('queryExpression', () => {
       headers: {},
       responseTime: 150,
       result: probeRequestResult.success,
-      isProbeResponsive: true,
     }
 
     const result = queryExpression(res, 'response.time > 1000')
@@ -51,7 +50,6 @@ describe('queryExpression', () => {
       headers: {},
       responseTime: 200,
       result: probeRequestResult.success,
-      isProbeResponsive: true,
     }
 
     const result = queryExpression(res, 'response.status != 200')
@@ -67,7 +65,6 @@ describe('queryExpression', () => {
       headers: { 'content-length': 2000 },
       responseTime: 200,
       result: probeRequestResult.success,
-      isProbeResponsive: true,
     }
 
     const result = queryExpression(res, 'response.size < 1000')
@@ -83,7 +80,6 @@ describe('queryExpression', () => {
       headers: { 'Content-Type': 'application/json' },
       responseTime: 200,
       result: probeRequestResult.success,
-      isProbeResponsive: true,
     }
 
     const result = queryExpression(
@@ -106,7 +102,6 @@ describe('queryExpression', () => {
         message: 'Hello',
       },
       result: probeRequestResult.success,
-      isProbeResponsive: true,
     }
 
     const result = queryExpression(
diff --git a/test/components/notification.test.ts b/test/components/notification.test.ts
index 8c4180e8..46c35438 100644
--- a/test/components/notification.test.ts
+++ b/test/components/notification.test.ts
@@ -53,7 +53,6 @@ describe('send alerts', () => {
           responseTime: 0,
           headers: {},
           result: probeRequestResult.success,
-          isProbeResponsive: true,
         },
       },
       notifications: [
@@ -87,7 +86,6 @@ describe('send alerts', () => {
           responseTime: 0,
           headers: {},
           result: probeRequestResult.success,
-          isProbeResponsive: true,
         },
       },
       notifications: [
@@ -121,7 +119,6 @@ describe('send alerts', () => {
           responseTime: 0,
           headers: {},
           result: probeRequestResult.success,
-          isProbeResponsive: true,
         },
       },
       notifications: [
@@ -156,7 +153,6 @@ describe('send alerts', () => {
           responseTime: 0,
           headers: {},
           result: probeRequestResult.success,
-          isProbeResponsive: true,
         },
       },
       notifications: [
@@ -192,7 +188,6 @@ describe('send alerts', () => {
           responseTime: 0,
           headers: {},
           result: probeRequestResult.success,
-          isProbeResponsive: true,
         },
       },
       notifications: [
@@ -233,7 +228,6 @@ describe('send alerts', () => {
           responseTime: 0,
           headers: {},
           result: probeRequestResult.success,
-          isProbeResponsive: true,
         },
       },
       notifications: [
@@ -270,7 +264,6 @@ describe('send alerts', () => {
           responseTime: 0,
           headers: {},
           result: probeRequestResult.success,
-          isProbeResponsive: true,
         },
       },
       notifications: [
@@ -324,7 +317,6 @@ describe('send alerts', () => {
           responseTime: 0,
           headers: {},
           result: probeRequestResult.success,
-          isProbeResponsive: true,
         },
       },
       notifications: [
@@ -361,7 +353,6 @@ describe('send alerts', () => {
           responseTime: 0,
           headers: {},
           result: probeRequestResult.success,
-          isProbeResponsive: true,
         },
       },
       notifications: [
@@ -395,7 +386,6 @@ describe('send alerts', () => {
           responseTime: 0,
           headers: {},
           result: probeRequestResult.success,
-          isProbeResponsive: true,
         },
       },
       notifications: [
@@ -429,7 +419,6 @@ describe('send alerts', () => {
           responseTime: 0,
           headers: {},
           result: probeRequestResult.success,
-          isProbeResponsive: true,
         },
       },
       notifications: [
@@ -463,7 +452,6 @@ describe('send alerts', () => {
           responseTime: 0,
           headers: {},
           result: probeRequestResult.success,
-          isProbeResponsive: true,
         },
       },
       notifications: [