Repository: rook/rook
Pull request #9581 (2022-01-17 08:28:19)

Update ceph csi release 3.5 image and sidecars 
Ceph CSI image has been udpated to v3.5.0
    
Below sidecars are updated to the latest releases with this commit.
    
    csi-provisioner      : 3.1.0
    csi-attacher         : 3.4.0
    node-driver-registrar: 2.4.0
    
    Signed-off-by: Humble Chirammal <hchiramm@redhat.com>

- [ ] **Commit Message Formatting**: Commit titles and messages follow guidelines in the [developer guide](https://rook.io/docs/rook/latest/development-flow.html#commit-structure).
- [ ] **Skip Tests for Docs**: Add the flag for skipping the build if this is only a documentation change. See [here](https://github.com/rook/rook/blob/master/INSTALL.md#skip-ci) for the flag.
- [ ] **Skip Unrelated Tests**: Add a flag to run tests for a specific storage provider. See [test options](https://github.com/rook/rook/blob/master/INSTALL.md#test-storage-provider).
- [ ] Reviewed the developer guide on [Submitting a Pull Request](https://rook.io/docs/rook/latest/development-flow.html#submitting-a-pull-request)
- [ ] Documentation has been updated, if necessary.
- [ ] Unit tests have been added, if necessary.
- [ ] Integration tests have been added, if necessary.
- [ ] Pending release notes updated with breaking and/or notable changes, if necessary.
- [ ] Upgrade from previous release is tested and upgrade user guide is updated, if necessary.
- [ ] Code generation (`make codegen`) has been run to update object specifications, if necessary.


Rakshith-R: @humblec changes are required here too https://github.com/rook/rook/blob/master/pkg/operator/ceph/csi/version.go#L32
humblec: > @humblec changes are required here too https://github.com/rook/rook/blob/master/pkg/operator/ceph/csi/version.go#L32

@Rakshith-R added this too. ptal.. thanks!
humblec: @Madhu-1 iic, in previous discussions here in this repor, it was told that, *not* to deprecate the release in minor version of rook ? thats why 3.3.0 was kept still as minimum version, if we are fine to deprecate it for rook users too, I can adjust the PR... @travisn @leseb 
Madhu-1: > @Madhu-1 iic, in previous discussions here in this repo, it was told that, _not_ to deprecate the release in minor version of rook ? thats why 3.3.0 was kept still as minimum version, if we are fine to deprecate it for rook users too, I can adjust the PR... @travisn @leseb

If the release is already deprecated in cephcsi what is the point of supporting an unsupported cephcsi version in Rook?
Madhu-1: > > > @Madhu-1 iic, in previous discussions here in this repo, it was told that, _not_ to deprecate the release in minor version of rook ? thats why 3.3.0 was kept still as minimum version, if we are fine to deprecate it for rook users too, I can adjust the PR... @travisn @leseb
> > 
> > 
> > If the release is already deprecated in cephcsi what is the point of supporting an unsupported cephcsi version in Rook?
> 
> both repos deprecation policy is/can be different?

Here is what looks correct to me. If it's supported in cephcsi and deprecated in Rook then it's fine. but here it's different. If someone uses the older version and hits any bug, we can not do any bug fixes in cephcsi as it's already deprecated.
humblec: > > > > @Madhu-1 iic, in previous discussions here in this repo, it was told that, _not_ to deprecate the release in minor version of rook ? thats why 3.3.0 was kept still as minimum version, if we are fine to deprecate it for rook users too, I can adjust the PR... @travisn @leseb
> > > 
> > > 
> > > If the release is already deprecated in cephcsi what is the point of supporting an unsupported cephcsi version in Rook?
> > 
> > 
> > both repos deprecation policy is/can be different?
> 
> Here is what looks correct to me. If it's supported in cephcsi and deprecated in Rook then it's fine. but here it's different. If someone uses the older version and hits any bug, we can not do any bug fixes in cephcsi as it's already deprecated.

I am fine either way, will wait for @travisn and @leseb to confirm and can refresh the PR accordingly.. 
travisn: > > > > > @Madhu-1 iic, in previous discussions here in this repo, it was told that, _not_ to deprecate the release in minor version of rook ? thats why 3.3.0 was kept still as minimum version, if we are fine to deprecate it for rook users too, I can adjust the PR... @travisn @leseb
> > > > 
> > > > 
> > > > If the release is already deprecated in cephcsi what is the point of supporting an unsupported cephcsi version in Rook?
> > > 
> > > 
> > > both repos deprecation policy is/can be different?
> > 
> > 
> > Here is what looks correct to me. If it's supported in cephcsi and deprecated in Rook then it's fine. but here it's different. If someone uses the older version and hits any bug, we can not do any bug fixes in cephcsi as it's already deprecated.
> 
> I am fine either way, will wait for @travisn and @leseb to confirm and can refresh the PR accordingly..

If 3.3 is deprecated in CSI, it sounds fine to change the minimum version in rook to 3.4. If they still really want to run an older version, they can still override it with the use unsupported flag. But almost everyone upstream (I hope) uses the default csi version that comes with Rook, so I don't anticipate it will affect many users either.
humblec: 
> > 
> > I am fine either way, will wait for @travisn and @leseb to confirm and can refresh the PR accordingly..
> 
> If 3.3 is deprecated in CSI, it sounds fine to change the minimum version in rook to 3.4. If they still really want to run an older version, they can still override it with the use unsupported flag. But almost everyone upstream (I hope) uses the default csi version that comes with Rook, so I don't anticipate it will affect many users either.

Done.. :+1: , ptal @travisn 

Patch:
diff --git a/.github/workflows/daily-nightly-jobs.yml b/.github/workflows/daily-nightly-jobs.yml
index 7c7df6e28..7c7abb156 100644
--- a/.github/workflows/daily-nightly-jobs.yml
+++ b/.github/workflows/daily-nightly-jobs.yml
@@ -326,7 +326,6 @@ jobs:
 
     - name: run Encryption KMS IBM Key Protect
       uses: ./.github/workflows/encryption-pvc-kms-ibm-kp
-      if: "env.IBM_KP_INSTANCE_ID != '' && env.IBM_KP_SERVICE_API_KEY != ''"
       with:
         github-token: ${{ secrets.GITHUB_TOKEN }}
         ibm-instance-id: ${{ secrets.IBM_KP_INSTANCE_ID }}
diff --git a/Documentation/ceph-upgrade.md b/Documentation/ceph-upgrade.md
index cb903ea20..9683e0a9d 100644
--- a/Documentation/ceph-upgrade.md
+++ b/Documentation/ceph-upgrade.md
@@ -545,10 +545,10 @@ kubectl -n $ROOK_OPERATOR_NAMESPACE edit configmap rook-ceph-operator-config
 The default upstream images are included below, which you can change to your desired images.
 
 ```yaml
-ROOK_CSI_CEPH_IMAGE: "quay.io/cephcsi/cephcsi:v3.4.0"
-ROOK_CSI_REGISTRAR_IMAGE: "k8s.gcr.io/sig-storage/csi-node-driver-registrar:v2.3.0"
-ROOK_CSI_PROVISIONER_IMAGE: "k8s.gcr.io/sig-storage/csi-provisioner:v3.0.0"
-ROOK_CSI_ATTACHER_IMAGE: "k8s.gcr.io/sig-storage/csi-attacher:v3.3.0"
+ROOK_CSI_CEPH_IMAGE: "quay.io/cephcsi/cephcsi:v3.5.0"
+ROOK_CSI_REGISTRAR_IMAGE: "k8s.gcr.io/sig-storage/csi-node-driver-registrar:v2.4.0"
+ROOK_CSI_PROVISIONER_IMAGE: "k8s.gcr.io/sig-storage/csi-provisioner:v3.1.0"
+ROOK_CSI_ATTACHER_IMAGE: "k8s.gcr.io/sig-storage/csi-attacher:v3.4.0"
 ROOK_CSI_RESIZER_IMAGE: "k8s.gcr.io/sig-storage/csi-resizer:v1.3.0"
 ROOK_CSI_SNAPSHOTTER_IMAGE: "k8s.gcr.io/sig-storage/csi-snapshotter:v4.2.0"
 CSI_VOLUME_REPLICATION_IMAGE: "quay.io/csiaddons/volumereplication-operator:v0.1.0"
@@ -570,11 +570,11 @@ kubectl --namespace rook-ceph get pod -o jsonpath='{range .items[*]}{range .spec
 ```
 
 ```
-k8s.gcr.io/sig-storage/csi-attacher:v3.3.0
-k8s.gcr.io/sig-storage/csi-node-driver-registrar:v2.3.0
-k8s.gcr.io/sig-storage/csi-provisioner:v3.0.0
+k8s.gcr.io/sig-storage/csi-attacher:v3.4.0
+k8s.gcr.io/sig-storage/csi-node-driver-registrar:v2.4.0
+k8s.gcr.io/sig-storage/csi-provisioner:v3.1.0
 k8s.gcr.io/sig-storage/csi-resizer:v1.3.0
 k8s.gcr.io/sig-storage/csi-snapshotter:v4.2.0
-quay.io/cephcsi/cephcsi:v3.4.0
+quay.io/cephcsi/cephcsi:v3.5.0
 quay.io/csiaddons/volumereplication-operator:v0.1.0
 ```
diff --git a/Documentation/helm-operator.md b/Documentation/helm-operator.md
index 644e327de..76d51a4ce 100644
--- a/Documentation/helm-operator.md
+++ b/Documentation/helm-operator.md
@@ -133,14 +133,14 @@ The following tables lists the configurable parameters of the rook-operator char
 | `csi.rbdLivenessMetricsPort`        | Ceph CSI RBD driver metrics port.                                                                                           | `8080`                                                    |
 | `csi.forceCephFSKernelClient`       | Enable Ceph Kernel clients on kernel < 4.17 which support quotas for Cephfs.                                                | `true`                                                    |
 | `csi.kubeletDirPath`                | Kubelet root directory path (if the Kubelet uses a different path for the `--root-dir` flag)                                | `/var/lib/kubelet`                                        |
-| `csi.cephcsi.image`                 | Ceph CSI image.                                                                                                             | `quay.io/cephcsi/cephcsi:v3.4.0`                          |
+| `csi.cephcsi.image`                 | Ceph CSI image.                                                                                                             | `quay.io/cephcsi/cephcsi:v3.5.0`                          |
 | `csi.rbdPluginUpdateStrategy`       | CSI Rbd plugin daemonset update strategy, supported values are OnDelete and RollingUpdate.                                  | `OnDelete`                                                |
 | `csi.cephFSPluginUpdateStrategy`    | CSI CephFS plugin daemonset update strategy, supported values are OnDelete and RollingUpdate.                               | `OnDelete`                                                |
-| `csi.registrar.image`               | Kubernetes CSI registrar image.                                                                                             | `k8s.gcr.io/sig-storage/csi-node-driver-registrar:v2.3.0` |
+| `csi.registrar.image`               | Kubernetes CSI registrar image.                                                                                             | `k8s.gcr.io/sig-storage/csi-node-driver-registrar:v2.4.0` |
 | `csi.resizer.image`                 | Kubernetes CSI resizer image.                                                                                               | `k8s.gcr.io/sig-storage/csi-resizer:v1.3.0`               |
-| `csi.provisioner.image`             | Kubernetes CSI provisioner image.                                                                                           | `k8s.gcr.io/sig-storage/csi-provisioner:v3.0.0`           |
+| `csi.provisioner.image`             | Kubernetes CSI provisioner image.                                                                                           | `k8s.gcr.io/sig-storage/csi-provisioner:v3.1.0`           |
 | `csi.snapshotter.image`             | Kubernetes CSI snapshotter image.                                                                                           | `k8s.gcr.io/sig-storage/csi-snapshotter:v4.2.0`           |
-| `csi.attacher.image`                | Kubernetes CSI Attacher image.                                                                                              | `k8s.gcr.io/sig-storage/csi-attacher:v3.3.0`              |
+| `csi.attacher.image`                | Kubernetes CSI Attacher image.                                                                                              | `k8s.gcr.io/sig-storage/csi-attacher:v3.4.0`              |
 | `csi.cephfsPodLabels`               | Labels to add to the CSI CephFS Pods.                                                                                       | <none>                                                    |
 | `csi.rbdPodLabels`                  | Labels to add to the CSI RBD Pods.                                                                                          | <none>                                                    |
 | `csi.volumeReplication.enabled`     | Enable Volume Replication.                                                                                                  | `false`                                                   |
diff --git a/deploy/charts/rook-ceph/values.yaml b/deploy/charts/rook-ceph/values.yaml
index 80d42d088..9a27b4a3d 100644
--- a/deploy/charts/rook-ceph/values.yaml
+++ b/deploy/charts/rook-ceph/values.yaml
@@ -275,15 +275,15 @@ csi:
   #rbdLivenessMetricsPort: 9080
   #kubeletDirPath: /var/lib/kubelet
   #cephcsi:
-    #image: quay.io/cephcsi/cephcsi:v3.4.0
+    #image: quay.io/cephcsi/cephcsi:v3.5.0
   #registrar:
-    #image: k8s.gcr.io/sig-storage/csi-node-driver-registrar:v2.3.0
+    #image: k8s.gcr.io/sig-storage/csi-node-driver-registrar:v2.4.0
   #provisioner:
-    #image: k8s.gcr.io/sig-storage/csi-provisioner:v3.0.0
+    #image: k8s.gcr.io/sig-storage/csi-provisioner:v3.1.0
   #snapshotter:
     #image: k8s.gcr.io/sig-storage/csi-snapshotter:v4.2.0
   #attacher:
-    #image: k8s.gcr.io/sig-storage/csi-attacher:v3.3.0
+    #image: k8s.gcr.io/sig-storage/csi-attacher:v3.4.0
   #resizer:
     #image: k8s.gcr.io/sig-storage/csi-resizer:v1.3.0
   # Labels to add to the CSI CephFS Deployments and DaemonSets Pods.
diff --git a/deploy/examples/images.txt b/deploy/examples/images.txt
index f084ab20f..e245ea3e5 100644
--- a/deploy/examples/images.txt
+++ b/deploy/examples/images.txt
@@ -1,9 +1,9 @@
- k8s.gcr.io/sig-storage/csi-attacher:v3.3.0
- k8s.gcr.io/sig-storage/csi-node-driver-registrar:v2.3.0
- k8s.gcr.io/sig-storage/csi-provisioner:v3.0.0
+ k8s.gcr.io/sig-storage/csi-attacher:v3.4.0
+ k8s.gcr.io/sig-storage/csi-node-driver-registrar:v2.4.0
+ k8s.gcr.io/sig-storage/csi-provisioner:v3.1.0
  k8s.gcr.io/sig-storage/csi-resizer:v1.3.0
  k8s.gcr.io/sig-storage/csi-snapshotter:v4.2.0
  quay.io/ceph/ceph:v16.2.7
- quay.io/cephcsi/cephcsi:v3.4.0
+ quay.io/cephcsi/cephcsi:v3.5.0
  quay.io/csiaddons/volumereplication-operator:v0.1.0
  rook/ceph:master
diff --git a/deploy/examples/operator-openshift.yaml b/deploy/examples/operator-openshift.yaml
index cf2939f4b..f6b2c6057 100644
--- a/deploy/examples/operator-openshift.yaml
+++ b/deploy/examples/operator-openshift.yaml
@@ -161,12 +161,12 @@ data:
   # The default version of CSI supported by Rook will be started. To change the version
   # of the CSI driver to something other than what is officially supported, change
   # these images to the desired release of the CSI driver.
-  # ROOK_CSI_CEPH_IMAGE: "quay.io/cephcsi/cephcsi:v3.4.0"
-  # ROOK_CSI_REGISTRAR_IMAGE: "k8s.gcr.io/sig-storage/csi-node-driver-registrar:v2.3.0"
+  # ROOK_CSI_CEPH_IMAGE: "quay.io/cephcsi/cephcsi:v3.5.0"
+  # ROOK_CSI_REGISTRAR_IMAGE: "k8s.gcr.io/sig-storage/csi-node-driver-registrar:v2.4.0"
   # ROOK_CSI_RESIZER_IMAGE: "k8s.gcr.io/sig-storage/csi-resizer:v1.3.0"
-  # ROOK_CSI_PROVISIONER_IMAGE: "k8s.gcr.io/sig-storage/csi-provisioner:v3.0.0"
+  # ROOK_CSI_PROVISIONER_IMAGE: "k8s.gcr.io/sig-storage/csi-provisioner:v3.1.0"
   # ROOK_CSI_SNAPSHOTTER_IMAGE: "k8s.gcr.io/sig-storage/csi-snapshotter:v4.2.0"
-  # ROOK_CSI_ATTACHER_IMAGE: "k8s.gcr.io/sig-storage/csi-attacher:v3.3.0"
+  # ROOK_CSI_ATTACHER_IMAGE: "k8s.gcr.io/sig-storage/csi-attacher:v3.4.0"
 
   # (Optional) set user created priorityclassName for csi plugin pods.
   # CSI_PLUGIN_PRIORITY_CLASSNAME: "system-node-critical"
diff --git a/deploy/examples/operator.yaml b/deploy/examples/operator.yaml
index 0c76546dc..01548e6f1 100644
--- a/deploy/examples/operator.yaml
+++ b/deploy/examples/operator.yaml
@@ -79,12 +79,12 @@ data:
   # The default version of CSI supported by Rook will be started. To change the version
   # of the CSI driver to something other than what is officially supported, change
   # these images to the desired release of the CSI driver.
-  # ROOK_CSI_CEPH_IMAGE: "quay.io/cephcsi/cephcsi:v3.4.0"
-  # ROOK_CSI_REGISTRAR_IMAGE: "k8s.gcr.io/sig-storage/csi-node-driver-registrar:v2.3.0"
+  # ROOK_CSI_CEPH_IMAGE: "quay.io/cephcsi/cephcsi:v3.5.0"
+  # ROOK_CSI_REGISTRAR_IMAGE: "k8s.gcr.io/sig-storage/csi-node-driver-registrar:v2.4.0"
   # ROOK_CSI_RESIZER_IMAGE: "k8s.gcr.io/sig-storage/csi-resizer:v1.3.0"
-  # ROOK_CSI_PROVISIONER_IMAGE: "k8s.gcr.io/sig-storage/csi-provisioner:v3.0.0"
+  # ROOK_CSI_PROVISIONER_IMAGE: "k8s.gcr.io/sig-storage/csi-provisioner:v3.1.0"
   # ROOK_CSI_SNAPSHOTTER_IMAGE: "k8s.gcr.io/sig-storage/csi-snapshotter:v4.2.0"
-  # ROOK_CSI_ATTACHER_IMAGE: "k8s.gcr.io/sig-storage/csi-attacher:v3.3.0"
+  # ROOK_CSI_ATTACHER_IMAGE: "k8s.gcr.io/sig-storage/csi-attacher:v3.4.0"
 
   # (Optional) set user created priorityclassName for csi plugin pods.
   # CSI_PLUGIN_PRIORITY_CLASSNAME: "system-node-critical"
diff --git a/pkg/operator/ceph/cluster/osd/spec.go b/pkg/operator/ceph/cluster/osd/spec.go
index 2f57fa52a..63cb3a83a 100644
--- a/pkg/operator/ceph/cluster/osd/spec.go
+++ b/pkg/operator/ceph/cluster/osd/spec.go
@@ -233,7 +233,7 @@ var defaultTuneFastSettings = []string{
 	"--osd-delete-sleep=0",                        // Time in seconds to sleep before next removal transaction for SSDs
 	"--bluestore-min-alloc-size=4096",             // Default min_alloc_size value for SSDs
 	"--bluestore-prefer-deferred-size=0",          // Default value of bluestore_prefer_deferred_size for SSDs
-	"--bluestore-compression-min-blob-size=8192",  // Default value of bluestore_compression_min_blob_size for SSDs
+	"--bluestore-compression-min-blob-size=8912",  // Default value of bluestore_compression_min_blob_size for SSDs
 	"--bluestore-compression-max-blob-size=65536", // Default value of bluestore_compression_max_blob_size for SSDs
 	"--bluestore-max-blob-size=65536",             // Default value of bluestore_max_blob_size for SSDs
 	"--bluestore-cache-size=3221225472",           // Default value of bluestore_cache_size for SSDs
diff --git a/pkg/operator/ceph/csi/spec.go b/pkg/operator/ceph/csi/spec.go
index 30a20b6e3..47d62f7e9 100644
--- a/pkg/operator/ceph/csi/spec.go
+++ b/pkg/operator/ceph/csi/spec.go
@@ -98,10 +98,10 @@ var (
 // manually challenging.
 var (
 	// image names
-	DefaultCSIPluginImage         = "quay.io/cephcsi/cephcsi:v3.4.0"
-	DefaultRegistrarImage         = "k8s.gcr.io/sig-storage/csi-node-driver-registrar:v2.3.0"
-	DefaultProvisionerImage       = "k8s.gcr.io/sig-storage/csi-provisioner:v3.0.0"
-	DefaultAttacherImage          = "k8s.gcr.io/sig-storage/csi-attacher:v3.3.0"
+	DefaultCSIPluginImage         = "quay.io/cephcsi/cephcsi:v3.5.0"
+	DefaultRegistrarImage         = "k8s.gcr.io/sig-storage/csi-node-driver-registrar:v2.4.0"
+	DefaultProvisionerImage       = "k8s.gcr.io/sig-storage/csi-provisioner:v3.1.0"
+	DefaultAttacherImage          = "k8s.gcr.io/sig-storage/csi-attacher:v3.4.0"
 	DefaultSnapshotterImage       = "k8s.gcr.io/sig-storage/csi-snapshotter:v4.2.0"
 	DefaultResizerImage           = "k8s.gcr.io/sig-storage/csi-resizer:v1.3.0"
 	DefaultVolumeReplicationImage = "quay.io/csiaddons/volumereplication-operator:v0.1.0"
diff --git a/pkg/operator/ceph/csi/version.go b/pkg/operator/ceph/csi/version.go
index bcc8166b3..c8e059610 100644
--- a/pkg/operator/ceph/csi/version.go
+++ b/pkg/operator/ceph/csi/version.go
@@ -25,15 +25,15 @@ import (
 )
 
 var (
-	//minimum supported version is 3.3.0
-	minimum = CephCSIVersion{3, 3, 0}
+	//minimum supported version is 3.4.0
+	minimum = CephCSIVersion{3, 4, 0}
 	//supportedCSIVersions are versions that rook supports
-	releasev330          = CephCSIVersion{3, 3, 0}
 	releasev340          = CephCSIVersion{3, 4, 0}
+	releasev350          = CephCSIVersion{3, 5, 0}
 	supportedCSIVersions = []CephCSIVersion{
 		minimum,
-		releasev330,
 		releasev340,
+		releasev350,
 	}
 	// for parsing the output of `cephcsi`
 	versionCSIPattern = regexp.MustCompile(`v(\d+)\.(\d+)\.(\d+)`)


Test patch:
diff --git a/.github/workflows/canary-integration-test.yml b/.github/workflows/canary-integration-test.yml
index 5ff32fab4..f331e0dc6 100644
--- a/.github/workflows/canary-integration-test.yml
+++ b/.github/workflows/canary-integration-test.yml
@@ -833,7 +833,6 @@ jobs:
 
     - name: run Encryption KMS IBM Key Protect
       uses: ./.github/workflows/encryption-pvc-kms-ibm-kp
-      if: "env.IBM_KP_INSTANCE_ID != '' && env.IBM_KP_SERVICE_API_KEY != ''"
       with:
         ibm-instance-id: ${{ secrets.IBM_INSTANCE_ID }}
         ibm-service-api-key: ${{ secrets.IBM_SERVICE_API_KEY }}
diff --git a/pkg/operator/ceph/csi/version_test.go b/pkg/operator/ceph/csi/version_test.go
index c69ae0c4c..2cca86b9f 100644
--- a/pkg/operator/ceph/csi/version_test.go
+++ b/pkg/operator/ceph/csi/version_test.go
@@ -23,9 +23,9 @@ import (
 )
 
 var (
-	testMinVersion         = CephCSIVersion{3, 3, 0}
-	testReleaseV330        = CephCSIVersion{3, 3, 0}
+	testMinVersion         = CephCSIVersion{3, 4, 0}
 	testReleaseV340        = CephCSIVersion{3, 4, 0}
+	testReleaseV350        = CephCSIVersion{3, 5, 0}
 	testVersionUnsupported = CephCSIVersion{4, 0, 0}
 )
 
@@ -40,12 +40,12 @@ func TestIsAtLeast(t *testing.T) {
 	assert.Equal(t, true, ret)
 
 	// Test version which is equal
-	ret = testReleaseV330.isAtLeast(&testReleaseV330)
+	ret = testReleaseV340.isAtLeast(&testReleaseV340)
 	assert.Equal(t, true, ret)
 
-	// Test for 3.4.0
+	// Test for 3.5.0
 	// Test version which is lesser
-	ret = testReleaseV340.isAtLeast(&testReleaseV330)
+	ret = testReleaseV350.isAtLeast(&testReleaseV340)
 	assert.Equal(t, true, ret)
 
 }
@@ -58,10 +58,10 @@ func TestSupported(t *testing.T) {
 	ret = testVersionUnsupported.Supported()
 	assert.Equal(t, false, ret)
 
-	ret = testReleaseV330.Supported()
+	ret = testReleaseV340.Supported()
 	assert.Equal(t, true, ret)
 
-	ret = testReleaseV340.Supported()
+	ret = testReleaseV350.Supported()
 	assert.Equal(t, true, ret)
 }