Repository: salesforce/tough-cookie
Pull request #414 (2024-05-16 17:27:11)

Preparing for release 5.0.0-rc.2
Includes changes:
https://github.com/salesforce/tough-cookie/compare/4afc5d..72ed3f0

colincasey: @wjhsf can you reapprove? since the version number is part of our public api i used this to validate that the API & Doc validation steps work as expected. this found a bug in the docs check which i've included in this PR too (here's the[ failure output](https://github.com/salesforce/tough-cookie/actions/runs/9117230084?pr=414) after the fix).

Patch:
diff --git a/.github/workflows/integration.yaml b/.github/workflows/integration.yaml
index 7eb3876..d253a0c 100644
--- a/.github/workflows/integration.yaml
+++ b/.github/workflows/integration.yaml
@@ -69,14 +69,14 @@ jobs:
       - name: Ensure API and doc changes have been committed
         run: |
           git add --renormalize .
-          if (( "$(git diff --ignore-space-at-eol --ignore-cr-at-eol | wc -l)" != 0 )); then
+          if (( "$(git diff HEAD --ignore-space-at-eol --ignore-cr-at-eol | wc -l)" != 0 )); then
             cat << EOF >> $GITHUB_STEP_SUMMARY
           ### Detected uncommitted changes
 
           \`\`\`shell
-          $(git diff)
+          $(git diff HEAD)
           \`\`\`
           EOF
-            git diff
+            git diff HEAD
             exit 1
           fi
diff --git a/api/docs/tough-cookie.version.md b/api/docs/tough-cookie.version.md
index bac8d96..dffa731 100644
--- a/api/docs/tough-cookie.version.md
+++ b/api/docs/tough-cookie.version.md
@@ -9,5 +9,5 @@ The version of `tough-cookie`
 **Signature:**
 
 ```typescript
-version = "5.0.0-rc.1"
+version = "5.0.0-rc.2"
 ```
diff --git a/api/tough-cookie.api.md b/api/tough-cookie.api.md
index fccfc15..4d2dcd6 100644
--- a/api/tough-cookie.api.md
+++ b/api/tough-cookie.api.md
@@ -299,7 +299,7 @@ export class Store {
 }
 
 // @public
-export const version = "5.0.0-rc.1";
+export const version = "5.0.0-rc.2";
 
 // (No @packageDocumentation comment for this package)
 
diff --git a/lib/version.ts b/lib/version.ts
index 7f37283..20cc2e8 100644
--- a/lib/version.ts
+++ b/lib/version.ts
@@ -2,4 +2,4 @@
  * The version of `tough-cookie`
  * @public
  */
-export const version = '5.0.0-rc.1'
+export const version = '5.0.0-rc.2'
diff --git a/package-lock.json b/package-lock.json
index bdddb0b..bc10122 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -1,12 +1,12 @@
 {
   "name": "tough-cookie",
-  "version": "5.0.0-rc.1",
+  "version": "5.0.0-rc.2",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "tough-cookie",
-      "version": "5.0.0-rc.1",
+      "version": "5.0.0-rc.2",
       "license": "BSD-3-Clause",
       "dependencies": {
         "punycode": "^2.3.1",
diff --git a/package.json b/package.json
index ca66259..5217194 100644
--- a/package.json
+++ b/package.json
@@ -67,7 +67,7 @@
     "RFC6265",
     "RFC2965"
   ],
-  "version": "5.0.0-rc.1",
+  "version": "5.0.0-rc.2",
   "homepage": "https://github.com/salesforce/tough-cookie",
   "repository": {
     "type": "git",


Test patch:
diff --git a/lib/__tests__/cookieJar.spec.ts b/lib/__tests__/cookieJar.spec.ts
index 8ca6fae..cc1d52e 100644
--- a/lib/__tests__/cookieJar.spec.ts
+++ b/lib/__tests__/cookieJar.spec.ts
@@ -977,7 +977,7 @@ describe('CookieJar', () => {
           prefixSecurity: 'silent',
           rejectPublicSuffixes: true,
           storeType: 'MemoryCookieStore',
-          version: 'tough-cookie@5.0.0-rc.1',
+          version: 'tough-cookie@5.0.0-rc.2',
         }
         expect(data).toEqual(expected)
       },
diff --git a/lib/__tests__/jarSerialization.spec.ts b/lib/__tests__/jarSerialization.spec.ts
index b22ce29..b0dc07b 100644
--- a/lib/__tests__/jarSerialization.spec.ts
+++ b/lib/__tests__/jarSerialization.spec.ts
@@ -37,7 +37,7 @@ import { version } from '../version'
 
 describe('cookieJar serialization', () => {
   it('should use the expected version', () => {
-    expect(version).toBe('5.0.0-rc.1')
+    expect(version).toBe('5.0.0-rc.2')
   })
 
   it('should provide the list of serialized properties available for a Cookie with `Cookie.serializableProperties`', () => {