Repository: rollbar/rollbar-java
Pull request #16 (2016-05-10 16:35:33)

remove version number property, maven cannot inject it during build
maven cannot inject the property into the version number and so the project cannot build, I've hardcoded the number, but it can be updated with the maven versions plugin.


Patch:
diff --git a/.gitignore b/.gitignore
index de792ca..1524529 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1,3 +1,4 @@
 *.iml
 .idea
-**/target
\ No newline at end of file
+**/target
+**/.flattened-pom.xml
\ No newline at end of file
diff --git a/README.md b/README.md
index ed85789..26967bd 100644
--- a/README.md
+++ b/README.md
@@ -36,7 +36,7 @@ dependency to your pom file:
 <dependency>
   <groupId>com.rollbar</groupId>
    <artifactId>rollbar</artifactId>
-   <version>0.5.0</version>
+   <version>0.5.2</version>
 </dependency>
 </dependencies>
 ```
@@ -44,7 +44,7 @@ dependency to your pom file:
 ### Gradle
 
 ```groovy
-compile('com.rollbar:rollbar:0.5.0')
+compile('com.rollbar:rollbar:0.5.2')
 ```
 
 ## Usage
diff --git a/parent-pom.xml b/parent-pom.xml
deleted file mode 100644
index a542154..0000000
--- a/parent-pom.xml
+++ /dev/null
@@ -1,137 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<project xmlns="http://maven.apache.org/POM/4.0.0"
-         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
-    <modelVersion>4.0.0</modelVersion>
-
-    <groupId>com.rollbar</groupId>
-    <artifactId>rollbar-parent</artifactId>
-    <version>${currentVersion}</version>
-
-    <packaging>pom</packaging>
-
-    <name>Parent POM for Rollbar Modules</name>
-    <description>For Rollbar modules to inherit from</description>
-
-    <properties>
-        <currentVersion>0.5.1</currentVersion>
-    </properties>
-
-    <build>
-        <plugins>
-            <plugin>
-                <groupId>org.apache.maven.plugins</groupId>
-                <artifactId>maven-jar-plugin</artifactId>
-                <configuration>
-                    <archive>
-                        <manifest>
-                            <addDefaultImplementationEntries>true</addDefaultImplementationEntries>
-                            <addDefaultSpecificationEntries>true</addDefaultSpecificationEntries>
-                        </manifest>
-                    </archive>
-                </configuration>
-            </plugin>
-            <plugin>
-                <groupId>org.apache.maven.plugins</groupId>
-                <artifactId>maven-source-plugin</artifactId>
-                <version>2.2.1</version>
-                <executions>
-                    <execution>
-                        <id>attach-sources</id>
-                        <goals>
-                            <goal>jar-no-fork</goal>
-                        </goals>
-                    </execution>
-                </executions>
-            </plugin>
-            <plugin>
-                <groupId>org.apache.maven.plugins</groupId>
-                <artifactId>maven-javadoc-plugin</artifactId>
-                <version>2.9.1</version>
-                <executions>
-                    <execution>
-                        <id>attach-javadocs</id>
-                        <goals>
-                            <goal>jar</goal>
-                        </goals>
-                    </execution>
-                </executions>
-            </plugin>
-            <plugin>
-                <groupId>org.apache.maven.plugins</groupId>
-                <artifactId>maven-gpg-plugin</artifactId>
-                <version>1.5</version>
-                <executions>
-                    <execution>
-                        <id>sign-artifacts</id>
-                        <phase>deploy</phase>
-                        <goals>
-                            <goal>sign</goal>
-                        </goals>
-                    </execution>
-                </executions>
-            </plugin>
-            <plugin>
-                <groupId>org.sonatype.plugins</groupId>
-                <artifactId>nexus-staging-maven-plugin</artifactId>
-                <version>1.6.3</version>
-                <extensions>true</extensions>
-                <configuration>
-                    <serverId>ossrh</serverId>
-                    <nexusUrl>https://oss.sonatype.org/</nexusUrl>
-                    <autoReleaseAfterClose>true</autoReleaseAfterClose>
-                </configuration>
-            </plugin>
-        </plugins>
-    </build>
-
-    <dependencies>
-        <dependency>
-            <groupId>junit</groupId>
-            <artifactId>junit</artifactId>
-            <version>4.10</version>
-            <scope>test</scope>
-        </dependency>
-        <dependency>
-            <groupId>com.google.code.gson</groupId>
-            <artifactId>gson</artifactId>
-            <version>2.3.1</version>
-            <scope>test</scope>
-        </dependency>
-        <dependency>
-            <groupId>org.hamcrest</groupId>
-            <artifactId>hamcrest-core</artifactId>
-            <scope>test</scope>
-            <version>1.1</version>
-        </dependency>
-    </dependencies>
-
-    <licenses>
-        <license>
-            <name>MIT License</name>
-            <url>http://www.opensource.org/licenses/mit-license.php</url>
-        </license>
-    </licenses>
-
-    <developers>
-        <developer>
-            <name>Christopher Pfohl</name>
-            <email>chris@rollbar.com</email>
-            <organization>Rollbar</organization>
-            <organizationUrl>http://www.rollbar.com</organizationUrl>
-        </developer>
-    </developers>
-
-    <scm>
-        <connection>scm:git:git@github.com:rollbar/rollbar-java.git</connection>
-        <developerConnection>scm:git:git@github.com:rollbar/rollbar-java.git</developerConnection>
-        <url>github.com/rollbar/rollbar-java</url>
-    </scm>
-
-    <distributionManagement>
-        <snapshotRepository>
-            <id>ossrh</id>
-            <url>https://oss.sonatype.org/content/repositories/snapshots</url>
-        </snapshotRepository>
-    </distributionManagement>
-</project>
diff --git a/pom.xml b/pom.xml
index ea4e2cc..abafca8 100644
--- a/pom.xml
+++ b/pom.xml
@@ -2,11 +2,15 @@
 <project xmlns="http://maven.apache.org/POM/4.0.0"
 	 xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
 	 xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
+
   <groupId>com.rollbar</groupId>
-  <artifactId>java-rollbar</artifactId>
-  <version>n/a</version>
+  <artifactId>rollbar-parent</artifactId>
+  <version>dev</version>
   <packaging>pom</packaging>
   <modelVersion>4.0.0</modelVersion>
+  <properties>
+    <rollbar.version>0.5.2</rollbar.version>
+  </properties>
 
   <name>java-rollbar</name>
   <description>For connecting your applications built on the JVM to Rollbar for Error Reporting</description>
@@ -18,16 +22,141 @@
     <module>rollbar-testing</module>
     <module>rollbar</module>
   </modules>
-  <build>
-    <plugins>
-      <plugin>
-        <groupId>org.apache.maven.plugins</groupId>
-        <artifactId>maven-deploy-plugin</artifactId>
-        <version>2.4</version>
-        <configuration>
-          <skip>true</skip>
-        </configuration>
-      </plugin>
-    </plugins>
-  </build>
+
+  <dependencies>
+    <dependency>
+      <groupId>junit</groupId>
+      <artifactId>junit</artifactId>
+      <version>4.10</version>
+      <scope>test</scope>
+    </dependency>
+    <dependency>
+      <groupId>com.google.code.gson</groupId>
+      <artifactId>gson</artifactId>
+      <version>2.3.1</version>
+      <scope>test</scope>
+    </dependency>
+    <dependency>
+      <groupId>org.hamcrest</groupId>
+      <artifactId>hamcrest-core</artifactId>
+      <scope>test</scope>
+      <version>1.1</version>
+    </dependency>
+  </dependencies>
+
+    <build>
+        <plugins>
+            <plugin>
+                <groupId>org.codehaus.mojo</groupId>
+                <artifactId>flatten-maven-plugin</artifactId>
+                <executions>
+                    <execution>
+                        <id>flatten</id>
+                        <phase>process-resources</phase>
+                        <goals>
+                            <goal>flatten</goal>
+                        </goals>
+                    </execution>
+                </executions>
+            </plugin>
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-jar-plugin</artifactId>
+                <configuration>
+                    <archive>
+                        <manifest>
+                            <addDefaultImplementationEntries>true</addDefaultImplementationEntries>
+                            <addDefaultSpecificationEntries>true</addDefaultSpecificationEntries>
+                        </manifest>
+                    </archive>
+                </configuration>
+            </plugin>
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-source-plugin</artifactId>
+                <version>2.2.1</version>
+                <executions>
+                    <execution>
+                        <id>attach-sources</id>
+                        <goals>
+                            <goal>jar-no-fork</goal>
+                        </goals>
+                    </execution>
+                </executions>
+            </plugin>
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-javadoc-plugin</artifactId>
+                <version>2.9.1</version>
+                <executions>
+                    <execution>
+                        <id>attach-javadocs</id>
+                        <goals>
+                            <goal>jar</goal>
+                        </goals>
+                    </execution>
+                </executions>
+            </plugin>
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-gpg-plugin</artifactId>
+                <version>1.5</version>
+                <executions>
+                    <execution>
+                        <id>sign-artifacts</id>
+                        <phase>deploy</phase>
+                        <goals>
+                            <goal>sign</goal>
+                        </goals>
+                    </execution>
+                </executions>
+            </plugin>
+            <plugin>
+                <groupId>org.sonatype.plugins</groupId>
+                <artifactId>nexus-staging-maven-plugin</artifactId>
+                <version>1.6.3</version>
+                <extensions>true</extensions>
+                <configuration>
+                    <serverId>ossrh</serverId>
+                    <nexusUrl>https://oss.sonatype.org/</nexusUrl>
+                    <autoReleaseAfterClose>true</autoReleaseAfterClose>
+                </configuration>
+            </plugin>
+        </plugins>
+    </build>
+
+    <licenses>
+    <license>
+      <name>MIT License</name>
+      <url>http://www.opensource.org/licenses/mit-license.php</url>
+    </license>
+  </licenses>
+
+  <developers>
+    <developer>
+      <name>Christopher Pfohl</name>
+      <email>chris@rollbar.com</email>
+      <organization>Rollbar</organization>
+      <organizationUrl>http://www.rollbar.com</organizationUrl>
+    </developer>
+    <developer>
+      <name>Daniel Steuernol</name>
+      <email>daniel@rollbar.com</email>
+      <organization>Rollbar</organization>
+      <organizationUrl>http://www.rollbar.com</organizationUrl>
+    </developer>
+  </developers>
+
+  <scm>
+    <connection>scm:git:git@github.com:rollbar/rollbar-java.git</connection>
+    <developerConnection>scm:git:git@github.com:rollbar/rollbar-java.git</developerConnection>
+    <url>github.com/rollbar/rollbar-java</url>
+  </scm>
+
+  <distributionManagement>
+    <snapshotRepository>
+      <id>ossrh</id>
+      <url>https://oss.sonatype.org/content/repositories/snapshots</url>
+    </snapshotRepository>
+  </distributionManagement>
 </project>
diff --git a/rollbar-payload/pom.xml b/rollbar-payload/pom.xml
index 356ba3b..4b68c07 100644
--- a/rollbar-payload/pom.xml
+++ b/rollbar-payload/pom.xml
@@ -7,8 +7,7 @@
     <parent>
         <groupId>com.rollbar</groupId>
         <artifactId>rollbar-parent</artifactId>
-        <version>${currentVersion}</version>
-        <relativePath>../parent-pom.xml</relativePath>
+        <version>dev</version>
     </parent>
 
     <name>rollbar-payload</name>
@@ -17,17 +16,18 @@
 
     <groupId>com.rollbar</groupId>
     <artifactId>rollbar-payload</artifactId>
+    <version>${rollbar.version}</version>
 
     <dependencies>
         <dependency>
             <groupId>com.rollbar</groupId>
             <artifactId>rollbar-utilities</artifactId>
-            <version>${currentVersion}</version>
+            <version>${rollbar.version}</version>
         </dependency>
         <dependency>
             <groupId>com.rollbar</groupId>
             <artifactId>rollbar-testing</artifactId>
-            <version>${currentVersion}</version>
+            <version>${rollbar.version}</version>
             <type>test-jar</type>
             <scope>test</scope>
         </dependency>
diff --git a/rollbar-sender/pom.xml b/rollbar-sender/pom.xml
index 2b1c8ee..4364f7f 100644
--- a/rollbar-sender/pom.xml
+++ b/rollbar-sender/pom.xml
@@ -5,24 +5,24 @@
     <parent>
         <artifactId>rollbar-parent</artifactId>
         <groupId>com.rollbar</groupId>
-        <version>${currentVersion}</version>
-        <relativePath>../parent-pom.xml</relativePath>
+        <version>dev</version>
     </parent>
 
     <modelVersion>4.0.0</modelVersion>
 
     <artifactId>rollbar-sender</artifactId>
+    <version>${rollbar.version}</version>
 
     <dependencies>
         <dependency>
             <groupId>com.rollbar</groupId>
             <artifactId>rollbar-payload</artifactId>
-            <version>${currentVersion}</version>
+            <version>${rollbar.version}</version>
         </dependency>
         <dependency>
             <groupId>com.rollbar</groupId>
             <artifactId>rollbar-utilities</artifactId>
-            <version>${currentVersion}</version>
+            <version>${rollbar.version}</version>
         </dependency>
     </dependencies>
 </project>
\ No newline at end of file
diff --git a/rollbar-utilities/pom.xml b/rollbar-utilities/pom.xml
index 9dc45b7..c5995ed 100644
--- a/rollbar-utilities/pom.xml
+++ b/rollbar-utilities/pom.xml
@@ -7,9 +7,9 @@
     <parent>
         <groupId>com.rollbar</groupId>
         <artifactId>rollbar-parent</artifactId>
-        <version>${currentVersion}</version>
-        <relativePath>../parent-pom.xml</relativePath>
+        <version>dev</version>
     </parent>
 
     <artifactId>rollbar-utilities</artifactId>
+    <version>${rollbar.version}</version>
 </project>
\ No newline at end of file
diff --git a/rollbar/pom.xml b/rollbar/pom.xml
index 9d57162..7737189 100644
--- a/rollbar/pom.xml
+++ b/rollbar/pom.xml
@@ -5,29 +5,29 @@
     <parent>
         <artifactId>rollbar-parent</artifactId>
         <groupId>com.rollbar</groupId>
-        <version>${currentVersion}</version>
-        <relativePath>../parent-pom.xml</relativePath>
+        <version>dev</version>
     </parent>
 
     <modelVersion>4.0.0</modelVersion>
 
     <artifactId>rollbar</artifactId>
+    <version>${rollbar.version}</version>
 
     <dependencies>
         <dependency>
             <groupId>com.rollbar</groupId>
             <artifactId>rollbar-payload</artifactId>
-            <version>${currentVersion}</version>
+            <version>${rollbar.version}</version>
         </dependency>
         <dependency>
             <groupId>com.rollbar</groupId>
             <artifactId>rollbar-sender</artifactId>
-            <version>${currentVersion}</version>
+            <version>${rollbar.version}</version>
         </dependency>
         <dependency>
             <groupId>com.rollbar</groupId>
             <artifactId>rollbar-utilities</artifactId>
-            <version>${currentVersion}</version>
+            <version>${rollbar.version}</version>
         </dependency>
     </dependencies>
 </project>
\ No newline at end of file


Test patch:
diff --git a/rollbar-testing/pom.xml b/rollbar-testing/pom.xml
index f1df2fc..0ce9e72 100644
--- a/rollbar-testing/pom.xml
+++ b/rollbar-testing/pom.xml
@@ -5,19 +5,19 @@
     <parent>
         <groupId>com.rollbar</groupId>
         <artifactId>rollbar-parent</artifactId>
-        <version>${currentVersion}</version>
-        <relativePath>../parent-pom.xml</relativePath>
+        <version>dev</version>
     </parent>
 
     <modelVersion>4.0.0</modelVersion>
 
     <artifactId>rollbar-testing</artifactId>
+    <version>${rollbar.version}</version>
 
     <dependencies>
         <dependency>
             <groupId>com.rollbar</groupId>
             <artifactId>rollbar-utilities</artifactId>
-            <version>${currentVersion}</version>
+            <version>${rollbar.version}</version>
         </dependency>
     </dependencies>