Repository: favonia/cloudflare-ddns
Pull request #950 (2024-09-28 03:33:07)

docs: fix typos in warning

codecov[bot]: ## [Codecov](https://app.codecov.io/gh/favonia/cloudflare-ddns/pull/950?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=favonia) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 95.77%. Comparing base [(`4518fac`)](https://app.codecov.io/gh/favonia/cloudflare-ddns/commit/4518faca43c375545ee3dd6828b571b327579b6b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=favonia) to head [(`acab851`)](https://app.codecov.io/gh/favonia/cloudflare-ddns/commit/acab8516a6f556f377d17fdd1d40659f6149ef5b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=favonia).

<details><summary>Additional details and impacted files</summary>


```diff
@@           Coverage Diff           @@
##             main     #950   +/-   ##
=======================================
  Coverage   95.77%   95.77%           
=======================================
  Files          62       62           
  Lines        2817     2817           
=======================================
  Hits         2698     2698           
  Misses        107      107           
  Partials       12       12           
```

| [Flag](https://app.codecov.io/gh/favonia/cloudflare-ddns/pull/950/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=favonia) | Coverage Δ | |
|---|---|---|
| [unittests](https://app.codecov.io/gh/favonia/cloudflare-ddns/pull/950/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=favonia) | `95.77% <100.00%> (ø)` | |

Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=favonia#carryforward-flags-in-the-pull-request-comment) to find out more.

</details>

[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/favonia/cloudflare-ddns/pull/950?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=favonia).   
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=favonia).


Patch:
diff --git a/internal/config/env_waf.go b/internal/config/env_waf.go
index 14d79ff..ac0e1ef 100644
--- a/internal/config/env_waf.go
+++ b/internal/config/env_waf.go
@@ -28,7 +28,7 @@ func ReadAndAppendWAFListNames(ppfmt pp.PP, key string, field *[]api.WAFList) bo
 	}
 
 	ppfmt.Hintf(pp.HintExperimentalWAF,
-		"You're using the new WAF list manipulation feature added in version 1.14.0")
+		"You're using the experimental WAF list manipulation feature added in version 1.14.0")
 
 	lists := make([]api.WAFList, 0, len(vals))
 


Test patch:
diff --git a/internal/config/env_waf_test.go b/internal/config/env_waf_test.go
index 372d96d..05ddb00 100644
--- a/internal/config/env_waf_test.go
+++ b/internal/config/env_waf_test.go
@@ -37,7 +37,7 @@ func TestReadAndAppendWAFListNames(t *testing.T) {
 			true,
 			func(m *mocks.MockPP) {
 				m.EXPECT().Hintf(pp.HintExperimentalWAF,
-					"You're using the new WAF list manipulation feature added in version 1.14.0")
+					"You're using the experimental WAF list manipulation feature added in version 1.14.0")
 			},
 		},
 		"two": {
@@ -47,7 +47,7 @@ func TestReadAndAppendWAFListNames(t *testing.T) {
 			true,
 			func(m *mocks.MockPP) {
 				m.EXPECT().Hintf(pp.HintExperimentalWAF,
-					"You're using the new WAF list manipulation feature added in version 1.14.0")
+					"You're using the experimental WAF list manipulation feature added in version 1.14.0")
 			},
 		},
 		"one+two": {
@@ -61,7 +61,7 @@ func TestReadAndAppendWAFListNames(t *testing.T) {
 			true,
 			func(m *mocks.MockPP) {
 				m.EXPECT().Hintf(pp.HintExperimentalWAF,
-					"You're using the new WAF list manipulation feature added in version 1.14.0")
+					"You're using the experimental WAF list manipulation feature added in version 1.14.0")
 			},
 		},
 		"invalid-format": {
@@ -71,7 +71,7 @@ func TestReadAndAppendWAFListNames(t *testing.T) {
 			false,
 			func(m *mocks.MockPP) {
 				m.EXPECT().Hintf(pp.HintExperimentalWAF,
-					"You're using the new WAF list manipulation feature added in version 1.14.0")
+					"You're using the experimental WAF list manipulation feature added in version 1.14.0")
 				m.EXPECT().Noticef(pp.EmojiUserError, `List %q should be in format "account-id/list-name"`, "+++")
 			},
 		},
@@ -87,7 +87,7 @@ func TestReadAndAppendWAFListNames(t *testing.T) {
 			true,
 			func(m *mocks.MockPP) {
 				m.EXPECT().Hintf(pp.HintExperimentalWAF,
-					"You're using the new WAF list manipulation feature added in version 1.14.0")
+					"You're using the experimental WAF list manipulation feature added in version 1.14.0")
 				m.EXPECT().Noticef(pp.EmojiUserWarning, "List name %q contains invalid character %q", "!!!", "!")
 			},
 		},