Repository: Materials-Consortia/optimade-python-tools
Pull request #60 (2019-07-26 12:37:27)

Some minor fixes
- Fixed a typo in our version of the schema for the field name `lattice_types` -> `lattice_vectors`.
- Switched the final test that needed a mongo server running to `mongomock` (I assume this is what we want @dwinston ) 

codecov[bot]: # [Codecov](https://codecov.io/gh/Materials-Consortia/optimade-python-tools/pull/60?src=pr&el=h1) Report
> Merging [#60](https://codecov.io/gh/Materials-Consortia/optimade-python-tools/pull/60?src=pr&el=desc) into [master](https://codecov.io/gh/Materials-Consortia/optimade-python-tools/commit/61b271d41049de4d5e59c4650c175717ae9d26e7?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/Materials-Consortia/optimade-python-tools/pull/60/graphs/tree.svg?width=650&token=UJAtmqkZZO&height=150&src=pr)](https://codecov.io/gh/Materials-Consortia/optimade-python-tools/pull/60?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master      #60   +/-   ##
=======================================
  Coverage   76.73%   76.73%           
=======================================
  Files          19       19           
  Lines         649      649           
=======================================
  Hits          498      498           
  Misses        151      151
```


| [Impacted Files](https://codecov.io/gh/Materials-Consortia/optimade-python-tools/pull/60?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [optimade/server/models/structures.py](https://codecov.io/gh/Materials-Consortia/optimade-python-tools/pull/60/diff?src=pr&el=tree#diff-b3B0aW1hZGUvc2VydmVyL21vZGVscy9zdHJ1Y3R1cmVzLnB5) | `59.67% <100%> (ø)` | :arrow_up: |
| [...imade/filtertransformers/tests/test\_transformer.py](https://codecov.io/gh/Materials-Consortia/optimade-python-tools/pull/60/diff?src=pr&el=tree#diff-b3B0aW1hZGUvZmlsdGVydHJhbnNmb3JtZXJzL3Rlc3RzL3Rlc3RfdHJhbnNmb3JtZXIucHk=) | `100% <100%> (ø)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/Materials-Consortia/optimade-python-tools/pull/60?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/Materials-Consortia/optimade-python-tools/pull/60?src=pr&el=footer). Last update [61b271d...904c084](https://codecov.io/gh/Materials-Consortia/optimade-python-tools/pull/60?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


Patch:
diff --git a/optimade/server/models/structures.py b/optimade/server/models/structures.py
index 1ea902a2..3b7a5cd9 100644
--- a/optimade/server/models/structures.py
+++ b/optimade/server/models/structures.py
@@ -260,7 +260,7 @@ the elements in this list each refer to the direction of the corresponding entry
 """,
     )
 
-    lattice_types: Optional[List[conlist(len_eq=3)]] = Schema(
+    lattice_vectors: Optional[List[conlist(len_eq=3)]] = Schema(
         ...,
         description="""List of three lattice vectors in Cartesian coordinates,
 in ångströms (Å).


Test patch:
diff --git a/optimade/filtertransformers/tests/test_transformer.py b/optimade/filtertransformers/tests/test_transformer.py
index fb6a60bb..a51ea683 100644
--- a/optimade/filtertransformers/tests/test_transformer.py
+++ b/optimade/filtertransformers/tests/test_transformer.py
@@ -2,7 +2,7 @@ import itertools
 from unittest import TestCase
 import uuid
 
-from pymongo import MongoClient
+from mongomock import MongoClient
 
 from optimade.filterparser import LarkParser
 from optimade.filtertransformers.mongo import MongoTransformer