Repository: knative-sandbox/eventing-kafka-broker
Pull request #2653 (2022-09-15 21:55:15)

KEDA Trigger Authentication SASL updates for secret spec
Signed-off-by: aavarghese <avarghese@us.ibm.com>



knative-prow[bot]: [APPROVALNOTIFIER] This PR is **NOT APPROVED**

This pull-request has been approved by: *<a href="https://github.com/knative-sandbox/eventing-kafka-broker/pull/2653#" title="Author self-approved">aavarghese</a>*
**Once this PR has been reviewed and has the lgtm label**, please assign n3wscott for approval by writing `/assign @n3wscott` in a comment. For more information see:[The Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).

The full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=knative-sandbox%2Feventing-kafka-broker).

<details open>
Needs approval from an approver in each of these files:

- **[OWNERS](https://github.com/knative-sandbox/eventing-kafka-broker/blob/main/OWNERS)**

Approvers can indicate their approval by writing `/approve` in a comment
Approvers can cancel approval by writing `/approve cancel` in a comment
</details>
<!-- META={"approvers":["n3wscott"]} -->
codecov[bot]: # [Codecov](https://codecov.io/gh/knative-sandbox/eventing-kafka-broker/pull/2653?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=knative-sandbox) Report
> Merging [#2653](https://codecov.io/gh/knative-sandbox/eventing-kafka-broker/pull/2653?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=knative-sandbox) (3bdd63d) into [main](https://codecov.io/gh/knative-sandbox/eventing-kafka-broker/commit/17b742d8a648bdf941814f4b495fc7f59ce81ec6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=knative-sandbox) (17b742d) will **decrease** coverage by `6.13%`.
> The diff coverage is `n/a`.

```diff
@@             Coverage Diff              @@
##               main    #2653      +/-   ##
============================================
- Coverage     61.99%   55.86%   -6.14%     
============================================
  Files           148       75      -73     
  Lines         10391     7853    -2538     
  Branches        229        0     -229     
============================================
- Hits           6442     4387    -2055     
+ Misses         3500     3150     -350     
+ Partials        449      316     -133     
```

| Flag | Coverage Δ | |
|---|---|---|
| java-unittests | `?` | |

Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=knative-sandbox#carryforward-flags-in-the-pull-request-comment) to find out more.

| [Impacted Files](https://codecov.io/gh/knative-sandbox/eventing-kafka-broker/pull/2653?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=knative-sandbox) | Coverage Δ | |
|---|---|---|
| [...patcher/impl/consumer/OrderedConsumerVerticle.java](https://codecov.io/gh/knative-sandbox/eventing-kafka-broker/pull/2653/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=knative-sandbox#diff-ZGF0YS1wbGFuZS9kaXNwYXRjaGVyL3NyYy9tYWluL2phdmEvZGV2L2tuYXRpdmUvZXZlbnRpbmcva2Fma2EvYnJva2VyL2Rpc3BhdGNoZXIvaW1wbC9jb25zdW1lci9PcmRlcmVkQ29uc3VtZXJWZXJ0aWNsZS5qYXZh) | | |
| [...nting/kafka/broker/dispatcher/ResponseHandler.java](https://codecov.io/gh/knative-sandbox/eventing-kafka-broker/pull/2653/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=knative-sandbox#diff-ZGF0YS1wbGFuZS9kaXNwYXRjaGVyL3NyYy9tYWluL2phdmEvZGV2L2tuYXRpdmUvZXZlbnRpbmcva2Fma2EvYnJva2VyL2Rpc3BhdGNoZXIvUmVzcG9uc2VIYW5kbGVyLmphdmE=) | | |
| [...roker/dispatcher/impl/filter/AttributesFilter.java](https://codecov.io/gh/knative-sandbox/eventing-kafka-broker/pull/2653/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=knative-sandbox#diff-ZGF0YS1wbGFuZS9kaXNwYXRjaGVyL3NyYy9tYWluL2phdmEvZGV2L2tuYXRpdmUvZXZlbnRpbmcva2Fma2EvYnJva2VyL2Rpc3BhdGNoZXIvaW1wbC9maWx0ZXIvQXR0cmlidXRlc0ZpbHRlci5qYXZh) | | |
| [...a/broker/core/security/KubernetesAuthProvider.java](https://codecov.io/gh/knative-sandbox/eventing-kafka-broker/pull/2653/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=knative-sandbox#diff-ZGF0YS1wbGFuZS9jb3JlL3NyYy9tYWluL2phdmEvZGV2L2tuYXRpdmUvZXZlbnRpbmcva2Fma2EvYnJva2VyL2NvcmUvc2VjdXJpdHkvS3ViZXJuZXRlc0F1dGhQcm92aWRlci5qYXZh) | | |
| [...spatcher/impl/consumer/CloudEventDeserializer.java](https://codecov.io/gh/knative-sandbox/eventing-kafka-broker/pull/2653/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=knative-sandbox#diff-ZGF0YS1wbGFuZS9kaXNwYXRjaGVyL3NyYy9tYWluL2phdmEvZGV2L2tuYXRpdmUvZXZlbnRpbmcva2Fma2EvYnJva2VyL2Rpc3BhdGNoZXIvaW1wbC9jb25zdW1lci9DbG91ZEV2ZW50RGVzZXJpYWxpemVyLmphdmE=) | | |
| [...nciler/impl/ResourcesReconcilerMessageHandler.java](https://codecov.io/gh/knative-sandbox/eventing-kafka-broker/pull/2653/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=knative-sandbox#diff-ZGF0YS1wbGFuZS9jb3JlL3NyYy9tYWluL2phdmEvZGV2L2tuYXRpdmUvZXZlbnRpbmcva2Fma2EvYnJva2VyL2NvcmUvcmVjb25jaWxlci9pbXBsL1Jlc291cmNlc1JlY29uY2lsZXJNZXNzYWdlSGFuZGxlci5qYXZh) | | |
| [...er/dispatcher/impl/consumer/InvalidCloudEvent.java](https://codecov.io/gh/knative-sandbox/eventing-kafka-broker/pull/2653/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=knative-sandbox#diff-ZGF0YS1wbGFuZS9kaXNwYXRjaGVyL3NyYy9tYWluL2phdmEvZGV2L2tuYXRpdmUvZXZlbnRpbmcva2Fma2EvYnJva2VyL2Rpc3BhdGNoZXIvaW1wbC9jb25zdW1lci9JbnZhbGlkQ2xvdWRFdmVudC5qYXZh) | | |
| [...dispatcher/impl/ResponseToHttpEndpointHandler.java](https://codecov.io/gh/knative-sandbox/eventing-kafka-broker/pull/2653/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=knative-sandbox#diff-ZGF0YS1wbGFuZS9kaXNwYXRjaGVyL3NyYy9tYWluL2phdmEvZGV2L2tuYXRpdmUvZXZlbnRpbmcva2Fma2EvYnJva2VyL2Rpc3BhdGNoZXIvaW1wbC9SZXNwb25zZVRvSHR0cEVuZHBvaW50SGFuZGxlci5qYXZh) | | |
| [...ceiver/impl/handler/IngressRequestHandlerImpl.java](https://codecov.io/gh/knative-sandbox/eventing-kafka-broker/pull/2653/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=knative-sandbox#diff-ZGF0YS1wbGFuZS9yZWNlaXZlci9zcmMvbWFpbi9qYXZhL2Rldi9rbmF0aXZlL2V2ZW50aW5nL2thZmthL2Jyb2tlci9yZWNlaXZlci9pbXBsL2hhbmRsZXIvSW5ncmVzc1JlcXVlc3RIYW5kbGVySW1wbC5qYXZh) | | |
| [...her/impl/filter/subscriptionsapi/PrefixFilter.java](https://codecov.io/gh/knative-sandbox/eventing-kafka-broker/pull/2653/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=knative-sandbox#diff-ZGF0YS1wbGFuZS9kaXNwYXRjaGVyL3NyYy9tYWluL2phdmEvZGV2L2tuYXRpdmUvZXZlbnRpbmcva2Fma2EvYnJva2VyL2Rpc3BhdGNoZXIvaW1wbC9maWx0ZXIvc3Vic2NyaXB0aW9uc2FwaS9QcmVmaXhGaWx0ZXIuamF2YQ==) | | |
| ... and [63 more](https://codecov.io/gh/knative-sandbox/eventing-kafka-broker/pull/2653/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=knative-sandbox) | |

Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=knative-sandbox). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=knative-sandbox)

knative-prow[bot]: [APPROVALNOTIFIER] This PR is **NOT APPROVED**

This pull-request has been approved by: *<a href="https://github.com/knative-sandbox/eventing-kafka-broker/pull/2653#" title="Author self-approved">aavarghese</a>*
**Once this PR has been reviewed and has the lgtm label**, please assign nak3 for approval by writing `/assign @nak3` in a comment. For more information see:[The Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).

The full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=knative-sandbox%2Feventing-kafka-broker).

<details open>
Needs approval from an approver in each of these files:

- **[OWNERS](https://github.com/knative-sandbox/eventing-kafka-broker/blob/main/OWNERS)**

Approvers can indicate their approval by writing `/approve` in a comment
Approvers can cancel approval by writing `/approve cancel` in a comment
</details>
<!-- META={"approvers":["nak3"]} -->
knative-prow-robot: @aavarghese: PR needs rebase.

<details>

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
</details>
knative-prow[bot]: @aavarghese: The following test **failed**, say `/retest` to rerun all failed tests or `/retest-required` to rerun all mandatory failed tests:

Test name | Commit | Details | Required | Rerun command
--- | --- | --- | --- | ---
reconciler-tests-namespaced-broker_eventing-kafka-broker_main | 9da1d116e3a19379132e0ea9d48f3afc27023a2f | [link](https://prow.knative.dev/view/gs/knative-prow/pr-logs/pull/knative-sandbox_eventing-kafka-broker/2653/reconciler-tests-namespaced-broker_eventing-kafka-broker_main/1582062057337917440) | true | `/test reconciler-tests-namespaced-broker`

[Your PR dashboard](https://prow.knative.dev/pr).

<details>

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
</details>
<!-- test report -->
knative-prow[bot]: [APPROVALNOTIFIER] This PR is **NOT APPROVED**

This pull-request has been approved by: *<a href="https://github.com/knative-sandbox/eventing-kafka-broker/pull/2653#" title="Author self-approved">aavarghese</a>*
**Once this PR has been reviewed and has the lgtm label**, please assign nak3 for approval by writing `/assign @nak3` in a comment. For more information see [the Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).

The full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=knative-sandbox%2Feventing-kafka-broker).

<details open>
Needs approval from an approver in each of these files:

- **[OWNERS](https://github.com/knative-sandbox/eventing-kafka-broker/blob/main/OWNERS)**

Approvers can indicate their approval by writing `/approve` in a comment
Approvers can cancel approval by writing `/approve cancel` in a comment
</details>
<!-- META={"approvers":["nak3"]} -->
knative-prow[bot]: @aavarghese: The following test **failed**, say `/retest` to rerun all failed tests or `/retest-required` to rerun all mandatory failed tests:

Test name | Commit | Details | Required | Rerun command
--- | --- | --- | --- | ---
channel-reconciler-tests-ssl_eventing-kafka-broker_main | 516c3367e9e06459795eec67954bb48d53dc14da | [link](https://prow.knative.dev/view/gs/knative-prow/pr-logs/pull/knative-sandbox_eventing-kafka-broker/2653/channel-reconciler-tests-ssl_eventing-kafka-broker_main/1585396001701629952) | true | `/test channel-reconciler-tests-ssl`

[Your PR dashboard](https://prow.knative.dev/pr).

<details>

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
</details>
<!-- test report -->
knative-prow[bot]: @aavarghese: The following tests **failed**, say `/retest` to rerun all failed tests or `/retest-required` to rerun all mandatory failed tests:

Test name | Commit | Details | Required | Rerun command
--- | --- | --- | --- | ---
channel-reconciler-tests-ssl_eventing-kafka-broker_main | 516c3367e9e06459795eec67954bb48d53dc14da | [link](https://prow.knative.dev/view/gs/knative-prow/pr-logs/pull/knative-sandbox_eventing-kafka-broker/2653/channel-reconciler-tests-ssl_eventing-kafka-broker_main/1585396001701629952) | true | `/test channel-reconciler-tests-ssl`
channel-reconciler-tests-sasl-ssl_eventing-kafka-broker_main | 516c3367e9e06459795eec67954bb48d53dc14da | [link](https://prow.knative.dev/view/gs/knative-prow/pr-logs/pull/knative-sandbox_eventing-kafka-broker/2653/channel-reconciler-tests-sasl-ssl_eventing-kafka-broker_main/1585396002989281280) | true | `/test channel-reconciler-tests-sasl-ssl`

[Your PR dashboard](https://prow.knative.dev/pr).

<details>

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
</details>
<!-- test report -->
knative-prow[bot]: @aavarghese: The following tests **failed**, say `/retest` to rerun all failed tests or `/retest-required` to rerun all mandatory failed tests:

Test name | Commit | Details | Required | Rerun command
--- | --- | --- | --- | ---
channel-reconciler-tests-ssl_eventing-kafka-broker_main | 516c3367e9e06459795eec67954bb48d53dc14da | [link](https://prow.knative.dev/view/gs/knative-prow/pr-logs/pull/knative-sandbox_eventing-kafka-broker/2653/channel-reconciler-tests-ssl_eventing-kafka-broker_main/1585396001701629952) | true | `/test channel-reconciler-tests-ssl`
channel-reconciler-tests-sasl-ssl_eventing-kafka-broker_main | 516c3367e9e06459795eec67954bb48d53dc14da | [link](https://prow.knative.dev/view/gs/knative-prow/pr-logs/pull/knative-sandbox_eventing-kafka-broker/2653/channel-reconciler-tests-sasl-ssl_eventing-kafka-broker_main/1585396002989281280) | true | `/test channel-reconciler-tests-sasl-ssl`
channel-integration-tests-sasl-plain_eventing-kafka-broker_main | 516c3367e9e06459795eec67954bb48d53dc14da | [link](https://prow.knative.dev/view/gs/knative-prow/pr-logs/pull/knative-sandbox_eventing-kafka-broker/2653/channel-integration-tests-sasl-plain_eventing-kafka-broker_main/1585396000850186240) | true | `/test channel-integration-tests-sasl-plain`

[Your PR dashboard](https://prow.knative.dev/pr).

<details>

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
</details>
<!-- test report -->
knative-prow[bot]: @aavarghese: The following tests **failed**, say `/retest` to rerun all failed tests or `/retest-required` to rerun all mandatory failed tests:

Test name | Commit | Details | Required | Rerun command
--- | --- | --- | --- | ---
channel-reconciler-tests-ssl_eventing-kafka-broker_main | 516c3367e9e06459795eec67954bb48d53dc14da | [link](https://prow.knative.dev/view/gs/knative-prow/pr-logs/pull/knative-sandbox_eventing-kafka-broker/2653/channel-reconciler-tests-ssl_eventing-kafka-broker_main/1585396001701629952) | true | `/test channel-reconciler-tests-ssl`
channel-reconciler-tests-sasl-ssl_eventing-kafka-broker_main | 516c3367e9e06459795eec67954bb48d53dc14da | [link](https://prow.knative.dev/view/gs/knative-prow/pr-logs/pull/knative-sandbox_eventing-kafka-broker/2653/channel-reconciler-tests-sasl-ssl_eventing-kafka-broker_main/1585396002989281280) | true | `/test channel-reconciler-tests-sasl-ssl`
channel-integration-tests-sasl-plain_eventing-kafka-broker_main | 516c3367e9e06459795eec67954bb48d53dc14da | [link](https://prow.knative.dev/view/gs/knative-prow/pr-logs/pull/knative-sandbox_eventing-kafka-broker/2653/channel-integration-tests-sasl-plain_eventing-kafka-broker_main/1585396000850186240) | true | `/test channel-integration-tests-sasl-plain`
reconciler-tests-namespaced-broker_eventing-kafka-broker_main | 516c3367e9e06459795eec67954bb48d53dc14da | [link](https://prow.knative.dev/view/gs/knative-prow/pr-logs/pull/knative-sandbox_eventing-kafka-broker/2653/reconciler-tests-namespaced-broker_eventing-kafka-broker_main/1585395996664270848) | true | `/test reconciler-tests-namespaced-broker`

[Your PR dashboard](https://prow.knative.dev/pr).

<details>

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
</details>
<!-- test report -->
aavarghese: /retest-required
knative-prow[bot]: @aavarghese: The following tests **failed**, say `/retest` to rerun all failed tests or `/retest-required` to rerun all mandatory failed tests:

Test name | Commit | Details | Required | Rerun command
--- | --- | --- | --- | ---
reconciler-tests-namespaced-broker_eventing-kafka-broker_main | 516c3367e9e06459795eec67954bb48d53dc14da | [link](https://prow.knative.dev/view/gs/knative-prow/pr-logs/pull/knative-sandbox_eventing-kafka-broker/2653/reconciler-tests-namespaced-broker_eventing-kafka-broker_main/1585395996664270848) | true | `/test reconciler-tests-namespaced-broker`
channel-integration-tests-sasl-plain_eventing-kafka-broker_main | 516c3367e9e06459795eec67954bb48d53dc14da | [link](https://prow.knative.dev/view/gs/knative-prow/pr-logs/pull/knative-sandbox_eventing-kafka-broker/2653/channel-integration-tests-sasl-plain_eventing-kafka-broker_main/1585479483270369280) | true | `/test channel-integration-tests-sasl-plain`

[Your PR dashboard](https://prow.knative.dev/pr).

<details>

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
</details>
<!-- test report -->
knative-prow-robot: @aavarghese: PR needs rebase.

<details>

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
</details>
aavarghese: KEDA integrations works for Channels and Triggers now with SASL types in SecretSpec. Will add support for TLS in a following PR...
knative-prow[bot]: @aavarghese: The following tests **failed**, say `/retest` to rerun all failed tests or `/retest-required` to rerun all mandatory failed tests:

Test name | Commit | Details | Required | Rerun command
--- | --- | --- | --- | ---
channel-integration-tests-sasl-plain_eventing-kafka-broker_main | 516c3367e9e06459795eec67954bb48d53dc14da | [link](https://prow.knative.dev/view/gs/knative-prow/pr-logs/pull/knative-sandbox_eventing-kafka-broker/2653/channel-integration-tests-sasl-plain_eventing-kafka-broker_main/1585479483270369280) | true | `/test channel-integration-tests-sasl-plain`
build-tests_eventing-kafka-broker_main | f3d2f2765dca9b6003dce0d033801b03b2667a38 | [link](https://prow.knative.dev/view/gs/knative-prow/pr-logs/pull/knative-sandbox_eventing-kafka-broker/2653/build-tests_eventing-kafka-broker_main/1585555900410630144) | true | `/test build-tests`

[Your PR dashboard](https://prow.knative.dev/pr).

<details>

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
</details>
<!-- test report -->
aavarghese: /test build-tests
pierDipi: /approve
knative-prow[bot]: [APPROVALNOTIFIER] This PR is **APPROVED**

This pull-request has been approved by: *<a href="https://github.com/knative-sandbox/eventing-kafka-broker/pull/2653#" title="Author self-approved">aavarghese</a>*, *<a href="https://github.com/knative-sandbox/eventing-kafka-broker/pull/2653#issuecomment-1294710630" title="Approved">pierDipi</a>*

The full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=knative-sandbox%2Feventing-kafka-broker).

The pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)

<details >
Needs approval from an approver in each of these files:

- ~~[OWNERS](https://github.com/knative-sandbox/eventing-kafka-broker/blob/main/OWNERS)~~ [pierDipi]

Approvers can indicate their approval by writing `/approve` in a comment
Approvers can cancel approval by writing `/approve cancel` in a comment
</details>
<!-- META={"approvers":[]} -->

Patch:
diff --git a/control-plane/pkg/keda/keda.go b/control-plane/pkg/keda/keda.go
index d6637654b..f4befb4e8 100644
--- a/control-plane/pkg/keda/keda.go
+++ b/control-plane/pkg/keda/keda.go
@@ -25,14 +25,14 @@ import (
 	kedav1alpha1 "knative.dev/eventing-kafka-broker/third_party/pkg/apis/keda/v1alpha1"
 	"knative.dev/eventing-kafka/pkg/apis/bindings/v1beta1"
 	"knative.dev/pkg/kmeta"
-	"knative.dev/pkg/reconciler"
 
 	kafkainternals "knative.dev/eventing-kafka-broker/control-plane/pkg/apis/internals/kafka/eventing/v1alpha1"
 	"knative.dev/eventing-kafka-broker/control-plane/pkg/kafka"
 )
 
 const (
-	defaultKafkaLagThreshold = 10
+	defaultKafkaLagThreshold           = 10
+	defaultKafkaActivationLagThreshold = 0
 )
 
 func GenerateScaleTarget(cg *kafkainternals.ConsumerGroup) *kedav1alpha1.ScaleTarget {
@@ -53,6 +53,11 @@ func GenerateScaleTriggers(cg *kafkainternals.ConsumerGroup, triggerAuthenticati
 		return nil, err
 	}
 
+	activationLagThreshold, err := GetInt32ValueFromMap(cg.Annotations, KedaAutoscalingKafkaActivationLagThreshold, defaultKafkaActivationLagThreshold)
+	if err != nil {
+		return nil, err
+	}
+
 	allowIdleConsumers := "false"
 	if cg.Status.Placements != nil {
 		allowIdleConsumers = "true"
@@ -60,11 +65,12 @@ func GenerateScaleTriggers(cg *kafkainternals.ConsumerGroup, triggerAuthenticati
 
 	for _, topic := range cg.Spec.Template.Spec.Topics {
 		triggerMetadata := map[string]string{
-			"bootstrapServers":   bootstrapServers,
-			"consumerGroup":      consumerGroup,
-			"topic":              topic,
-			"lagThreshold":       strconv.Itoa(int(*lagThreshold)),
-			"allowIdleConsumers": allowIdleConsumers,
+			"bootstrapServers":       bootstrapServers,
+			"consumerGroup":          consumerGroup,
+			"topic":                  topic,
+			"lagThreshold":           strconv.Itoa(int(*lagThreshold)),
+			"activationLagThreshold": strconv.Itoa(int(*activationLagThreshold)),
+			"allowIdleConsumers":     allowIdleConsumers,
 		}
 
 		trigger := kedav1alpha1.ScaleTriggers{
@@ -83,10 +89,36 @@ func GenerateScaleTriggers(cg *kafkainternals.ConsumerGroup, triggerAuthenticati
 	return triggers, nil
 }
 
-func GenerateTriggerAuthentication(cg *kafkainternals.ConsumerGroup, saslType *string) (*kedav1alpha1.TriggerAuthentication, *corev1.Secret, error) {
+func GenerateTriggerAuthentication(cg *kafkainternals.ConsumerGroup, saslType *string, protocol *string) (*kedav1alpha1.TriggerAuthentication, *corev1.Secret, error) {
 
 	secretTargetRefs := make([]kedav1alpha1.AuthSecretTargetRef, 0, 8)
-	var secret corev1.Secret
+
+	secret := corev1.Secret{
+		ObjectMeta: metav1.ObjectMeta{
+			Name:      cg.Name,
+			Namespace: cg.Namespace,
+			OwnerReferences: []metav1.OwnerReference{
+				*kmeta.NewControllerRef(cg),
+			},
+		},
+		Data:       make(map[string][]byte),
+		StringData: make(map[string]string),
+	}
+
+	if saslType != nil {
+		switch *saslType {
+		case "SCRAM-SHA-256":
+			secret.StringData["sasl"] = "scram_sha256"
+		case "SCRAM-SHA-512":
+			secret.StringData["sasl"] = "scram_sha512"
+		case "PLAIN":
+			secret.StringData["sasl"] = "plaintext"
+		default:
+			return nil, nil, fmt.Errorf("SASL type value %q is not supported", *saslType)
+		}
+	} else {
+		secret.StringData["sasl"] = "plaintext" //default
+	}
 
 	triggerAuth := &kedav1alpha1.TriggerAuthentication{
 		ObjectMeta: metav1.ObjectMeta{
@@ -105,35 +137,8 @@ func GenerateTriggerAuthentication(cg *kafkainternals.ConsumerGroup, saslType *s
 	}
 
 	if cg.Spec.Template.Spec.Auth.NetSpec != nil {
-		secret = corev1.Secret{
-			ObjectMeta: metav1.ObjectMeta{
-				Name:      cg.Name,
-				Namespace: cg.Namespace,
-				OwnerReferences: []metav1.OwnerReference{
-					*kmeta.NewControllerRef(cg),
-				},
-			},
-			Data:       make(map[string][]byte),
-			StringData: make(map[string]string),
-		}
 
 		if cg.Spec.Template.Spec.Auth.NetSpec.SASL.Enable {
-
-			if saslType != nil {
-				switch *saslType {
-				case "SCRAM-SHA-256":
-					secret.StringData["sasl"] = "scram_sha256"
-				case "SCRAM-SHA-512":
-					secret.StringData["sasl"] = "scram_sha512"
-				case "PLAIN":
-					secret.StringData["sasl"] = "plaintext"
-				default:
-					return nil, nil, fmt.Errorf("SASL type value %q is not supported", *saslType)
-				}
-			} else {
-				secret.StringData["sasl"] = "plaintext" //default
-			}
-
 			sasl := kedav1alpha1.AuthSecretTargetRef{Parameter: "sasl", Name: secret.Name, Key: "sasl"}
 			secretTargetRefs = append(secretTargetRefs, sasl)
 
@@ -157,36 +162,26 @@ func GenerateTriggerAuthentication(cg *kafkainternals.ConsumerGroup, saslType *s
 	}
 
 	if cg.Spec.Template.Spec.Auth.SecretSpec != nil && cg.Spec.Template.Spec.Auth.SecretSpec.Ref.Name != "" {
-		host := kedav1alpha1.AuthSecretTargetRef{
-			Parameter: "host", //TODO: parameter name?
-			Name:      cg.Spec.Template.Spec.Auth.SecretSpec.Ref.Name,
-			Key:       "", //TODO: key value?
+		sasl := kedav1alpha1.AuthSecretTargetRef{Parameter: "sasl", Name: secret.Name, Key: "sasl"}
+		secretTargetRefs = append(secretTargetRefs, sasl)
+
+		if protocol != nil {
+			user := kedav1alpha1.AuthSecretTargetRef{Parameter: "username", Name: cg.Spec.Template.Spec.Auth.SecretSpec.Ref.Name, Key: "user"}
+			secretTargetRefs = append(secretTargetRefs, user)
+		} else {
+			username := kedav1alpha1.AuthSecretTargetRef{Parameter: "username", Name: cg.Spec.Template.Spec.Auth.SecretSpec.Ref.Name, Key: "username"}
+			secretTargetRefs = append(secretTargetRefs, username)
 		}
-		secretTargetRefs = append(secretTargetRefs, host)
-		triggerAuth.Spec.SecretTargetRef = secretTargetRefs
 
-		return triggerAuth, nil, nil
-	}
+		password := kedav1alpha1.AuthSecretTargetRef{Parameter: "password", Name: cg.Spec.Template.Spec.Auth.SecretSpec.Ref.Name, Key: "password"}
+		secretTargetRefs = append(secretTargetRefs, password)
 
-	return triggerAuth, &secret, nil
-}
-
-// scaleObjectCreated makes a new reconciler event with event type Normal, and
-// reason ScaledObjectCreated.
-func ScaleObjectCreated(namespace, name string) reconciler.Event {
-	return reconciler.NewEvent(corev1.EventTypeNormal, "ScaledObjectCreated", "ScaledObject created: \"%s/%s\"", namespace, name)
-}
+		//TODO: TLS support to be added
 
-// scaleObjectUpdated makes a new reconciler event with event type Normal, and
-// reason ScaledObjectUpdated.
-func ScaleObjectUpdated(namespace, name string) reconciler.Event {
-	return reconciler.NewEvent(corev1.EventTypeNormal, "ScaledObjectUpdated", "ScaledObject updated: \"%s/%s\"", namespace, name)
-}
+		triggerAuth.Spec.SecretTargetRef = secretTargetRefs
+	}
 
-// scaleObjectFailed makes a new reconciler event with event type Warning, and
-// reason ScaleObjectFailed.
-func ScaleObjectFailed(namespace, name string, err error) reconciler.Event {
-	return reconciler.NewEvent(corev1.EventTypeWarning, "ScaleObjectFailed", "ScaledObject failed to create: \"%s/%s\", %w", namespace, name, err)
+	return triggerAuth, &secret, nil
 }
 
 func addAuthSecretTargetRef(parameter string, secretKeyRef v1beta1.SecretValueFromSource, secretTargetRefs []kedav1alpha1.AuthSecretTargetRef) []kedav1alpha1.AuthSecretTargetRef {
@@ -213,6 +208,7 @@ func SetAutoscalingAnnotations(objannotations map[string]string) map[string]stri
 		setAnnotation(objannotations, KedaAutoscalingPollingIntervalAnnotation, cgannotations)
 		setAnnotation(objannotations, KedaAutoscalingCooldownPeriodAnnotation, cgannotations)
 		setAnnotation(objannotations, KedaAutoscalingKafkaLagThreshold, cgannotations)
+		setAnnotation(objannotations, KedaAutoscalingKafkaActivationLagThreshold, cgannotations)
 		return cgannotations
 	}
 	return nil
diff --git a/control-plane/pkg/reconciler/consumergroup/consumergroup.go b/control-plane/pkg/reconciler/consumergroup/consumergroup.go
index cbef3c3c9..050714ff7 100644
--- a/control-plane/pkg/reconciler/consumergroup/consumergroup.go
+++ b/control-plane/pkg/reconciler/consumergroup/consumergroup.go
@@ -49,6 +49,7 @@ import (
 	kafkainternalslisters "knative.dev/eventing-kafka-broker/control-plane/pkg/client/internals/kafka/listers/eventing/v1alpha1"
 	"knative.dev/eventing-kafka-broker/control-plane/pkg/kafka"
 	"knative.dev/eventing-kafka-broker/control-plane/pkg/keda"
+	"knative.dev/eventing-kafka-broker/control-plane/pkg/security"
 
 	kedafunc "knative.dev/eventing-kafka-broker/control-plane/pkg/keda"
 	kedav1alpha1 "knative.dev/eventing-kafka-broker/third_party/pkg/apis/keda/v1alpha1"
@@ -455,7 +456,12 @@ func (r Reconciler) reconcileKedaObjects(ctx context.Context, cg *kafkainternals
 			return err
 		}
 
-		triggerAuthentication, secret, err = kedafunc.GenerateTriggerAuthentication(cg, saslType)
+		protocol, err := r.retrieveProtocolIfPresent(ctx, cg)
+		if err != nil {
+			return err
+		}
+
+		triggerAuthentication, secret, err = kedafunc.GenerateTriggerAuthentication(cg, saslType, protocol)
 		if err != nil {
 			return err
 		}
@@ -489,16 +495,40 @@ func (r Reconciler) reconcileKedaObjects(ctx context.Context, cg *kafkainternals
 }
 
 func (r *Reconciler) retrieveSaslTypeIfPresent(ctx context.Context, cg *kafkainternals.ConsumerGroup) (*string, error) {
-	if hasNetSpecAuthConfig(cg.Spec.Template.Spec.Auth) && cg.Spec.Template.Spec.Auth.NetSpec.SASL.Enable {
-		if cg.Spec.Template.Spec.Auth.NetSpec.SASL.Type.SecretKeyRef != nil {
-			secretKeyRefName := cg.Spec.Template.Spec.Auth.NetSpec.SASL.Type.SecretKeyRef.Name
-			secretKeyRefKey := cg.Spec.Template.Spec.Auth.NetSpec.SASL.Type.SecretKeyRef.Key
-			secret, err := r.KubeClient.CoreV1().Secrets(cg.Namespace).Get(ctx, secretKeyRefName, metav1.GetOptions{})
-			if err != nil {
-				return nil, reconciler.NewEvent(corev1.EventTypeWarning, "SaslTypeSecretUnavailable", "Unable to get SASL type from secret: \"%s/%s\", %w", cg.Namespace, secretKeyRefName, err)
-			}
-			saslTypeValue := string(secret.Data[secretKeyRefKey])
-			return &saslTypeValue, nil
+	if hasNetSpecAuthConfig(cg.Spec.Template.Spec.Auth) && cg.Spec.Template.Spec.Auth.NetSpec.SASL.Enable && cg.Spec.Template.Spec.Auth.NetSpec.SASL.Type.SecretKeyRef != nil {
+		secretKeyRefName := cg.Spec.Template.Spec.Auth.NetSpec.SASL.Type.SecretKeyRef.Name
+		secretKeyRefKey := cg.Spec.Template.Spec.Auth.NetSpec.SASL.Type.SecretKeyRef.Key
+		secret, err := r.KubeClient.CoreV1().Secrets(cg.Namespace).Get(ctx, secretKeyRefName, metav1.GetOptions{})
+		if err != nil {
+			return nil, fmt.Errorf("unable to get SASL type from secret: \"%s/%s\", %w", cg.Namespace, secretKeyRefName, err)
+		}
+		saslTypeValue := string(secret.Data[secretKeyRefKey])
+		return &saslTypeValue, nil
+	}
+	if hasSecretSpecConfig(cg.Spec.Template.Spec.Auth) && cg.Spec.Template.Spec.Auth.SecretSpec.Ref != nil {
+		secretKeyRefName := cg.Spec.Template.Spec.Auth.SecretSpec.Ref.Name
+		secretKeyRefNamespace := cg.Spec.Template.Spec.Auth.SecretSpec.Ref.Namespace
+		secret, err := r.KubeClient.CoreV1().Secrets(secretKeyRefNamespace).Get(ctx, secretKeyRefName, metav1.GetOptions{})
+		if err != nil {
+			return nil, fmt.Errorf("unable to get SASL type from secret: \"%s/%s\", %w", secretKeyRefNamespace, secretKeyRefName, err)
+		}
+		saslTypeValue := string(secret.Data["saslType"])
+		return &saslTypeValue, nil
+	}
+	return nil, nil
+}
+
+func (r *Reconciler) retrieveProtocolIfPresent(ctx context.Context, cg *kafkainternals.ConsumerGroup) (*string, error) {
+	if hasSecretSpecConfig(cg.Spec.Template.Spec.Auth) && cg.Spec.Template.Spec.Auth.SecretSpec.Ref != nil {
+		secretKeyRefName := cg.Spec.Template.Spec.Auth.SecretSpec.Ref.Name
+		secretKeyRefNamespace := cg.Spec.Template.Spec.Auth.SecretSpec.Ref.Namespace
+		secret, err := r.KubeClient.CoreV1().Secrets(secretKeyRefNamespace).Get(ctx, secretKeyRefName, metav1.GetOptions{})
+		if err != nil {
+			return nil, fmt.Errorf("unable to get Protocol from secret: \"%s/%s\", %w", secretKeyRefNamespace, secretKeyRefName, err)
+		}
+		if protocolValue, ok := secret.Data[security.ProtocolKey]; ok {
+			protocol := string(protocolValue)
+			return &protocol, nil
 		}
 	}
 	return nil, nil
@@ -575,8 +605,8 @@ func (r *Reconciler) reconcileSecret(ctx context.Context, expectedSecret *corev1
 func (r *Reconciler) isKEDAEnabled(ctx context.Context, namespace string) bool {
 	// TODO: code below failing unit tests with err: "panic: interface conversion: testing.ActionImpl is not testing.GetAction: missing method GetName"
 	/*if err := discovery.ServerSupportsVersion(r.KubeClient.Discovery(), keda.KedaSchemeGroupVersion); err == nil {
-		return true
-	}*/
+		 return true
+	 }*/
 
 	if r.KafkaFeatureFlags.IsControllerAutoscalerEnabled() {
 		if _, err := r.KedaClient.KedaV1alpha1().ScaledObjects(namespace).List(ctx, metav1.ListOptions{}); err != nil {


Test patch:
diff --git a/control-plane/pkg/reconciler/testing/objects_consumergroup.go b/control-plane/pkg/reconciler/testing/objects_consumergroup.go
index 4f776743a..9839cb038 100644
--- a/control-plane/pkg/reconciler/testing/objects_consumergroup.go
+++ b/control-plane/pkg/reconciler/testing/objects_consumergroup.go
@@ -70,12 +70,13 @@ var (
 	}
 
 	ConsumerGroupAnnotations = map[string]string{
-		keda.AutoscalingClassAnnotation:               keda.KEDA,
-		keda.AutoscalingMinScaleAnnotation:            "0",
-		keda.AutoscalingMaxScaleAnnotation:            "5",
-		keda.KedaAutoscalingPollingIntervalAnnotation: "30",
-		keda.KedaAutoscalingCooldownPeriodAnnotation:  "300",
-		keda.KedaAutoscalingKafkaLagThreshold:         "10",
+		keda.AutoscalingClassAnnotation:                 keda.KEDA,
+		keda.AutoscalingMinScaleAnnotation:              "0",
+		keda.AutoscalingMaxScaleAnnotation:              "5",
+		keda.KedaAutoscalingPollingIntervalAnnotation:   "30",
+		keda.KedaAutoscalingCooldownPeriodAnnotation:    "300",
+		keda.KedaAutoscalingKafkaLagThreshold:           "10",
+		keda.KedaAutoscalingKafkaActivationLagThreshold: "1",
 	}
 )