Repository: FairwindsOps/pluto
Pull request #79 (2020-05-28 14:53:09)

Add support for secrets for helm v2
It's possible to use helm v2 with added security mesure (disable tiller svc & secrets instead of configmaps):

```bash
helm init --history-max 5 --service-account tiller --override 'spec.template.spec.containers[0].command'='{/tiller,--listen=127.0.0.1:44134,--storage=secret}
```
In order to support this feature, I have add a flag `--helm-store` to the detect-helm command. I have tested it with my EKS sandbox cluster (1.15.x) with installed helm 2.14.2.


laghoule: I forgot to update the readme.md. If you're interresed with this PR, I will update it.
lucasreed: > I forgot to update the readme.md. If you're interresed with this PR, I will update it.

An update to the README would be great! Fine to add that at the end when the other review items are updated. Thanks!
sudermanjr: The venom tests aren't running right now due to Quay outage. I don't think your changes will break them, but you might consider adding some to cover the new functionality
laghoule: I have already made a test coverage of the new functionality ;)
codecov[bot]: # [Codecov](https://codecov.io/gh/FairwindsOps/pluto/pull/79?src=pr&el=h1) Report
> Merging [#79](https://codecov.io/gh/FairwindsOps/pluto/pull/79?src=pr&el=desc) into [master](https://codecov.io/gh/FairwindsOps/pluto/commit/f7e3a0636586d080a419d72dba91bdf841b8a8a9&el=desc) will **increase** coverage by `0.25%`.
> The diff coverage is `83.33%`.

[![Impacted file tree graph](https://codecov.io/gh/FairwindsOps/pluto/pull/79/graphs/tree.svg?width=650&height=150&src=pr&token=A23F79JTNA)](https://codecov.io/gh/FairwindsOps/pluto/pull/79?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master      #79      +/-   ##
==========================================
+ Coverage   78.23%   78.49%   +0.25%     
==========================================
  Files           6        6              
  Lines         363      372       +9     
==========================================
+ Hits          284      292       +8     
- Misses         52       53       +1     
  Partials       27       27              
```


| [Impacted Files](https://codecov.io/gh/FairwindsOps/pluto/pull/79?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/helm/helm.go](https://codecov.io/gh/FairwindsOps/pluto/pull/79/diff?src=pr&el=tree#diff-cGtnL2hlbG0vaGVsbS5nbw==) | `65.95% <83.33%> (+2.42%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/FairwindsOps/pluto/pull/79?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/FairwindsOps/pluto/pull/79?src=pr&el=footer). Last update [f7e3a06...3953433](https://codecov.io/gh/FairwindsOps/pluto/pull/79?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

sudermanjr: > I have already made a test coverage of the new functionality ;)

Sorry, I wasn't clear. We have two sets of tests, functional and unit. You got the unit tests covered (which is awesome, thank you). 

We also have functional testing with Venom in the e2e directory. Those are the ones I was referring to.

Patch:
diff --git a/README.md b/README.md
index 66edfa6..5f20e70 100644
--- a/README.md
+++ b/README.md
@@ -107,6 +107,8 @@ invincible-zebu-metrics-server   Deployment   extensions/v1beta1   apps/v1
 lunging-bat-metrics-server       Deployment   apps/v1                            false     false
 ```
 
+In case you have configured helm 2 with `--storage=secret`, you can add the optional `--helm-store secrets`. Default configuration for helm 2 is configmaps.
+
 If you only have access to a certain namespace (helm 3), or if you only want to see information for a single namespace, you can pass the `--namespace` or `-n` flag to restrict the output. Due to the way that helm2 stores configmaps, you will still need access to the tiller namespace if you are using helm 2.
 
 ```
diff --git a/cmd/root.go b/cmd/root.go
index 5016ef2..8040589 100644
--- a/cmd/root.go
+++ b/cmd/root.go
@@ -38,6 +38,7 @@ var (
 	outputFormat       string
 	showAll            bool
 	helmVersion        string
+	helmStore          string
 	ignoreDeprecations bool
 	ignoreRemovals     bool
 	targetVersion      string
@@ -58,6 +59,7 @@ func init() {
 	rootCmd.AddCommand(detectHelmCmd)
 	detectHelmCmd.PersistentFlags().StringVar(&helmVersion, "helm-version", "3", "Helm version in current cluster (2|3)")
 	detectHelmCmd.PersistentFlags().StringVarP(&namespace, "namespace", "n", "", "Only detect releases in a specific namespace.")
+	detectHelmCmd.PersistentFlags().StringVar(&helmStore, "helm-store", "configmaps", "Helm storage for v2 (configmaps|secrets)")
 
 	rootCmd.AddCommand(listVersionsCmd)
 	rootCmd.AddCommand(detectCmd)
@@ -135,7 +137,7 @@ var detectHelmCmd = &cobra.Command{
 	Short: "detect-helm",
 	Long:  `Detect Kubernetes apiVersions in a helm release (in cluster)`,
 	Run: func(cmd *cobra.Command, args []string) {
-		h := helm.NewHelm(helmVersion, namespace)
+		h := helm.NewHelm(helmVersion, helmStore, namespace)
 		err := h.FindVersions()
 		if err != nil {
 			fmt.Println("Error running helm-detect:", err)
@@ -158,6 +160,12 @@ var detectHelmCmd = &cobra.Command{
 		klog.V(5).Infof("retCode: %d", retCode)
 		os.Exit(retCode)
 	},
+	PreRun: func(cmd *cobra.Command, args []string) {
+		if helmStore != "secrets" && helmStore != "configmaps" && helmVersion == "2" {
+			fmt.Println("helm-store should be configmaps or secrets")
+			os.Exit(1)
+		}
+	},
 }
 
 var detectCmd = &cobra.Command{
diff --git a/pkg/helm/helm.go b/pkg/helm/helm.go
index e9ef9ef..53f96c8 100644
--- a/pkg/helm/helm.go
+++ b/pkg/helm/helm.go
@@ -33,6 +33,7 @@ type Helm struct {
 	Version   string
 	Kube      *kube
 	Namespace string
+	Store     string
 }
 
 // Release represents a single helm release
@@ -55,11 +56,12 @@ type ChartMeta struct {
 }
 
 // NewHelm returns a basic helm struct with the version of helm requested
-func NewHelm(version string, namespace string) *Helm {
+func NewHelm(version, store, namespace string) *Helm {
 	return &Helm{
 		Version:   version,
 		Kube:      getConfigInstance(),
 		Namespace: namespace,
+		Store:     store,
 	}
 }
 
@@ -78,13 +80,22 @@ func (h *Helm) FindVersions() error {
 	return err
 }
 
-// getReleasesVersionTwo retrieves helm 2 releases from ConfigMaps
+// getReleasesVersionTwo retrieves helm 2 releases from ConfigMaps or Secrets
 func (h *Helm) getReleasesVersionTwo() error {
+	var helmClient *helmstoragev2.Storage
 	if h.Version != "2" {
 		return fmt.Errorf("helm 2 function called without helm 2 version set")
 	}
-	hcm := driverv2.NewConfigMaps(h.Kube.Client.CoreV1().ConfigMaps(""))
-	helmClient := helmstoragev2.Init(hcm)
+	switch h.Store {
+	case "secrets":
+		hs := driverv2.NewSecrets(h.Kube.Client.CoreV1().Secrets(h.Namespace))
+		helmClient = helmstoragev2.Init(hs)
+	case "configmaps":
+		hcm := driverv2.NewConfigMaps(h.Kube.Client.CoreV1().ConfigMaps(""))
+		helmClient = helmstoragev2.Init(hcm)
+	default:
+		return fmt.Errorf("helm-store should be configmap or secrets")
+	}
 	list, err := helmClient.ListReleases()
 	if err != nil {
 		return err


Test patch:
diff --git a/e2e/tests/02_helm-detect-2.yaml b/e2e/tests/02_helm-detect-2.yaml
index ea1a53f..f62810a 100644
--- a/e2e/tests/02_helm-detect-2.yaml
+++ b/e2e/tests/02_helm-detect-2.yaml
@@ -1,7 +1,7 @@
 version: "2"
 name: "Static Code Files (including helm)"
 testcases:
-- name: install helm 2 configmaps
+- name: install helm 2 configmaps and secrets
   steps:
   - script: |
       kubectl create ns helm-system
@@ -34,6 +34,23 @@ testcases:
     - result.code ShouldEqual 0
     - result.systemout ShouldContainSubstring "NAME                                       NAMESPACE   KIND         VERSION   REPLACEMENT   DEPRECATED   DEPRECATED IN   REMOVED   REMOVED IN"
     - result.systemout ShouldContainSubstring "kindled-toucan/kindled-toucan-basic-demo   demo1       Deployment   apps/v1                 false                        false"
+
+- name: helm2 detect in-cluster show-all wide namespaced confimaps
+  steps:
+  - script: pluto detect-helm --helm-version=2 --helm-store configmaps -A -t v1.15.0 -owide -n demo1
+    assertions:
+    - result.code ShouldEqual 0
+    - result.systemout ShouldContainSubstring "NAME                                       NAMESPACE   KIND         VERSION   REPLACEMENT   DEPRECATED   DEPRECATED IN   REMOVED   REMOVED IN"
+    - result.systemout ShouldContainSubstring "kindled-toucan/kindled-toucan-basic-demo   demo1       Deployment   apps/v1                 false                        false"
+
+- name: helm2 detect show all wide namespaced secrets
+  steps:
+  - script: pluto detect-helm --helm-version=2 --helm-store secrets -A -t v1.16.0 -owide
+    assertions:
+    - result.code ShouldEqual 3
+    - result.systemout ShouldContainSubstring "NAME                                             NAMESPACE   KIND         VERSION              REPLACEMENT   DEPRECATED   DEPRECATED IN   REMOVED   REMOVED IN"
+    - result.systemout ShouldContainSubstring "invincible-zebu/invincible-zebu-metrics-server   default     Deployment   extensions/v1beta1   apps/v1       true         v1.9.0          true      v1.16.0"
+
 - name: cleanup
   steps:
   - script: |
diff --git a/e2e/tests/assets/helm2/helm2secrets-deprecated.yaml b/e2e/tests/assets/helm2/helm2secrets-deprecated.yaml
new file mode 100644
index 0000000..f97d4d7
--- /dev/null
+++ b/e2e/tests/assets/helm2/helm2secrets-deprecated.yaml
@@ -0,0 +1,17 @@
+apiVersion: v1
+data:
+  release: H4sIAAAAAAAC/+w8QYwkyVHa2xtjJzaY4bjH8Qn3nNnd8Vb1zt16dWq0iLnZtT3y7V5rZ72WtVrdZFdFd6cnq7IuM6tn+mYGgcwP/EBCFjz4IEvwQMICJB48LPjx4gEv3iAQFj9LfHigzKyqzqrq7umZ272bldnHbHdVZGREZGRkRGREk19k6YSlERtwDD7CQb7+n1fI31757JXOX115PEZIUEsWgUI5QQljqmCAmEKMGRdTjEMgZDcFCkM8hISluUYFU5GDGoucxzBAoAOOoAVwpnSBTkGuWDoCPUYYCs7FIUtHJBJJQtO4RwjAQT7ASHMYoYYgkPQQOl2aMdUtEIQH76iQie5ka4CabnVTEaPqkPXPf/aPfvTHP1374m9/7x9/+MobtW+bX9xNlaacQySSjKPGN/7p+1fI37xCfqFAGjgu1++Mtc5Ur9sdMT3OB2Ekkq4hSKaoUQUsjfIB1UJ26+PeuOC4zmfeCrduhVubOw8K6ew5aTMFFCKeK40yOGQxAh2NJI4MDhBDkKhELiOEXNERQkw1Dd9qMNPrkM8JjgmVB7la/xURHjI9/k2VCakljak0RPZ+jXz+ANMU9ZhSRdP11w9C+6EB9+iVydZ3126Fb4d31n98lfyyxiTjVKPqPnz/8f29UB/p9T+7uprWHB8DG0L4hPIcVUgzZnhmEYaRRKoRTk8vk14dHwNyZakyrPbgOyKHMZ0gxEwZQmI753Z/1/LMIgTLBxMpDIUEPWYKJHKkCkOYSUgRM+SQcQ6p0HAo5AGYBaoNgDzlqBz7kUiHbJRLtPOVXG/3d0k5r8i1Mqoihg7JN5AnEI2p1CE5Pg4A0xiC01Oy/udfIK/PVvCDMfIMpQp1xte//4Xj4+4mTFjSA4UahoyjnmZ4N8mVptEYe7DZPT0lBorcP8po6vhPaVJMjOWUBVwAMQ5ZitCpq2dohnQsQQUQzbmGcMeOfmjwlTpiIN+foJSGuxPQMk8juPO2/ciSvXw4ZEfQCWbISk4dmTtOr2g1xzDnfAof5pSzIcMYaJZZBkLybXTYLbw2cxhmjA5HNFcISiQI36w2tmN7yJDHCqhE4Cxh2qiEcEtwfTC1Irn3cM/AGg1VGUY3QrI7rBbZIolEqilLlZOee8a0U5CB2eeGTmMVDPEFtWdJ2IDWpextvPJlJdgSZiHASpI3e6X88qblond39cX16KwE4rCEj4o9ZAdXtNaenpvATLJUD6HzZRV8WXUa2Ny851G3RZ9rauitr9k8E5TK2Aqq3BoXCuOgOB0gP3udLXBnIVe+0N3nJ8WkJyAx4zRC6HylA50POh9nd5VmyLKmx1SXy67Mdvg09thZcisonrNPSuUsIRr7YJ4+LxNO00KWoqJRJPJUG1ZyhavSu+1GPVy0s+tg5bFqAAEAjo8r8q+zNOJ5vMxwhDcWoU19pstN1ZigU3zorIRkzs5Z/7s18tXZUVU6QRgHJcUSaYwyKH0lKTiGU5rw9d9Za4hFDmjkC+OApXEPdtzAR4IjoRkrdkYPLDTN9VhI9pE9zmcOAklQU+Nz9QjYde2BmiqNSe/4GEpqF5x3IZyeBh4fjn4Cbq+rnhUhzbIerIbLwlsDsHxEYSOqIcXhYwfV7V4BMEbJNB01IApfrcKyUEoVi4EWwYThYQ86WubYOc84jJm+yDgaJyytBsqcoxVsADRjX5ciz1QPnnbqjl/nWSEX51lbiEzEqnOz41xB936CcmDfjVB3bkLH+KDm/0Oqo3HnWV17/2SNfMnT3lyPgxi5c+ODSA6cpv7Pq2do6sp62VLpd1kaG0e4rbDLdMXb/nB62it0u05+gUhlNMKeda4DB/cyqrKxGo9waCguNWSJpE0w0bIdDUPQEJbKB9/FSBda6Ebv1UyhJfTspZl3BFSC8BakKQr7uGlp13/vM+RXZ/rZtqE/WXthmnkxG1rXzJdS1eYZIzs0gE6nYYLsV/PGGKLqizVH9W9dpan2npUrrjybVb0doa4+G/NVfbE2jJgTvL3omcrupy7etazOIR+PNKZGFxQpqeYsms7jyXGEUS6ZnlowVtBaAlqlrYAlmzCOI4yDc2lHjfXA+liOu7m+xo/XyJuz3eBwF6iD0hG02+IHa77eV9pdrPLHMrYvqyNgBGnTF03P2XHjO4dafIcmHEI4gZSlMaYabvtozHrYrzRNhbaGpJCGeVuObkzjwRaBSxO9iQkMmkxI7WlhIa4mPvOiJAogk0KLSPAePN7pF880lSPUfYvAZv8IgEKOkRbyYot3xkroaYZzaTUvDAhZ/9dXSaepwSqgGavr7183HY52Eq5p3GnGJI6Y0rJh2W2yrNgA2/3dxXugAA3rXtfLqO+lJhUy7a14dM+xTqsc2AAj54+0BDeZWSC3CgAstUYV9w5Y9vi9vSco2XDaM/E2loj6kgljdR+wlCV50oOtW7dmyMq37nHNPP5BzZmtMzdzZn/yaTizPxuew3N3Us8hr0vqwP7odXJ9oU66O4cEU+1U83uv+7o381YaVuxeNexn7iSfWTb/HEuMW/iex8v5uTmTOIkZZxFVtQOufFicf8VcBVHe0ph/vEbfRShcQYClE+KZt0zETjRON5v+yez1CRTeyDtNbJXDM9eRykS87Tk3FWDLO3JjJU1HCG8e4PQmvDkxKKB3t87m8bF9b0J7+9lBncCHudBYp6RFmvegVJa2SIozZIdTperia73qQcdb8HkjO2TO3I0ZWUJH2M8538NIovak1HzTFtXZOMqIyunFQnm05NU2dRc0jQ1ux0Lph6gPhTwI0Y/J7B6fvSzO/RZdxc0KSm+7NKbAIy3pTgXX1NjroDMO1xu63hh0A0K44Xnhy/V+JuS6VKrXxVrWFcY+MnZCKKaFtDrdeq3pqNKjhlb0bYRaMzpuTFa99Ek0situlMH7F0B3IdHmbRBEKHUQM3m3q5Os9ZaLkRZKxyjbI50/F5h45O47t2+/XQNoazGVI1Wn2KCp6+3CFagFR+XYSltcqNOiwS1aGQGV/zibYIpK9aUYYK81cUNzatDt+G3rrTqVEmnMVsdeB18FfSP/sgRzAXk20jLZYfYHHukzUTfgz55gInie4ANjOhor6FaoqXiJgexTPe5BQylbR5Dd2E88/PWZfep9Am+1wWoKl4oY92qexgJZ+IBtQXh2hQ6HLDXRyzJsJdBSTFpwlPXTdS4yD24pPrc6XhKuvSiYZHp6j8keHC90BryVUPWDaM4C3Jl3Uq3/7lVyc6HLXBxBxb2kc5v/+ZWV7xeXpcXKMOF8PvWScOGl865rkcv/rpH12TJkcRE+//ta27+8x5TMM6Nj7+bxCHV16DdF7vKtjXCm30ZQW4OXMN14gVBslciyCn9WWIKEpdsTyrgtRbMz+E9qDsVqw0vlmH07iwJ69K2UNmioPTubijko6nQ810DQ0//1/7paU3+VFbbm6tl3D6to/F5xejoXbo7NudiNQqkglHNxiPEOzeiAcaZZeaVzbfMaARgql51xCp+blXiUp9tqO50S8KauEnPSvP2WQrlgiML3WJofLXqbZxnHBFNNuX8j0wL0DqGSVBMu9HfvVZSY77v9ndr3ejhRjCkdxQDsVftWoSBHPbjz1a++fcePOtb/cM2/ZpSCYzBwuTy36j99zjnD53PzbQs1cj2elWj8zF9415KIVQItoBkr/AczGlPNIju8lNwlTR7+x6t+Qluj0u5vUOTCnXL+/atzvZq+iD9WejAwM72cx28r89QZI09CNe6OhTjo9MAKUeVRhEpVNrOedSgd4MPyMroI7ge5mg7EEfFjbXh6rTtgaVeNr7kaHBPkljd4QVR8uHZoK7s/fD+Ashj/+BhWqHBr5AwaN4DdSVUrOZKYQfA1WJBguGbTmEpTqcu0wkOcoCSk85evkb94zWwvQ/UG7GUYsSFDBYdj1GOU8Ojd7Z1Z3OmVujsjGBv52U+VEZ6diT0YUq6QkPruWDQVbWy9VSbbsIXrfgVjA4crYAwt6O7QVrQr1LbAtTDjTFlkN4EWtc0KRpia2Aljv3a/WJdKo8utRcjskrLJGnM0zb9hrJXmt3i1JFt03xE56GnGIsr5FA6p4WrMFBTO9pcMX1ORl2X/8yv+p2VzgBYWaUJTOrKF3M3ifFfgOxQSMByBNblmg3DIRAw010JFlFupOEzzGwTC5loR/8Bui6m+CzxxWLXFGFjqH/mQiBjrIjq0IyR+mDPbijCTkMFv+M8VAuUaZWrWXUxQcjqF1GE0HBmmMxErox4WbylKlJCnZXOH2f15ymyZsOW7sYNh2yAAPKJJxvGmI8VKxpLmMHskfRvNuhRkgEjh/jf3CJTEV5vI2SF3I1EkFXswiqRxMEZCjDh+MLNkzfCZJvGd2wRA01EPJrZdxmxVL9G4O3wodF+iwlQXk/nZaXj6jGxAAMVd+9Q9N/aZEGv1HAAWUrIsD2dap5APA8VGKcYQodRsaOWnboLCMkl37iYlsuEykQaUow7KO+ZAc0WIVy95fEpILadjn/iZFEM9qZI09vXs4meLkEYG2cFXVyhuQP0+xD7bAGufqr4f/4SCUU4lTTUiqGiMcc5LFYwkM44KBxrHgUitSoYGF8AeIiRCIlA9k9pMVEYXYhGprqbqQHVttSmzpXNFCV23mjQOZrMG5YwBjWORBmbCrpmwAEEZUp6NaVifqRqVibgH166ZEXPuUZwzGpgFqCYqJOqn7goNqg5g5TTP8e3nBFFHHsvdGpzx695PeVlZ4M+yfAL3pee+lF8d/dajrjxJQloZZLMOX8cic5o5IsdIuR5/RMrctZ+INlI1iL/x+HF/z9ZGMM0ov4ecmn0l0lj14K1bRgWb6eQXNtWcLLCNJftlTHjfmH2ruaVFAogaYSZALEXWg6cdyrktSy7X45EQ+muMY3G/XwsvCyd/69atW1vls4ciNUPmxKEFHPFqXGhj11W+q/uyAbAd22YwhcUbY8atXWofO4eQZ+aw2S/b8sriU5YOxb5D19gGBUBJ0awsvAXqFK/zoN5rScp1czcYrpyqqI7Y7VvD0syQuBP0TAMgcxMDWTtmxnarVr0giwfd9iHTSBa1Ezdk899eIT8fGreajVIhcf1fXtmAPtXmVLVidY+NU5fCIGfcxLqQ0eiAjtBascfmbFB5Zm90QI2RcxhxMXBJHJaObhofgmo2Qavh3nNzLG9AiiPn01zPJA7ZEcbuGP7SjRCMroFI7UhDEmQogbMUQ/L+tx/ef7RHwnt7H+xpIZFswI5IEpHCk509iJlUJBwx3bV/HRckHHwku/Zv+WA86po/5Vc1SbszRAMaHeSZbU1UZDNUhxnZDAf0gGyGOsnI5m+RDXhCJRO5gt179xUJMylMAEpCFiPtOjgpvks2f/ga+dyj+9v3HtwPk3j9B69tNG8fydN6Z+6z6xc7RG9cqKUXHpUPy35PKrHqE4tEkokUU62AswOc7SUtsn0oOzOffmPmW/ZFDNuFb+nzsrJmz/xUcxoFpZ+KN4xO2k/WUeWCxiqEx6LyZBEG1JCdZyI1csiVFknBlfVOHK19KRITpuQKtmOaaZTOUZ4rdrM9uva16g64GHQTag9fpc0m6mYVroA6XDdCQjaMGrntaVkipE8lTdBMdQL3UEWSWQtgv9nuJRIEAZxA9Zfse/mpfTgBF4jZ7Ejg2KznQeAE9o2x2i9GzmI3b7Tx+8vjochrlvvXjLeWY5/sz718MWh2h8UkN8uQi0KKh61esxktc3qxDKK9dnNa0YAaNmO7RdQwVdFyznDPkLdP9lsFqYYwr5luhVBvxueceglP7s1wxxd2s7zAytk886IDA3+u+KDCq+lohlDTkcFkg4a3KpBZ6DCDNM9KBTmBfT+iKMd5IUVjXOGNmYFPnxlBy5EF2XG5FmvEgcpRnli7UoJVXr6F7X+r+wATw3tltEzUZRNotjtThWbk8ek+2ffcfzP2Paa0sXbGTQUjJdcdWkAhXC/CN+V3gP7G3a3wzo2KGD/GMDgfGlyFx1HElkCVCYMMExUlZdxRDfEugh1EGYtYiDwZYGGYiyq0E9jf2if7LZfagG9bB21qeMmkmBjz7rLtzqd2TI7dLi/58L3mpTjmjq75x24JC7Wrii8MGlvwYOKZictYTWnCyX4VU9k1qZy1AZpgyPXW2gi9lEw96LLEeiHW0pHNSMUMNudQ+QIi88bAdzp2DXxnvM5X9W4xY3P6AeZQS+O4FKlnLiy99b6FxeLxfoShcmsXoDIm3Des1qRrAXiUCWXBb99+24M3nqmBfzzNbL6oxKtFadlPYL9yXN3qLLoj9uwmnXcV7Fu7sy4qDa6iahxmt4YsVZqmEapfL5zSuMjHSWv1UzF/2gXT1fxgOyE9shPm6XOYspFf2AcwuhHHZlmZAaXcy1NDudc2//QK+aWIdSMWeMq2/vtXNmBn1+ac8jQ1R5pI4evfvH8TDscsGgPlRmGnoMYsU630lXXQbcc72bA/7sFZpJVBYVRrdgBWNjZspkDLxJ8LKjpr5OrxKdn8768Yf4VswJ4d1ayn656n9uOCBR2N3xUKWsVxrUuPOeVzxeVGg0j3ezn1q4zGdI1rjMeMc5SryuQcHeYvpIG86TCs0ij+4oX3/63e81q9V1SptuK8iK7Zy7jnLn+v66pWYX7n/gvpZVq+kM+hGf8TWPdL1U5/5s6oCS+exfwXOENfqGZc5p3+3Ff8DC4vjwa0ypmeb7XSctovXKB0aVXikygx+gQswrzfDSDn/NWAy7jR53XlL+2tn7WLfIwm+jl8LSG7ebNzMVPe6B4lH7939DKu5/k6Pud2OS2Z0L/cv1AD54K2qqU8zvoS57fgrbD75/fIrdygdq50cM/ViSxtT6tVjVzOZrRPonOsdi3vTd2+oK/T1Z5k3qW9J/8F1/erdaBdJirnN7Kt3Jd2dm2Cp4ytKoXZP1uv0HgWGOy1Z2dUMXiAc+oZGm+blQ2N136Nw/NuoVvQ1rakR21p09nTZxdsITvnsdf8lZhP7edfPslDr/UDLhdzDT/F32h564evko0zggSNSq9f7Yv4jVsL1WBB+XvnH66eo/x9BToujdt6WYvWz8j/3L799pySdOdDLKpA37zyuXeuvPtzhbb+XwAAAP//9nkztvhfAAA=

+kind: Secret
+metadata:
+  creationTimestamp: "2020-04-02T21:24:40Z"
+  labels:
+    MODIFIED_AT: "1585862680"
+    NAME: invincible-zebu
+    OWNER: TILLER
+    STATUS: DEPLOYED
+    VERSION: "1"
+  name: invincible-zebu.v1
+  namespace: helm-system
+  resourceVersion: "265249"
+  selfLink: /api/v1/namespaces/helm-system/configmaps/invincible-zebu.v1
+  uid: 362f70c7-91dc-4478-88eb-08a7b368bfd0
diff --git a/pkg/helm/helm_test.go b/pkg/helm/helm_test.go
index b8d5b99..887446d 100644
--- a/pkg/helm/helm_test.go
+++ b/pkg/helm/helm_test.go
@@ -72,6 +72,21 @@ var (
 			"release": []byte("H4sIAAAAAAAC/+xbaZOiyLr+Kwb3fLg3oqoasKwujZgPQiniQpWoLDk1MUEmCGiyjCyKHf3fb2TigkttfebE+TIdYbRCkvmuz/u8SdYPJrQCh2kxnoOD1ElS5obxw3nEtH4wc3+VpH/aToyjwrGZFsOzPHvL3t+y/JT73uL5Vv3h7v7x/jv7HTA3DLa+Mtp2sJPScfRHglZ+nPpRyLQYOUxSC+MaioKYDGJumCS10ixhWsxh/hsmjFKHXOLuapKT1lLPqVlxjH1kkXlqM3VYg0VtlYWhH7rkduKQKQMrtJPWa1irOZs4WqW1l+enP5X2qPPbv/53mUEHpbjmOmktjuykdntLzJPEFnJqtjO3MpzWbnHtlbHi+I6MXoVO6iR3fvSNDPyNWBF51opY8uZyjE80C1E5jox5ZWq3UW2RRGFspd5vr8yPOz91guR39o+7wEkt20qtOzLzz1fm/6jMyItqr4zmJ35a89I0bn37xvHf79g79o5rPbKPbC2Nalni1IooW1UN8sqQ5/caXlOMWON2Hq3W1squ/WtvlhqZtPXIvobMzxuGKkeCYy8d+V4Job3yzA2TO6ukdCh7x92xF25u13oODmr0ido8WtUGB1sxN4wV+9phgpynV+LjFe6Oe6BzpkVM1q4oSsTEEVoyrTDD+IZJnSDGFo2V3w+yHi5+U56nnclduiEilwoxo8m9q/IaK/fUCEwED/WExNIVz5ZwDn1Bmy3XrhkuXRRqGQxwBgqBtSRtCybCAvJcauqNJdpGA6eepLKEA1ls6Ka+4YAxyiy9EaJA26KigWHQ9aGkLeUe1xTD9PtwIhSm3gjBpL20pObWFtsPL5N2pgXdxNa17ZCsVe9jVB9l9H5v5M4NdiCLwnenYF0UdDPAz9xhKHi25G3pvH7btXoqi3rp91KW8dX5bGlDx6M6GadlQBSa82mUD8lvUY1gXWGHgZej+tidG9x3p2hn+/lLPXfPjGMqC9AbVb0w7CmYri8pOQxVz9IbW1nsP0NexTOpWdii7A4x8GBPw6hobIHR5y1dwcNQbSBpttcTOz0hR+HYnS6bHVVrjqdcf/YyGUdWXfOBrrBQFEJgjN3hhMtMncOoLngmPyMyukPcx1DSPMTPsmnQTYGhrE1dwUROWeRyWYq3kG+sTUONXib978NQWQN9lCEiX0+Boy6bwaC5BBqRQW3KvnCQExXEB0IMAyWxdRXLYj8C+iY1ec9DoYpRfZyBUEug1PCgPvNl8Z7oFBP7AcNbw3qflTuNF7WjzSdau9kXvZWt97FZVxNZsrEtChmxFSra6VAnc2hbJHUXYCJQX8wCLQF6dwsmjeeq3nODdYf6o2uFxO4kLtymHCaZZagYGqVOqK56do/EQ3cJeiQeFIy4ZG1MGh6Q1AIYynY+kUtZdSWChRDZPXX97D/m/aPMD/vvs05zorX3cbAheREDn+RGgzV1nKGi7U+lpgc6fQ9K3czktUL2K3EeKhiFIDb5WWb38BpMSFxFriy2XWIjrTN7kDuYlSXOcyYCa+oplqWOCwKtLktcDEONBcbIBUGz2OXwCPLd5TjoJqbeWABDdida27WlR9cMZq5pAM/SN54ZbPDQ3a2z/3Rxbk+EhanfuzbfZU3edW3Jw3JPYU1D5VAh5MAXfGciFLbeoPkti/aZ777uM1QHC1nk6nKZt5nJbzggzVw58DCUuIUldQtb0ra22AhsfZNAEs8T2R36QnM+QSe5MmO1ibbET6rW7M+e2OVASjkz0Ba2tHYBxTmFN38hrkhOWXpjAXvaEkzaviVpCdSVyDT6LDAIXgAOShuah8S/ZZ6xqS1pKZI2nk30CdPv9NPrezCwsSx6MQxU7IjtSlxuclNXRVPfeDBQMPIbMQxsGpfyUzsm8zr1JCtxScAwIBjF+uQzIHEjaQtLeixx8CnKh4U6VbW+PpkpXYPF42eyfgWjEa8VdoAXYNIo8/JjHHuCPW1rS1ox0dr+G3OxjiHgPWYecr4rvKjd5vN4xnWv4RiSmstfy/m1KwfdNRIbNBZR0MAkXoYBzoc8xaDmx/47warENIT1MKCxU8CA5lhm6Y85sYFN87ic8wJnSf6S2PwAh6CusaauerbUyWg8n/lPxiBGPMl7j7V77Ydh8bgZLVA2Eu/Xw0Xn4fmpfT8SBRYWAocI5utNDvnn9VsmuXHMT5FN4UktoLEwAfoGm4aCh8sTuzfnE4H6baiDHIW2h4Kx26/4UH5y189PbSLL4LQuRr8xP2+uEJA/PQfHziq5S2N85CBOPckHvsBbOvsg9xSC/4GlbzDFwymX2obCmroSgWnkDvzmru4+/iUutXskdcmarCXN3BIXKEbR32U9GmeiH+WkppYyqhgQLvBuDHDH2i5pgWloiS22s/FuvtLPVa5C7fZiB1qBArwEE+FR7qkEIxfyk7mVe2vX7vVjqCkcCEDsiG1/SGLEqORaMC5/u3vdlALoXZZwslLmLgd7Y5fW1d7SRYbmQQkHlq4tZYnEvkCxZ+jGBpgILOFrJl8+b4ttflQIFEdRIZCc82yD+F/JoT5zJyQPjX4GDFJzy3lkCcRA3yxRIXgomLlQwimJX1DGHGtJeCuLHqkF1NZqpzGVab2nHHGLJG0xmNwPJrrpokPu7ueu4IlU2r98duZaxti1eZxAUfDBhMQ21W9Lax7R/aBn9NewfrDfEugghsEnasbR5jGo1uEKfk/rAKOwH5MadBz/8di5uLN7Qe1NY8DSuamtg8AyXFf22dPYonyhnR5iU1RL+zxFzarPh8vSRmV+zqrc8R15L3jIEu7i9hxLqzJdwbOvxzKpG5U5ERkfqoEsyhgVLEaFfGWdvXz/Ru589Psyt8o4EfdxSbGEB0Z/a+nNjMZdT9sCfUx7IMqFDvFKOJSWfCEOd2udyL5GAc5syXRlX9sOJ9qWcIdznNn/1gi+8LQve5QJdyUy8DNX9hNfFvtz2f9bcCeHOkfWSEy9j2FvNDhibomHlt64yvmh1PVJTMt+GdMUXyeNrSU2S92fok/wqJ19dxyKyPkBJ9zS+lVXc7QsfULjyz/2Z5ZuVnKou0Zdki9KDHla6wdv1Xp7b+9FKfebc4jCxtabbMndz3rCN3kJ58GgGwJ9nJrh8uGiFuNDX+Aeaxepr6Vtqf+KaDDjSS4rLKzL7t7+n653oUJycGFLzWJ65ru3bEJzdPoZP57wqcEn+NTDdT7yvv7jeh+bhop3vc8uj5vB7vehZ5Wl7sLkmxwMx7QXIvXvK3YqfaEJJq/ktt5gpx/VkyvPDIM97pQ60J6L9jxHrB98qf9ZXt1HGOvKAta1zBbL+nDB6Sk2l70f8WOF4/jH7/LX534Td397gw+WW5yBE6a3thOvHGSljn1XWEGFHZqGEGuVTASGxwK9QREaFU1+pPexLXU2YpDGMBg/yB2VIGPu6ByG4XhQYdoPpBv5fARfdnRDw9yYgcaa0w5h1nuEpPPud6ben/MEoR5lqUE7QBKVSrmjRJnTM+nMS4SPTb67ffbLLugYXYd7T6U3drsGvWNGP++6e6iTTt4bncpaRh6J2vd2cdABXfr758uMFgXS/S+B3mDlJ3O/Y8UCnVtDqcuCaVRGt8RhW+ouTUP1ng+7Ded2a+8jMf1FpD+x47N43EFBdQGb22hQ0bduGWp0ukvJeYDXxiSzZry2QIHGoqKyCyMKMdS7IdAEEg9ToCsFMNTtc3X3pJybhRz2oL5+V6azTmm/xmWGdSj6PXxiV+StZw/ou5cT8drCNvqx3cNPhBmSXHpXjyMCrCGvEt05FGDWmVEGj53e+CwW3JP1TL6Z2VI3hiR/934oP+mO8e9R/6lkRztGuts5OI4XtlfWfjgd8678249l7xRX1i19P43K3ZuLuJllKNDWsK7EJOccwgCmMc3VPWsbG8K6wtya84k8OJFZwqmp23jW0xLYFXIo4YWzw6eK/KUck8aaxqnUJF1+44q8tGM/szX9DHfV8dkvdzQvbHfmL7pT/RS5pLs/H0fWQUGThbySw6fI1TrK+EyOxDIAhoG2RZxQQL6Pn893G8VSDpXX2Mt7xJd05+RBFh+vrk/0vK6LQKrskrBUVFfGKGj6BzyqfOgOWcfG9lN0dX7TUKNnv51fsxPa2YbO0T6VHQXaFta1wuS17RWdaY2wpSYwdS452T2rPEeYO33bIhFsb29G/glWlHPwmLXEk12IHEja9ICRp8/QHfUKW7zE3p6a63o3hSKpdSfr35/EWe9Y3ass5hq2mqTz1Rux3Vue4sLx+i/KIZyybP8du4RqDiWtMA01hnxje6rL6b2/CdM/ZDsfUBxClim1GccrAk/PvtABhpDAOk4JVInBWVmVPl0qLjfQ6abjrpyelsp3qUGl2Tt3024Tmb5Qou6lECnhhWmM9nBfDfvy3qwkyXv3oItQFVLTUBdW50zWv5E6KHt79FQMDSEhjcWRRp3SyBK6L2X5FA283ni9F+5HWnhIEzu2JfeyRJzRlJNwPyk1CjbrfWxfo2G/nIJtSkGvNkufodzvNVr+GV36gA6c63GEAyEHVHetsAy1MaYlT7u3xbfTWxaPG2nA6J/BOnvSUpxv1lVhb2+fi7WvlKC35f9Y9tFUvlx35/tnv+2/QS0KYAg54jGh+5Ra7F4W7amZgHqCftgc63FN+ay8nVDpHUW5aF2CUo5hSON0DPlNbNaXV+xEXzxfKaEV6li+HLlWvqv+GpdUoX0/al+lGQWsq7nJN5NnX5iNubP5pE1sB1oGDGU76/VzM5hd0k4qh9ADxhVKSulCl7WeIne4vrp+jsLxdV16fWzqavxfo1GGkttGfwGM0VeodvW59yn2G7ShPHhwxMhTDDujOYtL7D3Sq/t325Nrrdgb2OqBAMSQ4M3kBBeO16e/KMcX6JQtNRNg9MuXe+HoRJeze38Ppr+5cZM4q9xHjoVQlH1IZ+xFZ2DxOANPkTvbvyOeHfbjfn2H5sNyEW9Pu/UjVNsSTgjzGxpqbvFaNpyClc1zK+bnHzdMbuHMSZjWD8aaz/3QTwum9ePnDTPPMCameM6d1cq3nfJEnx9YrkMGxxnGLxH2UcG0GHmuROnLykmcMGVumJUTR4mfRityL3T9cMP83D36kmE8cdDKSROm9fsfN4wfuisnKdcPwyilR72SUgQntCB2bKY1t3Di3DBelKTlaS/yjWmVp9ZunY0VxNi5wxGyiGdiK/Xo7ES9FJdfb5hLZcLIdiYOdlAarcoV48ieOChb+WkhRmHqbNLy+sqhx9BEEgBMiyMXkihbIWcnaXLtoV3cUGtFq5RpPbKHc20izpLUWckvzHFguwywq6ZAK8dKHaaVrjLnZheiYYbxzxsmjbCz2o+lmibIcwJrf05u7uPTM3J3noMD3w2jlXOMY7kQxqahssDoZ6ig7z1jwDdyFMxcm/cw9AXf1nECJPrOc23qyoqUNlTcD+RCmNF3pD2FQ7tSJvcUQqMTWbITyMv7nbkYBighUA9JmTAA3kH26X2pm4F2tJClBgZ8l6UlWPTWKNACy/AwEPdw0YmHvvACg01DlpoZmNBOluog9wSMfCEhnfHQjTK1q8xnBEKDGZH3CfJcCvl7V1sqU1lSYxSOBsPAjm3xsfxfwiEMmgUYR5kZxsVwXf5v6XYG630s+o0IFGSsF1aube3gPhf9kTvmmymk79X6nsmnHNq950fr6K9hqNRRO/prGPQ9i/5W0/J3s7B0NBiE1Ka6afRjWNe2cgd3VGM0GIakLMbYrI8HwwAvgd7JRT/KbIlbo6D5l+g3eMQrOZBmeQlnJBoCK/TnDs2X1/D29vY1/J/ahAZvq1Y92vntXcR7DY8nN1u1nHsNl35ot2qTk9h9DffnR+lJXBJw5SJkgdvqaq9hUsIAHXi7G5r6GDur2zRaOuHtw3IdLD8r8tu766eSO5vUCcnX5FvOQSe1Dpo8HWb4vBa3hzlqNWxBB5fq1Ojou8T7RgeeCn1Lj82Ww64fNz4d/9bI/aHjo2hvjcz3yr/uzteWZ4avDQ2s0HId+xYWrdqUOuM1TGIHUbV2KJi0alThZAedO5UDK0XesGqEr+j3eQ33Pt8vW3UV+YdPRfiaEF8x9MEu9MdJHijvBf7+gZOSUZH3x8/j9/03FIWp5YfOqqrYbe09Rd5b4nyZ6lLkH63VJF5o9W6dRk1lyMuBBbRqVRJQHUhqX3K29kHyNI1P71RUfYlI6jyy5wPiVZRGKMKt2lR8qd7Efu6ETpK8rCLonK1IVpKccxvUaoQstGrfLi7Ttc/FWzmW7f+HV9jxiivO+ioQXkE/K44J7v07kPcP1P0Ddf9A3T9Q9x+EuuofGXFlt0P/oon+nRj9mybm5/8HAAD//+BteWThNgAA"),
 		},
 	}
+	helmSecret2 = v1.Secret{
+		ObjectMeta: metav1.ObjectMeta{
+			Name: "sh.helm.release.v1.helmtest.v1",
+			Labels: map[string]string{
+				"MODIFIED_AT": "1585859667",
+				"NAME":        "helmtest",
+				"OWNER":       "TILLER",
+				"STATUS":      "DEPLOYED",
+				"VERSION":     "1",
+			},
+		},
+		Data: map[string][]byte{
+			"release": []byte("H4sIAAAAAAAC/+xaX28cSbVXstp7V3Wz9658ERKLkA5tr5KYdI8dULBaCpLXDsEicaw4m9VqtYpqus/MVFxd1VtVPfYwGZ4Qb0jwsALxCXjbJySekPgYSCBekBAPPMEHQKe6e6bnnz3OgnixH6zu6lPn/zm/+jPsrR7KzKF1a5+9wf58/a1rwZ+ub0fwEB24HgLPcykS7oRW8MHTR9AegCmUEqpLny1CorOMq9TGDADPcm0cHD3Zf3G4+/jB/Y1bJ0UbEyehiw5ynVoIQ8UztDlPEFLs8EI6CCUEPM8jIjYKHdpI6BbR3Sflkh43pOCdeRqhrOMqKemIJoBQw0urVc5d734wjITDzH689UmUoeMpdzwivqPgNqmb9DQEz4UVDnrO5XGrtX3329FWtBVtxztbO1vgNBQWYaAL0/REwABqyxYZRF4IO9qccpPCRu0OIJbxzhZbu/HWH377i3+8+c5vPvvpX669O/W2+c4B2SQlOTaX6PDdXz1k32E3mp4I3tyKtqOtza/uwvdQZuDHoaMNfH/snqfX+3df/td2tH0v2lr7/Q32/w6zXHKHtnX45NmD48idubXf3Xi9UA+HIYgORM+5LCgSqmvQ2ggVb0tMYTTyFIarLsJGT1sH8f05ahq3RAswoY4ocNUoxWQ4JEEbs3OdJBo7HAIqkhe3WsNhKcrzhdFoOIRowr0kY7OP0iLxT7RyXCgLwaFO8UgbF4zVtWj6IsHIDXIs+VVpfvhk/8GLoydPn83keTMjSImnKJFbjA7Ho6PRbJraHJOIuPpcVZUSowAq6ZY4CZXIIkUImrkQdQopSWDgzb09o9/B0Yx2xNu+lo7jUrKOu8JGPE0pFujHqpdGYVUVtVGpEW+M/bXE9Y80T9/nkurZnOd+AKAMjuHAQcYH4PgJAocOnkImVOHQ+lKglG6yhIMjquc2Au9zISlTo5Jb+feRLiDhCk65S3p+dmkn6E6zFG5eOtS2n0B4umoAb04CePzg6fODvQUx9BxXEb2iTAjDujtAMBwGw2FVjbeESvEM6ojLhjvrUoSt277YIl9xZW0FowV5MLEmJn1nwusNXlqVe7KwDs3B0QpluSr6LE/75XC01J8TX56HUrMiyVX/UcBa6oMLEKzRRtd+9H/syxNsedFDmaOxkcvl2l//dzhsbUJfZDFYdNAREile97PCOp70MIbNlg96a5M9OMu5Sn3hkYJUdvTsXRyxii4kjBVqsfvDCYmH4WjPz/WertOGKJ/00RiRIrwCZwqVwL1v+keRHRedjjiDIJwwIzPpuVRyzyAVCR/LoEIawKcFl6IjMCWne/Uj9iGW3D29IxmkroU2JpxiZHWGDbwuje4IlKkFbhCkyITDlELqesLCrfbAO2T/8JhoqRcRatyO2EEHTBnEksm4bsp1gR8TDk6FlNT+Ckt6WmqZhZSVtuf7d9Iuarc00L/+OHZrTbOUYCW/UxOoXza8DfH91UPb0HPsjpLLdAWOdZ0avbSCuRHKdSB4z4bv2WCGWyn3Msm27HkqCRvRpcLpo7G0dOO2jHCVLiWV5G2UF0XZPwRLbWq6vHx+Xol8BQZzSa0j+EYAwYvgdSpLZ5lWpaL2AkVLopITfYhsr+U/xssRrzIuKkFmCZFFiYnT5lElIIJGupc27+Z5bfZoxOabfRUGr8n8lFfwaaEdzixF57lkXPEupmF7EE816eMS9WChC48r7Vdz4qyt4UJFKL3O8eoE99hy3IthAfAtz+tZBKiQHniS6EK5CuMutM5P2i3nHC7rXdNkUVJqEFbrzOFw3HBuXbiOur2MqWoaXDeNGfZB9RCsxGRBZ1j7/G22MYHhFHOpBxkqF6aYGyQUSqMBz+Taj9/muXheZymeOVT0aFv97TY6vs1OhEpj2B9zYPVKhLb4F+TD9LoyrFlClZJxZXe4ZLoc190rULT2VA6+RWYT0tFk6jMi4bZMqcpV1eCezw7v2zq3S3kZregfNRQ4T4X5FjBR5V7JvXZzxb3hHfqTU4JeV9ROvdepLS8ZnQrXm2ykM97Fo0LKY0wM1ntp+pv9Mq2N0x/xTC4W1+hK5YT5Qjon/IuqLmrySgoj3GBPK4dnbrFWlXG5To+nyRepCzW6o2kYGU7StIla4znn6rJEH7tUme2705y982PaSE1HivJUW+G0GcBoFC/Eh9EomOVEYTzSUiSDqaQvWebjj9M6+KOEaZtqp9DGYepDw4dHmjB0Z2vme26004mWMTzbO2p8k6KPCq09MrqN09JIykOccSsA7XJiaM2OerEzihnkqfg3cre6MAnaCwM/plwS8rmyVDrFMRSPyZqjq5fjXEHOSeOdjlDCNeJfj7x20c/JcFqi8RvJRo9pDL6WpLWfvc2+sgixSpj6+40mTPE8J4D6F2LTFSZdYdIVJl1h0hUmXWHSBJM+v8a+NsGkqnVUG88Sl35yrYlLY0g6nuoyl4Glpf3JTvpkXSdOSIkmdPoEVXjv5DQ7CX55g/38xjrsVxvJvveOvwCZksLW4VlPWBAWOHy0+/hR2NEm485h6o9liWAfE8kNQp8bwdsSbXVfknNrMQWhnC5PlsceihhrAl0M24yVrabExaq1xKC6Qp0xgLzROA46h9odGbSE42wOHuDjT1jzSC+GIGCzR4l+kE27kGSvw3GOiegItHDaQ9dDA3zuJMH2dCFTMrHc+KcMqqcYnCnQM9pVSrsq0ZwGnlZHsnMHEwyAT2hjGI78/GcrHWdEnvagA0o7f1bOVVrpQjEjbe4Ar85yLXRRUaJjCoWtLmih9s04PHXuMTYPXGP1Ovah0UUew92trS1y5WKyhOe8LaRwomxP6wCQGp3XzyHsPnrkn6lHPlFy8FRr910h0Q6sw6zhUFOoXXuoFRHMDn9g0cSwXaniHUUS3CDHGMa3QKxuoDtbjFX3UP73B+X9cwwdLi0ujAdJmj2lKq+UE8mtnWTqPKGTNuQJlWFAShMo+ivsstOE/iUuz1tDPONZLjGSOuGSTZCgTGsAJ+undZpalnq5kJliEDppKw9PhK3X4LlIFpugSB27DxEKW3ApB2Aw0VlG3Y7yzGm/lBOdwfggaoIs/jJGg0Tex/IGwt8ZJFrZROiiVCvpacrl+r61sGiistFwaTV1PIPcor+KUAlWVxKWgg1aAaq+MFrRSt6W7V0K52SVELUqd8AWSY/EPxZKUFAiqpSBLiDVcMrVlCWNaYUqrS1/39DRUupTobqeuyQcvwM8fVlY/z0jAQoTtJabwR1vv8FM98sTyaQwcgBtw71vOg4N3Jy4+mZUMc3EJEZJXvhczqr3DDPfDLfv7jwWlYmfFmhXncGm8Jqiy5qAR/nExkBLnzf/dp39T0Q4ILpKG1z74/V1OKKmb8pmVg5Th1TQLoRMqZfkPDnhXWruFWbYIvdrN7A9lBK6UrfL/YtQ3TtgUHIn+ujzuzHOVcrWQWG3/EXJrdxgR5xhWsb567cjoC4BWvmZpBLkaHxcIhbtH784dtogW4fqZuD53jGkwlgWdYVr+f+l+ixq/8C0/P96oNdt0b/61fZVa8KozZOTIveoZ9lmZE9zthm1+QnbjFxGz9qILtv8IVuH59xQqsPB/gPLotzol5g4FokUeaskN/oli/o20Sm2WPAme4Pc/usvsTAM2Toc+/SIp6C4de76gr3e6qL+/VPYlLTaCmI1VZcfKLMvfpy8UPslh8cz9z1TM/yvojzVsouMKfcsJpzcWtRqLSEc3/QE5a+sgiV0zbucZ979C44Otlc5IVjZqpXtutyxwSXkX8Kzk9OExTv7xbl90e59svNcYVO+0ICL9uOjqdcFm22/lIibybFkCz21Er7aMH/hDfPosj1tvpFd4sBxWX5eda2rrnXVta661spda+fa+/9d7cP+GQAA//9E8AqZly8AAA=="),
+		},
+	}
 	wantOutput = []*api.Output{
 		{
 			Name:      "helmtest/helmtest-helmchartest-v1beta1",
@@ -111,11 +126,12 @@ var (
 	}
 )
 
-func newMockHelm(version string, namespace string) *Helm {
+func newMockHelm(version, store, namespace string) *Helm {
 	return &Helm{
 		Version:   version,
 		Namespace: namespace,
 		Kube:      getMockConfigInstance(),
+		Store:     store,
 	}
 }
 
@@ -165,10 +181,12 @@ func TestHelm_getManifestsVersionTwo(t *testing.T) {
 	tests := []struct {
 		name        string
 		helmVersion string
+		store       string
 		namespace   string
 		wantErr     bool
 		errMessage  string
 		configMap   *v1.ConfigMap
+		secret      *v1.Secret
 		want        []*api.Output
 	}{
 		{
@@ -178,15 +196,32 @@ func TestHelm_getManifestsVersionTwo(t *testing.T) {
 			errMessage:  "helm 2 function called without helm 2 version set",
 		},
 		{
-			name:        "helm 2 valid",
+			name:        "helm 2 valid configmap",
 			helmVersion: "2",
+			store:       "configmaps",
 			configMap:   &helmConfigMap,
 			want:        wantOutput,
 		},
+		{
+			name:        "helm 2 valid secret",
+			helmVersion: "2",
+			store:       "secrets",
+			secret:      &helmSecret2,
+			want:        wantOutput,
+		},
+		{
+			name:        "helm 2 bad store",
+			helmVersion: "2",
+			store:       "badstore",
+			secret:      &helmSecret2,
+			wantErr:     true,
+			errMessage:  "helm-store should be configmap or secrets",
+		},
 		{
 			name:        "helm 2 other namespace",
 			namespace:   "demo1",
 			helmVersion: "2",
+			store:       "configmaps",
 			configMap:   &helmConfigMap,
 			want:        nil,
 		},
@@ -194,18 +229,25 @@ func TestHelm_getManifestsVersionTwo(t *testing.T) {
 			name:        "helm 2 target namespace",
 			namespace:   "demo1",
 			helmVersion: "2",
+			store:       "configmaps",
 			configMap:   &helmConfigMap2,
 			want:        wantOutputNamespaced,
 		},
 	}
 	for _, tt := range tests {
-		h := newMockHelm(tt.helmVersion, tt.namespace)
+		h := newMockHelm(tt.helmVersion, tt.store, tt.namespace)
 		if tt.configMap != nil {
-			_, err := h.Kube.Client.CoreV1().ConfigMaps("kube-system").Create(tt.configMap)
+			_, err := h.Kube.Client.CoreV1().ConfigMaps(tt.namespace).Create(tt.configMap)
 			if err != nil {
 				t.Errorf("failed putting configMap in mocked kube. test: %s", tt.name)
 			}
 		}
+		if tt.secret != nil {
+			_, err := h.Kube.Client.CoreV1().Secrets(tt.namespace).Create(tt.secret)
+			if err != nil {
+				t.Errorf("failed putting secret in mocked kube. test: %s", tt.name)
+			}
+		}
 		t.Run(tt.name, func(t *testing.T) {
 			err := h.getReleasesVersionTwo()
 			if tt.wantErr {
@@ -242,7 +284,7 @@ func TestHelm_getManifestsVersionThree(t *testing.T) {
 	}
 
 	for _, tt := range tests {
-		h := newMockHelm(tt.helmVersion, "")
+		h := newMockHelm(tt.helmVersion, "secrets", "")
 		if tt.secret != nil {
 			_, err := h.Kube.Client.CoreV1().Secrets("default").Create(tt.secret)
 			if err != nil {
@@ -265,6 +307,7 @@ func TestHelm_getManifest_badClient(t *testing.T) {
 	tests := []struct {
 		name        string
 		helmVersion string
+		store       string
 		wantErr     bool
 		errMessage  string
 		secret      *v1.Secret
@@ -273,6 +316,7 @@ func TestHelm_getManifest_badClient(t *testing.T) {
 		{
 			name:        "two - bad client",
 			helmVersion: "2",
+			store:       "configmaps",
 			wantErr:     true,
 			errMessage:  "helm 3 function called without helm 3 version set",
 		},
@@ -287,6 +331,7 @@ func TestHelm_getManifest_badClient(t *testing.T) {
 	for _, tt := range tests {
 		h := &Helm{
 			Version: tt.helmVersion,
+			Store:   tt.store,
 			Kube:    newBadKubeClient(),
 		}
 		t.Run(tt.name, func(t *testing.T) {
@@ -318,7 +363,7 @@ func TestHelm_FindVersions(t *testing.T) {
 	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
-			h := newMockHelm(tt.helmVersion, "")
+			h := newMockHelm(tt.helmVersion, "", "secrets")
 			err := h.FindVersions()
 			if tt.wantErr {
 				assert.EqualError(t, err, tt.errMessage)