Repository: gojek/feast
Pull request #95 (2019-01-19 06:32:33)

add missing copyright headers and fix test fail due to previous merge
Add missing Copyright headers related to  #61 and PR #74 

feast-ci-bot: @tims: The following test **failed**, say `/retest` to rerun them all:

Test name | Commit | Details | Rerun command
--- | --- | --- | ---
presubmit-unit-tests | 1e27b8bb6c704c79378a0e2bc27b111a2b239d77 | [link]() | `/test presubmit-unit-tests`



<details>

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
</details>
<!-- test report -->
tims: Included a fix due to a merge fail with PR #90
zhilingc: Thanks. /approve
feast-ci-bot: @tims: you cannot LGTM your own PR.

<details>

In response to [this](https://github.com/gojek/feast/pull/95#issuecomment-455836304):

>/lgtm


Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
</details>
tims: /lgtm
pradithya: /approve
feast-ci-bot: [APPROVALNOTIFIER] This PR is **APPROVED**

This pull-request has been approved by: *<a href="https://github.com/gojek/feast/pull/95#issuecomment-455927251" title="Approved">pradithya</a>*

The full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands).

The pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)

<details >
Needs approval from an approver in each of these files:

- ~~[OWNERS](https://github.com/gojek/feast/blob/master/OWNERS)~~ [pradithya]

Approvers can indicate their approval by writing `/approve` in a comment
Approvers can cancel approval by writing `/approve cancel` in a comment
</details>
<!-- META={"approvers":[]} -->

Patch:
diff --git a/ingestion/src/main/java/feast/ingestion/transform/FeatureEnums.java b/ingestion/src/main/java/feast/ingestion/transform/FeatureEnums.java
deleted file mode 100644
index 77985082c..000000000
--- a/ingestion/src/main/java/feast/ingestion/transform/FeatureEnums.java
+++ /dev/null
@@ -1,15 +0,0 @@
-package feast.ingestion.transform;
-
-public class FeatureEnums {
-    public enum InputSource {
-        FILE,
-        BIGQUERY,
-        PUBSUB,
-        KAFKA
-    }
-
-    public enum FileFormat {
-        CSV,
-        JSON
-    }
-}
\ No newline at end of file
diff --git a/ingestion/src/main/java/feast/ingestion/util/JsonUtil.java b/ingestion/src/main/java/feast/ingestion/util/JsonUtil.java
index b142c013f..d32a79d1c 100644
--- a/ingestion/src/main/java/feast/ingestion/util/JsonUtil.java
+++ b/ingestion/src/main/java/feast/ingestion/util/JsonUtil.java
@@ -1,3 +1,20 @@
+/*
+ * Copyright 2019 The Feast Authors
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
 package feast.ingestion.util;
 
 import com.google.gson.Gson;
diff --git a/ingestion/src/main/java/feast/source/FeatureSource.java b/ingestion/src/main/java/feast/source/FeatureSource.java
index 4514b2de3..e4c0590b3 100644
--- a/ingestion/src/main/java/feast/source/FeatureSource.java
+++ b/ingestion/src/main/java/feast/source/FeatureSource.java
@@ -1,3 +1,20 @@
+/*
+ * Copyright 2019 The Feast Authors
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
 package feast.source;
 
 import feast.types.FeatureRowProto.FeatureRow;
diff --git a/ingestion/src/main/java/feast/source/FeatureSourceFactory.java b/ingestion/src/main/java/feast/source/FeatureSourceFactory.java
index 1de49cf34..fc4d64418 100644
--- a/ingestion/src/main/java/feast/source/FeatureSourceFactory.java
+++ b/ingestion/src/main/java/feast/source/FeatureSourceFactory.java
@@ -1,3 +1,20 @@
+/*
+ * Copyright 2019 The Feast Authors
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
 package feast.source;
 
 import feast.specs.ImportSpecProto.ImportSpec;
diff --git a/ingestion/src/main/java/feast/source/FeatureSourceFactoryService.java b/ingestion/src/main/java/feast/source/FeatureSourceFactoryService.java
index e4dd994dc..18917cb1d 100644
--- a/ingestion/src/main/java/feast/source/FeatureSourceFactoryService.java
+++ b/ingestion/src/main/java/feast/source/FeatureSourceFactoryService.java
@@ -1,3 +1,20 @@
+/*
+ * Copyright 2019 The Feast Authors
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
 package feast.source;
 
 import avro.shaded.com.google.common.collect.Lists;
diff --git a/ingestion/src/main/java/feast/source/bigquery/BigQueryFeatureSource.java b/ingestion/src/main/java/feast/source/bigquery/BigQueryFeatureSource.java
index b4b3973b5..9ce7f965f 100644
--- a/ingestion/src/main/java/feast/source/bigquery/BigQueryFeatureSource.java
+++ b/ingestion/src/main/java/feast/source/bigquery/BigQueryFeatureSource.java
@@ -1,3 +1,20 @@
+/*
+ * Copyright 2019 The Feast Authors
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
 package feast.source.bigquery;
 
 import static com.google.common.base.Preconditions.checkArgument;


Test patch:
diff --git a/ingestion/src/test/java/feast/ingestion/ImportJobCSVTest.java b/ingestion/src/test/java/feast/ingestion/ImportJobCSVTest.java
index 4a2fab2c6..c6adf7dd2 100644
--- a/ingestion/src/test/java/feast/ingestion/ImportJobCSVTest.java
+++ b/ingestion/src/test/java/feast/ingestion/ImportJobCSVTest.java
@@ -282,9 +282,8 @@ public class ImportJobCSVTest {
     ImportSpec importSpec =
         ProtoUtil.decodeProtoYaml(
             "---\n"
-                + "type: file\n"
+                + "type: file.csv\n"
                 + "options:\n"
-                + "  format: csv\n"
                 + "  # path: to be overwritten in tests\n"
                 + "entities:\n"
                 + "  - testEntity\n"
diff --git a/ingestion/src/test/java/feast/ingestion/model/SpecsTest.java b/ingestion/src/test/java/feast/ingestion/model/SpecsTest.java
index 17aceba18..d07073105 100644
--- a/ingestion/src/test/java/feast/ingestion/model/SpecsTest.java
+++ b/ingestion/src/test/java/feast/ingestion/model/SpecsTest.java
@@ -1,3 +1,20 @@
+/*
+ * Copyright 2019 The Feast Authors
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
 package feast.ingestion.model;
 
 import static junit.framework.TestCase.assertTrue;
diff --git a/ingestion/src/test/java/feast/ingestion/service/MockSpecService.java b/ingestion/src/test/java/feast/ingestion/service/MockSpecService.java
index 626545e11..54e70b39a 100644
--- a/ingestion/src/test/java/feast/ingestion/service/MockSpecService.java
+++ b/ingestion/src/test/java/feast/ingestion/service/MockSpecService.java
@@ -1,3 +1,20 @@
+/*
+ * Copyright 2019 The Feast Authors
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
 package feast.ingestion.service;
 
 import com.google.common.collect.Maps;
diff --git a/ingestion/src/test/java/feast/ingestion/transform/SplitOutputByStoreTest.java b/ingestion/src/test/java/feast/ingestion/transform/SplitOutputByStoreTest.java
index 09e8ef543..7758a7748 100644
--- a/ingestion/src/test/java/feast/ingestion/transform/SplitOutputByStoreTest.java
+++ b/ingestion/src/test/java/feast/ingestion/transform/SplitOutputByStoreTest.java
@@ -1,3 +1,20 @@
+/*
+ * Copyright 2019 The Feast Authors
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
 package feast.ingestion.transform;
 
 import static junit.framework.TestCase.assertNull;