nebius/SWE-rebench-V2-PRs huggingface dataset:
Repository: electron/electron-packager
Pull request #1041 (2019-08-17 21:00:41)

build: replace AppVeyor with CircleCI's Windows support
* [x] I have read the [contribution documentation](https://github.com/electron/electron-packager/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [code of conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project follows, as appropriate.

**Summarize your changes:**

Consolidate to one (faster) CI provider.

malept: Note that there are only 2 failing checks because it runs AppVeyor despite the config being gone.

Patch:
diff --git a/.circleci/config.yml b/.circleci/config.yml
index 3c01f5a..e293a93 100644
--- a/.circleci/config.yml
+++ b/.circleci/config.yml
@@ -39,7 +39,7 @@ step-save-brew-cache: &step-save-brew-cache
 step-before-install: &step-before-install
   run: test/ci/before_install.sh
 
-steps-linux: &steps-linux
+steps-linux-windows: &steps-linux-windows
   steps:
     - checkout
     - *step-env
@@ -65,24 +65,31 @@ steps-mac: &steps-mac
     - run: npm test
     - run: npm run codecov
 
-version: 2
+version: 2.1
+orbs:
+  win: circleci/windows@1.0.0
 jobs:
   test-linux-8:
     docker:
       - image: circleci/node:8
-    <<: *steps-linux
+    <<: *steps-linux-windows
   test-linux-10:
     docker:
       - image: circleci/node:10
-    <<: *steps-linux
+    <<: *steps-linux-windows
   test-linux-12:
     docker:
       - image: circleci/node:12
-    <<: *steps-linux
+    <<: *steps-linux-windows
   test-mac:
     macos:
       xcode: "10.2.0"
     <<: *steps-mac
+  test-windows:
+    executor:
+      name: win/vs2019
+      shell: bash.exe
+    <<: *steps-linux-windows
 
 workflows:
   version: 2
@@ -92,3 +99,4 @@ workflows:
       - test-linux-10
       - test-linux-12
       - test-mac
+      - test-windows


Test patch:
diff --git a/test/ci/appveyor.yml b/test/ci/appveyor.yml
deleted file mode 100644
index 715bd43..0000000
--- a/test/ci/appveyor.yml
+++ /dev/null
@@ -1,26 +0,0 @@
-platform:
-- x64
-environment:
-  matrix:
-  - nodejs_version: "8"
-  - nodejs_version: "10"
-cache:
-- 'node_modules'
-- '%USERPROFILE%\.electron'
-branches:
-  only:
-  - master
-
-install:
-- ps: Install-Product node $env:nodejs_version $env:platform
-- yarn
-- yarn upgrade
-
-test_script:
-- node --version
-- yarn --version
-- node test/ci/_before_script.js
-- yarn test
-- yarn codecov
-
-build: off
Repository: electron/electron-packager
Pull request #1043 (2019-08-20 05:48:09)

chore(deps-dev): upgrade eslint-config-standard to ^14
* [x] I have read the [contribution documentation](https://github.com/electron/electron-packager/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [code of conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project follows, as appropriate.
* [x] The testsuite passes successfully on my local machine (if applicable).

**Summarize your changes:**

Pre-emptive upgrade.


Patch:
diff --git a/package.json b/package.json
index 83ced16..206a1f2 100644
--- a/package.json
+++ b/package.json
@@ -48,7 +48,7 @@
     "buffer-equal": "^1.0.0",
     "codecov": "^3.0.0",
     "eslint": "^6.0.0",
-    "eslint-config-standard": "^13.0.0",
+    "eslint-config-standard": "^14.0.0",
     "eslint-plugin-ava": "^8.0.0",
     "eslint-plugin-import": "^2.2.0",
     "eslint-plugin-node": "^9.0.1",


Test patch:
diff --git a/test/infer.js b/test/infer.js
index 50a060d..d6ae441 100644
--- a/test/infer.js
+++ b/test/infer.js
@@ -46,7 +46,7 @@ async function inferMissingVersionTest (t, opts) {
 
   await getMetadataFromPackageJSON([], opts, opts.dir)
   const packageJSON = await fs.readJson(path.join(opts.dir, 'package.json'))
-  t.is(opts.electronVersion, packageJSON.devDependencies['electron'], 'The version should be inferred from installed electron module version')
+  t.is(opts.electronVersion, packageJSON.devDependencies.electron, 'The version should be inferred from installed electron module version')
 }
 
 async function testInferWin32metadata (t, opts, expected, assertionMessage) {
diff --git a/test/win32.js b/test/win32.js
index 6b41f95..0fe8a53 100644
--- a/test/win32.js
+++ b/test/win32.js
@@ -131,7 +131,7 @@ function setCompanyNameTest (companyName) {
   return generateVersionStringTest('version-string',
                                    opts,
                                    { CompanyName: companyName },
-                                   `Company name should match win32metadata value`)
+                                   'Company name should match win32metadata value')
 }
 
 test('better error message when wine is not found', (t) => {
Repository: electron/electron-packager
Pull request #1087 (2019-11-25 23:05:01)

fix: emit a warning if --osx-sign and a sub-property are specified in the CLI
* [x] I have read the [contribution documentation](https://github.com/electron/electron-packager/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [code of conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project follows, as appropriate.
* [x] The changes are appropriately documented (if applicable).
* [x] The changes have sufficient test coverage (if applicable).
* [x] The testsuite passes successfully on my local machine (if applicable).

**Summarize your changes:**

Avoids issues like #1086.


Patch:
diff --git a/src/cli.js b/src/cli.js
index bff20d9..60f6ab4 100644
--- a/src/cli.js
+++ b/src/cli.js
@@ -68,9 +68,13 @@ module.exports = {
     if (args.osxSign === 'true') {
       warning('--osx-sign does not take any arguments, it only has sub-properties (see --help)')
       args.osxSign = true
-    } else if (typeof args.osxSign === 'object' && !Array.isArray(args.osxSign)) {
-      // Keep kebab case of sub properties
-      args.osxSign = args['osx-sign']
+    } else if (typeof args['osx-sign'] === 'object') {
+      if (Array.isArray(args['osx-sign'])) {
+        warning('Remove --osx-sign (the bare flag) from the command line, only specify sub-properties (see --help)')
+      } else {
+        // Keep kebab case of sub properties
+        args.osxSign = args['osx-sign']
+      }
     }
 
     if (args.osxNotarize) {


Test patch:
diff --git a/test/cli.js b/test/cli.js
index 891e030..384feaf 100644
--- a/test/cli.js
+++ b/test/cli.js
@@ -2,6 +2,7 @@
 
 const cli = require('../src/cli')
 const test = require('ava')
+const util = require('./_util')
 
 test('CLI argument: --electron-version populates opts.electronVersion', t => {
   let args = cli.parseArgs([])
@@ -37,6 +38,12 @@ test('CLI argument: --osx-sign=true', t => {
   t.true(args.osxSign)
 })
 
+test('CLI argument: --osx-sign and --osx-sign subproperties should not be mixed', t => {
+  util.setupConsoleWarnSpy()
+  cli.parseArgs(['--osx-sign', '--osx-sign.identity=identity'])
+  util.assertWarning(t, 'WARNING: Remove --osx-sign (the bare flag) from the command line, only specify sub-properties (see --help)')
+})
+
 test('CLI argument: --osx-sign is object', t => {
   const args = cli.parseArgs([
     '--osx-sign.identity=identity',