Repository: numaproj/numaflow
Pull request #1800 (2024-07-05 23:05:30)

chore: update sarama to fix broker panic


<!--

Before you push your changes:

* Run `make pre-push -B` to fix codegen and lint problems.

Then, you MUST:

* Sign-off your commit (otherwise the DCO check will fail).
* Use [a conventional commit message](https://www.conventionalcommits.org/en/v1.0.0/) (otherwise the commit message check will fail).

If you did not do this, reset all your commit and replace them with a single commit:

```
git reset HEAD~1 ;# change 1 to how many commits you made
git commit --signoff -m 'feat: my feat. Fixes #1234'
```

When creating your PR: 

* Make sure that "Fixes #" or "Closes #" is in both the PR title (for release notes) and description (to automatically link and close the issue).
* Say how you tested your changes. If you changed the UI, attach screenshots.
* Set your PR as a draft initially.
* Your PR needs to pass the required checks before it can be approved. 
* Once required tests have passed, mark your PR "Ready for review".

If changes were requested, once you've made them, you MUST dismiss the review to get it reviewed again.

-->


codecov[bot]: ## [Codecov](https://app.codecov.io/gh/numaproj/numaflow/pull/1800?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=numaproj) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 47.88%. Comparing base [(`b9d2c97`)](https://app.codecov.io/gh/numaproj/numaflow/commit/b9d2c9751648647118914b3f89eab1b4bf6435c5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=numaproj) to head [(`c2775e1`)](https://app.codecov.io/gh/numaproj/numaflow/commit/c2775e185877740a0306d4d9a060847b46114c3a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=numaproj).

<details><summary>Additional details and impacted files</summary>


```diff
@@            Coverage Diff             @@
##             main    #1800      +/-   ##
==========================================
- Coverage   50.89%   47.88%   -3.02%     
==========================================
  Files         276       14     -262     
  Lines       26935     7109   -19826     
==========================================
- Hits        13709     3404   -10305     
+ Misses      12415     3705    -8710     
+ Partials      811        0     -811     
```

</details>

[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/numaproj/numaflow/pull/1800?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=numaproj).   
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=numaproj).


Patch:
diff --git a/go.mod b/go.mod
index 18df5d13..11c55b60 100644
--- a/go.mod
+++ b/go.mod
@@ -3,7 +3,7 @@ module github.com/numaproj/numaflow
 go 1.22
 
 require (
-	github.com/IBM/sarama v1.43.0
+	github.com/IBM/sarama v1.43.2
 	github.com/Masterminds/semver/v3 v3.2.1
 	github.com/Masterminds/sprig/v3 v3.2.3
 	github.com/ahmetb/gen-crd-api-reference-docs v0.3.0
diff --git a/go.sum b/go.sum
index 7e1ed54e..cfe9a580 100644
--- a/go.sum
+++ b/go.sum
@@ -46,8 +46,8 @@ github.com/Azure/go-autorest/tracing v0.6.0/go.mod h1:+vhtPC754Xsa23ID7GlGsrdKBp
 github.com/BurntSushi/toml v0.3.1/go.mod h1:xHWCNGjB5oqiDr8zfno3MHue2Ht5sIBksp03qcyfWMU=
 github.com/BurntSushi/xgb v0.0.0-20160522181843-27f122750802/go.mod h1:IVnqGOEym/WlBOVXweHU+Q+/VP0lqqI8lqeDx9IjBqo=
 github.com/DATA-DOG/go-sqlmock v1.3.3/go.mod h1:f/Ixk793poVmq4qj/V1dPUg2JEAKC73Q5eFN3EC/SaM=
-github.com/IBM/sarama v1.43.0 h1:YFFDn8mMI2QL0wOrG0J2sFoVIAFl7hS9JQi2YZsXtJc=
-github.com/IBM/sarama v1.43.0/go.mod h1:zlE6HEbC/SMQ9mhEYaF7nNLYOUyrs0obySKCckWP9BM=
+github.com/IBM/sarama v1.43.2 h1:HABeEqRUh32z8yzY2hGB/j8mHSzC/HA9zlEjqFNCzSw=
+github.com/IBM/sarama v1.43.2/go.mod h1:Kyo4WkF24Z+1nz7xeVUFWIuKVV8RS3wM8mkvPKMdXFQ=
 github.com/Knetic/govaluate v3.0.1-0.20171022003610-9aa49832a739+incompatible h1:1G1pk05UrOh0NlF1oeaaix1x8XzrfjIDK47TY0Zehcw=
 github.com/Knetic/govaluate v3.0.1-0.20171022003610-9aa49832a739+incompatible/go.mod h1:r7JcOSlj0wfOMncg0iLm8Leh48TZaKVeNIfJntJ2wa0=
 github.com/Masterminds/goutils v1.1.1 h1:5nUrii3FMTL5diU80unEVvNevw1nH4+ZV4DSLVJLSYI=


Test patch:
diff --git a/pkg/shared/util/saramaconfig_test.go b/pkg/shared/util/saramaconfig_test.go
index 803d4004..60be8d18 100644
--- a/pkg/shared/util/saramaconfig_test.go
+++ b/pkg/shared/util/saramaconfig_test.go
@@ -50,7 +50,7 @@ net:
 	t.Run("Empty config", func(t *testing.T) {
 		conf, err := GetSaramaConfigFromYAMLString("")
 		assert.NoError(t, err)
-		assert.Equal(t, 1000000, conf.Producer.MaxMessageBytes)
+		assert.Equal(t, 1048576, conf.Producer.MaxMessageBytes)
 		assert.Equal(t, 5, conf.Admin.Retry.Max)
 		assert.Equal(t, int32(1), conf.Consumer.Fetch.Min)
 		assert.Equal(t, 5, conf.Net.MaxOpenRequests)