Repository: GoogleChrome/lighthouse
Pull request #9086 (2019-05-30 21:55:07)

5.1.0

patrickhulce: fixtures need some love though
Hoten: > LGTM!
> 
> I'm curious @Hoten are you using the scripts at all? Are they helpful? How can they be more helpful?

`./lighthouse-core/scripts/release/test.sh`

I ended up commenting out the smoke parts because it kept flaking. Would be good to prompt "Smokes failed, was it a flake? Try again? Continue?" etc.

Maybe skip the first test run if it's just going to run the tests again via the npm package.

```
echo "${TXT_DIM}Press any key to see the git diff, CTRL+C to exit...${TXT_RESET}"
read -n 1 -r unused_variable
git --no-pager diff HEAD^
```

I was confused on this part, because I think you can't page up/down to see the whole diff.
brendankenny: all good?

Patch:
diff --git a/changelog.md b/changelog.md
index 8f25acad8..54bb0c440 100644
--- a/changelog.md
+++ b/changelog.md
@@ -1,3 +1,76 @@
+<a name="5.1.0"></a>
+# 5.1.0 (2019-05-30)
+[Full Changelog](https://github.com/googlechrome/lighthouse/compare/v5.0.0...v5.1.0)
+
+## New contributors!
+
+Thanks to our new contributors 👽🐷🐰🐯🐻! 
+@thebengeu
+@boyney123
+
+## Core
+
+* gather-runner: treat NO_FCP as a pageLoadError ([#8340](https://github.com/googlechrome/lighthouse/pull/8340))
+* logging: change log messages for gathering and trace retrieval ([#9029](https://github.com/googlechrome/lighthouse/pull/9029))
+* tap-targets: don't exclude visible position absolute elements from audit ([#7778](https://github.com/googlechrome/lighthouse/pull/7778))
+* budget: throw error on duplicate budget types ([#8915](https://github.com/googlechrome/lighthouse/pull/8915))
+* config: split out config helpers ([#9003](https://github.com/googlechrome/lighthouse/pull/9003))
+* gather-runner: always reset scroll position (reverted) ([#8625](https://github.com/googlechrome/lighthouse/pull/8625))
+* image-elements: drop spritesheet logic ([#8940](https://github.com/googlechrome/lighthouse/pull/8940))
+* refactor gather-runner control flow ([#8964](https://github.com/googlechrome/lighthouse/pull/8964))
+* perf: speed up getNodePath ([#9055](https://github.com/googlechrome/lighthouse/pull/9055))
+* performance-budget: add MP-FID as budget metric ([#8905](https://github.com/googlechrome/lighthouse/pull/8905))
+* runner: fix missing timing properties in the browser ([#9072](https://github.com/googlechrome/lighthouse/pull/9072))
+
+## Report
+
+* two rows for filmstrip on mobile ([#8563](https://github.com/googlechrome/lighthouse/pull/8563))
+* move gauge styles to main stylesheet ([#8893](https://github.com/googlechrome/lighthouse/pull/8893))
+* show metric descriptions by default when errors exist ([#9054](https://github.com/googlechrome/lighthouse/pull/9054))
+* show fireworks only if all core categories score 100 ([#9073](https://github.com/googlechrome/lighthouse/pull/9073))
+* make gauge font size and positioning dynamic ([#9057](https://github.com/googlechrome/lighthouse/pull/9057))
+* hide 3rd party filter checkbox if all rows are 3rd party ([#8966](https://github.com/googlechrome/lighthouse/pull/8966))
+* fix word breaking of display text, move metric disclaimer ([#9030](https://github.com/googlechrome/lighthouse/pull/9030))
+* show nodeLabel for DOM nodes in addition to snippet ([#8961](https://github.com/googlechrome/lighthouse/pull/8961))
+
+## Clients
+
+* devtools: move topbar out of scrollable container ([#9077](https://github.com/googlechrome/lighthouse/pull/9077))
+* devtools: enable sticky header, top bar, and report ui features ([#9023](https://github.com/googlechrome/lighthouse/pull/9023))
+* devtools: ignore dark mode media query ([#9082](https://github.com/googlechrome/lighthouse/pull/9082))
+* devtools: update version in tests on lh roll ([#8819](https://github.com/googlechrome/lighthouse/pull/8819))
+* lr: insert assets in lhr for logging purposes ([#9002](https://github.com/googlechrome/lighthouse/pull/9002))
+
+## CLI
+
+* flags: accept comma-separated array values ([#8933](https://github.com/googlechrome/lighthouse/pull/8933))
+
+## Docs
+
+* plugins: add link to field-performance plugin ([#9051](https://github.com/googlechrome/lighthouse/pull/9051))
+* plugins: rename Google AdSpeed Insights to Publisher Ads Audit ([#8906](https://github.com/googlechrome/lighthouse/pull/8906))
+* add lighthouse-plugin-field-performance to plugins ([#9049](https://github.com/googlechrome/lighthouse/pull/9049))
+* add performance-budgets to related projects ([#8971](https://github.com/googlechrome/lighthouse/pull/8971))
+
+## I18n
+
+* minor fr and ta translation updates ([#8999](https://github.com/googlechrome/lighthouse/pull/8999))
+
+## Misc
+
+* assets: remove outdated extension screenshots ([#9015](https://github.com/googlechrome/lighthouse/pull/9015))
+* dot-js require() everywhere ([#9006](https://github.com/googlechrome/lighthouse/pull/9006))
+* remove unneeded reportCategories from LH.ReportResult ([#9001](https://github.com/googlechrome/lighthouse/pull/9001))
+* update minify-trace scripts; extract to lib/ ([#8968](https://github.com/googlechrome/lighthouse/pull/8968))
+* fix master: tmp revert of scroll change in #8625 ([#9059](https://github.com/googlechrome/lighthouse/pull/9059))
+
+## Tests
+
+* lint: require file extension in require() ([#9017](https://github.com/googlechrome/lighthouse/pull/9017))
+* update a11y sample artifacts ([#9010](https://github.com/googlechrome/lighthouse/pull/9010))
+* remove compile-devtools on travis ([#8988](https://github.com/googlechrome/lighthouse/pull/8988))
+* smoke: re-enable dialog prompt ([#8894](https://github.com/googlechrome/lighthouse/pull/8894))
+
  <a name="5.0.0"></a>
 # 5.0.0 (2019-05-07)
 [Full Changelog](https://github.com/googlechrome/lighthouse/compare/v4.3.0...v5.0.0)
diff --git a/clients/extension/manifest.json b/clients/extension/manifest.json
index 6957976df..ee2d8d504 100644
--- a/clients/extension/manifest.json
+++ b/clients/extension/manifest.json
@@ -1,6 +1,6 @@
 {
   "name": "__MSG_appName__",
-  "version": "5.0.0",
+  "version": "5.1.0",
   "minimum_chrome_version": "72",
   "manifest_version": 2,
   "description": "__MSG_appDescription__",
diff --git a/package.json b/package.json
index a1ad87657..3fa91f007 100644
--- a/package.json
+++ b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "lighthouse",
-  "version": "5.0.0",
+  "version": "5.1.0",
   "description": "Lighthouse",
   "main": "./lighthouse-core/index.js",
   "bin": {
diff --git a/proto/sample_v2_round_trip.json b/proto/sample_v2_round_trip.json
index 36cf5bd0c..f0f16a4de 100644
--- a/proto/sample_v2_round_trip.json
+++ b/proto/sample_v2_round_trip.json
@@ -3916,7 +3916,7 @@
             "warningHeader": "Warnings: "
         }
     },
-    "lighthouseVersion": "5.0.0",
+    "lighthouseVersion": "5.1.0",
     "requestedUrl": "http://localhost:10200/dobetterweb/dbw_tester.html",
     "runWarnings": [],
     "stackPacks": [


Test patch:
diff --git a/lighthouse-core/test/results/sample_v2.json b/lighthouse-core/test/results/sample_v2.json
index c8a46b36f..76532a9e9 100644
--- a/lighthouse-core/test/results/sample_v2.json
+++ b/lighthouse-core/test/results/sample_v2.json
@@ -5,7 +5,7 @@
     "hostUserAgent": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3358.0 Safari/537.36",
     "benchmarkIndex": 1000
   },
-  "lighthouseVersion": "5.0.0",
+  "lighthouseVersion": "5.1.0",
   "fetchTime": "2018-03-13T00:55:45.840Z",
   "requestedUrl": "http://localhost:10200/dobetterweb/dbw_tester.html",
   "finalUrl": "http://localhost:10200/dobetterweb/dbw_tester.html",