Repository: primefaces/primefaces
Pull request #13437 (2025-02-26 18:05:27)

Slf4J version in one spot


Patch:
diff --git a/pom.xml b/pom.xml
index bff8269a8b..716fde532f 100644
--- a/pom.xml
+++ b/pom.xml
@@ -75,6 +75,7 @@
         <poi.version>5.4.0</poi.version>
         <jacoco.version>0.8.12</jacoco.version>
         <tomcat.version>10.1.34</tomcat.version>
+        <slf4j.version>2.0.17</slf4j.version>
 
         <sonar.skip>true</sonar.skip>
         <sonar.coverage.jacoco.xmlReportPaths>../primefaces-coverage/target/site/jacoco-aggregate/jacoco.xml</sonar.coverage.jacoco.xmlReportPaths>
@@ -188,7 +189,7 @@
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-deploy-plugin</artifactId>
-                <version>3.1.3</version>
+                <version>3.1.4</version>
             </plugin>
 
             <plugin>
diff --git a/primefaces-showcase/pom.xml b/primefaces-showcase/pom.xml
index 5c6b3328be..a67c1ffda6 100644
--- a/primefaces-showcase/pom.xml
+++ b/primefaces-showcase/pom.xml
@@ -118,7 +118,7 @@
         <dependency>
             <groupId>org.slf4j</groupId>
             <artifactId>slf4j-simple</artifactId>
-            <version>2.0.17</version>
+            <version>${slf4j.version}</version>
         </dependency>
 
         <!-- GraphicImage -->
diff --git a/primefaces/pom.xml b/primefaces/pom.xml
index df568eecf7..4241da3528 100644
--- a/primefaces/pom.xml
+++ b/primefaces/pom.xml
@@ -195,7 +195,7 @@
         <dependency>
             <groupId>org.slf4j</groupId>
             <artifactId>slf4j-nop</artifactId>
-            <version>2.0.17</version>
+            <version>${slf4j.version}</version>
             <scope>test</scope>
         </dependency>
 
diff --git a/primefaces/src/main/frontend/packages/components/src/datatable/datatable.widget.js b/primefaces/src/main/frontend/packages/components/src/datatable/datatable.widget.js
index 3fc3fe8ca3..62a99e4e61 100644
--- a/primefaces/src/main/frontend/packages/components/src/datatable/datatable.widget.js
+++ b/primefaces/src/main/frontend/packages/components/src/datatable/datatable.widget.js
@@ -1123,7 +1123,7 @@ PrimeFaces.widget.DataTable = class DataTable extends PrimeFaces.widget.Deferred
                             $this.unhighlightFocusedRow();
 
                             if($this.isCheckboxSelectionEnabled()) {
-                                row.find('> td.ui-selection-column .ui-chkbox input').trigger('focus');
+                                row.find('> td.ui-selection-column .ui-chkbox-box').trigger('focus');
                             }
                             else {
                                 $this.focusedRow = row;
@@ -3602,8 +3602,8 @@ PrimeFaces.widget.DataTable = class DataTable extends PrimeFaces.widget.Deferred
                         });
 
             // GitHub #433 Allow ENTER to submit ESC to cancel row editor
-            $(document).off("keydown" + namespace, "tr.ui-row-editing")
-                        .on("keydown" + namespace, "tr.ui-row-editing", function(e) {
+            $(document).off("keydown" + namespace, $this.jqId + " tr.ui-row-editing")
+                        .on("keydown" + namespace, $this.jqId + " tr.ui-row-editing", function(e) {
                             switch (e.key) {
                                 case 'Enter':
                                     var target = $(e.target);
diff --git a/primefaces/src/main/frontend/packages/core/src/core/core.widget.js b/primefaces/src/main/frontend/packages/core/src/core/core.widget.js
index c97f054414..dc4d5f3d6c 100644
--- a/primefaces/src/main/frontend/packages/core/src/core/core.widget.js
+++ b/primefaces/src/main/frontend/packages/core/src/core/core.widget.js
@@ -419,13 +419,14 @@ if (!PrimeFaces.widget) {
          * @param {string} event The name of an event to call.
          * @param {Partial<PrimeFaces.ajax.ConfigurationExtender>} [ext] Additional configuration that is passed to the
          * AJAX request for the server-side callback.
+         * @param {boolean} [fallbackToDomEvent=true] Whether to fallback to the DOM event if no behavior is defined.
          * @since 7.0
          */
-        callBehavior(event, ext) {
+        callBehavior(event, ext, fallbackToDomEvent = true) {
             if(this.hasBehavior(event)) {
                 this.cfg.behaviors[event].call(this, ext);
             }
-            else if (this.cfg.behaviors === undefined && this.jq.length > 0) {
+            else if (fallbackToDomEvent && this.cfg.behaviors === undefined && this.jq.length > 0) {
                 // #12887 if no behavior is defined, try to call the DOM event
                 this.jq.trigger(event, ext);
             }
diff --git a/primefaces/src/main/frontend/packages/idlemonitor/idlemonitor/src/idlemonitor.widget.js b/primefaces/src/main/frontend/packages/idlemonitor/idlemonitor/src/idlemonitor.widget.js
index 006f1d69df..cae0236fe4 100644
--- a/primefaces/src/main/frontend/packages/idlemonitor/idlemonitor/src/idlemonitor.widget.js
+++ b/primefaces/src/main/frontend/packages/idlemonitor/idlemonitor/src/idlemonitor.widget.js
@@ -44,14 +44,14 @@ PrimeFaces.widget.IdleMonitor = class IdleMonitor extends PrimeFaces.widget.Base
                 $this.cfg.onidle.call($this);
             }
 
-            $this.callBehavior('idle');
+            $this.callBehavior('idle', undefined, false);
         })
         .on("active.idleTimer" + this.cfg.id, function(){
             if($this.cfg.onactive) {
                 $this.cfg.onactive.call($this);
             }
 
-            $this.callBehavior('active');
+            $this.callBehavior('active', undefined, false);
         });
 
         $.idleTimer(this.cfg.timeout, document, this.cfg.id);


Test patch:
diff --git a/primefaces-integration-tests/pom.xml b/primefaces-integration-tests/pom.xml
index 84c37417f3..81952ccf55 100644
--- a/primefaces-integration-tests/pom.xml
+++ b/primefaces-integration-tests/pom.xml
@@ -179,7 +179,7 @@
         <dependency>
             <groupId>org.slf4j</groupId>
             <artifactId>slf4j-api</artifactId>
-            <version>2.0.17</version>
+            <version>${slf4j.version}</version>
             <scope>test</scope>
         </dependency>