Repository: googleapis/java-storage
Pull request #210 (2020-03-27 17:55:05)

deps: update conformance test dep
Updates conformance test dependency

codecov[bot]: # [Codecov](https://codecov.io/gh/googleapis/java-storage/pull/210?src=pr&el=h1) Report
> Merging [#210](https://codecov.io/gh/googleapis/java-storage/pull/210?src=pr&el=desc) into [master](https://codecov.io/gh/googleapis/java-storage/commit/789ceaa2be6163f85f483637205191e38029e0c2?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/googleapis/java-storage/pull/210/graphs/tree.svg?width=650&token=ssm139YOdp&height=150&src=pr)](https://codecov.io/gh/googleapis/java-storage/pull/210?src=pr&el=tree)

```diff
@@           Coverage Diff            @@
##             master    #210   +/-   ##
========================================
  Coverage      63.5%   63.5%           
  Complexity      540     540           
========================================
  Files            30      30           
  Lines          4759    4759           
  Branches        427     427           
========================================
  Hits           3022    3022           
  Misses         1577    1577           
  Partials        160     160
```



------

[Continue to review full report at Codecov](https://codecov.io/gh/googleapis/java-storage/pull/210?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/googleapis/java-storage/pull/210?src=pr&el=footer). Last update [789ceaa...b4f5778](https://codecov.io/gh/googleapis/java-storage/pull/210?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


Patch:
diff --git a/README.md b/README.md
index eb5e4e00..bcdb231c 100644
--- a/README.md
+++ b/README.md
@@ -245,4 +245,4 @@ Apache 2.0 - See [LICENSE] for more information.
 [cloud-storage-create-bucket]: https://cloud.google.com/storage/docs/cloud-console#_creatingbuckets
 [cloud-storage-activation]:https://cloud.google.com/storage/docs/signup?hl=en
 [storage-product-docs]: https://cloud.google.com/storage/docs/
-[storage-client-lib-docs]: https://googleapis.dev/java/google-cloud-clients/latest/index.html?com/google/cloud/storage/package-summary.html
+[storage-client-lib-docs]: https://googleapis.dev/java/google-cloud-storage/latest/index.html
diff --git a/pom.xml b/pom.xml
index 6aa2e33d..6591aa40 100644
--- a/pom.xml
+++ b/pom.xml
@@ -212,7 +212,7 @@
       <dependency>
         <groupId>com.google.cloud</groupId>
         <artifactId>google-cloud-conformance-tests</artifactId>
-        <version>0.0.7</version>
+        <version>0.0.9</version>
         <scope>test</scope>
       </dependency>
     </dependencies>
diff --git a/samples/install-without-bom/pom.xml b/samples/install-without-bom/pom.xml
index 2eb3989c..eed116bd 100644
--- a/samples/install-without-bom/pom.xml
+++ b/samples/install-without-bom/pom.xml
@@ -29,7 +29,7 @@
     <dependency>
       <groupId>com.google.cloud</groupId>
       <artifactId>google-cloud-storage</artifactId>
-      <version></version>
+      <version>1.106.0</version>
     </dependency>
     <!-- [END storage_install_without_bom] -->
 
diff --git a/samples/snapshot/pom.xml b/samples/snapshot/pom.xml
index ebe19169..496df31b 100644
--- a/samples/snapshot/pom.xml
+++ b/samples/snapshot/pom.xml
@@ -28,7 +28,7 @@
     <dependency>
       <groupId>com.google.cloud</groupId>
       <artifactId>google-cloud-storage</artifactId>
-      <version></version>
+      <version>1.106.1-SNAPSHOT</version>
     </dependency>
 
     <dependency>
diff --git a/samples/snippets/pom.xml b/samples/snippets/pom.xml
index 4a2edca4..4546ae2c 100644
--- a/samples/snippets/pom.xml
+++ b/samples/snippets/pom.xml
@@ -30,7 +30,7 @@
       <dependency>
         <groupId>com.google.cloud</groupId>
         <artifactId>libraries-bom</artifactId>
-        <version></version>
+        <version>4.3.0</version>
         <type>pom</type>
         <scope>import</scope>
       </dependency>


Test patch:
diff --git a/google-cloud-storage/src/test/java/com/google/cloud/storage/V4SigningTest.java b/google-cloud-storage/src/test/java/com/google/cloud/storage/V4SigningTest.java
index d45cb6dc..29fe002a 100644
--- a/google-cloud-storage/src/test/java/com/google/cloud/storage/V4SigningTest.java
+++ b/google-cloud-storage/src/test/java/com/google/cloud/storage/V4SigningTest.java
@@ -23,6 +23,7 @@ import com.google.api.core.ApiClock;
 import com.google.auth.oauth2.ServiceAccountCredentials;
 import com.google.cloud.conformance.storage.v1.SigningV4Test;
 import com.google.cloud.conformance.storage.v1.TestFile;
+import com.google.cloud.conformance.storage.v1.UrlStyle;
 import com.google.cloud.storage.Storage.SignUrlOption;
 import com.google.cloud.storage.testing.RemoteStorageHelper;
 import com.google.common.base.Charsets;
@@ -104,14 +105,14 @@ public class V4SigningTest {
 
     SignUrlOption style = SignUrlOption.withPathStyle();
 
-    if (testData.getUrlStyle().equals(SigningV4Test.UrlStyle.VIRTUAL_HOSTED_STYLE)) {
+    if (testData.getUrlStyle().equals(UrlStyle.VIRTUAL_HOSTED_STYLE)) {
       style = SignUrlOption.withVirtualHostedStyle();
-    } else if (testData.getUrlStyle().equals(SigningV4Test.UrlStyle.PATH_STYLE)) {
+    } else if (testData.getUrlStyle().equals(UrlStyle.PATH_STYLE)) {
       style = SignUrlOption.withPathStyle();
-    } else if (testData.getUrlStyle().equals(SigningV4Test.UrlStyle.BUCKET_BOUND_DOMAIN)) {
+    } else if (testData.getUrlStyle().equals(UrlStyle.BUCKET_BOUND_HOSTNAME)) {
       style =
           SignUrlOption.withBucketBoundHostname(
-              testData.getBucketBoundDomain(),
+              testData.getBucketBoundHostname(),
               Storage.UriScheme.valueOf(testData.getScheme().toUpperCase()));
     }