Repository: peopledoc/workalendar
Pull request #361 (2019-06-04 15:21:20)

Fix Panama calendar independence from Spain

- [x] Tests with a significant number of years to be tested for your calendar.
- [x] Changelog amended with a mention describing your changes.


brunobord: Thanks a lot for your contribution! A few points, though:

1. could you please make sure that this date change is/was permanent? was it always at this date, or did it change at a given year (for example: *"as of 2018, we're celebrating this holiday at this specific date"*); Adding a link or a reference document in the pull-request definition would be great, also.
2. could you please add a Changelog entry?
Natim: > The Independence day is always Novembre 28th.
Source: https://www.officeholidays.com/holidays/panama/panama-independence-day

brunobord: Wikipedia agrees: https://en.wikipedia.org/wiki/Public_holidays_in_Panama (of course, it can be wrong).

Maybe we could find some official document? (I can't read Spanish unfortunately)
Natim: http://www.panama-offshore-services.com/blog/fiestas_patrias_panama_celebrates_its_history_all_through_november.htm ?
chopanpma: Hi
This one is from us embassy in Panama the ones with the Panama flag
official holidays in Panama.

https://pa.usembassy.gov/holiday-calendar/

On Tue, Jun 4, 2019, 10:41 AM Rémy HUBSCHER <notifications@github.com>
wrote:

>
> http://www.panama-offshore-services.com/blog/fiestas_patrias_panama_celebrates_its_history_all_through_november.htm
> ?
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/peopledoc/workalendar/pull/361?email_source=notifications&email_token=AC2GGVK6RLJQW2PT7PCHYN3PY2EL3A5CNFSM4HS5O5SKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODW47R6Q#issuecomment-498727162>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AC2GGVLKXYVAXQXQ63K2BT3PY2EL3ANCNFSM4HS5O5SA>
> .
>

chopanpma: This is the official one, but I'm Spanish since it's the official language
:-).

http://gacetas.procuraduria-admon.gob.pa/27772-A_2015.pdf

On Tue, Jun 4, 2019, 11:10 AM Francisco Castañeda <fcastaneda@montuoso.com>
wrote:

> Hi
> This one is from us embassy in Panama the ones with the Panama flag
> official holidays in Panama.
>
> https://pa.usembassy.gov/holiday-calendar/
>
> On Tue, Jun 4, 2019, 10:41 AM Rémy HUBSCHER <notifications@github.com>
> wrote:
>
>>
>> http://www.panama-offshore-services.com/blog/fiestas_patrias_panama_celebrates_its_history_all_through_november.htm
>> ?
>>
>> —
>> You are receiving this because you authored the thread.
>> Reply to this email directly, view it on GitHub
>> <https://github.com/peopledoc/workalendar/pull/361?email_source=notifications&email_token=AC2GGVK6RLJQW2PT7PCHYN3PY2EL3A5CNFSM4HS5O5SKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODW47R6Q#issuecomment-498727162>,
>> or mute the thread
>> <https://github.com/notifications/unsubscribe-auth/AC2GGVLKXYVAXQXQ63K2BT3PY2EL3ANCNFSM4HS5O5SA>
>> .
>>
>

chopanpma: Ok will do.

On Wed, Jun 5, 2019, 11:40 AM Bruno Bord <notifications@github.com> wrote:

> *@brunobord* requested changes on this pull request.
> ------------------------------
>
> In Changelog.md
> <https://github.com/peopledoc/workalendar/pull/361#discussion_r290832203>:
>
> > @@ -4,6 +4,11 @@
>
>  Nothing here yet.
>
> +## v5.0.3 (2019-06-05)
>
> please, do not increase the version number yourself. It's the duty of the
> maintainer.
> You can replace the "Nothing here yet." line by your changelog entry.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/peopledoc/workalendar/pull/361?email_source=notifications&email_token=AC2GGVNABQ5VXFL6NDOTS2LPY7UALA5CNFSM4HS5O5SKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB2VZORA#pullrequestreview-246126404>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AC2GGVPMTZM3W27Q64EOHXDPY7UALANCNFSM4HS5O5SA>
> .
>

chopanpma: Done

On Wed, Jun 5, 2019 at 11:40 AM Bruno Bord <notifications@github.com> wrote:

> *@brunobord* requested changes on this pull request.
> ------------------------------
>
> In Changelog.md
> <https://github.com/peopledoc/workalendar/pull/361#discussion_r290832203>:
>
> > @@ -4,6 +4,11 @@
>
>  Nothing here yet.
>
> +## v5.0.3 (2019-06-05)
>
> please, do not increase the version number yourself. It's the duty of the
> maintainer.
> You can replace the "Nothing here yet." line by your changelog entry.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/peopledoc/workalendar/pull/361?email_source=notifications&email_token=AC2GGVNABQ5VXFL6NDOTS2LPY7UALA5CNFSM4HS5O5SKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB2VZORA#pullrequestreview-246126404>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AC2GGVPMTZM3W27Q64EOHXDPY7UALANCNFSM4HS5O5SA>
> .
>


-- 
Eng. Francisco Castañeda
Manager
Montuoso Software Engineering Inc.
e-mail:fcastaneda@montuoso.com
www.montuoso.com


Patch:
diff --git a/Changelog.md b/Changelog.md
index 11d3d4b..88ec23b 100644
--- a/Changelog.md
+++ b/Changelog.md
@@ -2,7 +2,8 @@
 
 ## master (unreleased)
 
-Nothing here yet.
+- Bugfix: Panama - Fixed incorrect independence from Spain date.
+
 
 ## v5.0.2 (2019-06-03)
 
diff --git a/workalendar/america/panama.py b/workalendar/america/panama.py
index 8969681..fca079c 100644
--- a/workalendar/america/panama.py
+++ b/workalendar/america/panama.py
@@ -21,7 +21,7 @@ class Panama(WesternCalendar, ChristianMixin):
         (11, 3, "Independence Day"),
         (11, 5, "Colon Day"),
         (11, 10, "Shout in Villa de los Santos"),
-        (12, 2, "Independence from Spain"),
+        (11, 28, "Independence from Spain"),
         (12, 8, "Mothers' Day"),
     )
 


Test patch:
diff --git a/workalendar/tests/test_america.py b/workalendar/tests/test_america.py
index 8f0aeb9..0af70fb 100644
--- a/workalendar/tests/test_america.py
+++ b/workalendar/tests/test_america.py
@@ -116,7 +116,7 @@ class PanamaTest(GenericCalendarTest):
         self.assertIn(date(2013, 11, 5), holidays)  # colon day
         # Shout in Villa de los Santos
         self.assertIn(date(2013, 11, 10), holidays)
-        self.assertIn(date(2013, 12, 2), holidays)  # Independence from spain
+        self.assertIn(date(2013, 11, 28), holidays)  # Independence from spain
         self.assertIn(date(2013, 12, 8), holidays)  # mother day
         self.assertIn(date(2013, 12, 25), holidays)  # XMas