Repository: jenkins-x/lighthouse
Pull request #918 (2020-08-14 18:38:36)

chore: Remove golint and blunderbuss plugins config (dead code)
This PR removes `golint` and `blunderbuss` plugins config as they are not used in the code.

jenkins-x-bot: Hi @eddycharly. Thanks for your PR.

I'm waiting for a [jenkins-x](https://github.com/orgs/jenkins-x/people) member to verify that this patch is reasonable to test. If it is, they should reply with `/ok-to-test` on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should [join the org](https://github.com/orgs/jenkins-x/people) to skip this step.

Once the patch is verified, the new status will be reflected by the `ok-to-test` label.

I understand the commands that are listed [here](https://go.k8s.io/bot-commands?repo=jenkins-x%2Flighthouse).

<details>

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [jenkins-x/lighthouse](https://github.com/jenkins-x/lighthouse/issues/new?title=Command%20issue:) repository.
</details>

jenkins-x-bot: [APPROVALNOTIFIER] This PR is **NOT APPROVED**

This pull-request has been approved by:
To complete the [pull request process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process), please assign **cagiti**
You can assign the PR to them by writing `/assign @cagiti` in a comment when ready.

The full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=jenkins-x%2Flighthouse).

<details open>
Needs approval from an approver in each of these files:

- **[OWNERS](https://github.com/jenkins-x/lighthouse/blob/master/OWNERS)**

Approvers can indicate their approval by writing `/approve` in a comment
Approvers can cancel approval by writing `/approve cancel` in a comment
</details>
<!-- META={"approvers":["cagiti"]} -->
abayer: /ok-to-test
abayer: I actually started trying to port the golint plugin over recently but got stuck figuring out how to deal with the line by line comments in a way that would work with GitLab and BitBucket Server. I’ll probably come back to it at some point, but I don’t see a problem in removing the config for now. The only concern I could have would be that existing Prow configs still need to be valid, but I believe it’ll just ignore unknown fields when unmarshaling anyway.
jenkins-x-bot: @eddycharly: The following test **failed**, say `/retest` to rerun them all:

Test name | Commit | Details | Rerun command
--- | --- | --- | ---
pr-build | 2b80d489aa805e97dbde728a7976058e2c884366 | [link](https://dashboard-jx.jenkins-x.live/teams/jx/projects/jenkins-x/lighthouse/PR-918/2) | `/test pr-build`

[View all Builds for this Pull Request](https://dashboard-jx.jenkins-x.live/teams/jx/projects/jenkins-x/lighthouse/PR-918) 

<details>

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [jenkins-x/lighthouse](https://github.com/jenkins-x/lighthouse/issues/new?title=Command%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
</details>
<!-- test report -->
abayer: A unit test failed in `pkg/repoconfig/merge`
eddycharly: As I’m writing plugins docs I started cleaning up the package at the same time. 

I’ll look at the failing test tonight or tomorrow. 
jenkins-x-bot: @eddycharly: The following test **failed**, say `/retest` to rerun them all:

Test name | Commit | Details | Rerun command
--- | --- | --- | ---
gitlab | 55839e9d01fd463663b3e743e2828fc9183d5e79 | [link](https://dashboard-jx.jenkins-x.live/teams/jx/projects/jenkins-x/lighthouse/PR-918/10) | `/test gitlab`

[View all Builds for this Pull Request](https://dashboard-jx.jenkins-x.live/teams/jx/projects/jenkins-x/lighthouse/PR-918) 

<details>

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [jenkins-x/lighthouse](https://github.com/jenkins-x/lighthouse/issues/new?title=Command%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
</details>
<!-- test report -->
jenkins-x-bot: @eddycharly: The following tests **failed**, say `/retest` to rerun them all:

Test name | Commit | Details | Rerun command
--- | --- | --- | ---
gitlab | 55839e9d01fd463663b3e743e2828fc9183d5e79 | [link](https://dashboard-jx.jenkins-x.live/teams/jx/projects/jenkins-x/lighthouse/PR-918/10) | `/test gitlab`
ghe | 55839e9d01fd463663b3e743e2828fc9183d5e79 | [link](https://dashboard-jx.jenkins-x.live/teams/jx/projects/jenkins-x/lighthouse/PR-918/8) | `/test ghe`

[View all Builds for this Pull Request](https://dashboard-jx.jenkins-x.live/teams/jx/projects/jenkins-x/lighthouse/PR-918) 

<details>

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [jenkins-x/lighthouse](https://github.com/jenkins-x/lighthouse/issues/new?title=Command%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
</details>
<!-- test report -->
jenkins-x-bot: @eddycharly: The following tests **failed**, say `/retest` to rerun them all:

Test name | Commit | Details | Rerun command
--- | --- | --- | ---
gitlab | 55839e9d01fd463663b3e743e2828fc9183d5e79 | [link](https://dashboard-jx.jenkins-x.live/teams/jx/projects/jenkins-x/lighthouse/PR-918/10) | `/test gitlab`
ghe | 55839e9d01fd463663b3e743e2828fc9183d5e79 | [link](https://dashboard-jx.jenkins-x.live/teams/jx/projects/jenkins-x/lighthouse/PR-918/8) | `/test ghe`
github | 55839e9d01fd463663b3e743e2828fc9183d5e79 | [link](https://dashboard-jx.jenkins-x.live/teams/jx/projects/jenkins-x/lighthouse/PR-918/11) | `/test github`

[View all Builds for this Pull Request](https://dashboard-jx.jenkins-x.live/teams/jx/projects/jenkins-x/lighthouse/PR-918) 

<details>

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [jenkins-x/lighthouse](https://github.com/jenkins-x/lighthouse/issues/new?title=Command%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
</details>
<!-- test report -->
jenkins-x-bot: @eddycharly: The following tests **failed**, say `/retest` to rerun them all:

Test name | Commit | Details | Rerun command
--- | --- | --- | ---
gitlab | 55839e9d01fd463663b3e743e2828fc9183d5e79 | [link](https://dashboard-jx.jenkins-x.live/teams/jx/projects/jenkins-x/lighthouse/PR-918/10) | `/test gitlab`
ghe | 55839e9d01fd463663b3e743e2828fc9183d5e79 | [link](https://dashboard-jx.jenkins-x.live/teams/jx/projects/jenkins-x/lighthouse/PR-918/8) | `/test ghe`
github | 55839e9d01fd463663b3e743e2828fc9183d5e79 | [link](https://dashboard-jx.jenkins-x.live/teams/jx/projects/jenkins-x/lighthouse/PR-918/11) | `/test github`
bbs | 55839e9d01fd463663b3e743e2828fc9183d5e79 | [link](https://dashboard-jx.jenkins-x.live/teams/jx/projects/jenkins-x/lighthouse/PR-918/9) | `/test bbs`

[View all Builds for this Pull Request](https://dashboard-jx.jenkins-x.live/teams/jx/projects/jenkins-x/lighthouse/PR-918) 

<details>

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [jenkins-x/lighthouse](https://github.com/jenkins-x/lighthouse/issues/new?title=Command%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
</details>
<!-- test report -->
jenkins-x-bot: @eddycharly: The following tests **failed**, say `/retest` to rerun them all:

Test name | Commit | Details | Rerun command
--- | --- | --- | ---
gitlab | 55839e9d01fd463663b3e743e2828fc9183d5e79 | [link](https://dashboard-jx.jenkins-x.live/teams/jx/projects/jenkins-x/lighthouse/PR-918/10) | `/test gitlab`
ghe | 55839e9d01fd463663b3e743e2828fc9183d5e79 | [link](https://dashboard-jx.jenkins-x.live/teams/jx/projects/jenkins-x/lighthouse/PR-918/8) | `/test ghe`
github | 55839e9d01fd463663b3e743e2828fc9183d5e79 | [link](https://dashboard-jx.jenkins-x.live/teams/jx/projects/jenkins-x/lighthouse/PR-918/11) | `/test github`
bbs | 55839e9d01fd463663b3e743e2828fc9183d5e79 | [link](https://dashboard-jx.jenkins-x.live/teams/jx/projects/jenkins-x/lighthouse/PR-918/9) | `/test bbs`
tekton | 55839e9d01fd463663b3e743e2828fc9183d5e79 | [link](https://dashboard-jx.jenkins-x.live/teams/jx/projects/jenkins-x/lighthouse/PR-918/12) | `/test tekton`

[View all Builds for this Pull Request](https://dashboard-jx.jenkins-x.live/teams/jx/projects/jenkins-x/lighthouse/PR-918) 

<details>

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [jenkins-x/lighthouse](https://github.com/jenkins-x/lighthouse/issues/new?title=Command%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
</details>
<!-- test report -->
jenkins-x-bot: @eddycharly: The following tests **failed**, say `/retest` to rerun them all:

Test name | Commit | Details | Rerun command
--- | --- | --- | ---
ghe | 55839e9d01fd463663b3e743e2828fc9183d5e79 | [link](https://dashboard-jx.jenkins-x.live/teams/jx/projects/jenkins-x/lighthouse/PR-918/8) | `/test ghe`
github | 55839e9d01fd463663b3e743e2828fc9183d5e79 | [link](https://dashboard-jx.jenkins-x.live/teams/jx/projects/jenkins-x/lighthouse/PR-918/11) | `/test github`
bbs | 55839e9d01fd463663b3e743e2828fc9183d5e79 | [link](https://dashboard-jx.jenkins-x.live/teams/jx/projects/jenkins-x/lighthouse/PR-918/9) | `/test bbs`
gitlab | 0d0e115f589443ea9df4ba0016029f56b752ab02 | [link](https://dashboard-jx.jenkins-x.live/teams/jx/projects/jenkins-x/lighthouse/PR-918/17) | `/test gitlab`

[View all Builds for this Pull Request](https://dashboard-jx.jenkins-x.live/teams/jx/projects/jenkins-x/lighthouse/PR-918) 

<details>

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [jenkins-x/lighthouse](https://github.com/jenkins-x/lighthouse/issues/new?title=Command%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
</details>
<!-- test report -->
jenkins-x-bot: @eddycharly: The following tests **failed**, say `/retest` to rerun them all:

Test name | Commit | Details | Rerun command
--- | --- | --- | ---
ghe | 55839e9d01fd463663b3e743e2828fc9183d5e79 | [link](https://dashboard-jx.jenkins-x.live/teams/jx/projects/jenkins-x/lighthouse/PR-918/8) | `/test ghe`
bbs | 55839e9d01fd463663b3e743e2828fc9183d5e79 | [link](https://dashboard-jx.jenkins-x.live/teams/jx/projects/jenkins-x/lighthouse/PR-918/9) | `/test bbs`
gitlab | 0d0e115f589443ea9df4ba0016029f56b752ab02 | [link](https://dashboard-jx.jenkins-x.live/teams/jx/projects/jenkins-x/lighthouse/PR-918/17) | `/test gitlab`
github | 0d0e115f589443ea9df4ba0016029f56b752ab02 | [link](https://dashboard-jx.jenkins-x.live/teams/jx/projects/jenkins-x/lighthouse/PR-918/15) | `/test github`

[View all Builds for this Pull Request](https://dashboard-jx.jenkins-x.live/teams/jx/projects/jenkins-x/lighthouse/PR-918) 

<details>

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [jenkins-x/lighthouse](https://github.com/jenkins-x/lighthouse/issues/new?title=Command%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
</details>
<!-- test report -->
jenkins-x-bot: @eddycharly: The following tests **failed**, say `/retest` to rerun them all:

Test name | Commit | Details | Rerun command
--- | --- | --- | ---
bbs | 55839e9d01fd463663b3e743e2828fc9183d5e79 | [link](https://dashboard-jx.jenkins-x.live/teams/jx/projects/jenkins-x/lighthouse/PR-918/9) | `/test bbs`
gitlab | 0d0e115f589443ea9df4ba0016029f56b752ab02 | [link](https://dashboard-jx.jenkins-x.live/teams/jx/projects/jenkins-x/lighthouse/PR-918/17) | `/test gitlab`
github | 0d0e115f589443ea9df4ba0016029f56b752ab02 | [link](https://dashboard-jx.jenkins-x.live/teams/jx/projects/jenkins-x/lighthouse/PR-918/15) | `/test github`
ghe | 0d0e115f589443ea9df4ba0016029f56b752ab02 | [link](https://dashboard-jx.jenkins-x.live/teams/jx/projects/jenkins-x/lighthouse/PR-918/14) | `/test ghe`

[View all Builds for this Pull Request](https://dashboard-jx.jenkins-x.live/teams/jx/projects/jenkins-x/lighthouse/PR-918) 

<details>

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [jenkins-x/lighthouse](https://github.com/jenkins-x/lighthouse/issues/new?title=Command%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
</details>
<!-- test report -->
jenkins-x-bot: @eddycharly: The following tests **failed**, say `/retest` to rerun them all:

Test name | Commit | Details | Rerun command
--- | --- | --- | ---
gitlab | 0d0e115f589443ea9df4ba0016029f56b752ab02 | [link](https://dashboard-jx.jenkins-x.live/teams/jx/projects/jenkins-x/lighthouse/PR-918/17) | `/test gitlab`
github | 0d0e115f589443ea9df4ba0016029f56b752ab02 | [link](https://dashboard-jx.jenkins-x.live/teams/jx/projects/jenkins-x/lighthouse/PR-918/15) | `/test github`
ghe | 0d0e115f589443ea9df4ba0016029f56b752ab02 | [link](https://dashboard-jx.jenkins-x.live/teams/jx/projects/jenkins-x/lighthouse/PR-918/14) | `/test ghe`
bbs | 0d0e115f589443ea9df4ba0016029f56b752ab02 | [link](https://dashboard-jx.jenkins-x.live/teams/jx/projects/jenkins-x/lighthouse/PR-918/16) | `/test bbs`

[View all Builds for this Pull Request](https://dashboard-jx.jenkins-x.live/teams/jx/projects/jenkins-x/lighthouse/PR-918) 

<details>

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [jenkins-x/lighthouse](https://github.com/jenkins-x/lighthouse/issues/new?title=Command%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
</details>
<!-- test report -->
abayer: /lgtm
jenkins-x-bot: [APPROVALNOTIFIER] This PR is **APPROVED**

This pull-request has been approved by: *[abayer](https://github.com/jenkins-x/lighthouse/pull/918#issuecomment-674277571 "LGTM")*

The full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=jenkins-x%2Flighthouse).

The pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)

<details >
Needs approval from an approver in each of these files:

- ~~[OWNERS](https://github.com#issuecomment-674277571/jenkins-x/lighthouse/blob/master/OWNERS)~~ [abayer]

Approvers can indicate their approval by writing `/approve` in a comment
Approvers can cancel approval by writing `/approve cancel` in a comment
</details>
<!-- META={"approvers":[]} -->

Patch:
diff --git a/charts/lighthouse/templates/plugins-cm.yaml b/charts/lighthouse/templates/plugins-cm.yaml
index f9aeb255..c9d9c584 100644
--- a/charts/lighthouse/templates/plugins-cm.yaml
+++ b/charts/lighthouse/templates/plugins-cm.yaml
@@ -22,7 +22,6 @@ data:
       # repos are specified here as:
       # - org/repo
       require_self_approval: true
-    blunderbuss: {}
     cat: {}
     cherry_pick_unapproved: {}
     config_updater:
diff --git a/pkg/plugins/config.go b/pkg/plugins/config.go
index 4fbafad9..bdc4b5de 100644
--- a/pkg/plugins/config.go
+++ b/pkg/plugins/config.go
@@ -32,8 +32,7 @@ import (
 )
 
 const (
-	defaultBlunderbussReviewerCount = 2
-	failOnMissingPlugin             = false
+	failOnMissingPlugin = false
 )
 
 // Configuration is the top-level serialization target for plugin Configuration.
@@ -56,11 +55,9 @@ type Configuration struct {
 	UseDeprecatedSelfApprove   bool                   `json:"use_deprecated_2018_implicit_self_approve_default_migrate_before_july_2019,omitempty"`
 	UseDeprecatedReviewApprove bool                   `json:"use_deprecated_2018_review_acts_as_approve_default_migrate_before_july_2019,omitempty"`
 	Blockades                  []Blockade             `json:"blockades,omitempty"`
-	Blunderbuss                Blunderbuss            `json:"blunderbuss,omitempty"`
 	Cat                        Cat                    `json:"cat,omitempty"`
 	CherryPickUnapproved       CherryPickUnapproved   `json:"cherry_pick_unapproved,omitempty"`
 	ConfigUpdater              ConfigUpdater          `json:"config_updater,omitempty"`
-	Golint                     *Golint                `json:"golint,omitempty"`
 	Heart                      Heart                  `json:"heart,omitempty"`
 	Label                      Label                  `json:"label,omitempty"`
 	Lgtm                       []Lgtm                 `json:"lgtm,omitempty"`
@@ -74,14 +71,6 @@ type Configuration struct {
 	Welcome                    []Welcome              `json:"welcome,omitempty"`
 }
 
-// Golint holds configuration for the golint plugin
-type Golint struct {
-	// MinimumConfidence is the smallest permissible confidence
-	// in (0,1] over which problems will be printed. Defaults to
-	// 0.8, as does the `go lint` tool.
-	MinimumConfidence *float64 `json:"minimum_confidence,omitempty"`
-}
-
 // ExternalPlugin holds configuration for registering an external
 // plugin in prow.
 type ExternalPlugin struct {
@@ -96,31 +85,6 @@ type ExternalPlugin struct {
 	Events []string `json:"events,omitempty"`
 }
 
-// Blunderbuss defines configuration for the blunderbuss plugin.
-type Blunderbuss struct {
-	// ReviewerCount is the minimum number of reviewers to request
-	// reviews from. Defaults to requesting reviews from 2 reviewers
-	// if FileWeightCount is not set.
-	ReviewerCount *int `json:"request_count,omitempty"`
-	// MaxReviewerCount is the maximum number of reviewers to request
-	// reviews from. Defaults to 0 meaning no limit.
-	MaxReviewerCount int `json:"max_request_count,omitempty"`
-	// FileWeightCount is the maximum number of reviewers to request
-	// reviews from. Selects reviewers based on file weighting.
-	// This and request_count are mutually exclusive options.
-	FileWeightCount *int `json:"file_weight_count,omitempty"`
-	// ExcludeApprovers controls whether approvers are considered to be
-	// reviewers. By default, approvers are considered as reviewers if
-	// insufficient reviewers are available. If ExcludeApprovers is true,
-	// approvers will never be considered as reviewers.
-	ExcludeApprovers bool `json:"exclude_approvers,omitempty"`
-	// UseStatusAvailability controls whether blunderbuss will consider GitHub's
-	// status availability when requesting reviews for users. This will use at one
-	// additional token per successful reviewer (and potentially more depending on
-	// how many busy reviewers it had to pass over).
-	UseStatusAvailability bool `json:"use_status_availability,omitempty"`
-}
-
 // Owners contains configuration related to handling OWNERS files.
 type Owners struct {
 	// MDYAMLRepos is a list of org and org/repo strings specifying the repos that support YAML
@@ -683,10 +647,6 @@ func (c *Configuration) setDefaults() {
 			c.ExternalPlugins[repo][i].Endpoint = fmt.Sprintf("http://%s", p.Name)
 		}
 	}
-	if c.Blunderbuss.ReviewerCount == nil && c.Blunderbuss.FileWeightCount == nil {
-		c.Blunderbuss.ReviewerCount = new(int)
-		*c.Blunderbuss.ReviewerCount = defaultBlunderbussReviewerCount
-	}
 	for i, trigger := range c.Triggers {
 		if trigger.TrustedOrg == "" || trigger.JoinOrgURL != "" {
 			continue
@@ -816,19 +776,6 @@ func validateExternalPlugins(pluginMap map[string][]ExternalPlugin) error {
 	return nil
 }
 
-func validateBlunderbuss(b *Blunderbuss) error {
-	if b.ReviewerCount != nil && b.FileWeightCount != nil {
-		return errors.New("cannot use both request_count and file_weight_count in blunderbuss")
-	}
-	if b.ReviewerCount != nil && *b.ReviewerCount < 1 {
-		return fmt.Errorf("invalid request_count: %v (needs to be positive)", *b.ReviewerCount)
-	}
-	if b.FileWeightCount != nil && *b.FileWeightCount < 1 {
-		return fmt.Errorf("invalid file_weight_count: %v (needs to be positive)", *b.FileWeightCount)
-	}
-	return nil
-}
-
 func validateConfigUpdater(updater *ConfigUpdater) error {
 	files := sets.NewString()
 	configMapKeys := map[string]sets.String{}
@@ -920,9 +867,6 @@ func (c *Configuration) Validate() error {
 	if err := validateExternalPlugins(c.ExternalPlugins); err != nil {
 		return err
 	}
-	if err := validateBlunderbuss(&c.Blunderbuss); err != nil {
-		return err
-	}
 	if err := validateConfigUpdater(&c.ConfigUpdater); err != nil {
 		return err
 	}


Test patch:
diff --git a/pkg/repoconfig/merge/test_data/simple/expected-plugins.yaml b/pkg/repoconfig/merge/test_data/simple/expected-plugins.yaml
index 56a0e168..545046fd 100644
--- a/pkg/repoconfig/merge/test_data/simple/expected-plugins.yaml
+++ b/pkg/repoconfig/merge/test_data/simple/expected-plugins.yaml
@@ -6,7 +6,6 @@ approve:
 - repos:
   - myorg/myowner
   require_self_approval: false
-blunderbuss: {}
 cat: {}
 cherry_pick_unapproved: {}
 config_updater:
@@ -36,7 +35,6 @@ plugins:
   - config-updater
   - approve
   - assign
-  - blunderbuss
   - help
   - hold
   - lgtm
diff --git a/pkg/repoconfig/merge/test_data/simple/source-plugins.yaml b/pkg/repoconfig/merge/test_data/simple/source-plugins.yaml
index e7f3e715..7bcb97f3 100644
--- a/pkg/repoconfig/merge/test_data/simple/source-plugins.yaml
+++ b/pkg/repoconfig/merge/test_data/simple/source-plugins.yaml
@@ -3,7 +3,6 @@ approve:
   repos:
   - someorg/somerepo
   require_self_approval: true
-blunderbuss: {}
 cat: {}
 cherry_pick_unapproved: {}
 config_updater:
@@ -21,7 +20,6 @@ plugins:
   - config-updater
   - approve
   - assign
-  - blunderbuss
   - help
   - hold
   - lgtm
diff --git a/pkg/webhook/test_data/test_plugins.yaml b/pkg/webhook/test_data/test_plugins.yaml
index cdc10363..3fd99b16 100644
--- a/pkg/webhook/test_data/test_plugins.yaml
+++ b/pkg/webhook/test_data/test_plugins.yaml
@@ -119,7 +119,6 @@ approve:
   repos:
   - test-org/bdd-gh-1573770044
   require_self_approval: true
-blunderbuss: {}
 cat: {}
 cherry_pick_unapproved: {}
 config_updater: {}
@@ -161,7 +160,6 @@ plugins:
   - config-updater
   - approve
   - assign
-  - blunderbuss
   - help
   - hold
   - lgtm
@@ -176,7 +174,6 @@ plugins:
   - config-updater
   - approve
   - assign
-  - blunderbuss
   - help
   - hold
   - lgtm
@@ -191,7 +188,6 @@ plugins:
   - config-updater
   - approve
   - assign
-  - blunderbuss
   - help
   - hold
   - lgtm
@@ -206,7 +202,6 @@ plugins:
   - config-updater
   - approve
   - assign
-  - blunderbuss
   - help
   - hold
   - lgtm
@@ -221,7 +216,6 @@ plugins:
   - config-updater
   - approve
   - assign
-  - blunderbuss
   - help
   - hold
   - lgtm
@@ -236,7 +230,6 @@ plugins:
   - config-updater
   - approve
   - assign
-  - blunderbuss
   - help
   - hold
   - lgtm
@@ -251,7 +244,6 @@ plugins:
   - config-updater
   - approve
   - assign
-  - blunderbuss
   - help
   - hold
   - lgtm
@@ -266,7 +258,6 @@ plugins:
   - config-updater
   - approve
   - assign
-  - blunderbuss
   - help
   - hold
   - lgtm
@@ -281,7 +272,6 @@ plugins:
   - config-updater
   - approve
   - assign
-  - blunderbuss
   - help
   - hold
   - lgtm
@@ -296,7 +286,6 @@ plugins:
   - config-updater
   - approve
   - assign
-  - blunderbuss
   - help
   - hold
   - lgtm
@@ -311,7 +300,6 @@ plugins:
   - config-updater
   - approve
   - assign
-  - blunderbuss
   - help
   - hold
   - lgtm
@@ -326,7 +314,6 @@ plugins:
   - config-updater
   - approve
   - assign
-  - blunderbuss
   - help
   - hold
   - lgtm
@@ -341,7 +328,6 @@ plugins:
   - config-updater
   - approve
   - assign
-  - blunderbuss
   - help
   - hold
   - lgtm
@@ -356,7 +342,6 @@ plugins:
   - config-updater
   - approve
   - assign
-  - blunderbuss
   - help
   - hold
   - lgtm
@@ -371,7 +356,6 @@ plugins:
   - config-updater
   - approve
   - assign
-  - blunderbuss
   - help
   - hold
   - lgtm
@@ -386,7 +370,6 @@ plugins:
   - config-updater
   - approve
   - assign
-  - blunderbuss
   - help
   - hold
   - lgtm
@@ -401,7 +384,6 @@ plugins:
   - config-updater
   - approve
   - assign
-  - blunderbuss
   - help
   - hold
   - lgtm
@@ -416,7 +398,6 @@ plugins:
   - config-updater
   - approve
   - assign
-  - blunderbuss
   - help
   - hold
   - lgtm
@@ -431,7 +412,6 @@ plugins:
   - config-updater
   - approve
   - assign
-  - blunderbuss
   - help
   - hold
   - lgtm
@@ -446,7 +426,6 @@ plugins:
   - config-updater
   - approve
   - assign
-  - blunderbuss
   - help
   - hold
   - lgtm
@@ -461,7 +440,6 @@ plugins:
   - config-updater
   - approve
   - assign
-  - blunderbuss
   - help
   - hold
   - lgtm
@@ -476,7 +454,6 @@ plugins:
   - config-updater
   - approve
   - assign
-  - blunderbuss
   - help
   - hold
   - lgtm
@@ -491,7 +468,6 @@ plugins:
   - config-updater
   - approve
   - assign
-  - blunderbuss
   - help
   - hold
   - lgtm
@@ -506,7 +482,6 @@ plugins:
   - config-updater
   - approve
   - assign
-  - blunderbuss
   - help
   - hold
   - lgtm
@@ -521,7 +496,6 @@ plugins:
   - config-updater
   - approve
   - assign
-  - blunderbuss
   - help
   - hold
   - lgtm
@@ -536,7 +510,6 @@ plugins:
   - config-updater
   - approve
   - assign
-  - blunderbuss
   - help
   - hold
   - lgtm
@@ -551,7 +524,6 @@ plugins:
   - config-updater
   - approve
   - assign
-  - blunderbuss
   - help
   - hold
   - lgtm
@@ -566,7 +538,6 @@ plugins:
   - config-updater
   - approve
   - assign
-  - blunderbuss
   - help
   - hold
   - lgtm
@@ -581,7 +552,6 @@ plugins:
   - config-updater
   - approve
   - assign
-  - blunderbuss
   - help
   - hold
   - lgtm
@@ -596,7 +566,6 @@ plugins:
   - config-updater
   - approve
   - assign
-  - blunderbuss
   - help
   - hold
   - lgtm
diff --git a/test/e2e/test_data/example-plugins.tmpl.yml b/test/e2e/test_data/example-plugins.tmpl.yml
index 72a41a00..3de5de74 100644
--- a/test/e2e/test_data/example-plugins.tmpl.yml
+++ b/test/e2e/test_data/example-plugins.tmpl.yml
@@ -3,7 +3,6 @@ approve:
   repos:
   - {{ .Owner }}/{{ .Repo }}
   require_self_approval: true
-blunderbuss: {}
 cat: {}
 cherry_pick_unapproved: {}
 config_updater: {}