Repository: Nukesor/comfy-table
Pull request #87 (2022-09-11 19:50:49)

Ci improvement (continued)
Attempt no.2 for issue #84 #85 

Nukesor: From what I understand, the co-authorship must be present on this commit of yours.
https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors

Simply adding a `Co-authored-by: name <name@example.com>` on the merge commit will probably do nothing, as the merge commit will be done by me/Github anyway.

Since I cannot change your commits, I assume you'll have to add this line to your commit message yourself.
You can get my commit Name + email address by looking at any of my commits via `git show`.

Patch:
diff --git a/.github/workflows/coverage.yml b/.github/workflows/coverage.yml
index 1d07b46..246ad24 100644
--- a/.github/workflows/coverage.yml
+++ b/.github/workflows/coverage.yml
@@ -26,10 +26,8 @@ jobs:
         uses: actions/checkout@v3
 
       - name: Setup Rust toolchain
-        uses: actions-rs/toolchain@v1
+        uses: dtolnay/rust-toolchain@stable
         with:
-          toolchain: stable
-          override: true
           components: llvm-tools-preview
 
       - name: Install cargo-llvm-cov
diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
index 4fa17ec..4564bde 100644
--- a/.github/workflows/lint.yml
+++ b/.github/workflows/lint.yml
@@ -29,31 +29,18 @@ jobs:
         uses: actions/checkout@v3
 
       - name: Setup Rust toolchain
-        uses: actions-rs/toolchain@v1
+        uses: dtolnay/rust-toolchain@stable
         with:
-          profile: minimal
-          toolchain: stable
-          override: true
           components: rustfmt, clippy
 
       - name: cargo build
-        uses: actions-rs/cargo@v1
-        with:
-          command: build
+        run: cargo build
 
       - name: cargo fmt
-        uses: actions-rs/cargo@v1
-        with:
-          command: fmt
+        run: cargo fmt
 
       - name: cargo clippy
-        uses: actions-rs/cargo@v1
-        with:
-          command: clippy
-          args: -- -D warnings
+        run: cargo clippy -- -D warnings
 
       - name: cargo clippy without default features
-        uses: actions-rs/cargo@v1
-        with:
-          command: clippy
-          args: --no-default-features -- -D warnings
+        run: cargo clippy --no-default-features -- -D warnings
diff --git a/Cargo.toml b/Cargo.toml
index f98f6f4..3f567c5 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -47,5 +47,5 @@ unicode-width = "0.1"
 pretty_assertions = "1"
 doc-comment = "0.3"
 proptest = "1"
-criterion = "0.4"
+criterion = "0.3"
 rand = "0.8"


Test patch:
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index e925832..eb8f488 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -51,31 +51,20 @@ jobs:
         uses: actions/checkout@v3
 
       - name: Setup Rust toolchain
-        uses: actions-rs/toolchain@v1
+        uses: dtolnay/rust-toolchain@master
         with:
-          profile: minimal
-          target: ${{ matrix.target }}
+          targets: ${{ matrix.target }}
           toolchain: ${{ matrix.toolchain }}
-          override: true
           components: rustfmt, clippy
 
       - name: cargo build
-        uses: actions-rs/cargo@v1
-        with:
-          command: build
-          args: --target=${{ matrix.target }}
+        run: cargo build --target=${{ matrix.target }}
         if: ${{ !matrix.minimal_setup }}
 
       - name: cargo test
-        uses: actions-rs/cargo@v1
-        with:
-          command: test
-          args: --target=${{ matrix.target }}
+        run: cargo test --target=${{ matrix.target }}
         if: ${{ !matrix.minimal_setup }}
 
       - name: cargo build without default features and without dev dependencies
-        uses: actions-rs/cargo@v1
-        with:
-          command: build
-          args: --release --target=${{ matrix.target }} --no-default-features
+        run: cargo build --release --target=${{ matrix.target }} --no-default-features
         if: ${{ matrix.minimal_setup }}