There is no general answer to this question. Flat spokes have minimal advantages in terms of aerodynamics and are often used with straightpull hubs because they are easier to manufacture in larger quantities. We like to use round spokes, unless it is a pure road bike LRS. Flat spokes are more expensive, so you should know exactly whether they make sense for the planned use.