Yes, the old Halloween buckets from McDonald's did have lids.  During 1986, 1990, 1992, 1994, and 1999, these vintage pails featured a handle and a functional lid, making them convenient for carrying and storing Halloween treats. However, the design of the buckets has evolved over the years.