It is definitely not going to benefit you, I can say that much for sure. Even if the supplement works regardless of your smoking habit, it will stain your teeth again, in the long run.