The choice between Guitar and Violin ultimately depends on your Sim's preferences. Since both are integral to the Musician Career, you'll need to master one of them. However, keep in mind that Piano mastery is also required, so choose the instrument that aligns with your Sim's interests.