Thancred has not died, as of Endwalker. Though there's been a couple of close calls, and he has needed to be resurrected, he is still alive and kicking.