Fatigue life: Spline > Keyway
Manufacturing cost: Spline broaching > Keyway broaching
Manufacturing time: It depends