To see Salzburg city itself, you should put aside a couple of days at most.  There are a lot of activities to do in the Salzburg region as well, and we would recommend a 7 night stay to cover most sights check out our guide here