It depends on what you are most comfortable in and what you are trying to achieve with your pole dancing. Shorts may be more comfortable and allow for more range of motion, while leggings can help you stay warm and provide support.