No, Buff apps on both Apple App Store and Google Play Store are not illegal.
Buff is truly legit and has also received high ratings and positive reviews on both the application stores.