If your salad doesn't smell right, most likely it's gone bad. In general, you want to avoid any leftovers that shows any changes in flavor, appearance, or if mold appears. When in doubt, toss it! Do not leave potato salad out for more than 2 hours when serving it at gatherings.