Wear what feels comfortable and allows your legs to move freely during all your exercises. Remember that when you are lying on a bench, if your shorts are too short or baggy, people can see up the leg. The gym is full of mirrors so be aware of the views you are giving to other gym goers.