There is no set time frame for how long a pre-shot routine should take. It all depends on what works best for you. My advice is to keep your routine short and simple. Whatever you do, make sure your routine is consistent with 3 stages - assess, prepare, and pull the trigger. This should take no longer than 30-40 seconds.