There is some debate about whether a Tom Collins should be shaken first, or mixed directly in the glass and just given a quick stir before serving. Most recipes, including this one, go with shaking. The ingredients will be fully mixed that way, and the ice that's in the glass won't melt as quickly since you'll be pouring on colder ingredients. In general, I usually shake any drink that has citrus juice.