This will vary from one herbicide to another. Some weed killers yield results within a few days while others take up to a month. Generally, you should see the weeds start to curl up after a week or two. Most pre-emergent herbicides remain effective at blocking weed germination for 3 months or more – consult your product’s packaging for details.