If possible, key results should always include relevant metrics that measure actual outcome, not just output. Projects with milestones belong to the output category so that they can be included as initiatives or tasks under the respective key results. For some objectives it can be fairly difficult to come up with metric-based key results, so you might not have any other option than to include milestone-based key results. In general, however, this is not advisable.