Yes, he needs to disclose any and all prior arrests and convictions.  As far as whether this might affect his getting a US citizenship or losing an already approved green card will really depend on the type of crime and for that, it is best to consult with an attorney who is familiar with the other country's criminal laws.