Because they have such a long shelf life, it can be tricky to tell when pickled onions have gone bad. However, if they develop a funky smell, change in color, start bubbling in the jar, or get slimy in texture, then it’s time to toss them out.