It can take anywhere from a few weeks to a few months for a puppy to be housebroken. The key is to be patient and consistent with training. Start by putting the puppy in a designated spot outside to do his business, and reward him with a treat when he goes potty in the right place. Be sure to praise him enthusiastically when he makes progress. If the puppy has an accident in the house, don't scold him – simply clean it up and put him back in his designated spot.