The right time to upgrade is whenever it makes the most sense for the individual. For some fortunate individuals, it is when their insurance benefit renews — which is typically every three years.
For others, four to five years is the "sweet spot," as this is the time frame where technology has significantly shifted to the point where users notice a significant improvement over their current hearing aids.