They both have pros and cons. Overall longevity earns a point for the metal mags (steel ones specifically) since they have more durability and less chance that the integral feed lips are damaged. The downside is they can be noisy when clanked against another surface and they have a bit of extra added weight. Polymer mags will be lighter and often cheaper. Most polymer magazines are made with military-grade polymer so they are shock resistant.