Edinburgh is a walkable city which is why you need comfy shoes or sandals for all day of walking. If you are going to visit some viewpoints or travel outside of the city, make sure to bring hiking boots or shoes as well. Also, always have a light jacket in warmer months, or a winter jacket if you are travelling in wintertime. Sunglasses are handy as well, on a bright summer day.