That depends on the shorts style. Most gym shorts perform just fine with underwear. But compression shorts in particular work best when no underwear is worn. They quickly remove sweat and act as a skintight liner that guards against chafing inside the thighs, or against scrapes when sliding during a softball or volleyball game.