I suggest making coleslaw the day of serving. The vinegar starts to break down the cabbage and it won't have the same crunch if you make it a whole day ahead. A few hours before is completely fine.