Every class can benefit from Engineering creations, and in such complex game, as WoW Classic is, nothing is clear-cut.
However we'd advise you to go for this profession on your main endgame character and create gold making alt, since these two don't go together. With Engineering gold is a commodity in short supply.