Yes, the admission to the National War Museum is free. But, as it is located within the premises of Edinburgh Castle, one has to pay for the admission ticket to the castle.