Apple cider vinegar is a great choice for pickling onions. It has a mellow, fruity flavor that complements the sweetness of the onions. You can also use white vinegar or red wine vinegar, each of which will give a slightly different flavor to pickled onions.