There is no correct answer to this question, and it depends on your needs. There are advantages and disadvantages to software and hardware wallets. These wallets are also referred to as hot (software) and cold (hardware) storage wallets. If you want a top of line security and ease of use, hardware wallets like the Trezor and Ledger Nano S are probably your best options. These wallets come at a cost, but we recommend them if you are storing a significant amount of crypto.
Check out episode 10 of Candid Crypto to learn more about crypto wallets.