If you are dressing your potato salad with a mayonnaise-based dressing, you want to allow them to cool before making potato salad so the potatoes don't melt the mayonnaise. If you are using a vinegar-based dressing, there is no need to cool the potatoes.