Using white vinegar gives a clear brine. If using apple cider vinegar instead; it will not be a clear brine. And so the color of the onions will not shine through.