It depends on your preference. A denser, waxier potato (like a red potato) will hold it's shape better. Russet potatoes tend to be fluffy, which I prefer. I use russet potatoes in this recipe. You can read more in this article about the science behind potato salad.