I don't recommend substituting a sweet onion in this recipe. A yellow onion gives it the strong flavor that it needs against all of the potatoes. The flavor of a sweet onion tends to get lost in this potato salad.