New potatoes aka red potatoes will make the creamiest soup, but it doesn't matter that much. If you have the starchier russet potatoes or Yukon golds, use them. You want vichyssoise to be creamy white, so sweet potatoes or purple potatoes would not be a good choice.