The best onions for making flavorful onion rings are sweet white onions. These onions have a delicious very light sweetness do them that make onions rings very flavorful. Regular yellow onions would also work. I have seen people use purple onions, but if you are looking for restaurant quality flavor, you should avoid using red onions for your onion rings as they are a little too pungant.