Clefairy won't evolve by leveling up or with high friendship. Instead, Clefairy evolves when exposed to a Moon Stone. This evolutionary stone can be picked up around Oni Mountain (appears as "golden sparkles" on the ground) or in South Province (Area Three) in Paldea.