It is always recommended to upgrade your town hall only after every building, troop, wall, and hero is completely maxed. If you are the anxious type, at least wait until everything besides heroes are maxed. If you make the move too soon, your offense will never be able to hit a normal TH10 for more than 1 or 2 stars.