The butter should be soft at room temperature but not melted. Softened butter ensures that the sugar is well incorporated. If the butter is cold or hard, it won't incorporate easily into the shortbread mixture resulting in an overworked dough which creates a dense bake.