Protein shakers are not entirely smell-proof. However, many shakers come with tight-fitting lids and seals, which help minimise odour leakage. Washing the shaker thoroughly after each use will reduce the chances of developing foul smells.