Yes, old potting soil loses value over time because the ingredients like peat moss, etc., start to decompose. Soil may start to lose moisture, affect the growth of plants, and start dying. At times during waterlogging, the soil may smell bad due to the presence of bacteria, but that has nothing to do with the soil going bad.