One of the most common reasons for data not being saved on iCloud is a shortage of space. Apple offers every user 5 GB of storage for free, but if you take a lot of pics then this can fill up quickly. To check your present usage, go to the Settings app and click on your account name and then choose iCloud.