No, it is not recommended to do pull ups with shoulder impingement as raising arm up reduces the sub-acromial spaces which increases pressure leading to increase risk of shoulder impingement.