No relationship is all sunshine is an old saying that means every relationship has its ups and downs. It's important to remember this when you're in a relationship, because no matter how great things are going, there will always be tough times too. This phrase is a reminder that even the best relationships have their challenges, and it's important to work through them together.