The two factors to consider when deciding when to buy new shorts are how often you run and how often you wash your shorts. If you run often or you wash to shorts fairly often then you are probably looking to replace them every one to two years. If you do so less frequently, then you can probably push up to five years.