An Xbox controller will last several years before having to be replaced as long as it's treated well. Playing video games with greasy fingers, dropping your controller on the ground, or leaving it uncharged (if wireless) for long stretches of time will impact its longevity.