If you plan on freezing them in a proper seal tight container you can make decorated sugar cookies months in advance. However, if you will be storing them in the refrigerator, plan on eating them within 5 to 7 days.