A good quality toilet fill valve should last at least 5 years. Often, they last longer. But if you notice changes in its performance, you should go ahead and replace it. Here is how to tell if it's time to change your fill valve: if there are leaks, if you notice weak toilet flushes, if you notice ghost/phantom flushes, or if there are weird noises coming from the toilet.