There is no right or wrong way to create SKU numbers. Create a system that makes sense for your business and that will allow you to look at a SKU and easily identify which product it refers to. Most SKUs are 8-12 characters long and the most important thing is that each product must have a unique identifier. There are plenty of online SKU generators that can help you.