According to the website of the United States Department of Veterans Affairs, the correct spelling is Veterans Day. This is because this day is not possessive, i.e., doesn’t belong to the veterans, but is attributive – it honours them.