A good trap should maintain an efficient seal, be self-cleaning, and provide unobstructed water flow.  Also, it should have a means of access for cleaning and maintenance purposes. Plus, the water seal should comply with a minimum depth of 2 inches and a maximum of 4 inches.