The methionine and cystine compounds in onions that makes your eyes water also makes the onions taste sharp. Soaking the onions in buttermilk dissolves the chemicals to make the onions tastier. It also gives the batter something to cling to.