You don't have to, but I think using both gives the onions an incredible zesty flavor. Use what you have on hand! Pickled onions in white vinegar will be a little tangier and pickled onions in apple cider vinegar will be a little sweeter.