After personally staying in both towns, I think it really depends on your travel style. If you are looking to spend most days by the beach relaxing with a slow paced day then I think Estoril is a great option. However, if you are looking to explore Cascais town, take part in some water based activities and dine in some tasty restaurants then I would look at staying in Cascais.