Cucumbers and onions in vinegar last in the refrigerator for up to one week. However, the vegetables will continue to soften and pickle during that time frame, so the texture will change. Generally, cucumber onion salad is best consumed within 3 days for the best taste and texture. If you add tomatoes to the salad, then it must be consumed within 3 days anyway due to the tomatoes.