Whether or not you wear underwear under your CrossFit shorts is purely a matter of personal preference. Keep in mind though that this activity features a ton of jumping and running and you may not want everything floating freely down there. In this case, underwear could be a good option for you.