Which software is best for you depends on your needs and also on your skills. For professional graphic designers with a lot of experience, Photoshop is certainly the better choice, as it is much more powerful than Canva. On the other hand, for beginners, in many cases Canva might be better, as it is much more intuitive and much easier to use than Photoshop.