This mostly comes down to personal preference and the conditions you're riding in. If riding off-road, longer socks will give you some protection from scratches and stinging plants. Obviously on colder rides, they'll help keep to keep you warm too. In general, road riders tend to lean towards shorter socks – as they need less protection, while MTB-ers tend to opt for mid length – which is a good sock sweet spot for use all year round.