Again, this one is more of a personal preference. For those in colder areas or those who like to layer, long ones are probably a better choice. They help increase circulation and you’ll never really have to worry about your ankles rubbing against your shoes.
Short ones are better for those who like to bring more attention to the shoe or those who don’t really like their socks to show. A downside is that they have more of a chance of falling down and your ankles can rub; this is why it’s important to find low-cut pairs that have a padded ankle tab.