It depends on your taste. Yellow sweet onions are great, red onions will give it a sharper flavor and stronger taste. You can even use shallots too, which are milder than yellow onions.