5-7 years is a good rule of thumb, but this varies widely based on the water quality, water pressure, and the quality of the materials used by the different manufacturers. In-tank toilet cleaners or DIY toilet tank chlorine tablets destroy the rubber parts of a tank very quickly. High water pressure can also cause the fill valve to fail much more frequently as well.