Both have their advantages, so it depends on what you are going for. Butter has a better, richer flavor. Butter based cookies have more potential to spread, but that is part of what gives you those buttery crispy edges. Shortening holds its shape more and is less likely to need chill time, however it lacks that butter flavoring. You can experiment with both to find your favorite or use a mix for the best of both worlds.