Personally, I don't think margarine is suitable to make shortbread. The cookies won't keep their shape as well in the oven and you'll lose out on flavour. Butter is a main component of shortbread, and you really want that buttery taste to shine through!