Yes, a basement floor drain needs a trap. All drains require traps to create an airtight water seal that will prevent hazardous sewer gases from escaping into your home.