You don’t have to pay again for GoodNotes 5 if you’ve already purchased it. You’ll continue to have full access to everything and your notes are all safe.
If you want to upgrade to Goodnotes 6, you can upgrade and subscribe directly in app.