The effectiveness of swales vs french drains depends on the context in which they are used. In some cases, a French drain may be more effective for controlling runoff due to its ability to more actively and quickly redirect water away from an area. However, in other cases a swale may be more effective, as it can act as a reservoir and store water for more controlled release.