There's no better time to visit San Antonio than during the winter and spring. The weather is pleasant, hotel rates are lower because there aren't as many people traveling around this part of Texas - which means you can get a better deal.
If you're looking for a more affordable trip, consider visiting during the shoulder seasons of spring or fall. The weather is still pleasant during these times, but there will be fewer people visiting the city.