A visor carrier assembly for a safety helmet, comprising: a visor; and an attachment device for attaching the visor to the safety helmet, the attachment device including double-pivot mechanisms for attachment to each side of the safety helmet to enable the visor to be selectively pivoted relative to the safety helmet, between first, second and third visor positions; characterised in that: each double pivot mechanism comprises first and second elongate arms (22, 24); the first elongate arm is to be fixedly mounted at a respective side edge of the safety helmet and a coupling region is provided in or on the first elongate arm; the second elongate arm is: coupled at one end to a respective side region of the visor by a first pivotal coupling comprising a coupling member and a coupling region, and coupled at a second end to the coupling region of the first elongate arm by a second pivotal coupling comprising a coupling member and a coupling region; each coupling member comprises a fixed elongate pin (50, 56) having a rounded portion (52a, 52b, 58a, 58b) at each end; each coupling region (28, 34) comprises an aperture (30, 36) defining a first notch or aperture (38, 40) along its inner edge within which one of the rounded portions (52a, 58a) of a respective coupling member is received to define a fixed pivot point, and an arcuate guide wall with which the opposite rounded portion (52b, 58b) of said respective coupling member engages and having ridges defining grooves or notches (39a, 39b, 42a, 42b) for receiving the opposite rounded portion (52b, 58b) as a respective pivotal coupling is pivoted about the fixed pivot point; and each groove or notch (39a, 39b, 42a, 42b) defines a respective visor position. a visor; and an attachment device for attaching the visor to the safety helmet, the attachment device including double-pivot mechanisms for attachment to each side of the safety helmet to enable the visor to be selectively pivoted relative to the safety helmet, between first, second and third visor positions; each double pivot mechanism comprises first and second elongate arms (22, 24); the first elongate arm is to be fixedly mounted at a respective side edge of the safety helmet and a coupling region is provided in or on the first elongate arm; the second elongate arm is: coupled at one end to a respective side region of the visor by a first pivotal coupling comprising a coupling member and a coupling region, and coupled at a second end to the coupling region of the first elongate arm by a second pivotal coupling comprising a coupling member and a coupling region; coupled at one end to a respective side region of the visor by a first pivotal coupling comprising a coupling member and a coupling region, and coupled at a second end to the coupling region of the first elongate arm by a second pivotal coupling comprising a coupling member and a coupling region; each coupling member comprises a fixed elongate pin (50, 56) having a rounded portion (52a, 52b, 58a, 58b) at each end; each coupling region (28, 34) comprises an aperture (30, 36) defining a first notch or aperture (38, 40) along its inner edge within which one of the rounded portions (52a, 58a) of a respective coupling member is received to define a fixed pivot point, and an arcuate guide wall with which the opposite rounded portion (52b, 58b) of said respective coupling member engages and having ridges defining grooves or notches (39a, 39b, 42a, 42b) for receiving the opposite rounded portion (52b, 58b) as a respective pivotal coupling is pivoted about the fixed pivot point; and each groove or notch (39a, 39b, 42a, 42b) defines a respective visor position.