But that eclipsed everything, dividing opinion for the whole of his career.