opened
dhirensr
username_0
@username_1  : i saw that this project needs this api ,and if no one is working i would like to work on it.
The idea is group by country and then for all distinct countries return 1 ip right?
or should it take country as parameter and then calculate top 10 ips of that country?
Waiting for the reply.
Top network ip by country
issue
created
Ali-Razmjoo
username_1
Hi,

thanks for your feedback, we also don't have it in honeypot events, right?

just to clarify sort will be like:

* honeypot->country->top_ips
* network->country->top_ips

no one currently working on this, just keep in mind if you want to provide this feature you must support `limit` and `skip` . the next step after that would be the same function by adding the date support. 

* honeypot->country->date->top_ips
* network->country->date->top_ips

thanks.
comment
created
dhirensr
username_0
@username_1 : I applied this sort for network events 
network->country->top_ips
I am not sure how do i test it if this is giving right results? I just changed the sort of top_ten_ips_in_network_events 
I am getting exactly the same results for both apis ,maybe the result is correct!
should i send a PR directly to review?
comment
created
Ali-Razmjoo
username_1
yes feel free to send your pr.
comment
created
dhirensr
username_0
@username_1 : https://github.com/zdresearch/OWASP-Honeypot/pull/9
please review
comment
closed
Ali-Razmjoo
username_1
issue
created
Ali-Razmjoo
username_1
thank you. done
comment