opened
psingh-io
username_0
#### Type of change
- Improvement to cryptogen tool

#### Description
This is an improvement on cryptogen tool to allow for custom expiry times for CA, Identity and TLS certificates for each organization. The expiration times can be customized using following configuration for each organization:
    CACertExpiry: 131400h
    IdentityCertExpiry: 131400h
    TLSCertExpiry: 131400h

The default expiry time remains 15 years
Added support to specify CA, Identity and TLS cert expiry times in cryptogen
issue
created
sykesm
username_1
Re-running PR checks. Some failures related to ubuntu mirror issues and units failed with FAB-16233.
comment
created
sykesm
username_1
@username_0 I plan to review these changes shortly but I wanted to point out that this PR was opened against release-2.3 instead of master. Our general process is to make the changes that introduce new features in master and to pull them back to other branches as appropriate. This helps ensure changes don't unintentionally dropped along the way.

Can you please retarget this PR to master?

Thanks.
comment
created
psingh-io
username_0
Sure, I will do this later today.

Thabks
comment
created
caod123
username_2
@username_0 it seems after you changed the base branch to master, a couple of unnecessary commits from the rebased `release-2.3` branch made it into this PR. Can you clean up the commit log so only your commit is on this PR against `master`? Also if possible can you address @username_1's comment regarding the missing integration tests for verifying this behavior.
comment
created
psingh-io
username_0
I will do the cleanup by tomorrow.

There is a separate ticket for integration test and I will pick that after
this. As it was pointed out by @username_1 <https://github.com/username_1>'s, the
integration tests did not exist for cryptogen before these changes.
comment
created
sykesm
username_1
The goal of that comment was to highlight that we're missing integration tests for this tool and that I believe we need them before we add additional capabilities.
comment
created
denyeart
username_3
@username_0 Do you intend to address the comments?
comment
created
denyeart
username_3
No response from @username_0 in many months so let's close, can be re-opened later.
comment