opened
joeytepp
username_0
## Proposed Change
Use [jest](https://facebook.github.io/jest/docs/en/getting-started.html) for unit testing on the hacker dashboard
Fixes Issue Ticket: #126 

### Description
After investigating several options, chose jest as unit testing framework for ongoing development
### List of changes:

	- Added jest to dependencies
	- Added jest testing to `test` script in `package.json`
	- Created an example test file in tests folder

## Pull Request Checklist:

	1. [ ] Does your submission pass tests?
	2. [ ] Have you lint your code locally prior to submission?
	3. [ ] Have you written new tests for your core changes, as applicable?
Add jest for unit testing
issue
created
joeytepp
username_0
@username_1 the client unit tests fail unless you run npm install from inside the client folder, do you know any way around this?
comment
created
joeytepp
username_0
@username_1 sounds good, gonna make some revisions on this after the long weekend 👍
comment
created
RobertWSaunders
username_1
Looks you have some conflicts to solve from the merging of #133. Your tests should be passing after that though, unless your new unit tests fail ahaha.
comment
created
RobertWSaunders
username_1
Updated the PR to use the new template for ya! Excited to have this in and get some experience writing some tests for our endpoints, this will be an awesome contribution that will lead to better code and a more bullet proof project.
comment
created
joeytepp
username_0
@username_1 ready for you to review this now. Also squashed and cherrypicked the original branch to fix the files changed issue
comment
created
joeytepp
username_0
@username_1 still waiting on this one ⏱🕚⏳🙃
comment
created
joeytepp
username_0
@username_1 missed some of your comments on my initial response, think i've addressed them all now. I'll get rid of the `jsconfig` stuff now and we will figure out the rest 👍
comment
created
RobertWSaunders
username_1
Lemme know when this is good for another review!
comment
created
joeytepp
username_0
@username_1 see my comments on the access token/env stuff, ready for you to give this another review (also added a badge to the README)
comment