opened
mitsy
username_0
Adding unit tests to convert some of the "online" tests to "standalone" ones using WireMock. In this PR, the "online" ones are not removed, but corresponding "standalone" ones are added to *Local test classes. Even apart from these, other tests are added wherever there was scope to add them. Please review. Thanks.

Mitali Jha
DevFactory
Adding unit tests
issue
created
slandelle
username_1
Hi Mitali,

Thanks a lot!

Would it be possible for you to provide a first PR with only the tests that are not based on WireMock, please?
Then, we'll figure out the best course of action regarding the other ones.

Thanks
comment
created
mitsy
username_0
Sure, Stephane. I'll work on it. Thanks for the review comments.

I am evaluating if we could get away without using WireMock and instead use
jetty for testing the functionality that we are testing here with WireMock.


Thanks a lot.
Mitali
comment
created
slandelle
username_1
I'm starting to consider if I couldn't build a simple test framework on top of Jetty, without abstracting anything away the way WireMock does. Maybe having a way to enqueue handlers, similar to OkHttp's MockServer.
comment
created
slandelle
username_1
@username_0 As expected, my PR is being rejected because WireMock's author want to retain JDK7 compatibility for some time. So no Jetty 9.3 there for now, which is a no go for us.

Let's keep on going with a custom tailor made solution so we don't depend on any external agenda. I'm pretty sure I can improve our current crappy integration test framework. I'll work on this next week, my hands at full atm.

In the meantime, it would be great if you could extract the non WireMock based stuff and submit a new isolated PR that I could quickly merge. I could do it myself, but you wouldn't be credited for the commit, so it would be a pity. Please just tell me.

Regards
comment
created
mitsy
username_0
I'll raise an islolated PR soon. Meanwhile, over the course of this week,
I'll anyway investigate what it takes to create a jetty based custom
integration test solution (similar to WireMock).

Regards
comment
created
slandelle
username_1
Awesome, thanks!
comment
created
slandelle
username_1
Closing this PR. Eager to get the next one :)
comment
created
slandelle
username_1
@username_0 gentle ping. Did you get a chance to extract the non WireMock stuff?
comment