opened
vikaschoudhary16
username_0
openshift/kubernetes-drain got updated to list daemonsets as part of `apps` group: https://github.com/openshift/kubernetes-drain/commit/97b0f2710aa6579a688c834e4c2c919adf1912d0#diff-b35cc60e9fab98b13f2a1f43795d4d00

Accordingly cluster-role should be updated. Otherwise we get error like this on Drain():
```
daemonsets.apps "node-ca" is forbidden: User "system:serviceaccount:openshift-machine-api:machine-api-controllers" cannot get resource "daemonsets" in API group "apps" in the namespace "openshift-image-registry": node-ca-sc9p8; daemonsets.apps "machine-config-daemon" is forbidden: User "system:serviceaccount:openshift-machine-api:machine-api-controllers" cannot get resource "daemonsets" in API group "apps" in the namespace "openshift-machine-config-operator": machine-config-daemon-zd5j9; daemonsets.apps "node-exporter" is forbidden: User "system:serviceaccount:openshift-machine-api:machine-api-controllers" cannot get resource "daemonsets" in API group "apps" in the namespace "openshift-monitoring": node-exporter-xnc6f; daemonsets.apps "multus" is forbidden: User "system:serviceaccount:openshift-machine-api:machine-api-controllers" cannot get resource "daemonsets" in API group "apps" in the namespace "openshift-multus": multus-fc6jv; daemonsets.apps "ovs" is forbidden: User "system:serviceaccount:openshift-machine-api:machine-api-controllers" cannot get resource "daemonsets" in API group "apps" in the namespace "openshift-sdn": ovs-f49pj; daemonsets.apps "sdn" is forbidden: User "system:serviceaccount:openshift-machine-api:machine-api-controllers" cannot get resource "daemonsets" in API group "apps" in the namespace "openshift-sdn": sdn-b79c2; daemonsets.apps "tuned" is forbidden: User "system:serviceaccount:openshift-machine-api:machine-api-controllers" cannot get resource "daemonsets" in API group "apps" in the namespace "openshift-cluster-node-tuning-operator": tuned-xzgzh; daemonsets.apps "dns-default" is forbidden: User "system:serviceaccount:openshift-machine-api:machine-api-controllers" cannot get resource "daemonsets" in API group "apps" in the namespace "openshift-dns": dns-default-c495j
```

This PR is required to get the CI green on https://github.com/openshift/cluster-api-provider-aws/pull/243
Modify machine-api-controller clusterrole for daemonsets
issue
created
enxebre
username_1
/approve
comment
created
frobware
username_2
/lgtm
comment
created
frobware
username_2
/lgtm
comment
created
frobware
username_2
/lgtm cancel
comment
created
ingvagabund
username_3
/lgtm
comment
created
enxebre
username_1
/cherrypick release-4.1
comment