opened
kencheeto
username_0
Connects #6947 

### Description
* Adds a max address line length validation of 20 characters to the Veteran model
* Adds support for displaying multiple kinds of validation errors on Veterans during Intake search (not just missing fields)
* Adds error messaging for address line lengths that are too long
* Removes handling of long address errors on intake completion

three potential visual things to tweak, to my eyes:
* Our `cf-bare-list` style sets `list-style-type: none;` but I wonder if the tips would look better with visible bullets
* the spacing between bullets in the tips feels a bit too large
* should the missing fields vs long address messages be more distinct?

### Screenshots of possible Veteran validation errors

Error when address line length is over 20 chars:
<img width="881" alt="screen shot 2018-09-24 at 7 02 35 pm" src="https://user-images.githubusercontent.com/279406/45989569-1f8c0280-c031-11e8-969d-a9f07c6287e7.png">
Existing error when fields are missing:
<img width="863" alt="screen shot 2018-09-24 at 7 04 58 pm" src="https://user-images.githubusercontent.com/279406/45989570-1f8c0280-c031-11e8-89ce-0bf8c3649304.png">
When both errors are present:
<img width="877" alt="screen shot 2018-09-24 at 7 33 41 pm" src="https://user-images.githubusercontent.com/279406/45989571-1f8c0280-c031-11e8-9f05-42cfd5140dd4.png">

### Acceptance Criteria
- [x] Code compiles correctly
- [x] Feature, unit tests

### Testing Plan
1. Edit bgs_service.rb#L31 to add a long address and/or missing field
    ```diff
    -# veteran = Generators::Veteran.build(file_number: row_hash["vbms_id"].chop)
    +veteran = Generators::Veteran.build(file_number: row_hash["vbms_id"].chop, address_line1: "super super long address blab blab blab", city: nil, state: nil)
    ```
1. Attempt to start an intake with any veteran
1. Validate that the error(s) show up correctly
Validate veteran address line length on intake search
issue
created
suzchap
username_1
It's not super pretty but I think it's fine for now.
comment