opened
mastermatt
username_0
Removes most of the eslint overrides that had the "TODO These are included in standard and should be cleaned up and turned on."
- no-path-concat
- no-throw-literal
- handle-callback-err
- eqeqeq
- new-cap
- camelcase

Each rule is isolated in it's own commit to ease reviewing. 

The only setting I left in place was `no-deprecated-api`. There are two places where this rule is broken and each deserve their own PR.

- `tests/test_header_matching.js` makes use of the `domain` module, which has been deprecated since Node v4.0.0, to aid in asserting errors. That whole file needs to be refactored anyway to use `got`.
- `url.parse` was deprecated in Node v11.0.0 in favor of the `url.URL` constructor. This will require some careful work to change as POJOs that resemble the output of `url.parse` get passed around a lot without a whole lot of documenting or commenting. I started down this rabbit hole and ran into a few edge cases that I think would introduce backwards breaking API changes.
Lint: Remove overrides.
issue