opened
UrielCh
username_0
- add a default salted Password implementation in client.go
- the new Implementation is tested in client_test.go
- reduce and improce utilitise function in urlvalidate.go
Add a default salted Password implementation + Testing + Small code improvement.
issue
created
UrielCh
username_0
thx for your feed back.
comment
created
UrielCh
username_0
Change completed :)
comment
created
UrielCh
username_0
Patched again.
comment
created
UrielCh
username_0
patched again.
comment
created
UrielCh
username_0
I had some more small patch to reduce duplicate code and code size.
can I submit them in this PR ?
comment
created
liggitt
username_1
@username_3 has the definitive answer, but my preference would be to limit this to the salted client example
comment
created
UrielCh
username_0
okey just my local change in access.go

it's time for final comments
comment
created
leetal
username_2
To me this PR seems OK, but with some smaller spelling mistakes. The pros is that this does not mess with the base implementation (other than improving it), and the cons is that it adds three new dependencies and also a new client that we need to mess with in case of updates. 

Nevertheless, I'm in favor of a PR.
comment
created
UrielCh
username_0
I'm back :)

Is my go docs are all Ok? As you can guess I'm not a native english speaker.
comment
created
RangelReale
username_3
Like #107, I don't think this belongs on the library, for the library to be simple, it shoudl just focus on the spec, this kind of thing I think would be better on another repository. If it is generic enough, I could point to it on the README.
comment
created
arekkas
username_4
Hi, I am the author of [Hydra](https://github.com/ory-am/hydra) and am currently writing an security-first framework for OAuth2 a osin-familiar API called [**fosite**](https://github.com/ory-am/fosite). If your changes don't make it to osin, as username_3 validly pointed out (and I believe the [same](https://github.com/username_3/osin/issues/107#issuecomment-169708348)), feel free to check it out. I am looking forward to any contributions, problems or use cases. :)
comment
created
UrielCh
username_0
I know your Hydra project I will probably contribute to it in the next Weeks.
comment