opened
bengreenier
username_0
The [package.json](https://github.com/Azure/platform-chaos/blob/master/package.json) file currently still lists `username_0` as a publisher, it should instead say `microsoft`.
package json needs updated publisher information
issue
created
Ethan-Arrowood
username_1
Can I include this fix in #14 ?
comment
created
bengreenier
username_0
@username_1 short answer: probably.

longer answer: What i'd ideally like to see if we go that route is clarity at the commit level. You'd want to rebase and merge (not squash and merge) and have one commit that fixes #11 and one that fixes this.
comment
created
Ethan-Arrowood
username_1
Okay so even though PRs are limited to squash and merging I can (locally) rebase and merge multiple commits in one PR -- I'll go ahead a push to my open pr branch now
comment
created
bengreenier
username_0
no that isn't necessary - we can modify our github configuration to allow rebase and merge. see https://github.com/orgs/Azure/teams/platform-chaos/discussions/5 for our internal discussion on the matter (sorry folks who don't have visibility here)
comment
closed
bengreenier
username_0
issue
created
bengreenier
username_0
closed in https://github.com/Azure/platform-chaos/pull/19
comment