opened
jarlah
username_0
Related to https://www.tapatalk.com/groups/freeacsforum/firmware-upgrade-downloadlink-t15.html
Should fix errors in generating download urls.
Currently only the code fix has been implemented.
Tests need to be added to verify that this actually solves the problem.
always use property based context path, not servlet context path
issue
created
jarlah
username_0
I should also consider renaming get Request method to getRequestData and getReq to getRawRequest, including the field names and setters. This to clearly separate what is relevant and whats not
comment
created
jarlah
username_0
The reason why context path on httpservletrequest is no more relevant is due to the fact that almost all modules now is based on spark java which does not have a concept of context path.
comment
created
jarlah
username_0
i am not going to fix any code style issues relating to this fix, they are not relevant in this context and would increase risk.
comment