opened
ahbarnett
username_0
FFTW_PLAN fftwPlan;   // *** should these 3 be ptrs instead?
  nufft_opts opts;
  spread_opts spopts;
 
It has been suggested these should be pointers, which means they have to be malloc'ed (C-style, because this header has to be C-compatible), I think, upon creation of a finufft_plan.

To me this sounds more messy, so actually I have no idea what the benefit is, other than if we want to write a ctypes python interface to a plan to access all of its elements.

I open the conversation, but am not sure this should be done.
v1.2 finufft_plan.h could have pointers to structs not struct instances?
issue
created
ahbarnett
username_0
A disadvantage would be that guru users could change the nufft_opts *after* finufft_plan is formed, which could spell disaster.   (Currently because nufft_opts is not a ptr in the plan, it is deep-copied at planning stage, and user can no longer affect the opts - a good thing).
comment
created
ahbarnett
username_0
we leave this as is.
comment
closed
ahbarnett
username_0
issue