opened
dereuromark
username_0
Resolves https://github.com/FriendsOfCake/search/issues/82

Classified as bug as currently using wildcard chars as normal text triggers wildcard behavior of DB which is not intended (unless you configure and use those specifically as wildcard chars for your filter).

2nd bug was: When using array input, the LIKE before/after was not working.
There were also no tests for this bug, this is now also fixed.

Also some small code cleanup.
Add proper filter behavior for LIKE wildcards.
issue
created
ADmad
username_1
Why all the unrelated changes in a single commit?
comment
created
dereuromark
username_0
Because I was working on a single branch for simplicity.
Those are simple fixes to easily look over and approve.
comment
created
ADmad
username_1
You can still do separate commits for unrelated changes on a single branch :)
comment
created
dereuromark
username_0
Or we can't be dense here and get stuff done ;)
You could just as well have fixed the issues I pointed out here yourself.
comment
created
dereuromark
username_0
Can we continue?
comment
created
dereuromark
username_0
Guys, whats the holdup?
I would very much not like to branch-off here as own composer plugin just because of that.
Let's please get things done.
comment
created
dereuromark
username_0
Closing and forking then as split off otherwise.. :/
comment
created
josegonzalez
username_2
@username_0 whats left on this PR, if anything?
comment
created
dereuromark
username_0
The decision on how to make a major bump probably.
And probably how to integrate https://github.com/FriendsOfCake/search/pull/85 before a major bump for all those that would need just escaping here.
comment
created
dereuromark
username_0
I rebased.
We can now release it with 2.0 tag and add documentation on how to use it from here on / what changed compared to 1.x.
comment
created
dereuromark
username_0
All good?
comment
created
jippi
username_3
TL;DR LGTM
comment
created
ADmad
username_1
TL;DR I'll make a 1.x release and then merge this to prepare for 2.0.
comment