opened
jseppi
username_0
Work In Progress.

Creating a decorator to handle form submissions for canceling Data Capture flows.

Closes #478

To Do:
- [ ] functionality
- [ ] tests
- [ ] add decorator to applicable view methods
- [ ] styling tweaks for making cancel buttons
[WIP] Canceling data_capture flows
issue
created
jseppi
username_0
Ugh, I can't seem to get my test methods to do what I think they should be doing.
comment
created
jseppi
username_0
ready for review @username_1
comment
created
jseppi
username_0
The problem I was having with tests was that I was trying to raise exceptions in the decorator, but those exceptions are not really catchable in a straightforward way. It seems that throwing decorator exceptions is not a great practice. Instead of checking arguments, I think we're covered by normal Django behaviors. For example, f a view name isn't found, then Django will through an exception somewhere else when it tries to do the reverse lookup, so I think that's ok.
comment
created
toolness
username_1
This looks good, feel free to merge it!
comment
created
jseppi
username_0
womp womp, travis failed with error `Cannot download "https://github.com/sass/node-sass/releases/download/v3.8.0/linux-x64-47_binding.node":`

Resubmitted the job
comment
created
jseppi
username_0
Lol, and now codeclimate is apparently stalled. Happy Wednesday!
comment
created
jseppi
username_0
Um, something is wrong with codeclimate. It's been running for nearly hour yet hasn't even finished checking out the code according to its status page. Given that it had a green light before the merge of #641, and #641 had its own green light, I am just going to merge this PR.

<img width="934" alt="screen shot 2016-08-31 at 3 46 43 pm" src="https://cloud.githubusercontent.com/assets/697848/18145769/26174e1c-6f92-11e6-8b1d-61da06bb3c5f.png">
comment