opened
erikphansen
username_0
## Description
I met with Jen Strickland earlier in the week to get some feedback on how we were marking up Profile 2.0 so far. This PR works in a lot of her feedback. I kept the commit history of this PR intact which serves as a bit of a punchlist of the changes that were made.

## Testing done
Local + unit tests.

## Screenshots


## Acceptance criteria
- [ ]

## Definition of done
- [ ] Events are logged appropriately
- [ ] Documentation has been updated, if applicable
- [ ] A link has been provided to the originating GitHub issue (or connected to it via ZenHub)
- [x] No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
Update Profile 2.0 markup for a11y purposes
issue
created
erikphansen
username_0
Jen basically showed me what she wanted the final markup to look like for both instances of this table (one on the new Military Info section and one on the new Account Security section) and I had to figure out how to make it work with the existing ProfileInfoComponent. We are using that table component in at least two more sections. Hopefully we won't have to make the component even crazier to account for even more differences in the final markup!
comment
created
ncksllvn
username_1
Side suggestion for some of the lengthy class lists - it could be neat to have a `styles` constant outside the JSX that does the `.join()`s before the JSX. It might make the JSX a little compact. -

```jsx
// this could also be defined outside of the component altogether
const styles = {
    tableHeading: [....headingMediumScreenSize, ...headingLargeScreensize],
   // ....
}
```
comment