opened
rht
username_0
So that the certbot nginx patch can be automatically applied after the nginx confs have be set up by puppet.
prod install: Move certbot setup to be after puppet apply.
issue
created
timabbott
username_1
@username_0 have you tested this?  I would expect this change to break the certbot feature, since `zulip-puppet-apply` will fail in the event that certs don't exist yet.  Is there a second half of this changeset that's missing?
comment
created
rht
username_0
I wasn't aware of this. Should the certbot download and setup happen within the puppet apply instead? In this case, as I had stated, there is a Puppet module that can be used https://github.com/voxpupuli/puppet-letsencrypt, depending on how elaborate the setup needs to be.
comment
created
rht
username_0
Another option is to disable the certs check within Puppet when the `--certbot` flag is activated.
comment
created
timabbott
username_1
@username_0 please don't submit pull requests that aren't tagged WIP and you haven't tested.  It wastes the time of reviewers.  

I think there's no need to move the certbot setup -- you don't need to use certbot in the same mode for renewal as you used to create the cert in the first place.  So maybe just drop that commit?
comment
created
rht
username_0
Sure, please drop that commit.
comment
created
timabbott
username_1
I opened #7285 with a version of your commit.  We should test that carefully and if it works, merge it.
comment