opened
SoLetsCode
username_0
Fixed link styles according to https://github.com/bcgov/digital.gov.bc.ca/issues/279. I went through each task and attached a gif to show that it works. I went overboard playing with some new capture software :) 

*note - header and footer links are not underlined until hovered. This seems to be the intended effect and my changes do not affect this. 
![Header 2020-10-05 at 00 42 39](https://user-images.githubusercontent.com/48116904/95053296-15cc1980-06a5-11eb-9b01-48e612ee6185.gif)

Links on white cards
![White Card 2020-10-05 at 00 43 20](https://user-images.githubusercontent.com/48116904/95053317-1c5a9100-06a5-11eb-88f2-d7da742a0823.gif)

 Links under Our Priorities on the Digital Framework page
![Our Priorities 2020-10-05 at 00 44 35](https://user-images.githubusercontent.com/48116904/95053335-2086ae80-06a5-11eb-82cb-421b92bc72d3.gif)

 Inline links on the Digital Principles page
![Digital Principles 2020-10-05 at 00 45 27](https://user-images.githubusercontent.com/48116904/95053351-267c8f80-06a5-11eb-8ad9-9f81a768cc58.gif)

 Standalone links (under Technical, Privacy, Security, and For Designers headings) on the Resources page.
![Tec Pri Sec 2020-10-05 at 00 46 10](https://user-images.githubusercontent.com/48116904/95053371-2d0b0700-06a5-11eb-85d5-4e2c1e7e3287.gif)

Linked headings under Video Communication Options heading on the Video Communication Platforms page. (Please note also: these headings are not picking up font-family: 'BC Sans'.)

-BC Sans is now applied. 
![Video Options 2020-10-05 at 00 50 56](https://user-images.githubusercontent.com/48116904/95053387-32685180-06a5-11eb-9dd8-5ef9ebd481d9.gif)

Suggestion: If we can, let's do away with all the individual classes for links (e.g. productCardLink, resourceLink, etc.)

I did not refractor these out because I was unsure how that would affect the website functionality.
standardized link styles
issue
created
SoLetsCode
username_0
I'm still not sure how to pass the OC login test.
comment
created
thegentlemanphysicist
username_1
That's by design on the project.  Only people on the team have credentials to deploy to openshift.  

Thanks for the interest on the project.  It's good to see people looking to contribute.  Unfortunately we're right in the middle of a major styling refactor. Basically we're moving all the .css files into styled-components.  It's a bit unclear how we will be able to integrate outside collaborators until it's complete.  There won't be a consistent pattern to follow until it's done, and there will be a lot of regression issues/merge conflicts. It may be best to hold off on PR's for the next little while, at least until our first release is done (3 weeks from now)
comment
created
SoLetsCode
username_0
@username_1 No problem, I will close this pull request and check back in a few weeks. All the best with the refracturing.
comment