opened
waqar-baig
username_0
Added option to pass password for pem file
Added option to pass password for pem file
issue
created
vanso-waqar
username_1
Is it ready to merge?
comment
created
calonso
username_2
Yeah, this looks good, just update the documentation of the affected methods and add a small spec that checks that the password given at the pusher is then received by `OpenSSL::PKey::RSA.new cert` call in `APNSConnection`
comment
created
calonso
username_2
How are you doing with this? Do you need any help?
comment
created
waqar-baig
username_0
Need some time. Will do it.
comment
created
calonso
username_2
Ok, cool, just let me know if you need a hand.
comment
created
waqar-baig
username_0
I believe it is ready to merge :)
comment
created
calonso
username_2
Please, rebase this branch to have it up to date with master.
comment
created
calonso
username_2
@username_0 left a couple of comments, good work apart for this. Thanks!
comment
created
calonso
username_2
@username_0 How are you doing with this? Do you need any help?
comment
created
xykox
username_3
Hi all,
will the pull request be merged  ?
comment
created
calonso
username_2
Yeah, give me a couple of hours
comment
created
calonso
username_2
Actually it needs to be @username_0 who finishes it as the code is in his fork.
@username_0 Are you up for finishing this?
TODO list:
* The JSON dump of the APNS notification has to be in ascii-8bit and I don't think `to_json`encodes using it
* Docs update to describe the new argument.

Apart from this small details this is a good feature. Cheers!
comment
created
xykox
username_3
thx :)
comment
created
waqar-baig
username_0
I had issues serializing deep ActiveRecord objects with JSON.dump.
So, I had changed it to #to_json.
Also using this same fork in my production without issues.
You guys can give it a try and merge if it works for you :)
comment
created
calonso
username_2
@username_0 You're right, I didn't read the force_encoding properly.

Could you please update the README file to include the new parameter documentation? Then I'll merge it straight away.

BTW, very glad to hear you're using the gem in production nicely! :)
comment
created
waqar-baig
username_0
I have already updated the apns.rb example for the same.
I hope you are looking for the same.
Cause readme file doesn't have code snippets.
comment
created
calonso
username_2
Sorry @username_0 I thought there were some snippets in README file. Sorry about that. 
Just left a couple of minor comments about tests and it should be ready to merge.
Great work!
comment
created
calonso
username_2
That's really cool. Thanks @username_0 for your effort.
comment
created
calonso
username_2
Travis build failed because the `Gemfile.lock`has the previous version referenced. See: [https://github.com/username_2/ruby-push-notifications/blob/master/Gemfile.lock#L4](https://github.com/username_2/ruby-push-notifications/blob/master/Gemfile.lock#L4)
Please, run `bundle update` to update the reference and that should fix it.
comment
created
calonso
username_2
@username_0 Perfect, thanks!!
comment