opened
snobu
username_0
Any complaints here?
Anything else we should enforce?
[eslint] Add newline before return and mandate curly braces
issue
created
kylon
username_1
do you mean
`if (x) {`
is now
```
if (x)
{
```

if yes, i don't like that code style :\
so many empty lines for no reason
comment
created
snobu
username_0
Updated description. No, Allman style (braces on newlines) is for C# and other serious business.
comment
created
lukaarma
username_2
Not really a fan of curly braces everywhere but since this project is getting quite big I think it's better to enforce a single stile so it's ok for me what you proposed
comment
created
snobu
username_0
Why 2? Can't find a rule for it, i'd like to enforce one empty line between functions, that would avoid a few accidents.
comment
created
kylon
username_1
+1
comment
created
lukaarma
username_2
Ok if you are going strictly by the book there no rule like that that I'm aware of, it's a wule that I imposed on myself because I found out that it made the code more readable
comment
created
snobu
username_0
Not necessarily against it, i just can't seem to find a rule for new lines between things. Did you ever enforce that in eslint?
comment
created
lukaarma
username_2
Nope, sorry
Never enforced it with any linting tool
comment
created
snobu
username_0
TO DO (until we merge this in):
* Add eslint to npm scripts `npm run lint`
* Amend the code so it lints cleanly
* Amend GitHub Action to run linting as well
comment