opened
DanielRuf
username_0
Currently the gutters are included in the width calculation even if `$gutter-output` is set to `false`.
This should not be the case.

Closes https://github.com/zurb/foundation-sites/issues/11059
fix: respect $gutter-output in the -xy-cell-properties mixin
issue
created
DanielRuf
username_0
Applied the proposed change by @username_1
comment
created
DanielRuf
username_0
How should the commit message / title be / look like?
comment
created
ncoden
username_1
Well something like:

````
feat: ignore `gutter-output` for margin grid in `xy-cell` mixins

`gutter-output` cannot be set to `false` for margin grid as the gutter (margin)
is defined with the width. Gutters can only be set or reset to 0, which does
not fullful the role of `gutter-output`.

See discussion at https://github.com/zurb/foundation-sites/pull/11081

**BREAKING CHANGE**

Before:
```scss
@include xy-cell(12, $gutter-type: margin, $gutter-output: false);
@include xy-cell-static(full, $gutter-type: margin, $gutter-output: false);
```

After
```scss
@include xy-cell(12, $gutter-type: margin, $gutters: 0);
@include xy-cell-static(full, $gutter-type: margin, $gutters: 0);
```

Co-authored-by: Nicolas Coden <nicolas@username_1.fr>
````

What do you think ? ;)
comment
created
DanielRuf
username_0
Done.
comment
created
ncoden
username_1
Teamwork 🎉 

![screen shot 2018-04-30 at 10 07 37](https://user-images.githubusercontent.com/9939075/39419099-6a9e297a-4c5e-11e8-8c1b-b0369a0a14c2.png)

Thank you @username_0 @username_2
comment
created
ncoden
username_1
https://github.com/username_0/foundation-sites/blob/828481aa8eb67258a53c3a68ba41221388ce0045/scss/xy-grid/_cell.scss#L98

Documentation must be updated to mention this behavior. Like `ignored for margin gutters`.
comment
created
SassNinja
username_2
I agree regarding the documentation update:
Maybe something as `Whether or not to output gutters when using padding gutter type. Always true for margin.` ?
comment
created
ncoden
username_1
@username_2 Could you review this ?
comment
created
SassNinja
username_2
LGTM @username_1

I've tested it with padding & margin and it works as expected 👍
comment