opened
itaysk
username_0
implements https://github.com/istio/api/pull/709
fix https://github.com/istio/istio/issues/9595
New header manipulation API
issue
created
rshriram
username_1
/ok-to-test
comment
created
rshriram
username_1
High level comment: if the appendFlag was recently introduced (after Istio 1.0, which is most likely), please guard the config generation pieces with a proxy version check, so that for 1.0 proxies, its only append/remove, while for 1.1 proxies, its set/append/remove [if and only if this functionality didn't exist by Istio 1.0 (around June).
comment
created
GregHanson
username_2
/test e2e-dashboard
comment
created
GregHanson
username_2
/test e2e-dashboard
comment
created
rshriram
username_1
Can you sync your branch to release 1.1 fully and see if the test failure goes away?

@douglas-Reid any idea why this dashboard test is failing for unrelated code?
comment
created
itaysk
username_0
Rebased
comment
created
GregHanson
username_2
/approve
/lgtm
comment
created
hklai
username_3
/retest
comment
created
GregHanson
username_2
/test e2e-dashboard
comment
created
GregHanson
username_2
/test istio-pilot-e2e-envoyv2-v1alpha3
comment