opened
mgpeter
username_0
See: #12 , #10 

This pull request is initially just a request for review, I don't fully expect it to be merged in straight away,  rather after some discussion and fixes on my part; I'd appreciate if it happens though : )

Covered changes

 * Add [SpreadsheetExcludeFromOutput] attribute. This works along the ExcludeFromOutput fllag in tabnames for now. Ideally I feel TabName and Exclude attributes should be used separately to follow SRP, also "cohesion, not coupling" (so that the exclude flag should be dropped from name attribute if we are actually to include my suggested changes in the library
 * update the solution to VS 2015, might need revert - depends on further decision by @username_1 
 * refactor the code a little to deduplicate logic for passing IEnumerables to work sheets
 * allow adding data to existing excel packages through AddData(ref ExcelPackage package, IEnumerable ...). One might question the *ref* usage, decided on this to make sure that implementors and clients are aware that passed excel package is being changed after all.
 * add unit test for exclude from output, refactor unit tests a little.
ExcludeFromOutput and small refactorings
issue
created
bradwestness
username_1
I feel like there's too much going on in this PR for me to feel comfortable merging it. If you check the [contributing guidelines document](https://github.com/username_1/EPPlusEnumerable/blob/master/CONTRIBUTING.md), I've requested that PR's include only one "unit of work," i.e. I'd love it if you could submit separate pull requests for the attribute, the refactoring, the VS2015 upgrade, etc.
comment
created
mgpeter
username_0
hey @username_1 thanks for quick response. That's not a problem and I will do so. Just couldn't allocate more time to it that weekend before actually having a discussion to see if we are on the same page here.

Will properly divide the pull request this week I think.

In the meantime, can you take a moment to think about what is basically your opinion in regards to the following:

 - Unit Tests - I can introduce BDD style tests with SpecFlow further on if you want ( http://www.specflow.org/getting-started/ ). I already see few scenarios when it would be beneficial for the project, basically saving time needed to write subsequent tests. It would allow to use "steps" as building blocks for bigger test scenarios. I can elaborate more if needed.
 - VS2015/VS2013 and nuGet - are you ok with going the automatic nuget restore way so that we can drop the nuget.exe ? ( http://www.xavierdecoster.com/migrate-away-from-msbuild-based-nuget-package-restore )
 - is "adding data to existing excel package" a desired functionality in your opinion? I thought so as I need it in the customer's solution. What do you think about exposing it, as it might seem like providing more access to clients of the code? However we are going to isolate the internal logic from the public method.
comment