opened
jpivarski
username_0
Reverts scikit-hep/uproot#202
Revert "Use Binder build API and remove trigger_binder.py and selenium dependency"
issue
created
jpivarski
username_0
@username_1: This is a PR to reverse the changes. I'm going to make you an uproot contributor so that you can edit this one directly.
comment
created
matthewfeickert
username_1
@username_0 Thanks. I'm following up with the Binder team about this one at the moment. It is strange that it is getting caught up like it is.
comment
created
jpivarski
username_0
I'm going to merge this PR so that I have a working version to test things against. You can open a new PR when you hear back from the Binder team.

Also, I think we can test these by doing an explicit "Trigger build" in Travis; that's what I'll do next time before merging into master.

And above all, thanks!
comment
created
matthewfeickert
username_1
Yeah, I usually just create a branch that I'll delete later from the PR branch and then modify the CI on it to trigger the whole CI to make sure it works the way I was thinking. Since I didn't have permissions to start a CI build on a non-PR branch before I didn't attempt that here before requesting your review.
comment
created
jpivarski
username_0
I mean, that's something I'd have to do. I did a merge earlier because I didn't know of this option, but now I do and that's how I'll do it.
comment