opened
sheamusburns
username_0
Successfully works on most endpoints 👍 
<img width="495" alt="p5_js___get_started" src="https://user-images.githubusercontent.com/8462408/37987272-b7cffb22-31cb-11e8-9d02-d3cf369710fa.png">

Bug: Still doesn't work on the /reference endpoint. I tried digging around to see if I could figure out how that page gets assembled, but no luck. If you can give me a sense of the structure, I can go in and add the `<link>` in the proper places.

<img width="448" alt="p5_js___reference" src="https://user-images.githubusercontent.com/8462408/37987416-220edbe8-31cc-11e8-94c6-a0dc3b48cc7e.png">
add asterisk favicon
issue
created
awarua
username_1
@username_0 - I believe that the reference endpoint is not generated within the project, but comes from the following static html file: `/dist/reference/index.html`.  So, if you add your lines to link to the favicon in there, it should show up (you'll have to put the path to the file directly).

```
<link rel="shortcut icon" href="/assets/img/favicon.ico">
<link rel="icon" href="/assets/img/favicon.ico">
```

**However**, this might not be a good long-term solution. @username_2 commented on another issue #38 that the reference page is generated from the following template in the main p5.js repository https://github.com/processing/p5.js/blob/master/docs/yuidoc-p5-theme/layouts/main.handlebars

So I guess when that gets updated, any changes you make to the static reference index.html page will be lost? 

I'm still not very familiar with the project & don't know the history of how the reference ended as a static file. I think it has to do with the challenges of translating from the source code generated documentation. There's some discussion of that in the [README](https://github.com/processing/p5.js-website/blob/master/README.md) under the 'JSON (reference)' section.
comment
created
awarua
username_1
@username_0 - I have been trying more to understand how this works, and I think the right place to make the change to add the favicon to the reference pages is to the [main.handlebars](https://github.com/processing/p5.js/blob/master/docs/yuidoc-p5-theme/layouts/main.handlebars) file in the p5.js repository.
comment
created
sheamusburns
username_0
@username_1 Thanks Jared, 
That's super helpful; I was confused by that JSON reference section and didn't think to look in the P5js project for that src. You're definitely right about the main.handlebars file -- once there it was a simple fix. 

[PR #2786 in Processing/p5.js](https://github.com/processing/p5.js/pull/2786) should resolve the issue where the favicon doesn't load with the on the reference site.
comment
created
lmccart
username_2
thanks!
comment