opened
lyrixx
username_0
fixes #1086
Fixed PhpdocShortDescriptionFixer for text ending by :
issue
created
GrahamCampbell
username_1
Massive :-1: from me.
comment
created
GrahamCampbell
username_1
Ending a short description in colon is NOT valid.
comment
created
GrahamCampbell
username_1
Otherwise your long description starts from the things after the colon, which would be silly.
comment
created
keradus
username_2
On the first look - yeah, `:` is not valid end of short descr.

On the second look - if `:` is invalid then we should not touch it...
comment
created
GrahamCampbell
username_1
No, this fixer is really useful because it highlights broken descriptions for people. It was really useful when I made that pull to symfony when I was regression testing this fixer originally, because it allowed me to manually rewrite some of their docblocks that were totally wrong.
comment
created
keradus
username_2
That way we could also allow crashes and creating invalid syntax.
Purpose of this tool is to **fix** things without participation of user, not to **highlights** problems.

I remembed that we one day remove all warns etc that do not fix anything.
comment
created
GrahamCampbell
username_1
:(

People will just move to phpcs if we do that, that's not really what we want, because people will just use their autofixer too.
comment
created
keradus
username_2
Not sure about that. phpcs has completely different approach.
Didn't we decided to drop warns after release of phpcbf ?
And to be honest... we are capable to fix almost 100% issues that we can detect so far...
comment
created
keradus
username_2
Closing due to discussion
comment