opened
velo
username_0
So, I created a PR to merge my fork back to this project!

Someone wouuld need to review (specially the poms) to make sure I do not killed something.

I renamed all packages and groupIds to net.revelec.code

Cheers
Revelc
issue
created
velo
username_0
````
The log length has exceeded the limit of 4 Megabytes (this usually means that test suite is raising the same exception over and over).

The build has been terminated.
````

Any chance to move to shippable? My build works like a charm there....
https://app.shippable.com/builds/55ac65c36507280b00fb072e
comment
created
hazendaz
username_1
I've got an idea that might this easier to pull in.  At the moment we are both highly diverted over at least a year while a lot is still common.  If I create a branch and you do a PR there, I'll merge.  Then I'll attempt what I assume will be a fun 'rebase'.  This way duplicate commits and or unnessary ones can be removed.  All your changes will float on top.


One other thing I'd like to check out after this.  I read m2e connectors are no longer needed.  The plugins can be self registered now.  Maybe we can have both for legacy users.


Thoughts?


Sent by Outlook for Android
comment
created
hazendaz
username_1
Maybe you already rebased.  I notice dates only go back a few months now.  If so just confirm...I can review maven stuff.  Only thing that concerns me is svn noted commits...but if rebased already it is what it is ;)


Sent by Outlook for Android
comment
created
ctubbsii
username_2
I merged this PR into a branch called 'username_0-merge'. I'll leave the review and incremental/selective merging to master up to you guys, though if I get a chance, I might jump in and help with the review.
comment
created
velo
username_0
@username_1 yes, I already rebased it....

originally, my fork was an independent project that I cloned from code.google svn....

When the source showed up on github, I killed mine, forked the github project and the re applied all my changes (git cherry-pick FTW)


@username_2 no problem, we just need to get it merged back to master before master start diverging...
comment