opened
tombsar
username_0
The contribution guide at ".github/CONTRIBUTING.md" is currently incomplete. In particular it is missing real content for the "Contributing a bug fix" and "Contributing a feature" sections.

It would be useful to know if you welcome PRs for trivial fixes, or if they are too much hassle to review, etc!
glfw contribution guide is incomplete
issue
created
elmindreda
username_1
It definitely is incomplete. Now that 3.2 is out, I'll be working on non-code things like this for a while.

To answer your specific question, I absolutely welcome trivial PRs!
comment
created
elmindreda
username_1
The bug report section should be somewhat usable now. Starting on these now.
comment
created
elmindreda
username_1
I still have some things to add, but what do you think is still missing?
comment
created
CaffeineViking
username_2
Personally, I think it looks really good. Also, love the table of contents at the top, really easy to find the information you're looking to make sure everything looks good. Honestly, the only addition I can think of would be a small coding style guide, so a contributor can basically double-check the commit before pull request for compliance. But i don't know if it's really necessary though, one can usually infer from code. Great work with the documentation in general @username_1! Keep up the good work!
comment
created
tombsar
username_0
LGTM! Seconding the request for a code style guide (possibly a separate document?), but otherwise pretty much complete.

Maybe mention somewhere in the "contributing" sections that glfw is written in C90 (or whatever version it uses; I couldn't find it with a quick search), so C++ code will not be accepted?

There are a couple of language things I would suggest (e.g. replacing "i.e." with "e.g." throughout), but those are style not content.
comment
closed
elmindreda
username_1
issue
created
elmindreda
username_1
Thank you.

Coding style will have to be a separate effort.
comment