opened
donguyenvt
username_0
Hello,

Here is my submission for the third assignment of the class Swift@CoderSchool.vn. Thank you.

Again, I cannot upload the app folder either in GitHub Desktop or Web. So, I put it under a zip file.

Nguyen Do
/cc @coderschoolreview
Assignment 3 Swift Submission
issue
created
donguyenvt
username_0
Oops! I just find out that the source code I uploaded here when I was in the middle of implementing the Infinite Scroll feature. So it won't be successfully built unless you remove the tableView.addInfiniteScrollWithHandler in the TweetsViewController.swift. I will fix this later tonight.

Regards/Nguyen Do
/cc @coderschoolreview
comment
created
minhchau273
username_1
:+1: nice work. The point of this homework was to explore a simple example of a full MVC application with a RESTful API. 


## Grading Summary:
* **Functionality**: Good
* **Code Style**: Good
* **Visual Design**: Average
* **Usability**: Good

#### **Overall**: Good


## Detailed Notes
* Note that you should resolve all the Auto Layout constraint warnings in your nibs.
* Note that you should try handling the conditionally present retweet label in the cells. This is a situation where it's not possible to specify the behavior by only the Interface Builder.
* You should try setting up the controls within the Tweet cells. It can sometimes be hard to have a clean design for embedded controls because it usually involves cumbersome plumbing. This is an instance where I think having the model handle the network action helps greatly simplify the implementation.
* You should try implementing the post tweet insertion into the feed. In real MVC apps, the more polished experiences have to do a certain amount of local object management to make a fully seamless experience.
* It'd be better if you show an alert when the new tweet cannot be post, for example in case the context is too long (>140 characters).
* You can use a `UITextView` instead of `UITextField` in `ComposeViewController` so that user can see the whole long content.
comment