opened
saurav2608
username_0
- [ ] closes #xxxx
- [ ] tests added / passed
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry

Pushing this code to check if this clears CI. Made a few changes towards issue #23791
DOC: Reordered import to conform to PEP8 standards.
issue
created
datapythonista
username_1
@username_0 in general try to not open the pull requests until you're done. You can push to your remote branch, but if you open a PR, someone will review it, and it's a waste of time if your changes are not finished (unless you need a review to make sure what you're doing is correct...)
comment
created
saurav2608
username_0
@username_1 -  I will keep this in mind henceforth. I will edit the .rst file over the weekend.
comment
created
datapythonista
username_1
@username_0 do you have time to address the comments?
comment
created
saurav2608
username_0
I got swamped by some other work. I can take this up on Wednesday.
comment
created
saurav2608
username_0
comment
created
jreback
username_2
can you rebase
comment
created
saurav2608
username_0
@username_2 : Unfortunately, I am not able to. I messed up at some point and now rebase and squash generates conflict errors that I am not resolve it with my knowledge of git. 

I am open to ideas on how to squash the commit. In the worst case, I can delete the branch and start again.
comment
created
datapythonista
username_1
just do a `git fetch upstream && git merge upstream/master` edit the file with the conflict, keep the lines that arr ok, and leave the file how it has to be, do a `git add` of the file, commit and push
comment
created
saurav2608
username_0
I am not sure if this worked.
comment
created
saurav2608
username_0
It did not. Somehow an old version of the file was pushed.
comment
created
datapythonista
username_1
Can you take a look at the first section of: https://username_1.github.io/blog/useful-git-commands.html
comment
created
saurav2608
username_0
@username_1 - I followed your post. But if I try to push I get below error. Should I pull one before pushing? 
`  ! [rejected]            io-doc -> io-doc (non-fast-forward)
error: failed to push some refs to 'https://github.com/username_0/pandas.git'
hint: Updates were rejected because the tip of your current branch is behind
hint: its remote counterpart. Integrate the remote changes (e.g.
hint: 'git pull ...') before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.`
comment
created
saurav2608
username_0
This is done I think. I forced a push on my forked repo.
comment
created
datapythonista
username_1
@username_0 can you do in this PR branch: `git fetch upstream && git merge upstream/master && git push` please

I'm not sure why the CI is failing, I think it shouldn't, but hopefully updating the branch will fix it.
comment
created
pep8speaks
username_3
Hello @username_0! Thanks for updating the PR.

 - There are no PEP8 issues in the file [`asv_bench/benchmarks/categoricals.py`](https://github.com/username_0/pandas/blob/aaa6b77144c1fe1ce5794527befeaf1b9d6cc149/asv_bench/benchmarks/categoricals.py) !

 - There are no PEP8 issues in the file [`pandas/core/arrays/categorical.py`](https://github.com/username_0/pandas/blob/aaa6b77144c1fe1ce5794527befeaf1b9d6cc149/pandas/core/arrays/categorical.py) !

 - There are no PEP8 issues in the file [`pandas/core/indexes/category.py`](https://github.com/username_0/pandas/blob/aaa6b77144c1fe1ce5794527befeaf1b9d6cc149/pandas/core/indexes/category.py) !

 - There are no PEP8 issues in the file [`pandas/core/reshape/tile.py`](https://github.com/username_0/pandas/blob/aaa6b77144c1fe1ce5794527befeaf1b9d6cc149/pandas/core/reshape/tile.py) !

 - There are no PEP8 issues in the file [`pandas/tests/reshape/test_tile.py`](https://github.com/username_0/pandas/blob/aaa6b77144c1fe1ce5794527befeaf1b9d6cc149/pandas/tests/reshape/test_tile.py) !

 - There are no PEP8 issues in the file [`pandas/tests/util/test_hashing.py`](https://github.com/username_0/pandas/blob/aaa6b77144c1fe1ce5794527befeaf1b9d6cc149/pandas/tests/util/test_hashing.py) !
comment
created
datapythonista
username_1
@username_0 looks like the PR contains unrelated changes again. Not sure what is causing this, I don't think the command I wrote causes it. But in any case, can you repeat what you did before to fix the history and leave only your changes in the PR please.
comment
created
saurav2608
username_0
I redid the PR. this look okay now. Please review once and let me know.
comment
created
saurav2608
username_0
@username_1  - no problem. It took long for my to fix this. Thank for your guidance. There are still some issues to resolve. For example suppressing `E402 module level import not at top of file` type errors where the import is deliberately kept at that location. I can work on those once these changes are merged.
comment
created
datapythonista
username_1
No worries @username_0, we all do what we can, and it also takes time for us to review.

I don't think we want to fix the `E402`, but make `flake8-rst` not report them as errors. I think it's better for users to have the imports in the block where they are used.

And don't worry much if not everything is fixed. There are so many things to fix at this point, that any fixes are very useful. Once most of the stuff is fixed, then we'll check more in detail the outstanding problems.

If you're looking for other things to contribute, it's probably better to wait until #23847 is merged to work on the rest of the `.rst` files, as it's a bit difficult to follow right now what is done, what's in progress, and what needs to be done. After that PR is merged, I'll create issues for the pages that need fixes, and it'll be easier.

One related issue that can be address and would be very useful to have implemented soon would be #23952.
comment
created
jreback
username_2
@username_0 can you rebase and remove io.rst from the setup.cfg
comment
created
datapythonista
username_1
@username_2 if you want to merge this, I'll open a PR with the fixed files, and I'll add this one too.
comment
created
jreback
username_2
thanks @username_0 

@username_1 go for it
comment