opened
at7
username_0
I updated the path to use the release version. This will be important to get the correct data when checking archive sites.
use release version
issue
created
ens-ma7
username_1
@username_0 but that means for each release we will have to update the path?
comment
created
at7
username_0
The data is not static and compara includes new species every release. If we keep updating the release version and the new new name of the alignment directory (from 75_mammals.gerp_conservation_score in release-95 to 88_mammals.gerp_conservation_score in release-96) we will be backwards compatible for archive sites. They might not always increase but I think this way we are safe?
comment
created
ens-ap5
username_2
Given that the first part of the URL is identical in each species ('ftp://ftp.ensembl.org/pub/current_compara/conservation_scores/'), it would make sense to generate it in the code that consumes the JSON, instead of having the full path hard-coded. Then we wouldn't need to update it every release, just when the number of mammals in the GERP alignment changes.
comment
created
at7
username_0
I like that. Shall we create a ticket for this for next time or is there time do it for 96? I can adjust the paths accordingly in the config files.
comment
created
ens-ap5
username_2
It should be a simple change. Put in a ticket now and I'll pick it up, like we did for the vervet variation link.
comment
created
at7
username_0
Here is the ticket: https://www.ebi.ac.uk/panda/jira/browse/ENSWEB-4943
Thank you
comment
created
ens-ma7
username_1
Thanks @username_2, i was going to suggest the same thing, you are too quick in responding, i was confused, i thought i was replying on an all PR.

I will leave this PR open until you have your changes in @username_2 , feel free to close it once you are happy.
comment
created
ens-ap5
username_2
Sorry, I thought I'd chime in since I saw an obvious solution :)
comment
created
ens-ma7
username_1
No problem at all, its just that within 5 minutes there was like 4 comments on the PR :) anyway its all yours now :)
comment
created
at7
username_0
Is this what you had in mind? If yes, I will update the other species as well.
comment
created
ens-ap5
username_2
Yes, that's perfect!
comment