opened
oodamien
username_0
Resolves #786
Stream Deploy: avoid resubmitting apps form values
issue
created
ghillert
username_1
Looks like this is not working, yet. I created the following stream `t3`:

`http --server.port=9900 | splitter --expression=payload.split(' ') | log`

Went to the deployment page `http://localhost:4200/#/streams/definitions/t3/deploy`

![image](https://user-images.githubusercontent.com/685363/40397714-d8238bc0-5dcf-11e8-9c11-9bcd1356b6be.png)

Made no changes. Only pressed `Deploy the Stream`.  Does not work for freetext option either.

Looks like we create this strange property `app.splitter.splitter.expression` (see duplication of `splitter`)
comment
created
ghillert
username_1
@username_0 Something is strange. I created a stream:

![image](https://user-images.githubusercontent.com/685363/40452677-5f6bfbfe-5e7e-11e8-803e-121deca5fa2c.png)

We don't handle the use-case where no value changed. In that case the `update` REST endpoint will send back an error: `Package to upgrade has no difference than existing deployed/deleted package. Not upgrading`. Therefore, we should only activate the `Deploy the Stream` button

![image](https://user-images.githubusercontent.com/685363/40452846-f75dc62c-5e7e-11e8-9322-987f880c7e48.png)

only, if anything has changed.
comment
created
ghillert
username_1
The shell does not resend the following properties:

* deployer.log.count=1
* version.http=1.3.1.RELEASE
* version.log=1.3.1.RELEASE

unless you specify them.
comment
created
ghillert
username_1
It looks like for the time being, we will always submit the properties in Skipper mode. For following stream updates we would always need to submit the properties because we would not know, if the value shown was the initial value (version `1`) or not. We would need to compare the stream to the initial version of the Stream in order to determine whether a property had changed or not.

With that the PR looks good for the changes it does add (using the Stream update REST endpoint).
comment
created
ghillert
username_1
Created https://github.com/spring-cloud/spring-cloud-dataflow-ui/issues/789 as a follow up.
comment
created
ghillert
username_1
Merged with commit 161c4e5151a36be687e1602f898a93887b2ca81f
comment
created
ilayaperumalg
username_2
This needs to be back ported to 1.5.x branch.
comment
created
ilayaperumalg
username_2
Back ported the changes 2ea34a6efa4c8a60b62118a44ef021286dc68500
comment