opened
rgrinberg
username_0
Embed build informations inside executable

- Project page: <a href="https://github.com/ocaml/dune">https://github.com/ocaml/dune</a>
- Documentation: <a href="https://dune.readthedocs.io/">https://dune.readthedocs.io/</a>

##### CHANGES:

- Make `patdiff` show refined diffs (ocaml/dune#4257, fixes ocaml/dune#4254, @hakuch)

- Fixed a bug that could result in needless recompilation under Windows due to
  case differences in the result of `Sys.getcwd` (observed under `emacs`).
  (ocaml/dune#3966, @nojb).

- Restore compatibility with Coq < 8.10 for coq-lang < 0.3 , document
  that `(using coq 0.3)` does require Coq 8.10 at least (ocaml/dune#4224, fixes
  ocaml/dune#4142, @ejgallego)

- Add a META rule for 'compiler-libs.native-toplevel' (ocaml/dune#4175, @altgr)

- No longer call `chmod` on symbolic links (fixes ocaml/dune#4195, @dannywillems)

- Dune no longer automatically create or edit `dune-project` files
  (ocaml/dune#4239, fixes ocaml/dune#4108, @username_3)

- Have `dune` communicate the location of the standard library directory to
  `merlin` (ocaml/dune#4211, fixes ocaml/dune#4188, @nojb)

- Workaround incorrect exception raised by Unix.utimes (OCaml PR#8857) in
  Path.touch on Windows (ocaml/dune#4223, @dra27)

- `dune ocaml-merlin` is now able to provide configuration for source files in
  the `_build` directory. (ocaml/dune#4274, @voodoos)

- Automatically delete left-over Merlin files when rebuilding for the first time
  a project previously built with Dune `<= 2.7`. (ocaml/dune#4261, @voodoos, @aalekseyev)

- Fix `ppx.exe` being compiled for the wrong target when cross-compiling
  (ocaml/dune#3751, fixes ocaml/dune#3698, @toots)

- `dune top` correctly escapes the generated toplevel directives, and make it
  easier for `dune top` to locate C stubs associated to concerned libraries.
  (ocaml/dune#4242, fixes ocaml/dune#4231, @nojb)

- Do not pass include directories containing native objects when compiling
  bytecode (ocaml/dune#4200, @nojb)
[new release] dune-build-info, dune, dune-configurator, dune-site, dune-action-plugin, dune-private-libs and dune-glob (2.8.3)
issue
created
camelus
username_1
Commit: 26052da07faeadc251669076a8c0688033566446

A pull request by opam-seasoned @username_0.

##### :sunny: All lint checks passed <small>26052da07faeadc251669076a8c0688033566446</small>

* These packages passed lint tests: `dune-action-plugin.2.8.3`, `dune-build-info.2.8.3`, `dune-configurator.2.8.3`, `dune-glob.2.8.3`, `dune-private-libs.2.8.3`, `dune-site.2.8.3`, `dune.2.8.3`


---


##### :sunny: Installability check (+7)

* new installable packages (7): `dune.2.8.3` `dune-action-plugin.2.8.3` `dune-build-info.2.8.3` `dune-configurator.2.8.3` `dune-glob.2.8.3` `dune-private-libs.2.8.3` `dune-site.2.8.3`
comment
created
kit-ty-kate
username_2
dune fails to compile with:
```
#=== ERROR while compiling dune.2.8.3 =========================================#
# context              2.0.8 | linux/x86_64 | ocaml-base-compiler.4.08.1 | file:///src
# path                 ~/.opam/4.08/.opam-switch/build/dune.2.8.3
# command              ~/.opam/4.08/.opam-switch/build/dune.2.8.3/./dune.exe build -p dune --profile dune-bootstrap -j 47
# exit-code            1
# env-file             ~/.opam/log/dune-16-9088e2.env
# output-file          ~/.opam/log/dune-16-9088e2.out
### output ###
# Internal error, please report upstream including the contents of _build/log.
# Description:
#   ("Map.add_exn: key already exists", { key = "compiler-libs.toplevel" })
# Raised at file "src/stdune/code_error.ml", line 9, characters 30-62
# Called from file "map.ml", line 281, characters 18-28
# Called from file "map.ml", line 289, characters 21-33
# Called from file "map.ml", line 289, characters 21-33
# Called from file "src/dune_rules/findlib/findlib.ml", line 460, characters
#   8-70
# Called from file "list.ml", line 121, characters 24-34
# Called from file "src/dune_rules/findlib/findlib.ml", line 473, characters
#   6-79
# Called from file "src/dune_rules/findlib/findlib.ml" (inlined), line 491,
#   characters 4-105
# Called from file "src/dune_rules/findlib/findlib.ml", line 536, characters
#   28-50
# Called from file "src/dune_rules/findlib/findlib.ml", line 568, characters
#   14-43
# Called from file "src/dune_rules/findlib/findlib.ml", line 574, characters
#   11-59
# Called from file "src/dune_rules/lib.ml", line 1795, characters 14-39
# Called from file "src/dune_rules/lib.ml", line 1247, characters 10-25
# Called from file "src/dune_rules/lib.ml", line 1261, characters 21-49
# Called from file "src/dune_rules/lib.ml", line 1261, characters 21-49
# Called from file "src/dune_rules/lib.ml", line 1239, characters 10-38
# Called from file "src/dune_rules/lib.ml", line 1357, characters 25-72
# Called from file "list.ml", line 121, characters 24-34
# Called from file "src/dune_rules/lib.ml", line 1339, characters 6-1023
# Called from file "src/dune_rules/lib.ml" (inlined), line 1139, characters
#   9-96
# Called from file "src/dune_rules/lib.ml", line 1138, characters 6-125
# Called from file "src/dune_rules/lib.ml", line 1822, characters 10-61
# Called from file "src/dune_rules/odoc.ml", line 669, characters 17-104
# Called from file "src/stdune/list.ml", line 19, characters 12-15
# Called from file "list.ml", line 103, characters 22-25
# Called from file "src/stdune/list.ml" (inlined), line 5, characters 19-33
# Called from file "src/stdune/list.ml", line 40, characters 29-39
# Called from file "src/dune_rules/odoc.ml" (inlined), line 662, characters
#   7-549
# Called from file "src/dune_rules/odoc.ml", line 661, characters 6-563
# Called from file "map.ml", line 295, characters 20-25
# Called from file "src/stdune/exn.ml", line 12, characters 8-11
# Re-raised at file "src/stdune/exn.ml", line 18, characters 4-11
# Called from file "src/memo/implicit_output.ml", line 119, characters 4-162
# Called from file "src/dune_engine/rules.ml" (inlined), line 188, characters
#   20-71
# Called from file "src/dune_engine/rules.ml", line 191, characters 20-33
# Called from file "src/dune_engine/build_system.ml", line 405, characters
#   23-41
# Called from file "src/dune_rules/gen_rules.ml", line 434, characters 2-387
# Called from file "src/fiber/fiber.ml", line 129, characters 18-21
# 
# I must not crash.  Uncertainty is the mind-killer. Exceptions are the
# little-death that brings total obliteration.  I will fully express my cases. 
# Execution will pass over me and through me.  And when it has gone past, I
# will unwind the stack along its path.  Where the cases are handled there will
# be nothing.  Only I will remain.
```
comment
created
rgrinberg
username_0
@nojb did you encounter this before?
comment
created
jeremiedimino
username_3
@username_0 this was fixed in https://github.com/ocaml/dune/pull/4249
comment
created
rgrinberg
username_0
We'll release 2.8.4 with the additional fix.
comment
created
mseri
username_4
Should we close this in favour of 2.8.4?
comment
created
mseri
username_4
Perfect, thanks. In the meantime the other PR was also merged
comment