opened
mattzeunert
username_0
<!-- Thank you for submitting a pull request! -->

**Summary**

Throttling rate is in kilobits not kilobytes.

LH uses a bandwidth of 1638kbps/1.6mpbs by default, so we should recommend using that with comcast too.
docs: fix throttling rate comment and tweak comcast bandwidth
issue
created
paulirish
username_1
the throttling.md change works for me.

But I'm not sure about the kilobytes => kilobits change. 

But looking at tcp-connection i'm getting even more confused..

https://github.com/GoogleChrome/lighthouse/blob/5865c873776b975a2c25632bc6a17c07b3c0050b/lighthouse-core/lib/dependency-graph/simulator/tcp-connection.js#L47

^ @username_2 why divide by 8? should this be called `bitsPerSecond` instead?
comment
created
paulirish
username_1
Took another look and Lantern is good. Also confirmed that DevTools's `emulateNetworkConditions` speaks in **bytes** per second. 

That leads me to wonder why we never convert our configuration value... My best guess is it's somehow wrapped up in the `DEVTOOLS_THROUGHPUT_ADJUSTMENT_FACTOR` but that seems very odd...  @username_2 plz tell me i'm being really dumb here. :)
comment
created
patrickhulce
username_2
We do convert our numbers before sending to DevTools

https://github.com/GoogleChrome/lighthouse/blob/5865c873776b975a2c25632bc6a17c07b3c0050b/lighthouse-core/lib/emulation.js#L107-L110

Nice catch @username_0 yeah the lowercase `b` in `Kbps` was meant to be the signal for `kilobits per second`, not sure how we messed that doc string up 😆
comment