opened
DeeJayElly
username_0
This PR fixes Address validation on Shelley QA Network

## Screenshots

<img width="1148" alt="Screen Shot 2020-10-27 at 6 16 28 PM" src="https://user-images.githubusercontent.com/15862062/97337436-92a37b00-1880-11eb-8619-a300e773867a.png">
<img width="1149" alt="Screen Shot 2020-10-27 at 6 16 00 PM" src="https://user-images.githubusercontent.com/15862062/97337450-9800c580-1880-11eb-864f-dd9549c5ce32.png">


---

## Testing Checklist

- [Slack QA thread](https://input-output-rnd.slack.com/archives/GGKFXSKC6/p1603819038247400)

---

## Review Checklist

### Basics

- [ ] PR has been assigned and has appropriate labels (`feature`/`bug`/`chore`, `release-x.x.x`)
- [ ] PR is updated to the most recent version of the target branch (and there are no conflicts)
- [ ] PR has a good description that summarizes all changes
- [ ] PR has default-sized Daedalus window screenshots or animated GIFs of important UI changes:
  - [ ] In English
  - [ ] In Japanese
- [ ] CHANGELOG entry has been added to the top of the appropriate section (*Features*, *Fixes*, *Chores*) and is linked to the correct PR on GitHub
- [ ] Automated tests: All acceptance and unit tests are passing (`yarn test`)
- [ ] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in *development* build (`yarn dev`)
- [ ] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in *production* build (`yarn package` / CI builds)
- [ ] There are no *flow* errors or warnings (`yarn flow:test`)
- [ ] There are no *lint* errors or warnings (`yarn lint`)
- [ ] There are no *prettier* errors or warnings (`yarn prettier:check`)
- [ ] There are no missing translations (running `yarn manage:translations` produces no changes)
- [ ] Text changes are proofread and approved (Jane Wild / Amy Reeve)
- [ ] Japanese text changes are proofread and approved (Junko Oda)
- [ ] UI changes look good in all themes (Alexander Rukin)
- [ ] Storybook works and no stories are broken (`yarn storybook`)
- [ ] In case of dependency changes `yarn.lock` file is updated

### Code Quality
- [ ] Important parts of the code are properly commented and documented
- [ ] Code is properly typed with flow
- [ ] React components are split-up enough to avoid unnecessary re-renderings
- [ ] Any code that only works in main process is neatly separated from components

### Testing
- [ ] New feature/change is covered by acceptance tests
- [ ] New feature/change is manually tested and approved by QA team
- [ ] All existing acceptance tests are still up-to-date
- [ ] New feature/change is covered by Daedalus Testing scenario
- [ ] All existing Daedalus Testing scenarios are still up-to-date

### After Review
- [ ] Merge the PR
- [ ] Delete the source branch
- [ ] Move the ticket to `done` column on the YouTrack board
- [ ] Update Slack QA thread by marking it with a green checkmark
[DDW-376] Fix address validation on shelley qa network
issue
created
gnpf
username_1
@username_0 this is working well. I was wondering if the same issue with Staging is going to be addressed on this PR too.
@username_3 [mentioned it happens there as well.](https://jira.iohk.io/browse/DDW-376?focusedCommentId=26027&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-26027)
comment
created
nikolaglumac
username_2
@username_0 please check this 🙏
comment
created
nikolaglumac
username_2
@username_0 I have added one more TODO for you:
![Screenshot 2020-10-29 at 10 46 34](https://user-images.githubusercontent.com/376611/97552037-0d30df80-19d4-11eb-8798-6620d0f9dadd.png)

cc @username_3
comment
created
DeeJayElly
username_0
Fix is added for network tag
comment
created
alan-mcnicholas
username_3
Address validation is now working on staging, great work @username_0 ! :)
comment
created
nikolaglumac
username_2
Thanks @username_3! Did you also make sure non-staging addresses are rejected? E.g. the mainnet ones?

cc @username_1 @ManusMcCole @mioriohk
comment
created
alan-mcnicholas
username_3
@username_2 I checked that address discrimination is working between staging\mainnet and testnet.
Valid addresses for both are accepted and invalid ones are rejected as expected due to incompatible networkMagic.
comment
created
nikolaglumac
username_2
Great! Thanks for checking that @username_3 ❤️ 
Can you please approve the PR?
comment