opened
bitfag
username_0
`get_market_fee()` in base.py returns market fee of `self.fee_asset`. It is surprising how we missed it. It is not we need at all, market fee is fee paid for buying some asset. E.g. the function must take "asset" as argument and return market fee for that asset (not self.fee_asset).

Because of wrong market fee, `get_market_xxx_price()` also returns slightly distorted values.
get_market_fee() returns wrong fee
issue
created
MarkoPaasila
username_1
So currently `get_market_fee()` get's the market fee for the defined fee asset, not the quote or base? Yes that's wrong. But the order creation fee still needs to use fee asset, so make sure not to mess that up
comment
created
bitfag
username_0
Sure, for this there is a separate method `get_order_creation_fee()` which doesn't use `get_market_fee()`.
comment
created
bitfag
username_0
Ok I think `get_market_fee()` is just redundant method because it just references an asset property. Fee info getting is as simple as calling `self.market['quote'].market_fee_percent`
comment
closed
PermieBTS
username_2
issue