opened
davidfowl
username_0
We have `IWebApplicationBuilder`, `WebApplicationBuilder`, `IWebApplication`, and `IApplicationBuilder`.

`IApplicationBuilder` looks related to `IWebApplicationBuilder` but they are not. 

Today:


```C#
var host = new WebHostBuilder()
                        .UseServer("Microsoft.AspNet.Server.Kestrel")
                        .UseUrls("http://localhost:5001")
                        .UseStartup<Startup>()
                        .Build();

host.Run();
```

Potential:

```C#
var app = new WebApplicationBuilder()
                        .UseServer("Microsoft.AspNet.Server.Kestrel")
                        .UseUrls("http://localhost:5001")
                        .UseStartup<Startup>()
                        .Build();

app.Run();
```
Consider changing WebApplication* to WebHost*
issue
created
Tratcher
username_1
I do agree there's ambiguity between IWebApplicationBuilder and IApplicationBuilder.
comment
created
davidfowl
username_0
Shall we go with host instead of application then?
comment
created
Tratcher
username_1
You're with @DamianEdwards right? Did he have anything to say on the subject?

I think it's fine, but I don't envy @username_5 having to touch all the repos again.
comment
created
davidfowl
username_0
Yes, we spoke about this today and concluded that it looks like WebApplication was wrong.
comment
created
mikes-gh
username_2
Would that mean also changing WebApplicationConfiguration to WebHostConfiguration?
comment
created
davidfowl
username_0
@username_2 yes re: `WebHostConfiguration`
comment
created
mikes-gh
username_2
@username_0 
```
WebHostBuilder
WebHostConfiguration
```
vs
```
WebHostingBuilder
WebHostingConfiguration
```
The later seems slightly more abstracted to me
comment
created
davidfowl
username_0
I dunno what you mean by more abstracted. I prefer:

I prefer a `WebHostBuilder` that builds a  `WebHost` using `WebHostConfiguration`
comment
created
mikes-gh
username_2
WebHost is fine.
comment
created
davidfowl
username_0
PS: @username_5 I'm sorry dude, that's alot of repos to update :disappointed:
comment
created
mikes-gh
username_2
WebHostConfiguration would read hosting.json seems a mismatch
WebHostingConfiguration would seem a more logically. match..
comment
created
davidfowl
username_0
But we're going to call it `WebHostConfiguration` so it matches the other names. We're splitting hairs and naming is hard but that's what we're calling it.
comment
created
aL3891
username_3
Maybe hosting.json could be host.json? (or webhost.json)
comment
created
henkmollema
username_4
`hosting.json` configures the hosting API. Webhost is just a part of that. It's not like we're renaming the repo to Webhost.
comment
created
JunTaoLuo
username_5
Marking as done since rename has been merged to dev and all repos have been updated. Will post announcement after monitoring test pass and close issue.
comment
created
GuardRex
username_6
... according to @username_1 https://github.com/aspnet/IISIntegration/issues/52#issuecomment-171444840
comment
created
mikes-gh
username_2
@username_5 
Looks like aspnet/Security is failing after this
comment
created
davidfowl
username_0
What is failing?
comment
created
mikes-gh
username_2
Microsoft.AspNet.Authentication.Test 

I noticed because I have a pull request for FacebookMiddleware

```
[00:05:14] Compiling 
[00:05:14] Microsoft.AspNet.Authentication.Test
[00:05:14]  for 
[00:05:14] DNX,Version=v4.5.1
[00:05:14] 
[00:05:17] [1m[31mC:\projects\security\test\Microsoft.AspNet.Authentication.Test\test\Microsoft.AspNet.Authentication.Test\Twitter\TwitterMiddlewareTests.cs(155,31): error CS0246: The type or namespace name 'WebHostBuilder' could not be found (are you missing a usi
[00:05:17] ng directive or an assembly reference?)
[00:05:17] 
[00:05:17] 
[00:05:17] Compilation failed.
```
comment
created
JunTaoLuo
username_5
@username_2 I think your packages may be out of date and updating to the newest packages should fix the problem. @username_6 I don't know how feasible listing all the versions is since many packages were affected. I will look into it but at least the renames will impact Microsoft.AspNet.Hosting rc2-16237 or later for sure.
comment
closed
JunTaoLuo
username_5
issue
created
JunTaoLuo
username_5
Seems like test pass will be broken for other reasons. Since I did not see any test failures relating to this change, I'm closing the issue for now.
comment
created
davidfowl
username_0
:clap:
comment