opened
jrubenoff
username_0
Fixes dobtco/screendoor-v2#1228
Adding .sub_labels
issue
created
ajb
username_1
This looks great in the screenshots you've provided, but without `dvl-core` it looks a little screwy. Remember that `formrenderer-base` does _not_ depend on dvl-core, and even though there are barely any visual styles in this repo, the layout should still render properly. (This is important for embeds.)
comment
created
ajb
username_1
Check out the updated version, lmk if you have questions. If you haven't been already, you can preview by opening `examples/index.html`.
comment
created
jrubenoff
username_0
Made some CSS fixes, please review.
comment
created
ajb
username_1
Am I crazy or did my previous comment disappear? here's what it was:

===

Are these CSS tweaks for formrenderer, or Screendoor? 

1. You'll notice that for better or worse, formrenderer uses `px` values in its CSS. I'd like to either stick with this, or rework the entire file to use `rem` or `em` units.

2. There is a layout error:

![img](http://take.ms/m7ugN)
comment
created
jrubenoff
username_0
1) I think this is OK in this instance. All labels are in relative units (`line-height: 1.5`), so `.label_sub` should as well.

`.fr_item_spacer` has a padding equal to the height of the label, and a `line-height` equal to the heights of the inputs, which are also set in relative units:

![screen shot 2015-01-13 at 3 23 21 pm](https://cloud.githubusercontent.com/assets/1328849/5731433/2279357a-9b38-11e4-9396-3b22df9122cb.png)

2) Fixed.
comment
created
ajb
username_1
Cool, that last change wasn't compiled FYI. (You can also run `grunt watch` to watch your files and compile when they're changed.)

And there is still this issue: 

![img](http://take.ms/DUDZC)
comment
created
ajb
username_1
Alright, fixed and rebased.
comment