opened
gizmooo
username_0
The domain-first domain approach is incorrect. For example, goo.gl returns undefined
some domains is not defined
issue
created
websanova
username_1
Are you using to version?

Also note that it's not a full to list as there are literally thousands of
them nowadays.
comment
created
gizmooo
username_0
I'm using the latest version of the plugin.
How do I get a domain?
https://plnkr.co/edit/YWy7BYrPxvGhW6F5aH3i?p=preview
comment
created
websanova
username_1
*I meant TLD version...

https://github.com/username_1/js-url/blob/master/url-tld.min.js
comment
created
gizmooo
username_0
Same thing with this version.
Can i do something wrong?
https://plnkr.co/edit/F4QlagpjcJNTBHKIfp8m?p=preview
comment
created
websanova
username_1
Show your code
comment
created
gizmooo
username_0
`var LINK = 'https://goo.gl/maps/smEKk1kZtq72'
  var domain = url('domain', LINK);
  var hostname = url('hostname', LINK);`
comment
created
websanova
username_1
Ok, so I added "gl" to the domain list. But that will only solve the issue with this domain.

I kind of gave up on keeping the tld list up to date because there are just too many nowadays.

You might want to try using the `url('.-1)` type structure for domain parts.
comment
closed
websanova
username_1
issue