opened
cdwort
username_0
We wanted to have tooltips be click to close (to accommodate clicking links inside) and found our users (really other devs roped into testing) had trouble finding how to close the tooltip. They first clicked outside the tooltip or inside the tooltip. Only after did they clicked on the original span they moused over/clicked on.

We wanted to add a close icon to provide a clear indication about where to click.

The resulting code to build up the template is little ugly, and this might be an edge use case, so no worries if this isn't something you're looking for.

Let me know if you'd like any changes or if I missed some documentation.

Thanks!
Add optional close button
issue
created
45kb
username_1
@username_0 Hi, first of all thanks for the PR, this feature is great.

I did not had any chance to try it, but as from the code you pushed, i just have some doubt,
wouldn't be better to call close-button="" attribute something like tooltip-close-button="" ?

Also could be great to use plain html inside the button, for example when using fontawesome:

    tooltip-close-button="<i class='fa fa-remove'></i>"

If you can fix or this is already fixed, let know, so we'll be glad to merge the PR!
comment
created
cdwort
username_0
Hi @username_1, thanks for the fast response! 

Thanks for catching the wrong attribute naming. It's now called tooltip-close-button.

It already does accept HTML, and there is an example in the Readme. I added examples to the index.html page and added some default styles to move the button to the right.

Let me know if there's anything else you would like to see. I can squash commits if you would like.
comment
created
wouldgo
username_2
Hi @username_0,
Looks good to me merging, could you please write down a brief explaination also in the readme.md file?

Best regard,
Dario.
comment
created
45kb
username_1
@username_0  thanks for the help! if you can please finish it, as @username_2  suggested :+1: 

thank you once more.
comment
created
cdwort
username_0
Hi @username_2 

I'm happy to make changes to what I already added for the readme, but could you give me a little more detail about what you would like to see? Are you asking that I break it out into a new section? Since it's only relevant when you click to close, I thought it might make sense to live in the triggers section.

Thanks for feedback,
Amy
comment
created
wouldgo
username_2
@username_0: ops! my fault I didn't saw your changes on the readme.md... Really sorry about that.
Merging right now, and thanks a lot for your commitment!

Dario.
comment
created
cdwort
username_0
@username_2 @username_1 I realize that for us to use this version we would probably want a minimized version. Would you accept another PR to update the minimized files?
comment
created
45kb
username_1
@username_0  i just pushed the minified versions, soon we will update tag and bower too
comment
created
cdwort
username_0
Awesome thanks!
comment
created
45kb
username_1
@username_0 it's a pleasure , thanks for your time.
comment