opened
arnog
username_0
**Describe the bug**
Modal dialogs are not accessible. When a modal dialog is displayed and a screen reader is used, the web page is visible to the screen reader (only the modal dialog should be).

**To Reproduce**

1. Launch Jupyter
2. Select Kernel > Restart Kernel... (to bring a sample modal dialog)

**Expected behavior**
The modal dialog should appear as modal to a screen reader
Modal dialogs are not accessible
issue
created
sinabahram
username_1
Initial fix is to add aria-modal="true" and role="dialog" on the containing element for the modal. Because modals are created/destroyed in the DOM upon usage, this should work fine. We then need to examine accessible ways of closing hte modal. There must be an accessible close button, and the escape key needs to also trigger this close button. Lastly, we need to make sure that focus is returned to where it originally was when the modal is closed. This means that jupyterlab needs to remember the last focussed element, and then upon modal close, this element needs to regain focus e.g. by calling .focus() on the reference to that element.
comment
closed
arnog
username_0
issue
created
arnog
username_0
Re-opening: more work to be done.
comment
reopened
arnog
username_0
**Describe the bug**
Modal dialogs are not accessible. When a modal dialog is displayed and a screen reader is used, the web page is visible to the screen reader (only the modal dialog should be).

**To Reproduce**

1. Launch Jupyter
2. Select Kernel > Restart Kernel... (to bring a sample modal dialog)

**Expected behavior**
The modal dialog should appear as modal to a screen reader
Modal dialogs are not accessible
issue
created
arnog
username_0
After further testing... the keyboard navigation works as expected and the focus is properly restored when the dialog is dismissed.
comment
closed
arnog
username_0
issue