opened
Gr3q
username_0
Now, this PR is to get feedback and help, because I kinda suck working with C++ and never used Qt before. Comes from my feature request https://github.com/gitahead/gitahead/issues/261

The Issues:
* Flag to trigger this mode is not linked to the added option (I need advice on how to do this)
* I want to use the git like relative time string (26 minutes ago) as timestamp, and I don't know if I can pull that from git or I have to build it myself.
* I only want to display the date if it is different than the previous string, but I don't know how/where to store the previous value to make this work.
* Badge needs serious refactoring. I split the whole function into 2 calls, based on alignment, but it's a lot of duplicate code, and I am unsure how to refactor it nicely because it is a static function.

I excluded the author name on purpose, because it does not provide any reference or context (only if you have to look out for that One person's commits in your team...) and  takes up way too much space.
I could include the Initials, but I'm already facing alignment issues on the right side so I don't really know where could I put it.

With Initials:
![image](https://user-images.githubusercontent.com/22377521/64487628-dda19f80-d234-11e9-9a89-f4b63a9afae3.png)


Current State:
![image](https://user-images.githubusercontent.com/22377521/64487531-bbf3e880-d233-11e9-81b5-6cbc08a4c0e7.png)
Add Compact Commit List as an option
issue
created
dgalli1
username_1
Would it be possible to do something like gitkraken for the authors? 
They generate a image for every user based on their git profile.
![grafik](https://user-images.githubusercontent.com/6371945/64487770-bb148400-d23e-11e9-8d0b-f4b487034b75.png)

This doesn't take up much space. But helps a lot with looking up commits from a certain person. And it looks way slicker then initals. I don't think it has to necessary be implementet at the history as gitkraken is doing i think next to the timestamp would be a improvment aswell
comment
created
Gr3q
username_0
I believe it is possible to do this, although it is a design choice what's not for me to decide.

At the moment I'll try to focus to fix the issues with the existing features.
comment
created
CFlix
username_2
Thank you so much @username_0! This looks great and is an absoloutely necessary feature. Hope the PR gets merged soon to end up in the next release!
comment
created
Gr3q
username_0
This PR is actually ready for merge, all the extra features can be implemented later (They turned out to be quite challenging and I do not have too much time to spend on this feature anymore)

If there is anything I should change/fix/additional testing please let me know.

Manual tests made in Linux:
Switching between Compact and Normal mode for an opened repo
Switching between Repos With different modes set
Opening new repo when an opened one was set to compact mode.
comment
created
kas-luthor
username_3
The width of the short ref IDs doesn't seem to fit on Windows
Maybe a broader character should be used for measurements?

![image](https://user-images.githubusercontent.com/16035731/68691738-85f51c80-0574-11ea-9725-1b9b2e129fd6.png)
comment
created
Gr3q
username_0
I wanted the commit reference width to be uniform (like a column), so the rest to its left are aligned correctly.
comment
created
Gr3q
username_0
@username_3 Does the problem still persists? I will try to build it on Windows _(again, had problems with openssl before)_ as well today to check if the commit reference displays correctly.
comment
created
kas-luthor
username_3
The width issue doesn't appear anymore
comment
created
hackhaslam
username_4
It still doesn't quite compute the right text width for the id, at least on macOS:
<img width="276" alt="Screen Shot 2019-11-18 at 7 03 50 PM" src="https://user-images.githubusercontent.com/6586470/69109959-76734900-0a36-11ea-97db-906207b6040f.png">
comment
created
Gr3q
username_0
It seems I can't get away with simple hacks... Fine, I'll do it properly this time.
comment
created
kas-luthor
username_3
Also: I think it would be nice to have an option to set compact mode as a default
Should I implement this or would you rather do it yourself?
comment
created
Gr3q
username_0
@username_3 That's something that was on my list to do, you can do it if you have the time. Or if you tell me which section and group is the best place for this setting in Options I can do it too.
comment
created
kas-luthor
username_3
I'd put it in the "Window" tab
I'll be able to implement it in ~6h when I get home
comment
created
Gr3q
username_0
Ok, thank you.
comment
created
Gr3q
username_0
Commit ID width calculation should be fixed now (it covers most cases). Widest characters are either 0,4,6,9,d or b, so I'm checking for those.

Optionally, I can use monospace font just for the commit ID to eliminate this problem, like this:

![image](https://user-images.githubusercontent.com/22377521/69145028-95b8b780-0ac4-11ea-8694-22c4979833f0.png)

Although It can look weird if people use wildly different monospace font compared to the default. For example for me the font baseline is different.
comment
created
hackhaslam
username_4
I'm reviewing this now.
comment
created
kas-luthor
username_3
@username_4 
My PR username_0/gitahead#2 is still open
comment
created
hackhaslam
username_4
@username_3 I will look at it.
comment
created
Gr3q
username_0
@username_3 thanks its merged now, I don't know why I don't get notifications about my fork.
comment
created
Gr3q
username_0
@username_4 feel free to pick it apart, I think there are a few things what I implemented at the wrong places/incorrectly (probably in CommitList.cpp) what I'm happy to fix if you point them out.
comment
created
hackhaslam
username_4
I tried it without duplicating the date in the way that I think you were trying to do. It looks weird to me. It would probably look better if the space were left blank instead of allowing the message to grow into that space. However, the width of the date string is variable, so I wouldn't really know how much space to leave. I'm going to merge it without this for now.

<img width="419" alt="Screen Shot 2019-11-20 at 4 15 23 PM" src="https://user-images.githubusercontent.com/6586470/69286673-11902e00-0bb1-11ea-9bee-ebedfd9912be.png">
comment
created
hackhaslam
username_4
I merged this manually with a couple of additional commits. I also didn't use the default setting commit from @username_3. Instead, I just changed the existing setting to an application global setting instead of a repo-specific one. I don't think there needs to be a separate repo-specific setting and global default setting, but I can revisit that if you guys think it's important.

@username_0 @username_3 I'm going to start including contributor names for specific changes in the change log. Can you let me know your preferred name (real name or handle) if you want it appear?

Also, @username_3 I'm trying to review some of your pull requests now. I can implement the macOS-specific portions of the ones that need them.
comment
created
Gr3q
username_0
I'm happy with the changes. My name is Attila Greguss, you can use it.

Thanks
comment
created
kas-luthor
username_3
@username_4 
Just "Kas" will be fine, thanks
comment