opened
luckysori
username_0
The implementation comes from
https://github.com/dalek-cryptography/bulletproofs and has been
modified to conform to Monero's implementation of the same paper.
Create new bulletproof submobule
issue
created
luckysori
username_0
This is an interesting question. At first I thought that writing an integration test was not that important because our primary goal is to be able to generate a valid Monero bulletproof, rather than to be able to verify Monero bulletproofs in general. 

Of course, if we are to contribute this to upstream, the verify function must not be buggy. So I was curious and tried it against a mainnet bulletproof and it fails! 

As it stands, the verify function works against the local prove function (and more importantly, the prove function works against Monero's verify function). I don't want to invest more time into debugging this (it may just be that I'm not deserializing things correctly), but we should record adding a passing "integration" test as a TODO. I'll add my failing test and mark it as `ignored`.
comment
created
thomaseizinger
username_1
That is okay, thank you!
comment
created
luckysori
username_0
Yep, all these `create_and_verify_n_m` tests create and verify a proof.
comment