opened
zhuyingjiang
username_0
separate the PR for rt5682 and nocodec.
Topic/add cnl nocodec tplg
issue
created
lgirdwood
username_1
@username_0 sorry not following, is this PR for the same files as https://github.com/thesofproject/sof/pull/834 ?
comment
created
zhuyingjiang
username_0
No, #834 is for rt5682 on CNL/WHL/CML, and this one is for  cnl nocodec.
comment
created
ranj063
username_2
@username_0 the commit message makes no sense 
"CommetLake(CML) and Whiskeylake(WHL) are CannonLake" 
You need to make it clear that they have the same audio IP.
comment
created
plbossart
username_3
The IP has more capability than the SOC, and the board add further 
restrictions. For a nocodec board I agree we should expose everything 
the IP can deal with, even if it means some of the pins may not be 
visible due to pin-muxing. For an actual device we should stick to what 
is actually usable, i.e. model the topology on board limitations.

Also you can't necessarily use the same topology for the same IP, e.g. 
for APL and SKL there are fundamental differences in memory layout which 
limit what can be done with internal memory only or conversely can't be 
scaled beyond the internal memory.
comment
created
zhuyingjiang
username_0
@username_1 @username_2 @bardliao
comment
created
zhuyingjiang
username_0
@username_1
comment