opened
vskh
username_0
Hi Machal!

Thanks for this lib, it helped me a lot to get my head around with tokio, serde and async.

I am looking to use it in my pet project with up to date tokio which is incompatible with the one used by the crate.

This PR updates tokio to the latest (0.2.6 at this stage) which more or less has migrated to latest futures. However, it still uses Encoder/Decoder from tokio rather than futures-codec.

Would you consider merging it in?
Update to latest futures & tokio.
issue
created
vorner
username_1
Thank you for the pull request. I don't have the time to do the review right now, but I hope to find the time in few days.

Of course I'll be glad to merge it and do a new release :-), it's just this crate wasn't really at the top of my priority list.
comment
created
vskh
username_0
Sure, let me have a look and update the PR.
comment
created
vskh
username_0
I've updated PR with suggested fix. With regards to adding me to authors - up to you :)
comment
created
vorner
username_1
Thank you. I've merged it, I'm adding you to the authors ‒ so you get your part of the fame 😇.

I'll try updating to serde-cbor 0.11 (the strange thing is, it seems to compile but tests fail after the update) and then cut a release, so both breaking changes are brought together.
comment