opened
bryano
username_0
Adds `FermionicSimulationGate` metaclass with common methods.

Adds `trotterize` method.
Utilities for trotterizing operators
issue
created
bryano
username_0
Note that the only failing test is pylint complaining about wrong import order because I'm importing from GitHub. (Needs more recent OF master and two of my PRs on Cirq.)
comment
created
bryano
username_0
Sorry, I did not realize how big this PR got. Let me know if you want me to break it up.
comment
created
bryano
username_0
Why does pylint say that cirq should come before numpy? Aren't they both 3rd-party imports?
comment
created
kevinsung
username_1
I don't know, just satisfy it haha.
comment
created
bryano
username_0
Fixes #253
comment
created
kevinsung
username_1
Hi @username_0 sorry for the delay in reviewing this. Can you please split this into two PR's, with one introducing the gates and the other with the trotterization utilities?
comment
created
bryano
username_0
@username_1 I could split it up, but the trotterization utilities are currently used to test the gates, so it wouldn't be trivial.
comment
created
kevinsung
username_1
Yes, please split it up. The gates and their tests should not depend on the trotterization utilities, but the other way around is okay.
comment
created
bryano
username_0
Okay, I'll start splitting it up.
comment
created
ncrubin
username_2
@username_0 We've come up on 1 year open for this PR.  Given it's age can I assume it is stale?
comment
created
bryano
username_0
@username_2 Yea, I think everything already got integrated in parts (#370, #371, #388).
comment