opened
runspired
username_0
There is no `.npmignore` file excluding these, so `files: []` here is the SOT.
This might help make errors with `bower install` more obvious, as bower tends to attempt to pull from `lib/` and will not have `dist/` available to it.
Remove `lib/` from published files.
issue
created
runspired
username_0
cc @username_2 @username_1 @Turbo87
comment
created
rwjblue
username_1
Now that I think about it more, I thought we actually wanted to keep these files around. So that we can allow apps to opt-in or out of instrumentation in the build (with something like ember-heimdall).  This functionality was removed temporarily but I believe that "we all agree" that we want the functionality...
comment
created
stefanpenner
username_2
Didn't we produce two builds one instrumented and one not. If so, in either case we wouldn't need lib
comment
created
rwjblue
username_1
Hehe, I really don't recall 😝
comment
created
runspired
username_0
Some thoughts

- once (or before) `ember-heimdall` is published, we should prebuild an instrumented and non-instrumented version if we've stopped doing so. This addon seems like a good candidate to be `static`
- relying on `lib/` for this seems like it would always be problematic, as we'd have to be extra careful to never do anything that didn't require a build step
- `ember-heimdall` is not published yet
comment
created
stefanpenner
username_2
https://github.com/ember-cli/loader.js/blob/master/build.js#L20
comment
created
stefanpenner
username_2
@username_1 should this be major or minor release?
comment
created
rwjblue
username_1
@username_2 - I think minor is fine, if folks were using `lib` they already had issues because it assumed `heimdall` global and whatnot...
comment
created
stefanpenner
username_2
released as v4.3.0 🎉
comment