opened
domderen
username_0
Currently the network tab contains a limited amount of information on the resources that were loaded in the browser. This change proposes extending the details displayed for each resource, to include:

- HTTP method,
- Status
- Full url,
- Easily visible response content type,
- Request headers,
- Request & response bodies.

Such level of information could help quickly understand what happened in the application, when it was communicating with backend services. This can help debug tests quicker to figure out why they are failing.

What do you think about such extension?

<img width="1680" alt="Zrzut ekranu 2021-01-14 o 15 31 33" src="https://user-images.githubusercontent.com/2360738/104636315-77882080-56a3-11eb-946f-d7fc096ec7fc.png">
<img width="1680" alt="Zrzut ekranu 2021-01-14 o 19 58 58" src="https://user-images.githubusercontent.com/2360738/104636306-735c0300-56a3-11eb-93d3-36fe3b1ad832.png">
<img width="1680" alt="Zrzut ekranu 2021-01-14 o 02 53 39" src="https://user-images.githubusercontent.com/2360738/104534016-c5edde80-5613-11eb-8386-05ce124e065b.png">
<img width="1680" alt="Zrzut ekranu 2021-01-14 o 15 31 59" src="https://user-images.githubusercontent.com/2360738/104636311-77882080-56a3-11eb-9e5c-b24f8717233d.png">
feat(trace viewer): Extending existing NetworkTab view.
issue
created
domderen
username_0
Hey @dgozman thanks for taking a look at this PR, I think all the changes you pointed out should be fixed now :)
comment
created
domderen
username_0
One more thing, I was looking at the failing checks, and most of them seems unrelated, but one of them peeked my interest, as it is related to the test I added here: https://github.com/microsoft/playwright/pull/5009/checks?check_run_id=1757111083

It looks like in this particular case, the trace file does not contain the `NetworkResourceTraceEvent` for `/file.json` request. I saw that issue before when I was adding those changes, but they went away. I thought it was related to the way the test was set up, but now I'm starting to wonder if there is potentially a race condition somewhere, that doesn't always wait for network events to resolve, before finishing an action like "click". Do you think this makes sense? Should I create a bug for it, and try to look for it?
comment