opened
Edouard-chin
username_0
Fix `AR::Relation#where_values_hash` with `HomogeousIn`:

- Calling `Blog.where(title: ['foo', 'bar']).where_values_hash` now
  returns an empty hash.
  This is a regression since 72fd0bae59 .

  `Arel::Node::HomogeousIn` isn't a `EqualityNode`, the `WhereClause`
  didn't had a case for this.

  I decide to not make `HomogeousIn` inherit from `EqualityNode`,
  because there is a comment questioning it for `In` https://github.com/rails/rails/blob/57d926a78a6968b9268f4ec1acde608132a1c920/activerecord/lib/arel/nodes.rb#L31
  Intead I just modified the `WhereClause` case and implemented
  `right` on the node which is needed by `where_value_hash` https://github.com/rails/rails/blob/57d926a78a6968b9268f4ec1acde608132a1c920/activerecord/lib/active_record/relation/where_clause.rb#L59

cc/ @tenderlove @rafaelfranca @paracycle @casperisfine @etiennebarrie
Fix `AR::Relation#where_values_hash` with `HomogeousIn`:
issue
created
eileencodes
username_1
I think you need to rebase with master. The failures you have look like the ones I caused yesterday 😅
comment