opened
marisademeglio
username_0
Adds a property to LinkedResource called `alternate`. 

Addresses https://github.com/w3c/pub-manifest/issues/33


<!--
    This comment and the below content is programatically generated.
    You may add a comma-separated list of anchors you'd like a
    direct link to below (e.g. #idl-serializers, #idl-sequence):

    Don't remove this comment or modify anything below this line.
    If you don't want a preview generated for this pull request,
    just replace the whole of this comment's content by "no preview"
    and remove what's below.
-->
***
<a href="https://pr-preview.s3.amazonaws.com/username_0/pub-manifest/pull/56.html" title="Last updated on Sep 9, 2019, 3:26 AM UTC (fe48b7a)">Preview</a> | <a href="https://pr-preview.s3.amazonaws.com/w3c/pub-manifest/56/cd05f1a...username_0:fe48b7a.html" title="Last updated on Sep 9, 2019, 3:26 AM UTC (fe48b7a)">Diff</a>
Feature/add alternative
issue
created
iherman
username_1
Also, the JSON schema in https://github.com/w3c/pub-manifest/blob/master/schema/link.schema.json should also be changed (actually, regardless of whether this PR is accepted or not, because it is missing even in the old format!)
comment
created
iherman
username_1
Note to myself: the 'alternate' property should also be added to the vocabulary and the context file, because it is not a schema.org property after all.
comment
created
iherman
username_1
@username_0, if you cannot do it, I am happy to do it if and when this is merged. I cannot add it to the current PR, because it is in your cloned repository to which I do not have write access...
comment
created
marisademeglio
username_0
The schema on my fork has `alternate` (🙏 @mattgarrish ): https://github.com/username_0/pub-manifest/blob/feature/add-alternative/schema/link.schema.json#L60

I don't know what changes you have in mind though (you mentioned old format, I'm not so familiar with the history of this file) so if it needs more work, feel free to make the edits or let me know and I'll do it.
comment
created
iherman
username_1
Oops, sorry @username_0, I missed that one in the schema file somehow. What you have is perfect, apologies for the noise!
comment