opened
eakuefner
username_0
In order for the current per-revision pipeline to support visualizing metrics that specify story grouping keys (like foreground/background for memory benchmarks, or warm/cold for PCv2), we need to suffix value names with story grouping keys in `PageTestResults.AddValue`, in the same place where we append the story grouping keys to the value's grouping key dict. We will ignore grouping keys that are specified by the value received by the metric itself, so that metrics will still be responsible for making the grouping keys part of the name in the way that they choose (memory is already doing this).

We may also consider abusing the `tir_label` field for this purpose, since the plumbing is already done there, and that gets us display on the dashboard for free.

@perezju @petrcermak @nedn
PageTestResults should suffix story grouping keys
issue
closed
eakuefner
username_0
issue
created
eakuefner
username_0
This is **done**.
comment