opened
xmik
username_0
I decided to give kitchen-terraform a try and tested it with OpenStack Terraform provider. It took me a while to set it up together, so I think adding it as example will make it easier for others to use kitchen-terraform with OpenStack.

I provided a `README.md` which should explain well enough what this example does. I wanted to make it as short and simple as possible, so I didn't repeat information from other examples. It should be easy to run for anyone new to kitchen-terraform.

Would you like to merge it? Or want to correct something? One thing that I don't like here is that I have 2 identical files: `examples/openstack/variables.tf` and `examples/openstack/test/fixtures/0.7/variables.tf`. But whenever I removed any variable from the latter, there were errors.

And I'm happy to find out that kitchen-terraform exists, there is definitely a need for such a tool!
Add example for OpenStack Terraform provider
issue
created
ncs-alane
username_1
Hi @username_0:

Thanks for your interest in the project! We're always happy to have more contributions to the documentation and examples. I will try to review your example soon and hopefully we can ship it with the 0.4.0 release.

We may be able to solve your concern with the redundant variable file in the test fixture module. The reasons why the detailed example uses test fixture modules are to illustrate how it can be done and to provide a way for us to test compatibility with different versions of Terraform. I have only skimmed through your code but I believe that you can simplify your example by removing the test fixture and testing the example module directly as the fixture module is not adding any additional configuration.
comment
created
xmik
username_0
I removed the redundant fixture directory and it works as you said. Now it feels much better. Let me know about any other things to correct and I'll later stash all the commits.
comment
created
ncs-alane
username_1
Do you know of an implementation of OpenStack that could used freely with this example?
comment
created
xmik
username_0
I updated the PR. Now when I use kitchen-terraform from the source code (instead of 0.3.0) I see repeated, unnecessary output on `kitchen verify`. I take it that `username_1-0.4.0` branch is not yet ready for release and perhaps you are aware of that output. (I can post here the output or create a separate issue if you want).
comment
created
xmik
username_0
You mean some public, free for open source projects OpenStack cloud to test this example? No, I don't. We use it as a private cloud. If I find any, I'll write here.
comment
created
ncs-alane
username_1
@username_0 Are you talking about Terraform command output? If so, 0.5.0 will introduce improved logging that pipes the output of commands like `output` and `version` to the debug logger.
comment
created
xmik
username_0
Yes, that is what I'm talking about. I put that output into gist: https://gist.github.com/username_0/53d2e997772379e512794a0a5bd4b4ab (just for reference). Nice that you are planning to improve it.
comment
created
ncs-alane
username_1
@username_0: I looked at your gist and it is indeed expected behaviour. The verbosity and redundant commands will be solved in 0.5.0.
comment
created
xmik
username_0
I rebased the branch and corrected the readme and build errors from Travis CI. Should I squash the branch?
comment
created
xmik
username_0
Do you, @username_1 , know how to fix the Travis build? Has this error happened ever before?
comment
created
ncs-alane
username_1
@username_0: The error is due to a misconfiguration in the base branch's release logic. I'll submit the correction and then you can rebase once again. 😓 

You don't need to squash your local branch as we can squash and merge on GitHub.
comment
created
ncs-alane
username_1
@username_0: The upstream issue should be solved. Please rebase again.
comment
created
xmik
username_0
Rebased and verified again and the Travis build is finally green! :-)
comment