opened
NickLaMuro
username_0
Purpose or Intent
-----------------
Update to newest version of Rails to get us to the official 5.0 release.


Links
-----
* https://github.com/fixlr/codemirror-rails
* https://github.com/fixlr/codemirror-rails/pull/49
* https://github.com/rails/jbuilder/blob/master/CHANGELOG.md


Steps for Testing/QA
--------------------
* This is a large jump for codemirror as far as minor releases goes, so we should make sure there are no issues with that.
* jbuilder also got an update, though the test suite should probably be covering that.
Upgrade to gem release of Rails 5.0
issue
created
himdel
username_1
Verified that codemirror 5.11 seems to behave sanely in the UI..
comment
created
himdel
username_1
Note for people using the `quiet_assets` gem in their local `Gemfile.dev.rb` .. it's deprecated, and will cause `bundle update` to fail .. but it can be replaced with a `Rails.application.config.assets.quiet = true` line somewhere in `config/initializers/*.rb`
comment
created
NickLaMuro
username_0
@Fryguy with the release of the new `codemirror-rails` gem, I think that closes out most of the reservations with merging this PR.

Also, is this something that needs to get merged into darga, or is #9563 good enough?
comment
created
chrisarcand
username_2
I would like to see this in Darga; I don't think relying on a hosted release candidate for a stable release of MIQ is a wise idea in the long run. @username_3 ?
comment
created
chessbyte
username_3
@username_2 I am all for backporting to Darga, BUT **first** it has to be merged on master.  :-)
comment
created
chrisarcand
username_2
Code changes look solid, Martin verified codemirror... LGTM 👍
comment
created
jrafanie
username_4
🎉 👏
comment