opened
yufeih
username_0
 Add file to JSON source info
issue
created
OsmondJiang
username_1
what are we going to resolve in this PR?
comment
created
live1206
username_2
Should we add a not null check here? so that there is always a File populated.
And populate file for these as well?
[https://github.com/dotnet/docfx/blob/aefc5c92856e969675de894a49255f44197a991d/src/docfx/build/metadata/MetadataValidator.cs#L30](https://github.com/dotnet/docfx/blob/aefc5c92856e969675de894a49255f44197a991d/src/docfx/build/metadata/MetadataValidator.cs#L30)
[https://github.com/dotnet/docfx/blob/aefc5c92856e969675de894a49255f44197a991d/src/docfx/build/metadata/MetadataValidator.cs#L46](https://github.com/dotnet/docfx/blob/aefc5c92856e969675de894a49255f44197a991d/src/docfx/build/metadata/MetadataValidator.cs#L46)

---
Refers to: src/docfx/lib/log/SourceInfo.cs:37 in 1e80a45. [](commit_id = 1e80a45e458b9ac292e037a56b719cd28d62af20, deletion_comment = False)
comment
created
yufeih
username_0
yes, after all the other `nulls` are cleaned up.
comment
created
live1206
username_2
As I can see, the two in `MetadataValidator.cs` are the only nulls left to clean up.
comment
created
yufeih
username_0
https://github.com/dotnet/docfx/commit/17b9711e9305d9d3bea68eeb7a5186ca5865b4c1#diff-600d735a03558a7e04fbe7a52cbea80aR20 makes that line could potentially also be `null`
comment
created
live1206
username_2
ok, leave it for later change then
comment