opened
mengxr
username_0
The previous default is `{gaps: false, pattern: "\\p{L}+|[^\\p{L}\\s]+"}`. The default pattern is hard to understand. This PR changes the default to `{gaps: true, pattern: "\\s+"}`. @username_1
[SPARK-7794] [MLLIB] update RegexTokenizer default settings
issue
created
jkbradley
username_1
LGTM
My only comment is that I'd prefer to have the Python doc (including doc embedded in Param) match the Scala doc, rather than being a short version of it.  I also like having the embedded doc match the Scala/Python generated doc so that explainParam prints out more info.
comment
created
mengxr
username_0
Agree. Right now it has huge overhead of keeping the docs in sync. It would be nice if this could be done automatically, e.g., geting the Scala Param.doc via Py4J. I merged this into master and branch-1.4.
comment