opened
kyleshevlin
username_0
This PR adds a configuration setting allowing the user to put the sidebar on the right side. This is accomplished by creating a list of the "surface" components, and reversing their order if the setting is set to `right`. The default CSS lays out the components correctly.
feat(workbench) adds configurable sidebar position
issue
created
bryphe
username_1
Awesome PR @username_0 - thank you!
comment
created
bryphe
username_1
I wonder if we should flip the 'highlight' in the activity bar:

![Screen Shot 2020-08-13 at 4 11 36 PM](https://user-images.githubusercontent.com/13532591/90196053-d1e12600-dd7f-11ea-93ac-fc2b1cfc74f7.png)

there is a highlight line to show the active selected sidebar pane - I believe it would make sense to move it to the right side when `workbench.sideBar.location` is `right`.
comment
created
kyleshevlin
username_0
Sure, @username_1, that's how it looks in VSCode, so I can give that a shot
![Screen Shot 2020-08-13 at 4 13 52 PM](https://user-images.githubusercontent.com/4333144/90196186-07860f00-dd80-11ea-847d-d91be1332e73.jpg)
comment
created
bryphe
username_1
Sweet, thanks @username_0 !

That border is here: https://github.com/onivim/oni2/blob/5e385db6ce03635bd390d4429d25ebd83af2ea7a/src/UI/Dock.re#L33

so we'll need to add a parameter to `<Dock />`, and then plumb it through `<activityBar />`:

https://github.com/onivim/oni2/blob/5e385db6ce03635bd390d4429d25ebd83af2ea7a/src/UI/Root.re#L126

Pretty close to where we query currently in `Root.re` to get the sidebar location.
comment
created
kyleshevlin
username_0
I've discovered a bug that should be addressed before merging this involving resizing the sidebar.

![SmallBug](https://user-images.githubusercontent.com/4333144/90198495-b299c700-dd86-11ea-99f4-af456ab70bce.gif)
comment
created
kyleshevlin
username_0
I have the resizer on the correct side already. Working on the pane resizing as expected.
comment
created
bryphe
username_1
Nice catch @username_0 !

I'm thinking we'll need to change the way the `delta` is applied as the resize in progress, depending on the sideBar location: 
https://github.com/onivim/oni2/blob/5e385db6ce03635bd390d4429d25ebd83af2ea7a/src/Feature/SideBar/Feature_SideBar.re#L44
(If it's on the right, we'd want `width - resizeDelta` instead)
comment
created
kyleshevlin
username_0
And got that, too.

![fixed](https://user-images.githubusercontent.com/4333144/90201888-001b3180-dd91-11ea-83d0-f3f7e6f89358.gif)
comment
created
kyleshevlin
username_0
FWIW, Ran unit tests locally and they all pass.
comment
created
bryphe
username_1
Just pulled the latest and tested it out - looks great, @username_0 !

 Thanks for fixing the highlight position and catching the resize issue 👍  Bringing in now!
comment