opened
mvegaca
username_0
It is needed to review the redlines considering:
- [ ] Follow generic redlines for views: https://developer.microsoft.com/es-es/windows/apps/design
- [ ] Please use this type ramp: https://docs.microsoft.com/en-us/windows/uwp/style/typography#type-ramp
- [ ] Follow this breaking point document for padding for pages at different screen sizes, etc: https://docs.microsoft.com/en-us/windows/uwp/layout/screen-sizes-and-breakpoints-for-responsive-design
- [ ] Make sure to follow 4px grid (in general, any value should be multiples of 4px)

We will require adding the visual state manager to handle breakpoints and this needs to be designed to be shared among different templates using it.
Review generated pages redlines and guidance as per design team requests
issue
created
ralarcon
username_1
Moving to backlog to better plan when to do this review (we don't have explicit request from design team to do a full the design review)
comment
created
crutkas
username_2
we're literally doing this right now.
comment
created
sibille
username_3
We got a design review from the fluent team and will adapt the following pages accordingly:
-  Blank page: 
	- Change margins to 24 l/r margin
- WebView
	- Hide title 
- Media Player
	- Hide title
- Master/Detail
	- Hide NavView Title
	- Add title to master list (14px bold)
	- Content area margin 52 px 
	- Change master lists background color 
	- Change master and detail styles 
- Telerik DataGrid
	- Change margins to 24 l/r margin
- Datagrid 
	- Change margins to 12 l/r margins
	- Change background color
 	- Show gridlines
	- Settings 
	- Change margins to 24 px l/r margin
	- Changed text and radio button styles 
- Chart
	- Change margins to 24 px l/r margin
- Tabbed 
	- Change margins to 24 px l/r margin
	- Change pivot tab header style
- Map
	- Hide title
- Image Gallery 
	- Change margins to 24px l/r margin
	- Change picture size
- Ink Pages 
	- Custom header with separate ink toolbar and command bar with white background 
- Camera
	- Hide title
- Adaptive GridView
	- Change margins to 24px l/r margin
	- Change background color of items
		
You can see design and implementation details in this PoC project. [FluentDesignReview.zip](https://github.com/Microsoft/WindowsTemplateStudio/files/2469555/FluentDesignReview.zip)

To hide/customize the NavView Header depending on the selected page we use a custom NavViewHeaderBehaviour.


Also updated action plan in the first comment of this issue.
comment
created
crutkas
username_2
great job on the alignment!
comment
created
mdtauk
username_4
It is good to see there is some effort to bring more consistency to Windows apps, even in a (semi)external toolkit of controls, templates etc.

It would be neat if the Fluent Design teams could make these red-lines and other specific guidance publicly available online in as much detail as Google does with its Material Design system.  There are docs, and some toolkits (even if many are out of date) but they are not presented in an ideal way for those designers who are not as code and programming focused.
comment
created
crutkas
username_2
@username_4  great feedback.
comment
created
sibille
username_3
We're facing an issue in the NavViewHeaderBehaviour with CodeBehind.
X:Bind is not working in the DataTemplate when HeaderContext is set to a Page.

Possible workarounds would be:
- Bind to a HelperClass
- Not setting HeaderContext and use binding instead of x:bind.

I've attached a solution where you can see the problem and the workaround:
[App1.zip](https://github.com/Microsoft/WindowsTemplateStudio/files/2506011/App1.zip)

- App1_XBind_Page: This project shows the problem, binding seems to work fine, but value is not shown.
- App1_XBind_Helper: Solution 1: Bind to a HelperClass
- App1_Binding: Solution 2: Use Binding instead of xBind
- App1_ContentPresenter: This project shows what we suspect is the underlying problem, a `ContentPresenter` with `Content` bound to a page does not resolve bindings in `ContentTemplate `correctly, a ContentPresenter with content bound to another class does.
comment
created
sibille
username_3
Scheme Activation Page texts are not aligned with the header
comment
closed
sibille
username_3
issue
created
sibille
username_3
Verified in dev-nightly:
Templates version: 0.19.18318.2
Wizard version: 0.19.18318.1
comment