opened
the-Mitu
username_0
This pull requests allows to register packages for GitLab projects placed into subgroups.

Currently the problem is that URL validation throws an error, because it expects url like *service*[.com]//*owner*/*project*. However, GitLab's subgroups allow URLs like gitlab.com/*owner*/*subgroup*/*subsubgroup*/*project*.

This pull request renames **m_project** to **m_projectPath** in **GitLabRepository** and allows it to store the *subgroup*/*subsubgroup*/*project* as is with slashes - so the first part after the URL is put into **m_owner** as it was before, but the rest is joined and put into **m_projectPath** even if contains slashes.

The regex is adjusted as well so that multiple slashed parts are allowed.

This will fix #374.
Support for GitLab projects inside subgroups
issue
created
the-Mitu
username_0
Unfortunately I have only private projects in subgroups. I've tested it locally on them and it worked but I expect you want to test it as well.

I've browsed the public GitLab groups and found some projects laying inside a subgroup that is publicly available. Example one: https://gitlab.com/ezmaxtech/ha/register

That one is actually not a D project, but maybe it is sufficient to see that the repo is accessed and an error appears just because there is are no dub projects in it. Alternatively a test group/subgroup has to be created.

Thanks for noting the #349 - however I actually need to set up my own instance for hosting non-public packages, so I'll hope I'm more lucky. :)
comment
created
the-Mitu
username_0
@username_1, Tried to test on staging - "Unknown repository type: gitlab". Haven't you forgotten to set the GitLab's server URL in settings.json?

I'd actually suggest it to be "gitlab.com" by default unless another one is specified - not unsupported unless specified - but this is something for another ticket.
comment
created
wilzbach
username_1
We have a #dub channel on the D Slack where you might be able to find help if you aren't lucky.
Simply send me a ping if you want an invite.
comment
created
wilzbach
username_1
Merged and thus I rebased this PR. We should be able to test https://gitlab.com/dub-registry-test/a-subgroup/test in a few minutes.
comment
created
wilzbach
username_1
https://dub-registry-staging-pr-378.herokuapp.com/packages/gitlab-test-package :)
comment
created
the-Mitu
username_0
@username_1, could I get that invitation to Slack workspace? I'm probably affected by the error you mentioned - and also have a few questions on other topic as well.
comment
created
wilzbach
username_1
@username_0 Invitation is out.
comment