opened
brson
username_0
This reverts https://github.com/rust-lang/rust/pull/26599, which puts the stage number in the output of `--version -v`, but is not supposed to put it in the 'stage2' compiler, which is what most people refer to the binary we deploy.

The picture is not so clear though because of how stage 'promotions' happen in the build and also because the windows build deploys stage3, not stage2.

cc @username_2
Revert putting stage number in --version
issue
created
rust-highfive
username_1
r? @pcwalton

(rust_highfive has picked a reviewer for you, use r? to override)
comment
created
brson
username_0
r? @username_3
comment
created
brson
username_0
Oh, the effect of the reverted patches is that on Linux, the compiler reports `stage: stage1`, when it is expected to report nothing. Off hand I'm not sure the best way to fix this in a way that works everywhere.
comment
created
richo
username_2
Yeah, sorry about the confusion here (I realised that something was amiss in this comment: https://github.com/rust-lang/rust/pull/26599#issuecomment-119005664)

it's extremely unclear what's happening, when I forced a stage3 build, it reports nothing, however my stage2 reports `stage: stage1`. Looking at what `make` appeared to do when creating the stage3 however it appeared to only actually build a new `rustc` binary and copy all the libs over to the new stage, which is confusing when this code appears in rustc_driver.

Apologies for the confusion, I'll try to work out what went sideways this week.
comment
created
alexcrichton
username_3
@username_4: r+ 147da94206f42a4b30fb1d401530519b58b4a050
comment
created
bors
username_4
:hourglass: Testing commit 147da94 with merge 50df2a0...
comment
created
bors
username_4
:sunny: Test successful - [auto-linux-32-nopt-t](http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/5626), [auto-linux-32-opt](http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/5638), [auto-linux-64-nopt-t](http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/5584), [auto-linux-64-opt](http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/5613), [auto-linux-64-x-android-t](http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/5585), [auto-mac-32-opt](http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/5658), [auto-mac-64-nopt-t](http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/5650), [auto-mac-64-opt](http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/5618), [auto-win-gnu-32-nopt-t](http://buildbot.rust-lang.org/builders/auto-win-gnu-32-nopt-t/builds/601), [auto-win-gnu-32-opt](http://buildbot.rust-lang.org/builders/auto-win-gnu-32-opt/builds/602), [auto-win-gnu-64-nopt-t](http://buildbot.rust-lang.org/builders/auto-win-gnu-64-nopt-t/builds/597), [auto-win-gnu-64-opt](http://buildbot.rust-lang.org/builders/auto-win-gnu-64-opt/builds/600)
comment