opened
kellyethridge
username_0
This update has a hard-coded set for exactly one import. This may become fragile depending on how often you change the API.
Excluded imports except ValidationRule in generating d.ts files.
issue
created
kellyethridge
username_0
This pull-request probably shouldn't be accepted until after the removal of the spoonx prefix is applied.
comment
created
doktordirk
username_1
why is the validation import needed while the other external imports are not?
comment
created
RWOverdijk
username_2
@username_1 Because we provide a custom validator. :+1:
comment
created
doktordirk
username_1
@username_0 right. that place is giving me pain. i suggest to add a like 'dts-builder-options.js' file (where and like paths.js) and get an array of additional importsToAdd from there. (you might need to rebase first)
comment
created
doktordirk
username_1
yes. :+1: that's good. lets merge those commits to make it look nicer in the commit log. (reset to branching point (--mixed which is default to keep changes). add what should be in new version, commit and force push)

for command line that'll be :
```sh
git reset 9e84f30
git add build/*
git commit -m "fix(d.ts): include only necessary imports"
git push -f origin HEAD
```
gulp util and a new build isn't needed
comment
created
RWOverdijk
username_2
@username_0 That's one beautiful commit you have there :)
comment
created
RWOverdijk
username_2
Two tiny comments in the same file. After that, you have my :+1:
comment
created
doktordirk
username_1
nice work !!
comment
created
kellyethridge
username_0
:+1: thanks guys. It's been a fun learning experience.
comment