opened
ehuss
username_0
This adds some changes to how `cargo package` and `cargo publish` handle the `license-file` field. This also incorporates some refactoring which hopefully makes the code a little clearer and straightforward, but which also resulted in some minor behavior changes.

* Warn if license-file points to a non-existent file.
* Automatically include license-file, even if it is not listed in the `package.include` list (similar to how Cargo.toml/lock are automatically included).
* If license-file points outside of the package root, copy the file to the package root (and rewrite the field in Cargo.toml).
* Files are now sorted when archived.
* `Archiving: Cargo.toml.orig` is explicitly printed where before it did not report that.
* `cargo package --list` now shows `Cargo.toml.orig` where before it was not reported.

Closes #3537
Closes #7830
Better support for license-file.
issue
created
rust-highfive
username_1
r? @Eh2406

(rust_highfive has picked a reviewer for you, use r? to override)
comment
created
alexcrichton
username_2
@username_3: r+

Nice!
comment
created
bors
username_3
:pushpin: Commit efed107648156d6c6f76bc89c58062bddbe30c62 has been approved by `username_2`

<!-- @username_3 r=username_2 efed107648156d6c6f76bc89c58062bddbe30c62 -->
<!-- homu: {"type":"Approved","sha":"efed107648156d6c6f76bc89c58062bddbe30c62","approver":"username_2"} -->
comment
created
bors
username_3
:hourglass: Testing commit efed107648156d6c6f76bc89c58062bddbe30c62 with merge df18fa62b808db4f492d4a1665e91c6334d1215c...
<!-- homu: {"type":"BuildStarted","head_sha":"efed107648156d6c6f76bc89c58062bddbe30c62","merge_sha":"df18fa62b808db4f492d4a1665e91c6334d1215c"} -->
comment
created
bors
username_3
:broken_heart: Test failed - [checks-azure](https://dev.azure.com/rust-lang/473adcf1-6656-4c7e-9337-c393e7e0431c/_build/results?buildId=21356)
<!-- homu: {"type":"BuildFailed","builder_url":"https://dev.azure.com/rust-lang/473adcf1-6656-4c7e-9337-c393e7e0431c/_build/results?buildId=21356","builder_name":"checks-azure"} -->
comment
created
bors
username_3
:umbrella: The latest upstream changes (presumably #7820) made this pull request unmergeable. Please resolve the merge conflicts.
comment
created
ehuss
username_0
@username_3 retry
Failed to fetch https://packages.microsoft.com/ubuntu/16.04/prod/dists/xenial/main/binary-amd64/Packages  Writing more data than expected (670139 > 669553)
comment
created
ehuss
username_0
@username_3 retry
Failed to fetch https://packages.microsoft.com/ubuntu/16.04/prod/dists/xenial/main/binary-amd64/Packages Writing more data than expected (670139 > 669553)
comment
created
ehuss
username_0
@username_3 r=username_2
comment
created
bors
username_3
:pushpin: Commit 90887707ed5aea9f9a474d5708fc19e8966defcd has been approved by `username_2`

<!-- @username_3 r=username_2 90887707ed5aea9f9a474d5708fc19e8966defcd -->
<!-- homu: {"type":"Approved","sha":"90887707ed5aea9f9a474d5708fc19e8966defcd","approver":"username_2"} -->
comment
created
bors
username_3
:hourglass: Testing commit 90887707ed5aea9f9a474d5708fc19e8966defcd with merge 8d4db3e24b2ea1a0963365a3039d2837c64b2304...
<!-- homu: {"type":"BuildStarted","head_sha":"90887707ed5aea9f9a474d5708fc19e8966defcd","merge_sha":"8d4db3e24b2ea1a0963365a3039d2837c64b2304"} -->
comment
created
bors
username_3
:sunny: Test successful - [checks-azure](https://dev.azure.com/rust-lang/473adcf1-6656-4c7e-9337-c393e7e0431c/_build/results?buildId=21431)
Approved by: username_2
Pushing 8d4db3e24b2ea1a0963365a3039d2837c64b2304 to master...
<!-- homu: {"type":"BuildCompleted","approved_by":"username_2","base_ref":"master","builders":{"checks-azure":"https://dev.azure.com/rust-lang/473adcf1-6656-4c7e-9337-c393e7e0431c/_build/results?buildId=21431"},"merge_sha":"8d4db3e24b2ea1a0963365a3039d2837c64b2304"} -->
comment