opened
DiegoCardozo94
username_0
### Purpose
*What is the context of this pull request? Why is it being done?*

Executing the `generator-botbuilder-assistant` of `master` branch presents an issue in the `template.json` file to execute successfully the `deploy` script

### Changes
*Are there any changes that need to be called out as significant or particularly difficult to grasp? (Include illustrative screenshots for context if applicable.)*

- Fixed the `template.json` in **templates** and **samples**

### Tests
*Is this covered by existing tests or new ones? If no, why not?*
\-

### Feature Plan
*Are there any remaining steps or dependencies before this issue can be fully resolved? If so, describe and link to any relevant pull requests or issues.*
*-*
### Checklist

#### General
- [ ] I have commented my code, particularly in hard-to-understand areas	
- [ ] I have added or updated the appropriate tests	
- [ ] I have updated related documentation

#### Bots
- [ ] I have validated that new and updated responses use appropriate [Speak](https://docs.microsoft.com/en-us/azure/bot-service/dotnet/bot-builder-dotnet-text-to-speech?view=azure-bot-service-3.0) and [InputHint](https://docs.microsoft.com/en-us/azure/bot-service/dotnet/bot-builder-dotnet-add-input-hints?view=azure-bot-service-3.0) properties to ensure a high-quality speech-first experience
- [ ] I have replicated language model changes across the English, French, Italian, German, Spanish, and Chinese `.lu` files and validated that deployment is successful

#### Deployment Scripts
- [ ] I have replicated my changes in the **Virtual Assistant Template** and **Sample** projects
- [ ] I have replicated my changes in the **Skill Template** and **Sample** projects
[TypeScript][Generator] Solve JSON parsing errors of template.json file
issue
created
darrenj
username_1
Out of interest - the template.json file should be the same across csharp/typescript. Has there been a need to make specific changes to the typescript version?
comment
created
dfavretto
username_2
@username_1 we updated the _template.json_ precisely to be similar to the one in C#, as in a previous changes the TypeScript _template.json_ had some errors introduced while solving some merge conflicts.

Right now, with this change, both _template.json_ are almost equal except for a few differences:
- **AppInsights** name has been always different between C# (`ApplicationInsights`) and TypeScript (`appInsights`).
- The **instrumentation key** property has a different casing, being Upper Camelcase in C# (`IntrumentationKey`) and Lower Camelcase in TypeScript (`instrumentationKey`)
- The TypeScript version has an extra property in the **Bot Web App** exclusive for NodeJS for the default Node version, and also a property for `CORS` ([documentation](https://developer.mozilla.org/en-US/docs/Web/HTTP/CORS)), which was added in the [PR #1374](https://github.com/microsoft/botframework-solutions/pull/1374/files?file-filters%5B%5D=.json#diff-500d21b45d4a92d3487bf63fa8916225R161) but only in TypeScript Skill's _template.json_.

![image](https://user-images.githubusercontent.com/23645105/70093426-2502b680-15ff-11ea-8439-cf770f276736.png)
comment