opened
tylerturdenpants
username_0
Get telemetry data
issue
created
tylerturdenpants
username_0
@username_1 this is blocked on a 1.0.1 release of `ember-codemods-telemetry-helpers` Thanks!
comment
created
rwjblue
username_1
Should be ready to rebase and bump to the more recent telemetry helpers
comment
created
tylerturdenpants
username_0
Before we release this, I need to update the readme
comment
created
tylerturdenpants
username_0
I think I want to add some test coverage to all of this. @username_1 It’s up to you if you want to merge.
comment
created
tylerturdenpants
username_0
I’ll resolve the conflicts. I’m almost certain once the conflicts are resolved, the coverage should go back up. The reason is the branching in deciding how to handle the component/helper data. The branch lets the telemetry-less tests pass. However, since I unified the tests to always work with either mock or real telemetry in all cases, the branching will not be needed.
comment
created
tylerturdenpants
username_0
I'm going to address some of the coverage issues.  I need to cover the rare cases for some of the branching that trying to avoid blowing up if certain data doesn't exist.  But you think it looks good otherwise?
comment
created
rwjblue
username_1
Yep! I'm also fine landing and working on code coverage separately.
comment
created
tylerturdenpants
username_0
Ok.  there is also some components that need to be identified by path alone when there is no backing js file
comment
created
tylerturdenpants
username_0
@username_1 I have fixed the test coverage.  The only thing blocking is this [PR](https://github.com/ember-codemods/ember-codemods-telemetry-helpers/pull/25).  let me know what you think
comment