opened
peterbell10
username_0
I've tested this fixes #3990.
Replace std::function with cFunctionRef in item callbacks
issue
created
LogicParrot
username_1
Please note the lambda changes were reverted in master. You need to re-add everything in this pull request.
comment
created
peterbell10
username_0
Well I guess this will have to include all of #3948 now.
comment
created
madmaxoft
username_2
I assume the changes are identical to the original PR that was merged and then reverted, and then only changed into using `cFunctionRef`. The cFunctionRef still needs a bit more documentation, it would be great to know why it's needed, why std::function won't work for us (even add a reference to the GH issue in the doxy-comment), so that anyone reading the code knows immediately what it does, without diving into its details.
comment
created
peterbell10
username_0
Yes the changes are identical, in fact this is literally #3948 with my last commit `git reset` away.
comment
created
madmaxoft
username_2
And I assume you tested against the 3990
comment
created
peterbell10
username_0
Yup, assuming the comment didn't break anything anyway.
comment