opened
makuk66
username_0
See [Announcement](http://mail-archives.apache.org/mod_mbox/lucene-solr-user/201912.mbox/%3cCAPsWd+NPnY-0=H4-otoy4soSWvCwMckuWpaCOFM83J=DuhjjUw@mail.gmail.com%3e)

Make sure to read the [upgrade notes](https://lucene.apache.org/solr/guide/8_4/solr-upgrade-notes.html); there have been changes to the default config that may require you to take action.

One the docker-solr side, there was a fix to the `oom.sh` script, and some house-keeping changes.
Add Solr 8.4
issue
created
yosifkit
username_1
<details>
<summary>Diff:</summary>

```diff
diff --git a/_bashbrew-arches b/_bashbrew-arches
index 911cfd9..1831af8 100644
--- a/_bashbrew-arches
+++ b/_bashbrew-arches
@@ -26,6 +26,10 @@ solr:8.2 @ amd64
 solr:8.2 @ arm64v8
 solr:8.2-slim @ amd64
 solr:8.2-slim @ arm64v8
+solr:8.3 @ amd64
+solr:8.3 @ arm64v8
+solr:8.3-slim @ amd64
+solr:8.3-slim @ arm64v8
 solr:latest @ amd64
 solr:latest @ arm64v8
 solr:slim @ amd64
diff --git a/_bashbrew-list b/_bashbrew-list
index a1187cb..1d698b4 100644
--- a/_bashbrew-list
+++ b/_bashbrew-list
@@ -42,5 +42,9 @@ solr:8.3
 solr:8.3-slim
 solr:8.3.1
 solr:8.3.1-slim
+solr:8.4
+solr:8.4-slim
+solr:8.4.0
+solr:8.4.0-slim
 solr:latest
 solr:slim
diff --git a/solr_slim/Dockerfile b/solr_8.3-slim/Dockerfile
similarity index 100%
copy from solr_slim/Dockerfile
copy to solr_8.3-slim/Dockerfile
diff --git a/solr_5-slim/scripts/docker-entrypoint.sh b/solr_8.3-slim/scripts/docker-entrypoint.sh
similarity index 100%
copy from solr_5-slim/scripts/docker-entrypoint.sh
copy to solr_8.3-slim/scripts/docker-entrypoint.sh
diff --git a/solr_8.0-slim/scripts/init-var-solr b/solr_8.3-slim/scripts/init-var-solr
similarity index 100%
copy from solr_8.0-slim/scripts/init-var-solr
copy to solr_8.3-slim/scripts/init-var-solr
diff --git a/solr_8.0-slim/scripts/oom_solr.sh b/solr_8.3-slim/scripts/oom_solr.sh
similarity index 100%
copy from solr_8.0-slim/scripts/oom_solr.sh
copy to solr_8.3-slim/scripts/oom_solr.sh
diff --git a/solr_8.0-slim/scripts/precreate-core b/solr_8.3-slim/scripts/precreate-core
similarity index 100%
copy from solr_8.0-slim/scripts/precreate-core
copy to solr_8.3-slim/scripts/precreate-core
diff --git a/solr_8.0-slim/scripts/run-initdb b/solr_8.3-slim/scripts/run-initdb
similarity index 100%
copy from solr_8.0-slim/scripts/run-initdb
copy to solr_8.3-slim/scripts/run-initdb
diff --git a/solr_8.0-slim/scripts/solr-create b/solr_8.3-slim/scripts/solr-create
similarity index 100%
copy from solr_8.0-slim/scripts/solr-create
copy to solr_8.3-slim/scripts/solr-create
diff --git a/solr_8.0-slim/scripts/solr-demo b/solr_8.3-slim/scripts/solr-demo
similarity index 100%
copy from solr_8.0-slim/scripts/solr-demo
copy to solr_8.3-slim/scripts/solr-demo
diff --git a/solr_5-slim/scripts/solr-fg b/solr_8.3-slim/scripts/solr-fg
similarity index 100%
copy from solr_5-slim/scripts/solr-fg
copy to solr_8.3-slim/scripts/solr-fg
diff --git a/solr_8.0-slim/scripts/solr-foreground b/solr_8.3-slim/scripts/solr-foreground
similarity index 100%
copy from solr_8.0-slim/scripts/solr-foreground
copy to solr_8.3-slim/scripts/solr-foreground
diff --git a/solr_8.0-slim/scripts/solr-precreate b/solr_8.3-slim/scripts/solr-precreate
similarity index 100%
copy from solr_8.0-slim/scripts/solr-precreate
copy to solr_8.3-slim/scripts/solr-precreate
diff --git a/solr_8.0-slim/scripts/start-local-solr b/solr_8.3-slim/scripts/start-local-solr
similarity index 100%
copy from solr_8.0-slim/scripts/start-local-solr
copy to solr_8.3-slim/scripts/start-local-solr
diff --git a/solr_5-slim/scripts/stop-local-solr b/solr_8.3-slim/scripts/stop-local-solr
similarity index 100%
copy from solr_5-slim/scripts/stop-local-solr
copy to solr_8.3-slim/scripts/stop-local-solr
diff --git a/solr_5-slim/scripts/wait-for-solr.sh b/solr_8.3-slim/scripts/wait-for-solr.sh
similarity index 100%
copy from solr_5-slim/scripts/wait-for-solr.sh
copy to solr_8.3-slim/scripts/wait-for-solr.sh
diff --git a/solr_8.0-slim/scripts/wait-for-zookeeper.sh b/solr_8.3-slim/scripts/wait-for-zookeeper.sh
similarity index 100%
copy from solr_8.0-slim/scripts/wait-for-zookeeper.sh
copy to solr_8.3-slim/scripts/wait-for-zookeeper.sh
diff --git a/solr_latest/Dockerfile b/solr_8.3/Dockerfile
similarity index 100%
copy from solr_latest/Dockerfile
copy to solr_8.3/Dockerfile
diff --git a/solr_5-slim/scripts/docker-entrypoint.sh b/solr_8.3/scripts/docker-entrypoint.sh
similarity index 100%
copy from solr_5-slim/scripts/docker-entrypoint.sh
copy to solr_8.3/scripts/docker-entrypoint.sh
diff --git a/solr_8.0-slim/scripts/init-var-solr b/solr_8.3/scripts/init-var-solr
similarity index 100%
copy from solr_8.0-slim/scripts/init-var-solr
copy to solr_8.3/scripts/init-var-solr
diff --git a/solr_8.0-slim/scripts/oom_solr.sh b/solr_8.3/scripts/oom_solr.sh
similarity index 100%
copy from solr_8.0-slim/scripts/oom_solr.sh
copy to solr_8.3/scripts/oom_solr.sh
diff --git a/solr_8.0-slim/scripts/precreate-core b/solr_8.3/scripts/precreate-core
similarity index 100%
copy from solr_8.0-slim/scripts/precreate-core
copy to solr_8.3/scripts/precreate-core
diff --git a/solr_8.0-slim/scripts/run-initdb b/solr_8.3/scripts/run-initdb
similarity index 100%
copy from solr_8.0-slim/scripts/run-initdb
copy to solr_8.3/scripts/run-initdb
diff --git a/solr_8.0-slim/scripts/solr-create b/solr_8.3/scripts/solr-create
similarity index 100%
copy from solr_8.0-slim/scripts/solr-create
copy to solr_8.3/scripts/solr-create
diff --git a/solr_8.0-slim/scripts/solr-demo b/solr_8.3/scripts/solr-demo
similarity index 100%
copy from solr_8.0-slim/scripts/solr-demo
copy to solr_8.3/scripts/solr-demo
diff --git a/solr_5-slim/scripts/solr-fg b/solr_8.3/scripts/solr-fg
similarity index 100%
copy from solr_5-slim/scripts/solr-fg
copy to solr_8.3/scripts/solr-fg
diff --git a/solr_8.0-slim/scripts/solr-foreground b/solr_8.3/scripts/solr-foreground
similarity index 100%
copy from solr_8.0-slim/scripts/solr-foreground
copy to solr_8.3/scripts/solr-foreground
diff --git a/solr_8.0-slim/scripts/solr-precreate b/solr_8.3/scripts/solr-precreate
similarity index 100%
copy from solr_8.0-slim/scripts/solr-precreate
copy to solr_8.3/scripts/solr-precreate
diff --git a/solr_8.0-slim/scripts/start-local-solr b/solr_8.3/scripts/start-local-solr
similarity index 100%
copy from solr_8.0-slim/scripts/start-local-solr
copy to solr_8.3/scripts/start-local-solr
diff --git a/solr_5-slim/scripts/stop-local-solr b/solr_8.3/scripts/stop-local-solr
similarity index 100%
copy from solr_5-slim/scripts/stop-local-solr
copy to solr_8.3/scripts/stop-local-solr
diff --git a/solr_5-slim/scripts/wait-for-solr.sh b/solr_8.3/scripts/wait-for-solr.sh
similarity index 100%
copy from solr_5-slim/scripts/wait-for-solr.sh
copy to solr_8.3/scripts/wait-for-solr.sh
diff --git a/solr_8.0-slim/scripts/wait-for-zookeeper.sh b/solr_8.3/scripts/wait-for-zookeeper.sh
similarity index 100%
copy from solr_8.0-slim/scripts/wait-for-zookeeper.sh
copy to solr_8.3/scripts/wait-for-zookeeper.sh
diff --git a/solr_latest/Dockerfile b/solr_latest/Dockerfile
index fc75c83..5a5c9c1 100644
--- a/solr_latest/Dockerfile
+++ b/solr_latest/Dockerfile
@@ -17,12 +17,12 @@ ENV SOLR_USER="solr" \
     SOLR_UID="8983" \
     SOLR_GROUP="solr" \
     SOLR_GID="8983" \
-    SOLR_VERSION="8.3.1" \
-    SOLR_CLOSER_URL="http://www.apache.org/dyn/closer.lua?filename=lucene/solr/8.3.1/solr-8.3.1.tgz&action=download" \
-    SOLR_DIST_URL="https://www.apache.org/dist/lucene/solr/8.3.1/solr-8.3.1.tgz" \
-    SOLR_ARCHIVE_URL="https://archive.apache.org/dist/lucene/solr/8.3.1/solr-8.3.1.tgz" \
-    SOLR_SHA256="300ae2632e1221aa4e4e4ffd317604dc0ee72f7af39cf78a7ba0e9b641320059" \
-    SOLR_KEYS="2085660D9C1FCCACC4A479A3BF160FF14992A24C" \
+    SOLR_VERSION="8.4.0" \
+    SOLR_CLOSER_URL="http://www.apache.org/dyn/closer.lua?filename=lucene/solr/8.4.0/solr-8.4.0.tgz&action=download" \
+    SOLR_DIST_URL="https://www.apache.org/dist/lucene/solr/8.4.0/solr-8.4.0.tgz" \
+    SOLR_ARCHIVE_URL="https://archive.apache.org/dist/lucene/solr/8.4.0/solr-8.4.0.tgz" \
+    SOLR_SHA256="66e7ed14e5ba8ac81af7749700cafac7ab49239137ddba92ae8bf863100f81a6" \
+    SOLR_KEYS="E6E21FFCDCEA14C95910EA65051A0FAF76BC6507" \
     PATH="/opt/solr/bin:/opt/docker-solr/scripts:$PATH" \
     SOLR_INCLUDE=/etc/default/solr.in.sh \
     SOLR_HOME=/var/solr/data \
diff --git a/solr_slim/Dockerfile b/solr_slim/Dockerfile
index 43f8ba0..a2a23fd 100644
--- a/solr_slim/Dockerfile
+++ b/solr_slim/Dockerfile
@@ -17,12 +17,12 @@ ENV SOLR_USER="solr" \
     SOLR_UID="8983" \
     SOLR_GROUP="solr" \
     SOLR_GID="8983" \
-    SOLR_VERSION="8.3.1" \
-    SOLR_CLOSER_URL="http://www.apache.org/dyn/closer.lua?filename=lucene/solr/8.3.1/solr-8.3.1.tgz&action=download" \
-    SOLR_DIST_URL="https://www.apache.org/dist/lucene/solr/8.3.1/solr-8.3.1.tgz" \
-    SOLR_ARCHIVE_URL="https://archive.apache.org/dist/lucene/solr/8.3.1/solr-8.3.1.tgz" \
-    SOLR_SHA256="300ae2632e1221aa4e4e4ffd317604dc0ee72f7af39cf78a7ba0e9b641320059" \
-    SOLR_KEYS="2085660D9C1FCCACC4A479A3BF160FF14992A24C" \
+    SOLR_VERSION="8.4.0" \
+    SOLR_CLOSER_URL="http://www.apache.org/dyn/closer.lua?filename=lucene/solr/8.4.0/solr-8.4.0.tgz&action=download" \
+    SOLR_DIST_URL="https://www.apache.org/dist/lucene/solr/8.4.0/solr-8.4.0.tgz" \
+    SOLR_ARCHIVE_URL="https://archive.apache.org/dist/lucene/solr/8.4.0/solr-8.4.0.tgz" \
+    SOLR_SHA256="66e7ed14e5ba8ac81af7749700cafac7ab49239137ddba92ae8bf863100f81a6" \
+    SOLR_KEYS="E6E21FFCDCEA14C95910EA65051A0FAF76BC6507" \
     PATH="/opt/solr/bin:/opt/docker-solr/scripts:$PATH" \
     SOLR_INCLUDE=/etc/default/solr.in.sh \
     SOLR_HOME=/var/solr/data \
```

</details>
comment
created
yosifkit
username_1
Build test of #7212; 5315721d; `amd64` (`solr`):

```console

$ bashbrew build solr:8.4.0
Building bashbrew/cache:1ae137f1c49bcc7eaf23bb036398a348c978d6b2f7813ea48595db968d4082e9 (solr:8.4.0)
Tagging solr:8.4.0
Tagging solr:8.4
Tagging solr:8
Tagging solr:latest

$ test/run.sh solr:8.4.0
testing solr:8.4.0
	'utc' [1/4]...passed
	'cve-2014--shellshock' [2/4]...passed
	'no-hard-coded-passwords' [3/4]...passed
	'override-cmd' [4/4]...passed


$ bashbrew build solr:8.4.0-slim
Building bashbrew/cache:220db60b0e2053861f57d6d86ce42137af528d2455a070be60e63e4d15206413 (solr:8.4.0-slim)
Tagging solr:8.4.0-slim
Tagging solr:8.4-slim
Tagging solr:8-slim
Tagging solr:slim

$ test/run.sh solr:8.4.0-slim
testing solr:8.4.0-slim
	'utc' [1/4]...passed
	'cve-2014--shellshock' [2/4]...passed
	'no-hard-coded-passwords' [3/4]...passed
	'override-cmd' [4/4]...passed


$ bashbrew build solr:8.3.1
Using bashbrew/cache:a554b509773cf46cc65e68303ebc3a3b42ef12f263c96db3a0dde23e81f4a0d3 (solr:8.3.1)
Tagging solr:8.3.1
Tagging solr:8.3

$ test/run.sh solr:8.3.1
testing solr:8.3.1
	'utc' [1/4]...passed
	'cve-2014--shellshock' [2/4]...passed
	'no-hard-coded-passwords' [3/4]...passed
	'override-cmd' [4/4]...passed


$ bashbrew build solr:8.3.1-slim
Using bashbrew/cache:2625fcd971ddf89541d8bb0ce173db39cbbbd1a96a22452f88632b3cf08f2012 (solr:8.3.1-slim)
Tagging solr:8.3.1-slim
Tagging solr:8.3-slim

$ test/run.sh solr:8.3.1-slim
testing solr:8.3.1-slim
	'utc' [1/4]...passed
	'cve-2014--shellshock' [2/4]...passed
	'no-hard-coded-passwords' [3/4]...passed
	'override-cmd' [4/4]...passed


$ bashbrew build solr:8.2.0
Using bashbrew/cache:aaaa3aeea055e3b36262ec49a008e8d1ac9721d47e954950710b8861dd04fd05 (solr:8.2.0)
Tagging solr:8.2.0
Tagging solr:8.2

$ test/run.sh solr:8.2.0
testing solr:8.2.0
	'utc' [1/4]...passed
	'cve-2014--shellshock' [2/4]...passed
	'no-hard-coded-passwords' [3/4]...passed
	'override-cmd' [4/4]...passed


$ bashbrew build solr:8.2.0-slim
Using bashbrew/cache:5e4842803287476df1fbe4322cfb26aacfb1d52988ed6174edfe981eca482cd2 (solr:8.2.0-slim)
Tagging solr:8.2.0-slim
Tagging solr:8.2-slim

$ test/run.sh solr:8.2.0-slim
testing solr:8.2.0-slim
	'utc' [1/4]...passed
	'cve-2014--shellshock' [2/4]...passed
	'no-hard-coded-passwords' [3/4]...passed
	'override-cmd' [4/4]...passed


$ bashbrew build solr:8.1.1
Using bashbrew/cache:3fadf6ec22607d937960c07b8c4cb9e851f509a374d4c90ba5cb71ad7d507feb (solr:8.1.1)
Tagging solr:8.1.1
Tagging solr:8.1

$ test/run.sh solr:8.1.1
testing solr:8.1.1
	'utc' [1/4]...passed
	'cve-2014--shellshock' [2/4]...passed
	'no-hard-coded-passwords' [3/4]...passed
	'override-cmd' [4/4]...passed


$ bashbrew build solr:8.1.1-slim
Using bashbrew/cache:05d1108a832aa0a4922dd34fcc9875f4368cb443ded65fd69a5117c8017c43bd (solr:8.1.1-slim)
Tagging solr:8.1.1-slim
Tagging solr:8.1-slim

$ test/run.sh solr:8.1.1-slim
testing solr:8.1.1-slim
	'utc' [1/4]...passed
	'cve-2014--shellshock' [2/4]...passed
	'no-hard-coded-passwords' [3/4]...passed
	'override-cmd' [4/4]...passed


$ bashbrew build solr:8.0.0
Using bashbrew/cache:0899a38b707c232583a00d6759f51d3c031a8ce602541c81ab6a07f9a4792224 (solr:8.0.0)
Tagging solr:8.0.0
Tagging solr:8.0

$ test/run.sh solr:8.0.0
testing solr:8.0.0
	'utc' [1/4]...passed
	'cve-2014--shellshock' [2/4]...passed
	'no-hard-coded-passwords' [3/4]...passed
	'override-cmd' [4/4]...passed


$ bashbrew build solr:8.0.0-slim
Using bashbrew/cache:7eb3b57f9819454b9d424003a3e7cb1f64626a549a317bbd3caa55db693b0484 (solr:8.0.0-slim)
Tagging solr:8.0.0-slim
Tagging solr:8.0-slim

$ test/run.sh solr:8.0.0-slim
testing solr:8.0.0-slim
	'utc' [1/4]...passed
	'cve-2014--shellshock' [2/4]...passed
	'no-hard-coded-passwords' [3/4]...passed
	'override-cmd' [4/4]...passed


$ bashbrew build solr:7.7.2
Using bashbrew/cache:5b236b869c2229a66f539c7ffa9ee952dc0bc0edd0024a34dd03a39a4f069042 (solr:7.7.2)
Tagging solr:7.7.2
Tagging solr:7.7
Tagging solr:7

$ test/run.sh solr:7.7.2
testing solr:7.7.2
	'utc' [1/4]...passed
	'cve-2014--shellshock' [2/4]...passed
	'no-hard-coded-passwords' [3/4]...passed
	'override-cmd' [4/4]...passed


$ bashbrew build solr:7.7.2-slim
Using bashbrew/cache:f80d1ed3bfa704c2480163eda581088f4685f2815b1c1f13e4a9da1e6026fca5 (solr:7.7.2-slim)
Tagging solr:7.7.2-slim
Tagging solr:7.7-slim
Tagging solr:7-slim

$ test/run.sh solr:7.7.2-slim
testing solr:7.7.2-slim
	'utc' [1/4]...passed
	'cve-2014--shellshock' [2/4]...passed
	'no-hard-coded-passwords' [3/4]...passed
	'override-cmd' [4/4]...passed


$ bashbrew build solr:7.6.0
Using bashbrew/cache:b4689a9cca6c72243ec4d0803742f79192c69dd6fdae8a9ca288844963ce40b5 (solr:7.6.0)
Tagging solr:7.6.0
Tagging solr:7.6

$ test/run.sh solr:7.6.0
testing solr:7.6.0
	'utc' [1/4]...passed
	'cve-2014--shellshock' [2/4]...passed
	'no-hard-coded-passwords' [3/4]...passed
	'override-cmd' [4/4]...passed


$ bashbrew build solr:7.6.0-slim
Using bashbrew/cache:09e9f85ba5f1dedc7886e785eb342fe10349f7d23ad8095967737c213de4dc11 (solr:7.6.0-slim)
Tagging solr:7.6.0-slim
Tagging solr:7.6-slim

$ test/run.sh solr:7.6.0-slim
testing solr:7.6.0-slim
	'utc' [1/4]...passed
	'cve-2014--shellshock' [2/4]...passed
	'no-hard-coded-passwords' [3/4]...passed
	'override-cmd' [4/4]...passed


$ bashbrew build solr:7.5.0
Using bashbrew/cache:3009c5493b5b761b39ef6de982b2f2a30ace768751283407b1e9ee15723bbbaa (solr:7.5.0)
Tagging solr:7.5.0
Tagging solr:7.5

$ test/run.sh solr:7.5.0
testing solr:7.5.0
	'utc' [1/4]...passed
	'cve-2014--shellshock' [2/4]...passed
	'no-hard-coded-passwords' [3/4]...passed
	'override-cmd' [4/4]...passed


$ bashbrew build solr:7.5.0-slim
Using bashbrew/cache:0e0cee3711a9c76fe7c21a9b9cf7d499962460a8f172bb2b6c78bcd5d80c1278 (solr:7.5.0-slim)
Tagging solr:7.5.0-slim
Tagging solr:7.5-slim

$ test/run.sh solr:7.5.0-slim
testing solr:7.5.0-slim
	'utc' [1/4]...passed
	'cve-2014--shellshock' [2/4]...passed
	'no-hard-coded-passwords' [3/4]...passed
	'override-cmd' [4/4]...passed


$ bashbrew build solr:6.6.6
Using bashbrew/cache:4431144693e1093caa0bac246366fef13eed415ee4a0053a7c0e21b793e0e84a (solr:6.6.6)
Tagging solr:6.6.6
Tagging solr:6.6
Tagging solr:6

$ test/run.sh solr:6.6.6
testing solr:6.6.6
	'utc' [1/4]...passed
	'cve-2014--shellshock' [2/4]...passed
	'no-hard-coded-passwords' [3/4]...passed
	'override-cmd' [4/4]...passed


$ bashbrew build solr:6.6.6-slim
Using bashbrew/cache:a96ac707a16c78ca86e1d17fa1ba85282ecd5dd9535333769622d555504ffba1 (solr:6.6.6-slim)
Tagging solr:6.6.6-slim
Tagging solr:6.6-slim
Tagging solr:6-slim

$ test/run.sh solr:6.6.6-slim
testing solr:6.6.6-slim
	'utc' [1/4]...passed
	'cve-2014--shellshock' [2/4]...passed
	'no-hard-coded-passwords' [3/4]...passed
	'override-cmd' [4/4]...passed


$ bashbrew build solr:5.5.5
Using bashbrew/cache:adc85f8ce5a5f574059e2283882ff4b1b9c3b5bd1b7f8c1b086f58d84b7c326c (solr:5.5.5)
Tagging solr:5.5.5
Tagging solr:5.5
Tagging solr:5

$ test/run.sh solr:5.5.5
testing solr:5.5.5
	'utc' [1/4]...passed
	'cve-2014--shellshock' [2/4]...passed
	'no-hard-coded-passwords' [3/4]...passed
	'override-cmd' [4/4]...passed


$ bashbrew build solr:5.5.5-slim
Using bashbrew/cache:d6cabe9705012418c82a93f1b5bb1c748712e6c1171c31def0c004d96f2d6f85 (solr:5.5.5-slim)
Tagging solr:5.5.5-slim
Tagging solr:5.5-slim
Tagging solr:5-slim

$ test/run.sh solr:5.5.5-slim
testing solr:5.5.5-slim
	'utc' [1/4]...passed
	'cve-2014--shellshock' [2/4]...passed
	'no-hard-coded-passwords' [3/4]...passed
	'override-cmd' [4/4]...passed

```
comment