opened
CharlesStover
username_0
Added functional anchorEl support for Popover (resolves #10411)
Added functional anchorEl support for Popover
issue
created
CharlesStover
username_0
I'm not sure what it's asking to be changed about this.
I see "no nested ternary operators," but I'd rather not guess-and-check with 12 commits as to how exactly it wasn't it formatted. I apparently don't have the same linting rules in my editor.
comment
created
mbrookes
username_1
Not meaning to be facetious, but the error is pretty self explanatory. You have a ternary that contains a ternary. I was originally going to comment on it until I saw that eslint picked it up. 

If you're unsure what an eslint rule means though, googling it is usually helpful. In this case: https://eslint.org/docs/rules/no-nested-ternary

If your editor doesn't support eslint (most do!), you can run it manually with `yarn eslint` (or `npm run eslint`). Better still `yarn eslint:fix` will fix many formatting issues for you automatically; and some editors (hello WebStorm!) have that built in too.
comment
created
CharlesStover
username_0
It isn't so much that I don't know what the error means, but that without it being replicated in my editor, I didn't feel the best option was to commit 12 times until I happened to provide the solution it wanted. I can come up with possible solutions to the errors, but ultimately I currently have valid code being rejected; my fixes will be valid code, so I have no reason to believe they won't be rejected. I will attempt to fix them, but as I don't know positively what `test_browser` or `prettier` is asking of me, it may take a few attempts.
comment
created
mbrookes
username_1
@username_0 If you read the rest of my reply, you might find some answers.
comment
created
CharlesStover
username_0
Sorry, but your reply did not tell me anything I did not already know.
comment