opened
manchicken
username_0
### Pull Request check-list

_Please make sure to review and check all of these items:_

- [X] Does `npm run test` or `npm run test-DIALECT` pass with this change (including linting)?
 + One caveat, tests are failing on `master`. My tests fail identically to those on `master`.
- [X] Does your issue contain a link to existing issue (Closes #5900) or a description of the issue you are solving?
- [X] Have you added new tests to prevent regressions?
- [N/A] Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
- [X] Have you added an entry under `Future` in the changelog?

_NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open._

### Description of change

This provides the ability for MySQL logs to be reported using the existing `sequelize.log()` functionality. This should help people find issues which MySQL doesn't consider errors, but does consider worthy of warning on.
Adding the ability to log warnings if they are present in MySQL.
issue
created
manchicken
username_0
So, it looks like some PGSQL tests are failing. I don't have any diffs in that area, so I'm not sure what's up with that. Are there known issues running the Travis-CI suite against PGSQL?
comment
created
janmeier
username_1
I like the idea, once my comments are adressed this should be good to merge
comment
created
janmeier
username_1
I don't know if we would need an option to turn this of perhaps?
comment
created
manchicken
username_0
@username_1: Thanks so much for your feedback. I've updated the pull request, thanks for your help.
comment
created
janmeier
username_1
@username_0 Needs a rebase and a couple of small style fixes
comment
created
manchicken
username_0
If we're down to just nitpicks I don't mind :)

How's everything else? It looks like there's a Travis CI build failure, but I don't know if that's "normal".
comment
created
janmeier
username_1
comment
created
manchicken
username_0
Sorry, totally forgot to jshint with this latest push. Need to install the
sublimetext plugin so I can't forget.
comment
created
janmeier
username_1
No problem, ping me when you have fixed + rebased ;)
comment
created
manchicken
username_0
I think that's everything. Did I miss anything?
comment
created
janmeier
username_1
Branch still has conflicts - did you do a `git rebase -i upstream/master` (where upstream = the main repo)
comment
created
manchicken
username_0
I thought I had. That's weird. I'll try again.
comment
created
manchicken
username_0
I just pushed a second attempt of the rebase... it shows no diffs between `upstream/master` other than the ones in my pull request.
comment
created
manchicken
username_0
(sorry for all of the noise, totally forgot to fetch before rebasing)
comment
created
manchicken
username_0
Looks like I need to fix the regex on my test.
comment
created
manchicken
username_0
@username_1: any thoughts on how to proceed?
comment
created
janmeier
username_1
Make the test mysql only - the other dialects are failing when trying to insert `HORSE` ;)
comment
created
manchicken
username_0
Seems so obvious when you say it. :-)
comment
created
manchicken
username_0
@username_1: are there any next steps?
comment
created
janmeier
username_1
Nothing other than for me to press the big, green merge button - thanks for your time :) !
comment
created
manchicken
username_0
Thank you very much. Let me know if I can help the project with something
else.
comment