opened
mavasani
username_0
1. Due to lack of a *real* CFG (#1567), we did not correctly merge analysis states from all return statements at CFG exit block. This change adds a temporary workaround to correctly track analysis state for methods with intermediate return statements.
2. Due to pending dataflow support for tuple operations (#1571), we need to pessimistically reset the analysis values for all tuple elements to ensure we do not report incorrect violations for dispose rules.
Couple more fixes to flow analysis for false positives on Roslyn.sln
issue
created
mavasani
username_0
Ping.. I need to merge this PR to enable dogfooding these rules on Roslyn.sln.
comment
created
mavasani
username_0
There are no more unexpected false positives on Roslyn.sln after incorporating these fixes.
comment