opened
manojkverma
username_0
Features:

1. Zone-wide and cluster-wide primary storage support
2. VM template caching automatically on Datera, the subsequent VMs can be created instantaneously by fast cloning the root volume.
3. Rapid storage-native snapshot
4. Multiple managed primary storages can be created with a single Datera cluster to provide better management of
      - Total provisioned capacity
      - Default storage QoS values
      - Replica size ( 1 to 5 )
      - IP pool assignment for iSCSI target
      - Volume Placement ( hybrid, single_flash, all_flash )
 5. Volume snapshot to VM template
 6. Volume to VM template
 7. Volume size increase using service policy
 8. Volume QoS change using service policy
 9. Enabled KVM support
10. New Datera app_instance name format to include ACS volume name
11. VM live migration
[WIP] Add Datera storage plugin
issue
created
manojkverma
username_0
This is same plugin from https://github.com/username_6/cloudstack
since @username_6 is on vacation, I made a few fixes for him.
comment
created
rhtyd
username_1
@username_2 package
comment
created
blueorangutan
username_2
@username_1 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
comment
created
blueorangutan
username_2
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-90
comment
created
borisstoyanov
username_3
@username_2 test
comment
created
blueorangutan
username_2
@username_3 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
comment
created
blueorangutan
username_2
<b>Trillian test result (tid-105)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 27179 seconds
Marvin logs: https://github.com/username_2/acs-prs/releases/download/trillian/pr3470-t105-kvm-centos7.zip
Smoke tests completed. 71 look OK, 1 have error(s)
Only failed tests results shown below:
comment
created
rhtyd
username_1
Tests LGTM, we don't have datera infra to test the plugin. @username_4 can you share your code review and test details if any. As @username_3 mentions, any tests are welcome.
comment
created
manojkverma
username_0
Thanks @username_1, I am sorry, I am new to open source development model, so thanks for bearing with me as I am working on this. @username_6 had python based integration test cases, which he ran against datera storage hardware. I am looking into getting java unit test to work with mock objects.
comment
created
rhtyd
username_1
@username_6 can you work with @username_4 on top of this PR? Also, what we're looking for are list of tests results (see other smoketests for example). Ideally, if you'd prefer you can add marvin smoketests to `test/integration/plugins/` of the source tree.
comment
created
swill
username_4
@username_0 & @username_6, if you can post the results of the python integration tests which you ran against the datara storage hardware, that would go a long way towards helping the community understand the current state of the plugin.  I agree with @username_1 that adding marvin smoketests to `test/integration/plugins/` is the ideal way to contribute the tests upstream.
comment
created
rhtyd
username_1
We're getting closer to 4.13.0.0 freeze date, ping @username_0 @username_6
comment
created
shwstppr
username_5
@username_0 @username_6 any update on this?
comment
created
jcsdatera
username_6
We are still working on this and very close.

Thank you
comment
created
jcsdatera
username_6
Added integrated tests with the following test result:

<pre> 
Attach a volume to a stopped virtual machine, then start VM ... === TestName: test_01_attach_new_volume_to_stopped_VM | Status : SUCCESS ===
ok
Attach, detach, and attach volume to a running VM ... === TestName: test_02_attach_detach_attach_volume | Status : SUCCESS ===
ok
Attach volume to running VM, then reboot. ... === TestName: test_03_attached_volume_reboot_VM | Status : SUCCESS ===
ok

----------------------------------------------------------------------
XML: /data/git/cs1/cloudstack/test/integration/nosetests.xml
----------------------------------------------------------------------
Ran 3 tests in 885.349s

OK</pre>
comment
created
rhtyd
username_1
@username_2 package
comment
created
blueorangutan
username_2
@username_1 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
comment
created
blueorangutan
username_2
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-172
comment
created
rhtyd
username_1
@username_2 test
comment
created
blueorangutan
username_2
@username_1 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
comment
created
blueorangutan
username_2
<b>Trillian test result (tid-199)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36279 seconds
Marvin logs: https://github.com/username_2/acs-prs/releases/download/trillian/pr3470-t199-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 75 look OK, 2 have error(s)
Only failed tests results shown below:


Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 207.86 | test_internal_lb.py
test_05_rvpc_multi_tiers | `Failure` | 419.43 | test_vpc_redundant.py
test_05_rvpc_multi_tiers | `Error` | 449.91 | test_vpc_redundant.py
comment
created
rhtyd
username_1
@username_2 test
comment
created
blueorangutan
username_2
@username_1 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
comment
created
jcsdatera
username_6
Ping @username_1, @username_4 
I noticed that this PR has been moved from milestone 4.13.0.0 to 4.14.0.0
Actually, we spent most of our time passing the tests until we apply the patch of  [#3497](https://github.com/apache/cloudstack/issues/3497)

If 4.13.0 deadline has passed, is it possible to mark this to the next 4.13.1 instead?
comment
created
blueorangutan
username_2
<b>Trillian test result (tid-209)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 30048 seconds
Marvin logs: https://github.com/username_2/acs-prs/releases/download/trillian/pr3470-t209-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 75 look OK, 2 have error(s)
Only failed tests results shown below:


Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_cancel_host_maintenace_with_no_migration_jobs | `Failure` | 1.17 | test_host_maintenance.py
test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 3.70 | test_host_maintenance.py
test_hostha_enable_ha_when_host_disabled | `Error` | 2.67 | test_hostha_kvm.py
test_hostha_enable_ha_when_host_in_maintenance | `Error` | 301.85 | test_hostha_kvm.py
comment
created
rhtyd
username_1
I've re-added this to 4.13.0.0, need another lgmt/review. @username_4 ?
comment
created
rhtyd
username_1
@username_4 are you lgtm on it? We can merge, the regression tests show the plugin is isolated enough and doesn't bring in any regression. cc @username_3 @username_5 @anuragaw
comment