opened
BenTheElder
username_0
there are many commands we make that should not run indefinitely before timing out, while some other like pull might be allowed to. we should consider extending our exec shim to handle timeouts properly.

thinking a bit more about the right way to do this, I think the shim may need a little redesign to better separate things that can be set before / after starting the command

/assign
/priority important-longterm
Introduce timeouts to exec
issue
created
BenTheElder
username_0
this is less necessary now, the one command I've observed hanging is `systemctl is-active docker.service` against the nodes, which we no longer use at all.

may revisit this in the future, perhaps we will refactor and plumb through context.Context everywhere.
comment
closed
BenTheElder
username_0
issue
created
BenTheElder
username_0
had a sneaking suspicion this would bite us, but so far we have no evidence that this is the case 🤷‍♂️ 
leaving as-is for now.
comment