opened
nikhita
username_0
Fixes kubernetes/apiextensions-apiserver#28

`go-openapi/validate` had a bug https://github.com/go-openapi/validate/issues/13 where it did not properly validate enums for integers. This hits users of CRD validation. This was fixed in https://github.com/go-openapi/validate/pull/14.

I had bumped `go-openapi/validate` for subresources in https://github.com/kubernetes/kubernetes/pull/55168 in this commit: https://github.com/kubernetes/kubernetes/commit/66a4e5122a2d810ada2f23af803d1e44256dd260 (to get the fix https://github.com/go-openapi/validate/pull/36 in). This bump picked up the fix for enum validation, so this bug does not affect 1.10 users.

This PR cherry picks the above commit to the `release-1.9` branch to fix the bug for 1.9 users.

This is not an automated cherry pick. My understanding is that automated cherry picks are for cherry-picking complete PRs and this cherry picks _a commit_ in a PR https://github.com/kubernetes/kubernetes/pull/55168. Adding an explicit hold to make sure this is ok.
/hold


**Release note**:
<!--  Write your release note:
1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string "action required".
2. If no release note is required, just write "NONE".
-->
```release-note
NONE
```

/cc username_1 sttts liggitt 
/assign username_1
[1.9] bump(go-openapi/validate): d509235108fcf6ab4913d2dcb3a2260c0db2108e
issue
created
nikhita
username_0
/kind bug
/area custom-resources
/sig api-machinery
comment
created
mbohlool
username_1
@username_0 it is ok to sometimes do manual cherrypicks. Please just add justification on why this is needed as a cherrypick and what is the user impact.
comment
created
cblecker
username_2
@username_0 staging godeps need to be updated here too
comment
created
jennybuckley
username_3
/cc @username_4
comment
created
jpbetz
username_4
Backporting this as a single commit looks fine to me. Removing hold.
comment
created
cblecker
username_2
@username_0 This still need attention (staging godeps need to be updated)
comment
created
nikhita
username_0
There is a still a discussion on how we should proceed with it. https://github.com/kubernetes/apiextensions-apiserver/issues/28#issuecomment-372751580.

Until that is agreed upon, I think we should not merge this.
comment
created
cblecker
username_2
@username_0 Understood.
/hold
comment
created
mbohlool
username_1
any update on this?
comment
created
mbohlool
username_1
Closing this in favor of #63604
comment