opened
bernt-matthias
username_0
The test defined here: https://github.com/OpenMS/OpenMS/blob/735441decb37d3d4501b682e45ac83d767b803f4/src/tests/topp/CMakeLists.txt#L267

fails with:

```
Abort reasons during feature construction:
- Invalid fit: Fitted model is bigger than 'max_rt_span': 1
```

the ini file actually defines 'max_rt_span': 2.5

Seems to be again due to an outdated ini file:

```
Warning: Parameters file version (1.8.0) does not match the version of this tool (2.4.0-HEAD-2018-10-26).
Your current parameters are still valid, but there might be new valid values or even new parameters. Upgrading the INI might be useful.
```

Little bit of background. For the CTD -> Galaxy tool converter I auto-extract tests for the Galaxy tools from the command line in the CMakeFile and the used ini-files. I understand that OpenMS tries to locate the parameters even if the CTD structure is wrong, my test generation scheme can not do this. Hence I observe differences in the results (in this case in some minor digits of some floating point numbers).
FeatureFinderCentroided tests 
issue
created
jpfeuffer
username_1
Can you elaborate? Why exactky do you think it does not honor max_rt_span?
comment
created
bernt-matthias
username_0
Because of the output `Invalid fit: Fitted model is bigger than 'max_rt_span': 1`.. But the ini file sets 2.5.
comment
created
bernt-matthias
username_0
Odd. `-debug 3` shows `"feature|max_rt_span" -> "2.5" (Maximum RT span in relation to extended area that the model is allowed to have.)` .. then I guess I just mis-interpret the output.
comment
created
cbielow
username_2
the `: 1` just says that this happened once. This number simply depends on the dataset (and parameters).
comment
created
cbielow
username_2
This probably not caused by parameters, but simply by platform. To compare results we use the FuzzyDiff tool (and so should you, I guess).
comment
closed
cbielow
username_2
issue
created
cbielow
username_2
closing, feel free to open if anything remains unclear.
comment