opened
imarian97
username_0
For rectangles I fixed the bug that occurs when you set "fromCenter:false" and also I implemented the minWidth and minHeight functionality.
Update jcanvas-handles.js
issue
created
caleb531
username_1
First of all, thanks for making a pull request for this issue.

I'm having trouble finding the logical differences in the code, because the indentation for the entire file as been modified. Could you please revert your whitespace/indentation changes so I can more easily review the logic that actually changed?

Thanks,
Caleb
comment
created
imarian97
username_0
Sorry about that, I fixed the problem.
comment
created
caleb531
username_1
Ah, much better—thanks for that. I've tested your code with the existing examples on the [plugin page for jCanvas Handles](http://calebevans.me/projects/jcanvas/plugins/handles/), and they all seem to work. Nice job.

However, I have one final request before I'm ready to merge (forgive me for failing to mention this earlier). I have chosen to abide by the [jQuery JavaScript Style Guide](http://contribute.jquery.org/style-guide/js/) for jCanvas *and* its official plugins (which includes Handles). Therefore, if you could please tweak your changes to abide by the style guidelines, I can merge this PR directly into `master`.

In general, you only need to ensure that:

* Your groups of parens are padded with a single space on each side (*e.g.* `if ( a === 3 )` instead of `if (a === 3)`)
* Key-value pairs have a space to the right of the colon, but not the left (*e.g.* `key: "value"` instead of `key : "value"`)

Also see my comment on one particular line in your code.

Other than that, your pull request is golden. :)

Thanks,
Caleb
comment
created
imarian97
username_0
I'm writing you this message because I think you didn't see my last commit.
comment
created
caleb531
username_1
Ah, yes. Apologies for missing that.

Thanks for the reminder. I'll merge that in later today.

Caleb

>
comment
created
caleb531
username_1
Changes look entirely solid. Time to merge!
comment