opened
MichaelPetrinolis
username_0
add github auth to the list of supported external providers
add github auth
issue
created
agriffard
username_1
Thank you Michael.
comment
created
MichaelPetrinolis
username_0
Check it out when you get some time...
comment
created
agriffard
username_1
OK, I managed to: 
Create an OAuth application on github
Enable the github authentication module
Set the client Id and Secret

Sign in with Github and link to an existing account

Enable registration
Register as another user with github

I am wondering a few things:
The association is only based on the username? The email is not retrieved from the github account when you register?
When you edit it in the admin, a user with external logins does not have any additional informations displayed?
comment
created
MichaelPetrinolis
username_0
1. If a user tries to login with external provider, and registration is enabled then 
- If the external provider provides an email claim, we search for an existing account with that email
- If not found, a new OC Account is created based on the username,email and password provided by the user
- If found, we request the password of the OC Account in order to link the external login
There is a PR that takes into consideration the email must confirmed parameter, if we request password in order to create a local Account from external login, and also uses the recaptcha

2. There is a front page (OrchardCore.Users/Account/ExternalLogins) where you can link/unlink OC account with external providers. Of course, is not complete, we must decide how this is integrated with profile/account info in admin/front end
comment
created
agriffard
username_1
Fixes #3483
comment