opened
mbp28
username_0
Hey, 

Just wanted to check in on the following: 

The ListOps dataset contains parses of different length. But I didn't find any code in this repo that does some sort of padding, neither did I see a padding symbol in the vocabulary. 

Do I understand correctly that the ListOpsBucketSampler only returns batches of samples that have the same number of tokens? Hence, no padding is necessary. This also implies that I may as well disregard the mask object the data loaders return for each batch as it is always only a matrix of ones? 

Thanks, 
Max
A Question About Padding / ListOpsBucketSampler
issue
created
serhii-havrylov
username_1
Not necessarily, if particular bucket size is smaller than a batch size, it will add data points from the different [bucket](https://github.com/facebookresearch/latent-treelstm/blob/master/listops/data_preprocessing/ListOpsBucketSampler.py#L41).
comment