opened
henrikra
username_0
I was wondering if `request` is needed as dependency. I think it is in node's core. Or at least I was able to use it in my small project without any `package.json` 🤔
Is request really needed as dependency?
issue
created
henrikra
username_0
Or maybe it works because MagicMirror already has it? https://github.com/MichMich/MagicMirror/blob/master/package.json#L65
comment
created
dolanmiu
username_1
Yeah its used here :smile::

https://github.com/username_1/MMM-awesome-alexa/blob/master/src/main/alexa-voice-service/audio-service.ts
comment
created
dolanmiu
username_1
I don't know, perhaps! But I think we should keep it in. It is not guaranteed in future that MagicMirror will keep the `request` dependency
comment
created
henrikra
username_0
Yeah I know that this module is using `request` but just wondering if it is really needed as double dependency when MagicMirror platform already has it :P I am very sure that people will quickly tell you in the issues if `request is undefined` :D
comment
created
henrikra
username_0
@username_1 Have you tested this?
comment
created
dolanmiu
username_1
I think we should keep request as a dependency, cos its uncertain what version of request MagicMirror is using (or will be using)

Imagine if MagicMirror updates their version of request, there is a chance it can break `MMM-awesome-alexa`! 😭
comment
created
henrikra
username_0
Okay true. Lets close this 🌂
comment
closed
henrikra
username_0
issue