opened
derekstavis
username_0
This PR migrates this plugin to new package structure. It also does some optimizations over the initial code:

- Includes a list of the built-in colorizers in README
- Split the grc wrapper function from the .load file
- Check if `grc` is available, bail out with error if not
- Wrap completions, as original commands are masked wrapper function
Migrate plugin to new omf structure
issue
created
nesl247
username_1
I think in `grc.wrap.fish`, `$arguments` and `$options` need to be reversed. The problem is with the order it has, you can't override any of the options on the cli.
comment
created
bobthecow
username_2
:+1:

@username_0 thoughts on @username_1's feedback?

I'm inclined to say that we can merge as-is, because this is a direct port of the previous functionality. Then we can worry about making it better. But if you want to take a shot at that as well, that works too :)
comment
created
nesl247
username_1
@username_2 Whatever gets it merged in faster. If merging this as-is is the quickest, let's do that, and I'll submit a PR to make the change I was referring to. I actually hadn't used this plugin previously, and didn't notice this was the prior behavior.
comment
created
derekstavis
username_0
I'd prefer merging as is, because of PR scope. I'm using it daily without issues, so I'm merging it so we can continue improving in next PRs!
comment