opened
menberg
username_0
The declaration of  public function init() lacks a ": void" which leads to a PHP Compile Error with error message "Declaration of username_1\\mailjet\\services\\SmsService::init() must be compatible with username_1\\mailjet\\services\\AbstractService::init(): void"

A possible fix would be to add ": void" to the following line:
https://github.com/username_1/Craft-3-Mailjet/blob/711061078561f3cc8ed2656fa4aa1aeea93b938e/src/services/SmsService.php#L28

Thanks for your wonderful work on this plugin.
Missing void in SmsService leads to PHP Compile Error
issue
created
bertoost
username_1
Good catch! It was added in the last update, without checking sub classes.
Will fix is later today. Thanks! 👍
comment
created
menberg
username_0
Thank you. Wonderful. Might there be also a chance to review https://github.com/username_1/Craft-3-Mailjet/pull/2 by the way? Thanks and have a nice day!
comment
created
bertoost
username_1
Yes. Thanks.
comment
closed
bertoost
username_1
issue
created
bertoost
username_1
Released soon!
comment