opened
Jiri-Kremser
username_0
this is based on https://github.com/apache/incubator-openwhisk/pull/2403
.. except the code is little bit more Scala idiomatic (using options instead of null checks, etc.), but the functionality is still the same, pls see the original PR for the details.
[wip] Draft 2 - Wrap runs within OpenTracing spans
issue
created
rabbah
username_1
no null! 👍
comment
created
rabbah
username_1
Option(null) == None.
comment
created
rabbah
username_1
oops, use filter instead of exists.
comment
created
jpkrohling
username_2
@username_0 , may I close #2403 in favor of this one?
comment
created
Jiri-Kremser
username_0
yes
comment
created
Jiri-Kremser
username_0
@username_1 is there anything else you want me to improve on this PR? Is it ok to have the open tracing code next to the markers in the logs as the first step? The tracing can be turned off or set to 10% using the env properties, so that only the fraction of the calls will be traced.
comment
created
rabbah
username_1
There is a second tracing pr #2282 - does it make sense to consider consolidating efforts?
comment
created
jpkrohling
username_2
I don't think so: there has been a thread on the mailing list, and it looks like that one has a different goal.
comment
created
rabbah
username_1
Closing per discussion on the dev list https://mail-archives.apache.org/mod_mbox/incubator-openwhisk-dev/201707.mbox/browser.
comment