opened
ShimiSun
username_0
Tracking the effort for the hooks migration starts here... see the below PRs as references.
Refactoring components and stories to use hooks
issue
created
aravind1078
username_1
@username_0  is there anything left to pick ?
comment
created
thidasapankaja
username_2
@username_0  Can I start working on this #3391 ?
comment
created
ShimiSun
username_0
@username_1 Go to any storybook example that has Class usage and refactor to class. look for example src/js/components/CheckBox/stories/Indeterminate.js
comment
created
ShimiSun
username_0
Hi @username_2, #3391  is a PR in progress, so maybe try to pick another Grommet class or story?
comment
created
thidasapankaja
username_2
@username_0 ok sure. I'll work on refactoring Class usage in Select story
comment
created
vitorfreitas
username_3
#3424
comment
created
vitorfreitas
username_3
#3424
comment
created
shakti97
username_4
I m trying to do but as i committed the code it starts some test and then i just wrote the git status and it showed me a huge amount of README files modified. Don't know why it changes the readme.md file. Can anybody know the reason behind this
comment
created
sofiageo
username_5
Are you using Windows and git autocrlf set to auto? The project is committed with LF line endings and I don't see any gitattributes committed to the repository to enforce the line endings. Your git might be changing the line endings to CRLF.
comment
created
shakti97
username_4
yes i m on windows
comment
created
sofiageo
username_5
In my opinion you should not commit anything with CRLF endings if the project is using LF endings, because it will create more confusion later. Another problem is that git is converting these files on "git clone" so even adding a gitattributes file don't be enough to fix it. Try to see if you can change the line endings from your IDE - if you are using IDEA products I think it's possible. - then only commit your changes.

p.s that's just my opinion and expertise and maybe grommet has no issues with the different line endings.
comment
created
sdowding
username_6
is there any other hooks stuff i can work on? it seems like its all finished!
comment
created
ShimiSun
username_0
@username_6 plenty...
Accordion.js
Chart.js
All of Chart stories  under src/js/components/Chart/stories
Collapsible.js
Resizer.js
Form.js
And more...

Look for imports of  `{ Component } from 'react'`, that will be a good place to start.
comment
created
ShimiSun
username_0
Leftovers for Hacktoberfest 2020:

1. Remove `class` usage from Drop-test.js
2. Remove `class` usage from Grommet.js
3. Remove `class` usage from InfiniteScroll.js
4. Remove `class` usage from src/js/components/Select/stories/ManyOptions.js
comment
created
aravind1078
username_1
@username_0 can you point the file paths to these three as well ?
```
Remove class usage from Drop-test.js
Remove class usage from Grommet.js
Remove class usage from InfiniteScroll.js
```
thanks.
comment
created
ShimiSun
username_0
@username_1, I added relative paths to the description.
comment
created
jcfilben
username_7
I believe there is just one item left:
templates/grommet-v2-template/src/index.js
comment
created
jcfilben
username_7
Closing, Class has been removed from all components (except RoutedAnchor and RoutedButton because they are deprecated) and stories.
comment