opened
MeshCollider
username_0
Suggested in https://github.com/bitcoin/bitcoin/pull/10481#issuecomment-325244946, this adds the option to explicitly choose whether a serialized transaction should be decoded as a witness or non-witness transaction rather than relying on the heuristic checks in #10481. The parameter defaults to relying on #10481 if not included, but it overrides that if included.
Add iswitness parameter to decode- and fundrawtransaction RPCs
issue
created
MeshCollider
username_0
@achow101 @roconnor-blockstream you might want to take a look at this :)
comment
created
MeshCollider
username_0
Changed style as requested, thanks @achow101
comment
created
luke-jr
username_1
Please don't change the style of *existing* code, only the new code... :/
comment
created
MeshCollider
username_0
@username_1 the style refactor only touches a tiny amount of code inside that single function, in a similar way to adding braces to existing if-statements when modifying nearby code. I'd argue that this small change to existing code style is worth it for the consistency, especially between try_witness and try_no_witness
comment
created
sipa
username_2
utACK 3d16658226cd08911200dbd90db762dc3409e443
comment
created
MeshCollider
username_0
Rebased
comment
created
laanwj
username_3
utACK 6f39ac04375a5f6ef803da59ba0b606123d63142
comment