opened
pvinis
username_0
in pull request #2885, `special` was not changed to bool. now it is.
menu: Change ex_menu()/special variable type and use stdbool constants
issue
created
ZyX-I
username_1
Travis failed due to the usual problem with gcov:

```
Error -> ...eovim/test/functional/terminal/window_split_tab_spec.lua @ 10
terminal before_each
./test/functional/ui/screen.lua:277: Row 1 didn't match.
Expected: "tty ready                                         "
Actual:   "profiling:/Users/travis/build/neovim/neovim/build/"
```

(and a bunch of similar errors). I restarted the job.
comment
created
fmoralesc
username_2
In line 229 of `map.c` we pass `special` to `replace_termcodes(...)`, which expects an int. Maybe check if this argument can be typed as a `bool`, and then review the other instances of this function.
comment
created
pvinis
username_0
actually, im changing all functions that are used in quickfix to accept the correct args, so i will add all of them soon. i have to change the other instances of them too. should i amend the commit, or make a new commit here?
comment
created
pvinis
username_0
one more thing. in `qf_add_entry`, `col` and `nr` are ints. also some other args. then somewhere in the same file we have `nr = get_dict_number(d, (char_u *)"nr");`, and `get_dict_number` gives a long. how should this be handled?
comment
created
justinmk
username_3
What does this PR have to do with quickfix? 

Note that you can coerce a int/long to bool with `!!` if necessary. Changing `special` to bool seems like it won't be much trouble though.
comment
created
pvinis
username_0
ah yes. sorry. i am enabling quickfix to compile with -Wconversion and i changed `special` there. ok, i think i will just remove this pr, and submit the big one later, with that in there.
comment
created
justinmk
username_3
There is already a PR for quickfix: https://github.com/neovim/neovim/pull/2818

Please search the existing PRs before working :)
comment
created
justinmk
username_3
I went ahead and merged this. Thanks
comment
created
justinmk
username_3
@username_0 Want to take over https://github.com/neovim/neovim/pull/2818 ?
comment
created
pvinis
username_0
yes
comment