opened
ks4225
username_0
These changes only apply to Azure Cloud clusters.

When creating an Epiphany Cluster, we may want to integrate the cluster with existing network resources. The changes here allow the selection of an existing network (using resource group + vnet + subnet) so that the cluster is terraformed into that existing network. Vnets and subnets will not be created when using this option.
Existing network support in Azure
issue
created
sunshine69
username_1
Can I have some added into the README Howto section to illustrate/show how to use the new feature? 

Does it include the generation of initial manifest with option `--full`? If not I suggest to include it or at least an skeleton example.
comment
created
ks4225
username_0
I have added a readme section in `CLUSTER.md` (which includes an example). Since this feature will probably be an edge case, I haven't added it into the YAML generation.
comment
created
ks4225
username_0
When re-running this, I noticed the Azure network validation occurs before the Azure login logic.
As a workaround, I have duplicated the required login logic, but happy to follow any suggestion on how to fix it properly.
comment
created
ks4225
username_0
Thanks @seriva, I understand what you are asking and I agree. Just haven't had time to revisit this PR for a while as it's not a priority for us at the moment.
comment
created
rafzei
username_2
Im closing this after approval from @username_0.
comment