Kernel bug: possible deadlock in ocfs2_init_acl
Subsystem: ocfs2
Status: open

Crash report:
(syz.0.17,5986,0):ocfs2_block_check_validate:400 ERROR: CRC32 failed: stored: 0xb3775c19, computed 0x2dd1c265. Applying ECC.
JBD2: Ignoring recovery information on journal
ocfs2: Mounting device (7,0) on (node local, slot 0) with ordered data mode.
======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz.0.17/5986 is trying to acquire lock:
ffff88805a2306f8 (&oi->ip_xattr_sem){++++}-{4:4}, at: ocfs2_init_acl+0x35b/0x840 fs/ocfs2/acl.c:367

but task is already holding lock:
ffff88803391c0e8 (&journal->j_trans_barrier){.+.+}-{4:4}, at: ocfs2_start_trans+0x3ae/0x970 fs/ocfs2/journal.c:372

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #3 (&journal->j_trans_barrier){.+.+}-{4:4}:
       down_read+0x9b/0x460 kernel/locking/rwsem.c:1537
       ocfs2_start_trans+0x3ae/0x970 fs/ocfs2/journal.c:372
       ocfs2_modify_bh+0xbd/0x490 fs/ocfs2/quota_local.c:101
       ocfs2_local_read_info+0xdad/0x16b0 fs/ocfs2/quota_local.c:767
       dquot_load_quota_sb+0x83a/0x11c0 fs/quota/dquot.c:2462
       dquot_load_quota_inode fs/quota/dquot.c:2499 [inline]
       dquot_load_quota_inode+0x2a3/0x470 fs/quota/dquot.c:2491
       ocfs2_enable_quotas+0x28a/0x5a0 fs/ocfs2/super.c:930
       ocfs2_fill_super+0x1d7c/0x4380 fs/ocfs2/super.c:1140
       get_tree_bdev_flags+0x38c/0x620 fs/super.c:1691
       vfs_get_tree+0x8e/0x330 fs/super.c:1751
       fc_mount fs/namespace.c:1199 [inline]
       do_new_mount_fc fs/namespace.c:3636 [inline]
       do_new_mount fs/namespace.c:3712 [inline]
       path_mount+0x7bf/0x23a0 fs/namespace.c:4022
       do_mount fs/namespace.c:4035 [inline]
       __do_sys_mount fs/namespace.c:4224 [inline]
       __se_sys_mount fs/namespace.c:4201 [inline]
       __x64_sys_mount+0x293/0x310 fs/namespace.c:4201
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xcd/0xf80 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #2 (sb_internal#2){.+.+}-{0:0}:
       percpu_down_read_internal include/linux/percpu-rwsem.h:53 [inline]
       percpu_down_read_freezable include/linux/percpu-rwsem.h:83 [inline]
       __sb_start_write include/linux/fs/super.h:19 [inline]
       sb_start_intwrite include/linux/fs/super.h:177 [inline]
       ocfs2_start_trans+0x29d/0x970 fs/ocfs2/journal.c:370
       ocfs2_xattr_set+0x12f2/0x2a50 fs/ocfs2/xattr.c:3673
       ocfs2_set_acl+0x46d/0x550 fs/ocfs2/acl.c:255
       ocfs2_iop_set_acl+0x224/0x2d0 fs/ocfs2/acl.c:287
       set_posix_acl+0x25f/0x320 fs/posix_acl.c:954
       vfs_set_acl+0x44a/0x920 fs/posix_acl.c:1133
       do_set_acl+0xd9/0x1a0 fs/posix_acl.c:1278
       do_setxattr+0xeb/0x180 fs/xattr.c:633
       file_setxattr fs/xattr.c:646 [inline]
       file_setxattr+0x139/0x1b0 fs/xattr.c:640
       path_setxattrat+0x247/0x2a0 fs/xattr.c:711
       __do_sys_fsetxattr fs/xattr.c:761 [inline]
       __se_sys_fsetxattr fs/xattr.c:758 [inline]
       __x64_sys_fsetxattr+0xc5/0x140 fs/xattr.c:758
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xcd/0xf80 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #1 (&ocfs2_sysfile_lock_key[EXTENT_ALLOC_SYSTEM_INODE]){+.+.}-{4:4}:
       down_write+0x92/0x200 kernel/locking/rwsem.c:1590
       inode_lock include/linux/fs.h:1027 [inline]
       ocfs2_reserve_suballoc_bits+0x11c/0x4830 fs/ocfs2/suballoc.c:789
       ocfs2_reserve_new_metadata_blocks+0x52c/0xc70 fs/ocfs2/suballoc.c:985
       ocfs2_init_xattr_set_ctxt fs/ocfs2/xattr.c:3307 [inline]
       ocfs2_xattr_set+0x184c/0x2a50 fs/ocfs2/xattr.c:3664
       ocfs2_set_acl+0x46d/0x550 fs/ocfs2/acl.c:255
       ocfs2_iop_set_acl+0x224/0x2d0 fs/ocfs2/acl.c:287
       set_posix_acl+0x25f/0x320 fs/posix_acl.c:954
       vfs_set_acl+0x44a/0x920 fs/posix_acl.c:1133
       do_set_acl+0xd9/0x1a0 fs/posix_acl.c:1278
       do_setxattr+0xeb/0x180 fs/xattr.c:633
       file_setxattr fs/xattr.c:646 [inline]
       file_setxattr+0x139/0x1b0 fs/xattr.c:640
       path_setxattrat+0x247/0x2a0 fs/xattr.c:711
       __do_sys_fsetxattr fs/xattr.c:761 [inline]
       __se_sys_fsetxattr fs/xattr.c:758 [inline]
       __x64_sys_fsetxattr+0xc5/0x140 fs/xattr.c:758
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xcd/0xf80 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #0 (&oi->ip_xattr_sem){++++}-{4:4}:
       check_prev_add kernel/locking/lockdep.c:3165 [inline]
       check_prevs_add kernel/locking/lockdep.c:3284 [inline]
       validate_chain kernel/locking/lockdep.c:3908 [inline]
       __lock_acquire+0x1669/0x2890 kernel/locking/lockdep.c:5237
       lock_acquire kernel/locking/lockdep.c:5868 [inline]
       lock_acquire+0x179/0x330 kernel/locking/lockdep.c:5825
       down_read+0x9b/0x460 kernel/locking/rwsem.c:1537
       ocfs2_init_acl+0x35b/0x840 fs/ocfs2/acl.c:367
       ocfs2_mknod+0xd2f/0x2510 fs/ocfs2/namei.c:414
       ocfs2_mkdir+0x17c/0x460 fs/ocfs2/namei.c:660
       vfs_mkdir+0x731/0xb60 fs/namei.c:5130
       do_mkdirat+0x442/0x5e0 fs/namei.c:5164
       __do_sys_mkdirat fs/namei.c:5186 [inline]
       __se_sys_mkdirat fs/namei.c:5184 [inline]
       __x64_sys_mkdirat+0x83/0xb0 fs/namei.c:5184
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xcd/0xf80 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

other info that might help us debug this:

Chain exists of:
  &oi->ip_xattr_sem --> sb_internal#2 --> &journal->j_trans_barrier

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  rlock(&journal->j_trans_barrier);
                               lock(sb_internal#2);
                               lock(&journal->j_trans_barrier);
  rlock(&oi->ip_xattr_sem);

 *** DEADLOCK ***

8 locks held by syz.0.17/5986:
 #0: ffff88807fbac420 (sb_writers#12){.+.+}-{0:0}, at: filename_create+0x10d/0x400 fs/namei.c:4872
 #1: ffff88805a2309c0 (&type->i_mutex_dir_key#8/1){+.+.}-{4:4}, at: inode_lock_nested include/linux/fs.h:1072 [inline]
 #1: ffff88805a2309c0 (&type->i_mutex_dir_key#8/1){+.+.}-{4:4}, at: __start_dirop fs/namei.c:2864 [inline]
 #1: ffff88805a2309c0 (&type->i_mutex_dir_key#8/1){+.+.}-{4:4}, at: start_dirop fs/namei.c:2875 [inline]
 #1: ffff88805a2309c0 (&type->i_mutex_dir_key#8/1){+.+.}-{4:4}, at: filename_create+0x1c0/0x400 fs/namei.c:4879
 #2: ffff88805a23a640 (&ocfs2_sysfile_lock_key[INODE_ALLOC_SYSTEM_INODE]){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:1027 [inline]
 #2: ffff88805a23a640 (&ocfs2_sysfile_lock_key[INODE_ALLOC_SYSTEM_INODE]){+.+.}-{4:4}, at: ocfs2_reserve_suballoc_bits+0x11c/0x4830 fs/ocfs2/suballoc.c:789
 #3: ffff88805a239800 (&ocfs2_sysfile_lock_key[EXTENT_ALLOC_SYSTEM_INODE]){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:1027 [inline]
 #3: ffff88805a239800 (&ocfs2_sysfile_lock_key[EXTENT_ALLOC_SYSTEM_INODE]){+.+.}-{4:4}, at: ocfs2_reserve_suballoc_bits+0x11c/0x4830 fs/ocfs2/suballoc.c:789
 #4: ffff88805a23c2c0 (&ocfs2_sysfile_lock_key[LOCAL_ALLOC_SYSTEM_INODE]){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:1027 [inline]
 #4: ffff88805a23c2c0 (&ocfs2_sysfile_lock_key[LOCAL_ALLOC_SYSTEM_INODE]){+.+.}-{4:4}, at: ocfs2_reserve_local_alloc_bits+0xec/0xbf0 fs/ocfs2/localalloc.c:636
 #5: ffff88807fbac610 (sb_internal#2){.+.+}-{0:0}, at: ocfs2_mknod+0xbec/0x2510 fs/ocfs2/namei.c:365
 #6: ffff88803391c0e8 (&journal->j_trans_barrier){.+.+}-{4:4}, at: ocfs2_start_trans+0x3ae/0x970 fs/ocfs2/journal.c:372
 #7: ffff8880318ea950 (jbd2_handle#2){.+.+}-{0:0}, at: start_this_handle+0x5e7/0x1410 fs/jbd2/transaction.c:444

stack backtrace:
CPU: 0 UID: 0 PID: 5986 Comm: syz.0.17 Not tainted syzkaller #0 PREEMPT(full) 
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/25/2025
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:94 [inline]
 dump_stack_lvl+0x116/0x1f0 lib/dump_stack.c:120
 print_circular_bug+0x275/0x340 kernel/locking/lockdep.c:2043
 check_noncircular+0x146/0x160 kernel/locking/lockdep.c:2175
 check_prev_add kernel/locking/lockdep.c:3165 [inline]
 check_prevs_add kernel/locking/lockdep.c:3284 [inline]
 validate_chain kernel/locking/lockdep.c:3908 [inline]
 __lock_acquire+0x1669/0x2890 kernel/locking/lockdep.c:5237
 lock_acquire kernel/locking/lockdep.c:5868 [inline]
 lock_acquire+0x179/0x330 kernel/locking/lockdep.c:5825
 down_read+0x9b/0x460 kernel/locking/rwsem.c:1537
 ocfs2_init_acl+0x35b/0x840 fs/ocfs2/acl.c:367
 ocfs2_mknod+0xd2f/0x2510 fs/ocfs2/namei.c:414
 ocfs2_mkdir+0x17c/0x460 fs/ocfs2/namei.c:660
 vfs_mkdir+0x731/0xb60 fs/namei.c:5130
 do_mkdirat+0x442/0x5e0 fs/namei.c:5164
 __do_sys_mkdirat fs/namei.c:5186 [inline]
 __se_sys_mkdirat fs/namei.c:5184 [inline]
 __x64_sys_mkdirat+0x83/0xb0 fs/namei.c:5184
 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
 do_syscall_64+0xcd/0xf80 arch/x86/entry/syscall_64.c:94
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7fe736d8de97
Code: 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 83 c8 ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 b8 02 01 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fff0cad5868 EFLAGS: 00000246 ORIG_RAX: 0000000000000102
RAX: ffffffffffffffda RBX: 00007fff0cad58f0 RCX: 00007fe736d8de97
RDX: 00000000000001ff RSI: 0000200000000180 RDI: 00000000ffffff9c
RBP: 00002000000002c0 R08: 00002000000007c0 R09: 0000000000000000
R10: 00002000000002c0 R11: 0000000000000246 R12: 0000200000000180
R13: 00007fff0cad58b0 R14: 0000000000000000 R15: 0000000000000000
 </TASK>