Err, good point. I don't like the pattern of "def foo()" delegating to "def
_foo()" really, I'd prefer if the "_foo" version had a more expressive name
was my real point :-)


On Wed, May 21, 2014 at 8:15 AM, Paul Kehrer <notifications@github.com>wrote:

> In cryptography/hazmat/backends/openssl/backend.py:
>
> > @@ -132,6 +132,14 @@ def create_hash_ctx(self, algorithm):
> >          return _HashContext(self, algorithm)
> >
> >      def cipher_supported(self, cipher, mode):
> > +        if self._cipher_supported(cipher, mode):
> > +            return True
> > +        elif isinstance(mode, CTR) and isinstance(cipher, AES):
> > +            return True
> > +        else:
> > +            return False
> > +
> > +    def _cipher_supported(self, cipher, mode):
>
> This is just a rename of the old cipher_supported method. While it does
> check if it's in the registry, it also then instantiates an EVP_CIPHER *.
> This is why AES CTR is in the registry but will return false in 0.9.8. I
> don't think _cipher_in_registry is appropriate given that it can return
> false for things in registry that are not supported by the linked OpenSSL.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/pyca/cryptography/pull/1068/files#r12901487>
> .
>



-- 
"I disapprove of what you say, but I will defend to the death your right to
say it." -- Evelyn Beatrice Hall (summarizing Voltaire)
"The people's good is the highest law." -- Cicero
GPG Key fingerprint: 125F 5C67 DFE9 4084