`magit-refresh-commit-buffer': pass REV *after* options

Strictly speaking, we can pass the REV in between the options
without causing any trouble, but that doesn't mean we should...

Signed-off-by: Pieter Praet <pieter@praet.org>
`magit-format-commit': pass REV *after* options

Strictly speaking, we can pass the REV in between the options
without causing any trouble, but that doesn't mean we should...

Signed-off-by: Pieter Praet <pieter@praet.org>
Merge pull request #928 from praet/args-order

Args order
`magit-git-section': fix docstring

The part about the CMD arg is no longer relevant since the docstring
was moved over from `magit-insert-section' (commit 6f69a607).

Signed-off-by: Pieter Praet <pieter@praet.org>
`magit-wazzup-mode': fix docstring

Being listed in `magit-wazzup-mode' doesn't necessarily mean that a
commit is unique to a branch.  The only thing we can be sure of is that
it's on a branch which isn't merged into HEAD yet.

Signed-off-by: Pieter Praet <pieter@praet.org>
`magit-wazzup-buffer-name': fix docstring

Signed-off-by: Pieter Praet <pieter@praet.org>
`magit-branch-manager-mode': fix docstring

Its docstring was copy-paste from `magit-diff-mode',
but wasn't adjusted according to its new location.

Signed-off-by: Pieter Praet <pieter@praet.org>
`magit-branches-buffer-name': fix docstring

s/branch /buffer /

Signed-off-by: Pieter Praet <pieter@praet.org>
`magit-commit-mode': fix docstring

s/locking/looking/

Signed-off-by: Pieter Praet <pieter@praet.org>
`magit-*-mode': separate clauses in docstring

Because a single punctuation char can do wonders for readability.

Signed-off-by: Pieter Praet <pieter@praet.org>
Merge branch 'docstrings'
`magit-git-lines': simplify

Instead of doing buffer movement and having to keep track of
where we are, just pass the whole buffer to `split-string'.

Signed-off-by: Pieter Praet <pieter@praet.org>
`magit-git-string': only move point if buffer contains anything

Using a stock configuration, running `magit-status' results in 27 calls
to `magit-git-string', so the less it does, the better.

Even though it doesn't make a measurable difference, there's no point in
moving `point' unless we're sure the buffer contains anything.

Signed-off-by: Pieter Praet <pieter@praet.org>
`magit-diffstat-keymap': fix docstring

Commit 8618430b changed `magit-diffstat-keymap's docstring to refer to
`magit-diffstat-mode', but that doesn't exist.  `magit-diffstat-keymap'
is used in `magit-commit-mode' and `magit-diff-mode' though.

Signed-off-by: Pieter Praet <pieter@praet.org>
`magit-cherry-mode-map': add

Commit 8618430b added a reference to MAPVAR `magit-cherry-mode-map'
in `magit-cherry-mode's docstring, but the former didn't exist.

Signed-off-by: Pieter Praet <pieter@praet.org>
`magit-stash-mode{,-map}': remove

Commit 8618430b added `magit-stash-mode-map', but neither it nor
`magit-stash-mode' (which the former is supposed to be used by)
serve any purpose:  `magit-show-stash' uses `magit-diff-mode'.

Signed-off-by: Pieter Praet <pieter@praet.org>
`string-{prefix,match}-p' (compat): remove

As stated in commit dc72fc03, the `string-prefix-p' and `string-match-p'
compatibility functions no longer serve any purpose since we decided to
drop support for Emacs < v23.2 (see commit 83dac351 and issue #708).

Signed-off-by: Pieter Praet <pieter@praet.org>
`magit-section-jump-map': quickly jump to sections

Add a `magit-status-mode-map' submap which allows to quickly
jump to some common sections in `magit-status-mode'.

Fixes #919.

Suggested-by: Kristian Lein-Mathisen <kristianlein@gmail.com>
Signed-off-by: Pieter Praet <pieter@praet.org>
Merge pull request #938 from praet/stash-mode

`magit-stash-mode{,-map}': remove
Merge pull request #939 from praet/cherry-mode-map

`magit-cherry-mode-map': add