GitHub PullRequestReviewCommentEvent at 2014-04-30 12:02:57
Repository: WebTundra
Actor: antont
Payload: {"comment":{"url":"https://api.github.com/repos/realXtend/WebTundra/pulls/comments/12139649","id":12139649,"diff_hunk":"@@ -191,19 +173,20 @@ var Transform = Class.$extend(\n     setRotation : function(x, y, z)\n     {\n         if (x instanceof THREE.Vector3)\n-            this._rot = x.clone();\n+            this._rot.copy(x);\n         else if (x instanceof THREE.Quaternion)\n         {\n-            this._rotEuler.setFromQuaternion(x.normalize());\n-            this._rot.x = THREE.Math.radToDeg(this._rotEuler.x);\n-            this._rot.y = THREE.Math.radToDeg(this._rotEuler.y);\n-            this._rot.z = THREE.Math.radToDeg(this._rotEuler.z);\n+            /// @todo Is this now incorrect as this._rotEuler order is \"ZYX\"?","path":"src/core/math/Transform.js","position":67,"original_position":67,"commit_id":"c221a1b8413b791cfc840fb1810e0d0d72901dd1","original_commit_id":"c221a1b8413b791cfc840fb1810e0d0d72901dd1","user":{"login":"antont","id":201016,"avatar_url":"https://avatars.githubusercontent.com/u/201016?","gravatar_id":"d1e0a54c21511bd42c1c0b2c2718dcef","url":"https://api.github.com/users/antont","html_url":"https://github.com/antont","followers_url":"https://api.github.com/users/antont/followers","following_url":"https://api.github.com/users/antont/following{/other_user}","gists_url":"https://api.github.com/users/antont/gists{/gist_id}","starred_url":"https://api.github.com/users/antont/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antont/subscriptions","organizations_url":"https://api.github.com/users/antont/orgs","repos_url":"https://api.github.com/users/antont/repos","events_url":"https://api.github.com/users/antont/events{/privacy}","received_events_url":"https://api.github.com/users/antont/received_events","type":"User","site_admin":false},"body":"yah iirc he also figured earlier that now that the protocol supports dealing with different versions we could consider changing the attribute and hence the network message to use quats","created_at":"2014-04-30T12:02:57Z","updated_at":"2014-04-30T12:02:57Z","html_url":"https://github.com/realXtend/WebTundra/pull/69#discussion_r12139649","pull_request_url":"https://api.github.com/repos/realXtend/WebTundra/pulls/69","_links":{"self":{"href":"https://api.github.com/repos/realXtend/WebTundra/pulls/comments/12139649"},"html":{"href":"https://github.com/realXtend/WebTundra/pull/69#discussion_r12139649"},"pull_request":{"href":"https://api.github.com/repos/realXtend/WebTundra/pulls/69"}}}}