GitHub PullRequestEvent at 2014-07-03 17:58:13
Repository: mocha-fibers
Actor: tzeskimo
Payload: {"action":"closed","number":4,"pull_request":{"url":"https://api.github.com/repos/tzeskimo/mocha-fibers/pulls/4","id":17683583,"html_url":"https://github.com/tzeskimo/mocha-fibers/pull/4","diff_url":"https://github.com/tzeskimo/mocha-fibers/pull/4.diff","patch_url":"https://github.com/tzeskimo/mocha-fibers/pull/4.patch","issue_url":"https://api.github.com/repos/tzeskimo/mocha-fibers/issues/4","number":4,"state":"closed","title":"Fix timeout by bumping bdd interface","user":{"login":"hurrymaplelad","id":1083040,"avatar_url":"https://avatars.githubusercontent.com/u/1083040?","gravatar_id":"27d8c47ce0192428de12cc633661d122","url":"https://api.github.com/users/hurrymaplelad","html_url":"https://github.com/hurrymaplelad","followers_url":"https://api.github.com/users/hurrymaplelad/followers","following_url":"https://api.github.com/users/hurrymaplelad/following{/other_user}","gists_url":"https://api.github.com/users/hurrymaplelad/gists{/gist_id}","starred_url":"https://api.github.com/users/hurrymaplelad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hurrymaplelad/subscriptions","organizations_url":"https://api.github.com/users/hurrymaplelad/orgs","repos_url":"https://api.github.com/users/hurrymaplelad/repos","events_url":"https://api.github.com/users/hurrymaplelad/events{/privacy}","received_events_url":"https://api.github.com/users/hurrymaplelad/received_events","type":"User","site_admin":false},"body":"[Suite level timeouts](http://visionmedia.github.io/mocha/#suite-specific-timeouts) like:\r\n\r\n``` js\r\ndescribe('a suite of tests', function(){\r\n  this.timeout(500);  // <------ This\r\n\r\n  it('should take less than 500ms', function(done){\r\n    setTimeout(done, 300);\r\n  })\r\n})\r\n```\r\n\r\nStopped working for me when I require mocha-fibers.  Looks like the BDD interface has changed a bit since this file was copied.  I tried layering the fibers wrapping on top of the interface exported by mocha to avoid future synchronization issues.  Works for all my tests.  Whatcha think?  Also, thanks for writing this.","created_at":"2014-06-27T02:29:44Z","updated_at":"2014-07-03T17:58:12Z","closed_at":"2014-07-03T17:58:12Z","merged_at":"2014-07-03T17:58:12Z","merge_commit_sha":"414af7e72a24b79ca184721976b5a5389194b9ec","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/tzeskimo/mocha-fibers/pulls/4/commits","review_comments_url":"https://api.github.com/repos/tzeskimo/mocha-fibers/pulls/4/comments","review_comment_url":"https://api.github.com/repos/tzeskimo/mocha-fibers/pulls/comments/{number}","comments_url":"https://api.github.com/repos/tzeskimo/mocha-fibers/issues/4/comments","statuses_url":"https://api.github.com/repos/tzeskimo/mocha-fibers/statuses/c71821d9151203bb70346f8009aa8844dd91615f","head":{"label":"goodeggs:fix-timeout","ref":"fix-timeout","sha":"c71821d9151203bb70346f8009aa8844dd91615f","user":{"login":"goodeggs","id":892928,"avatar_url":"https://avatars.githubusercontent.com/u/892928?","gravatar_id":"6bd4aa3b074535ad53165bd82308f925","url":"https://api.github.com/users/goodeggs","html_url":"https://github.com/goodeggs","followers_url":"https://api.github.com/users/goodeggs/followers","following_url":"https://api.github.com/users/goodeggs/following{/other_user}","gists_url":"https://api.github.com/users/goodeggs/gists{/gist_id}","starred_url":"https://api.github.com/users/goodeggs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goodeggs/subscriptions","organizations_url":"https://api.github.com/users/goodeggs/orgs","repos_url":"https://api.github.com/users/goodeggs/repos","events_url":"https://api.github.com/users/goodeggs/events{/privacy}","received_events_url":"https://api.github.com/users/goodeggs/received_events","type":"Organization","site_admin":false},"repo":{"id":21261084,"name":"mocha-fibers","full_name":"goodeggs/mocha-fibers","owner":{"login":"goodeggs","id":892928,"avatar_url":"https://avatars.githubusercontent.com/u/892928?","gravatar_id":"6bd4aa3b074535ad53165bd82308f925","url":"https://api.github.com/users/goodeggs","html_url":"https://github.com/goodeggs","followers_url":"https://api.github.com/users/goodeggs/followers","following_url":"https://api.github.com/users/goodeggs/following{/other_user}","gists_url":"https://api.github.com/users/goodeggs/gists{/gist_id}","starred_url":"https://api.github.com/users/goodeggs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goodeggs/subscriptions","organizations_url":"https://api.github.com/users/goodeggs/orgs","repos_url":"https://api.github.com/users/goodeggs/repos","events_url":"https://api.github.com/users/goodeggs/events{/privacy}","received_events_url":"https://api.github.com/users/goodeggs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/goodeggs/mocha-fibers","description":"mocha-fibers","fork":true,"url":"https://api.github.com/repos/goodeggs/mocha-fibers","forks_url":"https://api.github.com/repos/goodeggs/mocha-fibers/forks","keys_url":"https://api.github.com/repos/goodeggs/mocha-fibers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/goodeggs/mocha-fibers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/goodeggs/mocha-fibers/teams","hooks_url":"https://api.github.com/repos/goodeggs/mocha-fibers/hooks","issue_events_url":"https://api.github.com/repos/goodeggs/mocha-fibers/issues/events{/number}","events_url":"https://api.github.com/repos/goodeggs/mocha-fibers/events","assignees_url":"https://api.github.com/repos/goodeggs/mocha-fibers/assignees{/user}","branches_url":"https://api.github.com/repos/goodeggs/mocha-fibers/branches{/branch}","tags_url":"https://api.github.com/repos/goodeggs/mocha-fibers/tags","blobs_url":"https://api.github.com/repos/goodeggs/mocha-fibers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/goodeggs/mocha-fibers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/goodeggs/mocha-fibers/git/refs{/sha}","trees_url":"https://api.github.com/repos/goodeggs/mocha-fibers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/goodeggs/mocha-fibers/statuses/{sha}","languages_url":"https://api.github.com/repos/goodeggs/mocha-fibers/languages","stargazers_url":"https://api.github.com/repos/goodeggs/mocha-fibers/stargazers","contributors_url":"https://api.github.com/repos/goodeggs/mocha-fibers/contributors","subscribers_url":"https://api.github.com/repos/goodeggs/mocha-fibers/subscribers","subscription_url":"https://api.github.com/repos/goodeggs/mocha-fibers/subscription","commits_url":"https://api.github.com/repos/goodeggs/mocha-fibers/commits{/sha}","git_commits_url":"https://api.github.com/repos/goodeggs/mocha-fibers/git/commits{/sha}","comments_url":"https://api.github.com/repos/goodeggs/mocha-fibers/comments{/number}","issue_comment_url":"https://api.github.com/repos/goodeggs/mocha-fibers/issues/comments/{number}","contents_url":"https://api.github.com/repos/goodeggs/mocha-fibers/contents/{+path}","compare_url":"https://api.github.com/repos/goodeggs/mocha-fibers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/goodeggs/mocha-fibers/merges","archive_url":"https://api.github.com/repos/goodeggs/mocha-fibers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/goodeggs/mocha-fibers/downloads","issues_url":"https://api.github.com/repos/goodeggs/mocha-fibers/issues{/number}","pulls_url":"https://api.github.com/repos/goodeggs/mocha-fibers/pulls{/number}","milestones_url":"https://api.github.com/repos/goodeggs/mocha-fibers/milestones{/number}","notifications_url":"https://api.github.com/repos/goodeggs/mocha-fibers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/goodeggs/mocha-fibers/labels{/name}","releases_url":"https://api.github.com/repos/goodeggs/mocha-fibers/releases{/id}","created_at":"2014-06-27T02:06:47Z","updated_at":"2014-06-23T08:13:37Z","pushed_at":"2014-06-27T02:32:56Z","git_url":"git://github.com/goodeggs/mocha-fibers.git","ssh_url":"git@github.com:goodeggs/mocha-fibers.git","clone_url":"https://github.com/goodeggs/mocha-fibers.git","svn_url":"https://github.com/goodeggs/mocha-fibers","homepage":null,"size":107,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tzeskimo:master","ref":"master","sha":"b791337febd6101119f96bead9cffe6f1c81d3b5","user":{"login":"tzeskimo","id":719524,"avatar_url":"https://avatars.githubusercontent.com/u/719524?","gravatar_id":"0267f68edc6ad5a6a3bb5e72ad5ebb33","url":"https://api.github.com/users/tzeskimo","html_url":"https://github.com/tzeskimo","followers_url":"https://api.github.com/users/tzeskimo/followers","following_url":"https://api.github.com/users/tzeskimo/following{/other_user}","gists_url":"https://api.github.com/users/tzeskimo/gists{/gist_id}","starred_url":"https://api.github.com/users/tzeskimo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tzeskimo/subscriptions","organizations_url":"https://api.github.com/users/tzeskimo/orgs","repos_url":"https://api.github.com/users/tzeskimo/repos","events_url":"https://api.github.com/users/tzeskimo/events{/privacy}","received_events_url":"https://api.github.com/users/tzeskimo/received_events","type":"User","site_admin":false},"repo":{"id":5447607,"name":"mocha-fibers","full_name":"tzeskimo/mocha-fibers","owner":{"login":"tzeskimo","id":719524,"avatar_url":"https://avatars.githubusercontent.com/u/719524?","gravatar_id":"0267f68edc6ad5a6a3bb5e72ad5ebb33","url":"https://api.github.com/users/tzeskimo","html_url":"https://github.com/tzeskimo","followers_url":"https://api.github.com/users/tzeskimo/followers","following_url":"https://api.github.com/users/tzeskimo/following{/other_user}","gists_url":"https://api.github.com/users/tzeskimo/gists{/gist_id}","starred_url":"https://api.github.com/users/tzeskimo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tzeskimo/subscriptions","organizations_url":"https://api.github.com/users/tzeskimo/orgs","repos_url":"https://api.github.com/users/tzeskimo/repos","events_url":"https://api.github.com/users/tzeskimo/events{/privacy}","received_events_url":"https://api.github.com/users/tzeskimo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tzeskimo/mocha-fibers","description":"mocha-fibers","fork":false,"url":"https://api.github.com/repos/tzeskimo/mocha-fibers","forks_url":"https://api.github.com/repos/tzeskimo/mocha-fibers/forks","keys_url":"https://api.github.com/repos/tzeskimo/mocha-fibers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tzeskimo/mocha-fibers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tzeskimo/mocha-fibers/teams","hooks_url":"https://api.github.com/repos/tzeskimo/mocha-fibers/hooks","issue_events_url":"https://api.github.com/repos/tzeskimo/mocha-fibers/issues/events{/number}","events_url":"https://api.github.com/repos/tzeskimo/mocha-fibers/events","assignees_url":"https://api.github.com/repos/tzeskimo/mocha-fibers/assignees{/user}","branches_url":"https://api.github.com/repos/tzeskimo/mocha-fibers/branches{/branch}","tags_url":"https://api.github.com/repos/tzeskimo/mocha-fibers/tags","blobs_url":"https://api.github.com/repos/tzeskimo/mocha-fibers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tzeskimo/mocha-fibers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tzeskimo/mocha-fibers/git/refs{/sha}","trees_url":"https://api.github.com/repos/tzeskimo/mocha-fibers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tzeskimo/mocha-fibers/statuses/{sha}","languages_url":"https://api.github.com/repos/tzeskimo/mocha-fibers/languages","stargazers_url":"https://api.github.com/repos/tzeskimo/mocha-fibers/stargazers","contributors_url":"https://api.github.com/repos/tzeskimo/mocha-fibers/contributors","subscribers_url":"https://api.github.com/repos/tzeskimo/mocha-fibers/subscribers","subscription_url":"https://api.github.com/repos/tzeskimo/mocha-fibers/subscription","commits_url":"https://api.github.com/repos/tzeskimo/mocha-fibers/commits{/sha}","git_commits_url":"https://api.github.com/repos/tzeskimo/mocha-fibers/git/commits{/sha}","comments_url":"https://api.github.com/repos/tzeskimo/mocha-fibers/comments{/number}","issue_comment_url":"https://api.github.com/repos/tzeskimo/mocha-fibers/issues/comments/{number}","contents_url":"https://api.github.com/repos/tzeskimo/mocha-fibers/contents/{+path}","compare_url":"https://api.github.com/repos/tzeskimo/mocha-fibers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tzeskimo/mocha-fibers/merges","archive_url":"https://api.github.com/repos/tzeskimo/mocha-fibers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tzeskimo/mocha-fibers/downloads","issues_url":"https://api.github.com/repos/tzeskimo/mocha-fibers/issues{/number}","pulls_url":"https://api.github.com/repos/tzeskimo/mocha-fibers/pulls{/number}","milestones_url":"https://api.github.com/repos/tzeskimo/mocha-fibers/milestones{/number}","notifications_url":"https://api.github.com/repos/tzeskimo/mocha-fibers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tzeskimo/mocha-fibers/labels{/name}","releases_url":"https://api.github.com/repos/tzeskimo/mocha-fibers/releases{/id}","created_at":"2012-08-17T03:29:54Z","updated_at":"2014-07-03T17:58:12Z","pushed_at":"2014-07-03T17:58:12Z","git_url":"git://github.com/tzeskimo/mocha-fibers.git","ssh_url":"git@github.com:tzeskimo/mocha-fibers.git","clone_url":"https://github.com/tzeskimo/mocha-fibers.git","svn_url":"https://github.com/tzeskimo/mocha-fibers","homepage":null,"size":139,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":4,"mirror_url":null,"open_issues_count":1,"forks":4,"open_issues":1,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tzeskimo/mocha-fibers/pulls/4"},"html":{"href":"https://github.com/tzeskimo/mocha-fibers/pull/4"},"issue":{"href":"https://api.github.com/repos/tzeskimo/mocha-fibers/issues/4"},"comments":{"href":"https://api.github.com/repos/tzeskimo/mocha-fibers/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/tzeskimo/mocha-fibers/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/tzeskimo/mocha-fibers/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/tzeskimo/mocha-fibers/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/tzeskimo/mocha-fibers/statuses/c71821d9151203bb70346f8009aa8844dd91615f"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"tzeskimo","id":719524,"avatar_url":"https://avatars.githubusercontent.com/u/719524?","gravatar_id":"0267f68edc6ad5a6a3bb5e72ad5ebb33","url":"https://api.github.com/users/tzeskimo","html_url":"https://github.com/tzeskimo","followers_url":"https://api.github.com/users/tzeskimo/followers","following_url":"https://api.github.com/users/tzeskimo/following{/other_user}","gists_url":"https://api.github.com/users/tzeskimo/gists{/gist_id}","starred_url":"https://api.github.com/users/tzeskimo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tzeskimo/subscriptions","organizations_url":"https://api.github.com/users/tzeskimo/orgs","repos_url":"https://api.github.com/users/tzeskimo/repos","events_url":"https://api.github.com/users/tzeskimo/events{/privacy}","received_events_url":"https://api.github.com/users/tzeskimo/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":2,"additions":6,"deletions":65,"changed_files":2}}