GitHub PullRequestReviewCommentEvent at 2014-09-10 21:41:00
Repository: npm-www
Actor: ceejbot
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/npm/npm-www/pulls/comments/17391090","id":17391090,"diff_hunk":"@@ -26,43 +27,58 @@ function signUpStep1(req, res) {\n   })\n }\n \n-function createHubspotLead(model,res,data) {\n+// generic method to hit hubspot","path":"routes/enterprise-signup.js","position":15,"original_position":15,"commit_id":"ae594999c87a2512e77318e2ee76bebdc55501b8","original_commit_id":"ae594999c87a2512e77318e2ee76bebdc55501b8","user":{"login":"ceejbot","id":757502,"avatar_url":"https://avatars.githubusercontent.com/u/757502?v=2","gravatar_id":"0a356ffe066d3d8bf05be73fa57c0a44","url":"https://api.github.com/users/ceejbot","html_url":"https://github.com/ceejbot","followers_url":"https://api.github.com/users/ceejbot/followers","following_url":"https://api.github.com/users/ceejbot/following{/other_user}","gists_url":"https://api.github.com/users/ceejbot/gists{/gist_id}","starred_url":"https://api.github.com/users/ceejbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceejbot/subscriptions","organizations_url":"https://api.github.com/users/ceejbot/orgs","repos_url":"https://api.github.com/users/ceejbot/repos","events_url":"https://api.github.com/users/ceejbot/events{/privacy}","received_events_url":"https://api.github.com/users/ceejbot/received_events","type":"User","site_admin":false},"body":"I like this generalization.","created_at":"2014-09-10T21:41:00Z","updated_at":"2014-09-10T21:41:00Z","html_url":"https://github.com/npm/npm-www/pull/899#discussion_r17391090","pull_request_url":"https://api.github.com/repos/npm/npm-www/pulls/899","_links":{"self":{"href":"https://api.github.com/repos/npm/npm-www/pulls/comments/17391090"},"html":{"href":"https://github.com/npm/npm-www/pull/899#discussion_r17391090"},"pull_request":{"href":"https://api.github.com/repos/npm/npm-www/pulls/899"}}},"pull_request":{"url":"https://api.github.com/repos/npm/npm-www/pulls/899","id":21051963,"html_url":"https://github.com/npm/npm-www/pull/899","diff_url":"https://github.com/npm/npm-www/pull/899.diff","patch_url":"https://github.com/npm/npm-www/pull/899.patch","issue_url":"https://api.github.com/repos/npm/npm-www/issues/899","number":899,"state":"open","locked":false,"title":"Hubspot events for signup, agree ULA, ask for contact","user":{"login":"seldo","id":185893,"avatar_url":"https://avatars.githubusercontent.com/u/185893?v=2","gravatar_id":"8a928dbd910bf7ed8d4e3cba4ef60d82","url":"https://api.github.com/users/seldo","html_url":"https://github.com/seldo","followers_url":"https://api.github.com/users/seldo/followers","following_url":"https://api.github.com/users/seldo/following{/other_user}","gists_url":"https://api.github.com/users/seldo/gists{/gist_id}","starred_url":"https://api.github.com/users/seldo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seldo/subscriptions","organizations_url":"https://api.github.com/users/seldo/orgs","repos_url":"https://api.github.com/users/seldo/repos","events_url":"https://api.github.com/users/seldo/events{/privacy}","received_events_url":"https://api.github.com/users/seldo/received_events","type":"User","site_admin":false},"body":"Users now have the option to request being contacted if they don't want to agree to the ULA.\r\nHubspot gets notifications of 3 events:\r\n- anyone signs up\r\n- somebody agrees to ULA\r\n- somebody asks to be contacted instead","created_at":"2014-09-10T21:32:54Z","updated_at":"2014-09-10T21:41:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eb3501870838ee9c0a19ad023a855a92b82d43e4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/npm/npm-www/pulls/899/commits","review_comments_url":"https://api.github.com/repos/npm/npm-www/pulls/899/comments","review_comment_url":"https://api.github.com/repos/npm/npm-www/pulls/comments/{number}","comments_url":"https://api.github.com/repos/npm/npm-www/issues/899/comments","statuses_url":"https://api.github.com/repos/npm/npm-www/statuses/ae594999c87a2512e77318e2ee76bebdc55501b8","head":{"label":"npm:ljv-hubspot","ref":"ljv-hubspot","sha":"ae594999c87a2512e77318e2ee76bebdc55501b8","user":{"login":"npm","id":6078720,"avatar_url":"https://avatars.githubusercontent.com/u/6078720?v=2","gravatar_id":"46d8d00e190be647053f7d97fd0478e4","url":"https://api.github.com/users/npm","html_url":"https://github.com/npm","followers_url":"https://api.github.com/users/npm/followers","following_url":"https://api.github.com/users/npm/following{/other_user}","gists_url":"https://api.github.com/users/npm/gists{/gist_id}","starred_url":"https://api.github.com/users/npm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/npm/subscriptions","organizations_url":"https://api.github.com/users/npm/orgs","repos_url":"https://api.github.com/users/npm/repos","events_url":"https://api.github.com/users/npm/events{/privacy}","received_events_url":"https://api.github.com/users/npm/received_events","type":"Organization","site_admin":false},"repo":{"id":4070525,"name":"npm-www","full_name":"npm/npm-www","owner":{"login":"npm","id":6078720,"avatar_url":"https://avatars.githubusercontent.com/u/6078720?v=2","gravatar_id":"46d8d00e190be647053f7d97fd0478e4","url":"https://api.github.com/users/npm","html_url":"https://github.com/npm","followers_url":"https://api.github.com/users/npm/followers","following_url":"https://api.github.com/users/npm/following{/other_user}","gists_url":"https://api.github.com/users/npm/gists{/gist_id}","starred_url":"https://api.github.com/users/npm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/npm/subscriptions","organizations_url":"https://api.github.com/users/npm/orgs","repos_url":"https://api.github.com/users/npm/repos","events_url":"https://api.github.com/users/npm/events{/privacy}","received_events_url":"https://api.github.com/users/npm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/npm/npm-www","description":"npmjs.org website","fork":false,"url":"https://api.github.com/repos/npm/npm-www","forks_url":"https://api.github.com/repos/npm/npm-www/forks","keys_url":"https://api.github.com/repos/npm/npm-www/keys{/key_id}","collaborators_url":"https://api.github.com/repos/npm/npm-www/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/npm/npm-www/teams","hooks_url":"https://api.github.com/repos/npm/npm-www/hooks","issue_events_url":"https://api.github.com/repos/npm/npm-www/issues/events{/number}","events_url":"https://api.github.com/repos/npm/npm-www/events","assignees_url":"https://api.github.com/repos/npm/npm-www/assignees{/user}","branches_url":"https://api.github.com/repos/npm/npm-www/branches{/branch}","tags_url":"https://api.github.com/repos/npm/npm-www/tags","blobs_url":"https://api.github.com/repos/npm/npm-www/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/npm/npm-www/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/npm/npm-www/git/refs{/sha}","trees_url":"https://api.github.com/repos/npm/npm-www/git/trees{/sha}","statuses_url":"https://api.github.com/repos/npm/npm-www/statuses/{sha}","languages_url":"https://api.github.com/repos/npm/npm-www/languages","stargazers_url":"https://api.github.com/repos/npm/npm-www/stargazers","contributors_url":"https://api.github.com/repos/npm/npm-www/contributors","subscribers_url":"https://api.github.com/repos/npm/npm-www/subscribers","subscription_url":"https://api.github.com/repos/npm/npm-www/subscription","commits_url":"https://api.github.com/repos/npm/npm-www/commits{/sha}","git_commits_url":"https://api.github.com/repos/npm/npm-www/git/commits{/sha}","comments_url":"https://api.github.com/repos/npm/npm-www/comments{/number}","issue_comment_url":"https://api.github.com/repos/npm/npm-www/issues/comments/{number}","contents_url":"https://api.github.com/repos/npm/npm-www/contents/{+path}","compare_url":"https://api.github.com/repos/npm/npm-www/compare/{base}...{head}","merges_url":"https://api.github.com/repos/npm/npm-www/merges","archive_url":"https://api.github.com/repos/npm/npm-www/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/npm/npm-www/downloads","issues_url":"https://api.github.com/repos/npm/npm-www/issues{/number}","pulls_url":"https://api.github.com/repos/npm/npm-www/pulls{/number}","milestones_url":"https://api.github.com/repos/npm/npm-www/milestones{/number}","notifications_url":"https://api.github.com/repos/npm/npm-www/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/npm/npm-www/labels{/name}","releases_url":"https://api.github.com/repos/npm/npm-www/releases{/id}","created_at":"2012-04-19T01:42:57Z","updated_at":"2014-09-10T08:14:41Z","pushed_at":"2014-09-10T21:31:38Z","git_url":"git://github.com/npm/npm-www.git","ssh_url":"git@github.com:npm/npm-www.git","clone_url":"https://github.com/npm/npm-www.git","svn_url":"https://github.com/npm/npm-www","homepage":"http://npmjs.org/","size":32029,"stargazers_count":592,"watchers_count":592,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":201,"mirror_url":null,"open_issues_count":141,"forks":201,"open_issues":141,"watchers":592,"default_branch":"master"}},"base":{"label":"npm:master","ref":"master","sha":"0454700b50f33592e7bf3213c768ba52de4d58ec","user":{"login":"npm","id":6078720,"avatar_url":"https://avatars.githubusercontent.com/u/6078720?v=2","gravatar_id":"46d8d00e190be647053f7d97fd0478e4","url":"https://api.github.com/users/npm","html_url":"https://github.com/npm","followers_url":"https://api.github.com/users/npm/followers","following_url":"https://api.github.com/users/npm/following{/other_user}","gists_url":"https://api.github.com/users/npm/gists{/gist_id}","starred_url":"https://api.github.com/users/npm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/npm/subscriptions","organizations_url":"https://api.github.com/users/npm/orgs","repos_url":"https://api.github.com/users/npm/repos","events_url":"https://api.github.com/users/npm/events{/privacy}","received_events_url":"https://api.github.com/users/npm/received_events","type":"Organization","site_admin":false},"repo":{"id":4070525,"name":"npm-www","full_name":"npm/npm-www","owner":{"login":"npm","id":6078720,"avatar_url":"https://avatars.githubusercontent.com/u/6078720?v=2","gravatar_id":"46d8d00e190be647053f7d97fd0478e4","url":"https://api.github.com/users/npm","html_url":"https://github.com/npm","followers_url":"https://api.github.com/users/npm/followers","following_url":"https://api.github.com/users/npm/following{/other_user}","gists_url":"https://api.github.com/users/npm/gists{/gist_id}","starred_url":"https://api.github.com/users/npm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/npm/subscriptions","organizations_url":"https://api.github.com/users/npm/orgs","repos_url":"https://api.github.com/users/npm/repos","events_url":"https://api.github.com/users/npm/events{/privacy}","received_events_url":"https://api.github.com/users/npm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/npm/npm-www","description":"npmjs.org website","fork":false,"url":"https://api.github.com/repos/npm/npm-www","forks_url":"https://api.github.com/repos/npm/npm-www/forks","keys_url":"https://api.github.com/repos/npm/npm-www/keys{/key_id}","collaborators_url":"https://api.github.com/repos/npm/npm-www/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/npm/npm-www/teams","hooks_url":"https://api.github.com/repos/npm/npm-www/hooks","issue_events_url":"https://api.github.com/repos/npm/npm-www/issues/events{/number}","events_url":"https://api.github.com/repos/npm/npm-www/events","assignees_url":"https://api.github.com/repos/npm/npm-www/assignees{/user}","branches_url":"https://api.github.com/repos/npm/npm-www/branches{/branch}","tags_url":"https://api.github.com/repos/npm/npm-www/tags","blobs_url":"https://api.github.com/repos/npm/npm-www/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/npm/npm-www/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/npm/npm-www/git/refs{/sha}","trees_url":"https://api.github.com/repos/npm/npm-www/git/trees{/sha}","statuses_url":"https://api.github.com/repos/npm/npm-www/statuses/{sha}","languages_url":"https://api.github.com/repos/npm/npm-www/languages","stargazers_url":"https://api.github.com/repos/npm/npm-www/stargazers","contributors_url":"https://api.github.com/repos/npm/npm-www/contributors","subscribers_url":"https://api.github.com/repos/npm/npm-www/subscribers","subscription_url":"https://api.github.com/repos/npm/npm-www/subscription","commits_url":"https://api.github.com/repos/npm/npm-www/commits{/sha}","git_commits_url":"https://api.github.com/repos/npm/npm-www/git/commits{/sha}","comments_url":"https://api.github.com/repos/npm/npm-www/comments{/number}","issue_comment_url":"https://api.github.com/repos/npm/npm-www/issues/comments/{number}","contents_url":"https://api.github.com/repos/npm/npm-www/contents/{+path}","compare_url":"https://api.github.com/repos/npm/npm-www/compare/{base}...{head}","merges_url":"https://api.github.com/repos/npm/npm-www/merges","archive_url":"https://api.github.com/repos/npm/npm-www/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/npm/npm-www/downloads","issues_url":"https://api.github.com/repos/npm/npm-www/issues{/number}","pulls_url":"https://api.github.com/repos/npm/npm-www/pulls{/number}","milestones_url":"https://api.github.com/repos/npm/npm-www/milestones{/number}","notifications_url":"https://api.github.com/repos/npm/npm-www/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/npm/npm-www/labels{/name}","releases_url":"https://api.github.com/repos/npm/npm-www/releases{/id}","created_at":"2012-04-19T01:42:57Z","updated_at":"2014-09-10T08:14:41Z","pushed_at":"2014-09-10T21:31:38Z","git_url":"git://github.com/npm/npm-www.git","ssh_url":"git@github.com:npm/npm-www.git","clone_url":"https://github.com/npm/npm-www.git","svn_url":"https://github.com/npm/npm-www","homepage":"http://npmjs.org/","size":32029,"stargazers_count":592,"watchers_count":592,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":201,"mirror_url":null,"open_issues_count":141,"forks":201,"open_issues":141,"watchers":592,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/npm/npm-www/pulls/899"},"html":{"href":"https://github.com/npm/npm-www/pull/899"},"issue":{"href":"https://api.github.com/repos/npm/npm-www/issues/899"},"comments":{"href":"https://api.github.com/repos/npm/npm-www/issues/899/comments"},"review_comments":{"href":"https://api.github.com/repos/npm/npm-www/pulls/899/comments"},"review_comment":{"href":"https://api.github.com/repos/npm/npm-www/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/npm/npm-www/pulls/899/commits"},"statuses":{"href":"https://api.github.com/repos/npm/npm-www/statuses/ae594999c87a2512e77318e2ee76bebdc55501b8"}}}}