GitHub PullRequestReviewCommentEvent at 2014-09-05 02:16:22
Repository: cylc
Actor: hjoliver
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/cylc/cylc/pulls/comments/17154259","id":17154259,"diff_hunk":"@@ -630,27 +630,14 @@ def hold_all_tasks(self):\n                 itask.reset_state_held()\n \n     def release_all_tasks(self):\n-        # TODO ISO - check that we're not still holding tasks beyond suite\n-        # stop time (no point as finite-range tasks now disappear beyond\n-        # their stop time).\n         for itask in self.get_tasks(all=True):\n             if itask.state.is_currently('held'):\n-                #if self.stop_point and itask.point > self.stop_point:\n-                #    # this task has passed the suite stop time\n-                #    itask.log(INFO, \"Not releasing (beyond suite stop\n-                #    cycle) \" + str(self.stop_point))","path":"lib/cylc/task_pool.py","position":12,"original_position":12,"commit_id":"1d0f628b1d1c3e67c6162eeafe44c10c208d8b49","original_commit_id":"1d0f628b1d1c3e67c6162eeafe44c10c208d8b49","user":{"login":"hjoliver","id":2362137,"avatar_url":"https://avatars.githubusercontent.com/u/2362137?v=2","gravatar_id":"98e47cb02cad5b2dcec032d849a23e69","url":"https://api.github.com/users/hjoliver","html_url":"https://github.com/hjoliver","followers_url":"https://api.github.com/users/hjoliver/followers","following_url":"https://api.github.com/users/hjoliver/following{/other_user}","gists_url":"https://api.github.com/users/hjoliver/gists{/gist_id}","starred_url":"https://api.github.com/users/hjoliver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hjoliver/subscriptions","organizations_url":"https://api.github.com/users/hjoliver/orgs","repos_url":"https://api.github.com/users/hjoliver/repos","events_url":"https://api.github.com/users/hjoliver/events{/privacy}","received_events_url":"https://api.github.com/users/hjoliver/received_events","type":"User","site_admin":false},"body":"I restored this and tested it. Without it, it a suite was held after some tasks were held on passing the stop point, releasing the suite would result in the beyond-stop-point tasks running once.","created_at":"2014-09-05T02:16:22Z","updated_at":"2014-09-05T02:16:22Z","html_url":"https://github.com/cylc/cylc/pull/1144#discussion_r17154259","pull_request_url":"https://api.github.com/repos/cylc/cylc/pulls/1144","_links":{"self":{"href":"https://api.github.com/repos/cylc/cylc/pulls/comments/17154259"},"html":{"href":"https://github.com/cylc/cylc/pull/1144#discussion_r17154259"},"pull_request":{"href":"https://api.github.com/repos/cylc/cylc/pulls/1144"}}},"pull_request":{"url":"https://api.github.com/repos/cylc/cylc/pulls/1144","id":20784621,"html_url":"https://github.com/cylc/cylc/pull/1144","diff_url":"https://github.com/cylc/cylc/pull/1144.diff","patch_url":"https://github.com/cylc/cylc/pull/1144.patch","issue_url":"https://api.github.com/repos/cylc/cylc/issues/1144","number":1144,"state":"open","locked":false,"title":"Don't release tasks held beyond suite stop.","user":{"login":"hjoliver","id":2362137,"avatar_url":"https://avatars.githubusercontent.com/u/2362137?v=2","gravatar_id":"98e47cb02cad5b2dcec032d849a23e69","url":"https://api.github.com/users/hjoliver","html_url":"https://github.com/hjoliver","followers_url":"https://api.github.com/users/hjoliver/followers","following_url":"https://api.github.com/users/hjoliver/following{/other_user}","gists_url":"https://api.github.com/users/hjoliver/gists{/gist_id}","starred_url":"https://api.github.com/users/hjoliver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hjoliver/subscriptions","organizations_url":"https://api.github.com/users/hjoliver/orgs","repos_url":"https://api.github.com/users/hjoliver/repos","events_url":"https://api.github.com/users/hjoliver/events{/privacy}","received_events_url":"https://api.github.com/users/hjoliver/received_events","type":"User","site_admin":false},"body":"Addresses another of the remaining \"TODO ISO\" comments.  Tasks are still held beyond the suite stop point, which is handled differently to the end of a recurrence (for which tasks just disappear) because you might want to restart a suite with a later stop time.","created_at":"2014-09-05T02:13:49Z","updated_at":"2014-09-05T02:16:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1ad5c88f26da5ec9a46f8a1498989cf0e6a0fafd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cylc/cylc/pulls/1144/commits","review_comments_url":"https://api.github.com/repos/cylc/cylc/pulls/1144/comments","review_comment_url":"https://api.github.com/repos/cylc/cylc/pulls/comments/{number}","comments_url":"https://api.github.com/repos/cylc/cylc/issues/1144/comments","statuses_url":"https://api.github.com/repos/cylc/cylc/statuses/1d0f628b1d1c3e67c6162eeafe44c10c208d8b49","head":{"label":"hjoliver:todo-iso.hold-beyond-stop-point","ref":"todo-iso.hold-beyond-stop-point","sha":"1d0f628b1d1c3e67c6162eeafe44c10c208d8b49","user":{"login":"hjoliver","id":2362137,"avatar_url":"https://avatars.githubusercontent.com/u/2362137?v=2","gravatar_id":"98e47cb02cad5b2dcec032d849a23e69","url":"https://api.github.com/users/hjoliver","html_url":"https://github.com/hjoliver","followers_url":"https://api.github.com/users/hjoliver/followers","following_url":"https://api.github.com/users/hjoliver/following{/other_user}","gists_url":"https://api.github.com/users/hjoliver/gists{/gist_id}","starred_url":"https://api.github.com/users/hjoliver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hjoliver/subscriptions","organizations_url":"https://api.github.com/users/hjoliver/orgs","repos_url":"https://api.github.com/users/hjoliver/repos","events_url":"https://api.github.com/users/hjoliver/events{/privacy}","received_events_url":"https://api.github.com/users/hjoliver/received_events","type":"User","site_admin":false},"repo":{"id":5840564,"name":"cylc","full_name":"hjoliver/cylc","owner":{"login":"hjoliver","id":2362137,"avatar_url":"https://avatars.githubusercontent.com/u/2362137?v=2","gravatar_id":"98e47cb02cad5b2dcec032d849a23e69","url":"https://api.github.com/users/hjoliver","html_url":"https://github.com/hjoliver","followers_url":"https://api.github.com/users/hjoliver/followers","following_url":"https://api.github.com/users/hjoliver/following{/other_user}","gists_url":"https://api.github.com/users/hjoliver/gists{/gist_id}","starred_url":"https://api.github.com/users/hjoliver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hjoliver/subscriptions","organizations_url":"https://api.github.com/users/hjoliver/orgs","repos_url":"https://api.github.com/users/hjoliver/repos","events_url":"https://api.github.com/users/hjoliver/events{/privacy}","received_events_url":"https://api.github.com/users/hjoliver/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hjoliver/cylc","description":"My fork of the cylc suite engine. The central repository is here:","fork":true,"url":"https://api.github.com/repos/hjoliver/cylc","forks_url":"https://api.github.com/repos/hjoliver/cylc/forks","keys_url":"https://api.github.com/repos/hjoliver/cylc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hjoliver/cylc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hjoliver/cylc/teams","hooks_url":"https://api.github.com/repos/hjoliver/cylc/hooks","issue_events_url":"https://api.github.com/repos/hjoliver/cylc/issues/events{/number}","events_url":"https://api.github.com/repos/hjoliver/cylc/events","assignees_url":"https://api.github.com/repos/hjoliver/cylc/assignees{/user}","branches_url":"https://api.github.com/repos/hjoliver/cylc/branches{/branch}","tags_url":"https://api.github.com/repos/hjoliver/cylc/tags","blobs_url":"https://api.github.com/repos/hjoliver/cylc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hjoliver/cylc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hjoliver/cylc/git/refs{/sha}","trees_url":"https://api.github.com/repos/hjoliver/cylc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hjoliver/cylc/statuses/{sha}","languages_url":"https://api.github.com/repos/hjoliver/cylc/languages","stargazers_url":"https://api.github.com/repos/hjoliver/cylc/stargazers","contributors_url":"https://api.github.com/repos/hjoliver/cylc/contributors","subscribers_url":"https://api.github.com/repos/hjoliver/cylc/subscribers","subscription_url":"https://api.github.com/repos/hjoliver/cylc/subscription","commits_url":"https://api.github.com/repos/hjoliver/cylc/commits{/sha}","git_commits_url":"https://api.github.com/repos/hjoliver/cylc/git/commits{/sha}","comments_url":"https://api.github.com/repos/hjoliver/cylc/comments{/number}","issue_comment_url":"https://api.github.com/repos/hjoliver/cylc/issues/comments/{number}","contents_url":"https://api.github.com/repos/hjoliver/cylc/contents/{+path}","compare_url":"https://api.github.com/repos/hjoliver/cylc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hjoliver/cylc/merges","archive_url":"https://api.github.com/repos/hjoliver/cylc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hjoliver/cylc/downloads","issues_url":"https://api.github.com/repos/hjoliver/cylc/issues{/number}","pulls_url":"https://api.github.com/repos/hjoliver/cylc/pulls{/number}","milestones_url":"https://api.github.com/repos/hjoliver/cylc/milestones{/number}","notifications_url":"https://api.github.com/repos/hjoliver/cylc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hjoliver/cylc/labels{/name}","releases_url":"https://api.github.com/repos/hjoliver/cylc/releases{/id}","created_at":"2012-09-17T12:20:56Z","updated_at":"2014-07-06T21:06:43Z","pushed_at":"2014-09-05T02:11:28Z","git_url":"git://github.com/hjoliver/cylc.git","ssh_url":"git@github.com:hjoliver/cylc.git","clone_url":"https://github.com/hjoliver/cylc.git","svn_url":"https://github.com/hjoliver/cylc","homepage":"http://cylc.github.com/cylc","size":70834,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"cylc:master","ref":"master","sha":"5339f2586aa0a6085808c235c8c6bd20e58afed6","user":{"login":"cylc","id":824878,"avatar_url":"https://avatars.githubusercontent.com/u/824878?v=2","gravatar_id":"56ea86afcfc02c2006af9f6ae74f0f21","url":"https://api.github.com/users/cylc","html_url":"https://github.com/cylc","followers_url":"https://api.github.com/users/cylc/followers","following_url":"https://api.github.com/users/cylc/following{/other_user}","gists_url":"https://api.github.com/users/cylc/gists{/gist_id}","starred_url":"https://api.github.com/users/cylc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cylc/subscriptions","organizations_url":"https://api.github.com/users/cylc/orgs","repos_url":"https://api.github.com/users/cylc/repos","events_url":"https://api.github.com/users/cylc/events{/privacy}","received_events_url":"https://api.github.com/users/cylc/received_events","type":"Organization","site_admin":false},"repo":{"id":1836229,"name":"cylc","full_name":"cylc/cylc","owner":{"login":"cylc","id":824878,"avatar_url":"https://avatars.githubusercontent.com/u/824878?v=2","gravatar_id":"56ea86afcfc02c2006af9f6ae74f0f21","url":"https://api.github.com/users/cylc","html_url":"https://github.com/cylc","followers_url":"https://api.github.com/users/cylc/followers","following_url":"https://api.github.com/users/cylc/following{/other_user}","gists_url":"https://api.github.com/users/cylc/gists{/gist_id}","starred_url":"https://api.github.com/users/cylc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cylc/subscriptions","organizations_url":"https://api.github.com/users/cylc/orgs","repos_url":"https://api.github.com/users/cylc/repos","events_url":"https://api.github.com/users/cylc/events{/privacy}","received_events_url":"https://api.github.com/users/cylc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cylc/cylc","description":"This is the official repository of the cylc suite engine. It will normally contain just the master branch, with completed features merged in from feature branches in developer forks.","fork":false,"url":"https://api.github.com/repos/cylc/cylc","forks_url":"https://api.github.com/repos/cylc/cylc/forks","keys_url":"https://api.github.com/repos/cylc/cylc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cylc/cylc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cylc/cylc/teams","hooks_url":"https://api.github.com/repos/cylc/cylc/hooks","issue_events_url":"https://api.github.com/repos/cylc/cylc/issues/events{/number}","events_url":"https://api.github.com/repos/cylc/cylc/events","assignees_url":"https://api.github.com/repos/cylc/cylc/assignees{/user}","branches_url":"https://api.github.com/repos/cylc/cylc/branches{/branch}","tags_url":"https://api.github.com/repos/cylc/cylc/tags","blobs_url":"https://api.github.com/repos/cylc/cylc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cylc/cylc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cylc/cylc/git/refs{/sha}","trees_url":"https://api.github.com/repos/cylc/cylc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cylc/cylc/statuses/{sha}","languages_url":"https://api.github.com/repos/cylc/cylc/languages","stargazers_url":"https://api.github.com/repos/cylc/cylc/stargazers","contributors_url":"https://api.github.com/repos/cylc/cylc/contributors","subscribers_url":"https://api.github.com/repos/cylc/cylc/subscribers","subscription_url":"https://api.github.com/repos/cylc/cylc/subscription","commits_url":"https://api.github.com/repos/cylc/cylc/commits{/sha}","git_commits_url":"https://api.github.com/repos/cylc/cylc/git/commits{/sha}","comments_url":"https://api.github.com/repos/cylc/cylc/comments{/number}","issue_comment_url":"https://api.github.com/repos/cylc/cylc/issues/comments/{number}","contents_url":"https://api.github.com/repos/cylc/cylc/contents/{+path}","compare_url":"https://api.github.com/repos/cylc/cylc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cylc/cylc/merges","archive_url":"https://api.github.com/repos/cylc/cylc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cylc/cylc/downloads","issues_url":"https://api.github.com/repos/cylc/cylc/issues{/number}","pulls_url":"https://api.github.com/repos/cylc/cylc/pulls{/number}","milestones_url":"https://api.github.com/repos/cylc/cylc/milestones{/number}","notifications_url":"https://api.github.com/repos/cylc/cylc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cylc/cylc/labels{/name}","releases_url":"https://api.github.com/repos/cylc/cylc/releases{/id}","created_at":"2011-06-02T08:31:49Z","updated_at":"2014-09-02T10:56:29Z","pushed_at":"2014-09-04T11:26:31Z","git_url":"git://github.com/cylc/cylc.git","ssh_url":"git@github.com:cylc/cylc.git","clone_url":"https://github.com/cylc/cylc.git","svn_url":"https://github.com/cylc/cylc","homepage":"http://cylc.github.com/cylc","size":83729,"stargazers_count":20,"watchers_count":20,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":15,"mirror_url":null,"open_issues_count":150,"forks":15,"open_issues":150,"watchers":20,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cylc/cylc/pulls/1144"},"html":{"href":"https://github.com/cylc/cylc/pull/1144"},"issue":{"href":"https://api.github.com/repos/cylc/cylc/issues/1144"},"comments":{"href":"https://api.github.com/repos/cylc/cylc/issues/1144/comments"},"review_comments":{"href":"https://api.github.com/repos/cylc/cylc/pulls/1144/comments"},"review_comment":{"href":"https://api.github.com/repos/cylc/cylc/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/cylc/cylc/pulls/1144/commits"},"statuses":{"href":"https://api.github.com/repos/cylc/cylc/statuses/1d0f628b1d1c3e67c6162eeafe44c10c208d8b49"}}}}