GitHub PullRequestReviewCommentEvent at 2014-12-29 11:18:32
Repository: cdk
Actor: egonw
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/cdk/cdk/pulls/comments/22308928","id":22308928,"diff_hunk":"@@ -0,0 +1,609 @@\n+/* Copyright (C) 2014  Tomas Pluskal <plusik@gmail.com>\n+ *\n+ * Contact: cdk-devel@lists.sourceforge.net\n+ *\n+ * This program is free software; you can redistribute it and/or\n+ * modify it under the terms of the GNU Lesser General Public License\n+ * as published by the Free Software Foundation; either version 2.1\n+ * of the License, or (at your option) any later version.\n+ *\n+ * This program is distributed in the hope that it will be useful,\n+ * but WITHOUT ANY WARRANTY; without even the implied warranty of\n+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the\n+ * GNU Lesser General Public License for more details.\n+ *\n+ * You should have received a copy of the GNU Lesser General Public License\n+ * along with this program; if not, write to the Free Software\n+ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.\n+ */\n+package org.openscience.cdk.formula;\n+\n+import org.junit.Assert;\n+import org.junit.Test;\n+import org.openscience.cdk.CDKTestCase;\n+import org.openscience.cdk.config.IsotopeFactory;\n+import org.openscience.cdk.config.Isotopes;\n+import org.openscience.cdk.exception.CDKException;\n+import org.openscience.cdk.interfaces.IChemObjectBuilder;\n+import org.openscience.cdk.interfaces.IIsotope;\n+import org.openscience.cdk.interfaces.IMolecularFormula;\n+import org.openscience.cdk.interfaces.IMolecularFormulaSet;\n+import org.openscience.cdk.silent.SilentChemObjectBuilder;\n+import org.openscience.cdk.tools.manipulator.MolecularFormulaManipulator;\n+\n+/**\n+ * Checks the functionality of the MolecularFormulaGenerator.\n+ *\n+ * @cdk.module test-formula\n+ */\n+public class MolecularFormulaGeneratorTest extends CDKTestCase {","path":"tool/formula/src/test/java/org/openscience/cdk/formula/MolecularFormulaGeneratorTest.java","position":39,"original_position":39,"commit_id":"b8e030ad14c3e4ef1ee64ddf1f0e40ed0a870065","original_commit_id":"b8e030ad14c3e4ef1ee64ddf1f0e40ed0a870065","user":{"login":"egonw","id":26721,"avatar_url":"https://avatars.githubusercontent.com/u/26721?v=3","gravatar_id":"","url":"https://api.github.com/users/egonw","html_url":"https://github.com/egonw","followers_url":"https://api.github.com/users/egonw/followers","following_url":"https://api.github.com/users/egonw/following{/other_user}","gists_url":"https://api.github.com/users/egonw/gists{/gist_id}","starred_url":"https://api.github.com/users/egonw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/egonw/subscriptions","organizations_url":"https://api.github.com/users/egonw/orgs","repos_url":"https://api.github.com/users/egonw/repos","events_url":"https://api.github.com/users/egonw/events{/privacy}","received_events_url":"https://api.github.com/users/egonw/received_events","type":"User","site_admin":false},"body":"Does this list of tests also include the tests MassToFormulaToolTest?","created_at":"2014-12-29T11:18:32Z","updated_at":"2014-12-29T11:18:32Z","html_url":"https://github.com/cdk/cdk/pull/103#discussion_r22308928","pull_request_url":"https://api.github.com/repos/cdk/cdk/pulls/103","_links":{"self":{"href":"https://api.github.com/repos/cdk/cdk/pulls/comments/22308928"},"html":{"href":"https://github.com/cdk/cdk/pull/103#discussion_r22308928"},"pull_request":{"href":"https://api.github.com/repos/cdk/cdk/pulls/103"}}},"pull_request":{"url":"https://api.github.com/repos/cdk/cdk/pulls/103","id":26630507,"html_url":"https://github.com/cdk/cdk/pull/103","diff_url":"https://github.com/cdk/cdk/pull/103.diff","patch_url":"https://github.com/cdk/cdk/pull/103.patch","issue_url":"https://api.github.com/repos/cdk/cdk/issues/103","number":103,"state":"open","locked":false,"title":"new MolecularFormulaGenerator","user":{"login":"tomas-pluskal","id":1796692,"avatar_url":"https://avatars.githubusercontent.com/u/1796692?v=3","gravatar_id":"","url":"https://api.github.com/users/tomas-pluskal","html_url":"https://github.com/tomas-pluskal","followers_url":"https://api.github.com/users/tomas-pluskal/followers","following_url":"https://api.github.com/users/tomas-pluskal/following{/other_user}","gists_url":"https://api.github.com/users/tomas-pluskal/gists{/gist_id}","starred_url":"https://api.github.com/users/tomas-pluskal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomas-pluskal/subscriptions","organizations_url":"https://api.github.com/users/tomas-pluskal/orgs","repos_url":"https://api.github.com/users/tomas-pluskal/repos","events_url":"https://api.github.com/users/tomas-pluskal/events{/privacy}","received_events_url":"https://api.github.com/users/tomas-pluskal/received_events","type":"User","site_admin":false},"body":"Creating a pull request as discussed on the cdk-devel list.","created_at":"2014-12-29T02:26:04Z","updated_at":"2014-12-29T11:18:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e34d42f375e19cd81dec12fda263cf77ddd9613c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cdk/cdk/pulls/103/commits","review_comments_url":"https://api.github.com/repos/cdk/cdk/pulls/103/comments","review_comment_url":"https://api.github.com/repos/cdk/cdk/pulls/comments/{number}","comments_url":"https://api.github.com/repos/cdk/cdk/issues/103/comments","statuses_url":"https://api.github.com/repos/cdk/cdk/statuses/b8e030ad14c3e4ef1ee64ddf1f0e40ed0a870065","head":{"label":"tomas-pluskal:master","ref":"master","sha":"b8e030ad14c3e4ef1ee64ddf1f0e40ed0a870065","user":{"login":"tomas-pluskal","id":1796692,"avatar_url":"https://avatars.githubusercontent.com/u/1796692?v=3","gravatar_id":"","url":"https://api.github.com/users/tomas-pluskal","html_url":"https://github.com/tomas-pluskal","followers_url":"https://api.github.com/users/tomas-pluskal/followers","following_url":"https://api.github.com/users/tomas-pluskal/following{/other_user}","gists_url":"https://api.github.com/users/tomas-pluskal/gists{/gist_id}","starred_url":"https://api.github.com/users/tomas-pluskal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomas-pluskal/subscriptions","organizations_url":"https://api.github.com/users/tomas-pluskal/orgs","repos_url":"https://api.github.com/users/tomas-pluskal/repos","events_url":"https://api.github.com/users/tomas-pluskal/events{/privacy}","received_events_url":"https://api.github.com/users/tomas-pluskal/received_events","type":"User","site_admin":false},"repo":{"id":28576057,"name":"cdk","full_name":"tomas-pluskal/cdk","owner":{"login":"tomas-pluskal","id":1796692,"avatar_url":"https://avatars.githubusercontent.com/u/1796692?v=3","gravatar_id":"","url":"https://api.github.com/users/tomas-pluskal","html_url":"https://github.com/tomas-pluskal","followers_url":"https://api.github.com/users/tomas-pluskal/followers","following_url":"https://api.github.com/users/tomas-pluskal/following{/other_user}","gists_url":"https://api.github.com/users/tomas-pluskal/gists{/gist_id}","starred_url":"https://api.github.com/users/tomas-pluskal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomas-pluskal/subscriptions","organizations_url":"https://api.github.com/users/tomas-pluskal/orgs","repos_url":"https://api.github.com/users/tomas-pluskal/repos","events_url":"https://api.github.com/users/tomas-pluskal/events{/privacy}","received_events_url":"https://api.github.com/users/tomas-pluskal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tomas-pluskal/cdk","description":"The Chemistry Development Kit","fork":true,"url":"https://api.github.com/repos/tomas-pluskal/cdk","forks_url":"https://api.github.com/repos/tomas-pluskal/cdk/forks","keys_url":"https://api.github.com/repos/tomas-pluskal/cdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tomas-pluskal/cdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tomas-pluskal/cdk/teams","hooks_url":"https://api.github.com/repos/tomas-pluskal/cdk/hooks","issue_events_url":"https://api.github.com/repos/tomas-pluskal/cdk/issues/events{/number}","events_url":"https://api.github.com/repos/tomas-pluskal/cdk/events","assignees_url":"https://api.github.com/repos/tomas-pluskal/cdk/assignees{/user}","branches_url":"https://api.github.com/repos/tomas-pluskal/cdk/branches{/branch}","tags_url":"https://api.github.com/repos/tomas-pluskal/cdk/tags","blobs_url":"https://api.github.com/repos/tomas-pluskal/cdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tomas-pluskal/cdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tomas-pluskal/cdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/tomas-pluskal/cdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tomas-pluskal/cdk/statuses/{sha}","languages_url":"https://api.github.com/repos/tomas-pluskal/cdk/languages","stargazers_url":"https://api.github.com/repos/tomas-pluskal/cdk/stargazers","contributors_url":"https://api.github.com/repos/tomas-pluskal/cdk/contributors","subscribers_url":"https://api.github.com/repos/tomas-pluskal/cdk/subscribers","subscription_url":"https://api.github.com/repos/tomas-pluskal/cdk/subscription","commits_url":"https://api.github.com/repos/tomas-pluskal/cdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/tomas-pluskal/cdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/tomas-pluskal/cdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/tomas-pluskal/cdk/issues/comments/{number}","contents_url":"https://api.github.com/repos/tomas-pluskal/cdk/contents/{+path}","compare_url":"https://api.github.com/repos/tomas-pluskal/cdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tomas-pluskal/cdk/merges","archive_url":"https://api.github.com/repos/tomas-pluskal/cdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tomas-pluskal/cdk/downloads","issues_url":"https://api.github.com/repos/tomas-pluskal/cdk/issues{/number}","pulls_url":"https://api.github.com/repos/tomas-pluskal/cdk/pulls{/number}","milestones_url":"https://api.github.com/repos/tomas-pluskal/cdk/milestones{/number}","notifications_url":"https://api.github.com/repos/tomas-pluskal/cdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tomas-pluskal/cdk/labels{/name}","releases_url":"https://api.github.com/repos/tomas-pluskal/cdk/releases{/id}","created_at":"2014-12-29T01:24:44Z","updated_at":"2014-12-29T02:24:22Z","pushed_at":"2014-12-29T02:24:22Z","git_url":"git://github.com/tomas-pluskal/cdk.git","ssh_url":"git@github.com:tomas-pluskal/cdk.git","clone_url":"https://github.com/tomas-pluskal/cdk.git","svn_url":"https://github.com/tomas-pluskal/cdk","homepage":"http://cdk.sf.net/","size":193702,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cdk:master","ref":"master","sha":"e09e98c5a087d51ede87e4df4d28432b3acdb234","user":{"login":"cdk","id":273111,"avatar_url":"https://avatars.githubusercontent.com/u/273111?v=3","gravatar_id":"","url":"https://api.github.com/users/cdk","html_url":"https://github.com/cdk","followers_url":"https://api.github.com/users/cdk/followers","following_url":"https://api.github.com/users/cdk/following{/other_user}","gists_url":"https://api.github.com/users/cdk/gists{/gist_id}","starred_url":"https://api.github.com/users/cdk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdk/subscriptions","organizations_url":"https://api.github.com/users/cdk/orgs","repos_url":"https://api.github.com/users/cdk/repos","events_url":"https://api.github.com/users/cdk/events{/privacy}","received_events_url":"https://api.github.com/users/cdk/received_events","type":"Organization","site_admin":false},"repo":{"id":660443,"name":"cdk","full_name":"cdk/cdk","owner":{"login":"cdk","id":273111,"avatar_url":"https://avatars.githubusercontent.com/u/273111?v=3","gravatar_id":"","url":"https://api.github.com/users/cdk","html_url":"https://github.com/cdk","followers_url":"https://api.github.com/users/cdk/followers","following_url":"https://api.github.com/users/cdk/following{/other_user}","gists_url":"https://api.github.com/users/cdk/gists{/gist_id}","starred_url":"https://api.github.com/users/cdk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdk/subscriptions","organizations_url":"https://api.github.com/users/cdk/orgs","repos_url":"https://api.github.com/users/cdk/repos","events_url":"https://api.github.com/users/cdk/events{/privacy}","received_events_url":"https://api.github.com/users/cdk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cdk/cdk","description":"The Chemistry Development Kit","fork":true,"url":"https://api.github.com/repos/cdk/cdk","forks_url":"https://api.github.com/repos/cdk/cdk/forks","keys_url":"https://api.github.com/repos/cdk/cdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cdk/cdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cdk/cdk/teams","hooks_url":"https://api.github.com/repos/cdk/cdk/hooks","issue_events_url":"https://api.github.com/repos/cdk/cdk/issues/events{/number}","events_url":"https://api.github.com/repos/cdk/cdk/events","assignees_url":"https://api.github.com/repos/cdk/cdk/assignees{/user}","branches_url":"https://api.github.com/repos/cdk/cdk/branches{/branch}","tags_url":"https://api.github.com/repos/cdk/cdk/tags","blobs_url":"https://api.github.com/repos/cdk/cdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cdk/cdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cdk/cdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/cdk/cdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cdk/cdk/statuses/{sha}","languages_url":"https://api.github.com/repos/cdk/cdk/languages","stargazers_url":"https://api.github.com/repos/cdk/cdk/stargazers","contributors_url":"https://api.github.com/repos/cdk/cdk/contributors","subscribers_url":"https://api.github.com/repos/cdk/cdk/subscribers","subscription_url":"https://api.github.com/repos/cdk/cdk/subscription","commits_url":"https://api.github.com/repos/cdk/cdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/cdk/cdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/cdk/cdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/cdk/cdk/issues/comments/{number}","contents_url":"https://api.github.com/repos/cdk/cdk/contents/{+path}","compare_url":"https://api.github.com/repos/cdk/cdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cdk/cdk/merges","archive_url":"https://api.github.com/repos/cdk/cdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cdk/cdk/downloads","issues_url":"https://api.github.com/repos/cdk/cdk/issues{/number}","pulls_url":"https://api.github.com/repos/cdk/cdk/pulls{/number}","milestones_url":"https://api.github.com/repos/cdk/cdk/milestones{/number}","notifications_url":"https://api.github.com/repos/cdk/cdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cdk/cdk/labels{/name}","releases_url":"https://api.github.com/repos/cdk/cdk/releases{/id}","created_at":"2010-05-11T08:30:07Z","updated_at":"2014-12-28T15:29:20Z","pushed_at":"2014-12-28T15:29:20Z","git_url":"git://github.com/cdk/cdk.git","ssh_url":"git@github.com:cdk/cdk.git","clone_url":"https://github.com/cdk/cdk.git","svn_url":"https://github.com/cdk/cdk","homepage":"http://cdk.sf.net/","size":193702,"stargazers_count":35,"watchers_count":35,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":27,"mirror_url":null,"open_issues_count":2,"forks":27,"open_issues":2,"watchers":35,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cdk/cdk/pulls/103"},"html":{"href":"https://github.com/cdk/cdk/pull/103"},"issue":{"href":"https://api.github.com/repos/cdk/cdk/issues/103"},"comments":{"href":"https://api.github.com/repos/cdk/cdk/issues/103/comments"},"review_comments":{"href":"https://api.github.com/repos/cdk/cdk/pulls/103/comments"},"review_comment":{"href":"https://api.github.com/repos/cdk/cdk/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/cdk/cdk/pulls/103/commits"},"statuses":{"href":"https://api.github.com/repos/cdk/cdk/statuses/b8e030ad14c3e4ef1ee64ddf1f0e40ed0a870065"}}}}