GitHub PullRequestEvent at 2014-07-10 12:46:34
Repository: ember-cli-async-button
Actor: danmcclain
Payload: {"action":"opened","number":3,"pull_request":{"url":"https://api.github.com/repos/dockyard/ember-cli-async-button/pulls/3","id":18216921,"html_url":"https://github.com/dockyard/ember-cli-async-button/pull/3","diff_url":"https://github.com/dockyard/ember-cli-async-button/pull/3.diff","patch_url":"https://github.com/dockyard/ember-cli-async-button/pull/3.patch","issue_url":"https://api.github.com/repos/dockyard/ember-cli-async-button/issues/3","number":3,"state":"open","title":"Fixes template loading for versions greater than 37","user":{"login":"danmcclain","id":144138,"avatar_url":"https://avatars.githubusercontent.com/u/144138?","gravatar_id":"ef16c122bdbe053704f2307cea255867","url":"https://api.github.com/users/danmcclain","html_url":"https://github.com/danmcclain","followers_url":"https://api.github.com/users/danmcclain/followers","following_url":"https://api.github.com/users/danmcclain/following{/other_user}","gists_url":"https://api.github.com/users/danmcclain/gists{/gist_id}","starred_url":"https://api.github.com/users/danmcclain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danmcclain/subscriptions","organizations_url":"https://api.github.com/users/danmcclain/orgs","repos_url":"https://api.github.com/users/danmcclain/repos","events_url":"https://api.github.com/users/danmcclain/events{/privacy}","received_events_url":"https://api.github.com/users/danmcclain/received_events","type":"User","site_admin":false},"body":"This is a backwards compatible fix. The way templates were loaded was\r\nchanged by @rjackson, `template` is passed to `treeFor`, since it is\r\nunder `app` it would not be loaded previously.\r\n\r\nIf we don't care about pre-0.0.39, then the other fix for this is to\r\nleave `treeFor` the same, and move the `templates` directory to a\r\nsibling of `app`. If desired, I can alter this PR\r\n\r\n@rjackson helped in the making of this PR :+1:","created_at":"2014-07-10T12:46:33Z","updated_at":"2014-07-10T12:46:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dockyard/ember-cli-async-button/pulls/3/commits","review_comments_url":"https://api.github.com/repos/dockyard/ember-cli-async-button/pulls/3/comments","review_comment_url":"https://api.github.com/repos/dockyard/ember-cli-async-button/pulls/comments/{number}","comments_url":"https://api.github.com/repos/dockyard/ember-cli-async-button/issues/3/comments","statuses_url":"https://api.github.com/repos/dockyard/ember-cli-async-button/statuses/0d95d098414ae00a856ab9c660cbed280170b783","head":{"label":"dockyard:dm-fix-templates-for-cli-37-plus","ref":"dm-fix-templates-for-cli-37-plus","sha":"0d95d098414ae00a856ab9c660cbed280170b783","user":{"login":"dockyard","id":873981,"avatar_url":"https://avatars.githubusercontent.com/u/873981?","gravatar_id":"82da34d9988c79d5aa8114b9a28541a2","url":"https://api.github.com/users/dockyard","html_url":"https://github.com/dockyard","followers_url":"https://api.github.com/users/dockyard/followers","following_url":"https://api.github.com/users/dockyard/following{/other_user}","gists_url":"https://api.github.com/users/dockyard/gists{/gist_id}","starred_url":"https://api.github.com/users/dockyard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dockyard/subscriptions","organizations_url":"https://api.github.com/users/dockyard/orgs","repos_url":"https://api.github.com/users/dockyard/repos","events_url":"https://api.github.com/users/dockyard/events{/privacy}","received_events_url":"https://api.github.com/users/dockyard/received_events","type":"Organization","site_admin":false},"repo":{"id":21312470,"name":"ember-cli-async-button","full_name":"dockyard/ember-cli-async-button","owner":{"login":"dockyard","id":873981,"avatar_url":"https://avatars.githubusercontent.com/u/873981?","gravatar_id":"82da34d9988c79d5aa8114b9a28541a2","url":"https://api.github.com/users/dockyard","html_url":"https://github.com/dockyard","followers_url":"https://api.github.com/users/dockyard/followers","following_url":"https://api.github.com/users/dockyard/following{/other_user}","gists_url":"https://api.github.com/users/dockyard/gists{/gist_id}","starred_url":"https://api.github.com/users/dockyard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dockyard/subscriptions","organizations_url":"https://api.github.com/users/dockyard/orgs","repos_url":"https://api.github.com/users/dockyard/repos","events_url":"https://api.github.com/users/dockyard/events{/privacy}","received_events_url":"https://api.github.com/users/dockyard/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dockyard/ember-cli-async-button","description":"Async Button Component for Ember CLI apps","fork":false,"url":"https://api.github.com/repos/dockyard/ember-cli-async-button","forks_url":"https://api.github.com/repos/dockyard/ember-cli-async-button/forks","keys_url":"https://api.github.com/repos/dockyard/ember-cli-async-button/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dockyard/ember-cli-async-button/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dockyard/ember-cli-async-button/teams","hooks_url":"https://api.github.com/repos/dockyard/ember-cli-async-button/hooks","issue_events_url":"https://api.github.com/repos/dockyard/ember-cli-async-button/issues/events{/number}","events_url":"https://api.github.com/repos/dockyard/ember-cli-async-button/events","assignees_url":"https://api.github.com/repos/dockyard/ember-cli-async-button/assignees{/user}","branches_url":"https://api.github.com/repos/dockyard/ember-cli-async-button/branches{/branch}","tags_url":"https://api.github.com/repos/dockyard/ember-cli-async-button/tags","blobs_url":"https://api.github.com/repos/dockyard/ember-cli-async-button/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dockyard/ember-cli-async-button/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dockyard/ember-cli-async-button/git/refs{/sha}","trees_url":"https://api.github.com/repos/dockyard/ember-cli-async-button/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dockyard/ember-cli-async-button/statuses/{sha}","languages_url":"https://api.github.com/repos/dockyard/ember-cli-async-button/languages","stargazers_url":"https://api.github.com/repos/dockyard/ember-cli-async-button/stargazers","contributors_url":"https://api.github.com/repos/dockyard/ember-cli-async-button/contributors","subscribers_url":"https://api.github.com/repos/dockyard/ember-cli-async-button/subscribers","subscription_url":"https://api.github.com/repos/dockyard/ember-cli-async-button/subscription","commits_url":"https://api.github.com/repos/dockyard/ember-cli-async-button/commits{/sha}","git_commits_url":"https://api.github.com/repos/dockyard/ember-cli-async-button/git/commits{/sha}","comments_url":"https://api.github.com/repos/dockyard/ember-cli-async-button/comments{/number}","issue_comment_url":"https://api.github.com/repos/dockyard/ember-cli-async-button/issues/comments/{number}","contents_url":"https://api.github.com/repos/dockyard/ember-cli-async-button/contents/{+path}","compare_url":"https://api.github.com/repos/dockyard/ember-cli-async-button/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dockyard/ember-cli-async-button/merges","archive_url":"https://api.github.com/repos/dockyard/ember-cli-async-button/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dockyard/ember-cli-async-button/downloads","issues_url":"https://api.github.com/repos/dockyard/ember-cli-async-button/issues{/number}","pulls_url":"https://api.github.com/repos/dockyard/ember-cli-async-button/pulls{/number}","milestones_url":"https://api.github.com/repos/dockyard/ember-cli-async-button/milestones{/number}","notifications_url":"https://api.github.com/repos/dockyard/ember-cli-async-button/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dockyard/ember-cli-async-button/labels{/name}","releases_url":"https://api.github.com/repos/dockyard/ember-cli-async-button/releases{/id}","created_at":"2014-06-28T22:50:26Z","updated_at":"2014-07-08T09:25:30Z","pushed_at":"2014-07-10T12:46:24Z","git_url":"git://github.com/dockyard/ember-cli-async-button.git","ssh_url":"git@github.com:dockyard/ember-cli-async-button.git","clone_url":"https://github.com/dockyard/ember-cli-async-button.git","svn_url":"https://github.com/dockyard/ember-cli-async-button","homepage":"","size":152,"stargazers_count":27,"watchers_count":27,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":27,"default_branch":"master"}},"base":{"label":"dockyard:master","ref":"master","sha":"0567f424e73248b25d7970cdbd3250f53e8bff36","user":{"login":"dockyard","id":873981,"avatar_url":"https://avatars.githubusercontent.com/u/873981?","gravatar_id":"82da34d9988c79d5aa8114b9a28541a2","url":"https://api.github.com/users/dockyard","html_url":"https://github.com/dockyard","followers_url":"https://api.github.com/users/dockyard/followers","following_url":"https://api.github.com/users/dockyard/following{/other_user}","gists_url":"https://api.github.com/users/dockyard/gists{/gist_id}","starred_url":"https://api.github.com/users/dockyard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dockyard/subscriptions","organizations_url":"https://api.github.com/users/dockyard/orgs","repos_url":"https://api.github.com/users/dockyard/repos","events_url":"https://api.github.com/users/dockyard/events{/privacy}","received_events_url":"https://api.github.com/users/dockyard/received_events","type":"Organization","site_admin":false},"repo":{"id":21312470,"name":"ember-cli-async-button","full_name":"dockyard/ember-cli-async-button","owner":{"login":"dockyard","id":873981,"avatar_url":"https://avatars.githubusercontent.com/u/873981?","gravatar_id":"82da34d9988c79d5aa8114b9a28541a2","url":"https://api.github.com/users/dockyard","html_url":"https://github.com/dockyard","followers_url":"https://api.github.com/users/dockyard/followers","following_url":"https://api.github.com/users/dockyard/following{/other_user}","gists_url":"https://api.github.com/users/dockyard/gists{/gist_id}","starred_url":"https://api.github.com/users/dockyard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dockyard/subscriptions","organizations_url":"https://api.github.com/users/dockyard/orgs","repos_url":"https://api.github.com/users/dockyard/repos","events_url":"https://api.github.com/users/dockyard/events{/privacy}","received_events_url":"https://api.github.com/users/dockyard/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dockyard/ember-cli-async-button","description":"Async Button Component for Ember CLI apps","fork":false,"url":"https://api.github.com/repos/dockyard/ember-cli-async-button","forks_url":"https://api.github.com/repos/dockyard/ember-cli-async-button/forks","keys_url":"https://api.github.com/repos/dockyard/ember-cli-async-button/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dockyard/ember-cli-async-button/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dockyard/ember-cli-async-button/teams","hooks_url":"https://api.github.com/repos/dockyard/ember-cli-async-button/hooks","issue_events_url":"https://api.github.com/repos/dockyard/ember-cli-async-button/issues/events{/number}","events_url":"https://api.github.com/repos/dockyard/ember-cli-async-button/events","assignees_url":"https://api.github.com/repos/dockyard/ember-cli-async-button/assignees{/user}","branches_url":"https://api.github.com/repos/dockyard/ember-cli-async-button/branches{/branch}","tags_url":"https://api.github.com/repos/dockyard/ember-cli-async-button/tags","blobs_url":"https://api.github.com/repos/dockyard/ember-cli-async-button/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dockyard/ember-cli-async-button/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dockyard/ember-cli-async-button/git/refs{/sha}","trees_url":"https://api.github.com/repos/dockyard/ember-cli-async-button/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dockyard/ember-cli-async-button/statuses/{sha}","languages_url":"https://api.github.com/repos/dockyard/ember-cli-async-button/languages","stargazers_url":"https://api.github.com/repos/dockyard/ember-cli-async-button/stargazers","contributors_url":"https://api.github.com/repos/dockyard/ember-cli-async-button/contributors","subscribers_url":"https://api.github.com/repos/dockyard/ember-cli-async-button/subscribers","subscription_url":"https://api.github.com/repos/dockyard/ember-cli-async-button/subscription","commits_url":"https://api.github.com/repos/dockyard/ember-cli-async-button/commits{/sha}","git_commits_url":"https://api.github.com/repos/dockyard/ember-cli-async-button/git/commits{/sha}","comments_url":"https://api.github.com/repos/dockyard/ember-cli-async-button/comments{/number}","issue_comment_url":"https://api.github.com/repos/dockyard/ember-cli-async-button/issues/comments/{number}","contents_url":"https://api.github.com/repos/dockyard/ember-cli-async-button/contents/{+path}","compare_url":"https://api.github.com/repos/dockyard/ember-cli-async-button/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dockyard/ember-cli-async-button/merges","archive_url":"https://api.github.com/repos/dockyard/ember-cli-async-button/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dockyard/ember-cli-async-button/downloads","issues_url":"https://api.github.com/repos/dockyard/ember-cli-async-button/issues{/number}","pulls_url":"https://api.github.com/repos/dockyard/ember-cli-async-button/pulls{/number}","milestones_url":"https://api.github.com/repos/dockyard/ember-cli-async-button/milestones{/number}","notifications_url":"https://api.github.com/repos/dockyard/ember-cli-async-button/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dockyard/ember-cli-async-button/labels{/name}","releases_url":"https://api.github.com/repos/dockyard/ember-cli-async-button/releases{/id}","created_at":"2014-06-28T22:50:26Z","updated_at":"2014-07-08T09:25:30Z","pushed_at":"2014-07-10T12:46:24Z","git_url":"git://github.com/dockyard/ember-cli-async-button.git","ssh_url":"git@github.com:dockyard/ember-cli-async-button.git","clone_url":"https://github.com/dockyard/ember-cli-async-button.git","svn_url":"https://github.com/dockyard/ember-cli-async-button","homepage":"","size":152,"stargazers_count":27,"watchers_count":27,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dockyard/ember-cli-async-button/pulls/3"},"html":{"href":"https://github.com/dockyard/ember-cli-async-button/pull/3"},"issue":{"href":"https://api.github.com/repos/dockyard/ember-cli-async-button/issues/3"},"comments":{"href":"https://api.github.com/repos/dockyard/ember-cli-async-button/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/dockyard/ember-cli-async-button/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/dockyard/ember-cli-async-button/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/dockyard/ember-cli-async-button/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/dockyard/ember-cli-async-button/statuses/0d95d098414ae00a856ab9c660cbed280170b783"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":7,"deletions":1,"changed_files":1}}