GitHub PullRequestReviewCommentEvent at 2014-11-26 14:12:02
Repository: neovim
Actor: fwalch
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/neovim/neovim/pulls/comments/20936408","id":20936408,"diff_hunk":"@@ -1,5 +1,5 @@\n-#ifndef NVIM_OS_UNIX_DEFS_H\n-#define NVIM_OS_UNIX_DEFS_H\n+#ifndef NVIM_OS_UNIX_DEFS_LEGACY_H","path":"src/nvim/os_unix_defs.h","position":3,"original_position":3,"commit_id":"c4a0067be43b971ff11a4ddd1c9ab027a9f913ee","original_commit_id":"c4a0067be43b971ff11a4ddd1c9ab027a9f913ee","user":{"login":"fwalch","id":339435,"avatar_url":"https://avatars.githubusercontent.com/u/339435?v=3","gravatar_id":"","url":"https://api.github.com/users/fwalch","html_url":"https://github.com/fwalch","followers_url":"https://api.github.com/users/fwalch/followers","following_url":"https://api.github.com/users/fwalch/following{/other_user}","gists_url":"https://api.github.com/users/fwalch/gists{/gist_id}","starred_url":"https://api.github.com/users/fwalch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fwalch/subscriptions","organizations_url":"https://api.github.com/users/fwalch/orgs","repos_url":"https://api.github.com/users/fwalch/repos","events_url":"https://api.github.com/users/fwalch/events{/privacy}","received_events_url":"https://api.github.com/users/fwalch/received_events","type":"User","site_admin":false},"body":"`src/nvim/os_unix_defs.h` and `src/nvim/os/unix_defs.h` would have the same header guards, and this seemed to be the easiest solution... I'm not too happy about it, though.","created_at":"2014-11-26T14:12:02Z","updated_at":"2014-11-26T14:12:02Z","html_url":"https://github.com/neovim/neovim/pull/1493#discussion_r20936408","pull_request_url":"https://api.github.com/repos/neovim/neovim/pulls/1493","_links":{"self":{"href":"https://api.github.com/repos/neovim/neovim/pulls/comments/20936408"},"html":{"href":"https://github.com/neovim/neovim/pull/1493#discussion_r20936408"},"pull_request":{"href":"https://api.github.com/repos/neovim/neovim/pulls/1493"}}},"pull_request":{"url":"https://api.github.com/repos/neovim/neovim/pulls/1493","id":24671405,"html_url":"https://github.com/neovim/neovim/pull/1493","diff_url":"https://github.com/neovim/neovim/pull/1493.diff","patch_url":"https://github.com/neovim/neovim/pull/1493.patch","issue_url":"https://api.github.com/repos/neovim/neovim/issues/1493","number":1493,"state":"open","locked":false,"title":"[RFC] Linting: Integrate in CMake, enable by default.","user":{"login":"fwalch","id":339435,"avatar_url":"https://avatars.githubusercontent.com/u/339435?v=3","gravatar_id":"","url":"https://api.github.com/users/fwalch","html_url":"https://github.com/fwalch","followers_url":"https://api.github.com/users/fwalch/followers","following_url":"https://api.github.com/users/fwalch/following{/other_user}","gists_url":"https://api.github.com/users/fwalch/gists{/gist_id}","starred_url":"https://api.github.com/users/fwalch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fwalch/subscriptions","organizations_url":"https://api.github.com/users/fwalch/orgs","repos_url":"https://api.github.com/users/fwalch/repos","events_url":"https://api.github.com/users/fwalch/events{/privacy}","received_events_url":"https://api.github.com/users/fwalch/received_events","type":"User","site_admin":false},"body":"Similar to #1488, only for clint. There's a pretty long list of files in `RunLint.cmake` that doesn't really belong there (should be passed by caller, I think), so `[WIP]` for now.\r\n\r\nThis currently shows are a few lint issues with files in `src/nvim/os`:\r\n\r\n```\r\n(multiple files) #ifndef header guard has wrong style, please use: NVIM_OS_UNIX_DEFS_H\r\n/home/florian/Projects/neovim/src/nvim/os/users.c:55:  Consider using getpwuid_r(...) instead of getpwuid(...) for improved thread safety.\r\n/home/florian/Projects/neovim/src/nvim/os/fs_defs.h:17:  Missing space before {\r\n```","created_at":"2014-11-19T07:59:56Z","updated_at":"2014-11-26T14:12:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f5b5654d5224a265a99e242fde8a3c045ba4a203","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/neovim/neovim/pulls/1493/commits","review_comments_url":"https://api.github.com/repos/neovim/neovim/pulls/1493/comments","review_comment_url":"https://api.github.com/repos/neovim/neovim/pulls/comments/{number}","comments_url":"https://api.github.com/repos/neovim/neovim/issues/1493/comments","statuses_url":"https://api.github.com/repos/neovim/neovim/statuses/c4a0067be43b971ff11a4ddd1c9ab027a9f913ee","head":{"label":"fwalch:make-lint","ref":"make-lint","sha":"c4a0067be43b971ff11a4ddd1c9ab027a9f913ee","user":{"login":"fwalch","id":339435,"avatar_url":"https://avatars.githubusercontent.com/u/339435?v=3","gravatar_id":"","url":"https://api.github.com/users/fwalch","html_url":"https://github.com/fwalch","followers_url":"https://api.github.com/users/fwalch/followers","following_url":"https://api.github.com/users/fwalch/following{/other_user}","gists_url":"https://api.github.com/users/fwalch/gists{/gist_id}","starred_url":"https://api.github.com/users/fwalch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fwalch/subscriptions","organizations_url":"https://api.github.com/users/fwalch/orgs","repos_url":"https://api.github.com/users/fwalch/repos","events_url":"https://api.github.com/users/fwalch/events{/privacy}","received_events_url":"https://api.github.com/users/fwalch/received_events","type":"User","site_admin":false},"repo":{"id":20288605,"name":"neovim","full_name":"fwalch/neovim","owner":{"login":"fwalch","id":339435,"avatar_url":"https://avatars.githubusercontent.com/u/339435?v=3","gravatar_id":"","url":"https://api.github.com/users/fwalch","html_url":"https://github.com/fwalch","followers_url":"https://api.github.com/users/fwalch/followers","following_url":"https://api.github.com/users/fwalch/following{/other_user}","gists_url":"https://api.github.com/users/fwalch/gists{/gist_id}","starred_url":"https://api.github.com/users/fwalch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fwalch/subscriptions","organizations_url":"https://api.github.com/users/fwalch/orgs","repos_url":"https://api.github.com/users/fwalch/repos","events_url":"https://api.github.com/users/fwalch/events{/privacy}","received_events_url":"https://api.github.com/users/fwalch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fwalch/neovim","description":"vim's rebirth for the 21st century","fork":true,"url":"https://api.github.com/repos/fwalch/neovim","forks_url":"https://api.github.com/repos/fwalch/neovim/forks","keys_url":"https://api.github.com/repos/fwalch/neovim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fwalch/neovim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fwalch/neovim/teams","hooks_url":"https://api.github.com/repos/fwalch/neovim/hooks","issue_events_url":"https://api.github.com/repos/fwalch/neovim/issues/events{/number}","events_url":"https://api.github.com/repos/fwalch/neovim/events","assignees_url":"https://api.github.com/repos/fwalch/neovim/assignees{/user}","branches_url":"https://api.github.com/repos/fwalch/neovim/branches{/branch}","tags_url":"https://api.github.com/repos/fwalch/neovim/tags","blobs_url":"https://api.github.com/repos/fwalch/neovim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fwalch/neovim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fwalch/neovim/git/refs{/sha}","trees_url":"https://api.github.com/repos/fwalch/neovim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fwalch/neovim/statuses/{sha}","languages_url":"https://api.github.com/repos/fwalch/neovim/languages","stargazers_url":"https://api.github.com/repos/fwalch/neovim/stargazers","contributors_url":"https://api.github.com/repos/fwalch/neovim/contributors","subscribers_url":"https://api.github.com/repos/fwalch/neovim/subscribers","subscription_url":"https://api.github.com/repos/fwalch/neovim/subscription","commits_url":"https://api.github.com/repos/fwalch/neovim/commits{/sha}","git_commits_url":"https://api.github.com/repos/fwalch/neovim/git/commits{/sha}","comments_url":"https://api.github.com/repos/fwalch/neovim/comments{/number}","issue_comment_url":"https://api.github.com/repos/fwalch/neovim/issues/comments/{number}","contents_url":"https://api.github.com/repos/fwalch/neovim/contents/{+path}","compare_url":"https://api.github.com/repos/fwalch/neovim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fwalch/neovim/merges","archive_url":"https://api.github.com/repos/fwalch/neovim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fwalch/neovim/downloads","issues_url":"https://api.github.com/repos/fwalch/neovim/issues{/number}","pulls_url":"https://api.github.com/repos/fwalch/neovim/pulls{/number}","milestones_url":"https://api.github.com/repos/fwalch/neovim/milestones{/number}","notifications_url":"https://api.github.com/repos/fwalch/neovim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fwalch/neovim/labels{/name}","releases_url":"https://api.github.com/repos/fwalch/neovim/releases{/id}","created_at":"2014-05-29T09:18:20Z","updated_at":"2014-11-21T17:34:24Z","pushed_at":"2014-11-26T14:05:43Z","git_url":"git://github.com/fwalch/neovim.git","ssh_url":"git@github.com:fwalch/neovim.git","clone_url":"https://github.com/fwalch/neovim.git","svn_url":"https://github.com/fwalch/neovim","homepage":"http://neovim.org/","size":33471,"stargazers_count":0,"watchers_count":0,"language":"VimL","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"base":{"label":"neovim:master","ref":"master","sha":"f3e7314952723fdeeee1e0b762a27b4cfab7c7f0","user":{"login":"neovim","id":6471485,"avatar_url":"https://avatars.githubusercontent.com/u/6471485?v=3","gravatar_id":"","url":"https://api.github.com/users/neovim","html_url":"https://github.com/neovim","followers_url":"https://api.github.com/users/neovim/followers","following_url":"https://api.github.com/users/neovim/following{/other_user}","gists_url":"https://api.github.com/users/neovim/gists{/gist_id}","starred_url":"https://api.github.com/users/neovim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neovim/subscriptions","organizations_url":"https://api.github.com/users/neovim/orgs","repos_url":"https://api.github.com/users/neovim/repos","events_url":"https://api.github.com/users/neovim/events{/privacy}","received_events_url":"https://api.github.com/users/neovim/received_events","type":"Organization","site_admin":false},"repo":{"id":16408992,"name":"neovim","full_name":"neovim/neovim","owner":{"login":"neovim","id":6471485,"avatar_url":"https://avatars.githubusercontent.com/u/6471485?v=3","gravatar_id":"","url":"https://api.github.com/users/neovim","html_url":"https://github.com/neovim","followers_url":"https://api.github.com/users/neovim/followers","following_url":"https://api.github.com/users/neovim/following{/other_user}","gists_url":"https://api.github.com/users/neovim/gists{/gist_id}","starred_url":"https://api.github.com/users/neovim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neovim/subscriptions","organizations_url":"https://api.github.com/users/neovim/orgs","repos_url":"https://api.github.com/users/neovim/repos","events_url":"https://api.github.com/users/neovim/events{/privacy}","received_events_url":"https://api.github.com/users/neovim/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neovim/neovim","description":"vim out of the box","fork":false,"url":"https://api.github.com/repos/neovim/neovim","forks_url":"https://api.github.com/repos/neovim/neovim/forks","keys_url":"https://api.github.com/repos/neovim/neovim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neovim/neovim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neovim/neovim/teams","hooks_url":"https://api.github.com/repos/neovim/neovim/hooks","issue_events_url":"https://api.github.com/repos/neovim/neovim/issues/events{/number}","events_url":"https://api.github.com/repos/neovim/neovim/events","assignees_url":"https://api.github.com/repos/neovim/neovim/assignees{/user}","branches_url":"https://api.github.com/repos/neovim/neovim/branches{/branch}","tags_url":"https://api.github.com/repos/neovim/neovim/tags","blobs_url":"https://api.github.com/repos/neovim/neovim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neovim/neovim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neovim/neovim/git/refs{/sha}","trees_url":"https://api.github.com/repos/neovim/neovim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neovim/neovim/statuses/{sha}","languages_url":"https://api.github.com/repos/neovim/neovim/languages","stargazers_url":"https://api.github.com/repos/neovim/neovim/stargazers","contributors_url":"https://api.github.com/repos/neovim/neovim/contributors","subscribers_url":"https://api.github.com/repos/neovim/neovim/subscribers","subscription_url":"https://api.github.com/repos/neovim/neovim/subscription","commits_url":"https://api.github.com/repos/neovim/neovim/commits{/sha}","git_commits_url":"https://api.github.com/repos/neovim/neovim/git/commits{/sha}","comments_url":"https://api.github.com/repos/neovim/neovim/comments{/number}","issue_comment_url":"https://api.github.com/repos/neovim/neovim/issues/comments/{number}","contents_url":"https://api.github.com/repos/neovim/neovim/contents/{+path}","compare_url":"https://api.github.com/repos/neovim/neovim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neovim/neovim/merges","archive_url":"https://api.github.com/repos/neovim/neovim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neovim/neovim/downloads","issues_url":"https://api.github.com/repos/neovim/neovim/issues{/number}","pulls_url":"https://api.github.com/repos/neovim/neovim/pulls{/number}","milestones_url":"https://api.github.com/repos/neovim/neovim/milestones{/number}","notifications_url":"https://api.github.com/repos/neovim/neovim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neovim/neovim/labels{/name}","releases_url":"https://api.github.com/repos/neovim/neovim/releases{/id}","created_at":"2014-01-31T13:39:22Z","updated_at":"2014-11-26T14:05:31Z","pushed_at":"2014-11-26T14:04:34Z","git_url":"git://github.com/neovim/neovim.git","ssh_url":"git@github.com:neovim/neovim.git","clone_url":"https://github.com/neovim/neovim.git","svn_url":"https://github.com/neovim/neovim","homepage":"http://neovim.org/","size":65968,"stargazers_count":10844,"watchers_count":10844,"language":"VimL","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":704,"mirror_url":null,"open_issues_count":290,"forks":704,"open_issues":290,"watchers":10844,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/neovim/neovim/pulls/1493"},"html":{"href":"https://github.com/neovim/neovim/pull/1493"},"issue":{"href":"https://api.github.com/repos/neovim/neovim/issues/1493"},"comments":{"href":"https://api.github.com/repos/neovim/neovim/issues/1493/comments"},"review_comments":{"href":"https://api.github.com/repos/neovim/neovim/pulls/1493/comments"},"review_comment":{"href":"https://api.github.com/repos/neovim/neovim/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/neovim/neovim/pulls/1493/commits"},"statuses":{"href":"https://api.github.com/repos/neovim/neovim/statuses/c4a0067be43b971ff11a4ddd1c9ab027a9f913ee"}}}}