GitHub PullRequestReviewCommentEvent at 2014-12-18 04:35:15
Repository: rapidfire
Actor: iffyuva
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/code-mancers/rapidfire/pulls/comments/22023309","id":22023309,"diff_hunk":"@@ -19,10 +19,10 @@ def save!(options = {})\n           # in case of checkboxes, values are submitted as an array of\n           # strings. we will store answers as one big string separated\n           # by delimiter.\n+          text = text.values if text.is_a?(Hash)","path":"app/services/rapidfire/answer_group_builder.rb","position":4,"original_position":4,"commit_id":"30b66a351a657441b749576cce7b07f8fd7263b2","original_commit_id":"30b66a351a657441b749576cce7b07f8fd7263b2","user":{"login":"iffyuva","id":1108398,"avatar_url":"https://avatars.githubusercontent.com/u/1108398?v=3","gravatar_id":"","url":"https://api.github.com/users/iffyuva","html_url":"https://github.com/iffyuva","followers_url":"https://api.github.com/users/iffyuva/followers","following_url":"https://api.github.com/users/iffyuva/following{/other_user}","gists_url":"https://api.github.com/users/iffyuva/gists{/gist_id}","starred_url":"https://api.github.com/users/iffyuva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iffyuva/subscriptions","organizations_url":"https://api.github.com/users/iffyuva/orgs","repos_url":"https://api.github.com/users/iffyuva/repos","events_url":"https://api.github.com/users/iffyuva/events{/privacy}","received_events_url":"https://api.github.com/users/iffyuva/received_events","type":"User","site_admin":false},"body":"@sandrew can you explain the scenario where we get text as hash? thanks.","created_at":"2014-12-18T04:35:15Z","updated_at":"2014-12-18T04:35:15Z","html_url":"https://github.com/code-mancers/rapidfire/pull/39#discussion_r22023309","pull_request_url":"https://api.github.com/repos/code-mancers/rapidfire/pulls/39","_links":{"self":{"href":"https://api.github.com/repos/code-mancers/rapidfire/pulls/comments/22023309"},"html":{"href":"https://github.com/code-mancers/rapidfire/pull/39#discussion_r22023309"},"pull_request":{"href":"https://api.github.com/repos/code-mancers/rapidfire/pulls/39"}}},"pull_request":{"url":"https://api.github.com/repos/code-mancers/rapidfire/pulls/39","id":26217119,"html_url":"https://github.com/code-mancers/rapidfire/pull/39","diff_url":"https://github.com/code-mancers/rapidfire/pull/39.diff","patch_url":"https://github.com/code-mancers/rapidfire/pull/39.patch","issue_url":"https://api.github.com/repos/code-mancers/rapidfire/issues/39","number":39,"state":"open","locked":false,"title":"Proper label and input ids for checkbox and radios with non-sanitized values","user":{"login":"sandrew","id":198381,"avatar_url":"https://avatars.githubusercontent.com/u/198381?v=3","gravatar_id":"","url":"https://api.github.com/users/sandrew","html_url":"https://github.com/sandrew","followers_url":"https://api.github.com/users/sandrew/followers","following_url":"https://api.github.com/users/sandrew/following{/other_user}","gists_url":"https://api.github.com/users/sandrew/gists{/gist_id}","starred_url":"https://api.github.com/users/sandrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sandrew/subscriptions","organizations_url":"https://api.github.com/users/sandrew/orgs","repos_url":"https://api.github.com/users/sandrew/repos","events_url":"https://api.github.com/users/sandrew/events{/privacy}","received_events_url":"https://api.github.com/users/sandrew/received_events","type":"User","site_admin":false},"body":"Before now label ids and input ids for checkbox and radios inputs were messed of unsanitized option values and sanitized values, that was a nightmare if you had some punctuation or non-latin symbols in options.\r\nThis commit fixes it.\r\nIt looks a little tricky, but I don't see a more simple and cleaner way without including something like `simple_form`.","created_at":"2014-12-17T11:24:48Z","updated_at":"2014-12-18T04:35:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"592e33e27740c30dece236ae94986610d6ab0079","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/code-mancers/rapidfire/pulls/39/commits","review_comments_url":"https://api.github.com/repos/code-mancers/rapidfire/pulls/39/comments","review_comment_url":"https://api.github.com/repos/code-mancers/rapidfire/pulls/comments/{number}","comments_url":"https://api.github.com/repos/code-mancers/rapidfire/issues/39/comments","statuses_url":"https://api.github.com/repos/code-mancers/rapidfire/statuses/30b66a351a657441b749576cce7b07f8fd7263b2","head":{"label":"sandrew:fix/proper-checkbox-radio-button-labels","ref":"fix/proper-checkbox-radio-button-labels","sha":"30b66a351a657441b749576cce7b07f8fd7263b2","user":{"login":"sandrew","id":198381,"avatar_url":"https://avatars.githubusercontent.com/u/198381?v=3","gravatar_id":"","url":"https://api.github.com/users/sandrew","html_url":"https://github.com/sandrew","followers_url":"https://api.github.com/users/sandrew/followers","following_url":"https://api.github.com/users/sandrew/following{/other_user}","gists_url":"https://api.github.com/users/sandrew/gists{/gist_id}","starred_url":"https://api.github.com/users/sandrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sandrew/subscriptions","organizations_url":"https://api.github.com/users/sandrew/orgs","repos_url":"https://api.github.com/users/sandrew/repos","events_url":"https://api.github.com/users/sandrew/events{/privacy}","received_events_url":"https://api.github.com/users/sandrew/received_events","type":"User","site_admin":false},"repo":{"id":28096894,"name":"rapidfire","full_name":"sandrew/rapidfire","owner":{"login":"sandrew","id":198381,"avatar_url":"https://avatars.githubusercontent.com/u/198381?v=3","gravatar_id":"","url":"https://api.github.com/users/sandrew","html_url":"https://github.com/sandrew","followers_url":"https://api.github.com/users/sandrew/followers","following_url":"https://api.github.com/users/sandrew/following{/other_user}","gists_url":"https://api.github.com/users/sandrew/gists{/gist_id}","starred_url":"https://api.github.com/users/sandrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sandrew/subscriptions","organizations_url":"https://api.github.com/users/sandrew/orgs","repos_url":"https://api.github.com/users/sandrew/repos","events_url":"https://api.github.com/users/sandrew/events{/privacy}","received_events_url":"https://api.github.com/users/sandrew/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sandrew/rapidfire","description":"Making Dynamic Surveys should be easy!","fork":true,"url":"https://api.github.com/repos/sandrew/rapidfire","forks_url":"https://api.github.com/repos/sandrew/rapidfire/forks","keys_url":"https://api.github.com/repos/sandrew/rapidfire/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sandrew/rapidfire/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sandrew/rapidfire/teams","hooks_url":"https://api.github.com/repos/sandrew/rapidfire/hooks","issue_events_url":"https://api.github.com/repos/sandrew/rapidfire/issues/events{/number}","events_url":"https://api.github.com/repos/sandrew/rapidfire/events","assignees_url":"https://api.github.com/repos/sandrew/rapidfire/assignees{/user}","branches_url":"https://api.github.com/repos/sandrew/rapidfire/branches{/branch}","tags_url":"https://api.github.com/repos/sandrew/rapidfire/tags","blobs_url":"https://api.github.com/repos/sandrew/rapidfire/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sandrew/rapidfire/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sandrew/rapidfire/git/refs{/sha}","trees_url":"https://api.github.com/repos/sandrew/rapidfire/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sandrew/rapidfire/statuses/{sha}","languages_url":"https://api.github.com/repos/sandrew/rapidfire/languages","stargazers_url":"https://api.github.com/repos/sandrew/rapidfire/stargazers","contributors_url":"https://api.github.com/repos/sandrew/rapidfire/contributors","subscribers_url":"https://api.github.com/repos/sandrew/rapidfire/subscribers","subscription_url":"https://api.github.com/repos/sandrew/rapidfire/subscription","commits_url":"https://api.github.com/repos/sandrew/rapidfire/commits{/sha}","git_commits_url":"https://api.github.com/repos/sandrew/rapidfire/git/commits{/sha}","comments_url":"https://api.github.com/repos/sandrew/rapidfire/comments{/number}","issue_comment_url":"https://api.github.com/repos/sandrew/rapidfire/issues/comments/{number}","contents_url":"https://api.github.com/repos/sandrew/rapidfire/contents/{+path}","compare_url":"https://api.github.com/repos/sandrew/rapidfire/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sandrew/rapidfire/merges","archive_url":"https://api.github.com/repos/sandrew/rapidfire/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sandrew/rapidfire/downloads","issues_url":"https://api.github.com/repos/sandrew/rapidfire/issues{/number}","pulls_url":"https://api.github.com/repos/sandrew/rapidfire/pulls{/number}","milestones_url":"https://api.github.com/repos/sandrew/rapidfire/milestones{/number}","notifications_url":"https://api.github.com/repos/sandrew/rapidfire/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sandrew/rapidfire/labels{/name}","releases_url":"https://api.github.com/repos/sandrew/rapidfire/releases{/id}","created_at":"2014-12-16T16:59:14Z","updated_at":"2014-12-17T11:57:28Z","pushed_at":"2014-12-17T11:57:28Z","git_url":"git://github.com/sandrew/rapidfire.git","ssh_url":"git@github.com:sandrew/rapidfire.git","clone_url":"https://github.com/sandrew/rapidfire.git","svn_url":"https://github.com/sandrew/rapidfire","homepage":"","size":329,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"code-mancers:master","ref":"master","sha":"69b58799cf3c6271b9970632a963d62e67a99dfb","user":{"login":"code-mancers","id":1137275,"avatar_url":"https://avatars.githubusercontent.com/u/1137275?v=3","gravatar_id":"","url":"https://api.github.com/users/code-mancers","html_url":"https://github.com/code-mancers","followers_url":"https://api.github.com/users/code-mancers/followers","following_url":"https://api.github.com/users/code-mancers/following{/other_user}","gists_url":"https://api.github.com/users/code-mancers/gists{/gist_id}","starred_url":"https://api.github.com/users/code-mancers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/code-mancers/subscriptions","organizations_url":"https://api.github.com/users/code-mancers/orgs","repos_url":"https://api.github.com/users/code-mancers/repos","events_url":"https://api.github.com/users/code-mancers/events{/privacy}","received_events_url":"https://api.github.com/users/code-mancers/received_events","type":"Organization","site_admin":false},"repo":{"id":9489171,"name":"rapidfire","full_name":"code-mancers/rapidfire","owner":{"login":"code-mancers","id":1137275,"avatar_url":"https://avatars.githubusercontent.com/u/1137275?v=3","gravatar_id":"","url":"https://api.github.com/users/code-mancers","html_url":"https://github.com/code-mancers","followers_url":"https://api.github.com/users/code-mancers/followers","following_url":"https://api.github.com/users/code-mancers/following{/other_user}","gists_url":"https://api.github.com/users/code-mancers/gists{/gist_id}","starred_url":"https://api.github.com/users/code-mancers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/code-mancers/subscriptions","organizations_url":"https://api.github.com/users/code-mancers/orgs","repos_url":"https://api.github.com/users/code-mancers/repos","events_url":"https://api.github.com/users/code-mancers/events{/privacy}","received_events_url":"https://api.github.com/users/code-mancers/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/code-mancers/rapidfire","description":"Making Dynamic Surveys should be easy!","fork":false,"url":"https://api.github.com/repos/code-mancers/rapidfire","forks_url":"https://api.github.com/repos/code-mancers/rapidfire/forks","keys_url":"https://api.github.com/repos/code-mancers/rapidfire/keys{/key_id}","collaborators_url":"https://api.github.com/repos/code-mancers/rapidfire/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/code-mancers/rapidfire/teams","hooks_url":"https://api.github.com/repos/code-mancers/rapidfire/hooks","issue_events_url":"https://api.github.com/repos/code-mancers/rapidfire/issues/events{/number}","events_url":"https://api.github.com/repos/code-mancers/rapidfire/events","assignees_url":"https://api.github.com/repos/code-mancers/rapidfire/assignees{/user}","branches_url":"https://api.github.com/repos/code-mancers/rapidfire/branches{/branch}","tags_url":"https://api.github.com/repos/code-mancers/rapidfire/tags","blobs_url":"https://api.github.com/repos/code-mancers/rapidfire/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/code-mancers/rapidfire/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/code-mancers/rapidfire/git/refs{/sha}","trees_url":"https://api.github.com/repos/code-mancers/rapidfire/git/trees{/sha}","statuses_url":"https://api.github.com/repos/code-mancers/rapidfire/statuses/{sha}","languages_url":"https://api.github.com/repos/code-mancers/rapidfire/languages","stargazers_url":"https://api.github.com/repos/code-mancers/rapidfire/stargazers","contributors_url":"https://api.github.com/repos/code-mancers/rapidfire/contributors","subscribers_url":"https://api.github.com/repos/code-mancers/rapidfire/subscribers","subscription_url":"https://api.github.com/repos/code-mancers/rapidfire/subscription","commits_url":"https://api.github.com/repos/code-mancers/rapidfire/commits{/sha}","git_commits_url":"https://api.github.com/repos/code-mancers/rapidfire/git/commits{/sha}","comments_url":"https://api.github.com/repos/code-mancers/rapidfire/comments{/number}","issue_comment_url":"https://api.github.com/repos/code-mancers/rapidfire/issues/comments/{number}","contents_url":"https://api.github.com/repos/code-mancers/rapidfire/contents/{+path}","compare_url":"https://api.github.com/repos/code-mancers/rapidfire/compare/{base}...{head}","merges_url":"https://api.github.com/repos/code-mancers/rapidfire/merges","archive_url":"https://api.github.com/repos/code-mancers/rapidfire/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/code-mancers/rapidfire/downloads","issues_url":"https://api.github.com/repos/code-mancers/rapidfire/issues{/number}","pulls_url":"https://api.github.com/repos/code-mancers/rapidfire/pulls{/number}","milestones_url":"https://api.github.com/repos/code-mancers/rapidfire/milestones{/number}","notifications_url":"https://api.github.com/repos/code-mancers/rapidfire/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/code-mancers/rapidfire/labels{/name}","releases_url":"https://api.github.com/repos/code-mancers/rapidfire/releases{/id}","created_at":"2013-04-17T04:29:28Z","updated_at":"2014-12-15T18:18:41Z","pushed_at":"2014-11-12T15:51:03Z","git_url":"git://github.com/code-mancers/rapidfire.git","ssh_url":"git@github.com:code-mancers/rapidfire.git","clone_url":"https://github.com/code-mancers/rapidfire.git","svn_url":"https://github.com/code-mancers/rapidfire","homepage":"","size":936,"stargazers_count":109,"watchers_count":109,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":36,"mirror_url":null,"open_issues_count":17,"forks":36,"open_issues":17,"watchers":109,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/code-mancers/rapidfire/pulls/39"},"html":{"href":"https://github.com/code-mancers/rapidfire/pull/39"},"issue":{"href":"https://api.github.com/repos/code-mancers/rapidfire/issues/39"},"comments":{"href":"https://api.github.com/repos/code-mancers/rapidfire/issues/39/comments"},"review_comments":{"href":"https://api.github.com/repos/code-mancers/rapidfire/pulls/39/comments"},"review_comment":{"href":"https://api.github.com/repos/code-mancers/rapidfire/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/code-mancers/rapidfire/pulls/39/commits"},"statuses":{"href":"https://api.github.com/repos/code-mancers/rapidfire/statuses/30b66a351a657441b749576cce7b07f8fd7263b2"}}}}