GitHub PullRequestEvent at 2014-02-20 19:41:51
Repository: cmssw
Actor: wmtan
Payload: {"action":"closed","number":2519,"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/2519","id":12665540,"html_url":"https://github.com/cms-sw/cmssw/pull/2519","diff_url":"https://github.com/cms-sw/cmssw/pull/2519.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/2519.patch","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/2519","number":2519,"state":"closed","title":"Don't try to update empty process history ID","user":{"login":"wmtan","id":4268350,"avatar_url":"https://gravatar.com/avatar/7aedf822be990e83c1a6fe96cf5b0d13?d=https%3A%2F%2Fidenticons.github.com%2F08837289937c64d3dd988079d52de36b.png&r=x","gravatar_id":"7aedf822be990e83c1a6fe96cf5b0d13","url":"https://api.github.com/users/wmtan","html_url":"https://github.com/wmtan","followers_url":"https://api.github.com/users/wmtan/followers","following_url":"https://api.github.com/users/wmtan/following{/other_user}","gists_url":"https://api.github.com/users/wmtan/gists{/gist_id}","starred_url":"https://api.github.com/users/wmtan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmtan/subscriptions","organizations_url":"https://api.github.com/users/wmtan/orgs","repos_url":"https://api.github.com/users/wmtan/repos","events_url":"https://api.github.com/users/wmtan/events{/privacy}","received_events_url":"https://api.github.com/users/wmtan/received_events","type":"User","site_admin":false},"body":"This is a fix for a bug that has actually been in place since CMSSW_3_0_0, but did not show any symptoms until CMSSW_6_2_0.\r\nThe problem was hit by Erik Butz when he tried to read a file written with CMSSW_3_2_5.\r\nWhen an old format file is read, the process history ID's may change, and must then be converted to new values. However, prior to release 3_8_0, process history ID's existed only for events, and not for runs and lumis. The bug is that, when a file written before release 3_8_0 is read, the code attempts to convert the non-existent (default constructed) process history ID's of runs and lumis to the new values. These values are never used, so this is almost harmless, except for some unnecessary code running.\r\nHowever, to do the conversion, the process history ID must be looked up in a map. An assert occurs if the ID is not found. Apparently, prior to 6_2_0, the default ID was found in the map. Beginning in 6_2_X , it is not.\r\nThe fix is simply that if a file is read that predates the presence of process history ID's in runs and lumis,\r\ndon't try to convert the non-existent ID's, which are not used anyway.","created_at":"2014-02-18T19:07:37Z","updated_at":"2014-02-20T19:41:50Z","closed_at":"2014-02-20T19:41:50Z","merged_at":null,"merge_commit_sha":"6ade15c0b7bdb4817563ff119b13ca658e9d5880","assignee":null,"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/38","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/38/labels","id":570902,"number":38,"title":"Next CMSSW_7_0_X release","description":"","creator":{"login":"ktf","id":10544,"avatar_url":"https://gravatar.com/avatar/7a6c8f49981d093b41b365a4b522378d?d=https%3A%2F%2Fidenticons.github.com%2Fcbbb18efb6e9789c7b1476058c231bd5.png&r=x","gravatar_id":"7a6c8f49981d093b41b365a4b522378d","url":"https://api.github.com/users/ktf","html_url":"https://github.com/ktf","followers_url":"https://api.github.com/users/ktf/followers","following_url":"https://api.github.com/users/ktf/following{/other_user}","gists_url":"https://api.github.com/users/ktf/gists{/gist_id}","starred_url":"https://api.github.com/users/ktf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ktf/subscriptions","organizations_url":"https://api.github.com/users/ktf/orgs","repos_url":"https://api.github.com/users/ktf/repos","events_url":"https://api.github.com/users/ktf/events{/privacy}","received_events_url":"https://api.github.com/users/ktf/received_events","type":"User","site_admin":false},"open_issues":15,"closed_issues":9,"state":"open","created_at":"2014-02-16T18:44:49Z","updated_at":"2014-02-20T19:41:50Z","due_on":"2014-02-19T08:00:00Z"},"commits_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/2519/commits","review_comments_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/2519/comments","review_comment_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/{number}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/2519/comments","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/c3c8949314cc00ef23dddca8ba3b75967d1b1857","head":{"label":"wmtan:DoNotMapEmptyProcessHistoryID70X","ref":"DoNotMapEmptyProcessHistoryID70X","sha":"c3c8949314cc00ef23dddca8ba3b75967d1b1857","user":{"login":"wmtan","id":4268350,"avatar_url":"https://gravatar.com/avatar/7aedf822be990e83c1a6fe96cf5b0d13?d=https%3A%2F%2Fidenticons.github.com%2F08837289937c64d3dd988079d52de36b.png&r=x","gravatar_id":"7aedf822be990e83c1a6fe96cf5b0d13","url":"https://api.github.com/users/wmtan","html_url":"https://github.com/wmtan","followers_url":"https://api.github.com/users/wmtan/followers","following_url":"https://api.github.com/users/wmtan/following{/other_user}","gists_url":"https://api.github.com/users/wmtan/gists{/gist_id}","starred_url":"https://api.github.com/users/wmtan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmtan/subscriptions","organizations_url":"https://api.github.com/users/wmtan/orgs","repos_url":"https://api.github.com/users/wmtan/repos","events_url":"https://api.github.com/users/wmtan/events{/privacy}","received_events_url":"https://api.github.com/users/wmtan/received_events","type":"User","site_admin":false},"repo":{"id":10977262,"name":"cmssw","full_name":"wmtan/cmssw","owner":{"login":"wmtan","id":4268350,"avatar_url":"https://gravatar.com/avatar/7aedf822be990e83c1a6fe96cf5b0d13?d=https%3A%2F%2Fidenticons.github.com%2F08837289937c64d3dd988079d52de36b.png&r=x","gravatar_id":"7aedf822be990e83c1a6fe96cf5b0d13","url":"https://api.github.com/users/wmtan","html_url":"https://github.com/wmtan","followers_url":"https://api.github.com/users/wmtan/followers","following_url":"https://api.github.com/users/wmtan/following{/other_user}","gists_url":"https://api.github.com/users/wmtan/gists{/gist_id}","starred_url":"https://api.github.com/users/wmtan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmtan/subscriptions","organizations_url":"https://api.github.com/users/wmtan/orgs","repos_url":"https://api.github.com/users/wmtan/repos","events_url":"https://api.github.com/users/wmtan/events{/privacy}","received_events_url":"https://api.github.com/users/wmtan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wmtan/cmssw","description":"CMS Offline Software","fork":true,"url":"https://api.github.com/repos/wmtan/cmssw","forks_url":"https://api.github.com/repos/wmtan/cmssw/forks","keys_url":"https://api.github.com/repos/wmtan/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wmtan/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wmtan/cmssw/teams","hooks_url":"https://api.github.com/repos/wmtan/cmssw/hooks","issue_events_url":"https://api.github.com/repos/wmtan/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/wmtan/cmssw/events","assignees_url":"https://api.github.com/repos/wmtan/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/wmtan/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/wmtan/cmssw/tags","blobs_url":"https://api.github.com/repos/wmtan/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wmtan/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wmtan/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/wmtan/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wmtan/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/wmtan/cmssw/languages","stargazers_url":"https://api.github.com/repos/wmtan/cmssw/stargazers","contributors_url":"https://api.github.com/repos/wmtan/cmssw/contributors","subscribers_url":"https://api.github.com/repos/wmtan/cmssw/subscribers","subscription_url":"https://api.github.com/repos/wmtan/cmssw/subscription","commits_url":"https://api.github.com/repos/wmtan/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/wmtan/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/wmtan/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/wmtan/cmssw/issues/comments/{number}","contents_url":"https://api.github.com/repos/wmtan/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/wmtan/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wmtan/cmssw/merges","archive_url":"https://api.github.com/repos/wmtan/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wmtan/cmssw/downloads","issues_url":"https://api.github.com/repos/wmtan/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/wmtan/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/wmtan/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/wmtan/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wmtan/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/wmtan/cmssw/releases{/id}","created_at":"2013-06-26T19:44:14Z","updated_at":"2014-02-20T19:41:50Z","pushed_at":"2014-02-19T23:47:19Z","git_url":"git://github.com/wmtan/cmssw.git","ssh_url":"git@github.com:wmtan/cmssw.git","clone_url":"https://github.com/wmtan/cmssw.git","svn_url":"https://github.com/wmtan/cmssw","homepage":null,"size":385106,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"CMSSW_7_0_X","master_branch":"CMSSW_7_0_X"}},"base":{"label":"cms-sw:CMSSW_7_0_X","ref":"CMSSW_7_0_X","sha":"a77b07a8db621336a91be9180c904df8dd23177c","user":{"login":"cms-sw","id":3863500,"avatar_url":"https://gravatar.com/avatar/d5b5dd8d1e3a16502b38562e08e0635c?d=https%3A%2F%2Fidenticons.github.com%2Fee37918964f6205f415a497a8a01996d.png&r=x","gravatar_id":"d5b5dd8d1e3a16502b38562e08e0635c","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"repo":{"id":10969551,"name":"cmssw","full_name":"cms-sw/cmssw","owner":{"login":"cms-sw","id":3863500,"avatar_url":"https://gravatar.com/avatar/d5b5dd8d1e3a16502b38562e08e0635c?d=https%3A%2F%2Fidenticons.github.com%2Fee37918964f6205f415a497a8a01996d.png&r=x","gravatar_id":"d5b5dd8d1e3a16502b38562e08e0635c","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cms-sw/cmssw","description":"CMS Offline Software","fork":false,"url":"https://api.github.com/repos/cms-sw/cmssw","forks_url":"https://api.github.com/repos/cms-sw/cmssw/forks","keys_url":"https://api.github.com/repos/cms-sw/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cms-sw/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cms-sw/cmssw/teams","hooks_url":"https://api.github.com/repos/cms-sw/cmssw/hooks","issue_events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/cms-sw/cmssw/events","assignees_url":"https://api.github.com/repos/cms-sw/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/cms-sw/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/cms-sw/cmssw/tags","blobs_url":"https://api.github.com/repos/cms-sw/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cms-sw/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cms-sw/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/cms-sw/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/cms-sw/cmssw/languages","stargazers_url":"https://api.github.com/repos/cms-sw/cmssw/stargazers","contributors_url":"https://api.github.com/repos/cms-sw/cmssw/contributors","subscribers_url":"https://api.github.com/repos/cms-sw/cmssw/subscribers","subscription_url":"https://api.github.com/repos/cms-sw/cmssw/subscription","commits_url":"https://api.github.com/repos/cms-sw/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/cms-sw/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/{number}","contents_url":"https://api.github.com/repos/cms-sw/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/cms-sw/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cms-sw/cmssw/merges","archive_url":"https://api.github.com/repos/cms-sw/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cms-sw/cmssw/downloads","issues_url":"https://api.github.com/repos/cms-sw/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/cms-sw/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/cms-sw/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/cms-sw/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cms-sw/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/cms-sw/cmssw/releases{/id}","created_at":"2013-06-26T14:09:07Z","updated_at":"2014-02-20T18:52:23Z","pushed_at":"2014-02-20T18:52:20Z","git_url":"git://github.com/cms-sw/cmssw.git","ssh_url":"git@github.com:cms-sw/cmssw.git","clone_url":"https://github.com/cms-sw/cmssw.git","svn_url":"https://github.com/cms-sw/cmssw","homepage":"cms-sw.github.io/cmssw","size":514444,"stargazers_count":71,"watchers_count":71,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":579,"mirror_url":null,"open_issues_count":110,"forks":579,"open_issues":110,"watchers":71,"default_branch":"CMSSW_7_1_X","master_branch":"CMSSW_7_1_X"}},"_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/2519"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/2519"},"issue":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/2519"},"comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/2519/comments"},"review_comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/2519/comments"},"review_comment":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/2519/commits"},"statuses":{"href":"https://api.github.com/repos/cms-sw/cmssw/statuses/c3c8949314cc00ef23dddca8ba3b75967d1b1857"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":3,"review_comments":0,"commits":1,"additions":14,"deletions":10,"changed_files":1}}