GitHub PullRequestEvent at 2014-09-18 13:49:47
Repository: toml-rs
Actor: alexcrichton
Payload: {"action":"closed","number":18,"pull_request":{"url":"https://api.github.com/repos/alexcrichton/toml-rs/pulls/18","id":21412191,"html_url":"https://github.com/alexcrichton/toml-rs/pull/18","diff_url":"https://github.com/alexcrichton/toml-rs/pull/18.diff","patch_url":"https://github.com/alexcrichton/toml-rs/pull/18.patch","issue_url":"https://api.github.com/repos/alexcrichton/toml-rs/issues/18","number":18,"state":"closed","locked":false,"title":"Update show to print an error instead of failing","user":{"login":"jroesch","id":696509,"avatar_url":"https://avatars.githubusercontent.com/u/696509?v=2","gravatar_id":"41b3f81fe12349bcfa70eff20eaeb187","url":"https://api.github.com/users/jroesch","html_url":"https://github.com/jroesch","followers_url":"https://api.github.com/users/jroesch/followers","following_url":"https://api.github.com/users/jroesch/following{/other_user}","gists_url":"https://api.github.com/users/jroesch/gists{/gist_id}","starred_url":"https://api.github.com/users/jroesch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jroesch/subscriptions","organizations_url":"https://api.github.com/users/jroesch/orgs","repos_url":"https://api.github.com/users/jroesch/repos","events_url":"https://api.github.com/users/jroesch/events{/privacy}","received_events_url":"https://api.github.com/users/jroesch/received_events","type":"User","site_admin":false},"body":"These are the changes we discussed a few weeks ago, just slipped my mind, and figured I would submit them at the same time as my other PR.\r\n\r\n I removed the use of `fail!` in the `Show` implementation. I just changed the line that was failing with a message to print said message instead.\r\n\r\nNote: These changes won't build without my other PR which removes uses of `move_iter()`.","created_at":"2014-09-18T05:03:17Z","updated_at":"2014-09-18T13:49:47Z","closed_at":"2014-09-18T13:49:47Z","merged_at":"2014-09-18T13:49:47Z","merge_commit_sha":"40fb8e87234d487cc6f50608ea08944398ba850a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/alexcrichton/toml-rs/pulls/18/commits","review_comments_url":"https://api.github.com/repos/alexcrichton/toml-rs/pulls/18/comments","review_comment_url":"https://api.github.com/repos/alexcrichton/toml-rs/pulls/comments/{number}","comments_url":"https://api.github.com/repos/alexcrichton/toml-rs/issues/18/comments","statuses_url":"https://api.github.com/repos/alexcrichton/toml-rs/statuses/ef4e8f58acf6dcb3eae9ee26069b71837195a455","head":{"label":"jroesch:failing-show","ref":"failing-show","sha":"ef4e8f58acf6dcb3eae9ee26069b71837195a455","user":{"login":"jroesch","id":696509,"avatar_url":"https://avatars.githubusercontent.com/u/696509?v=2","gravatar_id":"41b3f81fe12349bcfa70eff20eaeb187","url":"https://api.github.com/users/jroesch","html_url":"https://github.com/jroesch","followers_url":"https://api.github.com/users/jroesch/followers","following_url":"https://api.github.com/users/jroesch/following{/other_user}","gists_url":"https://api.github.com/users/jroesch/gists{/gist_id}","starred_url":"https://api.github.com/users/jroesch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jroesch/subscriptions","organizations_url":"https://api.github.com/users/jroesch/orgs","repos_url":"https://api.github.com/users/jroesch/repos","events_url":"https://api.github.com/users/jroesch/events{/privacy}","received_events_url":"https://api.github.com/users/jroesch/received_events","type":"User","site_admin":false},"repo":{"id":23374613,"name":"toml-rs","full_name":"jroesch/toml-rs","owner":{"login":"jroesch","id":696509,"avatar_url":"https://avatars.githubusercontent.com/u/696509?v=2","gravatar_id":"41b3f81fe12349bcfa70eff20eaeb187","url":"https://api.github.com/users/jroesch","html_url":"https://github.com/jroesch","followers_url":"https://api.github.com/users/jroesch/followers","following_url":"https://api.github.com/users/jroesch/following{/other_user}","gists_url":"https://api.github.com/users/jroesch/gists{/gist_id}","starred_url":"https://api.github.com/users/jroesch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jroesch/subscriptions","organizations_url":"https://api.github.com/users/jroesch/orgs","repos_url":"https://api.github.com/users/jroesch/repos","events_url":"https://api.github.com/users/jroesch/events{/privacy}","received_events_url":"https://api.github.com/users/jroesch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jroesch/toml-rs","description":"A TOML encoding/decoding library for Rust","fork":true,"url":"https://api.github.com/repos/jroesch/toml-rs","forks_url":"https://api.github.com/repos/jroesch/toml-rs/forks","keys_url":"https://api.github.com/repos/jroesch/toml-rs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jroesch/toml-rs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jroesch/toml-rs/teams","hooks_url":"https://api.github.com/repos/jroesch/toml-rs/hooks","issue_events_url":"https://api.github.com/repos/jroesch/toml-rs/issues/events{/number}","events_url":"https://api.github.com/repos/jroesch/toml-rs/events","assignees_url":"https://api.github.com/repos/jroesch/toml-rs/assignees{/user}","branches_url":"https://api.github.com/repos/jroesch/toml-rs/branches{/branch}","tags_url":"https://api.github.com/repos/jroesch/toml-rs/tags","blobs_url":"https://api.github.com/repos/jroesch/toml-rs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jroesch/toml-rs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jroesch/toml-rs/git/refs{/sha}","trees_url":"https://api.github.com/repos/jroesch/toml-rs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jroesch/toml-rs/statuses/{sha}","languages_url":"https://api.github.com/repos/jroesch/toml-rs/languages","stargazers_url":"https://api.github.com/repos/jroesch/toml-rs/stargazers","contributors_url":"https://api.github.com/repos/jroesch/toml-rs/contributors","subscribers_url":"https://api.github.com/repos/jroesch/toml-rs/subscribers","subscription_url":"https://api.github.com/repos/jroesch/toml-rs/subscription","commits_url":"https://api.github.com/repos/jroesch/toml-rs/commits{/sha}","git_commits_url":"https://api.github.com/repos/jroesch/toml-rs/git/commits{/sha}","comments_url":"https://api.github.com/repos/jroesch/toml-rs/comments{/number}","issue_comment_url":"https://api.github.com/repos/jroesch/toml-rs/issues/comments/{number}","contents_url":"https://api.github.com/repos/jroesch/toml-rs/contents/{+path}","compare_url":"https://api.github.com/repos/jroesch/toml-rs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jroesch/toml-rs/merges","archive_url":"https://api.github.com/repos/jroesch/toml-rs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jroesch/toml-rs/downloads","issues_url":"https://api.github.com/repos/jroesch/toml-rs/issues{/number}","pulls_url":"https://api.github.com/repos/jroesch/toml-rs/pulls{/number}","milestones_url":"https://api.github.com/repos/jroesch/toml-rs/milestones{/number}","notifications_url":"https://api.github.com/repos/jroesch/toml-rs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jroesch/toml-rs/labels{/name}","releases_url":"https://api.github.com/repos/jroesch/toml-rs/releases{/id}","created_at":"2014-08-27T02:46:15Z","updated_at":"2014-08-26T05:58:41Z","pushed_at":"2014-09-18T05:01:27Z","git_url":"git://github.com/jroesch/toml-rs.git","ssh_url":"git@github.com:jroesch/toml-rs.git","clone_url":"https://github.com/jroesch/toml-rs.git","svn_url":"https://github.com/jroesch/toml-rs","homepage":"http://alexcrichton.com/toml-rs","size":711,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"alexcrichton:master","ref":"master","sha":"5f5bd93203aa4c8e0602eb4def2d73d385cba74c","user":{"login":"alexcrichton","id":64996,"avatar_url":"https://avatars.githubusercontent.com/u/64996?v=2","gravatar_id":"477e2098d9864b482d28e5ef8e657f43","url":"https://api.github.com/users/alexcrichton","html_url":"https://github.com/alexcrichton","followers_url":"https://api.github.com/users/alexcrichton/followers","following_url":"https://api.github.com/users/alexcrichton/following{/other_user}","gists_url":"https://api.github.com/users/alexcrichton/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcrichton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcrichton/subscriptions","organizations_url":"https://api.github.com/users/alexcrichton/orgs","repos_url":"https://api.github.com/users/alexcrichton/repos","events_url":"https://api.github.com/users/alexcrichton/events{/privacy}","received_events_url":"https://api.github.com/users/alexcrichton/received_events","type":"User","site_admin":false},"repo":{"id":21056223,"name":"toml-rs","full_name":"alexcrichton/toml-rs","owner":{"login":"alexcrichton","id":64996,"avatar_url":"https://avatars.githubusercontent.com/u/64996?v=2","gravatar_id":"477e2098d9864b482d28e5ef8e657f43","url":"https://api.github.com/users/alexcrichton","html_url":"https://github.com/alexcrichton","followers_url":"https://api.github.com/users/alexcrichton/followers","following_url":"https://api.github.com/users/alexcrichton/following{/other_user}","gists_url":"https://api.github.com/users/alexcrichton/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcrichton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcrichton/subscriptions","organizations_url":"https://api.github.com/users/alexcrichton/orgs","repos_url":"https://api.github.com/users/alexcrichton/repos","events_url":"https://api.github.com/users/alexcrichton/events{/privacy}","received_events_url":"https://api.github.com/users/alexcrichton/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alexcrichton/toml-rs","description":"A TOML encoding/decoding library for Rust","fork":false,"url":"https://api.github.com/repos/alexcrichton/toml-rs","forks_url":"https://api.github.com/repos/alexcrichton/toml-rs/forks","keys_url":"https://api.github.com/repos/alexcrichton/toml-rs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alexcrichton/toml-rs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alexcrichton/toml-rs/teams","hooks_url":"https://api.github.com/repos/alexcrichton/toml-rs/hooks","issue_events_url":"https://api.github.com/repos/alexcrichton/toml-rs/issues/events{/number}","events_url":"https://api.github.com/repos/alexcrichton/toml-rs/events","assignees_url":"https://api.github.com/repos/alexcrichton/toml-rs/assignees{/user}","branches_url":"https://api.github.com/repos/alexcrichton/toml-rs/branches{/branch}","tags_url":"https://api.github.com/repos/alexcrichton/toml-rs/tags","blobs_url":"https://api.github.com/repos/alexcrichton/toml-rs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alexcrichton/toml-rs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alexcrichton/toml-rs/git/refs{/sha}","trees_url":"https://api.github.com/repos/alexcrichton/toml-rs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alexcrichton/toml-rs/statuses/{sha}","languages_url":"https://api.github.com/repos/alexcrichton/toml-rs/languages","stargazers_url":"https://api.github.com/repos/alexcrichton/toml-rs/stargazers","contributors_url":"https://api.github.com/repos/alexcrichton/toml-rs/contributors","subscribers_url":"https://api.github.com/repos/alexcrichton/toml-rs/subscribers","subscription_url":"https://api.github.com/repos/alexcrichton/toml-rs/subscription","commits_url":"https://api.github.com/repos/alexcrichton/toml-rs/commits{/sha}","git_commits_url":"https://api.github.com/repos/alexcrichton/toml-rs/git/commits{/sha}","comments_url":"https://api.github.com/repos/alexcrichton/toml-rs/comments{/number}","issue_comment_url":"https://api.github.com/repos/alexcrichton/toml-rs/issues/comments/{number}","contents_url":"https://api.github.com/repos/alexcrichton/toml-rs/contents/{+path}","compare_url":"https://api.github.com/repos/alexcrichton/toml-rs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alexcrichton/toml-rs/merges","archive_url":"https://api.github.com/repos/alexcrichton/toml-rs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alexcrichton/toml-rs/downloads","issues_url":"https://api.github.com/repos/alexcrichton/toml-rs/issues{/number}","pulls_url":"https://api.github.com/repos/alexcrichton/toml-rs/pulls{/number}","milestones_url":"https://api.github.com/repos/alexcrichton/toml-rs/milestones{/number}","notifications_url":"https://api.github.com/repos/alexcrichton/toml-rs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alexcrichton/toml-rs/labels{/name}","releases_url":"https://api.github.com/repos/alexcrichton/toml-rs/releases{/id}","created_at":"2014-06-21T00:06:20Z","updated_at":"2014-09-13T10:47:28Z","pushed_at":"2014-09-18T13:49:47Z","git_url":"git://github.com/alexcrichton/toml-rs.git","ssh_url":"git@github.com:alexcrichton/toml-rs.git","clone_url":"https://github.com/alexcrichton/toml-rs.git","svn_url":"https://github.com/alexcrichton/toml-rs","homepage":"http://alexcrichton.com/toml-rs","size":1520,"stargazers_count":13,"watchers_count":13,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":12,"mirror_url":null,"open_issues_count":4,"forks":12,"open_issues":4,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alexcrichton/toml-rs/pulls/18"},"html":{"href":"https://github.com/alexcrichton/toml-rs/pull/18"},"issue":{"href":"https://api.github.com/repos/alexcrichton/toml-rs/issues/18"},"comments":{"href":"https://api.github.com/repos/alexcrichton/toml-rs/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/alexcrichton/toml-rs/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/alexcrichton/toml-rs/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/alexcrichton/toml-rs/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/alexcrichton/toml-rs/statuses/ef4e8f58acf6dcb3eae9ee26069b71837195a455"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"alexcrichton","id":64996,"avatar_url":"https://avatars.githubusercontent.com/u/64996?v=2","gravatar_id":"477e2098d9864b482d28e5ef8e657f43","url":"https://api.github.com/users/alexcrichton","html_url":"https://github.com/alexcrichton","followers_url":"https://api.github.com/users/alexcrichton/followers","following_url":"https://api.github.com/users/alexcrichton/following{/other_user}","gists_url":"https://api.github.com/users/alexcrichton/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcrichton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcrichton/subscriptions","organizations_url":"https://api.github.com/users/alexcrichton/orgs","repos_url":"https://api.github.com/users/alexcrichton/repos","events_url":"https://api.github.com/users/alexcrichton/events{/privacy}","received_events_url":"https://api.github.com/users/alexcrichton/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":3,"deletions":3,"changed_files":1}}