GitHub PullRequestEvent at 2014-10-20 17:33:23
Repository: VenoBox
Actor: nicolafranchini
Payload: {"action":"closed","number":29,"pull_request":{"url":"https://api.github.com/repos/nicolafranchini/VenoBox/pulls/29","id":22554181,"html_url":"https://github.com/nicolafranchini/VenoBox/pull/29","diff_url":"https://github.com/nicolafranchini/VenoBox/pull/29.diff","patch_url":"https://github.com/nicolafranchini/VenoBox/pull/29.patch","issue_url":"https://api.github.com/repos/nicolafranchini/VenoBox/issues/29","number":29,"state":"closed","locked":false,"title":"Added overlayclose, fixes and Tidy up","user":{"login":"martybalandis","id":3653259,"avatar_url":"https://avatars.githubusercontent.com/u/3653259?v=2","gravatar_id":"","url":"https://api.github.com/users/martybalandis","html_url":"https://github.com/martybalandis","followers_url":"https://api.github.com/users/martybalandis/followers","following_url":"https://api.github.com/users/martybalandis/following{/other_user}","gists_url":"https://api.github.com/users/martybalandis/gists{/gist_id}","starred_url":"https://api.github.com/users/martybalandis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martybalandis/subscriptions","organizations_url":"https://api.github.com/users/martybalandis/orgs","repos_url":"https://api.github.com/users/martybalandis/repos","events_url":"https://api.github.com/users/martybalandis/events{/privacy}","received_events_url":"https://api.github.com/users/martybalandis/received_events","type":"User","site_admin":false},"body":"Because I needed an option to close on X only #28 issue. I decided to make a option and while I was in momentum so I tweaked a bit more. If not merge when you might want to see if some of things I did are good for the code\r\n\r\nAdded overlayclose option. Default is true but if set to false it will only close on X\r\nDeclared missing variables (many were implicitly declared)\r\nChanged  var options = $.extend(defaults, options); to  var option = $.extend(defaults, options); and all variables accordingly because it is a duplicate declaration.\r\nMade the JavaScript better formed by fixing minor warning and errors IDE displays. Including missing semi-columns where it should be and commas where it is unnecessary. It is now has no errors at all!\r\nNote: I only updated venobox.js but not the venobox.min.js!!\r\n\r\nHope you like it. :) I didn't do things that should break the code. If it does let me know. If you do tests and see everything is still working it would be great if it get merged :)","created_at":"2014-10-10T11:25:15Z","updated_at":"2014-10-20T17:33:23Z","closed_at":"2014-10-20T17:33:23Z","merged_at":null,"merge_commit_sha":"b660adc1c83defd30e9428416fbe3252972f6f1c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nicolafranchini/VenoBox/pulls/29/commits","review_comments_url":"https://api.github.com/repos/nicolafranchini/VenoBox/pulls/29/comments","review_comment_url":"https://api.github.com/repos/nicolafranchini/VenoBox/pulls/comments/{number}","comments_url":"https://api.github.com/repos/nicolafranchini/VenoBox/issues/29/comments","statuses_url":"https://api.github.com/repos/nicolafranchini/VenoBox/statuses/13d33e2815a1a48bd39720b24a370f702d262b03","head":{"label":"martybalandis:master","ref":"master","sha":"13d33e2815a1a48bd39720b24a370f702d262b03","user":{"login":"martybalandis","id":3653259,"avatar_url":"https://avatars.githubusercontent.com/u/3653259?v=2","gravatar_id":"","url":"https://api.github.com/users/martybalandis","html_url":"https://github.com/martybalandis","followers_url":"https://api.github.com/users/martybalandis/followers","following_url":"https://api.github.com/users/martybalandis/following{/other_user}","gists_url":"https://api.github.com/users/martybalandis/gists{/gist_id}","starred_url":"https://api.github.com/users/martybalandis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martybalandis/subscriptions","organizations_url":"https://api.github.com/users/martybalandis/orgs","repos_url":"https://api.github.com/users/martybalandis/repos","events_url":"https://api.github.com/users/martybalandis/events{/privacy}","received_events_url":"https://api.github.com/users/martybalandis/received_events","type":"User","site_admin":false},"repo":{"id":25032289,"name":"VenoBox","full_name":"martybalandis/VenoBox","owner":{"login":"martybalandis","id":3653259,"avatar_url":"https://avatars.githubusercontent.com/u/3653259?v=2","gravatar_id":"","url":"https://api.github.com/users/martybalandis","html_url":"https://github.com/martybalandis","followers_url":"https://api.github.com/users/martybalandis/followers","following_url":"https://api.github.com/users/martybalandis/following{/other_user}","gists_url":"https://api.github.com/users/martybalandis/gists{/gist_id}","starred_url":"https://api.github.com/users/martybalandis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martybalandis/subscriptions","organizations_url":"https://api.github.com/users/martybalandis/orgs","repos_url":"https://api.github.com/users/martybalandis/repos","events_url":"https://api.github.com/users/martybalandis/events{/privacy}","received_events_url":"https://api.github.com/users/martybalandis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/martybalandis/VenoBox","description":"responsive jQuery lightbox plugin","fork":true,"url":"https://api.github.com/repos/martybalandis/VenoBox","forks_url":"https://api.github.com/repos/martybalandis/VenoBox/forks","keys_url":"https://api.github.com/repos/martybalandis/VenoBox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/martybalandis/VenoBox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/martybalandis/VenoBox/teams","hooks_url":"https://api.github.com/repos/martybalandis/VenoBox/hooks","issue_events_url":"https://api.github.com/repos/martybalandis/VenoBox/issues/events{/number}","events_url":"https://api.github.com/repos/martybalandis/VenoBox/events","assignees_url":"https://api.github.com/repos/martybalandis/VenoBox/assignees{/user}","branches_url":"https://api.github.com/repos/martybalandis/VenoBox/branches{/branch}","tags_url":"https://api.github.com/repos/martybalandis/VenoBox/tags","blobs_url":"https://api.github.com/repos/martybalandis/VenoBox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/martybalandis/VenoBox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/martybalandis/VenoBox/git/refs{/sha}","trees_url":"https://api.github.com/repos/martybalandis/VenoBox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/martybalandis/VenoBox/statuses/{sha}","languages_url":"https://api.github.com/repos/martybalandis/VenoBox/languages","stargazers_url":"https://api.github.com/repos/martybalandis/VenoBox/stargazers","contributors_url":"https://api.github.com/repos/martybalandis/VenoBox/contributors","subscribers_url":"https://api.github.com/repos/martybalandis/VenoBox/subscribers","subscription_url":"https://api.github.com/repos/martybalandis/VenoBox/subscription","commits_url":"https://api.github.com/repos/martybalandis/VenoBox/commits{/sha}","git_commits_url":"https://api.github.com/repos/martybalandis/VenoBox/git/commits{/sha}","comments_url":"https://api.github.com/repos/martybalandis/VenoBox/comments{/number}","issue_comment_url":"https://api.github.com/repos/martybalandis/VenoBox/issues/comments/{number}","contents_url":"https://api.github.com/repos/martybalandis/VenoBox/contents/{+path}","compare_url":"https://api.github.com/repos/martybalandis/VenoBox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/martybalandis/VenoBox/merges","archive_url":"https://api.github.com/repos/martybalandis/VenoBox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/martybalandis/VenoBox/downloads","issues_url":"https://api.github.com/repos/martybalandis/VenoBox/issues{/number}","pulls_url":"https://api.github.com/repos/martybalandis/VenoBox/pulls{/number}","milestones_url":"https://api.github.com/repos/martybalandis/VenoBox/milestones{/number}","notifications_url":"https://api.github.com/repos/martybalandis/VenoBox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/martybalandis/VenoBox/labels{/name}","releases_url":"https://api.github.com/repos/martybalandis/VenoBox/releases{/id}","created_at":"2014-10-10T11:15:41Z","updated_at":"2014-10-10T11:20:53Z","pushed_at":"2014-10-10T11:20:53Z","git_url":"git://github.com/martybalandis/VenoBox.git","ssh_url":"git@github.com:martybalandis/VenoBox.git","clone_url":"https://github.com/martybalandis/VenoBox.git","svn_url":"https://github.com/martybalandis/VenoBox","homepage":null,"size":395,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nicolafranchini:master","ref":"master","sha":"7f484bd2a4610aeb11a23134ae94f7078a59e650","user":{"login":"nicolafranchini","id":5631760,"avatar_url":"https://avatars.githubusercontent.com/u/5631760?v=2","gravatar_id":"","url":"https://api.github.com/users/nicolafranchini","html_url":"https://github.com/nicolafranchini","followers_url":"https://api.github.com/users/nicolafranchini/followers","following_url":"https://api.github.com/users/nicolafranchini/following{/other_user}","gists_url":"https://api.github.com/users/nicolafranchini/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolafranchini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolafranchini/subscriptions","organizations_url":"https://api.github.com/users/nicolafranchini/orgs","repos_url":"https://api.github.com/users/nicolafranchini/repos","events_url":"https://api.github.com/users/nicolafranchini/events{/privacy}","received_events_url":"https://api.github.com/users/nicolafranchini/received_events","type":"User","site_admin":false},"repo":{"id":14146763,"name":"VenoBox","full_name":"nicolafranchini/VenoBox","owner":{"login":"nicolafranchini","id":5631760,"avatar_url":"https://avatars.githubusercontent.com/u/5631760?v=2","gravatar_id":"","url":"https://api.github.com/users/nicolafranchini","html_url":"https://github.com/nicolafranchini","followers_url":"https://api.github.com/users/nicolafranchini/followers","following_url":"https://api.github.com/users/nicolafranchini/following{/other_user}","gists_url":"https://api.github.com/users/nicolafranchini/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolafranchini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolafranchini/subscriptions","organizations_url":"https://api.github.com/users/nicolafranchini/orgs","repos_url":"https://api.github.com/users/nicolafranchini/repos","events_url":"https://api.github.com/users/nicolafranchini/events{/privacy}","received_events_url":"https://api.github.com/users/nicolafranchini/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nicolafranchini/VenoBox","description":"responsive jQuery lightbox plugin","fork":false,"url":"https://api.github.com/repos/nicolafranchini/VenoBox","forks_url":"https://api.github.com/repos/nicolafranchini/VenoBox/forks","keys_url":"https://api.github.com/repos/nicolafranchini/VenoBox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nicolafranchini/VenoBox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nicolafranchini/VenoBox/teams","hooks_url":"https://api.github.com/repos/nicolafranchini/VenoBox/hooks","issue_events_url":"https://api.github.com/repos/nicolafranchini/VenoBox/issues/events{/number}","events_url":"https://api.github.com/repos/nicolafranchini/VenoBox/events","assignees_url":"https://api.github.com/repos/nicolafranchini/VenoBox/assignees{/user}","branches_url":"https://api.github.com/repos/nicolafranchini/VenoBox/branches{/branch}","tags_url":"https://api.github.com/repos/nicolafranchini/VenoBox/tags","blobs_url":"https://api.github.com/repos/nicolafranchini/VenoBox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nicolafranchini/VenoBox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nicolafranchini/VenoBox/git/refs{/sha}","trees_url":"https://api.github.com/repos/nicolafranchini/VenoBox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nicolafranchini/VenoBox/statuses/{sha}","languages_url":"https://api.github.com/repos/nicolafranchini/VenoBox/languages","stargazers_url":"https://api.github.com/repos/nicolafranchini/VenoBox/stargazers","contributors_url":"https://api.github.com/repos/nicolafranchini/VenoBox/contributors","subscribers_url":"https://api.github.com/repos/nicolafranchini/VenoBox/subscribers","subscription_url":"https://api.github.com/repos/nicolafranchini/VenoBox/subscription","commits_url":"https://api.github.com/repos/nicolafranchini/VenoBox/commits{/sha}","git_commits_url":"https://api.github.com/repos/nicolafranchini/VenoBox/git/commits{/sha}","comments_url":"https://api.github.com/repos/nicolafranchini/VenoBox/comments{/number}","issue_comment_url":"https://api.github.com/repos/nicolafranchini/VenoBox/issues/comments/{number}","contents_url":"https://api.github.com/repos/nicolafranchini/VenoBox/contents/{+path}","compare_url":"https://api.github.com/repos/nicolafranchini/VenoBox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nicolafranchini/VenoBox/merges","archive_url":"https://api.github.com/repos/nicolafranchini/VenoBox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nicolafranchini/VenoBox/downloads","issues_url":"https://api.github.com/repos/nicolafranchini/VenoBox/issues{/number}","pulls_url":"https://api.github.com/repos/nicolafranchini/VenoBox/pulls{/number}","milestones_url":"https://api.github.com/repos/nicolafranchini/VenoBox/milestones{/number}","notifications_url":"https://api.github.com/repos/nicolafranchini/VenoBox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nicolafranchini/VenoBox/labels{/name}","releases_url":"https://api.github.com/repos/nicolafranchini/VenoBox/releases{/id}","created_at":"2013-11-05T16:22:21Z","updated_at":"2014-10-11T18:30:14Z","pushed_at":"2014-10-20T17:29:47Z","git_url":"git://github.com/nicolafranchini/VenoBox.git","ssh_url":"git@github.com:nicolafranchini/VenoBox.git","clone_url":"https://github.com/nicolafranchini/VenoBox.git","svn_url":"https://github.com/nicolafranchini/VenoBox","homepage":null,"size":905,"stargazers_count":159,"watchers_count":159,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":45,"mirror_url":null,"open_issues_count":0,"forks":45,"open_issues":0,"watchers":159,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nicolafranchini/VenoBox/pulls/29"},"html":{"href":"https://github.com/nicolafranchini/VenoBox/pull/29"},"issue":{"href":"https://api.github.com/repos/nicolafranchini/VenoBox/issues/29"},"comments":{"href":"https://api.github.com/repos/nicolafranchini/VenoBox/issues/29/comments"},"review_comments":{"href":"https://api.github.com/repos/nicolafranchini/VenoBox/pulls/29/comments"},"review_comment":{"href":"https://api.github.com/repos/nicolafranchini/VenoBox/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/nicolafranchini/VenoBox/pulls/29/commits"},"statuses":{"href":"https://api.github.com/repos/nicolafranchini/VenoBox/statuses/13d33e2815a1a48bd39720b24a370f702d262b03"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":1,"review_comments":0,"commits":1,"additions":33,"deletions":24,"changed_files":1}}