GitHub PullRequestEvent at 2014-12-08 07:41:07
Repository: express-example
Actor: sdepold
Payload: {"action":"closed","number":12,"pull_request":{"url":"https://api.github.com/repos/sequelize/express-example/pulls/12","id":25638689,"html_url":"https://github.com/sequelize/express-example/pull/12","diff_url":"https://github.com/sequelize/express-example/pull/12.diff","patch_url":"https://github.com/sequelize/express-example/pull/12.patch","issue_url":"https://api.github.com/repos/sequelize/express-example/issues/12","number":12,"state":"closed","locked":false,"title":"Use Promises instead of EventEmitter for handling return results","user":{"login":"apapap","id":10100293,"avatar_url":"https://avatars.githubusercontent.com/u/10100293?v=3","gravatar_id":"","url":"https://api.github.com/users/apapap","html_url":"https://github.com/apapap","followers_url":"https://api.github.com/users/apapap/followers","following_url":"https://api.github.com/users/apapap/following{/other_user}","gists_url":"https://api.github.com/users/apapap/gists{/gist_id}","starred_url":"https://api.github.com/users/apapap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apapap/subscriptions","organizations_url":"https://api.github.com/users/apapap/orgs","repos_url":"https://api.github.com/users/apapap/repos","events_url":"https://api.github.com/users/apapap/events{/privacy}","received_events_url":"https://api.github.com/users/apapap/received_events","type":"User","site_admin":false},"body":"I thought I'd go ahead and do it.  :)\r\n\r\nReturn results now use core Promise methods rather than the EventEmitter methods from Sequelize.  The latter are now deprecated with Sequelize version 2.0.  E.g. .success is replaced by .then.  For more info about the Sequelize upgrade see:  https://github.com/sequelize/sequelize/wiki/Upgrading-to-2.0 \r\n\r\nFYI, Sequelize now uses the BlueBird Promises library.  For info on that, see: https://github.com/petkaantonov/bluebird \r\n\r\nNote that this project is an example of using Sequelize with Express.  There's currently minimal handling of rejection return results and other errors. ","created_at":"2014-12-07T22:38:54Z","updated_at":"2014-12-08T07:41:07Z","closed_at":"2014-12-08T07:41:07Z","merged_at":"2014-12-08T07:41:07Z","merge_commit_sha":"a3500a827a843686b4e79f3e82b64812486fedf2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sequelize/express-example/pulls/12/commits","review_comments_url":"https://api.github.com/repos/sequelize/express-example/pulls/12/comments","review_comment_url":"https://api.github.com/repos/sequelize/express-example/pulls/comments/{number}","comments_url":"https://api.github.com/repos/sequelize/express-example/issues/12/comments","statuses_url":"https://api.github.com/repos/sequelize/express-example/statuses/f559699fdff996569c3a3cdbddd869d9f810e9d4","head":{"label":"apapap:master","ref":"master","sha":"f559699fdff996569c3a3cdbddd869d9f810e9d4","user":{"login":"apapap","id":10100293,"avatar_url":"https://avatars.githubusercontent.com/u/10100293?v=3","gravatar_id":"","url":"https://api.github.com/users/apapap","html_url":"https://github.com/apapap","followers_url":"https://api.github.com/users/apapap/followers","following_url":"https://api.github.com/users/apapap/following{/other_user}","gists_url":"https://api.github.com/users/apapap/gists{/gist_id}","starred_url":"https://api.github.com/users/apapap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apapap/subscriptions","organizations_url":"https://api.github.com/users/apapap/orgs","repos_url":"https://api.github.com/users/apapap/repos","events_url":"https://api.github.com/users/apapap/events{/privacy}","received_events_url":"https://api.github.com/users/apapap/received_events","type":"User","site_admin":false},"repo":{"id":27646827,"name":"express-example","full_name":"apapap/express-example","owner":{"login":"apapap","id":10100293,"avatar_url":"https://avatars.githubusercontent.com/u/10100293?v=3","gravatar_id":"","url":"https://api.github.com/users/apapap","html_url":"https://github.com/apapap","followers_url":"https://api.github.com/users/apapap/followers","following_url":"https://api.github.com/users/apapap/following{/other_user}","gists_url":"https://api.github.com/users/apapap/gists{/gist_id}","starred_url":"https://api.github.com/users/apapap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apapap/subscriptions","organizations_url":"https://api.github.com/users/apapap/orgs","repos_url":"https://api.github.com/users/apapap/repos","events_url":"https://api.github.com/users/apapap/events{/privacy}","received_events_url":"https://api.github.com/users/apapap/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/apapap/express-example","description":"A proposal for the usage of Sequelize within an Express.JS application.","fork":true,"url":"https://api.github.com/repos/apapap/express-example","forks_url":"https://api.github.com/repos/apapap/express-example/forks","keys_url":"https://api.github.com/repos/apapap/express-example/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apapap/express-example/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apapap/express-example/teams","hooks_url":"https://api.github.com/repos/apapap/express-example/hooks","issue_events_url":"https://api.github.com/repos/apapap/express-example/issues/events{/number}","events_url":"https://api.github.com/repos/apapap/express-example/events","assignees_url":"https://api.github.com/repos/apapap/express-example/assignees{/user}","branches_url":"https://api.github.com/repos/apapap/express-example/branches{/branch}","tags_url":"https://api.github.com/repos/apapap/express-example/tags","blobs_url":"https://api.github.com/repos/apapap/express-example/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apapap/express-example/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apapap/express-example/git/refs{/sha}","trees_url":"https://api.github.com/repos/apapap/express-example/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apapap/express-example/statuses/{sha}","languages_url":"https://api.github.com/repos/apapap/express-example/languages","stargazers_url":"https://api.github.com/repos/apapap/express-example/stargazers","contributors_url":"https://api.github.com/repos/apapap/express-example/contributors","subscribers_url":"https://api.github.com/repos/apapap/express-example/subscribers","subscription_url":"https://api.github.com/repos/apapap/express-example/subscription","commits_url":"https://api.github.com/repos/apapap/express-example/commits{/sha}","git_commits_url":"https://api.github.com/repos/apapap/express-example/git/commits{/sha}","comments_url":"https://api.github.com/repos/apapap/express-example/comments{/number}","issue_comment_url":"https://api.github.com/repos/apapap/express-example/issues/comments/{number}","contents_url":"https://api.github.com/repos/apapap/express-example/contents/{+path}","compare_url":"https://api.github.com/repos/apapap/express-example/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apapap/express-example/merges","archive_url":"https://api.github.com/repos/apapap/express-example/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apapap/express-example/downloads","issues_url":"https://api.github.com/repos/apapap/express-example/issues{/number}","pulls_url":"https://api.github.com/repos/apapap/express-example/pulls{/number}","milestones_url":"https://api.github.com/repos/apapap/express-example/milestones{/number}","notifications_url":"https://api.github.com/repos/apapap/express-example/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apapap/express-example/labels{/name}","releases_url":"https://api.github.com/repos/apapap/express-example/releases{/id}","created_at":"2014-12-06T19:47:04Z","updated_at":"2014-12-07T22:08:08Z","pushed_at":"2014-12-07T22:08:08Z","git_url":"git://github.com/apapap/express-example.git","ssh_url":"git@github.com:apapap/express-example.git","clone_url":"https://github.com/apapap/express-example.git","svn_url":"https://github.com/apapap/express-example","homepage":"","size":96,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sequelize:master","ref":"master","sha":"01c285e4fab6a7721a913d250b4698dc4a74260b","user":{"login":"sequelize","id":3591786,"avatar_url":"https://avatars.githubusercontent.com/u/3591786?v=3","gravatar_id":"","url":"https://api.github.com/users/sequelize","html_url":"https://github.com/sequelize","followers_url":"https://api.github.com/users/sequelize/followers","following_url":"https://api.github.com/users/sequelize/following{/other_user}","gists_url":"https://api.github.com/users/sequelize/gists{/gist_id}","starred_url":"https://api.github.com/users/sequelize/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sequelize/subscriptions","organizations_url":"https://api.github.com/users/sequelize/orgs","repos_url":"https://api.github.com/users/sequelize/repos","events_url":"https://api.github.com/users/sequelize/events{/privacy}","received_events_url":"https://api.github.com/users/sequelize/received_events","type":"Organization","site_admin":false},"repo":{"id":15030344,"name":"express-example","full_name":"sequelize/express-example","owner":{"login":"sequelize","id":3591786,"avatar_url":"https://avatars.githubusercontent.com/u/3591786?v=3","gravatar_id":"","url":"https://api.github.com/users/sequelize","html_url":"https://github.com/sequelize","followers_url":"https://api.github.com/users/sequelize/followers","following_url":"https://api.github.com/users/sequelize/following{/other_user}","gists_url":"https://api.github.com/users/sequelize/gists{/gist_id}","starred_url":"https://api.github.com/users/sequelize/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sequelize/subscriptions","organizations_url":"https://api.github.com/users/sequelize/orgs","repos_url":"https://api.github.com/users/sequelize/repos","events_url":"https://api.github.com/users/sequelize/events{/privacy}","received_events_url":"https://api.github.com/users/sequelize/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sequelize/express-example","description":"A proposal for the usage of Sequelize within an Express.JS application.","fork":false,"url":"https://api.github.com/repos/sequelize/express-example","forks_url":"https://api.github.com/repos/sequelize/express-example/forks","keys_url":"https://api.github.com/repos/sequelize/express-example/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sequelize/express-example/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sequelize/express-example/teams","hooks_url":"https://api.github.com/repos/sequelize/express-example/hooks","issue_events_url":"https://api.github.com/repos/sequelize/express-example/issues/events{/number}","events_url":"https://api.github.com/repos/sequelize/express-example/events","assignees_url":"https://api.github.com/repos/sequelize/express-example/assignees{/user}","branches_url":"https://api.github.com/repos/sequelize/express-example/branches{/branch}","tags_url":"https://api.github.com/repos/sequelize/express-example/tags","blobs_url":"https://api.github.com/repos/sequelize/express-example/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sequelize/express-example/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sequelize/express-example/git/refs{/sha}","trees_url":"https://api.github.com/repos/sequelize/express-example/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sequelize/express-example/statuses/{sha}","languages_url":"https://api.github.com/repos/sequelize/express-example/languages","stargazers_url":"https://api.github.com/repos/sequelize/express-example/stargazers","contributors_url":"https://api.github.com/repos/sequelize/express-example/contributors","subscribers_url":"https://api.github.com/repos/sequelize/express-example/subscribers","subscription_url":"https://api.github.com/repos/sequelize/express-example/subscription","commits_url":"https://api.github.com/repos/sequelize/express-example/commits{/sha}","git_commits_url":"https://api.github.com/repos/sequelize/express-example/git/commits{/sha}","comments_url":"https://api.github.com/repos/sequelize/express-example/comments{/number}","issue_comment_url":"https://api.github.com/repos/sequelize/express-example/issues/comments/{number}","contents_url":"https://api.github.com/repos/sequelize/express-example/contents/{+path}","compare_url":"https://api.github.com/repos/sequelize/express-example/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sequelize/express-example/merges","archive_url":"https://api.github.com/repos/sequelize/express-example/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sequelize/express-example/downloads","issues_url":"https://api.github.com/repos/sequelize/express-example/issues{/number}","pulls_url":"https://api.github.com/repos/sequelize/express-example/pulls{/number}","milestones_url":"https://api.github.com/repos/sequelize/express-example/milestones{/number}","notifications_url":"https://api.github.com/repos/sequelize/express-example/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sequelize/express-example/labels{/name}","releases_url":"https://api.github.com/repos/sequelize/express-example/releases{/id}","created_at":"2013-12-08T20:07:26Z","updated_at":"2014-12-07T09:29:33Z","pushed_at":"2014-12-08T07:41:07Z","git_url":"git://github.com/sequelize/express-example.git","ssh_url":"git@github.com:sequelize/express-example.git","clone_url":"https://github.com/sequelize/express-example.git","svn_url":"https://github.com/sequelize/express-example","homepage":"","size":188,"stargazers_count":55,"watchers_count":55,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":30,"mirror_url":null,"open_issues_count":2,"forks":30,"open_issues":2,"watchers":55,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sequelize/express-example/pulls/12"},"html":{"href":"https://github.com/sequelize/express-example/pull/12"},"issue":{"href":"https://api.github.com/repos/sequelize/express-example/issues/12"},"comments":{"href":"https://api.github.com/repos/sequelize/express-example/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/sequelize/express-example/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/sequelize/express-example/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/sequelize/express-example/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/sequelize/express-example/statuses/f559699fdff996569c3a3cdbddd869d9f810e9d4"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"sdepold","id":79163,"avatar_url":"https://avatars.githubusercontent.com/u/79163?v=3","gravatar_id":"","url":"https://api.github.com/users/sdepold","html_url":"https://github.com/sdepold","followers_url":"https://api.github.com/users/sdepold/followers","following_url":"https://api.github.com/users/sdepold/following{/other_user}","gists_url":"https://api.github.com/users/sdepold/gists{/gist_id}","starred_url":"https://api.github.com/users/sdepold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdepold/subscriptions","organizations_url":"https://api.github.com/users/sdepold/orgs","repos_url":"https://api.github.com/users/sdepold/repos","events_url":"https://api.github.com/users/sdepold/events{/privacy}","received_events_url":"https://api.github.com/users/sdepold/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":14,"deletions":14,"changed_files":4}}