GitHub PullRequestReviewCommentEvent at 2014-07-08 10:35:32
Repository: junit
Actor: vorburger
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/junit-team/junit/pulls/comments/14646324","id":14646324,"diff_hunk":"@@ -106,6 +106,26 @@ static public void assertEquals(String message, String expected, String actual)\n     static public void assertEquals(String expected, String actual) {\n         assertEquals(null, expected, actual);\n     }\n+    \n+    /**\n+     * Asserts that two CharSequence are equal.\n+     * \n+     * @author Michael Vorburger\n+     */\n+    @SuppressWarnings(\"deprecation\")","path":"src/main/java/junit/framework/Assert.java","position":null,"original_position":10,"commit_id":"8830ab4573238b63bbbf2ac2ca0f5a0aa900c89d","original_commit_id":"f4aeb6b697ca0af52a70fa0ba18a342248fe68c9","user":{"login":"vorburger","id":298598,"avatar_url":"https://avatars.githubusercontent.com/u/298598?","gravatar_id":"3eced70cd3418b88f0fe9c101048e4ea","url":"https://api.github.com/users/vorburger","html_url":"https://github.com/vorburger","followers_url":"https://api.github.com/users/vorburger/followers","following_url":"https://api.github.com/users/vorburger/following{/other_user}","gists_url":"https://api.github.com/users/vorburger/gists{/gist_id}","starred_url":"https://api.github.com/users/vorburger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vorburger/subscriptions","organizations_url":"https://api.github.com/users/vorburger/orgs","repos_url":"https://api.github.com/users/vorburger/repos","events_url":"https://api.github.com/users/vorburger/events{/privacy}","received_events_url":"https://api.github.com/users/vorburger/received_events","type":"User","site_admin":false},"body":"None, this was stupid - removed in new commit. (Reason was that I copy/pasted this.)","created_at":"2014-07-08T10:35:32Z","updated_at":"2014-07-08T10:35:32Z","html_url":"https://github.com/junit-team/junit/pull/949#discussion_r14646324","pull_request_url":"https://api.github.com/repos/junit-team/junit/pulls/949","_links":{"self":{"href":"https://api.github.com/repos/junit-team/junit/pulls/comments/14646324"},"html":{"href":"https://github.com/junit-team/junit/pull/949#discussion_r14646324"},"pull_request":{"href":"https://api.github.com/repos/junit-team/junit/pulls/949"}}},"pull_request":{"url":"https://api.github.com/repos/junit-team/junit/pulls/949","id":18070576,"html_url":"https://github.com/junit-team/junit/pull/949","diff_url":"https://github.com/junit-team/junit/pull/949.diff","patch_url":"https://github.com/junit-team/junit/pull/949.patch","issue_url":"https://api.github.com/repos/junit-team/junit/issues/949","number":949,"state":"open","title":"support for assertEquals([String message, ] CharSequence, CharSequence)","user":{"login":"vorburger","id":298598,"avatar_url":"https://avatars.githubusercontent.com/u/298598?","gravatar_id":"3eced70cd3418b88f0fe9c101048e4ea","url":"https://api.github.com/users/vorburger","html_url":"https://github.com/vorburger","followers_url":"https://api.github.com/users/vorburger/followers","following_url":"https://api.github.com/users/vorburger/following{/other_user}","gists_url":"https://api.github.com/users/vorburger/gists{/gist_id}","starred_url":"https://api.github.com/users/vorburger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vorburger/subscriptions","organizations_url":"https://api.github.com/users/vorburger/orgs","repos_url":"https://api.github.com/users/vorburger/repos","events_url":"https://api.github.com/users/vorburger/events{/privacy}","received_events_url":"https://api.github.com/users/vorburger/received_events","type":"User","site_admin":false},"body":"This contribution fixes a problem I've run into when using assertEquals on two CharSequence.\r\n\r\nIt basically already works, of course - BUT one is left wondering why e.g. the Eclipse (and presumably other IDE as well) JUnit view's Result Comparison pop-up does not work on double-clicking a failure.. this is because, currently, assertEquals on two CharSequence throws only a generic AssertionFailedError and not the ComparisonFailure expected by such UIs.\r\n\r\nPS: As the pom.xml specifies jdk.version 1.5 and <compilerVersion>1.5</compilerVersion>,  I was assuming, hopefully correctly, that introducing a @since 1.4 CharSequence was not a problem for backward compat.","created_at":"2014-07-07T21:32:53Z","updated_at":"2014-07-08T10:35:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"955279bb3845440b061081def6ec6249ca10c71d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/junit-team/junit/pulls/949/commits","review_comments_url":"https://api.github.com/repos/junit-team/junit/pulls/949/comments","review_comment_url":"https://api.github.com/repos/junit-team/junit/pulls/comments/{number}","comments_url":"https://api.github.com/repos/junit-team/junit/issues/949/comments","statuses_url":"https://api.github.com/repos/junit-team/junit/statuses/8830ab4573238b63bbbf2ac2ca0f5a0aa900c89d","head":{"label":"vorburger:CharSequence","ref":"CharSequence","sha":"8830ab4573238b63bbbf2ac2ca0f5a0aa900c89d","user":{"login":"vorburger","id":298598,"avatar_url":"https://avatars.githubusercontent.com/u/298598?","gravatar_id":"3eced70cd3418b88f0fe9c101048e4ea","url":"https://api.github.com/users/vorburger","html_url":"https://github.com/vorburger","followers_url":"https://api.github.com/users/vorburger/followers","following_url":"https://api.github.com/users/vorburger/following{/other_user}","gists_url":"https://api.github.com/users/vorburger/gists{/gist_id}","starred_url":"https://api.github.com/users/vorburger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vorburger/subscriptions","organizations_url":"https://api.github.com/users/vorburger/orgs","repos_url":"https://api.github.com/users/vorburger/repos","events_url":"https://api.github.com/users/vorburger/events{/privacy}","received_events_url":"https://api.github.com/users/vorburger/received_events","type":"User","site_admin":false},"repo":{"id":12846314,"name":"junit","full_name":"vorburger/junit","owner":{"login":"vorburger","id":298598,"avatar_url":"https://avatars.githubusercontent.com/u/298598?","gravatar_id":"3eced70cd3418b88f0fe9c101048e4ea","url":"https://api.github.com/users/vorburger","html_url":"https://github.com/vorburger","followers_url":"https://api.github.com/users/vorburger/followers","following_url":"https://api.github.com/users/vorburger/following{/other_user}","gists_url":"https://api.github.com/users/vorburger/gists{/gist_id}","starred_url":"https://api.github.com/users/vorburger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vorburger/subscriptions","organizations_url":"https://api.github.com/users/vorburger/orgs","repos_url":"https://api.github.com/users/vorburger/repos","events_url":"https://api.github.com/users/vorburger/events{/privacy}","received_events_url":"https://api.github.com/users/vorburger/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vorburger/junit","description":"A programmer-oriented testing framework for Java.","fork":true,"url":"https://api.github.com/repos/vorburger/junit","forks_url":"https://api.github.com/repos/vorburger/junit/forks","keys_url":"https://api.github.com/repos/vorburger/junit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vorburger/junit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vorburger/junit/teams","hooks_url":"https://api.github.com/repos/vorburger/junit/hooks","issue_events_url":"https://api.github.com/repos/vorburger/junit/issues/events{/number}","events_url":"https://api.github.com/repos/vorburger/junit/events","assignees_url":"https://api.github.com/repos/vorburger/junit/assignees{/user}","branches_url":"https://api.github.com/repos/vorburger/junit/branches{/branch}","tags_url":"https://api.github.com/repos/vorburger/junit/tags","blobs_url":"https://api.github.com/repos/vorburger/junit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vorburger/junit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vorburger/junit/git/refs{/sha}","trees_url":"https://api.github.com/repos/vorburger/junit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vorburger/junit/statuses/{sha}","languages_url":"https://api.github.com/repos/vorburger/junit/languages","stargazers_url":"https://api.github.com/repos/vorburger/junit/stargazers","contributors_url":"https://api.github.com/repos/vorburger/junit/contributors","subscribers_url":"https://api.github.com/repos/vorburger/junit/subscribers","subscription_url":"https://api.github.com/repos/vorburger/junit/subscription","commits_url":"https://api.github.com/repos/vorburger/junit/commits{/sha}","git_commits_url":"https://api.github.com/repos/vorburger/junit/git/commits{/sha}","comments_url":"https://api.github.com/repos/vorburger/junit/comments{/number}","issue_comment_url":"https://api.github.com/repos/vorburger/junit/issues/comments/{number}","contents_url":"https://api.github.com/repos/vorburger/junit/contents/{+path}","compare_url":"https://api.github.com/repos/vorburger/junit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vorburger/junit/merges","archive_url":"https://api.github.com/repos/vorburger/junit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vorburger/junit/downloads","issues_url":"https://api.github.com/repos/vorburger/junit/issues{/number}","pulls_url":"https://api.github.com/repos/vorburger/junit/pulls{/number}","milestones_url":"https://api.github.com/repos/vorburger/junit/milestones{/number}","notifications_url":"https://api.github.com/repos/vorburger/junit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vorburger/junit/labels{/name}","releases_url":"https://api.github.com/repos/vorburger/junit/releases{/id}","created_at":"2013-09-15T14:05:23Z","updated_at":"2013-09-16T22:12:38Z","pushed_at":"2014-07-08T10:34:16Z","git_url":"git://github.com/vorburger/junit.git","ssh_url":"git@github.com:vorburger/junit.git","clone_url":"https://github.com/vorburger/junit.git","svn_url":"https://github.com/vorburger/junit","homepage":"","size":7412,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"junit-team:master","ref":"master","sha":"127f1bb2a137d611e98277a0d1e9184efc47bc05","user":{"login":"junit-team","id":874086,"avatar_url":"https://avatars.githubusercontent.com/u/874086?","gravatar_id":"075328bf957813f5bdb0756dd026f8d7","url":"https://api.github.com/users/junit-team","html_url":"https://github.com/junit-team","followers_url":"https://api.github.com/users/junit-team/followers","following_url":"https://api.github.com/users/junit-team/following{/other_user}","gists_url":"https://api.github.com/users/junit-team/gists{/gist_id}","starred_url":"https://api.github.com/users/junit-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junit-team/subscriptions","organizations_url":"https://api.github.com/users/junit-team/orgs","repos_url":"https://api.github.com/users/junit-team/repos","events_url":"https://api.github.com/users/junit-team/events{/privacy}","received_events_url":"https://api.github.com/users/junit-team/received_events","type":"Organization","site_admin":false},"repo":{"id":106310,"name":"junit","full_name":"junit-team/junit","owner":{"login":"junit-team","id":874086,"avatar_url":"https://avatars.githubusercontent.com/u/874086?","gravatar_id":"075328bf957813f5bdb0756dd026f8d7","url":"https://api.github.com/users/junit-team","html_url":"https://github.com/junit-team","followers_url":"https://api.github.com/users/junit-team/followers","following_url":"https://api.github.com/users/junit-team/following{/other_user}","gists_url":"https://api.github.com/users/junit-team/gists{/gist_id}","starred_url":"https://api.github.com/users/junit-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junit-team/subscriptions","organizations_url":"https://api.github.com/users/junit-team/orgs","repos_url":"https://api.github.com/users/junit-team/repos","events_url":"https://api.github.com/users/junit-team/events{/privacy}","received_events_url":"https://api.github.com/users/junit-team/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/junit-team/junit","description":"A programmer-oriented testing framework for Java.","fork":false,"url":"https://api.github.com/repos/junit-team/junit","forks_url":"https://api.github.com/repos/junit-team/junit/forks","keys_url":"https://api.github.com/repos/junit-team/junit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/junit-team/junit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/junit-team/junit/teams","hooks_url":"https://api.github.com/repos/junit-team/junit/hooks","issue_events_url":"https://api.github.com/repos/junit-team/junit/issues/events{/number}","events_url":"https://api.github.com/repos/junit-team/junit/events","assignees_url":"https://api.github.com/repos/junit-team/junit/assignees{/user}","branches_url":"https://api.github.com/repos/junit-team/junit/branches{/branch}","tags_url":"https://api.github.com/repos/junit-team/junit/tags","blobs_url":"https://api.github.com/repos/junit-team/junit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/junit-team/junit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/junit-team/junit/git/refs{/sha}","trees_url":"https://api.github.com/repos/junit-team/junit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/junit-team/junit/statuses/{sha}","languages_url":"https://api.github.com/repos/junit-team/junit/languages","stargazers_url":"https://api.github.com/repos/junit-team/junit/stargazers","contributors_url":"https://api.github.com/repos/junit-team/junit/contributors","subscribers_url":"https://api.github.com/repos/junit-team/junit/subscribers","subscription_url":"https://api.github.com/repos/junit-team/junit/subscription","commits_url":"https://api.github.com/repos/junit-team/junit/commits{/sha}","git_commits_url":"https://api.github.com/repos/junit-team/junit/git/commits{/sha}","comments_url":"https://api.github.com/repos/junit-team/junit/comments{/number}","issue_comment_url":"https://api.github.com/repos/junit-team/junit/issues/comments/{number}","contents_url":"https://api.github.com/repos/junit-team/junit/contents/{+path}","compare_url":"https://api.github.com/repos/junit-team/junit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/junit-team/junit/merges","archive_url":"https://api.github.com/repos/junit-team/junit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/junit-team/junit/downloads","issues_url":"https://api.github.com/repos/junit-team/junit/issues{/number}","pulls_url":"https://api.github.com/repos/junit-team/junit/pulls{/number}","milestones_url":"https://api.github.com/repos/junit-team/junit/milestones{/number}","notifications_url":"https://api.github.com/repos/junit-team/junit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/junit-team/junit/labels{/name}","releases_url":"https://api.github.com/repos/junit-team/junit/releases{/id}","created_at":"2009-01-13T03:41:26Z","updated_at":"2014-07-08T10:04:00Z","pushed_at":"2014-07-02T17:56:16Z","git_url":"git://github.com/junit-team/junit.git","ssh_url":"git@github.com:junit-team/junit.git","clone_url":"https://github.com/junit-team/junit.git","svn_url":"https://github.com/junit-team/junit","homepage":"","size":26710,"stargazers_count":2707,"watchers_count":2707,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":984,"mirror_url":null,"open_issues_count":155,"forks":984,"open_issues":155,"watchers":2707,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/junit-team/junit/pulls/949"},"html":{"href":"https://github.com/junit-team/junit/pull/949"},"issue":{"href":"https://api.github.com/repos/junit-team/junit/issues/949"},"comments":{"href":"https://api.github.com/repos/junit-team/junit/issues/949/comments"},"review_comments":{"href":"https://api.github.com/repos/junit-team/junit/pulls/949/comments"},"review_comment":{"href":"https://api.github.com/repos/junit-team/junit/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/junit-team/junit/pulls/949/commits"},"statuses":{"href":"https://api.github.com/repos/junit-team/junit/statuses/8830ab4573238b63bbbf2ac2ca0f5a0aa900c89d"}}}}