GitHub PullRequestReviewCommentEvent at 2014-11-06 10:52:31
Repository: gaia
Actor: etiennesegonzac
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/19937389","id":19937389,"diff_hunk":"@@ -369,6 +369,22 @@ var UtilityTray = {\n     if (instant || style.MozTransform === '') {\n       this.screen.classList.remove('utility-tray');\n       this.notifications.classList.remove('visible');\n+    } else {\n+\n+      var element = this.overlay;\n+      var safetyTimeout = null;\n+      var finish = function(evt) {\n+        if (evt && evt.target !== element) {\n+          return;\n+        }\n+\n+        element.removeEventListener('transitionend', finish);","path":"apps/system/js/utility_tray.js","position":13,"original_position":13,"commit_id":"2ad18ef0a2157396f5b6ca611b7c2e5cdb3da399","original_commit_id":"2ad18ef0a2157396f5b6ca611b7c2e5cdb3da399","user":{"login":"etiennesegonzac","id":105194,"avatar_url":"https://avatars.githubusercontent.com/u/105194?v=2","gravatar_id":"","url":"https://api.github.com/users/etiennesegonzac","html_url":"https://github.com/etiennesegonzac","followers_url":"https://api.github.com/users/etiennesegonzac/followers","following_url":"https://api.github.com/users/etiennesegonzac/following{/other_user}","gists_url":"https://api.github.com/users/etiennesegonzac/gists{/gist_id}","starred_url":"https://api.github.com/users/etiennesegonzac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etiennesegonzac/subscriptions","organizations_url":"https://api.github.com/users/etiennesegonzac/orgs","repos_url":"https://api.github.com/users/etiennesegonzac/repos","events_url":"https://api.github.com/users/etiennesegonzac/events{/privacy}","received_events_url":"https://api.github.com/users/etiennesegonzac/received_events","type":"User","site_admin":false},"body":"we could dispatch in the `transitionend` case of the `handleEvent` and in the first branch of the `if` above and we should be fine","created_at":"2014-11-06T10:52:31Z","updated_at":"2014-11-06T10:52:31Z","html_url":"https://github.com/mozilla-b2g/gaia/pull/25857#discussion_r19937389","pull_request_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/25857","_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/19937389"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/25857#discussion_r19937389"},"pull_request":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/25857"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/25857","id":23944575,"html_url":"https://github.com/mozilla-b2g/gaia/pull/25857","diff_url":"https://github.com/mozilla-b2g/gaia/pull/25857.diff","patch_url":"https://github.com/mozilla-b2g/gaia/pull/25857.patch","issue_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/25857","number":25857,"state":"open","locked":false,"title":"Bug 1089528 - Do not open app until utility tray is pulled down","user":{"login":"KevinGrandon","id":122602,"avatar_url":"https://avatars.githubusercontent.com/u/122602?v=2","gravatar_id":"","url":"https://api.github.com/users/KevinGrandon","html_url":"https://github.com/KevinGrandon","followers_url":"https://api.github.com/users/KevinGrandon/followers","following_url":"https://api.github.com/users/KevinGrandon/following{/other_user}","gists_url":"https://api.github.com/users/KevinGrandon/gists{/gist_id}","starred_url":"https://api.github.com/users/KevinGrandon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KevinGrandon/subscriptions","organizations_url":"https://api.github.com/users/KevinGrandon/orgs","repos_url":"https://api.github.com/users/KevinGrandon/repos","events_url":"https://api.github.com/users/KevinGrandon/events{/privacy}","received_events_url":"https://api.github.com/users/KevinGrandon/received_events","type":"User","site_admin":false},"body":"https://bugzilla.mozilla.org/show_bug.cgi?id=1089528","created_at":"2014-11-05T22:42:31Z","updated_at":"2014-11-06T10:52:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"568a58931fb86569f4d7f198bc286b343f4379f3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/25857/commits","review_comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/25857/comments","review_comment_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/25857/comments","statuses_url":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/2ad18ef0a2157396f5b6ca611b7c2e5cdb3da399","head":{"label":"KevinGrandon:bug_1089528_statusbar_closing","ref":"bug_1089528_statusbar_closing","sha":"2ad18ef0a2157396f5b6ca611b7c2e5cdb3da399","user":{"login":"KevinGrandon","id":122602,"avatar_url":"https://avatars.githubusercontent.com/u/122602?v=2","gravatar_id":"","url":"https://api.github.com/users/KevinGrandon","html_url":"https://github.com/KevinGrandon","followers_url":"https://api.github.com/users/KevinGrandon/followers","following_url":"https://api.github.com/users/KevinGrandon/following{/other_user}","gists_url":"https://api.github.com/users/KevinGrandon/gists{/gist_id}","starred_url":"https://api.github.com/users/KevinGrandon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KevinGrandon/subscriptions","organizations_url":"https://api.github.com/users/KevinGrandon/orgs","repos_url":"https://api.github.com/users/KevinGrandon/repos","events_url":"https://api.github.com/users/KevinGrandon/events{/privacy}","received_events_url":"https://api.github.com/users/KevinGrandon/received_events","type":"User","site_admin":false},"repo":{"id":6770930,"name":"gaia","full_name":"KevinGrandon/gaia","owner":{"login":"KevinGrandon","id":122602,"avatar_url":"https://avatars.githubusercontent.com/u/122602?v=2","gravatar_id":"","url":"https://api.github.com/users/KevinGrandon","html_url":"https://github.com/KevinGrandon","followers_url":"https://api.github.com/users/KevinGrandon/followers","following_url":"https://api.github.com/users/KevinGrandon/following{/other_user}","gists_url":"https://api.github.com/users/KevinGrandon/gists{/gist_id}","starred_url":"https://api.github.com/users/KevinGrandon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KevinGrandon/subscriptions","organizations_url":"https://api.github.com/users/KevinGrandon/orgs","repos_url":"https://api.github.com/users/KevinGrandon/repos","events_url":"https://api.github.com/users/KevinGrandon/events{/privacy}","received_events_url":"https://api.github.com/users/KevinGrandon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/KevinGrandon/gaia","description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project","fork":true,"url":"https://api.github.com/repos/KevinGrandon/gaia","forks_url":"https://api.github.com/repos/KevinGrandon/gaia/forks","keys_url":"https://api.github.com/repos/KevinGrandon/gaia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KevinGrandon/gaia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KevinGrandon/gaia/teams","hooks_url":"https://api.github.com/repos/KevinGrandon/gaia/hooks","issue_events_url":"https://api.github.com/repos/KevinGrandon/gaia/issues/events{/number}","events_url":"https://api.github.com/repos/KevinGrandon/gaia/events","assignees_url":"https://api.github.com/repos/KevinGrandon/gaia/assignees{/user}","branches_url":"https://api.github.com/repos/KevinGrandon/gaia/branches{/branch}","tags_url":"https://api.github.com/repos/KevinGrandon/gaia/tags","blobs_url":"https://api.github.com/repos/KevinGrandon/gaia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KevinGrandon/gaia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KevinGrandon/gaia/git/refs{/sha}","trees_url":"https://api.github.com/repos/KevinGrandon/gaia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KevinGrandon/gaia/statuses/{sha}","languages_url":"https://api.github.com/repos/KevinGrandon/gaia/languages","stargazers_url":"https://api.github.com/repos/KevinGrandon/gaia/stargazers","contributors_url":"https://api.github.com/repos/KevinGrandon/gaia/contributors","subscribers_url":"https://api.github.com/repos/KevinGrandon/gaia/subscribers","subscription_url":"https://api.github.com/repos/KevinGrandon/gaia/subscription","commits_url":"https://api.github.com/repos/KevinGrandon/gaia/commits{/sha}","git_commits_url":"https://api.github.com/repos/KevinGrandon/gaia/git/commits{/sha}","comments_url":"https://api.github.com/repos/KevinGrandon/gaia/comments{/number}","issue_comment_url":"https://api.github.com/repos/KevinGrandon/gaia/issues/comments/{number}","contents_url":"https://api.github.com/repos/KevinGrandon/gaia/contents/{+path}","compare_url":"https://api.github.com/repos/KevinGrandon/gaia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KevinGrandon/gaia/merges","archive_url":"https://api.github.com/repos/KevinGrandon/gaia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KevinGrandon/gaia/downloads","issues_url":"https://api.github.com/repos/KevinGrandon/gaia/issues{/number}","pulls_url":"https://api.github.com/repos/KevinGrandon/gaia/pulls{/number}","milestones_url":"https://api.github.com/repos/KevinGrandon/gaia/milestones{/number}","notifications_url":"https://api.github.com/repos/KevinGrandon/gaia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KevinGrandon/gaia/labels{/name}","releases_url":"https://api.github.com/repos/KevinGrandon/gaia/releases{/id}","created_at":"2012-11-20T02:22:33Z","updated_at":"2014-06-25T19:51:56Z","pushed_at":"2014-11-06T05:43:05Z","git_url":"git://github.com/KevinGrandon/gaia.git","ssh_url":"git@github.com:KevinGrandon/gaia.git","clone_url":"https://github.com/KevinGrandon/gaia.git","svn_url":"https://github.com/KevinGrandon/gaia","homepage":"https://wiki.mozilla.org/B2G","size":889930,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla-b2g:v2.1","ref":"v2.1","sha":"9658b93b412bdcc0f953d668e8c8e68318c99fb8","user":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=2","gravatar_id":"","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"repo":{"id":2317369,"name":"gaia","full_name":"mozilla-b2g/gaia","owner":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=2","gravatar_id":"","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-b2g/gaia","description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see","fork":false,"url":"https://api.github.com/repos/mozilla-b2g/gaia","forks_url":"https://api.github.com/repos/mozilla-b2g/gaia/forks","keys_url":"https://api.github.com/repos/mozilla-b2g/gaia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-b2g/gaia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-b2g/gaia/teams","hooks_url":"https://api.github.com/repos/mozilla-b2g/gaia/hooks","issue_events_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-b2g/gaia/events","assignees_url":"https://api.github.com/repos/mozilla-b2g/gaia/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-b2g/gaia/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-b2g/gaia/tags","blobs_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-b2g/gaia/languages","stargazers_url":"https://api.github.com/repos/mozilla-b2g/gaia/stargazers","contributors_url":"https://api.github.com/repos/mozilla-b2g/gaia/contributors","subscribers_url":"https://api.github.com/repos/mozilla-b2g/gaia/subscribers","subscription_url":"https://api.github.com/repos/mozilla-b2g/gaia/subscription","commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/comments/{number}","contents_url":"https://api.github.com/repos/mozilla-b2g/gaia/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-b2g/gaia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-b2g/gaia/merges","archive_url":"https://api.github.com/repos/mozilla-b2g/gaia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-b2g/gaia/downloads","issues_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-b2g/gaia/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-b2g/gaia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-b2g/gaia/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-b2g/gaia/releases{/id}","created_at":"2011-09-03T01:38:46Z","updated_at":"2014-11-06T02:33:09Z","pushed_at":"2014-11-06T10:18:38Z","git_url":"git://github.com/mozilla-b2g/gaia.git","ssh_url":"git@github.com:mozilla-b2g/gaia.git","clone_url":"https://github.com/mozilla-b2g/gaia.git","svn_url":"https://github.com/mozilla-b2g/gaia","homepage":"https://wiki.mozilla.org/B2G","size":1526760,"stargazers_count":1784,"watchers_count":1784,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2038,"mirror_url":null,"open_issues_count":613,"forks":2038,"open_issues":613,"watchers":1784,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/25857"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/25857"},"issue":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/issues/25857"},"comments":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/issues/25857/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/25857/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/25857/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/2ad18ef0a2157396f5b6ca611b7c2e5cdb3da399"}}}}