GitHub PullRequestReviewCommentEvent at 2014-11-06 22:30:18
Repository: hibernate-search
Actor: Sanne
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/hibernate/hibernate-search/pulls/comments/19981184","id":19981184,"diff_hunk":"@@ -34,4 +33,7 @@\n \t * @experimental : This feature is experimental\n \t */\n \tClass<? extends EntityIndexingInterceptor> interceptor() default DefaultEntityInterceptor.class;\n+\n+\tinterface DefaultEntityInterceptor extends EntityIndexingInterceptor {","path":"engine/src/main/java/org/hibernate/search/annotations/Indexed.java","position":13,"original_position":13,"commit_id":"61461b2e1ab9f6adad78fe1a12c411461c631961","original_commit_id":"61461b2e1ab9f6adad78fe1a12c411461c631961","user":{"login":"Sanne","id":42573,"avatar_url":"https://avatars.githubusercontent.com/u/42573?v=2","gravatar_id":"","url":"https://api.github.com/users/Sanne","html_url":"https://github.com/Sanne","followers_url":"https://api.github.com/users/Sanne/followers","following_url":"https://api.github.com/users/Sanne/following{/other_user}","gists_url":"https://api.github.com/users/Sanne/gists{/gist_id}","starred_url":"https://api.github.com/users/Sanne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sanne/subscriptions","organizations_url":"https://api.github.com/users/Sanne/orgs","repos_url":"https://api.github.com/users/Sanne/repos","events_url":"https://api.github.com/users/Sanne/events{/privacy}","received_events_url":"https://api.github.com/users/Sanne/received_events","type":"User","site_admin":false},"body":"by having this interface here, it's promoted to be public, in a public package.. seems to defeat the description of the JIRA?\r\nI'd prefer to just move the existing interceptor into an .impl package, if you really want to fix this.","created_at":"2014-11-06T22:30:18Z","updated_at":"2014-11-06T22:30:18Z","html_url":"https://github.com/hibernate/hibernate-search/pull/697#discussion_r19981184","pull_request_url":"https://api.github.com/repos/hibernate/hibernate-search/pulls/697","_links":{"self":{"href":"https://api.github.com/repos/hibernate/hibernate-search/pulls/comments/19981184"},"html":{"href":"https://github.com/hibernate/hibernate-search/pull/697#discussion_r19981184"},"pull_request":{"href":"https://api.github.com/repos/hibernate/hibernate-search/pulls/697"}}},"pull_request":{"url":"https://api.github.com/repos/hibernate/hibernate-search/pulls/697","id":23906037,"html_url":"https://github.com/hibernate/hibernate-search/pull/697","diff_url":"https://github.com/hibernate/hibernate-search/pull/697.diff","patch_url":"https://github.com/hibernate/hibernate-search/pull/697.patch","issue_url":"https://api.github.com/repos/hibernate/hibernate-search/issues/697","number":697,"state":"open","locked":false,"title":"HSEARCH-1713 Removing DefaultEntityInterceptor from public API and makin...","user":{"login":"hferentschik","id":296354,"avatar_url":"https://avatars.githubusercontent.com/u/296354?v=2","gravatar_id":"","url":"https://api.github.com/users/hferentschik","html_url":"https://github.com/hferentschik","followers_url":"https://api.github.com/users/hferentschik/followers","following_url":"https://api.github.com/users/hferentschik/following{/other_user}","gists_url":"https://api.github.com/users/hferentschik/gists{/gist_id}","starred_url":"https://api.github.com/users/hferentschik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hferentschik/subscriptions","organizations_url":"https://api.github.com/users/hferentschik/orgs","repos_url":"https://api.github.com/users/hferentschik/repos","events_url":"https://api.github.com/users/hferentschik/events{/privacy}","received_events_url":"https://api.github.com/users/hferentschik/received_events","type":"User","site_admin":false},"body":"...g it an inner interface of the @Indexed annotation","created_at":"2014-11-05T13:39:49Z","updated_at":"2014-11-06T22:30:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e1106d510521a59f14f91dc4ff7408dfeab98652","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hibernate/hibernate-search/pulls/697/commits","review_comments_url":"https://api.github.com/repos/hibernate/hibernate-search/pulls/697/comments","review_comment_url":"https://api.github.com/repos/hibernate/hibernate-search/pulls/comments/{number}","comments_url":"https://api.github.com/repos/hibernate/hibernate-search/issues/697/comments","statuses_url":"https://api.github.com/repos/hibernate/hibernate-search/statuses/61461b2e1ab9f6adad78fe1a12c411461c631961","head":{"label":"hferentschik:HSEARCH-1713","ref":"HSEARCH-1713","sha":"61461b2e1ab9f6adad78fe1a12c411461c631961","user":{"login":"hferentschik","id":296354,"avatar_url":"https://avatars.githubusercontent.com/u/296354?v=2","gravatar_id":"","url":"https://api.github.com/users/hferentschik","html_url":"https://github.com/hferentschik","followers_url":"https://api.github.com/users/hferentschik/followers","following_url":"https://api.github.com/users/hferentschik/following{/other_user}","gists_url":"https://api.github.com/users/hferentschik/gists{/gist_id}","starred_url":"https://api.github.com/users/hferentschik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hferentschik/subscriptions","organizations_url":"https://api.github.com/users/hferentschik/orgs","repos_url":"https://api.github.com/users/hferentschik/repos","events_url":"https://api.github.com/users/hferentschik/events{/privacy}","received_events_url":"https://api.github.com/users/hferentschik/received_events","type":"User","site_admin":false},"repo":{"id":1025927,"name":"hibernate-search","full_name":"hferentschik/hibernate-search","owner":{"login":"hferentschik","id":296354,"avatar_url":"https://avatars.githubusercontent.com/u/296354?v=2","gravatar_id":"","url":"https://api.github.com/users/hferentschik","html_url":"https://github.com/hferentschik","followers_url":"https://api.github.com/users/hferentschik/followers","following_url":"https://api.github.com/users/hferentschik/following{/other_user}","gists_url":"https://api.github.com/users/hferentschik/gists{/gist_id}","starred_url":"https://api.github.com/users/hferentschik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hferentschik/subscriptions","organizations_url":"https://api.github.com/users/hferentschik/orgs","repos_url":"https://api.github.com/users/hferentschik/repos","events_url":"https://api.github.com/users/hferentschik/events{/privacy}","received_events_url":"https://api.github.com/users/hferentschik/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hferentschik/hibernate-search","description":"Hibernate Search: full-text search for domain model","fork":true,"url":"https://api.github.com/repos/hferentschik/hibernate-search","forks_url":"https://api.github.com/repos/hferentschik/hibernate-search/forks","keys_url":"https://api.github.com/repos/hferentschik/hibernate-search/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hferentschik/hibernate-search/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hferentschik/hibernate-search/teams","hooks_url":"https://api.github.com/repos/hferentschik/hibernate-search/hooks","issue_events_url":"https://api.github.com/repos/hferentschik/hibernate-search/issues/events{/number}","events_url":"https://api.github.com/repos/hferentschik/hibernate-search/events","assignees_url":"https://api.github.com/repos/hferentschik/hibernate-search/assignees{/user}","branches_url":"https://api.github.com/repos/hferentschik/hibernate-search/branches{/branch}","tags_url":"https://api.github.com/repos/hferentschik/hibernate-search/tags","blobs_url":"https://api.github.com/repos/hferentschik/hibernate-search/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hferentschik/hibernate-search/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hferentschik/hibernate-search/git/refs{/sha}","trees_url":"https://api.github.com/repos/hferentschik/hibernate-search/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hferentschik/hibernate-search/statuses/{sha}","languages_url":"https://api.github.com/repos/hferentschik/hibernate-search/languages","stargazers_url":"https://api.github.com/repos/hferentschik/hibernate-search/stargazers","contributors_url":"https://api.github.com/repos/hferentschik/hibernate-search/contributors","subscribers_url":"https://api.github.com/repos/hferentschik/hibernate-search/subscribers","subscription_url":"https://api.github.com/repos/hferentschik/hibernate-search/subscription","commits_url":"https://api.github.com/repos/hferentschik/hibernate-search/commits{/sha}","git_commits_url":"https://api.github.com/repos/hferentschik/hibernate-search/git/commits{/sha}","comments_url":"https://api.github.com/repos/hferentschik/hibernate-search/comments{/number}","issue_comment_url":"https://api.github.com/repos/hferentschik/hibernate-search/issues/comments/{number}","contents_url":"https://api.github.com/repos/hferentschik/hibernate-search/contents/{+path}","compare_url":"https://api.github.com/repos/hferentschik/hibernate-search/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hferentschik/hibernate-search/merges","archive_url":"https://api.github.com/repos/hferentschik/hibernate-search/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hferentschik/hibernate-search/downloads","issues_url":"https://api.github.com/repos/hferentschik/hibernate-search/issues{/number}","pulls_url":"https://api.github.com/repos/hferentschik/hibernate-search/pulls{/number}","milestones_url":"https://api.github.com/repos/hferentschik/hibernate-search/milestones{/number}","notifications_url":"https://api.github.com/repos/hferentschik/hibernate-search/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hferentschik/hibernate-search/labels{/name}","releases_url":"https://api.github.com/repos/hferentschik/hibernate-search/releases{/id}","created_at":"2010-10-26T15:59:07Z","updated_at":"2014-08-29T14:01:04Z","pushed_at":"2014-11-05T16:05:03Z","git_url":"git://github.com/hferentschik/hibernate-search.git","ssh_url":"git@github.com:hferentschik/hibernate-search.git","clone_url":"https://github.com/hferentschik/hibernate-search.git","svn_url":"https://github.com/hferentschik/hibernate-search","homepage":"http://search.hibernate.org","size":42228,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"hibernate:master","ref":"master","sha":"4e8abd3ad1d4907f675ff9c92b3eba3295e52d0f","user":{"login":"hibernate","id":348262,"avatar_url":"https://avatars.githubusercontent.com/u/348262?v=2","gravatar_id":"","url":"https://api.github.com/users/hibernate","html_url":"https://github.com/hibernate","followers_url":"https://api.github.com/users/hibernate/followers","following_url":"https://api.github.com/users/hibernate/following{/other_user}","gists_url":"https://api.github.com/users/hibernate/gists{/gist_id}","starred_url":"https://api.github.com/users/hibernate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hibernate/subscriptions","organizations_url":"https://api.github.com/users/hibernate/orgs","repos_url":"https://api.github.com/users/hibernate/repos","events_url":"https://api.github.com/users/hibernate/events{/privacy}","received_events_url":"https://api.github.com/users/hibernate/received_events","type":"Organization","site_admin":false},"repo":{"id":990281,"name":"hibernate-search","full_name":"hibernate/hibernate-search","owner":{"login":"hibernate","id":348262,"avatar_url":"https://avatars.githubusercontent.com/u/348262?v=2","gravatar_id":"","url":"https://api.github.com/users/hibernate","html_url":"https://github.com/hibernate","followers_url":"https://api.github.com/users/hibernate/followers","following_url":"https://api.github.com/users/hibernate/following{/other_user}","gists_url":"https://api.github.com/users/hibernate/gists{/gist_id}","starred_url":"https://api.github.com/users/hibernate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hibernate/subscriptions","organizations_url":"https://api.github.com/users/hibernate/orgs","repos_url":"https://api.github.com/users/hibernate/repos","events_url":"https://api.github.com/users/hibernate/events{/privacy}","received_events_url":"https://api.github.com/users/hibernate/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hibernate/hibernate-search","description":"Hibernate Search: full-text search for domain model","fork":false,"url":"https://api.github.com/repos/hibernate/hibernate-search","forks_url":"https://api.github.com/repos/hibernate/hibernate-search/forks","keys_url":"https://api.github.com/repos/hibernate/hibernate-search/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hibernate/hibernate-search/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hibernate/hibernate-search/teams","hooks_url":"https://api.github.com/repos/hibernate/hibernate-search/hooks","issue_events_url":"https://api.github.com/repos/hibernate/hibernate-search/issues/events{/number}","events_url":"https://api.github.com/repos/hibernate/hibernate-search/events","assignees_url":"https://api.github.com/repos/hibernate/hibernate-search/assignees{/user}","branches_url":"https://api.github.com/repos/hibernate/hibernate-search/branches{/branch}","tags_url":"https://api.github.com/repos/hibernate/hibernate-search/tags","blobs_url":"https://api.github.com/repos/hibernate/hibernate-search/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hibernate/hibernate-search/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hibernate/hibernate-search/git/refs{/sha}","trees_url":"https://api.github.com/repos/hibernate/hibernate-search/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hibernate/hibernate-search/statuses/{sha}","languages_url":"https://api.github.com/repos/hibernate/hibernate-search/languages","stargazers_url":"https://api.github.com/repos/hibernate/hibernate-search/stargazers","contributors_url":"https://api.github.com/repos/hibernate/hibernate-search/contributors","subscribers_url":"https://api.github.com/repos/hibernate/hibernate-search/subscribers","subscription_url":"https://api.github.com/repos/hibernate/hibernate-search/subscription","commits_url":"https://api.github.com/repos/hibernate/hibernate-search/commits{/sha}","git_commits_url":"https://api.github.com/repos/hibernate/hibernate-search/git/commits{/sha}","comments_url":"https://api.github.com/repos/hibernate/hibernate-search/comments{/number}","issue_comment_url":"https://api.github.com/repos/hibernate/hibernate-search/issues/comments/{number}","contents_url":"https://api.github.com/repos/hibernate/hibernate-search/contents/{+path}","compare_url":"https://api.github.com/repos/hibernate/hibernate-search/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hibernate/hibernate-search/merges","archive_url":"https://api.github.com/repos/hibernate/hibernate-search/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hibernate/hibernate-search/downloads","issues_url":"https://api.github.com/repos/hibernate/hibernate-search/issues{/number}","pulls_url":"https://api.github.com/repos/hibernate/hibernate-search/pulls{/number}","milestones_url":"https://api.github.com/repos/hibernate/hibernate-search/milestones{/number}","notifications_url":"https://api.github.com/repos/hibernate/hibernate-search/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hibernate/hibernate-search/labels{/name}","releases_url":"https://api.github.com/repos/hibernate/hibernate-search/releases{/id}","created_at":"2010-10-15T15:55:09Z","updated_at":"2014-10-28T01:26:14Z","pushed_at":"2014-11-06T15:55:09Z","git_url":"git://github.com/hibernate/hibernate-search.git","ssh_url":"git@github.com:hibernate/hibernate-search.git","clone_url":"https://github.com/hibernate/hibernate-search.git","svn_url":"https://github.com/hibernate/hibernate-search","homepage":"http://search.hibernate.org","size":62255,"stargazers_count":130,"watchers_count":130,"language":"Java","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":91,"mirror_url":null,"open_issues_count":3,"forks":91,"open_issues":3,"watchers":130,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hibernate/hibernate-search/pulls/697"},"html":{"href":"https://github.com/hibernate/hibernate-search/pull/697"},"issue":{"href":"https://api.github.com/repos/hibernate/hibernate-search/issues/697"},"comments":{"href":"https://api.github.com/repos/hibernate/hibernate-search/issues/697/comments"},"review_comments":{"href":"https://api.github.com/repos/hibernate/hibernate-search/pulls/697/comments"},"review_comment":{"href":"https://api.github.com/repos/hibernate/hibernate-search/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/hibernate/hibernate-search/pulls/697/commits"},"statuses":{"href":"https://api.github.com/repos/hibernate/hibernate-search/statuses/61461b2e1ab9f6adad78fe1a12c411461c631961"}}}}