GitHub PullRequestReviewCommentEvent at 2014-08-18 06:39:25
Repository: spark
Actor: liancheng
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/16338953","id":16338953,"diff_hunk":"@@ -159,6 +159,28 @@ case class InsertIntoHiveTable(\n     writer.commitJob()\n   }\n \n+  def getDynamicPartDir(tableInfo: TableDesc, row: Row, dynamicPartNum2: Int) :String = {\n+    dynamicPartNum2 match {\n+      case 0 =>\"\"\n+      case i => {","path":"sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/InsertIntoHiveTable.scala","position":null,"original_position":16,"commit_id":"567972c2c4ff85e9d09b2c75fbffe5891b438b1c","original_commit_id":"d211d330550260d93752349682e7c8447691a9e5","user":{"login":"liancheng","id":230655,"avatar_url":"https://avatars.githubusercontent.com/u/230655?v=2","gravatar_id":"7fc334f1f3292b20d338cd85c45e167c","url":"https://api.github.com/users/liancheng","html_url":"https://github.com/liancheng","followers_url":"https://api.github.com/users/liancheng/followers","following_url":"https://api.github.com/users/liancheng/following{/other_user}","gists_url":"https://api.github.com/users/liancheng/gists{/gist_id}","starred_url":"https://api.github.com/users/liancheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liancheng/subscriptions","organizations_url":"https://api.github.com/users/liancheng/orgs","repos_url":"https://api.github.com/users/liancheng/repos","events_url":"https://api.github.com/users/liancheng/events{/privacy}","received_events_url":"https://api.github.com/users/liancheng/received_events","type":"User","site_admin":false},"body":"This pair of braces are redundant.","created_at":"2014-08-18T06:39:25Z","updated_at":"2014-08-18T06:39:25Z","html_url":"https://github.com/apache/spark/pull/1919#discussion_r16338953","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/1919","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/16338953"},"html":{"href":"https://github.com/apache/spark/pull/1919#discussion_r16338953"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/1919"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/1919","id":19712638,"html_url":"https://github.com/apache/spark/pull/1919","diff_url":"https://github.com/apache/spark/pull/1919.diff","patch_url":"https://github.com/apache/spark/pull/1919.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/1919","number":1919,"state":"open","locked":false,"title":"[SPARK-3007][SQL]Add \"Dynamic Partition\" support to Spark Sql hive","user":{"login":"baishuo","id":3177655,"avatar_url":"https://avatars.githubusercontent.com/u/3177655?v=2","gravatar_id":"abfef9539b88ee3241e3216e7b93bd1d","url":"https://api.github.com/users/baishuo","html_url":"https://github.com/baishuo","followers_url":"https://api.github.com/users/baishuo/followers","following_url":"https://api.github.com/users/baishuo/following{/other_user}","gists_url":"https://api.github.com/users/baishuo/gists{/gist_id}","starred_url":"https://api.github.com/users/baishuo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baishuo/subscriptions","organizations_url":"https://api.github.com/users/baishuo/orgs","repos_url":"https://api.github.com/users/baishuo/repos","events_url":"https://api.github.com/users/baishuo/events{/privacy}","received_events_url":"https://api.github.com/users/baishuo/received_events","type":"User","site_admin":false},"body":"the detail please refer the comment of https://issues.apache.org/jira/browse/SPARK-3007","created_at":"2014-08-13T09:14:59Z","updated_at":"2014-08-18T06:39:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"243ae3849260932f8ca7240ed25e4c7f2e97008d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/1919/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/1919/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments/{number}","comments_url":"https://api.github.com/repos/apache/spark/issues/1919/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/567972c2c4ff85e9d09b2c75fbffe5891b438b1c","head":{"label":"baishuo:patch-1","ref":"patch-1","sha":"567972c2c4ff85e9d09b2c75fbffe5891b438b1c","user":{"login":"baishuo","id":3177655,"avatar_url":"https://avatars.githubusercontent.com/u/3177655?v=2","gravatar_id":"abfef9539b88ee3241e3216e7b93bd1d","url":"https://api.github.com/users/baishuo","html_url":"https://github.com/baishuo","followers_url":"https://api.github.com/users/baishuo/followers","following_url":"https://api.github.com/users/baishuo/following{/other_user}","gists_url":"https://api.github.com/users/baishuo/gists{/gist_id}","starred_url":"https://api.github.com/users/baishuo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baishuo/subscriptions","organizations_url":"https://api.github.com/users/baishuo/orgs","repos_url":"https://api.github.com/users/baishuo/repos","events_url":"https://api.github.com/users/baishuo/events{/privacy}","received_events_url":"https://api.github.com/users/baishuo/received_events","type":"User","site_admin":false},"repo":{"id":22885947,"name":"spark","full_name":"baishuo/spark","owner":{"login":"baishuo","id":3177655,"avatar_url":"https://avatars.githubusercontent.com/u/3177655?v=2","gravatar_id":"abfef9539b88ee3241e3216e7b93bd1d","url":"https://api.github.com/users/baishuo","html_url":"https://github.com/baishuo","followers_url":"https://api.github.com/users/baishuo/followers","following_url":"https://api.github.com/users/baishuo/following{/other_user}","gists_url":"https://api.github.com/users/baishuo/gists{/gist_id}","starred_url":"https://api.github.com/users/baishuo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baishuo/subscriptions","organizations_url":"https://api.github.com/users/baishuo/orgs","repos_url":"https://api.github.com/users/baishuo/repos","events_url":"https://api.github.com/users/baishuo/events{/privacy}","received_events_url":"https://api.github.com/users/baishuo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/baishuo/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/baishuo/spark","forks_url":"https://api.github.com/repos/baishuo/spark/forks","keys_url":"https://api.github.com/repos/baishuo/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/baishuo/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/baishuo/spark/teams","hooks_url":"https://api.github.com/repos/baishuo/spark/hooks","issue_events_url":"https://api.github.com/repos/baishuo/spark/issues/events{/number}","events_url":"https://api.github.com/repos/baishuo/spark/events","assignees_url":"https://api.github.com/repos/baishuo/spark/assignees{/user}","branches_url":"https://api.github.com/repos/baishuo/spark/branches{/branch}","tags_url":"https://api.github.com/repos/baishuo/spark/tags","blobs_url":"https://api.github.com/repos/baishuo/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/baishuo/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/baishuo/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/baishuo/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/baishuo/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/baishuo/spark/languages","stargazers_url":"https://api.github.com/repos/baishuo/spark/stargazers","contributors_url":"https://api.github.com/repos/baishuo/spark/contributors","subscribers_url":"https://api.github.com/repos/baishuo/spark/subscribers","subscription_url":"https://api.github.com/repos/baishuo/spark/subscription","commits_url":"https://api.github.com/repos/baishuo/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/baishuo/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/baishuo/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/baishuo/spark/issues/comments/{number}","contents_url":"https://api.github.com/repos/baishuo/spark/contents/{+path}","compare_url":"https://api.github.com/repos/baishuo/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/baishuo/spark/merges","archive_url":"https://api.github.com/repos/baishuo/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/baishuo/spark/downloads","issues_url":"https://api.github.com/repos/baishuo/spark/issues{/number}","pulls_url":"https://api.github.com/repos/baishuo/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/baishuo/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/baishuo/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/baishuo/spark/labels{/name}","releases_url":"https://api.github.com/repos/baishuo/spark/releases{/id}","created_at":"2014-08-12T17:23:55Z","updated_at":"2014-08-18T06:26:44Z","pushed_at":"2014-08-18T06:36:58Z","git_url":"git://github.com/baishuo/spark.git","ssh_url":"git@github.com:baishuo/spark.git","clone_url":"https://github.com/baishuo/spark.git","svn_url":"https://github.com/baishuo/spark","homepage":null,"size":74890,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"fe4735958e62b1b32a01960503876000f3d2e520","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=2","gravatar_id":"a676c0bf448fcd49f588249ead719b4c","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=2","gravatar_id":"a676c0bf448fcd49f588249ead719b4c","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments/{number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","created_at":"2014-02-25T08:00:08Z","updated_at":"2014-08-18T03:29:38Z","pushed_at":"2014-08-18T06:31:12Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":2678708,"stargazers_count":1053,"watchers_count":1053,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":1101,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":285,"forks":1101,"open_issues":285,"watchers":1053,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/1919"},"html":{"href":"https://github.com/apache/spark/pull/1919"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/1919"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/1919/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/1919/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/1919/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/567972c2c4ff85e9d09b2c75fbffe5891b438b1c"}}}}