GitHub PullRequestReviewCommentEvent at 2014-10-03 17:27:04
Repository: tslint
Actor: ashwinr
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/palantir/tslint/pulls/comments/18407502","id":18407502,"diff_hunk":"@@ -40,16 +40,25 @@ class JsdocWalker extends Lint.RuleWalker {\n                 var commentText = triviaItem.fullText();\n                 var lines = commentText.split(\"\\n\");\n                 var jsdocPosition = currentPosition;\n-\n                 var firstLine = lines[0];\n+\n                 // regex is: start of string, followed by any amount of whitespace, followed by /**\n                 var isJsdocMatch = firstLine.match(/^\\s*\\/\\*\\*/);\n                 if (isJsdocMatch != null) {\n                     var lineMap = this.getSyntaxTree().lineMap();\n+\n+                    if (lines.length === 1) {\n+                        var firstLineMatch = firstLine.match(/^\\s*\\/\\*\\* .+ \\*\\/$/);","path":"src/rules/jsdocFormatRule.ts","position":13,"original_position":13,"commit_id":"1e07980420a89c27c7346d5f5d2dac901c42a8c6","original_commit_id":"1e07980420a89c27c7346d5f5d2dac901c42a8c6","user":{"login":"ashwinr","id":362990,"avatar_url":"https://avatars.githubusercontent.com/u/362990?v=2","gravatar_id":"","url":"https://api.github.com/users/ashwinr","html_url":"https://github.com/ashwinr","followers_url":"https://api.github.com/users/ashwinr/followers","following_url":"https://api.github.com/users/ashwinr/following{/other_user}","gists_url":"https://api.github.com/users/ashwinr/gists{/gist_id}","starred_url":"https://api.github.com/users/ashwinr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashwinr/subscriptions","organizations_url":"https://api.github.com/users/ashwinr/orgs","repos_url":"https://api.github.com/users/ashwinr/repos","events_url":"https://api.github.com/users/ashwinr/events{/privacy}","received_events_url":"https://api.github.com/users/ashwinr/received_events","type":"User","site_admin":false},"body":"this will not allow empty one-line comments like: \"/** */\". we should be allowing that. also add a test for an empty one-line comment to make sure it succeeds.","created_at":"2014-10-03T17:27:04Z","updated_at":"2014-10-03T17:27:04Z","html_url":"https://github.com/palantir/tslint/pull/218#discussion_r18407502","pull_request_url":"https://api.github.com/repos/palantir/tslint/pulls/218","_links":{"self":{"href":"https://api.github.com/repos/palantir/tslint/pulls/comments/18407502"},"html":{"href":"https://github.com/palantir/tslint/pull/218#discussion_r18407502"},"pull_request":{"href":"https://api.github.com/repos/palantir/tslint/pulls/218"}}},"pull_request":{"url":"https://api.github.com/repos/palantir/tslint/pulls/218","id":22215708,"html_url":"https://github.com/palantir/tslint/pull/218","diff_url":"https://github.com/palantir/tslint/pull/218.diff","patch_url":"https://github.com/palantir/tslint/pull/218.patch","issue_url":"https://api.github.com/repos/palantir/tslint/issues/218","number":218,"state":"open","locked":false,"title":"allow single line block comments","user":{"login":"fent","id":933490,"avatar_url":"https://avatars.githubusercontent.com/u/933490?v=2","gravatar_id":"","url":"https://api.github.com/users/fent","html_url":"https://github.com/fent","followers_url":"https://api.github.com/users/fent/followers","following_url":"https://api.github.com/users/fent/following{/other_user}","gists_url":"https://api.github.com/users/fent/gists{/gist_id}","starred_url":"https://api.github.com/users/fent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fent/subscriptions","organizations_url":"https://api.github.com/users/fent/orgs","repos_url":"https://api.github.com/users/fent/repos","events_url":"https://api.github.com/users/fent/events{/privacy}","received_events_url":"https://api.github.com/users/fent/received_events","type":"User","site_admin":false},"body":"Fixes #207 ","created_at":"2014-10-03T17:01:15Z","updated_at":"2014-10-03T17:27:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"05cd2f507080e23bad19518e7124a9486bb27264","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/palantir/tslint/pulls/218/commits","review_comments_url":"https://api.github.com/repos/palantir/tslint/pulls/218/comments","review_comment_url":"https://api.github.com/repos/palantir/tslint/pulls/comments/{number}","comments_url":"https://api.github.com/repos/palantir/tslint/issues/218/comments","statuses_url":"https://api.github.com/repos/palantir/tslint/statuses/1e07980420a89c27c7346d5f5d2dac901c42a8c6","head":{"label":"fent:onelinejsdoc","ref":"onelinejsdoc","sha":"1e07980420a89c27c7346d5f5d2dac901c42a8c6","user":{"login":"fent","id":933490,"avatar_url":"https://avatars.githubusercontent.com/u/933490?v=2","gravatar_id":"","url":"https://api.github.com/users/fent","html_url":"https://github.com/fent","followers_url":"https://api.github.com/users/fent/followers","following_url":"https://api.github.com/users/fent/following{/other_user}","gists_url":"https://api.github.com/users/fent/gists{/gist_id}","starred_url":"https://api.github.com/users/fent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fent/subscriptions","organizations_url":"https://api.github.com/users/fent/orgs","repos_url":"https://api.github.com/users/fent/repos","events_url":"https://api.github.com/users/fent/events{/privacy}","received_events_url":"https://api.github.com/users/fent/received_events","type":"User","site_admin":false},"repo":{"id":24656725,"name":"tslint","full_name":"fent/tslint","owner":{"login":"fent","id":933490,"avatar_url":"https://avatars.githubusercontent.com/u/933490?v=2","gravatar_id":"","url":"https://api.github.com/users/fent","html_url":"https://github.com/fent","followers_url":"https://api.github.com/users/fent/followers","following_url":"https://api.github.com/users/fent/following{/other_user}","gists_url":"https://api.github.com/users/fent/gists{/gist_id}","starred_url":"https://api.github.com/users/fent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fent/subscriptions","organizations_url":"https://api.github.com/users/fent/orgs","repos_url":"https://api.github.com/users/fent/repos","events_url":"https://api.github.com/users/fent/events{/privacy}","received_events_url":"https://api.github.com/users/fent/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fent/tslint","description":"A linter for the TypeScript language.","fork":true,"url":"https://api.github.com/repos/fent/tslint","forks_url":"https://api.github.com/repos/fent/tslint/forks","keys_url":"https://api.github.com/repos/fent/tslint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fent/tslint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fent/tslint/teams","hooks_url":"https://api.github.com/repos/fent/tslint/hooks","issue_events_url":"https://api.github.com/repos/fent/tslint/issues/events{/number}","events_url":"https://api.github.com/repos/fent/tslint/events","assignees_url":"https://api.github.com/repos/fent/tslint/assignees{/user}","branches_url":"https://api.github.com/repos/fent/tslint/branches{/branch}","tags_url":"https://api.github.com/repos/fent/tslint/tags","blobs_url":"https://api.github.com/repos/fent/tslint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fent/tslint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fent/tslint/git/refs{/sha}","trees_url":"https://api.github.com/repos/fent/tslint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fent/tslint/statuses/{sha}","languages_url":"https://api.github.com/repos/fent/tslint/languages","stargazers_url":"https://api.github.com/repos/fent/tslint/stargazers","contributors_url":"https://api.github.com/repos/fent/tslint/contributors","subscribers_url":"https://api.github.com/repos/fent/tslint/subscribers","subscription_url":"https://api.github.com/repos/fent/tslint/subscription","commits_url":"https://api.github.com/repos/fent/tslint/commits{/sha}","git_commits_url":"https://api.github.com/repos/fent/tslint/git/commits{/sha}","comments_url":"https://api.github.com/repos/fent/tslint/comments{/number}","issue_comment_url":"https://api.github.com/repos/fent/tslint/issues/comments/{number}","contents_url":"https://api.github.com/repos/fent/tslint/contents/{+path}","compare_url":"https://api.github.com/repos/fent/tslint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fent/tslint/merges","archive_url":"https://api.github.com/repos/fent/tslint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fent/tslint/downloads","issues_url":"https://api.github.com/repos/fent/tslint/issues{/number}","pulls_url":"https://api.github.com/repos/fent/tslint/pulls{/number}","milestones_url":"https://api.github.com/repos/fent/tslint/milestones{/number}","notifications_url":"https://api.github.com/repos/fent/tslint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fent/tslint/labels{/name}","releases_url":"https://api.github.com/repos/fent/tslint/releases{/id}","created_at":"2014-09-30T21:41:28Z","updated_at":"2014-09-30T02:00:34Z","pushed_at":"2014-10-03T17:00:43Z","git_url":"git://github.com/fent/tslint.git","ssh_url":"git@github.com:fent/tslint.git","clone_url":"https://github.com/fent/tslint.git","svn_url":"https://github.com/fent/tslint","homepage":null,"size":10232,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"palantir:master","ref":"master","sha":"084a914adc9165af32ccb6aa16e2ddd2d5ed0f06","user":{"login":"palantir","id":303157,"avatar_url":"https://avatars.githubusercontent.com/u/303157?v=2","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"repo":{"id":11672345,"name":"tslint","full_name":"palantir/tslint","owner":{"login":"palantir","id":303157,"avatar_url":"https://avatars.githubusercontent.com/u/303157?v=2","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/palantir/tslint","description":"A linter for the TypeScript language.","fork":false,"url":"https://api.github.com/repos/palantir/tslint","forks_url":"https://api.github.com/repos/palantir/tslint/forks","keys_url":"https://api.github.com/repos/palantir/tslint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/palantir/tslint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/palantir/tslint/teams","hooks_url":"https://api.github.com/repos/palantir/tslint/hooks","issue_events_url":"https://api.github.com/repos/palantir/tslint/issues/events{/number}","events_url":"https://api.github.com/repos/palantir/tslint/events","assignees_url":"https://api.github.com/repos/palantir/tslint/assignees{/user}","branches_url":"https://api.github.com/repos/palantir/tslint/branches{/branch}","tags_url":"https://api.github.com/repos/palantir/tslint/tags","blobs_url":"https://api.github.com/repos/palantir/tslint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/palantir/tslint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/palantir/tslint/git/refs{/sha}","trees_url":"https://api.github.com/repos/palantir/tslint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/palantir/tslint/statuses/{sha}","languages_url":"https://api.github.com/repos/palantir/tslint/languages","stargazers_url":"https://api.github.com/repos/palantir/tslint/stargazers","contributors_url":"https://api.github.com/repos/palantir/tslint/contributors","subscribers_url":"https://api.github.com/repos/palantir/tslint/subscribers","subscription_url":"https://api.github.com/repos/palantir/tslint/subscription","commits_url":"https://api.github.com/repos/palantir/tslint/commits{/sha}","git_commits_url":"https://api.github.com/repos/palantir/tslint/git/commits{/sha}","comments_url":"https://api.github.com/repos/palantir/tslint/comments{/number}","issue_comment_url":"https://api.github.com/repos/palantir/tslint/issues/comments/{number}","contents_url":"https://api.github.com/repos/palantir/tslint/contents/{+path}","compare_url":"https://api.github.com/repos/palantir/tslint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/palantir/tslint/merges","archive_url":"https://api.github.com/repos/palantir/tslint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/palantir/tslint/downloads","issues_url":"https://api.github.com/repos/palantir/tslint/issues{/number}","pulls_url":"https://api.github.com/repos/palantir/tslint/pulls{/number}","milestones_url":"https://api.github.com/repos/palantir/tslint/milestones{/number}","notifications_url":"https://api.github.com/repos/palantir/tslint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/palantir/tslint/labels{/name}","releases_url":"https://api.github.com/repos/palantir/tslint/releases{/id}","created_at":"2013-07-25T22:19:18Z","updated_at":"2014-09-30T02:00:34Z","pushed_at":"2014-10-03T16:34:52Z","git_url":"git://github.com/palantir/tslint.git","ssh_url":"git@github.com:palantir/tslint.git","clone_url":"https://github.com/palantir/tslint.git","svn_url":"https://github.com/palantir/tslint","homepage":null,"size":10232,"stargazers_count":150,"watchers_count":150,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":38,"mirror_url":null,"open_issues_count":30,"forks":38,"open_issues":30,"watchers":150,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/palantir/tslint/pulls/218"},"html":{"href":"https://github.com/palantir/tslint/pull/218"},"issue":{"href":"https://api.github.com/repos/palantir/tslint/issues/218"},"comments":{"href":"https://api.github.com/repos/palantir/tslint/issues/218/comments"},"review_comments":{"href":"https://api.github.com/repos/palantir/tslint/pulls/218/comments"},"review_comment":{"href":"https://api.github.com/repos/palantir/tslint/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/palantir/tslint/pulls/218/commits"},"statuses":{"href":"https://api.github.com/repos/palantir/tslint/statuses/1e07980420a89c27c7346d5f5d2dac901c42a8c6"}}}}