GitHub PullRequestReviewCommentEvent at 2014-03-18 16:44:05
Repository: archiving
Actor: mkyed
Payload: {"comment":{"url":"https://api.github.com/repos/firmafon/archiving/pulls/comments/10712213","id":10712213,"diff_hunk":"@@ -51,6 +51,28 @@ def with_archive(query_or_options={}, options={})\n         find_active_and_archived_by_sql(sql)\n       end\n \n+      def archive_aged_records(aged_where_sql = [\"created_at < ?\", 6.months.ago], order_sql = \"id ASC\", batch_size = 100)","path":"lib/archiving/archive_table.rb","position":4,"original_position":4,"commit_id":"c7145e482635cf897b52ee4fd184abaf486f7635","original_commit_id":"c7145e482635cf897b52ee4fd184abaf486f7635","user":{"login":"mkyed","id":445152,"avatar_url":"https://avatars.githubusercontent.com/u/445152?","gravatar_id":"2359a9a4d5dc4f8054e7613aac963d51","url":"https://api.github.com/users/mkyed","html_url":"https://github.com/mkyed","followers_url":"https://api.github.com/users/mkyed/followers","following_url":"https://api.github.com/users/mkyed/following{/other_user}","gists_url":"https://api.github.com/users/mkyed/gists{/gist_id}","starred_url":"https://api.github.com/users/mkyed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkyed/subscriptions","organizations_url":"https://api.github.com/users/mkyed/orgs","repos_url":"https://api.github.com/users/mkyed/repos","events_url":"https://api.github.com/users/mkyed/events{/privacy}","received_events_url":"https://api.github.com/users/mkyed/received_events","type":"User","site_admin":false},"body":"Tjoe, men hvordan skulle man så kalde den? Sådan noget som `Cdr::Tap.archive_aged_records(Cdr::Tab.where(\"created_at < ?\", 2.months.ago).order(:id).limit(200))`, ser lidt voldsomt ud, synes jeg. Måske bare med nogle `options` i stedet for parameterlisten?","created_at":"2014-03-18T16:44:05Z","updated_at":"2014-03-18T16:44:05Z","html_url":"https://github.com/firmafon/archiving/pull/1#discussion_r10712213","pull_request_url":"https://api.github.com/repos/firmafon/archiving/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/firmafon/archiving/pulls/comments/10712213"},"html":{"href":"https://github.com/firmafon/archiving/pull/1#discussion_r10712213"},"pull_request":{"href":"https://api.github.com/repos/firmafon/archiving/pulls/1"}}}}