GitHub PullRequestReviewCommentEvent at 2014-12-08 16:08:37
Repository: deis
Actor: bacongobbler
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/deis/deis/pulls/comments/21462561","id":21462561,"diff_hunk":"@@ -28,6 +31,13 @@ func main() {\n \n \tclient := etcd.NewClient([]string{\"http://\" + host + \":\" + etcdPort})\n \n+\tmaxmemory := \"50mb\"\n+\tresult, err := client.Get(\"/deis/cache/maxmemory\", false, false)\n+\tif err == nil {","path":"cache/image/main.go","position":28,"original_position":28,"commit_id":"a76c0cc768848bc48f7cef5235c4e9e00ef178f4","original_commit_id":"a76c0cc768848bc48f7cef5235c4e9e00ef178f4","user":{"login":"bacongobbler","id":1360539,"avatar_url":"https://avatars.githubusercontent.com/u/1360539?v=3","gravatar_id":"","url":"https://api.github.com/users/bacongobbler","html_url":"https://github.com/bacongobbler","followers_url":"https://api.github.com/users/bacongobbler/followers","following_url":"https://api.github.com/users/bacongobbler/following{/other_user}","gists_url":"https://api.github.com/users/bacongobbler/gists{/gist_id}","starred_url":"https://api.github.com/users/bacongobbler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bacongobbler/subscriptions","organizations_url":"https://api.github.com/users/bacongobbler/orgs","repos_url":"https://api.github.com/users/bacongobbler/repos","events_url":"https://api.github.com/users/bacongobbler/events{/privacy}","received_events_url":"https://api.github.com/users/bacongobbler/received_events","type":"User","site_admin":false},"body":"If you want to make sure that an error is not catched when the key is missing:\r\n\r\n```\r\nif err != nil {\r\n    if !strings.Contains(err.Error(), \"key not found\") {\r\n        // handle error\r\n    }\r\n}\r\n```\r\n\r\nI think we need that check in case there's some other issue happening here.","created_at":"2014-12-08T16:08:37Z","updated_at":"2014-12-08T16:08:37Z","html_url":"https://github.com/deis/deis/pull/1858#discussion_r21462561","pull_request_url":"https://api.github.com/repos/deis/deis/pulls/1858","_links":{"self":{"href":"https://api.github.com/repos/deis/deis/pulls/comments/21462561"},"html":{"href":"https://github.com/deis/deis/pull/1858#discussion_r21462561"},"pull_request":{"href":"https://api.github.com/repos/deis/deis/pulls/1858"}}},"pull_request":{"url":"https://api.github.com/repos/deis/deis/pulls/1858","id":21342670,"html_url":"https://github.com/deis/deis/pull/1858","diff_url":"https://github.com/deis/deis/pull/1858.diff","patch_url":"https://github.com/deis/deis/pull/1858.patch","issue_url":"https://api.github.com/repos/deis/deis/issues/1858","number":1858,"state":"open","locked":false,"title":"feat(registry): deis-cache for saving meta data","user":{"login":"johanneswuerbach","id":864578,"avatar_url":"https://avatars.githubusercontent.com/u/864578?v=3","gravatar_id":"","url":"https://api.github.com/users/johanneswuerbach","html_url":"https://github.com/johanneswuerbach","followers_url":"https://api.github.com/users/johanneswuerbach/followers","following_url":"https://api.github.com/users/johanneswuerbach/following{/other_user}","gists_url":"https://api.github.com/users/johanneswuerbach/gists{/gist_id}","starred_url":"https://api.github.com/users/johanneswuerbach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johanneswuerbach/subscriptions","organizations_url":"https://api.github.com/users/johanneswuerbach/orgs","repos_url":"https://api.github.com/users/johanneswuerbach/repos","events_url":"https://api.github.com/users/johanneswuerbach/events{/privacy}","received_events_url":"https://api.github.com/users/johanneswuerbach/received_events","type":"User","site_admin":false},"body":"This improves the registry speed with remote stores and improves the developer UX\r\n\r\nFixes #1780, fixes #1794","created_at":"2014-09-17T03:08:49Z","updated_at":"2014-12-08T16:08:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"25eb5b12cef0ec69363a3b1c3b3f14e54f1df456","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/deis/deis/pulls/1858/commits","review_comments_url":"https://api.github.com/repos/deis/deis/pulls/1858/comments","review_comment_url":"https://api.github.com/repos/deis/deis/pulls/comments/{number}","comments_url":"https://api.github.com/repos/deis/deis/issues/1858/comments","statuses_url":"https://api.github.com/repos/deis/deis/statuses/a76c0cc768848bc48f7cef5235c4e9e00ef178f4","head":{"label":"johanneswuerbach:lru-cache","ref":"lru-cache","sha":"a76c0cc768848bc48f7cef5235c4e9e00ef178f4","user":{"login":"johanneswuerbach","id":864578,"avatar_url":"https://avatars.githubusercontent.com/u/864578?v=3","gravatar_id":"","url":"https://api.github.com/users/johanneswuerbach","html_url":"https://github.com/johanneswuerbach","followers_url":"https://api.github.com/users/johanneswuerbach/followers","following_url":"https://api.github.com/users/johanneswuerbach/following{/other_user}","gists_url":"https://api.github.com/users/johanneswuerbach/gists{/gist_id}","starred_url":"https://api.github.com/users/johanneswuerbach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johanneswuerbach/subscriptions","organizations_url":"https://api.github.com/users/johanneswuerbach/orgs","repos_url":"https://api.github.com/users/johanneswuerbach/repos","events_url":"https://api.github.com/users/johanneswuerbach/events{/privacy}","received_events_url":"https://api.github.com/users/johanneswuerbach/received_events","type":"User","site_admin":false},"repo":{"id":18689654,"name":"deis","full_name":"johanneswuerbach/deis","owner":{"login":"johanneswuerbach","id":864578,"avatar_url":"https://avatars.githubusercontent.com/u/864578?v=3","gravatar_id":"","url":"https://api.github.com/users/johanneswuerbach","html_url":"https://github.com/johanneswuerbach","followers_url":"https://api.github.com/users/johanneswuerbach/followers","following_url":"https://api.github.com/users/johanneswuerbach/following{/other_user}","gists_url":"https://api.github.com/users/johanneswuerbach/gists{/gist_id}","starred_url":"https://api.github.com/users/johanneswuerbach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johanneswuerbach/subscriptions","organizations_url":"https://api.github.com/users/johanneswuerbach/orgs","repos_url":"https://api.github.com/users/johanneswuerbach/repos","events_url":"https://api.github.com/users/johanneswuerbach/events{/privacy}","received_events_url":"https://api.github.com/users/johanneswuerbach/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/johanneswuerbach/deis","description":"Your PaaS. Your Rules. ","fork":true,"url":"https://api.github.com/repos/johanneswuerbach/deis","forks_url":"https://api.github.com/repos/johanneswuerbach/deis/forks","keys_url":"https://api.github.com/repos/johanneswuerbach/deis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/johanneswuerbach/deis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/johanneswuerbach/deis/teams","hooks_url":"https://api.github.com/repos/johanneswuerbach/deis/hooks","issue_events_url":"https://api.github.com/repos/johanneswuerbach/deis/issues/events{/number}","events_url":"https://api.github.com/repos/johanneswuerbach/deis/events","assignees_url":"https://api.github.com/repos/johanneswuerbach/deis/assignees{/user}","branches_url":"https://api.github.com/repos/johanneswuerbach/deis/branches{/branch}","tags_url":"https://api.github.com/repos/johanneswuerbach/deis/tags","blobs_url":"https://api.github.com/repos/johanneswuerbach/deis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/johanneswuerbach/deis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/johanneswuerbach/deis/git/refs{/sha}","trees_url":"https://api.github.com/repos/johanneswuerbach/deis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/johanneswuerbach/deis/statuses/{sha}","languages_url":"https://api.github.com/repos/johanneswuerbach/deis/languages","stargazers_url":"https://api.github.com/repos/johanneswuerbach/deis/stargazers","contributors_url":"https://api.github.com/repos/johanneswuerbach/deis/contributors","subscribers_url":"https://api.github.com/repos/johanneswuerbach/deis/subscribers","subscription_url":"https://api.github.com/repos/johanneswuerbach/deis/subscription","commits_url":"https://api.github.com/repos/johanneswuerbach/deis/commits{/sha}","git_commits_url":"https://api.github.com/repos/johanneswuerbach/deis/git/commits{/sha}","comments_url":"https://api.github.com/repos/johanneswuerbach/deis/comments{/number}","issue_comment_url":"https://api.github.com/repos/johanneswuerbach/deis/issues/comments/{number}","contents_url":"https://api.github.com/repos/johanneswuerbach/deis/contents/{+path}","compare_url":"https://api.github.com/repos/johanneswuerbach/deis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/johanneswuerbach/deis/merges","archive_url":"https://api.github.com/repos/johanneswuerbach/deis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/johanneswuerbach/deis/downloads","issues_url":"https://api.github.com/repos/johanneswuerbach/deis/issues{/number}","pulls_url":"https://api.github.com/repos/johanneswuerbach/deis/pulls{/number}","milestones_url":"https://api.github.com/repos/johanneswuerbach/deis/milestones{/number}","notifications_url":"https://api.github.com/repos/johanneswuerbach/deis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/johanneswuerbach/deis/labels{/name}","releases_url":"https://api.github.com/repos/johanneswuerbach/deis/releases{/id}","created_at":"2014-04-11T21:41:55Z","updated_at":"2014-07-24T23:09:48Z","pushed_at":"2014-12-08T12:16:07Z","git_url":"git://github.com/johanneswuerbach/deis.git","ssh_url":"git@github.com:johanneswuerbach/deis.git","clone_url":"https://github.com/johanneswuerbach/deis.git","svn_url":"https://github.com/johanneswuerbach/deis","homepage":"http://deis.io","size":15359,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"deis:master","ref":"master","sha":"9fc24491976c0935e87b370d306c752e1915b281","user":{"login":"deis","id":6117407,"avatar_url":"https://avatars.githubusercontent.com/u/6117407?v=3","gravatar_id":"","url":"https://api.github.com/users/deis","html_url":"https://github.com/deis","followers_url":"https://api.github.com/users/deis/followers","following_url":"https://api.github.com/users/deis/following{/other_user}","gists_url":"https://api.github.com/users/deis/gists{/gist_id}","starred_url":"https://api.github.com/users/deis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deis/subscriptions","organizations_url":"https://api.github.com/users/deis/orgs","repos_url":"https://api.github.com/users/deis/repos","events_url":"https://api.github.com/users/deis/events{/privacy}","received_events_url":"https://api.github.com/users/deis/received_events","type":"Organization","site_admin":false},"repo":{"id":11589713,"name":"deis","full_name":"deis/deis","owner":{"login":"deis","id":6117407,"avatar_url":"https://avatars.githubusercontent.com/u/6117407?v=3","gravatar_id":"","url":"https://api.github.com/users/deis","html_url":"https://github.com/deis","followers_url":"https://api.github.com/users/deis/followers","following_url":"https://api.github.com/users/deis/following{/other_user}","gists_url":"https://api.github.com/users/deis/gists{/gist_id}","starred_url":"https://api.github.com/users/deis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deis/subscriptions","organizations_url":"https://api.github.com/users/deis/orgs","repos_url":"https://api.github.com/users/deis/repos","events_url":"https://api.github.com/users/deis/events{/privacy}","received_events_url":"https://api.github.com/users/deis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/deis/deis","description":"Your PaaS. Your Rules. ","fork":false,"url":"https://api.github.com/repos/deis/deis","forks_url":"https://api.github.com/repos/deis/deis/forks","keys_url":"https://api.github.com/repos/deis/deis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/deis/deis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/deis/deis/teams","hooks_url":"https://api.github.com/repos/deis/deis/hooks","issue_events_url":"https://api.github.com/repos/deis/deis/issues/events{/number}","events_url":"https://api.github.com/repos/deis/deis/events","assignees_url":"https://api.github.com/repos/deis/deis/assignees{/user}","branches_url":"https://api.github.com/repos/deis/deis/branches{/branch}","tags_url":"https://api.github.com/repos/deis/deis/tags","blobs_url":"https://api.github.com/repos/deis/deis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/deis/deis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/deis/deis/git/refs{/sha}","trees_url":"https://api.github.com/repos/deis/deis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/deis/deis/statuses/{sha}","languages_url":"https://api.github.com/repos/deis/deis/languages","stargazers_url":"https://api.github.com/repos/deis/deis/stargazers","contributors_url":"https://api.github.com/repos/deis/deis/contributors","subscribers_url":"https://api.github.com/repos/deis/deis/subscribers","subscription_url":"https://api.github.com/repos/deis/deis/subscription","commits_url":"https://api.github.com/repos/deis/deis/commits{/sha}","git_commits_url":"https://api.github.com/repos/deis/deis/git/commits{/sha}","comments_url":"https://api.github.com/repos/deis/deis/comments{/number}","issue_comment_url":"https://api.github.com/repos/deis/deis/issues/comments/{number}","contents_url":"https://api.github.com/repos/deis/deis/contents/{+path}","compare_url":"https://api.github.com/repos/deis/deis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/deis/deis/merges","archive_url":"https://api.github.com/repos/deis/deis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/deis/deis/downloads","issues_url":"https://api.github.com/repos/deis/deis/issues{/number}","pulls_url":"https://api.github.com/repos/deis/deis/pulls{/number}","milestones_url":"https://api.github.com/repos/deis/deis/milestones{/number}","notifications_url":"https://api.github.com/repos/deis/deis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/deis/deis/labels{/name}","releases_url":"https://api.github.com/repos/deis/deis/releases{/id}","created_at":"2013-07-22T19:02:40Z","updated_at":"2014-12-08T14:21:06Z","pushed_at":"2014-12-06T00:10:08Z","git_url":"git://github.com/deis/deis.git","ssh_url":"git@github.com:deis/deis.git","clone_url":"https://github.com/deis/deis.git","svn_url":"https://github.com/deis/deis","homepage":"http://deis.io","size":27923,"stargazers_count":3482,"watchers_count":3482,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":471,"mirror_url":null,"open_issues_count":200,"forks":471,"open_issues":200,"watchers":3482,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/deis/deis/pulls/1858"},"html":{"href":"https://github.com/deis/deis/pull/1858"},"issue":{"href":"https://api.github.com/repos/deis/deis/issues/1858"},"comments":{"href":"https://api.github.com/repos/deis/deis/issues/1858/comments"},"review_comments":{"href":"https://api.github.com/repos/deis/deis/pulls/1858/comments"},"review_comment":{"href":"https://api.github.com/repos/deis/deis/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/deis/deis/pulls/1858/commits"},"statuses":{"href":"https://api.github.com/repos/deis/deis/statuses/a76c0cc768848bc48f7cef5235c4e9e00ef178f4"}}}}