GitHub PushEvent at 2014-11-14 21:09:31
Repository: guides
Actor: bf4
Payload: {"shas":[["75016db79d04edec60f72b690f02923aebb4df16","994785169295d8d2d701a35241327f59d29e0d57@thoughtbot.com","Reformat links in lists to use reference style\n\n* Prevents wrapping long list items, improving readability\n* Removes the need for short URLs","Joe Ferris",false],["8b533f58341562212fa3807151d7feb4ba9efec3","994785169295d8d2d701a35241327f59d29e0d57@thoughtbot.com","Add rule avoid `any_instance` in RSpec.\n\n* `any_instance` promotes depending on concretions.\n* `any_instance` hides complexity.\n* Pure stubs promotes isolation and dependency injection.\n* Using dependency injection promotes inversion of control.","Joe Ferris",false],["2cf812d5a9a6c7705fa27fde0c2e6d04b316fb78","3c25b01657254677d3e1a8fd1f0742c5d489bd39@kylefiedler.com","Add more indepth style for Sass","Kyle Fiedler",false],["84c3bdef191afad1bf6c7189aeb97876ed0889bb","2591e5f46f28d303f9dc027d475a5c60d8dea17a@thoughtbot.com","Move Trello guide into Playbook\n\nA more recent version of this guide has been moved and edited in the\nplaybook:\n\nhttps://github.com/thoughtbot/playbook/blob/master/book/one-weeks-iteration.md\n\nRather than maintain two versions and potentially cause confusion about\nwhere to look for the process, I think we should stick to just the\nplaybook version.","Dan Croak",false],["ee95cf53fcec8c4524d3b8ecf7606dcc443c3309","2e1bc78903718fe967eef471536366f0df21a81e@thoughtbot.com","make it more clear what do do instead of protected","Chad Pytel",false],["1f577fe4a093d33607f281cab47422a05cd44590","2e1bc78903718fe967eef471536366f0df21a81e@thoughtbot.com","correct language","Chad Pytel",false],["3577108636a1e5d9fd962fe6a7e041b2b3722e20","101da2380f65b7f2bcd3a3454e7c87e88c9b5f8a@gmail.com","Refine language.\n\nWhen I read the original version I thought it was ambiguous: Should I avoid\ndefining protected methods, or calling them?","George Brocklehurst",false],["38bf539a40bd7d969b22f917a4312417c22a6efa","5dcddd8c35fdf6eb881ea4df21e8a28d2947c291@thoughtbot.com","Update the spec example to use except syntax","Jon Yurek",false],["7f6a33bef3f33885aa967bf8fcb3a306cae24ef1","a0f1490a20d0211c997b44bc357e1972deab8ae3@sikac.hu","Index foreign keys\n\nhttps://tomafro.net/2009/08/using-indexes-in-rails-index-your-associations","Prem Sichanugrist",false],["2893b30ec36435b7cbf85265ff867effeb5ad412","2591e5f46f28d303f9dc027d475a5c60d8dea17a@thoughtbot.com","Don't use instance variables in partials\n\n* It is hard to reason about the source of instance variables in\n  partials because the source is too far away.\n* Like globals, they're not given to you by your caller, and\n  maybe not even your caller's caller.\n* That makes it hard to figure out what you're changing when you change the\n  instance variable.\n* It couples the partial to the place it's first used.\n* If you use locals, then you can follow the chain all the way back.","Dan Croak",false],["754875a87643fedd244db350fda4f87f6750951e","994785169295d8d2d701a35241327f59d29e0d57@thoughtbot.com","Add guideline: avoid multiple assignments per line\n\n* Reading requires scanning back and forth across the line\n* Adding more assignments causes modifications instead of additions\n* Hides complexity\n* Easy to miss when scanning a method","Joe Ferris",false],["50458cea6210973f2c1872eca47a98d979547609","79e2475f81a6317276bf7cbb3958b20d289b78df@thoughtbot.com","Add point to avoid using semicolons in ruby","Greg Lazarev",false],["89eb58b4181b0d7e9fa2c13bf7b65789c117dd49","b1c1d8736f20db3fb6c1c66bb1455ed43909f0d8@nealke.mp","Combine testing into one heading","Neal Kemp",false],["111f7a9ca89bf2ce191763a8c54c9d89c989ef11","f145bb865a44131ac25a78f469f13a487cf15aef@gmail.com","Fix typo in ERB style item","Derek Prior",false],["64c64bfeb1af9bac0e824ebfc56e4865227b0dc9","994785169295d8d2d701a35241327f59d29e0d57@thoughtbot.com","Replace URLs that redirect with their targets\n\n* Removes short URLs\n* Makes it easier to see what you're being linked to\n* Improves readability by removing long, inline URLs","Joe Ferris",false],["4fc60c16caa9ddd5914666596cac5fbf1822d95c","88fdfb70eccc7dddffcd365167201e1286d2878b@gmail.com","Add HTML, ERB rules regarding quotes and attributes\n\nPrefer double quotes based on popular opinion and jQuery standard.","linduxed",false],["1552f4bd9ba9e0c0389aac8947721f8294d50ba5","2591e5f46f28d303f9dc027d475a5c60d8dea17a@thoughtbot.com","Review SCSS files for image-url use\n\nAs a Rails developer, I'm always looking for ways to be useful to\ndesigners during code review of their HTML/SCSS changes. This is a good\none to look for. Hat tip @jessieay.","Dan Croak",false],["f4eb3b1b544e3040b52cc60fbc6d0944d2ad5071","994785169295d8d2d701a35241327f59d29e0d57@thoughtbot.com","Add style guidelines on squashing and merging\n\n* Merge commits add noise the Git log.\n* A tree-based history is harder to follow than a linear log.\n* Encourages small, cohesive commits.","Joe Ferris",false],["4058b7ea0e1b1c0544fd798289fc3944e5071b5f","c279419393f616baa28cedf7b11242c1703ae6e2@thoughtbot.com","Separate unit/acceptance test guides\n\n* Move Acceptance Tests into their own section\n* Move Factories into their own section\n* Move Unit Tests into their own section","Harlow Ward",false],["fcf400ad2991ef1155f761ffdfd7bb62e1520aa6","d33bff83abd068f00141cdd2c95c87a11bb4083d@gmail.com","Style for dev and all environment seed data\n\n* db/seeds.rb for data needed in all envrionments\n* dev:prime rake task for dev environment seed data","Jessie A. Young",false]],"size":108,"ref":"refs/heads/master","head":"a09f1dabd71f0b0f4d3949d75b62958d0237c506"}