GitHub PullRequestReviewCommentEvent at 2014-09-19 09:10:42
Repository: message_bus
Actor: joakimk
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/SamSaffron/message_bus/pulls/comments/17775551","id":17775551,"diff_hunk":"@@ -2,6 +2,31 @@\n \n class MessageBus::ConnectionManager\n \n+  class SynchronizedSet < Set\n+\n+    def initialize\n+      super\n+      @mutex = Mutex.new\n+    end\n+\n+    alias_method :parent_add, :\"<<\"\n+    def <<(element)\n+      @mutex.synchronize do\n+        parent_add element","path":"lib/message_bus/connection_manager.rb","position":14,"original_position":14,"commit_id":"c1b33567b307e95fdc406b81db3d5eca27eadb78","original_commit_id":"c1b33567b307e95fdc406b81db3d5eca27eadb78","user":{"login":"joakimk","id":13256,"avatar_url":"https://avatars.githubusercontent.com/u/13256?v=2","gravatar_id":"df20257cb97f69a5dca8fa45cc6669da","url":"https://api.github.com/users/joakimk","html_url":"https://github.com/joakimk","followers_url":"https://api.github.com/users/joakimk/followers","following_url":"https://api.github.com/users/joakimk/following{/other_user}","gists_url":"https://api.github.com/users/joakimk/gists{/gist_id}","starred_url":"https://api.github.com/users/joakimk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joakimk/subscriptions","organizations_url":"https://api.github.com/users/joakimk/orgs","repos_url":"https://api.github.com/users/joakimk/repos","events_url":"https://api.github.com/users/joakimk/events{/privacy}","received_events_url":"https://api.github.com/users/joakimk/received_events","type":"User","site_admin":false},"body":"Would it be possible to just do `super(element)` instead of using alias_method? It's not overriding a method in place (e.g. by monkey patching) so you ought to be able to use super.","created_at":"2014-09-19T09:10:42Z","updated_at":"2014-09-19T09:10:42Z","html_url":"https://github.com/SamSaffron/message_bus/pull/19#discussion_r17775551","pull_request_url":"https://api.github.com/repos/SamSaffron/message_bus/pulls/19","_links":{"self":{"href":"https://api.github.com/repos/SamSaffron/message_bus/pulls/comments/17775551"},"html":{"href":"https://github.com/SamSaffron/message_bus/pull/19#discussion_r17775551"},"pull_request":{"href":"https://api.github.com/repos/SamSaffron/message_bus/pulls/19"}}},"pull_request":{"url":"https://api.github.com/repos/SamSaffron/message_bus/pulls/19","id":21362829,"html_url":"https://github.com/SamSaffron/message_bus/pull/19","diff_url":"https://github.com/SamSaffron/message_bus/pull/19.diff","patch_url":"https://github.com/SamSaffron/message_bus/pull/19.patch","issue_url":"https://api.github.com/repos/SamSaffron/message_bus/issues/19","number":19,"state":"closed","locked":false,"title":"Fix threading issue in ConnectionManager","user":{"login":"victorarias","id":866636,"avatar_url":"https://avatars.githubusercontent.com/u/866636?v=2","gravatar_id":"acd140ef9ef88d0b5132b380ccc5d1d7","url":"https://api.github.com/users/victorarias","html_url":"https://github.com/victorarias","followers_url":"https://api.github.com/users/victorarias/followers","following_url":"https://api.github.com/users/victorarias/following{/other_user}","gists_url":"https://api.github.com/users/victorarias/gists{/gist_id}","starred_url":"https://api.github.com/users/victorarias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/victorarias/subscriptions","organizations_url":"https://api.github.com/users/victorarias/orgs","repos_url":"https://api.github.com/users/victorarias/repos","events_url":"https://api.github.com/users/victorarias/events{/privacy}","received_events_url":"https://api.github.com/users/victorarias/received_events","type":"User","site_admin":false},"body":"As reported here: https://github.com/SamSaffron/message_bus/issues/18\r\n\r\nLet us (@tskogberg and I) know if you think this is not good enough.","created_at":"2014-09-17T12:33:16Z","updated_at":"2014-09-19T09:10:42Z","closed_at":"2014-09-19T03:45:44Z","merged_at":"2014-09-19T03:45:44Z","merge_commit_sha":"78f040d3c8054f752c470c921aa87df53b282f51","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/SamSaffron/message_bus/pulls/19/commits","review_comments_url":"https://api.github.com/repos/SamSaffron/message_bus/pulls/19/comments","review_comment_url":"https://api.github.com/repos/SamSaffron/message_bus/pulls/comments/{number}","comments_url":"https://api.github.com/repos/SamSaffron/message_bus/issues/19/comments","statuses_url":"https://api.github.com/repos/SamSaffron/message_bus/statuses/c1b33567b307e95fdc406b81db3d5eca27eadb78","head":{"label":"victorarias:master","ref":"master","sha":"c1b33567b307e95fdc406b81db3d5eca27eadb78","user":{"login":"victorarias","id":866636,"avatar_url":"https://avatars.githubusercontent.com/u/866636?v=2","gravatar_id":"acd140ef9ef88d0b5132b380ccc5d1d7","url":"https://api.github.com/users/victorarias","html_url":"https://github.com/victorarias","followers_url":"https://api.github.com/users/victorarias/followers","following_url":"https://api.github.com/users/victorarias/following{/other_user}","gists_url":"https://api.github.com/users/victorarias/gists{/gist_id}","starred_url":"https://api.github.com/users/victorarias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/victorarias/subscriptions","organizations_url":"https://api.github.com/users/victorarias/orgs","repos_url":"https://api.github.com/users/victorarias/repos","events_url":"https://api.github.com/users/victorarias/events{/privacy}","received_events_url":"https://api.github.com/users/victorarias/received_events","type":"User","site_admin":false},"repo":{"id":23627023,"name":"message_bus","full_name":"victorarias/message_bus","owner":{"login":"victorarias","id":866636,"avatar_url":"https://avatars.githubusercontent.com/u/866636?v=2","gravatar_id":"acd140ef9ef88d0b5132b380ccc5d1d7","url":"https://api.github.com/users/victorarias","html_url":"https://github.com/victorarias","followers_url":"https://api.github.com/users/victorarias/followers","following_url":"https://api.github.com/users/victorarias/following{/other_user}","gists_url":"https://api.github.com/users/victorarias/gists{/gist_id}","starred_url":"https://api.github.com/users/victorarias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/victorarias/subscriptions","organizations_url":"https://api.github.com/users/victorarias/orgs","repos_url":"https://api.github.com/users/victorarias/repos","events_url":"https://api.github.com/users/victorarias/events{/privacy}","received_events_url":"https://api.github.com/users/victorarias/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/victorarias/message_bus","description":"A reliable and robust messaging bus for Ruby and Rack","fork":true,"url":"https://api.github.com/repos/victorarias/message_bus","forks_url":"https://api.github.com/repos/victorarias/message_bus/forks","keys_url":"https://api.github.com/repos/victorarias/message_bus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/victorarias/message_bus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/victorarias/message_bus/teams","hooks_url":"https://api.github.com/repos/victorarias/message_bus/hooks","issue_events_url":"https://api.github.com/repos/victorarias/message_bus/issues/events{/number}","events_url":"https://api.github.com/repos/victorarias/message_bus/events","assignees_url":"https://api.github.com/repos/victorarias/message_bus/assignees{/user}","branches_url":"https://api.github.com/repos/victorarias/message_bus/branches{/branch}","tags_url":"https://api.github.com/repos/victorarias/message_bus/tags","blobs_url":"https://api.github.com/repos/victorarias/message_bus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/victorarias/message_bus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/victorarias/message_bus/git/refs{/sha}","trees_url":"https://api.github.com/repos/victorarias/message_bus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/victorarias/message_bus/statuses/{sha}","languages_url":"https://api.github.com/repos/victorarias/message_bus/languages","stargazers_url":"https://api.github.com/repos/victorarias/message_bus/stargazers","contributors_url":"https://api.github.com/repos/victorarias/message_bus/contributors","subscribers_url":"https://api.github.com/repos/victorarias/message_bus/subscribers","subscription_url":"https://api.github.com/repos/victorarias/message_bus/subscription","commits_url":"https://api.github.com/repos/victorarias/message_bus/commits{/sha}","git_commits_url":"https://api.github.com/repos/victorarias/message_bus/git/commits{/sha}","comments_url":"https://api.github.com/repos/victorarias/message_bus/comments{/number}","issue_comment_url":"https://api.github.com/repos/victorarias/message_bus/issues/comments/{number}","contents_url":"https://api.github.com/repos/victorarias/message_bus/contents/{+path}","compare_url":"https://api.github.com/repos/victorarias/message_bus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/victorarias/message_bus/merges","archive_url":"https://api.github.com/repos/victorarias/message_bus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/victorarias/message_bus/downloads","issues_url":"https://api.github.com/repos/victorarias/message_bus/issues{/number}","pulls_url":"https://api.github.com/repos/victorarias/message_bus/pulls{/number}","milestones_url":"https://api.github.com/repos/victorarias/message_bus/milestones{/number}","notifications_url":"https://api.github.com/repos/victorarias/message_bus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/victorarias/message_bus/labels{/name}","releases_url":"https://api.github.com/repos/victorarias/message_bus/releases{/id}","created_at":"2014-09-03T15:56:06Z","updated_at":"2014-09-03T19:42:22Z","pushed_at":"2014-09-17T15:23:41Z","git_url":"git://github.com/victorarias/message_bus.git","ssh_url":"git@github.com:victorarias/message_bus.git","clone_url":"https://github.com/victorarias/message_bus.git","svn_url":"https://github.com/victorarias/message_bus","homepage":null,"size":439,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SamSaffron:master","ref":"master","sha":"d0e576ab7837d0449b12074949c3d62ac1eccde8","user":{"login":"SamSaffron","id":5213,"avatar_url":"https://avatars.githubusercontent.com/u/5213?v=2","gravatar_id":"3dcae8378d46c244172a115c28ca49ce","url":"https://api.github.com/users/SamSaffron","html_url":"https://github.com/SamSaffron","followers_url":"https://api.github.com/users/SamSaffron/followers","following_url":"https://api.github.com/users/SamSaffron/following{/other_user}","gists_url":"https://api.github.com/users/SamSaffron/gists{/gist_id}","starred_url":"https://api.github.com/users/SamSaffron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SamSaffron/subscriptions","organizations_url":"https://api.github.com/users/SamSaffron/orgs","repos_url":"https://api.github.com/users/SamSaffron/repos","events_url":"https://api.github.com/users/SamSaffron/events{/privacy}","received_events_url":"https://api.github.com/users/SamSaffron/received_events","type":"User","site_admin":false},"repo":{"id":10071490,"name":"message_bus","full_name":"SamSaffron/message_bus","owner":{"login":"SamSaffron","id":5213,"avatar_url":"https://avatars.githubusercontent.com/u/5213?v=2","gravatar_id":"3dcae8378d46c244172a115c28ca49ce","url":"https://api.github.com/users/SamSaffron","html_url":"https://github.com/SamSaffron","followers_url":"https://api.github.com/users/SamSaffron/followers","following_url":"https://api.github.com/users/SamSaffron/following{/other_user}","gists_url":"https://api.github.com/users/SamSaffron/gists{/gist_id}","starred_url":"https://api.github.com/users/SamSaffron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SamSaffron/subscriptions","organizations_url":"https://api.github.com/users/SamSaffron/orgs","repos_url":"https://api.github.com/users/SamSaffron/repos","events_url":"https://api.github.com/users/SamSaffron/events{/privacy}","received_events_url":"https://api.github.com/users/SamSaffron/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SamSaffron/message_bus","description":"A reliable and robust messaging bus for Ruby and Rack","fork":false,"url":"https://api.github.com/repos/SamSaffron/message_bus","forks_url":"https://api.github.com/repos/SamSaffron/message_bus/forks","keys_url":"https://api.github.com/repos/SamSaffron/message_bus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SamSaffron/message_bus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SamSaffron/message_bus/teams","hooks_url":"https://api.github.com/repos/SamSaffron/message_bus/hooks","issue_events_url":"https://api.github.com/repos/SamSaffron/message_bus/issues/events{/number}","events_url":"https://api.github.com/repos/SamSaffron/message_bus/events","assignees_url":"https://api.github.com/repos/SamSaffron/message_bus/assignees{/user}","branches_url":"https://api.github.com/repos/SamSaffron/message_bus/branches{/branch}","tags_url":"https://api.github.com/repos/SamSaffron/message_bus/tags","blobs_url":"https://api.github.com/repos/SamSaffron/message_bus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SamSaffron/message_bus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SamSaffron/message_bus/git/refs{/sha}","trees_url":"https://api.github.com/repos/SamSaffron/message_bus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SamSaffron/message_bus/statuses/{sha}","languages_url":"https://api.github.com/repos/SamSaffron/message_bus/languages","stargazers_url":"https://api.github.com/repos/SamSaffron/message_bus/stargazers","contributors_url":"https://api.github.com/repos/SamSaffron/message_bus/contributors","subscribers_url":"https://api.github.com/repos/SamSaffron/message_bus/subscribers","subscription_url":"https://api.github.com/repos/SamSaffron/message_bus/subscription","commits_url":"https://api.github.com/repos/SamSaffron/message_bus/commits{/sha}","git_commits_url":"https://api.github.com/repos/SamSaffron/message_bus/git/commits{/sha}","comments_url":"https://api.github.com/repos/SamSaffron/message_bus/comments{/number}","issue_comment_url":"https://api.github.com/repos/SamSaffron/message_bus/issues/comments/{number}","contents_url":"https://api.github.com/repos/SamSaffron/message_bus/contents/{+path}","compare_url":"https://api.github.com/repos/SamSaffron/message_bus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SamSaffron/message_bus/merges","archive_url":"https://api.github.com/repos/SamSaffron/message_bus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SamSaffron/message_bus/downloads","issues_url":"https://api.github.com/repos/SamSaffron/message_bus/issues{/number}","pulls_url":"https://api.github.com/repos/SamSaffron/message_bus/pulls{/number}","milestones_url":"https://api.github.com/repos/SamSaffron/message_bus/milestones{/number}","notifications_url":"https://api.github.com/repos/SamSaffron/message_bus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SamSaffron/message_bus/labels{/name}","releases_url":"https://api.github.com/repos/SamSaffron/message_bus/releases{/id}","created_at":"2013-05-15T05:19:31Z","updated_at":"2014-09-14T17:15:05Z","pushed_at":"2014-09-19T03:45:44Z","git_url":"git://github.com/SamSaffron/message_bus.git","ssh_url":"git@github.com:SamSaffron/message_bus.git","clone_url":"https://github.com/SamSaffron/message_bus.git","svn_url":"https://github.com/SamSaffron/message_bus","homepage":null,"size":740,"stargazers_count":182,"watchers_count":182,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":7,"forks":18,"open_issues":7,"watchers":182,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SamSaffron/message_bus/pulls/19"},"html":{"href":"https://github.com/SamSaffron/message_bus/pull/19"},"issue":{"href":"https://api.github.com/repos/SamSaffron/message_bus/issues/19"},"comments":{"href":"https://api.github.com/repos/SamSaffron/message_bus/issues/19/comments"},"review_comments":{"href":"https://api.github.com/repos/SamSaffron/message_bus/pulls/19/comments"},"review_comment":{"href":"https://api.github.com/repos/SamSaffron/message_bus/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/SamSaffron/message_bus/pulls/19/commits"},"statuses":{"href":"https://api.github.com/repos/SamSaffron/message_bus/statuses/c1b33567b307e95fdc406b81db3d5eca27eadb78"}}}}