GitHub PullRequestReviewCommentEvent at 2014-04-08 00:55:02
Repository: nupic
Actor: breznak
Payload: {"comment":{"url":"https://api.github.com/repos/numenta/nupic/pulls/comments/11372631","id":11372631,"diff_hunk":"@@ -419,41 +515,27 @@ message(STATUS \"  Version: ${SWIG_VERSION}\")\n # Second, for multi-config builds (DEBUG or RELEASE, for example).\n #\n set(CMAKE_SWIG_OUTDIR \"${PYTHON_SITE_PACKAGES_DIR}/nupic/bindings\")\n-set(CMAKE_ARCHIVE_OUTPUT_DIRECTORY ${TEMP_BUILD_DIR}/lib)\n-set(CMAKE_RUNTIME_OUTPUT_DIRECTORY ${CMAKE_INSTALL_PREFIX}/bin)\n-set(CMAKE_LIBRARY_OUTPUT_DIRECTORY ${CMAKE_INSTALL_PREFIX}/lib)\n-foreach(OUTPUTCONFIG ${CMAKE_CONFIGURATION_TYPES})\n-  string(TOUPPER ${OUTPUTCONFIG} OUTPUTCONFIG)\n-  set(CMAKE_ARCHIVE_OUTPUT_DIRECTORY_${OUTPUTCONFIG} ${CMAKE_ARCHIVE_OUTPUT_DIRECTORY})\n-  set(CMAKE_RUNTIME_OUTPUT_DIRECTORY_${OUTPUTCONFIG} ${CMAKE_RUNTIME_OUTPUT_DIRECTORY})\n-  set(CMAKE_LIBRARY_OUTPUT_DIRECTORY_${OUTPUTCONFIG} ${CMAKE_LIBRARY_OUTPUT_DIRECTORY})\n-endforeach()\n \n #\n # Set environment variables of the operating system\n #\n message(STATUS \"Checking environment...\")\n message(STATUS \"Environment variables:\")\n-set_environment_variable(PATH \"${CMAKE_RUNTIME_OUTPUT_DIRECTORY}\" ON)\n+set_environment_variable(PATH \"${PROJECT_BUILD_RELEASE_DIR}/bin\" ON)\n set_environment_variable(PYTHONPATH \"${PYTHON_SITE_PACKAGES_DIR}\" OFF)","path":"CMakeLists.txt","position":491,"original_position":491,"commit_id":"f7b87068ea5e57bfd1812c1c5d51013c33be7eeb","original_commit_id":"f7b87068ea5e57bfd1812c1c5d51013c33be7eeb","user":{"login":"breznak","id":2166111,"avatar_url":"https://avatars.githubusercontent.com/u/2166111?","gravatar_id":"48e26a9725670e5f313e88c138503771","url":"https://api.github.com/users/breznak","html_url":"https://github.com/breznak","followers_url":"https://api.github.com/users/breznak/followers","following_url":"https://api.github.com/users/breznak/following{/other_user}","gists_url":"https://api.github.com/users/breznak/gists{/gist_id}","starred_url":"https://api.github.com/users/breznak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/breznak/subscriptions","organizations_url":"https://api.github.com/users/breznak/orgs","repos_url":"https://api.github.com/users/breznak/repos","events_url":"https://api.github.com/users/breznak/events{/privacy}","received_events_url":"https://api.github.com/users/breznak/received_events","type":"User","site_admin":false},"body":"> set_environment_variable(PYTHONPATH \"$ENV{PYTHONPATH}:${PYTHON_SITE_PACKAGES_DIR}\"\nOFF)\n\nYes, this is better. Or\nset_environment_variable(PYTHONPATH \"${PYTHON_SITE_PACKAGES_DIR}\" ON)\nshould do the same.\n\n\n\n> The problem is that some OS simply delete env variables after reset! Is\nnot safe we trust in \"setenv\" commands..\n\nGood catch! For cases when you build, restart, and the other day want to\nrun your CLA app.\nStill, we can autodetect PYTHONPATH this way during build, and user must\nwrite it eg to .bashrc or how OS-env is set on their machines..","created_at":"2014-04-08T00:55:02Z","updated_at":"2014-04-08T00:55:02Z","html_url":"https://github.com/numenta/nupic/pull/751#discussion_r11372631","pull_request_url":"https://api.github.com/repos/numenta/nupic/pulls/751","_links":{"self":{"href":"https://api.github.com/repos/numenta/nupic/pulls/comments/11372631"},"html":{"href":"https://github.com/numenta/nupic/pull/751#discussion_r11372631"},"pull_request":{"href":"https://api.github.com/repos/numenta/nupic/pulls/751"}}}}