GitHub PullRequestEvent at 2014-06-26 12:12:32
Repository: spring-data-commons
Actor: olivergierke
Payload: {"action":"closed","number":86,"pull_request":{"url":"https://api.github.com/repos/spring-projects/spring-data-commons/pulls/86","id":17048202,"html_url":"https://github.com/spring-projects/spring-data-commons/pull/86","diff_url":"https://github.com/spring-projects/spring-data-commons/pull/86.diff","patch_url":"https://github.com/spring-projects/spring-data-commons/pull/86.patch","issue_url":"https://api.github.com/repos/spring-projects/spring-data-commons/issues/86","number":86,"state":"closed","title":"DATACMNS-518 - Avoid potential infinite loops in PreferredConstructor.","user":{"login":"thomasdarimont","id":314690,"avatar_url":"https://avatars.githubusercontent.com/u/314690?","gravatar_id":"014bb231d48031c2974e4f723cc381b2","url":"https://api.github.com/users/thomasdarimont","html_url":"https://github.com/thomasdarimont","followers_url":"https://api.github.com/users/thomasdarimont/followers","following_url":"https://api.github.com/users/thomasdarimont/following{/other_user}","gists_url":"https://api.github.com/users/thomasdarimont/gists{/gist_id}","starred_url":"https://api.github.com/users/thomasdarimont/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomasdarimont/subscriptions","organizations_url":"https://api.github.com/users/thomasdarimont/orgs","repos_url":"https://api.github.com/users/thomasdarimont/repos","events_url":"https://api.github.com/users/thomasdarimont/events{/privacy}","received_events_url":"https://api.github.com/users/thomasdarimont/received_events","type":"User","site_admin":false},"body":"DATACMNS-518 - Spring Data Infinite Loop in HashMap in PreferredConstructor.\r\n\r\nWe now synchronise the (seldom) writes to the isPropertyParameterCache HM in PreferredConstructor via a ReadWriteLock. We could as well have used a CHM here without the need for manual locking but this would potentially waste memory for a mostly read-only data structure. We also anticipate potential multiple writes for the same property.","created_at":"2014-06-12T10:44:52Z","updated_at":"2014-06-26T12:12:32Z","closed_at":"2014-06-26T12:12:32Z","merged_at":null,"merge_commit_sha":"1456035fda9205e16e666a93bd4fae3f1c314b29","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/spring-projects/spring-data-commons/pulls/86/commits","review_comments_url":"https://api.github.com/repos/spring-projects/spring-data-commons/pulls/86/comments","review_comment_url":"https://api.github.com/repos/spring-projects/spring-data-commons/pulls/comments/{number}","comments_url":"https://api.github.com/repos/spring-projects/spring-data-commons/issues/86/comments","statuses_url":"https://api.github.com/repos/spring-projects/spring-data-commons/statuses/9b2f24dd273a14909954eb41a1397ed3a94a0dd7","head":{"label":"spring-projects:issue/DATACMNS-518","ref":"issue/DATACMNS-518","sha":"9b2f24dd273a14909954eb41a1397ed3a94a0dd7","user":{"login":"spring-projects","id":317776,"avatar_url":"https://avatars.githubusercontent.com/u/317776?","gravatar_id":"6f8a529bd100f4272a9ff1b8cdfbd26e","url":"https://api.github.com/users/spring-projects","html_url":"https://github.com/spring-projects","followers_url":"https://api.github.com/users/spring-projects/followers","following_url":"https://api.github.com/users/spring-projects/following{/other_user}","gists_url":"https://api.github.com/users/spring-projects/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-projects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-projects/subscriptions","organizations_url":"https://api.github.com/users/spring-projects/orgs","repos_url":"https://api.github.com/users/spring-projects/repos","events_url":"https://api.github.com/users/spring-projects/events{/privacy}","received_events_url":"https://api.github.com/users/spring-projects/received_events","type":"Organization","site_admin":false},"repo":{"id":1072614,"name":"spring-data-commons","full_name":"spring-projects/spring-data-commons","owner":{"login":"spring-projects","id":317776,"avatar_url":"https://avatars.githubusercontent.com/u/317776?","gravatar_id":"6f8a529bd100f4272a9ff1b8cdfbd26e","url":"https://api.github.com/users/spring-projects","html_url":"https://github.com/spring-projects","followers_url":"https://api.github.com/users/spring-projects/followers","following_url":"https://api.github.com/users/spring-projects/following{/other_user}","gists_url":"https://api.github.com/users/spring-projects/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-projects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-projects/subscriptions","organizations_url":"https://api.github.com/users/spring-projects/orgs","repos_url":"https://api.github.com/users/spring-projects/repos","events_url":"https://api.github.com/users/spring-projects/events{/privacy}","received_events_url":"https://api.github.com/users/spring-projects/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spring-projects/spring-data-commons","description":"Spring Data Commons. Interfaces and code shared between the various datastore specific implementations.","fork":false,"url":"https://api.github.com/repos/spring-projects/spring-data-commons","forks_url":"https://api.github.com/repos/spring-projects/spring-data-commons/forks","keys_url":"https://api.github.com/repos/spring-projects/spring-data-commons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spring-projects/spring-data-commons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spring-projects/spring-data-commons/teams","hooks_url":"https://api.github.com/repos/spring-projects/spring-data-commons/hooks","issue_events_url":"https://api.github.com/repos/spring-projects/spring-data-commons/issues/events{/number}","events_url":"https://api.github.com/repos/spring-projects/spring-data-commons/events","assignees_url":"https://api.github.com/repos/spring-projects/spring-data-commons/assignees{/user}","branches_url":"https://api.github.com/repos/spring-projects/spring-data-commons/branches{/branch}","tags_url":"https://api.github.com/repos/spring-projects/spring-data-commons/tags","blobs_url":"https://api.github.com/repos/spring-projects/spring-data-commons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spring-projects/spring-data-commons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spring-projects/spring-data-commons/git/refs{/sha}","trees_url":"https://api.github.com/repos/spring-projects/spring-data-commons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spring-projects/spring-data-commons/statuses/{sha}","languages_url":"https://api.github.com/repos/spring-projects/spring-data-commons/languages","stargazers_url":"https://api.github.com/repos/spring-projects/spring-data-commons/stargazers","contributors_url":"https://api.github.com/repos/spring-projects/spring-data-commons/contributors","subscribers_url":"https://api.github.com/repos/spring-projects/spring-data-commons/subscribers","subscription_url":"https://api.github.com/repos/spring-projects/spring-data-commons/subscription","commits_url":"https://api.github.com/repos/spring-projects/spring-data-commons/commits{/sha}","git_commits_url":"https://api.github.com/repos/spring-projects/spring-data-commons/git/commits{/sha}","comments_url":"https://api.github.com/repos/spring-projects/spring-data-commons/comments{/number}","issue_comment_url":"https://api.github.com/repos/spring-projects/spring-data-commons/issues/comments/{number}","contents_url":"https://api.github.com/repos/spring-projects/spring-data-commons/contents/{+path}","compare_url":"https://api.github.com/repos/spring-projects/spring-data-commons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spring-projects/spring-data-commons/merges","archive_url":"https://api.github.com/repos/spring-projects/spring-data-commons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spring-projects/spring-data-commons/downloads","issues_url":"https://api.github.com/repos/spring-projects/spring-data-commons/issues{/number}","pulls_url":"https://api.github.com/repos/spring-projects/spring-data-commons/pulls{/number}","milestones_url":"https://api.github.com/repos/spring-projects/spring-data-commons/milestones{/number}","notifications_url":"https://api.github.com/repos/spring-projects/spring-data-commons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spring-projects/spring-data-commons/labels{/name}","releases_url":"https://api.github.com/repos/spring-projects/spring-data-commons/releases{/id}","created_at":"2010-11-11T20:19:31Z","updated_at":"2014-06-26T12:11:47Z","pushed_at":"2014-06-26T12:12:32Z","git_url":"git://github.com/spring-projects/spring-data-commons.git","ssh_url":"git@github.com:spring-projects/spring-data-commons.git","clone_url":"https://github.com/spring-projects/spring-data-commons.git","svn_url":"https://github.com/spring-projects/spring-data-commons","homepage":"http://www.springsource.org/spring-data","size":13394,"stargazers_count":109,"watchers_count":109,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":89,"mirror_url":null,"open_issues_count":2,"forks":89,"open_issues":2,"watchers":109,"default_branch":"master"}},"base":{"label":"spring-projects:master","ref":"master","sha":"28b3221bcfd1f48e0c6f392e1a8a97b9d7e82f9b","user":{"login":"spring-projects","id":317776,"avatar_url":"https://avatars.githubusercontent.com/u/317776?","gravatar_id":"6f8a529bd100f4272a9ff1b8cdfbd26e","url":"https://api.github.com/users/spring-projects","html_url":"https://github.com/spring-projects","followers_url":"https://api.github.com/users/spring-projects/followers","following_url":"https://api.github.com/users/spring-projects/following{/other_user}","gists_url":"https://api.github.com/users/spring-projects/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-projects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-projects/subscriptions","organizations_url":"https://api.github.com/users/spring-projects/orgs","repos_url":"https://api.github.com/users/spring-projects/repos","events_url":"https://api.github.com/users/spring-projects/events{/privacy}","received_events_url":"https://api.github.com/users/spring-projects/received_events","type":"Organization","site_admin":false},"repo":{"id":1072614,"name":"spring-data-commons","full_name":"spring-projects/spring-data-commons","owner":{"login":"spring-projects","id":317776,"avatar_url":"https://avatars.githubusercontent.com/u/317776?","gravatar_id":"6f8a529bd100f4272a9ff1b8cdfbd26e","url":"https://api.github.com/users/spring-projects","html_url":"https://github.com/spring-projects","followers_url":"https://api.github.com/users/spring-projects/followers","following_url":"https://api.github.com/users/spring-projects/following{/other_user}","gists_url":"https://api.github.com/users/spring-projects/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-projects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-projects/subscriptions","organizations_url":"https://api.github.com/users/spring-projects/orgs","repos_url":"https://api.github.com/users/spring-projects/repos","events_url":"https://api.github.com/users/spring-projects/events{/privacy}","received_events_url":"https://api.github.com/users/spring-projects/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spring-projects/spring-data-commons","description":"Spring Data Commons. Interfaces and code shared between the various datastore specific implementations.","fork":false,"url":"https://api.github.com/repos/spring-projects/spring-data-commons","forks_url":"https://api.github.com/repos/spring-projects/spring-data-commons/forks","keys_url":"https://api.github.com/repos/spring-projects/spring-data-commons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spring-projects/spring-data-commons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spring-projects/spring-data-commons/teams","hooks_url":"https://api.github.com/repos/spring-projects/spring-data-commons/hooks","issue_events_url":"https://api.github.com/repos/spring-projects/spring-data-commons/issues/events{/number}","events_url":"https://api.github.com/repos/spring-projects/spring-data-commons/events","assignees_url":"https://api.github.com/repos/spring-projects/spring-data-commons/assignees{/user}","branches_url":"https://api.github.com/repos/spring-projects/spring-data-commons/branches{/branch}","tags_url":"https://api.github.com/repos/spring-projects/spring-data-commons/tags","blobs_url":"https://api.github.com/repos/spring-projects/spring-data-commons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spring-projects/spring-data-commons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spring-projects/spring-data-commons/git/refs{/sha}","trees_url":"https://api.github.com/repos/spring-projects/spring-data-commons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spring-projects/spring-data-commons/statuses/{sha}","languages_url":"https://api.github.com/repos/spring-projects/spring-data-commons/languages","stargazers_url":"https://api.github.com/repos/spring-projects/spring-data-commons/stargazers","contributors_url":"https://api.github.com/repos/spring-projects/spring-data-commons/contributors","subscribers_url":"https://api.github.com/repos/spring-projects/spring-data-commons/subscribers","subscription_url":"https://api.github.com/repos/spring-projects/spring-data-commons/subscription","commits_url":"https://api.github.com/repos/spring-projects/spring-data-commons/commits{/sha}","git_commits_url":"https://api.github.com/repos/spring-projects/spring-data-commons/git/commits{/sha}","comments_url":"https://api.github.com/repos/spring-projects/spring-data-commons/comments{/number}","issue_comment_url":"https://api.github.com/repos/spring-projects/spring-data-commons/issues/comments/{number}","contents_url":"https://api.github.com/repos/spring-projects/spring-data-commons/contents/{+path}","compare_url":"https://api.github.com/repos/spring-projects/spring-data-commons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spring-projects/spring-data-commons/merges","archive_url":"https://api.github.com/repos/spring-projects/spring-data-commons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spring-projects/spring-data-commons/downloads","issues_url":"https://api.github.com/repos/spring-projects/spring-data-commons/issues{/number}","pulls_url":"https://api.github.com/repos/spring-projects/spring-data-commons/pulls{/number}","milestones_url":"https://api.github.com/repos/spring-projects/spring-data-commons/milestones{/number}","notifications_url":"https://api.github.com/repos/spring-projects/spring-data-commons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spring-projects/spring-data-commons/labels{/name}","releases_url":"https://api.github.com/repos/spring-projects/spring-data-commons/releases{/id}","created_at":"2010-11-11T20:19:31Z","updated_at":"2014-06-26T12:11:47Z","pushed_at":"2014-06-26T12:12:32Z","git_url":"git://github.com/spring-projects/spring-data-commons.git","ssh_url":"git@github.com:spring-projects/spring-data-commons.git","clone_url":"https://github.com/spring-projects/spring-data-commons.git","svn_url":"https://github.com/spring-projects/spring-data-commons","homepage":"http://www.springsource.org/spring-data","size":13394,"stargazers_count":109,"watchers_count":109,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":89,"mirror_url":null,"open_issues_count":2,"forks":89,"open_issues":2,"watchers":109,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spring-projects/spring-data-commons/pulls/86"},"html":{"href":"https://github.com/spring-projects/spring-data-commons/pull/86"},"issue":{"href":"https://api.github.com/repos/spring-projects/spring-data-commons/issues/86"},"comments":{"href":"https://api.github.com/repos/spring-projects/spring-data-commons/issues/86/comments"},"review_comments":{"href":"https://api.github.com/repos/spring-projects/spring-data-commons/pulls/86/comments"},"review_comment":{"href":"https://api.github.com/repos/spring-projects/spring-data-commons/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/spring-projects/spring-data-commons/pulls/86/commits"},"statuses":{"href":"https://api.github.com/repos/spring-projects/spring-data-commons/statuses/9b2f24dd273a14909954eb41a1397ed3a94a0dd7"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":27,"deletions":12,"changed_files":2}}