GitHub PullRequestEvent at 2014-02-04 07:10:04
Repository: bootstrap-slider
Actor: j0rd
Payload: {"action":"opened","number":73,"pull_request":{"url":"https://api.github.com/repos/seiyria/bootstrap-slider/pulls/73","id":12166739,"html_url":"https://github.com/seiyria/bootstrap-slider/pull/73","diff_url":"https://github.com/seiyria/bootstrap-slider/pull/73.diff","patch_url":"https://github.com/seiyria/bootstrap-slider/pull/73.patch","issue_url":"https://api.github.com/repos/seiyria/bootstrap-slider/issues/73","number":73,"state":"open","title":"IE8 bugfix: changed use of .forEach to jQ $.each()","user":{"login":"j0rd","id":373320,"avatar_url":"https://gravatar.com/avatar/dd0d1860126279ef3441749e10dbac6b?d=https%3A%2F%2Fidenticons.github.com%2Fdf3c6f580b2e3853e93fc641212ff567.png&r=x","gravatar_id":"dd0d1860126279ef3441749e10dbac6b","url":"https://api.github.com/users/j0rd","html_url":"https://github.com/j0rd","followers_url":"https://api.github.com/users/j0rd/followers","following_url":"https://api.github.com/users/j0rd/following{/other_user}","gists_url":"https://api.github.com/users/j0rd/gists{/gist_id}","starred_url":"https://api.github.com/users/j0rd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/j0rd/subscriptions","organizations_url":"https://api.github.com/users/j0rd/orgs","repos_url":"https://api.github.com/users/j0rd/repos","events_url":"https://api.github.com/users/j0rd/events{/privacy}","received_events_url":"https://api.github.com/users/j0rd/received_events","type":"User","site_admin":false},"body":"I'm trying to do some early browser testing on some dynamic pages I'm creating which use this slider widget. Problem I found, is that the use of .forEach causes them to not work in IE8. \r\n\r\nI've changed it to jQuery each, which offers the same functionality in a more browser friendly way. \r\n\r\nI think my code could get cleaned up and avoid self...but code is here for review.","created_at":"2014-02-04T07:10:04Z","updated_at":"2014-02-04T07:10:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/seiyria/bootstrap-slider/pulls/73/commits","review_comments_url":"https://api.github.com/repos/seiyria/bootstrap-slider/pulls/73/comments","review_comment_url":"https://api.github.com/repos/seiyria/bootstrap-slider/pulls/comments/{number}","comments_url":"https://api.github.com/repos/seiyria/bootstrap-slider/issues/73/comments","statuses_url":"https://api.github.com/repos/seiyria/bootstrap-slider/statuses/e52602e03d42702e292b16a7feb215b76dd7a0cc","head":{"label":"j0rd:master","ref":"master","sha":"e52602e03d42702e292b16a7feb215b76dd7a0cc","user":{"login":"j0rd","id":373320,"avatar_url":"https://gravatar.com/avatar/dd0d1860126279ef3441749e10dbac6b?d=https%3A%2F%2Fidenticons.github.com%2Fdf3c6f580b2e3853e93fc641212ff567.png&r=x","gravatar_id":"dd0d1860126279ef3441749e10dbac6b","url":"https://api.github.com/users/j0rd","html_url":"https://github.com/j0rd","followers_url":"https://api.github.com/users/j0rd/followers","following_url":"https://api.github.com/users/j0rd/following{/other_user}","gists_url":"https://api.github.com/users/j0rd/gists{/gist_id}","starred_url":"https://api.github.com/users/j0rd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/j0rd/subscriptions","organizations_url":"https://api.github.com/users/j0rd/orgs","repos_url":"https://api.github.com/users/j0rd/repos","events_url":"https://api.github.com/users/j0rd/events{/privacy}","received_events_url":"https://api.github.com/users/j0rd/received_events","type":"User","site_admin":false},"repo":{"id":16504382,"name":"bootstrap-slider","full_name":"j0rd/bootstrap-slider","owner":{"login":"j0rd","id":373320,"avatar_url":"https://gravatar.com/avatar/dd0d1860126279ef3441749e10dbac6b?d=https%3A%2F%2Fidenticons.github.com%2Fdf3c6f580b2e3853e93fc641212ff567.png&r=x","gravatar_id":"dd0d1860126279ef3441749e10dbac6b","url":"https://api.github.com/users/j0rd","html_url":"https://github.com/j0rd","followers_url":"https://api.github.com/users/j0rd/followers","following_url":"https://api.github.com/users/j0rd/following{/other_user}","gists_url":"https://api.github.com/users/j0rd/gists{/gist_id}","starred_url":"https://api.github.com/users/j0rd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/j0rd/subscriptions","organizations_url":"https://api.github.com/users/j0rd/orgs","repos_url":"https://api.github.com/users/j0rd/repos","events_url":"https://api.github.com/users/j0rd/events{/privacy}","received_events_url":"https://api.github.com/users/j0rd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/j0rd/bootstrap-slider","description":"a \"fork\" of the original bootstrap slider found on http://www.eyecon.ro/ by Stefan Petre","fork":true,"url":"https://api.github.com/repos/j0rd/bootstrap-slider","forks_url":"https://api.github.com/repos/j0rd/bootstrap-slider/forks","keys_url":"https://api.github.com/repos/j0rd/bootstrap-slider/keys{/key_id}","collaborators_url":"https://api.github.com/repos/j0rd/bootstrap-slider/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/j0rd/bootstrap-slider/teams","hooks_url":"https://api.github.com/repos/j0rd/bootstrap-slider/hooks","issue_events_url":"https://api.github.com/repos/j0rd/bootstrap-slider/issues/events{/number}","events_url":"https://api.github.com/repos/j0rd/bootstrap-slider/events","assignees_url":"https://api.github.com/repos/j0rd/bootstrap-slider/assignees{/user}","branches_url":"https://api.github.com/repos/j0rd/bootstrap-slider/branches{/branch}","tags_url":"https://api.github.com/repos/j0rd/bootstrap-slider/tags","blobs_url":"https://api.github.com/repos/j0rd/bootstrap-slider/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/j0rd/bootstrap-slider/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/j0rd/bootstrap-slider/git/refs{/sha}","trees_url":"https://api.github.com/repos/j0rd/bootstrap-slider/git/trees{/sha}","statuses_url":"https://api.github.com/repos/j0rd/bootstrap-slider/statuses/{sha}","languages_url":"https://api.github.com/repos/j0rd/bootstrap-slider/languages","stargazers_url":"https://api.github.com/repos/j0rd/bootstrap-slider/stargazers","contributors_url":"https://api.github.com/repos/j0rd/bootstrap-slider/contributors","subscribers_url":"https://api.github.com/repos/j0rd/bootstrap-slider/subscribers","subscription_url":"https://api.github.com/repos/j0rd/bootstrap-slider/subscription","commits_url":"https://api.github.com/repos/j0rd/bootstrap-slider/commits{/sha}","git_commits_url":"https://api.github.com/repos/j0rd/bootstrap-slider/git/commits{/sha}","comments_url":"https://api.github.com/repos/j0rd/bootstrap-slider/comments{/number}","issue_comment_url":"https://api.github.com/repos/j0rd/bootstrap-slider/issues/comments/{number}","contents_url":"https://api.github.com/repos/j0rd/bootstrap-slider/contents/{+path}","compare_url":"https://api.github.com/repos/j0rd/bootstrap-slider/compare/{base}...{head}","merges_url":"https://api.github.com/repos/j0rd/bootstrap-slider/merges","archive_url":"https://api.github.com/repos/j0rd/bootstrap-slider/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/j0rd/bootstrap-slider/downloads","issues_url":"https://api.github.com/repos/j0rd/bootstrap-slider/issues{/number}","pulls_url":"https://api.github.com/repos/j0rd/bootstrap-slider/pulls{/number}","milestones_url":"https://api.github.com/repos/j0rd/bootstrap-slider/milestones{/number}","notifications_url":"https://api.github.com/repos/j0rd/bootstrap-slider/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/j0rd/bootstrap-slider/labels{/name}","releases_url":"https://api.github.com/repos/j0rd/bootstrap-slider/releases{/id}","created_at":"2014-02-04T06:40:31Z","updated_at":"2014-02-04T07:10:04Z","pushed_at":"2014-02-04T07:05:16Z","git_url":"git://github.com/j0rd/bootstrap-slider.git","ssh_url":"git@github.com:j0rd/bootstrap-slider.git","clone_url":"https://github.com/j0rd/bootstrap-slider.git","svn_url":"https://github.com/j0rd/bootstrap-slider","homepage":"http://seiyria.github.io/bootstrap-slider/","size":656,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master","master_branch":"master"}},"base":{"label":"seiyria:master","ref":"master","sha":"c54b6a81ef606974640a0148f023728feeeb0867","user":{"login":"seiyria","id":763609,"avatar_url":"https://gravatar.com/avatar/289f30e8a45f6b014b0b7c37dca9af22?d=https%3A%2F%2Fidenticons.github.com%2F3c08e2f6f90a686abcc39acfec260d2c.png&r=x","gravatar_id":"289f30e8a45f6b014b0b7c37dca9af22","url":"https://api.github.com/users/seiyria","html_url":"https://github.com/seiyria","followers_url":"https://api.github.com/users/seiyria/followers","following_url":"https://api.github.com/users/seiyria/following{/other_user}","gists_url":"https://api.github.com/users/seiyria/gists{/gist_id}","starred_url":"https://api.github.com/users/seiyria/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seiyria/subscriptions","organizations_url":"https://api.github.com/users/seiyria/orgs","repos_url":"https://api.github.com/users/seiyria/repos","events_url":"https://api.github.com/users/seiyria/events{/privacy}","received_events_url":"https://api.github.com/users/seiyria/received_events","type":"User","site_admin":false},"repo":{"id":11111023,"name":"bootstrap-slider","full_name":"seiyria/bootstrap-slider","owner":{"login":"seiyria","id":763609,"avatar_url":"https://gravatar.com/avatar/289f30e8a45f6b014b0b7c37dca9af22?d=https%3A%2F%2Fidenticons.github.com%2F3c08e2f6f90a686abcc39acfec260d2c.png&r=x","gravatar_id":"289f30e8a45f6b014b0b7c37dca9af22","url":"https://api.github.com/users/seiyria","html_url":"https://github.com/seiyria","followers_url":"https://api.github.com/users/seiyria/followers","following_url":"https://api.github.com/users/seiyria/following{/other_user}","gists_url":"https://api.github.com/users/seiyria/gists{/gist_id}","starred_url":"https://api.github.com/users/seiyria/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seiyria/subscriptions","organizations_url":"https://api.github.com/users/seiyria/orgs","repos_url":"https://api.github.com/users/seiyria/repos","events_url":"https://api.github.com/users/seiyria/events{/privacy}","received_events_url":"https://api.github.com/users/seiyria/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/seiyria/bootstrap-slider","description":"a \"fork\" of the original bootstrap slider found on http://www.eyecon.ro/ by Stefan Petre","fork":false,"url":"https://api.github.com/repos/seiyria/bootstrap-slider","forks_url":"https://api.github.com/repos/seiyria/bootstrap-slider/forks","keys_url":"https://api.github.com/repos/seiyria/bootstrap-slider/keys{/key_id}","collaborators_url":"https://api.github.com/repos/seiyria/bootstrap-slider/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/seiyria/bootstrap-slider/teams","hooks_url":"https://api.github.com/repos/seiyria/bootstrap-slider/hooks","issue_events_url":"https://api.github.com/repos/seiyria/bootstrap-slider/issues/events{/number}","events_url":"https://api.github.com/repos/seiyria/bootstrap-slider/events","assignees_url":"https://api.github.com/repos/seiyria/bootstrap-slider/assignees{/user}","branches_url":"https://api.github.com/repos/seiyria/bootstrap-slider/branches{/branch}","tags_url":"https://api.github.com/repos/seiyria/bootstrap-slider/tags","blobs_url":"https://api.github.com/repos/seiyria/bootstrap-slider/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/seiyria/bootstrap-slider/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/seiyria/bootstrap-slider/git/refs{/sha}","trees_url":"https://api.github.com/repos/seiyria/bootstrap-slider/git/trees{/sha}","statuses_url":"https://api.github.com/repos/seiyria/bootstrap-slider/statuses/{sha}","languages_url":"https://api.github.com/repos/seiyria/bootstrap-slider/languages","stargazers_url":"https://api.github.com/repos/seiyria/bootstrap-slider/stargazers","contributors_url":"https://api.github.com/repos/seiyria/bootstrap-slider/contributors","subscribers_url":"https://api.github.com/repos/seiyria/bootstrap-slider/subscribers","subscription_url":"https://api.github.com/repos/seiyria/bootstrap-slider/subscription","commits_url":"https://api.github.com/repos/seiyria/bootstrap-slider/commits{/sha}","git_commits_url":"https://api.github.com/repos/seiyria/bootstrap-slider/git/commits{/sha}","comments_url":"https://api.github.com/repos/seiyria/bootstrap-slider/comments{/number}","issue_comment_url":"https://api.github.com/repos/seiyria/bootstrap-slider/issues/comments/{number}","contents_url":"https://api.github.com/repos/seiyria/bootstrap-slider/contents/{+path}","compare_url":"https://api.github.com/repos/seiyria/bootstrap-slider/compare/{base}...{head}","merges_url":"https://api.github.com/repos/seiyria/bootstrap-slider/merges","archive_url":"https://api.github.com/repos/seiyria/bootstrap-slider/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/seiyria/bootstrap-slider/downloads","issues_url":"https://api.github.com/repos/seiyria/bootstrap-slider/issues{/number}","pulls_url":"https://api.github.com/repos/seiyria/bootstrap-slider/pulls{/number}","milestones_url":"https://api.github.com/repos/seiyria/bootstrap-slider/milestones{/number}","notifications_url":"https://api.github.com/repos/seiyria/bootstrap-slider/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/seiyria/bootstrap-slider/labels{/name}","releases_url":"https://api.github.com/repos/seiyria/bootstrap-slider/releases{/id}","created_at":"2013-07-02T00:25:54Z","updated_at":"2014-02-01T03:09:54Z","pushed_at":"2014-02-01T03:09:53Z","git_url":"git://github.com/seiyria/bootstrap-slider.git","ssh_url":"git@github.com:seiyria/bootstrap-slider.git","clone_url":"https://github.com/seiyria/bootstrap-slider.git","svn_url":"https://github.com/seiyria/bootstrap-slider","homepage":"http://seiyria.github.io/bootstrap-slider/","size":656,"stargazers_count":71,"watchers_count":71,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":44,"mirror_url":null,"open_issues_count":17,"forks":44,"open_issues":17,"watchers":71,"default_branch":"master","master_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/seiyria/bootstrap-slider/pulls/73"},"html":{"href":"https://github.com/seiyria/bootstrap-slider/pull/73"},"issue":{"href":"https://api.github.com/repos/seiyria/bootstrap-slider/issues/73"},"comments":{"href":"https://api.github.com/repos/seiyria/bootstrap-slider/issues/73/comments"},"review_comments":{"href":"https://api.github.com/repos/seiyria/bootstrap-slider/pulls/73/comments"},"review_comment":{"href":"https://api.github.com/repos/seiyria/bootstrap-slider/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/seiyria/bootstrap-slider/pulls/73/commits"},"statuses":{"href":"https://api.github.com/repos/seiyria/bootstrap-slider/statuses/e52602e03d42702e292b16a7feb215b76dd7a0cc"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":8,"deletions":7,"changed_files":1}}