GitHub PullRequestReviewCommentEvent at 2014-11-15 23:08:39
Repository: mixxx
Actor: rryan
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments/20405837","id":20405837,"diff_hunk":"@@ -60,6 +86,95 @@ DlgPrefEQ::DlgPrefEQ(QWidget* pParent, ConfigObject<ConfigValue>* pConfig)\n }\n \n DlgPrefEQ::~DlgPrefEQ() {\n+    qDeleteAll(m_deckEffectSelectors);\n+    m_deckEffectSelectors.clear();\n+\n+    int iNum = m_enableWaveformEqCOs.count();\n+    for (int i=0; i < iNum; i++) {\n+        delete (m_enableWaveformEqCOs.takeAt(0)); // Always delete element 0\n+    }\n+}\n+\n+void DlgPrefEQ::slotAddComboBox(double numDecks) {\n+    int oldDecks = m_deckEffectSelectors.size();     \n+    while (m_deckEffectSelectors.size() < static_cast<int>(numDecks)) {\n+        QHBoxLayout* innerHLayout = new QHBoxLayout();\n+        QLabel* label = new QLabel(QObject::tr(\"Deck %1\").\n+                            arg(m_deckEffectSelectors.size() + 1), this);\n+\n+        m_enableWaveformEqCOs.append(\n+                new ControlObject(ConfigKey(PlayerManager::groupForDeck(\n+                        m_deckEffectSelectors.size()), \"enableWaveformEq\")));\n+\n+        // Create the drop down list and populate it with the available effects\n+        QComboBox* box = new QComboBox(this);\n+        m_deckEffectSelectors.append(box);\n+        connect(box, SIGNAL(currentIndexChanged(int)),\n+                this, SLOT(slotEffectChangedOnDeck(int)));\n+\n+        // Setup the GUI\n+        innerHLayout->addWidget(label);\n+        innerHLayout->addWidget(box);\n+        innerHLayout->addStretch();\n+        verticalLayout_2->addLayout(innerHLayout);\n+    }\n+    slotPopulateDeckEffectSelectors(); \n+    for (int i = oldDecks; i < static_cast<int>(numDecks); ++i) {\n+        // Set the configured effect for box and simpleBox or Bessel8 LV-Mix EQ\n+        // if none is configured\n+        QString configuredEffect;\n+        int selectedEffectIndex;\n+        configuredEffect = m_pConfig->getValueString(ConfigKey(CONFIG_KEY,\n+                QString(\"EffectForDeck%1\").arg(i + 1)),\n+                QString(\"org.mixxx.effects.bessel8lvmixeq\"));\n+        selectedEffectIndex = m_deckEffectSelectors[i]->findData(configuredEffect);\n+        if (selectedEffectIndex < 0) {\n+            selectedEffectIndex = m_deckEffectSelectors[i]->findData(\"org.mixxx.effects.bessel8lvmixeq\");\n+        }\n+        m_deckEffectSelectors[i]->setCurrentIndex(selectedEffectIndex);\n+        m_enableWaveformEqCOs[i]->set(m_pEffectsManager->isEQ(\"org.mixxx.effects.bessel8lvmixeq\"));\n+    }\t\n+}\n+\n+void DlgPrefEQ::slotPopulateDeckEffectSelectors() {\n+    m_deckEffectSelectorsSetup = true; // prevents a recursive call\n+    QList<QPair<QString, QString> > availableEQEffectNames; \n+    if (CheckBoxHideEffects->isChecked()) {\n+        m_pConfig->set(ConfigKey(CONFIG_KEY, \"AdvancedView\"), QString(\"no\"));","path":"src/dlgprefeq.cpp","position":133,"original_position":133,"commit_id":"7804e3889b1b91ce438a39b07fa3dd666f04a150","original_commit_id":"7804e3889b1b91ce438a39b07fa3dd666f04a150","user":{"login":"rryan","id":26527,"avatar_url":"https://avatars.githubusercontent.com/u/26527?v=3","gravatar_id":"","url":"https://api.github.com/users/rryan","html_url":"https://github.com/rryan","followers_url":"https://api.github.com/users/rryan/followers","following_url":"https://api.github.com/users/rryan/following{/other_user}","gists_url":"https://api.github.com/users/rryan/gists{/gist_id}","starred_url":"https://api.github.com/users/rryan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rryan/subscriptions","organizations_url":"https://api.github.com/users/rryan/orgs","repos_url":"https://api.github.com/users/rryan/repos","events_url":"https://api.github.com/users/rryan/events{/privacy}","received_events_url":"https://api.github.com/users/rryan/received_events","type":"User","site_admin":false},"body":"No config changes should be made until Apply is pressed.","created_at":"2014-11-15T23:08:39Z","updated_at":"2014-11-15T23:08:39Z","html_url":"https://github.com/mixxxdj/mixxx/pull/364#discussion_r20405837","pull_request_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/364","_links":{"self":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments/20405837"},"html":{"href":"https://github.com/mixxxdj/mixxx/pull/364#discussion_r20405837"},"pull_request":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/364"}}},"pull_request":{"url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/364","id":23351391,"html_url":"https://github.com/mixxxdj/mixxx/pull/364","diff_url":"https://github.com/mixxxdj/mixxx/pull/364.diff","patch_url":"https://github.com/mixxxdj/mixxx/pull/364.patch","issue_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/364","number":364,"state":"open","locked":false,"title":"Eq rack2","user":{"login":"daschuer","id":1777442,"avatar_url":"https://avatars.githubusercontent.com/u/1777442?v=3","gravatar_id":"","url":"https://api.github.com/users/daschuer","html_url":"https://github.com/daschuer","followers_url":"https://api.github.com/users/daschuer/followers","following_url":"https://api.github.com/users/daschuer/following{/other_user}","gists_url":"https://api.github.com/users/daschuer/gists{/gist_id}","starred_url":"https://api.github.com/users/daschuer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daschuer/subscriptions","organizations_url":"https://api.github.com/users/daschuer/orgs","repos_url":"https://api.github.com/users/daschuer/repos","events_url":"https://api.github.com/users/daschuer/events{/privacy}","received_events_url":"https://api.github.com/users/daschuer/received_events","type":"User","site_admin":false},"body":"This is an updated version on Nicus EQ Rack Branch.\r\nIt enables the full power of the effect back-end for the EQ Knobs as well.\r\n\r\nYou can select which EQ should work on which deck and you can load any other effect to the EQ Slots.\r\n\r\nNext steps to merge:\r\n* Add a second Effect slot, to utilize the Filter knob / fourth band, some Controllers offer.\r\n* Add an effect chain to preferences for master EQ \r\n\r\n  ","created_at":"2014-10-26T13:55:16Z","updated_at":"2014-11-15T23:08:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f90f4d6a7050389ee60ef919885e043f45bf6522","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/364/commits","review_comments_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/364/comments","review_comment_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/364/comments","statuses_url":"https://api.github.com/repos/mixxxdj/mixxx/statuses/7804e3889b1b91ce438a39b07fa3dd666f04a150","head":{"label":"daschuer:eq_rack2","ref":"eq_rack2","sha":"7804e3889b1b91ce438a39b07fa3dd666f04a150","user":{"login":"daschuer","id":1777442,"avatar_url":"https://avatars.githubusercontent.com/u/1777442?v=3","gravatar_id":"","url":"https://api.github.com/users/daschuer","html_url":"https://github.com/daschuer","followers_url":"https://api.github.com/users/daschuer/followers","following_url":"https://api.github.com/users/daschuer/following{/other_user}","gists_url":"https://api.github.com/users/daschuer/gists{/gist_id}","starred_url":"https://api.github.com/users/daschuer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daschuer/subscriptions","organizations_url":"https://api.github.com/users/daschuer/orgs","repos_url":"https://api.github.com/users/daschuer/repos","events_url":"https://api.github.com/users/daschuer/events{/privacy}","received_events_url":"https://api.github.com/users/daschuer/received_events","type":"User","site_admin":false},"repo":{"id":10669071,"name":"mixxx","full_name":"daschuer/mixxx","owner":{"login":"daschuer","id":1777442,"avatar_url":"https://avatars.githubusercontent.com/u/1777442?v=3","gravatar_id":"","url":"https://api.github.com/users/daschuer","html_url":"https://github.com/daschuer","followers_url":"https://api.github.com/users/daschuer/followers","following_url":"https://api.github.com/users/daschuer/following{/other_user}","gists_url":"https://api.github.com/users/daschuer/gists{/gist_id}","starred_url":"https://api.github.com/users/daschuer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daschuer/subscriptions","organizations_url":"https://api.github.com/users/daschuer/orgs","repos_url":"https://api.github.com/users/daschuer/repos","events_url":"https://api.github.com/users/daschuer/events{/privacy}","received_events_url":"https://api.github.com/users/daschuer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/daschuer/mixxx","description":"Mixxx is Free DJ software that gives you everything you need to perform live mixes.","fork":true,"url":"https://api.github.com/repos/daschuer/mixxx","forks_url":"https://api.github.com/repos/daschuer/mixxx/forks","keys_url":"https://api.github.com/repos/daschuer/mixxx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/daschuer/mixxx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/daschuer/mixxx/teams","hooks_url":"https://api.github.com/repos/daschuer/mixxx/hooks","issue_events_url":"https://api.github.com/repos/daschuer/mixxx/issues/events{/number}","events_url":"https://api.github.com/repos/daschuer/mixxx/events","assignees_url":"https://api.github.com/repos/daschuer/mixxx/assignees{/user}","branches_url":"https://api.github.com/repos/daschuer/mixxx/branches{/branch}","tags_url":"https://api.github.com/repos/daschuer/mixxx/tags","blobs_url":"https://api.github.com/repos/daschuer/mixxx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/daschuer/mixxx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/daschuer/mixxx/git/refs{/sha}","trees_url":"https://api.github.com/repos/daschuer/mixxx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/daschuer/mixxx/statuses/{sha}","languages_url":"https://api.github.com/repos/daschuer/mixxx/languages","stargazers_url":"https://api.github.com/repos/daschuer/mixxx/stargazers","contributors_url":"https://api.github.com/repos/daschuer/mixxx/contributors","subscribers_url":"https://api.github.com/repos/daschuer/mixxx/subscribers","subscription_url":"https://api.github.com/repos/daschuer/mixxx/subscription","commits_url":"https://api.github.com/repos/daschuer/mixxx/commits{/sha}","git_commits_url":"https://api.github.com/repos/daschuer/mixxx/git/commits{/sha}","comments_url":"https://api.github.com/repos/daschuer/mixxx/comments{/number}","issue_comment_url":"https://api.github.com/repos/daschuer/mixxx/issues/comments/{number}","contents_url":"https://api.github.com/repos/daschuer/mixxx/contents/{+path}","compare_url":"https://api.github.com/repos/daschuer/mixxx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/daschuer/mixxx/merges","archive_url":"https://api.github.com/repos/daschuer/mixxx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/daschuer/mixxx/downloads","issues_url":"https://api.github.com/repos/daschuer/mixxx/issues{/number}","pulls_url":"https://api.github.com/repos/daschuer/mixxx/pulls{/number}","milestones_url":"https://api.github.com/repos/daschuer/mixxx/milestones{/number}","notifications_url":"https://api.github.com/repos/daschuer/mixxx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/daschuer/mixxx/labels{/name}","releases_url":"https://api.github.com/repos/daschuer/mixxx/releases{/id}","created_at":"2013-06-13T15:21:23Z","updated_at":"2014-08-08T23:24:07Z","pushed_at":"2014-11-15T22:37:00Z","git_url":"git://github.com/daschuer/mixxx.git","ssh_url":"git@github.com:daschuer/mixxx.git","clone_url":"https://github.com/daschuer/mixxx.git","svn_url":"https://github.com/daschuer/mixxx","homepage":null,"size":282045,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"mixxxdj:master","ref":"master","sha":"f841918e3145ab00cd48034e81ed4c99ef6006d4","user":{"login":"mixxxdj","id":1743769,"avatar_url":"https://avatars.githubusercontent.com/u/1743769?v=3","gravatar_id":"","url":"https://api.github.com/users/mixxxdj","html_url":"https://github.com/mixxxdj","followers_url":"https://api.github.com/users/mixxxdj/followers","following_url":"https://api.github.com/users/mixxxdj/following{/other_user}","gists_url":"https://api.github.com/users/mixxxdj/gists{/gist_id}","starred_url":"https://api.github.com/users/mixxxdj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mixxxdj/subscriptions","organizations_url":"https://api.github.com/users/mixxxdj/orgs","repos_url":"https://api.github.com/users/mixxxdj/repos","events_url":"https://api.github.com/users/mixxxdj/events{/privacy}","received_events_url":"https://api.github.com/users/mixxxdj/received_events","type":"Organization","site_admin":false},"repo":{"id":10126031,"name":"mixxx","full_name":"mixxxdj/mixxx","owner":{"login":"mixxxdj","id":1743769,"avatar_url":"https://avatars.githubusercontent.com/u/1743769?v=3","gravatar_id":"","url":"https://api.github.com/users/mixxxdj","html_url":"https://github.com/mixxxdj","followers_url":"https://api.github.com/users/mixxxdj/followers","following_url":"https://api.github.com/users/mixxxdj/following{/other_user}","gists_url":"https://api.github.com/users/mixxxdj/gists{/gist_id}","starred_url":"https://api.github.com/users/mixxxdj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mixxxdj/subscriptions","organizations_url":"https://api.github.com/users/mixxxdj/orgs","repos_url":"https://api.github.com/users/mixxxdj/repos","events_url":"https://api.github.com/users/mixxxdj/events{/privacy}","received_events_url":"https://api.github.com/users/mixxxdj/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mixxxdj/mixxx","description":"Mixxx is Free DJ software that gives you everything you need to perform live mixes.","fork":false,"url":"https://api.github.com/repos/mixxxdj/mixxx","forks_url":"https://api.github.com/repos/mixxxdj/mixxx/forks","keys_url":"https://api.github.com/repos/mixxxdj/mixxx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mixxxdj/mixxx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mixxxdj/mixxx/teams","hooks_url":"https://api.github.com/repos/mixxxdj/mixxx/hooks","issue_events_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/events{/number}","events_url":"https://api.github.com/repos/mixxxdj/mixxx/events","assignees_url":"https://api.github.com/repos/mixxxdj/mixxx/assignees{/user}","branches_url":"https://api.github.com/repos/mixxxdj/mixxx/branches{/branch}","tags_url":"https://api.github.com/repos/mixxxdj/mixxx/tags","blobs_url":"https://api.github.com/repos/mixxxdj/mixxx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mixxxdj/mixxx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mixxxdj/mixxx/git/refs{/sha}","trees_url":"https://api.github.com/repos/mixxxdj/mixxx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mixxxdj/mixxx/statuses/{sha}","languages_url":"https://api.github.com/repos/mixxxdj/mixxx/languages","stargazers_url":"https://api.github.com/repos/mixxxdj/mixxx/stargazers","contributors_url":"https://api.github.com/repos/mixxxdj/mixxx/contributors","subscribers_url":"https://api.github.com/repos/mixxxdj/mixxx/subscribers","subscription_url":"https://api.github.com/repos/mixxxdj/mixxx/subscription","commits_url":"https://api.github.com/repos/mixxxdj/mixxx/commits{/sha}","git_commits_url":"https://api.github.com/repos/mixxxdj/mixxx/git/commits{/sha}","comments_url":"https://api.github.com/repos/mixxxdj/mixxx/comments{/number}","issue_comment_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/comments/{number}","contents_url":"https://api.github.com/repos/mixxxdj/mixxx/contents/{+path}","compare_url":"https://api.github.com/repos/mixxxdj/mixxx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mixxxdj/mixxx/merges","archive_url":"https://api.github.com/repos/mixxxdj/mixxx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mixxxdj/mixxx/downloads","issues_url":"https://api.github.com/repos/mixxxdj/mixxx/issues{/number}","pulls_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls{/number}","milestones_url":"https://api.github.com/repos/mixxxdj/mixxx/milestones{/number}","notifications_url":"https://api.github.com/repos/mixxxdj/mixxx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mixxxdj/mixxx/labels{/name}","releases_url":"https://api.github.com/repos/mixxxdj/mixxx/releases{/id}","created_at":"2013-05-17T15:14:38Z","updated_at":"2014-11-12T22:37:04Z","pushed_at":"2014-11-15T22:57:13Z","git_url":"git://github.com/mixxxdj/mixxx.git","ssh_url":"git@github.com:mixxxdj/mixxx.git","clone_url":"https://github.com/mixxxdj/mixxx.git","svn_url":"https://github.com/mixxxdj/mixxx","homepage":"http://mixxx.org","size":309528,"stargazers_count":195,"watchers_count":195,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":161,"mirror_url":null,"open_issues_count":21,"forks":161,"open_issues":21,"watchers":195,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/364"},"html":{"href":"https://github.com/mixxxdj/mixxx/pull/364"},"issue":{"href":"https://api.github.com/repos/mixxxdj/mixxx/issues/364"},"comments":{"href":"https://api.github.com/repos/mixxxdj/mixxx/issues/364/comments"},"review_comments":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/364/comments"},"review_comment":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/364/commits"},"statuses":{"href":"https://api.github.com/repos/mixxxdj/mixxx/statuses/7804e3889b1b91ce438a39b07fa3dd666f04a150"}}}}