GitHub PullRequestEvent at 2014-03-04 20:42:26
Repository: dogecoin
Actor: voidref
Payload: {"action":"reopened","number":294,"pull_request":{"url":"https://api.github.com/repos/dogecoin/dogecoin/pulls/294","id":13092052,"html_url":"https://github.com/dogecoin/dogecoin/pull/294","diff_url":"https://github.com/dogecoin/dogecoin/pull/294.diff","patch_url":"https://github.com/dogecoin/dogecoin/pull/294.patch","issue_url":"https://api.github.com/repos/dogecoin/dogecoin/issues/294","number":294,"state":"open","title":"Remove restrictions on spending dust","user":{"login":"somegeekintn","id":152576,"avatar_url":"https://gravatar.com/avatar/e0154af92d9233fe5caa2925c70a7d5d?d=https%3A%2F%2Fidenticons.github.com%2F93ec56706c8200a3da15d2a5f964718d.png&r=x","gravatar_id":"e0154af92d9233fe5caa2925c70a7d5d","url":"https://api.github.com/users/somegeekintn","html_url":"https://github.com/somegeekintn","followers_url":"https://api.github.com/users/somegeekintn/followers","following_url":"https://api.github.com/users/somegeekintn/following{/other_user}","gists_url":"https://api.github.com/users/somegeekintn/gists{/gist_id}","starred_url":"https://api.github.com/users/somegeekintn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/somegeekintn/subscriptions","organizations_url":"https://api.github.com/users/somegeekintn/orgs","repos_url":"https://api.github.com/users/somegeekintn/repos","events_url":"https://api.github.com/users/somegeekintn/events{/privacy}","received_events_url":"https://api.github.com/users/somegeekintn/received_events","type":"User","site_admin":false},"body":"For background see #285\r\n\r\nI thought about quite a bit and eventually decided to submit this PR for two reasons. Primarily, the software should allow access to all of your coins whatever the amount. And also because dust should be, and is being, prevented during output creation. However, once it's been created it's actually a good thing to allow those coins to be swept into a new transaction to reduce block chain bloat / clutter (see also notes in Bitcoin 0.9.0rc2 encouraging sweeping). Basically the mininput stuff is like closing the barn door after the horse has left the stable. \r\n\r\nThese changes remove the minimum input restriction so all future transactions, regardless of the amount, are available to the user. While it is true that these coins can be recovered without this change, doing so requires the user to launch the client with miniput *and* rescan added to the command line to locate these transactions. Even with this change gaining access to old transactions that are less than 0.01 DOGE will require a rescan, but going forward all of your coins will be accessible whatever the amount.\r\n\r\nSince the changes were added to combat dust in December the number of transactions containing dust has been reduced dramatically, but they do still happen from time to time for whatever reason. When you consider that the number of people on reddit that are thrilled to receive as little as 1 DOGE it's not hard to imagine that many of the transactions are legitimate. Restricting access to amounts less than 0.01 is bound to cause some confusion and may lead users to believe the software is broken. Indeed several of us here were perplexed for a bit chasing down #285. \r\n\r\nAt a minimum I would recommend adding the change in wallet.h line 227 so all coins are at least added to the wallet without also requiring a rescan.\r\n\r\nFYI here are some things I discovered while researching this issue:\r\n\r\n* As of block 123,343: 1,210,592 outputs have been created containing amounts less than 0.01 DOGE totaling 110.02716482 DOGE.\r\n* Since adding the dust check in December that number has been dramatically reduced. Dust now appears at a rate of roughly once every 50 blocks. \r\n* Over the last 10,000 blocks: 187 outputs have been created with a value less than 0.01 DOGE totaling 0.47299720 DOGE\r\n* There may still be some issue when creating transactions where amounts less than 0.01 DOGE are not being moved into the fee as expected. This may not be the official client creating these transactions however. It's something I want to look into though.\r\n* Also some transactions are somehow being relayed without paying the necessary fees. For every output less than 0.01 the fee should increase by 1 DOGE but somehow there are transactions like this: http://dogechain.info/tx/216fecab2f47195a82defe6a76d099d40fc0e42007710344242ae5f2ae3d9025 This is also something I'd like to look into.","created_at":"2014-03-02T13:28:32Z","updated_at":"2014-03-04T20:42:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"00c42d4bc889ff26c7e0ca89eeb9033299873865","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dogecoin/dogecoin/pulls/294/commits","review_comments_url":"https://api.github.com/repos/dogecoin/dogecoin/pulls/294/comments","review_comment_url":"https://api.github.com/repos/dogecoin/dogecoin/pulls/comments/{number}","comments_url":"https://api.github.com/repos/dogecoin/dogecoin/issues/294/comments","statuses_url":"https://api.github.com/repos/dogecoin/dogecoin/statuses/c02e75ea0933165f4bafe059a12612eaeadb5d34","head":{"label":"somegeekintn:no_min","ref":"no_min","sha":"c02e75ea0933165f4bafe059a12612eaeadb5d34","user":{"login":"somegeekintn","id":152576,"avatar_url":"https://gravatar.com/avatar/e0154af92d9233fe5caa2925c70a7d5d?d=https%3A%2F%2Fidenticons.github.com%2F93ec56706c8200a3da15d2a5f964718d.png&r=x","gravatar_id":"e0154af92d9233fe5caa2925c70a7d5d","url":"https://api.github.com/users/somegeekintn","html_url":"https://github.com/somegeekintn","followers_url":"https://api.github.com/users/somegeekintn/followers","following_url":"https://api.github.com/users/somegeekintn/following{/other_user}","gists_url":"https://api.github.com/users/somegeekintn/gists{/gist_id}","starred_url":"https://api.github.com/users/somegeekintn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/somegeekintn/subscriptions","organizations_url":"https://api.github.com/users/somegeekintn/orgs","repos_url":"https://api.github.com/users/somegeekintn/repos","events_url":"https://api.github.com/users/somegeekintn/events{/privacy}","received_events_url":"https://api.github.com/users/somegeekintn/received_events","type":"User","site_admin":false},"repo":{"id":15849226,"name":"dogecoin","full_name":"somegeekintn/dogecoin","owner":{"login":"somegeekintn","id":152576,"avatar_url":"https://gravatar.com/avatar/e0154af92d9233fe5caa2925c70a7d5d?d=https%3A%2F%2Fidenticons.github.com%2F93ec56706c8200a3da15d2a5f964718d.png&r=x","gravatar_id":"e0154af92d9233fe5caa2925c70a7d5d","url":"https://api.github.com/users/somegeekintn","html_url":"https://github.com/somegeekintn","followers_url":"https://api.github.com/users/somegeekintn/followers","following_url":"https://api.github.com/users/somegeekintn/following{/other_user}","gists_url":"https://api.github.com/users/somegeekintn/gists{/gist_id}","starred_url":"https://api.github.com/users/somegeekintn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/somegeekintn/subscriptions","organizations_url":"https://api.github.com/users/somegeekintn/orgs","repos_url":"https://api.github.com/users/somegeekintn/repos","events_url":"https://api.github.com/users/somegeekintn/events{/privacy}","received_events_url":"https://api.github.com/users/somegeekintn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/somegeekintn/dogecoin","description":"very currency","fork":true,"url":"https://api.github.com/repos/somegeekintn/dogecoin","forks_url":"https://api.github.com/repos/somegeekintn/dogecoin/forks","keys_url":"https://api.github.com/repos/somegeekintn/dogecoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/somegeekintn/dogecoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/somegeekintn/dogecoin/teams","hooks_url":"https://api.github.com/repos/somegeekintn/dogecoin/hooks","issue_events_url":"https://api.github.com/repos/somegeekintn/dogecoin/issues/events{/number}","events_url":"https://api.github.com/repos/somegeekintn/dogecoin/events","assignees_url":"https://api.github.com/repos/somegeekintn/dogecoin/assignees{/user}","branches_url":"https://api.github.com/repos/somegeekintn/dogecoin/branches{/branch}","tags_url":"https://api.github.com/repos/somegeekintn/dogecoin/tags","blobs_url":"https://api.github.com/repos/somegeekintn/dogecoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/somegeekintn/dogecoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/somegeekintn/dogecoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/somegeekintn/dogecoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/somegeekintn/dogecoin/statuses/{sha}","languages_url":"https://api.github.com/repos/somegeekintn/dogecoin/languages","stargazers_url":"https://api.github.com/repos/somegeekintn/dogecoin/stargazers","contributors_url":"https://api.github.com/repos/somegeekintn/dogecoin/contributors","subscribers_url":"https://api.github.com/repos/somegeekintn/dogecoin/subscribers","subscription_url":"https://api.github.com/repos/somegeekintn/dogecoin/subscription","commits_url":"https://api.github.com/repos/somegeekintn/dogecoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/somegeekintn/dogecoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/somegeekintn/dogecoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/somegeekintn/dogecoin/issues/comments/{number}","contents_url":"https://api.github.com/repos/somegeekintn/dogecoin/contents/{+path}","compare_url":"https://api.github.com/repos/somegeekintn/dogecoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/somegeekintn/dogecoin/merges","archive_url":"https://api.github.com/repos/somegeekintn/dogecoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/somegeekintn/dogecoin/downloads","issues_url":"https://api.github.com/repos/somegeekintn/dogecoin/issues{/number}","pulls_url":"https://api.github.com/repos/somegeekintn/dogecoin/pulls{/number}","milestones_url":"https://api.github.com/repos/somegeekintn/dogecoin/milestones{/number}","notifications_url":"https://api.github.com/repos/somegeekintn/dogecoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/somegeekintn/dogecoin/labels{/name}","releases_url":"https://api.github.com/repos/somegeekintn/dogecoin/releases{/id}","created_at":"2014-01-12T19:38:23Z","updated_at":"2014-03-04T20:42:26Z","pushed_at":"2014-03-02T13:24:49Z","git_url":"git://github.com/somegeekintn/dogecoin.git","ssh_url":"git@github.com:somegeekintn/dogecoin.git","clone_url":"https://github.com/somegeekintn/dogecoin.git","svn_url":"https://github.com/somegeekintn/dogecoin","homepage":"","size":54127,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master","master_branch":"master"}},"base":{"label":"dogecoin:develop","ref":"develop","sha":"ae38c015da23e5768f6c5511306f0e75dc34fe99","user":{"login":"dogecoin","id":6122353,"avatar_url":"https://gravatar.com/avatar/00a8a64ec4ba650dce262c2cd1fd7a82?d=https%3A%2F%2Fidenticons.github.com%2F551877dbbf22eb401e16913617dc6f32.png&r=x","gravatar_id":"00a8a64ec4ba650dce262c2cd1fd7a82","url":"https://api.github.com/users/dogecoin","html_url":"https://github.com/dogecoin","followers_url":"https://api.github.com/users/dogecoin/followers","following_url":"https://api.github.com/users/dogecoin/following{/other_user}","gists_url":"https://api.github.com/users/dogecoin/gists{/gist_id}","starred_url":"https://api.github.com/users/dogecoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dogecoin/subscriptions","organizations_url":"https://api.github.com/users/dogecoin/orgs","repos_url":"https://api.github.com/users/dogecoin/repos","events_url":"https://api.github.com/users/dogecoin/events{/privacy}","received_events_url":"https://api.github.com/users/dogecoin/received_events","type":"Organization","site_admin":false},"repo":{"id":14981376,"name":"dogecoin","full_name":"dogecoin/dogecoin","owner":{"login":"dogecoin","id":6122353,"avatar_url":"https://gravatar.com/avatar/00a8a64ec4ba650dce262c2cd1fd7a82?d=https%3A%2F%2Fidenticons.github.com%2F551877dbbf22eb401e16913617dc6f32.png&r=x","gravatar_id":"00a8a64ec4ba650dce262c2cd1fd7a82","url":"https://api.github.com/users/dogecoin","html_url":"https://github.com/dogecoin","followers_url":"https://api.github.com/users/dogecoin/followers","following_url":"https://api.github.com/users/dogecoin/following{/other_user}","gists_url":"https://api.github.com/users/dogecoin/gists{/gist_id}","starred_url":"https://api.github.com/users/dogecoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dogecoin/subscriptions","organizations_url":"https://api.github.com/users/dogecoin/orgs","repos_url":"https://api.github.com/users/dogecoin/repos","events_url":"https://api.github.com/users/dogecoin/events{/privacy}","received_events_url":"https://api.github.com/users/dogecoin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dogecoin/dogecoin","description":"very currency","fork":false,"url":"https://api.github.com/repos/dogecoin/dogecoin","forks_url":"https://api.github.com/repos/dogecoin/dogecoin/forks","keys_url":"https://api.github.com/repos/dogecoin/dogecoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dogecoin/dogecoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dogecoin/dogecoin/teams","hooks_url":"https://api.github.com/repos/dogecoin/dogecoin/hooks","issue_events_url":"https://api.github.com/repos/dogecoin/dogecoin/issues/events{/number}","events_url":"https://api.github.com/repos/dogecoin/dogecoin/events","assignees_url":"https://api.github.com/repos/dogecoin/dogecoin/assignees{/user}","branches_url":"https://api.github.com/repos/dogecoin/dogecoin/branches{/branch}","tags_url":"https://api.github.com/repos/dogecoin/dogecoin/tags","blobs_url":"https://api.github.com/repos/dogecoin/dogecoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dogecoin/dogecoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dogecoin/dogecoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/dogecoin/dogecoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dogecoin/dogecoin/statuses/{sha}","languages_url":"https://api.github.com/repos/dogecoin/dogecoin/languages","stargazers_url":"https://api.github.com/repos/dogecoin/dogecoin/stargazers","contributors_url":"https://api.github.com/repos/dogecoin/dogecoin/contributors","subscribers_url":"https://api.github.com/repos/dogecoin/dogecoin/subscribers","subscription_url":"https://api.github.com/repos/dogecoin/dogecoin/subscription","commits_url":"https://api.github.com/repos/dogecoin/dogecoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/dogecoin/dogecoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/dogecoin/dogecoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/dogecoin/dogecoin/issues/comments/{number}","contents_url":"https://api.github.com/repos/dogecoin/dogecoin/contents/{+path}","compare_url":"https://api.github.com/repos/dogecoin/dogecoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dogecoin/dogecoin/merges","archive_url":"https://api.github.com/repos/dogecoin/dogecoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dogecoin/dogecoin/downloads","issues_url":"https://api.github.com/repos/dogecoin/dogecoin/issues{/number}","pulls_url":"https://api.github.com/repos/dogecoin/dogecoin/pulls{/number}","milestones_url":"https://api.github.com/repos/dogecoin/dogecoin/milestones{/number}","notifications_url":"https://api.github.com/repos/dogecoin/dogecoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dogecoin/dogecoin/labels{/name}","releases_url":"https://api.github.com/repos/dogecoin/dogecoin/releases{/id}","created_at":"2013-12-06T11:38:05Z","updated_at":"2014-03-04T11:01:35Z","pushed_at":"2014-03-04T11:01:35Z","git_url":"git://github.com/dogecoin/dogecoin.git","ssh_url":"git@github.com:dogecoin/dogecoin.git","clone_url":"https://github.com/dogecoin/dogecoin.git","svn_url":"https://github.com/dogecoin/dogecoin","homepage":"","size":72874,"stargazers_count":725,"watchers_count":725,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":296,"mirror_url":null,"open_issues_count":35,"forks":296,"open_issues":35,"watchers":725,"default_branch":"master-1.5","master_branch":"master-1.5"}},"_links":{"self":{"href":"https://api.github.com/repos/dogecoin/dogecoin/pulls/294"},"html":{"href":"https://github.com/dogecoin/dogecoin/pull/294"},"issue":{"href":"https://api.github.com/repos/dogecoin/dogecoin/issues/294"},"comments":{"href":"https://api.github.com/repos/dogecoin/dogecoin/issues/294/comments"},"review_comments":{"href":"https://api.github.com/repos/dogecoin/dogecoin/pulls/294/comments"},"review_comment":{"href":"https://api.github.com/repos/dogecoin/dogecoin/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/dogecoin/dogecoin/pulls/294/commits"},"statuses":{"href":"https://api.github.com/repos/dogecoin/dogecoin/statuses/c02e75ea0933165f4bafe059a12612eaeadb5d34"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":14,"review_comments":1,"commits":2,"additions":2,"deletions":32,"changed_files":8}}