GitHub PullRequestReviewCommentEvent at 2014-07-01 05:54:21
Repository: PFASST
Actor: torbjoernk
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/memmett/PFASST/pulls/comments/14389555","id":14389555,"diff_hunk":"@@ -30,16 +29,15 @@ class AdvectionDiffusionSweeper : public pfasst::encap::IMEXSweeper<time> {\n   double v  = 1.0;\n   time   t0 = 1.0;\n   double nu = 0.02;\n-  int    nf1evals = 0;\n+  size_t nf1evals = 0;\n \n public:\n-\n-  AdvectionDiffusionSweeper(int nvars)\n+  AdvectionDiffusionSweeper(size_t nvars)\n   {\n     ddx.resize(nvars);\n     lap.resize(nvars);\n-    for (int i=0; i<nvars; i++) {\n-      double kx = two_pi * ( i <= nvars/2 ? i : i-nvars );\n+    for(size_t i = 0; i < nvars; i++) {\n+      double kx = two_pi * ( (i <= (int)nvars/2) ? (int)i : (int)i - (int)nvars );","path":"examples/advection_diffusion/advection_diffusion_sweeper.hpp","position":25,"original_position":25,"commit_id":"add56bf87bbb7bbfdde1d7e12be688717e367338","original_commit_id":"add56bf87bbb7bbfdde1d7e12be688717e367338","user":{"login":"torbjoernk","id":1336965,"avatar_url":"https://avatars.githubusercontent.com/u/1336965?","gravatar_id":"3d12934d35da6e82ea7afc81d313cffa","url":"https://api.github.com/users/torbjoernk","html_url":"https://github.com/torbjoernk","followers_url":"https://api.github.com/users/torbjoernk/followers","following_url":"https://api.github.com/users/torbjoernk/following{/other_user}","gists_url":"https://api.github.com/users/torbjoernk/gists{/gist_id}","starred_url":"https://api.github.com/users/torbjoernk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/torbjoernk/subscriptions","organizations_url":"https://api.github.com/users/torbjoernk/orgs","repos_url":"https://api.github.com/users/torbjoernk/repos","events_url":"https://api.github.com/users/torbjoernk/events{/privacy}","received_events_url":"https://api.github.com/users/torbjoernk/received_events","type":"User","site_admin":false},"body":"You'r right, the first cast is useless. And regarding C-style cast vs. C++ constructor syntax you have a point there, too. As nobody will ever be able to compile PFASST with a plain old C compiler, we can safely use the latter.","created_at":"2014-07-01T05:54:21Z","updated_at":"2014-07-01T05:54:21Z","html_url":"https://github.com/memmett/PFASST/pull/1#discussion_r14389555","pull_request_url":"https://api.github.com/repos/memmett/PFASST/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/memmett/PFASST/pulls/comments/14389555"},"html":{"href":"https://github.com/memmett/PFASST/pull/1#discussion_r14389555"},"pull_request":{"href":"https://api.github.com/repos/memmett/PFASST/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/memmett/PFASST/pulls/1","id":17762674,"html_url":"https://github.com/memmett/PFASST/pull/1","diff_url":"https://github.com/memmett/PFASST/pull/1.diff","patch_url":"https://github.com/memmett/PFASST/pull/1.patch","issue_url":"https://api.github.com/repos/memmett/PFASST/issues/1","number":1,"state":"open","title":"finished the templates and added some further improvements","user":{"login":"torbjoernk","id":1336965,"avatar_url":"https://avatars.githubusercontent.com/u/1336965?","gravatar_id":"3d12934d35da6e82ea7afc81d313cffa","url":"https://api.github.com/users/torbjoernk","html_url":"https://github.com/torbjoernk","followers_url":"https://api.github.com/users/torbjoernk/followers","following_url":"https://api.github.com/users/torbjoernk/following{/other_user}","gists_url":"https://api.github.com/users/torbjoernk/gists{/gist_id}","starred_url":"https://api.github.com/users/torbjoernk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/torbjoernk/subscriptions","organizations_url":"https://api.github.com/users/torbjoernk/orgs","repos_url":"https://api.github.com/users/torbjoernk/repos","events_url":"https://api.github.com/users/torbjoernk/events{/privacy}","received_events_url":"https://api.github.com/users/torbjoernk/received_events","type":"User","site_admin":false},"body":"I've completed the templatization so everything compiles again.\r\n\r\nI also did some cleanup and code hardening.\r\n\r\nYou may merge these changes into your branch, update PR #18 on the main repo and merge PR #18 into the release branch.","created_at":"2014-06-30T09:11:13Z","updated_at":"2014-07-01T05:54:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e15611d5ee107acb9584e8130baba72cf7629d80","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/memmett/PFASST/pulls/1/commits","review_comments_url":"https://api.github.com/repos/memmett/PFASST/pulls/1/comments","review_comment_url":"https://api.github.com/repos/memmett/PFASST/pulls/comments/{number}","comments_url":"https://api.github.com/repos/memmett/PFASST/issues/1/comments","statuses_url":"https://api.github.com/repos/memmett/PFASST/statuses/add56bf87bbb7bbfdde1d7e12be688717e367338","head":{"label":"torbjoernk:feature/template-time","ref":"feature/template-time","sha":"add56bf87bbb7bbfdde1d7e12be688717e367338","user":{"login":"torbjoernk","id":1336965,"avatar_url":"https://avatars.githubusercontent.com/u/1336965?","gravatar_id":"3d12934d35da6e82ea7afc81d313cffa","url":"https://api.github.com/users/torbjoernk","html_url":"https://github.com/torbjoernk","followers_url":"https://api.github.com/users/torbjoernk/followers","following_url":"https://api.github.com/users/torbjoernk/following{/other_user}","gists_url":"https://api.github.com/users/torbjoernk/gists{/gist_id}","starred_url":"https://api.github.com/users/torbjoernk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/torbjoernk/subscriptions","organizations_url":"https://api.github.com/users/torbjoernk/orgs","repos_url":"https://api.github.com/users/torbjoernk/repos","events_url":"https://api.github.com/users/torbjoernk/events{/privacy}","received_events_url":"https://api.github.com/users/torbjoernk/received_events","type":"User","site_admin":false},"repo":{"id":20109754,"name":"PFASST","full_name":"torbjoernk/PFASST","owner":{"login":"torbjoernk","id":1336965,"avatar_url":"https://avatars.githubusercontent.com/u/1336965?","gravatar_id":"3d12934d35da6e82ea7afc81d313cffa","url":"https://api.github.com/users/torbjoernk","html_url":"https://github.com/torbjoernk","followers_url":"https://api.github.com/users/torbjoernk/followers","following_url":"https://api.github.com/users/torbjoernk/following{/other_user}","gists_url":"https://api.github.com/users/torbjoernk/gists{/gist_id}","starred_url":"https://api.github.com/users/torbjoernk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/torbjoernk/subscriptions","organizations_url":"https://api.github.com/users/torbjoernk/orgs","repos_url":"https://api.github.com/users/torbjoernk/repos","events_url":"https://api.github.com/users/torbjoernk/events{/privacy}","received_events_url":"https://api.github.com/users/torbjoernk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/torbjoernk/PFASST","description":"C++ PFASST","fork":true,"url":"https://api.github.com/repos/torbjoernk/PFASST","forks_url":"https://api.github.com/repos/torbjoernk/PFASST/forks","keys_url":"https://api.github.com/repos/torbjoernk/PFASST/keys{/key_id}","collaborators_url":"https://api.github.com/repos/torbjoernk/PFASST/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/torbjoernk/PFASST/teams","hooks_url":"https://api.github.com/repos/torbjoernk/PFASST/hooks","issue_events_url":"https://api.github.com/repos/torbjoernk/PFASST/issues/events{/number}","events_url":"https://api.github.com/repos/torbjoernk/PFASST/events","assignees_url":"https://api.github.com/repos/torbjoernk/PFASST/assignees{/user}","branches_url":"https://api.github.com/repos/torbjoernk/PFASST/branches{/branch}","tags_url":"https://api.github.com/repos/torbjoernk/PFASST/tags","blobs_url":"https://api.github.com/repos/torbjoernk/PFASST/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/torbjoernk/PFASST/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/torbjoernk/PFASST/git/refs{/sha}","trees_url":"https://api.github.com/repos/torbjoernk/PFASST/git/trees{/sha}","statuses_url":"https://api.github.com/repos/torbjoernk/PFASST/statuses/{sha}","languages_url":"https://api.github.com/repos/torbjoernk/PFASST/languages","stargazers_url":"https://api.github.com/repos/torbjoernk/PFASST/stargazers","contributors_url":"https://api.github.com/repos/torbjoernk/PFASST/contributors","subscribers_url":"https://api.github.com/repos/torbjoernk/PFASST/subscribers","subscription_url":"https://api.github.com/repos/torbjoernk/PFASST/subscription","commits_url":"https://api.github.com/repos/torbjoernk/PFASST/commits{/sha}","git_commits_url":"https://api.github.com/repos/torbjoernk/PFASST/git/commits{/sha}","comments_url":"https://api.github.com/repos/torbjoernk/PFASST/comments{/number}","issue_comment_url":"https://api.github.com/repos/torbjoernk/PFASST/issues/comments/{number}","contents_url":"https://api.github.com/repos/torbjoernk/PFASST/contents/{+path}","compare_url":"https://api.github.com/repos/torbjoernk/PFASST/compare/{base}...{head}","merges_url":"https://api.github.com/repos/torbjoernk/PFASST/merges","archive_url":"https://api.github.com/repos/torbjoernk/PFASST/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/torbjoernk/PFASST/downloads","issues_url":"https://api.github.com/repos/torbjoernk/PFASST/issues{/number}","pulls_url":"https://api.github.com/repos/torbjoernk/PFASST/pulls{/number}","milestones_url":"https://api.github.com/repos/torbjoernk/PFASST/milestones{/number}","notifications_url":"https://api.github.com/repos/torbjoernk/PFASST/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/torbjoernk/PFASST/labels{/name}","releases_url":"https://api.github.com/repos/torbjoernk/PFASST/releases{/id}","created_at":"2014-05-23T18:28:09Z","updated_at":"2014-06-23T18:13:36Z","pushed_at":"2014-06-30T09:08:21Z","git_url":"git://github.com/torbjoernk/PFASST.git","ssh_url":"git@github.com:torbjoernk/PFASST.git","clone_url":"https://github.com/torbjoernk/PFASST.git","svn_url":"https://github.com/torbjoernk/PFASST","homepage":null,"size":528,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"memmett:feature/template-time","ref":"feature/template-time","sha":"49c3e53488a2c042e5636ac9c254c7236649a683","user":{"login":"memmett","id":135065,"avatar_url":"https://avatars.githubusercontent.com/u/135065?","gravatar_id":"05729f0fd71ac8e41eb8b83e3a8be880","url":"https://api.github.com/users/memmett","html_url":"https://github.com/memmett","followers_url":"https://api.github.com/users/memmett/followers","following_url":"https://api.github.com/users/memmett/following{/other_user}","gists_url":"https://api.github.com/users/memmett/gists{/gist_id}","starred_url":"https://api.github.com/users/memmett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/memmett/subscriptions","organizations_url":"https://api.github.com/users/memmett/orgs","repos_url":"https://api.github.com/users/memmett/repos","events_url":"https://api.github.com/users/memmett/events{/privacy}","received_events_url":"https://api.github.com/users/memmett/received_events","type":"User","site_admin":false},"repo":{"id":21139564,"name":"PFASST","full_name":"memmett/PFASST","owner":{"login":"memmett","id":135065,"avatar_url":"https://avatars.githubusercontent.com/u/135065?","gravatar_id":"05729f0fd71ac8e41eb8b83e3a8be880","url":"https://api.github.com/users/memmett","html_url":"https://github.com/memmett","followers_url":"https://api.github.com/users/memmett/followers","following_url":"https://api.github.com/users/memmett/following{/other_user}","gists_url":"https://api.github.com/users/memmett/gists{/gist_id}","starred_url":"https://api.github.com/users/memmett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/memmett/subscriptions","organizations_url":"https://api.github.com/users/memmett/orgs","repos_url":"https://api.github.com/users/memmett/repos","events_url":"https://api.github.com/users/memmett/events{/privacy}","received_events_url":"https://api.github.com/users/memmett/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/memmett/PFASST","description":"C++ PFASST","fork":true,"url":"https://api.github.com/repos/memmett/PFASST","forks_url":"https://api.github.com/repos/memmett/PFASST/forks","keys_url":"https://api.github.com/repos/memmett/PFASST/keys{/key_id}","collaborators_url":"https://api.github.com/repos/memmett/PFASST/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/memmett/PFASST/teams","hooks_url":"https://api.github.com/repos/memmett/PFASST/hooks","issue_events_url":"https://api.github.com/repos/memmett/PFASST/issues/events{/number}","events_url":"https://api.github.com/repos/memmett/PFASST/events","assignees_url":"https://api.github.com/repos/memmett/PFASST/assignees{/user}","branches_url":"https://api.github.com/repos/memmett/PFASST/branches{/branch}","tags_url":"https://api.github.com/repos/memmett/PFASST/tags","blobs_url":"https://api.github.com/repos/memmett/PFASST/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/memmett/PFASST/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/memmett/PFASST/git/refs{/sha}","trees_url":"https://api.github.com/repos/memmett/PFASST/git/trees{/sha}","statuses_url":"https://api.github.com/repos/memmett/PFASST/statuses/{sha}","languages_url":"https://api.github.com/repos/memmett/PFASST/languages","stargazers_url":"https://api.github.com/repos/memmett/PFASST/stargazers","contributors_url":"https://api.github.com/repos/memmett/PFASST/contributors","subscribers_url":"https://api.github.com/repos/memmett/PFASST/subscribers","subscription_url":"https://api.github.com/repos/memmett/PFASST/subscription","commits_url":"https://api.github.com/repos/memmett/PFASST/commits{/sha}","git_commits_url":"https://api.github.com/repos/memmett/PFASST/git/commits{/sha}","comments_url":"https://api.github.com/repos/memmett/PFASST/comments{/number}","issue_comment_url":"https://api.github.com/repos/memmett/PFASST/issues/comments/{number}","contents_url":"https://api.github.com/repos/memmett/PFASST/contents/{+path}","compare_url":"https://api.github.com/repos/memmett/PFASST/compare/{base}...{head}","merges_url":"https://api.github.com/repos/memmett/PFASST/merges","archive_url":"https://api.github.com/repos/memmett/PFASST/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/memmett/PFASST/downloads","issues_url":"https://api.github.com/repos/memmett/PFASST/issues{/number}","pulls_url":"https://api.github.com/repos/memmett/PFASST/pulls{/number}","milestones_url":"https://api.github.com/repos/memmett/PFASST/milestones{/number}","notifications_url":"https://api.github.com/repos/memmett/PFASST/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/memmett/PFASST/labels{/name}","releases_url":"https://api.github.com/repos/memmett/PFASST/releases{/id}","created_at":"2014-06-23T19:36:28Z","updated_at":"2014-06-24T20:26:23Z","pushed_at":"2014-06-26T16:42:54Z","git_url":"git://github.com/memmett/PFASST.git","ssh_url":"git@github.com:memmett/PFASST.git","clone_url":"https://github.com/memmett/PFASST.git","svn_url":"https://github.com/memmett/PFASST","homepage":null,"size":408,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/memmett/PFASST/pulls/1"},"html":{"href":"https://github.com/memmett/PFASST/pull/1"},"issue":{"href":"https://api.github.com/repos/memmett/PFASST/issues/1"},"comments":{"href":"https://api.github.com/repos/memmett/PFASST/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/memmett/PFASST/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/memmett/PFASST/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/memmett/PFASST/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/memmett/PFASST/statuses/add56bf87bbb7bbfdde1d7e12be688717e367338"}}}}