GitHub PullRequestEvent at 2014-08-08 22:18:30
Repository: uncrustify
Actor: bengardner
Payload: {"action":"closed","number":273,"pull_request":{"url":"https://api.github.com/repos/bengardner/uncrustify/pulls/273","id":18588305,"html_url":"https://github.com/bengardner/uncrustify/pull/273","diff_url":"https://github.com/bengardner/uncrustify/pull/273.diff","patch_url":"https://github.com/bengardner/uncrustify/pull/273.patch","issue_url":"https://api.github.com/repos/bengardner/uncrustify/issues/273","number":273,"state":"closed","title":"Fix right shift (\">>\") turning into \"> >\" in C#","user":{"login":"orudge","id":7374160,"avatar_url":"https://avatars.githubusercontent.com/u/7374160?v=2","gravatar_id":"bf567719df36bf40b73a7f65e4af1770","url":"https://api.github.com/users/orudge","html_url":"https://github.com/orudge","followers_url":"https://api.github.com/users/orudge/followers","following_url":"https://api.github.com/users/orudge/following{/other_user}","gists_url":"https://api.github.com/users/orudge/gists{/gist_id}","starred_url":"https://api.github.com/users/orudge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orudge/subscriptions","organizations_url":"https://api.github.com/users/orudge/orgs","repos_url":"https://api.github.com/users/orudge/repos","events_url":"https://api.github.com/users/orudge/events{/privacy}","received_events_url":"https://api.github.com/users/orudge/received_events","type":"User","site_admin":false},"body":"I've found right shifts in C# would get converted to \"> >\", obviously breaking the code. The change to punctuators.cpp fixed this. (Left shifts were OK.)\r\n\r\nThis however caused generics to gain a space where not desired, as in:\r\n\r\nIEnumerable<Tuple<RectangleF, Point> > output;\r\n\r\nThe change to space.cpp adds an except for Java or C#, while maintaining the forced space restriction for the similar C++ construct.\r\n\r\nTests pass, but I've not done extensive testing on the changes - first time dipping into the uncrustify code, but I needed to fix this bug. :) Hope the changes are acceptable.","created_at":"2014-07-18T14:24:11Z","updated_at":"2014-08-08T22:18:30Z","closed_at":"2014-08-08T22:18:30Z","merged_at":"2014-08-08T22:18:30Z","merge_commit_sha":"028c94bf369f7f0be4cfd8b738ec1aab73f1b43f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bengardner/uncrustify/pulls/273/commits","review_comments_url":"https://api.github.com/repos/bengardner/uncrustify/pulls/273/comments","review_comment_url":"https://api.github.com/repos/bengardner/uncrustify/pulls/comments/{number}","comments_url":"https://api.github.com/repos/bengardner/uncrustify/issues/273/comments","statuses_url":"https://api.github.com/repos/bengardner/uncrustify/statuses/3111f775de155e7981aed56b6618a081e2db4767","head":{"label":"orudge:master","ref":"master","sha":"3111f775de155e7981aed56b6618a081e2db4767","user":{"login":"orudge","id":7374160,"avatar_url":"https://avatars.githubusercontent.com/u/7374160?v=2","gravatar_id":"bf567719df36bf40b73a7f65e4af1770","url":"https://api.github.com/users/orudge","html_url":"https://github.com/orudge","followers_url":"https://api.github.com/users/orudge/followers","following_url":"https://api.github.com/users/orudge/following{/other_user}","gists_url":"https://api.github.com/users/orudge/gists{/gist_id}","starred_url":"https://api.github.com/users/orudge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orudge/subscriptions","organizations_url":"https://api.github.com/users/orudge/orgs","repos_url":"https://api.github.com/users/orudge/repos","events_url":"https://api.github.com/users/orudge/events{/privacy}","received_events_url":"https://api.github.com/users/orudge/received_events","type":"User","site_admin":false},"repo":{"id":21982510,"name":"uncrustify","full_name":"orudge/uncrustify","owner":{"login":"orudge","id":7374160,"avatar_url":"https://avatars.githubusercontent.com/u/7374160?v=2","gravatar_id":"bf567719df36bf40b73a7f65e4af1770","url":"https://api.github.com/users/orudge","html_url":"https://github.com/orudge","followers_url":"https://api.github.com/users/orudge/followers","following_url":"https://api.github.com/users/orudge/following{/other_user}","gists_url":"https://api.github.com/users/orudge/gists{/gist_id}","starred_url":"https://api.github.com/users/orudge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orudge/subscriptions","organizations_url":"https://api.github.com/users/orudge/orgs","repos_url":"https://api.github.com/users/orudge/repos","events_url":"https://api.github.com/users/orudge/events{/privacy}","received_events_url":"https://api.github.com/users/orudge/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/orudge/uncrustify","description":"Code beautifier","fork":true,"url":"https://api.github.com/repos/orudge/uncrustify","forks_url":"https://api.github.com/repos/orudge/uncrustify/forks","keys_url":"https://api.github.com/repos/orudge/uncrustify/keys{/key_id}","collaborators_url":"https://api.github.com/repos/orudge/uncrustify/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/orudge/uncrustify/teams","hooks_url":"https://api.github.com/repos/orudge/uncrustify/hooks","issue_events_url":"https://api.github.com/repos/orudge/uncrustify/issues/events{/number}","events_url":"https://api.github.com/repos/orudge/uncrustify/events","assignees_url":"https://api.github.com/repos/orudge/uncrustify/assignees{/user}","branches_url":"https://api.github.com/repos/orudge/uncrustify/branches{/branch}","tags_url":"https://api.github.com/repos/orudge/uncrustify/tags","blobs_url":"https://api.github.com/repos/orudge/uncrustify/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/orudge/uncrustify/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/orudge/uncrustify/git/refs{/sha}","trees_url":"https://api.github.com/repos/orudge/uncrustify/git/trees{/sha}","statuses_url":"https://api.github.com/repos/orudge/uncrustify/statuses/{sha}","languages_url":"https://api.github.com/repos/orudge/uncrustify/languages","stargazers_url":"https://api.github.com/repos/orudge/uncrustify/stargazers","contributors_url":"https://api.github.com/repos/orudge/uncrustify/contributors","subscribers_url":"https://api.github.com/repos/orudge/uncrustify/subscribers","subscription_url":"https://api.github.com/repos/orudge/uncrustify/subscription","commits_url":"https://api.github.com/repos/orudge/uncrustify/commits{/sha}","git_commits_url":"https://api.github.com/repos/orudge/uncrustify/git/commits{/sha}","comments_url":"https://api.github.com/repos/orudge/uncrustify/comments{/number}","issue_comment_url":"https://api.github.com/repos/orudge/uncrustify/issues/comments/{number}","contents_url":"https://api.github.com/repos/orudge/uncrustify/contents/{+path}","compare_url":"https://api.github.com/repos/orudge/uncrustify/compare/{base}...{head}","merges_url":"https://api.github.com/repos/orudge/uncrustify/merges","archive_url":"https://api.github.com/repos/orudge/uncrustify/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/orudge/uncrustify/downloads","issues_url":"https://api.github.com/repos/orudge/uncrustify/issues{/number}","pulls_url":"https://api.github.com/repos/orudge/uncrustify/pulls{/number}","milestones_url":"https://api.github.com/repos/orudge/uncrustify/milestones{/number}","notifications_url":"https://api.github.com/repos/orudge/uncrustify/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/orudge/uncrustify/labels{/name}","releases_url":"https://api.github.com/repos/orudge/uncrustify/releases{/id}","created_at":"2014-07-18T14:11:39Z","updated_at":"2014-07-18T14:17:33Z","pushed_at":"2014-07-18T14:17:32Z","git_url":"git://github.com/orudge/uncrustify.git","ssh_url":"git@github.com:orudge/uncrustify.git","clone_url":"https://github.com/orudge/uncrustify.git","svn_url":"https://github.com/orudge/uncrustify","homepage":"http://uncrustify.sourceforge.net/","size":2910,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bengardner:master","ref":"master","sha":"36a0f44c54ee6301a5a208a12c08f97e59fcaa42","user":{"login":"bengardner","id":83918,"avatar_url":"https://avatars.githubusercontent.com/u/83918?v=2","gravatar_id":"1beca13bf91b22fd7e86770501e88c99","url":"https://api.github.com/users/bengardner","html_url":"https://github.com/bengardner","followers_url":"https://api.github.com/users/bengardner/followers","following_url":"https://api.github.com/users/bengardner/following{/other_user}","gists_url":"https://api.github.com/users/bengardner/gists{/gist_id}","starred_url":"https://api.github.com/users/bengardner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bengardner/subscriptions","organizations_url":"https://api.github.com/users/bengardner/orgs","repos_url":"https://api.github.com/users/bengardner/repos","events_url":"https://api.github.com/users/bengardner/events{/privacy}","received_events_url":"https://api.github.com/users/bengardner/received_events","type":"User","site_admin":false},"repo":{"id":340637,"name":"uncrustify","full_name":"bengardner/uncrustify","owner":{"login":"bengardner","id":83918,"avatar_url":"https://avatars.githubusercontent.com/u/83918?v=2","gravatar_id":"1beca13bf91b22fd7e86770501e88c99","url":"https://api.github.com/users/bengardner","html_url":"https://github.com/bengardner","followers_url":"https://api.github.com/users/bengardner/followers","following_url":"https://api.github.com/users/bengardner/following{/other_user}","gists_url":"https://api.github.com/users/bengardner/gists{/gist_id}","starred_url":"https://api.github.com/users/bengardner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bengardner/subscriptions","organizations_url":"https://api.github.com/users/bengardner/orgs","repos_url":"https://api.github.com/users/bengardner/repos","events_url":"https://api.github.com/users/bengardner/events{/privacy}","received_events_url":"https://api.github.com/users/bengardner/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bengardner/uncrustify","description":"Code beautifier","fork":false,"url":"https://api.github.com/repos/bengardner/uncrustify","forks_url":"https://api.github.com/repos/bengardner/uncrustify/forks","keys_url":"https://api.github.com/repos/bengardner/uncrustify/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bengardner/uncrustify/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bengardner/uncrustify/teams","hooks_url":"https://api.github.com/repos/bengardner/uncrustify/hooks","issue_events_url":"https://api.github.com/repos/bengardner/uncrustify/issues/events{/number}","events_url":"https://api.github.com/repos/bengardner/uncrustify/events","assignees_url":"https://api.github.com/repos/bengardner/uncrustify/assignees{/user}","branches_url":"https://api.github.com/repos/bengardner/uncrustify/branches{/branch}","tags_url":"https://api.github.com/repos/bengardner/uncrustify/tags","blobs_url":"https://api.github.com/repos/bengardner/uncrustify/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bengardner/uncrustify/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bengardner/uncrustify/git/refs{/sha}","trees_url":"https://api.github.com/repos/bengardner/uncrustify/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bengardner/uncrustify/statuses/{sha}","languages_url":"https://api.github.com/repos/bengardner/uncrustify/languages","stargazers_url":"https://api.github.com/repos/bengardner/uncrustify/stargazers","contributors_url":"https://api.github.com/repos/bengardner/uncrustify/contributors","subscribers_url":"https://api.github.com/repos/bengardner/uncrustify/subscribers","subscription_url":"https://api.github.com/repos/bengardner/uncrustify/subscription","commits_url":"https://api.github.com/repos/bengardner/uncrustify/commits{/sha}","git_commits_url":"https://api.github.com/repos/bengardner/uncrustify/git/commits{/sha}","comments_url":"https://api.github.com/repos/bengardner/uncrustify/comments{/number}","issue_comment_url":"https://api.github.com/repos/bengardner/uncrustify/issues/comments/{number}","contents_url":"https://api.github.com/repos/bengardner/uncrustify/contents/{+path}","compare_url":"https://api.github.com/repos/bengardner/uncrustify/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bengardner/uncrustify/merges","archive_url":"https://api.github.com/repos/bengardner/uncrustify/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bengardner/uncrustify/downloads","issues_url":"https://api.github.com/repos/bengardner/uncrustify/issues{/number}","pulls_url":"https://api.github.com/repos/bengardner/uncrustify/pulls{/number}","milestones_url":"https://api.github.com/repos/bengardner/uncrustify/milestones{/number}","notifications_url":"https://api.github.com/repos/bengardner/uncrustify/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bengardner/uncrustify/labels{/name}","releases_url":"https://api.github.com/repos/bengardner/uncrustify/releases{/id}","created_at":"2009-10-17T18:39:53Z","updated_at":"2014-08-07T19:24:43Z","pushed_at":"2014-08-08T22:18:30Z","git_url":"git://github.com/bengardner/uncrustify.git","ssh_url":"git@github.com:bengardner/uncrustify.git","clone_url":"https://github.com/bengardner/uncrustify.git","svn_url":"https://github.com/bengardner/uncrustify","homepage":"http://uncrustify.sourceforge.net/","size":4283,"stargazers_count":733,"watchers_count":733,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":122,"mirror_url":null,"open_issues_count":125,"forks":122,"open_issues":125,"watchers":733,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bengardner/uncrustify/pulls/273"},"html":{"href":"https://github.com/bengardner/uncrustify/pull/273"},"issue":{"href":"https://api.github.com/repos/bengardner/uncrustify/issues/273"},"comments":{"href":"https://api.github.com/repos/bengardner/uncrustify/issues/273/comments"},"review_comments":{"href":"https://api.github.com/repos/bengardner/uncrustify/pulls/273/comments"},"review_comment":{"href":"https://api.github.com/repos/bengardner/uncrustify/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/bengardner/uncrustify/pulls/273/commits"},"statuses":{"href":"https://api.github.com/repos/bengardner/uncrustify/statuses/3111f775de155e7981aed56b6618a081e2db4767"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"bengardner","id":83918,"avatar_url":"https://avatars.githubusercontent.com/u/83918?v=2","gravatar_id":"1beca13bf91b22fd7e86770501e88c99","url":"https://api.github.com/users/bengardner","html_url":"https://github.com/bengardner","followers_url":"https://api.github.com/users/bengardner/followers","following_url":"https://api.github.com/users/bengardner/following{/other_user}","gists_url":"https://api.github.com/users/bengardner/gists{/gist_id}","starred_url":"https://api.github.com/users/bengardner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bengardner/subscriptions","organizations_url":"https://api.github.com/users/bengardner/orgs","repos_url":"https://api.github.com/users/bengardner/repos","events_url":"https://api.github.com/users/bengardner/events{/privacy}","received_events_url":"https://api.github.com/users/bengardner/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":3,"deletions":3,"changed_files":2}}