GitHub PullRequestReviewCommentEvent at 2014-09-10 14:17:31
Repository: jbosstools-hibernate
Actor: fbricon
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/jbosstools/jbosstools-hibernate/pulls/comments/17363061","id":17363061,"diff_hunk":"@@ -253,7 +253,7 @@ public Properties getProjectOverrides(){\n \t@Override\n \tpublic String getHibernateVersion() {\n \t\tif (launchConfiguration.exists()){\n-\t\t\treturn getAttribute(IConsoleConfigurationLaunchConstants.HIBERNATE_VERSION, null);\n+\t\t\treturn getAttribute(IConsoleConfigurationLaunchConstants.HIBERNATE_VERSION, \"3.5\"); //$NON-NLS-1$\n \t\t}\n \t\treturn null;","path":"plugins/org.hibernate.eclipse.console/src/org/hibernate/eclipse/console/EclipseLaunchConsoleConfigurationPreferences.java","position":7,"original_position":7,"commit_id":"79b735d2eef63be426e73c74454e83c9056b00a8","original_commit_id":"79b735d2eef63be426e73c74454e83c9056b00a8","user":{"login":"fbricon","id":148698,"avatar_url":"https://avatars.githubusercontent.com/u/148698?v=2","gravatar_id":"a66008162ccd0fdceaa95ed82f4fef65","url":"https://api.github.com/users/fbricon","html_url":"https://github.com/fbricon","followers_url":"https://api.github.com/users/fbricon/followers","following_url":"https://api.github.com/users/fbricon/following{/other_user}","gists_url":"https://api.github.com/users/fbricon/gists{/gist_id}","starred_url":"https://api.github.com/users/fbricon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fbricon/subscriptions","organizations_url":"https://api.github.com/users/fbricon/orgs","repos_url":"https://api.github.com/users/fbricon/repos","events_url":"https://api.github.com/users/fbricon/events{/privacy}","received_events_url":"https://api.github.com/users/fbricon/received_events","type":"User","site_admin":false},"body":"can still return null, so caller methods would still be affected by NPEs","created_at":"2014-09-10T14:17:31Z","updated_at":"2014-09-10T14:17:31Z","html_url":"https://github.com/jbosstools/jbosstools-hibernate/pull/49#discussion_r17363061","pull_request_url":"https://api.github.com/repos/jbosstools/jbosstools-hibernate/pulls/49","_links":{"self":{"href":"https://api.github.com/repos/jbosstools/jbosstools-hibernate/pulls/comments/17363061"},"html":{"href":"https://github.com/jbosstools/jbosstools-hibernate/pull/49#discussion_r17363061"},"pull_request":{"href":"https://api.github.com/repos/jbosstools/jbosstools-hibernate/pulls/49"}}},"pull_request":{"url":"https://api.github.com/repos/jbosstools/jbosstools-hibernate/pulls/49","id":21010639,"html_url":"https://github.com/jbosstools/jbosstools-hibernate/pull/49","diff_url":"https://github.com/jbosstools/jbosstools-hibernate/pull/49.diff","patch_url":"https://github.com/jbosstools/jbosstools-hibernate/pull/49.patch","issue_url":"https://api.github.com/repos/jbosstools/jbosstools-hibernate/issues/49","number":49,"state":"open","locked":false,"title":"JBIDE-18282: NPE when expanding console configuration after creating Seam 2.3 project","user":{"login":"koentsje","id":621954,"avatar_url":"https://avatars.githubusercontent.com/u/621954?v=2","gravatar_id":"eb74d2f6c79cdffc0153896d532a7344","url":"https://api.github.com/users/koentsje","html_url":"https://github.com/koentsje","followers_url":"https://api.github.com/users/koentsje/followers","following_url":"https://api.github.com/users/koentsje/following{/other_user}","gists_url":"https://api.github.com/users/koentsje/gists{/gist_id}","starred_url":"https://api.github.com/users/koentsje/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koentsje/subscriptions","organizations_url":"https://api.github.com/users/koentsje/orgs","repos_url":"https://api.github.com/users/koentsje/repos","events_url":"https://api.github.com/users/koentsje/events{/privacy}","received_events_url":"https://api.github.com/users/koentsje/received_events","type":"User","site_admin":false},"body":"Use Hibernate 3.5 as a default when not specified","created_at":"2014-09-10T10:07:08Z","updated_at":"2014-09-10T14:17:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"66790e64513af2e860ae771449538939690155c0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jbosstools/jbosstools-hibernate/pulls/49/commits","review_comments_url":"https://api.github.com/repos/jbosstools/jbosstools-hibernate/pulls/49/comments","review_comment_url":"https://api.github.com/repos/jbosstools/jbosstools-hibernate/pulls/comments/{number}","comments_url":"https://api.github.com/repos/jbosstools/jbosstools-hibernate/issues/49/comments","statuses_url":"https://api.github.com/repos/jbosstools/jbosstools-hibernate/statuses/79b735d2eef63be426e73c74454e83c9056b00a8","head":{"label":"koentsje:JBIDE-18282","ref":"JBIDE-18282","sha":"79b735d2eef63be426e73c74454e83c9056b00a8","user":{"login":"koentsje","id":621954,"avatar_url":"https://avatars.githubusercontent.com/u/621954?v=2","gravatar_id":"eb74d2f6c79cdffc0153896d532a7344","url":"https://api.github.com/users/koentsje","html_url":"https://github.com/koentsje","followers_url":"https://api.github.com/users/koentsje/followers","following_url":"https://api.github.com/users/koentsje/following{/other_user}","gists_url":"https://api.github.com/users/koentsje/gists{/gist_id}","starred_url":"https://api.github.com/users/koentsje/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koentsje/subscriptions","organizations_url":"https://api.github.com/users/koentsje/orgs","repos_url":"https://api.github.com/users/koentsje/repos","events_url":"https://api.github.com/users/koentsje/events{/privacy}","received_events_url":"https://api.github.com/users/koentsje/received_events","type":"User","site_admin":false},"repo":{"id":6763576,"name":"jbosstools-hibernate","full_name":"koentsje/jbosstools-hibernate","owner":{"login":"koentsje","id":621954,"avatar_url":"https://avatars.githubusercontent.com/u/621954?v=2","gravatar_id":"eb74d2f6c79cdffc0153896d532a7344","url":"https://api.github.com/users/koentsje","html_url":"https://github.com/koentsje","followers_url":"https://api.github.com/users/koentsje/followers","following_url":"https://api.github.com/users/koentsje/following{/other_user}","gists_url":"https://api.github.com/users/koentsje/gists{/gist_id}","starred_url":"https://api.github.com/users/koentsje/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koentsje/subscriptions","organizations_url":"https://api.github.com/users/koentsje/orgs","repos_url":"https://api.github.com/users/koentsje/repos","events_url":"https://api.github.com/users/koentsje/events{/privacy}","received_events_url":"https://api.github.com/users/koentsje/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/koentsje/jbosstools-hibernate","description":"JBoss Tools :: Hibernate Tools { hibernatetools }","fork":true,"url":"https://api.github.com/repos/koentsje/jbosstools-hibernate","forks_url":"https://api.github.com/repos/koentsje/jbosstools-hibernate/forks","keys_url":"https://api.github.com/repos/koentsje/jbosstools-hibernate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/koentsje/jbosstools-hibernate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/koentsje/jbosstools-hibernate/teams","hooks_url":"https://api.github.com/repos/koentsje/jbosstools-hibernate/hooks","issue_events_url":"https://api.github.com/repos/koentsje/jbosstools-hibernate/issues/events{/number}","events_url":"https://api.github.com/repos/koentsje/jbosstools-hibernate/events","assignees_url":"https://api.github.com/repos/koentsje/jbosstools-hibernate/assignees{/user}","branches_url":"https://api.github.com/repos/koentsje/jbosstools-hibernate/branches{/branch}","tags_url":"https://api.github.com/repos/koentsje/jbosstools-hibernate/tags","blobs_url":"https://api.github.com/repos/koentsje/jbosstools-hibernate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/koentsje/jbosstools-hibernate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/koentsje/jbosstools-hibernate/git/refs{/sha}","trees_url":"https://api.github.com/repos/koentsje/jbosstools-hibernate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/koentsje/jbosstools-hibernate/statuses/{sha}","languages_url":"https://api.github.com/repos/koentsje/jbosstools-hibernate/languages","stargazers_url":"https://api.github.com/repos/koentsje/jbosstools-hibernate/stargazers","contributors_url":"https://api.github.com/repos/koentsje/jbosstools-hibernate/contributors","subscribers_url":"https://api.github.com/repos/koentsje/jbosstools-hibernate/subscribers","subscription_url":"https://api.github.com/repos/koentsje/jbosstools-hibernate/subscription","commits_url":"https://api.github.com/repos/koentsje/jbosstools-hibernate/commits{/sha}","git_commits_url":"https://api.github.com/repos/koentsje/jbosstools-hibernate/git/commits{/sha}","comments_url":"https://api.github.com/repos/koentsje/jbosstools-hibernate/comments{/number}","issue_comment_url":"https://api.github.com/repos/koentsje/jbosstools-hibernate/issues/comments/{number}","contents_url":"https://api.github.com/repos/koentsje/jbosstools-hibernate/contents/{+path}","compare_url":"https://api.github.com/repos/koentsje/jbosstools-hibernate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/koentsje/jbosstools-hibernate/merges","archive_url":"https://api.github.com/repos/koentsje/jbosstools-hibernate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/koentsje/jbosstools-hibernate/downloads","issues_url":"https://api.github.com/repos/koentsje/jbosstools-hibernate/issues{/number}","pulls_url":"https://api.github.com/repos/koentsje/jbosstools-hibernate/pulls{/number}","milestones_url":"https://api.github.com/repos/koentsje/jbosstools-hibernate/milestones{/number}","notifications_url":"https://api.github.com/repos/koentsje/jbosstools-hibernate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/koentsje/jbosstools-hibernate/labels{/name}","releases_url":"https://api.github.com/repos/koentsje/jbosstools-hibernate/releases{/id}","created_at":"2012-11-19T16:40:51Z","updated_at":"2014-06-25T13:43:40Z","pushed_at":"2014-09-10T10:26:43Z","git_url":"git://github.com/koentsje/jbosstools-hibernate.git","ssh_url":"git@github.com:koentsje/jbosstools-hibernate.git","clone_url":"https://github.com/koentsje/jbosstools-hibernate.git","svn_url":"https://github.com/koentsje/jbosstools-hibernate","homepage":null,"size":272525,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jbosstools:jbosstools-4.2.x","ref":"jbosstools-4.2.x","sha":"200757d568fd8f4df859fd1edf1bb14908a5274c","user":{"login":"jbosstools","id":619871,"avatar_url":"https://avatars.githubusercontent.com/u/619871?v=2","gravatar_id":"62086b897dffb44a7d078d28f84b2442","url":"https://api.github.com/users/jbosstools","html_url":"https://github.com/jbosstools","followers_url":"https://api.github.com/users/jbosstools/followers","following_url":"https://api.github.com/users/jbosstools/following{/other_user}","gists_url":"https://api.github.com/users/jbosstools/gists{/gist_id}","starred_url":"https://api.github.com/users/jbosstools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbosstools/subscriptions","organizations_url":"https://api.github.com/users/jbosstools/orgs","repos_url":"https://api.github.com/users/jbosstools/repos","events_url":"https://api.github.com/users/jbosstools/events{/privacy}","received_events_url":"https://api.github.com/users/jbosstools/received_events","type":"Organization","site_admin":false},"repo":{"id":6370964,"name":"jbosstools-hibernate","full_name":"jbosstools/jbosstools-hibernate","owner":{"login":"jbosstools","id":619871,"avatar_url":"https://avatars.githubusercontent.com/u/619871?v=2","gravatar_id":"62086b897dffb44a7d078d28f84b2442","url":"https://api.github.com/users/jbosstools","html_url":"https://github.com/jbosstools","followers_url":"https://api.github.com/users/jbosstools/followers","following_url":"https://api.github.com/users/jbosstools/following{/other_user}","gists_url":"https://api.github.com/users/jbosstools/gists{/gist_id}","starred_url":"https://api.github.com/users/jbosstools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbosstools/subscriptions","organizations_url":"https://api.github.com/users/jbosstools/orgs","repos_url":"https://api.github.com/users/jbosstools/repos","events_url":"https://api.github.com/users/jbosstools/events{/privacy}","received_events_url":"https://api.github.com/users/jbosstools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jbosstools/jbosstools-hibernate","description":"JBoss Tools :: Hibernate Tools { hibernatetools }","fork":false,"url":"https://api.github.com/repos/jbosstools/jbosstools-hibernate","forks_url":"https://api.github.com/repos/jbosstools/jbosstools-hibernate/forks","keys_url":"https://api.github.com/repos/jbosstools/jbosstools-hibernate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jbosstools/jbosstools-hibernate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jbosstools/jbosstools-hibernate/teams","hooks_url":"https://api.github.com/repos/jbosstools/jbosstools-hibernate/hooks","issue_events_url":"https://api.github.com/repos/jbosstools/jbosstools-hibernate/issues/events{/number}","events_url":"https://api.github.com/repos/jbosstools/jbosstools-hibernate/events","assignees_url":"https://api.github.com/repos/jbosstools/jbosstools-hibernate/assignees{/user}","branches_url":"https://api.github.com/repos/jbosstools/jbosstools-hibernate/branches{/branch}","tags_url":"https://api.github.com/repos/jbosstools/jbosstools-hibernate/tags","blobs_url":"https://api.github.com/repos/jbosstools/jbosstools-hibernate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jbosstools/jbosstools-hibernate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jbosstools/jbosstools-hibernate/git/refs{/sha}","trees_url":"https://api.github.com/repos/jbosstools/jbosstools-hibernate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jbosstools/jbosstools-hibernate/statuses/{sha}","languages_url":"https://api.github.com/repos/jbosstools/jbosstools-hibernate/languages","stargazers_url":"https://api.github.com/repos/jbosstools/jbosstools-hibernate/stargazers","contributors_url":"https://api.github.com/repos/jbosstools/jbosstools-hibernate/contributors","subscribers_url":"https://api.github.com/repos/jbosstools/jbosstools-hibernate/subscribers","subscription_url":"https://api.github.com/repos/jbosstools/jbosstools-hibernate/subscription","commits_url":"https://api.github.com/repos/jbosstools/jbosstools-hibernate/commits{/sha}","git_commits_url":"https://api.github.com/repos/jbosstools/jbosstools-hibernate/git/commits{/sha}","comments_url":"https://api.github.com/repos/jbosstools/jbosstools-hibernate/comments{/number}","issue_comment_url":"https://api.github.com/repos/jbosstools/jbosstools-hibernate/issues/comments/{number}","contents_url":"https://api.github.com/repos/jbosstools/jbosstools-hibernate/contents/{+path}","compare_url":"https://api.github.com/repos/jbosstools/jbosstools-hibernate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jbosstools/jbosstools-hibernate/merges","archive_url":"https://api.github.com/repos/jbosstools/jbosstools-hibernate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jbosstools/jbosstools-hibernate/downloads","issues_url":"https://api.github.com/repos/jbosstools/jbosstools-hibernate/issues{/number}","pulls_url":"https://api.github.com/repos/jbosstools/jbosstools-hibernate/pulls{/number}","milestones_url":"https://api.github.com/repos/jbosstools/jbosstools-hibernate/milestones{/number}","notifications_url":"https://api.github.com/repos/jbosstools/jbosstools-hibernate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jbosstools/jbosstools-hibernate/labels{/name}","releases_url":"https://api.github.com/repos/jbosstools/jbosstools-hibernate/releases{/id}","created_at":"2012-10-24T14:12:21Z","updated_at":"2014-09-02T07:08:46Z","pushed_at":"2014-09-10T08:40:52Z","git_url":"git://github.com/jbosstools/jbosstools-hibernate.git","ssh_url":"git@github.com:jbosstools/jbosstools-hibernate.git","clone_url":"https://github.com/jbosstools/jbosstools-hibernate.git","svn_url":"https://github.com/jbosstools/jbosstools-hibernate","homepage":null,"size":296258,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":17,"mirror_url":null,"open_issues_count":5,"forks":17,"open_issues":5,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jbosstools/jbosstools-hibernate/pulls/49"},"html":{"href":"https://github.com/jbosstools/jbosstools-hibernate/pull/49"},"issue":{"href":"https://api.github.com/repos/jbosstools/jbosstools-hibernate/issues/49"},"comments":{"href":"https://api.github.com/repos/jbosstools/jbosstools-hibernate/issues/49/comments"},"review_comments":{"href":"https://api.github.com/repos/jbosstools/jbosstools-hibernate/pulls/49/comments"},"review_comment":{"href":"https://api.github.com/repos/jbosstools/jbosstools-hibernate/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/jbosstools/jbosstools-hibernate/pulls/49/commits"},"statuses":{"href":"https://api.github.com/repos/jbosstools/jbosstools-hibernate/statuses/79b735d2eef63be426e73c74454e83c9056b00a8"}}}}