GitHub PullRequestEvent at 2014-10-16 23:23:22
Repository: java-sdk
Actor: csciuto
Payload: {"action":"closed","number":38,"pull_request":{"url":"https://api.github.com/repos/constantcontact/java-sdk/pulls/38","id":22564880,"html_url":"https://github.com/constantcontact/java-sdk/pull/38","diff_url":"https://github.com/constantcontact/java-sdk/pull/38.diff","patch_url":"https://github.com/constantcontact/java-sdk/pull/38.patch","issue_url":"https://api.github.com/repos/constantcontact/java-sdk/issues/38","number":38,"state":"closed","locked":false,"title":"Added versioning track header implementation","user":{"login":"halusstefan","id":1616229,"avatar_url":"https://avatars.githubusercontent.com/u/1616229?v=2","gravatar_id":"","url":"https://api.github.com/users/halusstefan","html_url":"https://github.com/halusstefan","followers_url":"https://api.github.com/users/halusstefan/followers","following_url":"https://api.github.com/users/halusstefan/following{/other_user}","gists_url":"https://api.github.com/users/halusstefan/gists{/gist_id}","starred_url":"https://api.github.com/users/halusstefan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/halusstefan/subscriptions","organizations_url":"https://api.github.com/users/halusstefan/orgs","repos_url":"https://api.github.com/users/halusstefan/repos","events_url":"https://api.github.com/users/halusstefan/events{/privacy}","received_events_url":"https://api.github.com/users/halusstefan/received_events","type":"User","site_admin":false},"body":"At this point of the implementation the version number must be updated manually in pom.xml and ctct_api.properties.\r\n\r\nI tried to use properties-maven-plugin, but a warning is raised by maven \"'version' contains an expression but should be a constant.\" and the token ${sdk.version} doesn't get replaced with the value in ctct_api.properties, when running mvn install. See below\r\n\r\n<groupId>com.constantcontact</groupId>\r\n<artifactId>constantcontact</artifactId>\r\n<version>${sdk.version}</version>\r\n\r\nwith ctct_api.properties file:\r\nsdk.version=2.1.5\r\n\r\nI will continue to investigate the issue, but for now i thinks it's ok to merge.","created_at":"2014-10-10T14:41:57Z","updated_at":"2014-10-16T23:23:22Z","closed_at":"2014-10-16T23:23:22Z","merged_at":"2014-10-16T23:23:22Z","merge_commit_sha":"4f8d23086480c7da464f6ac4cecd2c739e3463c0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/constantcontact/java-sdk/pulls/38/commits","review_comments_url":"https://api.github.com/repos/constantcontact/java-sdk/pulls/38/comments","review_comment_url":"https://api.github.com/repos/constantcontact/java-sdk/pulls/comments/{number}","comments_url":"https://api.github.com/repos/constantcontact/java-sdk/issues/38/comments","statuses_url":"https://api.github.com/repos/constantcontact/java-sdk/statuses/6bd2f01b68b672234d0e2f9b9c173d197265b82d","head":{"label":"halusstefan:master","ref":"master","sha":"6bd2f01b68b672234d0e2f9b9c173d197265b82d","user":{"login":"halusstefan","id":1616229,"avatar_url":"https://avatars.githubusercontent.com/u/1616229?v=2","gravatar_id":"","url":"https://api.github.com/users/halusstefan","html_url":"https://github.com/halusstefan","followers_url":"https://api.github.com/users/halusstefan/followers","following_url":"https://api.github.com/users/halusstefan/following{/other_user}","gists_url":"https://api.github.com/users/halusstefan/gists{/gist_id}","starred_url":"https://api.github.com/users/halusstefan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/halusstefan/subscriptions","organizations_url":"https://api.github.com/users/halusstefan/orgs","repos_url":"https://api.github.com/users/halusstefan/repos","events_url":"https://api.github.com/users/halusstefan/events{/privacy}","received_events_url":"https://api.github.com/users/halusstefan/received_events","type":"User","site_admin":false},"repo":{"id":11765899,"name":"java-sdk","full_name":"halusstefan/java-sdk","owner":{"login":"halusstefan","id":1616229,"avatar_url":"https://avatars.githubusercontent.com/u/1616229?v=2","gravatar_id":"","url":"https://api.github.com/users/halusstefan","html_url":"https://github.com/halusstefan","followers_url":"https://api.github.com/users/halusstefan/followers","following_url":"https://api.github.com/users/halusstefan/following{/other_user}","gists_url":"https://api.github.com/users/halusstefan/gists{/gist_id}","starred_url":"https://api.github.com/users/halusstefan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/halusstefan/subscriptions","organizations_url":"https://api.github.com/users/halusstefan/orgs","repos_url":"https://api.github.com/users/halusstefan/repos","events_url":"https://api.github.com/users/halusstefan/events{/privacy}","received_events_url":"https://api.github.com/users/halusstefan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/halusstefan/java-sdk","description":"Constant Contact Java SDK for v2","fork":true,"url":"https://api.github.com/repos/halusstefan/java-sdk","forks_url":"https://api.github.com/repos/halusstefan/java-sdk/forks","keys_url":"https://api.github.com/repos/halusstefan/java-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/halusstefan/java-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/halusstefan/java-sdk/teams","hooks_url":"https://api.github.com/repos/halusstefan/java-sdk/hooks","issue_events_url":"https://api.github.com/repos/halusstefan/java-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/halusstefan/java-sdk/events","assignees_url":"https://api.github.com/repos/halusstefan/java-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/halusstefan/java-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/halusstefan/java-sdk/tags","blobs_url":"https://api.github.com/repos/halusstefan/java-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/halusstefan/java-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/halusstefan/java-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/halusstefan/java-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/halusstefan/java-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/halusstefan/java-sdk/languages","stargazers_url":"https://api.github.com/repos/halusstefan/java-sdk/stargazers","contributors_url":"https://api.github.com/repos/halusstefan/java-sdk/contributors","subscribers_url":"https://api.github.com/repos/halusstefan/java-sdk/subscribers","subscription_url":"https://api.github.com/repos/halusstefan/java-sdk/subscription","commits_url":"https://api.github.com/repos/halusstefan/java-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/halusstefan/java-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/halusstefan/java-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/halusstefan/java-sdk/issues/comments/{number}","contents_url":"https://api.github.com/repos/halusstefan/java-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/halusstefan/java-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/halusstefan/java-sdk/merges","archive_url":"https://api.github.com/repos/halusstefan/java-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/halusstefan/java-sdk/downloads","issues_url":"https://api.github.com/repos/halusstefan/java-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/halusstefan/java-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/halusstefan/java-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/halusstefan/java-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/halusstefan/java-sdk/labels{/name}","releases_url":"https://api.github.com/repos/halusstefan/java-sdk/releases{/id}","created_at":"2013-07-30T13:37:23Z","updated_at":"2014-08-07T11:16:18Z","pushed_at":"2014-10-16T14:18:08Z","git_url":"git://github.com/halusstefan/java-sdk.git","ssh_url":"git@github.com:halusstefan/java-sdk.git","clone_url":"https://github.com/halusstefan/java-sdk.git","svn_url":"https://github.com/halusstefan/java-sdk","homepage":null,"size":7324,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"constantcontact:master","ref":"master","sha":"befd019f14f6706d0e0b3b31cc09fa986244028a","user":{"login":"constantcontact","id":632753,"avatar_url":"https://avatars.githubusercontent.com/u/632753?v=2","gravatar_id":"","url":"https://api.github.com/users/constantcontact","html_url":"https://github.com/constantcontact","followers_url":"https://api.github.com/users/constantcontact/followers","following_url":"https://api.github.com/users/constantcontact/following{/other_user}","gists_url":"https://api.github.com/users/constantcontact/gists{/gist_id}","starred_url":"https://api.github.com/users/constantcontact/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/constantcontact/subscriptions","organizations_url":"https://api.github.com/users/constantcontact/orgs","repos_url":"https://api.github.com/users/constantcontact/repos","events_url":"https://api.github.com/users/constantcontact/events{/privacy}","received_events_url":"https://api.github.com/users/constantcontact/received_events","type":"Organization","site_admin":false},"repo":{"id":8608977,"name":"java-sdk","full_name":"constantcontact/java-sdk","owner":{"login":"constantcontact","id":632753,"avatar_url":"https://avatars.githubusercontent.com/u/632753?v=2","gravatar_id":"","url":"https://api.github.com/users/constantcontact","html_url":"https://github.com/constantcontact","followers_url":"https://api.github.com/users/constantcontact/followers","following_url":"https://api.github.com/users/constantcontact/following{/other_user}","gists_url":"https://api.github.com/users/constantcontact/gists{/gist_id}","starred_url":"https://api.github.com/users/constantcontact/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/constantcontact/subscriptions","organizations_url":"https://api.github.com/users/constantcontact/orgs","repos_url":"https://api.github.com/users/constantcontact/repos","events_url":"https://api.github.com/users/constantcontact/events{/privacy}","received_events_url":"https://api.github.com/users/constantcontact/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/constantcontact/java-sdk","description":"Constant Contact Java SDK for v2 API","fork":false,"url":"https://api.github.com/repos/constantcontact/java-sdk","forks_url":"https://api.github.com/repos/constantcontact/java-sdk/forks","keys_url":"https://api.github.com/repos/constantcontact/java-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/constantcontact/java-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/constantcontact/java-sdk/teams","hooks_url":"https://api.github.com/repos/constantcontact/java-sdk/hooks","issue_events_url":"https://api.github.com/repos/constantcontact/java-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/constantcontact/java-sdk/events","assignees_url":"https://api.github.com/repos/constantcontact/java-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/constantcontact/java-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/constantcontact/java-sdk/tags","blobs_url":"https://api.github.com/repos/constantcontact/java-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/constantcontact/java-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/constantcontact/java-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/constantcontact/java-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/constantcontact/java-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/constantcontact/java-sdk/languages","stargazers_url":"https://api.github.com/repos/constantcontact/java-sdk/stargazers","contributors_url":"https://api.github.com/repos/constantcontact/java-sdk/contributors","subscribers_url":"https://api.github.com/repos/constantcontact/java-sdk/subscribers","subscription_url":"https://api.github.com/repos/constantcontact/java-sdk/subscription","commits_url":"https://api.github.com/repos/constantcontact/java-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/constantcontact/java-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/constantcontact/java-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/constantcontact/java-sdk/issues/comments/{number}","contents_url":"https://api.github.com/repos/constantcontact/java-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/constantcontact/java-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/constantcontact/java-sdk/merges","archive_url":"https://api.github.com/repos/constantcontact/java-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/constantcontact/java-sdk/downloads","issues_url":"https://api.github.com/repos/constantcontact/java-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/constantcontact/java-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/constantcontact/java-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/constantcontact/java-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/constantcontact/java-sdk/labels{/name}","releases_url":"https://api.github.com/repos/constantcontact/java-sdk/releases{/id}","created_at":"2013-03-06T17:27:13Z","updated_at":"2014-10-03T21:28:30Z","pushed_at":"2014-10-16T23:23:22Z","git_url":"git://github.com/constantcontact/java-sdk.git","ssh_url":"git@github.com:constantcontact/java-sdk.git","clone_url":"https://github.com/constantcontact/java-sdk.git","svn_url":"https://github.com/constantcontact/java-sdk","homepage":"","size":7340,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":1,"forks":21,"open_issues":1,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/constantcontact/java-sdk/pulls/38"},"html":{"href":"https://github.com/constantcontact/java-sdk/pull/38"},"issue":{"href":"https://api.github.com/repos/constantcontact/java-sdk/issues/38"},"comments":{"href":"https://api.github.com/repos/constantcontact/java-sdk/issues/38/comments"},"review_comments":{"href":"https://api.github.com/repos/constantcontact/java-sdk/pulls/38/comments"},"review_comment":{"href":"https://api.github.com/repos/constantcontact/java-sdk/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/constantcontact/java-sdk/pulls/38/commits"},"statuses":{"href":"https://api.github.com/repos/constantcontact/java-sdk/statuses/6bd2f01b68b672234d0e2f9b9c173d197265b82d"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"csciuto","id":1928023,"avatar_url":"https://avatars.githubusercontent.com/u/1928023?v=2","gravatar_id":"","url":"https://api.github.com/users/csciuto","html_url":"https://github.com/csciuto","followers_url":"https://api.github.com/users/csciuto/followers","following_url":"https://api.github.com/users/csciuto/following{/other_user}","gists_url":"https://api.github.com/users/csciuto/gists{/gist_id}","starred_url":"https://api.github.com/users/csciuto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csciuto/subscriptions","organizations_url":"https://api.github.com/users/csciuto/orgs","repos_url":"https://api.github.com/users/csciuto/repos","events_url":"https://api.github.com/users/csciuto/events{/privacy}","received_events_url":"https://api.github.com/users/csciuto/received_events","type":"User","site_admin":false},"comments":6,"review_comments":0,"commits":10,"additions":23,"deletions":39,"changed_files":4}}