GitHub PullRequestReviewCommentEvent at 2014-11-25 05:38:44
Repository: czmq
Actor: Asmod4n
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/zeromq/czmq/pulls/comments/20844232","id":20844232,"diff_hunk":"@@ -583,6 +586,9 @@ zhash_load (zhash_t *self, const char *filename)\n         return -1;              //  Failed to open file for reading\n \n     char *buffer = (char *) zmalloc (1024);\n+    if (!buffer)\n+        return -1;","path":"src/zhash.c","position":21,"original_position":21,"commit_id":"bccf63df03c51e22bb304cd154d1206e0bd77841","original_commit_id":"bccf63df03c51e22bb304cd154d1206e0bd77841","user":{"login":"Asmod4n","id":791770,"avatar_url":"https://avatars.githubusercontent.com/u/791770?v=3","gravatar_id":"","url":"https://api.github.com/users/Asmod4n","html_url":"https://github.com/Asmod4n","followers_url":"https://api.github.com/users/Asmod4n/followers","following_url":"https://api.github.com/users/Asmod4n/following{/other_user}","gists_url":"https://api.github.com/users/Asmod4n/gists{/gist_id}","starred_url":"https://api.github.com/users/Asmod4n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Asmod4n/subscriptions","organizations_url":"https://api.github.com/users/Asmod4n/orgs","repos_url":"https://api.github.com/users/Asmod4n/repos","events_url":"https://api.github.com/users/Asmod4n/events{/privacy}","received_events_url":"https://api.github.com/users/Asmod4n/received_events","type":"User","site_admin":false},"body":"@xaqq this looks better? https://gist.github.com/Asmod4n/8efe91b3ba5454cbe796","created_at":"2014-11-25T05:38:44Z","updated_at":"2014-11-25T05:38:44Z","html_url":"https://github.com/zeromq/czmq/pull/824#discussion_r20844232","pull_request_url":"https://api.github.com/repos/zeromq/czmq/pulls/824","_links":{"self":{"href":"https://api.github.com/repos/zeromq/czmq/pulls/comments/20844232"},"html":{"href":"https://github.com/zeromq/czmq/pull/824#discussion_r20844232"},"pull_request":{"href":"https://api.github.com/repos/zeromq/czmq/pulls/824"}}},"pull_request":{"url":"https://api.github.com/repos/zeromq/czmq/pulls/824","id":24902851,"html_url":"https://github.com/zeromq/czmq/pull/824","diff_url":"https://github.com/zeromq/czmq/pull/824.diff","patch_url":"https://github.com/zeromq/czmq/pull/824.patch","issue_url":"https://api.github.com/repos/zeromq/czmq/issues/824","number":824,"state":"open","locked":false,"title":"Problem: string buffers aren't NULL checked","user":{"login":"Asmod4n","id":791770,"avatar_url":"https://avatars.githubusercontent.com/u/791770?v=3","gravatar_id":"","url":"https://api.github.com/users/Asmod4n","html_url":"https://github.com/Asmod4n","followers_url":"https://api.github.com/users/Asmod4n/followers","following_url":"https://api.github.com/users/Asmod4n/following{/other_user}","gists_url":"https://api.github.com/users/Asmod4n/gists{/gist_id}","starred_url":"https://api.github.com/users/Asmod4n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Asmod4n/subscriptions","organizations_url":"https://api.github.com/users/Asmod4n/orgs","repos_url":"https://api.github.com/users/Asmod4n/repos","events_url":"https://api.github.com/users/Asmod4n/events{/privacy}","received_events_url":"https://api.github.com/users/Asmod4n/received_events","type":"User","site_admin":false},"body":"Have found some places where memory is allocated and not NULL checked.\r\nI have not touched the auto generated engine for zgossip which is also not checking for NULL pointers from strdup.\r\n\r\nTests pass locally.","created_at":"2014-11-23T15:59:23Z","updated_at":"2014-11-25T05:38:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"98e5f723bdf478b5fda7b2c213061fc783a78496","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/zeromq/czmq/pulls/824/commits","review_comments_url":"https://api.github.com/repos/zeromq/czmq/pulls/824/comments","review_comment_url":"https://api.github.com/repos/zeromq/czmq/pulls/comments/{number}","comments_url":"https://api.github.com/repos/zeromq/czmq/issues/824/comments","statuses_url":"https://api.github.com/repos/zeromq/czmq/statuses/bccf63df03c51e22bb304cd154d1206e0bd77841","head":{"label":"Asmod4n:strndup","ref":"strndup","sha":"bccf63df03c51e22bb304cd154d1206e0bd77841","user":{"login":"Asmod4n","id":791770,"avatar_url":"https://avatars.githubusercontent.com/u/791770?v=3","gravatar_id":"","url":"https://api.github.com/users/Asmod4n","html_url":"https://github.com/Asmod4n","followers_url":"https://api.github.com/users/Asmod4n/followers","following_url":"https://api.github.com/users/Asmod4n/following{/other_user}","gists_url":"https://api.github.com/users/Asmod4n/gists{/gist_id}","starred_url":"https://api.github.com/users/Asmod4n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Asmod4n/subscriptions","organizations_url":"https://api.github.com/users/Asmod4n/orgs","repos_url":"https://api.github.com/users/Asmod4n/repos","events_url":"https://api.github.com/users/Asmod4n/events{/privacy}","received_events_url":"https://api.github.com/users/Asmod4n/received_events","type":"User","site_admin":false},"repo":{"id":27012971,"name":"czmq","full_name":"Asmod4n/czmq","owner":{"login":"Asmod4n","id":791770,"avatar_url":"https://avatars.githubusercontent.com/u/791770?v=3","gravatar_id":"","url":"https://api.github.com/users/Asmod4n","html_url":"https://github.com/Asmod4n","followers_url":"https://api.github.com/users/Asmod4n/followers","following_url":"https://api.github.com/users/Asmod4n/following{/other_user}","gists_url":"https://api.github.com/users/Asmod4n/gists{/gist_id}","starred_url":"https://api.github.com/users/Asmod4n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Asmod4n/subscriptions","organizations_url":"https://api.github.com/users/Asmod4n/orgs","repos_url":"https://api.github.com/users/Asmod4n/repos","events_url":"https://api.github.com/users/Asmod4n/events{/privacy}","received_events_url":"https://api.github.com/users/Asmod4n/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Asmod4n/czmq","description":"High-level C binding for ØMQ","fork":true,"url":"https://api.github.com/repos/Asmod4n/czmq","forks_url":"https://api.github.com/repos/Asmod4n/czmq/forks","keys_url":"https://api.github.com/repos/Asmod4n/czmq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Asmod4n/czmq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Asmod4n/czmq/teams","hooks_url":"https://api.github.com/repos/Asmod4n/czmq/hooks","issue_events_url":"https://api.github.com/repos/Asmod4n/czmq/issues/events{/number}","events_url":"https://api.github.com/repos/Asmod4n/czmq/events","assignees_url":"https://api.github.com/repos/Asmod4n/czmq/assignees{/user}","branches_url":"https://api.github.com/repos/Asmod4n/czmq/branches{/branch}","tags_url":"https://api.github.com/repos/Asmod4n/czmq/tags","blobs_url":"https://api.github.com/repos/Asmod4n/czmq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Asmod4n/czmq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Asmod4n/czmq/git/refs{/sha}","trees_url":"https://api.github.com/repos/Asmod4n/czmq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Asmod4n/czmq/statuses/{sha}","languages_url":"https://api.github.com/repos/Asmod4n/czmq/languages","stargazers_url":"https://api.github.com/repos/Asmod4n/czmq/stargazers","contributors_url":"https://api.github.com/repos/Asmod4n/czmq/contributors","subscribers_url":"https://api.github.com/repos/Asmod4n/czmq/subscribers","subscription_url":"https://api.github.com/repos/Asmod4n/czmq/subscription","commits_url":"https://api.github.com/repos/Asmod4n/czmq/commits{/sha}","git_commits_url":"https://api.github.com/repos/Asmod4n/czmq/git/commits{/sha}","comments_url":"https://api.github.com/repos/Asmod4n/czmq/comments{/number}","issue_comment_url":"https://api.github.com/repos/Asmod4n/czmq/issues/comments/{number}","contents_url":"https://api.github.com/repos/Asmod4n/czmq/contents/{+path}","compare_url":"https://api.github.com/repos/Asmod4n/czmq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Asmod4n/czmq/merges","archive_url":"https://api.github.com/repos/Asmod4n/czmq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Asmod4n/czmq/downloads","issues_url":"https://api.github.com/repos/Asmod4n/czmq/issues{/number}","pulls_url":"https://api.github.com/repos/Asmod4n/czmq/pulls{/number}","milestones_url":"https://api.github.com/repos/Asmod4n/czmq/milestones{/number}","notifications_url":"https://api.github.com/repos/Asmod4n/czmq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Asmod4n/czmq/labels{/name}","releases_url":"https://api.github.com/repos/Asmod4n/czmq/releases{/id}","created_at":"2014-11-22T21:22:23Z","updated_at":"2014-11-22T21:22:25Z","pushed_at":"2014-11-23T17:10:18Z","git_url":"git://github.com/Asmod4n/czmq.git","ssh_url":"git@github.com:Asmod4n/czmq.git","clone_url":"https://github.com/Asmod4n/czmq.git","svn_url":"https://github.com/Asmod4n/czmq","homepage":"czmq.zeromq.org","size":13221,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zeromq:master","ref":"master","sha":"9aeb803793ff577ef73e990b4e2339aa83e514cf","user":{"login":"zeromq","id":109777,"avatar_url":"https://avatars.githubusercontent.com/u/109777?v=3","gravatar_id":"","url":"https://api.github.com/users/zeromq","html_url":"https://github.com/zeromq","followers_url":"https://api.github.com/users/zeromq/followers","following_url":"https://api.github.com/users/zeromq/following{/other_user}","gists_url":"https://api.github.com/users/zeromq/gists{/gist_id}","starred_url":"https://api.github.com/users/zeromq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeromq/subscriptions","organizations_url":"https://api.github.com/users/zeromq/orgs","repos_url":"https://api.github.com/users/zeromq/repos","events_url":"https://api.github.com/users/zeromq/events{/privacy}","received_events_url":"https://api.github.com/users/zeromq/received_events","type":"Organization","site_admin":false},"repo":{"id":1510809,"name":"czmq","full_name":"zeromq/czmq","owner":{"login":"zeromq","id":109777,"avatar_url":"https://avatars.githubusercontent.com/u/109777?v=3","gravatar_id":"","url":"https://api.github.com/users/zeromq","html_url":"https://github.com/zeromq","followers_url":"https://api.github.com/users/zeromq/followers","following_url":"https://api.github.com/users/zeromq/following{/other_user}","gists_url":"https://api.github.com/users/zeromq/gists{/gist_id}","starred_url":"https://api.github.com/users/zeromq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeromq/subscriptions","organizations_url":"https://api.github.com/users/zeromq/orgs","repos_url":"https://api.github.com/users/zeromq/repos","events_url":"https://api.github.com/users/zeromq/events{/privacy}","received_events_url":"https://api.github.com/users/zeromq/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zeromq/czmq","description":"High-level C binding for ØMQ","fork":false,"url":"https://api.github.com/repos/zeromq/czmq","forks_url":"https://api.github.com/repos/zeromq/czmq/forks","keys_url":"https://api.github.com/repos/zeromq/czmq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zeromq/czmq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zeromq/czmq/teams","hooks_url":"https://api.github.com/repos/zeromq/czmq/hooks","issue_events_url":"https://api.github.com/repos/zeromq/czmq/issues/events{/number}","events_url":"https://api.github.com/repos/zeromq/czmq/events","assignees_url":"https://api.github.com/repos/zeromq/czmq/assignees{/user}","branches_url":"https://api.github.com/repos/zeromq/czmq/branches{/branch}","tags_url":"https://api.github.com/repos/zeromq/czmq/tags","blobs_url":"https://api.github.com/repos/zeromq/czmq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zeromq/czmq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zeromq/czmq/git/refs{/sha}","trees_url":"https://api.github.com/repos/zeromq/czmq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zeromq/czmq/statuses/{sha}","languages_url":"https://api.github.com/repos/zeromq/czmq/languages","stargazers_url":"https://api.github.com/repos/zeromq/czmq/stargazers","contributors_url":"https://api.github.com/repos/zeromq/czmq/contributors","subscribers_url":"https://api.github.com/repos/zeromq/czmq/subscribers","subscription_url":"https://api.github.com/repos/zeromq/czmq/subscription","commits_url":"https://api.github.com/repos/zeromq/czmq/commits{/sha}","git_commits_url":"https://api.github.com/repos/zeromq/czmq/git/commits{/sha}","comments_url":"https://api.github.com/repos/zeromq/czmq/comments{/number}","issue_comment_url":"https://api.github.com/repos/zeromq/czmq/issues/comments/{number}","contents_url":"https://api.github.com/repos/zeromq/czmq/contents/{+path}","compare_url":"https://api.github.com/repos/zeromq/czmq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zeromq/czmq/merges","archive_url":"https://api.github.com/repos/zeromq/czmq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zeromq/czmq/downloads","issues_url":"https://api.github.com/repos/zeromq/czmq/issues{/number}","pulls_url":"https://api.github.com/repos/zeromq/czmq/pulls{/number}","milestones_url":"https://api.github.com/repos/zeromq/czmq/milestones{/number}","notifications_url":"https://api.github.com/repos/zeromq/czmq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zeromq/czmq/labels{/name}","releases_url":"https://api.github.com/repos/zeromq/czmq/releases{/id}","created_at":"2011-03-22T10:42:27Z","updated_at":"2014-11-24T21:37:30Z","pushed_at":"2014-11-24T21:37:30Z","git_url":"git://github.com/zeromq/czmq.git","ssh_url":"git@github.com:zeromq/czmq.git","clone_url":"https://github.com/zeromq/czmq.git","svn_url":"https://github.com/zeromq/czmq","homepage":"czmq.zeromq.org","size":13221,"stargazers_count":287,"watchers_count":287,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":171,"mirror_url":null,"open_issues_count":15,"forks":171,"open_issues":15,"watchers":287,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zeromq/czmq/pulls/824"},"html":{"href":"https://github.com/zeromq/czmq/pull/824"},"issue":{"href":"https://api.github.com/repos/zeromq/czmq/issues/824"},"comments":{"href":"https://api.github.com/repos/zeromq/czmq/issues/824/comments"},"review_comments":{"href":"https://api.github.com/repos/zeromq/czmq/pulls/824/comments"},"review_comment":{"href":"https://api.github.com/repos/zeromq/czmq/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/zeromq/czmq/pulls/824/commits"},"statuses":{"href":"https://api.github.com/repos/zeromq/czmq/statuses/bccf63df03c51e22bb304cd154d1206e0bd77841"}}}}