GitHub PullRequestReviewCommentEvent at 2014-03-05 17:50:00
Repository: salt
Actor: s0undt3ch
Payload: {"comment":{"url":"https://api.github.com/repos/saltstack/salt/pulls/comments/10309759","id":10309759,"diff_hunk":"@@ -1267,35 +1302,47 @@ def root_cmd(command, tty, sudo, **kwargs):\n         ' '.join(ssh_args), kwargs, pipes.quote(command)\n     )\n     log.debug('SSH command: {0!r}'.format(cmd))\n+    class PasswordError(Exception):","path":"salt/utils/cloud.py","position":146,"original_position":146,"commit_id":"f496cfddd56e41204a14ad98c4ab3c193ceb0578","original_commit_id":"98257eedd7e722fbb3f90d8ea53f272f993a7a8e","user":{"login":"s0undt3ch","id":300048,"avatar_url":"https://gravatar.com/avatar/49656fcaeab19bd7ad1d51264ea37e7d?d=https%3A%2F%2Fidenticons.github.com%2Fc05696eab78bc4f6417fe07dc2314a03.png&r=x","gravatar_id":"49656fcaeab19bd7ad1d51264ea37e7d","url":"https://api.github.com/users/s0undt3ch","html_url":"https://github.com/s0undt3ch","followers_url":"https://api.github.com/users/s0undt3ch/followers","following_url":"https://api.github.com/users/s0undt3ch/following{/other_user}","gists_url":"https://api.github.com/users/s0undt3ch/gists{/gist_id}","starred_url":"https://api.github.com/users/s0undt3ch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s0undt3ch/subscriptions","organizations_url":"https://api.github.com/users/s0undt3ch/orgs","repos_url":"https://api.github.com/users/s0undt3ch/repos","events_url":"https://api.github.com/users/s0undt3ch/events{/privacy}","received_events_url":"https://api.github.com/users/s0undt3ch/received_events","type":"User","site_admin":false},"body":"I believe we should move this exception definition to [`salt/cloud/exceptions.py`](https://github.com/saltstack/salt/blob/develop/salt/cloud/exceptions.py). What do you think @techhat?","created_at":"2014-03-05T17:50:00Z","updated_at":"2014-03-05T17:50:00Z","html_url":"https://github.com/saltstack/salt/pull/10869#discussion_r10309759","pull_request_url":"https://api.github.com/repos/saltstack/salt/pulls/10869","_links":{"self":{"href":"https://api.github.com/repos/saltstack/salt/pulls/comments/10309759"},"html":{"href":"https://github.com/saltstack/salt/pull/10869#discussion_r10309759"},"pull_request":{"href":"https://api.github.com/repos/saltstack/salt/pulls/10869"}}}}