GitHub PullRequestReviewCommentEvent at 2014-09-05 16:06:32
Repository: versal-gadget-launchers
Actor: mereskin
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/Versal/versal-gadget-launchers/pulls/comments/17180951","id":17180951,"diff_hunk":"@@ -0,0 +1,133 @@\n+/* global _ */\n+var prototype = Object.create(HTMLElement.prototype, {\n+  editable: {\n+    get: function(){\n+      return this.getAttribute('editable') == 'true';\n+    }\n+  },\n+\n+  config: {\n+    get: function(){\n+      return this.readAttributeAsJson('data-config');\n+    }\n+  },\n+\n+  src: {\n+    get: function(){\n+      return this.getAttribute('src') || 'about:blank';\n+    }\n+  },\n+\n+  // TODO\n+  // pass this from the player","path":"component-launcher/component-launcher.js","position":21,"original_position":22,"commit_id":"c6148b25cf00ef9c1f07d4995a0754a0963de2fd","original_commit_id":"2d5f7f8603134e3737be9be47e8ea963aa8067f5","user":{"login":"mereskin","id":1451094,"avatar_url":"https://avatars.githubusercontent.com/u/1451094?v=2","gravatar_id":"58e738f04883c6a438cd3cd9eb1153bc","url":"https://api.github.com/users/mereskin","html_url":"https://github.com/mereskin","followers_url":"https://api.github.com/users/mereskin/followers","following_url":"https://api.github.com/users/mereskin/following{/other_user}","gists_url":"https://api.github.com/users/mereskin/gists{/gist_id}","starred_url":"https://api.github.com/users/mereskin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mereskin/subscriptions","organizations_url":"https://api.github.com/users/mereskin/orgs","repos_url":"https://api.github.com/users/mereskin/repos","events_url":"https://api.github.com/users/mereskin/events{/privacy}","received_events_url":"https://api.github.com/users/mereskin/received_events","type":"User","site_admin":false},"body":"Just set an attribute on an element?","created_at":"2014-09-05T16:06:32Z","updated_at":"2014-09-05T16:06:32Z","html_url":"https://github.com/Versal/versal-gadget-launchers/pull/40#discussion_r17180951","pull_request_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/pulls/40","_links":{"self":{"href":"https://api.github.com/repos/Versal/versal-gadget-launchers/pulls/comments/17180951"},"html":{"href":"https://github.com/Versal/versal-gadget-launchers/pull/40#discussion_r17180951"},"pull_request":{"href":"https://api.github.com/repos/Versal/versal-gadget-launchers/pulls/40"}}},"pull_request":{"url":"https://api.github.com/repos/Versal/versal-gadget-launchers/pulls/40","id":20524759,"html_url":"https://github.com/Versal/versal-gadget-launchers/pull/40","diff_url":"https://github.com/Versal/versal-gadget-launchers/pull/40.diff","patch_url":"https://github.com/Versal/versal-gadget-launchers/pull/40.patch","issue_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/issues/40","number":40,"state":"open","locked":false,"title":"[Init draft, don't merge]","user":{"login":"shaohua","id":806173,"avatar_url":"https://avatars.githubusercontent.com/u/806173?v=2","gravatar_id":"d158e6a7710d61152346bcec8249fc4b","url":"https://api.github.com/users/shaohua","html_url":"https://github.com/shaohua","followers_url":"https://api.github.com/users/shaohua/followers","following_url":"https://api.github.com/users/shaohua/following{/other_user}","gists_url":"https://api.github.com/users/shaohua/gists{/gist_id}","starred_url":"https://api.github.com/users/shaohua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shaohua/subscriptions","organizations_url":"https://api.github.com/users/shaohua/orgs","repos_url":"https://api.github.com/users/shaohua/repos","events_url":"https://api.github.com/users/shaohua/events{/privacy}","received_events_url":"https://api.github.com/users/shaohua/received_events","type":"User","site_admin":false},"body":"The init draft of a minimum component launcher, it \r\n- sends editable and data-config down\r\n- uses MutationObserver so when its child's data-config changes, it captures the change and send it to player by fireCustomeEvents","created_at":"2014-08-29T21:35:27Z","updated_at":"2014-09-05T16:06:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8be8008634f55f79064ba63aa0c2a1cafcf9f19f","assignee":{"login":"mereskin","id":1451094,"avatar_url":"https://avatars.githubusercontent.com/u/1451094?v=2","gravatar_id":"58e738f04883c6a438cd3cd9eb1153bc","url":"https://api.github.com/users/mereskin","html_url":"https://github.com/mereskin","followers_url":"https://api.github.com/users/mereskin/followers","following_url":"https://api.github.com/users/mereskin/following{/other_user}","gists_url":"https://api.github.com/users/mereskin/gists{/gist_id}","starred_url":"https://api.github.com/users/mereskin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mereskin/subscriptions","organizations_url":"https://api.github.com/users/mereskin/orgs","repos_url":"https://api.github.com/users/mereskin/repos","events_url":"https://api.github.com/users/mereskin/events{/privacy}","received_events_url":"https://api.github.com/users/mereskin/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/pulls/40/commits","review_comments_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/pulls/40/comments","review_comment_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/issues/40/comments","statuses_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/statuses/c6148b25cf00ef9c1f07d4995a0754a0963de2fd","head":{"label":"Versal:feature/comp-launcher-prototype","ref":"feature/comp-launcher-prototype","sha":"c6148b25cf00ef9c1f07d4995a0754a0963de2fd","user":{"login":"Versal","id":1964245,"avatar_url":"https://avatars.githubusercontent.com/u/1964245?v=2","gravatar_id":"2cb84cc613981edbc014bc67a1e54435","url":"https://api.github.com/users/Versal","html_url":"https://github.com/Versal","followers_url":"https://api.github.com/users/Versal/followers","following_url":"https://api.github.com/users/Versal/following{/other_user}","gists_url":"https://api.github.com/users/Versal/gists{/gist_id}","starred_url":"https://api.github.com/users/Versal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Versal/subscriptions","organizations_url":"https://api.github.com/users/Versal/orgs","repos_url":"https://api.github.com/users/Versal/repos","events_url":"https://api.github.com/users/Versal/events{/privacy}","received_events_url":"https://api.github.com/users/Versal/received_events","type":"Organization","site_admin":false},"repo":{"id":19143479,"name":"versal-gadget-launchers","full_name":"Versal/versal-gadget-launchers","owner":{"login":"Versal","id":1964245,"avatar_url":"https://avatars.githubusercontent.com/u/1964245?v=2","gravatar_id":"2cb84cc613981edbc014bc67a1e54435","url":"https://api.github.com/users/Versal","html_url":"https://github.com/Versal","followers_url":"https://api.github.com/users/Versal/followers","following_url":"https://api.github.com/users/Versal/following{/other_user}","gists_url":"https://api.github.com/users/Versal/gists{/gist_id}","starred_url":"https://api.github.com/users/Versal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Versal/subscriptions","organizations_url":"https://api.github.com/users/Versal/orgs","repos_url":"https://api.github.com/users/Versal/repos","events_url":"https://api.github.com/users/Versal/events{/privacy}","received_events_url":"https://api.github.com/users/Versal/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Versal/versal-gadget-launchers","description":"Launchers for Versal gadgets","fork":false,"url":"https://api.github.com/repos/Versal/versal-gadget-launchers","forks_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/forks","keys_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/teams","hooks_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/hooks","issue_events_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/issues/events{/number}","events_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/events","assignees_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/assignees{/user}","branches_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/branches{/branch}","tags_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/tags","blobs_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/git/refs{/sha}","trees_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/statuses/{sha}","languages_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/languages","stargazers_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/stargazers","contributors_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/contributors","subscribers_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/subscribers","subscription_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/subscription","commits_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/commits{/sha}","git_commits_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/git/commits{/sha}","comments_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/comments{/number}","issue_comment_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/issues/comments/{number}","contents_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/contents/{+path}","compare_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/merges","archive_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/downloads","issues_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/issues{/number}","pulls_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/pulls{/number}","milestones_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/milestones{/number}","notifications_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/labels{/name}","releases_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/releases{/id}","created_at":"2014-04-25T11:13:38Z","updated_at":"2014-09-03T00:37:40Z","pushed_at":"2014-09-05T10:21:57Z","git_url":"git://github.com/Versal/versal-gadget-launchers.git","ssh_url":"git@github.com:Versal/versal-gadget-launchers.git","clone_url":"https://github.com/Versal/versal-gadget-launchers.git","svn_url":"https://github.com/Versal/versal-gadget-launchers","homepage":"","size":1556,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":8,"forks":0,"open_issues":8,"watchers":1,"default_branch":"master"}},"base":{"label":"Versal:master","ref":"master","sha":"49a50c8323d4e2e3356ce08bfbd07f7e6a3e0c12","user":{"login":"Versal","id":1964245,"avatar_url":"https://avatars.githubusercontent.com/u/1964245?v=2","gravatar_id":"2cb84cc613981edbc014bc67a1e54435","url":"https://api.github.com/users/Versal","html_url":"https://github.com/Versal","followers_url":"https://api.github.com/users/Versal/followers","following_url":"https://api.github.com/users/Versal/following{/other_user}","gists_url":"https://api.github.com/users/Versal/gists{/gist_id}","starred_url":"https://api.github.com/users/Versal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Versal/subscriptions","organizations_url":"https://api.github.com/users/Versal/orgs","repos_url":"https://api.github.com/users/Versal/repos","events_url":"https://api.github.com/users/Versal/events{/privacy}","received_events_url":"https://api.github.com/users/Versal/received_events","type":"Organization","site_admin":false},"repo":{"id":19143479,"name":"versal-gadget-launchers","full_name":"Versal/versal-gadget-launchers","owner":{"login":"Versal","id":1964245,"avatar_url":"https://avatars.githubusercontent.com/u/1964245?v=2","gravatar_id":"2cb84cc613981edbc014bc67a1e54435","url":"https://api.github.com/users/Versal","html_url":"https://github.com/Versal","followers_url":"https://api.github.com/users/Versal/followers","following_url":"https://api.github.com/users/Versal/following{/other_user}","gists_url":"https://api.github.com/users/Versal/gists{/gist_id}","starred_url":"https://api.github.com/users/Versal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Versal/subscriptions","organizations_url":"https://api.github.com/users/Versal/orgs","repos_url":"https://api.github.com/users/Versal/repos","events_url":"https://api.github.com/users/Versal/events{/privacy}","received_events_url":"https://api.github.com/users/Versal/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Versal/versal-gadget-launchers","description":"Launchers for Versal gadgets","fork":false,"url":"https://api.github.com/repos/Versal/versal-gadget-launchers","forks_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/forks","keys_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/teams","hooks_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/hooks","issue_events_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/issues/events{/number}","events_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/events","assignees_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/assignees{/user}","branches_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/branches{/branch}","tags_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/tags","blobs_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/git/refs{/sha}","trees_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/statuses/{sha}","languages_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/languages","stargazers_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/stargazers","contributors_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/contributors","subscribers_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/subscribers","subscription_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/subscription","commits_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/commits{/sha}","git_commits_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/git/commits{/sha}","comments_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/comments{/number}","issue_comment_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/issues/comments/{number}","contents_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/contents/{+path}","compare_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/merges","archive_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/downloads","issues_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/issues{/number}","pulls_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/pulls{/number}","milestones_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/milestones{/number}","notifications_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/labels{/name}","releases_url":"https://api.github.com/repos/Versal/versal-gadget-launchers/releases{/id}","created_at":"2014-04-25T11:13:38Z","updated_at":"2014-09-03T00:37:40Z","pushed_at":"2014-09-05T10:21:57Z","git_url":"git://github.com/Versal/versal-gadget-launchers.git","ssh_url":"git@github.com:Versal/versal-gadget-launchers.git","clone_url":"https://github.com/Versal/versal-gadget-launchers.git","svn_url":"https://github.com/Versal/versal-gadget-launchers","homepage":"","size":1556,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":8,"forks":0,"open_issues":8,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Versal/versal-gadget-launchers/pulls/40"},"html":{"href":"https://github.com/Versal/versal-gadget-launchers/pull/40"},"issue":{"href":"https://api.github.com/repos/Versal/versal-gadget-launchers/issues/40"},"comments":{"href":"https://api.github.com/repos/Versal/versal-gadget-launchers/issues/40/comments"},"review_comments":{"href":"https://api.github.com/repos/Versal/versal-gadget-launchers/pulls/40/comments"},"review_comment":{"href":"https://api.github.com/repos/Versal/versal-gadget-launchers/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Versal/versal-gadget-launchers/pulls/40/commits"},"statuses":{"href":"https://api.github.com/repos/Versal/versal-gadget-launchers/statuses/c6148b25cf00ef9c1f07d4995a0754a0963de2fd"}}}}