GitHub PullRequestReviewCommentEvent at 2014-06-30 22:48:44
Repository: basho_docs
Actor: coderoshi
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/basho/basho_docs/pulls/comments/14380279","id":14380279,"diff_hunk":"@@ -426,15 +426,13 @@ NoMethodError: undefined method 'map' for 1001:Fixnum\n ```\n \n ```java\n-/*\n-  The Java client will not allow you to provide invalid\n-  index names, because you are not required to add \"_bin\" or \"_int\" to\n-  the end of index names.\n-*/\n+// The Java client will not allow you to provide invalid index names,\n+// because you are not required to add \"_bin\" or \"_int\" to the end of\n+// those names\n ```\n \n ```python\n-bucket = client.bucket('mybucket', bucket_type: '<type>')\n+bucket = client.bucket_type('<type>').bucket('mybucket')","path":"source/languages/en/riak/dev/using/2i.md","position":43,"original_position":43,"commit_id":"46a37f49561bc76cd75754b16ee53ac1f24359b4","original_commit_id":"46a37f49561bc76cd75754b16ee53ac1f24359b4","user":{"login":"coderoshi","id":63749,"avatar_url":"https://avatars.githubusercontent.com/u/63749?","gravatar_id":"707e3965f1630286a3dcaad501a10fed","url":"https://api.github.com/users/coderoshi","html_url":"https://github.com/coderoshi","followers_url":"https://api.github.com/users/coderoshi/followers","following_url":"https://api.github.com/users/coderoshi/following{/other_user}","gists_url":"https://api.github.com/users/coderoshi/gists{/gist_id}","starred_url":"https://api.github.com/users/coderoshi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coderoshi/subscriptions","organizations_url":"https://api.github.com/users/coderoshi/orgs","repos_url":"https://api.github.com/users/coderoshi/repos","events_url":"https://api.github.com/users/coderoshi/events{/privacy}","received_events_url":"https://api.github.com/users/coderoshi/received_events","type":"User","site_admin":false},"body":"`<type>` is a placeholder, while `mybucket` isn't. either match with `mytype`, or `<bucket>`","created_at":"2014-06-30T22:48:44Z","updated_at":"2014-06-30T22:48:44Z","html_url":"https://github.com/basho/basho_docs/pull/1167#discussion_r14380279","pull_request_url":"https://api.github.com/repos/basho/basho_docs/pulls/1167","_links":{"self":{"href":"https://api.github.com/repos/basho/basho_docs/pulls/comments/14380279"},"html":{"href":"https://github.com/basho/basho_docs/pull/1167#discussion_r14380279"},"pull_request":{"href":"https://api.github.com/repos/basho/basho_docs/pulls/1167"}}},"pull_request":{"url":"https://api.github.com/repos/basho/basho_docs/pulls/1167","id":17748972,"html_url":"https://github.com/basho/basho_docs/pull/1167","diff_url":"https://github.com/basho/basho_docs/pull/1167.diff","patch_url":"https://github.com/basho/basho_docs/pull/1167.patch","issue_url":"https://api.github.com/repos/basho/basho_docs/issues/1167","number":1167,"state":"open","title":"Ready: Fix Python samples","user":{"login":"lucperkins","id":1523104,"avatar_url":"https://avatars.githubusercontent.com/u/1523104?","gravatar_id":"af481d7274821037b1a807995b4a6598","url":"https://api.github.com/users/lucperkins","html_url":"https://github.com/lucperkins","followers_url":"https://api.github.com/users/lucperkins/followers","following_url":"https://api.github.com/users/lucperkins/following{/other_user}","gists_url":"https://api.github.com/users/lucperkins/gists{/gist_id}","starred_url":"https://api.github.com/users/lucperkins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucperkins/subscriptions","organizations_url":"https://api.github.com/users/lucperkins/orgs","repos_url":"https://api.github.com/users/lucperkins/repos","events_url":"https://api.github.com/users/lucperkins/events{/privacy}","received_events_url":"https://api.github.com/users/lucperkins/received_events","type":"User","site_admin":false},"body":"The current code samples use the old format for specifying bucket type:\r\n\r\n    bucket = client.bucket('name', bucket_type='type')\r\n\r\nIt should be:\r\n\r\n    bucket = client.bucket_type('type').bucket('name')","created_at":"2014-06-29T17:41:42Z","updated_at":"2014-06-30T22:48:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e8a7fe2385ff8ac77c35c5435a81dfadc9148211","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/basho/basho_docs/pulls/1167/commits","review_comments_url":"https://api.github.com/repos/basho/basho_docs/pulls/1167/comments","review_comment_url":"https://api.github.com/repos/basho/basho_docs/pulls/comments/{number}","comments_url":"https://api.github.com/repos/basho/basho_docs/issues/1167/comments","statuses_url":"https://api.github.com/repos/basho/basho_docs/statuses/46a37f49561bc76cd75754b16ee53ac1f24359b4","head":{"label":"basho:bugs/lp/fix-python-samples","ref":"bugs/lp/fix-python-samples","sha":"46a37f49561bc76cd75754b16ee53ac1f24359b4","user":{"login":"basho","id":176293,"avatar_url":"https://avatars.githubusercontent.com/u/176293?","gravatar_id":"ce5141b78d2fe237e8bfba49d6aff405","url":"https://api.github.com/users/basho","html_url":"https://github.com/basho","followers_url":"https://api.github.com/users/basho/followers","following_url":"https://api.github.com/users/basho/following{/other_user}","gists_url":"https://api.github.com/users/basho/gists{/gist_id}","starred_url":"https://api.github.com/users/basho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basho/subscriptions","organizations_url":"https://api.github.com/users/basho/orgs","repos_url":"https://api.github.com/users/basho/repos","events_url":"https://api.github.com/users/basho/events{/privacy}","received_events_url":"https://api.github.com/users/basho/received_events","type":"Organization","site_admin":false},"repo":{"id":2401217,"name":"basho_docs","full_name":"basho/basho_docs","owner":{"login":"basho","id":176293,"avatar_url":"https://avatars.githubusercontent.com/u/176293?","gravatar_id":"ce5141b78d2fe237e8bfba49d6aff405","url":"https://api.github.com/users/basho","html_url":"https://github.com/basho","followers_url":"https://api.github.com/users/basho/followers","following_url":"https://api.github.com/users/basho/following{/other_user}","gists_url":"https://api.github.com/users/basho/gists{/gist_id}","starred_url":"https://api.github.com/users/basho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basho/subscriptions","organizations_url":"https://api.github.com/users/basho/orgs","repos_url":"https://api.github.com/users/basho/repos","events_url":"https://api.github.com/users/basho/events{/privacy}","received_events_url":"https://api.github.com/users/basho/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/basho/basho_docs","description":"Basho Products Documentation","fork":false,"url":"https://api.github.com/repos/basho/basho_docs","forks_url":"https://api.github.com/repos/basho/basho_docs/forks","keys_url":"https://api.github.com/repos/basho/basho_docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/basho/basho_docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/basho/basho_docs/teams","hooks_url":"https://api.github.com/repos/basho/basho_docs/hooks","issue_events_url":"https://api.github.com/repos/basho/basho_docs/issues/events{/number}","events_url":"https://api.github.com/repos/basho/basho_docs/events","assignees_url":"https://api.github.com/repos/basho/basho_docs/assignees{/user}","branches_url":"https://api.github.com/repos/basho/basho_docs/branches{/branch}","tags_url":"https://api.github.com/repos/basho/basho_docs/tags","blobs_url":"https://api.github.com/repos/basho/basho_docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/basho/basho_docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/basho/basho_docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/basho/basho_docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/basho/basho_docs/statuses/{sha}","languages_url":"https://api.github.com/repos/basho/basho_docs/languages","stargazers_url":"https://api.github.com/repos/basho/basho_docs/stargazers","contributors_url":"https://api.github.com/repos/basho/basho_docs/contributors","subscribers_url":"https://api.github.com/repos/basho/basho_docs/subscribers","subscription_url":"https://api.github.com/repos/basho/basho_docs/subscription","commits_url":"https://api.github.com/repos/basho/basho_docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/basho/basho_docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/basho/basho_docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/basho/basho_docs/issues/comments/{number}","contents_url":"https://api.github.com/repos/basho/basho_docs/contents/{+path}","compare_url":"https://api.github.com/repos/basho/basho_docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/basho/basho_docs/merges","archive_url":"https://api.github.com/repos/basho/basho_docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/basho/basho_docs/downloads","issues_url":"https://api.github.com/repos/basho/basho_docs/issues{/number}","pulls_url":"https://api.github.com/repos/basho/basho_docs/pulls{/number}","milestones_url":"https://api.github.com/repos/basho/basho_docs/milestones{/number}","notifications_url":"https://api.github.com/repos/basho/basho_docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/basho/basho_docs/labels{/name}","releases_url":"https://api.github.com/repos/basho/basho_docs/releases{/id}","created_at":"2011-09-16T18:47:02Z","updated_at":"2014-06-26T19:05:18Z","pushed_at":"2014-06-30T22:17:08Z","git_url":"git://github.com/basho/basho_docs.git","ssh_url":"git@github.com:basho/basho_docs.git","clone_url":"https://github.com/basho/basho_docs.git","svn_url":"https://github.com/basho/basho_docs","homepage":"http://docs.basho.com","size":44262,"stargazers_count":49,"watchers_count":49,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":69,"mirror_url":null,"open_issues_count":121,"forks":69,"open_issues":121,"watchers":49,"default_branch":"master"}},"base":{"label":"basho:2.0.0","ref":"2.0.0","sha":"1d262d6291acee90cfd7f77ebbb00d905d919187","user":{"login":"basho","id":176293,"avatar_url":"https://avatars.githubusercontent.com/u/176293?","gravatar_id":"ce5141b78d2fe237e8bfba49d6aff405","url":"https://api.github.com/users/basho","html_url":"https://github.com/basho","followers_url":"https://api.github.com/users/basho/followers","following_url":"https://api.github.com/users/basho/following{/other_user}","gists_url":"https://api.github.com/users/basho/gists{/gist_id}","starred_url":"https://api.github.com/users/basho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basho/subscriptions","organizations_url":"https://api.github.com/users/basho/orgs","repos_url":"https://api.github.com/users/basho/repos","events_url":"https://api.github.com/users/basho/events{/privacy}","received_events_url":"https://api.github.com/users/basho/received_events","type":"Organization","site_admin":false},"repo":{"id":2401217,"name":"basho_docs","full_name":"basho/basho_docs","owner":{"login":"basho","id":176293,"avatar_url":"https://avatars.githubusercontent.com/u/176293?","gravatar_id":"ce5141b78d2fe237e8bfba49d6aff405","url":"https://api.github.com/users/basho","html_url":"https://github.com/basho","followers_url":"https://api.github.com/users/basho/followers","following_url":"https://api.github.com/users/basho/following{/other_user}","gists_url":"https://api.github.com/users/basho/gists{/gist_id}","starred_url":"https://api.github.com/users/basho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basho/subscriptions","organizations_url":"https://api.github.com/users/basho/orgs","repos_url":"https://api.github.com/users/basho/repos","events_url":"https://api.github.com/users/basho/events{/privacy}","received_events_url":"https://api.github.com/users/basho/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/basho/basho_docs","description":"Basho Products Documentation","fork":false,"url":"https://api.github.com/repos/basho/basho_docs","forks_url":"https://api.github.com/repos/basho/basho_docs/forks","keys_url":"https://api.github.com/repos/basho/basho_docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/basho/basho_docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/basho/basho_docs/teams","hooks_url":"https://api.github.com/repos/basho/basho_docs/hooks","issue_events_url":"https://api.github.com/repos/basho/basho_docs/issues/events{/number}","events_url":"https://api.github.com/repos/basho/basho_docs/events","assignees_url":"https://api.github.com/repos/basho/basho_docs/assignees{/user}","branches_url":"https://api.github.com/repos/basho/basho_docs/branches{/branch}","tags_url":"https://api.github.com/repos/basho/basho_docs/tags","blobs_url":"https://api.github.com/repos/basho/basho_docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/basho/basho_docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/basho/basho_docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/basho/basho_docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/basho/basho_docs/statuses/{sha}","languages_url":"https://api.github.com/repos/basho/basho_docs/languages","stargazers_url":"https://api.github.com/repos/basho/basho_docs/stargazers","contributors_url":"https://api.github.com/repos/basho/basho_docs/contributors","subscribers_url":"https://api.github.com/repos/basho/basho_docs/subscribers","subscription_url":"https://api.github.com/repos/basho/basho_docs/subscription","commits_url":"https://api.github.com/repos/basho/basho_docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/basho/basho_docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/basho/basho_docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/basho/basho_docs/issues/comments/{number}","contents_url":"https://api.github.com/repos/basho/basho_docs/contents/{+path}","compare_url":"https://api.github.com/repos/basho/basho_docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/basho/basho_docs/merges","archive_url":"https://api.github.com/repos/basho/basho_docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/basho/basho_docs/downloads","issues_url":"https://api.github.com/repos/basho/basho_docs/issues{/number}","pulls_url":"https://api.github.com/repos/basho/basho_docs/pulls{/number}","milestones_url":"https://api.github.com/repos/basho/basho_docs/milestones{/number}","notifications_url":"https://api.github.com/repos/basho/basho_docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/basho/basho_docs/labels{/name}","releases_url":"https://api.github.com/repos/basho/basho_docs/releases{/id}","created_at":"2011-09-16T18:47:02Z","updated_at":"2014-06-26T19:05:18Z","pushed_at":"2014-06-30T22:17:08Z","git_url":"git://github.com/basho/basho_docs.git","ssh_url":"git@github.com:basho/basho_docs.git","clone_url":"https://github.com/basho/basho_docs.git","svn_url":"https://github.com/basho/basho_docs","homepage":"http://docs.basho.com","size":44262,"stargazers_count":49,"watchers_count":49,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":69,"mirror_url":null,"open_issues_count":121,"forks":69,"open_issues":121,"watchers":49,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/basho/basho_docs/pulls/1167"},"html":{"href":"https://github.com/basho/basho_docs/pull/1167"},"issue":{"href":"https://api.github.com/repos/basho/basho_docs/issues/1167"},"comments":{"href":"https://api.github.com/repos/basho/basho_docs/issues/1167/comments"},"review_comments":{"href":"https://api.github.com/repos/basho/basho_docs/pulls/1167/comments"},"review_comment":{"href":"https://api.github.com/repos/basho/basho_docs/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/basho/basho_docs/pulls/1167/commits"},"statuses":{"href":"https://api.github.com/repos/basho/basho_docs/statuses/46a37f49561bc76cd75754b16ee53ac1f24359b4"}}}}