GitHub PullRequestReviewCommentEvent at 2014-11-07 01:58:33
Repository: neovim
Actor: xu-cheng
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/neovim/neovim/pulls/comments/19990867","id":19990867,"diff_hunk":"@@ -18,6 +18,15 @@ if(NOT DEFINED TARGET)\n   message(FATAL_ERROR \"TARGET must be defined.\")\n endif()\n \n+set(SRC_DIR ${PREFIX}/src/${TARGET})\n+\n+# Check whether the source has been downloaded. If true, skip it.\n+# Useful for external downloads like homebrew.\n+if(EXISTS \"${SRC_DIR}\" AND IS_DIRECTORY \"${SRC_DIR}\")\n+  message(STATUS \"${SRC_DIR} is found, skip download\")","path":"third-party/cmake/DownloadAndExtractFile.cmake","position":9,"original_position":9,"commit_id":"0999344e425109e926d9c297543eee754434f859","original_commit_id":"0999344e425109e926d9c297543eee754434f859","user":{"login":"xu-cheng","id":3105373,"avatar_url":"https://avatars.githubusercontent.com/u/3105373?v=2","gravatar_id":"","url":"https://api.github.com/users/xu-cheng","html_url":"https://github.com/xu-cheng","followers_url":"https://api.github.com/users/xu-cheng/followers","following_url":"https://api.github.com/users/xu-cheng/following{/other_user}","gists_url":"https://api.github.com/users/xu-cheng/gists{/gist_id}","starred_url":"https://api.github.com/users/xu-cheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xu-cheng/subscriptions","organizations_url":"https://api.github.com/users/xu-cheng/orgs","repos_url":"https://api.github.com/users/xu-cheng/repos","events_url":"https://api.github.com/users/xu-cheng/events{/privacy}","received_events_url":"https://api.github.com/users/xu-cheng/received_events","type":"User","site_admin":false},"body":"Ok, will change it. ","created_at":"2014-11-07T01:58:33Z","updated_at":"2014-11-07T01:58:33Z","html_url":"https://github.com/neovim/neovim/pull/1411#discussion_r19990867","pull_request_url":"https://api.github.com/repos/neovim/neovim/pulls/1411","_links":{"self":{"href":"https://api.github.com/repos/neovim/neovim/pulls/comments/19990867"},"html":{"href":"https://github.com/neovim/neovim/pull/1411#discussion_r19990867"},"pull_request":{"href":"https://api.github.com/repos/neovim/neovim/pulls/1411"}}},"pull_request":{"url":"https://api.github.com/repos/neovim/neovim/pulls/1411","id":23969577,"html_url":"https://github.com/neovim/neovim/pull/1411","diff_url":"https://github.com/neovim/neovim/pull/1411.diff","patch_url":"https://github.com/neovim/neovim/pull/1411.patch","issue_url":"https://api.github.com/repos/neovim/neovim/issues/1411","number":1411,"state":"open","locked":false,"title":"[RFC] Let homebrew handle external resources download","user":{"login":"xu-cheng","id":3105373,"avatar_url":"https://avatars.githubusercontent.com/u/3105373?v=2","gravatar_id":"","url":"https://api.github.com/users/xu-cheng","html_url":"https://github.com/xu-cheng","followers_url":"https://api.github.com/users/xu-cheng/followers","following_url":"https://api.github.com/users/xu-cheng/following{/other_user}","gists_url":"https://api.github.com/users/xu-cheng/gists{/gist_id}","starred_url":"https://api.github.com/users/xu-cheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xu-cheng/subscriptions","organizations_url":"https://api.github.com/users/xu-cheng/orgs","repos_url":"https://api.github.com/users/xu-cheng/repos","events_url":"https://api.github.com/users/xu-cheng/events{/privacy}","received_events_url":"https://api.github.com/users/xu-cheng/received_events","type":"User","site_admin":false},"body":"@fwalch @tarruda\n\nClose #1388","created_at":"2014-11-06T09:58:20Z","updated_at":"2014-11-07T01:58:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1c04686affecbe4a1c47b005ee5ccb1168d6104e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/neovim/neovim/pulls/1411/commits","review_comments_url":"https://api.github.com/repos/neovim/neovim/pulls/1411/comments","review_comment_url":"https://api.github.com/repos/neovim/neovim/pulls/comments/{number}","comments_url":"https://api.github.com/repos/neovim/neovim/issues/1411/comments","statuses_url":"https://api.github.com/repos/neovim/neovim/statuses/0999344e425109e926d9c297543eee754434f859","head":{"label":"xu-cheng:homebrew-formula","ref":"homebrew-formula","sha":"0999344e425109e926d9c297543eee754434f859","user":{"login":"xu-cheng","id":3105373,"avatar_url":"https://avatars.githubusercontent.com/u/3105373?v=2","gravatar_id":"","url":"https://api.github.com/users/xu-cheng","html_url":"https://github.com/xu-cheng","followers_url":"https://api.github.com/users/xu-cheng/followers","following_url":"https://api.github.com/users/xu-cheng/following{/other_user}","gists_url":"https://api.github.com/users/xu-cheng/gists{/gist_id}","starred_url":"https://api.github.com/users/xu-cheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xu-cheng/subscriptions","organizations_url":"https://api.github.com/users/xu-cheng/orgs","repos_url":"https://api.github.com/users/xu-cheng/repos","events_url":"https://api.github.com/users/xu-cheng/events{/privacy}","received_events_url":"https://api.github.com/users/xu-cheng/received_events","type":"User","site_admin":false},"repo":{"id":21533820,"name":"neovim","full_name":"xu-cheng/neovim","owner":{"login":"xu-cheng","id":3105373,"avatar_url":"https://avatars.githubusercontent.com/u/3105373?v=2","gravatar_id":"","url":"https://api.github.com/users/xu-cheng","html_url":"https://github.com/xu-cheng","followers_url":"https://api.github.com/users/xu-cheng/followers","following_url":"https://api.github.com/users/xu-cheng/following{/other_user}","gists_url":"https://api.github.com/users/xu-cheng/gists{/gist_id}","starred_url":"https://api.github.com/users/xu-cheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xu-cheng/subscriptions","organizations_url":"https://api.github.com/users/xu-cheng/orgs","repos_url":"https://api.github.com/users/xu-cheng/repos","events_url":"https://api.github.com/users/xu-cheng/events{/privacy}","received_events_url":"https://api.github.com/users/xu-cheng/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xu-cheng/neovim","description":"vim for the 21st century","fork":true,"url":"https://api.github.com/repos/xu-cheng/neovim","forks_url":"https://api.github.com/repos/xu-cheng/neovim/forks","keys_url":"https://api.github.com/repos/xu-cheng/neovim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xu-cheng/neovim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xu-cheng/neovim/teams","hooks_url":"https://api.github.com/repos/xu-cheng/neovim/hooks","issue_events_url":"https://api.github.com/repos/xu-cheng/neovim/issues/events{/number}","events_url":"https://api.github.com/repos/xu-cheng/neovim/events","assignees_url":"https://api.github.com/repos/xu-cheng/neovim/assignees{/user}","branches_url":"https://api.github.com/repos/xu-cheng/neovim/branches{/branch}","tags_url":"https://api.github.com/repos/xu-cheng/neovim/tags","blobs_url":"https://api.github.com/repos/xu-cheng/neovim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xu-cheng/neovim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xu-cheng/neovim/git/refs{/sha}","trees_url":"https://api.github.com/repos/xu-cheng/neovim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xu-cheng/neovim/statuses/{sha}","languages_url":"https://api.github.com/repos/xu-cheng/neovim/languages","stargazers_url":"https://api.github.com/repos/xu-cheng/neovim/stargazers","contributors_url":"https://api.github.com/repos/xu-cheng/neovim/contributors","subscribers_url":"https://api.github.com/repos/xu-cheng/neovim/subscribers","subscription_url":"https://api.github.com/repos/xu-cheng/neovim/subscription","commits_url":"https://api.github.com/repos/xu-cheng/neovim/commits{/sha}","git_commits_url":"https://api.github.com/repos/xu-cheng/neovim/git/commits{/sha}","comments_url":"https://api.github.com/repos/xu-cheng/neovim/comments{/number}","issue_comment_url":"https://api.github.com/repos/xu-cheng/neovim/issues/comments/{number}","contents_url":"https://api.github.com/repos/xu-cheng/neovim/contents/{+path}","compare_url":"https://api.github.com/repos/xu-cheng/neovim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xu-cheng/neovim/merges","archive_url":"https://api.github.com/repos/xu-cheng/neovim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xu-cheng/neovim/downloads","issues_url":"https://api.github.com/repos/xu-cheng/neovim/issues{/number}","pulls_url":"https://api.github.com/repos/xu-cheng/neovim/pulls{/number}","milestones_url":"https://api.github.com/repos/xu-cheng/neovim/milestones{/number}","notifications_url":"https://api.github.com/repos/xu-cheng/neovim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xu-cheng/neovim/labels{/name}","releases_url":"https://api.github.com/repos/xu-cheng/neovim/releases{/id}","created_at":"2014-07-06T04:56:54Z","updated_at":"2014-10-09T11:03:54Z","pushed_at":"2014-11-06T12:28:30Z","git_url":"git://github.com/xu-cheng/neovim.git","ssh_url":"git@github.com:xu-cheng/neovim.git","clone_url":"https://github.com/xu-cheng/neovim.git","svn_url":"https://github.com/xu-cheng/neovim","homepage":"http://neovim.org/","size":22842,"stargazers_count":0,"watchers_count":0,"language":"VimL","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"neovim:master","ref":"master","sha":"4cc26fba249361cccd791a76fc35c46d851096a5","user":{"login":"neovim","id":6471485,"avatar_url":"https://avatars.githubusercontent.com/u/6471485?v=2","gravatar_id":"","url":"https://api.github.com/users/neovim","html_url":"https://github.com/neovim","followers_url":"https://api.github.com/users/neovim/followers","following_url":"https://api.github.com/users/neovim/following{/other_user}","gists_url":"https://api.github.com/users/neovim/gists{/gist_id}","starred_url":"https://api.github.com/users/neovim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neovim/subscriptions","organizations_url":"https://api.github.com/users/neovim/orgs","repos_url":"https://api.github.com/users/neovim/repos","events_url":"https://api.github.com/users/neovim/events{/privacy}","received_events_url":"https://api.github.com/users/neovim/received_events","type":"Organization","site_admin":false},"repo":{"id":16408992,"name":"neovim","full_name":"neovim/neovim","owner":{"login":"neovim","id":6471485,"avatar_url":"https://avatars.githubusercontent.com/u/6471485?v=2","gravatar_id":"","url":"https://api.github.com/users/neovim","html_url":"https://github.com/neovim","followers_url":"https://api.github.com/users/neovim/followers","following_url":"https://api.github.com/users/neovim/following{/other_user}","gists_url":"https://api.github.com/users/neovim/gists{/gist_id}","starred_url":"https://api.github.com/users/neovim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neovim/subscriptions","organizations_url":"https://api.github.com/users/neovim/orgs","repos_url":"https://api.github.com/users/neovim/repos","events_url":"https://api.github.com/users/neovim/events{/privacy}","received_events_url":"https://api.github.com/users/neovim/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neovim/neovim","description":"vim for the 21st century","fork":false,"url":"https://api.github.com/repos/neovim/neovim","forks_url":"https://api.github.com/repos/neovim/neovim/forks","keys_url":"https://api.github.com/repos/neovim/neovim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neovim/neovim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neovim/neovim/teams","hooks_url":"https://api.github.com/repos/neovim/neovim/hooks","issue_events_url":"https://api.github.com/repos/neovim/neovim/issues/events{/number}","events_url":"https://api.github.com/repos/neovim/neovim/events","assignees_url":"https://api.github.com/repos/neovim/neovim/assignees{/user}","branches_url":"https://api.github.com/repos/neovim/neovim/branches{/branch}","tags_url":"https://api.github.com/repos/neovim/neovim/tags","blobs_url":"https://api.github.com/repos/neovim/neovim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neovim/neovim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neovim/neovim/git/refs{/sha}","trees_url":"https://api.github.com/repos/neovim/neovim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neovim/neovim/statuses/{sha}","languages_url":"https://api.github.com/repos/neovim/neovim/languages","stargazers_url":"https://api.github.com/repos/neovim/neovim/stargazers","contributors_url":"https://api.github.com/repos/neovim/neovim/contributors","subscribers_url":"https://api.github.com/repos/neovim/neovim/subscribers","subscription_url":"https://api.github.com/repos/neovim/neovim/subscription","commits_url":"https://api.github.com/repos/neovim/neovim/commits{/sha}","git_commits_url":"https://api.github.com/repos/neovim/neovim/git/commits{/sha}","comments_url":"https://api.github.com/repos/neovim/neovim/comments{/number}","issue_comment_url":"https://api.github.com/repos/neovim/neovim/issues/comments/{number}","contents_url":"https://api.github.com/repos/neovim/neovim/contents/{+path}","compare_url":"https://api.github.com/repos/neovim/neovim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neovim/neovim/merges","archive_url":"https://api.github.com/repos/neovim/neovim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neovim/neovim/downloads","issues_url":"https://api.github.com/repos/neovim/neovim/issues{/number}","pulls_url":"https://api.github.com/repos/neovim/neovim/pulls{/number}","milestones_url":"https://api.github.com/repos/neovim/neovim/milestones{/number}","notifications_url":"https://api.github.com/repos/neovim/neovim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neovim/neovim/labels{/name}","releases_url":"https://api.github.com/repos/neovim/neovim/releases{/id}","created_at":"2014-01-31T13:39:22Z","updated_at":"2014-11-07T00:48:19Z","pushed_at":"2014-11-06T22:09:40Z","git_url":"git://github.com/neovim/neovim.git","ssh_url":"git@github.com:neovim/neovim.git","clone_url":"https://github.com/neovim/neovim.git","svn_url":"https://github.com/neovim/neovim","homepage":"http://neovim.org/","size":63375,"stargazers_count":10439,"watchers_count":10439,"language":"VimL","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":678,"mirror_url":null,"open_issues_count":265,"forks":678,"open_issues":265,"watchers":10439,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/neovim/neovim/pulls/1411"},"html":{"href":"https://github.com/neovim/neovim/pull/1411"},"issue":{"href":"https://api.github.com/repos/neovim/neovim/issues/1411"},"comments":{"href":"https://api.github.com/repos/neovim/neovim/issues/1411/comments"},"review_comments":{"href":"https://api.github.com/repos/neovim/neovim/pulls/1411/comments"},"review_comment":{"href":"https://api.github.com/repos/neovim/neovim/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/neovim/neovim/pulls/1411/commits"},"statuses":{"href":"https://api.github.com/repos/neovim/neovim/statuses/0999344e425109e926d9c297543eee754434f859"}}}}