GitHub PullRequestReviewCommentEvent at 2014-07-08 20:16:30
Repository: zeroclickinfo-spice
Actor: killerfish
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/pulls/comments/14677638","id":14677638,"diff_hunk":"@@ -0,0 +1,25 @@\n+package DDG::Spice::Steam::Specials;\n+# ABSTRACT: Fetch Steam Specials at Steam store.\n+\n+use DDG::Spice;\n+\n+name \"steam\";\n+source \"http://store.steampowered.com\";\n+description \"Get featured games on sale at Steam store\";\n+primary_example_queries \"steam specials\";\n+category \"special\";\n+topics \"gaming\",\"entertainment\";\n+icon_url \"/i/store.steampowered.com.ico\";\n+code_url \"https://github.com/duckduckgo/zeroclickinfo-spice/blob/master/lib/DDG/Spice/Steam/Specials.pm\";\n+attribution github => [\"https://github.com/killerfish\", \"Usman Raza\"],\n+            twitter => [\"https://twitter.com/f1shie\", \"Usman Raza\"];\n+\n+triggers startend => \"steam special\", \"steam specials\", \"steam store\", \"steam offers\", \"steam offer\";\n+spice to => 'http://store.steampowered.com/api/getappsincategory?category=cat_specials$1';","path":"lib/DDG/Spice/Steam/Specials.pm","position":18,"original_position":18,"commit_id":"4710c4458ded0941d51270408c54f7c0be0fc3ea","original_commit_id":"4710c4458ded0941d51270408c54f7c0be0fc3ea","user":{"login":"killerfish","id":1424236,"avatar_url":"https://avatars.githubusercontent.com/u/1424236?","gravatar_id":"b0b2b9004b2a304b049c673d03badea8","url":"https://api.github.com/users/killerfish","html_url":"https://github.com/killerfish","followers_url":"https://api.github.com/users/killerfish/followers","following_url":"https://api.github.com/users/killerfish/following{/other_user}","gists_url":"https://api.github.com/users/killerfish/gists{/gist_id}","starred_url":"https://api.github.com/users/killerfish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/killerfish/subscriptions","organizations_url":"https://api.github.com/users/killerfish/orgs","repos_url":"https://api.github.com/users/killerfish/repos","events_url":"https://api.github.com/users/killerfish/events{/privacy}","received_events_url":"https://api.github.com/users/killerfish/received_events","type":"User","site_admin":false},"body":"This is was something i noticed that, if i dont return an empty string to $1 (could be anywhere in the spice url), it does not trigger the spice. I was doing the plain \r\nreturn $_ if $_;\r\nreturn;\r\nbefore like in the hackage IA, but that didnt seemed to work for this call, perhaps it just fetches the json in hackage ia case, and in this case expects something to be returned to trigger that call. Could you confirm this, ty ","created_at":"2014-07-08T20:16:30Z","updated_at":"2014-07-08T20:16:30Z","html_url":"https://github.com/duckduckgo/zeroclickinfo-spice/pull/859#discussion_r14677638","pull_request_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/pulls/859","_links":{"self":{"href":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/pulls/comments/14677638"},"html":{"href":"https://github.com/duckduckgo/zeroclickinfo-spice/pull/859#discussion_r14677638"},"pull_request":{"href":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/pulls/859"}}},"pull_request":{"url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/pulls/859","id":16855623,"html_url":"https://github.com/duckduckgo/zeroclickinfo-spice/pull/859","diff_url":"https://github.com/duckduckgo/zeroclickinfo-spice/pull/859.diff","patch_url":"https://github.com/duckduckgo/zeroclickinfo-spice/pull/859.patch","issue_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/issues/859","number":859,"state":"open","title":"steam specials","user":{"login":"killerfish","id":1424236,"avatar_url":"https://avatars.githubusercontent.com/u/1424236?","gravatar_id":"b0b2b9004b2a304b049c673d03badea8","url":"https://api.github.com/users/killerfish","html_url":"https://github.com/killerfish","followers_url":"https://api.github.com/users/killerfish/followers","following_url":"https://api.github.com/users/killerfish/following{/other_user}","gists_url":"https://api.github.com/users/killerfish/gists{/gist_id}","starred_url":"https://api.github.com/users/killerfish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/killerfish/subscriptions","organizations_url":"https://api.github.com/users/killerfish/orgs","repos_url":"https://api.github.com/users/killerfish/repos","events_url":"https://api.github.com/users/killerfish/events{/privacy}","received_events_url":"https://api.github.com/users/killerfish/received_events","type":"User","site_admin":false},"body":"**What does your instant answer do?**\r\nFetch steam specials at Steam Store\r\n\r\n**What problem does your instant answer solve (Why is it better than organic links)?**\r\nGet to instantly know best Steam offers\r\n\r\n**What is the data source for your instant answer? (Provide a link if possible)**\r\nOfficial Steam Store (http://store.steampowered.com/)\r\n\r\n**Why did you choose this data source?**\r\nSteam api\r\n\r\n**Are there any other alternative (better) data sources?**\r\nNo\r\n\r\n**What are some example queries that trigger this instant answer?**\r\nsteam specials, steam offers\r\n\r\n**Which communities will this instant answer be especially useful for? (gamers, book lovers, etc)**\r\ngamers\r\n\r\n**Is this instant answer connected to a DuckDuckHack [instant answer idea](https://duck.co/ideas)?**\r\nYes, [here] (https://duck.co/ideas/idea/976/steam-sales)\r\n\r\n**Which existing instant answers will this one supersede/overlap with?**\r\n Steamdb perhaps\r\n\r\n**Are you having any problems? Do you need our help with anything?**\r\nI wanted to include steam game info <game_name>, but that requires to fetch a gamelist (returns json with some 30k records) from steam every time a request is made and then pass the matching id for a spice call. Im not sure, this scenario fits the spice IA perfectly, what to do? \r\nAlso please advise on the pending issue with pr #846 and #845(use of spice wrap_string_callback), so i can update accordingly. Ty.\r\n\r\n**\\*\\*Note:** Please attach a screenshot for new instant answer pull requests, and for pull requests which modify the look/design of existing instant answers.\r\n![special_1](https://cloud.githubusercontent.com/assets/1424236/3209215/7279a7ec-ee60-11e3-87b9-21ee6c780ff0.png)\r\n![special_2](https://cloud.githubusercontent.com/assets/1424236/3209216/7f0a7d7e-ee60-11e3-9310-4867b7a14cc1.png)\r\n\r\n##Checklist\r\nPlease place an 'X' where appropriate.\r\n\r\n```\r\n[X] Added metadata and attribution information\r\n[X] Wrote test file and added to t/ directory\r\n[X] Verified that instant answer adheres to design guidelines(https://github.com/duckduckgo/duckduckgo-documentation/blob/master/duckduckhack/styleguides/design_styleguide.md)\r\n[X] Tested cross-browser compatability\r\n\r\n    Please let us know which browsers/devices you've tested on:\r\n      - Mac OSX\r\n        [X] Google Chrome   \r\n        [X] Firefox       \r\n```\r\n","created_at":"2014-06-07T16:39:03Z","updated_at":"2014-07-08T20:16:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0cc45904696d71fc952a0e9d9ab0a1aa06ba82c5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/pulls/859/commits","review_comments_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/pulls/859/comments","review_comment_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/pulls/comments/{number}","comments_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/issues/859/comments","statuses_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/statuses/4710c4458ded0941d51270408c54f7c0be0fc3ea","head":{"label":"killerfish:steamspecial","ref":"steamspecial","sha":"4710c4458ded0941d51270408c54f7c0be0fc3ea","user":{"login":"killerfish","id":1424236,"avatar_url":"https://avatars.githubusercontent.com/u/1424236?","gravatar_id":"b0b2b9004b2a304b049c673d03badea8","url":"https://api.github.com/users/killerfish","html_url":"https://github.com/killerfish","followers_url":"https://api.github.com/users/killerfish/followers","following_url":"https://api.github.com/users/killerfish/following{/other_user}","gists_url":"https://api.github.com/users/killerfish/gists{/gist_id}","starred_url":"https://api.github.com/users/killerfish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/killerfish/subscriptions","organizations_url":"https://api.github.com/users/killerfish/orgs","repos_url":"https://api.github.com/users/killerfish/repos","events_url":"https://api.github.com/users/killerfish/events{/privacy}","received_events_url":"https://api.github.com/users/killerfish/received_events","type":"User","site_admin":false},"repo":{"id":18378950,"name":"zeroclickinfo-spice","full_name":"killerfish/zeroclickinfo-spice","owner":{"login":"killerfish","id":1424236,"avatar_url":"https://avatars.githubusercontent.com/u/1424236?","gravatar_id":"b0b2b9004b2a304b049c673d03badea8","url":"https://api.github.com/users/killerfish","html_url":"https://github.com/killerfish","followers_url":"https://api.github.com/users/killerfish/followers","following_url":"https://api.github.com/users/killerfish/following{/other_user}","gists_url":"https://api.github.com/users/killerfish/gists{/gist_id}","starred_url":"https://api.github.com/users/killerfish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/killerfish/subscriptions","organizations_url":"https://api.github.com/users/killerfish/orgs","repos_url":"https://api.github.com/users/killerfish/repos","events_url":"https://api.github.com/users/killerfish/events{/privacy}","received_events_url":"https://api.github.com/users/killerfish/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/killerfish/zeroclickinfo-spice","description":"DuckDuckGo instant answer plugins based on JavaScript APIs","fork":true,"url":"https://api.github.com/repos/killerfish/zeroclickinfo-spice","forks_url":"https://api.github.com/repos/killerfish/zeroclickinfo-spice/forks","keys_url":"https://api.github.com/repos/killerfish/zeroclickinfo-spice/keys{/key_id}","collaborators_url":"https://api.github.com/repos/killerfish/zeroclickinfo-spice/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/killerfish/zeroclickinfo-spice/teams","hooks_url":"https://api.github.com/repos/killerfish/zeroclickinfo-spice/hooks","issue_events_url":"https://api.github.com/repos/killerfish/zeroclickinfo-spice/issues/events{/number}","events_url":"https://api.github.com/repos/killerfish/zeroclickinfo-spice/events","assignees_url":"https://api.github.com/repos/killerfish/zeroclickinfo-spice/assignees{/user}","branches_url":"https://api.github.com/repos/killerfish/zeroclickinfo-spice/branches{/branch}","tags_url":"https://api.github.com/repos/killerfish/zeroclickinfo-spice/tags","blobs_url":"https://api.github.com/repos/killerfish/zeroclickinfo-spice/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/killerfish/zeroclickinfo-spice/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/killerfish/zeroclickinfo-spice/git/refs{/sha}","trees_url":"https://api.github.com/repos/killerfish/zeroclickinfo-spice/git/trees{/sha}","statuses_url":"https://api.github.com/repos/killerfish/zeroclickinfo-spice/statuses/{sha}","languages_url":"https://api.github.com/repos/killerfish/zeroclickinfo-spice/languages","stargazers_url":"https://api.github.com/repos/killerfish/zeroclickinfo-spice/stargazers","contributors_url":"https://api.github.com/repos/killerfish/zeroclickinfo-spice/contributors","subscribers_url":"https://api.github.com/repos/killerfish/zeroclickinfo-spice/subscribers","subscription_url":"https://api.github.com/repos/killerfish/zeroclickinfo-spice/subscription","commits_url":"https://api.github.com/repos/killerfish/zeroclickinfo-spice/commits{/sha}","git_commits_url":"https://api.github.com/repos/killerfish/zeroclickinfo-spice/git/commits{/sha}","comments_url":"https://api.github.com/repos/killerfish/zeroclickinfo-spice/comments{/number}","issue_comment_url":"https://api.github.com/repos/killerfish/zeroclickinfo-spice/issues/comments/{number}","contents_url":"https://api.github.com/repos/killerfish/zeroclickinfo-spice/contents/{+path}","compare_url":"https://api.github.com/repos/killerfish/zeroclickinfo-spice/compare/{base}...{head}","merges_url":"https://api.github.com/repos/killerfish/zeroclickinfo-spice/merges","archive_url":"https://api.github.com/repos/killerfish/zeroclickinfo-spice/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/killerfish/zeroclickinfo-spice/downloads","issues_url":"https://api.github.com/repos/killerfish/zeroclickinfo-spice/issues{/number}","pulls_url":"https://api.github.com/repos/killerfish/zeroclickinfo-spice/pulls{/number}","milestones_url":"https://api.github.com/repos/killerfish/zeroclickinfo-spice/milestones{/number}","notifications_url":"https://api.github.com/repos/killerfish/zeroclickinfo-spice/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/killerfish/zeroclickinfo-spice/labels{/name}","releases_url":"https://api.github.com/repos/killerfish/zeroclickinfo-spice/releases{/id}","created_at":"2014-04-02T19:40:50Z","updated_at":"2014-06-23T16:35:06Z","pushed_at":"2014-06-30T10:53:51Z","git_url":"git://github.com/killerfish/zeroclickinfo-spice.git","ssh_url":"git@github.com:killerfish/zeroclickinfo-spice.git","clone_url":"https://github.com/killerfish/zeroclickinfo-spice.git","svn_url":"https://github.com/killerfish/zeroclickinfo-spice","homepage":"http://duckduckhack.com/","size":10311,"stargazers_count":0,"watchers_count":0,"language":"Perl","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"duckduckgo:master","ref":"master","sha":"eed687a2e2f2ce320feaee24716f9d2d336a3860","user":{"login":"duckduckgo","id":342708,"avatar_url":"https://avatars.githubusercontent.com/u/342708?","gravatar_id":"5990c802462deecd497116fb037eb05a","url":"https://api.github.com/users/duckduckgo","html_url":"https://github.com/duckduckgo","followers_url":"https://api.github.com/users/duckduckgo/followers","following_url":"https://api.github.com/users/duckduckgo/following{/other_user}","gists_url":"https://api.github.com/users/duckduckgo/gists{/gist_id}","starred_url":"https://api.github.com/users/duckduckgo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duckduckgo/subscriptions","organizations_url":"https://api.github.com/users/duckduckgo/orgs","repos_url":"https://api.github.com/users/duckduckgo/repos","events_url":"https://api.github.com/users/duckduckgo/events{/privacy}","received_events_url":"https://api.github.com/users/duckduckgo/received_events","type":"Organization","site_admin":false},"repo":{"id":1997671,"name":"zeroclickinfo-spice","full_name":"duckduckgo/zeroclickinfo-spice","owner":{"login":"duckduckgo","id":342708,"avatar_url":"https://avatars.githubusercontent.com/u/342708?","gravatar_id":"5990c802462deecd497116fb037eb05a","url":"https://api.github.com/users/duckduckgo","html_url":"https://github.com/duckduckgo","followers_url":"https://api.github.com/users/duckduckgo/followers","following_url":"https://api.github.com/users/duckduckgo/following{/other_user}","gists_url":"https://api.github.com/users/duckduckgo/gists{/gist_id}","starred_url":"https://api.github.com/users/duckduckgo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duckduckgo/subscriptions","organizations_url":"https://api.github.com/users/duckduckgo/orgs","repos_url":"https://api.github.com/users/duckduckgo/repos","events_url":"https://api.github.com/users/duckduckgo/events{/privacy}","received_events_url":"https://api.github.com/users/duckduckgo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/duckduckgo/zeroclickinfo-spice","description":"DuckDuckGo instant answer plugins based on JavaScript APIs","fork":false,"url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice","forks_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/forks","keys_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/keys{/key_id}","collaborators_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/teams","hooks_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/hooks","issue_events_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/issues/events{/number}","events_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/events","assignees_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/assignees{/user}","branches_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/branches{/branch}","tags_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/tags","blobs_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/git/refs{/sha}","trees_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/git/trees{/sha}","statuses_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/statuses/{sha}","languages_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/languages","stargazers_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/stargazers","contributors_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/contributors","subscribers_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/subscribers","subscription_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/subscription","commits_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/commits{/sha}","git_commits_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/git/commits{/sha}","comments_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/comments{/number}","issue_comment_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/issues/comments/{number}","contents_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/contents/{+path}","compare_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/compare/{base}...{head}","merges_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/merges","archive_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/downloads","issues_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/issues{/number}","pulls_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/pulls{/number}","milestones_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/milestones{/number}","notifications_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/labels{/name}","releases_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/releases{/id}","created_at":"2011-07-04T22:08:37Z","updated_at":"2014-07-05T00:02:52Z","pushed_at":"2014-07-07T15:06:54Z","git_url":"git://github.com/duckduckgo/zeroclickinfo-spice.git","ssh_url":"git@github.com:duckduckgo/zeroclickinfo-spice.git","clone_url":"https://github.com/duckduckgo/zeroclickinfo-spice.git","svn_url":"https://github.com/duckduckgo/zeroclickinfo-spice","homepage":"http://duckduckhack.com/","size":32489,"stargazers_count":167,"watchers_count":167,"language":"Perl","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":276,"mirror_url":null,"open_issues_count":123,"forks":276,"open_issues":123,"watchers":167,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/pulls/859"},"html":{"href":"https://github.com/duckduckgo/zeroclickinfo-spice/pull/859"},"issue":{"href":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/issues/859"},"comments":{"href":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/issues/859/comments"},"review_comments":{"href":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/pulls/859/comments"},"review_comment":{"href":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/pulls/859/commits"},"statuses":{"href":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/statuses/4710c4458ded0941d51270408c54f7c0be0fc3ea"}}}}