GitHub PullRequestReviewCommentEvent at 2014-12-17 20:05:28
Repository: imgd
Actor: clone1018
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/minotar/imgd/pulls/comments/21999800","id":21999800,"diff_hunk":"@@ -101,8 +101,8 @@ func (router *Router) Serve(resource string) {\n \t\t}\n \n \t\tw.Header().Add(\"Content-Type\", \"image/png\")\n-\t\tw.Header().Add(\"X-Skin-Hash\", skin.Hash)\n-\t\tw.Header().Add(\"Cache-Control\", fmt.Sprintf(\"max-age=%d\", TimeoutActualSkin))\n+\t\tw.Header().Add(\"Cache-Control\", fmt.Sprintf(\"public, max-age=%d\", TimeoutActualSkin))\n+\t\tw.Header().Add(\"ETag\", skin.Hash)","path":"http.go","position":7,"original_position":7,"commit_id":"b6c55c4735b6c0cc58dea6704598262441188e35","original_commit_id":"b6c55c4735b6c0cc58dea6704598262441188e35","user":{"login":"clone1018","id":226638,"avatar_url":"https://avatars.githubusercontent.com/u/226638?v=3","gravatar_id":"","url":"https://api.github.com/users/clone1018","html_url":"https://github.com/clone1018","followers_url":"https://api.github.com/users/clone1018/followers","following_url":"https://api.github.com/users/clone1018/following{/other_user}","gists_url":"https://api.github.com/users/clone1018/gists{/gist_id}","starred_url":"https://api.github.com/users/clone1018/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clone1018/subscriptions","organizations_url":"https://api.github.com/users/clone1018/orgs","repos_url":"https://api.github.com/users/clone1018/repos","events_url":"https://api.github.com/users/clone1018/events{/privacy}","received_events_url":"https://api.github.com/users/clone1018/received_events","type":"User","site_admin":false},"body":"This is no good, currently if we return a skin from cache the hash is \"\" hashed.","created_at":"2014-12-17T20:05:28Z","updated_at":"2014-12-17T20:05:28Z","html_url":"https://github.com/minotar/imgd/pull/133#discussion_r21999800","pull_request_url":"https://api.github.com/repos/minotar/imgd/pulls/133","_links":{"self":{"href":"https://api.github.com/repos/minotar/imgd/pulls/comments/21999800"},"html":{"href":"https://github.com/minotar/imgd/pull/133#discussion_r21999800"},"pull_request":{"href":"https://api.github.com/repos/minotar/imgd/pulls/133"}}},"pull_request":{"url":"https://api.github.com/repos/minotar/imgd/pulls/133","id":26251829,"html_url":"https://github.com/minotar/imgd/pull/133","diff_url":"https://github.com/minotar/imgd/pull/133.diff","patch_url":"https://github.com/minotar/imgd/pull/133.patch","issue_url":"https://api.github.com/repos/minotar/imgd/issues/133","number":133,"state":"open","locked":false,"title":"Add ETag, specify public cache","user":{"login":"connor4312","id":2230985,"avatar_url":"https://avatars.githubusercontent.com/u/2230985?v=3","gravatar_id":"","url":"https://api.github.com/users/connor4312","html_url":"https://github.com/connor4312","followers_url":"https://api.github.com/users/connor4312/followers","following_url":"https://api.github.com/users/connor4312/following{/other_user}","gists_url":"https://api.github.com/users/connor4312/gists{/gist_id}","starred_url":"https://api.github.com/users/connor4312/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/connor4312/subscriptions","organizations_url":"https://api.github.com/users/connor4312/orgs","repos_url":"https://api.github.com/users/connor4312/repos","events_url":"https://api.github.com/users/connor4312/events{/privacy}","received_events_url":"https://api.github.com/users/connor4312/received_events","type":"User","site_admin":false},"body":"Based on research in regards to #85","created_at":"2014-12-17T19:59:36Z","updated_at":"2014-12-17T20:05:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"87dd4619dcc3813309298831873ead9b5e2efd36","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/minotar/imgd/pulls/133/commits","review_comments_url":"https://api.github.com/repos/minotar/imgd/pulls/133/comments","review_comment_url":"https://api.github.com/repos/minotar/imgd/pulls/comments/{number}","comments_url":"https://api.github.com/repos/minotar/imgd/issues/133/comments","statuses_url":"https://api.github.com/repos/minotar/imgd/statuses/b6c55c4735b6c0cc58dea6704598262441188e35","head":{"label":"minotar:cache-headers","ref":"cache-headers","sha":"b6c55c4735b6c0cc58dea6704598262441188e35","user":{"login":"minotar","id":5984724,"avatar_url":"https://avatars.githubusercontent.com/u/5984724?v=3","gravatar_id":"","url":"https://api.github.com/users/minotar","html_url":"https://github.com/minotar","followers_url":"https://api.github.com/users/minotar/followers","following_url":"https://api.github.com/users/minotar/following{/other_user}","gists_url":"https://api.github.com/users/minotar/gists{/gist_id}","starred_url":"https://api.github.com/users/minotar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minotar/subscriptions","organizations_url":"https://api.github.com/users/minotar/orgs","repos_url":"https://api.github.com/users/minotar/repos","events_url":"https://api.github.com/users/minotar/events{/privacy}","received_events_url":"https://api.github.com/users/minotar/received_events","type":"Organization","site_admin":false},"repo":{"id":3464544,"name":"imgd","full_name":"minotar/imgd","owner":{"login":"minotar","id":5984724,"avatar_url":"https://avatars.githubusercontent.com/u/5984724?v=3","gravatar_id":"","url":"https://api.github.com/users/minotar","html_url":"https://github.com/minotar","followers_url":"https://api.github.com/users/minotar/followers","following_url":"https://api.github.com/users/minotar/following{/other_user}","gists_url":"https://api.github.com/users/minotar/gists{/gist_id}","starred_url":"https://api.github.com/users/minotar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minotar/subscriptions","organizations_url":"https://api.github.com/users/minotar/orgs","repos_url":"https://api.github.com/users/minotar/repos","events_url":"https://api.github.com/users/minotar/events{/privacy}","received_events_url":"https://api.github.com/users/minotar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/minotar/imgd","description":"A Minotar is a global avatar that pulls your head off of your Minecraft.net skin, and allows it for use on several thousand sites. ","fork":false,"url":"https://api.github.com/repos/minotar/imgd","forks_url":"https://api.github.com/repos/minotar/imgd/forks","keys_url":"https://api.github.com/repos/minotar/imgd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/minotar/imgd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/minotar/imgd/teams","hooks_url":"https://api.github.com/repos/minotar/imgd/hooks","issue_events_url":"https://api.github.com/repos/minotar/imgd/issues/events{/number}","events_url":"https://api.github.com/repos/minotar/imgd/events","assignees_url":"https://api.github.com/repos/minotar/imgd/assignees{/user}","branches_url":"https://api.github.com/repos/minotar/imgd/branches{/branch}","tags_url":"https://api.github.com/repos/minotar/imgd/tags","blobs_url":"https://api.github.com/repos/minotar/imgd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/minotar/imgd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/minotar/imgd/git/refs{/sha}","trees_url":"https://api.github.com/repos/minotar/imgd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/minotar/imgd/statuses/{sha}","languages_url":"https://api.github.com/repos/minotar/imgd/languages","stargazers_url":"https://api.github.com/repos/minotar/imgd/stargazers","contributors_url":"https://api.github.com/repos/minotar/imgd/contributors","subscribers_url":"https://api.github.com/repos/minotar/imgd/subscribers","subscription_url":"https://api.github.com/repos/minotar/imgd/subscription","commits_url":"https://api.github.com/repos/minotar/imgd/commits{/sha}","git_commits_url":"https://api.github.com/repos/minotar/imgd/git/commits{/sha}","comments_url":"https://api.github.com/repos/minotar/imgd/comments{/number}","issue_comment_url":"https://api.github.com/repos/minotar/imgd/issues/comments/{number}","contents_url":"https://api.github.com/repos/minotar/imgd/contents/{+path}","compare_url":"https://api.github.com/repos/minotar/imgd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/minotar/imgd/merges","archive_url":"https://api.github.com/repos/minotar/imgd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/minotar/imgd/downloads","issues_url":"https://api.github.com/repos/minotar/imgd/issues{/number}","pulls_url":"https://api.github.com/repos/minotar/imgd/pulls{/number}","milestones_url":"https://api.github.com/repos/minotar/imgd/milestones{/number}","notifications_url":"https://api.github.com/repos/minotar/imgd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/minotar/imgd/labels{/name}","releases_url":"https://api.github.com/repos/minotar/imgd/releases{/id}","created_at":"2012-02-16T22:09:04Z","updated_at":"2014-12-17T11:33:26Z","pushed_at":"2014-12-17T20:04:01Z","git_url":"git://github.com/minotar/imgd.git","ssh_url":"git@github.com:minotar/imgd.git","clone_url":"https://github.com/minotar/imgd.git","svn_url":"https://github.com/minotar/imgd","homepage":"http://minotar.net/","size":1825,"stargazers_count":92,"watchers_count":92,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":59,"mirror_url":null,"open_issues_count":12,"forks":59,"open_issues":12,"watchers":92,"default_branch":"master"}},"base":{"label":"minotar:master","ref":"master","sha":"0bb4ac1298cc942f154a33b5e70e4727326aa927","user":{"login":"minotar","id":5984724,"avatar_url":"https://avatars.githubusercontent.com/u/5984724?v=3","gravatar_id":"","url":"https://api.github.com/users/minotar","html_url":"https://github.com/minotar","followers_url":"https://api.github.com/users/minotar/followers","following_url":"https://api.github.com/users/minotar/following{/other_user}","gists_url":"https://api.github.com/users/minotar/gists{/gist_id}","starred_url":"https://api.github.com/users/minotar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minotar/subscriptions","organizations_url":"https://api.github.com/users/minotar/orgs","repos_url":"https://api.github.com/users/minotar/repos","events_url":"https://api.github.com/users/minotar/events{/privacy}","received_events_url":"https://api.github.com/users/minotar/received_events","type":"Organization","site_admin":false},"repo":{"id":3464544,"name":"imgd","full_name":"minotar/imgd","owner":{"login":"minotar","id":5984724,"avatar_url":"https://avatars.githubusercontent.com/u/5984724?v=3","gravatar_id":"","url":"https://api.github.com/users/minotar","html_url":"https://github.com/minotar","followers_url":"https://api.github.com/users/minotar/followers","following_url":"https://api.github.com/users/minotar/following{/other_user}","gists_url":"https://api.github.com/users/minotar/gists{/gist_id}","starred_url":"https://api.github.com/users/minotar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minotar/subscriptions","organizations_url":"https://api.github.com/users/minotar/orgs","repos_url":"https://api.github.com/users/minotar/repos","events_url":"https://api.github.com/users/minotar/events{/privacy}","received_events_url":"https://api.github.com/users/minotar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/minotar/imgd","description":"A Minotar is a global avatar that pulls your head off of your Minecraft.net skin, and allows it for use on several thousand sites. ","fork":false,"url":"https://api.github.com/repos/minotar/imgd","forks_url":"https://api.github.com/repos/minotar/imgd/forks","keys_url":"https://api.github.com/repos/minotar/imgd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/minotar/imgd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/minotar/imgd/teams","hooks_url":"https://api.github.com/repos/minotar/imgd/hooks","issue_events_url":"https://api.github.com/repos/minotar/imgd/issues/events{/number}","events_url":"https://api.github.com/repos/minotar/imgd/events","assignees_url":"https://api.github.com/repos/minotar/imgd/assignees{/user}","branches_url":"https://api.github.com/repos/minotar/imgd/branches{/branch}","tags_url":"https://api.github.com/repos/minotar/imgd/tags","blobs_url":"https://api.github.com/repos/minotar/imgd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/minotar/imgd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/minotar/imgd/git/refs{/sha}","trees_url":"https://api.github.com/repos/minotar/imgd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/minotar/imgd/statuses/{sha}","languages_url":"https://api.github.com/repos/minotar/imgd/languages","stargazers_url":"https://api.github.com/repos/minotar/imgd/stargazers","contributors_url":"https://api.github.com/repos/minotar/imgd/contributors","subscribers_url":"https://api.github.com/repos/minotar/imgd/subscribers","subscription_url":"https://api.github.com/repos/minotar/imgd/subscription","commits_url":"https://api.github.com/repos/minotar/imgd/commits{/sha}","git_commits_url":"https://api.github.com/repos/minotar/imgd/git/commits{/sha}","comments_url":"https://api.github.com/repos/minotar/imgd/comments{/number}","issue_comment_url":"https://api.github.com/repos/minotar/imgd/issues/comments/{number}","contents_url":"https://api.github.com/repos/minotar/imgd/contents/{+path}","compare_url":"https://api.github.com/repos/minotar/imgd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/minotar/imgd/merges","archive_url":"https://api.github.com/repos/minotar/imgd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/minotar/imgd/downloads","issues_url":"https://api.github.com/repos/minotar/imgd/issues{/number}","pulls_url":"https://api.github.com/repos/minotar/imgd/pulls{/number}","milestones_url":"https://api.github.com/repos/minotar/imgd/milestones{/number}","notifications_url":"https://api.github.com/repos/minotar/imgd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/minotar/imgd/labels{/name}","releases_url":"https://api.github.com/repos/minotar/imgd/releases{/id}","created_at":"2012-02-16T22:09:04Z","updated_at":"2014-12-17T11:33:26Z","pushed_at":"2014-12-17T20:04:01Z","git_url":"git://github.com/minotar/imgd.git","ssh_url":"git@github.com:minotar/imgd.git","clone_url":"https://github.com/minotar/imgd.git","svn_url":"https://github.com/minotar/imgd","homepage":"http://minotar.net/","size":1825,"stargazers_count":92,"watchers_count":92,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":59,"mirror_url":null,"open_issues_count":12,"forks":59,"open_issues":12,"watchers":92,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/minotar/imgd/pulls/133"},"html":{"href":"https://github.com/minotar/imgd/pull/133"},"issue":{"href":"https://api.github.com/repos/minotar/imgd/issues/133"},"comments":{"href":"https://api.github.com/repos/minotar/imgd/issues/133/comments"},"review_comments":{"href":"https://api.github.com/repos/minotar/imgd/pulls/133/comments"},"review_comment":{"href":"https://api.github.com/repos/minotar/imgd/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/minotar/imgd/pulls/133/commits"},"statuses":{"href":"https://api.github.com/repos/minotar/imgd/statuses/b6c55c4735b6c0cc58dea6704598262441188e35"}}}}