GitHub PullRequestReviewCommentEvent at 2014-08-26 02:39:49
Repository: zc-v1-series
Actor: IronLady
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/zencart/zc-v1-series/pulls/comments/16693219","id":16693219,"diff_hunk":"@@ -53,13 +53,12 @@ function trail($separator = '&nbsp;&nbsp;') {\n       if (isset($this->_trail[$i]['link']) && zen_not_null($this->_trail[$i]['link']) && !$skip_link ) {\r\n         // this line simply sets the \"Home\" link to be the domain/url, not main_page=index?blahblah:\r\n         if ($this->_trail[$i]['title'] == HEADER_TITLE_CATALOG) {\r\n-          $trail_string .= '  <a ' . ($i==($n-1) ? 'itemprop=\"url\" ' : '') . 'href=\"' . ($request_type != 'SSL' ? HTTP_SERVER . DIR_WS_CATALOG : HTTPS_SERVER . DIR_WS_HTTPS_CATALOG) . '\">' . $this->_trail[$i]['title'] . '</a>';\r\n+          $trail_string .= '  <a href=\"' . ($request_type != 'SSL' ? HTTP_SERVER . DIR_WS_CATALOG : HTTPS_SERVER . DIR_WS_HTTPS_CATALOG) . '\">' . $this->_trail[$i]['title'] . '</a>';\r\n         } else {\r\n-          $trail_string .= '  <a ' . ($i==($n-1) ? 'itemprop=\"url\" ' : '') . 'href=\"' . $this->_trail[$i]['link'] . '\">' . '<span itemprop=\"title\">' . $this->_trail[$i]['title'] . '</span>' . '</a>';\r\n+          $trail_string .= '  <span itemscope itemtype=\"http://data-vocabulary.org/Breadcrumb\"><a itemprop=\"url\" href=\"' . $this->_trail[$i]['link'] . '\">' . '<span itemprop=\"title\">' . $this->_trail[$i]['title'] . '</span>' . '</a></span>';\r","path":"includes/classes/breadcrumb.php","position":null,"original_position":8,"commit_id":"cdf284c11426cdb86ff7a47e0ed54f16f92b6f58","original_commit_id":"d51c4d706406a825b9f1313bfad3331d89e70a0c","user":{"login":"IronLady","id":1428276,"avatar_url":"https://avatars.githubusercontent.com/u/1428276?v=2","gravatar_id":"fcaa53e946b4d8eb4d26d050588f256d","url":"https://api.github.com/users/IronLady","html_url":"https://github.com/IronLady","followers_url":"https://api.github.com/users/IronLady/followers","following_url":"https://api.github.com/users/IronLady/following{/other_user}","gists_url":"https://api.github.com/users/IronLady/gists{/gist_id}","starred_url":"https://api.github.com/users/IronLady/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IronLady/subscriptions","organizations_url":"https://api.github.com/users/IronLady/orgs","repos_url":"https://api.github.com/users/IronLady/repos","events_url":"https://api.github.com/users/IronLady/events{/privacy}","received_events_url":"https://api.github.com/users/IronLady/received_events","type":"User","site_admin":false},"body":"For consistency, I think we shouldn't break it onto multiple line.","created_at":"2014-08-26T02:39:49Z","updated_at":"2014-08-26T02:39:49Z","html_url":"https://github.com/zencart/zc-v1-series/pull/134#discussion_r16693219","pull_request_url":"https://api.github.com/repos/zencart/zc-v1-series/pulls/134","_links":{"self":{"href":"https://api.github.com/repos/zencart/zc-v1-series/pulls/comments/16693219"},"html":{"href":"https://github.com/zencart/zc-v1-series/pull/134#discussion_r16693219"},"pull_request":{"href":"https://api.github.com/repos/zencart/zc-v1-series/pulls/134"}}},"pull_request":{"url":"https://api.github.com/repos/zencart/zc-v1-series/pulls/134","id":19991355,"html_url":"https://github.com/zencart/zc-v1-series/pull/134","diff_url":"https://github.com/zencart/zc-v1-series/pull/134.diff","patch_url":"https://github.com/zencart/zc-v1-series/pull/134.patch","issue_url":"https://api.github.com/repos/zencart/zc-v1-series/issues/134","number":134,"state":"open","locked":false,"title":"Breadcrumb Rich Snippets Microdata","user":{"login":"IronLady","id":1428276,"avatar_url":"https://avatars.githubusercontent.com/u/1428276?v=2","gravatar_id":"fcaa53e946b4d8eb4d26d050588f256d","url":"https://api.github.com/users/IronLady","html_url":"https://github.com/IronLady","followers_url":"https://api.github.com/users/IronLady/followers","following_url":"https://api.github.com/users/IronLady/following{/other_user}","gists_url":"https://api.github.com/users/IronLady/gists{/gist_id}","starred_url":"https://api.github.com/users/IronLady/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IronLady/subscriptions","organizations_url":"https://api.github.com/users/IronLady/orgs","repos_url":"https://api.github.com/users/IronLady/repos","events_url":"https://api.github.com/users/IronLady/events{/privacy}","received_events_url":"https://api.github.com/users/IronLady/received_events","type":"User","site_admin":false},"body":"Using Google rich snippets tools\r\n(http://www.google.com/webmasters/tools/richsnippets) and I found out\r\nthat the microdata format is not completely correct.\r\n\r\nI think the changes I made fixed that issue.\n<a href='#crh-start'></a><a href='#crh-data-%7B%22processed%22%3A%20%5B%22https%3A//github.com/zencart/zc-v1-series/pull/134%23issuecomment-52660891%22%2C%20%22https%3A//github.com/zencart/zc-v1-series/pull/134%23discussion_r16437458%22%2C%20%22https%3A//github.com/zencart/zc-v1-series/pull/134%23discussion_r16437460%22%2C%20%22https%3A//github.com/zencart/zc-v1-series/pull/134%23issuecomment-52863218%22%2C%20%22https%3A//github.com/zencart/zc-v1-series/pull/134%23discussion_r16567162%22%2C%20%22https%3A//github.com/zencart/zc-v1-series/pull/134%23discussion_r16584306%22%2C%20%22https%3A//github.com/zencart/zc-v1-series/pull/134%23discussion_r16596267%22%2C%20%22https%3A//github.com/zencart/zc-v1-series/pull/134%23discussion_r16597828%22%5D%2C%20%22comments%22%3A%20%7B%22General%20Comment%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/zencart/zc-v1-series/pull/134%23issuecomment-52660891%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Sorry%20for%20the%20%5C%22reopened%5C%22.%20Accidentally%20deleted%20my%20branch.%5Cr%5Cn%5Cr%5CnThanks%22%2C%20%22created_at%22%3A%20%222014-08-19T16%3A31%3A26Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/1428276%3Fv%3D2%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/IronLady%22%7D%7D%2C%20%7B%22body%22%3A%20%22The%20improvements%20to%20richsnippet%20markup%20for%20breadcrumbs%20look%20good%2C%20and%20appear%20to%20pass%20the%20tests%20on%20Google%27s%20validator.%5Cr%5Cn%5Cr%5Cn%3A%2B1%3A%20%22%2C%20%22created_at%22%3A%20%222014-08-21T00%3A16%3A50Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/404472%3Fv%3D2%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/drbyte%22%7D%7D%5D%2C%20%22title%22%3A%20%22General%20Comment%22%7D%2C%20%22Pull%20d51c4d706406a825b9f1313bfad3331d89e70a0c%20includes/classes/breadcrumb.php%208%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/zencart/zc-v1-series/pull/134%23discussion_r16437458%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22There%20are%20a%20couple%20concatenation%20breaks%20around%20the%20%60span%60%20which%20are%20unnecessary.%22%2C%20%22created_at%22%3A%20%222014-08-19T19%3A28%3A58Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/1590605%3Fv%3D2%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/texdc%22%7D%7D%2C%20%7B%22body%22%3A%20%22Please%20remove%20the%20unnecessary%20concatenations%20around%20the%20%60itemprop%60%20span.%22%2C%20%22created_at%22%3A%20%222014-08-21T20%3A37%3A31Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/1590605%3Fv%3D2%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/texdc%22%7D%7D%2C%20%7B%22body%22%3A%20%22Thanks%20for%20the%20comment.%20%5Cr%5CnBut%2C%20I%20don%27t%20think%20that%20it%27s%20unnecessary%20%28the%20breaks%29.%20%5Cr%5CnI%20was%20thinking%20that%20I%20need%20to%20put%20one%20more%20break%20inside%20%3Ccode%3Eitemscope%3C/code%3E%20span.%5Cr%5Cn%60%60%60php%5Cr%5Cn%24trail_string%20.%3D%20%27%20%20%3Cspan%20itemscope%20itemtype%3D%5C%22http%3A//data-vocabulary.org/Breadcrumb%5C%22%3E%27%20.%20%27%3Ca%20itemprop%3D%5C%22url%5C%22%20href%3D%5C%22%27%20.%20%24this-%3E_trail%5B%24i%5D%5B%27link%27%5D%20.%20%27%5C%22%3E%27%20.%20%27%3Cspan%20itemprop%3D%5C%22title%5C%22%3E%27%20.%20%24this-%3E_trail%5B%24i%5D%5B%27title%27%5D%20.%20%27%3C/span%3E%27%20.%20%27%3C/a%3E%27%20.%20%27%3C/span%3E%27%3B%5Cr%5Cn%60%60%60%5Cr%5Cn%5Cr%5CnIt%20can%20be%20something%20like%20a%20%5C%22mark%5C%22%20for%20us%20to%20easily%20edit%20it%2C%20IN%20CASE%20there%20are%20any%20schema%20markup%20changes%20in%20the%20future%20%28who%20knows%29.%20%5Cr%5Cn%5Cr%5CnLet%27s%20just%20hear%20core%20developers%20thought%20about%20this.%5Cr%5Cn%22%2C%20%22created_at%22%3A%20%222014-08-22T06%3A29%3A19Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/1428276%3Fv%3D2%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/IronLady%22%7D%7D%2C%20%7B%22body%22%3A%20%22The%20spacing%20and%20concatenation%20is%20fine%20and%20good%20for%20readability%22%2C%20%22created_at%22%3A%20%222014-08-22T13%3A06%3A09Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/1992427%3Fv%3D2%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ajeh%22%7D%7D%2C%20%7B%22body%22%3A%20%22If%20you%20really%20want%20readability%2C%20break%20it%20onto%20multiple%20lines%3A%5Cr%5Cn%60%60%60php%5Cr%5Cn%24trail_string%20.%3D%20%27%20%3Cspan%20itemscope%20itemtype%3D%5C%22http%3A//data-vocabulary.org/Breadcrumb%5C%22%3E%27%5Cr%5Cn%20%20%20%20%20%20%20%20%20%20%20%20%20%20.%20%27%3Ca%20itemprop%3D%5C%22url%5C%22%20href%3D%5C%22%27%20.%20%24this-%3E_trail%5B%24i%5D%5B%27link%27%5D%20.%20%27%5C%22%3E%27%5Cr%5Cn%20%20%20%20%20%20%20%20%20%20%20%20%20%20.%20%27%3Cspan%20itemprop%3D%5C%22title%5C%22%3E%27%20.%20%24this-%3E_trail%5B%24i%5D%5B%27title%27%5D%20.%20%27%3C/span%3E%27%5Cr%5Cn%20%20%20%20%20%20%20%20%20%20%20%20%20%20.%20%27%3C/a%3E%3C/span%3E%27%3B%5Cr%5Cn%60%60%60%22%2C%20%22created_at%22%3A%20%222014-08-22T13%3A39%3A04Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/1590605%3Fv%3D2%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/texdc%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20includes/classes/breadcrumb.php%3AL53-65%22%7D%2C%20%22Pull%20d51c4d706406a825b9f1313bfad3331d89e70a0c%20includes/classes/breadcrumb.php%2022%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/zencart/zc-v1-series/pull/134%23discussion_r16437460%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Please%20restore%20the%20final%20new%20line.%22%2C%20%22created_at%22%3A%20%222014-08-19T19%3A29%3A00Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/1590605%3Fv%3D2%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/texdc%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20includes/classes/breadcrumb.php%3AL72-76%22%7D%7D%7D'></a>\n<a href='https://www.codereviewhub.com/'><img src='http://www.codereviewhub.com/site/github-bar.png' height=40></a>\n- [ ] <a href='#crh-comment-Pull d51c4d706406a825b9f1313bfad3331d89e70a0c includes/classes/breadcrumb.php 8'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/zencart/zc-v1-series/pull/134#discussion_r16437458'>File: includes/classes/breadcrumb.php:L53-65</a></b>\n- <a href='https://github.com/texdc'><img border=0 src='https://avatars.githubusercontent.com/u/1590605?v=2' height=16 width=16'></a> There are a couple concatenation breaks around the `span` which are unnecessary.\n- <a href='https://github.com/texdc'><img border=0 src='https://avatars.githubusercontent.com/u/1590605?v=2' height=16 width=16'></a> Please remove the unnecessary concatenations around the `itemprop` span.\n- <a href='https://github.com/IronLady'><img border=0 src='https://avatars.githubusercontent.com/u/1428276?v=2' height=16 width=16'></a> Thanks for the comment.\nBut, I don't think that it's unnecessary (the breaks).\nI was thinking that I need to put one more break inside <code>itemscope</code> span.\n```php\n$trail_string .= '  <span itemscope itemtype=\"http://data-vocabulary.org/Breadcrumb\">' . '<a itemprop=\"url\" href=\"' . $this->_trail[$i]['link'] . '\">' . '<span itemprop=\"title\">' . $this->_trail[$i]['title'] . '</span>' . '</a>' . '</span>';\n```\nIt can be something like a \"mark\" for us to easily edit it, IN CASE there are any schema markup changes in the future (who knows).\nLet's just hear core developers thought about this.\n- <a href='https://github.com/ajeh'><img border=0 src='https://avatars.githubusercontent.com/u/1992427?v=2' height=16 width=16'></a> The spacing and concatenation is fine and good for readability\n- <a href='https://github.com/texdc'><img border=0 src='https://avatars.githubusercontent.com/u/1590605?v=2' height=16 width=16'></a> If you really want readability, break it onto multiple lines:\n```php\n$trail_string .= ' <span itemscope itemtype=\"http://data-vocabulary.org/Breadcrumb\">'\n. '<a itemprop=\"url\" href=\"' . $this->_trail[$i]['link'] . '\">'\n. '<span itemprop=\"title\">' . $this->_trail[$i]['title'] . '</span>'\n. '</a></span>';\n```\n- [x] <a href='#crh-comment-Pull d51c4d706406a825b9f1313bfad3331d89e70a0c includes/classes/breadcrumb.php 22'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/zencart/zc-v1-series/pull/134#discussion_r16437460'>File: includes/classes/breadcrumb.php:L72-76</a></b>\n- <a href='https://github.com/texdc'><img border=0 src='https://avatars.githubusercontent.com/u/1590605?v=2' height=16 width=16'></a> Please restore the final new line.\n- [x] <a href='#crh-comment-General Comment'></a> <img src='http://www.codereviewhub.com/site/github-completed.png' height=16 width=60>&nbsp;<b><a href='https://github.com/zencart/zc-v1-series/pull/134#issuecomment-52660891'>General Comment</a></b>\n- <a href='https://github.com/IronLady'><img border=0 src='https://avatars.githubusercontent.com/u/1428276?v=2' height=16 width=16'></a> Sorry for the \"reopened\". Accidentally deleted my branch.\nThanks\n- <a href='https://github.com/drbyte'><img border=0 src='https://avatars.githubusercontent.com/u/404472?v=2' height=16 width=16'></a> The improvements to richsnippet markup for breadcrumbs look good, and appear to pass the tests on Google's validator.\n:+1:\n\n\n<a href='https://www.codereviewhub.com/zencart/zc-v1-series/pull/134?mark_as_completed=1'><img src='http://www.codereviewhub.com/site/github-mark-as-completed.png' height=26></a>&nbsp;<a href='https://www.codereviewhub.com/zencart/zc-v1-series/pull/134?approve=1'><img src='http://www.codereviewhub.com/site/github-approve.png' height=26></a>&nbsp;<a href='https://github.com/zencart/zc-v1-series/pull/134'><img src='http://www.codereviewhub.com/site/github-refresh.png' height=26></a>\n<a href='#crh-end'></a>","created_at":"2014-08-19T16:18:38Z","updated_at":"2014-08-26T02:39:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4492ab43f66469745121f0113a00c80d0fb90bc1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/zencart/zc-v1-series/pulls/134/commits","review_comments_url":"https://api.github.com/repos/zencart/zc-v1-series/pulls/134/comments","review_comment_url":"https://api.github.com/repos/zencart/zc-v1-series/pulls/comments/{number}","comments_url":"https://api.github.com/repos/zencart/zc-v1-series/issues/134/comments","statuses_url":"https://api.github.com/repos/zencart/zc-v1-series/statuses/cdf284c11426cdb86ff7a47e0ed54f16f92b6f58","head":{"label":"IronLady:upstream","ref":"upstream","sha":"cdf284c11426cdb86ff7a47e0ed54f16f92b6f58","user":{"login":"IronLady","id":1428276,"avatar_url":"https://avatars.githubusercontent.com/u/1428276?v=2","gravatar_id":"fcaa53e946b4d8eb4d26d050588f256d","url":"https://api.github.com/users/IronLady","html_url":"https://github.com/IronLady","followers_url":"https://api.github.com/users/IronLady/followers","following_url":"https://api.github.com/users/IronLady/following{/other_user}","gists_url":"https://api.github.com/users/IronLady/gists{/gist_id}","starred_url":"https://api.github.com/users/IronLady/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IronLady/subscriptions","organizations_url":"https://api.github.com/users/IronLady/orgs","repos_url":"https://api.github.com/users/IronLady/repos","events_url":"https://api.github.com/users/IronLady/events{/privacy}","received_events_url":"https://api.github.com/users/IronLady/received_events","type":"User","site_admin":false},"repo":{"id":22580343,"name":"zc-v1-series","full_name":"IronLady/zc-v1-series","owner":{"login":"IronLady","id":1428276,"avatar_url":"https://avatars.githubusercontent.com/u/1428276?v=2","gravatar_id":"fcaa53e946b4d8eb4d26d050588f256d","url":"https://api.github.com/users/IronLady","html_url":"https://github.com/IronLady","followers_url":"https://api.github.com/users/IronLady/followers","following_url":"https://api.github.com/users/IronLady/following{/other_user}","gists_url":"https://api.github.com/users/IronLady/gists{/gist_id}","starred_url":"https://api.github.com/users/IronLady/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IronLady/subscriptions","organizations_url":"https://api.github.com/users/IronLady/orgs","repos_url":"https://api.github.com/users/IronLady/repos","events_url":"https://api.github.com/users/IronLady/events{/privacy}","received_events_url":"https://api.github.com/users/IronLady/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/IronLady/zc-v1-series","description":"Zen Cart® is a full-function e-commerce application for your website.  NOTE: For \"stable\" releases, see the tagged releases section in GitHub.","fork":true,"url":"https://api.github.com/repos/IronLady/zc-v1-series","forks_url":"https://api.github.com/repos/IronLady/zc-v1-series/forks","keys_url":"https://api.github.com/repos/IronLady/zc-v1-series/keys{/key_id}","collaborators_url":"https://api.github.com/repos/IronLady/zc-v1-series/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/IronLady/zc-v1-series/teams","hooks_url":"https://api.github.com/repos/IronLady/zc-v1-series/hooks","issue_events_url":"https://api.github.com/repos/IronLady/zc-v1-series/issues/events{/number}","events_url":"https://api.github.com/repos/IronLady/zc-v1-series/events","assignees_url":"https://api.github.com/repos/IronLady/zc-v1-series/assignees{/user}","branches_url":"https://api.github.com/repos/IronLady/zc-v1-series/branches{/branch}","tags_url":"https://api.github.com/repos/IronLady/zc-v1-series/tags","blobs_url":"https://api.github.com/repos/IronLady/zc-v1-series/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/IronLady/zc-v1-series/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/IronLady/zc-v1-series/git/refs{/sha}","trees_url":"https://api.github.com/repos/IronLady/zc-v1-series/git/trees{/sha}","statuses_url":"https://api.github.com/repos/IronLady/zc-v1-series/statuses/{sha}","languages_url":"https://api.github.com/repos/IronLady/zc-v1-series/languages","stargazers_url":"https://api.github.com/repos/IronLady/zc-v1-series/stargazers","contributors_url":"https://api.github.com/repos/IronLady/zc-v1-series/contributors","subscribers_url":"https://api.github.com/repos/IronLady/zc-v1-series/subscribers","subscription_url":"https://api.github.com/repos/IronLady/zc-v1-series/subscription","commits_url":"https://api.github.com/repos/IronLady/zc-v1-series/commits{/sha}","git_commits_url":"https://api.github.com/repos/IronLady/zc-v1-series/git/commits{/sha}","comments_url":"https://api.github.com/repos/IronLady/zc-v1-series/comments{/number}","issue_comment_url":"https://api.github.com/repos/IronLady/zc-v1-series/issues/comments/{number}","contents_url":"https://api.github.com/repos/IronLady/zc-v1-series/contents/{+path}","compare_url":"https://api.github.com/repos/IronLady/zc-v1-series/compare/{base}...{head}","merges_url":"https://api.github.com/repos/IronLady/zc-v1-series/merges","archive_url":"https://api.github.com/repos/IronLady/zc-v1-series/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/IronLady/zc-v1-series/downloads","issues_url":"https://api.github.com/repos/IronLady/zc-v1-series/issues{/number}","pulls_url":"https://api.github.com/repos/IronLady/zc-v1-series/pulls{/number}","milestones_url":"https://api.github.com/repos/IronLady/zc-v1-series/milestones{/number}","notifications_url":"https://api.github.com/repos/IronLady/zc-v1-series/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/IronLady/zc-v1-series/labels{/name}","releases_url":"https://api.github.com/repos/IronLady/zc-v1-series/releases{/id}","created_at":"2014-08-03T17:59:12Z","updated_at":"2014-08-03T18:21:32Z","pushed_at":"2014-08-22T18:34:40Z","git_url":"git://github.com/IronLady/zc-v1-series.git","ssh_url":"git@github.com:IronLady/zc-v1-series.git","clone_url":"https://github.com/IronLady/zc-v1-series.git","svn_url":"https://github.com/IronLady/zc-v1-series","homepage":"","size":12962,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"v160"}},"base":{"label":"zencart:v160","ref":"v160","sha":"09f3c8b3bb6721424cdb420d34c6ddc450fa4d77","user":{"login":"zencart","id":20768,"avatar_url":"https://avatars.githubusercontent.com/u/20768?v=2","gravatar_id":"91a624fb0856dd75912a44ff5f7a8810","url":"https://api.github.com/users/zencart","html_url":"https://github.com/zencart","followers_url":"https://api.github.com/users/zencart/followers","following_url":"https://api.github.com/users/zencart/following{/other_user}","gists_url":"https://api.github.com/users/zencart/gists{/gist_id}","starred_url":"https://api.github.com/users/zencart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zencart/subscriptions","organizations_url":"https://api.github.com/users/zencart/orgs","repos_url":"https://api.github.com/users/zencart/repos","events_url":"https://api.github.com/users/zencart/events{/privacy}","received_events_url":"https://api.github.com/users/zencart/received_events","type":"Organization","site_admin":false},"repo":{"id":4883113,"name":"zc-v1-series","full_name":"zencart/zc-v1-series","owner":{"login":"zencart","id":20768,"avatar_url":"https://avatars.githubusercontent.com/u/20768?v=2","gravatar_id":"91a624fb0856dd75912a44ff5f7a8810","url":"https://api.github.com/users/zencart","html_url":"https://github.com/zencart","followers_url":"https://api.github.com/users/zencart/followers","following_url":"https://api.github.com/users/zencart/following{/other_user}","gists_url":"https://api.github.com/users/zencart/gists{/gist_id}","starred_url":"https://api.github.com/users/zencart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zencart/subscriptions","organizations_url":"https://api.github.com/users/zencart/orgs","repos_url":"https://api.github.com/users/zencart/repos","events_url":"https://api.github.com/users/zencart/events{/privacy}","received_events_url":"https://api.github.com/users/zencart/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zencart/zc-v1-series","description":"Zen Cart® is a full-function e-commerce application for your website.  NOTE: For \"stable\" releases, see the tagged releases section in GitHub.","fork":false,"url":"https://api.github.com/repos/zencart/zc-v1-series","forks_url":"https://api.github.com/repos/zencart/zc-v1-series/forks","keys_url":"https://api.github.com/repos/zencart/zc-v1-series/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zencart/zc-v1-series/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zencart/zc-v1-series/teams","hooks_url":"https://api.github.com/repos/zencart/zc-v1-series/hooks","issue_events_url":"https://api.github.com/repos/zencart/zc-v1-series/issues/events{/number}","events_url":"https://api.github.com/repos/zencart/zc-v1-series/events","assignees_url":"https://api.github.com/repos/zencart/zc-v1-series/assignees{/user}","branches_url":"https://api.github.com/repos/zencart/zc-v1-series/branches{/branch}","tags_url":"https://api.github.com/repos/zencart/zc-v1-series/tags","blobs_url":"https://api.github.com/repos/zencart/zc-v1-series/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zencart/zc-v1-series/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zencart/zc-v1-series/git/refs{/sha}","trees_url":"https://api.github.com/repos/zencart/zc-v1-series/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zencart/zc-v1-series/statuses/{sha}","languages_url":"https://api.github.com/repos/zencart/zc-v1-series/languages","stargazers_url":"https://api.github.com/repos/zencart/zc-v1-series/stargazers","contributors_url":"https://api.github.com/repos/zencart/zc-v1-series/contributors","subscribers_url":"https://api.github.com/repos/zencart/zc-v1-series/subscribers","subscription_url":"https://api.github.com/repos/zencart/zc-v1-series/subscription","commits_url":"https://api.github.com/repos/zencart/zc-v1-series/commits{/sha}","git_commits_url":"https://api.github.com/repos/zencart/zc-v1-series/git/commits{/sha}","comments_url":"https://api.github.com/repos/zencart/zc-v1-series/comments{/number}","issue_comment_url":"https://api.github.com/repos/zencart/zc-v1-series/issues/comments/{number}","contents_url":"https://api.github.com/repos/zencart/zc-v1-series/contents/{+path}","compare_url":"https://api.github.com/repos/zencart/zc-v1-series/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zencart/zc-v1-series/merges","archive_url":"https://api.github.com/repos/zencart/zc-v1-series/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zencart/zc-v1-series/downloads","issues_url":"https://api.github.com/repos/zencart/zc-v1-series/issues{/number}","pulls_url":"https://api.github.com/repos/zencart/zc-v1-series/pulls{/number}","milestones_url":"https://api.github.com/repos/zencart/zc-v1-series/milestones{/number}","notifications_url":"https://api.github.com/repos/zencart/zc-v1-series/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zencart/zc-v1-series/labels{/name}","releases_url":"https://api.github.com/repos/zencart/zc-v1-series/releases{/id}","created_at":"2012-07-04T10:02:56Z","updated_at":"2014-08-23T15:42:18Z","pushed_at":"2014-08-20T17:20:30Z","git_url":"git://github.com/zencart/zc-v1-series.git","ssh_url":"git@github.com:zencart/zc-v1-series.git","clone_url":"https://github.com/zencart/zc-v1-series.git","svn_url":"https://github.com/zencart/zc-v1-series","homepage":"","size":16900,"stargazers_count":38,"watchers_count":38,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":45,"mirror_url":null,"open_issues_count":24,"forks":45,"open_issues":24,"watchers":38,"default_branch":"v160"}},"_links":{"self":{"href":"https://api.github.com/repos/zencart/zc-v1-series/pulls/134"},"html":{"href":"https://github.com/zencart/zc-v1-series/pull/134"},"issue":{"href":"https://api.github.com/repos/zencart/zc-v1-series/issues/134"},"comments":{"href":"https://api.github.com/repos/zencart/zc-v1-series/issues/134/comments"},"review_comments":{"href":"https://api.github.com/repos/zencart/zc-v1-series/pulls/134/comments"},"review_comment":{"href":"https://api.github.com/repos/zencart/zc-v1-series/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/zencart/zc-v1-series/pulls/134/commits"},"statuses":{"href":"https://api.github.com/repos/zencart/zc-v1-series/statuses/cdf284c11426cdb86ff7a47e0ed54f16f92b6f58"}}}}