GitHub PullRequestReviewCommentEvent at 2014-08-26 06:22:50
Repository: gaia
Actor: steveck-chung
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/16697529","id":16697529,"diff_hunk":"@@ -1493,8 +1493,8 @@ var ThreadUI = {\n     return this.tmpl.notDownloaded.interpolate({\n       messageL10nId: messageL10nId,\n       messageL10nArgs: JSON.stringify({ date: expireFormatted }),\n-      messageL10nDate: +message.expiryDate,\n-      messageL10nDateFormat: 'dateTimeFormat_%x',\n+      messageL10nDate: message.expiryDate.toString(),","path":"apps/sms/js/thread_ui.js","position":6,"original_position":6,"commit_id":"c428b5a0d5f7f21a7a16b25ec4cea55ac20a4d85","original_commit_id":"4f957c36098cfe1fea045fd2c3dee30d2cd40b16","user":{"login":"steveck-chung","id":1704452,"avatar_url":"https://avatars.githubusercontent.com/u/1704452?v=2","gravatar_id":"0e719389c6f6e17e5693819fc9a5722a","url":"https://api.github.com/users/steveck-chung","html_url":"https://github.com/steveck-chung","followers_url":"https://api.github.com/users/steveck-chung/followers","following_url":"https://api.github.com/users/steveck-chung/following{/other_user}","gists_url":"https://api.github.com/users/steveck-chung/gists{/gist_id}","starred_url":"https://api.github.com/users/steveck-chung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steveck-chung/subscriptions","organizations_url":"https://api.github.com/users/steveck-chung/orgs","repos_url":"https://api.github.com/users/steveck-chung/repos","events_url":"https://api.github.com/users/steveck-chung/events{/privacy}","received_events_url":"https://api.github.com/users/steveck-chung/received_events","type":"User","site_admin":false},"body":"The date related properties of message was date object before, after 1.4(not quite sure) the properties was changed to pure number. For the backward compatibility we need to force the date into number for the most cases.  The old patch 4c1b014 is one of the changes and this looks like another careless error while I modified all the date related into number ... ","created_at":"2014-08-26T06:22:50Z","updated_at":"2014-08-26T06:22:50Z","html_url":"https://github.com/mozilla-b2g/gaia/pull/23208#discussion_r16697529","pull_request_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/23208","_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/16697529"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/23208#discussion_r16697529"},"pull_request":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/23208"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/23208","id":20173382,"html_url":"https://github.com/mozilla-b2g/gaia/pull/23208","diff_url":"https://github.com/mozilla-b2g/gaia/pull/23208.diff","patch_url":"https://github.com/mozilla-b2g/gaia/pull/23208.patch","issue_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/23208","number":23208,"state":"open","locked":false,"title":"Bug 1035762 - [B2G][SMS] support 24 hour time format. r=schung","user":{"login":"azasypkin","id":1713708,"avatar_url":"https://avatars.githubusercontent.com/u/1713708?v=2","gravatar_id":"18037d0ecb14ff43606946097eedb8b5","url":"https://api.github.com/users/azasypkin","html_url":"https://github.com/azasypkin","followers_url":"https://api.github.com/users/azasypkin/followers","following_url":"https://api.github.com/users/azasypkin/following{/other_user}","gists_url":"https://api.github.com/users/azasypkin/gists{/gist_id}","starred_url":"https://api.github.com/users/azasypkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azasypkin/subscriptions","organizations_url":"https://api.github.com/users/azasypkin/orgs","repos_url":"https://api.github.com/users/azasypkin/repos","events_url":"https://api.github.com/users/azasypkin/events{/privacy}","received_events_url":"https://api.github.com/users/azasypkin/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-08-22T14:05:24Z","updated_at":"2014-08-26T06:22:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dcb586c46d71d76becfde721cc86460ae9fb6ef3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/23208/commits","review_comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/23208/comments","review_comment_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/23208/comments","statuses_url":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/c428b5a0d5f7f21a7a16b25ec4cea55ac20a4d85","head":{"label":"azasypkin:bug-1035762-24h-format","ref":"bug-1035762-24h-format","sha":"c428b5a0d5f7f21a7a16b25ec4cea55ac20a4d85","user":{"login":"azasypkin","id":1713708,"avatar_url":"https://avatars.githubusercontent.com/u/1713708?v=2","gravatar_id":"18037d0ecb14ff43606946097eedb8b5","url":"https://api.github.com/users/azasypkin","html_url":"https://github.com/azasypkin","followers_url":"https://api.github.com/users/azasypkin/followers","following_url":"https://api.github.com/users/azasypkin/following{/other_user}","gists_url":"https://api.github.com/users/azasypkin/gists{/gist_id}","starred_url":"https://api.github.com/users/azasypkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azasypkin/subscriptions","organizations_url":"https://api.github.com/users/azasypkin/orgs","repos_url":"https://api.github.com/users/azasypkin/repos","events_url":"https://api.github.com/users/azasypkin/events{/privacy}","received_events_url":"https://api.github.com/users/azasypkin/received_events","type":"User","site_admin":false},"repo":{"id":17702910,"name":"gaia","full_name":"azasypkin/gaia","owner":{"login":"azasypkin","id":1713708,"avatar_url":"https://avatars.githubusercontent.com/u/1713708?v=2","gravatar_id":"18037d0ecb14ff43606946097eedb8b5","url":"https://api.github.com/users/azasypkin","html_url":"https://github.com/azasypkin","followers_url":"https://api.github.com/users/azasypkin/followers","following_url":"https://api.github.com/users/azasypkin/following{/other_user}","gists_url":"https://api.github.com/users/azasypkin/gists{/gist_id}","starred_url":"https://api.github.com/users/azasypkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azasypkin/subscriptions","organizations_url":"https://api.github.com/users/azasypkin/orgs","repos_url":"https://api.github.com/users/azasypkin/repos","events_url":"https://api.github.com/users/azasypkin/events{/privacy}","received_events_url":"https://api.github.com/users/azasypkin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/azasypkin/gaia","description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see https://wiki.mozilla.org/Release_Management/B2G_Landing","fork":true,"url":"https://api.github.com/repos/azasypkin/gaia","forks_url":"https://api.github.com/repos/azasypkin/gaia/forks","keys_url":"https://api.github.com/repos/azasypkin/gaia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/azasypkin/gaia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/azasypkin/gaia/teams","hooks_url":"https://api.github.com/repos/azasypkin/gaia/hooks","issue_events_url":"https://api.github.com/repos/azasypkin/gaia/issues/events{/number}","events_url":"https://api.github.com/repos/azasypkin/gaia/events","assignees_url":"https://api.github.com/repos/azasypkin/gaia/assignees{/user}","branches_url":"https://api.github.com/repos/azasypkin/gaia/branches{/branch}","tags_url":"https://api.github.com/repos/azasypkin/gaia/tags","blobs_url":"https://api.github.com/repos/azasypkin/gaia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/azasypkin/gaia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/azasypkin/gaia/git/refs{/sha}","trees_url":"https://api.github.com/repos/azasypkin/gaia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/azasypkin/gaia/statuses/{sha}","languages_url":"https://api.github.com/repos/azasypkin/gaia/languages","stargazers_url":"https://api.github.com/repos/azasypkin/gaia/stargazers","contributors_url":"https://api.github.com/repos/azasypkin/gaia/contributors","subscribers_url":"https://api.github.com/repos/azasypkin/gaia/subscribers","subscription_url":"https://api.github.com/repos/azasypkin/gaia/subscription","commits_url":"https://api.github.com/repos/azasypkin/gaia/commits{/sha}","git_commits_url":"https://api.github.com/repos/azasypkin/gaia/git/commits{/sha}","comments_url":"https://api.github.com/repos/azasypkin/gaia/comments{/number}","issue_comment_url":"https://api.github.com/repos/azasypkin/gaia/issues/comments/{number}","contents_url":"https://api.github.com/repos/azasypkin/gaia/contents/{+path}","compare_url":"https://api.github.com/repos/azasypkin/gaia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/azasypkin/gaia/merges","archive_url":"https://api.github.com/repos/azasypkin/gaia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/azasypkin/gaia/downloads","issues_url":"https://api.github.com/repos/azasypkin/gaia/issues{/number}","pulls_url":"https://api.github.com/repos/azasypkin/gaia/pulls{/number}","milestones_url":"https://api.github.com/repos/azasypkin/gaia/milestones{/number}","notifications_url":"https://api.github.com/repos/azasypkin/gaia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/azasypkin/gaia/labels{/name}","releases_url":"https://api.github.com/repos/azasypkin/gaia/releases{/id}","created_at":"2014-03-13T08:22:23Z","updated_at":"2014-06-28T10:03:34Z","pushed_at":"2014-08-25T15:11:42Z","git_url":"git://github.com/azasypkin/gaia.git","ssh_url":"git@github.com:azasypkin/gaia.git","clone_url":"https://github.com/azasypkin/gaia.git","svn_url":"https://github.com/azasypkin/gaia","homepage":"https://wiki.mozilla.org/B2G","size":823077,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla-b2g:master","ref":"master","sha":"a628bd3b5f863a0266df19ab0d1f0b93f1a19355","user":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=2","gravatar_id":"b1de11f7d6ddaf7b9d527281297c2ee1","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"repo":{"id":2317369,"name":"gaia","full_name":"mozilla-b2g/gaia","owner":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=2","gravatar_id":"b1de11f7d6ddaf7b9d527281297c2ee1","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-b2g/gaia","description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see","fork":false,"url":"https://api.github.com/repos/mozilla-b2g/gaia","forks_url":"https://api.github.com/repos/mozilla-b2g/gaia/forks","keys_url":"https://api.github.com/repos/mozilla-b2g/gaia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-b2g/gaia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-b2g/gaia/teams","hooks_url":"https://api.github.com/repos/mozilla-b2g/gaia/hooks","issue_events_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-b2g/gaia/events","assignees_url":"https://api.github.com/repos/mozilla-b2g/gaia/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-b2g/gaia/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-b2g/gaia/tags","blobs_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-b2g/gaia/languages","stargazers_url":"https://api.github.com/repos/mozilla-b2g/gaia/stargazers","contributors_url":"https://api.github.com/repos/mozilla-b2g/gaia/contributors","subscribers_url":"https://api.github.com/repos/mozilla-b2g/gaia/subscribers","subscription_url":"https://api.github.com/repos/mozilla-b2g/gaia/subscription","commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/comments/{number}","contents_url":"https://api.github.com/repos/mozilla-b2g/gaia/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-b2g/gaia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-b2g/gaia/merges","archive_url":"https://api.github.com/repos/mozilla-b2g/gaia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-b2g/gaia/downloads","issues_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-b2g/gaia/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-b2g/gaia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-b2g/gaia/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-b2g/gaia/releases{/id}","created_at":"2011-09-03T01:38:46Z","updated_at":"2014-08-25T20:32:34Z","pushed_at":"2014-08-26T06:02:08Z","git_url":"git://github.com/mozilla-b2g/gaia.git","ssh_url":"git@github.com:mozilla-b2g/gaia.git","clone_url":"https://github.com/mozilla-b2g/gaia.git","svn_url":"https://github.com/mozilla-b2g/gaia","homepage":"https://wiki.mozilla.org/B2G","size":1388907,"stargazers_count":1711,"watchers_count":1711,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":1851,"mirror_url":null,"open_issues_count":1987,"forks":1851,"open_issues":1987,"watchers":1711,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/23208"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/23208"},"issue":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/issues/23208"},"comments":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/issues/23208/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/23208/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/23208/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/c428b5a0d5f7f21a7a16b25ec4cea55ac20a4d85"}}}}