GitHub PullRequestReviewCommentEvent at 2014-11-17 19:17:02
Repository: osquery
Actor: marpaia
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/facebook/osquery/pulls/comments/20457232","id":20457232,"diff_hunk":"@@ -0,0 +1,43 @@\n+// Copyright 2014-present Mike Goffin. All Rights Reserved.\n+\n+#include <stdio.h>\n+#include <sys/mount.h>\n+\n+#include <boost/lexical_cast.hpp>\n+\n+#include \"osquery/database.h\"\n+\n+namespace osquery {\n+namespace tables {\n+\n+QueryData genMounts() {\n+  Row r;\n+  QueryData results;\n+\n+  struct statfs *mnt;\n+  int mnts = 0;\n+  int i;\n+\n+  mnts = getmntinfo(&mnt, MNT_WAIT);\n+  if(mnts == 0)\n+  {","path":"osquery/tables/system/darwin/mounts.cpp","position":23,"original_position":23,"commit_id":"0b4e382e968b607f0df980d283471eae1e02237a","original_commit_id":"0b4e382e968b607f0df980d283471eae1e02237a","user":{"login":"marpaia","id":927168,"avatar_url":"https://avatars.githubusercontent.com/u/927168?v=3","gravatar_id":"","url":"https://api.github.com/users/marpaia","html_url":"https://github.com/marpaia","followers_url":"https://api.github.com/users/marpaia/followers","following_url":"https://api.github.com/users/marpaia/following{/other_user}","gists_url":"https://api.github.com/users/marpaia/gists{/gist_id}","starred_url":"https://api.github.com/users/marpaia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marpaia/subscriptions","organizations_url":"https://api.github.com/users/marpaia/orgs","repos_url":"https://api.github.com/users/marpaia/repos","events_url":"https://api.github.com/users/marpaia/events{/privacy}","received_events_url":"https://api.github.com/users/marpaia/received_events","type":"User","site_admin":false},"body":"Can you run clang-format on this?","created_at":"2014-11-17T19:17:02Z","updated_at":"2014-11-17T19:17:02Z","html_url":"https://github.com/facebook/osquery/pull/440#discussion_r20457232","pull_request_url":"https://api.github.com/repos/facebook/osquery/pulls/440","_links":{"self":{"href":"https://api.github.com/repos/facebook/osquery/pulls/comments/20457232"},"html":{"href":"https://github.com/facebook/osquery/pull/440#discussion_r20457232"},"pull_request":{"href":"https://api.github.com/repos/facebook/osquery/pulls/440"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/osquery/pulls/440","id":24558079,"html_url":"https://github.com/facebook/osquery/pull/440","diff_url":"https://github.com/facebook/osquery/pull/440.diff","patch_url":"https://github.com/facebook/osquery/pull/440.patch","issue_url":"https://api.github.com/repos/facebook/osquery/issues/440","number":440,"state":"open","locked":false,"title":"Mounts table for OSX","user":{"login":"mgoffin","id":260873,"avatar_url":"https://avatars.githubusercontent.com/u/260873?v=3","gravatar_id":"","url":"https://api.github.com/users/mgoffin","html_url":"https://github.com/mgoffin","followers_url":"https://api.github.com/users/mgoffin/followers","following_url":"https://api.github.com/users/mgoffin/following{/other_user}","gists_url":"https://api.github.com/users/mgoffin/gists{/gist_id}","starred_url":"https://api.github.com/users/mgoffin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgoffin/subscriptions","organizations_url":"https://api.github.com/users/mgoffin/orgs","repos_url":"https://api.github.com/users/mgoffin/repos","events_url":"https://api.github.com/users/mgoffin/events{/privacy}","received_events_url":"https://api.github.com/users/mgoffin/received_events","type":"User","site_admin":false},"body":"Associated with #255, this adds Mounts table support for Darwin.\r\n\r\nThe information is gathered using `getmntinfo()`. Currently it has somewhat different info compared to what the Mounts table for linux should be showing. This is partially due to the fact that the linux table uses a different method for gathering the data, the linux table segfaults for me, and I haven't reconciled the content in `statfs` between linux and OSX to see what the differences are in available data.","created_at":"2014-11-17T18:59:04Z","updated_at":"2014-11-17T19:17:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1bef05c5c5d4502ca0aba96afcb4f0f56926da6b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/facebook/osquery/pulls/440/commits","review_comments_url":"https://api.github.com/repos/facebook/osquery/pulls/440/comments","review_comment_url":"https://api.github.com/repos/facebook/osquery/pulls/comments/{number}","comments_url":"https://api.github.com/repos/facebook/osquery/issues/440/comments","statuses_url":"https://api.github.com/repos/facebook/osquery/statuses/0b4e382e968b607f0df980d283471eae1e02237a","head":{"label":"mgoffin:mounts_table","ref":"mounts_table","sha":"0b4e382e968b607f0df980d283471eae1e02237a","user":{"login":"mgoffin","id":260873,"avatar_url":"https://avatars.githubusercontent.com/u/260873?v=3","gravatar_id":"","url":"https://api.github.com/users/mgoffin","html_url":"https://github.com/mgoffin","followers_url":"https://api.github.com/users/mgoffin/followers","following_url":"https://api.github.com/users/mgoffin/following{/other_user}","gists_url":"https://api.github.com/users/mgoffin/gists{/gist_id}","starred_url":"https://api.github.com/users/mgoffin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgoffin/subscriptions","organizations_url":"https://api.github.com/users/mgoffin/orgs","repos_url":"https://api.github.com/users/mgoffin/repos","events_url":"https://api.github.com/users/mgoffin/events{/privacy}","received_events_url":"https://api.github.com/users/mgoffin/received_events","type":"User","site_admin":false},"repo":{"id":26622031,"name":"osquery","full_name":"mgoffin/osquery","owner":{"login":"mgoffin","id":260873,"avatar_url":"https://avatars.githubusercontent.com/u/260873?v=3","gravatar_id":"","url":"https://api.github.com/users/mgoffin","html_url":"https://github.com/mgoffin","followers_url":"https://api.github.com/users/mgoffin/followers","following_url":"https://api.github.com/users/mgoffin/following{/other_user}","gists_url":"https://api.github.com/users/mgoffin/gists{/gist_id}","starred_url":"https://api.github.com/users/mgoffin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgoffin/subscriptions","organizations_url":"https://api.github.com/users/mgoffin/orgs","repos_url":"https://api.github.com/users/mgoffin/repos","events_url":"https://api.github.com/users/mgoffin/events{/privacy}","received_events_url":"https://api.github.com/users/mgoffin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mgoffin/osquery","description":"SQL powered operating system instrumentation and monitoring.","fork":true,"url":"https://api.github.com/repos/mgoffin/osquery","forks_url":"https://api.github.com/repos/mgoffin/osquery/forks","keys_url":"https://api.github.com/repos/mgoffin/osquery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mgoffin/osquery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mgoffin/osquery/teams","hooks_url":"https://api.github.com/repos/mgoffin/osquery/hooks","issue_events_url":"https://api.github.com/repos/mgoffin/osquery/issues/events{/number}","events_url":"https://api.github.com/repos/mgoffin/osquery/events","assignees_url":"https://api.github.com/repos/mgoffin/osquery/assignees{/user}","branches_url":"https://api.github.com/repos/mgoffin/osquery/branches{/branch}","tags_url":"https://api.github.com/repos/mgoffin/osquery/tags","blobs_url":"https://api.github.com/repos/mgoffin/osquery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mgoffin/osquery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mgoffin/osquery/git/refs{/sha}","trees_url":"https://api.github.com/repos/mgoffin/osquery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mgoffin/osquery/statuses/{sha}","languages_url":"https://api.github.com/repos/mgoffin/osquery/languages","stargazers_url":"https://api.github.com/repos/mgoffin/osquery/stargazers","contributors_url":"https://api.github.com/repos/mgoffin/osquery/contributors","subscribers_url":"https://api.github.com/repos/mgoffin/osquery/subscribers","subscription_url":"https://api.github.com/repos/mgoffin/osquery/subscription","commits_url":"https://api.github.com/repos/mgoffin/osquery/commits{/sha}","git_commits_url":"https://api.github.com/repos/mgoffin/osquery/git/commits{/sha}","comments_url":"https://api.github.com/repos/mgoffin/osquery/comments{/number}","issue_comment_url":"https://api.github.com/repos/mgoffin/osquery/issues/comments/{number}","contents_url":"https://api.github.com/repos/mgoffin/osquery/contents/{+path}","compare_url":"https://api.github.com/repos/mgoffin/osquery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mgoffin/osquery/merges","archive_url":"https://api.github.com/repos/mgoffin/osquery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mgoffin/osquery/downloads","issues_url":"https://api.github.com/repos/mgoffin/osquery/issues{/number}","pulls_url":"https://api.github.com/repos/mgoffin/osquery/pulls{/number}","milestones_url":"https://api.github.com/repos/mgoffin/osquery/milestones{/number}","notifications_url":"https://api.github.com/repos/mgoffin/osquery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mgoffin/osquery/labels{/name}","releases_url":"https://api.github.com/repos/mgoffin/osquery/releases{/id}","created_at":"2014-11-14T04:18:46Z","updated_at":"2014-11-14T04:18:48Z","pushed_at":"2014-11-17T18:53:52Z","git_url":"git://github.com/mgoffin/osquery.git","ssh_url":"git@github.com:mgoffin/osquery.git","clone_url":"https://github.com/mgoffin/osquery.git","svn_url":"https://github.com/mgoffin/osquery","homepage":"http://osquery.io","size":3689,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"093c857aea2d5bf6943fbea2e3ca7cdbb8678659","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":22394357,"name":"osquery","full_name":"facebook/osquery","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/osquery","description":"SQL powered operating system instrumentation and monitoring.","fork":false,"url":"https://api.github.com/repos/facebook/osquery","forks_url":"https://api.github.com/repos/facebook/osquery/forks","keys_url":"https://api.github.com/repos/facebook/osquery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/osquery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/osquery/teams","hooks_url":"https://api.github.com/repos/facebook/osquery/hooks","issue_events_url":"https://api.github.com/repos/facebook/osquery/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/osquery/events","assignees_url":"https://api.github.com/repos/facebook/osquery/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/osquery/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/osquery/tags","blobs_url":"https://api.github.com/repos/facebook/osquery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/osquery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/osquery/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/osquery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/osquery/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/osquery/languages","stargazers_url":"https://api.github.com/repos/facebook/osquery/stargazers","contributors_url":"https://api.github.com/repos/facebook/osquery/contributors","subscribers_url":"https://api.github.com/repos/facebook/osquery/subscribers","subscription_url":"https://api.github.com/repos/facebook/osquery/subscription","commits_url":"https://api.github.com/repos/facebook/osquery/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/osquery/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/osquery/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/osquery/issues/comments/{number}","contents_url":"https://api.github.com/repos/facebook/osquery/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/osquery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/osquery/merges","archive_url":"https://api.github.com/repos/facebook/osquery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/osquery/downloads","issues_url":"https://api.github.com/repos/facebook/osquery/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/osquery/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/osquery/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/osquery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/osquery/labels{/name}","releases_url":"https://api.github.com/repos/facebook/osquery/releases{/id}","created_at":"2014-07-29T20:27:33Z","updated_at":"2014-11-17T18:53:21Z","pushed_at":"2014-11-17T06:51:11Z","git_url":"git://github.com/facebook/osquery.git","ssh_url":"git@github.com:facebook/osquery.git","clone_url":"https://github.com/facebook/osquery.git","svn_url":"https://github.com/facebook/osquery","homepage":"http://osquery.io","size":15533,"stargazers_count":3166,"watchers_count":3166,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":196,"mirror_url":null,"open_issues_count":62,"forks":196,"open_issues":62,"watchers":3166,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/osquery/pulls/440"},"html":{"href":"https://github.com/facebook/osquery/pull/440"},"issue":{"href":"https://api.github.com/repos/facebook/osquery/issues/440"},"comments":{"href":"https://api.github.com/repos/facebook/osquery/issues/440/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/osquery/pulls/440/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/osquery/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/facebook/osquery/pulls/440/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/osquery/statuses/0b4e382e968b607f0df980d283471eae1e02237a"}}}}