GitHub PullRequestReviewCommentEvent at 2014-12-27 15:34:49
Repository: zordzman-plus-plus
Actor: JavaCakess
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/TeamLe-Shop/zordzman-plus-plus/pulls/comments/22292969","id":22292969,"diff_hunk":"@@ -142,20 +130,16 @@ int Server::exec() {\n     while (true) {\n         acceptConnections();\n         for (auto &client : m_clients) {\n-            for (auto &message : client.exec()) {\n-                // We can't use message.has_shape() here because we don't want\n-                // to make assumptions about the type of the message entity\n-                if (message.is_object()) {\n-                    Json type = message[\"type\"];\n-                    // If the 'type' field doesn't exist then is_string()\n-                    // is falsey\n-                    if (type.is_string()) {\n-                        for (auto &handler : m_handlers[type.string_value()]) {\n-                            handler(this, &client, message[\"entity\"]);\n-                        }\n-                    }\n-                }\n+            if (client.m_state == Client::Pending) {\n+                char buffer[512];\n+                bzero(buffer, 512);","path":"server/lib/Server.cpp","position":null,"original_position":79,"commit_id":"c3ad60999ba7cfac6af53459a2693512966e9ac0","original_commit_id":"bd9c79efd2a7250c862bd6c6deb26d3c8caf1c19","user":{"login":"JavaCakess","id":4682771,"avatar_url":"https://avatars.githubusercontent.com/u/4682771?v=3","gravatar_id":"","url":"https://api.github.com/users/JavaCakess","html_url":"https://github.com/JavaCakess","followers_url":"https://api.github.com/users/JavaCakess/followers","following_url":"https://api.github.com/users/JavaCakess/following{/other_user}","gists_url":"https://api.github.com/users/JavaCakess/gists{/gist_id}","starred_url":"https://api.github.com/users/JavaCakess/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JavaCakess/subscriptions","organizations_url":"https://api.github.com/users/JavaCakess/orgs","repos_url":"https://api.github.com/users/JavaCakess/repos","events_url":"https://api.github.com/users/JavaCakess/events{/privacy}","received_events_url":"https://api.github.com/users/JavaCakess/received_events","type":"User","site_admin":false},"body":"Memset used.","created_at":"2014-12-27T15:34:49Z","updated_at":"2014-12-27T15:34:49Z","html_url":"https://github.com/TeamLe-Shop/zordzman-plus-plus/pull/31#discussion_r22292969","pull_request_url":"https://api.github.com/repos/TeamLe-Shop/zordzman-plus-plus/pulls/31","_links":{"self":{"href":"https://api.github.com/repos/TeamLe-Shop/zordzman-plus-plus/pulls/comments/22292969"},"html":{"href":"https://github.com/TeamLe-Shop/zordzman-plus-plus/pull/31#discussion_r22292969"},"pull_request":{"href":"https://api.github.com/repos/TeamLe-Shop/zordzman-plus-plus/pulls/31"}}},"pull_request":{"url":"https://api.github.com/repos/TeamLe-Shop/zordzman-plus-plus/pulls/31","id":26386676,"html_url":"https://github.com/TeamLe-Shop/zordzman-plus-plus/pull/31","diff_url":"https://github.com/TeamLe-Shop/zordzman-plus-plus/pull/31.diff","patch_url":"https://github.com/TeamLe-Shop/zordzman-plus-plus/pull/31.patch","issue_url":"https://api.github.com/repos/TeamLe-Shop/zordzman-plus-plus/issues/31","number":31,"state":"open","locked":false,"title":"Remove TCPSocket and use MessageProcessor instead","user":{"login":"JavaCakess","id":4682771,"avatar_url":"https://avatars.githubusercontent.com/u/4682771?v=3","gravatar_id":"","url":"https://api.github.com/users/JavaCakess","html_url":"https://github.com/JavaCakess","followers_url":"https://api.github.com/users/JavaCakess/followers","following_url":"https://api.github.com/users/JavaCakess/following{/other_user}","gists_url":"https://api.github.com/users/JavaCakess/gists{/gist_id}","starred_url":"https://api.github.com/users/JavaCakess/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JavaCakess/subscriptions","organizations_url":"https://api.github.com/users/JavaCakess/orgs","repos_url":"https://api.github.com/users/JavaCakess/repos","events_url":"https://api.github.com/users/JavaCakess/events{/privacy}","received_events_url":"https://api.github.com/users/JavaCakess/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-12-19T17:37:59Z","updated_at":"2014-12-27T15:34:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cac3575c7f44303f4cc4b6c9ea32e3e8640ec02e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/TeamLe-Shop/zordzman-plus-plus/pulls/31/commits","review_comments_url":"https://api.github.com/repos/TeamLe-Shop/zordzman-plus-plus/pulls/31/comments","review_comment_url":"https://api.github.com/repos/TeamLe-Shop/zordzman-plus-plus/pulls/comments/{number}","comments_url":"https://api.github.com/repos/TeamLe-Shop/zordzman-plus-plus/issues/31/comments","statuses_url":"https://api.github.com/repos/TeamLe-Shop/zordzman-plus-plus/statuses/c3ad60999ba7cfac6af53459a2693512966e9ac0","head":{"label":"TeamLe-Shop:msg-processor","ref":"msg-processor","sha":"c3ad60999ba7cfac6af53459a2693512966e9ac0","user":{"login":"TeamLe-Shop","id":8238874,"avatar_url":"https://avatars.githubusercontent.com/u/8238874?v=3","gravatar_id":"","url":"https://api.github.com/users/TeamLe-Shop","html_url":"https://github.com/TeamLe-Shop","followers_url":"https://api.github.com/users/TeamLe-Shop/followers","following_url":"https://api.github.com/users/TeamLe-Shop/following{/other_user}","gists_url":"https://api.github.com/users/TeamLe-Shop/gists{/gist_id}","starred_url":"https://api.github.com/users/TeamLe-Shop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TeamLe-Shop/subscriptions","organizations_url":"https://api.github.com/users/TeamLe-Shop/orgs","repos_url":"https://api.github.com/users/TeamLe-Shop/repos","events_url":"https://api.github.com/users/TeamLe-Shop/events{/privacy}","received_events_url":"https://api.github.com/users/TeamLe-Shop/received_events","type":"Organization","site_admin":false},"repo":{"id":22427716,"name":"zordzman-plus-plus","full_name":"TeamLe-Shop/zordzman-plus-plus","owner":{"login":"TeamLe-Shop","id":8238874,"avatar_url":"https://avatars.githubusercontent.com/u/8238874?v=3","gravatar_id":"","url":"https://api.github.com/users/TeamLe-Shop","html_url":"https://github.com/TeamLe-Shop","followers_url":"https://api.github.com/users/TeamLe-Shop/followers","following_url":"https://api.github.com/users/TeamLe-Shop/following{/other_user}","gists_url":"https://api.github.com/users/TeamLe-Shop/gists{/gist_id}","starred_url":"https://api.github.com/users/TeamLe-Shop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TeamLe-Shop/subscriptions","organizations_url":"https://api.github.com/users/TeamLe-Shop/orgs","repos_url":"https://api.github.com/users/TeamLe-Shop/repos","events_url":"https://api.github.com/users/TeamLe-Shop/events{/privacy}","received_events_url":"https://api.github.com/users/TeamLe-Shop/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TeamLe-Shop/zordzman-plus-plus","description":"ZAORROMON, TALE OF A YOUNG NORDIC BOI","fork":false,"url":"https://api.github.com/repos/TeamLe-Shop/zordzman-plus-plus","forks_url":"https://api.github.com/repos/TeamLe-Shop/zordzman-plus-plus/forks","keys_url":"https://api.github.com/repos/TeamLe-Shop/zordzman-plus-plus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TeamLe-Shop/zordzman-plus-plus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TeamLe-Shop/zordzman-plus-plus/teams","hooks_url":"https://api.github.com/repos/TeamLe-Shop/zordzman-plus-plus/hooks","issue_events_url":"https://api.github.com/repos/TeamLe-Shop/zordzman-plus-plus/issues/events{/number}","events_url":"https://api.github.com/repos/TeamLe-Shop/zordzman-plus-plus/events","assignees_url":"https://api.github.com/repos/TeamLe-Shop/zordzman-plus-plus/assignees{/user}","branches_url":"https://api.github.com/repos/TeamLe-Shop/zordzman-plus-plus/branches{/branch}","tags_url":"https://api.github.com/repos/TeamLe-Shop/zordzman-plus-plus/tags","blobs_url":"https://api.github.com/repos/TeamLe-Shop/zordzman-plus-plus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TeamLe-Shop/zordzman-plus-plus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TeamLe-Shop/zordzman-plus-plus/git/refs{/sha}","trees_url":"https://api.github.com/repos/TeamLe-Shop/zordzman-plus-plus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TeamLe-Shop/zordzman-plus-plus/statuses/{sha}","languages_url":"https://api.github.com/repos/TeamLe-Shop/zordzman-plus-plus/languages","stargazers_url":"https://api.github.com/repos/TeamLe-Shop/zordzman-plus-plus/stargazers","contributors_url":"https://api.github.com/repos/TeamLe-Shop/zordzman-plus-plus/contributors","subscribers_url":"https://api.github.com/repos/TeamLe-Shop/zordzman-plus-plus/subscribers","subscription_url":"https://api.github.com/repos/TeamLe-Shop/zordzman-plus-plus/subscription","commits_url":"https://api.github.com/repos/TeamLe-Shop/zordzman-plus-plus/commits{/sha}","git_commits_url":"https://api.github.com/repos/TeamLe-Shop/zordzman-plus-plus/git/commits{/sha}","comments_url":"https://api.github.com/repos/TeamLe-Shop/zordzman-plus-plus/comments{/number}","issue_comment_url":"https://api.github.com/repos/TeamLe-Shop/zordzman-plus-plus/issues/comments/{number}","contents_url":"https://api.github.com/repos/TeamLe-Shop/zordzman-plus-plus/contents/{+path}","compare_url":"https://api.github.com/repos/TeamLe-Shop/zordzman-plus-plus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TeamLe-Shop/zordzman-plus-plus/merges","archive_url":"https://api.github.com/repos/TeamLe-Shop/zordzman-plus-plus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TeamLe-Shop/zordzman-plus-plus/downloads","issues_url":"https://api.github.com/repos/TeamLe-Shop/zordzman-plus-plus/issues{/number}","pulls_url":"https://api.github.com/repos/TeamLe-Shop/zordzman-plus-plus/pulls{/number}","milestones_url":"https://api.github.com/repos/TeamLe-Shop/zordzman-plus-plus/milestones{/number}","notifications_url":"https://api.github.com/repos/TeamLe-Shop/zordzman-plus-plus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TeamLe-Shop/zordzman-plus-plus/labels{/name}","releases_url":"https://api.github.com/repos/TeamLe-Shop/zordzman-plus-plus/releases{/id}","created_at":"2014-07-30T12:59:21Z","updated_at":"2014-12-20T08:38:56Z","pushed_at":"2014-12-27T15:32:13Z","git_url":"git://github.com/TeamLe-Shop/zordzman-plus-plus.git","ssh_url":"git@github.com:TeamLe-Shop/zordzman-plus-plus.git","clone_url":"https://github.com/TeamLe-Shop/zordzman-plus-plus.git","svn_url":"https://github.com/TeamLe-Shop/zordzman-plus-plus","homepage":"","size":8168,"stargazers_count":3,"watchers_count":3,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":6,"forks":5,"open_issues":6,"watchers":3,"default_branch":"master"}},"base":{"label":"TeamLe-Shop:master","ref":"master","sha":"3d3ba9cd33d688074bd27915df1b6088bd46efd1","user":{"login":"TeamLe-Shop","id":8238874,"avatar_url":"https://avatars.githubusercontent.com/u/8238874?v=3","gravatar_id":"","url":"https://api.github.com/users/TeamLe-Shop","html_url":"https://github.com/TeamLe-Shop","followers_url":"https://api.github.com/users/TeamLe-Shop/followers","following_url":"https://api.github.com/users/TeamLe-Shop/following{/other_user}","gists_url":"https://api.github.com/users/TeamLe-Shop/gists{/gist_id}","starred_url":"https://api.github.com/users/TeamLe-Shop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TeamLe-Shop/subscriptions","organizations_url":"https://api.github.com/users/TeamLe-Shop/orgs","repos_url":"https://api.github.com/users/TeamLe-Shop/repos","events_url":"https://api.github.com/users/TeamLe-Shop/events{/privacy}","received_events_url":"https://api.github.com/users/TeamLe-Shop/received_events","type":"Organization","site_admin":false},"repo":{"id":22427716,"name":"zordzman-plus-plus","full_name":"TeamLe-Shop/zordzman-plus-plus","owner":{"login":"TeamLe-Shop","id":8238874,"avatar_url":"https://avatars.githubusercontent.com/u/8238874?v=3","gravatar_id":"","url":"https://api.github.com/users/TeamLe-Shop","html_url":"https://github.com/TeamLe-Shop","followers_url":"https://api.github.com/users/TeamLe-Shop/followers","following_url":"https://api.github.com/users/TeamLe-Shop/following{/other_user}","gists_url":"https://api.github.com/users/TeamLe-Shop/gists{/gist_id}","starred_url":"https://api.github.com/users/TeamLe-Shop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TeamLe-Shop/subscriptions","organizations_url":"https://api.github.com/users/TeamLe-Shop/orgs","repos_url":"https://api.github.com/users/TeamLe-Shop/repos","events_url":"https://api.github.com/users/TeamLe-Shop/events{/privacy}","received_events_url":"https://api.github.com/users/TeamLe-Shop/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TeamLe-Shop/zordzman-plus-plus","description":"ZAORROMON, TALE OF A YOUNG NORDIC BOI","fork":false,"url":"https://api.github.com/repos/TeamLe-Shop/zordzman-plus-plus","forks_url":"https://api.github.com/repos/TeamLe-Shop/zordzman-plus-plus/forks","keys_url":"https://api.github.com/repos/TeamLe-Shop/zordzman-plus-plus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TeamLe-Shop/zordzman-plus-plus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TeamLe-Shop/zordzman-plus-plus/teams","hooks_url":"https://api.github.com/repos/TeamLe-Shop/zordzman-plus-plus/hooks","issue_events_url":"https://api.github.com/repos/TeamLe-Shop/zordzman-plus-plus/issues/events{/number}","events_url":"https://api.github.com/repos/TeamLe-Shop/zordzman-plus-plus/events","assignees_url":"https://api.github.com/repos/TeamLe-Shop/zordzman-plus-plus/assignees{/user}","branches_url":"https://api.github.com/repos/TeamLe-Shop/zordzman-plus-plus/branches{/branch}","tags_url":"https://api.github.com/repos/TeamLe-Shop/zordzman-plus-plus/tags","blobs_url":"https://api.github.com/repos/TeamLe-Shop/zordzman-plus-plus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TeamLe-Shop/zordzman-plus-plus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TeamLe-Shop/zordzman-plus-plus/git/refs{/sha}","trees_url":"https://api.github.com/repos/TeamLe-Shop/zordzman-plus-plus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TeamLe-Shop/zordzman-plus-plus/statuses/{sha}","languages_url":"https://api.github.com/repos/TeamLe-Shop/zordzman-plus-plus/languages","stargazers_url":"https://api.github.com/repos/TeamLe-Shop/zordzman-plus-plus/stargazers","contributors_url":"https://api.github.com/repos/TeamLe-Shop/zordzman-plus-plus/contributors","subscribers_url":"https://api.github.com/repos/TeamLe-Shop/zordzman-plus-plus/subscribers","subscription_url":"https://api.github.com/repos/TeamLe-Shop/zordzman-plus-plus/subscription","commits_url":"https://api.github.com/repos/TeamLe-Shop/zordzman-plus-plus/commits{/sha}","git_commits_url":"https://api.github.com/repos/TeamLe-Shop/zordzman-plus-plus/git/commits{/sha}","comments_url":"https://api.github.com/repos/TeamLe-Shop/zordzman-plus-plus/comments{/number}","issue_comment_url":"https://api.github.com/repos/TeamLe-Shop/zordzman-plus-plus/issues/comments/{number}","contents_url":"https://api.github.com/repos/TeamLe-Shop/zordzman-plus-plus/contents/{+path}","compare_url":"https://api.github.com/repos/TeamLe-Shop/zordzman-plus-plus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TeamLe-Shop/zordzman-plus-plus/merges","archive_url":"https://api.github.com/repos/TeamLe-Shop/zordzman-plus-plus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TeamLe-Shop/zordzman-plus-plus/downloads","issues_url":"https://api.github.com/repos/TeamLe-Shop/zordzman-plus-plus/issues{/number}","pulls_url":"https://api.github.com/repos/TeamLe-Shop/zordzman-plus-plus/pulls{/number}","milestones_url":"https://api.github.com/repos/TeamLe-Shop/zordzman-plus-plus/milestones{/number}","notifications_url":"https://api.github.com/repos/TeamLe-Shop/zordzman-plus-plus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TeamLe-Shop/zordzman-plus-plus/labels{/name}","releases_url":"https://api.github.com/repos/TeamLe-Shop/zordzman-plus-plus/releases{/id}","created_at":"2014-07-30T12:59:21Z","updated_at":"2014-12-20T08:38:56Z","pushed_at":"2014-12-27T15:32:13Z","git_url":"git://github.com/TeamLe-Shop/zordzman-plus-plus.git","ssh_url":"git@github.com:TeamLe-Shop/zordzman-plus-plus.git","clone_url":"https://github.com/TeamLe-Shop/zordzman-plus-plus.git","svn_url":"https://github.com/TeamLe-Shop/zordzman-plus-plus","homepage":"","size":8168,"stargazers_count":3,"watchers_count":3,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":6,"forks":5,"open_issues":6,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TeamLe-Shop/zordzman-plus-plus/pulls/31"},"html":{"href":"https://github.com/TeamLe-Shop/zordzman-plus-plus/pull/31"},"issue":{"href":"https://api.github.com/repos/TeamLe-Shop/zordzman-plus-plus/issues/31"},"comments":{"href":"https://api.github.com/repos/TeamLe-Shop/zordzman-plus-plus/issues/31/comments"},"review_comments":{"href":"https://api.github.com/repos/TeamLe-Shop/zordzman-plus-plus/pulls/31/comments"},"review_comment":{"href":"https://api.github.com/repos/TeamLe-Shop/zordzman-plus-plus/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/TeamLe-Shop/zordzman-plus-plus/pulls/31/commits"},"statuses":{"href":"https://api.github.com/repos/TeamLe-Shop/zordzman-plus-plus/statuses/c3ad60999ba7cfac6af53459a2693512966e9ac0"}}}}