GitHub PullRequestReviewCommentEvent at 2014-09-10 15:15:43
Repository: merlin
Actor: ouchadam
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/novoda/merlin/pulls/comments/17367010","id":17367010,"diff_hunk":"@@ -15,8 +15,10 @@\n @RunWith(MerlinRobolectricTestRunner.class)\n public class MerlinShould {\n \n-    @Mock private Context context;","path":"unit-tests/src/test/java/com/novoda/merlin/MerlinShould.java","position":4,"original_position":4,"commit_id":"7f4de444e42b9f622be66a4b3ed8268cca557aed","original_commit_id":"7f4de444e42b9f622be66a4b3ed8268cca557aed","user":{"login":"ouchadam","id":1848238,"avatar_url":"https://avatars.githubusercontent.com/u/1848238?v=2","gravatar_id":"e7705edf46c38df6f44b0190d02bca97","url":"https://api.github.com/users/ouchadam","html_url":"https://github.com/ouchadam","followers_url":"https://api.github.com/users/ouchadam/followers","following_url":"https://api.github.com/users/ouchadam/following{/other_user}","gists_url":"https://api.github.com/users/ouchadam/gists{/gist_id}","starred_url":"https://api.github.com/users/ouchadam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ouchadam/subscriptions","organizations_url":"https://api.github.com/users/ouchadam/orgs","repos_url":"https://api.github.com/users/ouchadam/repos","events_url":"https://api.github.com/users/ouchadam/events{/privacy}","received_events_url":"https://api.github.com/users/ouchadam/received_events","type":"User","site_admin":false},"body":"noooooo my beautiful formatting :cry: ","created_at":"2014-09-10T15:15:43Z","updated_at":"2014-09-10T15:15:43Z","html_url":"https://github.com/novoda/merlin/pull/34#discussion_r17367010","pull_request_url":"https://api.github.com/repos/novoda/merlin/pulls/34","_links":{"self":{"href":"https://api.github.com/repos/novoda/merlin/pulls/comments/17367010"},"html":{"href":"https://github.com/novoda/merlin/pull/34#discussion_r17367010"},"pull_request":{"href":"https://api.github.com/repos/novoda/merlin/pulls/34"}}},"pull_request":{"url":"https://api.github.com/repos/novoda/merlin/pulls/34","id":21009191,"html_url":"https://github.com/novoda/merlin/pull/34","diff_url":"https://github.com/novoda/merlin/pull/34.diff","patch_url":"https://github.com/novoda/merlin/pull/34.patch","issue_url":"https://api.github.com/repos/novoda/merlin/issues/34","number":34,"state":"open","locked":false,"title":"Issue 29 Network State","user":{"login":"Mecharyry","id":3380092,"avatar_url":"https://avatars.githubusercontent.com/u/3380092?v=2","gravatar_id":"5ba1b3d7770b631f9b117c52884e4dda","url":"https://api.github.com/users/Mecharyry","html_url":"https://github.com/Mecharyry","followers_url":"https://api.github.com/users/Mecharyry/followers","following_url":"https://api.github.com/users/Mecharyry/following{/other_user}","gists_url":"https://api.github.com/users/Mecharyry/gists{/gist_id}","starred_url":"https://api.github.com/users/Mecharyry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mecharyry/subscriptions","organizations_url":"https://api.github.com/users/Mecharyry/orgs","repos_url":"https://api.github.com/users/Mecharyry/repos","events_url":"https://api.github.com/users/Mecharyry/events{/privacy}","received_events_url":"https://api.github.com/users/Mecharyry/received_events","type":"User","site_admin":false},"body":"This pull request addresses issue #29 Provide the Current Network State. \r\n\r\nJust adds two methods into Merlin class which will retrieve the network info from a given context and return the network status. \r\n\r\n~~I was tempted to create a dummy Application in the android manifest and have it static so that you would not be required to pass a context in order to retrieve a network status, but there wouldn't be any guarantee that the onCreate would be called before someone tried to access the isConnected method.~~\r\n\r\n^^ Me forgetting that this is a library :tongue: \r\n\r\n","created_at":"2014-09-10T09:39:18Z","updated_at":"2014-09-10T15:15:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4de62b4ff87fccbf7c90e923444a589d80c15d0d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/novoda/merlin/pulls/34/commits","review_comments_url":"https://api.github.com/repos/novoda/merlin/pulls/34/comments","review_comment_url":"https://api.github.com/repos/novoda/merlin/pulls/comments/{number}","comments_url":"https://api.github.com/repos/novoda/merlin/issues/34/comments","statuses_url":"https://api.github.com/repos/novoda/merlin/statuses/7f4de444e42b9f622be66a4b3ed8268cca557aed","head":{"label":"novoda:Issue_29_NetworkState","ref":"Issue_29_NetworkState","sha":"7f4de444e42b9f622be66a4b3ed8268cca557aed","user":{"login":"novoda","id":74874,"avatar_url":"https://avatars.githubusercontent.com/u/74874?v=2","gravatar_id":"104b9579fb9d4f683d7bea2722bc5940","url":"https://api.github.com/users/novoda","html_url":"https://github.com/novoda","followers_url":"https://api.github.com/users/novoda/followers","following_url":"https://api.github.com/users/novoda/following{/other_user}","gists_url":"https://api.github.com/users/novoda/gists{/gist_id}","starred_url":"https://api.github.com/users/novoda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/novoda/subscriptions","organizations_url":"https://api.github.com/users/novoda/orgs","repos_url":"https://api.github.com/users/novoda/repos","events_url":"https://api.github.com/users/novoda/events{/privacy}","received_events_url":"https://api.github.com/users/novoda/received_events","type":"Organization","site_admin":false},"repo":{"id":9941578,"name":"merlin","full_name":"novoda/merlin","owner":{"login":"novoda","id":74874,"avatar_url":"https://avatars.githubusercontent.com/u/74874?v=2","gravatar_id":"104b9579fb9d4f683d7bea2722bc5940","url":"https://api.github.com/users/novoda","html_url":"https://github.com/novoda","followers_url":"https://api.github.com/users/novoda/followers","following_url":"https://api.github.com/users/novoda/following{/other_user}","gists_url":"https://api.github.com/users/novoda/gists{/gist_id}","starred_url":"https://api.github.com/users/novoda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/novoda/subscriptions","organizations_url":"https://api.github.com/users/novoda/orgs","repos_url":"https://api.github.com/users/novoda/repos","events_url":"https://api.github.com/users/novoda/events{/privacy}","received_events_url":"https://api.github.com/users/novoda/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/novoda/merlin","description":"Observes network connection status & gives callbacks","fork":false,"url":"https://api.github.com/repos/novoda/merlin","forks_url":"https://api.github.com/repos/novoda/merlin/forks","keys_url":"https://api.github.com/repos/novoda/merlin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/novoda/merlin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/novoda/merlin/teams","hooks_url":"https://api.github.com/repos/novoda/merlin/hooks","issue_events_url":"https://api.github.com/repos/novoda/merlin/issues/events{/number}","events_url":"https://api.github.com/repos/novoda/merlin/events","assignees_url":"https://api.github.com/repos/novoda/merlin/assignees{/user}","branches_url":"https://api.github.com/repos/novoda/merlin/branches{/branch}","tags_url":"https://api.github.com/repos/novoda/merlin/tags","blobs_url":"https://api.github.com/repos/novoda/merlin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/novoda/merlin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/novoda/merlin/git/refs{/sha}","trees_url":"https://api.github.com/repos/novoda/merlin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/novoda/merlin/statuses/{sha}","languages_url":"https://api.github.com/repos/novoda/merlin/languages","stargazers_url":"https://api.github.com/repos/novoda/merlin/stargazers","contributors_url":"https://api.github.com/repos/novoda/merlin/contributors","subscribers_url":"https://api.github.com/repos/novoda/merlin/subscribers","subscription_url":"https://api.github.com/repos/novoda/merlin/subscription","commits_url":"https://api.github.com/repos/novoda/merlin/commits{/sha}","git_commits_url":"https://api.github.com/repos/novoda/merlin/git/commits{/sha}","comments_url":"https://api.github.com/repos/novoda/merlin/comments{/number}","issue_comment_url":"https://api.github.com/repos/novoda/merlin/issues/comments/{number}","contents_url":"https://api.github.com/repos/novoda/merlin/contents/{+path}","compare_url":"https://api.github.com/repos/novoda/merlin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/novoda/merlin/merges","archive_url":"https://api.github.com/repos/novoda/merlin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/novoda/merlin/downloads","issues_url":"https://api.github.com/repos/novoda/merlin/issues{/number}","pulls_url":"https://api.github.com/repos/novoda/merlin/pulls{/number}","milestones_url":"https://api.github.com/repos/novoda/merlin/milestones{/number}","notifications_url":"https://api.github.com/repos/novoda/merlin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/novoda/merlin/labels{/name}","releases_url":"https://api.github.com/repos/novoda/merlin/releases{/id}","created_at":"2013-05-08T17:03:53Z","updated_at":"2014-09-09T16:23:33Z","pushed_at":"2014-09-10T14:03:28Z","git_url":"git://github.com/novoda/merlin.git","ssh_url":"git@github.com:novoda/merlin.git","clone_url":"https://github.com/novoda/merlin.git","svn_url":"https://github.com/novoda/merlin","homepage":"","size":1836,"stargazers_count":144,"watchers_count":144,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":13,"mirror_url":null,"open_issues_count":9,"forks":13,"open_issues":9,"watchers":144,"default_branch":"master"}},"base":{"label":"novoda:master","ref":"master","sha":"6159dc3e087cf4fde21872fbd8cf2e6cb4d3f566","user":{"login":"novoda","id":74874,"avatar_url":"https://avatars.githubusercontent.com/u/74874?v=2","gravatar_id":"104b9579fb9d4f683d7bea2722bc5940","url":"https://api.github.com/users/novoda","html_url":"https://github.com/novoda","followers_url":"https://api.github.com/users/novoda/followers","following_url":"https://api.github.com/users/novoda/following{/other_user}","gists_url":"https://api.github.com/users/novoda/gists{/gist_id}","starred_url":"https://api.github.com/users/novoda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/novoda/subscriptions","organizations_url":"https://api.github.com/users/novoda/orgs","repos_url":"https://api.github.com/users/novoda/repos","events_url":"https://api.github.com/users/novoda/events{/privacy}","received_events_url":"https://api.github.com/users/novoda/received_events","type":"Organization","site_admin":false},"repo":{"id":9941578,"name":"merlin","full_name":"novoda/merlin","owner":{"login":"novoda","id":74874,"avatar_url":"https://avatars.githubusercontent.com/u/74874?v=2","gravatar_id":"104b9579fb9d4f683d7bea2722bc5940","url":"https://api.github.com/users/novoda","html_url":"https://github.com/novoda","followers_url":"https://api.github.com/users/novoda/followers","following_url":"https://api.github.com/users/novoda/following{/other_user}","gists_url":"https://api.github.com/users/novoda/gists{/gist_id}","starred_url":"https://api.github.com/users/novoda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/novoda/subscriptions","organizations_url":"https://api.github.com/users/novoda/orgs","repos_url":"https://api.github.com/users/novoda/repos","events_url":"https://api.github.com/users/novoda/events{/privacy}","received_events_url":"https://api.github.com/users/novoda/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/novoda/merlin","description":"Observes network connection status & gives callbacks","fork":false,"url":"https://api.github.com/repos/novoda/merlin","forks_url":"https://api.github.com/repos/novoda/merlin/forks","keys_url":"https://api.github.com/repos/novoda/merlin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/novoda/merlin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/novoda/merlin/teams","hooks_url":"https://api.github.com/repos/novoda/merlin/hooks","issue_events_url":"https://api.github.com/repos/novoda/merlin/issues/events{/number}","events_url":"https://api.github.com/repos/novoda/merlin/events","assignees_url":"https://api.github.com/repos/novoda/merlin/assignees{/user}","branches_url":"https://api.github.com/repos/novoda/merlin/branches{/branch}","tags_url":"https://api.github.com/repos/novoda/merlin/tags","blobs_url":"https://api.github.com/repos/novoda/merlin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/novoda/merlin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/novoda/merlin/git/refs{/sha}","trees_url":"https://api.github.com/repos/novoda/merlin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/novoda/merlin/statuses/{sha}","languages_url":"https://api.github.com/repos/novoda/merlin/languages","stargazers_url":"https://api.github.com/repos/novoda/merlin/stargazers","contributors_url":"https://api.github.com/repos/novoda/merlin/contributors","subscribers_url":"https://api.github.com/repos/novoda/merlin/subscribers","subscription_url":"https://api.github.com/repos/novoda/merlin/subscription","commits_url":"https://api.github.com/repos/novoda/merlin/commits{/sha}","git_commits_url":"https://api.github.com/repos/novoda/merlin/git/commits{/sha}","comments_url":"https://api.github.com/repos/novoda/merlin/comments{/number}","issue_comment_url":"https://api.github.com/repos/novoda/merlin/issues/comments/{number}","contents_url":"https://api.github.com/repos/novoda/merlin/contents/{+path}","compare_url":"https://api.github.com/repos/novoda/merlin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/novoda/merlin/merges","archive_url":"https://api.github.com/repos/novoda/merlin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/novoda/merlin/downloads","issues_url":"https://api.github.com/repos/novoda/merlin/issues{/number}","pulls_url":"https://api.github.com/repos/novoda/merlin/pulls{/number}","milestones_url":"https://api.github.com/repos/novoda/merlin/milestones{/number}","notifications_url":"https://api.github.com/repos/novoda/merlin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/novoda/merlin/labels{/name}","releases_url":"https://api.github.com/repos/novoda/merlin/releases{/id}","created_at":"2013-05-08T17:03:53Z","updated_at":"2014-09-09T16:23:33Z","pushed_at":"2014-09-10T14:03:28Z","git_url":"git://github.com/novoda/merlin.git","ssh_url":"git@github.com:novoda/merlin.git","clone_url":"https://github.com/novoda/merlin.git","svn_url":"https://github.com/novoda/merlin","homepage":"","size":1836,"stargazers_count":144,"watchers_count":144,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":13,"mirror_url":null,"open_issues_count":9,"forks":13,"open_issues":9,"watchers":144,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/novoda/merlin/pulls/34"},"html":{"href":"https://github.com/novoda/merlin/pull/34"},"issue":{"href":"https://api.github.com/repos/novoda/merlin/issues/34"},"comments":{"href":"https://api.github.com/repos/novoda/merlin/issues/34/comments"},"review_comments":{"href":"https://api.github.com/repos/novoda/merlin/pulls/34/comments"},"review_comment":{"href":"https://api.github.com/repos/novoda/merlin/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/novoda/merlin/pulls/34/commits"},"statuses":{"href":"https://api.github.com/repos/novoda/merlin/statuses/7f4de444e42b9f622be66a4b3ed8268cca557aed"}}}}