GitHub PullRequestReviewCommentEvent at 2014-03-20 18:20:41
Repository: usergrid
Actor: tnine
Payload: {"comment":{"url":"https://api.github.com/repos/usergrid/usergrid/pulls/comments/10808841","id":10808841,"diff_hunk":"@@ -318,26 +327,33 @@ public ByteBuffer toByteBuffer( final EntityWrapper wrapper ) {\n                 builder.addBytes( STATE_PARTIAL );\n             }\n \n-            builder.addBytes( SER.toByteBuffer( wrapper.entity.get() ));\n+            try {\n+                builder.addBytes( mapper.writeValueAsBytes( wrapper.entity.get() ) );\n+            }\n+            catch ( JsonMappingException e ) {","path":"stack/corepersistence/collection/src/main/java/org/apache/usergrid/persistence/collection/serialization/impl/MvccEntitySerializationStrategyImpl.java","position":98,"original_position":98,"commit_id":"fcb6c9ac79b9d0fcf62c74ad92728d7b72ab1fef","original_commit_id":"fcb6c9ac79b9d0fcf62c74ad92728d7b72ab1fef","user":{"login":"tnine","id":249532,"avatar_url":"https://avatars.githubusercontent.com/u/249532?","gravatar_id":"6dd381ebefbe4ed453a3dd502c390cbb","url":"https://api.github.com/users/tnine","html_url":"https://github.com/tnine","followers_url":"https://api.github.com/users/tnine/followers","following_url":"https://api.github.com/users/tnine/following{/other_user}","gists_url":"https://api.github.com/users/tnine/gists{/gist_id}","starred_url":"https://api.github.com/users/tnine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tnine/subscriptions","organizations_url":"https://api.github.com/users/tnine/orgs","repos_url":"https://api.github.com/users/tnine/repos","events_url":"https://api.github.com/users/tnine/events{/privacy}","received_events_url":"https://api.github.com/users/tnine/received_events","type":"User","site_admin":false},"body":"Don't swallow exceptions.  If we get something weird here, wrap it in a CollectionRuntimeException and re-throw it.  We always want to signal to the caller something failed if we had a problem.","created_at":"2014-03-20T18:20:41Z","updated_at":"2014-03-20T18:20:41Z","html_url":"https://github.com/usergrid/usergrid/pull/77#discussion_r10808841","pull_request_url":"https://api.github.com/repos/usergrid/usergrid/pulls/77","_links":{"self":{"href":"https://api.github.com/repos/usergrid/usergrid/pulls/comments/10808841"},"html":{"href":"https://github.com/usergrid/usergrid/pull/77#discussion_r10808841"},"pull_request":{"href":"https://api.github.com/repos/usergrid/usergrid/pulls/77"}}}}