GitHub PullRequestReviewCommentEvent at 2014-03-24 16:05:35
Repository: homebrew
Actor: mikemcquaid
Payload: {"comment":{"url":"https://api.github.com/repos/Homebrew/homebrew/pulls/comments/10891144","id":10891144,"diff_hunk":"@@ -0,0 +1,22 @@\n+require \"formula\"\n+\n+class LSmash < Formula\n+  homepage \"http://up-cat.net/L%252DSMASH.html\"\n+  url \"https://github.com/l-smash/l-smash/archive/v1.5.0.tar.gz\"\n+  sha1 \"add437d5581946f211e2dcf8e03d6f1e0952f439\"\n+  head \"https://github.com/l-smash/l-smash.git\"\n+\n+  option \"disable-static\",  \"doesn't compile static library\"\n+  option \"enable-shared\",   \"also compile shared library besides static library\"\n+  option \"enable-debug\",    \"compile with debug symbols and never strip\"\n+\n+  def install\n+    args = [\"--prefix=#{prefix}\"]\n+    args << \"--disable-static\" if build.include? \"disable-static\"\n+    args << \"--enable-shared\"  if build.include? \"enable-shared\"\n+    args << \"--enable-debug\"   if build.include? \"enable-debug\"\n+\n+    system \"./configure\", *args\n+    system \"make\", \"install\"\n+  end","path":"Library/Formula/l-smash.rb","position":21,"original_position":21,"commit_id":"462efbb760e8fc33a2734b5d0ed3eee2f69e775d","original_commit_id":"462efbb760e8fc33a2734b5d0ed3eee2f69e775d","user":{"login":"mikemcquaid","id":125011,"avatar_url":"https://avatars.githubusercontent.com/u/125011?","gravatar_id":"215e0166d4d8265395c5d9076da73c70","url":"https://api.github.com/users/mikemcquaid","html_url":"https://github.com/mikemcquaid","followers_url":"https://api.github.com/users/mikemcquaid/followers","following_url":"https://api.github.com/users/mikemcquaid/following{/other_user}","gists_url":"https://api.github.com/users/mikemcquaid/gists{/gist_id}","starred_url":"https://api.github.com/users/mikemcquaid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikemcquaid/subscriptions","organizations_url":"https://api.github.com/users/mikemcquaid/orgs","repos_url":"https://api.github.com/users/mikemcquaid/repos","events_url":"https://api.github.com/users/mikemcquaid/events{/privacy}","received_events_url":"https://api.github.com/users/mikemcquaid/received_events","type":"User","site_admin":true},"body":"Can a test be added to do something more substantial then e.g. `--version` or `--help`? See `cmake.rb` for an example of a formula with a good test. Thanks!","created_at":"2014-03-24T16:05:35Z","updated_at":"2014-03-24T16:05:35Z","html_url":"https://github.com/Homebrew/homebrew/pull/27828#discussion_r10891144","pull_request_url":"https://api.github.com/repos/Homebrew/homebrew/pulls/27828","_links":{"self":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/comments/10891144"},"html":{"href":"https://github.com/Homebrew/homebrew/pull/27828#discussion_r10891144"},"pull_request":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/27828"}}}}