GitHub PullRequestReviewCommentEvent at 2014-06-19 19:42:30
Repository: phobos
Actor: s-ludwig
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/comments/13989074","id":13989074,"diff_hunk":"@@ -559,3 +571,491 @@ unittest\n         assert(encoded2 == encode(decoded2).to!StringType);\n     }\n }\n+\n+/* ====================== URI Struct ================ */\n+\n+/** URI struct\n+ * Examples:\n+ * --------------------\n+ * URI uri = \"scheme://user:pass@hostname:1234/path?query=string#_fragment_\";\n+ * auto s1 = uri.scheme;        // s1 = \"scheme\"\n+ * auto s2 = uri.authority;     // s2 = \"user:pass@hostname:1234\"\n+ * auto s3 = uri.auth;          // s3 = \"user:pass\"\n+ * auto s4 = uri.resource;      // s4 = \"hostname:1234\"\n+ * auto s5 = uri.pathAndQuery;  // s5 = \"/path?query=string\"\n+ * auto s6 = uri.username;      // s6 = \"user\"\n+ * auto s7 = uri.password;      // s7 = \"user\"\n+ * auto s8 = uri.host;          // s8 = \"hostname\"\n+ * auto p1 = uri.port;          // p1 = 1234\n+ * auto s9 = uri.path;          // s9 = \"/path\"\n+ * auto s10 = uri.query;        // s10 = \"query=string\"\n+ * auto s11 = uri.fragment;     // s11 = \"_fragment_\"\n+ * --------------------\n+ */\n+struct URI {\n+  private {\n+    struct Pair {\n+      string key;\n+      string val;\n+    }\n+    string  _scheme;\n+    string  _fragment;\n+    string  _host;\n+    string  _username;\n+    string  _password;\n+    string  _path;\n+    ushort  _port;\n+    Pair*[] _query;\n+  }\n+  /**\n+   * Create URI from string\n+   * Examples:\n+   * --------------------\n+   * auto uri = URI(\"http://dlang.org/\");\n+   * --------------------\n+   */\n+  this(string uri) {","path":"std/uri.d","position":75,"original_position":75,"commit_id":"978178595e4eada47fa362b88fc3b58a3550333a","original_commit_id":"978178595e4eada47fa362b88fc3b58a3550333a","user":{"login":"s-ludwig","id":1645969,"avatar_url":"https://avatars.githubusercontent.com/u/1645969?","gravatar_id":"6370fdf0b8d20bc8b4c66a10b8b5d147","url":"https://api.github.com/users/s-ludwig","html_url":"https://github.com/s-ludwig","followers_url":"https://api.github.com/users/s-ludwig/followers","following_url":"https://api.github.com/users/s-ludwig/following{/other_user}","gists_url":"https://api.github.com/users/s-ludwig/gists{/gist_id}","starred_url":"https://api.github.com/users/s-ludwig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s-ludwig/subscriptions","organizations_url":"https://api.github.com/users/s-ludwig/orgs","repos_url":"https://api.github.com/users/s-ludwig/repos","events_url":"https://api.github.com/users/s-ludwig/events{/privacy}","received_events_url":"https://api.github.com/users/s-ludwig/received_events","type":"User","site_admin":false},"body":"Not necessarily, if the implementation is supposed to support safe input string slicing to avoid allocations!","created_at":"2014-06-19T19:42:30Z","updated_at":"2014-06-19T19:42:30Z","html_url":"https://github.com/D-Programming-Language/phobos/pull/2257#discussion_r13989074","pull_request_url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/2257","_links":{"self":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/comments/13989074"},"html":{"href":"https://github.com/D-Programming-Language/phobos/pull/2257#discussion_r13989074"},"pull_request":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/2257"}}},"pull_request":{"url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/2257","id":17327049,"html_url":"https://github.com/D-Programming-Language/phobos/pull/2257","diff_url":"https://github.com/D-Programming-Language/phobos/pull/2257.diff","patch_url":"https://github.com/D-Programming-Language/phobos/pull/2257.patch","issue_url":"https://api.github.com/repos/D-Programming-Language/phobos/issues/2257","number":2257,"state":"open","title":"added struct for URI representation","user":{"login":"anton-dutov","id":1544442,"avatar_url":"https://avatars.githubusercontent.com/u/1544442?","gravatar_id":"b4a4f38fb4be90ce03d1146b193f58e6","url":"https://api.github.com/users/anton-dutov","html_url":"https://github.com/anton-dutov","followers_url":"https://api.github.com/users/anton-dutov/followers","following_url":"https://api.github.com/users/anton-dutov/following{/other_user}","gists_url":"https://api.github.com/users/anton-dutov/gists{/gist_id}","starred_url":"https://api.github.com/users/anton-dutov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anton-dutov/subscriptions","organizations_url":"https://api.github.com/users/anton-dutov/orgs","repos_url":"https://api.github.com/users/anton-dutov/repos","events_url":"https://api.github.com/users/anton-dutov/events{/privacy}","received_events_url":"https://api.github.com/users/anton-dutov/received_events","type":"User","site_admin":false},"body":"Advanced helper structure to URI representation, easy to parse/modify/construct URI strings.","created_at":"2014-06-18T23:59:35Z","updated_at":"2014-06-19T19:42:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2ec7411a7a4b86b61dc9c78f317f25335f38e76a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/2257/commits","review_comments_url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/2257/comments","review_comment_url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/comments/{number}","comments_url":"https://api.github.com/repos/D-Programming-Language/phobos/issues/2257/comments","statuses_url":"https://api.github.com/repos/D-Programming-Language/phobos/statuses/978178595e4eada47fa362b88fc3b58a3550333a","head":{"label":"anton-dutov:master","ref":"master","sha":"978178595e4eada47fa362b88fc3b58a3550333a","user":{"login":"anton-dutov","id":1544442,"avatar_url":"https://avatars.githubusercontent.com/u/1544442?","gravatar_id":"b4a4f38fb4be90ce03d1146b193f58e6","url":"https://api.github.com/users/anton-dutov","html_url":"https://github.com/anton-dutov","followers_url":"https://api.github.com/users/anton-dutov/followers","following_url":"https://api.github.com/users/anton-dutov/following{/other_user}","gists_url":"https://api.github.com/users/anton-dutov/gists{/gist_id}","starred_url":"https://api.github.com/users/anton-dutov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anton-dutov/subscriptions","organizations_url":"https://api.github.com/users/anton-dutov/orgs","repos_url":"https://api.github.com/users/anton-dutov/repos","events_url":"https://api.github.com/users/anton-dutov/events{/privacy}","received_events_url":"https://api.github.com/users/anton-dutov/received_events","type":"User","site_admin":false},"repo":{"id":20981406,"name":"phobos","full_name":"anton-dutov/phobos","owner":{"login":"anton-dutov","id":1544442,"avatar_url":"https://avatars.githubusercontent.com/u/1544442?","gravatar_id":"b4a4f38fb4be90ce03d1146b193f58e6","url":"https://api.github.com/users/anton-dutov","html_url":"https://github.com/anton-dutov","followers_url":"https://api.github.com/users/anton-dutov/followers","following_url":"https://api.github.com/users/anton-dutov/following{/other_user}","gists_url":"https://api.github.com/users/anton-dutov/gists{/gist_id}","starred_url":"https://api.github.com/users/anton-dutov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anton-dutov/subscriptions","organizations_url":"https://api.github.com/users/anton-dutov/orgs","repos_url":"https://api.github.com/users/anton-dutov/repos","events_url":"https://api.github.com/users/anton-dutov/events{/privacy}","received_events_url":"https://api.github.com/users/anton-dutov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/anton-dutov/phobos","description":"The standard library of the D programming language","fork":true,"url":"https://api.github.com/repos/anton-dutov/phobos","forks_url":"https://api.github.com/repos/anton-dutov/phobos/forks","keys_url":"https://api.github.com/repos/anton-dutov/phobos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/anton-dutov/phobos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/anton-dutov/phobos/teams","hooks_url":"https://api.github.com/repos/anton-dutov/phobos/hooks","issue_events_url":"https://api.github.com/repos/anton-dutov/phobos/issues/events{/number}","events_url":"https://api.github.com/repos/anton-dutov/phobos/events","assignees_url":"https://api.github.com/repos/anton-dutov/phobos/assignees{/user}","branches_url":"https://api.github.com/repos/anton-dutov/phobos/branches{/branch}","tags_url":"https://api.github.com/repos/anton-dutov/phobos/tags","blobs_url":"https://api.github.com/repos/anton-dutov/phobos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/anton-dutov/phobos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/anton-dutov/phobos/git/refs{/sha}","trees_url":"https://api.github.com/repos/anton-dutov/phobos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/anton-dutov/phobos/statuses/{sha}","languages_url":"https://api.github.com/repos/anton-dutov/phobos/languages","stargazers_url":"https://api.github.com/repos/anton-dutov/phobos/stargazers","contributors_url":"https://api.github.com/repos/anton-dutov/phobos/contributors","subscribers_url":"https://api.github.com/repos/anton-dutov/phobos/subscribers","subscription_url":"https://api.github.com/repos/anton-dutov/phobos/subscription","commits_url":"https://api.github.com/repos/anton-dutov/phobos/commits{/sha}","git_commits_url":"https://api.github.com/repos/anton-dutov/phobos/git/commits{/sha}","comments_url":"https://api.github.com/repos/anton-dutov/phobos/comments{/number}","issue_comment_url":"https://api.github.com/repos/anton-dutov/phobos/issues/comments/{number}","contents_url":"https://api.github.com/repos/anton-dutov/phobos/contents/{+path}","compare_url":"https://api.github.com/repos/anton-dutov/phobos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/anton-dutov/phobos/merges","archive_url":"https://api.github.com/repos/anton-dutov/phobos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/anton-dutov/phobos/downloads","issues_url":"https://api.github.com/repos/anton-dutov/phobos/issues{/number}","pulls_url":"https://api.github.com/repos/anton-dutov/phobos/pulls{/number}","milestones_url":"https://api.github.com/repos/anton-dutov/phobos/milestones{/number}","notifications_url":"https://api.github.com/repos/anton-dutov/phobos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/anton-dutov/phobos/labels{/name}","releases_url":"https://api.github.com/repos/anton-dutov/phobos/releases{/id}","created_at":"2014-06-18T23:27:26Z","updated_at":"2014-06-18T23:59:35Z","pushed_at":"2014-06-18T23:48:03Z","git_url":"git://github.com/anton-dutov/phobos.git","ssh_url":"git@github.com:anton-dutov/phobos.git","clone_url":"https://github.com/anton-dutov/phobos.git","svn_url":"https://github.com/anton-dutov/phobos","homepage":"dlang.org/phobos","size":51204,"stargazers_count":0,"watchers_count":0,"language":"D","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"D-Programming-Language:master","ref":"master","sha":"e63514cea498c1b97a36cec3c93058fbc18eac17","user":{"login":"D-Programming-Language","id":565913,"avatar_url":"https://avatars.githubusercontent.com/u/565913?","gravatar_id":"1fe90c0586802aee103ff9ac0b8f3fbe","url":"https://api.github.com/users/D-Programming-Language","html_url":"https://github.com/D-Programming-Language","followers_url":"https://api.github.com/users/D-Programming-Language/followers","following_url":"https://api.github.com/users/D-Programming-Language/following{/other_user}","gists_url":"https://api.github.com/users/D-Programming-Language/gists{/gist_id}","starred_url":"https://api.github.com/users/D-Programming-Language/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/D-Programming-Language/subscriptions","organizations_url":"https://api.github.com/users/D-Programming-Language/orgs","repos_url":"https://api.github.com/users/D-Programming-Language/repos","events_url":"https://api.github.com/users/D-Programming-Language/events{/privacy}","received_events_url":"https://api.github.com/users/D-Programming-Language/received_events","type":"Organization","site_admin":false},"repo":{"id":1257084,"name":"phobos","full_name":"D-Programming-Language/phobos","owner":{"login":"D-Programming-Language","id":565913,"avatar_url":"https://avatars.githubusercontent.com/u/565913?","gravatar_id":"1fe90c0586802aee103ff9ac0b8f3fbe","url":"https://api.github.com/users/D-Programming-Language","html_url":"https://github.com/D-Programming-Language","followers_url":"https://api.github.com/users/D-Programming-Language/followers","following_url":"https://api.github.com/users/D-Programming-Language/following{/other_user}","gists_url":"https://api.github.com/users/D-Programming-Language/gists{/gist_id}","starred_url":"https://api.github.com/users/D-Programming-Language/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/D-Programming-Language/subscriptions","organizations_url":"https://api.github.com/users/D-Programming-Language/orgs","repos_url":"https://api.github.com/users/D-Programming-Language/repos","events_url":"https://api.github.com/users/D-Programming-Language/events{/privacy}","received_events_url":"https://api.github.com/users/D-Programming-Language/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/D-Programming-Language/phobos","description":"The standard library of the D programming language","fork":false,"url":"https://api.github.com/repos/D-Programming-Language/phobos","forks_url":"https://api.github.com/repos/D-Programming-Language/phobos/forks","keys_url":"https://api.github.com/repos/D-Programming-Language/phobos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/D-Programming-Language/phobos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/D-Programming-Language/phobos/teams","hooks_url":"https://api.github.com/repos/D-Programming-Language/phobos/hooks","issue_events_url":"https://api.github.com/repos/D-Programming-Language/phobos/issues/events{/number}","events_url":"https://api.github.com/repos/D-Programming-Language/phobos/events","assignees_url":"https://api.github.com/repos/D-Programming-Language/phobos/assignees{/user}","branches_url":"https://api.github.com/repos/D-Programming-Language/phobos/branches{/branch}","tags_url":"https://api.github.com/repos/D-Programming-Language/phobos/tags","blobs_url":"https://api.github.com/repos/D-Programming-Language/phobos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/D-Programming-Language/phobos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/D-Programming-Language/phobos/git/refs{/sha}","trees_url":"https://api.github.com/repos/D-Programming-Language/phobos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/D-Programming-Language/phobos/statuses/{sha}","languages_url":"https://api.github.com/repos/D-Programming-Language/phobos/languages","stargazers_url":"https://api.github.com/repos/D-Programming-Language/phobos/stargazers","contributors_url":"https://api.github.com/repos/D-Programming-Language/phobos/contributors","subscribers_url":"https://api.github.com/repos/D-Programming-Language/phobos/subscribers","subscription_url":"https://api.github.com/repos/D-Programming-Language/phobos/subscription","commits_url":"https://api.github.com/repos/D-Programming-Language/phobos/commits{/sha}","git_commits_url":"https://api.github.com/repos/D-Programming-Language/phobos/git/commits{/sha}","comments_url":"https://api.github.com/repos/D-Programming-Language/phobos/comments{/number}","issue_comment_url":"https://api.github.com/repos/D-Programming-Language/phobos/issues/comments/{number}","contents_url":"https://api.github.com/repos/D-Programming-Language/phobos/contents/{+path}","compare_url":"https://api.github.com/repos/D-Programming-Language/phobos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/D-Programming-Language/phobos/merges","archive_url":"https://api.github.com/repos/D-Programming-Language/phobos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/D-Programming-Language/phobos/downloads","issues_url":"https://api.github.com/repos/D-Programming-Language/phobos/issues{/number}","pulls_url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls{/number}","milestones_url":"https://api.github.com/repos/D-Programming-Language/phobos/milestones{/number}","notifications_url":"https://api.github.com/repos/D-Programming-Language/phobos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/D-Programming-Language/phobos/labels{/name}","releases_url":"https://api.github.com/repos/D-Programming-Language/phobos/releases{/id}","created_at":"2011-01-15T07:00:06Z","updated_at":"2014-06-18T20:08:29Z","pushed_at":"2014-06-18T20:08:32Z","git_url":"git://github.com/D-Programming-Language/phobos.git","ssh_url":"git@github.com:D-Programming-Language/phobos.git","clone_url":"https://github.com/D-Programming-Language/phobos.git","svn_url":"https://github.com/D-Programming-Language/phobos","homepage":"dlang.org/phobos","size":51204,"stargazers_count":489,"watchers_count":489,"language":"D","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":325,"mirror_url":null,"open_issues_count":79,"forks":325,"open_issues":79,"watchers":489,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/2257"},"html":{"href":"https://github.com/D-Programming-Language/phobos/pull/2257"},"issue":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/issues/2257"},"comments":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/issues/2257/comments"},"review_comments":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/2257/comments"},"review_comment":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/2257/commits"},"statuses":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/statuses/978178595e4eada47fa362b88fc3b58a3550333a"}}}}