GitHub PullRequestReviewCommentEvent at 2014-11-25 05:58:18
Repository: dnschain
Actor: taoeffect
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/okTurtles/dnschain/pulls/comments/20844704","id":20844704,"diff_hunk":"@@ -50,11 +50,21 @@\n     \"winston\": \"^0.8.0\"\n   },\n   \"devDependencies\": {\n+    \"body-parser\": \"^1.9.2\",\n+    \"coffee-react\": \"^2.0.0\",\n     \"coffeelint\": \"^1.6.0\",\n+    \"express\": \"^4.10.2\",\n     \"grunt\": \"^0.4.5\",\n+    \"grunt-coffee-react\": \"git+https://github.com/vegetableman/grunt-coffee-react.git\",\n+    \"grunt-coffeeify\": \"^0.1.3\",\n     \"grunt-coffeelint\": \"0.0.13\",\n+    \"grunt-concurrent\": \"^1.0.0\",\n     \"grunt-contrib-watch\": \"^0.6.1\",\n-    \"matchdep\": \"~0.1.2\"\n+    \"grunt-nodemon\": \"^0.3.0\",\n+    \"ini\": \"^1.3.0\",\n+    \"matchdep\": \"~0.1.2\",\n+    \"mkdirp\": \"^0.5.0\",\n+    \"react\": \"^0.12.1\"","path":"package.json","position":19,"original_position":19,"commit_id":"776b52cfa343ea4fb04b2f4c94f5f5821193b0ca","original_commit_id":"776b52cfa343ea4fb04b2f4c94f5f5821193b0ca","user":{"login":"taoeffect","id":138706,"avatar_url":"https://avatars.githubusercontent.com/u/138706?v=3","gravatar_id":"","url":"https://api.github.com/users/taoeffect","html_url":"https://github.com/taoeffect","followers_url":"https://api.github.com/users/taoeffect/followers","following_url":"https://api.github.com/users/taoeffect/following{/other_user}","gists_url":"https://api.github.com/users/taoeffect/gists{/gist_id}","starred_url":"https://api.github.com/users/taoeffect/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taoeffect/subscriptions","organizations_url":"https://api.github.com/users/taoeffect/orgs","repos_url":"https://api.github.com/users/taoeffect/repos","events_url":"https://api.github.com/users/taoeffect/events{/privacy}","received_events_url":"https://api.github.com/users/taoeffect/received_events","type":"User","site_admin":false},"body":"A lot of these new dependencies belong in `dependencies`, not `devDependencies`. These include:\r\n\r\n- body-parser (I think)\r\n- express\r\n- react\r\n\r\nAnd maybe some others. The `devDependencies` are only for things that are needed when using grunt. Remember that DNSChain is run without grunt.","created_at":"2014-11-25T05:58:18Z","updated_at":"2014-11-25T05:58:18Z","html_url":"https://github.com/okTurtles/dnschain/pull/62#discussion_r20844704","pull_request_url":"https://api.github.com/repos/okTurtles/dnschain/pulls/62","_links":{"self":{"href":"https://api.github.com/repos/okTurtles/dnschain/pulls/comments/20844704"},"html":{"href":"https://github.com/okTurtles/dnschain/pull/62#discussion_r20844704"},"pull_request":{"href":"https://api.github.com/repos/okTurtles/dnschain/pulls/62"}}},"pull_request":{"url":"https://api.github.com/repos/okTurtles/dnschain/pulls/62","id":24899524,"html_url":"https://github.com/okTurtles/dnschain/pull/62","diff_url":"https://github.com/okTurtles/dnschain/pull/62.diff","patch_url":"https://github.com/okTurtles/dnschain/pull/62.patch","issue_url":"https://api.github.com/repos/okTurtles/dnschain/issues/62","number":62,"state":"open","locked":false,"title":"New: Added Admin page (fixes #30)","user":{"login":"vegetableman","id":1330851,"avatar_url":"https://avatars.githubusercontent.com/u/1330851?v=3","gravatar_id":"","url":"https://api.github.com/users/vegetableman","html_url":"https://github.com/vegetableman","followers_url":"https://api.github.com/users/vegetableman/followers","following_url":"https://api.github.com/users/vegetableman/following{/other_user}","gists_url":"https://api.github.com/users/vegetableman/gists{/gist_id}","starred_url":"https://api.github.com/users/vegetableman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vegetableman/subscriptions","organizations_url":"https://api.github.com/users/vegetableman/orgs","repos_url":"https://api.github.com/users/vegetableman/repos","events_url":"https://api.github.com/users/vegetableman/events{/privacy}","received_events_url":"https://api.github.com/users/vegetableman/received_events","type":"User","site_admin":false},"body":"Fixes #30\r\n\r\nFollowing are the changes made:\r\n\r\n* Supports save and reload of config.\r\n* Picks up the config with a higher priority as mentioned in the README.\r\n* Runs with ```grunt admin```\r\n* Uses react and coffeescript\r\n\r\nAny suggestions on how to go about on the below points?\r\n\r\n* Support of https ( Need certificates. Related to #58? )\r\n* Restart of other servers on save. (Should ```example.coffee``` be made a module?)\r\n* Graph ( depends on #10 )","created_at":"2014-11-23T09:22:27Z","updated_at":"2014-11-25T05:58:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fa48cde5bd57d4a867a7e49c00bd526e7c11b3d5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/okTurtles/dnschain/pulls/62/commits","review_comments_url":"https://api.github.com/repos/okTurtles/dnschain/pulls/62/comments","review_comment_url":"https://api.github.com/repos/okTurtles/dnschain/pulls/comments/{number}","comments_url":"https://api.github.com/repos/okTurtles/dnschain/issues/62/comments","statuses_url":"https://api.github.com/repos/okTurtles/dnschain/statuses/776b52cfa343ea4fb04b2f4c94f5f5821193b0ca","head":{"label":"vegetableman:admin","ref":"admin","sha":"776b52cfa343ea4fb04b2f4c94f5f5821193b0ca","user":{"login":"vegetableman","id":1330851,"avatar_url":"https://avatars.githubusercontent.com/u/1330851?v=3","gravatar_id":"","url":"https://api.github.com/users/vegetableman","html_url":"https://github.com/vegetableman","followers_url":"https://api.github.com/users/vegetableman/followers","following_url":"https://api.github.com/users/vegetableman/following{/other_user}","gists_url":"https://api.github.com/users/vegetableman/gists{/gist_id}","starred_url":"https://api.github.com/users/vegetableman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vegetableman/subscriptions","organizations_url":"https://api.github.com/users/vegetableman/orgs","repos_url":"https://api.github.com/users/vegetableman/repos","events_url":"https://api.github.com/users/vegetableman/events{/privacy}","received_events_url":"https://api.github.com/users/vegetableman/received_events","type":"User","site_admin":false},"repo":{"id":26853131,"name":"dnschain","full_name":"vegetableman/dnschain","owner":{"login":"vegetableman","id":1330851,"avatar_url":"https://avatars.githubusercontent.com/u/1330851?v=3","gravatar_id":"","url":"https://api.github.com/users/vegetableman","html_url":"https://github.com/vegetableman","followers_url":"https://api.github.com/users/vegetableman/followers","following_url":"https://api.github.com/users/vegetableman/following{/other_user}","gists_url":"https://api.github.com/users/vegetableman/gists{/gist_id}","starred_url":"https://api.github.com/users/vegetableman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vegetableman/subscriptions","organizations_url":"https://api.github.com/users/vegetableman/orgs","repos_url":"https://api.github.com/users/vegetableman/repos","events_url":"https://api.github.com/users/vegetableman/events{/privacy}","received_events_url":"https://api.github.com/users/vegetableman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vegetableman/dnschain","description":"A blockchain-based DNS + HTTP server that fixes HTTPS security, and more!","fork":true,"url":"https://api.github.com/repos/vegetableman/dnschain","forks_url":"https://api.github.com/repos/vegetableman/dnschain/forks","keys_url":"https://api.github.com/repos/vegetableman/dnschain/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vegetableman/dnschain/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vegetableman/dnschain/teams","hooks_url":"https://api.github.com/repos/vegetableman/dnschain/hooks","issue_events_url":"https://api.github.com/repos/vegetableman/dnschain/issues/events{/number}","events_url":"https://api.github.com/repos/vegetableman/dnschain/events","assignees_url":"https://api.github.com/repos/vegetableman/dnschain/assignees{/user}","branches_url":"https://api.github.com/repos/vegetableman/dnschain/branches{/branch}","tags_url":"https://api.github.com/repos/vegetableman/dnschain/tags","blobs_url":"https://api.github.com/repos/vegetableman/dnschain/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vegetableman/dnschain/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vegetableman/dnschain/git/refs{/sha}","trees_url":"https://api.github.com/repos/vegetableman/dnschain/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vegetableman/dnschain/statuses/{sha}","languages_url":"https://api.github.com/repos/vegetableman/dnschain/languages","stargazers_url":"https://api.github.com/repos/vegetableman/dnschain/stargazers","contributors_url":"https://api.github.com/repos/vegetableman/dnschain/contributors","subscribers_url":"https://api.github.com/repos/vegetableman/dnschain/subscribers","subscription_url":"https://api.github.com/repos/vegetableman/dnschain/subscription","commits_url":"https://api.github.com/repos/vegetableman/dnschain/commits{/sha}","git_commits_url":"https://api.github.com/repos/vegetableman/dnschain/git/commits{/sha}","comments_url":"https://api.github.com/repos/vegetableman/dnschain/comments{/number}","issue_comment_url":"https://api.github.com/repos/vegetableman/dnschain/issues/comments/{number}","contents_url":"https://api.github.com/repos/vegetableman/dnschain/contents/{+path}","compare_url":"https://api.github.com/repos/vegetableman/dnschain/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vegetableman/dnschain/merges","archive_url":"https://api.github.com/repos/vegetableman/dnschain/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vegetableman/dnschain/downloads","issues_url":"https://api.github.com/repos/vegetableman/dnschain/issues{/number}","pulls_url":"https://api.github.com/repos/vegetableman/dnschain/pulls{/number}","milestones_url":"https://api.github.com/repos/vegetableman/dnschain/milestones{/number}","notifications_url":"https://api.github.com/repos/vegetableman/dnschain/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vegetableman/dnschain/labels{/name}","releases_url":"https://api.github.com/repos/vegetableman/dnschain/releases{/id}","created_at":"2014-11-19T09:03:46Z","updated_at":"2014-11-19T09:03:47Z","pushed_at":"2014-11-23T09:35:22Z","git_url":"git://github.com/vegetableman/dnschain.git","ssh_url":"git@github.com:vegetableman/dnschain.git","clone_url":"https://github.com/vegetableman/dnschain.git","svn_url":"https://github.com/vegetableman/dnschain","homepage":"okturtles.com","size":278,"stargazers_count":0,"watchers_count":0,"language":"CoffeeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"okTurtles:master","ref":"master","sha":"7707dd39fa6d8f0beb3161db48c2b26d084376c9","user":{"login":"okTurtles","id":6006150,"avatar_url":"https://avatars.githubusercontent.com/u/6006150?v=3","gravatar_id":"","url":"https://api.github.com/users/okTurtles","html_url":"https://github.com/okTurtles","followers_url":"https://api.github.com/users/okTurtles/followers","following_url":"https://api.github.com/users/okTurtles/following{/other_user}","gists_url":"https://api.github.com/users/okTurtles/gists{/gist_id}","starred_url":"https://api.github.com/users/okTurtles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/okTurtles/subscriptions","organizations_url":"https://api.github.com/users/okTurtles/orgs","repos_url":"https://api.github.com/users/okTurtles/repos","events_url":"https://api.github.com/users/okTurtles/events{/privacy}","received_events_url":"https://api.github.com/users/okTurtles/received_events","type":"Organization","site_admin":false},"repo":{"id":16243703,"name":"dnschain","full_name":"okTurtles/dnschain","owner":{"login":"okTurtles","id":6006150,"avatar_url":"https://avatars.githubusercontent.com/u/6006150?v=3","gravatar_id":"","url":"https://api.github.com/users/okTurtles","html_url":"https://github.com/okTurtles","followers_url":"https://api.github.com/users/okTurtles/followers","following_url":"https://api.github.com/users/okTurtles/following{/other_user}","gists_url":"https://api.github.com/users/okTurtles/gists{/gist_id}","starred_url":"https://api.github.com/users/okTurtles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/okTurtles/subscriptions","organizations_url":"https://api.github.com/users/okTurtles/orgs","repos_url":"https://api.github.com/users/okTurtles/repos","events_url":"https://api.github.com/users/okTurtles/events{/privacy}","received_events_url":"https://api.github.com/users/okTurtles/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/okTurtles/dnschain","description":"A blockchain-based DNS + HTTP server that fixes HTTPS security, and more!","fork":false,"url":"https://api.github.com/repos/okTurtles/dnschain","forks_url":"https://api.github.com/repos/okTurtles/dnschain/forks","keys_url":"https://api.github.com/repos/okTurtles/dnschain/keys{/key_id}","collaborators_url":"https://api.github.com/repos/okTurtles/dnschain/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/okTurtles/dnschain/teams","hooks_url":"https://api.github.com/repos/okTurtles/dnschain/hooks","issue_events_url":"https://api.github.com/repos/okTurtles/dnschain/issues/events{/number}","events_url":"https://api.github.com/repos/okTurtles/dnschain/events","assignees_url":"https://api.github.com/repos/okTurtles/dnschain/assignees{/user}","branches_url":"https://api.github.com/repos/okTurtles/dnschain/branches{/branch}","tags_url":"https://api.github.com/repos/okTurtles/dnschain/tags","blobs_url":"https://api.github.com/repos/okTurtles/dnschain/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/okTurtles/dnschain/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/okTurtles/dnschain/git/refs{/sha}","trees_url":"https://api.github.com/repos/okTurtles/dnschain/git/trees{/sha}","statuses_url":"https://api.github.com/repos/okTurtles/dnschain/statuses/{sha}","languages_url":"https://api.github.com/repos/okTurtles/dnschain/languages","stargazers_url":"https://api.github.com/repos/okTurtles/dnschain/stargazers","contributors_url":"https://api.github.com/repos/okTurtles/dnschain/contributors","subscribers_url":"https://api.github.com/repos/okTurtles/dnschain/subscribers","subscription_url":"https://api.github.com/repos/okTurtles/dnschain/subscription","commits_url":"https://api.github.com/repos/okTurtles/dnschain/commits{/sha}","git_commits_url":"https://api.github.com/repos/okTurtles/dnschain/git/commits{/sha}","comments_url":"https://api.github.com/repos/okTurtles/dnschain/comments{/number}","issue_comment_url":"https://api.github.com/repos/okTurtles/dnschain/issues/comments/{number}","contents_url":"https://api.github.com/repos/okTurtles/dnschain/contents/{+path}","compare_url":"https://api.github.com/repos/okTurtles/dnschain/compare/{base}...{head}","merges_url":"https://api.github.com/repos/okTurtles/dnschain/merges","archive_url":"https://api.github.com/repos/okTurtles/dnschain/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/okTurtles/dnschain/downloads","issues_url":"https://api.github.com/repos/okTurtles/dnschain/issues{/number}","pulls_url":"https://api.github.com/repos/okTurtles/dnschain/pulls{/number}","milestones_url":"https://api.github.com/repos/okTurtles/dnschain/milestones{/number}","notifications_url":"https://api.github.com/repos/okTurtles/dnschain/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/okTurtles/dnschain/labels{/name}","releases_url":"https://api.github.com/repos/okTurtles/dnschain/releases{/id}","created_at":"2014-01-26T00:53:46Z","updated_at":"2014-11-22T06:00:20Z","pushed_at":"2014-11-22T06:00:20Z","git_url":"git://github.com/okTurtles/dnschain.git","ssh_url":"git@github.com:okTurtles/dnschain.git","clone_url":"https://github.com/okTurtles/dnschain.git","svn_url":"https://github.com/okTurtles/dnschain","homepage":"okturtles.com","size":1498,"stargazers_count":532,"watchers_count":532,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":37,"mirror_url":null,"open_issues_count":43,"forks":37,"open_issues":43,"watchers":532,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/okTurtles/dnschain/pulls/62"},"html":{"href":"https://github.com/okTurtles/dnschain/pull/62"},"issue":{"href":"https://api.github.com/repos/okTurtles/dnschain/issues/62"},"comments":{"href":"https://api.github.com/repos/okTurtles/dnschain/issues/62/comments"},"review_comments":{"href":"https://api.github.com/repos/okTurtles/dnschain/pulls/62/comments"},"review_comment":{"href":"https://api.github.com/repos/okTurtles/dnschain/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/okTurtles/dnschain/pulls/62/commits"},"statuses":{"href":"https://api.github.com/repos/okTurtles/dnschain/statuses/776b52cfa343ea4fb04b2f4c94f5f5821193b0ca"}}}}