GitHub PullRequestReviewCommentEvent at 2014-07-09 15:30:29
Repository: RIOT
Actor: Kijewski
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments/14716225","id":14716225,"diff_hunk":"@@ -0,0 +1,186 @@\n+/**\n+ * Copyright (C) 2014 Freie Universität Berlin\n+ *\n+ * This file is subject to the terms and conditions of the GNU Lesser General\n+ * Public License v2.1. See the file LICENSE in the top level directory for more\n+ * details.\n+ *\n+ * @file   at86rf231_driver.c\n+ * @author Thomas Eichinger <thomas.eichinger@fu-berlin.de>\n+ */\n+\n+#include <stdio.h>\n+#include <stddef.h>\n+\n+#include \"cpu.h\"\n+#include \"sched.h\"\n+#include \"vtimer.h\"\n+\n+#include \"arch/thread_arch.h\"\n+#include \"periph/gpio.h\"\n+#include \"periph_conf.h\"\n+#include \"spi.h\"\n+#include \"board.h\"\n+\n+#include \"at86rf231.h\"\n+#include \"at86rf231_spi.h\"\n+#include \"at86rf231_spi1.h\"\n+\n+/*\n+SPI1\n+  SCLK : PA5\n+  MISO : PA6\n+  MOSI : PA7\n+  CS : PA4\n+\n+GPIO\n+  IRQ0 : PC4 : Frame buff empty indicator\n+  DIG2 : ? : RX Frame Time stamping XXX : NOT USED\n+  Reset : PC1 : active low, enable chip\n+  SLEEP : PA2 : control sleep, tx & rx state\n+*/\n+\n+inline static void RESET_CLR(void)","path":"boards/iot-lab_M3/drivers/at86rf231_driver.c","position":43,"original_position":43,"commit_id":"320c8fbdc1bfef7a8bdc1444336f0ef3ed71b01f","original_commit_id":"320c8fbdc1bfef7a8bdc1444336f0ef3ed71b01f","user":{"login":"Kijewski","id":136776,"avatar_url":"https://avatars.githubusercontent.com/u/136776?","gravatar_id":"b26d2f162636903c1578cf3c45162845","url":"https://api.github.com/users/Kijewski","html_url":"https://github.com/Kijewski","followers_url":"https://api.github.com/users/Kijewski/followers","following_url":"https://api.github.com/users/Kijewski/following{/other_user}","gists_url":"https://api.github.com/users/Kijewski/gists{/gist_id}","starred_url":"https://api.github.com/users/Kijewski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kijewski/subscriptions","organizations_url":"https://api.github.com/users/Kijewski/orgs","repos_url":"https://api.github.com/users/Kijewski/repos","events_url":"https://api.github.com/users/Kijewski/events{/privacy}","received_events_url":"https://api.github.com/users/Kijewski/received_events","type":"User","site_admin":false},"body":"I have never read \"inline static\" in this order. :)","created_at":"2014-07-09T15:30:29Z","updated_at":"2014-07-09T15:30:29Z","html_url":"https://github.com/RIOT-OS/RIOT/pull/1363#discussion_r14716225","pull_request_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/1363","_links":{"self":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments/14716225"},"html":{"href":"https://github.com/RIOT-OS/RIOT/pull/1363#discussion_r14716225"},"pull_request":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/1363"}}},"pull_request":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/1363","id":17932700,"html_url":"https://github.com/RIOT-OS/RIOT/pull/1363","diff_url":"https://github.com/RIOT-OS/RIOT/pull/1363.diff","patch_url":"https://github.com/RIOT-OS/RIOT/pull/1363.patch","issue_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/1363","number":1363,"state":"open","title":"board: cpu: initial import of iot-lab_M3","user":{"login":"thomaseichinger","id":56618,"avatar_url":"https://avatars.githubusercontent.com/u/56618?","gravatar_id":"98c4a889e8827bb64c9e64c3f9bae890","url":"https://api.github.com/users/thomaseichinger","html_url":"https://github.com/thomaseichinger","followers_url":"https://api.github.com/users/thomaseichinger/followers","following_url":"https://api.github.com/users/thomaseichinger/following{/other_user}","gists_url":"https://api.github.com/users/thomaseichinger/gists{/gist_id}","starred_url":"https://api.github.com/users/thomaseichinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomaseichinger/subscriptions","organizations_url":"https://api.github.com/users/thomaseichinger/orgs","repos_url":"https://api.github.com/users/thomaseichinger/repos","events_url":"https://api.github.com/users/thomaseichinger/events{/privacy}","received_events_url":"https://api.github.com/users/thomaseichinger/received_events","type":"User","site_admin":false},"body":"This is an initial port for the iot-lab_M3 board and stm32f1 cpu.\r\nThis is a rewrite so it is implemented without the use of ST's peripheral library.\r\n\r\nDone:\r\n- [x] context switching\r\n- [x] timers\r\n- [x] gpio\r\n- [x] uart\r\n- [x] stdio\r\n- [x] spi\r\n- [x] at86rf231","created_at":"2014-07-03T08:59:30Z","updated_at":"2014-07-09T15:30:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0d81386ee78295ffe20650dd4fffd9381a769ae0","assignee":{"login":"haukepetersen","id":620834,"avatar_url":"https://avatars.githubusercontent.com/u/620834?","gravatar_id":"623b9dd1a8ebfa7436e4198b56255be0","url":"https://api.github.com/users/haukepetersen","html_url":"https://github.com/haukepetersen","followers_url":"https://api.github.com/users/haukepetersen/followers","following_url":"https://api.github.com/users/haukepetersen/following{/other_user}","gists_url":"https://api.github.com/users/haukepetersen/gists{/gist_id}","starred_url":"https://api.github.com/users/haukepetersen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haukepetersen/subscriptions","organizations_url":"https://api.github.com/users/haukepetersen/orgs","repos_url":"https://api.github.com/users/haukepetersen/repos","events_url":"https://api.github.com/users/haukepetersen/events{/privacy}","received_events_url":"https://api.github.com/users/haukepetersen/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/1363/commits","review_comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/1363/comments","review_comment_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments/{number}","comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/1363/comments","statuses_url":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/320c8fbdc1bfef7a8bdc1444336f0ef3ed71b01f","head":{"label":"thomaseichinger:thirdparty_boards_import","ref":"thirdparty_boards_import","sha":"320c8fbdc1bfef7a8bdc1444336f0ef3ed71b01f","user":{"login":"thomaseichinger","id":56618,"avatar_url":"https://avatars.githubusercontent.com/u/56618?","gravatar_id":"98c4a889e8827bb64c9e64c3f9bae890","url":"https://api.github.com/users/thomaseichinger","html_url":"https://github.com/thomaseichinger","followers_url":"https://api.github.com/users/thomaseichinger/followers","following_url":"https://api.github.com/users/thomaseichinger/following{/other_user}","gists_url":"https://api.github.com/users/thomaseichinger/gists{/gist_id}","starred_url":"https://api.github.com/users/thomaseichinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomaseichinger/subscriptions","organizations_url":"https://api.github.com/users/thomaseichinger/orgs","repos_url":"https://api.github.com/users/thomaseichinger/repos","events_url":"https://api.github.com/users/thomaseichinger/events{/privacy}","received_events_url":"https://api.github.com/users/thomaseichinger/received_events","type":"User","site_admin":false},"repo":{"id":11602439,"name":"RIOT","full_name":"thomaseichinger/RIOT","owner":{"login":"thomaseichinger","id":56618,"avatar_url":"https://avatars.githubusercontent.com/u/56618?","gravatar_id":"98c4a889e8827bb64c9e64c3f9bae890","url":"https://api.github.com/users/thomaseichinger","html_url":"https://github.com/thomaseichinger","followers_url":"https://api.github.com/users/thomaseichinger/followers","following_url":"https://api.github.com/users/thomaseichinger/following{/other_user}","gists_url":"https://api.github.com/users/thomaseichinger/gists{/gist_id}","starred_url":"https://api.github.com/users/thomaseichinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomaseichinger/subscriptions","organizations_url":"https://api.github.com/users/thomaseichinger/orgs","repos_url":"https://api.github.com/users/thomaseichinger/repos","events_url":"https://api.github.com/users/thomaseichinger/events{/privacy}","received_events_url":"https://api.github.com/users/thomaseichinger/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/thomaseichinger/RIOT","description":"RIOT OS -  The revolutionary IoT OS","fork":true,"url":"https://api.github.com/repos/thomaseichinger/RIOT","forks_url":"https://api.github.com/repos/thomaseichinger/RIOT/forks","keys_url":"https://api.github.com/repos/thomaseichinger/RIOT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thomaseichinger/RIOT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thomaseichinger/RIOT/teams","hooks_url":"https://api.github.com/repos/thomaseichinger/RIOT/hooks","issue_events_url":"https://api.github.com/repos/thomaseichinger/RIOT/issues/events{/number}","events_url":"https://api.github.com/repos/thomaseichinger/RIOT/events","assignees_url":"https://api.github.com/repos/thomaseichinger/RIOT/assignees{/user}","branches_url":"https://api.github.com/repos/thomaseichinger/RIOT/branches{/branch}","tags_url":"https://api.github.com/repos/thomaseichinger/RIOT/tags","blobs_url":"https://api.github.com/repos/thomaseichinger/RIOT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thomaseichinger/RIOT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thomaseichinger/RIOT/git/refs{/sha}","trees_url":"https://api.github.com/repos/thomaseichinger/RIOT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thomaseichinger/RIOT/statuses/{sha}","languages_url":"https://api.github.com/repos/thomaseichinger/RIOT/languages","stargazers_url":"https://api.github.com/repos/thomaseichinger/RIOT/stargazers","contributors_url":"https://api.github.com/repos/thomaseichinger/RIOT/contributors","subscribers_url":"https://api.github.com/repos/thomaseichinger/RIOT/subscribers","subscription_url":"https://api.github.com/repos/thomaseichinger/RIOT/subscription","commits_url":"https://api.github.com/repos/thomaseichinger/RIOT/commits{/sha}","git_commits_url":"https://api.github.com/repos/thomaseichinger/RIOT/git/commits{/sha}","comments_url":"https://api.github.com/repos/thomaseichinger/RIOT/comments{/number}","issue_comment_url":"https://api.github.com/repos/thomaseichinger/RIOT/issues/comments/{number}","contents_url":"https://api.github.com/repos/thomaseichinger/RIOT/contents/{+path}","compare_url":"https://api.github.com/repos/thomaseichinger/RIOT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thomaseichinger/RIOT/merges","archive_url":"https://api.github.com/repos/thomaseichinger/RIOT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thomaseichinger/RIOT/downloads","issues_url":"https://api.github.com/repos/thomaseichinger/RIOT/issues{/number}","pulls_url":"https://api.github.com/repos/thomaseichinger/RIOT/pulls{/number}","milestones_url":"https://api.github.com/repos/thomaseichinger/RIOT/milestones{/number}","notifications_url":"https://api.github.com/repos/thomaseichinger/RIOT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thomaseichinger/RIOT/labels{/name}","releases_url":"https://api.github.com/repos/thomaseichinger/RIOT/releases{/id}","created_at":"2013-07-23T07:33:28Z","updated_at":"2014-06-23T08:50:01Z","pushed_at":"2014-07-09T14:42:07Z","git_url":"git://github.com/thomaseichinger/RIOT.git","ssh_url":"git@github.com:thomaseichinger/RIOT.git","clone_url":"https://github.com/thomaseichinger/RIOT.git","svn_url":"https://github.com/thomaseichinger/RIOT","homepage":"https://github.com/RIOT-OS/RIOT/wiki","size":16607,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"RIOT-OS:master","ref":"master","sha":"17f2eb80b86c5120741f1cb684eb1c3cf2061a65","user":{"login":"RIOT-OS","id":3079480,"avatar_url":"https://avatars.githubusercontent.com/u/3079480?","gravatar_id":"18bbde293bccb57c7e43416f5c9ff243","url":"https://api.github.com/users/RIOT-OS","html_url":"https://github.com/RIOT-OS","followers_url":"https://api.github.com/users/RIOT-OS/followers","following_url":"https://api.github.com/users/RIOT-OS/following{/other_user}","gists_url":"https://api.github.com/users/RIOT-OS/gists{/gist_id}","starred_url":"https://api.github.com/users/RIOT-OS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RIOT-OS/subscriptions","organizations_url":"https://api.github.com/users/RIOT-OS/orgs","repos_url":"https://api.github.com/users/RIOT-OS/repos","events_url":"https://api.github.com/users/RIOT-OS/events{/privacy}","received_events_url":"https://api.github.com/users/RIOT-OS/received_events","type":"Organization","site_admin":false},"repo":{"id":7370241,"name":"RIOT","full_name":"RIOT-OS/RIOT","owner":{"login":"RIOT-OS","id":3079480,"avatar_url":"https://avatars.githubusercontent.com/u/3079480?","gravatar_id":"18bbde293bccb57c7e43416f5c9ff243","url":"https://api.github.com/users/RIOT-OS","html_url":"https://github.com/RIOT-OS","followers_url":"https://api.github.com/users/RIOT-OS/followers","following_url":"https://api.github.com/users/RIOT-OS/following{/other_user}","gists_url":"https://api.github.com/users/RIOT-OS/gists{/gist_id}","starred_url":"https://api.github.com/users/RIOT-OS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RIOT-OS/subscriptions","organizations_url":"https://api.github.com/users/RIOT-OS/orgs","repos_url":"https://api.github.com/users/RIOT-OS/repos","events_url":"https://api.github.com/users/RIOT-OS/events{/privacy}","received_events_url":"https://api.github.com/users/RIOT-OS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RIOT-OS/RIOT","description":"RIOT -  The friendly OS for IoT","fork":false,"url":"https://api.github.com/repos/RIOT-OS/RIOT","forks_url":"https://api.github.com/repos/RIOT-OS/RIOT/forks","keys_url":"https://api.github.com/repos/RIOT-OS/RIOT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RIOT-OS/RIOT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RIOT-OS/RIOT/teams","hooks_url":"https://api.github.com/repos/RIOT-OS/RIOT/hooks","issue_events_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/events{/number}","events_url":"https://api.github.com/repos/RIOT-OS/RIOT/events","assignees_url":"https://api.github.com/repos/RIOT-OS/RIOT/assignees{/user}","branches_url":"https://api.github.com/repos/RIOT-OS/RIOT/branches{/branch}","tags_url":"https://api.github.com/repos/RIOT-OS/RIOT/tags","blobs_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/refs{/sha}","trees_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/{sha}","languages_url":"https://api.github.com/repos/RIOT-OS/RIOT/languages","stargazers_url":"https://api.github.com/repos/RIOT-OS/RIOT/stargazers","contributors_url":"https://api.github.com/repos/RIOT-OS/RIOT/contributors","subscribers_url":"https://api.github.com/repos/RIOT-OS/RIOT/subscribers","subscription_url":"https://api.github.com/repos/RIOT-OS/RIOT/subscription","commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/commits{/sha}","git_commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/commits{/sha}","comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/comments{/number}","issue_comment_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/comments/{number}","contents_url":"https://api.github.com/repos/RIOT-OS/RIOT/contents/{+path}","compare_url":"https://api.github.com/repos/RIOT-OS/RIOT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RIOT-OS/RIOT/merges","archive_url":"https://api.github.com/repos/RIOT-OS/RIOT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RIOT-OS/RIOT/downloads","issues_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues{/number}","pulls_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls{/number}","milestones_url":"https://api.github.com/repos/RIOT-OS/RIOT/milestones{/number}","notifications_url":"https://api.github.com/repos/RIOT-OS/RIOT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RIOT-OS/RIOT/labels{/name}","releases_url":"https://api.github.com/repos/RIOT-OS/RIOT/releases{/id}","created_at":"2012-12-29T20:38:40Z","updated_at":"2014-07-08T07:10:48Z","pushed_at":"2014-07-09T14:39:10Z","git_url":"git://github.com/RIOT-OS/RIOT.git","ssh_url":"git@github.com:RIOT-OS/RIOT.git","clone_url":"https://github.com/RIOT-OS/RIOT.git","svn_url":"https://github.com/RIOT-OS/RIOT","homepage":"https://github.com/RIOT-OS/RIOT/wiki","size":59208,"stargazers_count":122,"watchers_count":122,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":88,"mirror_url":null,"open_issues_count":189,"forks":88,"open_issues":189,"watchers":122,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/1363"},"html":{"href":"https://github.com/RIOT-OS/RIOT/pull/1363"},"issue":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/issues/1363"},"comments":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/issues/1363/comments"},"review_comments":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/1363/comments"},"review_comment":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/1363/commits"},"statuses":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/320c8fbdc1bfef7a8bdc1444336f0ef3ed71b01f"}}}}