GitHub PullRequestEvent at 2014-10-28 03:16:22
Repository: expense_manager
Actor: bluerogue251
Payload: {"action":"opened","number":15,"pull_request":{"url":"https://api.github.com/repos/bluerogue251/expense_manager/pulls/15","id":23432112,"html_url":"https://github.com/bluerogue251/expense_manager/pull/15","diff_url":"https://github.com/bluerogue251/expense_manager/pull/15.diff","patch_url":"https://github.com/bluerogue251/expense_manager/pull/15.patch","issue_url":"https://api.github.com/repos/bluerogue251/expense_manager/issues/15","number":15,"state":"open","locked":false,"title":"Failing datatables count spec","user":{"login":"bluerogue251","id":5103414,"avatar_url":"https://avatars.githubusercontent.com/u/5103414?v=2","gravatar_id":"","url":"https://api.github.com/users/bluerogue251","html_url":"https://github.com/bluerogue251","followers_url":"https://api.github.com/users/bluerogue251/followers","following_url":"https://api.github.com/users/bluerogue251/following{/other_user}","gists_url":"https://api.github.com/users/bluerogue251/gists{/gist_id}","starred_url":"https://api.github.com/users/bluerogue251/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bluerogue251/subscriptions","organizations_url":"https://api.github.com/users/bluerogue251/orgs","repos_url":"https://api.github.com/users/bluerogue251/repos","events_url":"https://api.github.com/users/bluerogue251/events{/privacy}","received_events_url":"https://api.github.com/users/bluerogue251/received_events","type":"User","site_admin":false},"body":"Fix total record count\r\n\r\nBefore, the total record count and the matching search record count\r\nwould wrongly return the same number.\r\n\r\nNow, the total record count is correct again.\r\n\r\nThis was done by FIRST getting and saving the total record count,\r\nand only then allowing more conditions to be added on the query.\r\n\r\nSince the total record count must be gotten first, I've put it right\r\nin the Datatable initialize method, before anything else happens.\r\n\r\nIt's not good to have logic like this is an initializer, so If you\r\ncan find a better way to do this and avoid the logic in the\r\ninitializer, please do!\r\n","created_at":"2014-10-28T03:16:22Z","updated_at":"2014-10-28T03:16:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bluerogue251/expense_manager/pulls/15/commits","review_comments_url":"https://api.github.com/repos/bluerogue251/expense_manager/pulls/15/comments","review_comment_url":"https://api.github.com/repos/bluerogue251/expense_manager/pulls/comments/{number}","comments_url":"https://api.github.com/repos/bluerogue251/expense_manager/issues/15/comments","statuses_url":"https://api.github.com/repos/bluerogue251/expense_manager/statuses/0bb39c463cf1fd3c3b8ec84d4960acc715a6f433","head":{"label":"bluerogue251:failing_datatables_count_spec","ref":"failing_datatables_count_spec","sha":"0bb39c463cf1fd3c3b8ec84d4960acc715a6f433","user":{"login":"bluerogue251","id":5103414,"avatar_url":"https://avatars.githubusercontent.com/u/5103414?v=2","gravatar_id":"","url":"https://api.github.com/users/bluerogue251","html_url":"https://github.com/bluerogue251","followers_url":"https://api.github.com/users/bluerogue251/followers","following_url":"https://api.github.com/users/bluerogue251/following{/other_user}","gists_url":"https://api.github.com/users/bluerogue251/gists{/gist_id}","starred_url":"https://api.github.com/users/bluerogue251/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bluerogue251/subscriptions","organizations_url":"https://api.github.com/users/bluerogue251/orgs","repos_url":"https://api.github.com/users/bluerogue251/repos","events_url":"https://api.github.com/users/bluerogue251/events{/privacy}","received_events_url":"https://api.github.com/users/bluerogue251/received_events","type":"User","site_admin":false},"repo":{"id":22558053,"name":"expense_manager","full_name":"bluerogue251/expense_manager","owner":{"login":"bluerogue251","id":5103414,"avatar_url":"https://avatars.githubusercontent.com/u/5103414?v=2","gravatar_id":"","url":"https://api.github.com/users/bluerogue251","html_url":"https://github.com/bluerogue251","followers_url":"https://api.github.com/users/bluerogue251/followers","following_url":"https://api.github.com/users/bluerogue251/following{/other_user}","gists_url":"https://api.github.com/users/bluerogue251/gists{/gist_id}","starred_url":"https://api.github.com/users/bluerogue251/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bluerogue251/subscriptions","organizations_url":"https://api.github.com/users/bluerogue251/orgs","repos_url":"https://api.github.com/users/bluerogue251/repos","events_url":"https://api.github.com/users/bluerogue251/events{/privacy}","received_events_url":"https://api.github.com/users/bluerogue251/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bluerogue251/expense_manager","description":"A thoughtbot-style Rails application for managing company expenses","fork":false,"url":"https://api.github.com/repos/bluerogue251/expense_manager","forks_url":"https://api.github.com/repos/bluerogue251/expense_manager/forks","keys_url":"https://api.github.com/repos/bluerogue251/expense_manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bluerogue251/expense_manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bluerogue251/expense_manager/teams","hooks_url":"https://api.github.com/repos/bluerogue251/expense_manager/hooks","issue_events_url":"https://api.github.com/repos/bluerogue251/expense_manager/issues/events{/number}","events_url":"https://api.github.com/repos/bluerogue251/expense_manager/events","assignees_url":"https://api.github.com/repos/bluerogue251/expense_manager/assignees{/user}","branches_url":"https://api.github.com/repos/bluerogue251/expense_manager/branches{/branch}","tags_url":"https://api.github.com/repos/bluerogue251/expense_manager/tags","blobs_url":"https://api.github.com/repos/bluerogue251/expense_manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bluerogue251/expense_manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bluerogue251/expense_manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/bluerogue251/expense_manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bluerogue251/expense_manager/statuses/{sha}","languages_url":"https://api.github.com/repos/bluerogue251/expense_manager/languages","stargazers_url":"https://api.github.com/repos/bluerogue251/expense_manager/stargazers","contributors_url":"https://api.github.com/repos/bluerogue251/expense_manager/contributors","subscribers_url":"https://api.github.com/repos/bluerogue251/expense_manager/subscribers","subscription_url":"https://api.github.com/repos/bluerogue251/expense_manager/subscription","commits_url":"https://api.github.com/repos/bluerogue251/expense_manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/bluerogue251/expense_manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/bluerogue251/expense_manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/bluerogue251/expense_manager/issues/comments/{number}","contents_url":"https://api.github.com/repos/bluerogue251/expense_manager/contents/{+path}","compare_url":"https://api.github.com/repos/bluerogue251/expense_manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bluerogue251/expense_manager/merges","archive_url":"https://api.github.com/repos/bluerogue251/expense_manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bluerogue251/expense_manager/downloads","issues_url":"https://api.github.com/repos/bluerogue251/expense_manager/issues{/number}","pulls_url":"https://api.github.com/repos/bluerogue251/expense_manager/pulls{/number}","milestones_url":"https://api.github.com/repos/bluerogue251/expense_manager/milestones{/number}","notifications_url":"https://api.github.com/repos/bluerogue251/expense_manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bluerogue251/expense_manager/labels{/name}","releases_url":"https://api.github.com/repos/bluerogue251/expense_manager/releases{/id}","created_at":"2014-08-02T21:43:24Z","updated_at":"2014-09-02T19:26:14Z","pushed_at":"2014-10-28T03:14:46Z","git_url":"git://github.com/bluerogue251/expense_manager.git","ssh_url":"git@github.com:bluerogue251/expense_manager.git","clone_url":"https://github.com/bluerogue251/expense_manager.git","svn_url":"https://github.com/bluerogue251/expense_manager","homepage":null,"size":1052,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"bluerogue251:master","ref":"master","sha":"e8883e707098f91e82949a532a424378df4e626a","user":{"login":"bluerogue251","id":5103414,"avatar_url":"https://avatars.githubusercontent.com/u/5103414?v=2","gravatar_id":"","url":"https://api.github.com/users/bluerogue251","html_url":"https://github.com/bluerogue251","followers_url":"https://api.github.com/users/bluerogue251/followers","following_url":"https://api.github.com/users/bluerogue251/following{/other_user}","gists_url":"https://api.github.com/users/bluerogue251/gists{/gist_id}","starred_url":"https://api.github.com/users/bluerogue251/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bluerogue251/subscriptions","organizations_url":"https://api.github.com/users/bluerogue251/orgs","repos_url":"https://api.github.com/users/bluerogue251/repos","events_url":"https://api.github.com/users/bluerogue251/events{/privacy}","received_events_url":"https://api.github.com/users/bluerogue251/received_events","type":"User","site_admin":false},"repo":{"id":22558053,"name":"expense_manager","full_name":"bluerogue251/expense_manager","owner":{"login":"bluerogue251","id":5103414,"avatar_url":"https://avatars.githubusercontent.com/u/5103414?v=2","gravatar_id":"","url":"https://api.github.com/users/bluerogue251","html_url":"https://github.com/bluerogue251","followers_url":"https://api.github.com/users/bluerogue251/followers","following_url":"https://api.github.com/users/bluerogue251/following{/other_user}","gists_url":"https://api.github.com/users/bluerogue251/gists{/gist_id}","starred_url":"https://api.github.com/users/bluerogue251/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bluerogue251/subscriptions","organizations_url":"https://api.github.com/users/bluerogue251/orgs","repos_url":"https://api.github.com/users/bluerogue251/repos","events_url":"https://api.github.com/users/bluerogue251/events{/privacy}","received_events_url":"https://api.github.com/users/bluerogue251/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bluerogue251/expense_manager","description":"A thoughtbot-style Rails application for managing company expenses","fork":false,"url":"https://api.github.com/repos/bluerogue251/expense_manager","forks_url":"https://api.github.com/repos/bluerogue251/expense_manager/forks","keys_url":"https://api.github.com/repos/bluerogue251/expense_manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bluerogue251/expense_manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bluerogue251/expense_manager/teams","hooks_url":"https://api.github.com/repos/bluerogue251/expense_manager/hooks","issue_events_url":"https://api.github.com/repos/bluerogue251/expense_manager/issues/events{/number}","events_url":"https://api.github.com/repos/bluerogue251/expense_manager/events","assignees_url":"https://api.github.com/repos/bluerogue251/expense_manager/assignees{/user}","branches_url":"https://api.github.com/repos/bluerogue251/expense_manager/branches{/branch}","tags_url":"https://api.github.com/repos/bluerogue251/expense_manager/tags","blobs_url":"https://api.github.com/repos/bluerogue251/expense_manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bluerogue251/expense_manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bluerogue251/expense_manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/bluerogue251/expense_manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bluerogue251/expense_manager/statuses/{sha}","languages_url":"https://api.github.com/repos/bluerogue251/expense_manager/languages","stargazers_url":"https://api.github.com/repos/bluerogue251/expense_manager/stargazers","contributors_url":"https://api.github.com/repos/bluerogue251/expense_manager/contributors","subscribers_url":"https://api.github.com/repos/bluerogue251/expense_manager/subscribers","subscription_url":"https://api.github.com/repos/bluerogue251/expense_manager/subscription","commits_url":"https://api.github.com/repos/bluerogue251/expense_manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/bluerogue251/expense_manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/bluerogue251/expense_manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/bluerogue251/expense_manager/issues/comments/{number}","contents_url":"https://api.github.com/repos/bluerogue251/expense_manager/contents/{+path}","compare_url":"https://api.github.com/repos/bluerogue251/expense_manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bluerogue251/expense_manager/merges","archive_url":"https://api.github.com/repos/bluerogue251/expense_manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bluerogue251/expense_manager/downloads","issues_url":"https://api.github.com/repos/bluerogue251/expense_manager/issues{/number}","pulls_url":"https://api.github.com/repos/bluerogue251/expense_manager/pulls{/number}","milestones_url":"https://api.github.com/repos/bluerogue251/expense_manager/milestones{/number}","notifications_url":"https://api.github.com/repos/bluerogue251/expense_manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bluerogue251/expense_manager/labels{/name}","releases_url":"https://api.github.com/repos/bluerogue251/expense_manager/releases{/id}","created_at":"2014-08-02T21:43:24Z","updated_at":"2014-09-02T19:26:14Z","pushed_at":"2014-10-28T03:14:46Z","git_url":"git://github.com/bluerogue251/expense_manager.git","ssh_url":"git@github.com:bluerogue251/expense_manager.git","clone_url":"https://github.com/bluerogue251/expense_manager.git","svn_url":"https://github.com/bluerogue251/expense_manager","homepage":null,"size":1052,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bluerogue251/expense_manager/pulls/15"},"html":{"href":"https://github.com/bluerogue251/expense_manager/pull/15"},"issue":{"href":"https://api.github.com/repos/bluerogue251/expense_manager/issues/15"},"comments":{"href":"https://api.github.com/repos/bluerogue251/expense_manager/issues/15/comments"},"review_comments":{"href":"https://api.github.com/repos/bluerogue251/expense_manager/pulls/15/comments"},"review_comment":{"href":"https://api.github.com/repos/bluerogue251/expense_manager/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/bluerogue251/expense_manager/pulls/15/commits"},"statuses":{"href":"https://api.github.com/repos/bluerogue251/expense_manager/statuses/0bb39c463cf1fd3c3b8ec84d4960acc715a6f433"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":22,"deletions":7,"changed_files":2}}