GitHub PushEvent at 2014-01-14 15:08:01
Repository: corosync
Actor: jfriesse
Payload: {"shas":[["5046de387b5546871db42b7ceb46a24f23723dd4","d965d13ffc237c7c0019229a1f0802ecd31a8879@uvt.cz","totemiba: Properly allocate RDMA buffers\n\n1. In UD mode receivnig side of RDMA application should have enough\nspace in buffer to hold data and GRH. Also, sge.length on the receiving\nsize should be set to max_msg_size + sizeof (struct ibv_grh). Current\ncorosync doesn't take grh in the account and does not work if mtu is set\nto the real mtu of IB port (it works if netmtu is set to < 2048-40).\n2. ibv_wc.byte_len is the actual lentgh of the received packet, i.e.\nmsg_len + GRH. GRH length should be substracted in further proceeding.\nIf not, it might cause problems when messages get retransmitted, as\ntheir apparent size will constantly grow.\n3. Current corosync will not work with rdma and mtus > 2048. Most modern\nIB HW supports 4096 mtu.\n\nSigned-off-by: Yevheniy Demchenko <zheka@uvt.cz>\nReviewed-by: Jan Friesse <jfriesse@redhat.com>","Yevheniy Demchenko",false],["c5d4a0762f7db957baf4bfa3c1b30caa9904c72c","d965d13ffc237c7c0019229a1f0802ecd31a8879@uvt.cz","totemiba: Del channel fd from poll before destroy\n\nCorosync freezes after several peer node connects/disconnects. The\nfreeze happens in recv_token_cq_recv_event_fn in ibv_get_cq_event call.\nThe problems is in fact, that after each peer node connect,\nrecv_token_accept_destroy is called, which tries to call\npoll_dispatch_delete _after_ freeing of completion_channel. As\ncompletion_channel contains fd, handlers are not disconnected from\npoller properly. This leads to complete inconsistency in subsequent\ncalls to handlers.\n\nSigned-off-by: Yevheniy Demchenko <zheka@uvt.cz>\nReviewed-by: Jan Friesse <jfriesse@redhat.com>","Yevheniy Demchenko",false],["8f14a5788f67fc3f1735f5b21623cab99d9d76a7","d965d13ffc237c7c0019229a1f0802ecd31a8879@uvt.cz","totemiba: Fix parameters position for poll_add\n\nParameters in functions like mcast_cq_send_event_fn, ... were defined in\nincorrect order. Also their names were weird.\n\nSigned-off-by: Yevheniy Demchenko <zheka@uvt.cz>\nSigned-off-by: Jan Friesse <jfriesse@redhat.com>\nReviewed-by: Jan Friesse <jfriesse@redhat.com>","Yevheniy Demchenko",false],["805b3423eeb980ccd6bea2f404821229ff9099db","d965d13ffc237c7c0019229a1f0802ecd31a8879@uvt.cz","totemiba: Check if configured MTU is allowed by HW\n\nSolution use aproximation of totem structures. This needs to be\nrewritten in proper way. Also MTU checking should be implemented for IP\ntransports.\n\nSigned-off-by: Yevheniy Demchenko <zheka@uvt.cz>\nSigned-off-by: Jan Friesse <jfriesse@redhat.com>\nReviewed-by: Jan Friesse <jfriesse@redhat.com>","Yevheniy Demchenko",false],["f3ffd3da5c71a10e1783a38e50bafc61192854f6","bdfff7006d3a5967c7c741d652a74f5445442e11@redhat.com","totemsrp: Show English message when memb_state_gather_enter is called\n\nThe reason why memb_state_gather_enter is invoked was printed\nin integer code. This patch introduces human readable English\nmessages for the code.\n\nSigned-off-by: Masatake YAMATO <yamato@redhat.com>\nReviewed-by: Jan Friesse <jfriesse@redhat.com>","Masatake YAMATO",false],["b88c0766feff85a672f22515aa827c97cbce97b1","6488b1cbca6e6b4211117dfd16a5bcda41af6f8a@redhat.com","logsys: Make logging of totem work again\n\nBecause of change in libqb (9abb686) logging of TOTEM subsystem stopped\nworking.\n\nInstead of rely on previous behavior (implicit substring match), all\ntotem files are now explicitly given.\n\nAlso QB subsystem now uses comma separated filelist instead of previous\nfunction calling.\n\nSigned-off-by: Jan Friesse <jfriesse@redhat.com>\nReviewed-by: Christine Caulfield <ccaulfie@redhat.com>","Jan Friesse",false],["a91192cfe912f83a46648f0b26fa283760b20463","992cedbe1eac7dbaff482fcb880a50b57e6b8062@redhat.com","man pages: Note that votequorum's allow_downscale is unsupported\n\nSigned-off-by: Christine Caulfield <ccaulfie@redhat.com>\nReviewed-by: Fabio M. Di Nitto <fdinitto@redhat.com>","Christine Caulfield",false],["7014f10123a634cf026491edc9a09d6044106116","6488b1cbca6e6b4211117dfd16a5bcda41af6f8a@redhat.com","cfgtool: return error on reload failure\n\nIf reload fails, return code is set to value >0 to indicate error.\n\nSigned-off-by: Jan Friesse <jfriesse@redhat.com>\nReviewed-by: Christine Caulfield <ccaulfie@redhat.com>","Jan Friesse",false],["ff6a43edb346a5c313f97c39b6db00f4359c8170","992cedbe1eac7dbaff482fcb880a50b57e6b8062@redhat.com","votequorum: Add persistent expected_votes tracking.\n\nThis patch adds the option to store expected_votes to\npersistent storage. This is needed to allow_downscale\nto operate properly.\n\nSigned-off-by: Christine Caulfield <ccaulfie@redhat.com>","Christine Caulfield",false],["fcba1652ba76882682a89f713f3e6812f77732ba","992cedbe1eac7dbaff482fcb880a50b57e6b8062@redhat.com","votequorum: Improve/add documentation for quorum device API\n\nImprove the man pages for the votequorum qdevice API and include\nthem in the build. Also improve the testvotequorum2 test program.\n\nSigned-off-by: Christine Caulfield <ccaulfie@redhat.com>\nReviewed-by: Jan Friesse <jfriesse@redhat.com>","Christine Caulfield",false],["6cd1f67f1f63f5a8fdadb45734c28a6d6a512511","6488b1cbca6e6b4211117dfd16a5bcda41af6f8a@redhat.com","systemd unit: Make sure network is really up\n\nChange network.target to network-online.target to make sure network is\nreally up and running when starting corosync.\n\nSigned-off-by: Jan Friesse <jfriesse@redhat.com>\nReviewed-by: Christine Caulfield <ccaulfie@redhat.com>","Jan Friesse",false],["cfbb021e130337603fe5b545d1e377296ecb92ea","458918949d35e9c12ff543ff997464aaebb54844@gmail.com","totem: Drop invalid join msg in operational state\n\nAccording to the totem paper, if a processor\nreceives a join message in the operational state and if the\nreceivers identifier is in the join messages fail list,\nthen join message should be ignored.\n\nBy applying this validation of join messages, we can avoid unnecessary\nswitching from operational state to gather state(or even lead to rings\ncan not be merged) like the following to happen.\n\n1. Initially, there is only one ring contains three nodes, say\n   ring(A,B,C).\n2. A and B network partition, \"in the same time\", C is down.\n3. Node A sends join message with proclist:A,B,C. faillist:NULL.\n   Node B sends join message with proclist:A,B,C. faillist:NULL.\n4. Both A and B consensus timeout due to network partition.\n5. A and B network remerged.\n6. Node A sends join message with proclist:A,B,C. faillist:B,C. and\n   create ring(A).\n   Node B sends join message with proclist:A,B,C. faillist:A,C. and\n   create ring(B).\n7. Say join message with proclist:A,B,C. faillist:A,C which sent\n   by node B is received by node A because network remerged.\n8. Node A shifts to gather state and send out a modified join message\n   with proclist:A,B,C. faillist:B. Such join message will prevent\n   both A and B from merging.\n9. Node A consensus timeout (caused by waiting node C) and sends join\n   message with proclist:A,B,C. faillist:B,C again.\n\nSame thing happens on node B, so A and B will dead loop forever\nin step 7, 8 and 9.\n\nAs the paper also said: \"If a processor receives a join message in the\noperational state and if the sender's identifier is in the receiver's\nmy_proclist and the join message's ring_seq is less than the receiver's\nring sequence number, then it ignores the join message too.\" So these\npatch applying these validations of join messages altogether.\n\nSigned-off-by: Jason <huzhijiang@gmail.com>\nReviewed-by: Steven Dake <sdake@redhat.com>\nReviewed-by: Jan Friesse <jfriesse@redhat.com>","Jason",false],["8020f1d8e80da52c568fce09803d724b31c3fb88","992cedbe1eac7dbaff482fcb880a50b57e6b8062@redhat.com","votequorum: Add missing man pages\n\nMan pages for votequorum_qdevice_update and votquorum_qdevice_master_wins\nwere missing from the last commit.\n\nSigned-off-by: Christine Caulfield <ccaulfie@redhat.com>","Christine Caulfield",false],["178c0d82d9885923a64193c267e01ba9a109f8a4","6488b1cbca6e6b4211117dfd16a5bcda41af6f8a@redhat.com","Close devnull file handler\n\nSigned-off-by: Jan Friesse <jfriesse@redhat.com>\nReviewed-by: Christine Caulfield <ccaulfie@redhat.com>","Jan Friesse",false],["5c54f941ac210ee83871f1964d1c6cc784057ddb","6488b1cbca6e6b4211117dfd16a5bcda41af6f8a@redhat.com","Fix cppchecks warning\n\nSigned-off-by: Jan Friesse <jfriesse@redhat.com>\nReviewed-by: Christine Caulfield <ccaulfie@redhat.com>","Jan Friesse",false],["45dd9861ff78362068d214cf520006a1b26376cd","6488b1cbca6e6b4211117dfd16a5bcda41af6f8a@redhat.com","Properly check result of symlink\n\nError message is displayed when it's impossible to create symlink to\nfdata file.\n\nSigned-off-by: Jan Friesse <jfriesse@redhat.com>\nReviewed-by: Christine Caulfield <ccaulfie@redhat.com>","Jan Friesse",false]],"size":16,"ref":"refs/heads/needle-2.3","head":"45dd9861ff78362068d214cf520006a1b26376cd"}