GitHub PullRequestReviewCommentEvent at 2014-08-24 19:43:36
Repository: liquid
Actor: parkr
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/Shopify/liquid/pulls/comments/16637625","id":16637625,"diff_hunk":"@@ -33,6 +33,18 @@ def capitalize(input)\n       input.to_s.capitalize\n     end\n \n+    def concat(input, array)\n+      if input.is_a?(Array)\n+        if array.is_a?(Array)  \n+          input + array\n+        else\n+          return input","path":"lib/liquid/standardfilters.rb","position":9,"original_position":9,"commit_id":"3eefaaa9581899a5a672f043f9900aa5e34d332e","original_commit_id":"3eefaaa9581899a5a672f043f9900aa5e34d332e","user":{"login":"parkr","id":237985,"avatar_url":"https://avatars.githubusercontent.com/u/237985?v=2","gravatar_id":"3b05198379f4b275d304fd27e6cb09ae","url":"https://api.github.com/users/parkr","html_url":"https://github.com/parkr","followers_url":"https://api.github.com/users/parkr/followers","following_url":"https://api.github.com/users/parkr/following{/other_user}","gists_url":"https://api.github.com/users/parkr/gists{/gist_id}","starred_url":"https://api.github.com/users/parkr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parkr/subscriptions","organizations_url":"https://api.github.com/users/parkr/orgs","repos_url":"https://api.github.com/users/parkr/repos","events_url":"https://api.github.com/users/parkr/events{/privacy}","received_events_url":"https://api.github.com/users/parkr/received_events","type":"User","site_admin":false},"body":"I think so, yeah. When I `append`, I want to add a value to a list of values. Right now, `append` is string-centric, though, IIRC.","created_at":"2014-08-24T19:43:36Z","updated_at":"2014-08-24T19:43:36Z","html_url":"https://github.com/Shopify/liquid/pull/429#discussion_r16637625","pull_request_url":"https://api.github.com/repos/Shopify/liquid/pulls/429","_links":{"self":{"href":"https://api.github.com/repos/Shopify/liquid/pulls/comments/16637625"},"html":{"href":"https://github.com/Shopify/liquid/pull/429#discussion_r16637625"},"pull_request":{"href":"https://api.github.com/repos/Shopify/liquid/pulls/429"}}},"pull_request":{"url":"https://api.github.com/repos/Shopify/liquid/pulls/429","id":20222033,"html_url":"https://github.com/Shopify/liquid/pull/429","diff_url":"https://github.com/Shopify/liquid/pull/429.diff","patch_url":"https://github.com/Shopify/liquid/pull/429.patch","issue_url":"https://api.github.com/repos/Shopify/liquid/issues/429","number":429,"state":"open","locked":false,"title":"add concat filter","user":{"login":"divecch","id":213964,"avatar_url":"https://avatars.githubusercontent.com/u/213964?v=2","gravatar_id":"abcacd3eb6ec28ba30d2091542c4b9b5","url":"https://api.github.com/users/divecch","html_url":"https://github.com/divecch","followers_url":"https://api.github.com/users/divecch/followers","following_url":"https://api.github.com/users/divecch/following{/other_user}","gists_url":"https://api.github.com/users/divecch/gists{/gist_id}","starred_url":"https://api.github.com/users/divecch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/divecch/subscriptions","organizations_url":"https://api.github.com/users/divecch/orgs","repos_url":"https://api.github.com/users/divecch/repos","events_url":"https://api.github.com/users/divecch/events{/privacy}","received_events_url":"https://api.github.com/users/divecch/received_events","type":"User","site_admin":false},"body":"adding concat filter for arrays. it is very usefully and fix the issue #427","created_at":"2014-08-24T17:48:49Z","updated_at":"2014-08-24T19:43:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0609e3e2b7c416da87537ce98e4092b1ad6e5fa3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Shopify/liquid/pulls/429/commits","review_comments_url":"https://api.github.com/repos/Shopify/liquid/pulls/429/comments","review_comment_url":"https://api.github.com/repos/Shopify/liquid/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Shopify/liquid/issues/429/comments","statuses_url":"https://api.github.com/repos/Shopify/liquid/statuses/3eefaaa9581899a5a672f043f9900aa5e34d332e","head":{"label":"divecch:plus_concat_array","ref":"plus_concat_array","sha":"3eefaaa9581899a5a672f043f9900aa5e34d332e","user":{"login":"divecch","id":213964,"avatar_url":"https://avatars.githubusercontent.com/u/213964?v=2","gravatar_id":"abcacd3eb6ec28ba30d2091542c4b9b5","url":"https://api.github.com/users/divecch","html_url":"https://github.com/divecch","followers_url":"https://api.github.com/users/divecch/followers","following_url":"https://api.github.com/users/divecch/following{/other_user}","gists_url":"https://api.github.com/users/divecch/gists{/gist_id}","starred_url":"https://api.github.com/users/divecch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/divecch/subscriptions","organizations_url":"https://api.github.com/users/divecch/orgs","repos_url":"https://api.github.com/users/divecch/repos","events_url":"https://api.github.com/users/divecch/events{/privacy}","received_events_url":"https://api.github.com/users/divecch/received_events","type":"User","site_admin":false},"repo":{"id":23287863,"name":"liquid","full_name":"divecch/liquid","owner":{"login":"divecch","id":213964,"avatar_url":"https://avatars.githubusercontent.com/u/213964?v=2","gravatar_id":"abcacd3eb6ec28ba30d2091542c4b9b5","url":"https://api.github.com/users/divecch","html_url":"https://github.com/divecch","followers_url":"https://api.github.com/users/divecch/followers","following_url":"https://api.github.com/users/divecch/following{/other_user}","gists_url":"https://api.github.com/users/divecch/gists{/gist_id}","starred_url":"https://api.github.com/users/divecch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/divecch/subscriptions","organizations_url":"https://api.github.com/users/divecch/orgs","repos_url":"https://api.github.com/users/divecch/repos","events_url":"https://api.github.com/users/divecch/events{/privacy}","received_events_url":"https://api.github.com/users/divecch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/divecch/liquid","description":"Liquid markup language. Safe, customer facing template language for flexible web apps. ","fork":true,"url":"https://api.github.com/repos/divecch/liquid","forks_url":"https://api.github.com/repos/divecch/liquid/forks","keys_url":"https://api.github.com/repos/divecch/liquid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/divecch/liquid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/divecch/liquid/teams","hooks_url":"https://api.github.com/repos/divecch/liquid/hooks","issue_events_url":"https://api.github.com/repos/divecch/liquid/issues/events{/number}","events_url":"https://api.github.com/repos/divecch/liquid/events","assignees_url":"https://api.github.com/repos/divecch/liquid/assignees{/user}","branches_url":"https://api.github.com/repos/divecch/liquid/branches{/branch}","tags_url":"https://api.github.com/repos/divecch/liquid/tags","blobs_url":"https://api.github.com/repos/divecch/liquid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/divecch/liquid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/divecch/liquid/git/refs{/sha}","trees_url":"https://api.github.com/repos/divecch/liquid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/divecch/liquid/statuses/{sha}","languages_url":"https://api.github.com/repos/divecch/liquid/languages","stargazers_url":"https://api.github.com/repos/divecch/liquid/stargazers","contributors_url":"https://api.github.com/repos/divecch/liquid/contributors","subscribers_url":"https://api.github.com/repos/divecch/liquid/subscribers","subscription_url":"https://api.github.com/repos/divecch/liquid/subscription","commits_url":"https://api.github.com/repos/divecch/liquid/commits{/sha}","git_commits_url":"https://api.github.com/repos/divecch/liquid/git/commits{/sha}","comments_url":"https://api.github.com/repos/divecch/liquid/comments{/number}","issue_comment_url":"https://api.github.com/repos/divecch/liquid/issues/comments/{number}","contents_url":"https://api.github.com/repos/divecch/liquid/contents/{+path}","compare_url":"https://api.github.com/repos/divecch/liquid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/divecch/liquid/merges","archive_url":"https://api.github.com/repos/divecch/liquid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/divecch/liquid/downloads","issues_url":"https://api.github.com/repos/divecch/liquid/issues{/number}","pulls_url":"https://api.github.com/repos/divecch/liquid/pulls{/number}","milestones_url":"https://api.github.com/repos/divecch/liquid/milestones{/number}","notifications_url":"https://api.github.com/repos/divecch/liquid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/divecch/liquid/labels{/name}","releases_url":"https://api.github.com/repos/divecch/liquid/releases{/id}","created_at":"2014-08-24T17:43:50Z","updated_at":"2014-08-24T14:25:31Z","pushed_at":"2014-08-24T19:15:47Z","git_url":"git://github.com/divecch/liquid.git","ssh_url":"git@github.com:divecch/liquid.git","clone_url":"https://github.com/divecch/liquid.git","svn_url":"https://github.com/divecch/liquid","homepage":"http://liquidmarkup.org/","size":10933,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Shopify:master","ref":"master","sha":"dfb6c2049344989b3a6fa7adb2bfa9a0c575494e","user":{"login":"Shopify","id":8085,"avatar_url":"https://avatars.githubusercontent.com/u/8085?v=2","gravatar_id":"c5c29e455b8c4f05112abbc01af58a29","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"repo":{"id":15435,"name":"liquid","full_name":"Shopify/liquid","owner":{"login":"Shopify","id":8085,"avatar_url":"https://avatars.githubusercontent.com/u/8085?v=2","gravatar_id":"c5c29e455b8c4f05112abbc01af58a29","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Shopify/liquid","description":"Liquid markup language. Safe, customer facing template language for flexible web apps. ","fork":false,"url":"https://api.github.com/repos/Shopify/liquid","forks_url":"https://api.github.com/repos/Shopify/liquid/forks","keys_url":"https://api.github.com/repos/Shopify/liquid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shopify/liquid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shopify/liquid/teams","hooks_url":"https://api.github.com/repos/Shopify/liquid/hooks","issue_events_url":"https://api.github.com/repos/Shopify/liquid/issues/events{/number}","events_url":"https://api.github.com/repos/Shopify/liquid/events","assignees_url":"https://api.github.com/repos/Shopify/liquid/assignees{/user}","branches_url":"https://api.github.com/repos/Shopify/liquid/branches{/branch}","tags_url":"https://api.github.com/repos/Shopify/liquid/tags","blobs_url":"https://api.github.com/repos/Shopify/liquid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shopify/liquid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shopify/liquid/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shopify/liquid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shopify/liquid/statuses/{sha}","languages_url":"https://api.github.com/repos/Shopify/liquid/languages","stargazers_url":"https://api.github.com/repos/Shopify/liquid/stargazers","contributors_url":"https://api.github.com/repos/Shopify/liquid/contributors","subscribers_url":"https://api.github.com/repos/Shopify/liquid/subscribers","subscription_url":"https://api.github.com/repos/Shopify/liquid/subscription","commits_url":"https://api.github.com/repos/Shopify/liquid/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shopify/liquid/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shopify/liquid/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shopify/liquid/issues/comments/{number}","contents_url":"https://api.github.com/repos/Shopify/liquid/contents/{+path}","compare_url":"https://api.github.com/repos/Shopify/liquid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shopify/liquid/merges","archive_url":"https://api.github.com/repos/Shopify/liquid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shopify/liquid/downloads","issues_url":"https://api.github.com/repos/Shopify/liquid/issues{/number}","pulls_url":"https://api.github.com/repos/Shopify/liquid/pulls{/number}","milestones_url":"https://api.github.com/repos/Shopify/liquid/milestones{/number}","notifications_url":"https://api.github.com/repos/Shopify/liquid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shopify/liquid/labels{/name}","releases_url":"https://api.github.com/repos/Shopify/liquid/releases{/id}","created_at":"2008-05-08T15:27:26Z","updated_at":"2014-08-24T14:25:31Z","pushed_at":"2014-08-22T13:37:06Z","git_url":"git://github.com/Shopify/liquid.git","ssh_url":"git@github.com:Shopify/liquid.git","clone_url":"https://github.com/Shopify/liquid.git","svn_url":"https://github.com/Shopify/liquid","homepage":"http://liquidmarkup.org/","size":10933,"stargazers_count":2637,"watchers_count":2637,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":357,"mirror_url":null,"open_issues_count":18,"forks":357,"open_issues":18,"watchers":2637,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Shopify/liquid/pulls/429"},"html":{"href":"https://github.com/Shopify/liquid/pull/429"},"issue":{"href":"https://api.github.com/repos/Shopify/liquid/issues/429"},"comments":{"href":"https://api.github.com/repos/Shopify/liquid/issues/429/comments"},"review_comments":{"href":"https://api.github.com/repos/Shopify/liquid/pulls/429/comments"},"review_comment":{"href":"https://api.github.com/repos/Shopify/liquid/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Shopify/liquid/pulls/429/commits"},"statuses":{"href":"https://api.github.com/repos/Shopify/liquid/statuses/3eefaaa9581899a5a672f043f9900aa5e34d332e"}}}}