GitHub PullRequestReviewCommentEvent at 2014-02-19 13:28:41
Repository: libmpdataxx
Actor: trontrytel
Payload: {"comment":{"url":"https://api.github.com/repos/slayoo/libmpdataxx/pulls/comments/9864288","id":9864288,"diff_hunk":"@@ -98,6 +98,11 @@ int main()\n   run.advectee(ix::qx) = 0;\n   run.advectee(ix::qy) = 0;\n \n-  run.advance(nt); \n-\n+  for(int step = 1; step <=nt; step++)","path":"tests/shallow_water/spreading_drop_2d.cpp","position":6,"original_position":6,"commit_id":"03609dcc1199978d32aa9ea82b5e2a8986e547d2","original_commit_id":"03609dcc1199978d32aa9ea82b5e2a8986e547d2","user":{"login":"trontrytel","id":1196696,"avatar_url":"https://gravatar.com/avatar/b40eeeb0983addc5f27d70e796ccf1d5?d=https%3A%2F%2Fidenticons.github.com%2F1bf59779f28a6ee3d0cdb0828fd42037.png&r=x","gravatar_id":"b40eeeb0983addc5f27d70e796ccf1d5","url":"https://api.github.com/users/trontrytel","html_url":"https://github.com/trontrytel","followers_url":"https://api.github.com/users/trontrytel/followers","following_url":"https://api.github.com/users/trontrytel/following{/other_user}","gists_url":"https://api.github.com/users/trontrytel/gists{/gist_id}","starred_url":"https://api.github.com/users/trontrytel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trontrytel/subscriptions","organizations_url":"https://api.github.com/users/trontrytel/orgs","repos_url":"https://api.github.com/users/trontrytel/repos","events_url":"https://api.github.com/users/trontrytel/events{/privacy}","received_events_url":"https://api.github.com/users/trontrytel/received_events","type":"User","site_admin":false},"body":"Jak chcesz to zmieniaj - myślałam że to i tak tymczasowe, dopóki nie \nznajdziemy byka.\n\nPozdrawiam,\nania\n\nOn 02/19/2014 02:15 PM, Sylwester Arabas wrote:\n>\n> In tests/shallow_water/spreading_drop_2d.cpp:\n>\n> > @@ -98,6 +98,11 @@ int main()\n> >    run.advectee(ix::qx) = 0;\n> >    run.advectee(ix::qy) = 0;\n> >\n> > -  run.advance(nt);\n> > -\n> > +  for(int step = 1; step <=nt; step++)\n>\n> Aniu! To zabija równoległość :(\n> Proponuję to samo wrzucić do jakiegoś hooka, np:\n>\n> |void hook_post_step()\n> {\n>    parent_t::hook_post_step();\n>\n>    this->mem->barrier();\n>    if (this->mem->rank() != 0) return;\n>    if (min(this->mem->advectee()) < 0)\n>    {\n>      auto ix = minIndex(this->mem->advectee());\n>      std::cerr << \"  min @ (\" << ix << \") = \" << this->mem->advectee()(ix) << std::endl;\n>      throw std::runtime_error(\"values below zero!\");\n>    }\n> }\n> |\n>\n> Pozdrawiam,\n> S.\n>\n> —\n> Reply to this email directly or view it on GitHub \n> <https://github.com/slayoo/libmpdataxx/pull/104/files#r9863982>.\n>","created_at":"2014-02-19T13:28:41Z","updated_at":"2014-02-19T13:28:41Z","html_url":"https://github.com/slayoo/libmpdataxx/pull/104#discussion_r9864288","pull_request_url":"https://api.github.com/repos/slayoo/libmpdataxx/pulls/104","_links":{"self":{"href":"https://api.github.com/repos/slayoo/libmpdataxx/pulls/comments/9864288"},"html":{"href":"https://github.com/slayoo/libmpdataxx/pull/104#discussion_r9864288"},"pull_request":{"href":"https://api.github.com/repos/slayoo/libmpdataxx/pulls/104"}}}}