GitHub PullRequestEvent at 2014-02-06 16:22:20
Repository: redis-objects
Actor: nateware
Payload: {"action":"closed","number":103,"pull_request":{"url":"https://api.github.com/repos/nateware/redis-objects/pulls/103","id":7555793,"html_url":"https://github.com/nateware/redis-objects/pull/103","diff_url":"https://github.com/nateware/redis-objects/pull/103.diff","patch_url":"https://github.com/nateware/redis-objects/pull/103.patch","issue_url":"https://api.github.com/repos/nateware/redis-objects/issues/103","number":103,"state":"closed","title":"Allow overriding sorted set score types","user":{"login":"hfwang","id":5191,"avatar_url":"https://gravatar.com/avatar/708d60e43709bba4eceb5df7d8362b62?d=https%3A%2F%2Fidenticons.github.com%2F9b523b0c92185f39a0da77a82c51b46a.png&r=x","gravatar_id":"708d60e43709bba4eceb5df7d8362b62","url":"https://api.github.com/users/hfwang","html_url":"https://github.com/hfwang","followers_url":"https://api.github.com/users/hfwang/followers","following_url":"https://api.github.com/users/hfwang/following{/other_user}","gists_url":"https://api.github.com/users/hfwang/gists{/gist_id}","starred_url":"https://api.github.com/users/hfwang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hfwang/subscriptions","organizations_url":"https://api.github.com/users/hfwang/orgs","repos_url":"https://api.github.com/users/hfwang/repos","events_url":"https://api.github.com/users/hfwang/events{/privacy}","received_events_url":"https://api.github.com/users/hfwang/received_events","type":"User","site_admin":false},"body":"My fork of redis-objects has configurable marshalling, and I noticed that the way that from_redis is implemented caused issues (since I coerced the sortedset values to ints, they would also coerce the scores in the sorted set.)\r\n\r\nThis is the fix.","created_at":"2013-08-12T22:25:07Z","updated_at":"2014-02-06T16:22:20Z","closed_at":"2014-02-06T16:22:20Z","merged_at":null,"merge_commit_sha":"8afe77bb8a2b1b707686b751b76709625ebed8cc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nateware/redis-objects/pulls/103/commits","review_comments_url":"https://api.github.com/repos/nateware/redis-objects/pulls/103/comments","review_comment_url":"https://api.github.com/repos/nateware/redis-objects/pulls/comments/{number}","comments_url":"https://api.github.com/repos/nateware/redis-objects/issues/103/comments","statuses_url":"https://api.github.com/repos/nateware/redis-objects/statuses/71fbbdcabe7983b63f44d0daeed6c3bfe55fb666","head":{"label":"hfwang:rebase-sorted-set-scores","ref":"rebase-sorted-set-scores","sha":"71fbbdcabe7983b63f44d0daeed6c3bfe55fb666","user":{"login":"hfwang","id":5191,"avatar_url":"https://gravatar.com/avatar/708d60e43709bba4eceb5df7d8362b62?d=https%3A%2F%2Fidenticons.github.com%2F9b523b0c92185f39a0da77a82c51b46a.png&r=x","gravatar_id":"708d60e43709bba4eceb5df7d8362b62","url":"https://api.github.com/users/hfwang","html_url":"https://github.com/hfwang","followers_url":"https://api.github.com/users/hfwang/followers","following_url":"https://api.github.com/users/hfwang/following{/other_user}","gists_url":"https://api.github.com/users/hfwang/gists{/gist_id}","starred_url":"https://api.github.com/users/hfwang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hfwang/subscriptions","organizations_url":"https://api.github.com/users/hfwang/orgs","repos_url":"https://api.github.com/users/hfwang/repos","events_url":"https://api.github.com/users/hfwang/events{/privacy}","received_events_url":"https://api.github.com/users/hfwang/received_events","type":"User","site_admin":false},"repo":{"id":3411120,"name":"redis-objects","full_name":"hfwang/redis-objects","owner":{"login":"hfwang","id":5191,"avatar_url":"https://gravatar.com/avatar/708d60e43709bba4eceb5df7d8362b62?d=https%3A%2F%2Fidenticons.github.com%2F9b523b0c92185f39a0da77a82c51b46a.png&r=x","gravatar_id":"708d60e43709bba4eceb5df7d8362b62","url":"https://api.github.com/users/hfwang","html_url":"https://github.com/hfwang","followers_url":"https://api.github.com/users/hfwang/followers","following_url":"https://api.github.com/users/hfwang/following{/other_user}","gists_url":"https://api.github.com/users/hfwang/gists{/gist_id}","starred_url":"https://api.github.com/users/hfwang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hfwang/subscriptions","organizations_url":"https://api.github.com/users/hfwang/orgs","repos_url":"https://api.github.com/users/hfwang/repos","events_url":"https://api.github.com/users/hfwang/events{/privacy}","received_events_url":"https://api.github.com/users/hfwang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hfwang/redis-objects","description":"Map Redis types directly to Ruby objects","fork":true,"url":"https://api.github.com/repos/hfwang/redis-objects","forks_url":"https://api.github.com/repos/hfwang/redis-objects/forks","keys_url":"https://api.github.com/repos/hfwang/redis-objects/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hfwang/redis-objects/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hfwang/redis-objects/teams","hooks_url":"https://api.github.com/repos/hfwang/redis-objects/hooks","issue_events_url":"https://api.github.com/repos/hfwang/redis-objects/issues/events{/number}","events_url":"https://api.github.com/repos/hfwang/redis-objects/events","assignees_url":"https://api.github.com/repos/hfwang/redis-objects/assignees{/user}","branches_url":"https://api.github.com/repos/hfwang/redis-objects/branches{/branch}","tags_url":"https://api.github.com/repos/hfwang/redis-objects/tags","blobs_url":"https://api.github.com/repos/hfwang/redis-objects/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hfwang/redis-objects/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hfwang/redis-objects/git/refs{/sha}","trees_url":"https://api.github.com/repos/hfwang/redis-objects/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hfwang/redis-objects/statuses/{sha}","languages_url":"https://api.github.com/repos/hfwang/redis-objects/languages","stargazers_url":"https://api.github.com/repos/hfwang/redis-objects/stargazers","contributors_url":"https://api.github.com/repos/hfwang/redis-objects/contributors","subscribers_url":"https://api.github.com/repos/hfwang/redis-objects/subscribers","subscription_url":"https://api.github.com/repos/hfwang/redis-objects/subscription","commits_url":"https://api.github.com/repos/hfwang/redis-objects/commits{/sha}","git_commits_url":"https://api.github.com/repos/hfwang/redis-objects/git/commits{/sha}","comments_url":"https://api.github.com/repos/hfwang/redis-objects/comments{/number}","issue_comment_url":"https://api.github.com/repos/hfwang/redis-objects/issues/comments/{number}","contents_url":"https://api.github.com/repos/hfwang/redis-objects/contents/{+path}","compare_url":"https://api.github.com/repos/hfwang/redis-objects/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hfwang/redis-objects/merges","archive_url":"https://api.github.com/repos/hfwang/redis-objects/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hfwang/redis-objects/downloads","issues_url":"https://api.github.com/repos/hfwang/redis-objects/issues{/number}","pulls_url":"https://api.github.com/repos/hfwang/redis-objects/pulls{/number}","milestones_url":"https://api.github.com/repos/hfwang/redis-objects/milestones{/number}","notifications_url":"https://api.github.com/repos/hfwang/redis-objects/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hfwang/redis-objects/labels{/name}","releases_url":"https://api.github.com/repos/hfwang/redis-objects/releases{/id}","created_at":"2012-02-10T21:12:00Z","updated_at":"2014-01-08T00:05:09Z","pushed_at":"2014-01-08T00:05:09Z","git_url":"git://github.com/hfwang/redis-objects.git","ssh_url":"git@github.com:hfwang/redis-objects.git","clone_url":"https://github.com/hfwang/redis-objects.git","svn_url":"https://github.com/hfwang/redis-objects","homepage":"","size":679,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master","master_branch":"master"}},"base":{"label":"nateware:master","ref":"master","sha":"9ae6f6a2481937424bf7a36ad88351311d7f3a61","user":{"login":"nateware","id":7328,"avatar_url":"https://gravatar.com/avatar/69f4b9b411dfcaebe01d0fde8c751726?d=https%3A%2F%2Fidenticons.github.com%2F7c250678f61f49092fa0d4040e5e54e9.png&r=x","gravatar_id":"69f4b9b411dfcaebe01d0fde8c751726","url":"https://api.github.com/users/nateware","html_url":"https://github.com/nateware","followers_url":"https://api.github.com/users/nateware/followers","following_url":"https://api.github.com/users/nateware/following{/other_user}","gists_url":"https://api.github.com/users/nateware/gists{/gist_id}","starred_url":"https://api.github.com/users/nateware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nateware/subscriptions","organizations_url":"https://api.github.com/users/nateware/orgs","repos_url":"https://api.github.com/users/nateware/repos","events_url":"https://api.github.com/users/nateware/events{/privacy}","received_events_url":"https://api.github.com/users/nateware/received_events","type":"User","site_admin":false},"repo":{"id":367591,"name":"redis-objects","full_name":"nateware/redis-objects","owner":{"login":"nateware","id":7328,"avatar_url":"https://gravatar.com/avatar/69f4b9b411dfcaebe01d0fde8c751726?d=https%3A%2F%2Fidenticons.github.com%2F7c250678f61f49092fa0d4040e5e54e9.png&r=x","gravatar_id":"69f4b9b411dfcaebe01d0fde8c751726","url":"https://api.github.com/users/nateware","html_url":"https://github.com/nateware","followers_url":"https://api.github.com/users/nateware/followers","following_url":"https://api.github.com/users/nateware/following{/other_user}","gists_url":"https://api.github.com/users/nateware/gists{/gist_id}","starred_url":"https://api.github.com/users/nateware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nateware/subscriptions","organizations_url":"https://api.github.com/users/nateware/orgs","repos_url":"https://api.github.com/users/nateware/repos","events_url":"https://api.github.com/users/nateware/events{/privacy}","received_events_url":"https://api.github.com/users/nateware/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nateware/redis-objects","description":"Map Redis types directly to Ruby objects","fork":false,"url":"https://api.github.com/repos/nateware/redis-objects","forks_url":"https://api.github.com/repos/nateware/redis-objects/forks","keys_url":"https://api.github.com/repos/nateware/redis-objects/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nateware/redis-objects/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nateware/redis-objects/teams","hooks_url":"https://api.github.com/repos/nateware/redis-objects/hooks","issue_events_url":"https://api.github.com/repos/nateware/redis-objects/issues/events{/number}","events_url":"https://api.github.com/repos/nateware/redis-objects/events","assignees_url":"https://api.github.com/repos/nateware/redis-objects/assignees{/user}","branches_url":"https://api.github.com/repos/nateware/redis-objects/branches{/branch}","tags_url":"https://api.github.com/repos/nateware/redis-objects/tags","blobs_url":"https://api.github.com/repos/nateware/redis-objects/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nateware/redis-objects/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nateware/redis-objects/git/refs{/sha}","trees_url":"https://api.github.com/repos/nateware/redis-objects/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nateware/redis-objects/statuses/{sha}","languages_url":"https://api.github.com/repos/nateware/redis-objects/languages","stargazers_url":"https://api.github.com/repos/nateware/redis-objects/stargazers","contributors_url":"https://api.github.com/repos/nateware/redis-objects/contributors","subscribers_url":"https://api.github.com/repos/nateware/redis-objects/subscribers","subscription_url":"https://api.github.com/repos/nateware/redis-objects/subscription","commits_url":"https://api.github.com/repos/nateware/redis-objects/commits{/sha}","git_commits_url":"https://api.github.com/repos/nateware/redis-objects/git/commits{/sha}","comments_url":"https://api.github.com/repos/nateware/redis-objects/comments{/number}","issue_comment_url":"https://api.github.com/repos/nateware/redis-objects/issues/comments/{number}","contents_url":"https://api.github.com/repos/nateware/redis-objects/contents/{+path}","compare_url":"https://api.github.com/repos/nateware/redis-objects/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nateware/redis-objects/merges","archive_url":"https://api.github.com/repos/nateware/redis-objects/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nateware/redis-objects/downloads","issues_url":"https://api.github.com/repos/nateware/redis-objects/issues{/number}","pulls_url":"https://api.github.com/repos/nateware/redis-objects/pulls{/number}","milestones_url":"https://api.github.com/repos/nateware/redis-objects/milestones{/number}","notifications_url":"https://api.github.com/repos/nateware/redis-objects/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nateware/redis-objects/labels{/name}","releases_url":"https://api.github.com/repos/nateware/redis-objects/releases{/id}","created_at":"2009-11-10T14:32:02Z","updated_at":"2014-02-06T01:34:49Z","pushed_at":"2014-02-06T01:34:49Z","git_url":"git://github.com/nateware/redis-objects.git","ssh_url":"git@github.com:nateware/redis-objects.git","clone_url":"https://github.com/nateware/redis-objects.git","svn_url":"https://github.com/nateware/redis-objects","homepage":"","size":723,"stargazers_count":985,"watchers_count":985,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":137,"mirror_url":null,"open_issues_count":5,"forks":137,"open_issues":5,"watchers":985,"default_branch":"master","master_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nateware/redis-objects/pulls/103"},"html":{"href":"https://github.com/nateware/redis-objects/pull/103"},"issue":{"href":"https://api.github.com/repos/nateware/redis-objects/issues/103"},"comments":{"href":"https://api.github.com/repos/nateware/redis-objects/issues/103/comments"},"review_comments":{"href":"https://api.github.com/repos/nateware/redis-objects/pulls/103/comments"},"review_comment":{"href":"https://api.github.com/repos/nateware/redis-objects/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/nateware/redis-objects/pulls/103/commits"},"statuses":{"href":"https://api.github.com/repos/nateware/redis-objects/statuses/71fbbdcabe7983b63f44d0daeed6c3bfe55fb666"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":4,"review_comments":0,"commits":1,"additions":72,"deletions":25,"changed_files":3}}