GitHub PullRequestEvent at 2014-03-24 05:56:54
Repository: trashspotter-client
Actor: msecret
Payload: {"action":"opened","number":1,"pull_request":{"url":"https://api.github.com/repos/jeremiak/trashspotter-client/pulls/1","id":13887315,"html_url":"https://github.com/jeremiak/trashspotter-client/pull/1","diff_url":"https://github.com/jeremiak/trashspotter-client/pull/1.diff","patch_url":"https://github.com/jeremiak/trashspotter-client/pull/1.patch","issue_url":"https://api.github.com/repos/jeremiak/trashspotter-client/issues/1","number":1,"state":"open","title":"Updated JS to wait for async functions","user":{"login":"msecret","id":1701077,"avatar_url":"https://avatars.githubusercontent.com/u/1701077?","gravatar_id":"0568ab753361b646853ffddfa80a7d75","url":"https://api.github.com/users/msecret","html_url":"https://github.com/msecret","followers_url":"https://api.github.com/users/msecret/followers","following_url":"https://api.github.com/users/msecret/following{/other_user}","gists_url":"https://api.github.com/users/msecret/gists{/gist_id}","starred_url":"https://api.github.com/users/msecret/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msecret/subscriptions","organizations_url":"https://api.github.com/users/msecret/orgs","repos_url":"https://api.github.com/users/msecret/repos","events_url":"https://api.github.com/users/msecret/events{/privacy}","received_events_url":"https://api.github.com/users/msecret/received_events","type":"User","site_admin":false},"body":"Rather then setting global data from an ajax request and hoping it will be\r\nthere, the getLocation function will take an opts object with success and\r\nerror callbacks. The success callback is implemented so it recieves the location\r\ndata and makes the POST request to the backend. The error conditions should\r\nbe handled more specifically.\r\n\r\nAlso added a specific event handler to the click event, which would make it\r\neasier for testing and keeps functions smaller.\r\n\r\nTodo:\r\n- Put function documentation\r\n\r\nQuestions:\r\n- Does the pingHeroku ajax request need to be completed before any of the app\r\ncode runs?\r\n- If so, what should be done if that request doesn't return?","created_at":"2014-03-24T05:56:53Z","updated_at":"2014-03-24T05:56:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jeremiak/trashspotter-client/pulls/1/commits","review_comments_url":"https://api.github.com/repos/jeremiak/trashspotter-client/pulls/1/comments","review_comment_url":"https://api.github.com/repos/jeremiak/trashspotter-client/pulls/comments/{number}","comments_url":"https://api.github.com/repos/jeremiak/trashspotter-client/issues/1/comments","statuses_url":"https://api.github.com/repos/jeremiak/trashspotter-client/statuses/86669e6134cb2345a0f562b9eca4dd072bfb50c5","head":{"label":"msecret:gh-pages","ref":"gh-pages","sha":"86669e6134cb2345a0f562b9eca4dd072bfb50c5","user":{"login":"msecret","id":1701077,"avatar_url":"https://avatars.githubusercontent.com/u/1701077?","gravatar_id":"0568ab753361b646853ffddfa80a7d75","url":"https://api.github.com/users/msecret","html_url":"https://github.com/msecret","followers_url":"https://api.github.com/users/msecret/followers","following_url":"https://api.github.com/users/msecret/following{/other_user}","gists_url":"https://api.github.com/users/msecret/gists{/gist_id}","starred_url":"https://api.github.com/users/msecret/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msecret/subscriptions","organizations_url":"https://api.github.com/users/msecret/orgs","repos_url":"https://api.github.com/users/msecret/repos","events_url":"https://api.github.com/users/msecret/events{/privacy}","received_events_url":"https://api.github.com/users/msecret/received_events","type":"User","site_admin":false},"repo":{"id":18052772,"name":"trashspotter-client","full_name":"msecret/trashspotter-client","owner":{"login":"msecret","id":1701077,"avatar_url":"https://avatars.githubusercontent.com/u/1701077?","gravatar_id":"0568ab753361b646853ffddfa80a7d75","url":"https://api.github.com/users/msecret","html_url":"https://github.com/msecret","followers_url":"https://api.github.com/users/msecret/followers","following_url":"https://api.github.com/users/msecret/following{/other_user}","gists_url":"https://api.github.com/users/msecret/gists{/gist_id}","starred_url":"https://api.github.com/users/msecret/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msecret/subscriptions","organizations_url":"https://api.github.com/users/msecret/orgs","repos_url":"https://api.github.com/users/msecret/repos","events_url":"https://api.github.com/users/msecret/events{/privacy}","received_events_url":"https://api.github.com/users/msecret/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/msecret/trashspotter-client","description":"Client for trash spotter","fork":true,"url":"https://api.github.com/repos/msecret/trashspotter-client","forks_url":"https://api.github.com/repos/msecret/trashspotter-client/forks","keys_url":"https://api.github.com/repos/msecret/trashspotter-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/msecret/trashspotter-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/msecret/trashspotter-client/teams","hooks_url":"https://api.github.com/repos/msecret/trashspotter-client/hooks","issue_events_url":"https://api.github.com/repos/msecret/trashspotter-client/issues/events{/number}","events_url":"https://api.github.com/repos/msecret/trashspotter-client/events","assignees_url":"https://api.github.com/repos/msecret/trashspotter-client/assignees{/user}","branches_url":"https://api.github.com/repos/msecret/trashspotter-client/branches{/branch}","tags_url":"https://api.github.com/repos/msecret/trashspotter-client/tags","blobs_url":"https://api.github.com/repos/msecret/trashspotter-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/msecret/trashspotter-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/msecret/trashspotter-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/msecret/trashspotter-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/msecret/trashspotter-client/statuses/{sha}","languages_url":"https://api.github.com/repos/msecret/trashspotter-client/languages","stargazers_url":"https://api.github.com/repos/msecret/trashspotter-client/stargazers","contributors_url":"https://api.github.com/repos/msecret/trashspotter-client/contributors","subscribers_url":"https://api.github.com/repos/msecret/trashspotter-client/subscribers","subscription_url":"https://api.github.com/repos/msecret/trashspotter-client/subscription","commits_url":"https://api.github.com/repos/msecret/trashspotter-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/msecret/trashspotter-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/msecret/trashspotter-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/msecret/trashspotter-client/issues/comments/{number}","contents_url":"https://api.github.com/repos/msecret/trashspotter-client/contents/{+path}","compare_url":"https://api.github.com/repos/msecret/trashspotter-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/msecret/trashspotter-client/merges","archive_url":"https://api.github.com/repos/msecret/trashspotter-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/msecret/trashspotter-client/downloads","issues_url":"https://api.github.com/repos/msecret/trashspotter-client/issues{/number}","pulls_url":"https://api.github.com/repos/msecret/trashspotter-client/pulls{/number}","milestones_url":"https://api.github.com/repos/msecret/trashspotter-client/milestones{/number}","notifications_url":"https://api.github.com/repos/msecret/trashspotter-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/msecret/trashspotter-client/labels{/name}","releases_url":"https://api.github.com/repos/msecret/trashspotter-client/releases{/id}","created_at":"2014-03-24T05:36:45Z","updated_at":"2014-03-24T05:56:54Z","pushed_at":"2014-03-24T05:56:06Z","git_url":"git://github.com/msecret/trashspotter-client.git","ssh_url":"git@github.com:msecret/trashspotter-client.git","clone_url":"https://github.com/msecret/trashspotter-client.git","svn_url":"https://github.com/msecret/trashspotter-client","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master","master_branch":"master"}},"base":{"label":"jeremiak:gh-pages","ref":"gh-pages","sha":"d3e808cb42907e98e8beaa251a0e6291c93ca1ef","user":{"login":"jeremiak","id":780941,"avatar_url":"https://avatars.githubusercontent.com/u/780941?","gravatar_id":"638d6baab37b56ab0f8d0e4b4cf8af12","url":"https://api.github.com/users/jeremiak","html_url":"https://github.com/jeremiak","followers_url":"https://api.github.com/users/jeremiak/followers","following_url":"https://api.github.com/users/jeremiak/following{/other_user}","gists_url":"https://api.github.com/users/jeremiak/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremiak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremiak/subscriptions","organizations_url":"https://api.github.com/users/jeremiak/orgs","repos_url":"https://api.github.com/users/jeremiak/repos","events_url":"https://api.github.com/users/jeremiak/events{/privacy}","received_events_url":"https://api.github.com/users/jeremiak/received_events","type":"User","site_admin":false},"repo":{"id":17928612,"name":"trashspotter-client","full_name":"jeremiak/trashspotter-client","owner":{"login":"jeremiak","id":780941,"avatar_url":"https://avatars.githubusercontent.com/u/780941?","gravatar_id":"638d6baab37b56ab0f8d0e4b4cf8af12","url":"https://api.github.com/users/jeremiak","html_url":"https://github.com/jeremiak","followers_url":"https://api.github.com/users/jeremiak/followers","following_url":"https://api.github.com/users/jeremiak/following{/other_user}","gists_url":"https://api.github.com/users/jeremiak/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremiak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremiak/subscriptions","organizations_url":"https://api.github.com/users/jeremiak/orgs","repos_url":"https://api.github.com/users/jeremiak/repos","events_url":"https://api.github.com/users/jeremiak/events{/privacy}","received_events_url":"https://api.github.com/users/jeremiak/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jeremiak/trashspotter-client","description":"Client for trash spotter","fork":false,"url":"https://api.github.com/repos/jeremiak/trashspotter-client","forks_url":"https://api.github.com/repos/jeremiak/trashspotter-client/forks","keys_url":"https://api.github.com/repos/jeremiak/trashspotter-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jeremiak/trashspotter-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jeremiak/trashspotter-client/teams","hooks_url":"https://api.github.com/repos/jeremiak/trashspotter-client/hooks","issue_events_url":"https://api.github.com/repos/jeremiak/trashspotter-client/issues/events{/number}","events_url":"https://api.github.com/repos/jeremiak/trashspotter-client/events","assignees_url":"https://api.github.com/repos/jeremiak/trashspotter-client/assignees{/user}","branches_url":"https://api.github.com/repos/jeremiak/trashspotter-client/branches{/branch}","tags_url":"https://api.github.com/repos/jeremiak/trashspotter-client/tags","blobs_url":"https://api.github.com/repos/jeremiak/trashspotter-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jeremiak/trashspotter-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jeremiak/trashspotter-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/jeremiak/trashspotter-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jeremiak/trashspotter-client/statuses/{sha}","languages_url":"https://api.github.com/repos/jeremiak/trashspotter-client/languages","stargazers_url":"https://api.github.com/repos/jeremiak/trashspotter-client/stargazers","contributors_url":"https://api.github.com/repos/jeremiak/trashspotter-client/contributors","subscribers_url":"https://api.github.com/repos/jeremiak/trashspotter-client/subscribers","subscription_url":"https://api.github.com/repos/jeremiak/trashspotter-client/subscription","commits_url":"https://api.github.com/repos/jeremiak/trashspotter-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/jeremiak/trashspotter-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/jeremiak/trashspotter-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/jeremiak/trashspotter-client/issues/comments/{number}","contents_url":"https://api.github.com/repos/jeremiak/trashspotter-client/contents/{+path}","compare_url":"https://api.github.com/repos/jeremiak/trashspotter-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jeremiak/trashspotter-client/merges","archive_url":"https://api.github.com/repos/jeremiak/trashspotter-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jeremiak/trashspotter-client/downloads","issues_url":"https://api.github.com/repos/jeremiak/trashspotter-client/issues{/number}","pulls_url":"https://api.github.com/repos/jeremiak/trashspotter-client/pulls{/number}","milestones_url":"https://api.github.com/repos/jeremiak/trashspotter-client/milestones{/number}","notifications_url":"https://api.github.com/repos/jeremiak/trashspotter-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jeremiak/trashspotter-client/labels{/name}","releases_url":"https://api.github.com/repos/jeremiak/trashspotter-client/releases{/id}","created_at":"2014-03-20T02:46:31Z","updated_at":"2014-03-21T08:35:04Z","pushed_at":"2014-03-21T08:35:03Z","git_url":"git://github.com/jeremiak/trashspotter-client.git","ssh_url":"git@github.com:jeremiak/trashspotter-client.git","clone_url":"https://github.com/jeremiak/trashspotter-client.git","svn_url":"https://github.com/jeremiak/trashspotter-client","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master","master_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jeremiak/trashspotter-client/pulls/1"},"html":{"href":"https://github.com/jeremiak/trashspotter-client/pull/1"},"issue":{"href":"https://api.github.com/repos/jeremiak/trashspotter-client/issues/1"},"comments":{"href":"https://api.github.com/repos/jeremiak/trashspotter-client/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/jeremiak/trashspotter-client/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/jeremiak/trashspotter-client/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/jeremiak/trashspotter-client/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/jeremiak/trashspotter-client/statuses/86669e6134cb2345a0f562b9eca4dd072bfb50c5"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":61,"deletions":44,"changed_files":1}}