GitHub PullRequestReviewCommentEvent at 2014-09-28 05:00:30
Repository: qserv
Actor: smonkewitz
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/LSST/qserv/pulls/comments/18127598","id":18127598,"diff_hunk":"@@ -148,6 +144,9 @@ def killQuery(self, query, taskId):\n         self._callWithThread(a.invoke)\n         return \"Attempt: \" + query\n \n+    ### Deprecated/unused: the Lua interface is single-threaded and doesn't\n+    ### tolerate blocking well, so we never want it to wait for a query to\n+    ### complete in this manner.","path":"core/modules/czar/lsst/qserv/czar/appInterface.py","position":28,"original_position":28,"commit_id":"a0e6ea87752e0039174b34b3fef793de86d2b1ab","original_commit_id":"a0e6ea87752e0039174b34b3fef793de86d2b1ab","user":{"login":"smonkewitz","id":620114,"avatar_url":"https://avatars.githubusercontent.com/u/620114?v=2","gravatar_id":"","url":"https://api.github.com/users/smonkewitz","html_url":"https://github.com/smonkewitz","followers_url":"https://api.github.com/users/smonkewitz/followers","following_url":"https://api.github.com/users/smonkewitz/following{/other_user}","gists_url":"https://api.github.com/users/smonkewitz/gists{/gist_id}","starred_url":"https://api.github.com/users/smonkewitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smonkewitz/subscriptions","organizations_url":"https://api.github.com/users/smonkewitz/orgs","repos_url":"https://api.github.com/users/smonkewitz/repos","events_url":"https://api.github.com/users/smonkewitz/events{/privacy}","received_events_url":"https://api.github.com/users/smonkewitz/received_events","type":"User","site_admin":false},"body":"Why not just remove it then? Is there a ticket for getting rid of this?","created_at":"2014-09-28T05:00:30Z","updated_at":"2014-09-28T05:00:30Z","html_url":"https://github.com/LSST/qserv/pull/2#discussion_r18127598","pull_request_url":"https://api.github.com/repos/LSST/qserv/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/LSST/qserv/pulls/comments/18127598"},"html":{"href":"https://github.com/LSST/qserv/pull/2#discussion_r18127598"},"pull_request":{"href":"https://api.github.com/repos/LSST/qserv/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/LSST/qserv/pulls/2","id":21745611,"html_url":"https://github.com/LSST/qserv/pull/2","diff_url":"https://github.com/LSST/qserv/pull/2.diff","patch_url":"https://github.com/LSST/qserv/pull/2.patch","issue_url":"https://api.github.com/repos/LSST/qserv/issues/2","number":2,"state":"open","locked":false,"title":"tickets/DM-199: Develop new master-worker result system","user":{"login":"smonkewitz","id":620114,"avatar_url":"https://avatars.githubusercontent.com/u/620114?v=2","gravatar_id":"","url":"https://api.github.com/users/smonkewitz","html_url":"https://github.com/smonkewitz","followers_url":"https://api.github.com/users/smonkewitz/followers","following_url":"https://api.github.com/users/smonkewitz/following{/other_user}","gists_url":"https://api.github.com/users/smonkewitz/gists{/gist_id}","starred_url":"https://api.github.com/users/smonkewitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smonkewitz/subscriptions","organizations_url":"https://api.github.com/users/smonkewitz/orgs","repos_url":"https://api.github.com/users/smonkewitz/repos","events_url":"https://api.github.com/users/smonkewitz/events{/privacy}","received_events_url":"https://api.github.com/users/smonkewitz/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-09-24T21:17:32Z","updated_at":"2014-09-28T05:00:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1dddafca389ff756729f8af65351b01aae550b36","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/LSST/qserv/pulls/2/commits","review_comments_url":"https://api.github.com/repos/LSST/qserv/pulls/2/comments","review_comment_url":"https://api.github.com/repos/LSST/qserv/pulls/comments/{number}","comments_url":"https://api.github.com/repos/LSST/qserv/issues/2/comments","statuses_url":"https://api.github.com/repos/LSST/qserv/statuses/a0e6ea87752e0039174b34b3fef793de86d2b1ab","head":{"label":"LSST:tickets/DM-199","ref":"tickets/DM-199","sha":"a0e6ea87752e0039174b34b3fef793de86d2b1ab","user":{"login":"LSST","id":1134504,"avatar_url":"https://avatars.githubusercontent.com/u/1134504?v=2","gravatar_id":"","url":"https://api.github.com/users/LSST","html_url":"https://github.com/LSST","followers_url":"https://api.github.com/users/LSST/followers","following_url":"https://api.github.com/users/LSST/following{/other_user}","gists_url":"https://api.github.com/users/LSST/gists{/gist_id}","starred_url":"https://api.github.com/users/LSST/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LSST/subscriptions","organizations_url":"https://api.github.com/users/LSST/orgs","repos_url":"https://api.github.com/users/LSST/repos","events_url":"https://api.github.com/users/LSST/events{/privacy}","received_events_url":"https://api.github.com/users/LSST/received_events","type":"Organization","site_admin":false},"repo":{"id":23013460,"name":"qserv","full_name":"LSST/qserv","owner":{"login":"LSST","id":1134504,"avatar_url":"https://avatars.githubusercontent.com/u/1134504?v=2","gravatar_id":"","url":"https://api.github.com/users/LSST","html_url":"https://github.com/LSST","followers_url":"https://api.github.com/users/LSST/followers","following_url":"https://api.github.com/users/LSST/following{/other_user}","gists_url":"https://api.github.com/users/LSST/gists{/gist_id}","starred_url":"https://api.github.com/users/LSST/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LSST/subscriptions","organizations_url":"https://api.github.com/users/LSST/orgs","repos_url":"https://api.github.com/users/LSST/repos","events_url":"https://api.github.com/users/LSST/events{/privacy}","received_events_url":"https://api.github.com/users/LSST/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LSST/qserv","description":null,"fork":false,"url":"https://api.github.com/repos/LSST/qserv","forks_url":"https://api.github.com/repos/LSST/qserv/forks","keys_url":"https://api.github.com/repos/LSST/qserv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LSST/qserv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LSST/qserv/teams","hooks_url":"https://api.github.com/repos/LSST/qserv/hooks","issue_events_url":"https://api.github.com/repos/LSST/qserv/issues/events{/number}","events_url":"https://api.github.com/repos/LSST/qserv/events","assignees_url":"https://api.github.com/repos/LSST/qserv/assignees{/user}","branches_url":"https://api.github.com/repos/LSST/qserv/branches{/branch}","tags_url":"https://api.github.com/repos/LSST/qserv/tags","blobs_url":"https://api.github.com/repos/LSST/qserv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LSST/qserv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LSST/qserv/git/refs{/sha}","trees_url":"https://api.github.com/repos/LSST/qserv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LSST/qserv/statuses/{sha}","languages_url":"https://api.github.com/repos/LSST/qserv/languages","stargazers_url":"https://api.github.com/repos/LSST/qserv/stargazers","contributors_url":"https://api.github.com/repos/LSST/qserv/contributors","subscribers_url":"https://api.github.com/repos/LSST/qserv/subscribers","subscription_url":"https://api.github.com/repos/LSST/qserv/subscription","commits_url":"https://api.github.com/repos/LSST/qserv/commits{/sha}","git_commits_url":"https://api.github.com/repos/LSST/qserv/git/commits{/sha}","comments_url":"https://api.github.com/repos/LSST/qserv/comments{/number}","issue_comment_url":"https://api.github.com/repos/LSST/qserv/issues/comments/{number}","contents_url":"https://api.github.com/repos/LSST/qserv/contents/{+path}","compare_url":"https://api.github.com/repos/LSST/qserv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LSST/qserv/merges","archive_url":"https://api.github.com/repos/LSST/qserv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LSST/qserv/downloads","issues_url":"https://api.github.com/repos/LSST/qserv/issues{/number}","pulls_url":"https://api.github.com/repos/LSST/qserv/pulls{/number}","milestones_url":"https://api.github.com/repos/LSST/qserv/milestones{/number}","notifications_url":"https://api.github.com/repos/LSST/qserv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LSST/qserv/labels{/name}","releases_url":"https://api.github.com/repos/LSST/qserv/releases{/id}","created_at":"2014-08-16T07:50:36Z","updated_at":"2014-09-19T15:19:05Z","pushed_at":"2014-09-27T00:51:08Z","git_url":"git://github.com/LSST/qserv.git","ssh_url":"git@github.com:LSST/qserv.git","clone_url":"https://github.com/LSST/qserv.git","svn_url":"https://github.com/LSST/qserv","homepage":null,"size":14081,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"LSST:master","ref":"master","sha":"fb2c1a6ae7e22a72b44170a593f3312955a6ddc0","user":{"login":"LSST","id":1134504,"avatar_url":"https://avatars.githubusercontent.com/u/1134504?v=2","gravatar_id":"","url":"https://api.github.com/users/LSST","html_url":"https://github.com/LSST","followers_url":"https://api.github.com/users/LSST/followers","following_url":"https://api.github.com/users/LSST/following{/other_user}","gists_url":"https://api.github.com/users/LSST/gists{/gist_id}","starred_url":"https://api.github.com/users/LSST/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LSST/subscriptions","organizations_url":"https://api.github.com/users/LSST/orgs","repos_url":"https://api.github.com/users/LSST/repos","events_url":"https://api.github.com/users/LSST/events{/privacy}","received_events_url":"https://api.github.com/users/LSST/received_events","type":"Organization","site_admin":false},"repo":{"id":23013460,"name":"qserv","full_name":"LSST/qserv","owner":{"login":"LSST","id":1134504,"avatar_url":"https://avatars.githubusercontent.com/u/1134504?v=2","gravatar_id":"","url":"https://api.github.com/users/LSST","html_url":"https://github.com/LSST","followers_url":"https://api.github.com/users/LSST/followers","following_url":"https://api.github.com/users/LSST/following{/other_user}","gists_url":"https://api.github.com/users/LSST/gists{/gist_id}","starred_url":"https://api.github.com/users/LSST/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LSST/subscriptions","organizations_url":"https://api.github.com/users/LSST/orgs","repos_url":"https://api.github.com/users/LSST/repos","events_url":"https://api.github.com/users/LSST/events{/privacy}","received_events_url":"https://api.github.com/users/LSST/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LSST/qserv","description":null,"fork":false,"url":"https://api.github.com/repos/LSST/qserv","forks_url":"https://api.github.com/repos/LSST/qserv/forks","keys_url":"https://api.github.com/repos/LSST/qserv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LSST/qserv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LSST/qserv/teams","hooks_url":"https://api.github.com/repos/LSST/qserv/hooks","issue_events_url":"https://api.github.com/repos/LSST/qserv/issues/events{/number}","events_url":"https://api.github.com/repos/LSST/qserv/events","assignees_url":"https://api.github.com/repos/LSST/qserv/assignees{/user}","branches_url":"https://api.github.com/repos/LSST/qserv/branches{/branch}","tags_url":"https://api.github.com/repos/LSST/qserv/tags","blobs_url":"https://api.github.com/repos/LSST/qserv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LSST/qserv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LSST/qserv/git/refs{/sha}","trees_url":"https://api.github.com/repos/LSST/qserv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LSST/qserv/statuses/{sha}","languages_url":"https://api.github.com/repos/LSST/qserv/languages","stargazers_url":"https://api.github.com/repos/LSST/qserv/stargazers","contributors_url":"https://api.github.com/repos/LSST/qserv/contributors","subscribers_url":"https://api.github.com/repos/LSST/qserv/subscribers","subscription_url":"https://api.github.com/repos/LSST/qserv/subscription","commits_url":"https://api.github.com/repos/LSST/qserv/commits{/sha}","git_commits_url":"https://api.github.com/repos/LSST/qserv/git/commits{/sha}","comments_url":"https://api.github.com/repos/LSST/qserv/comments{/number}","issue_comment_url":"https://api.github.com/repos/LSST/qserv/issues/comments/{number}","contents_url":"https://api.github.com/repos/LSST/qserv/contents/{+path}","compare_url":"https://api.github.com/repos/LSST/qserv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LSST/qserv/merges","archive_url":"https://api.github.com/repos/LSST/qserv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LSST/qserv/downloads","issues_url":"https://api.github.com/repos/LSST/qserv/issues{/number}","pulls_url":"https://api.github.com/repos/LSST/qserv/pulls{/number}","milestones_url":"https://api.github.com/repos/LSST/qserv/milestones{/number}","notifications_url":"https://api.github.com/repos/LSST/qserv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LSST/qserv/labels{/name}","releases_url":"https://api.github.com/repos/LSST/qserv/releases{/id}","created_at":"2014-08-16T07:50:36Z","updated_at":"2014-09-19T15:19:05Z","pushed_at":"2014-09-27T00:51:08Z","git_url":"git://github.com/LSST/qserv.git","ssh_url":"git@github.com:LSST/qserv.git","clone_url":"https://github.com/LSST/qserv.git","svn_url":"https://github.com/LSST/qserv","homepage":null,"size":14081,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/LSST/qserv/pulls/2"},"html":{"href":"https://github.com/LSST/qserv/pull/2"},"issue":{"href":"https://api.github.com/repos/LSST/qserv/issues/2"},"comments":{"href":"https://api.github.com/repos/LSST/qserv/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/LSST/qserv/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/LSST/qserv/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/LSST/qserv/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/LSST/qserv/statuses/a0e6ea87752e0039174b34b3fef793de86d2b1ab"}}}}