GitHub PullRequestReviewCommentEvent at 2014-06-19 22:27:31
Repository: plottable
Actor: jtlan
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/palantir/plottable/pulls/comments/13997953","id":13997953,"diff_hunk":"@@ -0,0 +1,39 @@\n+///<reference path=\"../../reference.ts\" />\n+\n+module Plottable {\n+  export module Formatter {\n+    export class Time extends Abstract.Formatter {\n+      /**\n+       * Creates a formatter that displays dates\n+       * \n+       * @constructor\n+       * @param {number} [precision] The number of decimal places to display.","path":"src/utils/formatters/timeFormatter.ts","position":10,"original_position":10,"commit_id":"1e26d5dc1ac4f7ab552f0ef3f752873fee22242a","original_commit_id":"1e26d5dc1ac4f7ab552f0ef3f752873fee22242a","user":{"login":"jtlan","id":1440449,"avatar_url":"https://avatars.githubusercontent.com/u/1440449?","gravatar_id":"4bc5c0f9427390afb79f516fe35801be","url":"https://api.github.com/users/jtlan","html_url":"https://github.com/jtlan","followers_url":"https://api.github.com/users/jtlan/followers","following_url":"https://api.github.com/users/jtlan/following{/other_user}","gists_url":"https://api.github.com/users/jtlan/gists{/gist_id}","starred_url":"https://api.github.com/users/jtlan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtlan/subscriptions","organizations_url":"https://api.github.com/users/jtlan/orgs","repos_url":"https://api.github.com/users/jtlan/repos","events_url":"https://api.github.com/users/jtlan/events{/privacy}","received_events_url":"https://api.github.com/users/jtlan/received_events","type":"User","site_admin":false},"body":"Does precision actually get used at all? If not, you might consider removing it from the list of parameters and calling `super(null)` during construction.","created_at":"2014-06-19T22:27:31Z","updated_at":"2014-06-19T22:27:31Z","html_url":"https://github.com/palantir/plottable/pull/570#discussion_r13997953","pull_request_url":"https://api.github.com/repos/palantir/plottable/pulls/570","_links":{"self":{"href":"https://api.github.com/repos/palantir/plottable/pulls/comments/13997953"},"html":{"href":"https://github.com/palantir/plottable/pull/570#discussion_r13997953"},"pull_request":{"href":"https://api.github.com/repos/palantir/plottable/pulls/570"}}},"pull_request":{"url":"https://api.github.com/repos/palantir/plottable/pulls/570","id":17375969,"html_url":"https://github.com/palantir/plottable/pull/570","diff_url":"https://github.com/palantir/plottable/pull/570.diff","patch_url":"https://github.com/palantir/plottable/pull/570.patch","issue_url":"https://api.github.com/repos/palantir/plottable/issues/570","number":570,"state":"open","title":"Time Axis and Formatter","user":{"login":"lewin","id":4107323,"avatar_url":"https://avatars.githubusercontent.com/u/4107323?","gravatar_id":"bb6310957b3f53bb02af67c73b91ee1a","url":"https://api.github.com/users/lewin","html_url":"https://github.com/lewin","followers_url":"https://api.github.com/users/lewin/followers","following_url":"https://api.github.com/users/lewin/following{/other_user}","gists_url":"https://api.github.com/users/lewin/gists{/gist_id}","starred_url":"https://api.github.com/users/lewin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lewin/subscriptions","organizations_url":"https://api.github.com/users/lewin/orgs","repos_url":"https://api.github.com/users/lewin/repos","events_url":"https://api.github.com/users/lewin/events{/privacy}","received_events_url":"https://api.github.com/users/lewin/received_events","type":"User","site_admin":false},"body":"Reopening #562 now that #564 has been merged in. \r\n\r\nI've removed the Time Scale changes for now because they weren't playing nice with the domainers #553  (since the domainer assumes that they are quantitive scale). \r\n\r\nFor the Time formatter, I wasn't too sure what to do with precision. Currently I'm ignoring it, but we may want to make it do something in the future. ","created_at":"2014-06-19T21:03:33Z","updated_at":"2014-06-19T22:27:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e780a245a8cc82c40cbab977c3a9d883e07926db","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/palantir/plottable/pulls/570/commits","review_comments_url":"https://api.github.com/repos/palantir/plottable/pulls/570/comments","review_comment_url":"https://api.github.com/repos/palantir/plottable/pulls/comments/{number}","comments_url":"https://api.github.com/repos/palantir/plottable/issues/570/comments","statuses_url":"https://api.github.com/repos/palantir/plottable/statuses/1e26d5dc1ac4f7ab552f0ef3f752873fee22242a","head":{"label":"palantir:date-axis","ref":"date-axis","sha":"1e26d5dc1ac4f7ab552f0ef3f752873fee22242a","user":{"login":"palantir","id":303157,"avatar_url":"https://avatars.githubusercontent.com/u/303157?","gravatar_id":"c593136bf7c6a139280354bfc1448a14","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"repo":{"id":16149854,"name":"plottable","full_name":"palantir/plottable","owner":{"login":"palantir","id":303157,"avatar_url":"https://avatars.githubusercontent.com/u/303157?","gravatar_id":"c593136bf7c6a139280354bfc1448a14","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/palantir/plottable","description":"A library for creating interactive charts within a grid layout.","fork":false,"url":"https://api.github.com/repos/palantir/plottable","forks_url":"https://api.github.com/repos/palantir/plottable/forks","keys_url":"https://api.github.com/repos/palantir/plottable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/palantir/plottable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/palantir/plottable/teams","hooks_url":"https://api.github.com/repos/palantir/plottable/hooks","issue_events_url":"https://api.github.com/repos/palantir/plottable/issues/events{/number}","events_url":"https://api.github.com/repos/palantir/plottable/events","assignees_url":"https://api.github.com/repos/palantir/plottable/assignees{/user}","branches_url":"https://api.github.com/repos/palantir/plottable/branches{/branch}","tags_url":"https://api.github.com/repos/palantir/plottable/tags","blobs_url":"https://api.github.com/repos/palantir/plottable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/palantir/plottable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/palantir/plottable/git/refs{/sha}","trees_url":"https://api.github.com/repos/palantir/plottable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/palantir/plottable/statuses/{sha}","languages_url":"https://api.github.com/repos/palantir/plottable/languages","stargazers_url":"https://api.github.com/repos/palantir/plottable/stargazers","contributors_url":"https://api.github.com/repos/palantir/plottable/contributors","subscribers_url":"https://api.github.com/repos/palantir/plottable/subscribers","subscription_url":"https://api.github.com/repos/palantir/plottable/subscription","commits_url":"https://api.github.com/repos/palantir/plottable/commits{/sha}","git_commits_url":"https://api.github.com/repos/palantir/plottable/git/commits{/sha}","comments_url":"https://api.github.com/repos/palantir/plottable/comments{/number}","issue_comment_url":"https://api.github.com/repos/palantir/plottable/issues/comments/{number}","contents_url":"https://api.github.com/repos/palantir/plottable/contents/{+path}","compare_url":"https://api.github.com/repos/palantir/plottable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/palantir/plottable/merges","archive_url":"https://api.github.com/repos/palantir/plottable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/palantir/plottable/downloads","issues_url":"https://api.github.com/repos/palantir/plottable/issues{/number}","pulls_url":"https://api.github.com/repos/palantir/plottable/pulls{/number}","milestones_url":"https://api.github.com/repos/palantir/plottable/milestones{/number}","notifications_url":"https://api.github.com/repos/palantir/plottable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/palantir/plottable/labels{/name}","releases_url":"https://api.github.com/repos/palantir/plottable/releases{/id}","created_at":"2014-01-22T19:29:19Z","updated_at":"2014-06-19T21:46:51Z","pushed_at":"2014-06-19T21:46:04Z","git_url":"git://github.com/palantir/plottable.git","ssh_url":"git@github.com:palantir/plottable.git","clone_url":"https://github.com/palantir/plottable.git","svn_url":"https://github.com/palantir/plottable","homepage":"palantir.github.io/plottable","size":25777,"stargazers_count":22,"watchers_count":22,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":5,"mirror_url":null,"open_issues_count":69,"forks":5,"open_issues":69,"watchers":22,"default_branch":"master"}},"base":{"label":"palantir:master","ref":"master","sha":"d5869f5f7912a4f91add8b8085d22262a0506b60","user":{"login":"palantir","id":303157,"avatar_url":"https://avatars.githubusercontent.com/u/303157?","gravatar_id":"c593136bf7c6a139280354bfc1448a14","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"repo":{"id":16149854,"name":"plottable","full_name":"palantir/plottable","owner":{"login":"palantir","id":303157,"avatar_url":"https://avatars.githubusercontent.com/u/303157?","gravatar_id":"c593136bf7c6a139280354bfc1448a14","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/palantir/plottable","description":"A library for creating interactive charts within a grid layout.","fork":false,"url":"https://api.github.com/repos/palantir/plottable","forks_url":"https://api.github.com/repos/palantir/plottable/forks","keys_url":"https://api.github.com/repos/palantir/plottable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/palantir/plottable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/palantir/plottable/teams","hooks_url":"https://api.github.com/repos/palantir/plottable/hooks","issue_events_url":"https://api.github.com/repos/palantir/plottable/issues/events{/number}","events_url":"https://api.github.com/repos/palantir/plottable/events","assignees_url":"https://api.github.com/repos/palantir/plottable/assignees{/user}","branches_url":"https://api.github.com/repos/palantir/plottable/branches{/branch}","tags_url":"https://api.github.com/repos/palantir/plottable/tags","blobs_url":"https://api.github.com/repos/palantir/plottable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/palantir/plottable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/palantir/plottable/git/refs{/sha}","trees_url":"https://api.github.com/repos/palantir/plottable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/palantir/plottable/statuses/{sha}","languages_url":"https://api.github.com/repos/palantir/plottable/languages","stargazers_url":"https://api.github.com/repos/palantir/plottable/stargazers","contributors_url":"https://api.github.com/repos/palantir/plottable/contributors","subscribers_url":"https://api.github.com/repos/palantir/plottable/subscribers","subscription_url":"https://api.github.com/repos/palantir/plottable/subscription","commits_url":"https://api.github.com/repos/palantir/plottable/commits{/sha}","git_commits_url":"https://api.github.com/repos/palantir/plottable/git/commits{/sha}","comments_url":"https://api.github.com/repos/palantir/plottable/comments{/number}","issue_comment_url":"https://api.github.com/repos/palantir/plottable/issues/comments/{number}","contents_url":"https://api.github.com/repos/palantir/plottable/contents/{+path}","compare_url":"https://api.github.com/repos/palantir/plottable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/palantir/plottable/merges","archive_url":"https://api.github.com/repos/palantir/plottable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/palantir/plottable/downloads","issues_url":"https://api.github.com/repos/palantir/plottable/issues{/number}","pulls_url":"https://api.github.com/repos/palantir/plottable/pulls{/number}","milestones_url":"https://api.github.com/repos/palantir/plottable/milestones{/number}","notifications_url":"https://api.github.com/repos/palantir/plottable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/palantir/plottable/labels{/name}","releases_url":"https://api.github.com/repos/palantir/plottable/releases{/id}","created_at":"2014-01-22T19:29:19Z","updated_at":"2014-06-19T21:46:51Z","pushed_at":"2014-06-19T21:46:04Z","git_url":"git://github.com/palantir/plottable.git","ssh_url":"git@github.com:palantir/plottable.git","clone_url":"https://github.com/palantir/plottable.git","svn_url":"https://github.com/palantir/plottable","homepage":"palantir.github.io/plottable","size":25777,"stargazers_count":22,"watchers_count":22,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":5,"mirror_url":null,"open_issues_count":69,"forks":5,"open_issues":69,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/palantir/plottable/pulls/570"},"html":{"href":"https://github.com/palantir/plottable/pull/570"},"issue":{"href":"https://api.github.com/repos/palantir/plottable/issues/570"},"comments":{"href":"https://api.github.com/repos/palantir/plottable/issues/570/comments"},"review_comments":{"href":"https://api.github.com/repos/palantir/plottable/pulls/570/comments"},"review_comment":{"href":"https://api.github.com/repos/palantir/plottable/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/palantir/plottable/pulls/570/commits"},"statuses":{"href":"https://api.github.com/repos/palantir/plottable/statuses/1e26d5dc1ac4f7ab552f0ef3f752873fee22242a"}}}}