GitHub PullRequestReviewCommentEvent at 2014-09-17 11:17:56
Repository: doorkeeper
Actor: jasl
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/pulls/comments/17658146","id":17658146,"diff_hunk":"@@ -15,26 +15,16 @@ def self.configuration\n     @config || (fail MissingConfiguration.new)\n   end\n \n-  def self.orm_model_dir\n-    case configuration.orm\n-    when :mongoid3, :mongoid4\n-      'mongoid3_4'\n-    else\n-      configuration.orm\n-    end\n-  end\n-\n   def self.enable_orm\n-    require \"doorkeeper/models/#{orm_model_dir}/access_grant\"\n-    require \"doorkeeper/models/#{orm_model_dir}/access_token\"\n-    require \"doorkeeper/models/#{orm_model_dir}/application\"\n-    require 'doorkeeper/models/access_grant'\n-    require 'doorkeeper/models/access_token'\n-    require 'doorkeeper/models/application'\n+    # using Orm namespace to prevent some class finding problem\n+    require \"doorkeeper/orm/#{configuration.orm}\"\n+    \"doorkeeper/orm/#{configuration.orm}\".classify.constantize.initialize_models!\n+  rescue => e\n+    fail e, \"Doorkeeper: ORM adapter not found (#{configuration.orm}). You probably need to add the related gem.\"","path":"lib/doorkeeper/config.rb","position":24,"original_position":24,"commit_id":"c61c20b440131c8cd089a570b44b36483de10613","original_commit_id":"c61c20b440131c8cd089a570b44b36483de10613","user":{"login":"jasl","id":1024162,"avatar_url":"https://avatars.githubusercontent.com/u/1024162?v=2","gravatar_id":"ae099ab1f5877a54cb8f2133b6a2af62","url":"https://api.github.com/users/jasl","html_url":"https://github.com/jasl","followers_url":"https://api.github.com/users/jasl/followers","following_url":"https://api.github.com/users/jasl/following{/other_user}","gists_url":"https://api.github.com/users/jasl/gists{/gist_id}","starred_url":"https://api.github.com/users/jasl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasl/subscriptions","organizations_url":"https://api.github.com/users/jasl/orgs","repos_url":"https://api.github.com/users/jasl/repos","events_url":"https://api.github.com/users/jasl/events{/privacy}","received_events_url":"https://api.github.com/users/jasl/received_events","type":"User","site_admin":false},"body":"Or we just rescue `LoadError`? ","created_at":"2014-09-17T11:17:56Z","updated_at":"2014-09-17T11:17:56Z","html_url":"https://github.com/doorkeeper-gem/doorkeeper/pull/478#discussion_r17658146","pull_request_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/pulls/478","_links":{"self":{"href":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/pulls/comments/17658146"},"html":{"href":"https://github.com/doorkeeper-gem/doorkeeper/pull/478#discussion_r17658146"},"pull_request":{"href":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/pulls/478"}}},"pull_request":{"url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/pulls/478","id":20851629,"html_url":"https://github.com/doorkeeper-gem/doorkeeper/pull/478","diff_url":"https://github.com/doorkeeper-gem/doorkeeper/pull/478.diff","patch_url":"https://github.com/doorkeeper-gem/doorkeeper/pull/478.patch","issue_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/issues/478","number":478,"state":"open","locked":false,"title":"Extract ORM specifics","user":{"login":"jasl","id":1024162,"avatar_url":"https://avatars.githubusercontent.com/u/1024162?v=2","gravatar_id":"ae099ab1f5877a54cb8f2133b6a2af62","url":"https://api.github.com/users/jasl","html_url":"https://github.com/jasl","followers_url":"https://api.github.com/users/jasl/followers","following_url":"https://api.github.com/users/jasl/following{/other_user}","gists_url":"https://api.github.com/users/jasl/gists{/gist_id}","starred_url":"https://api.github.com/users/jasl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasl/subscriptions","organizations_url":"https://api.github.com/users/jasl/orgs","repos_url":"https://api.github.com/users/jasl/repos","events_url":"https://api.github.com/users/jasl/events{/privacy}","received_events_url":"https://api.github.com/users/jasl/received_events","type":"User","site_admin":false},"body":"rework of PR #454\r\n\r\nORM specifics except Active Record has extracted to [doorkeeper_bundle](https://github.com/jasl/doorkeeper_bundle) (not push to rubygems yet)","created_at":"2014-09-06T18:27:38Z","updated_at":"2014-09-17T11:17:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2ef58b498f494eaf917e4d646d2fde2ba61cf71a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/pulls/478/commits","review_comments_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/pulls/478/comments","review_comment_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/pulls/comments/{number}","comments_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/issues/478/comments","statuses_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/statuses/c61c20b440131c8cd089a570b44b36483de10613","head":{"label":"jasl:extract-orm-specifics","ref":"extract-orm-specifics","sha":"c61c20b440131c8cd089a570b44b36483de10613","user":{"login":"jasl","id":1024162,"avatar_url":"https://avatars.githubusercontent.com/u/1024162?v=2","gravatar_id":"ae099ab1f5877a54cb8f2133b6a2af62","url":"https://api.github.com/users/jasl","html_url":"https://github.com/jasl","followers_url":"https://api.github.com/users/jasl/followers","following_url":"https://api.github.com/users/jasl/following{/other_user}","gists_url":"https://api.github.com/users/jasl/gists{/gist_id}","starred_url":"https://api.github.com/users/jasl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasl/subscriptions","organizations_url":"https://api.github.com/users/jasl/orgs","repos_url":"https://api.github.com/users/jasl/repos","events_url":"https://api.github.com/users/jasl/events{/privacy}","received_events_url":"https://api.github.com/users/jasl/received_events","type":"User","site_admin":false},"repo":{"id":15069466,"name":"doorkeeper","full_name":"jasl/doorkeeper","owner":{"login":"jasl","id":1024162,"avatar_url":"https://avatars.githubusercontent.com/u/1024162?v=2","gravatar_id":"ae099ab1f5877a54cb8f2133b6a2af62","url":"https://api.github.com/users/jasl","html_url":"https://github.com/jasl","followers_url":"https://api.github.com/users/jasl/followers","following_url":"https://api.github.com/users/jasl/following{/other_user}","gists_url":"https://api.github.com/users/jasl/gists{/gist_id}","starred_url":"https://api.github.com/users/jasl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasl/subscriptions","organizations_url":"https://api.github.com/users/jasl/orgs","repos_url":"https://api.github.com/users/jasl/repos","events_url":"https://api.github.com/users/jasl/events{/privacy}","received_events_url":"https://api.github.com/users/jasl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jasl/doorkeeper","description":"Doorkeeper is an OAuth 2 provider for Rails.","fork":true,"url":"https://api.github.com/repos/jasl/doorkeeper","forks_url":"https://api.github.com/repos/jasl/doorkeeper/forks","keys_url":"https://api.github.com/repos/jasl/doorkeeper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jasl/doorkeeper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jasl/doorkeeper/teams","hooks_url":"https://api.github.com/repos/jasl/doorkeeper/hooks","issue_events_url":"https://api.github.com/repos/jasl/doorkeeper/issues/events{/number}","events_url":"https://api.github.com/repos/jasl/doorkeeper/events","assignees_url":"https://api.github.com/repos/jasl/doorkeeper/assignees{/user}","branches_url":"https://api.github.com/repos/jasl/doorkeeper/branches{/branch}","tags_url":"https://api.github.com/repos/jasl/doorkeeper/tags","blobs_url":"https://api.github.com/repos/jasl/doorkeeper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jasl/doorkeeper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jasl/doorkeeper/git/refs{/sha}","trees_url":"https://api.github.com/repos/jasl/doorkeeper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jasl/doorkeeper/statuses/{sha}","languages_url":"https://api.github.com/repos/jasl/doorkeeper/languages","stargazers_url":"https://api.github.com/repos/jasl/doorkeeper/stargazers","contributors_url":"https://api.github.com/repos/jasl/doorkeeper/contributors","subscribers_url":"https://api.github.com/repos/jasl/doorkeeper/subscribers","subscription_url":"https://api.github.com/repos/jasl/doorkeeper/subscription","commits_url":"https://api.github.com/repos/jasl/doorkeeper/commits{/sha}","git_commits_url":"https://api.github.com/repos/jasl/doorkeeper/git/commits{/sha}","comments_url":"https://api.github.com/repos/jasl/doorkeeper/comments{/number}","issue_comment_url":"https://api.github.com/repos/jasl/doorkeeper/issues/comments/{number}","contents_url":"https://api.github.com/repos/jasl/doorkeeper/contents/{+path}","compare_url":"https://api.github.com/repos/jasl/doorkeeper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jasl/doorkeeper/merges","archive_url":"https://api.github.com/repos/jasl/doorkeeper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jasl/doorkeeper/downloads","issues_url":"https://api.github.com/repos/jasl/doorkeeper/issues{/number}","pulls_url":"https://api.github.com/repos/jasl/doorkeeper/pulls{/number}","milestones_url":"https://api.github.com/repos/jasl/doorkeeper/milestones{/number}","notifications_url":"https://api.github.com/repos/jasl/doorkeeper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jasl/doorkeeper/labels{/name}","releases_url":"https://api.github.com/repos/jasl/doorkeeper/releases{/id}","created_at":"2013-12-10T06:55:43Z","updated_at":"2014-08-02T07:34:36Z","pushed_at":"2014-09-17T08:41:04Z","git_url":"git://github.com/jasl/doorkeeper.git","ssh_url":"git@github.com:jasl/doorkeeper.git","clone_url":"https://github.com/jasl/doorkeeper.git","svn_url":"https://github.com/jasl/doorkeeper","homepage":"https://github.com/applicake/doorkeeper","size":2686,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"doorkeeper-gem:master","ref":"master","sha":"9e64042a5862e72343cf25dd2a69cfa0cb64f43d","user":{"login":"doorkeeper-gem","id":7275750,"avatar_url":"https://avatars.githubusercontent.com/u/7275750?v=2","gravatar_id":null,"url":"https://api.github.com/users/doorkeeper-gem","html_url":"https://github.com/doorkeeper-gem","followers_url":"https://api.github.com/users/doorkeeper-gem/followers","following_url":"https://api.github.com/users/doorkeeper-gem/following{/other_user}","gists_url":"https://api.github.com/users/doorkeeper-gem/gists{/gist_id}","starred_url":"https://api.github.com/users/doorkeeper-gem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doorkeeper-gem/subscriptions","organizations_url":"https://api.github.com/users/doorkeeper-gem/orgs","repos_url":"https://api.github.com/users/doorkeeper-gem/repos","events_url":"https://api.github.com/users/doorkeeper-gem/events{/privacy}","received_events_url":"https://api.github.com/users/doorkeeper-gem/received_events","type":"Organization","site_admin":false},"repo":{"id":2802565,"name":"doorkeeper","full_name":"doorkeeper-gem/doorkeeper","owner":{"login":"doorkeeper-gem","id":7275750,"avatar_url":"https://avatars.githubusercontent.com/u/7275750?v=2","gravatar_id":null,"url":"https://api.github.com/users/doorkeeper-gem","html_url":"https://github.com/doorkeeper-gem","followers_url":"https://api.github.com/users/doorkeeper-gem/followers","following_url":"https://api.github.com/users/doorkeeper-gem/following{/other_user}","gists_url":"https://api.github.com/users/doorkeeper-gem/gists{/gist_id}","starred_url":"https://api.github.com/users/doorkeeper-gem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doorkeeper-gem/subscriptions","organizations_url":"https://api.github.com/users/doorkeeper-gem/orgs","repos_url":"https://api.github.com/users/doorkeeper-gem/repos","events_url":"https://api.github.com/users/doorkeeper-gem/events{/privacy}","received_events_url":"https://api.github.com/users/doorkeeper-gem/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/doorkeeper-gem/doorkeeper","description":"Doorkeeper is an OAuth 2 provider for Rails.","fork":false,"url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper","forks_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/forks","keys_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/teams","hooks_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/hooks","issue_events_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/issues/events{/number}","events_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/events","assignees_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/assignees{/user}","branches_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/branches{/branch}","tags_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/tags","blobs_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/git/refs{/sha}","trees_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/statuses/{sha}","languages_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/languages","stargazers_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/stargazers","contributors_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/contributors","subscribers_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/subscribers","subscription_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/subscription","commits_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/commits{/sha}","git_commits_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/git/commits{/sha}","comments_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/comments{/number}","issue_comment_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/issues/comments/{number}","contents_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/contents/{+path}","compare_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/merges","archive_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/downloads","issues_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/issues{/number}","pulls_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/pulls{/number}","milestones_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/milestones{/number}","notifications_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/labels{/name}","releases_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/releases{/id}","created_at":"2011-11-18T13:02:01Z","updated_at":"2014-09-17T01:58:40Z","pushed_at":"2014-09-07T17:00:00Z","git_url":"git://github.com/doorkeeper-gem/doorkeeper.git","ssh_url":"git@github.com:doorkeeper-gem/doorkeeper.git","clone_url":"https://github.com/doorkeeper-gem/doorkeeper.git","svn_url":"https://github.com/doorkeeper-gem/doorkeeper","homepage":"https://github.com/doorkeeper-gem/doorkeeper","size":7837,"stargazers_count":1685,"watchers_count":1685,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":377,"mirror_url":null,"open_issues_count":13,"forks":377,"open_issues":13,"watchers":1685,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/pulls/478"},"html":{"href":"https://github.com/doorkeeper-gem/doorkeeper/pull/478"},"issue":{"href":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/issues/478"},"comments":{"href":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/issues/478/comments"},"review_comments":{"href":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/pulls/478/comments"},"review_comment":{"href":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/pulls/478/commits"},"statuses":{"href":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/statuses/c61c20b440131c8cd089a570b44b36483de10613"}}}}