GitHub PullRequestEvent at 2014-02-14 17:35:14
Repository: amqp-client
Actor: sstone
Payload: {"action":"closed","number":32,"pull_request":{"url":"https://api.github.com/repos/sstone/amqp-client/pulls/32","id":12221086,"html_url":"https://github.com/sstone/amqp-client/pull/32","diff_url":"https://github.com/sstone/amqp-client/pull/32.diff","patch_url":"https://github.com/sstone/amqp-client/pull/32.patch","issue_url":"https://api.github.com/repos/sstone/amqp-client/issues/32","number":32,"state":"closed","title":"Remove temporary watcher as a listener when it is stopped","user":{"login":"ljcoomber","id":348068,"avatar_url":"https://gravatar.com/avatar/a325e7330f64d2cb796d5311dd087aea?d=https%3A%2F%2Fidenticons.github.com%2Ff2b8887c37602fc6a688c49e57648c18.png&r=x","gravatar_id":"a325e7330f64d2cb796d5311dd087aea","url":"https://api.github.com/users/ljcoomber","html_url":"https://github.com/ljcoomber","followers_url":"https://api.github.com/users/ljcoomber/followers","following_url":"https://api.github.com/users/ljcoomber/following{/other_user}","gists_url":"https://api.github.com/users/ljcoomber/gists{/gist_id}","starred_url":"https://api.github.com/users/ljcoomber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ljcoomber/subscriptions","organizations_url":"https://api.github.com/users/ljcoomber/orgs","repos_url":"https://api.github.com/users/ljcoomber/repos","events_url":"https://api.github.com/users/ljcoomber/events{/privacy}","received_events_url":"https://api.github.com/users/ljcoomber/received_events","type":"User","site_admin":false},"body":"The temporary actor used as a watcher on the channel / connection remains as a status listener, even after it has been stopped. AFAICT this doesn't break anything, but it does mean we see dead lettered messages when a connection or channel closes.\r\n\r\nThis PR removes the listener when stopping the actor.","created_at":"2014-02-05T13:19:58Z","updated_at":"2014-02-14T17:35:14Z","closed_at":"2014-02-14T17:35:14Z","merged_at":"2014-02-14T17:35:14Z","merge_commit_sha":"c74f51b428b05d55fd1d31eb94705e2c1e4db2b5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sstone/amqp-client/pulls/32/commits","review_comments_url":"https://api.github.com/repos/sstone/amqp-client/pulls/32/comments","review_comment_url":"https://api.github.com/repos/sstone/amqp-client/pulls/comments/{number}","comments_url":"https://api.github.com/repos/sstone/amqp-client/issues/32/comments","statuses_url":"https://api.github.com/repos/sstone/amqp-client/statuses/743422d899c61ae3f55d817ac80fc50e1f451f20","head":{"label":"ljcoomber:reconnect-tidyup","ref":"reconnect-tidyup","sha":"743422d899c61ae3f55d817ac80fc50e1f451f20","user":{"login":"ljcoomber","id":348068,"avatar_url":"https://gravatar.com/avatar/a325e7330f64d2cb796d5311dd087aea?d=https%3A%2F%2Fidenticons.github.com%2Ff2b8887c37602fc6a688c49e57648c18.png&r=x","gravatar_id":"a325e7330f64d2cb796d5311dd087aea","url":"https://api.github.com/users/ljcoomber","html_url":"https://github.com/ljcoomber","followers_url":"https://api.github.com/users/ljcoomber/followers","following_url":"https://api.github.com/users/ljcoomber/following{/other_user}","gists_url":"https://api.github.com/users/ljcoomber/gists{/gist_id}","starred_url":"https://api.github.com/users/ljcoomber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ljcoomber/subscriptions","organizations_url":"https://api.github.com/users/ljcoomber/orgs","repos_url":"https://api.github.com/users/ljcoomber/repos","events_url":"https://api.github.com/users/ljcoomber/events{/privacy}","received_events_url":"https://api.github.com/users/ljcoomber/received_events","type":"User","site_admin":false},"repo":{"id":16053072,"name":"amqp-client","full_name":"ljcoomber/amqp-client","owner":{"login":"ljcoomber","id":348068,"avatar_url":"https://gravatar.com/avatar/a325e7330f64d2cb796d5311dd087aea?d=https%3A%2F%2Fidenticons.github.com%2Ff2b8887c37602fc6a688c49e57648c18.png&r=x","gravatar_id":"a325e7330f64d2cb796d5311dd087aea","url":"https://api.github.com/users/ljcoomber","html_url":"https://github.com/ljcoomber","followers_url":"https://api.github.com/users/ljcoomber/followers","following_url":"https://api.github.com/users/ljcoomber/following{/other_user}","gists_url":"https://api.github.com/users/ljcoomber/gists{/gist_id}","starred_url":"https://api.github.com/users/ljcoomber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ljcoomber/subscriptions","organizations_url":"https://api.github.com/users/ljcoomber/orgs","repos_url":"https://api.github.com/users/ljcoomber/repos","events_url":"https://api.github.com/users/ljcoomber/events{/privacy}","received_events_url":"https://api.github.com/users/ljcoomber/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ljcoomber/amqp-client","description":"Simple fault-tolerant AMQP client written in Scala and based on Akka and the RabbitMQ java client","fork":true,"url":"https://api.github.com/repos/ljcoomber/amqp-client","forks_url":"https://api.github.com/repos/ljcoomber/amqp-client/forks","keys_url":"https://api.github.com/repos/ljcoomber/amqp-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ljcoomber/amqp-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ljcoomber/amqp-client/teams","hooks_url":"https://api.github.com/repos/ljcoomber/amqp-client/hooks","issue_events_url":"https://api.github.com/repos/ljcoomber/amqp-client/issues/events{/number}","events_url":"https://api.github.com/repos/ljcoomber/amqp-client/events","assignees_url":"https://api.github.com/repos/ljcoomber/amqp-client/assignees{/user}","branches_url":"https://api.github.com/repos/ljcoomber/amqp-client/branches{/branch}","tags_url":"https://api.github.com/repos/ljcoomber/amqp-client/tags","blobs_url":"https://api.github.com/repos/ljcoomber/amqp-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ljcoomber/amqp-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ljcoomber/amqp-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/ljcoomber/amqp-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ljcoomber/amqp-client/statuses/{sha}","languages_url":"https://api.github.com/repos/ljcoomber/amqp-client/languages","stargazers_url":"https://api.github.com/repos/ljcoomber/amqp-client/stargazers","contributors_url":"https://api.github.com/repos/ljcoomber/amqp-client/contributors","subscribers_url":"https://api.github.com/repos/ljcoomber/amqp-client/subscribers","subscription_url":"https://api.github.com/repos/ljcoomber/amqp-client/subscription","commits_url":"https://api.github.com/repos/ljcoomber/amqp-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/ljcoomber/amqp-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/ljcoomber/amqp-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/ljcoomber/amqp-client/issues/comments/{number}","contents_url":"https://api.github.com/repos/ljcoomber/amqp-client/contents/{+path}","compare_url":"https://api.github.com/repos/ljcoomber/amqp-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ljcoomber/amqp-client/merges","archive_url":"https://api.github.com/repos/ljcoomber/amqp-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ljcoomber/amqp-client/downloads","issues_url":"https://api.github.com/repos/ljcoomber/amqp-client/issues{/number}","pulls_url":"https://api.github.com/repos/ljcoomber/amqp-client/pulls{/number}","milestones_url":"https://api.github.com/repos/ljcoomber/amqp-client/milestones{/number}","notifications_url":"https://api.github.com/repos/ljcoomber/amqp-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ljcoomber/amqp-client/labels{/name}","releases_url":"https://api.github.com/repos/ljcoomber/amqp-client/releases{/id}","created_at":"2014-01-19T19:56:22Z","updated_at":"2014-02-14T17:35:14Z","pushed_at":"2014-02-12T21:47:21Z","git_url":"git://github.com/ljcoomber/amqp-client.git","ssh_url":"git@github.com:ljcoomber/amqp-client.git","clone_url":"https://github.com/ljcoomber/amqp-client.git","svn_url":"https://github.com/ljcoomber/amqp-client","homepage":"","size":375,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"scala2.10","master_branch":"scala2.10"}},"base":{"label":"sstone:scala2.10","ref":"scala2.10","sha":"ae19514d77e198c317d07c4ea9de713e82f07b48","user":{"login":"sstone","id":1573866,"avatar_url":"https://gravatar.com/avatar/28a802c763a30ee8cc540ccf7b67b69b?d=https%3A%2F%2Fidenticons.github.com%2Fec38d90ce15f20ccba50175e897b5056.png&r=x","gravatar_id":"28a802c763a30ee8cc540ccf7b67b69b","url":"https://api.github.com/users/sstone","html_url":"https://github.com/sstone","followers_url":"https://api.github.com/users/sstone/followers","following_url":"https://api.github.com/users/sstone/following{/other_user}","gists_url":"https://api.github.com/users/sstone/gists{/gist_id}","starred_url":"https://api.github.com/users/sstone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sstone/subscriptions","organizations_url":"https://api.github.com/users/sstone/orgs","repos_url":"https://api.github.com/users/sstone/repos","events_url":"https://api.github.com/users/sstone/events{/privacy}","received_events_url":"https://api.github.com/users/sstone/received_events","type":"User","site_admin":false},"repo":{"id":3826280,"name":"amqp-client","full_name":"sstone/amqp-client","owner":{"login":"sstone","id":1573866,"avatar_url":"https://gravatar.com/avatar/28a802c763a30ee8cc540ccf7b67b69b?d=https%3A%2F%2Fidenticons.github.com%2Fec38d90ce15f20ccba50175e897b5056.png&r=x","gravatar_id":"28a802c763a30ee8cc540ccf7b67b69b","url":"https://api.github.com/users/sstone","html_url":"https://github.com/sstone","followers_url":"https://api.github.com/users/sstone/followers","following_url":"https://api.github.com/users/sstone/following{/other_user}","gists_url":"https://api.github.com/users/sstone/gists{/gist_id}","starred_url":"https://api.github.com/users/sstone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sstone/subscriptions","organizations_url":"https://api.github.com/users/sstone/orgs","repos_url":"https://api.github.com/users/sstone/repos","events_url":"https://api.github.com/users/sstone/events{/privacy}","received_events_url":"https://api.github.com/users/sstone/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sstone/amqp-client","description":"Simple fault-tolerant AMQP client written in Scala and based on Akka and the RabbitMQ java client","fork":false,"url":"https://api.github.com/repos/sstone/amqp-client","forks_url":"https://api.github.com/repos/sstone/amqp-client/forks","keys_url":"https://api.github.com/repos/sstone/amqp-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sstone/amqp-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sstone/amqp-client/teams","hooks_url":"https://api.github.com/repos/sstone/amqp-client/hooks","issue_events_url":"https://api.github.com/repos/sstone/amqp-client/issues/events{/number}","events_url":"https://api.github.com/repos/sstone/amqp-client/events","assignees_url":"https://api.github.com/repos/sstone/amqp-client/assignees{/user}","branches_url":"https://api.github.com/repos/sstone/amqp-client/branches{/branch}","tags_url":"https://api.github.com/repos/sstone/amqp-client/tags","blobs_url":"https://api.github.com/repos/sstone/amqp-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sstone/amqp-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sstone/amqp-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/sstone/amqp-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sstone/amqp-client/statuses/{sha}","languages_url":"https://api.github.com/repos/sstone/amqp-client/languages","stargazers_url":"https://api.github.com/repos/sstone/amqp-client/stargazers","contributors_url":"https://api.github.com/repos/sstone/amqp-client/contributors","subscribers_url":"https://api.github.com/repos/sstone/amqp-client/subscribers","subscription_url":"https://api.github.com/repos/sstone/amqp-client/subscription","commits_url":"https://api.github.com/repos/sstone/amqp-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/sstone/amqp-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/sstone/amqp-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/sstone/amqp-client/issues/comments/{number}","contents_url":"https://api.github.com/repos/sstone/amqp-client/contents/{+path}","compare_url":"https://api.github.com/repos/sstone/amqp-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sstone/amqp-client/merges","archive_url":"https://api.github.com/repos/sstone/amqp-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sstone/amqp-client/downloads","issues_url":"https://api.github.com/repos/sstone/amqp-client/issues{/number}","pulls_url":"https://api.github.com/repos/sstone/amqp-client/pulls{/number}","milestones_url":"https://api.github.com/repos/sstone/amqp-client/milestones{/number}","notifications_url":"https://api.github.com/repos/sstone/amqp-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sstone/amqp-client/labels{/name}","releases_url":"https://api.github.com/repos/sstone/amqp-client/releases{/id}","created_at":"2012-03-25T18:28:48Z","updated_at":"2014-02-14T17:35:14Z","pushed_at":"2014-02-14T17:35:14Z","git_url":"git://github.com/sstone/amqp-client.git","ssh_url":"git@github.com:sstone/amqp-client.git","clone_url":"https://github.com/sstone/amqp-client.git","svn_url":"https://github.com/sstone/amqp-client","homepage":"","size":862,"stargazers_count":38,"watchers_count":38,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":31,"mirror_url":null,"open_issues_count":7,"forks":31,"open_issues":7,"watchers":38,"default_branch":"scala2.10","master_branch":"scala2.10"}},"_links":{"self":{"href":"https://api.github.com/repos/sstone/amqp-client/pulls/32"},"html":{"href":"https://github.com/sstone/amqp-client/pull/32"},"issue":{"href":"https://api.github.com/repos/sstone/amqp-client/issues/32"},"comments":{"href":"https://api.github.com/repos/sstone/amqp-client/issues/32/comments"},"review_comments":{"href":"https://api.github.com/repos/sstone/amqp-client/pulls/32/comments"},"review_comment":{"href":"https://api.github.com/repos/sstone/amqp-client/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/sstone/amqp-client/pulls/32/commits"},"statuses":{"href":"https://api.github.com/repos/sstone/amqp-client/statuses/743422d899c61ae3f55d817ac80fc50e1f451f20"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"sstone","id":1573866,"avatar_url":"https://gravatar.com/avatar/28a802c763a30ee8cc540ccf7b67b69b?d=https%3A%2F%2Fidenticons.github.com%2Fec38d90ce15f20ccba50175e897b5056.png&r=x","gravatar_id":"28a802c763a30ee8cc540ccf7b67b69b","url":"https://api.github.com/users/sstone","html_url":"https://github.com/sstone","followers_url":"https://api.github.com/users/sstone/followers","following_url":"https://api.github.com/users/sstone/following{/other_user}","gists_url":"https://api.github.com/users/sstone/gists{/gist_id}","starred_url":"https://api.github.com/users/sstone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sstone/subscriptions","organizations_url":"https://api.github.com/users/sstone/orgs","repos_url":"https://api.github.com/users/sstone/repos","events_url":"https://api.github.com/users/sstone/events{/privacy}","received_events_url":"https://api.github.com/users/sstone/received_events","type":"User","site_admin":false},"comments":5,"review_comments":0,"commits":4,"additions":61,"deletions":11,"changed_files":3}}