GitHub PullRequestEvent at 2014-04-26 14:55:35
Repository: ix
Actor: ralphos
Payload: {"action":"closed","number":5,"pull_request":{"url":"https://api.github.com/repos/ralphos/ix/pulls/5","id":15203038,"html_url":"https://github.com/ralphos/ix/pull/5","diff_url":"https://github.com/ralphos/ix/pull/5.diff","patch_url":"https://github.com/ralphos/ix/pull/5.patch","issue_url":"https://api.github.com/repos/ralphos/ix/issues/5","number":5,"state":"closed","title":"Rw/seller sees new auction","user":{"login":"ralphos","id":665348,"avatar_url":"https://avatars.githubusercontent.com/u/665348?","gravatar_id":"ee54cd7f78e92ed71ee174cf9b07a3e9","url":"https://api.github.com/users/ralphos","html_url":"https://github.com/ralphos","followers_url":"https://api.github.com/users/ralphos/followers","following_url":"https://api.github.com/users/ralphos/following{/other_user}","gists_url":"https://api.github.com/users/ralphos/gists{/gist_id}","starred_url":"https://api.github.com/users/ralphos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ralphos/subscriptions","organizations_url":"https://api.github.com/users/ralphos/orgs","repos_url":"https://api.github.com/users/ralphos/repos","events_url":"https://api.github.com/users/ralphos/events{/privacy}","received_events_url":"https://api.github.com/users/ralphos/received_events","type":"User","site_admin":false},"body":"### What's this PR do?\r\n\r\nThis PR allows for sellers to register Debtors in the system - to be approved by the admin. The concept of a debtor is a business that owes money to the company. For instance, they have agreed to purchase a set of goods, and thus an invoice has been issued to which the Debtor owes the balance (of the invoice) the company that has sold it.\r\n\r\nIn order to create an auction on IX, the Seller needs to register their debtors and wait for approval by the admin. Once approved, the debtor should see 'approved debtors' in the new auction page.\r\n\r\n### Where should the reviewer start?\r\n\r\nThe `app/views/auctions/new` is the starting place for this feature. It shows approved and pending debtors. If there are no approved debtors, the seller can register a new debtor. This begins the process of creating the debtor with a default status of 'pending'.\r\n\r\nAs you'll see, the Admin can approve the Debtor in ActiveAdmin, after which the Seller will see their debtor as approved.\r\n\r\n### Any background context?\r\n\r\nThe Debtors are essentially a reference for the admin to determine whether the invoice (directly associated with the debtor) is worthy of posting on IX for auction. As a result, the Debtor model has a lot of informational attributes - which I'm probably going to keep in one table, since the Seller will likely always have to fill out all fields to create a debtor. ","created_at":"2014-04-26T14:47:46Z","updated_at":"2014-04-26T14:55:35Z","closed_at":"2014-04-26T14:55:35Z","merged_at":"2014-04-26T14:55:35Z","merge_commit_sha":"1690aed43a4c9e5d9668f56e714377246d47dfc4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ralphos/ix/pulls/5/commits","review_comments_url":"https://api.github.com/repos/ralphos/ix/pulls/5/comments","review_comment_url":"https://api.github.com/repos/ralphos/ix/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ralphos/ix/issues/5/comments","statuses_url":"https://api.github.com/repos/ralphos/ix/statuses/cc32387faab9791f8bf40ea2d923d97ca347cd12","head":{"label":"ralphos:rw/seller-sees-new-auction","ref":"rw/seller-sees-new-auction","sha":"cc32387faab9791f8bf40ea2d923d97ca347cd12","user":{"login":"ralphos","id":665348,"avatar_url":"https://avatars.githubusercontent.com/u/665348?","gravatar_id":"ee54cd7f78e92ed71ee174cf9b07a3e9","url":"https://api.github.com/users/ralphos","html_url":"https://github.com/ralphos","followers_url":"https://api.github.com/users/ralphos/followers","following_url":"https://api.github.com/users/ralphos/following{/other_user}","gists_url":"https://api.github.com/users/ralphos/gists{/gist_id}","starred_url":"https://api.github.com/users/ralphos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ralphos/subscriptions","organizations_url":"https://api.github.com/users/ralphos/orgs","repos_url":"https://api.github.com/users/ralphos/repos","events_url":"https://api.github.com/users/ralphos/events{/privacy}","received_events_url":"https://api.github.com/users/ralphos/received_events","type":"User","site_admin":false},"repo":{"id":18173167,"name":"ix","full_name":"ralphos/ix","owner":{"login":"ralphos","id":665348,"avatar_url":"https://avatars.githubusercontent.com/u/665348?","gravatar_id":"ee54cd7f78e92ed71ee174cf9b07a3e9","url":"https://api.github.com/users/ralphos","html_url":"https://github.com/ralphos","followers_url":"https://api.github.com/users/ralphos/followers","following_url":"https://api.github.com/users/ralphos/following{/other_user}","gists_url":"https://api.github.com/users/ralphos/gists{/gist_id}","starred_url":"https://api.github.com/users/ralphos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ralphos/subscriptions","organizations_url":"https://api.github.com/users/ralphos/orgs","repos_url":"https://api.github.com/users/ralphos/repos","events_url":"https://api.github.com/users/ralphos/events{/privacy}","received_events_url":"https://api.github.com/users/ralphos/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ralphos/ix","description":"","fork":false,"url":"https://api.github.com/repos/ralphos/ix","forks_url":"https://api.github.com/repos/ralphos/ix/forks","keys_url":"https://api.github.com/repos/ralphos/ix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ralphos/ix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ralphos/ix/teams","hooks_url":"https://api.github.com/repos/ralphos/ix/hooks","issue_events_url":"https://api.github.com/repos/ralphos/ix/issues/events{/number}","events_url":"https://api.github.com/repos/ralphos/ix/events","assignees_url":"https://api.github.com/repos/ralphos/ix/assignees{/user}","branches_url":"https://api.github.com/repos/ralphos/ix/branches{/branch}","tags_url":"https://api.github.com/repos/ralphos/ix/tags","blobs_url":"https://api.github.com/repos/ralphos/ix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ralphos/ix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ralphos/ix/git/refs{/sha}","trees_url":"https://api.github.com/repos/ralphos/ix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ralphos/ix/statuses/{sha}","languages_url":"https://api.github.com/repos/ralphos/ix/languages","stargazers_url":"https://api.github.com/repos/ralphos/ix/stargazers","contributors_url":"https://api.github.com/repos/ralphos/ix/contributors","subscribers_url":"https://api.github.com/repos/ralphos/ix/subscribers","subscription_url":"https://api.github.com/repos/ralphos/ix/subscription","commits_url":"https://api.github.com/repos/ralphos/ix/commits{/sha}","git_commits_url":"https://api.github.com/repos/ralphos/ix/git/commits{/sha}","comments_url":"https://api.github.com/repos/ralphos/ix/comments{/number}","issue_comment_url":"https://api.github.com/repos/ralphos/ix/issues/comments/{number}","contents_url":"https://api.github.com/repos/ralphos/ix/contents/{+path}","compare_url":"https://api.github.com/repos/ralphos/ix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ralphos/ix/merges","archive_url":"https://api.github.com/repos/ralphos/ix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ralphos/ix/downloads","issues_url":"https://api.github.com/repos/ralphos/ix/issues{/number}","pulls_url":"https://api.github.com/repos/ralphos/ix/pulls{/number}","milestones_url":"https://api.github.com/repos/ralphos/ix/milestones{/number}","notifications_url":"https://api.github.com/repos/ralphos/ix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ralphos/ix/labels{/name}","releases_url":"https://api.github.com/repos/ralphos/ix/releases{/id}","created_at":"2014-03-27T11:09:22Z","updated_at":"2014-04-26T14:55:35Z","pushed_at":"2014-04-26T14:55:35Z","git_url":"git://github.com/ralphos/ix.git","ssh_url":"git@github.com:ralphos/ix.git","clone_url":"https://github.com/ralphos/ix.git","svn_url":"https://github.com/ralphos/ix","homepage":null,"size":14500,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ralphos:master","ref":"master","sha":"c80c4b785cbcf6670b24b02b3ffc1c5e99202319","user":{"login":"ralphos","id":665348,"avatar_url":"https://avatars.githubusercontent.com/u/665348?","gravatar_id":"ee54cd7f78e92ed71ee174cf9b07a3e9","url":"https://api.github.com/users/ralphos","html_url":"https://github.com/ralphos","followers_url":"https://api.github.com/users/ralphos/followers","following_url":"https://api.github.com/users/ralphos/following{/other_user}","gists_url":"https://api.github.com/users/ralphos/gists{/gist_id}","starred_url":"https://api.github.com/users/ralphos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ralphos/subscriptions","organizations_url":"https://api.github.com/users/ralphos/orgs","repos_url":"https://api.github.com/users/ralphos/repos","events_url":"https://api.github.com/users/ralphos/events{/privacy}","received_events_url":"https://api.github.com/users/ralphos/received_events","type":"User","site_admin":false},"repo":{"id":18173167,"name":"ix","full_name":"ralphos/ix","owner":{"login":"ralphos","id":665348,"avatar_url":"https://avatars.githubusercontent.com/u/665348?","gravatar_id":"ee54cd7f78e92ed71ee174cf9b07a3e9","url":"https://api.github.com/users/ralphos","html_url":"https://github.com/ralphos","followers_url":"https://api.github.com/users/ralphos/followers","following_url":"https://api.github.com/users/ralphos/following{/other_user}","gists_url":"https://api.github.com/users/ralphos/gists{/gist_id}","starred_url":"https://api.github.com/users/ralphos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ralphos/subscriptions","organizations_url":"https://api.github.com/users/ralphos/orgs","repos_url":"https://api.github.com/users/ralphos/repos","events_url":"https://api.github.com/users/ralphos/events{/privacy}","received_events_url":"https://api.github.com/users/ralphos/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ralphos/ix","description":"","fork":false,"url":"https://api.github.com/repos/ralphos/ix","forks_url":"https://api.github.com/repos/ralphos/ix/forks","keys_url":"https://api.github.com/repos/ralphos/ix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ralphos/ix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ralphos/ix/teams","hooks_url":"https://api.github.com/repos/ralphos/ix/hooks","issue_events_url":"https://api.github.com/repos/ralphos/ix/issues/events{/number}","events_url":"https://api.github.com/repos/ralphos/ix/events","assignees_url":"https://api.github.com/repos/ralphos/ix/assignees{/user}","branches_url":"https://api.github.com/repos/ralphos/ix/branches{/branch}","tags_url":"https://api.github.com/repos/ralphos/ix/tags","blobs_url":"https://api.github.com/repos/ralphos/ix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ralphos/ix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ralphos/ix/git/refs{/sha}","trees_url":"https://api.github.com/repos/ralphos/ix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ralphos/ix/statuses/{sha}","languages_url":"https://api.github.com/repos/ralphos/ix/languages","stargazers_url":"https://api.github.com/repos/ralphos/ix/stargazers","contributors_url":"https://api.github.com/repos/ralphos/ix/contributors","subscribers_url":"https://api.github.com/repos/ralphos/ix/subscribers","subscription_url":"https://api.github.com/repos/ralphos/ix/subscription","commits_url":"https://api.github.com/repos/ralphos/ix/commits{/sha}","git_commits_url":"https://api.github.com/repos/ralphos/ix/git/commits{/sha}","comments_url":"https://api.github.com/repos/ralphos/ix/comments{/number}","issue_comment_url":"https://api.github.com/repos/ralphos/ix/issues/comments/{number}","contents_url":"https://api.github.com/repos/ralphos/ix/contents/{+path}","compare_url":"https://api.github.com/repos/ralphos/ix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ralphos/ix/merges","archive_url":"https://api.github.com/repos/ralphos/ix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ralphos/ix/downloads","issues_url":"https://api.github.com/repos/ralphos/ix/issues{/number}","pulls_url":"https://api.github.com/repos/ralphos/ix/pulls{/number}","milestones_url":"https://api.github.com/repos/ralphos/ix/milestones{/number}","notifications_url":"https://api.github.com/repos/ralphos/ix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ralphos/ix/labels{/name}","releases_url":"https://api.github.com/repos/ralphos/ix/releases{/id}","created_at":"2014-03-27T11:09:22Z","updated_at":"2014-04-26T14:55:35Z","pushed_at":"2014-04-26T14:55:35Z","git_url":"git://github.com/ralphos/ix.git","ssh_url":"git@github.com:ralphos/ix.git","clone_url":"https://github.com/ralphos/ix.git","svn_url":"https://github.com/ralphos/ix","homepage":null,"size":14500,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ralphos/ix/pulls/5"},"html":{"href":"https://github.com/ralphos/ix/pull/5"},"issue":{"href":"https://api.github.com/repos/ralphos/ix/issues/5"},"comments":{"href":"https://api.github.com/repos/ralphos/ix/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/ralphos/ix/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/ralphos/ix/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ralphos/ix/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/ralphos/ix/statuses/cc32387faab9791f8bf40ea2d923d97ca347cd12"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"ralphos","id":665348,"avatar_url":"https://avatars.githubusercontent.com/u/665348?","gravatar_id":"ee54cd7f78e92ed71ee174cf9b07a3e9","url":"https://api.github.com/users/ralphos","html_url":"https://github.com/ralphos","followers_url":"https://api.github.com/users/ralphos/followers","following_url":"https://api.github.com/users/ralphos/following{/other_user}","gists_url":"https://api.github.com/users/ralphos/gists{/gist_id}","starred_url":"https://api.github.com/users/ralphos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ralphos/subscriptions","organizations_url":"https://api.github.com/users/ralphos/orgs","repos_url":"https://api.github.com/users/ralphos/repos","events_url":"https://api.github.com/users/ralphos/events{/privacy}","received_events_url":"https://api.github.com/users/ralphos/received_events","type":"User","site_admin":false},"comments":0,"review_comments":2,"commits":2,"additions":438,"deletions":2,"changed_files":21}}