GitHub PullRequestReviewCommentEvent at 2014-06-03 18:17:58
Repository: cilantro
Actor: hassanNS
Payload: {"comment":{"url":"https://api.github.com/repos/cbmi/cilantro/pulls/comments/13350123","id":13350123,"diff_hunk":"@@ -100,9 +101,153 @@ define([\n             }\n         },\n \n+        // Function for handling values which are not from the 'range'\n+        // operator. This function creates an appropriate language to represent\n+        // the values.\n+        parseValues: function(values, operator) {\n+            var text= [];\n+            // If the # of values are greater than this threshold, do not show\n+            // them all.\n+            var THRESHOLD = 5;\n+\n+            if (values.length === 1) {\n+                text.push('<span style=\"color:blue\">' + values[0] + '</span>');\n+            }\n+\n+            else if (values.length < THRESHOLD) {\n+                for (var i=0; i < values.length-1; i++) {","path":"src/js/cilantro/ui/context/filters.js","position":28,"original_position":28,"commit_id":"aec16e7aca8fcfa93f0f9eb0ddde9acadab7b1e1","original_commit_id":"aec16e7aca8fcfa93f0f9eb0ddde9acadab7b1e1","user":{"login":"hassanNS","id":2774472,"avatar_url":"https://avatars.githubusercontent.com/u/2774472?","gravatar_id":"b37cae323935014f8bca97cc1069d097","url":"https://api.github.com/users/hassanNS","html_url":"https://github.com/hassanNS","followers_url":"https://api.github.com/users/hassanNS/followers","following_url":"https://api.github.com/users/hassanNS/following{/other_user}","gists_url":"https://api.github.com/users/hassanNS/gists{/gist_id}","starred_url":"https://api.github.com/users/hassanNS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hassanNS/subscriptions","organizations_url":"https://api.github.com/users/hassanNS/orgs","repos_url":"https://api.github.com/users/hassanNS/repos","events_url":"https://api.github.com/users/hassanNS/events{/privacy}","received_events_url":"https://api.github.com/users/hassanNS/received_events","type":"User","site_admin":false},"body":"yes the last values is ignored and added right under. So if you have `[a, b, c]`, the string formed after the loop is `field name is a, b` and after the addition at the end \r\n`field name is a, b or c`","created_at":"2014-06-03T18:17:58Z","updated_at":"2014-06-03T18:17:58Z","html_url":"https://github.com/cbmi/cilantro/pull/601#discussion_r13350123","pull_request_url":"https://api.github.com/repos/cbmi/cilantro/pulls/601","_links":{"self":{"href":"https://api.github.com/repos/cbmi/cilantro/pulls/comments/13350123"},"html":{"href":"https://github.com/cbmi/cilantro/pull/601#discussion_r13350123"},"pull_request":{"href":"https://api.github.com/repos/cbmi/cilantro/pulls/601"}}}}