GitHub PullRequestReviewCommentEvent at 2014-03-03 10:24:17
Repository: ceph
Actor: kri5
Payload: {"comment":{"url":"https://api.github.com/repos/ceph/ceph/pulls/comments/10205894","id":10205894,"diff_hunk":"@@ -123,6 +123,6 @@ export CXXFLAGS\n \n ./configure \\\n --prefix=/usr --sbindir=/sbin --localstatedir=/var --sysconfdir=/etc \\\n---with-debug $with_profiler --with-cryptopp --with-radosgw \\\n+--with-debug $with_profiler --with-cryptopp --with-radosgw --with-librocksdb\\","path":"do_autogen.sh","position":5,"original_position":5,"commit_id":"1ef4b8c796b18d989d2db91cd7112c8e95eedbe7","original_commit_id":"1ef4b8c796b18d989d2db91cd7112c8e95eedbe7","user":{"login":"kri5","id":54695,"avatar_url":"https://avatars.githubusercontent.com/u/54695","gravatar_id":"48ae53ed462265f947d820d26ab54ef9","url":"https://api.github.com/users/kri5","html_url":"https://github.com/kri5","followers_url":"https://api.github.com/users/kri5/followers","following_url":"https://api.github.com/users/kri5/following{/other_user}","gists_url":"https://api.github.com/users/kri5/gists{/gist_id}","starred_url":"https://api.github.com/users/kri5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kri5/subscriptions","organizations_url":"https://api.github.com/users/kri5/orgs","repos_url":"https://api.github.com/users/kri5/repos","events_url":"https://api.github.com/users/kri5/events{/privacy}","received_events_url":"https://api.github.com/users/kri5/received_events","type":"User","site_admin":false},"body":"Are we sure we want to enable --with-librocksdb by default using do_autogen.sh?\r\nAs it requires c++11 and recent compiler, it would not compile for older compiler.","created_at":"2014-03-03T10:24:17Z","updated_at":"2014-03-03T10:24:17Z","html_url":"https://github.com/ceph/ceph/pull/1346#discussion_r10205894","pull_request_url":"https://api.github.com/repos/ceph/ceph/pulls/1346","_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments/10205894"},"html":{"href":"https://github.com/ceph/ceph/pull/1346#discussion_r10205894"},"pull_request":{"href":"https://api.github.com/repos/ceph/ceph/pulls/1346"}}}}