GitHub PullRequestReviewCommentEvent at 2014-08-07 11:49:59
Repository: wymeditor
Actor: mightyiam
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/wymeditor/wymeditor/pulls/comments/15930775","id":15930775,"diff_hunk":"@@ -16,55 +16,29 @@ WYMeditor.WymClassGecko.NEEDS_CELL_FIX = parseInt(\n     jQuery.browser.version >= '1.9.1' &&\n     jQuery.browser.version < '2.0';\n \n-WYMeditor.WymClassGecko.prototype.initIframe = function (iframe) {\n+WYMeditor.WymClassGecko.prototype._docEventQuirks = function () {\n     var wym = this;\n \n-    this._iframe = iframe;\n-    this._doc = iframe.contentDocument;\n-\n-    this._doc.title = this._wym._index;\n-\n-    // Set the text direction\n-    jQuery('html', this._doc).attr('dir', this._options.direction);\n-\n-    // Init html value\n-    if (this._wym._options.html) {\n-        this._html(this._wym._options.html);\n-    } else {\n-        this._html(this._element[0].value);\n-    }\n-\n-    this.enableDesignMode();\n-\n-    if (jQuery.isFunction(this._options.preBind)) {\n-        this._options.preBind(this);\n-    }\n-\n-    // Bind external events\n-    this._wym.bindEvents();\n-\n     jQuery(this._doc).bind(\"keydown\", this.keydown);\n     jQuery(this._doc).bind(\"keyup\", this.keyup);\n     jQuery(this._doc).bind(\"click\", this.click);\n     // Bind editor focus events (used to reset designmode - Gecko bug)\n     jQuery(this._doc).bind(\"focus\", function () {\n         // Fix scope\n-        wym.enableDesignMode.call(wym);\n+        wym._enableDesignModeOnIframe.call(wym);","path":"src/wymeditor/editor/gecko.js","position":39,"original_position":39,"commit_id":"8a403ec9214306b9fefc19e1fd8488891292063b","original_commit_id":"8a403ec9214306b9fefc19e1fd8488891292063b","user":{"login":"mightyiam","id":635591,"avatar_url":"https://avatars.githubusercontent.com/u/635591?v=2","gravatar_id":"33f75cd97825f68d5f8a758f0e9f2cda","url":"https://api.github.com/users/mightyiam","html_url":"https://github.com/mightyiam","followers_url":"https://api.github.com/users/mightyiam/followers","following_url":"https://api.github.com/users/mightyiam/following{/other_user}","gists_url":"https://api.github.com/users/mightyiam/gists{/gist_id}","starred_url":"https://api.github.com/users/mightyiam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mightyiam/subscriptions","organizations_url":"https://api.github.com/users/mightyiam/orgs","repos_url":"https://api.github.com/users/mightyiam/repos","events_url":"https://api.github.com/users/mightyiam/events{/privacy}","received_events_url":"https://api.github.com/users/mightyiam/received_events","type":"User","site_admin":false},"body":"So, leading underscore because the function is intended to be called only from within one other function?","created_at":"2014-08-07T11:49:59Z","updated_at":"2014-08-07T11:49:59Z","html_url":"https://github.com/wymeditor/wymeditor/pull/556#discussion_r15930775","pull_request_url":"https://api.github.com/repos/wymeditor/wymeditor/pulls/556","_links":{"self":{"href":"https://api.github.com/repos/wymeditor/wymeditor/pulls/comments/15930775"},"html":{"href":"https://github.com/wymeditor/wymeditor/pull/556#discussion_r15930775"},"pull_request":{"href":"https://api.github.com/repos/wymeditor/wymeditor/pulls/556"}}},"pull_request":{"url":"https://api.github.com/repos/wymeditor/wymeditor/pulls/556","id":19460306,"html_url":"https://github.com/wymeditor/wymeditor/pull/556","diff_url":"https://github.com/wymeditor/wymeditor/pull/556.diff","patch_url":"https://github.com/wymeditor/wymeditor/pull/556.patch","issue_url":"https://api.github.com/repos/wymeditor/wymeditor/issues/556","number":556,"state":"open","title":"Unable to add/remove row/columns in IE8","user":{"login":"mightyiam","id":635591,"avatar_url":"https://avatars.githubusercontent.com/u/635591?v=2","gravatar_id":"33f75cd97825f68d5f8a758f0e9f2cda","url":"https://api.github.com/users/mightyiam","html_url":"https://github.com/mightyiam","followers_url":"https://api.github.com/users/mightyiam/followers","following_url":"https://api.github.com/users/mightyiam/following{/other_user}","gists_url":"https://api.github.com/users/mightyiam/gists{/gist_id}","starred_url":"https://api.github.com/users/mightyiam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mightyiam/subscriptions","organizations_url":"https://api.github.com/users/mightyiam/orgs","repos_url":"https://api.github.com/users/mightyiam/repos","events_url":"https://api.github.com/users/mightyiam/events{/privacy}","received_events_url":"https://api.github.com/users/mightyiam/received_events","type":"User","site_admin":false},"body":"Clicking any of the add/remove buttons for rows/columns appears to be busted in IE8.","created_at":"2014-08-07T11:11:39Z","updated_at":"2014-08-07T11:49:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b183c5b28791aeacbc3f7b3293a0971e443cc6a2","assignee":null,"milestone":{"url":"https://api.github.com/repos/wymeditor/wymeditor/milestones/13","labels_url":"https://api.github.com/repos/wymeditor/wymeditor/milestones/13/labels","id":708267,"number":13,"title":"1.0.0b8","description":"","creator":{"login":"mightyiam","id":635591,"avatar_url":"https://avatars.githubusercontent.com/u/635591?v=2","gravatar_id":"33f75cd97825f68d5f8a758f0e9f2cda","url":"https://api.github.com/users/mightyiam","html_url":"https://github.com/mightyiam","followers_url":"https://api.github.com/users/mightyiam/followers","following_url":"https://api.github.com/users/mightyiam/following{/other_user}","gists_url":"https://api.github.com/users/mightyiam/gists{/gist_id}","starred_url":"https://api.github.com/users/mightyiam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mightyiam/subscriptions","organizations_url":"https://api.github.com/users/mightyiam/orgs","repos_url":"https://api.github.com/users/mightyiam/repos","events_url":"https://api.github.com/users/mightyiam/events{/privacy}","received_events_url":"https://api.github.com/users/mightyiam/received_events","type":"User","site_admin":false},"open_issues":9,"closed_issues":4,"state":"open","created_at":"2014-07-02T16:22:13Z","updated_at":"2014-07-31T20:12:24Z","due_on":null},"commits_url":"https://api.github.com/repos/wymeditor/wymeditor/pulls/556/commits","review_comments_url":"https://api.github.com/repos/wymeditor/wymeditor/pulls/556/comments","review_comment_url":"https://api.github.com/repos/wymeditor/wymeditor/pulls/comments/{number}","comments_url":"https://api.github.com/repos/wymeditor/wymeditor/issues/556/comments","statuses_url":"https://api.github.com/repos/wymeditor/wymeditor/statuses/8a403ec9214306b9fefc19e1fd8488891292063b","head":{"label":"wymeditor:issue_556","ref":"issue_556","sha":"8a403ec9214306b9fefc19e1fd8488891292063b","user":{"login":"wymeditor","id":187598,"avatar_url":"https://avatars.githubusercontent.com/u/187598?v=2","gravatar_id":"f5ca56e0793624023de9ed1168aaf0c7","url":"https://api.github.com/users/wymeditor","html_url":"https://github.com/wymeditor","followers_url":"https://api.github.com/users/wymeditor/followers","following_url":"https://api.github.com/users/wymeditor/following{/other_user}","gists_url":"https://api.github.com/users/wymeditor/gists{/gist_id}","starred_url":"https://api.github.com/users/wymeditor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wymeditor/subscriptions","organizations_url":"https://api.github.com/users/wymeditor/orgs","repos_url":"https://api.github.com/users/wymeditor/repos","events_url":"https://api.github.com/users/wymeditor/events{/privacy}","received_events_url":"https://api.github.com/users/wymeditor/received_events","type":"Organization","site_admin":false},"repo":{"id":483659,"name":"wymeditor","full_name":"wymeditor/wymeditor","owner":{"login":"wymeditor","id":187598,"avatar_url":"https://avatars.githubusercontent.com/u/187598?v=2","gravatar_id":"f5ca56e0793624023de9ed1168aaf0c7","url":"https://api.github.com/users/wymeditor","html_url":"https://github.com/wymeditor","followers_url":"https://api.github.com/users/wymeditor/followers","following_url":"https://api.github.com/users/wymeditor/following{/other_user}","gists_url":"https://api.github.com/users/wymeditor/gists{/gist_id}","starred_url":"https://api.github.com/users/wymeditor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wymeditor/subscriptions","organizations_url":"https://api.github.com/users/wymeditor/orgs","repos_url":"https://api.github.com/users/wymeditor/repos","events_url":"https://api.github.com/users/wymeditor/events{/privacy}","received_events_url":"https://api.github.com/users/wymeditor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wymeditor/wymeditor","description":"Pure js cross-browser WYSIWYM editor with a focus on the clean separation of content and styling.","fork":false,"url":"https://api.github.com/repos/wymeditor/wymeditor","forks_url":"https://api.github.com/repos/wymeditor/wymeditor/forks","keys_url":"https://api.github.com/repos/wymeditor/wymeditor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wymeditor/wymeditor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wymeditor/wymeditor/teams","hooks_url":"https://api.github.com/repos/wymeditor/wymeditor/hooks","issue_events_url":"https://api.github.com/repos/wymeditor/wymeditor/issues/events{/number}","events_url":"https://api.github.com/repos/wymeditor/wymeditor/events","assignees_url":"https://api.github.com/repos/wymeditor/wymeditor/assignees{/user}","branches_url":"https://api.github.com/repos/wymeditor/wymeditor/branches{/branch}","tags_url":"https://api.github.com/repos/wymeditor/wymeditor/tags","blobs_url":"https://api.github.com/repos/wymeditor/wymeditor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wymeditor/wymeditor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wymeditor/wymeditor/git/refs{/sha}","trees_url":"https://api.github.com/repos/wymeditor/wymeditor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wymeditor/wymeditor/statuses/{sha}","languages_url":"https://api.github.com/repos/wymeditor/wymeditor/languages","stargazers_url":"https://api.github.com/repos/wymeditor/wymeditor/stargazers","contributors_url":"https://api.github.com/repos/wymeditor/wymeditor/contributors","subscribers_url":"https://api.github.com/repos/wymeditor/wymeditor/subscribers","subscription_url":"https://api.github.com/repos/wymeditor/wymeditor/subscription","commits_url":"https://api.github.com/repos/wymeditor/wymeditor/commits{/sha}","git_commits_url":"https://api.github.com/repos/wymeditor/wymeditor/git/commits{/sha}","comments_url":"https://api.github.com/repos/wymeditor/wymeditor/comments{/number}","issue_comment_url":"https://api.github.com/repos/wymeditor/wymeditor/issues/comments/{number}","contents_url":"https://api.github.com/repos/wymeditor/wymeditor/contents/{+path}","compare_url":"https://api.github.com/repos/wymeditor/wymeditor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wymeditor/wymeditor/merges","archive_url":"https://api.github.com/repos/wymeditor/wymeditor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wymeditor/wymeditor/downloads","issues_url":"https://api.github.com/repos/wymeditor/wymeditor/issues{/number}","pulls_url":"https://api.github.com/repos/wymeditor/wymeditor/pulls{/number}","milestones_url":"https://api.github.com/repos/wymeditor/wymeditor/milestones{/number}","notifications_url":"https://api.github.com/repos/wymeditor/wymeditor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wymeditor/wymeditor/labels{/name}","releases_url":"https://api.github.com/repos/wymeditor/wymeditor/releases{/id}","created_at":"2010-01-22T10:50:59Z","updated_at":"2014-08-02T15:58:50Z","pushed_at":"2014-08-07T11:35:07Z","git_url":"git://github.com/wymeditor/wymeditor.git","ssh_url":"git@github.com:wymeditor/wymeditor.git","clone_url":"https://github.com/wymeditor/wymeditor.git","svn_url":"https://github.com/wymeditor/wymeditor","homepage":"http://wymeditor.github.io/wymeditor/","size":15682,"stargazers_count":471,"watchers_count":471,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":95,"mirror_url":null,"open_issues_count":104,"forks":95,"open_issues":104,"watchers":471,"default_branch":"master"}},"base":{"label":"wymeditor:master","ref":"master","sha":"9086a85ebeb051c01446cffa1cf04c70f70337d7","user":{"login":"wymeditor","id":187598,"avatar_url":"https://avatars.githubusercontent.com/u/187598?v=2","gravatar_id":"f5ca56e0793624023de9ed1168aaf0c7","url":"https://api.github.com/users/wymeditor","html_url":"https://github.com/wymeditor","followers_url":"https://api.github.com/users/wymeditor/followers","following_url":"https://api.github.com/users/wymeditor/following{/other_user}","gists_url":"https://api.github.com/users/wymeditor/gists{/gist_id}","starred_url":"https://api.github.com/users/wymeditor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wymeditor/subscriptions","organizations_url":"https://api.github.com/users/wymeditor/orgs","repos_url":"https://api.github.com/users/wymeditor/repos","events_url":"https://api.github.com/users/wymeditor/events{/privacy}","received_events_url":"https://api.github.com/users/wymeditor/received_events","type":"Organization","site_admin":false},"repo":{"id":483659,"name":"wymeditor","full_name":"wymeditor/wymeditor","owner":{"login":"wymeditor","id":187598,"avatar_url":"https://avatars.githubusercontent.com/u/187598?v=2","gravatar_id":"f5ca56e0793624023de9ed1168aaf0c7","url":"https://api.github.com/users/wymeditor","html_url":"https://github.com/wymeditor","followers_url":"https://api.github.com/users/wymeditor/followers","following_url":"https://api.github.com/users/wymeditor/following{/other_user}","gists_url":"https://api.github.com/users/wymeditor/gists{/gist_id}","starred_url":"https://api.github.com/users/wymeditor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wymeditor/subscriptions","organizations_url":"https://api.github.com/users/wymeditor/orgs","repos_url":"https://api.github.com/users/wymeditor/repos","events_url":"https://api.github.com/users/wymeditor/events{/privacy}","received_events_url":"https://api.github.com/users/wymeditor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wymeditor/wymeditor","description":"Pure js cross-browser WYSIWYM editor with a focus on the clean separation of content and styling.","fork":false,"url":"https://api.github.com/repos/wymeditor/wymeditor","forks_url":"https://api.github.com/repos/wymeditor/wymeditor/forks","keys_url":"https://api.github.com/repos/wymeditor/wymeditor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wymeditor/wymeditor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wymeditor/wymeditor/teams","hooks_url":"https://api.github.com/repos/wymeditor/wymeditor/hooks","issue_events_url":"https://api.github.com/repos/wymeditor/wymeditor/issues/events{/number}","events_url":"https://api.github.com/repos/wymeditor/wymeditor/events","assignees_url":"https://api.github.com/repos/wymeditor/wymeditor/assignees{/user}","branches_url":"https://api.github.com/repos/wymeditor/wymeditor/branches{/branch}","tags_url":"https://api.github.com/repos/wymeditor/wymeditor/tags","blobs_url":"https://api.github.com/repos/wymeditor/wymeditor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wymeditor/wymeditor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wymeditor/wymeditor/git/refs{/sha}","trees_url":"https://api.github.com/repos/wymeditor/wymeditor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wymeditor/wymeditor/statuses/{sha}","languages_url":"https://api.github.com/repos/wymeditor/wymeditor/languages","stargazers_url":"https://api.github.com/repos/wymeditor/wymeditor/stargazers","contributors_url":"https://api.github.com/repos/wymeditor/wymeditor/contributors","subscribers_url":"https://api.github.com/repos/wymeditor/wymeditor/subscribers","subscription_url":"https://api.github.com/repos/wymeditor/wymeditor/subscription","commits_url":"https://api.github.com/repos/wymeditor/wymeditor/commits{/sha}","git_commits_url":"https://api.github.com/repos/wymeditor/wymeditor/git/commits{/sha}","comments_url":"https://api.github.com/repos/wymeditor/wymeditor/comments{/number}","issue_comment_url":"https://api.github.com/repos/wymeditor/wymeditor/issues/comments/{number}","contents_url":"https://api.github.com/repos/wymeditor/wymeditor/contents/{+path}","compare_url":"https://api.github.com/repos/wymeditor/wymeditor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wymeditor/wymeditor/merges","archive_url":"https://api.github.com/repos/wymeditor/wymeditor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wymeditor/wymeditor/downloads","issues_url":"https://api.github.com/repos/wymeditor/wymeditor/issues{/number}","pulls_url":"https://api.github.com/repos/wymeditor/wymeditor/pulls{/number}","milestones_url":"https://api.github.com/repos/wymeditor/wymeditor/milestones{/number}","notifications_url":"https://api.github.com/repos/wymeditor/wymeditor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wymeditor/wymeditor/labels{/name}","releases_url":"https://api.github.com/repos/wymeditor/wymeditor/releases{/id}","created_at":"2010-01-22T10:50:59Z","updated_at":"2014-08-02T15:58:50Z","pushed_at":"2014-08-07T11:35:07Z","git_url":"git://github.com/wymeditor/wymeditor.git","ssh_url":"git@github.com:wymeditor/wymeditor.git","clone_url":"https://github.com/wymeditor/wymeditor.git","svn_url":"https://github.com/wymeditor/wymeditor","homepage":"http://wymeditor.github.io/wymeditor/","size":15682,"stargazers_count":471,"watchers_count":471,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":95,"mirror_url":null,"open_issues_count":104,"forks":95,"open_issues":104,"watchers":471,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wymeditor/wymeditor/pulls/556"},"html":{"href":"https://github.com/wymeditor/wymeditor/pull/556"},"issue":{"href":"https://api.github.com/repos/wymeditor/wymeditor/issues/556"},"comments":{"href":"https://api.github.com/repos/wymeditor/wymeditor/issues/556/comments"},"review_comments":{"href":"https://api.github.com/repos/wymeditor/wymeditor/pulls/556/comments"},"review_comment":{"href":"https://api.github.com/repos/wymeditor/wymeditor/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/wymeditor/wymeditor/pulls/556/commits"},"statuses":{"href":"https://api.github.com/repos/wymeditor/wymeditor/statuses/8a403ec9214306b9fefc19e1fd8488891292063b"}}}}