GitHub PullRequestReviewCommentEvent at 2014-08-04 13:31:12
Repository: AFNetworking
Actor: kylef
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/AFNetworking/AFNetworking/pulls/comments/15754601","id":15754601,"diff_hunk":"@@ -1,3 +1,8 @@\n+= Master\n+\n+ * Fixes an issue with `AFHTTPRequestSerializer` returning a request and\n+  silently handling an error from a `queryStringSerialization` block.\n+","path":"CHANGES","position":5,"original_position":5,"commit_id":"a5d5e024757e619164cc9abefc62102b2976541e","original_commit_id":"a5d5e024757e619164cc9abefc62102b2976541e","user":{"login":"kylef","id":44164,"avatar_url":"https://avatars.githubusercontent.com/u/44164?v=1","gravatar_id":"d200a17dd269fd4001bacb11662dab4b","url":"https://api.github.com/users/kylef","html_url":"https://github.com/kylef","followers_url":"https://api.github.com/users/kylef/followers","following_url":"https://api.github.com/users/kylef/following{/other_user}","gists_url":"https://api.github.com/users/kylef/gists{/gist_id}","starred_url":"https://api.github.com/users/kylef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kylef/subscriptions","organizations_url":"https://api.github.com/users/kylef/orgs","repos_url":"https://api.github.com/users/kylef/repos","events_url":"https://api.github.com/users/kylef/events{/privacy}","received_events_url":"https://api.github.com/users/kylef/received_events","type":"User","site_admin":false},"body":"@mattt Should we be putting our changes in this CHANGELOG?","created_at":"2014-08-04T13:31:12Z","updated_at":"2014-08-04T13:31:12Z","html_url":"https://github.com/AFNetworking/AFNetworking/pull/2228#discussion_r15754601","pull_request_url":"https://api.github.com/repos/AFNetworking/AFNetworking/pulls/2228","_links":{"self":{"href":"https://api.github.com/repos/AFNetworking/AFNetworking/pulls/comments/15754601"},"html":{"href":"https://github.com/AFNetworking/AFNetworking/pull/2228#discussion_r15754601"},"pull_request":{"href":"https://api.github.com/repos/AFNetworking/AFNetworking/pulls/2228"}}},"pull_request":{"url":"https://api.github.com/repos/AFNetworking/AFNetworking/pulls/2228","id":19281325,"html_url":"https://github.com/AFNetworking/AFNetworking/pull/2228","diff_url":"https://github.com/AFNetworking/AFNetworking/pull/2228.diff","patch_url":"https://github.com/AFNetworking/AFNetworking/pull/2228.patch","issue_url":"https://api.github.com/repos/AFNetworking/AFNetworking/issues/2228","number":2228,"state":"open","title":"Fixes an issue with the request serializer silently handling an error","user":{"login":"kylef","id":44164,"avatar_url":"https://avatars.githubusercontent.com/u/44164?v=1","gravatar_id":"d200a17dd269fd4001bacb11662dab4b","url":"https://api.github.com/users/kylef","html_url":"https://github.com/kylef","followers_url":"https://api.github.com/users/kylef/followers","following_url":"https://api.github.com/users/kylef/following{/other_user}","gists_url":"https://api.github.com/users/kylef/gists{/gist_id}","starred_url":"https://api.github.com/users/kylef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kylef/subscriptions","organizations_url":"https://api.github.com/users/kylef/orgs","repos_url":"https://api.github.com/users/kylef/repos","events_url":"https://api.github.com/users/kylef/events{/privacy}","received_events_url":"https://api.github.com/users/kylef/received_events","type":"User","site_admin":false},"body":"When a query string serialization block is set on `AFHTTPRequestSerializer`, if it was to fail with an error it would be silently handled and the serialization would still return an NSURLRequest.","created_at":"2014-08-04T13:18:08Z","updated_at":"2014-08-04T13:31:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a9322c1b8c898e34c0933aa7d95bf8ff6f965958","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/AFNetworking/AFNetworking/pulls/2228/commits","review_comments_url":"https://api.github.com/repos/AFNetworking/AFNetworking/pulls/2228/comments","review_comment_url":"https://api.github.com/repos/AFNetworking/AFNetworking/pulls/comments/{number}","comments_url":"https://api.github.com/repos/AFNetworking/AFNetworking/issues/2228/comments","statuses_url":"https://api.github.com/repos/AFNetworking/AFNetworking/statuses/a5d5e024757e619164cc9abefc62102b2976541e","head":{"label":"kylef:AFURLRequestSerialization-error","ref":"AFURLRequestSerialization-error","sha":"a5d5e024757e619164cc9abefc62102b2976541e","user":{"login":"kylef","id":44164,"avatar_url":"https://avatars.githubusercontent.com/u/44164?v=1","gravatar_id":"d200a17dd269fd4001bacb11662dab4b","url":"https://api.github.com/users/kylef","html_url":"https://github.com/kylef","followers_url":"https://api.github.com/users/kylef/followers","following_url":"https://api.github.com/users/kylef/following{/other_user}","gists_url":"https://api.github.com/users/kylef/gists{/gist_id}","starred_url":"https://api.github.com/users/kylef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kylef/subscriptions","organizations_url":"https://api.github.com/users/kylef/orgs","repos_url":"https://api.github.com/users/kylef/repos","events_url":"https://api.github.com/users/kylef/events{/privacy}","received_events_url":"https://api.github.com/users/kylef/received_events","type":"User","site_admin":false},"repo":{"id":10220747,"name":"AFNetworking","full_name":"kylef/AFNetworking","owner":{"login":"kylef","id":44164,"avatar_url":"https://avatars.githubusercontent.com/u/44164?v=1","gravatar_id":"d200a17dd269fd4001bacb11662dab4b","url":"https://api.github.com/users/kylef","html_url":"https://github.com/kylef","followers_url":"https://api.github.com/users/kylef/followers","following_url":"https://api.github.com/users/kylef/following{/other_user}","gists_url":"https://api.github.com/users/kylef/gists{/gist_id}","starred_url":"https://api.github.com/users/kylef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kylef/subscriptions","organizations_url":"https://api.github.com/users/kylef/orgs","repos_url":"https://api.github.com/users/kylef/repos","events_url":"https://api.github.com/users/kylef/events{/privacy}","received_events_url":"https://api.github.com/users/kylef/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kylef/AFNetworking","description":"A delightful iOS and OS X networking framework","fork":true,"url":"https://api.github.com/repos/kylef/AFNetworking","forks_url":"https://api.github.com/repos/kylef/AFNetworking/forks","keys_url":"https://api.github.com/repos/kylef/AFNetworking/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kylef/AFNetworking/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kylef/AFNetworking/teams","hooks_url":"https://api.github.com/repos/kylef/AFNetworking/hooks","issue_events_url":"https://api.github.com/repos/kylef/AFNetworking/issues/events{/number}","events_url":"https://api.github.com/repos/kylef/AFNetworking/events","assignees_url":"https://api.github.com/repos/kylef/AFNetworking/assignees{/user}","branches_url":"https://api.github.com/repos/kylef/AFNetworking/branches{/branch}","tags_url":"https://api.github.com/repos/kylef/AFNetworking/tags","blobs_url":"https://api.github.com/repos/kylef/AFNetworking/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kylef/AFNetworking/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kylef/AFNetworking/git/refs{/sha}","trees_url":"https://api.github.com/repos/kylef/AFNetworking/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kylef/AFNetworking/statuses/{sha}","languages_url":"https://api.github.com/repos/kylef/AFNetworking/languages","stargazers_url":"https://api.github.com/repos/kylef/AFNetworking/stargazers","contributors_url":"https://api.github.com/repos/kylef/AFNetworking/contributors","subscribers_url":"https://api.github.com/repos/kylef/AFNetworking/subscribers","subscription_url":"https://api.github.com/repos/kylef/AFNetworking/subscription","commits_url":"https://api.github.com/repos/kylef/AFNetworking/commits{/sha}","git_commits_url":"https://api.github.com/repos/kylef/AFNetworking/git/commits{/sha}","comments_url":"https://api.github.com/repos/kylef/AFNetworking/comments{/number}","issue_comment_url":"https://api.github.com/repos/kylef/AFNetworking/issues/comments/{number}","contents_url":"https://api.github.com/repos/kylef/AFNetworking/contents/{+path}","compare_url":"https://api.github.com/repos/kylef/AFNetworking/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kylef/AFNetworking/merges","archive_url":"https://api.github.com/repos/kylef/AFNetworking/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kylef/AFNetworking/downloads","issues_url":"https://api.github.com/repos/kylef/AFNetworking/issues{/number}","pulls_url":"https://api.github.com/repos/kylef/AFNetworking/pulls{/number}","milestones_url":"https://api.github.com/repos/kylef/AFNetworking/milestones{/number}","notifications_url":"https://api.github.com/repos/kylef/AFNetworking/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kylef/AFNetworking/labels{/name}","releases_url":"https://api.github.com/repos/kylef/AFNetworking/releases{/id}","created_at":"2013-05-22T13:42:38Z","updated_at":"2014-05-13T16:17:33Z","pushed_at":"2014-08-04T13:26:43Z","git_url":"git://github.com/kylef/AFNetworking.git","ssh_url":"git@github.com:kylef/AFNetworking.git","clone_url":"https://github.com/kylef/AFNetworking.git","svn_url":"https://github.com/kylef/AFNetworking","homepage":"http://afnetworking.com","size":5673,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"AFNetworking:master","ref":"master","sha":"80d35488c67d6a0b75cfc6854bed891f9427f21a","user":{"login":"AFNetworking","id":1181541,"avatar_url":"https://avatars.githubusercontent.com/u/1181541?v=1","gravatar_id":"2dd769dee380246925ca8bed7cf5d26f","url":"https://api.github.com/users/AFNetworking","html_url":"https://github.com/AFNetworking","followers_url":"https://api.github.com/users/AFNetworking/followers","following_url":"https://api.github.com/users/AFNetworking/following{/other_user}","gists_url":"https://api.github.com/users/AFNetworking/gists{/gist_id}","starred_url":"https://api.github.com/users/AFNetworking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AFNetworking/subscriptions","organizations_url":"https://api.github.com/users/AFNetworking/orgs","repos_url":"https://api.github.com/users/AFNetworking/repos","events_url":"https://api.github.com/users/AFNetworking/events{/privacy}","received_events_url":"https://api.github.com/users/AFNetworking/received_events","type":"Organization","site_admin":false},"repo":{"id":1828795,"name":"AFNetworking","full_name":"AFNetworking/AFNetworking","owner":{"login":"AFNetworking","id":1181541,"avatar_url":"https://avatars.githubusercontent.com/u/1181541?v=1","gravatar_id":"2dd769dee380246925ca8bed7cf5d26f","url":"https://api.github.com/users/AFNetworking","html_url":"https://github.com/AFNetworking","followers_url":"https://api.github.com/users/AFNetworking/followers","following_url":"https://api.github.com/users/AFNetworking/following{/other_user}","gists_url":"https://api.github.com/users/AFNetworking/gists{/gist_id}","starred_url":"https://api.github.com/users/AFNetworking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AFNetworking/subscriptions","organizations_url":"https://api.github.com/users/AFNetworking/orgs","repos_url":"https://api.github.com/users/AFNetworking/repos","events_url":"https://api.github.com/users/AFNetworking/events{/privacy}","received_events_url":"https://api.github.com/users/AFNetworking/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AFNetworking/AFNetworking","description":"A delightful iOS and OS X networking framework","fork":false,"url":"https://api.github.com/repos/AFNetworking/AFNetworking","forks_url":"https://api.github.com/repos/AFNetworking/AFNetworking/forks","keys_url":"https://api.github.com/repos/AFNetworking/AFNetworking/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AFNetworking/AFNetworking/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AFNetworking/AFNetworking/teams","hooks_url":"https://api.github.com/repos/AFNetworking/AFNetworking/hooks","issue_events_url":"https://api.github.com/repos/AFNetworking/AFNetworking/issues/events{/number}","events_url":"https://api.github.com/repos/AFNetworking/AFNetworking/events","assignees_url":"https://api.github.com/repos/AFNetworking/AFNetworking/assignees{/user}","branches_url":"https://api.github.com/repos/AFNetworking/AFNetworking/branches{/branch}","tags_url":"https://api.github.com/repos/AFNetworking/AFNetworking/tags","blobs_url":"https://api.github.com/repos/AFNetworking/AFNetworking/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AFNetworking/AFNetworking/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AFNetworking/AFNetworking/git/refs{/sha}","trees_url":"https://api.github.com/repos/AFNetworking/AFNetworking/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AFNetworking/AFNetworking/statuses/{sha}","languages_url":"https://api.github.com/repos/AFNetworking/AFNetworking/languages","stargazers_url":"https://api.github.com/repos/AFNetworking/AFNetworking/stargazers","contributors_url":"https://api.github.com/repos/AFNetworking/AFNetworking/contributors","subscribers_url":"https://api.github.com/repos/AFNetworking/AFNetworking/subscribers","subscription_url":"https://api.github.com/repos/AFNetworking/AFNetworking/subscription","commits_url":"https://api.github.com/repos/AFNetworking/AFNetworking/commits{/sha}","git_commits_url":"https://api.github.com/repos/AFNetworking/AFNetworking/git/commits{/sha}","comments_url":"https://api.github.com/repos/AFNetworking/AFNetworking/comments{/number}","issue_comment_url":"https://api.github.com/repos/AFNetworking/AFNetworking/issues/comments/{number}","contents_url":"https://api.github.com/repos/AFNetworking/AFNetworking/contents/{+path}","compare_url":"https://api.github.com/repos/AFNetworking/AFNetworking/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AFNetworking/AFNetworking/merges","archive_url":"https://api.github.com/repos/AFNetworking/AFNetworking/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AFNetworking/AFNetworking/downloads","issues_url":"https://api.github.com/repos/AFNetworking/AFNetworking/issues{/number}","pulls_url":"https://api.github.com/repos/AFNetworking/AFNetworking/pulls{/number}","milestones_url":"https://api.github.com/repos/AFNetworking/AFNetworking/milestones{/number}","notifications_url":"https://api.github.com/repos/AFNetworking/AFNetworking/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AFNetworking/AFNetworking/labels{/name}","releases_url":"https://api.github.com/repos/AFNetworking/AFNetworking/releases{/id}","created_at":"2011-05-31T21:28:44Z","updated_at":"2014-08-04T13:11:19Z","pushed_at":"2014-07-05T11:48:26Z","git_url":"git://github.com/AFNetworking/AFNetworking.git","ssh_url":"git@github.com:AFNetworking/AFNetworking.git","clone_url":"https://github.com/AFNetworking/AFNetworking.git","svn_url":"https://github.com/AFNetworking/AFNetworking","homepage":"http://afnetworking.com","size":18398,"stargazers_count":13052,"watchers_count":13052,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":3622,"mirror_url":null,"open_issues_count":24,"forks":3622,"open_issues":24,"watchers":13052,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AFNetworking/AFNetworking/pulls/2228"},"html":{"href":"https://github.com/AFNetworking/AFNetworking/pull/2228"},"issue":{"href":"https://api.github.com/repos/AFNetworking/AFNetworking/issues/2228"},"comments":{"href":"https://api.github.com/repos/AFNetworking/AFNetworking/issues/2228/comments"},"review_comments":{"href":"https://api.github.com/repos/AFNetworking/AFNetworking/pulls/2228/comments"},"review_comment":{"href":"https://api.github.com/repos/AFNetworking/AFNetworking/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/AFNetworking/AFNetworking/pulls/2228/commits"},"statuses":{"href":"https://api.github.com/repos/AFNetworking/AFNetworking/statuses/a5d5e024757e619164cc9abefc62102b2976541e"}}}}