GitHub PullRequestEvent at 2014-12-16 00:57:06
Repository: ansible
Actor: cchurch
Payload: {"action":"closed","number":9824,"pull_request":{"url":"https://api.github.com/repos/ansible/ansible/pulls/9824","id":26115057,"html_url":"https://github.com/ansible/ansible/pull/9824","diff_url":"https://github.com/ansible/ansible/pull/9824.diff","patch_url":"https://github.com/ansible/ansible/pull/9824.patch","issue_url":"https://api.github.com/repos/ansible/ansible/issues/9824","number":9824,"state":"closed","locked":false,"title":"Fixed error handling for the enabling of PS Remoting","user":{"login":"willempienaar","id":6728866,"avatar_url":"https://avatars.githubusercontent.com/u/6728866?v=3","gravatar_id":"","url":"https://api.github.com/users/willempienaar","html_url":"https://github.com/willempienaar","followers_url":"https://api.github.com/users/willempienaar/followers","following_url":"https://api.github.com/users/willempienaar/following{/other_user}","gists_url":"https://api.github.com/users/willempienaar/gists{/gist_id}","starred_url":"https://api.github.com/users/willempienaar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willempienaar/subscriptions","organizations_url":"https://api.github.com/users/willempienaar/orgs","repos_url":"https://api.github.com/users/willempienaar/repos","events_url":"https://api.github.com/users/willempienaar/events{/privacy}","received_events_url":"https://api.github.com/users/willempienaar/received_events","type":"User","site_admin":false},"body":"Power Shell Remoting will throw an exception if you attempt to enable it while one of your network interfaces is set to \"public\". Currently this error is hidden and the script continues to execute until it attempts to test PS Remoting to localhost. At that point the code fails with the following error:\r\n\r\n\"Unable to establish an HTTP or HTTPS remoting session.\"\r\n\r\nThis happens because PS Remoting didn't start. In actual fact the error that should have been thrown was the one that occurred when an attempt was made to enable PS Remoting.\r\n\r\nI have removed the try/catch and set the ErrorAction to Stop so that the script doesn't continue and the correct error is displayed. It will also now be clear why the script failed and how to rectify the problem.","created_at":"2014-12-16T00:53:20Z","updated_at":"2014-12-16T00:57:06Z","closed_at":"2014-12-16T00:57:06Z","merged_at":"2014-12-16T00:57:06Z","merge_commit_sha":"814bed2506969f55cc0c47f7467dc353109c575c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ansible/ansible/pulls/9824/commits","review_comments_url":"https://api.github.com/repos/ansible/ansible/pulls/9824/comments","review_comment_url":"https://api.github.com/repos/ansible/ansible/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ansible/ansible/issues/9824/comments","statuses_url":"https://api.github.com/repos/ansible/ansible/statuses/ac28652602805796211d9a3486e3a0d6d5e73f7e","head":{"label":"willempienaar:devel","ref":"devel","sha":"ac28652602805796211d9a3486e3a0d6d5e73f7e","user":{"login":"willempienaar","id":6728866,"avatar_url":"https://avatars.githubusercontent.com/u/6728866?v=3","gravatar_id":"","url":"https://api.github.com/users/willempienaar","html_url":"https://github.com/willempienaar","followers_url":"https://api.github.com/users/willempienaar/followers","following_url":"https://api.github.com/users/willempienaar/following{/other_user}","gists_url":"https://api.github.com/users/willempienaar/gists{/gist_id}","starred_url":"https://api.github.com/users/willempienaar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willempienaar/subscriptions","organizations_url":"https://api.github.com/users/willempienaar/orgs","repos_url":"https://api.github.com/users/willempienaar/repos","events_url":"https://api.github.com/users/willempienaar/events{/privacy}","received_events_url":"https://api.github.com/users/willempienaar/received_events","type":"User","site_admin":false},"repo":{"id":28062304,"name":"ansible","full_name":"willempienaar/ansible","owner":{"login":"willempienaar","id":6728866,"avatar_url":"https://avatars.githubusercontent.com/u/6728866?v=3","gravatar_id":"","url":"https://api.github.com/users/willempienaar","html_url":"https://github.com/willempienaar","followers_url":"https://api.github.com/users/willempienaar/followers","following_url":"https://api.github.com/users/willempienaar/following{/other_user}","gists_url":"https://api.github.com/users/willempienaar/gists{/gist_id}","starred_url":"https://api.github.com/users/willempienaar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willempienaar/subscriptions","organizations_url":"https://api.github.com/users/willempienaar/orgs","repos_url":"https://api.github.com/users/willempienaar/repos","events_url":"https://api.github.com/users/willempienaar/events{/privacy}","received_events_url":"https://api.github.com/users/willempienaar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/willempienaar/ansible","description":"Ansible is a radically simple IT automation platform that makes your applications and systems easier to deploy. Avoid writing scripts or custom code to deploy and update your applications— automate in a language that approaches plain English, using SSH, with no agents to install on remote systems.","fork":true,"url":"https://api.github.com/repos/willempienaar/ansible","forks_url":"https://api.github.com/repos/willempienaar/ansible/forks","keys_url":"https://api.github.com/repos/willempienaar/ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/willempienaar/ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/willempienaar/ansible/teams","hooks_url":"https://api.github.com/repos/willempienaar/ansible/hooks","issue_events_url":"https://api.github.com/repos/willempienaar/ansible/issues/events{/number}","events_url":"https://api.github.com/repos/willempienaar/ansible/events","assignees_url":"https://api.github.com/repos/willempienaar/ansible/assignees{/user}","branches_url":"https://api.github.com/repos/willempienaar/ansible/branches{/branch}","tags_url":"https://api.github.com/repos/willempienaar/ansible/tags","blobs_url":"https://api.github.com/repos/willempienaar/ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/willempienaar/ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/willempienaar/ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/willempienaar/ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/willempienaar/ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/willempienaar/ansible/languages","stargazers_url":"https://api.github.com/repos/willempienaar/ansible/stargazers","contributors_url":"https://api.github.com/repos/willempienaar/ansible/contributors","subscribers_url":"https://api.github.com/repos/willempienaar/ansible/subscribers","subscription_url":"https://api.github.com/repos/willempienaar/ansible/subscription","commits_url":"https://api.github.com/repos/willempienaar/ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/willempienaar/ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/willempienaar/ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/willempienaar/ansible/issues/comments/{number}","contents_url":"https://api.github.com/repos/willempienaar/ansible/contents/{+path}","compare_url":"https://api.github.com/repos/willempienaar/ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/willempienaar/ansible/merges","archive_url":"https://api.github.com/repos/willempienaar/ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/willempienaar/ansible/downloads","issues_url":"https://api.github.com/repos/willempienaar/ansible/issues{/number}","pulls_url":"https://api.github.com/repos/willempienaar/ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/willempienaar/ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/willempienaar/ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/willempienaar/ansible/labels{/name}","releases_url":"https://api.github.com/repos/willempienaar/ansible/releases{/id}","created_at":"2014-12-16T00:07:19Z","updated_at":"2014-12-16T00:29:47Z","pushed_at":"2014-12-16T00:29:47Z","git_url":"git://github.com/willempienaar/ansible.git","ssh_url":"git@github.com:willempienaar/ansible.git","clone_url":"https://github.com/willempienaar/ansible.git","svn_url":"https://github.com/willempienaar/ansible","homepage":"http://ansible.com/","size":149126,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"devel"}},"base":{"label":"ansible:devel","ref":"devel","sha":"8908f4a0efe015c303758fa736acb741cd072e47","user":{"login":"ansible","id":1507452,"avatar_url":"https://avatars.githubusercontent.com/u/1507452?v=3","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"repo":{"id":3638964,"name":"ansible","full_name":"ansible/ansible","owner":{"login":"ansible","id":1507452,"avatar_url":"https://avatars.githubusercontent.com/u/1507452?v=3","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ansible/ansible","description":"Ansible is a radically simple IT automation platform that makes your applications and systems easier to deploy. Avoid writing scripts or custom code to deploy and update your applications— automate in a language that approaches plain English, using SSH, with no agents to install on remote systems.","fork":false,"url":"https://api.github.com/repos/ansible/ansible","forks_url":"https://api.github.com/repos/ansible/ansible/forks","keys_url":"https://api.github.com/repos/ansible/ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ansible/ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ansible/ansible/teams","hooks_url":"https://api.github.com/repos/ansible/ansible/hooks","issue_events_url":"https://api.github.com/repos/ansible/ansible/issues/events{/number}","events_url":"https://api.github.com/repos/ansible/ansible/events","assignees_url":"https://api.github.com/repos/ansible/ansible/assignees{/user}","branches_url":"https://api.github.com/repos/ansible/ansible/branches{/branch}","tags_url":"https://api.github.com/repos/ansible/ansible/tags","blobs_url":"https://api.github.com/repos/ansible/ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ansible/ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ansible/ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/ansible/ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ansible/ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/ansible/ansible/languages","stargazers_url":"https://api.github.com/repos/ansible/ansible/stargazers","contributors_url":"https://api.github.com/repos/ansible/ansible/contributors","subscribers_url":"https://api.github.com/repos/ansible/ansible/subscribers","subscription_url":"https://api.github.com/repos/ansible/ansible/subscription","commits_url":"https://api.github.com/repos/ansible/ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/ansible/ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/ansible/ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/ansible/ansible/issues/comments/{number}","contents_url":"https://api.github.com/repos/ansible/ansible/contents/{+path}","compare_url":"https://api.github.com/repos/ansible/ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ansible/ansible/merges","archive_url":"https://api.github.com/repos/ansible/ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ansible/ansible/downloads","issues_url":"https://api.github.com/repos/ansible/ansible/issues{/number}","pulls_url":"https://api.github.com/repos/ansible/ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/ansible/ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/ansible/ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ansible/ansible/labels{/name}","releases_url":"https://api.github.com/repos/ansible/ansible/releases{/id}","created_at":"2012-03-06T14:58:02Z","updated_at":"2014-12-16T00:16:40Z","pushed_at":"2014-12-16T00:57:06Z","git_url":"git://github.com/ansible/ansible.git","ssh_url":"git@github.com:ansible/ansible.git","clone_url":"https://github.com/ansible/ansible.git","svn_url":"https://github.com/ansible/ansible","homepage":"http://ansible.com/","size":149126,"stargazers_count":8737,"watchers_count":8737,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2716,"mirror_url":null,"open_issues_count":540,"forks":2716,"open_issues":540,"watchers":8737,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/ansible/ansible/pulls/9824"},"html":{"href":"https://github.com/ansible/ansible/pull/9824"},"issue":{"href":"https://api.github.com/repos/ansible/ansible/issues/9824"},"comments":{"href":"https://api.github.com/repos/ansible/ansible/issues/9824/comments"},"review_comments":{"href":"https://api.github.com/repos/ansible/ansible/pulls/9824/comments"},"review_comment":{"href":"https://api.github.com/repos/ansible/ansible/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ansible/ansible/pulls/9824/commits"},"statuses":{"href":"https://api.github.com/repos/ansible/ansible/statuses/ac28652602805796211d9a3486e3a0d6d5e73f7e"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"cchurch","id":429563,"avatar_url":"https://avatars.githubusercontent.com/u/429563?v=3","gravatar_id":"","url":"https://api.github.com/users/cchurch","html_url":"https://github.com/cchurch","followers_url":"https://api.github.com/users/cchurch/followers","following_url":"https://api.github.com/users/cchurch/following{/other_user}","gists_url":"https://api.github.com/users/cchurch/gists{/gist_id}","starred_url":"https://api.github.com/users/cchurch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cchurch/subscriptions","organizations_url":"https://api.github.com/users/cchurch/orgs","repos_url":"https://api.github.com/users/cchurch/repos","events_url":"https://api.github.com/users/cchurch/events{/privacy}","received_events_url":"https://api.github.com/users/cchurch/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":7,"changed_files":1}}