GitHub PullRequestReviewCommentEvent at 2014-09-29 21:39:33
Repository: citra
Actor: neobrain
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/citra-emu/citra/pulls/comments/18185579","id":18185579,"diff_hunk":"@@ -50,18 +51,11 @@ u32 Directory_SDMC::Read(const u32 count, Entry* entries) {\n                 break;\n         }\n \n-        // Split the filename into 8.3 format.\n-        // TODO(Link Mauve): move that to common, I guess, and make it more robust to long filenames.\n-        std::string::size_type n = filename.rfind('.');\n-        if (n == std::string::npos) {\n-            strncpy(entry->short_name, filename.c_str(), 8);\n-            memset(entry->extension, '\\0', 3);\n-        } else {\n-            strncpy(entry->short_name, filename.substr(0, n).c_str(), 8);\n-            strncpy(entry->extension, filename.substr(n + 1).c_str(), 8);\n-        }\n+        FileUtil::SplitFilename83(filename, entry->short_name, entry->extension);\n \n         entry->is_directory = file.isDirectory;\n+        entry->is_hidden = filename[0] == '.';","path":"src/core/file_sys/directory_sdmc.cpp","position":38,"original_position":38,"commit_id":"f3a7d3c26c6bdff47e4b09271718d5db1b693a80","original_commit_id":"f3a7d3c26c6bdff47e4b09271718d5db1b693a80","user":{"login":"neobrain","id":4840017,"avatar_url":"https://avatars.githubusercontent.com/u/4840017?v=2","gravatar_id":"","url":"https://api.github.com/users/neobrain","html_url":"https://github.com/neobrain","followers_url":"https://api.github.com/users/neobrain/followers","following_url":"https://api.github.com/users/neobrain/following{/other_user}","gists_url":"https://api.github.com/users/neobrain/gists{/gist_id}","starred_url":"https://api.github.com/users/neobrain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neobrain/subscriptions","organizations_url":"https://api.github.com/users/neobrain/orgs","repos_url":"https://api.github.com/users/neobrain/repos","events_url":"https://api.github.com/users/neobrain/events{/privacy}","received_events_url":"https://api.github.com/users/neobrain/received_events","type":"User","site_admin":false},"body":"Please add brackets around comparisons when their result is assigned to a variable. I.e. `entry->is_hidden = (filename[0] == '.');`","created_at":"2014-09-29T21:39:33Z","updated_at":"2014-09-29T21:39:33Z","html_url":"https://github.com/citra-emu/citra/pull/121#discussion_r18185579","pull_request_url":"https://api.github.com/repos/citra-emu/citra/pulls/121","_links":{"self":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/comments/18185579"},"html":{"href":"https://github.com/citra-emu/citra/pull/121#discussion_r18185579"},"pull_request":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/121"}}},"pull_request":{"url":"https://api.github.com/repos/citra-emu/citra/pulls/121","id":21919877,"html_url":"https://github.com/citra-emu/citra/pull/121","diff_url":"https://github.com/citra-emu/citra/pull/121.diff","patch_url":"https://github.com/citra-emu/citra/pull/121.patch","issue_url":"https://api.github.com/repos/citra-emu/citra/issues/121","number":121,"state":"open","locked":false,"title":"Fix the filesystem implementation in order to get blargSnes to run","user":{"login":"linkmauve","id":7755816,"avatar_url":"https://avatars.githubusercontent.com/u/7755816?v=2","gravatar_id":"","url":"https://api.github.com/users/linkmauve","html_url":"https://github.com/linkmauve","followers_url":"https://api.github.com/users/linkmauve/followers","following_url":"https://api.github.com/users/linkmauve/following{/other_user}","gists_url":"https://api.github.com/users/linkmauve/gists{/gist_id}","starred_url":"https://api.github.com/users/linkmauve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkmauve/subscriptions","organizations_url":"https://api.github.com/users/linkmauve/orgs","repos_url":"https://api.github.com/users/linkmauve/repos","events_url":"https://api.github.com/users/linkmauve/events{/privacy}","received_events_url":"https://api.github.com/users/linkmauve/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-09-29T08:37:26Z","updated_at":"2014-09-29T21:39:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c56591d94344aa244b195df6909c202e278fd75c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/citra-emu/citra/pulls/121/commits","review_comments_url":"https://api.github.com/repos/citra-emu/citra/pulls/121/comments","review_comment_url":"https://api.github.com/repos/citra-emu/citra/pulls/comments/{number}","comments_url":"https://api.github.com/repos/citra-emu/citra/issues/121/comments","statuses_url":"https://api.github.com/repos/citra-emu/citra/statuses/f3a7d3c26c6bdff47e4b09271718d5db1b693a80","head":{"label":"linkmauve:master","ref":"master","sha":"f3a7d3c26c6bdff47e4b09271718d5db1b693a80","user":{"login":"linkmauve","id":7755816,"avatar_url":"https://avatars.githubusercontent.com/u/7755816?v=2","gravatar_id":"","url":"https://api.github.com/users/linkmauve","html_url":"https://github.com/linkmauve","followers_url":"https://api.github.com/users/linkmauve/followers","following_url":"https://api.github.com/users/linkmauve/following{/other_user}","gists_url":"https://api.github.com/users/linkmauve/gists{/gist_id}","starred_url":"https://api.github.com/users/linkmauve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkmauve/subscriptions","organizations_url":"https://api.github.com/users/linkmauve/orgs","repos_url":"https://api.github.com/users/linkmauve/repos","events_url":"https://api.github.com/users/linkmauve/events{/privacy}","received_events_url":"https://api.github.com/users/linkmauve/received_events","type":"User","site_admin":false},"repo":{"id":23252208,"name":"citra","full_name":"linkmauve/citra","owner":{"login":"linkmauve","id":7755816,"avatar_url":"https://avatars.githubusercontent.com/u/7755816?v=2","gravatar_id":"","url":"https://api.github.com/users/linkmauve","html_url":"https://github.com/linkmauve","followers_url":"https://api.github.com/users/linkmauve/followers","following_url":"https://api.github.com/users/linkmauve/following{/other_user}","gists_url":"https://api.github.com/users/linkmauve/gists{/gist_id}","starred_url":"https://api.github.com/users/linkmauve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkmauve/subscriptions","organizations_url":"https://api.github.com/users/linkmauve/orgs","repos_url":"https://api.github.com/users/linkmauve/repos","events_url":"https://api.github.com/users/linkmauve/events{/privacy}","received_events_url":"https://api.github.com/users/linkmauve/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/linkmauve/citra","description":"Nintendo 3DS emulator/debugger","fork":true,"url":"https://api.github.com/repos/linkmauve/citra","forks_url":"https://api.github.com/repos/linkmauve/citra/forks","keys_url":"https://api.github.com/repos/linkmauve/citra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linkmauve/citra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linkmauve/citra/teams","hooks_url":"https://api.github.com/repos/linkmauve/citra/hooks","issue_events_url":"https://api.github.com/repos/linkmauve/citra/issues/events{/number}","events_url":"https://api.github.com/repos/linkmauve/citra/events","assignees_url":"https://api.github.com/repos/linkmauve/citra/assignees{/user}","branches_url":"https://api.github.com/repos/linkmauve/citra/branches{/branch}","tags_url":"https://api.github.com/repos/linkmauve/citra/tags","blobs_url":"https://api.github.com/repos/linkmauve/citra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linkmauve/citra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linkmauve/citra/git/refs{/sha}","trees_url":"https://api.github.com/repos/linkmauve/citra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linkmauve/citra/statuses/{sha}","languages_url":"https://api.github.com/repos/linkmauve/citra/languages","stargazers_url":"https://api.github.com/repos/linkmauve/citra/stargazers","contributors_url":"https://api.github.com/repos/linkmauve/citra/contributors","subscribers_url":"https://api.github.com/repos/linkmauve/citra/subscribers","subscription_url":"https://api.github.com/repos/linkmauve/citra/subscription","commits_url":"https://api.github.com/repos/linkmauve/citra/commits{/sha}","git_commits_url":"https://api.github.com/repos/linkmauve/citra/git/commits{/sha}","comments_url":"https://api.github.com/repos/linkmauve/citra/comments{/number}","issue_comment_url":"https://api.github.com/repos/linkmauve/citra/issues/comments/{number}","contents_url":"https://api.github.com/repos/linkmauve/citra/contents/{+path}","compare_url":"https://api.github.com/repos/linkmauve/citra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linkmauve/citra/merges","archive_url":"https://api.github.com/repos/linkmauve/citra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linkmauve/citra/downloads","issues_url":"https://api.github.com/repos/linkmauve/citra/issues{/number}","pulls_url":"https://api.github.com/repos/linkmauve/citra/pulls{/number}","milestones_url":"https://api.github.com/repos/linkmauve/citra/milestones{/number}","notifications_url":"https://api.github.com/repos/linkmauve/citra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linkmauve/citra/labels{/name}","releases_url":"https://api.github.com/repos/linkmauve/citra/releases{/id}","created_at":"2014-08-23T09:07:09Z","updated_at":"2014-08-23T09:33:22Z","pushed_at":"2014-09-29T15:10:15Z","git_url":"git://github.com/linkmauve/citra.git","ssh_url":"git@github.com:linkmauve/citra.git","clone_url":"https://github.com/linkmauve/citra.git","svn_url":"https://github.com/linkmauve/citra","homepage":null,"size":4671,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"citra-emu:master","ref":"master","sha":"ee7cfc71bd8663b77a43c5ba577074972d9b7ad9","user":{"login":"citra-emu","id":7605670,"avatar_url":"https://avatars.githubusercontent.com/u/7605670?v=2","gravatar_id":"","url":"https://api.github.com/users/citra-emu","html_url":"https://github.com/citra-emu","followers_url":"https://api.github.com/users/citra-emu/followers","following_url":"https://api.github.com/users/citra-emu/following{/other_user}","gists_url":"https://api.github.com/users/citra-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/citra-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/citra-emu/subscriptions","organizations_url":"https://api.github.com/users/citra-emu/orgs","repos_url":"https://api.github.com/users/citra-emu/repos","events_url":"https://api.github.com/users/citra-emu/events{/privacy}","received_events_url":"https://api.github.com/users/citra-emu/received_events","type":"Organization","site_admin":false},"repo":{"id":19866730,"name":"citra","full_name":"citra-emu/citra","owner":{"login":"citra-emu","id":7605670,"avatar_url":"https://avatars.githubusercontent.com/u/7605670?v=2","gravatar_id":"","url":"https://api.github.com/users/citra-emu","html_url":"https://github.com/citra-emu","followers_url":"https://api.github.com/users/citra-emu/followers","following_url":"https://api.github.com/users/citra-emu/following{/other_user}","gists_url":"https://api.github.com/users/citra-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/citra-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/citra-emu/subscriptions","organizations_url":"https://api.github.com/users/citra-emu/orgs","repos_url":"https://api.github.com/users/citra-emu/repos","events_url":"https://api.github.com/users/citra-emu/events{/privacy}","received_events_url":"https://api.github.com/users/citra-emu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/citra-emu/citra","description":"Nintendo 3DS emulator/debugger","fork":false,"url":"https://api.github.com/repos/citra-emu/citra","forks_url":"https://api.github.com/repos/citra-emu/citra/forks","keys_url":"https://api.github.com/repos/citra-emu/citra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/citra-emu/citra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/citra-emu/citra/teams","hooks_url":"https://api.github.com/repos/citra-emu/citra/hooks","issue_events_url":"https://api.github.com/repos/citra-emu/citra/issues/events{/number}","events_url":"https://api.github.com/repos/citra-emu/citra/events","assignees_url":"https://api.github.com/repos/citra-emu/citra/assignees{/user}","branches_url":"https://api.github.com/repos/citra-emu/citra/branches{/branch}","tags_url":"https://api.github.com/repos/citra-emu/citra/tags","blobs_url":"https://api.github.com/repos/citra-emu/citra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/citra-emu/citra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/citra-emu/citra/git/refs{/sha}","trees_url":"https://api.github.com/repos/citra-emu/citra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/citra-emu/citra/statuses/{sha}","languages_url":"https://api.github.com/repos/citra-emu/citra/languages","stargazers_url":"https://api.github.com/repos/citra-emu/citra/stargazers","contributors_url":"https://api.github.com/repos/citra-emu/citra/contributors","subscribers_url":"https://api.github.com/repos/citra-emu/citra/subscribers","subscription_url":"https://api.github.com/repos/citra-emu/citra/subscription","commits_url":"https://api.github.com/repos/citra-emu/citra/commits{/sha}","git_commits_url":"https://api.github.com/repos/citra-emu/citra/git/commits{/sha}","comments_url":"https://api.github.com/repos/citra-emu/citra/comments{/number}","issue_comment_url":"https://api.github.com/repos/citra-emu/citra/issues/comments/{number}","contents_url":"https://api.github.com/repos/citra-emu/citra/contents/{+path}","compare_url":"https://api.github.com/repos/citra-emu/citra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/citra-emu/citra/merges","archive_url":"https://api.github.com/repos/citra-emu/citra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/citra-emu/citra/downloads","issues_url":"https://api.github.com/repos/citra-emu/citra/issues{/number}","pulls_url":"https://api.github.com/repos/citra-emu/citra/pulls{/number}","milestones_url":"https://api.github.com/repos/citra-emu/citra/milestones{/number}","notifications_url":"https://api.github.com/repos/citra-emu/citra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/citra-emu/citra/labels{/name}","releases_url":"https://api.github.com/repos/citra-emu/citra/releases{/id}","created_at":"2014-05-16T18:33:15Z","updated_at":"2014-09-29T21:01:48Z","pushed_at":"2014-09-23T02:02:53Z","git_url":"git://github.com/citra-emu/citra.git","ssh_url":"git@github.com:citra-emu/citra.git","clone_url":"https://github.com/citra-emu/citra.git","svn_url":"https://github.com/citra-emu/citra","homepage":null,"size":8972,"stargazers_count":213,"watchers_count":213,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":60,"mirror_url":null,"open_issues_count":17,"forks":60,"open_issues":17,"watchers":213,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/121"},"html":{"href":"https://github.com/citra-emu/citra/pull/121"},"issue":{"href":"https://api.github.com/repos/citra-emu/citra/issues/121"},"comments":{"href":"https://api.github.com/repos/citra-emu/citra/issues/121/comments"},"review_comments":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/121/comments"},"review_comment":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/121/commits"},"statuses":{"href":"https://api.github.com/repos/citra-emu/citra/statuses/f3a7d3c26c6bdff47e4b09271718d5db1b693a80"}}}}