GitHub PullRequestReviewCommentEvent at 2014-09-30 11:29:43
Repository: Firmware
Actor: thomasgubler
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/PX4/Firmware/pulls/comments/18211244","id":18211244,"diff_hunk":"@@ -1499,10 +1608,40 @@ int commander_thread_main(int argc, char *argv[])\n \t\t\tif (!status.data_link_lost) {\n \t\t\t\tmavlink_log_critical(mavlink_fd, \"ALL DATA LINKS LOST\");\n \t\t\t\tstatus.data_link_lost = true;\n+\t\t\t\tstatus.data_link_lost_counter++;\n \t\t\t\tstatus_changed = true;\n \t\t\t}\n \t\t}\n \n+\t\t/* Check engine failure\n+\t\t * only for fixed wing for now\n+\t\t */\n+\t\tif (!circuit_breaker_enabled(\"CBRK_ENGINEFAIL\", CBRK_ENGINEFAIL_KEY) &&","path":"src/modules/commander/commander.cpp","position":244,"original_position":244,"commit_id":"d4c0dc2ba0271f4d9c8044fd2a3a178cbb9987e3","original_commit_id":"d4c0dc2ba0271f4d9c8044fd2a3a178cbb9987e3","user":{"login":"thomasgubler","id":1419479,"avatar_url":"https://avatars.githubusercontent.com/u/1419479?v=2","gravatar_id":"","url":"https://api.github.com/users/thomasgubler","html_url":"https://github.com/thomasgubler","followers_url":"https://api.github.com/users/thomasgubler/followers","following_url":"https://api.github.com/users/thomasgubler/following{/other_user}","gists_url":"https://api.github.com/users/thomasgubler/gists{/gist_id}","starred_url":"https://api.github.com/users/thomasgubler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomasgubler/subscriptions","organizations_url":"https://api.github.com/users/thomasgubler/orgs","repos_url":"https://api.github.com/users/thomasgubler/repos","events_url":"https://api.github.com/users/thomasgubler/events{/privacy}","received_events_url":"https://api.github.com/users/thomasgubler/received_events","type":"User","site_admin":false},"body":"I am going to change it. We should really think about changing the circuit breaker interface to do that automatically.","created_at":"2014-09-30T11:29:43Z","updated_at":"2014-09-30T11:29:43Z","html_url":"https://github.com/PX4/Firmware/pull/1213#discussion_r18211244","pull_request_url":"https://api.github.com/repos/PX4/Firmware/pulls/1213","_links":{"self":{"href":"https://api.github.com/repos/PX4/Firmware/pulls/comments/18211244"},"html":{"href":"https://github.com/PX4/Firmware/pull/1213#discussion_r18211244"},"pull_request":{"href":"https://api.github.com/repos/PX4/Firmware/pulls/1213"}}},"pull_request":{"url":"https://api.github.com/repos/PX4/Firmware/pulls/1213","id":18622351,"html_url":"https://github.com/PX4/Firmware/pull/1213","diff_url":"https://github.com/PX4/Firmware/pull/1213.diff","patch_url":"https://github.com/PX4/Firmware/pull/1213.patch","issue_url":"https://api.github.com/repos/PX4/Firmware/issues/1213","number":1213,"state":"open","locked":false,"title":"Obc failsafe","user":{"login":"thomasgubler","id":1419479,"avatar_url":"https://avatars.githubusercontent.com/u/1419479?v=2","gravatar_id":"","url":"https://api.github.com/users/thomasgubler","html_url":"https://github.com/thomasgubler","followers_url":"https://api.github.com/users/thomasgubler/followers","following_url":"https://api.github.com/users/thomasgubler/following{/other_user}","gists_url":"https://api.github.com/users/thomasgubler/gists{/gist_id}","starred_url":"https://api.github.com/users/thomasgubler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomasgubler/subscriptions","organizations_url":"https://api.github.com/users/thomasgubler/orgs","repos_url":"https://api.github.com/users/thomasgubler/repos","events_url":"https://api.github.com/users/thomasgubler/events{/privacy}","received_events_url":"https://api.github.com/users/thomasgubler/received_events","type":"User","site_admin":false},"body":"This is a *WIP* PR to track progress in bringing up failsafe behavior according to the OBC rules (and also improving general failsafe behavior)\r\n\r\nincludes #1205","created_at":"2014-07-19T17:29:41Z","updated_at":"2014-09-30T11:29:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1335ee117d3e5dd29604fa3921bfd0699bec325b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/PX4/Firmware/pulls/1213/commits","review_comments_url":"https://api.github.com/repos/PX4/Firmware/pulls/1213/comments","review_comment_url":"https://api.github.com/repos/PX4/Firmware/pulls/comments/{number}","comments_url":"https://api.github.com/repos/PX4/Firmware/issues/1213/comments","statuses_url":"https://api.github.com/repos/PX4/Firmware/statuses/d4c0dc2ba0271f4d9c8044fd2a3a178cbb9987e3","head":{"label":"PX4:obcfailsafe","ref":"obcfailsafe","sha":"d4c0dc2ba0271f4d9c8044fd2a3a178cbb9987e3","user":{"login":"PX4","id":2096014,"avatar_url":"https://avatars.githubusercontent.com/u/2096014?v=2","gravatar_id":"","url":"https://api.github.com/users/PX4","html_url":"https://github.com/PX4","followers_url":"https://api.github.com/users/PX4/followers","following_url":"https://api.github.com/users/PX4/following{/other_user}","gists_url":"https://api.github.com/users/PX4/gists{/gist_id}","starred_url":"https://api.github.com/users/PX4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PX4/subscriptions","organizations_url":"https://api.github.com/users/PX4/orgs","repos_url":"https://api.github.com/users/PX4/repos","events_url":"https://api.github.com/users/PX4/events{/privacy}","received_events_url":"https://api.github.com/users/PX4/received_events","type":"Organization","site_admin":false},"repo":{"id":5298790,"name":"Firmware","full_name":"PX4/Firmware","owner":{"login":"PX4","id":2096014,"avatar_url":"https://avatars.githubusercontent.com/u/2096014?v=2","gravatar_id":"","url":"https://api.github.com/users/PX4","html_url":"https://github.com/PX4","followers_url":"https://api.github.com/users/PX4/followers","following_url":"https://api.github.com/users/PX4/following{/other_user}","gists_url":"https://api.github.com/users/PX4/gists{/gist_id}","starred_url":"https://api.github.com/users/PX4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PX4/subscriptions","organizations_url":"https://api.github.com/users/PX4/orgs","repos_url":"https://api.github.com/users/PX4/repos","events_url":"https://api.github.com/users/PX4/events{/privacy}","received_events_url":"https://api.github.com/users/PX4/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PX4/Firmware","description":"PX4 Firmware for PX4FMU autopilot and PX4IO servo / failsafe board","fork":false,"url":"https://api.github.com/repos/PX4/Firmware","forks_url":"https://api.github.com/repos/PX4/Firmware/forks","keys_url":"https://api.github.com/repos/PX4/Firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PX4/Firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PX4/Firmware/teams","hooks_url":"https://api.github.com/repos/PX4/Firmware/hooks","issue_events_url":"https://api.github.com/repos/PX4/Firmware/issues/events{/number}","events_url":"https://api.github.com/repos/PX4/Firmware/events","assignees_url":"https://api.github.com/repos/PX4/Firmware/assignees{/user}","branches_url":"https://api.github.com/repos/PX4/Firmware/branches{/branch}","tags_url":"https://api.github.com/repos/PX4/Firmware/tags","blobs_url":"https://api.github.com/repos/PX4/Firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PX4/Firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PX4/Firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/PX4/Firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PX4/Firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/PX4/Firmware/languages","stargazers_url":"https://api.github.com/repos/PX4/Firmware/stargazers","contributors_url":"https://api.github.com/repos/PX4/Firmware/contributors","subscribers_url":"https://api.github.com/repos/PX4/Firmware/subscribers","subscription_url":"https://api.github.com/repos/PX4/Firmware/subscription","commits_url":"https://api.github.com/repos/PX4/Firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/PX4/Firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/PX4/Firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/PX4/Firmware/issues/comments/{number}","contents_url":"https://api.github.com/repos/PX4/Firmware/contents/{+path}","compare_url":"https://api.github.com/repos/PX4/Firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PX4/Firmware/merges","archive_url":"https://api.github.com/repos/PX4/Firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PX4/Firmware/downloads","issues_url":"https://api.github.com/repos/PX4/Firmware/issues{/number}","pulls_url":"https://api.github.com/repos/PX4/Firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/PX4/Firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/PX4/Firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PX4/Firmware/labels{/name}","releases_url":"https://api.github.com/repos/PX4/Firmware/releases{/id}","created_at":"2012-08-04T21:19:36Z","updated_at":"2014-09-28T15:53:56Z","pushed_at":"2014-09-30T09:20:45Z","git_url":"git://github.com/PX4/Firmware.git","ssh_url":"git@github.com:PX4/Firmware.git","clone_url":"https://github.com/PX4/Firmware.git","svn_url":"https://github.com/PX4/Firmware","homepage":"https://pixhawk.ethz.ch/px4/","size":135484,"stargazers_count":171,"watchers_count":171,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":556,"mirror_url":null,"open_issues_count":133,"forks":556,"open_issues":133,"watchers":171,"default_branch":"master"}},"base":{"label":"PX4:master","ref":"master","sha":"8ced6bb49bf32128d2673e565cb112ca6d2f21eb","user":{"login":"PX4","id":2096014,"avatar_url":"https://avatars.githubusercontent.com/u/2096014?v=2","gravatar_id":"","url":"https://api.github.com/users/PX4","html_url":"https://github.com/PX4","followers_url":"https://api.github.com/users/PX4/followers","following_url":"https://api.github.com/users/PX4/following{/other_user}","gists_url":"https://api.github.com/users/PX4/gists{/gist_id}","starred_url":"https://api.github.com/users/PX4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PX4/subscriptions","organizations_url":"https://api.github.com/users/PX4/orgs","repos_url":"https://api.github.com/users/PX4/repos","events_url":"https://api.github.com/users/PX4/events{/privacy}","received_events_url":"https://api.github.com/users/PX4/received_events","type":"Organization","site_admin":false},"repo":{"id":5298790,"name":"Firmware","full_name":"PX4/Firmware","owner":{"login":"PX4","id":2096014,"avatar_url":"https://avatars.githubusercontent.com/u/2096014?v=2","gravatar_id":"","url":"https://api.github.com/users/PX4","html_url":"https://github.com/PX4","followers_url":"https://api.github.com/users/PX4/followers","following_url":"https://api.github.com/users/PX4/following{/other_user}","gists_url":"https://api.github.com/users/PX4/gists{/gist_id}","starred_url":"https://api.github.com/users/PX4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PX4/subscriptions","organizations_url":"https://api.github.com/users/PX4/orgs","repos_url":"https://api.github.com/users/PX4/repos","events_url":"https://api.github.com/users/PX4/events{/privacy}","received_events_url":"https://api.github.com/users/PX4/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PX4/Firmware","description":"PX4 Firmware for PX4FMU autopilot and PX4IO servo / failsafe board","fork":false,"url":"https://api.github.com/repos/PX4/Firmware","forks_url":"https://api.github.com/repos/PX4/Firmware/forks","keys_url":"https://api.github.com/repos/PX4/Firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PX4/Firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PX4/Firmware/teams","hooks_url":"https://api.github.com/repos/PX4/Firmware/hooks","issue_events_url":"https://api.github.com/repos/PX4/Firmware/issues/events{/number}","events_url":"https://api.github.com/repos/PX4/Firmware/events","assignees_url":"https://api.github.com/repos/PX4/Firmware/assignees{/user}","branches_url":"https://api.github.com/repos/PX4/Firmware/branches{/branch}","tags_url":"https://api.github.com/repos/PX4/Firmware/tags","blobs_url":"https://api.github.com/repos/PX4/Firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PX4/Firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PX4/Firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/PX4/Firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PX4/Firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/PX4/Firmware/languages","stargazers_url":"https://api.github.com/repos/PX4/Firmware/stargazers","contributors_url":"https://api.github.com/repos/PX4/Firmware/contributors","subscribers_url":"https://api.github.com/repos/PX4/Firmware/subscribers","subscription_url":"https://api.github.com/repos/PX4/Firmware/subscription","commits_url":"https://api.github.com/repos/PX4/Firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/PX4/Firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/PX4/Firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/PX4/Firmware/issues/comments/{number}","contents_url":"https://api.github.com/repos/PX4/Firmware/contents/{+path}","compare_url":"https://api.github.com/repos/PX4/Firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PX4/Firmware/merges","archive_url":"https://api.github.com/repos/PX4/Firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PX4/Firmware/downloads","issues_url":"https://api.github.com/repos/PX4/Firmware/issues{/number}","pulls_url":"https://api.github.com/repos/PX4/Firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/PX4/Firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/PX4/Firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PX4/Firmware/labels{/name}","releases_url":"https://api.github.com/repos/PX4/Firmware/releases{/id}","created_at":"2012-08-04T21:19:36Z","updated_at":"2014-09-28T15:53:56Z","pushed_at":"2014-09-30T09:20:45Z","git_url":"git://github.com/PX4/Firmware.git","ssh_url":"git@github.com:PX4/Firmware.git","clone_url":"https://github.com/PX4/Firmware.git","svn_url":"https://github.com/PX4/Firmware","homepage":"https://pixhawk.ethz.ch/px4/","size":135484,"stargazers_count":171,"watchers_count":171,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":556,"mirror_url":null,"open_issues_count":133,"forks":556,"open_issues":133,"watchers":171,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PX4/Firmware/pulls/1213"},"html":{"href":"https://github.com/PX4/Firmware/pull/1213"},"issue":{"href":"https://api.github.com/repos/PX4/Firmware/issues/1213"},"comments":{"href":"https://api.github.com/repos/PX4/Firmware/issues/1213/comments"},"review_comments":{"href":"https://api.github.com/repos/PX4/Firmware/pulls/1213/comments"},"review_comment":{"href":"https://api.github.com/repos/PX4/Firmware/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/PX4/Firmware/pulls/1213/commits"},"statuses":{"href":"https://api.github.com/repos/PX4/Firmware/statuses/d4c0dc2ba0271f4d9c8044fd2a3a178cbb9987e3"}}}}