GitHub PullRequestReviewCommentEvent at 2014-07-31 08:41:41
Repository: frontend
Actor: jamesgorrie
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/guardian/frontend/pulls/comments/15631369","id":15631369,"diff_hunk":"@@ -16,85 +16,122 @@ define([\n     storage\n     ) {\n \n-    var HistoryItem = function(item) {\n+    var history,","path":"common/app/assets/javascripts/modules/onward/history.js","position":5,"original_position":5,"commit_id":"6609d1c8223ff6cf2737b151919c1f710c367d33","original_commit_id":"6609d1c8223ff6cf2737b151919c1f710c367d33","user":{"login":"jamesgorrie","id":31692,"avatar_url":"https://avatars.githubusercontent.com/u/31692?v=1","gravatar_id":"d20f71813149bc8baa3a1525f46370e1","url":"https://api.github.com/users/jamesgorrie","html_url":"https://github.com/jamesgorrie","followers_url":"https://api.github.com/users/jamesgorrie/followers","following_url":"https://api.github.com/users/jamesgorrie/following{/other_user}","gists_url":"https://api.github.com/users/jamesgorrie/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesgorrie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesgorrie/subscriptions","organizations_url":"https://api.github.com/users/jamesgorrie/orgs","repos_url":"https://api.github.com/users/jamesgorrie/repos","events_url":"https://api.github.com/users/jamesgorrie/events{/privacy}","received_events_url":"https://api.github.com/users/jamesgorrie/received_events","type":"User","site_admin":false},"body":"Is this a little dangerous given that window.history is a var?\r\nNow you can't access that in here.\r\n","created_at":"2014-07-31T08:41:41Z","updated_at":"2014-07-31T08:41:41Z","html_url":"https://github.com/guardian/frontend/pull/5301#discussion_r15631369","pull_request_url":"https://api.github.com/repos/guardian/frontend/pulls/5301","_links":{"self":{"href":"https://api.github.com/repos/guardian/frontend/pulls/comments/15631369"},"html":{"href":"https://github.com/guardian/frontend/pull/5301#discussion_r15631369"},"pull_request":{"href":"https://api.github.com/repos/guardian/frontend/pulls/5301"}}},"pull_request":{"url":"https://api.github.com/repos/guardian/frontend/pulls/5301","id":19112448,"html_url":"https://github.com/guardian/frontend/pull/5301","diff_url":"https://github.com/guardian/frontend/pull/5301.diff","patch_url":"https://github.com/guardian/frontend/pull/5301.patch","issue_url":"https://api.github.com/repos/guardian/frontend/issues/5301","number":5301,"state":"open","title":"History refactor","user":{"login":"stephanfowler","id":1147913,"avatar_url":"https://avatars.githubusercontent.com/u/1147913?v=1","gravatar_id":"a24a5fa8750bbc8ef2c8bf20933c4a8d","url":"https://api.github.com/users/stephanfowler","html_url":"https://github.com/stephanfowler","followers_url":"https://api.github.com/users/stephanfowler/followers","following_url":"https://api.github.com/users/stephanfowler/following{/other_user}","gists_url":"https://api.github.com/users/stephanfowler/gists{/gist_id}","starred_url":"https://api.github.com/users/stephanfowler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephanfowler/subscriptions","organizations_url":"https://api.github.com/users/stephanfowler/orgs","repos_url":"https://api.github.com/users/stephanfowler/repos","events_url":"https://api.github.com/users/stephanfowler/events{/privacy}","received_events_url":"https://api.github.com/users/stephanfowler/received_events","type":"User","site_admin":false},"body":"* makes history into a singleton\r\n* adds a summary of visited sections and (primary) keywords\r\n* removes repeats from history, and instead:\r\n    * moves repeated page to front of list  \r\n    * maintains most-recent-first order\r\n    * adds count of # of visits to each page\r\n    * updates it's timestamp\r\n* removes sequence.js\r\n\r\n@phamann : I'm now adding __everything__ to history except network fronts and liveblogs..\r\n* will adding section/tag fronts mess up your use of history?\r\n* can I actually add liveblogs, now that deduping happens?\r\n\r\n@NathanielBennett : I can't find any use of `recentVisits` or `numberOfSessionsSince` functions. Do you need them any more?","created_at":"2014-07-30T19:42:41Z","updated_at":"2014-07-31T08:41:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bc025be7abd5b5cd0ef5a72a4ce4d233a29f777f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/guardian/frontend/pulls/5301/commits","review_comments_url":"https://api.github.com/repos/guardian/frontend/pulls/5301/comments","review_comment_url":"https://api.github.com/repos/guardian/frontend/pulls/comments/{number}","comments_url":"https://api.github.com/repos/guardian/frontend/issues/5301/comments","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/6609d1c8223ff6cf2737b151919c1f710c367d33","head":{"label":"guardian:history-refactor","ref":"history-refactor","sha":"6609d1c8223ff6cf2737b151919c1f710c367d33","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=1","gravatar_id":"2ddf2e74b78084fcf451b3cdeb075e73","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":4370755,"name":"frontend","full_name":"guardian/frontend","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=1","gravatar_id":"2ddf2e74b78084fcf451b3cdeb075e73","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/frontend","description":"Source for the Guardian's responsive site, coming soon to a desktop near you...","fork":false,"url":"https://api.github.com/repos/guardian/frontend","forks_url":"https://api.github.com/repos/guardian/frontend/forks","keys_url":"https://api.github.com/repos/guardian/frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/frontend/teams","hooks_url":"https://api.github.com/repos/guardian/frontend/hooks","issue_events_url":"https://api.github.com/repos/guardian/frontend/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/frontend/events","assignees_url":"https://api.github.com/repos/guardian/frontend/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/frontend/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/frontend/tags","blobs_url":"https://api.github.com/repos/guardian/frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/frontend/languages","stargazers_url":"https://api.github.com/repos/guardian/frontend/stargazers","contributors_url":"https://api.github.com/repos/guardian/frontend/contributors","subscribers_url":"https://api.github.com/repos/guardian/frontend/subscribers","subscription_url":"https://api.github.com/repos/guardian/frontend/subscription","commits_url":"https://api.github.com/repos/guardian/frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/frontend/issues/comments/{number}","contents_url":"https://api.github.com/repos/guardian/frontend/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/frontend/merges","archive_url":"https://api.github.com/repos/guardian/frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/frontend/downloads","issues_url":"https://api.github.com/repos/guardian/frontend/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/frontend/labels{/name}","releases_url":"https://api.github.com/repos/guardian/frontend/releases{/id}","created_at":"2012-05-18T15:39:15Z","updated_at":"2014-07-30T18:32:54Z","pushed_at":"2014-07-31T08:22:24Z","git_url":"git://github.com/guardian/frontend.git","ssh_url":"git@github.com:guardian/frontend.git","clone_url":"https://github.com/guardian/frontend.git","svn_url":"https://github.com/guardian/frontend","homepage":"http://www.theguardian.com/uk?view=mobile","size":420059,"stargazers_count":2188,"watchers_count":2188,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":183,"mirror_url":null,"open_issues_count":56,"forks":183,"open_issues":56,"watchers":2188,"default_branch":"master"}},"base":{"label":"guardian:master","ref":"master","sha":"db08ce2d2cfbf3e9a27a96af686e7859cbd7ac77","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=1","gravatar_id":"2ddf2e74b78084fcf451b3cdeb075e73","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":4370755,"name":"frontend","full_name":"guardian/frontend","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=1","gravatar_id":"2ddf2e74b78084fcf451b3cdeb075e73","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/frontend","description":"Source for the Guardian's responsive site, coming soon to a desktop near you...","fork":false,"url":"https://api.github.com/repos/guardian/frontend","forks_url":"https://api.github.com/repos/guardian/frontend/forks","keys_url":"https://api.github.com/repos/guardian/frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/frontend/teams","hooks_url":"https://api.github.com/repos/guardian/frontend/hooks","issue_events_url":"https://api.github.com/repos/guardian/frontend/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/frontend/events","assignees_url":"https://api.github.com/repos/guardian/frontend/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/frontend/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/frontend/tags","blobs_url":"https://api.github.com/repos/guardian/frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/frontend/languages","stargazers_url":"https://api.github.com/repos/guardian/frontend/stargazers","contributors_url":"https://api.github.com/repos/guardian/frontend/contributors","subscribers_url":"https://api.github.com/repos/guardian/frontend/subscribers","subscription_url":"https://api.github.com/repos/guardian/frontend/subscription","commits_url":"https://api.github.com/repos/guardian/frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/frontend/issues/comments/{number}","contents_url":"https://api.github.com/repos/guardian/frontend/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/frontend/merges","archive_url":"https://api.github.com/repos/guardian/frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/frontend/downloads","issues_url":"https://api.github.com/repos/guardian/frontend/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/frontend/labels{/name}","releases_url":"https://api.github.com/repos/guardian/frontend/releases{/id}","created_at":"2012-05-18T15:39:15Z","updated_at":"2014-07-30T18:32:54Z","pushed_at":"2014-07-31T08:22:24Z","git_url":"git://github.com/guardian/frontend.git","ssh_url":"git@github.com:guardian/frontend.git","clone_url":"https://github.com/guardian/frontend.git","svn_url":"https://github.com/guardian/frontend","homepage":"http://www.theguardian.com/uk?view=mobile","size":420059,"stargazers_count":2188,"watchers_count":2188,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":183,"mirror_url":null,"open_issues_count":56,"forks":183,"open_issues":56,"watchers":2188,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/guardian/frontend/pulls/5301"},"html":{"href":"https://github.com/guardian/frontend/pull/5301"},"issue":{"href":"https://api.github.com/repos/guardian/frontend/issues/5301"},"comments":{"href":"https://api.github.com/repos/guardian/frontend/issues/5301/comments"},"review_comments":{"href":"https://api.github.com/repos/guardian/frontend/pulls/5301/comments"},"review_comment":{"href":"https://api.github.com/repos/guardian/frontend/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/guardian/frontend/pulls/5301/commits"},"statuses":{"href":"https://api.github.com/repos/guardian/frontend/statuses/6609d1c8223ff6cf2737b151919c1f710c367d33"}}}}