GitHub PullRequestEvent at 2014-06-15 23:46:38
Repository: external_naginator
Actor: russell
Payload: {"action":"opened","number":3,"pull_request":{"url":"https://api.github.com/repos/daniellawrence/external_naginator/pulls/3","id":17157535,"html_url":"https://github.com/daniellawrence/external_naginator/pull/3","diff_url":"https://github.com/daniellawrence/external_naginator/pull/3.diff","patch_url":"https://github.com/daniellawrence/external_naginator/pull/3.patch","issue_url":"https://api.github.com/repos/daniellawrence/external_naginator/issues/3","number":3,"state":"open","title":"Sorry for the massive amount of changes.","user":{"login":"russell","id":2660,"avatar_url":"https://avatars.githubusercontent.com/u/2660?","gravatar_id":"9f656c1da1eef46c4f8384725234f557","url":"https://api.github.com/users/russell","html_url":"https://github.com/russell","followers_url":"https://api.github.com/users/russell/followers","following_url":"https://api.github.com/users/russell/following{/other_user}","gists_url":"https://api.github.com/users/russell/gists{/gist_id}","starred_url":"https://api.github.com/users/russell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/russell/subscriptions","organizations_url":"https://api.github.com/users/russell/orgs","repos_url":"https://api.github.com/users/russell/repos","events_url":"https://api.github.com/users/russell/events{/privacy}","received_events_url":"https://api.github.com/users/russell/received_events","type":"User","site_admin":false},"body":"Right,\r\n\r\nSo.\r\n\r\nbasically, i'm tossing this over the fence because it's enough for everything to be configurable without needing modify the generate.py.\r\n\r\nI think that probably the way forward is to create a class for each of the nagios types instead of having one class that does everything.  It's probably too hard to split this up.  But I'm happy to do any changes you suggest.\r\n\r\nCheers,\r\nRussell","created_at":"2014-06-15T23:46:38Z","updated_at":"2014-06-15T23:46:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/daniellawrence/external_naginator/pulls/3/commits","review_comments_url":"https://api.github.com/repos/daniellawrence/external_naginator/pulls/3/comments","review_comment_url":"https://api.github.com/repos/daniellawrence/external_naginator/pulls/comments/{number}","comments_url":"https://api.github.com/repos/daniellawrence/external_naginator/issues/3/comments","statuses_url":"https://api.github.com/repos/daniellawrence/external_naginator/statuses/4c8bde63d7d91693c8a329d889312a81c1b3ee21","head":{"label":"russell:master","ref":"master","sha":"4c8bde63d7d91693c8a329d889312a81c1b3ee21","user":{"login":"russell","id":2660,"avatar_url":"https://avatars.githubusercontent.com/u/2660?","gravatar_id":"9f656c1da1eef46c4f8384725234f557","url":"https://api.github.com/users/russell","html_url":"https://github.com/russell","followers_url":"https://api.github.com/users/russell/followers","following_url":"https://api.github.com/users/russell/following{/other_user}","gists_url":"https://api.github.com/users/russell/gists{/gist_id}","starred_url":"https://api.github.com/users/russell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/russell/subscriptions","organizations_url":"https://api.github.com/users/russell/orgs","repos_url":"https://api.github.com/users/russell/repos","events_url":"https://api.github.com/users/russell/events{/privacy}","received_events_url":"https://api.github.com/users/russell/received_events","type":"User","site_admin":false},"repo":{"id":20550105,"name":"external_naginator","full_name":"russell/external_naginator","owner":{"login":"russell","id":2660,"avatar_url":"https://avatars.githubusercontent.com/u/2660?","gravatar_id":"9f656c1da1eef46c4f8384725234f557","url":"https://api.github.com/users/russell","html_url":"https://github.com/russell","followers_url":"https://api.github.com/users/russell/followers","following_url":"https://api.github.com/users/russell/following{/other_user}","gists_url":"https://api.github.com/users/russell/gists{/gist_id}","starred_url":"https://api.github.com/users/russell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/russell/subscriptions","organizations_url":"https://api.github.com/users/russell/orgs","repos_url":"https://api.github.com/users/russell/repos","events_url":"https://api.github.com/users/russell/events{/privacy}","received_events_url":"https://api.github.com/users/russell/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/russell/external_naginator","description":"Generate nagios configuration with 20,000 items from puppetdb in seconds.","fork":true,"url":"https://api.github.com/repos/russell/external_naginator","forks_url":"https://api.github.com/repos/russell/external_naginator/forks","keys_url":"https://api.github.com/repos/russell/external_naginator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/russell/external_naginator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/russell/external_naginator/teams","hooks_url":"https://api.github.com/repos/russell/external_naginator/hooks","issue_events_url":"https://api.github.com/repos/russell/external_naginator/issues/events{/number}","events_url":"https://api.github.com/repos/russell/external_naginator/events","assignees_url":"https://api.github.com/repos/russell/external_naginator/assignees{/user}","branches_url":"https://api.github.com/repos/russell/external_naginator/branches{/branch}","tags_url":"https://api.github.com/repos/russell/external_naginator/tags","blobs_url":"https://api.github.com/repos/russell/external_naginator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/russell/external_naginator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/russell/external_naginator/git/refs{/sha}","trees_url":"https://api.github.com/repos/russell/external_naginator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/russell/external_naginator/statuses/{sha}","languages_url":"https://api.github.com/repos/russell/external_naginator/languages","stargazers_url":"https://api.github.com/repos/russell/external_naginator/stargazers","contributors_url":"https://api.github.com/repos/russell/external_naginator/contributors","subscribers_url":"https://api.github.com/repos/russell/external_naginator/subscribers","subscription_url":"https://api.github.com/repos/russell/external_naginator/subscription","commits_url":"https://api.github.com/repos/russell/external_naginator/commits{/sha}","git_commits_url":"https://api.github.com/repos/russell/external_naginator/git/commits{/sha}","comments_url":"https://api.github.com/repos/russell/external_naginator/comments{/number}","issue_comment_url":"https://api.github.com/repos/russell/external_naginator/issues/comments/{number}","contents_url":"https://api.github.com/repos/russell/external_naginator/contents/{+path}","compare_url":"https://api.github.com/repos/russell/external_naginator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/russell/external_naginator/merges","archive_url":"https://api.github.com/repos/russell/external_naginator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/russell/external_naginator/downloads","issues_url":"https://api.github.com/repos/russell/external_naginator/issues{/number}","pulls_url":"https://api.github.com/repos/russell/external_naginator/pulls{/number}","milestones_url":"https://api.github.com/repos/russell/external_naginator/milestones{/number}","notifications_url":"https://api.github.com/repos/russell/external_naginator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/russell/external_naginator/labels{/name}","releases_url":"https://api.github.com/repos/russell/external_naginator/releases{/id}","created_at":"2014-06-06T03:24:36Z","updated_at":"2014-06-15T23:46:38Z","pushed_at":"2014-06-15T23:40:06Z","git_url":"git://github.com/russell/external_naginator.git","ssh_url":"git@github.com:russell/external_naginator.git","clone_url":"https://github.com/russell/external_naginator.git","svn_url":"https://github.com/russell/external_naginator","homepage":null,"size":135,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"daniellawrence:master","ref":"master","sha":"5320b7996467335dff06dc28df87f9ebc5f5b97a","user":{"login":"daniellawrence","id":814463,"avatar_url":"https://avatars.githubusercontent.com/u/814463?","gravatar_id":"40bc6014b732acda1521af3347ba7c9d","url":"https://api.github.com/users/daniellawrence","html_url":"https://github.com/daniellawrence","followers_url":"https://api.github.com/users/daniellawrence/followers","following_url":"https://api.github.com/users/daniellawrence/following{/other_user}","gists_url":"https://api.github.com/users/daniellawrence/gists{/gist_id}","starred_url":"https://api.github.com/users/daniellawrence/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daniellawrence/subscriptions","organizations_url":"https://api.github.com/users/daniellawrence/orgs","repos_url":"https://api.github.com/users/daniellawrence/repos","events_url":"https://api.github.com/users/daniellawrence/events{/privacy}","received_events_url":"https://api.github.com/users/daniellawrence/received_events","type":"User","site_admin":false},"repo":{"id":20549752,"name":"external_naginator","full_name":"daniellawrence/external_naginator","owner":{"login":"daniellawrence","id":814463,"avatar_url":"https://avatars.githubusercontent.com/u/814463?","gravatar_id":"40bc6014b732acda1521af3347ba7c9d","url":"https://api.github.com/users/daniellawrence","html_url":"https://github.com/daniellawrence","followers_url":"https://api.github.com/users/daniellawrence/followers","following_url":"https://api.github.com/users/daniellawrence/following{/other_user}","gists_url":"https://api.github.com/users/daniellawrence/gists{/gist_id}","starred_url":"https://api.github.com/users/daniellawrence/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daniellawrence/subscriptions","organizations_url":"https://api.github.com/users/daniellawrence/orgs","repos_url":"https://api.github.com/users/daniellawrence/repos","events_url":"https://api.github.com/users/daniellawrence/events{/privacy}","received_events_url":"https://api.github.com/users/daniellawrence/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/daniellawrence/external_naginator","description":"Generate nagios configuration with 20,000 items from puppetdb in seconds.","fork":false,"url":"https://api.github.com/repos/daniellawrence/external_naginator","forks_url":"https://api.github.com/repos/daniellawrence/external_naginator/forks","keys_url":"https://api.github.com/repos/daniellawrence/external_naginator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/daniellawrence/external_naginator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/daniellawrence/external_naginator/teams","hooks_url":"https://api.github.com/repos/daniellawrence/external_naginator/hooks","issue_events_url":"https://api.github.com/repos/daniellawrence/external_naginator/issues/events{/number}","events_url":"https://api.github.com/repos/daniellawrence/external_naginator/events","assignees_url":"https://api.github.com/repos/daniellawrence/external_naginator/assignees{/user}","branches_url":"https://api.github.com/repos/daniellawrence/external_naginator/branches{/branch}","tags_url":"https://api.github.com/repos/daniellawrence/external_naginator/tags","blobs_url":"https://api.github.com/repos/daniellawrence/external_naginator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/daniellawrence/external_naginator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/daniellawrence/external_naginator/git/refs{/sha}","trees_url":"https://api.github.com/repos/daniellawrence/external_naginator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/daniellawrence/external_naginator/statuses/{sha}","languages_url":"https://api.github.com/repos/daniellawrence/external_naginator/languages","stargazers_url":"https://api.github.com/repos/daniellawrence/external_naginator/stargazers","contributors_url":"https://api.github.com/repos/daniellawrence/external_naginator/contributors","subscribers_url":"https://api.github.com/repos/daniellawrence/external_naginator/subscribers","subscription_url":"https://api.github.com/repos/daniellawrence/external_naginator/subscription","commits_url":"https://api.github.com/repos/daniellawrence/external_naginator/commits{/sha}","git_commits_url":"https://api.github.com/repos/daniellawrence/external_naginator/git/commits{/sha}","comments_url":"https://api.github.com/repos/daniellawrence/external_naginator/comments{/number}","issue_comment_url":"https://api.github.com/repos/daniellawrence/external_naginator/issues/comments/{number}","contents_url":"https://api.github.com/repos/daniellawrence/external_naginator/contents/{+path}","compare_url":"https://api.github.com/repos/daniellawrence/external_naginator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/daniellawrence/external_naginator/merges","archive_url":"https://api.github.com/repos/daniellawrence/external_naginator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/daniellawrence/external_naginator/downloads","issues_url":"https://api.github.com/repos/daniellawrence/external_naginator/issues{/number}","pulls_url":"https://api.github.com/repos/daniellawrence/external_naginator/pulls{/number}","milestones_url":"https://api.github.com/repos/daniellawrence/external_naginator/milestones{/number}","notifications_url":"https://api.github.com/repos/daniellawrence/external_naginator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/daniellawrence/external_naginator/labels{/name}","releases_url":"https://api.github.com/repos/daniellawrence/external_naginator/releases{/id}","created_at":"2014-06-06T03:09:00Z","updated_at":"2014-06-14T07:40:43Z","pushed_at":"2014-06-14T07:40:43Z","git_url":"git://github.com/daniellawrence/external_naginator.git","ssh_url":"git@github.com:daniellawrence/external_naginator.git","clone_url":"https://github.com/daniellawrence/external_naginator.git","svn_url":"https://github.com/daniellawrence/external_naginator","homepage":null,"size":220,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/daniellawrence/external_naginator/pulls/3"},"html":{"href":"https://github.com/daniellawrence/external_naginator/pull/3"},"issue":{"href":"https://api.github.com/repos/daniellawrence/external_naginator/issues/3"},"comments":{"href":"https://api.github.com/repos/daniellawrence/external_naginator/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/daniellawrence/external_naginator/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/daniellawrence/external_naginator/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/daniellawrence/external_naginator/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/daniellawrence/external_naginator/statuses/4c8bde63d7d91693c8a329d889312a81c1b3ee21"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":9,"additions":253,"deletions":158,"changed_files":2}}