GitHub PullRequestReviewCommentEvent at 2014-07-24 19:12:29
Repository: bitcore
Actor: ryanxcharles
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/bitpay/bitcore/pulls/comments/15366193","id":15366193,"diff_hunk":"@@ -107,6 +107,21 @@ describe('Address', function() {\n     });\n   });\n \n+  describe('constructor, 2 params', function() {\n+    it('should make an address from a version, hash', function() {\n+      var hash = new Buffer('1ab59a0fd1d5fc446d38746ee033c8af57ed6bc0', 'hex');\n+      var addr = new Address(0, hash);\n+      addr.toString().should.equal('13SE7uKmnQwGA8X1A8WcZnX2ceQRDEzsAd');\n+    });\n+    it('should fail with param version, string', function() {\n+      var hash = '1ab59a0fd1d5fc446d38746ee033c8af57ed6bc0';\n+      ( function (){ ","path":"test/test.Address.js","position":12,"original_position":12,"commit_id":"71f992138bc9f88316887150a1558c96e45006a2","original_commit_id":"71f992138bc9f88316887150a1558c96e45006a2","user":{"login":"ryanxcharles","id":63740,"avatar_url":"https://avatars.githubusercontent.com/u/63740?","gravatar_id":"17e6619ba42a009b25f1883641e64e1c","url":"https://api.github.com/users/ryanxcharles","html_url":"https://github.com/ryanxcharles","followers_url":"https://api.github.com/users/ryanxcharles/followers","following_url":"https://api.github.com/users/ryanxcharles/following{/other_user}","gists_url":"https://api.github.com/users/ryanxcharles/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanxcharles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanxcharles/subscriptions","organizations_url":"https://api.github.com/users/ryanxcharles/orgs","repos_url":"https://api.github.com/users/ryanxcharles/repos","events_url":"https://api.github.com/users/ryanxcharles/events{/privacy}","received_events_url":"https://api.github.com/users/ryanxcharles/received_events","type":"User","site_admin":false},"body":"\"( function (){\" should be \"(function() {\"","created_at":"2014-07-24T19:12:29Z","updated_at":"2014-07-24T19:12:29Z","html_url":"https://github.com/bitpay/bitcore/pull/450#discussion_r15366193","pull_request_url":"https://api.github.com/repos/bitpay/bitcore/pulls/450","_links":{"self":{"href":"https://api.github.com/repos/bitpay/bitcore/pulls/comments/15366193"},"html":{"href":"https://github.com/bitpay/bitcore/pull/450#discussion_r15366193"},"pull_request":{"href":"https://api.github.com/repos/bitpay/bitcore/pulls/450"}}},"pull_request":{"url":"https://api.github.com/repos/bitpay/bitcore/pulls/450","id":18817852,"html_url":"https://github.com/bitpay/bitcore/pull/450","diff_url":"https://github.com/bitpay/bitcore/pull/450.diff","patch_url":"https://github.com/bitpay/bitcore/pull/450.patch","issue_url":"https://api.github.com/repos/bitpay/bitcore/issues/450","number":450,"state":"open","title":"Feature/sin03","user":{"login":"matiu","id":98844,"avatar_url":"https://avatars.githubusercontent.com/u/98844?","gravatar_id":"56f9e171720d475025c9dff407760a98","url":"https://api.github.com/users/matiu","html_url":"https://github.com/matiu","followers_url":"https://api.github.com/users/matiu/followers","following_url":"https://api.github.com/users/matiu/following{/other_user}","gists_url":"https://api.github.com/users/matiu/gists{/gist_id}","starred_url":"https://api.github.com/users/matiu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matiu/subscriptions","organizations_url":"https://api.github.com/users/matiu/orgs","repos_url":"https://api.github.com/users/matiu/repos","events_url":"https://api.github.com/users/matiu/events{/privacy}","received_events_url":"https://api.github.com/users/matiu/received_events","type":"User","site_admin":false},"body":"\r\n - Implements suggestion by @ryanxcharles at https://github.com/bitpay/bitcore/pull/448#issuecomment-49955307\r\n - Add isBuffer check in address constructor","created_at":"2014-07-24T05:04:15Z","updated_at":"2014-07-24T19:12:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1fb3ee98d8aa5aaf697d2368b4d773df13dd7d54","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bitpay/bitcore/pulls/450/commits","review_comments_url":"https://api.github.com/repos/bitpay/bitcore/pulls/450/comments","review_comment_url":"https://api.github.com/repos/bitpay/bitcore/pulls/comments/{number}","comments_url":"https://api.github.com/repos/bitpay/bitcore/issues/450/comments","statuses_url":"https://api.github.com/repos/bitpay/bitcore/statuses/71f992138bc9f88316887150a1558c96e45006a2","head":{"label":"matiu:feature/sin03","ref":"feature/sin03","sha":"71f992138bc9f88316887150a1558c96e45006a2","user":{"login":"matiu","id":98844,"avatar_url":"https://avatars.githubusercontent.com/u/98844?","gravatar_id":"56f9e171720d475025c9dff407760a98","url":"https://api.github.com/users/matiu","html_url":"https://github.com/matiu","followers_url":"https://api.github.com/users/matiu/followers","following_url":"https://api.github.com/users/matiu/following{/other_user}","gists_url":"https://api.github.com/users/matiu/gists{/gist_id}","starred_url":"https://api.github.com/users/matiu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matiu/subscriptions","organizations_url":"https://api.github.com/users/matiu/orgs","repos_url":"https://api.github.com/users/matiu/repos","events_url":"https://api.github.com/users/matiu/events{/privacy}","received_events_url":"https://api.github.com/users/matiu/received_events","type":"User","site_admin":false},"repo":{"id":15911866,"name":"bitcore","full_name":"matiu/bitcore","owner":{"login":"matiu","id":98844,"avatar_url":"https://avatars.githubusercontent.com/u/98844?","gravatar_id":"56f9e171720d475025c9dff407760a98","url":"https://api.github.com/users/matiu","html_url":"https://github.com/matiu","followers_url":"https://api.github.com/users/matiu/followers","following_url":"https://api.github.com/users/matiu/following{/other_user}","gists_url":"https://api.github.com/users/matiu/gists{/gist_id}","starred_url":"https://api.github.com/users/matiu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matiu/subscriptions","organizations_url":"https://api.github.com/users/matiu/orgs","repos_url":"https://api.github.com/users/matiu/repos","events_url":"https://api.github.com/users/matiu/events{/privacy}","received_events_url":"https://api.github.com/users/matiu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/matiu/bitcore","description":"Nodejs Bitcoin Library","fork":true,"url":"https://api.github.com/repos/matiu/bitcore","forks_url":"https://api.github.com/repos/matiu/bitcore/forks","keys_url":"https://api.github.com/repos/matiu/bitcore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matiu/bitcore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matiu/bitcore/teams","hooks_url":"https://api.github.com/repos/matiu/bitcore/hooks","issue_events_url":"https://api.github.com/repos/matiu/bitcore/issues/events{/number}","events_url":"https://api.github.com/repos/matiu/bitcore/events","assignees_url":"https://api.github.com/repos/matiu/bitcore/assignees{/user}","branches_url":"https://api.github.com/repos/matiu/bitcore/branches{/branch}","tags_url":"https://api.github.com/repos/matiu/bitcore/tags","blobs_url":"https://api.github.com/repos/matiu/bitcore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matiu/bitcore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matiu/bitcore/git/refs{/sha}","trees_url":"https://api.github.com/repos/matiu/bitcore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matiu/bitcore/statuses/{sha}","languages_url":"https://api.github.com/repos/matiu/bitcore/languages","stargazers_url":"https://api.github.com/repos/matiu/bitcore/stargazers","contributors_url":"https://api.github.com/repos/matiu/bitcore/contributors","subscribers_url":"https://api.github.com/repos/matiu/bitcore/subscribers","subscription_url":"https://api.github.com/repos/matiu/bitcore/subscription","commits_url":"https://api.github.com/repos/matiu/bitcore/commits{/sha}","git_commits_url":"https://api.github.com/repos/matiu/bitcore/git/commits{/sha}","comments_url":"https://api.github.com/repos/matiu/bitcore/comments{/number}","issue_comment_url":"https://api.github.com/repos/matiu/bitcore/issues/comments/{number}","contents_url":"https://api.github.com/repos/matiu/bitcore/contents/{+path}","compare_url":"https://api.github.com/repos/matiu/bitcore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matiu/bitcore/merges","archive_url":"https://api.github.com/repos/matiu/bitcore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matiu/bitcore/downloads","issues_url":"https://api.github.com/repos/matiu/bitcore/issues{/number}","pulls_url":"https://api.github.com/repos/matiu/bitcore/pulls{/number}","milestones_url":"https://api.github.com/repos/matiu/bitcore/milestones{/number}","notifications_url":"https://api.github.com/repos/matiu/bitcore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matiu/bitcore/labels{/name}","releases_url":"https://api.github.com/repos/matiu/bitcore/releases{/id}","created_at":"2014-01-14T18:53:20Z","updated_at":"2014-06-12T20:49:52Z","pushed_at":"2014-07-24T04:47:56Z","git_url":"git://github.com/matiu/bitcore.git","ssh_url":"git@github.com:matiu/bitcore.git","clone_url":"https://github.com/matiu/bitcore.git","svn_url":"https://github.com/matiu/bitcore","homepage":null,"size":5408,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bitpay:master","ref":"master","sha":"cd1d667fe1ecfc15524d9c4aa3f885a206c4ee50","user":{"login":"bitpay","id":2554930,"avatar_url":"https://avatars.githubusercontent.com/u/2554930?","gravatar_id":"25ea89d58931785dfe8e9e1aa5b0f117","url":"https://api.github.com/users/bitpay","html_url":"https://github.com/bitpay","followers_url":"https://api.github.com/users/bitpay/followers","following_url":"https://api.github.com/users/bitpay/following{/other_user}","gists_url":"https://api.github.com/users/bitpay/gists{/gist_id}","starred_url":"https://api.github.com/users/bitpay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitpay/subscriptions","organizations_url":"https://api.github.com/users/bitpay/orgs","repos_url":"https://api.github.com/users/bitpay/repos","events_url":"https://api.github.com/users/bitpay/events{/privacy}","received_events_url":"https://api.github.com/users/bitpay/received_events","type":"Organization","site_admin":false},"repo":{"id":15259244,"name":"bitcore","full_name":"bitpay/bitcore","owner":{"login":"bitpay","id":2554930,"avatar_url":"https://avatars.githubusercontent.com/u/2554930?","gravatar_id":"25ea89d58931785dfe8e9e1aa5b0f117","url":"https://api.github.com/users/bitpay","html_url":"https://github.com/bitpay","followers_url":"https://api.github.com/users/bitpay/followers","following_url":"https://api.github.com/users/bitpay/following{/other_user}","gists_url":"https://api.github.com/users/bitpay/gists{/gist_id}","starred_url":"https://api.github.com/users/bitpay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitpay/subscriptions","organizations_url":"https://api.github.com/users/bitpay/orgs","repos_url":"https://api.github.com/users/bitpay/repos","events_url":"https://api.github.com/users/bitpay/events{/privacy}","received_events_url":"https://api.github.com/users/bitpay/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bitpay/bitcore","description":"A bitcoin library for your javascript.","fork":true,"url":"https://api.github.com/repos/bitpay/bitcore","forks_url":"https://api.github.com/repos/bitpay/bitcore/forks","keys_url":"https://api.github.com/repos/bitpay/bitcore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitpay/bitcore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitpay/bitcore/teams","hooks_url":"https://api.github.com/repos/bitpay/bitcore/hooks","issue_events_url":"https://api.github.com/repos/bitpay/bitcore/issues/events{/number}","events_url":"https://api.github.com/repos/bitpay/bitcore/events","assignees_url":"https://api.github.com/repos/bitpay/bitcore/assignees{/user}","branches_url":"https://api.github.com/repos/bitpay/bitcore/branches{/branch}","tags_url":"https://api.github.com/repos/bitpay/bitcore/tags","blobs_url":"https://api.github.com/repos/bitpay/bitcore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitpay/bitcore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitpay/bitcore/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitpay/bitcore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitpay/bitcore/statuses/{sha}","languages_url":"https://api.github.com/repos/bitpay/bitcore/languages","stargazers_url":"https://api.github.com/repos/bitpay/bitcore/stargazers","contributors_url":"https://api.github.com/repos/bitpay/bitcore/contributors","subscribers_url":"https://api.github.com/repos/bitpay/bitcore/subscribers","subscription_url":"https://api.github.com/repos/bitpay/bitcore/subscription","commits_url":"https://api.github.com/repos/bitpay/bitcore/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitpay/bitcore/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitpay/bitcore/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitpay/bitcore/issues/comments/{number}","contents_url":"https://api.github.com/repos/bitpay/bitcore/contents/{+path}","compare_url":"https://api.github.com/repos/bitpay/bitcore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitpay/bitcore/merges","archive_url":"https://api.github.com/repos/bitpay/bitcore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitpay/bitcore/downloads","issues_url":"https://api.github.com/repos/bitpay/bitcore/issues{/number}","pulls_url":"https://api.github.com/repos/bitpay/bitcore/pulls{/number}","milestones_url":"https://api.github.com/repos/bitpay/bitcore/milestones{/number}","notifications_url":"https://api.github.com/repos/bitpay/bitcore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitpay/bitcore/labels{/name}","releases_url":"https://api.github.com/repos/bitpay/bitcore/releases{/id}","created_at":"2013-12-17T16:10:28Z","updated_at":"2014-07-23T18:50:28Z","pushed_at":"2014-07-24T00:48:33Z","git_url":"git://github.com/bitpay/bitcore.git","ssh_url":"git@github.com:bitpay/bitcore.git","clone_url":"https://github.com/bitpay/bitcore.git","svn_url":"https://github.com/bitpay/bitcore","homepage":"http://bitcore.io","size":12532,"stargazers_count":974,"watchers_count":974,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":188,"mirror_url":null,"open_issues_count":55,"forks":188,"open_issues":55,"watchers":974,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitpay/bitcore/pulls/450"},"html":{"href":"https://github.com/bitpay/bitcore/pull/450"},"issue":{"href":"https://api.github.com/repos/bitpay/bitcore/issues/450"},"comments":{"href":"https://api.github.com/repos/bitpay/bitcore/issues/450/comments"},"review_comments":{"href":"https://api.github.com/repos/bitpay/bitcore/pulls/450/comments"},"review_comment":{"href":"https://api.github.com/repos/bitpay/bitcore/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/bitpay/bitcore/pulls/450/commits"},"statuses":{"href":"https://api.github.com/repos/bitpay/bitcore/statuses/71f992138bc9f88316887150a1558c96e45006a2"}}}}