GitHub PullRequestReviewCommentEvent at 2014-12-05 00:54:45
Repository: validations
Actor: rail44
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/lotus/validations/pulls/comments/21348739","id":21348739,"diff_hunk":"@@ -228,7 +227,7 @@ def size\n       # @since x.x.x\n       # @api private\n       def coerce\n-        _validate(:type) do |coercer|\n+        @coercion ||= _validate(:type) do |coercer|","path":"lib/lotus/validations/attribute.rb","position":20,"original_position":20,"commit_id":"31d13fb851bf8201cd2423a5bcbf714d68a2382c","original_commit_id":"31d13fb851bf8201cd2423a5bcbf714d68a2382c","user":{"login":"rail44","id":2589397,"avatar_url":"https://avatars.githubusercontent.com/u/2589397?v=3","gravatar_id":"","url":"https://api.github.com/users/rail44","html_url":"https://github.com/rail44","followers_url":"https://api.github.com/users/rail44/followers","following_url":"https://api.github.com/users/rail44/following{/other_user}","gists_url":"https://api.github.com/users/rail44/gists{/gist_id}","starred_url":"https://api.github.com/users/rail44/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rail44/subscriptions","organizations_url":"https://api.github.com/users/rail44/orgs","repos_url":"https://api.github.com/users/rail44/repos","events_url":"https://api.github.com/users/rail44/events{/privacy}","received_events_url":"https://api.github.com/users/rail44/received_events","type":"User","site_admin":false},"body":"Sorry but I could not understand why it have to be thread-safe. And I wonder whether current `Attribute` is already thread-safe or not.\r\nAre there times when `#coerce` is called by multiple threads?","created_at":"2014-12-05T00:54:45Z","updated_at":"2014-12-05T00:54:45Z","html_url":"https://github.com/lotus/validations/pull/34#discussion_r21348739","pull_request_url":"https://api.github.com/repos/lotus/validations/pulls/34","_links":{"self":{"href":"https://api.github.com/repos/lotus/validations/pulls/comments/21348739"},"html":{"href":"https://github.com/lotus/validations/pull/34#discussion_r21348739"},"pull_request":{"href":"https://api.github.com/repos/lotus/validations/pulls/34"}}},"pull_request":{"url":"https://api.github.com/repos/lotus/validations/pulls/34","id":25244216,"html_url":"https://github.com/lotus/validations/pull/34","diff_url":"https://github.com/lotus/validations/pull/34.diff","patch_url":"https://github.com/lotus/validations/pull/34.patch","issue_url":"https://api.github.com/repos/lotus/validations/issues/34","number":34,"state":"open","locked":false,"title":"Fix custom coercion for support idempotent between `valid?`","user":{"login":"rail44","id":2589397,"avatar_url":"https://avatars.githubusercontent.com/u/2589397?v=3","gravatar_id":"","url":"https://api.github.com/users/rail44","html_url":"https://github.com/rail44","followers_url":"https://api.github.com/users/rail44/followers","following_url":"https://api.github.com/users/rail44/following{/other_user}","gists_url":"https://api.github.com/users/rail44/gists{/gist_id}","starred_url":"https://api.github.com/users/rail44/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rail44/subscriptions","organizations_url":"https://api.github.com/users/rail44/orgs","repos_url":"https://api.github.com/users/rail44/repos","events_url":"https://api.github.com/users/rail44/events{/privacy}","received_events_url":"https://api.github.com/users/rail44/received_events","type":"User","site_admin":false},"body":"Hi.\r\n\r\nPlease review?\r\nthank you.\r\n\r\nCloses #33 ","created_at":"2014-12-01T02:17:25Z","updated_at":"2014-12-05T00:54:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f160185dd694901bc4f7369d80af7701bd32c533","assignee":{"login":"jodosha","id":5089,"avatar_url":"https://avatars.githubusercontent.com/u/5089?v=3","gravatar_id":"","url":"https://api.github.com/users/jodosha","html_url":"https://github.com/jodosha","followers_url":"https://api.github.com/users/jodosha/followers","following_url":"https://api.github.com/users/jodosha/following{/other_user}","gists_url":"https://api.github.com/users/jodosha/gists{/gist_id}","starred_url":"https://api.github.com/users/jodosha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jodosha/subscriptions","organizations_url":"https://api.github.com/users/jodosha/orgs","repos_url":"https://api.github.com/users/jodosha/repos","events_url":"https://api.github.com/users/jodosha/events{/privacy}","received_events_url":"https://api.github.com/users/jodosha/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/lotus/validations/milestones/2","labels_url":"https://api.github.com/repos/lotus/validations/milestones/2/labels","id":884264,"number":2,"title":"v0.2.1","description":"","creator":{"login":"jodosha","id":5089,"avatar_url":"https://avatars.githubusercontent.com/u/5089?v=3","gravatar_id":"","url":"https://api.github.com/users/jodosha","html_url":"https://github.com/jodosha","followers_url":"https://api.github.com/users/jodosha/followers","following_url":"https://api.github.com/users/jodosha/following{/other_user}","gists_url":"https://api.github.com/users/jodosha/gists{/gist_id}","starred_url":"https://api.github.com/users/jodosha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jodosha/subscriptions","organizations_url":"https://api.github.com/users/jodosha/orgs","repos_url":"https://api.github.com/users/jodosha/repos","events_url":"https://api.github.com/users/jodosha/events{/privacy}","received_events_url":"https://api.github.com/users/jodosha/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":0,"state":"open","created_at":"2014-11-29T14:36:25Z","updated_at":"2014-12-04T10:15:20Z","due_on":"2014-12-22T23:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/lotus/validations/pulls/34/commits","review_comments_url":"https://api.github.com/repos/lotus/validations/pulls/34/comments","review_comment_url":"https://api.github.com/repos/lotus/validations/pulls/comments/{number}","comments_url":"https://api.github.com/repos/lotus/validations/issues/34/comments","statuses_url":"https://api.github.com/repos/lotus/validations/statuses/31d13fb851bf8201cd2423a5bcbf714d68a2382c","head":{"label":"rail44:custom-coercion-idempotent","ref":"custom-coercion-idempotent","sha":"31d13fb851bf8201cd2423a5bcbf714d68a2382c","user":{"login":"rail44","id":2589397,"avatar_url":"https://avatars.githubusercontent.com/u/2589397?v=3","gravatar_id":"","url":"https://api.github.com/users/rail44","html_url":"https://github.com/rail44","followers_url":"https://api.github.com/users/rail44/followers","following_url":"https://api.github.com/users/rail44/following{/other_user}","gists_url":"https://api.github.com/users/rail44/gists{/gist_id}","starred_url":"https://api.github.com/users/rail44/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rail44/subscriptions","organizations_url":"https://api.github.com/users/rail44/orgs","repos_url":"https://api.github.com/users/rail44/repos","events_url":"https://api.github.com/users/rail44/events{/privacy}","received_events_url":"https://api.github.com/users/rail44/received_events","type":"User","site_admin":false},"repo":{"id":23785156,"name":"validations","full_name":"rail44/validations","owner":{"login":"rail44","id":2589397,"avatar_url":"https://avatars.githubusercontent.com/u/2589397?v=3","gravatar_id":"","url":"https://api.github.com/users/rail44","html_url":"https://github.com/rail44","followers_url":"https://api.github.com/users/rail44/followers","following_url":"https://api.github.com/users/rail44/following{/other_user}","gists_url":"https://api.github.com/users/rail44/gists{/gist_id}","starred_url":"https://api.github.com/users/rail44/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rail44/subscriptions","organizations_url":"https://api.github.com/users/rail44/orgs","repos_url":"https://api.github.com/users/rail44/repos","events_url":"https://api.github.com/users/rail44/events{/privacy}","received_events_url":"https://api.github.com/users/rail44/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rail44/validations","description":"Validation mixin for Ruby objects","fork":true,"url":"https://api.github.com/repos/rail44/validations","forks_url":"https://api.github.com/repos/rail44/validations/forks","keys_url":"https://api.github.com/repos/rail44/validations/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rail44/validations/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rail44/validations/teams","hooks_url":"https://api.github.com/repos/rail44/validations/hooks","issue_events_url":"https://api.github.com/repos/rail44/validations/issues/events{/number}","events_url":"https://api.github.com/repos/rail44/validations/events","assignees_url":"https://api.github.com/repos/rail44/validations/assignees{/user}","branches_url":"https://api.github.com/repos/rail44/validations/branches{/branch}","tags_url":"https://api.github.com/repos/rail44/validations/tags","blobs_url":"https://api.github.com/repos/rail44/validations/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rail44/validations/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rail44/validations/git/refs{/sha}","trees_url":"https://api.github.com/repos/rail44/validations/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rail44/validations/statuses/{sha}","languages_url":"https://api.github.com/repos/rail44/validations/languages","stargazers_url":"https://api.github.com/repos/rail44/validations/stargazers","contributors_url":"https://api.github.com/repos/rail44/validations/contributors","subscribers_url":"https://api.github.com/repos/rail44/validations/subscribers","subscription_url":"https://api.github.com/repos/rail44/validations/subscription","commits_url":"https://api.github.com/repos/rail44/validations/commits{/sha}","git_commits_url":"https://api.github.com/repos/rail44/validations/git/commits{/sha}","comments_url":"https://api.github.com/repos/rail44/validations/comments{/number}","issue_comment_url":"https://api.github.com/repos/rail44/validations/issues/comments/{number}","contents_url":"https://api.github.com/repos/rail44/validations/contents/{+path}","compare_url":"https://api.github.com/repos/rail44/validations/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rail44/validations/merges","archive_url":"https://api.github.com/repos/rail44/validations/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rail44/validations/downloads","issues_url":"https://api.github.com/repos/rail44/validations/issues{/number}","pulls_url":"https://api.github.com/repos/rail44/validations/pulls{/number}","milestones_url":"https://api.github.com/repos/rail44/validations/milestones{/number}","notifications_url":"https://api.github.com/repos/rail44/validations/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rail44/validations/labels{/name}","releases_url":"https://api.github.com/repos/rail44/validations/releases{/id}","created_at":"2014-09-08T09:22:56Z","updated_at":"2014-09-08T11:09:11Z","pushed_at":"2014-12-01T02:47:40Z","git_url":"git://github.com/rail44/validations.git","ssh_url":"git@github.com:rail44/validations.git","clone_url":"https://github.com/rail44/validations.git","svn_url":"https://github.com/rail44/validations","homepage":"http://lotusrb.org","size":319,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"lotus:master","ref":"master","sha":"6854a4446c85f221bf228483d2bbe3ca447572c7","user":{"login":"lotus","id":3210273,"avatar_url":"https://avatars.githubusercontent.com/u/3210273?v=3","gravatar_id":"","url":"https://api.github.com/users/lotus","html_url":"https://github.com/lotus","followers_url":"https://api.github.com/users/lotus/followers","following_url":"https://api.github.com/users/lotus/following{/other_user}","gists_url":"https://api.github.com/users/lotus/gists{/gist_id}","starred_url":"https://api.github.com/users/lotus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lotus/subscriptions","organizations_url":"https://api.github.com/users/lotus/orgs","repos_url":"https://api.github.com/users/lotus/repos","events_url":"https://api.github.com/users/lotus/events{/privacy}","received_events_url":"https://api.github.com/users/lotus/received_events","type":"Organization","site_admin":false},"repo":{"id":22643222,"name":"validations","full_name":"lotus/validations","owner":{"login":"lotus","id":3210273,"avatar_url":"https://avatars.githubusercontent.com/u/3210273?v=3","gravatar_id":"","url":"https://api.github.com/users/lotus","html_url":"https://github.com/lotus","followers_url":"https://api.github.com/users/lotus/followers","following_url":"https://api.github.com/users/lotus/following{/other_user}","gists_url":"https://api.github.com/users/lotus/gists{/gist_id}","starred_url":"https://api.github.com/users/lotus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lotus/subscriptions","organizations_url":"https://api.github.com/users/lotus/orgs","repos_url":"https://api.github.com/users/lotus/repos","events_url":"https://api.github.com/users/lotus/events{/privacy}","received_events_url":"https://api.github.com/users/lotus/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lotus/validations","description":"Validation mixin for Ruby objects","fork":false,"url":"https://api.github.com/repos/lotus/validations","forks_url":"https://api.github.com/repos/lotus/validations/forks","keys_url":"https://api.github.com/repos/lotus/validations/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lotus/validations/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lotus/validations/teams","hooks_url":"https://api.github.com/repos/lotus/validations/hooks","issue_events_url":"https://api.github.com/repos/lotus/validations/issues/events{/number}","events_url":"https://api.github.com/repos/lotus/validations/events","assignees_url":"https://api.github.com/repos/lotus/validations/assignees{/user}","branches_url":"https://api.github.com/repos/lotus/validations/branches{/branch}","tags_url":"https://api.github.com/repos/lotus/validations/tags","blobs_url":"https://api.github.com/repos/lotus/validations/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lotus/validations/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lotus/validations/git/refs{/sha}","trees_url":"https://api.github.com/repos/lotus/validations/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lotus/validations/statuses/{sha}","languages_url":"https://api.github.com/repos/lotus/validations/languages","stargazers_url":"https://api.github.com/repos/lotus/validations/stargazers","contributors_url":"https://api.github.com/repos/lotus/validations/contributors","subscribers_url":"https://api.github.com/repos/lotus/validations/subscribers","subscription_url":"https://api.github.com/repos/lotus/validations/subscription","commits_url":"https://api.github.com/repos/lotus/validations/commits{/sha}","git_commits_url":"https://api.github.com/repos/lotus/validations/git/commits{/sha}","comments_url":"https://api.github.com/repos/lotus/validations/comments{/number}","issue_comment_url":"https://api.github.com/repos/lotus/validations/issues/comments/{number}","contents_url":"https://api.github.com/repos/lotus/validations/contents/{+path}","compare_url":"https://api.github.com/repos/lotus/validations/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lotus/validations/merges","archive_url":"https://api.github.com/repos/lotus/validations/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lotus/validations/downloads","issues_url":"https://api.github.com/repos/lotus/validations/issues{/number}","pulls_url":"https://api.github.com/repos/lotus/validations/pulls{/number}","milestones_url":"https://api.github.com/repos/lotus/validations/milestones{/number}","notifications_url":"https://api.github.com/repos/lotus/validations/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lotus/validations/labels{/name}","releases_url":"https://api.github.com/repos/lotus/validations/releases{/id}","created_at":"2014-08-05T12:49:35Z","updated_at":"2014-12-03T08:24:32Z","pushed_at":"2014-12-03T10:10:54Z","git_url":"git://github.com/lotus/validations.git","ssh_url":"git@github.com:lotus/validations.git","clone_url":"https://github.com/lotus/validations.git","svn_url":"https://github.com/lotus/validations","homepage":"http://lotusrb.org","size":883,"stargazers_count":27,"watchers_count":27,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":4,"forks":15,"open_issues":4,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lotus/validations/pulls/34"},"html":{"href":"https://github.com/lotus/validations/pull/34"},"issue":{"href":"https://api.github.com/repos/lotus/validations/issues/34"},"comments":{"href":"https://api.github.com/repos/lotus/validations/issues/34/comments"},"review_comments":{"href":"https://api.github.com/repos/lotus/validations/pulls/34/comments"},"review_comment":{"href":"https://api.github.com/repos/lotus/validations/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/lotus/validations/pulls/34/commits"},"statuses":{"href":"https://api.github.com/repos/lotus/validations/statuses/31d13fb851bf8201cd2423a5bcbf714d68a2382c"}}}}