GitHub PullRequestEvent at 2014-08-18 18:34:49
Repository: qt-mustache
Actor: estan
Payload: {"action":"opened","number":10,"pull_request":{"url":"https://api.github.com/repos/robertknight/qt-mustache/pulls/10","id":19935843,"html_url":"https://github.com/robertknight/qt-mustache/pull/10","diff_url":"https://github.com/robertknight/qt-mustache/pull/10.diff","patch_url":"https://github.com/robertknight/qt-mustache/pull/10.patch","issue_url":"https://api.github.com/repos/robertknight/qt-mustache/issues/10","number":10,"state":"open","locked":false,"title":"Fix falseyness of hashes/maps.","user":{"login":"estan","id":86675,"avatar_url":"https://avatars.githubusercontent.com/u/86675?v=2","gravatar_id":"e67b4768ea754a5fcc0d4ba80cfecb3f","url":"https://api.github.com/users/estan","html_url":"https://github.com/estan","followers_url":"https://api.github.com/users/estan/followers","following_url":"https://api.github.com/users/estan/following{/other_user}","gists_url":"https://api.github.com/users/estan/gists{/gist_id}","starred_url":"https://api.github.com/users/estan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/estan/subscriptions","organizations_url":"https://api.github.com/users/estan/orgs","repos_url":"https://api.github.com/users/estan/repos","events_url":"https://api.github.com/users/estan/events{/privacy}","received_events_url":"https://api.github.com/users/estan/received_events","type":"User","site_admin":false},"body":"Hashes and maps are falsey only if they are empty. The current test deemed `QVariantHashes/-Maps` as false if `.toString().isEmpty()`, which is always true on maps/hashes. This patch makes the test use the `QHash::isEmpty()` and `QMap::isEmpty()` instead.\r\n\r\nThis fixes the \"Context\" tests in `sections.json` and `inverted.json` (and also by \"accident\" the \"Inverted Section\" test in `~lambdas.json`. (I'll fix so that the test doesn't even load cases from `~lambdas.json` in a separate commit.)","created_at":"2014-08-18T18:34:49Z","updated_at":"2014-08-18T18:34:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/robertknight/qt-mustache/pulls/10/commits","review_comments_url":"https://api.github.com/repos/robertknight/qt-mustache/pulls/10/comments","review_comment_url":"https://api.github.com/repos/robertknight/qt-mustache/pulls/comments/{number}","comments_url":"https://api.github.com/repos/robertknight/qt-mustache/issues/10/comments","statuses_url":"https://api.github.com/repos/robertknight/qt-mustache/statuses/04a13bc486096676528cd2c8f57230c659c8254c","head":{"label":"estan:fix-hash-map-falsyness","ref":"fix-hash-map-falsyness","sha":"04a13bc486096676528cd2c8f57230c659c8254c","user":{"login":"estan","id":86675,"avatar_url":"https://avatars.githubusercontent.com/u/86675?v=2","gravatar_id":"e67b4768ea754a5fcc0d4ba80cfecb3f","url":"https://api.github.com/users/estan","html_url":"https://github.com/estan","followers_url":"https://api.github.com/users/estan/followers","following_url":"https://api.github.com/users/estan/following{/other_user}","gists_url":"https://api.github.com/users/estan/gists{/gist_id}","starred_url":"https://api.github.com/users/estan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/estan/subscriptions","organizations_url":"https://api.github.com/users/estan/orgs","repos_url":"https://api.github.com/users/estan/repos","events_url":"https://api.github.com/users/estan/events{/privacy}","received_events_url":"https://api.github.com/users/estan/received_events","type":"User","site_admin":false},"repo":{"id":22581778,"name":"qt-mustache","full_name":"estan/qt-mustache","owner":{"login":"estan","id":86675,"avatar_url":"https://avatars.githubusercontent.com/u/86675?v=2","gravatar_id":"e67b4768ea754a5fcc0d4ba80cfecb3f","url":"https://api.github.com/users/estan","html_url":"https://github.com/estan","followers_url":"https://api.github.com/users/estan/followers","following_url":"https://api.github.com/users/estan/following{/other_user}","gists_url":"https://api.github.com/users/estan/gists{/gist_id}","starred_url":"https://api.github.com/users/estan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/estan/subscriptions","organizations_url":"https://api.github.com/users/estan/orgs","repos_url":"https://api.github.com/users/estan/repos","events_url":"https://api.github.com/users/estan/events{/privacy}","received_events_url":"https://api.github.com/users/estan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/estan/qt-mustache","description":"Mustache templating library for C++ using Qt","fork":true,"url":"https://api.github.com/repos/estan/qt-mustache","forks_url":"https://api.github.com/repos/estan/qt-mustache/forks","keys_url":"https://api.github.com/repos/estan/qt-mustache/keys{/key_id}","collaborators_url":"https://api.github.com/repos/estan/qt-mustache/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/estan/qt-mustache/teams","hooks_url":"https://api.github.com/repos/estan/qt-mustache/hooks","issue_events_url":"https://api.github.com/repos/estan/qt-mustache/issues/events{/number}","events_url":"https://api.github.com/repos/estan/qt-mustache/events","assignees_url":"https://api.github.com/repos/estan/qt-mustache/assignees{/user}","branches_url":"https://api.github.com/repos/estan/qt-mustache/branches{/branch}","tags_url":"https://api.github.com/repos/estan/qt-mustache/tags","blobs_url":"https://api.github.com/repos/estan/qt-mustache/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/estan/qt-mustache/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/estan/qt-mustache/git/refs{/sha}","trees_url":"https://api.github.com/repos/estan/qt-mustache/git/trees{/sha}","statuses_url":"https://api.github.com/repos/estan/qt-mustache/statuses/{sha}","languages_url":"https://api.github.com/repos/estan/qt-mustache/languages","stargazers_url":"https://api.github.com/repos/estan/qt-mustache/stargazers","contributors_url":"https://api.github.com/repos/estan/qt-mustache/contributors","subscribers_url":"https://api.github.com/repos/estan/qt-mustache/subscribers","subscription_url":"https://api.github.com/repos/estan/qt-mustache/subscription","commits_url":"https://api.github.com/repos/estan/qt-mustache/commits{/sha}","git_commits_url":"https://api.github.com/repos/estan/qt-mustache/git/commits{/sha}","comments_url":"https://api.github.com/repos/estan/qt-mustache/comments{/number}","issue_comment_url":"https://api.github.com/repos/estan/qt-mustache/issues/comments/{number}","contents_url":"https://api.github.com/repos/estan/qt-mustache/contents/{+path}","compare_url":"https://api.github.com/repos/estan/qt-mustache/compare/{base}...{head}","merges_url":"https://api.github.com/repos/estan/qt-mustache/merges","archive_url":"https://api.github.com/repos/estan/qt-mustache/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/estan/qt-mustache/downloads","issues_url":"https://api.github.com/repos/estan/qt-mustache/issues{/number}","pulls_url":"https://api.github.com/repos/estan/qt-mustache/pulls{/number}","milestones_url":"https://api.github.com/repos/estan/qt-mustache/milestones{/number}","notifications_url":"https://api.github.com/repos/estan/qt-mustache/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/estan/qt-mustache/labels{/name}","releases_url":"https://api.github.com/repos/estan/qt-mustache/releases{/id}","created_at":"2014-08-03T19:17:26Z","updated_at":"2014-08-11T17:40:15Z","pushed_at":"2014-08-18T18:32:52Z","git_url":"git://github.com/estan/qt-mustache.git","ssh_url":"git@github.com:estan/qt-mustache.git","clone_url":"https://github.com/estan/qt-mustache.git","svn_url":"https://github.com/estan/qt-mustache","homepage":null,"size":300,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"robertknight:master","ref":"master","sha":"8ee9aa2d8a670a49a23a6adbe165c791d3fdef56","user":{"login":"robertknight","id":2458,"avatar_url":"https://avatars.githubusercontent.com/u/2458?v=2","gravatar_id":"217c7106a3d4eba3584cd38abf8ee107","url":"https://api.github.com/users/robertknight","html_url":"https://github.com/robertknight","followers_url":"https://api.github.com/users/robertknight/followers","following_url":"https://api.github.com/users/robertknight/following{/other_user}","gists_url":"https://api.github.com/users/robertknight/gists{/gist_id}","starred_url":"https://api.github.com/users/robertknight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertknight/subscriptions","organizations_url":"https://api.github.com/users/robertknight/orgs","repos_url":"https://api.github.com/users/robertknight/repos","events_url":"https://api.github.com/users/robertknight/events{/privacy}","received_events_url":"https://api.github.com/users/robertknight/received_events","type":"User","site_admin":false},"repo":{"id":5569988,"name":"qt-mustache","full_name":"robertknight/qt-mustache","owner":{"login":"robertknight","id":2458,"avatar_url":"https://avatars.githubusercontent.com/u/2458?v=2","gravatar_id":"217c7106a3d4eba3584cd38abf8ee107","url":"https://api.github.com/users/robertknight","html_url":"https://github.com/robertknight","followers_url":"https://api.github.com/users/robertknight/followers","following_url":"https://api.github.com/users/robertknight/following{/other_user}","gists_url":"https://api.github.com/users/robertknight/gists{/gist_id}","starred_url":"https://api.github.com/users/robertknight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertknight/subscriptions","organizations_url":"https://api.github.com/users/robertknight/orgs","repos_url":"https://api.github.com/users/robertknight/repos","events_url":"https://api.github.com/users/robertknight/events{/privacy}","received_events_url":"https://api.github.com/users/robertknight/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/robertknight/qt-mustache","description":"Mustache templating library for C++ using Qt","fork":false,"url":"https://api.github.com/repos/robertknight/qt-mustache","forks_url":"https://api.github.com/repos/robertknight/qt-mustache/forks","keys_url":"https://api.github.com/repos/robertknight/qt-mustache/keys{/key_id}","collaborators_url":"https://api.github.com/repos/robertknight/qt-mustache/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/robertknight/qt-mustache/teams","hooks_url":"https://api.github.com/repos/robertknight/qt-mustache/hooks","issue_events_url":"https://api.github.com/repos/robertknight/qt-mustache/issues/events{/number}","events_url":"https://api.github.com/repos/robertknight/qt-mustache/events","assignees_url":"https://api.github.com/repos/robertknight/qt-mustache/assignees{/user}","branches_url":"https://api.github.com/repos/robertknight/qt-mustache/branches{/branch}","tags_url":"https://api.github.com/repos/robertknight/qt-mustache/tags","blobs_url":"https://api.github.com/repos/robertknight/qt-mustache/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/robertknight/qt-mustache/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/robertknight/qt-mustache/git/refs{/sha}","trees_url":"https://api.github.com/repos/robertknight/qt-mustache/git/trees{/sha}","statuses_url":"https://api.github.com/repos/robertknight/qt-mustache/statuses/{sha}","languages_url":"https://api.github.com/repos/robertknight/qt-mustache/languages","stargazers_url":"https://api.github.com/repos/robertknight/qt-mustache/stargazers","contributors_url":"https://api.github.com/repos/robertknight/qt-mustache/contributors","subscribers_url":"https://api.github.com/repos/robertknight/qt-mustache/subscribers","subscription_url":"https://api.github.com/repos/robertknight/qt-mustache/subscription","commits_url":"https://api.github.com/repos/robertknight/qt-mustache/commits{/sha}","git_commits_url":"https://api.github.com/repos/robertknight/qt-mustache/git/commits{/sha}","comments_url":"https://api.github.com/repos/robertknight/qt-mustache/comments{/number}","issue_comment_url":"https://api.github.com/repos/robertknight/qt-mustache/issues/comments/{number}","contents_url":"https://api.github.com/repos/robertknight/qt-mustache/contents/{+path}","compare_url":"https://api.github.com/repos/robertknight/qt-mustache/compare/{base}...{head}","merges_url":"https://api.github.com/repos/robertknight/qt-mustache/merges","archive_url":"https://api.github.com/repos/robertknight/qt-mustache/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/robertknight/qt-mustache/downloads","issues_url":"https://api.github.com/repos/robertknight/qt-mustache/issues{/number}","pulls_url":"https://api.github.com/repos/robertknight/qt-mustache/pulls{/number}","milestones_url":"https://api.github.com/repos/robertknight/qt-mustache/milestones{/number}","notifications_url":"https://api.github.com/repos/robertknight/qt-mustache/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/robertknight/qt-mustache/labels{/name}","releases_url":"https://api.github.com/repos/robertknight/qt-mustache/releases{/id}","created_at":"2012-08-27T11:16:35Z","updated_at":"2014-08-14T08:40:22Z","pushed_at":"2014-08-18T09:51:48Z","git_url":"git://github.com/robertknight/qt-mustache.git","ssh_url":"git@github.com:robertknight/qt-mustache.git","clone_url":"https://github.com/robertknight/qt-mustache.git","svn_url":"https://github.com/robertknight/qt-mustache","homepage":null,"size":288,"stargazers_count":15,"watchers_count":15,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":8,"mirror_url":null,"open_issues_count":5,"forks":8,"open_issues":5,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/robertknight/qt-mustache/pulls/10"},"html":{"href":"https://github.com/robertknight/qt-mustache/pull/10"},"issue":{"href":"https://api.github.com/repos/robertknight/qt-mustache/issues/10"},"comments":{"href":"https://api.github.com/repos/robertknight/qt-mustache/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/robertknight/qt-mustache/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/robertknight/qt-mustache/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/robertknight/qt-mustache/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/robertknight/qt-mustache/statuses/04a13bc486096676528cd2c8f57230c659c8254c"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":4,"deletions":3,"changed_files":2}}