GitHub PullRequestReviewCommentEvent at 2014-11-21 12:48:27
Repository: cmssw
Actor: namapane
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/20712647","id":20712647,"diff_hunk":"@@ -95,17 +95,16 @@ std::auto_ptr<MagneticField> VolumeBasedMagneticFieldESProducerFromDB::produce(c\n     message = \" (from valueOverride card)\";\n   }\n   string configLabel  = closerNominalLabel(current);\n-  edm::LogInfo(\"MagneticField|AutoMagneticField\") << \"Current: \" << current << message << \"; using map configuration with label: \" << configLabel;\n \n   // Get configuration\n   ESHandle<MagFieldConfig> confESH;\n   iRecord.getRecord<MagFieldConfigRcd>().get(configLabel, confESH);\n   const MagFieldConfig* conf = &*confESH;\n \n-  if (debug) {\n-    cout << \"VolumeBasedMagneticFieldESProducerFromDB::produce() \" << conf->version << endl;\n-  }\n-\n+  edm::LogInfo(\"MagneticField|AutoMagneticField\") << \"Current: \" << current << message << \"; using map configuration with label: \" << configLabel << endl\n+\t\t\t\t\t\t  << \"Version: \" << conf->version \n+\t\t\t\t\t\t  << \" geometryVersion: \" << conf->geometryVersion\n+\t\t\t\t\t\t  << \" slaveFieldVersion: \" << conf->slaveFieldVersion;","path":"MagneticField/GeomBuilder/plugins/VolumeBasedMagneticFieldESProducerFromDB.cc","position":18,"original_position":18,"commit_id":"8efe88d01efaf9ec7c32207ed97318c55226c2af","original_commit_id":"8efe88d01efaf9ec7c32207ed97318c55226c2af","user":{"login":"namapane","id":5168720,"avatar_url":"https://avatars.githubusercontent.com/u/5168720?v=3","gravatar_id":"","url":"https://api.github.com/users/namapane","html_url":"https://github.com/namapane","followers_url":"https://api.github.com/users/namapane/followers","following_url":"https://api.github.com/users/namapane/following{/other_user}","gists_url":"https://api.github.com/users/namapane/gists{/gist_id}","starred_url":"https://api.github.com/users/namapane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/namapane/subscriptions","organizations_url":"https://api.github.com/users/namapane/orgs","repos_url":"https://api.github.com/users/namapane/repos","events_url":"https://api.github.com/users/namapane/events{/privacy}","received_events_url":"https://api.github.com/users/namapane/received_events","type":"User","site_admin":false},"body":"This is not a part of the debug code mentioned above, so MessageLogger is appropriate in this specific case. Info is more appropriate IMO.","created_at":"2014-11-21T12:48:27Z","updated_at":"2014-11-21T12:48:27Z","html_url":"https://github.com/cms-sw/cmssw/pull/6514#discussion_r20712647","pull_request_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/6514","_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/20712647"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/6514#discussion_r20712647"},"pull_request":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/6514"}}},"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/6514","id":24786457,"html_url":"https://github.com/cms-sw/cmssw/pull/6514","diff_url":"https://github.com/cms-sw/cmssw/pull/6514.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/6514.patch","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/6514","number":6514,"state":"open","locked":false,"title":"Prepare for taking MF configurations from DB","user":{"login":"namapane","id":5168720,"avatar_url":"https://avatars.githubusercontent.com/u/5168720?v=3","gravatar_id":"","url":"https://api.github.com/users/namapane","html_url":"https://github.com/namapane","followers_url":"https://api.github.com/users/namapane/followers","following_url":"https://api.github.com/users/namapane/following{/other_user}","gists_url":"https://api.github.com/users/namapane/gists{/gist_id}","starred_url":"https://api.github.com/users/namapane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/namapane/subscriptions","organizations_url":"https://api.github.com/users/namapane/orgs","repos_url":"https://api.github.com/users/namapane/repos","events_url":"https://api.github.com/users/namapane/events{/privacy}","received_events_url":"https://api.github.com/users/namapane/received_events","type":"User","site_admin":false},"body":"Includes:\r\n-Tools to create .db files for standard configurations \r\n-Fix for one numerical stability problem with geometries imported to DB. The problem did not affect existing configurations (with geometry coming from xml), and the fix was regression-tested.\r\n\r\nThis fix is needed to be able to finally switch to reading MF geometry and configuration from DB, which will happen in a future (pre)release once a GT with all required payloads becomes available.\r\n","created_at":"2014-11-20T18:24:34Z","updated_at":"2014-11-21T12:48:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"59990d607bdb226bb05255da85f172d1aa4fa190","assignee":null,"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/49","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/49/labels","id":791225,"number":49,"title":"Next CMSSW_7_3_X","description":"","creator":{"login":"ktf","id":10544,"avatar_url":"https://avatars.githubusercontent.com/u/10544?v=3","gravatar_id":"","url":"https://api.github.com/users/ktf","html_url":"https://github.com/ktf","followers_url":"https://api.github.com/users/ktf/followers","following_url":"https://api.github.com/users/ktf/following{/other_user}","gists_url":"https://api.github.com/users/ktf/gists{/gist_id}","starred_url":"https://api.github.com/users/ktf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ktf/subscriptions","organizations_url":"https://api.github.com/users/ktf/orgs","repos_url":"https://api.github.com/users/ktf/repos","events_url":"https://api.github.com/users/ktf/events{/privacy}","received_events_url":"https://api.github.com/users/ktf/received_events","type":"User","site_admin":false},"open_issues":34,"closed_issues":638,"state":"open","created_at":"2014-09-16T07:39:32Z","updated_at":"2014-11-21T12:36:12Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/6514/commits","review_comments_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/6514/comments","review_comment_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/{number}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/6514/comments","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/8efe88d01efaf9ec7c32207ed97318c55226c2af","head":{"label":"namapane:MFConfigFromDB","ref":"MFConfigFromDB","sha":"8efe88d01efaf9ec7c32207ed97318c55226c2af","user":{"login":"namapane","id":5168720,"avatar_url":"https://avatars.githubusercontent.com/u/5168720?v=3","gravatar_id":"","url":"https://api.github.com/users/namapane","html_url":"https://github.com/namapane","followers_url":"https://api.github.com/users/namapane/followers","following_url":"https://api.github.com/users/namapane/following{/other_user}","gists_url":"https://api.github.com/users/namapane/gists{/gist_id}","starred_url":"https://api.github.com/users/namapane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/namapane/subscriptions","organizations_url":"https://api.github.com/users/namapane/orgs","repos_url":"https://api.github.com/users/namapane/repos","events_url":"https://api.github.com/users/namapane/events{/privacy}","received_events_url":"https://api.github.com/users/namapane/received_events","type":"User","site_admin":false},"repo":{"id":11929673,"name":"cmssw","full_name":"namapane/cmssw","owner":{"login":"namapane","id":5168720,"avatar_url":"https://avatars.githubusercontent.com/u/5168720?v=3","gravatar_id":"","url":"https://api.github.com/users/namapane","html_url":"https://github.com/namapane","followers_url":"https://api.github.com/users/namapane/followers","following_url":"https://api.github.com/users/namapane/following{/other_user}","gists_url":"https://api.github.com/users/namapane/gists{/gist_id}","starred_url":"https://api.github.com/users/namapane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/namapane/subscriptions","organizations_url":"https://api.github.com/users/namapane/orgs","repos_url":"https://api.github.com/users/namapane/repos","events_url":"https://api.github.com/users/namapane/events{/privacy}","received_events_url":"https://api.github.com/users/namapane/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/namapane/cmssw","description":"CMS Offline Software","fork":true,"url":"https://api.github.com/repos/namapane/cmssw","forks_url":"https://api.github.com/repos/namapane/cmssw/forks","keys_url":"https://api.github.com/repos/namapane/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/namapane/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/namapane/cmssw/teams","hooks_url":"https://api.github.com/repos/namapane/cmssw/hooks","issue_events_url":"https://api.github.com/repos/namapane/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/namapane/cmssw/events","assignees_url":"https://api.github.com/repos/namapane/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/namapane/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/namapane/cmssw/tags","blobs_url":"https://api.github.com/repos/namapane/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/namapane/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/namapane/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/namapane/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/namapane/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/namapane/cmssw/languages","stargazers_url":"https://api.github.com/repos/namapane/cmssw/stargazers","contributors_url":"https://api.github.com/repos/namapane/cmssw/contributors","subscribers_url":"https://api.github.com/repos/namapane/cmssw/subscribers","subscription_url":"https://api.github.com/repos/namapane/cmssw/subscription","commits_url":"https://api.github.com/repos/namapane/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/namapane/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/namapane/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/namapane/cmssw/issues/comments/{number}","contents_url":"https://api.github.com/repos/namapane/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/namapane/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/namapane/cmssw/merges","archive_url":"https://api.github.com/repos/namapane/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/namapane/cmssw/downloads","issues_url":"https://api.github.com/repos/namapane/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/namapane/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/namapane/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/namapane/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/namapane/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/namapane/cmssw/releases{/id}","created_at":"2013-08-06T17:06:37Z","updated_at":"2014-03-29T19:35:38Z","pushed_at":"2014-11-20T18:15:28Z","git_url":"git://github.com/namapane/cmssw.git","ssh_url":"git@github.com:namapane/cmssw.git","clone_url":"https://github.com/namapane/cmssw.git","svn_url":"https://github.com/namapane/cmssw","homepage":"cms-sw.github.io/cmssw","size":517715,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"CMSSW_7_0_X"}},"base":{"label":"cms-sw:CMSSW_7_3_X","ref":"CMSSW_7_3_X","sha":"3d54cb2966f2f02506da01db01730a843f2acb96","user":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars.githubusercontent.com/u/3863500?v=3","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"repo":{"id":10969551,"name":"cmssw","full_name":"cms-sw/cmssw","owner":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars.githubusercontent.com/u/3863500?v=3","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cms-sw/cmssw","description":"CMS Offline Software","fork":false,"url":"https://api.github.com/repos/cms-sw/cmssw","forks_url":"https://api.github.com/repos/cms-sw/cmssw/forks","keys_url":"https://api.github.com/repos/cms-sw/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cms-sw/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cms-sw/cmssw/teams","hooks_url":"https://api.github.com/repos/cms-sw/cmssw/hooks","issue_events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/cms-sw/cmssw/events","assignees_url":"https://api.github.com/repos/cms-sw/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/cms-sw/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/cms-sw/cmssw/tags","blobs_url":"https://api.github.com/repos/cms-sw/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cms-sw/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cms-sw/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/cms-sw/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/cms-sw/cmssw/languages","stargazers_url":"https://api.github.com/repos/cms-sw/cmssw/stargazers","contributors_url":"https://api.github.com/repos/cms-sw/cmssw/contributors","subscribers_url":"https://api.github.com/repos/cms-sw/cmssw/subscribers","subscription_url":"https://api.github.com/repos/cms-sw/cmssw/subscription","commits_url":"https://api.github.com/repos/cms-sw/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/cms-sw/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/{number}","contents_url":"https://api.github.com/repos/cms-sw/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/cms-sw/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cms-sw/cmssw/merges","archive_url":"https://api.github.com/repos/cms-sw/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cms-sw/cmssw/downloads","issues_url":"https://api.github.com/repos/cms-sw/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/cms-sw/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/cms-sw/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/cms-sw/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cms-sw/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/cms-sw/cmssw/releases{/id}","created_at":"2013-06-26T14:09:07Z","updated_at":"2014-11-21T11:33:37Z","pushed_at":"2014-11-21T12:08:16Z","git_url":"git://github.com/cms-sw/cmssw.git","ssh_url":"git@github.com:cms-sw/cmssw.git","clone_url":"https://github.com/cms-sw/cmssw.git","svn_url":"https://github.com/cms-sw/cmssw","homepage":"cms-sw.github.io/cmssw","size":810642,"stargazers_count":192,"watchers_count":192,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1132,"mirror_url":null,"open_issues_count":108,"forks":1132,"open_issues":108,"watchers":192,"default_branch":"CMSSW_7_3_X"}},"_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/6514"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/6514"},"issue":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/6514"},"comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/6514/comments"},"review_comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/6514/comments"},"review_comment":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/6514/commits"},"statuses":{"href":"https://api.github.com/repos/cms-sw/cmssw/statuses/8efe88d01efaf9ec7c32207ed97318c55226c2af"}}}}