GitHub PullRequestReviewCommentEvent at 2014-11-07 23:31:26
Repository: PaypalWebCheckoutBundle
Actor: mickaelandrieu
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/PaymentSuite/PaypalWebCheckoutBundle/pulls/comments/20044964","id":20044964,"diff_hunk":"@@ -172,34 +237,67 @@ public function processResult($orderId, array $parameters)\n      *\n      * @param array $parameters Parameters\n      *\n-     * @throws \\PaymentSuite\\PaypalWebCheckoutBundle\\Exception\\ParameterNotReceivedException\n+     * @throws ParameterNotReceivedException","path":"Services/PaypalWebCheckoutManager.php","position":204,"original_position":204,"commit_id":"397f1fc0ea0fd0f89cf4a29505a4759ab7deaa43","original_commit_id":"397f1fc0ea0fd0f89cf4a29505a4759ab7deaa43","user":{"login":"mickaelandrieu","id":1247388,"avatar_url":"https://avatars.githubusercontent.com/u/1247388?v=3","gravatar_id":"","url":"https://api.github.com/users/mickaelandrieu","html_url":"https://github.com/mickaelandrieu","followers_url":"https://api.github.com/users/mickaelandrieu/followers","following_url":"https://api.github.com/users/mickaelandrieu/following{/other_user}","gists_url":"https://api.github.com/users/mickaelandrieu/gists{/gist_id}","starred_url":"https://api.github.com/users/mickaelandrieu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mickaelandrieu/subscriptions","organizations_url":"https://api.github.com/users/mickaelandrieu/orgs","repos_url":"https://api.github.com/users/mickaelandrieu/repos","events_url":"https://api.github.com/users/mickaelandrieu/events{/privacy}","received_events_url":"https://api.github.com/users/mickaelandrieu/received_events","type":"User","site_admin":false},"body":"is your IDE find the correct Exception class ? ","created_at":"2014-11-07T23:31:26Z","updated_at":"2014-11-07T23:31:26Z","html_url":"https://github.com/PaymentSuite/PaypalWebCheckoutBundle/pull/11#discussion_r20044964","pull_request_url":"https://api.github.com/repos/PaymentSuite/PaypalWebCheckoutBundle/pulls/11","_links":{"self":{"href":"https://api.github.com/repos/PaymentSuite/PaypalWebCheckoutBundle/pulls/comments/20044964"},"html":{"href":"https://github.com/PaymentSuite/PaypalWebCheckoutBundle/pull/11#discussion_r20044964"},"pull_request":{"href":"https://api.github.com/repos/PaymentSuite/PaypalWebCheckoutBundle/pulls/11"}}},"pull_request":{"url":"https://api.github.com/repos/PaymentSuite/PaypalWebCheckoutBundle/pulls/11","id":23977693,"html_url":"https://github.com/PaymentSuite/PaypalWebCheckoutBundle/pull/11","diff_url":"https://github.com/PaymentSuite/PaypalWebCheckoutBundle/pull/11.diff","patch_url":"https://github.com/PaymentSuite/PaypalWebCheckoutBundle/pull/11.patch","issue_url":"https://api.github.com/repos/PaymentSuite/PaypalWebCheckoutBundle/issues/11","number":11,"state":"open","locked":false,"title":"General Refactoring","user":{"login":"alch","id":682515,"avatar_url":"https://avatars.githubusercontent.com/u/682515?v=3","gravatar_id":"","url":"https://api.github.com/users/alch","html_url":"https://github.com/alch","followers_url":"https://api.github.com/users/alch/followers","following_url":"https://api.github.com/users/alch/following{/other_user}","gists_url":"https://api.github.com/users/alch/gists{/gist_id}","starred_url":"https://api.github.com/users/alch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alch/subscriptions","organizations_url":"https://api.github.com/users/alch/orgs","repos_url":"https://api.github.com/users/alch/repos","events_url":"https://api.github.com/users/alch/events{/privacy}","received_events_url":"https://api.github.com/users/alch/received_events","type":"User","site_admin":false},"body":"This is a working PaymentSuite package implementing Paypal web Checkout.\r\nSome improvements were necessary in order to make it compliant with other PaymentSuite payment methods.\r\n\r\nChangeset:\r\n \r\n* Added a payment_cancel route\r\n* Renamed manager methods to be more explicit\r\n* Removed unused class properties. Fixed some routes\r\n* Adapting payment services\r\n* Improved PaypalWebCheckoutMethod\r\n* Passed php-cs-fixer and php-formatter\r\n* Small style fixes\r\n* Added URLFactory service\r\n* Improved transaction check and PaypalWebCheckoutMethod","created_at":"2014-11-06T12:41:46Z","updated_at":"2014-11-07T23:31:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a0882d3fdc5a8ac22e91f153dddff12e654c4e09","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/PaymentSuite/PaypalWebCheckoutBundle/pulls/11/commits","review_comments_url":"https://api.github.com/repos/PaymentSuite/PaypalWebCheckoutBundle/pulls/11/comments","review_comment_url":"https://api.github.com/repos/PaymentSuite/PaypalWebCheckoutBundle/pulls/comments/{number}","comments_url":"https://api.github.com/repos/PaymentSuite/PaypalWebCheckoutBundle/issues/11/comments","statuses_url":"https://api.github.com/repos/PaymentSuite/PaypalWebCheckoutBundle/statuses/397f1fc0ea0fd0f89cf4a29505a4759ab7deaa43","head":{"label":"alch:master","ref":"master","sha":"397f1fc0ea0fd0f89cf4a29505a4759ab7deaa43","user":{"login":"alch","id":682515,"avatar_url":"https://avatars.githubusercontent.com/u/682515?v=3","gravatar_id":"","url":"https://api.github.com/users/alch","html_url":"https://github.com/alch","followers_url":"https://api.github.com/users/alch/followers","following_url":"https://api.github.com/users/alch/following{/other_user}","gists_url":"https://api.github.com/users/alch/gists{/gist_id}","starred_url":"https://api.github.com/users/alch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alch/subscriptions","organizations_url":"https://api.github.com/users/alch/orgs","repos_url":"https://api.github.com/users/alch/repos","events_url":"https://api.github.com/users/alch/events{/privacy}","received_events_url":"https://api.github.com/users/alch/received_events","type":"User","site_admin":false},"repo":{"id":24607495,"name":"PaypalWebCheckoutBundle","full_name":"alch/PaypalWebCheckoutBundle","owner":{"login":"alch","id":682515,"avatar_url":"https://avatars.githubusercontent.com/u/682515?v=3","gravatar_id":"","url":"https://api.github.com/users/alch","html_url":"https://github.com/alch","followers_url":"https://api.github.com/users/alch/followers","following_url":"https://api.github.com/users/alch/following{/other_user}","gists_url":"https://api.github.com/users/alch/gists{/gist_id}","starred_url":"https://api.github.com/users/alch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alch/subscriptions","organizations_url":"https://api.github.com/users/alch/orgs","repos_url":"https://api.github.com/users/alch/repos","events_url":"https://api.github.com/users/alch/events{/privacy}","received_events_url":"https://api.github.com/users/alch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alch/PaypalWebCheckoutBundle","description":"PayPal web checkout for PaymentSuite","fork":true,"url":"https://api.github.com/repos/alch/PaypalWebCheckoutBundle","forks_url":"https://api.github.com/repos/alch/PaypalWebCheckoutBundle/forks","keys_url":"https://api.github.com/repos/alch/PaypalWebCheckoutBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alch/PaypalWebCheckoutBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alch/PaypalWebCheckoutBundle/teams","hooks_url":"https://api.github.com/repos/alch/PaypalWebCheckoutBundle/hooks","issue_events_url":"https://api.github.com/repos/alch/PaypalWebCheckoutBundle/issues/events{/number}","events_url":"https://api.github.com/repos/alch/PaypalWebCheckoutBundle/events","assignees_url":"https://api.github.com/repos/alch/PaypalWebCheckoutBundle/assignees{/user}","branches_url":"https://api.github.com/repos/alch/PaypalWebCheckoutBundle/branches{/branch}","tags_url":"https://api.github.com/repos/alch/PaypalWebCheckoutBundle/tags","blobs_url":"https://api.github.com/repos/alch/PaypalWebCheckoutBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alch/PaypalWebCheckoutBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alch/PaypalWebCheckoutBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/alch/PaypalWebCheckoutBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alch/PaypalWebCheckoutBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/alch/PaypalWebCheckoutBundle/languages","stargazers_url":"https://api.github.com/repos/alch/PaypalWebCheckoutBundle/stargazers","contributors_url":"https://api.github.com/repos/alch/PaypalWebCheckoutBundle/contributors","subscribers_url":"https://api.github.com/repos/alch/PaypalWebCheckoutBundle/subscribers","subscription_url":"https://api.github.com/repos/alch/PaypalWebCheckoutBundle/subscription","commits_url":"https://api.github.com/repos/alch/PaypalWebCheckoutBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/alch/PaypalWebCheckoutBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/alch/PaypalWebCheckoutBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/alch/PaypalWebCheckoutBundle/issues/comments/{number}","contents_url":"https://api.github.com/repos/alch/PaypalWebCheckoutBundle/contents/{+path}","compare_url":"https://api.github.com/repos/alch/PaypalWebCheckoutBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alch/PaypalWebCheckoutBundle/merges","archive_url":"https://api.github.com/repos/alch/PaypalWebCheckoutBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alch/PaypalWebCheckoutBundle/downloads","issues_url":"https://api.github.com/repos/alch/PaypalWebCheckoutBundle/issues{/number}","pulls_url":"https://api.github.com/repos/alch/PaypalWebCheckoutBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/alch/PaypalWebCheckoutBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/alch/PaypalWebCheckoutBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alch/PaypalWebCheckoutBundle/labels{/name}","releases_url":"https://api.github.com/repos/alch/PaypalWebCheckoutBundle/releases{/id}","created_at":"2014-09-29T18:30:00Z","updated_at":"2014-09-29T18:32:03Z","pushed_at":"2014-11-06T12:37:23Z","git_url":"git://github.com/alch/PaypalWebCheckoutBundle.git","ssh_url":"git@github.com:alch/PaypalWebCheckoutBundle.git","clone_url":"https://github.com/alch/PaypalWebCheckoutBundle.git","svn_url":"https://github.com/alch/PaypalWebCheckoutBundle","homepage":null,"size":179,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PaymentSuite:master","ref":"master","sha":"2a8f2c57e5c8d45bf1f020dacee241ff00da5093","user":{"login":"PaymentSuite","id":6288066,"avatar_url":"https://avatars.githubusercontent.com/u/6288066?v=3","gravatar_id":"","url":"https://api.github.com/users/PaymentSuite","html_url":"https://github.com/PaymentSuite","followers_url":"https://api.github.com/users/PaymentSuite/followers","following_url":"https://api.github.com/users/PaymentSuite/following{/other_user}","gists_url":"https://api.github.com/users/PaymentSuite/gists{/gist_id}","starred_url":"https://api.github.com/users/PaymentSuite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PaymentSuite/subscriptions","organizations_url":"https://api.github.com/users/PaymentSuite/orgs","repos_url":"https://api.github.com/users/PaymentSuite/repos","events_url":"https://api.github.com/users/PaymentSuite/events{/privacy}","received_events_url":"https://api.github.com/users/PaymentSuite/received_events","type":"Organization","site_admin":false},"repo":{"id":23487224,"name":"PaypalWebCheckoutBundle","full_name":"PaymentSuite/PaypalWebCheckoutBundle","owner":{"login":"PaymentSuite","id":6288066,"avatar_url":"https://avatars.githubusercontent.com/u/6288066?v=3","gravatar_id":"","url":"https://api.github.com/users/PaymentSuite","html_url":"https://github.com/PaymentSuite","followers_url":"https://api.github.com/users/PaymentSuite/followers","following_url":"https://api.github.com/users/PaymentSuite/following{/other_user}","gists_url":"https://api.github.com/users/PaymentSuite/gists{/gist_id}","starred_url":"https://api.github.com/users/PaymentSuite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PaymentSuite/subscriptions","organizations_url":"https://api.github.com/users/PaymentSuite/orgs","repos_url":"https://api.github.com/users/PaymentSuite/repos","events_url":"https://api.github.com/users/PaymentSuite/events{/privacy}","received_events_url":"https://api.github.com/users/PaymentSuite/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PaymentSuite/PaypalWebCheckoutBundle","description":"PayPal web checkout for PaymentSuite","fork":false,"url":"https://api.github.com/repos/PaymentSuite/PaypalWebCheckoutBundle","forks_url":"https://api.github.com/repos/PaymentSuite/PaypalWebCheckoutBundle/forks","keys_url":"https://api.github.com/repos/PaymentSuite/PaypalWebCheckoutBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PaymentSuite/PaypalWebCheckoutBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PaymentSuite/PaypalWebCheckoutBundle/teams","hooks_url":"https://api.github.com/repos/PaymentSuite/PaypalWebCheckoutBundle/hooks","issue_events_url":"https://api.github.com/repos/PaymentSuite/PaypalWebCheckoutBundle/issues/events{/number}","events_url":"https://api.github.com/repos/PaymentSuite/PaypalWebCheckoutBundle/events","assignees_url":"https://api.github.com/repos/PaymentSuite/PaypalWebCheckoutBundle/assignees{/user}","branches_url":"https://api.github.com/repos/PaymentSuite/PaypalWebCheckoutBundle/branches{/branch}","tags_url":"https://api.github.com/repos/PaymentSuite/PaypalWebCheckoutBundle/tags","blobs_url":"https://api.github.com/repos/PaymentSuite/PaypalWebCheckoutBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PaymentSuite/PaypalWebCheckoutBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PaymentSuite/PaypalWebCheckoutBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/PaymentSuite/PaypalWebCheckoutBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PaymentSuite/PaypalWebCheckoutBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/PaymentSuite/PaypalWebCheckoutBundle/languages","stargazers_url":"https://api.github.com/repos/PaymentSuite/PaypalWebCheckoutBundle/stargazers","contributors_url":"https://api.github.com/repos/PaymentSuite/PaypalWebCheckoutBundle/contributors","subscribers_url":"https://api.github.com/repos/PaymentSuite/PaypalWebCheckoutBundle/subscribers","subscription_url":"https://api.github.com/repos/PaymentSuite/PaypalWebCheckoutBundle/subscription","commits_url":"https://api.github.com/repos/PaymentSuite/PaypalWebCheckoutBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/PaymentSuite/PaypalWebCheckoutBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/PaymentSuite/PaypalWebCheckoutBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/PaymentSuite/PaypalWebCheckoutBundle/issues/comments/{number}","contents_url":"https://api.github.com/repos/PaymentSuite/PaypalWebCheckoutBundle/contents/{+path}","compare_url":"https://api.github.com/repos/PaymentSuite/PaypalWebCheckoutBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PaymentSuite/PaypalWebCheckoutBundle/merges","archive_url":"https://api.github.com/repos/PaymentSuite/PaypalWebCheckoutBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PaymentSuite/PaypalWebCheckoutBundle/downloads","issues_url":"https://api.github.com/repos/PaymentSuite/PaypalWebCheckoutBundle/issues{/number}","pulls_url":"https://api.github.com/repos/PaymentSuite/PaypalWebCheckoutBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/PaymentSuite/PaypalWebCheckoutBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/PaymentSuite/PaypalWebCheckoutBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PaymentSuite/PaypalWebCheckoutBundle/labels{/name}","releases_url":"https://api.github.com/repos/PaymentSuite/PaypalWebCheckoutBundle/releases{/id}","created_at":"2014-08-30T07:45:18Z","updated_at":"2014-09-29T13:40:35Z","pushed_at":"2014-11-05T09:55:17Z","git_url":"git://github.com/PaymentSuite/PaypalWebCheckoutBundle.git","ssh_url":"git@github.com:PaymentSuite/PaypalWebCheckoutBundle.git","clone_url":"https://github.com/PaymentSuite/PaypalWebCheckoutBundle.git","svn_url":"https://github.com/PaymentSuite/PaypalWebCheckoutBundle","homepage":null,"size":534,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":5,"forks":2,"open_issues":5,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PaymentSuite/PaypalWebCheckoutBundle/pulls/11"},"html":{"href":"https://github.com/PaymentSuite/PaypalWebCheckoutBundle/pull/11"},"issue":{"href":"https://api.github.com/repos/PaymentSuite/PaypalWebCheckoutBundle/issues/11"},"comments":{"href":"https://api.github.com/repos/PaymentSuite/PaypalWebCheckoutBundle/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/PaymentSuite/PaypalWebCheckoutBundle/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/PaymentSuite/PaypalWebCheckoutBundle/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/PaymentSuite/PaypalWebCheckoutBundle/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/PaymentSuite/PaypalWebCheckoutBundle/statuses/397f1fc0ea0fd0f89cf4a29505a4759ab7deaa43"}}}}