GitHub PullRequestReviewCommentEvent at 2014-08-28 15:14:09
Repository: bordeaux3d
Actor: DavidBruant
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/anthill/bordeaux3d/pulls/comments/16845856","id":16845856,"diff_hunk":"@@ -15,8 +15,26 @@ var scene = new THREE.Scene();\n var WIDTH = window.innerWidth,\n     HEIGHT = window.innerHeight;\n \n+// skysphere\n+var geometry = new THREE.SphereGeometry(100000, 60, 40);\n+var uniforms = {\n+  texture: { type: 't', value: THREE.ImageUtils.loadTexture('../img/sky.jpg') }\n+};\n+\n+var material = new THREE.ShaderMaterial( {\n+  uniforms:       uniforms,\n+  vertexShader:   document.getElementById('sky-vertex').textContent,\n+  fragmentShader: document.getElementById('sky-fragment').textContent\n+});\n+\n+var skyBox = new THREE.Mesh(geometry, material);\n+skyBox.scale.set(-1, 1, 1);\n+skyBox.eulerOrder = 'XZY';\n+skyBox.renderDepth = 1000.0;\n+scene.add(skyBox);\n+\n // Create a camera, zoom it out from the model a bit, and add it to the scene.\n-var camera = new THREE.PerspectiveCamera( 60, WIDTH / HEIGHT, 1, 5000 );\n+var camera = new THREE.PerspectiveCamera( 60, WIDTH / HEIGHT, 1, 500000 );","path":"front/src/3dviz.js","position":24,"original_position":24,"commit_id":"4885be3ae1fea51e2c555a3d1c6cb3c1c75a6b38","original_commit_id":"4885be3ae1fea51e2c555a3d1c6cb3c1c75a6b38","user":{"login":"DavidBruant","id":165829,"avatar_url":"https://avatars.githubusercontent.com/u/165829?v=2","gravatar_id":"b9b113093c351a599f86e0647c43add1","url":"https://api.github.com/users/DavidBruant","html_url":"https://github.com/DavidBruant","followers_url":"https://api.github.com/users/DavidBruant/followers","following_url":"https://api.github.com/users/DavidBruant/following{/other_user}","gists_url":"https://api.github.com/users/DavidBruant/gists{/gist_id}","starred_url":"https://api.github.com/users/DavidBruant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DavidBruant/subscriptions","organizations_url":"https://api.github.com/users/DavidBruant/orgs","repos_url":"https://api.github.com/users/DavidBruant/repos","events_url":"https://api.github.com/users/DavidBruant/events{/privacy}","received_events_url":"https://api.github.com/users/DavidBruant/received_events","type":"User","site_admin":false},"body":"Why?","created_at":"2014-08-28T15:14:09Z","updated_at":"2014-08-28T15:14:09Z","html_url":"https://github.com/anthill/bordeaux3d/pull/41#discussion_r16845856","pull_request_url":"https://api.github.com/repos/anthill/bordeaux3d/pulls/41","_links":{"self":{"href":"https://api.github.com/repos/anthill/bordeaux3d/pulls/comments/16845856"},"html":{"href":"https://github.com/anthill/bordeaux3d/pull/41#discussion_r16845856"},"pull_request":{"href":"https://api.github.com/repos/anthill/bordeaux3d/pulls/41"}}},"pull_request":{"url":"https://api.github.com/repos/anthill/bordeaux3d/pulls/41","id":20422449,"html_url":"https://github.com/anthill/bordeaux3d/pull/41","diff_url":"https://github.com/anthill/bordeaux3d/pull/41.diff","patch_url":"https://github.com/anthill/bordeaux3d/pull/41.patch","issue_url":"https://api.github.com/repos/anthill/bordeaux3d/issues/41","number":41,"state":"open","locked":false,"title":"added skysphere fixes #35 :sunrise:","user":{"login":"vallettea","id":371303,"avatar_url":"https://avatars.githubusercontent.com/u/371303?v=2","gravatar_id":"9238693c9b69a6f30230ded87fa5af65","url":"https://api.github.com/users/vallettea","html_url":"https://github.com/vallettea","followers_url":"https://api.github.com/users/vallettea/followers","following_url":"https://api.github.com/users/vallettea/following{/other_user}","gists_url":"https://api.github.com/users/vallettea/gists{/gist_id}","starred_url":"https://api.github.com/users/vallettea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vallettea/subscriptions","organizations_url":"https://api.github.com/users/vallettea/orgs","repos_url":"https://api.github.com/users/vallettea/repos","events_url":"https://api.github.com/users/vallettea/events{/privacy}","received_events_url":"https://api.github.com/users/vallettea/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-08-28T07:47:18Z","updated_at":"2014-08-28T15:14:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c487415f4bde2bcbd69a1d7b8ccf01b1f79173f3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/anthill/bordeaux3d/pulls/41/commits","review_comments_url":"https://api.github.com/repos/anthill/bordeaux3d/pulls/41/comments","review_comment_url":"https://api.github.com/repos/anthill/bordeaux3d/pulls/comments/{number}","comments_url":"https://api.github.com/repos/anthill/bordeaux3d/issues/41/comments","statuses_url":"https://api.github.com/repos/anthill/bordeaux3d/statuses/4885be3ae1fea51e2c555a3d1c6cb3c1c75a6b38","head":{"label":"vallettea:sunposition","ref":"sunposition","sha":"4885be3ae1fea51e2c555a3d1c6cb3c1c75a6b38","user":{"login":"vallettea","id":371303,"avatar_url":"https://avatars.githubusercontent.com/u/371303?v=2","gravatar_id":"9238693c9b69a6f30230ded87fa5af65","url":"https://api.github.com/users/vallettea","html_url":"https://github.com/vallettea","followers_url":"https://api.github.com/users/vallettea/followers","following_url":"https://api.github.com/users/vallettea/following{/other_user}","gists_url":"https://api.github.com/users/vallettea/gists{/gist_id}","starred_url":"https://api.github.com/users/vallettea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vallettea/subscriptions","organizations_url":"https://api.github.com/users/vallettea/orgs","repos_url":"https://api.github.com/users/vallettea/repos","events_url":"https://api.github.com/users/vallettea/events{/privacy}","received_events_url":"https://api.github.com/users/vallettea/received_events","type":"User","site_admin":false},"repo":{"id":22958658,"name":"bordeaux3d","full_name":"vallettea/bordeaux3d","owner":{"login":"vallettea","id":371303,"avatar_url":"https://avatars.githubusercontent.com/u/371303?v=2","gravatar_id":"9238693c9b69a6f30230ded87fa5af65","url":"https://api.github.com/users/vallettea","html_url":"https://github.com/vallettea","followers_url":"https://api.github.com/users/vallettea/followers","following_url":"https://api.github.com/users/vallettea/following{/other_user}","gists_url":"https://api.github.com/users/vallettea/gists{/gist_id}","starred_url":"https://api.github.com/users/vallettea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vallettea/subscriptions","organizations_url":"https://api.github.com/users/vallettea/orgs","repos_url":"https://api.github.com/users/vallettea/repos","events_url":"https://api.github.com/users/vallettea/events{/privacy}","received_events_url":"https://api.github.com/users/vallettea/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vallettea/bordeaux3d","description":"","fork":true,"url":"https://api.github.com/repos/vallettea/bordeaux3d","forks_url":"https://api.github.com/repos/vallettea/bordeaux3d/forks","keys_url":"https://api.github.com/repos/vallettea/bordeaux3d/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vallettea/bordeaux3d/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vallettea/bordeaux3d/teams","hooks_url":"https://api.github.com/repos/vallettea/bordeaux3d/hooks","issue_events_url":"https://api.github.com/repos/vallettea/bordeaux3d/issues/events{/number}","events_url":"https://api.github.com/repos/vallettea/bordeaux3d/events","assignees_url":"https://api.github.com/repos/vallettea/bordeaux3d/assignees{/user}","branches_url":"https://api.github.com/repos/vallettea/bordeaux3d/branches{/branch}","tags_url":"https://api.github.com/repos/vallettea/bordeaux3d/tags","blobs_url":"https://api.github.com/repos/vallettea/bordeaux3d/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vallettea/bordeaux3d/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vallettea/bordeaux3d/git/refs{/sha}","trees_url":"https://api.github.com/repos/vallettea/bordeaux3d/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vallettea/bordeaux3d/statuses/{sha}","languages_url":"https://api.github.com/repos/vallettea/bordeaux3d/languages","stargazers_url":"https://api.github.com/repos/vallettea/bordeaux3d/stargazers","contributors_url":"https://api.github.com/repos/vallettea/bordeaux3d/contributors","subscribers_url":"https://api.github.com/repos/vallettea/bordeaux3d/subscribers","subscription_url":"https://api.github.com/repos/vallettea/bordeaux3d/subscription","commits_url":"https://api.github.com/repos/vallettea/bordeaux3d/commits{/sha}","git_commits_url":"https://api.github.com/repos/vallettea/bordeaux3d/git/commits{/sha}","comments_url":"https://api.github.com/repos/vallettea/bordeaux3d/comments{/number}","issue_comment_url":"https://api.github.com/repos/vallettea/bordeaux3d/issues/comments/{number}","contents_url":"https://api.github.com/repos/vallettea/bordeaux3d/contents/{+path}","compare_url":"https://api.github.com/repos/vallettea/bordeaux3d/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vallettea/bordeaux3d/merges","archive_url":"https://api.github.com/repos/vallettea/bordeaux3d/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vallettea/bordeaux3d/downloads","issues_url":"https://api.github.com/repos/vallettea/bordeaux3d/issues{/number}","pulls_url":"https://api.github.com/repos/vallettea/bordeaux3d/pulls{/number}","milestones_url":"https://api.github.com/repos/vallettea/bordeaux3d/milestones{/number}","notifications_url":"https://api.github.com/repos/vallettea/bordeaux3d/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vallettea/bordeaux3d/labels{/name}","releases_url":"https://api.github.com/repos/vallettea/bordeaux3d/releases{/id}","created_at":"2014-08-14T15:23:09Z","updated_at":"2014-08-15T10:51:03Z","pushed_at":"2014-08-28T07:46:53Z","git_url":"git://github.com/vallettea/bordeaux3d.git","ssh_url":"git@github.com:vallettea/bordeaux3d.git","clone_url":"https://github.com/vallettea/bordeaux3d.git","svn_url":"https://github.com/vallettea/bordeaux3d","homepage":null,"size":714,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"anthill:master","ref":"master","sha":"38494e556e176b2bb643a5d629a0163f9bc11f96","user":{"login":"anthill","id":7281593,"avatar_url":"https://avatars.githubusercontent.com/u/7281593?v=2","gravatar_id":"d8e2bff88da442dc1368bda806193962","url":"https://api.github.com/users/anthill","html_url":"https://github.com/anthill","followers_url":"https://api.github.com/users/anthill/followers","following_url":"https://api.github.com/users/anthill/following{/other_user}","gists_url":"https://api.github.com/users/anthill/gists{/gist_id}","starred_url":"https://api.github.com/users/anthill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthill/subscriptions","organizations_url":"https://api.github.com/users/anthill/orgs","repos_url":"https://api.github.com/users/anthill/repos","events_url":"https://api.github.com/users/anthill/events{/privacy}","received_events_url":"https://api.github.com/users/anthill/received_events","type":"Organization","site_admin":false},"repo":{"id":22834495,"name":"bordeaux3d","full_name":"anthill/bordeaux3d","owner":{"login":"anthill","id":7281593,"avatar_url":"https://avatars.githubusercontent.com/u/7281593?v=2","gravatar_id":"d8e2bff88da442dc1368bda806193962","url":"https://api.github.com/users/anthill","html_url":"https://github.com/anthill","followers_url":"https://api.github.com/users/anthill/followers","following_url":"https://api.github.com/users/anthill/following{/other_user}","gists_url":"https://api.github.com/users/anthill/gists{/gist_id}","starred_url":"https://api.github.com/users/anthill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthill/subscriptions","organizations_url":"https://api.github.com/users/anthill/orgs","repos_url":"https://api.github.com/users/anthill/repos","events_url":"https://api.github.com/users/anthill/events{/privacy}","received_events_url":"https://api.github.com/users/anthill/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/anthill/bordeaux3d","description":"","fork":false,"url":"https://api.github.com/repos/anthill/bordeaux3d","forks_url":"https://api.github.com/repos/anthill/bordeaux3d/forks","keys_url":"https://api.github.com/repos/anthill/bordeaux3d/keys{/key_id}","collaborators_url":"https://api.github.com/repos/anthill/bordeaux3d/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/anthill/bordeaux3d/teams","hooks_url":"https://api.github.com/repos/anthill/bordeaux3d/hooks","issue_events_url":"https://api.github.com/repos/anthill/bordeaux3d/issues/events{/number}","events_url":"https://api.github.com/repos/anthill/bordeaux3d/events","assignees_url":"https://api.github.com/repos/anthill/bordeaux3d/assignees{/user}","branches_url":"https://api.github.com/repos/anthill/bordeaux3d/branches{/branch}","tags_url":"https://api.github.com/repos/anthill/bordeaux3d/tags","blobs_url":"https://api.github.com/repos/anthill/bordeaux3d/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/anthill/bordeaux3d/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/anthill/bordeaux3d/git/refs{/sha}","trees_url":"https://api.github.com/repos/anthill/bordeaux3d/git/trees{/sha}","statuses_url":"https://api.github.com/repos/anthill/bordeaux3d/statuses/{sha}","languages_url":"https://api.github.com/repos/anthill/bordeaux3d/languages","stargazers_url":"https://api.github.com/repos/anthill/bordeaux3d/stargazers","contributors_url":"https://api.github.com/repos/anthill/bordeaux3d/contributors","subscribers_url":"https://api.github.com/repos/anthill/bordeaux3d/subscribers","subscription_url":"https://api.github.com/repos/anthill/bordeaux3d/subscription","commits_url":"https://api.github.com/repos/anthill/bordeaux3d/commits{/sha}","git_commits_url":"https://api.github.com/repos/anthill/bordeaux3d/git/commits{/sha}","comments_url":"https://api.github.com/repos/anthill/bordeaux3d/comments{/number}","issue_comment_url":"https://api.github.com/repos/anthill/bordeaux3d/issues/comments/{number}","contents_url":"https://api.github.com/repos/anthill/bordeaux3d/contents/{+path}","compare_url":"https://api.github.com/repos/anthill/bordeaux3d/compare/{base}...{head}","merges_url":"https://api.github.com/repos/anthill/bordeaux3d/merges","archive_url":"https://api.github.com/repos/anthill/bordeaux3d/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/anthill/bordeaux3d/downloads","issues_url":"https://api.github.com/repos/anthill/bordeaux3d/issues{/number}","pulls_url":"https://api.github.com/repos/anthill/bordeaux3d/pulls{/number}","milestones_url":"https://api.github.com/repos/anthill/bordeaux3d/milestones{/number}","notifications_url":"https://api.github.com/repos/anthill/bordeaux3d/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/anthill/bordeaux3d/labels{/name}","releases_url":"https://api.github.com/repos/anthill/bordeaux3d/releases{/id}","created_at":"2014-08-11T09:53:50Z","updated_at":"2014-08-11T09:54:17Z","pushed_at":"2014-08-27T12:05:36Z","git_url":"git://github.com/anthill/bordeaux3d.git","ssh_url":"git@github.com:anthill/bordeaux3d.git","clone_url":"https://github.com/anthill/bordeaux3d.git","svn_url":"https://github.com/anthill/bordeaux3d","homepage":null,"size":939,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":4,"mirror_url":null,"open_issues_count":20,"forks":4,"open_issues":20,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/anthill/bordeaux3d/pulls/41"},"html":{"href":"https://github.com/anthill/bordeaux3d/pull/41"},"issue":{"href":"https://api.github.com/repos/anthill/bordeaux3d/issues/41"},"comments":{"href":"https://api.github.com/repos/anthill/bordeaux3d/issues/41/comments"},"review_comments":{"href":"https://api.github.com/repos/anthill/bordeaux3d/pulls/41/comments"},"review_comment":{"href":"https://api.github.com/repos/anthill/bordeaux3d/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/anthill/bordeaux3d/pulls/41/commits"},"statuses":{"href":"https://api.github.com/repos/anthill/bordeaux3d/statuses/4885be3ae1fea51e2c555a3d1c6cb3c1c75a6b38"}}}}