GitHub PullRequestReviewCommentEvent at 2014-12-19 22:29:02
Repository: chronicle
Actor: 6a68
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/chronicle/pulls/comments/22133242","id":22133242,"diff_hunk":"@@ -0,0 +1,76 @@\n+/* This Source Code Form is subject to the terms of the Mozilla Public\n+ * License, v. 2.0. If a copy of the MPL was not distributed with this\n+ * file, You can obtain one at http://mozilla.org/MPL/2.0/. */\n+\n+'use strict';\n+\n+// TODO extract schema into, you know, a schema file\n+// TODO figure out migrations story - node-migrate?\n+\n+var mysql = require('mysql');\n+var config = require('../config');\n+var log = require('../logger')('server.db');\n+\n+// TODO use connection pooling","path":"server/db/create_db.js","position":14,"original_position":14,"commit_id":"992e7a72a657f905678838440c9221308ad85952","original_commit_id":"992e7a72a657f905678838440c9221308ad85952","user":{"login":"6a68","id":96396,"avatar_url":"https://avatars.githubusercontent.com/u/96396?v=3","gravatar_id":"","url":"https://api.github.com/users/6a68","html_url":"https://github.com/6a68","followers_url":"https://api.github.com/users/6a68/followers","following_url":"https://api.github.com/users/6a68/following{/other_user}","gists_url":"https://api.github.com/users/6a68/gists{/gist_id}","starred_url":"https://api.github.com/users/6a68/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/6a68/subscriptions","organizations_url":"https://api.github.com/users/6a68/orgs","repos_url":"https://api.github.com/users/6a68/repos","events_url":"https://api.github.com/users/6a68/events{/privacy}","received_events_url":"https://api.github.com/users/6a68/received_events","type":"User","site_admin":false},"body":"yeah, the db code is really terrible","created_at":"2014-12-19T22:29:02Z","updated_at":"2014-12-19T22:29:02Z","html_url":"https://github.com/mozilla/chronicle/pull/42#discussion_r22133242","pull_request_url":"https://api.github.com/repos/mozilla/chronicle/pulls/42","_links":{"self":{"href":"https://api.github.com/repos/mozilla/chronicle/pulls/comments/22133242"},"html":{"href":"https://github.com/mozilla/chronicle/pull/42#discussion_r22133242"},"pull_request":{"href":"https://api.github.com/repos/mozilla/chronicle/pulls/42"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/chronicle/pulls/42","id":26396420,"html_url":"https://github.com/mozilla/chronicle/pull/42","diff_url":"https://github.com/mozilla/chronicle/pull/42.diff","patch_url":"https://github.com/mozilla/chronicle/pull/42.patch","issue_url":"https://api.github.com/repos/mozilla/chronicle/issues/42","number":42,"state":"open","locked":false,"title":"feat(server): enable fxa oauth login + save to db","user":{"login":"6a68","id":96396,"avatar_url":"https://avatars.githubusercontent.com/u/96396?v=3","gravatar_id":"","url":"https://api.github.com/users/6a68","html_url":"https://github.com/6a68","followers_url":"https://api.github.com/users/6a68/followers","following_url":"https://api.github.com/users/6a68/following{/other_user}","gists_url":"https://api.github.com/users/6a68/gists{/gist_id}","starred_url":"https://api.github.com/users/6a68/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/6a68/subscriptions","organizations_url":"https://api.github.com/users/6a68/orgs","repos_url":"https://api.github.com/users/6a68/repos","events_url":"https://api.github.com/users/6a68/events{/privacy}","received_events_url":"https://api.github.com/users/6a68/received_events","type":"User","site_admin":false},"body":"\r\nFixes #40, almost-kinda-fixes #24.\r\n\r\nChanges of note:\r\n  * I'm able to do the complete oauth-driven login flow locally \\o/\r\n  * Remove jscs rule requiring a space after `function`\r\n  * Serve static bits from `/dist`, not `/app`\r\n  * Add mozlog logging: heka compatible in prod, yet readable for local dev\r\n\r\nParticularly ugly/dangerous TODOs:\r\n  * Added DB creation and DB client, (barely) functional yet so ugly\r\n  * Make outgoing HTTP requests from inside the route handler: reverse proxy\r\n    needed\r\n  * Not yet using a nonce to avoid replay attacks, because hapi sessions\r\n    are so &#$%! unnecessarily complicated\r\n\r\n-----\r\n\r\nr? @pdehaan && @seanmonstar && @nchapman \r\n\r\nI've got a super super hacky (yet working) front-end in my [issue-24-WIP](https://github.com/6a68/chronicle/tree/issue-24-WIP) branch; next I'll try to get a client-side commit together that works well enough with the code already in the repo.","created_at":"2014-12-19T20:21:37Z","updated_at":"2014-12-19T22:29:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9d01b3a5f3b4800729dc36c9f687f9d8de31a42c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/chronicle/pulls/42/commits","review_comments_url":"https://api.github.com/repos/mozilla/chronicle/pulls/42/comments","review_comment_url":"https://api.github.com/repos/mozilla/chronicle/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mozilla/chronicle/issues/42/comments","statuses_url":"https://api.github.com/repos/mozilla/chronicle/statuses/992e7a72a657f905678838440c9221308ad85952","head":{"label":"6a68:issue-24-server","ref":"issue-24-server","sha":"992e7a72a657f905678838440c9221308ad85952","user":{"login":"6a68","id":96396,"avatar_url":"https://avatars.githubusercontent.com/u/96396?v=3","gravatar_id":"","url":"https://api.github.com/users/6a68","html_url":"https://github.com/6a68","followers_url":"https://api.github.com/users/6a68/followers","following_url":"https://api.github.com/users/6a68/following{/other_user}","gists_url":"https://api.github.com/users/6a68/gists{/gist_id}","starred_url":"https://api.github.com/users/6a68/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/6a68/subscriptions","organizations_url":"https://api.github.com/users/6a68/orgs","repos_url":"https://api.github.com/users/6a68/repos","events_url":"https://api.github.com/users/6a68/events{/privacy}","received_events_url":"https://api.github.com/users/6a68/received_events","type":"User","site_admin":false},"repo":{"id":27658013,"name":"chronicle","full_name":"6a68/chronicle","owner":{"login":"6a68","id":96396,"avatar_url":"https://avatars.githubusercontent.com/u/96396?v=3","gravatar_id":"","url":"https://api.github.com/users/6a68","html_url":"https://github.com/6a68","followers_url":"https://api.github.com/users/6a68/followers","following_url":"https://api.github.com/users/6a68/following{/other_user}","gists_url":"https://api.github.com/users/6a68/gists{/gist_id}","starred_url":"https://api.github.com/users/6a68/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/6a68/subscriptions","organizations_url":"https://api.github.com/users/6a68/orgs","repos_url":"https://api.github.com/users/6a68/repos","events_url":"https://api.github.com/users/6a68/events{/privacy}","received_events_url":"https://api.github.com/users/6a68/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/6a68/chronicle","description":"find everything you've ever found","fork":true,"url":"https://api.github.com/repos/6a68/chronicle","forks_url":"https://api.github.com/repos/6a68/chronicle/forks","keys_url":"https://api.github.com/repos/6a68/chronicle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/6a68/chronicle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/6a68/chronicle/teams","hooks_url":"https://api.github.com/repos/6a68/chronicle/hooks","issue_events_url":"https://api.github.com/repos/6a68/chronicle/issues/events{/number}","events_url":"https://api.github.com/repos/6a68/chronicle/events","assignees_url":"https://api.github.com/repos/6a68/chronicle/assignees{/user}","branches_url":"https://api.github.com/repos/6a68/chronicle/branches{/branch}","tags_url":"https://api.github.com/repos/6a68/chronicle/tags","blobs_url":"https://api.github.com/repos/6a68/chronicle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/6a68/chronicle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/6a68/chronicle/git/refs{/sha}","trees_url":"https://api.github.com/repos/6a68/chronicle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/6a68/chronicle/statuses/{sha}","languages_url":"https://api.github.com/repos/6a68/chronicle/languages","stargazers_url":"https://api.github.com/repos/6a68/chronicle/stargazers","contributors_url":"https://api.github.com/repos/6a68/chronicle/contributors","subscribers_url":"https://api.github.com/repos/6a68/chronicle/subscribers","subscription_url":"https://api.github.com/repos/6a68/chronicle/subscription","commits_url":"https://api.github.com/repos/6a68/chronicle/commits{/sha}","git_commits_url":"https://api.github.com/repos/6a68/chronicle/git/commits{/sha}","comments_url":"https://api.github.com/repos/6a68/chronicle/comments{/number}","issue_comment_url":"https://api.github.com/repos/6a68/chronicle/issues/comments/{number}","contents_url":"https://api.github.com/repos/6a68/chronicle/contents/{+path}","compare_url":"https://api.github.com/repos/6a68/chronicle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/6a68/chronicle/merges","archive_url":"https://api.github.com/repos/6a68/chronicle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/6a68/chronicle/downloads","issues_url":"https://api.github.com/repos/6a68/chronicle/issues{/number}","pulls_url":"https://api.github.com/repos/6a68/chronicle/pulls{/number}","milestones_url":"https://api.github.com/repos/6a68/chronicle/milestones{/number}","notifications_url":"https://api.github.com/repos/6a68/chronicle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/6a68/chronicle/labels{/name}","releases_url":"https://api.github.com/repos/6a68/chronicle/releases{/id}","created_at":"2014-12-07T03:30:21Z","updated_at":"2014-12-19T18:33:47Z","pushed_at":"2014-12-19T20:19:32Z","git_url":"git://github.com/6a68/chronicle.git","ssh_url":"git@github.com:6a68/chronicle.git","clone_url":"https://github.com/6a68/chronicle.git","svn_url":"https://github.com/6a68/chronicle","homepage":"http://mozillachronicle.tumblr.com/","size":208,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"6faaf649f1d1b616dcc9bee9a9e42fe4067e36ff","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":27606769,"name":"chronicle","full_name":"mozilla/chronicle","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/chronicle","description":"find everything you've ever found","fork":false,"url":"https://api.github.com/repos/mozilla/chronicle","forks_url":"https://api.github.com/repos/mozilla/chronicle/forks","keys_url":"https://api.github.com/repos/mozilla/chronicle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/chronicle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/chronicle/teams","hooks_url":"https://api.github.com/repos/mozilla/chronicle/hooks","issue_events_url":"https://api.github.com/repos/mozilla/chronicle/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/chronicle/events","assignees_url":"https://api.github.com/repos/mozilla/chronicle/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/chronicle/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/chronicle/tags","blobs_url":"https://api.github.com/repos/mozilla/chronicle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/chronicle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/chronicle/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/chronicle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/chronicle/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/chronicle/languages","stargazers_url":"https://api.github.com/repos/mozilla/chronicle/stargazers","contributors_url":"https://api.github.com/repos/mozilla/chronicle/contributors","subscribers_url":"https://api.github.com/repos/mozilla/chronicle/subscribers","subscription_url":"https://api.github.com/repos/mozilla/chronicle/subscription","commits_url":"https://api.github.com/repos/mozilla/chronicle/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/chronicle/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/chronicle/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/chronicle/issues/comments/{number}","contents_url":"https://api.github.com/repos/mozilla/chronicle/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/chronicle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/chronicle/merges","archive_url":"https://api.github.com/repos/mozilla/chronicle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/chronicle/downloads","issues_url":"https://api.github.com/repos/mozilla/chronicle/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/chronicle/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/chronicle/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/chronicle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/chronicle/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/chronicle/releases{/id}","created_at":"2014-12-05T19:31:19Z","updated_at":"2014-12-18T22:55:27Z","pushed_at":"2014-12-18T22:55:32Z","git_url":"git://github.com/mozilla/chronicle.git","ssh_url":"git@github.com:mozilla/chronicle.git","clone_url":"https://github.com/mozilla/chronicle.git","svn_url":"https://github.com/mozilla/chronicle","homepage":"http://mozillachronicle.tumblr.com/","size":472,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":16,"forks":3,"open_issues":16,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/chronicle/pulls/42"},"html":{"href":"https://github.com/mozilla/chronicle/pull/42"},"issue":{"href":"https://api.github.com/repos/mozilla/chronicle/issues/42"},"comments":{"href":"https://api.github.com/repos/mozilla/chronicle/issues/42/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/chronicle/pulls/42/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/chronicle/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mozilla/chronicle/pulls/42/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/chronicle/statuses/992e7a72a657f905678838440c9221308ad85952"}}}}