GitHub PullRequestReviewCommentEvent at 2014-04-08 14:58:04
Repository: sportsApp
Actor: davejlane
Payload: {"comment":{"url":"https://api.github.com/repos/sportsApp/sportsApp/pulls/comments/11393459","id":11393459,"diff_hunk":"@@ -1,9 +1,9 @@\n 'use strict';\n \n angular.module('sportsApp')\n-  .controller('MainCtrl', function ($scope, $http, espnAPI) {\n-    espnAPI.topHeadlines().success(function(data) {\n-      $scope.headlines = data.headlines;\n-      console.log($scope.headlines);\n+  .controller('MainCtrl', ['$scope', 'espnSports', '$log', function ($scope, sports, $log) {\n+    sports.get().$promise.then(function(data) {\n+      $scope.headlines = data;\n+      $log.info($scope.headlines);\n     });\n-  });\n+  }]);","path":"app/scripts/controllers/main.js","position":14,"original_position":14,"commit_id":"c55521c9f404986a32b318e6a05b5a2971d83f0f","original_commit_id":"c55521c9f404986a32b318e6a05b5a2971d83f0f","user":{"login":"davejlane","id":1855310,"avatar_url":"https://avatars.githubusercontent.com/u/1855310?","gravatar_id":"921843ff95cf36f9f4a3d68ed10cfc75","url":"https://api.github.com/users/davejlane","html_url":"https://github.com/davejlane","followers_url":"https://api.github.com/users/davejlane/followers","following_url":"https://api.github.com/users/davejlane/following{/other_user}","gists_url":"https://api.github.com/users/davejlane/gists{/gist_id}","starred_url":"https://api.github.com/users/davejlane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davejlane/subscriptions","organizations_url":"https://api.github.com/users/davejlane/orgs","repos_url":"https://api.github.com/users/davejlane/repos","events_url":"https://api.github.com/users/davejlane/events{/privacy}","received_events_url":"https://api.github.com/users/davejlane/received_events","type":"User","site_admin":false},"body":"I noticed that we're injecting dependencies in an array now. I read that this helps with minification (in that is won't minify the variables and cause problems.) Any other reason for doing it?","created_at":"2014-04-08T14:58:04Z","updated_at":"2014-04-08T14:58:04Z","html_url":"https://github.com/sportsApp/sportsApp/pull/5#discussion_r11393459","pull_request_url":"https://api.github.com/repos/sportsApp/sportsApp/pulls/5","_links":{"self":{"href":"https://api.github.com/repos/sportsApp/sportsApp/pulls/comments/11393459"},"html":{"href":"https://github.com/sportsApp/sportsApp/pull/5#discussion_r11393459"},"pull_request":{"href":"https://api.github.com/repos/sportsApp/sportsApp/pulls/5"}}}}