GitHub PullRequestReviewCommentEvent at 2014-05-27 17:54:01
Repository: cassovary
Actor: agrewal
Payload: {"comment":{"url":"https://api.github.com/repos/twitter/cassovary/pulls/comments/13091558","id":13091558,"diff_hunk":"@@ -62,82 +62,146 @@ object ArrayBasedDirectedGraph {\n    * 6. instantiate in-edge arrays\n    * 7. iterate over the sequence of nodes again, instantiate in-edges\n    */\n-  def apply(iteratorSeq: Seq[ () => Iterator[NodeIdEdgesMaxId] ], executorService: ExecutorService,\n-      storedGraphDir: StoredGraphDir) = {\n+  def apply(iteratorSeq: Seq[() => Iterator[NodeIdEdgesMaxId]], executorService: ExecutorService,\n+            storedGraphDir: StoredGraphDir) = {\n+\n+    val result = for {\n+      (nodesOutEdges, maxNodeId, nodeWithOutEdgesMaxId) <- fillOutEdges(iteratorSeq, storedGraphDir)\n+      (table, nodeIdSet) <- markStoredNodes(nodesOutEdges, maxNodeId, storedGraphDir)\n+      NodesWithNoOutEdgesAndGraphStats(nodesWithNoOutEdges, nodeWithOutEdgesCount, numEdges, numNodes) =\n+        createNodesWithNoOutEdges(table, nodeIdSet, maxNodeId, storedGraphDir)\n+      _ <-\n+        if (storedGraphDir == StoredGraphDir.BothInOut)\n+          fillMissingInEdges(table, nodesOutEdges, nodesWithNoOutEdges, nodeIdSet, maxNodeId)\n+        else\n+          Future.value(())","path":"cassovary-core/src/main/scala/com/twitter/cassovary/graph/ArrayBasedDirectedGraph.scala","position":66,"original_position":66,"commit_id":"c66263753377cc10a07981197e841116d0b595c9","original_commit_id":"c66263753377cc10a07981197e841116d0b595c9","user":{"login":"agrewal","id":312330,"avatar_url":"https://avatars.githubusercontent.com/u/312330?","gravatar_id":"09de2f23e8c913232e8e8e791cd05bf8","url":"https://api.github.com/users/agrewal","html_url":"https://github.com/agrewal","followers_url":"https://api.github.com/users/agrewal/followers","following_url":"https://api.github.com/users/agrewal/following{/other_user}","gists_url":"https://api.github.com/users/agrewal/gists{/gist_id}","starred_url":"https://api.github.com/users/agrewal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agrewal/subscriptions","organizations_url":"https://api.github.com/users/agrewal/orgs","repos_url":"https://api.github.com/users/agrewal/repos","events_url":"https://api.github.com/users/agrewal/events{/privacy}","received_events_url":"https://api.github.com/users/agrewal/received_events","type":"User","site_admin":false},"body":"Future.Done","created_at":"2014-05-27T17:54:01Z","updated_at":"2014-05-27T17:54:01Z","html_url":"https://github.com/twitter/cassovary/pull/72#discussion_r13091558","pull_request_url":"https://api.github.com/repos/twitter/cassovary/pulls/72","_links":{"self":{"href":"https://api.github.com/repos/twitter/cassovary/pulls/comments/13091558"},"html":{"href":"https://github.com/twitter/cassovary/pull/72#discussion_r13091558"},"pull_request":{"href":"https://api.github.com/repos/twitter/cassovary/pulls/72"}}}}