GitHub PullRequestReviewCommentEvent at 2014-08-28 00:03:36
Repository: kubernetes
Actor: jbeda
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/16813398","id":16813398,"diff_hunk":"@@ -40,30 +40,46 @@ function gitcommit() {\n   return 0\n }\n \n-if [[ -z \"$(which go)\" ]]; then\n-  echo \"Can't find 'go' in PATH, please fix and retry.\" >&2\n-  echo \"See http://golang.org/doc/install for installation instructions.\" >&2\n-  exit 1\n-fi\n-\n-if [[ -z \"$(which godep)\" ]]; then\n-  echo \"Can't find 'godep' in PATH, please fix and retry.\" >&2\n-  echo \"See https://github.com/GoogleCloudPlatform/kubernetes#godep-and-dependency-management\" >&2\n-  exit 1\n-fi\n+# kube::check_go will check that `go` and `godep` commands are available in","path":"hack/config-go.sh","position":15,"original_position":15,"commit_id":"3a496f8de8523034834bd6a8e5840471afdd2fff","original_commit_id":"3a496f8de8523034834bd6a8e5840471afdd2fff","user":{"login":"jbeda","id":37310,"avatar_url":"https://avatars.githubusercontent.com/u/37310?v=2","gravatar_id":"f0bf7410bf277bf7e238e067bb60f7cf","url":"https://api.github.com/users/jbeda","html_url":"https://github.com/jbeda","followers_url":"https://api.github.com/users/jbeda/followers","following_url":"https://api.github.com/users/jbeda/following{/other_user}","gists_url":"https://api.github.com/users/jbeda/gists{/gist_id}","starred_url":"https://api.github.com/users/jbeda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbeda/subscriptions","organizations_url":"https://api.github.com/users/jbeda/orgs","repos_url":"https://api.github.com/users/jbeda/repos","events_url":"https://api.github.com/users/jbeda/events{/privacy}","received_events_url":"https://api.github.com/users/jbeda/received_events","type":"User","site_admin":false},"body":"Comment out of date?","created_at":"2014-08-28T00:03:36Z","updated_at":"2014-08-28T00:03:36Z","html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/1069#discussion_r16813398","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/1069","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/16813398"},"html":{"href":"https://github.com/GoogleCloudPlatform/kubernetes/pull/1069#discussion_r16813398"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/1069"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/1069","id":20410535,"html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/1069","diff_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/1069.diff","patch_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/1069.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/1069","number":1069,"state":"open","locked":false,"title":"Move go detection and environment setup into its own function","user":{"login":"filbranden","id":106037,"avatar_url":"https://avatars.githubusercontent.com/u/106037?v=2","gravatar_id":"61737e0b179eb5d8e6078b6e72ccb776","url":"https://api.github.com/users/filbranden","html_url":"https://github.com/filbranden","followers_url":"https://api.github.com/users/filbranden/followers","following_url":"https://api.github.com/users/filbranden/following{/other_user}","gists_url":"https://api.github.com/users/filbranden/gists{/gist_id}","starred_url":"https://api.github.com/users/filbranden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/filbranden/subscriptions","organizations_url":"https://api.github.com/users/filbranden/orgs","repos_url":"https://api.github.com/users/filbranden/repos","events_url":"https://api.github.com/users/filbranden/events{/privacy}","received_events_url":"https://api.github.com/users/filbranden/received_events","type":"User","site_admin":false},"body":"@jbeda please take a look.\r\n\r\nThis should fix the Vagrant issue.\r\n\r\nCheers,\r\nFilipe\r\n","created_at":"2014-08-28T00:02:22Z","updated_at":"2014-08-28T00:03:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"37c16ffb808f7c912f2c251fbd8240cefa942f31","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/1069/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/1069/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/{number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/1069/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/3a496f8de8523034834bd6a8e5840471afdd2fff","head":{"label":"filbranden:vagrant_config1","ref":"vagrant_config1","sha":"3a496f8de8523034834bd6a8e5840471afdd2fff","user":{"login":"filbranden","id":106037,"avatar_url":"https://avatars.githubusercontent.com/u/106037?v=2","gravatar_id":"61737e0b179eb5d8e6078b6e72ccb776","url":"https://api.github.com/users/filbranden","html_url":"https://github.com/filbranden","followers_url":"https://api.github.com/users/filbranden/followers","following_url":"https://api.github.com/users/filbranden/following{/other_user}","gists_url":"https://api.github.com/users/filbranden/gists{/gist_id}","starred_url":"https://api.github.com/users/filbranden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/filbranden/subscriptions","organizations_url":"https://api.github.com/users/filbranden/orgs","repos_url":"https://api.github.com/users/filbranden/repos","events_url":"https://api.github.com/users/filbranden/events{/privacy}","received_events_url":"https://api.github.com/users/filbranden/received_events","type":"User","site_admin":false},"repo":{"id":22449002,"name":"kubernetes","full_name":"filbranden/kubernetes","owner":{"login":"filbranden","id":106037,"avatar_url":"https://avatars.githubusercontent.com/u/106037?v=2","gravatar_id":"61737e0b179eb5d8e6078b6e72ccb776","url":"https://api.github.com/users/filbranden","html_url":"https://github.com/filbranden","followers_url":"https://api.github.com/users/filbranden/followers","following_url":"https://api.github.com/users/filbranden/following{/other_user}","gists_url":"https://api.github.com/users/filbranden/gists{/gist_id}","starred_url":"https://api.github.com/users/filbranden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/filbranden/subscriptions","organizations_url":"https://api.github.com/users/filbranden/orgs","repos_url":"https://api.github.com/users/filbranden/repos","events_url":"https://api.github.com/users/filbranden/events{/privacy}","received_events_url":"https://api.github.com/users/filbranden/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/filbranden/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/filbranden/kubernetes","forks_url":"https://api.github.com/repos/filbranden/kubernetes/forks","keys_url":"https://api.github.com/repos/filbranden/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/filbranden/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/filbranden/kubernetes/teams","hooks_url":"https://api.github.com/repos/filbranden/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/filbranden/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/filbranden/kubernetes/events","assignees_url":"https://api.github.com/repos/filbranden/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/filbranden/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/filbranden/kubernetes/tags","blobs_url":"https://api.github.com/repos/filbranden/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/filbranden/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/filbranden/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/filbranden/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/filbranden/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/filbranden/kubernetes/languages","stargazers_url":"https://api.github.com/repos/filbranden/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/filbranden/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/filbranden/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/filbranden/kubernetes/subscription","commits_url":"https://api.github.com/repos/filbranden/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/filbranden/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/filbranden/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/filbranden/kubernetes/issues/comments/{number}","contents_url":"https://api.github.com/repos/filbranden/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/filbranden/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/filbranden/kubernetes/merges","archive_url":"https://api.github.com/repos/filbranden/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/filbranden/kubernetes/downloads","issues_url":"https://api.github.com/repos/filbranden/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/filbranden/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/filbranden/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/filbranden/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/filbranden/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/filbranden/kubernetes/releases{/id}","created_at":"2014-07-30T23:41:25Z","updated_at":"2014-07-31T17:33:18Z","pushed_at":"2014-08-28T00:01:50Z","git_url":"git://github.com/filbranden/kubernetes.git","ssh_url":"git@github.com:filbranden/kubernetes.git","clone_url":"https://github.com/filbranden/kubernetes.git","svn_url":"https://github.com/filbranden/kubernetes","homepage":null,"size":8672,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"1319309174f97946626f01a9720a191512f9137d","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=2","gravatar_id":"3db02c6238c8b1fb844871330744ec5d","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"GoogleCloudPlatform/kubernetes","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=2","gravatar_id":"3db02c6238c8b1fb844871330744ec5d","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/kubernetes","description":"Container Cluster Manager","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/comments/{number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/releases{/id}","created_at":"2014-06-06T22:56:04Z","updated_at":"2014-08-27T23:03:33Z","pushed_at":"2014-08-27T23:56:09Z","git_url":"git://github.com/GoogleCloudPlatform/kubernetes.git","ssh_url":"git@github.com:GoogleCloudPlatform/kubernetes.git","clone_url":"https://github.com/GoogleCloudPlatform/kubernetes.git","svn_url":"https://github.com/GoogleCloudPlatform/kubernetes","homepage":null,"size":25066,"stargazers_count":3259,"watchers_count":3259,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":423,"mirror_url":null,"open_issues_count":162,"forks":423,"open_issues":162,"watchers":3259,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/1069"},"html":{"href":"https://github.com/GoogleCloudPlatform/kubernetes/pull/1069"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/1069"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/1069/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/1069/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/1069/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/3a496f8de8523034834bd6a8e5840471afdd2fff"}}}}