GitHub PullRequestReviewCommentEvent at 2014-04-02 09:11:19
Repository: WikibaseQueryEngine
Actor: thiemowmde
Payload: {"comment":{"url":"https://api.github.com/repos/wmde/WikibaseQueryEngine/pulls/comments/11197330","id":11197330,"diff_hunk":"@@ -31,13 +37,19 @@ public function __construct() {\n \t\t\t\t\t\tnew TypeDefinition( TypeDefinition::TYPE_VARCHAR ),\n \t\t\t\t\t\tFieldDefinition::NOT_NULL\n \t\t\t\t\t),\n+\t\t\t\t\tnew FieldDefinition( 'hash',\n+\t\t\t\t\t\tnew TypeDefinition( TypeDefinition::TYPE_VARCHAR, 70 ),","path":"src/SQLStore/DVHandler/StringHandler.php","position":25,"original_position":25,"commit_id":"9b6b75b1833bfbb2b7994b9cf981e5c71f4b8026","original_commit_id":"9b6b75b1833bfbb2b7994b9cf981e5c71f4b8026","user":{"login":"thiemowmde","id":6576639,"avatar_url":"https://avatars.githubusercontent.com/u/6576639?","gravatar_id":"37a5d7555c26958a623057f5937bbe05","url":"https://api.github.com/users/thiemowmde","html_url":"https://github.com/thiemowmde","followers_url":"https://api.github.com/users/thiemowmde/followers","following_url":"https://api.github.com/users/thiemowmde/following{/other_user}","gists_url":"https://api.github.com/users/thiemowmde/gists{/gist_id}","starred_url":"https://api.github.com/users/thiemowmde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thiemowmde/subscriptions","organizations_url":"https://api.github.com/users/thiemowmde/orgs","repos_url":"https://api.github.com/users/thiemowmde/repos","events_url":"https://api.github.com/users/thiemowmde/events{/privacy}","received_events_url":"https://api.github.com/users/thiemowmde/received_events","type":"User","site_admin":false},"body":"At least the 70 should be a 50.\r\n\r\nWe seem to agree that these two places strongly depend on each other and need to be based on the same information. Which is not the case currently and leads to errors like this. The question if A uses B or B uses A is not so important to me.","created_at":"2014-04-02T09:11:19Z","updated_at":"2014-04-02T09:11:19Z","html_url":"https://github.com/wmde/WikibaseQueryEngine/pull/14#discussion_r11197330","pull_request_url":"https://api.github.com/repos/wmde/WikibaseQueryEngine/pulls/14","_links":{"self":{"href":"https://api.github.com/repos/wmde/WikibaseQueryEngine/pulls/comments/11197330"},"html":{"href":"https://github.com/wmde/WikibaseQueryEngine/pull/14#discussion_r11197330"},"pull_request":{"href":"https://api.github.com/repos/wmde/WikibaseQueryEngine/pulls/14"}}}}