GitHub PullRequestReviewCommentEvent at 2014-10-01 10:08:11
Repository: juju
Actor: mjs
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/juju/juju/pulls/comments/18270005","id":18270005,"diff_hunk":"@@ -132,8 +189,36 @@ func (s *loginSuite) TestLoginAsDeactivatedUser(c *gc.C) {\n \tc.Assert(err, gc.ErrorMatches, `unknown object type \"Client\"`)\n }\n \n-func (s *loginSuite) TestLoginSetsLogIdentifier(c *gc.C) {\n-\tinfo, cleanup := s.setupServer(c)\n+func (s *loginV0Suite) TestLoginSetsLogIdentifier(c *gc.C) {\n+\ts.runLoginSetsLogIdentifier(c, []string{\n+\t\t`<- \\[[0-9A-F]+\\] <unknown> {\"RequestId\":2,\"Type\":\"Admin\",\"Request\":\"Login\",` +","path":"apiserver/admin_test.go","position":115,"original_position":115,"commit_id":"9e6c90e08e0aebd8134b0d51a1c6a9fead1a708e","original_commit_id":"9e6c90e08e0aebd8134b0d51a1c6a9fead1a708e","user":{"login":"mjs","id":14993,"avatar_url":"https://avatars.githubusercontent.com/u/14993?v=2","gravatar_id":"","url":"https://api.github.com/users/mjs","html_url":"https://github.com/mjs","followers_url":"https://api.github.com/users/mjs/followers","following_url":"https://api.github.com/users/mjs/following{/other_user}","gists_url":"https://api.github.com/users/mjs/gists{/gist_id}","starred_url":"https://api.github.com/users/mjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjs/subscriptions","organizations_url":"https://api.github.com/users/mjs/orgs","repos_url":"https://api.github.com/users/mjs/repos","events_url":"https://api.github.com/users/mjs/events{/privacy}","received_events_url":"https://api.github.com/users/mjs/received_events","type":"User","site_admin":false},"body":"It might be worth mentioning why it's RequestId 2 and 3 in this test, but 1 and 2 in the next. I presume it's because of the fallback to v0 if the v1 attempt fails?","created_at":"2014-10-01T10:08:11Z","updated_at":"2014-10-01T10:08:11Z","html_url":"https://github.com/juju/juju/pull/392#discussion_r18270005","pull_request_url":"https://api.github.com/repos/juju/juju/pulls/392","_links":{"self":{"href":"https://api.github.com/repos/juju/juju/pulls/comments/18270005"},"html":{"href":"https://github.com/juju/juju/pull/392#discussion_r18270005"},"pull_request":{"href":"https://api.github.com/repos/juju/juju/pulls/392"}}},"pull_request":{"url":"https://api.github.com/repos/juju/juju/pulls/392","id":18818512,"html_url":"https://github.com/juju/juju/pull/392","diff_url":"https://github.com/juju/juju/pull/392.diff","patch_url":"https://github.com/juju/juju/pull/392.patch","issue_url":"https://api.github.com/repos/juju/juju/issues/392","number":392,"state":"open","locked":false,"title":"Login v2 API","user":{"login":"cmars","id":23741,"avatar_url":"https://avatars.githubusercontent.com/u/23741?v=2","gravatar_id":"","url":"https://api.github.com/users/cmars","html_url":"https://github.com/cmars","followers_url":"https://api.github.com/users/cmars/followers","following_url":"https://api.github.com/users/cmars/following{/other_user}","gists_url":"https://api.github.com/users/cmars/gists{/gist_id}","starred_url":"https://api.github.com/users/cmars/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmars/subscriptions","organizations_url":"https://api.github.com/users/cmars/orgs","repos_url":"https://api.github.com/users/cmars/repos","events_url":"https://api.github.com/users/cmars/events{/privacy}","received_events_url":"https://api.github.com/users/cmars/received_events","type":"User","site_admin":false},"body":"Introducing the v2 Login API, backed by the original Admin.Login logic. Builds on proposed pull request #367.","created_at":"2014-07-24T05:37:57Z","updated_at":"2014-10-01T10:08:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"96f91cab1c2cf2211f7778bcf112f9c88d7f519c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/juju/juju/pulls/392/commits","review_comments_url":"https://api.github.com/repos/juju/juju/pulls/392/comments","review_comment_url":"https://api.github.com/repos/juju/juju/pulls/comments/{number}","comments_url":"https://api.github.com/repos/juju/juju/issues/392/comments","statuses_url":"https://api.github.com/repos/juju/juju/statuses/9e6c90e08e0aebd8134b0d51a1c6a9fead1a708e","head":{"label":"cmars:id_loginv2","ref":"id_loginv2","sha":"9e6c90e08e0aebd8134b0d51a1c6a9fead1a708e","user":{"login":"cmars","id":23741,"avatar_url":"https://avatars.githubusercontent.com/u/23741?v=2","gravatar_id":"","url":"https://api.github.com/users/cmars","html_url":"https://github.com/cmars","followers_url":"https://api.github.com/users/cmars/followers","following_url":"https://api.github.com/users/cmars/following{/other_user}","gists_url":"https://api.github.com/users/cmars/gists{/gist_id}","starred_url":"https://api.github.com/users/cmars/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmars/subscriptions","organizations_url":"https://api.github.com/users/cmars/orgs","repos_url":"https://api.github.com/users/cmars/repos","events_url":"https://api.github.com/users/cmars/events{/privacy}","received_events_url":"https://api.github.com/users/cmars/received_events","type":"User","site_admin":false},"repo":{"id":20448906,"name":"juju","full_name":"cmars/juju","owner":{"login":"cmars","id":23741,"avatar_url":"https://avatars.githubusercontent.com/u/23741?v=2","gravatar_id":"","url":"https://api.github.com/users/cmars","html_url":"https://github.com/cmars","followers_url":"https://api.github.com/users/cmars/followers","following_url":"https://api.github.com/users/cmars/following{/other_user}","gists_url":"https://api.github.com/users/cmars/gists{/gist_id}","starred_url":"https://api.github.com/users/cmars/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmars/subscriptions","organizations_url":"https://api.github.com/users/cmars/orgs","repos_url":"https://api.github.com/users/cmars/repos","events_url":"https://api.github.com/users/cmars/events{/privacy}","received_events_url":"https://api.github.com/users/cmars/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cmars/juju","description":"juju is devops distilled","fork":true,"url":"https://api.github.com/repos/cmars/juju","forks_url":"https://api.github.com/repos/cmars/juju/forks","keys_url":"https://api.github.com/repos/cmars/juju/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cmars/juju/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cmars/juju/teams","hooks_url":"https://api.github.com/repos/cmars/juju/hooks","issue_events_url":"https://api.github.com/repos/cmars/juju/issues/events{/number}","events_url":"https://api.github.com/repos/cmars/juju/events","assignees_url":"https://api.github.com/repos/cmars/juju/assignees{/user}","branches_url":"https://api.github.com/repos/cmars/juju/branches{/branch}","tags_url":"https://api.github.com/repos/cmars/juju/tags","blobs_url":"https://api.github.com/repos/cmars/juju/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cmars/juju/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cmars/juju/git/refs{/sha}","trees_url":"https://api.github.com/repos/cmars/juju/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cmars/juju/statuses/{sha}","languages_url":"https://api.github.com/repos/cmars/juju/languages","stargazers_url":"https://api.github.com/repos/cmars/juju/stargazers","contributors_url":"https://api.github.com/repos/cmars/juju/contributors","subscribers_url":"https://api.github.com/repos/cmars/juju/subscribers","subscription_url":"https://api.github.com/repos/cmars/juju/subscription","commits_url":"https://api.github.com/repos/cmars/juju/commits{/sha}","git_commits_url":"https://api.github.com/repos/cmars/juju/git/commits{/sha}","comments_url":"https://api.github.com/repos/cmars/juju/comments{/number}","issue_comment_url":"https://api.github.com/repos/cmars/juju/issues/comments/{number}","contents_url":"https://api.github.com/repos/cmars/juju/contents/{+path}","compare_url":"https://api.github.com/repos/cmars/juju/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cmars/juju/merges","archive_url":"https://api.github.com/repos/cmars/juju/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cmars/juju/downloads","issues_url":"https://api.github.com/repos/cmars/juju/issues{/number}","pulls_url":"https://api.github.com/repos/cmars/juju/pulls{/number}","milestones_url":"https://api.github.com/repos/cmars/juju/milestones{/number}","notifications_url":"https://api.github.com/repos/cmars/juju/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cmars/juju/labels{/name}","releases_url":"https://api.github.com/repos/cmars/juju/releases{/id}","created_at":"2014-06-03T15:45:35Z","updated_at":"2014-06-27T23:26:40Z","pushed_at":"2014-10-01T02:33:59Z","git_url":"git://github.com/cmars/juju.git","ssh_url":"git@github.com:cmars/juju.git","clone_url":"https://github.com/cmars/juju.git","svn_url":"https://github.com/cmars/juju","homepage":null,"size":30797,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"juju:master","ref":"master","sha":"2c0ff10e263ab64e373d831ccf569e8cd605cbe2","user":{"login":"juju","id":4604548,"avatar_url":"https://avatars.githubusercontent.com/u/4604548?v=2","gravatar_id":"","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"repo":{"id":20445947,"name":"juju","full_name":"juju/juju","owner":{"login":"juju","id":4604548,"avatar_url":"https://avatars.githubusercontent.com/u/4604548?v=2","gravatar_id":"","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/juju/juju","description":"juju is devops distilled","fork":false,"url":"https://api.github.com/repos/juju/juju","forks_url":"https://api.github.com/repos/juju/juju/forks","keys_url":"https://api.github.com/repos/juju/juju/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juju/juju/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juju/juju/teams","hooks_url":"https://api.github.com/repos/juju/juju/hooks","issue_events_url":"https://api.github.com/repos/juju/juju/issues/events{/number}","events_url":"https://api.github.com/repos/juju/juju/events","assignees_url":"https://api.github.com/repos/juju/juju/assignees{/user}","branches_url":"https://api.github.com/repos/juju/juju/branches{/branch}","tags_url":"https://api.github.com/repos/juju/juju/tags","blobs_url":"https://api.github.com/repos/juju/juju/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juju/juju/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juju/juju/git/refs{/sha}","trees_url":"https://api.github.com/repos/juju/juju/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juju/juju/statuses/{sha}","languages_url":"https://api.github.com/repos/juju/juju/languages","stargazers_url":"https://api.github.com/repos/juju/juju/stargazers","contributors_url":"https://api.github.com/repos/juju/juju/contributors","subscribers_url":"https://api.github.com/repos/juju/juju/subscribers","subscription_url":"https://api.github.com/repos/juju/juju/subscription","commits_url":"https://api.github.com/repos/juju/juju/commits{/sha}","git_commits_url":"https://api.github.com/repos/juju/juju/git/commits{/sha}","comments_url":"https://api.github.com/repos/juju/juju/comments{/number}","issue_comment_url":"https://api.github.com/repos/juju/juju/issues/comments/{number}","contents_url":"https://api.github.com/repos/juju/juju/contents/{+path}","compare_url":"https://api.github.com/repos/juju/juju/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juju/juju/merges","archive_url":"https://api.github.com/repos/juju/juju/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juju/juju/downloads","issues_url":"https://api.github.com/repos/juju/juju/issues{/number}","pulls_url":"https://api.github.com/repos/juju/juju/pulls{/number}","milestones_url":"https://api.github.com/repos/juju/juju/milestones{/number}","notifications_url":"https://api.github.com/repos/juju/juju/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juju/juju/labels{/name}","releases_url":"https://api.github.com/repos/juju/juju/releases{/id}","created_at":"2014-06-03T14:28:10Z","updated_at":"2014-10-01T03:19:48Z","pushed_at":"2014-10-01T07:59:04Z","git_url":"git://github.com/juju/juju.git","ssh_url":"git@github.com:juju/juju.git","clone_url":"https://github.com/juju/juju.git","svn_url":"https://github.com/juju/juju","homepage":"juju.ubuntu.com","size":50188,"stargazers_count":213,"watchers_count":213,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":57,"mirror_url":null,"open_issues_count":58,"forks":57,"open_issues":58,"watchers":213,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/juju/juju/pulls/392"},"html":{"href":"https://github.com/juju/juju/pull/392"},"issue":{"href":"https://api.github.com/repos/juju/juju/issues/392"},"comments":{"href":"https://api.github.com/repos/juju/juju/issues/392/comments"},"review_comments":{"href":"https://api.github.com/repos/juju/juju/pulls/392/comments"},"review_comment":{"href":"https://api.github.com/repos/juju/juju/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/juju/juju/pulls/392/commits"},"statuses":{"href":"https://api.github.com/repos/juju/juju/statuses/9e6c90e08e0aebd8134b0d51a1c6a9fead1a708e"}}}}