GitHub PullRequestReviewCommentEvent at 2014-09-18 15:30:30
Repository: wro4j
Actor: muffl0n
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/alexo/wro4j/pulls/comments/17734358","id":17734358,"diff_hunk":"@@ -93,7 +93,7 @@ public boolean isResourceChanged(final Resource resource) {\n       }\n       return changeDetected.get();\n     } catch (final IOException e) {\n-      getLog().debug(\"failed to check for delta resource: \" + resource);\n+      getLog().error(\"failed to check for delta resource: \" + resource, e);","path":"wro4j-maven-plugin/src/main/java/ro/isdc/wro/maven/plugin/support/ResourceChangeHandler.java","position":5,"original_position":5,"commit_id":"c0a03848076904c5625d97414ab89f9606094e98","original_commit_id":"c0a03848076904c5625d97414ab89f9606094e98","user":{"login":"muffl0n","id":927904,"avatar_url":"https://avatars.githubusercontent.com/u/927904?v=2","gravatar_id":"ca0d389825584eae8762eb12593bb04b","url":"https://api.github.com/users/muffl0n","html_url":"https://github.com/muffl0n","followers_url":"https://api.github.com/users/muffl0n/followers","following_url":"https://api.github.com/users/muffl0n/following{/other_user}","gists_url":"https://api.github.com/users/muffl0n/gists{/gist_id}","starred_url":"https://api.github.com/users/muffl0n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muffl0n/subscriptions","organizations_url":"https://api.github.com/users/muffl0n/orgs","repos_url":"https://api.github.com/users/muffl0n/repos","events_url":"https://api.github.com/users/muffl0n/events{/privacy}","received_events_url":"https://api.github.com/users/muffl0n/received_events","type":"User","site_admin":false},"body":"Sound's reasonable. Though like in #207 described it may be important to know the cause. E.g. FileNotFoundException.\r\nBut maybe the message would be more than enough.\r\n","created_at":"2014-09-18T15:30:30Z","updated_at":"2014-09-18T15:30:30Z","html_url":"https://github.com/alexo/wro4j/pull/206#discussion_r17734358","pull_request_url":"https://api.github.com/repos/alexo/wro4j/pulls/206","_links":{"self":{"href":"https://api.github.com/repos/alexo/wro4j/pulls/comments/17734358"},"html":{"href":"https://github.com/alexo/wro4j/pull/206#discussion_r17734358"},"pull_request":{"href":"https://api.github.com/repos/alexo/wro4j/pulls/206"}}},"pull_request":{"url":"https://api.github.com/repos/alexo/wro4j/pulls/206","id":21299026,"html_url":"https://github.com/alexo/wro4j/pull/206","diff_url":"https://github.com/alexo/wro4j/pull/206.diff","patch_url":"https://github.com/alexo/wro4j/pull/206.patch","issue_url":"https://api.github.com/repos/alexo/wro4j/issues/206","number":206,"state":"closed","locked":false,"title":"Output as error if delta check fails","user":{"login":"muffl0n","id":927904,"avatar_url":"https://avatars.githubusercontent.com/u/927904?v=2","gravatar_id":"ca0d389825584eae8762eb12593bb04b","url":"https://api.github.com/users/muffl0n","html_url":"https://github.com/muffl0n","followers_url":"https://api.github.com/users/muffl0n/followers","following_url":"https://api.github.com/users/muffl0n/following{/other_user}","gists_url":"https://api.github.com/users/muffl0n/gists{/gist_id}","starred_url":"https://api.github.com/users/muffl0n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muffl0n/subscriptions","organizations_url":"https://api.github.com/users/muffl0n/orgs","repos_url":"https://api.github.com/users/muffl0n/repos","events_url":"https://api.github.com/users/muffl0n/events{/privacy}","received_events_url":"https://api.github.com/users/muffl0n/received_events","type":"User","site_admin":false},"body":"This should be logged as an error.","created_at":"2014-09-16T13:50:36Z","updated_at":"2014-09-18T15:30:30Z","closed_at":"2014-09-16T20:24:22Z","merged_at":"2014-09-16T20:24:22Z","merge_commit_sha":"09466578ec79490ea72ed7bfbd5475e5928a87de","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/alexo/wro4j/pulls/206/commits","review_comments_url":"https://api.github.com/repos/alexo/wro4j/pulls/206/comments","review_comment_url":"https://api.github.com/repos/alexo/wro4j/pulls/comments/{number}","comments_url":"https://api.github.com/repos/alexo/wro4j/issues/206/comments","statuses_url":"https://api.github.com/repos/alexo/wro4j/statuses/c0a03848076904c5625d97414ab89f9606094e98","head":{"label":"muffl0n:1.7_failed_delta_check","ref":"1.7_failed_delta_check","sha":"c0a03848076904c5625d97414ab89f9606094e98","user":{"login":"muffl0n","id":927904,"avatar_url":"https://avatars.githubusercontent.com/u/927904?v=2","gravatar_id":"ca0d389825584eae8762eb12593bb04b","url":"https://api.github.com/users/muffl0n","html_url":"https://github.com/muffl0n","followers_url":"https://api.github.com/users/muffl0n/followers","following_url":"https://api.github.com/users/muffl0n/following{/other_user}","gists_url":"https://api.github.com/users/muffl0n/gists{/gist_id}","starred_url":"https://api.github.com/users/muffl0n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muffl0n/subscriptions","organizations_url":"https://api.github.com/users/muffl0n/orgs","repos_url":"https://api.github.com/users/muffl0n/repos","events_url":"https://api.github.com/users/muffl0n/events{/privacy}","received_events_url":"https://api.github.com/users/muffl0n/received_events","type":"User","site_admin":false},"repo":{"id":23458664,"name":"wro4j","full_name":"muffl0n/wro4j","owner":{"login":"muffl0n","id":927904,"avatar_url":"https://avatars.githubusercontent.com/u/927904?v=2","gravatar_id":"ca0d389825584eae8762eb12593bb04b","url":"https://api.github.com/users/muffl0n","html_url":"https://github.com/muffl0n","followers_url":"https://api.github.com/users/muffl0n/followers","following_url":"https://api.github.com/users/muffl0n/following{/other_user}","gists_url":"https://api.github.com/users/muffl0n/gists{/gist_id}","starred_url":"https://api.github.com/users/muffl0n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muffl0n/subscriptions","organizations_url":"https://api.github.com/users/muffl0n/orgs","repos_url":"https://api.github.com/users/muffl0n/repos","events_url":"https://api.github.com/users/muffl0n/events{/privacy}","received_events_url":"https://api.github.com/users/muffl0n/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/muffl0n/wro4j","description":"Free and Open Source Java project which brings together almost all the modern web tools: JsHint, CssLint, JsMin, Google Closure compressor, YUI Compressor, UglifyJs, Dojo Shrinksafe, Css Variables Support, JSON Compression, Less, Sass, CoffeeScript and much more. In the same time, the aim is to keep it as simple as possible and as extensible as possible in order to be easily adapted to application specific needs.","fork":true,"url":"https://api.github.com/repos/muffl0n/wro4j","forks_url":"https://api.github.com/repos/muffl0n/wro4j/forks","keys_url":"https://api.github.com/repos/muffl0n/wro4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/muffl0n/wro4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/muffl0n/wro4j/teams","hooks_url":"https://api.github.com/repos/muffl0n/wro4j/hooks","issue_events_url":"https://api.github.com/repos/muffl0n/wro4j/issues/events{/number}","events_url":"https://api.github.com/repos/muffl0n/wro4j/events","assignees_url":"https://api.github.com/repos/muffl0n/wro4j/assignees{/user}","branches_url":"https://api.github.com/repos/muffl0n/wro4j/branches{/branch}","tags_url":"https://api.github.com/repos/muffl0n/wro4j/tags","blobs_url":"https://api.github.com/repos/muffl0n/wro4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/muffl0n/wro4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/muffl0n/wro4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/muffl0n/wro4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/muffl0n/wro4j/statuses/{sha}","languages_url":"https://api.github.com/repos/muffl0n/wro4j/languages","stargazers_url":"https://api.github.com/repos/muffl0n/wro4j/stargazers","contributors_url":"https://api.github.com/repos/muffl0n/wro4j/contributors","subscribers_url":"https://api.github.com/repos/muffl0n/wro4j/subscribers","subscription_url":"https://api.github.com/repos/muffl0n/wro4j/subscription","commits_url":"https://api.github.com/repos/muffl0n/wro4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/muffl0n/wro4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/muffl0n/wro4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/muffl0n/wro4j/issues/comments/{number}","contents_url":"https://api.github.com/repos/muffl0n/wro4j/contents/{+path}","compare_url":"https://api.github.com/repos/muffl0n/wro4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/muffl0n/wro4j/merges","archive_url":"https://api.github.com/repos/muffl0n/wro4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/muffl0n/wro4j/downloads","issues_url":"https://api.github.com/repos/muffl0n/wro4j/issues{/number}","pulls_url":"https://api.github.com/repos/muffl0n/wro4j/pulls{/number}","milestones_url":"https://api.github.com/repos/muffl0n/wro4j/milestones{/number}","notifications_url":"https://api.github.com/repos/muffl0n/wro4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/muffl0n/wro4j/labels{/name}","releases_url":"https://api.github.com/repos/muffl0n/wro4j/releases{/id}","created_at":"2014-08-29T09:04:22Z","updated_at":"2014-09-16T20:23:08Z","pushed_at":"2014-09-18T13:42:11Z","git_url":"git://github.com/muffl0n/wro4j.git","ssh_url":"git@github.com:muffl0n/wro4j.git","clone_url":"https://github.com/muffl0n/wro4j.git","svn_url":"https://github.com/muffl0n/wro4j","homepage":"http://alexo.github.com/wro4j/","size":111777,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"1.7.x"}},"base":{"label":"alexo:1.7.x","ref":"1.7.x","sha":"0f6f950376c1877d821cfca388fe32afd67dad49","user":{"login":"alexo","id":30596,"avatar_url":"https://avatars.githubusercontent.com/u/30596?v=2","gravatar_id":"909892a9a8f332145fc01b6547cd3a3a","url":"https://api.github.com/users/alexo","html_url":"https://github.com/alexo","followers_url":"https://api.github.com/users/alexo/followers","following_url":"https://api.github.com/users/alexo/following{/other_user}","gists_url":"https://api.github.com/users/alexo/gists{/gist_id}","starred_url":"https://api.github.com/users/alexo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexo/subscriptions","organizations_url":"https://api.github.com/users/alexo/orgs","repos_url":"https://api.github.com/users/alexo/repos","events_url":"https://api.github.com/users/alexo/events{/privacy}","received_events_url":"https://api.github.com/users/alexo/received_events","type":"User","site_admin":false},"repo":{"id":223355,"name":"wro4j","full_name":"alexo/wro4j","owner":{"login":"alexo","id":30596,"avatar_url":"https://avatars.githubusercontent.com/u/30596?v=2","gravatar_id":"909892a9a8f332145fc01b6547cd3a3a","url":"https://api.github.com/users/alexo","html_url":"https://github.com/alexo","followers_url":"https://api.github.com/users/alexo/followers","following_url":"https://api.github.com/users/alexo/following{/other_user}","gists_url":"https://api.github.com/users/alexo/gists{/gist_id}","starred_url":"https://api.github.com/users/alexo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexo/subscriptions","organizations_url":"https://api.github.com/users/alexo/orgs","repos_url":"https://api.github.com/users/alexo/repos","events_url":"https://api.github.com/users/alexo/events{/privacy}","received_events_url":"https://api.github.com/users/alexo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alexo/wro4j","description":"Free and Open Source Java project which brings together almost all the modern web tools: JsHint, CssLint, JsMin, Google Closure compressor, YUI Compressor, UglifyJs, Dojo Shrinksafe, Css Variables Support, JSON Compression, Less, Sass, CoffeeScript and much more. In the same time, the aim is to keep it as simple as possible and as extensible as possible in order to be easily adapted to application specific needs.","fork":false,"url":"https://api.github.com/repos/alexo/wro4j","forks_url":"https://api.github.com/repos/alexo/wro4j/forks","keys_url":"https://api.github.com/repos/alexo/wro4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alexo/wro4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alexo/wro4j/teams","hooks_url":"https://api.github.com/repos/alexo/wro4j/hooks","issue_events_url":"https://api.github.com/repos/alexo/wro4j/issues/events{/number}","events_url":"https://api.github.com/repos/alexo/wro4j/events","assignees_url":"https://api.github.com/repos/alexo/wro4j/assignees{/user}","branches_url":"https://api.github.com/repos/alexo/wro4j/branches{/branch}","tags_url":"https://api.github.com/repos/alexo/wro4j/tags","blobs_url":"https://api.github.com/repos/alexo/wro4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alexo/wro4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alexo/wro4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/alexo/wro4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alexo/wro4j/statuses/{sha}","languages_url":"https://api.github.com/repos/alexo/wro4j/languages","stargazers_url":"https://api.github.com/repos/alexo/wro4j/stargazers","contributors_url":"https://api.github.com/repos/alexo/wro4j/contributors","subscribers_url":"https://api.github.com/repos/alexo/wro4j/subscribers","subscription_url":"https://api.github.com/repos/alexo/wro4j/subscription","commits_url":"https://api.github.com/repos/alexo/wro4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/alexo/wro4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/alexo/wro4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/alexo/wro4j/issues/comments/{number}","contents_url":"https://api.github.com/repos/alexo/wro4j/contents/{+path}","compare_url":"https://api.github.com/repos/alexo/wro4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alexo/wro4j/merges","archive_url":"https://api.github.com/repos/alexo/wro4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alexo/wro4j/downloads","issues_url":"https://api.github.com/repos/alexo/wro4j/issues{/number}","pulls_url":"https://api.github.com/repos/alexo/wro4j/pulls{/number}","milestones_url":"https://api.github.com/repos/alexo/wro4j/milestones{/number}","notifications_url":"https://api.github.com/repos/alexo/wro4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alexo/wro4j/labels{/name}","releases_url":"https://api.github.com/repos/alexo/wro4j/releases{/id}","created_at":"2009-06-10T09:31:25Z","updated_at":"2014-09-15T09:58:44Z","pushed_at":"2014-09-16T20:24:22Z","git_url":"git://github.com/alexo/wro4j.git","ssh_url":"git@github.com:alexo/wro4j.git","clone_url":"https://github.com/alexo/wro4j.git","svn_url":"https://github.com/alexo/wro4j","homepage":"http://alexo.github.com/wro4j/","size":138772,"stargazers_count":412,"watchers_count":412,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":128,"mirror_url":null,"open_issues_count":37,"forks":128,"open_issues":37,"watchers":412,"default_branch":"1.7.x"}},"_links":{"self":{"href":"https://api.github.com/repos/alexo/wro4j/pulls/206"},"html":{"href":"https://github.com/alexo/wro4j/pull/206"},"issue":{"href":"https://api.github.com/repos/alexo/wro4j/issues/206"},"comments":{"href":"https://api.github.com/repos/alexo/wro4j/issues/206/comments"},"review_comments":{"href":"https://api.github.com/repos/alexo/wro4j/pulls/206/comments"},"review_comment":{"href":"https://api.github.com/repos/alexo/wro4j/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/alexo/wro4j/pulls/206/commits"},"statuses":{"href":"https://api.github.com/repos/alexo/wro4j/statuses/c0a03848076904c5625d97414ab89f9606094e98"}}}}