GitHub PushEvent at 2014-04-06 16:52:55
Repository: Selenium-Remote-Driver
Actor: gempesaw
Payload: {"shas":[["1bed10d1433c657d15df4fef91607f3722948fdf","a3d25c5064152872436acc5e825a1d069072cffe@gmail.com","Promote firefox_profile to init hash argument\n\nI struggled with this for a few days - should the initiation look like\n\n    my $fp_driver = Selenium::Remote::Driver->new(firefox_profile => $fp);\n\nor\n\n    my $fp_driver = Selenium::Remote::Driver->new(extra_capabilities => {\n        firefox_profile => $fp\n    });\n\nMy issue is I'm not sure what the 'extra' in 'extra_capabilities' really\nrefers to. This leads to, in practice, some confusion about what\narguments go where.\n\nThe disadvantage of having it as a primary arg is that it adds to the\nconfusion of what extra_capabilities is for in the first place. The\nadvantage is that it will fit into the future way that is mentioned in\nissue #110 where everything in the init hash makes it into the\ndesiredCapabilities object in the eventual POST to /session.\n\nIt is probably internally consistent to have it in the\nextra_capabilities hash considering the current implementation in 0.18,\nbut I was reluctant to do that because it wouldn't reflect the new API\nthat should supercede extra_capabilities.\n\nI decided to promote it to a top level argument in light of the planned\nchanges from #110.","Daniel Gempesaw",true],["fc9758948ed1085261a267ef4834f8dbb44c155a","a3d25c5064152872436acc5e825a1d069072cffe@gmail.com","Generate a build branch for the firefox-profile changes","Daniel Gempesaw",true],["d9c59b5fae97197ce9ce2fefa65523e952bd7e1a","a3d25c5064152872436acc5e825a1d069072cffe@gmail.com","Update os x mocks temporarily","Daniel Gempesaw",true]],"size":3,"ref":"refs/heads/firefox-profile","head":"d9c59b5fae97197ce9ce2fefa65523e952bd7e1a"}