GitHub PullRequestReviewCommentEvent at 2014-02-17 12:42:40
Repository: picongpu
Actor: ax3l
Payload: {"comment":{"url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/comments/9790368","id":9790368,"diff_hunk":"@@ -37,10 +37,10 @@ struct Unit<position<T_Type> >\n {\n   static std::vector<double> get()\n   {\n-      std::vector<double> unit(DIM3);\n-      unit[0]=CELL_WIDTH*UNIT_LENGTH;\n-      unit[1]=CELL_HEIGHT*UNIT_LENGTH;\n-      unit[2]=CELL_DEPTH*UNIT_LENGTH;\n+      std::vector<double> unit(simDim);","path":"src/picongpu/include/simulation_defines/unitless/particleDefinition.unitless","position":8,"original_position":8,"commit_id":"319a9fd500639455c51636a9eb8ef7c92a86a405","original_commit_id":"319a9fd500639455c51636a9eb8ef7c92a86a405","user":{"login":"ax3l","id":1353258,"avatar_url":"https://gravatar.com/avatar/4e90f994fc8dcf8d280b6e104b07ec8d?d=https%3A%2F%2Fidenticons.github.com%2F8c363341cbd3c8b18bf75304b7ab1f4b.png&r=x","gravatar_id":"4e90f994fc8dcf8d280b6e104b07ec8d","url":"https://api.github.com/users/ax3l","html_url":"https://github.com/ax3l","followers_url":"https://api.github.com/users/ax3l/followers","following_url":"https://api.github.com/users/ax3l/following{/other_user}","gists_url":"https://api.github.com/users/ax3l/gists{/gist_id}","starred_url":"https://api.github.com/users/ax3l/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ax3l/subscriptions","organizations_url":"https://api.github.com/users/ax3l/orgs","repos_url":"https://api.github.com/users/ax3l/repos","events_url":"https://api.github.com/users/ax3l/events{/privacy}","received_events_url":"https://api.github.com/users/ax3l/received_events","type":"User","site_admin":false},"body":"I would add a little comment here, stating that the in-cell position needs **two** transformations to get to SI:\r\nin-cell [0;1) -> dimensionless scaling to grid -> SI","created_at":"2014-02-17T12:42:40Z","updated_at":"2014-02-17T12:42:40Z","html_url":"https://github.com/ComputationalRadiationPhysics/picongpu/pull/212#discussion_r9790368","pull_request_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/212","_links":{"self":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/comments/9790368"},"html":{"href":"https://github.com/ComputationalRadiationPhysics/picongpu/pull/212#discussion_r9790368"},"pull_request":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/212"}}}}