GitHub PullRequestReviewCommentEvent at 2014-07-10 05:02:37
Repository: reservations
Actor: orenyk
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/YaleSTC/reservations/pulls/comments/14749623","id":14749623,"diff_hunk":"@@ -18,6 +19,16 @@ def persisted?\n \n   ## Item methods\n \n+  def get_items\n+    # Used in cart_validations\n+    # Return items where the key is the full equipment model object\n+    # uses 1 database call","path":"app/models/cart.rb","position":14,"original_position":14,"commit_id":"5a2bc1796b4e0de75187982f37eadad194256b38","original_commit_id":"5a2bc1796b4e0de75187982f37eadad194256b38","user":{"login":"orenyk","id":901808,"avatar_url":"https://avatars.githubusercontent.com/u/901808?","gravatar_id":"01cdfa0c35ce3c98aa3bfd3717c2696b","url":"https://api.github.com/users/orenyk","html_url":"https://github.com/orenyk","followers_url":"https://api.github.com/users/orenyk/followers","following_url":"https://api.github.com/users/orenyk/following{/other_user}","gists_url":"https://api.github.com/users/orenyk/gists{/gist_id}","starred_url":"https://api.github.com/users/orenyk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orenyk/subscriptions","organizations_url":"https://api.github.com/users/orenyk/orgs","repos_url":"https://api.github.com/users/orenyk/repos","events_url":"https://api.github.com/users/orenyk/events{/privacy}","received_events_url":"https://api.github.com/users/orenyk/received_events","type":"User","site_admin":false},"body":"I really like that you've been documenting when you're making DB calls, let's try to make that the case across our codebase. It will not only be good for documentation purposes but could also potentially uncover some other inefficiencies.","created_at":"2014-07-10T05:02:37Z","updated_at":"2014-07-10T05:02:37Z","html_url":"https://github.com/YaleSTC/reservations/pull/644#discussion_r14749623","pull_request_url":"https://api.github.com/repos/YaleSTC/reservations/pulls/644","_links":{"self":{"href":"https://api.github.com/repos/YaleSTC/reservations/pulls/comments/14749623"},"html":{"href":"https://github.com/YaleSTC/reservations/pull/644#discussion_r14749623"},"pull_request":{"href":"https://api.github.com/repos/YaleSTC/reservations/pulls/644"}}},"pull_request":{"url":"https://api.github.com/repos/YaleSTC/reservations/pulls/644","id":18122320,"html_url":"https://github.com/YaleSTC/reservations/pull/644","diff_url":"https://github.com/YaleSTC/reservations/pull/644.diff","patch_url":"https://github.com/YaleSTC/reservations/pull/644.patch","issue_url":"https://api.github.com/repos/YaleSTC/reservations/issues/644","number":644,"state":"open","title":"Fundamental Rewrite of Validation System","user":{"login":"squidgetx","id":6618711,"avatar_url":"https://avatars.githubusercontent.com/u/6618711?","gravatar_id":"7f0c30c0370d6bf23a67d123511093f8","url":"https://api.github.com/users/squidgetx","html_url":"https://github.com/squidgetx","followers_url":"https://api.github.com/users/squidgetx/followers","following_url":"https://api.github.com/users/squidgetx/following{/other_user}","gists_url":"https://api.github.com/users/squidgetx/gists{/gist_id}","starred_url":"https://api.github.com/users/squidgetx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/squidgetx/subscriptions","organizations_url":"https://api.github.com/users/squidgetx/orgs","repos_url":"https://api.github.com/users/squidgetx/repos","events_url":"https://api.github.com/users/squidgetx/events{/privacy}","received_events_url":"https://api.github.com/users/squidgetx/received_events","type":"User","site_admin":false},"body":"* Moving all 'soft' validations to cart validations instead of reservation validations. This enables the cart to run most validations only one time instead of for every equipment model in the cart (available, renewable, duration, max cat count, max model count, reserver has overdue, blackout dates)\r\n* Reservation.validateSet is no more\r\n* Only necessary validations run when the dates are updated and when items are added/removed (doesn't check for blackout dates when adding a new item to cart, for instance)\r\n","created_at":"2014-07-08T19:11:12Z","updated_at":"2014-07-10T05:02:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c6e45aabbd6b8de9e4acebf9eb2e62f98d4ac377","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/YaleSTC/reservations/pulls/644/commits","review_comments_url":"https://api.github.com/repos/YaleSTC/reservations/pulls/644/comments","review_comment_url":"https://api.github.com/repos/YaleSTC/reservations/pulls/comments/{number}","comments_url":"https://api.github.com/repos/YaleSTC/reservations/issues/644/comments","statuses_url":"https://api.github.com/repos/YaleSTC/reservations/statuses/5a2bc1796b4e0de75187982f37eadad194256b38","head":{"label":"YaleSTC:573_validations_lol","ref":"573_validations_lol","sha":"5a2bc1796b4e0de75187982f37eadad194256b38","user":{"login":"YaleSTC","id":106094,"avatar_url":"https://avatars.githubusercontent.com/u/106094?","gravatar_id":"df3a705cdde504295b3fbb1f8a46bc60","url":"https://api.github.com/users/YaleSTC","html_url":"https://github.com/YaleSTC","followers_url":"https://api.github.com/users/YaleSTC/followers","following_url":"https://api.github.com/users/YaleSTC/following{/other_user}","gists_url":"https://api.github.com/users/YaleSTC/gists{/gist_id}","starred_url":"https://api.github.com/users/YaleSTC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YaleSTC/subscriptions","organizations_url":"https://api.github.com/users/YaleSTC/orgs","repos_url":"https://api.github.com/users/YaleSTC/repos","events_url":"https://api.github.com/users/YaleSTC/events{/privacy}","received_events_url":"https://api.github.com/users/YaleSTC/received_events","type":"Organization","site_admin":false},"repo":{"id":345280,"name":"reservations","full_name":"YaleSTC/reservations","owner":{"login":"YaleSTC","id":106094,"avatar_url":"https://avatars.githubusercontent.com/u/106094?","gravatar_id":"df3a705cdde504295b3fbb1f8a46bc60","url":"https://api.github.com/users/YaleSTC","html_url":"https://github.com/YaleSTC","followers_url":"https://api.github.com/users/YaleSTC/followers","following_url":"https://api.github.com/users/YaleSTC/following{/other_user}","gists_url":"https://api.github.com/users/YaleSTC/gists{/gist_id}","starred_url":"https://api.github.com/users/YaleSTC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YaleSTC/subscriptions","organizations_url":"https://api.github.com/users/YaleSTC/orgs","repos_url":"https://api.github.com/users/YaleSTC/repos","events_url":"https://api.github.com/users/YaleSTC/events{/privacy}","received_events_url":"https://api.github.com/users/YaleSTC/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/YaleSTC/reservations","description":"Manages reservations for equipment (allows student reservations)","fork":false,"url":"https://api.github.com/repos/YaleSTC/reservations","forks_url":"https://api.github.com/repos/YaleSTC/reservations/forks","keys_url":"https://api.github.com/repos/YaleSTC/reservations/keys{/key_id}","collaborators_url":"https://api.github.com/repos/YaleSTC/reservations/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/YaleSTC/reservations/teams","hooks_url":"https://api.github.com/repos/YaleSTC/reservations/hooks","issue_events_url":"https://api.github.com/repos/YaleSTC/reservations/issues/events{/number}","events_url":"https://api.github.com/repos/YaleSTC/reservations/events","assignees_url":"https://api.github.com/repos/YaleSTC/reservations/assignees{/user}","branches_url":"https://api.github.com/repos/YaleSTC/reservations/branches{/branch}","tags_url":"https://api.github.com/repos/YaleSTC/reservations/tags","blobs_url":"https://api.github.com/repos/YaleSTC/reservations/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/YaleSTC/reservations/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/YaleSTC/reservations/git/refs{/sha}","trees_url":"https://api.github.com/repos/YaleSTC/reservations/git/trees{/sha}","statuses_url":"https://api.github.com/repos/YaleSTC/reservations/statuses/{sha}","languages_url":"https://api.github.com/repos/YaleSTC/reservations/languages","stargazers_url":"https://api.github.com/repos/YaleSTC/reservations/stargazers","contributors_url":"https://api.github.com/repos/YaleSTC/reservations/contributors","subscribers_url":"https://api.github.com/repos/YaleSTC/reservations/subscribers","subscription_url":"https://api.github.com/repos/YaleSTC/reservations/subscription","commits_url":"https://api.github.com/repos/YaleSTC/reservations/commits{/sha}","git_commits_url":"https://api.github.com/repos/YaleSTC/reservations/git/commits{/sha}","comments_url":"https://api.github.com/repos/YaleSTC/reservations/comments{/number}","issue_comment_url":"https://api.github.com/repos/YaleSTC/reservations/issues/comments/{number}","contents_url":"https://api.github.com/repos/YaleSTC/reservations/contents/{+path}","compare_url":"https://api.github.com/repos/YaleSTC/reservations/compare/{base}...{head}","merges_url":"https://api.github.com/repos/YaleSTC/reservations/merges","archive_url":"https://api.github.com/repos/YaleSTC/reservations/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/YaleSTC/reservations/downloads","issues_url":"https://api.github.com/repos/YaleSTC/reservations/issues{/number}","pulls_url":"https://api.github.com/repos/YaleSTC/reservations/pulls{/number}","milestones_url":"https://api.github.com/repos/YaleSTC/reservations/milestones{/number}","notifications_url":"https://api.github.com/repos/YaleSTC/reservations/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/YaleSTC/reservations/labels{/name}","releases_url":"https://api.github.com/repos/YaleSTC/reservations/releases{/id}","created_at":"2009-10-21T21:08:00Z","updated_at":"2014-07-08T19:06:34Z","pushed_at":"2014-07-10T04:49:20Z","git_url":"git://github.com/YaleSTC/reservations.git","ssh_url":"git@github.com:YaleSTC/reservations.git","clone_url":"https://github.com/YaleSTC/reservations.git","svn_url":"https://github.com/YaleSTC/reservations","homepage":"","size":54083,"stargazers_count":18,"watchers_count":18,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":5,"mirror_url":null,"open_issues_count":141,"forks":5,"open_issues":141,"watchers":18,"default_branch":"development"}},"base":{"label":"YaleSTC:development","ref":"development","sha":"3b98f18fc4b9639d1e10f9b354b28b91fd8e0d75","user":{"login":"YaleSTC","id":106094,"avatar_url":"https://avatars.githubusercontent.com/u/106094?","gravatar_id":"df3a705cdde504295b3fbb1f8a46bc60","url":"https://api.github.com/users/YaleSTC","html_url":"https://github.com/YaleSTC","followers_url":"https://api.github.com/users/YaleSTC/followers","following_url":"https://api.github.com/users/YaleSTC/following{/other_user}","gists_url":"https://api.github.com/users/YaleSTC/gists{/gist_id}","starred_url":"https://api.github.com/users/YaleSTC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YaleSTC/subscriptions","organizations_url":"https://api.github.com/users/YaleSTC/orgs","repos_url":"https://api.github.com/users/YaleSTC/repos","events_url":"https://api.github.com/users/YaleSTC/events{/privacy}","received_events_url":"https://api.github.com/users/YaleSTC/received_events","type":"Organization","site_admin":false},"repo":{"id":345280,"name":"reservations","full_name":"YaleSTC/reservations","owner":{"login":"YaleSTC","id":106094,"avatar_url":"https://avatars.githubusercontent.com/u/106094?","gravatar_id":"df3a705cdde504295b3fbb1f8a46bc60","url":"https://api.github.com/users/YaleSTC","html_url":"https://github.com/YaleSTC","followers_url":"https://api.github.com/users/YaleSTC/followers","following_url":"https://api.github.com/users/YaleSTC/following{/other_user}","gists_url":"https://api.github.com/users/YaleSTC/gists{/gist_id}","starred_url":"https://api.github.com/users/YaleSTC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YaleSTC/subscriptions","organizations_url":"https://api.github.com/users/YaleSTC/orgs","repos_url":"https://api.github.com/users/YaleSTC/repos","events_url":"https://api.github.com/users/YaleSTC/events{/privacy}","received_events_url":"https://api.github.com/users/YaleSTC/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/YaleSTC/reservations","description":"Manages reservations for equipment (allows student reservations)","fork":false,"url":"https://api.github.com/repos/YaleSTC/reservations","forks_url":"https://api.github.com/repos/YaleSTC/reservations/forks","keys_url":"https://api.github.com/repos/YaleSTC/reservations/keys{/key_id}","collaborators_url":"https://api.github.com/repos/YaleSTC/reservations/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/YaleSTC/reservations/teams","hooks_url":"https://api.github.com/repos/YaleSTC/reservations/hooks","issue_events_url":"https://api.github.com/repos/YaleSTC/reservations/issues/events{/number}","events_url":"https://api.github.com/repos/YaleSTC/reservations/events","assignees_url":"https://api.github.com/repos/YaleSTC/reservations/assignees{/user}","branches_url":"https://api.github.com/repos/YaleSTC/reservations/branches{/branch}","tags_url":"https://api.github.com/repos/YaleSTC/reservations/tags","blobs_url":"https://api.github.com/repos/YaleSTC/reservations/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/YaleSTC/reservations/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/YaleSTC/reservations/git/refs{/sha}","trees_url":"https://api.github.com/repos/YaleSTC/reservations/git/trees{/sha}","statuses_url":"https://api.github.com/repos/YaleSTC/reservations/statuses/{sha}","languages_url":"https://api.github.com/repos/YaleSTC/reservations/languages","stargazers_url":"https://api.github.com/repos/YaleSTC/reservations/stargazers","contributors_url":"https://api.github.com/repos/YaleSTC/reservations/contributors","subscribers_url":"https://api.github.com/repos/YaleSTC/reservations/subscribers","subscription_url":"https://api.github.com/repos/YaleSTC/reservations/subscription","commits_url":"https://api.github.com/repos/YaleSTC/reservations/commits{/sha}","git_commits_url":"https://api.github.com/repos/YaleSTC/reservations/git/commits{/sha}","comments_url":"https://api.github.com/repos/YaleSTC/reservations/comments{/number}","issue_comment_url":"https://api.github.com/repos/YaleSTC/reservations/issues/comments/{number}","contents_url":"https://api.github.com/repos/YaleSTC/reservations/contents/{+path}","compare_url":"https://api.github.com/repos/YaleSTC/reservations/compare/{base}...{head}","merges_url":"https://api.github.com/repos/YaleSTC/reservations/merges","archive_url":"https://api.github.com/repos/YaleSTC/reservations/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/YaleSTC/reservations/downloads","issues_url":"https://api.github.com/repos/YaleSTC/reservations/issues{/number}","pulls_url":"https://api.github.com/repos/YaleSTC/reservations/pulls{/number}","milestones_url":"https://api.github.com/repos/YaleSTC/reservations/milestones{/number}","notifications_url":"https://api.github.com/repos/YaleSTC/reservations/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/YaleSTC/reservations/labels{/name}","releases_url":"https://api.github.com/repos/YaleSTC/reservations/releases{/id}","created_at":"2009-10-21T21:08:00Z","updated_at":"2014-07-08T19:06:34Z","pushed_at":"2014-07-10T04:49:20Z","git_url":"git://github.com/YaleSTC/reservations.git","ssh_url":"git@github.com:YaleSTC/reservations.git","clone_url":"https://github.com/YaleSTC/reservations.git","svn_url":"https://github.com/YaleSTC/reservations","homepage":"","size":54083,"stargazers_count":18,"watchers_count":18,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":5,"mirror_url":null,"open_issues_count":141,"forks":5,"open_issues":141,"watchers":18,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/YaleSTC/reservations/pulls/644"},"html":{"href":"https://github.com/YaleSTC/reservations/pull/644"},"issue":{"href":"https://api.github.com/repos/YaleSTC/reservations/issues/644"},"comments":{"href":"https://api.github.com/repos/YaleSTC/reservations/issues/644/comments"},"review_comments":{"href":"https://api.github.com/repos/YaleSTC/reservations/pulls/644/comments"},"review_comment":{"href":"https://api.github.com/repos/YaleSTC/reservations/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/YaleSTC/reservations/pulls/644/commits"},"statuses":{"href":"https://api.github.com/repos/YaleSTC/reservations/statuses/5a2bc1796b4e0de75187982f37eadad194256b38"}}}}