GitHub PullRequestReviewCommentEvent at 2014-02-02 10:09:18
Repository: scala
Actor: lrytz
Payload: {"comment":{"url":"https://api.github.com/repos/scala/scala/pulls/comments/9369191","id":9369191,"diff_hunk":"@@ -20,12 +20,18 @@ abstract class Flatten extends InfoTransform {\n   /** Updates the owning scope with the given symbol, unlinking any others.\n    */\n   private def replaceSymbolInCurrentScope(sym: Symbol): Unit = exitingFlatten {\n+    removeSymbolInCurrentScope(sym)\n+    sym.owner.info.decls enter sym\n+  }\n+\n+  private def removeSymbolInCurrentScope(sym: Symbol): Unit = exitingFlatten {\n     val scope = sym.owner.info.decls\n     val old   = (scope lookupUnshadowedEntries sym.name).toList\n-    old foreach (scope unlink _)\n-    scope enter sym\n+    old foreach {entry =>\n+      scope unlink entry\n+    }","path":"src/compiler/scala/tools/nsc/transform/Flatten.scala","position":15,"original_position":15,"commit_id":"eb1d52a99b7a5c7a0e849762ce02accc4a4ff22b","original_commit_id":"eb1d52a99b7a5c7a0e849762ce02accc4a4ff22b","user":{"login":"lrytz","id":119636,"avatar_url":"https://gravatar.com/avatar/d807dd5133a6fc14c821178e53c34091?d=https%3A%2F%2Fidenticons.github.com%2F8f159ea16ad0f36be77714fc8ab1dcae.png&r=x","gravatar_id":"d807dd5133a6fc14c821178e53c34091","url":"https://api.github.com/users/lrytz","html_url":"https://github.com/lrytz","followers_url":"https://api.github.com/users/lrytz/followers","following_url":"https://api.github.com/users/lrytz/following{/other_user}","gists_url":"https://api.github.com/users/lrytz/gists{/gist_id}","starred_url":"https://api.github.com/users/lrytz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lrytz/subscriptions","organizations_url":"https://api.github.com/users/lrytz/orgs","repos_url":"https://api.github.com/users/lrytz/repos","events_url":"https://api.github.com/users/lrytz/events{/privacy}","received_events_url":"https://api.github.com/users/lrytz/received_events","type":"User","site_admin":false},"body":"this diff seems to be the same as just deleting the second line (`scope enter sym`).","created_at":"2014-02-02T10:09:18Z","updated_at":"2014-02-02T10:09:18Z","html_url":"https://github.com/scala/scala/pull/3389#discussion_r9369191","pull_request_url":"https://api.github.com/repos/scala/scala/pulls/3389","_links":{"self":{"href":"https://api.github.com/repos/scala/scala/pulls/comments/9369191"},"html":{"href":"https://github.com/scala/scala/pull/3389#discussion_r9369191"},"pull_request":{"href":"https://api.github.com/repos/scala/scala/pulls/3389"}}}}