GitHub PullRequestReviewCommentEvent at 2014-05-01 21:36:26
Repository: Nancy
Actor: thecodejunkie
Payload: {"comment":{"url":"https://api.github.com/repos/NancyFx/Nancy/pulls/comments/12209122","id":12209122,"diff_hunk":"@@ -0,0 +1,63 @@\n+﻿namespace Nancy.Routing\r\n+{\r\n+    using System;\r\n+    using System.Collections.Generic;\r\n+    using System.Linq;\r\n+\r\n+    using Nancy.Bootstrapper;\r\n+    using Nancy.TinyIoc;\r\n+\r\n+    /// <summary>\r\n+    /// Wires up default <see cref=\"IMetadataModule\"/> instances by scanning the <see cref=\"AppDomain\"/>.\r\n+    /// </summary>\r\n+    public class DefaultMetadataModuleCatalog : IMetadataModuleCatalog\r","path":"src/Nancy/Routing/DefaultMetadataModuleCatalog.cs","position":13,"original_position":13,"commit_id":"f1ef695ee0dcbd78b2ba6df7b87f4c2d77fc45a7","original_commit_id":"f1ef695ee0dcbd78b2ba6df7b87f4c2d77fc45a7","user":{"login":"thecodejunkie","id":50543,"avatar_url":"https://avatars.githubusercontent.com/u/50543?","gravatar_id":"61f3187a94eb0411ef92b123d7a13584","url":"https://api.github.com/users/thecodejunkie","html_url":"https://github.com/thecodejunkie","followers_url":"https://api.github.com/users/thecodejunkie/followers","following_url":"https://api.github.com/users/thecodejunkie/following{/other_user}","gists_url":"https://api.github.com/users/thecodejunkie/gists{/gist_id}","starred_url":"https://api.github.com/users/thecodejunkie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thecodejunkie/subscriptions","organizations_url":"https://api.github.com/users/thecodejunkie/orgs","repos_url":"https://api.github.com/users/thecodejunkie/repos","events_url":"https://api.github.com/users/thecodejunkie/events{/privacy}","received_events_url":"https://api.github.com/users/thecodejunkie/received_events","type":"User","site_admin":false},"body":"Diagnostics is a bit special. It's an application, bundled inside Nancy, with no intent of people using (much) of the actual code to extend it. Can't we just use an [IRegistrations](https://github.com/NancyFx/Nancy/blob/master/src/Nancy/Bootstrapper/IRegistrations.cs) to find and register all implementations of `IMetadataModule` and then just take an `IEnumerable<IMetdataModule>` dependency where ever needed?","created_at":"2014-05-01T21:36:26Z","updated_at":"2014-05-01T21:36:26Z","html_url":"https://github.com/NancyFx/Nancy/pull/1519#discussion_r12209122","pull_request_url":"https://api.github.com/repos/NancyFx/Nancy/pulls/1519","_links":{"self":{"href":"https://api.github.com/repos/NancyFx/Nancy/pulls/comments/12209122"},"html":{"href":"https://github.com/NancyFx/Nancy/pull/1519#discussion_r12209122"},"pull_request":{"href":"https://api.github.com/repos/NancyFx/Nancy/pulls/1519"}}}}