GitHub PullRequestReviewCommentEvent at 2014-07-02 11:40:02
Repository: sorl-watermark
Actor: infinityxxx
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/originell/sorl-watermark/pulls/comments/14452160","id":14452160,"diff_hunk":"@@ -15,3 +15,6 @@\n # Watermark position on the initial image.\n # By default places the watermark in the right bottom corner.\n THUMBNAIL_WATERMARK_POSITION = 'south east'\n+\n+# Add watermark before applying padding\n+THUMBNAIL_WATERMARK_BEFORE_PADDING = True","path":"sorl_watermarker/conf/defaults.py","position":6,"original_position":6,"commit_id":"7cf3bf442fc7ccf2626cabacc92511c0ab699980","original_commit_id":"7cf3bf442fc7ccf2626cabacc92511c0ab699980","user":{"login":"infinityxxx","id":531263,"avatar_url":"https://avatars.githubusercontent.com/u/531263?","gravatar_id":"435f5665fc3138dc54fd1245e56e58d1","url":"https://api.github.com/users/infinityxxx","html_url":"https://github.com/infinityxxx","followers_url":"https://api.github.com/users/infinityxxx/followers","following_url":"https://api.github.com/users/infinityxxx/following{/other_user}","gists_url":"https://api.github.com/users/infinityxxx/gists{/gist_id}","starred_url":"https://api.github.com/users/infinityxxx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infinityxxx/subscriptions","organizations_url":"https://api.github.com/users/infinityxxx/orgs","repos_url":"https://api.github.com/users/infinityxxx/repos","events_url":"https://api.github.com/users/infinityxxx/events{/privacy}","received_events_url":"https://api.github.com/users/infinityxxx/received_events","type":"User","site_admin":false},"body":"can be False by default (for saving previous behaviour)","created_at":"2014-07-02T11:40:02Z","updated_at":"2014-07-02T11:40:02Z","html_url":"https://github.com/originell/sorl-watermark/pull/22#discussion_r14452160","pull_request_url":"https://api.github.com/repos/originell/sorl-watermark/pulls/22","_links":{"self":{"href":"https://api.github.com/repos/originell/sorl-watermark/pulls/comments/14452160"},"html":{"href":"https://github.com/originell/sorl-watermark/pull/22#discussion_r14452160"},"pull_request":{"href":"https://api.github.com/repos/originell/sorl-watermark/pulls/22"}}},"pull_request":{"url":"https://api.github.com/repos/originell/sorl-watermark/pulls/22","id":17749458,"html_url":"https://github.com/originell/sorl-watermark/pull/22","diff_url":"https://github.com/originell/sorl-watermark/pull/22.diff","patch_url":"https://github.com/originell/sorl-watermark/pull/22.patch","issue_url":"https://api.github.com/repos/originell/sorl-watermark/issues/22","number":22,"state":"open","title":"Better handling for padding","user":{"login":"infinityxxx","id":531263,"avatar_url":"https://avatars.githubusercontent.com/u/531263?","gravatar_id":"435f5665fc3138dc54fd1245e56e58d1","url":"https://api.github.com/users/infinityxxx","html_url":"https://github.com/infinityxxx","followers_url":"https://api.github.com/users/infinityxxx/followers","following_url":"https://api.github.com/users/infinityxxx/following{/other_user}","gists_url":"https://api.github.com/users/infinityxxx/gists{/gist_id}","starred_url":"https://api.github.com/users/infinityxxx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infinityxxx/subscriptions","organizations_url":"https://api.github.com/users/infinityxxx/orgs","repos_url":"https://api.github.com/users/infinityxxx/repos","events_url":"https://api.github.com/users/infinityxxx/events{/privacy}","received_events_url":"https://api.github.com/users/infinityxxx/received_events","type":"User","site_admin":false},"body":"Add feature for handling ``padding``: ability to apply watermark before sorl-thumbnail adds padding to image.","created_at":"2014-06-29T18:40:46Z","updated_at":"2014-07-02T11:40:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"894f815f408f9a1e5f731733889bf76133706f68","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/originell/sorl-watermark/pulls/22/commits","review_comments_url":"https://api.github.com/repos/originell/sorl-watermark/pulls/22/comments","review_comment_url":"https://api.github.com/repos/originell/sorl-watermark/pulls/comments/{number}","comments_url":"https://api.github.com/repos/originell/sorl-watermark/issues/22/comments","statuses_url":"https://api.github.com/repos/originell/sorl-watermark/statuses/7cf3bf442fc7ccf2626cabacc92511c0ab699980","head":{"label":"infinityxxx:master","ref":"master","sha":"7cf3bf442fc7ccf2626cabacc92511c0ab699980","user":{"login":"infinityxxx","id":531263,"avatar_url":"https://avatars.githubusercontent.com/u/531263?","gravatar_id":"435f5665fc3138dc54fd1245e56e58d1","url":"https://api.github.com/users/infinityxxx","html_url":"https://github.com/infinityxxx","followers_url":"https://api.github.com/users/infinityxxx/followers","following_url":"https://api.github.com/users/infinityxxx/following{/other_user}","gists_url":"https://api.github.com/users/infinityxxx/gists{/gist_id}","starred_url":"https://api.github.com/users/infinityxxx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infinityxxx/subscriptions","organizations_url":"https://api.github.com/users/infinityxxx/orgs","repos_url":"https://api.github.com/users/infinityxxx/repos","events_url":"https://api.github.com/users/infinityxxx/events{/privacy}","received_events_url":"https://api.github.com/users/infinityxxx/received_events","type":"User","site_admin":false},"repo":{"id":19095378,"name":"sorl-watermark","full_name":"infinityxxx/sorl-watermark","owner":{"login":"infinityxxx","id":531263,"avatar_url":"https://avatars.githubusercontent.com/u/531263?","gravatar_id":"435f5665fc3138dc54fd1245e56e58d1","url":"https://api.github.com/users/infinityxxx","html_url":"https://github.com/infinityxxx","followers_url":"https://api.github.com/users/infinityxxx/followers","following_url":"https://api.github.com/users/infinityxxx/following{/other_user}","gists_url":"https://api.github.com/users/infinityxxx/gists{/gist_id}","starred_url":"https://api.github.com/users/infinityxxx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infinityxxx/subscriptions","organizations_url":"https://api.github.com/users/infinityxxx/orgs","repos_url":"https://api.github.com/users/infinityxxx/repos","events_url":"https://api.github.com/users/infinityxxx/events{/privacy}","received_events_url":"https://api.github.com/users/infinityxxx/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/infinityxxx/sorl-watermark","description":"Image based watermarks for sorl-thumbnail (with ability to apply padding AFTER watermark added)","fork":true,"url":"https://api.github.com/repos/infinityxxx/sorl-watermark","forks_url":"https://api.github.com/repos/infinityxxx/sorl-watermark/forks","keys_url":"https://api.github.com/repos/infinityxxx/sorl-watermark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/infinityxxx/sorl-watermark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/infinityxxx/sorl-watermark/teams","hooks_url":"https://api.github.com/repos/infinityxxx/sorl-watermark/hooks","issue_events_url":"https://api.github.com/repos/infinityxxx/sorl-watermark/issues/events{/number}","events_url":"https://api.github.com/repos/infinityxxx/sorl-watermark/events","assignees_url":"https://api.github.com/repos/infinityxxx/sorl-watermark/assignees{/user}","branches_url":"https://api.github.com/repos/infinityxxx/sorl-watermark/branches{/branch}","tags_url":"https://api.github.com/repos/infinityxxx/sorl-watermark/tags","blobs_url":"https://api.github.com/repos/infinityxxx/sorl-watermark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/infinityxxx/sorl-watermark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/infinityxxx/sorl-watermark/git/refs{/sha}","trees_url":"https://api.github.com/repos/infinityxxx/sorl-watermark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/infinityxxx/sorl-watermark/statuses/{sha}","languages_url":"https://api.github.com/repos/infinityxxx/sorl-watermark/languages","stargazers_url":"https://api.github.com/repos/infinityxxx/sorl-watermark/stargazers","contributors_url":"https://api.github.com/repos/infinityxxx/sorl-watermark/contributors","subscribers_url":"https://api.github.com/repos/infinityxxx/sorl-watermark/subscribers","subscription_url":"https://api.github.com/repos/infinityxxx/sorl-watermark/subscription","commits_url":"https://api.github.com/repos/infinityxxx/sorl-watermark/commits{/sha}","git_commits_url":"https://api.github.com/repos/infinityxxx/sorl-watermark/git/commits{/sha}","comments_url":"https://api.github.com/repos/infinityxxx/sorl-watermark/comments{/number}","issue_comment_url":"https://api.github.com/repos/infinityxxx/sorl-watermark/issues/comments/{number}","contents_url":"https://api.github.com/repos/infinityxxx/sorl-watermark/contents/{+path}","compare_url":"https://api.github.com/repos/infinityxxx/sorl-watermark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/infinityxxx/sorl-watermark/merges","archive_url":"https://api.github.com/repos/infinityxxx/sorl-watermark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/infinityxxx/sorl-watermark/downloads","issues_url":"https://api.github.com/repos/infinityxxx/sorl-watermark/issues{/number}","pulls_url":"https://api.github.com/repos/infinityxxx/sorl-watermark/pulls{/number}","milestones_url":"https://api.github.com/repos/infinityxxx/sorl-watermark/milestones{/number}","notifications_url":"https://api.github.com/repos/infinityxxx/sorl-watermark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/infinityxxx/sorl-watermark/labels{/name}","releases_url":"https://api.github.com/repos/infinityxxx/sorl-watermark/releases{/id}","created_at":"2014-04-24T04:11:19Z","updated_at":"2014-06-29T19:05:42Z","pushed_at":"2014-06-29T19:00:25Z","git_url":"git://github.com/infinityxxx/sorl-watermark.git","ssh_url":"git@github.com:infinityxxx/sorl-watermark.git","clone_url":"https://github.com/infinityxxx/sorl-watermark.git","svn_url":"https://github.com/infinityxxx/sorl-watermark","homepage":"","size":210,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"originell:master","ref":"master","sha":"e18a8b4f39c4cd6ad176af77d0ddf0c2968220ce","user":{"login":"originell","id":23529,"avatar_url":"https://avatars.githubusercontent.com/u/23529?","gravatar_id":"b7aaf37de0dd4c9384d15a61995f6b27","url":"https://api.github.com/users/originell","html_url":"https://github.com/originell","followers_url":"https://api.github.com/users/originell/followers","following_url":"https://api.github.com/users/originell/following{/other_user}","gists_url":"https://api.github.com/users/originell/gists{/gist_id}","starred_url":"https://api.github.com/users/originell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/originell/subscriptions","organizations_url":"https://api.github.com/users/originell/orgs","repos_url":"https://api.github.com/users/originell/repos","events_url":"https://api.github.com/users/originell/events{/privacy}","received_events_url":"https://api.github.com/users/originell/received_events","type":"User","site_admin":false},"repo":{"id":2128576,"name":"sorl-watermark","full_name":"originell/sorl-watermark","owner":{"login":"originell","id":23529,"avatar_url":"https://avatars.githubusercontent.com/u/23529?","gravatar_id":"b7aaf37de0dd4c9384d15a61995f6b27","url":"https://api.github.com/users/originell","html_url":"https://github.com/originell","followers_url":"https://api.github.com/users/originell/followers","following_url":"https://api.github.com/users/originell/following{/other_user}","gists_url":"https://api.github.com/users/originell/gists{/gist_id}","starred_url":"https://api.github.com/users/originell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/originell/subscriptions","organizations_url":"https://api.github.com/users/originell/orgs","repos_url":"https://api.github.com/users/originell/repos","events_url":"https://api.github.com/users/originell/events{/privacy}","received_events_url":"https://api.github.com/users/originell/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/originell/sorl-watermark","description":"Image based watermarks for sorl-thumbnail","fork":false,"url":"https://api.github.com/repos/originell/sorl-watermark","forks_url":"https://api.github.com/repos/originell/sorl-watermark/forks","keys_url":"https://api.github.com/repos/originell/sorl-watermark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/originell/sorl-watermark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/originell/sorl-watermark/teams","hooks_url":"https://api.github.com/repos/originell/sorl-watermark/hooks","issue_events_url":"https://api.github.com/repos/originell/sorl-watermark/issues/events{/number}","events_url":"https://api.github.com/repos/originell/sorl-watermark/events","assignees_url":"https://api.github.com/repos/originell/sorl-watermark/assignees{/user}","branches_url":"https://api.github.com/repos/originell/sorl-watermark/branches{/branch}","tags_url":"https://api.github.com/repos/originell/sorl-watermark/tags","blobs_url":"https://api.github.com/repos/originell/sorl-watermark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/originell/sorl-watermark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/originell/sorl-watermark/git/refs{/sha}","trees_url":"https://api.github.com/repos/originell/sorl-watermark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/originell/sorl-watermark/statuses/{sha}","languages_url":"https://api.github.com/repos/originell/sorl-watermark/languages","stargazers_url":"https://api.github.com/repos/originell/sorl-watermark/stargazers","contributors_url":"https://api.github.com/repos/originell/sorl-watermark/contributors","subscribers_url":"https://api.github.com/repos/originell/sorl-watermark/subscribers","subscription_url":"https://api.github.com/repos/originell/sorl-watermark/subscription","commits_url":"https://api.github.com/repos/originell/sorl-watermark/commits{/sha}","git_commits_url":"https://api.github.com/repos/originell/sorl-watermark/git/commits{/sha}","comments_url":"https://api.github.com/repos/originell/sorl-watermark/comments{/number}","issue_comment_url":"https://api.github.com/repos/originell/sorl-watermark/issues/comments/{number}","contents_url":"https://api.github.com/repos/originell/sorl-watermark/contents/{+path}","compare_url":"https://api.github.com/repos/originell/sorl-watermark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/originell/sorl-watermark/merges","archive_url":"https://api.github.com/repos/originell/sorl-watermark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/originell/sorl-watermark/downloads","issues_url":"https://api.github.com/repos/originell/sorl-watermark/issues{/number}","pulls_url":"https://api.github.com/repos/originell/sorl-watermark/pulls{/number}","milestones_url":"https://api.github.com/repos/originell/sorl-watermark/milestones{/number}","notifications_url":"https://api.github.com/repos/originell/sorl-watermark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/originell/sorl-watermark/labels{/name}","releases_url":"https://api.github.com/repos/originell/sorl-watermark/releases{/id}","created_at":"2011-07-30T12:26:32Z","updated_at":"2014-06-29T18:51:39Z","pushed_at":"2014-06-16T14:43:08Z","git_url":"git://github.com/originell/sorl-watermark.git","ssh_url":"git@github.com:originell/sorl-watermark.git","clone_url":"https://github.com/originell/sorl-watermark.git","svn_url":"https://github.com/originell/sorl-watermark","homepage":"","size":367,"stargazers_count":16,"watchers_count":16,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":12,"mirror_url":null,"open_issues_count":8,"forks":12,"open_issues":8,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/originell/sorl-watermark/pulls/22"},"html":{"href":"https://github.com/originell/sorl-watermark/pull/22"},"issue":{"href":"https://api.github.com/repos/originell/sorl-watermark/issues/22"},"comments":{"href":"https://api.github.com/repos/originell/sorl-watermark/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/originell/sorl-watermark/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/originell/sorl-watermark/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/originell/sorl-watermark/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/originell/sorl-watermark/statuses/7cf3bf442fc7ccf2626cabacc92511c0ab699980"}}}}