GitHub PullRequestEvent at 2014-09-30 02:08:41
Repository: nxfa2
Actor: fatiherikli
Payload: {"action":"opened","number":1,"pull_request":{"url":"https://api.github.com/repos/tpoisot/nxfa2/pulls/1","id":21977614,"html_url":"https://github.com/tpoisot/nxfa2/pull/1","diff_url":"https://github.com/tpoisot/nxfa2/pull/1.diff","patch_url":"https://github.com/tpoisot/nxfa2/pull/1.patch","issue_url":"https://api.github.com/repos/tpoisot/nxfa2/issues/1","number":1,"state":"open","locked":false,"title":"Cleanup","user":{"login":"fatiherikli","id":1220743,"avatar_url":"https://avatars.githubusercontent.com/u/1220743?v=2","gravatar_id":"","url":"https://api.github.com/users/fatiherikli","html_url":"https://github.com/fatiherikli","followers_url":"https://api.github.com/users/fatiherikli/followers","following_url":"https://api.github.com/users/fatiherikli/following{/other_user}","gists_url":"https://api.github.com/users/fatiherikli/gists{/gist_id}","starred_url":"https://api.github.com/users/fatiherikli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fatiherikli/subscriptions","organizations_url":"https://api.github.com/users/fatiherikli/orgs","repos_url":"https://api.github.com/users/fatiherikli/repos","events_url":"https://api.github.com/users/fatiherikli/events{/privacy}","received_events_url":"https://api.github.com/users/fatiherikli/received_events","type":"User","site_admin":false},"body":"Hey, thanks for your awesome implementation. \r\n\r\nI made some changes:\r\n- I added __main__ check to behave like a python module.\r\n- I removed eyclidean distance function. It was unused and you're already doing this in 60. and 74. lines.\r\n- I fixed this where condition `0.01, 0.1, length` with `0.01, 0.01, length`. Isn't that right?","created_at":"2014-09-30T02:08:41Z","updated_at":"2014-09-30T02:08:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/tpoisot/nxfa2/pulls/1/commits","review_comments_url":"https://api.github.com/repos/tpoisot/nxfa2/pulls/1/comments","review_comment_url":"https://api.github.com/repos/tpoisot/nxfa2/pulls/comments/{number}","comments_url":"https://api.github.com/repos/tpoisot/nxfa2/issues/1/comments","statuses_url":"https://api.github.com/repos/tpoisot/nxfa2/statuses/524890b799319da6caf344d9fe6c0e0fc3103fdd","head":{"label":"fatiherikli:master","ref":"master","sha":"524890b799319da6caf344d9fe6c0e0fc3103fdd","user":{"login":"fatiherikli","id":1220743,"avatar_url":"https://avatars.githubusercontent.com/u/1220743?v=2","gravatar_id":"","url":"https://api.github.com/users/fatiherikli","html_url":"https://github.com/fatiherikli","followers_url":"https://api.github.com/users/fatiherikli/followers","following_url":"https://api.github.com/users/fatiherikli/following{/other_user}","gists_url":"https://api.github.com/users/fatiherikli/gists{/gist_id}","starred_url":"https://api.github.com/users/fatiherikli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fatiherikli/subscriptions","organizations_url":"https://api.github.com/users/fatiherikli/orgs","repos_url":"https://api.github.com/users/fatiherikli/repos","events_url":"https://api.github.com/users/fatiherikli/events{/privacy}","received_events_url":"https://api.github.com/users/fatiherikli/received_events","type":"User","site_admin":false},"repo":{"id":24620360,"name":"nxfa2","full_name":"fatiherikli/nxfa2","owner":{"login":"fatiherikli","id":1220743,"avatar_url":"https://avatars.githubusercontent.com/u/1220743?v=2","gravatar_id":"","url":"https://api.github.com/users/fatiherikli","html_url":"https://github.com/fatiherikli","followers_url":"https://api.github.com/users/fatiherikli/followers","following_url":"https://api.github.com/users/fatiherikli/following{/other_user}","gists_url":"https://api.github.com/users/fatiherikli/gists{/gist_id}","starred_url":"https://api.github.com/users/fatiherikli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fatiherikli/subscriptions","organizations_url":"https://api.github.com/users/fatiherikli/orgs","repos_url":"https://api.github.com/users/fatiherikli/repos","events_url":"https://api.github.com/users/fatiherikli/events{/privacy}","received_events_url":"https://api.github.com/users/fatiherikli/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fatiherikli/nxfa2","description":"Force-Atlas 2 graph layout in networkx","fork":true,"url":"https://api.github.com/repos/fatiherikli/nxfa2","forks_url":"https://api.github.com/repos/fatiherikli/nxfa2/forks","keys_url":"https://api.github.com/repos/fatiherikli/nxfa2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fatiherikli/nxfa2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fatiherikli/nxfa2/teams","hooks_url":"https://api.github.com/repos/fatiherikli/nxfa2/hooks","issue_events_url":"https://api.github.com/repos/fatiherikli/nxfa2/issues/events{/number}","events_url":"https://api.github.com/repos/fatiherikli/nxfa2/events","assignees_url":"https://api.github.com/repos/fatiherikli/nxfa2/assignees{/user}","branches_url":"https://api.github.com/repos/fatiherikli/nxfa2/branches{/branch}","tags_url":"https://api.github.com/repos/fatiherikli/nxfa2/tags","blobs_url":"https://api.github.com/repos/fatiherikli/nxfa2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fatiherikli/nxfa2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fatiherikli/nxfa2/git/refs{/sha}","trees_url":"https://api.github.com/repos/fatiherikli/nxfa2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fatiherikli/nxfa2/statuses/{sha}","languages_url":"https://api.github.com/repos/fatiherikli/nxfa2/languages","stargazers_url":"https://api.github.com/repos/fatiherikli/nxfa2/stargazers","contributors_url":"https://api.github.com/repos/fatiherikli/nxfa2/contributors","subscribers_url":"https://api.github.com/repos/fatiherikli/nxfa2/subscribers","subscription_url":"https://api.github.com/repos/fatiherikli/nxfa2/subscription","commits_url":"https://api.github.com/repos/fatiherikli/nxfa2/commits{/sha}","git_commits_url":"https://api.github.com/repos/fatiherikli/nxfa2/git/commits{/sha}","comments_url":"https://api.github.com/repos/fatiherikli/nxfa2/comments{/number}","issue_comment_url":"https://api.github.com/repos/fatiherikli/nxfa2/issues/comments/{number}","contents_url":"https://api.github.com/repos/fatiherikli/nxfa2/contents/{+path}","compare_url":"https://api.github.com/repos/fatiherikli/nxfa2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fatiherikli/nxfa2/merges","archive_url":"https://api.github.com/repos/fatiherikli/nxfa2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fatiherikli/nxfa2/downloads","issues_url":"https://api.github.com/repos/fatiherikli/nxfa2/issues{/number}","pulls_url":"https://api.github.com/repos/fatiherikli/nxfa2/pulls{/number}","milestones_url":"https://api.github.com/repos/fatiherikli/nxfa2/milestones{/number}","notifications_url":"https://api.github.com/repos/fatiherikli/nxfa2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fatiherikli/nxfa2/labels{/name}","releases_url":"https://api.github.com/repos/fatiherikli/nxfa2/releases{/id}","created_at":"2014-09-30T01:53:29Z","updated_at":"2014-09-30T01:53:56Z","pushed_at":"2014-09-30T01:53:56Z","git_url":"git://github.com/fatiherikli/nxfa2.git","ssh_url":"git@github.com:fatiherikli/nxfa2.git","clone_url":"https://github.com/fatiherikli/nxfa2.git","svn_url":"https://github.com/fatiherikli/nxfa2","homepage":null,"size":103,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tpoisot:master","ref":"master","sha":"a0968b962eb987c53c543c4d4901d9a06d433a12","user":{"login":"tpoisot","id":579329,"avatar_url":"https://avatars.githubusercontent.com/u/579329?v=2","gravatar_id":"","url":"https://api.github.com/users/tpoisot","html_url":"https://github.com/tpoisot","followers_url":"https://api.github.com/users/tpoisot/followers","following_url":"https://api.github.com/users/tpoisot/following{/other_user}","gists_url":"https://api.github.com/users/tpoisot/gists{/gist_id}","starred_url":"https://api.github.com/users/tpoisot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tpoisot/subscriptions","organizations_url":"https://api.github.com/users/tpoisot/orgs","repos_url":"https://api.github.com/users/tpoisot/repos","events_url":"https://api.github.com/users/tpoisot/events{/privacy}","received_events_url":"https://api.github.com/users/tpoisot/received_events","type":"User","site_admin":false},"repo":{"id":8112431,"name":"nxfa2","full_name":"tpoisot/nxfa2","owner":{"login":"tpoisot","id":579329,"avatar_url":"https://avatars.githubusercontent.com/u/579329?v=2","gravatar_id":"","url":"https://api.github.com/users/tpoisot","html_url":"https://github.com/tpoisot","followers_url":"https://api.github.com/users/tpoisot/followers","following_url":"https://api.github.com/users/tpoisot/following{/other_user}","gists_url":"https://api.github.com/users/tpoisot/gists{/gist_id}","starred_url":"https://api.github.com/users/tpoisot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tpoisot/subscriptions","organizations_url":"https://api.github.com/users/tpoisot/orgs","repos_url":"https://api.github.com/users/tpoisot/repos","events_url":"https://api.github.com/users/tpoisot/events{/privacy}","received_events_url":"https://api.github.com/users/tpoisot/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tpoisot/nxfa2","description":"Force-Atlas 2 graph layout in networkx","fork":false,"url":"https://api.github.com/repos/tpoisot/nxfa2","forks_url":"https://api.github.com/repos/tpoisot/nxfa2/forks","keys_url":"https://api.github.com/repos/tpoisot/nxfa2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tpoisot/nxfa2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tpoisot/nxfa2/teams","hooks_url":"https://api.github.com/repos/tpoisot/nxfa2/hooks","issue_events_url":"https://api.github.com/repos/tpoisot/nxfa2/issues/events{/number}","events_url":"https://api.github.com/repos/tpoisot/nxfa2/events","assignees_url":"https://api.github.com/repos/tpoisot/nxfa2/assignees{/user}","branches_url":"https://api.github.com/repos/tpoisot/nxfa2/branches{/branch}","tags_url":"https://api.github.com/repos/tpoisot/nxfa2/tags","blobs_url":"https://api.github.com/repos/tpoisot/nxfa2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tpoisot/nxfa2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tpoisot/nxfa2/git/refs{/sha}","trees_url":"https://api.github.com/repos/tpoisot/nxfa2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tpoisot/nxfa2/statuses/{sha}","languages_url":"https://api.github.com/repos/tpoisot/nxfa2/languages","stargazers_url":"https://api.github.com/repos/tpoisot/nxfa2/stargazers","contributors_url":"https://api.github.com/repos/tpoisot/nxfa2/contributors","subscribers_url":"https://api.github.com/repos/tpoisot/nxfa2/subscribers","subscription_url":"https://api.github.com/repos/tpoisot/nxfa2/subscription","commits_url":"https://api.github.com/repos/tpoisot/nxfa2/commits{/sha}","git_commits_url":"https://api.github.com/repos/tpoisot/nxfa2/git/commits{/sha}","comments_url":"https://api.github.com/repos/tpoisot/nxfa2/comments{/number}","issue_comment_url":"https://api.github.com/repos/tpoisot/nxfa2/issues/comments/{number}","contents_url":"https://api.github.com/repos/tpoisot/nxfa2/contents/{+path}","compare_url":"https://api.github.com/repos/tpoisot/nxfa2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tpoisot/nxfa2/merges","archive_url":"https://api.github.com/repos/tpoisot/nxfa2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tpoisot/nxfa2/downloads","issues_url":"https://api.github.com/repos/tpoisot/nxfa2/issues{/number}","pulls_url":"https://api.github.com/repos/tpoisot/nxfa2/pulls{/number}","milestones_url":"https://api.github.com/repos/tpoisot/nxfa2/milestones{/number}","notifications_url":"https://api.github.com/repos/tpoisot/nxfa2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tpoisot/nxfa2/labels{/name}","releases_url":"https://api.github.com/repos/tpoisot/nxfa2/releases{/id}","created_at":"2013-02-09T17:37:34Z","updated_at":"2014-09-29T19:04:41Z","pushed_at":"2013-02-09T19:31:54Z","git_url":"git://github.com/tpoisot/nxfa2.git","ssh_url":"git@github.com:tpoisot/nxfa2.git","clone_url":"https://github.com/tpoisot/nxfa2.git","svn_url":"https://github.com/tpoisot/nxfa2","homepage":null,"size":120,"stargazers_count":5,"watchers_count":5,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":1,"forks":3,"open_issues":1,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tpoisot/nxfa2/pulls/1"},"html":{"href":"https://github.com/tpoisot/nxfa2/pull/1"},"issue":{"href":"https://api.github.com/repos/tpoisot/nxfa2/issues/1"},"comments":{"href":"https://api.github.com/repos/tpoisot/nxfa2/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/tpoisot/nxfa2/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/tpoisot/nxfa2/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/tpoisot/nxfa2/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/tpoisot/nxfa2/statuses/524890b799319da6caf344d9fe6c0e0fc3103fdd"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":6,"additions":44,"deletions":50,"changed_files":1}}