GitHub PullRequestReviewCommentEvent at 2014-12-10 00:09:51
Repository: cockroach
Actor: jamesgraves
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments/21574725","id":21574725,"diff_hunk":"@@ -23,6 +23,24 @@ mkdir -p \"${USR}\" \"${TMP}\" \"${LIB}\" \"${INCLUDE}\" \"${ROCKSDB}\"\n make clean || true\n (cd _vendor/rocksdb && make clean) || true\n \n+# Download and verify a file.\n+# ${1} is the URL\n+# ${2} is the expected md5sum\n+function download_verify()\n+{\n+    curl -LOs ${1}\n+    filename=`echo ${1} | sed 's/.*\\///'`\n+    if [ -f ${filename} ]; then\n+        dl_md5sum=`md5sum ${filename} | cut -c-32`","path":"build/devbase/vendor.sh","position":null,"original_position":12,"commit_id":"4f5eacb0dd7511b475bda9954c7ec94e2e50e177","original_commit_id":"d034c7160335e8b4e3574742b102bfb8930b4f7c","user":{"login":"jamesgraves","id":665082,"avatar_url":"https://avatars.githubusercontent.com/u/665082?v=3","gravatar_id":"","url":"https://api.github.com/users/jamesgraves","html_url":"https://github.com/jamesgraves","followers_url":"https://api.github.com/users/jamesgraves/followers","following_url":"https://api.github.com/users/jamesgraves/following{/other_user}","gists_url":"https://api.github.com/users/jamesgraves/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesgraves/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesgraves/subscriptions","organizations_url":"https://api.github.com/users/jamesgraves/orgs","repos_url":"https://api.github.com/users/jamesgraves/repos","events_url":"https://api.github.com/users/jamesgraves/events{/privacy}","received_events_url":"https://api.github.com/users/jamesgraves/received_events","type":"User","site_admin":false},"body":"The original authors of the libraries publish md5 sums on their download pages, so that's why it was chosen.","created_at":"2014-12-10T00:09:51Z","updated_at":"2014-12-10T00:09:51Z","html_url":"https://github.com/cockroachdb/cockroach/pull/206#discussion_r21574725","pull_request_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/206","_links":{"self":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments/21574725"},"html":{"href":"https://github.com/cockroachdb/cockroach/pull/206#discussion_r21574725"},"pull_request":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/206"}}},"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/206","id":25785104,"html_url":"https://github.com/cockroachdb/cockroach/pull/206","diff_url":"https://github.com/cockroachdb/cockroach/pull/206.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/206.patch","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/206","number":206,"state":"open","locked":false,"title":"Verify bzip2 and zlib downloads.","user":{"login":"jamesgraves","id":665082,"avatar_url":"https://avatars.githubusercontent.com/u/665082?v=3","gravatar_id":"","url":"https://api.github.com/users/jamesgraves","html_url":"https://github.com/jamesgraves","followers_url":"https://api.github.com/users/jamesgraves/followers","following_url":"https://api.github.com/users/jamesgraves/following{/other_user}","gists_url":"https://api.github.com/users/jamesgraves/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesgraves/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesgraves/subscriptions","organizations_url":"https://api.github.com/users/jamesgraves/orgs","repos_url":"https://api.github.com/users/jamesgraves/repos","events_url":"https://api.github.com/users/jamesgraves/events{/privacy}","received_events_url":"https://api.github.com/users/jamesgraves/received_events","type":"User","site_admin":false},"body":"The bzip2 and zlib authors don't provide https links to download\r\nreleases.  However, they do provide md5sums for the releases\r\non their webpages.","created_at":"2014-12-09T23:02:39Z","updated_at":"2014-12-10T00:09:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a0d1a0cbd418809f02946f18430f3279ec8811e8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/206/commits","review_comments_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/206/comments","review_comment_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments/{number}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/206/comments","statuses_url":"https://api.github.com/repos/cockroachdb/cockroach/statuses/4f5eacb0dd7511b475bda9954c7ec94e2e50e177","head":{"label":"jamesgraves:verify_downloads","ref":"verify_downloads","sha":"4f5eacb0dd7511b475bda9954c7ec94e2e50e177","user":{"login":"jamesgraves","id":665082,"avatar_url":"https://avatars.githubusercontent.com/u/665082?v=3","gravatar_id":"","url":"https://api.github.com/users/jamesgraves","html_url":"https://github.com/jamesgraves","followers_url":"https://api.github.com/users/jamesgraves/followers","following_url":"https://api.github.com/users/jamesgraves/following{/other_user}","gists_url":"https://api.github.com/users/jamesgraves/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesgraves/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesgraves/subscriptions","organizations_url":"https://api.github.com/users/jamesgraves/orgs","repos_url":"https://api.github.com/users/jamesgraves/repos","events_url":"https://api.github.com/users/jamesgraves/events{/privacy}","received_events_url":"https://api.github.com/users/jamesgraves/received_events","type":"User","site_admin":false},"repo":{"id":26295548,"name":"cockroach","full_name":"jamesgraves/cockroach","owner":{"login":"jamesgraves","id":665082,"avatar_url":"https://avatars.githubusercontent.com/u/665082?v=3","gravatar_id":"","url":"https://api.github.com/users/jamesgraves","html_url":"https://github.com/jamesgraves","followers_url":"https://api.github.com/users/jamesgraves/followers","following_url":"https://api.github.com/users/jamesgraves/following{/other_user}","gists_url":"https://api.github.com/users/jamesgraves/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesgraves/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesgraves/subscriptions","organizations_url":"https://api.github.com/users/jamesgraves/orgs","repos_url":"https://api.github.com/users/jamesgraves/repos","events_url":"https://api.github.com/users/jamesgraves/events{/privacy}","received_events_url":"https://api.github.com/users/jamesgraves/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jamesgraves/cockroach","description":"A Scalable, Geo-Replicated, Transactional Datastore","fork":true,"url":"https://api.github.com/repos/jamesgraves/cockroach","forks_url":"https://api.github.com/repos/jamesgraves/cockroach/forks","keys_url":"https://api.github.com/repos/jamesgraves/cockroach/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jamesgraves/cockroach/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jamesgraves/cockroach/teams","hooks_url":"https://api.github.com/repos/jamesgraves/cockroach/hooks","issue_events_url":"https://api.github.com/repos/jamesgraves/cockroach/issues/events{/number}","events_url":"https://api.github.com/repos/jamesgraves/cockroach/events","assignees_url":"https://api.github.com/repos/jamesgraves/cockroach/assignees{/user}","branches_url":"https://api.github.com/repos/jamesgraves/cockroach/branches{/branch}","tags_url":"https://api.github.com/repos/jamesgraves/cockroach/tags","blobs_url":"https://api.github.com/repos/jamesgraves/cockroach/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jamesgraves/cockroach/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jamesgraves/cockroach/git/refs{/sha}","trees_url":"https://api.github.com/repos/jamesgraves/cockroach/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jamesgraves/cockroach/statuses/{sha}","languages_url":"https://api.github.com/repos/jamesgraves/cockroach/languages","stargazers_url":"https://api.github.com/repos/jamesgraves/cockroach/stargazers","contributors_url":"https://api.github.com/repos/jamesgraves/cockroach/contributors","subscribers_url":"https://api.github.com/repos/jamesgraves/cockroach/subscribers","subscription_url":"https://api.github.com/repos/jamesgraves/cockroach/subscription","commits_url":"https://api.github.com/repos/jamesgraves/cockroach/commits{/sha}","git_commits_url":"https://api.github.com/repos/jamesgraves/cockroach/git/commits{/sha}","comments_url":"https://api.github.com/repos/jamesgraves/cockroach/comments{/number}","issue_comment_url":"https://api.github.com/repos/jamesgraves/cockroach/issues/comments/{number}","contents_url":"https://api.github.com/repos/jamesgraves/cockroach/contents/{+path}","compare_url":"https://api.github.com/repos/jamesgraves/cockroach/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jamesgraves/cockroach/merges","archive_url":"https://api.github.com/repos/jamesgraves/cockroach/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jamesgraves/cockroach/downloads","issues_url":"https://api.github.com/repos/jamesgraves/cockroach/issues{/number}","pulls_url":"https://api.github.com/repos/jamesgraves/cockroach/pulls{/number}","milestones_url":"https://api.github.com/repos/jamesgraves/cockroach/milestones{/number}","notifications_url":"https://api.github.com/repos/jamesgraves/cockroach/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jamesgraves/cockroach/labels{/name}","releases_url":"https://api.github.com/repos/jamesgraves/cockroach/releases{/id}","created_at":"2014-11-06T23:50:19Z","updated_at":"2014-12-09T22:40:14Z","pushed_at":"2014-12-10T00:08:24Z","git_url":"git://github.com/jamesgraves/cockroach.git","ssh_url":"git@github.com:jamesgraves/cockroach.git","clone_url":"https://github.com/jamesgraves/cockroach.git","svn_url":"https://github.com/jamesgraves/cockroach","homepage":null,"size":8299,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cockroachdb:master","ref":"master","sha":"3866f803f319b6898d34765e074a6f0d90266205","user":{"login":"cockroachdb","id":6748139,"avatar_url":"https://avatars.githubusercontent.com/u/6748139?v=3","gravatar_id":"","url":"https://api.github.com/users/cockroachdb","html_url":"https://github.com/cockroachdb","followers_url":"https://api.github.com/users/cockroachdb/followers","following_url":"https://api.github.com/users/cockroachdb/following{/other_user}","gists_url":"https://api.github.com/users/cockroachdb/gists{/gist_id}","starred_url":"https://api.github.com/users/cockroachdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockroachdb/subscriptions","organizations_url":"https://api.github.com/users/cockroachdb/orgs","repos_url":"https://api.github.com/users/cockroachdb/repos","events_url":"https://api.github.com/users/cockroachdb/events{/privacy}","received_events_url":"https://api.github.com/users/cockroachdb/received_events","type":"Organization","site_admin":false},"repo":{"id":16563587,"name":"cockroach","full_name":"cockroachdb/cockroach","owner":{"login":"cockroachdb","id":6748139,"avatar_url":"https://avatars.githubusercontent.com/u/6748139?v=3","gravatar_id":"","url":"https://api.github.com/users/cockroachdb","html_url":"https://github.com/cockroachdb","followers_url":"https://api.github.com/users/cockroachdb/followers","following_url":"https://api.github.com/users/cockroachdb/following{/other_user}","gists_url":"https://api.github.com/users/cockroachdb/gists{/gist_id}","starred_url":"https://api.github.com/users/cockroachdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockroachdb/subscriptions","organizations_url":"https://api.github.com/users/cockroachdb/orgs","repos_url":"https://api.github.com/users/cockroachdb/repos","events_url":"https://api.github.com/users/cockroachdb/events{/privacy}","received_events_url":"https://api.github.com/users/cockroachdb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cockroachdb/cockroach","description":"A Scalable, Geo-Replicated, Transactional Datastore","fork":false,"url":"https://api.github.com/repos/cockroachdb/cockroach","forks_url":"https://api.github.com/repos/cockroachdb/cockroach/forks","keys_url":"https://api.github.com/repos/cockroachdb/cockroach/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cockroachdb/cockroach/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cockroachdb/cockroach/teams","hooks_url":"https://api.github.com/repos/cockroachdb/cockroach/hooks","issue_events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/events{/number}","events_url":"https://api.github.com/repos/cockroachdb/cockroach/events","assignees_url":"https://api.github.com/repos/cockroachdb/cockroach/assignees{/user}","branches_url":"https://api.github.com/repos/cockroachdb/cockroach/branches{/branch}","tags_url":"https://api.github.com/repos/cockroachdb/cockroach/tags","blobs_url":"https://api.github.com/repos/cockroachdb/cockroach/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cockroachdb/cockroach/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cockroachdb/cockroach/git/refs{/sha}","trees_url":"https://api.github.com/repos/cockroachdb/cockroach/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cockroachdb/cockroach/statuses/{sha}","languages_url":"https://api.github.com/repos/cockroachdb/cockroach/languages","stargazers_url":"https://api.github.com/repos/cockroachdb/cockroach/stargazers","contributors_url":"https://api.github.com/repos/cockroachdb/cockroach/contributors","subscribers_url":"https://api.github.com/repos/cockroachdb/cockroach/subscribers","subscription_url":"https://api.github.com/repos/cockroachdb/cockroach/subscription","commits_url":"https://api.github.com/repos/cockroachdb/cockroach/commits{/sha}","git_commits_url":"https://api.github.com/repos/cockroachdb/cockroach/git/commits{/sha}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/comments{/number}","issue_comment_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/{number}","contents_url":"https://api.github.com/repos/cockroachdb/cockroach/contents/{+path}","compare_url":"https://api.github.com/repos/cockroachdb/cockroach/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cockroachdb/cockroach/merges","archive_url":"https://api.github.com/repos/cockroachdb/cockroach/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cockroachdb/cockroach/downloads","issues_url":"https://api.github.com/repos/cockroachdb/cockroach/issues{/number}","pulls_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls{/number}","milestones_url":"https://api.github.com/repos/cockroachdb/cockroach/milestones{/number}","notifications_url":"https://api.github.com/repos/cockroachdb/cockroach/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/labels{/name}","releases_url":"https://api.github.com/repos/cockroachdb/cockroach/releases{/id}","created_at":"2014-02-06T00:18:47Z","updated_at":"2014-12-10T00:09:40Z","pushed_at":"2014-12-10T00:09:40Z","git_url":"git://github.com/cockroachdb/cockroach.git","ssh_url":"git@github.com:cockroachdb/cockroach.git","clone_url":"https://github.com/cockroachdb/cockroach.git","svn_url":"https://github.com/cockroachdb/cockroach","homepage":null,"size":11198,"stargazers_count":2508,"watchers_count":2508,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":165,"mirror_url":null,"open_issues_count":16,"forks":165,"open_issues":16,"watchers":2508,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/206"},"html":{"href":"https://github.com/cockroachdb/cockroach/pull/206"},"issue":{"href":"https://api.github.com/repos/cockroachdb/cockroach/issues/206"},"comments":{"href":"https://api.github.com/repos/cockroachdb/cockroach/issues/206/comments"},"review_comments":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/206/comments"},"review_comment":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/206/commits"},"statuses":{"href":"https://api.github.com/repos/cockroachdb/cockroach/statuses/4f5eacb0dd7511b475bda9954c7ec94e2e50e177"}}}}