GitHub PullRequestEvent at 2014-06-15 14:38:20
Repository: micropython
Actor: stinos
Payload: {"action":"reopened","number":690,"pull_request":{"url":"https://api.github.com/repos/micropython/micropython/pulls/690","id":17126204,"html_url":"https://github.com/micropython/micropython/pull/690","diff_url":"https://github.com/micropython/micropython/pull/690.diff","patch_url":"https://github.com/micropython/micropython/pull/690.patch","issue_url":"https://api.github.com/repos/micropython/micropython/issues/690","number":690,"state":"open","title":"msvc: Enable GC","user":{"login":"stinos","id":1902997,"avatar_url":"https://avatars.githubusercontent.com/u/1902997?","gravatar_id":"b8a96ef1c0bf99b1f4e800bc96a7ea9b","url":"https://api.github.com/users/stinos","html_url":"https://github.com/stinos","followers_url":"https://api.github.com/users/stinos/followers","following_url":"https://api.github.com/users/stinos/following{/other_user}","gists_url":"https://api.github.com/users/stinos/gists{/gist_id}","starred_url":"https://api.github.com/users/stinos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stinos/subscriptions","organizations_url":"https://api.github.com/users/stinos/orgs","repos_url":"https://api.github.com/users/stinos/repos","events_url":"https://api.github.com/users/stinos/events{/privacy}","received_events_url":"https://api.github.com/users/stinos/received_events","type":"User","site_admin":false},"body":"Msvc only declares the semi-standard _bss_start and _end variables (for compatibility I guess), but they do not point to the actual bss section used. That is appended to the end of the data section by the linker so it's not possibly to look it up (or I found no way). However putting all statics in a named section and then querying the executable to figure out where the section is, and use that for the GC, seems to work just fine.\r\nAlso see #625 - a couple of tests show the behaviour is now roughly the same as gcc builds.","created_at":"2014-06-13T19:03:15Z","updated_at":"2014-06-15T14:38:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7f520484f3719e8444ae5d19915638062c7ee5c4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/micropython/micropython/pulls/690/commits","review_comments_url":"https://api.github.com/repos/micropython/micropython/pulls/690/comments","review_comment_url":"https://api.github.com/repos/micropython/micropython/pulls/comments/{number}","comments_url":"https://api.github.com/repos/micropython/micropython/issues/690/comments","statuses_url":"https://api.github.com/repos/micropython/micropython/statuses/bdd19c987222e7c62ea527a747595f7a9a8099a3","head":{"label":"stinos:msvc-gc","ref":"msvc-gc","sha":"bdd19c987222e7c62ea527a747595f7a9a8099a3","user":{"login":"stinos","id":1902997,"avatar_url":"https://avatars.githubusercontent.com/u/1902997?","gravatar_id":"b8a96ef1c0bf99b1f4e800bc96a7ea9b","url":"https://api.github.com/users/stinos","html_url":"https://github.com/stinos","followers_url":"https://api.github.com/users/stinos/followers","following_url":"https://api.github.com/users/stinos/following{/other_user}","gists_url":"https://api.github.com/users/stinos/gists{/gist_id}","starred_url":"https://api.github.com/users/stinos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stinos/subscriptions","organizations_url":"https://api.github.com/users/stinos/orgs","repos_url":"https://api.github.com/users/stinos/repos","events_url":"https://api.github.com/users/stinos/events{/privacy}","received_events_url":"https://api.github.com/users/stinos/received_events","type":"User","site_admin":false},"repo":{"id":19268673,"name":"micropython","full_name":"stinos/micropython","owner":{"login":"stinos","id":1902997,"avatar_url":"https://avatars.githubusercontent.com/u/1902997?","gravatar_id":"b8a96ef1c0bf99b1f4e800bc96a7ea9b","url":"https://api.github.com/users/stinos","html_url":"https://github.com/stinos","followers_url":"https://api.github.com/users/stinos/followers","following_url":"https://api.github.com/users/stinos/following{/other_user}","gists_url":"https://api.github.com/users/stinos/gists{/gist_id}","starred_url":"https://api.github.com/users/stinos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stinos/subscriptions","organizations_url":"https://api.github.com/users/stinos/orgs","repos_url":"https://api.github.com/users/stinos/repos","events_url":"https://api.github.com/users/stinos/events{/privacy}","received_events_url":"https://api.github.com/users/stinos/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stinos/micropython","description":"The Micro Python project","fork":true,"url":"https://api.github.com/repos/stinos/micropython","forks_url":"https://api.github.com/repos/stinos/micropython/forks","keys_url":"https://api.github.com/repos/stinos/micropython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stinos/micropython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stinos/micropython/teams","hooks_url":"https://api.github.com/repos/stinos/micropython/hooks","issue_events_url":"https://api.github.com/repos/stinos/micropython/issues/events{/number}","events_url":"https://api.github.com/repos/stinos/micropython/events","assignees_url":"https://api.github.com/repos/stinos/micropython/assignees{/user}","branches_url":"https://api.github.com/repos/stinos/micropython/branches{/branch}","tags_url":"https://api.github.com/repos/stinos/micropython/tags","blobs_url":"https://api.github.com/repos/stinos/micropython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stinos/micropython/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stinos/micropython/git/refs{/sha}","trees_url":"https://api.github.com/repos/stinos/micropython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stinos/micropython/statuses/{sha}","languages_url":"https://api.github.com/repos/stinos/micropython/languages","stargazers_url":"https://api.github.com/repos/stinos/micropython/stargazers","contributors_url":"https://api.github.com/repos/stinos/micropython/contributors","subscribers_url":"https://api.github.com/repos/stinos/micropython/subscribers","subscription_url":"https://api.github.com/repos/stinos/micropython/subscription","commits_url":"https://api.github.com/repos/stinos/micropython/commits{/sha}","git_commits_url":"https://api.github.com/repos/stinos/micropython/git/commits{/sha}","comments_url":"https://api.github.com/repos/stinos/micropython/comments{/number}","issue_comment_url":"https://api.github.com/repos/stinos/micropython/issues/comments/{number}","contents_url":"https://api.github.com/repos/stinos/micropython/contents/{+path}","compare_url":"https://api.github.com/repos/stinos/micropython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stinos/micropython/merges","archive_url":"https://api.github.com/repos/stinos/micropython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stinos/micropython/downloads","issues_url":"https://api.github.com/repos/stinos/micropython/issues{/number}","pulls_url":"https://api.github.com/repos/stinos/micropython/pulls{/number}","milestones_url":"https://api.github.com/repos/stinos/micropython/milestones{/number}","notifications_url":"https://api.github.com/repos/stinos/micropython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stinos/micropython/labels{/name}","releases_url":"https://api.github.com/repos/stinos/micropython/releases{/id}","created_at":"2014-04-29T08:04:48Z","updated_at":"2014-06-15T14:32:20Z","pushed_at":"2014-06-15T14:32:20Z","git_url":"git://github.com/stinos/micropython.git","ssh_url":"git@github.com:stinos/micropython.git","clone_url":"https://github.com/stinos/micropython.git","svn_url":"https://github.com/stinos/micropython","homepage":null,"size":11621,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"micropython:master","ref":"master","sha":"e3cfc0d33d04a33b6f546f8018991c34768a871d","user":{"login":"micropython","id":6298560,"avatar_url":"https://avatars.githubusercontent.com/u/6298560?","gravatar_id":"8dd8c7e0c7f45b48c8e44a4e85672370","url":"https://api.github.com/users/micropython","html_url":"https://github.com/micropython","followers_url":"https://api.github.com/users/micropython/followers","following_url":"https://api.github.com/users/micropython/following{/other_user}","gists_url":"https://api.github.com/users/micropython/gists{/gist_id}","starred_url":"https://api.github.com/users/micropython/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micropython/subscriptions","organizations_url":"https://api.github.com/users/micropython/orgs","repos_url":"https://api.github.com/users/micropython/repos","events_url":"https://api.github.com/users/micropython/events{/privacy}","received_events_url":"https://api.github.com/users/micropython/received_events","type":"Organization","site_admin":false},"repo":{"id":15337142,"name":"micropython","full_name":"micropython/micropython","owner":{"login":"micropython","id":6298560,"avatar_url":"https://avatars.githubusercontent.com/u/6298560?","gravatar_id":"8dd8c7e0c7f45b48c8e44a4e85672370","url":"https://api.github.com/users/micropython","html_url":"https://github.com/micropython","followers_url":"https://api.github.com/users/micropython/followers","following_url":"https://api.github.com/users/micropython/following{/other_user}","gists_url":"https://api.github.com/users/micropython/gists{/gist_id}","starred_url":"https://api.github.com/users/micropython/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micropython/subscriptions","organizations_url":"https://api.github.com/users/micropython/orgs","repos_url":"https://api.github.com/users/micropython/repos","events_url":"https://api.github.com/users/micropython/events{/privacy}","received_events_url":"https://api.github.com/users/micropython/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/micropython/micropython","description":"The Micro Python project","fork":false,"url":"https://api.github.com/repos/micropython/micropython","forks_url":"https://api.github.com/repos/micropython/micropython/forks","keys_url":"https://api.github.com/repos/micropython/micropython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/micropython/micropython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/micropython/micropython/teams","hooks_url":"https://api.github.com/repos/micropython/micropython/hooks","issue_events_url":"https://api.github.com/repos/micropython/micropython/issues/events{/number}","events_url":"https://api.github.com/repos/micropython/micropython/events","assignees_url":"https://api.github.com/repos/micropython/micropython/assignees{/user}","branches_url":"https://api.github.com/repos/micropython/micropython/branches{/branch}","tags_url":"https://api.github.com/repos/micropython/micropython/tags","blobs_url":"https://api.github.com/repos/micropython/micropython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/micropython/micropython/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/micropython/micropython/git/refs{/sha}","trees_url":"https://api.github.com/repos/micropython/micropython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/micropython/micropython/statuses/{sha}","languages_url":"https://api.github.com/repos/micropython/micropython/languages","stargazers_url":"https://api.github.com/repos/micropython/micropython/stargazers","contributors_url":"https://api.github.com/repos/micropython/micropython/contributors","subscribers_url":"https://api.github.com/repos/micropython/micropython/subscribers","subscription_url":"https://api.github.com/repos/micropython/micropython/subscription","commits_url":"https://api.github.com/repos/micropython/micropython/commits{/sha}","git_commits_url":"https://api.github.com/repos/micropython/micropython/git/commits{/sha}","comments_url":"https://api.github.com/repos/micropython/micropython/comments{/number}","issue_comment_url":"https://api.github.com/repos/micropython/micropython/issues/comments/{number}","contents_url":"https://api.github.com/repos/micropython/micropython/contents/{+path}","compare_url":"https://api.github.com/repos/micropython/micropython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/micropython/micropython/merges","archive_url":"https://api.github.com/repos/micropython/micropython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/micropython/micropython/downloads","issues_url":"https://api.github.com/repos/micropython/micropython/issues{/number}","pulls_url":"https://api.github.com/repos/micropython/micropython/pulls{/number}","milestones_url":"https://api.github.com/repos/micropython/micropython/milestones{/number}","notifications_url":"https://api.github.com/repos/micropython/micropython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/micropython/micropython/labels{/name}","releases_url":"https://api.github.com/repos/micropython/micropython/releases{/id}","created_at":"2013-12-20T11:47:07Z","updated_at":"2014-06-15T09:20:47Z","pushed_at":"2014-06-15T09:02:46Z","git_url":"git://github.com/micropython/micropython.git","ssh_url":"git@github.com:micropython/micropython.git","clone_url":"https://github.com/micropython/micropython.git","svn_url":"https://github.com/micropython/micropython","homepage":null,"size":29212,"stargazers_count":1038,"watchers_count":1038,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":130,"mirror_url":null,"open_issues_count":81,"forks":130,"open_issues":81,"watchers":1038,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/micropython/micropython/pulls/690"},"html":{"href":"https://github.com/micropython/micropython/pull/690"},"issue":{"href":"https://api.github.com/repos/micropython/micropython/issues/690"},"comments":{"href":"https://api.github.com/repos/micropython/micropython/issues/690/comments"},"review_comments":{"href":"https://api.github.com/repos/micropython/micropython/pulls/690/comments"},"review_comment":{"href":"https://api.github.com/repos/micropython/micropython/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/micropython/micropython/pulls/690/commits"},"statuses":{"href":"https://api.github.com/repos/micropython/micropython/statuses/bdd19c987222e7c62ea527a747595f7a9a8099a3"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":6,"review_comments":0,"commits":1,"additions":100,"deletions":3,"changed_files":6}}