GitHub PullRequestEvent at 2014-11-10 23:17:26
Repository: RxJS
Actor: mattpodwysocki
Payload: {"action":"closed","number":361,"pull_request":{"url":"https://api.github.com/repos/Reactive-Extensions/RxJS/pulls/361","id":24185019,"html_url":"https://github.com/Reactive-Extensions/RxJS/pull/361","diff_url":"https://github.com/Reactive-Extensions/RxJS/pull/361.diff","patch_url":"https://github.com/Reactive-Extensions/RxJS/pull/361.patch","issue_url":"https://api.github.com/repos/Reactive-Extensions/RxJS/issues/361","number":361,"state":"closed","locked":false,"title":"Move jscs to seperate file, other rules to todo file, fix styling","user":{"login":"hzoo","id":588473,"avatar_url":"https://avatars.githubusercontent.com/u/588473?v=3","gravatar_id":"","url":"https://api.github.com/users/hzoo","html_url":"https://github.com/hzoo","followers_url":"https://api.github.com/users/hzoo/followers","following_url":"https://api.github.com/users/hzoo/following{/other_user}","gists_url":"https://api.github.com/users/hzoo/gists{/gist_id}","starred_url":"https://api.github.com/users/hzoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hzoo/subscriptions","organizations_url":"https://api.github.com/users/hzoo/orgs","repos_url":"https://api.github.com/users/hzoo/repos","events_url":"https://api.github.com/users/hzoo/events{/privacy}","received_events_url":"https://api.github.com/users/hzoo/received_events","type":"User","site_admin":false},"body":"You might not like all of these rules - like `function()` vs `function ()` in the preset.\r\nSo to be more explicit, I copied the google preset rules to the newly created `.jscsrc` file.\r\n\r\nThe rules that created a lot of errors (indentation, etc) were moved to `.jscsrc-todo` and can be added/fixed later.\r\nThe rest of the files are changes for the rest of the rules.\r\nI excluded the files that were intro/outro.\r\n\r\n#359","created_at":"2014-11-10T22:59:12Z","updated_at":"2014-11-10T23:17:26Z","closed_at":"2014-11-10T23:17:26Z","merged_at":"2014-11-10T23:17:26Z","merge_commit_sha":"2cd84684be20a2dafe50371fe876e7b13869272a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Reactive-Extensions/RxJS/pulls/361/commits","review_comments_url":"https://api.github.com/repos/Reactive-Extensions/RxJS/pulls/361/comments","review_comment_url":"https://api.github.com/repos/Reactive-Extensions/RxJS/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Reactive-Extensions/RxJS/issues/361/comments","statuses_url":"https://api.github.com/repos/Reactive-Extensions/RxJS/statuses/d262399d8eb9a6d9c4b55f4c51f226c508f0ba3f","head":{"label":"hzoo:jscs-changes","ref":"jscs-changes","sha":"d262399d8eb9a6d9c4b55f4c51f226c508f0ba3f","user":{"login":"hzoo","id":588473,"avatar_url":"https://avatars.githubusercontent.com/u/588473?v=3","gravatar_id":"","url":"https://api.github.com/users/hzoo","html_url":"https://github.com/hzoo","followers_url":"https://api.github.com/users/hzoo/followers","following_url":"https://api.github.com/users/hzoo/following{/other_user}","gists_url":"https://api.github.com/users/hzoo/gists{/gist_id}","starred_url":"https://api.github.com/users/hzoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hzoo/subscriptions","organizations_url":"https://api.github.com/users/hzoo/orgs","repos_url":"https://api.github.com/users/hzoo/repos","events_url":"https://api.github.com/users/hzoo/events{/privacy}","received_events_url":"https://api.github.com/users/hzoo/received_events","type":"User","site_admin":false},"repo":{"id":26452296,"name":"RxJS","full_name":"hzoo/RxJS","owner":{"login":"hzoo","id":588473,"avatar_url":"https://avatars.githubusercontent.com/u/588473?v=3","gravatar_id":"","url":"https://api.github.com/users/hzoo","html_url":"https://github.com/hzoo","followers_url":"https://api.github.com/users/hzoo/followers","following_url":"https://api.github.com/users/hzoo/following{/other_user}","gists_url":"https://api.github.com/users/hzoo/gists{/gist_id}","starred_url":"https://api.github.com/users/hzoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hzoo/subscriptions","organizations_url":"https://api.github.com/users/hzoo/orgs","repos_url":"https://api.github.com/users/hzoo/repos","events_url":"https://api.github.com/users/hzoo/events{/privacy}","received_events_url":"https://api.github.com/users/hzoo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hzoo/RxJS","description":"The Reactive Extensions for JavaScript","fork":true,"url":"https://api.github.com/repos/hzoo/RxJS","forks_url":"https://api.github.com/repos/hzoo/RxJS/forks","keys_url":"https://api.github.com/repos/hzoo/RxJS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hzoo/RxJS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hzoo/RxJS/teams","hooks_url":"https://api.github.com/repos/hzoo/RxJS/hooks","issue_events_url":"https://api.github.com/repos/hzoo/RxJS/issues/events{/number}","events_url":"https://api.github.com/repos/hzoo/RxJS/events","assignees_url":"https://api.github.com/repos/hzoo/RxJS/assignees{/user}","branches_url":"https://api.github.com/repos/hzoo/RxJS/branches{/branch}","tags_url":"https://api.github.com/repos/hzoo/RxJS/tags","blobs_url":"https://api.github.com/repos/hzoo/RxJS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hzoo/RxJS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hzoo/RxJS/git/refs{/sha}","trees_url":"https://api.github.com/repos/hzoo/RxJS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hzoo/RxJS/statuses/{sha}","languages_url":"https://api.github.com/repos/hzoo/RxJS/languages","stargazers_url":"https://api.github.com/repos/hzoo/RxJS/stargazers","contributors_url":"https://api.github.com/repos/hzoo/RxJS/contributors","subscribers_url":"https://api.github.com/repos/hzoo/RxJS/subscribers","subscription_url":"https://api.github.com/repos/hzoo/RxJS/subscription","commits_url":"https://api.github.com/repos/hzoo/RxJS/commits{/sha}","git_commits_url":"https://api.github.com/repos/hzoo/RxJS/git/commits{/sha}","comments_url":"https://api.github.com/repos/hzoo/RxJS/comments{/number}","issue_comment_url":"https://api.github.com/repos/hzoo/RxJS/issues/comments/{number}","contents_url":"https://api.github.com/repos/hzoo/RxJS/contents/{+path}","compare_url":"https://api.github.com/repos/hzoo/RxJS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hzoo/RxJS/merges","archive_url":"https://api.github.com/repos/hzoo/RxJS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hzoo/RxJS/downloads","issues_url":"https://api.github.com/repos/hzoo/RxJS/issues{/number}","pulls_url":"https://api.github.com/repos/hzoo/RxJS/pulls{/number}","milestones_url":"https://api.github.com/repos/hzoo/RxJS/milestones{/number}","notifications_url":"https://api.github.com/repos/hzoo/RxJS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hzoo/RxJS/labels{/name}","releases_url":"https://api.github.com/repos/hzoo/RxJS/releases{/id}","created_at":"2014-11-10T19:39:43Z","updated_at":"2014-11-10T18:31:43Z","pushed_at":"2014-11-10T22:55:35Z","git_url":"git://github.com/hzoo/RxJS.git","ssh_url":"git@github.com:hzoo/RxJS.git","clone_url":"https://github.com/hzoo/RxJS.git","svn_url":"https://github.com/hzoo/RxJS","homepage":"http://reactive-extensions.github.com/RxJS/","size":20354,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Reactive-Extensions:master","ref":"master","sha":"01f03d0e04a19184fc89b53d681fb439eaa51318","user":{"login":"Reactive-Extensions","id":984368,"avatar_url":"https://avatars.githubusercontent.com/u/984368?v=3","gravatar_id":"","url":"https://api.github.com/users/Reactive-Extensions","html_url":"https://github.com/Reactive-Extensions","followers_url":"https://api.github.com/users/Reactive-Extensions/followers","following_url":"https://api.github.com/users/Reactive-Extensions/following{/other_user}","gists_url":"https://api.github.com/users/Reactive-Extensions/gists{/gist_id}","starred_url":"https://api.github.com/users/Reactive-Extensions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Reactive-Extensions/subscriptions","organizations_url":"https://api.github.com/users/Reactive-Extensions/orgs","repos_url":"https://api.github.com/users/Reactive-Extensions/repos","events_url":"https://api.github.com/users/Reactive-Extensions/events{/privacy}","received_events_url":"https://api.github.com/users/Reactive-Extensions/received_events","type":"Organization","site_admin":false},"repo":{"id":3122202,"name":"RxJS","full_name":"Reactive-Extensions/RxJS","owner":{"login":"Reactive-Extensions","id":984368,"avatar_url":"https://avatars.githubusercontent.com/u/984368?v=3","gravatar_id":"","url":"https://api.github.com/users/Reactive-Extensions","html_url":"https://github.com/Reactive-Extensions","followers_url":"https://api.github.com/users/Reactive-Extensions/followers","following_url":"https://api.github.com/users/Reactive-Extensions/following{/other_user}","gists_url":"https://api.github.com/users/Reactive-Extensions/gists{/gist_id}","starred_url":"https://api.github.com/users/Reactive-Extensions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Reactive-Extensions/subscriptions","organizations_url":"https://api.github.com/users/Reactive-Extensions/orgs","repos_url":"https://api.github.com/users/Reactive-Extensions/repos","events_url":"https://api.github.com/users/Reactive-Extensions/events{/privacy}","received_events_url":"https://api.github.com/users/Reactive-Extensions/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Reactive-Extensions/RxJS","description":"The Reactive Extensions for JavaScript","fork":false,"url":"https://api.github.com/repos/Reactive-Extensions/RxJS","forks_url":"https://api.github.com/repos/Reactive-Extensions/RxJS/forks","keys_url":"https://api.github.com/repos/Reactive-Extensions/RxJS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Reactive-Extensions/RxJS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Reactive-Extensions/RxJS/teams","hooks_url":"https://api.github.com/repos/Reactive-Extensions/RxJS/hooks","issue_events_url":"https://api.github.com/repos/Reactive-Extensions/RxJS/issues/events{/number}","events_url":"https://api.github.com/repos/Reactive-Extensions/RxJS/events","assignees_url":"https://api.github.com/repos/Reactive-Extensions/RxJS/assignees{/user}","branches_url":"https://api.github.com/repos/Reactive-Extensions/RxJS/branches{/branch}","tags_url":"https://api.github.com/repos/Reactive-Extensions/RxJS/tags","blobs_url":"https://api.github.com/repos/Reactive-Extensions/RxJS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Reactive-Extensions/RxJS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Reactive-Extensions/RxJS/git/refs{/sha}","trees_url":"https://api.github.com/repos/Reactive-Extensions/RxJS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Reactive-Extensions/RxJS/statuses/{sha}","languages_url":"https://api.github.com/repos/Reactive-Extensions/RxJS/languages","stargazers_url":"https://api.github.com/repos/Reactive-Extensions/RxJS/stargazers","contributors_url":"https://api.github.com/repos/Reactive-Extensions/RxJS/contributors","subscribers_url":"https://api.github.com/repos/Reactive-Extensions/RxJS/subscribers","subscription_url":"https://api.github.com/repos/Reactive-Extensions/RxJS/subscription","commits_url":"https://api.github.com/repos/Reactive-Extensions/RxJS/commits{/sha}","git_commits_url":"https://api.github.com/repos/Reactive-Extensions/RxJS/git/commits{/sha}","comments_url":"https://api.github.com/repos/Reactive-Extensions/RxJS/comments{/number}","issue_comment_url":"https://api.github.com/repos/Reactive-Extensions/RxJS/issues/comments/{number}","contents_url":"https://api.github.com/repos/Reactive-Extensions/RxJS/contents/{+path}","compare_url":"https://api.github.com/repos/Reactive-Extensions/RxJS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Reactive-Extensions/RxJS/merges","archive_url":"https://api.github.com/repos/Reactive-Extensions/RxJS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Reactive-Extensions/RxJS/downloads","issues_url":"https://api.github.com/repos/Reactive-Extensions/RxJS/issues{/number}","pulls_url":"https://api.github.com/repos/Reactive-Extensions/RxJS/pulls{/number}","milestones_url":"https://api.github.com/repos/Reactive-Extensions/RxJS/milestones{/number}","notifications_url":"https://api.github.com/repos/Reactive-Extensions/RxJS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Reactive-Extensions/RxJS/labels{/name}","releases_url":"https://api.github.com/repos/Reactive-Extensions/RxJS/releases{/id}","created_at":"2012-01-07T00:31:41Z","updated_at":"2014-11-10T18:31:43Z","pushed_at":"2014-11-10T23:17:26Z","git_url":"git://github.com/Reactive-Extensions/RxJS.git","ssh_url":"git@github.com:Reactive-Extensions/RxJS.git","clone_url":"https://github.com/Reactive-Extensions/RxJS.git","svn_url":"https://github.com/Reactive-Extensions/RxJS","homepage":"http://reactive-extensions.github.com/RxJS/","size":20354,"stargazers_count":2311,"watchers_count":2311,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":210,"mirror_url":null,"open_issues_count":19,"forks":210,"open_issues":19,"watchers":2311,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Reactive-Extensions/RxJS/pulls/361"},"html":{"href":"https://github.com/Reactive-Extensions/RxJS/pull/361"},"issue":{"href":"https://api.github.com/repos/Reactive-Extensions/RxJS/issues/361"},"comments":{"href":"https://api.github.com/repos/Reactive-Extensions/RxJS/issues/361/comments"},"review_comments":{"href":"https://api.github.com/repos/Reactive-Extensions/RxJS/pulls/361/comments"},"review_comment":{"href":"https://api.github.com/repos/Reactive-Extensions/RxJS/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Reactive-Extensions/RxJS/pulls/361/commits"},"statuses":{"href":"https://api.github.com/repos/Reactive-Extensions/RxJS/statuses/d262399d8eb9a6d9c4b55f4c51f226c508f0ba3f"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"mattpodwysocki","id":49051,"avatar_url":"https://avatars.githubusercontent.com/u/49051?v=3","gravatar_id":"","url":"https://api.github.com/users/mattpodwysocki","html_url":"https://github.com/mattpodwysocki","followers_url":"https://api.github.com/users/mattpodwysocki/followers","following_url":"https://api.github.com/users/mattpodwysocki/following{/other_user}","gists_url":"https://api.github.com/users/mattpodwysocki/gists{/gist_id}","starred_url":"https://api.github.com/users/mattpodwysocki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattpodwysocki/subscriptions","organizations_url":"https://api.github.com/users/mattpodwysocki/orgs","repos_url":"https://api.github.com/users/mattpodwysocki/repos","events_url":"https://api.github.com/users/mattpodwysocki/events{/privacy}","received_events_url":"https://api.github.com/users/mattpodwysocki/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":102,"deletions":27,"changed_files":17}}