GitHub PullRequestReviewCommentEvent at 2014-12-21 21:25:34
Repository: translators
Actor: rm2342
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/zotero/translators/pulls/comments/22150437","id":22150437,"diff_hunk":"@@ -114,25 +146,21 @@ var testCases = [\n \t\t\t\t\t\t\"creatorType\": \"author\"\n \t\t\t\t\t}\n \t\t\t\t],\n-\t\t\t\t\"notes\": [],\n-\t\t\t\t\"tags\": [],\n-\t\t\t\t\"seeAlso\": [],\n+\t\t\t\t\"journalAbbreviation\": \"JurPC\",\n+\t\t\t\t\"language\": \"de-DE\",\n+\t\t\t\t\"libraryCatalog\": \"JurPC\",\n+\t\t\t\t\"pages\": \"Abs. 1 - 92\",","path":"JurPC.js","position":124,"original_position":124,"commit_id":"79026a25a1f3bcfc92fea052c4bc4bc55c000620","original_commit_id":"79026a25a1f3bcfc92fea052c4bc4bc55c000620","user":{"login":"rm2342","id":9452312,"avatar_url":"https://avatars.githubusercontent.com/u/9452312?v=3","gravatar_id":"","url":"https://api.github.com/users/rm2342","html_url":"https://github.com/rm2342","followers_url":"https://api.github.com/users/rm2342/followers","following_url":"https://api.github.com/users/rm2342/following{/other_user}","gists_url":"https://api.github.com/users/rm2342/gists{/gist_id}","starred_url":"https://api.github.com/users/rm2342/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rm2342/subscriptions","organizations_url":"https://api.github.com/users/rm2342/orgs","repos_url":"https://api.github.com/users/rm2342/repos","events_url":"https://api.github.com/users/rm2342/events{/privacy}","received_events_url":"https://api.github.com/users/rm2342/received_events","type":"User","site_admin":false},"body":"This is how Scaffold populates the test case (and the result of running\r\ndoWeb()). I do not know why these attributes are set at all, they should\r\nall be null as far as I read the source code.\r\n\r\n22:24:50 Returned item:\r\n           {\r\n             \"itemType\": \"case\"\r\n             \"creators\": []\r\n             \"notes\": []\r\n             \"tags\": []\r\n             \"seeAlso\": []\r\n             \"attachments\": [\r\n               {\r\n                 \"title\": \"JurPC SNapshot\"\r\n                 \"mimeType\": \"text/html\"\r\n               }\r\n             ]\r\n         -   \"title\": \"Deus Ex\"\r\n             \"court\": \"BGH\"\r\n             \"caseName\": \"Deus Ex\"\r\n             \"docketNumber\": \"I ZB 71/13\"\r\n             \"reporter\": \"JurPC WebDok\"\r\n             \"reporterVolume\": \"165/2014\"\r\n         -   \"pages\": \"Abs. 1 - 18\"\r\n             \"url\": \"http://www.jurpc.de/jurpc/show?id=20140165\"\r\n             \"dateDecided\": \"2014-05-15\"\r\n             \"extra\": \"{:genre: Beschl.}\"\r\n             \"language\": \"de-DE\"\r\n         -   \"libraryCatalog\": \"JurPC\"\r\n         -   \"accessDate\": \"CURRENT_TIMESTAMP\"\r\n         +   \"firstPage\": \"Abs. 1 - 18\"\r\n           }\r\n22:24:50 Translation successful","created_at":"2014-12-21T21:25:34Z","updated_at":"2014-12-21T21:25:34Z","html_url":"https://github.com/zotero/translators/pull/825#discussion_r22150437","pull_request_url":"https://api.github.com/repos/zotero/translators/pulls/825","_links":{"self":{"href":"https://api.github.com/repos/zotero/translators/pulls/comments/22150437"},"html":{"href":"https://github.com/zotero/translators/pull/825#discussion_r22150437"},"pull_request":{"href":"https://api.github.com/repos/zotero/translators/pulls/825"}}},"pull_request":{"url":"https://api.github.com/repos/zotero/translators/pulls/825","id":25981266,"html_url":"https://github.com/zotero/translators/pull/825","diff_url":"https://github.com/zotero/translators/pull/825.diff","patch_url":"https://github.com/zotero/translators/pull/825.patch","issue_url":"https://api.github.com/repos/zotero/translators/issues/825","number":825,"state":"open","locked":false,"title":"refactored scraping of cases","user":{"login":"rm2342","id":9452312,"avatar_url":"https://avatars.githubusercontent.com/u/9452312?v=3","gravatar_id":"","url":"https://api.github.com/users/rm2342","html_url":"https://github.com/rm2342","followers_url":"https://api.github.com/users/rm2342/followers","following_url":"https://api.github.com/users/rm2342/following{/other_user}","gists_url":"https://api.github.com/users/rm2342/gists{/gist_id}","starred_url":"https://api.github.com/users/rm2342/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rm2342/subscriptions","organizations_url":"https://api.github.com/users/rm2342/orgs","repos_url":"https://api.github.com/users/rm2342/repos","events_url":"https://api.github.com/users/rm2342/events{/privacy}","received_events_url":"https://api.github.com/users/rm2342/received_events","type":"User","site_admin":false},"body":"& fixed scraping of cases where data is merged in one h2-element","created_at":"2014-12-12T15:37:45Z","updated_at":"2014-12-21T21:25:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0c4af7bf504aa4bec3a324c904b712916179762e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/zotero/translators/pulls/825/commits","review_comments_url":"https://api.github.com/repos/zotero/translators/pulls/825/comments","review_comment_url":"https://api.github.com/repos/zotero/translators/pulls/comments/{number}","comments_url":"https://api.github.com/repos/zotero/translators/issues/825/comments","statuses_url":"https://api.github.com/repos/zotero/translators/statuses/79026a25a1f3bcfc92fea052c4bc4bc55c000620","head":{"label":"rm2342:master","ref":"master","sha":"79026a25a1f3bcfc92fea052c4bc4bc55c000620","user":{"login":"rm2342","id":9452312,"avatar_url":"https://avatars.githubusercontent.com/u/9452312?v=3","gravatar_id":"","url":"https://api.github.com/users/rm2342","html_url":"https://github.com/rm2342","followers_url":"https://api.github.com/users/rm2342/followers","following_url":"https://api.github.com/users/rm2342/following{/other_user}","gists_url":"https://api.github.com/users/rm2342/gists{/gist_id}","starred_url":"https://api.github.com/users/rm2342/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rm2342/subscriptions","organizations_url":"https://api.github.com/users/rm2342/orgs","repos_url":"https://api.github.com/users/rm2342/repos","events_url":"https://api.github.com/users/rm2342/events{/privacy}","received_events_url":"https://api.github.com/users/rm2342/received_events","type":"User","site_admin":false},"repo":{"id":27506935,"name":"translators","full_name":"rm2342/translators","owner":{"login":"rm2342","id":9452312,"avatar_url":"https://avatars.githubusercontent.com/u/9452312?v=3","gravatar_id":"","url":"https://api.github.com/users/rm2342","html_url":"https://github.com/rm2342","followers_url":"https://api.github.com/users/rm2342/followers","following_url":"https://api.github.com/users/rm2342/following{/other_user}","gists_url":"https://api.github.com/users/rm2342/gists{/gist_id}","starred_url":"https://api.github.com/users/rm2342/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rm2342/subscriptions","organizations_url":"https://api.github.com/users/rm2342/orgs","repos_url":"https://api.github.com/users/rm2342/repos","events_url":"https://api.github.com/users/rm2342/events{/privacy}","received_events_url":"https://api.github.com/users/rm2342/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rm2342/translators","description":"Zotero Translators","fork":true,"url":"https://api.github.com/repos/rm2342/translators","forks_url":"https://api.github.com/repos/rm2342/translators/forks","keys_url":"https://api.github.com/repos/rm2342/translators/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rm2342/translators/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rm2342/translators/teams","hooks_url":"https://api.github.com/repos/rm2342/translators/hooks","issue_events_url":"https://api.github.com/repos/rm2342/translators/issues/events{/number}","events_url":"https://api.github.com/repos/rm2342/translators/events","assignees_url":"https://api.github.com/repos/rm2342/translators/assignees{/user}","branches_url":"https://api.github.com/repos/rm2342/translators/branches{/branch}","tags_url":"https://api.github.com/repos/rm2342/translators/tags","blobs_url":"https://api.github.com/repos/rm2342/translators/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rm2342/translators/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rm2342/translators/git/refs{/sha}","trees_url":"https://api.github.com/repos/rm2342/translators/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rm2342/translators/statuses/{sha}","languages_url":"https://api.github.com/repos/rm2342/translators/languages","stargazers_url":"https://api.github.com/repos/rm2342/translators/stargazers","contributors_url":"https://api.github.com/repos/rm2342/translators/contributors","subscribers_url":"https://api.github.com/repos/rm2342/translators/subscribers","subscription_url":"https://api.github.com/repos/rm2342/translators/subscription","commits_url":"https://api.github.com/repos/rm2342/translators/commits{/sha}","git_commits_url":"https://api.github.com/repos/rm2342/translators/git/commits{/sha}","comments_url":"https://api.github.com/repos/rm2342/translators/comments{/number}","issue_comment_url":"https://api.github.com/repos/rm2342/translators/issues/comments/{number}","contents_url":"https://api.github.com/repos/rm2342/translators/contents/{+path}","compare_url":"https://api.github.com/repos/rm2342/translators/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rm2342/translators/merges","archive_url":"https://api.github.com/repos/rm2342/translators/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rm2342/translators/downloads","issues_url":"https://api.github.com/repos/rm2342/translators/issues{/number}","pulls_url":"https://api.github.com/repos/rm2342/translators/pulls{/number}","milestones_url":"https://api.github.com/repos/rm2342/translators/milestones{/number}","notifications_url":"https://api.github.com/repos/rm2342/translators/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rm2342/translators/labels{/name}","releases_url":"https://api.github.com/repos/rm2342/translators/releases{/id}","created_at":"2014-12-03T20:45:38Z","updated_at":"2014-12-20T11:27:59Z","pushed_at":"2014-12-20T11:27:57Z","git_url":"git://github.com/rm2342/translators.git","ssh_url":"git@github.com:rm2342/translators.git","clone_url":"https://github.com/rm2342/translators.git","svn_url":"https://github.com/rm2342/translators","homepage":"http://www.zotero.org/support/dev/translators","size":10836,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zotero:master","ref":"master","sha":"68283be78ab5baf26e936134baf53f6482597c1f","user":{"login":"zotero","id":891917,"avatar_url":"https://avatars.githubusercontent.com/u/891917?v=3","gravatar_id":"","url":"https://api.github.com/users/zotero","html_url":"https://github.com/zotero","followers_url":"https://api.github.com/users/zotero/followers","following_url":"https://api.github.com/users/zotero/following{/other_user}","gists_url":"https://api.github.com/users/zotero/gists{/gist_id}","starred_url":"https://api.github.com/users/zotero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zotero/subscriptions","organizations_url":"https://api.github.com/users/zotero/orgs","repos_url":"https://api.github.com/users/zotero/repos","events_url":"https://api.github.com/users/zotero/events{/privacy}","received_events_url":"https://api.github.com/users/zotero/received_events","type":"Organization","site_admin":false},"repo":{"id":1991863,"name":"translators","full_name":"zotero/translators","owner":{"login":"zotero","id":891917,"avatar_url":"https://avatars.githubusercontent.com/u/891917?v=3","gravatar_id":"","url":"https://api.github.com/users/zotero","html_url":"https://github.com/zotero","followers_url":"https://api.github.com/users/zotero/followers","following_url":"https://api.github.com/users/zotero/following{/other_user}","gists_url":"https://api.github.com/users/zotero/gists{/gist_id}","starred_url":"https://api.github.com/users/zotero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zotero/subscriptions","organizations_url":"https://api.github.com/users/zotero/orgs","repos_url":"https://api.github.com/users/zotero/repos","events_url":"https://api.github.com/users/zotero/events{/privacy}","received_events_url":"https://api.github.com/users/zotero/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zotero/translators","description":"Zotero Translators","fork":false,"url":"https://api.github.com/repos/zotero/translators","forks_url":"https://api.github.com/repos/zotero/translators/forks","keys_url":"https://api.github.com/repos/zotero/translators/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zotero/translators/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zotero/translators/teams","hooks_url":"https://api.github.com/repos/zotero/translators/hooks","issue_events_url":"https://api.github.com/repos/zotero/translators/issues/events{/number}","events_url":"https://api.github.com/repos/zotero/translators/events","assignees_url":"https://api.github.com/repos/zotero/translators/assignees{/user}","branches_url":"https://api.github.com/repos/zotero/translators/branches{/branch}","tags_url":"https://api.github.com/repos/zotero/translators/tags","blobs_url":"https://api.github.com/repos/zotero/translators/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zotero/translators/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zotero/translators/git/refs{/sha}","trees_url":"https://api.github.com/repos/zotero/translators/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zotero/translators/statuses/{sha}","languages_url":"https://api.github.com/repos/zotero/translators/languages","stargazers_url":"https://api.github.com/repos/zotero/translators/stargazers","contributors_url":"https://api.github.com/repos/zotero/translators/contributors","subscribers_url":"https://api.github.com/repos/zotero/translators/subscribers","subscription_url":"https://api.github.com/repos/zotero/translators/subscription","commits_url":"https://api.github.com/repos/zotero/translators/commits{/sha}","git_commits_url":"https://api.github.com/repos/zotero/translators/git/commits{/sha}","comments_url":"https://api.github.com/repos/zotero/translators/comments{/number}","issue_comment_url":"https://api.github.com/repos/zotero/translators/issues/comments/{number}","contents_url":"https://api.github.com/repos/zotero/translators/contents/{+path}","compare_url":"https://api.github.com/repos/zotero/translators/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zotero/translators/merges","archive_url":"https://api.github.com/repos/zotero/translators/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zotero/translators/downloads","issues_url":"https://api.github.com/repos/zotero/translators/issues{/number}","pulls_url":"https://api.github.com/repos/zotero/translators/pulls{/number}","milestones_url":"https://api.github.com/repos/zotero/translators/milestones{/number}","notifications_url":"https://api.github.com/repos/zotero/translators/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zotero/translators/labels{/name}","releases_url":"https://api.github.com/repos/zotero/translators/releases{/id}","created_at":"2011-07-03T17:40:38Z","updated_at":"2014-12-18T07:06:51Z","pushed_at":"2014-12-18T07:06:51Z","git_url":"git://github.com/zotero/translators.git","ssh_url":"git@github.com:zotero/translators.git","clone_url":"https://github.com/zotero/translators.git","svn_url":"https://github.com/zotero/translators","homepage":"http://www.zotero.org/support/dev/translators","size":15867,"stargazers_count":127,"watchers_count":127,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":108,"mirror_url":null,"open_issues_count":116,"forks":108,"open_issues":116,"watchers":127,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zotero/translators/pulls/825"},"html":{"href":"https://github.com/zotero/translators/pull/825"},"issue":{"href":"https://api.github.com/repos/zotero/translators/issues/825"},"comments":{"href":"https://api.github.com/repos/zotero/translators/issues/825/comments"},"review_comments":{"href":"https://api.github.com/repos/zotero/translators/pulls/825/comments"},"review_comment":{"href":"https://api.github.com/repos/zotero/translators/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/zotero/translators/pulls/825/commits"},"statuses":{"href":"https://api.github.com/repos/zotero/translators/statuses/79026a25a1f3bcfc92fea052c4bc4bc55c000620"}}}}