GitHub PullRequestReviewCommentEvent at 2014-10-08 16:05:03
Repository: dns
Actor: asergeyev
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/miekg/dns/pulls/comments/18592907","id":18592907,"diff_hunk":"@@ -159,9 +159,40 @@ const (\n \t_AD = 1 << 5  // authticated data\n \t_CD = 1 << 4  // checking disabled\n \n-\t_LOC_EQUATOR = 1 << 31 // RFC 1876, Section 2.\n )\n \n+// RFC 1876, Section 2\n+const _LOC_EQUATOR = 1 << 31\n+\n+// RFC 4398, Section 2.1\n+const (\n+\tCertPKIX = 1 + iota","path":"types.go","position":12,"original_position":12,"commit_id":"efb2e66078bda450b72097b4030078c8b5c30d8f","original_commit_id":"efb2e66078bda450b72097b4030078c8b5c30d8f","user":{"login":"asergeyev","id":715656,"avatar_url":"https://avatars.githubusercontent.com/u/715656?v=2","gravatar_id":"","url":"https://api.github.com/users/asergeyev","html_url":"https://github.com/asergeyev","followers_url":"https://api.github.com/users/asergeyev/followers","following_url":"https://api.github.com/users/asergeyev/following{/other_user}","gists_url":"https://api.github.com/users/asergeyev/gists{/gist_id}","starred_url":"https://api.github.com/users/asergeyev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asergeyev/subscriptions","organizations_url":"https://api.github.com/users/asergeyev/orgs","repos_url":"https://api.github.com/users/asergeyev/repos","events_url":"https://api.github.com/users/asergeyev/events{/privacy}","received_events_url":"https://api.github.com/users/asergeyev/received_events","type":"User","site_admin":false},"body":"Actually... Say you're using CERT type... you want to find all records you got with PKIX type, you need some constants to do that. Then also if you're building CERT type record, you might need constants and string/int conversion tables available to you.","created_at":"2014-10-08T16:05:03Z","updated_at":"2014-10-08T16:05:03Z","html_url":"https://github.com/miekg/dns/pull/137#discussion_r18592907","pull_request_url":"https://api.github.com/repos/miekg/dns/pulls/137","_links":{"self":{"href":"https://api.github.com/repos/miekg/dns/pulls/comments/18592907"},"html":{"href":"https://github.com/miekg/dns/pull/137#discussion_r18592907"},"pull_request":{"href":"https://api.github.com/repos/miekg/dns/pulls/137"}}},"pull_request":{"url":"https://api.github.com/repos/miekg/dns/pulls/137","id":22394629,"html_url":"https://github.com/miekg/dns/pull/137","diff_url":"https://github.com/miekg/dns/pull/137.diff","patch_url":"https://github.com/miekg/dns/pull/137.patch","issue_url":"https://api.github.com/repos/miekg/dns/issues/137","number":137,"state":"open","locked":false,"title":"LOC typeToParserFunc fix and mnemonics for CERT rr","user":{"login":"asergeyev","id":715656,"avatar_url":"https://avatars.githubusercontent.com/u/715656?v=2","gravatar_id":"","url":"https://api.github.com/users/asergeyev","html_url":"https://github.com/asergeyev","followers_url":"https://api.github.com/users/asergeyev/followers","following_url":"https://api.github.com/users/asergeyev/following{/other_user}","gists_url":"https://api.github.com/users/asergeyev/gists{/gist_id}","starred_url":"https://api.github.com/users/asergeyev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asergeyev/subscriptions","organizations_url":"https://api.github.com/users/asergeyev/orgs","repos_url":"https://api.github.com/users/asergeyev/repos","events_url":"https://api.github.com/users/asergeyev/events{/privacy}","received_events_url":"https://api.github.com/users/asergeyev/received_events","type":"User","site_admin":false},"body":"Reverted recent true->false change for it to mitigate that.","created_at":"2014-10-08T00:50:08Z","updated_at":"2014-10-08T16:05:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aaf6e943aeda9a1e7d72cb84c307578b517601a1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/miekg/dns/pulls/137/commits","review_comments_url":"https://api.github.com/repos/miekg/dns/pulls/137/comments","review_comment_url":"https://api.github.com/repos/miekg/dns/pulls/comments/{number}","comments_url":"https://api.github.com/repos/miekg/dns/issues/137/comments","statuses_url":"https://api.github.com/repos/miekg/dns/statuses/efb2e66078bda450b72097b4030078c8b5c30d8f","head":{"label":"asergeyev:master","ref":"master","sha":"efb2e66078bda450b72097b4030078c8b5c30d8f","user":{"login":"asergeyev","id":715656,"avatar_url":"https://avatars.githubusercontent.com/u/715656?v=2","gravatar_id":"","url":"https://api.github.com/users/asergeyev","html_url":"https://github.com/asergeyev","followers_url":"https://api.github.com/users/asergeyev/followers","following_url":"https://api.github.com/users/asergeyev/following{/other_user}","gists_url":"https://api.github.com/users/asergeyev/gists{/gist_id}","starred_url":"https://api.github.com/users/asergeyev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asergeyev/subscriptions","organizations_url":"https://api.github.com/users/asergeyev/orgs","repos_url":"https://api.github.com/users/asergeyev/repos","events_url":"https://api.github.com/users/asergeyev/events{/privacy}","received_events_url":"https://api.github.com/users/asergeyev/received_events","type":"User","site_admin":false},"repo":{"id":23403955,"name":"dns","full_name":"asergeyev/dns","owner":{"login":"asergeyev","id":715656,"avatar_url":"https://avatars.githubusercontent.com/u/715656?v=2","gravatar_id":"","url":"https://api.github.com/users/asergeyev","html_url":"https://github.com/asergeyev","followers_url":"https://api.github.com/users/asergeyev/followers","following_url":"https://api.github.com/users/asergeyev/following{/other_user}","gists_url":"https://api.github.com/users/asergeyev/gists{/gist_id}","starred_url":"https://api.github.com/users/asergeyev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asergeyev/subscriptions","organizations_url":"https://api.github.com/users/asergeyev/orgs","repos_url":"https://api.github.com/users/asergeyev/repos","events_url":"https://api.github.com/users/asergeyev/events{/privacy}","received_events_url":"https://api.github.com/users/asergeyev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/asergeyev/dns","description":"DNS library in Go","fork":true,"url":"https://api.github.com/repos/asergeyev/dns","forks_url":"https://api.github.com/repos/asergeyev/dns/forks","keys_url":"https://api.github.com/repos/asergeyev/dns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/asergeyev/dns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/asergeyev/dns/teams","hooks_url":"https://api.github.com/repos/asergeyev/dns/hooks","issue_events_url":"https://api.github.com/repos/asergeyev/dns/issues/events{/number}","events_url":"https://api.github.com/repos/asergeyev/dns/events","assignees_url":"https://api.github.com/repos/asergeyev/dns/assignees{/user}","branches_url":"https://api.github.com/repos/asergeyev/dns/branches{/branch}","tags_url":"https://api.github.com/repos/asergeyev/dns/tags","blobs_url":"https://api.github.com/repos/asergeyev/dns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/asergeyev/dns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/asergeyev/dns/git/refs{/sha}","trees_url":"https://api.github.com/repos/asergeyev/dns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/asergeyev/dns/statuses/{sha}","languages_url":"https://api.github.com/repos/asergeyev/dns/languages","stargazers_url":"https://api.github.com/repos/asergeyev/dns/stargazers","contributors_url":"https://api.github.com/repos/asergeyev/dns/contributors","subscribers_url":"https://api.github.com/repos/asergeyev/dns/subscribers","subscription_url":"https://api.github.com/repos/asergeyev/dns/subscription","commits_url":"https://api.github.com/repos/asergeyev/dns/commits{/sha}","git_commits_url":"https://api.github.com/repos/asergeyev/dns/git/commits{/sha}","comments_url":"https://api.github.com/repos/asergeyev/dns/comments{/number}","issue_comment_url":"https://api.github.com/repos/asergeyev/dns/issues/comments/{number}","contents_url":"https://api.github.com/repos/asergeyev/dns/contents/{+path}","compare_url":"https://api.github.com/repos/asergeyev/dns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/asergeyev/dns/merges","archive_url":"https://api.github.com/repos/asergeyev/dns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/asergeyev/dns/downloads","issues_url":"https://api.github.com/repos/asergeyev/dns/issues{/number}","pulls_url":"https://api.github.com/repos/asergeyev/dns/pulls{/number}","milestones_url":"https://api.github.com/repos/asergeyev/dns/milestones{/number}","notifications_url":"https://api.github.com/repos/asergeyev/dns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/asergeyev/dns/labels{/name}","releases_url":"https://api.github.com/repos/asergeyev/dns/releases{/id}","created_at":"2014-08-27T20:15:35Z","updated_at":"2014-08-27T20:28:28Z","pushed_at":"2014-10-08T01:28:24Z","git_url":"git://github.com/asergeyev/dns.git","ssh_url":"git@github.com:asergeyev/dns.git","clone_url":"https://github.com/asergeyev/dns.git","svn_url":"https://github.com/asergeyev/dns","homepage":"http://miek.nl/posts/2014/Aug/16/go-dns-package/","size":10167,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"miekg:master","ref":"master","sha":"d05369e62919c0bf5613fc988d310a1b338a3db3","user":{"login":"miekg","id":353371,"avatar_url":"https://avatars.githubusercontent.com/u/353371?v=2","gravatar_id":"","url":"https://api.github.com/users/miekg","html_url":"https://github.com/miekg","followers_url":"https://api.github.com/users/miekg/followers","following_url":"https://api.github.com/users/miekg/following{/other_user}","gists_url":"https://api.github.com/users/miekg/gists{/gist_id}","starred_url":"https://api.github.com/users/miekg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miekg/subscriptions","organizations_url":"https://api.github.com/users/miekg/orgs","repos_url":"https://api.github.com/users/miekg/repos","events_url":"https://api.github.com/users/miekg/events{/privacy}","received_events_url":"https://api.github.com/users/miekg/received_events","type":"User","site_admin":false},"repo":{"id":815644,"name":"dns","full_name":"miekg/dns","owner":{"login":"miekg","id":353371,"avatar_url":"https://avatars.githubusercontent.com/u/353371?v=2","gravatar_id":"","url":"https://api.github.com/users/miekg","html_url":"https://github.com/miekg","followers_url":"https://api.github.com/users/miekg/followers","following_url":"https://api.github.com/users/miekg/following{/other_user}","gists_url":"https://api.github.com/users/miekg/gists{/gist_id}","starred_url":"https://api.github.com/users/miekg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miekg/subscriptions","organizations_url":"https://api.github.com/users/miekg/orgs","repos_url":"https://api.github.com/users/miekg/repos","events_url":"https://api.github.com/users/miekg/events{/privacy}","received_events_url":"https://api.github.com/users/miekg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/miekg/dns","description":"DNS library in Go","fork":false,"url":"https://api.github.com/repos/miekg/dns","forks_url":"https://api.github.com/repos/miekg/dns/forks","keys_url":"https://api.github.com/repos/miekg/dns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/miekg/dns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/miekg/dns/teams","hooks_url":"https://api.github.com/repos/miekg/dns/hooks","issue_events_url":"https://api.github.com/repos/miekg/dns/issues/events{/number}","events_url":"https://api.github.com/repos/miekg/dns/events","assignees_url":"https://api.github.com/repos/miekg/dns/assignees{/user}","branches_url":"https://api.github.com/repos/miekg/dns/branches{/branch}","tags_url":"https://api.github.com/repos/miekg/dns/tags","blobs_url":"https://api.github.com/repos/miekg/dns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/miekg/dns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/miekg/dns/git/refs{/sha}","trees_url":"https://api.github.com/repos/miekg/dns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/miekg/dns/statuses/{sha}","languages_url":"https://api.github.com/repos/miekg/dns/languages","stargazers_url":"https://api.github.com/repos/miekg/dns/stargazers","contributors_url":"https://api.github.com/repos/miekg/dns/contributors","subscribers_url":"https://api.github.com/repos/miekg/dns/subscribers","subscription_url":"https://api.github.com/repos/miekg/dns/subscription","commits_url":"https://api.github.com/repos/miekg/dns/commits{/sha}","git_commits_url":"https://api.github.com/repos/miekg/dns/git/commits{/sha}","comments_url":"https://api.github.com/repos/miekg/dns/comments{/number}","issue_comment_url":"https://api.github.com/repos/miekg/dns/issues/comments/{number}","contents_url":"https://api.github.com/repos/miekg/dns/contents/{+path}","compare_url":"https://api.github.com/repos/miekg/dns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/miekg/dns/merges","archive_url":"https://api.github.com/repos/miekg/dns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/miekg/dns/downloads","issues_url":"https://api.github.com/repos/miekg/dns/issues{/number}","pulls_url":"https://api.github.com/repos/miekg/dns/pulls{/number}","milestones_url":"https://api.github.com/repos/miekg/dns/milestones{/number}","notifications_url":"https://api.github.com/repos/miekg/dns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/miekg/dns/labels{/name}","releases_url":"https://api.github.com/repos/miekg/dns/releases{/id}","created_at":"2010-08-03T21:56:23Z","updated_at":"2014-10-08T13:38:53Z","pushed_at":"2014-10-08T14:35:34Z","git_url":"git://github.com/miekg/dns.git","ssh_url":"git@github.com:miekg/dns.git","clone_url":"https://github.com/miekg/dns.git","svn_url":"https://github.com/miekg/dns","homepage":"http://miek.nl/posts/2014/Aug/16/go-dns-package/","size":13186,"stargazers_count":685,"watchers_count":685,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":94,"mirror_url":null,"open_issues_count":5,"forks":94,"open_issues":5,"watchers":685,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/miekg/dns/pulls/137"},"html":{"href":"https://github.com/miekg/dns/pull/137"},"issue":{"href":"https://api.github.com/repos/miekg/dns/issues/137"},"comments":{"href":"https://api.github.com/repos/miekg/dns/issues/137/comments"},"review_comments":{"href":"https://api.github.com/repos/miekg/dns/pulls/137/comments"},"review_comment":{"href":"https://api.github.com/repos/miekg/dns/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/miekg/dns/pulls/137/commits"},"statuses":{"href":"https://api.github.com/repos/miekg/dns/statuses/efb2e66078bda450b72097b4030078c8b5c30d8f"}}}}