GitHub PullRequestReviewCommentEvent at 2014-06-13 23:03:09
Repository: flixel
Actor: Gama11
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/HaxeFlixel/flixel/pulls/comments/13775755","id":13775755,"diff_hunk":"@@ -0,0 +1,76 @@\n+package flixel.util.helpers;\n+\n+import flixel.math.FlxPoint;\n+import flixel.util.FlxStringUtil;\n+\n+/**\n+ * Helper object for holding beginning minimum/maximum and ending minimum/maximum values of FlxPoints, which have both an x and y component.\n+ */\n+class FlxPointRangeBounds extends Range<Bounds<FlxPoint>>","path":"flixel/util/helpers/FlxPointRangeBounds.hx","position":9,"original_position":9,"commit_id":"2404c0d016cf8d2c9e603372c94e57b89806d5b0","original_commit_id":"2404c0d016cf8d2c9e603372c94e57b89806d5b0","user":{"login":"Gama11","id":2620907,"avatar_url":"https://avatars.githubusercontent.com/u/2620907?","gravatar_id":"faf350239a4a63b2ba97d90e51860c79","url":"https://api.github.com/users/Gama11","html_url":"https://github.com/Gama11","followers_url":"https://api.github.com/users/Gama11/followers","following_url":"https://api.github.com/users/Gama11/following{/other_user}","gists_url":"https://api.github.com/users/Gama11/gists{/gist_id}","starred_url":"https://api.github.com/users/Gama11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gama11/subscriptions","organizations_url":"https://api.github.com/users/Gama11/orgs","repos_url":"https://api.github.com/users/Gama11/repos","events_url":"https://api.github.com/users/Gama11/events{/privacy}","received_events_url":"https://api.github.com/users/Gama11/received_events","type":"User","site_admin":false},"body":"This class needs some sort of destroy() function so the points can be recycled / `put()`.","created_at":"2014-06-13T23:03:09Z","updated_at":"2014-06-13T23:03:09Z","html_url":"https://github.com/HaxeFlixel/flixel/pull/1174#discussion_r13775755","pull_request_url":"https://api.github.com/repos/HaxeFlixel/flixel/pulls/1174","_links":{"self":{"href":"https://api.github.com/repos/HaxeFlixel/flixel/pulls/comments/13775755"},"html":{"href":"https://github.com/HaxeFlixel/flixel/pull/1174#discussion_r13775755"},"pull_request":{"href":"https://api.github.com/repos/HaxeFlixel/flixel/pulls/1174"}}},"pull_request":{"url":"https://api.github.com/repos/HaxeFlixel/flixel/pulls/1174","id":17083039,"html_url":"https://github.com/HaxeFlixel/flixel/pull/1174","diff_url":"https://github.com/HaxeFlixel/flixel/pull/1174.diff","patch_url":"https://github.com/HaxeFlixel/flixel/pull/1174.patch","issue_url":"https://api.github.com/repos/HaxeFlixel/flixel/issues/1174","number":1174,"state":"open","title":"FlxEmitter refactor (do not merge), closes #587","user":{"login":"steverichey","id":3226635,"avatar_url":"https://avatars.githubusercontent.com/u/3226635?","gravatar_id":"05bd5970500641dbba5753aef793dd44","url":"https://api.github.com/users/steverichey","html_url":"https://github.com/steverichey","followers_url":"https://api.github.com/users/steverichey/followers","following_url":"https://api.github.com/users/steverichey/following{/other_user}","gists_url":"https://api.github.com/users/steverichey/gists{/gist_id}","starred_url":"https://api.github.com/users/steverichey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steverichey/subscriptions","organizations_url":"https://api.github.com/users/steverichey/orgs","repos_url":"https://api.github.com/users/steverichey/repos","events_url":"https://api.github.com/users/steverichey/events{/privacy}","received_events_url":"https://api.github.com/users/steverichey/received_events","type":"User","site_admin":false},"body":"This is a pull request for a refactoring of `FlxEmitter`, which has several goals:\r\n\r\n* Merge `FlxEmitter` and `FlxEmitterExt`\r\n* Remove redundant variables (`lifespan` and `life`, `x` and `y` and `xPosition` and `yPosition`\r\n* Create a consistent logic for setting start, end, min, and max values (see `Range`, `Bounds`, `RangeBounds` and `FlxPointRangeBounds`)\r\n* Rename variables to be consistent with `FlxSprite` (`angularVelocity` instead of `rotation`)\r\n* Allow greater control over start, end, min, and max values\r\n\r\nThis is very much a WIP, but I wanted to get some feedback on the changes early. Usage:\r\n\r\n````\r\n_emitter = new FlxEmitter(10, 10, 200); // unchanged\r\n_emitter.velocity.setAll(100, -50, null, null, 200, 50); // finer control over velocity\r\n_emitter.elasticity.setAll(0.8); // elasticity vs. bounce\r\n````\r\n\r\nBasically everything will be `Bounds`, `RangeBounds`, `Range`, or `FlxPointRangeBounds`, allowing devs to set variables with a logical method (e.g. `velocity.start.min.x = 5;`) or all at once via `setAll()`.\r\n\r\nComments appreciated! Thanks!","created_at":"2014-06-12T22:10:16Z","updated_at":"2014-06-13T23:03:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b8a5bdf4c2720eca55d63cbdae7dfe8903bdfcd9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/HaxeFlixel/flixel/pulls/1174/commits","review_comments_url":"https://api.github.com/repos/HaxeFlixel/flixel/pulls/1174/comments","review_comment_url":"https://api.github.com/repos/HaxeFlixel/flixel/pulls/comments/{number}","comments_url":"https://api.github.com/repos/HaxeFlixel/flixel/issues/1174/comments","statuses_url":"https://api.github.com/repos/HaxeFlixel/flixel/statuses/2404c0d016cf8d2c9e603372c94e57b89806d5b0","head":{"label":"steverichey:dev","ref":"dev","sha":"2404c0d016cf8d2c9e603372c94e57b89806d5b0","user":{"login":"steverichey","id":3226635,"avatar_url":"https://avatars.githubusercontent.com/u/3226635?","gravatar_id":"05bd5970500641dbba5753aef793dd44","url":"https://api.github.com/users/steverichey","html_url":"https://github.com/steverichey","followers_url":"https://api.github.com/users/steverichey/followers","following_url":"https://api.github.com/users/steverichey/following{/other_user}","gists_url":"https://api.github.com/users/steverichey/gists{/gist_id}","starred_url":"https://api.github.com/users/steverichey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steverichey/subscriptions","organizations_url":"https://api.github.com/users/steverichey/orgs","repos_url":"https://api.github.com/users/steverichey/repos","events_url":"https://api.github.com/users/steverichey/events{/privacy}","received_events_url":"https://api.github.com/users/steverichey/received_events","type":"User","site_admin":false},"repo":{"id":20725896,"name":"flixel","full_name":"steverichey/flixel","owner":{"login":"steverichey","id":3226635,"avatar_url":"https://avatars.githubusercontent.com/u/3226635?","gravatar_id":"05bd5970500641dbba5753aef793dd44","url":"https://api.github.com/users/steverichey","html_url":"https://github.com/steverichey","followers_url":"https://api.github.com/users/steverichey/followers","following_url":"https://api.github.com/users/steverichey/following{/other_user}","gists_url":"https://api.github.com/users/steverichey/gists{/gist_id}","starred_url":"https://api.github.com/users/steverichey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steverichey/subscriptions","organizations_url":"https://api.github.com/users/steverichey/orgs","repos_url":"https://api.github.com/users/steverichey/repos","events_url":"https://api.github.com/users/steverichey/events{/privacy}","received_events_url":"https://api.github.com/users/steverichey/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/steverichey/flixel","description":"Free, cross-platform 2D game engine powered by Haxe and OpenFL","fork":true,"url":"https://api.github.com/repos/steverichey/flixel","forks_url":"https://api.github.com/repos/steverichey/flixel/forks","keys_url":"https://api.github.com/repos/steverichey/flixel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/steverichey/flixel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/steverichey/flixel/teams","hooks_url":"https://api.github.com/repos/steverichey/flixel/hooks","issue_events_url":"https://api.github.com/repos/steverichey/flixel/issues/events{/number}","events_url":"https://api.github.com/repos/steverichey/flixel/events","assignees_url":"https://api.github.com/repos/steverichey/flixel/assignees{/user}","branches_url":"https://api.github.com/repos/steverichey/flixel/branches{/branch}","tags_url":"https://api.github.com/repos/steverichey/flixel/tags","blobs_url":"https://api.github.com/repos/steverichey/flixel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/steverichey/flixel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/steverichey/flixel/git/refs{/sha}","trees_url":"https://api.github.com/repos/steverichey/flixel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/steverichey/flixel/statuses/{sha}","languages_url":"https://api.github.com/repos/steverichey/flixel/languages","stargazers_url":"https://api.github.com/repos/steverichey/flixel/stargazers","contributors_url":"https://api.github.com/repos/steverichey/flixel/contributors","subscribers_url":"https://api.github.com/repos/steverichey/flixel/subscribers","subscription_url":"https://api.github.com/repos/steverichey/flixel/subscription","commits_url":"https://api.github.com/repos/steverichey/flixel/commits{/sha}","git_commits_url":"https://api.github.com/repos/steverichey/flixel/git/commits{/sha}","comments_url":"https://api.github.com/repos/steverichey/flixel/comments{/number}","issue_comment_url":"https://api.github.com/repos/steverichey/flixel/issues/comments/{number}","contents_url":"https://api.github.com/repos/steverichey/flixel/contents/{+path}","compare_url":"https://api.github.com/repos/steverichey/flixel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/steverichey/flixel/merges","archive_url":"https://api.github.com/repos/steverichey/flixel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/steverichey/flixel/downloads","issues_url":"https://api.github.com/repos/steverichey/flixel/issues{/number}","pulls_url":"https://api.github.com/repos/steverichey/flixel/pulls{/number}","milestones_url":"https://api.github.com/repos/steverichey/flixel/milestones{/number}","notifications_url":"https://api.github.com/repos/steverichey/flixel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/steverichey/flixel/labels{/name}","releases_url":"https://api.github.com/repos/steverichey/flixel/releases{/id}","created_at":"2014-06-11T13:20:11Z","updated_at":"2014-06-13T22:28:41Z","pushed_at":"2014-06-13T22:28:45Z","git_url":"git://github.com/steverichey/flixel.git","ssh_url":"git@github.com:steverichey/flixel.git","clone_url":"https://github.com/steverichey/flixel.git","svn_url":"https://github.com/steverichey/flixel","homepage":"http://www.haxeflixel.com/","size":35858,"stargazers_count":0,"watchers_count":0,"language":"Haxe","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"HaxeFlixel:dev","ref":"dev","sha":"d059b528f38933133b3e1518f7b2e44fa50fcd39","user":{"login":"HaxeFlixel","id":4309553,"avatar_url":"https://avatars.githubusercontent.com/u/4309553?","gravatar_id":"96155ad8e262fda9d8eea953c629535c","url":"https://api.github.com/users/HaxeFlixel","html_url":"https://github.com/HaxeFlixel","followers_url":"https://api.github.com/users/HaxeFlixel/followers","following_url":"https://api.github.com/users/HaxeFlixel/following{/other_user}","gists_url":"https://api.github.com/users/HaxeFlixel/gists{/gist_id}","starred_url":"https://api.github.com/users/HaxeFlixel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HaxeFlixel/subscriptions","organizations_url":"https://api.github.com/users/HaxeFlixel/orgs","repos_url":"https://api.github.com/users/HaxeFlixel/repos","events_url":"https://api.github.com/users/HaxeFlixel/events{/privacy}","received_events_url":"https://api.github.com/users/HaxeFlixel/received_events","type":"Organization","site_admin":false},"repo":{"id":2101031,"name":"flixel","full_name":"HaxeFlixel/flixel","owner":{"login":"HaxeFlixel","id":4309553,"avatar_url":"https://avatars.githubusercontent.com/u/4309553?","gravatar_id":"96155ad8e262fda9d8eea953c629535c","url":"https://api.github.com/users/HaxeFlixel","html_url":"https://github.com/HaxeFlixel","followers_url":"https://api.github.com/users/HaxeFlixel/followers","following_url":"https://api.github.com/users/HaxeFlixel/following{/other_user}","gists_url":"https://api.github.com/users/HaxeFlixel/gists{/gist_id}","starred_url":"https://api.github.com/users/HaxeFlixel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HaxeFlixel/subscriptions","organizations_url":"https://api.github.com/users/HaxeFlixel/orgs","repos_url":"https://api.github.com/users/HaxeFlixel/repos","events_url":"https://api.github.com/users/HaxeFlixel/events{/privacy}","received_events_url":"https://api.github.com/users/HaxeFlixel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HaxeFlixel/flixel","description":"Free, cross-platform 2D game engine powered by Haxe and OpenFL","fork":false,"url":"https://api.github.com/repos/HaxeFlixel/flixel","forks_url":"https://api.github.com/repos/HaxeFlixel/flixel/forks","keys_url":"https://api.github.com/repos/HaxeFlixel/flixel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HaxeFlixel/flixel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HaxeFlixel/flixel/teams","hooks_url":"https://api.github.com/repos/HaxeFlixel/flixel/hooks","issue_events_url":"https://api.github.com/repos/HaxeFlixel/flixel/issues/events{/number}","events_url":"https://api.github.com/repos/HaxeFlixel/flixel/events","assignees_url":"https://api.github.com/repos/HaxeFlixel/flixel/assignees{/user}","branches_url":"https://api.github.com/repos/HaxeFlixel/flixel/branches{/branch}","tags_url":"https://api.github.com/repos/HaxeFlixel/flixel/tags","blobs_url":"https://api.github.com/repos/HaxeFlixel/flixel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HaxeFlixel/flixel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HaxeFlixel/flixel/git/refs{/sha}","trees_url":"https://api.github.com/repos/HaxeFlixel/flixel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HaxeFlixel/flixel/statuses/{sha}","languages_url":"https://api.github.com/repos/HaxeFlixel/flixel/languages","stargazers_url":"https://api.github.com/repos/HaxeFlixel/flixel/stargazers","contributors_url":"https://api.github.com/repos/HaxeFlixel/flixel/contributors","subscribers_url":"https://api.github.com/repos/HaxeFlixel/flixel/subscribers","subscription_url":"https://api.github.com/repos/HaxeFlixel/flixel/subscription","commits_url":"https://api.github.com/repos/HaxeFlixel/flixel/commits{/sha}","git_commits_url":"https://api.github.com/repos/HaxeFlixel/flixel/git/commits{/sha}","comments_url":"https://api.github.com/repos/HaxeFlixel/flixel/comments{/number}","issue_comment_url":"https://api.github.com/repos/HaxeFlixel/flixel/issues/comments/{number}","contents_url":"https://api.github.com/repos/HaxeFlixel/flixel/contents/{+path}","compare_url":"https://api.github.com/repos/HaxeFlixel/flixel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HaxeFlixel/flixel/merges","archive_url":"https://api.github.com/repos/HaxeFlixel/flixel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HaxeFlixel/flixel/downloads","issues_url":"https://api.github.com/repos/HaxeFlixel/flixel/issues{/number}","pulls_url":"https://api.github.com/repos/HaxeFlixel/flixel/pulls{/number}","milestones_url":"https://api.github.com/repos/HaxeFlixel/flixel/milestones{/number}","notifications_url":"https://api.github.com/repos/HaxeFlixel/flixel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HaxeFlixel/flixel/labels{/name}","releases_url":"https://api.github.com/repos/HaxeFlixel/flixel/releases{/id}","created_at":"2011-07-25T13:12:48Z","updated_at":"2014-06-13T19:31:57Z","pushed_at":"2014-06-13T19:31:57Z","git_url":"git://github.com/HaxeFlixel/flixel.git","ssh_url":"git@github.com:HaxeFlixel/flixel.git","clone_url":"https://github.com/HaxeFlixel/flixel.git","svn_url":"https://github.com/HaxeFlixel/flixel","homepage":"http://www.haxeflixel.com/","size":35858,"stargazers_count":525,"watchers_count":525,"language":"Haxe","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":129,"mirror_url":null,"open_issues_count":90,"forks":129,"open_issues":90,"watchers":525,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/HaxeFlixel/flixel/pulls/1174"},"html":{"href":"https://github.com/HaxeFlixel/flixel/pull/1174"},"issue":{"href":"https://api.github.com/repos/HaxeFlixel/flixel/issues/1174"},"comments":{"href":"https://api.github.com/repos/HaxeFlixel/flixel/issues/1174/comments"},"review_comments":{"href":"https://api.github.com/repos/HaxeFlixel/flixel/pulls/1174/comments"},"review_comment":{"href":"https://api.github.com/repos/HaxeFlixel/flixel/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/HaxeFlixel/flixel/pulls/1174/commits"},"statuses":{"href":"https://api.github.com/repos/HaxeFlixel/flixel/statuses/2404c0d016cf8d2c9e603372c94e57b89806d5b0"}}}}