GitHub PullRequestReviewCommentEvent at 2014-10-16 13:32:50
Repository: inspire-next
Actor: jmartinm
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/inspirehep/inspire-next/pulls/comments/18954845","id":18954845,"diff_hunk":"@@ -33,14 +33,26 @@ define(function(require, exports, module) {\n \n       special_mapping: {\n         article: function(data) {\n+\n+          var category_list = \"\";\n+\n+          if (typeof data.categories == \"string\") {\n+            var category_list = data.categories;","path":"inspire/modules/deposit/static/js/deposit/data_sources/arxiv.js","position":8,"original_position":8,"commit_id":"8e8532d440d9c4b193ae9b5d3361f2c8084d7ff9","original_commit_id":"8e8532d440d9c4b193ae9b5d3361f2c8084d7ff9","user":{"login":"jmartinm","id":580727,"avatar_url":"https://avatars.githubusercontent.com/u/580727?v=2","gravatar_id":"","url":"https://api.github.com/users/jmartinm","html_url":"https://github.com/jmartinm","followers_url":"https://api.github.com/users/jmartinm/followers","following_url":"https://api.github.com/users/jmartinm/following{/other_user}","gists_url":"https://api.github.com/users/jmartinm/gists{/gist_id}","starred_url":"https://api.github.com/users/jmartinm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmartinm/subscriptions","organizations_url":"https://api.github.com/users/jmartinm/orgs","repos_url":"https://api.github.com/users/jmartinm/repos","events_url":"https://api.github.com/users/jmartinm/events{/privacy}","received_events_url":"https://api.github.com/users/jmartinm/received_events","type":"User","site_admin":false},"body":"No need for ```var``` here. The variable is already defined on top.\r\n\r\nAlso better to use ```===``` instead of ```==```","created_at":"2014-10-16T13:32:50Z","updated_at":"2014-10-16T13:32:50Z","html_url":"https://github.com/inspirehep/inspire-next/pull/94#discussion_r18954845","pull_request_url":"https://api.github.com/repos/inspirehep/inspire-next/pulls/94","_links":{"self":{"href":"https://api.github.com/repos/inspirehep/inspire-next/pulls/comments/18954845"},"html":{"href":"https://github.com/inspirehep/inspire-next/pull/94#discussion_r18954845"},"pull_request":{"href":"https://api.github.com/repos/inspirehep/inspire-next/pulls/94"}}},"pull_request":{"url":"https://api.github.com/repos/inspirehep/inspire-next/pulls/94","id":21155095,"html_url":"https://github.com/inspirehep/inspire-next/pull/94","diff_url":"https://github.com/inspirehep/inspire-next/pull/94.diff","patch_url":"https://github.com/inspirehep/inspire-next/pull/94.patch","issue_url":"https://api.github.com/repos/inspirehep/inspire-next/issues/94","number":94,"state":"open","locked":false,"title":"extra arXiv mapping","user":{"login":"pedrogaudencio","id":416548,"avatar_url":"https://avatars.githubusercontent.com/u/416548?v=2","gravatar_id":"","url":"https://api.github.com/users/pedrogaudencio","html_url":"https://github.com/pedrogaudencio","followers_url":"https://api.github.com/users/pedrogaudencio/followers","following_url":"https://api.github.com/users/pedrogaudencio/following{/other_user}","gists_url":"https://api.github.com/users/pedrogaudencio/gists{/gist_id}","starred_url":"https://api.github.com/users/pedrogaudencio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pedrogaudencio/subscriptions","organizations_url":"https://api.github.com/users/pedrogaudencio/orgs","repos_url":"https://api.github.com/users/pedrogaudencio/repos","events_url":"https://api.github.com/users/pedrogaudencio/events{/privacy}","received_events_url":"https://api.github.com/users/pedrogaudencio/received_events","type":"User","site_admin":false},"body":"Add extra fields from arxiv (same as in oaiharvest) to the form fields (see [asana task](https://app.asana.com/0/8772567966361/12984151070479)).\r\n\r\narXiv journal names mapping depends on https://github.com/jmartinm/inspire-next/commits/overlay-changes.","created_at":"2014-09-12T14:13:49Z","updated_at":"2014-10-16T13:32:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ecf621ac310e225ea27d5987bb07330ac45baaf7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/inspirehep/inspire-next/pulls/94/commits","review_comments_url":"https://api.github.com/repos/inspirehep/inspire-next/pulls/94/comments","review_comment_url":"https://api.github.com/repos/inspirehep/inspire-next/pulls/comments/{number}","comments_url":"https://api.github.com/repos/inspirehep/inspire-next/issues/94/comments","statuses_url":"https://api.github.com/repos/inspirehep/inspire-next/statuses/8e8532d440d9c4b193ae9b5d3361f2c8084d7ff9","head":{"label":"pedrogaudencio:extra-arxiv","ref":"extra-arxiv","sha":"8e8532d440d9c4b193ae9b5d3361f2c8084d7ff9","user":{"login":"pedrogaudencio","id":416548,"avatar_url":"https://avatars.githubusercontent.com/u/416548?v=2","gravatar_id":"","url":"https://api.github.com/users/pedrogaudencio","html_url":"https://github.com/pedrogaudencio","followers_url":"https://api.github.com/users/pedrogaudencio/followers","following_url":"https://api.github.com/users/pedrogaudencio/following{/other_user}","gists_url":"https://api.github.com/users/pedrogaudencio/gists{/gist_id}","starred_url":"https://api.github.com/users/pedrogaudencio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pedrogaudencio/subscriptions","organizations_url":"https://api.github.com/users/pedrogaudencio/orgs","repos_url":"https://api.github.com/users/pedrogaudencio/repos","events_url":"https://api.github.com/users/pedrogaudencio/events{/privacy}","received_events_url":"https://api.github.com/users/pedrogaudencio/received_events","type":"User","site_admin":false},"repo":{"id":17870297,"name":"inspire-next","full_name":"pedrogaudencio/inspire-next","owner":{"login":"pedrogaudencio","id":416548,"avatar_url":"https://avatars.githubusercontent.com/u/416548?v=2","gravatar_id":"","url":"https://api.github.com/users/pedrogaudencio","html_url":"https://github.com/pedrogaudencio","followers_url":"https://api.github.com/users/pedrogaudencio/followers","following_url":"https://api.github.com/users/pedrogaudencio/following{/other_user}","gists_url":"https://api.github.com/users/pedrogaudencio/gists{/gist_id}","starred_url":"https://api.github.com/users/pedrogaudencio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pedrogaudencio/subscriptions","organizations_url":"https://api.github.com/users/pedrogaudencio/orgs","repos_url":"https://api.github.com/users/pedrogaudencio/repos","events_url":"https://api.github.com/users/pedrogaudencio/events{/privacy}","received_events_url":"https://api.github.com/users/pedrogaudencio/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pedrogaudencio/inspire-next","description":"INSPIRE overlay repository to be used with Invenio's NEXT branch","fork":true,"url":"https://api.github.com/repos/pedrogaudencio/inspire-next","forks_url":"https://api.github.com/repos/pedrogaudencio/inspire-next/forks","keys_url":"https://api.github.com/repos/pedrogaudencio/inspire-next/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pedrogaudencio/inspire-next/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pedrogaudencio/inspire-next/teams","hooks_url":"https://api.github.com/repos/pedrogaudencio/inspire-next/hooks","issue_events_url":"https://api.github.com/repos/pedrogaudencio/inspire-next/issues/events{/number}","events_url":"https://api.github.com/repos/pedrogaudencio/inspire-next/events","assignees_url":"https://api.github.com/repos/pedrogaudencio/inspire-next/assignees{/user}","branches_url":"https://api.github.com/repos/pedrogaudencio/inspire-next/branches{/branch}","tags_url":"https://api.github.com/repos/pedrogaudencio/inspire-next/tags","blobs_url":"https://api.github.com/repos/pedrogaudencio/inspire-next/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pedrogaudencio/inspire-next/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pedrogaudencio/inspire-next/git/refs{/sha}","trees_url":"https://api.github.com/repos/pedrogaudencio/inspire-next/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pedrogaudencio/inspire-next/statuses/{sha}","languages_url":"https://api.github.com/repos/pedrogaudencio/inspire-next/languages","stargazers_url":"https://api.github.com/repos/pedrogaudencio/inspire-next/stargazers","contributors_url":"https://api.github.com/repos/pedrogaudencio/inspire-next/contributors","subscribers_url":"https://api.github.com/repos/pedrogaudencio/inspire-next/subscribers","subscription_url":"https://api.github.com/repos/pedrogaudencio/inspire-next/subscription","commits_url":"https://api.github.com/repos/pedrogaudencio/inspire-next/commits{/sha}","git_commits_url":"https://api.github.com/repos/pedrogaudencio/inspire-next/git/commits{/sha}","comments_url":"https://api.github.com/repos/pedrogaudencio/inspire-next/comments{/number}","issue_comment_url":"https://api.github.com/repos/pedrogaudencio/inspire-next/issues/comments/{number}","contents_url":"https://api.github.com/repos/pedrogaudencio/inspire-next/contents/{+path}","compare_url":"https://api.github.com/repos/pedrogaudencio/inspire-next/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pedrogaudencio/inspire-next/merges","archive_url":"https://api.github.com/repos/pedrogaudencio/inspire-next/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pedrogaudencio/inspire-next/downloads","issues_url":"https://api.github.com/repos/pedrogaudencio/inspire-next/issues{/number}","pulls_url":"https://api.github.com/repos/pedrogaudencio/inspire-next/pulls{/number}","milestones_url":"https://api.github.com/repos/pedrogaudencio/inspire-next/milestones{/number}","notifications_url":"https://api.github.com/repos/pedrogaudencio/inspire-next/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pedrogaudencio/inspire-next/labels{/name}","releases_url":"https://api.github.com/repos/pedrogaudencio/inspire-next/releases{/id}","created_at":"2014-03-18T15:05:56Z","updated_at":"2014-07-08T08:57:19Z","pushed_at":"2014-10-16T13:11:58Z","git_url":"git://github.com/pedrogaudencio/inspire-next.git","ssh_url":"git@github.com:pedrogaudencio/inspire-next.git","clone_url":"https://github.com/pedrogaudencio/inspire-next.git","svn_url":"https://github.com/pedrogaudencio/inspire-next","homepage":null,"size":5565,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"sprint-3"}},"base":{"label":"inspirehep:master","ref":"master","sha":"6b6c433653ab8b2f9a70666717a41455a0c73815","user":{"login":"inspirehep","id":356664,"avatar_url":"https://avatars.githubusercontent.com/u/356664?v=2","gravatar_id":"","url":"https://api.github.com/users/inspirehep","html_url":"https://github.com/inspirehep","followers_url":"https://api.github.com/users/inspirehep/followers","following_url":"https://api.github.com/users/inspirehep/following{/other_user}","gists_url":"https://api.github.com/users/inspirehep/gists{/gist_id}","starred_url":"https://api.github.com/users/inspirehep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inspirehep/subscriptions","organizations_url":"https://api.github.com/users/inspirehep/orgs","repos_url":"https://api.github.com/users/inspirehep/repos","events_url":"https://api.github.com/users/inspirehep/events{/privacy}","received_events_url":"https://api.github.com/users/inspirehep/received_events","type":"Organization","site_admin":false},"repo":{"id":15221515,"name":"inspire-next","full_name":"inspirehep/inspire-next","owner":{"login":"inspirehep","id":356664,"avatar_url":"https://avatars.githubusercontent.com/u/356664?v=2","gravatar_id":"","url":"https://api.github.com/users/inspirehep","html_url":"https://github.com/inspirehep","followers_url":"https://api.github.com/users/inspirehep/followers","following_url":"https://api.github.com/users/inspirehep/following{/other_user}","gists_url":"https://api.github.com/users/inspirehep/gists{/gist_id}","starred_url":"https://api.github.com/users/inspirehep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inspirehep/subscriptions","organizations_url":"https://api.github.com/users/inspirehep/orgs","repos_url":"https://api.github.com/users/inspirehep/repos","events_url":"https://api.github.com/users/inspirehep/events{/privacy}","received_events_url":"https://api.github.com/users/inspirehep/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/inspirehep/inspire-next","description":"INSPIRE overlay repository to be used with Invenio's NEXT branch","fork":false,"url":"https://api.github.com/repos/inspirehep/inspire-next","forks_url":"https://api.github.com/repos/inspirehep/inspire-next/forks","keys_url":"https://api.github.com/repos/inspirehep/inspire-next/keys{/key_id}","collaborators_url":"https://api.github.com/repos/inspirehep/inspire-next/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/inspirehep/inspire-next/teams","hooks_url":"https://api.github.com/repos/inspirehep/inspire-next/hooks","issue_events_url":"https://api.github.com/repos/inspirehep/inspire-next/issues/events{/number}","events_url":"https://api.github.com/repos/inspirehep/inspire-next/events","assignees_url":"https://api.github.com/repos/inspirehep/inspire-next/assignees{/user}","branches_url":"https://api.github.com/repos/inspirehep/inspire-next/branches{/branch}","tags_url":"https://api.github.com/repos/inspirehep/inspire-next/tags","blobs_url":"https://api.github.com/repos/inspirehep/inspire-next/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/inspirehep/inspire-next/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/inspirehep/inspire-next/git/refs{/sha}","trees_url":"https://api.github.com/repos/inspirehep/inspire-next/git/trees{/sha}","statuses_url":"https://api.github.com/repos/inspirehep/inspire-next/statuses/{sha}","languages_url":"https://api.github.com/repos/inspirehep/inspire-next/languages","stargazers_url":"https://api.github.com/repos/inspirehep/inspire-next/stargazers","contributors_url":"https://api.github.com/repos/inspirehep/inspire-next/contributors","subscribers_url":"https://api.github.com/repos/inspirehep/inspire-next/subscribers","subscription_url":"https://api.github.com/repos/inspirehep/inspire-next/subscription","commits_url":"https://api.github.com/repos/inspirehep/inspire-next/commits{/sha}","git_commits_url":"https://api.github.com/repos/inspirehep/inspire-next/git/commits{/sha}","comments_url":"https://api.github.com/repos/inspirehep/inspire-next/comments{/number}","issue_comment_url":"https://api.github.com/repos/inspirehep/inspire-next/issues/comments/{number}","contents_url":"https://api.github.com/repos/inspirehep/inspire-next/contents/{+path}","compare_url":"https://api.github.com/repos/inspirehep/inspire-next/compare/{base}...{head}","merges_url":"https://api.github.com/repos/inspirehep/inspire-next/merges","archive_url":"https://api.github.com/repos/inspirehep/inspire-next/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/inspirehep/inspire-next/downloads","issues_url":"https://api.github.com/repos/inspirehep/inspire-next/issues{/number}","pulls_url":"https://api.github.com/repos/inspirehep/inspire-next/pulls{/number}","milestones_url":"https://api.github.com/repos/inspirehep/inspire-next/milestones{/number}","notifications_url":"https://api.github.com/repos/inspirehep/inspire-next/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/inspirehep/inspire-next/labels{/name}","releases_url":"https://api.github.com/repos/inspirehep/inspire-next/releases{/id}","created_at":"2013-12-16T09:11:58Z","updated_at":"2014-09-04T15:26:16Z","pushed_at":"2014-10-15T14:38:24Z","git_url":"git://github.com/inspirehep/inspire-next.git","ssh_url":"git@github.com:inspirehep/inspire-next.git","clone_url":"https://github.com/inspirehep/inspire-next.git","svn_url":"https://github.com/inspirehep/inspire-next","homepage":null,"size":7566,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":13,"forks":9,"open_issues":13,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/inspirehep/inspire-next/pulls/94"},"html":{"href":"https://github.com/inspirehep/inspire-next/pull/94"},"issue":{"href":"https://api.github.com/repos/inspirehep/inspire-next/issues/94"},"comments":{"href":"https://api.github.com/repos/inspirehep/inspire-next/issues/94/comments"},"review_comments":{"href":"https://api.github.com/repos/inspirehep/inspire-next/pulls/94/comments"},"review_comment":{"href":"https://api.github.com/repos/inspirehep/inspire-next/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/inspirehep/inspire-next/pulls/94/commits"},"statuses":{"href":"https://api.github.com/repos/inspirehep/inspire-next/statuses/8e8532d440d9c4b193ae9b5d3361f2c8084d7ff9"}}}}