GitHub PullRequestReviewCommentEvent at 2014-08-20 15:02:51
Repository: lumbermill
Actor: apg
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/heroku/lumbermill/pulls/comments/16481435","id":16481435,"diff_hunk":"@@ -42,3 +42,7 @@ func (d *Destination) PostPoint(point Point) {\n \t\tdroppedErrorCounter.Inc(1)\n \t}\n }\n+\n+func (d *Destination) Signal() {","path":"destination.go","position":5,"original_position":5,"commit_id":"0b8cffdf73ee15a8f4799313071cb4dbfd084922","original_commit_id":"0b8cffdf73ee15a8f4799313071cb4dbfd084922","user":{"login":"apg","id":44547,"avatar_url":"https://avatars.githubusercontent.com/u/44547?v=2","gravatar_id":"d543a7491b7b47ec7c3e8f259a75d2dd","url":"https://api.github.com/users/apg","html_url":"https://github.com/apg","followers_url":"https://api.github.com/users/apg/followers","following_url":"https://api.github.com/users/apg/following{/other_user}","gists_url":"https://api.github.com/users/apg/gists{/gist_id}","starred_url":"https://api.github.com/users/apg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apg/subscriptions","organizations_url":"https://api.github.com/users/apg/orgs","repos_url":"https://api.github.com/users/apg/repos","events_url":"https://api.github.com/users/apg/events{/privacy}","received_events_url":"https://api.github.com/users/apg/received_events","type":"User","site_admin":false},"body":"I'll change it to use Closer. ","created_at":"2014-08-20T15:02:51Z","updated_at":"2014-08-20T15:02:51Z","html_url":"https://github.com/heroku/lumbermill/pull/10#discussion_r16481435","pull_request_url":"https://api.github.com/repos/heroku/lumbermill/pulls/10","_links":{"self":{"href":"https://api.github.com/repos/heroku/lumbermill/pulls/comments/16481435"},"html":{"href":"https://github.com/heroku/lumbermill/pull/10#discussion_r16481435"},"pull_request":{"href":"https://api.github.com/repos/heroku/lumbermill/pulls/10"}}},"pull_request":{"url":"https://api.github.com/repos/heroku/lumbermill/pulls/10","id":19361498,"html_url":"https://github.com/heroku/lumbermill/pull/10","diff_url":"https://github.com/heroku/lumbermill/pull/10.diff","patch_url":"https://github.com/heroku/lumbermill/pull/10.patch","issue_url":"https://api.github.com/repos/heroku/lumbermill/issues/10","number":10,"state":"open","locked":false,"title":"Cleaner shutdown","user":{"login":"apg","id":44547,"avatar_url":"https://avatars.githubusercontent.com/u/44547?v=2","gravatar_id":"d543a7491b7b47ec7c3e8f259a75d2dd","url":"https://api.github.com/users/apg","html_url":"https://github.com/apg","followers_url":"https://api.github.com/users/apg/followers","following_url":"https://api.github.com/users/apg/following{/other_user}","gists_url":"https://api.github.com/users/apg/gists{/gist_id}","starred_url":"https://api.github.com/users/apg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apg/subscriptions","organizations_url":"https://api.github.com/users/apg/orgs","repos_url":"https://api.github.com/users/apg/repos","events_url":"https://api.github.com/users/apg/events{/privacy}","received_events_url":"https://api.github.com/users/apg/received_events","type":"User","site_admin":false},"body":"Provide a shutdown mechanism which waits until IIn-flight reqests are drained.","created_at":"2014-08-05T18:53:41Z","updated_at":"2014-08-20T15:02:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f2f9af29988784b880dabce20776feb2dc1b46e9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/heroku/lumbermill/pulls/10/commits","review_comments_url":"https://api.github.com/repos/heroku/lumbermill/pulls/10/comments","review_comment_url":"https://api.github.com/repos/heroku/lumbermill/pulls/comments/{number}","comments_url":"https://api.github.com/repos/heroku/lumbermill/issues/10/comments","statuses_url":"https://api.github.com/repos/heroku/lumbermill/statuses/0b8cffdf73ee15a8f4799313071cb4dbfd084922","head":{"label":"heroku:cleaner-shutdown","ref":"cleaner-shutdown","sha":"0b8cffdf73ee15a8f4799313071cb4dbfd084922","user":{"login":"heroku","id":23211,"avatar_url":"https://avatars.githubusercontent.com/u/23211?v=2","gravatar_id":"3d5c3e6e739b3f159973611ed5c47c84","url":"https://api.github.com/users/heroku","html_url":"https://github.com/heroku","followers_url":"https://api.github.com/users/heroku/followers","following_url":"https://api.github.com/users/heroku/following{/other_user}","gists_url":"https://api.github.com/users/heroku/gists{/gist_id}","starred_url":"https://api.github.com/users/heroku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heroku/subscriptions","organizations_url":"https://api.github.com/users/heroku/orgs","repos_url":"https://api.github.com/users/heroku/repos","events_url":"https://api.github.com/users/heroku/events{/privacy}","received_events_url":"https://api.github.com/users/heroku/received_events","type":"Organization","site_admin":false},"repo":{"id":20906640,"name":"lumbermill","full_name":"heroku/lumbermill","owner":{"login":"heroku","id":23211,"avatar_url":"https://avatars.githubusercontent.com/u/23211?v=2","gravatar_id":"3d5c3e6e739b3f159973611ed5c47c84","url":"https://api.github.com/users/heroku","html_url":"https://github.com/heroku","followers_url":"https://api.github.com/users/heroku/followers","following_url":"https://api.github.com/users/heroku/following{/other_user}","gists_url":"https://api.github.com/users/heroku/gists{/gist_id}","starred_url":"https://api.github.com/users/heroku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heroku/subscriptions","organizations_url":"https://api.github.com/users/heroku/orgs","repos_url":"https://api.github.com/users/heroku/repos","events_url":"https://api.github.com/users/heroku/events{/privacy}","received_events_url":"https://api.github.com/users/heroku/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/heroku/lumbermill","description":"Log Processor","fork":false,"url":"https://api.github.com/repos/heroku/lumbermill","forks_url":"https://api.github.com/repos/heroku/lumbermill/forks","keys_url":"https://api.github.com/repos/heroku/lumbermill/keys{/key_id}","collaborators_url":"https://api.github.com/repos/heroku/lumbermill/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/heroku/lumbermill/teams","hooks_url":"https://api.github.com/repos/heroku/lumbermill/hooks","issue_events_url":"https://api.github.com/repos/heroku/lumbermill/issues/events{/number}","events_url":"https://api.github.com/repos/heroku/lumbermill/events","assignees_url":"https://api.github.com/repos/heroku/lumbermill/assignees{/user}","branches_url":"https://api.github.com/repos/heroku/lumbermill/branches{/branch}","tags_url":"https://api.github.com/repos/heroku/lumbermill/tags","blobs_url":"https://api.github.com/repos/heroku/lumbermill/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/heroku/lumbermill/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/heroku/lumbermill/git/refs{/sha}","trees_url":"https://api.github.com/repos/heroku/lumbermill/git/trees{/sha}","statuses_url":"https://api.github.com/repos/heroku/lumbermill/statuses/{sha}","languages_url":"https://api.github.com/repos/heroku/lumbermill/languages","stargazers_url":"https://api.github.com/repos/heroku/lumbermill/stargazers","contributors_url":"https://api.github.com/repos/heroku/lumbermill/contributors","subscribers_url":"https://api.github.com/repos/heroku/lumbermill/subscribers","subscription_url":"https://api.github.com/repos/heroku/lumbermill/subscription","commits_url":"https://api.github.com/repos/heroku/lumbermill/commits{/sha}","git_commits_url":"https://api.github.com/repos/heroku/lumbermill/git/commits{/sha}","comments_url":"https://api.github.com/repos/heroku/lumbermill/comments{/number}","issue_comment_url":"https://api.github.com/repos/heroku/lumbermill/issues/comments/{number}","contents_url":"https://api.github.com/repos/heroku/lumbermill/contents/{+path}","compare_url":"https://api.github.com/repos/heroku/lumbermill/compare/{base}...{head}","merges_url":"https://api.github.com/repos/heroku/lumbermill/merges","archive_url":"https://api.github.com/repos/heroku/lumbermill/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/heroku/lumbermill/downloads","issues_url":"https://api.github.com/repos/heroku/lumbermill/issues{/number}","pulls_url":"https://api.github.com/repos/heroku/lumbermill/pulls{/number}","milestones_url":"https://api.github.com/repos/heroku/lumbermill/milestones{/number}","notifications_url":"https://api.github.com/repos/heroku/lumbermill/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/heroku/lumbermill/labels{/name}","releases_url":"https://api.github.com/repos/heroku/lumbermill/releases{/id}","created_at":"2014-06-17T01:48:43Z","updated_at":"2014-08-15T22:29:34Z","pushed_at":"2014-08-15T21:14:40Z","git_url":"git://github.com/heroku/lumbermill.git","ssh_url":"git@github.com:heroku/lumbermill.git","clone_url":"https://github.com/heroku/lumbermill.git","svn_url":"https://github.com/heroku/lumbermill","homepage":null,"size":999,"stargazers_count":22,"watchers_count":22,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":22,"default_branch":"master"}},"base":{"label":"heroku:master","ref":"master","sha":"e413ed7eb49bd32870780d045d4639029dd55717","user":{"login":"heroku","id":23211,"avatar_url":"https://avatars.githubusercontent.com/u/23211?v=2","gravatar_id":"3d5c3e6e739b3f159973611ed5c47c84","url":"https://api.github.com/users/heroku","html_url":"https://github.com/heroku","followers_url":"https://api.github.com/users/heroku/followers","following_url":"https://api.github.com/users/heroku/following{/other_user}","gists_url":"https://api.github.com/users/heroku/gists{/gist_id}","starred_url":"https://api.github.com/users/heroku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heroku/subscriptions","organizations_url":"https://api.github.com/users/heroku/orgs","repos_url":"https://api.github.com/users/heroku/repos","events_url":"https://api.github.com/users/heroku/events{/privacy}","received_events_url":"https://api.github.com/users/heroku/received_events","type":"Organization","site_admin":false},"repo":{"id":20906640,"name":"lumbermill","full_name":"heroku/lumbermill","owner":{"login":"heroku","id":23211,"avatar_url":"https://avatars.githubusercontent.com/u/23211?v=2","gravatar_id":"3d5c3e6e739b3f159973611ed5c47c84","url":"https://api.github.com/users/heroku","html_url":"https://github.com/heroku","followers_url":"https://api.github.com/users/heroku/followers","following_url":"https://api.github.com/users/heroku/following{/other_user}","gists_url":"https://api.github.com/users/heroku/gists{/gist_id}","starred_url":"https://api.github.com/users/heroku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heroku/subscriptions","organizations_url":"https://api.github.com/users/heroku/orgs","repos_url":"https://api.github.com/users/heroku/repos","events_url":"https://api.github.com/users/heroku/events{/privacy}","received_events_url":"https://api.github.com/users/heroku/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/heroku/lumbermill","description":"Log Processor","fork":false,"url":"https://api.github.com/repos/heroku/lumbermill","forks_url":"https://api.github.com/repos/heroku/lumbermill/forks","keys_url":"https://api.github.com/repos/heroku/lumbermill/keys{/key_id}","collaborators_url":"https://api.github.com/repos/heroku/lumbermill/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/heroku/lumbermill/teams","hooks_url":"https://api.github.com/repos/heroku/lumbermill/hooks","issue_events_url":"https://api.github.com/repos/heroku/lumbermill/issues/events{/number}","events_url":"https://api.github.com/repos/heroku/lumbermill/events","assignees_url":"https://api.github.com/repos/heroku/lumbermill/assignees{/user}","branches_url":"https://api.github.com/repos/heroku/lumbermill/branches{/branch}","tags_url":"https://api.github.com/repos/heroku/lumbermill/tags","blobs_url":"https://api.github.com/repos/heroku/lumbermill/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/heroku/lumbermill/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/heroku/lumbermill/git/refs{/sha}","trees_url":"https://api.github.com/repos/heroku/lumbermill/git/trees{/sha}","statuses_url":"https://api.github.com/repos/heroku/lumbermill/statuses/{sha}","languages_url":"https://api.github.com/repos/heroku/lumbermill/languages","stargazers_url":"https://api.github.com/repos/heroku/lumbermill/stargazers","contributors_url":"https://api.github.com/repos/heroku/lumbermill/contributors","subscribers_url":"https://api.github.com/repos/heroku/lumbermill/subscribers","subscription_url":"https://api.github.com/repos/heroku/lumbermill/subscription","commits_url":"https://api.github.com/repos/heroku/lumbermill/commits{/sha}","git_commits_url":"https://api.github.com/repos/heroku/lumbermill/git/commits{/sha}","comments_url":"https://api.github.com/repos/heroku/lumbermill/comments{/number}","issue_comment_url":"https://api.github.com/repos/heroku/lumbermill/issues/comments/{number}","contents_url":"https://api.github.com/repos/heroku/lumbermill/contents/{+path}","compare_url":"https://api.github.com/repos/heroku/lumbermill/compare/{base}...{head}","merges_url":"https://api.github.com/repos/heroku/lumbermill/merges","archive_url":"https://api.github.com/repos/heroku/lumbermill/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/heroku/lumbermill/downloads","issues_url":"https://api.github.com/repos/heroku/lumbermill/issues{/number}","pulls_url":"https://api.github.com/repos/heroku/lumbermill/pulls{/number}","milestones_url":"https://api.github.com/repos/heroku/lumbermill/milestones{/number}","notifications_url":"https://api.github.com/repos/heroku/lumbermill/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/heroku/lumbermill/labels{/name}","releases_url":"https://api.github.com/repos/heroku/lumbermill/releases{/id}","created_at":"2014-06-17T01:48:43Z","updated_at":"2014-08-15T22:29:34Z","pushed_at":"2014-08-15T21:14:40Z","git_url":"git://github.com/heroku/lumbermill.git","ssh_url":"git@github.com:heroku/lumbermill.git","clone_url":"https://github.com/heroku/lumbermill.git","svn_url":"https://github.com/heroku/lumbermill","homepage":null,"size":999,"stargazers_count":22,"watchers_count":22,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/heroku/lumbermill/pulls/10"},"html":{"href":"https://github.com/heroku/lumbermill/pull/10"},"issue":{"href":"https://api.github.com/repos/heroku/lumbermill/issues/10"},"comments":{"href":"https://api.github.com/repos/heroku/lumbermill/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/heroku/lumbermill/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/heroku/lumbermill/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/heroku/lumbermill/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/heroku/lumbermill/statuses/0b8cffdf73ee15a8f4799313071cb4dbfd084922"}}}}