GitHub PullRequestReviewCommentEvent at 2014-08-15 09:41:43
Repository: wildfly-core
Actor: aloubyansky
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/comments/16285847","id":16285847,"diff_hunk":"@@ -0,0 +1,66 @@\n+/*\n+ * JBoss, Home of Professional Open Source.\n+ * Copyright 2011, Red Hat, Inc., and individual contributors\n+ * as indicated by the @author tags. See the copyright.txt file in the\n+ * distribution for a full listing of individual contributors.\n+ *\n+ * This is free software; you can redistribute it and/or modify it\n+ * under the terms of the GNU Lesser General Public License as\n+ * published by the Free Software Foundation; either version 2.1 of\n+ * the License, or (at your option) any later version.\n+ *\n+ * This software is distributed in the hope that it will be useful,\n+ * but WITHOUT ANY WARRANTY; without even the implied warranty of\n+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU\n+ * Lesser General Public License for more details.\n+ *\n+ * You should have received a copy of the GNU Lesser General Public\n+ * License along with this software; if not, write to the Free\n+ * Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA\n+ * 02110-1301 USA, or see the FSF site: http://www.fsf.org.\n+ */\n+package org.jboss.as.cli.impl;\n+\n+import java.security.cert.X509Certificate;\n+import java.util.Date;\n+\n+public class ConnectionInfoBean {","path":"cli/src/main/java/org/jboss/as/cli/impl/ConnectionInfoBean.java","position":27,"original_position":27,"commit_id":"8e7181d67de4f62326f3f73c82600daa4d93ac2c","original_commit_id":"8e7181d67de4f62326f3f73c82600daa4d93ac2c","user":{"login":"aloubyansky","id":323379,"avatar_url":"https://avatars.githubusercontent.com/u/323379?v=2","gravatar_id":"d25e578dff40698d0ba55c8039ea8995","url":"https://api.github.com/users/aloubyansky","html_url":"https://github.com/aloubyansky","followers_url":"https://api.github.com/users/aloubyansky/followers","following_url":"https://api.github.com/users/aloubyansky/following{/other_user}","gists_url":"https://api.github.com/users/aloubyansky/gists{/gist_id}","starred_url":"https://api.github.com/users/aloubyansky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aloubyansky/subscriptions","organizations_url":"https://api.github.com/users/aloubyansky/orgs","repos_url":"https://api.github.com/users/aloubyansky/repos","events_url":"https://api.github.com/users/aloubyansky/events{/privacy}","received_events_url":"https://api.github.com/users/aloubyansky/received_events","type":"User","site_admin":false},"body":"Looks good. I meant to keep the class public but the constructor and the setters could have the default access modifier, so they are not visible outside the package.","created_at":"2014-08-15T09:41:43Z","updated_at":"2014-08-15T09:41:43Z","html_url":"https://github.com/wildfly/wildfly-core/pull/89#discussion_r16285847","pull_request_url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/89","_links":{"self":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/comments/16285847"},"html":{"href":"https://github.com/wildfly/wildfly-core/pull/89#discussion_r16285847"},"pull_request":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/89"}}},"pull_request":{"url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/89","id":19578018,"html_url":"https://github.com/wildfly/wildfly-core/pull/89","diff_url":"https://github.com/wildfly/wildfly-core/pull/89.diff","patch_url":"https://github.com/wildfly/wildfly-core/pull/89.patch","issue_url":"https://api.github.com/repos/wildfly/wildfly-core/issues/89","number":89,"state":"open","locked":false,"title":"implementation of WFLY-2510","user":{"login":"claudio4j","id":836543,"avatar_url":"https://avatars.githubusercontent.com/u/836543?v=2","gravatar_id":"e841c3dc55226305c4e2fc2464416316","url":"https://api.github.com/users/claudio4j","html_url":"https://github.com/claudio4j","followers_url":"https://api.github.com/users/claudio4j/followers","following_url":"https://api.github.com/users/claudio4j/following{/other_user}","gists_url":"https://api.github.com/users/claudio4j/gists{/gist_id}","starred_url":"https://api.github.com/users/claudio4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/claudio4j/subscriptions","organizations_url":"https://api.github.com/users/claudio4j/orgs","repos_url":"https://api.github.com/users/claudio4j/repos","events_url":"https://api.github.com/users/claudio4j/events{/privacy}","received_events_url":"https://api.github.com/users/claudio4j/received_events","type":"User","site_admin":false},"body":"Add CLI command to display information about current connection.","created_at":"2014-08-10T22:41:00Z","updated_at":"2014-08-15T09:41:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3537b3e1776308126054583ad779e3fc57fb5bd5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/89/commits","review_comments_url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/89/comments","review_comment_url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/comments/{number}","comments_url":"https://api.github.com/repos/wildfly/wildfly-core/issues/89/comments","statuses_url":"https://api.github.com/repos/wildfly/wildfly-core/statuses/8e7181d67de4f62326f3f73c82600daa4d93ac2c","head":{"label":"claudio4j:WFLY-2510","ref":"WFLY-2510","sha":"8e7181d67de4f62326f3f73c82600daa4d93ac2c","user":{"login":"claudio4j","id":836543,"avatar_url":"https://avatars.githubusercontent.com/u/836543?v=2","gravatar_id":"e841c3dc55226305c4e2fc2464416316","url":"https://api.github.com/users/claudio4j","html_url":"https://github.com/claudio4j","followers_url":"https://api.github.com/users/claudio4j/followers","following_url":"https://api.github.com/users/claudio4j/following{/other_user}","gists_url":"https://api.github.com/users/claudio4j/gists{/gist_id}","starred_url":"https://api.github.com/users/claudio4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/claudio4j/subscriptions","organizations_url":"https://api.github.com/users/claudio4j/orgs","repos_url":"https://api.github.com/users/claudio4j/repos","events_url":"https://api.github.com/users/claudio4j/events{/privacy}","received_events_url":"https://api.github.com/users/claudio4j/received_events","type":"User","site_admin":false},"repo":{"id":21439597,"name":"wildfly-core","full_name":"claudio4j/wildfly-core","owner":{"login":"claudio4j","id":836543,"avatar_url":"https://avatars.githubusercontent.com/u/836543?v=2","gravatar_id":"e841c3dc55226305c4e2fc2464416316","url":"https://api.github.com/users/claudio4j","html_url":"https://github.com/claudio4j","followers_url":"https://api.github.com/users/claudio4j/followers","following_url":"https://api.github.com/users/claudio4j/following{/other_user}","gists_url":"https://api.github.com/users/claudio4j/gists{/gist_id}","starred_url":"https://api.github.com/users/claudio4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/claudio4j/subscriptions","organizations_url":"https://api.github.com/users/claudio4j/orgs","repos_url":"https://api.github.com/users/claudio4j/repos","events_url":"https://api.github.com/users/claudio4j/events{/privacy}","received_events_url":"https://api.github.com/users/claudio4j/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/claudio4j/wildfly-core","description":"The core runtime that is used by the Wildfly application server","fork":true,"url":"https://api.github.com/repos/claudio4j/wildfly-core","forks_url":"https://api.github.com/repos/claudio4j/wildfly-core/forks","keys_url":"https://api.github.com/repos/claudio4j/wildfly-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/claudio4j/wildfly-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/claudio4j/wildfly-core/teams","hooks_url":"https://api.github.com/repos/claudio4j/wildfly-core/hooks","issue_events_url":"https://api.github.com/repos/claudio4j/wildfly-core/issues/events{/number}","events_url":"https://api.github.com/repos/claudio4j/wildfly-core/events","assignees_url":"https://api.github.com/repos/claudio4j/wildfly-core/assignees{/user}","branches_url":"https://api.github.com/repos/claudio4j/wildfly-core/branches{/branch}","tags_url":"https://api.github.com/repos/claudio4j/wildfly-core/tags","blobs_url":"https://api.github.com/repos/claudio4j/wildfly-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/claudio4j/wildfly-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/claudio4j/wildfly-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/claudio4j/wildfly-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/claudio4j/wildfly-core/statuses/{sha}","languages_url":"https://api.github.com/repos/claudio4j/wildfly-core/languages","stargazers_url":"https://api.github.com/repos/claudio4j/wildfly-core/stargazers","contributors_url":"https://api.github.com/repos/claudio4j/wildfly-core/contributors","subscribers_url":"https://api.github.com/repos/claudio4j/wildfly-core/subscribers","subscription_url":"https://api.github.com/repos/claudio4j/wildfly-core/subscription","commits_url":"https://api.github.com/repos/claudio4j/wildfly-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/claudio4j/wildfly-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/claudio4j/wildfly-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/claudio4j/wildfly-core/issues/comments/{number}","contents_url":"https://api.github.com/repos/claudio4j/wildfly-core/contents/{+path}","compare_url":"https://api.github.com/repos/claudio4j/wildfly-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/claudio4j/wildfly-core/merges","archive_url":"https://api.github.com/repos/claudio4j/wildfly-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/claudio4j/wildfly-core/downloads","issues_url":"https://api.github.com/repos/claudio4j/wildfly-core/issues{/number}","pulls_url":"https://api.github.com/repos/claudio4j/wildfly-core/pulls{/number}","milestones_url":"https://api.github.com/repos/claudio4j/wildfly-core/milestones{/number}","notifications_url":"https://api.github.com/repos/claudio4j/wildfly-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/claudio4j/wildfly-core/labels{/name}","releases_url":"https://api.github.com/repos/claudio4j/wildfly-core/releases{/id}","created_at":"2014-07-02T20:36:40Z","updated_at":"2014-07-28T03:17:17Z","pushed_at":"2014-08-15T00:31:14Z","git_url":"git://github.com/claudio4j/wildfly-core.git","ssh_url":"git@github.com:claudio4j/wildfly-core.git","clone_url":"https://github.com/claudio4j/wildfly-core.git","svn_url":"https://github.com/claudio4j/wildfly-core","homepage":null,"size":32533,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wildfly:master","ref":"master","sha":"9bf0e952655190cdd0cc230067f41b96629e33b5","user":{"login":"wildfly","id":3066274,"avatar_url":"https://avatars.githubusercontent.com/u/3066274?v=2","gravatar_id":null,"url":"https://api.github.com/users/wildfly","html_url":"https://github.com/wildfly","followers_url":"https://api.github.com/users/wildfly/followers","following_url":"https://api.github.com/users/wildfly/following{/other_user}","gists_url":"https://api.github.com/users/wildfly/gists{/gist_id}","starred_url":"https://api.github.com/users/wildfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wildfly/subscriptions","organizations_url":"https://api.github.com/users/wildfly/orgs","repos_url":"https://api.github.com/users/wildfly/repos","events_url":"https://api.github.com/users/wildfly/events{/privacy}","received_events_url":"https://api.github.com/users/wildfly/received_events","type":"Organization","site_admin":false},"repo":{"id":21394954,"name":"wildfly-core","full_name":"wildfly/wildfly-core","owner":{"login":"wildfly","id":3066274,"avatar_url":"https://avatars.githubusercontent.com/u/3066274?v=2","gravatar_id":null,"url":"https://api.github.com/users/wildfly","html_url":"https://github.com/wildfly","followers_url":"https://api.github.com/users/wildfly/followers","following_url":"https://api.github.com/users/wildfly/following{/other_user}","gists_url":"https://api.github.com/users/wildfly/gists{/gist_id}","starred_url":"https://api.github.com/users/wildfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wildfly/subscriptions","organizations_url":"https://api.github.com/users/wildfly/orgs","repos_url":"https://api.github.com/users/wildfly/repos","events_url":"https://api.github.com/users/wildfly/events{/privacy}","received_events_url":"https://api.github.com/users/wildfly/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wildfly/wildfly-core","description":"The core runtime that is used by the Wildfly application server","fork":false,"url":"https://api.github.com/repos/wildfly/wildfly-core","forks_url":"https://api.github.com/repos/wildfly/wildfly-core/forks","keys_url":"https://api.github.com/repos/wildfly/wildfly-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wildfly/wildfly-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wildfly/wildfly-core/teams","hooks_url":"https://api.github.com/repos/wildfly/wildfly-core/hooks","issue_events_url":"https://api.github.com/repos/wildfly/wildfly-core/issues/events{/number}","events_url":"https://api.github.com/repos/wildfly/wildfly-core/events","assignees_url":"https://api.github.com/repos/wildfly/wildfly-core/assignees{/user}","branches_url":"https://api.github.com/repos/wildfly/wildfly-core/branches{/branch}","tags_url":"https://api.github.com/repos/wildfly/wildfly-core/tags","blobs_url":"https://api.github.com/repos/wildfly/wildfly-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wildfly/wildfly-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wildfly/wildfly-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/wildfly/wildfly-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wildfly/wildfly-core/statuses/{sha}","languages_url":"https://api.github.com/repos/wildfly/wildfly-core/languages","stargazers_url":"https://api.github.com/repos/wildfly/wildfly-core/stargazers","contributors_url":"https://api.github.com/repos/wildfly/wildfly-core/contributors","subscribers_url":"https://api.github.com/repos/wildfly/wildfly-core/subscribers","subscription_url":"https://api.github.com/repos/wildfly/wildfly-core/subscription","commits_url":"https://api.github.com/repos/wildfly/wildfly-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/wildfly/wildfly-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/wildfly/wildfly-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/wildfly/wildfly-core/issues/comments/{number}","contents_url":"https://api.github.com/repos/wildfly/wildfly-core/contents/{+path}","compare_url":"https://api.github.com/repos/wildfly/wildfly-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wildfly/wildfly-core/merges","archive_url":"https://api.github.com/repos/wildfly/wildfly-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wildfly/wildfly-core/downloads","issues_url":"https://api.github.com/repos/wildfly/wildfly-core/issues{/number}","pulls_url":"https://api.github.com/repos/wildfly/wildfly-core/pulls{/number}","milestones_url":"https://api.github.com/repos/wildfly/wildfly-core/milestones{/number}","notifications_url":"https://api.github.com/repos/wildfly/wildfly-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wildfly/wildfly-core/labels{/name}","releases_url":"https://api.github.com/repos/wildfly/wildfly-core/releases{/id}","created_at":"2014-07-01T16:33:34Z","updated_at":"2014-08-13T11:07:39Z","pushed_at":"2014-08-14T20:56:53Z","git_url":"git://github.com/wildfly/wildfly-core.git","ssh_url":"git@github.com:wildfly/wildfly-core.git","clone_url":"https://github.com/wildfly/wildfly-core.git","svn_url":"https://github.com/wildfly/wildfly-core","homepage":null,"size":35135,"stargazers_count":4,"watchers_count":4,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":44,"mirror_url":null,"open_issues_count":13,"forks":44,"open_issues":13,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/89"},"html":{"href":"https://github.com/wildfly/wildfly-core/pull/89"},"issue":{"href":"https://api.github.com/repos/wildfly/wildfly-core/issues/89"},"comments":{"href":"https://api.github.com/repos/wildfly/wildfly-core/issues/89/comments"},"review_comments":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/89/comments"},"review_comment":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/89/commits"},"statuses":{"href":"https://api.github.com/repos/wildfly/wildfly-core/statuses/8e7181d67de4f62326f3f73c82600daa4d93ac2c"}}}}