GitHub PullRequestReviewCommentEvent at 2014-08-01 01:43:01
Repository: voltdb
Actor: paulmartel
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/VoltDB/voltdb/pulls/comments/15679617","id":15679617,"diff_hunk":"@@ -102,7 +102,7 @@ bool InsertExecutor::p_init(AbstractPlanNode* abstractNode,\n     m_templateTuple.init(targetTable->schema());\n \n     TableTuple tuple = m_templateTuple.tuple();\n-    m_node->initTemplateTuple(m_engine, tuple);\n+    m_node->initTemplateTuple(m_engine, &m_memoryPool, tuple);","path":"src/ee/executors/insertexecutor.cpp","position":5,"original_position":5,"commit_id":"fd40c3b2c0a4db685b7992bbe5d87568b98f7fda","original_commit_id":"fd40c3b2c0a4db685b7992bbe5d87568b98f7fda","user":{"login":"paulmartel","id":1512099,"avatar_url":"https://avatars.githubusercontent.com/u/1512099?v=1","gravatar_id":"6ead0214cbf028f95dcc28142fa4d7bd","url":"https://api.github.com/users/paulmartel","html_url":"https://github.com/paulmartel","followers_url":"https://api.github.com/users/paulmartel/followers","following_url":"https://api.github.com/users/paulmartel/following{/other_user}","gists_url":"https://api.github.com/users/paulmartel/gists{/gist_id}","starred_url":"https://api.github.com/users/paulmartel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulmartel/subscriptions","organizations_url":"https://api.github.com/users/paulmartel/orgs","repos_url":"https://api.github.com/users/paulmartel/repos","events_url":"https://api.github.com/users/paulmartel/events{/privacy}","received_events_url":"https://api.github.com/users/paulmartel/received_events","type":"User","site_admin":false},"body":"This changeset looks good, but I am suddenly reminded that this code does not properly support timestamp columns with DEFAULT NOW. DEFAULT NOW columns need to be reset at the top of p_execute to get the latest transaction start time. initTemplateTuple should probably have a side effect of filling a vector of ints with the column indexes of all DEFAULT NOW columns. p_execute would iterate over the vector to set those columns.","created_at":"2014-08-01T01:43:01Z","updated_at":"2014-08-01T01:43:01Z","html_url":"https://github.com/VoltDB/voltdb/pull/1586#discussion_r15679617","pull_request_url":"https://api.github.com/repos/VoltDB/voltdb/pulls/1586","_links":{"self":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/comments/15679617"},"html":{"href":"https://github.com/VoltDB/voltdb/pull/1586#discussion_r15679617"},"pull_request":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/1586"}}},"pull_request":{"url":"https://api.github.com/repos/VoltDB/voltdb/pulls/1586","id":19188159,"html_url":"https://github.com/VoltDB/voltdb/pull/1586","diff_url":"https://github.com/VoltDB/voltdb/pull/1586.diff","patch_url":"https://github.com/VoltDB/voltdb/pull/1586.patch","issue_url":"https://api.github.com/repos/VoltDB/voltdb/issues/1586","number":1586,"state":"open","title":"When preparing to insert, allocate non-inlined default values in executo...","user":{"login":"cwolff-voltdb","id":7902964,"avatar_url":"https://avatars.githubusercontent.com/u/7902964?v=1","gravatar_id":"3de3279085df92798516719e1a806947","url":"https://api.github.com/users/cwolff-voltdb","html_url":"https://github.com/cwolff-voltdb","followers_url":"https://api.github.com/users/cwolff-voltdb/followers","following_url":"https://api.github.com/users/cwolff-voltdb/following{/other_user}","gists_url":"https://api.github.com/users/cwolff-voltdb/gists{/gist_id}","starred_url":"https://api.github.com/users/cwolff-voltdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cwolff-voltdb/subscriptions","organizations_url":"https://api.github.com/users/cwolff-voltdb/orgs","repos_url":"https://api.github.com/users/cwolff-voltdb/repos","events_url":"https://api.github.com/users/cwolff-voltdb/events{/privacy}","received_events_url":"https://api.github.com/users/cwolff-voltdb/received_events","type":"User","site_admin":false},"body":"...r-scoped pool.\r\n\r\nMy performance fix for the insert/materialize node refactoring was allocating non-inlined temp strings in the temp pool.  The lifetime of this memory was not long enough, and valgrind was showing invalid pointer reads as a result.\r\n","created_at":"2014-08-01T00:47:38Z","updated_at":"2014-08-01T01:43:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ec9907fd2feab92fd0878ac53290f7f5a4f4e66a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/VoltDB/voltdb/pulls/1586/commits","review_comments_url":"https://api.github.com/repos/VoltDB/voltdb/pulls/1586/comments","review_comment_url":"https://api.github.com/repos/VoltDB/voltdb/pulls/comments/{number}","comments_url":"https://api.github.com/repos/VoltDB/voltdb/issues/1586/comments","statuses_url":"https://api.github.com/repos/VoltDB/voltdb/statuses/fd40c3b2c0a4db685b7992bbe5d87568b98f7fda","head":{"label":"VoltDB:insert-into-select-memcheck-failures","ref":"insert-into-select-memcheck-failures","sha":"fd40c3b2c0a4db685b7992bbe5d87568b98f7fda","user":{"login":"VoltDB","id":703910,"avatar_url":"https://avatars.githubusercontent.com/u/703910?v=1","gravatar_id":"bd7cbe7beb6aeaf74a622e90df1b54be","url":"https://api.github.com/users/VoltDB","html_url":"https://github.com/VoltDB","followers_url":"https://api.github.com/users/VoltDB/followers","following_url":"https://api.github.com/users/VoltDB/following{/other_user}","gists_url":"https://api.github.com/users/VoltDB/gists{/gist_id}","starred_url":"https://api.github.com/users/VoltDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VoltDB/subscriptions","organizations_url":"https://api.github.com/users/VoltDB/orgs","repos_url":"https://api.github.com/users/VoltDB/repos","events_url":"https://api.github.com/users/VoltDB/events{/privacy}","received_events_url":"https://api.github.com/users/VoltDB/received_events","type":"Organization","site_admin":false},"repo":{"id":2445970,"name":"voltdb","full_name":"VoltDB/voltdb","owner":{"login":"VoltDB","id":703910,"avatar_url":"https://avatars.githubusercontent.com/u/703910?v=1","gravatar_id":"bd7cbe7beb6aeaf74a622e90df1b54be","url":"https://api.github.com/users/VoltDB","html_url":"https://github.com/VoltDB","followers_url":"https://api.github.com/users/VoltDB/followers","following_url":"https://api.github.com/users/VoltDB/following{/other_user}","gists_url":"https://api.github.com/users/VoltDB/gists{/gist_id}","starred_url":"https://api.github.com/users/VoltDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VoltDB/subscriptions","organizations_url":"https://api.github.com/users/VoltDB/orgs","repos_url":"https://api.github.com/users/VoltDB/repos","events_url":"https://api.github.com/users/VoltDB/events{/privacy}","received_events_url":"https://api.github.com/users/VoltDB/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/VoltDB/voltdb","description":"VoltDB","fork":false,"url":"https://api.github.com/repos/VoltDB/voltdb","forks_url":"https://api.github.com/repos/VoltDB/voltdb/forks","keys_url":"https://api.github.com/repos/VoltDB/voltdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VoltDB/voltdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VoltDB/voltdb/teams","hooks_url":"https://api.github.com/repos/VoltDB/voltdb/hooks","issue_events_url":"https://api.github.com/repos/VoltDB/voltdb/issues/events{/number}","events_url":"https://api.github.com/repos/VoltDB/voltdb/events","assignees_url":"https://api.github.com/repos/VoltDB/voltdb/assignees{/user}","branches_url":"https://api.github.com/repos/VoltDB/voltdb/branches{/branch}","tags_url":"https://api.github.com/repos/VoltDB/voltdb/tags","blobs_url":"https://api.github.com/repos/VoltDB/voltdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VoltDB/voltdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VoltDB/voltdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/VoltDB/voltdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VoltDB/voltdb/statuses/{sha}","languages_url":"https://api.github.com/repos/VoltDB/voltdb/languages","stargazers_url":"https://api.github.com/repos/VoltDB/voltdb/stargazers","contributors_url":"https://api.github.com/repos/VoltDB/voltdb/contributors","subscribers_url":"https://api.github.com/repos/VoltDB/voltdb/subscribers","subscription_url":"https://api.github.com/repos/VoltDB/voltdb/subscription","commits_url":"https://api.github.com/repos/VoltDB/voltdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/VoltDB/voltdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/VoltDB/voltdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/VoltDB/voltdb/issues/comments/{number}","contents_url":"https://api.github.com/repos/VoltDB/voltdb/contents/{+path}","compare_url":"https://api.github.com/repos/VoltDB/voltdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VoltDB/voltdb/merges","archive_url":"https://api.github.com/repos/VoltDB/voltdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VoltDB/voltdb/downloads","issues_url":"https://api.github.com/repos/VoltDB/voltdb/issues{/number}","pulls_url":"https://api.github.com/repos/VoltDB/voltdb/pulls{/number}","milestones_url":"https://api.github.com/repos/VoltDB/voltdb/milestones{/number}","notifications_url":"https://api.github.com/repos/VoltDB/voltdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VoltDB/voltdb/labels{/name}","releases_url":"https://api.github.com/repos/VoltDB/voltdb/releases{/id}","created_at":"2011-09-23T18:46:12Z","updated_at":"2014-07-29T11:09:49Z","pushed_at":"2014-08-01T01:17:42Z","git_url":"git://github.com/VoltDB/voltdb.git","ssh_url":"git@github.com:VoltDB/voltdb.git","clone_url":"https://github.com/VoltDB/voltdb.git","svn_url":"https://github.com/VoltDB/voltdb","homepage":"http://community.voltdb.com/","size":509258,"stargazers_count":347,"watchers_count":347,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":87,"mirror_url":null,"open_issues_count":31,"forks":87,"open_issues":31,"watchers":347,"default_branch":"master"}},"base":{"label":"VoltDB:master","ref":"master","sha":"76287354e9b000c8d4e7dd051d352d4d8b364bb1","user":{"login":"VoltDB","id":703910,"avatar_url":"https://avatars.githubusercontent.com/u/703910?v=1","gravatar_id":"bd7cbe7beb6aeaf74a622e90df1b54be","url":"https://api.github.com/users/VoltDB","html_url":"https://github.com/VoltDB","followers_url":"https://api.github.com/users/VoltDB/followers","following_url":"https://api.github.com/users/VoltDB/following{/other_user}","gists_url":"https://api.github.com/users/VoltDB/gists{/gist_id}","starred_url":"https://api.github.com/users/VoltDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VoltDB/subscriptions","organizations_url":"https://api.github.com/users/VoltDB/orgs","repos_url":"https://api.github.com/users/VoltDB/repos","events_url":"https://api.github.com/users/VoltDB/events{/privacy}","received_events_url":"https://api.github.com/users/VoltDB/received_events","type":"Organization","site_admin":false},"repo":{"id":2445970,"name":"voltdb","full_name":"VoltDB/voltdb","owner":{"login":"VoltDB","id":703910,"avatar_url":"https://avatars.githubusercontent.com/u/703910?v=1","gravatar_id":"bd7cbe7beb6aeaf74a622e90df1b54be","url":"https://api.github.com/users/VoltDB","html_url":"https://github.com/VoltDB","followers_url":"https://api.github.com/users/VoltDB/followers","following_url":"https://api.github.com/users/VoltDB/following{/other_user}","gists_url":"https://api.github.com/users/VoltDB/gists{/gist_id}","starred_url":"https://api.github.com/users/VoltDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VoltDB/subscriptions","organizations_url":"https://api.github.com/users/VoltDB/orgs","repos_url":"https://api.github.com/users/VoltDB/repos","events_url":"https://api.github.com/users/VoltDB/events{/privacy}","received_events_url":"https://api.github.com/users/VoltDB/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/VoltDB/voltdb","description":"VoltDB","fork":false,"url":"https://api.github.com/repos/VoltDB/voltdb","forks_url":"https://api.github.com/repos/VoltDB/voltdb/forks","keys_url":"https://api.github.com/repos/VoltDB/voltdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VoltDB/voltdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VoltDB/voltdb/teams","hooks_url":"https://api.github.com/repos/VoltDB/voltdb/hooks","issue_events_url":"https://api.github.com/repos/VoltDB/voltdb/issues/events{/number}","events_url":"https://api.github.com/repos/VoltDB/voltdb/events","assignees_url":"https://api.github.com/repos/VoltDB/voltdb/assignees{/user}","branches_url":"https://api.github.com/repos/VoltDB/voltdb/branches{/branch}","tags_url":"https://api.github.com/repos/VoltDB/voltdb/tags","blobs_url":"https://api.github.com/repos/VoltDB/voltdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VoltDB/voltdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VoltDB/voltdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/VoltDB/voltdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VoltDB/voltdb/statuses/{sha}","languages_url":"https://api.github.com/repos/VoltDB/voltdb/languages","stargazers_url":"https://api.github.com/repos/VoltDB/voltdb/stargazers","contributors_url":"https://api.github.com/repos/VoltDB/voltdb/contributors","subscribers_url":"https://api.github.com/repos/VoltDB/voltdb/subscribers","subscription_url":"https://api.github.com/repos/VoltDB/voltdb/subscription","commits_url":"https://api.github.com/repos/VoltDB/voltdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/VoltDB/voltdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/VoltDB/voltdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/VoltDB/voltdb/issues/comments/{number}","contents_url":"https://api.github.com/repos/VoltDB/voltdb/contents/{+path}","compare_url":"https://api.github.com/repos/VoltDB/voltdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VoltDB/voltdb/merges","archive_url":"https://api.github.com/repos/VoltDB/voltdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VoltDB/voltdb/downloads","issues_url":"https://api.github.com/repos/VoltDB/voltdb/issues{/number}","pulls_url":"https://api.github.com/repos/VoltDB/voltdb/pulls{/number}","milestones_url":"https://api.github.com/repos/VoltDB/voltdb/milestones{/number}","notifications_url":"https://api.github.com/repos/VoltDB/voltdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VoltDB/voltdb/labels{/name}","releases_url":"https://api.github.com/repos/VoltDB/voltdb/releases{/id}","created_at":"2011-09-23T18:46:12Z","updated_at":"2014-07-29T11:09:49Z","pushed_at":"2014-08-01T01:17:42Z","git_url":"git://github.com/VoltDB/voltdb.git","ssh_url":"git@github.com:VoltDB/voltdb.git","clone_url":"https://github.com/VoltDB/voltdb.git","svn_url":"https://github.com/VoltDB/voltdb","homepage":"http://community.voltdb.com/","size":509258,"stargazers_count":347,"watchers_count":347,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":87,"mirror_url":null,"open_issues_count":31,"forks":87,"open_issues":31,"watchers":347,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/1586"},"html":{"href":"https://github.com/VoltDB/voltdb/pull/1586"},"issue":{"href":"https://api.github.com/repos/VoltDB/voltdb/issues/1586"},"comments":{"href":"https://api.github.com/repos/VoltDB/voltdb/issues/1586/comments"},"review_comments":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/1586/comments"},"review_comment":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/1586/commits"},"statuses":{"href":"https://api.github.com/repos/VoltDB/voltdb/statuses/fd40c3b2c0a4db685b7992bbe5d87568b98f7fda"}}}}