GitHub PullRequestReviewCommentEvent at 2014-12-09 08:04:44
Repository: splunk-sdk-csharp-pcl
Actor: shakeelmohamed
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/splunk/splunk-sdk-csharp-pcl/pulls/comments/21511936","id":21511936,"diff_hunk":"@@ -301,14 +307,14 @@ private static bool IsScheme(string[] args, DebuggerAttachPoints attachPoints)\n                 }\n                 else\n                 {\n-                    await writer.LogAsync(\"ERROR\", \"Invalid arguments to modular input.\");\n+                    await writer.LogAsync(Severity.Error, string.Format(\"Invalid arguments to modular input: name={0}\", name));\n                     return -1;\n                 }\n             }\n             catch (Exception e)\n             {\n                 var full = e.ToString().Replace(Environment.NewLine, \" | \");","path":"src/Splunk.ModularInputs/Splunk/ModularInputs/ModularInput.cs","position":42,"original_position":42,"commit_id":"b64b319a5944b88d861f53f1b9d9ef8c497ee7bc","original_commit_id":"b64b319a5944b88d861f53f1b9d9ef8c497ee7bc","user":{"login":"shakeelmohamed","id":1480063,"avatar_url":"https://avatars.githubusercontent.com/u/1480063?v=3","gravatar_id":"","url":"https://api.github.com/users/shakeelmohamed","html_url":"https://github.com/shakeelmohamed","followers_url":"https://api.github.com/users/shakeelmohamed/followers","following_url":"https://api.github.com/users/shakeelmohamed/following{/other_user}","gists_url":"https://api.github.com/users/shakeelmohamed/gists{/gist_id}","starred_url":"https://api.github.com/users/shakeelmohamed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shakeelmohamed/subscriptions","organizations_url":"https://api.github.com/users/shakeelmohamed/orgs","repos_url":"https://api.github.com/users/shakeelmohamed/repos","events_url":"https://api.github.com/users/shakeelmohamed/events{/privacy}","received_events_url":"https://api.github.com/users/shakeelmohamed/received_events","type":"User","site_admin":false},"body":"Same comment as above, `var exceptionString = ...` would be nicer","created_at":"2014-12-09T08:04:44Z","updated_at":"2014-12-09T08:04:44Z","html_url":"https://github.com/splunk/splunk-sdk-csharp-pcl/pull/29#discussion_r21511936","pull_request_url":"https://api.github.com/repos/splunk/splunk-sdk-csharp-pcl/pulls/29","_links":{"self":{"href":"https://api.github.com/repos/splunk/splunk-sdk-csharp-pcl/pulls/comments/21511936"},"html":{"href":"https://github.com/splunk/splunk-sdk-csharp-pcl/pull/29#discussion_r21511936"},"pull_request":{"href":"https://api.github.com/repos/splunk/splunk-sdk-csharp-pcl/pulls/29"}}},"pull_request":{"url":"https://api.github.com/repos/splunk/splunk-sdk-csharp-pcl/pulls/29","id":25723349,"html_url":"https://github.com/splunk/splunk-sdk-csharp-pcl/pull/29","diff_url":"https://github.com/splunk/splunk-sdk-csharp-pcl/pull/29.diff","patch_url":"https://github.com/splunk/splunk-sdk-csharp-pcl/pull/29.patch","issue_url":"https://api.github.com/repos/splunk/splunk-sdk-csharp-pcl/issues/29","number":29,"state":"open","locked":false,"title":"Adding better logging for validation. Also adding input name for all","user":{"login":"glennblock","id":141124,"avatar_url":"https://avatars.githubusercontent.com/u/141124?v=3","gravatar_id":"","url":"https://api.github.com/users/glennblock","html_url":"https://github.com/glennblock","followers_url":"https://api.github.com/users/glennblock/followers","following_url":"https://api.github.com/users/glennblock/following{/other_user}","gists_url":"https://api.github.com/users/glennblock/gists{/gist_id}","starred_url":"https://api.github.com/users/glennblock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glennblock/subscriptions","organizations_url":"https://api.github.com/users/glennblock/orgs","repos_url":"https://api.github.com/users/glennblock/repos","events_url":"https://api.github.com/users/glennblock/events{/privacy}","received_events_url":"https://api.github.com/users/glennblock/received_events","type":"User","site_admin":false},"body":"logging.\r\n","created_at":"2014-12-09T07:10:00Z","updated_at":"2014-12-09T08:04:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b91aad40b2776bfd8a5aaf580bcad3ed09ab944b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/splunk/splunk-sdk-csharp-pcl/pulls/29/commits","review_comments_url":"https://api.github.com/repos/splunk/splunk-sdk-csharp-pcl/pulls/29/comments","review_comment_url":"https://api.github.com/repos/splunk/splunk-sdk-csharp-pcl/pulls/comments/{number}","comments_url":"https://api.github.com/repos/splunk/splunk-sdk-csharp-pcl/issues/29/comments","statuses_url":"https://api.github.com/repos/splunk/splunk-sdk-csharp-pcl/statuses/b64b319a5944b88d861f53f1b9d9ef8c497ee7bc","head":{"label":"splunk:error-logging","ref":"error-logging","sha":"b64b319a5944b88d861f53f1b9d9ef8c497ee7bc","user":{"login":"splunk","id":651467,"avatar_url":"https://avatars.githubusercontent.com/u/651467?v=3","gravatar_id":"","url":"https://api.github.com/users/splunk","html_url":"https://github.com/splunk","followers_url":"https://api.github.com/users/splunk/followers","following_url":"https://api.github.com/users/splunk/following{/other_user}","gists_url":"https://api.github.com/users/splunk/gists{/gist_id}","starred_url":"https://api.github.com/users/splunk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/splunk/subscriptions","organizations_url":"https://api.github.com/users/splunk/orgs","repos_url":"https://api.github.com/users/splunk/repos","events_url":"https://api.github.com/users/splunk/events{/privacy}","received_events_url":"https://api.github.com/users/splunk/received_events","type":"Organization","site_admin":false},"repo":{"id":16777291,"name":"splunk-sdk-csharp-pcl","full_name":"splunk/splunk-sdk-csharp-pcl","owner":{"login":"splunk","id":651467,"avatar_url":"https://avatars.githubusercontent.com/u/651467?v=3","gravatar_id":"","url":"https://api.github.com/users/splunk","html_url":"https://github.com/splunk","followers_url":"https://api.github.com/users/splunk/followers","following_url":"https://api.github.com/users/splunk/following{/other_user}","gists_url":"https://api.github.com/users/splunk/gists{/gist_id}","starred_url":"https://api.github.com/users/splunk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/splunk/subscriptions","organizations_url":"https://api.github.com/users/splunk/orgs","repos_url":"https://api.github.com/users/splunk/repos","events_url":"https://api.github.com/users/splunk/events{/privacy}","received_events_url":"https://api.github.com/users/splunk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/splunk/splunk-sdk-csharp-pcl","description":"Splunk's next generation C# SDK","fork":false,"url":"https://api.github.com/repos/splunk/splunk-sdk-csharp-pcl","forks_url":"https://api.github.com/repos/splunk/splunk-sdk-csharp-pcl/forks","keys_url":"https://api.github.com/repos/splunk/splunk-sdk-csharp-pcl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/splunk/splunk-sdk-csharp-pcl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/splunk/splunk-sdk-csharp-pcl/teams","hooks_url":"https://api.github.com/repos/splunk/splunk-sdk-csharp-pcl/hooks","issue_events_url":"https://api.github.com/repos/splunk/splunk-sdk-csharp-pcl/issues/events{/number}","events_url":"https://api.github.com/repos/splunk/splunk-sdk-csharp-pcl/events","assignees_url":"https://api.github.com/repos/splunk/splunk-sdk-csharp-pcl/assignees{/user}","branches_url":"https://api.github.com/repos/splunk/splunk-sdk-csharp-pcl/branches{/branch}","tags_url":"https://api.github.com/repos/splunk/splunk-sdk-csharp-pcl/tags","blobs_url":"https://api.github.com/repos/splunk/splunk-sdk-csharp-pcl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/splunk/splunk-sdk-csharp-pcl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/splunk/splunk-sdk-csharp-pcl/git/refs{/sha}","trees_url":"https://api.github.com/repos/splunk/splunk-sdk-csharp-pcl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/splunk/splunk-sdk-csharp-pcl/statuses/{sha}","languages_url":"https://api.github.com/repos/splunk/splunk-sdk-csharp-pcl/languages","stargazers_url":"https://api.github.com/repos/splunk/splunk-sdk-csharp-pcl/stargazers","contributors_url":"https://api.github.com/repos/splunk/splunk-sdk-csharp-pcl/contributors","subscribers_url":"https://api.github.com/repos/splunk/splunk-sdk-csharp-pcl/subscribers","subscription_url":"https://api.github.com/repos/splunk/splunk-sdk-csharp-pcl/subscription","commits_url":"https://api.github.com/repos/splunk/splunk-sdk-csharp-pcl/commits{/sha}","git_commits_url":"https://api.github.com/repos/splunk/splunk-sdk-csharp-pcl/git/commits{/sha}","comments_url":"https://api.github.com/repos/splunk/splunk-sdk-csharp-pcl/comments{/number}","issue_comment_url":"https://api.github.com/repos/splunk/splunk-sdk-csharp-pcl/issues/comments/{number}","contents_url":"https://api.github.com/repos/splunk/splunk-sdk-csharp-pcl/contents/{+path}","compare_url":"https://api.github.com/repos/splunk/splunk-sdk-csharp-pcl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/splunk/splunk-sdk-csharp-pcl/merges","archive_url":"https://api.github.com/repos/splunk/splunk-sdk-csharp-pcl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/splunk/splunk-sdk-csharp-pcl/downloads","issues_url":"https://api.github.com/repos/splunk/splunk-sdk-csharp-pcl/issues{/number}","pulls_url":"https://api.github.com/repos/splunk/splunk-sdk-csharp-pcl/pulls{/number}","milestones_url":"https://api.github.com/repos/splunk/splunk-sdk-csharp-pcl/milestones{/number}","notifications_url":"https://api.github.com/repos/splunk/splunk-sdk-csharp-pcl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/splunk/splunk-sdk-csharp-pcl/labels{/name}","releases_url":"https://api.github.com/repos/splunk/splunk-sdk-csharp-pcl/releases{/id}","created_at":"2014-02-12T18:32:47Z","updated_at":"2014-12-08T23:25:00Z","pushed_at":"2014-12-09T07:13:28Z","git_url":"git://github.com/splunk/splunk-sdk-csharp-pcl.git","ssh_url":"git@github.com:splunk/splunk-sdk-csharp-pcl.git","clone_url":"https://github.com/splunk/splunk-sdk-csharp-pcl.git","svn_url":"https://github.com/splunk/splunk-sdk-csharp-pcl","homepage":"","size":62540,"stargazers_count":21,"watchers_count":21,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":1,"forks":9,"open_issues":1,"watchers":21,"default_branch":"master"}},"base":{"label":"splunk:develop","ref":"develop","sha":"db516077cd817d3579acfc48bdfbb94791932921","user":{"login":"splunk","id":651467,"avatar_url":"https://avatars.githubusercontent.com/u/651467?v=3","gravatar_id":"","url":"https://api.github.com/users/splunk","html_url":"https://github.com/splunk","followers_url":"https://api.github.com/users/splunk/followers","following_url":"https://api.github.com/users/splunk/following{/other_user}","gists_url":"https://api.github.com/users/splunk/gists{/gist_id}","starred_url":"https://api.github.com/users/splunk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/splunk/subscriptions","organizations_url":"https://api.github.com/users/splunk/orgs","repos_url":"https://api.github.com/users/splunk/repos","events_url":"https://api.github.com/users/splunk/events{/privacy}","received_events_url":"https://api.github.com/users/splunk/received_events","type":"Organization","site_admin":false},"repo":{"id":16777291,"name":"splunk-sdk-csharp-pcl","full_name":"splunk/splunk-sdk-csharp-pcl","owner":{"login":"splunk","id":651467,"avatar_url":"https://avatars.githubusercontent.com/u/651467?v=3","gravatar_id":"","url":"https://api.github.com/users/splunk","html_url":"https://github.com/splunk","followers_url":"https://api.github.com/users/splunk/followers","following_url":"https://api.github.com/users/splunk/following{/other_user}","gists_url":"https://api.github.com/users/splunk/gists{/gist_id}","starred_url":"https://api.github.com/users/splunk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/splunk/subscriptions","organizations_url":"https://api.github.com/users/splunk/orgs","repos_url":"https://api.github.com/users/splunk/repos","events_url":"https://api.github.com/users/splunk/events{/privacy}","received_events_url":"https://api.github.com/users/splunk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/splunk/splunk-sdk-csharp-pcl","description":"Splunk's next generation C# SDK","fork":false,"url":"https://api.github.com/repos/splunk/splunk-sdk-csharp-pcl","forks_url":"https://api.github.com/repos/splunk/splunk-sdk-csharp-pcl/forks","keys_url":"https://api.github.com/repos/splunk/splunk-sdk-csharp-pcl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/splunk/splunk-sdk-csharp-pcl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/splunk/splunk-sdk-csharp-pcl/teams","hooks_url":"https://api.github.com/repos/splunk/splunk-sdk-csharp-pcl/hooks","issue_events_url":"https://api.github.com/repos/splunk/splunk-sdk-csharp-pcl/issues/events{/number}","events_url":"https://api.github.com/repos/splunk/splunk-sdk-csharp-pcl/events","assignees_url":"https://api.github.com/repos/splunk/splunk-sdk-csharp-pcl/assignees{/user}","branches_url":"https://api.github.com/repos/splunk/splunk-sdk-csharp-pcl/branches{/branch}","tags_url":"https://api.github.com/repos/splunk/splunk-sdk-csharp-pcl/tags","blobs_url":"https://api.github.com/repos/splunk/splunk-sdk-csharp-pcl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/splunk/splunk-sdk-csharp-pcl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/splunk/splunk-sdk-csharp-pcl/git/refs{/sha}","trees_url":"https://api.github.com/repos/splunk/splunk-sdk-csharp-pcl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/splunk/splunk-sdk-csharp-pcl/statuses/{sha}","languages_url":"https://api.github.com/repos/splunk/splunk-sdk-csharp-pcl/languages","stargazers_url":"https://api.github.com/repos/splunk/splunk-sdk-csharp-pcl/stargazers","contributors_url":"https://api.github.com/repos/splunk/splunk-sdk-csharp-pcl/contributors","subscribers_url":"https://api.github.com/repos/splunk/splunk-sdk-csharp-pcl/subscribers","subscription_url":"https://api.github.com/repos/splunk/splunk-sdk-csharp-pcl/subscription","commits_url":"https://api.github.com/repos/splunk/splunk-sdk-csharp-pcl/commits{/sha}","git_commits_url":"https://api.github.com/repos/splunk/splunk-sdk-csharp-pcl/git/commits{/sha}","comments_url":"https://api.github.com/repos/splunk/splunk-sdk-csharp-pcl/comments{/number}","issue_comment_url":"https://api.github.com/repos/splunk/splunk-sdk-csharp-pcl/issues/comments/{number}","contents_url":"https://api.github.com/repos/splunk/splunk-sdk-csharp-pcl/contents/{+path}","compare_url":"https://api.github.com/repos/splunk/splunk-sdk-csharp-pcl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/splunk/splunk-sdk-csharp-pcl/merges","archive_url":"https://api.github.com/repos/splunk/splunk-sdk-csharp-pcl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/splunk/splunk-sdk-csharp-pcl/downloads","issues_url":"https://api.github.com/repos/splunk/splunk-sdk-csharp-pcl/issues{/number}","pulls_url":"https://api.github.com/repos/splunk/splunk-sdk-csharp-pcl/pulls{/number}","milestones_url":"https://api.github.com/repos/splunk/splunk-sdk-csharp-pcl/milestones{/number}","notifications_url":"https://api.github.com/repos/splunk/splunk-sdk-csharp-pcl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/splunk/splunk-sdk-csharp-pcl/labels{/name}","releases_url":"https://api.github.com/repos/splunk/splunk-sdk-csharp-pcl/releases{/id}","created_at":"2014-02-12T18:32:47Z","updated_at":"2014-12-08T23:25:00Z","pushed_at":"2014-12-09T07:13:28Z","git_url":"git://github.com/splunk/splunk-sdk-csharp-pcl.git","ssh_url":"git@github.com:splunk/splunk-sdk-csharp-pcl.git","clone_url":"https://github.com/splunk/splunk-sdk-csharp-pcl.git","svn_url":"https://github.com/splunk/splunk-sdk-csharp-pcl","homepage":"","size":62540,"stargazers_count":21,"watchers_count":21,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":1,"forks":9,"open_issues":1,"watchers":21,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/splunk/splunk-sdk-csharp-pcl/pulls/29"},"html":{"href":"https://github.com/splunk/splunk-sdk-csharp-pcl/pull/29"},"issue":{"href":"https://api.github.com/repos/splunk/splunk-sdk-csharp-pcl/issues/29"},"comments":{"href":"https://api.github.com/repos/splunk/splunk-sdk-csharp-pcl/issues/29/comments"},"review_comments":{"href":"https://api.github.com/repos/splunk/splunk-sdk-csharp-pcl/pulls/29/comments"},"review_comment":{"href":"https://api.github.com/repos/splunk/splunk-sdk-csharp-pcl/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/splunk/splunk-sdk-csharp-pcl/pulls/29/commits"},"statuses":{"href":"https://api.github.com/repos/splunk/splunk-sdk-csharp-pcl/statuses/b64b319a5944b88d861f53f1b9d9ef8c497ee7bc"}}}}