GitHub PullRequestEvent at 2014-10-12 21:57:17
Repository: dolphin
Actor: degasus
Payload: {"action":"opened","number":1269,"pull_request":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/1269","id":22620843,"html_url":"https://github.com/dolphin-emu/dolphin/pull/1269","diff_url":"https://github.com/dolphin-emu/dolphin/pull/1269.diff","patch_url":"https://github.com/dolphin-emu/dolphin/pull/1269.patch","issue_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/1269","number":1269,"state":"open","locked":false,"title":"VertexLoader: Skip vertices with index = -1","user":{"login":"degasus","id":2787141,"avatar_url":"https://avatars.githubusercontent.com/u/2787141?v=2","gravatar_id":"","url":"https://api.github.com/users/degasus","html_url":"https://github.com/degasus","followers_url":"https://api.github.com/users/degasus/followers","following_url":"https://api.github.com/users/degasus/following{/other_user}","gists_url":"https://api.github.com/users/degasus/gists{/gist_id}","starred_url":"https://api.github.com/users/degasus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/degasus/subscriptions","organizations_url":"https://api.github.com/users/degasus/orgs","repos_url":"https://api.github.com/users/degasus/repos","events_url":"https://api.github.com/users/degasus/events{/privacy}","received_events_url":"https://api.github.com/users/degasus/received_events","type":"User","site_admin":false},"body":"This patches emits NaNs for all position indices with the index -1. This vertices should be skipped, but this would require a huge redesign of the vertex loader. So just emit NaNs which results in skipped primitives.\r\nThis may be wrong if the winding of strips matters, for quads, ... - but it's still much better than now.","created_at":"2014-10-12T21:57:16Z","updated_at":"2014-10-12T21:57:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/1269/commits","review_comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/1269/comments","review_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/{number}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/1269/comments","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/f12def6eedf6913724df560febbc709a300c2d8a","head":{"label":"degasus:vertexloaderfixes","ref":"vertexloaderfixes","sha":"f12def6eedf6913724df560febbc709a300c2d8a","user":{"login":"degasus","id":2787141,"avatar_url":"https://avatars.githubusercontent.com/u/2787141?v=2","gravatar_id":"","url":"https://api.github.com/users/degasus","html_url":"https://github.com/degasus","followers_url":"https://api.github.com/users/degasus/followers","following_url":"https://api.github.com/users/degasus/following{/other_user}","gists_url":"https://api.github.com/users/degasus/gists{/gist_id}","starred_url":"https://api.github.com/users/degasus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/degasus/subscriptions","organizations_url":"https://api.github.com/users/degasus/orgs","repos_url":"https://api.github.com/users/degasus/repos","events_url":"https://api.github.com/users/degasus/events{/privacy}","received_events_url":"https://api.github.com/users/degasus/received_events","type":"User","site_admin":false},"repo":{"id":16313731,"name":"dolphin","full_name":"degasus/dolphin","owner":{"login":"degasus","id":2787141,"avatar_url":"https://avatars.githubusercontent.com/u/2787141?v=2","gravatar_id":"","url":"https://api.github.com/users/degasus","html_url":"https://github.com/degasus","followers_url":"https://api.github.com/users/degasus/followers","following_url":"https://api.github.com/users/degasus/following{/other_user}","gists_url":"https://api.github.com/users/degasus/gists{/gist_id}","starred_url":"https://api.github.com/users/degasus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/degasus/subscriptions","organizations_url":"https://api.github.com/users/degasus/orgs","repos_url":"https://api.github.com/users/degasus/repos","events_url":"https://api.github.com/users/degasus/events{/privacy}","received_events_url":"https://api.github.com/users/degasus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/degasus/dolphin","description":"Dolphin is a GameCube/Wii emulator, allowing you to play games for these two platforms on PC, with improvements.","fork":true,"url":"https://api.github.com/repos/degasus/dolphin","forks_url":"https://api.github.com/repos/degasus/dolphin/forks","keys_url":"https://api.github.com/repos/degasus/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/degasus/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/degasus/dolphin/teams","hooks_url":"https://api.github.com/repos/degasus/dolphin/hooks","issue_events_url":"https://api.github.com/repos/degasus/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/degasus/dolphin/events","assignees_url":"https://api.github.com/repos/degasus/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/degasus/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/degasus/dolphin/tags","blobs_url":"https://api.github.com/repos/degasus/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/degasus/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/degasus/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/degasus/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/degasus/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/degasus/dolphin/languages","stargazers_url":"https://api.github.com/repos/degasus/dolphin/stargazers","contributors_url":"https://api.github.com/repos/degasus/dolphin/contributors","subscribers_url":"https://api.github.com/repos/degasus/dolphin/subscribers","subscription_url":"https://api.github.com/repos/degasus/dolphin/subscription","commits_url":"https://api.github.com/repos/degasus/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/degasus/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/degasus/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/degasus/dolphin/issues/comments/{number}","contents_url":"https://api.github.com/repos/degasus/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/degasus/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/degasus/dolphin/merges","archive_url":"https://api.github.com/repos/degasus/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/degasus/dolphin/downloads","issues_url":"https://api.github.com/repos/degasus/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/degasus/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/degasus/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/degasus/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/degasus/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/degasus/dolphin/releases{/id}","created_at":"2014-01-28T14:18:33Z","updated_at":"2014-07-06T09:06:03Z","pushed_at":"2014-10-12T21:57:00Z","git_url":"git://github.com/degasus/dolphin.git","ssh_url":"git@github.com:degasus/dolphin.git","clone_url":"https://github.com/degasus/dolphin.git","svn_url":"https://github.com/degasus/dolphin","homepage":null,"size":186994,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dolphin-emu:master","ref":"master","sha":"18c81dbc3325309323885be3b61861cc57746de2","user":{"login":"dolphin-emu","id":5050316,"avatar_url":"https://avatars.githubusercontent.com/u/5050316?v=2","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"repo":{"id":11577304,"name":"dolphin","full_name":"dolphin-emu/dolphin","owner":{"login":"dolphin-emu","id":5050316,"avatar_url":"https://avatars.githubusercontent.com/u/5050316?v=2","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dolphin-emu/dolphin","description":"Dolphin is a GameCube/Wii emulator, allowing you to play games for these two platforms on PC, with improvements.","fork":false,"url":"https://api.github.com/repos/dolphin-emu/dolphin","forks_url":"https://api.github.com/repos/dolphin-emu/dolphin/forks","keys_url":"https://api.github.com/repos/dolphin-emu/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dolphin-emu/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dolphin-emu/dolphin/teams","hooks_url":"https://api.github.com/repos/dolphin-emu/dolphin/hooks","issue_events_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/dolphin-emu/dolphin/events","assignees_url":"https://api.github.com/repos/dolphin-emu/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/dolphin-emu/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/tags","blobs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/dolphin-emu/dolphin/languages","stargazers_url":"https://api.github.com/repos/dolphin-emu/dolphin/stargazers","contributors_url":"https://api.github.com/repos/dolphin-emu/dolphin/contributors","subscribers_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscribers","subscription_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscription","commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/comments/{number}","contents_url":"https://api.github.com/repos/dolphin-emu/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/dolphin-emu/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dolphin-emu/dolphin/merges","archive_url":"https://api.github.com/repos/dolphin-emu/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dolphin-emu/dolphin/downloads","issues_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/dolphin-emu/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/dolphin-emu/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dolphin-emu/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/dolphin-emu/dolphin/releases{/id}","created_at":"2013-07-22T09:07:57Z","updated_at":"2014-10-12T21:22:56Z","pushed_at":"2014-10-12T03:26:24Z","git_url":"git://github.com/dolphin-emu/dolphin.git","ssh_url":"git@github.com:dolphin-emu/dolphin.git","clone_url":"https://github.com/dolphin-emu/dolphin.git","svn_url":"https://github.com/dolphin-emu/dolphin","homepage":null,"size":252774,"stargazers_count":635,"watchers_count":635,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":210,"mirror_url":null,"open_issues_count":49,"forks":210,"open_issues":49,"watchers":635,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/1269"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/1269"},"issue":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/1269"},"comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/1269/comments"},"review_comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/1269/comments"},"review_comment":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/1269/commits"},"statuses":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/f12def6eedf6913724df560febbc709a300c2d8a"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":24,"deletions":6,"changed_files":1}}