GitHub PullRequestReviewCommentEvent at 2014-07-31 14:15:02
Repository: odoo
Actor: xmo-odoo
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/odoo/odoo/pulls/comments/15644097","id":15644097,"diff_hunk":"@@ -295,11 +295,37 @@ def set_translations(self, data, lang):\n                         new_trans['gengo_comment'] = t.get('gengo_comment')\n                     irt.create(request.cr, request.uid, new_trans)\n         return True\n+    \n+    def compress_image(self, image, quality):\n+        image_format = image.format\n+        optimized = True\n+        if quality == '95':\n+            optimized = False ","path":"addons/website/controllers/main.py","position":9,"original_position":9,"commit_id":"07ec384ef11f7974d3af1b773f39210cdb0c4aab","original_commit_id":"79f195e8c14144397699af2cc0679e7d7ce9c793","user":{"login":"xmo-odoo","id":7571158,"avatar_url":"https://avatars.githubusercontent.com/u/7571158?v=1","gravatar_id":"2b4ebbf353587634810d8c47722cee1a","url":"https://api.github.com/users/xmo-odoo","html_url":"https://github.com/xmo-odoo","followers_url":"https://api.github.com/users/xmo-odoo/followers","following_url":"https://api.github.com/users/xmo-odoo/following{/other_user}","gists_url":"https://api.github.com/users/xmo-odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/xmo-odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xmo-odoo/subscriptions","organizations_url":"https://api.github.com/users/xmo-odoo/orgs","repos_url":"https://api.github.com/users/xmo-odoo/repos","events_url":"https://api.github.com/users/xmo-odoo/events{/privacy}","received_events_url":"https://api.github.com/users/xmo-odoo/received_events","type":"User","site_admin":false},"body":"According to the documentation, `optimize` seems to be lossless, it simply makes more passes to select optimal encoder settings.","created_at":"2014-07-31T14:15:02Z","updated_at":"2014-07-31T14:15:02Z","html_url":"https://github.com/odoo/odoo/pull/1417#discussion_r15644097","pull_request_url":"https://api.github.com/repos/odoo/odoo/pulls/1417","_links":{"self":{"href":"https://api.github.com/repos/odoo/odoo/pulls/comments/15644097"},"html":{"href":"https://github.com/odoo/odoo/pull/1417#discussion_r15644097"},"pull_request":{"href":"https://api.github.com/repos/odoo/odoo/pulls/1417"}}},"pull_request":{"url":"https://api.github.com/repos/odoo/odoo/pulls/1417","id":18965495,"html_url":"https://github.com/odoo/odoo/pull/1417","diff_url":"https://github.com/odoo/odoo/pull/1417.diff","patch_url":"https://github.com/odoo/odoo/pull/1417.patch","issue_url":"https://api.github.com/repos/odoo/odoo/issues/1417","number":1417,"state":"open","title":"Compress images to upload on website","user":{"login":"nja-odoo","id":7599705,"avatar_url":"https://avatars.githubusercontent.com/u/7599705?v=1","gravatar_id":"2ba8aad6b5efb4ae4355ed8678b6db51","url":"https://api.github.com/users/nja-odoo","html_url":"https://github.com/nja-odoo","followers_url":"https://api.github.com/users/nja-odoo/followers","following_url":"https://api.github.com/users/nja-odoo/following{/other_user}","gists_url":"https://api.github.com/users/nja-odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/nja-odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nja-odoo/subscriptions","organizations_url":"https://api.github.com/users/nja-odoo/orgs","repos_url":"https://api.github.com/users/nja-odoo/repos","events_url":"https://api.github.com/users/nja-odoo/events{/privacy}","received_events_url":"https://api.github.com/users/nja-odoo/received_events","type":"User","site_admin":false},"body":"Compress images and upload them on website using the quality selected by user.\r\n\r\nTask: https://openerp.my.openerp.com/web?#id=8680&view_type=form&model=project.task&menu_id=3942&action=327\r\nPad: https://pad.odoo.com/p/r.BpiW2XLoXNlh35yj\r\n\r\nThanks\r\n","created_at":"2014-07-28T13:04:44Z","updated_at":"2014-07-31T14:15:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"be8ccb2a9df7717c646bae7c0a094bf316e8dc6c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/odoo/odoo/pulls/1417/commits","review_comments_url":"https://api.github.com/repos/odoo/odoo/pulls/1417/comments","review_comment_url":"https://api.github.com/repos/odoo/odoo/pulls/comments/{number}","comments_url":"https://api.github.com/repos/odoo/odoo/issues/1417/comments","statuses_url":"https://api.github.com/repos/odoo/odoo/statuses/07ec384ef11f7974d3af1b773f39210cdb0c4aab","head":{"label":"odoo-dev:master-website-image-reduction-nja","ref":"master-website-image-reduction-nja","sha":"07ec384ef11f7974d3af1b773f39210cdb0c4aab","user":{"login":"odoo-dev","id":7466976,"avatar_url":"https://avatars.githubusercontent.com/u/7466976?v=1","gravatar_id":null,"url":"https://api.github.com/users/odoo-dev","html_url":"https://github.com/odoo-dev","followers_url":"https://api.github.com/users/odoo-dev/followers","following_url":"https://api.github.com/users/odoo-dev/following{/other_user}","gists_url":"https://api.github.com/users/odoo-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/odoo-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoo-dev/subscriptions","organizations_url":"https://api.github.com/users/odoo-dev/orgs","repos_url":"https://api.github.com/users/odoo-dev/repos","events_url":"https://api.github.com/users/odoo-dev/events{/privacy}","received_events_url":"https://api.github.com/users/odoo-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":19853934,"name":"odoo","full_name":"odoo-dev/odoo","owner":{"login":"odoo-dev","id":7466976,"avatar_url":"https://avatars.githubusercontent.com/u/7466976?v=1","gravatar_id":null,"url":"https://api.github.com/users/odoo-dev","html_url":"https://github.com/odoo-dev","followers_url":"https://api.github.com/users/odoo-dev/followers","following_url":"https://api.github.com/users/odoo-dev/following{/other_user}","gists_url":"https://api.github.com/users/odoo-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/odoo-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoo-dev/subscriptions","organizations_url":"https://api.github.com/users/odoo-dev/orgs","repos_url":"https://api.github.com/users/odoo-dev/repos","events_url":"https://api.github.com/users/odoo-dev/events{/privacy}","received_events_url":"https://api.github.com/users/odoo-dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/odoo-dev/odoo","description":"RD Dev Repository","fork":true,"url":"https://api.github.com/repos/odoo-dev/odoo","forks_url":"https://api.github.com/repos/odoo-dev/odoo/forks","keys_url":"https://api.github.com/repos/odoo-dev/odoo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/odoo-dev/odoo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/odoo-dev/odoo/teams","hooks_url":"https://api.github.com/repos/odoo-dev/odoo/hooks","issue_events_url":"https://api.github.com/repos/odoo-dev/odoo/issues/events{/number}","events_url":"https://api.github.com/repos/odoo-dev/odoo/events","assignees_url":"https://api.github.com/repos/odoo-dev/odoo/assignees{/user}","branches_url":"https://api.github.com/repos/odoo-dev/odoo/branches{/branch}","tags_url":"https://api.github.com/repos/odoo-dev/odoo/tags","blobs_url":"https://api.github.com/repos/odoo-dev/odoo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/odoo-dev/odoo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/odoo-dev/odoo/git/refs{/sha}","trees_url":"https://api.github.com/repos/odoo-dev/odoo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/odoo-dev/odoo/statuses/{sha}","languages_url":"https://api.github.com/repos/odoo-dev/odoo/languages","stargazers_url":"https://api.github.com/repos/odoo-dev/odoo/stargazers","contributors_url":"https://api.github.com/repos/odoo-dev/odoo/contributors","subscribers_url":"https://api.github.com/repos/odoo-dev/odoo/subscribers","subscription_url":"https://api.github.com/repos/odoo-dev/odoo/subscription","commits_url":"https://api.github.com/repos/odoo-dev/odoo/commits{/sha}","git_commits_url":"https://api.github.com/repos/odoo-dev/odoo/git/commits{/sha}","comments_url":"https://api.github.com/repos/odoo-dev/odoo/comments{/number}","issue_comment_url":"https://api.github.com/repos/odoo-dev/odoo/issues/comments/{number}","contents_url":"https://api.github.com/repos/odoo-dev/odoo/contents/{+path}","compare_url":"https://api.github.com/repos/odoo-dev/odoo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/odoo-dev/odoo/merges","archive_url":"https://api.github.com/repos/odoo-dev/odoo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/odoo-dev/odoo/downloads","issues_url":"https://api.github.com/repos/odoo-dev/odoo/issues{/number}","pulls_url":"https://api.github.com/repos/odoo-dev/odoo/pulls{/number}","milestones_url":"https://api.github.com/repos/odoo-dev/odoo/milestones{/number}","notifications_url":"https://api.github.com/repos/odoo-dev/odoo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/odoo-dev/odoo/labels{/name}","releases_url":"https://api.github.com/repos/odoo-dev/odoo/releases{/id}","created_at":"2014-05-16T11:16:19Z","updated_at":"2014-07-31T05:39:39Z","pushed_at":"2014-07-31T14:10:06Z","git_url":"git://github.com/odoo-dev/odoo.git","ssh_url":"git@github.com:odoo-dev/odoo.git","clone_url":"https://github.com/odoo-dev/odoo.git","svn_url":"https://github.com/odoo-dev/odoo","homepage":"https://www.odoo.com","size":855128,"stargazers_count":26,"watchers_count":26,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":7,"mirror_url":null,"open_issues_count":9,"forks":7,"open_issues":9,"watchers":26,"default_branch":"master"}},"base":{"label":"odoo:master","ref":"master","sha":"24ce30b94504df98942fc771ff1ee07c46684ad8","user":{"login":"odoo","id":6368483,"avatar_url":"https://avatars.githubusercontent.com/u/6368483?v=1","gravatar_id":null,"url":"https://api.github.com/users/odoo","html_url":"https://github.com/odoo","followers_url":"https://api.github.com/users/odoo/followers","following_url":"https://api.github.com/users/odoo/following{/other_user}","gists_url":"https://api.github.com/users/odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoo/subscriptions","organizations_url":"https://api.github.com/users/odoo/orgs","repos_url":"https://api.github.com/users/odoo/repos","events_url":"https://api.github.com/users/odoo/events{/privacy}","received_events_url":"https://api.github.com/users/odoo/received_events","type":"Organization","site_admin":false},"repo":{"id":19745004,"name":"odoo","full_name":"odoo/odoo","owner":{"login":"odoo","id":6368483,"avatar_url":"https://avatars.githubusercontent.com/u/6368483?v=1","gravatar_id":null,"url":"https://api.github.com/users/odoo","html_url":"https://github.com/odoo","followers_url":"https://api.github.com/users/odoo/followers","following_url":"https://api.github.com/users/odoo/following{/other_user}","gists_url":"https://api.github.com/users/odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoo/subscriptions","organizations_url":"https://api.github.com/users/odoo/orgs","repos_url":"https://api.github.com/users/odoo/repos","events_url":"https://api.github.com/users/odoo/events{/privacy}","received_events_url":"https://api.github.com/users/odoo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/odoo/odoo","description":"Odoo (formerly OpenERP). Open Source Business Apps.","fork":false,"url":"https://api.github.com/repos/odoo/odoo","forks_url":"https://api.github.com/repos/odoo/odoo/forks","keys_url":"https://api.github.com/repos/odoo/odoo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/odoo/odoo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/odoo/odoo/teams","hooks_url":"https://api.github.com/repos/odoo/odoo/hooks","issue_events_url":"https://api.github.com/repos/odoo/odoo/issues/events{/number}","events_url":"https://api.github.com/repos/odoo/odoo/events","assignees_url":"https://api.github.com/repos/odoo/odoo/assignees{/user}","branches_url":"https://api.github.com/repos/odoo/odoo/branches{/branch}","tags_url":"https://api.github.com/repos/odoo/odoo/tags","blobs_url":"https://api.github.com/repos/odoo/odoo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/odoo/odoo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/odoo/odoo/git/refs{/sha}","trees_url":"https://api.github.com/repos/odoo/odoo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/odoo/odoo/statuses/{sha}","languages_url":"https://api.github.com/repos/odoo/odoo/languages","stargazers_url":"https://api.github.com/repos/odoo/odoo/stargazers","contributors_url":"https://api.github.com/repos/odoo/odoo/contributors","subscribers_url":"https://api.github.com/repos/odoo/odoo/subscribers","subscription_url":"https://api.github.com/repos/odoo/odoo/subscription","commits_url":"https://api.github.com/repos/odoo/odoo/commits{/sha}","git_commits_url":"https://api.github.com/repos/odoo/odoo/git/commits{/sha}","comments_url":"https://api.github.com/repos/odoo/odoo/comments{/number}","issue_comment_url":"https://api.github.com/repos/odoo/odoo/issues/comments/{number}","contents_url":"https://api.github.com/repos/odoo/odoo/contents/{+path}","compare_url":"https://api.github.com/repos/odoo/odoo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/odoo/odoo/merges","archive_url":"https://api.github.com/repos/odoo/odoo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/odoo/odoo/downloads","issues_url":"https://api.github.com/repos/odoo/odoo/issues{/number}","pulls_url":"https://api.github.com/repos/odoo/odoo/pulls{/number}","milestones_url":"https://api.github.com/repos/odoo/odoo/milestones{/number}","notifications_url":"https://api.github.com/repos/odoo/odoo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/odoo/odoo/labels{/name}","releases_url":"https://api.github.com/repos/odoo/odoo/releases{/id}","created_at":"2014-05-13T15:38:58Z","updated_at":"2014-07-31T12:43:52Z","pushed_at":"2014-07-31T14:07:09Z","git_url":"git://github.com/odoo/odoo.git","ssh_url":"git@github.com:odoo/odoo.git","clone_url":"https://github.com/odoo/odoo.git","svn_url":"https://github.com/odoo/odoo","homepage":"https://www.odoo.com","size":789060,"stargazers_count":965,"watchers_count":965,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":723,"mirror_url":null,"open_issues_count":641,"forks":723,"open_issues":641,"watchers":965,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/odoo/odoo/pulls/1417"},"html":{"href":"https://github.com/odoo/odoo/pull/1417"},"issue":{"href":"https://api.github.com/repos/odoo/odoo/issues/1417"},"comments":{"href":"https://api.github.com/repos/odoo/odoo/issues/1417/comments"},"review_comments":{"href":"https://api.github.com/repos/odoo/odoo/pulls/1417/comments"},"review_comment":{"href":"https://api.github.com/repos/odoo/odoo/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/odoo/odoo/pulls/1417/commits"},"statuses":{"href":"https://api.github.com/repos/odoo/odoo/statuses/07ec384ef11f7974d3af1b773f39210cdb0c4aab"}}}}