GitHub PullRequestReviewCommentEvent at 2014-12-05 09:56:44
Repository: cpp-ethereum
Actor: CJentzsch
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/comments/21363794","id":21363794,"diff_hunk":"@@ -32,53 +33,85 @@ namespace solidity {\n \n // forward declarations\n class Scanner;\n-class ContractDefinition;\n+class SourceUnit;\n class Compiler;\n class GlobalContext;\n+class ContractDefinition;\n \n /**\n  * Easy to use and self-contained Solidity compiler with as few header dependencies as possible.\n  * It holds state and can be used to either step through the compilation stages (and abort e.g.\n  * before compilation to bytecode) or run the whole compilation in one call.\n  */\n-class CompilerStack\n+class CompilerStack: boost::noncopyable\n {\n public:\n-\tCompilerStack() {}\n-\tvoid reset() {  *this = CompilerStack(); }\n+\tCompilerStack(): m_parseSuccessful(false) {}\n+\t/// Adds a source object (e.g. file) to the parser. After this, parse has to be called again.\n+\tvoid addSource(std::string const& _name, std::string const& _content);\n \tvoid setSource(std::string const& _sourceCode);\n+\t/// Parses all source units that were added\n \tvoid parse();\n+\t/// Sets the given source code as the only source unit and parses it.\n \tvoid parse(std::string const& _sourceCode);\n-\t/// Compiles the contract that was previously parsed.\n-\tbytes const& compile(bool _optimize = false);\n+\t/// Returns a list of the contract names in the sources.\n+\tstd::vector<std::string> getContractNames();\n+\n+\t/// Compiles the source units that were prevously added and parsed.","path":"libsolidity/CompilerStack.h","position":42,"original_position":42,"commit_id":"04c8d8bdc08398089225c3e134df8ad533c887b8","original_commit_id":"04c8d8bdc08398089225c3e134df8ad533c887b8","user":{"login":"CJentzsch","id":8452011,"avatar_url":"https://avatars.githubusercontent.com/u/8452011?v=3","gravatar_id":"","url":"https://api.github.com/users/CJentzsch","html_url":"https://github.com/CJentzsch","followers_url":"https://api.github.com/users/CJentzsch/followers","following_url":"https://api.github.com/users/CJentzsch/following{/other_user}","gists_url":"https://api.github.com/users/CJentzsch/gists{/gist_id}","starred_url":"https://api.github.com/users/CJentzsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CJentzsch/subscriptions","organizations_url":"https://api.github.com/users/CJentzsch/orgs","repos_url":"https://api.github.com/users/CJentzsch/repos","events_url":"https://api.github.com/users/CJentzsch/events{/privacy}","received_events_url":"https://api.github.com/users/CJentzsch/received_events","type":"User","site_admin":false},"body":"little typo previously","created_at":"2014-12-05T09:56:44Z","updated_at":"2014-12-05T09:56:44Z","html_url":"https://github.com/ethereum/cpp-ethereum/pull/558#discussion_r21363794","pull_request_url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/558","_links":{"self":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/comments/21363794"},"html":{"href":"https://github.com/ethereum/cpp-ethereum/pull/558#discussion_r21363794"},"pull_request":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/558"}}},"pull_request":{"url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/558","id":25437995,"html_url":"https://github.com/ethereum/cpp-ethereum/pull/558","diff_url":"https://github.com/ethereum/cpp-ethereum/pull/558.diff","patch_url":"https://github.com/ethereum/cpp-ethereum/pull/558.patch","issue_url":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/558","number":558,"state":"open","locked":false,"title":"Solidity for multiple files and multiple contracts per file.","user":{"login":"chriseth","id":9073706,"avatar_url":"https://avatars.githubusercontent.com/u/9073706?v=3","gravatar_id":"","url":"https://api.github.com/users/chriseth","html_url":"https://github.com/chriseth","followers_url":"https://api.github.com/users/chriseth/followers","following_url":"https://api.github.com/users/chriseth/following{/other_user}","gists_url":"https://api.github.com/users/chriseth/gists{/gist_id}","starred_url":"https://api.github.com/users/chriseth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chriseth/subscriptions","organizations_url":"https://api.github.com/users/chriseth/orgs","repos_url":"https://api.github.com/users/chriseth/repos","events_url":"https://api.github.com/users/chriseth/events{/privacy}","received_events_url":"https://api.github.com/users/chriseth/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-12-03T17:53:56Z","updated_at":"2014-12-05T09:56:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6b6e1399cd98efdd57f468ea279caae75edecf93","assignee":{"login":"chriseth","id":9073706,"avatar_url":"https://avatars.githubusercontent.com/u/9073706?v=3","gravatar_id":"","url":"https://api.github.com/users/chriseth","html_url":"https://github.com/chriseth","followers_url":"https://api.github.com/users/chriseth/followers","following_url":"https://api.github.com/users/chriseth/following{/other_user}","gists_url":"https://api.github.com/users/chriseth/gists{/gist_id}","starred_url":"https://api.github.com/users/chriseth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chriseth/subscriptions","organizations_url":"https://api.github.com/users/chriseth/orgs","repos_url":"https://api.github.com/users/chriseth/repos","events_url":"https://api.github.com/users/chriseth/events{/privacy}","received_events_url":"https://api.github.com/users/chriseth/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/558/commits","review_comments_url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/558/comments","review_comment_url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/558/comments","statuses_url":"https://api.github.com/repos/ethereum/cpp-ethereum/statuses/04c8d8bdc08398089225c3e134df8ad533c887b8","head":{"label":"chriseth:sol_import","ref":"sol_import","sha":"04c8d8bdc08398089225c3e134df8ad533c887b8","user":{"login":"chriseth","id":9073706,"avatar_url":"https://avatars.githubusercontent.com/u/9073706?v=3","gravatar_id":"","url":"https://api.github.com/users/chriseth","html_url":"https://github.com/chriseth","followers_url":"https://api.github.com/users/chriseth/followers","following_url":"https://api.github.com/users/chriseth/following{/other_user}","gists_url":"https://api.github.com/users/chriseth/gists{/gist_id}","starred_url":"https://api.github.com/users/chriseth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chriseth/subscriptions","organizations_url":"https://api.github.com/users/chriseth/orgs","repos_url":"https://api.github.com/users/chriseth/repos","events_url":"https://api.github.com/users/chriseth/events{/privacy}","received_events_url":"https://api.github.com/users/chriseth/received_events","type":"User","site_admin":false},"repo":{"id":24932538,"name":"cpp-ethereum","full_name":"chriseth/cpp-ethereum","owner":{"login":"chriseth","id":9073706,"avatar_url":"https://avatars.githubusercontent.com/u/9073706?v=3","gravatar_id":"","url":"https://api.github.com/users/chriseth","html_url":"https://github.com/chriseth","followers_url":"https://api.github.com/users/chriseth/followers","following_url":"https://api.github.com/users/chriseth/following{/other_user}","gists_url":"https://api.github.com/users/chriseth/gists{/gist_id}","starred_url":"https://api.github.com/users/chriseth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chriseth/subscriptions","organizations_url":"https://api.github.com/users/chriseth/orgs","repos_url":"https://api.github.com/users/chriseth/repos","events_url":"https://api.github.com/users/chriseth/events{/privacy}","received_events_url":"https://api.github.com/users/chriseth/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chriseth/cpp-ethereum","description":"Gavin Wood's C++ implementation of the Ethereum yellowpaper.","fork":true,"url":"https://api.github.com/repos/chriseth/cpp-ethereum","forks_url":"https://api.github.com/repos/chriseth/cpp-ethereum/forks","keys_url":"https://api.github.com/repos/chriseth/cpp-ethereum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chriseth/cpp-ethereum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chriseth/cpp-ethereum/teams","hooks_url":"https://api.github.com/repos/chriseth/cpp-ethereum/hooks","issue_events_url":"https://api.github.com/repos/chriseth/cpp-ethereum/issues/events{/number}","events_url":"https://api.github.com/repos/chriseth/cpp-ethereum/events","assignees_url":"https://api.github.com/repos/chriseth/cpp-ethereum/assignees{/user}","branches_url":"https://api.github.com/repos/chriseth/cpp-ethereum/branches{/branch}","tags_url":"https://api.github.com/repos/chriseth/cpp-ethereum/tags","blobs_url":"https://api.github.com/repos/chriseth/cpp-ethereum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chriseth/cpp-ethereum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chriseth/cpp-ethereum/git/refs{/sha}","trees_url":"https://api.github.com/repos/chriseth/cpp-ethereum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chriseth/cpp-ethereum/statuses/{sha}","languages_url":"https://api.github.com/repos/chriseth/cpp-ethereum/languages","stargazers_url":"https://api.github.com/repos/chriseth/cpp-ethereum/stargazers","contributors_url":"https://api.github.com/repos/chriseth/cpp-ethereum/contributors","subscribers_url":"https://api.github.com/repos/chriseth/cpp-ethereum/subscribers","subscription_url":"https://api.github.com/repos/chriseth/cpp-ethereum/subscription","commits_url":"https://api.github.com/repos/chriseth/cpp-ethereum/commits{/sha}","git_commits_url":"https://api.github.com/repos/chriseth/cpp-ethereum/git/commits{/sha}","comments_url":"https://api.github.com/repos/chriseth/cpp-ethereum/comments{/number}","issue_comment_url":"https://api.github.com/repos/chriseth/cpp-ethereum/issues/comments/{number}","contents_url":"https://api.github.com/repos/chriseth/cpp-ethereum/contents/{+path}","compare_url":"https://api.github.com/repos/chriseth/cpp-ethereum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chriseth/cpp-ethereum/merges","archive_url":"https://api.github.com/repos/chriseth/cpp-ethereum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chriseth/cpp-ethereum/downloads","issues_url":"https://api.github.com/repos/chriseth/cpp-ethereum/issues{/number}","pulls_url":"https://api.github.com/repos/chriseth/cpp-ethereum/pulls{/number}","milestones_url":"https://api.github.com/repos/chriseth/cpp-ethereum/milestones{/number}","notifications_url":"https://api.github.com/repos/chriseth/cpp-ethereum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chriseth/cpp-ethereum/labels{/name}","releases_url":"https://api.github.com/repos/chriseth/cpp-ethereum/releases{/id}","created_at":"2014-10-08T09:01:35Z","updated_at":"2014-10-10T15:01:57Z","pushed_at":"2014-12-04T18:38:30Z","git_url":"git://github.com/chriseth/cpp-ethereum.git","ssh_url":"git@github.com:chriseth/cpp-ethereum.git","clone_url":"https://github.com/chriseth/cpp-ethereum.git","svn_url":"https://github.com/chriseth/cpp-ethereum","homepage":"www.gavwood.com/Paper.pdf","size":21017,"stargazers_count":1,"watchers_count":1,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"develop"}},"base":{"label":"ethereum:develop","ref":"develop","sha":"9e5a49736cb212468023244d3ae6d5b9c44feb84","user":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars.githubusercontent.com/u/6250754?v=3","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"repo":{"id":15460666,"name":"cpp-ethereum","full_name":"ethereum/cpp-ethereum","owner":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars.githubusercontent.com/u/6250754?v=3","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethereum/cpp-ethereum","description":"Gavin Wood's C++ implementation of the Ethereum yellowpaper.","fork":false,"url":"https://api.github.com/repos/ethereum/cpp-ethereum","forks_url":"https://api.github.com/repos/ethereum/cpp-ethereum/forks","keys_url":"https://api.github.com/repos/ethereum/cpp-ethereum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereum/cpp-ethereum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereum/cpp-ethereum/teams","hooks_url":"https://api.github.com/repos/ethereum/cpp-ethereum/hooks","issue_events_url":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/events{/number}","events_url":"https://api.github.com/repos/ethereum/cpp-ethereum/events","assignees_url":"https://api.github.com/repos/ethereum/cpp-ethereum/assignees{/user}","branches_url":"https://api.github.com/repos/ethereum/cpp-ethereum/branches{/branch}","tags_url":"https://api.github.com/repos/ethereum/cpp-ethereum/tags","blobs_url":"https://api.github.com/repos/ethereum/cpp-ethereum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereum/cpp-ethereum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereum/cpp-ethereum/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereum/cpp-ethereum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereum/cpp-ethereum/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereum/cpp-ethereum/languages","stargazers_url":"https://api.github.com/repos/ethereum/cpp-ethereum/stargazers","contributors_url":"https://api.github.com/repos/ethereum/cpp-ethereum/contributors","subscribers_url":"https://api.github.com/repos/ethereum/cpp-ethereum/subscribers","subscription_url":"https://api.github.com/repos/ethereum/cpp-ethereum/subscription","commits_url":"https://api.github.com/repos/ethereum/cpp-ethereum/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereum/cpp-ethereum/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereum/cpp-ethereum/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/comments/{number}","contents_url":"https://api.github.com/repos/ethereum/cpp-ethereum/contents/{+path}","compare_url":"https://api.github.com/repos/ethereum/cpp-ethereum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereum/cpp-ethereum/merges","archive_url":"https://api.github.com/repos/ethereum/cpp-ethereum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereum/cpp-ethereum/downloads","issues_url":"https://api.github.com/repos/ethereum/cpp-ethereum/issues{/number}","pulls_url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereum/cpp-ethereum/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereum/cpp-ethereum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereum/cpp-ethereum/labels{/name}","releases_url":"https://api.github.com/repos/ethereum/cpp-ethereum/releases{/id}","created_at":"2013-12-26T21:26:06Z","updated_at":"2014-12-05T09:56:22Z","pushed_at":"2014-12-05T09:56:21Z","git_url":"git://github.com/ethereum/cpp-ethereum.git","ssh_url":"git@github.com:ethereum/cpp-ethereum.git","clone_url":"https://github.com/ethereum/cpp-ethereum.git","svn_url":"https://github.com/ethereum/cpp-ethereum","homepage":"www.gavwood.com/Paper.pdf","size":23079,"stargazers_count":353,"watchers_count":353,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":127,"mirror_url":null,"open_issues_count":57,"forks":127,"open_issues":57,"watchers":353,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/558"},"html":{"href":"https://github.com/ethereum/cpp-ethereum/pull/558"},"issue":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/558"},"comments":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/558/comments"},"review_comments":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/558/comments"},"review_comment":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/558/commits"},"statuses":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/statuses/04c8d8bdc08398089225c3e134df8ad533c887b8"}}}}