GitHub PullRequestReviewCommentEvent at 2014-10-17 19:43:27
Repository: CPAProxy
Actor: chrisballinger
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/ursachec/CPAProxy/pulls/comments/19038794","id":19038794,"diff_hunk":"@@ -16,35 +17,18 @@\n  \n  The authentication message needs to be sent before any other control commands can be accepted.\n  */\n-- (void)cpa_sendAuthenticate;\n+- (void)cpa_sendAuthenticateWihtCompletion:(CPAProxyCommandResponseBlock)completion;","path":"CPAProxy/CPAProxyManager+TorCommands.h","position":13,"original_position":13,"commit_id":"7d1ad8ae8fce9990bf6a316d5e642348a3ca9657","original_commit_id":"7d1ad8ae8fce9990bf6a316d5e642348a3ca9657","user":{"login":"chrisballinger","id":518687,"avatar_url":"https://avatars.githubusercontent.com/u/518687?v=2","gravatar_id":"","url":"https://api.github.com/users/chrisballinger","html_url":"https://github.com/chrisballinger","followers_url":"https://api.github.com/users/chrisballinger/followers","following_url":"https://api.github.com/users/chrisballinger/following{/other_user}","gists_url":"https://api.github.com/users/chrisballinger/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisballinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisballinger/subscriptions","organizations_url":"https://api.github.com/users/chrisballinger/orgs","repos_url":"https://api.github.com/users/chrisballinger/repos","events_url":"https://api.github.com/users/chrisballinger/events{/privacy}","received_events_url":"https://api.github.com/users/chrisballinger/received_events","type":"User","site_admin":false},"body":"@davidchiles Typo \"Wiht\", also a completionQueue parameter should be provided:\r\n\r\n* `cpa_sendAuthenticateWithCompletion:completionQueue:` ","created_at":"2014-10-17T19:43:27Z","updated_at":"2014-10-17T19:43:27Z","html_url":"https://github.com/ursachec/CPAProxy/pull/15#discussion_r19038794","pull_request_url":"https://api.github.com/repos/ursachec/CPAProxy/pulls/15","_links":{"self":{"href":"https://api.github.com/repos/ursachec/CPAProxy/pulls/comments/19038794"},"html":{"href":"https://github.com/ursachec/CPAProxy/pull/15#discussion_r19038794"},"pull_request":{"href":"https://api.github.com/repos/ursachec/CPAProxy/pulls/15"}}},"pull_request":{"url":"https://api.github.com/repos/ursachec/CPAProxy/pulls/15","id":22942988,"html_url":"https://github.com/ursachec/CPAProxy/pull/15","diff_url":"https://github.com/ursachec/CPAProxy/pull/15.diff","patch_url":"https://github.com/ursachec/CPAProxy/pull/15.patch","issue_url":"https://api.github.com/repos/ursachec/CPAProxy/issues/15","number":15,"state":"open","locked":false,"title":"Added GCDAsyncSocket & tor control port commands and response parsing","user":{"login":"davidchiles","id":309772,"avatar_url":"https://avatars.githubusercontent.com/u/309772?v=2","gravatar_id":"","url":"https://api.github.com/users/davidchiles","html_url":"https://github.com/davidchiles","followers_url":"https://api.github.com/users/davidchiles/followers","following_url":"https://api.github.com/users/davidchiles/following{/other_user}","gists_url":"https://api.github.com/users/davidchiles/gists{/gist_id}","starred_url":"https://api.github.com/users/davidchiles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidchiles/subscriptions","organizations_url":"https://api.github.com/users/davidchiles/orgs","repos_url":"https://api.github.com/users/davidchiles/repos","events_url":"https://api.github.com/users/davidchiles/events{/privacy}","received_events_url":"https://api.github.com/users/davidchiles/received_events","type":"User","site_admin":false},"body":"Added GCDAsyncSocket as method for connecting to socket instead of custom socket setup. \r\n\r\nMore info on the [TOR control port commands.](https://gitweb.torproject.org/torspec.git?a=blob_plain;hb=HEAD;f=control-spec.txt)\r\n\r\n## Commands\r\n\r\n- `CPAProxyCommand` - Object that contains the actual command string and response block that should be called. When a command is sent to the `CPASocketManager` the string is sent over the control port and then queued waiting for a response from TOR (normally `250 OK`). Once the response is received the command is removed from the queue and sent into the delegate via `- (void)socketManager:(CPASocketManager *)manager didReceiveResponse:(NSString *)response forCommand:(CPAProxyCommand *)command;`. If there is not a queued command or the response is asynchronous the method is called on the delegate but command is nil.\r\n\r\n## Response\r\n\r\n- `CPAProxyResponseParser` - This class is just a way to organize all the specific parsing code to retrieve status codes and such. More methods should be added here as more responses are handled.\r\n- `CPASocketManager` - There is now code to better handle asynchronous responses (status code 650). This includes multi line responses ending in '.' and connecting a given response to the command that initiated it.\r\n","created_at":"2014-10-17T18:21:57Z","updated_at":"2014-10-17T19:43:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"21d95df300a3316978d3f313306467292116deb8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ursachec/CPAProxy/pulls/15/commits","review_comments_url":"https://api.github.com/repos/ursachec/CPAProxy/pulls/15/comments","review_comment_url":"https://api.github.com/repos/ursachec/CPAProxy/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ursachec/CPAProxy/issues/15/comments","statuses_url":"https://api.github.com/repos/ursachec/CPAProxy/statuses/7d1ad8ae8fce9990bf6a316d5e642348a3ca9657","head":{"label":"davidchiles:GCDAsyncSocket","ref":"GCDAsyncSocket","sha":"7d1ad8ae8fce9990bf6a316d5e642348a3ca9657","user":{"login":"davidchiles","id":309772,"avatar_url":"https://avatars.githubusercontent.com/u/309772?v=2","gravatar_id":"","url":"https://api.github.com/users/davidchiles","html_url":"https://github.com/davidchiles","followers_url":"https://api.github.com/users/davidchiles/followers","following_url":"https://api.github.com/users/davidchiles/following{/other_user}","gists_url":"https://api.github.com/users/davidchiles/gists{/gist_id}","starred_url":"https://api.github.com/users/davidchiles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidchiles/subscriptions","organizations_url":"https://api.github.com/users/davidchiles/orgs","repos_url":"https://api.github.com/users/davidchiles/repos","events_url":"https://api.github.com/users/davidchiles/events{/privacy}","received_events_url":"https://api.github.com/users/davidchiles/received_events","type":"User","site_admin":false},"repo":{"id":24738380,"name":"CPAProxy","full_name":"davidchiles/CPAProxy","owner":{"login":"davidchiles","id":309772,"avatar_url":"https://avatars.githubusercontent.com/u/309772?v=2","gravatar_id":"","url":"https://api.github.com/users/davidchiles","html_url":"https://github.com/davidchiles","followers_url":"https://api.github.com/users/davidchiles/followers","following_url":"https://api.github.com/users/davidchiles/following{/other_user}","gists_url":"https://api.github.com/users/davidchiles/gists{/gist_id}","starred_url":"https://api.github.com/users/davidchiles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidchiles/subscriptions","organizations_url":"https://api.github.com/users/davidchiles/orgs","repos_url":"https://api.github.com/users/davidchiles/repos","events_url":"https://api.github.com/users/davidchiles/events{/privacy}","received_events_url":"https://api.github.com/users/davidchiles/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/davidchiles/CPAProxy","description":"CPAProxy is a thin Objective-C wrapper around Tor.","fork":true,"url":"https://api.github.com/repos/davidchiles/CPAProxy","forks_url":"https://api.github.com/repos/davidchiles/CPAProxy/forks","keys_url":"https://api.github.com/repos/davidchiles/CPAProxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/davidchiles/CPAProxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/davidchiles/CPAProxy/teams","hooks_url":"https://api.github.com/repos/davidchiles/CPAProxy/hooks","issue_events_url":"https://api.github.com/repos/davidchiles/CPAProxy/issues/events{/number}","events_url":"https://api.github.com/repos/davidchiles/CPAProxy/events","assignees_url":"https://api.github.com/repos/davidchiles/CPAProxy/assignees{/user}","branches_url":"https://api.github.com/repos/davidchiles/CPAProxy/branches{/branch}","tags_url":"https://api.github.com/repos/davidchiles/CPAProxy/tags","blobs_url":"https://api.github.com/repos/davidchiles/CPAProxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/davidchiles/CPAProxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/davidchiles/CPAProxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/davidchiles/CPAProxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/davidchiles/CPAProxy/statuses/{sha}","languages_url":"https://api.github.com/repos/davidchiles/CPAProxy/languages","stargazers_url":"https://api.github.com/repos/davidchiles/CPAProxy/stargazers","contributors_url":"https://api.github.com/repos/davidchiles/CPAProxy/contributors","subscribers_url":"https://api.github.com/repos/davidchiles/CPAProxy/subscribers","subscription_url":"https://api.github.com/repos/davidchiles/CPAProxy/subscription","commits_url":"https://api.github.com/repos/davidchiles/CPAProxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/davidchiles/CPAProxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/davidchiles/CPAProxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/davidchiles/CPAProxy/issues/comments/{number}","contents_url":"https://api.github.com/repos/davidchiles/CPAProxy/contents/{+path}","compare_url":"https://api.github.com/repos/davidchiles/CPAProxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/davidchiles/CPAProxy/merges","archive_url":"https://api.github.com/repos/davidchiles/CPAProxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/davidchiles/CPAProxy/downloads","issues_url":"https://api.github.com/repos/davidchiles/CPAProxy/issues{/number}","pulls_url":"https://api.github.com/repos/davidchiles/CPAProxy/pulls{/number}","milestones_url":"https://api.github.com/repos/davidchiles/CPAProxy/milestones{/number}","notifications_url":"https://api.github.com/repos/davidchiles/CPAProxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/davidchiles/CPAProxy/labels{/name}","releases_url":"https://api.github.com/repos/davidchiles/CPAProxy/releases{/id}","created_at":"2014-10-02T21:59:19Z","updated_at":"2014-10-03T17:34:24Z","pushed_at":"2014-10-17T18:08:15Z","git_url":"git://github.com/davidchiles/CPAProxy.git","ssh_url":"git@github.com:davidchiles/CPAProxy.git","clone_url":"https://github.com/davidchiles/CPAProxy.git","svn_url":"https://github.com/davidchiles/CPAProxy","homepage":"","size":16743,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ursachec:master","ref":"master","sha":"99f57a38cece02cf1eca544e5bffa3db7af1988b","user":{"login":"ursachec","id":497951,"avatar_url":"https://avatars.githubusercontent.com/u/497951?v=2","gravatar_id":"","url":"https://api.github.com/users/ursachec","html_url":"https://github.com/ursachec","followers_url":"https://api.github.com/users/ursachec/followers","following_url":"https://api.github.com/users/ursachec/following{/other_user}","gists_url":"https://api.github.com/users/ursachec/gists{/gist_id}","starred_url":"https://api.github.com/users/ursachec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ursachec/subscriptions","organizations_url":"https://api.github.com/users/ursachec/orgs","repos_url":"https://api.github.com/users/ursachec/repos","events_url":"https://api.github.com/users/ursachec/events{/privacy}","received_events_url":"https://api.github.com/users/ursachec/received_events","type":"User","site_admin":false},"repo":{"id":13356733,"name":"CPAProxy","full_name":"ursachec/CPAProxy","owner":{"login":"ursachec","id":497951,"avatar_url":"https://avatars.githubusercontent.com/u/497951?v=2","gravatar_id":"","url":"https://api.github.com/users/ursachec","html_url":"https://github.com/ursachec","followers_url":"https://api.github.com/users/ursachec/followers","following_url":"https://api.github.com/users/ursachec/following{/other_user}","gists_url":"https://api.github.com/users/ursachec/gists{/gist_id}","starred_url":"https://api.github.com/users/ursachec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ursachec/subscriptions","organizations_url":"https://api.github.com/users/ursachec/orgs","repos_url":"https://api.github.com/users/ursachec/repos","events_url":"https://api.github.com/users/ursachec/events{/privacy}","received_events_url":"https://api.github.com/users/ursachec/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ursachec/CPAProxy","description":"CPAProxy is a thin Objective-C wrapper around Tor.","fork":false,"url":"https://api.github.com/repos/ursachec/CPAProxy","forks_url":"https://api.github.com/repos/ursachec/CPAProxy/forks","keys_url":"https://api.github.com/repos/ursachec/CPAProxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ursachec/CPAProxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ursachec/CPAProxy/teams","hooks_url":"https://api.github.com/repos/ursachec/CPAProxy/hooks","issue_events_url":"https://api.github.com/repos/ursachec/CPAProxy/issues/events{/number}","events_url":"https://api.github.com/repos/ursachec/CPAProxy/events","assignees_url":"https://api.github.com/repos/ursachec/CPAProxy/assignees{/user}","branches_url":"https://api.github.com/repos/ursachec/CPAProxy/branches{/branch}","tags_url":"https://api.github.com/repos/ursachec/CPAProxy/tags","blobs_url":"https://api.github.com/repos/ursachec/CPAProxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ursachec/CPAProxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ursachec/CPAProxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/ursachec/CPAProxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ursachec/CPAProxy/statuses/{sha}","languages_url":"https://api.github.com/repos/ursachec/CPAProxy/languages","stargazers_url":"https://api.github.com/repos/ursachec/CPAProxy/stargazers","contributors_url":"https://api.github.com/repos/ursachec/CPAProxy/contributors","subscribers_url":"https://api.github.com/repos/ursachec/CPAProxy/subscribers","subscription_url":"https://api.github.com/repos/ursachec/CPAProxy/subscription","commits_url":"https://api.github.com/repos/ursachec/CPAProxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/ursachec/CPAProxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/ursachec/CPAProxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/ursachec/CPAProxy/issues/comments/{number}","contents_url":"https://api.github.com/repos/ursachec/CPAProxy/contents/{+path}","compare_url":"https://api.github.com/repos/ursachec/CPAProxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ursachec/CPAProxy/merges","archive_url":"https://api.github.com/repos/ursachec/CPAProxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ursachec/CPAProxy/downloads","issues_url":"https://api.github.com/repos/ursachec/CPAProxy/issues{/number}","pulls_url":"https://api.github.com/repos/ursachec/CPAProxy/pulls{/number}","milestones_url":"https://api.github.com/repos/ursachec/CPAProxy/milestones{/number}","notifications_url":"https://api.github.com/repos/ursachec/CPAProxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ursachec/CPAProxy/labels{/name}","releases_url":"https://api.github.com/repos/ursachec/CPAProxy/releases{/id}","created_at":"2013-10-06T03:41:48Z","updated_at":"2014-10-10T19:08:23Z","pushed_at":"2014-10-15T03:31:12Z","git_url":"git://github.com/ursachec/CPAProxy.git","ssh_url":"git@github.com:ursachec/CPAProxy.git","clone_url":"https://github.com/ursachec/CPAProxy.git","svn_url":"https://github.com/ursachec/CPAProxy","homepage":"","size":16866,"stargazers_count":28,"watchers_count":28,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":3,"forks":7,"open_issues":3,"watchers":28,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ursachec/CPAProxy/pulls/15"},"html":{"href":"https://github.com/ursachec/CPAProxy/pull/15"},"issue":{"href":"https://api.github.com/repos/ursachec/CPAProxy/issues/15"},"comments":{"href":"https://api.github.com/repos/ursachec/CPAProxy/issues/15/comments"},"review_comments":{"href":"https://api.github.com/repos/ursachec/CPAProxy/pulls/15/comments"},"review_comment":{"href":"https://api.github.com/repos/ursachec/CPAProxy/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ursachec/CPAProxy/pulls/15/commits"},"statuses":{"href":"https://api.github.com/repos/ursachec/CPAProxy/statuses/7d1ad8ae8fce9990bf6a316d5e642348a3ca9657"}}}}