GitHub PullRequestReviewCommentEvent at 2014-09-18 18:34:41
Repository: spark
Actor: andrewor14
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/17745881","id":17745881,"diff_hunk":"@@ -44,30 +50,19 @@ private[spark] class HistoryServerArguments(conf: SparkConf, args: Array[String]\n     }\n   }\n \n+  // Use common defaults file, if not specified by user\n+  propertiesFile = Option(propertiesFile).getOrElse(Utils.getDefaultConfigFile)\n+\n   private def printUsageAndExit(exitCode: Int) {\n     System.err.println(\n       \"\"\"\n-      |Usage: HistoryServer\n-      |\n-      |Configuration options can be set by setting the corresponding JVM system property.\n-      |History Server options are always available; additional options depend on the provider.\n-      |\n-      |History Server options:\n-      |\n-      |  spark.history.ui.port              Port where server will listen for connections\n-      |                                     (default 18080)\n-      |  spark.history.acls.enable          Whether to enable view acls for all applications\n-      |                                     (default false)\n-      |  spark.history.provider             Name of history provider class (defaults to\n-      |                                     file system-based provider)\n-      |  spark.history.retainedApplications Max number of application UIs to keep loaded in memory\n-      |                                     (default 50)\n-      |FsHistoryProvider options:\n-      |\n-      |  spark.history.fs.logDirectory      Directory where app logs are stored (required)\n-      |  spark.history.fs.updateInterval    How often to reload log data from storage (in seconds,\n-      |                                     default 10)\n-      |\"\"\".stripMargin)","path":"core/src/main/scala/org/apache/spark/deploy/history/HistoryServerArguments.scala","position":71,"original_position":65,"commit_id":"c4a77e907052322eeec604d21c729cd1c9c6a1f3","original_commit_id":"217280a18c2e4df4c7531b7387c8ec7bf03efb8b","user":{"login":"andrewor14","id":2133137,"avatar_url":"https://avatars.githubusercontent.com/u/2133137?v=2","gravatar_id":"a05e843641a8e04d55eca499e2d04997","url":"https://api.github.com/users/andrewor14","html_url":"https://github.com/andrewor14","followers_url":"https://api.github.com/users/andrewor14/followers","following_url":"https://api.github.com/users/andrewor14/following{/other_user}","gists_url":"https://api.github.com/users/andrewor14/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewor14/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewor14/subscriptions","organizations_url":"https://api.github.com/users/andrewor14/orgs","repos_url":"https://api.github.com/users/andrewor14/repos","events_url":"https://api.github.com/users/andrewor14/events{/privacy}","received_events_url":"https://api.github.com/users/andrewor14/received_events","type":"User","site_admin":false},"body":"I still think we should add it back. It's more convenient because some of these options are actually necessary (`spark.history.fs.logDirectory`)","created_at":"2014-09-18T18:34:41Z","updated_at":"2014-09-18T18:34:41Z","html_url":"https://github.com/apache/spark/pull/2379#discussion_r17745881","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/2379","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/17745881"},"html":{"href":"https://github.com/apache/spark/pull/2379#discussion_r17745881"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/2379"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/2379","id":21190528,"html_url":"https://github.com/apache/spark/pull/2379","diff_url":"https://github.com/apache/spark/pull/2379.diff","patch_url":"https://github.com/apache/spark/pull/2379.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/2379","number":2379,"state":"open","locked":false,"title":"[SPARK-2098] All Spark processes should support spark-defaults.conf, config file","user":{"login":"witgo","id":302879,"avatar_url":"https://avatars.githubusercontent.com/u/302879?v=2","gravatar_id":"82f14c57ba7522241b0e3c67d759609e","url":"https://api.github.com/users/witgo","html_url":"https://github.com/witgo","followers_url":"https://api.github.com/users/witgo/followers","following_url":"https://api.github.com/users/witgo/following{/other_user}","gists_url":"https://api.github.com/users/witgo/gists{/gist_id}","starred_url":"https://api.github.com/users/witgo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/witgo/subscriptions","organizations_url":"https://api.github.com/users/witgo/orgs","repos_url":"https://api.github.com/users/witgo/repos","events_url":"https://api.github.com/users/witgo/events{/privacy}","received_events_url":"https://api.github.com/users/witgo/received_events","type":"User","site_admin":false},"body":"This is another implementation about #1256\r\ncc @andrewor14 @vanzin","created_at":"2014-09-13T07:37:47Z","updated_at":"2014-09-18T18:34:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"db278c4fa6339269e9ab91cbed700bbaf98c3909","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/2379/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/2379/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments/{number}","comments_url":"https://api.github.com/repos/apache/spark/issues/2379/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/c4a77e907052322eeec604d21c729cd1c9c6a1f3","head":{"label":"witgo:SPARK-2098-new","ref":"SPARK-2098-new","sha":"c4a77e907052322eeec604d21c729cd1c9c6a1f3","user":{"login":"witgo","id":302879,"avatar_url":"https://avatars.githubusercontent.com/u/302879?v=2","gravatar_id":"82f14c57ba7522241b0e3c67d759609e","url":"https://api.github.com/users/witgo","html_url":"https://github.com/witgo","followers_url":"https://api.github.com/users/witgo/followers","following_url":"https://api.github.com/users/witgo/following{/other_user}","gists_url":"https://api.github.com/users/witgo/gists{/gist_id}","starred_url":"https://api.github.com/users/witgo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/witgo/subscriptions","organizations_url":"https://api.github.com/users/witgo/orgs","repos_url":"https://api.github.com/users/witgo/repos","events_url":"https://api.github.com/users/witgo/events{/privacy}","received_events_url":"https://api.github.com/users/witgo/received_events","type":"User","site_admin":false},"repo":{"id":17201985,"name":"spark","full_name":"witgo/spark","owner":{"login":"witgo","id":302879,"avatar_url":"https://avatars.githubusercontent.com/u/302879?v=2","gravatar_id":"82f14c57ba7522241b0e3c67d759609e","url":"https://api.github.com/users/witgo","html_url":"https://github.com/witgo","followers_url":"https://api.github.com/users/witgo/followers","following_url":"https://api.github.com/users/witgo/following{/other_user}","gists_url":"https://api.github.com/users/witgo/gists{/gist_id}","starred_url":"https://api.github.com/users/witgo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/witgo/subscriptions","organizations_url":"https://api.github.com/users/witgo/orgs","repos_url":"https://api.github.com/users/witgo/repos","events_url":"https://api.github.com/users/witgo/events{/privacy}","received_events_url":"https://api.github.com/users/witgo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/witgo/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/witgo/spark","forks_url":"https://api.github.com/repos/witgo/spark/forks","keys_url":"https://api.github.com/repos/witgo/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/witgo/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/witgo/spark/teams","hooks_url":"https://api.github.com/repos/witgo/spark/hooks","issue_events_url":"https://api.github.com/repos/witgo/spark/issues/events{/number}","events_url":"https://api.github.com/repos/witgo/spark/events","assignees_url":"https://api.github.com/repos/witgo/spark/assignees{/user}","branches_url":"https://api.github.com/repos/witgo/spark/branches{/branch}","tags_url":"https://api.github.com/repos/witgo/spark/tags","blobs_url":"https://api.github.com/repos/witgo/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/witgo/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/witgo/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/witgo/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/witgo/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/witgo/spark/languages","stargazers_url":"https://api.github.com/repos/witgo/spark/stargazers","contributors_url":"https://api.github.com/repos/witgo/spark/contributors","subscribers_url":"https://api.github.com/repos/witgo/spark/subscribers","subscription_url":"https://api.github.com/repos/witgo/spark/subscription","commits_url":"https://api.github.com/repos/witgo/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/witgo/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/witgo/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/witgo/spark/issues/comments/{number}","contents_url":"https://api.github.com/repos/witgo/spark/contents/{+path}","compare_url":"https://api.github.com/repos/witgo/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/witgo/spark/merges","archive_url":"https://api.github.com/repos/witgo/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/witgo/spark/downloads","issues_url":"https://api.github.com/repos/witgo/spark/issues{/number}","pulls_url":"https://api.github.com/repos/witgo/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/witgo/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/witgo/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/witgo/spark/labels{/name}","releases_url":"https://api.github.com/repos/witgo/spark/releases{/id}","created_at":"2014-02-26T06:58:08Z","updated_at":"2014-07-09T07:08:17Z","pushed_at":"2014-09-18T17:19:08Z","git_url":"git://github.com/witgo/spark.git","ssh_url":"git@github.com:witgo/spark.git","clone_url":"https://github.com/witgo/spark.git","svn_url":"https://github.com/witgo/spark","homepage":null,"size":83217,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"1147973f1c7713013c7c0ca414482b511a730475","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=2","gravatar_id":"a676c0bf448fcd49f588249ead719b4c","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=2","gravatar_id":"a676c0bf448fcd49f588249ead719b4c","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments/{number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","created_at":"2014-02-25T08:00:08Z","updated_at":"2014-09-18T16:40:36Z","pushed_at":"2014-09-18T17:31:07Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":3167711,"stargazers_count":1505,"watchers_count":1505,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1340,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":235,"forks":1340,"open_issues":235,"watchers":1505,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/2379"},"html":{"href":"https://github.com/apache/spark/pull/2379"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/2379"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/2379/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/2379/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/2379/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/c4a77e907052322eeec604d21c729cd1c9c6a1f3"}}}}