GitHub PullRequestReviewCommentEvent at 2014-12-15 14:45:31
Repository: logstash-integration-testing
Actor: ph
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/elasticsearch/logstash-integration-testing/pulls/comments/21828540","id":21828540,"diff_hunk":"@@ -20,8 +20,8 @@ def execute(debug=false)\n           events  = test[:events].to_i\n           time    = test[:time].to_i\n           manager = runner.new(test[:config], debug, install_path)\n-          p, elapsed, events_count = manager.run(events, time, manager.read_input_file(test[:input]))\n-          lines << \"#{test[:name]}, #{\"%.2f\" % elapsed}, #{events_count}, #{\"%.0f\" % (events_count / elapsed)},#{p.last}, #{\"%.0f\" % (p.reduce(:+) / p.size)}\"\n+          p, elapsed, events_count, start_time = manager.run(events, time, manager.read_input_file(test[:input]))\n+          lines << \"#{test[:name]}, #{start_time} #{\"%.2f\" % elapsed}, #{events_count}, #{\"%.0f\" % (events_count / elapsed)},#{p.last}, #{\"%.0f\" % (p.reduce(:+) / p.size)}\"\n         end","path":"lib/lsit/suite.rb","position":8,"original_position":8,"commit_id":"30f22fabeb9cfebb8a66018619b3e5aa828130a4","original_commit_id":"30f22fabeb9cfebb8a66018619b3e5aa828130a4","user":{"login":"ph","id":640,"avatar_url":"https://avatars.githubusercontent.com/u/640?v=3","gravatar_id":"","url":"https://api.github.com/users/ph","html_url":"https://github.com/ph","followers_url":"https://api.github.com/users/ph/followers","following_url":"https://api.github.com/users/ph/following{/other_user}","gists_url":"https://api.github.com/users/ph/gists{/gist_id}","starred_url":"https://api.github.com/users/ph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ph/subscriptions","organizations_url":"https://api.github.com/users/ph/orgs","repos_url":"https://api.github.com/users/ph/repos","events_url":"https://api.github.com/users/ph/events{/privacy}","received_events_url":"https://api.github.com/users/ph/received_events","type":"User","site_admin":false},"body":"I find the interpolation line a little hard to read and I wonder if using an array like this would make it clearer and easier to change?\r\n```ruby\r\n[\r\n test[:name],\r\n start_time,\r\n \"%.2f\" % elapsed,\r\n events_count,\r\n \"%.0f\" % (events_count / elapsed),\r\n p.last, \r\n \"%.0f\" % (p.reduce(:+) / p.size)\r\n].join(', ')\r\n```","created_at":"2014-12-15T14:45:31Z","updated_at":"2014-12-15T14:45:31Z","html_url":"https://github.com/elasticsearch/logstash-integration-testing/pull/6#discussion_r21828540","pull_request_url":"https://api.github.com/repos/elasticsearch/logstash-integration-testing/pulls/6","_links":{"self":{"href":"https://api.github.com/repos/elasticsearch/logstash-integration-testing/pulls/comments/21828540"},"html":{"href":"https://github.com/elasticsearch/logstash-integration-testing/pull/6#discussion_r21828540"},"pull_request":{"href":"https://api.github.com/repos/elasticsearch/logstash-integration-testing/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/elasticsearch/logstash-integration-testing/pulls/6","id":25980865,"html_url":"https://github.com/elasticsearch/logstash-integration-testing/pull/6","diff_url":"https://github.com/elasticsearch/logstash-integration-testing/pull/6.diff","patch_url":"https://github.com/elasticsearch/logstash-integration-testing/pull/6.patch","issue_url":"https://api.github.com/repos/elasticsearch/logstash-integration-testing/issues/6","number":6,"state":"open","locked":false,"title":"Track startup time","user":{"login":"purbon","id":68540,"avatar_url":"https://avatars.githubusercontent.com/u/68540?v=3","gravatar_id":"","url":"https://api.github.com/users/purbon","html_url":"https://github.com/purbon","followers_url":"https://api.github.com/users/purbon/followers","following_url":"https://api.github.com/users/purbon/following{/other_user}","gists_url":"https://api.github.com/users/purbon/gists{/gist_id}","starred_url":"https://api.github.com/users/purbon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/purbon/subscriptions","organizations_url":"https://api.github.com/users/purbon/orgs","repos_url":"https://api.github.com/users/purbon/repos","events_url":"https://api.github.com/users/purbon/events{/privacy}","received_events_url":"https://api.github.com/users/purbon/received_events","type":"User","site_admin":false},"body":"One important part of Logstash is the time it takes to start. This PR tracks the time between the call to the bin until its able to get the first message.","created_at":"2014-12-12T15:32:00Z","updated_at":"2014-12-15T14:45:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9dc6a0e7505b36bb18e8e77690c66da5844b809e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/elasticsearch/logstash-integration-testing/pulls/6/commits","review_comments_url":"https://api.github.com/repos/elasticsearch/logstash-integration-testing/pulls/6/comments","review_comment_url":"https://api.github.com/repos/elasticsearch/logstash-integration-testing/pulls/comments/{number}","comments_url":"https://api.github.com/repos/elasticsearch/logstash-integration-testing/issues/6/comments","statuses_url":"https://api.github.com/repos/elasticsearch/logstash-integration-testing/statuses/30f22fabeb9cfebb8a66018619b3e5aa828130a4","head":{"label":"purbon:feature/track_startup_time","ref":"feature/track_startup_time","sha":"30f22fabeb9cfebb8a66018619b3e5aa828130a4","user":{"login":"purbon","id":68540,"avatar_url":"https://avatars.githubusercontent.com/u/68540?v=3","gravatar_id":"","url":"https://api.github.com/users/purbon","html_url":"https://github.com/purbon","followers_url":"https://api.github.com/users/purbon/followers","following_url":"https://api.github.com/users/purbon/following{/other_user}","gists_url":"https://api.github.com/users/purbon/gists{/gist_id}","starred_url":"https://api.github.com/users/purbon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/purbon/subscriptions","organizations_url":"https://api.github.com/users/purbon/orgs","repos_url":"https://api.github.com/users/purbon/repos","events_url":"https://api.github.com/users/purbon/events{/privacy}","received_events_url":"https://api.github.com/users/purbon/received_events","type":"User","site_admin":false},"repo":{"id":27488209,"name":"logstash-integration-testing","full_name":"purbon/logstash-integration-testing","owner":{"login":"purbon","id":68540,"avatar_url":"https://avatars.githubusercontent.com/u/68540?v=3","gravatar_id":"","url":"https://api.github.com/users/purbon","html_url":"https://github.com/purbon","followers_url":"https://api.github.com/users/purbon/followers","following_url":"https://api.github.com/users/purbon/following{/other_user}","gists_url":"https://api.github.com/users/purbon/gists{/gist_id}","starred_url":"https://api.github.com/users/purbon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/purbon/subscriptions","organizations_url":"https://api.github.com/users/purbon/orgs","repos_url":"https://api.github.com/users/purbon/repos","events_url":"https://api.github.com/users/purbon/events{/privacy}","received_events_url":"https://api.github.com/users/purbon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/purbon/logstash-integration-testing","description":"Logstash integration and performance testing tools","fork":true,"url":"https://api.github.com/repos/purbon/logstash-integration-testing","forks_url":"https://api.github.com/repos/purbon/logstash-integration-testing/forks","keys_url":"https://api.github.com/repos/purbon/logstash-integration-testing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/purbon/logstash-integration-testing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/purbon/logstash-integration-testing/teams","hooks_url":"https://api.github.com/repos/purbon/logstash-integration-testing/hooks","issue_events_url":"https://api.github.com/repos/purbon/logstash-integration-testing/issues/events{/number}","events_url":"https://api.github.com/repos/purbon/logstash-integration-testing/events","assignees_url":"https://api.github.com/repos/purbon/logstash-integration-testing/assignees{/user}","branches_url":"https://api.github.com/repos/purbon/logstash-integration-testing/branches{/branch}","tags_url":"https://api.github.com/repos/purbon/logstash-integration-testing/tags","blobs_url":"https://api.github.com/repos/purbon/logstash-integration-testing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/purbon/logstash-integration-testing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/purbon/logstash-integration-testing/git/refs{/sha}","trees_url":"https://api.github.com/repos/purbon/logstash-integration-testing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/purbon/logstash-integration-testing/statuses/{sha}","languages_url":"https://api.github.com/repos/purbon/logstash-integration-testing/languages","stargazers_url":"https://api.github.com/repos/purbon/logstash-integration-testing/stargazers","contributors_url":"https://api.github.com/repos/purbon/logstash-integration-testing/contributors","subscribers_url":"https://api.github.com/repos/purbon/logstash-integration-testing/subscribers","subscription_url":"https://api.github.com/repos/purbon/logstash-integration-testing/subscription","commits_url":"https://api.github.com/repos/purbon/logstash-integration-testing/commits{/sha}","git_commits_url":"https://api.github.com/repos/purbon/logstash-integration-testing/git/commits{/sha}","comments_url":"https://api.github.com/repos/purbon/logstash-integration-testing/comments{/number}","issue_comment_url":"https://api.github.com/repos/purbon/logstash-integration-testing/issues/comments/{number}","contents_url":"https://api.github.com/repos/purbon/logstash-integration-testing/contents/{+path}","compare_url":"https://api.github.com/repos/purbon/logstash-integration-testing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/purbon/logstash-integration-testing/merges","archive_url":"https://api.github.com/repos/purbon/logstash-integration-testing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/purbon/logstash-integration-testing/downloads","issues_url":"https://api.github.com/repos/purbon/logstash-integration-testing/issues{/number}","pulls_url":"https://api.github.com/repos/purbon/logstash-integration-testing/pulls{/number}","milestones_url":"https://api.github.com/repos/purbon/logstash-integration-testing/milestones{/number}","notifications_url":"https://api.github.com/repos/purbon/logstash-integration-testing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/purbon/logstash-integration-testing/labels{/name}","releases_url":"https://api.github.com/repos/purbon/logstash-integration-testing/releases{/id}","created_at":"2014-12-03T13:23:19Z","updated_at":"2014-12-08T19:15:59Z","pushed_at":"2014-12-12T15:25:39Z","git_url":"git://github.com/purbon/logstash-integration-testing.git","ssh_url":"git@github.com:purbon/logstash-integration-testing.git","clone_url":"https://github.com/purbon/logstash-integration-testing.git","svn_url":"https://github.com/purbon/logstash-integration-testing","homepage":null,"size":275,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elasticsearch:master","ref":"master","sha":"c1f022f4f0a4d4050064594bbc0e8542025c88f9","user":{"login":"elasticsearch","id":141304,"avatar_url":"https://avatars.githubusercontent.com/u/141304?v=3","gravatar_id":"","url":"https://api.github.com/users/elasticsearch","html_url":"https://github.com/elasticsearch","followers_url":"https://api.github.com/users/elasticsearch/followers","following_url":"https://api.github.com/users/elasticsearch/following{/other_user}","gists_url":"https://api.github.com/users/elasticsearch/gists{/gist_id}","starred_url":"https://api.github.com/users/elasticsearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elasticsearch/subscriptions","organizations_url":"https://api.github.com/users/elasticsearch/orgs","repos_url":"https://api.github.com/users/elasticsearch/repos","events_url":"https://api.github.com/users/elasticsearch/events{/privacy}","received_events_url":"https://api.github.com/users/elasticsearch/received_events","type":"Organization","site_admin":false},"repo":{"id":27456726,"name":"logstash-integration-testing","full_name":"elasticsearch/logstash-integration-testing","owner":{"login":"elasticsearch","id":141304,"avatar_url":"https://avatars.githubusercontent.com/u/141304?v=3","gravatar_id":"","url":"https://api.github.com/users/elasticsearch","html_url":"https://github.com/elasticsearch","followers_url":"https://api.github.com/users/elasticsearch/followers","following_url":"https://api.github.com/users/elasticsearch/following{/other_user}","gists_url":"https://api.github.com/users/elasticsearch/gists{/gist_id}","starred_url":"https://api.github.com/users/elasticsearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elasticsearch/subscriptions","organizations_url":"https://api.github.com/users/elasticsearch/orgs","repos_url":"https://api.github.com/users/elasticsearch/repos","events_url":"https://api.github.com/users/elasticsearch/events{/privacy}","received_events_url":"https://api.github.com/users/elasticsearch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elasticsearch/logstash-integration-testing","description":"Logstash integration and performance testing tools","fork":false,"url":"https://api.github.com/repos/elasticsearch/logstash-integration-testing","forks_url":"https://api.github.com/repos/elasticsearch/logstash-integration-testing/forks","keys_url":"https://api.github.com/repos/elasticsearch/logstash-integration-testing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elasticsearch/logstash-integration-testing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elasticsearch/logstash-integration-testing/teams","hooks_url":"https://api.github.com/repos/elasticsearch/logstash-integration-testing/hooks","issue_events_url":"https://api.github.com/repos/elasticsearch/logstash-integration-testing/issues/events{/number}","events_url":"https://api.github.com/repos/elasticsearch/logstash-integration-testing/events","assignees_url":"https://api.github.com/repos/elasticsearch/logstash-integration-testing/assignees{/user}","branches_url":"https://api.github.com/repos/elasticsearch/logstash-integration-testing/branches{/branch}","tags_url":"https://api.github.com/repos/elasticsearch/logstash-integration-testing/tags","blobs_url":"https://api.github.com/repos/elasticsearch/logstash-integration-testing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elasticsearch/logstash-integration-testing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elasticsearch/logstash-integration-testing/git/refs{/sha}","trees_url":"https://api.github.com/repos/elasticsearch/logstash-integration-testing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elasticsearch/logstash-integration-testing/statuses/{sha}","languages_url":"https://api.github.com/repos/elasticsearch/logstash-integration-testing/languages","stargazers_url":"https://api.github.com/repos/elasticsearch/logstash-integration-testing/stargazers","contributors_url":"https://api.github.com/repos/elasticsearch/logstash-integration-testing/contributors","subscribers_url":"https://api.github.com/repos/elasticsearch/logstash-integration-testing/subscribers","subscription_url":"https://api.github.com/repos/elasticsearch/logstash-integration-testing/subscription","commits_url":"https://api.github.com/repos/elasticsearch/logstash-integration-testing/commits{/sha}","git_commits_url":"https://api.github.com/repos/elasticsearch/logstash-integration-testing/git/commits{/sha}","comments_url":"https://api.github.com/repos/elasticsearch/logstash-integration-testing/comments{/number}","issue_comment_url":"https://api.github.com/repos/elasticsearch/logstash-integration-testing/issues/comments/{number}","contents_url":"https://api.github.com/repos/elasticsearch/logstash-integration-testing/contents/{+path}","compare_url":"https://api.github.com/repos/elasticsearch/logstash-integration-testing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elasticsearch/logstash-integration-testing/merges","archive_url":"https://api.github.com/repos/elasticsearch/logstash-integration-testing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elasticsearch/logstash-integration-testing/downloads","issues_url":"https://api.github.com/repos/elasticsearch/logstash-integration-testing/issues{/number}","pulls_url":"https://api.github.com/repos/elasticsearch/logstash-integration-testing/pulls{/number}","milestones_url":"https://api.github.com/repos/elasticsearch/logstash-integration-testing/milestones{/number}","notifications_url":"https://api.github.com/repos/elasticsearch/logstash-integration-testing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elasticsearch/logstash-integration-testing/labels{/name}","releases_url":"https://api.github.com/repos/elasticsearch/logstash-integration-testing/releases{/id}","created_at":"2014-12-02T22:27:08Z","updated_at":"2014-12-13T16:24:41Z","pushed_at":"2014-12-08T17:08:13Z","git_url":"git://github.com/elasticsearch/logstash-integration-testing.git","ssh_url":"git@github.com:elasticsearch/logstash-integration-testing.git","clone_url":"https://github.com/elasticsearch/logstash-integration-testing.git","svn_url":"https://github.com/elasticsearch/logstash-integration-testing","homepage":null,"size":247,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":4,"forks":2,"open_issues":4,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elasticsearch/logstash-integration-testing/pulls/6"},"html":{"href":"https://github.com/elasticsearch/logstash-integration-testing/pull/6"},"issue":{"href":"https://api.github.com/repos/elasticsearch/logstash-integration-testing/issues/6"},"comments":{"href":"https://api.github.com/repos/elasticsearch/logstash-integration-testing/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/elasticsearch/logstash-integration-testing/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/elasticsearch/logstash-integration-testing/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/elasticsearch/logstash-integration-testing/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/elasticsearch/logstash-integration-testing/statuses/30f22fabeb9cfebb8a66018619b3e5aa828130a4"}}}}