GitHub PullRequestReviewCommentEvent at 2014-09-11 03:48:34
Repository: gaia
Actor: alivedise
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/17403029","id":17403029,"diff_hunk":"@@ -130,8 +130,10 @@\n           // in another app, not the LockScreen.\n           if ('proximity' !== evt.detail.screenOffBy &&\n               !this.states.FTUOccurs) {\n-            // The app would be inactive while screen off.\n-            this.openApp();\n+            // Because locking/unlocking should not only handle by\n+            // this manager. Others may need to know the state change\n+            // to do the work.\n+            this.publish('lockscreen-request-lock');","path":"apps/system/js/lockscreen_window_manager.js","position":9,"original_position":9,"commit_id":"f57f21c74c71fcce423067bbf544d8c8050f0fbc","original_commit_id":"f57f21c74c71fcce423067bbf544d8c8050f0fbc","user":{"login":"alivedise","id":546519,"avatar_url":"https://avatars.githubusercontent.com/u/546519?v=2","gravatar_id":"2200ce74246a04126cf04cfa39ff0c37","url":"https://api.github.com/users/alivedise","html_url":"https://github.com/alivedise","followers_url":"https://api.github.com/users/alivedise/followers","following_url":"https://api.github.com/users/alivedise/following{/other_user}","gists_url":"https://api.github.com/users/alivedise/gists{/gist_id}","starred_url":"https://api.github.com/users/alivedise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alivedise/subscriptions","organizations_url":"https://api.github.com/users/alivedise/orgs","repos_url":"https://api.github.com/users/alivedise/repos","events_url":"https://api.github.com/users/alivedise/events{/privacy}","received_events_url":"https://api.github.com/users/alivedise/received_events","type":"User","site_admin":false},"body":"I don't think we need this if lockscreenStateManager is moved into lockscreen iframe?","created_at":"2014-09-11T03:48:34Z","updated_at":"2014-09-11T03:48:34Z","html_url":"https://github.com/mozilla-b2g/gaia/pull/23930#discussion_r17403029","pull_request_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/23930","_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/17403029"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/23930#discussion_r17403029"},"pull_request":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/23930"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/23930","id":21063347,"html_url":"https://github.com/mozilla-b2g/gaia/pull/23930","diff_url":"https://github.com/mozilla-b2g/gaia/pull/23930.diff","patch_url":"https://github.com/mozilla-b2g/gaia/pull/23930.patch","issue_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/23930","number":23930,"state":"open","locked":false,"title":"Bug 1064630 - [Lockscreen] Locking device after entering a passcode leav...","user":{"login":"snowmantw","id":129153,"avatar_url":"https://avatars.githubusercontent.com/u/129153?v=2","gravatar_id":"a45359e3fe86aeca5b166ed821964b0b","url":"https://api.github.com/users/snowmantw","html_url":"https://github.com/snowmantw","followers_url":"https://api.github.com/users/snowmantw/followers","following_url":"https://api.github.com/users/snowmantw/following{/other_user}","gists_url":"https://api.github.com/users/snowmantw/gists{/gist_id}","starred_url":"https://api.github.com/users/snowmantw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snowmantw/subscriptions","organizations_url":"https://api.github.com/users/snowmantw/orgs","repos_url":"https://api.github.com/users/snowmantw/repos","events_url":"https://api.github.com/users/snowmantw/events{/privacy}","received_events_url":"https://api.github.com/users/snowmantw/received_events","type":"User","site_admin":false},"body":"...es the user in an unrecoverable state","created_at":"2014-09-11T02:32:27Z","updated_at":"2014-09-11T03:48:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8c6a70243b30b7c7af2cd207daf588bb9ff81778","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/23930/commits","review_comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/23930/comments","review_comment_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/23930/comments","statuses_url":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/f57f21c74c71fcce423067bbf544d8c8050f0fbc","head":{"label":"snowmantw:issue1064630","ref":"issue1064630","sha":"f57f21c74c71fcce423067bbf544d8c8050f0fbc","user":{"login":"snowmantw","id":129153,"avatar_url":"https://avatars.githubusercontent.com/u/129153?v=2","gravatar_id":"a45359e3fe86aeca5b166ed821964b0b","url":"https://api.github.com/users/snowmantw","html_url":"https://github.com/snowmantw","followers_url":"https://api.github.com/users/snowmantw/followers","following_url":"https://api.github.com/users/snowmantw/following{/other_user}","gists_url":"https://api.github.com/users/snowmantw/gists{/gist_id}","starred_url":"https://api.github.com/users/snowmantw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snowmantw/subscriptions","organizations_url":"https://api.github.com/users/snowmantw/orgs","repos_url":"https://api.github.com/users/snowmantw/repos","events_url":"https://api.github.com/users/snowmantw/events{/privacy}","received_events_url":"https://api.github.com/users/snowmantw/received_events","type":"User","site_admin":false},"repo":{"id":11719524,"name":"gaia","full_name":"snowmantw/gaia","owner":{"login":"snowmantw","id":129153,"avatar_url":"https://avatars.githubusercontent.com/u/129153?v=2","gravatar_id":"a45359e3fe86aeca5b166ed821964b0b","url":"https://api.github.com/users/snowmantw","html_url":"https://github.com/snowmantw","followers_url":"https://api.github.com/users/snowmantw/followers","following_url":"https://api.github.com/users/snowmantw/following{/other_user}","gists_url":"https://api.github.com/users/snowmantw/gists{/gist_id}","starred_url":"https://api.github.com/users/snowmantw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snowmantw/subscriptions","organizations_url":"https://api.github.com/users/snowmantw/orgs","repos_url":"https://api.github.com/users/snowmantw/repos","events_url":"https://api.github.com/users/snowmantw/events{/privacy}","received_events_url":"https://api.github.com/users/snowmantw/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/snowmantw/gaia","description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see https://wiki.mozilla.org/Release_Management/B2G_Landing","fork":true,"url":"https://api.github.com/repos/snowmantw/gaia","forks_url":"https://api.github.com/repos/snowmantw/gaia/forks","keys_url":"https://api.github.com/repos/snowmantw/gaia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/snowmantw/gaia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/snowmantw/gaia/teams","hooks_url":"https://api.github.com/repos/snowmantw/gaia/hooks","issue_events_url":"https://api.github.com/repos/snowmantw/gaia/issues/events{/number}","events_url":"https://api.github.com/repos/snowmantw/gaia/events","assignees_url":"https://api.github.com/repos/snowmantw/gaia/assignees{/user}","branches_url":"https://api.github.com/repos/snowmantw/gaia/branches{/branch}","tags_url":"https://api.github.com/repos/snowmantw/gaia/tags","blobs_url":"https://api.github.com/repos/snowmantw/gaia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/snowmantw/gaia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/snowmantw/gaia/git/refs{/sha}","trees_url":"https://api.github.com/repos/snowmantw/gaia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/snowmantw/gaia/statuses/{sha}","languages_url":"https://api.github.com/repos/snowmantw/gaia/languages","stargazers_url":"https://api.github.com/repos/snowmantw/gaia/stargazers","contributors_url":"https://api.github.com/repos/snowmantw/gaia/contributors","subscribers_url":"https://api.github.com/repos/snowmantw/gaia/subscribers","subscription_url":"https://api.github.com/repos/snowmantw/gaia/subscription","commits_url":"https://api.github.com/repos/snowmantw/gaia/commits{/sha}","git_commits_url":"https://api.github.com/repos/snowmantw/gaia/git/commits{/sha}","comments_url":"https://api.github.com/repos/snowmantw/gaia/comments{/number}","issue_comment_url":"https://api.github.com/repos/snowmantw/gaia/issues/comments/{number}","contents_url":"https://api.github.com/repos/snowmantw/gaia/contents/{+path}","compare_url":"https://api.github.com/repos/snowmantw/gaia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/snowmantw/gaia/merges","archive_url":"https://api.github.com/repos/snowmantw/gaia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/snowmantw/gaia/downloads","issues_url":"https://api.github.com/repos/snowmantw/gaia/issues{/number}","pulls_url":"https://api.github.com/repos/snowmantw/gaia/pulls{/number}","milestones_url":"https://api.github.com/repos/snowmantw/gaia/milestones{/number}","notifications_url":"https://api.github.com/repos/snowmantw/gaia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/snowmantw/gaia/labels{/name}","releases_url":"https://api.github.com/repos/snowmantw/gaia/releases{/id}","created_at":"2013-07-28T12:37:37Z","updated_at":"2014-07-03T00:59:35Z","pushed_at":"2014-09-11T02:31:02Z","git_url":"git://github.com/snowmantw/gaia.git","ssh_url":"git@github.com:snowmantw/gaia.git","clone_url":"https://github.com/snowmantw/gaia.git","svn_url":"https://github.com/snowmantw/gaia","homepage":"https://wiki.mozilla.org/B2G","size":837625,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla-b2g:master","ref":"master","sha":"69783c4be7604601cca9329b4f75a2ac9ba6338e","user":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=2","gravatar_id":"b1de11f7d6ddaf7b9d527281297c2ee1","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"repo":{"id":2317369,"name":"gaia","full_name":"mozilla-b2g/gaia","owner":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=2","gravatar_id":"b1de11f7d6ddaf7b9d527281297c2ee1","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-b2g/gaia","description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see","fork":false,"url":"https://api.github.com/repos/mozilla-b2g/gaia","forks_url":"https://api.github.com/repos/mozilla-b2g/gaia/forks","keys_url":"https://api.github.com/repos/mozilla-b2g/gaia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-b2g/gaia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-b2g/gaia/teams","hooks_url":"https://api.github.com/repos/mozilla-b2g/gaia/hooks","issue_events_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-b2g/gaia/events","assignees_url":"https://api.github.com/repos/mozilla-b2g/gaia/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-b2g/gaia/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-b2g/gaia/tags","blobs_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-b2g/gaia/languages","stargazers_url":"https://api.github.com/repos/mozilla-b2g/gaia/stargazers","contributors_url":"https://api.github.com/repos/mozilla-b2g/gaia/contributors","subscribers_url":"https://api.github.com/repos/mozilla-b2g/gaia/subscribers","subscription_url":"https://api.github.com/repos/mozilla-b2g/gaia/subscription","commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/comments/{number}","contents_url":"https://api.github.com/repos/mozilla-b2g/gaia/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-b2g/gaia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-b2g/gaia/merges","archive_url":"https://api.github.com/repos/mozilla-b2g/gaia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-b2g/gaia/downloads","issues_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-b2g/gaia/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-b2g/gaia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-b2g/gaia/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-b2g/gaia/releases{/id}","created_at":"2011-09-03T01:38:46Z","updated_at":"2014-09-10T13:49:17Z","pushed_at":"2014-09-11T03:24:06Z","git_url":"git://github.com/mozilla-b2g/gaia.git","ssh_url":"git@github.com:mozilla-b2g/gaia.git","clone_url":"https://github.com/mozilla-b2g/gaia.git","svn_url":"https://github.com/mozilla-b2g/gaia","homepage":"https://wiki.mozilla.org/B2G","size":1428701,"stargazers_count":1735,"watchers_count":1735,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":1899,"mirror_url":null,"open_issues_count":2008,"forks":1899,"open_issues":2008,"watchers":1735,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/23930"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/23930"},"issue":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/issues/23930"},"comments":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/issues/23930/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/23930/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/23930/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/f57f21c74c71fcce423067bbf544d8c8050f0fbc"}}}}