GitHub PullRequestReviewCommentEvent at 2014-08-04 16:01:38
Repository: rust
Actor: eddyb
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/comments/15763267","id":15763267,"diff_hunk":"@@ -8,9 +8,9 @@\n // option. This file may not be copied, modified, or distributed\n // except according to those terms.\n \n-use syntax::fold::Folder;\n-use syntax::{ast, fold, attr};\n-use syntax::codemap;\n+use fold::Folder;\n+use {ast, fold, attr};\n+use codemap;","path":"src/libsyntax/config.rs","position":9,"original_position":9,"commit_id":"7d8ca04e4877cdca2485b3bce91dfac4fbaff9a5","original_commit_id":"7d8ca04e4877cdca2485b3bce91dfac4fbaff9a5","user":{"login":"eddyb","id":77424,"avatar_url":"https://avatars.githubusercontent.com/u/77424?v=2","gravatar_id":"9ecb50b1ff19c8104ea1b2ce02aa8534","url":"https://api.github.com/users/eddyb","html_url":"https://github.com/eddyb","followers_url":"https://api.github.com/users/eddyb/followers","following_url":"https://api.github.com/users/eddyb/following{/other_user}","gists_url":"https://api.github.com/users/eddyb/gists{/gist_id}","starred_url":"https://api.github.com/users/eddyb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eddyb/subscriptions","organizations_url":"https://api.github.com/users/eddyb/orgs","repos_url":"https://api.github.com/users/eddyb/repos","events_url":"https://api.github.com/users/eddyb/events{/privacy}","received_events_url":"https://api.github.com/users/eddyb/received_events","type":"User","site_admin":false},"body":"I believe this can be integrated into parsing and expansion, which would allow us to `#[cfg]`-gate code that wouldn't parse with a given version of rustc.","created_at":"2014-08-04T16:01:38Z","updated_at":"2014-08-04T16:01:38Z","html_url":"https://github.com/rust-lang/rust/pull/16240#discussion_r15763267","pull_request_url":"https://api.github.com/repos/rust-lang/rust/pulls/16240","_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments/15763267"},"html":{"href":"https://github.com/rust-lang/rust/pull/16240#discussion_r15763267"},"pull_request":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/16240"}}},"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/16240","id":19276155,"html_url":"https://github.com/rust-lang/rust/pull/16240","diff_url":"https://github.com/rust-lang/rust/pull/16240.diff","patch_url":"https://github.com/rust-lang/rust/pull/16240.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/16240","number":16240,"state":"open","title":"move most of front to libsyntax","user":{"login":"nick29581","id":762626,"avatar_url":"https://avatars.githubusercontent.com/u/762626?v=2","gravatar_id":"fbd53a3405ed31e6e3a1fe235ca797be","url":"https://api.github.com/users/nick29581","html_url":"https://github.com/nick29581","followers_url":"https://api.github.com/users/nick29581/followers","following_url":"https://api.github.com/users/nick29581/following{/other_user}","gists_url":"https://api.github.com/users/nick29581/gists{/gist_id}","starred_url":"https://api.github.com/users/nick29581/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nick29581/subscriptions","organizations_url":"https://api.github.com/users/nick29581/orgs","repos_url":"https://api.github.com/users/nick29581/repos","events_url":"https://api.github.com/users/nick29581/events{/privacy}","received_events_url":"https://api.github.com/users/nick29581/received_events","type":"User","site_admin":false},"body":"I tried to move all of front to libsyntax but feature_gate.rs and std_inject.rs have small but annoying dependencies on other rustc stuff. So I'm not really sure if moving just this stuff is worthwhile, but it does seem a bit of a better fit in libsyntax.\r\n\r\nr?","created_at":"2014-08-04T11:04:31Z","updated_at":"2014-08-04T16:01:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"da6e69a9c63c117dff8f30c6d873e9759f235708","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/16240/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/16240/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments/{number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/16240/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/7d8ca04e4877cdca2485b3bce91dfac4fbaff9a5","head":{"label":"nick29581:front","ref":"front","sha":"7d8ca04e4877cdca2485b3bce91dfac4fbaff9a5","user":{"login":"nick29581","id":762626,"avatar_url":"https://avatars.githubusercontent.com/u/762626?v=2","gravatar_id":"fbd53a3405ed31e6e3a1fe235ca797be","url":"https://api.github.com/users/nick29581","html_url":"https://github.com/nick29581","followers_url":"https://api.github.com/users/nick29581/followers","following_url":"https://api.github.com/users/nick29581/following{/other_user}","gists_url":"https://api.github.com/users/nick29581/gists{/gist_id}","starred_url":"https://api.github.com/users/nick29581/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nick29581/subscriptions","organizations_url":"https://api.github.com/users/nick29581/orgs","repos_url":"https://api.github.com/users/nick29581/repos","events_url":"https://api.github.com/users/nick29581/events{/privacy}","received_events_url":"https://api.github.com/users/nick29581/received_events","type":"User","site_admin":false},"repo":{"id":11998169,"name":"rust","full_name":"nick29581/rust","owner":{"login":"nick29581","id":762626,"avatar_url":"https://avatars.githubusercontent.com/u/762626?v=2","gravatar_id":"fbd53a3405ed31e6e3a1fe235ca797be","url":"https://api.github.com/users/nick29581","html_url":"https://github.com/nick29581","followers_url":"https://api.github.com/users/nick29581/followers","following_url":"https://api.github.com/users/nick29581/following{/other_user}","gists_url":"https://api.github.com/users/nick29581/gists{/gist_id}","starred_url":"https://api.github.com/users/nick29581/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nick29581/subscriptions","organizations_url":"https://api.github.com/users/nick29581/orgs","repos_url":"https://api.github.com/users/nick29581/repos","events_url":"https://api.github.com/users/nick29581/events{/privacy}","received_events_url":"https://api.github.com/users/nick29581/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nick29581/rust","description":"a safe, concurrent, practical language","fork":true,"url":"https://api.github.com/repos/nick29581/rust","forks_url":"https://api.github.com/repos/nick29581/rust/forks","keys_url":"https://api.github.com/repos/nick29581/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nick29581/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nick29581/rust/teams","hooks_url":"https://api.github.com/repos/nick29581/rust/hooks","issue_events_url":"https://api.github.com/repos/nick29581/rust/issues/events{/number}","events_url":"https://api.github.com/repos/nick29581/rust/events","assignees_url":"https://api.github.com/repos/nick29581/rust/assignees{/user}","branches_url":"https://api.github.com/repos/nick29581/rust/branches{/branch}","tags_url":"https://api.github.com/repos/nick29581/rust/tags","blobs_url":"https://api.github.com/repos/nick29581/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nick29581/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nick29581/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/nick29581/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nick29581/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/nick29581/rust/languages","stargazers_url":"https://api.github.com/repos/nick29581/rust/stargazers","contributors_url":"https://api.github.com/repos/nick29581/rust/contributors","subscribers_url":"https://api.github.com/repos/nick29581/rust/subscribers","subscription_url":"https://api.github.com/repos/nick29581/rust/subscription","commits_url":"https://api.github.com/repos/nick29581/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/nick29581/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/nick29581/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/nick29581/rust/issues/comments/{number}","contents_url":"https://api.github.com/repos/nick29581/rust/contents/{+path}","compare_url":"https://api.github.com/repos/nick29581/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nick29581/rust/merges","archive_url":"https://api.github.com/repos/nick29581/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nick29581/rust/downloads","issues_url":"https://api.github.com/repos/nick29581/rust/issues{/number}","pulls_url":"https://api.github.com/repos/nick29581/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/nick29581/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/nick29581/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nick29581/rust/labels{/name}","releases_url":"https://api.github.com/repos/nick29581/rust/releases{/id}","created_at":"2013-08-09T10:00:46Z","updated_at":"2014-07-13T23:04:58Z","pushed_at":"2014-08-04T11:02:41Z","git_url":"git://github.com/nick29581/rust.git","ssh_url":"git@github.com:nick29581/rust.git","clone_url":"https://github.com/nick29581/rust.git","svn_url":"https://github.com/nick29581/rust","homepage":"http://www.rust-lang.org","size":205593,"stargazers_count":1,"watchers_count":1,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"795f6ae829ab1bfd72394a5da9096e2717ec0f62","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=2","gravatar_id":"a4268b59e433144466a0f67cbcfd8cdc","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"name":"rust","full_name":"rust-lang/rust","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=2","gravatar_id":"a4268b59e433144466a0f67cbcfd8cdc","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust","description":"a safe, concurrent, practical language","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments/{number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","created_at":"2010-06-16T20:39:03Z","updated_at":"2014-08-04T10:06:15Z","pushed_at":"2014-08-04T14:41:20Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"http://www.rust-lang.org","size":421490,"stargazers_count":5960,"watchers_count":5960,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":1204,"mirror_url":null,"open_issues_count":1788,"forks":1204,"open_issues":1788,"watchers":5960,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/16240"},"html":{"href":"https://github.com/rust-lang/rust/pull/16240"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/16240"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/16240/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/16240/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/16240/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/7d8ca04e4877cdca2485b3bce91dfac4fbaff9a5"}}}}