GitHub PullRequestReviewCommentEvent at 2014-10-30 08:33:03
Repository: homebrew
Actor: mikemcquaid
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/Homebrew/homebrew/pulls/comments/19592100","id":19592100,"diff_hunk":"@@ -0,0 +1,54 @@\n+require \"formula\"\n+\n+# Note: pull from git tag to get submodules\n+class Osquery < Formula\n+  homepage \"http://osquery.io\"\n+  url \"https://github.com/facebook/osquery.git\", :tag => \"1.0.3\"\n+  sha1 \"529d9a9abc0eb282fd0e61884e2c9f0ee24eddd0\"\n+\n+  depends_on \"cmake\" => :build\n+\n+  depends_on \"boost\"\n+  depends_on \"cmake\"","path":"Library/Formula/osquery.rb","position":12,"original_position":12,"commit_id":"7a01a60747f0f0c12753092101bf0cb9547118bf","original_commit_id":"7a01a60747f0f0c12753092101bf0cb9547118bf","user":{"login":"mikemcquaid","id":125011,"avatar_url":"https://avatars.githubusercontent.com/u/125011?v=2","gravatar_id":"","url":"https://api.github.com/users/mikemcquaid","html_url":"https://github.com/mikemcquaid","followers_url":"https://api.github.com/users/mikemcquaid/followers","following_url":"https://api.github.com/users/mikemcquaid/following{/other_user}","gists_url":"https://api.github.com/users/mikemcquaid/gists{/gist_id}","starred_url":"https://api.github.com/users/mikemcquaid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikemcquaid/subscriptions","organizations_url":"https://api.github.com/users/mikemcquaid/orgs","repos_url":"https://api.github.com/users/mikemcquaid/repos","events_url":"https://api.github.com/users/mikemcquaid/events{/privacy}","received_events_url":"https://api.github.com/users/mikemcquaid/received_events","type":"User","site_admin":true},"body":"Are you sure this is needed at runtime?","created_at":"2014-10-30T08:33:03Z","updated_at":"2014-10-30T08:33:03Z","html_url":"https://github.com/Homebrew/homebrew/pull/33718#discussion_r19592100","pull_request_url":"https://api.github.com/repos/Homebrew/homebrew/pulls/33718","_links":{"self":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/comments/19592100"},"html":{"href":"https://github.com/Homebrew/homebrew/pull/33718#discussion_r19592100"},"pull_request":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/33718"}}},"pull_request":{"url":"https://api.github.com/repos/Homebrew/homebrew/pulls/33718","id":23559253,"html_url":"https://github.com/Homebrew/homebrew/pull/33718","diff_url":"https://github.com/Homebrew/homebrew/pull/33718.diff","patch_url":"https://github.com/Homebrew/homebrew/pull/33718.patch","issue_url":"https://api.github.com/repos/Homebrew/homebrew/issues/33718","number":33718,"state":"open","locked":false,"title":"Added osquery 1.0.3","user":{"login":"jjeising","id":40333,"avatar_url":"https://avatars.githubusercontent.com/u/40333?v=2","gravatar_id":"","url":"https://api.github.com/users/jjeising","html_url":"https://github.com/jjeising","followers_url":"https://api.github.com/users/jjeising/followers","following_url":"https://api.github.com/users/jjeising/following{/other_user}","gists_url":"https://api.github.com/users/jjeising/gists{/gist_id}","starred_url":"https://api.github.com/users/jjeising/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjeising/subscriptions","organizations_url":"https://api.github.com/users/jjeising/orgs","repos_url":"https://api.github.com/users/jjeising/repos","events_url":"https://api.github.com/users/jjeising/events{/privacy}","received_events_url":"https://api.github.com/users/jjeising/received_events","type":"User","site_admin":false},"body":"This adds the new [osquery](http://osquery.io/).\r\n\r\nThe package ignores `make deps` (`tools/provision.sh`) because it justs pulls some homebrew dependencies and later calls `sudo pip install…`.\r\n\r\nBuild currently fails if Jinja2 for Python is not installed (`pip install Jinja2`).\r\nWhat's the recommend way to provide the package during installation?","created_at":"2014-10-29T19:50:13Z","updated_at":"2014-10-30T08:33:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"88a01f5500c9acf71054fa2a7e2149fa25a59bc0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Homebrew/homebrew/pulls/33718/commits","review_comments_url":"https://api.github.com/repos/Homebrew/homebrew/pulls/33718/comments","review_comment_url":"https://api.github.com/repos/Homebrew/homebrew/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Homebrew/homebrew/issues/33718/comments","statuses_url":"https://api.github.com/repos/Homebrew/homebrew/statuses/7a01a60747f0f0c12753092101bf0cb9547118bf","head":{"label":"jjeising:fb-osquery","ref":"fb-osquery","sha":"7a01a60747f0f0c12753092101bf0cb9547118bf","user":{"login":"jjeising","id":40333,"avatar_url":"https://avatars.githubusercontent.com/u/40333?v=2","gravatar_id":"","url":"https://api.github.com/users/jjeising","html_url":"https://github.com/jjeising","followers_url":"https://api.github.com/users/jjeising/followers","following_url":"https://api.github.com/users/jjeising/following{/other_user}","gists_url":"https://api.github.com/users/jjeising/gists{/gist_id}","starred_url":"https://api.github.com/users/jjeising/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjeising/subscriptions","organizations_url":"https://api.github.com/users/jjeising/orgs","repos_url":"https://api.github.com/users/jjeising/repos","events_url":"https://api.github.com/users/jjeising/events{/privacy}","received_events_url":"https://api.github.com/users/jjeising/received_events","type":"User","site_admin":false},"repo":{"id":5127545,"name":"homebrew","full_name":"jjeising/homebrew","owner":{"login":"jjeising","id":40333,"avatar_url":"https://avatars.githubusercontent.com/u/40333?v=2","gravatar_id":"","url":"https://api.github.com/users/jjeising","html_url":"https://github.com/jjeising","followers_url":"https://api.github.com/users/jjeising/followers","following_url":"https://api.github.com/users/jjeising/following{/other_user}","gists_url":"https://api.github.com/users/jjeising/gists{/gist_id}","starred_url":"https://api.github.com/users/jjeising/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjeising/subscriptions","organizations_url":"https://api.github.com/users/jjeising/orgs","repos_url":"https://api.github.com/users/jjeising/repos","events_url":"https://api.github.com/users/jjeising/events{/privacy}","received_events_url":"https://api.github.com/users/jjeising/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jjeising/homebrew","description":"The missing package manager for OS X.","fork":true,"url":"https://api.github.com/repos/jjeising/homebrew","forks_url":"https://api.github.com/repos/jjeising/homebrew/forks","keys_url":"https://api.github.com/repos/jjeising/homebrew/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jjeising/homebrew/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jjeising/homebrew/teams","hooks_url":"https://api.github.com/repos/jjeising/homebrew/hooks","issue_events_url":"https://api.github.com/repos/jjeising/homebrew/issues/events{/number}","events_url":"https://api.github.com/repos/jjeising/homebrew/events","assignees_url":"https://api.github.com/repos/jjeising/homebrew/assignees{/user}","branches_url":"https://api.github.com/repos/jjeising/homebrew/branches{/branch}","tags_url":"https://api.github.com/repos/jjeising/homebrew/tags","blobs_url":"https://api.github.com/repos/jjeising/homebrew/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jjeising/homebrew/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jjeising/homebrew/git/refs{/sha}","trees_url":"https://api.github.com/repos/jjeising/homebrew/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jjeising/homebrew/statuses/{sha}","languages_url":"https://api.github.com/repos/jjeising/homebrew/languages","stargazers_url":"https://api.github.com/repos/jjeising/homebrew/stargazers","contributors_url":"https://api.github.com/repos/jjeising/homebrew/contributors","subscribers_url":"https://api.github.com/repos/jjeising/homebrew/subscribers","subscription_url":"https://api.github.com/repos/jjeising/homebrew/subscription","commits_url":"https://api.github.com/repos/jjeising/homebrew/commits{/sha}","git_commits_url":"https://api.github.com/repos/jjeising/homebrew/git/commits{/sha}","comments_url":"https://api.github.com/repos/jjeising/homebrew/comments{/number}","issue_comment_url":"https://api.github.com/repos/jjeising/homebrew/issues/comments/{number}","contents_url":"https://api.github.com/repos/jjeising/homebrew/contents/{+path}","compare_url":"https://api.github.com/repos/jjeising/homebrew/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jjeising/homebrew/merges","archive_url":"https://api.github.com/repos/jjeising/homebrew/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jjeising/homebrew/downloads","issues_url":"https://api.github.com/repos/jjeising/homebrew/issues{/number}","pulls_url":"https://api.github.com/repos/jjeising/homebrew/pulls{/number}","milestones_url":"https://api.github.com/repos/jjeising/homebrew/milestones{/number}","notifications_url":"https://api.github.com/repos/jjeising/homebrew/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jjeising/homebrew/labels{/name}","releases_url":"https://api.github.com/repos/jjeising/homebrew/releases{/id}","created_at":"2012-07-20T19:42:25Z","updated_at":"2014-06-25T11:52:01Z","pushed_at":"2014-10-29T23:23:18Z","git_url":"git://github.com/jjeising/homebrew.git","ssh_url":"git@github.com:jjeising/homebrew.git","clone_url":"https://github.com/jjeising/homebrew.git","svn_url":"https://github.com/jjeising/homebrew","homepage":"http://mxcl.github.com/homebrew","size":47497,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Homebrew:master","ref":"master","sha":"e79ba250f160bd53eba8c65fd737b21f216620b1","user":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars.githubusercontent.com/u/1503512?v=2","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"repo":{"id":206084,"name":"homebrew","full_name":"Homebrew/homebrew","owner":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars.githubusercontent.com/u/1503512?v=2","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Homebrew/homebrew","description":"The missing package manager for OS X.","fork":false,"url":"https://api.github.com/repos/Homebrew/homebrew","forks_url":"https://api.github.com/repos/Homebrew/homebrew/forks","keys_url":"https://api.github.com/repos/Homebrew/homebrew/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Homebrew/homebrew/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Homebrew/homebrew/teams","hooks_url":"https://api.github.com/repos/Homebrew/homebrew/hooks","issue_events_url":"https://api.github.com/repos/Homebrew/homebrew/issues/events{/number}","events_url":"https://api.github.com/repos/Homebrew/homebrew/events","assignees_url":"https://api.github.com/repos/Homebrew/homebrew/assignees{/user}","branches_url":"https://api.github.com/repos/Homebrew/homebrew/branches{/branch}","tags_url":"https://api.github.com/repos/Homebrew/homebrew/tags","blobs_url":"https://api.github.com/repos/Homebrew/homebrew/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Homebrew/homebrew/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Homebrew/homebrew/git/refs{/sha}","trees_url":"https://api.github.com/repos/Homebrew/homebrew/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Homebrew/homebrew/statuses/{sha}","languages_url":"https://api.github.com/repos/Homebrew/homebrew/languages","stargazers_url":"https://api.github.com/repos/Homebrew/homebrew/stargazers","contributors_url":"https://api.github.com/repos/Homebrew/homebrew/contributors","subscribers_url":"https://api.github.com/repos/Homebrew/homebrew/subscribers","subscription_url":"https://api.github.com/repos/Homebrew/homebrew/subscription","commits_url":"https://api.github.com/repos/Homebrew/homebrew/commits{/sha}","git_commits_url":"https://api.github.com/repos/Homebrew/homebrew/git/commits{/sha}","comments_url":"https://api.github.com/repos/Homebrew/homebrew/comments{/number}","issue_comment_url":"https://api.github.com/repos/Homebrew/homebrew/issues/comments/{number}","contents_url":"https://api.github.com/repos/Homebrew/homebrew/contents/{+path}","compare_url":"https://api.github.com/repos/Homebrew/homebrew/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Homebrew/homebrew/merges","archive_url":"https://api.github.com/repos/Homebrew/homebrew/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Homebrew/homebrew/downloads","issues_url":"https://api.github.com/repos/Homebrew/homebrew/issues{/number}","pulls_url":"https://api.github.com/repos/Homebrew/homebrew/pulls{/number}","milestones_url":"https://api.github.com/repos/Homebrew/homebrew/milestones{/number}","notifications_url":"https://api.github.com/repos/Homebrew/homebrew/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Homebrew/homebrew/labels{/name}","releases_url":"https://api.github.com/repos/Homebrew/homebrew/releases{/id}","created_at":"2009-05-20T19:38:37Z","updated_at":"2014-10-30T07:53:33Z","pushed_at":"2014-10-30T08:31:24Z","git_url":"git://github.com/Homebrew/homebrew.git","ssh_url":"git@github.com:Homebrew/homebrew.git","clone_url":"https://github.com/Homebrew/homebrew.git","svn_url":"https://github.com/Homebrew/homebrew","homepage":"http://brew.sh","size":1234126,"stargazers_count":19831,"watchers_count":19831,"language":"Ruby","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":9828,"mirror_url":null,"open_issues_count":241,"forks":9828,"open_issues":241,"watchers":19831,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/33718"},"html":{"href":"https://github.com/Homebrew/homebrew/pull/33718"},"issue":{"href":"https://api.github.com/repos/Homebrew/homebrew/issues/33718"},"comments":{"href":"https://api.github.com/repos/Homebrew/homebrew/issues/33718/comments"},"review_comments":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/33718/comments"},"review_comment":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/33718/commits"},"statuses":{"href":"https://api.github.com/repos/Homebrew/homebrew/statuses/7a01a60747f0f0c12753092101bf0cb9547118bf"}}}}