GitHub PullRequestReviewCommentEvent at 2014-05-31 12:08:12
Repository: ndk
Actor: awong-dev
Payload: {"comment":{"url":"https://api.github.com/repos/awong-dev/ndk/pulls/comments/13260797","id":13260797,"diff_hunk":"@@ -42,6 +42,158 @@\n #pragma clang diagnostic ignored \"-Wsign-conversion\"\n #endif\n \n+#ifndef _LIBCPP_LOCALE__L_EXTENSIONS","path":"sources/cxx-stl/llvm-libc++/libcxx/src/locale.cpp","position":4,"original_position":4,"commit_id":"8f2d7c0880361abbcf4ccaca0a9d4e2dda6f1a63","original_commit_id":"8f2d7c0880361abbcf4ccaca0a9d4e2dda6f1a63","user":{"login":"awong-dev","id":144579,"avatar_url":"https://avatars.githubusercontent.com/u/144579?","gravatar_id":"27bc9f128bc2437600f07badef87f6c2","url":"https://api.github.com/users/awong-dev","html_url":"https://github.com/awong-dev","followers_url":"https://api.github.com/users/awong-dev/followers","following_url":"https://api.github.com/users/awong-dev/following{/other_user}","gists_url":"https://api.github.com/users/awong-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/awong-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awong-dev/subscriptions","organizations_url":"https://api.github.com/users/awong-dev/orgs","repos_url":"https://api.github.com/users/awong-dev/repos","events_url":"https://api.github.com/users/awong-dev/events{/privacy}","received_events_url":"https://api.github.com/users/awong-dev/received_events","type":"User","site_admin":false},"body":"My understanding might be wrong here so double-check me, but I thoguth these ctype functions are supposed to be provided by the libc, not the c++ runtime.\r\n\r\nIf so, then these would make more sense in a support library.  I think this file is meant to export the couple of std:: apis (eg locale::classic()) that happen to wrap the libc locale libraries.","created_at":"2014-05-31T12:08:12Z","updated_at":"2014-05-31T12:08:12Z","html_url":"https://github.com/awong-dev/ndk/pull/93#discussion_r13260797","pull_request_url":"https://api.github.com/repos/awong-dev/ndk/pulls/93","_links":{"self":{"href":"https://api.github.com/repos/awong-dev/ndk/pulls/comments/13260797"},"html":{"href":"https://github.com/awong-dev/ndk/pull/93#discussion_r13260797"},"pull_request":{"href":"https://api.github.com/repos/awong-dev/ndk/pulls/93"}}}}