GitHub PullRequestEvent at 2014-08-21 12:14:07
Repository: jasmine-rails
Actor: werkshy
Payload: {"action":"opened","number":143,"pull_request":{"url":"https://api.github.com/repos/searls/jasmine-rails/pulls/143","id":20105616,"html_url":"https://github.com/searls/jasmine-rails/pull/143","diff_url":"https://github.com/searls/jasmine-rails/pull/143.diff","patch_url":"https://github.com/searls/jasmine-rails/pull/143.patch","issue_url":"https://api.github.com/repos/searls/jasmine-rails/issues/143","number":143,"state":"open","locked":false,"title":"Protect against nil source in offline_asset_paths","user":{"login":"werkshy","id":3298,"avatar_url":"https://avatars.githubusercontent.com/u/3298?v=2","gravatar_id":"5ec42b48f0e4a608b658cdd659189408","url":"https://api.github.com/users/werkshy","html_url":"https://github.com/werkshy","followers_url":"https://api.github.com/users/werkshy/followers","following_url":"https://api.github.com/users/werkshy/following{/other_user}","gists_url":"https://api.github.com/users/werkshy/gists{/gist_id}","starred_url":"https://api.github.com/users/werkshy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/werkshy/subscriptions","organizations_url":"https://api.github.com/users/werkshy/orgs","repos_url":"https://api.github.com/users/werkshy/repos","events_url":"https://api.github.com/users/werkshy/events{/privacy}","received_events_url":"https://api.github.com/users/werkshy/received_events","type":"User","site_admin":false},"body":"The monkey-patched offline asset path stuff was receiving a nil 'source' argument in our app and crashing before writing the assets and runner.html. It seems prudent to just ignore these. (This PR fixes the problem for us).\r\n\r\nFWIW the line in our code that seemed to be triggering this was this:\r\n\r\n    \"#{ActionController::Base.asset_host}#{ActionController::Base.helpers.asset_path(self.checkout_image)}\",\r\n\r\nI think in this case self.checkout_image is nil.","created_at":"2014-08-21T12:14:06Z","updated_at":"2014-08-21T12:14:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1bd148f25eb2fdb3f2367c61024d8d969fb92b77","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/searls/jasmine-rails/pulls/143/commits","review_comments_url":"https://api.github.com/repos/searls/jasmine-rails/pulls/143/comments","review_comment_url":"https://api.github.com/repos/searls/jasmine-rails/pulls/comments/{number}","comments_url":"https://api.github.com/repos/searls/jasmine-rails/issues/143/comments","statuses_url":"https://api.github.com/repos/searls/jasmine-rails/statuses/0a1a8af4a7ff41a5d8108b218ed8a07d9a0fd8f5","head":{"label":"werkshy:nil_source_fix","ref":"nil_source_fix","sha":"0a1a8af4a7ff41a5d8108b218ed8a07d9a0fd8f5","user":{"login":"werkshy","id":3298,"avatar_url":"https://avatars.githubusercontent.com/u/3298?v=2","gravatar_id":"5ec42b48f0e4a608b658cdd659189408","url":"https://api.github.com/users/werkshy","html_url":"https://github.com/werkshy","followers_url":"https://api.github.com/users/werkshy/followers","following_url":"https://api.github.com/users/werkshy/following{/other_user}","gists_url":"https://api.github.com/users/werkshy/gists{/gist_id}","starred_url":"https://api.github.com/users/werkshy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/werkshy/subscriptions","organizations_url":"https://api.github.com/users/werkshy/orgs","repos_url":"https://api.github.com/users/werkshy/repos","events_url":"https://api.github.com/users/werkshy/events{/privacy}","received_events_url":"https://api.github.com/users/werkshy/received_events","type":"User","site_admin":false},"repo":{"id":23185360,"name":"jasmine-rails","full_name":"werkshy/jasmine-rails","owner":{"login":"werkshy","id":3298,"avatar_url":"https://avatars.githubusercontent.com/u/3298?v=2","gravatar_id":"5ec42b48f0e4a608b658cdd659189408","url":"https://api.github.com/users/werkshy","html_url":"https://github.com/werkshy","followers_url":"https://api.github.com/users/werkshy/followers","following_url":"https://api.github.com/users/werkshy/following{/other_user}","gists_url":"https://api.github.com/users/werkshy/gists{/gist_id}","starred_url":"https://api.github.com/users/werkshy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/werkshy/subscriptions","organizations_url":"https://api.github.com/users/werkshy/orgs","repos_url":"https://api.github.com/users/werkshy/repos","events_url":"https://api.github.com/users/werkshy/events{/privacy}","received_events_url":"https://api.github.com/users/werkshy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/werkshy/jasmine-rails","description":"A Jasmine runner for rails projects that's got you covered in both the terminal and the browser","fork":true,"url":"https://api.github.com/repos/werkshy/jasmine-rails","forks_url":"https://api.github.com/repos/werkshy/jasmine-rails/forks","keys_url":"https://api.github.com/repos/werkshy/jasmine-rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/werkshy/jasmine-rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/werkshy/jasmine-rails/teams","hooks_url":"https://api.github.com/repos/werkshy/jasmine-rails/hooks","issue_events_url":"https://api.github.com/repos/werkshy/jasmine-rails/issues/events{/number}","events_url":"https://api.github.com/repos/werkshy/jasmine-rails/events","assignees_url":"https://api.github.com/repos/werkshy/jasmine-rails/assignees{/user}","branches_url":"https://api.github.com/repos/werkshy/jasmine-rails/branches{/branch}","tags_url":"https://api.github.com/repos/werkshy/jasmine-rails/tags","blobs_url":"https://api.github.com/repos/werkshy/jasmine-rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/werkshy/jasmine-rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/werkshy/jasmine-rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/werkshy/jasmine-rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/werkshy/jasmine-rails/statuses/{sha}","languages_url":"https://api.github.com/repos/werkshy/jasmine-rails/languages","stargazers_url":"https://api.github.com/repos/werkshy/jasmine-rails/stargazers","contributors_url":"https://api.github.com/repos/werkshy/jasmine-rails/contributors","subscribers_url":"https://api.github.com/repos/werkshy/jasmine-rails/subscribers","subscription_url":"https://api.github.com/repos/werkshy/jasmine-rails/subscription","commits_url":"https://api.github.com/repos/werkshy/jasmine-rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/werkshy/jasmine-rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/werkshy/jasmine-rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/werkshy/jasmine-rails/issues/comments/{number}","contents_url":"https://api.github.com/repos/werkshy/jasmine-rails/contents/{+path}","compare_url":"https://api.github.com/repos/werkshy/jasmine-rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/werkshy/jasmine-rails/merges","archive_url":"https://api.github.com/repos/werkshy/jasmine-rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/werkshy/jasmine-rails/downloads","issues_url":"https://api.github.com/repos/werkshy/jasmine-rails/issues{/number}","pulls_url":"https://api.github.com/repos/werkshy/jasmine-rails/pulls{/number}","milestones_url":"https://api.github.com/repos/werkshy/jasmine-rails/milestones{/number}","notifications_url":"https://api.github.com/repos/werkshy/jasmine-rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/werkshy/jasmine-rails/labels{/name}","releases_url":"https://api.github.com/repos/werkshy/jasmine-rails/releases{/id}","created_at":"2014-08-21T11:57:32Z","updated_at":"2014-08-21T08:47:04Z","pushed_at":"2014-08-21T12:02:50Z","git_url":"git://github.com/werkshy/jasmine-rails.git","ssh_url":"git@github.com:werkshy/jasmine-rails.git","clone_url":"https://github.com/werkshy/jasmine-rails.git","svn_url":"https://github.com/werkshy/jasmine-rails","homepage":"http://rubygems.org/gems/jasmine-rails","size":1318,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"searls:master","ref":"master","sha":"736184143930cfb739d4e2d8aa61023e062f46f7","user":{"login":"searls","id":79303,"avatar_url":"https://avatars.githubusercontent.com/u/79303?v=2","gravatar_id":"e6c6e133e74c3b83f04d2861deaa1c20","url":"https://api.github.com/users/searls","html_url":"https://github.com/searls","followers_url":"https://api.github.com/users/searls/followers","following_url":"https://api.github.com/users/searls/following{/other_user}","gists_url":"https://api.github.com/users/searls/gists{/gist_id}","starred_url":"https://api.github.com/users/searls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/searls/subscriptions","organizations_url":"https://api.github.com/users/searls/orgs","repos_url":"https://api.github.com/users/searls/repos","events_url":"https://api.github.com/users/searls/events{/privacy}","received_events_url":"https://api.github.com/users/searls/received_events","type":"User","site_admin":false},"repo":{"id":2277989,"name":"jasmine-rails","full_name":"searls/jasmine-rails","owner":{"login":"searls","id":79303,"avatar_url":"https://avatars.githubusercontent.com/u/79303?v=2","gravatar_id":"e6c6e133e74c3b83f04d2861deaa1c20","url":"https://api.github.com/users/searls","html_url":"https://github.com/searls","followers_url":"https://api.github.com/users/searls/followers","following_url":"https://api.github.com/users/searls/following{/other_user}","gists_url":"https://api.github.com/users/searls/gists{/gist_id}","starred_url":"https://api.github.com/users/searls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/searls/subscriptions","organizations_url":"https://api.github.com/users/searls/orgs","repos_url":"https://api.github.com/users/searls/repos","events_url":"https://api.github.com/users/searls/events{/privacy}","received_events_url":"https://api.github.com/users/searls/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/searls/jasmine-rails","description":"A Jasmine runner for rails projects that's got you covered in both the terminal and the browser","fork":false,"url":"https://api.github.com/repos/searls/jasmine-rails","forks_url":"https://api.github.com/repos/searls/jasmine-rails/forks","keys_url":"https://api.github.com/repos/searls/jasmine-rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/searls/jasmine-rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/searls/jasmine-rails/teams","hooks_url":"https://api.github.com/repos/searls/jasmine-rails/hooks","issue_events_url":"https://api.github.com/repos/searls/jasmine-rails/issues/events{/number}","events_url":"https://api.github.com/repos/searls/jasmine-rails/events","assignees_url":"https://api.github.com/repos/searls/jasmine-rails/assignees{/user}","branches_url":"https://api.github.com/repos/searls/jasmine-rails/branches{/branch}","tags_url":"https://api.github.com/repos/searls/jasmine-rails/tags","blobs_url":"https://api.github.com/repos/searls/jasmine-rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/searls/jasmine-rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/searls/jasmine-rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/searls/jasmine-rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/searls/jasmine-rails/statuses/{sha}","languages_url":"https://api.github.com/repos/searls/jasmine-rails/languages","stargazers_url":"https://api.github.com/repos/searls/jasmine-rails/stargazers","contributors_url":"https://api.github.com/repos/searls/jasmine-rails/contributors","subscribers_url":"https://api.github.com/repos/searls/jasmine-rails/subscribers","subscription_url":"https://api.github.com/repos/searls/jasmine-rails/subscription","commits_url":"https://api.github.com/repos/searls/jasmine-rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/searls/jasmine-rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/searls/jasmine-rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/searls/jasmine-rails/issues/comments/{number}","contents_url":"https://api.github.com/repos/searls/jasmine-rails/contents/{+path}","compare_url":"https://api.github.com/repos/searls/jasmine-rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/searls/jasmine-rails/merges","archive_url":"https://api.github.com/repos/searls/jasmine-rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/searls/jasmine-rails/downloads","issues_url":"https://api.github.com/repos/searls/jasmine-rails/issues{/number}","pulls_url":"https://api.github.com/repos/searls/jasmine-rails/pulls{/number}","milestones_url":"https://api.github.com/repos/searls/jasmine-rails/milestones{/number}","notifications_url":"https://api.github.com/repos/searls/jasmine-rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/searls/jasmine-rails/labels{/name}","releases_url":"https://api.github.com/repos/searls/jasmine-rails/releases{/id}","created_at":"2011-08-27T04:52:06Z","updated_at":"2014-08-21T08:47:04Z","pushed_at":"2014-08-04T22:24:39Z","git_url":"git://github.com/searls/jasmine-rails.git","ssh_url":"git@github.com:searls/jasmine-rails.git","clone_url":"https://github.com/searls/jasmine-rails.git","svn_url":"https://github.com/searls/jasmine-rails","homepage":"http://rubygems.org/gems/jasmine-rails","size":1318,"stargazers_count":232,"watchers_count":232,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":109,"mirror_url":null,"open_issues_count":18,"forks":109,"open_issues":18,"watchers":232,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/searls/jasmine-rails/pulls/143"},"html":{"href":"https://github.com/searls/jasmine-rails/pull/143"},"issue":{"href":"https://api.github.com/repos/searls/jasmine-rails/issues/143"},"comments":{"href":"https://api.github.com/repos/searls/jasmine-rails/issues/143/comments"},"review_comments":{"href":"https://api.github.com/repos/searls/jasmine-rails/pulls/143/comments"},"review_comment":{"href":"https://api.github.com/repos/searls/jasmine-rails/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/searls/jasmine-rails/pulls/143/commits"},"statuses":{"href":"https://api.github.com/repos/searls/jasmine-rails/statuses/0a1a8af4a7ff41a5d8108b218ed8a07d9a0fd8f5"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}