GitHub PullRequestReviewCommentEvent at 2014-02-28 23:46:41
Repository: RIOT
Actor: OlegHahm
Payload: {"comment":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments/10186553","id":10186553,"diff_hunk":"@@ -1086,15 +1160,14 @@ void recv_nbr_sol(void)\n         icmpv6_opt_hdr_len += (opt_buf->length * 8);\n     }\n \n-    addr_list_t *alist_targ, *alist_dest;\n+    ipv6_net_if_hit_t alist_targ, alist_dest;\n \n     nbr_sol_buf = get_nbr_sol_buf(ipv6_ext_hdr_len);\n-    alist_targ = ipv6_iface_addr_match(&(nbr_sol_buf->target_addr));\n \n-    if (alist_targ != NULL) {\n-        alist_dest = ipv6_iface_addr_match(&(ipv6_buf->destaddr));\n+    if (ipv6_net_if_addr_match(&alist_targ, &nbr_sol_buf->target_addr) != NULL) {\n+        ipv6_net_if_addr_match(&alist_dest, &ipv6_buf->destaddr);\n \n-        if ((memcmp(&(alist_targ->addr), &(alist_dest->addr), 16) == 0) ||\n+        if ((memcmp(alist_targ.addr->addr_data, alist_dest.addr->addr_data, 16) == 0) ||","path":"sys/net/network_layer/sixlowpan/icmp.c","position":787,"original_position":787,"commit_id":"bce340fab1a6067e3530bc3dd0a79309dc71ea78","original_commit_id":"bce340fab1a6067e3530bc3dd0a79309dc71ea78","user":{"login":"OlegHahm","id":1590423,"avatar_url":"https://avatars.githubusercontent.com/u/1590423","gravatar_id":"0352936c8f6b1e38b2b8aff5b685ddea","url":"https://api.github.com/users/OlegHahm","html_url":"https://github.com/OlegHahm","followers_url":"https://api.github.com/users/OlegHahm/followers","following_url":"https://api.github.com/users/OlegHahm/following{/other_user}","gists_url":"https://api.github.com/users/OlegHahm/gists{/gist_id}","starred_url":"https://api.github.com/users/OlegHahm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OlegHahm/subscriptions","organizations_url":"https://api.github.com/users/OlegHahm/orgs","repos_url":"https://api.github.com/users/OlegHahm/repos","events_url":"https://api.github.com/users/OlegHahm/events{/privacy}","received_events_url":"https://api.github.com/users/OlegHahm/received_events","type":"User","site_admin":false},"body":"I'm a fan of having numbers explained. Why 16?","created_at":"2014-02-28T23:46:41Z","updated_at":"2014-02-28T23:46:41Z","html_url":"https://github.com/RIOT-OS/RIOT/pull/644#discussion_r10186553","pull_request_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/644","_links":{"self":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments/10186553"},"html":{"href":"https://github.com/RIOT-OS/RIOT/pull/644#discussion_r10186553"},"pull_request":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/644"}}}}