GitHub PullRequestEvent at 2014-10-08 21:09:29
Repository: Bolts-iOS
Actor: grantland
Payload: {"action":"closed","number":62,"pull_request":{"url":"https://api.github.com/repos/BoltsFramework/Bolts-iOS/pulls/62","id":22453653,"html_url":"https://github.com/BoltsFramework/Bolts-iOS/pull/62","diff_url":"https://github.com/BoltsFramework/Bolts-iOS/pull/62.diff","patch_url":"https://github.com/BoltsFramework/Bolts-iOS/pull/62.patch","issue_url":"https://api.github.com/repos/BoltsFramework/Bolts-iOS/issues/62","number":62,"state":"closed","locked":false,"title":"Update Bolts to work on OS X 10.10 and enable modules. Update iOS to include armv7s.","user":{"login":"nlutsenko-fb","id":7162174,"avatar_url":"https://avatars.githubusercontent.com/u/7162174?v=2","gravatar_id":"","url":"https://api.github.com/users/nlutsenko-fb","html_url":"https://github.com/nlutsenko-fb","followers_url":"https://api.github.com/users/nlutsenko-fb/followers","following_url":"https://api.github.com/users/nlutsenko-fb/following{/other_user}","gists_url":"https://api.github.com/users/nlutsenko-fb/gists{/gist_id}","starred_url":"https://api.github.com/users/nlutsenko-fb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nlutsenko-fb/subscriptions","organizations_url":"https://api.github.com/users/nlutsenko-fb/orgs","repos_url":"https://api.github.com/users/nlutsenko-fb/repos","events_url":"https://api.github.com/users/nlutsenko-fb/events{/privacy}","received_events_url":"https://api.github.com/users/nlutsenko-fb/received_events","type":"User","site_admin":false},"body":"Changes:\r\n- Converted Bolts for OS X to `framework` product-type. OS X had it since a long time ago, so it shouldn't affect anyone.\r\n- Added Info.plist for OS X version of Bolts. This is required on 10.10 right now.\r\n- Added `armv7s` to ARCHS for iOS, so everyone can still use it.\r\n- Enabled module support in OS X bolts. (`@import Bolts;` now works).\r\n- Cleaned up build scripts for new OS X deployment via `framework`.\r\n- Cleaned up .travis.yml file\r\n\r\nTest #1:\r\n- `./build_framework.sh` inside `scripts` folder.\r\n- Try using the version that is built on Xcode 5 / 6 in few applications for both iOS and OSX.\r\n\r\nTest #2:\r\n- `./build_framework.sh` inside `scripts` folder.\r\n- Try using Bolts for OS X with Xcode 6.1 Beta targeting OS X 10.10\r\n- Codesign shouldn't fail now.\r\n\r\nTest #3:\r\n- Try using Bolts for OS X in an example project\r\n- Replace `#import <Bolts/*>` with `@import Bolts;`\r\n- It shouldn't fail.\r\n\r\nOh yeah and the last one - travis CI now passes.","created_at":"2014-10-08T20:51:07Z","updated_at":"2014-10-08T21:09:28Z","closed_at":"2014-10-08T21:09:28Z","merged_at":"2014-10-08T21:09:28Z","merge_commit_sha":"5c9fd130d804425044b71fc8ec31931528c7743f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/BoltsFramework/Bolts-iOS/pulls/62/commits","review_comments_url":"https://api.github.com/repos/BoltsFramework/Bolts-iOS/pulls/62/comments","review_comment_url":"https://api.github.com/repos/BoltsFramework/Bolts-iOS/pulls/comments/{number}","comments_url":"https://api.github.com/repos/BoltsFramework/Bolts-iOS/issues/62/comments","statuses_url":"https://api.github.com/repos/BoltsFramework/Bolts-iOS/statuses/be80a7de81a94859f137ddc0d1ccf2a433e222fe","head":{"label":"nlutsenko-fb:framework","ref":"framework","sha":"be80a7de81a94859f137ddc0d1ccf2a433e222fe","user":{"login":"nlutsenko-fb","id":7162174,"avatar_url":"https://avatars.githubusercontent.com/u/7162174?v=2","gravatar_id":"","url":"https://api.github.com/users/nlutsenko-fb","html_url":"https://github.com/nlutsenko-fb","followers_url":"https://api.github.com/users/nlutsenko-fb/followers","following_url":"https://api.github.com/users/nlutsenko-fb/following{/other_user}","gists_url":"https://api.github.com/users/nlutsenko-fb/gists{/gist_id}","starred_url":"https://api.github.com/users/nlutsenko-fb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nlutsenko-fb/subscriptions","organizations_url":"https://api.github.com/users/nlutsenko-fb/orgs","repos_url":"https://api.github.com/users/nlutsenko-fb/repos","events_url":"https://api.github.com/users/nlutsenko-fb/events{/privacy}","received_events_url":"https://api.github.com/users/nlutsenko-fb/received_events","type":"User","site_admin":false},"repo":{"id":21584529,"name":"Bolts-iOS","full_name":"nlutsenko-fb/Bolts-iOS","owner":{"login":"nlutsenko-fb","id":7162174,"avatar_url":"https://avatars.githubusercontent.com/u/7162174?v=2","gravatar_id":"","url":"https://api.github.com/users/nlutsenko-fb","html_url":"https://github.com/nlutsenko-fb","followers_url":"https://api.github.com/users/nlutsenko-fb/followers","following_url":"https://api.github.com/users/nlutsenko-fb/following{/other_user}","gists_url":"https://api.github.com/users/nlutsenko-fb/gists{/gist_id}","starred_url":"https://api.github.com/users/nlutsenko-fb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nlutsenko-fb/subscriptions","organizations_url":"https://api.github.com/users/nlutsenko-fb/orgs","repos_url":"https://api.github.com/users/nlutsenko-fb/repos","events_url":"https://api.github.com/users/nlutsenko-fb/events{/privacy}","received_events_url":"https://api.github.com/users/nlutsenko-fb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nlutsenko-fb/Bolts-iOS","description":"Bolts is a collection of low-level libraries designed to make developing mobile apps easier.","fork":true,"url":"https://api.github.com/repos/nlutsenko-fb/Bolts-iOS","forks_url":"https://api.github.com/repos/nlutsenko-fb/Bolts-iOS/forks","keys_url":"https://api.github.com/repos/nlutsenko-fb/Bolts-iOS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nlutsenko-fb/Bolts-iOS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nlutsenko-fb/Bolts-iOS/teams","hooks_url":"https://api.github.com/repos/nlutsenko-fb/Bolts-iOS/hooks","issue_events_url":"https://api.github.com/repos/nlutsenko-fb/Bolts-iOS/issues/events{/number}","events_url":"https://api.github.com/repos/nlutsenko-fb/Bolts-iOS/events","assignees_url":"https://api.github.com/repos/nlutsenko-fb/Bolts-iOS/assignees{/user}","branches_url":"https://api.github.com/repos/nlutsenko-fb/Bolts-iOS/branches{/branch}","tags_url":"https://api.github.com/repos/nlutsenko-fb/Bolts-iOS/tags","blobs_url":"https://api.github.com/repos/nlutsenko-fb/Bolts-iOS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nlutsenko-fb/Bolts-iOS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nlutsenko-fb/Bolts-iOS/git/refs{/sha}","trees_url":"https://api.github.com/repos/nlutsenko-fb/Bolts-iOS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nlutsenko-fb/Bolts-iOS/statuses/{sha}","languages_url":"https://api.github.com/repos/nlutsenko-fb/Bolts-iOS/languages","stargazers_url":"https://api.github.com/repos/nlutsenko-fb/Bolts-iOS/stargazers","contributors_url":"https://api.github.com/repos/nlutsenko-fb/Bolts-iOS/contributors","subscribers_url":"https://api.github.com/repos/nlutsenko-fb/Bolts-iOS/subscribers","subscription_url":"https://api.github.com/repos/nlutsenko-fb/Bolts-iOS/subscription","commits_url":"https://api.github.com/repos/nlutsenko-fb/Bolts-iOS/commits{/sha}","git_commits_url":"https://api.github.com/repos/nlutsenko-fb/Bolts-iOS/git/commits{/sha}","comments_url":"https://api.github.com/repos/nlutsenko-fb/Bolts-iOS/comments{/number}","issue_comment_url":"https://api.github.com/repos/nlutsenko-fb/Bolts-iOS/issues/comments/{number}","contents_url":"https://api.github.com/repos/nlutsenko-fb/Bolts-iOS/contents/{+path}","compare_url":"https://api.github.com/repos/nlutsenko-fb/Bolts-iOS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nlutsenko-fb/Bolts-iOS/merges","archive_url":"https://api.github.com/repos/nlutsenko-fb/Bolts-iOS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nlutsenko-fb/Bolts-iOS/downloads","issues_url":"https://api.github.com/repos/nlutsenko-fb/Bolts-iOS/issues{/number}","pulls_url":"https://api.github.com/repos/nlutsenko-fb/Bolts-iOS/pulls{/number}","milestones_url":"https://api.github.com/repos/nlutsenko-fb/Bolts-iOS/milestones{/number}","notifications_url":"https://api.github.com/repos/nlutsenko-fb/Bolts-iOS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nlutsenko-fb/Bolts-iOS/labels{/name}","releases_url":"https://api.github.com/repos/nlutsenko-fb/Bolts-iOS/releases{/id}","created_at":"2014-07-07T19:54:17Z","updated_at":"2014-07-07T19:58:00Z","pushed_at":"2014-10-08T20:43:05Z","git_url":"git://github.com/nlutsenko-fb/Bolts-iOS.git","ssh_url":"git@github.com:nlutsenko-fb/Bolts-iOS.git","clone_url":"https://github.com/nlutsenko-fb/Bolts-iOS.git","svn_url":"https://github.com/nlutsenko-fb/Bolts-iOS","homepage":"http://boltsframework.github.io/docs/ios/","size":557,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"BoltsFramework:master","ref":"master","sha":"53156a4a57c2b23eda77316aed422a4ad2344a71","user":{"login":"BoltsFramework","id":6530429,"avatar_url":"https://avatars.githubusercontent.com/u/6530429?v=2","gravatar_id":"","url":"https://api.github.com/users/BoltsFramework","html_url":"https://github.com/BoltsFramework","followers_url":"https://api.github.com/users/BoltsFramework/followers","following_url":"https://api.github.com/users/BoltsFramework/following{/other_user}","gists_url":"https://api.github.com/users/BoltsFramework/gists{/gist_id}","starred_url":"https://api.github.com/users/BoltsFramework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BoltsFramework/subscriptions","organizations_url":"https://api.github.com/users/BoltsFramework/orgs","repos_url":"https://api.github.com/users/BoltsFramework/repos","events_url":"https://api.github.com/users/BoltsFramework/events{/privacy}","received_events_url":"https://api.github.com/users/BoltsFramework/received_events","type":"Organization","site_admin":false},"repo":{"id":16368651,"name":"Bolts-iOS","full_name":"BoltsFramework/Bolts-iOS","owner":{"login":"BoltsFramework","id":6530429,"avatar_url":"https://avatars.githubusercontent.com/u/6530429?v=2","gravatar_id":"","url":"https://api.github.com/users/BoltsFramework","html_url":"https://github.com/BoltsFramework","followers_url":"https://api.github.com/users/BoltsFramework/followers","following_url":"https://api.github.com/users/BoltsFramework/following{/other_user}","gists_url":"https://api.github.com/users/BoltsFramework/gists{/gist_id}","starred_url":"https://api.github.com/users/BoltsFramework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BoltsFramework/subscriptions","organizations_url":"https://api.github.com/users/BoltsFramework/orgs","repos_url":"https://api.github.com/users/BoltsFramework/repos","events_url":"https://api.github.com/users/BoltsFramework/events{/privacy}","received_events_url":"https://api.github.com/users/BoltsFramework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/BoltsFramework/Bolts-iOS","description":"Bolts is a collection of low-level libraries designed to make developing mobile apps easier.","fork":false,"url":"https://api.github.com/repos/BoltsFramework/Bolts-iOS","forks_url":"https://api.github.com/repos/BoltsFramework/Bolts-iOS/forks","keys_url":"https://api.github.com/repos/BoltsFramework/Bolts-iOS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BoltsFramework/Bolts-iOS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BoltsFramework/Bolts-iOS/teams","hooks_url":"https://api.github.com/repos/BoltsFramework/Bolts-iOS/hooks","issue_events_url":"https://api.github.com/repos/BoltsFramework/Bolts-iOS/issues/events{/number}","events_url":"https://api.github.com/repos/BoltsFramework/Bolts-iOS/events","assignees_url":"https://api.github.com/repos/BoltsFramework/Bolts-iOS/assignees{/user}","branches_url":"https://api.github.com/repos/BoltsFramework/Bolts-iOS/branches{/branch}","tags_url":"https://api.github.com/repos/BoltsFramework/Bolts-iOS/tags","blobs_url":"https://api.github.com/repos/BoltsFramework/Bolts-iOS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BoltsFramework/Bolts-iOS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BoltsFramework/Bolts-iOS/git/refs{/sha}","trees_url":"https://api.github.com/repos/BoltsFramework/Bolts-iOS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BoltsFramework/Bolts-iOS/statuses/{sha}","languages_url":"https://api.github.com/repos/BoltsFramework/Bolts-iOS/languages","stargazers_url":"https://api.github.com/repos/BoltsFramework/Bolts-iOS/stargazers","contributors_url":"https://api.github.com/repos/BoltsFramework/Bolts-iOS/contributors","subscribers_url":"https://api.github.com/repos/BoltsFramework/Bolts-iOS/subscribers","subscription_url":"https://api.github.com/repos/BoltsFramework/Bolts-iOS/subscription","commits_url":"https://api.github.com/repos/BoltsFramework/Bolts-iOS/commits{/sha}","git_commits_url":"https://api.github.com/repos/BoltsFramework/Bolts-iOS/git/commits{/sha}","comments_url":"https://api.github.com/repos/BoltsFramework/Bolts-iOS/comments{/number}","issue_comment_url":"https://api.github.com/repos/BoltsFramework/Bolts-iOS/issues/comments/{number}","contents_url":"https://api.github.com/repos/BoltsFramework/Bolts-iOS/contents/{+path}","compare_url":"https://api.github.com/repos/BoltsFramework/Bolts-iOS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BoltsFramework/Bolts-iOS/merges","archive_url":"https://api.github.com/repos/BoltsFramework/Bolts-iOS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BoltsFramework/Bolts-iOS/downloads","issues_url":"https://api.github.com/repos/BoltsFramework/Bolts-iOS/issues{/number}","pulls_url":"https://api.github.com/repos/BoltsFramework/Bolts-iOS/pulls{/number}","milestones_url":"https://api.github.com/repos/BoltsFramework/Bolts-iOS/milestones{/number}","notifications_url":"https://api.github.com/repos/BoltsFramework/Bolts-iOS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BoltsFramework/Bolts-iOS/labels{/name}","releases_url":"https://api.github.com/repos/BoltsFramework/Bolts-iOS/releases{/id}","created_at":"2014-01-30T04:54:14Z","updated_at":"2014-10-08T09:40:37Z","pushed_at":"2014-10-08T21:09:28Z","git_url":"git://github.com/BoltsFramework/Bolts-iOS.git","ssh_url":"git@github.com:BoltsFramework/Bolts-iOS.git","clone_url":"https://github.com/BoltsFramework/Bolts-iOS.git","svn_url":"https://github.com/BoltsFramework/Bolts-iOS","homepage":"http://boltsframework.github.io/docs/ios/","size":1469,"stargazers_count":2572,"watchers_count":2572,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":200,"mirror_url":null,"open_issues_count":16,"forks":200,"open_issues":16,"watchers":2572,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/BoltsFramework/Bolts-iOS/pulls/62"},"html":{"href":"https://github.com/BoltsFramework/Bolts-iOS/pull/62"},"issue":{"href":"https://api.github.com/repos/BoltsFramework/Bolts-iOS/issues/62"},"comments":{"href":"https://api.github.com/repos/BoltsFramework/Bolts-iOS/issues/62/comments"},"review_comments":{"href":"https://api.github.com/repos/BoltsFramework/Bolts-iOS/pulls/62/comments"},"review_comment":{"href":"https://api.github.com/repos/BoltsFramework/Bolts-iOS/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/BoltsFramework/Bolts-iOS/pulls/62/commits"},"statuses":{"href":"https://api.github.com/repos/BoltsFramework/Bolts-iOS/statuses/be80a7de81a94859f137ddc0d1ccf2a433e222fe"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"grantland","id":277030,"avatar_url":"https://avatars.githubusercontent.com/u/277030?v=2","gravatar_id":"","url":"https://api.github.com/users/grantland","html_url":"https://github.com/grantland","followers_url":"https://api.github.com/users/grantland/followers","following_url":"https://api.github.com/users/grantland/following{/other_user}","gists_url":"https://api.github.com/users/grantland/gists{/gist_id}","starred_url":"https://api.github.com/users/grantland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grantland/subscriptions","organizations_url":"https://api.github.com/users/grantland/orgs","repos_url":"https://api.github.com/users/grantland/repos","events_url":"https://api.github.com/users/grantland/events{/privacy}","received_events_url":"https://api.github.com/users/grantland/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":4,"additions":109,"deletions":24,"changed_files":6}}