GitHub PullRequestEvent at 2014-07-16 01:24:21
Repository: rollbar-gem
Actor: sbezboro
Payload: {"action":"closed","number":124,"pull_request":{"url":"https://api.github.com/repos/rollbar/rollbar-gem/pulls/124","id":18298699,"html_url":"https://github.com/rollbar/rollbar-gem/pull/124","diff_url":"https://github.com/rollbar/rollbar-gem/pull/124.diff","patch_url":"https://github.com/rollbar/rollbar-gem/pull/124.patch","issue_url":"https://api.github.com/repos/rollbar/rollbar-gem/issues/124","number":124,"state":"closed","title":"do not require rails its evil + cleanup other weird requires","user":{"login":"grosser","id":11367,"avatar_url":"https://avatars.githubusercontent.com/u/11367?","gravatar_id":"59436ecd4fe6ad7c34f67654d839f05f","url":"https://api.github.com/users/grosser","html_url":"https://github.com/grosser","followers_url":"https://api.github.com/users/grosser/followers","following_url":"https://api.github.com/users/grosser/following{/other_user}","gists_url":"https://api.github.com/users/grosser/gists{/gist_id}","starred_url":"https://api.github.com/users/grosser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grosser/subscriptions","organizations_url":"https://api.github.com/users/grosser/orgs","repos_url":"https://api.github.com/users/grosser/repos","events_url":"https://api.github.com/users/grosser/events{/privacy}","received_events_url":"https://api.github.com/users/grosser/received_events","type":"User","site_admin":false},"body":"`require 'securerandom' if defined?(SecureRandom)` etc does not make any sense to me ...\r\n\r\nthe usual railtie loads rails/railtie and not all of rails see https://github.com/rails/activemodel-globalid/blob/master/lib/active_model/railtie.rb and https://github.com/rails/activemodel-globalid/blob/master/lib/active_model/railtie.rb\r\n\r\n@brianr @sbezboro ","created_at":"2014-07-11T20:02:04Z","updated_at":"2014-07-16T01:24:21Z","closed_at":"2014-07-16T01:24:21Z","merged_at":"2014-07-16T01:24:21Z","merge_commit_sha":"246be33170592736efc8d2c3d834dc9f89275a75","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rollbar/rollbar-gem/pulls/124/commits","review_comments_url":"https://api.github.com/repos/rollbar/rollbar-gem/pulls/124/comments","review_comment_url":"https://api.github.com/repos/rollbar/rollbar-gem/pulls/comments/{number}","comments_url":"https://api.github.com/repos/rollbar/rollbar-gem/issues/124/comments","statuses_url":"https://api.github.com/repos/rollbar/rollbar-gem/statuses/aa47a3e1e8ea8d9512f7f6a8ac8affef951bc15d","head":{"label":"grosser:grosser/rails","ref":"grosser/rails","sha":"aa47a3e1e8ea8d9512f7f6a8ac8affef951bc15d","user":{"login":"grosser","id":11367,"avatar_url":"https://avatars.githubusercontent.com/u/11367?","gravatar_id":"59436ecd4fe6ad7c34f67654d839f05f","url":"https://api.github.com/users/grosser","html_url":"https://github.com/grosser","followers_url":"https://api.github.com/users/grosser/followers","following_url":"https://api.github.com/users/grosser/following{/other_user}","gists_url":"https://api.github.com/users/grosser/gists{/gist_id}","starred_url":"https://api.github.com/users/grosser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grosser/subscriptions","organizations_url":"https://api.github.com/users/grosser/orgs","repos_url":"https://api.github.com/users/grosser/repos","events_url":"https://api.github.com/users/grosser/events{/privacy}","received_events_url":"https://api.github.com/users/grosser/received_events","type":"User","site_admin":false},"repo":{"id":21356712,"name":"rollbar-gem","full_name":"grosser/rollbar-gem","owner":{"login":"grosser","id":11367,"avatar_url":"https://avatars.githubusercontent.com/u/11367?","gravatar_id":"59436ecd4fe6ad7c34f67654d839f05f","url":"https://api.github.com/users/grosser","html_url":"https://github.com/grosser","followers_url":"https://api.github.com/users/grosser/followers","following_url":"https://api.github.com/users/grosser/following{/other_user}","gists_url":"https://api.github.com/users/grosser/gists{/gist_id}","starred_url":"https://api.github.com/users/grosser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grosser/subscriptions","organizations_url":"https://api.github.com/users/grosser/orgs","repos_url":"https://api.github.com/users/grosser/repos","events_url":"https://api.github.com/users/grosser/events{/privacy}","received_events_url":"https://api.github.com/users/grosser/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/grosser/rollbar-gem","description":"Exception tracking and logging from Ruby to Rollbar","fork":true,"url":"https://api.github.com/repos/grosser/rollbar-gem","forks_url":"https://api.github.com/repos/grosser/rollbar-gem/forks","keys_url":"https://api.github.com/repos/grosser/rollbar-gem/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grosser/rollbar-gem/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grosser/rollbar-gem/teams","hooks_url":"https://api.github.com/repos/grosser/rollbar-gem/hooks","issue_events_url":"https://api.github.com/repos/grosser/rollbar-gem/issues/events{/number}","events_url":"https://api.github.com/repos/grosser/rollbar-gem/events","assignees_url":"https://api.github.com/repos/grosser/rollbar-gem/assignees{/user}","branches_url":"https://api.github.com/repos/grosser/rollbar-gem/branches{/branch}","tags_url":"https://api.github.com/repos/grosser/rollbar-gem/tags","blobs_url":"https://api.github.com/repos/grosser/rollbar-gem/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grosser/rollbar-gem/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grosser/rollbar-gem/git/refs{/sha}","trees_url":"https://api.github.com/repos/grosser/rollbar-gem/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grosser/rollbar-gem/statuses/{sha}","languages_url":"https://api.github.com/repos/grosser/rollbar-gem/languages","stargazers_url":"https://api.github.com/repos/grosser/rollbar-gem/stargazers","contributors_url":"https://api.github.com/repos/grosser/rollbar-gem/contributors","subscribers_url":"https://api.github.com/repos/grosser/rollbar-gem/subscribers","subscription_url":"https://api.github.com/repos/grosser/rollbar-gem/subscription","commits_url":"https://api.github.com/repos/grosser/rollbar-gem/commits{/sha}","git_commits_url":"https://api.github.com/repos/grosser/rollbar-gem/git/commits{/sha}","comments_url":"https://api.github.com/repos/grosser/rollbar-gem/comments{/number}","issue_comment_url":"https://api.github.com/repos/grosser/rollbar-gem/issues/comments/{number}","contents_url":"https://api.github.com/repos/grosser/rollbar-gem/contents/{+path}","compare_url":"https://api.github.com/repos/grosser/rollbar-gem/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grosser/rollbar-gem/merges","archive_url":"https://api.github.com/repos/grosser/rollbar-gem/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grosser/rollbar-gem/downloads","issues_url":"https://api.github.com/repos/grosser/rollbar-gem/issues{/number}","pulls_url":"https://api.github.com/repos/grosser/rollbar-gem/pulls{/number}","milestones_url":"https://api.github.com/repos/grosser/rollbar-gem/milestones{/number}","notifications_url":"https://api.github.com/repos/grosser/rollbar-gem/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grosser/rollbar-gem/labels{/name}","releases_url":"https://api.github.com/repos/grosser/rollbar-gem/releases{/id}","created_at":"2014-06-30T15:46:36Z","updated_at":"2014-06-27T00:46:28Z","pushed_at":"2014-07-11T20:00:00Z","git_url":"git://github.com/grosser/rollbar-gem.git","ssh_url":"git@github.com:grosser/rollbar-gem.git","clone_url":"https://github.com/grosser/rollbar-gem.git","svn_url":"https://github.com/grosser/rollbar-gem","homepage":"https://rollbar.com/docs/notifier/rollbar-gem/","size":587,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rollbar:master","ref":"master","sha":"f584b8f274691259656b6a77f378b69fc042a876","user":{"login":"rollbar","id":3219584,"avatar_url":"https://avatars.githubusercontent.com/u/3219584?","gravatar_id":"643437c4dd1d181d9817de165169180b","url":"https://api.github.com/users/rollbar","html_url":"https://github.com/rollbar","followers_url":"https://api.github.com/users/rollbar/followers","following_url":"https://api.github.com/users/rollbar/following{/other_user}","gists_url":"https://api.github.com/users/rollbar/gists{/gist_id}","starred_url":"https://api.github.com/users/rollbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rollbar/subscriptions","organizations_url":"https://api.github.com/users/rollbar/orgs","repos_url":"https://api.github.com/users/rollbar/repos","events_url":"https://api.github.com/users/rollbar/events{/privacy}","received_events_url":"https://api.github.com/users/rollbar/received_events","type":"Organization","site_admin":false},"repo":{"id":5556347,"name":"rollbar-gem","full_name":"rollbar/rollbar-gem","owner":{"login":"rollbar","id":3219584,"avatar_url":"https://avatars.githubusercontent.com/u/3219584?","gravatar_id":"643437c4dd1d181d9817de165169180b","url":"https://api.github.com/users/rollbar","html_url":"https://github.com/rollbar","followers_url":"https://api.github.com/users/rollbar/followers","following_url":"https://api.github.com/users/rollbar/following{/other_user}","gists_url":"https://api.github.com/users/rollbar/gists{/gist_id}","starred_url":"https://api.github.com/users/rollbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rollbar/subscriptions","organizations_url":"https://api.github.com/users/rollbar/orgs","repos_url":"https://api.github.com/users/rollbar/repos","events_url":"https://api.github.com/users/rollbar/events{/privacy}","received_events_url":"https://api.github.com/users/rollbar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rollbar/rollbar-gem","description":"Exception tracking and logging from Ruby to Rollbar","fork":false,"url":"https://api.github.com/repos/rollbar/rollbar-gem","forks_url":"https://api.github.com/repos/rollbar/rollbar-gem/forks","keys_url":"https://api.github.com/repos/rollbar/rollbar-gem/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rollbar/rollbar-gem/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rollbar/rollbar-gem/teams","hooks_url":"https://api.github.com/repos/rollbar/rollbar-gem/hooks","issue_events_url":"https://api.github.com/repos/rollbar/rollbar-gem/issues/events{/number}","events_url":"https://api.github.com/repos/rollbar/rollbar-gem/events","assignees_url":"https://api.github.com/repos/rollbar/rollbar-gem/assignees{/user}","branches_url":"https://api.github.com/repos/rollbar/rollbar-gem/branches{/branch}","tags_url":"https://api.github.com/repos/rollbar/rollbar-gem/tags","blobs_url":"https://api.github.com/repos/rollbar/rollbar-gem/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rollbar/rollbar-gem/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rollbar/rollbar-gem/git/refs{/sha}","trees_url":"https://api.github.com/repos/rollbar/rollbar-gem/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rollbar/rollbar-gem/statuses/{sha}","languages_url":"https://api.github.com/repos/rollbar/rollbar-gem/languages","stargazers_url":"https://api.github.com/repos/rollbar/rollbar-gem/stargazers","contributors_url":"https://api.github.com/repos/rollbar/rollbar-gem/contributors","subscribers_url":"https://api.github.com/repos/rollbar/rollbar-gem/subscribers","subscription_url":"https://api.github.com/repos/rollbar/rollbar-gem/subscription","commits_url":"https://api.github.com/repos/rollbar/rollbar-gem/commits{/sha}","git_commits_url":"https://api.github.com/repos/rollbar/rollbar-gem/git/commits{/sha}","comments_url":"https://api.github.com/repos/rollbar/rollbar-gem/comments{/number}","issue_comment_url":"https://api.github.com/repos/rollbar/rollbar-gem/issues/comments/{number}","contents_url":"https://api.github.com/repos/rollbar/rollbar-gem/contents/{+path}","compare_url":"https://api.github.com/repos/rollbar/rollbar-gem/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rollbar/rollbar-gem/merges","archive_url":"https://api.github.com/repos/rollbar/rollbar-gem/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rollbar/rollbar-gem/downloads","issues_url":"https://api.github.com/repos/rollbar/rollbar-gem/issues{/number}","pulls_url":"https://api.github.com/repos/rollbar/rollbar-gem/pulls{/number}","milestones_url":"https://api.github.com/repos/rollbar/rollbar-gem/milestones{/number}","notifications_url":"https://api.github.com/repos/rollbar/rollbar-gem/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rollbar/rollbar-gem/labels{/name}","releases_url":"https://api.github.com/repos/rollbar/rollbar-gem/releases{/id}","created_at":"2012-08-26T01:00:16Z","updated_at":"2014-07-03T08:19:59Z","pushed_at":"2014-07-16T01:24:21Z","git_url":"git://github.com/rollbar/rollbar-gem.git","ssh_url":"git@github.com:rollbar/rollbar-gem.git","clone_url":"https://github.com/rollbar/rollbar-gem.git","svn_url":"https://github.com/rollbar/rollbar-gem","homepage":"https://rollbar.com/docs/notifier/rollbar-gem/","size":2287,"stargazers_count":38,"watchers_count":38,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":47,"mirror_url":null,"open_issues_count":20,"forks":47,"open_issues":20,"watchers":38,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rollbar/rollbar-gem/pulls/124"},"html":{"href":"https://github.com/rollbar/rollbar-gem/pull/124"},"issue":{"href":"https://api.github.com/repos/rollbar/rollbar-gem/issues/124"},"comments":{"href":"https://api.github.com/repos/rollbar/rollbar-gem/issues/124/comments"},"review_comments":{"href":"https://api.github.com/repos/rollbar/rollbar-gem/pulls/124/comments"},"review_comment":{"href":"https://api.github.com/repos/rollbar/rollbar-gem/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/rollbar/rollbar-gem/pulls/124/commits"},"statuses":{"href":"https://api.github.com/repos/rollbar/rollbar-gem/statuses/aa47a3e1e8ea8d9512f7f6a8ac8affef951bc15d"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"sbezboro","id":1294576,"avatar_url":"https://avatars.githubusercontent.com/u/1294576?","gravatar_id":"9a1885ab106722bac0e233bc30a0fccb","url":"https://api.github.com/users/sbezboro","html_url":"https://github.com/sbezboro","followers_url":"https://api.github.com/users/sbezboro/followers","following_url":"https://api.github.com/users/sbezboro/following{/other_user}","gists_url":"https://api.github.com/users/sbezboro/gists{/gist_id}","starred_url":"https://api.github.com/users/sbezboro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbezboro/subscriptions","organizations_url":"https://api.github.com/users/sbezboro/orgs","repos_url":"https://api.github.com/users/sbezboro/repos","events_url":"https://api.github.com/users/sbezboro/events{/privacy}","received_events_url":"https://api.github.com/users/sbezboro/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"commits":1,"additions":5,"deletions":11,"changed_files":2}}