GitHub PullRequestReviewCommentEvent at 2014-05-20 14:38:29
Repository: di.dart
Actor: vicb
Payload: {"comment":{"url":"https://api.github.com/repos/angular/di.dart/pulls/comments/12846908","id":12846908,"diff_hunk":"@@ -16,6 +16,15 @@ String error(ResolutionContext resolving, String message, [Key appendDependency]\n   if (appendDependency != null) {\n     resolving = new ResolutionContext(resolving.depth + 1, appendDependency, resolving);\n   }\n-  String path = resolving.ancestorKeys().reversed.join(' -> ');\n-  return '$message (resolving $path)';\n+  List resolvingKeys = resolving.ancestorKeys.reversed.toList(growable: false);\n+  // De-duplicate keys when there is a circular dependency\n+  // This is required because we don't check for circular dependencies before the\n+  // a depth threshold which would lead to msg like \"A -> B -> A -> B -> ... -> A\"\n+  for (var i = 1; i < resolvingKeys.length - 1; i++) {\n+    if (resolvingKeys[i] == resolvingKeys.first) {\n+      resolvingKeys = resolvingKeys.sublist(0, i + 1);","path":"lib/src/error_helper.dart","position":12,"original_position":12,"commit_id":"4ccdb1f0723c140bceb332a317884770c02ad4a8","original_commit_id":"4ccdb1f0723c140bceb332a317884770c02ad4a8","user":{"login":"vicb","id":248818,"avatar_url":"https://avatars.githubusercontent.com/u/248818?","gravatar_id":"ca6e92a6fc51417b3749e68d26df1f29","url":"https://api.github.com/users/vicb","html_url":"https://github.com/vicb","followers_url":"https://api.github.com/users/vicb/followers","following_url":"https://api.github.com/users/vicb/following{/other_user}","gists_url":"https://api.github.com/users/vicb/gists{/gist_id}","starred_url":"https://api.github.com/users/vicb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vicb/subscriptions","organizations_url":"https://api.github.com/users/vicb/orgs","repos_url":"https://api.github.com/users/vicb/repos","events_url":"https://api.github.com/users/vicb/events{/privacy}","received_events_url":"https://api.github.com/users/vicb/received_events","type":"User","site_admin":false},"body":"seen that when I had already submitted the PR... not a real concern as perf is not a pb here","created_at":"2014-05-20T14:38:29Z","updated_at":"2014-05-20T14:38:29Z","html_url":"https://github.com/angular/di.dart/pull/101#discussion_r12846908","pull_request_url":"https://api.github.com/repos/angular/di.dart/pulls/101","_links":{"self":{"href":"https://api.github.com/repos/angular/di.dart/pulls/comments/12846908"},"html":{"href":"https://github.com/angular/di.dart/pull/101#discussion_r12846908"},"pull_request":{"href":"https://api.github.com/repos/angular/di.dart/pulls/101"}}}}