GitHub PullRequestEvent at 2014-06-05 13:09:02
Repository: blocklayered
Actor: gRoussac
Payload: {"action":"closed","number":11,"pull_request":{"url":"https://api.github.com/repos/PrestaShop/blocklayered/pulls/11","id":16764540,"html_url":"https://github.com/PrestaShop/blocklayered/pull/11","diff_url":"https://github.com/PrestaShop/blocklayered/pull/11.diff","patch_url":"https://github.com/PrestaShop/blocklayered/pull/11.patch","issue_url":"https://api.github.com/repos/PrestaShop/blocklayered/issues/11","number":11,"state":"closed","title":"Fix incompatibility : product comparison & block layered","user":{"login":"nicooprat","id":645641,"avatar_url":"https://avatars.githubusercontent.com/u/645641?","gravatar_id":"02dc1f1df1b512b989f12ba47707064d","url":"https://api.github.com/users/nicooprat","html_url":"https://github.com/nicooprat","followers_url":"https://api.github.com/users/nicooprat/followers","following_url":"https://api.github.com/users/nicooprat/following{/other_user}","gists_url":"https://api.github.com/users/nicooprat/gists{/gist_id}","starred_url":"https://api.github.com/users/nicooprat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicooprat/subscriptions","organizations_url":"https://api.github.com/users/nicooprat/orgs","repos_url":"https://api.github.com/users/nicooprat/repos","events_url":"https://api.github.com/users/nicooprat/events{/privacy}","received_events_url":"https://api.github.com/users/nicooprat/received_events","type":"User","site_admin":false},"body":"When using block layered, the variable `compareProducts` was not passed to Smarty and disallow us from using the product comparator : checkboxes were obviously never checked. Just added one line in the Smarty assign.\r\n\r\nThis bug exists for many years and is pretty annoying ! Please consider merging fast, thanks.","created_at":"2014-06-05T13:07:50Z","updated_at":"2014-06-05T13:09:02Z","closed_at":"2014-06-05T13:09:02Z","merged_at":null,"merge_commit_sha":"fd21231aab526b8889a0f7175f4b7b6ea83758aa","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/PrestaShop/blocklayered/pulls/11/commits","review_comments_url":"https://api.github.com/repos/PrestaShop/blocklayered/pulls/11/comments","review_comment_url":"https://api.github.com/repos/PrestaShop/blocklayered/pulls/comments/{number}","comments_url":"https://api.github.com/repos/PrestaShop/blocklayered/issues/11/comments","statuses_url":"https://api.github.com/repos/PrestaShop/blocklayered/statuses/83f17eed3ac85fa335d33db78084f3cfca882f4a","head":{"label":"Mezcalito:master","ref":"master","sha":"83f17eed3ac85fa335d33db78084f3cfca882f4a","user":{"login":"Mezcalito","id":736547,"avatar_url":"https://avatars.githubusercontent.com/u/736547?","gravatar_id":"7e1e3a96b0a89be5eff61a7472e5ca7f","url":"https://api.github.com/users/Mezcalito","html_url":"https://github.com/Mezcalito","followers_url":"https://api.github.com/users/Mezcalito/followers","following_url":"https://api.github.com/users/Mezcalito/following{/other_user}","gists_url":"https://api.github.com/users/Mezcalito/gists{/gist_id}","starred_url":"https://api.github.com/users/Mezcalito/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mezcalito/subscriptions","organizations_url":"https://api.github.com/users/Mezcalito/orgs","repos_url":"https://api.github.com/users/Mezcalito/repos","events_url":"https://api.github.com/users/Mezcalito/events{/privacy}","received_events_url":"https://api.github.com/users/Mezcalito/received_events","type":"Organization","site_admin":false},"repo":{"id":20525136,"name":"blocklayered","full_name":"Mezcalito/blocklayered","owner":{"login":"Mezcalito","id":736547,"avatar_url":"https://avatars.githubusercontent.com/u/736547?","gravatar_id":"7e1e3a96b0a89be5eff61a7472e5ca7f","url":"https://api.github.com/users/Mezcalito","html_url":"https://github.com/Mezcalito","followers_url":"https://api.github.com/users/Mezcalito/followers","following_url":"https://api.github.com/users/Mezcalito/following{/other_user}","gists_url":"https://api.github.com/users/Mezcalito/gists{/gist_id}","starred_url":"https://api.github.com/users/Mezcalito/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mezcalito/subscriptions","organizations_url":"https://api.github.com/users/Mezcalito/orgs","repos_url":"https://api.github.com/users/Mezcalito/repos","events_url":"https://api.github.com/users/Mezcalito/events{/privacy}","received_events_url":"https://api.github.com/users/Mezcalito/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Mezcalito/blocklayered","description":"","fork":true,"url":"https://api.github.com/repos/Mezcalito/blocklayered","forks_url":"https://api.github.com/repos/Mezcalito/blocklayered/forks","keys_url":"https://api.github.com/repos/Mezcalito/blocklayered/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Mezcalito/blocklayered/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Mezcalito/blocklayered/teams","hooks_url":"https://api.github.com/repos/Mezcalito/blocklayered/hooks","issue_events_url":"https://api.github.com/repos/Mezcalito/blocklayered/issues/events{/number}","events_url":"https://api.github.com/repos/Mezcalito/blocklayered/events","assignees_url":"https://api.github.com/repos/Mezcalito/blocklayered/assignees{/user}","branches_url":"https://api.github.com/repos/Mezcalito/blocklayered/branches{/branch}","tags_url":"https://api.github.com/repos/Mezcalito/blocklayered/tags","blobs_url":"https://api.github.com/repos/Mezcalito/blocklayered/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Mezcalito/blocklayered/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Mezcalito/blocklayered/git/refs{/sha}","trees_url":"https://api.github.com/repos/Mezcalito/blocklayered/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Mezcalito/blocklayered/statuses/{sha}","languages_url":"https://api.github.com/repos/Mezcalito/blocklayered/languages","stargazers_url":"https://api.github.com/repos/Mezcalito/blocklayered/stargazers","contributors_url":"https://api.github.com/repos/Mezcalito/blocklayered/contributors","subscribers_url":"https://api.github.com/repos/Mezcalito/blocklayered/subscribers","subscription_url":"https://api.github.com/repos/Mezcalito/blocklayered/subscription","commits_url":"https://api.github.com/repos/Mezcalito/blocklayered/commits{/sha}","git_commits_url":"https://api.github.com/repos/Mezcalito/blocklayered/git/commits{/sha}","comments_url":"https://api.github.com/repos/Mezcalito/blocklayered/comments{/number}","issue_comment_url":"https://api.github.com/repos/Mezcalito/blocklayered/issues/comments/{number}","contents_url":"https://api.github.com/repos/Mezcalito/blocklayered/contents/{+path}","compare_url":"https://api.github.com/repos/Mezcalito/blocklayered/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Mezcalito/blocklayered/merges","archive_url":"https://api.github.com/repos/Mezcalito/blocklayered/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Mezcalito/blocklayered/downloads","issues_url":"https://api.github.com/repos/Mezcalito/blocklayered/issues{/number}","pulls_url":"https://api.github.com/repos/Mezcalito/blocklayered/pulls{/number}","milestones_url":"https://api.github.com/repos/Mezcalito/blocklayered/milestones{/number}","notifications_url":"https://api.github.com/repos/Mezcalito/blocklayered/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Mezcalito/blocklayered/labels{/name}","releases_url":"https://api.github.com/repos/Mezcalito/blocklayered/releases{/id}","created_at":"2014-06-05T13:03:10Z","updated_at":"2014-06-05T13:07:50Z","pushed_at":"2014-06-05T13:03:38Z","git_url":"git://github.com/Mezcalito/blocklayered.git","ssh_url":"git@github.com:Mezcalito/blocklayered.git","clone_url":"https://github.com/Mezcalito/blocklayered.git","svn_url":"https://github.com/Mezcalito/blocklayered","homepage":"http://www.prestashop.com","size":566,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PrestaShop:master","ref":"master","sha":"012ae536236ef4034ce1a119ed743529bb30ac9b","user":{"login":"PrestaShop","id":2815696,"avatar_url":"https://avatars.githubusercontent.com/u/2815696?","gravatar_id":"8af6bd93a53326e113722eff6f76d0fa","url":"https://api.github.com/users/PrestaShop","html_url":"https://github.com/PrestaShop","followers_url":"https://api.github.com/users/PrestaShop/followers","following_url":"https://api.github.com/users/PrestaShop/following{/other_user}","gists_url":"https://api.github.com/users/PrestaShop/gists{/gist_id}","starred_url":"https://api.github.com/users/PrestaShop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PrestaShop/subscriptions","organizations_url":"https://api.github.com/users/PrestaShop/orgs","repos_url":"https://api.github.com/users/PrestaShop/repos","events_url":"https://api.github.com/users/PrestaShop/events{/privacy}","received_events_url":"https://api.github.com/users/PrestaShop/received_events","type":"Organization","site_admin":false},"repo":{"id":17943147,"name":"blocklayered","full_name":"PrestaShop/blocklayered","owner":{"login":"PrestaShop","id":2815696,"avatar_url":"https://avatars.githubusercontent.com/u/2815696?","gravatar_id":"8af6bd93a53326e113722eff6f76d0fa","url":"https://api.github.com/users/PrestaShop","html_url":"https://github.com/PrestaShop","followers_url":"https://api.github.com/users/PrestaShop/followers","following_url":"https://api.github.com/users/PrestaShop/following{/other_user}","gists_url":"https://api.github.com/users/PrestaShop/gists{/gist_id}","starred_url":"https://api.github.com/users/PrestaShop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PrestaShop/subscriptions","organizations_url":"https://api.github.com/users/PrestaShop/orgs","repos_url":"https://api.github.com/users/PrestaShop/repos","events_url":"https://api.github.com/users/PrestaShop/events{/privacy}","received_events_url":"https://api.github.com/users/PrestaShop/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PrestaShop/blocklayered","description":"","fork":false,"url":"https://api.github.com/repos/PrestaShop/blocklayered","forks_url":"https://api.github.com/repos/PrestaShop/blocklayered/forks","keys_url":"https://api.github.com/repos/PrestaShop/blocklayered/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PrestaShop/blocklayered/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PrestaShop/blocklayered/teams","hooks_url":"https://api.github.com/repos/PrestaShop/blocklayered/hooks","issue_events_url":"https://api.github.com/repos/PrestaShop/blocklayered/issues/events{/number}","events_url":"https://api.github.com/repos/PrestaShop/blocklayered/events","assignees_url":"https://api.github.com/repos/PrestaShop/blocklayered/assignees{/user}","branches_url":"https://api.github.com/repos/PrestaShop/blocklayered/branches{/branch}","tags_url":"https://api.github.com/repos/PrestaShop/blocklayered/tags","blobs_url":"https://api.github.com/repos/PrestaShop/blocklayered/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PrestaShop/blocklayered/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PrestaShop/blocklayered/git/refs{/sha}","trees_url":"https://api.github.com/repos/PrestaShop/blocklayered/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PrestaShop/blocklayered/statuses/{sha}","languages_url":"https://api.github.com/repos/PrestaShop/blocklayered/languages","stargazers_url":"https://api.github.com/repos/PrestaShop/blocklayered/stargazers","contributors_url":"https://api.github.com/repos/PrestaShop/blocklayered/contributors","subscribers_url":"https://api.github.com/repos/PrestaShop/blocklayered/subscribers","subscription_url":"https://api.github.com/repos/PrestaShop/blocklayered/subscription","commits_url":"https://api.github.com/repos/PrestaShop/blocklayered/commits{/sha}","git_commits_url":"https://api.github.com/repos/PrestaShop/blocklayered/git/commits{/sha}","comments_url":"https://api.github.com/repos/PrestaShop/blocklayered/comments{/number}","issue_comment_url":"https://api.github.com/repos/PrestaShop/blocklayered/issues/comments/{number}","contents_url":"https://api.github.com/repos/PrestaShop/blocklayered/contents/{+path}","compare_url":"https://api.github.com/repos/PrestaShop/blocklayered/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PrestaShop/blocklayered/merges","archive_url":"https://api.github.com/repos/PrestaShop/blocklayered/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PrestaShop/blocklayered/downloads","issues_url":"https://api.github.com/repos/PrestaShop/blocklayered/issues{/number}","pulls_url":"https://api.github.com/repos/PrestaShop/blocklayered/pulls{/number}","milestones_url":"https://api.github.com/repos/PrestaShop/blocklayered/milestones{/number}","notifications_url":"https://api.github.com/repos/PrestaShop/blocklayered/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PrestaShop/blocklayered/labels{/name}","releases_url":"https://api.github.com/repos/PrestaShop/blocklayered/releases{/id}","created_at":"2014-03-20T13:16:55Z","updated_at":"2014-05-21T12:12:49Z","pushed_at":"2014-05-21T12:12:48Z","git_url":"git://github.com/PrestaShop/blocklayered.git","ssh_url":"git@github.com:PrestaShop/blocklayered.git","clone_url":"https://github.com/PrestaShop/blocklayered.git","svn_url":"https://github.com/PrestaShop/blocklayered","homepage":"http://www.prestashop.com","size":566,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":9,"mirror_url":null,"open_issues_count":4,"forks":9,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PrestaShop/blocklayered/pulls/11"},"html":{"href":"https://github.com/PrestaShop/blocklayered/pull/11"},"issue":{"href":"https://api.github.com/repos/PrestaShop/blocklayered/issues/11"},"comments":{"href":"https://api.github.com/repos/PrestaShop/blocklayered/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/PrestaShop/blocklayered/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/PrestaShop/blocklayered/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/PrestaShop/blocklayered/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/PrestaShop/blocklayered/statuses/83f17eed3ac85fa335d33db78084f3cfca882f4a"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"commits":1,"additions":1,"deletions":0,"changed_files":1}}