GitHub PullRequestEvent at 2014-01-15 19:03:42
Repository: moab_tools
Actor: Pshriwise
Payload: {"action":"closed","number":12,"pull_request":{"url":"https://api.github.com/repos/svalinn/moab_tools/pulls/12","id":9328396,"html_url":"https://github.com/svalinn/moab_tools/pull/12","diff_url":"https://github.com/svalinn/moab_tools/pull/12.diff","patch_url":"https://github.com/svalinn/moab_tools/pull/12.patch","issue_url":"https://github.com/svalinn/moab_tools/pull/12","number":12,"state":"closed","title":"Moab v4.6 changes","user":{"login":"Pshriwise","id":4563941,"avatar_url":"https://gravatar.com/avatar/0857316c4bf735f96aa9a2fb0f9b6091?d=https%3A%2F%2Fidenticons.github.com%2F837838514894e7a4a39dfeb6fa81b8af.png&r=x","gravatar_id":"0857316c4bf735f96aa9a2fb0f9b6091","url":"https://api.github.com/users/Pshriwise","html_url":"https://github.com/Pshriwise","followers_url":"https://api.github.com/users/Pshriwise/followers","following_url":"https://api.github.com/users/Pshriwise/following{/other_user}","gists_url":"https://api.github.com/users/Pshriwise/gists{/gist_id}","starred_url":"https://api.github.com/users/Pshriwise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pshriwise/subscriptions","organizations_url":"https://api.github.com/users/Pshriwise/orgs","repos_url":"https://api.github.com/users/Pshriwise/repos","events_url":"https://api.github.com/users/Pshriwise/events{/privacy}","received_events_url":"https://api.github.com/users/Pshriwise/received_events","type":"User","site_admin":false},"body":"uncommented the set_senses error check and added the condition MB_MULTIPLE_ENTITY_HANDLES_FOUND. For the time being I believe this to be ok as this is generally a result of two merged curves referencing the a small surface between them. The sense data for this surface is deleted upon the surface's deletion by the remove_surf_sense_data function I've written in mw_func.cpp so no references to erroneous sense data remain upon the file write. This has been the case for the iter model.\r\n\r\nThere is however a case in which curves can share multiple surfaces. However, it shouldn't be one which moab's set_senses has a problem with. I'll be developing a test for this soon.","created_at":"2013-10-23T13:04:11Z","updated_at":"2014-01-15T19:03:42Z","closed_at":"2014-01-15T19:03:42Z","merged_at":null,"merge_commit_sha":"549228410660fb16d7dbfd38738d214808c9edf4","assignee":null,"milestone":null,"commits_url":"https://github.com/svalinn/moab_tools/pull/12/commits","review_comments_url":"https://github.com/svalinn/moab_tools/pull/12/comments","review_comment_url":"/repos/svalinn/moab_tools/pulls/comments/{number}","comments_url":"https://api.github.com/repos/svalinn/moab_tools/issues/12/comments","statuses_url":"https://api.github.com/repos/svalinn/moab_tools/statuses/86a463e6c16cae674f3dce6f4d9670e54ec05cc6","head":{"label":"Pshriwise:moab_v4.6_changes","ref":"moab_v4.6_changes","sha":"86a463e6c16cae674f3dce6f4d9670e54ec05cc6","user":{"login":"Pshriwise","id":4563941,"avatar_url":"https://gravatar.com/avatar/0857316c4bf735f96aa9a2fb0f9b6091?d=https%3A%2F%2Fidenticons.github.com%2F837838514894e7a4a39dfeb6fa81b8af.png&r=x","gravatar_id":"0857316c4bf735f96aa9a2fb0f9b6091","url":"https://api.github.com/users/Pshriwise","html_url":"https://github.com/Pshriwise","followers_url":"https://api.github.com/users/Pshriwise/followers","following_url":"https://api.github.com/users/Pshriwise/following{/other_user}","gists_url":"https://api.github.com/users/Pshriwise/gists{/gist_id}","starred_url":"https://api.github.com/users/Pshriwise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pshriwise/subscriptions","organizations_url":"https://api.github.com/users/Pshriwise/orgs","repos_url":"https://api.github.com/users/Pshriwise/repos","events_url":"https://api.github.com/users/Pshriwise/events{/privacy}","received_events_url":"https://api.github.com/users/Pshriwise/received_events","type":"User","site_admin":false},"repo":{"id":11222440,"name":"moab_tools","full_name":"Pshriwise/moab_tools","owner":{"login":"Pshriwise","id":4563941,"avatar_url":"https://gravatar.com/avatar/0857316c4bf735f96aa9a2fb0f9b6091?d=https%3A%2F%2Fidenticons.github.com%2F837838514894e7a4a39dfeb6fa81b8af.png&r=x","gravatar_id":"0857316c4bf735f96aa9a2fb0f9b6091","url":"https://api.github.com/users/Pshriwise","html_url":"https://github.com/Pshriwise","followers_url":"https://api.github.com/users/Pshriwise/followers","following_url":"https://api.github.com/users/Pshriwise/following{/other_user}","gists_url":"https://api.github.com/users/Pshriwise/gists{/gist_id}","starred_url":"https://api.github.com/users/Pshriwise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pshriwise/subscriptions","organizations_url":"https://api.github.com/users/Pshriwise/orgs","repos_url":"https://api.github.com/users/Pshriwise/repos","events_url":"https://api.github.com/users/Pshriwise/events{/privacy}","received_events_url":"https://api.github.com/users/Pshriwise/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Pshriwise/moab_tools","description":"Tools for manipulating and examining moab meshes","fork":true,"url":"https://api.github.com/repos/Pshriwise/moab_tools","forks_url":"https://api.github.com/repos/Pshriwise/moab_tools/forks","keys_url":"https://api.github.com/repos/Pshriwise/moab_tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Pshriwise/moab_tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Pshriwise/moab_tools/teams","hooks_url":"https://api.github.com/repos/Pshriwise/moab_tools/hooks","issue_events_url":"https://api.github.com/repos/Pshriwise/moab_tools/issues/events{/number}","events_url":"https://api.github.com/repos/Pshriwise/moab_tools/events","assignees_url":"https://api.github.com/repos/Pshriwise/moab_tools/assignees{/user}","branches_url":"https://api.github.com/repos/Pshriwise/moab_tools/branches{/branch}","tags_url":"https://api.github.com/repos/Pshriwise/moab_tools/tags","blobs_url":"https://api.github.com/repos/Pshriwise/moab_tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Pshriwise/moab_tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Pshriwise/moab_tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/Pshriwise/moab_tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Pshriwise/moab_tools/statuses/{sha}","languages_url":"https://api.github.com/repos/Pshriwise/moab_tools/languages","stargazers_url":"https://api.github.com/repos/Pshriwise/moab_tools/stargazers","contributors_url":"https://api.github.com/repos/Pshriwise/moab_tools/contributors","subscribers_url":"https://api.github.com/repos/Pshriwise/moab_tools/subscribers","subscription_url":"https://api.github.com/repos/Pshriwise/moab_tools/subscription","commits_url":"https://api.github.com/repos/Pshriwise/moab_tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/Pshriwise/moab_tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/Pshriwise/moab_tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/Pshriwise/moab_tools/issues/comments/{number}","contents_url":"https://api.github.com/repos/Pshriwise/moab_tools/contents/{+path}","compare_url":"https://api.github.com/repos/Pshriwise/moab_tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Pshriwise/moab_tools/merges","archive_url":"https://api.github.com/repos/Pshriwise/moab_tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Pshriwise/moab_tools/downloads","issues_url":"https://api.github.com/repos/Pshriwise/moab_tools/issues{/number}","pulls_url":"https://api.github.com/repos/Pshriwise/moab_tools/pulls{/number}","milestones_url":"https://api.github.com/repos/Pshriwise/moab_tools/milestones{/number}","notifications_url":"https://api.github.com/repos/Pshriwise/moab_tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Pshriwise/moab_tools/labels{/name}","releases_url":"https://api.github.com/repos/Pshriwise/moab_tools/releases{/id}","created_at":"2013-07-06T18:25:09Z","updated_at":"2014-01-15T19:03:42Z","pushed_at":"2014-01-15T19:03:42Z","git_url":"git://github.com/Pshriwise/moab_tools.git","ssh_url":"git@github.com:Pshriwise/moab_tools.git","clone_url":"https://github.com/Pshriwise/moab_tools.git","svn_url":"https://github.com/Pshriwise/moab_tools","homepage":null,"size":8799,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":1,"default_branch":"master","master_branch":"master"}},"base":{"label":"svalinn:moab_v4.6_changes","ref":"moab_v4.6_changes","sha":"691aeca31a99e1b427d60ca342d97c75e5e0e3fc","user":{"login":"svalinn","id":1921454,"avatar_url":"https://gravatar.com/avatar/b3209041fb93fc23af1ddc9b3153f2d1?d=https%3A%2F%2Fidenticons.github.com%2F427fb679f131a2a6451d8f3ee97b5a30.png&r=x","gravatar_id":"b3209041fb93fc23af1ddc9b3153f2d1","url":"https://api.github.com/users/svalinn","html_url":"https://github.com/svalinn","followers_url":"https://api.github.com/users/svalinn/followers","following_url":"https://api.github.com/users/svalinn/following{/other_user}","gists_url":"https://api.github.com/users/svalinn/gists{/gist_id}","starred_url":"https://api.github.com/users/svalinn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svalinn/subscriptions","organizations_url":"https://api.github.com/users/svalinn/orgs","repos_url":"https://api.github.com/users/svalinn/repos","events_url":"https://api.github.com/users/svalinn/events{/privacy}","received_events_url":"https://api.github.com/users/svalinn/received_events","type":"Organization","site_admin":false},"repo":{"id":8636125,"name":"moab_tools","full_name":"svalinn/moab_tools","owner":{"login":"svalinn","id":1921454,"avatar_url":"https://gravatar.com/avatar/b3209041fb93fc23af1ddc9b3153f2d1?d=https%3A%2F%2Fidenticons.github.com%2F427fb679f131a2a6451d8f3ee97b5a30.png&r=x","gravatar_id":"b3209041fb93fc23af1ddc9b3153f2d1","url":"https://api.github.com/users/svalinn","html_url":"https://github.com/svalinn","followers_url":"https://api.github.com/users/svalinn/followers","following_url":"https://api.github.com/users/svalinn/following{/other_user}","gists_url":"https://api.github.com/users/svalinn/gists{/gist_id}","starred_url":"https://api.github.com/users/svalinn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svalinn/subscriptions","organizations_url":"https://api.github.com/users/svalinn/orgs","repos_url":"https://api.github.com/users/svalinn/repos","events_url":"https://api.github.com/users/svalinn/events{/privacy}","received_events_url":"https://api.github.com/users/svalinn/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/svalinn/moab_tools","description":"Tools for manipulating and examining moab meshes","fork":false,"url":"https://api.github.com/repos/svalinn/moab_tools","forks_url":"https://api.github.com/repos/svalinn/moab_tools/forks","keys_url":"https://api.github.com/repos/svalinn/moab_tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/svalinn/moab_tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/svalinn/moab_tools/teams","hooks_url":"https://api.github.com/repos/svalinn/moab_tools/hooks","issue_events_url":"https://api.github.com/repos/svalinn/moab_tools/issues/events{/number}","events_url":"https://api.github.com/repos/svalinn/moab_tools/events","assignees_url":"https://api.github.com/repos/svalinn/moab_tools/assignees{/user}","branches_url":"https://api.github.com/repos/svalinn/moab_tools/branches{/branch}","tags_url":"https://api.github.com/repos/svalinn/moab_tools/tags","blobs_url":"https://api.github.com/repos/svalinn/moab_tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/svalinn/moab_tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/svalinn/moab_tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/svalinn/moab_tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/svalinn/moab_tools/statuses/{sha}","languages_url":"https://api.github.com/repos/svalinn/moab_tools/languages","stargazers_url":"https://api.github.com/repos/svalinn/moab_tools/stargazers","contributors_url":"https://api.github.com/repos/svalinn/moab_tools/contributors","subscribers_url":"https://api.github.com/repos/svalinn/moab_tools/subscribers","subscription_url":"https://api.github.com/repos/svalinn/moab_tools/subscription","commits_url":"https://api.github.com/repos/svalinn/moab_tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/svalinn/moab_tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/svalinn/moab_tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/svalinn/moab_tools/issues/comments/{number}","contents_url":"https://api.github.com/repos/svalinn/moab_tools/contents/{+path}","compare_url":"https://api.github.com/repos/svalinn/moab_tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/svalinn/moab_tools/merges","archive_url":"https://api.github.com/repos/svalinn/moab_tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/svalinn/moab_tools/downloads","issues_url":"https://api.github.com/repos/svalinn/moab_tools/issues{/number}","pulls_url":"https://api.github.com/repos/svalinn/moab_tools/pulls{/number}","milestones_url":"https://api.github.com/repos/svalinn/moab_tools/milestones{/number}","notifications_url":"https://api.github.com/repos/svalinn/moab_tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/svalinn/moab_tools/labels{/name}","releases_url":"https://api.github.com/repos/svalinn/moab_tools/releases{/id}","created_at":"2013-03-07T20:42:58Z","updated_at":"2013-12-13T15:36:17Z","pushed_at":"2013-12-13T15:36:17Z","git_url":"git://github.com/svalinn/moab_tools.git","ssh_url":"git@github.com:svalinn/moab_tools.git","clone_url":"https://github.com/svalinn/moab_tools.git","svn_url":"https://github.com/svalinn/moab_tools","homepage":null,"size":3601,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":2,"mirror_url":null,"open_issues_count":7,"forks":2,"open_issues":7,"watchers":1,"default_branch":"master","master_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/svalinn/moab_tools/pulls/12"},"html":{"href":"https://github.com/svalinn/moab_tools/pull/12"},"issue":{"href":"https://api.github.com/repos/svalinn/moab_tools/issues/12"},"comments":{"href":"https://api.github.com/repos/svalinn/moab_tools/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/svalinn/moab_tools/pulls/12/comments"},"statuses":{"href":"https://api.github.com/repos/svalinn/moab_tools/statuses/86a463e6c16cae674f3dce6f4d9670e54ec05cc6"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":21,"additions":3898,"deletions":519,"changed_files":23}}