GitHub PullRequestReviewCommentEvent at 2014-12-11 16:44:20
Repository: export_roles_permissions
Actor: pacproduct
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/vijaycs85/export_roles_permissions/pulls/comments/21689090","id":21689090,"diff_hunk":"@@ -68,9 +72,9 @@ function export_roles_permissions_form_submit($form, &$form_state) {\n       $code[] = '  // Add the permissions to the role.';\n       $code[] = '  $permissions = array(';\n \n-      $perms = export_roles_permissions_get_role_permissions(array($rid => $rid));\n+      $perms = export_roles_permissions_get_role_permissions(array($rid => $roles[$rid]));\n       foreach ($perms[$rid] as $perm) {\n-        $code[] = \"    '\" . trim($perm) . \"',\";","path":"export_roles_permissions.admin.inc","position":58,"original_position":58,"commit_id":"54386bba71fa17b57d328b3863b30a931f96f757","original_commit_id":"34602fb2b8266047ac3d03b674724cfef86b3e61","user":{"login":"pacproduct","id":2098407,"avatar_url":"https://avatars.githubusercontent.com/u/2098407?v=3","gravatar_id":"","url":"https://api.github.com/users/pacproduct","html_url":"https://github.com/pacproduct","followers_url":"https://api.github.com/users/pacproduct/followers","following_url":"https://api.github.com/users/pacproduct/following{/other_user}","gists_url":"https://api.github.com/users/pacproduct/gists{/gist_id}","starred_url":"https://api.github.com/users/pacproduct/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pacproduct/subscriptions","organizations_url":"https://api.github.com/users/pacproduct/orgs","repos_url":"https://api.github.com/users/pacproduct/repos","events_url":"https://api.github.com/users/pacproduct/events{/privacy}","received_events_url":"https://api.github.com/users/pacproduct/received_events","type":"User","site_admin":false},"body":"As long as all functions dealing with permission make sure they separate permission with \", \" (one coma and one space), everything should work just fine.\r\n\r\nThe drupal core function user_admin_perm_submit(...) uses \", \" as a delimiter.\r\nHence, I thought it was fine and safe to do the same. What do you think?","created_at":"2014-12-11T16:44:20Z","updated_at":"2014-12-11T16:44:20Z","html_url":"https://github.com/vijaycs85/export_roles_permissions/pull/1#discussion_r21689090","pull_request_url":"https://api.github.com/repos/vijaycs85/export_roles_permissions/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/vijaycs85/export_roles_permissions/pulls/comments/21689090"},"html":{"href":"https://github.com/vijaycs85/export_roles_permissions/pull/1#discussion_r21689090"},"pull_request":{"href":"https://api.github.com/repos/vijaycs85/export_roles_permissions/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/vijaycs85/export_roles_permissions/pulls/1","id":25901189,"html_url":"https://github.com/vijaycs85/export_roles_permissions/pull/1","diff_url":"https://github.com/vijaycs85/export_roles_permissions/pull/1.diff","patch_url":"https://github.com/vijaycs85/export_roles_permissions/pull/1.patch","issue_url":"https://api.github.com/repos/vijaycs85/export_roles_permissions/issues/1","number":1,"state":"open","locked":false,"title":"Code review","user":{"login":"pacproduct","id":2098407,"avatar_url":"https://avatars.githubusercontent.com/u/2098407?v=3","gravatar_id":"","url":"https://api.github.com/users/pacproduct","html_url":"https://github.com/pacproduct","followers_url":"https://api.github.com/users/pacproduct/followers","following_url":"https://api.github.com/users/pacproduct/following{/other_user}","gists_url":"https://api.github.com/users/pacproduct/gists{/gist_id}","starred_url":"https://api.github.com/users/pacproduct/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pacproduct/subscriptions","organizations_url":"https://api.github.com/users/pacproduct/orgs","repos_url":"https://api.github.com/users/pacproduct/repos","events_url":"https://api.github.com/users/pacproduct/events{/privacy}","received_events_url":"https://api.github.com/users/pacproduct/received_events","type":"User","site_admin":false},"body":"Code review + one fix in the export_roles_permissions_grant_permissions(...) function.\r\nWe still need to make sure that the exported code creates missing roles if any (see TODO in the code).","created_at":"2014-12-11T13:59:26Z","updated_at":"2014-12-11T16:44:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d6fae6001c6df4529df6c32bff48b06f044504a8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/vijaycs85/export_roles_permissions/pulls/1/commits","review_comments_url":"https://api.github.com/repos/vijaycs85/export_roles_permissions/pulls/1/comments","review_comment_url":"https://api.github.com/repos/vijaycs85/export_roles_permissions/pulls/comments/{number}","comments_url":"https://api.github.com/repos/vijaycs85/export_roles_permissions/issues/1/comments","statuses_url":"https://api.github.com/repos/vijaycs85/export_roles_permissions/statuses/54386bba71fa17b57d328b3863b30a931f96f757","head":{"label":"pacproduct:6.x-1.x","ref":"6.x-1.x","sha":"54386bba71fa17b57d328b3863b30a931f96f757","user":{"login":"pacproduct","id":2098407,"avatar_url":"https://avatars.githubusercontent.com/u/2098407?v=3","gravatar_id":"","url":"https://api.github.com/users/pacproduct","html_url":"https://github.com/pacproduct","followers_url":"https://api.github.com/users/pacproduct/followers","following_url":"https://api.github.com/users/pacproduct/following{/other_user}","gists_url":"https://api.github.com/users/pacproduct/gists{/gist_id}","starred_url":"https://api.github.com/users/pacproduct/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pacproduct/subscriptions","organizations_url":"https://api.github.com/users/pacproduct/orgs","repos_url":"https://api.github.com/users/pacproduct/repos","events_url":"https://api.github.com/users/pacproduct/events{/privacy}","received_events_url":"https://api.github.com/users/pacproduct/received_events","type":"User","site_admin":false},"repo":{"id":27863899,"name":"export_roles_permissions","full_name":"pacproduct/export_roles_permissions","owner":{"login":"pacproduct","id":2098407,"avatar_url":"https://avatars.githubusercontent.com/u/2098407?v=3","gravatar_id":"","url":"https://api.github.com/users/pacproduct","html_url":"https://github.com/pacproduct","followers_url":"https://api.github.com/users/pacproduct/followers","following_url":"https://api.github.com/users/pacproduct/following{/other_user}","gists_url":"https://api.github.com/users/pacproduct/gists{/gist_id}","starred_url":"https://api.github.com/users/pacproduct/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pacproduct/subscriptions","organizations_url":"https://api.github.com/users/pacproduct/orgs","repos_url":"https://api.github.com/users/pacproduct/repos","events_url":"https://api.github.com/users/pacproduct/events{/privacy}","received_events_url":"https://api.github.com/users/pacproduct/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pacproduct/export_roles_permissions","description":"Drupal 6 version of Export Roles & Permissions module","fork":true,"url":"https://api.github.com/repos/pacproduct/export_roles_permissions","forks_url":"https://api.github.com/repos/pacproduct/export_roles_permissions/forks","keys_url":"https://api.github.com/repos/pacproduct/export_roles_permissions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pacproduct/export_roles_permissions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pacproduct/export_roles_permissions/teams","hooks_url":"https://api.github.com/repos/pacproduct/export_roles_permissions/hooks","issue_events_url":"https://api.github.com/repos/pacproduct/export_roles_permissions/issues/events{/number}","events_url":"https://api.github.com/repos/pacproduct/export_roles_permissions/events","assignees_url":"https://api.github.com/repos/pacproduct/export_roles_permissions/assignees{/user}","branches_url":"https://api.github.com/repos/pacproduct/export_roles_permissions/branches{/branch}","tags_url":"https://api.github.com/repos/pacproduct/export_roles_permissions/tags","blobs_url":"https://api.github.com/repos/pacproduct/export_roles_permissions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pacproduct/export_roles_permissions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pacproduct/export_roles_permissions/git/refs{/sha}","trees_url":"https://api.github.com/repos/pacproduct/export_roles_permissions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pacproduct/export_roles_permissions/statuses/{sha}","languages_url":"https://api.github.com/repos/pacproduct/export_roles_permissions/languages","stargazers_url":"https://api.github.com/repos/pacproduct/export_roles_permissions/stargazers","contributors_url":"https://api.github.com/repos/pacproduct/export_roles_permissions/contributors","subscribers_url":"https://api.github.com/repos/pacproduct/export_roles_permissions/subscribers","subscription_url":"https://api.github.com/repos/pacproduct/export_roles_permissions/subscription","commits_url":"https://api.github.com/repos/pacproduct/export_roles_permissions/commits{/sha}","git_commits_url":"https://api.github.com/repos/pacproduct/export_roles_permissions/git/commits{/sha}","comments_url":"https://api.github.com/repos/pacproduct/export_roles_permissions/comments{/number}","issue_comment_url":"https://api.github.com/repos/pacproduct/export_roles_permissions/issues/comments/{number}","contents_url":"https://api.github.com/repos/pacproduct/export_roles_permissions/contents/{+path}","compare_url":"https://api.github.com/repos/pacproduct/export_roles_permissions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pacproduct/export_roles_permissions/merges","archive_url":"https://api.github.com/repos/pacproduct/export_roles_permissions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pacproduct/export_roles_permissions/downloads","issues_url":"https://api.github.com/repos/pacproduct/export_roles_permissions/issues{/number}","pulls_url":"https://api.github.com/repos/pacproduct/export_roles_permissions/pulls{/number}","milestones_url":"https://api.github.com/repos/pacproduct/export_roles_permissions/milestones{/number}","notifications_url":"https://api.github.com/repos/pacproduct/export_roles_permissions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pacproduct/export_roles_permissions/labels{/name}","releases_url":"https://api.github.com/repos/pacproduct/export_roles_permissions/releases{/id}","created_at":"2014-12-11T09:34:52Z","updated_at":"2014-12-10T23:54:44Z","pushed_at":"2014-12-11T16:35:28Z","git_url":"git://github.com/pacproduct/export_roles_permissions.git","ssh_url":"git@github.com:pacproduct/export_roles_permissions.git","clone_url":"https://github.com/pacproduct/export_roles_permissions.git","svn_url":"https://github.com/pacproduct/export_roles_permissions","homepage":"https://www.drupal.org/project/export_roles_permissions","size":0,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"6.x-1.x"}},"base":{"label":"vijaycs85:6.x-1.x","ref":"6.x-1.x","sha":"f5e8931777cbc05412a93ac19a86ef396886af0c","user":{"login":"vijaycs85","id":1220029,"avatar_url":"https://avatars.githubusercontent.com/u/1220029?v=3","gravatar_id":"","url":"https://api.github.com/users/vijaycs85","html_url":"https://github.com/vijaycs85","followers_url":"https://api.github.com/users/vijaycs85/followers","following_url":"https://api.github.com/users/vijaycs85/following{/other_user}","gists_url":"https://api.github.com/users/vijaycs85/gists{/gist_id}","starred_url":"https://api.github.com/users/vijaycs85/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vijaycs85/subscriptions","organizations_url":"https://api.github.com/users/vijaycs85/orgs","repos_url":"https://api.github.com/users/vijaycs85/repos","events_url":"https://api.github.com/users/vijaycs85/events{/privacy}","received_events_url":"https://api.github.com/users/vijaycs85/received_events","type":"User","site_admin":false},"repo":{"id":27845552,"name":"export_roles_permissions","full_name":"vijaycs85/export_roles_permissions","owner":{"login":"vijaycs85","id":1220029,"avatar_url":"https://avatars.githubusercontent.com/u/1220029?v=3","gravatar_id":"","url":"https://api.github.com/users/vijaycs85","html_url":"https://github.com/vijaycs85","followers_url":"https://api.github.com/users/vijaycs85/followers","following_url":"https://api.github.com/users/vijaycs85/following{/other_user}","gists_url":"https://api.github.com/users/vijaycs85/gists{/gist_id}","starred_url":"https://api.github.com/users/vijaycs85/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vijaycs85/subscriptions","organizations_url":"https://api.github.com/users/vijaycs85/orgs","repos_url":"https://api.github.com/users/vijaycs85/repos","events_url":"https://api.github.com/users/vijaycs85/events{/privacy}","received_events_url":"https://api.github.com/users/vijaycs85/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vijaycs85/export_roles_permissions","description":"Drupal 6 version of Export Roles & Permissions module","fork":false,"url":"https://api.github.com/repos/vijaycs85/export_roles_permissions","forks_url":"https://api.github.com/repos/vijaycs85/export_roles_permissions/forks","keys_url":"https://api.github.com/repos/vijaycs85/export_roles_permissions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vijaycs85/export_roles_permissions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vijaycs85/export_roles_permissions/teams","hooks_url":"https://api.github.com/repos/vijaycs85/export_roles_permissions/hooks","issue_events_url":"https://api.github.com/repos/vijaycs85/export_roles_permissions/issues/events{/number}","events_url":"https://api.github.com/repos/vijaycs85/export_roles_permissions/events","assignees_url":"https://api.github.com/repos/vijaycs85/export_roles_permissions/assignees{/user}","branches_url":"https://api.github.com/repos/vijaycs85/export_roles_permissions/branches{/branch}","tags_url":"https://api.github.com/repos/vijaycs85/export_roles_permissions/tags","blobs_url":"https://api.github.com/repos/vijaycs85/export_roles_permissions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vijaycs85/export_roles_permissions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vijaycs85/export_roles_permissions/git/refs{/sha}","trees_url":"https://api.github.com/repos/vijaycs85/export_roles_permissions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vijaycs85/export_roles_permissions/statuses/{sha}","languages_url":"https://api.github.com/repos/vijaycs85/export_roles_permissions/languages","stargazers_url":"https://api.github.com/repos/vijaycs85/export_roles_permissions/stargazers","contributors_url":"https://api.github.com/repos/vijaycs85/export_roles_permissions/contributors","subscribers_url":"https://api.github.com/repos/vijaycs85/export_roles_permissions/subscribers","subscription_url":"https://api.github.com/repos/vijaycs85/export_roles_permissions/subscription","commits_url":"https://api.github.com/repos/vijaycs85/export_roles_permissions/commits{/sha}","git_commits_url":"https://api.github.com/repos/vijaycs85/export_roles_permissions/git/commits{/sha}","comments_url":"https://api.github.com/repos/vijaycs85/export_roles_permissions/comments{/number}","issue_comment_url":"https://api.github.com/repos/vijaycs85/export_roles_permissions/issues/comments/{number}","contents_url":"https://api.github.com/repos/vijaycs85/export_roles_permissions/contents/{+path}","compare_url":"https://api.github.com/repos/vijaycs85/export_roles_permissions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vijaycs85/export_roles_permissions/merges","archive_url":"https://api.github.com/repos/vijaycs85/export_roles_permissions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vijaycs85/export_roles_permissions/downloads","issues_url":"https://api.github.com/repos/vijaycs85/export_roles_permissions/issues{/number}","pulls_url":"https://api.github.com/repos/vijaycs85/export_roles_permissions/pulls{/number}","milestones_url":"https://api.github.com/repos/vijaycs85/export_roles_permissions/milestones{/number}","notifications_url":"https://api.github.com/repos/vijaycs85/export_roles_permissions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vijaycs85/export_roles_permissions/labels{/name}","releases_url":"https://api.github.com/repos/vijaycs85/export_roles_permissions/releases{/id}","created_at":"2014-12-10T23:53:00Z","updated_at":"2014-12-10T23:54:44Z","pushed_at":"2014-12-10T23:54:22Z","git_url":"git://github.com/vijaycs85/export_roles_permissions.git","ssh_url":"git@github.com:vijaycs85/export_roles_permissions.git","clone_url":"https://github.com/vijaycs85/export_roles_permissions.git","svn_url":"https://github.com/vijaycs85/export_roles_permissions","homepage":"https://www.drupal.org/project/export_roles_permissions","size":0,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"6.x-1.x"}},"_links":{"self":{"href":"https://api.github.com/repos/vijaycs85/export_roles_permissions/pulls/1"},"html":{"href":"https://github.com/vijaycs85/export_roles_permissions/pull/1"},"issue":{"href":"https://api.github.com/repos/vijaycs85/export_roles_permissions/issues/1"},"comments":{"href":"https://api.github.com/repos/vijaycs85/export_roles_permissions/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/vijaycs85/export_roles_permissions/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/vijaycs85/export_roles_permissions/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/vijaycs85/export_roles_permissions/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/vijaycs85/export_roles_permissions/statuses/54386bba71fa17b57d328b3863b30a931f96f757"}}}}