GitHub PushEvent at 2014-07-16 20:14:52
Repository: hubot-scripts
Actor: Elemecca
Payload: {"shas":[["712a8843a3c68396af3be31975259e71478f423d","f75897670c17327c42ab201733fb8a81ff9f4c34@tremily.us","github-commit-link: Loosen regexp to match 7-through-40-char hashes\n\nInstead of 7-or-40-char hashes (e.g. not 8-character hashes).  The\n{m,n} syntax is part of POSIX's basic regular expressions, although\nPOSIX uses \\{m,n\\} [1].  It looks like CoffeeScript also supports this\nrange syntax [2]:\n\n  | \\.{2,3}           # range or splat\n\nbut I couldn't find a clear regexp specification while skimming the\nCoffeeScript docs.\n\n[1]: http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap09.html#tag_09_03_06\n[2]: http://coffeescript.org/#regexes","W. Trevor King",true],["111a329f72f7ffcf18d42c50633c12e141716daa","f75897670c17327c42ab201733fb8a81ff9f4c34@tremily.us","github-commit-link: Add support for repo@<SHA> and user/repo@<SHA>\n\nBased on similar parsing in github-issue-link.coffee.  The main change\nin the logic is that the initial .* is now the non-greedy .*?, so it\ndoesn't gobble up the repo-part of the regexp [1].  The user/repo\nportion is [^\\s@]+, which matches one or more characters that are\nneither whitespace [2] nor @.\n\nThe non-capturing (?:...) block [3] around the optional repo@ or\nuser/repo@ qualifier allows us to group the qualifier with its @, even\nthough we only need the repo or user/repo (without the @) in our\ninternal logic.\n\nI use CoffeeScript's block regular expressions to comment the regexp\n[4], and CoffeeScript's existential operator '?' to check if\n'msg.match[1]' is defined [5].\n\nI also document the fact that lines matching 'commit/' are ignored.\n\n[1]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Regular_Expressions#special-questionmark\n[2]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Regular_Expressions#special-white-space\n[3]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Regular_Expressions#special-non-capturing-parentheses\n[4]: http://coffeescript.org/#regexes\n[5]: http://coffeescript.org/#operators","W. Trevor King",true],["660ae284d5e98897521334af56c8c016bf92b1f9","f75897670c17327c42ab201733fb8a81ff9f4c34@tremily.us","github-commit-link: Only show the first line of the commit\n\nThis is traditionally the message summary.  From Git's own docs [1]:\n\n> The first line of the commit message should be a short description\n> (50 characters is the soft limit, see DISCUSSION in git-commit(1)),\n> and should skip the full stop.\n\nI sometimes write long, detailed commit messages (like this one), and\nthere's no need to spam the channel with all of this motivational\nbackground.  The summary line should be sufficient context there, and\nfolks looking for more information can follow the URL (which I've\nmoved to it's own line).\n\n[1]: https://github.com/git/git/blob/v1.9.0/Documentation/SubmittingPatches#L89","W. Trevor King",true],["9c30d43808e7b21e77183a44e4f9aaff49e47710","ccec20862cfb34a850cc28223f6bc96a6db3b9e6@gmail.com","Eval script now generates proper script\n\nThe eval script sent the name of the language at the end of the hashbang,\nnot the command as it seems like it should.","Daniel Bruce",true],["d1d33a71eb8a044342e3bd268b8376c611dcc9c4","ccec20862cfb34a850cc28223f6bc96a6db3b9e6@gmail.com","Don't send an array","Daniel Bruce",true],["dfaffea42dfe53dd7790fd879fbdb428b791e9a0","571041f3d6386ca706c7f4a8d79deab9065b7d85@lgh-alumni.de","Deprecate tell.coffee -- it is a package of its own now\n\nUpgrade instructions at\nhttps://github.com/lorenzhs/hubot-tell/blob/master/UPGRADING.md","Lorenz Hübschle-Schneider",true],["4a09e113231dc8810f625890fc3030e6d5c0f851","f75897670c17327c42ab201733fb8a81ff9f4c34@tremily.us","github-commits: Don't parse req.body (it's already an object)\n\nAvoid:\n\n  github-commits error: SyntaxError: Unexpected token u. Payload: undefined\n\nbecause req.body is already parsed by the time github-commits sees it.\nThe original github-commits code was added in 6e7ce2a (notify in chat\nwhen a new commit is pushed, 2012-08-15), but Hubot added the\nbodyParser middleware in 4f4c8c7 (Use bodyParser middleware to parse\nPOST bodys [sic], 2011-12-24), so I'm not sure how this ever worked.\nFrom the express docs for req.body [1]:\n\n  This property is an object containing the parsed request body. This\n  feature is provided by the bodyParser() middleware, though other\n  body parsing middleware may follow this convention as well. This\n  property defaults to {} when bodyParser() is used.\n\nBesides removing the parsing, I've renamed the generic 'payload' to\nthe more specific 'push' for most of the script body, because\n'req.body' is already a generic identifier, and I want to keep the\nparsed variable isolated from future changes to the calling API.\n\n[1]: http://expressjs.com/3x/api.html#req.body","W. Trevor King",true],["d2c8984e98f539a005e9822746144c38adc18a83","22b49bc1b0e25e9d51a932487c07c25ef0b9103d@yosida95.com","Add spaces before and after the URL.","yosida95",true],["4c08e5565592b3ada06dc077fa8a6fafc3f0fbee","b02b8d23855cdedaedd676a746548ab9cce9f1d8@sonatype.com","Script deprecated. Provide warning and fail fast.","Justin Young",true],["13b949a71dc93783d868ed84b69fe24cc3741f39","5d2835895d12301c4ff3495cbdc756e297e136b6@googlemail.com","Remove the dependency to gitio\n\nI just had a hard time debugging this, with removing that dependency it is way more stable then before.","Ole Michaelis",true],["9738ae41fd3b844e4a9ab9aae2206b323715fe2b","29c0b50b77888be9a7549bf711d43c854539a233@gmail.com","better logging to support custom prefix","Kevin Lanni",true],["cfef3a3b7575983271921b8430b4a90d7b0ce238","29c0b50b77888be9a7549bf711d43c854539a233@gmail.com","better English","Kevin Lanni",true],["0e5134b9dc2d668d6e96bb23a5fb8967816ecb73","97fbb39d6669474add792dd85ed0b7a394a6ab1b@pfizer.com","Added South Park Bank Teller and Morpheus What if I Told You.","Eric Silva",true],["3acc987d56f9d88fa9d6c0ad884a31627ba9b206","364ad8b22fb863212a7fd29c319b61686bf41fbe@whitehatsec.com","Fix error in github-pull-request-notifier when body is empty.\n\nWhen someone submits a pull request without a message the JSON\ndocument contains `null` for `body`. The notifier script was\ntrying to call `match` on `body` to extract the list of user\nmentions. That would fail when it was `null`, resulting in:\n\n    Whoa, I got an error: TypeError: Cannot call method 'match' of null\n\nThis changes it to use the existential access operator, so\nwhen body is `null` the mention list is `undefined`.","Sam Hanes",true],["fa6c27b82324fbab3cd48616b17bf84bf7a31b9d","aaf4c61ddcc5e8a2dabede0f3b482cd9aea9434d@jamesfleeting.com","Removed 404 images and added replacements to beerme.","James Fleeting",true],["33461070bddf1d894dade1c239e8ac594af69f29","b02b8d23855cdedaedd676a746548ab9cce9f1d8@sonatype.com","Change description to read beer advocate script is broken rather than deprecated.","Justin Young",true],["655b133505026eb9e90bcea96d08bb8d10c29eff","c028c213ed5efcf30c3f4fc7361dbde0c893c5b7@technicalpickles.com","Merge pull request #1429 from ircubic/eval-use-command\n\nEval script sending wrong query","Josh Nichols",true],["7c4e36f2423eac309d36a9bb1d48c040dd0362e3","5e2f21bfaeb7b46d5d619707de794e069e1e481e@github.com","Version bump to 2.5.14","Josh Nichols",true],["68d4184c279cb298539eb049ed7458684b098e33","c028c213ed5efcf30c3f4fc7361dbde0c893c5b7@technicalpickles.com","Merge pull request #1431 from lorenzhs/deprecate-tell\n\nDeprecate tell.coffee -- it is a package of its own now","Josh Nichols",true],["b25b247aaeca97f7da61ff38eba83d39c26d3a26","c028c213ed5efcf30c3f4fc7361dbde0c893c5b7@technicalpickles.com","Merge pull request #1432 from wking/github-commits-body-json\n\ngithub-commits: Don't parse req.body (it's already an object)","Josh Nichols",true]],"size":90,"ref":"refs/heads/master","head":"e70b8470b54653e0fc9f3db12db43f19082d1ab8"}