GitHub PullRequestReviewCommentEvent at 2014-10-22 17:42:25
Repository: eidolon
Actor: 1aurabrown
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/artsy/eidolon/pulls/comments/19230517","id":19230517,"diff_hunk":"@@ -9,7 +9,7 @@ inhibit_all_warnings!\n # Artsy stuff\n pod 'Artsy+UIColors'\n pod 'Artsy+UILabels'\n-pod 'Artsy-UIButtons', :git => 'https://github.com/artsy/Artsy-UIButtons.git', :commit => 'a28bc016f25fc184da4dad49d11c7774afda85ce'\n+pod 'Artsy-UIButtons'","path":"Podfile","position":5,"original_position":5,"commit_id":"7b982bdeccb6aee7f66c5479e3beabe5b51eae22","original_commit_id":"7b982bdeccb6aee7f66c5479e3beabe5b51eae22","user":{"login":"1aurabrown","id":3171662,"avatar_url":"https://avatars.githubusercontent.com/u/3171662?v=2","gravatar_id":"","url":"https://api.github.com/users/1aurabrown","html_url":"https://github.com/1aurabrown","followers_url":"https://api.github.com/users/1aurabrown/followers","following_url":"https://api.github.com/users/1aurabrown/following{/other_user}","gists_url":"https://api.github.com/users/1aurabrown/gists{/gist_id}","starred_url":"https://api.github.com/users/1aurabrown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/1aurabrown/subscriptions","organizations_url":"https://api.github.com/users/1aurabrown/orgs","repos_url":"https://api.github.com/users/1aurabrown/repos","events_url":"https://api.github.com/users/1aurabrown/events{/privacy}","received_events_url":"https://api.github.com/users/1aurabrown/received_events","type":"User","site_admin":false},"body":"i released a new version","created_at":"2014-10-22T17:42:25Z","updated_at":"2014-10-22T17:42:25Z","html_url":"https://github.com/artsy/eidolon/pull/226#discussion_r19230517","pull_request_url":"https://api.github.com/repos/artsy/eidolon/pulls/226","_links":{"self":{"href":"https://api.github.com/repos/artsy/eidolon/pulls/comments/19230517"},"html":{"href":"https://github.com/artsy/eidolon/pull/226#discussion_r19230517"},"pull_request":{"href":"https://api.github.com/repos/artsy/eidolon/pulls/226"}}},"pull_request":{"url":"https://api.github.com/repos/artsy/eidolon/pulls/226","id":23175014,"html_url":"https://github.com/artsy/eidolon/pull/226","diff_url":"https://github.com/artsy/eidolon/pull/226.diff","patch_url":"https://github.com/artsy/eidolon/pull/226.patch","issue_url":"https://api.github.com/repos/artsy/eidolon/issues/226","number":226,"state":"open","locked":false,"title":"@ashfurrow => clean up divider lines in collection views","user":{"login":"1aurabrown","id":3171662,"avatar_url":"https://avatars.githubusercontent.com/u/3171662?v=2","gravatar_id":"","url":"https://api.github.com/users/1aurabrown","html_url":"https://github.com/1aurabrown","followers_url":"https://api.github.com/users/1aurabrown/followers","following_url":"https://api.github.com/users/1aurabrown/following{/other_user}","gists_url":"https://api.github.com/users/1aurabrown/gists{/gist_id}","starred_url":"https://api.github.com/users/1aurabrown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/1aurabrown/subscriptions","organizations_url":"https://api.github.com/users/1aurabrown/orgs","repos_url":"https://api.github.com/users/1aurabrown/repos","events_url":"https://api.github.com/users/1aurabrown/events{/privacy}","received_events_url":"https://api.github.com/users/1aurabrown/received_events","type":"User","site_admin":false},"body":"Instead of using a 1-px view for our dotted and solid borders/dividers, let's just use the ARDrawing methods we have in the UILabels pod to draw a border layer on whatever view requires a border.\r\n\r\nWe were sort of doing this in the place where we were supposed to be using a dotted border, but we were basically adding a dotted border to a 1px UIView that was already serving as a solid border. This gets rid of all those single pixel divider views.\r\n\r\nThe table views looks the same as before with this change:\r\n![screen shot 2014-10-22 at 1 31 35 pm](https://cloud.githubusercontent.com/assets/3171662/4740913/afc431ea-5a11-11e4-9bef-9266a28b68c6.png)\r\n\r\nAnd the dotted divider actually looks right now:\r\n![screen shot 2014-10-22 at 1 31 47 pm](https://cloud.githubusercontent.com/assets/3171662/4740920/c66d7ffa-5a11-11e4-9958-f089227a1bfb.png)\r\n","created_at":"2014-10-22T17:35:14Z","updated_at":"2014-10-22T17:42:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"355c1d324e47e71b8afa85127eecf420e143151a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/artsy/eidolon/pulls/226/commits","review_comments_url":"https://api.github.com/repos/artsy/eidolon/pulls/226/comments","review_comment_url":"https://api.github.com/repos/artsy/eidolon/pulls/comments/{number}","comments_url":"https://api.github.com/repos/artsy/eidolon/issues/226/comments","statuses_url":"https://api.github.com/repos/artsy/eidolon/statuses/7b982bdeccb6aee7f66c5479e3beabe5b51eae22","head":{"label":"1aurabrown:master","ref":"master","sha":"7b982bdeccb6aee7f66c5479e3beabe5b51eae22","user":{"login":"1aurabrown","id":3171662,"avatar_url":"https://avatars.githubusercontent.com/u/3171662?v=2","gravatar_id":"","url":"https://api.github.com/users/1aurabrown","html_url":"https://github.com/1aurabrown","followers_url":"https://api.github.com/users/1aurabrown/followers","following_url":"https://api.github.com/users/1aurabrown/following{/other_user}","gists_url":"https://api.github.com/users/1aurabrown/gists{/gist_id}","starred_url":"https://api.github.com/users/1aurabrown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/1aurabrown/subscriptions","organizations_url":"https://api.github.com/users/1aurabrown/orgs","repos_url":"https://api.github.com/users/1aurabrown/repos","events_url":"https://api.github.com/users/1aurabrown/events{/privacy}","received_events_url":"https://api.github.com/users/1aurabrown/received_events","type":"User","site_admin":false},"repo":{"id":24426445,"name":"eidolon","full_name":"1aurabrown/eidolon","owner":{"login":"1aurabrown","id":3171662,"avatar_url":"https://avatars.githubusercontent.com/u/3171662?v=2","gravatar_id":"","url":"https://api.github.com/users/1aurabrown","html_url":"https://github.com/1aurabrown","followers_url":"https://api.github.com/users/1aurabrown/followers","following_url":"https://api.github.com/users/1aurabrown/following{/other_user}","gists_url":"https://api.github.com/users/1aurabrown/gists{/gist_id}","starred_url":"https://api.github.com/users/1aurabrown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/1aurabrown/subscriptions","organizations_url":"https://api.github.com/users/1aurabrown/orgs","repos_url":"https://api.github.com/users/1aurabrown/repos","events_url":"https://api.github.com/users/1aurabrown/events{/privacy}","received_events_url":"https://api.github.com/users/1aurabrown/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/1aurabrown/eidolon","description":"The Artsy Auction Kiosk App","fork":true,"url":"https://api.github.com/repos/1aurabrown/eidolon","forks_url":"https://api.github.com/repos/1aurabrown/eidolon/forks","keys_url":"https://api.github.com/repos/1aurabrown/eidolon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/1aurabrown/eidolon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/1aurabrown/eidolon/teams","hooks_url":"https://api.github.com/repos/1aurabrown/eidolon/hooks","issue_events_url":"https://api.github.com/repos/1aurabrown/eidolon/issues/events{/number}","events_url":"https://api.github.com/repos/1aurabrown/eidolon/events","assignees_url":"https://api.github.com/repos/1aurabrown/eidolon/assignees{/user}","branches_url":"https://api.github.com/repos/1aurabrown/eidolon/branches{/branch}","tags_url":"https://api.github.com/repos/1aurabrown/eidolon/tags","blobs_url":"https://api.github.com/repos/1aurabrown/eidolon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/1aurabrown/eidolon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/1aurabrown/eidolon/git/refs{/sha}","trees_url":"https://api.github.com/repos/1aurabrown/eidolon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/1aurabrown/eidolon/statuses/{sha}","languages_url":"https://api.github.com/repos/1aurabrown/eidolon/languages","stargazers_url":"https://api.github.com/repos/1aurabrown/eidolon/stargazers","contributors_url":"https://api.github.com/repos/1aurabrown/eidolon/contributors","subscribers_url":"https://api.github.com/repos/1aurabrown/eidolon/subscribers","subscription_url":"https://api.github.com/repos/1aurabrown/eidolon/subscription","commits_url":"https://api.github.com/repos/1aurabrown/eidolon/commits{/sha}","git_commits_url":"https://api.github.com/repos/1aurabrown/eidolon/git/commits{/sha}","comments_url":"https://api.github.com/repos/1aurabrown/eidolon/comments{/number}","issue_comment_url":"https://api.github.com/repos/1aurabrown/eidolon/issues/comments/{number}","contents_url":"https://api.github.com/repos/1aurabrown/eidolon/contents/{+path}","compare_url":"https://api.github.com/repos/1aurabrown/eidolon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/1aurabrown/eidolon/merges","archive_url":"https://api.github.com/repos/1aurabrown/eidolon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/1aurabrown/eidolon/downloads","issues_url":"https://api.github.com/repos/1aurabrown/eidolon/issues{/number}","pulls_url":"https://api.github.com/repos/1aurabrown/eidolon/pulls{/number}","milestones_url":"https://api.github.com/repos/1aurabrown/eidolon/milestones{/number}","notifications_url":"https://api.github.com/repos/1aurabrown/eidolon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/1aurabrown/eidolon/labels{/name}","releases_url":"https://api.github.com/repos/1aurabrown/eidolon/releases{/id}","created_at":"2014-09-24T18:03:30Z","updated_at":"2014-09-30T15:31:39Z","pushed_at":"2014-10-22T17:40:20Z","git_url":"git://github.com/1aurabrown/eidolon.git","ssh_url":"git@github.com:1aurabrown/eidolon.git","clone_url":"https://github.com/1aurabrown/eidolon.git","svn_url":"https://github.com/1aurabrown/eidolon","homepage":null,"size":33348,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"artsy:master","ref":"master","sha":"13e540ffcd0483652e1f9bd807c808da3134e664","user":{"login":"artsy","id":546231,"avatar_url":"https://avatars.githubusercontent.com/u/546231?v=2","gravatar_id":"","url":"https://api.github.com/users/artsy","html_url":"https://github.com/artsy","followers_url":"https://api.github.com/users/artsy/followers","following_url":"https://api.github.com/users/artsy/following{/other_user}","gists_url":"https://api.github.com/users/artsy/gists{/gist_id}","starred_url":"https://api.github.com/users/artsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artsy/subscriptions","organizations_url":"https://api.github.com/users/artsy/orgs","repos_url":"https://api.github.com/users/artsy/repos","events_url":"https://api.github.com/users/artsy/events{/privacy}","received_events_url":"https://api.github.com/users/artsy/received_events","type":"Organization","site_admin":false},"repo":{"id":22613546,"name":"eidolon","full_name":"artsy/eidolon","owner":{"login":"artsy","id":546231,"avatar_url":"https://avatars.githubusercontent.com/u/546231?v=2","gravatar_id":"","url":"https://api.github.com/users/artsy","html_url":"https://github.com/artsy","followers_url":"https://api.github.com/users/artsy/followers","following_url":"https://api.github.com/users/artsy/following{/other_user}","gists_url":"https://api.github.com/users/artsy/gists{/gist_id}","starred_url":"https://api.github.com/users/artsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artsy/subscriptions","organizations_url":"https://api.github.com/users/artsy/orgs","repos_url":"https://api.github.com/users/artsy/repos","events_url":"https://api.github.com/users/artsy/events{/privacy}","received_events_url":"https://api.github.com/users/artsy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/artsy/eidolon","description":"The Artsy Auction Kiosk App","fork":false,"url":"https://api.github.com/repos/artsy/eidolon","forks_url":"https://api.github.com/repos/artsy/eidolon/forks","keys_url":"https://api.github.com/repos/artsy/eidolon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/artsy/eidolon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/artsy/eidolon/teams","hooks_url":"https://api.github.com/repos/artsy/eidolon/hooks","issue_events_url":"https://api.github.com/repos/artsy/eidolon/issues/events{/number}","events_url":"https://api.github.com/repos/artsy/eidolon/events","assignees_url":"https://api.github.com/repos/artsy/eidolon/assignees{/user}","branches_url":"https://api.github.com/repos/artsy/eidolon/branches{/branch}","tags_url":"https://api.github.com/repos/artsy/eidolon/tags","blobs_url":"https://api.github.com/repos/artsy/eidolon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/artsy/eidolon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/artsy/eidolon/git/refs{/sha}","trees_url":"https://api.github.com/repos/artsy/eidolon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/artsy/eidolon/statuses/{sha}","languages_url":"https://api.github.com/repos/artsy/eidolon/languages","stargazers_url":"https://api.github.com/repos/artsy/eidolon/stargazers","contributors_url":"https://api.github.com/repos/artsy/eidolon/contributors","subscribers_url":"https://api.github.com/repos/artsy/eidolon/subscribers","subscription_url":"https://api.github.com/repos/artsy/eidolon/subscription","commits_url":"https://api.github.com/repos/artsy/eidolon/commits{/sha}","git_commits_url":"https://api.github.com/repos/artsy/eidolon/git/commits{/sha}","comments_url":"https://api.github.com/repos/artsy/eidolon/comments{/number}","issue_comment_url":"https://api.github.com/repos/artsy/eidolon/issues/comments/{number}","contents_url":"https://api.github.com/repos/artsy/eidolon/contents/{+path}","compare_url":"https://api.github.com/repos/artsy/eidolon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/artsy/eidolon/merges","archive_url":"https://api.github.com/repos/artsy/eidolon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/artsy/eidolon/downloads","issues_url":"https://api.github.com/repos/artsy/eidolon/issues{/number}","pulls_url":"https://api.github.com/repos/artsy/eidolon/pulls{/number}","milestones_url":"https://api.github.com/repos/artsy/eidolon/milestones{/number}","notifications_url":"https://api.github.com/repos/artsy/eidolon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/artsy/eidolon/labels{/name}","releases_url":"https://api.github.com/repos/artsy/eidolon/releases{/id}","created_at":"2014-08-04T17:38:26Z","updated_at":"2014-10-22T05:33:04Z","pushed_at":"2014-10-22T14:28:25Z","git_url":"git://github.com/artsy/eidolon.git","ssh_url":"git@github.com:artsy/eidolon.git","clone_url":"https://github.com/artsy/eidolon.git","svn_url":"https://github.com/artsy/eidolon","homepage":null,"size":34948,"stargazers_count":89,"watchers_count":89,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":20,"forks":4,"open_issues":20,"watchers":89,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/artsy/eidolon/pulls/226"},"html":{"href":"https://github.com/artsy/eidolon/pull/226"},"issue":{"href":"https://api.github.com/repos/artsy/eidolon/issues/226"},"comments":{"href":"https://api.github.com/repos/artsy/eidolon/issues/226/comments"},"review_comments":{"href":"https://api.github.com/repos/artsy/eidolon/pulls/226/comments"},"review_comment":{"href":"https://api.github.com/repos/artsy/eidolon/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/artsy/eidolon/pulls/226/commits"},"statuses":{"href":"https://api.github.com/repos/artsy/eidolon/statuses/7b982bdeccb6aee7f66c5479e3beabe5b51eae22"}}}}