GitHub PullRequestReviewCommentEvent at 2014-03-13 21:54:32
Repository: foreman
Actor: abenari
Payload: {"comment":{"url":"https://api.github.com/repos/theforeman/foreman/pulls/comments/10588351","id":10588351,"diff_hunk":"@@ -1,7 +1,13 @@\n-<% javascript 'jquery.multi-select' %>\n+<% javascript 'taxonomy_edit' %>\n+\n <%= form_for taxonomy do |f| %>\n   <%= base_errors_for taxonomy %>\n-  <%= select_f f, :parent_id, taxonomy.class.order(:title), :id, :title, { :include_blank => true }, { :label => _('Parent'), :disabled => true } %>\n+  <%= select_f f, :parent_id, taxonomy.class.order(:title), :id, :title, { :include_blank => true },","path":"app/views/taxonomies/_form.html.erb","position":7,"original_position":7,"commit_id":"41b171082def50256edcca141b5bdf24ff9fc8d3","original_commit_id":"40cce7d3ceee0301766117afc8845c9f92b2d22f","user":{"login":"abenari","id":608711,"avatar_url":"https://gravatar.com/avatar/60379725ee75e02e465638407bc8bec2?d=https%3A%2F%2Fidenticons.github.com%2Fd73a9f1c36e51555fb2b1eb275a38720.png&r=x","gravatar_id":"60379725ee75e02e465638407bc8bec2","url":"https://api.github.com/users/abenari","html_url":"https://github.com/abenari","followers_url":"https://api.github.com/users/abenari/followers","following_url":"https://api.github.com/users/abenari/following{/other_user}","gists_url":"https://api.github.com/users/abenari/gists{/gist_id}","starred_url":"https://api.github.com/users/abenari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abenari/subscriptions","organizations_url":"https://api.github.com/users/abenari/orgs","repos_url":"https://api.github.com/users/abenari/repos","events_url":"https://api.github.com/users/abenari/events{/privacy}","received_events_url":"https://api.github.com/users/abenari/received_events","type":"User","site_admin":false},"body":"Exactly, If you have A>B>C and you are editing A you can't change the parent to be A (can't be parent of self) nor B or C(can't have parent that is your own descendant)  the ancestry gem will not allow that. So validation wize the code is already working well.\r\nMy comment is that we should remove the options that can't be selected from the options list.","created_at":"2014-03-13T21:54:32Z","updated_at":"2014-03-13T21:54:32Z","html_url":"https://github.com/theforeman/foreman/pull/1282#discussion_r10588351","pull_request_url":"https://api.github.com/repos/theforeman/foreman/pulls/1282","_links":{"self":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/comments/10588351"},"html":{"href":"https://github.com/theforeman/foreman/pull/1282#discussion_r10588351"},"pull_request":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/1282"}}}}