GitHub PullRequestReviewCommentEvent at 2014-11-11 00:56:49
Repository: marionette-js-runner
Actor: lightsofapollo
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/mozilla-b2g/marionette-js-runner/pulls/comments/20125927","id":20125927,"diff_hunk":"@@ -0,0 +1,28 @@\n+#! /usr/bin/env node\n+\n+var applyManifest = require('../lib/applymanifest');\n+var requireResolve = require('../lib/require_resolve');\n+\n+var ArgumentParser = require('argparse').ArgumentParser;\n+\n+var parser = new ArgumentParser({\n+  version: require('../package').version,\n+  description: 'Apply whitelist/blacklist manifests to test files',\n+  addHelp: true,\n+});\n+\n+parser.addArgument(['manifest'], {\n+  type: requireResolve,\n+  help: 'Manifest file to use to filter given files'\n+});\n+\n+parser.addArgument(['files'], {\n+  nargs: '*',\n+  type: 'string'\n+});\n+\n+var args = parser.parseArgs();\n+\n+process.stdout.write(","path":"bin/apply-manifest","position":26,"original_position":26,"commit_id":"791bb6663e2c0a695df63f66fd350b1478dbccee","original_commit_id":"791bb6663e2c0a695df63f66fd350b1478dbccee","user":{"login":"lightsofapollo","id":322957,"avatar_url":"https://avatars.githubusercontent.com/u/322957?v=3","gravatar_id":"","url":"https://api.github.com/users/lightsofapollo","html_url":"https://github.com/lightsofapollo","followers_url":"https://api.github.com/users/lightsofapollo/followers","following_url":"https://api.github.com/users/lightsofapollo/following{/other_user}","gists_url":"https://api.github.com/users/lightsofapollo/gists{/gist_id}","starred_url":"https://api.github.com/users/lightsofapollo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lightsofapollo/subscriptions","organizations_url":"https://api.github.com/users/lightsofapollo/orgs","repos_url":"https://api.github.com/users/lightsofapollo/repos","events_url":"https://api.github.com/users/lightsofapollo/events{/privacy}","received_events_url":"https://api.github.com/users/lightsofapollo/received_events","type":"User","site_admin":false},"body":"I will make this work in gaia via something like <marionette js> $(apply-manifest $MANIFEST | files)","created_at":"2014-11-11T00:56:49Z","updated_at":"2014-11-11T00:56:49Z","html_url":"https://github.com/mozilla-b2g/marionette-js-runner/pull/46#discussion_r20125927","pull_request_url":"https://api.github.com/repos/mozilla-b2g/marionette-js-runner/pulls/46","_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/marionette-js-runner/pulls/comments/20125927"},"html":{"href":"https://github.com/mozilla-b2g/marionette-js-runner/pull/46#discussion_r20125927"},"pull_request":{"href":"https://api.github.com/repos/mozilla-b2g/marionette-js-runner/pulls/46"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla-b2g/marionette-js-runner/pulls/46","id":24109849,"html_url":"https://github.com/mozilla-b2g/marionette-js-runner/pull/46","diff_url":"https://github.com/mozilla-b2g/marionette-js-runner/pull/46.diff","patch_url":"https://github.com/mozilla-b2g/marionette-js-runner/pull/46.patch","issue_url":"https://api.github.com/repos/mozilla-b2g/marionette-js-runner/issues/46","number":46,"state":"open","locked":false,"title":"Bug 1084006 - Allow hosts to specify their own CLI arguments","user":{"login":"lightsofapollo","id":322957,"avatar_url":"https://avatars.githubusercontent.com/u/322957?v=3","gravatar_id":"","url":"https://api.github.com/users/lightsofapollo","html_url":"https://github.com/lightsofapollo","followers_url":"https://api.github.com/users/lightsofapollo/followers","following_url":"https://api.github.com/users/lightsofapollo/following{/other_user}","gists_url":"https://api.github.com/users/lightsofapollo/gists{/gist_id}","starred_url":"https://api.github.com/users/lightsofapollo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lightsofapollo/subscriptions","organizations_url":"https://api.github.com/users/lightsofapollo/orgs","repos_url":"https://api.github.com/users/lightsofapollo/repos","events_url":"https://api.github.com/users/lightsofapollo/events{/privacy}","received_events_url":"https://api.github.com/users/lightsofapollo/received_events","type":"User","site_admin":false},"body":"This is the first step in a pretty major overhaul of how hosts work this does away with all the terrible hacks we added so far to do exactly this. This also aims at removing the need for ./bin/gaia-marionette. The manifest functionality has been moved into its own binary (and can be used via some shell subs).","created_at":"2014-11-09T03:44:46Z","updated_at":"2014-11-11T00:56:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"474feae0d9e13d110ed578ed0a351556c7bb7355","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-b2g/marionette-js-runner/pulls/46/commits","review_comments_url":"https://api.github.com/repos/mozilla-b2g/marionette-js-runner/pulls/46/comments","review_comment_url":"https://api.github.com/repos/mozilla-b2g/marionette-js-runner/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mozilla-b2g/marionette-js-runner/issues/46/comments","statuses_url":"https://api.github.com/repos/mozilla-b2g/marionette-js-runner/statuses/791bb6663e2c0a695df63f66fd350b1478dbccee","head":{"label":"mozilla-b2g:extensible-hosts","ref":"extensible-hosts","sha":"791bb6663e2c0a695df63f66fd350b1478dbccee","user":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"repo":{"id":11259691,"name":"marionette-js-runner","full_name":"mozilla-b2g/marionette-js-runner","owner":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-b2g/marionette-js-runner","description":"High level test framework and runner for marionette js client","fork":false,"url":"https://api.github.com/repos/mozilla-b2g/marionette-js-runner","forks_url":"https://api.github.com/repos/mozilla-b2g/marionette-js-runner/forks","keys_url":"https://api.github.com/repos/mozilla-b2g/marionette-js-runner/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-b2g/marionette-js-runner/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-b2g/marionette-js-runner/teams","hooks_url":"https://api.github.com/repos/mozilla-b2g/marionette-js-runner/hooks","issue_events_url":"https://api.github.com/repos/mozilla-b2g/marionette-js-runner/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-b2g/marionette-js-runner/events","assignees_url":"https://api.github.com/repos/mozilla-b2g/marionette-js-runner/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-b2g/marionette-js-runner/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-b2g/marionette-js-runner/tags","blobs_url":"https://api.github.com/repos/mozilla-b2g/marionette-js-runner/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-b2g/marionette-js-runner/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-b2g/marionette-js-runner/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-b2g/marionette-js-runner/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-b2g/marionette-js-runner/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-b2g/marionette-js-runner/languages","stargazers_url":"https://api.github.com/repos/mozilla-b2g/marionette-js-runner/stargazers","contributors_url":"https://api.github.com/repos/mozilla-b2g/marionette-js-runner/contributors","subscribers_url":"https://api.github.com/repos/mozilla-b2g/marionette-js-runner/subscribers","subscription_url":"https://api.github.com/repos/mozilla-b2g/marionette-js-runner/subscription","commits_url":"https://api.github.com/repos/mozilla-b2g/marionette-js-runner/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-b2g/marionette-js-runner/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-b2g/marionette-js-runner/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-b2g/marionette-js-runner/issues/comments/{number}","contents_url":"https://api.github.com/repos/mozilla-b2g/marionette-js-runner/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-b2g/marionette-js-runner/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-b2g/marionette-js-runner/merges","archive_url":"https://api.github.com/repos/mozilla-b2g/marionette-js-runner/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-b2g/marionette-js-runner/downloads","issues_url":"https://api.github.com/repos/mozilla-b2g/marionette-js-runner/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-b2g/marionette-js-runner/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-b2g/marionette-js-runner/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-b2g/marionette-js-runner/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-b2g/marionette-js-runner/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-b2g/marionette-js-runner/releases{/id}","created_at":"2013-07-08T16:45:43Z","updated_at":"2014-10-08T14:39:20Z","pushed_at":"2014-11-09T06:44:16Z","git_url":"git://github.com/mozilla-b2g/marionette-js-runner.git","ssh_url":"git@github.com:mozilla-b2g/marionette-js-runner.git","clone_url":"https://github.com/mozilla-b2g/marionette-js-runner.git","svn_url":"https://github.com/mozilla-b2g/marionette-js-runner","homepage":null,"size":997,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":4,"forks":19,"open_issues":4,"watchers":5,"default_branch":"master"}},"base":{"label":"mozilla-b2g:master","ref":"master","sha":"dcdbc92baa35f30ae9ff6da5f6ec4a15d2bc5a73","user":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"repo":{"id":11259691,"name":"marionette-js-runner","full_name":"mozilla-b2g/marionette-js-runner","owner":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-b2g/marionette-js-runner","description":"High level test framework and runner for marionette js client","fork":false,"url":"https://api.github.com/repos/mozilla-b2g/marionette-js-runner","forks_url":"https://api.github.com/repos/mozilla-b2g/marionette-js-runner/forks","keys_url":"https://api.github.com/repos/mozilla-b2g/marionette-js-runner/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-b2g/marionette-js-runner/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-b2g/marionette-js-runner/teams","hooks_url":"https://api.github.com/repos/mozilla-b2g/marionette-js-runner/hooks","issue_events_url":"https://api.github.com/repos/mozilla-b2g/marionette-js-runner/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-b2g/marionette-js-runner/events","assignees_url":"https://api.github.com/repos/mozilla-b2g/marionette-js-runner/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-b2g/marionette-js-runner/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-b2g/marionette-js-runner/tags","blobs_url":"https://api.github.com/repos/mozilla-b2g/marionette-js-runner/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-b2g/marionette-js-runner/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-b2g/marionette-js-runner/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-b2g/marionette-js-runner/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-b2g/marionette-js-runner/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-b2g/marionette-js-runner/languages","stargazers_url":"https://api.github.com/repos/mozilla-b2g/marionette-js-runner/stargazers","contributors_url":"https://api.github.com/repos/mozilla-b2g/marionette-js-runner/contributors","subscribers_url":"https://api.github.com/repos/mozilla-b2g/marionette-js-runner/subscribers","subscription_url":"https://api.github.com/repos/mozilla-b2g/marionette-js-runner/subscription","commits_url":"https://api.github.com/repos/mozilla-b2g/marionette-js-runner/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-b2g/marionette-js-runner/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-b2g/marionette-js-runner/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-b2g/marionette-js-runner/issues/comments/{number}","contents_url":"https://api.github.com/repos/mozilla-b2g/marionette-js-runner/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-b2g/marionette-js-runner/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-b2g/marionette-js-runner/merges","archive_url":"https://api.github.com/repos/mozilla-b2g/marionette-js-runner/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-b2g/marionette-js-runner/downloads","issues_url":"https://api.github.com/repos/mozilla-b2g/marionette-js-runner/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-b2g/marionette-js-runner/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-b2g/marionette-js-runner/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-b2g/marionette-js-runner/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-b2g/marionette-js-runner/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-b2g/marionette-js-runner/releases{/id}","created_at":"2013-07-08T16:45:43Z","updated_at":"2014-10-08T14:39:20Z","pushed_at":"2014-11-09T06:44:16Z","git_url":"git://github.com/mozilla-b2g/marionette-js-runner.git","ssh_url":"git@github.com:mozilla-b2g/marionette-js-runner.git","clone_url":"https://github.com/mozilla-b2g/marionette-js-runner.git","svn_url":"https://github.com/mozilla-b2g/marionette-js-runner","homepage":null,"size":997,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":4,"forks":19,"open_issues":4,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/marionette-js-runner/pulls/46"},"html":{"href":"https://github.com/mozilla-b2g/marionette-js-runner/pull/46"},"issue":{"href":"https://api.github.com/repos/mozilla-b2g/marionette-js-runner/issues/46"},"comments":{"href":"https://api.github.com/repos/mozilla-b2g/marionette-js-runner/issues/46/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-b2g/marionette-js-runner/pulls/46/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-b2g/marionette-js-runner/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mozilla-b2g/marionette-js-runner/pulls/46/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-b2g/marionette-js-runner/statuses/791bb6663e2c0a695df63f66fd350b1478dbccee"}}}}