GitHub PullRequestReviewCommentEvent at 2014-02-08 14:47:44
Repository: django
Actor: chrismedrela
Payload: {"comment":{"url":"https://api.github.com/repos/django/django/pulls/comments/9564031","id":9564031,"diff_hunk":"@@ -1160,6 +1164,61 @@ def _check_id_field(cls):\n             return []\n \n     @classmethod\n+    def _check_field_name_clashes(cls):\n+        \"\"\" Ref #17673. \"\"\"\n+\n+        errors = []\n+        used_fields = {} # name or attname -> field\n+\n+        # Check that multi-inheritance doesn't cause field name shadowing.\n+        for parent in cls._meta.parents:\n+            for f in parent._meta.local_fields:\n+                clash = used_fields.get(f.name) or used_fields.get(f.attname) or None","path":"django/db/models/base.py","position":28,"original_position":28,"commit_id":"ebabd9a253e23c8d106e04c9969b990351227354","original_commit_id":"9931ac7ea0c1eed4e293d9fc5a841a2fa23f73d5","user":{"login":"chrismedrela","id":1645996,"avatar_url":"https://gravatar.com/avatar/4c073f8a91288f2893656d36630b375f?d=https%3A%2F%2Fidenticons.github.com%2Fe89afa3f87f53c4176c95a0542f7fcc6.png&r=x","gravatar_id":"4c073f8a91288f2893656d36630b375f","url":"https://api.github.com/users/chrismedrela","html_url":"https://github.com/chrismedrela","followers_url":"https://api.github.com/users/chrismedrela/followers","following_url":"https://api.github.com/users/chrismedrela/following{/other_user}","gists_url":"https://api.github.com/users/chrismedrela/gists{/gist_id}","starred_url":"https://api.github.com/users/chrismedrela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrismedrela/subscriptions","organizations_url":"https://api.github.com/users/chrismedrela/orgs","repos_url":"https://api.github.com/users/chrismedrela/repos","events_url":"https://api.github.com/users/chrismedrela/events{/privacy}","received_events_url":"https://api.github.com/users/chrismedrela/received_events","type":"User","site_admin":false},"body":"OK, I've added a note to release notes. However, I'm not sure if this is what should be documented.","created_at":"2014-02-08T14:47:44Z","updated_at":"2014-02-08T14:47:44Z","html_url":"https://github.com/django/django/pull/2242#discussion_r9564031","pull_request_url":"https://api.github.com/repos/django/django/pulls/2242","_links":{"self":{"href":"https://api.github.com/repos/django/django/pulls/comments/9564031"},"html":{"href":"https://github.com/django/django/pull/2242#discussion_r9564031"},"pull_request":{"href":"https://api.github.com/repos/django/django/pulls/2242"}}}}