GitHub PullRequestReviewCommentEvent at 2014-04-25 00:12:13
Repository: resque-retry
Actor: jzaleski
Payload: {"comment":{"url":"https://api.github.com/repos/lantins/resque-retry/pulls/comments/11978868","id":11978868,"diff_hunk":"@@ -381,9 +403,29 @@ class << self; self end.class_eval{ undef_method(mname) } rescue nil\n       #\n       # @api private\n       def clean_retry_key(*args)\n+        log 'Clearing retry key', args\n         Resque.redis.del(redis_retry_key(*args))\n       end\n \n+      # Log messages through the Resque logger.  Generally not for appication\n+      # logging-just for inner-workings of Resque and plugins.\n+      #\n+      # Requires that RESQUE_RETRY_LOGGING be set to the string \"true\" in the environment.\n+      #\n+      # message:: message to log\n+      # args:: args of the resque job in context\n+      # exception:: the exception that might be causing a retry\n+      #\n+      # @api private\n+      def log(message, args, exception=nil)\n+        # Resque::Worker will handle interpeting LOGGER, VERBOSE, and VVERBOSE\n+        # since everyone is sharing Resque.logger.\n+        if Resque.logger && ENV['RESQUE_RETRY_LOGGING'] == 'true'","path":"lib/resque/plugins/retry.rb","position":139,"original_position":139,"commit_id":"6500cc64922c19dbaba6740ca8633fb44fa67315","original_commit_id":"6500cc64922c19dbaba6740ca8633fb44fa67315","user":{"login":"jzaleski","id":2303800,"avatar_url":"https://avatars.githubusercontent.com/u/2303800?","gravatar_id":"c6766c6b88ae118fd067e6af062be339","url":"https://api.github.com/users/jzaleski","html_url":"https://github.com/jzaleski","followers_url":"https://api.github.com/users/jzaleski/followers","following_url":"https://api.github.com/users/jzaleski/following{/other_user}","gists_url":"https://api.github.com/users/jzaleski/gists{/gist_id}","starred_url":"https://api.github.com/users/jzaleski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jzaleski/subscriptions","organizations_url":"https://api.github.com/users/jzaleski/orgs","repos_url":"https://api.github.com/users/jzaleski/repos","events_url":"https://api.github.com/users/jzaleski/events{/privacy}","received_events_url":"https://api.github.com/users/jzaleski/received_events","type":"User","site_admin":false},"body":"As mentioned below, let's just check if `Resque.logger` exists here (and remove the env-var check entirely -- further details below).","created_at":"2014-04-25T00:12:13Z","updated_at":"2014-04-25T00:12:13Z","html_url":"https://github.com/lantins/resque-retry/pull/99#discussion_r11978868","pull_request_url":"https://api.github.com/repos/lantins/resque-retry/pulls/99","_links":{"self":{"href":"https://api.github.com/repos/lantins/resque-retry/pulls/comments/11978868"},"html":{"href":"https://github.com/lantins/resque-retry/pull/99#discussion_r11978868"},"pull_request":{"href":"https://api.github.com/repos/lantins/resque-retry/pulls/99"}}}}