GitHub PullRequestReviewCommentEvent at 2014-09-26 13:48:25
Repository: gaia
Actor: Rik
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/18089410","id":18089410,"diff_hunk":"@@ -758,16 +763,11 @@ var CallsHandler = (function callsHandler() {\n              (telephony.conferenceGroup.calls.length > 0));\n   }\n \n-  function mergeActiveCallWith(call) {\n-    if (telephony.active == telephony.conferenceGroup) {\n-      telephony.conferenceGroup.add(call);\n-    } else {\n-      telephony.conferenceGroup.add(telephony.active, call);\n+  function mergeCalls() {\n+    if (!telephony.conferenceGroup.calls.length) {\n+      telephony.conferenceGroup.add(telephony.calls[0], telephony.calls[1]);","path":"apps/callscreen/js/calls_handler.js","position":36,"original_position":36,"commit_id":"dda1889350c512c51b1d38d574fab5a1feb8c60c","original_commit_id":"dda1889350c512c51b1d38d574fab5a1feb8c60c","user":{"login":"Rik","id":3653,"avatar_url":"https://avatars.githubusercontent.com/u/3653?v=2","gravatar_id":"","url":"https://api.github.com/users/Rik","html_url":"https://github.com/Rik","followers_url":"https://api.github.com/users/Rik/followers","following_url":"https://api.github.com/users/Rik/following{/other_user}","gists_url":"https://api.github.com/users/Rik/gists{/gist_id}","starred_url":"https://api.github.com/users/Rik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rik/subscriptions","organizations_url":"https://api.github.com/users/Rik/orgs","repos_url":"https://api.github.com/users/Rik/repos","events_url":"https://api.github.com/users/Rik/events{/privacy}","received_events_url":"https://api.github.com/users/Rik/received_events","type":"User","site_admin":false},"body":"I've tested and we get this error : `W/GeckoConsole( 2143): [JavaScript Error: \"NS_ERROR_NOT_AVAILABLE: \" {file: \"app://callscreen.gaiamobile.org/js/calls_handler.js\" line: 772}]`. Which is expected.","created_at":"2014-09-26T13:48:25Z","updated_at":"2014-09-26T13:48:25Z","html_url":"https://github.com/mozilla-b2g/gaia/pull/22348#discussion_r18089410","pull_request_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/22348","_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/18089410"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/22348#discussion_r18089410"},"pull_request":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/22348"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/22348","id":19142397,"html_url":"https://github.com/mozilla-b2g/gaia/pull/22348","diff_url":"https://github.com/mozilla-b2g/gaia/pull/22348.diff","patch_url":"https://github.com/mozilla-b2g/gaia/pull/22348.patch","issue_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/22348","number":22348,"state":"open","locked":false,"title":"Bug 977588 - [Dialer] The Active call screen does not have the option to place calls on hold.","user":{"login":"pacorampas","id":3866940,"avatar_url":"https://avatars.githubusercontent.com/u/3866940?v=2","gravatar_id":"","url":"https://api.github.com/users/pacorampas","html_url":"https://github.com/pacorampas","followers_url":"https://api.github.com/users/pacorampas/followers","following_url":"https://api.github.com/users/pacorampas/following{/other_user}","gists_url":"https://api.github.com/users/pacorampas/gists{/gist_id}","starred_url":"https://api.github.com/users/pacorampas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pacorampas/subscriptions","organizations_url":"https://api.github.com/users/pacorampas/orgs","repos_url":"https://api.github.com/users/pacorampas/repos","events_url":"https://api.github.com/users/pacorampas/events{/privacy}","received_events_url":"https://api.github.com/users/pacorampas/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-07-31T10:05:19Z","updated_at":"2014-09-26T13:48:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"982e14c32f5464de3821dbcea98e401ee50eb2e8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/22348/commits","review_comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/22348/comments","review_comment_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/22348/comments","statuses_url":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/dda1889350c512c51b1d38d574fab5a1feb8c60c","head":{"label":"pacorampas:977588","ref":"977588","sha":"dda1889350c512c51b1d38d574fab5a1feb8c60c","user":{"login":"pacorampas","id":3866940,"avatar_url":"https://avatars.githubusercontent.com/u/3866940?v=2","gravatar_id":"","url":"https://api.github.com/users/pacorampas","html_url":"https://github.com/pacorampas","followers_url":"https://api.github.com/users/pacorampas/followers","following_url":"https://api.github.com/users/pacorampas/following{/other_user}","gists_url":"https://api.github.com/users/pacorampas/gists{/gist_id}","starred_url":"https://api.github.com/users/pacorampas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pacorampas/subscriptions","organizations_url":"https://api.github.com/users/pacorampas/orgs","repos_url":"https://api.github.com/users/pacorampas/repos","events_url":"https://api.github.com/users/pacorampas/events{/privacy}","received_events_url":"https://api.github.com/users/pacorampas/received_events","type":"User","site_admin":false},"repo":{"id":17360277,"name":"gaia","full_name":"pacorampas/gaia","owner":{"login":"pacorampas","id":3866940,"avatar_url":"https://avatars.githubusercontent.com/u/3866940?v=2","gravatar_id":"","url":"https://api.github.com/users/pacorampas","html_url":"https://github.com/pacorampas","followers_url":"https://api.github.com/users/pacorampas/followers","following_url":"https://api.github.com/users/pacorampas/following{/other_user}","gists_url":"https://api.github.com/users/pacorampas/gists{/gist_id}","starred_url":"https://api.github.com/users/pacorampas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pacorampas/subscriptions","organizations_url":"https://api.github.com/users/pacorampas/orgs","repos_url":"https://api.github.com/users/pacorampas/repos","events_url":"https://api.github.com/users/pacorampas/events{/privacy}","received_events_url":"https://api.github.com/users/pacorampas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pacorampas/gaia","description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see https://wiki.mozilla.org/Release_Management/B2G_Landing","fork":true,"url":"https://api.github.com/repos/pacorampas/gaia","forks_url":"https://api.github.com/repos/pacorampas/gaia/forks","keys_url":"https://api.github.com/repos/pacorampas/gaia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pacorampas/gaia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pacorampas/gaia/teams","hooks_url":"https://api.github.com/repos/pacorampas/gaia/hooks","issue_events_url":"https://api.github.com/repos/pacorampas/gaia/issues/events{/number}","events_url":"https://api.github.com/repos/pacorampas/gaia/events","assignees_url":"https://api.github.com/repos/pacorampas/gaia/assignees{/user}","branches_url":"https://api.github.com/repos/pacorampas/gaia/branches{/branch}","tags_url":"https://api.github.com/repos/pacorampas/gaia/tags","blobs_url":"https://api.github.com/repos/pacorampas/gaia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pacorampas/gaia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pacorampas/gaia/git/refs{/sha}","trees_url":"https://api.github.com/repos/pacorampas/gaia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pacorampas/gaia/statuses/{sha}","languages_url":"https://api.github.com/repos/pacorampas/gaia/languages","stargazers_url":"https://api.github.com/repos/pacorampas/gaia/stargazers","contributors_url":"https://api.github.com/repos/pacorampas/gaia/contributors","subscribers_url":"https://api.github.com/repos/pacorampas/gaia/subscribers","subscription_url":"https://api.github.com/repos/pacorampas/gaia/subscription","commits_url":"https://api.github.com/repos/pacorampas/gaia/commits{/sha}","git_commits_url":"https://api.github.com/repos/pacorampas/gaia/git/commits{/sha}","comments_url":"https://api.github.com/repos/pacorampas/gaia/comments{/number}","issue_comment_url":"https://api.github.com/repos/pacorampas/gaia/issues/comments/{number}","contents_url":"https://api.github.com/repos/pacorampas/gaia/contents/{+path}","compare_url":"https://api.github.com/repos/pacorampas/gaia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pacorampas/gaia/merges","archive_url":"https://api.github.com/repos/pacorampas/gaia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pacorampas/gaia/downloads","issues_url":"https://api.github.com/repos/pacorampas/gaia/issues{/number}","pulls_url":"https://api.github.com/repos/pacorampas/gaia/pulls{/number}","milestones_url":"https://api.github.com/repos/pacorampas/gaia/milestones{/number}","notifications_url":"https://api.github.com/repos/pacorampas/gaia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pacorampas/gaia/labels{/name}","releases_url":"https://api.github.com/repos/pacorampas/gaia/releases{/id}","created_at":"2014-03-03T08:55:07Z","updated_at":"2014-07-10T06:31:26Z","pushed_at":"2014-09-26T11:15:55Z","git_url":"git://github.com/pacorampas/gaia.git","ssh_url":"git@github.com:pacorampas/gaia.git","clone_url":"https://github.com/pacorampas/gaia.git","svn_url":"https://github.com/pacorampas/gaia","homepage":"https://wiki.mozilla.org/B2G","size":869133,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla-b2g:master","ref":"master","sha":"f34925055ae0a520a0bbbae8c64698391691a06f","user":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=2","gravatar_id":"","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"repo":{"id":2317369,"name":"gaia","full_name":"mozilla-b2g/gaia","owner":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=2","gravatar_id":"","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-b2g/gaia","description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see","fork":false,"url":"https://api.github.com/repos/mozilla-b2g/gaia","forks_url":"https://api.github.com/repos/mozilla-b2g/gaia/forks","keys_url":"https://api.github.com/repos/mozilla-b2g/gaia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-b2g/gaia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-b2g/gaia/teams","hooks_url":"https://api.github.com/repos/mozilla-b2g/gaia/hooks","issue_events_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-b2g/gaia/events","assignees_url":"https://api.github.com/repos/mozilla-b2g/gaia/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-b2g/gaia/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-b2g/gaia/tags","blobs_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-b2g/gaia/languages","stargazers_url":"https://api.github.com/repos/mozilla-b2g/gaia/stargazers","contributors_url":"https://api.github.com/repos/mozilla-b2g/gaia/contributors","subscribers_url":"https://api.github.com/repos/mozilla-b2g/gaia/subscribers","subscription_url":"https://api.github.com/repos/mozilla-b2g/gaia/subscription","commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/comments/{number}","contents_url":"https://api.github.com/repos/mozilla-b2g/gaia/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-b2g/gaia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-b2g/gaia/merges","archive_url":"https://api.github.com/repos/mozilla-b2g/gaia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-b2g/gaia/downloads","issues_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-b2g/gaia/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-b2g/gaia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-b2g/gaia/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-b2g/gaia/releases{/id}","created_at":"2011-09-03T01:38:46Z","updated_at":"2014-09-25T19:23:30Z","pushed_at":"2014-09-26T13:06:33Z","git_url":"git://github.com/mozilla-b2g/gaia.git","ssh_url":"git@github.com:mozilla-b2g/gaia.git","clone_url":"https://github.com/mozilla-b2g/gaia.git","svn_url":"https://github.com/mozilla-b2g/gaia","homepage":"https://wiki.mozilla.org/B2G","size":1464048,"stargazers_count":1752,"watchers_count":1752,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1930,"mirror_url":null,"open_issues_count":2039,"forks":1930,"open_issues":2039,"watchers":1752,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/22348"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/22348"},"issue":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/issues/22348"},"comments":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/issues/22348/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/22348/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/22348/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/dda1889350c512c51b1d38d574fab5a1feb8c60c"}}}}