GitHub PullRequestReviewCommentEvent at 2014-10-18 15:29:24
Repository: OpenRA
Actor: Phrohdoh
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/comments/19054220","id":19054220,"diff_hunk":"@@ -0,0 +1,138 @@\n+﻿// #region Copyright & License Information\n+// /*\n+//  * Copyright 2007-2014 The OpenRA Developers (see AUTHORS)\n+//  * This file is part of OpenRA, which is free software. It is made\n+//  * available to you under the terms of the GNU General Public License\n+//  * as published by the Free Software Foundation. For more information,\n+//  * see COPYING.\n+//  */\n+// #endregion\n+using System;\n+using OpenRA.Traits;\n+using System.Linq;\n+using OpenRA.Mods.RA;\n+\n+\n+namespace OpenRA.Mods.RA\n+{\n+\t[Desc(\"Automated flying carryall\")]\n+\tpublic class AutoCarryAllInfo : ITraitInfo\n+\t{\n+\n+\t\tpublic object Create(ActorInitializer init) { return new AutoCarryAll(init.self, this); }\n+\t}\n+\tpublic class AutoCarryAll : INotifyIdle, INotifyKilled, IResolveOrder\n+\t{\n+\t\t//private AutoCarryAllInfo info;\n+\t\tActor self;\n+\n+\t\t// The actor we are currently carrying.\n+\t\tprivate Actor carryable = null;","path":"OpenRA.Mods.RA/AutoCarryAll/AutoCarryAll.cs","position":30,"original_position":30,"commit_id":"acfa3057b5ac8aeabb10f7d42b0489d8b3b3f79a","original_commit_id":"acfa3057b5ac8aeabb10f7d42b0489d8b3b3f79a","user":{"login":"Phrohdoh","id":4861023,"avatar_url":"https://avatars.githubusercontent.com/u/4861023?v=2","gravatar_id":"","url":"https://api.github.com/users/Phrohdoh","html_url":"https://github.com/Phrohdoh","followers_url":"https://api.github.com/users/Phrohdoh/followers","following_url":"https://api.github.com/users/Phrohdoh/following{/other_user}","gists_url":"https://api.github.com/users/Phrohdoh/gists{/gist_id}","starred_url":"https://api.github.com/users/Phrohdoh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Phrohdoh/subscriptions","organizations_url":"https://api.github.com/users/Phrohdoh/orgs","repos_url":"https://api.github.com/users/Phrohdoh/repos","events_url":"https://api.github.com/users/Phrohdoh/events{/privacy}","received_events_url":"https://api.github.com/users/Phrohdoh/received_events","type":"User","site_admin":false},"body":"Could this be named `carrying` to be a bit more self explanatory?","created_at":"2014-10-18T15:29:24Z","updated_at":"2014-10-18T15:29:24Z","html_url":"https://github.com/OpenRA/OpenRA/pull/6780#discussion_r19054220","pull_request_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/6780","_links":{"self":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/comments/19054220"},"html":{"href":"https://github.com/OpenRA/OpenRA/pull/6780#discussion_r19054220"},"pull_request":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/6780"}}},"pull_request":{"url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/6780","id":22968911,"html_url":"https://github.com/OpenRA/OpenRA/pull/6780","diff_url":"https://github.com/OpenRA/OpenRA/pull/6780.diff","patch_url":"https://github.com/OpenRA/OpenRA/pull/6780.patch","issue_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/6780","number":6780,"state":"open","locked":false,"title":"D2K: Implement automatic Carryall","user":{"login":"MatthijsBenschop","id":8655965,"avatar_url":"https://avatars.githubusercontent.com/u/8655965?v=2","gravatar_id":"","url":"https://api.github.com/users/MatthijsBenschop","html_url":"https://github.com/MatthijsBenschop","followers_url":"https://api.github.com/users/MatthijsBenschop/followers","following_url":"https://api.github.com/users/MatthijsBenschop/following{/other_user}","gists_url":"https://api.github.com/users/MatthijsBenschop/gists{/gist_id}","starred_url":"https://api.github.com/users/MatthijsBenschop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MatthijsBenschop/subscriptions","organizations_url":"https://api.github.com/users/MatthijsBenschop/orgs","repos_url":"https://api.github.com/users/MatthijsBenschop/repos","events_url":"https://api.github.com/users/MatthijsBenschop/events{/privacy}","received_events_url":"https://api.github.com/users/MatthijsBenschop/received_events","type":"User","site_admin":false},"body":"This is a big WIP, the basic is working and wanted to share this with you guys. Please do not merge yet.\r\n\r\nIts buildable from a heavy factory and is transporting harvs to and from procs. For this I've added some hooks into the harvester code.\r\n\r\nBefore merge i've got this todo list, in my order of preference:\r\n- [x] Carry harvesters to and from spice fields\r\n- [ ] Show the unit being carried below the carryall (Already got a hint from pchote on irc to look at the TD transports)\r\n- [ ] Base fly when idle (easy)\r\n- [ ] Transport units to the repair pad when clicked with the wrench (where's that base repair code?)\r\n- [ ] Spawn outside screen and move into playing area after being build (no clue yet)\r\n- [ ] Code style and rules yaml\r\n\r\nMaybe later:\r\n- [ ] Deliver a harvester when proc is build\r\n- [ ] Fly more like a Dune2000 caryall rather than like a ra helicopter\r\n- [ ] A (non buildable) ra chinook carying vehicles (for fun)\r\n\r\nI'd like some feedback, about the global direction i've taken with the code, and need some help to implement the other goals in the todo list.","created_at":"2014-10-18T15:11:12Z","updated_at":"2014-10-18T15:29:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dc956d8c86800f636577dc398813e516cfb34197","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/6780/commits","review_comments_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/6780/comments","review_comment_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/comments/{number}","comments_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/6780/comments","statuses_url":"https://api.github.com/repos/OpenRA/OpenRA/statuses/acfa3057b5ac8aeabb10f7d42b0489d8b3b3f79a","head":{"label":"MatthijsBenschop:d2k-caryall","ref":"d2k-caryall","sha":"acfa3057b5ac8aeabb10f7d42b0489d8b3b3f79a","user":{"login":"MatthijsBenschop","id":8655965,"avatar_url":"https://avatars.githubusercontent.com/u/8655965?v=2","gravatar_id":"","url":"https://api.github.com/users/MatthijsBenschop","html_url":"https://github.com/MatthijsBenschop","followers_url":"https://api.github.com/users/MatthijsBenschop/followers","following_url":"https://api.github.com/users/MatthijsBenschop/following{/other_user}","gists_url":"https://api.github.com/users/MatthijsBenschop/gists{/gist_id}","starred_url":"https://api.github.com/users/MatthijsBenschop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MatthijsBenschop/subscriptions","organizations_url":"https://api.github.com/users/MatthijsBenschop/orgs","repos_url":"https://api.github.com/users/MatthijsBenschop/repos","events_url":"https://api.github.com/users/MatthijsBenschop/events{/privacy}","received_events_url":"https://api.github.com/users/MatthijsBenschop/received_events","type":"User","site_admin":false},"repo":{"id":24276481,"name":"OpenRA","full_name":"MatthijsBenschop/OpenRA","owner":{"login":"MatthijsBenschop","id":8655965,"avatar_url":"https://avatars.githubusercontent.com/u/8655965?v=2","gravatar_id":"","url":"https://api.github.com/users/MatthijsBenschop","html_url":"https://github.com/MatthijsBenschop","followers_url":"https://api.github.com/users/MatthijsBenschop/followers","following_url":"https://api.github.com/users/MatthijsBenschop/following{/other_user}","gists_url":"https://api.github.com/users/MatthijsBenschop/gists{/gist_id}","starred_url":"https://api.github.com/users/MatthijsBenschop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MatthijsBenschop/subscriptions","organizations_url":"https://api.github.com/users/MatthijsBenschop/orgs","repos_url":"https://api.github.com/users/MatthijsBenschop/repos","events_url":"https://api.github.com/users/MatthijsBenschop/events{/privacy}","received_events_url":"https://api.github.com/users/MatthijsBenschop/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MatthijsBenschop/OpenRA","description":"An open-source implementation of the Command & Conquer: Red Alert engine using .NET/Mono and OpenGL. Runs on Windows, Linux and Mac OS X.","fork":true,"url":"https://api.github.com/repos/MatthijsBenschop/OpenRA","forks_url":"https://api.github.com/repos/MatthijsBenschop/OpenRA/forks","keys_url":"https://api.github.com/repos/MatthijsBenschop/OpenRA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MatthijsBenschop/OpenRA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MatthijsBenschop/OpenRA/teams","hooks_url":"https://api.github.com/repos/MatthijsBenschop/OpenRA/hooks","issue_events_url":"https://api.github.com/repos/MatthijsBenschop/OpenRA/issues/events{/number}","events_url":"https://api.github.com/repos/MatthijsBenschop/OpenRA/events","assignees_url":"https://api.github.com/repos/MatthijsBenschop/OpenRA/assignees{/user}","branches_url":"https://api.github.com/repos/MatthijsBenschop/OpenRA/branches{/branch}","tags_url":"https://api.github.com/repos/MatthijsBenschop/OpenRA/tags","blobs_url":"https://api.github.com/repos/MatthijsBenschop/OpenRA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MatthijsBenschop/OpenRA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MatthijsBenschop/OpenRA/git/refs{/sha}","trees_url":"https://api.github.com/repos/MatthijsBenschop/OpenRA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MatthijsBenschop/OpenRA/statuses/{sha}","languages_url":"https://api.github.com/repos/MatthijsBenschop/OpenRA/languages","stargazers_url":"https://api.github.com/repos/MatthijsBenschop/OpenRA/stargazers","contributors_url":"https://api.github.com/repos/MatthijsBenschop/OpenRA/contributors","subscribers_url":"https://api.github.com/repos/MatthijsBenschop/OpenRA/subscribers","subscription_url":"https://api.github.com/repos/MatthijsBenschop/OpenRA/subscription","commits_url":"https://api.github.com/repos/MatthijsBenschop/OpenRA/commits{/sha}","git_commits_url":"https://api.github.com/repos/MatthijsBenschop/OpenRA/git/commits{/sha}","comments_url":"https://api.github.com/repos/MatthijsBenschop/OpenRA/comments{/number}","issue_comment_url":"https://api.github.com/repos/MatthijsBenschop/OpenRA/issues/comments/{number}","contents_url":"https://api.github.com/repos/MatthijsBenschop/OpenRA/contents/{+path}","compare_url":"https://api.github.com/repos/MatthijsBenschop/OpenRA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MatthijsBenschop/OpenRA/merges","archive_url":"https://api.github.com/repos/MatthijsBenschop/OpenRA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MatthijsBenschop/OpenRA/downloads","issues_url":"https://api.github.com/repos/MatthijsBenschop/OpenRA/issues{/number}","pulls_url":"https://api.github.com/repos/MatthijsBenschop/OpenRA/pulls{/number}","milestones_url":"https://api.github.com/repos/MatthijsBenschop/OpenRA/milestones{/number}","notifications_url":"https://api.github.com/repos/MatthijsBenschop/OpenRA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MatthijsBenschop/OpenRA/labels{/name}","releases_url":"https://api.github.com/repos/MatthijsBenschop/OpenRA/releases{/id}","created_at":"2014-09-20T22:50:06Z","updated_at":"2014-10-11T11:18:41Z","pushed_at":"2014-10-18T13:45:33Z","git_url":"git://github.com/MatthijsBenschop/OpenRA.git","ssh_url":"git@github.com:MatthijsBenschop/OpenRA.git","clone_url":"https://github.com/MatthijsBenschop/OpenRA.git","svn_url":"https://github.com/MatthijsBenschop/OpenRA","homepage":"http://www.openra.net","size":72330,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"bleed"}},"base":{"label":"OpenRA:bleed","ref":"bleed","sha":"426f14690595c218822611283b9c1e431f082d24","user":{"login":"OpenRA","id":409046,"avatar_url":"https://avatars.githubusercontent.com/u/409046?v=2","gravatar_id":"","url":"https://api.github.com/users/OpenRA","html_url":"https://github.com/OpenRA","followers_url":"https://api.github.com/users/OpenRA/followers","following_url":"https://api.github.com/users/OpenRA/following{/other_user}","gists_url":"https://api.github.com/users/OpenRA/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenRA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenRA/subscriptions","organizations_url":"https://api.github.com/users/OpenRA/orgs","repos_url":"https://api.github.com/users/OpenRA/repos","events_url":"https://api.github.com/users/OpenRA/events{/privacy}","received_events_url":"https://api.github.com/users/OpenRA/received_events","type":"Organization","site_admin":false},"repo":{"id":959908,"name":"OpenRA","full_name":"OpenRA/OpenRA","owner":{"login":"OpenRA","id":409046,"avatar_url":"https://avatars.githubusercontent.com/u/409046?v=2","gravatar_id":"","url":"https://api.github.com/users/OpenRA","html_url":"https://github.com/OpenRA","followers_url":"https://api.github.com/users/OpenRA/followers","following_url":"https://api.github.com/users/OpenRA/following{/other_user}","gists_url":"https://api.github.com/users/OpenRA/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenRA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenRA/subscriptions","organizations_url":"https://api.github.com/users/OpenRA/orgs","repos_url":"https://api.github.com/users/OpenRA/repos","events_url":"https://api.github.com/users/OpenRA/events{/privacy}","received_events_url":"https://api.github.com/users/OpenRA/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenRA/OpenRA","description":"An open-source implementation of the Command & Conquer: Red Alert engine using .NET/Mono and OpenGL. Runs on Windows, Linux and Mac OS X.","fork":false,"url":"https://api.github.com/repos/OpenRA/OpenRA","forks_url":"https://api.github.com/repos/OpenRA/OpenRA/forks","keys_url":"https://api.github.com/repos/OpenRA/OpenRA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenRA/OpenRA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenRA/OpenRA/teams","hooks_url":"https://api.github.com/repos/OpenRA/OpenRA/hooks","issue_events_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/events{/number}","events_url":"https://api.github.com/repos/OpenRA/OpenRA/events","assignees_url":"https://api.github.com/repos/OpenRA/OpenRA/assignees{/user}","branches_url":"https://api.github.com/repos/OpenRA/OpenRA/branches{/branch}","tags_url":"https://api.github.com/repos/OpenRA/OpenRA/tags","blobs_url":"https://api.github.com/repos/OpenRA/OpenRA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenRA/OpenRA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenRA/OpenRA/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenRA/OpenRA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenRA/OpenRA/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenRA/OpenRA/languages","stargazers_url":"https://api.github.com/repos/OpenRA/OpenRA/stargazers","contributors_url":"https://api.github.com/repos/OpenRA/OpenRA/contributors","subscribers_url":"https://api.github.com/repos/OpenRA/OpenRA/subscribers","subscription_url":"https://api.github.com/repos/OpenRA/OpenRA/subscription","commits_url":"https://api.github.com/repos/OpenRA/OpenRA/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenRA/OpenRA/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenRA/OpenRA/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/comments/{number}","contents_url":"https://api.github.com/repos/OpenRA/OpenRA/contents/{+path}","compare_url":"https://api.github.com/repos/OpenRA/OpenRA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenRA/OpenRA/merges","archive_url":"https://api.github.com/repos/OpenRA/OpenRA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenRA/OpenRA/downloads","issues_url":"https://api.github.com/repos/OpenRA/OpenRA/issues{/number}","pulls_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenRA/OpenRA/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenRA/OpenRA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenRA/OpenRA/labels{/name}","releases_url":"https://api.github.com/repos/OpenRA/OpenRA/releases{/id}","created_at":"2010-10-04T07:38:05Z","updated_at":"2014-10-18T12:38:08Z","pushed_at":"2014-10-18T12:36:06Z","git_url":"git://github.com/OpenRA/OpenRA.git","ssh_url":"git@github.com:OpenRA/OpenRA.git","clone_url":"https://github.com/OpenRA/OpenRA.git","svn_url":"https://github.com/OpenRA/OpenRA","homepage":"http://www.openra.net","size":178017,"stargazers_count":1407,"watchers_count":1407,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":465,"mirror_url":null,"open_issues_count":777,"forks":465,"open_issues":777,"watchers":1407,"default_branch":"bleed"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/6780"},"html":{"href":"https://github.com/OpenRA/OpenRA/pull/6780"},"issue":{"href":"https://api.github.com/repos/OpenRA/OpenRA/issues/6780"},"comments":{"href":"https://api.github.com/repos/OpenRA/OpenRA/issues/6780/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/6780/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/6780/commits"},"statuses":{"href":"https://api.github.com/repos/OpenRA/OpenRA/statuses/acfa3057b5ac8aeabb10f7d42b0489d8b3b3f79a"}}}}