GitHub PullRequestEvent at 2014-11-21 23:53:54
Repository: txredisapi
Actor: fiorix
Payload: {"action":"closed","number":76,"pull_request":{"url":"https://api.github.com/repos/fiorix/txredisapi/pulls/76","id":24831746,"html_url":"https://github.com/fiorix/txredisapi/pull/76","diff_url":"https://github.com/fiorix/txredisapi/pull/76.diff","patch_url":"https://github.com/fiorix/txredisapi/pull/76.patch","issue_url":"https://api.github.com/repos/fiorix/txredisapi/issues/76","number":76,"state":"closed","locked":false,"title":"Multiple queued commands during watch","user":{"login":"iksteen","id":1001206,"avatar_url":"https://avatars.githubusercontent.com/u/1001206?v=3","gravatar_id":"","url":"https://api.github.com/users/iksteen","html_url":"https://github.com/iksteen","followers_url":"https://api.github.com/users/iksteen/followers","following_url":"https://api.github.com/users/iksteen/following{/other_user}","gists_url":"https://api.github.com/users/iksteen/gists{/gist_id}","starred_url":"https://api.github.com/users/iksteen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iksteen/subscriptions","organizations_url":"https://api.github.com/users/iksteen/orgs","repos_url":"https://api.github.com/users/iksteen/repos","events_url":"https://api.github.com/users/iksteen/events{/privacy}","received_events_url":"https://api.github.com/users/iksteen/received_events","type":"User","site_admin":false},"body":"When MULTI has not been called on a transaction yet, post_proc should be treated as it would be without a transaction.\r\n\r\nBelow is an example where post_proc won't be called. The result of hgetall will not be a dictionary:\r\n\r\n    t = yield db.watch(['foo'])\r\n    a, b = yield defer.gatherResults([\r\n        t.hgetall('bar'),\r\n        t.hgetall('baz'),\r\n    ])\r\n\r\nThis pull requests adds a test for this scenario, fixes the handling of post_proc before MULTI is called, and makes commit/discard check if MULTI is called.","created_at":"2014-11-21T10:44:24Z","updated_at":"2014-11-21T23:53:54Z","closed_at":"2014-11-21T23:53:54Z","merged_at":"2014-11-21T23:53:54Z","merge_commit_sha":"1486f90ee0ef6aaa590310ae2fa47afae43f2808","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/fiorix/txredisapi/pulls/76/commits","review_comments_url":"https://api.github.com/repos/fiorix/txredisapi/pulls/76/comments","review_comment_url":"https://api.github.com/repos/fiorix/txredisapi/pulls/comments/{number}","comments_url":"https://api.github.com/repos/fiorix/txredisapi/issues/76/comments","statuses_url":"https://api.github.com/repos/fiorix/txredisapi/statuses/076ff5356f324982db77b15c15928f1d09aad73f","head":{"label":"voipro:fix-async-during-watch","ref":"fix-async-during-watch","sha":"076ff5356f324982db77b15c15928f1d09aad73f","user":{"login":"voipro","id":2870884,"avatar_url":"https://avatars.githubusercontent.com/u/2870884?v=3","gravatar_id":"","url":"https://api.github.com/users/voipro","html_url":"https://github.com/voipro","followers_url":"https://api.github.com/users/voipro/followers","following_url":"https://api.github.com/users/voipro/following{/other_user}","gists_url":"https://api.github.com/users/voipro/gists{/gist_id}","starred_url":"https://api.github.com/users/voipro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/voipro/subscriptions","organizations_url":"https://api.github.com/users/voipro/orgs","repos_url":"https://api.github.com/users/voipro/repos","events_url":"https://api.github.com/users/voipro/events{/privacy}","received_events_url":"https://api.github.com/users/voipro/received_events","type":"Organization","site_admin":false},"repo":{"id":26955011,"name":"txredisapi","full_name":"voipro/txredisapi","owner":{"login":"voipro","id":2870884,"avatar_url":"https://avatars.githubusercontent.com/u/2870884?v=3","gravatar_id":"","url":"https://api.github.com/users/voipro","html_url":"https://github.com/voipro","followers_url":"https://api.github.com/users/voipro/followers","following_url":"https://api.github.com/users/voipro/following{/other_user}","gists_url":"https://api.github.com/users/voipro/gists{/gist_id}","starred_url":"https://api.github.com/users/voipro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/voipro/subscriptions","organizations_url":"https://api.github.com/users/voipro/orgs","repos_url":"https://api.github.com/users/voipro/repos","events_url":"https://api.github.com/users/voipro/events{/privacy}","received_events_url":"https://api.github.com/users/voipro/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/voipro/txredisapi","description":"non-blocking redis client for python twisted","fork":true,"url":"https://api.github.com/repos/voipro/txredisapi","forks_url":"https://api.github.com/repos/voipro/txredisapi/forks","keys_url":"https://api.github.com/repos/voipro/txredisapi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/voipro/txredisapi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/voipro/txredisapi/teams","hooks_url":"https://api.github.com/repos/voipro/txredisapi/hooks","issue_events_url":"https://api.github.com/repos/voipro/txredisapi/issues/events{/number}","events_url":"https://api.github.com/repos/voipro/txredisapi/events","assignees_url":"https://api.github.com/repos/voipro/txredisapi/assignees{/user}","branches_url":"https://api.github.com/repos/voipro/txredisapi/branches{/branch}","tags_url":"https://api.github.com/repos/voipro/txredisapi/tags","blobs_url":"https://api.github.com/repos/voipro/txredisapi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/voipro/txredisapi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/voipro/txredisapi/git/refs{/sha}","trees_url":"https://api.github.com/repos/voipro/txredisapi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/voipro/txredisapi/statuses/{sha}","languages_url":"https://api.github.com/repos/voipro/txredisapi/languages","stargazers_url":"https://api.github.com/repos/voipro/txredisapi/stargazers","contributors_url":"https://api.github.com/repos/voipro/txredisapi/contributors","subscribers_url":"https://api.github.com/repos/voipro/txredisapi/subscribers","subscription_url":"https://api.github.com/repos/voipro/txredisapi/subscription","commits_url":"https://api.github.com/repos/voipro/txredisapi/commits{/sha}","git_commits_url":"https://api.github.com/repos/voipro/txredisapi/git/commits{/sha}","comments_url":"https://api.github.com/repos/voipro/txredisapi/comments{/number}","issue_comment_url":"https://api.github.com/repos/voipro/txredisapi/issues/comments/{number}","contents_url":"https://api.github.com/repos/voipro/txredisapi/contents/{+path}","compare_url":"https://api.github.com/repos/voipro/txredisapi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/voipro/txredisapi/merges","archive_url":"https://api.github.com/repos/voipro/txredisapi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/voipro/txredisapi/downloads","issues_url":"https://api.github.com/repos/voipro/txredisapi/issues{/number}","pulls_url":"https://api.github.com/repos/voipro/txredisapi/pulls{/number}","milestones_url":"https://api.github.com/repos/voipro/txredisapi/milestones{/number}","notifications_url":"https://api.github.com/repos/voipro/txredisapi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/voipro/txredisapi/labels{/name}","releases_url":"https://api.github.com/repos/voipro/txredisapi/releases{/id}","created_at":"2014-11-21T10:02:11Z","updated_at":"2014-11-21T10:02:12Z","pushed_at":"2014-11-21T10:40:13Z","git_url":"git://github.com/voipro/txredisapi.git","ssh_url":"git@github.com:voipro/txredisapi.git","clone_url":"https://github.com/voipro/txredisapi.git","svn_url":"https://github.com/voipro/txredisapi","homepage":"","size":810,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fiorix:master","ref":"master","sha":"d7f13e51857fe875d24a8564544824785c81374c","user":{"login":"fiorix","id":129742,"avatar_url":"https://avatars.githubusercontent.com/u/129742?v=3","gravatar_id":"","url":"https://api.github.com/users/fiorix","html_url":"https://github.com/fiorix","followers_url":"https://api.github.com/users/fiorix/followers","following_url":"https://api.github.com/users/fiorix/following{/other_user}","gists_url":"https://api.github.com/users/fiorix/gists{/gist_id}","starred_url":"https://api.github.com/users/fiorix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fiorix/subscriptions","organizations_url":"https://api.github.com/users/fiorix/orgs","repos_url":"https://api.github.com/users/fiorix/repos","events_url":"https://api.github.com/users/fiorix/events{/privacy}","received_events_url":"https://api.github.com/users/fiorix/received_events","type":"User","site_admin":false},"repo":{"id":437086,"name":"txredisapi","full_name":"fiorix/txredisapi","owner":{"login":"fiorix","id":129742,"avatar_url":"https://avatars.githubusercontent.com/u/129742?v=3","gravatar_id":"","url":"https://api.github.com/users/fiorix","html_url":"https://github.com/fiorix","followers_url":"https://api.github.com/users/fiorix/followers","following_url":"https://api.github.com/users/fiorix/following{/other_user}","gists_url":"https://api.github.com/users/fiorix/gists{/gist_id}","starred_url":"https://api.github.com/users/fiorix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fiorix/subscriptions","organizations_url":"https://api.github.com/users/fiorix/orgs","repos_url":"https://api.github.com/users/fiorix/repos","events_url":"https://api.github.com/users/fiorix/events{/privacy}","received_events_url":"https://api.github.com/users/fiorix/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fiorix/txredisapi","description":"non-blocking redis client for python twisted","fork":false,"url":"https://api.github.com/repos/fiorix/txredisapi","forks_url":"https://api.github.com/repos/fiorix/txredisapi/forks","keys_url":"https://api.github.com/repos/fiorix/txredisapi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fiorix/txredisapi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fiorix/txredisapi/teams","hooks_url":"https://api.github.com/repos/fiorix/txredisapi/hooks","issue_events_url":"https://api.github.com/repos/fiorix/txredisapi/issues/events{/number}","events_url":"https://api.github.com/repos/fiorix/txredisapi/events","assignees_url":"https://api.github.com/repos/fiorix/txredisapi/assignees{/user}","branches_url":"https://api.github.com/repos/fiorix/txredisapi/branches{/branch}","tags_url":"https://api.github.com/repos/fiorix/txredisapi/tags","blobs_url":"https://api.github.com/repos/fiorix/txredisapi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fiorix/txredisapi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fiorix/txredisapi/git/refs{/sha}","trees_url":"https://api.github.com/repos/fiorix/txredisapi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fiorix/txredisapi/statuses/{sha}","languages_url":"https://api.github.com/repos/fiorix/txredisapi/languages","stargazers_url":"https://api.github.com/repos/fiorix/txredisapi/stargazers","contributors_url":"https://api.github.com/repos/fiorix/txredisapi/contributors","subscribers_url":"https://api.github.com/repos/fiorix/txredisapi/subscribers","subscription_url":"https://api.github.com/repos/fiorix/txredisapi/subscription","commits_url":"https://api.github.com/repos/fiorix/txredisapi/commits{/sha}","git_commits_url":"https://api.github.com/repos/fiorix/txredisapi/git/commits{/sha}","comments_url":"https://api.github.com/repos/fiorix/txredisapi/comments{/number}","issue_comment_url":"https://api.github.com/repos/fiorix/txredisapi/issues/comments/{number}","contents_url":"https://api.github.com/repos/fiorix/txredisapi/contents/{+path}","compare_url":"https://api.github.com/repos/fiorix/txredisapi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fiorix/txredisapi/merges","archive_url":"https://api.github.com/repos/fiorix/txredisapi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fiorix/txredisapi/downloads","issues_url":"https://api.github.com/repos/fiorix/txredisapi/issues{/number}","pulls_url":"https://api.github.com/repos/fiorix/txredisapi/pulls{/number}","milestones_url":"https://api.github.com/repos/fiorix/txredisapi/milestones{/number}","notifications_url":"https://api.github.com/repos/fiorix/txredisapi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fiorix/txredisapi/labels{/name}","releases_url":"https://api.github.com/repos/fiorix/txredisapi/releases{/id}","created_at":"2009-12-14T21:27:02Z","updated_at":"2014-11-11T05:28:36Z","pushed_at":"2014-11-21T23:53:54Z","git_url":"git://github.com/fiorix/txredisapi.git","ssh_url":"git@github.com:fiorix/txredisapi.git","clone_url":"https://github.com/fiorix/txredisapi.git","svn_url":"https://github.com/fiorix/txredisapi","homepage":"","size":810,"stargazers_count":137,"watchers_count":137,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":44,"mirror_url":null,"open_issues_count":6,"forks":44,"open_issues":6,"watchers":137,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fiorix/txredisapi/pulls/76"},"html":{"href":"https://github.com/fiorix/txredisapi/pull/76"},"issue":{"href":"https://api.github.com/repos/fiorix/txredisapi/issues/76"},"comments":{"href":"https://api.github.com/repos/fiorix/txredisapi/issues/76/comments"},"review_comments":{"href":"https://api.github.com/repos/fiorix/txredisapi/pulls/76/comments"},"review_comment":{"href":"https://api.github.com/repos/fiorix/txredisapi/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/fiorix/txredisapi/pulls/76/commits"},"statuses":{"href":"https://api.github.com/repos/fiorix/txredisapi/statuses/076ff5356f324982db77b15c15928f1d09aad73f"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"fiorix","id":129742,"avatar_url":"https://avatars.githubusercontent.com/u/129742?v=3","gravatar_id":"","url":"https://api.github.com/users/fiorix","html_url":"https://github.com/fiorix","followers_url":"https://api.github.com/users/fiorix/followers","following_url":"https://api.github.com/users/fiorix/following{/other_user}","gists_url":"https://api.github.com/users/fiorix/gists{/gist_id}","starred_url":"https://api.github.com/users/fiorix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fiorix/subscriptions","organizations_url":"https://api.github.com/users/fiorix/orgs","repos_url":"https://api.github.com/users/fiorix/repos","events_url":"https://api.github.com/users/fiorix/events{/privacy}","received_events_url":"https://api.github.com/users/fiorix/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":3,"additions":25,"deletions":8,"changed_files":2}}