GitHub PullRequestReviewCommentEvent at 2014-02-21 10:32:23
Repository: symfony-docs
Actor: bicpi
Payload: {"comment":{"url":"https://api.github.com/repos/symfony/symfony-docs/pulls/comments/9941537","id":9941537,"diff_hunk":"@@ -34,7 +34,7 @@ Basic Example: HTTP Authentication\n The Security component can be configured via your application configuration.\n In fact, most standard security setups are just a matter of using the right\n configuration. The following configuration tells Symfony to secure any URL\n-matching ``/admin/*`` and to ask the user for credentials using basic HTTP","path":"book/security.rst","position":4,"original_position":4,"commit_id":"9289d31cd3598e77b98e465206b0c94073975a9d","original_commit_id":"9289d31cd3598e77b98e465206b0c94073975a9d","user":{"login":"bicpi","id":301163,"avatar_url":"https://gravatar.com/avatar/2ac1fe2befdfefc42caca2d5c1db35e1?d=https%3A%2F%2Fidenticons.github.com%2Fb2c50bb135c98bb33d55f82329799d13.png&r=x","gravatar_id":"2ac1fe2befdfefc42caca2d5c1db35e1","url":"https://api.github.com/users/bicpi","html_url":"https://github.com/bicpi","followers_url":"https://api.github.com/users/bicpi/followers","following_url":"https://api.github.com/users/bicpi/following{/other_user}","gists_url":"https://api.github.com/users/bicpi/gists{/gist_id}","starred_url":"https://api.github.com/users/bicpi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bicpi/subscriptions","organizations_url":"https://api.github.com/users/bicpi/orgs","repos_url":"https://api.github.com/users/bicpi/repos","events_url":"https://api.github.com/users/bicpi/events{/privacy}","received_events_url":"https://api.github.com/users/bicpi/received_events","type":"User","site_admin":false},"body":"I also thought about this option which would mean to change the ``access_control`` rule to ``^/admin/``.\r\n\r\nBut maybe users are not aware that securing with ``^/admin/`` excludes a possible admin area entry point ``/admin``?","created_at":"2014-02-21T10:32:23Z","updated_at":"2014-02-21T10:32:23Z","html_url":"https://github.com/symfony/symfony-docs/pull/3595#discussion_r9941537","pull_request_url":"https://api.github.com/repos/symfony/symfony-docs/pulls/3595","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony-docs/pulls/comments/9941537"},"html":{"href":"https://github.com/symfony/symfony-docs/pull/3595#discussion_r9941537"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony-docs/pulls/3595"}}}}