GitHub PullRequestReviewCommentEvent at 2014-09-10 19:06:39
Repository: tachyon
Actor: dcapwell
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/amplab/tachyon/pulls/comments/17381756","id":17381756,"diff_hunk":"@@ -0,0 +1,278 @@\n+/*\n+ * Licensed to the Apache Software Foundation (ASF) under one or more\n+ * contributor license agreements. See the NOTICE file distributed with\n+ * this work for additional information regarding copyright ownership.\n+ * The ASF licenses this file to You under the Apache License, Version 2.0\n+ * (the \"License\"); you may not use this file except in compliance with\n+ * the License. You may obtain a copy of the License at\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+package tachyon.worker.nio;\n+\n+import java.io.IOException;\n+import java.net.InetSocketAddress;\n+import java.nio.channels.SelectionKey;\n+import java.nio.channels.Selector;\n+import java.nio.channels.ServerSocketChannel;\n+import java.nio.channels.SocketChannel;\n+import java.nio.channels.spi.SelectorProvider;\n+import java.util.Collections;\n+import java.util.HashMap;\n+import java.util.Iterator;\n+import java.util.Map;\n+\n+import com.google.common.io.Closeables;\n+import org.apache.log4j.Logger;\n+\n+import com.google.common.base.Throwables;\n+\n+import tachyon.Constants;\n+import tachyon.conf.CommonConf;\n+import tachyon.worker.BlocksLocker;\n+import tachyon.worker.DataServer;\n+\n+/**\n+ * The Server to serve data file read request from remote machines. The current implementation\n+ * is based on non-blocking NIO.\n+ */\n+public class NIODataServer implements Runnable, DataServer {","path":"core/src/main/java/tachyon/worker/nio/NIODataServer.java","position":43,"original_position":43,"commit_id":"445a1dad023e73e3976cf5793caec1b7fff2dc71","original_commit_id":"445a1dad023e73e3976cf5793caec1b7fff2dc71","user":{"login":"dcapwell","id":1852601,"avatar_url":"https://avatars.githubusercontent.com/u/1852601?v=2","gravatar_id":"136010620e86ea76cd82ee1f865b5a2e","url":"https://api.github.com/users/dcapwell","html_url":"https://github.com/dcapwell","followers_url":"https://api.github.com/users/dcapwell/followers","following_url":"https://api.github.com/users/dcapwell/following{/other_user}","gists_url":"https://api.github.com/users/dcapwell/gists{/gist_id}","starred_url":"https://api.github.com/users/dcapwell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcapwell/subscriptions","organizations_url":"https://api.github.com/users/dcapwell/orgs","repos_url":"https://api.github.com/users/dcapwell/repos","events_url":"https://api.github.com/users/dcapwell/events{/privacy}","received_events_url":"https://api.github.com/users/dcapwell/received_events","type":"User","site_admin":false},"body":"Copy/Paste from old DataServer with changes requested in this PR.\r\n\r\nThe only diff is I added a thread to the constructor to handle what the worker used to have.","created_at":"2014-09-10T19:06:39Z","updated_at":"2014-09-10T19:06:39Z","html_url":"https://github.com/amplab/tachyon/pull/333#discussion_r17381756","pull_request_url":"https://api.github.com/repos/amplab/tachyon/pulls/333","_links":{"self":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/comments/17381756"},"html":{"href":"https://github.com/amplab/tachyon/pull/333#discussion_r17381756"},"pull_request":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/333"}}},"pull_request":{"url":"https://api.github.com/repos/amplab/tachyon/pulls/333","id":19504661,"html_url":"https://github.com/amplab/tachyon/pull/333","diff_url":"https://github.com/amplab/tachyon/pull/333.diff","patch_url":"https://github.com/amplab/tachyon/pull/333.patch","issue_url":"https://api.github.com/repos/amplab/tachyon/issues/333","number":333,"state":"open","locked":false,"title":"[TACHYON-62] Netty","user":{"login":"dcapwell","id":1852601,"avatar_url":"https://avatars.githubusercontent.com/u/1852601?v=2","gravatar_id":"136010620e86ea76cd82ee1f865b5a2e","url":"https://api.github.com/users/dcapwell","html_url":"https://github.com/dcapwell","followers_url":"https://api.github.com/users/dcapwell/followers","following_url":"https://api.github.com/users/dcapwell/following{/other_user}","gists_url":"https://api.github.com/users/dcapwell/gists{/gist_id}","starred_url":"https://api.github.com/users/dcapwell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcapwell/subscriptions","organizations_url":"https://api.github.com/users/dcapwell/orgs","repos_url":"https://api.github.com/users/dcapwell/repos","events_url":"https://api.github.com/users/dcapwell/events{/privacy}","received_events_url":"https://api.github.com/users/dcapwell/received_events","type":"User","site_admin":false},"body":"Netty implementation of the data server.\r\n\r\nThis patch is not done yet.  Its intent is to show the work I have right now for commenting.\r\n\r\nThis PR should not be merged until performance results come in.","created_at":"2014-08-08T01:17:18Z","updated_at":"2014-09-10T19:06:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"34bc0ead0ed2104ee805f3cf531bf05e93efe9b5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/amplab/tachyon/pulls/333/commits","review_comments_url":"https://api.github.com/repos/amplab/tachyon/pulls/333/comments","review_comment_url":"https://api.github.com/repos/amplab/tachyon/pulls/comments/{number}","comments_url":"https://api.github.com/repos/amplab/tachyon/issues/333/comments","statuses_url":"https://api.github.com/repos/amplab/tachyon/statuses/445a1dad023e73e3976cf5793caec1b7fff2dc71","head":{"label":"dcapwell:netty","ref":"netty","sha":"445a1dad023e73e3976cf5793caec1b7fff2dc71","user":{"login":"dcapwell","id":1852601,"avatar_url":"https://avatars.githubusercontent.com/u/1852601?v=2","gravatar_id":"136010620e86ea76cd82ee1f865b5a2e","url":"https://api.github.com/users/dcapwell","html_url":"https://github.com/dcapwell","followers_url":"https://api.github.com/users/dcapwell/followers","following_url":"https://api.github.com/users/dcapwell/following{/other_user}","gists_url":"https://api.github.com/users/dcapwell/gists{/gist_id}","starred_url":"https://api.github.com/users/dcapwell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcapwell/subscriptions","organizations_url":"https://api.github.com/users/dcapwell/orgs","repos_url":"https://api.github.com/users/dcapwell/repos","events_url":"https://api.github.com/users/dcapwell/events{/privacy}","received_events_url":"https://api.github.com/users/dcapwell/received_events","type":"User","site_admin":false},"repo":{"id":21745003,"name":"tachyon","full_name":"dcapwell/tachyon","owner":{"login":"dcapwell","id":1852601,"avatar_url":"https://avatars.githubusercontent.com/u/1852601?v=2","gravatar_id":"136010620e86ea76cd82ee1f865b5a2e","url":"https://api.github.com/users/dcapwell","html_url":"https://github.com/dcapwell","followers_url":"https://api.github.com/users/dcapwell/followers","following_url":"https://api.github.com/users/dcapwell/following{/other_user}","gists_url":"https://api.github.com/users/dcapwell/gists{/gist_id}","starred_url":"https://api.github.com/users/dcapwell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcapwell/subscriptions","organizations_url":"https://api.github.com/users/dcapwell/orgs","repos_url":"https://api.github.com/users/dcapwell/repos","events_url":"https://api.github.com/users/dcapwell/events{/privacy}","received_events_url":"https://api.github.com/users/dcapwell/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dcapwell/tachyon","description":"Memory-centric Storage System for Big Data Analytics","fork":true,"url":"https://api.github.com/repos/dcapwell/tachyon","forks_url":"https://api.github.com/repos/dcapwell/tachyon/forks","keys_url":"https://api.github.com/repos/dcapwell/tachyon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dcapwell/tachyon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dcapwell/tachyon/teams","hooks_url":"https://api.github.com/repos/dcapwell/tachyon/hooks","issue_events_url":"https://api.github.com/repos/dcapwell/tachyon/issues/events{/number}","events_url":"https://api.github.com/repos/dcapwell/tachyon/events","assignees_url":"https://api.github.com/repos/dcapwell/tachyon/assignees{/user}","branches_url":"https://api.github.com/repos/dcapwell/tachyon/branches{/branch}","tags_url":"https://api.github.com/repos/dcapwell/tachyon/tags","blobs_url":"https://api.github.com/repos/dcapwell/tachyon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dcapwell/tachyon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dcapwell/tachyon/git/refs{/sha}","trees_url":"https://api.github.com/repos/dcapwell/tachyon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dcapwell/tachyon/statuses/{sha}","languages_url":"https://api.github.com/repos/dcapwell/tachyon/languages","stargazers_url":"https://api.github.com/repos/dcapwell/tachyon/stargazers","contributors_url":"https://api.github.com/repos/dcapwell/tachyon/contributors","subscribers_url":"https://api.github.com/repos/dcapwell/tachyon/subscribers","subscription_url":"https://api.github.com/repos/dcapwell/tachyon/subscription","commits_url":"https://api.github.com/repos/dcapwell/tachyon/commits{/sha}","git_commits_url":"https://api.github.com/repos/dcapwell/tachyon/git/commits{/sha}","comments_url":"https://api.github.com/repos/dcapwell/tachyon/comments{/number}","issue_comment_url":"https://api.github.com/repos/dcapwell/tachyon/issues/comments/{number}","contents_url":"https://api.github.com/repos/dcapwell/tachyon/contents/{+path}","compare_url":"https://api.github.com/repos/dcapwell/tachyon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dcapwell/tachyon/merges","archive_url":"https://api.github.com/repos/dcapwell/tachyon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dcapwell/tachyon/downloads","issues_url":"https://api.github.com/repos/dcapwell/tachyon/issues{/number}","pulls_url":"https://api.github.com/repos/dcapwell/tachyon/pulls{/number}","milestones_url":"https://api.github.com/repos/dcapwell/tachyon/milestones{/number}","notifications_url":"https://api.github.com/repos/dcapwell/tachyon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dcapwell/tachyon/labels{/name}","releases_url":"https://api.github.com/repos/dcapwell/tachyon/releases{/id}","created_at":"2014-07-11T17:22:53Z","updated_at":"2014-07-12T00:24:31Z","pushed_at":"2014-09-09T02:52:37Z","git_url":"git://github.com/dcapwell/tachyon.git","ssh_url":"git@github.com:dcapwell/tachyon.git","clone_url":"https://github.com/dcapwell/tachyon.git","svn_url":"https://github.com/dcapwell/tachyon","homepage":"http://tachyon-project.org","size":8873,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"amplab:master","ref":"master","sha":"01dbff90d660b87f53caa9818963af9be304e79e","user":{"login":"amplab","id":1438454,"avatar_url":"https://avatars.githubusercontent.com/u/1438454?v=2","gravatar_id":"c0783723b006eb46526c04fa47ba2cd7","url":"https://api.github.com/users/amplab","html_url":"https://github.com/amplab","followers_url":"https://api.github.com/users/amplab/followers","following_url":"https://api.github.com/users/amplab/following{/other_user}","gists_url":"https://api.github.com/users/amplab/gists{/gist_id}","starred_url":"https://api.github.com/users/amplab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amplab/subscriptions","organizations_url":"https://api.github.com/users/amplab/orgs","repos_url":"https://api.github.com/users/amplab/repos","events_url":"https://api.github.com/users/amplab/events{/privacy}","received_events_url":"https://api.github.com/users/amplab/received_events","type":"Organization","site_admin":false},"repo":{"id":7276954,"name":"tachyon","full_name":"amplab/tachyon","owner":{"login":"amplab","id":1438454,"avatar_url":"https://avatars.githubusercontent.com/u/1438454?v=2","gravatar_id":"c0783723b006eb46526c04fa47ba2cd7","url":"https://api.github.com/users/amplab","html_url":"https://github.com/amplab","followers_url":"https://api.github.com/users/amplab/followers","following_url":"https://api.github.com/users/amplab/following{/other_user}","gists_url":"https://api.github.com/users/amplab/gists{/gist_id}","starred_url":"https://api.github.com/users/amplab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amplab/subscriptions","organizations_url":"https://api.github.com/users/amplab/orgs","repos_url":"https://api.github.com/users/amplab/repos","events_url":"https://api.github.com/users/amplab/events{/privacy}","received_events_url":"https://api.github.com/users/amplab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/amplab/tachyon","description":" A Reliable Memory Centric Distributed Storage System","fork":false,"url":"https://api.github.com/repos/amplab/tachyon","forks_url":"https://api.github.com/repos/amplab/tachyon/forks","keys_url":"https://api.github.com/repos/amplab/tachyon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amplab/tachyon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amplab/tachyon/teams","hooks_url":"https://api.github.com/repos/amplab/tachyon/hooks","issue_events_url":"https://api.github.com/repos/amplab/tachyon/issues/events{/number}","events_url":"https://api.github.com/repos/amplab/tachyon/events","assignees_url":"https://api.github.com/repos/amplab/tachyon/assignees{/user}","branches_url":"https://api.github.com/repos/amplab/tachyon/branches{/branch}","tags_url":"https://api.github.com/repos/amplab/tachyon/tags","blobs_url":"https://api.github.com/repos/amplab/tachyon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amplab/tachyon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amplab/tachyon/git/refs{/sha}","trees_url":"https://api.github.com/repos/amplab/tachyon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amplab/tachyon/statuses/{sha}","languages_url":"https://api.github.com/repos/amplab/tachyon/languages","stargazers_url":"https://api.github.com/repos/amplab/tachyon/stargazers","contributors_url":"https://api.github.com/repos/amplab/tachyon/contributors","subscribers_url":"https://api.github.com/repos/amplab/tachyon/subscribers","subscription_url":"https://api.github.com/repos/amplab/tachyon/subscription","commits_url":"https://api.github.com/repos/amplab/tachyon/commits{/sha}","git_commits_url":"https://api.github.com/repos/amplab/tachyon/git/commits{/sha}","comments_url":"https://api.github.com/repos/amplab/tachyon/comments{/number}","issue_comment_url":"https://api.github.com/repos/amplab/tachyon/issues/comments/{number}","contents_url":"https://api.github.com/repos/amplab/tachyon/contents/{+path}","compare_url":"https://api.github.com/repos/amplab/tachyon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amplab/tachyon/merges","archive_url":"https://api.github.com/repos/amplab/tachyon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amplab/tachyon/downloads","issues_url":"https://api.github.com/repos/amplab/tachyon/issues{/number}","pulls_url":"https://api.github.com/repos/amplab/tachyon/pulls{/number}","milestones_url":"https://api.github.com/repos/amplab/tachyon/milestones{/number}","notifications_url":"https://api.github.com/repos/amplab/tachyon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amplab/tachyon/labels{/name}","releases_url":"https://api.github.com/repos/amplab/tachyon/releases{/id}","created_at":"2012-12-21T17:43:46Z","updated_at":"2014-09-09T14:47:08Z","pushed_at":"2014-09-10T05:40:43Z","git_url":"git://github.com/amplab/tachyon.git","ssh_url":"git@github.com:amplab/tachyon.git","clone_url":"https://github.com/amplab/tachyon.git","svn_url":"https://github.com/amplab/tachyon","homepage":"http://tachyon-project.org","size":28535,"stargazers_count":928,"watchers_count":928,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":273,"mirror_url":null,"open_issues_count":16,"forks":273,"open_issues":16,"watchers":928,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/333"},"html":{"href":"https://github.com/amplab/tachyon/pull/333"},"issue":{"href":"https://api.github.com/repos/amplab/tachyon/issues/333"},"comments":{"href":"https://api.github.com/repos/amplab/tachyon/issues/333/comments"},"review_comments":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/333/comments"},"review_comment":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/333/commits"},"statuses":{"href":"https://api.github.com/repos/amplab/tachyon/statuses/445a1dad023e73e3976cf5793caec1b7fff2dc71"}}}}