GitHub PullRequestReviewCommentEvent at 2014-07-11 19:21:57
Repository: openbr
Actor: caotto
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/biometrics/openbr/pulls/comments/14838899","id":14838899,"diff_hunk":"@@ -25,22 +25,30 @@ namespace br {\n \n struct AlgorithmCore\n {\n+    enum CompareMode\n+    {\n+        None,\n+        DistanceCompare,\n+        TransformCompare,\n+    };\n+\n     QSharedPointer<Transform> transform;\n+    Transform *simplifiedTransform;\n+    QSharedPointer<Transform> deleteSimplifiedTransform;","path":"openbr/core/core.cpp","position":13,"original_position":13,"commit_id":"cc6651c380df092ca486ce31e535fc225f48694f","original_commit_id":"cc6651c380df092ca486ce31e535fc225f48694f","user":{"login":"caotto","id":3228952,"avatar_url":"https://avatars.githubusercontent.com/u/3228952?","gravatar_id":"7ef4a611883118daccd79c3289e8549d","url":"https://api.github.com/users/caotto","html_url":"https://github.com/caotto","followers_url":"https://api.github.com/users/caotto/followers","following_url":"https://api.github.com/users/caotto/following{/other_user}","gists_url":"https://api.github.com/users/caotto/gists{/gist_id}","starred_url":"https://api.github.com/users/caotto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caotto/subscriptions","organizations_url":"https://api.github.com/users/caotto/orgs","repos_url":"https://api.github.com/users/caotto/repos","events_url":"https://api.github.com/users/caotto/events{/privacy}","received_events_url":"https://api.github.com/users/caotto/received_events","type":"User","site_admin":false},"body":"simplifiedTransform is the result of simplify, deleteSimplifiedTransform is a QSharedPointer pointed at it if it is not already scheduled to be deleted","created_at":"2014-07-11T19:21:57Z","updated_at":"2014-07-11T19:21:57Z","html_url":"https://github.com/biometrics/openbr/pull/216#discussion_r14838899","pull_request_url":"https://api.github.com/repos/biometrics/openbr/pulls/216","_links":{"self":{"href":"https://api.github.com/repos/biometrics/openbr/pulls/comments/14838899"},"html":{"href":"https://github.com/biometrics/openbr/pull/216#discussion_r14838899"},"pull_request":{"href":"https://api.github.com/repos/biometrics/openbr/pulls/216"}}},"pull_request":{"url":"https://api.github.com/repos/biometrics/openbr/pulls/216","id":18130364,"html_url":"https://github.com/biometrics/openbr/pull/216","diff_url":"https://github.com/biometrics/openbr/pull/216.diff","patch_url":"https://github.com/biometrics/openbr/pull/216.patch","issue_url":"https://api.github.com/repos/biometrics/openbr/issues/216","number":216,"state":"open","title":"Better support for serializing algorithms in memory","user":{"login":"caotto","id":3228952,"avatar_url":"https://avatars.githubusercontent.com/u/3228952?","gravatar_id":"7ef4a611883118daccd79c3289e8549d","url":"https://api.github.com/users/caotto","html_url":"https://github.com/caotto","followers_url":"https://api.github.com/users/caotto/followers","following_url":"https://api.github.com/users/caotto/following{/other_user}","gists_url":"https://api.github.com/users/caotto/gists{/gist_id}","starred_url":"https://api.github.com/users/caotto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caotto/subscriptions","organizations_url":"https://api.github.com/users/caotto/orgs","repos_url":"https://api.github.com/users/caotto/repos","events_url":"https://api.github.com/users/caotto/events{/privacy}","received_events_url":"https://api.github.com/users/caotto/received_events","type":"User","site_admin":false},"body":" This branch gives us better support for serializing algorithms, without rigidly assuming that they can be reproduced from the string originally used to create them.\r\n\r\nThe main idea is to expand on Object::description, so that it produces a string that accurately reflects the state of the current object in memory, and also add support for bypassing LoadStore blocks, so that it is possible to force serialization to a single buffer.\r\n\r\nWhen serialization to a single buffer is available, we can do things like serialize a transform in memory, send it to a different process, and the other process can then deserialize it and use the transform, without having to use the file system as an intermediary. Doing this in turn allows some simplification of the algorithm building done in AlgorithmCore::compare and AlgorithmCore::enroll, allowing us to treat multi and single process cases uniformly for the most part. ","created_at":"2014-07-08T21:49:32Z","updated_at":"2014-07-11T19:21:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1901cc40de5252d2692bcd39580461389d20f48c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/biometrics/openbr/pulls/216/commits","review_comments_url":"https://api.github.com/repos/biometrics/openbr/pulls/216/comments","review_comment_url":"https://api.github.com/repos/biometrics/openbr/pulls/comments/{number}","comments_url":"https://api.github.com/repos/biometrics/openbr/issues/216/comments","statuses_url":"https://api.github.com/repos/biometrics/openbr/statuses/cc6651c380df092ca486ce31e535fc225f48694f","head":{"label":"biometrics:serialization_update","ref":"serialization_update","sha":"cc6651c380df092ca486ce31e535fc225f48694f","user":{"login":"biometrics","id":94188,"avatar_url":"https://avatars.githubusercontent.com/u/94188?","gravatar_id":"6da04b59ac7cf46ee9584891a5a66885","url":"https://api.github.com/users/biometrics","html_url":"https://github.com/biometrics","followers_url":"https://api.github.com/users/biometrics/followers","following_url":"https://api.github.com/users/biometrics/following{/other_user}","gists_url":"https://api.github.com/users/biometrics/gists{/gist_id}","starred_url":"https://api.github.com/users/biometrics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biometrics/subscriptions","organizations_url":"https://api.github.com/users/biometrics/orgs","repos_url":"https://api.github.com/users/biometrics/repos","events_url":"https://api.github.com/users/biometrics/events{/privacy}","received_events_url":"https://api.github.com/users/biometrics/received_events","type":"Organization","site_admin":false},"repo":{"id":7251195,"name":"openbr","full_name":"biometrics/openbr","owner":{"login":"biometrics","id":94188,"avatar_url":"https://avatars.githubusercontent.com/u/94188?","gravatar_id":"6da04b59ac7cf46ee9584891a5a66885","url":"https://api.github.com/users/biometrics","html_url":"https://github.com/biometrics","followers_url":"https://api.github.com/users/biometrics/followers","following_url":"https://api.github.com/users/biometrics/following{/other_user}","gists_url":"https://api.github.com/users/biometrics/gists{/gist_id}","starred_url":"https://api.github.com/users/biometrics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biometrics/subscriptions","organizations_url":"https://api.github.com/users/biometrics/orgs","repos_url":"https://api.github.com/users/biometrics/repos","events_url":"https://api.github.com/users/biometrics/events{/privacy}","received_events_url":"https://api.github.com/users/biometrics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/biometrics/openbr","description":"Open Source Biometrics, Face Recognition","fork":false,"url":"https://api.github.com/repos/biometrics/openbr","forks_url":"https://api.github.com/repos/biometrics/openbr/forks","keys_url":"https://api.github.com/repos/biometrics/openbr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/biometrics/openbr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/biometrics/openbr/teams","hooks_url":"https://api.github.com/repos/biometrics/openbr/hooks","issue_events_url":"https://api.github.com/repos/biometrics/openbr/issues/events{/number}","events_url":"https://api.github.com/repos/biometrics/openbr/events","assignees_url":"https://api.github.com/repos/biometrics/openbr/assignees{/user}","branches_url":"https://api.github.com/repos/biometrics/openbr/branches{/branch}","tags_url":"https://api.github.com/repos/biometrics/openbr/tags","blobs_url":"https://api.github.com/repos/biometrics/openbr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/biometrics/openbr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/biometrics/openbr/git/refs{/sha}","trees_url":"https://api.github.com/repos/biometrics/openbr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/biometrics/openbr/statuses/{sha}","languages_url":"https://api.github.com/repos/biometrics/openbr/languages","stargazers_url":"https://api.github.com/repos/biometrics/openbr/stargazers","contributors_url":"https://api.github.com/repos/biometrics/openbr/contributors","subscribers_url":"https://api.github.com/repos/biometrics/openbr/subscribers","subscription_url":"https://api.github.com/repos/biometrics/openbr/subscription","commits_url":"https://api.github.com/repos/biometrics/openbr/commits{/sha}","git_commits_url":"https://api.github.com/repos/biometrics/openbr/git/commits{/sha}","comments_url":"https://api.github.com/repos/biometrics/openbr/comments{/number}","issue_comment_url":"https://api.github.com/repos/biometrics/openbr/issues/comments/{number}","contents_url":"https://api.github.com/repos/biometrics/openbr/contents/{+path}","compare_url":"https://api.github.com/repos/biometrics/openbr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/biometrics/openbr/merges","archive_url":"https://api.github.com/repos/biometrics/openbr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/biometrics/openbr/downloads","issues_url":"https://api.github.com/repos/biometrics/openbr/issues{/number}","pulls_url":"https://api.github.com/repos/biometrics/openbr/pulls{/number}","milestones_url":"https://api.github.com/repos/biometrics/openbr/milestones{/number}","notifications_url":"https://api.github.com/repos/biometrics/openbr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/biometrics/openbr/labels{/name}","releases_url":"https://api.github.com/repos/biometrics/openbr/releases{/id}","created_at":"2012-12-20T02:52:37Z","updated_at":"2014-07-11T17:44:42Z","pushed_at":"2014-07-11T19:06:38Z","git_url":"git://github.com/biometrics/openbr.git","ssh_url":"git@github.com:biometrics/openbr.git","clone_url":"https://github.com/biometrics/openbr.git","svn_url":"https://github.com/biometrics/openbr","homepage":"www.openbiometrics.org","size":40934,"stargazers_count":974,"watchers_count":974,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":148,"mirror_url":null,"open_issues_count":13,"forks":148,"open_issues":13,"watchers":974,"default_branch":"master"}},"base":{"label":"biometrics:master","ref":"master","sha":"496bc87cf13aeb66dcdd22377edb5c22c96ff699","user":{"login":"biometrics","id":94188,"avatar_url":"https://avatars.githubusercontent.com/u/94188?","gravatar_id":"6da04b59ac7cf46ee9584891a5a66885","url":"https://api.github.com/users/biometrics","html_url":"https://github.com/biometrics","followers_url":"https://api.github.com/users/biometrics/followers","following_url":"https://api.github.com/users/biometrics/following{/other_user}","gists_url":"https://api.github.com/users/biometrics/gists{/gist_id}","starred_url":"https://api.github.com/users/biometrics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biometrics/subscriptions","organizations_url":"https://api.github.com/users/biometrics/orgs","repos_url":"https://api.github.com/users/biometrics/repos","events_url":"https://api.github.com/users/biometrics/events{/privacy}","received_events_url":"https://api.github.com/users/biometrics/received_events","type":"Organization","site_admin":false},"repo":{"id":7251195,"name":"openbr","full_name":"biometrics/openbr","owner":{"login":"biometrics","id":94188,"avatar_url":"https://avatars.githubusercontent.com/u/94188?","gravatar_id":"6da04b59ac7cf46ee9584891a5a66885","url":"https://api.github.com/users/biometrics","html_url":"https://github.com/biometrics","followers_url":"https://api.github.com/users/biometrics/followers","following_url":"https://api.github.com/users/biometrics/following{/other_user}","gists_url":"https://api.github.com/users/biometrics/gists{/gist_id}","starred_url":"https://api.github.com/users/biometrics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biometrics/subscriptions","organizations_url":"https://api.github.com/users/biometrics/orgs","repos_url":"https://api.github.com/users/biometrics/repos","events_url":"https://api.github.com/users/biometrics/events{/privacy}","received_events_url":"https://api.github.com/users/biometrics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/biometrics/openbr","description":"Open Source Biometrics, Face Recognition","fork":false,"url":"https://api.github.com/repos/biometrics/openbr","forks_url":"https://api.github.com/repos/biometrics/openbr/forks","keys_url":"https://api.github.com/repos/biometrics/openbr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/biometrics/openbr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/biometrics/openbr/teams","hooks_url":"https://api.github.com/repos/biometrics/openbr/hooks","issue_events_url":"https://api.github.com/repos/biometrics/openbr/issues/events{/number}","events_url":"https://api.github.com/repos/biometrics/openbr/events","assignees_url":"https://api.github.com/repos/biometrics/openbr/assignees{/user}","branches_url":"https://api.github.com/repos/biometrics/openbr/branches{/branch}","tags_url":"https://api.github.com/repos/biometrics/openbr/tags","blobs_url":"https://api.github.com/repos/biometrics/openbr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/biometrics/openbr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/biometrics/openbr/git/refs{/sha}","trees_url":"https://api.github.com/repos/biometrics/openbr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/biometrics/openbr/statuses/{sha}","languages_url":"https://api.github.com/repos/biometrics/openbr/languages","stargazers_url":"https://api.github.com/repos/biometrics/openbr/stargazers","contributors_url":"https://api.github.com/repos/biometrics/openbr/contributors","subscribers_url":"https://api.github.com/repos/biometrics/openbr/subscribers","subscription_url":"https://api.github.com/repos/biometrics/openbr/subscription","commits_url":"https://api.github.com/repos/biometrics/openbr/commits{/sha}","git_commits_url":"https://api.github.com/repos/biometrics/openbr/git/commits{/sha}","comments_url":"https://api.github.com/repos/biometrics/openbr/comments{/number}","issue_comment_url":"https://api.github.com/repos/biometrics/openbr/issues/comments/{number}","contents_url":"https://api.github.com/repos/biometrics/openbr/contents/{+path}","compare_url":"https://api.github.com/repos/biometrics/openbr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/biometrics/openbr/merges","archive_url":"https://api.github.com/repos/biometrics/openbr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/biometrics/openbr/downloads","issues_url":"https://api.github.com/repos/biometrics/openbr/issues{/number}","pulls_url":"https://api.github.com/repos/biometrics/openbr/pulls{/number}","milestones_url":"https://api.github.com/repos/biometrics/openbr/milestones{/number}","notifications_url":"https://api.github.com/repos/biometrics/openbr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/biometrics/openbr/labels{/name}","releases_url":"https://api.github.com/repos/biometrics/openbr/releases{/id}","created_at":"2012-12-20T02:52:37Z","updated_at":"2014-07-11T17:44:42Z","pushed_at":"2014-07-11T19:06:38Z","git_url":"git://github.com/biometrics/openbr.git","ssh_url":"git@github.com:biometrics/openbr.git","clone_url":"https://github.com/biometrics/openbr.git","svn_url":"https://github.com/biometrics/openbr","homepage":"www.openbiometrics.org","size":40934,"stargazers_count":974,"watchers_count":974,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":148,"mirror_url":null,"open_issues_count":13,"forks":148,"open_issues":13,"watchers":974,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/biometrics/openbr/pulls/216"},"html":{"href":"https://github.com/biometrics/openbr/pull/216"},"issue":{"href":"https://api.github.com/repos/biometrics/openbr/issues/216"},"comments":{"href":"https://api.github.com/repos/biometrics/openbr/issues/216/comments"},"review_comments":{"href":"https://api.github.com/repos/biometrics/openbr/pulls/216/comments"},"review_comment":{"href":"https://api.github.com/repos/biometrics/openbr/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/biometrics/openbr/pulls/216/commits"},"statuses":{"href":"https://api.github.com/repos/biometrics/openbr/statuses/cc6651c380df092ca486ce31e535fc225f48694f"}}}}