GitHub PullRequestReviewCommentEvent at 2014-03-25 20:43:27
Repository: stratosphere
Actor: StephanEwen
Payload: {"comment":{"url":"https://api.github.com/repos/stratosphere/stratosphere/pulls/comments/10952275","id":10952275,"diff_hunk":"@@ -0,0 +1,41 @@\n+/***********************************************************************************************************************","path":"stratosphere-java/src/main/java/eu/stratosphere/api/java/typeutils/runtime/DummySerializerFactory.java","position":1,"original_position":1,"commit_id":"b38ad93910b7d9d0517c0da1e866de2f8ad13d84","original_commit_id":"b38ad93910b7d9d0517c0da1e866de2f8ad13d84","user":{"login":"StephanEwen","id":1727146,"avatar_url":"https://avatars.githubusercontent.com/u/1727146?","gravatar_id":"8ebc798d33195e7ac63c81f25c1eb865","url":"https://api.github.com/users/StephanEwen","html_url":"https://github.com/StephanEwen","followers_url":"https://api.github.com/users/StephanEwen/followers","following_url":"https://api.github.com/users/StephanEwen/following{/other_user}","gists_url":"https://api.github.com/users/StephanEwen/gists{/gist_id}","starred_url":"https://api.github.com/users/StephanEwen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StephanEwen/subscriptions","organizations_url":"https://api.github.com/users/StephanEwen/orgs","repos_url":"https://api.github.com/users/StephanEwen/repos","events_url":"https://api.github.com/users/StephanEwen/events{/privacy}","received_events_url":"https://api.github.com/users/StephanEwen/received_events","type":"User","site_admin":false},"body":"I am surprised that this works. If the factory is ever used, it will at some point be used to create a serializer. It then returns null and causes a NullPointerException. I think you really need a NullSerializer (or discarding serializer), rather than a factory that returns null.","created_at":"2014-03-25T20:43:27Z","updated_at":"2014-03-25T20:43:27Z","html_url":"https://github.com/stratosphere/stratosphere/pull/627#discussion_r10952275","pull_request_url":"https://api.github.com/repos/stratosphere/stratosphere/pulls/627","_links":{"self":{"href":"https://api.github.com/repos/stratosphere/stratosphere/pulls/comments/10952275"},"html":{"href":"https://github.com/stratosphere/stratosphere/pull/627#discussion_r10952275"},"pull_request":{"href":"https://api.github.com/repos/stratosphere/stratosphere/pulls/627"}}}}