GitHub PullRequestReviewCommentEvent at 2014-07-08 12:09:48
Repository: symfony
Actor: stof
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/symfony/symfony/pulls/comments/14649056","id":14649056,"diff_hunk":"@@ -35,9 +37,23 @@ public static function getSubscribedEvents()\n         return array(FormEvents::POST_SUBMIT => 'validateForm');\n     }\n \n-    public function __construct(ValidatorInterface $validator, ViolationMapperInterface $violationMapper)\n+    /**\n+     * @param  ValidatorInterface                                         $validator       The validator requires an instance of ValidatorInterface\n+     *                                                                                     since 2.5 instance of {@link Symfony\\Component\\Validator\\Validator\\ValidatorInterface}\n+     *                                                                                     until 2.4 instance of {@link Symfony\\Component\\Validator\\ValidatorInterface}","path":"src/Symfony/Component/Form/Extension/Validator/EventListener/ValidationListener.php","position":20,"original_position":20,"commit_id":"0a1e9c208f8730219bebf89f6696b246a0c88da7","original_commit_id":"0a1e9c208f8730219bebf89f6696b246a0c88da7","user":{"login":"stof","id":439401,"avatar_url":"https://avatars.githubusercontent.com/u/439401?","gravatar_id":"7894bbdf1c05b18a1444ad8c76c9d583","url":"https://api.github.com/users/stof","html_url":"https://github.com/stof","followers_url":"https://api.github.com/users/stof/followers","following_url":"https://api.github.com/users/stof/following{/other_user}","gists_url":"https://api.github.com/users/stof/gists{/gist_id}","starred_url":"https://api.github.com/users/stof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stof/subscriptions","organizations_url":"https://api.github.com/users/stof/orgs","repos_url":"https://api.github.com/users/stof/repos","events_url":"https://api.github.com/users/stof/events{/privacy}","received_events_url":"https://api.github.com/users/stof/received_events","type":"User","site_admin":false},"body":"This should be removed, as it is wrong. In Symfony 2.5, we have both interfaces (and in 2.4, we won't have this code as this is something which will be merged in 2.5)","created_at":"2014-07-08T12:09:48Z","updated_at":"2014-07-08T12:09:48Z","html_url":"https://github.com/symfony/symfony/pull/11350#discussion_r14649056","pull_request_url":"https://api.github.com/repos/symfony/symfony/pulls/11350","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/14649056"},"html":{"href":"https://github.com/symfony/symfony/pull/11350#discussion_r14649056"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony/pulls/11350"}}},"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/11350","id":18097498,"html_url":"https://github.com/symfony/symfony/pull/11350","diff_url":"https://github.com/symfony/symfony/pull/11350.diff","patch_url":"https://github.com/symfony/symfony/pull/11350.patch","issue_url":"https://api.github.com/repos/symfony/symfony/issues/11350","number":11350,"state":"open","title":"[Form] solved dependency to ValidatorInterface, fix #11036","user":{"login":"sebastianblum","id":551751,"avatar_url":"https://avatars.githubusercontent.com/u/551751?","gravatar_id":"aedf1b41ec8eab7598a3d472c91da314","url":"https://api.github.com/users/sebastianblum","html_url":"https://github.com/sebastianblum","followers_url":"https://api.github.com/users/sebastianblum/followers","following_url":"https://api.github.com/users/sebastianblum/following{/other_user}","gists_url":"https://api.github.com/users/sebastianblum/gists{/gist_id}","starred_url":"https://api.github.com/users/sebastianblum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebastianblum/subscriptions","organizations_url":"https://api.github.com/users/sebastianblum/orgs","repos_url":"https://api.github.com/users/sebastianblum/repos","events_url":"https://api.github.com/users/sebastianblum/events{/privacy}","received_events_url":"https://api.github.com/users/sebastianblum/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Bug fix?      | [yes]\r\n| New feature?  | [no]\r\n| BC breaks?    | [no]\r\n| Deprecations? | [no]\r\n| Tests pass?   | [yes]\r\n| Fixed tickets | #11036, #11345\r\n| License       | MIT\r\n| Doc PR        | \r\n\r\nSince Symfony 2.5\r\n\r\nThe problem was that the form component has a hardcoded decency to the deprecated validator component.\r\nThe pull request fixes the dependency to the validator component and supports now both implementations.\r\n\r\n@Symfony Core Members\r\nplease review the changes https://github.com/sebastianblum/symfony/blob/0a1e9c208f8730219bebf89f6696b246a0c88da7/src/Symfony/Component/Form/Extension/Validator/ValidatorExtension.php\r\nI'm not sure if it was the right solution\r\n","created_at":"2014-07-08T11:54:02Z","updated_at":"2014-07-08T12:09:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"66289617cefa9edb3e5db30e7f8e5e018cd6607a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/symfony/symfony/pulls/11350/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony/pulls/11350/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony/pulls/comments/{number}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/11350/comments","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/0a1e9c208f8730219bebf89f6696b246a0c88da7","head":{"label":"sebastianblum:master","ref":"master","sha":"0a1e9c208f8730219bebf89f6696b246a0c88da7","user":{"login":"sebastianblum","id":551751,"avatar_url":"https://avatars.githubusercontent.com/u/551751?","gravatar_id":"aedf1b41ec8eab7598a3d472c91da314","url":"https://api.github.com/users/sebastianblum","html_url":"https://github.com/sebastianblum","followers_url":"https://api.github.com/users/sebastianblum/followers","following_url":"https://api.github.com/users/sebastianblum/following{/other_user}","gists_url":"https://api.github.com/users/sebastianblum/gists{/gist_id}","starred_url":"https://api.github.com/users/sebastianblum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebastianblum/subscriptions","organizations_url":"https://api.github.com/users/sebastianblum/orgs","repos_url":"https://api.github.com/users/sebastianblum/repos","events_url":"https://api.github.com/users/sebastianblum/events{/privacy}","received_events_url":"https://api.github.com/users/sebastianblum/received_events","type":"User","site_admin":false},"repo":{"id":21607159,"name":"symfony","full_name":"sebastianblum/symfony","owner":{"login":"sebastianblum","id":551751,"avatar_url":"https://avatars.githubusercontent.com/u/551751?","gravatar_id":"aedf1b41ec8eab7598a3d472c91da314","url":"https://api.github.com/users/sebastianblum","html_url":"https://github.com/sebastianblum","followers_url":"https://api.github.com/users/sebastianblum/followers","following_url":"https://api.github.com/users/sebastianblum/following{/other_user}","gists_url":"https://api.github.com/users/sebastianblum/gists{/gist_id}","starred_url":"https://api.github.com/users/sebastianblum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebastianblum/subscriptions","organizations_url":"https://api.github.com/users/sebastianblum/orgs","repos_url":"https://api.github.com/users/sebastianblum/repos","events_url":"https://api.github.com/users/sebastianblum/events{/privacy}","received_events_url":"https://api.github.com/users/sebastianblum/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sebastianblum/symfony","description":"The Symfony PHP framework","fork":true,"url":"https://api.github.com/repos/sebastianblum/symfony","forks_url":"https://api.github.com/repos/sebastianblum/symfony/forks","keys_url":"https://api.github.com/repos/sebastianblum/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sebastianblum/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sebastianblum/symfony/teams","hooks_url":"https://api.github.com/repos/sebastianblum/symfony/hooks","issue_events_url":"https://api.github.com/repos/sebastianblum/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/sebastianblum/symfony/events","assignees_url":"https://api.github.com/repos/sebastianblum/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/sebastianblum/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/sebastianblum/symfony/tags","blobs_url":"https://api.github.com/repos/sebastianblum/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sebastianblum/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sebastianblum/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/sebastianblum/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sebastianblum/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/sebastianblum/symfony/languages","stargazers_url":"https://api.github.com/repos/sebastianblum/symfony/stargazers","contributors_url":"https://api.github.com/repos/sebastianblum/symfony/contributors","subscribers_url":"https://api.github.com/repos/sebastianblum/symfony/subscribers","subscription_url":"https://api.github.com/repos/sebastianblum/symfony/subscription","commits_url":"https://api.github.com/repos/sebastianblum/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/sebastianblum/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/sebastianblum/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/sebastianblum/symfony/issues/comments/{number}","contents_url":"https://api.github.com/repos/sebastianblum/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/sebastianblum/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sebastianblum/symfony/merges","archive_url":"https://api.github.com/repos/sebastianblum/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sebastianblum/symfony/downloads","issues_url":"https://api.github.com/repos/sebastianblum/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/sebastianblum/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/sebastianblum/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/sebastianblum/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sebastianblum/symfony/labels{/name}","releases_url":"https://api.github.com/repos/sebastianblum/symfony/releases{/id}","created_at":"2014-07-08T09:36:31Z","updated_at":"2014-07-08T11:46:20Z","pushed_at":"2014-07-08T11:46:14Z","git_url":"git://github.com/sebastianblum/symfony.git","ssh_url":"git@github.com:sebastianblum/symfony.git","clone_url":"https://github.com/sebastianblum/symfony.git","svn_url":"https://github.com/sebastianblum/symfony","homepage":"symfony.com","size":157162,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":false,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"symfony:master","ref":"master","sha":"9d6817e43c97ae88041f197792ed9eae51816188","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?","gravatar_id":"bc6312a5b583c4258c9fad11122c6e31","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":458058,"name":"symfony","full_name":"symfony/symfony","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?","gravatar_id":"bc6312a5b583c4258c9fad11122c6e31","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony","description":"The Symfony PHP framework","fork":false,"url":"https://api.github.com/repos/symfony/symfony","forks_url":"https://api.github.com/repos/symfony/symfony/forks","keys_url":"https://api.github.com/repos/symfony/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony/teams","hooks_url":"https://api.github.com/repos/symfony/symfony/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony/events","assignees_url":"https://api.github.com/repos/symfony/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony/tags","blobs_url":"https://api.github.com/repos/symfony/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony/subscription","commits_url":"https://api.github.com/repos/symfony/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony/issues/comments/{number}","contents_url":"https://api.github.com/repos/symfony/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony/merges","archive_url":"https://api.github.com/repos/symfony/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony/downloads","issues_url":"https://api.github.com/repos/symfony/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony/releases{/id}","created_at":"2010-01-04T14:21:21Z","updated_at":"2014-07-08T07:10:35Z","pushed_at":"2014-07-08T11:55:43Z","git_url":"git://github.com/symfony/symfony.git","ssh_url":"git@github.com:symfony/symfony.git","clone_url":"https://github.com/symfony/symfony.git","svn_url":"https://github.com/symfony/symfony","homepage":"symfony.com","size":157162,"stargazers_count":8570,"watchers_count":8570,"language":"PHP","has_issues":true,"has_downloads":false,"has_wiki":false,"forks_count":3288,"mirror_url":null,"open_issues_count":804,"forks":3288,"open_issues":804,"watchers":8570,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/11350"},"html":{"href":"https://github.com/symfony/symfony/pull/11350"},"issue":{"href":"https://api.github.com/repos/symfony/symfony/issues/11350"},"comments":{"href":"https://api.github.com/repos/symfony/symfony/issues/11350/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony/pulls/11350/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony/pulls/11350/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony/statuses/0a1e9c208f8730219bebf89f6696b246a0c88da7"}}}}