GitHub PullRequestReviewCommentEvent at 2014-11-26 11:43:47
Repository: puppet-php
Actor: globin
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/Mayflower/puppet-php/pulls/comments/20929936","id":20929936,"diff_hunk":"@@ -93,18 +93,11 @@\n     config => $real_settings\n   }\n \n-  # FIXME: On Ubuntu/Debian systems we use the mods-available folder and have\n-  # to enable settings files ourselves\n+  # Ubuntu/Debian systems use the mods-available folder. We need to enable\n+  # settings files ourselves with php5enmod command.\n   if $::osfamily == 'Debian' and versioncmp($::php_version, '5.4') >= 0 {\n-    $symlinks = [\"${php::params::config_root}/cli/conf.d/20-${lowercase_title}.ini\"]\n-    $real_symlinks = concat($symlinks, $php::fpm ? {\n-      true    => [\"${php::params::config_root}/fpm/conf.d/20-${lowercase_title}.ini\"],\n-      default => [],\n-    })\n-\n-    file { $real_symlinks:\n-      ensure  => link,\n-      target  => $php_settings_file,\n+    exec { \"php5enmod ${lowercase_title}\":\n+      unless  => \"test -L ${php::params::config_root}/conf.d/*-${lowercase_title}.ini\",","path":"manifests/extension.pp","position":19,"original_position":19,"commit_id":"3c4e0eaf22913923788276bd822f2d06409d175c","original_commit_id":"3c4e0eaf22913923788276bd822f2d06409d175c","user":{"login":"globin","id":1447245,"avatar_url":"https://avatars.githubusercontent.com/u/1447245?v=3","gravatar_id":"","url":"https://api.github.com/users/globin","html_url":"https://github.com/globin","followers_url":"https://api.github.com/users/globin/followers","following_url":"https://api.github.com/users/globin/following{/other_user}","gists_url":"https://api.github.com/users/globin/gists{/gist_id}","starred_url":"https://api.github.com/users/globin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/globin/subscriptions","organizations_url":"https://api.github.com/users/globin/orgs","repos_url":"https://api.github.com/users/globin/repos","events_url":"https://api.github.com/users/globin/events{/privacy}","received_events_url":"https://api.github.com/users/globin/received_events","type":"User","site_admin":false},"body":"This check does not work, the links are in `/etc/php5/$sapi/conf.d/XX-ext.ini`.","created_at":"2014-11-26T11:43:47Z","updated_at":"2014-11-26T11:43:47Z","html_url":"https://github.com/Mayflower/puppet-php/pull/38#discussion_r20929936","pull_request_url":"https://api.github.com/repos/Mayflower/puppet-php/pulls/38","_links":{"self":{"href":"https://api.github.com/repos/Mayflower/puppet-php/pulls/comments/20929936"},"html":{"href":"https://github.com/Mayflower/puppet-php/pull/38#discussion_r20929936"},"pull_request":{"href":"https://api.github.com/repos/Mayflower/puppet-php/pulls/38"}}},"pull_request":{"url":"https://api.github.com/repos/Mayflower/puppet-php/pulls/38","id":25076317,"html_url":"https://github.com/Mayflower/puppet-php/pull/38","diff_url":"https://github.com/Mayflower/puppet-php/pull/38.diff","patch_url":"https://github.com/Mayflower/puppet-php/pull/38.patch","issue_url":"https://api.github.com/repos/Mayflower/puppet-php/issues/38","number":38,"state":"open","locked":false,"title":"Leverage php5enmod for Debian systems","user":{"login":"jonhattan","id":482058,"avatar_url":"https://avatars.githubusercontent.com/u/482058?v=3","gravatar_id":"","url":"https://api.github.com/users/jonhattan","html_url":"https://github.com/jonhattan","followers_url":"https://api.github.com/users/jonhattan/followers","following_url":"https://api.github.com/users/jonhattan/following{/other_user}","gists_url":"https://api.github.com/users/jonhattan/gists{/gist_id}","starred_url":"https://api.github.com/users/jonhattan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonhattan/subscriptions","organizations_url":"https://api.github.com/users/jonhattan/orgs","repos_url":"https://api.github.com/users/jonhattan/repos","events_url":"https://api.github.com/users/jonhattan/events{/privacy}","received_events_url":"https://api.github.com/users/jonhattan/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-11-26T11:12:32Z","updated_at":"2014-11-26T11:43:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5ad2d22b516e604e5a842eb31c466e9bee433251","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Mayflower/puppet-php/pulls/38/commits","review_comments_url":"https://api.github.com/repos/Mayflower/puppet-php/pulls/38/comments","review_comment_url":"https://api.github.com/repos/Mayflower/puppet-php/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Mayflower/puppet-php/issues/38/comments","statuses_url":"https://api.github.com/repos/Mayflower/puppet-php/statuses/3c4e0eaf22913923788276bd822f2d06409d175c","head":{"label":"jonhattan:extensions-priority","ref":"extensions-priority","sha":"3c4e0eaf22913923788276bd822f2d06409d175c","user":{"login":"jonhattan","id":482058,"avatar_url":"https://avatars.githubusercontent.com/u/482058?v=3","gravatar_id":"","url":"https://api.github.com/users/jonhattan","html_url":"https://github.com/jonhattan","followers_url":"https://api.github.com/users/jonhattan/followers","following_url":"https://api.github.com/users/jonhattan/following{/other_user}","gists_url":"https://api.github.com/users/jonhattan/gists{/gist_id}","starred_url":"https://api.github.com/users/jonhattan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonhattan/subscriptions","organizations_url":"https://api.github.com/users/jonhattan/orgs","repos_url":"https://api.github.com/users/jonhattan/repos","events_url":"https://api.github.com/users/jonhattan/events{/privacy}","received_events_url":"https://api.github.com/users/jonhattan/received_events","type":"User","site_admin":false},"repo":{"id":25461083,"name":"puppet-php","full_name":"jonhattan/puppet-php","owner":{"login":"jonhattan","id":482058,"avatar_url":"https://avatars.githubusercontent.com/u/482058?v=3","gravatar_id":"","url":"https://api.github.com/users/jonhattan","html_url":"https://github.com/jonhattan","followers_url":"https://api.github.com/users/jonhattan/followers","following_url":"https://api.github.com/users/jonhattan/following{/other_user}","gists_url":"https://api.github.com/users/jonhattan/gists{/gist_id}","starred_url":"https://api.github.com/users/jonhattan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonhattan/subscriptions","organizations_url":"https://api.github.com/users/jonhattan/orgs","repos_url":"https://api.github.com/users/jonhattan/repos","events_url":"https://api.github.com/users/jonhattan/events{/privacy}","received_events_url":"https://api.github.com/users/jonhattan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jonhattan/puppet-php","description":"Puppet module to manage PHP FPM on Debian, Ubuntu, RedHat/CentOS, SuSE","fork":true,"url":"https://api.github.com/repos/jonhattan/puppet-php","forks_url":"https://api.github.com/repos/jonhattan/puppet-php/forks","keys_url":"https://api.github.com/repos/jonhattan/puppet-php/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jonhattan/puppet-php/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jonhattan/puppet-php/teams","hooks_url":"https://api.github.com/repos/jonhattan/puppet-php/hooks","issue_events_url":"https://api.github.com/repos/jonhattan/puppet-php/issues/events{/number}","events_url":"https://api.github.com/repos/jonhattan/puppet-php/events","assignees_url":"https://api.github.com/repos/jonhattan/puppet-php/assignees{/user}","branches_url":"https://api.github.com/repos/jonhattan/puppet-php/branches{/branch}","tags_url":"https://api.github.com/repos/jonhattan/puppet-php/tags","blobs_url":"https://api.github.com/repos/jonhattan/puppet-php/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jonhattan/puppet-php/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jonhattan/puppet-php/git/refs{/sha}","trees_url":"https://api.github.com/repos/jonhattan/puppet-php/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jonhattan/puppet-php/statuses/{sha}","languages_url":"https://api.github.com/repos/jonhattan/puppet-php/languages","stargazers_url":"https://api.github.com/repos/jonhattan/puppet-php/stargazers","contributors_url":"https://api.github.com/repos/jonhattan/puppet-php/contributors","subscribers_url":"https://api.github.com/repos/jonhattan/puppet-php/subscribers","subscription_url":"https://api.github.com/repos/jonhattan/puppet-php/subscription","commits_url":"https://api.github.com/repos/jonhattan/puppet-php/commits{/sha}","git_commits_url":"https://api.github.com/repos/jonhattan/puppet-php/git/commits{/sha}","comments_url":"https://api.github.com/repos/jonhattan/puppet-php/comments{/number}","issue_comment_url":"https://api.github.com/repos/jonhattan/puppet-php/issues/comments/{number}","contents_url":"https://api.github.com/repos/jonhattan/puppet-php/contents/{+path}","compare_url":"https://api.github.com/repos/jonhattan/puppet-php/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jonhattan/puppet-php/merges","archive_url":"https://api.github.com/repos/jonhattan/puppet-php/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jonhattan/puppet-php/downloads","issues_url":"https://api.github.com/repos/jonhattan/puppet-php/issues{/number}","pulls_url":"https://api.github.com/repos/jonhattan/puppet-php/pulls{/number}","milestones_url":"https://api.github.com/repos/jonhattan/puppet-php/milestones{/number}","notifications_url":"https://api.github.com/repos/jonhattan/puppet-php/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jonhattan/puppet-php/labels{/name}","releases_url":"https://api.github.com/repos/jonhattan/puppet-php/releases{/id}","created_at":"2014-10-20T10:16:13Z","updated_at":"2014-11-26T11:43:05Z","pushed_at":"2014-11-26T11:43:05Z","git_url":"git://github.com/jonhattan/puppet-php.git","ssh_url":"git@github.com:jonhattan/puppet-php.git","clone_url":"https://github.com/jonhattan/puppet-php.git","svn_url":"https://github.com/jonhattan/puppet-php","homepage":"https://forge.puppetlabs.com/mayflower/php","size":590,"stargazers_count":0,"watchers_count":0,"language":"Puppet","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Mayflower:master","ref":"master","sha":"5e7e643b16283b07621adf51c5d080e49ee1c5f6","user":{"login":"Mayflower","id":536878,"avatar_url":"https://avatars.githubusercontent.com/u/536878?v=3","gravatar_id":"","url":"https://api.github.com/users/Mayflower","html_url":"https://github.com/Mayflower","followers_url":"https://api.github.com/users/Mayflower/followers","following_url":"https://api.github.com/users/Mayflower/following{/other_user}","gists_url":"https://api.github.com/users/Mayflower/gists{/gist_id}","starred_url":"https://api.github.com/users/Mayflower/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mayflower/subscriptions","organizations_url":"https://api.github.com/users/Mayflower/orgs","repos_url":"https://api.github.com/users/Mayflower/repos","events_url":"https://api.github.com/users/Mayflower/events{/privacy}","received_events_url":"https://api.github.com/users/Mayflower/received_events","type":"Organization","site_admin":false},"repo":{"id":16954722,"name":"puppet-php","full_name":"Mayflower/puppet-php","owner":{"login":"Mayflower","id":536878,"avatar_url":"https://avatars.githubusercontent.com/u/536878?v=3","gravatar_id":"","url":"https://api.github.com/users/Mayflower","html_url":"https://github.com/Mayflower","followers_url":"https://api.github.com/users/Mayflower/followers","following_url":"https://api.github.com/users/Mayflower/following{/other_user}","gists_url":"https://api.github.com/users/Mayflower/gists{/gist_id}","starred_url":"https://api.github.com/users/Mayflower/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mayflower/subscriptions","organizations_url":"https://api.github.com/users/Mayflower/orgs","repos_url":"https://api.github.com/users/Mayflower/repos","events_url":"https://api.github.com/users/Mayflower/events{/privacy}","received_events_url":"https://api.github.com/users/Mayflower/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Mayflower/puppet-php","description":"Puppet module to manage PHP FPM on Debian, Ubuntu, RedHat/CentOS, SuSE","fork":false,"url":"https://api.github.com/repos/Mayflower/puppet-php","forks_url":"https://api.github.com/repos/Mayflower/puppet-php/forks","keys_url":"https://api.github.com/repos/Mayflower/puppet-php/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Mayflower/puppet-php/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Mayflower/puppet-php/teams","hooks_url":"https://api.github.com/repos/Mayflower/puppet-php/hooks","issue_events_url":"https://api.github.com/repos/Mayflower/puppet-php/issues/events{/number}","events_url":"https://api.github.com/repos/Mayflower/puppet-php/events","assignees_url":"https://api.github.com/repos/Mayflower/puppet-php/assignees{/user}","branches_url":"https://api.github.com/repos/Mayflower/puppet-php/branches{/branch}","tags_url":"https://api.github.com/repos/Mayflower/puppet-php/tags","blobs_url":"https://api.github.com/repos/Mayflower/puppet-php/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Mayflower/puppet-php/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Mayflower/puppet-php/git/refs{/sha}","trees_url":"https://api.github.com/repos/Mayflower/puppet-php/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Mayflower/puppet-php/statuses/{sha}","languages_url":"https://api.github.com/repos/Mayflower/puppet-php/languages","stargazers_url":"https://api.github.com/repos/Mayflower/puppet-php/stargazers","contributors_url":"https://api.github.com/repos/Mayflower/puppet-php/contributors","subscribers_url":"https://api.github.com/repos/Mayflower/puppet-php/subscribers","subscription_url":"https://api.github.com/repos/Mayflower/puppet-php/subscription","commits_url":"https://api.github.com/repos/Mayflower/puppet-php/commits{/sha}","git_commits_url":"https://api.github.com/repos/Mayflower/puppet-php/git/commits{/sha}","comments_url":"https://api.github.com/repos/Mayflower/puppet-php/comments{/number}","issue_comment_url":"https://api.github.com/repos/Mayflower/puppet-php/issues/comments/{number}","contents_url":"https://api.github.com/repos/Mayflower/puppet-php/contents/{+path}","compare_url":"https://api.github.com/repos/Mayflower/puppet-php/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Mayflower/puppet-php/merges","archive_url":"https://api.github.com/repos/Mayflower/puppet-php/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Mayflower/puppet-php/downloads","issues_url":"https://api.github.com/repos/Mayflower/puppet-php/issues{/number}","pulls_url":"https://api.github.com/repos/Mayflower/puppet-php/pulls{/number}","milestones_url":"https://api.github.com/repos/Mayflower/puppet-php/milestones{/number}","notifications_url":"https://api.github.com/repos/Mayflower/puppet-php/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Mayflower/puppet-php/labels{/name}","releases_url":"https://api.github.com/repos/Mayflower/puppet-php/releases{/id}","created_at":"2014-02-18T16:06:24Z","updated_at":"2014-11-16T05:21:37Z","pushed_at":"2014-10-20T12:17:35Z","git_url":"git://github.com/Mayflower/puppet-php.git","ssh_url":"git@github.com:Mayflower/puppet-php.git","clone_url":"https://github.com/Mayflower/puppet-php.git","svn_url":"https://github.com/Mayflower/puppet-php","homepage":"https://forge.puppetlabs.com/mayflower/php","size":1708,"stargazers_count":17,"watchers_count":17,"language":"Puppet","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":6,"forks":13,"open_issues":6,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Mayflower/puppet-php/pulls/38"},"html":{"href":"https://github.com/Mayflower/puppet-php/pull/38"},"issue":{"href":"https://api.github.com/repos/Mayflower/puppet-php/issues/38"},"comments":{"href":"https://api.github.com/repos/Mayflower/puppet-php/issues/38/comments"},"review_comments":{"href":"https://api.github.com/repos/Mayflower/puppet-php/pulls/38/comments"},"review_comment":{"href":"https://api.github.com/repos/Mayflower/puppet-php/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Mayflower/puppet-php/pulls/38/commits"},"statuses":{"href":"https://api.github.com/repos/Mayflower/puppet-php/statuses/3c4e0eaf22913923788276bd822f2d06409d175c"}}}}