GitHub PullRequestEvent at 2014-03-29 19:17:08
Repository: orestes
Actor: scgilardi
Payload: {"action":"opened","number":1,"pull_request":{"url":"https://api.github.com/repos/technomancy/orestes/pulls/1","id":14145441,"html_url":"https://github.com/technomancy/orestes/pull/1","diff_url":"https://github.com/technomancy/orestes/pull/1.diff","patch_url":"https://github.com/technomancy/orestes/pull/1.patch","issue_url":"https://api.github.com/repos/technomancy/orestes/issues/1","number":1,"state":"open","title":"some tweaks to conditionals","user":{"login":"scgilardi","id":87927,"avatar_url":"https://avatars.githubusercontent.com/u/87927?","gravatar_id":"fd6d619db121560f604fde876bb25285","url":"https://api.github.com/users/scgilardi","html_url":"https://github.com/scgilardi","followers_url":"https://api.github.com/users/scgilardi/followers","following_url":"https://api.github.com/users/scgilardi/following{/other_user}","gists_url":"https://api.github.com/users/scgilardi/gists{/gist_id}","starred_url":"https://api.github.com/users/scgilardi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scgilardi/subscriptions","organizations_url":"https://api.github.com/users/scgilardi/orgs","repos_url":"https://api.github.com/users/scgilardi/repos","events_url":"https://api.github.com/users/scgilardi/events{/privacy}","received_events_url":"https://api.github.com/users/scgilardi/received_events","type":"User","site_admin":false},"body":"I noticed a couple of things that look like bugs and suggested a couple of ways to make things clearer.\r\n\r\nAnother general note, the expression x++ \"returns\" the old value of x, while ++x \"returns\" the new value. In the absence of optimizations that arrange to throw away the return value if it's not used, the latter is more efficient. (this matters more in C++ where x++ implies at least an implicit copy of the object before ++ is applied). In my opinion \"Increment x\" is better written as \"++x\" than \"x++\" unless you really need the value before it's incremented.","created_at":"2014-03-29T19:17:07Z","updated_at":"2014-03-29T19:17:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/technomancy/orestes/pulls/1/commits","review_comments_url":"https://api.github.com/repos/technomancy/orestes/pulls/1/comments","review_comment_url":"https://api.github.com/repos/technomancy/orestes/pulls/comments/{number}","comments_url":"https://api.github.com/repos/technomancy/orestes/issues/1/comments","statuses_url":"https://api.github.com/repos/technomancy/orestes/statuses/2a96b9b5a99bb2bb213d827d78297d496c4538b1","head":{"label":"scgilardi:master","ref":"master","sha":"2a96b9b5a99bb2bb213d827d78297d496c4538b1","user":{"login":"scgilardi","id":87927,"avatar_url":"https://avatars.githubusercontent.com/u/87927?","gravatar_id":"fd6d619db121560f604fde876bb25285","url":"https://api.github.com/users/scgilardi","html_url":"https://github.com/scgilardi","followers_url":"https://api.github.com/users/scgilardi/followers","following_url":"https://api.github.com/users/scgilardi/following{/other_user}","gists_url":"https://api.github.com/users/scgilardi/gists{/gist_id}","starred_url":"https://api.github.com/users/scgilardi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scgilardi/subscriptions","organizations_url":"https://api.github.com/users/scgilardi/orgs","repos_url":"https://api.github.com/users/scgilardi/repos","events_url":"https://api.github.com/users/scgilardi/events{/privacy}","received_events_url":"https://api.github.com/users/scgilardi/received_events","type":"User","site_admin":false},"repo":{"id":18248251,"name":"orestes","full_name":"scgilardi/orestes","owner":{"login":"scgilardi","id":87927,"avatar_url":"https://avatars.githubusercontent.com/u/87927?","gravatar_id":"fd6d619db121560f604fde876bb25285","url":"https://api.github.com/users/scgilardi","html_url":"https://github.com/scgilardi","followers_url":"https://api.github.com/users/scgilardi/followers","following_url":"https://api.github.com/users/scgilardi/following{/other_user}","gists_url":"https://api.github.com/users/scgilardi/gists{/gist_id}","starred_url":"https://api.github.com/users/scgilardi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scgilardi/subscriptions","organizations_url":"https://api.github.com/users/scgilardi/orgs","repos_url":"https://api.github.com/users/scgilardi/repos","events_url":"https://api.github.com/users/scgilardi/events{/privacy}","received_events_url":"https://api.github.com/users/scgilardi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/scgilardi/orestes","description":"the ultimate yak shave","fork":true,"url":"https://api.github.com/repos/scgilardi/orestes","forks_url":"https://api.github.com/repos/scgilardi/orestes/forks","keys_url":"https://api.github.com/repos/scgilardi/orestes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scgilardi/orestes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scgilardi/orestes/teams","hooks_url":"https://api.github.com/repos/scgilardi/orestes/hooks","issue_events_url":"https://api.github.com/repos/scgilardi/orestes/issues/events{/number}","events_url":"https://api.github.com/repos/scgilardi/orestes/events","assignees_url":"https://api.github.com/repos/scgilardi/orestes/assignees{/user}","branches_url":"https://api.github.com/repos/scgilardi/orestes/branches{/branch}","tags_url":"https://api.github.com/repos/scgilardi/orestes/tags","blobs_url":"https://api.github.com/repos/scgilardi/orestes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scgilardi/orestes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scgilardi/orestes/git/refs{/sha}","trees_url":"https://api.github.com/repos/scgilardi/orestes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scgilardi/orestes/statuses/{sha}","languages_url":"https://api.github.com/repos/scgilardi/orestes/languages","stargazers_url":"https://api.github.com/repos/scgilardi/orestes/stargazers","contributors_url":"https://api.github.com/repos/scgilardi/orestes/contributors","subscribers_url":"https://api.github.com/repos/scgilardi/orestes/subscribers","subscription_url":"https://api.github.com/repos/scgilardi/orestes/subscription","commits_url":"https://api.github.com/repos/scgilardi/orestes/commits{/sha}","git_commits_url":"https://api.github.com/repos/scgilardi/orestes/git/commits{/sha}","comments_url":"https://api.github.com/repos/scgilardi/orestes/comments{/number}","issue_comment_url":"https://api.github.com/repos/scgilardi/orestes/issues/comments/{number}","contents_url":"https://api.github.com/repos/scgilardi/orestes/contents/{+path}","compare_url":"https://api.github.com/repos/scgilardi/orestes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scgilardi/orestes/merges","archive_url":"https://api.github.com/repos/scgilardi/orestes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scgilardi/orestes/downloads","issues_url":"https://api.github.com/repos/scgilardi/orestes/issues{/number}","pulls_url":"https://api.github.com/repos/scgilardi/orestes/pulls{/number}","milestones_url":"https://api.github.com/repos/scgilardi/orestes/milestones{/number}","notifications_url":"https://api.github.com/repos/scgilardi/orestes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scgilardi/orestes/labels{/name}","releases_url":"https://api.github.com/repos/scgilardi/orestes/releases{/id}","created_at":"2014-03-29T18:53:55Z","updated_at":"2014-03-29T19:17:07Z","pushed_at":"2014-03-29T19:08:36Z","git_url":"git://github.com/scgilardi/orestes.git","ssh_url":"git@github.com:scgilardi/orestes.git","clone_url":"https://github.com/scgilardi/orestes.git","svn_url":"https://github.com/scgilardi/orestes","homepage":null,"size":148,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master","master_branch":"master"}},"base":{"label":"technomancy:master","ref":"master","sha":"fb1c49daf869262751e3c06d43acb7d78e2610ea","user":{"login":"technomancy","id":141,"avatar_url":"https://avatars.githubusercontent.com/u/141?","gravatar_id":"22788ec68b2aee512f8f4c5d8ae819ae","url":"https://api.github.com/users/technomancy","html_url":"https://github.com/technomancy","followers_url":"https://api.github.com/users/technomancy/followers","following_url":"https://api.github.com/users/technomancy/following{/other_user}","gists_url":"https://api.github.com/users/technomancy/gists{/gist_id}","starred_url":"https://api.github.com/users/technomancy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/technomancy/subscriptions","organizations_url":"https://api.github.com/users/technomancy/orgs","repos_url":"https://api.github.com/users/technomancy/repos","events_url":"https://api.github.com/users/technomancy/events{/privacy}","received_events_url":"https://api.github.com/users/technomancy/received_events","type":"User","site_admin":false},"repo":{"id":17963923,"name":"orestes","full_name":"technomancy/orestes","owner":{"login":"technomancy","id":141,"avatar_url":"https://avatars.githubusercontent.com/u/141?","gravatar_id":"22788ec68b2aee512f8f4c5d8ae819ae","url":"https://api.github.com/users/technomancy","html_url":"https://github.com/technomancy","followers_url":"https://api.github.com/users/technomancy/followers","following_url":"https://api.github.com/users/technomancy/following{/other_user}","gists_url":"https://api.github.com/users/technomancy/gists{/gist_id}","starred_url":"https://api.github.com/users/technomancy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/technomancy/subscriptions","organizations_url":"https://api.github.com/users/technomancy/orgs","repos_url":"https://api.github.com/users/technomancy/repos","events_url":"https://api.github.com/users/technomancy/events{/privacy}","received_events_url":"https://api.github.com/users/technomancy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/technomancy/orestes","description":"the ultimate yak shave","fork":false,"url":"https://api.github.com/repos/technomancy/orestes","forks_url":"https://api.github.com/repos/technomancy/orestes/forks","keys_url":"https://api.github.com/repos/technomancy/orestes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/technomancy/orestes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/technomancy/orestes/teams","hooks_url":"https://api.github.com/repos/technomancy/orestes/hooks","issue_events_url":"https://api.github.com/repos/technomancy/orestes/issues/events{/number}","events_url":"https://api.github.com/repos/technomancy/orestes/events","assignees_url":"https://api.github.com/repos/technomancy/orestes/assignees{/user}","branches_url":"https://api.github.com/repos/technomancy/orestes/branches{/branch}","tags_url":"https://api.github.com/repos/technomancy/orestes/tags","blobs_url":"https://api.github.com/repos/technomancy/orestes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/technomancy/orestes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/technomancy/orestes/git/refs{/sha}","trees_url":"https://api.github.com/repos/technomancy/orestes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/technomancy/orestes/statuses/{sha}","languages_url":"https://api.github.com/repos/technomancy/orestes/languages","stargazers_url":"https://api.github.com/repos/technomancy/orestes/stargazers","contributors_url":"https://api.github.com/repos/technomancy/orestes/contributors","subscribers_url":"https://api.github.com/repos/technomancy/orestes/subscribers","subscription_url":"https://api.github.com/repos/technomancy/orestes/subscription","commits_url":"https://api.github.com/repos/technomancy/orestes/commits{/sha}","git_commits_url":"https://api.github.com/repos/technomancy/orestes/git/commits{/sha}","comments_url":"https://api.github.com/repos/technomancy/orestes/comments{/number}","issue_comment_url":"https://api.github.com/repos/technomancy/orestes/issues/comments/{number}","contents_url":"https://api.github.com/repos/technomancy/orestes/contents/{+path}","compare_url":"https://api.github.com/repos/technomancy/orestes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/technomancy/orestes/merges","archive_url":"https://api.github.com/repos/technomancy/orestes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/technomancy/orestes/downloads","issues_url":"https://api.github.com/repos/technomancy/orestes/issues{/number}","pulls_url":"https://api.github.com/repos/technomancy/orestes/pulls{/number}","milestones_url":"https://api.github.com/repos/technomancy/orestes/milestones{/number}","notifications_url":"https://api.github.com/repos/technomancy/orestes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/technomancy/orestes/labels{/name}","releases_url":"https://api.github.com/repos/technomancy/orestes/releases{/id}","created_at":"2014-03-21T01:04:14Z","updated_at":"2014-03-29T05:20:41Z","pushed_at":"2014-03-29T05:20:39Z","git_url":"git://github.com/technomancy/orestes.git","ssh_url":"git@github.com:technomancy/orestes.git","clone_url":"https://github.com/technomancy/orestes.git","svn_url":"https://github.com/technomancy/orestes","homepage":null,"size":148,"stargazers_count":3,"watchers_count":3,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":3,"default_branch":"master","master_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/technomancy/orestes/pulls/1"},"html":{"href":"https://github.com/technomancy/orestes/pull/1"},"issue":{"href":"https://api.github.com/repos/technomancy/orestes/issues/1"},"comments":{"href":"https://api.github.com/repos/technomancy/orestes/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/technomancy/orestes/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/technomancy/orestes/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/technomancy/orestes/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/technomancy/orestes/statuses/2a96b9b5a99bb2bb213d827d78297d496c4538b1"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":3,"additions":5,"deletions":5,"changed_files":1}}