GitHub PullRequestReviewCommentEvent at 2014-11-07 16:56:32
Repository: elasticsearch
Actor: javanna
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/comments/20021948","id":20021948,"diff_hunk":"@@ -74,10 +75,10 @@ protected GetIndexResponse newResponse() {\n     @Override\n     protected void doMasterOperation(final GetIndexRequest request, String[] concreteIndices, final ClusterState state,\n                                      final ActionListener<GetIndexResponse> listener) throws ElasticsearchException {\n-        ImmutableOpenMap<String, ImmutableList<Entry>> warmersResult = ImmutableOpenMap.of();\n-        ImmutableOpenMap<String, ImmutableOpenMap<String, MappingMetaData>> mappingsResult = ImmutableOpenMap.of();\n-        ImmutableOpenMap<String, ImmutableList<AliasMetaData>> aliasesResult = ImmutableOpenMap.of();\n-        ImmutableOpenMap<String, Settings> settings = ImmutableOpenMap.of();\n+        ImmutableOpenMap<String, ImmutableList<Entry>> warmersResult = null;\n+        ImmutableOpenMap<String, ImmutableOpenMap<String, MappingMetaData>> mappingsResult = null;\n+        ImmutableOpenMap<String, ImmutableList<AliasMetaData>> aliasesResult = null;\n+        ImmutableOpenMap<String, Settings> settings = null;","path":"src/main/java/org/elasticsearch/action/admin/indices/get/TransportGetIndexAction.java","position":19,"original_position":19,"commit_id":"e837f0ab81c94e45cefd0bdfb51f977931fbcf4d","original_commit_id":"e837f0ab81c94e45cefd0bdfb51f977931fbcf4d","user":{"login":"javanna","id":832460,"avatar_url":"https://avatars.githubusercontent.com/u/832460?v=3","gravatar_id":"","url":"https://api.github.com/users/javanna","html_url":"https://github.com/javanna","followers_url":"https://api.github.com/users/javanna/followers","following_url":"https://api.github.com/users/javanna/following{/other_user}","gists_url":"https://api.github.com/users/javanna/gists{/gist_id}","starred_url":"https://api.github.com/users/javanna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javanna/subscriptions","organizations_url":"https://api.github.com/users/javanna/orgs","repos_url":"https://api.github.com/users/javanna/repos","events_url":"https://api.github.com/users/javanna/events{/privacy}","received_events_url":"https://api.github.com/users/javanna/received_events","type":"User","site_admin":false},"body":"I tend to prefer the previous version with non null values. But I guess you need to distinguish between stuff that was not asked and stuff that was asked but nothing was found? In the first case nothing in the response while in the second case you would have an empty section in the response?","created_at":"2014-11-07T16:56:32Z","updated_at":"2014-11-07T16:56:32Z","html_url":"https://github.com/elasticsearch/elasticsearch/pull/8392#discussion_r20021948","pull_request_url":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/8392","_links":{"self":{"href":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/comments/20021948"},"html":{"href":"https://github.com/elasticsearch/elasticsearch/pull/8392#discussion_r20021948"},"pull_request":{"href":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/8392"}}},"pull_request":{"url":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/8392","id":24064950,"html_url":"https://github.com/elasticsearch/elasticsearch/pull/8392","diff_url":"https://github.com/elasticsearch/elasticsearch/pull/8392.diff","patch_url":"https://github.com/elasticsearch/elasticsearch/pull/8392.patch","issue_url":"https://api.github.com/repos/elasticsearch/elasticsearch/issues/8392","number":8392,"state":"open","locked":false,"title":"Indices API: Fix GET index API always running all features","user":{"login":"colings86","id":236731,"avatar_url":"https://avatars.githubusercontent.com/u/236731?v=3","gravatar_id":"","url":"https://api.github.com/users/colings86","html_url":"https://github.com/colings86","followers_url":"https://api.github.com/users/colings86/followers","following_url":"https://api.github.com/users/colings86/following{/other_user}","gists_url":"https://api.github.com/users/colings86/gists{/gist_id}","starred_url":"https://api.github.com/users/colings86/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colings86/subscriptions","organizations_url":"https://api.github.com/users/colings86/orgs","repos_url":"https://api.github.com/users/colings86/repos","events_url":"https://api.github.com/users/colings86/events{/privacy}","received_events_url":"https://api.github.com/users/colings86/received_events","type":"User","site_admin":false},"body":"Previous to this change all features (_alias,_mapping,_settings,_warmer) are run regardless of which features are actually requested. This change fixes the request object to resolve this bug","created_at":"2014-11-07T16:40:17Z","updated_at":"2014-11-07T16:56:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4a164948409aedcb25d2c5604089780ab56c449d","assignee":{"login":"colings86","id":236731,"avatar_url":"https://avatars.githubusercontent.com/u/236731?v=3","gravatar_id":"","url":"https://api.github.com/users/colings86","html_url":"https://github.com/colings86","followers_url":"https://api.github.com/users/colings86/followers","following_url":"https://api.github.com/users/colings86/following{/other_user}","gists_url":"https://api.github.com/users/colings86/gists{/gist_id}","starred_url":"https://api.github.com/users/colings86/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colings86/subscriptions","organizations_url":"https://api.github.com/users/colings86/orgs","repos_url":"https://api.github.com/users/colings86/repos","events_url":"https://api.github.com/users/colings86/events{/privacy}","received_events_url":"https://api.github.com/users/colings86/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/8392/commits","review_comments_url":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/8392/comments","review_comment_url":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/comments/{number}","comments_url":"https://api.github.com/repos/elasticsearch/elasticsearch/issues/8392/comments","statuses_url":"https://api.github.com/repos/elasticsearch/elasticsearch/statuses/e837f0ab81c94e45cefd0bdfb51f977931fbcf4d","head":{"label":"colings86:fix/getIndexFeatures","ref":"fix/getIndexFeatures","sha":"e837f0ab81c94e45cefd0bdfb51f977931fbcf4d","user":{"login":"colings86","id":236731,"avatar_url":"https://avatars.githubusercontent.com/u/236731?v=3","gravatar_id":"","url":"https://api.github.com/users/colings86","html_url":"https://github.com/colings86","followers_url":"https://api.github.com/users/colings86/followers","following_url":"https://api.github.com/users/colings86/following{/other_user}","gists_url":"https://api.github.com/users/colings86/gists{/gist_id}","starred_url":"https://api.github.com/users/colings86/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colings86/subscriptions","organizations_url":"https://api.github.com/users/colings86/orgs","repos_url":"https://api.github.com/users/colings86/repos","events_url":"https://api.github.com/users/colings86/events{/privacy}","received_events_url":"https://api.github.com/users/colings86/received_events","type":"User","site_admin":false},"repo":{"id":19935914,"name":"elasticsearch","full_name":"colings86/elasticsearch","owner":{"login":"colings86","id":236731,"avatar_url":"https://avatars.githubusercontent.com/u/236731?v=3","gravatar_id":"","url":"https://api.github.com/users/colings86","html_url":"https://github.com/colings86","followers_url":"https://api.github.com/users/colings86/followers","following_url":"https://api.github.com/users/colings86/following{/other_user}","gists_url":"https://api.github.com/users/colings86/gists{/gist_id}","starred_url":"https://api.github.com/users/colings86/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colings86/subscriptions","organizations_url":"https://api.github.com/users/colings86/orgs","repos_url":"https://api.github.com/users/colings86/repos","events_url":"https://api.github.com/users/colings86/events{/privacy}","received_events_url":"https://api.github.com/users/colings86/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/colings86/elasticsearch","description":"Open Source, Distributed, RESTful Search Engine","fork":true,"url":"https://api.github.com/repos/colings86/elasticsearch","forks_url":"https://api.github.com/repos/colings86/elasticsearch/forks","keys_url":"https://api.github.com/repos/colings86/elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/colings86/elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/colings86/elasticsearch/teams","hooks_url":"https://api.github.com/repos/colings86/elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/colings86/elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/colings86/elasticsearch/events","assignees_url":"https://api.github.com/repos/colings86/elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/colings86/elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/colings86/elasticsearch/tags","blobs_url":"https://api.github.com/repos/colings86/elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/colings86/elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/colings86/elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/colings86/elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/colings86/elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/colings86/elasticsearch/languages","stargazers_url":"https://api.github.com/repos/colings86/elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/colings86/elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/colings86/elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/colings86/elasticsearch/subscription","commits_url":"https://api.github.com/repos/colings86/elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/colings86/elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/colings86/elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/colings86/elasticsearch/issues/comments/{number}","contents_url":"https://api.github.com/repos/colings86/elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/colings86/elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/colings86/elasticsearch/merges","archive_url":"https://api.github.com/repos/colings86/elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/colings86/elasticsearch/downloads","issues_url":"https://api.github.com/repos/colings86/elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/colings86/elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/colings86/elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/colings86/elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/colings86/elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/colings86/elasticsearch/releases{/id}","created_at":"2014-05-19T09:22:57Z","updated_at":"2014-06-30T11:06:32Z","pushed_at":"2014-11-07T16:40:10Z","git_url":"git://github.com/colings86/elasticsearch.git","ssh_url":"git@github.com:colings86/elasticsearch.git","clone_url":"https://github.com/colings86/elasticsearch.git","svn_url":"https://github.com/colings86/elasticsearch","homepage":"http://elasticsearch.org","size":74950,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elasticsearch:master","ref":"master","sha":"3712d979519db5453bea49c34642a391c51d88b3","user":{"login":"elasticsearch","id":141304,"avatar_url":"https://avatars.githubusercontent.com/u/141304?v=3","gravatar_id":"","url":"https://api.github.com/users/elasticsearch","html_url":"https://github.com/elasticsearch","followers_url":"https://api.github.com/users/elasticsearch/followers","following_url":"https://api.github.com/users/elasticsearch/following{/other_user}","gists_url":"https://api.github.com/users/elasticsearch/gists{/gist_id}","starred_url":"https://api.github.com/users/elasticsearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elasticsearch/subscriptions","organizations_url":"https://api.github.com/users/elasticsearch/orgs","repos_url":"https://api.github.com/users/elasticsearch/repos","events_url":"https://api.github.com/users/elasticsearch/events{/privacy}","received_events_url":"https://api.github.com/users/elasticsearch/received_events","type":"Organization","site_admin":false},"repo":{"id":507775,"name":"elasticsearch","full_name":"elasticsearch/elasticsearch","owner":{"login":"elasticsearch","id":141304,"avatar_url":"https://avatars.githubusercontent.com/u/141304?v=3","gravatar_id":"","url":"https://api.github.com/users/elasticsearch","html_url":"https://github.com/elasticsearch","followers_url":"https://api.github.com/users/elasticsearch/followers","following_url":"https://api.github.com/users/elasticsearch/following{/other_user}","gists_url":"https://api.github.com/users/elasticsearch/gists{/gist_id}","starred_url":"https://api.github.com/users/elasticsearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elasticsearch/subscriptions","organizations_url":"https://api.github.com/users/elasticsearch/orgs","repos_url":"https://api.github.com/users/elasticsearch/repos","events_url":"https://api.github.com/users/elasticsearch/events{/privacy}","received_events_url":"https://api.github.com/users/elasticsearch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elasticsearch/elasticsearch","description":"Open Source, Distributed, RESTful Search Engine","fork":false,"url":"https://api.github.com/repos/elasticsearch/elasticsearch","forks_url":"https://api.github.com/repos/elasticsearch/elasticsearch/forks","keys_url":"https://api.github.com/repos/elasticsearch/elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elasticsearch/elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elasticsearch/elasticsearch/teams","hooks_url":"https://api.github.com/repos/elasticsearch/elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/elasticsearch/elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/elasticsearch/elasticsearch/events","assignees_url":"https://api.github.com/repos/elasticsearch/elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/elasticsearch/elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/elasticsearch/elasticsearch/tags","blobs_url":"https://api.github.com/repos/elasticsearch/elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elasticsearch/elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elasticsearch/elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/elasticsearch/elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elasticsearch/elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/elasticsearch/elasticsearch/languages","stargazers_url":"https://api.github.com/repos/elasticsearch/elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/elasticsearch/elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/elasticsearch/elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/elasticsearch/elasticsearch/subscription","commits_url":"https://api.github.com/repos/elasticsearch/elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/elasticsearch/elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/elasticsearch/elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/elasticsearch/elasticsearch/issues/comments/{number}","contents_url":"https://api.github.com/repos/elasticsearch/elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/elasticsearch/elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elasticsearch/elasticsearch/merges","archive_url":"https://api.github.com/repos/elasticsearch/elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elasticsearch/elasticsearch/downloads","issues_url":"https://api.github.com/repos/elasticsearch/elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/elasticsearch/elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/elasticsearch/elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elasticsearch/elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/elasticsearch/elasticsearch/releases{/id}","created_at":"2010-02-08T13:20:56Z","updated_at":"2014-11-07T15:13:10Z","pushed_at":"2014-11-07T16:09:19Z","git_url":"git://github.com/elasticsearch/elasticsearch.git","ssh_url":"git@github.com:elasticsearch/elasticsearch.git","clone_url":"https://github.com/elasticsearch/elasticsearch.git","svn_url":"https://github.com/elasticsearch/elasticsearch","homepage":"http://elasticsearch.org","size":297668,"stargazers_count":8810,"watchers_count":8810,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2670,"mirror_url":null,"open_issues_count":891,"forks":2670,"open_issues":891,"watchers":8810,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/8392"},"html":{"href":"https://github.com/elasticsearch/elasticsearch/pull/8392"},"issue":{"href":"https://api.github.com/repos/elasticsearch/elasticsearch/issues/8392"},"comments":{"href":"https://api.github.com/repos/elasticsearch/elasticsearch/issues/8392/comments"},"review_comments":{"href":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/8392/comments"},"review_comment":{"href":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/8392/commits"},"statuses":{"href":"https://api.github.com/repos/elasticsearch/elasticsearch/statuses/e837f0ab81c94e45cefd0bdfb51f977931fbcf4d"}}}}