GitHub PullRequestReviewCommentEvent at 2014-09-17 15:32:42
Repository: mozmill-ci
Actor: whimboo
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/mozmill-ci/pulls/comments/17671390","id":17671390,"diff_hunk":"@@ -202,10 +202,14 @@ def on_build(self, data):\n         target_platform = self.get_platform_identifier(data['platform'])\n \n         # Check locale restrictions and stop processing if locale is not wanted\n-        if target_branch['locales'] and \\\n+        if target_branch['locales'] and not target_branch['blacklist'] and \\\n                 data['locale'] not in target_branch['locales']:\n             return\n \n+        if target_branch['blacklist'] and \\\n+                data['locale'] in target_branch['blacklist']:\n+            return","path":"pulse.py","position":11,"original_position":11,"commit_id":"734658261d2abe0ec8def824b537d5b3e478cace","original_commit_id":"734658261d2abe0ec8def824b537d5b3e478cace","user":{"login":"whimboo","id":129603,"avatar_url":"https://avatars.githubusercontent.com/u/129603?v=2","gravatar_id":"4ab832a8d5cae15967c0da59ebfb83f7","url":"https://api.github.com/users/whimboo","html_url":"https://github.com/whimboo","followers_url":"https://api.github.com/users/whimboo/followers","following_url":"https://api.github.com/users/whimboo/following{/other_user}","gists_url":"https://api.github.com/users/whimboo/gists{/gist_id}","starred_url":"https://api.github.com/users/whimboo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whimboo/subscriptions","organizations_url":"https://api.github.com/users/whimboo/orgs","repos_url":"https://api.github.com/users/whimboo/repos","events_url":"https://api.github.com/users/whimboo/events{/privacy}","received_events_url":"https://api.github.com/users/whimboo/received_events","type":"User","site_admin":false},"body":"As we have said the blacklist takes precedence over the white-list. This is the other way around now. ","created_at":"2014-09-17T15:32:42Z","updated_at":"2014-09-17T15:32:42Z","html_url":"https://github.com/mozilla/mozmill-ci/pull/491#discussion_r17671390","pull_request_url":"https://api.github.com/repos/mozilla/mozmill-ci/pulls/491","_links":{"self":{"href":"https://api.github.com/repos/mozilla/mozmill-ci/pulls/comments/17671390"},"html":{"href":"https://github.com/mozilla/mozmill-ci/pull/491#discussion_r17671390"},"pull_request":{"href":"https://api.github.com/repos/mozilla/mozmill-ci/pulls/491"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/mozmill-ci/pulls/491","id":21362420,"html_url":"https://github.com/mozilla/mozmill-ci/pull/491","diff_url":"https://github.com/mozilla/mozmill-ci/pull/491.diff","patch_url":"https://github.com/mozilla/mozmill-ci/pull/491.patch","issue_url":"https://api.github.com/repos/mozilla/mozmill-ci/issues/491","number":491,"state":"open","locked":false,"title":"Add blacklist for locales  (#309)","user":{"login":"andreeamatei","id":1662265,"avatar_url":"https://avatars.githubusercontent.com/u/1662265?v=2","gravatar_id":"260c18a817b6cb7aa1c9a8f70a285d65","url":"https://api.github.com/users/andreeamatei","html_url":"https://github.com/andreeamatei","followers_url":"https://api.github.com/users/andreeamatei/followers","following_url":"https://api.github.com/users/andreeamatei/following{/other_user}","gists_url":"https://api.github.com/users/andreeamatei/gists{/gist_id}","starred_url":"https://api.github.com/users/andreeamatei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreeamatei/subscriptions","organizations_url":"https://api.github.com/users/andreeamatei/orgs","repos_url":"https://api.github.com/users/andreeamatei/repos","events_url":"https://api.github.com/users/andreeamatei/events{/privacy}","received_events_url":"https://api.github.com/users/andreeamatei/received_events","type":"User","site_admin":false},"body":"This is for issue #309. I added here the changes for the pulse script and also the blacklist for staging beta and release, for testing. So as discussed, the blacklist will have priority when there are both.","created_at":"2014-09-17T12:24:23Z","updated_at":"2014-09-17T15:32:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0955e2a86aa457f4d9daf2de061bd25694ba5dac","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/mozmill-ci/pulls/491/commits","review_comments_url":"https://api.github.com/repos/mozilla/mozmill-ci/pulls/491/comments","review_comment_url":"https://api.github.com/repos/mozilla/mozmill-ci/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mozilla/mozmill-ci/issues/491/comments","statuses_url":"https://api.github.com/repos/mozilla/mozmill-ci/statuses/734658261d2abe0ec8def824b537d5b3e478cace","head":{"label":"andreeamatei:blacklist","ref":"blacklist","sha":"734658261d2abe0ec8def824b537d5b3e478cace","user":{"login":"andreeamatei","id":1662265,"avatar_url":"https://avatars.githubusercontent.com/u/1662265?v=2","gravatar_id":"260c18a817b6cb7aa1c9a8f70a285d65","url":"https://api.github.com/users/andreeamatei","html_url":"https://github.com/andreeamatei","followers_url":"https://api.github.com/users/andreeamatei/followers","following_url":"https://api.github.com/users/andreeamatei/following{/other_user}","gists_url":"https://api.github.com/users/andreeamatei/gists{/gist_id}","starred_url":"https://api.github.com/users/andreeamatei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreeamatei/subscriptions","organizations_url":"https://api.github.com/users/andreeamatei/orgs","repos_url":"https://api.github.com/users/andreeamatei/repos","events_url":"https://api.github.com/users/andreeamatei/events{/privacy}","received_events_url":"https://api.github.com/users/andreeamatei/received_events","type":"User","site_admin":false},"repo":{"id":16775335,"name":"mozmill-ci","full_name":"andreeamatei/mozmill-ci","owner":{"login":"andreeamatei","id":1662265,"avatar_url":"https://avatars.githubusercontent.com/u/1662265?v=2","gravatar_id":"260c18a817b6cb7aa1c9a8f70a285d65","url":"https://api.github.com/users/andreeamatei","html_url":"https://github.com/andreeamatei","followers_url":"https://api.github.com/users/andreeamatei/followers","following_url":"https://api.github.com/users/andreeamatei/following{/other_user}","gists_url":"https://api.github.com/users/andreeamatei/gists{/gist_id}","starred_url":"https://api.github.com/users/andreeamatei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreeamatei/subscriptions","organizations_url":"https://api.github.com/users/andreeamatei/orgs","repos_url":"https://api.github.com/users/andreeamatei/repos","events_url":"https://api.github.com/users/andreeamatei/events{/privacy}","received_events_url":"https://api.github.com/users/andreeamatei/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andreeamatei/mozmill-ci","description":"Mozmill test-runs driven by Pulse and Jenkins","fork":true,"url":"https://api.github.com/repos/andreeamatei/mozmill-ci","forks_url":"https://api.github.com/repos/andreeamatei/mozmill-ci/forks","keys_url":"https://api.github.com/repos/andreeamatei/mozmill-ci/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andreeamatei/mozmill-ci/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andreeamatei/mozmill-ci/teams","hooks_url":"https://api.github.com/repos/andreeamatei/mozmill-ci/hooks","issue_events_url":"https://api.github.com/repos/andreeamatei/mozmill-ci/issues/events{/number}","events_url":"https://api.github.com/repos/andreeamatei/mozmill-ci/events","assignees_url":"https://api.github.com/repos/andreeamatei/mozmill-ci/assignees{/user}","branches_url":"https://api.github.com/repos/andreeamatei/mozmill-ci/branches{/branch}","tags_url":"https://api.github.com/repos/andreeamatei/mozmill-ci/tags","blobs_url":"https://api.github.com/repos/andreeamatei/mozmill-ci/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andreeamatei/mozmill-ci/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andreeamatei/mozmill-ci/git/refs{/sha}","trees_url":"https://api.github.com/repos/andreeamatei/mozmill-ci/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andreeamatei/mozmill-ci/statuses/{sha}","languages_url":"https://api.github.com/repos/andreeamatei/mozmill-ci/languages","stargazers_url":"https://api.github.com/repos/andreeamatei/mozmill-ci/stargazers","contributors_url":"https://api.github.com/repos/andreeamatei/mozmill-ci/contributors","subscribers_url":"https://api.github.com/repos/andreeamatei/mozmill-ci/subscribers","subscription_url":"https://api.github.com/repos/andreeamatei/mozmill-ci/subscription","commits_url":"https://api.github.com/repos/andreeamatei/mozmill-ci/commits{/sha}","git_commits_url":"https://api.github.com/repos/andreeamatei/mozmill-ci/git/commits{/sha}","comments_url":"https://api.github.com/repos/andreeamatei/mozmill-ci/comments{/number}","issue_comment_url":"https://api.github.com/repos/andreeamatei/mozmill-ci/issues/comments/{number}","contents_url":"https://api.github.com/repos/andreeamatei/mozmill-ci/contents/{+path}","compare_url":"https://api.github.com/repos/andreeamatei/mozmill-ci/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andreeamatei/mozmill-ci/merges","archive_url":"https://api.github.com/repos/andreeamatei/mozmill-ci/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andreeamatei/mozmill-ci/downloads","issues_url":"https://api.github.com/repos/andreeamatei/mozmill-ci/issues{/number}","pulls_url":"https://api.github.com/repos/andreeamatei/mozmill-ci/pulls{/number}","milestones_url":"https://api.github.com/repos/andreeamatei/mozmill-ci/milestones{/number}","notifications_url":"https://api.github.com/repos/andreeamatei/mozmill-ci/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andreeamatei/mozmill-ci/labels{/name}","releases_url":"https://api.github.com/repos/andreeamatei/mozmill-ci/releases{/id}","created_at":"2014-02-12T17:25:44Z","updated_at":"2014-08-08T07:22:35Z","pushed_at":"2014-09-17T12:15:49Z","git_url":"git://github.com/andreeamatei/mozmill-ci.git","ssh_url":"git@github.com:andreeamatei/mozmill-ci.git","clone_url":"https://github.com/andreeamatei/mozmill-ci.git","svn_url":"https://github.com/andreeamatei/mozmill-ci","homepage":"https://wiki.mozilla.org/Auto-tools/Automation_Development/Projects/Mozmill_Automation/Mozmill_CI","size":52424,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"4cfb7187ce3c0348a10c058af907e49098dbeaa1","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=2","gravatar_id":"9ba739c8f3288e256b13553e4d257b5e","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":3037564,"name":"mozmill-ci","full_name":"mozilla/mozmill-ci","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=2","gravatar_id":"9ba739c8f3288e256b13553e4d257b5e","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/mozmill-ci","description":"Mozmill continuous integration system driven by Mozilla Pulse and Jenkins","fork":false,"url":"https://api.github.com/repos/mozilla/mozmill-ci","forks_url":"https://api.github.com/repos/mozilla/mozmill-ci/forks","keys_url":"https://api.github.com/repos/mozilla/mozmill-ci/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/mozmill-ci/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/mozmill-ci/teams","hooks_url":"https://api.github.com/repos/mozilla/mozmill-ci/hooks","issue_events_url":"https://api.github.com/repos/mozilla/mozmill-ci/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/mozmill-ci/events","assignees_url":"https://api.github.com/repos/mozilla/mozmill-ci/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/mozmill-ci/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/mozmill-ci/tags","blobs_url":"https://api.github.com/repos/mozilla/mozmill-ci/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/mozmill-ci/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/mozmill-ci/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/mozmill-ci/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/mozmill-ci/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/mozmill-ci/languages","stargazers_url":"https://api.github.com/repos/mozilla/mozmill-ci/stargazers","contributors_url":"https://api.github.com/repos/mozilla/mozmill-ci/contributors","subscribers_url":"https://api.github.com/repos/mozilla/mozmill-ci/subscribers","subscription_url":"https://api.github.com/repos/mozilla/mozmill-ci/subscription","commits_url":"https://api.github.com/repos/mozilla/mozmill-ci/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/mozmill-ci/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/mozmill-ci/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/mozmill-ci/issues/comments/{number}","contents_url":"https://api.github.com/repos/mozilla/mozmill-ci/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/mozmill-ci/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/mozmill-ci/merges","archive_url":"https://api.github.com/repos/mozilla/mozmill-ci/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/mozmill-ci/downloads","issues_url":"https://api.github.com/repos/mozilla/mozmill-ci/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/mozmill-ci/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/mozmill-ci/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/mozmill-ci/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/mozmill-ci/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/mozmill-ci/releases{/id}","created_at":"2011-12-23T00:33:51Z","updated_at":"2014-09-09T08:43:05Z","pushed_at":"2014-09-17T06:34:38Z","git_url":"git://github.com/mozilla/mozmill-ci.git","ssh_url":"git@github.com:mozilla/mozmill-ci.git","clone_url":"https://github.com/mozilla/mozmill-ci.git","svn_url":"https://github.com/mozilla/mozmill-ci","homepage":"https://wiki.mozilla.org/QA/Automation/Projects/Mozmill_Automation/Mozmill_CI","size":66242,"stargazers_count":11,"watchers_count":11,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":56,"forks":16,"open_issues":56,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/mozmill-ci/pulls/491"},"html":{"href":"https://github.com/mozilla/mozmill-ci/pull/491"},"issue":{"href":"https://api.github.com/repos/mozilla/mozmill-ci/issues/491"},"comments":{"href":"https://api.github.com/repos/mozilla/mozmill-ci/issues/491/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/mozmill-ci/pulls/491/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/mozmill-ci/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mozilla/mozmill-ci/pulls/491/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/mozmill-ci/statuses/734658261d2abe0ec8def824b537d5b3e478cace"}}}}