GitHub PullRequestReviewCommentEvent at 2014-09-18 13:00:39
Repository: gaia
Actor: julienw
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/17724972","id":17724972,"diff_hunk":"@@ -811,6 +817,22 @@ var Compose = (function() {\n       dom.form.dataset.messageType = this.type;\n     },\n \n+    onSegmentInfoChange: function c_onSegmentInfoChange() {\n+      // If segment info was the reason to update message type then here we\n+      // should have the most actual one because updateType was called before\n+      if (this.type === 'sms') {","path":"apps/sms/js/compose.js","position":45,"original_position":45,"commit_id":"9bf499f04e38ef9cdfc45e615abb4ef5fc5a82ad","original_commit_id":"9bf499f04e38ef9cdfc45e615abb4ef5fc5a82ad","user":{"login":"julienw","id":454175,"avatar_url":"https://avatars.githubusercontent.com/u/454175?v=2","gravatar_id":"a2b625f331361a7110da59a907d79e95","url":"https://api.github.com/users/julienw","html_url":"https://github.com/julienw","followers_url":"https://api.github.com/users/julienw/followers","following_url":"https://api.github.com/users/julienw/following{/other_user}","gists_url":"https://api.github.com/users/julienw/gists{/gist_id}","starred_url":"https://api.github.com/users/julienw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julienw/subscriptions","organizations_url":"https://api.github.com/users/julienw/orgs","repos_url":"https://api.github.com/users/julienw/repos","events_url":"https://api.github.com/users/julienw/events{/privacy}","received_events_url":"https://api.github.com/users/julienw/received_events","type":"User","site_admin":false},"body":"actually I just tried your code, and this doesn't work properly:\r\n\r\n1. add enough text to display the counter\r\n2. add a subject and add one letter in it => should move to MMS\r\n3. add some text in the input\r\n4. remove the subject\r\n=> the counter is like it was at step 1.\r\n5. add one letter\r\n=> you see the counter moves more than it should.\r\n\r\nI think it works properly in current master, but I'm not sure.\r\n\r\nWe need to check the same with an attachment instead of a subject.","created_at":"2014-09-18T13:00:39Z","updated_at":"2014-09-18T13:00:39Z","html_url":"https://github.com/mozilla-b2g/gaia/pull/23726#discussion_r17724972","pull_request_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/23726","_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/17724972"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/23726#discussion_r17724972"},"pull_request":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/23726"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/23726","id":20753645,"html_url":"https://github.com/mozilla-b2g/gaia/pull/23726","diff_url":"https://github.com/mozilla-b2g/gaia/pull/23726.diff","patch_url":"https://github.com/mozilla-b2g/gaia/pull/23726.patch","issue_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/23726","number":23726,"state":"open","locked":false,"title":"Bug 1061215 - [Messages][Refactoring] Improve handling of remaining chars counter. r=schung","user":{"login":"azasypkin","id":1713708,"avatar_url":"https://avatars.githubusercontent.com/u/1713708?v=2","gravatar_id":"18037d0ecb14ff43606946097eedb8b5","url":"https://api.github.com/users/azasypkin","html_url":"https://github.com/azasypkin","followers_url":"https://api.github.com/users/azasypkin/followers","following_url":"https://api.github.com/users/azasypkin/following{/other_user}","gists_url":"https://api.github.com/users/azasypkin/gists{/gist_id}","starred_url":"https://api.github.com/users/azasypkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azasypkin/subscriptions","organizations_url":"https://api.github.com/users/azasypkin/orgs","repos_url":"https://api.github.com/users/azasypkin/repos","events_url":"https://api.github.com/users/azasypkin/events{/privacy}","received_events_url":"https://api.github.com/users/azasypkin/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-09-04T15:58:30Z","updated_at":"2014-09-18T13:00:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b9d5816a2d30035187963e5997b8a45d78174a79","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/23726/commits","review_comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/23726/comments","review_comment_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/23726/comments","statuses_url":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/9bf499f04e38ef9cdfc45e615abb4ef5fc5a82ad","head":{"label":"azasypkin:bug-1061215-remaining-chars-counter","ref":"bug-1061215-remaining-chars-counter","sha":"9bf499f04e38ef9cdfc45e615abb4ef5fc5a82ad","user":{"login":"azasypkin","id":1713708,"avatar_url":"https://avatars.githubusercontent.com/u/1713708?v=2","gravatar_id":"18037d0ecb14ff43606946097eedb8b5","url":"https://api.github.com/users/azasypkin","html_url":"https://github.com/azasypkin","followers_url":"https://api.github.com/users/azasypkin/followers","following_url":"https://api.github.com/users/azasypkin/following{/other_user}","gists_url":"https://api.github.com/users/azasypkin/gists{/gist_id}","starred_url":"https://api.github.com/users/azasypkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azasypkin/subscriptions","organizations_url":"https://api.github.com/users/azasypkin/orgs","repos_url":"https://api.github.com/users/azasypkin/repos","events_url":"https://api.github.com/users/azasypkin/events{/privacy}","received_events_url":"https://api.github.com/users/azasypkin/received_events","type":"User","site_admin":false},"repo":{"id":17702910,"name":"gaia","full_name":"azasypkin/gaia","owner":{"login":"azasypkin","id":1713708,"avatar_url":"https://avatars.githubusercontent.com/u/1713708?v=2","gravatar_id":"18037d0ecb14ff43606946097eedb8b5","url":"https://api.github.com/users/azasypkin","html_url":"https://github.com/azasypkin","followers_url":"https://api.github.com/users/azasypkin/followers","following_url":"https://api.github.com/users/azasypkin/following{/other_user}","gists_url":"https://api.github.com/users/azasypkin/gists{/gist_id}","starred_url":"https://api.github.com/users/azasypkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azasypkin/subscriptions","organizations_url":"https://api.github.com/users/azasypkin/orgs","repos_url":"https://api.github.com/users/azasypkin/repos","events_url":"https://api.github.com/users/azasypkin/events{/privacy}","received_events_url":"https://api.github.com/users/azasypkin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/azasypkin/gaia","description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see https://wiki.mozilla.org/Release_Management/B2G_Landing","fork":true,"url":"https://api.github.com/repos/azasypkin/gaia","forks_url":"https://api.github.com/repos/azasypkin/gaia/forks","keys_url":"https://api.github.com/repos/azasypkin/gaia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/azasypkin/gaia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/azasypkin/gaia/teams","hooks_url":"https://api.github.com/repos/azasypkin/gaia/hooks","issue_events_url":"https://api.github.com/repos/azasypkin/gaia/issues/events{/number}","events_url":"https://api.github.com/repos/azasypkin/gaia/events","assignees_url":"https://api.github.com/repos/azasypkin/gaia/assignees{/user}","branches_url":"https://api.github.com/repos/azasypkin/gaia/branches{/branch}","tags_url":"https://api.github.com/repos/azasypkin/gaia/tags","blobs_url":"https://api.github.com/repos/azasypkin/gaia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/azasypkin/gaia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/azasypkin/gaia/git/refs{/sha}","trees_url":"https://api.github.com/repos/azasypkin/gaia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/azasypkin/gaia/statuses/{sha}","languages_url":"https://api.github.com/repos/azasypkin/gaia/languages","stargazers_url":"https://api.github.com/repos/azasypkin/gaia/stargazers","contributors_url":"https://api.github.com/repos/azasypkin/gaia/contributors","subscribers_url":"https://api.github.com/repos/azasypkin/gaia/subscribers","subscription_url":"https://api.github.com/repos/azasypkin/gaia/subscription","commits_url":"https://api.github.com/repos/azasypkin/gaia/commits{/sha}","git_commits_url":"https://api.github.com/repos/azasypkin/gaia/git/commits{/sha}","comments_url":"https://api.github.com/repos/azasypkin/gaia/comments{/number}","issue_comment_url":"https://api.github.com/repos/azasypkin/gaia/issues/comments/{number}","contents_url":"https://api.github.com/repos/azasypkin/gaia/contents/{+path}","compare_url":"https://api.github.com/repos/azasypkin/gaia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/azasypkin/gaia/merges","archive_url":"https://api.github.com/repos/azasypkin/gaia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/azasypkin/gaia/downloads","issues_url":"https://api.github.com/repos/azasypkin/gaia/issues{/number}","pulls_url":"https://api.github.com/repos/azasypkin/gaia/pulls{/number}","milestones_url":"https://api.github.com/repos/azasypkin/gaia/milestones{/number}","notifications_url":"https://api.github.com/repos/azasypkin/gaia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/azasypkin/gaia/labels{/name}","releases_url":"https://api.github.com/repos/azasypkin/gaia/releases{/id}","created_at":"2014-03-13T08:22:23Z","updated_at":"2014-06-28T10:03:34Z","pushed_at":"2014-09-18T08:53:10Z","git_url":"git://github.com/azasypkin/gaia.git","ssh_url":"git@github.com:azasypkin/gaia.git","clone_url":"https://github.com/azasypkin/gaia.git","svn_url":"https://github.com/azasypkin/gaia","homepage":"https://wiki.mozilla.org/B2G","size":840803,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla-b2g:master","ref":"master","sha":"743c07ff7fc2d94a897624d59c5b8ab04a796ad4","user":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=2","gravatar_id":"b1de11f7d6ddaf7b9d527281297c2ee1","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"repo":{"id":2317369,"name":"gaia","full_name":"mozilla-b2g/gaia","owner":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=2","gravatar_id":"b1de11f7d6ddaf7b9d527281297c2ee1","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-b2g/gaia","description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see","fork":false,"url":"https://api.github.com/repos/mozilla-b2g/gaia","forks_url":"https://api.github.com/repos/mozilla-b2g/gaia/forks","keys_url":"https://api.github.com/repos/mozilla-b2g/gaia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-b2g/gaia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-b2g/gaia/teams","hooks_url":"https://api.github.com/repos/mozilla-b2g/gaia/hooks","issue_events_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-b2g/gaia/events","assignees_url":"https://api.github.com/repos/mozilla-b2g/gaia/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-b2g/gaia/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-b2g/gaia/tags","blobs_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-b2g/gaia/languages","stargazers_url":"https://api.github.com/repos/mozilla-b2g/gaia/stargazers","contributors_url":"https://api.github.com/repos/mozilla-b2g/gaia/contributors","subscribers_url":"https://api.github.com/repos/mozilla-b2g/gaia/subscribers","subscription_url":"https://api.github.com/repos/mozilla-b2g/gaia/subscription","commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/comments/{number}","contents_url":"https://api.github.com/repos/mozilla-b2g/gaia/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-b2g/gaia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-b2g/gaia/merges","archive_url":"https://api.github.com/repos/mozilla-b2g/gaia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-b2g/gaia/downloads","issues_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-b2g/gaia/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-b2g/gaia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-b2g/gaia/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-b2g/gaia/releases{/id}","created_at":"2011-09-03T01:38:46Z","updated_at":"2014-09-18T02:27:05Z","pushed_at":"2014-09-18T11:57:33Z","git_url":"git://github.com/mozilla-b2g/gaia.git","ssh_url":"git@github.com:mozilla-b2g/gaia.git","clone_url":"https://github.com/mozilla-b2g/gaia.git","svn_url":"https://github.com/mozilla-b2g/gaia","homepage":"https://wiki.mozilla.org/B2G","size":1439571,"stargazers_count":1744,"watchers_count":1744,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1914,"mirror_url":null,"open_issues_count":2035,"forks":1914,"open_issues":2035,"watchers":1744,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/23726"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/23726"},"issue":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/issues/23726"},"comments":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/issues/23726/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/23726/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/23726/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/9bf499f04e38ef9cdfc45e615abb4ef5fc5a82ad"}}}}