GitHub PullRequestReviewCommentEvent at 2014-11-04 09:30:31
Repository: zabbix
Actor: guilhem
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/laradji/zabbix/pulls/comments/19792260","id":19792260,"diff_hunk":"@@ -0,0 +1,10 @@\n+default['zabbix']['agent']['servicename'] = 'zabbix-agent'","path":"attributes/agent_package.rb","position":1,"original_position":1,"commit_id":"3f511345dbe182c545377362fb73d2712b89ead6","original_commit_id":"3f511345dbe182c545377362fb73d2712b89ead6","user":{"login":"guilhem","id":486876,"avatar_url":"https://avatars.githubusercontent.com/u/486876?v=2","gravatar_id":"","url":"https://api.github.com/users/guilhem","html_url":"https://github.com/guilhem","followers_url":"https://api.github.com/users/guilhem/followers","following_url":"https://api.github.com/users/guilhem/following{/other_user}","gists_url":"https://api.github.com/users/guilhem/gists{/gist_id}","starred_url":"https://api.github.com/users/guilhem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guilhem/subscriptions","organizations_url":"https://api.github.com/users/guilhem/orgs","repos_url":"https://api.github.com/users/guilhem/repos","events_url":"https://api.github.com/users/guilhem/events{/privacy}","received_events_url":"https://api.github.com/users/guilhem/received_events","type":"User","site_admin":false},"body":"be careful, all attributes are loaded in alphabetical order even if corresponding recipe isn't.\r\n\r\nHere node['zabbix']['agent']['servicename'] will never be `zabbix_agentd` because it is override by this one.\r\n\r\nIf you want to act different in each recipe, use `node.default['zabbix']['agent']['servicename'] =` in recipe.rb","created_at":"2014-11-04T09:30:31Z","updated_at":"2014-11-04T09:30:31Z","html_url":"https://github.com/laradji/zabbix/pull/187#discussion_r19792260","pull_request_url":"https://api.github.com/repos/laradji/zabbix/pulls/187","_links":{"self":{"href":"https://api.github.com/repos/laradji/zabbix/pulls/comments/19792260"},"html":{"href":"https://github.com/laradji/zabbix/pull/187#discussion_r19792260"},"pull_request":{"href":"https://api.github.com/repos/laradji/zabbix/pulls/187"}}},"pull_request":{"url":"https://api.github.com/repos/laradji/zabbix/pulls/187","id":23811119,"html_url":"https://github.com/laradji/zabbix/pull/187","diff_url":"https://github.com/laradji/zabbix/pull/187.diff","patch_url":"https://github.com/laradji/zabbix/pull/187.patch","issue_url":"https://api.github.com/repos/laradji/zabbix/issues/187","number":187,"state":"open","locked":false,"title":"Allow agent to be installed from deb/rpm package","user":{"login":"TD-4242","id":3487671,"avatar_url":"https://avatars.githubusercontent.com/u/3487671?v=2","gravatar_id":"","url":"https://api.github.com/users/TD-4242","html_url":"https://github.com/TD-4242","followers_url":"https://api.github.com/users/TD-4242/followers","following_url":"https://api.github.com/users/TD-4242/following{/other_user}","gists_url":"https://api.github.com/users/TD-4242/gists{/gist_id}","starred_url":"https://api.github.com/users/TD-4242/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TD-4242/subscriptions","organizations_url":"https://api.github.com/users/TD-4242/orgs","repos_url":"https://api.github.com/users/TD-4242/repos","events_url":"https://api.github.com/users/TD-4242/events{/privacy}","received_events_url":"https://api.github.com/users/TD-4242/received_events","type":"User","site_admin":false},"body":"This will allow the agent to be installed from either rpm or dev packages.\r\n\r\nBy default this points to repo.zabbix.com and the appropriate directories.  Although, that can be overwritten with an attribute.\r\n\r\nI had to create an attribute for the service name due to the packages having it as zabbix-agent and the templates using zabbix_agentd.  This should have no effect on any other install method as it maintains the same service name for any non packaged version.\r\n\r\nRedhat/CentOS is untested as I don't have easy access to that OS currently.\r\n\r\nI will be creating this install source for the server and web portions as well.","created_at":"2014-11-04T04:45:55Z","updated_at":"2014-11-04T09:30:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ddab0e726e49b7681cc8ada8428fdd4e4b31ee42","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/laradji/zabbix/pulls/187/commits","review_comments_url":"https://api.github.com/repos/laradji/zabbix/pulls/187/comments","review_comment_url":"https://api.github.com/repos/laradji/zabbix/pulls/comments/{number}","comments_url":"https://api.github.com/repos/laradji/zabbix/issues/187/comments","statuses_url":"https://api.github.com/repos/laradji/zabbix/statuses/3f511345dbe182c545377362fb73d2712b89ead6","head":{"label":"TD-4242:master","ref":"master","sha":"3f511345dbe182c545377362fb73d2712b89ead6","user":{"login":"TD-4242","id":3487671,"avatar_url":"https://avatars.githubusercontent.com/u/3487671?v=2","gravatar_id":"","url":"https://api.github.com/users/TD-4242","html_url":"https://github.com/TD-4242","followers_url":"https://api.github.com/users/TD-4242/followers","following_url":"https://api.github.com/users/TD-4242/following{/other_user}","gists_url":"https://api.github.com/users/TD-4242/gists{/gist_id}","starred_url":"https://api.github.com/users/TD-4242/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TD-4242/subscriptions","organizations_url":"https://api.github.com/users/TD-4242/orgs","repos_url":"https://api.github.com/users/TD-4242/repos","events_url":"https://api.github.com/users/TD-4242/events{/privacy}","received_events_url":"https://api.github.com/users/TD-4242/received_events","type":"User","site_admin":false},"repo":{"id":26134343,"name":"zabbix","full_name":"TD-4242/zabbix","owner":{"login":"TD-4242","id":3487671,"avatar_url":"https://avatars.githubusercontent.com/u/3487671?v=2","gravatar_id":"","url":"https://api.github.com/users/TD-4242","html_url":"https://github.com/TD-4242","followers_url":"https://api.github.com/users/TD-4242/followers","following_url":"https://api.github.com/users/TD-4242/following{/other_user}","gists_url":"https://api.github.com/users/TD-4242/gists{/gist_id}","starred_url":"https://api.github.com/users/TD-4242/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TD-4242/subscriptions","organizations_url":"https://api.github.com/users/TD-4242/orgs","repos_url":"https://api.github.com/users/TD-4242/repos","events_url":"https://api.github.com/users/TD-4242/events{/privacy}","received_events_url":"https://api.github.com/users/TD-4242/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TD-4242/zabbix","description":"Zabbix chef cookbook","fork":true,"url":"https://api.github.com/repos/TD-4242/zabbix","forks_url":"https://api.github.com/repos/TD-4242/zabbix/forks","keys_url":"https://api.github.com/repos/TD-4242/zabbix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TD-4242/zabbix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TD-4242/zabbix/teams","hooks_url":"https://api.github.com/repos/TD-4242/zabbix/hooks","issue_events_url":"https://api.github.com/repos/TD-4242/zabbix/issues/events{/number}","events_url":"https://api.github.com/repos/TD-4242/zabbix/events","assignees_url":"https://api.github.com/repos/TD-4242/zabbix/assignees{/user}","branches_url":"https://api.github.com/repos/TD-4242/zabbix/branches{/branch}","tags_url":"https://api.github.com/repos/TD-4242/zabbix/tags","blobs_url":"https://api.github.com/repos/TD-4242/zabbix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TD-4242/zabbix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TD-4242/zabbix/git/refs{/sha}","trees_url":"https://api.github.com/repos/TD-4242/zabbix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TD-4242/zabbix/statuses/{sha}","languages_url":"https://api.github.com/repos/TD-4242/zabbix/languages","stargazers_url":"https://api.github.com/repos/TD-4242/zabbix/stargazers","contributors_url":"https://api.github.com/repos/TD-4242/zabbix/contributors","subscribers_url":"https://api.github.com/repos/TD-4242/zabbix/subscribers","subscription_url":"https://api.github.com/repos/TD-4242/zabbix/subscription","commits_url":"https://api.github.com/repos/TD-4242/zabbix/commits{/sha}","git_commits_url":"https://api.github.com/repos/TD-4242/zabbix/git/commits{/sha}","comments_url":"https://api.github.com/repos/TD-4242/zabbix/comments{/number}","issue_comment_url":"https://api.github.com/repos/TD-4242/zabbix/issues/comments/{number}","contents_url":"https://api.github.com/repos/TD-4242/zabbix/contents/{+path}","compare_url":"https://api.github.com/repos/TD-4242/zabbix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TD-4242/zabbix/merges","archive_url":"https://api.github.com/repos/TD-4242/zabbix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TD-4242/zabbix/downloads","issues_url":"https://api.github.com/repos/TD-4242/zabbix/issues{/number}","pulls_url":"https://api.github.com/repos/TD-4242/zabbix/pulls{/number}","milestones_url":"https://api.github.com/repos/TD-4242/zabbix/milestones{/number}","notifications_url":"https://api.github.com/repos/TD-4242/zabbix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TD-4242/zabbix/labels{/name}","releases_url":"https://api.github.com/repos/TD-4242/zabbix/releases{/id}","created_at":"2014-11-03T19:15:33Z","updated_at":"2014-11-03T22:35:44Z","pushed_at":"2014-11-04T05:19:18Z","git_url":"git://github.com/TD-4242/zabbix.git","ssh_url":"git@github.com:TD-4242/zabbix.git","clone_url":"https://github.com/TD-4242/zabbix.git","svn_url":"https://github.com/TD-4242/zabbix","homepage":null,"size":2089,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"laradji:master","ref":"master","sha":"e0323faec9d7d372fcfd2398b44d7c4c3a47fd5c","user":{"login":"laradji","id":397239,"avatar_url":"https://avatars.githubusercontent.com/u/397239?v=2","gravatar_id":"","url":"https://api.github.com/users/laradji","html_url":"https://github.com/laradji","followers_url":"https://api.github.com/users/laradji/followers","following_url":"https://api.github.com/users/laradji/following{/other_user}","gists_url":"https://api.github.com/users/laradji/gists{/gist_id}","starred_url":"https://api.github.com/users/laradji/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laradji/subscriptions","organizations_url":"https://api.github.com/users/laradji/orgs","repos_url":"https://api.github.com/users/laradji/repos","events_url":"https://api.github.com/users/laradji/events{/privacy}","received_events_url":"https://api.github.com/users/laradji/received_events","type":"User","site_admin":false},"repo":{"id":4367065,"name":"zabbix","full_name":"laradji/zabbix","owner":{"login":"laradji","id":397239,"avatar_url":"https://avatars.githubusercontent.com/u/397239?v=2","gravatar_id":"","url":"https://api.github.com/users/laradji","html_url":"https://github.com/laradji","followers_url":"https://api.github.com/users/laradji/followers","following_url":"https://api.github.com/users/laradji/following{/other_user}","gists_url":"https://api.github.com/users/laradji/gists{/gist_id}","starred_url":"https://api.github.com/users/laradji/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laradji/subscriptions","organizations_url":"https://api.github.com/users/laradji/orgs","repos_url":"https://api.github.com/users/laradji/repos","events_url":"https://api.github.com/users/laradji/events{/privacy}","received_events_url":"https://api.github.com/users/laradji/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/laradji/zabbix","description":"Zabbix chef cookbook","fork":false,"url":"https://api.github.com/repos/laradji/zabbix","forks_url":"https://api.github.com/repos/laradji/zabbix/forks","keys_url":"https://api.github.com/repos/laradji/zabbix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/laradji/zabbix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/laradji/zabbix/teams","hooks_url":"https://api.github.com/repos/laradji/zabbix/hooks","issue_events_url":"https://api.github.com/repos/laradji/zabbix/issues/events{/number}","events_url":"https://api.github.com/repos/laradji/zabbix/events","assignees_url":"https://api.github.com/repos/laradji/zabbix/assignees{/user}","branches_url":"https://api.github.com/repos/laradji/zabbix/branches{/branch}","tags_url":"https://api.github.com/repos/laradji/zabbix/tags","blobs_url":"https://api.github.com/repos/laradji/zabbix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/laradji/zabbix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/laradji/zabbix/git/refs{/sha}","trees_url":"https://api.github.com/repos/laradji/zabbix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/laradji/zabbix/statuses/{sha}","languages_url":"https://api.github.com/repos/laradji/zabbix/languages","stargazers_url":"https://api.github.com/repos/laradji/zabbix/stargazers","contributors_url":"https://api.github.com/repos/laradji/zabbix/contributors","subscribers_url":"https://api.github.com/repos/laradji/zabbix/subscribers","subscription_url":"https://api.github.com/repos/laradji/zabbix/subscription","commits_url":"https://api.github.com/repos/laradji/zabbix/commits{/sha}","git_commits_url":"https://api.github.com/repos/laradji/zabbix/git/commits{/sha}","comments_url":"https://api.github.com/repos/laradji/zabbix/comments{/number}","issue_comment_url":"https://api.github.com/repos/laradji/zabbix/issues/comments/{number}","contents_url":"https://api.github.com/repos/laradji/zabbix/contents/{+path}","compare_url":"https://api.github.com/repos/laradji/zabbix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/laradji/zabbix/merges","archive_url":"https://api.github.com/repos/laradji/zabbix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/laradji/zabbix/downloads","issues_url":"https://api.github.com/repos/laradji/zabbix/issues{/number}","pulls_url":"https://api.github.com/repos/laradji/zabbix/pulls{/number}","milestones_url":"https://api.github.com/repos/laradji/zabbix/milestones{/number}","notifications_url":"https://api.github.com/repos/laradji/zabbix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/laradji/zabbix/labels{/name}","releases_url":"https://api.github.com/repos/laradji/zabbix/releases{/id}","created_at":"2012-05-18T08:07:09Z","updated_at":"2014-10-24T14:31:27Z","pushed_at":"2014-09-16T15:05:04Z","git_url":"git://github.com/laradji/zabbix.git","ssh_url":"git@github.com:laradji/zabbix.git","clone_url":"https://github.com/laradji/zabbix.git","svn_url":"https://github.com/laradji/zabbix","homepage":null,"size":2089,"stargazers_count":69,"watchers_count":69,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":95,"mirror_url":null,"open_issues_count":21,"forks":95,"open_issues":21,"watchers":69,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/laradji/zabbix/pulls/187"},"html":{"href":"https://github.com/laradji/zabbix/pull/187"},"issue":{"href":"https://api.github.com/repos/laradji/zabbix/issues/187"},"comments":{"href":"https://api.github.com/repos/laradji/zabbix/issues/187/comments"},"review_comments":{"href":"https://api.github.com/repos/laradji/zabbix/pulls/187/comments"},"review_comment":{"href":"https://api.github.com/repos/laradji/zabbix/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/laradji/zabbix/pulls/187/commits"},"statuses":{"href":"https://api.github.com/repos/laradji/zabbix/statuses/3f511345dbe182c545377362fb73d2712b89ead6"}}}}