GitHub PullRequestReviewCommentEvent at 2014-11-07 18:34:54
Repository: botocore
Actor: jamesls
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/boto/botocore/pulls/comments/20027843","id":20027843,"diff_hunk":"@@ -12,20 +12,21 @@\n # distributed on an \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF\n # ANY KIND, either express or implied. See the License for the specific\n # language governing permissions and limitations under the License.\n-\n import datetime\n import json\n import mock\n import os\n \n+from dateutil.tz import tzlocal\n+\n from botocore import credentials\n import botocore.exceptions\n import botocore.session\n from botocore.vendored.requests import ConnectionError\n-\n from tests import unittest, BaseEnvVar, create_session\n \n \n+","path":"tests/unit/test_credentials.py","position":null,"original_position":20,"commit_id":"b40fad21522d3ee9617bf1c01a4b09c3237c26b5","original_commit_id":"807c16f2c016d6b6232a54a255bba0a77ee6258b","user":{"login":"jamesls","id":368057,"avatar_url":"https://avatars.githubusercontent.com/u/368057?v=3","gravatar_id":"","url":"https://api.github.com/users/jamesls","html_url":"https://github.com/jamesls","followers_url":"https://api.github.com/users/jamesls/followers","following_url":"https://api.github.com/users/jamesls/following{/other_user}","gists_url":"https://api.github.com/users/jamesls/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesls/subscriptions","organizations_url":"https://api.github.com/users/jamesls/orgs","repos_url":"https://api.github.com/users/jamesls/repos","events_url":"https://api.github.com/users/jamesls/events{/privacy}","received_events_url":"https://api.github.com/users/jamesls/received_events","type":"User","site_admin":false},"body":"I pushed a new commit that cleans up the pep8 formatting and removes the unused imports (https://github.com/jamesls/botocore/commit/b40fad21522d3ee9617bf1c01a4b09c3237c26b5)","created_at":"2014-11-07T18:34:54Z","updated_at":"2014-11-07T18:34:54Z","html_url":"https://github.com/boto/botocore/pull/373#discussion_r20027843","pull_request_url":"https://api.github.com/repos/boto/botocore/pulls/373","_links":{"self":{"href":"https://api.github.com/repos/boto/botocore/pulls/comments/20027843"},"html":{"href":"https://github.com/boto/botocore/pull/373#discussion_r20027843"},"pull_request":{"href":"https://api.github.com/repos/boto/botocore/pulls/373"}}},"pull_request":{"url":"https://api.github.com/repos/boto/botocore/pulls/373","id":24035358,"html_url":"https://github.com/boto/botocore/pull/373","diff_url":"https://github.com/boto/botocore/pull/373.diff","patch_url":"https://github.com/boto/botocore/pull/373.patch","issue_url":"https://api.github.com/repos/boto/botocore/issues/373","number":373,"state":"open","locked":false,"title":"Update cred provider to have more general date parser","user":{"login":"jamesls","id":368057,"avatar_url":"https://avatars.githubusercontent.com/u/368057?v=3","gravatar_id":"","url":"https://api.github.com/users/jamesls","html_url":"https://github.com/jamesls","followers_url":"https://api.github.com/users/jamesls/followers","following_url":"https://api.github.com/users/jamesls/following{/other_user}","gists_url":"https://api.github.com/users/jamesls/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesls/subscriptions","organizations_url":"https://api.github.com/users/jamesls/orgs","repos_url":"https://api.github.com/users/jamesls/repos","events_url":"https://api.github.com/users/jamesls/events{/privacy}","received_events_url":"https://api.github.com/users/jamesls/received_events","type":"User","site_admin":false},"body":"Also, the default time fetcher now returns time zone aware\r\nlocal time.  This results in no external function change,\r\nbut it does allow for more generalized date string formats\r\nto be provided (it uses dateutil.parser.parse() to parse\r\ntimestamps now).\r\n\r\ncc @kyleknap @danielgtaylor ","created_at":"2014-11-07T06:14:30Z","updated_at":"2014-11-07T18:34:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"97c560fb43b44cdd250d6ea06afbf5fcfdbc1e7c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/boto/botocore/pulls/373/commits","review_comments_url":"https://api.github.com/repos/boto/botocore/pulls/373/comments","review_comment_url":"https://api.github.com/repos/boto/botocore/pulls/comments/{number}","comments_url":"https://api.github.com/repos/boto/botocore/issues/373/comments","statuses_url":"https://api.github.com/repos/boto/botocore/statuses/b40fad21522d3ee9617bf1c01a4b09c3237c26b5","head":{"label":"jamesls:tz-aware-cred-refresh","ref":"tz-aware-cred-refresh","sha":"b40fad21522d3ee9617bf1c01a4b09c3237c26b5","user":{"login":"jamesls","id":368057,"avatar_url":"https://avatars.githubusercontent.com/u/368057?v=3","gravatar_id":"","url":"https://api.github.com/users/jamesls","html_url":"https://github.com/jamesls","followers_url":"https://api.github.com/users/jamesls/followers","following_url":"https://api.github.com/users/jamesls/following{/other_user}","gists_url":"https://api.github.com/users/jamesls/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesls/subscriptions","organizations_url":"https://api.github.com/users/jamesls/orgs","repos_url":"https://api.github.com/users/jamesls/repos","events_url":"https://api.github.com/users/jamesls/events{/privacy}","received_events_url":"https://api.github.com/users/jamesls/received_events","type":"User","site_admin":false},"repo":{"id":7948111,"name":"botocore","full_name":"jamesls/botocore","owner":{"login":"jamesls","id":368057,"avatar_url":"https://avatars.githubusercontent.com/u/368057?v=3","gravatar_id":"","url":"https://api.github.com/users/jamesls","html_url":"https://github.com/jamesls","followers_url":"https://api.github.com/users/jamesls/followers","following_url":"https://api.github.com/users/jamesls/following{/other_user}","gists_url":"https://api.github.com/users/jamesls/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesls/subscriptions","organizations_url":"https://api.github.com/users/jamesls/orgs","repos_url":"https://api.github.com/users/jamesls/repos","events_url":"https://api.github.com/users/jamesls/events{/privacy}","received_events_url":"https://api.github.com/users/jamesls/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jamesls/botocore","description":"The low-level, core functionality of boto 3.","fork":true,"url":"https://api.github.com/repos/jamesls/botocore","forks_url":"https://api.github.com/repos/jamesls/botocore/forks","keys_url":"https://api.github.com/repos/jamesls/botocore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jamesls/botocore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jamesls/botocore/teams","hooks_url":"https://api.github.com/repos/jamesls/botocore/hooks","issue_events_url":"https://api.github.com/repos/jamesls/botocore/issues/events{/number}","events_url":"https://api.github.com/repos/jamesls/botocore/events","assignees_url":"https://api.github.com/repos/jamesls/botocore/assignees{/user}","branches_url":"https://api.github.com/repos/jamesls/botocore/branches{/branch}","tags_url":"https://api.github.com/repos/jamesls/botocore/tags","blobs_url":"https://api.github.com/repos/jamesls/botocore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jamesls/botocore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jamesls/botocore/git/refs{/sha}","trees_url":"https://api.github.com/repos/jamesls/botocore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jamesls/botocore/statuses/{sha}","languages_url":"https://api.github.com/repos/jamesls/botocore/languages","stargazers_url":"https://api.github.com/repos/jamesls/botocore/stargazers","contributors_url":"https://api.github.com/repos/jamesls/botocore/contributors","subscribers_url":"https://api.github.com/repos/jamesls/botocore/subscribers","subscription_url":"https://api.github.com/repos/jamesls/botocore/subscription","commits_url":"https://api.github.com/repos/jamesls/botocore/commits{/sha}","git_commits_url":"https://api.github.com/repos/jamesls/botocore/git/commits{/sha}","comments_url":"https://api.github.com/repos/jamesls/botocore/comments{/number}","issue_comment_url":"https://api.github.com/repos/jamesls/botocore/issues/comments/{number}","contents_url":"https://api.github.com/repos/jamesls/botocore/contents/{+path}","compare_url":"https://api.github.com/repos/jamesls/botocore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jamesls/botocore/merges","archive_url":"https://api.github.com/repos/jamesls/botocore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jamesls/botocore/downloads","issues_url":"https://api.github.com/repos/jamesls/botocore/issues{/number}","pulls_url":"https://api.github.com/repos/jamesls/botocore/pulls{/number}","milestones_url":"https://api.github.com/repos/jamesls/botocore/milestones{/number}","notifications_url":"https://api.github.com/repos/jamesls/botocore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jamesls/botocore/labels{/name}","releases_url":"https://api.github.com/repos/jamesls/botocore/releases{/id}","created_at":"2013-01-31T23:36:26Z","updated_at":"2014-06-24T18:29:52Z","pushed_at":"2014-11-07T18:34:04Z","git_url":"git://github.com/jamesls/botocore.git","ssh_url":"git@github.com:jamesls/botocore.git","clone_url":"https://github.com/jamesls/botocore.git","svn_url":"https://github.com/jamesls/botocore","homepage":null,"size":16360,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"boto:develop","ref":"develop","sha":"e754fc0d7b4a51dc1ac11c8fc5916873ce458526","user":{"login":"boto","id":327752,"avatar_url":"https://avatars.githubusercontent.com/u/327752?v=3","gravatar_id":"","url":"https://api.github.com/users/boto","html_url":"https://github.com/boto","followers_url":"https://api.github.com/users/boto/followers","following_url":"https://api.github.com/users/boto/following{/other_user}","gists_url":"https://api.github.com/users/boto/gists{/gist_id}","starred_url":"https://api.github.com/users/boto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boto/subscriptions","organizations_url":"https://api.github.com/users/boto/orgs","repos_url":"https://api.github.com/users/boto/repos","events_url":"https://api.github.com/users/boto/events{/privacy}","received_events_url":"https://api.github.com/users/boto/received_events","type":"Organization","site_admin":false},"repo":{"id":6670942,"name":"botocore","full_name":"boto/botocore","owner":{"login":"boto","id":327752,"avatar_url":"https://avatars.githubusercontent.com/u/327752?v=3","gravatar_id":"","url":"https://api.github.com/users/boto","html_url":"https://github.com/boto","followers_url":"https://api.github.com/users/boto/followers","following_url":"https://api.github.com/users/boto/following{/other_user}","gists_url":"https://api.github.com/users/boto/gists{/gist_id}","starred_url":"https://api.github.com/users/boto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boto/subscriptions","organizations_url":"https://api.github.com/users/boto/orgs","repos_url":"https://api.github.com/users/boto/repos","events_url":"https://api.github.com/users/boto/events{/privacy}","received_events_url":"https://api.github.com/users/boto/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/boto/botocore","description":"The low-level, core functionality of boto 3.","fork":false,"url":"https://api.github.com/repos/boto/botocore","forks_url":"https://api.github.com/repos/boto/botocore/forks","keys_url":"https://api.github.com/repos/boto/botocore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/boto/botocore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/boto/botocore/teams","hooks_url":"https://api.github.com/repos/boto/botocore/hooks","issue_events_url":"https://api.github.com/repos/boto/botocore/issues/events{/number}","events_url":"https://api.github.com/repos/boto/botocore/events","assignees_url":"https://api.github.com/repos/boto/botocore/assignees{/user}","branches_url":"https://api.github.com/repos/boto/botocore/branches{/branch}","tags_url":"https://api.github.com/repos/boto/botocore/tags","blobs_url":"https://api.github.com/repos/boto/botocore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/boto/botocore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/boto/botocore/git/refs{/sha}","trees_url":"https://api.github.com/repos/boto/botocore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/boto/botocore/statuses/{sha}","languages_url":"https://api.github.com/repos/boto/botocore/languages","stargazers_url":"https://api.github.com/repos/boto/botocore/stargazers","contributors_url":"https://api.github.com/repos/boto/botocore/contributors","subscribers_url":"https://api.github.com/repos/boto/botocore/subscribers","subscription_url":"https://api.github.com/repos/boto/botocore/subscription","commits_url":"https://api.github.com/repos/boto/botocore/commits{/sha}","git_commits_url":"https://api.github.com/repos/boto/botocore/git/commits{/sha}","comments_url":"https://api.github.com/repos/boto/botocore/comments{/number}","issue_comment_url":"https://api.github.com/repos/boto/botocore/issues/comments/{number}","contents_url":"https://api.github.com/repos/boto/botocore/contents/{+path}","compare_url":"https://api.github.com/repos/boto/botocore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/boto/botocore/merges","archive_url":"https://api.github.com/repos/boto/botocore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/boto/botocore/downloads","issues_url":"https://api.github.com/repos/boto/botocore/issues{/number}","pulls_url":"https://api.github.com/repos/boto/botocore/pulls{/number}","milestones_url":"https://api.github.com/repos/boto/botocore/milestones{/number}","notifications_url":"https://api.github.com/repos/boto/botocore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/boto/botocore/labels{/name}","releases_url":"https://api.github.com/repos/boto/botocore/releases{/id}","created_at":"2012-11-13T13:25:36Z","updated_at":"2014-10-17T04:46:52Z","pushed_at":"2014-11-07T18:28:26Z","git_url":"git://github.com/boto/botocore.git","ssh_url":"git@github.com:boto/botocore.git","clone_url":"https://github.com/boto/botocore.git","svn_url":"https://github.com/boto/botocore","homepage":null,"size":21480,"stargazers_count":91,"watchers_count":91,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":67,"mirror_url":null,"open_issues_count":11,"forks":67,"open_issues":11,"watchers":91,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/boto/botocore/pulls/373"},"html":{"href":"https://github.com/boto/botocore/pull/373"},"issue":{"href":"https://api.github.com/repos/boto/botocore/issues/373"},"comments":{"href":"https://api.github.com/repos/boto/botocore/issues/373/comments"},"review_comments":{"href":"https://api.github.com/repos/boto/botocore/pulls/373/comments"},"review_comment":{"href":"https://api.github.com/repos/boto/botocore/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/boto/botocore/pulls/373/commits"},"statuses":{"href":"https://api.github.com/repos/boto/botocore/statuses/b40fad21522d3ee9617bf1c01a4b09c3237c26b5"}}}}