GitHub PullRequestReviewCommentEvent at 2014-10-21 16:57:06
Repository: omnibus-chef
Actor: jdmundrawala
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/opscode/omnibus-chef/pulls/comments/19161695","id":19161695,"diff_hunk":"@@ -50,7 +50,7 @@\n                   <File Id=\"RubyExecutable\" Source=\"$(var.ProjectSourceDir)\\embedded\\bin\\ruby.exe\" KeyPath=\"yes\" />\n                   <ServiceInstall Name=\"chef-client\" Type=\"ownProcess\"\n                                   Start=\"auto\" Vital=\"yes\" ErrorControl=\"ignore\"\n-                                  Arguments=\"[PROJECTLOCATION]$(var.ChefGemPath)\\lib\\chef\\application\\windows_service.rb\"\n+                                  Arguments=\"$(var.ProjectSourceDir)\\bin\\chef-windows-service\"","path":"resources/chef/msi/source.wxs.erb","position":5,"original_position":5,"commit_id":"3fca0daef30605297bc15126a709192d5a6671e0","original_commit_id":"3fca0daef30605297bc15126a709192d5a6671e0","user":{"login":"jdmundrawala","id":27443,"avatar_url":"https://avatars.githubusercontent.com/u/27443?v=2","gravatar_id":"","url":"https://api.github.com/users/jdmundrawala","html_url":"https://github.com/jdmundrawala","followers_url":"https://api.github.com/users/jdmundrawala/followers","following_url":"https://api.github.com/users/jdmundrawala/following{/other_user}","gists_url":"https://api.github.com/users/jdmundrawala/gists{/gist_id}","starred_url":"https://api.github.com/users/jdmundrawala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdmundrawala/subscriptions","organizations_url":"https://api.github.com/users/jdmundrawala/orgs","repos_url":"https://api.github.com/users/jdmundrawala/repos","events_url":"https://api.github.com/users/jdmundrawala/events{/privacy}","received_events_url":"https://api.github.com/users/jdmundrawala/received_events","type":"User","site_admin":false},"body":"Hmm. Appbundler generated:\r\n```ruby\r\n#!C:/opscode/chef/embedded/bin/ruby.exe\r\n#--APP_BUNDLER_BINSTUB_FORMAT_VERSION=1--\r\nENV[\"GEM_HOME\"] = ENV[\"GEM_PATH\"] = nil unless ENV[\"APPBUNDLER_ALLOW_RVM\"] == \"true\"\r\ngem \"chef-zero\", \"= 3.2\"\r\ngem \"ffi-yajl\", \"= 1.2.0\"\r\ngem \"ffi\", \"= 1.9.6\"\r\ngem \"libyajl2\", \"= 1.1.0\"\r\ngem \"hashie\", \"= 2.1.2\"\r\ngem \"mixlib-log\", \"= 1.6.0\"\r\ngem \"rack\", \"= 1.5.2\"\r\ngem \"uuidtools\", \"= 2.1.5\"\r\ngem \"diff-lcs\", \"= 1.2.5\"\r\ngem \"erubis\", \"= 2.7.0\"\r\ngem \"highline\", \"= 1.6.21\"\r\ngem \"mixlib-authentication\", \"= 1.3.0\"\r\ngem \"mixlib-cli\", \"= 1.5.0\"\r\ngem \"mixlib-config\", \"= 2.1.0\"\r\ngem \"mixlib-shellout\", \"= 2.0.0.rc.0\"\r\ngem \"win32-process\", \"= 0.7.3\"\r\ngem \"windows-pr\", \"= 1.2.2\"\r\ngem \"win32-api\", \"= 1.5.1\"\r\ngem \"windows-api\", \"= 0.4.2\"\r\ngem \"net-ssh\", \"= 2.9.1\"\r\ngem \"net-ssh-multi\", \"= 1.2.0\"\r\ngem \"net-ssh-gateway\", \"= 1.2.0\"\r\ngem \"ohai\", \"= 7.6.0.rc.0\"\r\ngem \"ipaddress\", \"= 0.8.0\"\r\ngem \"mime-types\", \"= 1.25.1\"\r\ngem \"net-dhcp\", \"= 1.2.1\"\r\ngem \"rake\", \"= 10.1.1\"\r\ngem \"systemu\", \"= 2.6.4\"\r\ngem \"wmi-lite\", \"= 1.0.0\"\r\ngem \"plist\", \"= 3.1.0\"\r\ngem \"pry\", \"= 0.10.1\"\r\ngem \"coderay\", \"= 1.1.0\"\r\ngem \"method_source\", \"= 0.8.2\"\r\ngem \"slop\", \"= 3.6.0\"\r\ngem \"win32console\", \"= 1.3.2\"\r\ngem \"win32-dir\", \"= 0.4.5\"\r\ngem \"win32-event\", \"= 0.6.1\"\r\ngem \"win32-ipc\", \"= 0.6.1\"\r\ngem \"win32-mmap\", \"= 0.4.0\"\r\ngem \"win32-mutex\", \"= 0.4.1\"\r\ngem \"win32-service\", \"= 0.8.2\"\r\n$:.unshift \"C:/opscode/chef/embedded/apps/chef/lib\"\r\nKernel.load 'C:/opscode/chef/embedded/apps/chef/bin/chef-windows-service'\r\n```\r\nIs this not enough to run?","created_at":"2014-10-21T16:57:06Z","updated_at":"2014-10-21T16:57:06Z","html_url":"https://github.com/opscode/omnibus-chef/pull/260#discussion_r19161695","pull_request_url":"https://api.github.com/repos/opscode/omnibus-chef/pulls/260","_links":{"self":{"href":"https://api.github.com/repos/opscode/omnibus-chef/pulls/comments/19161695"},"html":{"href":"https://github.com/opscode/omnibus-chef/pull/260#discussion_r19161695"},"pull_request":{"href":"https://api.github.com/repos/opscode/omnibus-chef/pulls/260"}}},"pull_request":{"url":"https://api.github.com/repos/opscode/omnibus-chef/pulls/260","id":22817539,"html_url":"https://github.com/opscode/omnibus-chef/pull/260","diff_url":"https://github.com/opscode/omnibus-chef/pull/260.diff","patch_url":"https://github.com/opscode/omnibus-chef/pull/260.patch","issue_url":"https://api.github.com/repos/opscode/omnibus-chef/issues/260","number":260,"state":"open","locked":false,"title":"Removing Gem installs","user":{"login":"jdmundrawala","id":27443,"avatar_url":"https://avatars.githubusercontent.com/u/27443?v=2","gravatar_id":"","url":"https://api.github.com/users/jdmundrawala","html_url":"https://github.com/jdmundrawala","followers_url":"https://api.github.com/users/jdmundrawala/followers","following_url":"https://api.github.com/users/jdmundrawala/following{/other_user}","gists_url":"https://api.github.com/users/jdmundrawala/gists{/gist_id}","starred_url":"https://api.github.com/users/jdmundrawala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdmundrawala/subscriptions","organizations_url":"https://api.github.com/users/jdmundrawala/orgs","repos_url":"https://api.github.com/users/jdmundrawala/repos","events_url":"https://api.github.com/users/jdmundrawala/events{/privacy}","received_events_url":"https://api.github.com/users/jdmundrawala/received_events","type":"User","site_admin":false},"body":"I don't think these gem installs do anything considering we use appbundler, which is just copying from the source directory (see https://github.com/opscode/omnibus/blob/cf4b18fb94f724956b28592cde0890fe42cf6fbe/lib/omnibus/builder.rb#L289).\r\nAlso pointing to chef app.\r\nThoughts?\r\ncc @danielsdeleo @opscode/client-engineers\r\n\r\nNote: This builds on windows, running through CI now","created_at":"2014-10-15T21:40:35Z","updated_at":"2014-10-21T16:57:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fd5ca2f3d92d7baa07016d16317c14df06eb7d2d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/opscode/omnibus-chef/pulls/260/commits","review_comments_url":"https://api.github.com/repos/opscode/omnibus-chef/pulls/260/comments","review_comment_url":"https://api.github.com/repos/opscode/omnibus-chef/pulls/comments/{number}","comments_url":"https://api.github.com/repos/opscode/omnibus-chef/issues/260/comments","statuses_url":"https://api.github.com/repos/opscode/omnibus-chef/statuses/3fca0daef30605297bc15126a709192d5a6671e0","head":{"label":"opscode:jdmundrawala/cruft","ref":"jdmundrawala/cruft","sha":"3fca0daef30605297bc15126a709192d5a6671e0","user":{"login":"opscode","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?v=2","gravatar_id":"","url":"https://api.github.com/users/opscode","html_url":"https://github.com/opscode","followers_url":"https://api.github.com/users/opscode/followers","following_url":"https://api.github.com/users/opscode/following{/other_user}","gists_url":"https://api.github.com/users/opscode/gists{/gist_id}","starred_url":"https://api.github.com/users/opscode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opscode/subscriptions","organizations_url":"https://api.github.com/users/opscode/orgs","repos_url":"https://api.github.com/users/opscode/repos","events_url":"https://api.github.com/users/opscode/events{/privacy}","received_events_url":"https://api.github.com/users/opscode/received_events","type":"Organization","site_admin":false},"repo":{"id":4056288,"name":"omnibus-chef","full_name":"opscode/omnibus-chef","owner":{"login":"opscode","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?v=2","gravatar_id":"","url":"https://api.github.com/users/opscode","html_url":"https://github.com/opscode","followers_url":"https://api.github.com/users/opscode/followers","following_url":"https://api.github.com/users/opscode/following{/other_user}","gists_url":"https://api.github.com/users/opscode/gists{/gist_id}","starred_url":"https://api.github.com/users/opscode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opscode/subscriptions","organizations_url":"https://api.github.com/users/opscode/orgs","repos_url":"https://api.github.com/users/opscode/repos","events_url":"https://api.github.com/users/opscode/events{/privacy}","received_events_url":"https://api.github.com/users/opscode/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opscode/omnibus-chef","description":"Omnibus packaging for Chef","fork":false,"url":"https://api.github.com/repos/opscode/omnibus-chef","forks_url":"https://api.github.com/repos/opscode/omnibus-chef/forks","keys_url":"https://api.github.com/repos/opscode/omnibus-chef/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opscode/omnibus-chef/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opscode/omnibus-chef/teams","hooks_url":"https://api.github.com/repos/opscode/omnibus-chef/hooks","issue_events_url":"https://api.github.com/repos/opscode/omnibus-chef/issues/events{/number}","events_url":"https://api.github.com/repos/opscode/omnibus-chef/events","assignees_url":"https://api.github.com/repos/opscode/omnibus-chef/assignees{/user}","branches_url":"https://api.github.com/repos/opscode/omnibus-chef/branches{/branch}","tags_url":"https://api.github.com/repos/opscode/omnibus-chef/tags","blobs_url":"https://api.github.com/repos/opscode/omnibus-chef/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opscode/omnibus-chef/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opscode/omnibus-chef/git/refs{/sha}","trees_url":"https://api.github.com/repos/opscode/omnibus-chef/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opscode/omnibus-chef/statuses/{sha}","languages_url":"https://api.github.com/repos/opscode/omnibus-chef/languages","stargazers_url":"https://api.github.com/repos/opscode/omnibus-chef/stargazers","contributors_url":"https://api.github.com/repos/opscode/omnibus-chef/contributors","subscribers_url":"https://api.github.com/repos/opscode/omnibus-chef/subscribers","subscription_url":"https://api.github.com/repos/opscode/omnibus-chef/subscription","commits_url":"https://api.github.com/repos/opscode/omnibus-chef/commits{/sha}","git_commits_url":"https://api.github.com/repos/opscode/omnibus-chef/git/commits{/sha}","comments_url":"https://api.github.com/repos/opscode/omnibus-chef/comments{/number}","issue_comment_url":"https://api.github.com/repos/opscode/omnibus-chef/issues/comments/{number}","contents_url":"https://api.github.com/repos/opscode/omnibus-chef/contents/{+path}","compare_url":"https://api.github.com/repos/opscode/omnibus-chef/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opscode/omnibus-chef/merges","archive_url":"https://api.github.com/repos/opscode/omnibus-chef/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opscode/omnibus-chef/downloads","issues_url":"https://api.github.com/repos/opscode/omnibus-chef/issues{/number}","pulls_url":"https://api.github.com/repos/opscode/omnibus-chef/pulls{/number}","milestones_url":"https://api.github.com/repos/opscode/omnibus-chef/milestones{/number}","notifications_url":"https://api.github.com/repos/opscode/omnibus-chef/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opscode/omnibus-chef/labels{/name}","releases_url":"https://api.github.com/repos/opscode/omnibus-chef/releases{/id}","created_at":"2012-04-17T19:22:38Z","updated_at":"2014-09-11T08:47:35Z","pushed_at":"2014-10-21T16:17:28Z","git_url":"git://github.com/opscode/omnibus-chef.git","ssh_url":"git@github.com:opscode/omnibus-chef.git","clone_url":"https://github.com/opscode/omnibus-chef.git","svn_url":"https://github.com/opscode/omnibus-chef","homepage":"","size":12253,"stargazers_count":61,"watchers_count":61,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":50,"mirror_url":null,"open_issues_count":9,"forks":50,"open_issues":9,"watchers":61,"default_branch":"master"}},"base":{"label":"opscode:master","ref":"master","sha":"bd62d006797a5f6a67607b557be4f580da8295ec","user":{"login":"opscode","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?v=2","gravatar_id":"","url":"https://api.github.com/users/opscode","html_url":"https://github.com/opscode","followers_url":"https://api.github.com/users/opscode/followers","following_url":"https://api.github.com/users/opscode/following{/other_user}","gists_url":"https://api.github.com/users/opscode/gists{/gist_id}","starred_url":"https://api.github.com/users/opscode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opscode/subscriptions","organizations_url":"https://api.github.com/users/opscode/orgs","repos_url":"https://api.github.com/users/opscode/repos","events_url":"https://api.github.com/users/opscode/events{/privacy}","received_events_url":"https://api.github.com/users/opscode/received_events","type":"Organization","site_admin":false},"repo":{"id":4056288,"name":"omnibus-chef","full_name":"opscode/omnibus-chef","owner":{"login":"opscode","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?v=2","gravatar_id":"","url":"https://api.github.com/users/opscode","html_url":"https://github.com/opscode","followers_url":"https://api.github.com/users/opscode/followers","following_url":"https://api.github.com/users/opscode/following{/other_user}","gists_url":"https://api.github.com/users/opscode/gists{/gist_id}","starred_url":"https://api.github.com/users/opscode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opscode/subscriptions","organizations_url":"https://api.github.com/users/opscode/orgs","repos_url":"https://api.github.com/users/opscode/repos","events_url":"https://api.github.com/users/opscode/events{/privacy}","received_events_url":"https://api.github.com/users/opscode/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opscode/omnibus-chef","description":"Omnibus packaging for Chef","fork":false,"url":"https://api.github.com/repos/opscode/omnibus-chef","forks_url":"https://api.github.com/repos/opscode/omnibus-chef/forks","keys_url":"https://api.github.com/repos/opscode/omnibus-chef/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opscode/omnibus-chef/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opscode/omnibus-chef/teams","hooks_url":"https://api.github.com/repos/opscode/omnibus-chef/hooks","issue_events_url":"https://api.github.com/repos/opscode/omnibus-chef/issues/events{/number}","events_url":"https://api.github.com/repos/opscode/omnibus-chef/events","assignees_url":"https://api.github.com/repos/opscode/omnibus-chef/assignees{/user}","branches_url":"https://api.github.com/repos/opscode/omnibus-chef/branches{/branch}","tags_url":"https://api.github.com/repos/opscode/omnibus-chef/tags","blobs_url":"https://api.github.com/repos/opscode/omnibus-chef/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opscode/omnibus-chef/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opscode/omnibus-chef/git/refs{/sha}","trees_url":"https://api.github.com/repos/opscode/omnibus-chef/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opscode/omnibus-chef/statuses/{sha}","languages_url":"https://api.github.com/repos/opscode/omnibus-chef/languages","stargazers_url":"https://api.github.com/repos/opscode/omnibus-chef/stargazers","contributors_url":"https://api.github.com/repos/opscode/omnibus-chef/contributors","subscribers_url":"https://api.github.com/repos/opscode/omnibus-chef/subscribers","subscription_url":"https://api.github.com/repos/opscode/omnibus-chef/subscription","commits_url":"https://api.github.com/repos/opscode/omnibus-chef/commits{/sha}","git_commits_url":"https://api.github.com/repos/opscode/omnibus-chef/git/commits{/sha}","comments_url":"https://api.github.com/repos/opscode/omnibus-chef/comments{/number}","issue_comment_url":"https://api.github.com/repos/opscode/omnibus-chef/issues/comments/{number}","contents_url":"https://api.github.com/repos/opscode/omnibus-chef/contents/{+path}","compare_url":"https://api.github.com/repos/opscode/omnibus-chef/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opscode/omnibus-chef/merges","archive_url":"https://api.github.com/repos/opscode/omnibus-chef/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opscode/omnibus-chef/downloads","issues_url":"https://api.github.com/repos/opscode/omnibus-chef/issues{/number}","pulls_url":"https://api.github.com/repos/opscode/omnibus-chef/pulls{/number}","milestones_url":"https://api.github.com/repos/opscode/omnibus-chef/milestones{/number}","notifications_url":"https://api.github.com/repos/opscode/omnibus-chef/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opscode/omnibus-chef/labels{/name}","releases_url":"https://api.github.com/repos/opscode/omnibus-chef/releases{/id}","created_at":"2012-04-17T19:22:38Z","updated_at":"2014-09-11T08:47:35Z","pushed_at":"2014-10-21T16:17:28Z","git_url":"git://github.com/opscode/omnibus-chef.git","ssh_url":"git@github.com:opscode/omnibus-chef.git","clone_url":"https://github.com/opscode/omnibus-chef.git","svn_url":"https://github.com/opscode/omnibus-chef","homepage":"","size":12253,"stargazers_count":61,"watchers_count":61,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":50,"mirror_url":null,"open_issues_count":9,"forks":50,"open_issues":9,"watchers":61,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opscode/omnibus-chef/pulls/260"},"html":{"href":"https://github.com/opscode/omnibus-chef/pull/260"},"issue":{"href":"https://api.github.com/repos/opscode/omnibus-chef/issues/260"},"comments":{"href":"https://api.github.com/repos/opscode/omnibus-chef/issues/260/comments"},"review_comments":{"href":"https://api.github.com/repos/opscode/omnibus-chef/pulls/260/comments"},"review_comment":{"href":"https://api.github.com/repos/opscode/omnibus-chef/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/opscode/omnibus-chef/pulls/260/commits"},"statuses":{"href":"https://api.github.com/repos/opscode/omnibus-chef/statuses/3fca0daef30605297bc15126a709192d5a6671e0"}}}}