GitHub PullRequestReviewCommentEvent at 2014-09-16 22:12:28
Repository: cfacter
Actor: vrthra
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/cfacter/pulls/comments/17634156","id":17634156,"diff_hunk":"@@ -0,0 +1,263 @@\n+#include <facter/facts/solaris/networking_resolver.hpp>\n+#include <facter/facts/collection.hpp>\n+#include <facter/facts/fact.hpp>\n+#include <facter/util/posix/scoped_descriptor.hpp>\n+#include <facter/facts/scalar_value.hpp>\n+#include <facter/execution/execution.hpp>\n+#include <facter/util/string.hpp>\n+#include <facter/logging/logging.hpp>\n+#include <boost/algorithm/string.hpp>\n+#include <sstream>\n+#include <cstring>\n+#include <sys/sockio.h>\n+#include <net/if_arp.h>\n+\n+using namespace std;\n+using namespace facter::util::posix;\n+using namespace facter::util;\n+using namespace facter::execution;\n+\n+LOG_DECLARE_NAMESPACE(\"facts.solaris.networking\");\n+\n+namespace facter { namespace facts { namespace solaris {\n+    void networking_resolver::resolve_interface_facts(collection& facts)\n+    {\n+        struct lifnum ifnr{.lifn_family = AF_UNSPEC, .lifn_flags = 0, .lifn_count = 0};\n+        scoped_descriptor ctl(socket(AF_INET, SOCK_DGRAM, 0));\n+        if (static_cast<int>(ctl) < 0) {\n+            LOG_DEBUG(\"resolve_interface_facts failed %1% %2%\", strerror(errno), errno);","path":"lib/src/facts/solaris/networking_resolver.cc","position":null,"original_position":28,"commit_id":"e037caf7e08433e0a3113ed661df5b926d36f854","original_commit_id":"31d243d539d06d2aeb488e2283c5550d924f8b58","user":{"login":"vrthra","id":70410,"avatar_url":"https://avatars.githubusercontent.com/u/70410?v=2","gravatar_id":"e691538fed1de0cc9b2f7cf1a0c11cb1","url":"https://api.github.com/users/vrthra","html_url":"https://github.com/vrthra","followers_url":"https://api.github.com/users/vrthra/followers","following_url":"https://api.github.com/users/vrthra/following{/other_user}","gists_url":"https://api.github.com/users/vrthra/gists{/gist_id}","starred_url":"https://api.github.com/users/vrthra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vrthra/subscriptions","organizations_url":"https://api.github.com/users/vrthra/orgs","repos_url":"https://api.github.com/users/vrthra/repos","events_url":"https://api.github.com/users/vrthra/events{/privacy}","received_events_url":"https://api.github.com/users/vrthra/received_events","type":"User","site_admin":false},"body":"updated","created_at":"2014-09-16T22:12:28Z","updated_at":"2014-09-16T22:12:28Z","html_url":"https://github.com/puppetlabs/cfacter/pull/118#discussion_r17634156","pull_request_url":"https://api.github.com/repos/puppetlabs/cfacter/pulls/118","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/cfacter/pulls/comments/17634156"},"html":{"href":"https://github.com/puppetlabs/cfacter/pull/118#discussion_r17634156"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/cfacter/pulls/118"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/cfacter/pulls/118","id":20827001,"html_url":"https://github.com/puppetlabs/cfacter/pull/118","diff_url":"https://github.com/puppetlabs/cfacter/pull/118.diff","patch_url":"https://github.com/puppetlabs/cfacter/pull/118.patch","issue_url":"https://api.github.com/repos/puppetlabs/cfacter/issues/118","number":118,"state":"open","locked":false,"title":"(CFACT-86) Networking facts for solaris","user":{"login":"vrthra","id":70410,"avatar_url":"https://avatars.githubusercontent.com/u/70410?v=2","gravatar_id":"e691538fed1de0cc9b2f7cf1a0c11cb1","url":"https://api.github.com/users/vrthra","html_url":"https://github.com/vrthra","followers_url":"https://api.github.com/users/vrthra/followers","following_url":"https://api.github.com/users/vrthra/following{/other_user}","gists_url":"https://api.github.com/users/vrthra/gists{/gist_id}","starred_url":"https://api.github.com/users/vrthra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vrthra/subscriptions","organizations_url":"https://api.github.com/users/vrthra/orgs","repos_url":"https://api.github.com/users/vrthra/repos","events_url":"https://api.github.com/users/vrthra/events{/privacy}","received_events_url":"https://api.github.com/users/vrthra/received_events","type":"User","site_admin":false},"body":"This patch adds support for networking facts for solaris. This is patterned on\r\nthe bsd networking resolver. \r\n","created_at":"2014-09-05T18:50:38Z","updated_at":"2014-09-16T22:12:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"06e748e03b00e99f43926d3dcb652c9ddc5c7ae5","assignee":{"login":"kylog","id":1752967,"avatar_url":"https://avatars.githubusercontent.com/u/1752967?v=2","gravatar_id":"e46db96a8767af9536fee9bc00b9f0af","url":"https://api.github.com/users/kylog","html_url":"https://github.com/kylog","followers_url":"https://api.github.com/users/kylog/followers","following_url":"https://api.github.com/users/kylog/following{/other_user}","gists_url":"https://api.github.com/users/kylog/gists{/gist_id}","starred_url":"https://api.github.com/users/kylog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kylog/subscriptions","organizations_url":"https://api.github.com/users/kylog/orgs","repos_url":"https://api.github.com/users/kylog/repos","events_url":"https://api.github.com/users/kylog/events{/privacy}","received_events_url":"https://api.github.com/users/kylog/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/cfacter/pulls/118/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/cfacter/pulls/118/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/cfacter/pulls/comments/{number}","comments_url":"https://api.github.com/repos/puppetlabs/cfacter/issues/118/comments","statuses_url":"https://api.github.com/repos/puppetlabs/cfacter/statuses/e037caf7e08433e0a3113ed661df5b926d36f854","head":{"label":"vrthra:fix/cfact-86/networking-solaris","ref":"fix/cfact-86/networking-solaris","sha":"e037caf7e08433e0a3113ed661df5b926d36f854","user":{"login":"vrthra","id":70410,"avatar_url":"https://avatars.githubusercontent.com/u/70410?v=2","gravatar_id":"e691538fed1de0cc9b2f7cf1a0c11cb1","url":"https://api.github.com/users/vrthra","html_url":"https://github.com/vrthra","followers_url":"https://api.github.com/users/vrthra/followers","following_url":"https://api.github.com/users/vrthra/following{/other_user}","gists_url":"https://api.github.com/users/vrthra/gists{/gist_id}","starred_url":"https://api.github.com/users/vrthra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vrthra/subscriptions","organizations_url":"https://api.github.com/users/vrthra/orgs","repos_url":"https://api.github.com/users/vrthra/repos","events_url":"https://api.github.com/users/vrthra/events{/privacy}","received_events_url":"https://api.github.com/users/vrthra/received_events","type":"User","site_admin":false},"repo":{"id":23197751,"name":"cfacter","full_name":"vrthra/cfacter","owner":{"login":"vrthra","id":70410,"avatar_url":"https://avatars.githubusercontent.com/u/70410?v=2","gravatar_id":"e691538fed1de0cc9b2f7cf1a0c11cb1","url":"https://api.github.com/users/vrthra","html_url":"https://github.com/vrthra","followers_url":"https://api.github.com/users/vrthra/followers","following_url":"https://api.github.com/users/vrthra/following{/other_user}","gists_url":"https://api.github.com/users/vrthra/gists{/gist_id}","starred_url":"https://api.github.com/users/vrthra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vrthra/subscriptions","organizations_url":"https://api.github.com/users/vrthra/orgs","repos_url":"https://api.github.com/users/vrthra/repos","events_url":"https://api.github.com/users/vrthra/events{/privacy}","received_events_url":"https://api.github.com/users/vrthra/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vrthra/cfacter","description":"Collect and display system facts from a C++ library.","fork":true,"url":"https://api.github.com/repos/vrthra/cfacter","forks_url":"https://api.github.com/repos/vrthra/cfacter/forks","keys_url":"https://api.github.com/repos/vrthra/cfacter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vrthra/cfacter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vrthra/cfacter/teams","hooks_url":"https://api.github.com/repos/vrthra/cfacter/hooks","issue_events_url":"https://api.github.com/repos/vrthra/cfacter/issues/events{/number}","events_url":"https://api.github.com/repos/vrthra/cfacter/events","assignees_url":"https://api.github.com/repos/vrthra/cfacter/assignees{/user}","branches_url":"https://api.github.com/repos/vrthra/cfacter/branches{/branch}","tags_url":"https://api.github.com/repos/vrthra/cfacter/tags","blobs_url":"https://api.github.com/repos/vrthra/cfacter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vrthra/cfacter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vrthra/cfacter/git/refs{/sha}","trees_url":"https://api.github.com/repos/vrthra/cfacter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vrthra/cfacter/statuses/{sha}","languages_url":"https://api.github.com/repos/vrthra/cfacter/languages","stargazers_url":"https://api.github.com/repos/vrthra/cfacter/stargazers","contributors_url":"https://api.github.com/repos/vrthra/cfacter/contributors","subscribers_url":"https://api.github.com/repos/vrthra/cfacter/subscribers","subscription_url":"https://api.github.com/repos/vrthra/cfacter/subscription","commits_url":"https://api.github.com/repos/vrthra/cfacter/commits{/sha}","git_commits_url":"https://api.github.com/repos/vrthra/cfacter/git/commits{/sha}","comments_url":"https://api.github.com/repos/vrthra/cfacter/comments{/number}","issue_comment_url":"https://api.github.com/repos/vrthra/cfacter/issues/comments/{number}","contents_url":"https://api.github.com/repos/vrthra/cfacter/contents/{+path}","compare_url":"https://api.github.com/repos/vrthra/cfacter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vrthra/cfacter/merges","archive_url":"https://api.github.com/repos/vrthra/cfacter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vrthra/cfacter/downloads","issues_url":"https://api.github.com/repos/vrthra/cfacter/issues{/number}","pulls_url":"https://api.github.com/repos/vrthra/cfacter/pulls{/number}","milestones_url":"https://api.github.com/repos/vrthra/cfacter/milestones{/number}","notifications_url":"https://api.github.com/repos/vrthra/cfacter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vrthra/cfacter/labels{/name}","releases_url":"https://api.github.com/repos/vrthra/cfacter/releases{/id}","created_at":"2014-08-21T18:12:18Z","updated_at":"2014-09-02T17:08:45Z","pushed_at":"2014-09-16T22:11:14Z","git_url":"git://github.com/vrthra/cfacter.git","ssh_url":"git@github.com:vrthra/cfacter.git","clone_url":"https://github.com/vrthra/cfacter.git","svn_url":"https://github.com/vrthra/cfacter","homepage":"https://tickets.puppetlabs.com/browse/CFACT","size":4943,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"c0c37e671a9641ca8de9ae363ca427c31489bf3f","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=2","gravatar_id":"eb454c2139c156db7c8266a875519a1f","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":17602228,"name":"cfacter","full_name":"puppetlabs/cfacter","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=2","gravatar_id":"eb454c2139c156db7c8266a875519a1f","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/cfacter","description":"Collect and display system facts from a C++ library.","fork":false,"url":"https://api.github.com/repos/puppetlabs/cfacter","forks_url":"https://api.github.com/repos/puppetlabs/cfacter/forks","keys_url":"https://api.github.com/repos/puppetlabs/cfacter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/cfacter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/cfacter/teams","hooks_url":"https://api.github.com/repos/puppetlabs/cfacter/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/cfacter/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/cfacter/events","assignees_url":"https://api.github.com/repos/puppetlabs/cfacter/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/cfacter/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/cfacter/tags","blobs_url":"https://api.github.com/repos/puppetlabs/cfacter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/cfacter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/cfacter/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/cfacter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/cfacter/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/cfacter/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/cfacter/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/cfacter/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/cfacter/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/cfacter/subscription","commits_url":"https://api.github.com/repos/puppetlabs/cfacter/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/cfacter/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/cfacter/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/cfacter/issues/comments/{number}","contents_url":"https://api.github.com/repos/puppetlabs/cfacter/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/cfacter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/cfacter/merges","archive_url":"https://api.github.com/repos/puppetlabs/cfacter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/cfacter/downloads","issues_url":"https://api.github.com/repos/puppetlabs/cfacter/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/cfacter/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/cfacter/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/cfacter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/cfacter/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/cfacter/releases{/id}","created_at":"2014-03-10T17:48:17Z","updated_at":"2014-09-15T11:16:47Z","pushed_at":"2014-09-16T22:10:19Z","git_url":"git://github.com/puppetlabs/cfacter.git","ssh_url":"git@github.com:puppetlabs/cfacter.git","clone_url":"https://github.com/puppetlabs/cfacter.git","svn_url":"https://github.com/puppetlabs/cfacter","homepage":"https://tickets.puppetlabs.com/browse/CFACT","size":79770,"stargazers_count":15,"watchers_count":15,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":4,"forks":16,"open_issues":4,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/cfacter/pulls/118"},"html":{"href":"https://github.com/puppetlabs/cfacter/pull/118"},"issue":{"href":"https://api.github.com/repos/puppetlabs/cfacter/issues/118"},"comments":{"href":"https://api.github.com/repos/puppetlabs/cfacter/issues/118/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/cfacter/pulls/118/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/cfacter/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/cfacter/pulls/118/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/cfacter/statuses/e037caf7e08433e0a3113ed661df5b926d36f854"}}}}