GitHub PullRequestEvent at 2014-09-26 12:59:31
Repository: Blocks
Actor: kevinmpowell
Payload: {"action":"closed","number":100,"pull_request":{"url":"https://api.github.com/repos/EightShapes/Blocks/pulls/100","id":21520920,"html_url":"https://github.com/EightShapes/Blocks/pull/100","diff_url":"https://github.com/EightShapes/Blocks/pull/100.diff","patch_url":"https://github.com/EightShapes/Blocks/pull/100.patch","issue_url":"https://api.github.com/repos/EightShapes/Blocks/issues/100","number":100,"state":"closed","locked":false,"title":"Feature/blocks viewer updates","user":{"login":"kevinmpowell","id":979463,"avatar_url":"https://avatars.githubusercontent.com/u/979463?v=2","gravatar_id":"","url":"https://api.github.com/users/kevinmpowell","html_url":"https://github.com/kevinmpowell","followers_url":"https://api.github.com/users/kevinmpowell/followers","following_url":"https://api.github.com/users/kevinmpowell/following{/other_user}","gists_url":"https://api.github.com/users/kevinmpowell/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinmpowell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinmpowell/subscriptions","organizations_url":"https://api.github.com/users/kevinmpowell/orgs","repos_url":"https://api.github.com/users/kevinmpowell/repos","events_url":"https://api.github.com/users/kevinmpowell/events{/privacy}","received_events_url":"https://api.github.com/users/kevinmpowell/received_events","type":"User","site_admin":false},"body":"@humancompanion, I've been working on some updates to BlocksViewer that @francisrupert requested. \r\nIssues are:\r\n[closes #95]\r\n[closes #96]\r\n[closes #97]\r\n[closes #98]\r\n\r\n### Approach\r\nThose issues have to do with the auto-sizing of the iFrame wrapper to match the content of the component inside. In working on these issues I did a line-by-line deep dive into the existing Viewer code to gain a better understanding of how it works. I had previously done some work on Viewer, adding the \"auto-zoom\" functionality, but this work was mostly hacked jQuery added at the end of the file trying to work after BlocksViewer had already parsed everything. In the process of addressing these four issues, I've also better integrated that previous work into the file.\r\n\r\n**Summary of updates**\r\n* Fix sizing bugs in #95, #96, and #97 \r\n* Fix resizing bug from #98 \r\n * Done by overlaying a hidden div on top of the iFrame while resizing, and removing the iFrame after the resize event has ended\r\n* Refactor previous \"auto-zoom\" code to fit into the existing Viewer process\r\n* Add JS-injected default styles, so it's more apparent when blocks has been activated\r\n * Add console NOTICE to inform of the injected styles and how to add a parameter to ````config.json```` to prevent the injection of default styles\r\n* Replace several ````setTimeout```` sections of code with a ````setInterval``` + ````clearInterval```` approach to ensure the correct timing and execution of the Viewer rendering process\r\n * I'm not sure what exact impacts this has had, but prior to these changes, Safari and Chrome would only render the last framed component on a page, after these changes Safari and Chrome correctly render all framed components.\r\n\r\nIf you want to set up a time to do a formal walkthrough of the code let me know. Otherwise, feel free to use line-by-line commenting. I did run this through JSHint and I've tried to keep the existing style of the document when implementing these changes.\r\n\r\nI also recommend **bumping to version 2.4.0**, since this represents a pretty significant update to Viewer.","created_at":"2014-09-19T20:13:36Z","updated_at":"2014-09-26T12:59:30Z","closed_at":"2014-09-26T12:59:30Z","merged_at":"2014-09-26T12:59:30Z","merge_commit_sha":"7edf9bff778d541cf6da34048bdfa484d568c89d","assignee":{"login":"humancompanion","id":352987,"avatar_url":"https://avatars.githubusercontent.com/u/352987?v=2","gravatar_id":"","url":"https://api.github.com/users/humancompanion","html_url":"https://github.com/humancompanion","followers_url":"https://api.github.com/users/humancompanion/followers","following_url":"https://api.github.com/users/humancompanion/following{/other_user}","gists_url":"https://api.github.com/users/humancompanion/gists{/gist_id}","starred_url":"https://api.github.com/users/humancompanion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/humancompanion/subscriptions","organizations_url":"https://api.github.com/users/humancompanion/orgs","repos_url":"https://api.github.com/users/humancompanion/repos","events_url":"https://api.github.com/users/humancompanion/events{/privacy}","received_events_url":"https://api.github.com/users/humancompanion/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/EightShapes/Blocks/pulls/100/commits","review_comments_url":"https://api.github.com/repos/EightShapes/Blocks/pulls/100/comments","review_comment_url":"https://api.github.com/repos/EightShapes/Blocks/pulls/comments/{number}","comments_url":"https://api.github.com/repos/EightShapes/Blocks/issues/100/comments","statuses_url":"https://api.github.com/repos/EightShapes/Blocks/statuses/9db4ab763b731266292a4fea1cd3877e36ef1245","head":{"label":"EightShapes:feature/blocks-viewer-updates","ref":"feature/blocks-viewer-updates","sha":"9db4ab763b731266292a4fea1cd3877e36ef1245","user":{"login":"EightShapes","id":1165923,"avatar_url":"https://avatars.githubusercontent.com/u/1165923?v=2","gravatar_id":"","url":"https://api.github.com/users/EightShapes","html_url":"https://github.com/EightShapes","followers_url":"https://api.github.com/users/EightShapes/followers","following_url":"https://api.github.com/users/EightShapes/following{/other_user}","gists_url":"https://api.github.com/users/EightShapes/gists{/gist_id}","starred_url":"https://api.github.com/users/EightShapes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EightShapes/subscriptions","organizations_url":"https://api.github.com/users/EightShapes/orgs","repos_url":"https://api.github.com/users/EightShapes/repos","events_url":"https://api.github.com/users/EightShapes/events{/privacy}","received_events_url":"https://api.github.com/users/EightShapes/received_events","type":"Organization","site_admin":false},"repo":{"id":2691011,"name":"Blocks","full_name":"EightShapes/Blocks","owner":{"login":"EightShapes","id":1165923,"avatar_url":"https://avatars.githubusercontent.com/u/1165923?v=2","gravatar_id":"","url":"https://api.github.com/users/EightShapes","html_url":"https://github.com/EightShapes","followers_url":"https://api.github.com/users/EightShapes/followers","following_url":"https://api.github.com/users/EightShapes/following{/other_user}","gists_url":"https://api.github.com/users/EightShapes/gists{/gist_id}","starred_url":"https://api.github.com/users/EightShapes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EightShapes/subscriptions","organizations_url":"https://api.github.com/users/EightShapes/orgs","repos_url":"https://api.github.com/users/EightShapes/repos","events_url":"https://api.github.com/users/EightShapes/events{/privacy}","received_events_url":"https://api.github.com/users/EightShapes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/EightShapes/Blocks","description":"HTML prototyping toolkit","fork":false,"url":"https://api.github.com/repos/EightShapes/Blocks","forks_url":"https://api.github.com/repos/EightShapes/Blocks/forks","keys_url":"https://api.github.com/repos/EightShapes/Blocks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EightShapes/Blocks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EightShapes/Blocks/teams","hooks_url":"https://api.github.com/repos/EightShapes/Blocks/hooks","issue_events_url":"https://api.github.com/repos/EightShapes/Blocks/issues/events{/number}","events_url":"https://api.github.com/repos/EightShapes/Blocks/events","assignees_url":"https://api.github.com/repos/EightShapes/Blocks/assignees{/user}","branches_url":"https://api.github.com/repos/EightShapes/Blocks/branches{/branch}","tags_url":"https://api.github.com/repos/EightShapes/Blocks/tags","blobs_url":"https://api.github.com/repos/EightShapes/Blocks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EightShapes/Blocks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EightShapes/Blocks/git/refs{/sha}","trees_url":"https://api.github.com/repos/EightShapes/Blocks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EightShapes/Blocks/statuses/{sha}","languages_url":"https://api.github.com/repos/EightShapes/Blocks/languages","stargazers_url":"https://api.github.com/repos/EightShapes/Blocks/stargazers","contributors_url":"https://api.github.com/repos/EightShapes/Blocks/contributors","subscribers_url":"https://api.github.com/repos/EightShapes/Blocks/subscribers","subscription_url":"https://api.github.com/repos/EightShapes/Blocks/subscription","commits_url":"https://api.github.com/repos/EightShapes/Blocks/commits{/sha}","git_commits_url":"https://api.github.com/repos/EightShapes/Blocks/git/commits{/sha}","comments_url":"https://api.github.com/repos/EightShapes/Blocks/comments{/number}","issue_comment_url":"https://api.github.com/repos/EightShapes/Blocks/issues/comments/{number}","contents_url":"https://api.github.com/repos/EightShapes/Blocks/contents/{+path}","compare_url":"https://api.github.com/repos/EightShapes/Blocks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EightShapes/Blocks/merges","archive_url":"https://api.github.com/repos/EightShapes/Blocks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EightShapes/Blocks/downloads","issues_url":"https://api.github.com/repos/EightShapes/Blocks/issues{/number}","pulls_url":"https://api.github.com/repos/EightShapes/Blocks/pulls{/number}","milestones_url":"https://api.github.com/repos/EightShapes/Blocks/milestones{/number}","notifications_url":"https://api.github.com/repos/EightShapes/Blocks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EightShapes/Blocks/labels{/name}","releases_url":"https://api.github.com/repos/EightShapes/Blocks/releases{/id}","created_at":"2011-11-01T21:39:09Z","updated_at":"2014-09-24T14:17:56Z","pushed_at":"2014-09-26T12:59:30Z","git_url":"git://github.com/EightShapes/Blocks.git","ssh_url":"git@github.com:EightShapes/Blocks.git","clone_url":"https://github.com/EightShapes/Blocks.git","svn_url":"https://github.com/EightShapes/Blocks","homepage":"","size":7427,"stargazers_count":101,"watchers_count":101,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":35,"mirror_url":null,"open_issues_count":6,"forks":35,"open_issues":6,"watchers":101,"default_branch":"master"}},"base":{"label":"EightShapes:master","ref":"master","sha":"de59165210a34e4bea19436a4440eac23c448799","user":{"login":"EightShapes","id":1165923,"avatar_url":"https://avatars.githubusercontent.com/u/1165923?v=2","gravatar_id":"","url":"https://api.github.com/users/EightShapes","html_url":"https://github.com/EightShapes","followers_url":"https://api.github.com/users/EightShapes/followers","following_url":"https://api.github.com/users/EightShapes/following{/other_user}","gists_url":"https://api.github.com/users/EightShapes/gists{/gist_id}","starred_url":"https://api.github.com/users/EightShapes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EightShapes/subscriptions","organizations_url":"https://api.github.com/users/EightShapes/orgs","repos_url":"https://api.github.com/users/EightShapes/repos","events_url":"https://api.github.com/users/EightShapes/events{/privacy}","received_events_url":"https://api.github.com/users/EightShapes/received_events","type":"Organization","site_admin":false},"repo":{"id":2691011,"name":"Blocks","full_name":"EightShapes/Blocks","owner":{"login":"EightShapes","id":1165923,"avatar_url":"https://avatars.githubusercontent.com/u/1165923?v=2","gravatar_id":"","url":"https://api.github.com/users/EightShapes","html_url":"https://github.com/EightShapes","followers_url":"https://api.github.com/users/EightShapes/followers","following_url":"https://api.github.com/users/EightShapes/following{/other_user}","gists_url":"https://api.github.com/users/EightShapes/gists{/gist_id}","starred_url":"https://api.github.com/users/EightShapes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EightShapes/subscriptions","organizations_url":"https://api.github.com/users/EightShapes/orgs","repos_url":"https://api.github.com/users/EightShapes/repos","events_url":"https://api.github.com/users/EightShapes/events{/privacy}","received_events_url":"https://api.github.com/users/EightShapes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/EightShapes/Blocks","description":"HTML prototyping toolkit","fork":false,"url":"https://api.github.com/repos/EightShapes/Blocks","forks_url":"https://api.github.com/repos/EightShapes/Blocks/forks","keys_url":"https://api.github.com/repos/EightShapes/Blocks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EightShapes/Blocks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EightShapes/Blocks/teams","hooks_url":"https://api.github.com/repos/EightShapes/Blocks/hooks","issue_events_url":"https://api.github.com/repos/EightShapes/Blocks/issues/events{/number}","events_url":"https://api.github.com/repos/EightShapes/Blocks/events","assignees_url":"https://api.github.com/repos/EightShapes/Blocks/assignees{/user}","branches_url":"https://api.github.com/repos/EightShapes/Blocks/branches{/branch}","tags_url":"https://api.github.com/repos/EightShapes/Blocks/tags","blobs_url":"https://api.github.com/repos/EightShapes/Blocks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EightShapes/Blocks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EightShapes/Blocks/git/refs{/sha}","trees_url":"https://api.github.com/repos/EightShapes/Blocks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EightShapes/Blocks/statuses/{sha}","languages_url":"https://api.github.com/repos/EightShapes/Blocks/languages","stargazers_url":"https://api.github.com/repos/EightShapes/Blocks/stargazers","contributors_url":"https://api.github.com/repos/EightShapes/Blocks/contributors","subscribers_url":"https://api.github.com/repos/EightShapes/Blocks/subscribers","subscription_url":"https://api.github.com/repos/EightShapes/Blocks/subscription","commits_url":"https://api.github.com/repos/EightShapes/Blocks/commits{/sha}","git_commits_url":"https://api.github.com/repos/EightShapes/Blocks/git/commits{/sha}","comments_url":"https://api.github.com/repos/EightShapes/Blocks/comments{/number}","issue_comment_url":"https://api.github.com/repos/EightShapes/Blocks/issues/comments/{number}","contents_url":"https://api.github.com/repos/EightShapes/Blocks/contents/{+path}","compare_url":"https://api.github.com/repos/EightShapes/Blocks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EightShapes/Blocks/merges","archive_url":"https://api.github.com/repos/EightShapes/Blocks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EightShapes/Blocks/downloads","issues_url":"https://api.github.com/repos/EightShapes/Blocks/issues{/number}","pulls_url":"https://api.github.com/repos/EightShapes/Blocks/pulls{/number}","milestones_url":"https://api.github.com/repos/EightShapes/Blocks/milestones{/number}","notifications_url":"https://api.github.com/repos/EightShapes/Blocks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EightShapes/Blocks/labels{/name}","releases_url":"https://api.github.com/repos/EightShapes/Blocks/releases{/id}","created_at":"2011-11-01T21:39:09Z","updated_at":"2014-09-24T14:17:56Z","pushed_at":"2014-09-26T12:59:30Z","git_url":"git://github.com/EightShapes/Blocks.git","ssh_url":"git@github.com:EightShapes/Blocks.git","clone_url":"https://github.com/EightShapes/Blocks.git","svn_url":"https://github.com/EightShapes/Blocks","homepage":"","size":7427,"stargazers_count":101,"watchers_count":101,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":35,"mirror_url":null,"open_issues_count":6,"forks":35,"open_issues":6,"watchers":101,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/EightShapes/Blocks/pulls/100"},"html":{"href":"https://github.com/EightShapes/Blocks/pull/100"},"issue":{"href":"https://api.github.com/repos/EightShapes/Blocks/issues/100"},"comments":{"href":"https://api.github.com/repos/EightShapes/Blocks/issues/100/comments"},"review_comments":{"href":"https://api.github.com/repos/EightShapes/Blocks/pulls/100/comments"},"review_comment":{"href":"https://api.github.com/repos/EightShapes/Blocks/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/EightShapes/Blocks/pulls/100/commits"},"statuses":{"href":"https://api.github.com/repos/EightShapes/Blocks/statuses/9db4ab763b731266292a4fea1cd3877e36ef1245"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"kevinmpowell","id":979463,"avatar_url":"https://avatars.githubusercontent.com/u/979463?v=2","gravatar_id":"","url":"https://api.github.com/users/kevinmpowell","html_url":"https://github.com/kevinmpowell","followers_url":"https://api.github.com/users/kevinmpowell/followers","following_url":"https://api.github.com/users/kevinmpowell/following{/other_user}","gists_url":"https://api.github.com/users/kevinmpowell/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinmpowell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinmpowell/subscriptions","organizations_url":"https://api.github.com/users/kevinmpowell/orgs","repos_url":"https://api.github.com/users/kevinmpowell/repos","events_url":"https://api.github.com/users/kevinmpowell/events{/privacy}","received_events_url":"https://api.github.com/users/kevinmpowell/received_events","type":"User","site_admin":false},"comments":0,"review_comments":3,"commits":15,"additions":324,"deletions":211,"changed_files":14}}