GitHub PullRequestEvent at 2014-05-22 07:48:01
Repository: RBDOOM-3-BFG
Actor: RobertBeckebans
Payload: {"action":"closed","number":125,"pull_request":{"url":"https://api.github.com/repos/RobertBeckebans/RBDOOM-3-BFG/pulls/125","id":16189986,"html_url":"https://github.com/RobertBeckebans/RBDOOM-3-BFG/pull/125","diff_url":"https://github.com/RobertBeckebans/RBDOOM-3-BFG/pull/125.diff","patch_url":"https://github.com/RobertBeckebans/RBDOOM-3-BFG/pull/125.patch","issue_url":"https://api.github.com/repos/RobertBeckebans/RBDOOM-3-BFG/issues/125","number":125,"state":"closed","title":"Replaced procfs dependent functions with native calls on OS X. #87","user":{"login":"JanSimek","id":1261493,"avatar_url":"https://avatars.githubusercontent.com/u/1261493?","gravatar_id":"6f74d87d40f017ec0cbf44a24ead9bda","url":"https://api.github.com/users/JanSimek","html_url":"https://github.com/JanSimek","followers_url":"https://api.github.com/users/JanSimek/followers","following_url":"https://api.github.com/users/JanSimek/following{/other_user}","gists_url":"https://api.github.com/users/JanSimek/gists{/gist_id}","starred_url":"https://api.github.com/users/JanSimek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JanSimek/subscriptions","organizations_url":"https://api.github.com/users/JanSimek/orgs","repos_url":"https://api.github.com/users/JanSimek/repos","events_url":"https://api.github.com/users/JanSimek/events{/privacy}","received_events_url":"https://api.github.com/users/JanSimek/received_events","type":"User","site_admin":false},"body":"I started replacing functions in linux_main.cpp which rely on procfs with OS X native calls and separating the two by ```#ifdefs```\r\n\r\nIn the end it looked really confusing, so I decided to move all the common functions into posix_main.cpp and separate platform specific ones into platform_linux.cpp and platform_osx.mm (contains objective-c++ code). It's not finished, it's not tested on linux and it breaks clang build (gcc compilation works) with this error: \r\n\r\n```error: Objective-C 1 was disabled in PCH file but is currently enabled```\r\n\r\nI wasn't sure if you were going to like this solution, so I submitted this pull request first before working on it further.","created_at":"2014-05-21T21:38:44Z","updated_at":"2014-05-22T07:48:01Z","closed_at":"2014-05-22T07:48:01Z","merged_at":"2014-05-22T07:48:01Z","merge_commit_sha":"d963d9e75e69dc2c4bb4bbe3dc81b43f0faa89e6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/RobertBeckebans/RBDOOM-3-BFG/pulls/125/commits","review_comments_url":"https://api.github.com/repos/RobertBeckebans/RBDOOM-3-BFG/pulls/125/comments","review_comment_url":"https://api.github.com/repos/RobertBeckebans/RBDOOM-3-BFG/pulls/comments/{number}","comments_url":"https://api.github.com/repos/RobertBeckebans/RBDOOM-3-BFG/issues/125/comments","statuses_url":"https://api.github.com/repos/RobertBeckebans/RBDOOM-3-BFG/statuses/e1f8597360e7e7c483760060aea92e482ed97b4b","head":{"label":"JanSimek:objective-c","ref":"objective-c","sha":"e1f8597360e7e7c483760060aea92e482ed97b4b","user":{"login":"JanSimek","id":1261493,"avatar_url":"https://avatars.githubusercontent.com/u/1261493?","gravatar_id":"6f74d87d40f017ec0cbf44a24ead9bda","url":"https://api.github.com/users/JanSimek","html_url":"https://github.com/JanSimek","followers_url":"https://api.github.com/users/JanSimek/followers","following_url":"https://api.github.com/users/JanSimek/following{/other_user}","gists_url":"https://api.github.com/users/JanSimek/gists{/gist_id}","starred_url":"https://api.github.com/users/JanSimek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JanSimek/subscriptions","organizations_url":"https://api.github.com/users/JanSimek/orgs","repos_url":"https://api.github.com/users/JanSimek/repos","events_url":"https://api.github.com/users/JanSimek/events{/privacy}","received_events_url":"https://api.github.com/users/JanSimek/received_events","type":"User","site_admin":false},"repo":{"id":19921978,"name":"RBDOOM-3-BFG","full_name":"JanSimek/RBDOOM-3-BFG","owner":{"login":"JanSimek","id":1261493,"avatar_url":"https://avatars.githubusercontent.com/u/1261493?","gravatar_id":"6f74d87d40f017ec0cbf44a24ead9bda","url":"https://api.github.com/users/JanSimek","html_url":"https://github.com/JanSimek","followers_url":"https://api.github.com/users/JanSimek/followers","following_url":"https://api.github.com/users/JanSimek/following{/other_user}","gists_url":"https://api.github.com/users/JanSimek/gists{/gist_id}","starred_url":"https://api.github.com/users/JanSimek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JanSimek/subscriptions","organizations_url":"https://api.github.com/users/JanSimek/orgs","repos_url":"https://api.github.com/users/JanSimek/repos","events_url":"https://api.github.com/users/JanSimek/events{/privacy}","received_events_url":"https://api.github.com/users/JanSimek/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JanSimek/RBDOOM-3-BFG","description":"Doom 3 BFG Edition with soft shadows, cleaned up source, Linux and 64 bit Support","fork":true,"url":"https://api.github.com/repos/JanSimek/RBDOOM-3-BFG","forks_url":"https://api.github.com/repos/JanSimek/RBDOOM-3-BFG/forks","keys_url":"https://api.github.com/repos/JanSimek/RBDOOM-3-BFG/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JanSimek/RBDOOM-3-BFG/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JanSimek/RBDOOM-3-BFG/teams","hooks_url":"https://api.github.com/repos/JanSimek/RBDOOM-3-BFG/hooks","issue_events_url":"https://api.github.com/repos/JanSimek/RBDOOM-3-BFG/issues/events{/number}","events_url":"https://api.github.com/repos/JanSimek/RBDOOM-3-BFG/events","assignees_url":"https://api.github.com/repos/JanSimek/RBDOOM-3-BFG/assignees{/user}","branches_url":"https://api.github.com/repos/JanSimek/RBDOOM-3-BFG/branches{/branch}","tags_url":"https://api.github.com/repos/JanSimek/RBDOOM-3-BFG/tags","blobs_url":"https://api.github.com/repos/JanSimek/RBDOOM-3-BFG/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JanSimek/RBDOOM-3-BFG/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JanSimek/RBDOOM-3-BFG/git/refs{/sha}","trees_url":"https://api.github.com/repos/JanSimek/RBDOOM-3-BFG/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JanSimek/RBDOOM-3-BFG/statuses/{sha}","languages_url":"https://api.github.com/repos/JanSimek/RBDOOM-3-BFG/languages","stargazers_url":"https://api.github.com/repos/JanSimek/RBDOOM-3-BFG/stargazers","contributors_url":"https://api.github.com/repos/JanSimek/RBDOOM-3-BFG/contributors","subscribers_url":"https://api.github.com/repos/JanSimek/RBDOOM-3-BFG/subscribers","subscription_url":"https://api.github.com/repos/JanSimek/RBDOOM-3-BFG/subscription","commits_url":"https://api.github.com/repos/JanSimek/RBDOOM-3-BFG/commits{/sha}","git_commits_url":"https://api.github.com/repos/JanSimek/RBDOOM-3-BFG/git/commits{/sha}","comments_url":"https://api.github.com/repos/JanSimek/RBDOOM-3-BFG/comments{/number}","issue_comment_url":"https://api.github.com/repos/JanSimek/RBDOOM-3-BFG/issues/comments/{number}","contents_url":"https://api.github.com/repos/JanSimek/RBDOOM-3-BFG/contents/{+path}","compare_url":"https://api.github.com/repos/JanSimek/RBDOOM-3-BFG/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JanSimek/RBDOOM-3-BFG/merges","archive_url":"https://api.github.com/repos/JanSimek/RBDOOM-3-BFG/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JanSimek/RBDOOM-3-BFG/downloads","issues_url":"https://api.github.com/repos/JanSimek/RBDOOM-3-BFG/issues{/number}","pulls_url":"https://api.github.com/repos/JanSimek/RBDOOM-3-BFG/pulls{/number}","milestones_url":"https://api.github.com/repos/JanSimek/RBDOOM-3-BFG/milestones{/number}","notifications_url":"https://api.github.com/repos/JanSimek/RBDOOM-3-BFG/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JanSimek/RBDOOM-3-BFG/labels{/name}","releases_url":"https://api.github.com/repos/JanSimek/RBDOOM-3-BFG/releases{/id}","created_at":"2014-05-18T21:51:35Z","updated_at":"2014-05-22T07:48:01Z","pushed_at":"2014-05-21T23:34:04Z","git_url":"git://github.com/JanSimek/RBDOOM-3-BFG.git","ssh_url":"git@github.com:JanSimek/RBDOOM-3-BFG.git","clone_url":"https://github.com/JanSimek/RBDOOM-3-BFG.git","svn_url":"https://github.com/JanSimek/RBDOOM-3-BFG","homepage":"","size":14055,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"RobertBeckebans:master","ref":"master","sha":"6d0765f3e3d2c297fd6933da6ea819b3b11c6591","user":{"login":"RobertBeckebans","id":1278614,"avatar_url":"https://avatars.githubusercontent.com/u/1278614?","gravatar_id":"c2358ab042fd3f18429636dc64d0c4f1","url":"https://api.github.com/users/RobertBeckebans","html_url":"https://github.com/RobertBeckebans","followers_url":"https://api.github.com/users/RobertBeckebans/followers","following_url":"https://api.github.com/users/RobertBeckebans/following{/other_user}","gists_url":"https://api.github.com/users/RobertBeckebans/gists{/gist_id}","starred_url":"https://api.github.com/users/RobertBeckebans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RobertBeckebans/subscriptions","organizations_url":"https://api.github.com/users/RobertBeckebans/orgs","repos_url":"https://api.github.com/users/RobertBeckebans/repos","events_url":"https://api.github.com/users/RobertBeckebans/events{/privacy}","received_events_url":"https://api.github.com/users/RobertBeckebans/received_events","type":"User","site_admin":false},"repo":{"id":6879750,"name":"RBDOOM-3-BFG","full_name":"RobertBeckebans/RBDOOM-3-BFG","owner":{"login":"RobertBeckebans","id":1278614,"avatar_url":"https://avatars.githubusercontent.com/u/1278614?","gravatar_id":"c2358ab042fd3f18429636dc64d0c4f1","url":"https://api.github.com/users/RobertBeckebans","html_url":"https://github.com/RobertBeckebans","followers_url":"https://api.github.com/users/RobertBeckebans/followers","following_url":"https://api.github.com/users/RobertBeckebans/following{/other_user}","gists_url":"https://api.github.com/users/RobertBeckebans/gists{/gist_id}","starred_url":"https://api.github.com/users/RobertBeckebans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RobertBeckebans/subscriptions","organizations_url":"https://api.github.com/users/RobertBeckebans/orgs","repos_url":"https://api.github.com/users/RobertBeckebans/repos","events_url":"https://api.github.com/users/RobertBeckebans/events{/privacy}","received_events_url":"https://api.github.com/users/RobertBeckebans/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/RobertBeckebans/RBDOOM-3-BFG","description":"Doom 3 BFG Edition with soft shadows, cleaned up source, Linux and 64 bit Support","fork":true,"url":"https://api.github.com/repos/RobertBeckebans/RBDOOM-3-BFG","forks_url":"https://api.github.com/repos/RobertBeckebans/RBDOOM-3-BFG/forks","keys_url":"https://api.github.com/repos/RobertBeckebans/RBDOOM-3-BFG/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RobertBeckebans/RBDOOM-3-BFG/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RobertBeckebans/RBDOOM-3-BFG/teams","hooks_url":"https://api.github.com/repos/RobertBeckebans/RBDOOM-3-BFG/hooks","issue_events_url":"https://api.github.com/repos/RobertBeckebans/RBDOOM-3-BFG/issues/events{/number}","events_url":"https://api.github.com/repos/RobertBeckebans/RBDOOM-3-BFG/events","assignees_url":"https://api.github.com/repos/RobertBeckebans/RBDOOM-3-BFG/assignees{/user}","branches_url":"https://api.github.com/repos/RobertBeckebans/RBDOOM-3-BFG/branches{/branch}","tags_url":"https://api.github.com/repos/RobertBeckebans/RBDOOM-3-BFG/tags","blobs_url":"https://api.github.com/repos/RobertBeckebans/RBDOOM-3-BFG/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RobertBeckebans/RBDOOM-3-BFG/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RobertBeckebans/RBDOOM-3-BFG/git/refs{/sha}","trees_url":"https://api.github.com/repos/RobertBeckebans/RBDOOM-3-BFG/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RobertBeckebans/RBDOOM-3-BFG/statuses/{sha}","languages_url":"https://api.github.com/repos/RobertBeckebans/RBDOOM-3-BFG/languages","stargazers_url":"https://api.github.com/repos/RobertBeckebans/RBDOOM-3-BFG/stargazers","contributors_url":"https://api.github.com/repos/RobertBeckebans/RBDOOM-3-BFG/contributors","subscribers_url":"https://api.github.com/repos/RobertBeckebans/RBDOOM-3-BFG/subscribers","subscription_url":"https://api.github.com/repos/RobertBeckebans/RBDOOM-3-BFG/subscription","commits_url":"https://api.github.com/repos/RobertBeckebans/RBDOOM-3-BFG/commits{/sha}","git_commits_url":"https://api.github.com/repos/RobertBeckebans/RBDOOM-3-BFG/git/commits{/sha}","comments_url":"https://api.github.com/repos/RobertBeckebans/RBDOOM-3-BFG/comments{/number}","issue_comment_url":"https://api.github.com/repos/RobertBeckebans/RBDOOM-3-BFG/issues/comments/{number}","contents_url":"https://api.github.com/repos/RobertBeckebans/RBDOOM-3-BFG/contents/{+path}","compare_url":"https://api.github.com/repos/RobertBeckebans/RBDOOM-3-BFG/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RobertBeckebans/RBDOOM-3-BFG/merges","archive_url":"https://api.github.com/repos/RobertBeckebans/RBDOOM-3-BFG/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RobertBeckebans/RBDOOM-3-BFG/downloads","issues_url":"https://api.github.com/repos/RobertBeckebans/RBDOOM-3-BFG/issues{/number}","pulls_url":"https://api.github.com/repos/RobertBeckebans/RBDOOM-3-BFG/pulls{/number}","milestones_url":"https://api.github.com/repos/RobertBeckebans/RBDOOM-3-BFG/milestones{/number}","notifications_url":"https://api.github.com/repos/RobertBeckebans/RBDOOM-3-BFG/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RobertBeckebans/RBDOOM-3-BFG/labels{/name}","releases_url":"https://api.github.com/repos/RobertBeckebans/RBDOOM-3-BFG/releases{/id}","created_at":"2012-11-27T08:22:56Z","updated_at":"2014-05-22T07:48:01Z","pushed_at":"2014-05-22T07:48:01Z","git_url":"git://github.com/RobertBeckebans/RBDOOM-3-BFG.git","ssh_url":"git@github.com:RobertBeckebans/RBDOOM-3-BFG.git","clone_url":"https://github.com/RobertBeckebans/RBDOOM-3-BFG.git","svn_url":"https://github.com/RobertBeckebans/RBDOOM-3-BFG","homepage":"","size":14055,"stargazers_count":142,"watchers_count":142,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":39,"mirror_url":null,"open_issues_count":13,"forks":39,"open_issues":13,"watchers":142,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RobertBeckebans/RBDOOM-3-BFG/pulls/125"},"html":{"href":"https://github.com/RobertBeckebans/RBDOOM-3-BFG/pull/125"},"issue":{"href":"https://api.github.com/repos/RobertBeckebans/RBDOOM-3-BFG/issues/125"},"comments":{"href":"https://api.github.com/repos/RobertBeckebans/RBDOOM-3-BFG/issues/125/comments"},"review_comments":{"href":"https://api.github.com/repos/RobertBeckebans/RBDOOM-3-BFG/pulls/125/comments"},"review_comment":{"href":"https://api.github.com/repos/RobertBeckebans/RBDOOM-3-BFG/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/RobertBeckebans/RBDOOM-3-BFG/pulls/125/commits"},"statuses":{"href":"https://api.github.com/repos/RobertBeckebans/RBDOOM-3-BFG/statuses/e1f8597360e7e7c483760060aea92e482ed97b4b"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"RobertBeckebans","id":1278614,"avatar_url":"https://avatars.githubusercontent.com/u/1278614?","gravatar_id":"c2358ab042fd3f18429636dc64d0c4f1","url":"https://api.github.com/users/RobertBeckebans","html_url":"https://github.com/RobertBeckebans","followers_url":"https://api.github.com/users/RobertBeckebans/followers","following_url":"https://api.github.com/users/RobertBeckebans/following{/other_user}","gists_url":"https://api.github.com/users/RobertBeckebans/gists{/gist_id}","starred_url":"https://api.github.com/users/RobertBeckebans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RobertBeckebans/subscriptions","organizations_url":"https://api.github.com/users/RobertBeckebans/orgs","repos_url":"https://api.github.com/users/RobertBeckebans/repos","events_url":"https://api.github.com/users/RobertBeckebans/events{/privacy}","received_events_url":"https://api.github.com/users/RobertBeckebans/received_events","type":"User","site_admin":false},"comments":4,"review_comments":0,"commits":3,"additions":725,"deletions":293,"changed_files":7}}