GitHub PullRequestReviewCommentEvent at 2014-08-22 09:49:57
Repository: mercury
Actor: hakubo
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/Wikia/mercury/pulls/comments/16589989","id":16589989,"diff_hunk":"@@ -0,0 +1,49 @@\n+/// <reference path=\"../app.ts\" />\n+'use strict';\n+\n+App.SideNavView = Em.View.extend({\n+\ttagName: 'nav',\n+\tclassNames: ['side-nav'],\n+\tclassNameBindings: ['isCollapsed:hidden:slide-into-view'],\n+\tisCollapsed: true,\n+\tlayoutName: 'app/side-nav',\n+\n+\tactions: {\n+\t\texpandSideNav: function (): void {\n+\t\t\tthis.set('isCollapsed', false);\n+\t\t\tEmber.$('body').addClass('no-scroll');","path":"public/scripts/main/views/SideNavView.ts","position":14,"original_position":14,"commit_id":"ad0608e1c1dd4a2f537f05859452f088e0a51d7f","original_commit_id":"ad0608e1c1dd4a2f537f05859452f088e0a51d7f","user":{"login":"hakubo","id":1018759,"avatar_url":"https://avatars.githubusercontent.com/u/1018759?v=2","gravatar_id":"436a51c106f26ddb5e5379479842c8c0","url":"https://api.github.com/users/hakubo","html_url":"https://github.com/hakubo","followers_url":"https://api.github.com/users/hakubo/followers","following_url":"https://api.github.com/users/hakubo/following{/other_user}","gists_url":"https://api.github.com/users/hakubo/gists{/gist_id}","starred_url":"https://api.github.com/users/hakubo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hakubo/subscriptions","organizations_url":"https://api.github.com/users/hakubo/orgs","repos_url":"https://api.github.com/users/hakubo/repos","events_url":"https://api.github.com/users/hakubo/events{/privacy}","received_events_url":"https://api.github.com/users/hakubo/received_events","type":"User","site_admin":false},"body":"I am not a fun of stuff like this,\r\nthis brakes the experience, and feels like something is broken","created_at":"2014-08-22T09:49:57Z","updated_at":"2014-08-22T09:49:57Z","html_url":"https://github.com/Wikia/mercury/pull/110#discussion_r16589989","pull_request_url":"https://api.github.com/repos/Wikia/mercury/pulls/110","_links":{"self":{"href":"https://api.github.com/repos/Wikia/mercury/pulls/comments/16589989"},"html":{"href":"https://github.com/Wikia/mercury/pull/110#discussion_r16589989"},"pull_request":{"href":"https://api.github.com/repos/Wikia/mercury/pulls/110"}}},"pull_request":{"url":"https://api.github.com/repos/Wikia/mercury/pulls/110","id":19353637,"html_url":"https://github.com/Wikia/mercury/pull/110","diff_url":"https://github.com/Wikia/mercury/pull/110.diff","patch_url":"https://github.com/Wikia/mercury/pull/110.patch","issue_url":"https://api.github.com/repos/Wikia/mercury/issues/110","number":110,"state":"open","locked":false,"title":"Hg 91 top nav bar","user":{"login":"benmai","id":7683112,"avatar_url":"https://avatars.githubusercontent.com/u/7683112?v=2","gravatar_id":"bb0a95b776b13b712ae7a5f68e83a3cb","url":"https://api.github.com/users/benmai","html_url":"https://github.com/benmai","followers_url":"https://api.github.com/users/benmai/followers","following_url":"https://api.github.com/users/benmai/following{/other_user}","gists_url":"https://api.github.com/users/benmai/gists{/gist_id}","starred_url":"https://api.github.com/users/benmai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benmai/subscriptions","organizations_url":"https://api.github.com/users/benmai/orgs","repos_url":"https://api.github.com/users/benmai/repos","events_url":"https://api.github.com/users/benmai/events{/privacy}","received_events_url":"https://api.github.com/users/benmai/received_events","type":"User","site_admin":false},"body":"@hakubo @kenkouot \r\n\r\nThis is the branch for the Wikia nav menu -- you tap the icon to the left of the Wikia icon, and it slides out. Both navigation and search are functional, and just need some touch-up.\r\n\r\n**TODOs**\r\nFor slide-out menu overall:\r\n- [x] Why does Travis fail on the integration test _every time_ on this branch???\r\n- [x] Make sure the 'x' button on the search bar is correctly clickable (it was acting up)\r\n- [ ] If at all possible enforce a _13px_ margin between the search bar and 'Cancel' link while maintaining the 13px margins on the outer sides of both\r\n- [ ] Comb through style, normalize style between search and nav (there probably is a better way of organizing the style files, as it is they are quite cumbersome)\r\n\r\nFor Navigation:\r\n- [ ] Add sliding menus\r\n - [ ] Add cache of already-rendered menu panes\r\n- [ ] Add touch states\r\n\r\nFor Search:\r\n- Styling:\r\n - [x] Review styling overall\r\n- Functionality:\r\n - [x] Internationalize messages (placeholder text, No Results/Loading... messages) \r\n - [ ] Review nodejs-side search API design\r\n - [x] Reconcile node/initial page load changes with @hakubo's PR #111 \r\n","created_at":"2014-08-05T16:38:59Z","updated_at":"2014-08-22T09:49:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"de7a6242820a09e39c8cc03f44aaea1cdf70d90e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Wikia/mercury/pulls/110/commits","review_comments_url":"https://api.github.com/repos/Wikia/mercury/pulls/110/comments","review_comment_url":"https://api.github.com/repos/Wikia/mercury/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Wikia/mercury/issues/110/comments","statuses_url":"https://api.github.com/repos/Wikia/mercury/statuses/ad0608e1c1dd4a2f537f05859452f088e0a51d7f","head":{"label":"Wikia:HG-91-top-nav-bar","ref":"HG-91-top-nav-bar","sha":"ad0608e1c1dd4a2f537f05859452f088e0a51d7f","user":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=2","gravatar_id":"7d465709e42f40da92f14aae7e005558","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"repo":{"id":16710430,"name":"mercury","full_name":"Wikia/mercury","owner":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=2","gravatar_id":"7d465709e42f40da92f14aae7e005558","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Wikia/mercury","description":"","fork":false,"url":"https://api.github.com/repos/Wikia/mercury","forks_url":"https://api.github.com/repos/Wikia/mercury/forks","keys_url":"https://api.github.com/repos/Wikia/mercury/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Wikia/mercury/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Wikia/mercury/teams","hooks_url":"https://api.github.com/repos/Wikia/mercury/hooks","issue_events_url":"https://api.github.com/repos/Wikia/mercury/issues/events{/number}","events_url":"https://api.github.com/repos/Wikia/mercury/events","assignees_url":"https://api.github.com/repos/Wikia/mercury/assignees{/user}","branches_url":"https://api.github.com/repos/Wikia/mercury/branches{/branch}","tags_url":"https://api.github.com/repos/Wikia/mercury/tags","blobs_url":"https://api.github.com/repos/Wikia/mercury/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Wikia/mercury/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Wikia/mercury/git/refs{/sha}","trees_url":"https://api.github.com/repos/Wikia/mercury/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Wikia/mercury/statuses/{sha}","languages_url":"https://api.github.com/repos/Wikia/mercury/languages","stargazers_url":"https://api.github.com/repos/Wikia/mercury/stargazers","contributors_url":"https://api.github.com/repos/Wikia/mercury/contributors","subscribers_url":"https://api.github.com/repos/Wikia/mercury/subscribers","subscription_url":"https://api.github.com/repos/Wikia/mercury/subscription","commits_url":"https://api.github.com/repos/Wikia/mercury/commits{/sha}","git_commits_url":"https://api.github.com/repos/Wikia/mercury/git/commits{/sha}","comments_url":"https://api.github.com/repos/Wikia/mercury/comments{/number}","issue_comment_url":"https://api.github.com/repos/Wikia/mercury/issues/comments/{number}","contents_url":"https://api.github.com/repos/Wikia/mercury/contents/{+path}","compare_url":"https://api.github.com/repos/Wikia/mercury/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Wikia/mercury/merges","archive_url":"https://api.github.com/repos/Wikia/mercury/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Wikia/mercury/downloads","issues_url":"https://api.github.com/repos/Wikia/mercury/issues{/number}","pulls_url":"https://api.github.com/repos/Wikia/mercury/pulls{/number}","milestones_url":"https://api.github.com/repos/Wikia/mercury/milestones{/number}","notifications_url":"https://api.github.com/repos/Wikia/mercury/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Wikia/mercury/labels{/name}","releases_url":"https://api.github.com/repos/Wikia/mercury/releases{/id}","created_at":"2014-02-10T21:44:25Z","updated_at":"2014-08-21T08:46:21Z","pushed_at":"2014-08-22T09:34:26Z","git_url":"git://github.com/Wikia/mercury.git","ssh_url":"git@github.com:Wikia/mercury.git","clone_url":"https://github.com/Wikia/mercury.git","svn_url":"https://github.com/Wikia/mercury","homepage":null,"size":6596,"stargazers_count":3,"watchers_count":3,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":3,"default_branch":"master"}},"base":{"label":"Wikia:master","ref":"master","sha":"9ad73438d46dec01c92fbb4989340d931498f894","user":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=2","gravatar_id":"7d465709e42f40da92f14aae7e005558","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"repo":{"id":16710430,"name":"mercury","full_name":"Wikia/mercury","owner":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=2","gravatar_id":"7d465709e42f40da92f14aae7e005558","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Wikia/mercury","description":"","fork":false,"url":"https://api.github.com/repos/Wikia/mercury","forks_url":"https://api.github.com/repos/Wikia/mercury/forks","keys_url":"https://api.github.com/repos/Wikia/mercury/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Wikia/mercury/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Wikia/mercury/teams","hooks_url":"https://api.github.com/repos/Wikia/mercury/hooks","issue_events_url":"https://api.github.com/repos/Wikia/mercury/issues/events{/number}","events_url":"https://api.github.com/repos/Wikia/mercury/events","assignees_url":"https://api.github.com/repos/Wikia/mercury/assignees{/user}","branches_url":"https://api.github.com/repos/Wikia/mercury/branches{/branch}","tags_url":"https://api.github.com/repos/Wikia/mercury/tags","blobs_url":"https://api.github.com/repos/Wikia/mercury/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Wikia/mercury/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Wikia/mercury/git/refs{/sha}","trees_url":"https://api.github.com/repos/Wikia/mercury/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Wikia/mercury/statuses/{sha}","languages_url":"https://api.github.com/repos/Wikia/mercury/languages","stargazers_url":"https://api.github.com/repos/Wikia/mercury/stargazers","contributors_url":"https://api.github.com/repos/Wikia/mercury/contributors","subscribers_url":"https://api.github.com/repos/Wikia/mercury/subscribers","subscription_url":"https://api.github.com/repos/Wikia/mercury/subscription","commits_url":"https://api.github.com/repos/Wikia/mercury/commits{/sha}","git_commits_url":"https://api.github.com/repos/Wikia/mercury/git/commits{/sha}","comments_url":"https://api.github.com/repos/Wikia/mercury/comments{/number}","issue_comment_url":"https://api.github.com/repos/Wikia/mercury/issues/comments/{number}","contents_url":"https://api.github.com/repos/Wikia/mercury/contents/{+path}","compare_url":"https://api.github.com/repos/Wikia/mercury/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Wikia/mercury/merges","archive_url":"https://api.github.com/repos/Wikia/mercury/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Wikia/mercury/downloads","issues_url":"https://api.github.com/repos/Wikia/mercury/issues{/number}","pulls_url":"https://api.github.com/repos/Wikia/mercury/pulls{/number}","milestones_url":"https://api.github.com/repos/Wikia/mercury/milestones{/number}","notifications_url":"https://api.github.com/repos/Wikia/mercury/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Wikia/mercury/labels{/name}","releases_url":"https://api.github.com/repos/Wikia/mercury/releases{/id}","created_at":"2014-02-10T21:44:25Z","updated_at":"2014-08-21T08:46:21Z","pushed_at":"2014-08-22T09:34:26Z","git_url":"git://github.com/Wikia/mercury.git","ssh_url":"git@github.com:Wikia/mercury.git","clone_url":"https://github.com/Wikia/mercury.git","svn_url":"https://github.com/Wikia/mercury","homepage":null,"size":6596,"stargazers_count":3,"watchers_count":3,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Wikia/mercury/pulls/110"},"html":{"href":"https://github.com/Wikia/mercury/pull/110"},"issue":{"href":"https://api.github.com/repos/Wikia/mercury/issues/110"},"comments":{"href":"https://api.github.com/repos/Wikia/mercury/issues/110/comments"},"review_comments":{"href":"https://api.github.com/repos/Wikia/mercury/pulls/110/comments"},"review_comment":{"href":"https://api.github.com/repos/Wikia/mercury/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Wikia/mercury/pulls/110/commits"},"statuses":{"href":"https://api.github.com/repos/Wikia/mercury/statuses/ad0608e1c1dd4a2f537f05859452f088e0a51d7f"}}}}