GitHub PullRequestReviewCommentEvent at 2014-12-09 16:11:09
Repository: flood
Actor: marimano
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/pboyer/flood/pulls/comments/21538724","id":21538724,"diff_hunk":"@@ -133,22 +133,18 @@ define([  'backbone',\n \n       var isBackspaceOrDelete = e.keyCode === 46 || e.keyCode === 8;\n \n-      if ( !(e.metaKey || e.ctrlKey) && !isBackspaceOrDelete ) return;\n+      if ( !(e.metaKey || e.ctrlKey) && !isBackspaceOrDelete )\n+          return;\n \n-      // do not capture from input\n-      if (e.originalEvent.srcElement && e.originalEvent.srcElement.nodeName === \"INPUT\") return;\n-      if (e.target.nodeName === \"INPUT\") return;\n+      var excludedNames = [\"INPUT\", \"CODE\", \"TEXTAREA\"];\n+      var srcEl = e.originalEvent.srcElement;\n \n-      // do not capture from textarea\n-      if (e.originalEvent.srcElement && e.originalEvent.srcElement.nodeName === \"CODE\" ) return;\n-      if (e.target.nodeName === \"CODE\") return;\n+      // do not capture from input and textarea\n+      if (srcEl && excludedNames.indexOf(srcEl.nodeName) > -1\n+          || excludedNames.indexOf(e.target.nodeName) > -1)\n+          return;\n \n       // keycodes: http://css-tricks.com/snippets/javascript/javascript-keycodes/\n-      switch (e.keyCode) {\n-        case 78:\n-          this.newWorkspace();\n-          return e.preventDefault();\n-      }","path":"app/scripts/views/AppView.js","position":27,"original_position":27,"commit_id":"bc5bba2ff3499acf9e502dc315214610ef76bfab","original_commit_id":"bc5bba2ff3499acf9e502dc315214610ef76bfab","user":{"login":"marimano","id":7658189,"avatar_url":"https://avatars.githubusercontent.com/u/7658189?v=3","gravatar_id":"","url":"https://api.github.com/users/marimano","html_url":"https://github.com/marimano","followers_url":"https://api.github.com/users/marimano/followers","following_url":"https://api.github.com/users/marimano/following{/other_user}","gists_url":"https://api.github.com/users/marimano/gists{/gist_id}","starred_url":"https://api.github.com/users/marimano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marimano/subscriptions","organizations_url":"https://api.github.com/users/marimano/orgs","repos_url":"https://api.github.com/users/marimano/repos","events_url":"https://api.github.com/users/marimano/events{/privacy}","received_events_url":"https://api.github.com/users/marimano/received_events","type":"User","site_admin":false},"body":"adding one more Home ws is not allowed anymore. So adding should be forbidden here as well","created_at":"2014-12-09T16:11:09Z","updated_at":"2014-12-09T16:11:09Z","html_url":"https://github.com/pboyer/flood/pull/94#discussion_r21538724","pull_request_url":"https://api.github.com/repos/pboyer/flood/pulls/94","_links":{"self":{"href":"https://api.github.com/repos/pboyer/flood/pulls/comments/21538724"},"html":{"href":"https://github.com/pboyer/flood/pull/94#discussion_r21538724"},"pull_request":{"href":"https://api.github.com/repos/pboyer/flood/pulls/94"}}},"pull_request":{"url":"https://api.github.com/repos/pboyer/flood/pulls/94","id":25754377,"html_url":"https://github.com/pboyer/flood/pull/94","diff_url":"https://github.com/pboyer/flood/pull/94.diff","patch_url":"https://github.com/pboyer/flood/pull/94.patch","issue_url":"https://api.github.com/repos/pboyer/flood/issues/94","number":94,"state":"open","locked":false,"title":"REACH-123 Add view for String node","user":{"login":"marimano","id":7658189,"avatar_url":"https://avatars.githubusercontent.com/u/7658189?v=3","gravatar_id":"","url":"https://api.github.com/users/marimano","html_url":"https://github.com/marimano","followers_url":"https://api.github.com/users/marimano/followers","following_url":"https://api.github.com/users/marimano/following{/other_user}","gists_url":"https://api.github.com/users/marimano/gists{/gist_id}","starred_url":"https://api.github.com/users/marimano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marimano/subscriptions","organizations_url":"https://api.github.com/users/marimano/orgs","repos_url":"https://api.github.com/users/marimano/repos","events_url":"https://api.github.com/users/marimano/events{/privacy}","received_events_url":"https://api.github.com/users/marimano/received_events","type":"User","site_admin":false},"body":"[REACH-123 Add view for String node](http://adsk-oss.myjetbrains.com/youtrack/issue/REACH-123)\r\n\r\nTo work correctly, this PR requires changes in [Dynamo](https://github.com/Benglin/Dynamo/pull/241)","created_at":"2014-12-09T16:08:14Z","updated_at":"2014-12-09T16:11:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1acba34b334e33b462cc39b66959764f434f4f76","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/pboyer/flood/pulls/94/commits","review_comments_url":"https://api.github.com/repos/pboyer/flood/pulls/94/comments","review_comment_url":"https://api.github.com/repos/pboyer/flood/pulls/comments/{number}","comments_url":"https://api.github.com/repos/pboyer/flood/issues/94/comments","statuses_url":"https://api.github.com/repos/pboyer/flood/statuses/bc5bba2ff3499acf9e502dc315214610ef76bfab","head":{"label":"marimano:string-view","ref":"string-view","sha":"bc5bba2ff3499acf9e502dc315214610ef76bfab","user":{"login":"marimano","id":7658189,"avatar_url":"https://avatars.githubusercontent.com/u/7658189?v=3","gravatar_id":"","url":"https://api.github.com/users/marimano","html_url":"https://github.com/marimano","followers_url":"https://api.github.com/users/marimano/followers","following_url":"https://api.github.com/users/marimano/following{/other_user}","gists_url":"https://api.github.com/users/marimano/gists{/gist_id}","starred_url":"https://api.github.com/users/marimano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marimano/subscriptions","organizations_url":"https://api.github.com/users/marimano/orgs","repos_url":"https://api.github.com/users/marimano/repos","events_url":"https://api.github.com/users/marimano/events{/privacy}","received_events_url":"https://api.github.com/users/marimano/received_events","type":"User","site_admin":false},"repo":{"id":23222218,"name":"flood","full_name":"marimano/flood","owner":{"login":"marimano","id":7658189,"avatar_url":"https://avatars.githubusercontent.com/u/7658189?v=3","gravatar_id":"","url":"https://api.github.com/users/marimano","html_url":"https://github.com/marimano","followers_url":"https://api.github.com/users/marimano/followers","following_url":"https://api.github.com/users/marimano/following{/other_user}","gists_url":"https://api.github.com/users/marimano/gists{/gist_id}","starred_url":"https://api.github.com/users/marimano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marimano/subscriptions","organizations_url":"https://api.github.com/users/marimano/orgs","repos_url":"https://api.github.com/users/marimano/repos","events_url":"https://api.github.com/users/marimano/events{/privacy}","received_events_url":"https://api.github.com/users/marimano/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/marimano/flood","description":"A visual programming environment for the browser","fork":true,"url":"https://api.github.com/repos/marimano/flood","forks_url":"https://api.github.com/repos/marimano/flood/forks","keys_url":"https://api.github.com/repos/marimano/flood/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marimano/flood/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marimano/flood/teams","hooks_url":"https://api.github.com/repos/marimano/flood/hooks","issue_events_url":"https://api.github.com/repos/marimano/flood/issues/events{/number}","events_url":"https://api.github.com/repos/marimano/flood/events","assignees_url":"https://api.github.com/repos/marimano/flood/assignees{/user}","branches_url":"https://api.github.com/repos/marimano/flood/branches{/branch}","tags_url":"https://api.github.com/repos/marimano/flood/tags","blobs_url":"https://api.github.com/repos/marimano/flood/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marimano/flood/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marimano/flood/git/refs{/sha}","trees_url":"https://api.github.com/repos/marimano/flood/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marimano/flood/statuses/{sha}","languages_url":"https://api.github.com/repos/marimano/flood/languages","stargazers_url":"https://api.github.com/repos/marimano/flood/stargazers","contributors_url":"https://api.github.com/repos/marimano/flood/contributors","subscribers_url":"https://api.github.com/repos/marimano/flood/subscribers","subscription_url":"https://api.github.com/repos/marimano/flood/subscription","commits_url":"https://api.github.com/repos/marimano/flood/commits{/sha}","git_commits_url":"https://api.github.com/repos/marimano/flood/git/commits{/sha}","comments_url":"https://api.github.com/repos/marimano/flood/comments{/number}","issue_comment_url":"https://api.github.com/repos/marimano/flood/issues/comments/{number}","contents_url":"https://api.github.com/repos/marimano/flood/contents/{+path}","compare_url":"https://api.github.com/repos/marimano/flood/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marimano/flood/merges","archive_url":"https://api.github.com/repos/marimano/flood/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marimano/flood/downloads","issues_url":"https://api.github.com/repos/marimano/flood/issues{/number}","pulls_url":"https://api.github.com/repos/marimano/flood/pulls{/number}","milestones_url":"https://api.github.com/repos/marimano/flood/milestones{/number}","notifications_url":"https://api.github.com/repos/marimano/flood/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marimano/flood/labels{/name}","releases_url":"https://api.github.com/repos/marimano/flood/releases{/id}","created_at":"2014-08-22T10:50:13Z","updated_at":"2014-06-25T18:34:02Z","pushed_at":"2014-12-09T16:05:38Z","git_url":"git://github.com/marimano/flood.git","ssh_url":"git@github.com:marimano/flood.git","clone_url":"https://github.com/marimano/flood.git","svn_url":"https://github.com/marimano/flood","homepage":"","size":46268,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pboyer:Reach","ref":"Reach","sha":"64f1fc585648abe58159f44ed670130c689100d7","user":{"login":"pboyer","id":916345,"avatar_url":"https://avatars.githubusercontent.com/u/916345?v=3","gravatar_id":"","url":"https://api.github.com/users/pboyer","html_url":"https://github.com/pboyer","followers_url":"https://api.github.com/users/pboyer/followers","following_url":"https://api.github.com/users/pboyer/following{/other_user}","gists_url":"https://api.github.com/users/pboyer/gists{/gist_id}","starred_url":"https://api.github.com/users/pboyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pboyer/subscriptions","organizations_url":"https://api.github.com/users/pboyer/orgs","repos_url":"https://api.github.com/users/pboyer/repos","events_url":"https://api.github.com/users/pboyer/events{/privacy}","received_events_url":"https://api.github.com/users/pboyer/received_events","type":"User","site_admin":false},"repo":{"id":10161776,"name":"flood","full_name":"pboyer/flood","owner":{"login":"pboyer","id":916345,"avatar_url":"https://avatars.githubusercontent.com/u/916345?v=3","gravatar_id":"","url":"https://api.github.com/users/pboyer","html_url":"https://github.com/pboyer","followers_url":"https://api.github.com/users/pboyer/followers","following_url":"https://api.github.com/users/pboyer/following{/other_user}","gists_url":"https://api.github.com/users/pboyer/gists{/gist_id}","starred_url":"https://api.github.com/users/pboyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pboyer/subscriptions","organizations_url":"https://api.github.com/users/pboyer/orgs","repos_url":"https://api.github.com/users/pboyer/repos","events_url":"https://api.github.com/users/pboyer/events{/privacy}","received_events_url":"https://api.github.com/users/pboyer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pboyer/flood","description":"A visual programming environment for the browser","fork":false,"url":"https://api.github.com/repos/pboyer/flood","forks_url":"https://api.github.com/repos/pboyer/flood/forks","keys_url":"https://api.github.com/repos/pboyer/flood/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pboyer/flood/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pboyer/flood/teams","hooks_url":"https://api.github.com/repos/pboyer/flood/hooks","issue_events_url":"https://api.github.com/repos/pboyer/flood/issues/events{/number}","events_url":"https://api.github.com/repos/pboyer/flood/events","assignees_url":"https://api.github.com/repos/pboyer/flood/assignees{/user}","branches_url":"https://api.github.com/repos/pboyer/flood/branches{/branch}","tags_url":"https://api.github.com/repos/pboyer/flood/tags","blobs_url":"https://api.github.com/repos/pboyer/flood/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pboyer/flood/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pboyer/flood/git/refs{/sha}","trees_url":"https://api.github.com/repos/pboyer/flood/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pboyer/flood/statuses/{sha}","languages_url":"https://api.github.com/repos/pboyer/flood/languages","stargazers_url":"https://api.github.com/repos/pboyer/flood/stargazers","contributors_url":"https://api.github.com/repos/pboyer/flood/contributors","subscribers_url":"https://api.github.com/repos/pboyer/flood/subscribers","subscription_url":"https://api.github.com/repos/pboyer/flood/subscription","commits_url":"https://api.github.com/repos/pboyer/flood/commits{/sha}","git_commits_url":"https://api.github.com/repos/pboyer/flood/git/commits{/sha}","comments_url":"https://api.github.com/repos/pboyer/flood/comments{/number}","issue_comment_url":"https://api.github.com/repos/pboyer/flood/issues/comments/{number}","contents_url":"https://api.github.com/repos/pboyer/flood/contents/{+path}","compare_url":"https://api.github.com/repos/pboyer/flood/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pboyer/flood/merges","archive_url":"https://api.github.com/repos/pboyer/flood/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pboyer/flood/downloads","issues_url":"https://api.github.com/repos/pboyer/flood/issues{/number}","pulls_url":"https://api.github.com/repos/pboyer/flood/pulls{/number}","milestones_url":"https://api.github.com/repos/pboyer/flood/milestones{/number}","notifications_url":"https://api.github.com/repos/pboyer/flood/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pboyer/flood/labels{/name}","releases_url":"https://api.github.com/repos/pboyer/flood/releases{/id}","created_at":"2013-05-19T21:45:23Z","updated_at":"2014-11-22T12:30:45Z","pushed_at":"2014-12-05T13:16:00Z","git_url":"git://github.com/pboyer/flood.git","ssh_url":"git@github.com:pboyer/flood.git","clone_url":"https://github.com/pboyer/flood.git","svn_url":"https://github.com/pboyer/flood","homepage":"http://www.floodeditor.com","size":47410,"stargazers_count":113,"watchers_count":113,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":6,"forks":12,"open_issues":6,"watchers":113,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pboyer/flood/pulls/94"},"html":{"href":"https://github.com/pboyer/flood/pull/94"},"issue":{"href":"https://api.github.com/repos/pboyer/flood/issues/94"},"comments":{"href":"https://api.github.com/repos/pboyer/flood/issues/94/comments"},"review_comments":{"href":"https://api.github.com/repos/pboyer/flood/pulls/94/comments"},"review_comment":{"href":"https://api.github.com/repos/pboyer/flood/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/pboyer/flood/pulls/94/commits"},"statuses":{"href":"https://api.github.com/repos/pboyer/flood/statuses/bc5bba2ff3499acf9e502dc315214610ef76bfab"}}}}