GitHub PullRequestReviewCommentEvent at 2014-09-09 17:51:26
Repository: angular.js
Actor: f0ysal
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/angular/angular.js/pulls/comments/17316357","id":17316357,"diff_hunk":"@@ -295,7 +295,7 @@ angular.module('ngResource', ['ng']).\n         });\n         query.sort();\n         url = url.replace(/\\/*$/, '');\n-        return url + (query.length ? '?' + query.join('&') : '');\n+        return url + (query.length ? '?' + query.join('&') : '') + '/'; // append slashes to urls","path":"src/ngResource/resource.js","position":5,"original_position":5,"commit_id":"6363135789a33121a91e0c4735791aebfaa06fdd","original_commit_id":"6363135789a33121a91e0c4735791aebfaa06fdd","user":{"login":"f0ysal","id":1332990,"avatar_url":"https://avatars.githubusercontent.com/u/1332990?v=2","gravatar_id":"0a9bef020b7e00b2d4ac1ce776d35794","url":"https://api.github.com/users/f0ysal","html_url":"https://github.com/f0ysal","followers_url":"https://api.github.com/users/f0ysal/followers","following_url":"https://api.github.com/users/f0ysal/following{/other_user}","gists_url":"https://api.github.com/users/f0ysal/gists{/gist_id}","starred_url":"https://api.github.com/users/f0ysal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/f0ysal/subscriptions","organizations_url":"https://api.github.com/users/f0ysal/orgs","repos_url":"https://api.github.com/users/f0ysal/repos","events_url":"https://api.github.com/users/f0ysal/events{/privacy}","received_events_url":"https://api.github.com/users/f0ysal/received_events","type":"User","site_admin":false},"body":"Still facing the trailing slash issue with Django Rest Framework with Angular Resource.","created_at":"2014-09-09T17:51:26Z","updated_at":"2014-09-09T17:51:26Z","html_url":"https://github.com/angular/angular.js/pull/1064#discussion_r17316357","pull_request_url":"https://api.github.com/repos/angular/angular.js/pulls/1064","_links":{"self":{"href":"https://api.github.com/repos/angular/angular.js/pulls/comments/17316357"},"html":{"href":"https://github.com/angular/angular.js/pull/1064#discussion_r17316357"},"pull_request":{"href":"https://api.github.com/repos/angular/angular.js/pulls/1064"}}},"pull_request":{"url":"https://api.github.com/repos/angular/angular.js/pulls/1064","id":1582882,"html_url":"https://github.com/angular/angular.js/pull/1064","diff_url":"https://github.com/angular/angular.js/pull/1064.diff","patch_url":"https://github.com/angular/angular.js/pull/1064.patch","issue_url":"https://api.github.com/repos/angular/angular.js/issues/1064","number":1064,"state":"closed","locked":false,"title":"Appends slashes to urls","user":{"login":"umurkontaci","id":991022,"avatar_url":"https://avatars.githubusercontent.com/u/991022?v=2","gravatar_id":"fe606dbd81c2af047dcb0e19ff5655c2","url":"https://api.github.com/users/umurkontaci","html_url":"https://github.com/umurkontaci","followers_url":"https://api.github.com/users/umurkontaci/followers","following_url":"https://api.github.com/users/umurkontaci/following{/other_user}","gists_url":"https://api.github.com/users/umurkontaci/gists{/gist_id}","starred_url":"https://api.github.com/users/umurkontaci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/umurkontaci/subscriptions","organizations_url":"https://api.github.com/users/umurkontaci/orgs","repos_url":"https://api.github.com/users/umurkontaci/repos","events_url":"https://api.github.com/users/umurkontaci/events{/privacy}","received_events_url":"https://api.github.com/users/umurkontaci/received_events","type":"User","site_admin":false},"body":"Angular intenionally removes slashes from urls defined in ngResource and this causes bugs and problems in frameworks like django. It simply *adds* slashes to urls for it work.","created_at":"2012-06-17T13:21:30Z","updated_at":"2014-09-09T17:51:26Z","closed_at":"2012-09-04T21:30:23Z","merged_at":null,"merge_commit_sha":"1a663d0250213722b9f7b28c11d281aa9169e49f","assignee":{"login":"mhevery","id":111951,"avatar_url":"https://avatars.githubusercontent.com/u/111951?v=2","gravatar_id":"8d67eedc1442e8392a7add197abacd66","url":"https://api.github.com/users/mhevery","html_url":"https://github.com/mhevery","followers_url":"https://api.github.com/users/mhevery/followers","following_url":"https://api.github.com/users/mhevery/following{/other_user}","gists_url":"https://api.github.com/users/mhevery/gists{/gist_id}","starred_url":"https://api.github.com/users/mhevery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhevery/subscriptions","organizations_url":"https://api.github.com/users/mhevery/orgs","repos_url":"https://api.github.com/users/mhevery/repos","events_url":"https://api.github.com/users/mhevery/events{/privacy}","received_events_url":"https://api.github.com/users/mhevery/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/angular/angular.js/pulls/1064/commits","review_comments_url":"https://api.github.com/repos/angular/angular.js/pulls/1064/comments","review_comment_url":"https://api.github.com/repos/angular/angular.js/pulls/comments/{number}","comments_url":"https://api.github.com/repos/angular/angular.js/issues/1064/comments","statuses_url":"https://api.github.com/repos/angular/angular.js/statuses/6363135789a33121a91e0c4735791aebfaa06fdd","head":{"label":"umurkontaci:master","ref":"master","sha":"6363135789a33121a91e0c4735791aebfaa06fdd","user":{"login":"umurkontaci","id":991022,"avatar_url":"https://avatars.githubusercontent.com/u/991022?v=2","gravatar_id":"fe606dbd81c2af047dcb0e19ff5655c2","url":"https://api.github.com/users/umurkontaci","html_url":"https://github.com/umurkontaci","followers_url":"https://api.github.com/users/umurkontaci/followers","following_url":"https://api.github.com/users/umurkontaci/following{/other_user}","gists_url":"https://api.github.com/users/umurkontaci/gists{/gist_id}","starred_url":"https://api.github.com/users/umurkontaci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/umurkontaci/subscriptions","organizations_url":"https://api.github.com/users/umurkontaci/orgs","repos_url":"https://api.github.com/users/umurkontaci/repos","events_url":"https://api.github.com/users/umurkontaci/events{/privacy}","received_events_url":"https://api.github.com/users/umurkontaci/received_events","type":"User","site_admin":false},"repo":null},"base":{"label":"angular:master","ref":"master","sha":"d0c0eadeddf6382cc8d8996fc9ac1f5cddf4d97a","user":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=2","gravatar_id":"f0d91e5cf8ad1ce7972cc486baa20c42","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":460078,"name":"angular.js","full_name":"angular/angular.js","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=2","gravatar_id":"f0d91e5cf8ad1ce7972cc486baa20c42","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/angular.js","description":"HTML enhanced for web apps","fork":false,"url":"https://api.github.com/repos/angular/angular.js","forks_url":"https://api.github.com/repos/angular/angular.js/forks","keys_url":"https://api.github.com/repos/angular/angular.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/angular.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/angular.js/teams","hooks_url":"https://api.github.com/repos/angular/angular.js/hooks","issue_events_url":"https://api.github.com/repos/angular/angular.js/issues/events{/number}","events_url":"https://api.github.com/repos/angular/angular.js/events","assignees_url":"https://api.github.com/repos/angular/angular.js/assignees{/user}","branches_url":"https://api.github.com/repos/angular/angular.js/branches{/branch}","tags_url":"https://api.github.com/repos/angular/angular.js/tags","blobs_url":"https://api.github.com/repos/angular/angular.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/angular.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/angular.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/angular.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/angular.js/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/angular.js/languages","stargazers_url":"https://api.github.com/repos/angular/angular.js/stargazers","contributors_url":"https://api.github.com/repos/angular/angular.js/contributors","subscribers_url":"https://api.github.com/repos/angular/angular.js/subscribers","subscription_url":"https://api.github.com/repos/angular/angular.js/subscription","commits_url":"https://api.github.com/repos/angular/angular.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/angular.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/angular.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/angular.js/issues/comments/{number}","contents_url":"https://api.github.com/repos/angular/angular.js/contents/{+path}","compare_url":"https://api.github.com/repos/angular/angular.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/angular.js/merges","archive_url":"https://api.github.com/repos/angular/angular.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/angular.js/downloads","issues_url":"https://api.github.com/repos/angular/angular.js/issues{/number}","pulls_url":"https://api.github.com/repos/angular/angular.js/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/angular.js/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/angular.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/angular.js/labels{/name}","releases_url":"https://api.github.com/repos/angular/angular.js/releases{/id}","created_at":"2010-01-06T00:34:37Z","updated_at":"2014-09-09T17:40:08Z","pushed_at":"2014-09-09T17:46:51Z","git_url":"git://github.com/angular/angular.js.git","ssh_url":"git@github.com:angular/angular.js.git","clone_url":"https://github.com/angular/angular.js.git","svn_url":"https://github.com/angular/angular.js","homepage":"http://angularjs.org","size":222656,"stargazers_count":28372,"watchers_count":28372,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":10488,"mirror_url":null,"open_issues_count":1128,"forks":10488,"open_issues":1128,"watchers":28372,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/angular.js/pulls/1064"},"html":{"href":"https://github.com/angular/angular.js/pull/1064"},"issue":{"href":"https://api.github.com/repos/angular/angular.js/issues/1064"},"comments":{"href":"https://api.github.com/repos/angular/angular.js/issues/1064/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/angular.js/pulls/1064/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/angular.js/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/angular/angular.js/pulls/1064/commits"},"statuses":{"href":"https://api.github.com/repos/angular/angular.js/statuses/6363135789a33121a91e0c4735791aebfaa06fdd"}}}}