GitHub PullRequestReviewCommentEvent at 2014-02-11 05:27:17
Repository: azure-activedirectory-library-for-android
Actor: borisvidolov
Payload: {"comment":{"url":"https://api.github.com/repos/MSOpenTech/azure-activedirectory-library-for-android/pulls/comments/9614027","id":9614027,"diff_hunk":"@@ -12,18 +12,14 @@\n import java.net.URL;\n import java.util.HashMap;\n import java.util.Iterator;\n-import java.util.concurrent.atomic.AtomicBoolean;\n \n-import android.annotation.TargetApi;\n-import android.os.AsyncTask;\n import android.os.Build;\n \n /**\n- * AsyncTask can be executed only once. It throws exception for multiple async\n- * calls on same object. Do not call onPreExecute, onPostExecute or\n- * doInBackground directly\n+ * Webrequest are called in background thread from API level. HttpWebRequest\n+ * does not create another thread.\n  */\n-class HttpWebRequest extends AsyncTask<Void, Void, HttpWebResponse> {","path":"adal/src/com/microsoft/adal/HttpWebRequest.java","position":17,"original_position":17,"commit_id":"a2ca706035184f16f9020da5f4eae1265f0d5785","original_commit_id":"a2ca706035184f16f9020da5f4eae1265f0d5785","user":{"login":"borisvidolov","id":5383972,"avatar_url":"https://gravatar.com/avatar/914cc7bebd4a29a27b52130ad717e7d9?d=https%3A%2F%2Fidenticons.github.com%2Fd608faad6ac2d54d7fd91741ceab73a0.png&r=x","gravatar_id":"914cc7bebd4a29a27b52130ad717e7d9","url":"https://api.github.com/users/borisvidolov","html_url":"https://github.com/borisvidolov","followers_url":"https://api.github.com/users/borisvidolov/followers","following_url":"https://api.github.com/users/borisvidolov/following{/other_user}","gists_url":"https://api.github.com/users/borisvidolov/gists{/gist_id}","starred_url":"https://api.github.com/users/borisvidolov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/borisvidolov/subscriptions","organizations_url":"https://api.github.com/users/borisvidolov/orgs","repos_url":"https://api.github.com/users/borisvidolov/repos","events_url":"https://api.github.com/users/borisvidolov/events{/privacy}","received_events_url":"https://api.github.com/users/borisvidolov/received_events","type":"User","site_admin":false},"body":"Let us discuss this change in person - I need to understand the architectural need to move to a separate thread instead of the built-in async task.","created_at":"2014-02-11T05:27:17Z","updated_at":"2014-02-11T05:27:17Z","html_url":"https://github.com/MSOpenTech/azure-activedirectory-library-for-android/pull/48#discussion_r9614027","pull_request_url":"https://api.github.com/repos/MSOpenTech/azure-activedirectory-library-for-android/pulls/48","_links":{"self":{"href":"https://api.github.com/repos/MSOpenTech/azure-activedirectory-library-for-android/pulls/comments/9614027"},"html":{"href":"https://github.com/MSOpenTech/azure-activedirectory-library-for-android/pull/48#discussion_r9614027"},"pull_request":{"href":"https://api.github.com/repos/MSOpenTech/azure-activedirectory-library-for-android/pulls/48"}}}}