GitHub PullRequestReviewCommentEvent at 2014-08-15 13:10:13
Repository: opm-core
Actor: andlaus
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/OPM/opm-core/pulls/comments/16291196","id":16291196,"diff_hunk":"@@ -394,20 +394,28 @@ namespace Opm\n \n                 assign(G, opress, z0, cells, press);\n \n+                // Default pressure at WOC and GOC to -inf\n                 po_woc = -std::numeric_limits<double>::max();\n                 po_goc = -std::numeric_limits<double>::max();\n \n                 const double woc = reg.zwoc();\n-                // Compute Oil pressure at WOC\n-                if      (z0 > woc) { po_woc = opress[0](woc); } // WOC above datum\n-                else if (z0 < woc) { po_woc = opress[1](woc); } // WOC below datum\n-                else               { po_woc = p0;             } // WOC *at*  datum\n+                // Compute Oil pressure at WOC,\n+                // if WOC is within the reservoir.\n+                if ( ( woc > span[0] ) & ( woc < span[1] ) ){\n+                    if      (z0 > woc) { po_woc = opress[0](woc); } // WOC above datum\n+                    else if (z0 < woc) { po_woc = opress[1](woc); } // WOC below datum\n+                    else               { po_woc = p0;             } // WOC *at*  datum\n+                }\n \n                 const double goc = reg.zgoc();\n-                // Compute Oil pressure at GOC\n-                if      (z0 > goc) { po_goc = opress[0](goc); } // GOC above datum\n-                else if (z0 < goc) { po_goc = opress[1](goc); } // GOC below datum\n-                else               { po_goc = p0;             } // GOC *at*  datum\n+                // Compute Oil pressure at GOC,\n+                // if GOC is within the reservoir.\n+                if ( ( goc > span[0] ) & ( goc < span[1] ) ){","path":"opm/core/simulator/initStateEquil_impl.hpp","position":28,"original_position":28,"commit_id":"12b245df3da1e7b1a9c0b6d5570d0d2f44a600c0","original_commit_id":"12b245df3da1e7b1a9c0b6d5570d0d2f44a600c0","user":{"login":"andlaus","id":1837735,"avatar_url":"https://avatars.githubusercontent.com/u/1837735?v=2","gravatar_id":"66363bd380194c65c745a2fd0f1e85ce","url":"https://api.github.com/users/andlaus","html_url":"https://github.com/andlaus","followers_url":"https://api.github.com/users/andlaus/followers","following_url":"https://api.github.com/users/andlaus/following{/other_user}","gists_url":"https://api.github.com/users/andlaus/gists{/gist_id}","starred_url":"https://api.github.com/users/andlaus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andlaus/subscriptions","organizations_url":"https://api.github.com/users/andlaus/orgs","repos_url":"https://api.github.com/users/andlaus/repos","events_url":"https://api.github.com/users/andlaus/events{/privacy}","received_events_url":"https://api.github.com/users/andlaus/received_events","type":"User","site_admin":false},"body":"same here. I guess it workes because the '>' and '<' operators both set only the lowest bit to one... ","created_at":"2014-08-15T13:10:13Z","updated_at":"2014-08-15T13:10:13Z","html_url":"https://github.com/OPM/opm-core/pull/630#discussion_r16291196","pull_request_url":"https://api.github.com/repos/OPM/opm-core/pulls/630","_links":{"self":{"href":"https://api.github.com/repos/OPM/opm-core/pulls/comments/16291196"},"html":{"href":"https://github.com/OPM/opm-core/pull/630#discussion_r16291196"},"pull_request":{"href":"https://api.github.com/repos/OPM/opm-core/pulls/630"}}},"pull_request":{"url":"https://api.github.com/repos/OPM/opm-core/pulls/630","id":19832222,"html_url":"https://github.com/OPM/opm-core/pull/630","diff_url":"https://github.com/OPM/opm-core/pull/630.diff","patch_url":"https://github.com/OPM/opm-core/pull/630.patch","issue_url":"https://api.github.com/repos/OPM/opm-core/issues/630","number":630,"state":"open","locked":false,"title":"The water/gas press. are calculated only if woc/goc is within the reservoar ","user":{"login":"totto82","id":3223024,"avatar_url":"https://avatars.githubusercontent.com/u/3223024?v=2","gravatar_id":"685ee35a0950339b200465b1553bd97e","url":"https://api.github.com/users/totto82","html_url":"https://github.com/totto82","followers_url":"https://api.github.com/users/totto82/followers","following_url":"https://api.github.com/users/totto82/following{/other_user}","gists_url":"https://api.github.com/users/totto82/gists{/gist_id}","starred_url":"https://api.github.com/users/totto82/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/totto82/subscriptions","organizations_url":"https://api.github.com/users/totto82/orgs","repos_url":"https://api.github.com/users/totto82/repos","events_url":"https://api.github.com/users/totto82/events{/privacy}","received_events_url":"https://api.github.com/users/totto82/received_events","type":"User","site_admin":false},"body":"The water/gas pressure used for the calculation of the phase saturation and the rs values is set to -inf when woc/goc is above or below the reservoir. With this fix in the initialization OPM reproduces Eclipse results for SPE9. \r\n\r\n ","created_at":"2014-08-15T07:17:41Z","updated_at":"2014-08-15T13:10:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e8c7f61e597141ef87a1ce633c779d4ee8313539","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/OPM/opm-core/pulls/630/commits","review_comments_url":"https://api.github.com/repos/OPM/opm-core/pulls/630/comments","review_comment_url":"https://api.github.com/repos/OPM/opm-core/pulls/comments/{number}","comments_url":"https://api.github.com/repos/OPM/opm-core/issues/630/comments","statuses_url":"https://api.github.com/repos/OPM/opm-core/statuses/12b245df3da1e7b1a9c0b6d5570d0d2f44a600c0","head":{"label":"totto82:fix_init_spe9","ref":"fix_init_spe9","sha":"12b245df3da1e7b1a9c0b6d5570d0d2f44a600c0","user":{"login":"totto82","id":3223024,"avatar_url":"https://avatars.githubusercontent.com/u/3223024?v=2","gravatar_id":"685ee35a0950339b200465b1553bd97e","url":"https://api.github.com/users/totto82","html_url":"https://github.com/totto82","followers_url":"https://api.github.com/users/totto82/followers","following_url":"https://api.github.com/users/totto82/following{/other_user}","gists_url":"https://api.github.com/users/totto82/gists{/gist_id}","starred_url":"https://api.github.com/users/totto82/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/totto82/subscriptions","organizations_url":"https://api.github.com/users/totto82/orgs","repos_url":"https://api.github.com/users/totto82/repos","events_url":"https://api.github.com/users/totto82/events{/privacy}","received_events_url":"https://api.github.com/users/totto82/received_events","type":"User","site_admin":false},"repo":{"id":7516283,"name":"opm-core","full_name":"totto82/opm-core","owner":{"login":"totto82","id":3223024,"avatar_url":"https://avatars.githubusercontent.com/u/3223024?v=2","gravatar_id":"685ee35a0950339b200465b1553bd97e","url":"https://api.github.com/users/totto82","html_url":"https://github.com/totto82","followers_url":"https://api.github.com/users/totto82/followers","following_url":"https://api.github.com/users/totto82/following{/other_user}","gists_url":"https://api.github.com/users/totto82/gists{/gist_id}","starred_url":"https://api.github.com/users/totto82/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/totto82/subscriptions","organizations_url":"https://api.github.com/users/totto82/orgs","repos_url":"https://api.github.com/users/totto82/repos","events_url":"https://api.github.com/users/totto82/events{/privacy}","received_events_url":"https://api.github.com/users/totto82/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/totto82/opm-core","description":"Open Porous Media Core Library","fork":true,"url":"https://api.github.com/repos/totto82/opm-core","forks_url":"https://api.github.com/repos/totto82/opm-core/forks","keys_url":"https://api.github.com/repos/totto82/opm-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/totto82/opm-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/totto82/opm-core/teams","hooks_url":"https://api.github.com/repos/totto82/opm-core/hooks","issue_events_url":"https://api.github.com/repos/totto82/opm-core/issues/events{/number}","events_url":"https://api.github.com/repos/totto82/opm-core/events","assignees_url":"https://api.github.com/repos/totto82/opm-core/assignees{/user}","branches_url":"https://api.github.com/repos/totto82/opm-core/branches{/branch}","tags_url":"https://api.github.com/repos/totto82/opm-core/tags","blobs_url":"https://api.github.com/repos/totto82/opm-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/totto82/opm-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/totto82/opm-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/totto82/opm-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/totto82/opm-core/statuses/{sha}","languages_url":"https://api.github.com/repos/totto82/opm-core/languages","stargazers_url":"https://api.github.com/repos/totto82/opm-core/stargazers","contributors_url":"https://api.github.com/repos/totto82/opm-core/contributors","subscribers_url":"https://api.github.com/repos/totto82/opm-core/subscribers","subscription_url":"https://api.github.com/repos/totto82/opm-core/subscription","commits_url":"https://api.github.com/repos/totto82/opm-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/totto82/opm-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/totto82/opm-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/totto82/opm-core/issues/comments/{number}","contents_url":"https://api.github.com/repos/totto82/opm-core/contents/{+path}","compare_url":"https://api.github.com/repos/totto82/opm-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/totto82/opm-core/merges","archive_url":"https://api.github.com/repos/totto82/opm-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/totto82/opm-core/downloads","issues_url":"https://api.github.com/repos/totto82/opm-core/issues{/number}","pulls_url":"https://api.github.com/repos/totto82/opm-core/pulls{/number}","milestones_url":"https://api.github.com/repos/totto82/opm-core/milestones{/number}","notifications_url":"https://api.github.com/repos/totto82/opm-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/totto82/opm-core/labels{/name}","releases_url":"https://api.github.com/repos/totto82/opm-core/releases{/id}","created_at":"2013-01-09T06:50:10Z","updated_at":"2014-08-05T13:04:09Z","pushed_at":"2014-08-15T07:09:40Z","git_url":"git://github.com/totto82/opm-core.git","ssh_url":"git@github.com:totto82/opm-core.git","clone_url":"https://github.com/totto82/opm-core.git","svn_url":"https://github.com/totto82/opm-core","homepage":"http://www.opm-project.org","size":10920,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OPM:master","ref":"master","sha":"a6c173abadcf1123e406f8b2b465613139da1865","user":{"login":"OPM","id":1827197,"avatar_url":"https://avatars.githubusercontent.com/u/1827197?v=2","gravatar_id":"fc9326316d3b8dde4e60de6ed0cb4933","url":"https://api.github.com/users/OPM","html_url":"https://github.com/OPM","followers_url":"https://api.github.com/users/OPM/followers","following_url":"https://api.github.com/users/OPM/following{/other_user}","gists_url":"https://api.github.com/users/OPM/gists{/gist_id}","starred_url":"https://api.github.com/users/OPM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OPM/subscriptions","organizations_url":"https://api.github.com/users/OPM/orgs","repos_url":"https://api.github.com/users/OPM/repos","events_url":"https://api.github.com/users/OPM/events{/privacy}","received_events_url":"https://api.github.com/users/OPM/received_events","type":"Organization","site_admin":false},"repo":{"id":4787500,"name":"opm-core","full_name":"OPM/opm-core","owner":{"login":"OPM","id":1827197,"avatar_url":"https://avatars.githubusercontent.com/u/1827197?v=2","gravatar_id":"fc9326316d3b8dde4e60de6ed0cb4933","url":"https://api.github.com/users/OPM","html_url":"https://github.com/OPM","followers_url":"https://api.github.com/users/OPM/followers","following_url":"https://api.github.com/users/OPM/following{/other_user}","gists_url":"https://api.github.com/users/OPM/gists{/gist_id}","starred_url":"https://api.github.com/users/OPM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OPM/subscriptions","organizations_url":"https://api.github.com/users/OPM/orgs","repos_url":"https://api.github.com/users/OPM/repos","events_url":"https://api.github.com/users/OPM/events{/privacy}","received_events_url":"https://api.github.com/users/OPM/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OPM/opm-core","description":"Open Porous Media Core Library","fork":false,"url":"https://api.github.com/repos/OPM/opm-core","forks_url":"https://api.github.com/repos/OPM/opm-core/forks","keys_url":"https://api.github.com/repos/OPM/opm-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OPM/opm-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OPM/opm-core/teams","hooks_url":"https://api.github.com/repos/OPM/opm-core/hooks","issue_events_url":"https://api.github.com/repos/OPM/opm-core/issues/events{/number}","events_url":"https://api.github.com/repos/OPM/opm-core/events","assignees_url":"https://api.github.com/repos/OPM/opm-core/assignees{/user}","branches_url":"https://api.github.com/repos/OPM/opm-core/branches{/branch}","tags_url":"https://api.github.com/repos/OPM/opm-core/tags","blobs_url":"https://api.github.com/repos/OPM/opm-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OPM/opm-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OPM/opm-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/OPM/opm-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OPM/opm-core/statuses/{sha}","languages_url":"https://api.github.com/repos/OPM/opm-core/languages","stargazers_url":"https://api.github.com/repos/OPM/opm-core/stargazers","contributors_url":"https://api.github.com/repos/OPM/opm-core/contributors","subscribers_url":"https://api.github.com/repos/OPM/opm-core/subscribers","subscription_url":"https://api.github.com/repos/OPM/opm-core/subscription","commits_url":"https://api.github.com/repos/OPM/opm-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/OPM/opm-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/OPM/opm-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/OPM/opm-core/issues/comments/{number}","contents_url":"https://api.github.com/repos/OPM/opm-core/contents/{+path}","compare_url":"https://api.github.com/repos/OPM/opm-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OPM/opm-core/merges","archive_url":"https://api.github.com/repos/OPM/opm-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OPM/opm-core/downloads","issues_url":"https://api.github.com/repos/OPM/opm-core/issues{/number}","pulls_url":"https://api.github.com/repos/OPM/opm-core/pulls{/number}","milestones_url":"https://api.github.com/repos/OPM/opm-core/milestones{/number}","notifications_url":"https://api.github.com/repos/OPM/opm-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OPM/opm-core/labels{/name}","releases_url":"https://api.github.com/repos/OPM/opm-core/releases{/id}","created_at":"2012-06-25T21:14:06Z","updated_at":"2014-06-30T12:43:17Z","pushed_at":"2014-08-14T12:02:55Z","git_url":"git://github.com/OPM/opm-core.git","ssh_url":"git@github.com:OPM/opm-core.git","clone_url":"https://github.com/OPM/opm-core.git","svn_url":"https://github.com/OPM/opm-core","homepage":"http://www.opm-project.org","size":15924,"stargazers_count":11,"watchers_count":11,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":33,"mirror_url":null,"open_issues_count":24,"forks":33,"open_issues":24,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OPM/opm-core/pulls/630"},"html":{"href":"https://github.com/OPM/opm-core/pull/630"},"issue":{"href":"https://api.github.com/repos/OPM/opm-core/issues/630"},"comments":{"href":"https://api.github.com/repos/OPM/opm-core/issues/630/comments"},"review_comments":{"href":"https://api.github.com/repos/OPM/opm-core/pulls/630/comments"},"review_comment":{"href":"https://api.github.com/repos/OPM/opm-core/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/OPM/opm-core/pulls/630/commits"},"statuses":{"href":"https://api.github.com/repos/OPM/opm-core/statuses/12b245df3da1e7b1a9c0b6d5570d0d2f44a600c0"}}}}