GitHub PullRequestReviewCommentEvent at 2014-08-05 18:47:19
Repository: fxa-content-server
Actor: ckarlof
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/fxa-content-server/pulls/comments/15833208","id":15833208,"diff_hunk":"@@ -170,6 +170,7 @@ function (\n       this.setSessionValueFromUrl('service');\n       this.setSessionValueFromUrl('redirectTo');\n       this.setSessionValueFromUrl('context');\n+      this.setSessionValueFromUrl('webChannelId');","path":"app/scripts/lib/app-start.js","position":4,"original_position":4,"commit_id":"3fa953b97376d568e5a9b67f764538a438ed25a4","original_commit_id":"3fa953b97376d568e5a9b67f764538a438ed25a4","user":{"login":"ckarlof","id":2365255,"avatar_url":"https://avatars.githubusercontent.com/u/2365255?v=2","gravatar_id":"64711dbc841d530896810a75fa601bbb","url":"https://api.github.com/users/ckarlof","html_url":"https://github.com/ckarlof","followers_url":"https://api.github.com/users/ckarlof/followers","following_url":"https://api.github.com/users/ckarlof/following{/other_user}","gists_url":"https://api.github.com/users/ckarlof/gists{/gist_id}","starred_url":"https://api.github.com/users/ckarlof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckarlof/subscriptions","organizations_url":"https://api.github.com/users/ckarlof/orgs","repos_url":"https://api.github.com/users/ckarlof/repos","events_url":"https://api.github.com/users/ckarlof/events{/privacy}","received_events_url":"https://api.github.com/users/ckarlof/received_events","type":"User","site_admin":false},"body":"I'd like to think about how we can move away from the `Session` god object.\r\n\r\nI think it would also be useful to have a notion of an `Environment` which is never persisted, but is gathered from the \"environment\", e.g., the query params. `initSessionFromUrl` could easily be `initEnvironmentFromUrl`. We can also mock the the Environment for tests. \r\n\r\nIf we ever need something to be persisted from the environment into the `Session` (e.g., during a signup or password reset flow), the we do it explicitly and scope it as much as possible (either to the flow, uid, email, etc).","created_at":"2014-08-05T18:47:19Z","updated_at":"2014-08-05T18:47:19Z","html_url":"https://github.com/mozilla/fxa-content-server/pull/1502#discussion_r15833208","pull_request_url":"https://api.github.com/repos/mozilla/fxa-content-server/pulls/1502","_links":{"self":{"href":"https://api.github.com/repos/mozilla/fxa-content-server/pulls/comments/15833208"},"html":{"href":"https://github.com/mozilla/fxa-content-server/pull/1502#discussion_r15833208"},"pull_request":{"href":"https://api.github.com/repos/mozilla/fxa-content-server/pulls/1502"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/fxa-content-server/pulls/1502","id":19321341,"html_url":"https://github.com/mozilla/fxa-content-server/pull/1502","diff_url":"https://github.com/mozilla/fxa-content-server/pull/1502.diff","patch_url":"https://github.com/mozilla/fxa-content-server/pull/1502.patch","issue_url":"https://api.github.com/repos/mozilla/fxa-content-server/issues/1502","number":1502,"state":"open","title":"WIP feat(oauth): Add WebChannel support","user":{"login":"vladikoff","id":128755,"avatar_url":"https://avatars.githubusercontent.com/u/128755?v=2","gravatar_id":"3e9c4f562ec682106a091011eea70507","url":"https://api.github.com/users/vladikoff","html_url":"https://github.com/vladikoff","followers_url":"https://api.github.com/users/vladikoff/followers","following_url":"https://api.github.com/users/vladikoff/following{/other_user}","gists_url":"https://api.github.com/users/vladikoff/gists{/gist_id}","starred_url":"https://api.github.com/users/vladikoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vladikoff/subscriptions","organizations_url":"https://api.github.com/users/vladikoff/orgs","repos_url":"https://api.github.com/users/vladikoff/repos","events_url":"https://api.github.com/users/vladikoff/events{/privacy}","received_events_url":"https://api.github.com/users/vladikoff/received_events","type":"User","site_admin":false},"body":"@shane-tomlinson @ckarlof feedback?\r\n\r\n- [ ] Need to check error reporting\r\n- [ ] Need to fix localstorage WebChannel saving\r\n- [ ] Tests","created_at":"2014-08-05T03:55:39Z","updated_at":"2014-08-05T18:47:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"02651e3030f5945787d1290e7a4cc280b53f9ce5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/fxa-content-server/pulls/1502/commits","review_comments_url":"https://api.github.com/repos/mozilla/fxa-content-server/pulls/1502/comments","review_comment_url":"https://api.github.com/repos/mozilla/fxa-content-server/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mozilla/fxa-content-server/issues/1502/comments","statuses_url":"https://api.github.com/repos/mozilla/fxa-content-server/statuses/3fa953b97376d568e5a9b67f764538a438ed25a4","head":{"label":"vladikoff:oauth-msg-5","ref":"oauth-msg-5","sha":"3fa953b97376d568e5a9b67f764538a438ed25a4","user":{"login":"vladikoff","id":128755,"avatar_url":"https://avatars.githubusercontent.com/u/128755?v=2","gravatar_id":"3e9c4f562ec682106a091011eea70507","url":"https://api.github.com/users/vladikoff","html_url":"https://github.com/vladikoff","followers_url":"https://api.github.com/users/vladikoff/followers","following_url":"https://api.github.com/users/vladikoff/following{/other_user}","gists_url":"https://api.github.com/users/vladikoff/gists{/gist_id}","starred_url":"https://api.github.com/users/vladikoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vladikoff/subscriptions","organizations_url":"https://api.github.com/users/vladikoff/orgs","repos_url":"https://api.github.com/users/vladikoff/repos","events_url":"https://api.github.com/users/vladikoff/events{/privacy}","received_events_url":"https://api.github.com/users/vladikoff/received_events","type":"User","site_admin":false},"repo":{"id":15786683,"name":"fxa-content-server","full_name":"vladikoff/fxa-content-server","owner":{"login":"vladikoff","id":128755,"avatar_url":"https://avatars.githubusercontent.com/u/128755?v=2","gravatar_id":"3e9c4f562ec682106a091011eea70507","url":"https://api.github.com/users/vladikoff","html_url":"https://github.com/vladikoff","followers_url":"https://api.github.com/users/vladikoff/followers","following_url":"https://api.github.com/users/vladikoff/following{/other_user}","gists_url":"https://api.github.com/users/vladikoff/gists{/gist_id}","starred_url":"https://api.github.com/users/vladikoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vladikoff/subscriptions","organizations_url":"https://api.github.com/users/vladikoff/orgs","repos_url":"https://api.github.com/users/vladikoff/repos","events_url":"https://api.github.com/users/vladikoff/events{/privacy}","received_events_url":"https://api.github.com/users/vladikoff/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vladikoff/fxa-content-server","description":"Firefox Accounts","fork":true,"url":"https://api.github.com/repos/vladikoff/fxa-content-server","forks_url":"https://api.github.com/repos/vladikoff/fxa-content-server/forks","keys_url":"https://api.github.com/repos/vladikoff/fxa-content-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vladikoff/fxa-content-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vladikoff/fxa-content-server/teams","hooks_url":"https://api.github.com/repos/vladikoff/fxa-content-server/hooks","issue_events_url":"https://api.github.com/repos/vladikoff/fxa-content-server/issues/events{/number}","events_url":"https://api.github.com/repos/vladikoff/fxa-content-server/events","assignees_url":"https://api.github.com/repos/vladikoff/fxa-content-server/assignees{/user}","branches_url":"https://api.github.com/repos/vladikoff/fxa-content-server/branches{/branch}","tags_url":"https://api.github.com/repos/vladikoff/fxa-content-server/tags","blobs_url":"https://api.github.com/repos/vladikoff/fxa-content-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vladikoff/fxa-content-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vladikoff/fxa-content-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/vladikoff/fxa-content-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vladikoff/fxa-content-server/statuses/{sha}","languages_url":"https://api.github.com/repos/vladikoff/fxa-content-server/languages","stargazers_url":"https://api.github.com/repos/vladikoff/fxa-content-server/stargazers","contributors_url":"https://api.github.com/repos/vladikoff/fxa-content-server/contributors","subscribers_url":"https://api.github.com/repos/vladikoff/fxa-content-server/subscribers","subscription_url":"https://api.github.com/repos/vladikoff/fxa-content-server/subscription","commits_url":"https://api.github.com/repos/vladikoff/fxa-content-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/vladikoff/fxa-content-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/vladikoff/fxa-content-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/vladikoff/fxa-content-server/issues/comments/{number}","contents_url":"https://api.github.com/repos/vladikoff/fxa-content-server/contents/{+path}","compare_url":"https://api.github.com/repos/vladikoff/fxa-content-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vladikoff/fxa-content-server/merges","archive_url":"https://api.github.com/repos/vladikoff/fxa-content-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vladikoff/fxa-content-server/downloads","issues_url":"https://api.github.com/repos/vladikoff/fxa-content-server/issues{/number}","pulls_url":"https://api.github.com/repos/vladikoff/fxa-content-server/pulls{/number}","milestones_url":"https://api.github.com/repos/vladikoff/fxa-content-server/milestones{/number}","notifications_url":"https://api.github.com/repos/vladikoff/fxa-content-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vladikoff/fxa-content-server/labels{/name}","releases_url":"https://api.github.com/repos/vladikoff/fxa-content-server/releases{/id}","created_at":"2014-01-10T02:53:37Z","updated_at":"2014-07-06T18:19:33Z","pushed_at":"2014-08-05T03:53:40Z","git_url":"git://github.com/vladikoff/fxa-content-server.git","ssh_url":"git@github.com:vladikoff/fxa-content-server.git","clone_url":"https://github.com/vladikoff/fxa-content-server.git","svn_url":"https://github.com/vladikoff/fxa-content-server","homepage":"","size":6213,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"245f2692c4e084fb3863dc745022685bbf746153","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=2","gravatar_id":"9ba739c8f3288e256b13553e4d257b5e","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":11778024,"name":"fxa-content-server","full_name":"mozilla/fxa-content-server","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=2","gravatar_id":"9ba739c8f3288e256b13553e4d257b5e","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/fxa-content-server","description":"Firefox Accounts Content Server","fork":false,"url":"https://api.github.com/repos/mozilla/fxa-content-server","forks_url":"https://api.github.com/repos/mozilla/fxa-content-server/forks","keys_url":"https://api.github.com/repos/mozilla/fxa-content-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/fxa-content-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/fxa-content-server/teams","hooks_url":"https://api.github.com/repos/mozilla/fxa-content-server/hooks","issue_events_url":"https://api.github.com/repos/mozilla/fxa-content-server/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/fxa-content-server/events","assignees_url":"https://api.github.com/repos/mozilla/fxa-content-server/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/fxa-content-server/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/fxa-content-server/tags","blobs_url":"https://api.github.com/repos/mozilla/fxa-content-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/fxa-content-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/fxa-content-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/fxa-content-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/fxa-content-server/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/fxa-content-server/languages","stargazers_url":"https://api.github.com/repos/mozilla/fxa-content-server/stargazers","contributors_url":"https://api.github.com/repos/mozilla/fxa-content-server/contributors","subscribers_url":"https://api.github.com/repos/mozilla/fxa-content-server/subscribers","subscription_url":"https://api.github.com/repos/mozilla/fxa-content-server/subscription","commits_url":"https://api.github.com/repos/mozilla/fxa-content-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/fxa-content-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/fxa-content-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/fxa-content-server/issues/comments/{number}","contents_url":"https://api.github.com/repos/mozilla/fxa-content-server/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/fxa-content-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/fxa-content-server/merges","archive_url":"https://api.github.com/repos/mozilla/fxa-content-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/fxa-content-server/downloads","issues_url":"https://api.github.com/repos/mozilla/fxa-content-server/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/fxa-content-server/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/fxa-content-server/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/fxa-content-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/fxa-content-server/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/fxa-content-server/releases{/id}","created_at":"2013-07-30T23:35:35Z","updated_at":"2014-06-25T20:31:53Z","pushed_at":"2014-08-05T18:33:44Z","git_url":"git://github.com/mozilla/fxa-content-server.git","ssh_url":"git@github.com:mozilla/fxa-content-server.git","clone_url":"https://github.com/mozilla/fxa-content-server.git","svn_url":"https://github.com/mozilla/fxa-content-server","homepage":"","size":26607,"stargazers_count":25,"watchers_count":25,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":21,"mirror_url":null,"open_issues_count":145,"forks":21,"open_issues":145,"watchers":25,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/fxa-content-server/pulls/1502"},"html":{"href":"https://github.com/mozilla/fxa-content-server/pull/1502"},"issue":{"href":"https://api.github.com/repos/mozilla/fxa-content-server/issues/1502"},"comments":{"href":"https://api.github.com/repos/mozilla/fxa-content-server/issues/1502/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/fxa-content-server/pulls/1502/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/fxa-content-server/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mozilla/fxa-content-server/pulls/1502/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/fxa-content-server/statuses/3fa953b97376d568e5a9b67f764538a438ed25a4"}}}}