GitHub PullRequestReviewCommentEvent at 2014-08-21 18:14:49
Repository: gamgee
Actor: jmthibault79
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/broadinstitute/gamgee/pulls/comments/16556614","id":16556614,"diff_hunk":"@@ -101,6 +101,32 @@ class IndividualField {\n    * @param other another IndividualField object\n    */\n   IndividualField& operator=(IndividualField&& other) = default;\n+\n+  /**\n+   * @brief compares two IndividualField objects in the following order: memory address, size and values. \n+   * @param other something to compare to\n+   * @return true if the objects are the same (memory address-wise), or contain exactly the same values. Value comparison is dictated by TYPE's operator== implementation\n+   */\n+  bool operator==(const IndividualField& other) const {\n+    if (this == &other) \n+      return true;\n+    if (size() != other.size()) \n+      return false;\n+    for (auto i=0u; i != size(); ++i) {","path":"gamgee/individual_field.h","position":15,"original_position":15,"commit_id":"e37b9f947e8f8a52c367ac52b2f1f1edbaf27e28","original_commit_id":"e37b9f947e8f8a52c367ac52b2f1f1edbaf27e28","user":{"login":"jmthibault79","id":2701406,"avatar_url":"https://avatars.githubusercontent.com/u/2701406?v=2","gravatar_id":"4f28b8eff56e587100c8917ec0ac5b03","url":"https://api.github.com/users/jmthibault79","html_url":"https://github.com/jmthibault79","followers_url":"https://api.github.com/users/jmthibault79/followers","following_url":"https://api.github.com/users/jmthibault79/following{/other_user}","gists_url":"https://api.github.com/users/jmthibault79/gists{/gist_id}","starred_url":"https://api.github.com/users/jmthibault79/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmthibault79/subscriptions","organizations_url":"https://api.github.com/users/jmthibault79/orgs","repos_url":"https://api.github.com/users/jmthibault79/repos","events_url":"https://api.github.com/users/jmthibault79/events{/privacy}","received_events_url":"https://api.github.com/users/jmthibault79/received_events","type":"User","site_admin":false},"body":"Cool, I'll try to remember that.","created_at":"2014-08-21T18:14:49Z","updated_at":"2014-08-21T18:14:49Z","html_url":"https://github.com/broadinstitute/gamgee/pull/198#discussion_r16556614","pull_request_url":"https://api.github.com/repos/broadinstitute/gamgee/pulls/198","_links":{"self":{"href":"https://api.github.com/repos/broadinstitute/gamgee/pulls/comments/16556614"},"html":{"href":"https://github.com/broadinstitute/gamgee/pull/198#discussion_r16556614"},"pull_request":{"href":"https://api.github.com/repos/broadinstitute/gamgee/pulls/198"}}},"pull_request":{"url":"https://api.github.com/repos/broadinstitute/gamgee/pulls/198","id":20113350,"html_url":"https://github.com/broadinstitute/gamgee/pull/198","diff_url":"https://github.com/broadinstitute/gamgee/pull/198.diff","patch_url":"https://github.com/broadinstitute/gamgee/pull/198.patch","issue_url":"https://api.github.com/repos/broadinstitute/gamgee/issues/198","number":198,"state":"open","locked":false,"title":"IndividualField: add operator== and operator!=","user":{"login":"MauricioCarneiro","id":1843628,"avatar_url":"https://avatars.githubusercontent.com/u/1843628?v=2","gravatar_id":"33e009132b1bc3c5bd7be7e0762d4c46","url":"https://api.github.com/users/MauricioCarneiro","html_url":"https://github.com/MauricioCarneiro","followers_url":"https://api.github.com/users/MauricioCarneiro/followers","following_url":"https://api.github.com/users/MauricioCarneiro/following{/other_user}","gists_url":"https://api.github.com/users/MauricioCarneiro/gists{/gist_id}","starred_url":"https://api.github.com/users/MauricioCarneiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MauricioCarneiro/subscriptions","organizations_url":"https://api.github.com/users/MauricioCarneiro/orgs","repos_url":"https://api.github.com/users/MauricioCarneiro/repos","events_url":"https://api.github.com/users/MauricioCarneiro/events{/privacy}","received_events_url":"https://api.github.com/users/MauricioCarneiro/received_events","type":"User","site_admin":false},"body":"Add implementation of the two operators for both IndividualField and\nIndividualFieldValue so we can write tests more easily and compare\nobjects. Comparison is based on value equality. The Genotype class\nalready had the operators implemented (thanks @kshakir)\n\nfixes #187","created_at":"2014-08-21T14:35:04Z","updated_at":"2014-08-21T18:14:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5212159910493ecc23f02f17c797c6ed14a53b36","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/broadinstitute/gamgee/pulls/198/commits","review_comments_url":"https://api.github.com/repos/broadinstitute/gamgee/pulls/198/comments","review_comment_url":"https://api.github.com/repos/broadinstitute/gamgee/pulls/comments/{number}","comments_url":"https://api.github.com/repos/broadinstitute/gamgee/issues/198/comments","statuses_url":"https://api.github.com/repos/broadinstitute/gamgee/statuses/e37b9f947e8f8a52c367ac52b2f1f1edbaf27e28","head":{"label":"broadinstitute:mc_individual_operator_equals_187","ref":"mc_individual_operator_equals_187","sha":"e37b9f947e8f8a52c367ac52b2f1f1edbaf27e28","user":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars.githubusercontent.com/u/393552?v=2","gravatar_id":"15796050d34835c57c1cf412d45b9c0c","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"repo":{"id":17992711,"name":"gamgee","full_name":"broadinstitute/gamgee","owner":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars.githubusercontent.com/u/393552?v=2","gravatar_id":"15796050d34835c57c1cf412d45b9c0c","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/broadinstitute/gamgee","description":"A C++ interface for NGS data formats","fork":false,"url":"https://api.github.com/repos/broadinstitute/gamgee","forks_url":"https://api.github.com/repos/broadinstitute/gamgee/forks","keys_url":"https://api.github.com/repos/broadinstitute/gamgee/keys{/key_id}","collaborators_url":"https://api.github.com/repos/broadinstitute/gamgee/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/broadinstitute/gamgee/teams","hooks_url":"https://api.github.com/repos/broadinstitute/gamgee/hooks","issue_events_url":"https://api.github.com/repos/broadinstitute/gamgee/issues/events{/number}","events_url":"https://api.github.com/repos/broadinstitute/gamgee/events","assignees_url":"https://api.github.com/repos/broadinstitute/gamgee/assignees{/user}","branches_url":"https://api.github.com/repos/broadinstitute/gamgee/branches{/branch}","tags_url":"https://api.github.com/repos/broadinstitute/gamgee/tags","blobs_url":"https://api.github.com/repos/broadinstitute/gamgee/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/broadinstitute/gamgee/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/broadinstitute/gamgee/git/refs{/sha}","trees_url":"https://api.github.com/repos/broadinstitute/gamgee/git/trees{/sha}","statuses_url":"https://api.github.com/repos/broadinstitute/gamgee/statuses/{sha}","languages_url":"https://api.github.com/repos/broadinstitute/gamgee/languages","stargazers_url":"https://api.github.com/repos/broadinstitute/gamgee/stargazers","contributors_url":"https://api.github.com/repos/broadinstitute/gamgee/contributors","subscribers_url":"https://api.github.com/repos/broadinstitute/gamgee/subscribers","subscription_url":"https://api.github.com/repos/broadinstitute/gamgee/subscription","commits_url":"https://api.github.com/repos/broadinstitute/gamgee/commits{/sha}","git_commits_url":"https://api.github.com/repos/broadinstitute/gamgee/git/commits{/sha}","comments_url":"https://api.github.com/repos/broadinstitute/gamgee/comments{/number}","issue_comment_url":"https://api.github.com/repos/broadinstitute/gamgee/issues/comments/{number}","contents_url":"https://api.github.com/repos/broadinstitute/gamgee/contents/{+path}","compare_url":"https://api.github.com/repos/broadinstitute/gamgee/compare/{base}...{head}","merges_url":"https://api.github.com/repos/broadinstitute/gamgee/merges","archive_url":"https://api.github.com/repos/broadinstitute/gamgee/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/broadinstitute/gamgee/downloads","issues_url":"https://api.github.com/repos/broadinstitute/gamgee/issues{/number}","pulls_url":"https://api.github.com/repos/broadinstitute/gamgee/pulls{/number}","milestones_url":"https://api.github.com/repos/broadinstitute/gamgee/milestones{/number}","notifications_url":"https://api.github.com/repos/broadinstitute/gamgee/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/broadinstitute/gamgee/labels{/name}","releases_url":"https://api.github.com/repos/broadinstitute/gamgee/releases{/id}","created_at":"2014-03-21T20:04:04Z","updated_at":"2014-08-17T23:51:01Z","pushed_at":"2014-08-21T18:09:24Z","git_url":"git://github.com/broadinstitute/gamgee.git","ssh_url":"git@github.com:broadinstitute/gamgee.git","clone_url":"https://github.com/broadinstitute/gamgee.git","svn_url":"https://github.com/broadinstitute/gamgee","homepage":"http://broadinstitute.github.io/gamgee/","size":39448,"stargazers_count":14,"watchers_count":14,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":2,"mirror_url":null,"open_issues_count":43,"forks":2,"open_issues":43,"watchers":14,"default_branch":"master"}},"base":{"label":"broadinstitute:master","ref":"master","sha":"0bc63ee638ace63ab649a67240655277c10535ad","user":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars.githubusercontent.com/u/393552?v=2","gravatar_id":"15796050d34835c57c1cf412d45b9c0c","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"repo":{"id":17992711,"name":"gamgee","full_name":"broadinstitute/gamgee","owner":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars.githubusercontent.com/u/393552?v=2","gravatar_id":"15796050d34835c57c1cf412d45b9c0c","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/broadinstitute/gamgee","description":"A C++ interface for NGS data formats","fork":false,"url":"https://api.github.com/repos/broadinstitute/gamgee","forks_url":"https://api.github.com/repos/broadinstitute/gamgee/forks","keys_url":"https://api.github.com/repos/broadinstitute/gamgee/keys{/key_id}","collaborators_url":"https://api.github.com/repos/broadinstitute/gamgee/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/broadinstitute/gamgee/teams","hooks_url":"https://api.github.com/repos/broadinstitute/gamgee/hooks","issue_events_url":"https://api.github.com/repos/broadinstitute/gamgee/issues/events{/number}","events_url":"https://api.github.com/repos/broadinstitute/gamgee/events","assignees_url":"https://api.github.com/repos/broadinstitute/gamgee/assignees{/user}","branches_url":"https://api.github.com/repos/broadinstitute/gamgee/branches{/branch}","tags_url":"https://api.github.com/repos/broadinstitute/gamgee/tags","blobs_url":"https://api.github.com/repos/broadinstitute/gamgee/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/broadinstitute/gamgee/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/broadinstitute/gamgee/git/refs{/sha}","trees_url":"https://api.github.com/repos/broadinstitute/gamgee/git/trees{/sha}","statuses_url":"https://api.github.com/repos/broadinstitute/gamgee/statuses/{sha}","languages_url":"https://api.github.com/repos/broadinstitute/gamgee/languages","stargazers_url":"https://api.github.com/repos/broadinstitute/gamgee/stargazers","contributors_url":"https://api.github.com/repos/broadinstitute/gamgee/contributors","subscribers_url":"https://api.github.com/repos/broadinstitute/gamgee/subscribers","subscription_url":"https://api.github.com/repos/broadinstitute/gamgee/subscription","commits_url":"https://api.github.com/repos/broadinstitute/gamgee/commits{/sha}","git_commits_url":"https://api.github.com/repos/broadinstitute/gamgee/git/commits{/sha}","comments_url":"https://api.github.com/repos/broadinstitute/gamgee/comments{/number}","issue_comment_url":"https://api.github.com/repos/broadinstitute/gamgee/issues/comments/{number}","contents_url":"https://api.github.com/repos/broadinstitute/gamgee/contents/{+path}","compare_url":"https://api.github.com/repos/broadinstitute/gamgee/compare/{base}...{head}","merges_url":"https://api.github.com/repos/broadinstitute/gamgee/merges","archive_url":"https://api.github.com/repos/broadinstitute/gamgee/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/broadinstitute/gamgee/downloads","issues_url":"https://api.github.com/repos/broadinstitute/gamgee/issues{/number}","pulls_url":"https://api.github.com/repos/broadinstitute/gamgee/pulls{/number}","milestones_url":"https://api.github.com/repos/broadinstitute/gamgee/milestones{/number}","notifications_url":"https://api.github.com/repos/broadinstitute/gamgee/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/broadinstitute/gamgee/labels{/name}","releases_url":"https://api.github.com/repos/broadinstitute/gamgee/releases{/id}","created_at":"2014-03-21T20:04:04Z","updated_at":"2014-08-17T23:51:01Z","pushed_at":"2014-08-21T18:09:24Z","git_url":"git://github.com/broadinstitute/gamgee.git","ssh_url":"git@github.com:broadinstitute/gamgee.git","clone_url":"https://github.com/broadinstitute/gamgee.git","svn_url":"https://github.com/broadinstitute/gamgee","homepage":"http://broadinstitute.github.io/gamgee/","size":39448,"stargazers_count":14,"watchers_count":14,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":2,"mirror_url":null,"open_issues_count":43,"forks":2,"open_issues":43,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/broadinstitute/gamgee/pulls/198"},"html":{"href":"https://github.com/broadinstitute/gamgee/pull/198"},"issue":{"href":"https://api.github.com/repos/broadinstitute/gamgee/issues/198"},"comments":{"href":"https://api.github.com/repos/broadinstitute/gamgee/issues/198/comments"},"review_comments":{"href":"https://api.github.com/repos/broadinstitute/gamgee/pulls/198/comments"},"review_comment":{"href":"https://api.github.com/repos/broadinstitute/gamgee/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/broadinstitute/gamgee/pulls/198/commits"},"statuses":{"href":"https://api.github.com/repos/broadinstitute/gamgee/statuses/e37b9f947e8f8a52c367ac52b2f1f1edbaf27e28"}}}}