GitHub PullRequestEvent at 2014-06-23 19:35:07
Repository: puppet
Actor: joshcooper
Payload: {"action":"closed","number":2790,"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppet/pulls/2790","id":17426740,"html_url":"https://github.com/puppetlabs/puppet/pull/2790","diff_url":"https://github.com/puppetlabs/puppet/pull/2790.diff","patch_url":"https://github.com/puppetlabs/puppet/pull/2790.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppet/issues/2790","number":2790,"state":"closed","title":"(PUP-2816) Default forge override in Rakefile","user":{"login":"zaphod42","id":295810,"avatar_url":"https://avatars.githubusercontent.com/u/295810?","gravatar_id":"36ccf398adbe1a4264d57b32917b990c","url":"https://api.github.com/users/zaphod42","html_url":"https://github.com/zaphod42","followers_url":"https://api.github.com/users/zaphod42/followers","following_url":"https://api.github.com/users/zaphod42/following{/other_user}","gists_url":"https://api.github.com/users/zaphod42/gists{/gist_id}","starred_url":"https://api.github.com/users/zaphod42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zaphod42/subscriptions","organizations_url":"https://api.github.com/users/zaphod42/orgs","repos_url":"https://api.github.com/users/zaphod42/repos","events_url":"https://api.github.com/users/zaphod42/events{/privacy}","received_events_url":"https://api.github.com/users/zaphod42/received_events","type":"User","site_admin":false},"body":"The override for the fake forge to use only showed up in the \nci-bootstrap-from-artifacts.sh, but that only affects how the jenkins jobs\nhandle the pipeline. When you run the tests on your own machine, you aren't\ngoing to use that script, which would mean that it would use the wrong fake\nforge. This moves the override to the Rakefile so that it will always take\neffect.","created_at":"2014-06-20T20:43:14Z","updated_at":"2014-06-23T19:35:06Z","closed_at":"2014-06-23T19:35:06Z","merged_at":"2014-06-23T19:35:06Z","merge_commit_sha":"f59acb975b7f15f2097eb7bf40f6f0e30d48bbd1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/2790/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/2790/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/{number}","comments_url":"https://api.github.com/repos/puppetlabs/puppet/issues/2790/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppet/statuses/83260bb327bf40eb263a5e8fb450ca25acab1d2f","head":{"label":"zaphod42:issue/stable/pup-2816-using-wrong-fake-forge","ref":"issue/stable/pup-2816-using-wrong-fake-forge","sha":"83260bb327bf40eb263a5e8fb450ca25acab1d2f","user":{"login":"zaphod42","id":295810,"avatar_url":"https://avatars.githubusercontent.com/u/295810?","gravatar_id":"36ccf398adbe1a4264d57b32917b990c","url":"https://api.github.com/users/zaphod42","html_url":"https://github.com/zaphod42","followers_url":"https://api.github.com/users/zaphod42/followers","following_url":"https://api.github.com/users/zaphod42/following{/other_user}","gists_url":"https://api.github.com/users/zaphod42/gists{/gist_id}","starred_url":"https://api.github.com/users/zaphod42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zaphod42/subscriptions","organizations_url":"https://api.github.com/users/zaphod42/orgs","repos_url":"https://api.github.com/users/zaphod42/repos","events_url":"https://api.github.com/users/zaphod42/events{/privacy}","received_events_url":"https://api.github.com/users/zaphod42/received_events","type":"User","site_admin":false},"repo":{"id":3769776,"name":"puppet","full_name":"zaphod42/puppet","owner":{"login":"zaphod42","id":295810,"avatar_url":"https://avatars.githubusercontent.com/u/295810?","gravatar_id":"36ccf398adbe1a4264d57b32917b990c","url":"https://api.github.com/users/zaphod42","html_url":"https://github.com/zaphod42","followers_url":"https://api.github.com/users/zaphod42/followers","following_url":"https://api.github.com/users/zaphod42/following{/other_user}","gists_url":"https://api.github.com/users/zaphod42/gists{/gist_id}","starred_url":"https://api.github.com/users/zaphod42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zaphod42/subscriptions","organizations_url":"https://api.github.com/users/zaphod42/orgs","repos_url":"https://api.github.com/users/zaphod42/repos","events_url":"https://api.github.com/users/zaphod42/events{/privacy}","received_events_url":"https://api.github.com/users/zaphod42/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zaphod42/puppet","description":"Server automation framework and application","fork":true,"url":"https://api.github.com/repos/zaphod42/puppet","forks_url":"https://api.github.com/repos/zaphod42/puppet/forks","keys_url":"https://api.github.com/repos/zaphod42/puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zaphod42/puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zaphod42/puppet/teams","hooks_url":"https://api.github.com/repos/zaphod42/puppet/hooks","issue_events_url":"https://api.github.com/repos/zaphod42/puppet/issues/events{/number}","events_url":"https://api.github.com/repos/zaphod42/puppet/events","assignees_url":"https://api.github.com/repos/zaphod42/puppet/assignees{/user}","branches_url":"https://api.github.com/repos/zaphod42/puppet/branches{/branch}","tags_url":"https://api.github.com/repos/zaphod42/puppet/tags","blobs_url":"https://api.github.com/repos/zaphod42/puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zaphod42/puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zaphod42/puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/zaphod42/puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zaphod42/puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/zaphod42/puppet/languages","stargazers_url":"https://api.github.com/repos/zaphod42/puppet/stargazers","contributors_url":"https://api.github.com/repos/zaphod42/puppet/contributors","subscribers_url":"https://api.github.com/repos/zaphod42/puppet/subscribers","subscription_url":"https://api.github.com/repos/zaphod42/puppet/subscription","commits_url":"https://api.github.com/repos/zaphod42/puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/zaphod42/puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/zaphod42/puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/zaphod42/puppet/issues/comments/{number}","contents_url":"https://api.github.com/repos/zaphod42/puppet/contents/{+path}","compare_url":"https://api.github.com/repos/zaphod42/puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zaphod42/puppet/merges","archive_url":"https://api.github.com/repos/zaphod42/puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zaphod42/puppet/downloads","issues_url":"https://api.github.com/repos/zaphod42/puppet/issues{/number}","pulls_url":"https://api.github.com/repos/zaphod42/puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/zaphod42/puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/zaphod42/puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zaphod42/puppet/labels{/name}","releases_url":"https://api.github.com/repos/zaphod42/puppet/releases{/id}","created_at":"2012-03-19T23:17:16Z","updated_at":"2014-06-23T19:35:06Z","pushed_at":"2014-06-20T20:43:00Z","git_url":"git://github.com/zaphod42/puppet.git","ssh_url":"git@github.com:zaphod42/puppet.git","clone_url":"https://github.com/zaphod42/puppet.git","svn_url":"https://github.com/zaphod42/puppet","homepage":"http://www.puppetlabs.com/puppet/introduction/","size":44358,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"puppetlabs:stable","ref":"stable","sha":"591198cee8a9c1a2db37e5e6a8cfad23f9847658","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?","gravatar_id":"eb454c2139c156db7c8266a875519a1f","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":910744,"name":"puppet","full_name":"puppetlabs/puppet","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?","gravatar_id":"eb454c2139c156db7c8266a875519a1f","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/puppet","description":"Server automation framework and application","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppet","forks_url":"https://api.github.com/repos/puppetlabs/puppet/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppet/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppet/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppet/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppet/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppet/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppet/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppet/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppet/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppet/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppet/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppet/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppet/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppet/issues/comments/{number}","contents_url":"https://api.github.com/repos/puppetlabs/puppet/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppet/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppet/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppet/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppet/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppet/releases{/id}","created_at":"2010-09-14T19:26:44Z","updated_at":"2014-06-23T19:35:05Z","pushed_at":"2014-06-23T19:35:06Z","git_url":"git://github.com/puppetlabs/puppet.git","ssh_url":"git@github.com:puppetlabs/puppet.git","clone_url":"https://github.com/puppetlabs/puppet.git","svn_url":"https://github.com/puppetlabs/puppet","homepage":"http://www.puppetlabs.com/puppet/introduction/","size":100226,"stargazers_count":2293,"watchers_count":2293,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":1024,"mirror_url":null,"open_issues_count":45,"forks":1024,"open_issues":45,"watchers":2293,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/2790"},"html":{"href":"https://github.com/puppetlabs/puppet/pull/2790"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppet/issues/2790"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppet/issues/2790/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/2790/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/2790/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppet/statuses/83260bb327bf40eb263a5e8fb450ca25acab1d2f"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"joshcooper","id":737664,"avatar_url":"https://avatars.githubusercontent.com/u/737664?","gravatar_id":"c7ff0fe7a67ef06a7717c0dde345acc7","url":"https://api.github.com/users/joshcooper","html_url":"https://github.com/joshcooper","followers_url":"https://api.github.com/users/joshcooper/followers","following_url":"https://api.github.com/users/joshcooper/following{/other_user}","gists_url":"https://api.github.com/users/joshcooper/gists{/gist_id}","starred_url":"https://api.github.com/users/joshcooper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshcooper/subscriptions","organizations_url":"https://api.github.com/users/joshcooper/orgs","repos_url":"https://api.github.com/users/joshcooper/repos","events_url":"https://api.github.com/users/joshcooper/events{/privacy}","received_events_url":"https://api.github.com/users/joshcooper/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":2,"deletions":2,"changed_files":2}}