GitHub PullRequestReviewCommentEvent at 2014-10-11 18:13:47
Repository: wsdl2phpgenerator
Actor: kasperg
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/pulls/comments/18743427","id":18743427,"diff_hunk":"@@ -240,6 +240,9 @@ private static function validateNamingConvention($name)\n             $name = self::NAME_PREFIX . ucfirst($name);\n         }\n \n+        // encoding special chars to avoid naming conflicts at constant names\n+        $name = str_replace(array(';', '&'), '_', htmlspecialchars($name));\n+\n         return preg_replace('/[^a-zA-Z0-9_x7f-xff]*/', '', preg_replace('/^[^a-zA-Z_x7f-xff]*/', '', $name));","path":"src/Wsdl2PhpGenerator/Validator.php","position":7,"original_position":7,"commit_id":"40e480061ab49d5f57db0dc5be546e3d0f755460","original_commit_id":"40e480061ab49d5f57db0dc5be546e3d0f755460","user":{"login":"kasperg","id":73966,"avatar_url":"https://avatars.githubusercontent.com/u/73966?v=2","gravatar_id":"","url":"https://api.github.com/users/kasperg","html_url":"https://github.com/kasperg","followers_url":"https://api.github.com/users/kasperg/followers","following_url":"https://api.github.com/users/kasperg/following{/other_user}","gists_url":"https://api.github.com/users/kasperg/gists{/gist_id}","starred_url":"https://api.github.com/users/kasperg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kasperg/subscriptions","organizations_url":"https://api.github.com/users/kasperg/orgs","repos_url":"https://api.github.com/users/kasperg/repos","events_url":"https://api.github.com/users/kasperg/events{/privacy}","received_events_url":"https://api.github.com/users/kasperg/received_events","type":"User","site_admin":false},"body":"Given the change above it this replacement necessary?","created_at":"2014-10-11T18:13:47Z","updated_at":"2014-10-11T18:13:47Z","html_url":"https://github.com/wsdl2phpgenerator/wsdl2phpgenerator/pull/153#discussion_r18743427","pull_request_url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/pulls/153","_links":{"self":{"href":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/pulls/comments/18743427"},"html":{"href":"https://github.com/wsdl2phpgenerator/wsdl2phpgenerator/pull/153#discussion_r18743427"},"pull_request":{"href":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/pulls/153"}}},"pull_request":{"url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/pulls/153","id":22544622,"html_url":"https://github.com/wsdl2phpgenerator/wsdl2phpgenerator/pull/153","diff_url":"https://github.com/wsdl2phpgenerator/wsdl2phpgenerator/pull/153.diff","patch_url":"https://github.com/wsdl2phpgenerator/wsdl2phpgenerator/pull/153.patch","issue_url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/issues/153","number":153,"state":"open","locked":false,"title":"Resolved problem with naming of constants","user":{"login":"pmarien","id":8394874,"avatar_url":"https://avatars.githubusercontent.com/u/8394874?v=2","gravatar_id":"","url":"https://api.github.com/users/pmarien","html_url":"https://github.com/pmarien","followers_url":"https://api.github.com/users/pmarien/followers","following_url":"https://api.github.com/users/pmarien/following{/other_user}","gists_url":"https://api.github.com/users/pmarien/gists{/gist_id}","starred_url":"https://api.github.com/users/pmarien/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmarien/subscriptions","organizations_url":"https://api.github.com/users/pmarien/orgs","repos_url":"https://api.github.com/users/pmarien/repos","events_url":"https://api.github.com/users/pmarien/events{/privacy}","received_events_url":"https://api.github.com/users/pmarien/received_events","type":"User","site_admin":false},"body":"Resolved problem with naming of constants.\r\nCompatible to php 5.3","created_at":"2014-10-10T07:49:50Z","updated_at":"2014-10-11T18:13:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"26984ac655f59a9e4e88884a8b543e6f3f46dfe1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/pulls/153/commits","review_comments_url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/pulls/153/comments","review_comment_url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/pulls/comments/{number}","comments_url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/issues/153/comments","statuses_url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/statuses/40e480061ab49d5f57db0dc5be546e3d0f755460","head":{"label":"pmarien:3.x","ref":"3.x","sha":"40e480061ab49d5f57db0dc5be546e3d0f755460","user":{"login":"pmarien","id":8394874,"avatar_url":"https://avatars.githubusercontent.com/u/8394874?v=2","gravatar_id":"","url":"https://api.github.com/users/pmarien","html_url":"https://github.com/pmarien","followers_url":"https://api.github.com/users/pmarien/followers","following_url":"https://api.github.com/users/pmarien/following{/other_user}","gists_url":"https://api.github.com/users/pmarien/gists{/gist_id}","starred_url":"https://api.github.com/users/pmarien/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmarien/subscriptions","organizations_url":"https://api.github.com/users/pmarien/orgs","repos_url":"https://api.github.com/users/pmarien/repos","events_url":"https://api.github.com/users/pmarien/events{/privacy}","received_events_url":"https://api.github.com/users/pmarien/received_events","type":"User","site_admin":false},"repo":{"id":24933712,"name":"wsdl2phpgenerator","full_name":"pmarien/wsdl2phpgenerator","owner":{"login":"pmarien","id":8394874,"avatar_url":"https://avatars.githubusercontent.com/u/8394874?v=2","gravatar_id":"","url":"https://api.github.com/users/pmarien","html_url":"https://github.com/pmarien","followers_url":"https://api.github.com/users/pmarien/followers","following_url":"https://api.github.com/users/pmarien/following{/other_user}","gists_url":"https://api.github.com/users/pmarien/gists{/gist_id}","starred_url":"https://api.github.com/users/pmarien/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmarien/subscriptions","organizations_url":"https://api.github.com/users/pmarien/orgs","repos_url":"https://api.github.com/users/pmarien/repos","events_url":"https://api.github.com/users/pmarien/events{/privacy}","received_events_url":"https://api.github.com/users/pmarien/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pmarien/wsdl2phpgenerator","description":"Simple utility and class library for generating php classes from a wsdl file.","fork":true,"url":"https://api.github.com/repos/pmarien/wsdl2phpgenerator","forks_url":"https://api.github.com/repos/pmarien/wsdl2phpgenerator/forks","keys_url":"https://api.github.com/repos/pmarien/wsdl2phpgenerator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pmarien/wsdl2phpgenerator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pmarien/wsdl2phpgenerator/teams","hooks_url":"https://api.github.com/repos/pmarien/wsdl2phpgenerator/hooks","issue_events_url":"https://api.github.com/repos/pmarien/wsdl2phpgenerator/issues/events{/number}","events_url":"https://api.github.com/repos/pmarien/wsdl2phpgenerator/events","assignees_url":"https://api.github.com/repos/pmarien/wsdl2phpgenerator/assignees{/user}","branches_url":"https://api.github.com/repos/pmarien/wsdl2phpgenerator/branches{/branch}","tags_url":"https://api.github.com/repos/pmarien/wsdl2phpgenerator/tags","blobs_url":"https://api.github.com/repos/pmarien/wsdl2phpgenerator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pmarien/wsdl2phpgenerator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pmarien/wsdl2phpgenerator/git/refs{/sha}","trees_url":"https://api.github.com/repos/pmarien/wsdl2phpgenerator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pmarien/wsdl2phpgenerator/statuses/{sha}","languages_url":"https://api.github.com/repos/pmarien/wsdl2phpgenerator/languages","stargazers_url":"https://api.github.com/repos/pmarien/wsdl2phpgenerator/stargazers","contributors_url":"https://api.github.com/repos/pmarien/wsdl2phpgenerator/contributors","subscribers_url":"https://api.github.com/repos/pmarien/wsdl2phpgenerator/subscribers","subscription_url":"https://api.github.com/repos/pmarien/wsdl2phpgenerator/subscription","commits_url":"https://api.github.com/repos/pmarien/wsdl2phpgenerator/commits{/sha}","git_commits_url":"https://api.github.com/repos/pmarien/wsdl2phpgenerator/git/commits{/sha}","comments_url":"https://api.github.com/repos/pmarien/wsdl2phpgenerator/comments{/number}","issue_comment_url":"https://api.github.com/repos/pmarien/wsdl2phpgenerator/issues/comments/{number}","contents_url":"https://api.github.com/repos/pmarien/wsdl2phpgenerator/contents/{+path}","compare_url":"https://api.github.com/repos/pmarien/wsdl2phpgenerator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pmarien/wsdl2phpgenerator/merges","archive_url":"https://api.github.com/repos/pmarien/wsdl2phpgenerator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pmarien/wsdl2phpgenerator/downloads","issues_url":"https://api.github.com/repos/pmarien/wsdl2phpgenerator/issues{/number}","pulls_url":"https://api.github.com/repos/pmarien/wsdl2phpgenerator/pulls{/number}","milestones_url":"https://api.github.com/repos/pmarien/wsdl2phpgenerator/milestones{/number}","notifications_url":"https://api.github.com/repos/pmarien/wsdl2phpgenerator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pmarien/wsdl2phpgenerator/labels{/name}","releases_url":"https://api.github.com/repos/pmarien/wsdl2phpgenerator/releases{/id}","created_at":"2014-10-08T09:30:29Z","updated_at":"2014-10-08T09:41:09Z","pushed_at":"2014-10-10T20:39:59Z","git_url":"git://github.com/pmarien/wsdl2phpgenerator.git","ssh_url":"git@github.com:pmarien/wsdl2phpgenerator.git","clone_url":"https://github.com/pmarien/wsdl2phpgenerator.git","svn_url":"https://github.com/pmarien/wsdl2phpgenerator","homepage":"http://wsdl2phpgenerator.github.io/wsdl2phpgenerator","size":3433,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wsdl2phpgenerator:3.x","ref":"3.x","sha":"ad1c24e37d80c8cc6edf617d9b3ce15cbf44e6cc","user":{"login":"wsdl2phpgenerator","id":5506864,"avatar_url":"https://avatars.githubusercontent.com/u/5506864?v=2","gravatar_id":"","url":"https://api.github.com/users/wsdl2phpgenerator","html_url":"https://github.com/wsdl2phpgenerator","followers_url":"https://api.github.com/users/wsdl2phpgenerator/followers","following_url":"https://api.github.com/users/wsdl2phpgenerator/following{/other_user}","gists_url":"https://api.github.com/users/wsdl2phpgenerator/gists{/gist_id}","starred_url":"https://api.github.com/users/wsdl2phpgenerator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wsdl2phpgenerator/subscriptions","organizations_url":"https://api.github.com/users/wsdl2phpgenerator/orgs","repos_url":"https://api.github.com/users/wsdl2phpgenerator/repos","events_url":"https://api.github.com/users/wsdl2phpgenerator/events{/privacy}","received_events_url":"https://api.github.com/users/wsdl2phpgenerator/received_events","type":"Organization","site_admin":false},"repo":{"id":502867,"name":"wsdl2phpgenerator","full_name":"wsdl2phpgenerator/wsdl2phpgenerator","owner":{"login":"wsdl2phpgenerator","id":5506864,"avatar_url":"https://avatars.githubusercontent.com/u/5506864?v=2","gravatar_id":"","url":"https://api.github.com/users/wsdl2phpgenerator","html_url":"https://github.com/wsdl2phpgenerator","followers_url":"https://api.github.com/users/wsdl2phpgenerator/followers","following_url":"https://api.github.com/users/wsdl2phpgenerator/following{/other_user}","gists_url":"https://api.github.com/users/wsdl2phpgenerator/gists{/gist_id}","starred_url":"https://api.github.com/users/wsdl2phpgenerator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wsdl2phpgenerator/subscriptions","organizations_url":"https://api.github.com/users/wsdl2phpgenerator/orgs","repos_url":"https://api.github.com/users/wsdl2phpgenerator/repos","events_url":"https://api.github.com/users/wsdl2phpgenerator/events{/privacy}","received_events_url":"https://api.github.com/users/wsdl2phpgenerator/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wsdl2phpgenerator/wsdl2phpgenerator","description":"Simple utility and class library for generating php classes from a wsdl file.","fork":false,"url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator","forks_url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/forks","keys_url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/teams","hooks_url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/hooks","issue_events_url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/issues/events{/number}","events_url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/events","assignees_url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/assignees{/user}","branches_url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/branches{/branch}","tags_url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/tags","blobs_url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/git/refs{/sha}","trees_url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/statuses/{sha}","languages_url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/languages","stargazers_url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/stargazers","contributors_url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/contributors","subscribers_url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/subscribers","subscription_url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/subscription","commits_url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/commits{/sha}","git_commits_url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/git/commits{/sha}","comments_url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/comments{/number}","issue_comment_url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/issues/comments/{number}","contents_url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/contents/{+path}","compare_url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/merges","archive_url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/downloads","issues_url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/issues{/number}","pulls_url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/pulls{/number}","milestones_url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/milestones{/number}","notifications_url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/labels{/name}","releases_url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/releases{/id}","created_at":"2010-02-04T20:54:41Z","updated_at":"2014-10-01T12:54:50Z","pushed_at":"2014-10-01T11:48:08Z","git_url":"git://github.com/wsdl2phpgenerator/wsdl2phpgenerator.git","ssh_url":"git@github.com:wsdl2phpgenerator/wsdl2phpgenerator.git","clone_url":"https://github.com/wsdl2phpgenerator/wsdl2phpgenerator.git","svn_url":"https://github.com/wsdl2phpgenerator/wsdl2phpgenerator","homepage":"http://wsdl2phpgenerator.github.io/wsdl2phpgenerator","size":5511,"stargazers_count":157,"watchers_count":157,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":68,"mirror_url":null,"open_issues_count":32,"forks":68,"open_issues":32,"watchers":157,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/pulls/153"},"html":{"href":"https://github.com/wsdl2phpgenerator/wsdl2phpgenerator/pull/153"},"issue":{"href":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/issues/153"},"comments":{"href":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/issues/153/comments"},"review_comments":{"href":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/pulls/153/comments"},"review_comment":{"href":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/pulls/153/commits"},"statuses":{"href":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/statuses/40e480061ab49d5f57db0dc5be546e3d0f755460"}}}}