GitHub PullRequestReviewCommentEvent at 2014-04-07 15:22:51
Repository: cordova-blackberry
Actor: jsoref
Payload: {"comment":{"url":"https://api.github.com/repos/apache/cordova-blackberry/pulls/comments/11348541","id":11348541,"diff_hunk":"@@ -254,16 +254,15 @@ _self = {\n             };\n \n         bb10_utils.exec(script, args, options, function (error, stdout, stderr) {\n-            // error code 3 corresponds to a connected device, null or \"Error: null\" in stderr corresponds to connected emulator\n-            var isSimConnected = (type === \"emulator\" && (\n+            // error code 3 corresponds to connected device with password\n+            // null or \"Error: null\" in stderr corresponds to connected simulator or device without password\n+            var connected =\n                     error === null ||\n+                    (error && error.code === 3) ||","path":"blackberry10/bin/templates/project/cordova/lib/target-utils.js","position":10,"original_position":10,"commit_id":"5a3f7695ccf80e5ceac1346a5dd84f722797db0f","original_commit_id":"5a3f7695ccf80e5ceac1346a5dd84f722797db0f","user":{"login":"jsoref","id":2119212,"avatar_url":"https://avatars.githubusercontent.com/u/2119212?","gravatar_id":"a98ec71db20b1e455d17b47a14de1ae7","url":"https://api.github.com/users/jsoref","html_url":"https://github.com/jsoref","followers_url":"https://api.github.com/users/jsoref/followers","following_url":"https://api.github.com/users/jsoref/following{/other_user}","gists_url":"https://api.github.com/users/jsoref/gists{/gist_id}","starred_url":"https://api.github.com/users/jsoref/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsoref/subscriptions","organizations_url":"https://api.github.com/users/jsoref/orgs","repos_url":"https://api.github.com/users/jsoref/repos","events_url":"https://api.github.com/users/jsoref/events{/privacy}","received_events_url":"https://api.github.com/users/jsoref/received_events","type":"User","site_admin":false},"body":"You shouldn't need error &&, because the error === null || should short circuit it, unless you're expecting someone to pass `error===0` or `error===''` in which case, i think we have bigger issues.","created_at":"2014-04-07T15:22:51Z","updated_at":"2014-04-07T15:22:51Z","html_url":"https://github.com/apache/cordova-blackberry/pull/154#discussion_r11348541","pull_request_url":"https://api.github.com/repos/apache/cordova-blackberry/pulls/154","_links":{"self":{"href":"https://api.github.com/repos/apache/cordova-blackberry/pulls/comments/11348541"},"html":{"href":"https://github.com/apache/cordova-blackberry/pull/154#discussion_r11348541"},"pull_request":{"href":"https://api.github.com/repos/apache/cordova-blackberry/pulls/154"}}}}