GitHub PullRequestReviewCommentEvent at 2014-12-15 15:55:40
Repository: encore-ui
Actor: glynnis
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/rackerlabs/encore-ui/pulls/comments/21834078","id":21834078,"diff_hunk":"@@ -0,0 +1,181 @@\n+<rx-page title=\"'Encore-UI - Forms'\">\n+\n+<h2 class=\"title clear\">Directives</h2>\n+\n+<h3 class=\"title clear\">Labels and Inputs with rxFormItem</h3>\n+\n+<div class=\"component-description clear\">\n+    <ul class=\"list\">\n+        <li>The directive rxFormItem creates a field row wrapped in a label. Used for fields which include a single input/field.</li>\n+        <li>This will also apply to the textarea tag.</li>\n+        <li>You would most likely use this angular.js directive directly, otherwise any input field can be placed inside an element with a class of <code>field-input</code> to apply styling.</li>\n+        <li>NOTE: As of right now, only stacked forms are available. Any implementations for inline forms would have to avoid using rxFormItem, using the field-input class directly.</li>\n+    </ul>\n+</div>\n+\n+<tabset class=\"clearfix clear\">\n+    <tab heading=\"Demo\">\n+        <div rx-compile=\"component.docs.html\" class=\"component-demo\">\n+<h4 class=\"title sm\">rxFormItem Directive</h4>            \n+<rx-form-item label=\"Plain textbox\">\n+    <input type=\"text\" />\n+</rx-form-item>\n+<rx-form-item label=\"Text area\">\n+    <textarea rows=\"10\" cols=\"50\"></textarea>\n+</rx-form-item>\n+\n+<h4 class=\"title sm\">Non-rxFormItem Fields wrapped in .field-input</h4>\n+<span class=\"field-input\">\n+    <input type=\"text\">\n+</span>\n+<span class=\"field-input\">\n+    <input type=\"checkbox\">\n+</span>\n+        </div>\n+    </tab>\n+</tabset>\n+\n+<h3 class=\"title clear\">Compressed Layout</h3>","path":"demo/styleguide/forms.html","position":37,"original_position":38,"commit_id":"06649c9b6dd2dbdc78d164aa3369c9619d6a5a09","original_commit_id":"52cc466624d23e0ce66c95b3e0c608bbee08c276","user":{"login":"glynnis","id":1529366,"avatar_url":"https://avatars.githubusercontent.com/u/1529366?v=3","gravatar_id":"","url":"https://api.github.com/users/glynnis","html_url":"https://github.com/glynnis","followers_url":"https://api.github.com/users/glynnis/followers","following_url":"https://api.github.com/users/glynnis/following{/other_user}","gists_url":"https://api.github.com/users/glynnis/gists{/gist_id}","starred_url":"https://api.github.com/users/glynnis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glynnis/subscriptions","organizations_url":"https://api.github.com/users/glynnis/orgs","repos_url":"https://api.github.com/users/glynnis/repos","events_url":"https://api.github.com/users/glynnis/events{/privacy}","received_events_url":"https://api.github.com/users/glynnis/received_events","type":"User","site_admin":false},"body":"This has been addressed.","created_at":"2014-12-15T15:55:40Z","updated_at":"2014-12-15T15:55:40Z","html_url":"https://github.com/rackerlabs/encore-ui/pull/669#discussion_r21834078","pull_request_url":"https://api.github.com/repos/rackerlabs/encore-ui/pulls/669","_links":{"self":{"href":"https://api.github.com/repos/rackerlabs/encore-ui/pulls/comments/21834078"},"html":{"href":"https://github.com/rackerlabs/encore-ui/pull/669#discussion_r21834078"},"pull_request":{"href":"https://api.github.com/repos/rackerlabs/encore-ui/pulls/669"}}},"pull_request":{"url":"https://api.github.com/repos/rackerlabs/encore-ui/pulls/669","id":25769859,"html_url":"https://github.com/rackerlabs/encore-ui/pull/669","diff_url":"https://github.com/rackerlabs/encore-ui/pull/669.diff","patch_url":"https://github.com/rackerlabs/encore-ui/pull/669.patch","issue_url":"https://api.github.com/repos/rackerlabs/encore-ui/issues/669","number":669,"state":"open","locked":false,"title":"DO NOT MERGE YET: Demo site V2","user":{"login":"ErnieAtLYD","id":33945,"avatar_url":"https://avatars.githubusercontent.com/u/33945?v=3","gravatar_id":"","url":"https://api.github.com/users/ErnieAtLYD","html_url":"https://github.com/ErnieAtLYD","followers_url":"https://api.github.com/users/ErnieAtLYD/followers","following_url":"https://api.github.com/users/ErnieAtLYD/following{/other_user}","gists_url":"https://api.github.com/users/ErnieAtLYD/gists{/gist_id}","starred_url":"https://api.github.com/users/ErnieAtLYD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ErnieAtLYD/subscriptions","organizations_url":"https://api.github.com/users/ErnieAtLYD/orgs","repos_url":"https://api.github.com/users/ErnieAtLYD/repos","events_url":"https://api.github.com/users/ErnieAtLYD/events{/privacy}","received_events_url":"https://api.github.com/users/ErnieAtLYD/received_events","type":"User","site_admin":false},"body":"Looking for team feedback (copy, angular.js optimization) for the V2 style guide demo site. (rackerlabs.github.io/encore-ui/)\r\n\r\nGoing to continue submitting commits, especially those marked FIXME.","created_at":"2014-12-09T19:31:49Z","updated_at":"2014-12-15T15:55:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2145dd3718b5d48ed7eda39fef7769d4f96e513d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rackerlabs/encore-ui/pulls/669/commits","review_comments_url":"https://api.github.com/repos/rackerlabs/encore-ui/pulls/669/comments","review_comment_url":"https://api.github.com/repos/rackerlabs/encore-ui/pulls/comments/{number}","comments_url":"https://api.github.com/repos/rackerlabs/encore-ui/issues/669/comments","statuses_url":"https://api.github.com/repos/rackerlabs/encore-ui/statuses/06649c9b6dd2dbdc78d164aa3369c9619d6a5a09","head":{"label":"rackerlabs:demo-site-V2","ref":"demo-site-V2","sha":"06649c9b6dd2dbdc78d164aa3369c9619d6a5a09","user":{"login":"rackerlabs","id":84293,"avatar_url":"https://avatars.githubusercontent.com/u/84293?v=3","gravatar_id":"","url":"https://api.github.com/users/rackerlabs","html_url":"https://github.com/rackerlabs","followers_url":"https://api.github.com/users/rackerlabs/followers","following_url":"https://api.github.com/users/rackerlabs/following{/other_user}","gists_url":"https://api.github.com/users/rackerlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/rackerlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rackerlabs/subscriptions","organizations_url":"https://api.github.com/users/rackerlabs/orgs","repos_url":"https://api.github.com/users/rackerlabs/repos","events_url":"https://api.github.com/users/rackerlabs/events{/privacy}","received_events_url":"https://api.github.com/users/rackerlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":11432401,"name":"encore-ui","full_name":"rackerlabs/encore-ui","owner":{"login":"rackerlabs","id":84293,"avatar_url":"https://avatars.githubusercontent.com/u/84293?v=3","gravatar_id":"","url":"https://api.github.com/users/rackerlabs","html_url":"https://github.com/rackerlabs","followers_url":"https://api.github.com/users/rackerlabs/followers","following_url":"https://api.github.com/users/rackerlabs/following{/other_user}","gists_url":"https://api.github.com/users/rackerlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/rackerlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rackerlabs/subscriptions","organizations_url":"https://api.github.com/users/rackerlabs/orgs","repos_url":"https://api.github.com/users/rackerlabs/repos","events_url":"https://api.github.com/users/rackerlabs/events{/privacy}","received_events_url":"https://api.github.com/users/rackerlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rackerlabs/encore-ui","description":"UI Framework for Encore","fork":false,"url":"https://api.github.com/repos/rackerlabs/encore-ui","forks_url":"https://api.github.com/repos/rackerlabs/encore-ui/forks","keys_url":"https://api.github.com/repos/rackerlabs/encore-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rackerlabs/encore-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rackerlabs/encore-ui/teams","hooks_url":"https://api.github.com/repos/rackerlabs/encore-ui/hooks","issue_events_url":"https://api.github.com/repos/rackerlabs/encore-ui/issues/events{/number}","events_url":"https://api.github.com/repos/rackerlabs/encore-ui/events","assignees_url":"https://api.github.com/repos/rackerlabs/encore-ui/assignees{/user}","branches_url":"https://api.github.com/repos/rackerlabs/encore-ui/branches{/branch}","tags_url":"https://api.github.com/repos/rackerlabs/encore-ui/tags","blobs_url":"https://api.github.com/repos/rackerlabs/encore-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rackerlabs/encore-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rackerlabs/encore-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/rackerlabs/encore-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rackerlabs/encore-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/rackerlabs/encore-ui/languages","stargazers_url":"https://api.github.com/repos/rackerlabs/encore-ui/stargazers","contributors_url":"https://api.github.com/repos/rackerlabs/encore-ui/contributors","subscribers_url":"https://api.github.com/repos/rackerlabs/encore-ui/subscribers","subscription_url":"https://api.github.com/repos/rackerlabs/encore-ui/subscription","commits_url":"https://api.github.com/repos/rackerlabs/encore-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/rackerlabs/encore-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/rackerlabs/encore-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/rackerlabs/encore-ui/issues/comments/{number}","contents_url":"https://api.github.com/repos/rackerlabs/encore-ui/contents/{+path}","compare_url":"https://api.github.com/repos/rackerlabs/encore-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rackerlabs/encore-ui/merges","archive_url":"https://api.github.com/repos/rackerlabs/encore-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rackerlabs/encore-ui/downloads","issues_url":"https://api.github.com/repos/rackerlabs/encore-ui/issues{/number}","pulls_url":"https://api.github.com/repos/rackerlabs/encore-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/rackerlabs/encore-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/rackerlabs/encore-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rackerlabs/encore-ui/labels{/name}","releases_url":"https://api.github.com/repos/rackerlabs/encore-ui/releases{/id}","created_at":"2013-07-15T20:06:52Z","updated_at":"2014-12-12T16:13:32Z","pushed_at":"2014-12-12T17:49:00Z","git_url":"git://github.com/rackerlabs/encore-ui.git","ssh_url":"git@github.com:rackerlabs/encore-ui.git","clone_url":"https://github.com/rackerlabs/encore-ui.git","svn_url":"https://github.com/rackerlabs/encore-ui","homepage":"http://rackerlabs.github.io/encore-ui/","size":20413,"stargazers_count":23,"watchers_count":23,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":20,"mirror_url":null,"open_issues_count":68,"forks":20,"open_issues":68,"watchers":23,"default_branch":"master"}},"base":{"label":"rackerlabs:master","ref":"master","sha":"583b3da229692b850ec93d4bb97ffdc0706ce3b9","user":{"login":"rackerlabs","id":84293,"avatar_url":"https://avatars.githubusercontent.com/u/84293?v=3","gravatar_id":"","url":"https://api.github.com/users/rackerlabs","html_url":"https://github.com/rackerlabs","followers_url":"https://api.github.com/users/rackerlabs/followers","following_url":"https://api.github.com/users/rackerlabs/following{/other_user}","gists_url":"https://api.github.com/users/rackerlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/rackerlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rackerlabs/subscriptions","organizations_url":"https://api.github.com/users/rackerlabs/orgs","repos_url":"https://api.github.com/users/rackerlabs/repos","events_url":"https://api.github.com/users/rackerlabs/events{/privacy}","received_events_url":"https://api.github.com/users/rackerlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":11432401,"name":"encore-ui","full_name":"rackerlabs/encore-ui","owner":{"login":"rackerlabs","id":84293,"avatar_url":"https://avatars.githubusercontent.com/u/84293?v=3","gravatar_id":"","url":"https://api.github.com/users/rackerlabs","html_url":"https://github.com/rackerlabs","followers_url":"https://api.github.com/users/rackerlabs/followers","following_url":"https://api.github.com/users/rackerlabs/following{/other_user}","gists_url":"https://api.github.com/users/rackerlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/rackerlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rackerlabs/subscriptions","organizations_url":"https://api.github.com/users/rackerlabs/orgs","repos_url":"https://api.github.com/users/rackerlabs/repos","events_url":"https://api.github.com/users/rackerlabs/events{/privacy}","received_events_url":"https://api.github.com/users/rackerlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rackerlabs/encore-ui","description":"UI Framework for Encore","fork":false,"url":"https://api.github.com/repos/rackerlabs/encore-ui","forks_url":"https://api.github.com/repos/rackerlabs/encore-ui/forks","keys_url":"https://api.github.com/repos/rackerlabs/encore-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rackerlabs/encore-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rackerlabs/encore-ui/teams","hooks_url":"https://api.github.com/repos/rackerlabs/encore-ui/hooks","issue_events_url":"https://api.github.com/repos/rackerlabs/encore-ui/issues/events{/number}","events_url":"https://api.github.com/repos/rackerlabs/encore-ui/events","assignees_url":"https://api.github.com/repos/rackerlabs/encore-ui/assignees{/user}","branches_url":"https://api.github.com/repos/rackerlabs/encore-ui/branches{/branch}","tags_url":"https://api.github.com/repos/rackerlabs/encore-ui/tags","blobs_url":"https://api.github.com/repos/rackerlabs/encore-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rackerlabs/encore-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rackerlabs/encore-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/rackerlabs/encore-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rackerlabs/encore-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/rackerlabs/encore-ui/languages","stargazers_url":"https://api.github.com/repos/rackerlabs/encore-ui/stargazers","contributors_url":"https://api.github.com/repos/rackerlabs/encore-ui/contributors","subscribers_url":"https://api.github.com/repos/rackerlabs/encore-ui/subscribers","subscription_url":"https://api.github.com/repos/rackerlabs/encore-ui/subscription","commits_url":"https://api.github.com/repos/rackerlabs/encore-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/rackerlabs/encore-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/rackerlabs/encore-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/rackerlabs/encore-ui/issues/comments/{number}","contents_url":"https://api.github.com/repos/rackerlabs/encore-ui/contents/{+path}","compare_url":"https://api.github.com/repos/rackerlabs/encore-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rackerlabs/encore-ui/merges","archive_url":"https://api.github.com/repos/rackerlabs/encore-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rackerlabs/encore-ui/downloads","issues_url":"https://api.github.com/repos/rackerlabs/encore-ui/issues{/number}","pulls_url":"https://api.github.com/repos/rackerlabs/encore-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/rackerlabs/encore-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/rackerlabs/encore-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rackerlabs/encore-ui/labels{/name}","releases_url":"https://api.github.com/repos/rackerlabs/encore-ui/releases{/id}","created_at":"2013-07-15T20:06:52Z","updated_at":"2014-12-12T16:13:32Z","pushed_at":"2014-12-12T17:49:00Z","git_url":"git://github.com/rackerlabs/encore-ui.git","ssh_url":"git@github.com:rackerlabs/encore-ui.git","clone_url":"https://github.com/rackerlabs/encore-ui.git","svn_url":"https://github.com/rackerlabs/encore-ui","homepage":"http://rackerlabs.github.io/encore-ui/","size":20413,"stargazers_count":23,"watchers_count":23,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":20,"mirror_url":null,"open_issues_count":68,"forks":20,"open_issues":68,"watchers":23,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rackerlabs/encore-ui/pulls/669"},"html":{"href":"https://github.com/rackerlabs/encore-ui/pull/669"},"issue":{"href":"https://api.github.com/repos/rackerlabs/encore-ui/issues/669"},"comments":{"href":"https://api.github.com/repos/rackerlabs/encore-ui/issues/669/comments"},"review_comments":{"href":"https://api.github.com/repos/rackerlabs/encore-ui/pulls/669/comments"},"review_comment":{"href":"https://api.github.com/repos/rackerlabs/encore-ui/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/rackerlabs/encore-ui/pulls/669/commits"},"statuses":{"href":"https://api.github.com/repos/rackerlabs/encore-ui/statuses/06649c9b6dd2dbdc78d164aa3369c9619d6a5a09"}}}}