GitHub PullRequestEvent at 2014-03-01 21:49:01
Repository: peerjs
Actor: michelle
Payload: {"action":"closed","number":163,"pull_request":{"url":"https://api.github.com/repos/peers/peerjs/pulls/163","id":12890697,"html_url":"https://github.com/peers/peerjs/pull/163","diff_url":"https://github.com/peers/peerjs/pull/163.diff","patch_url":"https://github.com/peers/peerjs/pull/163.patch","issue_url":"https://api.github.com/repos/peers/peerjs/issues/163","number":163,"state":"closed","title":"Add a \"path\" option for a namespaced peer server.","user":{"login":"michelle","id":928757,"avatar_url":"https://avatars.githubusercontent.com/u/928757","gravatar_id":"f97b18952f732072a34cdaf37f630863","url":"https://api.github.com/users/michelle","html_url":"https://github.com/michelle","followers_url":"https://api.github.com/users/michelle/followers","following_url":"https://api.github.com/users/michelle/following{/other_user}","gists_url":"https://api.github.com/users/michelle/gists{/gist_id}","starred_url":"https://api.github.com/users/michelle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michelle/subscriptions","organizations_url":"https://api.github.com/users/michelle/orgs","repos_url":"https://api.github.com/users/michelle/repos","events_url":"https://api.github.com/users/michelle/events{/privacy}","received_events_url":"https://api.github.com/users/michelle/received_events","type":"User","site_admin":false},"body":"Addresses #78.\r\n\r\nMy blockers:\r\n\r\n- Not sure `path` is a great name for this option. It's also a bit weird because you have to pass in only the middle part of the path, which makes it a bit hard to explain in the docs. (e.g. `my_namespace` instead of `/my_namespace` or `my_namespace/`.) We can make it smarter but mrrrh :(.\r\n- I actually think it'd be nicer if you can just pass in a fully-formed path (e.g. `https://peerjs.com:8000/my/path` or `https://peerjs.com/my/other/path`)\r\n\r\n@ericz: What do you think? Probably would be good to look at what other libraries do here.","created_at":"2014-02-25T06:59:25Z","updated_at":"2014-03-01T21:49:00Z","closed_at":"2014-03-01T21:49:00Z","merged_at":"2014-03-01T21:49:00Z","merge_commit_sha":"4029c9ca59e26bb4ec4d41384461f35071e74c40","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/peers/peerjs/pulls/163/commits","review_comments_url":"https://api.github.com/repos/peers/peerjs/pulls/163/comments","review_comment_url":"https://api.github.com/repos/peers/peerjs/pulls/comments/{number}","comments_url":"https://api.github.com/repos/peers/peerjs/issues/163/comments","statuses_url":"https://api.github.com/repos/peers/peerjs/statuses/3a2802ecf187cf981ce8b445037fa2856612b8f5","head":{"label":"peers:add-path-option","ref":"add-path-option","sha":"3a2802ecf187cf981ce8b445037fa2856612b8f5","user":{"login":"peers","id":3409784,"avatar_url":"https://avatars.githubusercontent.com/u/3409784","gravatar_id":"1961f60e6deded0814bbe3f10d12c582","url":"https://api.github.com/users/peers","html_url":"https://github.com/peers","followers_url":"https://api.github.com/users/peers/followers","following_url":"https://api.github.com/users/peers/following{/other_user}","gists_url":"https://api.github.com/users/peers/gists{/gist_id}","starred_url":"https://api.github.com/users/peers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peers/subscriptions","organizations_url":"https://api.github.com/users/peers/orgs","repos_url":"https://api.github.com/users/peers/repos","events_url":"https://api.github.com/users/peers/events{/privacy}","received_events_url":"https://api.github.com/users/peers/received_events","type":"Organization","site_admin":false},"repo":{"id":7292898,"name":"peerjs","full_name":"peers/peerjs","owner":{"login":"peers","id":3409784,"avatar_url":"https://avatars.githubusercontent.com/u/3409784","gravatar_id":"1961f60e6deded0814bbe3f10d12c582","url":"https://api.github.com/users/peers","html_url":"https://github.com/peers","followers_url":"https://api.github.com/users/peers/followers","following_url":"https://api.github.com/users/peers/following{/other_user}","gists_url":"https://api.github.com/users/peers/gists{/gist_id}","starred_url":"https://api.github.com/users/peers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peers/subscriptions","organizations_url":"https://api.github.com/users/peers/orgs","repos_url":"https://api.github.com/users/peers/repos","events_url":"https://api.github.com/users/peers/events{/privacy}","received_events_url":"https://api.github.com/users/peers/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/peers/peerjs","description":"Peer-to-peer data in the browser.","fork":false,"url":"https://api.github.com/repos/peers/peerjs","forks_url":"https://api.github.com/repos/peers/peerjs/forks","keys_url":"https://api.github.com/repos/peers/peerjs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/peers/peerjs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/peers/peerjs/teams","hooks_url":"https://api.github.com/repos/peers/peerjs/hooks","issue_events_url":"https://api.github.com/repos/peers/peerjs/issues/events{/number}","events_url":"https://api.github.com/repos/peers/peerjs/events","assignees_url":"https://api.github.com/repos/peers/peerjs/assignees{/user}","branches_url":"https://api.github.com/repos/peers/peerjs/branches{/branch}","tags_url":"https://api.github.com/repos/peers/peerjs/tags","blobs_url":"https://api.github.com/repos/peers/peerjs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/peers/peerjs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/peers/peerjs/git/refs{/sha}","trees_url":"https://api.github.com/repos/peers/peerjs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/peers/peerjs/statuses/{sha}","languages_url":"https://api.github.com/repos/peers/peerjs/languages","stargazers_url":"https://api.github.com/repos/peers/peerjs/stargazers","contributors_url":"https://api.github.com/repos/peers/peerjs/contributors","subscribers_url":"https://api.github.com/repos/peers/peerjs/subscribers","subscription_url":"https://api.github.com/repos/peers/peerjs/subscription","commits_url":"https://api.github.com/repos/peers/peerjs/commits{/sha}","git_commits_url":"https://api.github.com/repos/peers/peerjs/git/commits{/sha}","comments_url":"https://api.github.com/repos/peers/peerjs/comments{/number}","issue_comment_url":"https://api.github.com/repos/peers/peerjs/issues/comments/{number}","contents_url":"https://api.github.com/repos/peers/peerjs/contents/{+path}","compare_url":"https://api.github.com/repos/peers/peerjs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/peers/peerjs/merges","archive_url":"https://api.github.com/repos/peers/peerjs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/peers/peerjs/downloads","issues_url":"https://api.github.com/repos/peers/peerjs/issues{/number}","pulls_url":"https://api.github.com/repos/peers/peerjs/pulls{/number}","milestones_url":"https://api.github.com/repos/peers/peerjs/milestones{/number}","notifications_url":"https://api.github.com/repos/peers/peerjs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/peers/peerjs/labels{/name}","releases_url":"https://api.github.com/repos/peers/peerjs/releases{/id}","created_at":"2012-12-23T07:28:47Z","updated_at":"2014-03-01T21:49:00Z","pushed_at":"2014-03-01T21:49:00Z","git_url":"git://github.com/peers/peerjs.git","ssh_url":"git@github.com:peers/peerjs.git","clone_url":"https://github.com/peers/peerjs.git","svn_url":"https://github.com/peers/peerjs","homepage":"http://peerjs.com","size":2784,"stargazers_count":1933,"watchers_count":1933,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":188,"mirror_url":null,"open_issues_count":35,"forks":188,"open_issues":35,"watchers":1933,"default_branch":"master","master_branch":"master"}},"base":{"label":"peers:master","ref":"master","sha":"7175b8370e53acad7a14f324a22e36bb8fc0a38b","user":{"login":"peers","id":3409784,"avatar_url":"https://avatars.githubusercontent.com/u/3409784","gravatar_id":"1961f60e6deded0814bbe3f10d12c582","url":"https://api.github.com/users/peers","html_url":"https://github.com/peers","followers_url":"https://api.github.com/users/peers/followers","following_url":"https://api.github.com/users/peers/following{/other_user}","gists_url":"https://api.github.com/users/peers/gists{/gist_id}","starred_url":"https://api.github.com/users/peers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peers/subscriptions","organizations_url":"https://api.github.com/users/peers/orgs","repos_url":"https://api.github.com/users/peers/repos","events_url":"https://api.github.com/users/peers/events{/privacy}","received_events_url":"https://api.github.com/users/peers/received_events","type":"Organization","site_admin":false},"repo":{"id":7292898,"name":"peerjs","full_name":"peers/peerjs","owner":{"login":"peers","id":3409784,"avatar_url":"https://avatars.githubusercontent.com/u/3409784","gravatar_id":"1961f60e6deded0814bbe3f10d12c582","url":"https://api.github.com/users/peers","html_url":"https://github.com/peers","followers_url":"https://api.github.com/users/peers/followers","following_url":"https://api.github.com/users/peers/following{/other_user}","gists_url":"https://api.github.com/users/peers/gists{/gist_id}","starred_url":"https://api.github.com/users/peers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peers/subscriptions","organizations_url":"https://api.github.com/users/peers/orgs","repos_url":"https://api.github.com/users/peers/repos","events_url":"https://api.github.com/users/peers/events{/privacy}","received_events_url":"https://api.github.com/users/peers/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/peers/peerjs","description":"Peer-to-peer data in the browser.","fork":false,"url":"https://api.github.com/repos/peers/peerjs","forks_url":"https://api.github.com/repos/peers/peerjs/forks","keys_url":"https://api.github.com/repos/peers/peerjs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/peers/peerjs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/peers/peerjs/teams","hooks_url":"https://api.github.com/repos/peers/peerjs/hooks","issue_events_url":"https://api.github.com/repos/peers/peerjs/issues/events{/number}","events_url":"https://api.github.com/repos/peers/peerjs/events","assignees_url":"https://api.github.com/repos/peers/peerjs/assignees{/user}","branches_url":"https://api.github.com/repos/peers/peerjs/branches{/branch}","tags_url":"https://api.github.com/repos/peers/peerjs/tags","blobs_url":"https://api.github.com/repos/peers/peerjs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/peers/peerjs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/peers/peerjs/git/refs{/sha}","trees_url":"https://api.github.com/repos/peers/peerjs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/peers/peerjs/statuses/{sha}","languages_url":"https://api.github.com/repos/peers/peerjs/languages","stargazers_url":"https://api.github.com/repos/peers/peerjs/stargazers","contributors_url":"https://api.github.com/repos/peers/peerjs/contributors","subscribers_url":"https://api.github.com/repos/peers/peerjs/subscribers","subscription_url":"https://api.github.com/repos/peers/peerjs/subscription","commits_url":"https://api.github.com/repos/peers/peerjs/commits{/sha}","git_commits_url":"https://api.github.com/repos/peers/peerjs/git/commits{/sha}","comments_url":"https://api.github.com/repos/peers/peerjs/comments{/number}","issue_comment_url":"https://api.github.com/repos/peers/peerjs/issues/comments/{number}","contents_url":"https://api.github.com/repos/peers/peerjs/contents/{+path}","compare_url":"https://api.github.com/repos/peers/peerjs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/peers/peerjs/merges","archive_url":"https://api.github.com/repos/peers/peerjs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/peers/peerjs/downloads","issues_url":"https://api.github.com/repos/peers/peerjs/issues{/number}","pulls_url":"https://api.github.com/repos/peers/peerjs/pulls{/number}","milestones_url":"https://api.github.com/repos/peers/peerjs/milestones{/number}","notifications_url":"https://api.github.com/repos/peers/peerjs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/peers/peerjs/labels{/name}","releases_url":"https://api.github.com/repos/peers/peerjs/releases{/id}","created_at":"2012-12-23T07:28:47Z","updated_at":"2014-03-01T21:49:00Z","pushed_at":"2014-03-01T21:49:00Z","git_url":"git://github.com/peers/peerjs.git","ssh_url":"git@github.com:peers/peerjs.git","clone_url":"https://github.com/peers/peerjs.git","svn_url":"https://github.com/peers/peerjs","homepage":"http://peerjs.com","size":2784,"stargazers_count":1933,"watchers_count":1933,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":188,"mirror_url":null,"open_issues_count":35,"forks":188,"open_issues":35,"watchers":1933,"default_branch":"master","master_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/peers/peerjs/pulls/163"},"html":{"href":"https://github.com/peers/peerjs/pull/163"},"issue":{"href":"https://api.github.com/repos/peers/peerjs/issues/163"},"comments":{"href":"https://api.github.com/repos/peers/peerjs/issues/163/comments"},"review_comments":{"href":"https://api.github.com/repos/peers/peerjs/pulls/163/comments"},"review_comment":{"href":"https://api.github.com/repos/peers/peerjs/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/peers/peerjs/pulls/163/commits"},"statuses":{"href":"https://api.github.com/repos/peers/peerjs/statuses/3a2802ecf187cf981ce8b445037fa2856612b8f5"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"michelle","id":928757,"avatar_url":"https://avatars.githubusercontent.com/u/928757","gravatar_id":"f97b18952f732072a34cdaf37f630863","url":"https://api.github.com/users/michelle","html_url":"https://github.com/michelle","followers_url":"https://api.github.com/users/michelle/followers","following_url":"https://api.github.com/users/michelle/following{/other_user}","gists_url":"https://api.github.com/users/michelle/gists{/gist_id}","starred_url":"https://api.github.com/users/michelle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michelle/subscriptions","organizations_url":"https://api.github.com/users/michelle/orgs","repos_url":"https://api.github.com/users/michelle/repos","events_url":"https://api.github.com/users/michelle/events{/privacy}","received_events_url":"https://api.github.com/users/michelle/received_events","type":"User","site_admin":false},"comments":6,"review_comments":0,"commits":5,"additions":54,"deletions":17,"changed_files":6}}