GitHub PullRequestEvent at 2014-05-28 12:12:38
Repository: strongTNC
Actor: dbrgn
Payload: {"action":"closed","number":255,"pull_request":{"url":"https://api.github.com/repos/tnc-ba/strongTNC/pulls/255","id":16373310,"html_url":"https://github.com/tnc-ba/strongTNC/pull/255","diff_url":"https://github.com/tnc-ba/strongTNC/pull/255.diff","patch_url":"https://github.com/tnc-ba/strongTNC/pull/255.patch","issue_url":"https://api.github.com/repos/tnc-ba/strongTNC/issues/255","number":255,"state":"closed","title":"Improved & tested enforcement save view","user":{"login":"dbrgn","id":105168,"avatar_url":"https://avatars.githubusercontent.com/u/105168?","gravatar_id":"282f1d8224546ceaaf23367c8aa7695a","url":"https://api.github.com/users/dbrgn","html_url":"https://github.com/dbrgn","followers_url":"https://api.github.com/users/dbrgn/followers","following_url":"https://api.github.com/users/dbrgn/following{/other_user}","gists_url":"https://api.github.com/users/dbrgn/gists{/gist_id}","starred_url":"https://api.github.com/users/dbrgn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbrgn/subscriptions","organizations_url":"https://api.github.com/users/dbrgn/orgs","repos_url":"https://api.github.com/users/dbrgn/repos","events_url":"https://api.github.com/users/dbrgn/events{/privacy}","received_events_url":"https://api.github.com/users/dbrgn/received_events","type":"User","site_admin":false},"body":"Found this when grepping for TODOs in the sourcecode.\r\n\r\n- Removed ValueErrors (now proper HTTP400 are returned instead of HTTP500)\r\n- Fixed potential KeyErrors\r\n- Added test for enforcement save view\r\n\r\nThis raises coverage to 60%.","created_at":"2014-05-27T14:06:12Z","updated_at":"2014-05-28T12:12:37Z","closed_at":"2014-05-28T12:12:37Z","merged_at":"2014-05-28T12:12:37Z","merge_commit_sha":"2eb09284d6fde2958ed90e885f10d18e41fb16b2","assignee":{"login":"d22","id":546694,"avatar_url":"https://avatars.githubusercontent.com/u/546694?","gravatar_id":"f78f13273c39dd509d62a2a088da9317","url":"https://api.github.com/users/d22","html_url":"https://github.com/d22","followers_url":"https://api.github.com/users/d22/followers","following_url":"https://api.github.com/users/d22/following{/other_user}","gists_url":"https://api.github.com/users/d22/gists{/gist_id}","starred_url":"https://api.github.com/users/d22/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d22/subscriptions","organizations_url":"https://api.github.com/users/d22/orgs","repos_url":"https://api.github.com/users/d22/repos","events_url":"https://api.github.com/users/d22/events{/privacy}","received_events_url":"https://api.github.com/users/d22/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/tnc-ba/strongTNC/milestones/7","labels_url":"https://api.github.com/repos/tnc-ba/strongTNC/milestones/7/labels","id":649209,"number":7,"title":"Iteration 7","description":"","creator":{"login":"d22","id":546694,"avatar_url":"https://avatars.githubusercontent.com/u/546694?","gravatar_id":"f78f13273c39dd509d62a2a088da9317","url":"https://api.github.com/users/d22","html_url":"https://github.com/d22","followers_url":"https://api.github.com/users/d22/followers","following_url":"https://api.github.com/users/d22/following{/other_user}","gists_url":"https://api.github.com/users/d22/gists{/gist_id}","starred_url":"https://api.github.com/users/d22/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d22/subscriptions","organizations_url":"https://api.github.com/users/d22/orgs","repos_url":"https://api.github.com/users/d22/repos","events_url":"https://api.github.com/users/d22/events{/privacy}","received_events_url":"https://api.github.com/users/d22/received_events","type":"User","site_admin":false},"open_issues":36,"closed_issues":50,"state":"open","created_at":"2014-05-05T13:33:22Z","updated_at":"2014-05-28T12:12:37Z","due_on":"2014-06-01T07:00:00Z"},"commits_url":"https://api.github.com/repos/tnc-ba/strongTNC/pulls/255/commits","review_comments_url":"https://api.github.com/repos/tnc-ba/strongTNC/pulls/255/comments","review_comment_url":"https://api.github.com/repos/tnc-ba/strongTNC/pulls/comments/{number}","comments_url":"https://api.github.com/repos/tnc-ba/strongTNC/issues/255/comments","statuses_url":"https://api.github.com/repos/tnc-ba/strongTNC/statuses/c65f2a97a5bed282f0df60a3e4d903d75365149e","head":{"label":"tnc-ba:enforcement_view","ref":"enforcement_view","sha":"c65f2a97a5bed282f0df60a3e4d903d75365149e","user":{"login":"tnc-ba","id":6727157,"avatar_url":"https://avatars.githubusercontent.com/u/6727157?","gravatar_id":"b2ae4b4cccb92071fefee9f3f58e9bb5","url":"https://api.github.com/users/tnc-ba","html_url":"https://github.com/tnc-ba","followers_url":"https://api.github.com/users/tnc-ba/followers","following_url":"https://api.github.com/users/tnc-ba/following{/other_user}","gists_url":"https://api.github.com/users/tnc-ba/gists{/gist_id}","starred_url":"https://api.github.com/users/tnc-ba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tnc-ba/subscriptions","organizations_url":"https://api.github.com/users/tnc-ba/orgs","repos_url":"https://api.github.com/users/tnc-ba/repos","events_url":"https://api.github.com/users/tnc-ba/events{/privacy}","received_events_url":"https://api.github.com/users/tnc-ba/received_events","type":"Organization","site_admin":false},"repo":{"id":16985025,"name":"strongTNC","full_name":"tnc-ba/strongTNC","owner":{"login":"tnc-ba","id":6727157,"avatar_url":"https://avatars.githubusercontent.com/u/6727157?","gravatar_id":"b2ae4b4cccb92071fefee9f3f58e9bb5","url":"https://api.github.com/users/tnc-ba","html_url":"https://github.com/tnc-ba","followers_url":"https://api.github.com/users/tnc-ba/followers","following_url":"https://api.github.com/users/tnc-ba/following{/other_user}","gists_url":"https://api.github.com/users/tnc-ba/gists{/gist_id}","starred_url":"https://api.github.com/users/tnc-ba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tnc-ba/subscriptions","organizations_url":"https://api.github.com/users/tnc-ba/orgs","repos_url":"https://api.github.com/users/tnc-ba/repos","events_url":"https://api.github.com/users/tnc-ba/events{/privacy}","received_events_url":"https://api.github.com/users/tnc-ba/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tnc-ba/strongTNC","description":"BYOD TNC Database Management Tool","fork":true,"url":"https://api.github.com/repos/tnc-ba/strongTNC","forks_url":"https://api.github.com/repos/tnc-ba/strongTNC/forks","keys_url":"https://api.github.com/repos/tnc-ba/strongTNC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tnc-ba/strongTNC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tnc-ba/strongTNC/teams","hooks_url":"https://api.github.com/repos/tnc-ba/strongTNC/hooks","issue_events_url":"https://api.github.com/repos/tnc-ba/strongTNC/issues/events{/number}","events_url":"https://api.github.com/repos/tnc-ba/strongTNC/events","assignees_url":"https://api.github.com/repos/tnc-ba/strongTNC/assignees{/user}","branches_url":"https://api.github.com/repos/tnc-ba/strongTNC/branches{/branch}","tags_url":"https://api.github.com/repos/tnc-ba/strongTNC/tags","blobs_url":"https://api.github.com/repos/tnc-ba/strongTNC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tnc-ba/strongTNC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tnc-ba/strongTNC/git/refs{/sha}","trees_url":"https://api.github.com/repos/tnc-ba/strongTNC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tnc-ba/strongTNC/statuses/{sha}","languages_url":"https://api.github.com/repos/tnc-ba/strongTNC/languages","stargazers_url":"https://api.github.com/repos/tnc-ba/strongTNC/stargazers","contributors_url":"https://api.github.com/repos/tnc-ba/strongTNC/contributors","subscribers_url":"https://api.github.com/repos/tnc-ba/strongTNC/subscribers","subscription_url":"https://api.github.com/repos/tnc-ba/strongTNC/subscription","commits_url":"https://api.github.com/repos/tnc-ba/strongTNC/commits{/sha}","git_commits_url":"https://api.github.com/repos/tnc-ba/strongTNC/git/commits{/sha}","comments_url":"https://api.github.com/repos/tnc-ba/strongTNC/comments{/number}","issue_comment_url":"https://api.github.com/repos/tnc-ba/strongTNC/issues/comments/{number}","contents_url":"https://api.github.com/repos/tnc-ba/strongTNC/contents/{+path}","compare_url":"https://api.github.com/repos/tnc-ba/strongTNC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tnc-ba/strongTNC/merges","archive_url":"https://api.github.com/repos/tnc-ba/strongTNC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tnc-ba/strongTNC/downloads","issues_url":"https://api.github.com/repos/tnc-ba/strongTNC/issues{/number}","pulls_url":"https://api.github.com/repos/tnc-ba/strongTNC/pulls{/number}","milestones_url":"https://api.github.com/repos/tnc-ba/strongTNC/milestones{/number}","notifications_url":"https://api.github.com/repos/tnc-ba/strongTNC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tnc-ba/strongTNC/labels{/name}","releases_url":"https://api.github.com/repos/tnc-ba/strongTNC/releases{/id}","created_at":"2014-02-19T13:29:39Z","updated_at":"2014-05-28T12:12:37Z","pushed_at":"2014-05-28T12:12:37Z","git_url":"git://github.com/tnc-ba/strongTNC.git","ssh_url":"git@github.com:tnc-ba/strongTNC.git","clone_url":"https://github.com/tnc-ba/strongTNC.git","svn_url":"https://github.com/tnc-ba/strongTNC","homepage":"","size":15104,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":65,"forks":0,"open_issues":65,"watchers":0,"default_branch":"master"}},"base":{"label":"tnc-ba:master","ref":"master","sha":"d63a78b3c3f0abc0ba87aae17ceafdae354a24c7","user":{"login":"tnc-ba","id":6727157,"avatar_url":"https://avatars.githubusercontent.com/u/6727157?","gravatar_id":"b2ae4b4cccb92071fefee9f3f58e9bb5","url":"https://api.github.com/users/tnc-ba","html_url":"https://github.com/tnc-ba","followers_url":"https://api.github.com/users/tnc-ba/followers","following_url":"https://api.github.com/users/tnc-ba/following{/other_user}","gists_url":"https://api.github.com/users/tnc-ba/gists{/gist_id}","starred_url":"https://api.github.com/users/tnc-ba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tnc-ba/subscriptions","organizations_url":"https://api.github.com/users/tnc-ba/orgs","repos_url":"https://api.github.com/users/tnc-ba/repos","events_url":"https://api.github.com/users/tnc-ba/events{/privacy}","received_events_url":"https://api.github.com/users/tnc-ba/received_events","type":"Organization","site_admin":false},"repo":{"id":16985025,"name":"strongTNC","full_name":"tnc-ba/strongTNC","owner":{"login":"tnc-ba","id":6727157,"avatar_url":"https://avatars.githubusercontent.com/u/6727157?","gravatar_id":"b2ae4b4cccb92071fefee9f3f58e9bb5","url":"https://api.github.com/users/tnc-ba","html_url":"https://github.com/tnc-ba","followers_url":"https://api.github.com/users/tnc-ba/followers","following_url":"https://api.github.com/users/tnc-ba/following{/other_user}","gists_url":"https://api.github.com/users/tnc-ba/gists{/gist_id}","starred_url":"https://api.github.com/users/tnc-ba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tnc-ba/subscriptions","organizations_url":"https://api.github.com/users/tnc-ba/orgs","repos_url":"https://api.github.com/users/tnc-ba/repos","events_url":"https://api.github.com/users/tnc-ba/events{/privacy}","received_events_url":"https://api.github.com/users/tnc-ba/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tnc-ba/strongTNC","description":"BYOD TNC Database Management Tool","fork":true,"url":"https://api.github.com/repos/tnc-ba/strongTNC","forks_url":"https://api.github.com/repos/tnc-ba/strongTNC/forks","keys_url":"https://api.github.com/repos/tnc-ba/strongTNC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tnc-ba/strongTNC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tnc-ba/strongTNC/teams","hooks_url":"https://api.github.com/repos/tnc-ba/strongTNC/hooks","issue_events_url":"https://api.github.com/repos/tnc-ba/strongTNC/issues/events{/number}","events_url":"https://api.github.com/repos/tnc-ba/strongTNC/events","assignees_url":"https://api.github.com/repos/tnc-ba/strongTNC/assignees{/user}","branches_url":"https://api.github.com/repos/tnc-ba/strongTNC/branches{/branch}","tags_url":"https://api.github.com/repos/tnc-ba/strongTNC/tags","blobs_url":"https://api.github.com/repos/tnc-ba/strongTNC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tnc-ba/strongTNC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tnc-ba/strongTNC/git/refs{/sha}","trees_url":"https://api.github.com/repos/tnc-ba/strongTNC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tnc-ba/strongTNC/statuses/{sha}","languages_url":"https://api.github.com/repos/tnc-ba/strongTNC/languages","stargazers_url":"https://api.github.com/repos/tnc-ba/strongTNC/stargazers","contributors_url":"https://api.github.com/repos/tnc-ba/strongTNC/contributors","subscribers_url":"https://api.github.com/repos/tnc-ba/strongTNC/subscribers","subscription_url":"https://api.github.com/repos/tnc-ba/strongTNC/subscription","commits_url":"https://api.github.com/repos/tnc-ba/strongTNC/commits{/sha}","git_commits_url":"https://api.github.com/repos/tnc-ba/strongTNC/git/commits{/sha}","comments_url":"https://api.github.com/repos/tnc-ba/strongTNC/comments{/number}","issue_comment_url":"https://api.github.com/repos/tnc-ba/strongTNC/issues/comments/{number}","contents_url":"https://api.github.com/repos/tnc-ba/strongTNC/contents/{+path}","compare_url":"https://api.github.com/repos/tnc-ba/strongTNC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tnc-ba/strongTNC/merges","archive_url":"https://api.github.com/repos/tnc-ba/strongTNC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tnc-ba/strongTNC/downloads","issues_url":"https://api.github.com/repos/tnc-ba/strongTNC/issues{/number}","pulls_url":"https://api.github.com/repos/tnc-ba/strongTNC/pulls{/number}","milestones_url":"https://api.github.com/repos/tnc-ba/strongTNC/milestones{/number}","notifications_url":"https://api.github.com/repos/tnc-ba/strongTNC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tnc-ba/strongTNC/labels{/name}","releases_url":"https://api.github.com/repos/tnc-ba/strongTNC/releases{/id}","created_at":"2014-02-19T13:29:39Z","updated_at":"2014-05-28T12:12:37Z","pushed_at":"2014-05-28T12:12:37Z","git_url":"git://github.com/tnc-ba/strongTNC.git","ssh_url":"git@github.com:tnc-ba/strongTNC.git","clone_url":"https://github.com/tnc-ba/strongTNC.git","svn_url":"https://github.com/tnc-ba/strongTNC","homepage":"","size":15104,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":65,"forks":0,"open_issues":65,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tnc-ba/strongTNC/pulls/255"},"html":{"href":"https://github.com/tnc-ba/strongTNC/pull/255"},"issue":{"href":"https://api.github.com/repos/tnc-ba/strongTNC/issues/255"},"comments":{"href":"https://api.github.com/repos/tnc-ba/strongTNC/issues/255/comments"},"review_comments":{"href":"https://api.github.com/repos/tnc-ba/strongTNC/pulls/255/comments"},"review_comment":{"href":"https://api.github.com/repos/tnc-ba/strongTNC/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/tnc-ba/strongTNC/pulls/255/commits"},"statuses":{"href":"https://api.github.com/repos/tnc-ba/strongTNC/statuses/c65f2a97a5bed282f0df60a3e4d903d75365149e"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"dbrgn","id":105168,"avatar_url":"https://avatars.githubusercontent.com/u/105168?","gravatar_id":"282f1d8224546ceaaf23367c8aa7695a","url":"https://api.github.com/users/dbrgn","html_url":"https://github.com/dbrgn","followers_url":"https://api.github.com/users/dbrgn/followers","following_url":"https://api.github.com/users/dbrgn/following{/other_user}","gists_url":"https://api.github.com/users/dbrgn/gists{/gist_id}","starred_url":"https://api.github.com/users/dbrgn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbrgn/subscriptions","organizations_url":"https://api.github.com/users/dbrgn/orgs","repos_url":"https://api.github.com/users/dbrgn/repos","events_url":"https://api.github.com/users/dbrgn/events{/privacy}","received_events_url":"https://api.github.com/users/dbrgn/received_events","type":"User","site_admin":false},"comments":6,"review_comments":0,"commits":1,"additions":143,"deletions":67,"changed_files":4}}