GitHub PullRequestReviewCommentEvent at 2014-07-23 15:50:55
Repository: play_motion
Actor: po1
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/pal-robotics/play_motion/pulls/comments/15296121","id":15296121,"diff_hunk":"@@ -96,6 +97,12 @@ namespace play_motion\n     motion_joints = info.joints;\n   }\n \n+  void getMotionJoints(const std::string& motion_id, JointNames& motion_joints)\n+  {\n+    ros::NodeHandle pm_nh(\"/play_motion\");","path":"play_motion/src/play_motion_helpers.cpp","position":14,"original_position":14,"commit_id":"76a3b43b066e70924d0e5a07d4825bf19cf61c22","original_commit_id":"76a3b43b066e70924d0e5a07d4825bf19cf61c22","user":{"login":"po1","id":3410742,"avatar_url":"https://avatars.githubusercontent.com/u/3410742?","gravatar_id":"4808dc3f5ee7a7a70e527f4b794fd18a","url":"https://api.github.com/users/po1","html_url":"https://github.com/po1","followers_url":"https://api.github.com/users/po1/followers","following_url":"https://api.github.com/users/po1/following{/other_user}","gists_url":"https://api.github.com/users/po1/gists{/gist_id}","starred_url":"https://api.github.com/users/po1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/po1/subscriptions","organizations_url":"https://api.github.com/users/po1/orgs","repos_url":"https://api.github.com/users/po1/repos","events_url":"https://api.github.com/users/po1/events{/privacy}","received_events_url":"https://api.github.com/users/po1/received_events","type":"User","site_admin":false},"body":"I would not use a leading `/`, this breaks namespacing like `<group ns=\"foo\">` in launch files.","created_at":"2014-07-23T15:50:55Z","updated_at":"2014-07-23T15:50:55Z","html_url":"https://github.com/pal-robotics/play_motion/pull/44#discussion_r15296121","pull_request_url":"https://api.github.com/repos/pal-robotics/play_motion/pulls/44","_links":{"self":{"href":"https://api.github.com/repos/pal-robotics/play_motion/pulls/comments/15296121"},"html":{"href":"https://github.com/pal-robotics/play_motion/pull/44#discussion_r15296121"},"pull_request":{"href":"https://api.github.com/repos/pal-robotics/play_motion/pulls/44"}}},"pull_request":{"url":"https://api.github.com/repos/pal-robotics/play_motion/pulls/44","id":18783898,"html_url":"https://github.com/pal-robotics/play_motion/pull/44","diff_url":"https://github.com/pal-robotics/play_motion/pull/44.diff","patch_url":"https://github.com/pal-robotics/play_motion/pull/44.patch","issue_url":"https://api.github.com/repos/pal-robotics/play_motion/issues/44","number":44,"state":"open","title":"Convenience functions","user":{"login":"bmagyar","id":3524577,"avatar_url":"https://avatars.githubusercontent.com/u/3524577?","gravatar_id":"2d5c5ec20db198e8efc4ec568b5cc16f","url":"https://api.github.com/users/bmagyar","html_url":"https://github.com/bmagyar","followers_url":"https://api.github.com/users/bmagyar/followers","following_url":"https://api.github.com/users/bmagyar/following{/other_user}","gists_url":"https://api.github.com/users/bmagyar/gists{/gist_id}","starred_url":"https://api.github.com/users/bmagyar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmagyar/subscriptions","organizations_url":"https://api.github.com/users/bmagyar/orgs","repos_url":"https://api.github.com/users/bmagyar/repos","events_url":"https://api.github.com/users/bmagyar/events{/privacy}","received_events_url":"https://api.github.com/users/bmagyar/received_events","type":"User","site_admin":false},"body":"Added alternative functions to each helper which requires a NodeHandle. Now without this argument the overridden functions create one with the default namespace (play_motion) and call the former functions. \r\n\r\nAlso refactored a few argument names that were using camelCase while the majority uses underscores in this file.","created_at":"2014-07-23T15:47:06Z","updated_at":"2014-07-23T15:50:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"62a597864d644e83055d4fc676107abde50a2629","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/pal-robotics/play_motion/pulls/44/commits","review_comments_url":"https://api.github.com/repos/pal-robotics/play_motion/pulls/44/comments","review_comment_url":"https://api.github.com/repos/pal-robotics/play_motion/pulls/comments/{number}","comments_url":"https://api.github.com/repos/pal-robotics/play_motion/issues/44/comments","statuses_url":"https://api.github.com/repos/pal-robotics/play_motion/statuses/76a3b43b066e70924d0e5a07d4825bf19cf61c22","head":{"label":"bmagyar:convenience_functions","ref":"convenience_functions","sha":"76a3b43b066e70924d0e5a07d4825bf19cf61c22","user":{"login":"bmagyar","id":3524577,"avatar_url":"https://avatars.githubusercontent.com/u/3524577?","gravatar_id":"2d5c5ec20db198e8efc4ec568b5cc16f","url":"https://api.github.com/users/bmagyar","html_url":"https://github.com/bmagyar","followers_url":"https://api.github.com/users/bmagyar/followers","following_url":"https://api.github.com/users/bmagyar/following{/other_user}","gists_url":"https://api.github.com/users/bmagyar/gists{/gist_id}","starred_url":"https://api.github.com/users/bmagyar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmagyar/subscriptions","organizations_url":"https://api.github.com/users/bmagyar/orgs","repos_url":"https://api.github.com/users/bmagyar/repos","events_url":"https://api.github.com/users/bmagyar/events{/privacy}","received_events_url":"https://api.github.com/users/bmagyar/received_events","type":"User","site_admin":false},"repo":{"id":22153794,"name":"play_motion","full_name":"bmagyar/play_motion","owner":{"login":"bmagyar","id":3524577,"avatar_url":"https://avatars.githubusercontent.com/u/3524577?","gravatar_id":"2d5c5ec20db198e8efc4ec568b5cc16f","url":"https://api.github.com/users/bmagyar","html_url":"https://github.com/bmagyar","followers_url":"https://api.github.com/users/bmagyar/followers","following_url":"https://api.github.com/users/bmagyar/following{/other_user}","gists_url":"https://api.github.com/users/bmagyar/gists{/gist_id}","starred_url":"https://api.github.com/users/bmagyar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmagyar/subscriptions","organizations_url":"https://api.github.com/users/bmagyar/orgs","repos_url":"https://api.github.com/users/bmagyar/repos","events_url":"https://api.github.com/users/bmagyar/events{/privacy}","received_events_url":"https://api.github.com/users/bmagyar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bmagyar/play_motion","description":"A tool to play pre-recorded motions on a robot using ros_control","fork":true,"url":"https://api.github.com/repos/bmagyar/play_motion","forks_url":"https://api.github.com/repos/bmagyar/play_motion/forks","keys_url":"https://api.github.com/repos/bmagyar/play_motion/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bmagyar/play_motion/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bmagyar/play_motion/teams","hooks_url":"https://api.github.com/repos/bmagyar/play_motion/hooks","issue_events_url":"https://api.github.com/repos/bmagyar/play_motion/issues/events{/number}","events_url":"https://api.github.com/repos/bmagyar/play_motion/events","assignees_url":"https://api.github.com/repos/bmagyar/play_motion/assignees{/user}","branches_url":"https://api.github.com/repos/bmagyar/play_motion/branches{/branch}","tags_url":"https://api.github.com/repos/bmagyar/play_motion/tags","blobs_url":"https://api.github.com/repos/bmagyar/play_motion/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bmagyar/play_motion/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bmagyar/play_motion/git/refs{/sha}","trees_url":"https://api.github.com/repos/bmagyar/play_motion/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bmagyar/play_motion/statuses/{sha}","languages_url":"https://api.github.com/repos/bmagyar/play_motion/languages","stargazers_url":"https://api.github.com/repos/bmagyar/play_motion/stargazers","contributors_url":"https://api.github.com/repos/bmagyar/play_motion/contributors","subscribers_url":"https://api.github.com/repos/bmagyar/play_motion/subscribers","subscription_url":"https://api.github.com/repos/bmagyar/play_motion/subscription","commits_url":"https://api.github.com/repos/bmagyar/play_motion/commits{/sha}","git_commits_url":"https://api.github.com/repos/bmagyar/play_motion/git/commits{/sha}","comments_url":"https://api.github.com/repos/bmagyar/play_motion/comments{/number}","issue_comment_url":"https://api.github.com/repos/bmagyar/play_motion/issues/comments/{number}","contents_url":"https://api.github.com/repos/bmagyar/play_motion/contents/{+path}","compare_url":"https://api.github.com/repos/bmagyar/play_motion/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bmagyar/play_motion/merges","archive_url":"https://api.github.com/repos/bmagyar/play_motion/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bmagyar/play_motion/downloads","issues_url":"https://api.github.com/repos/bmagyar/play_motion/issues{/number}","pulls_url":"https://api.github.com/repos/bmagyar/play_motion/pulls{/number}","milestones_url":"https://api.github.com/repos/bmagyar/play_motion/milestones{/number}","notifications_url":"https://api.github.com/repos/bmagyar/play_motion/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bmagyar/play_motion/labels{/name}","releases_url":"https://api.github.com/repos/bmagyar/play_motion/releases{/id}","created_at":"2014-07-23T14:38:21Z","updated_at":"2014-07-23T15:18:09Z","pushed_at":"2014-07-23T15:43:26Z","git_url":"git://github.com/bmagyar/play_motion.git","ssh_url":"git@github.com:bmagyar/play_motion.git","clone_url":"https://github.com/bmagyar/play_motion.git","svn_url":"https://github.com/bmagyar/play_motion","homepage":null,"size":317,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"hydro-devel"}},"base":{"label":"pal-robotics:hydro-devel","ref":"hydro-devel","sha":"4dd77a40e0eb8bc011cae8c577b2d7b63834a08f","user":{"login":"pal-robotics","id":1128029,"avatar_url":"https://avatars.githubusercontent.com/u/1128029?","gravatar_id":"acee7f52780e4f693d6aa18f20314f2c","url":"https://api.github.com/users/pal-robotics","html_url":"https://github.com/pal-robotics","followers_url":"https://api.github.com/users/pal-robotics/followers","following_url":"https://api.github.com/users/pal-robotics/following{/other_user}","gists_url":"https://api.github.com/users/pal-robotics/gists{/gist_id}","starred_url":"https://api.github.com/users/pal-robotics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pal-robotics/subscriptions","organizations_url":"https://api.github.com/users/pal-robotics/orgs","repos_url":"https://api.github.com/users/pal-robotics/repos","events_url":"https://api.github.com/users/pal-robotics/events{/privacy}","received_events_url":"https://api.github.com/users/pal-robotics/received_events","type":"Organization","site_admin":false},"repo":{"id":13269331,"name":"play_motion","full_name":"pal-robotics/play_motion","owner":{"login":"pal-robotics","id":1128029,"avatar_url":"https://avatars.githubusercontent.com/u/1128029?","gravatar_id":"acee7f52780e4f693d6aa18f20314f2c","url":"https://api.github.com/users/pal-robotics","html_url":"https://github.com/pal-robotics","followers_url":"https://api.github.com/users/pal-robotics/followers","following_url":"https://api.github.com/users/pal-robotics/following{/other_user}","gists_url":"https://api.github.com/users/pal-robotics/gists{/gist_id}","starred_url":"https://api.github.com/users/pal-robotics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pal-robotics/subscriptions","organizations_url":"https://api.github.com/users/pal-robotics/orgs","repos_url":"https://api.github.com/users/pal-robotics/repos","events_url":"https://api.github.com/users/pal-robotics/events{/privacy}","received_events_url":"https://api.github.com/users/pal-robotics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pal-robotics/play_motion","description":"A tool to play pre-recorded motions on a robot using ros_control","fork":false,"url":"https://api.github.com/repos/pal-robotics/play_motion","forks_url":"https://api.github.com/repos/pal-robotics/play_motion/forks","keys_url":"https://api.github.com/repos/pal-robotics/play_motion/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pal-robotics/play_motion/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pal-robotics/play_motion/teams","hooks_url":"https://api.github.com/repos/pal-robotics/play_motion/hooks","issue_events_url":"https://api.github.com/repos/pal-robotics/play_motion/issues/events{/number}","events_url":"https://api.github.com/repos/pal-robotics/play_motion/events","assignees_url":"https://api.github.com/repos/pal-robotics/play_motion/assignees{/user}","branches_url":"https://api.github.com/repos/pal-robotics/play_motion/branches{/branch}","tags_url":"https://api.github.com/repos/pal-robotics/play_motion/tags","blobs_url":"https://api.github.com/repos/pal-robotics/play_motion/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pal-robotics/play_motion/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pal-robotics/play_motion/git/refs{/sha}","trees_url":"https://api.github.com/repos/pal-robotics/play_motion/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pal-robotics/play_motion/statuses/{sha}","languages_url":"https://api.github.com/repos/pal-robotics/play_motion/languages","stargazers_url":"https://api.github.com/repos/pal-robotics/play_motion/stargazers","contributors_url":"https://api.github.com/repos/pal-robotics/play_motion/contributors","subscribers_url":"https://api.github.com/repos/pal-robotics/play_motion/subscribers","subscription_url":"https://api.github.com/repos/pal-robotics/play_motion/subscription","commits_url":"https://api.github.com/repos/pal-robotics/play_motion/commits{/sha}","git_commits_url":"https://api.github.com/repos/pal-robotics/play_motion/git/commits{/sha}","comments_url":"https://api.github.com/repos/pal-robotics/play_motion/comments{/number}","issue_comment_url":"https://api.github.com/repos/pal-robotics/play_motion/issues/comments/{number}","contents_url":"https://api.github.com/repos/pal-robotics/play_motion/contents/{+path}","compare_url":"https://api.github.com/repos/pal-robotics/play_motion/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pal-robotics/play_motion/merges","archive_url":"https://api.github.com/repos/pal-robotics/play_motion/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pal-robotics/play_motion/downloads","issues_url":"https://api.github.com/repos/pal-robotics/play_motion/issues{/number}","pulls_url":"https://api.github.com/repos/pal-robotics/play_motion/pulls{/number}","milestones_url":"https://api.github.com/repos/pal-robotics/play_motion/milestones{/number}","notifications_url":"https://api.github.com/repos/pal-robotics/play_motion/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pal-robotics/play_motion/labels{/name}","releases_url":"https://api.github.com/repos/pal-robotics/play_motion/releases{/id}","created_at":"2013-10-02T11:26:57Z","updated_at":"2014-07-02T14:45:43Z","pushed_at":"2014-07-02T14:45:43Z","git_url":"git://github.com/pal-robotics/play_motion.git","ssh_url":"git@github.com:pal-robotics/play_motion.git","clone_url":"https://github.com/pal-robotics/play_motion.git","svn_url":"https://github.com/pal-robotics/play_motion","homepage":null,"size":1447,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":6,"mirror_url":null,"open_issues_count":13,"forks":6,"open_issues":13,"watchers":0,"default_branch":"hydro-devel"}},"_links":{"self":{"href":"https://api.github.com/repos/pal-robotics/play_motion/pulls/44"},"html":{"href":"https://github.com/pal-robotics/play_motion/pull/44"},"issue":{"href":"https://api.github.com/repos/pal-robotics/play_motion/issues/44"},"comments":{"href":"https://api.github.com/repos/pal-robotics/play_motion/issues/44/comments"},"review_comments":{"href":"https://api.github.com/repos/pal-robotics/play_motion/pulls/44/comments"},"review_comment":{"href":"https://api.github.com/repos/pal-robotics/play_motion/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/pal-robotics/play_motion/pulls/44/commits"},"statuses":{"href":"https://api.github.com/repos/pal-robotics/play_motion/statuses/76a3b43b066e70924d0e5a07d4825bf19cf61c22"}}}}