GitHub PullRequestReviewCommentEvent at 2014-04-24 15:23:44
Repository: cfme_tests
Actor: psav
Payload: {"comment":{"url":"https://api.github.com/repos/RedHatQE/cfme_tests/pulls/comments/11954151","id":11954151,"diff_hunk":"@@ -18,3 +19,27 @@ def test_system_image_type_crud():\n     with update(sys_image_type):\n         sys_image_type.name = sys_image_type.name + \"_update\"\n     sys_image_type.delete(cancel=False)\n+\n+\n+def test_duplicate_name_error_validation():\n+    \"\"\"\n+    Tests a System Image for duplicate name.\n+    \"\"\"\n+    sys_image_type = pxe.SystemImageType(\n+        name=generate_random_string(size=8),\n+        provision_type='Vm')\n+    sys_image_type.create()\n+    with error.expected('Name has already been taken'):\n+        sys_image_type.create()\n+    sys_image_type.delete(cancel=False)\n+\n+\n+def test_name_required_error_validation():\n+    \"\"\"\n+    Tests a System Image for with no name.\n+    \"\"\"\n+    sys_image_type = pxe.SystemImageType(\n+        name=\"\",","path":"cfme/tests/infrastructure/test_system_image_type.py","position":32,"original_position":32,"commit_id":"dd66eabc1d71a6bf09f899ac8a5e4f95632e92d1","original_commit_id":"dd66eabc1d71a6bf09f899ac8a5e4f95632e92d1","user":{"login":"psav","id":5639745,"avatar_url":"https://avatars.githubusercontent.com/u/5639745?","gravatar_id":"0adc6d3a3c9f5f5f5af85376ce324ac9","url":"https://api.github.com/users/psav","html_url":"https://github.com/psav","followers_url":"https://api.github.com/users/psav/followers","following_url":"https://api.github.com/users/psav/following{/other_user}","gists_url":"https://api.github.com/users/psav/gists{/gist_id}","starred_url":"https://api.github.com/users/psav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psav/subscriptions","organizations_url":"https://api.github.com/users/psav/orgs","repos_url":"https://api.github.com/users/psav/repos","events_url":"https://api.github.com/users/psav/events{/privacy}","received_events_url":"https://api.github.com/users/psav/received_events","type":"User","site_admin":false},"body":"I would prefer this to be None and not \"\"","created_at":"2014-04-24T15:23:44Z","updated_at":"2014-04-24T15:23:44Z","html_url":"https://github.com/RedHatQE/cfme_tests/pull/692#discussion_r11954151","pull_request_url":"https://api.github.com/repos/RedHatQE/cfme_tests/pulls/692","_links":{"self":{"href":"https://api.github.com/repos/RedHatQE/cfme_tests/pulls/comments/11954151"},"html":{"href":"https://github.com/RedHatQE/cfme_tests/pull/692#discussion_r11954151"},"pull_request":{"href":"https://api.github.com/repos/RedHatQE/cfme_tests/pulls/692"}}}}