GitHub PullRequestReviewCommentEvent at 2014-12-03 22:36:00
Repository: dimgem
Actor: v0y
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/geodotka/dimgem/pulls/comments/21271291","id":21271291,"diff_hunk":"@@ -1,23 +1,56 @@\n+#!/usr/bin/env python\n+# encoding: utf-8\n+\n from django.conf.urls import patterns, include, url\n from django.contrib import admin\n+from dimgem.views import ShowPostView\n \n \n admin.autodiscover()\n \n \n urlpatterns = patterns('dimgem.views',\n-    url(r'^dim/$', 'home', name='home1'),\n-    url(r'^gem/$', 'home', name='home2'),\n-    url(r'^dim/gramatyka/$', 'show_posts', name='gramma1'),\n-    url(r'^gem/gramatyka/$', 'show_posts', name='gramma2'),\n-    url(r'^dim/slownictwo/$', 'show_posts', name='vocabulary1'),\n-    url(r'^gem/slownictwo/$', 'show_posts', name='vocabulary2'),\n-    url(r'^dim/ciekawostki/$', 'show_posts', name='curiosity1'),\n-    url(r'^gem/ciekawostki/$', 'show_posts', name='curiosity2'),\n-    url(r'^dim/false_friends/$', 'show_posts', name='false_friends1'),\n-    url(r'^gem/false_friends/$', 'show_posts', name='false_friends2'),\n+    url(r'^$', 'home', name='home'),","path":"dimgem/urls.py","position":23,"original_position":23,"commit_id":"fdc4b3c6b9558458d2bc05b91bf5c63e1f09316f","original_commit_id":"fdc4b3c6b9558458d2bc05b91bf5c63e1f09316f","user":{"login":"v0y","id":3825931,"avatar_url":"https://avatars.githubusercontent.com/u/3825931?v=3","gravatar_id":"","url":"https://api.github.com/users/v0y","html_url":"https://github.com/v0y","followers_url":"https://api.github.com/users/v0y/followers","following_url":"https://api.github.com/users/v0y/following{/other_user}","gists_url":"https://api.github.com/users/v0y/gists{/gist_id}","starred_url":"https://api.github.com/users/v0y/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/v0y/subscriptions","organizations_url":"https://api.github.com/users/v0y/orgs","repos_url":"https://api.github.com/users/v0y/repos","events_url":"https://api.github.com/users/v0y/events{/privacy}","received_events_url":"https://api.github.com/users/v0y/received_events","type":"User","site_admin":false},"body":"jedyne, co robi widok `home` to renderowanie templatki. Jest więc zbędny, możesz to zrobić w urlu:\r\n```python\r\nurl(r'^$', TemplateView.as_view(template_name='home.html', name='home')\r\n```","created_at":"2014-12-03T22:36:00Z","updated_at":"2014-12-03T22:36:00Z","html_url":"https://github.com/geodotka/dimgem/pull/20#discussion_r21271291","pull_request_url":"https://api.github.com/repos/geodotka/dimgem/pulls/20","_links":{"self":{"href":"https://api.github.com/repos/geodotka/dimgem/pulls/comments/21271291"},"html":{"href":"https://github.com/geodotka/dimgem/pull/20#discussion_r21271291"},"pull_request":{"href":"https://api.github.com/repos/geodotka/dimgem/pulls/20"}}},"pull_request":{"url":"https://api.github.com/repos/geodotka/dimgem/pulls/20","id":25440479,"html_url":"https://github.com/geodotka/dimgem/pull/20","diff_url":"https://github.com/geodotka/dimgem/pull/20.diff","patch_url":"https://github.com/geodotka/dimgem/pull/20.patch","issue_url":"https://api.github.com/repos/geodotka/dimgem/issues/20","number":20,"state":"open","locked":false,"title":"17 fix urls and views","user":{"login":"geodotka","id":8895503,"avatar_url":"https://avatars.githubusercontent.com/u/8895503?v=3","gravatar_id":"","url":"https://api.github.com/users/geodotka","html_url":"https://github.com/geodotka","followers_url":"https://api.github.com/users/geodotka/followers","following_url":"https://api.github.com/users/geodotka/following{/other_user}","gists_url":"https://api.github.com/users/geodotka/gists{/gist_id}","starred_url":"https://api.github.com/users/geodotka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geodotka/subscriptions","organizations_url":"https://api.github.com/users/geodotka/orgs","repos_url":"https://api.github.com/users/geodotka/repos","events_url":"https://api.github.com/users/geodotka/events{/privacy}","received_events_url":"https://api.github.com/users/geodotka/received_events","type":"User","site_admin":false},"body":"close #17 ","created_at":"2014-12-03T18:29:44Z","updated_at":"2014-12-03T22:36:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d6bab977543f6fc4954956028973df379d976742","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/geodotka/dimgem/pulls/20/commits","review_comments_url":"https://api.github.com/repos/geodotka/dimgem/pulls/20/comments","review_comment_url":"https://api.github.com/repos/geodotka/dimgem/pulls/comments/{number}","comments_url":"https://api.github.com/repos/geodotka/dimgem/issues/20/comments","statuses_url":"https://api.github.com/repos/geodotka/dimgem/statuses/fdc4b3c6b9558458d2bc05b91bf5c63e1f09316f","head":{"label":"geodotka:17-fix_urls_and_views","ref":"17-fix_urls_and_views","sha":"fdc4b3c6b9558458d2bc05b91bf5c63e1f09316f","user":{"login":"geodotka","id":8895503,"avatar_url":"https://avatars.githubusercontent.com/u/8895503?v=3","gravatar_id":"","url":"https://api.github.com/users/geodotka","html_url":"https://github.com/geodotka","followers_url":"https://api.github.com/users/geodotka/followers","following_url":"https://api.github.com/users/geodotka/following{/other_user}","gists_url":"https://api.github.com/users/geodotka/gists{/gist_id}","starred_url":"https://api.github.com/users/geodotka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geodotka/subscriptions","organizations_url":"https://api.github.com/users/geodotka/orgs","repos_url":"https://api.github.com/users/geodotka/repos","events_url":"https://api.github.com/users/geodotka/events{/privacy}","received_events_url":"https://api.github.com/users/geodotka/received_events","type":"User","site_admin":false},"repo":{"id":26821018,"name":"dimgem","full_name":"geodotka/dimgem","owner":{"login":"geodotka","id":8895503,"avatar_url":"https://avatars.githubusercontent.com/u/8895503?v=3","gravatar_id":"","url":"https://api.github.com/users/geodotka","html_url":"https://github.com/geodotka","followers_url":"https://api.github.com/users/geodotka/followers","following_url":"https://api.github.com/users/geodotka/following{/other_user}","gists_url":"https://api.github.com/users/geodotka/gists{/gist_id}","starred_url":"https://api.github.com/users/geodotka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geodotka/subscriptions","organizations_url":"https://api.github.com/users/geodotka/orgs","repos_url":"https://api.github.com/users/geodotka/repos","events_url":"https://api.github.com/users/geodotka/events{/privacy}","received_events_url":"https://api.github.com/users/geodotka/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/geodotka/dimgem","description":"","fork":false,"url":"https://api.github.com/repos/geodotka/dimgem","forks_url":"https://api.github.com/repos/geodotka/dimgem/forks","keys_url":"https://api.github.com/repos/geodotka/dimgem/keys{/key_id}","collaborators_url":"https://api.github.com/repos/geodotka/dimgem/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/geodotka/dimgem/teams","hooks_url":"https://api.github.com/repos/geodotka/dimgem/hooks","issue_events_url":"https://api.github.com/repos/geodotka/dimgem/issues/events{/number}","events_url":"https://api.github.com/repos/geodotka/dimgem/events","assignees_url":"https://api.github.com/repos/geodotka/dimgem/assignees{/user}","branches_url":"https://api.github.com/repos/geodotka/dimgem/branches{/branch}","tags_url":"https://api.github.com/repos/geodotka/dimgem/tags","blobs_url":"https://api.github.com/repos/geodotka/dimgem/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/geodotka/dimgem/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/geodotka/dimgem/git/refs{/sha}","trees_url":"https://api.github.com/repos/geodotka/dimgem/git/trees{/sha}","statuses_url":"https://api.github.com/repos/geodotka/dimgem/statuses/{sha}","languages_url":"https://api.github.com/repos/geodotka/dimgem/languages","stargazers_url":"https://api.github.com/repos/geodotka/dimgem/stargazers","contributors_url":"https://api.github.com/repos/geodotka/dimgem/contributors","subscribers_url":"https://api.github.com/repos/geodotka/dimgem/subscribers","subscription_url":"https://api.github.com/repos/geodotka/dimgem/subscription","commits_url":"https://api.github.com/repos/geodotka/dimgem/commits{/sha}","git_commits_url":"https://api.github.com/repos/geodotka/dimgem/git/commits{/sha}","comments_url":"https://api.github.com/repos/geodotka/dimgem/comments{/number}","issue_comment_url":"https://api.github.com/repos/geodotka/dimgem/issues/comments/{number}","contents_url":"https://api.github.com/repos/geodotka/dimgem/contents/{+path}","compare_url":"https://api.github.com/repos/geodotka/dimgem/compare/{base}...{head}","merges_url":"https://api.github.com/repos/geodotka/dimgem/merges","archive_url":"https://api.github.com/repos/geodotka/dimgem/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/geodotka/dimgem/downloads","issues_url":"https://api.github.com/repos/geodotka/dimgem/issues{/number}","pulls_url":"https://api.github.com/repos/geodotka/dimgem/pulls{/number}","milestones_url":"https://api.github.com/repos/geodotka/dimgem/milestones{/number}","notifications_url":"https://api.github.com/repos/geodotka/dimgem/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/geodotka/dimgem/labels{/name}","releases_url":"https://api.github.com/repos/geodotka/dimgem/releases{/id}","created_at":"2014-11-18T17:26:10Z","updated_at":"2014-11-28T22:53:42Z","pushed_at":"2014-12-03T22:28:31Z","git_url":"git://github.com/geodotka/dimgem.git","ssh_url":"git@github.com:geodotka/dimgem.git","clone_url":"https://github.com/geodotka/dimgem.git","svn_url":"https://github.com/geodotka/dimgem","homepage":null,"size":1048,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":10,"forks":0,"open_issues":10,"watchers":0,"default_branch":"master"}},"base":{"label":"geodotka:master","ref":"master","sha":"7012c1b83b06a3f640043a6128d7b011c55476b0","user":{"login":"geodotka","id":8895503,"avatar_url":"https://avatars.githubusercontent.com/u/8895503?v=3","gravatar_id":"","url":"https://api.github.com/users/geodotka","html_url":"https://github.com/geodotka","followers_url":"https://api.github.com/users/geodotka/followers","following_url":"https://api.github.com/users/geodotka/following{/other_user}","gists_url":"https://api.github.com/users/geodotka/gists{/gist_id}","starred_url":"https://api.github.com/users/geodotka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geodotka/subscriptions","organizations_url":"https://api.github.com/users/geodotka/orgs","repos_url":"https://api.github.com/users/geodotka/repos","events_url":"https://api.github.com/users/geodotka/events{/privacy}","received_events_url":"https://api.github.com/users/geodotka/received_events","type":"User","site_admin":false},"repo":{"id":26821018,"name":"dimgem","full_name":"geodotka/dimgem","owner":{"login":"geodotka","id":8895503,"avatar_url":"https://avatars.githubusercontent.com/u/8895503?v=3","gravatar_id":"","url":"https://api.github.com/users/geodotka","html_url":"https://github.com/geodotka","followers_url":"https://api.github.com/users/geodotka/followers","following_url":"https://api.github.com/users/geodotka/following{/other_user}","gists_url":"https://api.github.com/users/geodotka/gists{/gist_id}","starred_url":"https://api.github.com/users/geodotka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geodotka/subscriptions","organizations_url":"https://api.github.com/users/geodotka/orgs","repos_url":"https://api.github.com/users/geodotka/repos","events_url":"https://api.github.com/users/geodotka/events{/privacy}","received_events_url":"https://api.github.com/users/geodotka/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/geodotka/dimgem","description":"","fork":false,"url":"https://api.github.com/repos/geodotka/dimgem","forks_url":"https://api.github.com/repos/geodotka/dimgem/forks","keys_url":"https://api.github.com/repos/geodotka/dimgem/keys{/key_id}","collaborators_url":"https://api.github.com/repos/geodotka/dimgem/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/geodotka/dimgem/teams","hooks_url":"https://api.github.com/repos/geodotka/dimgem/hooks","issue_events_url":"https://api.github.com/repos/geodotka/dimgem/issues/events{/number}","events_url":"https://api.github.com/repos/geodotka/dimgem/events","assignees_url":"https://api.github.com/repos/geodotka/dimgem/assignees{/user}","branches_url":"https://api.github.com/repos/geodotka/dimgem/branches{/branch}","tags_url":"https://api.github.com/repos/geodotka/dimgem/tags","blobs_url":"https://api.github.com/repos/geodotka/dimgem/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/geodotka/dimgem/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/geodotka/dimgem/git/refs{/sha}","trees_url":"https://api.github.com/repos/geodotka/dimgem/git/trees{/sha}","statuses_url":"https://api.github.com/repos/geodotka/dimgem/statuses/{sha}","languages_url":"https://api.github.com/repos/geodotka/dimgem/languages","stargazers_url":"https://api.github.com/repos/geodotka/dimgem/stargazers","contributors_url":"https://api.github.com/repos/geodotka/dimgem/contributors","subscribers_url":"https://api.github.com/repos/geodotka/dimgem/subscribers","subscription_url":"https://api.github.com/repos/geodotka/dimgem/subscription","commits_url":"https://api.github.com/repos/geodotka/dimgem/commits{/sha}","git_commits_url":"https://api.github.com/repos/geodotka/dimgem/git/commits{/sha}","comments_url":"https://api.github.com/repos/geodotka/dimgem/comments{/number}","issue_comment_url":"https://api.github.com/repos/geodotka/dimgem/issues/comments/{number}","contents_url":"https://api.github.com/repos/geodotka/dimgem/contents/{+path}","compare_url":"https://api.github.com/repos/geodotka/dimgem/compare/{base}...{head}","merges_url":"https://api.github.com/repos/geodotka/dimgem/merges","archive_url":"https://api.github.com/repos/geodotka/dimgem/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/geodotka/dimgem/downloads","issues_url":"https://api.github.com/repos/geodotka/dimgem/issues{/number}","pulls_url":"https://api.github.com/repos/geodotka/dimgem/pulls{/number}","milestones_url":"https://api.github.com/repos/geodotka/dimgem/milestones{/number}","notifications_url":"https://api.github.com/repos/geodotka/dimgem/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/geodotka/dimgem/labels{/name}","releases_url":"https://api.github.com/repos/geodotka/dimgem/releases{/id}","created_at":"2014-11-18T17:26:10Z","updated_at":"2014-11-28T22:53:42Z","pushed_at":"2014-12-03T22:28:31Z","git_url":"git://github.com/geodotka/dimgem.git","ssh_url":"git@github.com:geodotka/dimgem.git","clone_url":"https://github.com/geodotka/dimgem.git","svn_url":"https://github.com/geodotka/dimgem","homepage":null,"size":1048,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":10,"forks":0,"open_issues":10,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/geodotka/dimgem/pulls/20"},"html":{"href":"https://github.com/geodotka/dimgem/pull/20"},"issue":{"href":"https://api.github.com/repos/geodotka/dimgem/issues/20"},"comments":{"href":"https://api.github.com/repos/geodotka/dimgem/issues/20/comments"},"review_comments":{"href":"https://api.github.com/repos/geodotka/dimgem/pulls/20/comments"},"review_comment":{"href":"https://api.github.com/repos/geodotka/dimgem/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/geodotka/dimgem/pulls/20/commits"},"statuses":{"href":"https://api.github.com/repos/geodotka/dimgem/statuses/fdc4b3c6b9558458d2bc05b91bf5c63e1f09316f"}}}}