GitHub PullRequestEvent at 2014-11-18 19:03:25
Repository: css-modal
Actor: drublic
Payload: {"action":"opened","number":167,"pull_request":{"url":"https://api.github.com/repos/drublic/css-modal/pulls/167","id":24635344,"html_url":"https://github.com/drublic/css-modal/pull/167","diff_url":"https://github.com/drublic/css-modal/pull/167.diff","patch_url":"https://github.com/drublic/css-modal/pull/167.patch","issue_url":"https://api.github.com/repos/drublic/css-modal/issues/167","number":167,"state":"open","locked":false,"title":"Use jQuery as CustomEvent fallback instead of Bean","user":{"login":"drublic","id":502487,"avatar_url":"https://avatars.githubusercontent.com/u/502487?v=3","gravatar_id":"","url":"https://api.github.com/users/drublic","html_url":"https://github.com/drublic","followers_url":"https://api.github.com/users/drublic/followers","following_url":"https://api.github.com/users/drublic/following{/other_user}","gists_url":"https://api.github.com/users/drublic/gists{/gist_id}","starred_url":"https://api.github.com/users/drublic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drublic/subscriptions","organizations_url":"https://api.github.com/users/drublic/orgs","repos_url":"https://api.github.com/users/drublic/repos","events_url":"https://api.github.com/users/drublic/events{/privacy}","received_events_url":"https://api.github.com/users/drublic/received_events","type":"User","site_admin":false},"body":"This commit removes Bean from CSS Modal's IE8 dependency list and\r\nintroduces jQuery as this dependency for CustomEvents.\r\nCustomEventus can be mocked in IE8 with some difficulties - this should\r\nnot be the problem of us as implementors though which is why we use a\r\nlibrary for correct behavior. In the past we've used bean as a\r\nlightwight solution.\r\n\r\nNearly all webprojects these days require jQuery for their JavaScript\r\nwhich is why I think jQuery is more robust and easier to use for most\r\ndevelopers.\r\nYou get full (JS) IE8 compatibility by simply including jQuery into your\r\nproject.","created_at":"2014-11-18T19:03:24Z","updated_at":"2014-11-18T19:03:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/drublic/css-modal/pulls/167/commits","review_comments_url":"https://api.github.com/repos/drublic/css-modal/pulls/167/comments","review_comment_url":"https://api.github.com/repos/drublic/css-modal/pulls/comments/{number}","comments_url":"https://api.github.com/repos/drublic/css-modal/issues/167/comments","statuses_url":"https://api.github.com/repos/drublic/css-modal/statuses/dd45c3a3c03ddf6a192c29b57968479448bd885b","head":{"label":"drublic:jquery-insteadof-bean","ref":"jquery-insteadof-bean","sha":"dd45c3a3c03ddf6a192c29b57968479448bd885b","user":{"login":"drublic","id":502487,"avatar_url":"https://avatars.githubusercontent.com/u/502487?v=3","gravatar_id":"","url":"https://api.github.com/users/drublic","html_url":"https://github.com/drublic","followers_url":"https://api.github.com/users/drublic/followers","following_url":"https://api.github.com/users/drublic/following{/other_user}","gists_url":"https://api.github.com/users/drublic/gists{/gist_id}","starred_url":"https://api.github.com/users/drublic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drublic/subscriptions","organizations_url":"https://api.github.com/users/drublic/orgs","repos_url":"https://api.github.com/users/drublic/repos","events_url":"https://api.github.com/users/drublic/events{/privacy}","received_events_url":"https://api.github.com/users/drublic/received_events","type":"User","site_admin":false},"repo":{"id":6820011,"name":"css-modal","full_name":"drublic/css-modal","owner":{"login":"drublic","id":502487,"avatar_url":"https://avatars.githubusercontent.com/u/502487?v=3","gravatar_id":"","url":"https://api.github.com/users/drublic","html_url":"https://github.com/drublic","followers_url":"https://api.github.com/users/drublic/followers","following_url":"https://api.github.com/users/drublic/following{/other_user}","gists_url":"https://api.github.com/users/drublic/gists{/gist_id}","starred_url":"https://api.github.com/users/drublic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drublic/subscriptions","organizations_url":"https://api.github.com/users/drublic/orgs","repos_url":"https://api.github.com/users/drublic/repos","events_url":"https://api.github.com/users/drublic/events{/privacy}","received_events_url":"https://api.github.com/users/drublic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/drublic/css-modal","description":"A modal built out of pure CSS","fork":false,"url":"https://api.github.com/repos/drublic/css-modal","forks_url":"https://api.github.com/repos/drublic/css-modal/forks","keys_url":"https://api.github.com/repos/drublic/css-modal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/drublic/css-modal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/drublic/css-modal/teams","hooks_url":"https://api.github.com/repos/drublic/css-modal/hooks","issue_events_url":"https://api.github.com/repos/drublic/css-modal/issues/events{/number}","events_url":"https://api.github.com/repos/drublic/css-modal/events","assignees_url":"https://api.github.com/repos/drublic/css-modal/assignees{/user}","branches_url":"https://api.github.com/repos/drublic/css-modal/branches{/branch}","tags_url":"https://api.github.com/repos/drublic/css-modal/tags","blobs_url":"https://api.github.com/repos/drublic/css-modal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/drublic/css-modal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/drublic/css-modal/git/refs{/sha}","trees_url":"https://api.github.com/repos/drublic/css-modal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/drublic/css-modal/statuses/{sha}","languages_url":"https://api.github.com/repos/drublic/css-modal/languages","stargazers_url":"https://api.github.com/repos/drublic/css-modal/stargazers","contributors_url":"https://api.github.com/repos/drublic/css-modal/contributors","subscribers_url":"https://api.github.com/repos/drublic/css-modal/subscribers","subscription_url":"https://api.github.com/repos/drublic/css-modal/subscription","commits_url":"https://api.github.com/repos/drublic/css-modal/commits{/sha}","git_commits_url":"https://api.github.com/repos/drublic/css-modal/git/commits{/sha}","comments_url":"https://api.github.com/repos/drublic/css-modal/comments{/number}","issue_comment_url":"https://api.github.com/repos/drublic/css-modal/issues/comments/{number}","contents_url":"https://api.github.com/repos/drublic/css-modal/contents/{+path}","compare_url":"https://api.github.com/repos/drublic/css-modal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/drublic/css-modal/merges","archive_url":"https://api.github.com/repos/drublic/css-modal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/drublic/css-modal/downloads","issues_url":"https://api.github.com/repos/drublic/css-modal/issues{/number}","pulls_url":"https://api.github.com/repos/drublic/css-modal/pulls{/number}","milestones_url":"https://api.github.com/repos/drublic/css-modal/milestones{/number}","notifications_url":"https://api.github.com/repos/drublic/css-modal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/drublic/css-modal/labels{/name}","releases_url":"https://api.github.com/repos/drublic/css-modal/releases{/id}","created_at":"2012-11-22T23:09:26Z","updated_at":"2014-11-18T18:14:28Z","pushed_at":"2014-11-18T18:49:57Z","git_url":"git://github.com/drublic/css-modal.git","ssh_url":"git@github.com:drublic/css-modal.git","clone_url":"https://github.com/drublic/css-modal.git","svn_url":"https://github.com/drublic/css-modal","homepage":"drublic.github.io/css-modal","size":5087,"stargazers_count":1286,"watchers_count":1286,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":202,"mirror_url":null,"open_issues_count":14,"forks":202,"open_issues":14,"watchers":1286,"default_branch":"master"}},"base":{"label":"drublic:master","ref":"master","sha":"1f2a96e397f86708a4d6eb05a8edfd54d05d3a20","user":{"login":"drublic","id":502487,"avatar_url":"https://avatars.githubusercontent.com/u/502487?v=3","gravatar_id":"","url":"https://api.github.com/users/drublic","html_url":"https://github.com/drublic","followers_url":"https://api.github.com/users/drublic/followers","following_url":"https://api.github.com/users/drublic/following{/other_user}","gists_url":"https://api.github.com/users/drublic/gists{/gist_id}","starred_url":"https://api.github.com/users/drublic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drublic/subscriptions","organizations_url":"https://api.github.com/users/drublic/orgs","repos_url":"https://api.github.com/users/drublic/repos","events_url":"https://api.github.com/users/drublic/events{/privacy}","received_events_url":"https://api.github.com/users/drublic/received_events","type":"User","site_admin":false},"repo":{"id":6820011,"name":"css-modal","full_name":"drublic/css-modal","owner":{"login":"drublic","id":502487,"avatar_url":"https://avatars.githubusercontent.com/u/502487?v=3","gravatar_id":"","url":"https://api.github.com/users/drublic","html_url":"https://github.com/drublic","followers_url":"https://api.github.com/users/drublic/followers","following_url":"https://api.github.com/users/drublic/following{/other_user}","gists_url":"https://api.github.com/users/drublic/gists{/gist_id}","starred_url":"https://api.github.com/users/drublic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drublic/subscriptions","organizations_url":"https://api.github.com/users/drublic/orgs","repos_url":"https://api.github.com/users/drublic/repos","events_url":"https://api.github.com/users/drublic/events{/privacy}","received_events_url":"https://api.github.com/users/drublic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/drublic/css-modal","description":"A modal built out of pure CSS","fork":false,"url":"https://api.github.com/repos/drublic/css-modal","forks_url":"https://api.github.com/repos/drublic/css-modal/forks","keys_url":"https://api.github.com/repos/drublic/css-modal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/drublic/css-modal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/drublic/css-modal/teams","hooks_url":"https://api.github.com/repos/drublic/css-modal/hooks","issue_events_url":"https://api.github.com/repos/drublic/css-modal/issues/events{/number}","events_url":"https://api.github.com/repos/drublic/css-modal/events","assignees_url":"https://api.github.com/repos/drublic/css-modal/assignees{/user}","branches_url":"https://api.github.com/repos/drublic/css-modal/branches{/branch}","tags_url":"https://api.github.com/repos/drublic/css-modal/tags","blobs_url":"https://api.github.com/repos/drublic/css-modal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/drublic/css-modal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/drublic/css-modal/git/refs{/sha}","trees_url":"https://api.github.com/repos/drublic/css-modal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/drublic/css-modal/statuses/{sha}","languages_url":"https://api.github.com/repos/drublic/css-modal/languages","stargazers_url":"https://api.github.com/repos/drublic/css-modal/stargazers","contributors_url":"https://api.github.com/repos/drublic/css-modal/contributors","subscribers_url":"https://api.github.com/repos/drublic/css-modal/subscribers","subscription_url":"https://api.github.com/repos/drublic/css-modal/subscription","commits_url":"https://api.github.com/repos/drublic/css-modal/commits{/sha}","git_commits_url":"https://api.github.com/repos/drublic/css-modal/git/commits{/sha}","comments_url":"https://api.github.com/repos/drublic/css-modal/comments{/number}","issue_comment_url":"https://api.github.com/repos/drublic/css-modal/issues/comments/{number}","contents_url":"https://api.github.com/repos/drublic/css-modal/contents/{+path}","compare_url":"https://api.github.com/repos/drublic/css-modal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/drublic/css-modal/merges","archive_url":"https://api.github.com/repos/drublic/css-modal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/drublic/css-modal/downloads","issues_url":"https://api.github.com/repos/drublic/css-modal/issues{/number}","pulls_url":"https://api.github.com/repos/drublic/css-modal/pulls{/number}","milestones_url":"https://api.github.com/repos/drublic/css-modal/milestones{/number}","notifications_url":"https://api.github.com/repos/drublic/css-modal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/drublic/css-modal/labels{/name}","releases_url":"https://api.github.com/repos/drublic/css-modal/releases{/id}","created_at":"2012-11-22T23:09:26Z","updated_at":"2014-11-18T18:14:28Z","pushed_at":"2014-11-18T18:49:57Z","git_url":"git://github.com/drublic/css-modal.git","ssh_url":"git@github.com:drublic/css-modal.git","clone_url":"https://github.com/drublic/css-modal.git","svn_url":"https://github.com/drublic/css-modal","homepage":"drublic.github.io/css-modal","size":5087,"stargazers_count":1286,"watchers_count":1286,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":202,"mirror_url":null,"open_issues_count":14,"forks":202,"open_issues":14,"watchers":1286,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/drublic/css-modal/pulls/167"},"html":{"href":"https://github.com/drublic/css-modal/pull/167"},"issue":{"href":"https://api.github.com/repos/drublic/css-modal/issues/167"},"comments":{"href":"https://api.github.com/repos/drublic/css-modal/issues/167/comments"},"review_comments":{"href":"https://api.github.com/repos/drublic/css-modal/pulls/167/comments"},"review_comment":{"href":"https://api.github.com/repos/drublic/css-modal/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/drublic/css-modal/pulls/167/commits"},"statuses":{"href":"https://api.github.com/repos/drublic/css-modal/statuses/dd45c3a3c03ddf6a192c29b57968479448bd885b"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":43,"deletions":27,"changed_files":7}}