GitHub PullRequestReviewCommentEvent at 2014-10-27 17:10:03
Repository: PayPal-Cordova-Plugin
Actor: miche-atucha
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/paypal/PayPal-Cordova-Plugin/pulls/comments/19419677","id":19419677,"diff_hunk":"@@ -23,13 +23,18 @@ function PayPalPaymentDetails(subtotal, shipping, tax) {\n  * @param {String} intent: Sale for an immediate payment or Auth\n  *                 for payment authorization only, to be captured separately at a later time.\n  * @param {PayPalPaymentDetails} details: PayPalPaymentDetails object (optional)\n+ * @param {object} extra: Other properties for the payment, currently only invoiceNumber is implemented (optional)","path":"www/paypal-mobile-js-helper.js","position":4,"original_position":4,"commit_id":"9b798f85db73d2c52a397c32ac9f76097c396dfc","original_commit_id":"84a678807a1977a6e581135ca74a937fbc25932e","user":{"login":"miche-atucha","id":6463472,"avatar_url":"https://avatars.githubusercontent.com/u/6463472?v=2","gravatar_id":"","url":"https://api.github.com/users/miche-atucha","html_url":"https://github.com/miche-atucha","followers_url":"https://api.github.com/users/miche-atucha/followers","following_url":"https://api.github.com/users/miche-atucha/following{/other_user}","gists_url":"https://api.github.com/users/miche-atucha/gists{/gist_id}","starred_url":"https://api.github.com/users/miche-atucha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miche-atucha/subscriptions","organizations_url":"https://api.github.com/users/miche-atucha/orgs","repos_url":"https://api.github.com/users/miche-atucha/repos","events_url":"https://api.github.com/users/miche-atucha/events{/privacy}","received_events_url":"https://api.github.com/users/miche-atucha/received_events","type":"User","site_admin":false},"body":"well, what do you think of put invoiceNumber as a method in \nPayPalPayment, so it´s corresponde to the native implementations?\n\nOn 27/10/14 12:08 pm, Roman wrote:\n>\n> In www/paypal-mobile-js-helper.js:\n>\n> > @@ -23,13 +23,18 @@ function PayPalPaymentDetails(subtotal, shipping, tax) {\n> >   * @param {String} intent: Sale for an immediate payment or Auth\n> >   *                 for payment authorization only, to be captured separately at a later time.\n> >   * @param {PayPalPaymentDetails} details: PayPalPaymentDetails object (optional)\n> > + * @param {object} extra: Other properties for the payment, currently only invoiceNumber is implemented (optional)\n>\n> it doesn't correspond to the implementation in .java and .m classes. \n> Anyone will try to use it that way will get a crash. Also, custom and \n> invoiceNumber are two different things. The comment is misleading \n> since PayPalPaymentDetails is optional as well and also property of \n> the payment.\n>\n> —\n> Reply to this email directly or view it on GitHub \n> <https://github.com/paypal/PayPal-Cordova-Plugin/pull/32/files#r19419542>.\n>","created_at":"2014-10-27T17:10:03Z","updated_at":"2014-10-27T17:10:03Z","html_url":"https://github.com/paypal/PayPal-Cordova-Plugin/pull/32#discussion_r19419677","pull_request_url":"https://api.github.com/repos/paypal/PayPal-Cordova-Plugin/pulls/32","_links":{"self":{"href":"https://api.github.com/repos/paypal/PayPal-Cordova-Plugin/pulls/comments/19419677"},"html":{"href":"https://github.com/paypal/PayPal-Cordova-Plugin/pull/32#discussion_r19419677"},"pull_request":{"href":"https://api.github.com/repos/paypal/PayPal-Cordova-Plugin/pulls/32"}}},"pull_request":{"url":"https://api.github.com/repos/paypal/PayPal-Cordova-Plugin/pulls/32","id":23201355,"html_url":"https://github.com/paypal/PayPal-Cordova-Plugin/pull/32","diff_url":"https://github.com/paypal/PayPal-Cordova-Plugin/pull/32.diff","patch_url":"https://github.com/paypal/PayPal-Cordova-Plugin/pull/32.patch","issue_url":"https://api.github.com/repos/paypal/PayPal-Cordova-Plugin/issues/32","number":32,"state":"open","locked":false,"title":"Adding option to include invoiceNumber in PayPalPayment.","user":{"login":"miche-atucha","id":6463472,"avatar_url":"https://avatars.githubusercontent.com/u/6463472?v=2","gravatar_id":"","url":"https://api.github.com/users/miche-atucha","html_url":"https://github.com/miche-atucha","followers_url":"https://api.github.com/users/miche-atucha/followers","following_url":"https://api.github.com/users/miche-atucha/following{/other_user}","gists_url":"https://api.github.com/users/miche-atucha/gists{/gist_id}","starred_url":"https://api.github.com/users/miche-atucha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miche-atucha/subscriptions","organizations_url":"https://api.github.com/users/miche-atucha/orgs","repos_url":"https://api.github.com/users/miche-atucha/repos","events_url":"https://api.github.com/users/miche-atucha/events{/privacy}","received_events_url":"https://api.github.com/users/miche-atucha/received_events","type":"User","site_admin":false},"body":"I need set the invoiceNumber in my project to associate Paypal payments with my own payment records that i need to create before launch the singlePaymentUI.","created_at":"2014-10-23T01:12:10Z","updated_at":"2014-10-27T17:10:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dc2fc6beefa6a48fc93be9e8a35f1380d30cfa31","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/paypal/PayPal-Cordova-Plugin/pulls/32/commits","review_comments_url":"https://api.github.com/repos/paypal/PayPal-Cordova-Plugin/pulls/32/comments","review_comment_url":"https://api.github.com/repos/paypal/PayPal-Cordova-Plugin/pulls/comments/{number}","comments_url":"https://api.github.com/repos/paypal/PayPal-Cordova-Plugin/issues/32/comments","statuses_url":"https://api.github.com/repos/paypal/PayPal-Cordova-Plugin/statuses/9b798f85db73d2c52a397c32ac9f76097c396dfc","head":{"label":"miche-atucha:master","ref":"master","sha":"9b798f85db73d2c52a397c32ac9f76097c396dfc","user":{"login":"miche-atucha","id":6463472,"avatar_url":"https://avatars.githubusercontent.com/u/6463472?v=2","gravatar_id":"","url":"https://api.github.com/users/miche-atucha","html_url":"https://github.com/miche-atucha","followers_url":"https://api.github.com/users/miche-atucha/followers","following_url":"https://api.github.com/users/miche-atucha/following{/other_user}","gists_url":"https://api.github.com/users/miche-atucha/gists{/gist_id}","starred_url":"https://api.github.com/users/miche-atucha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miche-atucha/subscriptions","organizations_url":"https://api.github.com/users/miche-atucha/orgs","repos_url":"https://api.github.com/users/miche-atucha/repos","events_url":"https://api.github.com/users/miche-atucha/events{/privacy}","received_events_url":"https://api.github.com/users/miche-atucha/received_events","type":"User","site_admin":false},"repo":{"id":25612359,"name":"PayPal-Cordova-Plugin","full_name":"miche-atucha/PayPal-Cordova-Plugin","owner":{"login":"miche-atucha","id":6463472,"avatar_url":"https://avatars.githubusercontent.com/u/6463472?v=2","gravatar_id":"","url":"https://api.github.com/users/miche-atucha","html_url":"https://github.com/miche-atucha","followers_url":"https://api.github.com/users/miche-atucha/followers","following_url":"https://api.github.com/users/miche-atucha/following{/other_user}","gists_url":"https://api.github.com/users/miche-atucha/gists{/gist_id}","starred_url":"https://api.github.com/users/miche-atucha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miche-atucha/subscriptions","organizations_url":"https://api.github.com/users/miche-atucha/orgs","repos_url":"https://api.github.com/users/miche-atucha/repos","events_url":"https://api.github.com/users/miche-atucha/events{/privacy}","received_events_url":"https://api.github.com/users/miche-atucha/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/miche-atucha/PayPal-Cordova-Plugin","description":"PayPal SDK Cordova/Phonegap Plugin","fork":true,"url":"https://api.github.com/repos/miche-atucha/PayPal-Cordova-Plugin","forks_url":"https://api.github.com/repos/miche-atucha/PayPal-Cordova-Plugin/forks","keys_url":"https://api.github.com/repos/miche-atucha/PayPal-Cordova-Plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/miche-atucha/PayPal-Cordova-Plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/miche-atucha/PayPal-Cordova-Plugin/teams","hooks_url":"https://api.github.com/repos/miche-atucha/PayPal-Cordova-Plugin/hooks","issue_events_url":"https://api.github.com/repos/miche-atucha/PayPal-Cordova-Plugin/issues/events{/number}","events_url":"https://api.github.com/repos/miche-atucha/PayPal-Cordova-Plugin/events","assignees_url":"https://api.github.com/repos/miche-atucha/PayPal-Cordova-Plugin/assignees{/user}","branches_url":"https://api.github.com/repos/miche-atucha/PayPal-Cordova-Plugin/branches{/branch}","tags_url":"https://api.github.com/repos/miche-atucha/PayPal-Cordova-Plugin/tags","blobs_url":"https://api.github.com/repos/miche-atucha/PayPal-Cordova-Plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/miche-atucha/PayPal-Cordova-Plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/miche-atucha/PayPal-Cordova-Plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/miche-atucha/PayPal-Cordova-Plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/miche-atucha/PayPal-Cordova-Plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/miche-atucha/PayPal-Cordova-Plugin/languages","stargazers_url":"https://api.github.com/repos/miche-atucha/PayPal-Cordova-Plugin/stargazers","contributors_url":"https://api.github.com/repos/miche-atucha/PayPal-Cordova-Plugin/contributors","subscribers_url":"https://api.github.com/repos/miche-atucha/PayPal-Cordova-Plugin/subscribers","subscription_url":"https://api.github.com/repos/miche-atucha/PayPal-Cordova-Plugin/subscription","commits_url":"https://api.github.com/repos/miche-atucha/PayPal-Cordova-Plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/miche-atucha/PayPal-Cordova-Plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/miche-atucha/PayPal-Cordova-Plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/miche-atucha/PayPal-Cordova-Plugin/issues/comments/{number}","contents_url":"https://api.github.com/repos/miche-atucha/PayPal-Cordova-Plugin/contents/{+path}","compare_url":"https://api.github.com/repos/miche-atucha/PayPal-Cordova-Plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/miche-atucha/PayPal-Cordova-Plugin/merges","archive_url":"https://api.github.com/repos/miche-atucha/PayPal-Cordova-Plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/miche-atucha/PayPal-Cordova-Plugin/downloads","issues_url":"https://api.github.com/repos/miche-atucha/PayPal-Cordova-Plugin/issues{/number}","pulls_url":"https://api.github.com/repos/miche-atucha/PayPal-Cordova-Plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/miche-atucha/PayPal-Cordova-Plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/miche-atucha/PayPal-Cordova-Plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/miche-atucha/PayPal-Cordova-Plugin/labels{/name}","releases_url":"https://api.github.com/repos/miche-atucha/PayPal-Cordova-Plugin/releases{/id}","created_at":"2014-10-23T01:07:23Z","updated_at":"2014-10-23T01:09:22Z","pushed_at":"2014-10-27T16:53:24Z","git_url":"git://github.com/miche-atucha/PayPal-Cordova-Plugin.git","ssh_url":"git@github.com:miche-atucha/PayPal-Cordova-Plugin.git","clone_url":"https://github.com/miche-atucha/PayPal-Cordova-Plugin.git","svn_url":"https://github.com/miche-atucha/PayPal-Cordova-Plugin","homepage":null,"size":109,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"paypal:master","ref":"master","sha":"eed8ef98ae5b66aae721ea1f7c1f058d3730c777","user":{"login":"paypal","id":476675,"avatar_url":"https://avatars.githubusercontent.com/u/476675?v=2","gravatar_id":"","url":"https://api.github.com/users/paypal","html_url":"https://github.com/paypal","followers_url":"https://api.github.com/users/paypal/followers","following_url":"https://api.github.com/users/paypal/following{/other_user}","gists_url":"https://api.github.com/users/paypal/gists{/gist_id}","starred_url":"https://api.github.com/users/paypal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paypal/subscriptions","organizations_url":"https://api.github.com/users/paypal/orgs","repos_url":"https://api.github.com/users/paypal/repos","events_url":"https://api.github.com/users/paypal/events{/privacy}","received_events_url":"https://api.github.com/users/paypal/received_events","type":"Organization","site_admin":false},"repo":{"id":17648032,"name":"PayPal-Cordova-Plugin","full_name":"paypal/PayPal-Cordova-Plugin","owner":{"login":"paypal","id":476675,"avatar_url":"https://avatars.githubusercontent.com/u/476675?v=2","gravatar_id":"","url":"https://api.github.com/users/paypal","html_url":"https://github.com/paypal","followers_url":"https://api.github.com/users/paypal/followers","following_url":"https://api.github.com/users/paypal/following{/other_user}","gists_url":"https://api.github.com/users/paypal/gists{/gist_id}","starred_url":"https://api.github.com/users/paypal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paypal/subscriptions","organizations_url":"https://api.github.com/users/paypal/orgs","repos_url":"https://api.github.com/users/paypal/repos","events_url":"https://api.github.com/users/paypal/events{/privacy}","received_events_url":"https://api.github.com/users/paypal/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/paypal/PayPal-Cordova-Plugin","description":"PayPal SDK Cordova/Phonegap Plugin","fork":false,"url":"https://api.github.com/repos/paypal/PayPal-Cordova-Plugin","forks_url":"https://api.github.com/repos/paypal/PayPal-Cordova-Plugin/forks","keys_url":"https://api.github.com/repos/paypal/PayPal-Cordova-Plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paypal/PayPal-Cordova-Plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paypal/PayPal-Cordova-Plugin/teams","hooks_url":"https://api.github.com/repos/paypal/PayPal-Cordova-Plugin/hooks","issue_events_url":"https://api.github.com/repos/paypal/PayPal-Cordova-Plugin/issues/events{/number}","events_url":"https://api.github.com/repos/paypal/PayPal-Cordova-Plugin/events","assignees_url":"https://api.github.com/repos/paypal/PayPal-Cordova-Plugin/assignees{/user}","branches_url":"https://api.github.com/repos/paypal/PayPal-Cordova-Plugin/branches{/branch}","tags_url":"https://api.github.com/repos/paypal/PayPal-Cordova-Plugin/tags","blobs_url":"https://api.github.com/repos/paypal/PayPal-Cordova-Plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paypal/PayPal-Cordova-Plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paypal/PayPal-Cordova-Plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/paypal/PayPal-Cordova-Plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paypal/PayPal-Cordova-Plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/paypal/PayPal-Cordova-Plugin/languages","stargazers_url":"https://api.github.com/repos/paypal/PayPal-Cordova-Plugin/stargazers","contributors_url":"https://api.github.com/repos/paypal/PayPal-Cordova-Plugin/contributors","subscribers_url":"https://api.github.com/repos/paypal/PayPal-Cordova-Plugin/subscribers","subscription_url":"https://api.github.com/repos/paypal/PayPal-Cordova-Plugin/subscription","commits_url":"https://api.github.com/repos/paypal/PayPal-Cordova-Plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/paypal/PayPal-Cordova-Plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/paypal/PayPal-Cordova-Plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/paypal/PayPal-Cordova-Plugin/issues/comments/{number}","contents_url":"https://api.github.com/repos/paypal/PayPal-Cordova-Plugin/contents/{+path}","compare_url":"https://api.github.com/repos/paypal/PayPal-Cordova-Plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paypal/PayPal-Cordova-Plugin/merges","archive_url":"https://api.github.com/repos/paypal/PayPal-Cordova-Plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paypal/PayPal-Cordova-Plugin/downloads","issues_url":"https://api.github.com/repos/paypal/PayPal-Cordova-Plugin/issues{/number}","pulls_url":"https://api.github.com/repos/paypal/PayPal-Cordova-Plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/paypal/PayPal-Cordova-Plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/paypal/PayPal-Cordova-Plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paypal/PayPal-Cordova-Plugin/labels{/name}","releases_url":"https://api.github.com/repos/paypal/PayPal-Cordova-Plugin/releases{/id}","created_at":"2014-03-11T22:47:35Z","updated_at":"2014-10-19T16:27:44Z","pushed_at":"2014-10-13T20:41:33Z","git_url":"git://github.com/paypal/PayPal-Cordova-Plugin.git","ssh_url":"git@github.com:paypal/PayPal-Cordova-Plugin.git","clone_url":"https://github.com/paypal/PayPal-Cordova-Plugin.git","svn_url":"https://github.com/paypal/PayPal-Cordova-Plugin","homepage":null,"size":278,"stargazers_count":29,"watchers_count":29,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":7,"forks":20,"open_issues":7,"watchers":29,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/paypal/PayPal-Cordova-Plugin/pulls/32"},"html":{"href":"https://github.com/paypal/PayPal-Cordova-Plugin/pull/32"},"issue":{"href":"https://api.github.com/repos/paypal/PayPal-Cordova-Plugin/issues/32"},"comments":{"href":"https://api.github.com/repos/paypal/PayPal-Cordova-Plugin/issues/32/comments"},"review_comments":{"href":"https://api.github.com/repos/paypal/PayPal-Cordova-Plugin/pulls/32/comments"},"review_comment":{"href":"https://api.github.com/repos/paypal/PayPal-Cordova-Plugin/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/paypal/PayPal-Cordova-Plugin/pulls/32/commits"},"statuses":{"href":"https://api.github.com/repos/paypal/PayPal-Cordova-Plugin/statuses/9b798f85db73d2c52a397c32ac9f76097c396dfc"}}}}