GitHub PullRequestReviewCommentEvent at 2014-08-01 21:54:50
Repository: jsdom
Actor: domenic
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/tmpvar/jsdom/pulls/comments/15721152","id":15721152,"diff_hunk":"@@ -242,9 +242,7 @@ exports.createWindow = function(dom, options) {\n           var url = URL.parse(lastUrl);\n           var host = url.host.split(':')[0];\n           if (host.indexOf(cookieDomain, host.length - cookieDomain.length) !== -1) {\n-            xhr.setDisableHeaderCheck(true);\n             xhr.setRequestHeader('cookie', window.document.cookie);","path":"lib/jsdom/browser/index.js","position":14,"original_position":14,"commit_id":"68b0df2b5b1aeb5b2ba24b09d48974bd4800e5b1","original_commit_id":"68b0df2b5b1aeb5b2ba24b09d48974bd4800e5b1","user":{"login":"domenic","id":617481,"avatar_url":"https://avatars.githubusercontent.com/u/617481?v=1","gravatar_id":"c6d819207a3010b39d13e1f59f2c0029","url":"https://api.github.com/users/domenic","html_url":"https://github.com/domenic","followers_url":"https://api.github.com/users/domenic/followers","following_url":"https://api.github.com/users/domenic/following{/other_user}","gists_url":"https://api.github.com/users/domenic/gists{/gist_id}","starred_url":"https://api.github.com/users/domenic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/domenic/subscriptions","organizations_url":"https://api.github.com/users/domenic/orgs","repos_url":"https://api.github.com/users/domenic/repos","events_url":"https://api.github.com/users/domenic/events{/privacy}","received_events_url":"https://api.github.com/users/domenic/received_events","type":"User","site_admin":false},"body":"I think allowing people to write code that works in jsdom but not in the browser is bad. It'd be nicer if setDisableHeaderCheck was _setDisableHeaderCheck though, for our purposes at least.","created_at":"2014-08-01T21:54:50Z","updated_at":"2014-08-01T21:54:50Z","html_url":"https://github.com/tmpvar/jsdom/pull/847#discussion_r15721152","pull_request_url":"https://api.github.com/repos/tmpvar/jsdom/pulls/847","_links":{"self":{"href":"https://api.github.com/repos/tmpvar/jsdom/pulls/comments/15721152"},"html":{"href":"https://github.com/tmpvar/jsdom/pull/847#discussion_r15721152"},"pull_request":{"href":"https://api.github.com/repos/tmpvar/jsdom/pulls/847"}}},"pull_request":{"url":"https://api.github.com/repos/tmpvar/jsdom/pulls/847","id":19234716,"html_url":"https://github.com/tmpvar/jsdom/pull/847","diff_url":"https://github.com/tmpvar/jsdom/pull/847.diff","patch_url":"https://github.com/tmpvar/jsdom/pull/847.patch","issue_url":"https://api.github.com/repos/tmpvar/jsdom/issues/847","number":847,"state":"open","title":"Switch to w3c-xmlhttprequest","user":{"login":"kapouer","id":131406,"avatar_url":"https://avatars.githubusercontent.com/u/131406?v=1","gravatar_id":"1a211d6ec19ccd9c41819fc05fdc41ab","url":"https://api.github.com/users/kapouer","html_url":"https://github.com/kapouer","followers_url":"https://api.github.com/users/kapouer/followers","following_url":"https://api.github.com/users/kapouer/following{/other_user}","gists_url":"https://api.github.com/users/kapouer/gists{/gist_id}","starred_url":"https://api.github.com/users/kapouer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kapouer/subscriptions","organizations_url":"https://api.github.com/users/kapouer/orgs","repos_url":"https://api.github.com/users/kapouer/repos","events_url":"https://api.github.com/users/kapouer/events{/privacy}","received_events_url":"https://api.github.com/users/kapouer/received_events","type":"User","site_admin":false},"body":"Closes #790.\r\nBrings several improvements over legacy node-xmlhttprequest, like\r\nsupport for \"responseType\" and \"response\" properties (allowing binary xhr requests through 'arraybuffer' responseType, see spec); better event support, xhr streaming, and room for improvement (code is quite well structured).","created_at":"2014-08-01T21:21:31Z","updated_at":"2014-08-01T21:54:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0ee4f33ab6e4da9c2366e65ca4bf00d9303eb58a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/tmpvar/jsdom/pulls/847/commits","review_comments_url":"https://api.github.com/repos/tmpvar/jsdom/pulls/847/comments","review_comment_url":"https://api.github.com/repos/tmpvar/jsdom/pulls/comments/{number}","comments_url":"https://api.github.com/repos/tmpvar/jsdom/issues/847/comments","statuses_url":"https://api.github.com/repos/tmpvar/jsdom/statuses/68b0df2b5b1aeb5b2ba24b09d48974bd4800e5b1","head":{"label":"kapouer:master","ref":"master","sha":"68b0df2b5b1aeb5b2ba24b09d48974bd4800e5b1","user":{"login":"kapouer","id":131406,"avatar_url":"https://avatars.githubusercontent.com/u/131406?v=1","gravatar_id":"1a211d6ec19ccd9c41819fc05fdc41ab","url":"https://api.github.com/users/kapouer","html_url":"https://github.com/kapouer","followers_url":"https://api.github.com/users/kapouer/followers","following_url":"https://api.github.com/users/kapouer/following{/other_user}","gists_url":"https://api.github.com/users/kapouer/gists{/gist_id}","starred_url":"https://api.github.com/users/kapouer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kapouer/subscriptions","organizations_url":"https://api.github.com/users/kapouer/orgs","repos_url":"https://api.github.com/users/kapouer/repos","events_url":"https://api.github.com/users/kapouer/events{/privacy}","received_events_url":"https://api.github.com/users/kapouer/received_events","type":"User","site_admin":false},"repo":{"id":10104000,"name":"jsdom","full_name":"kapouer/jsdom","owner":{"login":"kapouer","id":131406,"avatar_url":"https://avatars.githubusercontent.com/u/131406?v=1","gravatar_id":"1a211d6ec19ccd9c41819fc05fdc41ab","url":"https://api.github.com/users/kapouer","html_url":"https://github.com/kapouer","followers_url":"https://api.github.com/users/kapouer/followers","following_url":"https://api.github.com/users/kapouer/following{/other_user}","gists_url":"https://api.github.com/users/kapouer/gists{/gist_id}","starred_url":"https://api.github.com/users/kapouer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kapouer/subscriptions","organizations_url":"https://api.github.com/users/kapouer/orgs","repos_url":"https://api.github.com/users/kapouer/repos","events_url":"https://api.github.com/users/kapouer/events{/privacy}","received_events_url":"https://api.github.com/users/kapouer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kapouer/jsdom","description":"A javascript implementation of the DOM, for use with node.js.","fork":true,"url":"https://api.github.com/repos/kapouer/jsdom","forks_url":"https://api.github.com/repos/kapouer/jsdom/forks","keys_url":"https://api.github.com/repos/kapouer/jsdom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kapouer/jsdom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kapouer/jsdom/teams","hooks_url":"https://api.github.com/repos/kapouer/jsdom/hooks","issue_events_url":"https://api.github.com/repos/kapouer/jsdom/issues/events{/number}","events_url":"https://api.github.com/repos/kapouer/jsdom/events","assignees_url":"https://api.github.com/repos/kapouer/jsdom/assignees{/user}","branches_url":"https://api.github.com/repos/kapouer/jsdom/branches{/branch}","tags_url":"https://api.github.com/repos/kapouer/jsdom/tags","blobs_url":"https://api.github.com/repos/kapouer/jsdom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kapouer/jsdom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kapouer/jsdom/git/refs{/sha}","trees_url":"https://api.github.com/repos/kapouer/jsdom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kapouer/jsdom/statuses/{sha}","languages_url":"https://api.github.com/repos/kapouer/jsdom/languages","stargazers_url":"https://api.github.com/repos/kapouer/jsdom/stargazers","contributors_url":"https://api.github.com/repos/kapouer/jsdom/contributors","subscribers_url":"https://api.github.com/repos/kapouer/jsdom/subscribers","subscription_url":"https://api.github.com/repos/kapouer/jsdom/subscription","commits_url":"https://api.github.com/repos/kapouer/jsdom/commits{/sha}","git_commits_url":"https://api.github.com/repos/kapouer/jsdom/git/commits{/sha}","comments_url":"https://api.github.com/repos/kapouer/jsdom/comments{/number}","issue_comment_url":"https://api.github.com/repos/kapouer/jsdom/issues/comments/{number}","contents_url":"https://api.github.com/repos/kapouer/jsdom/contents/{+path}","compare_url":"https://api.github.com/repos/kapouer/jsdom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kapouer/jsdom/merges","archive_url":"https://api.github.com/repos/kapouer/jsdom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kapouer/jsdom/downloads","issues_url":"https://api.github.com/repos/kapouer/jsdom/issues{/number}","pulls_url":"https://api.github.com/repos/kapouer/jsdom/pulls{/number}","milestones_url":"https://api.github.com/repos/kapouer/jsdom/milestones{/number}","notifications_url":"https://api.github.com/repos/kapouer/jsdom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kapouer/jsdom/labels{/name}","releases_url":"https://api.github.com/repos/kapouer/jsdom/releases{/id}","created_at":"2013-05-16T15:15:02Z","updated_at":"2014-08-01T00:08:29Z","pushed_at":"2014-08-01T00:08:29Z","git_url":"git://github.com/kapouer/jsdom.git","ssh_url":"git@github.com:kapouer/jsdom.git","clone_url":"https://github.com/kapouer/jsdom.git","svn_url":"https://github.com/kapouer/jsdom","homepage":"","size":6511,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tmpvar:master","ref":"master","sha":"204aabc7b0cbc4e69199586bd2e2b07c2d5bb622","user":{"login":"tmpvar","id":46673,"avatar_url":"https://avatars.githubusercontent.com/u/46673?v=1","gravatar_id":"2893bc1693002e652210b3705f74b5dd","url":"https://api.github.com/users/tmpvar","html_url":"https://github.com/tmpvar","followers_url":"https://api.github.com/users/tmpvar/followers","following_url":"https://api.github.com/users/tmpvar/following{/other_user}","gists_url":"https://api.github.com/users/tmpvar/gists{/gist_id}","starred_url":"https://api.github.com/users/tmpvar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmpvar/subscriptions","organizations_url":"https://api.github.com/users/tmpvar/orgs","repos_url":"https://api.github.com/users/tmpvar/repos","events_url":"https://api.github.com/users/tmpvar/events{/privacy}","received_events_url":"https://api.github.com/users/tmpvar/received_events","type":"User","site_admin":false},"repo":{"id":478584,"name":"jsdom","full_name":"tmpvar/jsdom","owner":{"login":"tmpvar","id":46673,"avatar_url":"https://avatars.githubusercontent.com/u/46673?v=1","gravatar_id":"2893bc1693002e652210b3705f74b5dd","url":"https://api.github.com/users/tmpvar","html_url":"https://github.com/tmpvar","followers_url":"https://api.github.com/users/tmpvar/followers","following_url":"https://api.github.com/users/tmpvar/following{/other_user}","gists_url":"https://api.github.com/users/tmpvar/gists{/gist_id}","starred_url":"https://api.github.com/users/tmpvar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmpvar/subscriptions","organizations_url":"https://api.github.com/users/tmpvar/orgs","repos_url":"https://api.github.com/users/tmpvar/repos","events_url":"https://api.github.com/users/tmpvar/events{/privacy}","received_events_url":"https://api.github.com/users/tmpvar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tmpvar/jsdom","description":"A javascript implementation of the DOM, for use with node.js.","fork":false,"url":"https://api.github.com/repos/tmpvar/jsdom","forks_url":"https://api.github.com/repos/tmpvar/jsdom/forks","keys_url":"https://api.github.com/repos/tmpvar/jsdom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tmpvar/jsdom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tmpvar/jsdom/teams","hooks_url":"https://api.github.com/repos/tmpvar/jsdom/hooks","issue_events_url":"https://api.github.com/repos/tmpvar/jsdom/issues/events{/number}","events_url":"https://api.github.com/repos/tmpvar/jsdom/events","assignees_url":"https://api.github.com/repos/tmpvar/jsdom/assignees{/user}","branches_url":"https://api.github.com/repos/tmpvar/jsdom/branches{/branch}","tags_url":"https://api.github.com/repos/tmpvar/jsdom/tags","blobs_url":"https://api.github.com/repos/tmpvar/jsdom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tmpvar/jsdom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tmpvar/jsdom/git/refs{/sha}","trees_url":"https://api.github.com/repos/tmpvar/jsdom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tmpvar/jsdom/statuses/{sha}","languages_url":"https://api.github.com/repos/tmpvar/jsdom/languages","stargazers_url":"https://api.github.com/repos/tmpvar/jsdom/stargazers","contributors_url":"https://api.github.com/repos/tmpvar/jsdom/contributors","subscribers_url":"https://api.github.com/repos/tmpvar/jsdom/subscribers","subscription_url":"https://api.github.com/repos/tmpvar/jsdom/subscription","commits_url":"https://api.github.com/repos/tmpvar/jsdom/commits{/sha}","git_commits_url":"https://api.github.com/repos/tmpvar/jsdom/git/commits{/sha}","comments_url":"https://api.github.com/repos/tmpvar/jsdom/comments{/number}","issue_comment_url":"https://api.github.com/repos/tmpvar/jsdom/issues/comments/{number}","contents_url":"https://api.github.com/repos/tmpvar/jsdom/contents/{+path}","compare_url":"https://api.github.com/repos/tmpvar/jsdom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tmpvar/jsdom/merges","archive_url":"https://api.github.com/repos/tmpvar/jsdom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tmpvar/jsdom/downloads","issues_url":"https://api.github.com/repos/tmpvar/jsdom/issues{/number}","pulls_url":"https://api.github.com/repos/tmpvar/jsdom/pulls{/number}","milestones_url":"https://api.github.com/repos/tmpvar/jsdom/milestones{/number}","notifications_url":"https://api.github.com/repos/tmpvar/jsdom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tmpvar/jsdom/labels{/name}","releases_url":"https://api.github.com/repos/tmpvar/jsdom/releases{/id}","created_at":"2010-01-19T06:55:19Z","updated_at":"2014-08-01T12:29:10Z","pushed_at":"2014-08-01T21:27:06Z","git_url":"git://github.com/tmpvar/jsdom.git","ssh_url":"git@github.com:tmpvar/jsdom.git","clone_url":"https://github.com/tmpvar/jsdom.git","svn_url":"https://github.com/tmpvar/jsdom","homepage":"","size":14450,"stargazers_count":3173,"watchers_count":3173,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":384,"mirror_url":null,"open_issues_count":102,"forks":384,"open_issues":102,"watchers":3173,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tmpvar/jsdom/pulls/847"},"html":{"href":"https://github.com/tmpvar/jsdom/pull/847"},"issue":{"href":"https://api.github.com/repos/tmpvar/jsdom/issues/847"},"comments":{"href":"https://api.github.com/repos/tmpvar/jsdom/issues/847/comments"},"review_comments":{"href":"https://api.github.com/repos/tmpvar/jsdom/pulls/847/comments"},"review_comment":{"href":"https://api.github.com/repos/tmpvar/jsdom/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/tmpvar/jsdom/pulls/847/commits"},"statuses":{"href":"https://api.github.com/repos/tmpvar/jsdom/statuses/68b0df2b5b1aeb5b2ba24b09d48974bd4800e5b1"}}}}