GitHub PullRequestReviewCommentEvent at 2014-09-05 21:00:01
Repository: bitcoin
Actor: sipa
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/17197912","id":17197912,"diff_hunk":"@@ -4121,10 +4121,13 @@ bool ProcessMessages(CNode* pfrom)\n \n         // get next message\n         CNetMessage& msg = *it;\n+        CMessageHeader& hdr = msg.hdr;\n+        unsigned int nMessageSize = hdr.nMessageSize;\n+        string strCommand = hdr.GetCommand();","path":"src/main.cpp","position":6,"original_position":6,"commit_id":"2488148aab4ffc4ec4b783d363c72b4075db9a37","original_commit_id":"2488148aab4ffc4ec4b783d363c72b4075db9a37","user":{"login":"sipa","id":548488,"avatar_url":"https://avatars.githubusercontent.com/u/548488?v=2","gravatar_id":"369687cc5d256fe269c9fac0216be2a7","url":"https://api.github.com/users/sipa","html_url":"https://github.com/sipa","followers_url":"https://api.github.com/users/sipa/followers","following_url":"https://api.github.com/users/sipa/following{/other_user}","gists_url":"https://api.github.com/users/sipa/gists{/gist_id}","starred_url":"https://api.github.com/users/sipa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sipa/subscriptions","organizations_url":"https://api.github.com/users/sipa/orgs","repos_url":"https://api.github.com/users/sipa/repos","events_url":"https://api.github.com/users/sipa/events{/privacy}","received_events_url":"https://api.github.com/users/sipa/received_events","type":"User","site_admin":false},"body":"It will return an empty string for command in case an incomplete message is in the buffer. That probably happens rarely.\r\n\r\n","created_at":"2014-09-05T21:00:01Z","updated_at":"2014-09-05T21:00:01Z","html_url":"https://github.com/bitcoin/bitcoin/pull/4839#discussion_r17197912","pull_request_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/4839","_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/17197912"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/4839#discussion_r17197912"},"pull_request":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/4839"}}},"pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/4839","id":20719678,"html_url":"https://github.com/bitcoin/bitcoin/pull/4839","diff_url":"https://github.com/bitcoin/bitcoin/pull/4839.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/4839.patch","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/4839","number":4839,"state":"open","locked":false,"title":"Less messy debug","user":{"login":"rebroad","id":1530283,"avatar_url":"https://avatars.githubusercontent.com/u/1530283?v=2","gravatar_id":"a27aa8d1cbe456b5b7bdcc7d43b118fc","url":"https://api.github.com/users/rebroad","html_url":"https://github.com/rebroad","followers_url":"https://api.github.com/users/rebroad/followers","following_url":"https://api.github.com/users/rebroad/following{/other_user}","gists_url":"https://api.github.com/users/rebroad/gists{/gist_id}","starred_url":"https://api.github.com/users/rebroad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rebroad/subscriptions","organizations_url":"https://api.github.com/users/rebroad/orgs","repos_url":"https://api.github.com/users/rebroad/repos","events_url":"https://api.github.com/users/rebroad/events{/privacy}","received_events_url":"https://api.github.com/users/rebroad/received_events","type":"User","site_admin":false},"body":"Show peer causing the bad messages.","created_at":"2014-09-04T03:03:39Z","updated_at":"2014-09-05T21:00:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1b74074c6a41d4b0a254add97dd719e091c3d6b5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/4839/commits","review_comments_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/4839/comments","review_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/{number}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/4839/comments","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/2488148aab4ffc4ec4b783d363c72b4075db9a37","head":{"label":"rebroad:LessMessyDebug","ref":"LessMessyDebug","sha":"2488148aab4ffc4ec4b783d363c72b4075db9a37","user":{"login":"rebroad","id":1530283,"avatar_url":"https://avatars.githubusercontent.com/u/1530283?v=2","gravatar_id":"a27aa8d1cbe456b5b7bdcc7d43b118fc","url":"https://api.github.com/users/rebroad","html_url":"https://github.com/rebroad","followers_url":"https://api.github.com/users/rebroad/followers","following_url":"https://api.github.com/users/rebroad/following{/other_user}","gists_url":"https://api.github.com/users/rebroad/gists{/gist_id}","starred_url":"https://api.github.com/users/rebroad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rebroad/subscriptions","organizations_url":"https://api.github.com/users/rebroad/orgs","repos_url":"https://api.github.com/users/rebroad/repos","events_url":"https://api.github.com/users/rebroad/events{/privacy}","received_events_url":"https://api.github.com/users/rebroad/received_events","type":"User","site_admin":false},"repo":{"id":3774405,"name":"bitcoin","full_name":"rebroad/bitcoin","owner":{"login":"rebroad","id":1530283,"avatar_url":"https://avatars.githubusercontent.com/u/1530283?v=2","gravatar_id":"a27aa8d1cbe456b5b7bdcc7d43b118fc","url":"https://api.github.com/users/rebroad","html_url":"https://github.com/rebroad","followers_url":"https://api.github.com/users/rebroad/followers","following_url":"https://api.github.com/users/rebroad/following{/other_user}","gists_url":"https://api.github.com/users/rebroad/gists{/gist_id}","starred_url":"https://api.github.com/users/rebroad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rebroad/subscriptions","organizations_url":"https://api.github.com/users/rebroad/orgs","repos_url":"https://api.github.com/users/rebroad/repos","events_url":"https://api.github.com/users/rebroad/events{/privacy}","received_events_url":"https://api.github.com/users/rebroad/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rebroad/bitcoin","description":"Bitcoin integration/staging tree","fork":true,"url":"https://api.github.com/repos/rebroad/bitcoin","forks_url":"https://api.github.com/repos/rebroad/bitcoin/forks","keys_url":"https://api.github.com/repos/rebroad/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rebroad/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rebroad/bitcoin/teams","hooks_url":"https://api.github.com/repos/rebroad/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/rebroad/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/rebroad/bitcoin/events","assignees_url":"https://api.github.com/repos/rebroad/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/rebroad/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/rebroad/bitcoin/tags","blobs_url":"https://api.github.com/repos/rebroad/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rebroad/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rebroad/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/rebroad/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rebroad/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/rebroad/bitcoin/languages","stargazers_url":"https://api.github.com/repos/rebroad/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/rebroad/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/rebroad/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/rebroad/bitcoin/subscription","commits_url":"https://api.github.com/repos/rebroad/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/rebroad/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/rebroad/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/rebroad/bitcoin/issues/comments/{number}","contents_url":"https://api.github.com/repos/rebroad/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/rebroad/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rebroad/bitcoin/merges","archive_url":"https://api.github.com/repos/rebroad/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rebroad/bitcoin/downloads","issues_url":"https://api.github.com/repos/rebroad/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/rebroad/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/rebroad/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/rebroad/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rebroad/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/rebroad/bitcoin/releases{/id}","created_at":"2012-03-20T11:21:44Z","updated_at":"2014-06-25T18:11:28Z","pushed_at":"2014-09-05T15:23:15Z","git_url":"git://github.com/rebroad/bitcoin.git","ssh_url":"git@github.com:rebroad/bitcoin.git","clone_url":"https://github.com/rebroad/bitcoin.git","svn_url":"https://github.com/rebroad/bitcoin","homepage":"http://www.bitcoin.org","size":46340,"stargazers_count":1,"watchers_count":1,"language":"TypeScript","has_issues":true,"has_downloads":false,"has_wiki":true,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"bitcoin:master","ref":"master","sha":"961c4a04c25237285fb9a694f8918556c690bcd6","user":{"login":"bitcoin","id":528860,"avatar_url":"https://avatars.githubusercontent.com/u/528860?v=2","gravatar_id":"26e4cc7164bdfe71d0daf3764fbc4b33","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"repo":{"id":1181927,"name":"bitcoin","full_name":"bitcoin/bitcoin","owner":{"login":"bitcoin","id":528860,"avatar_url":"https://avatars.githubusercontent.com/u/528860?v=2","gravatar_id":"26e4cc7164bdfe71d0daf3764fbc4b33","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bitcoin/bitcoin","description":"Bitcoin Core integration/staging tree","fork":false,"url":"https://api.github.com/repos/bitcoin/bitcoin","forks_url":"https://api.github.com/repos/bitcoin/bitcoin/forks","keys_url":"https://api.github.com/repos/bitcoin/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoin/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoin/bitcoin/teams","hooks_url":"https://api.github.com/repos/bitcoin/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoin/bitcoin/events","assignees_url":"https://api.github.com/repos/bitcoin/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoin/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoin/bitcoin/tags","blobs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoin/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoin/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoin/bitcoin/languages","stargazers_url":"https://api.github.com/repos/bitcoin/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/bitcoin/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/bitcoin/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/bitcoin/bitcoin/subscription","commits_url":"https://api.github.com/repos/bitcoin/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoin/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments/{number}","contents_url":"https://api.github.com/repos/bitcoin/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoin/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoin/bitcoin/merges","archive_url":"https://api.github.com/repos/bitcoin/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoin/bitcoin/downloads","issues_url":"https://api.github.com/repos/bitcoin/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoin/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/bitcoin/bitcoin/releases{/id}","created_at":"2010-12-19T15:16:43Z","updated_at":"2014-09-05T18:21:08Z","pushed_at":"2014-09-05T20:54:12Z","git_url":"git://github.com/bitcoin/bitcoin.git","ssh_url":"git@github.com:bitcoin/bitcoin.git","clone_url":"https://github.com/bitcoin/bitcoin.git","svn_url":"https://github.com/bitcoin/bitcoin","homepage":"https://bitcoin.org/en/download","size":102678,"stargazers_count":5793,"watchers_count":5793,"language":"TypeScript","has_issues":true,"has_downloads":false,"has_wiki":false,"forks_count":4175,"mirror_url":null,"open_issues_count":410,"forks":4175,"open_issues":410,"watchers":5793,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/4839"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/4839"},"issue":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/4839"},"comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/4839/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/4839/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/4839/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoin/bitcoin/statuses/2488148aab4ffc4ec4b783d363c72b4075db9a37"}}}}