GitHub PullRequestReviewCommentEvent at 2014-10-21 08:40:09
Repository: symfony-installer
Actor: jzawadzki
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/symfony/symfony-installer/pulls/comments/19135492","id":19135492,"diff_hunk":"@@ -77,12 +82,24 @@ protected function execute(InputInterface $input, OutputInterface $output)\n     * Read the documentation at <comment>http://symfony.com/doc</comment>\n \n MESSAGE;\n+        } else {\n+            $message = <<<MESSAGE\n+\n+ <info>✕</info>  Symfony was <info>successfully installed</info> but your system doesn't meet requirements!\n \n+MESSAGE;\n+        }\n         if (defined('PHP_WINDOWS_VERSION_BUILD')) {\n-            $message = str_replace('✔', 'OK', $message);\n+            $message = str_replace(array('✔','✕'), array('OK','FAILED'), $message);\n         }\n \n         $output->writeln($message);\n+\n+        if(!$meetRequirements) {\n+            foreach ($errorMessages as $helpText) {\n+               $output->writeln(' * '.$helpText);\n+            }","path":"src/Symfony/Installer/NewCommand.php","position":35,"original_position":35,"commit_id":"9ce3f64a1dc78741adbddb218b72feb559453e36","original_commit_id":"9ce3f64a1dc78741adbddb218b72feb559453e36","user":{"login":"jzawadzki","id":1220891,"avatar_url":"https://avatars.githubusercontent.com/u/1220891?v=2","gravatar_id":"","url":"https://api.github.com/users/jzawadzki","html_url":"https://github.com/jzawadzki","followers_url":"https://api.github.com/users/jzawadzki/followers","following_url":"https://api.github.com/users/jzawadzki/following{/other_user}","gists_url":"https://api.github.com/users/jzawadzki/gists{/gist_id}","starred_url":"https://api.github.com/users/jzawadzki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jzawadzki/subscriptions","organizations_url":"https://api.github.com/users/jzawadzki/orgs","repos_url":"https://api.github.com/users/jzawadzki/repos","events_url":"https://api.github.com/users/jzawadzki/events{/privacy}","received_events_url":"https://api.github.com/users/jzawadzki/received_events","type":"User","site_admin":false},"body":"just `return 1` or `throw RuntimeException`?","created_at":"2014-10-21T08:40:09Z","updated_at":"2014-10-21T08:40:09Z","html_url":"https://github.com/symfony/symfony-installer/pull/27#discussion_r19135492","pull_request_url":"https://api.github.com/repos/symfony/symfony-installer/pulls/27","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony-installer/pulls/comments/19135492"},"html":{"href":"https://github.com/symfony/symfony-installer/pull/27#discussion_r19135492"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony-installer/pulls/27"}}},"pull_request":{"url":"https://api.github.com/repos/symfony/symfony-installer/pulls/27","id":22978775,"html_url":"https://github.com/symfony/symfony-installer/pull/27","diff_url":"https://github.com/symfony/symfony-installer/pull/27.diff","patch_url":"https://github.com/symfony/symfony-installer/pull/27.patch","issue_url":"https://api.github.com/repos/symfony/symfony-installer/issues/27","number":27,"state":"open","locked":false,"title":"Added checking symfony requirements before showing success message","user":{"login":"jzawadzki","id":1220891,"avatar_url":"https://avatars.githubusercontent.com/u/1220891?v=2","gravatar_id":"","url":"https://api.github.com/users/jzawadzki","html_url":"https://github.com/jzawadzki","followers_url":"https://api.github.com/users/jzawadzki/followers","following_url":"https://api.github.com/users/jzawadzki/following{/other_user}","gists_url":"https://api.github.com/users/jzawadzki/gists{/gist_id}","starred_url":"https://api.github.com/users/jzawadzki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jzawadzki/subscriptions","organizations_url":"https://api.github.com/users/jzawadzki/orgs","repos_url":"https://api.github.com/users/jzawadzki/repos","events_url":"https://api.github.com/users/jzawadzki/events{/privacy}","received_events_url":"https://api.github.com/users/jzawadzki/received_events","type":"User","site_admin":false},"body":"I've added checking symfony requirements (as per #9)\r\nIf any of requirements is not met installer will show error message and list missing requirements. Hovewer, it will not show recommendations as app/check.php does that already and I think it's not needed here?\r\nProbably error message can be better but I think it's a good start.\r\n","created_at":"2014-10-19T09:58:15Z","updated_at":"2014-10-21T08:40:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4a1524855560f47b0fe497aa8ebd5b6a68d668ce","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/symfony/symfony-installer/pulls/27/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony-installer/pulls/27/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony-installer/pulls/comments/{number}","comments_url":"https://api.github.com/repos/symfony/symfony-installer/issues/27/comments","statuses_url":"https://api.github.com/repos/symfony/symfony-installer/statuses/9ce3f64a1dc78741adbddb218b72feb559453e36","head":{"label":"jzawadzki:master","ref":"master","sha":"9ce3f64a1dc78741adbddb218b72feb559453e36","user":{"login":"jzawadzki","id":1220891,"avatar_url":"https://avatars.githubusercontent.com/u/1220891?v=2","gravatar_id":"","url":"https://api.github.com/users/jzawadzki","html_url":"https://github.com/jzawadzki","followers_url":"https://api.github.com/users/jzawadzki/followers","following_url":"https://api.github.com/users/jzawadzki/following{/other_user}","gists_url":"https://api.github.com/users/jzawadzki/gists{/gist_id}","starred_url":"https://api.github.com/users/jzawadzki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jzawadzki/subscriptions","organizations_url":"https://api.github.com/users/jzawadzki/orgs","repos_url":"https://api.github.com/users/jzawadzki/repos","events_url":"https://api.github.com/users/jzawadzki/events{/privacy}","received_events_url":"https://api.github.com/users/jzawadzki/received_events","type":"User","site_admin":false},"repo":{"id":25325349,"name":"symfony-installer","full_name":"jzawadzki/symfony-installer","owner":{"login":"jzawadzki","id":1220891,"avatar_url":"https://avatars.githubusercontent.com/u/1220891?v=2","gravatar_id":"","url":"https://api.github.com/users/jzawadzki","html_url":"https://github.com/jzawadzki","followers_url":"https://api.github.com/users/jzawadzki/followers","following_url":"https://api.github.com/users/jzawadzki/following{/other_user}","gists_url":"https://api.github.com/users/jzawadzki/gists{/gist_id}","starred_url":"https://api.github.com/users/jzawadzki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jzawadzki/subscriptions","organizations_url":"https://api.github.com/users/jzawadzki/orgs","repos_url":"https://api.github.com/users/jzawadzki/repos","events_url":"https://api.github.com/users/jzawadzki/events{/privacy}","received_events_url":"https://api.github.com/users/jzawadzki/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jzawadzki/symfony-installer","description":"The Symfony Installer","fork":true,"url":"https://api.github.com/repos/jzawadzki/symfony-installer","forks_url":"https://api.github.com/repos/jzawadzki/symfony-installer/forks","keys_url":"https://api.github.com/repos/jzawadzki/symfony-installer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jzawadzki/symfony-installer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jzawadzki/symfony-installer/teams","hooks_url":"https://api.github.com/repos/jzawadzki/symfony-installer/hooks","issue_events_url":"https://api.github.com/repos/jzawadzki/symfony-installer/issues/events{/number}","events_url":"https://api.github.com/repos/jzawadzki/symfony-installer/events","assignees_url":"https://api.github.com/repos/jzawadzki/symfony-installer/assignees{/user}","branches_url":"https://api.github.com/repos/jzawadzki/symfony-installer/branches{/branch}","tags_url":"https://api.github.com/repos/jzawadzki/symfony-installer/tags","blobs_url":"https://api.github.com/repos/jzawadzki/symfony-installer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jzawadzki/symfony-installer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jzawadzki/symfony-installer/git/refs{/sha}","trees_url":"https://api.github.com/repos/jzawadzki/symfony-installer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jzawadzki/symfony-installer/statuses/{sha}","languages_url":"https://api.github.com/repos/jzawadzki/symfony-installer/languages","stargazers_url":"https://api.github.com/repos/jzawadzki/symfony-installer/stargazers","contributors_url":"https://api.github.com/repos/jzawadzki/symfony-installer/contributors","subscribers_url":"https://api.github.com/repos/jzawadzki/symfony-installer/subscribers","subscription_url":"https://api.github.com/repos/jzawadzki/symfony-installer/subscription","commits_url":"https://api.github.com/repos/jzawadzki/symfony-installer/commits{/sha}","git_commits_url":"https://api.github.com/repos/jzawadzki/symfony-installer/git/commits{/sha}","comments_url":"https://api.github.com/repos/jzawadzki/symfony-installer/comments{/number}","issue_comment_url":"https://api.github.com/repos/jzawadzki/symfony-installer/issues/comments/{number}","contents_url":"https://api.github.com/repos/jzawadzki/symfony-installer/contents/{+path}","compare_url":"https://api.github.com/repos/jzawadzki/symfony-installer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jzawadzki/symfony-installer/merges","archive_url":"https://api.github.com/repos/jzawadzki/symfony-installer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jzawadzki/symfony-installer/downloads","issues_url":"https://api.github.com/repos/jzawadzki/symfony-installer/issues{/number}","pulls_url":"https://api.github.com/repos/jzawadzki/symfony-installer/pulls{/number}","milestones_url":"https://api.github.com/repos/jzawadzki/symfony-installer/milestones{/number}","notifications_url":"https://api.github.com/repos/jzawadzki/symfony-installer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jzawadzki/symfony-installer/labels{/name}","releases_url":"https://api.github.com/repos/jzawadzki/symfony-installer/releases{/id}","created_at":"2014-10-16T22:37:47Z","updated_at":"2014-10-19T09:52:39Z","pushed_at":"2014-10-19T20:47:00Z","git_url":"git://github.com/jzawadzki/symfony-installer.git","ssh_url":"git@github.com:jzawadzki/symfony-installer.git","clone_url":"https://github.com/jzawadzki/symfony-installer.git","svn_url":"https://github.com/jzawadzki/symfony-installer","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"symfony:master","ref":"master","sha":"9e4d18607e3db9cf1cb515a02ba90463c78f9ad2","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=2","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":25295409,"name":"symfony-installer","full_name":"symfony/symfony-installer","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=2","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony-installer","description":"The Symfony Installer","fork":false,"url":"https://api.github.com/repos/symfony/symfony-installer","forks_url":"https://api.github.com/repos/symfony/symfony-installer/forks","keys_url":"https://api.github.com/repos/symfony/symfony-installer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony-installer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony-installer/teams","hooks_url":"https://api.github.com/repos/symfony/symfony-installer/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony-installer/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony-installer/events","assignees_url":"https://api.github.com/repos/symfony/symfony-installer/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony-installer/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony-installer/tags","blobs_url":"https://api.github.com/repos/symfony/symfony-installer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony-installer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony-installer/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony-installer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony-installer/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony-installer/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony-installer/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony-installer/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony-installer/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony-installer/subscription","commits_url":"https://api.github.com/repos/symfony/symfony-installer/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony-installer/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony-installer/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony-installer/issues/comments/{number}","contents_url":"https://api.github.com/repos/symfony/symfony-installer/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony-installer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony-installer/merges","archive_url":"https://api.github.com/repos/symfony/symfony-installer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony-installer/downloads","issues_url":"https://api.github.com/repos/symfony/symfony-installer/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony-installer/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony-installer/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony-installer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony-installer/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony-installer/releases{/id}","created_at":"2014-10-16T09:32:36Z","updated_at":"2014-10-21T08:12:44Z","pushed_at":"2014-10-21T08:14:40Z","git_url":"git://github.com/symfony/symfony-installer.git","ssh_url":"git@github.com:symfony/symfony-installer.git","clone_url":"https://github.com/symfony/symfony-installer.git","svn_url":"https://github.com/symfony/symfony-installer","homepage":null,"size":0,"stargazers_count":85,"watchers_count":85,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":19,"forks":14,"open_issues":19,"watchers":85,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony-installer/pulls/27"},"html":{"href":"https://github.com/symfony/symfony-installer/pull/27"},"issue":{"href":"https://api.github.com/repos/symfony/symfony-installer/issues/27"},"comments":{"href":"https://api.github.com/repos/symfony/symfony-installer/issues/27/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony-installer/pulls/27/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony-installer/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony-installer/pulls/27/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony-installer/statuses/9ce3f64a1dc78741adbddb218b72feb559453e36"}}}}