GitHub PullRequestEvent at 2014-12-14 01:04:03
Repository: phpseclib
Actor: bantu
Payload: {"action":"closed","number":507,"pull_request":{"url":"https://api.github.com/repos/phpseclib/phpseclib/pulls/507","id":25223132,"html_url":"https://github.com/phpseclib/phpseclib/pull/507","diff_url":"https://github.com/phpseclib/phpseclib/pull/507.diff","patch_url":"https://github.com/phpseclib/phpseclib/pull/507.patch","issue_url":"https://api.github.com/repos/phpseclib/phpseclib/issues/507","number":507,"state":"closed","locked":false,"title":"add OpenSSL support for symmetric key encryption","user":{"login":"terrafrost","id":214474,"avatar_url":"https://avatars.githubusercontent.com/u/214474?v=3","gravatar_id":"","url":"https://api.github.com/users/terrafrost","html_url":"https://github.com/terrafrost","followers_url":"https://api.github.com/users/terrafrost/followers","following_url":"https://api.github.com/users/terrafrost/following{/other_user}","gists_url":"https://api.github.com/users/terrafrost/gists{/gist_id}","starred_url":"https://api.github.com/users/terrafrost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terrafrost/subscriptions","organizations_url":"https://api.github.com/users/terrafrost/orgs","repos_url":"https://api.github.com/users/terrafrost/repos","events_url":"https://api.github.com/users/terrafrost/events{/privacy}","received_events_url":"https://api.github.com/users/terrafrost/received_events","type":"User","site_admin":false},"body":"Replaces #259\r\n\r\nThere are a few other things I'd like to do before this is merged.\r\n\r\n1. adjust ordering of crypto algorithms in SSH2 based on available extensions\r\n2. do a test of RC4 too for CRYPT_MODE_STREAM \r\n3. test both internal modes?\r\n4. do the continuous mode tests without continuous mode enabled to ensure that non-continuous mode operates correctly.\r\n\r\nTo elaborate on # 1...  OpenSSL cannot be used with arcfour256, for example. That uses a 256-bit key whereas OpenSSL only supports RC4 up to 128-bit keys.\r\n\r\nWith any luck this'll make #458 more testable (ie. I get the impression mcrypt is becoming supported less and less, as the years pass, whereas openssl is becoming more and more supported; for example, doing `sudo apt-get install php5-cli` on Ubuntu yields a PHP install with OpenSSL but not mcrypt; mcrypt is still built into Windows PHP installs whereas OpenSSL is not, but who knows how long that'll continue to be the case).\r\n\r\nAlso, the following might make for some interesting reading:\r\n\r\nhttps://github.com/terrafrost/phpseclib/blob/f6e0c4b506b0bdb310314aabfca8d0b7244fe8ba/tests/Unit/Crypt/RC2.php#L17","created_at":"2014-11-29T13:50:46Z","updated_at":"2014-12-14T01:04:03Z","closed_at":"2014-12-14T01:04:03Z","merged_at":null,"merge_commit_sha":"d9953a3f661a7ce419474d28e999d4e5ad5c23ce","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/phpseclib/phpseclib/pulls/507/commits","review_comments_url":"https://api.github.com/repos/phpseclib/phpseclib/pulls/507/comments","review_comment_url":"https://api.github.com/repos/phpseclib/phpseclib/pulls/comments/{number}","comments_url":"https://api.github.com/repos/phpseclib/phpseclib/issues/507/comments","statuses_url":"https://api.github.com/repos/phpseclib/phpseclib/statuses/8f27aaa323f649290a7ebed57647c1af3394f787","head":{"label":"terrafrost:openssl-support","ref":"openssl-support","sha":"8f27aaa323f649290a7ebed57647c1af3394f787","user":{"login":"terrafrost","id":214474,"avatar_url":"https://avatars.githubusercontent.com/u/214474?v=3","gravatar_id":"","url":"https://api.github.com/users/terrafrost","html_url":"https://github.com/terrafrost","followers_url":"https://api.github.com/users/terrafrost/followers","following_url":"https://api.github.com/users/terrafrost/following{/other_user}","gists_url":"https://api.github.com/users/terrafrost/gists{/gist_id}","starred_url":"https://api.github.com/users/terrafrost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terrafrost/subscriptions","organizations_url":"https://api.github.com/users/terrafrost/orgs","repos_url":"https://api.github.com/users/terrafrost/repos","events_url":"https://api.github.com/users/terrafrost/events{/privacy}","received_events_url":"https://api.github.com/users/terrafrost/received_events","type":"User","site_admin":false},"repo":{"id":4767988,"name":"phpseclib","full_name":"terrafrost/phpseclib","owner":{"login":"terrafrost","id":214474,"avatar_url":"https://avatars.githubusercontent.com/u/214474?v=3","gravatar_id":"","url":"https://api.github.com/users/terrafrost","html_url":"https://github.com/terrafrost","followers_url":"https://api.github.com/users/terrafrost/followers","following_url":"https://api.github.com/users/terrafrost/following{/other_user}","gists_url":"https://api.github.com/users/terrafrost/gists{/gist_id}","starred_url":"https://api.github.com/users/terrafrost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terrafrost/subscriptions","organizations_url":"https://api.github.com/users/terrafrost/orgs","repos_url":"https://api.github.com/users/terrafrost/repos","events_url":"https://api.github.com/users/terrafrost/events{/privacy}","received_events_url":"https://api.github.com/users/terrafrost/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/terrafrost/phpseclib","description":"PHP Secure Communications Library","fork":true,"url":"https://api.github.com/repos/terrafrost/phpseclib","forks_url":"https://api.github.com/repos/terrafrost/phpseclib/forks","keys_url":"https://api.github.com/repos/terrafrost/phpseclib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/terrafrost/phpseclib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/terrafrost/phpseclib/teams","hooks_url":"https://api.github.com/repos/terrafrost/phpseclib/hooks","issue_events_url":"https://api.github.com/repos/terrafrost/phpseclib/issues/events{/number}","events_url":"https://api.github.com/repos/terrafrost/phpseclib/events","assignees_url":"https://api.github.com/repos/terrafrost/phpseclib/assignees{/user}","branches_url":"https://api.github.com/repos/terrafrost/phpseclib/branches{/branch}","tags_url":"https://api.github.com/repos/terrafrost/phpseclib/tags","blobs_url":"https://api.github.com/repos/terrafrost/phpseclib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/terrafrost/phpseclib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/terrafrost/phpseclib/git/refs{/sha}","trees_url":"https://api.github.com/repos/terrafrost/phpseclib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/terrafrost/phpseclib/statuses/{sha}","languages_url":"https://api.github.com/repos/terrafrost/phpseclib/languages","stargazers_url":"https://api.github.com/repos/terrafrost/phpseclib/stargazers","contributors_url":"https://api.github.com/repos/terrafrost/phpseclib/contributors","subscribers_url":"https://api.github.com/repos/terrafrost/phpseclib/subscribers","subscription_url":"https://api.github.com/repos/terrafrost/phpseclib/subscription","commits_url":"https://api.github.com/repos/terrafrost/phpseclib/commits{/sha}","git_commits_url":"https://api.github.com/repos/terrafrost/phpseclib/git/commits{/sha}","comments_url":"https://api.github.com/repos/terrafrost/phpseclib/comments{/number}","issue_comment_url":"https://api.github.com/repos/terrafrost/phpseclib/issues/comments/{number}","contents_url":"https://api.github.com/repos/terrafrost/phpseclib/contents/{+path}","compare_url":"https://api.github.com/repos/terrafrost/phpseclib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/terrafrost/phpseclib/merges","archive_url":"https://api.github.com/repos/terrafrost/phpseclib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/terrafrost/phpseclib/downloads","issues_url":"https://api.github.com/repos/terrafrost/phpseclib/issues{/number}","pulls_url":"https://api.github.com/repos/terrafrost/phpseclib/pulls{/number}","milestones_url":"https://api.github.com/repos/terrafrost/phpseclib/milestones{/number}","notifications_url":"https://api.github.com/repos/terrafrost/phpseclib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/terrafrost/phpseclib/labels{/name}","releases_url":"https://api.github.com/repos/terrafrost/phpseclib/releases{/id}","created_at":"2012-06-23T22:07:05Z","updated_at":"2014-12-06T18:30:52Z","pushed_at":"2014-12-13T22:56:56Z","git_url":"git://github.com/terrafrost/phpseclib.git","ssh_url":"git@github.com:terrafrost/phpseclib.git","clone_url":"https://github.com/terrafrost/phpseclib.git","svn_url":"https://github.com/terrafrost/phpseclib","homepage":null,"size":5256,"stargazers_count":3,"watchers_count":3,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":3,"default_branch":"master"}},"base":{"label":"phpseclib:master","ref":"master","sha":"956660e9b979c169c11a6b722db0af1c1c715730","user":{"login":"phpseclib","id":1820952,"avatar_url":"https://avatars.githubusercontent.com/u/1820952?v=3","gravatar_id":"","url":"https://api.github.com/users/phpseclib","html_url":"https://github.com/phpseclib","followers_url":"https://api.github.com/users/phpseclib/followers","following_url":"https://api.github.com/users/phpseclib/following{/other_user}","gists_url":"https://api.github.com/users/phpseclib/gists{/gist_id}","starred_url":"https://api.github.com/users/phpseclib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phpseclib/subscriptions","organizations_url":"https://api.github.com/users/phpseclib/orgs","repos_url":"https://api.github.com/users/phpseclib/repos","events_url":"https://api.github.com/users/phpseclib/events{/privacy}","received_events_url":"https://api.github.com/users/phpseclib/received_events","type":"Organization","site_admin":false},"repo":{"id":4565995,"name":"phpseclib","full_name":"phpseclib/phpseclib","owner":{"login":"phpseclib","id":1820952,"avatar_url":"https://avatars.githubusercontent.com/u/1820952?v=3","gravatar_id":"","url":"https://api.github.com/users/phpseclib","html_url":"https://github.com/phpseclib","followers_url":"https://api.github.com/users/phpseclib/followers","following_url":"https://api.github.com/users/phpseclib/following{/other_user}","gists_url":"https://api.github.com/users/phpseclib/gists{/gist_id}","starred_url":"https://api.github.com/users/phpseclib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phpseclib/subscriptions","organizations_url":"https://api.github.com/users/phpseclib/orgs","repos_url":"https://api.github.com/users/phpseclib/repos","events_url":"https://api.github.com/users/phpseclib/events{/privacy}","received_events_url":"https://api.github.com/users/phpseclib/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/phpseclib/phpseclib","description":"PHP Secure Communications Library","fork":false,"url":"https://api.github.com/repos/phpseclib/phpseclib","forks_url":"https://api.github.com/repos/phpseclib/phpseclib/forks","keys_url":"https://api.github.com/repos/phpseclib/phpseclib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phpseclib/phpseclib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phpseclib/phpseclib/teams","hooks_url":"https://api.github.com/repos/phpseclib/phpseclib/hooks","issue_events_url":"https://api.github.com/repos/phpseclib/phpseclib/issues/events{/number}","events_url":"https://api.github.com/repos/phpseclib/phpseclib/events","assignees_url":"https://api.github.com/repos/phpseclib/phpseclib/assignees{/user}","branches_url":"https://api.github.com/repos/phpseclib/phpseclib/branches{/branch}","tags_url":"https://api.github.com/repos/phpseclib/phpseclib/tags","blobs_url":"https://api.github.com/repos/phpseclib/phpseclib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phpseclib/phpseclib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phpseclib/phpseclib/git/refs{/sha}","trees_url":"https://api.github.com/repos/phpseclib/phpseclib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phpseclib/phpseclib/statuses/{sha}","languages_url":"https://api.github.com/repos/phpseclib/phpseclib/languages","stargazers_url":"https://api.github.com/repos/phpseclib/phpseclib/stargazers","contributors_url":"https://api.github.com/repos/phpseclib/phpseclib/contributors","subscribers_url":"https://api.github.com/repos/phpseclib/phpseclib/subscribers","subscription_url":"https://api.github.com/repos/phpseclib/phpseclib/subscription","commits_url":"https://api.github.com/repos/phpseclib/phpseclib/commits{/sha}","git_commits_url":"https://api.github.com/repos/phpseclib/phpseclib/git/commits{/sha}","comments_url":"https://api.github.com/repos/phpseclib/phpseclib/comments{/number}","issue_comment_url":"https://api.github.com/repos/phpseclib/phpseclib/issues/comments/{number}","contents_url":"https://api.github.com/repos/phpseclib/phpseclib/contents/{+path}","compare_url":"https://api.github.com/repos/phpseclib/phpseclib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phpseclib/phpseclib/merges","archive_url":"https://api.github.com/repos/phpseclib/phpseclib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phpseclib/phpseclib/downloads","issues_url":"https://api.github.com/repos/phpseclib/phpseclib/issues{/number}","pulls_url":"https://api.github.com/repos/phpseclib/phpseclib/pulls{/number}","milestones_url":"https://api.github.com/repos/phpseclib/phpseclib/milestones{/number}","notifications_url":"https://api.github.com/repos/phpseclib/phpseclib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phpseclib/phpseclib/labels{/name}","releases_url":"https://api.github.com/repos/phpseclib/phpseclib/releases{/id}","created_at":"2012-06-05T21:55:28Z","updated_at":"2014-12-14T00:59:35Z","pushed_at":"2014-12-14T00:59:35Z","git_url":"git://github.com/phpseclib/phpseclib.git","ssh_url":"git@github.com:phpseclib/phpseclib.git","clone_url":"https://github.com/phpseclib/phpseclib.git","svn_url":"https://github.com/phpseclib/phpseclib","homepage":"http://phpseclib.sourceforge.net","size":9871,"stargazers_count":577,"watchers_count":577,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":181,"mirror_url":null,"open_issues_count":67,"forks":181,"open_issues":67,"watchers":577,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/phpseclib/phpseclib/pulls/507"},"html":{"href":"https://github.com/phpseclib/phpseclib/pull/507"},"issue":{"href":"https://api.github.com/repos/phpseclib/phpseclib/issues/507"},"comments":{"href":"https://api.github.com/repos/phpseclib/phpseclib/issues/507/comments"},"review_comments":{"href":"https://api.github.com/repos/phpseclib/phpseclib/pulls/507/comments"},"review_comment":{"href":"https://api.github.com/repos/phpseclib/phpseclib/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/phpseclib/phpseclib/pulls/507/commits"},"statuses":{"href":"https://api.github.com/repos/phpseclib/phpseclib/statuses/8f27aaa323f649290a7ebed57647c1af3394f787"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":15,"review_comments":7,"commits":27,"additions":1590,"deletions":863,"changed_files":17}}