GitHub PullRequestReviewCommentEvent at 2014-12-12 10:11:32
Repository: spark
Actor: WangTaoTheTonic
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/21736185","id":21736185,"diff_hunk":"@@ -129,9 +129,12 @@ case $option in\n     mkdir -p \"$SPARK_PID_DIR\"\n \n     if [ -f $pid ]; then\n-      if kill -0 `cat $pid` > /dev/null 2>&1; then\n-        echo $command running as process `cat $pid`.  Stop it first.\n-        exit 1\n+      TARGET_ID=`cat $pid`\n+      if kill -0 $TARGET_ID > /dev/null 2>&1; then\n+        if [[ `ps -p $TARGET_ID -o args=` =~ $command ]]; then","path":"sbin/spark-daemon.sh","position":null,"original_position":9,"commit_id":"cf4ecc638992cca6c2718c494a21f0da09f26e7a","original_commit_id":"f36cfb42c01ee525878e3baac8962128c66d2093","user":{"login":"WangTaoTheTonic","id":5276001,"avatar_url":"https://avatars.githubusercontent.com/u/5276001?v=3","gravatar_id":"","url":"https://api.github.com/users/WangTaoTheTonic","html_url":"https://github.com/WangTaoTheTonic","followers_url":"https://api.github.com/users/WangTaoTheTonic/followers","following_url":"https://api.github.com/users/WangTaoTheTonic/following{/other_user}","gists_url":"https://api.github.com/users/WangTaoTheTonic/gists{/gist_id}","starred_url":"https://api.github.com/users/WangTaoTheTonic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WangTaoTheTonic/subscriptions","organizations_url":"https://api.github.com/users/WangTaoTheTonic/orgs","repos_url":"https://api.github.com/users/WangTaoTheTonic/repos","events_url":"https://api.github.com/users/WangTaoTheTonic/events{/privacy}","received_events_url":"https://api.github.com/users/WangTaoTheTonic/received_events","type":"User","site_admin":false},"body":"Yep it is redundant with `kill`.\r\nBut that reminds me that we will use `kill` command to check if the daemon pid exists in other places, in which condition that if some other process take that pid, we might kill others.","created_at":"2014-12-12T10:11:32Z","updated_at":"2014-12-12T10:11:32Z","html_url":"https://github.com/apache/spark/pull/3683#discussion_r21736185","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/3683","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/21736185"},"html":{"href":"https://github.com/apache/spark/pull/3683#discussion_r21736185"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/3683"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/3683","id":25956572,"html_url":"https://github.com/apache/spark/pull/3683","diff_url":"https://github.com/apache/spark/pull/3683.diff","patch_url":"https://github.com/apache/spark/pull/3683.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/3683","number":3683,"state":"open","locked":false,"title":"[SPARK-4832][Deploy]some other processes might take the daemon pid","user":{"login":"WangTaoTheTonic","id":5276001,"avatar_url":"https://avatars.githubusercontent.com/u/5276001?v=3","gravatar_id":"","url":"https://api.github.com/users/WangTaoTheTonic","html_url":"https://github.com/WangTaoTheTonic","followers_url":"https://api.github.com/users/WangTaoTheTonic/followers","following_url":"https://api.github.com/users/WangTaoTheTonic/following{/other_user}","gists_url":"https://api.github.com/users/WangTaoTheTonic/gists{/gist_id}","starred_url":"https://api.github.com/users/WangTaoTheTonic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WangTaoTheTonic/subscriptions","organizations_url":"https://api.github.com/users/WangTaoTheTonic/orgs","repos_url":"https://api.github.com/users/WangTaoTheTonic/repos","events_url":"https://api.github.com/users/WangTaoTheTonic/events{/privacy}","received_events_url":"https://api.github.com/users/WangTaoTheTonic/received_events","type":"User","site_admin":false},"body":"Some other processes might use the pid saved in pid file. In that case we should ignore it and launch daemons.\r\n\r\nJIRA is down for maintenance. I will file one once it return.","created_at":"2014-12-12T07:31:13Z","updated_at":"2014-12-12T10:11:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cc2ba65113b658ac943c65d218f69bf18c7f28a1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/3683/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/3683/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments/{number}","comments_url":"https://api.github.com/repos/apache/spark/issues/3683/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/cf4ecc638992cca6c2718c494a21f0da09f26e7a","head":{"label":"WangTaoTheTonic:otherproc","ref":"otherproc","sha":"cf4ecc638992cca6c2718c494a21f0da09f26e7a","user":{"login":"WangTaoTheTonic","id":5276001,"avatar_url":"https://avatars.githubusercontent.com/u/5276001?v=3","gravatar_id":"","url":"https://api.github.com/users/WangTaoTheTonic","html_url":"https://github.com/WangTaoTheTonic","followers_url":"https://api.github.com/users/WangTaoTheTonic/followers","following_url":"https://api.github.com/users/WangTaoTheTonic/following{/other_user}","gists_url":"https://api.github.com/users/WangTaoTheTonic/gists{/gist_id}","starred_url":"https://api.github.com/users/WangTaoTheTonic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WangTaoTheTonic/subscriptions","organizations_url":"https://api.github.com/users/WangTaoTheTonic/orgs","repos_url":"https://api.github.com/users/WangTaoTheTonic/repos","events_url":"https://api.github.com/users/WangTaoTheTonic/events{/privacy}","received_events_url":"https://api.github.com/users/WangTaoTheTonic/received_events","type":"User","site_admin":false},"repo":{"id":18954614,"name":"spark","full_name":"WangTaoTheTonic/spark","owner":{"login":"WangTaoTheTonic","id":5276001,"avatar_url":"https://avatars.githubusercontent.com/u/5276001?v=3","gravatar_id":"","url":"https://api.github.com/users/WangTaoTheTonic","html_url":"https://github.com/WangTaoTheTonic","followers_url":"https://api.github.com/users/WangTaoTheTonic/followers","following_url":"https://api.github.com/users/WangTaoTheTonic/following{/other_user}","gists_url":"https://api.github.com/users/WangTaoTheTonic/gists{/gist_id}","starred_url":"https://api.github.com/users/WangTaoTheTonic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WangTaoTheTonic/subscriptions","organizations_url":"https://api.github.com/users/WangTaoTheTonic/orgs","repos_url":"https://api.github.com/users/WangTaoTheTonic/repos","events_url":"https://api.github.com/users/WangTaoTheTonic/events{/privacy}","received_events_url":"https://api.github.com/users/WangTaoTheTonic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/WangTaoTheTonic/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/WangTaoTheTonic/spark","forks_url":"https://api.github.com/repos/WangTaoTheTonic/spark/forks","keys_url":"https://api.github.com/repos/WangTaoTheTonic/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WangTaoTheTonic/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WangTaoTheTonic/spark/teams","hooks_url":"https://api.github.com/repos/WangTaoTheTonic/spark/hooks","issue_events_url":"https://api.github.com/repos/WangTaoTheTonic/spark/issues/events{/number}","events_url":"https://api.github.com/repos/WangTaoTheTonic/spark/events","assignees_url":"https://api.github.com/repos/WangTaoTheTonic/spark/assignees{/user}","branches_url":"https://api.github.com/repos/WangTaoTheTonic/spark/branches{/branch}","tags_url":"https://api.github.com/repos/WangTaoTheTonic/spark/tags","blobs_url":"https://api.github.com/repos/WangTaoTheTonic/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WangTaoTheTonic/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WangTaoTheTonic/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/WangTaoTheTonic/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WangTaoTheTonic/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/WangTaoTheTonic/spark/languages","stargazers_url":"https://api.github.com/repos/WangTaoTheTonic/spark/stargazers","contributors_url":"https://api.github.com/repos/WangTaoTheTonic/spark/contributors","subscribers_url":"https://api.github.com/repos/WangTaoTheTonic/spark/subscribers","subscription_url":"https://api.github.com/repos/WangTaoTheTonic/spark/subscription","commits_url":"https://api.github.com/repos/WangTaoTheTonic/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/WangTaoTheTonic/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/WangTaoTheTonic/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/WangTaoTheTonic/spark/issues/comments/{number}","contents_url":"https://api.github.com/repos/WangTaoTheTonic/spark/contents/{+path}","compare_url":"https://api.github.com/repos/WangTaoTheTonic/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WangTaoTheTonic/spark/merges","archive_url":"https://api.github.com/repos/WangTaoTheTonic/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WangTaoTheTonic/spark/downloads","issues_url":"https://api.github.com/repos/WangTaoTheTonic/spark/issues{/number}","pulls_url":"https://api.github.com/repos/WangTaoTheTonic/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/WangTaoTheTonic/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/WangTaoTheTonic/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WangTaoTheTonic/spark/labels{/name}","releases_url":"https://api.github.com/repos/WangTaoTheTonic/spark/releases{/id}","created_at":"2014-04-20T01:10:21Z","updated_at":"2014-11-25T14:23:14Z","pushed_at":"2014-12-12T10:08:21Z","git_url":"git://github.com/WangTaoTheTonic/spark.git","ssh_url":"git@github.com:WangTaoTheTonic/spark.git","clone_url":"https://github.com/WangTaoTheTonic/spark.git","svn_url":"https://github.com/WangTaoTheTonic/spark","homepage":null,"size":98265,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"41a3f9343831a3efc18e08595d095282a8d1486b","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments/{number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","created_at":"2014-02-25T08:00:08Z","updated_at":"2014-12-12T08:52:34Z","pushed_at":"2014-12-12T07:39:02Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":1029996,"stargazers_count":2291,"watchers_count":2291,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2052,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":315,"forks":2052,"open_issues":315,"watchers":2291,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/3683"},"html":{"href":"https://github.com/apache/spark/pull/3683"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/3683"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/3683/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/3683/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/3683/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/cf4ecc638992cca6c2718c494a21f0da09f26e7a"}}}}