GitHub PullRequestReviewCommentEvent at 2014-08-20 10:57:46
Repository: fontforge
Actor: monkeyiq
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/fontforge/fontforge/pulls/comments/16469272","id":16469272,"diff_hunk":"@@ -212,6 +213,16 @@ AC_PATH_PROG([UNZIP],[unzip],[unzip])\n AC_PATH_PROG([UPDATE_MIME_DATABASE],[update-mime-database],[:])\n AC_PATH_PROG([UPDATE_DESKTOP_DATABASE],[update-desktop-database],[:])\n AC_PATH_PROG([PLUTIL],[plutil],[:])\n+\n+if test \"y$HOMEBREW_BREW_FILE\" != \"y\"; then\n+   echo \"detected a homebrew build environment\"\n+   PYLIBDIR=$(${HOMEBREW_PREFIX}/bin/python -c \"from distutils.sysconfig import get_python_lib; print(get_python_lib())\")\n+   PYPKGCONFIG=\"$( cd \"$PYLIBDIR/../../pkgconfig\" && pwd )\"\n+   export PKG_CONFIG_PATH=\"$PKG_CONFIG_PATH:$PYPKGCONFIG\"\n+   echo \"found python pkg_config information: $PYPKGCONFIG\"\n+   export PYTHON=\"${HOMEBREW_PREFIX}/bin/python\"","path":"configure.ac","position":19,"original_position":19,"commit_id":"552f062ce6a3e9c237fc562b96abf0cf82f85442","original_commit_id":"5ea52a2d3d846bb6f383e112b9e7940bf6ba684f","user":{"login":"monkeyiq","id":387108,"avatar_url":"https://avatars.githubusercontent.com/u/387108?v=2","gravatar_id":"f4070477400c9b8311bfcb4ee411f439","url":"https://api.github.com/users/monkeyiq","html_url":"https://github.com/monkeyiq","followers_url":"https://api.github.com/users/monkeyiq/followers","following_url":"https://api.github.com/users/monkeyiq/following{/other_user}","gists_url":"https://api.github.com/users/monkeyiq/gists{/gist_id}","starred_url":"https://api.github.com/users/monkeyiq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monkeyiq/subscriptions","organizations_url":"https://api.github.com/users/monkeyiq/orgs","repos_url":"https://api.github.com/users/monkeyiq/repos","events_url":"https://api.github.com/users/monkeyiq/events{/privacy}","received_events_url":"https://api.github.com/users/monkeyiq/received_events","type":"User","site_admin":false},"body":"I guess I could do a pkg-config test first and when that fails do the PKG_CONFIG_PATH update. Note that the PYLIBDIR and PYPKGCONFIG are not used anywhere but the line export PKG_CONFIG_PATH= which does an append. So if it can already be found then it shouldn't effect anything. \r\n\r\nThe override for python is harder, I notice that my default \"type -all python\" is not the brew python. I can leave that off and see what happens to the build. (no export PYTHON=) line","created_at":"2014-08-20T10:57:46Z","updated_at":"2014-08-20T10:57:46Z","html_url":"https://github.com/fontforge/fontforge/pull/1664#discussion_r16469272","pull_request_url":"https://api.github.com/repos/fontforge/fontforge/pulls/1664","_links":{"self":{"href":"https://api.github.com/repos/fontforge/fontforge/pulls/comments/16469272"},"html":{"href":"https://github.com/fontforge/fontforge/pull/1664#discussion_r16469272"},"pull_request":{"href":"https://api.github.com/repos/fontforge/fontforge/pulls/1664"}}},"pull_request":{"url":"https://api.github.com/repos/fontforge/fontforge/pulls/1664","id":19903625,"html_url":"https://github.com/fontforge/fontforge/pull/1664","diff_url":"https://github.com/fontforge/fontforge/pull/1664.diff","patch_url":"https://github.com/fontforge/fontforge/pull/1664.patch","issue_url":"https://api.github.com/repos/fontforge/fontforge/issues/1664","number":1664,"state":"open","locked":false,"title":"Monkeyiq/2014/aug/travisosxpack","user":{"login":"monkeyiq","id":387108,"avatar_url":"https://avatars.githubusercontent.com/u/387108?v=2","gravatar_id":"f4070477400c9b8311bfcb4ee411f439","url":"https://api.github.com/users/monkeyiq","html_url":"https://github.com/monkeyiq","followers_url":"https://api.github.com/users/monkeyiq/followers","following_url":"https://api.github.com/users/monkeyiq/following{/other_user}","gists_url":"https://api.github.com/users/monkeyiq/gists{/gist_id}","starred_url":"https://api.github.com/users/monkeyiq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monkeyiq/subscriptions","organizations_url":"https://api.github.com/users/monkeyiq/orgs","repos_url":"https://api.github.com/users/monkeyiq/repos","events_url":"https://api.github.com/users/monkeyiq/events{/privacy}","received_events_url":"https://api.github.com/users/monkeyiq/received_events","type":"User","site_admin":false},"body":"This is an update of the PR https://github.com/fontforge/fontforge/pull/1662 but is done on a branch that was first pushed to the mainline fontforge repository. I don't particularly like this design, in the past I have created branches in my fork of fontforge and generated PRs from there. Travis CI does not allow secure environment variables to be shown to builds from forks, see http://docs.travis-ci.com/user/encryption-keys/. I understand why Travis CI does this, and it makes sense. Once I get package building going I might look at having Travis CI build my fork, and branches in it rather than the mainline fontforge. The issue there is a slightly odd one that as far as I can see you would have to create a PR in your own fork against it's master for the Travis build to work there, then create a PR (call it PR2) against the fontforge repo citing the first PR to show that PR2 can pass CI and build a package.\r\n\r\n\r\n","created_at":"2014-08-18T07:54:50Z","updated_at":"2014-08-20T10:57:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0d986d9242da9e741d50c5f543faba2f37b7723d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/fontforge/fontforge/pulls/1664/commits","review_comments_url":"https://api.github.com/repos/fontforge/fontforge/pulls/1664/comments","review_comment_url":"https://api.github.com/repos/fontforge/fontforge/pulls/comments/{number}","comments_url":"https://api.github.com/repos/fontforge/fontforge/issues/1664/comments","statuses_url":"https://api.github.com/repos/fontforge/fontforge/statuses/552f062ce6a3e9c237fc562b96abf0cf82f85442","head":{"label":"fontforge:monkeyiq/2014/aug/travisosxpack","ref":"monkeyiq/2014/aug/travisosxpack","sha":"552f062ce6a3e9c237fc562b96abf0cf82f85442","user":{"login":"fontforge","id":2048660,"avatar_url":"https://avatars.githubusercontent.com/u/2048660?v=2","gravatar_id":"e5f339de6842eb75dfa439127293f982","url":"https://api.github.com/users/fontforge","html_url":"https://github.com/fontforge","followers_url":"https://api.github.com/users/fontforge/followers","following_url":"https://api.github.com/users/fontforge/following{/other_user}","gists_url":"https://api.github.com/users/fontforge/gists{/gist_id}","starred_url":"https://api.github.com/users/fontforge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fontforge/subscriptions","organizations_url":"https://api.github.com/users/fontforge/orgs","repos_url":"https://api.github.com/users/fontforge/repos","events_url":"https://api.github.com/users/fontforge/events{/privacy}","received_events_url":"https://api.github.com/users/fontforge/received_events","type":"Organization","site_admin":false},"repo":{"id":5390156,"name":"fontforge","full_name":"fontforge/fontforge","owner":{"login":"fontforge","id":2048660,"avatar_url":"https://avatars.githubusercontent.com/u/2048660?v=2","gravatar_id":"e5f339de6842eb75dfa439127293f982","url":"https://api.github.com/users/fontforge","html_url":"https://github.com/fontforge","followers_url":"https://api.github.com/users/fontforge/followers","following_url":"https://api.github.com/users/fontforge/following{/other_user}","gists_url":"https://api.github.com/users/fontforge/gists{/gist_id}","starred_url":"https://api.github.com/users/fontforge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fontforge/subscriptions","organizations_url":"https://api.github.com/users/fontforge/orgs","repos_url":"https://api.github.com/users/fontforge/repos","events_url":"https://api.github.com/users/fontforge/events{/privacy}","received_events_url":"https://api.github.com/users/fontforge/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fontforge/fontforge","description":"A font editor. Old site at fontforge.org, new site at","fork":false,"url":"https://api.github.com/repos/fontforge/fontforge","forks_url":"https://api.github.com/repos/fontforge/fontforge/forks","keys_url":"https://api.github.com/repos/fontforge/fontforge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fontforge/fontforge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fontforge/fontforge/teams","hooks_url":"https://api.github.com/repos/fontforge/fontforge/hooks","issue_events_url":"https://api.github.com/repos/fontforge/fontforge/issues/events{/number}","events_url":"https://api.github.com/repos/fontforge/fontforge/events","assignees_url":"https://api.github.com/repos/fontforge/fontforge/assignees{/user}","branches_url":"https://api.github.com/repos/fontforge/fontforge/branches{/branch}","tags_url":"https://api.github.com/repos/fontforge/fontforge/tags","blobs_url":"https://api.github.com/repos/fontforge/fontforge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fontforge/fontforge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fontforge/fontforge/git/refs{/sha}","trees_url":"https://api.github.com/repos/fontforge/fontforge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fontforge/fontforge/statuses/{sha}","languages_url":"https://api.github.com/repos/fontforge/fontforge/languages","stargazers_url":"https://api.github.com/repos/fontforge/fontforge/stargazers","contributors_url":"https://api.github.com/repos/fontforge/fontforge/contributors","subscribers_url":"https://api.github.com/repos/fontforge/fontforge/subscribers","subscription_url":"https://api.github.com/repos/fontforge/fontforge/subscription","commits_url":"https://api.github.com/repos/fontforge/fontforge/commits{/sha}","git_commits_url":"https://api.github.com/repos/fontforge/fontforge/git/commits{/sha}","comments_url":"https://api.github.com/repos/fontforge/fontforge/comments{/number}","issue_comment_url":"https://api.github.com/repos/fontforge/fontforge/issues/comments/{number}","contents_url":"https://api.github.com/repos/fontforge/fontforge/contents/{+path}","compare_url":"https://api.github.com/repos/fontforge/fontforge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fontforge/fontforge/merges","archive_url":"https://api.github.com/repos/fontforge/fontforge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fontforge/fontforge/downloads","issues_url":"https://api.github.com/repos/fontforge/fontforge/issues{/number}","pulls_url":"https://api.github.com/repos/fontforge/fontforge/pulls{/number}","milestones_url":"https://api.github.com/repos/fontforge/fontforge/milestones{/number}","notifications_url":"https://api.github.com/repos/fontforge/fontforge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fontforge/fontforge/labels{/name}","releases_url":"https://api.github.com/repos/fontforge/fontforge/releases{/id}","created_at":"2012-08-12T17:08:20Z","updated_at":"2014-08-19T03:51:44Z","pushed_at":"2014-08-20T10:50:32Z","git_url":"git://github.com/fontforge/fontforge.git","ssh_url":"git@github.com:fontforge/fontforge.git","clone_url":"https://github.com/fontforge/fontforge.git","svn_url":"https://github.com/fontforge/fontforge","homepage":"http://fontforge.github.io","size":79028,"stargazers_count":215,"watchers_count":215,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":93,"mirror_url":null,"open_issues_count":398,"forks":93,"open_issues":398,"watchers":215,"default_branch":"master"}},"base":{"label":"fontforge:master","ref":"master","sha":"f89b6332cd860e18d5e81fa5a92ea9766f6da32b","user":{"login":"fontforge","id":2048660,"avatar_url":"https://avatars.githubusercontent.com/u/2048660?v=2","gravatar_id":"e5f339de6842eb75dfa439127293f982","url":"https://api.github.com/users/fontforge","html_url":"https://github.com/fontforge","followers_url":"https://api.github.com/users/fontforge/followers","following_url":"https://api.github.com/users/fontforge/following{/other_user}","gists_url":"https://api.github.com/users/fontforge/gists{/gist_id}","starred_url":"https://api.github.com/users/fontforge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fontforge/subscriptions","organizations_url":"https://api.github.com/users/fontforge/orgs","repos_url":"https://api.github.com/users/fontforge/repos","events_url":"https://api.github.com/users/fontforge/events{/privacy}","received_events_url":"https://api.github.com/users/fontforge/received_events","type":"Organization","site_admin":false},"repo":{"id":5390156,"name":"fontforge","full_name":"fontforge/fontforge","owner":{"login":"fontforge","id":2048660,"avatar_url":"https://avatars.githubusercontent.com/u/2048660?v=2","gravatar_id":"e5f339de6842eb75dfa439127293f982","url":"https://api.github.com/users/fontforge","html_url":"https://github.com/fontforge","followers_url":"https://api.github.com/users/fontforge/followers","following_url":"https://api.github.com/users/fontforge/following{/other_user}","gists_url":"https://api.github.com/users/fontforge/gists{/gist_id}","starred_url":"https://api.github.com/users/fontforge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fontforge/subscriptions","organizations_url":"https://api.github.com/users/fontforge/orgs","repos_url":"https://api.github.com/users/fontforge/repos","events_url":"https://api.github.com/users/fontforge/events{/privacy}","received_events_url":"https://api.github.com/users/fontforge/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fontforge/fontforge","description":"A font editor. Old site at fontforge.org, new site at","fork":false,"url":"https://api.github.com/repos/fontforge/fontforge","forks_url":"https://api.github.com/repos/fontforge/fontforge/forks","keys_url":"https://api.github.com/repos/fontforge/fontforge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fontforge/fontforge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fontforge/fontforge/teams","hooks_url":"https://api.github.com/repos/fontforge/fontforge/hooks","issue_events_url":"https://api.github.com/repos/fontforge/fontforge/issues/events{/number}","events_url":"https://api.github.com/repos/fontforge/fontforge/events","assignees_url":"https://api.github.com/repos/fontforge/fontforge/assignees{/user}","branches_url":"https://api.github.com/repos/fontforge/fontforge/branches{/branch}","tags_url":"https://api.github.com/repos/fontforge/fontforge/tags","blobs_url":"https://api.github.com/repos/fontforge/fontforge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fontforge/fontforge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fontforge/fontforge/git/refs{/sha}","trees_url":"https://api.github.com/repos/fontforge/fontforge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fontforge/fontforge/statuses/{sha}","languages_url":"https://api.github.com/repos/fontforge/fontforge/languages","stargazers_url":"https://api.github.com/repos/fontforge/fontforge/stargazers","contributors_url":"https://api.github.com/repos/fontforge/fontforge/contributors","subscribers_url":"https://api.github.com/repos/fontforge/fontforge/subscribers","subscription_url":"https://api.github.com/repos/fontforge/fontforge/subscription","commits_url":"https://api.github.com/repos/fontforge/fontforge/commits{/sha}","git_commits_url":"https://api.github.com/repos/fontforge/fontforge/git/commits{/sha}","comments_url":"https://api.github.com/repos/fontforge/fontforge/comments{/number}","issue_comment_url":"https://api.github.com/repos/fontforge/fontforge/issues/comments/{number}","contents_url":"https://api.github.com/repos/fontforge/fontforge/contents/{+path}","compare_url":"https://api.github.com/repos/fontforge/fontforge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fontforge/fontforge/merges","archive_url":"https://api.github.com/repos/fontforge/fontforge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fontforge/fontforge/downloads","issues_url":"https://api.github.com/repos/fontforge/fontforge/issues{/number}","pulls_url":"https://api.github.com/repos/fontforge/fontforge/pulls{/number}","milestones_url":"https://api.github.com/repos/fontforge/fontforge/milestones{/number}","notifications_url":"https://api.github.com/repos/fontforge/fontforge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fontforge/fontforge/labels{/name}","releases_url":"https://api.github.com/repos/fontforge/fontforge/releases{/id}","created_at":"2012-08-12T17:08:20Z","updated_at":"2014-08-19T03:51:44Z","pushed_at":"2014-08-20T10:50:32Z","git_url":"git://github.com/fontforge/fontforge.git","ssh_url":"git@github.com:fontforge/fontforge.git","clone_url":"https://github.com/fontforge/fontforge.git","svn_url":"https://github.com/fontforge/fontforge","homepage":"http://fontforge.github.io","size":79028,"stargazers_count":215,"watchers_count":215,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":93,"mirror_url":null,"open_issues_count":398,"forks":93,"open_issues":398,"watchers":215,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fontforge/fontforge/pulls/1664"},"html":{"href":"https://github.com/fontforge/fontforge/pull/1664"},"issue":{"href":"https://api.github.com/repos/fontforge/fontforge/issues/1664"},"comments":{"href":"https://api.github.com/repos/fontforge/fontforge/issues/1664/comments"},"review_comments":{"href":"https://api.github.com/repos/fontforge/fontforge/pulls/1664/comments"},"review_comment":{"href":"https://api.github.com/repos/fontforge/fontforge/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/fontforge/fontforge/pulls/1664/commits"},"statuses":{"href":"https://api.github.com/repos/fontforge/fontforge/statuses/552f062ce6a3e9c237fc562b96abf0cf82f85442"}}}}