GitHub PushEvent at 2014-10-29 12:21:52
Repository: openbsc
Actor: hubot
Payload: {"shas":[["7204e1533e351072c6bd1bcc2ec69e7ee7b33cb8","bc4099e8129048574af98275fa037a1c852d38db@sysmocom.de","sgsn: Reorganize and fix gsm48_gmm_authorize (TODO)\n\nCurrently the order of the 'if' clauses in gsm48_gmm_authorize\ndoesn't match the order in which the conditional parts are entered.\nThis makes it difficult to maintain. In addition the t3350_mode is\nnot stored in every path, so that this information is lost when the\nidentification procedure is started. Since the default value\ncoincidentally is GMM_T3350_MODE_ATT, this doesn't hurt for Attach\nRequests which are the only messages that initially trigger the\nauthentication yet.\n\nThis patch changes the order of the 'if' clause to match the\nprocessing order, it removes the t3350_mode parameter entirely and\nintroduces a mm->pending_req field. The latter must be set when the\nrequest that causes the authorization before calling\ngsm48_gmm_authorize. The gprs_t3350_mode enum is extended by\nGMM_T3350_MODE_NONE (value 0, which is the default) to make it\npossible to detect related initialisation errors or race conditions.\n\nTODO:\n - There isn't much defference between t3350_mode (refers to the\n   timer) and pending_req (refers to the procedure),\n   where mm->T == 3350 => mm->t3350_mode == f(mm->pending_req).\n   Check whether one of them can be dropped.\n\nSponsored-by: On-Waves ehf","Jacob Erlbeck",true],["83c100948322c788340d21b7b245ff91e632f7f4","bc4099e8129048574af98275fa037a1c852d38db@sysmocom.de","sgsn/test: Move message sending to send_0408_message\n\nThis replaces serveral occurences of duplicated code for message\ncreation and sending (passing to gsm0408_gprs_rcvmsg) into a single\nfunction. In addition, the sgsn_tx_counter is always reset within\nsend_0408_message to simplify the code that checks for the number of\nmessages sent.\n\nSponsored-by: On-Waves ehf","Jacob Erlbeck",true],["d3ecafd210344c15e8bbe26387b31b25f3d4bba1","bc4099e8129048574af98275fa037a1c852d38db@sysmocom.de","sgsn/test: Add test_gmm_attach\n\nThis test checks the attach procedure until the Attach Complete is\nreceived.\n\nNote that authorization and GMM state updates are not working\nproperly yet.\n\nSponsored-by: On-Waves ehf","Jacob Erlbeck",true],["94cda4d4b7f12a4bf77e85229c6166c469c8c89b","bc4099e8129048574af98275fa037a1c852d38db@sysmocom.de","sgsn: Cleanup GMM state transitions\n\nCurrently the GMM state is set to GMM-REGISTERED when an Attach\nAccept or a RA Update Accept message is sent, even if a new P-TMSI is\nincluded. In this case 04.08 requires (see 4.7.3.1.3 and 4.7.5.1.3),\nthat the state is set to GMM-COMMON-PROCEDURE-INITIATED when the\nAccept is sent. When the Complete is received, the SGSN shall set\nthe state to GMM-REGISTERED.\n\nThis patch modifies the state updates accordingly.\n\nSponsored-by: On-Waves ehf","Jacob Erlbeck",true],["945950a43090c058915bd11de8e8752756e5a6f0","bc4099e8129048574af98275fa037a1c852d38db@sysmocom.de","sgsn: Added TODOs (TODO)\n\nTODO:\n  - fix and remove TODOs\n  - add test cases for Detach(reattach)\n  - add test cases for PDP context deletion (OW#1311)\n  - add test cases for Fix P-TMSI generation for repeated Attach Accept\n    messages (OW#1322)\n  - add test cases for Cancel pending timer in sgsn_mm_ctx_free\n  - remove this commit\n\nSponsored-by: On-Waves ehf","Jacob Erlbeck",true],["9f69ffe32767c7bb24bdf33c4fe9acdabcc8d1ca","bc4099e8129048574af98275fa037a1c852d38db@sysmocom.de","sgsn: Make authorization asynchronous (EXPERIMENTAL)\n\nCurrently the authorization of an IMSI is done by checking ACLs from\nwithin gsm48_rx_gmm_att_req when receiving an Attach Request\ncontaining an IMSI.\n\nThis patch moves the check to gsm48_gmm_authorize, so that it is\ninitiated before the Attach Accept would be sent, but after\neventually completing the identification procedures. The\nauthorization now works by invoking the callback function\nsgsn_update_subscriber_data when such information in gathered. This\ncurrently happens directly from sgsn_auth_request() but would work\nasynchronously, too.\n\nThe change has been successfully tested with a single phone (E71).\n\nSponsored-by: On-Waves ehf","Jacob Erlbeck",true]],"size":6,"ref":"refs/heads/jerlbeck/wip/gprs-patching","head":"9f69ffe32767c7bb24bdf33c4fe9acdabcc8d1ca"}