GitHub PullRequestEvent at 2014-06-10 14:38:27
Repository: dojox
Actor: Kagetsume
Payload: {"action":"opened","number":112,"pull_request":{"url":"https://api.github.com/repos/dojo/dojox/pulls/112","id":16943519,"html_url":"https://github.com/dojo/dojox/pull/112","diff_url":"https://github.com/dojo/dojox/pull/112.diff","patch_url":"https://github.com/dojo/dojox/pull/112.patch","issue_url":"https://api.github.com/repos/dojo/dojox/issues/112","number":112,"state":"open","title":"T18078","user":{"login":"Kagetsume","id":125361,"avatar_url":"https://avatars.githubusercontent.com/u/125361?","gravatar_id":"f339bcb02c2cf6404c6f1cc6d366f6a5","url":"https://api.github.com/users/Kagetsume","html_url":"https://github.com/Kagetsume","followers_url":"https://api.github.com/users/Kagetsume/followers","following_url":"https://api.github.com/users/Kagetsume/following{/other_user}","gists_url":"https://api.github.com/users/Kagetsume/gists{/gist_id}","starred_url":"https://api.github.com/users/Kagetsume/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kagetsume/subscriptions","organizations_url":"https://api.github.com/users/Kagetsume/orgs","repos_url":"https://api.github.com/users/Kagetsume/repos","events_url":"https://api.github.com/users/Kagetsume/events{/privacy}","received_events_url":"https://api.github.com/users/Kagetsume/received_events","type":"User","site_admin":false},"body":"This is a pull request for dojo enhancement: https://bugs.dojotoolkit.org/ticket/18078.  It adds in the ability to specify different alignments for the chart title.  Originally, all the chart would do is center align a title.  This keeps that as the default, but allows for chart, or theme setting of titleAlign, which can now be: left, right, middle, edge.  The behavior is as defined:\r\nleft:  Align the title all the way to the left.\r\nright:  Align the title all the way to the right.\r\nedge:  Align the title to the edge of the plot where the axis is.\r\n\r\nAll of the above try to take into account bidi, which will generally flip them around.  left becomes right and so on.  The question I have is on edge.  In BIDI, do we mirror the axis to the right?  I assumed we do now, but I could not easily tell if it actually did that.  The current edge code assumes that too, which may not be accurate.  Please advise.\r\n","created_at":"2014-06-10T14:38:26Z","updated_at":"2014-06-10T14:38:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5e9328a0ca3cea409876f17d3baabe8947ffe745","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dojo/dojox/pulls/112/commits","review_comments_url":"https://api.github.com/repos/dojo/dojox/pulls/112/comments","review_comment_url":"https://api.github.com/repos/dojo/dojox/pulls/comments/{number}","comments_url":"https://api.github.com/repos/dojo/dojox/issues/112/comments","statuses_url":"https://api.github.com/repos/dojo/dojox/statuses/5bb2ba683f02fc5aa824b18f03b948004bdf652e","head":{"label":"Kagetsume:t18078","ref":"t18078","sha":"5bb2ba683f02fc5aa824b18f03b948004bdf652e","user":{"login":"Kagetsume","id":125361,"avatar_url":"https://avatars.githubusercontent.com/u/125361?","gravatar_id":"f339bcb02c2cf6404c6f1cc6d366f6a5","url":"https://api.github.com/users/Kagetsume","html_url":"https://github.com/Kagetsume","followers_url":"https://api.github.com/users/Kagetsume/followers","following_url":"https://api.github.com/users/Kagetsume/following{/other_user}","gists_url":"https://api.github.com/users/Kagetsume/gists{/gist_id}","starred_url":"https://api.github.com/users/Kagetsume/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kagetsume/subscriptions","organizations_url":"https://api.github.com/users/Kagetsume/orgs","repos_url":"https://api.github.com/users/Kagetsume/repos","events_url":"https://api.github.com/users/Kagetsume/events{/privacy}","received_events_url":"https://api.github.com/users/Kagetsume/received_events","type":"User","site_admin":false},"repo":{"id":20262863,"name":"dojox","full_name":"Kagetsume/dojox","owner":{"login":"Kagetsume","id":125361,"avatar_url":"https://avatars.githubusercontent.com/u/125361?","gravatar_id":"f339bcb02c2cf6404c6f1cc6d366f6a5","url":"https://api.github.com/users/Kagetsume","html_url":"https://github.com/Kagetsume","followers_url":"https://api.github.com/users/Kagetsume/followers","following_url":"https://api.github.com/users/Kagetsume/following{/other_user}","gists_url":"https://api.github.com/users/Kagetsume/gists{/gist_id}","starred_url":"https://api.github.com/users/Kagetsume/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kagetsume/subscriptions","organizations_url":"https://api.github.com/users/Kagetsume/orgs","repos_url":"https://api.github.com/users/Kagetsume/repos","events_url":"https://api.github.com/users/Kagetsume/events{/privacy}","received_events_url":"https://api.github.com/users/Kagetsume/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Kagetsume/dojox","description":"The Dojo Toolkit extras library. Please submit bugs to https://bugs.dojotoolkit.org/","fork":true,"url":"https://api.github.com/repos/Kagetsume/dojox","forks_url":"https://api.github.com/repos/Kagetsume/dojox/forks","keys_url":"https://api.github.com/repos/Kagetsume/dojox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Kagetsume/dojox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Kagetsume/dojox/teams","hooks_url":"https://api.github.com/repos/Kagetsume/dojox/hooks","issue_events_url":"https://api.github.com/repos/Kagetsume/dojox/issues/events{/number}","events_url":"https://api.github.com/repos/Kagetsume/dojox/events","assignees_url":"https://api.github.com/repos/Kagetsume/dojox/assignees{/user}","branches_url":"https://api.github.com/repos/Kagetsume/dojox/branches{/branch}","tags_url":"https://api.github.com/repos/Kagetsume/dojox/tags","blobs_url":"https://api.github.com/repos/Kagetsume/dojox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Kagetsume/dojox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Kagetsume/dojox/git/refs{/sha}","trees_url":"https://api.github.com/repos/Kagetsume/dojox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Kagetsume/dojox/statuses/{sha}","languages_url":"https://api.github.com/repos/Kagetsume/dojox/languages","stargazers_url":"https://api.github.com/repos/Kagetsume/dojox/stargazers","contributors_url":"https://api.github.com/repos/Kagetsume/dojox/contributors","subscribers_url":"https://api.github.com/repos/Kagetsume/dojox/subscribers","subscription_url":"https://api.github.com/repos/Kagetsume/dojox/subscription","commits_url":"https://api.github.com/repos/Kagetsume/dojox/commits{/sha}","git_commits_url":"https://api.github.com/repos/Kagetsume/dojox/git/commits{/sha}","comments_url":"https://api.github.com/repos/Kagetsume/dojox/comments{/number}","issue_comment_url":"https://api.github.com/repos/Kagetsume/dojox/issues/comments/{number}","contents_url":"https://api.github.com/repos/Kagetsume/dojox/contents/{+path}","compare_url":"https://api.github.com/repos/Kagetsume/dojox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Kagetsume/dojox/merges","archive_url":"https://api.github.com/repos/Kagetsume/dojox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Kagetsume/dojox/downloads","issues_url":"https://api.github.com/repos/Kagetsume/dojox/issues{/number}","pulls_url":"https://api.github.com/repos/Kagetsume/dojox/pulls{/number}","milestones_url":"https://api.github.com/repos/Kagetsume/dojox/milestones{/number}","notifications_url":"https://api.github.com/repos/Kagetsume/dojox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Kagetsume/dojox/labels{/name}","releases_url":"https://api.github.com/repos/Kagetsume/dojox/releases{/id}","created_at":"2014-05-28T15:34:48Z","updated_at":"2014-06-10T14:38:26Z","pushed_at":"2014-06-10T14:31:41Z","git_url":"git://github.com/Kagetsume/dojox.git","ssh_url":"git@github.com:Kagetsume/dojox.git","clone_url":"https://github.com/Kagetsume/dojox.git","svn_url":"https://github.com/Kagetsume/dojox","homepage":"https://dojotoolkit.org/","size":38353,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dojo:master","ref":"master","sha":"fc11ab64523ca3eb08d5eedf82b979d086b06eff","user":{"login":"dojo","id":86896,"avatar_url":"https://avatars.githubusercontent.com/u/86896?","gravatar_id":"d85dd1d75870a16a625755a1e0a1bcf0","url":"https://api.github.com/users/dojo","html_url":"https://github.com/dojo","followers_url":"https://api.github.com/users/dojo/followers","following_url":"https://api.github.com/users/dojo/following{/other_user}","gists_url":"https://api.github.com/users/dojo/gists{/gist_id}","starred_url":"https://api.github.com/users/dojo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dojo/subscriptions","organizations_url":"https://api.github.com/users/dojo/orgs","repos_url":"https://api.github.com/users/dojo/repos","events_url":"https://api.github.com/users/dojo/events{/privacy}","received_events_url":"https://api.github.com/users/dojo/received_events","type":"Organization","site_admin":false},"repo":{"id":10160535,"name":"dojox","full_name":"dojo/dojox","owner":{"login":"dojo","id":86896,"avatar_url":"https://avatars.githubusercontent.com/u/86896?","gravatar_id":"d85dd1d75870a16a625755a1e0a1bcf0","url":"https://api.github.com/users/dojo","html_url":"https://github.com/dojo","followers_url":"https://api.github.com/users/dojo/followers","following_url":"https://api.github.com/users/dojo/following{/other_user}","gists_url":"https://api.github.com/users/dojo/gists{/gist_id}","starred_url":"https://api.github.com/users/dojo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dojo/subscriptions","organizations_url":"https://api.github.com/users/dojo/orgs","repos_url":"https://api.github.com/users/dojo/repos","events_url":"https://api.github.com/users/dojo/events{/privacy}","received_events_url":"https://api.github.com/users/dojo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dojo/dojox","description":"The Dojo Toolkit extras library. Please submit bugs to https://bugs.dojotoolkit.org/","fork":false,"url":"https://api.github.com/repos/dojo/dojox","forks_url":"https://api.github.com/repos/dojo/dojox/forks","keys_url":"https://api.github.com/repos/dojo/dojox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dojo/dojox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dojo/dojox/teams","hooks_url":"https://api.github.com/repos/dojo/dojox/hooks","issue_events_url":"https://api.github.com/repos/dojo/dojox/issues/events{/number}","events_url":"https://api.github.com/repos/dojo/dojox/events","assignees_url":"https://api.github.com/repos/dojo/dojox/assignees{/user}","branches_url":"https://api.github.com/repos/dojo/dojox/branches{/branch}","tags_url":"https://api.github.com/repos/dojo/dojox/tags","blobs_url":"https://api.github.com/repos/dojo/dojox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dojo/dojox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dojo/dojox/git/refs{/sha}","trees_url":"https://api.github.com/repos/dojo/dojox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dojo/dojox/statuses/{sha}","languages_url":"https://api.github.com/repos/dojo/dojox/languages","stargazers_url":"https://api.github.com/repos/dojo/dojox/stargazers","contributors_url":"https://api.github.com/repos/dojo/dojox/contributors","subscribers_url":"https://api.github.com/repos/dojo/dojox/subscribers","subscription_url":"https://api.github.com/repos/dojo/dojox/subscription","commits_url":"https://api.github.com/repos/dojo/dojox/commits{/sha}","git_commits_url":"https://api.github.com/repos/dojo/dojox/git/commits{/sha}","comments_url":"https://api.github.com/repos/dojo/dojox/comments{/number}","issue_comment_url":"https://api.github.com/repos/dojo/dojox/issues/comments/{number}","contents_url":"https://api.github.com/repos/dojo/dojox/contents/{+path}","compare_url":"https://api.github.com/repos/dojo/dojox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dojo/dojox/merges","archive_url":"https://api.github.com/repos/dojo/dojox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dojo/dojox/downloads","issues_url":"https://api.github.com/repos/dojo/dojox/issues{/number}","pulls_url":"https://api.github.com/repos/dojo/dojox/pulls{/number}","milestones_url":"https://api.github.com/repos/dojo/dojox/milestones{/number}","notifications_url":"https://api.github.com/repos/dojo/dojox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dojo/dojox/labels{/name}","releases_url":"https://api.github.com/repos/dojo/dojox/releases{/id}","created_at":"2013-05-19T19:50:54Z","updated_at":"2014-06-06T04:09:54Z","pushed_at":"2014-06-06T04:09:55Z","git_url":"git://github.com/dojo/dojox.git","ssh_url":"git@github.com:dojo/dojox.git","clone_url":"https://github.com/dojo/dojox.git","svn_url":"https://github.com/dojo/dojox","homepage":"https://dojotoolkit.org/","size":64072,"stargazers_count":66,"watchers_count":66,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":119,"mirror_url":null,"open_issues_count":12,"forks":119,"open_issues":12,"watchers":66,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dojo/dojox/pulls/112"},"html":{"href":"https://github.com/dojo/dojox/pull/112"},"issue":{"href":"https://api.github.com/repos/dojo/dojox/issues/112"},"comments":{"href":"https://api.github.com/repos/dojo/dojox/issues/112/comments"},"review_comments":{"href":"https://api.github.com/repos/dojo/dojox/pulls/112/comments"},"review_comment":{"href":"https://api.github.com/repos/dojo/dojox/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/dojo/dojox/pulls/112/commits"},"statuses":{"href":"https://api.github.com/repos/dojo/dojox/statuses/5bb2ba683f02fc5aa824b18f03b948004bdf652e"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":116,"deletions":13,"changed_files":2}}