GitHub PullRequestReviewCommentEvent at 2014-04-26 11:44:30
Repository: active_merchant
Actor: kanishkdudeja
Payload: {"comment":{"url":"https://api.github.com/repos/Shopify/active_merchant/pulls/comments/12024146","id":12024146,"diff_hunk":"@@ -0,0 +1,47 @@\n+require File.dirname(__FILE__) + '/mobikwikwallet/helper.rb'\n+require File.dirname(__FILE__) + '/mobikwikwallet/notification.rb'\n+require File.dirname(__FILE__) + '/mobikwikwallet/return.rb'\n+\n+module ActiveMerchant #:nodoc:\n+  module Billing #:nodoc:\n+    module Integrations #:nodoc:\n+      module Mobikwikwallet\n+\n+        mattr_accessor :live_url\n+        mattr_accessor :test_url\n+        \n+        self.live_url = 'https://www.mobikwik.com/wallet'\n+\n+        self.test_url = 'https://test.mobikwik.com/mobikwik/wallet'\n+\n+        def self.credential_based_url(options)","path":"lib/active_merchant/billing/integrations/mobikwikwallet.rb","position":17,"original_position":17,"commit_id":"5a1a6574e7d7125ac8953fa8b25f1b81859598a0","original_commit_id":"1e7e8e75c4dd39ec3e7c4ca4b9902c9ed2ecc559","user":{"login":"kanishkdudeja","id":3773215,"avatar_url":"https://avatars.githubusercontent.com/u/3773215?","gravatar_id":"ec67acf34b8db41f1828b6426d2bcc50","url":"https://api.github.com/users/kanishkdudeja","html_url":"https://github.com/kanishkdudeja","followers_url":"https://api.github.com/users/kanishkdudeja/followers","following_url":"https://api.github.com/users/kanishkdudeja/following{/other_user}","gists_url":"https://api.github.com/users/kanishkdudeja/gists{/gist_id}","starred_url":"https://api.github.com/users/kanishkdudeja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kanishkdudeja/subscriptions","organizations_url":"https://api.github.com/users/kanishkdudeja/orgs","repos_url":"https://api.github.com/users/kanishkdudeja/repos","events_url":"https://api.github.com/users/kanishkdudeja/events{/privacy}","received_events_url":"https://api.github.com/users/kanishkdudeja/received_events","type":"User","site_admin":false},"body":"Could you point me to a sample where i can see the implementation of self.service_url. Actually we needed another parameter :credential5 for setting the mode(test or live). Depending upon the value of credential5(test or live), i wanted to set the corresponding url. After seeing samples from other gateways, we implemented it the same way. I hope the switching between live and testing functionality would be managed my Shopify itself? Or will we need to manage it from the code?","created_at":"2014-04-26T11:44:30Z","updated_at":"2014-04-26T11:44:30Z","html_url":"https://github.com/Shopify/active_merchant/pull/1106#discussion_r12024146","pull_request_url":"https://api.github.com/repos/Shopify/active_merchant/pulls/1106","_links":{"self":{"href":"https://api.github.com/repos/Shopify/active_merchant/pulls/comments/12024146"},"html":{"href":"https://github.com/Shopify/active_merchant/pull/1106#discussion_r12024146"},"pull_request":{"href":"https://api.github.com/repos/Shopify/active_merchant/pulls/1106"}}}}