GitHub PullRequestReviewCommentEvent at 2014-09-17 17:12:22
Repository: OpenMS
Actor: cbielow
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/OpenMS/OpenMS/pulls/comments/17678228","id":17678228,"diff_hunk":"@@ -0,0 +1,131 @@\n+// --------------------------------------------------------------------------\n+//                   OpenMS -- Open-Source Mass Spectrometry\n+// --------------------------------------------------------------------------\n+// Copyright The OpenMS Team -- Eberhard Karls University Tuebingen,\n+// ETH Zurich, and Freie Universitaet Berlin 2002-2013.\n+//\n+// This software is released under a three-clause BSD license:\n+//  * Redistributions of source code must retain the above copyright\n+//    notice, this list of conditions and the following disclaimer.\n+//  * Redistributions in binary form must reproduce the above copyright\n+//    notice, this list of conditions and the following disclaimer in the\n+//    documentation and/or other materials provided with the distribution.\n+//  * Neither the name of any author or any participating institution\n+//    may be used to endorse or promote products derived from this software\n+//    without specific prior written permission.\n+// For a full list of authors, refer to the file AUTHORS.\n+// --------------------------------------------------------------------------\n+// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS \"AS IS\"\n+// AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE\n+// IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE\n+// ARE DISCLAIMED. IN NO EVENT SHALL ANY OF THE AUTHORS OR THE CONTRIBUTING\n+// INSTITUTIONS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,\n+// EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,\n+// PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS;\n+// OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY,\n+// WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR\n+// OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF\n+// ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.\n+//\n+// --------------------------------------------------------------------------\n+// $Maintainer: Timo Sachsenberg $\n+// $Authors: Stephan Aiche, Timo Sachsenberg $\n+// --------------------------------------------------------------------------\n+\n+#ifndef OPENMS_MATH_MISC_BSPLINE2D_H\n+#define OPENMS_MATH_MISC_BSPLINE2D_H\n+\n+#include <vector>\n+\n+#include <OpenMS/config.h>\n+#include <OpenMS/KERNEL/StandardTypes.h>\n+\n+// forward declaration of impl class BSpline\n+template <class T>\n+struct BSpline;\n+\n+namespace OpenMS\n+{\n+  /**\n+   * @brief b spline interpolation\n+   */\n+  class OPENMS_DLLAPI BSpline2d\n+  {\n+public:\n+    \n+    // Note: Don't change boundary coniditon constants ase these are passed through to the eol-bspline implementation.","path":"src/openms/include/OpenMS/MATH/MISC/BSpline2d.h","position":56,"original_position":56,"commit_id":"63fbba0decb78307528b30aa85c407d629a0b130","original_commit_id":"8b0065765ad9238d86a64ee807a89e054b5c2a2c","user":{"login":"cbielow","id":6008722,"avatar_url":"https://avatars.githubusercontent.com/u/6008722?v=2","gravatar_id":"8124e946c8f2119319525d0c5188483b","url":"https://api.github.com/users/cbielow","html_url":"https://github.com/cbielow","followers_url":"https://api.github.com/users/cbielow/followers","following_url":"https://api.github.com/users/cbielow/following{/other_user}","gists_url":"https://api.github.com/users/cbielow/gists{/gist_id}","starred_url":"https://api.github.com/users/cbielow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbielow/subscriptions","organizations_url":"https://api.github.com/users/cbielow/orgs","repos_url":"https://api.github.com/users/cbielow/repos","events_url":"https://api.github.com/users/cbielow/events{/privacy}","received_events_url":"https://api.github.com/users/cbielow/received_events","type":"User","site_admin":false},"body":"i second that","created_at":"2014-09-17T17:12:22Z","updated_at":"2014-09-17T17:12:22Z","html_url":"https://github.com/OpenMS/OpenMS/pull/985#discussion_r17678228","pull_request_url":"https://api.github.com/repos/OpenMS/OpenMS/pulls/985","_links":{"self":{"href":"https://api.github.com/repos/OpenMS/OpenMS/pulls/comments/17678228"},"html":{"href":"https://github.com/OpenMS/OpenMS/pull/985#discussion_r17678228"},"pull_request":{"href":"https://api.github.com/repos/OpenMS/OpenMS/pulls/985"}}},"pull_request":{"url":"https://api.github.com/repos/OpenMS/OpenMS/pulls/985","id":21034309,"html_url":"https://github.com/OpenMS/OpenMS/pull/985","diff_url":"https://github.com/OpenMS/OpenMS/pull/985.diff","patch_url":"https://github.com/OpenMS/OpenMS/pull/985.patch","issue_url":"https://api.github.com/repos/OpenMS/OpenMS/issues/985","number":985,"state":"open","locked":false,"title":"[FEATURE] bspline support using eol bsplines implementation","user":{"login":"aiche","id":878705,"avatar_url":"https://avatars.githubusercontent.com/u/878705?v=2","gravatar_id":"283c8bf4042d462becc9a621c0a8f9ea","url":"https://api.github.com/users/aiche","html_url":"https://github.com/aiche","followers_url":"https://api.github.com/users/aiche/followers","following_url":"https://api.github.com/users/aiche/following{/other_user}","gists_url":"https://api.github.com/users/aiche/gists{/gist_id}","starred_url":"https://api.github.com/users/aiche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aiche/subscriptions","organizations_url":"https://api.github.com/users/aiche/orgs","repos_url":"https://api.github.com/users/aiche/repos","events_url":"https://api.github.com/users/aiche/events{/privacy}","received_events_url":"https://api.github.com/users/aiche/received_events","type":"User","site_admin":false},"body":"This pull request adds a BSpline implementation based on the ell-eol-spline library. The library (a handful c and h files) is added as 3rd party lib to OpenMS (see below).  The library itself is header only, so no special care has to be taken w.r.t. building it. \r\n\r\nThis pull requests actually introduces also a new concept to the build system to include smaller libraries in `openms/3rdparty` instead of adding them to the contrib. Here we have direct control over the build system inside the OpenMS build system. No need for a find_package(XX) and special care in the contrib. This mechanism should be  used for special purpose sub-libs like eol-bspline, numpress, or the ims stuff. The later two would have to be ported out of the OpenMS code. This also enforces the necessary separation between code we **use** and code we **develop**.\r\n\r\nThe bspline implementation is required to reintroduce the `TransformationModelBSpline` removed during the GSL cleanup. The only modification of the bspline code is contained in 8b0065765ad9238d86a64ee807a89e054b5c2a2c and fixes an issue with llvm/clang compilers (see http://clang.llvm.org/compatibility.html#dep_lookup_bases for details).\r\n\r\nAlso contains an unrelated commit fixing the mac os x install docu.","created_at":"2014-09-10T16:52:41Z","updated_at":"2014-09-17T17:12:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"865cb3b23bc43cde952fb1a704fbc16155f8f950","assignee":null,"milestone":{"url":"https://api.github.com/repos/OpenMS/OpenMS/milestones/2","labels_url":"https://api.github.com/repos/OpenMS/OpenMS/milestones/2/labels","id":531141,"number":2,"title":"Release 1.12","description":null,"creator":{"login":"timosachsenberg","id":5803621,"avatar_url":"https://avatars.githubusercontent.com/u/5803621?v=2","gravatar_id":"90803618cbf5c28fb98924d3c96a5b59","url":"https://api.github.com/users/timosachsenberg","html_url":"https://github.com/timosachsenberg","followers_url":"https://api.github.com/users/timosachsenberg/followers","following_url":"https://api.github.com/users/timosachsenberg/following{/other_user}","gists_url":"https://api.github.com/users/timosachsenberg/gists{/gist_id}","starred_url":"https://api.github.com/users/timosachsenberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timosachsenberg/subscriptions","organizations_url":"https://api.github.com/users/timosachsenberg/orgs","repos_url":"https://api.github.com/users/timosachsenberg/repos","events_url":"https://api.github.com/users/timosachsenberg/events{/privacy}","received_events_url":"https://api.github.com/users/timosachsenberg/received_events","type":"User","site_admin":false},"open_issues":67,"closed_issues":221,"state":"open","created_at":"2014-01-09T10:32:00Z","updated_at":"2014-09-17T08:06:29Z","due_on":null},"commits_url":"https://api.github.com/repos/OpenMS/OpenMS/pulls/985/commits","review_comments_url":"https://api.github.com/repos/OpenMS/OpenMS/pulls/985/comments","review_comment_url":"https://api.github.com/repos/OpenMS/OpenMS/pulls/comments/{number}","comments_url":"https://api.github.com/repos/OpenMS/OpenMS/issues/985/comments","statuses_url":"https://api.github.com/repos/OpenMS/OpenMS/statuses/63fbba0decb78307528b30aa85c407d629a0b130","head":{"label":"aiche:feature/eol-bsplines","ref":"feature/eol-bsplines","sha":"63fbba0decb78307528b30aa85c407d629a0b130","user":{"login":"aiche","id":878705,"avatar_url":"https://avatars.githubusercontent.com/u/878705?v=2","gravatar_id":"283c8bf4042d462becc9a621c0a8f9ea","url":"https://api.github.com/users/aiche","html_url":"https://github.com/aiche","followers_url":"https://api.github.com/users/aiche/followers","following_url":"https://api.github.com/users/aiche/following{/other_user}","gists_url":"https://api.github.com/users/aiche/gists{/gist_id}","starred_url":"https://api.github.com/users/aiche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aiche/subscriptions","organizations_url":"https://api.github.com/users/aiche/orgs","repos_url":"https://api.github.com/users/aiche/repos","events_url":"https://api.github.com/users/aiche/events{/privacy}","received_events_url":"https://api.github.com/users/aiche/received_events","type":"User","site_admin":false},"repo":{"id":15794969,"name":"OpenMS","full_name":"aiche/OpenMS","owner":{"login":"aiche","id":878705,"avatar_url":"https://avatars.githubusercontent.com/u/878705?v=2","gravatar_id":"283c8bf4042d462becc9a621c0a8f9ea","url":"https://api.github.com/users/aiche","html_url":"https://github.com/aiche","followers_url":"https://api.github.com/users/aiche/followers","following_url":"https://api.github.com/users/aiche/following{/other_user}","gists_url":"https://api.github.com/users/aiche/gists{/gist_id}","starred_url":"https://api.github.com/users/aiche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aiche/subscriptions","organizations_url":"https://api.github.com/users/aiche/orgs","repos_url":"https://api.github.com/users/aiche/repos","events_url":"https://api.github.com/users/aiche/events{/privacy}","received_events_url":"https://api.github.com/users/aiche/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aiche/OpenMS","description":"The codebase of the OpenMS project","fork":true,"url":"https://api.github.com/repos/aiche/OpenMS","forks_url":"https://api.github.com/repos/aiche/OpenMS/forks","keys_url":"https://api.github.com/repos/aiche/OpenMS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aiche/OpenMS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aiche/OpenMS/teams","hooks_url":"https://api.github.com/repos/aiche/OpenMS/hooks","issue_events_url":"https://api.github.com/repos/aiche/OpenMS/issues/events{/number}","events_url":"https://api.github.com/repos/aiche/OpenMS/events","assignees_url":"https://api.github.com/repos/aiche/OpenMS/assignees{/user}","branches_url":"https://api.github.com/repos/aiche/OpenMS/branches{/branch}","tags_url":"https://api.github.com/repos/aiche/OpenMS/tags","blobs_url":"https://api.github.com/repos/aiche/OpenMS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aiche/OpenMS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aiche/OpenMS/git/refs{/sha}","trees_url":"https://api.github.com/repos/aiche/OpenMS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aiche/OpenMS/statuses/{sha}","languages_url":"https://api.github.com/repos/aiche/OpenMS/languages","stargazers_url":"https://api.github.com/repos/aiche/OpenMS/stargazers","contributors_url":"https://api.github.com/repos/aiche/OpenMS/contributors","subscribers_url":"https://api.github.com/repos/aiche/OpenMS/subscribers","subscription_url":"https://api.github.com/repos/aiche/OpenMS/subscription","commits_url":"https://api.github.com/repos/aiche/OpenMS/commits{/sha}","git_commits_url":"https://api.github.com/repos/aiche/OpenMS/git/commits{/sha}","comments_url":"https://api.github.com/repos/aiche/OpenMS/comments{/number}","issue_comment_url":"https://api.github.com/repos/aiche/OpenMS/issues/comments/{number}","contents_url":"https://api.github.com/repos/aiche/OpenMS/contents/{+path}","compare_url":"https://api.github.com/repos/aiche/OpenMS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aiche/OpenMS/merges","archive_url":"https://api.github.com/repos/aiche/OpenMS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aiche/OpenMS/downloads","issues_url":"https://api.github.com/repos/aiche/OpenMS/issues{/number}","pulls_url":"https://api.github.com/repos/aiche/OpenMS/pulls{/number}","milestones_url":"https://api.github.com/repos/aiche/OpenMS/milestones{/number}","notifications_url":"https://api.github.com/repos/aiche/OpenMS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aiche/OpenMS/labels{/name}","releases_url":"https://api.github.com/repos/aiche/OpenMS/releases{/id}","created_at":"2014-01-10T10:21:04Z","updated_at":"2014-08-28T12:37:21Z","pushed_at":"2014-09-17T16:31:15Z","git_url":"git://github.com/aiche/OpenMS.git","ssh_url":"git@github.com:aiche/OpenMS.git","clone_url":"https://github.com/aiche/OpenMS.git","svn_url":"https://github.com/aiche/OpenMS","homepage":null,"size":188322,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"base":{"label":"OpenMS:develop","ref":"develop","sha":"d8dac15caaf38f04a45c09b2a1b059f6902743c8","user":{"login":"OpenMS","id":5994841,"avatar_url":"https://avatars.githubusercontent.com/u/5994841?v=2","gravatar_id":"1ba1d6b33d51d3417c547886349804ae","url":"https://api.github.com/users/OpenMS","html_url":"https://github.com/OpenMS","followers_url":"https://api.github.com/users/OpenMS/followers","following_url":"https://api.github.com/users/OpenMS/following{/other_user}","gists_url":"https://api.github.com/users/OpenMS/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenMS/subscriptions","organizations_url":"https://api.github.com/users/OpenMS/orgs","repos_url":"https://api.github.com/users/OpenMS/repos","events_url":"https://api.github.com/users/OpenMS/events{/privacy}","received_events_url":"https://api.github.com/users/OpenMS/received_events","type":"Organization","site_admin":false},"repo":{"id":15763403,"name":"OpenMS","full_name":"OpenMS/OpenMS","owner":{"login":"OpenMS","id":5994841,"avatar_url":"https://avatars.githubusercontent.com/u/5994841?v=2","gravatar_id":"1ba1d6b33d51d3417c547886349804ae","url":"https://api.github.com/users/OpenMS","html_url":"https://github.com/OpenMS","followers_url":"https://api.github.com/users/OpenMS/followers","following_url":"https://api.github.com/users/OpenMS/following{/other_user}","gists_url":"https://api.github.com/users/OpenMS/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenMS/subscriptions","organizations_url":"https://api.github.com/users/OpenMS/orgs","repos_url":"https://api.github.com/users/OpenMS/repos","events_url":"https://api.github.com/users/OpenMS/events{/privacy}","received_events_url":"https://api.github.com/users/OpenMS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenMS/OpenMS","description":"The codebase of the OpenMS project","fork":false,"url":"https://api.github.com/repos/OpenMS/OpenMS","forks_url":"https://api.github.com/repos/OpenMS/OpenMS/forks","keys_url":"https://api.github.com/repos/OpenMS/OpenMS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenMS/OpenMS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenMS/OpenMS/teams","hooks_url":"https://api.github.com/repos/OpenMS/OpenMS/hooks","issue_events_url":"https://api.github.com/repos/OpenMS/OpenMS/issues/events{/number}","events_url":"https://api.github.com/repos/OpenMS/OpenMS/events","assignees_url":"https://api.github.com/repos/OpenMS/OpenMS/assignees{/user}","branches_url":"https://api.github.com/repos/OpenMS/OpenMS/branches{/branch}","tags_url":"https://api.github.com/repos/OpenMS/OpenMS/tags","blobs_url":"https://api.github.com/repos/OpenMS/OpenMS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenMS/OpenMS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenMS/OpenMS/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenMS/OpenMS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenMS/OpenMS/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenMS/OpenMS/languages","stargazers_url":"https://api.github.com/repos/OpenMS/OpenMS/stargazers","contributors_url":"https://api.github.com/repos/OpenMS/OpenMS/contributors","subscribers_url":"https://api.github.com/repos/OpenMS/OpenMS/subscribers","subscription_url":"https://api.github.com/repos/OpenMS/OpenMS/subscription","commits_url":"https://api.github.com/repos/OpenMS/OpenMS/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenMS/OpenMS/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenMS/OpenMS/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenMS/OpenMS/issues/comments/{number}","contents_url":"https://api.github.com/repos/OpenMS/OpenMS/contents/{+path}","compare_url":"https://api.github.com/repos/OpenMS/OpenMS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenMS/OpenMS/merges","archive_url":"https://api.github.com/repos/OpenMS/OpenMS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenMS/OpenMS/downloads","issues_url":"https://api.github.com/repos/OpenMS/OpenMS/issues{/number}","pulls_url":"https://api.github.com/repos/OpenMS/OpenMS/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenMS/OpenMS/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenMS/OpenMS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenMS/OpenMS/labels{/name}","releases_url":"https://api.github.com/repos/OpenMS/OpenMS/releases{/id}","created_at":"2014-01-09T10:15:13Z","updated_at":"2014-09-11T11:13:48Z","pushed_at":"2014-09-17T08:06:29Z","git_url":"git://github.com/OpenMS/OpenMS.git","ssh_url":"git@github.com:OpenMS/OpenMS.git","clone_url":"https://github.com/OpenMS/OpenMS.git","svn_url":"https://github.com/OpenMS/OpenMS","homepage":null,"size":209224,"stargazers_count":17,"watchers_count":17,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":36,"mirror_url":null,"open_issues_count":229,"forks":36,"open_issues":229,"watchers":17,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenMS/OpenMS/pulls/985"},"html":{"href":"https://github.com/OpenMS/OpenMS/pull/985"},"issue":{"href":"https://api.github.com/repos/OpenMS/OpenMS/issues/985"},"comments":{"href":"https://api.github.com/repos/OpenMS/OpenMS/issues/985/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenMS/OpenMS/pulls/985/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenMS/OpenMS/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/OpenMS/OpenMS/pulls/985/commits"},"statuses":{"href":"https://api.github.com/repos/OpenMS/OpenMS/statuses/63fbba0decb78307528b30aa85c407d629a0b130"}}}}