GitHub PullRequestEvent at 2014-10-07 07:41:28
Repository: foreman
Actor: ohadlevy
Payload: {"action":"closed","number":1825,"pull_request":{"url":"https://api.github.com/repos/theforeman/foreman/pulls/1825","id":22333778,"html_url":"https://github.com/theforeman/foreman/pull/1825","diff_url":"https://github.com/theforeman/foreman/pull/1825.diff","patch_url":"https://github.com/theforeman/foreman/pull/1825.patch","issue_url":"https://api.github.com/repos/theforeman/foreman/issues/1825","number":1825,"state":"closed","locked":false,"title":"Refs #3809 - Use parentheses in method definitions","user":{"login":"eLobato","id":598891,"avatar_url":"https://avatars.githubusercontent.com/u/598891?v=2","gravatar_id":"","url":"https://api.github.com/users/eLobato","html_url":"https://github.com/eLobato","followers_url":"https://api.github.com/users/eLobato/followers","following_url":"https://api.github.com/users/eLobato/following{/other_user}","gists_url":"https://api.github.com/users/eLobato/gists{/gist_id}","starred_url":"https://api.github.com/users/eLobato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eLobato/subscriptions","organizations_url":"https://api.github.com/users/eLobato/orgs","repos_url":"https://api.github.com/users/eLobato/repos","events_url":"https://api.github.com/users/eLobato/events{/privacy}","received_events_url":"https://api.github.com/users/eLobato/received_events","type":"User","site_admin":false},"body":"This was done in a minute with --auto-correct, it just adds parentheses to method definitions with parameters to comply with the standard, ```def method(parameter, parameter)```","created_at":"2014-10-07T06:55:11Z","updated_at":"2014-10-07T07:41:27Z","closed_at":"2014-10-07T07:41:27Z","merged_at":null,"merge_commit_sha":"dbdb899c6705f1d29e896bbc82ceea72d559925b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/theforeman/foreman/pulls/1825/commits","review_comments_url":"https://api.github.com/repos/theforeman/foreman/pulls/1825/comments","review_comment_url":"https://api.github.com/repos/theforeman/foreman/pulls/comments/{number}","comments_url":"https://api.github.com/repos/theforeman/foreman/issues/1825/comments","statuses_url":"https://api.github.com/repos/theforeman/foreman/statuses/5f5f3b22523162f7c9fd84b87fbefb867744d03c","head":{"label":"eLobato:defs","ref":"defs","sha":"5f5f3b22523162f7c9fd84b87fbefb867744d03c","user":{"login":"eLobato","id":598891,"avatar_url":"https://avatars.githubusercontent.com/u/598891?v=2","gravatar_id":"","url":"https://api.github.com/users/eLobato","html_url":"https://github.com/eLobato","followers_url":"https://api.github.com/users/eLobato/followers","following_url":"https://api.github.com/users/eLobato/following{/other_user}","gists_url":"https://api.github.com/users/eLobato/gists{/gist_id}","starred_url":"https://api.github.com/users/eLobato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eLobato/subscriptions","organizations_url":"https://api.github.com/users/eLobato/orgs","repos_url":"https://api.github.com/users/eLobato/repos","events_url":"https://api.github.com/users/eLobato/events{/privacy}","received_events_url":"https://api.github.com/users/eLobato/received_events","type":"User","site_admin":false},"repo":{"id":5842097,"name":"foreman","full_name":"eLobato/foreman","owner":{"login":"eLobato","id":598891,"avatar_url":"https://avatars.githubusercontent.com/u/598891?v=2","gravatar_id":"","url":"https://api.github.com/users/eLobato","html_url":"https://github.com/eLobato","followers_url":"https://api.github.com/users/eLobato/followers","following_url":"https://api.github.com/users/eLobato/following{/other_user}","gists_url":"https://api.github.com/users/eLobato/gists{/gist_id}","starred_url":"https://api.github.com/users/eLobato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eLobato/subscriptions","organizations_url":"https://api.github.com/users/eLobato/orgs","repos_url":"https://api.github.com/users/eLobato/repos","events_url":"https://api.github.com/users/eLobato/events{/privacy}","received_events_url":"https://api.github.com/users/eLobato/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eLobato/foreman","description":"an application that automates the lifecycle of servers ","fork":true,"url":"https://api.github.com/repos/eLobato/foreman","forks_url":"https://api.github.com/repos/eLobato/foreman/forks","keys_url":"https://api.github.com/repos/eLobato/foreman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eLobato/foreman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eLobato/foreman/teams","hooks_url":"https://api.github.com/repos/eLobato/foreman/hooks","issue_events_url":"https://api.github.com/repos/eLobato/foreman/issues/events{/number}","events_url":"https://api.github.com/repos/eLobato/foreman/events","assignees_url":"https://api.github.com/repos/eLobato/foreman/assignees{/user}","branches_url":"https://api.github.com/repos/eLobato/foreman/branches{/branch}","tags_url":"https://api.github.com/repos/eLobato/foreman/tags","blobs_url":"https://api.github.com/repos/eLobato/foreman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eLobato/foreman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eLobato/foreman/git/refs{/sha}","trees_url":"https://api.github.com/repos/eLobato/foreman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eLobato/foreman/statuses/{sha}","languages_url":"https://api.github.com/repos/eLobato/foreman/languages","stargazers_url":"https://api.github.com/repos/eLobato/foreman/stargazers","contributors_url":"https://api.github.com/repos/eLobato/foreman/contributors","subscribers_url":"https://api.github.com/repos/eLobato/foreman/subscribers","subscription_url":"https://api.github.com/repos/eLobato/foreman/subscription","commits_url":"https://api.github.com/repos/eLobato/foreman/commits{/sha}","git_commits_url":"https://api.github.com/repos/eLobato/foreman/git/commits{/sha}","comments_url":"https://api.github.com/repos/eLobato/foreman/comments{/number}","issue_comment_url":"https://api.github.com/repos/eLobato/foreman/issues/comments/{number}","contents_url":"https://api.github.com/repos/eLobato/foreman/contents/{+path}","compare_url":"https://api.github.com/repos/eLobato/foreman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eLobato/foreman/merges","archive_url":"https://api.github.com/repos/eLobato/foreman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eLobato/foreman/downloads","issues_url":"https://api.github.com/repos/eLobato/foreman/issues{/number}","pulls_url":"https://api.github.com/repos/eLobato/foreman/pulls{/number}","milestones_url":"https://api.github.com/repos/eLobato/foreman/milestones{/number}","notifications_url":"https://api.github.com/repos/eLobato/foreman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eLobato/foreman/labels{/name}","releases_url":"https://api.github.com/repos/eLobato/foreman/releases{/id}","created_at":"2012-09-17T14:23:49Z","updated_at":"2014-08-11T21:39:19Z","pushed_at":"2014-10-07T06:58:21Z","git_url":"git://github.com/eLobato/foreman.git","ssh_url":"git@github.com:eLobato/foreman.git","clone_url":"https://github.com/eLobato/foreman.git","svn_url":"https://github.com/eLobato/foreman","homepage":"http://theforeman.org","size":23238,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"develop"}},"base":{"label":"theforeman:develop","ref":"develop","sha":"19abc86f7f7416e0a2f437285f6679841b4d6dea","user":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars.githubusercontent.com/u/1439844?v=2","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"repo":{"id":258750,"name":"foreman","full_name":"theforeman/foreman","owner":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars.githubusercontent.com/u/1439844?v=2","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/theforeman/foreman","description":"an application that automates the lifecycle of servers ","fork":false,"url":"https://api.github.com/repos/theforeman/foreman","forks_url":"https://api.github.com/repos/theforeman/foreman/forks","keys_url":"https://api.github.com/repos/theforeman/foreman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theforeman/foreman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theforeman/foreman/teams","hooks_url":"https://api.github.com/repos/theforeman/foreman/hooks","issue_events_url":"https://api.github.com/repos/theforeman/foreman/issues/events{/number}","events_url":"https://api.github.com/repos/theforeman/foreman/events","assignees_url":"https://api.github.com/repos/theforeman/foreman/assignees{/user}","branches_url":"https://api.github.com/repos/theforeman/foreman/branches{/branch}","tags_url":"https://api.github.com/repos/theforeman/foreman/tags","blobs_url":"https://api.github.com/repos/theforeman/foreman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theforeman/foreman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theforeman/foreman/git/refs{/sha}","trees_url":"https://api.github.com/repos/theforeman/foreman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theforeman/foreman/statuses/{sha}","languages_url":"https://api.github.com/repos/theforeman/foreman/languages","stargazers_url":"https://api.github.com/repos/theforeman/foreman/stargazers","contributors_url":"https://api.github.com/repos/theforeman/foreman/contributors","subscribers_url":"https://api.github.com/repos/theforeman/foreman/subscribers","subscription_url":"https://api.github.com/repos/theforeman/foreman/subscription","commits_url":"https://api.github.com/repos/theforeman/foreman/commits{/sha}","git_commits_url":"https://api.github.com/repos/theforeman/foreman/git/commits{/sha}","comments_url":"https://api.github.com/repos/theforeman/foreman/comments{/number}","issue_comment_url":"https://api.github.com/repos/theforeman/foreman/issues/comments/{number}","contents_url":"https://api.github.com/repos/theforeman/foreman/contents/{+path}","compare_url":"https://api.github.com/repos/theforeman/foreman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theforeman/foreman/merges","archive_url":"https://api.github.com/repos/theforeman/foreman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theforeman/foreman/downloads","issues_url":"https://api.github.com/repos/theforeman/foreman/issues{/number}","pulls_url":"https://api.github.com/repos/theforeman/foreman/pulls{/number}","milestones_url":"https://api.github.com/repos/theforeman/foreman/milestones{/number}","notifications_url":"https://api.github.com/repos/theforeman/foreman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theforeman/foreman/labels{/name}","releases_url":"https://api.github.com/repos/theforeman/foreman/releases{/id}","created_at":"2009-07-23T15:07:00Z","updated_at":"2014-10-06T18:52:26Z","pushed_at":"2014-10-07T07:41:19Z","git_url":"git://github.com/theforeman/foreman.git","ssh_url":"git@github.com:theforeman/foreman.git","clone_url":"https://github.com/theforeman/foreman.git","svn_url":"https://github.com/theforeman/foreman","homepage":"http://theforeman.org","size":64852,"stargazers_count":550,"watchers_count":550,"language":"Ruby","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":305,"mirror_url":null,"open_issues_count":46,"forks":305,"open_issues":46,"watchers":550,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/1825"},"html":{"href":"https://github.com/theforeman/foreman/pull/1825"},"issue":{"href":"https://api.github.com/repos/theforeman/foreman/issues/1825"},"comments":{"href":"https://api.github.com/repos/theforeman/foreman/issues/1825/comments"},"review_comments":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/1825/comments"},"review_comment":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/1825/commits"},"statuses":{"href":"https://api.github.com/repos/theforeman/foreman/statuses/5f5f3b22523162f7c9fd84b87fbefb867744d03c"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":2,"review_comments":0,"commits":1,"additions":417,"deletions":423,"changed_files":136}}