GitHub PullRequestReviewCommentEvent at 2014-09-10 14:10:01
Repository: yast-registration
Actor: mvidner
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/yast/yast-registration/pulls/comments/17362525","id":17362525,"diff_hunk":"@@ -79,6 +79,15 @@ def upgrade_product(product)\n       end\n     end\n \n+    # @param [String] target_distro new target distribution\n+    # @return [OpenStruct] SCC response\n+    def update_system(target_distro = nil)","path":"src/lib/registration/registration.rb","position":6,"original_position":6,"commit_id":"53b4a989641aabb66f072f4f98b19da2087301e0","original_commit_id":"53b4a989641aabb66f072f4f98b19da2087301e0","user":{"login":"mvidner","id":102056,"avatar_url":"https://avatars.githubusercontent.com/u/102056?v=2","gravatar_id":"cb3d39e1fb6fabb5f916885b6154623a","url":"https://api.github.com/users/mvidner","html_url":"https://github.com/mvidner","followers_url":"https://api.github.com/users/mvidner/followers","following_url":"https://api.github.com/users/mvidner/following{/other_user}","gists_url":"https://api.github.com/users/mvidner/gists{/gist_id}","starred_url":"https://api.github.com/users/mvidner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mvidner/subscriptions","organizations_url":"https://api.github.com/users/mvidner/orgs","repos_url":"https://api.github.com/users/mvidner/repos","events_url":"https://api.github.com/users/mvidner/events{/privacy}","received_events_url":"https://api.github.com/users/mvidner/received_events","type":"User","site_admin":false},"body":"Why allow nil? IIUC that case is not used.","created_at":"2014-09-10T14:10:01Z","updated_at":"2014-09-10T14:10:01Z","html_url":"https://github.com/yast/yast-registration/pull/164#discussion_r17362525","pull_request_url":"https://api.github.com/repos/yast/yast-registration/pulls/164","_links":{"self":{"href":"https://api.github.com/repos/yast/yast-registration/pulls/comments/17362525"},"html":{"href":"https://github.com/yast/yast-registration/pull/164#discussion_r17362525"},"pull_request":{"href":"https://api.github.com/repos/yast/yast-registration/pulls/164"}}},"pull_request":{"url":"https://api.github.com/repos/yast/yast-registration/pulls/164","id":21019772,"html_url":"https://github.com/yast/yast-registration/pull/164","diff_url":"https://github.com/yast/yast-registration/pull/164.diff","patch_url":"https://github.com/yast/yast-registration/pull/164.patch","issue_url":"https://api.github.com/repos/yast/yast-registration/issues/164","number":164,"state":"open","locked":false,"title":"Set the new target distro value at update (bnc#889778) ","user":{"login":"lslezak","id":907998,"avatar_url":"https://avatars.githubusercontent.com/u/907998?v=2","gravatar_id":"654c5b4f0d657240edff9440a901839b","url":"https://api.github.com/users/lslezak","html_url":"https://github.com/lslezak","followers_url":"https://api.github.com/users/lslezak/followers","following_url":"https://api.github.com/users/lslezak/following{/other_user}","gists_url":"https://api.github.com/users/lslezak/gists{/gist_id}","starred_url":"https://api.github.com/users/lslezak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lslezak/subscriptions","organizations_url":"https://api.github.com/users/lslezak/orgs","repos_url":"https://api.github.com/users/lslezak/repos","events_url":"https://api.github.com/users/lslezak/events{/privacy}","received_events_url":"https://api.github.com/users/lslezak/received_events","type":"User","site_admin":false},"body":"- tested in regular SLES11 update via SCC\r\n- @jsrain tested update using a SMT instance\r\n","created_at":"2014-09-10T13:21:42Z","updated_at":"2014-09-10T14:10:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a8915acf9992f0ca53d02cb57658ae642f852928","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/yast/yast-registration/pulls/164/commits","review_comments_url":"https://api.github.com/repos/yast/yast-registration/pulls/164/comments","review_comment_url":"https://api.github.com/repos/yast/yast-registration/pulls/comments/{number}","comments_url":"https://api.github.com/repos/yast/yast-registration/issues/164/comments","statuses_url":"https://api.github.com/repos/yast/yast-registration/statuses/53b4a989641aabb66f072f4f98b19da2087301e0","head":{"label":"yast:system_upgrade","ref":"system_upgrade","sha":"53b4a989641aabb66f072f4f98b19da2087301e0","user":{"login":"yast","id":909990,"avatar_url":"https://avatars.githubusercontent.com/u/909990?v=2","gravatar_id":"e467a14202136d0b384e7b8ce386d6d5","url":"https://api.github.com/users/yast","html_url":"https://github.com/yast","followers_url":"https://api.github.com/users/yast/followers","following_url":"https://api.github.com/users/yast/following{/other_user}","gists_url":"https://api.github.com/users/yast/gists{/gist_id}","starred_url":"https://api.github.com/users/yast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yast/subscriptions","organizations_url":"https://api.github.com/users/yast/orgs","repos_url":"https://api.github.com/users/yast/repos","events_url":"https://api.github.com/users/yast/events{/privacy}","received_events_url":"https://api.github.com/users/yast/received_events","type":"Organization","site_admin":false},"repo":{"id":4368197,"name":"yast-registration","full_name":"yast/yast-registration","owner":{"login":"yast","id":909990,"avatar_url":"https://avatars.githubusercontent.com/u/909990?v=2","gravatar_id":"e467a14202136d0b384e7b8ce386d6d5","url":"https://api.github.com/users/yast","html_url":"https://github.com/yast","followers_url":"https://api.github.com/users/yast/followers","following_url":"https://api.github.com/users/yast/following{/other_user}","gists_url":"https://api.github.com/users/yast/gists{/gist_id}","starred_url":"https://api.github.com/users/yast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yast/subscriptions","organizations_url":"https://api.github.com/users/yast/orgs","repos_url":"https://api.github.com/users/yast/repos","events_url":"https://api.github.com/users/yast/events{/privacy}","received_events_url":"https://api.github.com/users/yast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yast/yast-registration","description":"YaST module registration","fork":false,"url":"https://api.github.com/repos/yast/yast-registration","forks_url":"https://api.github.com/repos/yast/yast-registration/forks","keys_url":"https://api.github.com/repos/yast/yast-registration/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yast/yast-registration/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yast/yast-registration/teams","hooks_url":"https://api.github.com/repos/yast/yast-registration/hooks","issue_events_url":"https://api.github.com/repos/yast/yast-registration/issues/events{/number}","events_url":"https://api.github.com/repos/yast/yast-registration/events","assignees_url":"https://api.github.com/repos/yast/yast-registration/assignees{/user}","branches_url":"https://api.github.com/repos/yast/yast-registration/branches{/branch}","tags_url":"https://api.github.com/repos/yast/yast-registration/tags","blobs_url":"https://api.github.com/repos/yast/yast-registration/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yast/yast-registration/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yast/yast-registration/git/refs{/sha}","trees_url":"https://api.github.com/repos/yast/yast-registration/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yast/yast-registration/statuses/{sha}","languages_url":"https://api.github.com/repos/yast/yast-registration/languages","stargazers_url":"https://api.github.com/repos/yast/yast-registration/stargazers","contributors_url":"https://api.github.com/repos/yast/yast-registration/contributors","subscribers_url":"https://api.github.com/repos/yast/yast-registration/subscribers","subscription_url":"https://api.github.com/repos/yast/yast-registration/subscription","commits_url":"https://api.github.com/repos/yast/yast-registration/commits{/sha}","git_commits_url":"https://api.github.com/repos/yast/yast-registration/git/commits{/sha}","comments_url":"https://api.github.com/repos/yast/yast-registration/comments{/number}","issue_comment_url":"https://api.github.com/repos/yast/yast-registration/issues/comments/{number}","contents_url":"https://api.github.com/repos/yast/yast-registration/contents/{+path}","compare_url":"https://api.github.com/repos/yast/yast-registration/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yast/yast-registration/merges","archive_url":"https://api.github.com/repos/yast/yast-registration/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yast/yast-registration/downloads","issues_url":"https://api.github.com/repos/yast/yast-registration/issues{/number}","pulls_url":"https://api.github.com/repos/yast/yast-registration/pulls{/number}","milestones_url":"https://api.github.com/repos/yast/yast-registration/milestones{/number}","notifications_url":"https://api.github.com/repos/yast/yast-registration/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yast/yast-registration/labels{/name}","releases_url":"https://api.github.com/repos/yast/yast-registration/releases{/id}","created_at":"2012-05-18T10:25:55Z","updated_at":"2014-09-03T07:47:49Z","pushed_at":"2014-09-10T13:48:08Z","git_url":"git://github.com/yast/yast-registration.git","ssh_url":"git@github.com:yast/yast-registration.git","clone_url":"https://github.com/yast/yast-registration.git","svn_url":"https://github.com/yast/yast-registration","homepage":"http://en.opensuse.org/Portal:YaST","size":11297,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":6,"mirror_url":null,"open_issues_count":2,"forks":6,"open_issues":2,"watchers":2,"default_branch":"master"}},"base":{"label":"yast:master","ref":"master","sha":"72b389f78d56d03019ebc692d189c5adad2915cf","user":{"login":"yast","id":909990,"avatar_url":"https://avatars.githubusercontent.com/u/909990?v=2","gravatar_id":"e467a14202136d0b384e7b8ce386d6d5","url":"https://api.github.com/users/yast","html_url":"https://github.com/yast","followers_url":"https://api.github.com/users/yast/followers","following_url":"https://api.github.com/users/yast/following{/other_user}","gists_url":"https://api.github.com/users/yast/gists{/gist_id}","starred_url":"https://api.github.com/users/yast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yast/subscriptions","organizations_url":"https://api.github.com/users/yast/orgs","repos_url":"https://api.github.com/users/yast/repos","events_url":"https://api.github.com/users/yast/events{/privacy}","received_events_url":"https://api.github.com/users/yast/received_events","type":"Organization","site_admin":false},"repo":{"id":4368197,"name":"yast-registration","full_name":"yast/yast-registration","owner":{"login":"yast","id":909990,"avatar_url":"https://avatars.githubusercontent.com/u/909990?v=2","gravatar_id":"e467a14202136d0b384e7b8ce386d6d5","url":"https://api.github.com/users/yast","html_url":"https://github.com/yast","followers_url":"https://api.github.com/users/yast/followers","following_url":"https://api.github.com/users/yast/following{/other_user}","gists_url":"https://api.github.com/users/yast/gists{/gist_id}","starred_url":"https://api.github.com/users/yast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yast/subscriptions","organizations_url":"https://api.github.com/users/yast/orgs","repos_url":"https://api.github.com/users/yast/repos","events_url":"https://api.github.com/users/yast/events{/privacy}","received_events_url":"https://api.github.com/users/yast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yast/yast-registration","description":"YaST module registration","fork":false,"url":"https://api.github.com/repos/yast/yast-registration","forks_url":"https://api.github.com/repos/yast/yast-registration/forks","keys_url":"https://api.github.com/repos/yast/yast-registration/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yast/yast-registration/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yast/yast-registration/teams","hooks_url":"https://api.github.com/repos/yast/yast-registration/hooks","issue_events_url":"https://api.github.com/repos/yast/yast-registration/issues/events{/number}","events_url":"https://api.github.com/repos/yast/yast-registration/events","assignees_url":"https://api.github.com/repos/yast/yast-registration/assignees{/user}","branches_url":"https://api.github.com/repos/yast/yast-registration/branches{/branch}","tags_url":"https://api.github.com/repos/yast/yast-registration/tags","blobs_url":"https://api.github.com/repos/yast/yast-registration/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yast/yast-registration/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yast/yast-registration/git/refs{/sha}","trees_url":"https://api.github.com/repos/yast/yast-registration/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yast/yast-registration/statuses/{sha}","languages_url":"https://api.github.com/repos/yast/yast-registration/languages","stargazers_url":"https://api.github.com/repos/yast/yast-registration/stargazers","contributors_url":"https://api.github.com/repos/yast/yast-registration/contributors","subscribers_url":"https://api.github.com/repos/yast/yast-registration/subscribers","subscription_url":"https://api.github.com/repos/yast/yast-registration/subscription","commits_url":"https://api.github.com/repos/yast/yast-registration/commits{/sha}","git_commits_url":"https://api.github.com/repos/yast/yast-registration/git/commits{/sha}","comments_url":"https://api.github.com/repos/yast/yast-registration/comments{/number}","issue_comment_url":"https://api.github.com/repos/yast/yast-registration/issues/comments/{number}","contents_url":"https://api.github.com/repos/yast/yast-registration/contents/{+path}","compare_url":"https://api.github.com/repos/yast/yast-registration/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yast/yast-registration/merges","archive_url":"https://api.github.com/repos/yast/yast-registration/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yast/yast-registration/downloads","issues_url":"https://api.github.com/repos/yast/yast-registration/issues{/number}","pulls_url":"https://api.github.com/repos/yast/yast-registration/pulls{/number}","milestones_url":"https://api.github.com/repos/yast/yast-registration/milestones{/number}","notifications_url":"https://api.github.com/repos/yast/yast-registration/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yast/yast-registration/labels{/name}","releases_url":"https://api.github.com/repos/yast/yast-registration/releases{/id}","created_at":"2012-05-18T10:25:55Z","updated_at":"2014-09-03T07:47:49Z","pushed_at":"2014-09-10T13:48:08Z","git_url":"git://github.com/yast/yast-registration.git","ssh_url":"git@github.com:yast/yast-registration.git","clone_url":"https://github.com/yast/yast-registration.git","svn_url":"https://github.com/yast/yast-registration","homepage":"http://en.opensuse.org/Portal:YaST","size":11297,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":6,"mirror_url":null,"open_issues_count":2,"forks":6,"open_issues":2,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yast/yast-registration/pulls/164"},"html":{"href":"https://github.com/yast/yast-registration/pull/164"},"issue":{"href":"https://api.github.com/repos/yast/yast-registration/issues/164"},"comments":{"href":"https://api.github.com/repos/yast/yast-registration/issues/164/comments"},"review_comments":{"href":"https://api.github.com/repos/yast/yast-registration/pulls/164/comments"},"review_comment":{"href":"https://api.github.com/repos/yast/yast-registration/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/yast/yast-registration/pulls/164/commits"},"statuses":{"href":"https://api.github.com/repos/yast/yast-registration/statuses/53b4a989641aabb66f072f4f98b19da2087301e0"}}}}