GitHub PullRequestReviewCommentEvent at 2014-05-29 06:09:23
Repository: urllib3
Actor: shazow
Payload: {"comment":{"url":"https://api.github.com/repos/shazow/urllib3/pulls/comments/13170210","id":13170210,"diff_hunk":"@@ -80,41 +81,53 @@ def test_invalid_host(self):\n             self.assertRaises(LocationParseError, get_host, location)\n \n \n-    def test_parse_url(self):\n-        url_host_map = {\n-            'http://google.com/mail': Url('http', host='google.com', path='/mail'),\n-            'http://google.com/mail/': Url('http', host='google.com', path='/mail/'),\n-            'google.com/mail': Url(host='google.com', path='/mail'),\n-            'http://google.com/': Url('http', host='google.com', path='/'),\n-            'http://google.com': Url('http', host='google.com'),\n-            'http://google.com?foo': Url('http', host='google.com', path='', query='foo'),\n-\n-            # Path/query/fragment\n-            '': Url(),\n-            '/': Url(path='/'),\n-            '?': Url(path='', query=''),\n-            '#': Url(path='', fragment=''),\n-            '#?/!google.com/?foo#bar': Url(path='', fragment='?/!google.com/?foo#bar'),\n-            '/foo': Url(path='/foo'),\n-            '/foo?bar=baz': Url(path='/foo', query='bar=baz'),\n-            '/foo?bar=baz#banana?apple/orange': Url(path='/foo', query='bar=baz', fragment='banana?apple/orange'),\n-\n-            # Port\n-            'http://google.com/': Url('http', host='google.com', path='/'),\n-            'http://google.com:80/': Url('http', host='google.com', port=80, path='/'),\n-            'http://google.com:/': Url('http', host='google.com', path='/'),\n-            'http://google.com:80': Url('http', host='google.com', port=80),\n-            'http://google.com:': Url('http', host='google.com'),\n-\n-            # Auth\n-            'http://foo:bar@localhost/': Url('http', auth='foo:bar', host='localhost', path='/'),\n-            'http://foo@localhost/': Url('http', auth='foo', host='localhost', path='/'),\n-            'http://foo:bar@baz@localhost/': Url('http', auth='foo:bar@baz', host='localhost', path='/'),\n-            'http://@': Url('http', host=None, auth='')\n+    parse_url_host_map = {","path":"test/test_util.py","position":43,"original_position":43,"commit_id":"559ae6a997def336e07665c98819e4ece5422200","original_commit_id":"559ae6a997def336e07665c98819e4ece5422200","user":{"login":"shazow","id":6292,"avatar_url":"https://avatars.githubusercontent.com/u/6292?","gravatar_id":"c355dd26a5f80e1605d2ff1ecb6e719e","url":"https://api.github.com/users/shazow","html_url":"https://github.com/shazow","followers_url":"https://api.github.com/users/shazow/followers","following_url":"https://api.github.com/users/shazow/following{/other_user}","gists_url":"https://api.github.com/users/shazow/gists{/gist_id}","starred_url":"https://api.github.com/users/shazow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shazow/subscriptions","organizations_url":"https://api.github.com/users/shazow/orgs","repos_url":"https://api.github.com/users/shazow/repos","events_url":"https://api.github.com/users/shazow/events{/privacy}","received_events_url":"https://api.github.com/users/shazow/received_events","type":"User","site_admin":false},"body":"Would be handy to add a couple unicode tests, too. Not necessarily this PR though.","created_at":"2014-05-29T06:09:23Z","updated_at":"2014-05-29T06:09:23Z","html_url":"https://github.com/shazow/urllib3/pull/394#discussion_r13170210","pull_request_url":"https://api.github.com/repos/shazow/urllib3/pulls/394","_links":{"self":{"href":"https://api.github.com/repos/shazow/urllib3/pulls/comments/13170210"},"html":{"href":"https://github.com/shazow/urllib3/pull/394#discussion_r13170210"},"pull_request":{"href":"https://api.github.com/repos/shazow/urllib3/pulls/394"}}}}