GitHub PullRequestEvent at 2014-09-03 22:50:26
Repository: sourcemod
Actor: psychonic
Payload: {"action":"closed","number":147,"pull_request":{"url":"https://api.github.com/repos/alliedmodders/sourcemod/pulls/147","id":20650185,"html_url":"https://github.com/alliedmodders/sourcemod/pull/147","diff_url":"https://github.com/alliedmodders/sourcemod/pull/147.diff","patch_url":"https://github.com/alliedmodders/sourcemod/pull/147.patch","issue_url":"https://api.github.com/repos/alliedmodders/sourcemod/issues/147","number":147,"state":"closed","locked":false,"title":"Expose explicit client auth string formats","user":{"login":"psychonic","id":844118,"avatar_url":"https://avatars.githubusercontent.com/u/844118?v=2","gravatar_id":"b2bb3d2861fa59314f1f3c00e757384d","url":"https://api.github.com/users/psychonic","html_url":"https://github.com/psychonic","followers_url":"https://api.github.com/users/psychonic/followers","following_url":"https://api.github.com/users/psychonic/following{/other_user}","gists_url":"https://api.github.com/users/psychonic/gists{/gist_id}","starred_url":"https://api.github.com/users/psychonic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psychonic/subscriptions","organizations_url":"https://api.github.com/users/psychonic/orgs","repos_url":"https://api.github.com/users/psychonic/repos","events_url":"https://api.github.com/users/psychonic/events{/privacy}","received_events_url":"https://api.github.com/users/psychonic/received_events","type":"User","site_admin":false},"body":"This PR changes GetClientAuthString to act similar to the version in the 1.6-dev branch, deprecates it, and adds a new GetClientAuthString2 to allow explicit specification of the format wanted.\r\n\r\nThe reason for going with a new native is to not affect existing code (including blindly-recompiled code) while being able to keep a sane default (explicit rather than assumed Steam2). Additionally, it gives us the luxury of reordering params to be a bit saner.","created_at":"2014-09-03T00:50:48Z","updated_at":"2014-09-03T22:50:24Z","closed_at":"2014-09-03T22:50:24Z","merged_at":"2014-09-03T22:50:24Z","merge_commit_sha":"80140651a1c56ee49e88966e01458a6bac777db5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/alliedmodders/sourcemod/pulls/147/commits","review_comments_url":"https://api.github.com/repos/alliedmodders/sourcemod/pulls/147/comments","review_comment_url":"https://api.github.com/repos/alliedmodders/sourcemod/pulls/comments/{number}","comments_url":"https://api.github.com/repos/alliedmodders/sourcemod/issues/147/comments","statuses_url":"https://api.github.com/repos/alliedmodders/sourcemod/statuses/7f3656215bb0cecf8d0a5830c063e2644ce29e46","head":{"label":"alliedmodders:new-auth","ref":"new-auth","sha":"7f3656215bb0cecf8d0a5830c063e2644ce29e46","user":{"login":"alliedmodders","id":6601917,"avatar_url":"https://avatars.githubusercontent.com/u/6601917?v=2","gravatar_id":"11566bc03570c46e75fd6a784535f7c8","url":"https://api.github.com/users/alliedmodders","html_url":"https://github.com/alliedmodders","followers_url":"https://api.github.com/users/alliedmodders/followers","following_url":"https://api.github.com/users/alliedmodders/following{/other_user}","gists_url":"https://api.github.com/users/alliedmodders/gists{/gist_id}","starred_url":"https://api.github.com/users/alliedmodders/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alliedmodders/subscriptions","organizations_url":"https://api.github.com/users/alliedmodders/orgs","repos_url":"https://api.github.com/users/alliedmodders/repos","events_url":"https://api.github.com/users/alliedmodders/events{/privacy}","received_events_url":"https://api.github.com/users/alliedmodders/received_events","type":"Organization","site_admin":false},"repo":{"id":20145274,"name":"sourcemod","full_name":"alliedmodders/sourcemod","owner":{"login":"alliedmodders","id":6601917,"avatar_url":"https://avatars.githubusercontent.com/u/6601917?v=2","gravatar_id":"11566bc03570c46e75fd6a784535f7c8","url":"https://api.github.com/users/alliedmodders","html_url":"https://github.com/alliedmodders","followers_url":"https://api.github.com/users/alliedmodders/followers","following_url":"https://api.github.com/users/alliedmodders/following{/other_user}","gists_url":"https://api.github.com/users/alliedmodders/gists{/gist_id}","starred_url":"https://api.github.com/users/alliedmodders/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alliedmodders/subscriptions","organizations_url":"https://api.github.com/users/alliedmodders/orgs","repos_url":"https://api.github.com/users/alliedmodders/repos","events_url":"https://api.github.com/users/alliedmodders/events{/privacy}","received_events_url":"https://api.github.com/users/alliedmodders/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alliedmodders/sourcemod","description":"SourceMod - Source Engine Scripting and Administration","fork":false,"url":"https://api.github.com/repos/alliedmodders/sourcemod","forks_url":"https://api.github.com/repos/alliedmodders/sourcemod/forks","keys_url":"https://api.github.com/repos/alliedmodders/sourcemod/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alliedmodders/sourcemod/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alliedmodders/sourcemod/teams","hooks_url":"https://api.github.com/repos/alliedmodders/sourcemod/hooks","issue_events_url":"https://api.github.com/repos/alliedmodders/sourcemod/issues/events{/number}","events_url":"https://api.github.com/repos/alliedmodders/sourcemod/events","assignees_url":"https://api.github.com/repos/alliedmodders/sourcemod/assignees{/user}","branches_url":"https://api.github.com/repos/alliedmodders/sourcemod/branches{/branch}","tags_url":"https://api.github.com/repos/alliedmodders/sourcemod/tags","blobs_url":"https://api.github.com/repos/alliedmodders/sourcemod/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alliedmodders/sourcemod/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alliedmodders/sourcemod/git/refs{/sha}","trees_url":"https://api.github.com/repos/alliedmodders/sourcemod/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alliedmodders/sourcemod/statuses/{sha}","languages_url":"https://api.github.com/repos/alliedmodders/sourcemod/languages","stargazers_url":"https://api.github.com/repos/alliedmodders/sourcemod/stargazers","contributors_url":"https://api.github.com/repos/alliedmodders/sourcemod/contributors","subscribers_url":"https://api.github.com/repos/alliedmodders/sourcemod/subscribers","subscription_url":"https://api.github.com/repos/alliedmodders/sourcemod/subscription","commits_url":"https://api.github.com/repos/alliedmodders/sourcemod/commits{/sha}","git_commits_url":"https://api.github.com/repos/alliedmodders/sourcemod/git/commits{/sha}","comments_url":"https://api.github.com/repos/alliedmodders/sourcemod/comments{/number}","issue_comment_url":"https://api.github.com/repos/alliedmodders/sourcemod/issues/comments/{number}","contents_url":"https://api.github.com/repos/alliedmodders/sourcemod/contents/{+path}","compare_url":"https://api.github.com/repos/alliedmodders/sourcemod/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alliedmodders/sourcemod/merges","archive_url":"https://api.github.com/repos/alliedmodders/sourcemod/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alliedmodders/sourcemod/downloads","issues_url":"https://api.github.com/repos/alliedmodders/sourcemod/issues{/number}","pulls_url":"https://api.github.com/repos/alliedmodders/sourcemod/pulls{/number}","milestones_url":"https://api.github.com/repos/alliedmodders/sourcemod/milestones{/number}","notifications_url":"https://api.github.com/repos/alliedmodders/sourcemod/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alliedmodders/sourcemod/labels{/name}","releases_url":"https://api.github.com/repos/alliedmodders/sourcemod/releases{/id}","created_at":"2014-05-25T02:58:39Z","updated_at":"2014-09-02T23:10:51Z","pushed_at":"2014-09-03T22:50:25Z","git_url":"git://github.com/alliedmodders/sourcemod.git","ssh_url":"git@github.com:alliedmodders/sourcemod.git","clone_url":"https://github.com/alliedmodders/sourcemod.git","svn_url":"https://github.com/alliedmodders/sourcemod","homepage":"http://www.sourcemod.net/","size":43712,"stargazers_count":64,"watchers_count":64,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":20,"mirror_url":null,"open_issues_count":13,"forks":20,"open_issues":13,"watchers":64,"default_branch":"master"}},"base":{"label":"alliedmodders:master","ref":"master","sha":"e9e35979a4e24c72c1eb08f8620d2ff40eee1bf6","user":{"login":"alliedmodders","id":6601917,"avatar_url":"https://avatars.githubusercontent.com/u/6601917?v=2","gravatar_id":"11566bc03570c46e75fd6a784535f7c8","url":"https://api.github.com/users/alliedmodders","html_url":"https://github.com/alliedmodders","followers_url":"https://api.github.com/users/alliedmodders/followers","following_url":"https://api.github.com/users/alliedmodders/following{/other_user}","gists_url":"https://api.github.com/users/alliedmodders/gists{/gist_id}","starred_url":"https://api.github.com/users/alliedmodders/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alliedmodders/subscriptions","organizations_url":"https://api.github.com/users/alliedmodders/orgs","repos_url":"https://api.github.com/users/alliedmodders/repos","events_url":"https://api.github.com/users/alliedmodders/events{/privacy}","received_events_url":"https://api.github.com/users/alliedmodders/received_events","type":"Organization","site_admin":false},"repo":{"id":20145274,"name":"sourcemod","full_name":"alliedmodders/sourcemod","owner":{"login":"alliedmodders","id":6601917,"avatar_url":"https://avatars.githubusercontent.com/u/6601917?v=2","gravatar_id":"11566bc03570c46e75fd6a784535f7c8","url":"https://api.github.com/users/alliedmodders","html_url":"https://github.com/alliedmodders","followers_url":"https://api.github.com/users/alliedmodders/followers","following_url":"https://api.github.com/users/alliedmodders/following{/other_user}","gists_url":"https://api.github.com/users/alliedmodders/gists{/gist_id}","starred_url":"https://api.github.com/users/alliedmodders/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alliedmodders/subscriptions","organizations_url":"https://api.github.com/users/alliedmodders/orgs","repos_url":"https://api.github.com/users/alliedmodders/repos","events_url":"https://api.github.com/users/alliedmodders/events{/privacy}","received_events_url":"https://api.github.com/users/alliedmodders/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alliedmodders/sourcemod","description":"SourceMod - Source Engine Scripting and Administration","fork":false,"url":"https://api.github.com/repos/alliedmodders/sourcemod","forks_url":"https://api.github.com/repos/alliedmodders/sourcemod/forks","keys_url":"https://api.github.com/repos/alliedmodders/sourcemod/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alliedmodders/sourcemod/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alliedmodders/sourcemod/teams","hooks_url":"https://api.github.com/repos/alliedmodders/sourcemod/hooks","issue_events_url":"https://api.github.com/repos/alliedmodders/sourcemod/issues/events{/number}","events_url":"https://api.github.com/repos/alliedmodders/sourcemod/events","assignees_url":"https://api.github.com/repos/alliedmodders/sourcemod/assignees{/user}","branches_url":"https://api.github.com/repos/alliedmodders/sourcemod/branches{/branch}","tags_url":"https://api.github.com/repos/alliedmodders/sourcemod/tags","blobs_url":"https://api.github.com/repos/alliedmodders/sourcemod/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alliedmodders/sourcemod/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alliedmodders/sourcemod/git/refs{/sha}","trees_url":"https://api.github.com/repos/alliedmodders/sourcemod/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alliedmodders/sourcemod/statuses/{sha}","languages_url":"https://api.github.com/repos/alliedmodders/sourcemod/languages","stargazers_url":"https://api.github.com/repos/alliedmodders/sourcemod/stargazers","contributors_url":"https://api.github.com/repos/alliedmodders/sourcemod/contributors","subscribers_url":"https://api.github.com/repos/alliedmodders/sourcemod/subscribers","subscription_url":"https://api.github.com/repos/alliedmodders/sourcemod/subscription","commits_url":"https://api.github.com/repos/alliedmodders/sourcemod/commits{/sha}","git_commits_url":"https://api.github.com/repos/alliedmodders/sourcemod/git/commits{/sha}","comments_url":"https://api.github.com/repos/alliedmodders/sourcemod/comments{/number}","issue_comment_url":"https://api.github.com/repos/alliedmodders/sourcemod/issues/comments/{number}","contents_url":"https://api.github.com/repos/alliedmodders/sourcemod/contents/{+path}","compare_url":"https://api.github.com/repos/alliedmodders/sourcemod/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alliedmodders/sourcemod/merges","archive_url":"https://api.github.com/repos/alliedmodders/sourcemod/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alliedmodders/sourcemod/downloads","issues_url":"https://api.github.com/repos/alliedmodders/sourcemod/issues{/number}","pulls_url":"https://api.github.com/repos/alliedmodders/sourcemod/pulls{/number}","milestones_url":"https://api.github.com/repos/alliedmodders/sourcemod/milestones{/number}","notifications_url":"https://api.github.com/repos/alliedmodders/sourcemod/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alliedmodders/sourcemod/labels{/name}","releases_url":"https://api.github.com/repos/alliedmodders/sourcemod/releases{/id}","created_at":"2014-05-25T02:58:39Z","updated_at":"2014-09-02T23:10:51Z","pushed_at":"2014-09-03T22:50:25Z","git_url":"git://github.com/alliedmodders/sourcemod.git","ssh_url":"git@github.com:alliedmodders/sourcemod.git","clone_url":"https://github.com/alliedmodders/sourcemod.git","svn_url":"https://github.com/alliedmodders/sourcemod","homepage":"http://www.sourcemod.net/","size":43712,"stargazers_count":64,"watchers_count":64,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":20,"mirror_url":null,"open_issues_count":13,"forks":20,"open_issues":13,"watchers":64,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alliedmodders/sourcemod/pulls/147"},"html":{"href":"https://github.com/alliedmodders/sourcemod/pull/147"},"issue":{"href":"https://api.github.com/repos/alliedmodders/sourcemod/issues/147"},"comments":{"href":"https://api.github.com/repos/alliedmodders/sourcemod/issues/147/comments"},"review_comments":{"href":"https://api.github.com/repos/alliedmodders/sourcemod/pulls/147/comments"},"review_comment":{"href":"https://api.github.com/repos/alliedmodders/sourcemod/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/alliedmodders/sourcemod/pulls/147/commits"},"statuses":{"href":"https://api.github.com/repos/alliedmodders/sourcemod/statuses/7f3656215bb0cecf8d0a5830c063e2644ce29e46"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"psychonic","id":844118,"avatar_url":"https://avatars.githubusercontent.com/u/844118?v=2","gravatar_id":"b2bb3d2861fa59314f1f3c00e757384d","url":"https://api.github.com/users/psychonic","html_url":"https://github.com/psychonic","followers_url":"https://api.github.com/users/psychonic/followers","following_url":"https://api.github.com/users/psychonic/following{/other_user}","gists_url":"https://api.github.com/users/psychonic/gists{/gist_id}","starred_url":"https://api.github.com/users/psychonic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psychonic/subscriptions","organizations_url":"https://api.github.com/users/psychonic/orgs","repos_url":"https://api.github.com/users/psychonic/repos","events_url":"https://api.github.com/users/psychonic/events{/privacy}","received_events_url":"https://api.github.com/users/psychonic/received_events","type":"User","site_admin":false},"comments":3,"review_comments":1,"commits":7,"additions":243,"deletions":28,"changed_files":13}}