GitHub PullRequestEvent at 2014-10-07 13:18:52
Repository: homebrew-cask
Actor: rolandwalker
Payload: {"action":"opened","number":6530,"pull_request":{"url":"https://api.github.com/repos/caskroom/homebrew-cask/pulls/6530","id":22351502,"html_url":"https://github.com/caskroom/homebrew-cask/pull/6530","diff_url":"https://github.com/caskroom/homebrew-cask/pull/6530.diff","patch_url":"https://github.com/caskroom/homebrew-cask/pull/6530.patch","issue_url":"https://api.github.com/repos/caskroom/homebrew-cask/issues/6530","number":6530,"state":"open","locked":false,"title":"reformat maintenance.rb, provide `else` in `if`","user":{"login":"rolandwalker","id":727482,"avatar_url":"https://avatars.githubusercontent.com/u/727482?v=2","gravatar_id":"","url":"https://api.github.com/users/rolandwalker","html_url":"https://github.com/rolandwalker","followers_url":"https://api.github.com/users/rolandwalker/followers","following_url":"https://api.github.com/users/rolandwalker/following{/other_user}","gists_url":"https://api.github.com/users/rolandwalker/gists{/gist_id}","starred_url":"https://api.github.com/users/rolandwalker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rolandwalker/subscriptions","organizations_url":"https://api.github.com/users/rolandwalker/orgs","repos_url":"https://api.github.com/users/rolandwalker/repos","events_url":"https://api.github.com/users/rolandwalker/events{/privacy}","received_events_url":"https://api.github.com/users/rolandwalker/received_events","type":"User","site_admin":false},"body":"Per [CASK_LANGUAGE_REFERENCE.md](https://github.com/caskroom/homebrew-cask/blob/master/doc/CASK_LANGUAGE_REFERENCE.md#always-fall-through-to-the-newest-case) an `if` should have an `else`.\r\n\r\nThis Cask is an unusual case, as the vendor has a different version for every OS revision.  So, it is likely that a Yosemite user does not want to download the Mavericks version of the software, as this `else` directs.\r\n\r\nHowever, we bump up against a limitation of our code here: leaving the `url` field blank is illegal in the DSL. Any command which merely *evaluated* this Cask would die under Yosemite, because the `url` field would be empty.\r\n\r\nA better resolution would be to accept `:unknown` in the `url` field (see #5248).  We should consider accepting `:unknown` for all stanzas in anticipation of such corner cases.\r\n\r\ncc @alexcruice","created_at":"2014-10-07T13:18:51Z","updated_at":"2014-10-07T13:18:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/caskroom/homebrew-cask/pulls/6530/commits","review_comments_url":"https://api.github.com/repos/caskroom/homebrew-cask/pulls/6530/comments","review_comment_url":"https://api.github.com/repos/caskroom/homebrew-cask/pulls/comments/{number}","comments_url":"https://api.github.com/repos/caskroom/homebrew-cask/issues/6530/comments","statuses_url":"https://api.github.com/repos/caskroom/homebrew-cask/statuses/98474d84eea4c65feadc394e096b61b55e95eab9","head":{"label":"rolandwalker:reformat_maintenance","ref":"reformat_maintenance","sha":"98474d84eea4c65feadc394e096b61b55e95eab9","user":{"login":"rolandwalker","id":727482,"avatar_url":"https://avatars.githubusercontent.com/u/727482?v=2","gravatar_id":"","url":"https://api.github.com/users/rolandwalker","html_url":"https://github.com/rolandwalker","followers_url":"https://api.github.com/users/rolandwalker/followers","following_url":"https://api.github.com/users/rolandwalker/following{/other_user}","gists_url":"https://api.github.com/users/rolandwalker/gists{/gist_id}","starred_url":"https://api.github.com/users/rolandwalker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rolandwalker/subscriptions","organizations_url":"https://api.github.com/users/rolandwalker/orgs","repos_url":"https://api.github.com/users/rolandwalker/repos","events_url":"https://api.github.com/users/rolandwalker/events{/privacy}","received_events_url":"https://api.github.com/users/rolandwalker/received_events","type":"User","site_admin":false},"repo":{"id":14505203,"name":"homebrew-cask","full_name":"rolandwalker/homebrew-cask","owner":{"login":"rolandwalker","id":727482,"avatar_url":"https://avatars.githubusercontent.com/u/727482?v=2","gravatar_id":"","url":"https://api.github.com/users/rolandwalker","html_url":"https://github.com/rolandwalker","followers_url":"https://api.github.com/users/rolandwalker/followers","following_url":"https://api.github.com/users/rolandwalker/following{/other_user}","gists_url":"https://api.github.com/users/rolandwalker/gists{/gist_id}","starred_url":"https://api.github.com/users/rolandwalker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rolandwalker/subscriptions","organizations_url":"https://api.github.com/users/rolandwalker/orgs","repos_url":"https://api.github.com/users/rolandwalker/repos","events_url":"https://api.github.com/users/rolandwalker/events{/privacy}","received_events_url":"https://api.github.com/users/rolandwalker/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rolandwalker/homebrew-cask","description":"a friendly homebrew-style CLI workflow for the administration of Mac applications distributed as binaries","fork":true,"url":"https://api.github.com/repos/rolandwalker/homebrew-cask","forks_url":"https://api.github.com/repos/rolandwalker/homebrew-cask/forks","keys_url":"https://api.github.com/repos/rolandwalker/homebrew-cask/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rolandwalker/homebrew-cask/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rolandwalker/homebrew-cask/teams","hooks_url":"https://api.github.com/repos/rolandwalker/homebrew-cask/hooks","issue_events_url":"https://api.github.com/repos/rolandwalker/homebrew-cask/issues/events{/number}","events_url":"https://api.github.com/repos/rolandwalker/homebrew-cask/events","assignees_url":"https://api.github.com/repos/rolandwalker/homebrew-cask/assignees{/user}","branches_url":"https://api.github.com/repos/rolandwalker/homebrew-cask/branches{/branch}","tags_url":"https://api.github.com/repos/rolandwalker/homebrew-cask/tags","blobs_url":"https://api.github.com/repos/rolandwalker/homebrew-cask/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rolandwalker/homebrew-cask/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rolandwalker/homebrew-cask/git/refs{/sha}","trees_url":"https://api.github.com/repos/rolandwalker/homebrew-cask/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rolandwalker/homebrew-cask/statuses/{sha}","languages_url":"https://api.github.com/repos/rolandwalker/homebrew-cask/languages","stargazers_url":"https://api.github.com/repos/rolandwalker/homebrew-cask/stargazers","contributors_url":"https://api.github.com/repos/rolandwalker/homebrew-cask/contributors","subscribers_url":"https://api.github.com/repos/rolandwalker/homebrew-cask/subscribers","subscription_url":"https://api.github.com/repos/rolandwalker/homebrew-cask/subscription","commits_url":"https://api.github.com/repos/rolandwalker/homebrew-cask/commits{/sha}","git_commits_url":"https://api.github.com/repos/rolandwalker/homebrew-cask/git/commits{/sha}","comments_url":"https://api.github.com/repos/rolandwalker/homebrew-cask/comments{/number}","issue_comment_url":"https://api.github.com/repos/rolandwalker/homebrew-cask/issues/comments/{number}","contents_url":"https://api.github.com/repos/rolandwalker/homebrew-cask/contents/{+path}","compare_url":"https://api.github.com/repos/rolandwalker/homebrew-cask/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rolandwalker/homebrew-cask/merges","archive_url":"https://api.github.com/repos/rolandwalker/homebrew-cask/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rolandwalker/homebrew-cask/downloads","issues_url":"https://api.github.com/repos/rolandwalker/homebrew-cask/issues{/number}","pulls_url":"https://api.github.com/repos/rolandwalker/homebrew-cask/pulls{/number}","milestones_url":"https://api.github.com/repos/rolandwalker/homebrew-cask/milestones{/number}","notifications_url":"https://api.github.com/repos/rolandwalker/homebrew-cask/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rolandwalker/homebrew-cask/labels{/name}","releases_url":"https://api.github.com/repos/rolandwalker/homebrew-cask/releases{/id}","created_at":"2013-11-18T21:07:31Z","updated_at":"2014-06-26T00:39:22Z","pushed_at":"2014-10-07T13:07:37Z","git_url":"git://github.com/rolandwalker/homebrew-cask.git","ssh_url":"git@github.com:rolandwalker/homebrew-cask.git","clone_url":"https://github.com/rolandwalker/homebrew-cask.git","svn_url":"https://github.com/rolandwalker/homebrew-cask","homepage":"","size":33369,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"caskroom:master","ref":"master","sha":"00755ff32bd9c657ca19d7822ffb4d2b338745fc","user":{"login":"caskroom","id":5647711,"avatar_url":"https://avatars.githubusercontent.com/u/5647711?v=2","gravatar_id":"","url":"https://api.github.com/users/caskroom","html_url":"https://github.com/caskroom","followers_url":"https://api.github.com/users/caskroom/followers","following_url":"https://api.github.com/users/caskroom/following{/other_user}","gists_url":"https://api.github.com/users/caskroom/gists{/gist_id}","starred_url":"https://api.github.com/users/caskroom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskroom/subscriptions","organizations_url":"https://api.github.com/users/caskroom/orgs","repos_url":"https://api.github.com/users/caskroom/repos","events_url":"https://api.github.com/users/caskroom/events{/privacy}","received_events_url":"https://api.github.com/users/caskroom/received_events","type":"Organization","site_admin":false},"repo":{"id":3623050,"name":"homebrew-cask","full_name":"caskroom/homebrew-cask","owner":{"login":"caskroom","id":5647711,"avatar_url":"https://avatars.githubusercontent.com/u/5647711?v=2","gravatar_id":"","url":"https://api.github.com/users/caskroom","html_url":"https://github.com/caskroom","followers_url":"https://api.github.com/users/caskroom/followers","following_url":"https://api.github.com/users/caskroom/following{/other_user}","gists_url":"https://api.github.com/users/caskroom/gists{/gist_id}","starred_url":"https://api.github.com/users/caskroom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskroom/subscriptions","organizations_url":"https://api.github.com/users/caskroom/orgs","repos_url":"https://api.github.com/users/caskroom/repos","events_url":"https://api.github.com/users/caskroom/events{/privacy}","received_events_url":"https://api.github.com/users/caskroom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/caskroom/homebrew-cask","description":"A CLI workflow for the administration of Mac applications distributed as binaries","fork":false,"url":"https://api.github.com/repos/caskroom/homebrew-cask","forks_url":"https://api.github.com/repos/caskroom/homebrew-cask/forks","keys_url":"https://api.github.com/repos/caskroom/homebrew-cask/keys{/key_id}","collaborators_url":"https://api.github.com/repos/caskroom/homebrew-cask/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/caskroom/homebrew-cask/teams","hooks_url":"https://api.github.com/repos/caskroom/homebrew-cask/hooks","issue_events_url":"https://api.github.com/repos/caskroom/homebrew-cask/issues/events{/number}","events_url":"https://api.github.com/repos/caskroom/homebrew-cask/events","assignees_url":"https://api.github.com/repos/caskroom/homebrew-cask/assignees{/user}","branches_url":"https://api.github.com/repos/caskroom/homebrew-cask/branches{/branch}","tags_url":"https://api.github.com/repos/caskroom/homebrew-cask/tags","blobs_url":"https://api.github.com/repos/caskroom/homebrew-cask/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/caskroom/homebrew-cask/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/caskroom/homebrew-cask/git/refs{/sha}","trees_url":"https://api.github.com/repos/caskroom/homebrew-cask/git/trees{/sha}","statuses_url":"https://api.github.com/repos/caskroom/homebrew-cask/statuses/{sha}","languages_url":"https://api.github.com/repos/caskroom/homebrew-cask/languages","stargazers_url":"https://api.github.com/repos/caskroom/homebrew-cask/stargazers","contributors_url":"https://api.github.com/repos/caskroom/homebrew-cask/contributors","subscribers_url":"https://api.github.com/repos/caskroom/homebrew-cask/subscribers","subscription_url":"https://api.github.com/repos/caskroom/homebrew-cask/subscription","commits_url":"https://api.github.com/repos/caskroom/homebrew-cask/commits{/sha}","git_commits_url":"https://api.github.com/repos/caskroom/homebrew-cask/git/commits{/sha}","comments_url":"https://api.github.com/repos/caskroom/homebrew-cask/comments{/number}","issue_comment_url":"https://api.github.com/repos/caskroom/homebrew-cask/issues/comments/{number}","contents_url":"https://api.github.com/repos/caskroom/homebrew-cask/contents/{+path}","compare_url":"https://api.github.com/repos/caskroom/homebrew-cask/compare/{base}...{head}","merges_url":"https://api.github.com/repos/caskroom/homebrew-cask/merges","archive_url":"https://api.github.com/repos/caskroom/homebrew-cask/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/caskroom/homebrew-cask/downloads","issues_url":"https://api.github.com/repos/caskroom/homebrew-cask/issues{/number}","pulls_url":"https://api.github.com/repos/caskroom/homebrew-cask/pulls{/number}","milestones_url":"https://api.github.com/repos/caskroom/homebrew-cask/milestones{/number}","notifications_url":"https://api.github.com/repos/caskroom/homebrew-cask/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/caskroom/homebrew-cask/labels{/name}","releases_url":"https://api.github.com/repos/caskroom/homebrew-cask/releases{/id}","created_at":"2012-03-05T02:05:17Z","updated_at":"2014-10-07T08:37:38Z","pushed_at":"2014-10-07T13:02:27Z","git_url":"git://github.com/caskroom/homebrew-cask.git","ssh_url":"git@github.com:caskroom/homebrew-cask.git","clone_url":"https://github.com/caskroom/homebrew-cask.git","svn_url":"https://github.com/caskroom/homebrew-cask","homepage":"http://caskroom.io","size":109771,"stargazers_count":4931,"watchers_count":4931,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1280,"mirror_url":null,"open_issues_count":165,"forks":1280,"open_issues":165,"watchers":4931,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/caskroom/homebrew-cask/pulls/6530"},"html":{"href":"https://github.com/caskroom/homebrew-cask/pull/6530"},"issue":{"href":"https://api.github.com/repos/caskroom/homebrew-cask/issues/6530"},"comments":{"href":"https://api.github.com/repos/caskroom/homebrew-cask/issues/6530/comments"},"review_comments":{"href":"https://api.github.com/repos/caskroom/homebrew-cask/pulls/6530/comments"},"review_comment":{"href":"https://api.github.com/repos/caskroom/homebrew-cask/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/caskroom/homebrew-cask/pulls/6530/commits"},"statuses":{"href":"https://api.github.com/repos/caskroom/homebrew-cask/statuses/98474d84eea4c65feadc394e096b61b55e95eab9"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":15,"deletions":13,"changed_files":1}}