GitHub PullRequestReviewCommentEvent at 2014-12-26 13:27:13
Repository: csympy
Actor: isuruf
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/sympy/csympy/pulls/comments/22283512","id":22283512,"diff_hunk":"@@ -9,7 +9,7 @@ include_directories(BEFORE ${CMAKE_SOURCE_DIR}/src)\n cython_add_module_pyx(csympy_wrapper csympy.pxd)\n add_python_library(csympy_wrapper ${SRC})\n target_link_libraries(csympy_wrapper csympy teuchos ${LIBS})\n-if (CMAKE_CXX_COMPILER_ID STREQUAL GNU)\n+if (CMAKE_CXX_COMPILER_ID MATCHES GNU|Clang)\n   # Must suppress strict aliasing for this file\n   set_source_files_properties(\n     csympy_wrapper.cpp","path":"csympy/lib/CMakeLists.txt","position":8,"original_position":8,"commit_id":"1e7ca5535574e6f95bb795f8a9a45c08fe2df102","original_commit_id":"2bf9ff7934a06608e6d47eda771cfde662974ba6","user":{"login":"isuruf","id":5234427,"avatar_url":"https://avatars.githubusercontent.com/u/5234427?v=3","gravatar_id":"","url":"https://api.github.com/users/isuruf","html_url":"https://github.com/isuruf","followers_url":"https://api.github.com/users/isuruf/followers","following_url":"https://api.github.com/users/isuruf/following{/other_user}","gists_url":"https://api.github.com/users/isuruf/gists{/gist_id}","starred_url":"https://api.github.com/users/isuruf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isuruf/subscriptions","organizations_url":"https://api.github.com/users/isuruf/orgs","repos_url":"https://api.github.com/users/isuruf/repos","events_url":"https://api.github.com/users/isuruf/events{/privacy}","received_events_url":"https://api.github.com/users/isuruf/received_events","type":"User","site_admin":false},"body":"Turning off `Wunused-function` turns off `Wunneeded-internal-declaration` (See [here](-Wunused-function and -Wunneeded-internal-declaration))","created_at":"2014-12-26T13:27:13Z","updated_at":"2014-12-26T13:27:13Z","html_url":"https://github.com/sympy/csympy/pull/354#discussion_r22283512","pull_request_url":"https://api.github.com/repos/sympy/csympy/pulls/354","_links":{"self":{"href":"https://api.github.com/repos/sympy/csympy/pulls/comments/22283512"},"html":{"href":"https://github.com/sympy/csympy/pull/354#discussion_r22283512"},"pull_request":{"href":"https://api.github.com/repos/sympy/csympy/pulls/354"}}},"pull_request":{"url":"https://api.github.com/repos/sympy/csympy/pulls/354","id":26585338,"html_url":"https://github.com/sympy/csympy/pull/354","diff_url":"https://github.com/sympy/csympy/pull/354.diff","patch_url":"https://github.com/sympy/csympy/pull/354.patch","issue_url":"https://api.github.com/repos/sympy/csympy/issues/354","number":354,"state":"open","locked":false,"title":"Travis-ci: use cpp environment and test clang","user":{"login":"isuruf","id":5234427,"avatar_url":"https://avatars.githubusercontent.com/u/5234427?v=3","gravatar_id":"","url":"https://api.github.com/users/isuruf","html_url":"https://github.com/isuruf","followers_url":"https://api.github.com/users/isuruf/followers","following_url":"https://api.github.com/users/isuruf/following{/other_user}","gists_url":"https://api.github.com/users/isuruf/gists{/gist_id}","starred_url":"https://api.github.com/users/isuruf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isuruf/subscriptions","organizations_url":"https://api.github.com/users/isuruf/orgs","repos_url":"https://api.github.com/users/isuruf/repos","events_url":"https://api.github.com/users/isuruf/events{/privacy}","received_events_url":"https://api.github.com/users/isuruf/received_events","type":"User","site_admin":false},"body":"Following changes were made to the travis/shippable builds\r\n* Travis - Use cpp environment instead of python\r\n* Shippable - Added shippable.yml which uses python environment (though Miniconda is used to install python) since shippable does not support cpp\r\n* Use Miniconda to install python (2.6, 2.7, 3.3, 3.4)\r\n* Removed python 3.2 tests as miniconda does not support it.\r\n* Travis - Added a test in clang\r\n* Added `-Wno-constant-logical-operand` flag for Travis/Shippable builds","created_at":"2014-12-25T18:14:17Z","updated_at":"2014-12-26T13:27:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"85d7e48a23b1b7aa9010f0e3bacf2f1771f27ae0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sympy/csympy/pulls/354/commits","review_comments_url":"https://api.github.com/repos/sympy/csympy/pulls/354/comments","review_comment_url":"https://api.github.com/repos/sympy/csympy/pulls/comments/{number}","comments_url":"https://api.github.com/repos/sympy/csympy/issues/354/comments","statuses_url":"https://api.github.com/repos/sympy/csympy/statuses/1e7ca5535574e6f95bb795f8a9a45c08fe2df102","head":{"label":"isuruf:travis","ref":"travis","sha":"1e7ca5535574e6f95bb795f8a9a45c08fe2df102","user":{"login":"isuruf","id":5234427,"avatar_url":"https://avatars.githubusercontent.com/u/5234427?v=3","gravatar_id":"","url":"https://api.github.com/users/isuruf","html_url":"https://github.com/isuruf","followers_url":"https://api.github.com/users/isuruf/followers","following_url":"https://api.github.com/users/isuruf/following{/other_user}","gists_url":"https://api.github.com/users/isuruf/gists{/gist_id}","starred_url":"https://api.github.com/users/isuruf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isuruf/subscriptions","organizations_url":"https://api.github.com/users/isuruf/orgs","repos_url":"https://api.github.com/users/isuruf/repos","events_url":"https://api.github.com/users/isuruf/events{/privacy}","received_events_url":"https://api.github.com/users/isuruf/received_events","type":"User","site_admin":false},"repo":{"id":20401702,"name":"csympy","full_name":"isuruf/csympy","owner":{"login":"isuruf","id":5234427,"avatar_url":"https://avatars.githubusercontent.com/u/5234427?v=3","gravatar_id":"","url":"https://api.github.com/users/isuruf","html_url":"https://github.com/isuruf","followers_url":"https://api.github.com/users/isuruf/followers","following_url":"https://api.github.com/users/isuruf/following{/other_user}","gists_url":"https://api.github.com/users/isuruf/gists{/gist_id}","starred_url":"https://api.github.com/users/isuruf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isuruf/subscriptions","organizations_url":"https://api.github.com/users/isuruf/orgs","repos_url":"https://api.github.com/users/isuruf/repos","events_url":"https://api.github.com/users/isuruf/events{/privacy}","received_events_url":"https://api.github.com/users/isuruf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/isuruf/csympy","description":"Fast symbolic manipulation library, written in C++","fork":true,"url":"https://api.github.com/repos/isuruf/csympy","forks_url":"https://api.github.com/repos/isuruf/csympy/forks","keys_url":"https://api.github.com/repos/isuruf/csympy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/isuruf/csympy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/isuruf/csympy/teams","hooks_url":"https://api.github.com/repos/isuruf/csympy/hooks","issue_events_url":"https://api.github.com/repos/isuruf/csympy/issues/events{/number}","events_url":"https://api.github.com/repos/isuruf/csympy/events","assignees_url":"https://api.github.com/repos/isuruf/csympy/assignees{/user}","branches_url":"https://api.github.com/repos/isuruf/csympy/branches{/branch}","tags_url":"https://api.github.com/repos/isuruf/csympy/tags","blobs_url":"https://api.github.com/repos/isuruf/csympy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/isuruf/csympy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/isuruf/csympy/git/refs{/sha}","trees_url":"https://api.github.com/repos/isuruf/csympy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/isuruf/csympy/statuses/{sha}","languages_url":"https://api.github.com/repos/isuruf/csympy/languages","stargazers_url":"https://api.github.com/repos/isuruf/csympy/stargazers","contributors_url":"https://api.github.com/repos/isuruf/csympy/contributors","subscribers_url":"https://api.github.com/repos/isuruf/csympy/subscribers","subscription_url":"https://api.github.com/repos/isuruf/csympy/subscription","commits_url":"https://api.github.com/repos/isuruf/csympy/commits{/sha}","git_commits_url":"https://api.github.com/repos/isuruf/csympy/git/commits{/sha}","comments_url":"https://api.github.com/repos/isuruf/csympy/comments{/number}","issue_comment_url":"https://api.github.com/repos/isuruf/csympy/issues/comments/{number}","contents_url":"https://api.github.com/repos/isuruf/csympy/contents/{+path}","compare_url":"https://api.github.com/repos/isuruf/csympy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/isuruf/csympy/merges","archive_url":"https://api.github.com/repos/isuruf/csympy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/isuruf/csympy/downloads","issues_url":"https://api.github.com/repos/isuruf/csympy/issues{/number}","pulls_url":"https://api.github.com/repos/isuruf/csympy/pulls{/number}","milestones_url":"https://api.github.com/repos/isuruf/csympy/milestones{/number}","notifications_url":"https://api.github.com/repos/isuruf/csympy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/isuruf/csympy/labels{/name}","releases_url":"https://api.github.com/repos/isuruf/csympy/releases{/id}","created_at":"2014-06-02T11:28:39Z","updated_at":"2014-06-25T15:03:41Z","pushed_at":"2014-12-26T12:11:54Z","git_url":"git://github.com/isuruf/csympy.git","ssh_url":"git@github.com:isuruf/csympy.git","clone_url":"https://github.com/isuruf/csympy.git","svn_url":"https://github.com/isuruf/csympy","homepage":"http://sympy.org","size":2669,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sympy:master","ref":"master","sha":"26daca33e1972375ead5d0b518614e325d344a8b","user":{"login":"sympy","id":260832,"avatar_url":"https://avatars.githubusercontent.com/u/260832?v=3","gravatar_id":"","url":"https://api.github.com/users/sympy","html_url":"https://github.com/sympy","followers_url":"https://api.github.com/users/sympy/followers","following_url":"https://api.github.com/users/sympy/following{/other_user}","gists_url":"https://api.github.com/users/sympy/gists{/gist_id}","starred_url":"https://api.github.com/users/sympy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sympy/subscriptions","organizations_url":"https://api.github.com/users/sympy/orgs","repos_url":"https://api.github.com/users/sympy/repos","events_url":"https://api.github.com/users/sympy/events{/privacy}","received_events_url":"https://api.github.com/users/sympy/received_events","type":"Organization","site_admin":false},"repo":{"id":42376,"name":"csympy","full_name":"sympy/csympy","owner":{"login":"sympy","id":260832,"avatar_url":"https://avatars.githubusercontent.com/u/260832?v=3","gravatar_id":"","url":"https://api.github.com/users/sympy","html_url":"https://github.com/sympy","followers_url":"https://api.github.com/users/sympy/followers","following_url":"https://api.github.com/users/sympy/following{/other_user}","gists_url":"https://api.github.com/users/sympy/gists{/gist_id}","starred_url":"https://api.github.com/users/sympy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sympy/subscriptions","organizations_url":"https://api.github.com/users/sympy/orgs","repos_url":"https://api.github.com/users/sympy/repos","events_url":"https://api.github.com/users/sympy/events{/privacy}","received_events_url":"https://api.github.com/users/sympy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sympy/csympy","description":"Fast symbolic manipulation library, written in C++","fork":false,"url":"https://api.github.com/repos/sympy/csympy","forks_url":"https://api.github.com/repos/sympy/csympy/forks","keys_url":"https://api.github.com/repos/sympy/csympy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sympy/csympy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sympy/csympy/teams","hooks_url":"https://api.github.com/repos/sympy/csympy/hooks","issue_events_url":"https://api.github.com/repos/sympy/csympy/issues/events{/number}","events_url":"https://api.github.com/repos/sympy/csympy/events","assignees_url":"https://api.github.com/repos/sympy/csympy/assignees{/user}","branches_url":"https://api.github.com/repos/sympy/csympy/branches{/branch}","tags_url":"https://api.github.com/repos/sympy/csympy/tags","blobs_url":"https://api.github.com/repos/sympy/csympy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sympy/csympy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sympy/csympy/git/refs{/sha}","trees_url":"https://api.github.com/repos/sympy/csympy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sympy/csympy/statuses/{sha}","languages_url":"https://api.github.com/repos/sympy/csympy/languages","stargazers_url":"https://api.github.com/repos/sympy/csympy/stargazers","contributors_url":"https://api.github.com/repos/sympy/csympy/contributors","subscribers_url":"https://api.github.com/repos/sympy/csympy/subscribers","subscription_url":"https://api.github.com/repos/sympy/csympy/subscription","commits_url":"https://api.github.com/repos/sympy/csympy/commits{/sha}","git_commits_url":"https://api.github.com/repos/sympy/csympy/git/commits{/sha}","comments_url":"https://api.github.com/repos/sympy/csympy/comments{/number}","issue_comment_url":"https://api.github.com/repos/sympy/csympy/issues/comments/{number}","contents_url":"https://api.github.com/repos/sympy/csympy/contents/{+path}","compare_url":"https://api.github.com/repos/sympy/csympy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sympy/csympy/merges","archive_url":"https://api.github.com/repos/sympy/csympy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sympy/csympy/downloads","issues_url":"https://api.github.com/repos/sympy/csympy/issues{/number}","pulls_url":"https://api.github.com/repos/sympy/csympy/pulls{/number}","milestones_url":"https://api.github.com/repos/sympy/csympy/milestones{/number}","notifications_url":"https://api.github.com/repos/sympy/csympy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sympy/csympy/labels{/name}","releases_url":"https://api.github.com/repos/sympy/csympy/releases{/id}","created_at":"2008-08-13T18:40:14Z","updated_at":"2014-12-25T10:08:08Z","pushed_at":"2014-12-25T10:08:08Z","git_url":"git://github.com/sympy/csympy.git","ssh_url":"git@github.com:sympy/csympy.git","clone_url":"https://github.com/sympy/csympy.git","svn_url":"https://github.com/sympy/csympy","homepage":"http://sympy.org","size":4316,"stargazers_count":37,"watchers_count":37,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":39,"mirror_url":null,"open_issues_count":52,"forks":39,"open_issues":52,"watchers":37,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sympy/csympy/pulls/354"},"html":{"href":"https://github.com/sympy/csympy/pull/354"},"issue":{"href":"https://api.github.com/repos/sympy/csympy/issues/354"},"comments":{"href":"https://api.github.com/repos/sympy/csympy/issues/354/comments"},"review_comments":{"href":"https://api.github.com/repos/sympy/csympy/pulls/354/comments"},"review_comment":{"href":"https://api.github.com/repos/sympy/csympy/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/sympy/csympy/pulls/354/commits"},"statuses":{"href":"https://api.github.com/repos/sympy/csympy/statuses/1e7ca5535574e6f95bb795f8a9a45c08fe2df102"}}}}