GitHub PullRequestReviewCommentEvent at 2014-09-18 12:55:53
Repository: kc
Actor: jwillia
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/kuali/kc/pulls/comments/17724739","id":17724739,"diff_hunk":"@@ -102,13 +102,46 @@\n             <list>\n                 <bean parent=\"Kc-Wizard-RoleResults\"\n                       p:progressiveRender=\"@{#empty(#fp.addRecipientHelper.lineType)}\"\n-                      p:order=\"10\" />\n+                      p:order=\"10\" >\n+                    <property name=\"items\">\n+                        <list merge=\"true\">\n+                            <bean parent=\"Uif-InputField\" p:propertyName=\"selected\"\n+                                  p:label=\"\" p:readOnly=\"false\" p:order=\"10\" p:cssClasses=\"one_required\">\n+                                <property name=\"control\">\n+                                    <bean parent=\"Uif-CheckboxControl\"/>\n+                                </property>\n+                            </bean>","path":"coeus-impl/src/main/resources/org/kuali/coeus/common/notification/impl/SendNotificationDialog.xml","position":13,"original_position":13,"commit_id":"f5851778bdbec10c8898ebfc0af68c6f1cc2ef6d","original_commit_id":"f5851778bdbec10c8898ebfc0af68c6f1cc2ef6d","user":{"login":"jwillia","id":7320896,"avatar_url":"https://avatars.githubusercontent.com/u/7320896?v=2","gravatar_id":"fce82676dc86929ef1beff839d4d35ac","url":"https://api.github.com/users/jwillia","html_url":"https://github.com/jwillia","followers_url":"https://api.github.com/users/jwillia/followers","following_url":"https://api.github.com/users/jwillia/following{/other_user}","gists_url":"https://api.github.com/users/jwillia/gists{/gist_id}","starred_url":"https://api.github.com/users/jwillia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwillia/subscriptions","organizations_url":"https://api.github.com/users/jwillia/orgs","repos_url":"https://api.github.com/users/jwillia/repos","events_url":"https://api.github.com/users/jwillia/events{/privacy}","received_events_url":"https://api.github.com/users/jwillia/received_events","type":"User","site_admin":false},"body":"this makes all selects on the right hand side of the wizard for consistency, since any item added to a merged list is currently just added to the end of the list.  If the merge order gets fixed all the selects will move back to the left hand side","created_at":"2014-09-18T12:55:53Z","updated_at":"2014-09-18T12:55:53Z","html_url":"https://github.com/kuali/kc/pull/749#discussion_r17724739","pull_request_url":"https://api.github.com/repos/kuali/kc/pulls/749","_links":{"self":{"href":"https://api.github.com/repos/kuali/kc/pulls/comments/17724739"},"html":{"href":"https://github.com/kuali/kc/pull/749#discussion_r17724739"},"pull_request":{"href":"https://api.github.com/repos/kuali/kc/pulls/749"}}},"pull_request":{"url":"https://api.github.com/repos/kuali/kc/pulls/749","id":21390538,"html_url":"https://github.com/kuali/kc/pull/749","diff_url":"https://github.com/kuali/kc/pull/749.diff","patch_url":"https://github.com/kuali/kc/pull/749.patch","issue_url":"https://api.github.com/repos/kuali/kc/issues/749","number":749,"state":"open","locked":false,"title":"KRACOEUS-7955:fix select on wizards","user":{"login":"jwillia","id":7320896,"avatar_url":"https://avatars.githubusercontent.com/u/7320896?v=2","gravatar_id":"fce82676dc86929ef1beff839d4d35ac","url":"https://api.github.com/users/jwillia","html_url":"https://github.com/jwillia","followers_url":"https://api.github.com/users/jwillia/followers","following_url":"https://api.github.com/users/jwillia/following{/other_user}","gists_url":"https://api.github.com/users/jwillia/gists{/gist_id}","starred_url":"https://api.github.com/users/jwillia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwillia/subscriptions","organizations_url":"https://api.github.com/users/jwillia/orgs","repos_url":"https://api.github.com/users/jwillia/repos","events_url":"https://api.github.com/users/jwillia/events{/privacy}","received_events_url":"https://api.github.com/users/jwillia/received_events","type":"User","site_admin":false},"body":"unfortunately, since merge ordering seems to be broken https://jira.kuali.org/browse/KULRICE-13288, all selects are going to appear on the right hand side of the wizard until it gets fixed.  If we want them all to appear on the left i can do that but I will have to define the results page twice once for single select and once for mulitple select.","created_at":"2014-09-17T19:38:52Z","updated_at":"2014-09-18T12:55:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"215a96ce3195eab253758fe3a60bb37d1165eeaa","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/kuali/kc/pulls/749/commits","review_comments_url":"https://api.github.com/repos/kuali/kc/pulls/749/comments","review_comment_url":"https://api.github.com/repos/kuali/kc/pulls/comments/{number}","comments_url":"https://api.github.com/repos/kuali/kc/issues/749/comments","statuses_url":"https://api.github.com/repos/kuali/kc/statuses/f5851778bdbec10c8898ebfc0af68c6f1cc2ef6d","head":{"label":"jwillia:KRACOEUS_7955_1","ref":"KRACOEUS_7955_1","sha":"f5851778bdbec10c8898ebfc0af68c6f1cc2ef6d","user":{"login":"jwillia","id":7320896,"avatar_url":"https://avatars.githubusercontent.com/u/7320896?v=2","gravatar_id":"fce82676dc86929ef1beff839d4d35ac","url":"https://api.github.com/users/jwillia","html_url":"https://github.com/jwillia","followers_url":"https://api.github.com/users/jwillia/followers","following_url":"https://api.github.com/users/jwillia/following{/other_user}","gists_url":"https://api.github.com/users/jwillia/gists{/gist_id}","starred_url":"https://api.github.com/users/jwillia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwillia/subscriptions","organizations_url":"https://api.github.com/users/jwillia/orgs","repos_url":"https://api.github.com/users/jwillia/repos","events_url":"https://api.github.com/users/jwillia/events{/privacy}","received_events_url":"https://api.github.com/users/jwillia/received_events","type":"User","site_admin":false},"repo":{"id":18894243,"name":"kc","full_name":"jwillia/kc","owner":{"login":"jwillia","id":7320896,"avatar_url":"https://avatars.githubusercontent.com/u/7320896?v=2","gravatar_id":"fce82676dc86929ef1beff839d4d35ac","url":"https://api.github.com/users/jwillia","html_url":"https://github.com/jwillia","followers_url":"https://api.github.com/users/jwillia/followers","following_url":"https://api.github.com/users/jwillia/following{/other_user}","gists_url":"https://api.github.com/users/jwillia/gists{/gist_id}","starred_url":"https://api.github.com/users/jwillia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwillia/subscriptions","organizations_url":"https://api.github.com/users/jwillia/orgs","repos_url":"https://api.github.com/users/jwillia/repos","events_url":"https://api.github.com/users/jwillia/events{/privacy}","received_events_url":"https://api.github.com/users/jwillia/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jwillia/kc","description":"Kuali Coeus","fork":true,"url":"https://api.github.com/repos/jwillia/kc","forks_url":"https://api.github.com/repos/jwillia/kc/forks","keys_url":"https://api.github.com/repos/jwillia/kc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jwillia/kc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jwillia/kc/teams","hooks_url":"https://api.github.com/repos/jwillia/kc/hooks","issue_events_url":"https://api.github.com/repos/jwillia/kc/issues/events{/number}","events_url":"https://api.github.com/repos/jwillia/kc/events","assignees_url":"https://api.github.com/repos/jwillia/kc/assignees{/user}","branches_url":"https://api.github.com/repos/jwillia/kc/branches{/branch}","tags_url":"https://api.github.com/repos/jwillia/kc/tags","blobs_url":"https://api.github.com/repos/jwillia/kc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jwillia/kc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jwillia/kc/git/refs{/sha}","trees_url":"https://api.github.com/repos/jwillia/kc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jwillia/kc/statuses/{sha}","languages_url":"https://api.github.com/repos/jwillia/kc/languages","stargazers_url":"https://api.github.com/repos/jwillia/kc/stargazers","contributors_url":"https://api.github.com/repos/jwillia/kc/contributors","subscribers_url":"https://api.github.com/repos/jwillia/kc/subscribers","subscription_url":"https://api.github.com/repos/jwillia/kc/subscription","commits_url":"https://api.github.com/repos/jwillia/kc/commits{/sha}","git_commits_url":"https://api.github.com/repos/jwillia/kc/git/commits{/sha}","comments_url":"https://api.github.com/repos/jwillia/kc/comments{/number}","issue_comment_url":"https://api.github.com/repos/jwillia/kc/issues/comments/{number}","contents_url":"https://api.github.com/repos/jwillia/kc/contents/{+path}","compare_url":"https://api.github.com/repos/jwillia/kc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jwillia/kc/merges","archive_url":"https://api.github.com/repos/jwillia/kc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jwillia/kc/downloads","issues_url":"https://api.github.com/repos/jwillia/kc/issues{/number}","pulls_url":"https://api.github.com/repos/jwillia/kc/pulls{/number}","milestones_url":"https://api.github.com/repos/jwillia/kc/milestones{/number}","notifications_url":"https://api.github.com/repos/jwillia/kc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jwillia/kc/labels{/name}","releases_url":"https://api.github.com/repos/jwillia/kc/releases{/id}","created_at":"2014-04-17T21:37:55Z","updated_at":"2014-06-25T18:08:03Z","pushed_at":"2014-09-17T19:41:09Z","git_url":"git://github.com/jwillia/kc.git","ssh_url":"git@github.com:jwillia/kc.git","clone_url":"https://github.com/jwillia/kc.git","svn_url":"https://github.com/jwillia/kc","homepage":"http://www.kuali.org/kc","size":592591,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kuali:master","ref":"master","sha":"86d36a255f261f6fe3c1d2c531ebceb85d49f968","user":{"login":"kuali","id":371097,"avatar_url":"https://avatars.githubusercontent.com/u/371097?v=2","gravatar_id":"c2e9cf7cb10aab4497c85f81a4188869","url":"https://api.github.com/users/kuali","html_url":"https://github.com/kuali","followers_url":"https://api.github.com/users/kuali/followers","following_url":"https://api.github.com/users/kuali/following{/other_user}","gists_url":"https://api.github.com/users/kuali/gists{/gist_id}","starred_url":"https://api.github.com/users/kuali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kuali/subscriptions","organizations_url":"https://api.github.com/users/kuali/orgs","repos_url":"https://api.github.com/users/kuali/repos","events_url":"https://api.github.com/users/kuali/events{/privacy}","received_events_url":"https://api.github.com/users/kuali/received_events","type":"Organization","site_admin":false},"repo":{"id":16106733,"name":"kc","full_name":"kuali/kc","owner":{"login":"kuali","id":371097,"avatar_url":"https://avatars.githubusercontent.com/u/371097?v=2","gravatar_id":"c2e9cf7cb10aab4497c85f81a4188869","url":"https://api.github.com/users/kuali","html_url":"https://github.com/kuali","followers_url":"https://api.github.com/users/kuali/followers","following_url":"https://api.github.com/users/kuali/following{/other_user}","gists_url":"https://api.github.com/users/kuali/gists{/gist_id}","starred_url":"https://api.github.com/users/kuali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kuali/subscriptions","organizations_url":"https://api.github.com/users/kuali/orgs","repos_url":"https://api.github.com/users/kuali/repos","events_url":"https://api.github.com/users/kuali/events{/privacy}","received_events_url":"https://api.github.com/users/kuali/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kuali/kc","description":"Kuali Coeus","fork":false,"url":"https://api.github.com/repos/kuali/kc","forks_url":"https://api.github.com/repos/kuali/kc/forks","keys_url":"https://api.github.com/repos/kuali/kc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kuali/kc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kuali/kc/teams","hooks_url":"https://api.github.com/repos/kuali/kc/hooks","issue_events_url":"https://api.github.com/repos/kuali/kc/issues/events{/number}","events_url":"https://api.github.com/repos/kuali/kc/events","assignees_url":"https://api.github.com/repos/kuali/kc/assignees{/user}","branches_url":"https://api.github.com/repos/kuali/kc/branches{/branch}","tags_url":"https://api.github.com/repos/kuali/kc/tags","blobs_url":"https://api.github.com/repos/kuali/kc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kuali/kc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kuali/kc/git/refs{/sha}","trees_url":"https://api.github.com/repos/kuali/kc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kuali/kc/statuses/{sha}","languages_url":"https://api.github.com/repos/kuali/kc/languages","stargazers_url":"https://api.github.com/repos/kuali/kc/stargazers","contributors_url":"https://api.github.com/repos/kuali/kc/contributors","subscribers_url":"https://api.github.com/repos/kuali/kc/subscribers","subscription_url":"https://api.github.com/repos/kuali/kc/subscription","commits_url":"https://api.github.com/repos/kuali/kc/commits{/sha}","git_commits_url":"https://api.github.com/repos/kuali/kc/git/commits{/sha}","comments_url":"https://api.github.com/repos/kuali/kc/comments{/number}","issue_comment_url":"https://api.github.com/repos/kuali/kc/issues/comments/{number}","contents_url":"https://api.github.com/repos/kuali/kc/contents/{+path}","compare_url":"https://api.github.com/repos/kuali/kc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kuali/kc/merges","archive_url":"https://api.github.com/repos/kuali/kc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kuali/kc/downloads","issues_url":"https://api.github.com/repos/kuali/kc/issues{/number}","pulls_url":"https://api.github.com/repos/kuali/kc/pulls{/number}","milestones_url":"https://api.github.com/repos/kuali/kc/milestones{/number}","notifications_url":"https://api.github.com/repos/kuali/kc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kuali/kc/labels{/name}","releases_url":"https://api.github.com/repos/kuali/kc/releases{/id}","created_at":"2014-01-21T15:32:22Z","updated_at":"2014-09-17T19:46:00Z","pushed_at":"2014-09-18T00:52:08Z","git_url":"git://github.com/kuali/kc.git","ssh_url":"git@github.com:kuali/kc.git","clone_url":"https://github.com/kuali/kc.git","svn_url":"https://github.com/kuali/kc","homepage":"http://www.kuali.org/kc","size":696638,"stargazers_count":8,"watchers_count":8,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":35,"mirror_url":null,"open_issues_count":26,"forks":35,"open_issues":26,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kuali/kc/pulls/749"},"html":{"href":"https://github.com/kuali/kc/pull/749"},"issue":{"href":"https://api.github.com/repos/kuali/kc/issues/749"},"comments":{"href":"https://api.github.com/repos/kuali/kc/issues/749/comments"},"review_comments":{"href":"https://api.github.com/repos/kuali/kc/pulls/749/comments"},"review_comment":{"href":"https://api.github.com/repos/kuali/kc/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/kuali/kc/pulls/749/commits"},"statuses":{"href":"https://api.github.com/repos/kuali/kc/statuses/f5851778bdbec10c8898ebfc0af68c6f1cc2ef6d"}}}}