GitHub PullRequestReviewCommentEvent at 2014-06-30 03:50:00
Repository: escodegen
Actor: Constellation
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/Constellation/escodegen/pulls/comments/14334804","id":14334804,"diff_hunk":"@@ -1796,6 +1800,12 @@\n                 // So if comment is attached to target node, we should specialize.\n                 withIndent(function () {\n                     node = stmt.declarations[0];\n+                    if (node.type === Syntax.VariableDeclarator &&\n+                        node.init &&\n+                        node.init.type === Syntax.ObjectExpression) {\n+                        restoreIndent();\n+                    }\n+","path":"escodegen.js","position":20,"original_position":20,"commit_id":"24c332c559c80cbf62448c7fd597facba1d64436","original_commit_id":"24c332c559c80cbf62448c7fd597facba1d64436","user":{"login":"Constellation","id":9023,"avatar_url":"https://avatars.githubusercontent.com/u/9023?","gravatar_id":"09b5a917b6ea8928e0d5bf8a432412fe","url":"https://api.github.com/users/Constellation","html_url":"https://github.com/Constellation","followers_url":"https://api.github.com/users/Constellation/followers","following_url":"https://api.github.com/users/Constellation/following{/other_user}","gists_url":"https://api.github.com/users/Constellation/gists{/gist_id}","starred_url":"https://api.github.com/users/Constellation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Constellation/subscriptions","organizations_url":"https://api.github.com/users/Constellation/orgs","repos_url":"https://api.github.com/users/Constellation/repos","events_url":"https://api.github.com/users/Constellation/events{/privacy}","received_events_url":"https://api.github.com/users/Constellation/received_events","type":"User","site_admin":false},"body":"`VariableDecalation` can hold multiple declarations.\r\nSo, you need to check `stmt.declaration.length === 1`.\r\nCurrently, FunctionExpression case is already considered in escodegen (L1787 - L1792).\r\nSo generalizing it for ObjectExpression / ArrayExpression is better.","created_at":"2014-06-30T03:50:00Z","updated_at":"2014-06-30T03:50:00Z","html_url":"https://github.com/Constellation/escodegen/pull/188#discussion_r14334804","pull_request_url":"https://api.github.com/repos/Constellation/escodegen/pulls/188","_links":{"self":{"href":"https://api.github.com/repos/Constellation/escodegen/pulls/comments/14334804"},"html":{"href":"https://github.com/Constellation/escodegen/pull/188#discussion_r14334804"},"pull_request":{"href":"https://api.github.com/repos/Constellation/escodegen/pulls/188"}}},"pull_request":{"url":"https://api.github.com/repos/Constellation/escodegen/pulls/188","id":17747261,"html_url":"https://github.com/Constellation/escodegen/pull/188","diff_url":"https://github.com/Constellation/escodegen/pull/188.diff","patch_url":"https://github.com/Constellation/escodegen/pull/188.patch","issue_url":"https://api.github.com/repos/Constellation/escodegen/issues/188","number":188,"state":"open","title":"FIX Constellation/escodegen#187","user":{"login":"leeight","id":104052,"avatar_url":"https://avatars.githubusercontent.com/u/104052?","gravatar_id":"f0a30a89a4689815170031b22b1722f2","url":"https://api.github.com/users/leeight","html_url":"https://github.com/leeight","followers_url":"https://api.github.com/users/leeight/followers","following_url":"https://api.github.com/users/leeight/following{/other_user}","gists_url":"https://api.github.com/users/leeight/gists{/gist_id}","starred_url":"https://api.github.com/users/leeight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leeight/subscriptions","organizations_url":"https://api.github.com/users/leeight/orgs","repos_url":"https://api.github.com/users/leeight/repos","events_url":"https://api.github.com/users/leeight/events{/privacy}","received_events_url":"https://api.github.com/users/leeight/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-06-29T14:02:50Z","updated_at":"2014-06-30T03:50:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"344b1fe649636bc737ff23162a5879b22a272360","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Constellation/escodegen/pulls/188/commits","review_comments_url":"https://api.github.com/repos/Constellation/escodegen/pulls/188/comments","review_comment_url":"https://api.github.com/repos/Constellation/escodegen/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Constellation/escodegen/issues/188/comments","statuses_url":"https://api.github.com/repos/Constellation/escodegen/statuses/24c332c559c80cbf62448c7fd597facba1d64436","head":{"label":"leeight:issue-187","ref":"issue-187","sha":"24c332c559c80cbf62448c7fd597facba1d64436","user":{"login":"leeight","id":104052,"avatar_url":"https://avatars.githubusercontent.com/u/104052?","gravatar_id":"f0a30a89a4689815170031b22b1722f2","url":"https://api.github.com/users/leeight","html_url":"https://github.com/leeight","followers_url":"https://api.github.com/users/leeight/followers","following_url":"https://api.github.com/users/leeight/following{/other_user}","gists_url":"https://api.github.com/users/leeight/gists{/gist_id}","starred_url":"https://api.github.com/users/leeight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leeight/subscriptions","organizations_url":"https://api.github.com/users/leeight/orgs","repos_url":"https://api.github.com/users/leeight/repos","events_url":"https://api.github.com/users/leeight/events{/privacy}","received_events_url":"https://api.github.com/users/leeight/received_events","type":"User","site_admin":false},"repo":{"id":21323794,"name":"escodegen","full_name":"leeight/escodegen","owner":{"login":"leeight","id":104052,"avatar_url":"https://avatars.githubusercontent.com/u/104052?","gravatar_id":"f0a30a89a4689815170031b22b1722f2","url":"https://api.github.com/users/leeight","html_url":"https://github.com/leeight","followers_url":"https://api.github.com/users/leeight/followers","following_url":"https://api.github.com/users/leeight/following{/other_user}","gists_url":"https://api.github.com/users/leeight/gists{/gist_id}","starred_url":"https://api.github.com/users/leeight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leeight/subscriptions","organizations_url":"https://api.github.com/users/leeight/orgs","repos_url":"https://api.github.com/users/leeight/repos","events_url":"https://api.github.com/users/leeight/events{/privacy}","received_events_url":"https://api.github.com/users/leeight/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/leeight/escodegen","description":"ECMAScript code generator","fork":true,"url":"https://api.github.com/repos/leeight/escodegen","forks_url":"https://api.github.com/repos/leeight/escodegen/forks","keys_url":"https://api.github.com/repos/leeight/escodegen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/leeight/escodegen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/leeight/escodegen/teams","hooks_url":"https://api.github.com/repos/leeight/escodegen/hooks","issue_events_url":"https://api.github.com/repos/leeight/escodegen/issues/events{/number}","events_url":"https://api.github.com/repos/leeight/escodegen/events","assignees_url":"https://api.github.com/repos/leeight/escodegen/assignees{/user}","branches_url":"https://api.github.com/repos/leeight/escodegen/branches{/branch}","tags_url":"https://api.github.com/repos/leeight/escodegen/tags","blobs_url":"https://api.github.com/repos/leeight/escodegen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/leeight/escodegen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/leeight/escodegen/git/refs{/sha}","trees_url":"https://api.github.com/repos/leeight/escodegen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/leeight/escodegen/statuses/{sha}","languages_url":"https://api.github.com/repos/leeight/escodegen/languages","stargazers_url":"https://api.github.com/repos/leeight/escodegen/stargazers","contributors_url":"https://api.github.com/repos/leeight/escodegen/contributors","subscribers_url":"https://api.github.com/repos/leeight/escodegen/subscribers","subscription_url":"https://api.github.com/repos/leeight/escodegen/subscription","commits_url":"https://api.github.com/repos/leeight/escodegen/commits{/sha}","git_commits_url":"https://api.github.com/repos/leeight/escodegen/git/commits{/sha}","comments_url":"https://api.github.com/repos/leeight/escodegen/comments{/number}","issue_comment_url":"https://api.github.com/repos/leeight/escodegen/issues/comments/{number}","contents_url":"https://api.github.com/repos/leeight/escodegen/contents/{+path}","compare_url":"https://api.github.com/repos/leeight/escodegen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/leeight/escodegen/merges","archive_url":"https://api.github.com/repos/leeight/escodegen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/leeight/escodegen/downloads","issues_url":"https://api.github.com/repos/leeight/escodegen/issues{/number}","pulls_url":"https://api.github.com/repos/leeight/escodegen/pulls{/number}","milestones_url":"https://api.github.com/repos/leeight/escodegen/milestones{/number}","notifications_url":"https://api.github.com/repos/leeight/escodegen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/leeight/escodegen/labels{/name}","releases_url":"https://api.github.com/repos/leeight/escodegen/releases{/id}","created_at":"2014-06-29T13:29:35Z","updated_at":"2014-06-29T12:41:36Z","pushed_at":"2014-06-29T14:02:41Z","git_url":"git://github.com/leeight/escodegen.git","ssh_url":"git@github.com:leeight/escodegen.git","clone_url":"https://github.com/leeight/escodegen.git","svn_url":"https://github.com/leeight/escodegen","homepage":"","size":1370,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Constellation:master","ref":"master","sha":"41fbbe5058849b5e082542c5cfce76c2d67792e6","user":{"login":"Constellation","id":9023,"avatar_url":"https://avatars.githubusercontent.com/u/9023?","gravatar_id":"09b5a917b6ea8928e0d5bf8a432412fe","url":"https://api.github.com/users/Constellation","html_url":"https://github.com/Constellation","followers_url":"https://api.github.com/users/Constellation/followers","following_url":"https://api.github.com/users/Constellation/following{/other_user}","gists_url":"https://api.github.com/users/Constellation/gists{/gist_id}","starred_url":"https://api.github.com/users/Constellation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Constellation/subscriptions","organizations_url":"https://api.github.com/users/Constellation/orgs","repos_url":"https://api.github.com/users/Constellation/repos","events_url":"https://api.github.com/users/Constellation/events{/privacy}","received_events_url":"https://api.github.com/users/Constellation/received_events","type":"User","site_admin":false},"repo":{"id":3611422,"name":"escodegen","full_name":"Constellation/escodegen","owner":{"login":"Constellation","id":9023,"avatar_url":"https://avatars.githubusercontent.com/u/9023?","gravatar_id":"09b5a917b6ea8928e0d5bf8a432412fe","url":"https://api.github.com/users/Constellation","html_url":"https://github.com/Constellation","followers_url":"https://api.github.com/users/Constellation/followers","following_url":"https://api.github.com/users/Constellation/following{/other_user}","gists_url":"https://api.github.com/users/Constellation/gists{/gist_id}","starred_url":"https://api.github.com/users/Constellation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Constellation/subscriptions","organizations_url":"https://api.github.com/users/Constellation/orgs","repos_url":"https://api.github.com/users/Constellation/repos","events_url":"https://api.github.com/users/Constellation/events{/privacy}","received_events_url":"https://api.github.com/users/Constellation/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Constellation/escodegen","description":"ECMAScript code generator","fork":false,"url":"https://api.github.com/repos/Constellation/escodegen","forks_url":"https://api.github.com/repos/Constellation/escodegen/forks","keys_url":"https://api.github.com/repos/Constellation/escodegen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Constellation/escodegen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Constellation/escodegen/teams","hooks_url":"https://api.github.com/repos/Constellation/escodegen/hooks","issue_events_url":"https://api.github.com/repos/Constellation/escodegen/issues/events{/number}","events_url":"https://api.github.com/repos/Constellation/escodegen/events","assignees_url":"https://api.github.com/repos/Constellation/escodegen/assignees{/user}","branches_url":"https://api.github.com/repos/Constellation/escodegen/branches{/branch}","tags_url":"https://api.github.com/repos/Constellation/escodegen/tags","blobs_url":"https://api.github.com/repos/Constellation/escodegen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Constellation/escodegen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Constellation/escodegen/git/refs{/sha}","trees_url":"https://api.github.com/repos/Constellation/escodegen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Constellation/escodegen/statuses/{sha}","languages_url":"https://api.github.com/repos/Constellation/escodegen/languages","stargazers_url":"https://api.github.com/repos/Constellation/escodegen/stargazers","contributors_url":"https://api.github.com/repos/Constellation/escodegen/contributors","subscribers_url":"https://api.github.com/repos/Constellation/escodegen/subscribers","subscription_url":"https://api.github.com/repos/Constellation/escodegen/subscription","commits_url":"https://api.github.com/repos/Constellation/escodegen/commits{/sha}","git_commits_url":"https://api.github.com/repos/Constellation/escodegen/git/commits{/sha}","comments_url":"https://api.github.com/repos/Constellation/escodegen/comments{/number}","issue_comment_url":"https://api.github.com/repos/Constellation/escodegen/issues/comments/{number}","contents_url":"https://api.github.com/repos/Constellation/escodegen/contents/{+path}","compare_url":"https://api.github.com/repos/Constellation/escodegen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Constellation/escodegen/merges","archive_url":"https://api.github.com/repos/Constellation/escodegen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Constellation/escodegen/downloads","issues_url":"https://api.github.com/repos/Constellation/escodegen/issues{/number}","pulls_url":"https://api.github.com/repos/Constellation/escodegen/pulls{/number}","milestones_url":"https://api.github.com/repos/Constellation/escodegen/milestones{/number}","notifications_url":"https://api.github.com/repos/Constellation/escodegen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Constellation/escodegen/labels{/name}","releases_url":"https://api.github.com/repos/Constellation/escodegen/releases{/id}","created_at":"2012-03-03T15:14:52Z","updated_at":"2014-06-29T12:41:36Z","pushed_at":"2014-06-03T07:01:01Z","git_url":"git://github.com/Constellation/escodegen.git","ssh_url":"git@github.com:Constellation/escodegen.git","clone_url":"https://github.com/Constellation/escodegen.git","svn_url":"https://github.com/Constellation/escodegen","homepage":"","size":3080,"stargazers_count":571,"watchers_count":571,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":81,"mirror_url":null,"open_issues_count":40,"forks":81,"open_issues":40,"watchers":571,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Constellation/escodegen/pulls/188"},"html":{"href":"https://github.com/Constellation/escodegen/pull/188"},"issue":{"href":"https://api.github.com/repos/Constellation/escodegen/issues/188"},"comments":{"href":"https://api.github.com/repos/Constellation/escodegen/issues/188/comments"},"review_comments":{"href":"https://api.github.com/repos/Constellation/escodegen/pulls/188/comments"},"review_comment":{"href":"https://api.github.com/repos/Constellation/escodegen/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Constellation/escodegen/pulls/188/commits"},"statuses":{"href":"https://api.github.com/repos/Constellation/escodegen/statuses/24c332c559c80cbf62448c7fd597facba1d64436"}}}}