GitHub PullRequestReviewCommentEvent at 2014-02-03 11:12:59
Repository: moodlemobile
Actor: jleyva
Payload: {"comment":{"url":"https://api.github.com/repos/moodlehq/moodlemobile/pulls/comments/9379390","id":9379390,"diff_hunk":"@@ -214,6 +214,7 @@ MM.settings = {\n \n         MM.popConfirm(MM.lang.s('deletesitefiles'), function() {\n             MM.fs.removeDirectory(siteId, function() {\n+                //TODO - The content plugins should be noticed about this!\n                 MM.settings.showSpaceusage();","path":"lib/mm.settings.js","position":5,"original_position":5,"commit_id":"e1f1d1fc37fbb7262067df8a3383b438c1643071","original_commit_id":"e1f1d1fc37fbb7262067df8a3383b438c1643071","user":{"login":"jleyva","id":615556,"avatar_url":"https://gravatar.com/avatar/15a195c40714560f43a8a021039d9f4c?d=https%3A%2F%2Fidenticons.github.com%2Fbea42628359dd607ac05c18f048746a7.png&r=x","gravatar_id":"15a195c40714560f43a8a021039d9f4c","url":"https://api.github.com/users/jleyva","html_url":"https://github.com/jleyva","followers_url":"https://api.github.com/users/jleyva/followers","following_url":"https://api.github.com/users/jleyva/following{/other_user}","gists_url":"https://api.github.com/users/jleyva/gists{/gist_id}","starred_url":"https://api.github.com/users/jleyva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jleyva/subscriptions","organizations_url":"https://api.github.com/users/jleyva/orgs","repos_url":"https://api.github.com/users/jleyva/repos","events_url":"https://api.github.com/users/jleyva/events{/privacy}","received_events_url":"https://api.github.com/users/jleyva/received_events","type":"User","site_admin":false},"body":"Not a type but it doesn't look good, all the settings uses the same url handler /settings/thesettingname\r\n\r\nAnd then I call the setting by appending the setting name (first letter in capitals) to the name show\r\n\r\nshow /settings/spaceusage is showSpaceusage\r\n\r\nThat wasn't a good idea, I should've used a settings/:settingid showSetting(settingId) function instead\r\n","created_at":"2014-02-03T11:12:59Z","updated_at":"2014-02-03T11:12:59Z","html_url":"https://github.com/moodlehq/moodlemobile/pull/55#discussion_r9379390","pull_request_url":"https://api.github.com/repos/moodlehq/moodlemobile/pulls/55","_links":{"self":{"href":"https://api.github.com/repos/moodlehq/moodlemobile/pulls/comments/9379390"},"html":{"href":"https://github.com/moodlehq/moodlemobile/pull/55#discussion_r9379390"},"pull_request":{"href":"https://api.github.com/repos/moodlehq/moodlemobile/pulls/55"}}}}