GitHub PullRequestReviewCommentEvent at 2014-06-30 07:44:25
Repository: MyRadio
Actor: AJDurant
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/UniversityRadioYork/MyRadio/pulls/comments/14338750","id":14338750,"diff_hunk":"@@ -67,6 +67,7 @@ public function __construct($message, $code = 500, Exception $previous = null)\n             //Configuration is available, use this to decide what to do\n             if (Config::$display_errors\n                 or (class_exists('CoreUtils')\n+                && defined('AUTH_SHOWERRORS')","path":"src/Classes/MyRadioException.php","position":4,"original_position":4,"commit_id":"ba8d9ae8bd81515836f7371427d7eaaef681489f","original_commit_id":"ba8d9ae8bd81515836f7371427d7eaaef681489f","user":{"login":"AJDurant","id":763880,"avatar_url":"https://avatars.githubusercontent.com/u/763880?","gravatar_id":"a201b4ebf4b6e88cff2727821bcecbd6","url":"https://api.github.com/users/AJDurant","html_url":"https://github.com/AJDurant","followers_url":"https://api.github.com/users/AJDurant/followers","following_url":"https://api.github.com/users/AJDurant/following{/other_user}","gists_url":"https://api.github.com/users/AJDurant/gists{/gist_id}","starred_url":"https://api.github.com/users/AJDurant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AJDurant/subscriptions","organizations_url":"https://api.github.com/users/AJDurant/orgs","repos_url":"https://api.github.com/users/AJDurant/repos","events_url":"https://api.github.com/users/AJDurant/events{/privacy}","received_events_url":"https://api.github.com/users/AJDurant/received_events","type":"User","site_admin":false},"body":"For some reason at the time I thought we quoted them in functions, but I've\r\nrealised this isn't the case at all... Silly Andy\r\nOn 30 Jun 2014 00:00, \"Lloyd Wallis\" <notifications@github.com> wrote:\r\n\r\n> In src/Classes/MyRadioException.php:\r\n>\r\n> > @@ -67,6 +67,7 @@ public function __construct($message, $code = 500, Exception $previous = null)\r\n> >              //Configuration is available, use this to decide what to do\r\n> >              if (Config::$display_errors\r\n> >                  or (class_exists('CoreUtils')\r\n> > +                && defined('AUTH_SHOWERRORS')\r\n>\r\n> They've always been PHP constants - they're set up in api.php\r\n>\r\n> —\r\n> Reply to this email directly or view it on GitHub\r\n> <https://github.com/UniversityRadioYork/MyRadio/pull/86/files#r14332241>.\r\n>","created_at":"2014-06-30T07:44:25Z","updated_at":"2014-06-30T07:44:25Z","html_url":"https://github.com/UniversityRadioYork/MyRadio/pull/86#discussion_r14338750","pull_request_url":"https://api.github.com/repos/UniversityRadioYork/MyRadio/pulls/86","_links":{"self":{"href":"https://api.github.com/repos/UniversityRadioYork/MyRadio/pulls/comments/14338750"},"html":{"href":"https://github.com/UniversityRadioYork/MyRadio/pull/86#discussion_r14338750"},"pull_request":{"href":"https://api.github.com/repos/UniversityRadioYork/MyRadio/pulls/86"}}},"pull_request":{"url":"https://api.github.com/repos/UniversityRadioYork/MyRadio/pulls/86","id":17273180,"html_url":"https://github.com/UniversityRadioYork/MyRadio/pull/86","diff_url":"https://github.com/UniversityRadioYork/MyRadio/pull/86.diff","patch_url":"https://github.com/UniversityRadioYork/MyRadio/pull/86.patch","issue_url":"https://api.github.com/repos/UniversityRadioYork/MyRadio/issues/86","number":86,"state":"open","title":"Setup","user":{"login":"Flump5281","id":2572695,"avatar_url":"https://avatars.githubusercontent.com/u/2572695?","gravatar_id":"cd9864b221f31d626427da43cf24a4c6","url":"https://api.github.com/users/Flump5281","html_url":"https://github.com/Flump5281","followers_url":"https://api.github.com/users/Flump5281/followers","following_url":"https://api.github.com/users/Flump5281/following{/other_user}","gists_url":"https://api.github.com/users/Flump5281/gists{/gist_id}","starred_url":"https://api.github.com/users/Flump5281/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Flump5281/subscriptions","organizations_url":"https://api.github.com/users/Flump5281/orgs","repos_url":"https://api.github.com/users/Flump5281/repos","events_url":"https://api.github.com/users/Flump5281/events{/privacy}","received_events_url":"https://api.github.com/users/Flump5281/received_events","type":"User","site_admin":false},"body":"I'm submitting this as a PRQ now as it (shouldn't) make breaking changes to production, however does mean that development can be done without access to the production environment.\r\n\r\nEven more than usual, I recommend testing these changes in one of the test directories first before putting it live to the general populace (or potentially even waiting off until after the end of term)","created_at":"2014-06-18T02:54:32Z","updated_at":"2014-06-30T07:44:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6f3ca39b3036eeaf424bf7474a4842da761e3713","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/UniversityRadioYork/MyRadio/pulls/86/commits","review_comments_url":"https://api.github.com/repos/UniversityRadioYork/MyRadio/pulls/86/comments","review_comment_url":"https://api.github.com/repos/UniversityRadioYork/MyRadio/pulls/comments/{number}","comments_url":"https://api.github.com/repos/UniversityRadioYork/MyRadio/issues/86/comments","statuses_url":"https://api.github.com/repos/UniversityRadioYork/MyRadio/statuses/ba8d9ae8bd81515836f7371427d7eaaef681489f","head":{"label":"UniversityRadioYork:setup","ref":"setup","sha":"ba8d9ae8bd81515836f7371427d7eaaef681489f","user":{"login":"UniversityRadioYork","id":823554,"avatar_url":"https://avatars.githubusercontent.com/u/823554?","gravatar_id":"972854c6af9b5b56efb48ca2a0738fe7","url":"https://api.github.com/users/UniversityRadioYork","html_url":"https://github.com/UniversityRadioYork","followers_url":"https://api.github.com/users/UniversityRadioYork/followers","following_url":"https://api.github.com/users/UniversityRadioYork/following{/other_user}","gists_url":"https://api.github.com/users/UniversityRadioYork/gists{/gist_id}","starred_url":"https://api.github.com/users/UniversityRadioYork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UniversityRadioYork/subscriptions","organizations_url":"https://api.github.com/users/UniversityRadioYork/orgs","repos_url":"https://api.github.com/users/UniversityRadioYork/repos","events_url":"https://api.github.com/users/UniversityRadioYork/events{/privacy}","received_events_url":"https://api.github.com/users/UniversityRadioYork/received_events","type":"Organization","site_admin":false},"repo":{"id":12393514,"name":"MyRadio","full_name":"UniversityRadioYork/MyRadio","owner":{"login":"UniversityRadioYork","id":823554,"avatar_url":"https://avatars.githubusercontent.com/u/823554?","gravatar_id":"972854c6af9b5b56efb48ca2a0738fe7","url":"https://api.github.com/users/UniversityRadioYork","html_url":"https://github.com/UniversityRadioYork","followers_url":"https://api.github.com/users/UniversityRadioYork/followers","following_url":"https://api.github.com/users/UniversityRadioYork/following{/other_user}","gists_url":"https://api.github.com/users/UniversityRadioYork/gists{/gist_id}","starred_url":"https://api.github.com/users/UniversityRadioYork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UniversityRadioYork/subscriptions","organizations_url":"https://api.github.com/users/UniversityRadioYork/orgs","repos_url":"https://api.github.com/users/UniversityRadioYork/repos","events_url":"https://api.github.com/users/UniversityRadioYork/events{/privacy}","received_events_url":"https://api.github.com/users/UniversityRadioYork/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/UniversityRadioYork/MyRadio","description":"University Radio York's back-end radio management system","fork":false,"url":"https://api.github.com/repos/UniversityRadioYork/MyRadio","forks_url":"https://api.github.com/repos/UniversityRadioYork/MyRadio/forks","keys_url":"https://api.github.com/repos/UniversityRadioYork/MyRadio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UniversityRadioYork/MyRadio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UniversityRadioYork/MyRadio/teams","hooks_url":"https://api.github.com/repos/UniversityRadioYork/MyRadio/hooks","issue_events_url":"https://api.github.com/repos/UniversityRadioYork/MyRadio/issues/events{/number}","events_url":"https://api.github.com/repos/UniversityRadioYork/MyRadio/events","assignees_url":"https://api.github.com/repos/UniversityRadioYork/MyRadio/assignees{/user}","branches_url":"https://api.github.com/repos/UniversityRadioYork/MyRadio/branches{/branch}","tags_url":"https://api.github.com/repos/UniversityRadioYork/MyRadio/tags","blobs_url":"https://api.github.com/repos/UniversityRadioYork/MyRadio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UniversityRadioYork/MyRadio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UniversityRadioYork/MyRadio/git/refs{/sha}","trees_url":"https://api.github.com/repos/UniversityRadioYork/MyRadio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UniversityRadioYork/MyRadio/statuses/{sha}","languages_url":"https://api.github.com/repos/UniversityRadioYork/MyRadio/languages","stargazers_url":"https://api.github.com/repos/UniversityRadioYork/MyRadio/stargazers","contributors_url":"https://api.github.com/repos/UniversityRadioYork/MyRadio/contributors","subscribers_url":"https://api.github.com/repos/UniversityRadioYork/MyRadio/subscribers","subscription_url":"https://api.github.com/repos/UniversityRadioYork/MyRadio/subscription","commits_url":"https://api.github.com/repos/UniversityRadioYork/MyRadio/commits{/sha}","git_commits_url":"https://api.github.com/repos/UniversityRadioYork/MyRadio/git/commits{/sha}","comments_url":"https://api.github.com/repos/UniversityRadioYork/MyRadio/comments{/number}","issue_comment_url":"https://api.github.com/repos/UniversityRadioYork/MyRadio/issues/comments/{number}","contents_url":"https://api.github.com/repos/UniversityRadioYork/MyRadio/contents/{+path}","compare_url":"https://api.github.com/repos/UniversityRadioYork/MyRadio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UniversityRadioYork/MyRadio/merges","archive_url":"https://api.github.com/repos/UniversityRadioYork/MyRadio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UniversityRadioYork/MyRadio/downloads","issues_url":"https://api.github.com/repos/UniversityRadioYork/MyRadio/issues{/number}","pulls_url":"https://api.github.com/repos/UniversityRadioYork/MyRadio/pulls{/number}","milestones_url":"https://api.github.com/repos/UniversityRadioYork/MyRadio/milestones{/number}","notifications_url":"https://api.github.com/repos/UniversityRadioYork/MyRadio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UniversityRadioYork/MyRadio/labels{/name}","releases_url":"https://api.github.com/repos/UniversityRadioYork/MyRadio/releases{/id}","created_at":"2013-08-27T00:56:25Z","updated_at":"2014-06-28T15:33:19Z","pushed_at":"2014-06-28T15:33:47Z","git_url":"git://github.com/UniversityRadioYork/MyRadio.git","ssh_url":"git@github.com:UniversityRadioYork/MyRadio.git","clone_url":"https://github.com/UniversityRadioYork/MyRadio.git","svn_url":"https://github.com/UniversityRadioYork/MyRadio","homepage":"http://ury.org.uk","size":10165,"stargazers_count":3,"watchers_count":3,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":7,"mirror_url":null,"open_issues_count":27,"forks":7,"open_issues":27,"watchers":3,"default_branch":"master"}},"base":{"label":"UniversityRadioYork:master","ref":"master","sha":"08fe41348fdfb33c8ee976d46f43f5d83d1b3fdb","user":{"login":"UniversityRadioYork","id":823554,"avatar_url":"https://avatars.githubusercontent.com/u/823554?","gravatar_id":"972854c6af9b5b56efb48ca2a0738fe7","url":"https://api.github.com/users/UniversityRadioYork","html_url":"https://github.com/UniversityRadioYork","followers_url":"https://api.github.com/users/UniversityRadioYork/followers","following_url":"https://api.github.com/users/UniversityRadioYork/following{/other_user}","gists_url":"https://api.github.com/users/UniversityRadioYork/gists{/gist_id}","starred_url":"https://api.github.com/users/UniversityRadioYork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UniversityRadioYork/subscriptions","organizations_url":"https://api.github.com/users/UniversityRadioYork/orgs","repos_url":"https://api.github.com/users/UniversityRadioYork/repos","events_url":"https://api.github.com/users/UniversityRadioYork/events{/privacy}","received_events_url":"https://api.github.com/users/UniversityRadioYork/received_events","type":"Organization","site_admin":false},"repo":{"id":12393514,"name":"MyRadio","full_name":"UniversityRadioYork/MyRadio","owner":{"login":"UniversityRadioYork","id":823554,"avatar_url":"https://avatars.githubusercontent.com/u/823554?","gravatar_id":"972854c6af9b5b56efb48ca2a0738fe7","url":"https://api.github.com/users/UniversityRadioYork","html_url":"https://github.com/UniversityRadioYork","followers_url":"https://api.github.com/users/UniversityRadioYork/followers","following_url":"https://api.github.com/users/UniversityRadioYork/following{/other_user}","gists_url":"https://api.github.com/users/UniversityRadioYork/gists{/gist_id}","starred_url":"https://api.github.com/users/UniversityRadioYork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UniversityRadioYork/subscriptions","organizations_url":"https://api.github.com/users/UniversityRadioYork/orgs","repos_url":"https://api.github.com/users/UniversityRadioYork/repos","events_url":"https://api.github.com/users/UniversityRadioYork/events{/privacy}","received_events_url":"https://api.github.com/users/UniversityRadioYork/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/UniversityRadioYork/MyRadio","description":"University Radio York's back-end radio management system","fork":false,"url":"https://api.github.com/repos/UniversityRadioYork/MyRadio","forks_url":"https://api.github.com/repos/UniversityRadioYork/MyRadio/forks","keys_url":"https://api.github.com/repos/UniversityRadioYork/MyRadio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UniversityRadioYork/MyRadio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UniversityRadioYork/MyRadio/teams","hooks_url":"https://api.github.com/repos/UniversityRadioYork/MyRadio/hooks","issue_events_url":"https://api.github.com/repos/UniversityRadioYork/MyRadio/issues/events{/number}","events_url":"https://api.github.com/repos/UniversityRadioYork/MyRadio/events","assignees_url":"https://api.github.com/repos/UniversityRadioYork/MyRadio/assignees{/user}","branches_url":"https://api.github.com/repos/UniversityRadioYork/MyRadio/branches{/branch}","tags_url":"https://api.github.com/repos/UniversityRadioYork/MyRadio/tags","blobs_url":"https://api.github.com/repos/UniversityRadioYork/MyRadio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UniversityRadioYork/MyRadio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UniversityRadioYork/MyRadio/git/refs{/sha}","trees_url":"https://api.github.com/repos/UniversityRadioYork/MyRadio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UniversityRadioYork/MyRadio/statuses/{sha}","languages_url":"https://api.github.com/repos/UniversityRadioYork/MyRadio/languages","stargazers_url":"https://api.github.com/repos/UniversityRadioYork/MyRadio/stargazers","contributors_url":"https://api.github.com/repos/UniversityRadioYork/MyRadio/contributors","subscribers_url":"https://api.github.com/repos/UniversityRadioYork/MyRadio/subscribers","subscription_url":"https://api.github.com/repos/UniversityRadioYork/MyRadio/subscription","commits_url":"https://api.github.com/repos/UniversityRadioYork/MyRadio/commits{/sha}","git_commits_url":"https://api.github.com/repos/UniversityRadioYork/MyRadio/git/commits{/sha}","comments_url":"https://api.github.com/repos/UniversityRadioYork/MyRadio/comments{/number}","issue_comment_url":"https://api.github.com/repos/UniversityRadioYork/MyRadio/issues/comments/{number}","contents_url":"https://api.github.com/repos/UniversityRadioYork/MyRadio/contents/{+path}","compare_url":"https://api.github.com/repos/UniversityRadioYork/MyRadio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UniversityRadioYork/MyRadio/merges","archive_url":"https://api.github.com/repos/UniversityRadioYork/MyRadio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UniversityRadioYork/MyRadio/downloads","issues_url":"https://api.github.com/repos/UniversityRadioYork/MyRadio/issues{/number}","pulls_url":"https://api.github.com/repos/UniversityRadioYork/MyRadio/pulls{/number}","milestones_url":"https://api.github.com/repos/UniversityRadioYork/MyRadio/milestones{/number}","notifications_url":"https://api.github.com/repos/UniversityRadioYork/MyRadio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UniversityRadioYork/MyRadio/labels{/name}","releases_url":"https://api.github.com/repos/UniversityRadioYork/MyRadio/releases{/id}","created_at":"2013-08-27T00:56:25Z","updated_at":"2014-06-28T15:33:19Z","pushed_at":"2014-06-28T15:33:47Z","git_url":"git://github.com/UniversityRadioYork/MyRadio.git","ssh_url":"git@github.com:UniversityRadioYork/MyRadio.git","clone_url":"https://github.com/UniversityRadioYork/MyRadio.git","svn_url":"https://github.com/UniversityRadioYork/MyRadio","homepage":"http://ury.org.uk","size":10165,"stargazers_count":3,"watchers_count":3,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":7,"mirror_url":null,"open_issues_count":27,"forks":7,"open_issues":27,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/UniversityRadioYork/MyRadio/pulls/86"},"html":{"href":"https://github.com/UniversityRadioYork/MyRadio/pull/86"},"issue":{"href":"https://api.github.com/repos/UniversityRadioYork/MyRadio/issues/86"},"comments":{"href":"https://api.github.com/repos/UniversityRadioYork/MyRadio/issues/86/comments"},"review_comments":{"href":"https://api.github.com/repos/UniversityRadioYork/MyRadio/pulls/86/comments"},"review_comment":{"href":"https://api.github.com/repos/UniversityRadioYork/MyRadio/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/UniversityRadioYork/MyRadio/pulls/86/commits"},"statuses":{"href":"https://api.github.com/repos/UniversityRadioYork/MyRadio/statuses/ba8d9ae8bd81515836f7371427d7eaaef681489f"}}}}