GitHub PullRequestEvent at 2014-01-03 18:07:36
Repository: FileAPI
Actor: korzhyk
Payload: {"action":"closed","number":175,"pull_request":{"url":"https://api.github.com/repos/mailru/FileAPI/pulls/175","id":11212705,"html_url":"https://github.com/mailru/FileAPI/pull/175","diff_url":"https://github.com/mailru/FileAPI/pull/175.diff","patch_url":"https://github.com/mailru/FileAPI/pull/175.patch","issue_url":"https://github.com/mailru/FileAPI/pull/175","number":175,"state":"closed","title":"Add params to the beginning of form.","user":{"login":"korzhyk","id":1100134,"avatar_url":"https://gravatar.com/avatar/f0bfa975bc6e87457c25002d93c2d626?d=https%3A%2F%2Fidenticons.github.com%2F9661108f25c19614f42c6307666ff18c.png&r=x","gravatar_id":"f0bfa975bc6e87457c25002d93c2d626","url":"https://api.github.com/users/korzhyk","html_url":"https://github.com/korzhyk","followers_url":"https://api.github.com/users/korzhyk/followers","following_url":"https://api.github.com/users/korzhyk/following{/other_user}","gists_url":"https://api.github.com/users/korzhyk/gists{/gist_id}","starred_url":"https://api.github.com/users/korzhyk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/korzhyk/subscriptions","organizations_url":"https://api.github.com/users/korzhyk/orgs","repos_url":"https://api.github.com/users/korzhyk/repos","events_url":"https://api.github.com/users/korzhyk/events{/privacy}","received_events_url":"https://api.github.com/users/korzhyk/received_events","type":"User","site_admin":false},"body":"Добавлять параметры загрузки (params) на начало формы.\r\n\r\nhttps://github.com/mailru/FileAPI/blob/dev/lib/FileAPI.core.js#L1619-L1629\r\n\r\nЗачем это нужно!?\r\nНапример на стороне сервера у нас есть **stream** обработчик формы, допустим для загрузки файла нужно указать ключ/токен (в [params](https://github.com/mailru/FileAPI/blob/dev/lib/FileAPI.core.js#L1620)) или что то еще. \r\n\r\nПотом когда начало формы прилетит на сервер мы сможем получить параметры и продолжить загрузку файла в противном случае нам нужно будет закачать файл (а это ресурсы и время работы скриптов) и только потом сделать проверку.\r\n\r\nДа, есть QueryString и Headers, но думаю еще один способ не помешает.","created_at":"2014-01-03T17:21:20Z","updated_at":"2014-01-03T18:07:36Z","closed_at":"2014-01-03T18:07:36Z","merged_at":null,"merge_commit_sha":"32539e9eef3e677a3d2a401dd7a1e010aaec17af","assignee":null,"milestone":null,"commits_url":"https://github.com/mailru/FileAPI/pull/175/commits","review_comments_url":"https://github.com/mailru/FileAPI/pull/175/comments","review_comment_url":"/repos/mailru/FileAPI/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mailru/FileAPI/issues/175/comments","statuses_url":"https://api.github.com/repos/mailru/FileAPI/statuses/5249a7ffd644856a6befd4d9d4a808a0fab5407e","head":{"label":"korzhyk:dev","ref":"dev","sha":"5249a7ffd644856a6befd4d9d4a808a0fab5407e","user":{"login":"korzhyk","id":1100134,"avatar_url":"https://gravatar.com/avatar/f0bfa975bc6e87457c25002d93c2d626?d=https%3A%2F%2Fidenticons.github.com%2F9661108f25c19614f42c6307666ff18c.png&r=x","gravatar_id":"f0bfa975bc6e87457c25002d93c2d626","url":"https://api.github.com/users/korzhyk","html_url":"https://github.com/korzhyk","followers_url":"https://api.github.com/users/korzhyk/followers","following_url":"https://api.github.com/users/korzhyk/following{/other_user}","gists_url":"https://api.github.com/users/korzhyk/gists{/gist_id}","starred_url":"https://api.github.com/users/korzhyk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/korzhyk/subscriptions","organizations_url":"https://api.github.com/users/korzhyk/orgs","repos_url":"https://api.github.com/users/korzhyk/repos","events_url":"https://api.github.com/users/korzhyk/events{/privacy}","received_events_url":"https://api.github.com/users/korzhyk/received_events","type":"User","site_admin":false},"repo":{"id":15614176,"name":"FileAPI","full_name":"korzhyk/FileAPI","owner":{"login":"korzhyk","id":1100134,"avatar_url":"https://gravatar.com/avatar/f0bfa975bc6e87457c25002d93c2d626?d=https%3A%2F%2Fidenticons.github.com%2F9661108f25c19614f42c6307666ff18c.png&r=x","gravatar_id":"f0bfa975bc6e87457c25002d93c2d626","url":"https://api.github.com/users/korzhyk","html_url":"https://github.com/korzhyk","followers_url":"https://api.github.com/users/korzhyk/followers","following_url":"https://api.github.com/users/korzhyk/following{/other_user}","gists_url":"https://api.github.com/users/korzhyk/gists{/gist_id}","starred_url":"https://api.github.com/users/korzhyk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/korzhyk/subscriptions","organizations_url":"https://api.github.com/users/korzhyk/orgs","repos_url":"https://api.github.com/users/korzhyk/repos","events_url":"https://api.github.com/users/korzhyk/events{/privacy}","received_events_url":"https://api.github.com/users/korzhyk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/korzhyk/FileAPI","description":"FileAPI — a set of  javascript tools for working with files. Multiupload, drag'n'drop and chunked file upload. Images: crop, resize and auto orientation by EXIF.","fork":true,"url":"https://api.github.com/repos/korzhyk/FileAPI","forks_url":"https://api.github.com/repos/korzhyk/FileAPI/forks","keys_url":"https://api.github.com/repos/korzhyk/FileAPI/keys{/key_id}","collaborators_url":"https://api.github.com/repos/korzhyk/FileAPI/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/korzhyk/FileAPI/teams","hooks_url":"https://api.github.com/repos/korzhyk/FileAPI/hooks","issue_events_url":"https://api.github.com/repos/korzhyk/FileAPI/issues/events{/number}","events_url":"https://api.github.com/repos/korzhyk/FileAPI/events","assignees_url":"https://api.github.com/repos/korzhyk/FileAPI/assignees{/user}","branches_url":"https://api.github.com/repos/korzhyk/FileAPI/branches{/branch}","tags_url":"https://api.github.com/repos/korzhyk/FileAPI/tags","blobs_url":"https://api.github.com/repos/korzhyk/FileAPI/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/korzhyk/FileAPI/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/korzhyk/FileAPI/git/refs{/sha}","trees_url":"https://api.github.com/repos/korzhyk/FileAPI/git/trees{/sha}","statuses_url":"https://api.github.com/repos/korzhyk/FileAPI/statuses/{sha}","languages_url":"https://api.github.com/repos/korzhyk/FileAPI/languages","stargazers_url":"https://api.github.com/repos/korzhyk/FileAPI/stargazers","contributors_url":"https://api.github.com/repos/korzhyk/FileAPI/contributors","subscribers_url":"https://api.github.com/repos/korzhyk/FileAPI/subscribers","subscription_url":"https://api.github.com/repos/korzhyk/FileAPI/subscription","commits_url":"https://api.github.com/repos/korzhyk/FileAPI/commits{/sha}","git_commits_url":"https://api.github.com/repos/korzhyk/FileAPI/git/commits{/sha}","comments_url":"https://api.github.com/repos/korzhyk/FileAPI/comments{/number}","issue_comment_url":"https://api.github.com/repos/korzhyk/FileAPI/issues/comments/{number}","contents_url":"https://api.github.com/repos/korzhyk/FileAPI/contents/{+path}","compare_url":"https://api.github.com/repos/korzhyk/FileAPI/compare/{base}...{head}","merges_url":"https://api.github.com/repos/korzhyk/FileAPI/merges","archive_url":"https://api.github.com/repos/korzhyk/FileAPI/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/korzhyk/FileAPI/downloads","issues_url":"https://api.github.com/repos/korzhyk/FileAPI/issues{/number}","pulls_url":"https://api.github.com/repos/korzhyk/FileAPI/pulls{/number}","milestones_url":"https://api.github.com/repos/korzhyk/FileAPI/milestones{/number}","notifications_url":"https://api.github.com/repos/korzhyk/FileAPI/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/korzhyk/FileAPI/labels{/name}","releases_url":"https://api.github.com/repos/korzhyk/FileAPI/releases{/id}","created_at":"2014-01-03T16:44:06Z","updated_at":"2014-01-03T18:07:36Z","pushed_at":"2014-01-03T18:01:40Z","git_url":"git://github.com/korzhyk/FileAPI.git","ssh_url":"git@github.com:korzhyk/FileAPI.git","clone_url":"https://github.com/korzhyk/FileAPI.git","svn_url":"https://github.com/korzhyk/FileAPI","homepage":"http://mailru.github.io/FileAPI/","size":4110,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master","master_branch":"master"}},"base":{"label":"mailru:dev","ref":"dev","sha":"a946f68ad2e0100e23418f26636e2c7cf71a311c","user":{"login":"mailru","id":399923,"avatar_url":"https://gravatar.com/avatar/84de621402815f197fb2c46994411c00?d=https%3A%2F%2Fidenticons.github.com%2F5c2b9f38cfea8628843da42e4953efdc.png&r=x","gravatar_id":"84de621402815f197fb2c46994411c00","url":"https://api.github.com/users/mailru","html_url":"https://github.com/mailru","followers_url":"https://api.github.com/users/mailru/followers","following_url":"https://api.github.com/users/mailru/following{/other_user}","gists_url":"https://api.github.com/users/mailru/gists{/gist_id}","starred_url":"https://api.github.com/users/mailru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mailru/subscriptions","organizations_url":"https://api.github.com/users/mailru/orgs","repos_url":"https://api.github.com/users/mailru/repos","events_url":"https://api.github.com/users/mailru/events{/privacy}","received_events_url":"https://api.github.com/users/mailru/received_events","type":"Organization","site_admin":false},"repo":{"id":3197382,"name":"FileAPI","full_name":"mailru/FileAPI","owner":{"login":"mailru","id":399923,"avatar_url":"https://gravatar.com/avatar/84de621402815f197fb2c46994411c00?d=https%3A%2F%2Fidenticons.github.com%2F5c2b9f38cfea8628843da42e4953efdc.png&r=x","gravatar_id":"84de621402815f197fb2c46994411c00","url":"https://api.github.com/users/mailru","html_url":"https://github.com/mailru","followers_url":"https://api.github.com/users/mailru/followers","following_url":"https://api.github.com/users/mailru/following{/other_user}","gists_url":"https://api.github.com/users/mailru/gists{/gist_id}","starred_url":"https://api.github.com/users/mailru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mailru/subscriptions","organizations_url":"https://api.github.com/users/mailru/orgs","repos_url":"https://api.github.com/users/mailru/repos","events_url":"https://api.github.com/users/mailru/events{/privacy}","received_events_url":"https://api.github.com/users/mailru/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mailru/FileAPI","description":"FileAPI — a set of  javascript tools for working with files. Multiupload, drag'n'drop and chunked file upload. Images: crop, resize and auto orientation by EXIF.","fork":false,"url":"https://api.github.com/repos/mailru/FileAPI","forks_url":"https://api.github.com/repos/mailru/FileAPI/forks","keys_url":"https://api.github.com/repos/mailru/FileAPI/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mailru/FileAPI/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mailru/FileAPI/teams","hooks_url":"https://api.github.com/repos/mailru/FileAPI/hooks","issue_events_url":"https://api.github.com/repos/mailru/FileAPI/issues/events{/number}","events_url":"https://api.github.com/repos/mailru/FileAPI/events","assignees_url":"https://api.github.com/repos/mailru/FileAPI/assignees{/user}","branches_url":"https://api.github.com/repos/mailru/FileAPI/branches{/branch}","tags_url":"https://api.github.com/repos/mailru/FileAPI/tags","blobs_url":"https://api.github.com/repos/mailru/FileAPI/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mailru/FileAPI/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mailru/FileAPI/git/refs{/sha}","trees_url":"https://api.github.com/repos/mailru/FileAPI/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mailru/FileAPI/statuses/{sha}","languages_url":"https://api.github.com/repos/mailru/FileAPI/languages","stargazers_url":"https://api.github.com/repos/mailru/FileAPI/stargazers","contributors_url":"https://api.github.com/repos/mailru/FileAPI/contributors","subscribers_url":"https://api.github.com/repos/mailru/FileAPI/subscribers","subscription_url":"https://api.github.com/repos/mailru/FileAPI/subscription","commits_url":"https://api.github.com/repos/mailru/FileAPI/commits{/sha}","git_commits_url":"https://api.github.com/repos/mailru/FileAPI/git/commits{/sha}","comments_url":"https://api.github.com/repos/mailru/FileAPI/comments{/number}","issue_comment_url":"https://api.github.com/repos/mailru/FileAPI/issues/comments/{number}","contents_url":"https://api.github.com/repos/mailru/FileAPI/contents/{+path}","compare_url":"https://api.github.com/repos/mailru/FileAPI/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mailru/FileAPI/merges","archive_url":"https://api.github.com/repos/mailru/FileAPI/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mailru/FileAPI/downloads","issues_url":"https://api.github.com/repos/mailru/FileAPI/issues{/number}","pulls_url":"https://api.github.com/repos/mailru/FileAPI/pulls{/number}","milestones_url":"https://api.github.com/repos/mailru/FileAPI/milestones{/number}","notifications_url":"https://api.github.com/repos/mailru/FileAPI/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mailru/FileAPI/labels{/name}","releases_url":"https://api.github.com/repos/mailru/FileAPI/releases{/id}","created_at":"2012-01-17T06:47:39Z","updated_at":"2014-01-03T16:44:06Z","pushed_at":"2013-12-05T18:26:01Z","git_url":"git://github.com/mailru/FileAPI.git","ssh_url":"git@github.com:mailru/FileAPI.git","clone_url":"https://github.com/mailru/FileAPI.git","svn_url":"https://github.com/mailru/FileAPI","homepage":"http://mailru.github.io/FileAPI/","size":4658,"stargazers_count":1382,"watchers_count":1382,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":155,"mirror_url":null,"open_issues_count":8,"forks":155,"open_issues":8,"watchers":1382,"default_branch":"master","master_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mailru/FileAPI/pulls/175"},"html":{"href":"https://github.com/mailru/FileAPI/pull/175"},"issue":{"href":"https://api.github.com/repos/mailru/FileAPI/issues/175"},"comments":{"href":"https://api.github.com/repos/mailru/FileAPI/issues/175/comments"},"review_comments":{"href":"https://api.github.com/repos/mailru/FileAPI/pulls/175/comments"},"statuses":{"href":"https://api.github.com/repos/mailru/FileAPI/statuses/5249a7ffd644856a6befd4d9d4a808a0fab5407e"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":1,"review_comments":0,"commits":1,"additions":38,"deletions":41,"changed_files":5}}