GitHub PullRequestReviewCommentEvent at 2014-11-11 07:16:16
Repository: jekyll
Actor: parkr
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/jekyll/jekyll/pulls/comments/20134987","id":20134987,"diff_hunk":"@@ -144,9 +144,9 @@ def sanitized_path(base_directory, questionable_path)\n       return base_directory if base_directory.eql?(questionable_path)\n \n       clean_path = File.expand_path(questionable_path, \"/\")\n-      clean_path = clean_path.sub(/^\\A\\w\\:\\//, '/')\n+      clean_path = clean_path.sub(/\\A\\w\\:\\//, '/')\n \n-      unless clean_path.start_with?(base_directory.sub(/^\\A\\w\\:\\//, '/'))\n+      unless clean_path.start_with?(base_directory.sub(/\\A\\w\\:\\//, '/'))","path":"lib/jekyll.rb","position":8,"original_position":8,"commit_id":"bd907c5be68070ad9f4411e4d614a9ed48e46118","original_commit_id":"bd907c5be68070ad9f4411e4d614a9ed48e46118","user":{"login":"parkr","id":237985,"avatar_url":"https://avatars.githubusercontent.com/u/237985?v=3","gravatar_id":"","url":"https://api.github.com/users/parkr","html_url":"https://github.com/parkr","followers_url":"https://api.github.com/users/parkr/followers","following_url":"https://api.github.com/users/parkr/following{/other_user}","gists_url":"https://api.github.com/users/parkr/gists{/gist_id}","starred_url":"https://api.github.com/users/parkr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parkr/subscriptions","organizations_url":"https://api.github.com/users/parkr/orgs","repos_url":"https://api.github.com/users/parkr/repos","events_url":"https://api.github.com/users/parkr/events{/privacy}","received_events_url":"https://api.github.com/users/parkr/received_events","type":"User","site_admin":false},"body":"@mastahyeti Will ship with your approval. Perhaps I need to stub out `File.expand_path` such that returns the Windows paths. The real problem is that the method as it stands right now can't be fluidly tested on a unix machine.","created_at":"2014-11-11T07:16:16Z","updated_at":"2014-11-11T07:16:16Z","html_url":"https://github.com/jekyll/jekyll/pull/3089#discussion_r20134987","pull_request_url":"https://api.github.com/repos/jekyll/jekyll/pulls/3089","_links":{"self":{"href":"https://api.github.com/repos/jekyll/jekyll/pulls/comments/20134987"},"html":{"href":"https://github.com/jekyll/jekyll/pull/3089#discussion_r20134987"},"pull_request":{"href":"https://api.github.com/repos/jekyll/jekyll/pulls/3089"}}},"pull_request":{"url":"https://api.github.com/repos/jekyll/jekyll/pulls/3089","id":24171292,"html_url":"https://github.com/jekyll/jekyll/pull/3089","diff_url":"https://github.com/jekyll/jekyll/pull/3089.diff","patch_url":"https://github.com/jekyll/jekyll/pull/3089.patch","issue_url":"https://api.github.com/repos/jekyll/jekyll/issues/3089","number":3089,"state":"open","locked":false,"title":"Remove duplicate regexp phrase: ^\\A","user":{"login":"parkr","id":237985,"avatar_url":"https://avatars.githubusercontent.com/u/237985?v=3","gravatar_id":"","url":"https://api.github.com/users/parkr","html_url":"https://github.com/parkr","followers_url":"https://api.github.com/users/parkr/followers","following_url":"https://api.github.com/users/parkr/following{/other_user}","gists_url":"https://api.github.com/users/parkr/gists{/gist_id}","starred_url":"https://api.github.com/users/parkr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parkr/subscriptions","organizations_url":"https://api.github.com/users/parkr/orgs","repos_url":"https://api.github.com/users/parkr/repos","events_url":"https://api.github.com/users/parkr/events{/privacy}","received_events_url":"https://api.github.com/users/parkr/received_events","type":"User","site_admin":false},"body":"Addresses @mastahyeti's comment in #3077: https://github.com/jekyll/jekyll/pull/3077#discussion_r20077150\r\n\r\nNo clue how the tests passed with that invalid regexp. It's frustrating not being able to CI this on Windows.","created_at":"2014-11-10T19:36:14Z","updated_at":"2014-11-11T07:16:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"778154da25d3a76a29674969e7ff5f35dc9a389f","assignee":{"login":"parkr","id":237985,"avatar_url":"https://avatars.githubusercontent.com/u/237985?v=3","gravatar_id":"","url":"https://api.github.com/users/parkr","html_url":"https://github.com/parkr","followers_url":"https://api.github.com/users/parkr/followers","following_url":"https://api.github.com/users/parkr/following{/other_user}","gists_url":"https://api.github.com/users/parkr/gists{/gist_id}","starred_url":"https://api.github.com/users/parkr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parkr/subscriptions","organizations_url":"https://api.github.com/users/parkr/orgs","repos_url":"https://api.github.com/users/parkr/repos","events_url":"https://api.github.com/users/parkr/events{/privacy}","received_events_url":"https://api.github.com/users/parkr/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/jekyll/jekyll/milestones/27","labels_url":"https://api.github.com/repos/jekyll/jekyll/milestones/27/labels","id":860603,"number":27,"title":"2.5.2","description":null,"creator":{"login":"parkr","id":237985,"avatar_url":"https://avatars.githubusercontent.com/u/237985?v=3","gravatar_id":"","url":"https://api.github.com/users/parkr","html_url":"https://github.com/parkr","followers_url":"https://api.github.com/users/parkr/followers","following_url":"https://api.github.com/users/parkr/following{/other_user}","gists_url":"https://api.github.com/users/parkr/gists{/gist_id}","starred_url":"https://api.github.com/users/parkr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parkr/subscriptions","organizations_url":"https://api.github.com/users/parkr/orgs","repos_url":"https://api.github.com/users/parkr/repos","events_url":"https://api.github.com/users/parkr/events{/privacy}","received_events_url":"https://api.github.com/users/parkr/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":1,"state":"open","created_at":"2014-11-10T19:37:02Z","updated_at":"2014-11-10T20:02:29Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/jekyll/jekyll/pulls/3089/commits","review_comments_url":"https://api.github.com/repos/jekyll/jekyll/pulls/3089/comments","review_comment_url":"https://api.github.com/repos/jekyll/jekyll/pulls/comments/{number}","comments_url":"https://api.github.com/repos/jekyll/jekyll/issues/3089/comments","statuses_url":"https://api.github.com/repos/jekyll/jekyll/statuses/bd907c5be68070ad9f4411e4d614a9ed48e46118","head":{"label":"jekyll:remove-duplication-in-regexp","ref":"remove-duplication-in-regexp","sha":"bd907c5be68070ad9f4411e4d614a9ed48e46118","user":{"login":"jekyll","id":3083652,"avatar_url":"https://avatars.githubusercontent.com/u/3083652?v=3","gravatar_id":"","url":"https://api.github.com/users/jekyll","html_url":"https://github.com/jekyll","followers_url":"https://api.github.com/users/jekyll/followers","following_url":"https://api.github.com/users/jekyll/following{/other_user}","gists_url":"https://api.github.com/users/jekyll/gists{/gist_id}","starred_url":"https://api.github.com/users/jekyll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jekyll/subscriptions","organizations_url":"https://api.github.com/users/jekyll/orgs","repos_url":"https://api.github.com/users/jekyll/repos","events_url":"https://api.github.com/users/jekyll/events{/privacy}","received_events_url":"https://api.github.com/users/jekyll/received_events","type":"Organization","site_admin":false},"repo":{"id":65252,"name":"jekyll","full_name":"jekyll/jekyll","owner":{"login":"jekyll","id":3083652,"avatar_url":"https://avatars.githubusercontent.com/u/3083652?v=3","gravatar_id":"","url":"https://api.github.com/users/jekyll","html_url":"https://github.com/jekyll","followers_url":"https://api.github.com/users/jekyll/followers","following_url":"https://api.github.com/users/jekyll/following{/other_user}","gists_url":"https://api.github.com/users/jekyll/gists{/gist_id}","starred_url":"https://api.github.com/users/jekyll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jekyll/subscriptions","organizations_url":"https://api.github.com/users/jekyll/orgs","repos_url":"https://api.github.com/users/jekyll/repos","events_url":"https://api.github.com/users/jekyll/events{/privacy}","received_events_url":"https://api.github.com/users/jekyll/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jekyll/jekyll","description":"Jekyll is a blog-aware, static site generator in Ruby","fork":false,"url":"https://api.github.com/repos/jekyll/jekyll","forks_url":"https://api.github.com/repos/jekyll/jekyll/forks","keys_url":"https://api.github.com/repos/jekyll/jekyll/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jekyll/jekyll/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jekyll/jekyll/teams","hooks_url":"https://api.github.com/repos/jekyll/jekyll/hooks","issue_events_url":"https://api.github.com/repos/jekyll/jekyll/issues/events{/number}","events_url":"https://api.github.com/repos/jekyll/jekyll/events","assignees_url":"https://api.github.com/repos/jekyll/jekyll/assignees{/user}","branches_url":"https://api.github.com/repos/jekyll/jekyll/branches{/branch}","tags_url":"https://api.github.com/repos/jekyll/jekyll/tags","blobs_url":"https://api.github.com/repos/jekyll/jekyll/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jekyll/jekyll/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jekyll/jekyll/git/refs{/sha}","trees_url":"https://api.github.com/repos/jekyll/jekyll/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jekyll/jekyll/statuses/{sha}","languages_url":"https://api.github.com/repos/jekyll/jekyll/languages","stargazers_url":"https://api.github.com/repos/jekyll/jekyll/stargazers","contributors_url":"https://api.github.com/repos/jekyll/jekyll/contributors","subscribers_url":"https://api.github.com/repos/jekyll/jekyll/subscribers","subscription_url":"https://api.github.com/repos/jekyll/jekyll/subscription","commits_url":"https://api.github.com/repos/jekyll/jekyll/commits{/sha}","git_commits_url":"https://api.github.com/repos/jekyll/jekyll/git/commits{/sha}","comments_url":"https://api.github.com/repos/jekyll/jekyll/comments{/number}","issue_comment_url":"https://api.github.com/repos/jekyll/jekyll/issues/comments/{number}","contents_url":"https://api.github.com/repos/jekyll/jekyll/contents/{+path}","compare_url":"https://api.github.com/repos/jekyll/jekyll/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jekyll/jekyll/merges","archive_url":"https://api.github.com/repos/jekyll/jekyll/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jekyll/jekyll/downloads","issues_url":"https://api.github.com/repos/jekyll/jekyll/issues{/number}","pulls_url":"https://api.github.com/repos/jekyll/jekyll/pulls{/number}","milestones_url":"https://api.github.com/repos/jekyll/jekyll/milestones{/number}","notifications_url":"https://api.github.com/repos/jekyll/jekyll/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jekyll/jekyll/labels{/name}","releases_url":"https://api.github.com/repos/jekyll/jekyll/releases{/id}","created_at":"2008-10-20T06:29:03Z","updated_at":"2014-11-11T07:02:31Z","pushed_at":"2014-11-10T20:02:25Z","git_url":"git://github.com/jekyll/jekyll.git","ssh_url":"git@github.com:jekyll/jekyll.git","clone_url":"https://github.com/jekyll/jekyll.git","svn_url":"https://github.com/jekyll/jekyll","homepage":"http://jekyllrb.com","size":92728,"stargazers_count":17276,"watchers_count":17276,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3586,"mirror_url":null,"open_issues_count":126,"forks":3586,"open_issues":126,"watchers":17276,"default_branch":"master"}},"base":{"label":"jekyll:master","ref":"master","sha":"c79fe1125c91dee059420599201ff98a76121446","user":{"login":"jekyll","id":3083652,"avatar_url":"https://avatars.githubusercontent.com/u/3083652?v=3","gravatar_id":"","url":"https://api.github.com/users/jekyll","html_url":"https://github.com/jekyll","followers_url":"https://api.github.com/users/jekyll/followers","following_url":"https://api.github.com/users/jekyll/following{/other_user}","gists_url":"https://api.github.com/users/jekyll/gists{/gist_id}","starred_url":"https://api.github.com/users/jekyll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jekyll/subscriptions","organizations_url":"https://api.github.com/users/jekyll/orgs","repos_url":"https://api.github.com/users/jekyll/repos","events_url":"https://api.github.com/users/jekyll/events{/privacy}","received_events_url":"https://api.github.com/users/jekyll/received_events","type":"Organization","site_admin":false},"repo":{"id":65252,"name":"jekyll","full_name":"jekyll/jekyll","owner":{"login":"jekyll","id":3083652,"avatar_url":"https://avatars.githubusercontent.com/u/3083652?v=3","gravatar_id":"","url":"https://api.github.com/users/jekyll","html_url":"https://github.com/jekyll","followers_url":"https://api.github.com/users/jekyll/followers","following_url":"https://api.github.com/users/jekyll/following{/other_user}","gists_url":"https://api.github.com/users/jekyll/gists{/gist_id}","starred_url":"https://api.github.com/users/jekyll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jekyll/subscriptions","organizations_url":"https://api.github.com/users/jekyll/orgs","repos_url":"https://api.github.com/users/jekyll/repos","events_url":"https://api.github.com/users/jekyll/events{/privacy}","received_events_url":"https://api.github.com/users/jekyll/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jekyll/jekyll","description":"Jekyll is a blog-aware, static site generator in Ruby","fork":false,"url":"https://api.github.com/repos/jekyll/jekyll","forks_url":"https://api.github.com/repos/jekyll/jekyll/forks","keys_url":"https://api.github.com/repos/jekyll/jekyll/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jekyll/jekyll/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jekyll/jekyll/teams","hooks_url":"https://api.github.com/repos/jekyll/jekyll/hooks","issue_events_url":"https://api.github.com/repos/jekyll/jekyll/issues/events{/number}","events_url":"https://api.github.com/repos/jekyll/jekyll/events","assignees_url":"https://api.github.com/repos/jekyll/jekyll/assignees{/user}","branches_url":"https://api.github.com/repos/jekyll/jekyll/branches{/branch}","tags_url":"https://api.github.com/repos/jekyll/jekyll/tags","blobs_url":"https://api.github.com/repos/jekyll/jekyll/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jekyll/jekyll/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jekyll/jekyll/git/refs{/sha}","trees_url":"https://api.github.com/repos/jekyll/jekyll/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jekyll/jekyll/statuses/{sha}","languages_url":"https://api.github.com/repos/jekyll/jekyll/languages","stargazers_url":"https://api.github.com/repos/jekyll/jekyll/stargazers","contributors_url":"https://api.github.com/repos/jekyll/jekyll/contributors","subscribers_url":"https://api.github.com/repos/jekyll/jekyll/subscribers","subscription_url":"https://api.github.com/repos/jekyll/jekyll/subscription","commits_url":"https://api.github.com/repos/jekyll/jekyll/commits{/sha}","git_commits_url":"https://api.github.com/repos/jekyll/jekyll/git/commits{/sha}","comments_url":"https://api.github.com/repos/jekyll/jekyll/comments{/number}","issue_comment_url":"https://api.github.com/repos/jekyll/jekyll/issues/comments/{number}","contents_url":"https://api.github.com/repos/jekyll/jekyll/contents/{+path}","compare_url":"https://api.github.com/repos/jekyll/jekyll/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jekyll/jekyll/merges","archive_url":"https://api.github.com/repos/jekyll/jekyll/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jekyll/jekyll/downloads","issues_url":"https://api.github.com/repos/jekyll/jekyll/issues{/number}","pulls_url":"https://api.github.com/repos/jekyll/jekyll/pulls{/number}","milestones_url":"https://api.github.com/repos/jekyll/jekyll/milestones{/number}","notifications_url":"https://api.github.com/repos/jekyll/jekyll/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jekyll/jekyll/labels{/name}","releases_url":"https://api.github.com/repos/jekyll/jekyll/releases{/id}","created_at":"2008-10-20T06:29:03Z","updated_at":"2014-11-11T07:02:31Z","pushed_at":"2014-11-10T20:02:25Z","git_url":"git://github.com/jekyll/jekyll.git","ssh_url":"git@github.com:jekyll/jekyll.git","clone_url":"https://github.com/jekyll/jekyll.git","svn_url":"https://github.com/jekyll/jekyll","homepage":"http://jekyllrb.com","size":92728,"stargazers_count":17276,"watchers_count":17276,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3586,"mirror_url":null,"open_issues_count":126,"forks":3586,"open_issues":126,"watchers":17276,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jekyll/jekyll/pulls/3089"},"html":{"href":"https://github.com/jekyll/jekyll/pull/3089"},"issue":{"href":"https://api.github.com/repos/jekyll/jekyll/issues/3089"},"comments":{"href":"https://api.github.com/repos/jekyll/jekyll/issues/3089/comments"},"review_comments":{"href":"https://api.github.com/repos/jekyll/jekyll/pulls/3089/comments"},"review_comment":{"href":"https://api.github.com/repos/jekyll/jekyll/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/jekyll/jekyll/pulls/3089/commits"},"statuses":{"href":"https://api.github.com/repos/jekyll/jekyll/statuses/bd907c5be68070ad9f4411e4d614a9ed48e46118"}}}}