GitHub PullRequestEvent at 2014-03-20 16:31:35
Repository: geotools
Actor: aaime
Payload: {"action":"opened","number":403,"pull_request":{"url":"https://api.github.com/repos/geotools/geotools/pulls/403","id":13797014,"html_url":"https://github.com/geotools/geotools/pull/403","diff_url":"https://github.com/geotools/geotools/pull/403.diff","patch_url":"https://github.com/geotools/geotools/pull/403.patch","issue_url":"https://api.github.com/repos/geotools/geotools/issues/403","number":403,"state":"open","title":"Encode elements with xs:nil='true' when they are nullable, but minOccurs=1","user":{"login":"aaime","id":325433,"avatar_url":"https://avatars.githubusercontent.com/u/325433?","gravatar_id":"e77a3c0c0da0193cf53884869bd5e9e7","url":"https://api.github.com/users/aaime","html_url":"https://github.com/aaime","followers_url":"https://api.github.com/users/aaime/followers","following_url":"https://api.github.com/users/aaime/following{/other_user}","gists_url":"https://api.github.com/users/aaime/gists{/gist_id}","starred_url":"https://api.github.com/users/aaime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaime/subscriptions","organizations_url":"https://api.github.com/users/aaime/orgs","repos_url":"https://api.github.com/users/aaime/repos","events_url":"https://api.github.com/users/aaime/events{/privacy}","received_events_url":"https://api.github.com/users/aaime/received_events","type":"User","site_admin":false},"body":"This tentative patch tries make sure we encode valid XML for cases in which the schema says a certain element has minOccurs=1, it's nillable, and the attribute in question is null in the data we're encoding.\r\nBasically, we cannot omit the element, but we need to encode an empty one with xs:nil=\"true\" as the attribute.\r\n\r\nOne thing I'm not sure how to handle is adding the http://www.w3.org/2001/XMLSchema namespace if the  caller did not add it, right now it's hard coded, but it's not right, e.g., geoserver code forces the presence of it using the xsi prefix instead, and we end up with two prefix declarations.","created_at":"2014-03-20T16:31:35Z","updated_at":"2014-03-20T16:31:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/geotools/geotools/pulls/403/commits","review_comments_url":"https://api.github.com/repos/geotools/geotools/pulls/403/comments","review_comment_url":"https://api.github.com/repos/geotools/geotools/pulls/comments/{number}","comments_url":"https://api.github.com/repos/geotools/geotools/issues/403/comments","statuses_url":"https://api.github.com/repos/geotools/geotools/statuses/98c8c3e6b748102ac5d4429f9e14a3c3e1cfce49","head":{"label":"aaime:nil-handling","ref":"nil-handling","sha":"98c8c3e6b748102ac5d4429f9e14a3c3e1cfce49","user":{"login":"aaime","id":325433,"avatar_url":"https://avatars.githubusercontent.com/u/325433?","gravatar_id":"e77a3c0c0da0193cf53884869bd5e9e7","url":"https://api.github.com/users/aaime","html_url":"https://github.com/aaime","followers_url":"https://api.github.com/users/aaime/followers","following_url":"https://api.github.com/users/aaime/following{/other_user}","gists_url":"https://api.github.com/users/aaime/gists{/gist_id}","starred_url":"https://api.github.com/users/aaime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaime/subscriptions","organizations_url":"https://api.github.com/users/aaime/orgs","repos_url":"https://api.github.com/users/aaime/repos","events_url":"https://api.github.com/users/aaime/events{/privacy}","received_events_url":"https://api.github.com/users/aaime/received_events","type":"User","site_admin":false},"repo":{"id":4835074,"name":"geotools","full_name":"aaime/geotools","owner":{"login":"aaime","id":325433,"avatar_url":"https://avatars.githubusercontent.com/u/325433?","gravatar_id":"e77a3c0c0da0193cf53884869bd5e9e7","url":"https://api.github.com/users/aaime","html_url":"https://github.com/aaime","followers_url":"https://api.github.com/users/aaime/followers","following_url":"https://api.github.com/users/aaime/following{/other_user}","gists_url":"https://api.github.com/users/aaime/gists{/gist_id}","starred_url":"https://api.github.com/users/aaime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaime/subscriptions","organizations_url":"https://api.github.com/users/aaime/orgs","repos_url":"https://api.github.com/users/aaime/repos","events_url":"https://api.github.com/users/aaime/events{/privacy}","received_events_url":"https://api.github.com/users/aaime/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aaime/geotools","description":"Mirror of central GeoTools svn repository","fork":true,"url":"https://api.github.com/repos/aaime/geotools","forks_url":"https://api.github.com/repos/aaime/geotools/forks","keys_url":"https://api.github.com/repos/aaime/geotools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aaime/geotools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aaime/geotools/teams","hooks_url":"https://api.github.com/repos/aaime/geotools/hooks","issue_events_url":"https://api.github.com/repos/aaime/geotools/issues/events{/number}","events_url":"https://api.github.com/repos/aaime/geotools/events","assignees_url":"https://api.github.com/repos/aaime/geotools/assignees{/user}","branches_url":"https://api.github.com/repos/aaime/geotools/branches{/branch}","tags_url":"https://api.github.com/repos/aaime/geotools/tags","blobs_url":"https://api.github.com/repos/aaime/geotools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aaime/geotools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aaime/geotools/git/refs{/sha}","trees_url":"https://api.github.com/repos/aaime/geotools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aaime/geotools/statuses/{sha}","languages_url":"https://api.github.com/repos/aaime/geotools/languages","stargazers_url":"https://api.github.com/repos/aaime/geotools/stargazers","contributors_url":"https://api.github.com/repos/aaime/geotools/contributors","subscribers_url":"https://api.github.com/repos/aaime/geotools/subscribers","subscription_url":"https://api.github.com/repos/aaime/geotools/subscription","commits_url":"https://api.github.com/repos/aaime/geotools/commits{/sha}","git_commits_url":"https://api.github.com/repos/aaime/geotools/git/commits{/sha}","comments_url":"https://api.github.com/repos/aaime/geotools/comments{/number}","issue_comment_url":"https://api.github.com/repos/aaime/geotools/issues/comments/{number}","contents_url":"https://api.github.com/repos/aaime/geotools/contents/{+path}","compare_url":"https://api.github.com/repos/aaime/geotools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aaime/geotools/merges","archive_url":"https://api.github.com/repos/aaime/geotools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aaime/geotools/downloads","issues_url":"https://api.github.com/repos/aaime/geotools/issues{/number}","pulls_url":"https://api.github.com/repos/aaime/geotools/pulls{/number}","milestones_url":"https://api.github.com/repos/aaime/geotools/milestones{/number}","notifications_url":"https://api.github.com/repos/aaime/geotools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aaime/geotools/labels{/name}","releases_url":"https://api.github.com/repos/aaime/geotools/releases{/id}","created_at":"2012-06-29T17:32:49Z","updated_at":"2014-03-20T16:31:35Z","pushed_at":"2014-03-20T16:28:47Z","git_url":"git://github.com/aaime/geotools.git","ssh_url":"git@github.com:aaime/geotools.git","clone_url":"https://github.com/aaime/geotools.git","svn_url":"https://github.com/aaime/geotools","homepage":"http://geotools.org","size":86505,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master","master_branch":"master"}},"base":{"label":"geotools:master","ref":"master","sha":"296c20afc75ae42df7397da32db30fe2ccb2feb3","user":{"login":"geotools","id":1187031,"avatar_url":"https://avatars.githubusercontent.com/u/1187031?","gravatar_id":"60e3e5cfd789fdcf58caaf6d0cbc0196","url":"https://api.github.com/users/geotools","html_url":"https://github.com/geotools","followers_url":"https://api.github.com/users/geotools/followers","following_url":"https://api.github.com/users/geotools/following{/other_user}","gists_url":"https://api.github.com/users/geotools/gists{/gist_id}","starred_url":"https://api.github.com/users/geotools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geotools/subscriptions","organizations_url":"https://api.github.com/users/geotools/orgs","repos_url":"https://api.github.com/users/geotools/repos","events_url":"https://api.github.com/users/geotools/events{/privacy}","received_events_url":"https://api.github.com/users/geotools/received_events","type":"Organization","site_admin":false},"repo":{"id":2752522,"name":"geotools","full_name":"geotools/geotools","owner":{"login":"geotools","id":1187031,"avatar_url":"https://avatars.githubusercontent.com/u/1187031?","gravatar_id":"60e3e5cfd789fdcf58caaf6d0cbc0196","url":"https://api.github.com/users/geotools","html_url":"https://github.com/geotools","followers_url":"https://api.github.com/users/geotools/followers","following_url":"https://api.github.com/users/geotools/following{/other_user}","gists_url":"https://api.github.com/users/geotools/gists{/gist_id}","starred_url":"https://api.github.com/users/geotools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geotools/subscriptions","organizations_url":"https://api.github.com/users/geotools/orgs","repos_url":"https://api.github.com/users/geotools/repos","events_url":"https://api.github.com/users/geotools/events{/privacy}","received_events_url":"https://api.github.com/users/geotools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/geotools/geotools","description":"Official GeoTools repository","fork":false,"url":"https://api.github.com/repos/geotools/geotools","forks_url":"https://api.github.com/repos/geotools/geotools/forks","keys_url":"https://api.github.com/repos/geotools/geotools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/geotools/geotools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/geotools/geotools/teams","hooks_url":"https://api.github.com/repos/geotools/geotools/hooks","issue_events_url":"https://api.github.com/repos/geotools/geotools/issues/events{/number}","events_url":"https://api.github.com/repos/geotools/geotools/events","assignees_url":"https://api.github.com/repos/geotools/geotools/assignees{/user}","branches_url":"https://api.github.com/repos/geotools/geotools/branches{/branch}","tags_url":"https://api.github.com/repos/geotools/geotools/tags","blobs_url":"https://api.github.com/repos/geotools/geotools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/geotools/geotools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/geotools/geotools/git/refs{/sha}","trees_url":"https://api.github.com/repos/geotools/geotools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/geotools/geotools/statuses/{sha}","languages_url":"https://api.github.com/repos/geotools/geotools/languages","stargazers_url":"https://api.github.com/repos/geotools/geotools/stargazers","contributors_url":"https://api.github.com/repos/geotools/geotools/contributors","subscribers_url":"https://api.github.com/repos/geotools/geotools/subscribers","subscription_url":"https://api.github.com/repos/geotools/geotools/subscription","commits_url":"https://api.github.com/repos/geotools/geotools/commits{/sha}","git_commits_url":"https://api.github.com/repos/geotools/geotools/git/commits{/sha}","comments_url":"https://api.github.com/repos/geotools/geotools/comments{/number}","issue_comment_url":"https://api.github.com/repos/geotools/geotools/issues/comments/{number}","contents_url":"https://api.github.com/repos/geotools/geotools/contents/{+path}","compare_url":"https://api.github.com/repos/geotools/geotools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/geotools/geotools/merges","archive_url":"https://api.github.com/repos/geotools/geotools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/geotools/geotools/downloads","issues_url":"https://api.github.com/repos/geotools/geotools/issues{/number}","pulls_url":"https://api.github.com/repos/geotools/geotools/pulls{/number}","milestones_url":"https://api.github.com/repos/geotools/geotools/milestones{/number}","notifications_url":"https://api.github.com/repos/geotools/geotools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/geotools/geotools/labels{/name}","releases_url":"https://api.github.com/repos/geotools/geotools/releases{/id}","created_at":"2011-11-10T23:22:12Z","updated_at":"2014-03-20T08:09:39Z","pushed_at":"2014-03-20T08:09:39Z","git_url":"git://github.com/geotools/geotools.git","ssh_url":"git@github.com:geotools/geotools.git","clone_url":"https://github.com/geotools/geotools.git","svn_url":"https://github.com/geotools/geotools","homepage":"http://geotools.org","size":160962,"stargazers_count":137,"watchers_count":137,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":173,"mirror_url":null,"open_issues_count":5,"forks":173,"open_issues":5,"watchers":137,"default_branch":"master","master_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/geotools/geotools/pulls/403"},"html":{"href":"https://github.com/geotools/geotools/pull/403"},"issue":{"href":"https://api.github.com/repos/geotools/geotools/issues/403"},"comments":{"href":"https://api.github.com/repos/geotools/geotools/issues/403/comments"},"review_comments":{"href":"https://api.github.com/repos/geotools/geotools/pulls/403/comments"},"review_comment":{"href":"https://api.github.com/repos/geotools/geotools/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/geotools/geotools/pulls/403/commits"},"statuses":{"href":"https://api.github.com/repos/geotools/geotools/statuses/98c8c3e6b748102ac5d4429f9e14a3c3e1cfce49"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":85,"deletions":29,"changed_files":7}}