GitHub PullRequestReviewCommentEvent at 2014-07-30 15:10:01
Repository: crits_services
Actor: TheDr1ver
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/MITRECND/crits_services/pulls/comments/15589553","id":15589553,"diff_hunk":"@@ -233,6 +274,67 @@ def _scan(self, context):\n \n         self._error(\"Cuckoo did not complete before timeout\")\n \n+    def _scan(self, context):\n+        task_id = self.config.get('existing task id')\n+        if task_id:\n+            self._info(\"Reusing existing task with ID: %s\" % task_id)\n+            multi_task = 0\n+        else:\n+            task_id = self.submit_task(context)\n+            if not task_id:","path":"cuckoo_service/__init__.py","position":160,"original_position":160,"commit_id":"12c668a325d89014df15dc6a363db46a08499e74","original_commit_id":"12c668a325d89014df15dc6a363db46a08499e74","user":{"login":"TheDr1ver","id":6147794,"avatar_url":"https://avatars.githubusercontent.com/u/6147794?v=1","gravatar_id":"e212ce7df3a1e7052392870fefb303e6","url":"https://api.github.com/users/TheDr1ver","html_url":"https://github.com/TheDr1ver","followers_url":"https://api.github.com/users/TheDr1ver/followers","following_url":"https://api.github.com/users/TheDr1ver/following{/other_user}","gists_url":"https://api.github.com/users/TheDr1ver/gists{/gist_id}","starred_url":"https://api.github.com/users/TheDr1ver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheDr1ver/subscriptions","organizations_url":"https://api.github.com/users/TheDr1ver/orgs","repos_url":"https://api.github.com/users/TheDr1ver/repos","events_url":"https://api.github.com/users/TheDr1ver/events{/privacy}","received_events_url":"https://api.github.com/users/TheDr1ver/received_events","type":"User","site_admin":false},"body":"This was in the original code (line 179) - I'm assuming it means that submit_task() didn't work with the current context. submit_task() only returns 'None' if it cannot submit the file, and in that case submit_task() takes care of the error logging (line 125 of the original code - 170 of the updated code).","created_at":"2014-07-30T15:10:01Z","updated_at":"2014-07-30T15:10:01Z","html_url":"https://github.com/MITRECND/crits_services/pull/3#discussion_r15589553","pull_request_url":"https://api.github.com/repos/MITRECND/crits_services/pulls/3","_links":{"self":{"href":"https://api.github.com/repos/MITRECND/crits_services/pulls/comments/15589553"},"html":{"href":"https://github.com/MITRECND/crits_services/pull/3#discussion_r15589553"},"pull_request":{"href":"https://api.github.com/repos/MITRECND/crits_services/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/MITRECND/crits_services/pulls/3","id":19037417,"html_url":"https://github.com/MITRECND/crits_services/pull/3","diff_url":"https://github.com/MITRECND/crits_services/pull/3.diff","patch_url":"https://github.com/MITRECND/crits_services/pull/3.patch","issue_url":"https://api.github.com/repos/MITRECND/crits_services/issues/3","number":3,"state":"open","title":"Add results/indexing to cuckoo service","user":{"login":"TheDr1ver","id":6147794,"avatar_url":"https://avatars.githubusercontent.com/u/6147794?v=1","gravatar_id":"e212ce7df3a1e7052392870fefb303e6","url":"https://api.github.com/users/TheDr1ver","html_url":"https://github.com/TheDr1ver","followers_url":"https://api.github.com/users/TheDr1ver/followers","following_url":"https://api.github.com/users/TheDr1ver/following{/other_user}","gists_url":"https://api.github.com/users/TheDr1ver/gists{/gist_id}","starred_url":"https://api.github.com/users/TheDr1ver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheDr1ver/subscriptions","organizations_url":"https://api.github.com/users/TheDr1ver/orgs","repos_url":"https://api.github.com/users/TheDr1ver/repos","events_url":"https://api.github.com/users/TheDr1ver/events{/privacy}","received_events_url":"https://api.github.com/users/TheDr1ver/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-07-29T16:19:48Z","updated_at":"2014-07-30T15:10:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"daf200a0f052b6a69225906ebd5bb2db3a067f57","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/MITRECND/crits_services/pulls/3/commits","review_comments_url":"https://api.github.com/repos/MITRECND/crits_services/pulls/3/comments","review_comment_url":"https://api.github.com/repos/MITRECND/crits_services/pulls/comments/{number}","comments_url":"https://api.github.com/repos/MITRECND/crits_services/issues/3/comments","statuses_url":"https://api.github.com/repos/MITRECND/crits_services/statuses/12c668a325d89014df15dc6a363db46a08499e74","head":{"label":"TheDr1ver:patch-1","ref":"patch-1","sha":"12c668a325d89014df15dc6a363db46a08499e74","user":{"login":"TheDr1ver","id":6147794,"avatar_url":"https://avatars.githubusercontent.com/u/6147794?v=1","gravatar_id":"e212ce7df3a1e7052392870fefb303e6","url":"https://api.github.com/users/TheDr1ver","html_url":"https://github.com/TheDr1ver","followers_url":"https://api.github.com/users/TheDr1ver/followers","following_url":"https://api.github.com/users/TheDr1ver/following{/other_user}","gists_url":"https://api.github.com/users/TheDr1ver/gists{/gist_id}","starred_url":"https://api.github.com/users/TheDr1ver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheDr1ver/subscriptions","organizations_url":"https://api.github.com/users/TheDr1ver/orgs","repos_url":"https://api.github.com/users/TheDr1ver/repos","events_url":"https://api.github.com/users/TheDr1ver/events{/privacy}","received_events_url":"https://api.github.com/users/TheDr1ver/received_events","type":"User","site_admin":false},"repo":{"id":22270548,"name":"crits_services","full_name":"TheDr1ver/crits_services","owner":{"login":"TheDr1ver","id":6147794,"avatar_url":"https://avatars.githubusercontent.com/u/6147794?v=1","gravatar_id":"e212ce7df3a1e7052392870fefb303e6","url":"https://api.github.com/users/TheDr1ver","html_url":"https://github.com/TheDr1ver","followers_url":"https://api.github.com/users/TheDr1ver/followers","following_url":"https://api.github.com/users/TheDr1ver/following{/other_user}","gists_url":"https://api.github.com/users/TheDr1ver/gists{/gist_id}","starred_url":"https://api.github.com/users/TheDr1ver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheDr1ver/subscriptions","organizations_url":"https://api.github.com/users/TheDr1ver/orgs","repos_url":"https://api.github.com/users/TheDr1ver/repos","events_url":"https://api.github.com/users/TheDr1ver/events{/privacy}","received_events_url":"https://api.github.com/users/TheDr1ver/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TheDr1ver/crits_services","description":"CRITs Services Collection","fork":true,"url":"https://api.github.com/repos/TheDr1ver/crits_services","forks_url":"https://api.github.com/repos/TheDr1ver/crits_services/forks","keys_url":"https://api.github.com/repos/TheDr1ver/crits_services/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TheDr1ver/crits_services/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TheDr1ver/crits_services/teams","hooks_url":"https://api.github.com/repos/TheDr1ver/crits_services/hooks","issue_events_url":"https://api.github.com/repos/TheDr1ver/crits_services/issues/events{/number}","events_url":"https://api.github.com/repos/TheDr1ver/crits_services/events","assignees_url":"https://api.github.com/repos/TheDr1ver/crits_services/assignees{/user}","branches_url":"https://api.github.com/repos/TheDr1ver/crits_services/branches{/branch}","tags_url":"https://api.github.com/repos/TheDr1ver/crits_services/tags","blobs_url":"https://api.github.com/repos/TheDr1ver/crits_services/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TheDr1ver/crits_services/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TheDr1ver/crits_services/git/refs{/sha}","trees_url":"https://api.github.com/repos/TheDr1ver/crits_services/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TheDr1ver/crits_services/statuses/{sha}","languages_url":"https://api.github.com/repos/TheDr1ver/crits_services/languages","stargazers_url":"https://api.github.com/repos/TheDr1ver/crits_services/stargazers","contributors_url":"https://api.github.com/repos/TheDr1ver/crits_services/contributors","subscribers_url":"https://api.github.com/repos/TheDr1ver/crits_services/subscribers","subscription_url":"https://api.github.com/repos/TheDr1ver/crits_services/subscription","commits_url":"https://api.github.com/repos/TheDr1ver/crits_services/commits{/sha}","git_commits_url":"https://api.github.com/repos/TheDr1ver/crits_services/git/commits{/sha}","comments_url":"https://api.github.com/repos/TheDr1ver/crits_services/comments{/number}","issue_comment_url":"https://api.github.com/repos/TheDr1ver/crits_services/issues/comments/{number}","contents_url":"https://api.github.com/repos/TheDr1ver/crits_services/contents/{+path}","compare_url":"https://api.github.com/repos/TheDr1ver/crits_services/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TheDr1ver/crits_services/merges","archive_url":"https://api.github.com/repos/TheDr1ver/crits_services/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TheDr1ver/crits_services/downloads","issues_url":"https://api.github.com/repos/TheDr1ver/crits_services/issues{/number}","pulls_url":"https://api.github.com/repos/TheDr1ver/crits_services/pulls{/number}","milestones_url":"https://api.github.com/repos/TheDr1ver/crits_services/milestones{/number}","notifications_url":"https://api.github.com/repos/TheDr1ver/crits_services/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TheDr1ver/crits_services/labels{/name}","releases_url":"https://api.github.com/repos/TheDr1ver/crits_services/releases{/id}","created_at":"2014-07-25T20:54:36Z","updated_at":"2014-07-28T17:13:34Z","pushed_at":"2014-07-29T18:41:45Z","git_url":"git://github.com/TheDr1ver/crits_services.git","ssh_url":"git@github.com:TheDr1ver/crits_services.git","clone_url":"https://github.com/TheDr1ver/crits_services.git","svn_url":"https://github.com/TheDr1ver/crits_services","homepage":null,"size":471,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"MITRECND:cuckoo","ref":"cuckoo","sha":"e6d48e189f93221a686b49fdd92407f62c9a5819","user":{"login":"MITRECND","id":2372505,"avatar_url":"https://avatars.githubusercontent.com/u/2372505?v=1","gravatar_id":"3cdebb5d77368e2caa001581c59ad649","url":"https://api.github.com/users/MITRECND","html_url":"https://github.com/MITRECND","followers_url":"https://api.github.com/users/MITRECND/followers","following_url":"https://api.github.com/users/MITRECND/following{/other_user}","gists_url":"https://api.github.com/users/MITRECND/gists{/gist_id}","starred_url":"https://api.github.com/users/MITRECND/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MITRECND/subscriptions","organizations_url":"https://api.github.com/users/MITRECND/orgs","repos_url":"https://api.github.com/users/MITRECND/repos","events_url":"https://api.github.com/users/MITRECND/events{/privacy}","received_events_url":"https://api.github.com/users/MITRECND/received_events","type":"Organization","site_admin":false},"repo":{"id":20405981,"name":"crits_services","full_name":"MITRECND/crits_services","owner":{"login":"MITRECND","id":2372505,"avatar_url":"https://avatars.githubusercontent.com/u/2372505?v=1","gravatar_id":"3cdebb5d77368e2caa001581c59ad649","url":"https://api.github.com/users/MITRECND","html_url":"https://github.com/MITRECND","followers_url":"https://api.github.com/users/MITRECND/followers","following_url":"https://api.github.com/users/MITRECND/following{/other_user}","gists_url":"https://api.github.com/users/MITRECND/gists{/gist_id}","starred_url":"https://api.github.com/users/MITRECND/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MITRECND/subscriptions","organizations_url":"https://api.github.com/users/MITRECND/orgs","repos_url":"https://api.github.com/users/MITRECND/repos","events_url":"https://api.github.com/users/MITRECND/events{/privacy}","received_events_url":"https://api.github.com/users/MITRECND/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MITRECND/crits_services","description":"CRITs Services Collection","fork":true,"url":"https://api.github.com/repos/MITRECND/crits_services","forks_url":"https://api.github.com/repos/MITRECND/crits_services/forks","keys_url":"https://api.github.com/repos/MITRECND/crits_services/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MITRECND/crits_services/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MITRECND/crits_services/teams","hooks_url":"https://api.github.com/repos/MITRECND/crits_services/hooks","issue_events_url":"https://api.github.com/repos/MITRECND/crits_services/issues/events{/number}","events_url":"https://api.github.com/repos/MITRECND/crits_services/events","assignees_url":"https://api.github.com/repos/MITRECND/crits_services/assignees{/user}","branches_url":"https://api.github.com/repos/MITRECND/crits_services/branches{/branch}","tags_url":"https://api.github.com/repos/MITRECND/crits_services/tags","blobs_url":"https://api.github.com/repos/MITRECND/crits_services/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MITRECND/crits_services/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MITRECND/crits_services/git/refs{/sha}","trees_url":"https://api.github.com/repos/MITRECND/crits_services/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MITRECND/crits_services/statuses/{sha}","languages_url":"https://api.github.com/repos/MITRECND/crits_services/languages","stargazers_url":"https://api.github.com/repos/MITRECND/crits_services/stargazers","contributors_url":"https://api.github.com/repos/MITRECND/crits_services/contributors","subscribers_url":"https://api.github.com/repos/MITRECND/crits_services/subscribers","subscription_url":"https://api.github.com/repos/MITRECND/crits_services/subscription","commits_url":"https://api.github.com/repos/MITRECND/crits_services/commits{/sha}","git_commits_url":"https://api.github.com/repos/MITRECND/crits_services/git/commits{/sha}","comments_url":"https://api.github.com/repos/MITRECND/crits_services/comments{/number}","issue_comment_url":"https://api.github.com/repos/MITRECND/crits_services/issues/comments/{number}","contents_url":"https://api.github.com/repos/MITRECND/crits_services/contents/{+path}","compare_url":"https://api.github.com/repos/MITRECND/crits_services/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MITRECND/crits_services/merges","archive_url":"https://api.github.com/repos/MITRECND/crits_services/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MITRECND/crits_services/downloads","issues_url":"https://api.github.com/repos/MITRECND/crits_services/issues{/number}","pulls_url":"https://api.github.com/repos/MITRECND/crits_services/pulls{/number}","milestones_url":"https://api.github.com/repos/MITRECND/crits_services/milestones{/number}","notifications_url":"https://api.github.com/repos/MITRECND/crits_services/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MITRECND/crits_services/labels{/name}","releases_url":"https://api.github.com/repos/MITRECND/crits_services/releases{/id}","created_at":"2014-06-02T14:03:52Z","updated_at":"2014-07-25T20:55:50Z","pushed_at":"2014-07-22T16:08:49Z","git_url":"git://github.com/MITRECND/crits_services.git","ssh_url":"git@github.com:MITRECND/crits_services.git","clone_url":"https://github.com/MITRECND/crits_services.git","svn_url":"https://github.com/MITRECND/crits_services","homepage":null,"size":454,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MITRECND/crits_services/pulls/3"},"html":{"href":"https://github.com/MITRECND/crits_services/pull/3"},"issue":{"href":"https://api.github.com/repos/MITRECND/crits_services/issues/3"},"comments":{"href":"https://api.github.com/repos/MITRECND/crits_services/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/MITRECND/crits_services/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/MITRECND/crits_services/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/MITRECND/crits_services/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/MITRECND/crits_services/statuses/12c668a325d89014df15dc6a363db46a08499e74"}}}}