GitHub PullRequestReviewCommentEvent at 2014-10-08 09:37:33
Repository: guard-rspec
Actor: houndci
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/guard/guard-rspec/pulls/comments/18572031","id":18572031,"diff_hunk":"@@ -6,15 +6,25 @@\n   let(:inspector) { klass.new(options) }\n \n   # Use real paths because BaseInspector#_clean will be used to clean them\n-  let(:paths) { [\n-    'spec/lib/guard/rspec/inspectors/base_inspector_spec.rb',\n-    'spec/lib/guard/rspec/runner_spec.rb',\n-    'spec/lib/guard/rspec/deprecator_spec.rb'\n-  ] }\n-  let(:failed_locations) { [\n-    './spec/lib/guard/rspec/runner_spec.rb:12',\n-    './spec/lib/guard/rspec/deprecator_spec.rb:55'\n-  ] }\n+  let(:paths) do\n+    ['spec/lib/guard/rspec/inspectors/base_inspector_spec.rb',\n+     'spec/lib/guard/rspec/runner_spec.rb',\n+     'spec/lib/guard/rspec/deprecator_spec.rb']\n+  end\n+\n+  let(:expected_paths) { with_current_dir(paths) }\n+\n+  let(:other_paths) do\n+    ['spec/lib/guard/rspec/inspectors/simple_inspector_spec.rb',\n+     'spec/lib/guard/rspec/runner_spec.rb']\n+  end\n+\n+  let(:other_expected_paths) { with_current_dir(other_paths) }\n+\n+  let(:failed_locations) do\n+    ['./spec/lib/guard/rspec/runner_spec.rb:12',","path":"spec/lib/guard/rspec/inspectors/shared_examples.rb","position":29,"original_position":29,"commit_id":"aeebae3de3af93261b8e3b8207bf3f0de2f31e43","original_commit_id":"aeebae3de3af93261b8e3b8207bf3f0de2f31e43","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=2","gravatar_id":"","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.","created_at":"2014-10-08T09:37:33Z","updated_at":"2014-10-08T09:37:33Z","html_url":"https://github.com/guard/guard-rspec/pull/287#discussion_r18572031","pull_request_url":"https://api.github.com/repos/guard/guard-rspec/pulls/287","_links":{"self":{"href":"https://api.github.com/repos/guard/guard-rspec/pulls/comments/18572031"},"html":{"href":"https://github.com/guard/guard-rspec/pull/287#discussion_r18572031"},"pull_request":{"href":"https://api.github.com/repos/guard/guard-rspec/pulls/287"}}},"pull_request":{"url":"https://api.github.com/repos/guard/guard-rspec/pulls/287","id":22410799,"html_url":"https://github.com/guard/guard-rspec/pull/287","diff_url":"https://github.com/guard/guard-rspec/pull/287.diff","patch_url":"https://github.com/guard/guard-rspec/pull/287.patch","issue_url":"https://api.github.com/repos/guard/guard-rspec/issues/287","number":287,"state":"open","locked":false,"title":"Fixed watchdir option","user":{"login":"lesniakania","id":193863,"avatar_url":"https://avatars.githubusercontent.com/u/193863?v=2","gravatar_id":"","url":"https://api.github.com/users/lesniakania","html_url":"https://github.com/lesniakania","followers_url":"https://api.github.com/users/lesniakania/followers","following_url":"https://api.github.com/users/lesniakania/following{/other_user}","gists_url":"https://api.github.com/users/lesniakania/gists{/gist_id}","starred_url":"https://api.github.com/users/lesniakania/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lesniakania/subscriptions","organizations_url":"https://api.github.com/users/lesniakania/orgs","repos_url":"https://api.github.com/users/lesniakania/repos","events_url":"https://api.github.com/users/lesniakania/events{/privacy}","received_events_url":"https://api.github.com/users/lesniakania/received_events","type":"User","site_admin":false},"body":"I think current watchdir option doesn't work as it should (please correct me if I'm missing something).\r\n\r\nMy recent project was consisted of many different modules each of them having it's own tests suite.\r\nI've tried to use watchdir option but it didn't work as I expected.\r\n\r\nI've created sample project and described steps to reproduce the issue and fix for the issue with my forks (https://github.com/lesniakania/guard and https://github.com/lesniakania/guard-rspec):\r\n\r\nhttps://github.com/lesniakania/multiple-modules-with-guard\r\n\r\nThese changes depends on changes I've made in guard repo.","created_at":"2014-10-08T09:37:21Z","updated_at":"2014-10-08T09:37:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"19dbaeb3d4bb2f8ddd79ed873649ba6e511fe5a6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/guard/guard-rspec/pulls/287/commits","review_comments_url":"https://api.github.com/repos/guard/guard-rspec/pulls/287/comments","review_comment_url":"https://api.github.com/repos/guard/guard-rspec/pulls/comments/{number}","comments_url":"https://api.github.com/repos/guard/guard-rspec/issues/287/comments","statuses_url":"https://api.github.com/repos/guard/guard-rspec/statuses/aeebae3de3af93261b8e3b8207bf3f0de2f31e43","head":{"label":"lesniakania:master","ref":"master","sha":"aeebae3de3af93261b8e3b8207bf3f0de2f31e43","user":{"login":"lesniakania","id":193863,"avatar_url":"https://avatars.githubusercontent.com/u/193863?v=2","gravatar_id":"","url":"https://api.github.com/users/lesniakania","html_url":"https://github.com/lesniakania","followers_url":"https://api.github.com/users/lesniakania/followers","following_url":"https://api.github.com/users/lesniakania/following{/other_user}","gists_url":"https://api.github.com/users/lesniakania/gists{/gist_id}","starred_url":"https://api.github.com/users/lesniakania/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lesniakania/subscriptions","organizations_url":"https://api.github.com/users/lesniakania/orgs","repos_url":"https://api.github.com/users/lesniakania/repos","events_url":"https://api.github.com/users/lesniakania/events{/privacy}","received_events_url":"https://api.github.com/users/lesniakania/received_events","type":"User","site_admin":false},"repo":{"id":24838334,"name":"guard-rspec","full_name":"lesniakania/guard-rspec","owner":{"login":"lesniakania","id":193863,"avatar_url":"https://avatars.githubusercontent.com/u/193863?v=2","gravatar_id":"","url":"https://api.github.com/users/lesniakania","html_url":"https://github.com/lesniakania","followers_url":"https://api.github.com/users/lesniakania/followers","following_url":"https://api.github.com/users/lesniakania/following{/other_user}","gists_url":"https://api.github.com/users/lesniakania/gists{/gist_id}","starred_url":"https://api.github.com/users/lesniakania/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lesniakania/subscriptions","organizations_url":"https://api.github.com/users/lesniakania/orgs","repos_url":"https://api.github.com/users/lesniakania/repos","events_url":"https://api.github.com/users/lesniakania/events{/privacy}","received_events_url":"https://api.github.com/users/lesniakania/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lesniakania/guard-rspec","description":"Guard::RSpec automatically run your specs (much like autotest)","fork":true,"url":"https://api.github.com/repos/lesniakania/guard-rspec","forks_url":"https://api.github.com/repos/lesniakania/guard-rspec/forks","keys_url":"https://api.github.com/repos/lesniakania/guard-rspec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lesniakania/guard-rspec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lesniakania/guard-rspec/teams","hooks_url":"https://api.github.com/repos/lesniakania/guard-rspec/hooks","issue_events_url":"https://api.github.com/repos/lesniakania/guard-rspec/issues/events{/number}","events_url":"https://api.github.com/repos/lesniakania/guard-rspec/events","assignees_url":"https://api.github.com/repos/lesniakania/guard-rspec/assignees{/user}","branches_url":"https://api.github.com/repos/lesniakania/guard-rspec/branches{/branch}","tags_url":"https://api.github.com/repos/lesniakania/guard-rspec/tags","blobs_url":"https://api.github.com/repos/lesniakania/guard-rspec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lesniakania/guard-rspec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lesniakania/guard-rspec/git/refs{/sha}","trees_url":"https://api.github.com/repos/lesniakania/guard-rspec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lesniakania/guard-rspec/statuses/{sha}","languages_url":"https://api.github.com/repos/lesniakania/guard-rspec/languages","stargazers_url":"https://api.github.com/repos/lesniakania/guard-rspec/stargazers","contributors_url":"https://api.github.com/repos/lesniakania/guard-rspec/contributors","subscribers_url":"https://api.github.com/repos/lesniakania/guard-rspec/subscribers","subscription_url":"https://api.github.com/repos/lesniakania/guard-rspec/subscription","commits_url":"https://api.github.com/repos/lesniakania/guard-rspec/commits{/sha}","git_commits_url":"https://api.github.com/repos/lesniakania/guard-rspec/git/commits{/sha}","comments_url":"https://api.github.com/repos/lesniakania/guard-rspec/comments{/number}","issue_comment_url":"https://api.github.com/repos/lesniakania/guard-rspec/issues/comments/{number}","contents_url":"https://api.github.com/repos/lesniakania/guard-rspec/contents/{+path}","compare_url":"https://api.github.com/repos/lesniakania/guard-rspec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lesniakania/guard-rspec/merges","archive_url":"https://api.github.com/repos/lesniakania/guard-rspec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lesniakania/guard-rspec/downloads","issues_url":"https://api.github.com/repos/lesniakania/guard-rspec/issues{/number}","pulls_url":"https://api.github.com/repos/lesniakania/guard-rspec/pulls{/number}","milestones_url":"https://api.github.com/repos/lesniakania/guard-rspec/milestones{/number}","notifications_url":"https://api.github.com/repos/lesniakania/guard-rspec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lesniakania/guard-rspec/labels{/name}","releases_url":"https://api.github.com/repos/lesniakania/guard-rspec/releases{/id}","created_at":"2014-10-06T08:15:11Z","updated_at":"2014-10-06T08:16:18Z","pushed_at":"2014-10-08T09:25:07Z","git_url":"git://github.com/lesniakania/guard-rspec.git","ssh_url":"git@github.com:lesniakania/guard-rspec.git","clone_url":"https://github.com/lesniakania/guard-rspec.git","svn_url":"https://github.com/lesniakania/guard-rspec","homepage":"https://rubygems.org/gems/guard-rspec","size":585,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"guard:master","ref":"master","sha":"2bdd89ee0c42c1574738b8405d97be32ebd93224","user":{"login":"guard","id":351846,"avatar_url":"https://avatars.githubusercontent.com/u/351846?v=2","gravatar_id":"","url":"https://api.github.com/users/guard","html_url":"https://github.com/guard","followers_url":"https://api.github.com/users/guard/followers","following_url":"https://api.github.com/users/guard/following{/other_user}","gists_url":"https://api.github.com/users/guard/gists{/gist_id}","starred_url":"https://api.github.com/users/guard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guard/subscriptions","organizations_url":"https://api.github.com/users/guard/orgs","repos_url":"https://api.github.com/users/guard/repos","events_url":"https://api.github.com/users/guard/events{/privacy}","received_events_url":"https://api.github.com/users/guard/received_events","type":"Organization","site_admin":false},"repo":{"id":959090,"name":"guard-rspec","full_name":"guard/guard-rspec","owner":{"login":"guard","id":351846,"avatar_url":"https://avatars.githubusercontent.com/u/351846?v=2","gravatar_id":"","url":"https://api.github.com/users/guard","html_url":"https://github.com/guard","followers_url":"https://api.github.com/users/guard/followers","following_url":"https://api.github.com/users/guard/following{/other_user}","gists_url":"https://api.github.com/users/guard/gists{/gist_id}","starred_url":"https://api.github.com/users/guard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guard/subscriptions","organizations_url":"https://api.github.com/users/guard/orgs","repos_url":"https://api.github.com/users/guard/repos","events_url":"https://api.github.com/users/guard/events{/privacy}","received_events_url":"https://api.github.com/users/guard/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guard/guard-rspec","description":"Guard::RSpec automatically run your specs (much like autotest)","fork":false,"url":"https://api.github.com/repos/guard/guard-rspec","forks_url":"https://api.github.com/repos/guard/guard-rspec/forks","keys_url":"https://api.github.com/repos/guard/guard-rspec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guard/guard-rspec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guard/guard-rspec/teams","hooks_url":"https://api.github.com/repos/guard/guard-rspec/hooks","issue_events_url":"https://api.github.com/repos/guard/guard-rspec/issues/events{/number}","events_url":"https://api.github.com/repos/guard/guard-rspec/events","assignees_url":"https://api.github.com/repos/guard/guard-rspec/assignees{/user}","branches_url":"https://api.github.com/repos/guard/guard-rspec/branches{/branch}","tags_url":"https://api.github.com/repos/guard/guard-rspec/tags","blobs_url":"https://api.github.com/repos/guard/guard-rspec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guard/guard-rspec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guard/guard-rspec/git/refs{/sha}","trees_url":"https://api.github.com/repos/guard/guard-rspec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guard/guard-rspec/statuses/{sha}","languages_url":"https://api.github.com/repos/guard/guard-rspec/languages","stargazers_url":"https://api.github.com/repos/guard/guard-rspec/stargazers","contributors_url":"https://api.github.com/repos/guard/guard-rspec/contributors","subscribers_url":"https://api.github.com/repos/guard/guard-rspec/subscribers","subscription_url":"https://api.github.com/repos/guard/guard-rspec/subscription","commits_url":"https://api.github.com/repos/guard/guard-rspec/commits{/sha}","git_commits_url":"https://api.github.com/repos/guard/guard-rspec/git/commits{/sha}","comments_url":"https://api.github.com/repos/guard/guard-rspec/comments{/number}","issue_comment_url":"https://api.github.com/repos/guard/guard-rspec/issues/comments/{number}","contents_url":"https://api.github.com/repos/guard/guard-rspec/contents/{+path}","compare_url":"https://api.github.com/repos/guard/guard-rspec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guard/guard-rspec/merges","archive_url":"https://api.github.com/repos/guard/guard-rspec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guard/guard-rspec/downloads","issues_url":"https://api.github.com/repos/guard/guard-rspec/issues{/number}","pulls_url":"https://api.github.com/repos/guard/guard-rspec/pulls{/number}","milestones_url":"https://api.github.com/repos/guard/guard-rspec/milestones{/number}","notifications_url":"https://api.github.com/repos/guard/guard-rspec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guard/guard-rspec/labels{/name}","releases_url":"https://api.github.com/repos/guard/guard-rspec/releases{/id}","created_at":"2010-10-03T21:10:16Z","updated_at":"2014-10-05T07:39:36Z","pushed_at":"2014-08-29T13:03:55Z","git_url":"git://github.com/guard/guard-rspec.git","ssh_url":"git@github.com:guard/guard-rspec.git","clone_url":"https://github.com/guard/guard-rspec.git","svn_url":"https://github.com/guard/guard-rspec","homepage":"https://rubygems.org/gems/guard-rspec","size":1536,"stargazers_count":718,"watchers_count":718,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":160,"mirror_url":null,"open_issues_count":9,"forks":160,"open_issues":9,"watchers":718,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/guard/guard-rspec/pulls/287"},"html":{"href":"https://github.com/guard/guard-rspec/pull/287"},"issue":{"href":"https://api.github.com/repos/guard/guard-rspec/issues/287"},"comments":{"href":"https://api.github.com/repos/guard/guard-rspec/issues/287/comments"},"review_comments":{"href":"https://api.github.com/repos/guard/guard-rspec/pulls/287/comments"},"review_comment":{"href":"https://api.github.com/repos/guard/guard-rspec/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/guard/guard-rspec/pulls/287/commits"},"statuses":{"href":"https://api.github.com/repos/guard/guard-rspec/statuses/aeebae3de3af93261b8e3b8207bf3f0de2f31e43"}}}}