GitHub PullRequestReviewCommentEvent at 2014-04-24 09:31:37
Repository: fh-js-sdk
Actor: johnfriz
Payload: {"comment":{"url":"https://api.github.com/repos/feedhenry/fh-js-sdk/pulls/comments/11941370","id":11941370,"diff_hunk":"@@ -778,6 +807,14 @@ var self = {\n     });\n   },\n \n+  setHasCustomSync : function(custom_sync){","path":"src/modules/sync-cli.js","position":154,"original_position":154,"commit_id":"19bc61322d9c1629f2587b6bbcaf8f589dff9e87","original_commit_id":"19bc61322d9c1629f2587b6bbcaf8f589dff9e87","user":{"login":"johnfriz","id":235734,"avatar_url":"https://avatars.githubusercontent.com/u/235734?","gravatar_id":"d1a7ca04c3e57d6ee8bad97d18d6693c","url":"https://api.github.com/users/johnfriz","html_url":"https://github.com/johnfriz","followers_url":"https://api.github.com/users/johnfriz/followers","following_url":"https://api.github.com/users/johnfriz/following{/other_user}","gists_url":"https://api.github.com/users/johnfriz/gists{/gist_id}","starred_url":"https://api.github.com/users/johnfriz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnfriz/subscriptions","organizations_url":"https://api.github.com/users/johnfriz/orgs","repos_url":"https://api.github.com/users/johnfriz/repos","events_url":"https://api.github.com/users/johnfriz/events{/privacy}","received_events_url":"https://api.github.com/users/johnfriz/received_events","type":"User","site_admin":false},"body":"OK. I see how the boolean is being used. \r\n\r\nI think this hasCustomSync flag should be per-dataset, rather than globally - remember, checkHasCustomSync() is checking at the dataset level, and so we need to be storing the information at dataset level too.\r\n\r\n$fh.manage() can be called multiple times. Each time it is called, the options passed are merged with the existing ones, not replacing them (i.e. PATCH not PUT on http terms). The query_params and meta_data are PUT.\r\n\r\nYou are right about multiple monitors for multiple init calls - good spot.","created_at":"2014-04-24T09:31:37Z","updated_at":"2014-04-24T09:31:37Z","html_url":"https://github.com/feedhenry/fh-js-sdk/pull/51#discussion_r11941370","pull_request_url":"https://api.github.com/repos/feedhenry/fh-js-sdk/pulls/51","_links":{"self":{"href":"https://api.github.com/repos/feedhenry/fh-js-sdk/pulls/comments/11941370"},"html":{"href":"https://github.com/feedhenry/fh-js-sdk/pull/51#discussion_r11941370"},"pull_request":{"href":"https://api.github.com/repos/feedhenry/fh-js-sdk/pulls/51"}}}}