GitHub PullRequestEvent at 2014-07-15 20:07:59
Repository: capybara
Actor: twalpole
Payload: {"action":"closed","number":1357,"pull_request":{"url":"https://api.github.com/repos/jnicklas/capybara/pulls/1357","id":18113460,"html_url":"https://github.com/jnicklas/capybara/pull/1357","diff_url":"https://github.com/jnicklas/capybara/pull/1357.diff","patch_url":"https://github.com/jnicklas/capybara/pull/1357.patch","issue_url":"https://api.github.com/repos/jnicklas/capybara/issues/1357","number":1357,"state":"closed","title":"Always convert visit's URL to a String before manipulation","user":{"login":"shepmaster","id":174509,"avatar_url":"https://avatars.githubusercontent.com/u/174509?","gravatar_id":"aa7ba9affedd3df1bacafab9cab3b6ce","url":"https://api.github.com/users/shepmaster","html_url":"https://github.com/shepmaster","followers_url":"https://api.github.com/users/shepmaster/followers","following_url":"https://api.github.com/users/shepmaster/following{/other_user}","gists_url":"https://api.github.com/users/shepmaster/gists{/gist_id}","starred_url":"https://api.github.com/users/shepmaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shepmaster/subscriptions","organizations_url":"https://api.github.com/users/shepmaster/orgs","repos_url":"https://api.github.com/users/shepmaster/repos","events_url":"https://api.github.com/users/shepmaster/events{/privacy}","received_events_url":"https://api.github.com/users/shepmaster/received_events","type":"User","site_admin":false},"body":"It is convenient to be able to pass in URI objects to `visit`, but\r\nthese need to be coerced to a string before actual usage. Most of\r\nvisit's code paths would convert the incoming url to a string\r\nas-needed. However, the path used when `always_include_port` is\r\nenabled did not, causing an error where `URI.parse` would try to parse\r\nan existing URI object.\r\n\r\nThis change consolidates the coercion to string at the entrypoint of\r\nthe method.","created_at":"2014-07-08T16:38:04Z","updated_at":"2014-07-15T20:07:59Z","closed_at":"2014-07-15T20:07:59Z","merged_at":"2014-07-15T20:07:59Z","merge_commit_sha":"f9fce1e38a1aa5a1c5a60f0ed76d5b6d2ea1342c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jnicklas/capybara/pulls/1357/commits","review_comments_url":"https://api.github.com/repos/jnicklas/capybara/pulls/1357/comments","review_comment_url":"https://api.github.com/repos/jnicklas/capybara/pulls/comments/{number}","comments_url":"https://api.github.com/repos/jnicklas/capybara/issues/1357/comments","statuses_url":"https://api.github.com/repos/jnicklas/capybara/statuses/ffc31a8eb46185186d55a9244679d8bd58b4ef19","head":{"label":"shepmaster:visit-uri-and-always-include-port","ref":"visit-uri-and-always-include-port","sha":"ffc31a8eb46185186d55a9244679d8bd58b4ef19","user":{"login":"shepmaster","id":174509,"avatar_url":"https://avatars.githubusercontent.com/u/174509?","gravatar_id":"aa7ba9affedd3df1bacafab9cab3b6ce","url":"https://api.github.com/users/shepmaster","html_url":"https://github.com/shepmaster","followers_url":"https://api.github.com/users/shepmaster/followers","following_url":"https://api.github.com/users/shepmaster/following{/other_user}","gists_url":"https://api.github.com/users/shepmaster/gists{/gist_id}","starred_url":"https://api.github.com/users/shepmaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shepmaster/subscriptions","organizations_url":"https://api.github.com/users/shepmaster/orgs","repos_url":"https://api.github.com/users/shepmaster/repos","events_url":"https://api.github.com/users/shepmaster/events{/privacy}","received_events_url":"https://api.github.com/users/shepmaster/received_events","type":"User","site_admin":false},"repo":{"id":6103865,"name":"capybara","full_name":"shepmaster/capybara","owner":{"login":"shepmaster","id":174509,"avatar_url":"https://avatars.githubusercontent.com/u/174509?","gravatar_id":"aa7ba9affedd3df1bacafab9cab3b6ce","url":"https://api.github.com/users/shepmaster","html_url":"https://github.com/shepmaster","followers_url":"https://api.github.com/users/shepmaster/followers","following_url":"https://api.github.com/users/shepmaster/following{/other_user}","gists_url":"https://api.github.com/users/shepmaster/gists{/gist_id}","starred_url":"https://api.github.com/users/shepmaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shepmaster/subscriptions","organizations_url":"https://api.github.com/users/shepmaster/orgs","repos_url":"https://api.github.com/users/shepmaster/repos","events_url":"https://api.github.com/users/shepmaster/events{/privacy}","received_events_url":"https://api.github.com/users/shepmaster/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shepmaster/capybara","description":"Acceptance test framework for web applications","fork":true,"url":"https://api.github.com/repos/shepmaster/capybara","forks_url":"https://api.github.com/repos/shepmaster/capybara/forks","keys_url":"https://api.github.com/repos/shepmaster/capybara/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shepmaster/capybara/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shepmaster/capybara/teams","hooks_url":"https://api.github.com/repos/shepmaster/capybara/hooks","issue_events_url":"https://api.github.com/repos/shepmaster/capybara/issues/events{/number}","events_url":"https://api.github.com/repos/shepmaster/capybara/events","assignees_url":"https://api.github.com/repos/shepmaster/capybara/assignees{/user}","branches_url":"https://api.github.com/repos/shepmaster/capybara/branches{/branch}","tags_url":"https://api.github.com/repos/shepmaster/capybara/tags","blobs_url":"https://api.github.com/repos/shepmaster/capybara/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shepmaster/capybara/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shepmaster/capybara/git/refs{/sha}","trees_url":"https://api.github.com/repos/shepmaster/capybara/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shepmaster/capybara/statuses/{sha}","languages_url":"https://api.github.com/repos/shepmaster/capybara/languages","stargazers_url":"https://api.github.com/repos/shepmaster/capybara/stargazers","contributors_url":"https://api.github.com/repos/shepmaster/capybara/contributors","subscribers_url":"https://api.github.com/repos/shepmaster/capybara/subscribers","subscription_url":"https://api.github.com/repos/shepmaster/capybara/subscription","commits_url":"https://api.github.com/repos/shepmaster/capybara/commits{/sha}","git_commits_url":"https://api.github.com/repos/shepmaster/capybara/git/commits{/sha}","comments_url":"https://api.github.com/repos/shepmaster/capybara/comments{/number}","issue_comment_url":"https://api.github.com/repos/shepmaster/capybara/issues/comments/{number}","contents_url":"https://api.github.com/repos/shepmaster/capybara/contents/{+path}","compare_url":"https://api.github.com/repos/shepmaster/capybara/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shepmaster/capybara/merges","archive_url":"https://api.github.com/repos/shepmaster/capybara/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shepmaster/capybara/downloads","issues_url":"https://api.github.com/repos/shepmaster/capybara/issues{/number}","pulls_url":"https://api.github.com/repos/shepmaster/capybara/pulls{/number}","milestones_url":"https://api.github.com/repos/shepmaster/capybara/milestones{/number}","notifications_url":"https://api.github.com/repos/shepmaster/capybara/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shepmaster/capybara/labels{/name}","releases_url":"https://api.github.com/repos/shepmaster/capybara/releases{/id}","created_at":"2012-10-06T15:19:01Z","updated_at":"2014-07-08T16:36:13Z","pushed_at":"2014-07-08T20:49:33Z","git_url":"git://github.com/shepmaster/capybara.git","ssh_url":"git@github.com:shepmaster/capybara.git","clone_url":"https://github.com/shepmaster/capybara.git","svn_url":"https://github.com/shepmaster/capybara","homepage":"http://jnicklas.github.com/capybara/","size":8890,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":false,"has_wiki":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jnicklas:master","ref":"master","sha":"10e8450429672e4eccdaa08636fb7b967dcc5dce","user":{"login":"jnicklas","id":134,"avatar_url":"https://avatars.githubusercontent.com/u/134?","gravatar_id":"6c469749d725177dd2837d806c769cd4","url":"https://api.github.com/users/jnicklas","html_url":"https://github.com/jnicklas","followers_url":"https://api.github.com/users/jnicklas/followers","following_url":"https://api.github.com/users/jnicklas/following{/other_user}","gists_url":"https://api.github.com/users/jnicklas/gists{/gist_id}","starred_url":"https://api.github.com/users/jnicklas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnicklas/subscriptions","organizations_url":"https://api.github.com/users/jnicklas/orgs","repos_url":"https://api.github.com/users/jnicklas/repos","events_url":"https://api.github.com/users/jnicklas/events{/privacy}","received_events_url":"https://api.github.com/users/jnicklas/received_events","type":"User","site_admin":false},"repo":{"id":361310,"name":"capybara","full_name":"jnicklas/capybara","owner":{"login":"jnicklas","id":134,"avatar_url":"https://avatars.githubusercontent.com/u/134?","gravatar_id":"6c469749d725177dd2837d806c769cd4","url":"https://api.github.com/users/jnicklas","html_url":"https://github.com/jnicklas","followers_url":"https://api.github.com/users/jnicklas/followers","following_url":"https://api.github.com/users/jnicklas/following{/other_user}","gists_url":"https://api.github.com/users/jnicklas/gists{/gist_id}","starred_url":"https://api.github.com/users/jnicklas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnicklas/subscriptions","organizations_url":"https://api.github.com/users/jnicklas/orgs","repos_url":"https://api.github.com/users/jnicklas/repos","events_url":"https://api.github.com/users/jnicklas/events{/privacy}","received_events_url":"https://api.github.com/users/jnicklas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jnicklas/capybara","description":"Acceptance test framework for web applications","fork":false,"url":"https://api.github.com/repos/jnicklas/capybara","forks_url":"https://api.github.com/repos/jnicklas/capybara/forks","keys_url":"https://api.github.com/repos/jnicklas/capybara/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jnicklas/capybara/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jnicklas/capybara/teams","hooks_url":"https://api.github.com/repos/jnicklas/capybara/hooks","issue_events_url":"https://api.github.com/repos/jnicklas/capybara/issues/events{/number}","events_url":"https://api.github.com/repos/jnicklas/capybara/events","assignees_url":"https://api.github.com/repos/jnicklas/capybara/assignees{/user}","branches_url":"https://api.github.com/repos/jnicklas/capybara/branches{/branch}","tags_url":"https://api.github.com/repos/jnicklas/capybara/tags","blobs_url":"https://api.github.com/repos/jnicklas/capybara/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jnicklas/capybara/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jnicklas/capybara/git/refs{/sha}","trees_url":"https://api.github.com/repos/jnicklas/capybara/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jnicklas/capybara/statuses/{sha}","languages_url":"https://api.github.com/repos/jnicklas/capybara/languages","stargazers_url":"https://api.github.com/repos/jnicklas/capybara/stargazers","contributors_url":"https://api.github.com/repos/jnicklas/capybara/contributors","subscribers_url":"https://api.github.com/repos/jnicklas/capybara/subscribers","subscription_url":"https://api.github.com/repos/jnicklas/capybara/subscription","commits_url":"https://api.github.com/repos/jnicklas/capybara/commits{/sha}","git_commits_url":"https://api.github.com/repos/jnicklas/capybara/git/commits{/sha}","comments_url":"https://api.github.com/repos/jnicklas/capybara/comments{/number}","issue_comment_url":"https://api.github.com/repos/jnicklas/capybara/issues/comments/{number}","contents_url":"https://api.github.com/repos/jnicklas/capybara/contents/{+path}","compare_url":"https://api.github.com/repos/jnicklas/capybara/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jnicklas/capybara/merges","archive_url":"https://api.github.com/repos/jnicklas/capybara/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jnicklas/capybara/downloads","issues_url":"https://api.github.com/repos/jnicklas/capybara/issues{/number}","pulls_url":"https://api.github.com/repos/jnicklas/capybara/pulls{/number}","milestones_url":"https://api.github.com/repos/jnicklas/capybara/milestones{/number}","notifications_url":"https://api.github.com/repos/jnicklas/capybara/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jnicklas/capybara/labels{/name}","releases_url":"https://api.github.com/repos/jnicklas/capybara/releases{/id}","created_at":"2009-11-04T22:19:17Z","updated_at":"2014-07-15T14:47:27Z","pushed_at":"2014-07-15T20:07:59Z","git_url":"git://github.com/jnicklas/capybara.git","ssh_url":"git@github.com:jnicklas/capybara.git","clone_url":"https://github.com/jnicklas/capybara.git","svn_url":"https://github.com/jnicklas/capybara","homepage":"http://jnicklas.github.com/capybara/","size":13371,"stargazers_count":5162,"watchers_count":5162,"language":"Ruby","has_issues":true,"has_downloads":false,"has_wiki":false,"forks_count":814,"mirror_url":null,"open_issues_count":27,"forks":814,"open_issues":27,"watchers":5162,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jnicklas/capybara/pulls/1357"},"html":{"href":"https://github.com/jnicklas/capybara/pull/1357"},"issue":{"href":"https://api.github.com/repos/jnicklas/capybara/issues/1357"},"comments":{"href":"https://api.github.com/repos/jnicklas/capybara/issues/1357/comments"},"review_comments":{"href":"https://api.github.com/repos/jnicklas/capybara/pulls/1357/comments"},"review_comment":{"href":"https://api.github.com/repos/jnicklas/capybara/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/jnicklas/capybara/pulls/1357/commits"},"statuses":{"href":"https://api.github.com/repos/jnicklas/capybara/statuses/ffc31a8eb46185186d55a9244679d8bd58b4ef19"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"twalpole","id":16556,"avatar_url":"https://avatars.githubusercontent.com/u/16556?","gravatar_id":"4c86fb78337803faec5cbf0a32431804","url":"https://api.github.com/users/twalpole","html_url":"https://github.com/twalpole","followers_url":"https://api.github.com/users/twalpole/followers","following_url":"https://api.github.com/users/twalpole/following{/other_user}","gists_url":"https://api.github.com/users/twalpole/gists{/gist_id}","starred_url":"https://api.github.com/users/twalpole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twalpole/subscriptions","organizations_url":"https://api.github.com/users/twalpole/orgs","repos_url":"https://api.github.com/users/twalpole/repos","events_url":"https://api.github.com/users/twalpole/events{/privacy}","received_events_url":"https://api.github.com/users/twalpole/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"commits":2,"additions":5,"deletions":4,"changed_files":1}}