GitHub PullRequestReviewCommentEvent at 2014-08-14 03:12:22
Repository: symfony
Actor: stof
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/symfony/symfony/pulls/comments/16219531","id":16219531,"diff_hunk":"@@ -88,6 +88,60 @@ protected function normalizeToken($token)\n     }\n \n     /**\n+     * Seeks to a non-whitespace token\n+     *\n+     * @param \\ArrayIterator $tokenIterator\n+     */\n+    protected function seekToNextRelaventToken($tokenIterator)","path":"src/Symfony/Bundle/FrameworkBundle/Translation/PhpExtractor.php","position":47,"original_position":47,"commit_id":"4934c032f9ac170243185eb9c7ea1d5f2605bb61","original_commit_id":"4934c032f9ac170243185eb9c7ea1d5f2605bb61","user":{"login":"stof","id":439401,"avatar_url":"https://avatars.githubusercontent.com/u/439401?v=2","gravatar_id":"7894bbdf1c05b18a1444ad8c76c9d583","url":"https://api.github.com/users/stof","html_url":"https://github.com/stof","followers_url":"https://api.github.com/users/stof/followers","following_url":"https://api.github.com/users/stof/following{/other_user}","gists_url":"https://api.github.com/users/stof/gists{/gist_id}","starred_url":"https://api.github.com/users/stof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stof/subscriptions","organizations_url":"https://api.github.com/users/stof/orgs","repos_url":"https://api.github.com/users/stof/repos","events_url":"https://api.github.com/users/stof/events{/privacy}","received_events_url":"https://api.github.com/users/stof/received_events","type":"User","site_admin":false},"body":"typo in method name: ``relevant``.\r\n\r\nand the method should be private and the argument should be typehinted","created_at":"2014-08-14T03:12:22Z","updated_at":"2014-08-14T03:12:22Z","html_url":"https://github.com/symfony/symfony/pull/10197#discussion_r16219531","pull_request_url":"https://api.github.com/repos/symfony/symfony/pulls/10197","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/16219531"},"html":{"href":"https://github.com/symfony/symfony/pull/10197#discussion_r16219531"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony/pulls/10197"}}},"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/10197","id":12168171,"html_url":"https://github.com/symfony/symfony/pull/10197","diff_url":"https://github.com/symfony/symfony/pull/10197.diff","patch_url":"https://github.com/symfony/symfony/pull/10197.patch","issue_url":"https://api.github.com/repos/symfony/symfony/issues/10197","number":10197,"state":"open","locked":false,"title":"[FrameworkBundle] PhpExtractor bugfix and improvements","user":{"login":"mtibben","id":980499,"avatar_url":"https://avatars.githubusercontent.com/u/980499?v=2","gravatar_id":"6f7884edd0c844d384597a6b008a77c6","url":"https://api.github.com/users/mtibben","html_url":"https://github.com/mtibben","followers_url":"https://api.github.com/users/mtibben/followers","following_url":"https://api.github.com/users/mtibben/following{/other_user}","gists_url":"https://api.github.com/users/mtibben/gists{/gist_id}","starred_url":"https://api.github.com/users/mtibben/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtibben/subscriptions","organizations_url":"https://api.github.com/users/mtibben/orgs","repos_url":"https://api.github.com/users/mtibben/repos","events_url":"https://api.github.com/users/mtibben/events{/privacy}","received_events_url":"https://api.github.com/users/mtibben/received_events","type":"User","site_admin":false},"body":"PhpExtractor currently only handles simple strings which match an overly-specific token sequence.\r\n\r\nThis change adds support for \r\n- heredoc / nowdoc\r\n- inconsistent whitespace when parsing\r\n- escaped sequences in strings\r\n- `transChoice`\r\n\r\n| Q             | A\r\n| ------------- | ---\r\n| Bug fix?      | yes\r\n| New feature?  | no\r\n| BC breaks?    | no\r\n| Deprecations? | no\r\n| Tests pass?   | yes\r\n| Fixed tickets |\r\n| License       | MIT\r\n| Doc PR        |\r\n","created_at":"2014-02-04T08:28:31Z","updated_at":"2014-08-14T03:12:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"59f56b55d1c241234e29984fd5cb195df35c5b99","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/symfony/symfony/pulls/10197/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony/pulls/10197/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony/pulls/comments/{number}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/10197/comments","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/4934c032f9ac170243185eb9c7ea1d5f2605bb61","head":{"label":"mtibben:bugs/transations-php-extractor","ref":"bugs/transations-php-extractor","sha":"4934c032f9ac170243185eb9c7ea1d5f2605bb61","user":{"login":"mtibben","id":980499,"avatar_url":"https://avatars.githubusercontent.com/u/980499?v=2","gravatar_id":"6f7884edd0c844d384597a6b008a77c6","url":"https://api.github.com/users/mtibben","html_url":"https://github.com/mtibben","followers_url":"https://api.github.com/users/mtibben/followers","following_url":"https://api.github.com/users/mtibben/following{/other_user}","gists_url":"https://api.github.com/users/mtibben/gists{/gist_id}","starred_url":"https://api.github.com/users/mtibben/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtibben/subscriptions","organizations_url":"https://api.github.com/users/mtibben/orgs","repos_url":"https://api.github.com/users/mtibben/repos","events_url":"https://api.github.com/users/mtibben/events{/privacy}","received_events_url":"https://api.github.com/users/mtibben/received_events","type":"User","site_admin":false},"repo":{"id":16506114,"name":"symfony","full_name":"mtibben/symfony","owner":{"login":"mtibben","id":980499,"avatar_url":"https://avatars.githubusercontent.com/u/980499?v=2","gravatar_id":"6f7884edd0c844d384597a6b008a77c6","url":"https://api.github.com/users/mtibben","html_url":"https://github.com/mtibben","followers_url":"https://api.github.com/users/mtibben/followers","following_url":"https://api.github.com/users/mtibben/following{/other_user}","gists_url":"https://api.github.com/users/mtibben/gists{/gist_id}","starred_url":"https://api.github.com/users/mtibben/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtibben/subscriptions","organizations_url":"https://api.github.com/users/mtibben/orgs","repos_url":"https://api.github.com/users/mtibben/repos","events_url":"https://api.github.com/users/mtibben/events{/privacy}","received_events_url":"https://api.github.com/users/mtibben/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mtibben/symfony","description":"The Symfony PHP framework","fork":true,"url":"https://api.github.com/repos/mtibben/symfony","forks_url":"https://api.github.com/repos/mtibben/symfony/forks","keys_url":"https://api.github.com/repos/mtibben/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mtibben/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mtibben/symfony/teams","hooks_url":"https://api.github.com/repos/mtibben/symfony/hooks","issue_events_url":"https://api.github.com/repos/mtibben/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/mtibben/symfony/events","assignees_url":"https://api.github.com/repos/mtibben/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/mtibben/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/mtibben/symfony/tags","blobs_url":"https://api.github.com/repos/mtibben/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mtibben/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mtibben/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/mtibben/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mtibben/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/mtibben/symfony/languages","stargazers_url":"https://api.github.com/repos/mtibben/symfony/stargazers","contributors_url":"https://api.github.com/repos/mtibben/symfony/contributors","subscribers_url":"https://api.github.com/repos/mtibben/symfony/subscribers","subscription_url":"https://api.github.com/repos/mtibben/symfony/subscription","commits_url":"https://api.github.com/repos/mtibben/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/mtibben/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/mtibben/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/mtibben/symfony/issues/comments/{number}","contents_url":"https://api.github.com/repos/mtibben/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/mtibben/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mtibben/symfony/merges","archive_url":"https://api.github.com/repos/mtibben/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mtibben/symfony/downloads","issues_url":"https://api.github.com/repos/mtibben/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/mtibben/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/mtibben/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/mtibben/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mtibben/symfony/labels{/name}","releases_url":"https://api.github.com/repos/mtibben/symfony/releases{/id}","created_at":"2014-02-04T08:19:49Z","updated_at":"2014-06-06T03:39:58Z","pushed_at":"2014-06-06T03:39:57Z","git_url":"git://github.com/mtibben/symfony.git","ssh_url":"git@github.com:mtibben/symfony.git","clone_url":"https://github.com/mtibben/symfony.git","svn_url":"https://github.com/mtibben/symfony","homepage":"symfony.com","size":39209,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":false,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"symfony:master","ref":"master","sha":"12d44bcf6cfdc8e5807805b5fe435cf6c24e7a0c","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=2","gravatar_id":"bc6312a5b583c4258c9fad11122c6e31","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":458058,"name":"symfony","full_name":"symfony/symfony","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=2","gravatar_id":"bc6312a5b583c4258c9fad11122c6e31","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony","description":"The Symfony PHP framework","fork":false,"url":"https://api.github.com/repos/symfony/symfony","forks_url":"https://api.github.com/repos/symfony/symfony/forks","keys_url":"https://api.github.com/repos/symfony/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony/teams","hooks_url":"https://api.github.com/repos/symfony/symfony/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony/events","assignees_url":"https://api.github.com/repos/symfony/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony/tags","blobs_url":"https://api.github.com/repos/symfony/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony/subscription","commits_url":"https://api.github.com/repos/symfony/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony/issues/comments/{number}","contents_url":"https://api.github.com/repos/symfony/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony/merges","archive_url":"https://api.github.com/repos/symfony/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony/downloads","issues_url":"https://api.github.com/repos/symfony/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony/releases{/id}","created_at":"2010-01-04T14:21:21Z","updated_at":"2014-08-14T01:37:29Z","pushed_at":"2014-08-13T19:40:24Z","git_url":"git://github.com/symfony/symfony.git","ssh_url":"git@github.com:symfony/symfony.git","clone_url":"https://github.com/symfony/symfony.git","svn_url":"https://github.com/symfony/symfony","homepage":"symfony.com","size":166812,"stargazers_count":8751,"watchers_count":8751,"language":"PHP","has_issues":true,"has_downloads":false,"has_wiki":false,"forks_count":3358,"mirror_url":null,"open_issues_count":858,"forks":3358,"open_issues":858,"watchers":8751,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/10197"},"html":{"href":"https://github.com/symfony/symfony/pull/10197"},"issue":{"href":"https://api.github.com/repos/symfony/symfony/issues/10197"},"comments":{"href":"https://api.github.com/repos/symfony/symfony/issues/10197/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony/pulls/10197/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony/pulls/10197/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony/statuses/4934c032f9ac170243185eb9c7ea1d5f2605bb61"}}}}