GitHub PullRequestReviewCommentEvent at 2014-11-07 21:10:17
Repository: slamdata
Actor: joneshf
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/slamdata/slamdata/pulls/comments/20037638","id":20037638,"diff_hunk":"@@ -61,12 +67,13 @@\n     \"showdown\": \"~0.3.1\",\n     \"reactable\": \"f0f3f45959ee2a851322f779658db7608b7b8a1d\",\n     \"icomoon\": \"~0.0.1\",\n-    \"slamengine-jar\": \"https://github.com/slamdata/slamengine/releases/download/v1.0.2-SNAPSHOT-112/slamengine_2.11-1.0.2-SNAPSHOT-one-jar.jar\",\n-    \"purescript-strings\": \"~0.4.0\",\n-    \"purescript-maps\": \"~0.1.1\"\n+    \"slamengine-jar\": \"https://github.com/slamdata/slamengine/releases/download/v1.0.2-SNAPSHOT-112/slamengine_2.11-1.0.2-SNAPSHOT-one-jar.jar\"\n   },\n   \"devDependencies\": {\n     \"underscore-contrib\": \"~0.3.0\",\n     \"tiny-emitter\": \"~1.0.0\"\n+  },\n+  \"resolutions\": {\n+    \"d3\": \"~3.3.13\"","path":"bower.json","position":59,"original_position":59,"commit_id":"a92203f9634bf9c7cd1f280ba28ba7cd93d92893","original_commit_id":"63252dad037729dee1da896995ad9432669be59a","user":{"login":"joneshf","id":1356417,"avatar_url":"https://avatars.githubusercontent.com/u/1356417?v=3","gravatar_id":"","url":"https://api.github.com/users/joneshf","html_url":"https://github.com/joneshf","followers_url":"https://api.github.com/users/joneshf/followers","following_url":"https://api.github.com/users/joneshf/following{/other_user}","gists_url":"https://api.github.com/users/joneshf/gists{/gist_id}","starred_url":"https://api.github.com/users/joneshf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joneshf/subscriptions","organizations_url":"https://api.github.com/users/joneshf/orgs","repos_url":"https://api.github.com/users/joneshf/repos","events_url":"https://api.github.com/users/joneshf/events{/privacy}","received_events_url":"https://api.github.com/users/joneshf/received_events","type":"User","site_admin":false},"body":"Probably the nw version needs the new dependencies. I can check in a bit.\r\n\r\nAlso, I'd prefer if we didn't need to duplicate the requirements, but I can't remember why I started doing that. Might've been a late night thing, or some limitation of psc at the time, I'll look into this as well.","created_at":"2014-11-07T21:10:17Z","updated_at":"2014-11-07T21:10:17Z","html_url":"https://github.com/slamdata/slamdata/pull/157#discussion_r20037638","pull_request_url":"https://api.github.com/repos/slamdata/slamdata/pulls/157","_links":{"self":{"href":"https://api.github.com/repos/slamdata/slamdata/pulls/comments/20037638"},"html":{"href":"https://github.com/slamdata/slamdata/pull/157#discussion_r20037638"},"pull_request":{"href":"https://api.github.com/repos/slamdata/slamdata/pulls/157"}}},"pull_request":{"url":"https://api.github.com/repos/slamdata/slamdata/pulls/157","id":24071466,"html_url":"https://github.com/slamdata/slamdata/pull/157","diff_url":"https://github.com/slamdata/slamdata/pull/157.diff","patch_url":"https://github.com/slamdata/slamdata/pull/157.patch","issue_url":"https://api.github.com/repos/slamdata/slamdata/issues/157","number":157,"state":"open","locked":false,"title":"Partial work towards #30","user":{"login":"jdegoes","id":156745,"avatar_url":"https://avatars.githubusercontent.com/u/156745?v=3","gravatar_id":"","url":"https://api.github.com/users/jdegoes","html_url":"https://github.com/jdegoes","followers_url":"https://api.github.com/users/jdegoes/followers","following_url":"https://api.github.com/users/jdegoes/following{/other_user}","gists_url":"https://api.github.com/users/jdegoes/gists{/gist_id}","starred_url":"https://api.github.com/users/jdegoes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdegoes/subscriptions","organizations_url":"https://api.github.com/users/jdegoes/orgs","repos_url":"https://api.github.com/users/jdegoes/repos","events_url":"https://api.github.com/users/jdegoes/events{/privacy}","received_events_url":"https://api.github.com/users/jdegoes/received_events","type":"User","site_admin":false},"body":"A mega-PR that includes a whole bunch of changes related to intelligent charting (#30):\r\n\r\n1. Added analysis module for analyzing JSON, which uses heuristics currently to detect common types.\r\n2. Added interface for charts, which enables generation, perturbation, serialization, and rendering of chart options.\r\n3. Added implementation for `PieChartOptions` based on NVD3.\r\n\r\nOnce thoroughly tested / debugged, this is expected to become the pattern for other chart types (line, bar, etc.).\r\n\r\nReview by @joneshf ","created_at":"2014-11-07T18:18:35Z","updated_at":"2014-11-07T21:10:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d4b6e01e4780420380a494ad4f83aea2f35691f4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/slamdata/slamdata/pulls/157/commits","review_comments_url":"https://api.github.com/repos/slamdata/slamdata/pulls/157/comments","review_comment_url":"https://api.github.com/repos/slamdata/slamdata/pulls/comments/{number}","comments_url":"https://api.github.com/repos/slamdata/slamdata/issues/157/comments","statuses_url":"https://api.github.com/repos/slamdata/slamdata/statuses/a92203f9634bf9c7cd1f280ba28ba7cd93d92893","head":{"label":"jdegoes:ready/30","ref":"ready/30","sha":"a92203f9634bf9c7cd1f280ba28ba7cd93d92893","user":{"login":"jdegoes","id":156745,"avatar_url":"https://avatars.githubusercontent.com/u/156745?v=3","gravatar_id":"","url":"https://api.github.com/users/jdegoes","html_url":"https://github.com/jdegoes","followers_url":"https://api.github.com/users/jdegoes/followers","following_url":"https://api.github.com/users/jdegoes/following{/other_user}","gists_url":"https://api.github.com/users/jdegoes/gists{/gist_id}","starred_url":"https://api.github.com/users/jdegoes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdegoes/subscriptions","organizations_url":"https://api.github.com/users/jdegoes/orgs","repos_url":"https://api.github.com/users/jdegoes/repos","events_url":"https://api.github.com/users/jdegoes/events{/privacy}","received_events_url":"https://api.github.com/users/jdegoes/received_events","type":"User","site_admin":false},"repo":{"id":23977006,"name":"slamdata","full_name":"jdegoes/slamdata","owner":{"login":"jdegoes","id":156745,"avatar_url":"https://avatars.githubusercontent.com/u/156745?v=3","gravatar_id":"","url":"https://api.github.com/users/jdegoes","html_url":"https://github.com/jdegoes","followers_url":"https://api.github.com/users/jdegoes/followers","following_url":"https://api.github.com/users/jdegoes/following{/other_user}","gists_url":"https://api.github.com/users/jdegoes/gists{/gist_id}","starred_url":"https://api.github.com/users/jdegoes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdegoes/subscriptions","organizations_url":"https://api.github.com/users/jdegoes/orgs","repos_url":"https://api.github.com/users/jdegoes/repos","events_url":"https://api.github.com/users/jdegoes/events{/privacy}","received_events_url":"https://api.github.com/users/jdegoes/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jdegoes/slamdata","description":"The front-end for SlamEngine.","fork":true,"url":"https://api.github.com/repos/jdegoes/slamdata","forks_url":"https://api.github.com/repos/jdegoes/slamdata/forks","keys_url":"https://api.github.com/repos/jdegoes/slamdata/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jdegoes/slamdata/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jdegoes/slamdata/teams","hooks_url":"https://api.github.com/repos/jdegoes/slamdata/hooks","issue_events_url":"https://api.github.com/repos/jdegoes/slamdata/issues/events{/number}","events_url":"https://api.github.com/repos/jdegoes/slamdata/events","assignees_url":"https://api.github.com/repos/jdegoes/slamdata/assignees{/user}","branches_url":"https://api.github.com/repos/jdegoes/slamdata/branches{/branch}","tags_url":"https://api.github.com/repos/jdegoes/slamdata/tags","blobs_url":"https://api.github.com/repos/jdegoes/slamdata/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jdegoes/slamdata/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jdegoes/slamdata/git/refs{/sha}","trees_url":"https://api.github.com/repos/jdegoes/slamdata/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jdegoes/slamdata/statuses/{sha}","languages_url":"https://api.github.com/repos/jdegoes/slamdata/languages","stargazers_url":"https://api.github.com/repos/jdegoes/slamdata/stargazers","contributors_url":"https://api.github.com/repos/jdegoes/slamdata/contributors","subscribers_url":"https://api.github.com/repos/jdegoes/slamdata/subscribers","subscription_url":"https://api.github.com/repos/jdegoes/slamdata/subscription","commits_url":"https://api.github.com/repos/jdegoes/slamdata/commits{/sha}","git_commits_url":"https://api.github.com/repos/jdegoes/slamdata/git/commits{/sha}","comments_url":"https://api.github.com/repos/jdegoes/slamdata/comments{/number}","issue_comment_url":"https://api.github.com/repos/jdegoes/slamdata/issues/comments/{number}","contents_url":"https://api.github.com/repos/jdegoes/slamdata/contents/{+path}","compare_url":"https://api.github.com/repos/jdegoes/slamdata/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jdegoes/slamdata/merges","archive_url":"https://api.github.com/repos/jdegoes/slamdata/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jdegoes/slamdata/downloads","issues_url":"https://api.github.com/repos/jdegoes/slamdata/issues{/number}","pulls_url":"https://api.github.com/repos/jdegoes/slamdata/pulls{/number}","milestones_url":"https://api.github.com/repos/jdegoes/slamdata/milestones{/number}","notifications_url":"https://api.github.com/repos/jdegoes/slamdata/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jdegoes/slamdata/labels{/name}","releases_url":"https://api.github.com/repos/jdegoes/slamdata/releases{/id}","created_at":"2014-09-12T21:08:43Z","updated_at":"2014-09-29T19:11:47Z","pushed_at":"2014-11-07T20:44:14Z","git_url":"git://github.com/jdegoes/slamdata.git","ssh_url":"git@github.com:jdegoes/slamdata.git","clone_url":"https://github.com/jdegoes/slamdata.git","svn_url":"https://github.com/jdegoes/slamdata","homepage":null,"size":3933,"stargazers_count":0,"watchers_count":0,"language":"PureScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"slamdata:master","ref":"master","sha":"ca7369d4993be77c5c05ddfba7f39b474ed2fd2e","user":{"login":"slamdata","id":5385602,"avatar_url":"https://avatars.githubusercontent.com/u/5385602?v=3","gravatar_id":"","url":"https://api.github.com/users/slamdata","html_url":"https://github.com/slamdata","followers_url":"https://api.github.com/users/slamdata/followers","following_url":"https://api.github.com/users/slamdata/following{/other_user}","gists_url":"https://api.github.com/users/slamdata/gists{/gist_id}","starred_url":"https://api.github.com/users/slamdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slamdata/subscriptions","organizations_url":"https://api.github.com/users/slamdata/orgs","repos_url":"https://api.github.com/users/slamdata/repos","events_url":"https://api.github.com/users/slamdata/events{/privacy}","received_events_url":"https://api.github.com/users/slamdata/received_events","type":"Organization","site_admin":false},"repo":{"id":19464471,"name":"slamdata","full_name":"slamdata/slamdata","owner":{"login":"slamdata","id":5385602,"avatar_url":"https://avatars.githubusercontent.com/u/5385602?v=3","gravatar_id":"","url":"https://api.github.com/users/slamdata","html_url":"https://github.com/slamdata","followers_url":"https://api.github.com/users/slamdata/followers","following_url":"https://api.github.com/users/slamdata/following{/other_user}","gists_url":"https://api.github.com/users/slamdata/gists{/gist_id}","starred_url":"https://api.github.com/users/slamdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slamdata/subscriptions","organizations_url":"https://api.github.com/users/slamdata/orgs","repos_url":"https://api.github.com/users/slamdata/repos","events_url":"https://api.github.com/users/slamdata/events{/privacy}","received_events_url":"https://api.github.com/users/slamdata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/slamdata/slamdata","description":"The front-end for SlamEngine.","fork":false,"url":"https://api.github.com/repos/slamdata/slamdata","forks_url":"https://api.github.com/repos/slamdata/slamdata/forks","keys_url":"https://api.github.com/repos/slamdata/slamdata/keys{/key_id}","collaborators_url":"https://api.github.com/repos/slamdata/slamdata/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/slamdata/slamdata/teams","hooks_url":"https://api.github.com/repos/slamdata/slamdata/hooks","issue_events_url":"https://api.github.com/repos/slamdata/slamdata/issues/events{/number}","events_url":"https://api.github.com/repos/slamdata/slamdata/events","assignees_url":"https://api.github.com/repos/slamdata/slamdata/assignees{/user}","branches_url":"https://api.github.com/repos/slamdata/slamdata/branches{/branch}","tags_url":"https://api.github.com/repos/slamdata/slamdata/tags","blobs_url":"https://api.github.com/repos/slamdata/slamdata/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/slamdata/slamdata/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/slamdata/slamdata/git/refs{/sha}","trees_url":"https://api.github.com/repos/slamdata/slamdata/git/trees{/sha}","statuses_url":"https://api.github.com/repos/slamdata/slamdata/statuses/{sha}","languages_url":"https://api.github.com/repos/slamdata/slamdata/languages","stargazers_url":"https://api.github.com/repos/slamdata/slamdata/stargazers","contributors_url":"https://api.github.com/repos/slamdata/slamdata/contributors","subscribers_url":"https://api.github.com/repos/slamdata/slamdata/subscribers","subscription_url":"https://api.github.com/repos/slamdata/slamdata/subscription","commits_url":"https://api.github.com/repos/slamdata/slamdata/commits{/sha}","git_commits_url":"https://api.github.com/repos/slamdata/slamdata/git/commits{/sha}","comments_url":"https://api.github.com/repos/slamdata/slamdata/comments{/number}","issue_comment_url":"https://api.github.com/repos/slamdata/slamdata/issues/comments/{number}","contents_url":"https://api.github.com/repos/slamdata/slamdata/contents/{+path}","compare_url":"https://api.github.com/repos/slamdata/slamdata/compare/{base}...{head}","merges_url":"https://api.github.com/repos/slamdata/slamdata/merges","archive_url":"https://api.github.com/repos/slamdata/slamdata/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/slamdata/slamdata/downloads","issues_url":"https://api.github.com/repos/slamdata/slamdata/issues{/number}","pulls_url":"https://api.github.com/repos/slamdata/slamdata/pulls{/number}","milestones_url":"https://api.github.com/repos/slamdata/slamdata/milestones{/number}","notifications_url":"https://api.github.com/repos/slamdata/slamdata/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/slamdata/slamdata/labels{/name}","releases_url":"https://api.github.com/repos/slamdata/slamdata/releases{/id}","created_at":"2014-05-05T17:27:44Z","updated_at":"2014-11-07T02:29:03Z","pushed_at":"2014-11-07T15:29:24Z","git_url":"git://github.com/slamdata/slamdata.git","ssh_url":"git@github.com:slamdata/slamdata.git","clone_url":"https://github.com/slamdata/slamdata.git","svn_url":"https://github.com/slamdata/slamdata","homepage":null,"size":5059,"stargazers_count":37,"watchers_count":37,"language":"PureScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":25,"forks":11,"open_issues":25,"watchers":37,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/slamdata/slamdata/pulls/157"},"html":{"href":"https://github.com/slamdata/slamdata/pull/157"},"issue":{"href":"https://api.github.com/repos/slamdata/slamdata/issues/157"},"comments":{"href":"https://api.github.com/repos/slamdata/slamdata/issues/157/comments"},"review_comments":{"href":"https://api.github.com/repos/slamdata/slamdata/pulls/157/comments"},"review_comment":{"href":"https://api.github.com/repos/slamdata/slamdata/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/slamdata/slamdata/pulls/157/commits"},"statuses":{"href":"https://api.github.com/repos/slamdata/slamdata/statuses/a92203f9634bf9c7cd1f280ba28ba7cd93d92893"}}}}