GitHub PullRequestReviewCommentEvent at 2014-03-26 09:02:21
Repository: SalesforceMobileSDK-Android
Actor: bhariharan
Payload: {"comment":{"url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/pulls/comments/10968214","id":10968214,"diff_hunk":"@@ -180,17 +180,13 @@ public void testDoesUserAccountExist() {\n      * Test to signout of the current user.\n      */\n     public void testSignoutCurrentUser() {\n-    \t/*\n-    \t * FIXME: This test works standalone, but in a suite, subsequent tests\n-    \t * won't execute, since logout pops the top activity off the stack,\n-    \t * driving the test runner crazy. Need to find a workaround.\n-    \t */\n     \tList<UserAccount> users = userAccMgr.getAuthenticatedUsers();\n     \tassertNull(\"There should be no authenticated users\", users);\n     \tcreateTestAccount();\n     \tusers = userAccMgr.getAuthenticatedUsers();\n     \tassertEquals(\"There should be 1 authenticated user\", 1, users.size());\n     \tuserAccMgr.signoutCurrentUser(null);\n+    \teq.waitForEvent(EventType.LogoutComplete, 30000);","path":"native/test/SalesforceSDKTest/src/com/salesforce/androidsdk/accounts/UserAccountManagerTest.java","position":15,"original_position":15,"commit_id":"1f165554c234eee940b3ada28b16da2be821eec2","original_commit_id":"1f165554c234eee940b3ada28b16da2be821eec2","user":{"login":"bhariharan","id":1820287,"avatar_url":"https://avatars.githubusercontent.com/u/1820287?","gravatar_id":"2166720cb0d5fa78ace38f31856b1806","url":"https://api.github.com/users/bhariharan","html_url":"https://github.com/bhariharan","followers_url":"https://api.github.com/users/bhariharan/followers","following_url":"https://api.github.com/users/bhariharan/following{/other_user}","gists_url":"https://api.github.com/users/bhariharan/gists{/gist_id}","starred_url":"https://api.github.com/users/bhariharan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bhariharan/subscriptions","organizations_url":"https://api.github.com/users/bhariharan/orgs","repos_url":"https://api.github.com/users/bhariharan/repos","events_url":"https://api.github.com/users/bhariharan/events{/privacy}","received_events_url":"https://api.github.com/users/bhariharan/received_events","type":"User","site_admin":false},"body":"Pretty simple fix here - all we had to do was wait for the right event to come along.","created_at":"2014-03-26T09:02:21Z","updated_at":"2014-03-26T09:02:21Z","html_url":"https://github.com/forcedotcom/SalesforceMobileSDK-Android/pull/469#discussion_r10968214","pull_request_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/pulls/469","_links":{"self":{"href":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/pulls/comments/10968214"},"html":{"href":"https://github.com/forcedotcom/SalesforceMobileSDK-Android/pull/469#discussion_r10968214"},"pull_request":{"href":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/pulls/469"}}}}