GitHub PullRequestReviewCommentEvent at 2014-12-05 07:34:11
Repository: ceph
Actor: yuyuyu101
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/ceph/ceph/pulls/comments/21358732","id":21358732,"diff_hunk":"@@ -383,26 +387,75 @@ class ObjectStore {\n       COLL_HINT_EXPECTED_NUM_OBJECTS = 1,\n     };\n \n+    struct Op {\n+      __le32 op;\n+      __le32 cid;\n+      __le32 oid;\n+      __le64 off;\n+      __le64 len;","path":"src/os/ObjectStore.h","position":31,"original_position":31,"commit_id":"bdadc6eed2c2b4425c8d8bd067e2e714bb3ff878","original_commit_id":"bdadc6eed2c2b4425c8d8bd067e2e714bb3ff878","user":{"login":"yuyuyu101","id":980577,"avatar_url":"https://avatars.githubusercontent.com/u/980577?v=3","gravatar_id":"","url":"https://api.github.com/users/yuyuyu101","html_url":"https://github.com/yuyuyu101","followers_url":"https://api.github.com/users/yuyuyu101/followers","following_url":"https://api.github.com/users/yuyuyu101/following{/other_user}","gists_url":"https://api.github.com/users/yuyuyu101/gists{/gist_id}","starred_url":"https://api.github.com/users/yuyuyu101/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuyuyu101/subscriptions","organizations_url":"https://api.github.com/users/yuyuyu101/orgs","repos_url":"https://api.github.com/users/yuyuyu101/repos","events_url":"https://api.github.com/users/yuyuyu101/events{/privacy}","received_events_url":"https://api.github.com/users/yuyuyu101/received_events","type":"User","site_admin":false},"body":"for the following fields, I think we can construct several struct and make them as a union structure here to reduce space consuming","created_at":"2014-12-05T07:34:11Z","updated_at":"2014-12-05T07:34:11Z","html_url":"https://github.com/ceph/ceph/pull/2991#discussion_r21358732","pull_request_url":"https://api.github.com/repos/ceph/ceph/pulls/2991","_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments/21358732"},"html":{"href":"https://github.com/ceph/ceph/pull/2991#discussion_r21358732"},"pull_request":{"href":"https://api.github.com/repos/ceph/ceph/pulls/2991"}}},"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/2991","id":24926098,"html_url":"https://github.com/ceph/ceph/pull/2991","diff_url":"https://github.com/ceph/ceph/pull/2991.diff","patch_url":"https://github.com/ceph/ceph/pull/2991.patch","issue_url":"https://api.github.com/repos/ceph/ceph/issues/2991","number":2991,"state":"open","locked":false,"title":"WIP: Fast transaction encode & decode","user":{"login":"yuandong1222","id":1825849,"avatar_url":"https://avatars.githubusercontent.com/u/1825849?v=3","gravatar_id":"","url":"https://api.github.com/users/yuandong1222","html_url":"https://github.com/yuandong1222","followers_url":"https://api.github.com/users/yuandong1222/followers","following_url":"https://api.github.com/users/yuandong1222/following{/other_user}","gists_url":"https://api.github.com/users/yuandong1222/gists{/gist_id}","starred_url":"https://api.github.com/users/yuandong1222/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuandong1222/subscriptions","organizations_url":"https://api.github.com/users/yuandong1222/orgs","repos_url":"https://api.github.com/users/yuandong1222/repos","events_url":"https://api.github.com/users/yuandong1222/events{/privacy}","received_events_url":"https://api.github.com/users/yuandong1222/received_events","type":"User","site_admin":false},"body":"Current transaction use a bufferlist tbl to encode all actions and their data, so if object appears many times, it will be encoded many times. And when FileStore do this transaction, it must decode all actions and data from the tbl.\r\n\r\nThis path follows BP: osd: update_Transaction_encoding, \r\n\r\nThe transaction use two maps to keep all colls and objects appeared in the transaction, and each coll and object only need to be encoded once. On the other hand, FileStore don't need to decode actions, colls and objects anymore.","created_at":"2014-11-24T11:21:53Z","updated_at":"2014-12-05T07:34:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"75fc5d1d263acb035aecefcf97751d0e946c8d02","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph/pulls/2991/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph/pulls/2991/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/2991/comments","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/bdadc6eed2c2b4425c8d8bd067e2e714bb3ff878","head":{"label":"yuandong1222:fast-transaction-encode-decode","ref":"fast-transaction-encode-decode","sha":"bdadc6eed2c2b4425c8d8bd067e2e714bb3ff878","user":{"login":"yuandong1222","id":1825849,"avatar_url":"https://avatars.githubusercontent.com/u/1825849?v=3","gravatar_id":"","url":"https://api.github.com/users/yuandong1222","html_url":"https://github.com/yuandong1222","followers_url":"https://api.github.com/users/yuandong1222/followers","following_url":"https://api.github.com/users/yuandong1222/following{/other_user}","gists_url":"https://api.github.com/users/yuandong1222/gists{/gist_id}","starred_url":"https://api.github.com/users/yuandong1222/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuandong1222/subscriptions","organizations_url":"https://api.github.com/users/yuandong1222/orgs","repos_url":"https://api.github.com/users/yuandong1222/repos","events_url":"https://api.github.com/users/yuandong1222/events{/privacy}","received_events_url":"https://api.github.com/users/yuandong1222/received_events","type":"User","site_admin":false},"repo":{"id":11190106,"name":"ceph","full_name":"yuandong1222/ceph","owner":{"login":"yuandong1222","id":1825849,"avatar_url":"https://avatars.githubusercontent.com/u/1825849?v=3","gravatar_id":"","url":"https://api.github.com/users/yuandong1222","html_url":"https://github.com/yuandong1222","followers_url":"https://api.github.com/users/yuandong1222/followers","following_url":"https://api.github.com/users/yuandong1222/following{/other_user}","gists_url":"https://api.github.com/users/yuandong1222/gists{/gist_id}","starred_url":"https://api.github.com/users/yuandong1222/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuandong1222/subscriptions","organizations_url":"https://api.github.com/users/yuandong1222/orgs","repos_url":"https://api.github.com/users/yuandong1222/repos","events_url":"https://api.github.com/users/yuandong1222/events{/privacy}","received_events_url":"https://api.github.com/users/yuandong1222/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yuandong1222/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":true,"url":"https://api.github.com/repos/yuandong1222/ceph","forks_url":"https://api.github.com/repos/yuandong1222/ceph/forks","keys_url":"https://api.github.com/repos/yuandong1222/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yuandong1222/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yuandong1222/ceph/teams","hooks_url":"https://api.github.com/repos/yuandong1222/ceph/hooks","issue_events_url":"https://api.github.com/repos/yuandong1222/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/yuandong1222/ceph/events","assignees_url":"https://api.github.com/repos/yuandong1222/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/yuandong1222/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/yuandong1222/ceph/tags","blobs_url":"https://api.github.com/repos/yuandong1222/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yuandong1222/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yuandong1222/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/yuandong1222/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yuandong1222/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/yuandong1222/ceph/languages","stargazers_url":"https://api.github.com/repos/yuandong1222/ceph/stargazers","contributors_url":"https://api.github.com/repos/yuandong1222/ceph/contributors","subscribers_url":"https://api.github.com/repos/yuandong1222/ceph/subscribers","subscription_url":"https://api.github.com/repos/yuandong1222/ceph/subscription","commits_url":"https://api.github.com/repos/yuandong1222/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/yuandong1222/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/yuandong1222/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/yuandong1222/ceph/issues/comments/{number}","contents_url":"https://api.github.com/repos/yuandong1222/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/yuandong1222/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yuandong1222/ceph/merges","archive_url":"https://api.github.com/repos/yuandong1222/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yuandong1222/ceph/downloads","issues_url":"https://api.github.com/repos/yuandong1222/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/yuandong1222/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/yuandong1222/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/yuandong1222/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yuandong1222/ceph/labels{/name}","releases_url":"https://api.github.com/repos/yuandong1222/ceph/releases{/id}","created_at":"2013-07-05T02:23:14Z","updated_at":"2014-12-02T09:32:02Z","pushed_at":"2014-12-05T03:13:12Z","git_url":"git://github.com/yuandong1222/ceph.git","ssh_url":"git@github.com:yuandong1222/ceph.git","clone_url":"https://github.com/yuandong1222/ceph.git","svn_url":"https://github.com/yuandong1222/ceph","homepage":"http://ceph.com","size":88461,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"9e3e4c8e51b0e9d336520aab351a459e23ba9370","user":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":2310495,"name":"ceph","full_name":"ceph/ceph","owner":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ceph/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":false,"url":"https://api.github.com/repos/ceph/ceph","forks_url":"https://api.github.com/repos/ceph/ceph/forks","keys_url":"https://api.github.com/repos/ceph/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph/teams","hooks_url":"https://api.github.com/repos/ceph/ceph/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph/events","assignees_url":"https://api.github.com/repos/ceph/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph/tags","blobs_url":"https://api.github.com/repos/ceph/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph/subscription","commits_url":"https://api.github.com/repos/ceph/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph/issues/comments/{number}","contents_url":"https://api.github.com/repos/ceph/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph/merges","archive_url":"https://api.github.com/repos/ceph/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph/downloads","issues_url":"https://api.github.com/repos/ceph/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph/releases{/id}","created_at":"2011-09-01T21:41:26Z","updated_at":"2014-12-05T05:48:33Z","pushed_at":"2014-12-05T07:25:54Z","git_url":"git://github.com/ceph/ceph.git","ssh_url":"git@github.com:ceph/ceph.git","clone_url":"https://github.com/ceph/ceph.git","svn_url":"https://github.com/ceph/ceph","homepage":"http://ceph.com","size":296761,"stargazers_count":1013,"watchers_count":1013,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":507,"mirror_url":null,"open_issues_count":73,"forks":507,"open_issues":73,"watchers":1013,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/2991"},"html":{"href":"https://github.com/ceph/ceph/pull/2991"},"issue":{"href":"https://api.github.com/repos/ceph/ceph/issues/2991"},"comments":{"href":"https://api.github.com/repos/ceph/ceph/issues/2991/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph/pulls/2991/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph/pulls/2991/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph/statuses/bdadc6eed2c2b4425c8d8bd067e2e714bb3ff878"}}}}