GitHub PullRequestReviewCommentEvent at 2014-07-19 09:22:58
Repository: sympy
Actor: skirpichev
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/sympy/sympy/pulls/comments/15142890","id":15142890,"diff_hunk":"@@ -606,6 +618,8 @@ def test_acos():\n     assert acos(Rational(3, 2), evaluate=False).is_positive is False\n     assert acos(p).is_positive is None\n \n+    assert acos(z).conjugate() == acos(conjugate(z))","path":"sympy/functions/elementary/tests/test_trigonometric.py","position":53,"original_position":53,"commit_id":"2956d049323ba14c67159fa0ca06381aabad1b4c","original_commit_id":"2956d049323ba14c67159fa0ca06381aabad1b4c","user":{"login":"skirpichev","id":2155800,"avatar_url":"https://avatars.githubusercontent.com/u/2155800?","gravatar_id":"0621cf21f5cba395eaa48c7541265738","url":"https://api.github.com/users/skirpichev","html_url":"https://github.com/skirpichev","followers_url":"https://api.github.com/users/skirpichev/followers","following_url":"https://api.github.com/users/skirpichev/following{/other_user}","gists_url":"https://api.github.com/users/skirpichev/gists{/gist_id}","starred_url":"https://api.github.com/users/skirpichev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skirpichev/subscriptions","organizations_url":"https://api.github.com/users/skirpichev/orgs","repos_url":"https://api.github.com/users/skirpichev/repos","events_url":"https://api.github.com/users/skirpichev/events{/privacy}","received_events_url":"https://api.github.com/users/skirpichev/received_events","type":"User","site_admin":false},"body":"On Fri, Jul 18, 2014 at 05:02:55PM -0700, raoulb wrote:\n>    In sympy/functions/elementary/tests/test_trigonometric.py:\n> \n>  > @@ -606,6 +618,8 @@ def test_acos():\n>  >      assert acos(Rational(3, 2), evaluate=False).is_positive is False\n>  >      assert acos(p).is_positive is None\n>  >\n>  > +    assert acos(z).conjugate() == acos(conjugate(z))\n> \n>    There are such rules for all other functions.\n>    Usually there are some conditions restricting the general equality.\n>    For asin it is x not +-1, +-oo I think.\n>    How should we handle such stuff? Ignore for the moment?\n\nSee sympy/functions/special/elliptic_integrals.py for example.\n\nI'll try to fix this for inverse trig functions.","created_at":"2014-07-19T09:22:58Z","updated_at":"2014-07-19T09:22:58Z","html_url":"https://github.com/sympy/sympy/pull/7500#discussion_r15142890","pull_request_url":"https://api.github.com/repos/sympy/sympy/pulls/7500","_links":{"self":{"href":"https://api.github.com/repos/sympy/sympy/pulls/comments/15142890"},"html":{"href":"https://github.com/sympy/sympy/pull/7500#discussion_r15142890"},"pull_request":{"href":"https://api.github.com/repos/sympy/sympy/pulls/7500"}}},"pull_request":{"url":"https://api.github.com/repos/sympy/sympy/pulls/7500","id":15977337,"html_url":"https://github.com/sympy/sympy/pull/7500","diff_url":"https://github.com/sympy/sympy/pull/7500.diff","patch_url":"https://github.com/sympy/sympy/pull/7500.patch","issue_url":"https://api.github.com/repos/sympy/sympy/issues/7500","number":7500,"state":"open","title":"Replacement for @raoulb pr#914","user":{"login":"skirpichev","id":2155800,"avatar_url":"https://avatars.githubusercontent.com/u/2155800?","gravatar_id":"0621cf21f5cba395eaa48c7541265738","url":"https://api.github.com/users/skirpichev","html_url":"https://github.com/skirpichev","followers_url":"https://api.github.com/users/skirpichev/followers","following_url":"https://api.github.com/users/skirpichev/following{/other_user}","gists_url":"https://api.github.com/users/skirpichev/gists{/gist_id}","starred_url":"https://api.github.com/users/skirpichev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skirpichev/subscriptions","organizations_url":"https://api.github.com/users/skirpichev/orgs","repos_url":"https://api.github.com/users/skirpichev/repos","events_url":"https://api.github.com/users/skirpichev/events{/privacy}","received_events_url":"https://api.github.com/users/skirpichev/received_events","type":"User","site_admin":false},"body":"See #914\r\n\r\nToDo:\r\n- [x] tests\r\n- [x] final rebase","created_at":"2014-05-16T09:07:25Z","updated_at":"2014-07-19T09:22:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"60d5d7fddb03e5d220b0543d4864ba84039b7690","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sympy/sympy/pulls/7500/commits","review_comments_url":"https://api.github.com/repos/sympy/sympy/pulls/7500/comments","review_comment_url":"https://api.github.com/repos/sympy/sympy/pulls/comments/{number}","comments_url":"https://api.github.com/repos/sympy/sympy/issues/7500/comments","statuses_url":"https://api.github.com/repos/sympy/sympy/statuses/2956d049323ba14c67159fa0ca06381aabad1b4c","head":{"label":"skirpichev:raoulb-trig","ref":"raoulb-trig","sha":"2956d049323ba14c67159fa0ca06381aabad1b4c","user":{"login":"skirpichev","id":2155800,"avatar_url":"https://avatars.githubusercontent.com/u/2155800?","gravatar_id":"0621cf21f5cba395eaa48c7541265738","url":"https://api.github.com/users/skirpichev","html_url":"https://github.com/skirpichev","followers_url":"https://api.github.com/users/skirpichev/followers","following_url":"https://api.github.com/users/skirpichev/following{/other_user}","gists_url":"https://api.github.com/users/skirpichev/gists{/gist_id}","starred_url":"https://api.github.com/users/skirpichev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skirpichev/subscriptions","organizations_url":"https://api.github.com/users/skirpichev/orgs","repos_url":"https://api.github.com/users/skirpichev/repos","events_url":"https://api.github.com/users/skirpichev/events{/privacy}","received_events_url":"https://api.github.com/users/skirpichev/received_events","type":"User","site_admin":false},"repo":{"id":8088589,"name":"sympy","full_name":"skirpichev/sympy","owner":{"login":"skirpichev","id":2155800,"avatar_url":"https://avatars.githubusercontent.com/u/2155800?","gravatar_id":"0621cf21f5cba395eaa48c7541265738","url":"https://api.github.com/users/skirpichev","html_url":"https://github.com/skirpichev","followers_url":"https://api.github.com/users/skirpichev/followers","following_url":"https://api.github.com/users/skirpichev/following{/other_user}","gists_url":"https://api.github.com/users/skirpichev/gists{/gist_id}","starred_url":"https://api.github.com/users/skirpichev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skirpichev/subscriptions","organizations_url":"https://api.github.com/users/skirpichev/orgs","repos_url":"https://api.github.com/users/skirpichev/repos","events_url":"https://api.github.com/users/skirpichev/events{/privacy}","received_events_url":"https://api.github.com/users/skirpichev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/skirpichev/sympy","description":"A computer algebra system written in pure Python","fork":true,"url":"https://api.github.com/repos/skirpichev/sympy","forks_url":"https://api.github.com/repos/skirpichev/sympy/forks","keys_url":"https://api.github.com/repos/skirpichev/sympy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/skirpichev/sympy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/skirpichev/sympy/teams","hooks_url":"https://api.github.com/repos/skirpichev/sympy/hooks","issue_events_url":"https://api.github.com/repos/skirpichev/sympy/issues/events{/number}","events_url":"https://api.github.com/repos/skirpichev/sympy/events","assignees_url":"https://api.github.com/repos/skirpichev/sympy/assignees{/user}","branches_url":"https://api.github.com/repos/skirpichev/sympy/branches{/branch}","tags_url":"https://api.github.com/repos/skirpichev/sympy/tags","blobs_url":"https://api.github.com/repos/skirpichev/sympy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/skirpichev/sympy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/skirpichev/sympy/git/refs{/sha}","trees_url":"https://api.github.com/repos/skirpichev/sympy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/skirpichev/sympy/statuses/{sha}","languages_url":"https://api.github.com/repos/skirpichev/sympy/languages","stargazers_url":"https://api.github.com/repos/skirpichev/sympy/stargazers","contributors_url":"https://api.github.com/repos/skirpichev/sympy/contributors","subscribers_url":"https://api.github.com/repos/skirpichev/sympy/subscribers","subscription_url":"https://api.github.com/repos/skirpichev/sympy/subscription","commits_url":"https://api.github.com/repos/skirpichev/sympy/commits{/sha}","git_commits_url":"https://api.github.com/repos/skirpichev/sympy/git/commits{/sha}","comments_url":"https://api.github.com/repos/skirpichev/sympy/comments{/number}","issue_comment_url":"https://api.github.com/repos/skirpichev/sympy/issues/comments/{number}","contents_url":"https://api.github.com/repos/skirpichev/sympy/contents/{+path}","compare_url":"https://api.github.com/repos/skirpichev/sympy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/skirpichev/sympy/merges","archive_url":"https://api.github.com/repos/skirpichev/sympy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/skirpichev/sympy/downloads","issues_url":"https://api.github.com/repos/skirpichev/sympy/issues{/number}","pulls_url":"https://api.github.com/repos/skirpichev/sympy/pulls{/number}","milestones_url":"https://api.github.com/repos/skirpichev/sympy/milestones{/number}","notifications_url":"https://api.github.com/repos/skirpichev/sympy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/skirpichev/sympy/labels{/name}","releases_url":"https://api.github.com/repos/skirpichev/sympy/releases{/id}","created_at":"2013-02-08T06:15:32Z","updated_at":"2014-06-25T11:35:25Z","pushed_at":"2014-07-17T08:29:01Z","git_url":"git://github.com/skirpichev/sympy.git","ssh_url":"git@github.com:skirpichev/sympy.git","clone_url":"https://github.com/skirpichev/sympy.git","svn_url":"https://github.com/skirpichev/sympy","homepage":"http://sympy.org/","size":138839,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sympy:master","ref":"master","sha":"064369bf06b724320d544d24ee92ed2a46900e03","user":{"login":"sympy","id":260832,"avatar_url":"https://avatars.githubusercontent.com/u/260832?","gravatar_id":"cbddfebe00a15f38108875eaafa827de","url":"https://api.github.com/users/sympy","html_url":"https://github.com/sympy","followers_url":"https://api.github.com/users/sympy/followers","following_url":"https://api.github.com/users/sympy/following{/other_user}","gists_url":"https://api.github.com/users/sympy/gists{/gist_id}","starred_url":"https://api.github.com/users/sympy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sympy/subscriptions","organizations_url":"https://api.github.com/users/sympy/orgs","repos_url":"https://api.github.com/users/sympy/repos","events_url":"https://api.github.com/users/sympy/events{/privacy}","received_events_url":"https://api.github.com/users/sympy/received_events","type":"Organization","site_admin":false},"repo":{"id":640534,"name":"sympy","full_name":"sympy/sympy","owner":{"login":"sympy","id":260832,"avatar_url":"https://avatars.githubusercontent.com/u/260832?","gravatar_id":"cbddfebe00a15f38108875eaafa827de","url":"https://api.github.com/users/sympy","html_url":"https://github.com/sympy","followers_url":"https://api.github.com/users/sympy/followers","following_url":"https://api.github.com/users/sympy/following{/other_user}","gists_url":"https://api.github.com/users/sympy/gists{/gist_id}","starred_url":"https://api.github.com/users/sympy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sympy/subscriptions","organizations_url":"https://api.github.com/users/sympy/orgs","repos_url":"https://api.github.com/users/sympy/repos","events_url":"https://api.github.com/users/sympy/events{/privacy}","received_events_url":"https://api.github.com/users/sympy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sympy/sympy","description":"A computer algebra system written in pure Python","fork":false,"url":"https://api.github.com/repos/sympy/sympy","forks_url":"https://api.github.com/repos/sympy/sympy/forks","keys_url":"https://api.github.com/repos/sympy/sympy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sympy/sympy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sympy/sympy/teams","hooks_url":"https://api.github.com/repos/sympy/sympy/hooks","issue_events_url":"https://api.github.com/repos/sympy/sympy/issues/events{/number}","events_url":"https://api.github.com/repos/sympy/sympy/events","assignees_url":"https://api.github.com/repos/sympy/sympy/assignees{/user}","branches_url":"https://api.github.com/repos/sympy/sympy/branches{/branch}","tags_url":"https://api.github.com/repos/sympy/sympy/tags","blobs_url":"https://api.github.com/repos/sympy/sympy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sympy/sympy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sympy/sympy/git/refs{/sha}","trees_url":"https://api.github.com/repos/sympy/sympy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sympy/sympy/statuses/{sha}","languages_url":"https://api.github.com/repos/sympy/sympy/languages","stargazers_url":"https://api.github.com/repos/sympy/sympy/stargazers","contributors_url":"https://api.github.com/repos/sympy/sympy/contributors","subscribers_url":"https://api.github.com/repos/sympy/sympy/subscribers","subscription_url":"https://api.github.com/repos/sympy/sympy/subscription","commits_url":"https://api.github.com/repos/sympy/sympy/commits{/sha}","git_commits_url":"https://api.github.com/repos/sympy/sympy/git/commits{/sha}","comments_url":"https://api.github.com/repos/sympy/sympy/comments{/number}","issue_comment_url":"https://api.github.com/repos/sympy/sympy/issues/comments/{number}","contents_url":"https://api.github.com/repos/sympy/sympy/contents/{+path}","compare_url":"https://api.github.com/repos/sympy/sympy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sympy/sympy/merges","archive_url":"https://api.github.com/repos/sympy/sympy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sympy/sympy/downloads","issues_url":"https://api.github.com/repos/sympy/sympy/issues{/number}","pulls_url":"https://api.github.com/repos/sympy/sympy/pulls{/number}","milestones_url":"https://api.github.com/repos/sympy/sympy/milestones{/number}","notifications_url":"https://api.github.com/repos/sympy/sympy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sympy/sympy/labels{/name}","releases_url":"https://api.github.com/repos/sympy/sympy/releases{/id}","created_at":"2010-04-30T20:37:14Z","updated_at":"2014-07-17T22:54:00Z","pushed_at":"2014-07-17T02:41:09Z","git_url":"git://github.com/sympy/sympy.git","ssh_url":"git@github.com:sympy/sympy.git","clone_url":"https://github.com/sympy/sympy.git","svn_url":"https://github.com/sympy/sympy","homepage":"http://sympy.org/","size":210024,"stargazers_count":1179,"watchers_count":1179,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":674,"mirror_url":null,"open_issues_count":1498,"forks":674,"open_issues":1498,"watchers":1179,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sympy/sympy/pulls/7500"},"html":{"href":"https://github.com/sympy/sympy/pull/7500"},"issue":{"href":"https://api.github.com/repos/sympy/sympy/issues/7500"},"comments":{"href":"https://api.github.com/repos/sympy/sympy/issues/7500/comments"},"review_comments":{"href":"https://api.github.com/repos/sympy/sympy/pulls/7500/comments"},"review_comment":{"href":"https://api.github.com/repos/sympy/sympy/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/sympy/sympy/pulls/7500/commits"},"statuses":{"href":"https://api.github.com/repos/sympy/sympy/statuses/2956d049323ba14c67159fa0ca06381aabad1b4c"}}}}