GitHub PullRequestReviewCommentEvent at 2014-07-14 21:56:14
Repository: rust
Actor: alexcrichton
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/comments/14906944","id":14906944,"diff_hunk":"@@ -0,0 +1,64 @@\n+// Copyright 2013 The Rust Project Developers. See the COPYRIGHT\n+// file at the top-level directory of this distribution and at\n+// http://rust-lang.org/COPYRIGHT.\n+//\n+// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or\n+// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license\n+// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your\n+// option. This file may not be copied, modified, or distributed\n+// except according to those terms.\n+\n+// WARNING: THIS IS A GENERATED FILE, DO NOT MODIFY\n+//          take a look at src/etc/mklldeps.py if you're interested\n+\n+#[cfg(target_arch = \"x86_64\", target_os = \"linux\")]\n+#[link(name = \"LLVMInstrumentation\", kind = \"static\")]\n+#[link(name = \"LLVMInterpreter\", kind = \"static\")]\n+#[link(name = \"LLVMMCJIT\", kind = \"static\")]\n+#[link(name = \"LLVMRuntimeDyld\", kind = \"static\")]\n+#[link(name = \"LLVMJIT\", kind = \"static\")]\n+#[link(name = \"LLVMExecutionEngine\", kind = \"static\")]\n+#[link(name = \"LLVMAsmParser\", kind = \"static\")]\n+#[link(name = \"LLVMLinker\", kind = \"static\")]\n+#[link(name = \"LLVMBitWriter\", kind = \"static\")]\n+#[link(name = \"LLVMipo\", kind = \"static\")]\n+#[link(name = \"LLVMVectorize\", kind = \"static\")]\n+#[link(name = \"LLVMMipsDisassembler\", kind = \"static\")]\n+#[link(name = \"LLVMMipsCodeGen\", kind = \"static\")]\n+#[link(name = \"LLVMMipsAsmParser\", kind = \"static\")]\n+#[link(name = \"LLVMMipsDesc\", kind = \"static\")]\n+#[link(name = \"LLVMMipsInfo\", kind = \"static\")]\n+#[link(name = \"LLVMMipsAsmPrinter\", kind = \"static\")]\n+#[link(name = \"LLVMARMDisassembler\", kind = \"static\")]\n+#[link(name = \"LLVMARMCodeGen\", kind = \"static\")]\n+#[link(name = \"LLVMARMAsmParser\", kind = \"static\")]\n+#[link(name = \"LLVMARMDesc\", kind = \"static\")]\n+#[link(name = \"LLVMARMInfo\", kind = \"static\")]\n+#[link(name = \"LLVMARMAsmPrinter\", kind = \"static\")]\n+#[link(name = \"LLVMX86Disassembler\", kind = \"static\")]\n+#[link(name = \"LLVMX86AsmParser\", kind = \"static\")]\n+#[link(name = \"LLVMX86CodeGen\", kind = \"static\")]\n+#[link(name = \"LLVMSelectionDAG\", kind = \"static\")]\n+#[link(name = \"LLVMAsmPrinter\", kind = \"static\")]\n+#[link(name = \"LLVMMCParser\", kind = \"static\")]\n+#[link(name = \"LLVMCodeGen\", kind = \"static\")]\n+#[link(name = \"LLVMScalarOpts\", kind = \"static\")]\n+#[link(name = \"LLVMInstCombine\", kind = \"static\")]\n+#[link(name = \"LLVMTransformUtils\", kind = \"static\")]\n+#[link(name = \"LLVMipa\", kind = \"static\")]\n+#[link(name = \"LLVMAnalysis\", kind = \"static\")]\n+#[link(name = \"LLVMTarget\", kind = \"static\")]\n+#[link(name = \"LLVMX86Desc\", kind = \"static\")]\n+#[link(name = \"LLVMX86Info\", kind = \"static\")]\n+#[link(name = \"LLVMX86AsmPrinter\", kind = \"static\")]\n+#[link(name = \"LLVMMC\", kind = \"static\")]\n+#[link(name = \"LLVMObject\", kind = \"static\")]\n+#[link(name = \"LLVMBitReader\", kind = \"static\")]\n+#[link(name = \"LLVMCore\", kind = \"static\")]\n+#[link(name = \"LLVMX86Utils\", kind = \"static\")]\n+#[link(name = \"LLVMSupport\", kind = \"static\")]\n+#[link(name = \"pthread\")]\n+#[link(name = \"dl\")]\n+#[link(name = \"m\")]\n+#[link(name = \"stdc++\")]\n+extern {}","path":"src/librustc_llvm/llvmdeps.rs","position":64,"original_position":64,"commit_id":"2117b2a2193a70a5612e97acc34685f792d4d538","original_commit_id":"2117b2a2193a70a5612e97acc34685f792d4d538","user":{"login":"alexcrichton","id":64996,"avatar_url":"https://avatars.githubusercontent.com/u/64996?","gravatar_id":"477e2098d9864b482d28e5ef8e657f43","url":"https://api.github.com/users/alexcrichton","html_url":"https://github.com/alexcrichton","followers_url":"https://api.github.com/users/alexcrichton/followers","following_url":"https://api.github.com/users/alexcrichton/following{/other_user}","gists_url":"https://api.github.com/users/alexcrichton/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcrichton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcrichton/subscriptions","organizations_url":"https://api.github.com/users/alexcrichton/orgs","repos_url":"https://api.github.com/users/alexcrichton/repos","events_url":"https://api.github.com/users/alexcrichton/events{/privacy}","received_events_url":"https://api.github.com/users/alexcrichton/received_events","type":"User","site_admin":false},"body":"This seems to have snuck in by accident.","created_at":"2014-07-14T21:56:14Z","updated_at":"2014-07-14T21:56:14Z","html_url":"https://github.com/rust-lang/rust/pull/15611#discussion_r14906944","pull_request_url":"https://api.github.com/repos/rust-lang/rust/pulls/15611","_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments/14906944"},"html":{"href":"https://github.com/rust-lang/rust/pull/15611#discussion_r14906944"},"pull_request":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/15611"}}},"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/15611","id":18294576,"html_url":"https://github.com/rust-lang/rust/pull/15611","diff_url":"https://github.com/rust-lang/rust/pull/15611.diff","patch_url":"https://github.com/rust-lang/rust/pull/15611.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/15611","number":15611,"state":"open","title":"Rename `push/pop_back` to `push`/`pop`, add to `MutableSeq`","user":{"login":"brson","id":147214,"avatar_url":"https://avatars.githubusercontent.com/u/147214?","gravatar_id":"d0ce8e171d43e20591074a66e9ff7ae6","url":"https://api.github.com/users/brson","html_url":"https://github.com/brson","followers_url":"https://api.github.com/users/brson/followers","following_url":"https://api.github.com/users/brson/following{/other_user}","gists_url":"https://api.github.com/users/brson/gists{/gist_id}","starred_url":"https://api.github.com/users/brson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brson/subscriptions","organizations_url":"https://api.github.com/users/brson/orgs","repos_url":"https://api.github.com/users/brson/repos","events_url":"https://api.github.com/users/brson/events{/privacy}","received_events_url":"https://api.github.com/users/brson/received_events","type":"User","site_admin":false},"body":"This fixes naming conventions for `push`/`pop` from either end of a structure by partially implementing @erickt's suggestion from https://github.com/rust-lang/rust/issues/10852#issuecomment-30823343, namely:\r\n\r\n* push/pop from the 'back' are called `push` and `pop`.\r\n* push/pop from the 'front' are called `push_front` and `pop_front`.\r\n* `push`/`pop` are declared on the `MutableSeq` trait.\r\n* Implement `MutableSeq` for `Vec`, `DList`, and `RingBuf`.\r\n* Add `MutableSeq` to the prelude.\r\n\r\nI did not make any further refactorings because there is some more extensive thought that needs to be put into the collections traits. This is an easy first step that should close https://github.com/rust-lang/rust/issues/10852.\r\n\r\nI left the `push_back` and `pop_back` methods on `DList` and `RingBuf` deprecated. Because `MutableSeq` is in the prelude it shouldn't break many, but it is a breaking change.","created_at":"2014-07-11T18:41:35Z","updated_at":"2014-07-14T21:56:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6be8b842a02b601aca2cf58776044c0c744cf9a2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/15611/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/15611/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments/{number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/15611/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/2117b2a2193a70a5612e97acc34685f792d4d538","head":{"label":"brson:pushpop","ref":"pushpop","sha":"2117b2a2193a70a5612e97acc34685f792d4d538","user":{"login":"brson","id":147214,"avatar_url":"https://avatars.githubusercontent.com/u/147214?","gravatar_id":"d0ce8e171d43e20591074a66e9ff7ae6","url":"https://api.github.com/users/brson","html_url":"https://github.com/brson","followers_url":"https://api.github.com/users/brson/followers","following_url":"https://api.github.com/users/brson/following{/other_user}","gists_url":"https://api.github.com/users/brson/gists{/gist_id}","starred_url":"https://api.github.com/users/brson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brson/subscriptions","organizations_url":"https://api.github.com/users/brson/orgs","repos_url":"https://api.github.com/users/brson/repos","events_url":"https://api.github.com/users/brson/events{/privacy}","received_events_url":"https://api.github.com/users/brson/received_events","type":"User","site_admin":false},"repo":{"id":779820,"name":"rust","full_name":"brson/rust","owner":{"login":"brson","id":147214,"avatar_url":"https://avatars.githubusercontent.com/u/147214?","gravatar_id":"d0ce8e171d43e20591074a66e9ff7ae6","url":"https://api.github.com/users/brson","html_url":"https://github.com/brson","followers_url":"https://api.github.com/users/brson/followers","following_url":"https://api.github.com/users/brson/following{/other_user}","gists_url":"https://api.github.com/users/brson/gists{/gist_id}","starred_url":"https://api.github.com/users/brson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brson/subscriptions","organizations_url":"https://api.github.com/users/brson/orgs","repos_url":"https://api.github.com/users/brson/repos","events_url":"https://api.github.com/users/brson/events{/privacy}","received_events_url":"https://api.github.com/users/brson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brson/rust","description":"pursuing the trifecta","fork":true,"url":"https://api.github.com/repos/brson/rust","forks_url":"https://api.github.com/repos/brson/rust/forks","keys_url":"https://api.github.com/repos/brson/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brson/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brson/rust/teams","hooks_url":"https://api.github.com/repos/brson/rust/hooks","issue_events_url":"https://api.github.com/repos/brson/rust/issues/events{/number}","events_url":"https://api.github.com/repos/brson/rust/events","assignees_url":"https://api.github.com/repos/brson/rust/assignees{/user}","branches_url":"https://api.github.com/repos/brson/rust/branches{/branch}","tags_url":"https://api.github.com/repos/brson/rust/tags","blobs_url":"https://api.github.com/repos/brson/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brson/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brson/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/brson/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brson/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/brson/rust/languages","stargazers_url":"https://api.github.com/repos/brson/rust/stargazers","contributors_url":"https://api.github.com/repos/brson/rust/contributors","subscribers_url":"https://api.github.com/repos/brson/rust/subscribers","subscription_url":"https://api.github.com/repos/brson/rust/subscription","commits_url":"https://api.github.com/repos/brson/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/brson/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/brson/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/brson/rust/issues/comments/{number}","contents_url":"https://api.github.com/repos/brson/rust/contents/{+path}","compare_url":"https://api.github.com/repos/brson/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brson/rust/merges","archive_url":"https://api.github.com/repos/brson/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brson/rust/downloads","issues_url":"https://api.github.com/repos/brson/rust/issues{/number}","pulls_url":"https://api.github.com/repos/brson/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/brson/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/brson/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brson/rust/labels{/name}","releases_url":"https://api.github.com/repos/brson/rust/releases{/id}","created_at":"2010-07-16T23:45:53Z","updated_at":"2014-06-25T03:42:03Z","pushed_at":"2014-07-14T21:52:00Z","git_url":"git://github.com/brson/rust.git","ssh_url":"git@github.com:brson/rust.git","clone_url":"https://github.com/brson/rust.git","svn_url":"https://github.com/brson/rust","homepage":"http://www.rust-lang.org","size":194406,"stargazers_count":3,"watchers_count":3,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":3,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"e62479133b9b81ae5c32720fa18bd589a9f425e8","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?","gravatar_id":"a4268b59e433144466a0f67cbcfd8cdc","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"name":"rust","full_name":"rust-lang/rust","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?","gravatar_id":"a4268b59e433144466a0f67cbcfd8cdc","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust","description":"a safe, concurrent, practical language","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments/{number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","created_at":"2010-06-16T20:39:03Z","updated_at":"2014-07-14T21:47:47Z","pushed_at":"2014-07-14T21:21:27Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"http://www.rust-lang.org","size":401138,"stargazers_count":5733,"watchers_count":5733,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":1161,"mirror_url":null,"open_issues_count":1694,"forks":1161,"open_issues":1694,"watchers":5733,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/15611"},"html":{"href":"https://github.com/rust-lang/rust/pull/15611"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/15611"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/15611/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/15611/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/15611/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/2117b2a2193a70a5612e97acc34685f792d4d538"}}}}