GitHub PullRequestReviewCommentEvent at 2014-08-11 21:47:02
Repository: knife-azure
Actor: adamedx
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/opscode/knife-azure/pulls/comments/16082829","id":16082829,"diff_hunk":"@@ -190,6 +190,16 @@ def load_winrm_deps\n         :long => \"--azure-subnet-name SUBNET_NAME\",\n         :description => \"Optional. Specifies the subnet of virtual machine\"\n \n+      option :azure_vm_startup_timeout,\n+        :long => \"--azure_startup_timeout TIMEOUT\",\n+        :description => \"The number of minutes that knife-azure will wait for the virtual machine to reach the 'provisioning' state. Default is 10.\",\n+        :default => 10\n+\n+      option :azure_vm_ready_timeout,\n+        :long => \"--azure_vm_ready TIMEOUT\",","path":"lib/chef/knife/azure_server_create.rb","position":10,"original_position":10,"commit_id":"b857d4f0fe000149e45db36447e7c977967c7c9a","original_commit_id":"b857d4f0fe000149e45db36447e7c977967c7c9a","user":{"login":"adamedx","id":2422125,"avatar_url":"https://avatars.githubusercontent.com/u/2422125?v=2","gravatar_id":"1480c8ef029da92a0129efa8c5b2d036","url":"https://api.github.com/users/adamedx","html_url":"https://github.com/adamedx","followers_url":"https://api.github.com/users/adamedx/followers","following_url":"https://api.github.com/users/adamedx/following{/other_user}","gists_url":"https://api.github.com/users/adamedx/gists{/gist_id}","starred_url":"https://api.github.com/users/adamedx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamedx/subscriptions","organizations_url":"https://api.github.com/users/adamedx/orgs","repos_url":"https://api.github.com/users/adamedx/repos","events_url":"https://api.github.com/users/adamedx/events{/privacy}","received_events_url":"https://api.github.com/users/adamedx/received_events","type":"User","site_admin":false},"body":"Should keep this in sync with the option name, and remove underscores.","created_at":"2014-08-11T21:47:02Z","updated_at":"2014-08-11T21:47:02Z","html_url":"https://github.com/opscode/knife-azure/pull/146#discussion_r16082829","pull_request_url":"https://api.github.com/repos/opscode/knife-azure/pulls/146","_links":{"self":{"href":"https://api.github.com/repos/opscode/knife-azure/pulls/comments/16082829"},"html":{"href":"https://github.com/opscode/knife-azure/pull/146#discussion_r16082829"},"pull_request":{"href":"https://api.github.com/repos/opscode/knife-azure/pulls/146"}}},"pull_request":{"url":"https://api.github.com/repos/opscode/knife-azure/pulls/146","id":15583300,"html_url":"https://github.com/opscode/knife-azure/pull/146","diff_url":"https://github.com/opscode/knife-azure/pull/146.diff","patch_url":"https://github.com/opscode/knife-azure/pull/146.patch","issue_url":"https://api.github.com/repos/opscode/knife-azure/issues/146","number":146,"state":"open","title":"KNIFE-481 - Virtual machine state 'provisioning' not reached after 5 minutes.","user":{"login":"elmundio87","id":642372,"avatar_url":"https://avatars.githubusercontent.com/u/642372?v=2","gravatar_id":"baebfd1380edb391f8d05e2984ff8deb","url":"https://api.github.com/users/elmundio87","html_url":"https://github.com/elmundio87","followers_url":"https://api.github.com/users/elmundio87/followers","following_url":"https://api.github.com/users/elmundio87/following{/other_user}","gists_url":"https://api.github.com/users/elmundio87/gists{/gist_id}","starred_url":"https://api.github.com/users/elmundio87/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elmundio87/subscriptions","organizations_url":"https://api.github.com/users/elmundio87/orgs","repos_url":"https://api.github.com/users/elmundio87/repos","events_url":"https://api.github.com/users/elmundio87/events{/privacy}","received_events_url":"https://api.github.com/users/elmundio87/received_events","type":"User","site_admin":false},"body":"Added a new parameter to configure the previously hardcoded timeout in wait_for_virtual_machine_state\r\n\r\nDetails: https://tickets.opscode.com/browse/KNIFE-481","created_at":"2014-05-07T08:30:43Z","updated_at":"2014-08-11T21:47:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8f2a104029180a423d967496c649d38c23969f17","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/opscode/knife-azure/pulls/146/commits","review_comments_url":"https://api.github.com/repos/opscode/knife-azure/pulls/146/comments","review_comment_url":"https://api.github.com/repos/opscode/knife-azure/pulls/comments/{number}","comments_url":"https://api.github.com/repos/opscode/knife-azure/issues/146/comments","statuses_url":"https://api.github.com/repos/opscode/knife-azure/statuses/b857d4f0fe000149e45db36447e7c977967c7c9a","head":{"label":"elmundio87:azure_vm_startup_timeout","ref":"azure_vm_startup_timeout","sha":"b857d4f0fe000149e45db36447e7c977967c7c9a","user":{"login":"elmundio87","id":642372,"avatar_url":"https://avatars.githubusercontent.com/u/642372?v=2","gravatar_id":"baebfd1380edb391f8d05e2984ff8deb","url":"https://api.github.com/users/elmundio87","html_url":"https://github.com/elmundio87","followers_url":"https://api.github.com/users/elmundio87/followers","following_url":"https://api.github.com/users/elmundio87/following{/other_user}","gists_url":"https://api.github.com/users/elmundio87/gists{/gist_id}","starred_url":"https://api.github.com/users/elmundio87/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elmundio87/subscriptions","organizations_url":"https://api.github.com/users/elmundio87/orgs","repos_url":"https://api.github.com/users/elmundio87/repos","events_url":"https://api.github.com/users/elmundio87/events{/privacy}","received_events_url":"https://api.github.com/users/elmundio87/received_events","type":"User","site_admin":false},"repo":{"id":19497552,"name":"knife-azure","full_name":"elmundio87/knife-azure","owner":{"login":"elmundio87","id":642372,"avatar_url":"https://avatars.githubusercontent.com/u/642372?v=2","gravatar_id":"baebfd1380edb391f8d05e2984ff8deb","url":"https://api.github.com/users/elmundio87","html_url":"https://github.com/elmundio87","followers_url":"https://api.github.com/users/elmundio87/followers","following_url":"https://api.github.com/users/elmundio87/following{/other_user}","gists_url":"https://api.github.com/users/elmundio87/gists{/gist_id}","starred_url":"https://api.github.com/users/elmundio87/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elmundio87/subscriptions","organizations_url":"https://api.github.com/users/elmundio87/orgs","repos_url":"https://api.github.com/users/elmundio87/repos","events_url":"https://api.github.com/users/elmundio87/events{/privacy}","received_events_url":"https://api.github.com/users/elmundio87/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/elmundio87/knife-azure","description":"knife-azure plugin source.","fork":true,"url":"https://api.github.com/repos/elmundio87/knife-azure","forks_url":"https://api.github.com/repos/elmundio87/knife-azure/forks","keys_url":"https://api.github.com/repos/elmundio87/knife-azure/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elmundio87/knife-azure/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elmundio87/knife-azure/teams","hooks_url":"https://api.github.com/repos/elmundio87/knife-azure/hooks","issue_events_url":"https://api.github.com/repos/elmundio87/knife-azure/issues/events{/number}","events_url":"https://api.github.com/repos/elmundio87/knife-azure/events","assignees_url":"https://api.github.com/repos/elmundio87/knife-azure/assignees{/user}","branches_url":"https://api.github.com/repos/elmundio87/knife-azure/branches{/branch}","tags_url":"https://api.github.com/repos/elmundio87/knife-azure/tags","blobs_url":"https://api.github.com/repos/elmundio87/knife-azure/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elmundio87/knife-azure/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elmundio87/knife-azure/git/refs{/sha}","trees_url":"https://api.github.com/repos/elmundio87/knife-azure/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elmundio87/knife-azure/statuses/{sha}","languages_url":"https://api.github.com/repos/elmundio87/knife-azure/languages","stargazers_url":"https://api.github.com/repos/elmundio87/knife-azure/stargazers","contributors_url":"https://api.github.com/repos/elmundio87/knife-azure/contributors","subscribers_url":"https://api.github.com/repos/elmundio87/knife-azure/subscribers","subscription_url":"https://api.github.com/repos/elmundio87/knife-azure/subscription","commits_url":"https://api.github.com/repos/elmundio87/knife-azure/commits{/sha}","git_commits_url":"https://api.github.com/repos/elmundio87/knife-azure/git/commits{/sha}","comments_url":"https://api.github.com/repos/elmundio87/knife-azure/comments{/number}","issue_comment_url":"https://api.github.com/repos/elmundio87/knife-azure/issues/comments/{number}","contents_url":"https://api.github.com/repos/elmundio87/knife-azure/contents/{+path}","compare_url":"https://api.github.com/repos/elmundio87/knife-azure/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elmundio87/knife-azure/merges","archive_url":"https://api.github.com/repos/elmundio87/knife-azure/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elmundio87/knife-azure/downloads","issues_url":"https://api.github.com/repos/elmundio87/knife-azure/issues{/number}","pulls_url":"https://api.github.com/repos/elmundio87/knife-azure/pulls{/number}","milestones_url":"https://api.github.com/repos/elmundio87/knife-azure/milestones{/number}","notifications_url":"https://api.github.com/repos/elmundio87/knife-azure/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elmundio87/knife-azure/labels{/name}","releases_url":"https://api.github.com/repos/elmundio87/knife-azure/releases{/id}","created_at":"2014-05-06T14:33:53Z","updated_at":"2014-05-08T09:59:03Z","pushed_at":"2014-05-08T09:59:04Z","git_url":"git://github.com/elmundio87/knife-azure.git","ssh_url":"git@github.com:elmundio87/knife-azure.git","clone_url":"https://github.com/elmundio87/knife-azure.git","svn_url":"https://github.com/elmundio87/knife-azure","homepage":null,"size":821,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"opscode:master","ref":"master","sha":"72c3c016b8dc615c8ec76cb6d645547a6b20269f","user":{"login":"opscode","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?v=2","gravatar_id":"890bf76f4dc18c12a19c55e988a1bd5e","url":"https://api.github.com/users/opscode","html_url":"https://github.com/opscode","followers_url":"https://api.github.com/users/opscode/followers","following_url":"https://api.github.com/users/opscode/following{/other_user}","gists_url":"https://api.github.com/users/opscode/gists{/gist_id}","starred_url":"https://api.github.com/users/opscode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opscode/subscriptions","organizations_url":"https://api.github.com/users/opscode/orgs","repos_url":"https://api.github.com/users/opscode/repos","events_url":"https://api.github.com/users/opscode/events{/privacy}","received_events_url":"https://api.github.com/users/opscode/received_events","type":"Organization","site_admin":false},"repo":{"id":4576133,"name":"knife-azure","full_name":"opscode/knife-azure","owner":{"login":"opscode","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?v=2","gravatar_id":"890bf76f4dc18c12a19c55e988a1bd5e","url":"https://api.github.com/users/opscode","html_url":"https://github.com/opscode","followers_url":"https://api.github.com/users/opscode/followers","following_url":"https://api.github.com/users/opscode/following{/other_user}","gists_url":"https://api.github.com/users/opscode/gists{/gist_id}","starred_url":"https://api.github.com/users/opscode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opscode/subscriptions","organizations_url":"https://api.github.com/users/opscode/orgs","repos_url":"https://api.github.com/users/opscode/repos","events_url":"https://api.github.com/users/opscode/events{/privacy}","received_events_url":"https://api.github.com/users/opscode/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opscode/knife-azure","description":"knife-azure plugin source.","fork":false,"url":"https://api.github.com/repos/opscode/knife-azure","forks_url":"https://api.github.com/repos/opscode/knife-azure/forks","keys_url":"https://api.github.com/repos/opscode/knife-azure/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opscode/knife-azure/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opscode/knife-azure/teams","hooks_url":"https://api.github.com/repos/opscode/knife-azure/hooks","issue_events_url":"https://api.github.com/repos/opscode/knife-azure/issues/events{/number}","events_url":"https://api.github.com/repos/opscode/knife-azure/events","assignees_url":"https://api.github.com/repos/opscode/knife-azure/assignees{/user}","branches_url":"https://api.github.com/repos/opscode/knife-azure/branches{/branch}","tags_url":"https://api.github.com/repos/opscode/knife-azure/tags","blobs_url":"https://api.github.com/repos/opscode/knife-azure/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opscode/knife-azure/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opscode/knife-azure/git/refs{/sha}","trees_url":"https://api.github.com/repos/opscode/knife-azure/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opscode/knife-azure/statuses/{sha}","languages_url":"https://api.github.com/repos/opscode/knife-azure/languages","stargazers_url":"https://api.github.com/repos/opscode/knife-azure/stargazers","contributors_url":"https://api.github.com/repos/opscode/knife-azure/contributors","subscribers_url":"https://api.github.com/repos/opscode/knife-azure/subscribers","subscription_url":"https://api.github.com/repos/opscode/knife-azure/subscription","commits_url":"https://api.github.com/repos/opscode/knife-azure/commits{/sha}","git_commits_url":"https://api.github.com/repos/opscode/knife-azure/git/commits{/sha}","comments_url":"https://api.github.com/repos/opscode/knife-azure/comments{/number}","issue_comment_url":"https://api.github.com/repos/opscode/knife-azure/issues/comments/{number}","contents_url":"https://api.github.com/repos/opscode/knife-azure/contents/{+path}","compare_url":"https://api.github.com/repos/opscode/knife-azure/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opscode/knife-azure/merges","archive_url":"https://api.github.com/repos/opscode/knife-azure/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opscode/knife-azure/downloads","issues_url":"https://api.github.com/repos/opscode/knife-azure/issues{/number}","pulls_url":"https://api.github.com/repos/opscode/knife-azure/pulls{/number}","milestones_url":"https://api.github.com/repos/opscode/knife-azure/milestones{/number}","notifications_url":"https://api.github.com/repos/opscode/knife-azure/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opscode/knife-azure/labels{/name}","releases_url":"https://api.github.com/repos/opscode/knife-azure/releases{/id}","created_at":"2012-06-06T18:10:30Z","updated_at":"2014-08-09T18:00:06Z","pushed_at":"2014-08-06T16:37:21Z","git_url":"git://github.com/opscode/knife-azure.git","ssh_url":"git@github.com:opscode/knife-azure.git","clone_url":"https://github.com/opscode/knife-azure.git","svn_url":"https://github.com/opscode/knife-azure","homepage":null,"size":3124,"stargazers_count":44,"watchers_count":44,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":39,"mirror_url":null,"open_issues_count":15,"forks":39,"open_issues":15,"watchers":44,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opscode/knife-azure/pulls/146"},"html":{"href":"https://github.com/opscode/knife-azure/pull/146"},"issue":{"href":"https://api.github.com/repos/opscode/knife-azure/issues/146"},"comments":{"href":"https://api.github.com/repos/opscode/knife-azure/issues/146/comments"},"review_comments":{"href":"https://api.github.com/repos/opscode/knife-azure/pulls/146/comments"},"review_comment":{"href":"https://api.github.com/repos/opscode/knife-azure/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/opscode/knife-azure/pulls/146/commits"},"statuses":{"href":"https://api.github.com/repos/opscode/knife-azure/statuses/b857d4f0fe000149e45db36447e7c977967c7c9a"}}}}