GitHub PullRequestEvent at 2014-08-30 23:03:22
Repository: kpatch
Actor: cormander
Payload: {"action":"opened","number":384,"pull_request":{"url":"https://api.github.com/repos/dynup/kpatch/pulls/384","id":20540199,"html_url":"https://github.com/dynup/kpatch/pull/384","diff_url":"https://github.com/dynup/kpatch/pull/384.diff","patch_url":"https://github.com/dynup/kpatch/pull/384.patch","issue_url":"https://api.github.com/repos/dynup/kpatch/issues/384","number":384,"state":"open","locked":false,"title":"Make sure each symbol address doesn't start with a jump instruction","user":{"login":"cormander","id":106200,"avatar_url":"https://avatars.githubusercontent.com/u/106200?v=2","gravatar_id":"14d13403d1e6abdf7f8d8a38456cf1b4","url":"https://api.github.com/users/cormander","html_url":"https://github.com/cormander","followers_url":"https://api.github.com/users/cormander/followers","following_url":"https://api.github.com/users/cormander/following{/other_user}","gists_url":"https://api.github.com/users/cormander/gists{/gist_id}","starred_url":"https://api.github.com/users/cormander/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cormander/subscriptions","organizations_url":"https://api.github.com/users/cormander/orgs","repos_url":"https://api.github.com/users/cormander/repos","events_url":"https://api.github.com/users/cormander/events{/privacy}","received_events_url":"https://api.github.com/users/cormander/received_events","type":"User","site_admin":false},"body":"This patch makes kpatch_link_object run through all the verify steps before it attempts to patch them. On failure, there is no need to call unlink (although unlink is called on the return path anyway - but I'll tackle that\r\nproblem another day) so add the err_verify jump point.\r\n\r\nWe also now check the start of the symbol address for the 0xe9 OP_JMP_REL32 instruction. This may not be the best place to do it, but it's the soonest place I could find that I could add the check without doing any major\r\nrewrites.\r\n\r\nThe purpose of this check is to make sure the functions havne't been redirected outside of the normal kernel internal redirect systems, because if they have been, we'll run into problems down the road.\r\n","created_at":"2014-08-30T23:03:22Z","updated_at":"2014-08-30T23:03:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dynup/kpatch/pulls/384/commits","review_comments_url":"https://api.github.com/repos/dynup/kpatch/pulls/384/comments","review_comment_url":"https://api.github.com/repos/dynup/kpatch/pulls/comments/{number}","comments_url":"https://api.github.com/repos/dynup/kpatch/issues/384/comments","statuses_url":"https://api.github.com/repos/dynup/kpatch/statuses/62f6d3620e91ea7bf3e9698a98245dc0b4e6a4d5","head":{"label":"cormander:master","ref":"master","sha":"62f6d3620e91ea7bf3e9698a98245dc0b4e6a4d5","user":{"login":"cormander","id":106200,"avatar_url":"https://avatars.githubusercontent.com/u/106200?v=2","gravatar_id":"14d13403d1e6abdf7f8d8a38456cf1b4","url":"https://api.github.com/users/cormander","html_url":"https://github.com/cormander","followers_url":"https://api.github.com/users/cormander/followers","following_url":"https://api.github.com/users/cormander/following{/other_user}","gists_url":"https://api.github.com/users/cormander/gists{/gist_id}","starred_url":"https://api.github.com/users/cormander/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cormander/subscriptions","organizations_url":"https://api.github.com/users/cormander/orgs","repos_url":"https://api.github.com/users/cormander/repos","events_url":"https://api.github.com/users/cormander/events{/privacy}","received_events_url":"https://api.github.com/users/cormander/received_events","type":"User","site_admin":false},"repo":{"id":23502240,"name":"kpatch","full_name":"cormander/kpatch","owner":{"login":"cormander","id":106200,"avatar_url":"https://avatars.githubusercontent.com/u/106200?v=2","gravatar_id":"14d13403d1e6abdf7f8d8a38456cf1b4","url":"https://api.github.com/users/cormander","html_url":"https://github.com/cormander","followers_url":"https://api.github.com/users/cormander/followers","following_url":"https://api.github.com/users/cormander/following{/other_user}","gists_url":"https://api.github.com/users/cormander/gists{/gist_id}","starred_url":"https://api.github.com/users/cormander/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cormander/subscriptions","organizations_url":"https://api.github.com/users/cormander/orgs","repos_url":"https://api.github.com/users/cormander/repos","events_url":"https://api.github.com/users/cormander/events{/privacy}","received_events_url":"https://api.github.com/users/cormander/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cormander/kpatch","description":"kpatch - dynamic kernel patching","fork":true,"url":"https://api.github.com/repos/cormander/kpatch","forks_url":"https://api.github.com/repos/cormander/kpatch/forks","keys_url":"https://api.github.com/repos/cormander/kpatch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cormander/kpatch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cormander/kpatch/teams","hooks_url":"https://api.github.com/repos/cormander/kpatch/hooks","issue_events_url":"https://api.github.com/repos/cormander/kpatch/issues/events{/number}","events_url":"https://api.github.com/repos/cormander/kpatch/events","assignees_url":"https://api.github.com/repos/cormander/kpatch/assignees{/user}","branches_url":"https://api.github.com/repos/cormander/kpatch/branches{/branch}","tags_url":"https://api.github.com/repos/cormander/kpatch/tags","blobs_url":"https://api.github.com/repos/cormander/kpatch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cormander/kpatch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cormander/kpatch/git/refs{/sha}","trees_url":"https://api.github.com/repos/cormander/kpatch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cormander/kpatch/statuses/{sha}","languages_url":"https://api.github.com/repos/cormander/kpatch/languages","stargazers_url":"https://api.github.com/repos/cormander/kpatch/stargazers","contributors_url":"https://api.github.com/repos/cormander/kpatch/contributors","subscribers_url":"https://api.github.com/repos/cormander/kpatch/subscribers","subscription_url":"https://api.github.com/repos/cormander/kpatch/subscription","commits_url":"https://api.github.com/repos/cormander/kpatch/commits{/sha}","git_commits_url":"https://api.github.com/repos/cormander/kpatch/git/commits{/sha}","comments_url":"https://api.github.com/repos/cormander/kpatch/comments{/number}","issue_comment_url":"https://api.github.com/repos/cormander/kpatch/issues/comments/{number}","contents_url":"https://api.github.com/repos/cormander/kpatch/contents/{+path}","compare_url":"https://api.github.com/repos/cormander/kpatch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cormander/kpatch/merges","archive_url":"https://api.github.com/repos/cormander/kpatch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cormander/kpatch/downloads","issues_url":"https://api.github.com/repos/cormander/kpatch/issues{/number}","pulls_url":"https://api.github.com/repos/cormander/kpatch/pulls{/number}","milestones_url":"https://api.github.com/repos/cormander/kpatch/milestones{/number}","notifications_url":"https://api.github.com/repos/cormander/kpatch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cormander/kpatch/labels{/name}","releases_url":"https://api.github.com/repos/cormander/kpatch/releases{/id}","created_at":"2014-08-30T22:54:57Z","updated_at":"2014-08-30T23:00:06Z","pushed_at":"2014-08-30T23:00:06Z","git_url":"git://github.com/cormander/kpatch.git","ssh_url":"git@github.com:cormander/kpatch.git","clone_url":"https://github.com/cormander/kpatch.git","svn_url":"https://github.com/cormander/kpatch","homepage":null,"size":6176,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dynup:master","ref":"master","sha":"b369d4852ad364e176feb24f8ad2cfb12eb70e3c","user":{"login":"dynup","id":6643594,"avatar_url":"https://avatars.githubusercontent.com/u/6643594?v=2","gravatar_id":null,"url":"https://api.github.com/users/dynup","html_url":"https://github.com/dynup","followers_url":"https://api.github.com/users/dynup/followers","following_url":"https://api.github.com/users/dynup/following{/other_user}","gists_url":"https://api.github.com/users/dynup/gists{/gist_id}","starred_url":"https://api.github.com/users/dynup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dynup/subscriptions","organizations_url":"https://api.github.com/users/dynup/orgs","repos_url":"https://api.github.com/users/dynup/repos","events_url":"https://api.github.com/users/dynup/events{/privacy}","received_events_url":"https://api.github.com/users/dynup/received_events","type":"Organization","site_admin":false},"repo":{"id":16743039,"name":"kpatch","full_name":"dynup/kpatch","owner":{"login":"dynup","id":6643594,"avatar_url":"https://avatars.githubusercontent.com/u/6643594?v=2","gravatar_id":null,"url":"https://api.github.com/users/dynup","html_url":"https://github.com/dynup","followers_url":"https://api.github.com/users/dynup/followers","following_url":"https://api.github.com/users/dynup/following{/other_user}","gists_url":"https://api.github.com/users/dynup/gists{/gist_id}","starred_url":"https://api.github.com/users/dynup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dynup/subscriptions","organizations_url":"https://api.github.com/users/dynup/orgs","repos_url":"https://api.github.com/users/dynup/repos","events_url":"https://api.github.com/users/dynup/events{/privacy}","received_events_url":"https://api.github.com/users/dynup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dynup/kpatch","description":"kpatch - dynamic kernel patching","fork":false,"url":"https://api.github.com/repos/dynup/kpatch","forks_url":"https://api.github.com/repos/dynup/kpatch/forks","keys_url":"https://api.github.com/repos/dynup/kpatch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dynup/kpatch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dynup/kpatch/teams","hooks_url":"https://api.github.com/repos/dynup/kpatch/hooks","issue_events_url":"https://api.github.com/repos/dynup/kpatch/issues/events{/number}","events_url":"https://api.github.com/repos/dynup/kpatch/events","assignees_url":"https://api.github.com/repos/dynup/kpatch/assignees{/user}","branches_url":"https://api.github.com/repos/dynup/kpatch/branches{/branch}","tags_url":"https://api.github.com/repos/dynup/kpatch/tags","blobs_url":"https://api.github.com/repos/dynup/kpatch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dynup/kpatch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dynup/kpatch/git/refs{/sha}","trees_url":"https://api.github.com/repos/dynup/kpatch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dynup/kpatch/statuses/{sha}","languages_url":"https://api.github.com/repos/dynup/kpatch/languages","stargazers_url":"https://api.github.com/repos/dynup/kpatch/stargazers","contributors_url":"https://api.github.com/repos/dynup/kpatch/contributors","subscribers_url":"https://api.github.com/repos/dynup/kpatch/subscribers","subscription_url":"https://api.github.com/repos/dynup/kpatch/subscription","commits_url":"https://api.github.com/repos/dynup/kpatch/commits{/sha}","git_commits_url":"https://api.github.com/repos/dynup/kpatch/git/commits{/sha}","comments_url":"https://api.github.com/repos/dynup/kpatch/comments{/number}","issue_comment_url":"https://api.github.com/repos/dynup/kpatch/issues/comments/{number}","contents_url":"https://api.github.com/repos/dynup/kpatch/contents/{+path}","compare_url":"https://api.github.com/repos/dynup/kpatch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dynup/kpatch/merges","archive_url":"https://api.github.com/repos/dynup/kpatch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dynup/kpatch/downloads","issues_url":"https://api.github.com/repos/dynup/kpatch/issues{/number}","pulls_url":"https://api.github.com/repos/dynup/kpatch/pulls{/number}","milestones_url":"https://api.github.com/repos/dynup/kpatch/milestones{/number}","notifications_url":"https://api.github.com/repos/dynup/kpatch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dynup/kpatch/labels{/name}","releases_url":"https://api.github.com/repos/dynup/kpatch/releases{/id}","created_at":"2014-02-11T19:47:52Z","updated_at":"2014-08-29T04:42:00Z","pushed_at":"2014-08-29T21:15:03Z","git_url":"git://github.com/dynup/kpatch.git","ssh_url":"git@github.com:dynup/kpatch.git","clone_url":"https://github.com/dynup/kpatch.git","svn_url":"https://github.com/dynup/kpatch","homepage":null,"size":6176,"stargazers_count":229,"watchers_count":229,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":40,"mirror_url":null,"open_issues_count":14,"forks":40,"open_issues":14,"watchers":229,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dynup/kpatch/pulls/384"},"html":{"href":"https://github.com/dynup/kpatch/pull/384"},"issue":{"href":"https://api.github.com/repos/dynup/kpatch/issues/384"},"comments":{"href":"https://api.github.com/repos/dynup/kpatch/issues/384/comments"},"review_comments":{"href":"https://api.github.com/repos/dynup/kpatch/pulls/384/comments"},"review_comment":{"href":"https://api.github.com/repos/dynup/kpatch/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/dynup/kpatch/pulls/384/commits"},"statuses":{"href":"https://api.github.com/repos/dynup/kpatch/statuses/62f6d3620e91ea7bf3e9698a98245dc0b4e6a4d5"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":18,"deletions":6,"changed_files":1}}