GitHub PullRequestEvent at 2014-10-09 23:14:25
Repository: deis
Actor: gust1n
Payload: {"action":"opened","number":2095,"pull_request":{"url":"https://api.github.com/repos/deis/deis/pulls/2095","id":22530831,"html_url":"https://github.com/deis/deis/pull/2095","diff_url":"https://github.com/deis/deis/pull/2095.diff","patch_url":"https://github.com/deis/deis/pull/2095.patch","issue_url":"https://api.github.com/repos/deis/deis/issues/2095","number":2095,"state":"open","locked":false,"title":"feat(Publisher): Adding support for publishing multiple service ports","user":{"login":"gust1n","id":234222,"avatar_url":"https://avatars.githubusercontent.com/u/234222?v=2","gravatar_id":"","url":"https://api.github.com/users/gust1n","html_url":"https://github.com/gust1n","followers_url":"https://api.github.com/users/gust1n/followers","following_url":"https://api.github.com/users/gust1n/following{/other_user}","gists_url":"https://api.github.com/users/gust1n/gists{/gist_id}","starred_url":"https://api.github.com/users/gust1n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gust1n/subscriptions","organizations_url":"https://api.github.com/users/gust1n/orgs","repos_url":"https://api.github.com/users/gust1n/repos","events_url":"https://api.github.com/users/gust1n/events{/privacy}","received_events_url":"https://api.github.com/users/gust1n/received_events","type":"User","site_admin":false},"body":"As discussed in #2044.\r\n\r\nThis changed the behavior of the publisher into using the interal port as part of the query. Since we want to support multiple ports we somehow need to differentiate the ports but I'd rather not switch to posting JSON or something to keep the keys simple (as they are now).\r\n\r\nThis has worked great for us and actually makes sense. The query (in pseudo) for the clients will be for example \"give me port 5432 of an instance of postgres\" and the answer will be \"1.2.3.4:49123\" or whatever.\r\n\r\nI hope I made my point clear about this approach. Will follow up with another PR that cleans up the logging and also deletes etcd keys on docker events when this is merged/rejected.","created_at":"2014-10-09T23:14:24Z","updated_at":"2014-10-09T23:14:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/deis/deis/pulls/2095/commits","review_comments_url":"https://api.github.com/repos/deis/deis/pulls/2095/comments","review_comment_url":"https://api.github.com/repos/deis/deis/pulls/comments/{number}","comments_url":"https://api.github.com/repos/deis/deis/issues/2095/comments","statuses_url":"https://api.github.com/repos/deis/deis/statuses/43ff4d95947bcdf82040816197a5e6ba38a01649","head":{"label":"gust1n:master","ref":"master","sha":"43ff4d95947bcdf82040816197a5e6ba38a01649","user":{"login":"gust1n","id":234222,"avatar_url":"https://avatars.githubusercontent.com/u/234222?v=2","gravatar_id":"","url":"https://api.github.com/users/gust1n","html_url":"https://github.com/gust1n","followers_url":"https://api.github.com/users/gust1n/followers","following_url":"https://api.github.com/users/gust1n/following{/other_user}","gists_url":"https://api.github.com/users/gust1n/gists{/gist_id}","starred_url":"https://api.github.com/users/gust1n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gust1n/subscriptions","organizations_url":"https://api.github.com/users/gust1n/orgs","repos_url":"https://api.github.com/users/gust1n/repos","events_url":"https://api.github.com/users/gust1n/events{/privacy}","received_events_url":"https://api.github.com/users/gust1n/received_events","type":"User","site_admin":false},"repo":{"id":25011889,"name":"deis","full_name":"gust1n/deis","owner":{"login":"gust1n","id":234222,"avatar_url":"https://avatars.githubusercontent.com/u/234222?v=2","gravatar_id":"","url":"https://api.github.com/users/gust1n","html_url":"https://github.com/gust1n","followers_url":"https://api.github.com/users/gust1n/followers","following_url":"https://api.github.com/users/gust1n/following{/other_user}","gists_url":"https://api.github.com/users/gust1n/gists{/gist_id}","starred_url":"https://api.github.com/users/gust1n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gust1n/subscriptions","organizations_url":"https://api.github.com/users/gust1n/orgs","repos_url":"https://api.github.com/users/gust1n/repos","events_url":"https://api.github.com/users/gust1n/events{/privacy}","received_events_url":"https://api.github.com/users/gust1n/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gust1n/deis","description":"Your PaaS. Your Rules. ","fork":true,"url":"https://api.github.com/repos/gust1n/deis","forks_url":"https://api.github.com/repos/gust1n/deis/forks","keys_url":"https://api.github.com/repos/gust1n/deis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gust1n/deis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gust1n/deis/teams","hooks_url":"https://api.github.com/repos/gust1n/deis/hooks","issue_events_url":"https://api.github.com/repos/gust1n/deis/issues/events{/number}","events_url":"https://api.github.com/repos/gust1n/deis/events","assignees_url":"https://api.github.com/repos/gust1n/deis/assignees{/user}","branches_url":"https://api.github.com/repos/gust1n/deis/branches{/branch}","tags_url":"https://api.github.com/repos/gust1n/deis/tags","blobs_url":"https://api.github.com/repos/gust1n/deis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gust1n/deis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gust1n/deis/git/refs{/sha}","trees_url":"https://api.github.com/repos/gust1n/deis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gust1n/deis/statuses/{sha}","languages_url":"https://api.github.com/repos/gust1n/deis/languages","stargazers_url":"https://api.github.com/repos/gust1n/deis/stargazers","contributors_url":"https://api.github.com/repos/gust1n/deis/contributors","subscribers_url":"https://api.github.com/repos/gust1n/deis/subscribers","subscription_url":"https://api.github.com/repos/gust1n/deis/subscription","commits_url":"https://api.github.com/repos/gust1n/deis/commits{/sha}","git_commits_url":"https://api.github.com/repos/gust1n/deis/git/commits{/sha}","comments_url":"https://api.github.com/repos/gust1n/deis/comments{/number}","issue_comment_url":"https://api.github.com/repos/gust1n/deis/issues/comments/{number}","contents_url":"https://api.github.com/repos/gust1n/deis/contents/{+path}","compare_url":"https://api.github.com/repos/gust1n/deis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gust1n/deis/merges","archive_url":"https://api.github.com/repos/gust1n/deis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gust1n/deis/downloads","issues_url":"https://api.github.com/repos/gust1n/deis/issues{/number}","pulls_url":"https://api.github.com/repos/gust1n/deis/pulls{/number}","milestones_url":"https://api.github.com/repos/gust1n/deis/milestones{/number}","notifications_url":"https://api.github.com/repos/gust1n/deis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gust1n/deis/labels{/name}","releases_url":"https://api.github.com/repos/gust1n/deis/releases{/id}","created_at":"2014-10-09T22:54:15Z","updated_at":"2014-10-09T23:08:07Z","pushed_at":"2014-10-09T23:08:07Z","git_url":"git://github.com/gust1n/deis.git","ssh_url":"git@github.com:gust1n/deis.git","clone_url":"https://github.com/gust1n/deis.git","svn_url":"https://github.com/gust1n/deis","homepage":"http://deis.io","size":42748,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"deis:master","ref":"master","sha":"e9343e71698bfbf7857d661b763f83595c9e6ae8","user":{"login":"deis","id":6117407,"avatar_url":"https://avatars.githubusercontent.com/u/6117407?v=2","gravatar_id":"","url":"https://api.github.com/users/deis","html_url":"https://github.com/deis","followers_url":"https://api.github.com/users/deis/followers","following_url":"https://api.github.com/users/deis/following{/other_user}","gists_url":"https://api.github.com/users/deis/gists{/gist_id}","starred_url":"https://api.github.com/users/deis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deis/subscriptions","organizations_url":"https://api.github.com/users/deis/orgs","repos_url":"https://api.github.com/users/deis/repos","events_url":"https://api.github.com/users/deis/events{/privacy}","received_events_url":"https://api.github.com/users/deis/received_events","type":"Organization","site_admin":false},"repo":{"id":11589713,"name":"deis","full_name":"deis/deis","owner":{"login":"deis","id":6117407,"avatar_url":"https://avatars.githubusercontent.com/u/6117407?v=2","gravatar_id":"","url":"https://api.github.com/users/deis","html_url":"https://github.com/deis","followers_url":"https://api.github.com/users/deis/followers","following_url":"https://api.github.com/users/deis/following{/other_user}","gists_url":"https://api.github.com/users/deis/gists{/gist_id}","starred_url":"https://api.github.com/users/deis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deis/subscriptions","organizations_url":"https://api.github.com/users/deis/orgs","repos_url":"https://api.github.com/users/deis/repos","events_url":"https://api.github.com/users/deis/events{/privacy}","received_events_url":"https://api.github.com/users/deis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/deis/deis","description":"Your PaaS. Your Rules. ","fork":false,"url":"https://api.github.com/repos/deis/deis","forks_url":"https://api.github.com/repos/deis/deis/forks","keys_url":"https://api.github.com/repos/deis/deis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/deis/deis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/deis/deis/teams","hooks_url":"https://api.github.com/repos/deis/deis/hooks","issue_events_url":"https://api.github.com/repos/deis/deis/issues/events{/number}","events_url":"https://api.github.com/repos/deis/deis/events","assignees_url":"https://api.github.com/repos/deis/deis/assignees{/user}","branches_url":"https://api.github.com/repos/deis/deis/branches{/branch}","tags_url":"https://api.github.com/repos/deis/deis/tags","blobs_url":"https://api.github.com/repos/deis/deis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/deis/deis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/deis/deis/git/refs{/sha}","trees_url":"https://api.github.com/repos/deis/deis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/deis/deis/statuses/{sha}","languages_url":"https://api.github.com/repos/deis/deis/languages","stargazers_url":"https://api.github.com/repos/deis/deis/stargazers","contributors_url":"https://api.github.com/repos/deis/deis/contributors","subscribers_url":"https://api.github.com/repos/deis/deis/subscribers","subscription_url":"https://api.github.com/repos/deis/deis/subscription","commits_url":"https://api.github.com/repos/deis/deis/commits{/sha}","git_commits_url":"https://api.github.com/repos/deis/deis/git/commits{/sha}","comments_url":"https://api.github.com/repos/deis/deis/comments{/number}","issue_comment_url":"https://api.github.com/repos/deis/deis/issues/comments/{number}","contents_url":"https://api.github.com/repos/deis/deis/contents/{+path}","compare_url":"https://api.github.com/repos/deis/deis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/deis/deis/merges","archive_url":"https://api.github.com/repos/deis/deis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/deis/deis/downloads","issues_url":"https://api.github.com/repos/deis/deis/issues{/number}","pulls_url":"https://api.github.com/repos/deis/deis/pulls{/number}","milestones_url":"https://api.github.com/repos/deis/deis/milestones{/number}","notifications_url":"https://api.github.com/repos/deis/deis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/deis/deis/labels{/name}","releases_url":"https://api.github.com/repos/deis/deis/releases{/id}","created_at":"2013-07-22T19:02:40Z","updated_at":"2014-10-09T23:01:41Z","pushed_at":"2014-10-09T19:34:49Z","git_url":"git://github.com/deis/deis.git","ssh_url":"git@github.com:deis/deis.git","clone_url":"https://github.com/deis/deis.git","svn_url":"https://github.com/deis/deis","homepage":"http://deis.io","size":42748,"stargazers_count":2667,"watchers_count":2667,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":326,"mirror_url":null,"open_issues_count":159,"forks":326,"open_issues":159,"watchers":2667,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/deis/deis/pulls/2095"},"html":{"href":"https://github.com/deis/deis/pull/2095"},"issue":{"href":"https://api.github.com/repos/deis/deis/issues/2095"},"comments":{"href":"https://api.github.com/repos/deis/deis/issues/2095/comments"},"review_comments":{"href":"https://api.github.com/repos/deis/deis/pulls/2095/comments"},"review_comment":{"href":"https://api.github.com/repos/deis/deis/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/deis/deis/pulls/2095/commits"},"statuses":{"href":"https://api.github.com/repos/deis/deis/statuses/43ff4d95947bcdf82040816197a5e6ba38a01649"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":5,"deletions":6,"changed_files":1}}