GitHub PullRequestReviewCommentEvent at 2014-11-13 13:57:41
Repository: cms
Actor: lorenzotello
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/moneyadviceservice/cms/pulls/comments/20291451","id":20291451,"diff_hunk":"@@ -0,0 +1,21 @@\n+module Cms\n+  module Components\n+    class MenuLink\n+      include ActiveModel::Model\n+      attr_accessor :name, :path, :sublinks\n+\n+      def sublinks?","path":"lib/cms/components/menu_link.rb","position":7,"original_position":7,"commit_id":"1a5eca770a5a46adc59559fa65b2350fafe59940","original_commit_id":"1a5eca770a5a46adc59559fa65b2350fafe59940","user":{"login":"lorenzotello","id":8899941,"avatar_url":"https://avatars.githubusercontent.com/u/8899941?v=3","gravatar_id":"","url":"https://api.github.com/users/lorenzotello","html_url":"https://github.com/lorenzotello","followers_url":"https://api.github.com/users/lorenzotello/followers","following_url":"https://api.github.com/users/lorenzotello/following{/other_user}","gists_url":"https://api.github.com/users/lorenzotello/gists{/gist_id}","starred_url":"https://api.github.com/users/lorenzotello/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lorenzotello/subscriptions","organizations_url":"https://api.github.com/users/lorenzotello/orgs","repos_url":"https://api.github.com/users/lorenzotello/repos","events_url":"https://api.github.com/users/lorenzotello/events{/privacy}","received_events_url":"https://api.github.com/users/lorenzotello/received_events","type":"User","site_admin":false},"body":"Good to wrap menu options in a class!.\r\nI would call this method has_sublinks? so in the specs you can use expectations like... expect(menu_link).to have_sublinks or expect(menu_link).not_to have_sublinks\r\n","created_at":"2014-11-13T13:57:41Z","updated_at":"2014-11-13T13:57:41Z","html_url":"https://github.com/moneyadviceservice/cms/pull/78#discussion_r20291451","pull_request_url":"https://api.github.com/repos/moneyadviceservice/cms/pulls/78","_links":{"self":{"href":"https://api.github.com/repos/moneyadviceservice/cms/pulls/comments/20291451"},"html":{"href":"https://github.com/moneyadviceservice/cms/pull/78#discussion_r20291451"},"pull_request":{"href":"https://api.github.com/repos/moneyadviceservice/cms/pulls/78"}}},"pull_request":{"url":"https://api.github.com/repos/moneyadviceservice/cms/pulls/78","id":24362775,"html_url":"https://github.com/moneyadviceservice/cms/pull/78","diff_url":"https://github.com/moneyadviceservice/cms/pull/78.diff","patch_url":"https://github.com/moneyadviceservice/cms/pull/78.patch","issue_url":"https://api.github.com/repos/moneyadviceservice/cms/issues/78","number":78,"state":"open","locked":false,"title":"Global navigation","user":{"login":"tomas-stefano","id":27509,"avatar_url":"https://avatars.githubusercontent.com/u/27509?v=3","gravatar_id":"","url":"https://api.github.com/users/tomas-stefano","html_url":"https://github.com/tomas-stefano","followers_url":"https://api.github.com/users/tomas-stefano/followers","following_url":"https://api.github.com/users/tomas-stefano/following{/other_user}","gists_url":"https://api.github.com/users/tomas-stefano/gists{/gist_id}","starred_url":"https://api.github.com/users/tomas-stefano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomas-stefano/subscriptions","organizations_url":"https://api.github.com/users/tomas-stefano/orgs","repos_url":"https://api.github.com/users/tomas-stefano/repos","events_url":"https://api.github.com/users/tomas-stefano/events{/privacy}","received_events_url":"https://api.github.com/users/tomas-stefano/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-11-13T11:47:59Z","updated_at":"2014-11-13T13:57:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c6dbd10a3bde4b5efd8cf1d294fae673772a51a7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/moneyadviceservice/cms/pulls/78/commits","review_comments_url":"https://api.github.com/repos/moneyadviceservice/cms/pulls/78/comments","review_comment_url":"https://api.github.com/repos/moneyadviceservice/cms/pulls/comments/{number}","comments_url":"https://api.github.com/repos/moneyadviceservice/cms/issues/78/comments","statuses_url":"https://api.github.com/repos/moneyadviceservice/cms/statuses/1a5eca770a5a46adc59559fa65b2350fafe59940","head":{"label":"moneyadviceservice:global-navigation","ref":"global-navigation","sha":"1a5eca770a5a46adc59559fa65b2350fafe59940","user":{"login":"moneyadviceservice","id":2064781,"avatar_url":"https://avatars.githubusercontent.com/u/2064781?v=3","gravatar_id":"","url":"https://api.github.com/users/moneyadviceservice","html_url":"https://github.com/moneyadviceservice","followers_url":"https://api.github.com/users/moneyadviceservice/followers","following_url":"https://api.github.com/users/moneyadviceservice/following{/other_user}","gists_url":"https://api.github.com/users/moneyadviceservice/gists{/gist_id}","starred_url":"https://api.github.com/users/moneyadviceservice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moneyadviceservice/subscriptions","organizations_url":"https://api.github.com/users/moneyadviceservice/orgs","repos_url":"https://api.github.com/users/moneyadviceservice/repos","events_url":"https://api.github.com/users/moneyadviceservice/events{/privacy}","received_events_url":"https://api.github.com/users/moneyadviceservice/received_events","type":"Organization","site_admin":false},"repo":{"id":21238354,"name":"cms","full_name":"moneyadviceservice/cms","owner":{"login":"moneyadviceservice","id":2064781,"avatar_url":"https://avatars.githubusercontent.com/u/2064781?v=3","gravatar_id":"","url":"https://api.github.com/users/moneyadviceservice","html_url":"https://github.com/moneyadviceservice","followers_url":"https://api.github.com/users/moneyadviceservice/followers","following_url":"https://api.github.com/users/moneyadviceservice/following{/other_user}","gists_url":"https://api.github.com/users/moneyadviceservice/gists{/gist_id}","starred_url":"https://api.github.com/users/moneyadviceservice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moneyadviceservice/subscriptions","organizations_url":"https://api.github.com/users/moneyadviceservice/orgs","repos_url":"https://api.github.com/users/moneyadviceservice/repos","events_url":"https://api.github.com/users/moneyadviceservice/events{/privacy}","received_events_url":"https://api.github.com/users/moneyadviceservice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/moneyadviceservice/cms","description":"The MAS CMS","fork":false,"url":"https://api.github.com/repos/moneyadviceservice/cms","forks_url":"https://api.github.com/repos/moneyadviceservice/cms/forks","keys_url":"https://api.github.com/repos/moneyadviceservice/cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/moneyadviceservice/cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/moneyadviceservice/cms/teams","hooks_url":"https://api.github.com/repos/moneyadviceservice/cms/hooks","issue_events_url":"https://api.github.com/repos/moneyadviceservice/cms/issues/events{/number}","events_url":"https://api.github.com/repos/moneyadviceservice/cms/events","assignees_url":"https://api.github.com/repos/moneyadviceservice/cms/assignees{/user}","branches_url":"https://api.github.com/repos/moneyadviceservice/cms/branches{/branch}","tags_url":"https://api.github.com/repos/moneyadviceservice/cms/tags","blobs_url":"https://api.github.com/repos/moneyadviceservice/cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/moneyadviceservice/cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/moneyadviceservice/cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/moneyadviceservice/cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/moneyadviceservice/cms/statuses/{sha}","languages_url":"https://api.github.com/repos/moneyadviceservice/cms/languages","stargazers_url":"https://api.github.com/repos/moneyadviceservice/cms/stargazers","contributors_url":"https://api.github.com/repos/moneyadviceservice/cms/contributors","subscribers_url":"https://api.github.com/repos/moneyadviceservice/cms/subscribers","subscription_url":"https://api.github.com/repos/moneyadviceservice/cms/subscription","commits_url":"https://api.github.com/repos/moneyadviceservice/cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/moneyadviceservice/cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/moneyadviceservice/cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/moneyadviceservice/cms/issues/comments/{number}","contents_url":"https://api.github.com/repos/moneyadviceservice/cms/contents/{+path}","compare_url":"https://api.github.com/repos/moneyadviceservice/cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/moneyadviceservice/cms/merges","archive_url":"https://api.github.com/repos/moneyadviceservice/cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/moneyadviceservice/cms/downloads","issues_url":"https://api.github.com/repos/moneyadviceservice/cms/issues{/number}","pulls_url":"https://api.github.com/repos/moneyadviceservice/cms/pulls{/number}","milestones_url":"https://api.github.com/repos/moneyadviceservice/cms/milestones{/number}","notifications_url":"https://api.github.com/repos/moneyadviceservice/cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/moneyadviceservice/cms/labels{/name}","releases_url":"https://api.github.com/repos/moneyadviceservice/cms/releases{/id}","created_at":"2014-06-26T11:26:25Z","updated_at":"2014-09-08T10:29:15Z","pushed_at":"2014-11-13T12:23:22Z","git_url":"git://github.com/moneyadviceservice/cms.git","ssh_url":"git@github.com:moneyadviceservice/cms.git","clone_url":"https://github.com/moneyadviceservice/cms.git","svn_url":"https://github.com/moneyadviceservice/cms","homepage":null,"size":7972,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"moneyadviceservice:master","ref":"master","sha":"7b32f4ea0efe6544bba43c86de6243aceb3a2e2c","user":{"login":"moneyadviceservice","id":2064781,"avatar_url":"https://avatars.githubusercontent.com/u/2064781?v=3","gravatar_id":"","url":"https://api.github.com/users/moneyadviceservice","html_url":"https://github.com/moneyadviceservice","followers_url":"https://api.github.com/users/moneyadviceservice/followers","following_url":"https://api.github.com/users/moneyadviceservice/following{/other_user}","gists_url":"https://api.github.com/users/moneyadviceservice/gists{/gist_id}","starred_url":"https://api.github.com/users/moneyadviceservice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moneyadviceservice/subscriptions","organizations_url":"https://api.github.com/users/moneyadviceservice/orgs","repos_url":"https://api.github.com/users/moneyadviceservice/repos","events_url":"https://api.github.com/users/moneyadviceservice/events{/privacy}","received_events_url":"https://api.github.com/users/moneyadviceservice/received_events","type":"Organization","site_admin":false},"repo":{"id":21238354,"name":"cms","full_name":"moneyadviceservice/cms","owner":{"login":"moneyadviceservice","id":2064781,"avatar_url":"https://avatars.githubusercontent.com/u/2064781?v=3","gravatar_id":"","url":"https://api.github.com/users/moneyadviceservice","html_url":"https://github.com/moneyadviceservice","followers_url":"https://api.github.com/users/moneyadviceservice/followers","following_url":"https://api.github.com/users/moneyadviceservice/following{/other_user}","gists_url":"https://api.github.com/users/moneyadviceservice/gists{/gist_id}","starred_url":"https://api.github.com/users/moneyadviceservice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moneyadviceservice/subscriptions","organizations_url":"https://api.github.com/users/moneyadviceservice/orgs","repos_url":"https://api.github.com/users/moneyadviceservice/repos","events_url":"https://api.github.com/users/moneyadviceservice/events{/privacy}","received_events_url":"https://api.github.com/users/moneyadviceservice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/moneyadviceservice/cms","description":"The MAS CMS","fork":false,"url":"https://api.github.com/repos/moneyadviceservice/cms","forks_url":"https://api.github.com/repos/moneyadviceservice/cms/forks","keys_url":"https://api.github.com/repos/moneyadviceservice/cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/moneyadviceservice/cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/moneyadviceservice/cms/teams","hooks_url":"https://api.github.com/repos/moneyadviceservice/cms/hooks","issue_events_url":"https://api.github.com/repos/moneyadviceservice/cms/issues/events{/number}","events_url":"https://api.github.com/repos/moneyadviceservice/cms/events","assignees_url":"https://api.github.com/repos/moneyadviceservice/cms/assignees{/user}","branches_url":"https://api.github.com/repos/moneyadviceservice/cms/branches{/branch}","tags_url":"https://api.github.com/repos/moneyadviceservice/cms/tags","blobs_url":"https://api.github.com/repos/moneyadviceservice/cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/moneyadviceservice/cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/moneyadviceservice/cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/moneyadviceservice/cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/moneyadviceservice/cms/statuses/{sha}","languages_url":"https://api.github.com/repos/moneyadviceservice/cms/languages","stargazers_url":"https://api.github.com/repos/moneyadviceservice/cms/stargazers","contributors_url":"https://api.github.com/repos/moneyadviceservice/cms/contributors","subscribers_url":"https://api.github.com/repos/moneyadviceservice/cms/subscribers","subscription_url":"https://api.github.com/repos/moneyadviceservice/cms/subscription","commits_url":"https://api.github.com/repos/moneyadviceservice/cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/moneyadviceservice/cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/moneyadviceservice/cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/moneyadviceservice/cms/issues/comments/{number}","contents_url":"https://api.github.com/repos/moneyadviceservice/cms/contents/{+path}","compare_url":"https://api.github.com/repos/moneyadviceservice/cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/moneyadviceservice/cms/merges","archive_url":"https://api.github.com/repos/moneyadviceservice/cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/moneyadviceservice/cms/downloads","issues_url":"https://api.github.com/repos/moneyadviceservice/cms/issues{/number}","pulls_url":"https://api.github.com/repos/moneyadviceservice/cms/pulls{/number}","milestones_url":"https://api.github.com/repos/moneyadviceservice/cms/milestones{/number}","notifications_url":"https://api.github.com/repos/moneyadviceservice/cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/moneyadviceservice/cms/labels{/name}","releases_url":"https://api.github.com/repos/moneyadviceservice/cms/releases{/id}","created_at":"2014-06-26T11:26:25Z","updated_at":"2014-09-08T10:29:15Z","pushed_at":"2014-11-13T12:23:22Z","git_url":"git://github.com/moneyadviceservice/cms.git","ssh_url":"git@github.com:moneyadviceservice/cms.git","clone_url":"https://github.com/moneyadviceservice/cms.git","svn_url":"https://github.com/moneyadviceservice/cms","homepage":null,"size":7972,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/moneyadviceservice/cms/pulls/78"},"html":{"href":"https://github.com/moneyadviceservice/cms/pull/78"},"issue":{"href":"https://api.github.com/repos/moneyadviceservice/cms/issues/78"},"comments":{"href":"https://api.github.com/repos/moneyadviceservice/cms/issues/78/comments"},"review_comments":{"href":"https://api.github.com/repos/moneyadviceservice/cms/pulls/78/comments"},"review_comment":{"href":"https://api.github.com/repos/moneyadviceservice/cms/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/moneyadviceservice/cms/pulls/78/commits"},"statuses":{"href":"https://api.github.com/repos/moneyadviceservice/cms/statuses/1a5eca770a5a46adc59559fa65b2350fafe59940"}}}}