GitHub PullRequestReviewCommentEvent at 2014-06-24 07:55:41
Repository: Project-OSRM
Actor: DennisOSRM
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/DennisOSRM/Project-OSRM/pulls/comments/14116793","id":14116793,"diff_hunk":"@@ -212,7 +212,7 @@ template <class EdgeDataT> class InternalDataFacade : public BaseDataFacade<Edge\n         BOOST_ASSERT_MSG(0 != number_of_chars, \"name file broken\");\n         m_names_char_list.resize(number_of_chars + 1); //+1 gives sentinel element\n         name_stream.read((char *)&m_names_char_list[0], number_of_chars * sizeof(char));\n-        BOOST_ASSERT_MSG(0 != m_names_char_list.size(), \"could not load any names\");\n+//        BOOST_ASSERT_MSG(0 != m_names_char_list.size(), \"could not load any names\");","path":"Server/DataStructures/InternalDataFacade.h","position":5,"original_position":5,"commit_id":"10aa935a6bf1ab2e7a991057fc07d6eecff16b59","original_commit_id":"10aa935a6bf1ab2e7a991057fc07d6eecff16b59","user":{"login":"DennisOSRM","id":1067895,"avatar_url":"https://avatars.githubusercontent.com/u/1067895?","gravatar_id":"498c16976f86cdd92eb2de3bfb7ecb07","url":"https://api.github.com/users/DennisOSRM","html_url":"https://github.com/DennisOSRM","followers_url":"https://api.github.com/users/DennisOSRM/followers","following_url":"https://api.github.com/users/DennisOSRM/following{/other_user}","gists_url":"https://api.github.com/users/DennisOSRM/gists{/gist_id}","starred_url":"https://api.github.com/users/DennisOSRM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DennisOSRM/subscriptions","organizations_url":"https://api.github.com/users/DennisOSRM/orgs","repos_url":"https://api.github.com/users/DennisOSRM/repos","events_url":"https://api.github.com/users/DennisOSRM/events{/privacy}","received_events_url":"https://api.github.com/users/DennisOSRM/received_events","type":"User","site_admin":false},"body":"What's the issue that is happening here? The assert should either be fixed or removed.","created_at":"2014-06-24T07:55:41Z","updated_at":"2014-06-24T07:55:41Z","html_url":"https://github.com/DennisOSRM/Project-OSRM/pull/1094#discussion_r14116793","pull_request_url":"https://api.github.com/repos/DennisOSRM/Project-OSRM/pulls/1094","_links":{"self":{"href":"https://api.github.com/repos/DennisOSRM/Project-OSRM/pulls/comments/14116793"},"html":{"href":"https://github.com/DennisOSRM/Project-OSRM/pull/1094#discussion_r14116793"},"pull_request":{"href":"https://api.github.com/repos/DennisOSRM/Project-OSRM/pulls/1094"}}},"pull_request":{"url":"https://api.github.com/repos/DennisOSRM/Project-OSRM/pulls/1094","id":17479423,"html_url":"https://github.com/DennisOSRM/Project-OSRM/pull/1094","diff_url":"https://github.com/DennisOSRM/Project-OSRM/pull/1094.diff","patch_url":"https://github.com/DennisOSRM/Project-OSRM/pull/1094.patch","issue_url":"https://api.github.com/repos/DennisOSRM/Project-OSRM/issues/1094","number":1094,"state":"open","title":"Fixes","user":{"login":"gberaudo","id":7294662,"avatar_url":"https://avatars.githubusercontent.com/u/7294662?","gravatar_id":"a9f489e692d36e9638f89270dbafa969","url":"https://api.github.com/users/gberaudo","html_url":"https://github.com/gberaudo","followers_url":"https://api.github.com/users/gberaudo/followers","following_url":"https://api.github.com/users/gberaudo/following{/other_user}","gists_url":"https://api.github.com/users/gberaudo/gists{/gist_id}","starred_url":"https://api.github.com/users/gberaudo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gberaudo/subscriptions","organizations_url":"https://api.github.com/users/gberaudo/orgs","repos_url":"https://api.github.com/users/gberaudo/repos","events_url":"https://api.github.com/users/gberaudo/events{/privacy}","received_events_url":"https://api.github.com/users/gberaudo/received_events","type":"User","site_admin":false},"body":"Small fixes not including elevation features.","created_at":"2014-06-23T15:06:54Z","updated_at":"2014-06-24T07:55:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c2635247a544098c5122dc83ef135abd3014f984","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/DennisOSRM/Project-OSRM/pulls/1094/commits","review_comments_url":"https://api.github.com/repos/DennisOSRM/Project-OSRM/pulls/1094/comments","review_comment_url":"https://api.github.com/repos/DennisOSRM/Project-OSRM/pulls/comments/{number}","comments_url":"https://api.github.com/repos/DennisOSRM/Project-OSRM/issues/1094/comments","statuses_url":"https://api.github.com/repos/DennisOSRM/Project-OSRM/statuses/10aa935a6bf1ab2e7a991057fc07d6eecff16b59","head":{"label":"gberaudo:fixes","ref":"fixes","sha":"10aa935a6bf1ab2e7a991057fc07d6eecff16b59","user":{"login":"gberaudo","id":7294662,"avatar_url":"https://avatars.githubusercontent.com/u/7294662?","gravatar_id":"a9f489e692d36e9638f89270dbafa969","url":"https://api.github.com/users/gberaudo","html_url":"https://github.com/gberaudo","followers_url":"https://api.github.com/users/gberaudo/followers","following_url":"https://api.github.com/users/gberaudo/following{/other_user}","gists_url":"https://api.github.com/users/gberaudo/gists{/gist_id}","starred_url":"https://api.github.com/users/gberaudo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gberaudo/subscriptions","organizations_url":"https://api.github.com/users/gberaudo/orgs","repos_url":"https://api.github.com/users/gberaudo/repos","events_url":"https://api.github.com/users/gberaudo/events{/privacy}","received_events_url":"https://api.github.com/users/gberaudo/received_events","type":"User","site_admin":false},"repo":{"id":20443158,"name":"Project-OSRM","full_name":"gberaudo/Project-OSRM","owner":{"login":"gberaudo","id":7294662,"avatar_url":"https://avatars.githubusercontent.com/u/7294662?","gravatar_id":"a9f489e692d36e9638f89270dbafa969","url":"https://api.github.com/users/gberaudo","html_url":"https://github.com/gberaudo","followers_url":"https://api.github.com/users/gberaudo/followers","following_url":"https://api.github.com/users/gberaudo/following{/other_user}","gists_url":"https://api.github.com/users/gberaudo/gists{/gist_id}","starred_url":"https://api.github.com/users/gberaudo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gberaudo/subscriptions","organizations_url":"https://api.github.com/users/gberaudo/orgs","repos_url":"https://api.github.com/users/gberaudo/repos","events_url":"https://api.github.com/users/gberaudo/events{/privacy}","received_events_url":"https://api.github.com/users/gberaudo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gberaudo/Project-OSRM","description":"Project OSRM: The OpenStreetMap Data Routing Engine","fork":true,"url":"https://api.github.com/repos/gberaudo/Project-OSRM","forks_url":"https://api.github.com/repos/gberaudo/Project-OSRM/forks","keys_url":"https://api.github.com/repos/gberaudo/Project-OSRM/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gberaudo/Project-OSRM/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gberaudo/Project-OSRM/teams","hooks_url":"https://api.github.com/repos/gberaudo/Project-OSRM/hooks","issue_events_url":"https://api.github.com/repos/gberaudo/Project-OSRM/issues/events{/number}","events_url":"https://api.github.com/repos/gberaudo/Project-OSRM/events","assignees_url":"https://api.github.com/repos/gberaudo/Project-OSRM/assignees{/user}","branches_url":"https://api.github.com/repos/gberaudo/Project-OSRM/branches{/branch}","tags_url":"https://api.github.com/repos/gberaudo/Project-OSRM/tags","blobs_url":"https://api.github.com/repos/gberaudo/Project-OSRM/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gberaudo/Project-OSRM/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gberaudo/Project-OSRM/git/refs{/sha}","trees_url":"https://api.github.com/repos/gberaudo/Project-OSRM/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gberaudo/Project-OSRM/statuses/{sha}","languages_url":"https://api.github.com/repos/gberaudo/Project-OSRM/languages","stargazers_url":"https://api.github.com/repos/gberaudo/Project-OSRM/stargazers","contributors_url":"https://api.github.com/repos/gberaudo/Project-OSRM/contributors","subscribers_url":"https://api.github.com/repos/gberaudo/Project-OSRM/subscribers","subscription_url":"https://api.github.com/repos/gberaudo/Project-OSRM/subscription","commits_url":"https://api.github.com/repos/gberaudo/Project-OSRM/commits{/sha}","git_commits_url":"https://api.github.com/repos/gberaudo/Project-OSRM/git/commits{/sha}","comments_url":"https://api.github.com/repos/gberaudo/Project-OSRM/comments{/number}","issue_comment_url":"https://api.github.com/repos/gberaudo/Project-OSRM/issues/comments/{number}","contents_url":"https://api.github.com/repos/gberaudo/Project-OSRM/contents/{+path}","compare_url":"https://api.github.com/repos/gberaudo/Project-OSRM/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gberaudo/Project-OSRM/merges","archive_url":"https://api.github.com/repos/gberaudo/Project-OSRM/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gberaudo/Project-OSRM/downloads","issues_url":"https://api.github.com/repos/gberaudo/Project-OSRM/issues{/number}","pulls_url":"https://api.github.com/repos/gberaudo/Project-OSRM/pulls{/number}","milestones_url":"https://api.github.com/repos/gberaudo/Project-OSRM/milestones{/number}","notifications_url":"https://api.github.com/repos/gberaudo/Project-OSRM/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gberaudo/Project-OSRM/labels{/name}","releases_url":"https://api.github.com/repos/gberaudo/Project-OSRM/releases{/id}","created_at":"2014-06-03T13:13:29Z","updated_at":"2014-06-23T16:50:43Z","pushed_at":"2014-06-23T15:47:04Z","git_url":"git://github.com/gberaudo/Project-OSRM.git","ssh_url":"git@github.com:gberaudo/Project-OSRM.git","clone_url":"https://github.com/gberaudo/Project-OSRM.git","svn_url":"https://github.com/gberaudo/Project-OSRM","homepage":"http://map.project-osrm.org","size":8288,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DennisOSRM:develop","ref":"develop","sha":"5e1110930e757e65911ea43cb35e03a658843741","user":{"login":"DennisOSRM","id":1067895,"avatar_url":"https://avatars.githubusercontent.com/u/1067895?","gravatar_id":"498c16976f86cdd92eb2de3bfb7ecb07","url":"https://api.github.com/users/DennisOSRM","html_url":"https://github.com/DennisOSRM","followers_url":"https://api.github.com/users/DennisOSRM/followers","following_url":"https://api.github.com/users/DennisOSRM/following{/other_user}","gists_url":"https://api.github.com/users/DennisOSRM/gists{/gist_id}","starred_url":"https://api.github.com/users/DennisOSRM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DennisOSRM/subscriptions","organizations_url":"https://api.github.com/users/DennisOSRM/orgs","repos_url":"https://api.github.com/users/DennisOSRM/repos","events_url":"https://api.github.com/users/DennisOSRM/events{/privacy}","received_events_url":"https://api.github.com/users/DennisOSRM/received_events","type":"User","site_admin":false},"repo":{"id":2436255,"name":"Project-OSRM","full_name":"DennisOSRM/Project-OSRM","owner":{"login":"DennisOSRM","id":1067895,"avatar_url":"https://avatars.githubusercontent.com/u/1067895?","gravatar_id":"498c16976f86cdd92eb2de3bfb7ecb07","url":"https://api.github.com/users/DennisOSRM","html_url":"https://github.com/DennisOSRM","followers_url":"https://api.github.com/users/DennisOSRM/followers","following_url":"https://api.github.com/users/DennisOSRM/following{/other_user}","gists_url":"https://api.github.com/users/DennisOSRM/gists{/gist_id}","starred_url":"https://api.github.com/users/DennisOSRM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DennisOSRM/subscriptions","organizations_url":"https://api.github.com/users/DennisOSRM/orgs","repos_url":"https://api.github.com/users/DennisOSRM/repos","events_url":"https://api.github.com/users/DennisOSRM/events{/privacy}","received_events_url":"https://api.github.com/users/DennisOSRM/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DennisOSRM/Project-OSRM","description":"Project OSRM: The OpenStreetMap Data Routing Engine","fork":false,"url":"https://api.github.com/repos/DennisOSRM/Project-OSRM","forks_url":"https://api.github.com/repos/DennisOSRM/Project-OSRM/forks","keys_url":"https://api.github.com/repos/DennisOSRM/Project-OSRM/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DennisOSRM/Project-OSRM/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DennisOSRM/Project-OSRM/teams","hooks_url":"https://api.github.com/repos/DennisOSRM/Project-OSRM/hooks","issue_events_url":"https://api.github.com/repos/DennisOSRM/Project-OSRM/issues/events{/number}","events_url":"https://api.github.com/repos/DennisOSRM/Project-OSRM/events","assignees_url":"https://api.github.com/repos/DennisOSRM/Project-OSRM/assignees{/user}","branches_url":"https://api.github.com/repos/DennisOSRM/Project-OSRM/branches{/branch}","tags_url":"https://api.github.com/repos/DennisOSRM/Project-OSRM/tags","blobs_url":"https://api.github.com/repos/DennisOSRM/Project-OSRM/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DennisOSRM/Project-OSRM/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DennisOSRM/Project-OSRM/git/refs{/sha}","trees_url":"https://api.github.com/repos/DennisOSRM/Project-OSRM/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DennisOSRM/Project-OSRM/statuses/{sha}","languages_url":"https://api.github.com/repos/DennisOSRM/Project-OSRM/languages","stargazers_url":"https://api.github.com/repos/DennisOSRM/Project-OSRM/stargazers","contributors_url":"https://api.github.com/repos/DennisOSRM/Project-OSRM/contributors","subscribers_url":"https://api.github.com/repos/DennisOSRM/Project-OSRM/subscribers","subscription_url":"https://api.github.com/repos/DennisOSRM/Project-OSRM/subscription","commits_url":"https://api.github.com/repos/DennisOSRM/Project-OSRM/commits{/sha}","git_commits_url":"https://api.github.com/repos/DennisOSRM/Project-OSRM/git/commits{/sha}","comments_url":"https://api.github.com/repos/DennisOSRM/Project-OSRM/comments{/number}","issue_comment_url":"https://api.github.com/repos/DennisOSRM/Project-OSRM/issues/comments/{number}","contents_url":"https://api.github.com/repos/DennisOSRM/Project-OSRM/contents/{+path}","compare_url":"https://api.github.com/repos/DennisOSRM/Project-OSRM/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DennisOSRM/Project-OSRM/merges","archive_url":"https://api.github.com/repos/DennisOSRM/Project-OSRM/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DennisOSRM/Project-OSRM/downloads","issues_url":"https://api.github.com/repos/DennisOSRM/Project-OSRM/issues{/number}","pulls_url":"https://api.github.com/repos/DennisOSRM/Project-OSRM/pulls{/number}","milestones_url":"https://api.github.com/repos/DennisOSRM/Project-OSRM/milestones{/number}","notifications_url":"https://api.github.com/repos/DennisOSRM/Project-OSRM/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DennisOSRM/Project-OSRM/labels{/name}","releases_url":"https://api.github.com/repos/DennisOSRM/Project-OSRM/releases{/id}","created_at":"2011-09-22T10:05:08Z","updated_at":"2014-06-23T17:49:31Z","pushed_at":"2014-06-23T17:49:31Z","git_url":"git://github.com/DennisOSRM/Project-OSRM.git","ssh_url":"git@github.com:DennisOSRM/Project-OSRM.git","clone_url":"https://github.com/DennisOSRM/Project-OSRM.git","svn_url":"https://github.com/DennisOSRM/Project-OSRM","homepage":"http://map.project-osrm.org","size":23606,"stargazers_count":531,"watchers_count":531,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":189,"mirror_url":null,"open_issues_count":144,"forks":189,"open_issues":144,"watchers":531,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DennisOSRM/Project-OSRM/pulls/1094"},"html":{"href":"https://github.com/DennisOSRM/Project-OSRM/pull/1094"},"issue":{"href":"https://api.github.com/repos/DennisOSRM/Project-OSRM/issues/1094"},"comments":{"href":"https://api.github.com/repos/DennisOSRM/Project-OSRM/issues/1094/comments"},"review_comments":{"href":"https://api.github.com/repos/DennisOSRM/Project-OSRM/pulls/1094/comments"},"review_comment":{"href":"https://api.github.com/repos/DennisOSRM/Project-OSRM/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/DennisOSRM/Project-OSRM/pulls/1094/commits"},"statuses":{"href":"https://api.github.com/repos/DennisOSRM/Project-OSRM/statuses/10aa935a6bf1ab2e7a991057fc07d6eecff16b59"}}}}