GitHub PullRequestReviewCommentEvent at 2014-11-03 18:31:30
Repository: qserv
Actor: g-i-t
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/LSST/qserv/pulls/comments/19753170","id":19753170,"diff_hunk":"@@ -0,0 +1,66 @@\n+\n+local_err_msg=\"Failure while starting Qserv:\"\n+if [ ! -w \"${QSERV_RUN_DIR}\" -o ! -d \"${QSERV_RUN_DIR}\" ]; then\n+    log_failure_msg \"${local_err_msg} \\$QSERV_RUN_DIR isn't a writable \\\n+directory\"\n+    exit 1\n+fi\n+if [ ! -w \"${QSERV_PID_DIR}\" -o ! -d \"${QSERV_PID_DIR}\" ]; then\n+    log_failure_msg \"${local_err_msg} \\$QSERV_PID_DIR isn't a writable \\\n+directory\"\n+    exit 1\n+fi\n+if [ ! -w \"${QSERV_LOG_DIR}\" -o ! -d \"${QSERV_LOG_DIR}\" ]; then\n+    log_failure_msg \"${local_err_msg} \\$QSERV_LOG_DIR isn't a writable \\\n+directory\"\n+    exit 1\n+fi\n+if [ -z \"${QSERV_UNIX_USER}\" ]; then\n+    log_failure_msg \"${local_err_msg} \\$QSERV_UNIX_USER is an empty \\\n+string\"\n+    exit 1\n+fi\n+if [ \"$QSERV_RPC_PORT\" -neq \"$QSERV_RPC_PORT\" ] 2> /dev/null; then","path":"admin/templates/configuration/etc/init.d/qserv-check-config","position":null,"original_position":23,"commit_id":"08d252d89e662701cc10a81e4c91d2c12a72872b","original_commit_id":"2152b45a73fd01563a7ef8276bc2d42498663e5c","user":{"login":"g-i-t","id":4266950,"avatar_url":"https://avatars.githubusercontent.com/u/4266950?v=2","gravatar_id":"","url":"https://api.github.com/users/g-i-t","html_url":"https://github.com/g-i-t","followers_url":"https://api.github.com/users/g-i-t/followers","following_url":"https://api.github.com/users/g-i-t/following{/other_user}","gists_url":"https://api.github.com/users/g-i-t/gists{/gist_id}","starred_url":"https://api.github.com/users/g-i-t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/g-i-t/subscriptions","organizations_url":"https://api.github.com/users/g-i-t/orgs","repos_url":"https://api.github.com/users/g-i-t/repos","events_url":"https://api.github.com/users/g-i-t/events{/privacy}","received_events_url":"https://api.github.com/users/g-i-t/received_events","type":"User","site_admin":false},"body":"I don't think I can define any simple rule. I guess there should be enough checks to make sure that init.d script can do its work (start or stop service), but if you just pass something to a server then it's probably application responsibility to validate it.\r\n","created_at":"2014-11-03T18:31:30Z","updated_at":"2014-11-03T18:31:30Z","html_url":"https://github.com/LSST/qserv/pull/7#discussion_r19753170","pull_request_url":"https://api.github.com/repos/LSST/qserv/pulls/7","_links":{"self":{"href":"https://api.github.com/repos/LSST/qserv/pulls/comments/19753170"},"html":{"href":"https://github.com/LSST/qserv/pull/7#discussion_r19753170"},"pull_request":{"href":"https://api.github.com/repos/LSST/qserv/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/LSST/qserv/pulls/7","id":23574304,"html_url":"https://github.com/LSST/qserv/pull/7","diff_url":"https://github.com/LSST/qserv/pull/7.diff","patch_url":"https://github.com/LSST/qserv/pull/7.patch","issue_url":"https://api.github.com/repos/LSST/qserv/issues/7","number":7,"state":"open","locked":false,"title":"u/fjammes/dm-1338","user":{"login":"g-i-t","id":4266950,"avatar_url":"https://avatars.githubusercontent.com/u/4266950?v=2","gravatar_id":"","url":"https://api.github.com/users/g-i-t","html_url":"https://github.com/g-i-t","followers_url":"https://api.github.com/users/g-i-t/followers","following_url":"https://api.github.com/users/g-i-t/following{/other_user}","gists_url":"https://api.github.com/users/g-i-t/gists{/gist_id}","starred_url":"https://api.github.com/users/g-i-t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/g-i-t/subscriptions","organizations_url":"https://api.github.com/users/g-i-t/orgs","repos_url":"https://api.github.com/users/g-i-t/repos","events_url":"https://api.github.com/users/g-i-t/events{/privacy}","received_events_url":"https://api.github.com/users/g-i-t/received_events","type":"User","site_admin":false},"body":"Reviewing DM-1338","created_at":"2014-10-29T23:55:58Z","updated_at":"2014-11-03T18:31:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9d4d82a1c642570301594b4f09baa995a527b054","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/LSST/qserv/pulls/7/commits","review_comments_url":"https://api.github.com/repos/LSST/qserv/pulls/7/comments","review_comment_url":"https://api.github.com/repos/LSST/qserv/pulls/comments/{number}","comments_url":"https://api.github.com/repos/LSST/qserv/issues/7/comments","statuses_url":"https://api.github.com/repos/LSST/qserv/statuses/08d252d89e662701cc10a81e4c91d2c12a72872b","head":{"label":"LSST:u/fjammes/DM-1338","ref":"u/fjammes/DM-1338","sha":"08d252d89e662701cc10a81e4c91d2c12a72872b","user":{"login":"LSST","id":1134504,"avatar_url":"https://avatars.githubusercontent.com/u/1134504?v=2","gravatar_id":"","url":"https://api.github.com/users/LSST","html_url":"https://github.com/LSST","followers_url":"https://api.github.com/users/LSST/followers","following_url":"https://api.github.com/users/LSST/following{/other_user}","gists_url":"https://api.github.com/users/LSST/gists{/gist_id}","starred_url":"https://api.github.com/users/LSST/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LSST/subscriptions","organizations_url":"https://api.github.com/users/LSST/orgs","repos_url":"https://api.github.com/users/LSST/repos","events_url":"https://api.github.com/users/LSST/events{/privacy}","received_events_url":"https://api.github.com/users/LSST/received_events","type":"Organization","site_admin":false},"repo":{"id":23013460,"name":"qserv","full_name":"LSST/qserv","owner":{"login":"LSST","id":1134504,"avatar_url":"https://avatars.githubusercontent.com/u/1134504?v=2","gravatar_id":"","url":"https://api.github.com/users/LSST","html_url":"https://github.com/LSST","followers_url":"https://api.github.com/users/LSST/followers","following_url":"https://api.github.com/users/LSST/following{/other_user}","gists_url":"https://api.github.com/users/LSST/gists{/gist_id}","starred_url":"https://api.github.com/users/LSST/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LSST/subscriptions","organizations_url":"https://api.github.com/users/LSST/orgs","repos_url":"https://api.github.com/users/LSST/repos","events_url":"https://api.github.com/users/LSST/events{/privacy}","received_events_url":"https://api.github.com/users/LSST/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LSST/qserv","description":null,"fork":false,"url":"https://api.github.com/repos/LSST/qserv","forks_url":"https://api.github.com/repos/LSST/qserv/forks","keys_url":"https://api.github.com/repos/LSST/qserv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LSST/qserv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LSST/qserv/teams","hooks_url":"https://api.github.com/repos/LSST/qserv/hooks","issue_events_url":"https://api.github.com/repos/LSST/qserv/issues/events{/number}","events_url":"https://api.github.com/repos/LSST/qserv/events","assignees_url":"https://api.github.com/repos/LSST/qserv/assignees{/user}","branches_url":"https://api.github.com/repos/LSST/qserv/branches{/branch}","tags_url":"https://api.github.com/repos/LSST/qserv/tags","blobs_url":"https://api.github.com/repos/LSST/qserv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LSST/qserv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LSST/qserv/git/refs{/sha}","trees_url":"https://api.github.com/repos/LSST/qserv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LSST/qserv/statuses/{sha}","languages_url":"https://api.github.com/repos/LSST/qserv/languages","stargazers_url":"https://api.github.com/repos/LSST/qserv/stargazers","contributors_url":"https://api.github.com/repos/LSST/qserv/contributors","subscribers_url":"https://api.github.com/repos/LSST/qserv/subscribers","subscription_url":"https://api.github.com/repos/LSST/qserv/subscription","commits_url":"https://api.github.com/repos/LSST/qserv/commits{/sha}","git_commits_url":"https://api.github.com/repos/LSST/qserv/git/commits{/sha}","comments_url":"https://api.github.com/repos/LSST/qserv/comments{/number}","issue_comment_url":"https://api.github.com/repos/LSST/qserv/issues/comments/{number}","contents_url":"https://api.github.com/repos/LSST/qserv/contents/{+path}","compare_url":"https://api.github.com/repos/LSST/qserv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LSST/qserv/merges","archive_url":"https://api.github.com/repos/LSST/qserv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LSST/qserv/downloads","issues_url":"https://api.github.com/repos/LSST/qserv/issues{/number}","pulls_url":"https://api.github.com/repos/LSST/qserv/pulls{/number}","milestones_url":"https://api.github.com/repos/LSST/qserv/milestones{/number}","notifications_url":"https://api.github.com/repos/LSST/qserv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LSST/qserv/labels{/name}","releases_url":"https://api.github.com/repos/LSST/qserv/releases{/id}","created_at":"2014-08-16T07:50:36Z","updated_at":"2014-09-19T15:19:05Z","pushed_at":"2014-11-03T18:02:08Z","git_url":"git://github.com/LSST/qserv.git","ssh_url":"git@github.com:LSST/qserv.git","clone_url":"https://github.com/LSST/qserv.git","svn_url":"https://github.com/LSST/qserv","homepage":null,"size":14925,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":3,"forks":3,"open_issues":3,"watchers":1,"default_branch":"master"}},"base":{"label":"LSST:master","ref":"master","sha":"7ec9f529129b5c91546cd56b539a88d14484ee08","user":{"login":"LSST","id":1134504,"avatar_url":"https://avatars.githubusercontent.com/u/1134504?v=2","gravatar_id":"","url":"https://api.github.com/users/LSST","html_url":"https://github.com/LSST","followers_url":"https://api.github.com/users/LSST/followers","following_url":"https://api.github.com/users/LSST/following{/other_user}","gists_url":"https://api.github.com/users/LSST/gists{/gist_id}","starred_url":"https://api.github.com/users/LSST/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LSST/subscriptions","organizations_url":"https://api.github.com/users/LSST/orgs","repos_url":"https://api.github.com/users/LSST/repos","events_url":"https://api.github.com/users/LSST/events{/privacy}","received_events_url":"https://api.github.com/users/LSST/received_events","type":"Organization","site_admin":false},"repo":{"id":23013460,"name":"qserv","full_name":"LSST/qserv","owner":{"login":"LSST","id":1134504,"avatar_url":"https://avatars.githubusercontent.com/u/1134504?v=2","gravatar_id":"","url":"https://api.github.com/users/LSST","html_url":"https://github.com/LSST","followers_url":"https://api.github.com/users/LSST/followers","following_url":"https://api.github.com/users/LSST/following{/other_user}","gists_url":"https://api.github.com/users/LSST/gists{/gist_id}","starred_url":"https://api.github.com/users/LSST/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LSST/subscriptions","organizations_url":"https://api.github.com/users/LSST/orgs","repos_url":"https://api.github.com/users/LSST/repos","events_url":"https://api.github.com/users/LSST/events{/privacy}","received_events_url":"https://api.github.com/users/LSST/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LSST/qserv","description":null,"fork":false,"url":"https://api.github.com/repos/LSST/qserv","forks_url":"https://api.github.com/repos/LSST/qserv/forks","keys_url":"https://api.github.com/repos/LSST/qserv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LSST/qserv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LSST/qserv/teams","hooks_url":"https://api.github.com/repos/LSST/qserv/hooks","issue_events_url":"https://api.github.com/repos/LSST/qserv/issues/events{/number}","events_url":"https://api.github.com/repos/LSST/qserv/events","assignees_url":"https://api.github.com/repos/LSST/qserv/assignees{/user}","branches_url":"https://api.github.com/repos/LSST/qserv/branches{/branch}","tags_url":"https://api.github.com/repos/LSST/qserv/tags","blobs_url":"https://api.github.com/repos/LSST/qserv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LSST/qserv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LSST/qserv/git/refs{/sha}","trees_url":"https://api.github.com/repos/LSST/qserv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LSST/qserv/statuses/{sha}","languages_url":"https://api.github.com/repos/LSST/qserv/languages","stargazers_url":"https://api.github.com/repos/LSST/qserv/stargazers","contributors_url":"https://api.github.com/repos/LSST/qserv/contributors","subscribers_url":"https://api.github.com/repos/LSST/qserv/subscribers","subscription_url":"https://api.github.com/repos/LSST/qserv/subscription","commits_url":"https://api.github.com/repos/LSST/qserv/commits{/sha}","git_commits_url":"https://api.github.com/repos/LSST/qserv/git/commits{/sha}","comments_url":"https://api.github.com/repos/LSST/qserv/comments{/number}","issue_comment_url":"https://api.github.com/repos/LSST/qserv/issues/comments/{number}","contents_url":"https://api.github.com/repos/LSST/qserv/contents/{+path}","compare_url":"https://api.github.com/repos/LSST/qserv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LSST/qserv/merges","archive_url":"https://api.github.com/repos/LSST/qserv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LSST/qserv/downloads","issues_url":"https://api.github.com/repos/LSST/qserv/issues{/number}","pulls_url":"https://api.github.com/repos/LSST/qserv/pulls{/number}","milestones_url":"https://api.github.com/repos/LSST/qserv/milestones{/number}","notifications_url":"https://api.github.com/repos/LSST/qserv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LSST/qserv/labels{/name}","releases_url":"https://api.github.com/repos/LSST/qserv/releases{/id}","created_at":"2014-08-16T07:50:36Z","updated_at":"2014-09-19T15:19:05Z","pushed_at":"2014-11-03T18:02:08Z","git_url":"git://github.com/LSST/qserv.git","ssh_url":"git@github.com:LSST/qserv.git","clone_url":"https://github.com/LSST/qserv.git","svn_url":"https://github.com/LSST/qserv","homepage":null,"size":14925,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":3,"forks":3,"open_issues":3,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/LSST/qserv/pulls/7"},"html":{"href":"https://github.com/LSST/qserv/pull/7"},"issue":{"href":"https://api.github.com/repos/LSST/qserv/issues/7"},"comments":{"href":"https://api.github.com/repos/LSST/qserv/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/LSST/qserv/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/LSST/qserv/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/LSST/qserv/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/LSST/qserv/statuses/08d252d89e662701cc10a81e4c91d2c12a72872b"}}}}