GitHub PullRequestReviewCommentEvent at 2014-05-18 04:26:16
Repository: aspect
Actor: ian-r-rose
Payload: {"comment":{"url":"https://api.github.com/repos/geodynamics/aspect/pulls/comments/12772111","id":12772111,"diff_hunk":"@@ -802,6 +812,20 @@ namespace aspect\n                    ExcMessage(\"Invalid input parameter file: Too many entries in List of normalized fields\"));\n     }\n     prm.leave_subsection ();\n+\n+    prm.enter_subsection (\"Free surface\");\n+        {\n+          std::vector<int> x_free_surface_boundary_indicators\n+            = Utilities::string_to_int\n+              (Utilities::split_string_list\n+               (prm.get (\"Free surface boundary indicators\")));\n+          free_surface_boundary_indicators\n+            = std::set<types::boundary_id> (x_free_surface_boundary_indicators.begin(),\n+                                              x_free_surface_boundary_indicators.end());\n+\n+          free_surface_enabled = !free_surface_boundary_indicators.empty();\n+        }\n+    prm.leave_subsection ();\n   }","path":"source/simulator/parameters.cc","position":35,"original_position":35,"commit_id":"e625f24251255cd8fb76db2e8da8948018d84fad","original_commit_id":"e625f24251255cd8fb76db2e8da8948018d84fad","user":{"login":"ian-r-rose","id":5728311,"avatar_url":"https://avatars.githubusercontent.com/u/5728311?","gravatar_id":"91de3f50dcbe944dbcb847f74cbe2d70","url":"https://api.github.com/users/ian-r-rose","html_url":"https://github.com/ian-r-rose","followers_url":"https://api.github.com/users/ian-r-rose/followers","following_url":"https://api.github.com/users/ian-r-rose/following{/other_user}","gists_url":"https://api.github.com/users/ian-r-rose/gists{/gist_id}","starred_url":"https://api.github.com/users/ian-r-rose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ian-r-rose/subscriptions","organizations_url":"https://api.github.com/users/ian-r-rose/orgs","repos_url":"https://api.github.com/users/ian-r-rose/repos","events_url":"https://api.github.com/users/ian-r-rose/events{/privacy}","received_events_url":"https://api.github.com/users/ian-r-rose/received_events","type":"User","site_admin":false},"body":"Roger that","created_at":"2014-05-18T04:26:16Z","updated_at":"2014-05-18T04:26:16Z","html_url":"https://github.com/geodynamics/aspect/pull/12#discussion_r12772111","pull_request_url":"https://api.github.com/repos/geodynamics/aspect/pulls/12","_links":{"self":{"href":"https://api.github.com/repos/geodynamics/aspect/pulls/comments/12772111"},"html":{"href":"https://github.com/geodynamics/aspect/pull/12#discussion_r12772111"},"pull_request":{"href":"https://api.github.com/repos/geodynamics/aspect/pulls/12"}}}}