GitHub PullRequestReviewCommentEvent at 2014-04-08 15:27:54
Repository: WAVED
Actor: seanblue
Payload: {"comment":{"url":"https://api.github.com/repos/KSHSK/WAVED/pulls/comments/11395013","id":11395013,"diff_hunk":"@@ -66,14 +75,27 @@ define(['knockout',\n     });\n \n     Property.prototype.getState = function() {\n+        if (typeof this._value === 'object' && typeof this._value.getState === 'function') {\n+            return {\n+                'value': this._value.getState()\n+            };\n+        }\n         return {\n             'value': this._value\n         };\n     };\n \n     Property.prototype.setState = function(state) {\n-        this._value = state.value;\n-        this._displayValue = state.value;\n+        var value = state.value;\n+        if (defined(state.value) && defined(state.value.type)) {\n+            var O = window.wavedTypes[state.value.type];","path":"Source/models/Property/Property.js","position":49,"original_position":49,"commit_id":"3d73b0877ac16c530a064bbcbfb766deab9c9bda","original_commit_id":"3d73b0877ac16c530a064bbcbfb766deab9c9bda","user":{"login":"seanblue","id":5884067,"avatar_url":"https://avatars.githubusercontent.com/u/5884067?","gravatar_id":"56a2fb3bf7fa47d27a2470273280aacf","url":"https://api.github.com/users/seanblue","html_url":"https://github.com/seanblue","followers_url":"https://api.github.com/users/seanblue/followers","following_url":"https://api.github.com/users/seanblue/following{/other_user}","gists_url":"https://api.github.com/users/seanblue/gists{/gist_id}","starred_url":"https://api.github.com/users/seanblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanblue/subscriptions","organizations_url":"https://api.github.com/users/seanblue/orgs","repos_url":"https://api.github.com/users/seanblue/repos","events_url":"https://api.github.com/users/seanblue/events{/privacy}","received_events_url":"https://api.github.com/users/seanblue/received_events","type":"User","site_admin":false},"body":"Can you explain the need for this?\r\n@stnguyen09 should also look at this stuff. His version of `ArrayProperty` already replaced the DataSet state with an actual DataSet object, or something like that. Maybe the two of you can agree on which way is better so it's consistent.","created_at":"2014-04-08T15:27:54Z","updated_at":"2014-04-08T15:27:54Z","html_url":"https://github.com/KSHSK/WAVED/pull/195#discussion_r11395013","pull_request_url":"https://api.github.com/repos/KSHSK/WAVED/pulls/195","_links":{"self":{"href":"https://api.github.com/repos/KSHSK/WAVED/pulls/comments/11395013"},"html":{"href":"https://github.com/KSHSK/WAVED/pull/195#discussion_r11395013"},"pull_request":{"href":"https://api.github.com/repos/KSHSK/WAVED/pulls/195"}}}}