GitHub PullRequestReviewCommentEvent at 2014-12-09 19:41:08
Repository: FileSystem
Actor: Praburaj
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/aspnet/FileSystem/pulls/comments/21556057","id":21556057,"diff_hunk":"@@ -24,5 +26,12 @@ public interface IFileSystem\n         /// <param name=\"subpath\">Relative path that identifies the directory.</param>\n         /// <returns>Returns the contents of the directory.</returns>\n         IDirectoryContents GetDirectoryContents(string subpath);\n+\n+        /// <summary>\n+        /// Creates a change trigger with the specified filter.\n+        /// </summary>\n+        /// <param name=\"filter\">Filter string used to determine what files or folders to monitor.</param>","path":"src/Microsoft.AspNet.FileSystems.Interfaces/IFileSystem.cs","position":17,"original_position":17,"commit_id":"4092fb635399353461924ebab3fa635dd39e1ab0","original_commit_id":"4092fb635399353461924ebab3fa635dd39e1ab0","user":{"login":"Praburaj","id":2294732,"avatar_url":"https://avatars.githubusercontent.com/u/2294732?v=3","gravatar_id":"","url":"https://api.github.com/users/Praburaj","html_url":"https://github.com/Praburaj","followers_url":"https://api.github.com/users/Praburaj/followers","following_url":"https://api.github.com/users/Praburaj/following{/other_user}","gists_url":"https://api.github.com/users/Praburaj/gists{/gist_id}","starred_url":"https://api.github.com/users/Praburaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Praburaj/subscriptions","organizations_url":"https://api.github.com/users/Praburaj/orgs","repos_url":"https://api.github.com/users/Praburaj/repos","events_url":"https://api.github.com/users/Praburaj/events{/privacy}","received_events_url":"https://api.github.com/users/Praburaj/received_events","type":"User","site_admin":false},"body":"Good point. I will add some examples. \r\n\r\nYeah you can do all of those patterns - same like \"code\", \"exclude\" fields on project.json.","created_at":"2014-12-09T19:41:08Z","updated_at":"2014-12-09T19:41:08Z","html_url":"https://github.com/aspnet/FileSystem/pull/24#discussion_r21556057","pull_request_url":"https://api.github.com/repos/aspnet/FileSystem/pulls/24","_links":{"self":{"href":"https://api.github.com/repos/aspnet/FileSystem/pulls/comments/21556057"},"html":{"href":"https://github.com/aspnet/FileSystem/pull/24#discussion_r21556057"},"pull_request":{"href":"https://api.github.com/repos/aspnet/FileSystem/pulls/24"}}},"pull_request":{"url":"https://api.github.com/repos/aspnet/FileSystem/pulls/24","id":25532836,"html_url":"https://github.com/aspnet/FileSystem/pull/24","diff_url":"https://github.com/aspnet/FileSystem/pull/24.diff","patch_url":"https://github.com/aspnet/FileSystem/pull/24.patch","issue_url":"https://api.github.com/repos/aspnet/FileSystem/issues/24","number":24,"state":"open","locked":false,"title":"Adding ability to monitor file changes for PhysicalFileSystem","user":{"login":"Praburaj","id":2294732,"avatar_url":"https://avatars.githubusercontent.com/u/2294732?v=3","gravatar_id":"","url":"https://api.github.com/users/Praburaj","html_url":"https://github.com/Praburaj","followers_url":"https://api.github.com/users/Praburaj/followers","following_url":"https://api.github.com/users/Praburaj/following{/other_user}","gists_url":"https://api.github.com/users/Praburaj/gists{/gist_id}","starred_url":"https://api.github.com/users/Praburaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Praburaj/subscriptions","organizations_url":"https://api.github.com/users/Praburaj/orgs","repos_url":"https://api.github.com/users/Praburaj/repos","events_url":"https://api.github.com/users/Praburaj/events{/privacy}","received_events_url":"https://api.github.com/users/Praburaj/received_events","type":"User","site_admin":false},"body":"1. This includes the implementation & tests.\r\n2. A modified IFileInfo interface (This will require changes to MVC repo - A PR will be sent out after this changes are approved.).\r\n3. File system watcher turns off when there are no files to monitor and turns on when files are to be monitored.\r\n4. Need to add a test to verify that file system watcher turns off if no files to monitor.\r\n\r\n@Tratcher @pranavkm ","created_at":"2014-12-04T22:08:40Z","updated_at":"2014-12-09T19:41:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a9ff89d6b51e5c1c7daf4c43582025f5f6661112","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/aspnet/FileSystem/pulls/24/commits","review_comments_url":"https://api.github.com/repos/aspnet/FileSystem/pulls/24/comments","review_comment_url":"https://api.github.com/repos/aspnet/FileSystem/pulls/comments/{number}","comments_url":"https://api.github.com/repos/aspnet/FileSystem/issues/24/comments","statuses_url":"https://api.github.com/repos/aspnet/FileSystem/statuses/4092fb635399353461924ebab3fa635dd39e1ab0","head":{"label":"Praburaj:dev","ref":"dev","sha":"4092fb635399353461924ebab3fa635dd39e1ab0","user":{"login":"Praburaj","id":2294732,"avatar_url":"https://avatars.githubusercontent.com/u/2294732?v=3","gravatar_id":"","url":"https://api.github.com/users/Praburaj","html_url":"https://github.com/Praburaj","followers_url":"https://api.github.com/users/Praburaj/followers","following_url":"https://api.github.com/users/Praburaj/following{/other_user}","gists_url":"https://api.github.com/users/Praburaj/gists{/gist_id}","starred_url":"https://api.github.com/users/Praburaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Praburaj/subscriptions","organizations_url":"https://api.github.com/users/Praburaj/orgs","repos_url":"https://api.github.com/users/Praburaj/repos","events_url":"https://api.github.com/users/Praburaj/events{/privacy}","received_events_url":"https://api.github.com/users/Praburaj/received_events","type":"User","site_admin":false},"repo":{"id":27562314,"name":"FileSystem","full_name":"Praburaj/FileSystem","owner":{"login":"Praburaj","id":2294732,"avatar_url":"https://avatars.githubusercontent.com/u/2294732?v=3","gravatar_id":"","url":"https://api.github.com/users/Praburaj","html_url":"https://github.com/Praburaj","followers_url":"https://api.github.com/users/Praburaj/followers","following_url":"https://api.github.com/users/Praburaj/following{/other_user}","gists_url":"https://api.github.com/users/Praburaj/gists{/gist_id}","starred_url":"https://api.github.com/users/Praburaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Praburaj/subscriptions","organizations_url":"https://api.github.com/users/Praburaj/orgs","repos_url":"https://api.github.com/users/Praburaj/repos","events_url":"https://api.github.com/users/Praburaj/events{/privacy}","received_events_url":"https://api.github.com/users/Praburaj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Praburaj/FileSystem","description":"Abstraction of file system APIs.","fork":true,"url":"https://api.github.com/repos/Praburaj/FileSystem","forks_url":"https://api.github.com/repos/Praburaj/FileSystem/forks","keys_url":"https://api.github.com/repos/Praburaj/FileSystem/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Praburaj/FileSystem/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Praburaj/FileSystem/teams","hooks_url":"https://api.github.com/repos/Praburaj/FileSystem/hooks","issue_events_url":"https://api.github.com/repos/Praburaj/FileSystem/issues/events{/number}","events_url":"https://api.github.com/repos/Praburaj/FileSystem/events","assignees_url":"https://api.github.com/repos/Praburaj/FileSystem/assignees{/user}","branches_url":"https://api.github.com/repos/Praburaj/FileSystem/branches{/branch}","tags_url":"https://api.github.com/repos/Praburaj/FileSystem/tags","blobs_url":"https://api.github.com/repos/Praburaj/FileSystem/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Praburaj/FileSystem/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Praburaj/FileSystem/git/refs{/sha}","trees_url":"https://api.github.com/repos/Praburaj/FileSystem/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Praburaj/FileSystem/statuses/{sha}","languages_url":"https://api.github.com/repos/Praburaj/FileSystem/languages","stargazers_url":"https://api.github.com/repos/Praburaj/FileSystem/stargazers","contributors_url":"https://api.github.com/repos/Praburaj/FileSystem/contributors","subscribers_url":"https://api.github.com/repos/Praburaj/FileSystem/subscribers","subscription_url":"https://api.github.com/repos/Praburaj/FileSystem/subscription","commits_url":"https://api.github.com/repos/Praburaj/FileSystem/commits{/sha}","git_commits_url":"https://api.github.com/repos/Praburaj/FileSystem/git/commits{/sha}","comments_url":"https://api.github.com/repos/Praburaj/FileSystem/comments{/number}","issue_comment_url":"https://api.github.com/repos/Praburaj/FileSystem/issues/comments/{number}","contents_url":"https://api.github.com/repos/Praburaj/FileSystem/contents/{+path}","compare_url":"https://api.github.com/repos/Praburaj/FileSystem/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Praburaj/FileSystem/merges","archive_url":"https://api.github.com/repos/Praburaj/FileSystem/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Praburaj/FileSystem/downloads","issues_url":"https://api.github.com/repos/Praburaj/FileSystem/issues{/number}","pulls_url":"https://api.github.com/repos/Praburaj/FileSystem/pulls{/number}","milestones_url":"https://api.github.com/repos/Praburaj/FileSystem/milestones{/number}","notifications_url":"https://api.github.com/repos/Praburaj/FileSystem/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Praburaj/FileSystem/labels{/name}","releases_url":"https://api.github.com/repos/Praburaj/FileSystem/releases{/id}","created_at":"2014-12-04T22:07:30Z","updated_at":"2014-12-09T19:33:46Z","pushed_at":"2014-12-09T19:33:46Z","git_url":"git://github.com/Praburaj/FileSystem.git","ssh_url":"git@github.com:Praburaj/FileSystem.git","clone_url":"https://github.com/Praburaj/FileSystem.git","svn_url":"https://github.com/Praburaj/FileSystem","homepage":"","size":204,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"aspnet:dev","ref":"dev","sha":"225f316ca7c4f9690c8963a254de817033b74d9a","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":16161950,"name":"FileSystem","full_name":"aspnet/FileSystem","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/FileSystem","description":"Abstraction of file system APIs.","fork":false,"url":"https://api.github.com/repos/aspnet/FileSystem","forks_url":"https://api.github.com/repos/aspnet/FileSystem/forks","keys_url":"https://api.github.com/repos/aspnet/FileSystem/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/FileSystem/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/FileSystem/teams","hooks_url":"https://api.github.com/repos/aspnet/FileSystem/hooks","issue_events_url":"https://api.github.com/repos/aspnet/FileSystem/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/FileSystem/events","assignees_url":"https://api.github.com/repos/aspnet/FileSystem/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/FileSystem/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/FileSystem/tags","blobs_url":"https://api.github.com/repos/aspnet/FileSystem/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/FileSystem/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/FileSystem/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/FileSystem/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/FileSystem/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/FileSystem/languages","stargazers_url":"https://api.github.com/repos/aspnet/FileSystem/stargazers","contributors_url":"https://api.github.com/repos/aspnet/FileSystem/contributors","subscribers_url":"https://api.github.com/repos/aspnet/FileSystem/subscribers","subscription_url":"https://api.github.com/repos/aspnet/FileSystem/subscription","commits_url":"https://api.github.com/repos/aspnet/FileSystem/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/FileSystem/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/FileSystem/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/FileSystem/issues/comments/{number}","contents_url":"https://api.github.com/repos/aspnet/FileSystem/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/FileSystem/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/FileSystem/merges","archive_url":"https://api.github.com/repos/aspnet/FileSystem/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/FileSystem/downloads","issues_url":"https://api.github.com/repos/aspnet/FileSystem/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/FileSystem/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/FileSystem/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/FileSystem/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/FileSystem/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/FileSystem/releases{/id}","created_at":"2014-01-23T04:09:34Z","updated_at":"2014-12-08T23:24:35Z","pushed_at":"2014-12-08T23:45:07Z","git_url":"git://github.com/aspnet/FileSystem.git","ssh_url":"git@github.com:aspnet/FileSystem.git","clone_url":"https://github.com/aspnet/FileSystem.git","svn_url":"https://github.com/aspnet/FileSystem","homepage":"","size":851,"stargazers_count":41,"watchers_count":41,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":10,"forks":17,"open_issues":10,"watchers":41,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnet/FileSystem/pulls/24"},"html":{"href":"https://github.com/aspnet/FileSystem/pull/24"},"issue":{"href":"https://api.github.com/repos/aspnet/FileSystem/issues/24"},"comments":{"href":"https://api.github.com/repos/aspnet/FileSystem/issues/24/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnet/FileSystem/pulls/24/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnet/FileSystem/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/aspnet/FileSystem/pulls/24/commits"},"statuses":{"href":"https://api.github.com/repos/aspnet/FileSystem/statuses/4092fb635399353461924ebab3fa635dd39e1ab0"}}}}