GitHub PullRequestReviewCommentEvent at 2014-10-28 09:07:22
Repository: mercury
Actor: nandy-andy
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/Wikia/mercury/pulls/comments/19458812","id":19458812,"diff_hunk":"@@ -8,7 +8,9 @@\n \t\t\t{{i18n 'side-nav-menu-label'}}\n \t\t{{/if}}\n \t</li>\n-\t<li><a href=\"/wiki/Special:Random\">{{i18n 'random-page-label'}}</a></li>\n+\t<li {{action 'randomArticle'}}>","path":"public/templates/main/app/local-nav-menu.hbs","position":5,"original_position":5,"commit_id":"bc8685178399f2dfba1656ed6be554d027fe0fbd","original_commit_id":"bc8685178399f2dfba1656ed6be554d027fe0fbd","user":{"login":"nandy-andy","id":1662451,"avatar_url":"https://avatars.githubusercontent.com/u/1662451?v=2","gravatar_id":"","url":"https://api.github.com/users/nandy-andy","html_url":"https://github.com/nandy-andy","followers_url":"https://api.github.com/users/nandy-andy/followers","following_url":"https://api.github.com/users/nandy-andy/following{/other_user}","gists_url":"https://api.github.com/users/nandy-andy/gists{/gist_id}","starred_url":"https://api.github.com/users/nandy-andy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nandy-andy/subscriptions","organizations_url":"https://api.github.com/users/nandy-andy/orgs","repos_url":"https://api.github.com/users/nandy-andy/repos","events_url":"https://api.github.com/users/nandy-andy/events{/privacy}","received_events_url":"https://api.github.com/users/nandy-andy/received_events","type":"User","site_admin":false},"body":"I wanted to use `{{link-to}}` helper and actually I used it but there were some side-effects made by our {{handleLink()}} hooks (in {{ArticleView}} and {{ApplicationRoute}}). I made a very ugly work-around for them and yesterday I came up with the idea of custom action which is cleaner than the hack: https://github.com/Wikia/mercury/commit/272615f0baf2ff4cfdbf6bbe40cf50fd234cd637 I discussed it with @hakubo offline and I can leave a `//TODO:` comment to fix it once we clean our links handlers -- Jakub, have you created the ticket for it? :japanese_ogre: ","created_at":"2014-10-28T09:07:22Z","updated_at":"2014-10-28T09:07:22Z","html_url":"https://github.com/Wikia/mercury/pull/291#discussion_r19458812","pull_request_url":"https://api.github.com/repos/Wikia/mercury/pulls/291","_links":{"self":{"href":"https://api.github.com/repos/Wikia/mercury/pulls/comments/19458812"},"html":{"href":"https://github.com/Wikia/mercury/pull/291#discussion_r19458812"},"pull_request":{"href":"https://api.github.com/repos/Wikia/mercury/pulls/291"}}},"pull_request":{"url":"https://api.github.com/repos/Wikia/mercury/pulls/291","id":23378292,"html_url":"https://github.com/Wikia/mercury/pull/291","diff_url":"https://github.com/Wikia/mercury/pull/291.diff","patch_url":"https://github.com/Wikia/mercury/pull/291.patch","issue_url":"https://api.github.com/repos/Wikia/mercury/issues/291","number":291,"state":"open","locked":false,"title":"HG-199","user":{"login":"nandy-andy","id":1662451,"avatar_url":"https://avatars.githubusercontent.com/u/1662451?v=2","gravatar_id":"","url":"https://api.github.com/users/nandy-andy","html_url":"https://github.com/nandy-andy","followers_url":"https://api.github.com/users/nandy-andy/followers","following_url":"https://api.github.com/users/nandy-andy/following{/other_user}","gists_url":"https://api.github.com/users/nandy-andy/gists{/gist_id}","starred_url":"https://api.github.com/users/nandy-andy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nandy-andy/subscriptions","organizations_url":"https://api.github.com/users/nandy-andy/orgs","repos_url":"https://api.github.com/users/nandy-andy/repos","events_url":"https://api.github.com/users/nandy-andy/events{/privacy}","received_events_url":"https://api.github.com/users/nandy-andy/received_events","type":"User","site_admin":false},"body":"Currently `Random Page` button in Mercury goes to MW `Special:Random` page. We want to change it and use Ember's magic there. The changes below use new entry-point on MW side implemented in: https://github.com/Wikia/app/pull/5113 and are as follow:\r\n* Hapi entry point for random page,\r\n* EmberJS changes on front-end side (new `randomPage` route, new custom action in `ApplicationRoute`, changes in `ArticleModel` and in local navigation template).\r\n\r\nTODO:\r\n* unit tests fixes,\r\n* new unit tests,\r\n* fix first visit,\r\n* check how to pass model into article view instead of sending 2 requests.","created_at":"2014-10-27T12:03:10Z","updated_at":"2014-10-28T09:07:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"04eaf51f5b33f133dbcc2a3b84896bddb9a1ec5a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Wikia/mercury/pulls/291/commits","review_comments_url":"https://api.github.com/repos/Wikia/mercury/pulls/291/comments","review_comment_url":"https://api.github.com/repos/Wikia/mercury/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Wikia/mercury/issues/291/comments","statuses_url":"https://api.github.com/repos/Wikia/mercury/statuses/bc8685178399f2dfba1656ed6be554d027fe0fbd","head":{"label":"Wikia:HG-199","ref":"HG-199","sha":"bc8685178399f2dfba1656ed6be554d027fe0fbd","user":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=2","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"repo":{"id":16710430,"name":"mercury","full_name":"Wikia/mercury","owner":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=2","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Wikia/mercury","description":"","fork":false,"url":"https://api.github.com/repos/Wikia/mercury","forks_url":"https://api.github.com/repos/Wikia/mercury/forks","keys_url":"https://api.github.com/repos/Wikia/mercury/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Wikia/mercury/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Wikia/mercury/teams","hooks_url":"https://api.github.com/repos/Wikia/mercury/hooks","issue_events_url":"https://api.github.com/repos/Wikia/mercury/issues/events{/number}","events_url":"https://api.github.com/repos/Wikia/mercury/events","assignees_url":"https://api.github.com/repos/Wikia/mercury/assignees{/user}","branches_url":"https://api.github.com/repos/Wikia/mercury/branches{/branch}","tags_url":"https://api.github.com/repos/Wikia/mercury/tags","blobs_url":"https://api.github.com/repos/Wikia/mercury/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Wikia/mercury/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Wikia/mercury/git/refs{/sha}","trees_url":"https://api.github.com/repos/Wikia/mercury/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Wikia/mercury/statuses/{sha}","languages_url":"https://api.github.com/repos/Wikia/mercury/languages","stargazers_url":"https://api.github.com/repos/Wikia/mercury/stargazers","contributors_url":"https://api.github.com/repos/Wikia/mercury/contributors","subscribers_url":"https://api.github.com/repos/Wikia/mercury/subscribers","subscription_url":"https://api.github.com/repos/Wikia/mercury/subscription","commits_url":"https://api.github.com/repos/Wikia/mercury/commits{/sha}","git_commits_url":"https://api.github.com/repos/Wikia/mercury/git/commits{/sha}","comments_url":"https://api.github.com/repos/Wikia/mercury/comments{/number}","issue_comment_url":"https://api.github.com/repos/Wikia/mercury/issues/comments/{number}","contents_url":"https://api.github.com/repos/Wikia/mercury/contents/{+path}","compare_url":"https://api.github.com/repos/Wikia/mercury/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Wikia/mercury/merges","archive_url":"https://api.github.com/repos/Wikia/mercury/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Wikia/mercury/downloads","issues_url":"https://api.github.com/repos/Wikia/mercury/issues{/number}","pulls_url":"https://api.github.com/repos/Wikia/mercury/pulls{/number}","milestones_url":"https://api.github.com/repos/Wikia/mercury/milestones{/number}","notifications_url":"https://api.github.com/repos/Wikia/mercury/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Wikia/mercury/labels{/name}","releases_url":"https://api.github.com/repos/Wikia/mercury/releases{/id}","created_at":"2014-02-10T21:44:25Z","updated_at":"2014-10-10T12:14:31Z","pushed_at":"2014-10-27T21:43:56Z","git_url":"git://github.com/Wikia/mercury.git","ssh_url":"git@github.com:Wikia/mercury.git","clone_url":"https://github.com/Wikia/mercury.git","svn_url":"https://github.com/Wikia/mercury","homepage":null,"size":17156,"stargazers_count":5,"watchers_count":5,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":5,"default_branch":"master"}},"base":{"label":"Wikia:master","ref":"master","sha":"fa2d9bbd877234699a23b8add1db9155edba77cc","user":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=2","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"repo":{"id":16710430,"name":"mercury","full_name":"Wikia/mercury","owner":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=2","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Wikia/mercury","description":"","fork":false,"url":"https://api.github.com/repos/Wikia/mercury","forks_url":"https://api.github.com/repos/Wikia/mercury/forks","keys_url":"https://api.github.com/repos/Wikia/mercury/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Wikia/mercury/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Wikia/mercury/teams","hooks_url":"https://api.github.com/repos/Wikia/mercury/hooks","issue_events_url":"https://api.github.com/repos/Wikia/mercury/issues/events{/number}","events_url":"https://api.github.com/repos/Wikia/mercury/events","assignees_url":"https://api.github.com/repos/Wikia/mercury/assignees{/user}","branches_url":"https://api.github.com/repos/Wikia/mercury/branches{/branch}","tags_url":"https://api.github.com/repos/Wikia/mercury/tags","blobs_url":"https://api.github.com/repos/Wikia/mercury/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Wikia/mercury/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Wikia/mercury/git/refs{/sha}","trees_url":"https://api.github.com/repos/Wikia/mercury/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Wikia/mercury/statuses/{sha}","languages_url":"https://api.github.com/repos/Wikia/mercury/languages","stargazers_url":"https://api.github.com/repos/Wikia/mercury/stargazers","contributors_url":"https://api.github.com/repos/Wikia/mercury/contributors","subscribers_url":"https://api.github.com/repos/Wikia/mercury/subscribers","subscription_url":"https://api.github.com/repos/Wikia/mercury/subscription","commits_url":"https://api.github.com/repos/Wikia/mercury/commits{/sha}","git_commits_url":"https://api.github.com/repos/Wikia/mercury/git/commits{/sha}","comments_url":"https://api.github.com/repos/Wikia/mercury/comments{/number}","issue_comment_url":"https://api.github.com/repos/Wikia/mercury/issues/comments/{number}","contents_url":"https://api.github.com/repos/Wikia/mercury/contents/{+path}","compare_url":"https://api.github.com/repos/Wikia/mercury/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Wikia/mercury/merges","archive_url":"https://api.github.com/repos/Wikia/mercury/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Wikia/mercury/downloads","issues_url":"https://api.github.com/repos/Wikia/mercury/issues{/number}","pulls_url":"https://api.github.com/repos/Wikia/mercury/pulls{/number}","milestones_url":"https://api.github.com/repos/Wikia/mercury/milestones{/number}","notifications_url":"https://api.github.com/repos/Wikia/mercury/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Wikia/mercury/labels{/name}","releases_url":"https://api.github.com/repos/Wikia/mercury/releases{/id}","created_at":"2014-02-10T21:44:25Z","updated_at":"2014-10-10T12:14:31Z","pushed_at":"2014-10-27T21:43:56Z","git_url":"git://github.com/Wikia/mercury.git","ssh_url":"git@github.com:Wikia/mercury.git","clone_url":"https://github.com/Wikia/mercury.git","svn_url":"https://github.com/Wikia/mercury","homepage":null,"size":17156,"stargazers_count":5,"watchers_count":5,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Wikia/mercury/pulls/291"},"html":{"href":"https://github.com/Wikia/mercury/pull/291"},"issue":{"href":"https://api.github.com/repos/Wikia/mercury/issues/291"},"comments":{"href":"https://api.github.com/repos/Wikia/mercury/issues/291/comments"},"review_comments":{"href":"https://api.github.com/repos/Wikia/mercury/pulls/291/comments"},"review_comment":{"href":"https://api.github.com/repos/Wikia/mercury/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Wikia/mercury/pulls/291/commits"},"statuses":{"href":"https://api.github.com/repos/Wikia/mercury/statuses/bc8685178399f2dfba1656ed6be554d027fe0fbd"}}}}