GitHub PullRequestEvent at 2014-09-25 07:04:04
Repository: GCMMessage
Actor: iVariable
Payload: {"action":"closed","number":4,"pull_request":{"url":"https://api.github.com/repos/CodeMonkeysRu/GCMMessage/pulls/4","id":18159289,"html_url":"https://github.com/CodeMonkeysRu/GCMMessage/pull/4","diff_url":"https://github.com/CodeMonkeysRu/GCMMessage/pull/4.diff","patch_url":"https://github.com/CodeMonkeysRu/GCMMessage/pull/4.patch","issue_url":"https://api.github.com/repos/CodeMonkeysRu/GCMMessage/issues/4","number":4,"state":"closed","locked":false,"title":"Adding Queueing Functionality / Exponential Backoff","user":{"login":"stevetauber","id":1258342,"avatar_url":"https://avatars.githubusercontent.com/u/1258342?v=2","gravatar_id":"","url":"https://api.github.com/users/stevetauber","html_url":"https://github.com/stevetauber","followers_url":"https://api.github.com/users/stevetauber/followers","following_url":"https://api.github.com/users/stevetauber/following{/other_user}","gists_url":"https://api.github.com/users/stevetauber/gists{/gist_id}","starred_url":"https://api.github.com/users/stevetauber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevetauber/subscriptions","organizations_url":"https://api.github.com/users/stevetauber/orgs","repos_url":"https://api.github.com/users/stevetauber/repos","events_url":"https://api.github.com/users/stevetauber/events{/privacy}","received_events_url":"https://api.github.com/users/stevetauber/received_events","type":"User","site_admin":false},"body":"Ugh... I suck at rebasing. Anyways, this pull request completely re-writes the library into a queue based solution. It uses php-resque to store the pending messages. A worker loops through and then tries to send the message via GCM. If it fails, it adds it back into the queue with exponential back off. It also abides by the Retry-After header. It also uses php-curl-class for easier unit testing / readability.\r\n\r\nThings I still need to do:\r\n - Update Unit Testing\r\n - Support the new notifications stuff (This is still in beta so once my account gets approved then I'll be able to implement it) https://developer.android.com/google/gcm/notifications.html\r\n\r\n","created_at":"2014-07-09T13:14:58Z","updated_at":"2014-09-25T07:04:03Z","closed_at":"2014-09-25T07:04:03Z","merged_at":null,"merge_commit_sha":"279f5b540f2bf3957e1f02fb657688bd2f7fd20a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/CodeMonkeysRu/GCMMessage/pulls/4/commits","review_comments_url":"https://api.github.com/repos/CodeMonkeysRu/GCMMessage/pulls/4/comments","review_comment_url":"https://api.github.com/repos/CodeMonkeysRu/GCMMessage/pulls/comments/{number}","comments_url":"https://api.github.com/repos/CodeMonkeysRu/GCMMessage/issues/4/comments","statuses_url":"https://api.github.com/repos/CodeMonkeysRu/GCMMessage/statuses/30d808783f7810a17c9c2eecd1efa7da0611b654","head":{"label":"stevetauber:master","ref":"master","sha":"30d808783f7810a17c9c2eecd1efa7da0611b654","user":{"login":"stevetauber","id":1258342,"avatar_url":"https://avatars.githubusercontent.com/u/1258342?v=2","gravatar_id":"","url":"https://api.github.com/users/stevetauber","html_url":"https://github.com/stevetauber","followers_url":"https://api.github.com/users/stevetauber/followers","following_url":"https://api.github.com/users/stevetauber/following{/other_user}","gists_url":"https://api.github.com/users/stevetauber/gists{/gist_id}","starred_url":"https://api.github.com/users/stevetauber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevetauber/subscriptions","organizations_url":"https://api.github.com/users/stevetauber/orgs","repos_url":"https://api.github.com/users/stevetauber/repos","events_url":"https://api.github.com/users/stevetauber/events{/privacy}","received_events_url":"https://api.github.com/users/stevetauber/received_events","type":"User","site_admin":false},"repo":{"id":21424367,"name":"GCMMessage","full_name":"stevetauber/GCMMessage","owner":{"login":"stevetauber","id":1258342,"avatar_url":"https://avatars.githubusercontent.com/u/1258342?v=2","gravatar_id":"","url":"https://api.github.com/users/stevetauber","html_url":"https://github.com/stevetauber","followers_url":"https://api.github.com/users/stevetauber/followers","following_url":"https://api.github.com/users/stevetauber/following{/other_user}","gists_url":"https://api.github.com/users/stevetauber/gists{/gist_id}","starred_url":"https://api.github.com/users/stevetauber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevetauber/subscriptions","organizations_url":"https://api.github.com/users/stevetauber/orgs","repos_url":"https://api.github.com/users/stevetauber/repos","events_url":"https://api.github.com/users/stevetauber/events{/privacy}","received_events_url":"https://api.github.com/users/stevetauber/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stevetauber/GCMMessage","description":"A PHP library to send messages to devices registered through Google Cloud Messaging.","fork":true,"url":"https://api.github.com/repos/stevetauber/GCMMessage","forks_url":"https://api.github.com/repos/stevetauber/GCMMessage/forks","keys_url":"https://api.github.com/repos/stevetauber/GCMMessage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stevetauber/GCMMessage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stevetauber/GCMMessage/teams","hooks_url":"https://api.github.com/repos/stevetauber/GCMMessage/hooks","issue_events_url":"https://api.github.com/repos/stevetauber/GCMMessage/issues/events{/number}","events_url":"https://api.github.com/repos/stevetauber/GCMMessage/events","assignees_url":"https://api.github.com/repos/stevetauber/GCMMessage/assignees{/user}","branches_url":"https://api.github.com/repos/stevetauber/GCMMessage/branches{/branch}","tags_url":"https://api.github.com/repos/stevetauber/GCMMessage/tags","blobs_url":"https://api.github.com/repos/stevetauber/GCMMessage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stevetauber/GCMMessage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stevetauber/GCMMessage/git/refs{/sha}","trees_url":"https://api.github.com/repos/stevetauber/GCMMessage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stevetauber/GCMMessage/statuses/{sha}","languages_url":"https://api.github.com/repos/stevetauber/GCMMessage/languages","stargazers_url":"https://api.github.com/repos/stevetauber/GCMMessage/stargazers","contributors_url":"https://api.github.com/repos/stevetauber/GCMMessage/contributors","subscribers_url":"https://api.github.com/repos/stevetauber/GCMMessage/subscribers","subscription_url":"https://api.github.com/repos/stevetauber/GCMMessage/subscription","commits_url":"https://api.github.com/repos/stevetauber/GCMMessage/commits{/sha}","git_commits_url":"https://api.github.com/repos/stevetauber/GCMMessage/git/commits{/sha}","comments_url":"https://api.github.com/repos/stevetauber/GCMMessage/comments{/number}","issue_comment_url":"https://api.github.com/repos/stevetauber/GCMMessage/issues/comments/{number}","contents_url":"https://api.github.com/repos/stevetauber/GCMMessage/contents/{+path}","compare_url":"https://api.github.com/repos/stevetauber/GCMMessage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stevetauber/GCMMessage/merges","archive_url":"https://api.github.com/repos/stevetauber/GCMMessage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stevetauber/GCMMessage/downloads","issues_url":"https://api.github.com/repos/stevetauber/GCMMessage/issues{/number}","pulls_url":"https://api.github.com/repos/stevetauber/GCMMessage/pulls{/number}","milestones_url":"https://api.github.com/repos/stevetauber/GCMMessage/milestones{/number}","notifications_url":"https://api.github.com/repos/stevetauber/GCMMessage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stevetauber/GCMMessage/labels{/name}","releases_url":"https://api.github.com/repos/stevetauber/GCMMessage/releases{/id}","created_at":"2014-07-02T13:05:22Z","updated_at":"2014-07-02T14:12:08Z","pushed_at":"2014-07-11T09:11:39Z","git_url":"git://github.com/stevetauber/GCMMessage.git","ssh_url":"git@github.com:stevetauber/GCMMessage.git","clone_url":"https://github.com/stevetauber/GCMMessage.git","svn_url":"https://github.com/stevetauber/GCMMessage","homepage":null,"size":306,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CodeMonkeysRu:master","ref":"master","sha":"9e3b3580c69b839c2eb5e117742083e8d6cd4e65","user":{"login":"CodeMonkeysRu","id":1104719,"avatar_url":"https://avatars.githubusercontent.com/u/1104719?v=2","gravatar_id":"","url":"https://api.github.com/users/CodeMonkeysRu","html_url":"https://github.com/CodeMonkeysRu","followers_url":"https://api.github.com/users/CodeMonkeysRu/followers","following_url":"https://api.github.com/users/CodeMonkeysRu/following{/other_user}","gists_url":"https://api.github.com/users/CodeMonkeysRu/gists{/gist_id}","starred_url":"https://api.github.com/users/CodeMonkeysRu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CodeMonkeysRu/subscriptions","organizations_url":"https://api.github.com/users/CodeMonkeysRu/orgs","repos_url":"https://api.github.com/users/CodeMonkeysRu/repos","events_url":"https://api.github.com/users/CodeMonkeysRu/events{/privacy}","received_events_url":"https://api.github.com/users/CodeMonkeysRu/received_events","type":"Organization","site_admin":false},"repo":{"id":9542905,"name":"GCMMessage","full_name":"CodeMonkeysRu/GCMMessage","owner":{"login":"CodeMonkeysRu","id":1104719,"avatar_url":"https://avatars.githubusercontent.com/u/1104719?v=2","gravatar_id":"","url":"https://api.github.com/users/CodeMonkeysRu","html_url":"https://github.com/CodeMonkeysRu","followers_url":"https://api.github.com/users/CodeMonkeysRu/followers","following_url":"https://api.github.com/users/CodeMonkeysRu/following{/other_user}","gists_url":"https://api.github.com/users/CodeMonkeysRu/gists{/gist_id}","starred_url":"https://api.github.com/users/CodeMonkeysRu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CodeMonkeysRu/subscriptions","organizations_url":"https://api.github.com/users/CodeMonkeysRu/orgs","repos_url":"https://api.github.com/users/CodeMonkeysRu/repos","events_url":"https://api.github.com/users/CodeMonkeysRu/events{/privacy}","received_events_url":"https://api.github.com/users/CodeMonkeysRu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CodeMonkeysRu/GCMMessage","description":"A PHP library to send messages to devices registered through Google Cloud Messaging.","fork":false,"url":"https://api.github.com/repos/CodeMonkeysRu/GCMMessage","forks_url":"https://api.github.com/repos/CodeMonkeysRu/GCMMessage/forks","keys_url":"https://api.github.com/repos/CodeMonkeysRu/GCMMessage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CodeMonkeysRu/GCMMessage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CodeMonkeysRu/GCMMessage/teams","hooks_url":"https://api.github.com/repos/CodeMonkeysRu/GCMMessage/hooks","issue_events_url":"https://api.github.com/repos/CodeMonkeysRu/GCMMessage/issues/events{/number}","events_url":"https://api.github.com/repos/CodeMonkeysRu/GCMMessage/events","assignees_url":"https://api.github.com/repos/CodeMonkeysRu/GCMMessage/assignees{/user}","branches_url":"https://api.github.com/repos/CodeMonkeysRu/GCMMessage/branches{/branch}","tags_url":"https://api.github.com/repos/CodeMonkeysRu/GCMMessage/tags","blobs_url":"https://api.github.com/repos/CodeMonkeysRu/GCMMessage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CodeMonkeysRu/GCMMessage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CodeMonkeysRu/GCMMessage/git/refs{/sha}","trees_url":"https://api.github.com/repos/CodeMonkeysRu/GCMMessage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CodeMonkeysRu/GCMMessage/statuses/{sha}","languages_url":"https://api.github.com/repos/CodeMonkeysRu/GCMMessage/languages","stargazers_url":"https://api.github.com/repos/CodeMonkeysRu/GCMMessage/stargazers","contributors_url":"https://api.github.com/repos/CodeMonkeysRu/GCMMessage/contributors","subscribers_url":"https://api.github.com/repos/CodeMonkeysRu/GCMMessage/subscribers","subscription_url":"https://api.github.com/repos/CodeMonkeysRu/GCMMessage/subscription","commits_url":"https://api.github.com/repos/CodeMonkeysRu/GCMMessage/commits{/sha}","git_commits_url":"https://api.github.com/repos/CodeMonkeysRu/GCMMessage/git/commits{/sha}","comments_url":"https://api.github.com/repos/CodeMonkeysRu/GCMMessage/comments{/number}","issue_comment_url":"https://api.github.com/repos/CodeMonkeysRu/GCMMessage/issues/comments/{number}","contents_url":"https://api.github.com/repos/CodeMonkeysRu/GCMMessage/contents/{+path}","compare_url":"https://api.github.com/repos/CodeMonkeysRu/GCMMessage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CodeMonkeysRu/GCMMessage/merges","archive_url":"https://api.github.com/repos/CodeMonkeysRu/GCMMessage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CodeMonkeysRu/GCMMessage/downloads","issues_url":"https://api.github.com/repos/CodeMonkeysRu/GCMMessage/issues{/number}","pulls_url":"https://api.github.com/repos/CodeMonkeysRu/GCMMessage/pulls{/number}","milestones_url":"https://api.github.com/repos/CodeMonkeysRu/GCMMessage/milestones{/number}","notifications_url":"https://api.github.com/repos/CodeMonkeysRu/GCMMessage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CodeMonkeysRu/GCMMessage/labels{/name}","releases_url":"https://api.github.com/repos/CodeMonkeysRu/GCMMessage/releases{/id}","created_at":"2013-04-19T10:16:54Z","updated_at":"2014-08-03T19:50:17Z","pushed_at":"2014-07-02T16:15:57Z","git_url":"git://github.com/CodeMonkeysRu/GCMMessage.git","ssh_url":"git@github.com:CodeMonkeysRu/GCMMessage.git","clone_url":"https://github.com/CodeMonkeysRu/GCMMessage.git","svn_url":"https://github.com/CodeMonkeysRu/GCMMessage","homepage":null,"size":209,"stargazers_count":19,"watchers_count":19,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":0,"forks":12,"open_issues":0,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CodeMonkeysRu/GCMMessage/pulls/4"},"html":{"href":"https://github.com/CodeMonkeysRu/GCMMessage/pull/4"},"issue":{"href":"https://api.github.com/repos/CodeMonkeysRu/GCMMessage/issues/4"},"comments":{"href":"https://api.github.com/repos/CodeMonkeysRu/GCMMessage/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/CodeMonkeysRu/GCMMessage/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/CodeMonkeysRu/GCMMessage/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/CodeMonkeysRu/GCMMessage/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/CodeMonkeysRu/GCMMessage/statuses/30d808783f7810a17c9c2eecd1efa7da0611b654"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"commits":6,"additions":638,"deletions":363,"changed_files":9}}