GitHub PullRequestReviewCommentEvent at 2014-04-28 02:22:05
Repository: elasticsearch
Actor: martijnvg
Payload: {"comment":{"url":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/comments/12033493","id":12033493,"diff_hunk":"@@ -159,6 +161,8 @@ public void setNeedsGlobalOrdinals(boolean needsGlobalOrdinals) {}\n \n             public abstract BytesValues.WithOrdinals globalBytesValues();\n \n+            public abstract long maxOrd(IndexSearcher indexSearcher);","path":"src/main/java/org/elasticsearch/search/aggregations/support/ValuesSource.java","position":20,"original_position":20,"commit_id":"1461cc3cb48af666342c8f0afe5765b3bc7e8208","original_commit_id":"1461cc3cb48af666342c8f0afe5765b3bc7e8208","user":{"login":"martijnvg","id":580421,"avatar_url":"https://avatars.githubusercontent.com/u/580421?","gravatar_id":"c572e98b0d86d9f26d5e9cd9ddd99fc7","url":"https://api.github.com/users/martijnvg","html_url":"https://github.com/martijnvg","followers_url":"https://api.github.com/users/martijnvg/followers","following_url":"https://api.github.com/users/martijnvg/following{/other_user}","gists_url":"https://api.github.com/users/martijnvg/gists{/gist_id}","starred_url":"https://api.github.com/users/martijnvg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martijnvg/subscriptions","organizations_url":"https://api.github.com/users/martijnvg/orgs","repos_url":"https://api.github.com/users/martijnvg/repos","events_url":"https://api.github.com/users/martijnvg/events{/privacy}","received_events_url":"https://api.github.com/users/martijnvg/received_events","type":"User","site_admin":false},"body":"Yes, it should, I'll change that.","created_at":"2014-04-28T02:22:05Z","updated_at":"2014-04-28T02:22:05Z","html_url":"https://github.com/elasticsearch/elasticsearch/pull/5895#discussion_r12033493","pull_request_url":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/5895","_links":{"self":{"href":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/comments/12033493"},"html":{"href":"https://github.com/elasticsearch/elasticsearch/pull/5895#discussion_r12033493"},"pull_request":{"href":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/5895"}}}}