GitHub PullRequestReviewCommentEvent at 2014-01-29 14:52:40
Repository: handlebars-helper-intl
Actor: apipkin
Payload: {"comment":{"url":"https://api.github.com/repos/yahoo/handlebars-helper-intl/pulls/comments/9268316","id":9268316,"diff_hunk":"@@ -146,19 +148,13 @@\n         }\n \n         var hash = (options && options.hash) || {},\n-            formatOptions = extend({}, hash),\n-            locale = _getLocale(hash, this),\n-            msg;\n+            data = (options && options.data) || {},\n+            formatOptions = extend({\n+                currency: data.currency\n+            }, hash),\n+            locale = hash.locale || data.locale;\n \n-        if (!formatOptions.currency) {\n-            formatOptions.currency = this.currency;\n-        }\n-\n-\n-\n-        msg = new IntlMessageFormat(str, locale, formatOptions);\n-\n-        return msg.format(formatOptions);\n+        return new IntlMessageFormat(str, locale, formatOptions);","path":"lib/helpers.js","position":52,"original_position":52,"commit_id":"a87f6e1cd343bb2254250c86f49958e6ec06d043","original_commit_id":"a87f6e1cd343bb2254250c86f49958e6ec06d043","user":{"login":"apipkin","id":167456,"avatar_url":"https://gravatar.com/avatar/75f75cf9c3baaf6e50095cdebe24e11d?d=https%3A%2F%2Fidenticons.github.com%2Fef9f6d213a435cc953d522508c79f03f.png&r=x","gravatar_id":"75f75cf9c3baaf6e50095cdebe24e11d","url":"https://api.github.com/users/apipkin","html_url":"https://github.com/apipkin","followers_url":"https://api.github.com/users/apipkin/followers","following_url":"https://api.github.com/users/apipkin/following{/other_user}","gists_url":"https://api.github.com/users/apipkin/gists{/gist_id}","starred_url":"https://api.github.com/users/apipkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apipkin/subscriptions","organizations_url":"https://api.github.com/users/apipkin/orgs","repos_url":"https://api.github.com/users/apipkin/repos","events_url":"https://api.github.com/users/apipkin/events{/privacy}","received_events_url":"https://api.github.com/users/apipkin/received_events","type":"User","site_admin":false},"body":"This needs `.format(formatOptions)` added to the end.","created_at":"2014-01-29T14:52:40Z","updated_at":"2014-01-29T14:52:40Z","html_url":"https://github.com/yahoo/handlebars-helper-intl/pull/18#discussion_r9268316","pull_request_url":"https://api.github.com/repos/yahoo/handlebars-helper-intl/pulls/18","_links":{"self":{"href":"https://api.github.com/repos/yahoo/handlebars-helper-intl/pulls/comments/9268316"},"html":{"href":"https://github.com/yahoo/handlebars-helper-intl/pull/18#discussion_r9268316"},"pull_request":{"href":"https://api.github.com/repos/yahoo/handlebars-helper-intl/pulls/18"}}}}