GitHub PullRequestEvent at 2014-07-13 18:24:57
Repository: stravalib
Actor: hozn
Payload: {"action":"closed","number":22,"pull_request":{"url":"https://api.github.com/repos/hozn/stravalib/pulls/22","id":18312334,"html_url":"https://github.com/hozn/stravalib/pull/22","diff_url":"https://github.com/hozn/stravalib/pull/22.diff","patch_url":"https://github.com/hozn/stravalib/pull/22.patch","issue_url":"https://api.github.com/repos/hozn/stravalib/issues/22","number":22,"state":"closed","title":"add support for streams + a few minor changes","user":{"login":"ghisprince","id":3979966,"avatar_url":"https://avatars.githubusercontent.com/u/3979966?","gravatar_id":"270620414be9cdf8eba71ccb01fe0bb3","url":"https://api.github.com/users/ghisprince","html_url":"https://github.com/ghisprince","followers_url":"https://api.github.com/users/ghisprince/followers","following_url":"https://api.github.com/users/ghisprince/following{/other_user}","gists_url":"https://api.github.com/users/ghisprince/gists{/gist_id}","starred_url":"https://api.github.com/users/ghisprince/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghisprince/subscriptions","organizations_url":"https://api.github.com/users/ghisprince/orgs","repos_url":"https://api.github.com/users/ghisprince/repos","events_url":"https://api.github.com/users/ghisprince/events{/privacy}","received_events_url":"https://api.github.com/users/ghisprince/received_events","type":"User","site_admin":false},"body":"laps is mostly done, but @greenpasta says he see warnings,  i don't have activities with laps, so i can't troubleshoot it. \r\n\r\nstream added  on client object for effort, activity, segment. Not added to the activity object in model.py.\r\n\r\nthere's a few things i put comments next to for your review.","created_at":"2014-07-12T08:16:03Z","updated_at":"2014-07-13T18:24:57Z","closed_at":"2014-07-13T18:24:57Z","merged_at":null,"merge_commit_sha":"c42ca01c8e18ce0e846971e89d7a89c4a61c2824","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hozn/stravalib/pulls/22/commits","review_comments_url":"https://api.github.com/repos/hozn/stravalib/pulls/22/comments","review_comment_url":"https://api.github.com/repos/hozn/stravalib/pulls/comments/{number}","comments_url":"https://api.github.com/repos/hozn/stravalib/issues/22/comments","statuses_url":"https://api.github.com/repos/hozn/stravalib/statuses/94f876e4202f01080fc680bd782020a3b040c78e","head":{"label":"ghisprince:master","ref":"master","sha":"94f876e4202f01080fc680bd782020a3b040c78e","user":{"login":"ghisprince","id":3979966,"avatar_url":"https://avatars.githubusercontent.com/u/3979966?","gravatar_id":"270620414be9cdf8eba71ccb01fe0bb3","url":"https://api.github.com/users/ghisprince","html_url":"https://github.com/ghisprince","followers_url":"https://api.github.com/users/ghisprince/followers","following_url":"https://api.github.com/users/ghisprince/following{/other_user}","gists_url":"https://api.github.com/users/ghisprince/gists{/gist_id}","starred_url":"https://api.github.com/users/ghisprince/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghisprince/subscriptions","organizations_url":"https://api.github.com/users/ghisprince/orgs","repos_url":"https://api.github.com/users/ghisprince/repos","events_url":"https://api.github.com/users/ghisprince/events{/privacy}","received_events_url":"https://api.github.com/users/ghisprince/received_events","type":"User","site_admin":false},"repo":{"id":21265451,"name":"stravalib","full_name":"ghisprince/stravalib","owner":{"login":"ghisprince","id":3979966,"avatar_url":"https://avatars.githubusercontent.com/u/3979966?","gravatar_id":"270620414be9cdf8eba71ccb01fe0bb3","url":"https://api.github.com/users/ghisprince","html_url":"https://github.com/ghisprince","followers_url":"https://api.github.com/users/ghisprince/followers","following_url":"https://api.github.com/users/ghisprince/following{/other_user}","gists_url":"https://api.github.com/users/ghisprince/gists{/gist_id}","starred_url":"https://api.github.com/users/ghisprince/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghisprince/subscriptions","organizations_url":"https://api.github.com/users/ghisprince/orgs","repos_url":"https://api.github.com/users/ghisprince/repos","events_url":"https://api.github.com/users/ghisprince/events{/privacy}","received_events_url":"https://api.github.com/users/ghisprince/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ghisprince/stravalib","description":"Library to provide simple client interface to Strava's REST API (v3).","fork":true,"url":"https://api.github.com/repos/ghisprince/stravalib","forks_url":"https://api.github.com/repos/ghisprince/stravalib/forks","keys_url":"https://api.github.com/repos/ghisprince/stravalib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ghisprince/stravalib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ghisprince/stravalib/teams","hooks_url":"https://api.github.com/repos/ghisprince/stravalib/hooks","issue_events_url":"https://api.github.com/repos/ghisprince/stravalib/issues/events{/number}","events_url":"https://api.github.com/repos/ghisprince/stravalib/events","assignees_url":"https://api.github.com/repos/ghisprince/stravalib/assignees{/user}","branches_url":"https://api.github.com/repos/ghisprince/stravalib/branches{/branch}","tags_url":"https://api.github.com/repos/ghisprince/stravalib/tags","blobs_url":"https://api.github.com/repos/ghisprince/stravalib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ghisprince/stravalib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ghisprince/stravalib/git/refs{/sha}","trees_url":"https://api.github.com/repos/ghisprince/stravalib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ghisprince/stravalib/statuses/{sha}","languages_url":"https://api.github.com/repos/ghisprince/stravalib/languages","stargazers_url":"https://api.github.com/repos/ghisprince/stravalib/stargazers","contributors_url":"https://api.github.com/repos/ghisprince/stravalib/contributors","subscribers_url":"https://api.github.com/repos/ghisprince/stravalib/subscribers","subscription_url":"https://api.github.com/repos/ghisprince/stravalib/subscription","commits_url":"https://api.github.com/repos/ghisprince/stravalib/commits{/sha}","git_commits_url":"https://api.github.com/repos/ghisprince/stravalib/git/commits{/sha}","comments_url":"https://api.github.com/repos/ghisprince/stravalib/comments{/number}","issue_comment_url":"https://api.github.com/repos/ghisprince/stravalib/issues/comments/{number}","contents_url":"https://api.github.com/repos/ghisprince/stravalib/contents/{+path}","compare_url":"https://api.github.com/repos/ghisprince/stravalib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ghisprince/stravalib/merges","archive_url":"https://api.github.com/repos/ghisprince/stravalib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ghisprince/stravalib/downloads","issues_url":"https://api.github.com/repos/ghisprince/stravalib/issues{/number}","pulls_url":"https://api.github.com/repos/ghisprince/stravalib/pulls{/number}","milestones_url":"https://api.github.com/repos/ghisprince/stravalib/milestones{/number}","notifications_url":"https://api.github.com/repos/ghisprince/stravalib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ghisprince/stravalib/labels{/name}","releases_url":"https://api.github.com/repos/ghisprince/stravalib/releases{/id}","created_at":"2014-06-27T05:50:47Z","updated_at":"2014-06-24T15:47:46Z","pushed_at":"2014-07-13T04:50:42Z","git_url":"git://github.com/ghisprince/stravalib.git","ssh_url":"git@github.com:ghisprince/stravalib.git","clone_url":"https://github.com/ghisprince/stravalib.git","svn_url":"https://github.com/ghisprince/stravalib","homepage":"http://pythonhosted.org/stravalib/","size":484,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hozn:master","ref":"master","sha":"50457fec4bbc0109037c4893c70137a634b3e342","user":{"login":"hozn","id":391939,"avatar_url":"https://avatars.githubusercontent.com/u/391939?","gravatar_id":"2c32b52f6d7c057f0c54afd069eeb98f","url":"https://api.github.com/users/hozn","html_url":"https://github.com/hozn","followers_url":"https://api.github.com/users/hozn/followers","following_url":"https://api.github.com/users/hozn/following{/other_user}","gists_url":"https://api.github.com/users/hozn/gists{/gist_id}","starred_url":"https://api.github.com/users/hozn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hozn/subscriptions","organizations_url":"https://api.github.com/users/hozn/orgs","repos_url":"https://api.github.com/users/hozn/repos","events_url":"https://api.github.com/users/hozn/events{/privacy}","received_events_url":"https://api.github.com/users/hozn/received_events","type":"User","site_admin":false},"repo":{"id":8828908,"name":"stravalib","full_name":"hozn/stravalib","owner":{"login":"hozn","id":391939,"avatar_url":"https://avatars.githubusercontent.com/u/391939?","gravatar_id":"2c32b52f6d7c057f0c54afd069eeb98f","url":"https://api.github.com/users/hozn","html_url":"https://github.com/hozn","followers_url":"https://api.github.com/users/hozn/followers","following_url":"https://api.github.com/users/hozn/following{/other_user}","gists_url":"https://api.github.com/users/hozn/gists{/gist_id}","starred_url":"https://api.github.com/users/hozn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hozn/subscriptions","organizations_url":"https://api.github.com/users/hozn/orgs","repos_url":"https://api.github.com/users/hozn/repos","events_url":"https://api.github.com/users/hozn/events{/privacy}","received_events_url":"https://api.github.com/users/hozn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hozn/stravalib","description":"Library to provide simple client interface to Strava's REST API (v3).","fork":false,"url":"https://api.github.com/repos/hozn/stravalib","forks_url":"https://api.github.com/repos/hozn/stravalib/forks","keys_url":"https://api.github.com/repos/hozn/stravalib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hozn/stravalib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hozn/stravalib/teams","hooks_url":"https://api.github.com/repos/hozn/stravalib/hooks","issue_events_url":"https://api.github.com/repos/hozn/stravalib/issues/events{/number}","events_url":"https://api.github.com/repos/hozn/stravalib/events","assignees_url":"https://api.github.com/repos/hozn/stravalib/assignees{/user}","branches_url":"https://api.github.com/repos/hozn/stravalib/branches{/branch}","tags_url":"https://api.github.com/repos/hozn/stravalib/tags","blobs_url":"https://api.github.com/repos/hozn/stravalib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hozn/stravalib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hozn/stravalib/git/refs{/sha}","trees_url":"https://api.github.com/repos/hozn/stravalib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hozn/stravalib/statuses/{sha}","languages_url":"https://api.github.com/repos/hozn/stravalib/languages","stargazers_url":"https://api.github.com/repos/hozn/stravalib/stargazers","contributors_url":"https://api.github.com/repos/hozn/stravalib/contributors","subscribers_url":"https://api.github.com/repos/hozn/stravalib/subscribers","subscription_url":"https://api.github.com/repos/hozn/stravalib/subscription","commits_url":"https://api.github.com/repos/hozn/stravalib/commits{/sha}","git_commits_url":"https://api.github.com/repos/hozn/stravalib/git/commits{/sha}","comments_url":"https://api.github.com/repos/hozn/stravalib/comments{/number}","issue_comment_url":"https://api.github.com/repos/hozn/stravalib/issues/comments/{number}","contents_url":"https://api.github.com/repos/hozn/stravalib/contents/{+path}","compare_url":"https://api.github.com/repos/hozn/stravalib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hozn/stravalib/merges","archive_url":"https://api.github.com/repos/hozn/stravalib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hozn/stravalib/downloads","issues_url":"https://api.github.com/repos/hozn/stravalib/issues{/number}","pulls_url":"https://api.github.com/repos/hozn/stravalib/pulls{/number}","milestones_url":"https://api.github.com/repos/hozn/stravalib/milestones{/number}","notifications_url":"https://api.github.com/repos/hozn/stravalib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hozn/stravalib/labels{/name}","releases_url":"https://api.github.com/repos/hozn/stravalib/releases{/id}","created_at":"2013-03-17T02:48:54Z","updated_at":"2014-07-13T11:08:39Z","pushed_at":"2014-07-13T17:58:16Z","git_url":"git://github.com/hozn/stravalib.git","ssh_url":"git@github.com:hozn/stravalib.git","clone_url":"https://github.com/hozn/stravalib.git","svn_url":"https://github.com/hozn/stravalib","homepage":"http://pythonhosted.org/stravalib/","size":663,"stargazers_count":38,"watchers_count":38,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":10,"mirror_url":null,"open_issues_count":7,"forks":10,"open_issues":7,"watchers":38,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hozn/stravalib/pulls/22"},"html":{"href":"https://github.com/hozn/stravalib/pull/22"},"issue":{"href":"https://api.github.com/repos/hozn/stravalib/issues/22"},"comments":{"href":"https://api.github.com/repos/hozn/stravalib/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/hozn/stravalib/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/hozn/stravalib/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/hozn/stravalib/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/hozn/stravalib/statuses/94f876e4202f01080fc680bd782020a3b040c78e"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"commits":9,"additions":278,"deletions":22,"changed_files":4}}