GitHub PullRequestReviewCommentEvent at 2014-09-04 12:34:08
Repository: php-src
Actor: datibbaw
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/php/php-src/pulls/comments/17110109","id":17110109,"diff_hunk":"@@ -2174,6 +2184,31 @@ PHP_FUNCTION(dom_document_save_html)\n \t\t\tRETVAL_FALSE;\n \t\t}\n \t\txmlBufferFree(buf);\n+\t} else if (type == 2) {\n+\t\tintern = Z_DOMOBJ_P(nodep);\n+\t\tobjmap = (dom_nnodemap_object *)intern->ptr;\n+\t\tnode = dom_object_get_node(objmap->baseobj);\n+\n+\t\tbuf = xmlBufferCreate();\n+\t\tif (!buf) {\n+\t\t\tphp_error_docref(NULL TSRMLS_CC, E_WARNING, \"Could not fetch buffer\");\n+\t\t\tRETURN_FALSE;\n+\t\t}\n+\n+\t\tif (node && node->children) {\n+\t\t\tnode = node->children;\n+\n+\t\t\twhile (node = xmlNextElementSibling(node)) {\n+\t\t\t\tsize += htmlNodeDump(buf, NULL, node);\n+\t\t\t}\n+\t\t}\n+\n+\t\tif (size == -1) {\n+\t\t\tRETVAL_FALSE;\n+\t\t} else {\n+\t\t\tmem = (xmlChar*) xmlBufferContent(buf);\n+\t\t\tRETVAL_STRINGL((const char*) mem, size);\n+\t\t}","path":"ext/dom/document.c","position":65,"original_position":65,"commit_id":"8bf77f69cffce824648ca4cacc86862c6ec8c8d2","original_commit_id":"8bf77f69cffce824648ca4cacc86862c6ec8c8d2","user":{"login":"datibbaw","id":87972,"avatar_url":"https://avatars.githubusercontent.com/u/87972?v=2","gravatar_id":"348de906e0efe215cc50ae7117044c03","url":"https://api.github.com/users/datibbaw","html_url":"https://github.com/datibbaw","followers_url":"https://api.github.com/users/datibbaw/followers","following_url":"https://api.github.com/users/datibbaw/following{/other_user}","gists_url":"https://api.github.com/users/datibbaw/gists{/gist_id}","starred_url":"https://api.github.com/users/datibbaw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datibbaw/subscriptions","organizations_url":"https://api.github.com/users/datibbaw/orgs","repos_url":"https://api.github.com/users/datibbaw/repos","events_url":"https://api.github.com/users/datibbaw/events{/privacy}","received_events_url":"https://api.github.com/users/datibbaw/received_events","type":"User","site_admin":false},"body":"We should `xmlBufferFree(buf);` here.","created_at":"2014-09-04T12:34:08Z","updated_at":"2014-09-04T12:34:08Z","html_url":"https://github.com/php/php-src/pull/800#discussion_r17110109","pull_request_url":"https://api.github.com/repos/php/php-src/pulls/800","_links":{"self":{"href":"https://api.github.com/repos/php/php-src/pulls/comments/17110109"},"html":{"href":"https://github.com/php/php-src/pull/800#discussion_r17110109"},"pull_request":{"href":"https://api.github.com/repos/php/php-src/pulls/800"}}},"pull_request":{"url":"https://api.github.com/repos/php/php-src/pulls/800","id":20665844,"html_url":"https://github.com/php/php-src/pull/800","diff_url":"https://github.com/php/php-src/pull/800.diff","patch_url":"https://github.com/php/php-src/pull/800.patch","issue_url":"https://api.github.com/repos/php/php-src/issues/800","number":800,"state":"open","locked":false,"title":"Feature Request 67948","user":{"login":"bor0","id":1620929,"avatar_url":"https://avatars.githubusercontent.com/u/1620929?v=2","gravatar_id":"da41badf1bf65b8e0290737c4d707dd4","url":"https://api.github.com/users/bor0","html_url":"https://github.com/bor0","followers_url":"https://api.github.com/users/bor0/followers","following_url":"https://api.github.com/users/bor0/following{/other_user}","gists_url":"https://api.github.com/users/bor0/gists{/gist_id}","starred_url":"https://api.github.com/users/bor0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bor0/subscriptions","organizations_url":"https://api.github.com/users/bor0/orgs","repos_url":"https://api.github.com/users/bor0/repos","events_url":"https://api.github.com/users/bor0/events{/privacy}","received_events_url":"https://api.github.com/users/bor0/received_events","type":"User","site_admin":false},"body":"https://bugs.php.net/bug.php?id=67948\r\n\r\nAdd handling for DOMNodeList parameter as well","created_at":"2014-09-03T09:45:48Z","updated_at":"2014-09-04T12:34:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d4efde917517aa5a534fa9c88f6626328543be1f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/php/php-src/pulls/800/commits","review_comments_url":"https://api.github.com/repos/php/php-src/pulls/800/comments","review_comment_url":"https://api.github.com/repos/php/php-src/pulls/comments/{number}","comments_url":"https://api.github.com/repos/php/php-src/issues/800/comments","statuses_url":"https://api.github.com/repos/php/php-src/statuses/8bf77f69cffce824648ca4cacc86862c6ec8c8d2","head":{"label":"bor0:bug67948","ref":"bug67948","sha":"8bf77f69cffce824648ca4cacc86862c6ec8c8d2","user":{"login":"bor0","id":1620929,"avatar_url":"https://avatars.githubusercontent.com/u/1620929?v=2","gravatar_id":"da41badf1bf65b8e0290737c4d707dd4","url":"https://api.github.com/users/bor0","html_url":"https://github.com/bor0","followers_url":"https://api.github.com/users/bor0/followers","following_url":"https://api.github.com/users/bor0/following{/other_user}","gists_url":"https://api.github.com/users/bor0/gists{/gist_id}","starred_url":"https://api.github.com/users/bor0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bor0/subscriptions","organizations_url":"https://api.github.com/users/bor0/orgs","repos_url":"https://api.github.com/users/bor0/repos","events_url":"https://api.github.com/users/bor0/events{/privacy}","received_events_url":"https://api.github.com/users/bor0/received_events","type":"User","site_admin":false},"repo":{"id":12768271,"name":"php-src","full_name":"bor0/php-src","owner":{"login":"bor0","id":1620929,"avatar_url":"https://avatars.githubusercontent.com/u/1620929?v=2","gravatar_id":"da41badf1bf65b8e0290737c4d707dd4","url":"https://api.github.com/users/bor0","html_url":"https://github.com/bor0","followers_url":"https://api.github.com/users/bor0/followers","following_url":"https://api.github.com/users/bor0/following{/other_user}","gists_url":"https://api.github.com/users/bor0/gists{/gist_id}","starred_url":"https://api.github.com/users/bor0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bor0/subscriptions","organizations_url":"https://api.github.com/users/bor0/orgs","repos_url":"https://api.github.com/users/bor0/repos","events_url":"https://api.github.com/users/bor0/events{/privacy}","received_events_url":"https://api.github.com/users/bor0/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bor0/php-src","description":"The PHP Interpreter","fork":true,"url":"https://api.github.com/repos/bor0/php-src","forks_url":"https://api.github.com/repos/bor0/php-src/forks","keys_url":"https://api.github.com/repos/bor0/php-src/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bor0/php-src/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bor0/php-src/teams","hooks_url":"https://api.github.com/repos/bor0/php-src/hooks","issue_events_url":"https://api.github.com/repos/bor0/php-src/issues/events{/number}","events_url":"https://api.github.com/repos/bor0/php-src/events","assignees_url":"https://api.github.com/repos/bor0/php-src/assignees{/user}","branches_url":"https://api.github.com/repos/bor0/php-src/branches{/branch}","tags_url":"https://api.github.com/repos/bor0/php-src/tags","blobs_url":"https://api.github.com/repos/bor0/php-src/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bor0/php-src/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bor0/php-src/git/refs{/sha}","trees_url":"https://api.github.com/repos/bor0/php-src/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bor0/php-src/statuses/{sha}","languages_url":"https://api.github.com/repos/bor0/php-src/languages","stargazers_url":"https://api.github.com/repos/bor0/php-src/stargazers","contributors_url":"https://api.github.com/repos/bor0/php-src/contributors","subscribers_url":"https://api.github.com/repos/bor0/php-src/subscribers","subscription_url":"https://api.github.com/repos/bor0/php-src/subscription","commits_url":"https://api.github.com/repos/bor0/php-src/commits{/sha}","git_commits_url":"https://api.github.com/repos/bor0/php-src/git/commits{/sha}","comments_url":"https://api.github.com/repos/bor0/php-src/comments{/number}","issue_comment_url":"https://api.github.com/repos/bor0/php-src/issues/comments/{number}","contents_url":"https://api.github.com/repos/bor0/php-src/contents/{+path}","compare_url":"https://api.github.com/repos/bor0/php-src/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bor0/php-src/merges","archive_url":"https://api.github.com/repos/bor0/php-src/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bor0/php-src/downloads","issues_url":"https://api.github.com/repos/bor0/php-src/issues{/number}","pulls_url":"https://api.github.com/repos/bor0/php-src/pulls{/number}","milestones_url":"https://api.github.com/repos/bor0/php-src/milestones{/number}","notifications_url":"https://api.github.com/repos/bor0/php-src/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bor0/php-src/labels{/name}","releases_url":"https://api.github.com/repos/bor0/php-src/releases{/id}","created_at":"2013-09-11T21:31:13Z","updated_at":"2014-07-30T23:15:50Z","pushed_at":"2014-09-04T12:24:52Z","git_url":"git://github.com/bor0/php-src.git","ssh_url":"git@github.com:bor0/php-src.git","clone_url":"https://github.com/bor0/php-src.git","svn_url":"https://github.com/bor0/php-src","homepage":"http://www.php.net","size":184840,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"php:master","ref":"master","sha":"92164f6b7bceb70645d2d5224f5209ff4d417e9b","user":{"login":"php","id":25158,"avatar_url":"https://avatars.githubusercontent.com/u/25158?v=2","gravatar_id":"42bce1cfd9c0fb087bffb79ad979de0f","url":"https://api.github.com/users/php","html_url":"https://github.com/php","followers_url":"https://api.github.com/users/php/followers","following_url":"https://api.github.com/users/php/following{/other_user}","gists_url":"https://api.github.com/users/php/gists{/gist_id}","starred_url":"https://api.github.com/users/php/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/php/subscriptions","organizations_url":"https://api.github.com/users/php/orgs","repos_url":"https://api.github.com/users/php/repos","events_url":"https://api.github.com/users/php/events{/privacy}","received_events_url":"https://api.github.com/users/php/received_events","type":"Organization","site_admin":false},"repo":{"id":1903522,"name":"php-src","full_name":"php/php-src","owner":{"login":"php","id":25158,"avatar_url":"https://avatars.githubusercontent.com/u/25158?v=2","gravatar_id":"42bce1cfd9c0fb087bffb79ad979de0f","url":"https://api.github.com/users/php","html_url":"https://github.com/php","followers_url":"https://api.github.com/users/php/followers","following_url":"https://api.github.com/users/php/following{/other_user}","gists_url":"https://api.github.com/users/php/gists{/gist_id}","starred_url":"https://api.github.com/users/php/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/php/subscriptions","organizations_url":"https://api.github.com/users/php/orgs","repos_url":"https://api.github.com/users/php/repos","events_url":"https://api.github.com/users/php/events{/privacy}","received_events_url":"https://api.github.com/users/php/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/php/php-src","description":"The PHP Interpreter","fork":false,"url":"https://api.github.com/repos/php/php-src","forks_url":"https://api.github.com/repos/php/php-src/forks","keys_url":"https://api.github.com/repos/php/php-src/keys{/key_id}","collaborators_url":"https://api.github.com/repos/php/php-src/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/php/php-src/teams","hooks_url":"https://api.github.com/repos/php/php-src/hooks","issue_events_url":"https://api.github.com/repos/php/php-src/issues/events{/number}","events_url":"https://api.github.com/repos/php/php-src/events","assignees_url":"https://api.github.com/repos/php/php-src/assignees{/user}","branches_url":"https://api.github.com/repos/php/php-src/branches{/branch}","tags_url":"https://api.github.com/repos/php/php-src/tags","blobs_url":"https://api.github.com/repos/php/php-src/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/php/php-src/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/php/php-src/git/refs{/sha}","trees_url":"https://api.github.com/repos/php/php-src/git/trees{/sha}","statuses_url":"https://api.github.com/repos/php/php-src/statuses/{sha}","languages_url":"https://api.github.com/repos/php/php-src/languages","stargazers_url":"https://api.github.com/repos/php/php-src/stargazers","contributors_url":"https://api.github.com/repos/php/php-src/contributors","subscribers_url":"https://api.github.com/repos/php/php-src/subscribers","subscription_url":"https://api.github.com/repos/php/php-src/subscription","commits_url":"https://api.github.com/repos/php/php-src/commits{/sha}","git_commits_url":"https://api.github.com/repos/php/php-src/git/commits{/sha}","comments_url":"https://api.github.com/repos/php/php-src/comments{/number}","issue_comment_url":"https://api.github.com/repos/php/php-src/issues/comments/{number}","contents_url":"https://api.github.com/repos/php/php-src/contents/{+path}","compare_url":"https://api.github.com/repos/php/php-src/compare/{base}...{head}","merges_url":"https://api.github.com/repos/php/php-src/merges","archive_url":"https://api.github.com/repos/php/php-src/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/php/php-src/downloads","issues_url":"https://api.github.com/repos/php/php-src/issues{/number}","pulls_url":"https://api.github.com/repos/php/php-src/pulls{/number}","milestones_url":"https://api.github.com/repos/php/php-src/milestones{/number}","notifications_url":"https://api.github.com/repos/php/php-src/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/php/php-src/labels{/name}","releases_url":"https://api.github.com/repos/php/php-src/releases{/id}","created_at":"2011-06-16T01:52:25Z","updated_at":"2014-09-04T06:53:32Z","pushed_at":"2014-09-04T10:06:53Z","git_url":"git://github.com/php/php-src.git","ssh_url":"git@github.com:php/php-src.git","clone_url":"https://github.com/php/php-src.git","svn_url":"https://github.com/php/php-src","homepage":"http://www.php.net","size":1215219,"stargazers_count":4656,"watchers_count":4656,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":1600,"mirror_url":null,"open_issues_count":150,"forks":1600,"open_issues":150,"watchers":4656,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/php/php-src/pulls/800"},"html":{"href":"https://github.com/php/php-src/pull/800"},"issue":{"href":"https://api.github.com/repos/php/php-src/issues/800"},"comments":{"href":"https://api.github.com/repos/php/php-src/issues/800/comments"},"review_comments":{"href":"https://api.github.com/repos/php/php-src/pulls/800/comments"},"review_comment":{"href":"https://api.github.com/repos/php/php-src/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/php/php-src/pulls/800/commits"},"statuses":{"href":"https://api.github.com/repos/php/php-src/statuses/8bf77f69cffce824648ca4cacc86862c6ec8c8d2"}}}}