GitHub PushEvent at 2014-05-23 15:11:21
Repository: xen-api
Actor: djs55
Payload: {"shas":[["42224cd1a5b8e37179fcc292c1273df9f3547df2","a0992b7f1f450b4c7716d34b81a2d6f0877ae11a@citrix.com","CA-135187: Filter out restricted device_config keys\n\nA commit fixing SCTX-1616 now causes PBD create to throw an error if given\na device_config with the SRmaster key in (internal use only).\n\nHowever, if this happened to exist from a time when this was not forbidden then\npool join will fail since the slave uses the device_config from the master's\nPBD record which might contain this key.\n\nThis commit filters this key out in the pool join code-path.\n\nSigned-off-by: Si Beaumont <simon.beaumont@citrix.com>","Si Beaumont",false],["879261e017aaf6157dc07ce2c537e520d8d57f42","a0992b7f1f450b4c7716d34b81a2d6f0877ae11a@citrix.com","CA-135189: Remove restricted device_config on upgrade\n\nThe SRmaster key is restricted for internal use only. There are precautions\ntaken against creating PBDs with such a key in the device config now but we\nshould purge the database of any such keys created before these measures were\nin place.\n\nSigned-off-by: Si Beaumont <simon.beaumont@citrix.com>","Si Beaumont",false],["b434f457ca8ff586f82627031027e9ff9b12f14e","e7e3380887a8f95cc9dc4f0d51dedc7e849a287a@citrix.com","s/Stringext/Xstringext/g\n\nSigned-off-by: Jon Ludlam <jonathan.ludlam@citrix.com>","Jon Ludlam",false],["2c1a1aa22a644a86a7bbb680e18df8984422eb87","e7e3380887a8f95cc9dc4f0d51dedc7e849a287a@eu.citrix.com","Merge pull request #1742 from jonludlam/great_stringext_rename\n\ns/Stringext/Xstringext/g","Jon Ludlam",false],["c200a91e5ea4ae9ec543b0249cd23249238c8c81","a0992b7f1f450b4c7716d34b81a2d6f0877ae11a@citrix.com","CA-134765: Fix race condition in database layer\n\nThe read_records_where function in the database layer (used by the\nget_all_records and get_all_records_where APIs) was reading the database\nmultiple times by calling find_refs_with_filter[1] to get the refs that matched\nthe query and then calling read_record[2] for each of these refs.\n\nThis violates point #2 of the  locking strategy stated at the top of the module\nthat read only functions must only call get_database once to ensure they\noperate on a consistent snapshot.\n\nSince [1] and [2] make get_database calls the get_all_records* functions make\nn+1 calls to get_database for a table with n records. Because of this, deleting\na record during a get_all_records_where will result in a DBCache_NotFound\nexception with parameter \"missing row\".\n\nThis commits adds internal variants of functions [1] and [2] that take\nan actual instance of Database.t rather than a Db_ref.t which is a Database.t\nref ref.\n\nSigned-off-by: Si Beaumont <simon.beaumont@citrix.com>","Si Beaumont",false],["58458cc8e0599c90199cfce3c90473558a4ca0f6","e7e3380887a8f95cc9dc4f0d51dedc7e849a287a@eu.citrix.com","Merge pull request #1745 from simonjbeaumont/ca-134675\n\nCA-134765: Fix race condition in database layer","Jon Ludlam",false],["f16319d0d5d811a0e9cd6ff84b5cfddee6f16c00","37b74501daa612e48fea94f9846ed4ddeb6a8f07@citrix.com","Merge pull request #1734 from simonjbeaumont/sctx-1616\n\nCA-135187: Filter out restricted device_config keys","John Else",false],["6141b46865ee111bab106e8981122695b872da8f","37b74501daa612e48fea94f9846ed4ddeb6a8f07@citrix.com","Merge pull request #1736 from simonjbeaumont/ca-135189\n\nCA-135189: Remove restricted device_config on upgrade","John Else",false],["e7e5faa759d48bc5ef2b15b7e65a38d6da70ef6b","e7e3380887a8f95cc9dc4f0d51dedc7e849a287a@citrix.com","Add a test for event inject\n\nSigned-off-by: Jon Ludlam <jonathan.ludlam@citrix.com>","Jon Ludlam",false],["bedca96adfcfdadd2e2e8c2c8b5158b6e5a115bf","e7e3380887a8f95cc9dc4f0d51dedc7e849a287a@citrix.com","Fix a defect where event.from can go into a tight loop\n\nThis puts the subscription check into the inner loop\nof the event.from rather than when gathering the\nsnapshots. This fixes a problem where xapi would go into\na tight loop when subscribed to a particular objects\nevents and a different object of the same class was\nupdated. This tight loop also wouldn't perform the\nsession check so logging out the session wouldn't cause\nthe call to return.\n\nSigned-off-by: Jon Ludlam <jonathan.ludlam@citrix.com>","Jon Ludlam",false],["e221b0d0194f2a002e269423384c471603480445","e7e3380887a8f95cc9dc4f0d51dedc7e849a287a@citrix.com","If we're not using the message switch, there can be only one xenopsd.\n\nSigned-off-by: Jon Ludlam <jonathan.ludlam@citrix.com>","Jon Ludlam",false],["25208e2d08f2d589ce11b744ad70b45c57b5d72f","a0992b7f1f450b4c7716d34b81a2d6f0877ae11a@citrix.com","Ignore new artifacts of OUnit2 test runs\n\nSigned-off-by: Si Beaumont <simon.beaumont@citrix.com>","Si Beaumont",false],["860eeff4cff937bb835acc1fd66458716a9ef819","e7e3380887a8f95cc9dc4f0d51dedc7e849a287a@eu.citrix.com","Merge pull request #1748 from jonludlam/event-problems\n\nEvent problems","Jon Ludlam",false],["c56bb8c04f1c7d31d839e32d252bbabfcbc463fc","e7e3380887a8f95cc9dc4f0d51dedc7e849a287a@eu.citrix.com","Merge pull request #1749 from simonjbeaumont/ignore-ounit-cruft\n\nIgnore new artifacts of OUnit2 test runs","Jon Ludlam",false],["c63a71ce7c0e7d916cb102680b2a1bdfd51ba6d5","a0992b7f1f450b4c7716d34b81a2d6f0877ae11a@citrix.com","Convert test suite to OUnit2 before running\n\nThis is needed since running an OUnit 1.x test suite using OUnit2 installed\ndoes not return non-zero exit code even on failure or error.\n\nConverting the suite at this point is desirable in favour of converting all the\ntests because we can keep writing tests using OUnit 1.x style, making them\nbackportable to old build environments without OUnit2 (and without this patch).\n\nSigned-off-by: Si Beaumont <simon.beaumont@citrix.com>","Si Beaumont",false],["7f8e276b3a5ce2ea48b2d669797bb5c474d5045e","a0992b7f1f450b4c7716d34b81a2d6f0877ae11a@citrix.com","Unit tests: Don't attempt to talk to squeezed\n\nSigned-off-by: Si Beaumont <simon.beaumont@citrix.com>","Si Beaumont",false],["4653fef3833e5cab512337c00a4271b0c2d963c1","a0992b7f1f450b4c7716d34b81a2d6f0877ae11a@citrix.com","Disable test case that uses API call\n\nThe mock API feature is not quite feature-full to fully mock API calls as this\ntest case attempts to make use of. There is a Helpers.call_api_functions\n(indirectly) in the codepath which fails since the mock database created does\nnot persist as far as the server that handles the API call.\n\nWe'll disable this test for now which is error-ing (not failing) until we have\ntime to properly provide a mock API.\n\nSigned-off-by: Si Beaumont <simon.beaumont@citrix.com>","Si Beaumont",false],["c56f9556d5ab7b1499a3aa0ac5530e236ee2c2f2","37b74501daa612e48fea94f9846ed4ddeb6a8f07@citrix.com","Merge pull request #1751 from simonjbeaumont/fix-ounit-tests\n\nConvert test suite to OUnit2 before running","John Else",false],["d535b8a4cf5b33448b4a3c6b6c37bcb4a7108be1","e7e3380887a8f95cc9dc4f0d51dedc7e849a287a@citrix.com","Remove last use of Re_str from xapi\n\nSigned-off-by: Jon Ludlam <jonathan.ludlam@citrix.com>","Jon Ludlam",false],["a44f859ac14e294ecfd59332e15d6be6f1f04f6a","e7e3380887a8f95cc9dc4f0d51dedc7e849a287a@eu.citrix.com","Merge pull request #1766 from jonludlam/remove_re_str\n\nRemove last use of Re_str from xapi","Jon Ludlam",false]],"size":22,"ref":"refs/heads/smapiv2","head":"c16dffb9dc7355c3881a391336a78fa164325bc3"}