GitHub PullRequestEvent at 2014-04-29 22:12:48
Repository: winjs
Actor: jseanxu
Payload: {"action":"opened","number":202,"pull_request":{"url":"https://api.github.com/repos/winjs/winjs/pulls/202","id":15315977,"html_url":"https://github.com/winjs/winjs/pull/202","diff_url":"https://github.com/winjs/winjs/pull/202.diff","patch_url":"https://github.com/winjs/winjs/pull/202.patch","issue_url":"https://api.github.com/repos/winjs/winjs/issues/202","number":202,"state":"open","title":"Jseanxu/fix pivot without pivotitems","user":{"login":"jseanxu","id":6741017,"avatar_url":"https://avatars.githubusercontent.com/u/6741017?","gravatar_id":"9cc87815a184c587806d623e902eaf2e","url":"https://api.github.com/users/jseanxu","html_url":"https://github.com/jseanxu","followers_url":"https://api.github.com/users/jseanxu/followers","following_url":"https://api.github.com/users/jseanxu/following{/other_user}","gists_url":"https://api.github.com/users/jseanxu/gists{/gist_id}","starred_url":"https://api.github.com/users/jseanxu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jseanxu/subscriptions","organizations_url":"https://api.github.com/users/jseanxu/orgs","repos_url":"https://api.github.com/users/jseanxu/repos","events_url":"https://api.github.com/users/jseanxu/events{/privacy}","received_events_url":"https://api.github.com/users/jseanxu/received_events","type":"User","site_admin":false},"body":"The issue is that when there are no PivotItems in the constructor path, the viewport is not recentered because recentering is part of loading an item. The fix here is to always recenter on the constructor path once. Fixes #17.","created_at":"2014-04-29T22:12:48Z","updated_at":"2014-04-29T22:12:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/winjs/winjs/pulls/202/commits","review_comments_url":"https://api.github.com/repos/winjs/winjs/pulls/202/comments","review_comment_url":"https://api.github.com/repos/winjs/winjs/pulls/comments/{number}","comments_url":"https://api.github.com/repos/winjs/winjs/issues/202/comments","statuses_url":"https://api.github.com/repos/winjs/winjs/statuses/b3fb941daba95b5ff68793e170c9f6f15d73d553","head":{"label":"winjs:jseanxu/fix-pivot-without-pivotitems","ref":"jseanxu/fix-pivot-without-pivotitems","sha":"b3fb941daba95b5ff68793e170c9f6f15d73d553","user":{"login":"winjs","id":6923056,"avatar_url":"https://avatars.githubusercontent.com/u/6923056?","gravatar_id":null,"url":"https://api.github.com/users/winjs","html_url":"https://github.com/winjs","followers_url":"https://api.github.com/users/winjs/followers","following_url":"https://api.github.com/users/winjs/following{/other_user}","gists_url":"https://api.github.com/users/winjs/gists{/gist_id}","starred_url":"https://api.github.com/users/winjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/winjs/subscriptions","organizations_url":"https://api.github.com/users/winjs/orgs","repos_url":"https://api.github.com/users/winjs/repos","events_url":"https://api.github.com/users/winjs/events{/privacy}","received_events_url":"https://api.github.com/users/winjs/received_events","type":"Organization","site_admin":false},"repo":{"id":18102026,"name":"winjs","full_name":"winjs/winjs","owner":{"login":"winjs","id":6923056,"avatar_url":"https://avatars.githubusercontent.com/u/6923056?","gravatar_id":null,"url":"https://api.github.com/users/winjs","html_url":"https://github.com/winjs","followers_url":"https://api.github.com/users/winjs/followers","following_url":"https://api.github.com/users/winjs/following{/other_user}","gists_url":"https://api.github.com/users/winjs/gists{/gist_id}","starred_url":"https://api.github.com/users/winjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/winjs/subscriptions","organizations_url":"https://api.github.com/users/winjs/orgs","repos_url":"https://api.github.com/users/winjs/repos","events_url":"https://api.github.com/users/winjs/events{/privacy}","received_events_url":"https://api.github.com/users/winjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/winjs/winjs","description":"WinJS project by Microsoft Open Technologies","fork":false,"url":"https://api.github.com/repos/winjs/winjs","forks_url":"https://api.github.com/repos/winjs/winjs/forks","keys_url":"https://api.github.com/repos/winjs/winjs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/winjs/winjs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/winjs/winjs/teams","hooks_url":"https://api.github.com/repos/winjs/winjs/hooks","issue_events_url":"https://api.github.com/repos/winjs/winjs/issues/events{/number}","events_url":"https://api.github.com/repos/winjs/winjs/events","assignees_url":"https://api.github.com/repos/winjs/winjs/assignees{/user}","branches_url":"https://api.github.com/repos/winjs/winjs/branches{/branch}","tags_url":"https://api.github.com/repos/winjs/winjs/tags","blobs_url":"https://api.github.com/repos/winjs/winjs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/winjs/winjs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/winjs/winjs/git/refs{/sha}","trees_url":"https://api.github.com/repos/winjs/winjs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/winjs/winjs/statuses/{sha}","languages_url":"https://api.github.com/repos/winjs/winjs/languages","stargazers_url":"https://api.github.com/repos/winjs/winjs/stargazers","contributors_url":"https://api.github.com/repos/winjs/winjs/contributors","subscribers_url":"https://api.github.com/repos/winjs/winjs/subscribers","subscription_url":"https://api.github.com/repos/winjs/winjs/subscription","commits_url":"https://api.github.com/repos/winjs/winjs/commits{/sha}","git_commits_url":"https://api.github.com/repos/winjs/winjs/git/commits{/sha}","comments_url":"https://api.github.com/repos/winjs/winjs/comments{/number}","issue_comment_url":"https://api.github.com/repos/winjs/winjs/issues/comments/{number}","contents_url":"https://api.github.com/repos/winjs/winjs/contents/{+path}","compare_url":"https://api.github.com/repos/winjs/winjs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/winjs/winjs/merges","archive_url":"https://api.github.com/repos/winjs/winjs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/winjs/winjs/downloads","issues_url":"https://api.github.com/repos/winjs/winjs/issues{/number}","pulls_url":"https://api.github.com/repos/winjs/winjs/pulls{/number}","milestones_url":"https://api.github.com/repos/winjs/winjs/milestones{/number}","notifications_url":"https://api.github.com/repos/winjs/winjs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/winjs/winjs/labels{/name}","releases_url":"https://api.github.com/repos/winjs/winjs/releases{/id}","created_at":"2014-03-25T13:54:47Z","updated_at":"2014-04-29T22:12:48Z","pushed_at":"2014-04-29T22:09:14Z","git_url":"git://github.com/winjs/winjs.git","ssh_url":"git@github.com:winjs/winjs.git","clone_url":"https://github.com/winjs/winjs.git","svn_url":"https://github.com/winjs/winjs","homepage":"http://try.buildwinjs.com/","size":6877,"stargazers_count":2363,"watchers_count":2363,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":264,"mirror_url":null,"open_issues_count":88,"forks":264,"open_issues":88,"watchers":2363,"default_branch":"master"}},"base":{"label":"winjs:master","ref":"master","sha":"b1f26471726dc06f238f3d681255525fa2400e4d","user":{"login":"winjs","id":6923056,"avatar_url":"https://avatars.githubusercontent.com/u/6923056?","gravatar_id":null,"url":"https://api.github.com/users/winjs","html_url":"https://github.com/winjs","followers_url":"https://api.github.com/users/winjs/followers","following_url":"https://api.github.com/users/winjs/following{/other_user}","gists_url":"https://api.github.com/users/winjs/gists{/gist_id}","starred_url":"https://api.github.com/users/winjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/winjs/subscriptions","organizations_url":"https://api.github.com/users/winjs/orgs","repos_url":"https://api.github.com/users/winjs/repos","events_url":"https://api.github.com/users/winjs/events{/privacy}","received_events_url":"https://api.github.com/users/winjs/received_events","type":"Organization","site_admin":false},"repo":{"id":18102026,"name":"winjs","full_name":"winjs/winjs","owner":{"login":"winjs","id":6923056,"avatar_url":"https://avatars.githubusercontent.com/u/6923056?","gravatar_id":null,"url":"https://api.github.com/users/winjs","html_url":"https://github.com/winjs","followers_url":"https://api.github.com/users/winjs/followers","following_url":"https://api.github.com/users/winjs/following{/other_user}","gists_url":"https://api.github.com/users/winjs/gists{/gist_id}","starred_url":"https://api.github.com/users/winjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/winjs/subscriptions","organizations_url":"https://api.github.com/users/winjs/orgs","repos_url":"https://api.github.com/users/winjs/repos","events_url":"https://api.github.com/users/winjs/events{/privacy}","received_events_url":"https://api.github.com/users/winjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/winjs/winjs","description":"WinJS project by Microsoft Open Technologies","fork":false,"url":"https://api.github.com/repos/winjs/winjs","forks_url":"https://api.github.com/repos/winjs/winjs/forks","keys_url":"https://api.github.com/repos/winjs/winjs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/winjs/winjs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/winjs/winjs/teams","hooks_url":"https://api.github.com/repos/winjs/winjs/hooks","issue_events_url":"https://api.github.com/repos/winjs/winjs/issues/events{/number}","events_url":"https://api.github.com/repos/winjs/winjs/events","assignees_url":"https://api.github.com/repos/winjs/winjs/assignees{/user}","branches_url":"https://api.github.com/repos/winjs/winjs/branches{/branch}","tags_url":"https://api.github.com/repos/winjs/winjs/tags","blobs_url":"https://api.github.com/repos/winjs/winjs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/winjs/winjs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/winjs/winjs/git/refs{/sha}","trees_url":"https://api.github.com/repos/winjs/winjs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/winjs/winjs/statuses/{sha}","languages_url":"https://api.github.com/repos/winjs/winjs/languages","stargazers_url":"https://api.github.com/repos/winjs/winjs/stargazers","contributors_url":"https://api.github.com/repos/winjs/winjs/contributors","subscribers_url":"https://api.github.com/repos/winjs/winjs/subscribers","subscription_url":"https://api.github.com/repos/winjs/winjs/subscription","commits_url":"https://api.github.com/repos/winjs/winjs/commits{/sha}","git_commits_url":"https://api.github.com/repos/winjs/winjs/git/commits{/sha}","comments_url":"https://api.github.com/repos/winjs/winjs/comments{/number}","issue_comment_url":"https://api.github.com/repos/winjs/winjs/issues/comments/{number}","contents_url":"https://api.github.com/repos/winjs/winjs/contents/{+path}","compare_url":"https://api.github.com/repos/winjs/winjs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/winjs/winjs/merges","archive_url":"https://api.github.com/repos/winjs/winjs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/winjs/winjs/downloads","issues_url":"https://api.github.com/repos/winjs/winjs/issues{/number}","pulls_url":"https://api.github.com/repos/winjs/winjs/pulls{/number}","milestones_url":"https://api.github.com/repos/winjs/winjs/milestones{/number}","notifications_url":"https://api.github.com/repos/winjs/winjs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/winjs/winjs/labels{/name}","releases_url":"https://api.github.com/repos/winjs/winjs/releases{/id}","created_at":"2014-03-25T13:54:47Z","updated_at":"2014-04-29T22:12:48Z","pushed_at":"2014-04-29T22:09:14Z","git_url":"git://github.com/winjs/winjs.git","ssh_url":"git@github.com:winjs/winjs.git","clone_url":"https://github.com/winjs/winjs.git","svn_url":"https://github.com/winjs/winjs","homepage":"http://try.buildwinjs.com/","size":6877,"stargazers_count":2363,"watchers_count":2363,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":264,"mirror_url":null,"open_issues_count":88,"forks":264,"open_issues":88,"watchers":2363,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/winjs/winjs/pulls/202"},"html":{"href":"https://github.com/winjs/winjs/pull/202"},"issue":{"href":"https://api.github.com/repos/winjs/winjs/issues/202"},"comments":{"href":"https://api.github.com/repos/winjs/winjs/issues/202/comments"},"review_comments":{"href":"https://api.github.com/repos/winjs/winjs/pulls/202/comments"},"review_comment":{"href":"https://api.github.com/repos/winjs/winjs/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/winjs/winjs/pulls/202/commits"},"statuses":{"href":"https://api.github.com/repos/winjs/winjs/statuses/b3fb941daba95b5ff68793e170c9f6f15d73d553"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":16,"deletions":2,"changed_files":2}}