GitHub PullRequestReviewCommentEvent at 2014-12-10 21:19:02
Repository: dolphin
Actor: lioncash
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/21638113","id":21638113,"diff_hunk":"@@ -0,0 +1,29 @@\n+// Copyright 2013 Dolphin Emulator Project\n+// Licensed under GPLv2\n+// Refer to the license.txt file included.\n+\n+#pragma once\n+\n+#include \"Common/Thread.h\"\n+#include \"Core/HW/SI.h\"\n+\n+struct libusb_device_handle;\n+struct libusb_device_descriptor;\n+struct libusb_config_descriptor;\n+struct libusb_interface_descriptor;\n+struct libusb_endpoint_descriptor;\n+struct libusb_transfer;\n+","path":"Source/Core/Core/HW/SI_GCAdapter.h","position":16,"original_position":16,"commit_id":"6269b8c95e60732707c0386a2c9597b2782fd975","original_commit_id":"6269b8c95e60732707c0386a2c9597b2782fd975","user":{"login":"lioncash","id":712067,"avatar_url":"https://avatars.githubusercontent.com/u/712067?v=3","gravatar_id":"","url":"https://api.github.com/users/lioncash","html_url":"https://github.com/lioncash","followers_url":"https://api.github.com/users/lioncash/followers","following_url":"https://api.github.com/users/lioncash/following{/other_user}","gists_url":"https://api.github.com/users/lioncash/gists{/gist_id}","starred_url":"https://api.github.com/users/lioncash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lioncash/subscriptions","organizations_url":"https://api.github.com/users/lioncash/orgs","repos_url":"https://api.github.com/users/lioncash/repos","events_url":"https://api.github.com/users/lioncash/events{/privacy}","received_events_url":"https://api.github.com/users/lioncash/received_events","type":"User","site_admin":false},"body":"Why the forward declarations when they aren't used in the header?","created_at":"2014-12-10T21:19:02Z","updated_at":"2014-12-10T21:19:02Z","html_url":"https://github.com/dolphin-emu/dolphin/pull/1678#discussion_r21638113","pull_request_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/1678","_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/21638113"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/1678#discussion_r21638113"},"pull_request":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/1678"}}},"pull_request":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/1678","id":25744053,"html_url":"https://github.com/dolphin-emu/dolphin/pull/1678","diff_url":"https://github.com/dolphin-emu/dolphin/pull/1678.diff","patch_url":"https://github.com/dolphin-emu/dolphin/pull/1678.patch","issue_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/1678","number":1678,"state":"open","locked":false,"title":"Added GameCube Adapter support","user":{"login":"skidau","id":8612259,"avatar_url":"https://avatars.githubusercontent.com/u/8612259?v=3","gravatar_id":"","url":"https://api.github.com/users/skidau","html_url":"https://github.com/skidau","followers_url":"https://api.github.com/users/skidau/followers","following_url":"https://api.github.com/users/skidau/following{/other_user}","gists_url":"https://api.github.com/users/skidau/gists{/gist_id}","starred_url":"https://api.github.com/users/skidau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skidau/subscriptions","organizations_url":"https://api.github.com/users/skidau/orgs","repos_url":"https://api.github.com/users/skidau/repos","events_url":"https://api.github.com/users/skidau/events{/privacy}","received_events_url":"https://api.github.com/users/skidau/received_events","type":"User","site_admin":false},"body":"The libusb driver must be installed on the adapter (e.g. zadig can be used to install the driver in Windows).  GameCube pad controllers are supported and will override the current input device assigned to the port.  GameCube controller buttons are auto-configured and cannot be re-assigned.  Rumble is supported.  Hotplug is supported while playing a game.  If a controller is unplugged from the adapter, Dolphin will fallback to using the host input device on that port.  If a port on the adapter is unused, Dolphin will use the host input device for that port, allowing a mixture of host input devices and controllers connected to the adapter.\r\n\r\nThe adapter support can be disabled in the Controllers config if the OS driver is preferred (allowing the pad buttons to be reconfigured).\r\n\r\nOne adapter per system is supported.\r\n\r\nBongos, Wavebirds and DDR dance mats are untested.\r\n\r\nGC Keyboard, Steering Wheel, GBA and some dance mats are untested and unlikely to work.\r\n\r\nIf you have any of the above controllers, enable the log (View > Show Log Configuration and View > Show Log) and enable Warning verbosity, Write to Window and check the \"SerialInt\" Log Type.  The log will have a message like \"New device connected to Port 1 of Type: XX\" when the device is plugged into the adapter while playing a game.  Let me know what the XX is and we might be able to get some support for those controllers.\r\n\r\n","created_at":"2014-12-09T13:54:28Z","updated_at":"2014-12-10T21:19:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8c84c8006fe8d2840a098a26a9c24603b6216085","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/1678/commits","review_comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/1678/comments","review_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/{number}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/1678/comments","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/6269b8c95e60732707c0386a2c9597b2782fd975","head":{"label":"skidau:GC-Adapter","ref":"GC-Adapter","sha":"6269b8c95e60732707c0386a2c9597b2782fd975","user":{"login":"skidau","id":8612259,"avatar_url":"https://avatars.githubusercontent.com/u/8612259?v=3","gravatar_id":"","url":"https://api.github.com/users/skidau","html_url":"https://github.com/skidau","followers_url":"https://api.github.com/users/skidau/followers","following_url":"https://api.github.com/users/skidau/following{/other_user}","gists_url":"https://api.github.com/users/skidau/gists{/gist_id}","starred_url":"https://api.github.com/users/skidau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skidau/subscriptions","organizations_url":"https://api.github.com/users/skidau/orgs","repos_url":"https://api.github.com/users/skidau/repos","events_url":"https://api.github.com/users/skidau/events{/privacy}","received_events_url":"https://api.github.com/users/skidau/received_events","type":"User","site_admin":false},"repo":{"id":23535207,"name":"dolphin","full_name":"skidau/dolphin","owner":{"login":"skidau","id":8612259,"avatar_url":"https://avatars.githubusercontent.com/u/8612259?v=3","gravatar_id":"","url":"https://api.github.com/users/skidau","html_url":"https://github.com/skidau","followers_url":"https://api.github.com/users/skidau/followers","following_url":"https://api.github.com/users/skidau/following{/other_user}","gists_url":"https://api.github.com/users/skidau/gists{/gist_id}","starred_url":"https://api.github.com/users/skidau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skidau/subscriptions","organizations_url":"https://api.github.com/users/skidau/orgs","repos_url":"https://api.github.com/users/skidau/repos","events_url":"https://api.github.com/users/skidau/events{/privacy}","received_events_url":"https://api.github.com/users/skidau/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/skidau/dolphin","description":"Dolphin is a GameCube/Wii emulator, allowing you to play games for these two platforms on PC, with improvements.","fork":true,"url":"https://api.github.com/repos/skidau/dolphin","forks_url":"https://api.github.com/repos/skidau/dolphin/forks","keys_url":"https://api.github.com/repos/skidau/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/skidau/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/skidau/dolphin/teams","hooks_url":"https://api.github.com/repos/skidau/dolphin/hooks","issue_events_url":"https://api.github.com/repos/skidau/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/skidau/dolphin/events","assignees_url":"https://api.github.com/repos/skidau/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/skidau/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/skidau/dolphin/tags","blobs_url":"https://api.github.com/repos/skidau/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/skidau/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/skidau/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/skidau/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/skidau/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/skidau/dolphin/languages","stargazers_url":"https://api.github.com/repos/skidau/dolphin/stargazers","contributors_url":"https://api.github.com/repos/skidau/dolphin/contributors","subscribers_url":"https://api.github.com/repos/skidau/dolphin/subscribers","subscription_url":"https://api.github.com/repos/skidau/dolphin/subscription","commits_url":"https://api.github.com/repos/skidau/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/skidau/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/skidau/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/skidau/dolphin/issues/comments/{number}","contents_url":"https://api.github.com/repos/skidau/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/skidau/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/skidau/dolphin/merges","archive_url":"https://api.github.com/repos/skidau/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/skidau/dolphin/downloads","issues_url":"https://api.github.com/repos/skidau/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/skidau/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/skidau/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/skidau/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/skidau/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/skidau/dolphin/releases{/id}","created_at":"2014-09-01T08:05:15Z","updated_at":"2014-09-01T08:04:00Z","pushed_at":"2014-12-10T12:20:40Z","git_url":"git://github.com/skidau/dolphin.git","ssh_url":"git@github.com:skidau/dolphin.git","clone_url":"https://github.com/skidau/dolphin.git","svn_url":"https://github.com/skidau/dolphin","homepage":null,"size":195964,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dolphin-emu:master","ref":"master","sha":"4c139ca7cc816489feffc0b6ee0a3f1a6d85060e","user":{"login":"dolphin-emu","id":5050316,"avatar_url":"https://avatars.githubusercontent.com/u/5050316?v=3","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"repo":{"id":11577304,"name":"dolphin","full_name":"dolphin-emu/dolphin","owner":{"login":"dolphin-emu","id":5050316,"avatar_url":"https://avatars.githubusercontent.com/u/5050316?v=3","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dolphin-emu/dolphin","description":"Dolphin is a GameCube/Wii emulator, allowing you to play games for these two platforms on PC, with improvements.","fork":false,"url":"https://api.github.com/repos/dolphin-emu/dolphin","forks_url":"https://api.github.com/repos/dolphin-emu/dolphin/forks","keys_url":"https://api.github.com/repos/dolphin-emu/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dolphin-emu/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dolphin-emu/dolphin/teams","hooks_url":"https://api.github.com/repos/dolphin-emu/dolphin/hooks","issue_events_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/dolphin-emu/dolphin/events","assignees_url":"https://api.github.com/repos/dolphin-emu/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/dolphin-emu/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/tags","blobs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/dolphin-emu/dolphin/languages","stargazers_url":"https://api.github.com/repos/dolphin-emu/dolphin/stargazers","contributors_url":"https://api.github.com/repos/dolphin-emu/dolphin/contributors","subscribers_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscribers","subscription_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscription","commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/comments/{number}","contents_url":"https://api.github.com/repos/dolphin-emu/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/dolphin-emu/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dolphin-emu/dolphin/merges","archive_url":"https://api.github.com/repos/dolphin-emu/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dolphin-emu/dolphin/downloads","issues_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/dolphin-emu/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/dolphin-emu/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dolphin-emu/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/dolphin-emu/dolphin/releases{/id}","created_at":"2013-07-22T09:07:57Z","updated_at":"2014-12-10T20:35:37Z","pushed_at":"2014-12-10T20:35:36Z","git_url":"git://github.com/dolphin-emu/dolphin.git","ssh_url":"git@github.com:dolphin-emu/dolphin.git","clone_url":"https://github.com/dolphin-emu/dolphin.git","svn_url":"https://github.com/dolphin-emu/dolphin","homepage":null,"size":244229,"stargazers_count":813,"watchers_count":813,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":267,"mirror_url":null,"open_issues_count":51,"forks":267,"open_issues":51,"watchers":813,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/1678"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/1678"},"issue":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/1678"},"comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/1678/comments"},"review_comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/1678/comments"},"review_comment":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/1678/commits"},"statuses":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/6269b8c95e60732707c0386a2c9597b2782fd975"}}}}