GitHub PullRequestReviewCommentEvent at 2014-11-18 08:51:10
Repository: androidannotations
Actor: jiongxuan
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/excilys/androidannotations/pulls/comments/20492182","id":20492182,"diff_hunk":"@@ -0,0 +1,34 @@\n+/**\n+ * Copyright (C) 2010-2014 eBusiness Information, Excilys Group\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\"); you may not\n+ * use this file except in compliance with the License. You may obtain a copy of\n+ * the License at\n+ *\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed To in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT\n+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the\n+ * License for the specific language governing permissions and limitations under\n+ * the License.\n+ */\n+package org.androidannotations.helper;\n+\n+import static com.sun.codemodel.JExpr._null;\n+\n+import org.androidannotations.holder.HasReceiverRegistration;\n+import org.androidannotations.process.ProcessHolder;\n+\n+import com.sun.codemodel.JBlock;\n+import com.sun.codemodel.JFieldVar;\n+\n+public class OrmLiteHelper {\n+\n+\tpublic static void injectReleaseInDestroy(JFieldVar databaseHelperRef, HasReceiverRegistration receiverHolder, ProcessHolder.Classes classes) {","path":"AndroidAnnotations/androidannotations/src/main/java/org/androidannotations/helper/OrmLiteHelper.java","position":28,"original_position":28,"commit_id":"1d0f89140443a0a9ffbcf6c8931e07d8f035c292","original_commit_id":"1d0f89140443a0a9ffbcf6c8931e07d8f035c292","user":{"login":"jiongxuan","id":4717125,"avatar_url":"https://avatars.githubusercontent.com/u/4717125?v=3","gravatar_id":"","url":"https://api.github.com/users/jiongxuan","html_url":"https://github.com/jiongxuan","followers_url":"https://api.github.com/users/jiongxuan/followers","following_url":"https://api.github.com/users/jiongxuan/following{/other_user}","gists_url":"https://api.github.com/users/jiongxuan/gists{/gist_id}","starred_url":"https://api.github.com/users/jiongxuan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jiongxuan/subscriptions","organizations_url":"https://api.github.com/users/jiongxuan/orgs","repos_url":"https://api.github.com/users/jiongxuan/repos","events_url":"https://api.github.com/users/jiongxuan/events{/privacy}","received_events_url":"https://api.github.com/users/jiongxuan/received_events","type":"User","site_admin":false},"body":"`HasLifecycleMethods`? \r\n\r\nAre you sure that the interface should have `onDestroyBeforeSuperBlock` method?\r\nIf not, how can I insert `OpenHelperManager.release` in the onDestroy method?","created_at":"2014-11-18T08:51:10Z","updated_at":"2014-11-18T08:51:10Z","html_url":"https://github.com/excilys/androidannotations/pull/1245#discussion_r20492182","pull_request_url":"https://api.github.com/repos/excilys/androidannotations/pulls/1245","_links":{"self":{"href":"https://api.github.com/repos/excilys/androidannotations/pulls/comments/20492182"},"html":{"href":"https://github.com/excilys/androidannotations/pull/1245#discussion_r20492182"},"pull_request":{"href":"https://api.github.com/repos/excilys/androidannotations/pulls/1245"}}},"pull_request":{"url":"https://api.github.com/repos/excilys/androidannotations/pulls/1245","id":24503351,"html_url":"https://github.com/excilys/androidannotations/pull/1245","diff_url":"https://github.com/excilys/androidannotations/pull/1245.diff","patch_url":"https://github.com/excilys/androidannotations/pull/1245.patch","issue_url":"https://api.github.com/repos/excilys/androidannotations/issues/1245","number":1245,"state":"open","locked":false,"title":"943 release openhelpermanager","user":{"login":"jiongxuan","id":4717125,"avatar_url":"https://avatars.githubusercontent.com/u/4717125?v=3","gravatar_id":"","url":"https://api.github.com/users/jiongxuan","html_url":"https://github.com/jiongxuan","followers_url":"https://api.github.com/users/jiongxuan/followers","following_url":"https://api.github.com/users/jiongxuan/following{/other_user}","gists_url":"https://api.github.com/users/jiongxuan/gists{/gist_id}","starred_url":"https://api.github.com/users/jiongxuan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jiongxuan/subscriptions","organizations_url":"https://api.github.com/users/jiongxuan/orgs","repos_url":"https://api.github.com/users/jiongxuan/repos","events_url":"https://api.github.com/users/jiongxuan/events{/privacy}","received_events_url":"https://api.github.com/users/jiongxuan/received_events","type":"User","site_admin":false},"body":"Implement #943 issue.\r\n\r\nPlease review my code. Thx!","created_at":"2014-11-16T15:52:57Z","updated_at":"2014-11-18T08:51:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8ebc6ada923ba3016db83d6c35d79d717a4a34e7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/excilys/androidannotations/pulls/1245/commits","review_comments_url":"https://api.github.com/repos/excilys/androidannotations/pulls/1245/comments","review_comment_url":"https://api.github.com/repos/excilys/androidannotations/pulls/comments/{number}","comments_url":"https://api.github.com/repos/excilys/androidannotations/issues/1245/comments","statuses_url":"https://api.github.com/repos/excilys/androidannotations/statuses/1d0f89140443a0a9ffbcf6c8931e07d8f035c292","head":{"label":"jiongxuan:943_release_openhelpermanager","ref":"943_release_openhelpermanager","sha":"1d0f89140443a0a9ffbcf6c8931e07d8f035c292","user":{"login":"jiongxuan","id":4717125,"avatar_url":"https://avatars.githubusercontent.com/u/4717125?v=3","gravatar_id":"","url":"https://api.github.com/users/jiongxuan","html_url":"https://github.com/jiongxuan","followers_url":"https://api.github.com/users/jiongxuan/followers","following_url":"https://api.github.com/users/jiongxuan/following{/other_user}","gists_url":"https://api.github.com/users/jiongxuan/gists{/gist_id}","starred_url":"https://api.github.com/users/jiongxuan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jiongxuan/subscriptions","organizations_url":"https://api.github.com/users/jiongxuan/orgs","repos_url":"https://api.github.com/users/jiongxuan/repos","events_url":"https://api.github.com/users/jiongxuan/events{/privacy}","received_events_url":"https://api.github.com/users/jiongxuan/received_events","type":"User","site_admin":false},"repo":{"id":26669101,"name":"androidannotations","full_name":"jiongxuan/androidannotations","owner":{"login":"jiongxuan","id":4717125,"avatar_url":"https://avatars.githubusercontent.com/u/4717125?v=3","gravatar_id":"","url":"https://api.github.com/users/jiongxuan","html_url":"https://github.com/jiongxuan","followers_url":"https://api.github.com/users/jiongxuan/followers","following_url":"https://api.github.com/users/jiongxuan/following{/other_user}","gists_url":"https://api.github.com/users/jiongxuan/gists{/gist_id}","starred_url":"https://api.github.com/users/jiongxuan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jiongxuan/subscriptions","organizations_url":"https://api.github.com/users/jiongxuan/orgs","repos_url":"https://api.github.com/users/jiongxuan/repos","events_url":"https://api.github.com/users/jiongxuan/events{/privacy}","received_events_url":"https://api.github.com/users/jiongxuan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jiongxuan/androidannotations","description":"AA for my contribute","fork":true,"url":"https://api.github.com/repos/jiongxuan/androidannotations","forks_url":"https://api.github.com/repos/jiongxuan/androidannotations/forks","keys_url":"https://api.github.com/repos/jiongxuan/androidannotations/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jiongxuan/androidannotations/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jiongxuan/androidannotations/teams","hooks_url":"https://api.github.com/repos/jiongxuan/androidannotations/hooks","issue_events_url":"https://api.github.com/repos/jiongxuan/androidannotations/issues/events{/number}","events_url":"https://api.github.com/repos/jiongxuan/androidannotations/events","assignees_url":"https://api.github.com/repos/jiongxuan/androidannotations/assignees{/user}","branches_url":"https://api.github.com/repos/jiongxuan/androidannotations/branches{/branch}","tags_url":"https://api.github.com/repos/jiongxuan/androidannotations/tags","blobs_url":"https://api.github.com/repos/jiongxuan/androidannotations/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jiongxuan/androidannotations/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jiongxuan/androidannotations/git/refs{/sha}","trees_url":"https://api.github.com/repos/jiongxuan/androidannotations/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jiongxuan/androidannotations/statuses/{sha}","languages_url":"https://api.github.com/repos/jiongxuan/androidannotations/languages","stargazers_url":"https://api.github.com/repos/jiongxuan/androidannotations/stargazers","contributors_url":"https://api.github.com/repos/jiongxuan/androidannotations/contributors","subscribers_url":"https://api.github.com/repos/jiongxuan/androidannotations/subscribers","subscription_url":"https://api.github.com/repos/jiongxuan/androidannotations/subscription","commits_url":"https://api.github.com/repos/jiongxuan/androidannotations/commits{/sha}","git_commits_url":"https://api.github.com/repos/jiongxuan/androidannotations/git/commits{/sha}","comments_url":"https://api.github.com/repos/jiongxuan/androidannotations/comments{/number}","issue_comment_url":"https://api.github.com/repos/jiongxuan/androidannotations/issues/comments/{number}","contents_url":"https://api.github.com/repos/jiongxuan/androidannotations/contents/{+path}","compare_url":"https://api.github.com/repos/jiongxuan/androidannotations/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jiongxuan/androidannotations/merges","archive_url":"https://api.github.com/repos/jiongxuan/androidannotations/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jiongxuan/androidannotations/downloads","issues_url":"https://api.github.com/repos/jiongxuan/androidannotations/issues{/number}","pulls_url":"https://api.github.com/repos/jiongxuan/androidannotations/pulls{/number}","milestones_url":"https://api.github.com/repos/jiongxuan/androidannotations/milestones{/number}","notifications_url":"https://api.github.com/repos/jiongxuan/androidannotations/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jiongxuan/androidannotations/labels{/name}","releases_url":"https://api.github.com/repos/jiongxuan/androidannotations/releases{/id}","created_at":"2014-11-15T04:19:51Z","updated_at":"2014-11-15T04:21:12Z","pushed_at":"2014-11-18T08:36:27Z","git_url":"git://github.com/jiongxuan/androidannotations.git","ssh_url":"git@github.com:jiongxuan/androidannotations.git","clone_url":"https://github.com/jiongxuan/androidannotations.git","svn_url":"https://github.com/jiongxuan/androidannotations","homepage":"http://androidannotations.org","size":54377,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"excilys:develop","ref":"develop","sha":"c8b8725dd791ed7a8d2a9cc10d5dd60e22bab784","user":{"login":"excilys","id":668697,"avatar_url":"https://avatars.githubusercontent.com/u/668697?v=3","gravatar_id":"","url":"https://api.github.com/users/excilys","html_url":"https://github.com/excilys","followers_url":"https://api.github.com/users/excilys/followers","following_url":"https://api.github.com/users/excilys/following{/other_user}","gists_url":"https://api.github.com/users/excilys/gists{/gist_id}","starred_url":"https://api.github.com/users/excilys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/excilys/subscriptions","organizations_url":"https://api.github.com/users/excilys/orgs","repos_url":"https://api.github.com/users/excilys/repos","events_url":"https://api.github.com/users/excilys/events{/privacy}","received_events_url":"https://api.github.com/users/excilys/received_events","type":"Organization","site_admin":false},"repo":{"id":3116751,"name":"androidannotations","full_name":"excilys/androidannotations","owner":{"login":"excilys","id":668697,"avatar_url":"https://avatars.githubusercontent.com/u/668697?v=3","gravatar_id":"","url":"https://api.github.com/users/excilys","html_url":"https://github.com/excilys","followers_url":"https://api.github.com/users/excilys/followers","following_url":"https://api.github.com/users/excilys/following{/other_user}","gists_url":"https://api.github.com/users/excilys/gists{/gist_id}","starred_url":"https://api.github.com/users/excilys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/excilys/subscriptions","organizations_url":"https://api.github.com/users/excilys/orgs","repos_url":"https://api.github.com/users/excilys/repos","events_url":"https://api.github.com/users/excilys/events{/privacy}","received_events_url":"https://api.github.com/users/excilys/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/excilys/androidannotations","description":"Fast Android Development. Easy maintainance.","fork":false,"url":"https://api.github.com/repos/excilys/androidannotations","forks_url":"https://api.github.com/repos/excilys/androidannotations/forks","keys_url":"https://api.github.com/repos/excilys/androidannotations/keys{/key_id}","collaborators_url":"https://api.github.com/repos/excilys/androidannotations/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/excilys/androidannotations/teams","hooks_url":"https://api.github.com/repos/excilys/androidannotations/hooks","issue_events_url":"https://api.github.com/repos/excilys/androidannotations/issues/events{/number}","events_url":"https://api.github.com/repos/excilys/androidannotations/events","assignees_url":"https://api.github.com/repos/excilys/androidannotations/assignees{/user}","branches_url":"https://api.github.com/repos/excilys/androidannotations/branches{/branch}","tags_url":"https://api.github.com/repos/excilys/androidannotations/tags","blobs_url":"https://api.github.com/repos/excilys/androidannotations/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/excilys/androidannotations/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/excilys/androidannotations/git/refs{/sha}","trees_url":"https://api.github.com/repos/excilys/androidannotations/git/trees{/sha}","statuses_url":"https://api.github.com/repos/excilys/androidannotations/statuses/{sha}","languages_url":"https://api.github.com/repos/excilys/androidannotations/languages","stargazers_url":"https://api.github.com/repos/excilys/androidannotations/stargazers","contributors_url":"https://api.github.com/repos/excilys/androidannotations/contributors","subscribers_url":"https://api.github.com/repos/excilys/androidannotations/subscribers","subscription_url":"https://api.github.com/repos/excilys/androidannotations/subscription","commits_url":"https://api.github.com/repos/excilys/androidannotations/commits{/sha}","git_commits_url":"https://api.github.com/repos/excilys/androidannotations/git/commits{/sha}","comments_url":"https://api.github.com/repos/excilys/androidannotations/comments{/number}","issue_comment_url":"https://api.github.com/repos/excilys/androidannotations/issues/comments/{number}","contents_url":"https://api.github.com/repos/excilys/androidannotations/contents/{+path}","compare_url":"https://api.github.com/repos/excilys/androidannotations/compare/{base}...{head}","merges_url":"https://api.github.com/repos/excilys/androidannotations/merges","archive_url":"https://api.github.com/repos/excilys/androidannotations/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/excilys/androidannotations/downloads","issues_url":"https://api.github.com/repos/excilys/androidannotations/issues{/number}","pulls_url":"https://api.github.com/repos/excilys/androidannotations/pulls{/number}","milestones_url":"https://api.github.com/repos/excilys/androidannotations/milestones{/number}","notifications_url":"https://api.github.com/repos/excilys/androidannotations/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/excilys/androidannotations/labels{/name}","releases_url":"https://api.github.com/repos/excilys/androidannotations/releases{/id}","created_at":"2012-01-06T08:48:03Z","updated_at":"2014-11-18T06:01:01Z","pushed_at":"2014-11-14T15:43:07Z","git_url":"git://github.com/excilys/androidannotations.git","ssh_url":"git@github.com:excilys/androidannotations.git","clone_url":"https://github.com/excilys/androidannotations.git","svn_url":"https://github.com/excilys/androidannotations","homepage":"http://androidannotations.org","size":54377,"stargazers_count":3929,"watchers_count":3929,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1106,"mirror_url":null,"open_issues_count":104,"forks":1106,"open_issues":104,"watchers":3929,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/excilys/androidannotations/pulls/1245"},"html":{"href":"https://github.com/excilys/androidannotations/pull/1245"},"issue":{"href":"https://api.github.com/repos/excilys/androidannotations/issues/1245"},"comments":{"href":"https://api.github.com/repos/excilys/androidannotations/issues/1245/comments"},"review_comments":{"href":"https://api.github.com/repos/excilys/androidannotations/pulls/1245/comments"},"review_comment":{"href":"https://api.github.com/repos/excilys/androidannotations/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/excilys/androidannotations/pulls/1245/commits"},"statuses":{"href":"https://api.github.com/repos/excilys/androidannotations/statuses/1d0f89140443a0a9ffbcf6c8931e07d8f035c292"}}}}