GitHub PullRequestReviewCommentEvent at 2014-06-23 18:50:50
Repository: plottable
Actor: bmalehorn
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/palantir/plottable/pulls/comments/14092716","id":14092716,"diff_hunk":"@@ -8,6 +8,9 @@ export module Abstract {\n     public _precision: number;\n \n     constructor(precision: number) {\n+      if (precision < 0 || 20 < precision) {","path":"src/utils/formatters/formatter.ts","position":4,"original_position":4,"commit_id":"5d906288cb72050993c40b6af216b25e8cea183f","original_commit_id":"5d906288cb72050993c40b6af216b25e8cea183f","user":{"login":"bmalehorn","id":3344958,"avatar_url":"https://avatars.githubusercontent.com/u/3344958?","gravatar_id":"bd7961598025441e6c3911aa462afb2f","url":"https://api.github.com/users/bmalehorn","html_url":"https://github.com/bmalehorn","followers_url":"https://api.github.com/users/bmalehorn/followers","following_url":"https://api.github.com/users/bmalehorn/following{/other_user}","gists_url":"https://api.github.com/users/bmalehorn/gists{/gist_id}","starred_url":"https://api.github.com/users/bmalehorn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmalehorn/subscriptions","organizations_url":"https://api.github.com/users/bmalehorn/orgs","repos_url":"https://api.github.com/users/bmalehorn/repos","events_url":"https://api.github.com/users/bmalehorn/events{/privacy}","received_events_url":"https://api.github.com/users/bmalehorn/received_events","type":"User","site_admin":false},"body":"I have a knee-jerk reaction to make all the inequalities point the same direction like in equations. I wrote it as you suggested originally, so that's probably the more intuitive form.","created_at":"2014-06-23T18:50:50Z","updated_at":"2014-06-23T18:50:50Z","html_url":"https://github.com/palantir/plottable/pull/578#discussion_r14092716","pull_request_url":"https://api.github.com/repos/palantir/plottable/pulls/578","_links":{"self":{"href":"https://api.github.com/repos/palantir/plottable/pulls/comments/14092716"},"html":{"href":"https://github.com/palantir/plottable/pull/578#discussion_r14092716"},"pull_request":{"href":"https://api.github.com/repos/palantir/plottable/pulls/578"}}},"pull_request":{"url":"https://api.github.com/repos/palantir/plottable/pulls/578","id":17432573,"html_url":"https://github.com/palantir/plottable/pull/578","diff_url":"https://github.com/palantir/plottable/pull/578.diff","patch_url":"https://github.com/palantir/plottable/pull/578.patch","issue_url":"https://api.github.com/repos/palantir/plottable/issues/578","number":578,"state":"open","title":"new Formatter.General(-1) throws exception","user":{"login":"bmalehorn","id":3344958,"avatar_url":"https://avatars.githubusercontent.com/u/3344958?","gravatar_id":"bd7961598025441e6c3911aa462afb2f","url":"https://api.github.com/users/bmalehorn","html_url":"https://github.com/bmalehorn","followers_url":"https://api.github.com/users/bmalehorn/followers","following_url":"https://api.github.com/users/bmalehorn/following{/other_user}","gists_url":"https://api.github.com/users/bmalehorn/gists{/gist_id}","starred_url":"https://api.github.com/users/bmalehorn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmalehorn/subscriptions","organizations_url":"https://api.github.com/users/bmalehorn/orgs","repos_url":"https://api.github.com/users/bmalehorn/repos","events_url":"https://api.github.com/users/bmalehorn/events{/privacy}","received_events_url":"https://api.github.com/users/bmalehorn/received_events","type":"User","site_admin":false},"body":"Most formatters would fail when given strange precision because `Number.toFixed` throws an error. But `Formatter.General` doesn't use `toFixed`, so it failed silently.\r\n\r\nNow all formatters throw an exception on construction if their precision is strange.\r\n\r\nClose #568.","created_at":"2014-06-20T23:15:03Z","updated_at":"2014-06-23T18:50:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"893ee6c538132fc873b1c14ea0eeca965d658411","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/palantir/plottable/pulls/578/commits","review_comments_url":"https://api.github.com/repos/palantir/plottable/pulls/578/comments","review_comment_url":"https://api.github.com/repos/palantir/plottable/pulls/comments/{number}","comments_url":"https://api.github.com/repos/palantir/plottable/issues/578/comments","statuses_url":"https://api.github.com/repos/palantir/plottable/statuses/5d906288cb72050993c40b6af216b25e8cea183f","head":{"label":"palantir:general-formatter-error","ref":"general-formatter-error","sha":"5d906288cb72050993c40b6af216b25e8cea183f","user":{"login":"palantir","id":303157,"avatar_url":"https://avatars.githubusercontent.com/u/303157?","gravatar_id":"c593136bf7c6a139280354bfc1448a14","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"repo":{"id":16149854,"name":"plottable","full_name":"palantir/plottable","owner":{"login":"palantir","id":303157,"avatar_url":"https://avatars.githubusercontent.com/u/303157?","gravatar_id":"c593136bf7c6a139280354bfc1448a14","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/palantir/plottable","description":"A library for creating interactive charts within a grid layout.","fork":false,"url":"https://api.github.com/repos/palantir/plottable","forks_url":"https://api.github.com/repos/palantir/plottable/forks","keys_url":"https://api.github.com/repos/palantir/plottable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/palantir/plottable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/palantir/plottable/teams","hooks_url":"https://api.github.com/repos/palantir/plottable/hooks","issue_events_url":"https://api.github.com/repos/palantir/plottable/issues/events{/number}","events_url":"https://api.github.com/repos/palantir/plottable/events","assignees_url":"https://api.github.com/repos/palantir/plottable/assignees{/user}","branches_url":"https://api.github.com/repos/palantir/plottable/branches{/branch}","tags_url":"https://api.github.com/repos/palantir/plottable/tags","blobs_url":"https://api.github.com/repos/palantir/plottable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/palantir/plottable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/palantir/plottable/git/refs{/sha}","trees_url":"https://api.github.com/repos/palantir/plottable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/palantir/plottable/statuses/{sha}","languages_url":"https://api.github.com/repos/palantir/plottable/languages","stargazers_url":"https://api.github.com/repos/palantir/plottable/stargazers","contributors_url":"https://api.github.com/repos/palantir/plottable/contributors","subscribers_url":"https://api.github.com/repos/palantir/plottable/subscribers","subscription_url":"https://api.github.com/repos/palantir/plottable/subscription","commits_url":"https://api.github.com/repos/palantir/plottable/commits{/sha}","git_commits_url":"https://api.github.com/repos/palantir/plottable/git/commits{/sha}","comments_url":"https://api.github.com/repos/palantir/plottable/comments{/number}","issue_comment_url":"https://api.github.com/repos/palantir/plottable/issues/comments/{number}","contents_url":"https://api.github.com/repos/palantir/plottable/contents/{+path}","compare_url":"https://api.github.com/repos/palantir/plottable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/palantir/plottable/merges","archive_url":"https://api.github.com/repos/palantir/plottable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/palantir/plottable/downloads","issues_url":"https://api.github.com/repos/palantir/plottable/issues{/number}","pulls_url":"https://api.github.com/repos/palantir/plottable/pulls{/number}","milestones_url":"https://api.github.com/repos/palantir/plottable/milestones{/number}","notifications_url":"https://api.github.com/repos/palantir/plottable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/palantir/plottable/labels{/name}","releases_url":"https://api.github.com/repos/palantir/plottable/releases{/id}","created_at":"2014-01-22T19:29:19Z","updated_at":"2014-06-20T23:15:03Z","pushed_at":"2014-06-23T18:44:18Z","git_url":"git://github.com/palantir/plottable.git","ssh_url":"git@github.com:palantir/plottable.git","clone_url":"https://github.com/palantir/plottable.git","svn_url":"https://github.com/palantir/plottable","homepage":"palantir.github.io/plottable","size":25777,"stargazers_count":22,"watchers_count":22,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":5,"mirror_url":null,"open_issues_count":74,"forks":5,"open_issues":74,"watchers":22,"default_branch":"master"}},"base":{"label":"palantir:master","ref":"master","sha":"bfa757d446a0320e83eead29b4a36909fda21c52","user":{"login":"palantir","id":303157,"avatar_url":"https://avatars.githubusercontent.com/u/303157?","gravatar_id":"c593136bf7c6a139280354bfc1448a14","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"repo":{"id":16149854,"name":"plottable","full_name":"palantir/plottable","owner":{"login":"palantir","id":303157,"avatar_url":"https://avatars.githubusercontent.com/u/303157?","gravatar_id":"c593136bf7c6a139280354bfc1448a14","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/palantir/plottable","description":"A library for creating interactive charts within a grid layout.","fork":false,"url":"https://api.github.com/repos/palantir/plottable","forks_url":"https://api.github.com/repos/palantir/plottable/forks","keys_url":"https://api.github.com/repos/palantir/plottable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/palantir/plottable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/palantir/plottable/teams","hooks_url":"https://api.github.com/repos/palantir/plottable/hooks","issue_events_url":"https://api.github.com/repos/palantir/plottable/issues/events{/number}","events_url":"https://api.github.com/repos/palantir/plottable/events","assignees_url":"https://api.github.com/repos/palantir/plottable/assignees{/user}","branches_url":"https://api.github.com/repos/palantir/plottable/branches{/branch}","tags_url":"https://api.github.com/repos/palantir/plottable/tags","blobs_url":"https://api.github.com/repos/palantir/plottable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/palantir/plottable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/palantir/plottable/git/refs{/sha}","trees_url":"https://api.github.com/repos/palantir/plottable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/palantir/plottable/statuses/{sha}","languages_url":"https://api.github.com/repos/palantir/plottable/languages","stargazers_url":"https://api.github.com/repos/palantir/plottable/stargazers","contributors_url":"https://api.github.com/repos/palantir/plottable/contributors","subscribers_url":"https://api.github.com/repos/palantir/plottable/subscribers","subscription_url":"https://api.github.com/repos/palantir/plottable/subscription","commits_url":"https://api.github.com/repos/palantir/plottable/commits{/sha}","git_commits_url":"https://api.github.com/repos/palantir/plottable/git/commits{/sha}","comments_url":"https://api.github.com/repos/palantir/plottable/comments{/number}","issue_comment_url":"https://api.github.com/repos/palantir/plottable/issues/comments/{number}","contents_url":"https://api.github.com/repos/palantir/plottable/contents/{+path}","compare_url":"https://api.github.com/repos/palantir/plottable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/palantir/plottable/merges","archive_url":"https://api.github.com/repos/palantir/plottable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/palantir/plottable/downloads","issues_url":"https://api.github.com/repos/palantir/plottable/issues{/number}","pulls_url":"https://api.github.com/repos/palantir/plottable/pulls{/number}","milestones_url":"https://api.github.com/repos/palantir/plottable/milestones{/number}","notifications_url":"https://api.github.com/repos/palantir/plottable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/palantir/plottable/labels{/name}","releases_url":"https://api.github.com/repos/palantir/plottable/releases{/id}","created_at":"2014-01-22T19:29:19Z","updated_at":"2014-06-20T23:15:03Z","pushed_at":"2014-06-23T18:44:18Z","git_url":"git://github.com/palantir/plottable.git","ssh_url":"git@github.com:palantir/plottable.git","clone_url":"https://github.com/palantir/plottable.git","svn_url":"https://github.com/palantir/plottable","homepage":"palantir.github.io/plottable","size":25777,"stargazers_count":22,"watchers_count":22,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":5,"mirror_url":null,"open_issues_count":74,"forks":5,"open_issues":74,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/palantir/plottable/pulls/578"},"html":{"href":"https://github.com/palantir/plottable/pull/578"},"issue":{"href":"https://api.github.com/repos/palantir/plottable/issues/578"},"comments":{"href":"https://api.github.com/repos/palantir/plottable/issues/578/comments"},"review_comments":{"href":"https://api.github.com/repos/palantir/plottable/pulls/578/comments"},"review_comment":{"href":"https://api.github.com/repos/palantir/plottable/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/palantir/plottable/pulls/578/commits"},"statuses":{"href":"https://api.github.com/repos/palantir/plottable/statuses/5d906288cb72050993c40b6af216b25e8cea183f"}}}}