GitHub PullRequestReviewCommentEvent at 2014-12-09 00:20:17
Repository: la4j
Actor: vkostyukov
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/vkostyukov/la4j/pulls/comments/21498592","id":21498592,"diff_hunk":"@@ -113,12 +137,38 @@ public double foldNonZeroInRow(int i, MatrixAccumulator accumulator) {\n         eachNonZeroInRow(i, Matrices.asAccumulatorProcedure(accumulator));\n         return accumulator.accumulate();\n     }\n+    \n+    @Override\n+    public double foldNonZeroInRow(int i, VectorFunction function) {","path":"src/main/java/org/la4j/matrix/sparse/AbstractCompressedMatrix.java","position":51,"original_position":51,"commit_id":"fbbee093aebd224f7fc854bc75d6747675df3de1","original_commit_id":"fbbee093aebd224f7fc854bc75d6747675df3de1","user":{"login":"vkostyukov","id":1098539,"avatar_url":"https://avatars.githubusercontent.com/u/1098539?v=3","gravatar_id":"","url":"https://api.github.com/users/vkostyukov","html_url":"https://github.com/vkostyukov","followers_url":"https://api.github.com/users/vkostyukov/followers","following_url":"https://api.github.com/users/vkostyukov/following{/other_user}","gists_url":"https://api.github.com/users/vkostyukov/gists{/gist_id}","starred_url":"https://api.github.com/users/vkostyukov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vkostyukov/subscriptions","organizations_url":"https://api.github.com/users/vkostyukov/orgs","repos_url":"https://api.github.com/users/vkostyukov/repos","events_url":"https://api.github.com/users/vkostyukov/events{/privacy}","received_events_url":"https://api.github.com/users/vkostyukov/received_events","type":"User","site_admin":false},"body":"So, all you need to do, is something like this:\r\n\r\n```java\r\neachNonZeroInRow(i, Vectors.asAccumulatorProcedure(accumulator));\r\nreturn accumulator.accumulate();\r\n```","created_at":"2014-12-09T00:20:17Z","updated_at":"2014-12-09T00:20:17Z","html_url":"https://github.com/vkostyukov/la4j/pull/233#discussion_r21498592","pull_request_url":"https://api.github.com/repos/vkostyukov/la4j/pulls/233","_links":{"self":{"href":"https://api.github.com/repos/vkostyukov/la4j/pulls/comments/21498592"},"html":{"href":"https://github.com/vkostyukov/la4j/pull/233#discussion_r21498592"},"pull_request":{"href":"https://api.github.com/repos/vkostyukov/la4j/pulls/233"}}},"pull_request":{"url":"https://api.github.com/repos/vkostyukov/la4j/pulls/233","id":25709039,"html_url":"https://github.com/vkostyukov/la4j/pull/233","diff_url":"https://github.com/vkostyukov/la4j/pull/233.diff","patch_url":"https://github.com/vkostyukov/la4j/pull/233.patch","issue_url":"https://api.github.com/repos/vkostyukov/la4j/issues/233","number":233,"state":"open","locked":false,"title":"172 vector function","user":{"login":"DWiechert","id":2567382,"avatar_url":"https://avatars.githubusercontent.com/u/2567382?v=3","gravatar_id":"","url":"https://api.github.com/users/DWiechert","html_url":"https://github.com/DWiechert","followers_url":"https://api.github.com/users/DWiechert/followers","following_url":"https://api.github.com/users/DWiechert/following{/other_user}","gists_url":"https://api.github.com/users/DWiechert/gists{/gist_id}","starred_url":"https://api.github.com/users/DWiechert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DWiechert/subscriptions","organizations_url":"https://api.github.com/users/DWiechert/orgs","repos_url":"https://api.github.com/users/DWiechert/repos","events_url":"https://api.github.com/users/DWiechert/events{/privacy}","received_events_url":"https://api.github.com/users/DWiechert/received_events","type":"User","site_admin":false},"body":"Preliminary code review of new functions. Tests will be added once I know the implementation is correct.","created_at":"2014-12-09T00:07:28Z","updated_at":"2014-12-09T00:20:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"46eb4443fa10104bdcbc47c065e03f477816b665","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/vkostyukov/la4j/pulls/233/commits","review_comments_url":"https://api.github.com/repos/vkostyukov/la4j/pulls/233/comments","review_comment_url":"https://api.github.com/repos/vkostyukov/la4j/pulls/comments/{number}","comments_url":"https://api.github.com/repos/vkostyukov/la4j/issues/233/comments","statuses_url":"https://api.github.com/repos/vkostyukov/la4j/statuses/fbbee093aebd224f7fc854bc75d6747675df3de1","head":{"label":"DWiechert:172-VectorFunction","ref":"172-VectorFunction","sha":"fbbee093aebd224f7fc854bc75d6747675df3de1","user":{"login":"DWiechert","id":2567382,"avatar_url":"https://avatars.githubusercontent.com/u/2567382?v=3","gravatar_id":"","url":"https://api.github.com/users/DWiechert","html_url":"https://github.com/DWiechert","followers_url":"https://api.github.com/users/DWiechert/followers","following_url":"https://api.github.com/users/DWiechert/following{/other_user}","gists_url":"https://api.github.com/users/DWiechert/gists{/gist_id}","starred_url":"https://api.github.com/users/DWiechert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DWiechert/subscriptions","organizations_url":"https://api.github.com/users/DWiechert/orgs","repos_url":"https://api.github.com/users/DWiechert/repos","events_url":"https://api.github.com/users/DWiechert/events{/privacy}","received_events_url":"https://api.github.com/users/DWiechert/received_events","type":"User","site_admin":false},"repo":{"id":27461457,"name":"la4j","full_name":"DWiechert/la4j","owner":{"login":"DWiechert","id":2567382,"avatar_url":"https://avatars.githubusercontent.com/u/2567382?v=3","gravatar_id":"","url":"https://api.github.com/users/DWiechert","html_url":"https://github.com/DWiechert","followers_url":"https://api.github.com/users/DWiechert/followers","following_url":"https://api.github.com/users/DWiechert/following{/other_user}","gists_url":"https://api.github.com/users/DWiechert/gists{/gist_id}","starred_url":"https://api.github.com/users/DWiechert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DWiechert/subscriptions","organizations_url":"https://api.github.com/users/DWiechert/orgs","repos_url":"https://api.github.com/users/DWiechert/repos","events_url":"https://api.github.com/users/DWiechert/events{/privacy}","received_events_url":"https://api.github.com/users/DWiechert/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DWiechert/la4j","description":"Linear Algebra for Java","fork":true,"url":"https://api.github.com/repos/DWiechert/la4j","forks_url":"https://api.github.com/repos/DWiechert/la4j/forks","keys_url":"https://api.github.com/repos/DWiechert/la4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DWiechert/la4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DWiechert/la4j/teams","hooks_url":"https://api.github.com/repos/DWiechert/la4j/hooks","issue_events_url":"https://api.github.com/repos/DWiechert/la4j/issues/events{/number}","events_url":"https://api.github.com/repos/DWiechert/la4j/events","assignees_url":"https://api.github.com/repos/DWiechert/la4j/assignees{/user}","branches_url":"https://api.github.com/repos/DWiechert/la4j/branches{/branch}","tags_url":"https://api.github.com/repos/DWiechert/la4j/tags","blobs_url":"https://api.github.com/repos/DWiechert/la4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DWiechert/la4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DWiechert/la4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/DWiechert/la4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DWiechert/la4j/statuses/{sha}","languages_url":"https://api.github.com/repos/DWiechert/la4j/languages","stargazers_url":"https://api.github.com/repos/DWiechert/la4j/stargazers","contributors_url":"https://api.github.com/repos/DWiechert/la4j/contributors","subscribers_url":"https://api.github.com/repos/DWiechert/la4j/subscribers","subscription_url":"https://api.github.com/repos/DWiechert/la4j/subscription","commits_url":"https://api.github.com/repos/DWiechert/la4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/DWiechert/la4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/DWiechert/la4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/DWiechert/la4j/issues/comments/{number}","contents_url":"https://api.github.com/repos/DWiechert/la4j/contents/{+path}","compare_url":"https://api.github.com/repos/DWiechert/la4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DWiechert/la4j/merges","archive_url":"https://api.github.com/repos/DWiechert/la4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DWiechert/la4j/downloads","issues_url":"https://api.github.com/repos/DWiechert/la4j/issues{/number}","pulls_url":"https://api.github.com/repos/DWiechert/la4j/pulls{/number}","milestones_url":"https://api.github.com/repos/DWiechert/la4j/milestones{/number}","notifications_url":"https://api.github.com/repos/DWiechert/la4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DWiechert/la4j/labels{/name}","releases_url":"https://api.github.com/repos/DWiechert/la4j/releases{/id}","created_at":"2014-12-03T00:45:47Z","updated_at":"2014-12-08T23:20:52Z","pushed_at":"2014-12-09T00:06:09Z","git_url":"git://github.com/DWiechert/la4j.git","ssh_url":"git@github.com:DWiechert/la4j.git","clone_url":"https://github.com/DWiechert/la4j.git","svn_url":"https://github.com/DWiechert/la4j","homepage":"http://la4j.org","size":1940,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"vkostyukov:master","ref":"master","sha":"eef3fbc2c0e2f3823be86c541fed59e1dbcf463c","user":{"login":"vkostyukov","id":1098539,"avatar_url":"https://avatars.githubusercontent.com/u/1098539?v=3","gravatar_id":"","url":"https://api.github.com/users/vkostyukov","html_url":"https://github.com/vkostyukov","followers_url":"https://api.github.com/users/vkostyukov/followers","following_url":"https://api.github.com/users/vkostyukov/following{/other_user}","gists_url":"https://api.github.com/users/vkostyukov/gists{/gist_id}","starred_url":"https://api.github.com/users/vkostyukov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vkostyukov/subscriptions","organizations_url":"https://api.github.com/users/vkostyukov/orgs","repos_url":"https://api.github.com/users/vkostyukov/repos","events_url":"https://api.github.com/users/vkostyukov/events{/privacy}","received_events_url":"https://api.github.com/users/vkostyukov/received_events","type":"User","site_admin":false},"repo":{"id":7235555,"name":"la4j","full_name":"vkostyukov/la4j","owner":{"login":"vkostyukov","id":1098539,"avatar_url":"https://avatars.githubusercontent.com/u/1098539?v=3","gravatar_id":"","url":"https://api.github.com/users/vkostyukov","html_url":"https://github.com/vkostyukov","followers_url":"https://api.github.com/users/vkostyukov/followers","following_url":"https://api.github.com/users/vkostyukov/following{/other_user}","gists_url":"https://api.github.com/users/vkostyukov/gists{/gist_id}","starred_url":"https://api.github.com/users/vkostyukov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vkostyukov/subscriptions","organizations_url":"https://api.github.com/users/vkostyukov/orgs","repos_url":"https://api.github.com/users/vkostyukov/repos","events_url":"https://api.github.com/users/vkostyukov/events{/privacy}","received_events_url":"https://api.github.com/users/vkostyukov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vkostyukov/la4j","description":"Linear Algebra for Java","fork":false,"url":"https://api.github.com/repos/vkostyukov/la4j","forks_url":"https://api.github.com/repos/vkostyukov/la4j/forks","keys_url":"https://api.github.com/repos/vkostyukov/la4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vkostyukov/la4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vkostyukov/la4j/teams","hooks_url":"https://api.github.com/repos/vkostyukov/la4j/hooks","issue_events_url":"https://api.github.com/repos/vkostyukov/la4j/issues/events{/number}","events_url":"https://api.github.com/repos/vkostyukov/la4j/events","assignees_url":"https://api.github.com/repos/vkostyukov/la4j/assignees{/user}","branches_url":"https://api.github.com/repos/vkostyukov/la4j/branches{/branch}","tags_url":"https://api.github.com/repos/vkostyukov/la4j/tags","blobs_url":"https://api.github.com/repos/vkostyukov/la4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vkostyukov/la4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vkostyukov/la4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/vkostyukov/la4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vkostyukov/la4j/statuses/{sha}","languages_url":"https://api.github.com/repos/vkostyukov/la4j/languages","stargazers_url":"https://api.github.com/repos/vkostyukov/la4j/stargazers","contributors_url":"https://api.github.com/repos/vkostyukov/la4j/contributors","subscribers_url":"https://api.github.com/repos/vkostyukov/la4j/subscribers","subscription_url":"https://api.github.com/repos/vkostyukov/la4j/subscription","commits_url":"https://api.github.com/repos/vkostyukov/la4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/vkostyukov/la4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/vkostyukov/la4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/vkostyukov/la4j/issues/comments/{number}","contents_url":"https://api.github.com/repos/vkostyukov/la4j/contents/{+path}","compare_url":"https://api.github.com/repos/vkostyukov/la4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vkostyukov/la4j/merges","archive_url":"https://api.github.com/repos/vkostyukov/la4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vkostyukov/la4j/downloads","issues_url":"https://api.github.com/repos/vkostyukov/la4j/issues{/number}","pulls_url":"https://api.github.com/repos/vkostyukov/la4j/pulls{/number}","milestones_url":"https://api.github.com/repos/vkostyukov/la4j/milestones{/number}","notifications_url":"https://api.github.com/repos/vkostyukov/la4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vkostyukov/la4j/labels{/name}","releases_url":"https://api.github.com/repos/vkostyukov/la4j/releases{/id}","created_at":"2012-12-19T05:33:56Z","updated_at":"2014-12-08T04:48:51Z","pushed_at":"2014-12-08T04:48:51Z","git_url":"git://github.com/vkostyukov/la4j.git","ssh_url":"git@github.com:vkostyukov/la4j.git","clone_url":"https://github.com/vkostyukov/la4j.git","svn_url":"https://github.com/vkostyukov/la4j","homepage":"http://la4j.org","size":3681,"stargazers_count":138,"watchers_count":138,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":54,"mirror_url":null,"open_issues_count":51,"forks":54,"open_issues":51,"watchers":138,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vkostyukov/la4j/pulls/233"},"html":{"href":"https://github.com/vkostyukov/la4j/pull/233"},"issue":{"href":"https://api.github.com/repos/vkostyukov/la4j/issues/233"},"comments":{"href":"https://api.github.com/repos/vkostyukov/la4j/issues/233/comments"},"review_comments":{"href":"https://api.github.com/repos/vkostyukov/la4j/pulls/233/comments"},"review_comment":{"href":"https://api.github.com/repos/vkostyukov/la4j/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/vkostyukov/la4j/pulls/233/commits"},"statuses":{"href":"https://api.github.com/repos/vkostyukov/la4j/statuses/fbbee093aebd224f7fc854bc75d6747675df3de1"}}}}