GitHub PullRequestEvent at 2014-09-22 02:36:20
Repository: scala
Actor: retronym
Payload: {"action":"closed","number":3991,"pull_request":{"url":"https://api.github.com/repos/scala/scala/pulls/3991","id":21545943,"html_url":"https://github.com/scala/scala/pull/3991","diff_url":"https://github.com/scala/scala/pull/3991.diff","patch_url":"https://github.com/scala/scala/pull/3991.patch","issue_url":"https://api.github.com/repos/scala/scala/issues/3991","number":3991,"state":"closed","locked":false,"title":"Scala parser cuts last bracket","user":{"login":"ajozwik","id":909625,"avatar_url":"https://avatars.githubusercontent.com/u/909625?v=2","gravatar_id":"bb1c10e76b3b540abcc2bf4889a0e52f","url":"https://api.github.com/users/ajozwik","html_url":"https://github.com/ajozwik","followers_url":"https://api.github.com/users/ajozwik/followers","following_url":"https://api.github.com/users/ajozwik/following{/other_user}","gists_url":"https://api.github.com/users/ajozwik/gists{/gist_id}","starred_url":"https://api.github.com/users/ajozwik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajozwik/subscriptions","organizations_url":"https://api.github.com/users/ajozwik/orgs","repos_url":"https://api.github.com/users/ajozwik/repos","events_url":"https://api.github.com/users/ajozwik/events{/privacy}","received_events_url":"https://api.github.com/users/ajozwik/received_events","type":"User","site_admin":false},"body":"In scenario [mirror.mkToolBox(options = \"-Yrangepos\")](http://stackoverflow.com/q/25547149/651140):\r\n```scala\r\nlibraryDependencies ++= Seq(\"org.scala-lang\" % \"scala-compiler\" % \"2.10.4\") map {\r\n    (dependency) =>{\r\n        dependency\r\n    }\r\n}\r\n```\r\nScala parser create tree with wrong RangePosition. In method: `scala.reflect.internal.Positions` `def atPos[T <: Tree](pos: Position)(tree: T): T` if the tree.pos is assigned - `pos` with correct `end` is ignored. So for the same tree method now check - if flag Yrangepos is set - and then replace `end` position of statement.\r\nI compiled some projects with this version of scala - and code works,  but I think - acceptance tests are needed.\r\n\r\nFor scala 2.11 the trait Positions was rewritten. For scala 2.10 I do not have fix. It is needed for https://github.com/sbt/sbt/issues/1606","created_at":"2014-09-21T08:09:56Z","updated_at":"2014-09-22T02:36:20Z","closed_at":"2014-09-22T02:36:20Z","merged_at":null,"merge_commit_sha":"a89bd973bfee2acf8ae6f025bfe4a8cfa1223887","assignee":null,"milestone":{"url":"https://api.github.com/repos/scala/scala/milestones/41","labels_url":"https://api.github.com/repos/scala/scala/milestones/41/labels","id":639718,"number":41,"title":"2.11.3","description":"Merge to 2.11.x.\r\n\r\n(Release Sep 29. PR queue closes Sep 19.)","creator":{"login":"adriaanm","id":91083,"avatar_url":"https://avatars.githubusercontent.com/u/91083?v=2","gravatar_id":"d573d4b8a6bd9e2f41611d8d566c533e","url":"https://api.github.com/users/adriaanm","html_url":"https://github.com/adriaanm","followers_url":"https://api.github.com/users/adriaanm/followers","following_url":"https://api.github.com/users/adriaanm/following{/other_user}","gists_url":"https://api.github.com/users/adriaanm/gists{/gist_id}","starred_url":"https://api.github.com/users/adriaanm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adriaanm/subscriptions","organizations_url":"https://api.github.com/users/adriaanm/orgs","repos_url":"https://api.github.com/users/adriaanm/repos","events_url":"https://api.github.com/users/adriaanm/events{/privacy}","received_events_url":"https://api.github.com/users/adriaanm/received_events","type":"User","site_admin":false},"open_issues":12,"closed_issues":73,"state":"open","created_at":"2014-04-24T21:44:19Z","updated_at":"2014-09-22T02:36:20Z","due_on":"2014-09-19T07:00:00Z"},"commits_url":"https://api.github.com/repos/scala/scala/pulls/3991/commits","review_comments_url":"https://api.github.com/repos/scala/scala/pulls/3991/comments","review_comment_url":"https://api.github.com/repos/scala/scala/pulls/comments/{number}","comments_url":"https://api.github.com/repos/scala/scala/issues/3991/comments","statuses_url":"https://api.github.com/repos/scala/scala/statuses/ac257319406f46a22679fe59ea77cf185dee8cb8","head":{"label":"ajozwik:2.11.x","ref":"2.11.x","sha":"ac257319406f46a22679fe59ea77cf185dee8cb8","user":{"login":"ajozwik","id":909625,"avatar_url":"https://avatars.githubusercontent.com/u/909625?v=2","gravatar_id":"bb1c10e76b3b540abcc2bf4889a0e52f","url":"https://api.github.com/users/ajozwik","html_url":"https://github.com/ajozwik","followers_url":"https://api.github.com/users/ajozwik/followers","following_url":"https://api.github.com/users/ajozwik/following{/other_user}","gists_url":"https://api.github.com/users/ajozwik/gists{/gist_id}","starred_url":"https://api.github.com/users/ajozwik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajozwik/subscriptions","organizations_url":"https://api.github.com/users/ajozwik/orgs","repos_url":"https://api.github.com/users/ajozwik/repos","events_url":"https://api.github.com/users/ajozwik/events{/privacy}","received_events_url":"https://api.github.com/users/ajozwik/received_events","type":"User","site_admin":false},"repo":{"id":24231072,"name":"scala","full_name":"ajozwik/scala","owner":{"login":"ajozwik","id":909625,"avatar_url":"https://avatars.githubusercontent.com/u/909625?v=2","gravatar_id":"bb1c10e76b3b540abcc2bf4889a0e52f","url":"https://api.github.com/users/ajozwik","html_url":"https://github.com/ajozwik","followers_url":"https://api.github.com/users/ajozwik/followers","following_url":"https://api.github.com/users/ajozwik/following{/other_user}","gists_url":"https://api.github.com/users/ajozwik/gists{/gist_id}","starred_url":"https://api.github.com/users/ajozwik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajozwik/subscriptions","organizations_url":"https://api.github.com/users/ajozwik/orgs","repos_url":"https://api.github.com/users/ajozwik/repos","events_url":"https://api.github.com/users/ajozwik/events{/privacy}","received_events_url":"https://api.github.com/users/ajozwik/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ajozwik/scala","description":"The Scala programming language","fork":true,"url":"https://api.github.com/repos/ajozwik/scala","forks_url":"https://api.github.com/repos/ajozwik/scala/forks","keys_url":"https://api.github.com/repos/ajozwik/scala/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ajozwik/scala/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ajozwik/scala/teams","hooks_url":"https://api.github.com/repos/ajozwik/scala/hooks","issue_events_url":"https://api.github.com/repos/ajozwik/scala/issues/events{/number}","events_url":"https://api.github.com/repos/ajozwik/scala/events","assignees_url":"https://api.github.com/repos/ajozwik/scala/assignees{/user}","branches_url":"https://api.github.com/repos/ajozwik/scala/branches{/branch}","tags_url":"https://api.github.com/repos/ajozwik/scala/tags","blobs_url":"https://api.github.com/repos/ajozwik/scala/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ajozwik/scala/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ajozwik/scala/git/refs{/sha}","trees_url":"https://api.github.com/repos/ajozwik/scala/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ajozwik/scala/statuses/{sha}","languages_url":"https://api.github.com/repos/ajozwik/scala/languages","stargazers_url":"https://api.github.com/repos/ajozwik/scala/stargazers","contributors_url":"https://api.github.com/repos/ajozwik/scala/contributors","subscribers_url":"https://api.github.com/repos/ajozwik/scala/subscribers","subscription_url":"https://api.github.com/repos/ajozwik/scala/subscription","commits_url":"https://api.github.com/repos/ajozwik/scala/commits{/sha}","git_commits_url":"https://api.github.com/repos/ajozwik/scala/git/commits{/sha}","comments_url":"https://api.github.com/repos/ajozwik/scala/comments{/number}","issue_comment_url":"https://api.github.com/repos/ajozwik/scala/issues/comments/{number}","contents_url":"https://api.github.com/repos/ajozwik/scala/contents/{+path}","compare_url":"https://api.github.com/repos/ajozwik/scala/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ajozwik/scala/merges","archive_url":"https://api.github.com/repos/ajozwik/scala/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ajozwik/scala/downloads","issues_url":"https://api.github.com/repos/ajozwik/scala/issues{/number}","pulls_url":"https://api.github.com/repos/ajozwik/scala/pulls{/number}","milestones_url":"https://api.github.com/repos/ajozwik/scala/milestones{/number}","notifications_url":"https://api.github.com/repos/ajozwik/scala/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ajozwik/scala/labels{/name}","releases_url":"https://api.github.com/repos/ajozwik/scala/releases{/id}","created_at":"2014-09-19T13:37:46Z","updated_at":"2014-09-19T13:49:52Z","pushed_at":"2014-09-19T13:49:44Z","git_url":"git://github.com/ajozwik/scala.git","ssh_url":"git@github.com:ajozwik/scala.git","clone_url":"https://github.com/ajozwik/scala.git","svn_url":"https://github.com/ajozwik/scala","homepage":"http://www.scala-lang.org/","size":81029,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"2.11.x"}},"base":{"label":"scala:2.11.x","ref":"2.11.x","sha":"379dbb0f6aa1d2d1233771a2dccec6c2dc584222","user":{"login":"scala","id":57059,"avatar_url":"https://avatars.githubusercontent.com/u/57059?v=2","gravatar_id":"034ea19230dbc7c67b487e6ba64127f0","url":"https://api.github.com/users/scala","html_url":"https://github.com/scala","followers_url":"https://api.github.com/users/scala/followers","following_url":"https://api.github.com/users/scala/following{/other_user}","gists_url":"https://api.github.com/users/scala/gists{/gist_id}","starred_url":"https://api.github.com/users/scala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scala/subscriptions","organizations_url":"https://api.github.com/users/scala/orgs","repos_url":"https://api.github.com/users/scala/repos","events_url":"https://api.github.com/users/scala/events{/privacy}","received_events_url":"https://api.github.com/users/scala/received_events","type":"Organization","site_admin":false},"repo":{"id":2888818,"name":"scala","full_name":"scala/scala","owner":{"login":"scala","id":57059,"avatar_url":"https://avatars.githubusercontent.com/u/57059?v=2","gravatar_id":"034ea19230dbc7c67b487e6ba64127f0","url":"https://api.github.com/users/scala","html_url":"https://github.com/scala","followers_url":"https://api.github.com/users/scala/followers","following_url":"https://api.github.com/users/scala/following{/other_user}","gists_url":"https://api.github.com/users/scala/gists{/gist_id}","starred_url":"https://api.github.com/users/scala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scala/subscriptions","organizations_url":"https://api.github.com/users/scala/orgs","repos_url":"https://api.github.com/users/scala/repos","events_url":"https://api.github.com/users/scala/events{/privacy}","received_events_url":"https://api.github.com/users/scala/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scala/scala","description":"The Scala programming language","fork":false,"url":"https://api.github.com/repos/scala/scala","forks_url":"https://api.github.com/repos/scala/scala/forks","keys_url":"https://api.github.com/repos/scala/scala/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scala/scala/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scala/scala/teams","hooks_url":"https://api.github.com/repos/scala/scala/hooks","issue_events_url":"https://api.github.com/repos/scala/scala/issues/events{/number}","events_url":"https://api.github.com/repos/scala/scala/events","assignees_url":"https://api.github.com/repos/scala/scala/assignees{/user}","branches_url":"https://api.github.com/repos/scala/scala/branches{/branch}","tags_url":"https://api.github.com/repos/scala/scala/tags","blobs_url":"https://api.github.com/repos/scala/scala/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scala/scala/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scala/scala/git/refs{/sha}","trees_url":"https://api.github.com/repos/scala/scala/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scala/scala/statuses/{sha}","languages_url":"https://api.github.com/repos/scala/scala/languages","stargazers_url":"https://api.github.com/repos/scala/scala/stargazers","contributors_url":"https://api.github.com/repos/scala/scala/contributors","subscribers_url":"https://api.github.com/repos/scala/scala/subscribers","subscription_url":"https://api.github.com/repos/scala/scala/subscription","commits_url":"https://api.github.com/repos/scala/scala/commits{/sha}","git_commits_url":"https://api.github.com/repos/scala/scala/git/commits{/sha}","comments_url":"https://api.github.com/repos/scala/scala/comments{/number}","issue_comment_url":"https://api.github.com/repos/scala/scala/issues/comments/{number}","contents_url":"https://api.github.com/repos/scala/scala/contents/{+path}","compare_url":"https://api.github.com/repos/scala/scala/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scala/scala/merges","archive_url":"https://api.github.com/repos/scala/scala/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scala/scala/downloads","issues_url":"https://api.github.com/repos/scala/scala/issues{/number}","pulls_url":"https://api.github.com/repos/scala/scala/pulls{/number}","milestones_url":"https://api.github.com/repos/scala/scala/milestones{/number}","notifications_url":"https://api.github.com/repos/scala/scala/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scala/scala/labels{/name}","releases_url":"https://api.github.com/repos/scala/scala/releases{/id}","created_at":"2011-12-01T05:02:34Z","updated_at":"2014-09-22T01:12:03Z","pushed_at":"2014-09-19T06:18:53Z","git_url":"git://github.com/scala/scala.git","ssh_url":"git@github.com:scala/scala.git","clone_url":"https://github.com/scala/scala.git","svn_url":"https://github.com/scala/scala","homepage":"http://www.scala-lang.org/","size":182534,"stargazers_count":2942,"watchers_count":2942,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":816,"mirror_url":null,"open_issues_count":16,"forks":816,"open_issues":16,"watchers":2942,"default_branch":"2.11.x"}},"_links":{"self":{"href":"https://api.github.com/repos/scala/scala/pulls/3991"},"html":{"href":"https://github.com/scala/scala/pull/3991"},"issue":{"href":"https://api.github.com/repos/scala/scala/issues/3991"},"comments":{"href":"https://api.github.com/repos/scala/scala/issues/3991/comments"},"review_comments":{"href":"https://api.github.com/repos/scala/scala/pulls/3991/comments"},"review_comment":{"href":"https://api.github.com/repos/scala/scala/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/scala/scala/pulls/3991/commits"},"statuses":{"href":"https://api.github.com/repos/scala/scala/statuses/ac257319406f46a22679fe59ea77cf185dee8cb8"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":3,"review_comments":0,"commits":1,"additions":12,"deletions":6,"changed_files":1}}