GitHub PullRequestReviewCommentEvent at 2014-10-06 22:16:37
Repository: MinecraftForge
Actor: 50Wliu
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/comments/18489764","id":18489764,"diff_hunk":"@@ -1,21 +1,108 @@\n --- ../src-base/minecraft/net/minecraft/world/Explosion.java\n +++ ../src-work/minecraft/net/minecraft/world/Explosion.java\n-@@ -86,7 +86,7 @@\n- \n-                             if (block.func_149688_o() != Material.field_151579_a)\n-                             {\n--                                float f3 = this.field_77283_e != null ? this.field_77283_e.func_145772_a(this, this.field_77287_j, j1, k1, l1, block) : block.func_149638_a(this.field_77283_e);\n-+                                float f3 = this.field_77283_e != null ? this.field_77283_e.func_145772_a(this, this.field_77287_j, j1, k1, l1, block) : block.getExplosionResistance(this.field_77283_e, field_77287_j, j1, k1, l1, field_77284_b, field_77285_c, field_77282_d);\n-                                 f1 -= (f3 + 0.3F) * f2;\n-                             }\n- \n-@@ -211,8 +211,7 @@\n-                         block.func_149690_a(this.field_77287_j, i, j, k, this.field_77287_j.func_72805_g(i, j, k), 1.0F / this.field_77280_f, 0);\n-                     }\n- \n--                    this.field_77287_j.func_147465_d(i, j, k, Blocks.field_150350_a, 0, 3);\n--                    block.func_149723_a(this.field_77287_j, i, j, k, this);\n-+                    block.onBlockExploded(this.field_77287_j, i, j, k, this);\n+@@ -19,6 +19,8 @@\n+ import net.minecraft.util.DamageSource;\n+ import net.minecraft.util.MathHelper;\n+ import net.minecraft.util.Vec3;\n++import net.minecraftforge.common.MinecraftForge;\n++import net.minecraftforge.event.world.ExplosionEvent;\n+ \n+ public class Explosion\n+ {\n+@@ -33,7 +35,9 @@\n+     public Entity field_77283_e;\n+     public float field_77280_f;\n+     public List field_77281_g = new ArrayList();\n++    public List affectedEntities = new ArrayList();\n+     private Map field_77288_k = new HashMap();\n++    private boolean cancelled = false;\n+     private static final String __OBFID = \"CL_00000134\";\n+ \n+     public Explosion(World p_i1948_1_, Entity p_i1948_2_, double p_i1948_3_, double p_i1948_5_, double p_i1948_7_, float p_i1948_9_)\n+@@ -56,6 +60,23 @@\n+         double d5;\n+         double d6;\n+         double d7;\n++        \n++        \n++        \n++        ExplosionEvent.Pre explosionPreEvent = new ExplosionEvent.Pre(this, field_77284_b, field_77285_c, field_77282_d, field_77287_j, field_77283_e, func_94613_c(), field_77280_f, field_77286_a, field_82755_b);\n++        \n++        if(MinecraftForge.EVENT_BUS.post(explosionPreEvent))\n++        {\n++            cancelled = true;\n++            return;\n++        }\n++        \n++        field_77280_f = explosionPreEvent.explosionSize;\n++        f = explosionPreEvent.explosionSize;\n++        field_77286_a = explosionPreEvent.isFlaming;\n++        field_82755_b = explosionPreEvent.isSmoking;\n++        \n++        \n+ \n+         for (i = 0; i < this.field_77289_h; ++i)\n+         {\n+@@ -103,6 +124,8 @@\n+                 }\n+             }\n+         }\n++        \n++        ","path":"patches/minecraft/net/minecraft/world/Explosion.java.patch","position":67,"original_position":67,"commit_id":"f380c1cc9313e6ccc0892a0ed5e4fce528064813","original_commit_id":"f380c1cc9313e6ccc0892a0ed5e4fce528064813","user":{"login":"50Wliu","id":2766036,"avatar_url":"https://avatars.githubusercontent.com/u/2766036?v=2","gravatar_id":"","url":"https://api.github.com/users/50Wliu","html_url":"https://github.com/50Wliu","followers_url":"https://api.github.com/users/50Wliu/followers","following_url":"https://api.github.com/users/50Wliu/following{/other_user}","gists_url":"https://api.github.com/users/50Wliu/gists{/gist_id}","starred_url":"https://api.github.com/users/50Wliu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/50Wliu/subscriptions","organizations_url":"https://api.github.com/users/50Wliu/orgs","repos_url":"https://api.github.com/users/50Wliu/repos","events_url":"https://api.github.com/users/50Wliu/events{/privacy}","received_events_url":"https://api.github.com/users/50Wliu/received_events","type":"User","site_admin":false},"body":"What","created_at":"2014-10-06T22:16:37Z","updated_at":"2014-10-06T22:16:37Z","html_url":"https://github.com/MinecraftForge/MinecraftForge/pull/1444#discussion_r18489764","pull_request_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/1444","_links":{"self":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/comments/18489764"},"html":{"href":"https://github.com/MinecraftForge/MinecraftForge/pull/1444#discussion_r18489764"},"pull_request":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/1444"}}},"pull_request":{"url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/1444","id":22318289,"html_url":"https://github.com/MinecraftForge/MinecraftForge/pull/1444","diff_url":"https://github.com/MinecraftForge/MinecraftForge/pull/1444.diff","patch_url":"https://github.com/MinecraftForge/MinecraftForge/pull/1444.patch","issue_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/1444","number":1444,"state":"open","locked":false,"title":"ExplosionEvent","user":{"login":"HaniiPuppy","id":6645766,"avatar_url":"https://avatars.githubusercontent.com/u/6645766?v=2","gravatar_id":"","url":"https://api.github.com/users/HaniiPuppy","html_url":"https://github.com/HaniiPuppy","followers_url":"https://api.github.com/users/HaniiPuppy/followers","following_url":"https://api.github.com/users/HaniiPuppy/following{/other_user}","gists_url":"https://api.github.com/users/HaniiPuppy/gists{/gist_id}","starred_url":"https://api.github.com/users/HaniiPuppy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HaniiPuppy/subscriptions","organizations_url":"https://api.github.com/users/HaniiPuppy/orgs","repos_url":"https://api.github.com/users/HaniiPuppy/repos","events_url":"https://api.github.com/users/HaniiPuppy/events{/privacy}","received_events_url":"https://api.github.com/users/HaniiPuppy/received_events","type":"User","site_admin":false},"body":"Creates net.minecraftforge.event.world.ExplosionEvent, and implements it in net.minecraft.world.Explosion.\r\n\r\nThree events are created to cover pre, during, and post. During is provided in addition to pre and post to allow for affectedEntities and affectedBlocks to be mutable. ExplosionSize is only mutable for listeners listening to ExplosionEvent.Pre","created_at":"2014-10-06T22:10:29Z","updated_at":"2014-10-06T22:16:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cee9a3fa5caa0dbc3688831a4c18c0d32f9c7389","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/1444/commits","review_comments_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/1444/comments","review_comment_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/comments/{number}","comments_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/1444/comments","statuses_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/statuses/f380c1cc9313e6ccc0892a0ed5e4fce528064813","head":{"label":"HaniiPuppy:master","ref":"master","sha":"f380c1cc9313e6ccc0892a0ed5e4fce528064813","user":{"login":"HaniiPuppy","id":6645766,"avatar_url":"https://avatars.githubusercontent.com/u/6645766?v=2","gravatar_id":"","url":"https://api.github.com/users/HaniiPuppy","html_url":"https://github.com/HaniiPuppy","followers_url":"https://api.github.com/users/HaniiPuppy/followers","following_url":"https://api.github.com/users/HaniiPuppy/following{/other_user}","gists_url":"https://api.github.com/users/HaniiPuppy/gists{/gist_id}","starred_url":"https://api.github.com/users/HaniiPuppy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HaniiPuppy/subscriptions","organizations_url":"https://api.github.com/users/HaniiPuppy/orgs","repos_url":"https://api.github.com/users/HaniiPuppy/repos","events_url":"https://api.github.com/users/HaniiPuppy/events{/privacy}","received_events_url":"https://api.github.com/users/HaniiPuppy/received_events","type":"User","site_admin":false},"repo":{"id":24865803,"name":"MinecraftForge","full_name":"HaniiPuppy/MinecraftForge","owner":{"login":"HaniiPuppy","id":6645766,"avatar_url":"https://avatars.githubusercontent.com/u/6645766?v=2","gravatar_id":"","url":"https://api.github.com/users/HaniiPuppy","html_url":"https://github.com/HaniiPuppy","followers_url":"https://api.github.com/users/HaniiPuppy/followers","following_url":"https://api.github.com/users/HaniiPuppy/following{/other_user}","gists_url":"https://api.github.com/users/HaniiPuppy/gists{/gist_id}","starred_url":"https://api.github.com/users/HaniiPuppy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HaniiPuppy/subscriptions","organizations_url":"https://api.github.com/users/HaniiPuppy/orgs","repos_url":"https://api.github.com/users/HaniiPuppy/repos","events_url":"https://api.github.com/users/HaniiPuppy/events{/privacy}","received_events_url":"https://api.github.com/users/HaniiPuppy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/HaniiPuppy/MinecraftForge","description":"Modifications to the Minecraft base files to assist in compatibility between mods.","fork":true,"url":"https://api.github.com/repos/HaniiPuppy/MinecraftForge","forks_url":"https://api.github.com/repos/HaniiPuppy/MinecraftForge/forks","keys_url":"https://api.github.com/repos/HaniiPuppy/MinecraftForge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HaniiPuppy/MinecraftForge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HaniiPuppy/MinecraftForge/teams","hooks_url":"https://api.github.com/repos/HaniiPuppy/MinecraftForge/hooks","issue_events_url":"https://api.github.com/repos/HaniiPuppy/MinecraftForge/issues/events{/number}","events_url":"https://api.github.com/repos/HaniiPuppy/MinecraftForge/events","assignees_url":"https://api.github.com/repos/HaniiPuppy/MinecraftForge/assignees{/user}","branches_url":"https://api.github.com/repos/HaniiPuppy/MinecraftForge/branches{/branch}","tags_url":"https://api.github.com/repos/HaniiPuppy/MinecraftForge/tags","blobs_url":"https://api.github.com/repos/HaniiPuppy/MinecraftForge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HaniiPuppy/MinecraftForge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HaniiPuppy/MinecraftForge/git/refs{/sha}","trees_url":"https://api.github.com/repos/HaniiPuppy/MinecraftForge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HaniiPuppy/MinecraftForge/statuses/{sha}","languages_url":"https://api.github.com/repos/HaniiPuppy/MinecraftForge/languages","stargazers_url":"https://api.github.com/repos/HaniiPuppy/MinecraftForge/stargazers","contributors_url":"https://api.github.com/repos/HaniiPuppy/MinecraftForge/contributors","subscribers_url":"https://api.github.com/repos/HaniiPuppy/MinecraftForge/subscribers","subscription_url":"https://api.github.com/repos/HaniiPuppy/MinecraftForge/subscription","commits_url":"https://api.github.com/repos/HaniiPuppy/MinecraftForge/commits{/sha}","git_commits_url":"https://api.github.com/repos/HaniiPuppy/MinecraftForge/git/commits{/sha}","comments_url":"https://api.github.com/repos/HaniiPuppy/MinecraftForge/comments{/number}","issue_comment_url":"https://api.github.com/repos/HaniiPuppy/MinecraftForge/issues/comments/{number}","contents_url":"https://api.github.com/repos/HaniiPuppy/MinecraftForge/contents/{+path}","compare_url":"https://api.github.com/repos/HaniiPuppy/MinecraftForge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HaniiPuppy/MinecraftForge/merges","archive_url":"https://api.github.com/repos/HaniiPuppy/MinecraftForge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HaniiPuppy/MinecraftForge/downloads","issues_url":"https://api.github.com/repos/HaniiPuppy/MinecraftForge/issues{/number}","pulls_url":"https://api.github.com/repos/HaniiPuppy/MinecraftForge/pulls{/number}","milestones_url":"https://api.github.com/repos/HaniiPuppy/MinecraftForge/milestones{/number}","notifications_url":"https://api.github.com/repos/HaniiPuppy/MinecraftForge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HaniiPuppy/MinecraftForge/labels{/name}","releases_url":"https://api.github.com/repos/HaniiPuppy/MinecraftForge/releases{/id}","created_at":"2014-10-06T21:33:08Z","updated_at":"2014-10-06T21:58:54Z","pushed_at":"2014-10-06T22:02:11Z","git_url":"git://github.com/HaniiPuppy/MinecraftForge.git","ssh_url":"git@github.com:HaniiPuppy/MinecraftForge.git","clone_url":"https://github.com/HaniiPuppy/MinecraftForge.git","svn_url":"https://github.com/HaniiPuppy/MinecraftForge","homepage":"","size":129808,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"MinecraftForge:master","ref":"master","sha":"6da8a19094ff4c00e22e0639ca7446694c5defec","user":{"login":"MinecraftForge","id":1390178,"avatar_url":"https://avatars.githubusercontent.com/u/1390178?v=2","gravatar_id":"","url":"https://api.github.com/users/MinecraftForge","html_url":"https://github.com/MinecraftForge","followers_url":"https://api.github.com/users/MinecraftForge/followers","following_url":"https://api.github.com/users/MinecraftForge/following{/other_user}","gists_url":"https://api.github.com/users/MinecraftForge/gists{/gist_id}","starred_url":"https://api.github.com/users/MinecraftForge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MinecraftForge/subscriptions","organizations_url":"https://api.github.com/users/MinecraftForge/orgs","repos_url":"https://api.github.com/users/MinecraftForge/repos","events_url":"https://api.github.com/users/MinecraftForge/events{/privacy}","received_events_url":"https://api.github.com/users/MinecraftForge/received_events","type":"Organization","site_admin":false},"repo":{"id":3301400,"name":"MinecraftForge","full_name":"MinecraftForge/MinecraftForge","owner":{"login":"MinecraftForge","id":1390178,"avatar_url":"https://avatars.githubusercontent.com/u/1390178?v=2","gravatar_id":"","url":"https://api.github.com/users/MinecraftForge","html_url":"https://github.com/MinecraftForge","followers_url":"https://api.github.com/users/MinecraftForge/followers","following_url":"https://api.github.com/users/MinecraftForge/following{/other_user}","gists_url":"https://api.github.com/users/MinecraftForge/gists{/gist_id}","starred_url":"https://api.github.com/users/MinecraftForge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MinecraftForge/subscriptions","organizations_url":"https://api.github.com/users/MinecraftForge/orgs","repos_url":"https://api.github.com/users/MinecraftForge/repos","events_url":"https://api.github.com/users/MinecraftForge/events{/privacy}","received_events_url":"https://api.github.com/users/MinecraftForge/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MinecraftForge/MinecraftForge","description":"Modifications to the Minecraft base files to assist in compatibility between mods.","fork":false,"url":"https://api.github.com/repos/MinecraftForge/MinecraftForge","forks_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/forks","keys_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/teams","hooks_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/hooks","issue_events_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/events{/number}","events_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/events","assignees_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/assignees{/user}","branches_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/branches{/branch}","tags_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/tags","blobs_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/git/refs{/sha}","trees_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/statuses/{sha}","languages_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/languages","stargazers_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/stargazers","contributors_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/contributors","subscribers_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/subscribers","subscription_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/subscription","commits_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/commits{/sha}","git_commits_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/git/commits{/sha}","comments_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/comments{/number}","issue_comment_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/comments/{number}","contents_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/contents/{+path}","compare_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/merges","archive_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/downloads","issues_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues{/number}","pulls_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls{/number}","milestones_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/milestones{/number}","notifications_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/labels{/name}","releases_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/releases{/id}","created_at":"2012-01-30T01:35:01Z","updated_at":"2014-10-05T02:01:50Z","pushed_at":"2014-10-06T22:12:13Z","git_url":"git://github.com/MinecraftForge/MinecraftForge.git","ssh_url":"git@github.com:MinecraftForge/MinecraftForge.git","clone_url":"https://github.com/MinecraftForge/MinecraftForge.git","svn_url":"https://github.com/MinecraftForge/MinecraftForge","homepage":"","size":129808,"stargazers_count":762,"watchers_count":762,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":467,"mirror_url":null,"open_issues_count":113,"forks":467,"open_issues":113,"watchers":762,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/1444"},"html":{"href":"https://github.com/MinecraftForge/MinecraftForge/pull/1444"},"issue":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/1444"},"comments":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/1444/comments"},"review_comments":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/1444/comments"},"review_comment":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/1444/commits"},"statuses":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/statuses/f380c1cc9313e6ccc0892a0ed5e4fce528064813"}}}}