GitHub PullRequestReviewCommentEvent at 2014-10-06 18:37:20
Repository: vraptor4
Actor: lucascs
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/caelum/vraptor4/pulls/comments/18475956","id":18475956,"diff_hunk":"@@ -42,7 +44,7 @@\n  */\n public class JstlLocalizationTest {\n \n-\tstatic final Locale PT_BR = new Locale(\"pt\", \"BR\");\n+\tprivate static final Locale PORTUGUESE_BRAZIL = new Locale(\"pt\", \"BR\");","path":"vraptor-core/src/test/java/br/com/caelum/vraptor/core/JstlLocalizationTest.java","position":14,"original_position":14,"commit_id":"bcd2bd4e2059a3625d7d3fb90861cabf4171442d","original_commit_id":"bcd2bd4e2059a3625d7d3fb90861cabf4171442d","user":{"login":"lucascs","id":46113,"avatar_url":"https://avatars.githubusercontent.com/u/46113?v=2","gravatar_id":"","url":"https://api.github.com/users/lucascs","html_url":"https://github.com/lucascs","followers_url":"https://api.github.com/users/lucascs/followers","following_url":"https://api.github.com/users/lucascs/following{/other_user}","gists_url":"https://api.github.com/users/lucascs/gists{/gist_id}","starred_url":"https://api.github.com/users/lucascs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucascs/subscriptions","organizations_url":"https://api.github.com/users/lucascs/orgs","repos_url":"https://api.github.com/users/lucascs/repos","events_url":"https://api.github.com/users/lucascs/events{/privacy}","received_events_url":"https://api.github.com/users/lucascs/received_events","type":"User","site_admin":false},"body":"I prefer `PT_BR`","created_at":"2014-10-06T18:37:20Z","updated_at":"2014-10-06T18:37:20Z","html_url":"https://github.com/caelum/vraptor4/pull/829#discussion_r18475956","pull_request_url":"https://api.github.com/repos/caelum/vraptor4/pulls/829","_links":{"self":{"href":"https://api.github.com/repos/caelum/vraptor4/pulls/comments/18475956"},"html":{"href":"https://github.com/caelum/vraptor4/pull/829#discussion_r18475956"},"pull_request":{"href":"https://api.github.com/repos/caelum/vraptor4/pulls/829"}}},"pull_request":{"url":"https://api.github.com/repos/caelum/vraptor4/pulls/829","id":22238037,"html_url":"https://github.com/caelum/vraptor4/pull/829","diff_url":"https://github.com/caelum/vraptor4/pull/829.diff","patch_url":"https://github.com/caelum/vraptor4/pull/829.patch","issue_url":"https://api.github.com/repos/caelum/vraptor4/issues/829","number":829,"state":"open","locked":false,"title":"Internal improvements for JstlLocalization and unit tests","user":{"login":"garcia-jj","id":140387,"avatar_url":"https://avatars.githubusercontent.com/u/140387?v=2","gravatar_id":"","url":"https://api.github.com/users/garcia-jj","html_url":"https://github.com/garcia-jj","followers_url":"https://api.github.com/users/garcia-jj/followers","following_url":"https://api.github.com/users/garcia-jj/following{/other_user}","gists_url":"https://api.github.com/users/garcia-jj/gists{/gist_id}","starred_url":"https://api.github.com/users/garcia-jj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garcia-jj/subscriptions","organizations_url":"https://api.github.com/users/garcia-jj/orgs","repos_url":"https://api.github.com/users/garcia-jj/repos","events_url":"https://api.github.com/users/garcia-jj/events{/privacy}","received_events_url":"https://api.github.com/users/garcia-jj/received_events","type":"User","site_admin":false},"body":"With this pull request, we lookup `Locale` using a Java 7 method to do this. Some test methods are renamed to a better name.\r\n\r\nThe `getBundle()` producer have a parameter `Locale` added to allow us to receive a injected object. So we can create an alternative producer if nedded. And using injected `Locale` we avoid method `getLocale()` called twice.","created_at":"2014-10-04T00:55:31Z","updated_at":"2014-10-06T18:37:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f7f925c42aca0f947d6c227fb43e54d7e0d5219b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/caelum/vraptor4/pulls/829/commits","review_comments_url":"https://api.github.com/repos/caelum/vraptor4/pulls/829/comments","review_comment_url":"https://api.github.com/repos/caelum/vraptor4/pulls/comments/{number}","comments_url":"https://api.github.com/repos/caelum/vraptor4/issues/829/comments","statuses_url":"https://api.github.com/repos/caelum/vraptor4/statuses/bcd2bd4e2059a3625d7d3fb90861cabf4171442d","head":{"label":"caelum:ot-l10n-refactor","ref":"ot-l10n-refactor","sha":"bcd2bd4e2059a3625d7d3fb90861cabf4171442d","user":{"login":"caelum","id":65012,"avatar_url":"https://avatars.githubusercontent.com/u/65012?v=2","gravatar_id":"","url":"https://api.github.com/users/caelum","html_url":"https://github.com/caelum","followers_url":"https://api.github.com/users/caelum/followers","following_url":"https://api.github.com/users/caelum/following{/other_user}","gists_url":"https://api.github.com/users/caelum/gists{/gist_id}","starred_url":"https://api.github.com/users/caelum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caelum/subscriptions","organizations_url":"https://api.github.com/users/caelum/orgs","repos_url":"https://api.github.com/users/caelum/repos","events_url":"https://api.github.com/users/caelum/events{/privacy}","received_events_url":"https://api.github.com/users/caelum/received_events","type":"Organization","site_admin":false},"repo":{"id":9821876,"name":"vraptor4","full_name":"caelum/vraptor4","owner":{"login":"caelum","id":65012,"avatar_url":"https://avatars.githubusercontent.com/u/65012?v=2","gravatar_id":"","url":"https://api.github.com/users/caelum","html_url":"https://github.com/caelum","followers_url":"https://api.github.com/users/caelum/followers","following_url":"https://api.github.com/users/caelum/following{/other_user}","gists_url":"https://api.github.com/users/caelum/gists{/gist_id}","starred_url":"https://api.github.com/users/caelum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caelum/subscriptions","organizations_url":"https://api.github.com/users/caelum/orgs","repos_url":"https://api.github.com/users/caelum/repos","events_url":"https://api.github.com/users/caelum/events{/privacy}","received_events_url":"https://api.github.com/users/caelum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/caelum/vraptor4","description":"A Java web MVC action-based framework","fork":false,"url":"https://api.github.com/repos/caelum/vraptor4","forks_url":"https://api.github.com/repos/caelum/vraptor4/forks","keys_url":"https://api.github.com/repos/caelum/vraptor4/keys{/key_id}","collaborators_url":"https://api.github.com/repos/caelum/vraptor4/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/caelum/vraptor4/teams","hooks_url":"https://api.github.com/repos/caelum/vraptor4/hooks","issue_events_url":"https://api.github.com/repos/caelum/vraptor4/issues/events{/number}","events_url":"https://api.github.com/repos/caelum/vraptor4/events","assignees_url":"https://api.github.com/repos/caelum/vraptor4/assignees{/user}","branches_url":"https://api.github.com/repos/caelum/vraptor4/branches{/branch}","tags_url":"https://api.github.com/repos/caelum/vraptor4/tags","blobs_url":"https://api.github.com/repos/caelum/vraptor4/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/caelum/vraptor4/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/caelum/vraptor4/git/refs{/sha}","trees_url":"https://api.github.com/repos/caelum/vraptor4/git/trees{/sha}","statuses_url":"https://api.github.com/repos/caelum/vraptor4/statuses/{sha}","languages_url":"https://api.github.com/repos/caelum/vraptor4/languages","stargazers_url":"https://api.github.com/repos/caelum/vraptor4/stargazers","contributors_url":"https://api.github.com/repos/caelum/vraptor4/contributors","subscribers_url":"https://api.github.com/repos/caelum/vraptor4/subscribers","subscription_url":"https://api.github.com/repos/caelum/vraptor4/subscription","commits_url":"https://api.github.com/repos/caelum/vraptor4/commits{/sha}","git_commits_url":"https://api.github.com/repos/caelum/vraptor4/git/commits{/sha}","comments_url":"https://api.github.com/repos/caelum/vraptor4/comments{/number}","issue_comment_url":"https://api.github.com/repos/caelum/vraptor4/issues/comments/{number}","contents_url":"https://api.github.com/repos/caelum/vraptor4/contents/{+path}","compare_url":"https://api.github.com/repos/caelum/vraptor4/compare/{base}...{head}","merges_url":"https://api.github.com/repos/caelum/vraptor4/merges","archive_url":"https://api.github.com/repos/caelum/vraptor4/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/caelum/vraptor4/downloads","issues_url":"https://api.github.com/repos/caelum/vraptor4/issues{/number}","pulls_url":"https://api.github.com/repos/caelum/vraptor4/pulls{/number}","milestones_url":"https://api.github.com/repos/caelum/vraptor4/milestones{/number}","notifications_url":"https://api.github.com/repos/caelum/vraptor4/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/caelum/vraptor4/labels{/name}","releases_url":"https://api.github.com/repos/caelum/vraptor4/releases{/id}","created_at":"2013-05-02T20:22:14Z","updated_at":"2014-10-02T09:24:56Z","pushed_at":"2014-10-06T17:01:41Z","git_url":"git://github.com/caelum/vraptor4.git","ssh_url":"git@github.com:caelum/vraptor4.git","clone_url":"https://github.com/caelum/vraptor4.git","svn_url":"https://github.com/caelum/vraptor4","homepage":"vraptor.org","size":26570,"stargazers_count":138,"watchers_count":138,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":105,"mirror_url":null,"open_issues_count":30,"forks":105,"open_issues":30,"watchers":138,"default_branch":"master"}},"base":{"label":"caelum:master","ref":"master","sha":"f76ca73d273008eb5453466e4a0cbfc7635d1056","user":{"login":"caelum","id":65012,"avatar_url":"https://avatars.githubusercontent.com/u/65012?v=2","gravatar_id":"","url":"https://api.github.com/users/caelum","html_url":"https://github.com/caelum","followers_url":"https://api.github.com/users/caelum/followers","following_url":"https://api.github.com/users/caelum/following{/other_user}","gists_url":"https://api.github.com/users/caelum/gists{/gist_id}","starred_url":"https://api.github.com/users/caelum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caelum/subscriptions","organizations_url":"https://api.github.com/users/caelum/orgs","repos_url":"https://api.github.com/users/caelum/repos","events_url":"https://api.github.com/users/caelum/events{/privacy}","received_events_url":"https://api.github.com/users/caelum/received_events","type":"Organization","site_admin":false},"repo":{"id":9821876,"name":"vraptor4","full_name":"caelum/vraptor4","owner":{"login":"caelum","id":65012,"avatar_url":"https://avatars.githubusercontent.com/u/65012?v=2","gravatar_id":"","url":"https://api.github.com/users/caelum","html_url":"https://github.com/caelum","followers_url":"https://api.github.com/users/caelum/followers","following_url":"https://api.github.com/users/caelum/following{/other_user}","gists_url":"https://api.github.com/users/caelum/gists{/gist_id}","starred_url":"https://api.github.com/users/caelum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caelum/subscriptions","organizations_url":"https://api.github.com/users/caelum/orgs","repos_url":"https://api.github.com/users/caelum/repos","events_url":"https://api.github.com/users/caelum/events{/privacy}","received_events_url":"https://api.github.com/users/caelum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/caelum/vraptor4","description":"A Java web MVC action-based framework","fork":false,"url":"https://api.github.com/repos/caelum/vraptor4","forks_url":"https://api.github.com/repos/caelum/vraptor4/forks","keys_url":"https://api.github.com/repos/caelum/vraptor4/keys{/key_id}","collaborators_url":"https://api.github.com/repos/caelum/vraptor4/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/caelum/vraptor4/teams","hooks_url":"https://api.github.com/repos/caelum/vraptor4/hooks","issue_events_url":"https://api.github.com/repos/caelum/vraptor4/issues/events{/number}","events_url":"https://api.github.com/repos/caelum/vraptor4/events","assignees_url":"https://api.github.com/repos/caelum/vraptor4/assignees{/user}","branches_url":"https://api.github.com/repos/caelum/vraptor4/branches{/branch}","tags_url":"https://api.github.com/repos/caelum/vraptor4/tags","blobs_url":"https://api.github.com/repos/caelum/vraptor4/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/caelum/vraptor4/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/caelum/vraptor4/git/refs{/sha}","trees_url":"https://api.github.com/repos/caelum/vraptor4/git/trees{/sha}","statuses_url":"https://api.github.com/repos/caelum/vraptor4/statuses/{sha}","languages_url":"https://api.github.com/repos/caelum/vraptor4/languages","stargazers_url":"https://api.github.com/repos/caelum/vraptor4/stargazers","contributors_url":"https://api.github.com/repos/caelum/vraptor4/contributors","subscribers_url":"https://api.github.com/repos/caelum/vraptor4/subscribers","subscription_url":"https://api.github.com/repos/caelum/vraptor4/subscription","commits_url":"https://api.github.com/repos/caelum/vraptor4/commits{/sha}","git_commits_url":"https://api.github.com/repos/caelum/vraptor4/git/commits{/sha}","comments_url":"https://api.github.com/repos/caelum/vraptor4/comments{/number}","issue_comment_url":"https://api.github.com/repos/caelum/vraptor4/issues/comments/{number}","contents_url":"https://api.github.com/repos/caelum/vraptor4/contents/{+path}","compare_url":"https://api.github.com/repos/caelum/vraptor4/compare/{base}...{head}","merges_url":"https://api.github.com/repos/caelum/vraptor4/merges","archive_url":"https://api.github.com/repos/caelum/vraptor4/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/caelum/vraptor4/downloads","issues_url":"https://api.github.com/repos/caelum/vraptor4/issues{/number}","pulls_url":"https://api.github.com/repos/caelum/vraptor4/pulls{/number}","milestones_url":"https://api.github.com/repos/caelum/vraptor4/milestones{/number}","notifications_url":"https://api.github.com/repos/caelum/vraptor4/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/caelum/vraptor4/labels{/name}","releases_url":"https://api.github.com/repos/caelum/vraptor4/releases{/id}","created_at":"2013-05-02T20:22:14Z","updated_at":"2014-10-02T09:24:56Z","pushed_at":"2014-10-06T17:01:41Z","git_url":"git://github.com/caelum/vraptor4.git","ssh_url":"git@github.com:caelum/vraptor4.git","clone_url":"https://github.com/caelum/vraptor4.git","svn_url":"https://github.com/caelum/vraptor4","homepage":"vraptor.org","size":26570,"stargazers_count":138,"watchers_count":138,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":105,"mirror_url":null,"open_issues_count":30,"forks":105,"open_issues":30,"watchers":138,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/caelum/vraptor4/pulls/829"},"html":{"href":"https://github.com/caelum/vraptor4/pull/829"},"issue":{"href":"https://api.github.com/repos/caelum/vraptor4/issues/829"},"comments":{"href":"https://api.github.com/repos/caelum/vraptor4/issues/829/comments"},"review_comments":{"href":"https://api.github.com/repos/caelum/vraptor4/pulls/829/comments"},"review_comment":{"href":"https://api.github.com/repos/caelum/vraptor4/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/caelum/vraptor4/pulls/829/commits"},"statuses":{"href":"https://api.github.com/repos/caelum/vraptor4/statuses/bcd2bd4e2059a3625d7d3fb90861cabf4171442d"}}}}