GitHub PullRequestReviewCommentEvent at 2014-12-12 21:59:24
Repository: fireplace
Actor: cvan
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/fireplace/pulls/comments/21776259","id":21776259,"diff_hunk":"@@ -8,6 +8,13 @@ define('views/recommended',\n \n     var app_models = models('app');\n \n+    z.page.on('before_logout', function() {\n+        if (window.location.pathname === urls.reverse('recommended')) {","path":"src/media/js/views/recommended.js","position":14,"original_position":14,"commit_id":"7eef5297ec91095f58344bcc993324680dbd41d0","original_commit_id":"5f2727a3ad86aa0a62069a7fc9c0ea34a61b2d12","user":{"login":"cvan","id":203725,"avatar_url":"https://avatars.githubusercontent.com/u/203725?v=3","gravatar_id":"","url":"https://api.github.com/users/cvan","html_url":"https://github.com/cvan","followers_url":"https://api.github.com/users/cvan/followers","following_url":"https://api.github.com/users/cvan/following{/other_user}","gists_url":"https://api.github.com/users/cvan/gists{/gist_id}","starred_url":"https://api.github.com/users/cvan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cvan/subscriptions","organizations_url":"https://api.github.com/users/cvan/orgs","repos_url":"https://api.github.com/users/cvan/repos","events_url":"https://api.github.com/users/cvan/events{/privacy}","received_events_url":"https://api.github.com/users/cvan/received_events","type":"User","site_admin":false},"body":"all I request is be careful with overriding people's history with `replaceState`/`divert`.","created_at":"2014-12-12T21:59:24Z","updated_at":"2014-12-12T21:59:24Z","html_url":"https://github.com/mozilla/fireplace/pull/847#discussion_r21776259","pull_request_url":"https://api.github.com/repos/mozilla/fireplace/pulls/847","_links":{"self":{"href":"https://api.github.com/repos/mozilla/fireplace/pulls/comments/21776259"},"html":{"href":"https://github.com/mozilla/fireplace/pull/847#discussion_r21776259"},"pull_request":{"href":"https://api.github.com/repos/mozilla/fireplace/pulls/847"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/fireplace/pulls/847","id":25939318,"html_url":"https://github.com/mozilla/fireplace/pull/847","diff_url":"https://github.com/mozilla/fireplace/pull/847.diff","patch_url":"https://github.com/mozilla/fireplace/pull/847.patch","issue_url":"https://api.github.com/repos/mozilla/fireplace/issues/847","number":847,"state":"open","locked":false,"title":"Redirect user if logging out from recommended (bug 1110326)","user":{"login":"robhudson","id":1106,"avatar_url":"https://avatars.githubusercontent.com/u/1106?v=3","gravatar_id":"","url":"https://api.github.com/users/robhudson","html_url":"https://github.com/robhudson","followers_url":"https://api.github.com/users/robhudson/followers","following_url":"https://api.github.com/users/robhudson/following{/other_user}","gists_url":"https://api.github.com/users/robhudson/gists{/gist_id}","starred_url":"https://api.github.com/users/robhudson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robhudson/subscriptions","organizations_url":"https://api.github.com/users/robhudson/orgs","repos_url":"https://api.github.com/users/robhudson/repos","events_url":"https://api.github.com/users/robhudson/events{/privacy}","received_events_url":"https://api.github.com/users/robhudson/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-12-11T22:53:24Z","updated_at":"2014-12-12T21:59:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6caf60e7cffc3e95eeb519c0e6ff8dc97cdb9382","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/fireplace/pulls/847/commits","review_comments_url":"https://api.github.com/repos/mozilla/fireplace/pulls/847/comments","review_comment_url":"https://api.github.com/repos/mozilla/fireplace/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mozilla/fireplace/issues/847/comments","statuses_url":"https://api.github.com/repos/mozilla/fireplace/statuses/7eef5297ec91095f58344bcc993324680dbd41d0","head":{"label":"robhudson:1110326-logout-recommended","ref":"1110326-logout-recommended","sha":"7eef5297ec91095f58344bcc993324680dbd41d0","user":{"login":"robhudson","id":1106,"avatar_url":"https://avatars.githubusercontent.com/u/1106?v=3","gravatar_id":"","url":"https://api.github.com/users/robhudson","html_url":"https://github.com/robhudson","followers_url":"https://api.github.com/users/robhudson/followers","following_url":"https://api.github.com/users/robhudson/following{/other_user}","gists_url":"https://api.github.com/users/robhudson/gists{/gist_id}","starred_url":"https://api.github.com/users/robhudson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robhudson/subscriptions","organizations_url":"https://api.github.com/users/robhudson/orgs","repos_url":"https://api.github.com/users/robhudson/repos","events_url":"https://api.github.com/users/robhudson/events{/privacy}","received_events_url":"https://api.github.com/users/robhudson/received_events","type":"User","site_admin":false},"repo":{"id":10089025,"name":"fireplace","full_name":"robhudson/fireplace","owner":{"login":"robhudson","id":1106,"avatar_url":"https://avatars.githubusercontent.com/u/1106?v=3","gravatar_id":"","url":"https://api.github.com/users/robhudson","html_url":"https://github.com/robhudson","followers_url":"https://api.github.com/users/robhudson/followers","following_url":"https://api.github.com/users/robhudson/following{/other_user}","gists_url":"https://api.github.com/users/robhudson/gists{/gist_id}","starred_url":"https://api.github.com/users/robhudson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robhudson/subscriptions","organizations_url":"https://api.github.com/users/robhudson/orgs","repos_url":"https://api.github.com/users/robhudson/repos","events_url":"https://api.github.com/users/robhudson/events{/privacy}","received_events_url":"https://api.github.com/users/robhudson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/robhudson/fireplace","description":"Ignition, the Remix","fork":true,"url":"https://api.github.com/repos/robhudson/fireplace","forks_url":"https://api.github.com/repos/robhudson/fireplace/forks","keys_url":"https://api.github.com/repos/robhudson/fireplace/keys{/key_id}","collaborators_url":"https://api.github.com/repos/robhudson/fireplace/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/robhudson/fireplace/teams","hooks_url":"https://api.github.com/repos/robhudson/fireplace/hooks","issue_events_url":"https://api.github.com/repos/robhudson/fireplace/issues/events{/number}","events_url":"https://api.github.com/repos/robhudson/fireplace/events","assignees_url":"https://api.github.com/repos/robhudson/fireplace/assignees{/user}","branches_url":"https://api.github.com/repos/robhudson/fireplace/branches{/branch}","tags_url":"https://api.github.com/repos/robhudson/fireplace/tags","blobs_url":"https://api.github.com/repos/robhudson/fireplace/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/robhudson/fireplace/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/robhudson/fireplace/git/refs{/sha}","trees_url":"https://api.github.com/repos/robhudson/fireplace/git/trees{/sha}","statuses_url":"https://api.github.com/repos/robhudson/fireplace/statuses/{sha}","languages_url":"https://api.github.com/repos/robhudson/fireplace/languages","stargazers_url":"https://api.github.com/repos/robhudson/fireplace/stargazers","contributors_url":"https://api.github.com/repos/robhudson/fireplace/contributors","subscribers_url":"https://api.github.com/repos/robhudson/fireplace/subscribers","subscription_url":"https://api.github.com/repos/robhudson/fireplace/subscription","commits_url":"https://api.github.com/repos/robhudson/fireplace/commits{/sha}","git_commits_url":"https://api.github.com/repos/robhudson/fireplace/git/commits{/sha}","comments_url":"https://api.github.com/repos/robhudson/fireplace/comments{/number}","issue_comment_url":"https://api.github.com/repos/robhudson/fireplace/issues/comments/{number}","contents_url":"https://api.github.com/repos/robhudson/fireplace/contents/{+path}","compare_url":"https://api.github.com/repos/robhudson/fireplace/compare/{base}...{head}","merges_url":"https://api.github.com/repos/robhudson/fireplace/merges","archive_url":"https://api.github.com/repos/robhudson/fireplace/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/robhudson/fireplace/downloads","issues_url":"https://api.github.com/repos/robhudson/fireplace/issues{/number}","pulls_url":"https://api.github.com/repos/robhudson/fireplace/pulls{/number}","milestones_url":"https://api.github.com/repos/robhudson/fireplace/milestones{/number}","notifications_url":"https://api.github.com/repos/robhudson/fireplace/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/robhudson/fireplace/labels{/name}","releases_url":"https://api.github.com/repos/robhudson/fireplace/releases{/id}","created_at":"2013-05-15T22:13:36Z","updated_at":"2014-11-24T19:16:27Z","pushed_at":"2014-12-12T21:46:35Z","git_url":"git://github.com/robhudson/fireplace.git","ssh_url":"git@github.com:robhudson/fireplace.git","clone_url":"https://github.com/robhudson/fireplace.git","svn_url":"https://github.com/robhudson/fireplace","homepage":"https://marketplace.firefox.com/","size":20654,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"0d4d652168e0702fb03fa021a1233bba2d18ad2e","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":8046076,"name":"fireplace","full_name":"mozilla/fireplace","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/fireplace","description":"Frontend for the Firefox Marketplace","fork":false,"url":"https://api.github.com/repos/mozilla/fireplace","forks_url":"https://api.github.com/repos/mozilla/fireplace/forks","keys_url":"https://api.github.com/repos/mozilla/fireplace/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/fireplace/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/fireplace/teams","hooks_url":"https://api.github.com/repos/mozilla/fireplace/hooks","issue_events_url":"https://api.github.com/repos/mozilla/fireplace/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/fireplace/events","assignees_url":"https://api.github.com/repos/mozilla/fireplace/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/fireplace/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/fireplace/tags","blobs_url":"https://api.github.com/repos/mozilla/fireplace/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/fireplace/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/fireplace/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/fireplace/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/fireplace/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/fireplace/languages","stargazers_url":"https://api.github.com/repos/mozilla/fireplace/stargazers","contributors_url":"https://api.github.com/repos/mozilla/fireplace/contributors","subscribers_url":"https://api.github.com/repos/mozilla/fireplace/subscribers","subscription_url":"https://api.github.com/repos/mozilla/fireplace/subscription","commits_url":"https://api.github.com/repos/mozilla/fireplace/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/fireplace/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/fireplace/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/fireplace/issues/comments/{number}","contents_url":"https://api.github.com/repos/mozilla/fireplace/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/fireplace/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/fireplace/merges","archive_url":"https://api.github.com/repos/mozilla/fireplace/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/fireplace/downloads","issues_url":"https://api.github.com/repos/mozilla/fireplace/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/fireplace/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/fireplace/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/fireplace/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/fireplace/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/fireplace/releases{/id}","created_at":"2013-02-06T06:41:06Z","updated_at":"2014-12-12T21:26:58Z","pushed_at":"2014-12-12T21:27:43Z","git_url":"git://github.com/mozilla/fireplace.git","ssh_url":"git@github.com:mozilla/fireplace.git","clone_url":"https://github.com/mozilla/fireplace.git","svn_url":"https://github.com/mozilla/fireplace","homepage":"https://marketplace.firefox.com/","size":80046,"stargazers_count":42,"watchers_count":42,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":87,"mirror_url":null,"open_issues_count":7,"forks":87,"open_issues":7,"watchers":42,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/fireplace/pulls/847"},"html":{"href":"https://github.com/mozilla/fireplace/pull/847"},"issue":{"href":"https://api.github.com/repos/mozilla/fireplace/issues/847"},"comments":{"href":"https://api.github.com/repos/mozilla/fireplace/issues/847/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/fireplace/pulls/847/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/fireplace/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mozilla/fireplace/pulls/847/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/fireplace/statuses/7eef5297ec91095f58344bcc993324680dbd41d0"}}}}