GitHub PullRequestReviewCommentEvent at 2014-11-30 23:23:19
Repository: robopaint
Actor: techninja
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/evil-mad/robopaint/pulls/comments/21064835","id":21064835,"diff_hunk":"@@ -557,40 +559,44 @@ function getColorsets() {\n       continue;\n     }\n \n-    // Move through all colorsets in file\n+     // Move through all colorsets in file\n     for(var s in fileSets) {\n       var c = fileSets[s];\n-\n+      var machineName = c.machineName\n       try {\n         // Add pure white to the end of the color set for auto-color\n-        c.colors.push({'White': '#FFFFFF'});\n+        c.colors.push({'white': '#FFFFFF'});\n \n         // Process Colors to avoid re-processing later\n         var colorsOut = [];\n         for (var i in c.colors){\n-          var name = Object.keys(c.colors[i])[0];\n+          var color = c.colors[i];\n+          var name = Object.keys(color)[0];\n           var h = c.colors[i][name];\n           var r = robopaint.utils.colorStringToArray(h);\n           colorsOut.push({\n-            name: name,\n+            name: robopaint.t(\"colorsets.colors.\" + name),\n             color: {\n               HEX: h,\n               RGB: r,\n               HSL: robopaint.utils.rgbToHSL(r),\n               YUV: robopaint.utils.rgbToYUV(r)\n             }\n+\n           });\n         }\n       } catch(e) {\n-        // Silently fail on bad parse!\n+        console.error(\"Parse error on colorset: \" + s, e);","path":"resources/main.js","position":46,"original_position":46,"commit_id":"180d930d6150a1c8cf61a54afc4edb0af3286a74","original_commit_id":"180d930d6150a1c8cf61a54afc4edb0af3286a74","user":{"login":"techninja","id":320747,"avatar_url":"https://avatars.githubusercontent.com/u/320747?v=3","gravatar_id":"","url":"https://api.github.com/users/techninja","html_url":"https://github.com/techninja","followers_url":"https://api.github.com/users/techninja/followers","following_url":"https://api.github.com/users/techninja/following{/other_user}","gists_url":"https://api.github.com/users/techninja/gists{/gist_id}","starred_url":"https://api.github.com/users/techninja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/techninja/subscriptions","organizations_url":"https://api.github.com/users/techninja/orgs","repos_url":"https://api.github.com/users/techninja/repos","events_url":"https://api.github.com/users/techninja/events{/privacy}","received_events_url":"https://api.github.com/users/techninja/received_events","type":"User","site_admin":false},"body":"A nice touch! :+1: ","created_at":"2014-11-30T23:23:19Z","updated_at":"2014-11-30T23:23:19Z","html_url":"https://github.com/evil-mad/robopaint/pull/181#discussion_r21064835","pull_request_url":"https://api.github.com/repos/evil-mad/robopaint/pulls/181","_links":{"self":{"href":"https://api.github.com/repos/evil-mad/robopaint/pulls/comments/21064835"},"html":{"href":"https://github.com/evil-mad/robopaint/pull/181#discussion_r21064835"},"pull_request":{"href":"https://api.github.com/repos/evil-mad/robopaint/pulls/181"}}},"pull_request":{"url":"https://api.github.com/repos/evil-mad/robopaint/pulls/181","id":24662210,"html_url":"https://github.com/evil-mad/robopaint/pull/181","diff_url":"https://github.com/evil-mad/robopaint/pull/181.diff","patch_url":"https://github.com/evil-mad/robopaint/pull/181.patch","issue_url":"https://api.github.com/repos/evil-mad/robopaint/issues/181","number":181,"state":"open","locked":false,"title":"i18n Colorset translations","user":{"login":"rogerfachini","id":7243587,"avatar_url":"https://avatars.githubusercontent.com/u/7243587?v=3","gravatar_id":"","url":"https://api.github.com/users/rogerfachini","html_url":"https://github.com/rogerfachini","followers_url":"https://api.github.com/users/rogerfachini/followers","following_url":"https://api.github.com/users/rogerfachini/following{/other_user}","gists_url":"https://api.github.com/users/rogerfachini/gists{/gist_id}","starred_url":"https://api.github.com/users/rogerfachini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rogerfachini/subscriptions","organizations_url":"https://api.github.com/users/rogerfachini/orgs","repos_url":"https://api.github.com/users/rogerfachini/repos","events_url":"https://api.github.com/users/rogerfachini/events{/privacy}","received_events_url":"https://api.github.com/users/rogerfachini/received_events","type":"User","site_admin":false},"body":"This should translate the colorsets successfully. Currently only the generic-standard colorset has translation files, though.","created_at":"2014-11-19T02:38:58Z","updated_at":"2014-11-30T23:23:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"277c31e80d3a9cc3fc0735ff4db01aed2eece232","assignee":null,"milestone":{"url":"https://api.github.com/repos/evil-mad/robopaint/milestones/9","labels_url":"https://api.github.com/repos/evil-mad/robopaint/milestones/9/labels","id":855099,"number":9,"title":"0.9.5","description":"Midway release for 0.9.0, intended as a feature release to include non-bugfix additions.","creator":{"login":"techninja","id":320747,"avatar_url":"https://avatars.githubusercontent.com/u/320747?v=3","gravatar_id":"","url":"https://api.github.com/users/techninja","html_url":"https://github.com/techninja","followers_url":"https://api.github.com/users/techninja/followers","following_url":"https://api.github.com/users/techninja/following{/other_user}","gists_url":"https://api.github.com/users/techninja/gists{/gist_id}","starred_url":"https://api.github.com/users/techninja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/techninja/subscriptions","organizations_url":"https://api.github.com/users/techninja/orgs","repos_url":"https://api.github.com/users/techninja/repos","events_url":"https://api.github.com/users/techninja/events{/privacy}","received_events_url":"https://api.github.com/users/techninja/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":3,"state":"open","created_at":"2014-11-05T19:50:38Z","updated_at":"2014-11-30T00:31:37Z","due_on":"2014-12-15T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/evil-mad/robopaint/pulls/181/commits","review_comments_url":"https://api.github.com/repos/evil-mad/robopaint/pulls/181/comments","review_comment_url":"https://api.github.com/repos/evil-mad/robopaint/pulls/comments/{number}","comments_url":"https://api.github.com/repos/evil-mad/robopaint/issues/181/comments","statuses_url":"https://api.github.com/repos/evil-mad/robopaint/statuses/180d930d6150a1c8cf61a54afc4edb0af3286a74","head":{"label":"rogerfachini:Colorsets-i18n","ref":"Colorsets-i18n","sha":"180d930d6150a1c8cf61a54afc4edb0af3286a74","user":{"login":"rogerfachini","id":7243587,"avatar_url":"https://avatars.githubusercontent.com/u/7243587?v=3","gravatar_id":"","url":"https://api.github.com/users/rogerfachini","html_url":"https://github.com/rogerfachini","followers_url":"https://api.github.com/users/rogerfachini/followers","following_url":"https://api.github.com/users/rogerfachini/following{/other_user}","gists_url":"https://api.github.com/users/rogerfachini/gists{/gist_id}","starred_url":"https://api.github.com/users/rogerfachini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rogerfachini/subscriptions","organizations_url":"https://api.github.com/users/rogerfachini/orgs","repos_url":"https://api.github.com/users/rogerfachini/repos","events_url":"https://api.github.com/users/rogerfachini/events{/privacy}","received_events_url":"https://api.github.com/users/rogerfachini/received_events","type":"User","site_admin":false},"repo":{"id":24220963,"name":"robopaint","full_name":"rogerfachini/robopaint","owner":{"login":"rogerfachini","id":7243587,"avatar_url":"https://avatars.githubusercontent.com/u/7243587?v=3","gravatar_id":"","url":"https://api.github.com/users/rogerfachini","html_url":"https://github.com/rogerfachini","followers_url":"https://api.github.com/users/rogerfachini/followers","following_url":"https://api.github.com/users/rogerfachini/following{/other_user}","gists_url":"https://api.github.com/users/rogerfachini/gists{/gist_id}","starred_url":"https://api.github.com/users/rogerfachini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rogerfachini/subscriptions","organizations_url":"https://api.github.com/users/rogerfachini/orgs","repos_url":"https://api.github.com/users/rogerfachini/repos","events_url":"https://api.github.com/users/rogerfachini/events{/privacy}","received_events_url":"https://api.github.com/users/rogerfachini/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rogerfachini/robopaint","description":"The software for your friendly painting robot kit!","fork":true,"url":"https://api.github.com/repos/rogerfachini/robopaint","forks_url":"https://api.github.com/repos/rogerfachini/robopaint/forks","keys_url":"https://api.github.com/repos/rogerfachini/robopaint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rogerfachini/robopaint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rogerfachini/robopaint/teams","hooks_url":"https://api.github.com/repos/rogerfachini/robopaint/hooks","issue_events_url":"https://api.github.com/repos/rogerfachini/robopaint/issues/events{/number}","events_url":"https://api.github.com/repos/rogerfachini/robopaint/events","assignees_url":"https://api.github.com/repos/rogerfachini/robopaint/assignees{/user}","branches_url":"https://api.github.com/repos/rogerfachini/robopaint/branches{/branch}","tags_url":"https://api.github.com/repos/rogerfachini/robopaint/tags","blobs_url":"https://api.github.com/repos/rogerfachini/robopaint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rogerfachini/robopaint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rogerfachini/robopaint/git/refs{/sha}","trees_url":"https://api.github.com/repos/rogerfachini/robopaint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rogerfachini/robopaint/statuses/{sha}","languages_url":"https://api.github.com/repos/rogerfachini/robopaint/languages","stargazers_url":"https://api.github.com/repos/rogerfachini/robopaint/stargazers","contributors_url":"https://api.github.com/repos/rogerfachini/robopaint/contributors","subscribers_url":"https://api.github.com/repos/rogerfachini/robopaint/subscribers","subscription_url":"https://api.github.com/repos/rogerfachini/robopaint/subscription","commits_url":"https://api.github.com/repos/rogerfachini/robopaint/commits{/sha}","git_commits_url":"https://api.github.com/repos/rogerfachini/robopaint/git/commits{/sha}","comments_url":"https://api.github.com/repos/rogerfachini/robopaint/comments{/number}","issue_comment_url":"https://api.github.com/repos/rogerfachini/robopaint/issues/comments/{number}","contents_url":"https://api.github.com/repos/rogerfachini/robopaint/contents/{+path}","compare_url":"https://api.github.com/repos/rogerfachini/robopaint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rogerfachini/robopaint/merges","archive_url":"https://api.github.com/repos/rogerfachini/robopaint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rogerfachini/robopaint/downloads","issues_url":"https://api.github.com/repos/rogerfachini/robopaint/issues{/number}","pulls_url":"https://api.github.com/repos/rogerfachini/robopaint/pulls{/number}","milestones_url":"https://api.github.com/repos/rogerfachini/robopaint/milestones{/number}","notifications_url":"https://api.github.com/repos/rogerfachini/robopaint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rogerfachini/robopaint/labels{/name}","releases_url":"https://api.github.com/repos/rogerfachini/robopaint/releases{/id}","created_at":"2014-09-19T07:44:50Z","updated_at":"2014-10-14T06:57:44Z","pushed_at":"2014-11-30T23:00:22Z","git_url":"git://github.com/rogerfachini/robopaint.git","ssh_url":"git@github.com:rogerfachini/robopaint.git","clone_url":"https://github.com/rogerfachini/robopaint.git","svn_url":"https://github.com/rogerfachini/robopaint","homepage":null,"size":9292,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"evil-mad:master","ref":"master","sha":"ff78bd7d1d54884a9012806a1cfbf165eb59d27a","user":{"login":"evil-mad","id":5661788,"avatar_url":"https://avatars.githubusercontent.com/u/5661788?v=3","gravatar_id":"","url":"https://api.github.com/users/evil-mad","html_url":"https://github.com/evil-mad","followers_url":"https://api.github.com/users/evil-mad/followers","following_url":"https://api.github.com/users/evil-mad/following{/other_user}","gists_url":"https://api.github.com/users/evil-mad/gists{/gist_id}","starred_url":"https://api.github.com/users/evil-mad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evil-mad/subscriptions","organizations_url":"https://api.github.com/users/evil-mad/orgs","repos_url":"https://api.github.com/users/evil-mad/repos","events_url":"https://api.github.com/users/evil-mad/events{/privacy}","received_events_url":"https://api.github.com/users/evil-mad/received_events","type":"Organization","site_admin":false},"repo":{"id":9786367,"name":"robopaint","full_name":"evil-mad/robopaint","owner":{"login":"evil-mad","id":5661788,"avatar_url":"https://avatars.githubusercontent.com/u/5661788?v=3","gravatar_id":"","url":"https://api.github.com/users/evil-mad","html_url":"https://github.com/evil-mad","followers_url":"https://api.github.com/users/evil-mad/followers","following_url":"https://api.github.com/users/evil-mad/following{/other_user}","gists_url":"https://api.github.com/users/evil-mad/gists{/gist_id}","starred_url":"https://api.github.com/users/evil-mad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evil-mad/subscriptions","organizations_url":"https://api.github.com/users/evil-mad/orgs","repos_url":"https://api.github.com/users/evil-mad/repos","events_url":"https://api.github.com/users/evil-mad/events{/privacy}","received_events_url":"https://api.github.com/users/evil-mad/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/evil-mad/robopaint","description":"The software for your friendly painting robot kit!","fork":false,"url":"https://api.github.com/repos/evil-mad/robopaint","forks_url":"https://api.github.com/repos/evil-mad/robopaint/forks","keys_url":"https://api.github.com/repos/evil-mad/robopaint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/evil-mad/robopaint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/evil-mad/robopaint/teams","hooks_url":"https://api.github.com/repos/evil-mad/robopaint/hooks","issue_events_url":"https://api.github.com/repos/evil-mad/robopaint/issues/events{/number}","events_url":"https://api.github.com/repos/evil-mad/robopaint/events","assignees_url":"https://api.github.com/repos/evil-mad/robopaint/assignees{/user}","branches_url":"https://api.github.com/repos/evil-mad/robopaint/branches{/branch}","tags_url":"https://api.github.com/repos/evil-mad/robopaint/tags","blobs_url":"https://api.github.com/repos/evil-mad/robopaint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/evil-mad/robopaint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/evil-mad/robopaint/git/refs{/sha}","trees_url":"https://api.github.com/repos/evil-mad/robopaint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/evil-mad/robopaint/statuses/{sha}","languages_url":"https://api.github.com/repos/evil-mad/robopaint/languages","stargazers_url":"https://api.github.com/repos/evil-mad/robopaint/stargazers","contributors_url":"https://api.github.com/repos/evil-mad/robopaint/contributors","subscribers_url":"https://api.github.com/repos/evil-mad/robopaint/subscribers","subscription_url":"https://api.github.com/repos/evil-mad/robopaint/subscription","commits_url":"https://api.github.com/repos/evil-mad/robopaint/commits{/sha}","git_commits_url":"https://api.github.com/repos/evil-mad/robopaint/git/commits{/sha}","comments_url":"https://api.github.com/repos/evil-mad/robopaint/comments{/number}","issue_comment_url":"https://api.github.com/repos/evil-mad/robopaint/issues/comments/{number}","contents_url":"https://api.github.com/repos/evil-mad/robopaint/contents/{+path}","compare_url":"https://api.github.com/repos/evil-mad/robopaint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/evil-mad/robopaint/merges","archive_url":"https://api.github.com/repos/evil-mad/robopaint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/evil-mad/robopaint/downloads","issues_url":"https://api.github.com/repos/evil-mad/robopaint/issues{/number}","pulls_url":"https://api.github.com/repos/evil-mad/robopaint/pulls{/number}","milestones_url":"https://api.github.com/repos/evil-mad/robopaint/milestones{/number}","notifications_url":"https://api.github.com/repos/evil-mad/robopaint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/evil-mad/robopaint/labels{/name}","releases_url":"https://api.github.com/repos/evil-mad/robopaint/releases{/id}","created_at":"2013-05-01T05:33:48Z","updated_at":"2014-11-30T22:12:34Z","pushed_at":"2014-11-30T22:12:34Z","git_url":"git://github.com/evil-mad/robopaint.git","ssh_url":"git@github.com:evil-mad/robopaint.git","clone_url":"https://github.com/evil-mad/robopaint.git","svn_url":"https://github.com/evil-mad/robopaint","homepage":null,"size":10256,"stargazers_count":12,"watchers_count":12,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":38,"forks":9,"open_issues":38,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/evil-mad/robopaint/pulls/181"},"html":{"href":"https://github.com/evil-mad/robopaint/pull/181"},"issue":{"href":"https://api.github.com/repos/evil-mad/robopaint/issues/181"},"comments":{"href":"https://api.github.com/repos/evil-mad/robopaint/issues/181/comments"},"review_comments":{"href":"https://api.github.com/repos/evil-mad/robopaint/pulls/181/comments"},"review_comment":{"href":"https://api.github.com/repos/evil-mad/robopaint/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/evil-mad/robopaint/pulls/181/commits"},"statuses":{"href":"https://api.github.com/repos/evil-mad/robopaint/statuses/180d930d6150a1c8cf61a54afc4edb0af3286a74"}}}}