GitHub PullRequestReviewCommentEvent at 2014-06-17 16:51:40
Repository: thor
Actor: jimfleming
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/rdio/thor/pulls/comments/13871025","id":13871025,"diff_hunk":"@@ -257,11 +265,16 @@ class ImageService(conf: Config) extends BaseImageService(conf) {\n \n                 // Apply any filters to each image and return the final image\n                 applyLayerFilters(imageMap, layers, width, height) match {\n-                  case Some(image) => {\n+                  case (_, frames) if frames.length > 1 => {\n                     // Apply final resize and build response\n-                    buildResponse(req, scaleTo(image, width, height), format, compression)\n+                    val resizedFrames = frames.map( f => Frame(scaleTo(f.image, width, height), f.durationInMs))","path":"src/main/scala/com/rdio/thor/ImageService.scala","position":66,"original_position":66,"commit_id":"2dd1f3855a72e9e1ca162bf7edc2ebf4eeb4f5ef","original_commit_id":"2dd1f3855a72e9e1ca162bf7edc2ebf4eeb4f5ef","user":{"login":"jimfleming","id":226553,"avatar_url":"https://avatars.githubusercontent.com/u/226553?","gravatar_id":"09eba569c869fbf14784d05f3952159f","url":"https://api.github.com/users/jimfleming","html_url":"https://github.com/jimfleming","followers_url":"https://api.github.com/users/jimfleming/followers","following_url":"https://api.github.com/users/jimfleming/following{/other_user}","gists_url":"https://api.github.com/users/jimfleming/gists{/gist_id}","starred_url":"https://api.github.com/users/jimfleming/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimfleming/subscriptions","organizations_url":"https://api.github.com/users/jimfleming/orgs","repos_url":"https://api.github.com/users/jimfleming/repos","events_url":"https://api.github.com/users/jimfleming/events{/privacy}","received_events_url":"https://api.github.com/users/jimfleming/received_events","type":"User","site_admin":false},"body":"`frames.map(f =>` (remove internal space)","created_at":"2014-06-17T16:51:40Z","updated_at":"2014-06-17T16:51:40Z","html_url":"https://github.com/rdio/thor/pull/13#discussion_r13871025","pull_request_url":"https://api.github.com/repos/rdio/thor/pulls/13","_links":{"self":{"href":"https://api.github.com/repos/rdio/thor/pulls/comments/13871025"},"html":{"href":"https://github.com/rdio/thor/pull/13#discussion_r13871025"},"pull_request":{"href":"https://api.github.com/repos/rdio/thor/pulls/13"}}},"pull_request":{"url":"https://api.github.com/repos/rdio/thor/pulls/13","id":16850124,"html_url":"https://github.com/rdio/thor/pull/13","diff_url":"https://github.com/rdio/thor/pull/13.diff","patch_url":"https://github.com/rdio/thor/pull/13.patch","issue_url":"https://api.github.com/repos/rdio/thor/issues/13","number":13,"state":"open","title":"Adding support for animated gifs","user":{"login":"rstecker","id":3209024,"avatar_url":"https://avatars.githubusercontent.com/u/3209024?","gravatar_id":"376add8133d1c6004ef60b99866fd3be","url":"https://api.github.com/users/rstecker","html_url":"https://github.com/rstecker","followers_url":"https://api.github.com/users/rstecker/followers","following_url":"https://api.github.com/users/rstecker/following{/other_user}","gists_url":"https://api.github.com/users/rstecker/gists{/gist_id}","starred_url":"https://api.github.com/users/rstecker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rstecker/subscriptions","organizations_url":"https://api.github.com/users/rstecker/orgs","repos_url":"https://api.github.com/users/rstecker/repos","events_url":"https://api.github.com/users/rstecker/events{/privacy}","received_events_url":"https://api.github.com/users/rstecker/received_events","type":"User","site_admin":false},"body":"I know I'm missing tests.\r\nAlso need to update README\r\n\r\nAdding the `frame(durationInMs)` filter. ","created_at":"2014-06-07T01:54:42Z","updated_at":"2014-06-17T16:51:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a161e21276a59d097498c8c2204ec24776606b88","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rdio/thor/pulls/13/commits","review_comments_url":"https://api.github.com/repos/rdio/thor/pulls/13/comments","review_comment_url":"https://api.github.com/repos/rdio/thor/pulls/comments/{number}","comments_url":"https://api.github.com/repos/rdio/thor/issues/13/comments","statuses_url":"https://api.github.com/repos/rdio/thor/statuses/2dd1f3855a72e9e1ca162bf7edc2ebf4eeb4f5ef","head":{"label":"rstecker:master","ref":"master","sha":"2dd1f3855a72e9e1ca162bf7edc2ebf4eeb4f5ef","user":{"login":"rstecker","id":3209024,"avatar_url":"https://avatars.githubusercontent.com/u/3209024?","gravatar_id":"376add8133d1c6004ef60b99866fd3be","url":"https://api.github.com/users/rstecker","html_url":"https://github.com/rstecker","followers_url":"https://api.github.com/users/rstecker/followers","following_url":"https://api.github.com/users/rstecker/following{/other_user}","gists_url":"https://api.github.com/users/rstecker/gists{/gist_id}","starred_url":"https://api.github.com/users/rstecker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rstecker/subscriptions","organizations_url":"https://api.github.com/users/rstecker/orgs","repos_url":"https://api.github.com/users/rstecker/repos","events_url":"https://api.github.com/users/rstecker/events{/privacy}","received_events_url":"https://api.github.com/users/rstecker/received_events","type":"User","site_admin":false},"repo":{"id":20583018,"name":"thor","full_name":"rstecker/thor","owner":{"login":"rstecker","id":3209024,"avatar_url":"https://avatars.githubusercontent.com/u/3209024?","gravatar_id":"376add8133d1c6004ef60b99866fd3be","url":"https://api.github.com/users/rstecker","html_url":"https://github.com/rstecker","followers_url":"https://api.github.com/users/rstecker/followers","following_url":"https://api.github.com/users/rstecker/following{/other_user}","gists_url":"https://api.github.com/users/rstecker/gists{/gist_id}","starred_url":"https://api.github.com/users/rstecker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rstecker/subscriptions","organizations_url":"https://api.github.com/users/rstecker/orgs","repos_url":"https://api.github.com/users/rstecker/repos","events_url":"https://api.github.com/users/rstecker/events{/privacy}","received_events_url":"https://api.github.com/users/rstecker/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rstecker/thor","description":"A Finagle based image processor.","fork":true,"url":"https://api.github.com/repos/rstecker/thor","forks_url":"https://api.github.com/repos/rstecker/thor/forks","keys_url":"https://api.github.com/repos/rstecker/thor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rstecker/thor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rstecker/thor/teams","hooks_url":"https://api.github.com/repos/rstecker/thor/hooks","issue_events_url":"https://api.github.com/repos/rstecker/thor/issues/events{/number}","events_url":"https://api.github.com/repos/rstecker/thor/events","assignees_url":"https://api.github.com/repos/rstecker/thor/assignees{/user}","branches_url":"https://api.github.com/repos/rstecker/thor/branches{/branch}","tags_url":"https://api.github.com/repos/rstecker/thor/tags","blobs_url":"https://api.github.com/repos/rstecker/thor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rstecker/thor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rstecker/thor/git/refs{/sha}","trees_url":"https://api.github.com/repos/rstecker/thor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rstecker/thor/statuses/{sha}","languages_url":"https://api.github.com/repos/rstecker/thor/languages","stargazers_url":"https://api.github.com/repos/rstecker/thor/stargazers","contributors_url":"https://api.github.com/repos/rstecker/thor/contributors","subscribers_url":"https://api.github.com/repos/rstecker/thor/subscribers","subscription_url":"https://api.github.com/repos/rstecker/thor/subscription","commits_url":"https://api.github.com/repos/rstecker/thor/commits{/sha}","git_commits_url":"https://api.github.com/repos/rstecker/thor/git/commits{/sha}","comments_url":"https://api.github.com/repos/rstecker/thor/comments{/number}","issue_comment_url":"https://api.github.com/repos/rstecker/thor/issues/comments/{number}","contents_url":"https://api.github.com/repos/rstecker/thor/contents/{+path}","compare_url":"https://api.github.com/repos/rstecker/thor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rstecker/thor/merges","archive_url":"https://api.github.com/repos/rstecker/thor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rstecker/thor/downloads","issues_url":"https://api.github.com/repos/rstecker/thor/issues{/number}","pulls_url":"https://api.github.com/repos/rstecker/thor/pulls{/number}","milestones_url":"https://api.github.com/repos/rstecker/thor/milestones{/number}","notifications_url":"https://api.github.com/repos/rstecker/thor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rstecker/thor/labels{/name}","releases_url":"https://api.github.com/repos/rstecker/thor/releases{/id}","created_at":"2014-06-07T01:48:34Z","updated_at":"2014-06-07T01:54:42Z","pushed_at":"2014-06-07T01:52:27Z","git_url":"git://github.com/rstecker/thor.git","ssh_url":"git@github.com:rstecker/thor.git","clone_url":"https://github.com/rstecker/thor.git","svn_url":"https://github.com/rstecker/thor","homepage":null,"size":153,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rdio:master","ref":"master","sha":"33f391f6b0377430b7f1c8ca1d94ab1394696762","user":{"login":"rdio","id":318145,"avatar_url":"https://avatars.githubusercontent.com/u/318145?","gravatar_id":"d3ca5fdff2f2ed201ecb16c595882f76","url":"https://api.github.com/users/rdio","html_url":"https://github.com/rdio","followers_url":"https://api.github.com/users/rdio/followers","following_url":"https://api.github.com/users/rdio/following{/other_user}","gists_url":"https://api.github.com/users/rdio/gists{/gist_id}","starred_url":"https://api.github.com/users/rdio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdio/subscriptions","organizations_url":"https://api.github.com/users/rdio/orgs","repos_url":"https://api.github.com/users/rdio/repos","events_url":"https://api.github.com/users/rdio/events{/privacy}","received_events_url":"https://api.github.com/users/rdio/received_events","type":"Organization","site_admin":false},"repo":{"id":18381190,"name":"thor","full_name":"rdio/thor","owner":{"login":"rdio","id":318145,"avatar_url":"https://avatars.githubusercontent.com/u/318145?","gravatar_id":"d3ca5fdff2f2ed201ecb16c595882f76","url":"https://api.github.com/users/rdio","html_url":"https://github.com/rdio","followers_url":"https://api.github.com/users/rdio/followers","following_url":"https://api.github.com/users/rdio/following{/other_user}","gists_url":"https://api.github.com/users/rdio/gists{/gist_id}","starred_url":"https://api.github.com/users/rdio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdio/subscriptions","organizations_url":"https://api.github.com/users/rdio/orgs","repos_url":"https://api.github.com/users/rdio/repos","events_url":"https://api.github.com/users/rdio/events{/privacy}","received_events_url":"https://api.github.com/users/rdio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rdio/thor","description":"A Finagle based image processor.","fork":false,"url":"https://api.github.com/repos/rdio/thor","forks_url":"https://api.github.com/repos/rdio/thor/forks","keys_url":"https://api.github.com/repos/rdio/thor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rdio/thor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rdio/thor/teams","hooks_url":"https://api.github.com/repos/rdio/thor/hooks","issue_events_url":"https://api.github.com/repos/rdio/thor/issues/events{/number}","events_url":"https://api.github.com/repos/rdio/thor/events","assignees_url":"https://api.github.com/repos/rdio/thor/assignees{/user}","branches_url":"https://api.github.com/repos/rdio/thor/branches{/branch}","tags_url":"https://api.github.com/repos/rdio/thor/tags","blobs_url":"https://api.github.com/repos/rdio/thor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rdio/thor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rdio/thor/git/refs{/sha}","trees_url":"https://api.github.com/repos/rdio/thor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rdio/thor/statuses/{sha}","languages_url":"https://api.github.com/repos/rdio/thor/languages","stargazers_url":"https://api.github.com/repos/rdio/thor/stargazers","contributors_url":"https://api.github.com/repos/rdio/thor/contributors","subscribers_url":"https://api.github.com/repos/rdio/thor/subscribers","subscription_url":"https://api.github.com/repos/rdio/thor/subscription","commits_url":"https://api.github.com/repos/rdio/thor/commits{/sha}","git_commits_url":"https://api.github.com/repos/rdio/thor/git/commits{/sha}","comments_url":"https://api.github.com/repos/rdio/thor/comments{/number}","issue_comment_url":"https://api.github.com/repos/rdio/thor/issues/comments/{number}","contents_url":"https://api.github.com/repos/rdio/thor/contents/{+path}","compare_url":"https://api.github.com/repos/rdio/thor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rdio/thor/merges","archive_url":"https://api.github.com/repos/rdio/thor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rdio/thor/downloads","issues_url":"https://api.github.com/repos/rdio/thor/issues{/number}","pulls_url":"https://api.github.com/repos/rdio/thor/pulls{/number}","milestones_url":"https://api.github.com/repos/rdio/thor/milestones{/number}","notifications_url":"https://api.github.com/repos/rdio/thor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rdio/thor/labels{/name}","releases_url":"https://api.github.com/repos/rdio/thor/releases{/id}","created_at":"2014-04-02T20:55:17Z","updated_at":"2014-06-10T20:32:25Z","pushed_at":"2014-06-05T18:32:21Z","git_url":"git://github.com/rdio/thor.git","ssh_url":"git@github.com:rdio/thor.git","clone_url":"https://github.com/rdio/thor.git","svn_url":"https://github.com/rdio/thor","homepage":null,"size":346,"stargazers_count":9,"watchers_count":9,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":4,"mirror_url":null,"open_issues_count":6,"forks":4,"open_issues":6,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rdio/thor/pulls/13"},"html":{"href":"https://github.com/rdio/thor/pull/13"},"issue":{"href":"https://api.github.com/repos/rdio/thor/issues/13"},"comments":{"href":"https://api.github.com/repos/rdio/thor/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/rdio/thor/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/rdio/thor/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/rdio/thor/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/rdio/thor/statuses/2dd1f3855a72e9e1ca162bf7edc2ebf4eeb4f5ef"}}}}