GitHub PullRequestEvent at 2014-08-18 13:22:04
Repository: rhq
Actor: jshaughn
Payload: {"action":"closed","number":105,"pull_request":{"url":"https://api.github.com/repos/rhq-project/rhq/pulls/105","id":19353221,"html_url":"https://github.com/rhq-project/rhq/pull/105","diff_url":"https://github.com/rhq-project/rhq/pull/105.diff","patch_url":"https://github.com/rhq-project/rhq/pull/105.patch","issue_url":"https://api.github.com/repos/rhq-project/rhq/issues/105","number":105,"state":"closed","locked":false,"title":"[1125439] Duplicate baselines metric entries","user":{"login":"jshaughn","id":2104052,"avatar_url":"https://avatars.githubusercontent.com/u/2104052?v=2","gravatar_id":"5f450217f2232da6e7854597e0d5a510","url":"https://api.github.com/users/jshaughn","html_url":"https://github.com/jshaughn","followers_url":"https://api.github.com/users/jshaughn/followers","following_url":"https://api.github.com/users/jshaughn/following{/other_user}","gists_url":"https://api.github.com/users/jshaughn/gists{/gist_id}","starred_url":"https://api.github.com/users/jshaughn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jshaughn/subscriptions","organizations_url":"https://api.github.com/users/jshaughn/orgs","repos_url":"https://api.github.com/users/jshaughn/repos","events_url":"https://api.github.com/users/jshaughn/events{/privacy}","received_events_url":"https://api.github.com/users/jshaughn/received_events","type":"User","site_admin":false},"body":"Although the root cause is still unknown the relevant code paths did not\r\nprotect against generating multiple baselines for a single schedule, even\r\nthough that should be invalid.  Here are some changes that are more in line\r\nwith the 1-1 relationship that should exist between schedule and\r\nbaseline (optional for schedule, required for baseline)\r\n- Make the db index on baseline's scheduleId unique. There should only be\r\n  one baseline for a schedule. This will prevent the problem in the BZ, possibly\r\n  at the expense of failure when trying to store a duplicate, but that would\r\n  perhaps help us pinpoint a problematic code-path.\r\n- Use Sets (or a Map) as opposed to Lists in several places in the local API.\r\n- Simplify and I think make more efficient the query for selecting schedules\r\n  without a current baseline. Make it return distinct ids (this is a hedge,\r\n  I don't think it would return duplicates, but this ensures that constraint).\r\n  Replace a left join with a NOT EXISTS sub select.\r\n- Chunk the storage of baselines to prevent large Txs, don't pass entities\r\n  across Tx boundary, fetch all Schedules in one query, and (maybe) simplify the\r\n  entity manager interaction.\r\n- Simplify some of the TransactionAttribute decls\r\n- Mark MeasurementSchedule.baseline as an optional 1-1 relationship, just to make\r\n  it explicit on the entity.\r\n- Fix some local SLSB jdoc","created_at":"2014-08-05T16:31:55Z","updated_at":"2014-08-18T13:22:04Z","closed_at":"2014-08-18T13:22:04Z","merged_at":null,"merge_commit_sha":"7f518bb5461c3174e1151f0d5c0f83bc44f0df6d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rhq-project/rhq/pulls/105/commits","review_comments_url":"https://api.github.com/repos/rhq-project/rhq/pulls/105/comments","review_comment_url":"https://api.github.com/repos/rhq-project/rhq/pulls/comments/{number}","comments_url":"https://api.github.com/repos/rhq-project/rhq/issues/105/comments","statuses_url":"https://api.github.com/repos/rhq-project/rhq/statuses/e7fd7c1c9ce5268c6ee2a314c57e344b65a5b494","head":{"label":"rhq-project:jshaughn/1125439","ref":"jshaughn/1125439","sha":"e7fd7c1c9ce5268c6ee2a314c57e344b65a5b494","user":{"login":"rhq-project","id":1080166,"avatar_url":"https://avatars.githubusercontent.com/u/1080166?v=2","gravatar_id":"257936c84696897147a945bb59fee2bf","url":"https://api.github.com/users/rhq-project","html_url":"https://github.com/rhq-project","followers_url":"https://api.github.com/users/rhq-project/followers","following_url":"https://api.github.com/users/rhq-project/following{/other_user}","gists_url":"https://api.github.com/users/rhq-project/gists{/gist_id}","starred_url":"https://api.github.com/users/rhq-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhq-project/subscriptions","organizations_url":"https://api.github.com/users/rhq-project/orgs","repos_url":"https://api.github.com/users/rhq-project/repos","events_url":"https://api.github.com/users/rhq-project/events{/privacy}","received_events_url":"https://api.github.com/users/rhq-project/received_events","type":"Organization","site_admin":false},"repo":{"id":17278009,"name":"rhq","full_name":"rhq-project/rhq","owner":{"login":"rhq-project","id":1080166,"avatar_url":"https://avatars.githubusercontent.com/u/1080166?v=2","gravatar_id":"257936c84696897147a945bb59fee2bf","url":"https://api.github.com/users/rhq-project","html_url":"https://github.com/rhq-project","followers_url":"https://api.github.com/users/rhq-project/followers","following_url":"https://api.github.com/users/rhq-project/following{/other_user}","gists_url":"https://api.github.com/users/rhq-project/gists{/gist_id}","starred_url":"https://api.github.com/users/rhq-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhq-project/subscriptions","organizations_url":"https://api.github.com/users/rhq-project/orgs","repos_url":"https://api.github.com/users/rhq-project/repos","events_url":"https://api.github.com/users/rhq-project/events{/privacy}","received_events_url":"https://api.github.com/users/rhq-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rhq-project/rhq","description":"RHQ system management and monitoring framework","fork":false,"url":"https://api.github.com/repos/rhq-project/rhq","forks_url":"https://api.github.com/repos/rhq-project/rhq/forks","keys_url":"https://api.github.com/repos/rhq-project/rhq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rhq-project/rhq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rhq-project/rhq/teams","hooks_url":"https://api.github.com/repos/rhq-project/rhq/hooks","issue_events_url":"https://api.github.com/repos/rhq-project/rhq/issues/events{/number}","events_url":"https://api.github.com/repos/rhq-project/rhq/events","assignees_url":"https://api.github.com/repos/rhq-project/rhq/assignees{/user}","branches_url":"https://api.github.com/repos/rhq-project/rhq/branches{/branch}","tags_url":"https://api.github.com/repos/rhq-project/rhq/tags","blobs_url":"https://api.github.com/repos/rhq-project/rhq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rhq-project/rhq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rhq-project/rhq/git/refs{/sha}","trees_url":"https://api.github.com/repos/rhq-project/rhq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rhq-project/rhq/statuses/{sha}","languages_url":"https://api.github.com/repos/rhq-project/rhq/languages","stargazers_url":"https://api.github.com/repos/rhq-project/rhq/stargazers","contributors_url":"https://api.github.com/repos/rhq-project/rhq/contributors","subscribers_url":"https://api.github.com/repos/rhq-project/rhq/subscribers","subscription_url":"https://api.github.com/repos/rhq-project/rhq/subscription","commits_url":"https://api.github.com/repos/rhq-project/rhq/commits{/sha}","git_commits_url":"https://api.github.com/repos/rhq-project/rhq/git/commits{/sha}","comments_url":"https://api.github.com/repos/rhq-project/rhq/comments{/number}","issue_comment_url":"https://api.github.com/repos/rhq-project/rhq/issues/comments/{number}","contents_url":"https://api.github.com/repos/rhq-project/rhq/contents/{+path}","compare_url":"https://api.github.com/repos/rhq-project/rhq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rhq-project/rhq/merges","archive_url":"https://api.github.com/repos/rhq-project/rhq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rhq-project/rhq/downloads","issues_url":"https://api.github.com/repos/rhq-project/rhq/issues{/number}","pulls_url":"https://api.github.com/repos/rhq-project/rhq/pulls{/number}","milestones_url":"https://api.github.com/repos/rhq-project/rhq/milestones{/number}","notifications_url":"https://api.github.com/repos/rhq-project/rhq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rhq-project/rhq/labels{/name}","releases_url":"https://api.github.com/repos/rhq-project/rhq/releases{/id}","created_at":"2014-02-28T06:54:47Z","updated_at":"2014-08-08T01:55:45Z","pushed_at":"2014-08-18T10:54:49Z","git_url":"git://github.com/rhq-project/rhq.git","ssh_url":"git@github.com:rhq-project/rhq.git","clone_url":"https://github.com/rhq-project/rhq.git","svn_url":"https://github.com/rhq-project/rhq","homepage":"http://jboss.org/rhq","size":416404,"stargazers_count":22,"watchers_count":22,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":24,"mirror_url":null,"open_issues_count":17,"forks":24,"open_issues":17,"watchers":22,"default_branch":"master"}},"base":{"label":"rhq-project:master","ref":"master","sha":"946b70169817d913a8b45c8f015935e99d914b38","user":{"login":"rhq-project","id":1080166,"avatar_url":"https://avatars.githubusercontent.com/u/1080166?v=2","gravatar_id":"257936c84696897147a945bb59fee2bf","url":"https://api.github.com/users/rhq-project","html_url":"https://github.com/rhq-project","followers_url":"https://api.github.com/users/rhq-project/followers","following_url":"https://api.github.com/users/rhq-project/following{/other_user}","gists_url":"https://api.github.com/users/rhq-project/gists{/gist_id}","starred_url":"https://api.github.com/users/rhq-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhq-project/subscriptions","organizations_url":"https://api.github.com/users/rhq-project/orgs","repos_url":"https://api.github.com/users/rhq-project/repos","events_url":"https://api.github.com/users/rhq-project/events{/privacy}","received_events_url":"https://api.github.com/users/rhq-project/received_events","type":"Organization","site_admin":false},"repo":{"id":17278009,"name":"rhq","full_name":"rhq-project/rhq","owner":{"login":"rhq-project","id":1080166,"avatar_url":"https://avatars.githubusercontent.com/u/1080166?v=2","gravatar_id":"257936c84696897147a945bb59fee2bf","url":"https://api.github.com/users/rhq-project","html_url":"https://github.com/rhq-project","followers_url":"https://api.github.com/users/rhq-project/followers","following_url":"https://api.github.com/users/rhq-project/following{/other_user}","gists_url":"https://api.github.com/users/rhq-project/gists{/gist_id}","starred_url":"https://api.github.com/users/rhq-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhq-project/subscriptions","organizations_url":"https://api.github.com/users/rhq-project/orgs","repos_url":"https://api.github.com/users/rhq-project/repos","events_url":"https://api.github.com/users/rhq-project/events{/privacy}","received_events_url":"https://api.github.com/users/rhq-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rhq-project/rhq","description":"RHQ system management and monitoring framework","fork":false,"url":"https://api.github.com/repos/rhq-project/rhq","forks_url":"https://api.github.com/repos/rhq-project/rhq/forks","keys_url":"https://api.github.com/repos/rhq-project/rhq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rhq-project/rhq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rhq-project/rhq/teams","hooks_url":"https://api.github.com/repos/rhq-project/rhq/hooks","issue_events_url":"https://api.github.com/repos/rhq-project/rhq/issues/events{/number}","events_url":"https://api.github.com/repos/rhq-project/rhq/events","assignees_url":"https://api.github.com/repos/rhq-project/rhq/assignees{/user}","branches_url":"https://api.github.com/repos/rhq-project/rhq/branches{/branch}","tags_url":"https://api.github.com/repos/rhq-project/rhq/tags","blobs_url":"https://api.github.com/repos/rhq-project/rhq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rhq-project/rhq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rhq-project/rhq/git/refs{/sha}","trees_url":"https://api.github.com/repos/rhq-project/rhq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rhq-project/rhq/statuses/{sha}","languages_url":"https://api.github.com/repos/rhq-project/rhq/languages","stargazers_url":"https://api.github.com/repos/rhq-project/rhq/stargazers","contributors_url":"https://api.github.com/repos/rhq-project/rhq/contributors","subscribers_url":"https://api.github.com/repos/rhq-project/rhq/subscribers","subscription_url":"https://api.github.com/repos/rhq-project/rhq/subscription","commits_url":"https://api.github.com/repos/rhq-project/rhq/commits{/sha}","git_commits_url":"https://api.github.com/repos/rhq-project/rhq/git/commits{/sha}","comments_url":"https://api.github.com/repos/rhq-project/rhq/comments{/number}","issue_comment_url":"https://api.github.com/repos/rhq-project/rhq/issues/comments/{number}","contents_url":"https://api.github.com/repos/rhq-project/rhq/contents/{+path}","compare_url":"https://api.github.com/repos/rhq-project/rhq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rhq-project/rhq/merges","archive_url":"https://api.github.com/repos/rhq-project/rhq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rhq-project/rhq/downloads","issues_url":"https://api.github.com/repos/rhq-project/rhq/issues{/number}","pulls_url":"https://api.github.com/repos/rhq-project/rhq/pulls{/number}","milestones_url":"https://api.github.com/repos/rhq-project/rhq/milestones{/number}","notifications_url":"https://api.github.com/repos/rhq-project/rhq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rhq-project/rhq/labels{/name}","releases_url":"https://api.github.com/repos/rhq-project/rhq/releases{/id}","created_at":"2014-02-28T06:54:47Z","updated_at":"2014-08-08T01:55:45Z","pushed_at":"2014-08-18T10:54:49Z","git_url":"git://github.com/rhq-project/rhq.git","ssh_url":"git@github.com:rhq-project/rhq.git","clone_url":"https://github.com/rhq-project/rhq.git","svn_url":"https://github.com/rhq-project/rhq","homepage":"http://jboss.org/rhq","size":416404,"stargazers_count":22,"watchers_count":22,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":24,"mirror_url":null,"open_issues_count":17,"forks":24,"open_issues":17,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rhq-project/rhq/pulls/105"},"html":{"href":"https://github.com/rhq-project/rhq/pull/105"},"issue":{"href":"https://api.github.com/repos/rhq-project/rhq/issues/105"},"comments":{"href":"https://api.github.com/repos/rhq-project/rhq/issues/105/comments"},"review_comments":{"href":"https://api.github.com/repos/rhq-project/rhq/pulls/105/comments"},"review_comment":{"href":"https://api.github.com/repos/rhq-project/rhq/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/rhq-project/rhq/pulls/105/commits"},"statuses":{"href":"https://api.github.com/repos/rhq-project/rhq/statuses/e7fd7c1c9ce5268c6ee2a314c57e344b65a5b494"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":0,"review_comments":0,"commits":3,"additions":158,"deletions":102,"changed_files":10}}