GitHub PullRequestEvent at 2014-11-08 23:10:58
Repository: -tg-station
Actor: hornygranny
Payload: {"action":"closed","number":5722,"pull_request":{"url":"https://api.github.com/repos/tgstation/-tg-station/pulls/5722","id":24030093,"html_url":"https://github.com/tgstation/-tg-station/pull/5722","diff_url":"https://github.com/tgstation/-tg-station/pull/5722.diff","patch_url":"https://github.com/tgstation/-tg-station/pull/5722.patch","issue_url":"https://api.github.com/repos/tgstation/-tg-station/issues/5722","number":5722,"state":"closed","locked":false,"title":"Exosuit fabricator revamp","user":{"login":"Aranclanos","id":701959,"avatar_url":"https://avatars.githubusercontent.com/u/701959?v=3","gravatar_id":"","url":"https://api.github.com/users/Aranclanos","html_url":"https://github.com/Aranclanos","followers_url":"https://api.github.com/users/Aranclanos/followers","following_url":"https://api.github.com/users/Aranclanos/following{/other_user}","gists_url":"https://api.github.com/users/Aranclanos/gists{/gist_id}","starred_url":"https://api.github.com/users/Aranclanos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aranclanos/subscriptions","organizations_url":"https://api.github.com/users/Aranclanos/orgs","repos_url":"https://api.github.com/users/Aranclanos/repos","events_url":"https://api.github.com/users/Aranclanos/events{/privacy}","received_events_url":"https://api.github.com/users/Aranclanos/received_events","type":"User","site_admin":false},"body":"Exosuits will now use the designs from RnD to create objects instead of having the object already created on their contents.\r\nEach one of the default items to build are now designs.\r\nRemoved access required to use the exosuit fabricators.\r\nRemoved an unused mech syringe gun design and replaced with a new one, with no cost.\r\nAdded a temporal object, /obj/item/mechavars, to be able to use initalize() for the construction time. This will be later on removed and the construction time will be ported to the design datums.\r\nSome minors issues are still present, due to the amount of files needed to fix these, it won't be part of this commit, but a future one.\r\nFixes #3893\r\nRemoved required access to access the setting controls of the RnD console.\r\n\r\nedit (forgot to mention):\r\nupdates the research debug object, it will now cover all research branches\r\nadded a new file for all the default exosuit designs\r\n\r\nknown issues:\r\nminerals show up with a '$' at the start (for example, '$metal')\r\noverlay at applying minerals to the machine doesn't appear (related to $metal)\r\nfirefighter appears when adding all ripley to queue (not my issue but still)\r\nstill using the hacky machinery object for the construction_time var\r\n\t-/obj/item/mechavars\r\nall objects still have the construction_cost var, must be deleted\r\nemags useless on the exo fabs","created_at":"2014-11-07T02:47:42Z","updated_at":"2014-11-08T23:10:58Z","closed_at":"2014-11-08T23:10:58Z","merged_at":"2014-11-08T23:10:58Z","merge_commit_sha":"2a71a8a68e136085740ec81fd1c7b95d0f6b2247","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/tgstation/-tg-station/pulls/5722/commits","review_comments_url":"https://api.github.com/repos/tgstation/-tg-station/pulls/5722/comments","review_comment_url":"https://api.github.com/repos/tgstation/-tg-station/pulls/comments/{number}","comments_url":"https://api.github.com/repos/tgstation/-tg-station/issues/5722/comments","statuses_url":"https://api.github.com/repos/tgstation/-tg-station/statuses/d56698f99101a2973dda06b374dc55c9c79faab1","head":{"label":"Aranclanos:mechfabricators","ref":"mechfabricators","sha":"d56698f99101a2973dda06b374dc55c9c79faab1","user":{"login":"Aranclanos","id":701959,"avatar_url":"https://avatars.githubusercontent.com/u/701959?v=3","gravatar_id":"","url":"https://api.github.com/users/Aranclanos","html_url":"https://github.com/Aranclanos","followers_url":"https://api.github.com/users/Aranclanos/followers","following_url":"https://api.github.com/users/Aranclanos/following{/other_user}","gists_url":"https://api.github.com/users/Aranclanos/gists{/gist_id}","starred_url":"https://api.github.com/users/Aranclanos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aranclanos/subscriptions","organizations_url":"https://api.github.com/users/Aranclanos/orgs","repos_url":"https://api.github.com/users/Aranclanos/repos","events_url":"https://api.github.com/users/Aranclanos/events{/privacy}","received_events_url":"https://api.github.com/users/Aranclanos/received_events","type":"User","site_admin":false},"repo":{"id":9137067,"name":"-tg-station","full_name":"Aranclanos/-tg-station","owner":{"login":"Aranclanos","id":701959,"avatar_url":"https://avatars.githubusercontent.com/u/701959?v=3","gravatar_id":"","url":"https://api.github.com/users/Aranclanos","html_url":"https://github.com/Aranclanos","followers_url":"https://api.github.com/users/Aranclanos/followers","following_url":"https://api.github.com/users/Aranclanos/following{/other_user}","gists_url":"https://api.github.com/users/Aranclanos/gists{/gist_id}","starred_url":"https://api.github.com/users/Aranclanos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aranclanos/subscriptions","organizations_url":"https://api.github.com/users/Aranclanos/orgs","repos_url":"https://api.github.com/users/Aranclanos/repos","events_url":"https://api.github.com/users/Aranclanos/events{/privacy}","received_events_url":"https://api.github.com/users/Aranclanos/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Aranclanos/-tg-station","description":"/tg/'s SS13 branch","fork":true,"url":"https://api.github.com/repos/Aranclanos/-tg-station","forks_url":"https://api.github.com/repos/Aranclanos/-tg-station/forks","keys_url":"https://api.github.com/repos/Aranclanos/-tg-station/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Aranclanos/-tg-station/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Aranclanos/-tg-station/teams","hooks_url":"https://api.github.com/repos/Aranclanos/-tg-station/hooks","issue_events_url":"https://api.github.com/repos/Aranclanos/-tg-station/issues/events{/number}","events_url":"https://api.github.com/repos/Aranclanos/-tg-station/events","assignees_url":"https://api.github.com/repos/Aranclanos/-tg-station/assignees{/user}","branches_url":"https://api.github.com/repos/Aranclanos/-tg-station/branches{/branch}","tags_url":"https://api.github.com/repos/Aranclanos/-tg-station/tags","blobs_url":"https://api.github.com/repos/Aranclanos/-tg-station/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Aranclanos/-tg-station/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Aranclanos/-tg-station/git/refs{/sha}","trees_url":"https://api.github.com/repos/Aranclanos/-tg-station/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Aranclanos/-tg-station/statuses/{sha}","languages_url":"https://api.github.com/repos/Aranclanos/-tg-station/languages","stargazers_url":"https://api.github.com/repos/Aranclanos/-tg-station/stargazers","contributors_url":"https://api.github.com/repos/Aranclanos/-tg-station/contributors","subscribers_url":"https://api.github.com/repos/Aranclanos/-tg-station/subscribers","subscription_url":"https://api.github.com/repos/Aranclanos/-tg-station/subscription","commits_url":"https://api.github.com/repos/Aranclanos/-tg-station/commits{/sha}","git_commits_url":"https://api.github.com/repos/Aranclanos/-tg-station/git/commits{/sha}","comments_url":"https://api.github.com/repos/Aranclanos/-tg-station/comments{/number}","issue_comment_url":"https://api.github.com/repos/Aranclanos/-tg-station/issues/comments/{number}","contents_url":"https://api.github.com/repos/Aranclanos/-tg-station/contents/{+path}","compare_url":"https://api.github.com/repos/Aranclanos/-tg-station/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Aranclanos/-tg-station/merges","archive_url":"https://api.github.com/repos/Aranclanos/-tg-station/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Aranclanos/-tg-station/downloads","issues_url":"https://api.github.com/repos/Aranclanos/-tg-station/issues{/number}","pulls_url":"https://api.github.com/repos/Aranclanos/-tg-station/pulls{/number}","milestones_url":"https://api.github.com/repos/Aranclanos/-tg-station/milestones{/number}","notifications_url":"https://api.github.com/repos/Aranclanos/-tg-station/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Aranclanos/-tg-station/labels{/name}","releases_url":"https://api.github.com/repos/Aranclanos/-tg-station/releases{/id}","created_at":"2013-03-31T22:11:34Z","updated_at":"2014-06-24T21:24:19Z","pushed_at":"2014-11-07T02:45:56Z","git_url":"git://github.com/Aranclanos/-tg-station.git","ssh_url":"git@github.com:Aranclanos/-tg-station.git","clone_url":"https://github.com/Aranclanos/-tg-station.git","svn_url":"https://github.com/Aranclanos/-tg-station","homepage":"","size":390564,"stargazers_count":0,"watchers_count":0,"language":"DM","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tgstation:master","ref":"master","sha":"e94b3ea9ebee2dae0fe5061776f51cfe9592450b","user":{"login":"tgstation","id":1363778,"avatar_url":"https://avatars.githubusercontent.com/u/1363778?v=3","gravatar_id":"","url":"https://api.github.com/users/tgstation","html_url":"https://github.com/tgstation","followers_url":"https://api.github.com/users/tgstation/followers","following_url":"https://api.github.com/users/tgstation/following{/other_user}","gists_url":"https://api.github.com/users/tgstation/gists{/gist_id}","starred_url":"https://api.github.com/users/tgstation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgstation/subscriptions","organizations_url":"https://api.github.com/users/tgstation/orgs","repos_url":"https://api.github.com/users/tgstation/repos","events_url":"https://api.github.com/users/tgstation/events{/privacy}","received_events_url":"https://api.github.com/users/tgstation/received_events","type":"Organization","site_admin":false},"repo":{"id":3234987,"name":"-tg-station","full_name":"tgstation/-tg-station","owner":{"login":"tgstation","id":1363778,"avatar_url":"https://avatars.githubusercontent.com/u/1363778?v=3","gravatar_id":"","url":"https://api.github.com/users/tgstation","html_url":"https://github.com/tgstation","followers_url":"https://api.github.com/users/tgstation/followers","following_url":"https://api.github.com/users/tgstation/following{/other_user}","gists_url":"https://api.github.com/users/tgstation/gists{/gist_id}","starred_url":"https://api.github.com/users/tgstation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgstation/subscriptions","organizations_url":"https://api.github.com/users/tgstation/orgs","repos_url":"https://api.github.com/users/tgstation/repos","events_url":"https://api.github.com/users/tgstation/events{/privacy}","received_events_url":"https://api.github.com/users/tgstation/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tgstation/-tg-station","description":"/tg/'s SS13 branch","fork":false,"url":"https://api.github.com/repos/tgstation/-tg-station","forks_url":"https://api.github.com/repos/tgstation/-tg-station/forks","keys_url":"https://api.github.com/repos/tgstation/-tg-station/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tgstation/-tg-station/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tgstation/-tg-station/teams","hooks_url":"https://api.github.com/repos/tgstation/-tg-station/hooks","issue_events_url":"https://api.github.com/repos/tgstation/-tg-station/issues/events{/number}","events_url":"https://api.github.com/repos/tgstation/-tg-station/events","assignees_url":"https://api.github.com/repos/tgstation/-tg-station/assignees{/user}","branches_url":"https://api.github.com/repos/tgstation/-tg-station/branches{/branch}","tags_url":"https://api.github.com/repos/tgstation/-tg-station/tags","blobs_url":"https://api.github.com/repos/tgstation/-tg-station/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tgstation/-tg-station/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tgstation/-tg-station/git/refs{/sha}","trees_url":"https://api.github.com/repos/tgstation/-tg-station/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tgstation/-tg-station/statuses/{sha}","languages_url":"https://api.github.com/repos/tgstation/-tg-station/languages","stargazers_url":"https://api.github.com/repos/tgstation/-tg-station/stargazers","contributors_url":"https://api.github.com/repos/tgstation/-tg-station/contributors","subscribers_url":"https://api.github.com/repos/tgstation/-tg-station/subscribers","subscription_url":"https://api.github.com/repos/tgstation/-tg-station/subscription","commits_url":"https://api.github.com/repos/tgstation/-tg-station/commits{/sha}","git_commits_url":"https://api.github.com/repos/tgstation/-tg-station/git/commits{/sha}","comments_url":"https://api.github.com/repos/tgstation/-tg-station/comments{/number}","issue_comment_url":"https://api.github.com/repos/tgstation/-tg-station/issues/comments/{number}","contents_url":"https://api.github.com/repos/tgstation/-tg-station/contents/{+path}","compare_url":"https://api.github.com/repos/tgstation/-tg-station/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tgstation/-tg-station/merges","archive_url":"https://api.github.com/repos/tgstation/-tg-station/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tgstation/-tg-station/downloads","issues_url":"https://api.github.com/repos/tgstation/-tg-station/issues{/number}","pulls_url":"https://api.github.com/repos/tgstation/-tg-station/pulls{/number}","milestones_url":"https://api.github.com/repos/tgstation/-tg-station/milestones{/number}","notifications_url":"https://api.github.com/repos/tgstation/-tg-station/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tgstation/-tg-station/labels{/name}","releases_url":"https://api.github.com/repos/tgstation/-tg-station/releases{/id}","created_at":"2012-01-21T17:32:47Z","updated_at":"2014-11-03T20:17:40Z","pushed_at":"2014-11-08T23:10:58Z","git_url":"git://github.com/tgstation/-tg-station.git","ssh_url":"git@github.com:tgstation/-tg-station.git","clone_url":"https://github.com/tgstation/-tg-station.git","svn_url":"https://github.com/tgstation/-tg-station","homepage":"http://www.tgstation13.org/","size":517744,"stargazers_count":168,"watchers_count":168,"language":"DM","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":565,"mirror_url":null,"open_issues_count":538,"forks":565,"open_issues":538,"watchers":168,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tgstation/-tg-station/pulls/5722"},"html":{"href":"https://github.com/tgstation/-tg-station/pull/5722"},"issue":{"href":"https://api.github.com/repos/tgstation/-tg-station/issues/5722"},"comments":{"href":"https://api.github.com/repos/tgstation/-tg-station/issues/5722/comments"},"review_comments":{"href":"https://api.github.com/repos/tgstation/-tg-station/pulls/5722/comments"},"review_comment":{"href":"https://api.github.com/repos/tgstation/-tg-station/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/tgstation/-tg-station/pulls/5722/commits"},"statuses":{"href":"https://api.github.com/repos/tgstation/-tg-station/statuses/d56698f99101a2973dda06b374dc55c9c79faab1"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"hornygranny","id":6364323,"avatar_url":"https://avatars.githubusercontent.com/u/6364323?v=3","gravatar_id":"","url":"https://api.github.com/users/hornygranny","html_url":"https://github.com/hornygranny","followers_url":"https://api.github.com/users/hornygranny/followers","following_url":"https://api.github.com/users/hornygranny/following{/other_user}","gists_url":"https://api.github.com/users/hornygranny/gists{/gist_id}","starred_url":"https://api.github.com/users/hornygranny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hornygranny/subscriptions","organizations_url":"https://api.github.com/users/hornygranny/orgs","repos_url":"https://api.github.com/users/hornygranny/repos","events_url":"https://api.github.com/users/hornygranny/events{/privacy}","received_events_url":"https://api.github.com/users/hornygranny/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":239,"deletions":497,"changed_files":4}}