GitHub PullRequestReviewCommentEvent at 2014-03-23 05:12:55
Repository: mesos-plugin
Actor: vinodkone
Payload: {"comment":{"url":"https://api.github.com/repos/jenkinsci/mesos-plugin/pulls/comments/10865668","id":10865668,"diff_hunk":"@@ -266,59 +264,38 @@ public static MesosCloud get() {\n   }\n \n   /**\n-  * @return the slaveAttributes\n-  */\n-  public JSONObject getSlaveAttributes() {\n-    return slaveAttributes;\n-  }\n-\n-  /**\n   * @return the checkpoint\n   */\n   public boolean isCheckpoint() {\n     return checkpoint;\n   }\n \n-  /**\n-  * @return the slaveCpus\n-  */\n-  public double getSlaveCpus() {\n-    return slaveCpus;\n-  }\n-\n-  /**\n-  * @return the slaveMem\n-  */\n-  public int getSlaveMem() {\n-    return slaveMem;\n-  }\n-\n-  /**\n-  * @return the executorCpus\n-  */\n-  public double getExecutorCpus() {\n-    return executorCpus;\n-  }\n-\n-  /**\n-  * @return the maxExecutors\n-  */\n-  public int getMaxExecutors() {\n-    return maxExecutors;\n+  private MesosSlaveInfo getSlaveInfo(List<MesosSlaveInfo> mesosSlaveInfoList,\n+      Label label) {\n+    for (MesosSlaveInfo mesosSlaveInfo : mesosSlaveInfoList) {\n+      if (label.matches(Label.parse(mesosSlaveInfo.getLabelString()))) {\n+        return mesosSlaveInfo;\n+      }\n+    }\n+    return null;\n   }\n \n   /**\n-  * @return the executorMem\n+  * Retrives the slaveattribute corresponding to label name","path":"src/main/java/org/jenkinsci/plugins/mesos/MesosCloud.java","position":187,"original_position":187,"commit_id":"5b8f4532f9b2edde57f82090787796c78155f3d2","original_commit_id":"5b8f4532f9b2edde57f82090787796c78155f3d2","user":{"login":"vinodkone","id":48131,"avatar_url":"https://avatars.githubusercontent.com/u/48131?","gravatar_id":"e45291ced7d7e535c64b4470d35a94fe","url":"https://api.github.com/users/vinodkone","html_url":"https://github.com/vinodkone","followers_url":"https://api.github.com/users/vinodkone/followers","following_url":"https://api.github.com/users/vinodkone/following{/other_user}","gists_url":"https://api.github.com/users/vinodkone/gists{/gist_id}","starred_url":"https://api.github.com/users/vinodkone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vinodkone/subscriptions","organizations_url":"https://api.github.com/users/vinodkone/orgs","repos_url":"https://api.github.com/users/vinodkone/repos","events_url":"https://api.github.com/users/vinodkone/events{/privacy}","received_events_url":"https://api.github.com/users/vinodkone/received_events","type":"User","site_admin":false},"body":"s/Retrives/Retrieves/\r\n\r\ns/name/name./","created_at":"2014-03-23T05:12:55Z","updated_at":"2014-03-23T05:12:55Z","html_url":"https://github.com/jenkinsci/mesos-plugin/pull/24#discussion_r10865668","pull_request_url":"https://api.github.com/repos/jenkinsci/mesos-plugin/pulls/24","_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/mesos-plugin/pulls/comments/10865668"},"html":{"href":"https://github.com/jenkinsci/mesos-plugin/pull/24#discussion_r10865668"},"pull_request":{"href":"https://api.github.com/repos/jenkinsci/mesos-plugin/pulls/24"}}}}