GitHub PullRequestEvent at 2014-12-09 16:51:07
Repository: django-jstemplate
Actor: mjumbewu
Payload: {"action":"closed","number":9,"pull_request":{"url":"https://api.github.com/repos/mjumbewu/django-jstemplate/pulls/9","id":24686640,"html_url":"https://github.com/mjumbewu/django-jstemplate/pull/9","diff_url":"https://github.com/mjumbewu/django-jstemplate/pull/9.diff","patch_url":"https://github.com/mjumbewu/django-jstemplate/pull/9.patch","issue_url":"https://api.github.com/repos/mjumbewu/django-jstemplate/issues/9","number":9,"state":"closed","locked":false,"title":"Fix incompatibility with the latest versions of django-debug-toolbar","user":{"login":"Psycojoker","id":41827,"avatar_url":"https://avatars.githubusercontent.com/u/41827?v=3","gravatar_id":"","url":"https://api.github.com/users/Psycojoker","html_url":"https://github.com/Psycojoker","followers_url":"https://api.github.com/users/Psycojoker/followers","following_url":"https://api.github.com/users/Psycojoker/following{/other_user}","gists_url":"https://api.github.com/users/Psycojoker/gists{/gist_id}","starred_url":"https://api.github.com/users/Psycojoker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Psycojoker/subscriptions","organizations_url":"https://api.github.com/users/Psycojoker/orgs","repos_url":"https://api.github.com/users/Psycojoker/repos","events_url":"https://api.github.com/users/Psycojoker/events{/privacy}","received_events_url":"https://api.github.com/users/Psycojoker/received_events","type":"User","site_admin":false},"body":"Hello,\r\n\r\nIn the latest version of django debug toolbar, it is recommended to add this entry the INSTALLED_APPS:\r\n\r\n    debug_toolbar.apps.DebugToolbarConfig\r\n\r\nWhich is not a django module. This conflict with the way django-jstemplate parses the INSTALLED_APPS tuple and results in this exception (cut because it is terribly long):\r\n\r\n```\r\n  File \"/home/psycojoker/code/django/vegout/ve/lib/python2.7/site-packages/django/template/base.py\", line 1336, in get_library\r\n    lib = import_library(taglib_module)\r\n  File \"/home/psycojoker/code/django/vegout/ve/lib/python2.7/site-packages/django/template/base.py\", line 1270, in import_library\r\n    mod = import_module(taglib_module)\r\n  File \"/usr/lib/python2.7/importlib/__init__.py\", line 37, in import_module\r\n    __import__(name)\r\n  File \"/home/psycojoker/code/django/vegout/ve/lib/python2.7/site-packages/jstemplate/templatetags/jstemplate.py\", line 3, in <module>\r\n    from .rawjstemplate import rawjstemplate\r\n  File \"/home/psycojoker/code/django/vegout/ve/lib/python2.7/site-packages/jstemplate/templatetags/rawjstemplate.py\", line 2, in <module>\r\n    from .base import BaseJSTemplateNode, jstemplate_tag_helper\r\n  File \"/home/psycojoker/code/django/vegout/ve/lib/python2.7/site-packages/jstemplate/templatetags/base.py\", line 6, in <module>\r\n    from ..loading import find, preprocess, JSTemplateNotFound\r\n  File \"/home/psycojoker/code/django/vegout/ve/lib/python2.7/site-packages/jstemplate/loading.py\", line 80, in <module>\r\n    finders = _get_finders()\r\n  File \"/home/psycojoker/code/django/vegout/ve/lib/python2.7/site-packages/jstemplate/loading.py\", line 72, in _get_finders\r\n    return _get_classes(conf.JSTEMPLATE_FINDERS)\r\n  File \"/home/psycojoker/code/django/vegout/ve/lib/python2.7/site-packages/jstemplate/loading.py\", line 55, in _get_classes\r\n    mod = import_module(modpath)\r\n  File \"/home/psycojoker/code/django/vegout/ve/lib/python2.7/site-packages/django/utils/importlib.py\", line 46, in import_module\r\n    __import__(name)\r\n  File \"/home/psycojoker/code/django/vegout/ve/lib/python2.7/site-packages/jstemplate/finders.py\", line 125, in <module>\r\n    app_template_dirs = _get_app_template_dirs()\r\n  File \"/home/psycojoker/code/django/vegout/ve/lib/python2.7/site-packages/jstemplate/finders.py\", line 112, in _get_app_template_dirs\r\n    raise ImproperlyConfigured(\"ImportError %s: %s\" % (app, e.args[0]))\r\nImproperlyConfigured: ImportError debug_toolbar.apps.DebugToolbarConfig: No module named DebugToolbarConfig\r\n```\r\n\r\nApparently, django-jstemplate is not the first django application to have this problem has you can see here for haystack: https://github.com/toastdriven/django-haystack/issues/1074  which has been fixed this way: https://github.com/toastdriven/django-haystack/commit/a32c8993ae986fe22d362d477b434b39b13a2cc6\r\n\r\nI have taken a similar approach in this pull request.\r\n\r\nKind regards and thanks for your work :)","created_at":"2014-11-19T13:06:19Z","updated_at":"2014-12-09T16:51:07Z","closed_at":"2014-12-09T16:51:07Z","merged_at":"2014-12-09T16:51:07Z","merge_commit_sha":"b368ce12443e28f3db0a2516dce9ea2f4c120520","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mjumbewu/django-jstemplate/pulls/9/commits","review_comments_url":"https://api.github.com/repos/mjumbewu/django-jstemplate/pulls/9/comments","review_comment_url":"https://api.github.com/repos/mjumbewu/django-jstemplate/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mjumbewu/django-jstemplate/issues/9/comments","statuses_url":"https://api.github.com/repos/mjumbewu/django-jstemplate/statuses/3401657e0dfb4084c401514e46372ff339b9efff","head":{"label":"Psycojoker:master","ref":"master","sha":"3401657e0dfb4084c401514e46372ff339b9efff","user":{"login":"Psycojoker","id":41827,"avatar_url":"https://avatars.githubusercontent.com/u/41827?v=3","gravatar_id":"","url":"https://api.github.com/users/Psycojoker","html_url":"https://github.com/Psycojoker","followers_url":"https://api.github.com/users/Psycojoker/followers","following_url":"https://api.github.com/users/Psycojoker/following{/other_user}","gists_url":"https://api.github.com/users/Psycojoker/gists{/gist_id}","starred_url":"https://api.github.com/users/Psycojoker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Psycojoker/subscriptions","organizations_url":"https://api.github.com/users/Psycojoker/orgs","repos_url":"https://api.github.com/users/Psycojoker/repos","events_url":"https://api.github.com/users/Psycojoker/events{/privacy}","received_events_url":"https://api.github.com/users/Psycojoker/received_events","type":"User","site_admin":false},"repo":{"id":26861514,"name":"django-jstemplate","full_name":"Psycojoker/django-jstemplate","owner":{"login":"Psycojoker","id":41827,"avatar_url":"https://avatars.githubusercontent.com/u/41827?v=3","gravatar_id":"","url":"https://api.github.com/users/Psycojoker","html_url":"https://github.com/Psycojoker","followers_url":"https://api.github.com/users/Psycojoker/followers","following_url":"https://api.github.com/users/Psycojoker/following{/other_user}","gists_url":"https://api.github.com/users/Psycojoker/gists{/gist_id}","starred_url":"https://api.github.com/users/Psycojoker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Psycojoker/subscriptions","organizations_url":"https://api.github.com/users/Psycojoker/orgs","repos_url":"https://api.github.com/users/Psycojoker/repos","events_url":"https://api.github.com/users/Psycojoker/events{/privacy}","received_events_url":"https://api.github.com/users/Psycojoker/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Psycojoker/django-jstemplate","description":"Embed Javascript templates (mustache.js and more) into Django templates with minimal fuss.","fork":true,"url":"https://api.github.com/repos/Psycojoker/django-jstemplate","forks_url":"https://api.github.com/repos/Psycojoker/django-jstemplate/forks","keys_url":"https://api.github.com/repos/Psycojoker/django-jstemplate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Psycojoker/django-jstemplate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Psycojoker/django-jstemplate/teams","hooks_url":"https://api.github.com/repos/Psycojoker/django-jstemplate/hooks","issue_events_url":"https://api.github.com/repos/Psycojoker/django-jstemplate/issues/events{/number}","events_url":"https://api.github.com/repos/Psycojoker/django-jstemplate/events","assignees_url":"https://api.github.com/repos/Psycojoker/django-jstemplate/assignees{/user}","branches_url":"https://api.github.com/repos/Psycojoker/django-jstemplate/branches{/branch}","tags_url":"https://api.github.com/repos/Psycojoker/django-jstemplate/tags","blobs_url":"https://api.github.com/repos/Psycojoker/django-jstemplate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Psycojoker/django-jstemplate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Psycojoker/django-jstemplate/git/refs{/sha}","trees_url":"https://api.github.com/repos/Psycojoker/django-jstemplate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Psycojoker/django-jstemplate/statuses/{sha}","languages_url":"https://api.github.com/repos/Psycojoker/django-jstemplate/languages","stargazers_url":"https://api.github.com/repos/Psycojoker/django-jstemplate/stargazers","contributors_url":"https://api.github.com/repos/Psycojoker/django-jstemplate/contributors","subscribers_url":"https://api.github.com/repos/Psycojoker/django-jstemplate/subscribers","subscription_url":"https://api.github.com/repos/Psycojoker/django-jstemplate/subscription","commits_url":"https://api.github.com/repos/Psycojoker/django-jstemplate/commits{/sha}","git_commits_url":"https://api.github.com/repos/Psycojoker/django-jstemplate/git/commits{/sha}","comments_url":"https://api.github.com/repos/Psycojoker/django-jstemplate/comments{/number}","issue_comment_url":"https://api.github.com/repos/Psycojoker/django-jstemplate/issues/comments/{number}","contents_url":"https://api.github.com/repos/Psycojoker/django-jstemplate/contents/{+path}","compare_url":"https://api.github.com/repos/Psycojoker/django-jstemplate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Psycojoker/django-jstemplate/merges","archive_url":"https://api.github.com/repos/Psycojoker/django-jstemplate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Psycojoker/django-jstemplate/downloads","issues_url":"https://api.github.com/repos/Psycojoker/django-jstemplate/issues{/number}","pulls_url":"https://api.github.com/repos/Psycojoker/django-jstemplate/pulls{/number}","milestones_url":"https://api.github.com/repos/Psycojoker/django-jstemplate/milestones{/number}","notifications_url":"https://api.github.com/repos/Psycojoker/django-jstemplate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Psycojoker/django-jstemplate/labels{/name}","releases_url":"https://api.github.com/repos/Psycojoker/django-jstemplate/releases{/id}","created_at":"2014-11-19T13:00:11Z","updated_at":"2014-11-19T13:04:25Z","pushed_at":"2014-11-19T13:04:24Z","git_url":"git://github.com/Psycojoker/django-jstemplate.git","ssh_url":"git@github.com:Psycojoker/django-jstemplate.git","clone_url":"https://github.com/Psycojoker/django-jstemplate.git","svn_url":"https://github.com/Psycojoker/django-jstemplate","homepage":"","size":359,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mjumbewu:master","ref":"master","sha":"e067aece0d0b0dc52918112626a2be47926de246","user":{"login":"mjumbewu","id":146749,"avatar_url":"https://avatars.githubusercontent.com/u/146749?v=3","gravatar_id":"","url":"https://api.github.com/users/mjumbewu","html_url":"https://github.com/mjumbewu","followers_url":"https://api.github.com/users/mjumbewu/followers","following_url":"https://api.github.com/users/mjumbewu/following{/other_user}","gists_url":"https://api.github.com/users/mjumbewu/gists{/gist_id}","starred_url":"https://api.github.com/users/mjumbewu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjumbewu/subscriptions","organizations_url":"https://api.github.com/users/mjumbewu/orgs","repos_url":"https://api.github.com/users/mjumbewu/repos","events_url":"https://api.github.com/users/mjumbewu/events{/privacy}","received_events_url":"https://api.github.com/users/mjumbewu/received_events","type":"User","site_admin":false},"repo":{"id":5697475,"name":"django-jstemplate","full_name":"mjumbewu/django-jstemplate","owner":{"login":"mjumbewu","id":146749,"avatar_url":"https://avatars.githubusercontent.com/u/146749?v=3","gravatar_id":"","url":"https://api.github.com/users/mjumbewu","html_url":"https://github.com/mjumbewu","followers_url":"https://api.github.com/users/mjumbewu/followers","following_url":"https://api.github.com/users/mjumbewu/following{/other_user}","gists_url":"https://api.github.com/users/mjumbewu/gists{/gist_id}","starred_url":"https://api.github.com/users/mjumbewu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjumbewu/subscriptions","organizations_url":"https://api.github.com/users/mjumbewu/orgs","repos_url":"https://api.github.com/users/mjumbewu/repos","events_url":"https://api.github.com/users/mjumbewu/events{/privacy}","received_events_url":"https://api.github.com/users/mjumbewu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mjumbewu/django-jstemplate","description":"Embed Javascript templates (mustache.js and more) into Django templates with minimal fuss.","fork":false,"url":"https://api.github.com/repos/mjumbewu/django-jstemplate","forks_url":"https://api.github.com/repos/mjumbewu/django-jstemplate/forks","keys_url":"https://api.github.com/repos/mjumbewu/django-jstemplate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mjumbewu/django-jstemplate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mjumbewu/django-jstemplate/teams","hooks_url":"https://api.github.com/repos/mjumbewu/django-jstemplate/hooks","issue_events_url":"https://api.github.com/repos/mjumbewu/django-jstemplate/issues/events{/number}","events_url":"https://api.github.com/repos/mjumbewu/django-jstemplate/events","assignees_url":"https://api.github.com/repos/mjumbewu/django-jstemplate/assignees{/user}","branches_url":"https://api.github.com/repos/mjumbewu/django-jstemplate/branches{/branch}","tags_url":"https://api.github.com/repos/mjumbewu/django-jstemplate/tags","blobs_url":"https://api.github.com/repos/mjumbewu/django-jstemplate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mjumbewu/django-jstemplate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mjumbewu/django-jstemplate/git/refs{/sha}","trees_url":"https://api.github.com/repos/mjumbewu/django-jstemplate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mjumbewu/django-jstemplate/statuses/{sha}","languages_url":"https://api.github.com/repos/mjumbewu/django-jstemplate/languages","stargazers_url":"https://api.github.com/repos/mjumbewu/django-jstemplate/stargazers","contributors_url":"https://api.github.com/repos/mjumbewu/django-jstemplate/contributors","subscribers_url":"https://api.github.com/repos/mjumbewu/django-jstemplate/subscribers","subscription_url":"https://api.github.com/repos/mjumbewu/django-jstemplate/subscription","commits_url":"https://api.github.com/repos/mjumbewu/django-jstemplate/commits{/sha}","git_commits_url":"https://api.github.com/repos/mjumbewu/django-jstemplate/git/commits{/sha}","comments_url":"https://api.github.com/repos/mjumbewu/django-jstemplate/comments{/number}","issue_comment_url":"https://api.github.com/repos/mjumbewu/django-jstemplate/issues/comments/{number}","contents_url":"https://api.github.com/repos/mjumbewu/django-jstemplate/contents/{+path}","compare_url":"https://api.github.com/repos/mjumbewu/django-jstemplate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mjumbewu/django-jstemplate/merges","archive_url":"https://api.github.com/repos/mjumbewu/django-jstemplate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mjumbewu/django-jstemplate/downloads","issues_url":"https://api.github.com/repos/mjumbewu/django-jstemplate/issues{/number}","pulls_url":"https://api.github.com/repos/mjumbewu/django-jstemplate/pulls{/number}","milestones_url":"https://api.github.com/repos/mjumbewu/django-jstemplate/milestones{/number}","notifications_url":"https://api.github.com/repos/mjumbewu/django-jstemplate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mjumbewu/django-jstemplate/labels{/name}","releases_url":"https://api.github.com/repos/mjumbewu/django-jstemplate/releases{/id}","created_at":"2012-09-06T04:31:05Z","updated_at":"2014-12-09T16:51:07Z","pushed_at":"2014-12-09T16:51:06Z","git_url":"git://github.com/mjumbewu/django-jstemplate.git","ssh_url":"git@github.com:mjumbewu/django-jstemplate.git","clone_url":"https://github.com/mjumbewu/django-jstemplate.git","svn_url":"https://github.com/mjumbewu/django-jstemplate","homepage":"","size":562,"stargazers_count":33,"watchers_count":33,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":4,"forks":8,"open_issues":4,"watchers":33,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mjumbewu/django-jstemplate/pulls/9"},"html":{"href":"https://github.com/mjumbewu/django-jstemplate/pull/9"},"issue":{"href":"https://api.github.com/repos/mjumbewu/django-jstemplate/issues/9"},"comments":{"href":"https://api.github.com/repos/mjumbewu/django-jstemplate/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/mjumbewu/django-jstemplate/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/mjumbewu/django-jstemplate/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mjumbewu/django-jstemplate/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/mjumbewu/django-jstemplate/statuses/3401657e0dfb4084c401514e46372ff339b9efff"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"mjumbewu","id":146749,"avatar_url":"https://avatars.githubusercontent.com/u/146749?v=3","gravatar_id":"","url":"https://api.github.com/users/mjumbewu","html_url":"https://github.com/mjumbewu","followers_url":"https://api.github.com/users/mjumbewu/followers","following_url":"https://api.github.com/users/mjumbewu/following{/other_user}","gists_url":"https://api.github.com/users/mjumbewu/gists{/gist_id}","starred_url":"https://api.github.com/users/mjumbewu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjumbewu/subscriptions","organizations_url":"https://api.github.com/users/mjumbewu/orgs","repos_url":"https://api.github.com/users/mjumbewu/repos","events_url":"https://api.github.com/users/mjumbewu/events{/privacy}","received_events_url":"https://api.github.com/users/mjumbewu/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":0,"additions":0,"deletions":0,"changed_files":0}}