GitHub PullRequestEvent at 2014-01-14 19:03:18
Repository: WP-e-Commerce
Actor: JustinSainton
Payload: {"action":"closed","number":757,"pull_request":{"url":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/pulls/757","id":11105942,"html_url":"https://github.com/wp-e-commerce/WP-e-Commerce/pull/757","diff_url":"https://github.com/wp-e-commerce/WP-e-Commerce/pull/757.diff","patch_url":"https://github.com/wp-e-commerce/WP-e-Commerce/pull/757.patch","issue_url":"https://github.com/wp-e-commerce/WP-e-Commerce/pull/757","number":757,"state":"closed","title":"PR for issue #756 UPS/USPS modules try to calculate rates over and over","user":{"login":"ReactorShop","id":5473636,"avatar_url":"https://gravatar.com/avatar/53abc076ce7cdf2c85a3ea391cf50ea7?d=https%3A%2F%2Fidenticons.github.com%2F0488229ddaed89676fcbc61255213d6a.png&r=x","gravatar_id":"53abc076ce7cdf2c85a3ea391cf50ea7","url":"https://api.github.com/users/ReactorShop","html_url":"https://github.com/ReactorShop","followers_url":"https://api.github.com/users/ReactorShop/followers","following_url":"https://api.github.com/users/ReactorShop/following{/other_user}","gists_url":"https://api.github.com/users/ReactorShop/gists{/gist_id}","starred_url":"https://api.github.com/users/ReactorShop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReactorShop/subscriptions","organizations_url":"https://api.github.com/users/ReactorShop/orgs","repos_url":"https://api.github.com/users/ReactorShop/repos","events_url":"https://api.github.com/users/ReactorShop/events{/privacy}","received_events_url":"https://api.github.com/users/ReactorShop/received_events","type":"User","site_admin":false},"body":"Here are the modifications indicated in issue #756:\r\n\r\na) Modified the TXT_WPSC_OVER_UPS_WEIGHT constant to\r\nTXT_WPSC_OVER_WEIGHT in wpsc-languages/EN_en.php. The text now reads:\r\n\"Your order exceeds the standard shipping weight limit. Please contact\r\nus to quote other shipping alternatives.\". This text is now used in\r\nboth USPS and UPS weight limit checks.\r\n\r\nb) Added a checkbox to provide the ability of disabling international\r\nshipping, for those who don't want to offer it. The standard behavior\r\nis not affected (Enabled). This is part of the getQuote initial\r\nconditions check.\r\n\r\nc) The UPS module getQuote filter now matches the more efficient USPS\r\nrates initial conditions check. The data checked is the destination\r\ncountry, zip code, and shipment weight. Then there's a shipper weight\r\nlimit check if you want the whole shipment to be rated as one envelope.\r\nIf any of these data checks fail, bail. If these datas checks are ok,\r\ncheck cache and return the rate table if found. Else, continue the rate\r\ntable request process.\r\n\r\nd) The UPS cache check process now matches the USPS cache check\r\nprocess, which uses less variables.\r\n\r\ne) Moved UPS's shipment being assigned at the constructor to getQuote\r\n(right after the bail checks). This avoids the shipment being assigned\r\nto the ash_ups class every time this class is instantiated during each\r\nsession, matching the USPS module behavior.\r\n\r\nf) I removed some redundant variable assignments done at the end of\r\ngetQuote (rates_expire, set_destination). These values have already\r\nbeing assigned before the cache check.\r\n\r\ng) I'm assigning the shipper's internal name to the $args (UPS) or\r\n$data (USPS) arrays, so the wpsc_cart_shipment hook $this->name\r\nparameter is now changed to $args or $data, depending on the shipper\r\nmodule. I'm using this hook to apply a partitioning problem/bin packing\r\nalgorithm to reduce the package quantity, and therefore reduce the\r\nshipping cost. It's a new hook, so at this point no one else should be\r\naffected with this modification.\r\n\r\nh) I'm adding a new hook called wpsc_shipment_data, after setting the\r\nquote request data and before requesting the quote. I'm using this hook\r\nto check if the shipment could be rated as shipped as an envelope\r\n(movies), instead of packages, to modify on the shipment type data flag.\r\n\r\ni) I'm adding another hook called wpsc_rates_table right before\r\nreturning the rates table. I use this to add packaging costs to the\r\nrates, based on the shipment contents.\r\n\r\nIf you have any questions or comments, please don't hesitate to ask.","created_at":"2013-12-27T03:09:59Z","updated_at":"2014-01-14T19:03:18Z","closed_at":"2014-01-14T19:03:18Z","merged_at":"2014-01-14T19:03:18Z","merge_commit_sha":"38ab36e46865dd4edaffbedb942ebbdb1cf345fe","assignee":null,"milestone":{"url":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/milestones/12","labels_url":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/milestones/12/labels","id":442068,"number":12,"title":"3.8.14","description":"","creator":{"login":"garyc40","id":52500,"avatar_url":"https://gravatar.com/avatar/aea5ee57d1e882ad17e95c99265784d1?d=https%3A%2F%2Fidenticons.github.com%2F71e6568104eea8c02b71b5980039cd90.png&r=x","gravatar_id":"aea5ee57d1e882ad17e95c99265784d1","url":"https://api.github.com/users/garyc40","html_url":"https://github.com/garyc40","followers_url":"https://api.github.com/users/garyc40/followers","following_url":"https://api.github.com/users/garyc40/following{/other_user}","gists_url":"https://api.github.com/users/garyc40/gists{/gist_id}","starred_url":"https://api.github.com/users/garyc40/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garyc40/subscriptions","organizations_url":"https://api.github.com/users/garyc40/orgs","repos_url":"https://api.github.com/users/garyc40/repos","events_url":"https://api.github.com/users/garyc40/events{/privacy}","received_events_url":"https://api.github.com/users/garyc40/received_events","type":"User","site_admin":false},"open_issues":125,"closed_issues":39,"state":"open","created_at":"2013-10-01T03:40:59Z","updated_at":"2014-01-14T19:03:18Z","due_on":"2014-03-03T08:00:00Z"},"commits_url":"https://github.com/wp-e-commerce/WP-e-Commerce/pull/757/commits","review_comments_url":"https://github.com/wp-e-commerce/WP-e-Commerce/pull/757/comments","review_comment_url":"/repos/wp-e-commerce/WP-e-Commerce/pulls/comments/{number}","comments_url":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/issues/757/comments","statuses_url":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/statuses/6bd9be98d8525a1e62a447c884ef4c4abf9c7c98","head":{"label":"ReactorShop:master","ref":"master","sha":"6bd9be98d8525a1e62a447c884ef4c4abf9c7c98","user":{"login":"ReactorShop","id":5473636,"avatar_url":"https://gravatar.com/avatar/53abc076ce7cdf2c85a3ea391cf50ea7?d=https%3A%2F%2Fidenticons.github.com%2F0488229ddaed89676fcbc61255213d6a.png&r=x","gravatar_id":"53abc076ce7cdf2c85a3ea391cf50ea7","url":"https://api.github.com/users/ReactorShop","html_url":"https://github.com/ReactorShop","followers_url":"https://api.github.com/users/ReactorShop/followers","following_url":"https://api.github.com/users/ReactorShop/following{/other_user}","gists_url":"https://api.github.com/users/ReactorShop/gists{/gist_id}","starred_url":"https://api.github.com/users/ReactorShop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReactorShop/subscriptions","organizations_url":"https://api.github.com/users/ReactorShop/orgs","repos_url":"https://api.github.com/users/ReactorShop/repos","events_url":"https://api.github.com/users/ReactorShop/events{/privacy}","received_events_url":"https://api.github.com/users/ReactorShop/received_events","type":"User","site_admin":false},"repo":{"id":14249103,"name":"WP-e-Commerce","full_name":"ReactorShop/WP-e-Commerce","owner":{"login":"ReactorShop","id":5473636,"avatar_url":"https://gravatar.com/avatar/53abc076ce7cdf2c85a3ea391cf50ea7?d=https%3A%2F%2Fidenticons.github.com%2F0488229ddaed89676fcbc61255213d6a.png&r=x","gravatar_id":"53abc076ce7cdf2c85a3ea391cf50ea7","url":"https://api.github.com/users/ReactorShop","html_url":"https://github.com/ReactorShop","followers_url":"https://api.github.com/users/ReactorShop/followers","following_url":"https://api.github.com/users/ReactorShop/following{/other_user}","gists_url":"https://api.github.com/users/ReactorShop/gists{/gist_id}","starred_url":"https://api.github.com/users/ReactorShop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReactorShop/subscriptions","organizations_url":"https://api.github.com/users/ReactorShop/orgs","repos_url":"https://api.github.com/users/ReactorShop/repos","events_url":"https://api.github.com/users/ReactorShop/events{/privacy}","received_events_url":"https://api.github.com/users/ReactorShop/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ReactorShop/WP-e-Commerce","description":"WP e-Commerce Plugin - The most popular and robust e-Commerce solution for WordPress","fork":true,"url":"https://api.github.com/repos/ReactorShop/WP-e-Commerce","forks_url":"https://api.github.com/repos/ReactorShop/WP-e-Commerce/forks","keys_url":"https://api.github.com/repos/ReactorShop/WP-e-Commerce/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ReactorShop/WP-e-Commerce/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ReactorShop/WP-e-Commerce/teams","hooks_url":"https://api.github.com/repos/ReactorShop/WP-e-Commerce/hooks","issue_events_url":"https://api.github.com/repos/ReactorShop/WP-e-Commerce/issues/events{/number}","events_url":"https://api.github.com/repos/ReactorShop/WP-e-Commerce/events","assignees_url":"https://api.github.com/repos/ReactorShop/WP-e-Commerce/assignees{/user}","branches_url":"https://api.github.com/repos/ReactorShop/WP-e-Commerce/branches{/branch}","tags_url":"https://api.github.com/repos/ReactorShop/WP-e-Commerce/tags","blobs_url":"https://api.github.com/repos/ReactorShop/WP-e-Commerce/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ReactorShop/WP-e-Commerce/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ReactorShop/WP-e-Commerce/git/refs{/sha}","trees_url":"https://api.github.com/repos/ReactorShop/WP-e-Commerce/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ReactorShop/WP-e-Commerce/statuses/{sha}","languages_url":"https://api.github.com/repos/ReactorShop/WP-e-Commerce/languages","stargazers_url":"https://api.github.com/repos/ReactorShop/WP-e-Commerce/stargazers","contributors_url":"https://api.github.com/repos/ReactorShop/WP-e-Commerce/contributors","subscribers_url":"https://api.github.com/repos/ReactorShop/WP-e-Commerce/subscribers","subscription_url":"https://api.github.com/repos/ReactorShop/WP-e-Commerce/subscription","commits_url":"https://api.github.com/repos/ReactorShop/WP-e-Commerce/commits{/sha}","git_commits_url":"https://api.github.com/repos/ReactorShop/WP-e-Commerce/git/commits{/sha}","comments_url":"https://api.github.com/repos/ReactorShop/WP-e-Commerce/comments{/number}","issue_comment_url":"https://api.github.com/repos/ReactorShop/WP-e-Commerce/issues/comments/{number}","contents_url":"https://api.github.com/repos/ReactorShop/WP-e-Commerce/contents/{+path}","compare_url":"https://api.github.com/repos/ReactorShop/WP-e-Commerce/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ReactorShop/WP-e-Commerce/merges","archive_url":"https://api.github.com/repos/ReactorShop/WP-e-Commerce/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ReactorShop/WP-e-Commerce/downloads","issues_url":"https://api.github.com/repos/ReactorShop/WP-e-Commerce/issues{/number}","pulls_url":"https://api.github.com/repos/ReactorShop/WP-e-Commerce/pulls{/number}","milestones_url":"https://api.github.com/repos/ReactorShop/WP-e-Commerce/milestones{/number}","notifications_url":"https://api.github.com/repos/ReactorShop/WP-e-Commerce/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ReactorShop/WP-e-Commerce/labels{/name}","releases_url":"https://api.github.com/repos/ReactorShop/WP-e-Commerce/releases{/id}","created_at":"2013-11-09T01:44:07Z","updated_at":"2014-01-14T19:03:18Z","pushed_at":"2013-12-27T04:04:43Z","git_url":"git://github.com/ReactorShop/WP-e-Commerce.git","ssh_url":"git@github.com:ReactorShop/WP-e-Commerce.git","clone_url":"https://github.com/ReactorShop/WP-e-Commerce.git","svn_url":"https://github.com/ReactorShop/WP-e-Commerce","homepage":"http://getshopped.org","size":13542,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master","master_branch":"master"}},"base":{"label":"wp-e-commerce:master","ref":"master","sha":"e61f0db0f1dc5ddee58d1a6dd8dcfa4077bc038f","user":{"login":"wp-e-commerce","id":2290601,"avatar_url":"https://identicons.github.com/c608f0ad3516742f1c5b3de5abb1acc1.png","gravatar_id":null,"url":"https://api.github.com/users/wp-e-commerce","html_url":"https://github.com/wp-e-commerce","followers_url":"https://api.github.com/users/wp-e-commerce/followers","following_url":"https://api.github.com/users/wp-e-commerce/following{/other_user}","gists_url":"https://api.github.com/users/wp-e-commerce/gists{/gist_id}","starred_url":"https://api.github.com/users/wp-e-commerce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wp-e-commerce/subscriptions","organizations_url":"https://api.github.com/users/wp-e-commerce/orgs","repos_url":"https://api.github.com/users/wp-e-commerce/repos","events_url":"https://api.github.com/users/wp-e-commerce/events{/privacy}","received_events_url":"https://api.github.com/users/wp-e-commerce/received_events","type":"Organization","site_admin":false},"repo":{"id":2052629,"name":"WP-e-Commerce","full_name":"wp-e-commerce/WP-e-Commerce","owner":{"login":"wp-e-commerce","id":2290601,"avatar_url":"https://identicons.github.com/c608f0ad3516742f1c5b3de5abb1acc1.png","gravatar_id":null,"url":"https://api.github.com/users/wp-e-commerce","html_url":"https://github.com/wp-e-commerce","followers_url":"https://api.github.com/users/wp-e-commerce/followers","following_url":"https://api.github.com/users/wp-e-commerce/following{/other_user}","gists_url":"https://api.github.com/users/wp-e-commerce/gists{/gist_id}","starred_url":"https://api.github.com/users/wp-e-commerce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wp-e-commerce/subscriptions","organizations_url":"https://api.github.com/users/wp-e-commerce/orgs","repos_url":"https://api.github.com/users/wp-e-commerce/repos","events_url":"https://api.github.com/users/wp-e-commerce/events{/privacy}","received_events_url":"https://api.github.com/users/wp-e-commerce/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wp-e-commerce/WP-e-Commerce","description":"WP e-Commerce Plugin - The most popular and robust e-Commerce solution for WordPress","fork":false,"url":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce","forks_url":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/forks","keys_url":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/teams","hooks_url":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/hooks","issue_events_url":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/issues/events{/number}","events_url":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/events","assignees_url":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/assignees{/user}","branches_url":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/branches{/branch}","tags_url":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/tags","blobs_url":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/git/refs{/sha}","trees_url":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/statuses/{sha}","languages_url":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/languages","stargazers_url":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/stargazers","contributors_url":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/contributors","subscribers_url":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/subscribers","subscription_url":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/subscription","commits_url":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/commits{/sha}","git_commits_url":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/git/commits{/sha}","comments_url":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/comments{/number}","issue_comment_url":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/issues/comments/{number}","contents_url":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/contents/{+path}","compare_url":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/merges","archive_url":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/downloads","issues_url":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/issues{/number}","pulls_url":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/pulls{/number}","milestones_url":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/milestones{/number}","notifications_url":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/labels{/name}","releases_url":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/releases{/id}","created_at":"2011-07-15T10:54:16Z","updated_at":"2014-01-14T19:03:18Z","pushed_at":"2014-01-14T19:03:18Z","git_url":"git://github.com/wp-e-commerce/WP-e-Commerce.git","ssh_url":"git@github.com:wp-e-commerce/WP-e-Commerce.git","clone_url":"https://github.com/wp-e-commerce/WP-e-Commerce.git","svn_url":"https://github.com/wp-e-commerce/WP-e-Commerce","homepage":"http://getshopped.org","size":18774,"stargazers_count":106,"watchers_count":106,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":109,"mirror_url":null,"open_issues_count":219,"forks":109,"open_issues":219,"watchers":106,"default_branch":"master","master_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/pulls/757"},"html":{"href":"https://github.com/wp-e-commerce/WP-e-Commerce/pull/757"},"issue":{"href":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/issues/757"},"comments":{"href":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/issues/757/comments"},"review_comments":{"href":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/pulls/757/comments"},"statuses":{"href":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/statuses/6bd9be98d8525a1e62a447c884ef4c4abf9c7c98"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"JustinSainton","id":1168754,"avatar_url":"https://gravatar.com/avatar/02fbf19ad633e203e3bc571b80ca3f66?d=https%3A%2F%2Fidenticons.github.com%2Fa321038fe21b1fa297ec991dd928d243.png&r=x","gravatar_id":"02fbf19ad633e203e3bc571b80ca3f66","url":"https://api.github.com/users/JustinSainton","html_url":"https://github.com/JustinSainton","followers_url":"https://api.github.com/users/JustinSainton/followers","following_url":"https://api.github.com/users/JustinSainton/following{/other_user}","gists_url":"https://api.github.com/users/JustinSainton/gists{/gist_id}","starred_url":"https://api.github.com/users/JustinSainton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JustinSainton/subscriptions","organizations_url":"https://api.github.com/users/JustinSainton/orgs","repos_url":"https://api.github.com/users/JustinSainton/repos","events_url":"https://api.github.com/users/JustinSainton/events{/privacy}","received_events_url":"https://api.github.com/users/JustinSainton/received_events","type":"User","site_admin":false},"comments":1,"review_comments":2,"commits":5,"additions":141,"deletions":138,"changed_files":2}}