GitHub PullRequestReviewCommentEvent at 2014-10-23 19:21:48
Repository: angular-google-maps
Actor: nmccready
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/angular-ui/angular-google-maps/pulls/comments/19301046","id":19301046,"diff_hunk":"@@ -1,16 +0,0 @@\n-angular.module(\"google-maps.directives.api.utils\".ns())\n-.factory \"FitHelper\".ns(), [","path":"src/coffee/directives/api/utils/fit-helper.coffee","position":2,"original_position":2,"commit_id":"34147baae5136dc2a9b5ce8a07ce626ad0b502bc","original_commit_id":"34147baae5136dc2a9b5ce8a07ce626ad0b502bc","user":{"login":"nmccready","id":583593,"avatar_url":"https://avatars.githubusercontent.com/u/583593?v=2","gravatar_id":"","url":"https://api.github.com/users/nmccready","html_url":"https://github.com/nmccready","followers_url":"https://api.github.com/users/nmccready/followers","following_url":"https://api.github.com/users/nmccready/following{/other_user}","gists_url":"https://api.github.com/users/nmccready/gists{/gist_id}","starred_url":"https://api.github.com/users/nmccready/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmccready/subscriptions","organizations_url":"https://api.github.com/users/nmccready/orgs","repos_url":"https://api.github.com/users/nmccready/repos","events_url":"https://api.github.com/users/nmccready/events{/privacy}","received_events_url":"https://api.github.com/users/nmccready/received_events","type":"User","site_admin":false},"body":"This should not be removed as fit was rolled into the old MarkerManagers . This way fit is supported by Marker and the Markers directive.","created_at":"2014-10-23T19:21:48Z","updated_at":"2014-10-23T19:21:48Z","html_url":"https://github.com/angular-ui/angular-google-maps/pull/798#discussion_r19301046","pull_request_url":"https://api.github.com/repos/angular-ui/angular-google-maps/pulls/798","_links":{"self":{"href":"https://api.github.com/repos/angular-ui/angular-google-maps/pulls/comments/19301046"},"html":{"href":"https://github.com/angular-ui/angular-google-maps/pull/798#discussion_r19301046"},"pull_request":{"href":"https://api.github.com/repos/angular-ui/angular-google-maps/pulls/798"}}},"pull_request":{"url":"https://api.github.com/repos/angular-ui/angular-google-maps/pulls/798","id":23244283,"html_url":"https://github.com/angular-ui/angular-google-maps/pull/798","diff_url":"https://github.com/angular-ui/angular-google-maps/pull/798.diff","patch_url":"https://github.com/angular-ui/angular-google-maps/pull/798.patch","issue_url":"https://api.github.com/repos/angular-ui/angular-google-maps/issues/798","number":798,"state":"open","locked":false,"title":"[develop] Performance Improvements (Markers, MarkerClusterer Rewrite)","user":{"login":"nmccready","id":583593,"avatar_url":"https://avatars.githubusercontent.com/u/583593?v=2","gravatar_id":"","url":"https://api.github.com/users/nmccready","html_url":"https://github.com/nmccready","followers_url":"https://api.github.com/users/nmccready/followers","following_url":"https://api.github.com/users/nmccready/following{/other_user}","gists_url":"https://api.github.com/users/nmccready/gists{/gist_id}","starred_url":"https://api.github.com/users/nmccready/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmccready/subscriptions","organizations_url":"https://api.github.com/users/nmccready/orgs","repos_url":"https://api.github.com/users/nmccready/repos","events_url":"https://api.github.com/users/nmccready/events{/privacy}","received_events_url":"https://api.github.com/users/nmccready/received_events","type":"User","site_admin":false},"body":"Performance tweaks\r\n\r\n- lazyUpdate map.coffee\r\n- modelsByRef to disable equality checks\r\n- marker managers improvements (MarkerClustererPlus dropped from google tools sdk)\r\n\r\nThis is to open up this major PR for discussion how to handle merging in these changes.","created_at":"2014-10-23T17:23:29Z","updated_at":"2014-10-23T19:21:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/angular-ui/angular-google-maps/pulls/798/commits","review_comments_url":"https://api.github.com/repos/angular-ui/angular-google-maps/pulls/798/comments","review_comment_url":"https://api.github.com/repos/angular-ui/angular-google-maps/pulls/comments/{number}","comments_url":"https://api.github.com/repos/angular-ui/angular-google-maps/issues/798/comments","statuses_url":"https://api.github.com/repos/angular-ui/angular-google-maps/statuses/34147baae5136dc2a9b5ce8a07ce626ad0b502bc","head":{"label":"ccg1415:performance_tweaks","ref":"performance_tweaks","sha":"34147baae5136dc2a9b5ce8a07ce626ad0b502bc","user":{"login":"ccg1415","id":2971512,"avatar_url":"https://avatars.githubusercontent.com/u/2971512?v=2","gravatar_id":"","url":"https://api.github.com/users/ccg1415","html_url":"https://github.com/ccg1415","followers_url":"https://api.github.com/users/ccg1415/followers","following_url":"https://api.github.com/users/ccg1415/following{/other_user}","gists_url":"https://api.github.com/users/ccg1415/gists{/gist_id}","starred_url":"https://api.github.com/users/ccg1415/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ccg1415/subscriptions","organizations_url":"https://api.github.com/users/ccg1415/orgs","repos_url":"https://api.github.com/users/ccg1415/repos","events_url":"https://api.github.com/users/ccg1415/events{/privacy}","received_events_url":"https://api.github.com/users/ccg1415/received_events","type":"User","site_admin":false},"repo":{"id":20918044,"name":"angular-google-maps","full_name":"ccg1415/angular-google-maps","owner":{"login":"ccg1415","id":2971512,"avatar_url":"https://avatars.githubusercontent.com/u/2971512?v=2","gravatar_id":"","url":"https://api.github.com/users/ccg1415","html_url":"https://github.com/ccg1415","followers_url":"https://api.github.com/users/ccg1415/followers","following_url":"https://api.github.com/users/ccg1415/following{/other_user}","gists_url":"https://api.github.com/users/ccg1415/gists{/gist_id}","starred_url":"https://api.github.com/users/ccg1415/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ccg1415/subscriptions","organizations_url":"https://api.github.com/users/ccg1415/orgs","repos_url":"https://api.github.com/users/ccg1415/repos","events_url":"https://api.github.com/users/ccg1415/events{/privacy}","received_events_url":"https://api.github.com/users/ccg1415/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ccg1415/angular-google-maps","description":"AngularJS directives for the Google Maps Javascript API","fork":true,"url":"https://api.github.com/repos/ccg1415/angular-google-maps","forks_url":"https://api.github.com/repos/ccg1415/angular-google-maps/forks","keys_url":"https://api.github.com/repos/ccg1415/angular-google-maps/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ccg1415/angular-google-maps/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ccg1415/angular-google-maps/teams","hooks_url":"https://api.github.com/repos/ccg1415/angular-google-maps/hooks","issue_events_url":"https://api.github.com/repos/ccg1415/angular-google-maps/issues/events{/number}","events_url":"https://api.github.com/repos/ccg1415/angular-google-maps/events","assignees_url":"https://api.github.com/repos/ccg1415/angular-google-maps/assignees{/user}","branches_url":"https://api.github.com/repos/ccg1415/angular-google-maps/branches{/branch}","tags_url":"https://api.github.com/repos/ccg1415/angular-google-maps/tags","blobs_url":"https://api.github.com/repos/ccg1415/angular-google-maps/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ccg1415/angular-google-maps/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ccg1415/angular-google-maps/git/refs{/sha}","trees_url":"https://api.github.com/repos/ccg1415/angular-google-maps/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ccg1415/angular-google-maps/statuses/{sha}","languages_url":"https://api.github.com/repos/ccg1415/angular-google-maps/languages","stargazers_url":"https://api.github.com/repos/ccg1415/angular-google-maps/stargazers","contributors_url":"https://api.github.com/repos/ccg1415/angular-google-maps/contributors","subscribers_url":"https://api.github.com/repos/ccg1415/angular-google-maps/subscribers","subscription_url":"https://api.github.com/repos/ccg1415/angular-google-maps/subscription","commits_url":"https://api.github.com/repos/ccg1415/angular-google-maps/commits{/sha}","git_commits_url":"https://api.github.com/repos/ccg1415/angular-google-maps/git/commits{/sha}","comments_url":"https://api.github.com/repos/ccg1415/angular-google-maps/comments{/number}","issue_comment_url":"https://api.github.com/repos/ccg1415/angular-google-maps/issues/comments/{number}","contents_url":"https://api.github.com/repos/ccg1415/angular-google-maps/contents/{+path}","compare_url":"https://api.github.com/repos/ccg1415/angular-google-maps/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ccg1415/angular-google-maps/merges","archive_url":"https://api.github.com/repos/ccg1415/angular-google-maps/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ccg1415/angular-google-maps/downloads","issues_url":"https://api.github.com/repos/ccg1415/angular-google-maps/issues{/number}","pulls_url":"https://api.github.com/repos/ccg1415/angular-google-maps/pulls{/number}","milestones_url":"https://api.github.com/repos/ccg1415/angular-google-maps/milestones{/number}","notifications_url":"https://api.github.com/repos/ccg1415/angular-google-maps/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ccg1415/angular-google-maps/labels{/name}","releases_url":"https://api.github.com/repos/ccg1415/angular-google-maps/releases{/id}","created_at":"2014-06-17T09:40:50Z","updated_at":"2014-10-16T13:45:39Z","pushed_at":"2014-10-22T16:05:58Z","git_url":"git://github.com/ccg1415/angular-google-maps.git","ssh_url":"git@github.com:ccg1415/angular-google-maps.git","clone_url":"https://github.com/ccg1415/angular-google-maps.git","svn_url":"https://github.com/ccg1415/angular-google-maps","homepage":null,"size":8772,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular-ui:develop","ref":"develop","sha":"b75e76bedb77a48a2372458cd33dee962fa28221","user":{"login":"angular-ui","id":1530011,"avatar_url":"https://avatars.githubusercontent.com/u/1530011?v=2","gravatar_id":"","url":"https://api.github.com/users/angular-ui","html_url":"https://github.com/angular-ui","followers_url":"https://api.github.com/users/angular-ui/followers","following_url":"https://api.github.com/users/angular-ui/following{/other_user}","gists_url":"https://api.github.com/users/angular-ui/gists{/gist_id}","starred_url":"https://api.github.com/users/angular-ui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular-ui/subscriptions","organizations_url":"https://api.github.com/users/angular-ui/orgs","repos_url":"https://api.github.com/users/angular-ui/repos","events_url":"https://api.github.com/users/angular-ui/events{/privacy}","received_events_url":"https://api.github.com/users/angular-ui/received_events","type":"Organization","site_admin":false},"repo":{"id":5438867,"name":"angular-google-maps","full_name":"angular-ui/angular-google-maps","owner":{"login":"angular-ui","id":1530011,"avatar_url":"https://avatars.githubusercontent.com/u/1530011?v=2","gravatar_id":"","url":"https://api.github.com/users/angular-ui","html_url":"https://github.com/angular-ui","followers_url":"https://api.github.com/users/angular-ui/followers","following_url":"https://api.github.com/users/angular-ui/following{/other_user}","gists_url":"https://api.github.com/users/angular-ui/gists{/gist_id}","starred_url":"https://api.github.com/users/angular-ui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular-ui/subscriptions","organizations_url":"https://api.github.com/users/angular-ui/orgs","repos_url":"https://api.github.com/users/angular-ui/repos","events_url":"https://api.github.com/users/angular-ui/events{/privacy}","received_events_url":"https://api.github.com/users/angular-ui/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular-ui/angular-google-maps","description":"AngularJS directives for the Google Maps Javascript API","fork":false,"url":"https://api.github.com/repos/angular-ui/angular-google-maps","forks_url":"https://api.github.com/repos/angular-ui/angular-google-maps/forks","keys_url":"https://api.github.com/repos/angular-ui/angular-google-maps/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular-ui/angular-google-maps/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular-ui/angular-google-maps/teams","hooks_url":"https://api.github.com/repos/angular-ui/angular-google-maps/hooks","issue_events_url":"https://api.github.com/repos/angular-ui/angular-google-maps/issues/events{/number}","events_url":"https://api.github.com/repos/angular-ui/angular-google-maps/events","assignees_url":"https://api.github.com/repos/angular-ui/angular-google-maps/assignees{/user}","branches_url":"https://api.github.com/repos/angular-ui/angular-google-maps/branches{/branch}","tags_url":"https://api.github.com/repos/angular-ui/angular-google-maps/tags","blobs_url":"https://api.github.com/repos/angular-ui/angular-google-maps/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular-ui/angular-google-maps/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular-ui/angular-google-maps/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular-ui/angular-google-maps/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular-ui/angular-google-maps/statuses/{sha}","languages_url":"https://api.github.com/repos/angular-ui/angular-google-maps/languages","stargazers_url":"https://api.github.com/repos/angular-ui/angular-google-maps/stargazers","contributors_url":"https://api.github.com/repos/angular-ui/angular-google-maps/contributors","subscribers_url":"https://api.github.com/repos/angular-ui/angular-google-maps/subscribers","subscription_url":"https://api.github.com/repos/angular-ui/angular-google-maps/subscription","commits_url":"https://api.github.com/repos/angular-ui/angular-google-maps/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular-ui/angular-google-maps/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular-ui/angular-google-maps/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular-ui/angular-google-maps/issues/comments/{number}","contents_url":"https://api.github.com/repos/angular-ui/angular-google-maps/contents/{+path}","compare_url":"https://api.github.com/repos/angular-ui/angular-google-maps/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular-ui/angular-google-maps/merges","archive_url":"https://api.github.com/repos/angular-ui/angular-google-maps/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular-ui/angular-google-maps/downloads","issues_url":"https://api.github.com/repos/angular-ui/angular-google-maps/issues{/number}","pulls_url":"https://api.github.com/repos/angular-ui/angular-google-maps/pulls{/number}","milestones_url":"https://api.github.com/repos/angular-ui/angular-google-maps/milestones{/number}","notifications_url":"https://api.github.com/repos/angular-ui/angular-google-maps/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular-ui/angular-google-maps/labels{/name}","releases_url":"https://api.github.com/repos/angular-ui/angular-google-maps/releases{/id}","created_at":"2012-08-16T12:50:47Z","updated_at":"2014-10-23T11:07:33Z","pushed_at":"2014-10-23T17:08:41Z","git_url":"git://github.com/angular-ui/angular-google-maps.git","ssh_url":"git@github.com:angular-ui/angular-google-maps.git","clone_url":"https://github.com/angular-ui/angular-google-maps.git","svn_url":"https://github.com/angular-ui/angular-google-maps","homepage":"http://angular-ui.github.io/angular-google-maps","size":31887,"stargazers_count":1157,"watchers_count":1157,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":464,"mirror_url":null,"open_issues_count":67,"forks":464,"open_issues":67,"watchers":1157,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular-ui/angular-google-maps/pulls/798"},"html":{"href":"https://github.com/angular-ui/angular-google-maps/pull/798"},"issue":{"href":"https://api.github.com/repos/angular-ui/angular-google-maps/issues/798"},"comments":{"href":"https://api.github.com/repos/angular-ui/angular-google-maps/issues/798/comments"},"review_comments":{"href":"https://api.github.com/repos/angular-ui/angular-google-maps/pulls/798/comments"},"review_comment":{"href":"https://api.github.com/repos/angular-ui/angular-google-maps/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/angular-ui/angular-google-maps/pulls/798/commits"},"statuses":{"href":"https://api.github.com/repos/angular-ui/angular-google-maps/statuses/34147baae5136dc2a9b5ce8a07ce626ad0b502bc"}}}}