GitHub PullRequestReviewCommentEvent at 2014-10-21 16:07:19
Repository: bitmonero
Actor: fluffypony
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/monero-project/bitmonero/pulls/comments/19158577","id":19158577,"diff_hunk":"@@ -0,0 +1,51 @@\n+# Copyright (c) 2014, The Monero Project\n+#\n+# All rights reserved.\n+#\n+# Redistribution and use in source and binary forms, with or without modification, are\n+# permitted provided that the following conditions are met:\n+#\n+# 1. Redistributions of source code must retain the above copyright notice, this list of\n+#    conditions and the following disclaimer.\n+#\n+# 2. Redistributions in binary form must reproduce the above copyright notice, this list\n+#    of conditions and the following disclaimer in the documentation and/or other\n+#    materials provided with the distribution.\n+#\n+# 3. Neither the name of the copyright holder nor the names of its contributors may be\n+#    used to endorse or promote products derived from this software without specific\n+#    prior written permission.\n+#\n+# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS \"AS IS\" AND ANY\n+# EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF\n+# MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL\n+# THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,\n+# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,\n+# PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS\n+# INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT,\n+# STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF\n+# THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.\n+\n+set(common_sources\n+  base58.cpp\n+  command_line.cpp\n+  dns_utils.cpp\n+  util.cpp)\n+\n+set(common_headers\n+  base58.h\n+  boost_serialization_helper.h\n+  command_line.h\n+  dns_utils.h\n+  int-util.h\n+  pod-class.h\n+  unordered_containers_boost_serialization.h\n+  util.h\n+  varint.h)","path":"src/common/CMakeLists.txt","position":44,"original_position":44,"commit_id":"ba78c15fd2af1946ea5bca1b4bfe65614d345b12","original_commit_id":"ba78c15fd2af1946ea5bca1b4bfe65614d345b12","user":{"login":"fluffypony","id":1944293,"avatar_url":"https://avatars.githubusercontent.com/u/1944293?v=2","gravatar_id":"","url":"https://api.github.com/users/fluffypony","html_url":"https://github.com/fluffypony","followers_url":"https://api.github.com/users/fluffypony/followers","following_url":"https://api.github.com/users/fluffypony/following{/other_user}","gists_url":"https://api.github.com/users/fluffypony/gists{/gist_id}","starred_url":"https://api.github.com/users/fluffypony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fluffypony/subscriptions","organizations_url":"https://api.github.com/users/fluffypony/orgs","repos_url":"https://api.github.com/users/fluffypony/repos","events_url":"https://api.github.com/users/fluffypony/events{/privacy}","received_events_url":"https://api.github.com/users/fluffypony/received_events","type":"User","site_admin":false},"body":"All headers are private at this stage, but I'd love to have a framework in place so that as-and-when we refactor things out into a public library we know what we need to do in the CMakeLists.","created_at":"2014-10-21T16:07:19Z","updated_at":"2014-10-21T16:07:19Z","html_url":"https://github.com/monero-project/bitmonero/pull/180#discussion_r19158577","pull_request_url":"https://api.github.com/repos/monero-project/bitmonero/pulls/180","_links":{"self":{"href":"https://api.github.com/repos/monero-project/bitmonero/pulls/comments/19158577"},"html":{"href":"https://github.com/monero-project/bitmonero/pull/180#discussion_r19158577"},"pull_request":{"href":"https://api.github.com/repos/monero-project/bitmonero/pulls/180"}}},"pull_request":{"url":"https://api.github.com/repos/monero-project/bitmonero/pulls/180","id":23094366,"html_url":"https://github.com/monero-project/bitmonero/pull/180","diff_url":"https://github.com/monero-project/bitmonero/pull/180.diff","patch_url":"https://github.com/monero-project/bitmonero/pull/180.patch","issue_url":"https://api.github.com/repos/monero-project/bitmonero/issues/180","number":180,"state":"open","locked":false,"title":"cmake-work","user":{"login":"mathstuf","id":97253,"avatar_url":"https://avatars.githubusercontent.com/u/97253?v=2","gravatar_id":"","url":"https://api.github.com/users/mathstuf","html_url":"https://github.com/mathstuf","followers_url":"https://api.github.com/users/mathstuf/followers","following_url":"https://api.github.com/users/mathstuf/following{/other_user}","gists_url":"https://api.github.com/users/mathstuf/gists{/gist_id}","starred_url":"https://api.github.com/users/mathstuf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mathstuf/subscriptions","organizations_url":"https://api.github.com/users/mathstuf/orgs","repos_url":"https://api.github.com/users/mathstuf/repos","events_url":"https://api.github.com/users/mathstuf/events{/privacy}","received_events_url":"https://api.github.com/users/mathstuf/received_events","type":"User","site_admin":false},"body":"Initial splitting up and cleanup of CMake code (looking for feedback for now; merging would be best held off until the other directories have the same treatment). I'll add comments inline as to where some things need attention yet.","created_at":"2014-10-21T15:29:54Z","updated_at":"2014-10-21T16:07:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2aa02312c10c936a1897d717cb0677779b5f6347","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/monero-project/bitmonero/pulls/180/commits","review_comments_url":"https://api.github.com/repos/monero-project/bitmonero/pulls/180/comments","review_comment_url":"https://api.github.com/repos/monero-project/bitmonero/pulls/comments/{number}","comments_url":"https://api.github.com/repos/monero-project/bitmonero/issues/180/comments","statuses_url":"https://api.github.com/repos/monero-project/bitmonero/statuses/ba78c15fd2af1946ea5bca1b4bfe65614d345b12","head":{"label":"mathstuf:cmake-work","ref":"cmake-work","sha":"ba78c15fd2af1946ea5bca1b4bfe65614d345b12","user":{"login":"mathstuf","id":97253,"avatar_url":"https://avatars.githubusercontent.com/u/97253?v=2","gravatar_id":"","url":"https://api.github.com/users/mathstuf","html_url":"https://github.com/mathstuf","followers_url":"https://api.github.com/users/mathstuf/followers","following_url":"https://api.github.com/users/mathstuf/following{/other_user}","gists_url":"https://api.github.com/users/mathstuf/gists{/gist_id}","starred_url":"https://api.github.com/users/mathstuf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mathstuf/subscriptions","organizations_url":"https://api.github.com/users/mathstuf/orgs","repos_url":"https://api.github.com/users/mathstuf/repos","events_url":"https://api.github.com/users/mathstuf/events{/privacy}","received_events_url":"https://api.github.com/users/mathstuf/received_events","type":"User","site_admin":false},"repo":{"id":25526711,"name":"bitmonero","full_name":"mathstuf/bitmonero","owner":{"login":"mathstuf","id":97253,"avatar_url":"https://avatars.githubusercontent.com/u/97253?v=2","gravatar_id":"","url":"https://api.github.com/users/mathstuf","html_url":"https://github.com/mathstuf","followers_url":"https://api.github.com/users/mathstuf/followers","following_url":"https://api.github.com/users/mathstuf/following{/other_user}","gists_url":"https://api.github.com/users/mathstuf/gists{/gist_id}","starred_url":"https://api.github.com/users/mathstuf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mathstuf/subscriptions","organizations_url":"https://api.github.com/users/mathstuf/orgs","repos_url":"https://api.github.com/users/mathstuf/repos","events_url":"https://api.github.com/users/mathstuf/events{/privacy}","received_events_url":"https://api.github.com/users/mathstuf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mathstuf/bitmonero","description":"Monero: the secure, private, untraceable cryptocurrency","fork":true,"url":"https://api.github.com/repos/mathstuf/bitmonero","forks_url":"https://api.github.com/repos/mathstuf/bitmonero/forks","keys_url":"https://api.github.com/repos/mathstuf/bitmonero/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mathstuf/bitmonero/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mathstuf/bitmonero/teams","hooks_url":"https://api.github.com/repos/mathstuf/bitmonero/hooks","issue_events_url":"https://api.github.com/repos/mathstuf/bitmonero/issues/events{/number}","events_url":"https://api.github.com/repos/mathstuf/bitmonero/events","assignees_url":"https://api.github.com/repos/mathstuf/bitmonero/assignees{/user}","branches_url":"https://api.github.com/repos/mathstuf/bitmonero/branches{/branch}","tags_url":"https://api.github.com/repos/mathstuf/bitmonero/tags","blobs_url":"https://api.github.com/repos/mathstuf/bitmonero/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mathstuf/bitmonero/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mathstuf/bitmonero/git/refs{/sha}","trees_url":"https://api.github.com/repos/mathstuf/bitmonero/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mathstuf/bitmonero/statuses/{sha}","languages_url":"https://api.github.com/repos/mathstuf/bitmonero/languages","stargazers_url":"https://api.github.com/repos/mathstuf/bitmonero/stargazers","contributors_url":"https://api.github.com/repos/mathstuf/bitmonero/contributors","subscribers_url":"https://api.github.com/repos/mathstuf/bitmonero/subscribers","subscription_url":"https://api.github.com/repos/mathstuf/bitmonero/subscription","commits_url":"https://api.github.com/repos/mathstuf/bitmonero/commits{/sha}","git_commits_url":"https://api.github.com/repos/mathstuf/bitmonero/git/commits{/sha}","comments_url":"https://api.github.com/repos/mathstuf/bitmonero/comments{/number}","issue_comment_url":"https://api.github.com/repos/mathstuf/bitmonero/issues/comments/{number}","contents_url":"https://api.github.com/repos/mathstuf/bitmonero/contents/{+path}","compare_url":"https://api.github.com/repos/mathstuf/bitmonero/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mathstuf/bitmonero/merges","archive_url":"https://api.github.com/repos/mathstuf/bitmonero/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mathstuf/bitmonero/downloads","issues_url":"https://api.github.com/repos/mathstuf/bitmonero/issues{/number}","pulls_url":"https://api.github.com/repos/mathstuf/bitmonero/pulls{/number}","milestones_url":"https://api.github.com/repos/mathstuf/bitmonero/milestones{/number}","notifications_url":"https://api.github.com/repos/mathstuf/bitmonero/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mathstuf/bitmonero/labels{/name}","releases_url":"https://api.github.com/repos/mathstuf/bitmonero/releases{/id}","created_at":"2014-10-21T14:25:08Z","updated_at":"2014-10-19T01:23:40Z","pushed_at":"2014-10-21T15:28:07Z","git_url":"git://github.com/mathstuf/bitmonero.git","ssh_url":"git@github.com:mathstuf/bitmonero.git","clone_url":"https://github.com/mathstuf/bitmonero.git","svn_url":"https://github.com/mathstuf/bitmonero","homepage":"monero.cc","size":15355,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"monero-project:master","ref":"master","sha":"8eb23757993251f3b8cdf7638ecd53c7d854afbc","user":{"login":"monero-project","id":7450663,"avatar_url":"https://avatars.githubusercontent.com/u/7450663?v=2","gravatar_id":"","url":"https://api.github.com/users/monero-project","html_url":"https://github.com/monero-project","followers_url":"https://api.github.com/users/monero-project/followers","following_url":"https://api.github.com/users/monero-project/following{/other_user}","gists_url":"https://api.github.com/users/monero-project/gists{/gist_id}","starred_url":"https://api.github.com/users/monero-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monero-project/subscriptions","organizations_url":"https://api.github.com/users/monero-project/orgs","repos_url":"https://api.github.com/users/monero-project/repos","events_url":"https://api.github.com/users/monero-project/events{/privacy}","received_events_url":"https://api.github.com/users/monero-project/received_events","type":"User","site_admin":false},"repo":{"id":19316619,"name":"bitmonero","full_name":"monero-project/bitmonero","owner":{"login":"monero-project","id":7450663,"avatar_url":"https://avatars.githubusercontent.com/u/7450663?v=2","gravatar_id":"","url":"https://api.github.com/users/monero-project","html_url":"https://github.com/monero-project","followers_url":"https://api.github.com/users/monero-project/followers","following_url":"https://api.github.com/users/monero-project/following{/other_user}","gists_url":"https://api.github.com/users/monero-project/gists{/gist_id}","starred_url":"https://api.github.com/users/monero-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monero-project/subscriptions","organizations_url":"https://api.github.com/users/monero-project/orgs","repos_url":"https://api.github.com/users/monero-project/repos","events_url":"https://api.github.com/users/monero-project/events{/privacy}","received_events_url":"https://api.github.com/users/monero-project/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/monero-project/bitmonero","description":"Monero: the secure, private, untraceable cryptocurrency","fork":false,"url":"https://api.github.com/repos/monero-project/bitmonero","forks_url":"https://api.github.com/repos/monero-project/bitmonero/forks","keys_url":"https://api.github.com/repos/monero-project/bitmonero/keys{/key_id}","collaborators_url":"https://api.github.com/repos/monero-project/bitmonero/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/monero-project/bitmonero/teams","hooks_url":"https://api.github.com/repos/monero-project/bitmonero/hooks","issue_events_url":"https://api.github.com/repos/monero-project/bitmonero/issues/events{/number}","events_url":"https://api.github.com/repos/monero-project/bitmonero/events","assignees_url":"https://api.github.com/repos/monero-project/bitmonero/assignees{/user}","branches_url":"https://api.github.com/repos/monero-project/bitmonero/branches{/branch}","tags_url":"https://api.github.com/repos/monero-project/bitmonero/tags","blobs_url":"https://api.github.com/repos/monero-project/bitmonero/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/monero-project/bitmonero/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/monero-project/bitmonero/git/refs{/sha}","trees_url":"https://api.github.com/repos/monero-project/bitmonero/git/trees{/sha}","statuses_url":"https://api.github.com/repos/monero-project/bitmonero/statuses/{sha}","languages_url":"https://api.github.com/repos/monero-project/bitmonero/languages","stargazers_url":"https://api.github.com/repos/monero-project/bitmonero/stargazers","contributors_url":"https://api.github.com/repos/monero-project/bitmonero/contributors","subscribers_url":"https://api.github.com/repos/monero-project/bitmonero/subscribers","subscription_url":"https://api.github.com/repos/monero-project/bitmonero/subscription","commits_url":"https://api.github.com/repos/monero-project/bitmonero/commits{/sha}","git_commits_url":"https://api.github.com/repos/monero-project/bitmonero/git/commits{/sha}","comments_url":"https://api.github.com/repos/monero-project/bitmonero/comments{/number}","issue_comment_url":"https://api.github.com/repos/monero-project/bitmonero/issues/comments/{number}","contents_url":"https://api.github.com/repos/monero-project/bitmonero/contents/{+path}","compare_url":"https://api.github.com/repos/monero-project/bitmonero/compare/{base}...{head}","merges_url":"https://api.github.com/repos/monero-project/bitmonero/merges","archive_url":"https://api.github.com/repos/monero-project/bitmonero/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/monero-project/bitmonero/downloads","issues_url":"https://api.github.com/repos/monero-project/bitmonero/issues{/number}","pulls_url":"https://api.github.com/repos/monero-project/bitmonero/pulls{/number}","milestones_url":"https://api.github.com/repos/monero-project/bitmonero/milestones{/number}","notifications_url":"https://api.github.com/repos/monero-project/bitmonero/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/monero-project/bitmonero/labels{/name}","releases_url":"https://api.github.com/repos/monero-project/bitmonero/releases{/id}","created_at":"2014-04-30T14:38:28Z","updated_at":"2014-10-19T01:23:40Z","pushed_at":"2014-10-20T12:16:27Z","git_url":"git://github.com/monero-project/bitmonero.git","ssh_url":"git@github.com:monero-project/bitmonero.git","clone_url":"https://github.com/monero-project/bitmonero.git","svn_url":"https://github.com/monero-project/bitmonero","homepage":"monero.cc","size":15355,"stargazers_count":44,"watchers_count":44,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":58,"mirror_url":null,"open_issues_count":37,"forks":58,"open_issues":37,"watchers":44,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/monero-project/bitmonero/pulls/180"},"html":{"href":"https://github.com/monero-project/bitmonero/pull/180"},"issue":{"href":"https://api.github.com/repos/monero-project/bitmonero/issues/180"},"comments":{"href":"https://api.github.com/repos/monero-project/bitmonero/issues/180/comments"},"review_comments":{"href":"https://api.github.com/repos/monero-project/bitmonero/pulls/180/comments"},"review_comment":{"href":"https://api.github.com/repos/monero-project/bitmonero/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/monero-project/bitmonero/pulls/180/commits"},"statuses":{"href":"https://api.github.com/repos/monero-project/bitmonero/statuses/ba78c15fd2af1946ea5bca1b4bfe65614d345b12"}}}}