GitHub PullRequestReviewCommentEvent at 2014-10-19 14:32:19
Repository: Pokemon-Showdown
Actor: macrarazy
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/pulls/comments/19060512","id":19060512,"diff_hunk":"@@ -620,7 +620,10 @@ var commands = exports.commands = {\n \t\t\t\treturn connection.sendTo(target, \"|noinit|namerequired|You must have a name in order to join the room '\" + target + \"'.\");\n \t\t\t}\n \t\t}\n-\t\tif (!user.joinRoom(targetRoom || room, connection)) {\n+\t\tif (targetRoom.bannedUsers[user.userid]) {\n+\t\t\treturn connection.sendTo(target, \"|noinit|banned|You are banned from the room '\" + target + \"'.\");\n+\t\t}\n+\t\tif (!user.joinRoom(targetRoom || room, connection) && !targetRoom.bannedUsers[user.userid]) {","path":"commands.js","position":8,"original_position":8,"commit_id":"18fabf0f638b7a25ee0c165e0d1da752afd138a0","original_commit_id":"18fabf0f638b7a25ee0c165e0d1da752afd138a0","user":{"login":"macrarazy","id":4999269,"avatar_url":"https://avatars.githubusercontent.com/u/4999269?v=2","gravatar_id":"","url":"https://api.github.com/users/macrarazy","html_url":"https://github.com/macrarazy","followers_url":"https://api.github.com/users/macrarazy/followers","following_url":"https://api.github.com/users/macrarazy/following{/other_user}","gists_url":"https://api.github.com/users/macrarazy/gists{/gist_id}","starred_url":"https://api.github.com/users/macrarazy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/macrarazy/subscriptions","organizations_url":"https://api.github.com/users/macrarazy/orgs","repos_url":"https://api.github.com/users/macrarazy/repos","events_url":"https://api.github.com/users/macrarazy/events{/privacy}","received_events_url":"https://api.github.com/users/macrarazy/received_events","type":"User","site_admin":false},"body":"Are you implying I shouldn't even check for that case at all or check for something else?","created_at":"2014-10-19T14:32:19Z","updated_at":"2014-10-19T14:32:19Z","html_url":"https://github.com/Zarel/Pokemon-Showdown/pull/1267#discussion_r19060512","pull_request_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/pulls/1267","_links":{"self":{"href":"https://api.github.com/repos/Zarel/Pokemon-Showdown/pulls/comments/19060512"},"html":{"href":"https://github.com/Zarel/Pokemon-Showdown/pull/1267#discussion_r19060512"},"pull_request":{"href":"https://api.github.com/repos/Zarel/Pokemon-Showdown/pulls/1267"}}},"pull_request":{"url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/pulls/1267","id":22966346,"html_url":"https://github.com/Zarel/Pokemon-Showdown/pull/1267","diff_url":"https://github.com/Zarel/Pokemon-Showdown/pull/1267.diff","patch_url":"https://github.com/Zarel/Pokemon-Showdown/pull/1267.patch","issue_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/issues/1267","number":1267,"state":"open","locked":false,"title":"User-friendly failed /join message","user":{"login":"macrarazy","id":4999269,"avatar_url":"https://avatars.githubusercontent.com/u/4999269?v=2","gravatar_id":"","url":"https://api.github.com/users/macrarazy","html_url":"https://github.com/macrarazy","followers_url":"https://api.github.com/users/macrarazy/followers","following_url":"https://api.github.com/users/macrarazy/following{/other_user}","gists_url":"https://api.github.com/users/macrarazy/gists{/gist_id}","starred_url":"https://api.github.com/users/macrarazy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/macrarazy/subscriptions","organizations_url":"https://api.github.com/users/macrarazy/orgs","repos_url":"https://api.github.com/users/macrarazy/repos","events_url":"https://api.github.com/users/macrarazy/events{/privacy}","received_events_url":"https://api.github.com/users/macrarazy/received_events","type":"User","site_admin":false},"body":"The failed /join message does appear when you're banned so adding \"You could be banned from the room.\" makes sense as that's also mentioned in ``/redirect``.","created_at":"2014-10-18T10:20:32Z","updated_at":"2014-10-19T14:32:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0bb0360a49e8440cd59945befe66446e78fdcfc3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/pulls/1267/commits","review_comments_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/pulls/1267/comments","review_comment_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/issues/1267/comments","statuses_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/statuses/18fabf0f638b7a25ee0c165e0d1da752afd138a0","head":{"label":"macrarazy:patch-32","ref":"patch-32","sha":"18fabf0f638b7a25ee0c165e0d1da752afd138a0","user":{"login":"macrarazy","id":4999269,"avatar_url":"https://avatars.githubusercontent.com/u/4999269?v=2","gravatar_id":"","url":"https://api.github.com/users/macrarazy","html_url":"https://github.com/macrarazy","followers_url":"https://api.github.com/users/macrarazy/followers","following_url":"https://api.github.com/users/macrarazy/following{/other_user}","gists_url":"https://api.github.com/users/macrarazy/gists{/gist_id}","starred_url":"https://api.github.com/users/macrarazy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/macrarazy/subscriptions","organizations_url":"https://api.github.com/users/macrarazy/orgs","repos_url":"https://api.github.com/users/macrarazy/repos","events_url":"https://api.github.com/users/macrarazy/events{/privacy}","received_events_url":"https://api.github.com/users/macrarazy/received_events","type":"User","site_admin":false},"repo":{"id":22968131,"name":"Pokemon-Showdown","full_name":"macrarazy/Pokemon-Showdown","owner":{"login":"macrarazy","id":4999269,"avatar_url":"https://avatars.githubusercontent.com/u/4999269?v=2","gravatar_id":"","url":"https://api.github.com/users/macrarazy","html_url":"https://github.com/macrarazy","followers_url":"https://api.github.com/users/macrarazy/followers","following_url":"https://api.github.com/users/macrarazy/following{/other_user}","gists_url":"https://api.github.com/users/macrarazy/gists{/gist_id}","starred_url":"https://api.github.com/users/macrarazy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/macrarazy/subscriptions","organizations_url":"https://api.github.com/users/macrarazy/orgs","repos_url":"https://api.github.com/users/macrarazy/repos","events_url":"https://api.github.com/users/macrarazy/events{/privacy}","received_events_url":"https://api.github.com/users/macrarazy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/macrarazy/Pokemon-Showdown","description":"Pokémon battle simulator.","fork":true,"url":"https://api.github.com/repos/macrarazy/Pokemon-Showdown","forks_url":"https://api.github.com/repos/macrarazy/Pokemon-Showdown/forks","keys_url":"https://api.github.com/repos/macrarazy/Pokemon-Showdown/keys{/key_id}","collaborators_url":"https://api.github.com/repos/macrarazy/Pokemon-Showdown/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/macrarazy/Pokemon-Showdown/teams","hooks_url":"https://api.github.com/repos/macrarazy/Pokemon-Showdown/hooks","issue_events_url":"https://api.github.com/repos/macrarazy/Pokemon-Showdown/issues/events{/number}","events_url":"https://api.github.com/repos/macrarazy/Pokemon-Showdown/events","assignees_url":"https://api.github.com/repos/macrarazy/Pokemon-Showdown/assignees{/user}","branches_url":"https://api.github.com/repos/macrarazy/Pokemon-Showdown/branches{/branch}","tags_url":"https://api.github.com/repos/macrarazy/Pokemon-Showdown/tags","blobs_url":"https://api.github.com/repos/macrarazy/Pokemon-Showdown/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/macrarazy/Pokemon-Showdown/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/macrarazy/Pokemon-Showdown/git/refs{/sha}","trees_url":"https://api.github.com/repos/macrarazy/Pokemon-Showdown/git/trees{/sha}","statuses_url":"https://api.github.com/repos/macrarazy/Pokemon-Showdown/statuses/{sha}","languages_url":"https://api.github.com/repos/macrarazy/Pokemon-Showdown/languages","stargazers_url":"https://api.github.com/repos/macrarazy/Pokemon-Showdown/stargazers","contributors_url":"https://api.github.com/repos/macrarazy/Pokemon-Showdown/contributors","subscribers_url":"https://api.github.com/repos/macrarazy/Pokemon-Showdown/subscribers","subscription_url":"https://api.github.com/repos/macrarazy/Pokemon-Showdown/subscription","commits_url":"https://api.github.com/repos/macrarazy/Pokemon-Showdown/commits{/sha}","git_commits_url":"https://api.github.com/repos/macrarazy/Pokemon-Showdown/git/commits{/sha}","comments_url":"https://api.github.com/repos/macrarazy/Pokemon-Showdown/comments{/number}","issue_comment_url":"https://api.github.com/repos/macrarazy/Pokemon-Showdown/issues/comments/{number}","contents_url":"https://api.github.com/repos/macrarazy/Pokemon-Showdown/contents/{+path}","compare_url":"https://api.github.com/repos/macrarazy/Pokemon-Showdown/compare/{base}...{head}","merges_url":"https://api.github.com/repos/macrarazy/Pokemon-Showdown/merges","archive_url":"https://api.github.com/repos/macrarazy/Pokemon-Showdown/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/macrarazy/Pokemon-Showdown/downloads","issues_url":"https://api.github.com/repos/macrarazy/Pokemon-Showdown/issues{/number}","pulls_url":"https://api.github.com/repos/macrarazy/Pokemon-Showdown/pulls{/number}","milestones_url":"https://api.github.com/repos/macrarazy/Pokemon-Showdown/milestones{/number}","notifications_url":"https://api.github.com/repos/macrarazy/Pokemon-Showdown/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/macrarazy/Pokemon-Showdown/labels{/name}","releases_url":"https://api.github.com/repos/macrarazy/Pokemon-Showdown/releases{/id}","created_at":"2014-08-14T20:47:41Z","updated_at":"2014-08-21T10:09:31Z","pushed_at":"2014-10-19T07:19:01Z","git_url":"git://github.com/macrarazy/Pokemon-Showdown.git","ssh_url":"git@github.com:macrarazy/Pokemon-Showdown.git","clone_url":"https://github.com/macrarazy/Pokemon-Showdown.git","svn_url":"https://github.com/macrarazy/Pokemon-Showdown","homepage":"http://pokemonshowdown.com","size":28499,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Zarel:master","ref":"master","sha":"5b2df72f70e23bd85b5c575840c77b73dd0674ee","user":{"login":"Zarel","id":551184,"avatar_url":"https://avatars.githubusercontent.com/u/551184?v=2","gravatar_id":"","url":"https://api.github.com/users/Zarel","html_url":"https://github.com/Zarel","followers_url":"https://api.github.com/users/Zarel/followers","following_url":"https://api.github.com/users/Zarel/following{/other_user}","gists_url":"https://api.github.com/users/Zarel/gists{/gist_id}","starred_url":"https://api.github.com/users/Zarel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zarel/subscriptions","organizations_url":"https://api.github.com/users/Zarel/orgs","repos_url":"https://api.github.com/users/Zarel/repos","events_url":"https://api.github.com/users/Zarel/events{/privacy}","received_events_url":"https://api.github.com/users/Zarel/received_events","type":"User","site_admin":false},"repo":{"id":3038446,"name":"Pokemon-Showdown","full_name":"Zarel/Pokemon-Showdown","owner":{"login":"Zarel","id":551184,"avatar_url":"https://avatars.githubusercontent.com/u/551184?v=2","gravatar_id":"","url":"https://api.github.com/users/Zarel","html_url":"https://github.com/Zarel","followers_url":"https://api.github.com/users/Zarel/followers","following_url":"https://api.github.com/users/Zarel/following{/other_user}","gists_url":"https://api.github.com/users/Zarel/gists{/gist_id}","starred_url":"https://api.github.com/users/Zarel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zarel/subscriptions","organizations_url":"https://api.github.com/users/Zarel/orgs","repos_url":"https://api.github.com/users/Zarel/repos","events_url":"https://api.github.com/users/Zarel/events{/privacy}","received_events_url":"https://api.github.com/users/Zarel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Zarel/Pokemon-Showdown","description":"Pokémon battle simulator.","fork":false,"url":"https://api.github.com/repos/Zarel/Pokemon-Showdown","forks_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/forks","keys_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/teams","hooks_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/hooks","issue_events_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/issues/events{/number}","events_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/events","assignees_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/assignees{/user}","branches_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/branches{/branch}","tags_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/tags","blobs_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/git/refs{/sha}","trees_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/statuses/{sha}","languages_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/languages","stargazers_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/stargazers","contributors_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/contributors","subscribers_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/subscribers","subscription_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/subscription","commits_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/commits{/sha}","git_commits_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/git/commits{/sha}","comments_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/comments{/number}","issue_comment_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/issues/comments/{number}","contents_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/contents/{+path}","compare_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/merges","archive_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/downloads","issues_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/issues{/number}","pulls_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/pulls{/number}","milestones_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/milestones{/number}","notifications_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/labels{/name}","releases_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/releases{/id}","created_at":"2011-12-23T04:52:33Z","updated_at":"2014-10-19T08:00:02Z","pushed_at":"2014-10-19T13:06:32Z","git_url":"git://github.com/Zarel/Pokemon-Showdown.git","ssh_url":"git@github.com:Zarel/Pokemon-Showdown.git","clone_url":"https://github.com/Zarel/Pokemon-Showdown.git","svn_url":"https://github.com/Zarel/Pokemon-Showdown","homepage":"http://pokemonshowdown.com","size":55087,"stargazers_count":378,"watchers_count":378,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":503,"mirror_url":null,"open_issues_count":33,"forks":503,"open_issues":33,"watchers":378,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Zarel/Pokemon-Showdown/pulls/1267"},"html":{"href":"https://github.com/Zarel/Pokemon-Showdown/pull/1267"},"issue":{"href":"https://api.github.com/repos/Zarel/Pokemon-Showdown/issues/1267"},"comments":{"href":"https://api.github.com/repos/Zarel/Pokemon-Showdown/issues/1267/comments"},"review_comments":{"href":"https://api.github.com/repos/Zarel/Pokemon-Showdown/pulls/1267/comments"},"review_comment":{"href":"https://api.github.com/repos/Zarel/Pokemon-Showdown/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Zarel/Pokemon-Showdown/pulls/1267/commits"},"statuses":{"href":"https://api.github.com/repos/Zarel/Pokemon-Showdown/statuses/18fabf0f638b7a25ee0c165e0d1da752afd138a0"}}}}