GitHub PullRequestEvent at 2014-01-22 14:48:52
Repository: playtest
Actor: jburdeezy
Payload: {"action":"closed","number":18,"pull_request":{"url":"https://api.github.com/repos/jburdeezy/playtest/pulls/18","id":11657429,"html_url":"https://github.com/jburdeezy/playtest/pull/18","diff_url":"https://github.com/jburdeezy/playtest/pull/18.diff","patch_url":"https://github.com/jburdeezy/playtest/pull/18.patch","issue_url":"https://github.com/jburdeezy/playtest/pull/18","number":18,"state":"closed","title":"Command line options now added","user":{"login":"armahillo","id":502363,"avatar_url":"https://gravatar.com/avatar/52adc6862b6d7f0cd83a6cd10d89cd2d?d=https%3A%2F%2Fidenticons.github.com%2F7988e42681ea97acd621edd6e55ca2cb.png&r=x","gravatar_id":"52adc6862b6d7f0cd83a6cd10d89cd2d","url":"https://api.github.com/users/armahillo","html_url":"https://github.com/armahillo","followers_url":"https://api.github.com/users/armahillo/followers","following_url":"https://api.github.com/users/armahillo/following{/other_user}","gists_url":"https://api.github.com/users/armahillo/gists{/gist_id}","starred_url":"https://api.github.com/users/armahillo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/armahillo/subscriptions","organizations_url":"https://api.github.com/users/armahillo/orgs","repos_url":"https://api.github.com/users/armahillo/repos","events_url":"https://api.github.com/users/armahillo/events{/privacy}","received_events_url":"https://api.github.com/users/armahillo/received_events","type":"User","site_admin":false},"body":"Basic command line parsing available, using OptParser. (I tried using GLI but it seemed like overkill for this right now). CLI options are below. I also refactored the template class into two subclasses -- HtmlTemplate and PdfTemplate, encapsulating the filetype-specific functionality into each, and doing some faux-polymorphism with their \"render\" method. The \"html\" static file in the import/ folder is gone after I realized I wasn't using it in the Template class at all. That may be worth re-adding at a later date, idk. Console output is now conditional on a \"Verbose\" flag (see below). All specs have been updated and pass, with 2 pending for when I can figure out how to test Prawn.\r\n\r\n## CLI Options\r\n\r\n-v | --verbose : display console output while running\r\n\r\n-c CARDYAML | --cards CARDYAML : defaults to \"import/cards.yml\", the YAML file it will use for reference\r\n\r\n-o OUTPUT | --output OUTPUT : the file to export to. Defaults to \"export/rendered_XXXXXX.ext\" where XXXX is the microtime and ext is the output extension (defaults to PDF)\r\n\r\n-s CSSFILE | --stylesheet CSSFILE : The css file to use when doing HTML output, optional. Defaults to \"import/default.css\"\r\n\r\n## CLI Examples\r\nSuper basic: ./playtest.rb\r\nSuper basic, verbose: ./playtest.rb -v\r\nCustom YAML input: ./playtest.rb -c \"import/cards.yml\"\r\nHTML output: ./playtest.rb -o \"export/foo.html\"\r\nSuper tweaked: ./playtest.rb -v -c \"/path/to/my/cards.yml\" -o \"/path/to/my/export/new_cards.pdf\"\r\n\r\n","created_at":"2014-01-19T17:10:27Z","updated_at":"2014-01-22T14:48:52Z","closed_at":"2014-01-22T14:48:52Z","merged_at":"2014-01-22T14:48:52Z","merge_commit_sha":"83d24adb974515e3ad2b48703286a97bab06d786","assignee":null,"milestone":null,"commits_url":"https://github.com/jburdeezy/playtest/pull/18/commits","review_comments_url":"https://github.com/jburdeezy/playtest/pull/18/comments","review_comment_url":"/repos/jburdeezy/playtest/pulls/comments/{number}","comments_url":"https://api.github.com/repos/jburdeezy/playtest/issues/18/comments","statuses_url":"https://api.github.com/repos/jburdeezy/playtest/statuses/b81dd875d5d90a135bff5e22913658a05f071067","head":{"label":"armahillo:master","ref":"master","sha":"b81dd875d5d90a135bff5e22913658a05f071067","user":{"login":"armahillo","id":502363,"avatar_url":"https://gravatar.com/avatar/52adc6862b6d7f0cd83a6cd10d89cd2d?d=https%3A%2F%2Fidenticons.github.com%2F7988e42681ea97acd621edd6e55ca2cb.png&r=x","gravatar_id":"52adc6862b6d7f0cd83a6cd10d89cd2d","url":"https://api.github.com/users/armahillo","html_url":"https://github.com/armahillo","followers_url":"https://api.github.com/users/armahillo/followers","following_url":"https://api.github.com/users/armahillo/following{/other_user}","gists_url":"https://api.github.com/users/armahillo/gists{/gist_id}","starred_url":"https://api.github.com/users/armahillo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/armahillo/subscriptions","organizations_url":"https://api.github.com/users/armahillo/orgs","repos_url":"https://api.github.com/users/armahillo/repos","events_url":"https://api.github.com/users/armahillo/events{/privacy}","received_events_url":"https://api.github.com/users/armahillo/received_events","type":"User","site_admin":false},"repo":{"id":14626625,"name":"playtest","full_name":"armahillo/playtest","owner":{"login":"armahillo","id":502363,"avatar_url":"https://gravatar.com/avatar/52adc6862b6d7f0cd83a6cd10d89cd2d?d=https%3A%2F%2Fidenticons.github.com%2F7988e42681ea97acd621edd6e55ca2cb.png&r=x","gravatar_id":"52adc6862b6d7f0cd83a6cd10d89cd2d","url":"https://api.github.com/users/armahillo","html_url":"https://github.com/armahillo","followers_url":"https://api.github.com/users/armahillo/followers","following_url":"https://api.github.com/users/armahillo/following{/other_user}","gists_url":"https://api.github.com/users/armahillo/gists{/gist_id}","starred_url":"https://api.github.com/users/armahillo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/armahillo/subscriptions","organizations_url":"https://api.github.com/users/armahillo/orgs","repos_url":"https://api.github.com/users/armahillo/repos","events_url":"https://api.github.com/users/armahillo/events{/privacy}","received_events_url":"https://api.github.com/users/armahillo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/armahillo/playtest","description":"A simple ruby script system that lets you quickly prototype physical card games","fork":true,"url":"https://api.github.com/repos/armahillo/playtest","forks_url":"https://api.github.com/repos/armahillo/playtest/forks","keys_url":"https://api.github.com/repos/armahillo/playtest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/armahillo/playtest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/armahillo/playtest/teams","hooks_url":"https://api.github.com/repos/armahillo/playtest/hooks","issue_events_url":"https://api.github.com/repos/armahillo/playtest/issues/events{/number}","events_url":"https://api.github.com/repos/armahillo/playtest/events","assignees_url":"https://api.github.com/repos/armahillo/playtest/assignees{/user}","branches_url":"https://api.github.com/repos/armahillo/playtest/branches{/branch}","tags_url":"https://api.github.com/repos/armahillo/playtest/tags","blobs_url":"https://api.github.com/repos/armahillo/playtest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/armahillo/playtest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/armahillo/playtest/git/refs{/sha}","trees_url":"https://api.github.com/repos/armahillo/playtest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/armahillo/playtest/statuses/{sha}","languages_url":"https://api.github.com/repos/armahillo/playtest/languages","stargazers_url":"https://api.github.com/repos/armahillo/playtest/stargazers","contributors_url":"https://api.github.com/repos/armahillo/playtest/contributors","subscribers_url":"https://api.github.com/repos/armahillo/playtest/subscribers","subscription_url":"https://api.github.com/repos/armahillo/playtest/subscription","commits_url":"https://api.github.com/repos/armahillo/playtest/commits{/sha}","git_commits_url":"https://api.github.com/repos/armahillo/playtest/git/commits{/sha}","comments_url":"https://api.github.com/repos/armahillo/playtest/comments{/number}","issue_comment_url":"https://api.github.com/repos/armahillo/playtest/issues/comments/{number}","contents_url":"https://api.github.com/repos/armahillo/playtest/contents/{+path}","compare_url":"https://api.github.com/repos/armahillo/playtest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/armahillo/playtest/merges","archive_url":"https://api.github.com/repos/armahillo/playtest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/armahillo/playtest/downloads","issues_url":"https://api.github.com/repos/armahillo/playtest/issues{/number}","pulls_url":"https://api.github.com/repos/armahillo/playtest/pulls{/number}","milestones_url":"https://api.github.com/repos/armahillo/playtest/milestones{/number}","notifications_url":"https://api.github.com/repos/armahillo/playtest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/armahillo/playtest/labels{/name}","releases_url":"https://api.github.com/repos/armahillo/playtest/releases{/id}","created_at":"2013-11-22T18:58:23Z","updated_at":"2014-01-22T14:48:52Z","pushed_at":"2014-01-19T16:59:04Z","git_url":"git://github.com/armahillo/playtest.git","ssh_url":"git@github.com:armahillo/playtest.git","clone_url":"https://github.com/armahillo/playtest.git","svn_url":"https://github.com/armahillo/playtest","homepage":null,"size":565,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master","master_branch":"master"}},"base":{"label":"jburdeezy:master","ref":"master","sha":"1d3e4489afa509fb02fc915edbc06d19777dba79","user":{"login":"jburdeezy","id":227566,"avatar_url":"https://gravatar.com/avatar/30e69155ce74b5e8f70cc37dd9b8d9cc?d=https%3A%2F%2Fidenticons.github.com%2F7ab92e5db86a733dd245fd7f58704a52.png&r=x","gravatar_id":"30e69155ce74b5e8f70cc37dd9b8d9cc","url":"https://api.github.com/users/jburdeezy","html_url":"https://github.com/jburdeezy","followers_url":"https://api.github.com/users/jburdeezy/followers","following_url":"https://api.github.com/users/jburdeezy/following{/other_user}","gists_url":"https://api.github.com/users/jburdeezy/gists{/gist_id}","starred_url":"https://api.github.com/users/jburdeezy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jburdeezy/subscriptions","organizations_url":"https://api.github.com/users/jburdeezy/orgs","repos_url":"https://api.github.com/users/jburdeezy/repos","events_url":"https://api.github.com/users/jburdeezy/events{/privacy}","received_events_url":"https://api.github.com/users/jburdeezy/received_events","type":"User","site_admin":false},"repo":{"id":14548873,"name":"playtest","full_name":"jburdeezy/playtest","owner":{"login":"jburdeezy","id":227566,"avatar_url":"https://gravatar.com/avatar/30e69155ce74b5e8f70cc37dd9b8d9cc?d=https%3A%2F%2Fidenticons.github.com%2F7ab92e5db86a733dd245fd7f58704a52.png&r=x","gravatar_id":"30e69155ce74b5e8f70cc37dd9b8d9cc","url":"https://api.github.com/users/jburdeezy","html_url":"https://github.com/jburdeezy","followers_url":"https://api.github.com/users/jburdeezy/followers","following_url":"https://api.github.com/users/jburdeezy/following{/other_user}","gists_url":"https://api.github.com/users/jburdeezy/gists{/gist_id}","starred_url":"https://api.github.com/users/jburdeezy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jburdeezy/subscriptions","organizations_url":"https://api.github.com/users/jburdeezy/orgs","repos_url":"https://api.github.com/users/jburdeezy/repos","events_url":"https://api.github.com/users/jburdeezy/events{/privacy}","received_events_url":"https://api.github.com/users/jburdeezy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jburdeezy/playtest","description":"A simple ruby script system that lets you quickly prototype physical card games","fork":false,"url":"https://api.github.com/repos/jburdeezy/playtest","forks_url":"https://api.github.com/repos/jburdeezy/playtest/forks","keys_url":"https://api.github.com/repos/jburdeezy/playtest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jburdeezy/playtest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jburdeezy/playtest/teams","hooks_url":"https://api.github.com/repos/jburdeezy/playtest/hooks","issue_events_url":"https://api.github.com/repos/jburdeezy/playtest/issues/events{/number}","events_url":"https://api.github.com/repos/jburdeezy/playtest/events","assignees_url":"https://api.github.com/repos/jburdeezy/playtest/assignees{/user}","branches_url":"https://api.github.com/repos/jburdeezy/playtest/branches{/branch}","tags_url":"https://api.github.com/repos/jburdeezy/playtest/tags","blobs_url":"https://api.github.com/repos/jburdeezy/playtest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jburdeezy/playtest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jburdeezy/playtest/git/refs{/sha}","trees_url":"https://api.github.com/repos/jburdeezy/playtest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jburdeezy/playtest/statuses/{sha}","languages_url":"https://api.github.com/repos/jburdeezy/playtest/languages","stargazers_url":"https://api.github.com/repos/jburdeezy/playtest/stargazers","contributors_url":"https://api.github.com/repos/jburdeezy/playtest/contributors","subscribers_url":"https://api.github.com/repos/jburdeezy/playtest/subscribers","subscription_url":"https://api.github.com/repos/jburdeezy/playtest/subscription","commits_url":"https://api.github.com/repos/jburdeezy/playtest/commits{/sha}","git_commits_url":"https://api.github.com/repos/jburdeezy/playtest/git/commits{/sha}","comments_url":"https://api.github.com/repos/jburdeezy/playtest/comments{/number}","issue_comment_url":"https://api.github.com/repos/jburdeezy/playtest/issues/comments/{number}","contents_url":"https://api.github.com/repos/jburdeezy/playtest/contents/{+path}","compare_url":"https://api.github.com/repos/jburdeezy/playtest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jburdeezy/playtest/merges","archive_url":"https://api.github.com/repos/jburdeezy/playtest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jburdeezy/playtest/downloads","issues_url":"https://api.github.com/repos/jburdeezy/playtest/issues{/number}","pulls_url":"https://api.github.com/repos/jburdeezy/playtest/pulls{/number}","milestones_url":"https://api.github.com/repos/jburdeezy/playtest/milestones{/number}","notifications_url":"https://api.github.com/repos/jburdeezy/playtest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jburdeezy/playtest/labels{/name}","releases_url":"https://api.github.com/repos/jburdeezy/playtest/releases{/id}","created_at":"2013-11-20T06:43:06Z","updated_at":"2013-12-03T14:00:16Z","pushed_at":"2014-01-22T14:48:51Z","git_url":"git://github.com/jburdeezy/playtest.git","ssh_url":"git@github.com:jburdeezy/playtest.git","clone_url":"https://github.com/jburdeezy/playtest.git","svn_url":"https://github.com/jburdeezy/playtest","homepage":null,"size":1378,"stargazers_count":8,"watchers_count":8,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":2,"mirror_url":null,"open_issues_count":5,"forks":2,"open_issues":5,"watchers":8,"default_branch":"master","master_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jburdeezy/playtest/pulls/18"},"html":{"href":"https://github.com/jburdeezy/playtest/pull/18"},"issue":{"href":"https://api.github.com/repos/jburdeezy/playtest/issues/18"},"comments":{"href":"https://api.github.com/repos/jburdeezy/playtest/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/jburdeezy/playtest/pulls/18/comments"},"statuses":{"href":"https://api.github.com/repos/jburdeezy/playtest/statuses/b81dd875d5d90a135bff5e22913658a05f071067"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jburdeezy","id":227566,"avatar_url":"https://gravatar.com/avatar/30e69155ce74b5e8f70cc37dd9b8d9cc?d=https%3A%2F%2Fidenticons.github.com%2F7ab92e5db86a733dd245fd7f58704a52.png&r=x","gravatar_id":"30e69155ce74b5e8f70cc37dd9b8d9cc","url":"https://api.github.com/users/jburdeezy","html_url":"https://github.com/jburdeezy","followers_url":"https://api.github.com/users/jburdeezy/followers","following_url":"https://api.github.com/users/jburdeezy/following{/other_user}","gists_url":"https://api.github.com/users/jburdeezy/gists{/gist_id}","starred_url":"https://api.github.com/users/jburdeezy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jburdeezy/subscriptions","organizations_url":"https://api.github.com/users/jburdeezy/orgs","repos_url":"https://api.github.com/users/jburdeezy/repos","events_url":"https://api.github.com/users/jburdeezy/events{/privacy}","received_events_url":"https://api.github.com/users/jburdeezy/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":3,"additions":259,"deletions":154,"changed_files":18}}