GitHub PullRequestReviewCommentEvent at 2014-10-07 13:25:59
Repository: hibernate-search
Actor: hferentschik
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/hibernate/hibernate-search/pulls/comments/18518459","id":18518459,"diff_hunk":"@@ -243,98 +241,92 @@ benefit in sharing indexes.\n [[section-services]]\n === Using external services\n \n-Any of the pluggable contracts we have seen so far allows for the injection of a service. The most\n-notable example being the DirectoryProvider. The full list is:\n+You will only need this section if you are extending Hibernate Search to replace some of its\n+core components with custom implementations, for example to use your custom `DirectoryProvider`,\n+and you need your custom implementation to access some other component.\n+For example a `DirectoryProvider` - like many other internal components - is started by invoking\n+its no-arguments constructor, and then often some initialization method is invoked,\n+giving access to a `BuildContext` which can be used to access Services.\n+This way your custom implementations can access any services normally included, or you can","path":"documentation/src/main/asciidoc/ch10.asciidoc","position":61,"original_position":61,"commit_id":"4d328dc92039a63b358d9e8531111a470c390af8","original_commit_id":"4d328dc92039a63b358d9e8531111a470c390af8","user":{"login":"hferentschik","id":296354,"avatar_url":"https://avatars.githubusercontent.com/u/296354?v=2","gravatar_id":"","url":"https://api.github.com/users/hferentschik","html_url":"https://github.com/hferentschik","followers_url":"https://api.github.com/users/hferentschik/followers","following_url":"https://api.github.com/users/hferentschik/following{/other_user}","gists_url":"https://api.github.com/users/hferentschik/gists{/gist_id}","starred_url":"https://api.github.com/users/hferentschik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hferentschik/subscriptions","organizations_url":"https://api.github.com/users/hferentschik/orgs","repos_url":"https://api.github.com/users/hferentschik/repos","events_url":"https://api.github.com/users/hferentschik/events{/privacy}","received_events_url":"https://api.github.com/users/hferentschik/received_events","type":"User","site_admin":false},"body":"normally == available per default","created_at":"2014-10-07T13:25:59Z","updated_at":"2014-10-07T13:25:59Z","html_url":"https://github.com/hibernate/hibernate-search/pull/670#discussion_r18518459","pull_request_url":"https://api.github.com/repos/hibernate/hibernate-search/pulls/670","_links":{"self":{"href":"https://api.github.com/repos/hibernate/hibernate-search/pulls/comments/18518459"},"html":{"href":"https://github.com/hibernate/hibernate-search/pull/670#discussion_r18518459"},"pull_request":{"href":"https://api.github.com/repos/hibernate/hibernate-search/pulls/670"}}},"pull_request":{"url":"https://api.github.com/repos/hibernate/hibernate-search/pulls/670","id":22347809,"html_url":"https://github.com/hibernate/hibernate-search/pull/670","diff_url":"https://github.com/hibernate/hibernate-search/pull/670.diff","patch_url":"https://github.com/hibernate/hibernate-search/pull/670.patch","issue_url":"https://api.github.com/repos/hibernate/hibernate-search/issues/670","number":670,"state":"open","locked":false,"title":"Rewrite documentation around Services","user":{"login":"Sanne","id":42573,"avatar_url":"https://avatars.githubusercontent.com/u/42573?v=2","gravatar_id":"","url":"https://api.github.com/users/Sanne","html_url":"https://github.com/Sanne","followers_url":"https://api.github.com/users/Sanne/followers","following_url":"https://api.github.com/users/Sanne/following{/other_user}","gists_url":"https://api.github.com/users/Sanne/gists{/gist_id}","starred_url":"https://api.github.com/users/Sanne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sanne/subscriptions","organizations_url":"https://api.github.com/users/Sanne/orgs","repos_url":"https://api.github.com/users/Sanne/repos","events_url":"https://api.github.com/users/Sanne/events{/privacy}","received_events_url":"https://api.github.com/users/Sanne/received_events","type":"User","site_admin":false},"body":"\r\n - https://hibernate.atlassian.net/browse/HSEARCH-1595","created_at":"2014-10-07T12:08:57Z","updated_at":"2014-10-07T13:25:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"188acf58940df3ad731d2142507d4c15557a5c62","assignee":{"login":"hferentschik","id":296354,"avatar_url":"https://avatars.githubusercontent.com/u/296354?v=2","gravatar_id":"","url":"https://api.github.com/users/hferentschik","html_url":"https://github.com/hferentschik","followers_url":"https://api.github.com/users/hferentschik/followers","following_url":"https://api.github.com/users/hferentschik/following{/other_user}","gists_url":"https://api.github.com/users/hferentschik/gists{/gist_id}","starred_url":"https://api.github.com/users/hferentschik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hferentschik/subscriptions","organizations_url":"https://api.github.com/users/hferentschik/orgs","repos_url":"https://api.github.com/users/hferentschik/repos","events_url":"https://api.github.com/users/hferentschik/events{/privacy}","received_events_url":"https://api.github.com/users/hferentschik/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/hibernate/hibernate-search/pulls/670/commits","review_comments_url":"https://api.github.com/repos/hibernate/hibernate-search/pulls/670/comments","review_comment_url":"https://api.github.com/repos/hibernate/hibernate-search/pulls/comments/{number}","comments_url":"https://api.github.com/repos/hibernate/hibernate-search/issues/670/comments","statuses_url":"https://api.github.com/repos/hibernate/hibernate-search/statuses/4d328dc92039a63b358d9e8531111a470c390af8","head":{"label":"Sanne:HSEARCH-1595","ref":"HSEARCH-1595","sha":"4d328dc92039a63b358d9e8531111a470c390af8","user":{"login":"Sanne","id":42573,"avatar_url":"https://avatars.githubusercontent.com/u/42573?v=2","gravatar_id":"","url":"https://api.github.com/users/Sanne","html_url":"https://github.com/Sanne","followers_url":"https://api.github.com/users/Sanne/followers","following_url":"https://api.github.com/users/Sanne/following{/other_user}","gists_url":"https://api.github.com/users/Sanne/gists{/gist_id}","starred_url":"https://api.github.com/users/Sanne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sanne/subscriptions","organizations_url":"https://api.github.com/users/Sanne/orgs","repos_url":"https://api.github.com/users/Sanne/repos","events_url":"https://api.github.com/users/Sanne/events{/privacy}","received_events_url":"https://api.github.com/users/Sanne/received_events","type":"User","site_admin":false},"repo":{"id":1026619,"name":"hibernate-search","full_name":"Sanne/hibernate-search","owner":{"login":"Sanne","id":42573,"avatar_url":"https://avatars.githubusercontent.com/u/42573?v=2","gravatar_id":"","url":"https://api.github.com/users/Sanne","html_url":"https://github.com/Sanne","followers_url":"https://api.github.com/users/Sanne/followers","following_url":"https://api.github.com/users/Sanne/following{/other_user}","gists_url":"https://api.github.com/users/Sanne/gists{/gist_id}","starred_url":"https://api.github.com/users/Sanne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sanne/subscriptions","organizations_url":"https://api.github.com/users/Sanne/orgs","repos_url":"https://api.github.com/users/Sanne/repos","events_url":"https://api.github.com/users/Sanne/events{/privacy}","received_events_url":"https://api.github.com/users/Sanne/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Sanne/hibernate-search","description":"Hibernate Search: full-text search for domain model","fork":true,"url":"https://api.github.com/repos/Sanne/hibernate-search","forks_url":"https://api.github.com/repos/Sanne/hibernate-search/forks","keys_url":"https://api.github.com/repos/Sanne/hibernate-search/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Sanne/hibernate-search/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Sanne/hibernate-search/teams","hooks_url":"https://api.github.com/repos/Sanne/hibernate-search/hooks","issue_events_url":"https://api.github.com/repos/Sanne/hibernate-search/issues/events{/number}","events_url":"https://api.github.com/repos/Sanne/hibernate-search/events","assignees_url":"https://api.github.com/repos/Sanne/hibernate-search/assignees{/user}","branches_url":"https://api.github.com/repos/Sanne/hibernate-search/branches{/branch}","tags_url":"https://api.github.com/repos/Sanne/hibernate-search/tags","blobs_url":"https://api.github.com/repos/Sanne/hibernate-search/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Sanne/hibernate-search/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Sanne/hibernate-search/git/refs{/sha}","trees_url":"https://api.github.com/repos/Sanne/hibernate-search/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Sanne/hibernate-search/statuses/{sha}","languages_url":"https://api.github.com/repos/Sanne/hibernate-search/languages","stargazers_url":"https://api.github.com/repos/Sanne/hibernate-search/stargazers","contributors_url":"https://api.github.com/repos/Sanne/hibernate-search/contributors","subscribers_url":"https://api.github.com/repos/Sanne/hibernate-search/subscribers","subscription_url":"https://api.github.com/repos/Sanne/hibernate-search/subscription","commits_url":"https://api.github.com/repos/Sanne/hibernate-search/commits{/sha}","git_commits_url":"https://api.github.com/repos/Sanne/hibernate-search/git/commits{/sha}","comments_url":"https://api.github.com/repos/Sanne/hibernate-search/comments{/number}","issue_comment_url":"https://api.github.com/repos/Sanne/hibernate-search/issues/comments/{number}","contents_url":"https://api.github.com/repos/Sanne/hibernate-search/contents/{+path}","compare_url":"https://api.github.com/repos/Sanne/hibernate-search/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Sanne/hibernate-search/merges","archive_url":"https://api.github.com/repos/Sanne/hibernate-search/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Sanne/hibernate-search/downloads","issues_url":"https://api.github.com/repos/Sanne/hibernate-search/issues{/number}","pulls_url":"https://api.github.com/repos/Sanne/hibernate-search/pulls{/number}","milestones_url":"https://api.github.com/repos/Sanne/hibernate-search/milestones{/number}","notifications_url":"https://api.github.com/repos/Sanne/hibernate-search/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Sanne/hibernate-search/labels{/name}","releases_url":"https://api.github.com/repos/Sanne/hibernate-search/releases{/id}","created_at":"2010-10-26T20:06:17Z","updated_at":"2014-09-01T08:05:59Z","pushed_at":"2014-10-07T13:08:37Z","git_url":"git://github.com/Sanne/hibernate-search.git","ssh_url":"git@github.com:Sanne/hibernate-search.git","clone_url":"https://github.com/Sanne/hibernate-search.git","svn_url":"https://github.com/Sanne/hibernate-search","homepage":"http://search.hibernate.org","size":45461,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"hibernate:master","ref":"master","sha":"991aeee6f8b2f6830091e4327f62658596eb5e70","user":{"login":"hibernate","id":348262,"avatar_url":"https://avatars.githubusercontent.com/u/348262?v=2","gravatar_id":"","url":"https://api.github.com/users/hibernate","html_url":"https://github.com/hibernate","followers_url":"https://api.github.com/users/hibernate/followers","following_url":"https://api.github.com/users/hibernate/following{/other_user}","gists_url":"https://api.github.com/users/hibernate/gists{/gist_id}","starred_url":"https://api.github.com/users/hibernate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hibernate/subscriptions","organizations_url":"https://api.github.com/users/hibernate/orgs","repos_url":"https://api.github.com/users/hibernate/repos","events_url":"https://api.github.com/users/hibernate/events{/privacy}","received_events_url":"https://api.github.com/users/hibernate/received_events","type":"Organization","site_admin":false},"repo":{"id":990281,"name":"hibernate-search","full_name":"hibernate/hibernate-search","owner":{"login":"hibernate","id":348262,"avatar_url":"https://avatars.githubusercontent.com/u/348262?v=2","gravatar_id":"","url":"https://api.github.com/users/hibernate","html_url":"https://github.com/hibernate","followers_url":"https://api.github.com/users/hibernate/followers","following_url":"https://api.github.com/users/hibernate/following{/other_user}","gists_url":"https://api.github.com/users/hibernate/gists{/gist_id}","starred_url":"https://api.github.com/users/hibernate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hibernate/subscriptions","organizations_url":"https://api.github.com/users/hibernate/orgs","repos_url":"https://api.github.com/users/hibernate/repos","events_url":"https://api.github.com/users/hibernate/events{/privacy}","received_events_url":"https://api.github.com/users/hibernate/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hibernate/hibernate-search","description":"Hibernate Search: full-text search for domain model","fork":false,"url":"https://api.github.com/repos/hibernate/hibernate-search","forks_url":"https://api.github.com/repos/hibernate/hibernate-search/forks","keys_url":"https://api.github.com/repos/hibernate/hibernate-search/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hibernate/hibernate-search/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hibernate/hibernate-search/teams","hooks_url":"https://api.github.com/repos/hibernate/hibernate-search/hooks","issue_events_url":"https://api.github.com/repos/hibernate/hibernate-search/issues/events{/number}","events_url":"https://api.github.com/repos/hibernate/hibernate-search/events","assignees_url":"https://api.github.com/repos/hibernate/hibernate-search/assignees{/user}","branches_url":"https://api.github.com/repos/hibernate/hibernate-search/branches{/branch}","tags_url":"https://api.github.com/repos/hibernate/hibernate-search/tags","blobs_url":"https://api.github.com/repos/hibernate/hibernate-search/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hibernate/hibernate-search/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hibernate/hibernate-search/git/refs{/sha}","trees_url":"https://api.github.com/repos/hibernate/hibernate-search/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hibernate/hibernate-search/statuses/{sha}","languages_url":"https://api.github.com/repos/hibernate/hibernate-search/languages","stargazers_url":"https://api.github.com/repos/hibernate/hibernate-search/stargazers","contributors_url":"https://api.github.com/repos/hibernate/hibernate-search/contributors","subscribers_url":"https://api.github.com/repos/hibernate/hibernate-search/subscribers","subscription_url":"https://api.github.com/repos/hibernate/hibernate-search/subscription","commits_url":"https://api.github.com/repos/hibernate/hibernate-search/commits{/sha}","git_commits_url":"https://api.github.com/repos/hibernate/hibernate-search/git/commits{/sha}","comments_url":"https://api.github.com/repos/hibernate/hibernate-search/comments{/number}","issue_comment_url":"https://api.github.com/repos/hibernate/hibernate-search/issues/comments/{number}","contents_url":"https://api.github.com/repos/hibernate/hibernate-search/contents/{+path}","compare_url":"https://api.github.com/repos/hibernate/hibernate-search/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hibernate/hibernate-search/merges","archive_url":"https://api.github.com/repos/hibernate/hibernate-search/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hibernate/hibernate-search/downloads","issues_url":"https://api.github.com/repos/hibernate/hibernate-search/issues{/number}","pulls_url":"https://api.github.com/repos/hibernate/hibernate-search/pulls{/number}","milestones_url":"https://api.github.com/repos/hibernate/hibernate-search/milestones{/number}","notifications_url":"https://api.github.com/repos/hibernate/hibernate-search/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hibernate/hibernate-search/labels{/name}","releases_url":"https://api.github.com/repos/hibernate/hibernate-search/releases{/id}","created_at":"2010-10-15T15:55:09Z","updated_at":"2014-09-25T13:46:34Z","pushed_at":"2014-09-30T09:56:20Z","git_url":"git://github.com/hibernate/hibernate-search.git","ssh_url":"git@github.com:hibernate/hibernate-search.git","clone_url":"https://github.com/hibernate/hibernate-search.git","svn_url":"https://github.com/hibernate/hibernate-search","homepage":"http://search.hibernate.org","size":60884,"stargazers_count":129,"watchers_count":129,"language":"Java","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":90,"mirror_url":null,"open_issues_count":1,"forks":90,"open_issues":1,"watchers":129,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hibernate/hibernate-search/pulls/670"},"html":{"href":"https://github.com/hibernate/hibernate-search/pull/670"},"issue":{"href":"https://api.github.com/repos/hibernate/hibernate-search/issues/670"},"comments":{"href":"https://api.github.com/repos/hibernate/hibernate-search/issues/670/comments"},"review_comments":{"href":"https://api.github.com/repos/hibernate/hibernate-search/pulls/670/comments"},"review_comment":{"href":"https://api.github.com/repos/hibernate/hibernate-search/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/hibernate/hibernate-search/pulls/670/commits"},"statuses":{"href":"https://api.github.com/repos/hibernate/hibernate-search/statuses/4d328dc92039a63b358d9e8531111a470c390af8"}}}}