GitHub PullRequestReviewCommentEvent at 2014-08-05 18:38:03
Repository: libgit2
Actor: jacquesg
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/libgit2/libgit2/pulls/comments/15832602","id":15832602,"diff_hunk":"@@ -353,6 +353,10 @@ IF (THREADSAFE)\n \tENDIF()\n \n \tADD_DEFINITIONS(-DGIT_THREADS)\n+ELSE()\n+\tIF (NOT WIN32 OR MINGW)\n+\t\tADD_C_FLAG_IF_SUPPORTED(-Wno-unused-value)\n+\tENDIF()","path":"CMakeLists.txt","position":7,"original_position":7,"commit_id":"caeb9667caf43c6f637ee09beeb61260493826a5","original_commit_id":"caeb9667caf43c6f637ee09beeb61260493826a5","user":{"login":"jacquesg","id":3534453,"avatar_url":"https://avatars.githubusercontent.com/u/3534453?v=2","gravatar_id":"019f39a605e3dfe373cf243877be7fad","url":"https://api.github.com/users/jacquesg","html_url":"https://github.com/jacquesg","followers_url":"https://api.github.com/users/jacquesg/followers","following_url":"https://api.github.com/users/jacquesg/following{/other_user}","gists_url":"https://api.github.com/users/jacquesg/gists{/gist_id}","starred_url":"https://api.github.com/users/jacquesg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacquesg/subscriptions","organizations_url":"https://api.github.com/users/jacquesg/orgs","repos_url":"https://api.github.com/users/jacquesg/repos","events_url":"https://api.github.com/users/jacquesg/events{/privacy}","received_events_url":"https://api.github.com/users/jacquesg/received_events","type":"User","site_admin":false},"body":"Ok, I'll undo this one.","created_at":"2014-08-05T18:38:03Z","updated_at":"2014-08-05T18:38:03Z","html_url":"https://github.com/libgit2/libgit2/pull/2471#discussion_r15832602","pull_request_url":"https://api.github.com/repos/libgit2/libgit2/pulls/2471","_links":{"self":{"href":"https://api.github.com/repos/libgit2/libgit2/pulls/comments/15832602"},"html":{"href":"https://github.com/libgit2/libgit2/pull/2471#discussion_r15832602"},"pull_request":{"href":"https://api.github.com/repos/libgit2/libgit2/pulls/2471"}}},"pull_request":{"url":"https://api.github.com/repos/libgit2/libgit2/pulls/2471","id":18324385,"html_url":"https://github.com/libgit2/libgit2/pull/2471","diff_url":"https://github.com/libgit2/libgit2/pull/2471.diff","patch_url":"https://github.com/libgit2/libgit2/pull/2471.patch","issue_url":"https://api.github.com/repos/libgit2/libgit2/issues/2471","number":2471,"state":"open","title":"Compatibility/Portability cleanup","user":{"login":"jacquesg","id":3534453,"avatar_url":"https://avatars.githubusercontent.com/u/3534453?v=2","gravatar_id":"019f39a605e3dfe373cf243877be7fad","url":"https://api.github.com/users/jacquesg","html_url":"https://github.com/jacquesg","followers_url":"https://api.github.com/users/jacquesg/followers","following_url":"https://api.github.com/users/jacquesg/following{/other_user}","gists_url":"https://api.github.com/users/jacquesg/gists{/gist_id}","starred_url":"https://api.github.com/users/jacquesg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacquesg/subscriptions","organizations_url":"https://api.github.com/users/jacquesg/orgs","repos_url":"https://api.github.com/users/jacquesg/repos","events_url":"https://api.github.com/users/jacquesg/events{/privacy}","received_events_url":"https://api.github.com/users/jacquesg/received_events","type":"User","site_admin":false},"body":"This PR cleans up the portability/compatibility layer and fixes a few benign warnings I've picked up while doing this:\r\n\r\n* Fixed the include guard of ```unix/posix.h```\r\n* Replaced all remaning ```snprintf``` with ```p_snprintf```. We had duplicate mappings of ```_snprintf_s``` to ```snprintf```\r\n* Added ```p_``` prefix to ```strcasecmp``` and ```strncasecmp```. They're POSIX after all.\r\n* The remaining little bit of ```define```'s in the mingw compatibility file had is actually general enough (not mingw specific) that it was moved directly into the top-level ```posix.h``` file.\r\n\r\nI've tested the changes on mingw, MSVC (2008 + 2003 Platform SDK) and clang on OS X.\r\n","created_at":"2014-07-13T15:46:04Z","updated_at":"2014-08-05T18:38:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"089b7d38c788e4172b135dfef9faede0af70ab5b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/libgit2/libgit2/pulls/2471/commits","review_comments_url":"https://api.github.com/repos/libgit2/libgit2/pulls/2471/comments","review_comment_url":"https://api.github.com/repos/libgit2/libgit2/pulls/comments/{number}","comments_url":"https://api.github.com/repos/libgit2/libgit2/issues/2471/comments","statuses_url":"https://api.github.com/repos/libgit2/libgit2/statuses/caeb9667caf43c6f637ee09beeb61260493826a5","head":{"label":"jacquesg:compatibility-cleanup","ref":"compatibility-cleanup","sha":"caeb9667caf43c6f637ee09beeb61260493826a5","user":{"login":"jacquesg","id":3534453,"avatar_url":"https://avatars.githubusercontent.com/u/3534453?v=2","gravatar_id":"019f39a605e3dfe373cf243877be7fad","url":"https://api.github.com/users/jacquesg","html_url":"https://github.com/jacquesg","followers_url":"https://api.github.com/users/jacquesg/followers","following_url":"https://api.github.com/users/jacquesg/following{/other_user}","gists_url":"https://api.github.com/users/jacquesg/gists{/gist_id}","starred_url":"https://api.github.com/users/jacquesg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacquesg/subscriptions","organizations_url":"https://api.github.com/users/jacquesg/orgs","repos_url":"https://api.github.com/users/jacquesg/repos","events_url":"https://api.github.com/users/jacquesg/events{/privacy}","received_events_url":"https://api.github.com/users/jacquesg/received_events","type":"User","site_admin":false},"repo":{"id":8486177,"name":"libgit2","full_name":"jacquesg/libgit2","owner":{"login":"jacquesg","id":3534453,"avatar_url":"https://avatars.githubusercontent.com/u/3534453?v=2","gravatar_id":"019f39a605e3dfe373cf243877be7fad","url":"https://api.github.com/users/jacquesg","html_url":"https://github.com/jacquesg","followers_url":"https://api.github.com/users/jacquesg/followers","following_url":"https://api.github.com/users/jacquesg/following{/other_user}","gists_url":"https://api.github.com/users/jacquesg/gists{/gist_id}","starred_url":"https://api.github.com/users/jacquesg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacquesg/subscriptions","organizations_url":"https://api.github.com/users/jacquesg/orgs","repos_url":"https://api.github.com/users/jacquesg/repos","events_url":"https://api.github.com/users/jacquesg/events{/privacy}","received_events_url":"https://api.github.com/users/jacquesg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jacquesg/libgit2","description":"The Library","fork":true,"url":"https://api.github.com/repos/jacquesg/libgit2","forks_url":"https://api.github.com/repos/jacquesg/libgit2/forks","keys_url":"https://api.github.com/repos/jacquesg/libgit2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jacquesg/libgit2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jacquesg/libgit2/teams","hooks_url":"https://api.github.com/repos/jacquesg/libgit2/hooks","issue_events_url":"https://api.github.com/repos/jacquesg/libgit2/issues/events{/number}","events_url":"https://api.github.com/repos/jacquesg/libgit2/events","assignees_url":"https://api.github.com/repos/jacquesg/libgit2/assignees{/user}","branches_url":"https://api.github.com/repos/jacquesg/libgit2/branches{/branch}","tags_url":"https://api.github.com/repos/jacquesg/libgit2/tags","blobs_url":"https://api.github.com/repos/jacquesg/libgit2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jacquesg/libgit2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jacquesg/libgit2/git/refs{/sha}","trees_url":"https://api.github.com/repos/jacquesg/libgit2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jacquesg/libgit2/statuses/{sha}","languages_url":"https://api.github.com/repos/jacquesg/libgit2/languages","stargazers_url":"https://api.github.com/repos/jacquesg/libgit2/stargazers","contributors_url":"https://api.github.com/repos/jacquesg/libgit2/contributors","subscribers_url":"https://api.github.com/repos/jacquesg/libgit2/subscribers","subscription_url":"https://api.github.com/repos/jacquesg/libgit2/subscription","commits_url":"https://api.github.com/repos/jacquesg/libgit2/commits{/sha}","git_commits_url":"https://api.github.com/repos/jacquesg/libgit2/git/commits{/sha}","comments_url":"https://api.github.com/repos/jacquesg/libgit2/comments{/number}","issue_comment_url":"https://api.github.com/repos/jacquesg/libgit2/issues/comments/{number}","contents_url":"https://api.github.com/repos/jacquesg/libgit2/contents/{+path}","compare_url":"https://api.github.com/repos/jacquesg/libgit2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jacquesg/libgit2/merges","archive_url":"https://api.github.com/repos/jacquesg/libgit2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jacquesg/libgit2/downloads","issues_url":"https://api.github.com/repos/jacquesg/libgit2/issues{/number}","pulls_url":"https://api.github.com/repos/jacquesg/libgit2/pulls{/number}","milestones_url":"https://api.github.com/repos/jacquesg/libgit2/milestones{/number}","notifications_url":"https://api.github.com/repos/jacquesg/libgit2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jacquesg/libgit2/labels{/name}","releases_url":"https://api.github.com/repos/jacquesg/libgit2/releases{/id}","created_at":"2013-02-28T19:20:19Z","updated_at":"2014-07-12T10:35:03Z","pushed_at":"2014-08-05T17:51:41Z","git_url":"git://github.com/jacquesg/libgit2.git","ssh_url":"git@github.com:jacquesg/libgit2.git","clone_url":"https://github.com/jacquesg/libgit2.git","svn_url":"https://github.com/jacquesg/libgit2","homepage":"http://libgit2.github.com","size":18538,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"libgit2:master","ref":"master","sha":"a6d7e166344cb0d9aa5ecca037a975f9f19e64f1","user":{"login":"libgit2","id":394745,"avatar_url":"https://avatars.githubusercontent.com/u/394745?v=2","gravatar_id":"1c56acccc41c591705dc92da5f6ab603","url":"https://api.github.com/users/libgit2","html_url":"https://github.com/libgit2","followers_url":"https://api.github.com/users/libgit2/followers","following_url":"https://api.github.com/users/libgit2/following{/other_user}","gists_url":"https://api.github.com/users/libgit2/gists{/gist_id}","starred_url":"https://api.github.com/users/libgit2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libgit2/subscriptions","organizations_url":"https://api.github.com/users/libgit2/orgs","repos_url":"https://api.github.com/users/libgit2/repos","events_url":"https://api.github.com/users/libgit2/events{/privacy}","received_events_url":"https://api.github.com/users/libgit2/received_events","type":"Organization","site_admin":false},"repo":{"id":901662,"name":"libgit2","full_name":"libgit2/libgit2","owner":{"login":"libgit2","id":394745,"avatar_url":"https://avatars.githubusercontent.com/u/394745?v=2","gravatar_id":"1c56acccc41c591705dc92da5f6ab603","url":"https://api.github.com/users/libgit2","html_url":"https://github.com/libgit2","followers_url":"https://api.github.com/users/libgit2/followers","following_url":"https://api.github.com/users/libgit2/following{/other_user}","gists_url":"https://api.github.com/users/libgit2/gists{/gist_id}","starred_url":"https://api.github.com/users/libgit2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libgit2/subscriptions","organizations_url":"https://api.github.com/users/libgit2/orgs","repos_url":"https://api.github.com/users/libgit2/repos","events_url":"https://api.github.com/users/libgit2/events{/privacy}","received_events_url":"https://api.github.com/users/libgit2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/libgit2/libgit2","description":"The Library","fork":false,"url":"https://api.github.com/repos/libgit2/libgit2","forks_url":"https://api.github.com/repos/libgit2/libgit2/forks","keys_url":"https://api.github.com/repos/libgit2/libgit2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/libgit2/libgit2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/libgit2/libgit2/teams","hooks_url":"https://api.github.com/repos/libgit2/libgit2/hooks","issue_events_url":"https://api.github.com/repos/libgit2/libgit2/issues/events{/number}","events_url":"https://api.github.com/repos/libgit2/libgit2/events","assignees_url":"https://api.github.com/repos/libgit2/libgit2/assignees{/user}","branches_url":"https://api.github.com/repos/libgit2/libgit2/branches{/branch}","tags_url":"https://api.github.com/repos/libgit2/libgit2/tags","blobs_url":"https://api.github.com/repos/libgit2/libgit2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/libgit2/libgit2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/libgit2/libgit2/git/refs{/sha}","trees_url":"https://api.github.com/repos/libgit2/libgit2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/libgit2/libgit2/statuses/{sha}","languages_url":"https://api.github.com/repos/libgit2/libgit2/languages","stargazers_url":"https://api.github.com/repos/libgit2/libgit2/stargazers","contributors_url":"https://api.github.com/repos/libgit2/libgit2/contributors","subscribers_url":"https://api.github.com/repos/libgit2/libgit2/subscribers","subscription_url":"https://api.github.com/repos/libgit2/libgit2/subscription","commits_url":"https://api.github.com/repos/libgit2/libgit2/commits{/sha}","git_commits_url":"https://api.github.com/repos/libgit2/libgit2/git/commits{/sha}","comments_url":"https://api.github.com/repos/libgit2/libgit2/comments{/number}","issue_comment_url":"https://api.github.com/repos/libgit2/libgit2/issues/comments/{number}","contents_url":"https://api.github.com/repos/libgit2/libgit2/contents/{+path}","compare_url":"https://api.github.com/repos/libgit2/libgit2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/libgit2/libgit2/merges","archive_url":"https://api.github.com/repos/libgit2/libgit2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/libgit2/libgit2/downloads","issues_url":"https://api.github.com/repos/libgit2/libgit2/issues{/number}","pulls_url":"https://api.github.com/repos/libgit2/libgit2/pulls{/number}","milestones_url":"https://api.github.com/repos/libgit2/libgit2/milestones{/number}","notifications_url":"https://api.github.com/repos/libgit2/libgit2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/libgit2/libgit2/labels{/name}","releases_url":"https://api.github.com/repos/libgit2/libgit2/releases{/id}","created_at":"2010-09-10T16:17:48Z","updated_at":"2014-08-05T17:30:52Z","pushed_at":"2014-08-05T18:28:22Z","git_url":"git://github.com/libgit2/libgit2.git","ssh_url":"git@github.com:libgit2/libgit2.git","clone_url":"https://github.com/libgit2/libgit2.git","svn_url":"https://github.com/libgit2/libgit2","homepage":"http://libgit2.github.com","size":83464,"stargazers_count":4592,"watchers_count":4592,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":1013,"mirror_url":null,"open_issues_count":124,"forks":1013,"open_issues":124,"watchers":4592,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/libgit2/libgit2/pulls/2471"},"html":{"href":"https://github.com/libgit2/libgit2/pull/2471"},"issue":{"href":"https://api.github.com/repos/libgit2/libgit2/issues/2471"},"comments":{"href":"https://api.github.com/repos/libgit2/libgit2/issues/2471/comments"},"review_comments":{"href":"https://api.github.com/repos/libgit2/libgit2/pulls/2471/comments"},"review_comment":{"href":"https://api.github.com/repos/libgit2/libgit2/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/libgit2/libgit2/pulls/2471/commits"},"statuses":{"href":"https://api.github.com/repos/libgit2/libgit2/statuses/caeb9667caf43c6f637ee09beeb61260493826a5"}}}}