GitHub PullRequestReviewCommentEvent at 2014-04-01 07:15:03
Repository: virtual-dom
Actor: Raynos
Payload: {"comment":{"url":"https://api.github.com/repos/Matt-Esch/virtual-dom/pulls/comments/11149680","id":11149680,"diff_hunk":"@@ -61,16 +62,21 @@ function diffProps(a, b) {\n     var diff\n \n     for (var aKey in a) {\n-        if (aKey === \"style\") {\n-            var styleDiff = diffProps(a.style, b.style || nullProps)\n-            if (styleDiff) {\n+        var aValue = a[aKey]\n+        var bValue = b[aKey] || nullProps\n+\n+        if (isObject(aValue)) {\n+            if (getPrototype(bValue) !== getPrototype(aValue)) {","path":"diff.js","position":19,"original_position":19,"commit_id":"9abf608bad2f064043e00eae79382dba3c748ae0","original_commit_id":"9abf608bad2f064043e00eae79382dba3c748ae0","user":{"login":"Raynos","id":479538,"avatar_url":"https://avatars.githubusercontent.com/u/479538?","gravatar_id":"d840cb1fb7e828284011cc08f40a1015","url":"https://api.github.com/users/Raynos","html_url":"https://github.com/Raynos","followers_url":"https://api.github.com/users/Raynos/followers","following_url":"https://api.github.com/users/Raynos/following{/other_user}","gists_url":"https://api.github.com/users/Raynos/gists{/gist_id}","starred_url":"https://api.github.com/users/Raynos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Raynos/subscriptions","organizations_url":"https://api.github.com/users/Raynos/orgs","repos_url":"https://api.github.com/users/Raynos/repos","events_url":"https://api.github.com/users/Raynos/events{/privacy}","received_events_url":"https://api.github.com/users/Raynos/received_events","type":"User","site_admin":false},"body":"if prototypes are not the same then we must patch bValue wholly.\r\n\r\nYou cannot merge `aValue` and `bValue` if the prototypes change otherwise the method calls will fail.","created_at":"2014-04-01T07:15:03Z","updated_at":"2014-04-01T07:15:03Z","html_url":"https://github.com/Matt-Esch/virtual-dom/pull/39#discussion_r11149680","pull_request_url":"https://api.github.com/repos/Matt-Esch/virtual-dom/pulls/39","_links":{"self":{"href":"https://api.github.com/repos/Matt-Esch/virtual-dom/pulls/comments/11149680"},"html":{"href":"https://github.com/Matt-Esch/virtual-dom/pull/39#discussion_r11149680"},"pull_request":{"href":"https://api.github.com/repos/Matt-Esch/virtual-dom/pulls/39"}}}}