GitHub PullRequestReviewCommentEvent at 2014-10-09 21:24:02
Repository: WorldGuard
Actor: TomyLobo
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/sk89q/WorldGuard/pulls/comments/18675295","id":18675295,"diff_hunk":"@@ -278,7 +282,7 @@ private DefaultDomain parseDomain(YAMLNode node) {\n         }\n \n         for (String name : node.getStringList(\"groups\", null)) {\n-            if (!name.isEmpty()) {\n+            if (!name.trim().isEmpty()) {","path":"src/main/java/com/sk89q/worldguard/protection/managers/storage/file/YamlRegionFile.java","position":39,"original_position":39,"commit_id":"06e474008998c9e9114db4af33588d809880fbcf","original_commit_id":"06e474008998c9e9114db4af33588d809880fbcf","user":{"login":"TomyLobo","id":963797,"avatar_url":"https://avatars.githubusercontent.com/u/963797?v=2","gravatar_id":"","url":"https://api.github.com/users/TomyLobo","html_url":"https://github.com/TomyLobo","followers_url":"https://api.github.com/users/TomyLobo/followers","following_url":"https://api.github.com/users/TomyLobo/following{/other_user}","gists_url":"https://api.github.com/users/TomyLobo/gists{/gist_id}","starred_url":"https://api.github.com/users/TomyLobo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomyLobo/subscriptions","organizations_url":"https://api.github.com/users/TomyLobo/orgs","repos_url":"https://api.github.com/users/TomyLobo/repos","events_url":"https://api.github.com/users/TomyLobo/events{/privacy}","received_events_url":"https://api.github.com/users/TomyLobo/received_events","type":"User","site_admin":false},"body":"why is there no warning in this one?","created_at":"2014-10-09T21:24:02Z","updated_at":"2014-10-09T21:24:02Z","html_url":"https://github.com/sk89q/WorldGuard/pull/329#discussion_r18675295","pull_request_url":"https://api.github.com/repos/sk89q/WorldGuard/pulls/329","_links":{"self":{"href":"https://api.github.com/repos/sk89q/WorldGuard/pulls/comments/18675295"},"html":{"href":"https://github.com/sk89q/WorldGuard/pull/329#discussion_r18675295"},"pull_request":{"href":"https://api.github.com/repos/sk89q/WorldGuard/pulls/329"}}},"pull_request":{"url":"https://api.github.com/repos/sk89q/WorldGuard/pulls/329","id":22466285,"html_url":"https://github.com/sk89q/WorldGuard/pull/329","diff_url":"https://github.com/sk89q/WorldGuard/pull/329.diff","patch_url":"https://github.com/sk89q/WorldGuard/pull/329.patch","issue_url":"https://api.github.com/repos/sk89q/WorldGuard/issues/329","number":329,"state":"open","locked":false,"title":"Fix for issue #3182 - Warns about blank owners in region file","user":{"login":"NAE","id":1007815,"avatar_url":"https://avatars.githubusercontent.com/u/1007815?v=2","gravatar_id":"","url":"https://api.github.com/users/NAE","html_url":"https://github.com/NAE","followers_url":"https://api.github.com/users/NAE/followers","following_url":"https://api.github.com/users/NAE/following{/other_user}","gists_url":"https://api.github.com/users/NAE/gists{/gist_id}","starred_url":"https://api.github.com/users/NAE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NAE/subscriptions","organizations_url":"https://api.github.com/users/NAE/orgs","repos_url":"https://api.github.com/users/NAE/repos","events_url":"https://api.github.com/users/NAE/events{/privacy}","received_events_url":"https://api.github.com/users/NAE/received_events","type":"User","site_admin":false},"body":"Fixes http://youtrack.sk89q.com/issue/WORLDGUARD-3182\r\n\r\nIssue creator had region file that contained a region with an owner ' '. This will log a warning with the problematic region, but continue anyway.","created_at":"2014-10-09T01:13:59Z","updated_at":"2014-10-09T21:24:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"63d4ad207cfc2c27fb2ba1ebbd244224d1a480f4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sk89q/WorldGuard/pulls/329/commits","review_comments_url":"https://api.github.com/repos/sk89q/WorldGuard/pulls/329/comments","review_comment_url":"https://api.github.com/repos/sk89q/WorldGuard/pulls/comments/{number}","comments_url":"https://api.github.com/repos/sk89q/WorldGuard/issues/329/comments","statuses_url":"https://api.github.com/repos/sk89q/WorldGuard/statuses/06e474008998c9e9114db4af33588d809880fbcf","head":{"label":"NAE:master","ref":"master","sha":"06e474008998c9e9114db4af33588d809880fbcf","user":{"login":"NAE","id":1007815,"avatar_url":"https://avatars.githubusercontent.com/u/1007815?v=2","gravatar_id":"","url":"https://api.github.com/users/NAE","html_url":"https://github.com/NAE","followers_url":"https://api.github.com/users/NAE/followers","following_url":"https://api.github.com/users/NAE/following{/other_user}","gists_url":"https://api.github.com/users/NAE/gists{/gist_id}","starred_url":"https://api.github.com/users/NAE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NAE/subscriptions","organizations_url":"https://api.github.com/users/NAE/orgs","repos_url":"https://api.github.com/users/NAE/repos","events_url":"https://api.github.com/users/NAE/events{/privacy}","received_events_url":"https://api.github.com/users/NAE/received_events","type":"User","site_admin":false},"repo":{"id":24834934,"name":"WorldGuard","full_name":"NAE/WorldGuard","owner":{"login":"NAE","id":1007815,"avatar_url":"https://avatars.githubusercontent.com/u/1007815?v=2","gravatar_id":"","url":"https://api.github.com/users/NAE","html_url":"https://github.com/NAE","followers_url":"https://api.github.com/users/NAE/followers","following_url":"https://api.github.com/users/NAE/following{/other_user}","gists_url":"https://api.github.com/users/NAE/gists{/gist_id}","starred_url":"https://api.github.com/users/NAE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NAE/subscriptions","organizations_url":"https://api.github.com/users/NAE/orgs","repos_url":"https://api.github.com/users/NAE/repos","events_url":"https://api.github.com/users/NAE/events{/privacy}","received_events_url":"https://api.github.com/users/NAE/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/NAE/WorldGuard","description":"Protect Minecraft servers, protect areas, and solve problems","fork":true,"url":"https://api.github.com/repos/NAE/WorldGuard","forks_url":"https://api.github.com/repos/NAE/WorldGuard/forks","keys_url":"https://api.github.com/repos/NAE/WorldGuard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NAE/WorldGuard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NAE/WorldGuard/teams","hooks_url":"https://api.github.com/repos/NAE/WorldGuard/hooks","issue_events_url":"https://api.github.com/repos/NAE/WorldGuard/issues/events{/number}","events_url":"https://api.github.com/repos/NAE/WorldGuard/events","assignees_url":"https://api.github.com/repos/NAE/WorldGuard/assignees{/user}","branches_url":"https://api.github.com/repos/NAE/WorldGuard/branches{/branch}","tags_url":"https://api.github.com/repos/NAE/WorldGuard/tags","blobs_url":"https://api.github.com/repos/NAE/WorldGuard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NAE/WorldGuard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NAE/WorldGuard/git/refs{/sha}","trees_url":"https://api.github.com/repos/NAE/WorldGuard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NAE/WorldGuard/statuses/{sha}","languages_url":"https://api.github.com/repos/NAE/WorldGuard/languages","stargazers_url":"https://api.github.com/repos/NAE/WorldGuard/stargazers","contributors_url":"https://api.github.com/repos/NAE/WorldGuard/contributors","subscribers_url":"https://api.github.com/repos/NAE/WorldGuard/subscribers","subscription_url":"https://api.github.com/repos/NAE/WorldGuard/subscription","commits_url":"https://api.github.com/repos/NAE/WorldGuard/commits{/sha}","git_commits_url":"https://api.github.com/repos/NAE/WorldGuard/git/commits{/sha}","comments_url":"https://api.github.com/repos/NAE/WorldGuard/comments{/number}","issue_comment_url":"https://api.github.com/repos/NAE/WorldGuard/issues/comments/{number}","contents_url":"https://api.github.com/repos/NAE/WorldGuard/contents/{+path}","compare_url":"https://api.github.com/repos/NAE/WorldGuard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NAE/WorldGuard/merges","archive_url":"https://api.github.com/repos/NAE/WorldGuard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NAE/WorldGuard/downloads","issues_url":"https://api.github.com/repos/NAE/WorldGuard/issues{/number}","pulls_url":"https://api.github.com/repos/NAE/WorldGuard/pulls{/number}","milestones_url":"https://api.github.com/repos/NAE/WorldGuard/milestones{/number}","notifications_url":"https://api.github.com/repos/NAE/WorldGuard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NAE/WorldGuard/labels{/name}","releases_url":"https://api.github.com/repos/NAE/WorldGuard/releases{/id}","created_at":"2014-10-06T05:27:06Z","updated_at":"2014-10-06T07:14:03Z","pushed_at":"2014-10-06T07:14:02Z","git_url":"git://github.com/NAE/WorldGuard.git","ssh_url":"git@github.com:NAE/WorldGuard.git","clone_url":"https://github.com/NAE/WorldGuard.git","svn_url":"https://github.com/NAE/WorldGuard","homepage":"http://www.enginehub.org/worldguard","size":5296,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sk89q:master","ref":"master","sha":"25f12e9733a4b8a833c90cbfa93fc7cb95a53172","user":{"login":"sk89q","id":38949,"avatar_url":"https://avatars.githubusercontent.com/u/38949?v=2","gravatar_id":"","url":"https://api.github.com/users/sk89q","html_url":"https://github.com/sk89q","followers_url":"https://api.github.com/users/sk89q/followers","following_url":"https://api.github.com/users/sk89q/following{/other_user}","gists_url":"https://api.github.com/users/sk89q/gists{/gist_id}","starred_url":"https://api.github.com/users/sk89q/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sk89q/subscriptions","organizations_url":"https://api.github.com/users/sk89q/orgs","repos_url":"https://api.github.com/users/sk89q/repos","events_url":"https://api.github.com/users/sk89q/events{/privacy}","received_events_url":"https://api.github.com/users/sk89q/received_events","type":"User","site_admin":false},"repo":{"id":1090553,"name":"WorldGuard","full_name":"sk89q/WorldGuard","owner":{"login":"sk89q","id":38949,"avatar_url":"https://avatars.githubusercontent.com/u/38949?v=2","gravatar_id":"","url":"https://api.github.com/users/sk89q","html_url":"https://github.com/sk89q","followers_url":"https://api.github.com/users/sk89q/followers","following_url":"https://api.github.com/users/sk89q/following{/other_user}","gists_url":"https://api.github.com/users/sk89q/gists{/gist_id}","starred_url":"https://api.github.com/users/sk89q/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sk89q/subscriptions","organizations_url":"https://api.github.com/users/sk89q/orgs","repos_url":"https://api.github.com/users/sk89q/repos","events_url":"https://api.github.com/users/sk89q/events{/privacy}","received_events_url":"https://api.github.com/users/sk89q/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sk89q/WorldGuard","description":"Protect Minecraft servers, protect areas, and solve problems","fork":false,"url":"https://api.github.com/repos/sk89q/WorldGuard","forks_url":"https://api.github.com/repos/sk89q/WorldGuard/forks","keys_url":"https://api.github.com/repos/sk89q/WorldGuard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sk89q/WorldGuard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sk89q/WorldGuard/teams","hooks_url":"https://api.github.com/repos/sk89q/WorldGuard/hooks","issue_events_url":"https://api.github.com/repos/sk89q/WorldGuard/issues/events{/number}","events_url":"https://api.github.com/repos/sk89q/WorldGuard/events","assignees_url":"https://api.github.com/repos/sk89q/WorldGuard/assignees{/user}","branches_url":"https://api.github.com/repos/sk89q/WorldGuard/branches{/branch}","tags_url":"https://api.github.com/repos/sk89q/WorldGuard/tags","blobs_url":"https://api.github.com/repos/sk89q/WorldGuard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sk89q/WorldGuard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sk89q/WorldGuard/git/refs{/sha}","trees_url":"https://api.github.com/repos/sk89q/WorldGuard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sk89q/WorldGuard/statuses/{sha}","languages_url":"https://api.github.com/repos/sk89q/WorldGuard/languages","stargazers_url":"https://api.github.com/repos/sk89q/WorldGuard/stargazers","contributors_url":"https://api.github.com/repos/sk89q/WorldGuard/contributors","subscribers_url":"https://api.github.com/repos/sk89q/WorldGuard/subscribers","subscription_url":"https://api.github.com/repos/sk89q/WorldGuard/subscription","commits_url":"https://api.github.com/repos/sk89q/WorldGuard/commits{/sha}","git_commits_url":"https://api.github.com/repos/sk89q/WorldGuard/git/commits{/sha}","comments_url":"https://api.github.com/repos/sk89q/WorldGuard/comments{/number}","issue_comment_url":"https://api.github.com/repos/sk89q/WorldGuard/issues/comments/{number}","contents_url":"https://api.github.com/repos/sk89q/WorldGuard/contents/{+path}","compare_url":"https://api.github.com/repos/sk89q/WorldGuard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sk89q/WorldGuard/merges","archive_url":"https://api.github.com/repos/sk89q/WorldGuard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sk89q/WorldGuard/downloads","issues_url":"https://api.github.com/repos/sk89q/WorldGuard/issues{/number}","pulls_url":"https://api.github.com/repos/sk89q/WorldGuard/pulls{/number}","milestones_url":"https://api.github.com/repos/sk89q/WorldGuard/milestones{/number}","notifications_url":"https://api.github.com/repos/sk89q/WorldGuard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sk89q/WorldGuard/labels{/name}","releases_url":"https://api.github.com/repos/sk89q/WorldGuard/releases{/id}","created_at":"2010-11-18T03:25:19Z","updated_at":"2014-09-27T05:29:47Z","pushed_at":"2014-09-19T03:32:59Z","git_url":"git://github.com/sk89q/WorldGuard.git","ssh_url":"git@github.com:sk89q/WorldGuard.git","clone_url":"https://github.com/sk89q/WorldGuard.git","svn_url":"https://github.com/sk89q/WorldGuard","homepage":"http://www.enginehub.org/worldguard","size":10712,"stargazers_count":314,"watchers_count":314,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":255,"mirror_url":null,"open_issues_count":6,"forks":255,"open_issues":6,"watchers":314,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sk89q/WorldGuard/pulls/329"},"html":{"href":"https://github.com/sk89q/WorldGuard/pull/329"},"issue":{"href":"https://api.github.com/repos/sk89q/WorldGuard/issues/329"},"comments":{"href":"https://api.github.com/repos/sk89q/WorldGuard/issues/329/comments"},"review_comments":{"href":"https://api.github.com/repos/sk89q/WorldGuard/pulls/329/comments"},"review_comment":{"href":"https://api.github.com/repos/sk89q/WorldGuard/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/sk89q/WorldGuard/pulls/329/commits"},"statuses":{"href":"https://api.github.com/repos/sk89q/WorldGuard/statuses/06e474008998c9e9114db4af33588d809880fbcf"}}}}