GitHub PullRequestReviewCommentEvent at 2014-09-22 17:43:54
Repository: kc
Actor: gathreya
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/kuali/kc/pulls/comments/17864647","id":17864647,"diff_hunk":"@@ -419,4 +593,58 @@ public void setKcAuthorizationService(KcAuthorizationService kcAuthorizationServ\n \t\tthis.kcAuthorizationService = kcAuthorizationService;\n \t}\n \n+    protected  TaskAuthorizationService getTaskAuthenticationService (){\n+        if (taskAuthenticationService == null) {\n+            taskAuthenticationService = KcServiceLocator.getService(TaskAuthorizationService.class);\n+        }\n+        return taskAuthenticationService;\n+    }\n+","path":"coeus-impl/src/main/java/org/kuali/coeus/propdev/impl/auth/ProposalDevelopmentDocumentAuthorizer.java","position":474,"original_position":474,"commit_id":"3f09db962676a85be16493cb40fbfe2a57740a72","original_commit_id":"3f09db962676a85be16493cb40fbfe2a57740a72","user":{"login":"gathreya","id":6466224,"avatar_url":"https://avatars.githubusercontent.com/u/6466224?v=2","gravatar_id":"","url":"https://api.github.com/users/gathreya","html_url":"https://github.com/gathreya","followers_url":"https://api.github.com/users/gathreya/followers","following_url":"https://api.github.com/users/gathreya/following{/other_user}","gists_url":"https://api.github.com/users/gathreya/gists{/gist_id}","starred_url":"https://api.github.com/users/gathreya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gathreya/subscriptions","organizations_url":"https://api.github.com/users/gathreya/orgs","repos_url":"https://api.github.com/users/gathreya/repos","events_url":"https://api.github.com/users/gathreya/events{/privacy}","received_events_url":"https://api.github.com/users/gathreya/received_events","type":"User","site_admin":false},"body":"are you using this anywhere? Do you still need this service?","created_at":"2014-09-22T17:43:54Z","updated_at":"2014-09-22T17:43:54Z","html_url":"https://github.com/kuali/kc/pull/762#discussion_r17864647","pull_request_url":"https://api.github.com/repos/kuali/kc/pulls/762","_links":{"self":{"href":"https://api.github.com/repos/kuali/kc/pulls/comments/17864647"},"html":{"href":"https://github.com/kuali/kc/pull/762#discussion_r17864647"},"pull_request":{"href":"https://api.github.com/repos/kuali/kc/pulls/762"}}},"pull_request":{"url":"https://api.github.com/repos/kuali/kc/pulls/762","id":21465793,"html_url":"https://github.com/kuali/kc/pull/762","diff_url":"https://github.com/kuali/kc/pull/762.diff","patch_url":"https://github.com/kuali/kc/pull/762.patch","issue_url":"https://api.github.com/repos/kuali/kc/issues/762","number":762,"state":"open","locked":false,"title":"KRACOEUS-7747: task authorizer replacement","user":{"login":"leoherbie","id":188602,"avatar_url":"https://avatars.githubusercontent.com/u/188602?v=2","gravatar_id":"","url":"https://api.github.com/users/leoherbie","html_url":"https://github.com/leoherbie","followers_url":"https://api.github.com/users/leoherbie/followers","following_url":"https://api.github.com/users/leoherbie/following{/other_user}","gists_url":"https://api.github.com/users/leoherbie/gists{/gist_id}","starred_url":"https://api.github.com/users/leoherbie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leoherbie/subscriptions","organizations_url":"https://api.github.com/users/leoherbie/orgs","repos_url":"https://api.github.com/users/leoherbie/repos","events_url":"https://api.github.com/users/leoherbie/events{/privacy}","received_events_url":"https://api.github.com/users/leoherbie/received_events","type":"User","site_admin":false},"body":"Here is the potential replacement for the task authorizer (and web authorizer) framework.  I tried to accomplish several things:  \r\n\r\n1) less layers for abstraction\r\n2) small units of authorization - I still don't want to put everything in one class\r\n3) fully spring based\r\n4) integration into KRADs authorization classes\r\n5) easy path to port from task/web auth framework\r\n\r\nPlease review this and ask any questions.  I'm not a huge fan of the ViewActionAuthorizer piece because I'm not sure whether we should be locking down the system this way.  Also, we don't use the feature a lot (WebAuthorizers) and I'd guess we missed a lot of \"methodsToCall\".  Also, one methodToCall controller method can easily call another so you have to remember to add to the list when this happens.\r\n\r\nAlso note that I used the final keyword in a few places on methods.  There is actually a good reason for this.  We want to avoid having doc generic auth logic in view authorizers and since view authorizers delegate to doc auth that is the place you can put that logic.  Rice actually made some of these methods final already but missed a few.  I just completed that task.","created_at":"2014-09-18T21:59:48Z","updated_at":"2014-09-22T17:43:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"055186d2de9878b9677f01b94ddd69f8a045b6c2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/kuali/kc/pulls/762/commits","review_comments_url":"https://api.github.com/repos/kuali/kc/pulls/762/comments","review_comment_url":"https://api.github.com/repos/kuali/kc/pulls/comments/{number}","comments_url":"https://api.github.com/repos/kuali/kc/issues/762/comments","statuses_url":"https://api.github.com/repos/kuali/kc/statuses/3f09db962676a85be16493cb40fbfe2a57740a72","head":{"label":"leoherbie:kill_the_task_framework","ref":"kill_the_task_framework","sha":"3f09db962676a85be16493cb40fbfe2a57740a72","user":{"login":"leoherbie","id":188602,"avatar_url":"https://avatars.githubusercontent.com/u/188602?v=2","gravatar_id":"","url":"https://api.github.com/users/leoherbie","html_url":"https://github.com/leoherbie","followers_url":"https://api.github.com/users/leoherbie/followers","following_url":"https://api.github.com/users/leoherbie/following{/other_user}","gists_url":"https://api.github.com/users/leoherbie/gists{/gist_id}","starred_url":"https://api.github.com/users/leoherbie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leoherbie/subscriptions","organizations_url":"https://api.github.com/users/leoherbie/orgs","repos_url":"https://api.github.com/users/leoherbie/repos","events_url":"https://api.github.com/users/leoherbie/events{/privacy}","received_events_url":"https://api.github.com/users/leoherbie/received_events","type":"User","site_admin":false},"repo":{"id":16319639,"name":"kc","full_name":"leoherbie/kc","owner":{"login":"leoherbie","id":188602,"avatar_url":"https://avatars.githubusercontent.com/u/188602?v=2","gravatar_id":"","url":"https://api.github.com/users/leoherbie","html_url":"https://github.com/leoherbie","followers_url":"https://api.github.com/users/leoherbie/followers","following_url":"https://api.github.com/users/leoherbie/following{/other_user}","gists_url":"https://api.github.com/users/leoherbie/gists{/gist_id}","starred_url":"https://api.github.com/users/leoherbie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leoherbie/subscriptions","organizations_url":"https://api.github.com/users/leoherbie/orgs","repos_url":"https://api.github.com/users/leoherbie/repos","events_url":"https://api.github.com/users/leoherbie/events{/privacy}","received_events_url":"https://api.github.com/users/leoherbie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/leoherbie/kc","description":"Kuali Coeus","fork":true,"url":"https://api.github.com/repos/leoherbie/kc","forks_url":"https://api.github.com/repos/leoherbie/kc/forks","keys_url":"https://api.github.com/repos/leoherbie/kc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/leoherbie/kc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/leoherbie/kc/teams","hooks_url":"https://api.github.com/repos/leoherbie/kc/hooks","issue_events_url":"https://api.github.com/repos/leoherbie/kc/issues/events{/number}","events_url":"https://api.github.com/repos/leoherbie/kc/events","assignees_url":"https://api.github.com/repos/leoherbie/kc/assignees{/user}","branches_url":"https://api.github.com/repos/leoherbie/kc/branches{/branch}","tags_url":"https://api.github.com/repos/leoherbie/kc/tags","blobs_url":"https://api.github.com/repos/leoherbie/kc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/leoherbie/kc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/leoherbie/kc/git/refs{/sha}","trees_url":"https://api.github.com/repos/leoherbie/kc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/leoherbie/kc/statuses/{sha}","languages_url":"https://api.github.com/repos/leoherbie/kc/languages","stargazers_url":"https://api.github.com/repos/leoherbie/kc/stargazers","contributors_url":"https://api.github.com/repos/leoherbie/kc/contributors","subscribers_url":"https://api.github.com/repos/leoherbie/kc/subscribers","subscription_url":"https://api.github.com/repos/leoherbie/kc/subscription","commits_url":"https://api.github.com/repos/leoherbie/kc/commits{/sha}","git_commits_url":"https://api.github.com/repos/leoherbie/kc/git/commits{/sha}","comments_url":"https://api.github.com/repos/leoherbie/kc/comments{/number}","issue_comment_url":"https://api.github.com/repos/leoherbie/kc/issues/comments/{number}","contents_url":"https://api.github.com/repos/leoherbie/kc/contents/{+path}","compare_url":"https://api.github.com/repos/leoherbie/kc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/leoherbie/kc/merges","archive_url":"https://api.github.com/repos/leoherbie/kc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/leoherbie/kc/downloads","issues_url":"https://api.github.com/repos/leoherbie/kc/issues{/number}","pulls_url":"https://api.github.com/repos/leoherbie/kc/pulls{/number}","milestones_url":"https://api.github.com/repos/leoherbie/kc/milestones{/number}","notifications_url":"https://api.github.com/repos/leoherbie/kc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/leoherbie/kc/labels{/name}","releases_url":"https://api.github.com/repos/leoherbie/kc/releases{/id}","created_at":"2014-01-28T17:33:17Z","updated_at":"2014-06-25T12:32:57Z","pushed_at":"2014-09-22T17:16:10Z","git_url":"git://github.com/leoherbie/kc.git","ssh_url":"git@github.com:leoherbie/kc.git","clone_url":"https://github.com/leoherbie/kc.git","svn_url":"https://github.com/leoherbie/kc","homepage":"http://www.kuali.org/kc","size":594917,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kuali:master","ref":"master","sha":"d72ff6aca2c895f7f57dc1763cc28c29e98b6e97","user":{"login":"kuali","id":371097,"avatar_url":"https://avatars.githubusercontent.com/u/371097?v=2","gravatar_id":"","url":"https://api.github.com/users/kuali","html_url":"https://github.com/kuali","followers_url":"https://api.github.com/users/kuali/followers","following_url":"https://api.github.com/users/kuali/following{/other_user}","gists_url":"https://api.github.com/users/kuali/gists{/gist_id}","starred_url":"https://api.github.com/users/kuali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kuali/subscriptions","organizations_url":"https://api.github.com/users/kuali/orgs","repos_url":"https://api.github.com/users/kuali/repos","events_url":"https://api.github.com/users/kuali/events{/privacy}","received_events_url":"https://api.github.com/users/kuali/received_events","type":"Organization","site_admin":false},"repo":{"id":16106733,"name":"kc","full_name":"kuali/kc","owner":{"login":"kuali","id":371097,"avatar_url":"https://avatars.githubusercontent.com/u/371097?v=2","gravatar_id":"","url":"https://api.github.com/users/kuali","html_url":"https://github.com/kuali","followers_url":"https://api.github.com/users/kuali/followers","following_url":"https://api.github.com/users/kuali/following{/other_user}","gists_url":"https://api.github.com/users/kuali/gists{/gist_id}","starred_url":"https://api.github.com/users/kuali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kuali/subscriptions","organizations_url":"https://api.github.com/users/kuali/orgs","repos_url":"https://api.github.com/users/kuali/repos","events_url":"https://api.github.com/users/kuali/events{/privacy}","received_events_url":"https://api.github.com/users/kuali/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kuali/kc","description":"Kuali Coeus","fork":false,"url":"https://api.github.com/repos/kuali/kc","forks_url":"https://api.github.com/repos/kuali/kc/forks","keys_url":"https://api.github.com/repos/kuali/kc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kuali/kc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kuali/kc/teams","hooks_url":"https://api.github.com/repos/kuali/kc/hooks","issue_events_url":"https://api.github.com/repos/kuali/kc/issues/events{/number}","events_url":"https://api.github.com/repos/kuali/kc/events","assignees_url":"https://api.github.com/repos/kuali/kc/assignees{/user}","branches_url":"https://api.github.com/repos/kuali/kc/branches{/branch}","tags_url":"https://api.github.com/repos/kuali/kc/tags","blobs_url":"https://api.github.com/repos/kuali/kc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kuali/kc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kuali/kc/git/refs{/sha}","trees_url":"https://api.github.com/repos/kuali/kc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kuali/kc/statuses/{sha}","languages_url":"https://api.github.com/repos/kuali/kc/languages","stargazers_url":"https://api.github.com/repos/kuali/kc/stargazers","contributors_url":"https://api.github.com/repos/kuali/kc/contributors","subscribers_url":"https://api.github.com/repos/kuali/kc/subscribers","subscription_url":"https://api.github.com/repos/kuali/kc/subscription","commits_url":"https://api.github.com/repos/kuali/kc/commits{/sha}","git_commits_url":"https://api.github.com/repos/kuali/kc/git/commits{/sha}","comments_url":"https://api.github.com/repos/kuali/kc/comments{/number}","issue_comment_url":"https://api.github.com/repos/kuali/kc/issues/comments/{number}","contents_url":"https://api.github.com/repos/kuali/kc/contents/{+path}","compare_url":"https://api.github.com/repos/kuali/kc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kuali/kc/merges","archive_url":"https://api.github.com/repos/kuali/kc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kuali/kc/downloads","issues_url":"https://api.github.com/repos/kuali/kc/issues{/number}","pulls_url":"https://api.github.com/repos/kuali/kc/pulls{/number}","milestones_url":"https://api.github.com/repos/kuali/kc/milestones{/number}","notifications_url":"https://api.github.com/repos/kuali/kc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kuali/kc/labels{/name}","releases_url":"https://api.github.com/repos/kuali/kc/releases{/id}","created_at":"2014-01-21T15:32:22Z","updated_at":"2014-09-17T19:46:00Z","pushed_at":"2014-09-20T17:19:42Z","git_url":"git://github.com/kuali/kc.git","ssh_url":"git@github.com:kuali/kc.git","clone_url":"https://github.com/kuali/kc.git","svn_url":"https://github.com/kuali/kc","homepage":"http://www.kuali.org/kc","size":696783,"stargazers_count":8,"watchers_count":8,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":35,"mirror_url":null,"open_issues_count":22,"forks":35,"open_issues":22,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kuali/kc/pulls/762"},"html":{"href":"https://github.com/kuali/kc/pull/762"},"issue":{"href":"https://api.github.com/repos/kuali/kc/issues/762"},"comments":{"href":"https://api.github.com/repos/kuali/kc/issues/762/comments"},"review_comments":{"href":"https://api.github.com/repos/kuali/kc/pulls/762/comments"},"review_comment":{"href":"https://api.github.com/repos/kuali/kc/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/kuali/kc/pulls/762/commits"},"statuses":{"href":"https://api.github.com/repos/kuali/kc/statuses/3f09db962676a85be16493cb40fbfe2a57740a72"}}}}