GitHub PullRequestReviewCommentEvent at 2014-05-15 19:16:56
Repository: homebrew
Actor: dlo
Payload: {"comment":{"url":"https://api.github.com/repos/Homebrew/homebrew/pulls/comments/12707715","id":12707715,"diff_hunk":"@@ -19,9 +19,11 @@ class Sqlite < Formula\n   option 'with-docs', 'Install HTML documentation'\n   option 'without-rtree', 'Disable the R*Tree index module'\n   option 'with-fts', 'Enable the FTS module'\n+  option 'with-icu', 'Enable the ICU module'\n   option 'with-functions', 'Enable more math and string functions for SQL queries'\n \n   depends_on 'readline' => :recommended\n+  depends_on 'icu4c' => :build if build.with? \"icu\"","path":"Library/Formula/sqlite.rb","position":8,"original_position":8,"commit_id":"d094842e5c18156fc6b4df56f15cf60a2b0b8d46","original_commit_id":"d094842e5c18156fc6b4df56f15cf60a2b0b8d46","user":{"login":"dlo","id":38447,"avatar_url":"https://avatars.githubusercontent.com/u/38447?","gravatar_id":"bd0391d7225d10455d35de0fb5485bea","url":"https://api.github.com/users/dlo","html_url":"https://github.com/dlo","followers_url":"https://api.github.com/users/dlo/followers","following_url":"https://api.github.com/users/dlo/following{/other_user}","gists_url":"https://api.github.com/users/dlo/gists{/gist_id}","starred_url":"https://api.github.com/users/dlo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlo/subscriptions","organizations_url":"https://api.github.com/users/dlo/orgs","repos_url":"https://api.github.com/users/dlo/repos","events_url":"https://api.github.com/users/dlo/events{/privacy}","received_events_url":"https://api.github.com/users/dlo/received_events","type":"User","site_admin":false},"body":"I believe it's statically linked...I could be wrong though. Would changing to \":optional\" be the safe move?","created_at":"2014-05-15T19:16:56Z","updated_at":"2014-05-15T19:16:56Z","html_url":"https://github.com/Homebrew/homebrew/pull/29285#discussion_r12707715","pull_request_url":"https://api.github.com/repos/Homebrew/homebrew/pulls/29285","_links":{"self":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/comments/12707715"},"html":{"href":"https://github.com/Homebrew/homebrew/pull/29285#discussion_r12707715"},"pull_request":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/29285"}}}}