GitHub PullRequestReviewCommentEvent at 2014-10-02 20:51:49
Repository: SAPI
Actor: houndci
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/unepwcmc/SAPI/pulls/comments/18366956","id":18366956,"diff_hunk":"@@ -0,0 +1,62 @@\n+class Admin::NomenclatureChanges::SplitController < Admin::NomenclatureChanges::BuildController\n+\n+  steps *NomenclatureChange::Split::STEPS\n+\n+  def create\n+    @nomenclature_change = NomenclatureChange::Split.new(:status => NomenclatureChange::NEW)\n+    if @nomenclature_change.save\n+      redirect_to wizard_path(steps.first, :nomenclature_change_id => @nomenclature_change.id)\n+    else\n+      redirect_to admin_nomenclature_changes_url, :alert => \"Could not start a new nomenclature change\"\n+    end\n+  end\n+\n+  def show\n+    builder = NomenclatureChange::Split::Constructor.new(@nomenclature_change)\n+    case step\n+    when :inputs\n+      set_events\n+      set_taxonomy\n+      builder.build_input\n+    when :outputs\n+      set_taxonomy\n+      builder.build_outputs\n+    when :notes\n+      builder.build_input_and_output_notes\n+    when :children\n+      builder.build_parent_reassignments\n+      skip_or_previous_step if @nomenclature_change.input.parent_reassignments.empty?\n+    when :names\n+      builder.build_name_reassignments\n+      skip_or_previous_step if @nomenclature_change.input.name_reassignments.empty?","path":"app/controllers/admin/nomenclature_changes/split_controller.rb","position":31,"original_position":31,"commit_id":"1b4a785d25091e4ee2e73ed3a892ab1ef9597982","original_commit_id":"1b4a785d25091e4ee2e73ed3a892ab1ef9597982","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=2","gravatar_id":"","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Line is too long. [83/80]","created_at":"2014-10-02T20:51:49Z","updated_at":"2014-10-02T20:51:49Z","html_url":"https://github.com/unepwcmc/SAPI/pull/396#discussion_r18366956","pull_request_url":"https://api.github.com/repos/unepwcmc/SAPI/pulls/396","_links":{"self":{"href":"https://api.github.com/repos/unepwcmc/SAPI/pulls/comments/18366956"},"html":{"href":"https://github.com/unepwcmc/SAPI/pull/396#discussion_r18366956"},"pull_request":{"href":"https://api.github.com/repos/unepwcmc/SAPI/pulls/396"}}},"pull_request":{"url":"https://api.github.com/repos/unepwcmc/SAPI/pulls/396","id":22138720,"html_url":"https://github.com/unepwcmc/SAPI/pull/396","diff_url":"https://github.com/unepwcmc/SAPI/pull/396.diff","patch_url":"https://github.com/unepwcmc/SAPI/pull/396.patch","issue_url":"https://api.github.com/repos/unepwcmc/SAPI/issues/396","number":396,"state":"open","locked":false,"title":"Multi lingual public nomenclature notes","user":{"login":"agnessa","id":134055,"avatar_url":"https://avatars.githubusercontent.com/u/134055?v=2","gravatar_id":"","url":"https://api.github.com/users/agnessa","html_url":"https://github.com/agnessa","followers_url":"https://api.github.com/users/agnessa/followers","following_url":"https://api.github.com/users/agnessa/following{/other_user}","gists_url":"https://api.github.com/users/agnessa/gists{/gist_id}","starred_url":"https://api.github.com/users/agnessa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agnessa/subscriptions","organizations_url":"https://api.github.com/users/agnessa/orgs","repos_url":"https://api.github.com/users/agnessa/repos","events_url":"https://api.github.com/users/agnessa/events{/privacy}","received_events_url":"https://api.github.com/users/agnessa/received_events","type":"User","site_admin":false},"body":"Finished & cleaned up handling of public nomenclature notes (no changes to internal notes)\r\n* added _en, _es, _fr fields to nomenclature change inputs, outputs and reassingments\r\n* added _en, _es, _fr fields to trade_restrictions and eu_decisions (for consistency with listing changes & less awkward special cases handling)\r\n* refactored the nomenclature change constructors to fetch note templates from I18n, rather than hardcoded values\r\n\r\nRequires `rake db:migrate` and rails server restart (to load the translations)","created_at":"2014-10-02T13:12:59Z","updated_at":"2014-10-02T20:51:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"db739308f1458f4a10d01d1c55fc365a52533f36","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/unepwcmc/SAPI/pulls/396/commits","review_comments_url":"https://api.github.com/repos/unepwcmc/SAPI/pulls/396/comments","review_comment_url":"https://api.github.com/repos/unepwcmc/SAPI/pulls/comments/{number}","comments_url":"https://api.github.com/repos/unepwcmc/SAPI/issues/396/comments","statuses_url":"https://api.github.com/repos/unepwcmc/SAPI/statuses/1b4a785d25091e4ee2e73ed3a892ab1ef9597982","head":{"label":"unepwcmc:multi_lingual_public_nomenclature_notes","ref":"multi_lingual_public_nomenclature_notes","sha":"1b4a785d25091e4ee2e73ed3a892ab1ef9597982","user":{"login":"unepwcmc","id":513080,"avatar_url":"https://avatars.githubusercontent.com/u/513080?v=2","gravatar_id":"","url":"https://api.github.com/users/unepwcmc","html_url":"https://github.com/unepwcmc","followers_url":"https://api.github.com/users/unepwcmc/followers","following_url":"https://api.github.com/users/unepwcmc/following{/other_user}","gists_url":"https://api.github.com/users/unepwcmc/gists{/gist_id}","starred_url":"https://api.github.com/users/unepwcmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unepwcmc/subscriptions","organizations_url":"https://api.github.com/users/unepwcmc/orgs","repos_url":"https://api.github.com/users/unepwcmc/repos","events_url":"https://api.github.com/users/unepwcmc/events{/privacy}","received_events_url":"https://api.github.com/users/unepwcmc/received_events","type":"Organization","site_admin":false},"repo":{"id":4285537,"name":"SAPI","full_name":"unepwcmc/SAPI","owner":{"login":"unepwcmc","id":513080,"avatar_url":"https://avatars.githubusercontent.com/u/513080?v=2","gravatar_id":"","url":"https://api.github.com/users/unepwcmc","html_url":"https://github.com/unepwcmc","followers_url":"https://api.github.com/users/unepwcmc/followers","following_url":"https://api.github.com/users/unepwcmc/following{/other_user}","gists_url":"https://api.github.com/users/unepwcmc/gists{/gist_id}","starred_url":"https://api.github.com/users/unepwcmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unepwcmc/subscriptions","organizations_url":"https://api.github.com/users/unepwcmc/orgs","repos_url":"https://api.github.com/users/unepwcmc/repos","events_url":"https://api.github.com/users/unepwcmc/events{/privacy}","received_events_url":"https://api.github.com/users/unepwcmc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/unepwcmc/SAPI","description":"SAPI","fork":false,"url":"https://api.github.com/repos/unepwcmc/SAPI","forks_url":"https://api.github.com/repos/unepwcmc/SAPI/forks","keys_url":"https://api.github.com/repos/unepwcmc/SAPI/keys{/key_id}","collaborators_url":"https://api.github.com/repos/unepwcmc/SAPI/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/unepwcmc/SAPI/teams","hooks_url":"https://api.github.com/repos/unepwcmc/SAPI/hooks","issue_events_url":"https://api.github.com/repos/unepwcmc/SAPI/issues/events{/number}","events_url":"https://api.github.com/repos/unepwcmc/SAPI/events","assignees_url":"https://api.github.com/repos/unepwcmc/SAPI/assignees{/user}","branches_url":"https://api.github.com/repos/unepwcmc/SAPI/branches{/branch}","tags_url":"https://api.github.com/repos/unepwcmc/SAPI/tags","blobs_url":"https://api.github.com/repos/unepwcmc/SAPI/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/unepwcmc/SAPI/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/unepwcmc/SAPI/git/refs{/sha}","trees_url":"https://api.github.com/repos/unepwcmc/SAPI/git/trees{/sha}","statuses_url":"https://api.github.com/repos/unepwcmc/SAPI/statuses/{sha}","languages_url":"https://api.github.com/repos/unepwcmc/SAPI/languages","stargazers_url":"https://api.github.com/repos/unepwcmc/SAPI/stargazers","contributors_url":"https://api.github.com/repos/unepwcmc/SAPI/contributors","subscribers_url":"https://api.github.com/repos/unepwcmc/SAPI/subscribers","subscription_url":"https://api.github.com/repos/unepwcmc/SAPI/subscription","commits_url":"https://api.github.com/repos/unepwcmc/SAPI/commits{/sha}","git_commits_url":"https://api.github.com/repos/unepwcmc/SAPI/git/commits{/sha}","comments_url":"https://api.github.com/repos/unepwcmc/SAPI/comments{/number}","issue_comment_url":"https://api.github.com/repos/unepwcmc/SAPI/issues/comments/{number}","contents_url":"https://api.github.com/repos/unepwcmc/SAPI/contents/{+path}","compare_url":"https://api.github.com/repos/unepwcmc/SAPI/compare/{base}...{head}","merges_url":"https://api.github.com/repos/unepwcmc/SAPI/merges","archive_url":"https://api.github.com/repos/unepwcmc/SAPI/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/unepwcmc/SAPI/downloads","issues_url":"https://api.github.com/repos/unepwcmc/SAPI/issues{/number}","pulls_url":"https://api.github.com/repos/unepwcmc/SAPI/pulls{/number}","milestones_url":"https://api.github.com/repos/unepwcmc/SAPI/milestones{/number}","notifications_url":"https://api.github.com/repos/unepwcmc/SAPI/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/unepwcmc/SAPI/labels{/name}","releases_url":"https://api.github.com/repos/unepwcmc/SAPI/releases{/id}","created_at":"2012-05-10T14:28:22Z","updated_at":"2014-09-16T15:40:25Z","pushed_at":"2014-10-02T20:51:41Z","git_url":"git://github.com/unepwcmc/SAPI.git","ssh_url":"git@github.com:unepwcmc/SAPI.git","clone_url":"https://github.com/unepwcmc/SAPI.git","svn_url":"https://github.com/unepwcmc/SAPI","homepage":null,"size":217617,"stargazers_count":11,"watchers_count":11,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":6,"forks":2,"open_issues":6,"watchers":11,"default_branch":"master"}},"base":{"label":"unepwcmc:nomenclature_changes","ref":"nomenclature_changes","sha":"099dfe015c622b86bebf439dd387d8531f07e47c","user":{"login":"unepwcmc","id":513080,"avatar_url":"https://avatars.githubusercontent.com/u/513080?v=2","gravatar_id":"","url":"https://api.github.com/users/unepwcmc","html_url":"https://github.com/unepwcmc","followers_url":"https://api.github.com/users/unepwcmc/followers","following_url":"https://api.github.com/users/unepwcmc/following{/other_user}","gists_url":"https://api.github.com/users/unepwcmc/gists{/gist_id}","starred_url":"https://api.github.com/users/unepwcmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unepwcmc/subscriptions","organizations_url":"https://api.github.com/users/unepwcmc/orgs","repos_url":"https://api.github.com/users/unepwcmc/repos","events_url":"https://api.github.com/users/unepwcmc/events{/privacy}","received_events_url":"https://api.github.com/users/unepwcmc/received_events","type":"Organization","site_admin":false},"repo":{"id":4285537,"name":"SAPI","full_name":"unepwcmc/SAPI","owner":{"login":"unepwcmc","id":513080,"avatar_url":"https://avatars.githubusercontent.com/u/513080?v=2","gravatar_id":"","url":"https://api.github.com/users/unepwcmc","html_url":"https://github.com/unepwcmc","followers_url":"https://api.github.com/users/unepwcmc/followers","following_url":"https://api.github.com/users/unepwcmc/following{/other_user}","gists_url":"https://api.github.com/users/unepwcmc/gists{/gist_id}","starred_url":"https://api.github.com/users/unepwcmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unepwcmc/subscriptions","organizations_url":"https://api.github.com/users/unepwcmc/orgs","repos_url":"https://api.github.com/users/unepwcmc/repos","events_url":"https://api.github.com/users/unepwcmc/events{/privacy}","received_events_url":"https://api.github.com/users/unepwcmc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/unepwcmc/SAPI","description":"SAPI","fork":false,"url":"https://api.github.com/repos/unepwcmc/SAPI","forks_url":"https://api.github.com/repos/unepwcmc/SAPI/forks","keys_url":"https://api.github.com/repos/unepwcmc/SAPI/keys{/key_id}","collaborators_url":"https://api.github.com/repos/unepwcmc/SAPI/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/unepwcmc/SAPI/teams","hooks_url":"https://api.github.com/repos/unepwcmc/SAPI/hooks","issue_events_url":"https://api.github.com/repos/unepwcmc/SAPI/issues/events{/number}","events_url":"https://api.github.com/repos/unepwcmc/SAPI/events","assignees_url":"https://api.github.com/repos/unepwcmc/SAPI/assignees{/user}","branches_url":"https://api.github.com/repos/unepwcmc/SAPI/branches{/branch}","tags_url":"https://api.github.com/repos/unepwcmc/SAPI/tags","blobs_url":"https://api.github.com/repos/unepwcmc/SAPI/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/unepwcmc/SAPI/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/unepwcmc/SAPI/git/refs{/sha}","trees_url":"https://api.github.com/repos/unepwcmc/SAPI/git/trees{/sha}","statuses_url":"https://api.github.com/repos/unepwcmc/SAPI/statuses/{sha}","languages_url":"https://api.github.com/repos/unepwcmc/SAPI/languages","stargazers_url":"https://api.github.com/repos/unepwcmc/SAPI/stargazers","contributors_url":"https://api.github.com/repos/unepwcmc/SAPI/contributors","subscribers_url":"https://api.github.com/repos/unepwcmc/SAPI/subscribers","subscription_url":"https://api.github.com/repos/unepwcmc/SAPI/subscription","commits_url":"https://api.github.com/repos/unepwcmc/SAPI/commits{/sha}","git_commits_url":"https://api.github.com/repos/unepwcmc/SAPI/git/commits{/sha}","comments_url":"https://api.github.com/repos/unepwcmc/SAPI/comments{/number}","issue_comment_url":"https://api.github.com/repos/unepwcmc/SAPI/issues/comments/{number}","contents_url":"https://api.github.com/repos/unepwcmc/SAPI/contents/{+path}","compare_url":"https://api.github.com/repos/unepwcmc/SAPI/compare/{base}...{head}","merges_url":"https://api.github.com/repos/unepwcmc/SAPI/merges","archive_url":"https://api.github.com/repos/unepwcmc/SAPI/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/unepwcmc/SAPI/downloads","issues_url":"https://api.github.com/repos/unepwcmc/SAPI/issues{/number}","pulls_url":"https://api.github.com/repos/unepwcmc/SAPI/pulls{/number}","milestones_url":"https://api.github.com/repos/unepwcmc/SAPI/milestones{/number}","notifications_url":"https://api.github.com/repos/unepwcmc/SAPI/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/unepwcmc/SAPI/labels{/name}","releases_url":"https://api.github.com/repos/unepwcmc/SAPI/releases{/id}","created_at":"2012-05-10T14:28:22Z","updated_at":"2014-09-16T15:40:25Z","pushed_at":"2014-10-02T20:51:41Z","git_url":"git://github.com/unepwcmc/SAPI.git","ssh_url":"git@github.com:unepwcmc/SAPI.git","clone_url":"https://github.com/unepwcmc/SAPI.git","svn_url":"https://github.com/unepwcmc/SAPI","homepage":null,"size":217617,"stargazers_count":11,"watchers_count":11,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":6,"forks":2,"open_issues":6,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/unepwcmc/SAPI/pulls/396"},"html":{"href":"https://github.com/unepwcmc/SAPI/pull/396"},"issue":{"href":"https://api.github.com/repos/unepwcmc/SAPI/issues/396"},"comments":{"href":"https://api.github.com/repos/unepwcmc/SAPI/issues/396/comments"},"review_comments":{"href":"https://api.github.com/repos/unepwcmc/SAPI/pulls/396/comments"},"review_comment":{"href":"https://api.github.com/repos/unepwcmc/SAPI/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/unepwcmc/SAPI/pulls/396/commits"},"statuses":{"href":"https://api.github.com/repos/unepwcmc/SAPI/statuses/1b4a785d25091e4ee2e73ed3a892ab1ef9597982"}}}}