GitHub PullRequestEvent at 2014-10-13 19:44:41
Repository: enyo
Actor: dmikey
Payload: {"action":"opened","number":880,"pull_request":{"url":"https://api.github.com/repos/enyojs/enyo/pulls/880","id":22667636,"html_url":"https://github.com/enyojs/enyo/pull/880","diff_url":"https://github.com/enyojs/enyo/pull/880.diff","patch_url":"https://github.com/enyojs/enyo/pull/880.patch","issue_url":"https://api.github.com/repos/enyojs/enyo/issues/880","number":880,"state":"open","locked":false,"title":"Bhv 5129 derekanderson","user":{"login":"dmikey","id":328000,"avatar_url":"https://avatars.githubusercontent.com/u/328000?v=2","gravatar_id":"","url":"https://api.github.com/users/dmikey","html_url":"https://github.com/dmikey","followers_url":"https://api.github.com/users/dmikey/followers","following_url":"https://api.github.com/users/dmikey/following{/other_user}","gists_url":"https://api.github.com/users/dmikey/gists{/gist_id}","starred_url":"https://api.github.com/users/dmikey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmikey/subscriptions","organizations_url":"https://api.github.com/users/dmikey/orgs","repos_url":"https://api.github.com/users/dmikey/repos","events_url":"https://api.github.com/users/dmikey/events{/privacy}","received_events_url":"https://api.github.com/users/dmikey/received_events","type":"User","site_admin":false},"body":"Added two new events BeforeShow and BeforeHide to ensure that implementations that already expect Show and Hide to be called after the popup state is altered.\r\n\r\nMoved original showingChanged code into showHideMethod. Modified showingChanged to call showHideEvent (which was moved out of the original showingChanged method) before and after calling showHideMethod.\r\n\r\nThis PR doesn't alter the current ability for the chain to be called, but needs to go in before moonstone or onyx, to ensure that showHideMethod is called when needed.\r\n\r\nEnyo-DCO-1.1-Signed-off-by: Derek Anderson <derek.anderson@lge.com>","created_at":"2014-10-13T19:44:39Z","updated_at":"2014-10-13T19:44:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/enyojs/enyo/pulls/880/commits","review_comments_url":"https://api.github.com/repos/enyojs/enyo/pulls/880/comments","review_comment_url":"https://api.github.com/repos/enyojs/enyo/pulls/comments/{number}","comments_url":"https://api.github.com/repos/enyojs/enyo/issues/880/comments","statuses_url":"https://api.github.com/repos/enyojs/enyo/statuses/c37ca10a52be00354f1b82d8d8a0ff1ead316761","head":{"label":"enyojs:BHV-5129-derekanderson","ref":"BHV-5129-derekanderson","sha":"c37ca10a52be00354f1b82d8d8a0ff1ead316761","user":{"login":"enyojs","id":1266337,"avatar_url":"https://avatars.githubusercontent.com/u/1266337?v=2","gravatar_id":"","url":"https://api.github.com/users/enyojs","html_url":"https://github.com/enyojs","followers_url":"https://api.github.com/users/enyojs/followers","following_url":"https://api.github.com/users/enyojs/following{/other_user}","gists_url":"https://api.github.com/users/enyojs/gists{/gist_id}","starred_url":"https://api.github.com/users/enyojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enyojs/subscriptions","organizations_url":"https://api.github.com/users/enyojs/orgs","repos_url":"https://api.github.com/users/enyojs/repos","events_url":"https://api.github.com/users/enyojs/events{/privacy}","received_events_url":"https://api.github.com/users/enyojs/received_events","type":"Organization","site_admin":false},"repo":{"id":2983241,"name":"enyo","full_name":"enyojs/enyo","owner":{"login":"enyojs","id":1266337,"avatar_url":"https://avatars.githubusercontent.com/u/1266337?v=2","gravatar_id":"","url":"https://api.github.com/users/enyojs","html_url":"https://github.com/enyojs","followers_url":"https://api.github.com/users/enyojs/followers","following_url":"https://api.github.com/users/enyojs/following{/other_user}","gists_url":"https://api.github.com/users/enyojs/gists{/gist_id}","starred_url":"https://api.github.com/users/enyojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enyojs/subscriptions","organizations_url":"https://api.github.com/users/enyojs/orgs","repos_url":"https://api.github.com/users/enyojs/repos","events_url":"https://api.github.com/users/enyojs/events{/privacy}","received_events_url":"https://api.github.com/users/enyojs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/enyojs/enyo","description":"A JavaScript application framework emphasizing modularity and encapsulation","fork":false,"url":"https://api.github.com/repos/enyojs/enyo","forks_url":"https://api.github.com/repos/enyojs/enyo/forks","keys_url":"https://api.github.com/repos/enyojs/enyo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/enyojs/enyo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/enyojs/enyo/teams","hooks_url":"https://api.github.com/repos/enyojs/enyo/hooks","issue_events_url":"https://api.github.com/repos/enyojs/enyo/issues/events{/number}","events_url":"https://api.github.com/repos/enyojs/enyo/events","assignees_url":"https://api.github.com/repos/enyojs/enyo/assignees{/user}","branches_url":"https://api.github.com/repos/enyojs/enyo/branches{/branch}","tags_url":"https://api.github.com/repos/enyojs/enyo/tags","blobs_url":"https://api.github.com/repos/enyojs/enyo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/enyojs/enyo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/enyojs/enyo/git/refs{/sha}","trees_url":"https://api.github.com/repos/enyojs/enyo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/enyojs/enyo/statuses/{sha}","languages_url":"https://api.github.com/repos/enyojs/enyo/languages","stargazers_url":"https://api.github.com/repos/enyojs/enyo/stargazers","contributors_url":"https://api.github.com/repos/enyojs/enyo/contributors","subscribers_url":"https://api.github.com/repos/enyojs/enyo/subscribers","subscription_url":"https://api.github.com/repos/enyojs/enyo/subscription","commits_url":"https://api.github.com/repos/enyojs/enyo/commits{/sha}","git_commits_url":"https://api.github.com/repos/enyojs/enyo/git/commits{/sha}","comments_url":"https://api.github.com/repos/enyojs/enyo/comments{/number}","issue_comment_url":"https://api.github.com/repos/enyojs/enyo/issues/comments/{number}","contents_url":"https://api.github.com/repos/enyojs/enyo/contents/{+path}","compare_url":"https://api.github.com/repos/enyojs/enyo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/enyojs/enyo/merges","archive_url":"https://api.github.com/repos/enyojs/enyo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/enyojs/enyo/downloads","issues_url":"https://api.github.com/repos/enyojs/enyo/issues{/number}","pulls_url":"https://api.github.com/repos/enyojs/enyo/pulls{/number}","milestones_url":"https://api.github.com/repos/enyojs/enyo/milestones{/number}","notifications_url":"https://api.github.com/repos/enyojs/enyo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/enyojs/enyo/labels{/name}","releases_url":"https://api.github.com/repos/enyojs/enyo/releases{/id}","created_at":"2011-12-14T21:30:25Z","updated_at":"2014-09-29T12:26:24Z","pushed_at":"2014-10-13T19:38:19Z","git_url":"git://github.com/enyojs/enyo.git","ssh_url":"git@github.com:enyojs/enyo.git","clone_url":"https://github.com/enyojs/enyo.git","svn_url":"https://github.com/enyojs/enyo","homepage":"","size":44489,"stargazers_count":1777,"watchers_count":1777,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":276,"mirror_url":null,"open_issues_count":42,"forks":276,"open_issues":42,"watchers":1777,"default_branch":"master"}},"base":{"label":"enyojs:master","ref":"master","sha":"b0fffe569bc0a21eafcf167f55a956a78e2530d6","user":{"login":"enyojs","id":1266337,"avatar_url":"https://avatars.githubusercontent.com/u/1266337?v=2","gravatar_id":"","url":"https://api.github.com/users/enyojs","html_url":"https://github.com/enyojs","followers_url":"https://api.github.com/users/enyojs/followers","following_url":"https://api.github.com/users/enyojs/following{/other_user}","gists_url":"https://api.github.com/users/enyojs/gists{/gist_id}","starred_url":"https://api.github.com/users/enyojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enyojs/subscriptions","organizations_url":"https://api.github.com/users/enyojs/orgs","repos_url":"https://api.github.com/users/enyojs/repos","events_url":"https://api.github.com/users/enyojs/events{/privacy}","received_events_url":"https://api.github.com/users/enyojs/received_events","type":"Organization","site_admin":false},"repo":{"id":2983241,"name":"enyo","full_name":"enyojs/enyo","owner":{"login":"enyojs","id":1266337,"avatar_url":"https://avatars.githubusercontent.com/u/1266337?v=2","gravatar_id":"","url":"https://api.github.com/users/enyojs","html_url":"https://github.com/enyojs","followers_url":"https://api.github.com/users/enyojs/followers","following_url":"https://api.github.com/users/enyojs/following{/other_user}","gists_url":"https://api.github.com/users/enyojs/gists{/gist_id}","starred_url":"https://api.github.com/users/enyojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enyojs/subscriptions","organizations_url":"https://api.github.com/users/enyojs/orgs","repos_url":"https://api.github.com/users/enyojs/repos","events_url":"https://api.github.com/users/enyojs/events{/privacy}","received_events_url":"https://api.github.com/users/enyojs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/enyojs/enyo","description":"A JavaScript application framework emphasizing modularity and encapsulation","fork":false,"url":"https://api.github.com/repos/enyojs/enyo","forks_url":"https://api.github.com/repos/enyojs/enyo/forks","keys_url":"https://api.github.com/repos/enyojs/enyo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/enyojs/enyo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/enyojs/enyo/teams","hooks_url":"https://api.github.com/repos/enyojs/enyo/hooks","issue_events_url":"https://api.github.com/repos/enyojs/enyo/issues/events{/number}","events_url":"https://api.github.com/repos/enyojs/enyo/events","assignees_url":"https://api.github.com/repos/enyojs/enyo/assignees{/user}","branches_url":"https://api.github.com/repos/enyojs/enyo/branches{/branch}","tags_url":"https://api.github.com/repos/enyojs/enyo/tags","blobs_url":"https://api.github.com/repos/enyojs/enyo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/enyojs/enyo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/enyojs/enyo/git/refs{/sha}","trees_url":"https://api.github.com/repos/enyojs/enyo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/enyojs/enyo/statuses/{sha}","languages_url":"https://api.github.com/repos/enyojs/enyo/languages","stargazers_url":"https://api.github.com/repos/enyojs/enyo/stargazers","contributors_url":"https://api.github.com/repos/enyojs/enyo/contributors","subscribers_url":"https://api.github.com/repos/enyojs/enyo/subscribers","subscription_url":"https://api.github.com/repos/enyojs/enyo/subscription","commits_url":"https://api.github.com/repos/enyojs/enyo/commits{/sha}","git_commits_url":"https://api.github.com/repos/enyojs/enyo/git/commits{/sha}","comments_url":"https://api.github.com/repos/enyojs/enyo/comments{/number}","issue_comment_url":"https://api.github.com/repos/enyojs/enyo/issues/comments/{number}","contents_url":"https://api.github.com/repos/enyojs/enyo/contents/{+path}","compare_url":"https://api.github.com/repos/enyojs/enyo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/enyojs/enyo/merges","archive_url":"https://api.github.com/repos/enyojs/enyo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/enyojs/enyo/downloads","issues_url":"https://api.github.com/repos/enyojs/enyo/issues{/number}","pulls_url":"https://api.github.com/repos/enyojs/enyo/pulls{/number}","milestones_url":"https://api.github.com/repos/enyojs/enyo/milestones{/number}","notifications_url":"https://api.github.com/repos/enyojs/enyo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/enyojs/enyo/labels{/name}","releases_url":"https://api.github.com/repos/enyojs/enyo/releases{/id}","created_at":"2011-12-14T21:30:25Z","updated_at":"2014-09-29T12:26:24Z","pushed_at":"2014-10-13T19:38:19Z","git_url":"git://github.com/enyojs/enyo.git","ssh_url":"git@github.com:enyojs/enyo.git","clone_url":"https://github.com/enyojs/enyo.git","svn_url":"https://github.com/enyojs/enyo","homepage":"","size":44489,"stargazers_count":1777,"watchers_count":1777,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":276,"mirror_url":null,"open_issues_count":42,"forks":276,"open_issues":42,"watchers":1777,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/enyojs/enyo/pulls/880"},"html":{"href":"https://github.com/enyojs/enyo/pull/880"},"issue":{"href":"https://api.github.com/repos/enyojs/enyo/issues/880"},"comments":{"href":"https://api.github.com/repos/enyojs/enyo/issues/880/comments"},"review_comments":{"href":"https://api.github.com/repos/enyojs/enyo/pulls/880/comments"},"review_comment":{"href":"https://api.github.com/repos/enyojs/enyo/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/enyojs/enyo/pulls/880/commits"},"statuses":{"href":"https://api.github.com/repos/enyojs/enyo/statuses/c37ca10a52be00354f1b82d8d8a0ff1ead316761"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":35,"deletions":9,"changed_files":1}}