GitHub PullRequestReviewCommentEvent at 2014-02-19 21:48:33
Repository: community-builds
Actor: retronym
Payload: {"comment":{"url":"https://api.github.com/repos/retronym/community-builds/pulls/comments/9885078","id":9885078,"diff_hunk":"@@ -71,21 +71,58 @@ build.projects:[\n     ]\n   }\n \n+  {\n+    name: \"scala-continuations\"\n+    uri: \"git://github.com/scala/scala-continuations.git\"\n+    extra.sbt-version: \"0.13.1\"\n+    // workaround for NPE in continuations plugin:\n+    // java.lang.NullPointerException\n+    //    at scala.tools.nsc.transform.Mixin$MixinTransformer.scala$tools$nsc$transform$Mixin$MixinTransformer$$postTransform(Mixin.scala:1127)\n+    //    at scala.tools.nsc.transform.Mixin$MixinTransformer$$anonfun$transform$1.apply(Mixin.scala:1234)\n+    //    at scala.tools.nsc.transform.Mixin$MixinTransformer$$anonfun$transform$1.apply(Mixin.scala:1234)\n+    extra.run-tests: false\n+  }\n+\n \n-//  {\n-//    name: \"Play2-core\",\n-//    uri: \"git://github.com/playframework/Play20.git\",\n-//    extra: {\n-//      projects: [\"Play\"]\n-//                directory: \"framework\"\n-//    }\n-//    extra.sbt-version: \"0.13.0\"\n-//  }\n-//  {\n-//    name: \"scala-io\"\n-//    uri: \"git://github.com/scala-incubator/scala-io.git#2.10.x\"\n-//    extra.sbt-version: \"0.11.3\"\n-//  }\n+  {\n+    name: \"Play2-core\",\n+    uri: \"git://github.com/gkossakowski/playframework.git#scala-2.11\",\n+    extra: {\n+      projects: [\"Play\"]\n+      directory: \"framework\"\n+      run-tests: false\n+      commands: [\n+        // workaround for the problem with PlayVersion.scala file is being passed twice to Scala compiler\n+        // and we get double definition error\n+        \"set sources in (PlayProject, Compile, compile) := (sources in (PlayProject, Compile, compile)).value.distinct\"\n+      ]\n+    }\n+    extra.sbt-version: \"0.13.1\"\n+  }\n+  {\n+    name: \"scala-io\"\n+    // my own fork:\n+    // 1. disables building of scaladoc docs (due to regression in scaladoc)\n+    // 2. adds dependency on scala-parser-combinators","path":"community-2.11.x.dbuild","position":50,"original_position":50,"commit_id":"61e6c06b0a4c273260c3e5f7003af960ebb1b6d3","original_commit_id":"61e6c06b0a4c273260c3e5f7003af960ebb1b6d3","user":{"login":"retronym","id":65551,"avatar_url":"https://gravatar.com/avatar/5df8faf17a57ccab478a9b8056862fc3?d=https%3A%2F%2Fidenticons.github.com%2F75e4dffe50001cf8b96d3beecbe181be.png&r=x","gravatar_id":"5df8faf17a57ccab478a9b8056862fc3","url":"https://api.github.com/users/retronym","html_url":"https://github.com/retronym","followers_url":"https://api.github.com/users/retronym/followers","following_url":"https://api.github.com/users/retronym/following{/other_user}","gists_url":"https://api.github.com/users/retronym/gists{/gist_id}","starred_url":"https://api.github.com/users/retronym/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/retronym/subscriptions","organizations_url":"https://api.github.com/users/retronym/orgs","repos_url":"https://api.github.com/users/retronym/repos","events_url":"https://api.github.com/users/retronym/events{/privacy}","received_events_url":"https://api.github.com/users/retronym/received_events","type":"User","site_admin":false},"body":"FYI, one can do this with `extra.commands: [\"set libraryDependencies +=...\"`. But if you have to fork for other reasons, it doesn't help.","created_at":"2014-02-19T21:48:33Z","updated_at":"2014-02-19T21:48:33Z","html_url":"https://github.com/retronym/community-builds/pull/4#discussion_r9885078","pull_request_url":"https://api.github.com/repos/retronym/community-builds/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/retronym/community-builds/pulls/comments/9885078"},"html":{"href":"https://github.com/retronym/community-builds/pull/4#discussion_r9885078"},"pull_request":{"href":"https://api.github.com/repos/retronym/community-builds/pulls/4"}}}}