GitHub PullRequestEvent at 2014-08-08 06:33:56
Repository: java-client
Actor: Jonahss
Payload: {"action":"closed","number":84,"pull_request":{"url":"https://api.github.com/repos/appium/java-client/pulls/84","id":19490091,"html_url":"https://github.com/appium/java-client/pull/84","diff_url":"https://github.com/appium/java-client/pull/84.diff","patch_url":"https://github.com/appium/java-client/pull/84.patch","issue_url":"https://api.github.com/repos/appium/java-client/issues/84","number":84,"state":"closed","title":"Page factory. Fixes","user":{"login":"TikhomirovSergey","id":4927589,"avatar_url":"https://avatars.githubusercontent.com/u/4927589?v=2","gravatar_id":"a4a2c6007fbc3e394667d4387736cf5a","url":"https://api.github.com/users/TikhomirovSergey","html_url":"https://github.com/TikhomirovSergey","followers_url":"https://api.github.com/users/TikhomirovSergey/followers","following_url":"https://api.github.com/users/TikhomirovSergey/following{/other_user}","gists_url":"https://api.github.com/users/TikhomirovSergey/gists{/gist_id}","starred_url":"https://api.github.com/users/TikhomirovSergey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TikhomirovSergey/subscriptions","organizations_url":"https://api.github.com/users/TikhomirovSergey/orgs","repos_url":"https://api.github.com/users/TikhomirovSergey/repos","events_url":"https://api.github.com/users/TikhomirovSergey/events{/privacy}","received_events_url":"https://api.github.com/users/TikhomirovSergey/received_events","type":"User","site_admin":false},"body":"There is a bug which I found yesterday. Here is the way to reproduce it:\r\n\r\n```java\r\n//declaration\r\n@FindByAnnotation\r\n//It is not reproduced when RemoteWebElement or MobileElement are declared instead of\r\nWebElement someElement; \r\n\r\n\r\n//Populate\r\nPageFactory.initElements(new AppiumFieldDecorator(driver), pageObjectInstance); //or something like this\r\n\r\n\r\n//execution\r\n((JavascriptExecutor) driver).executeScript(\"someScript\", someElement);\r\n```\r\n\r\nException\r\n```java\r\nFAILED: androidHybridAppTest\r\njava.lang.IllegalArgumentException: Argument is of an illegal type: org.openqa.selenium.WebElement$$EnhancerByCGLIB$$eedfaea9\r\n\tat org.openqa.selenium.remote.internal.WebElementToJsonConverter.apply(WebElementToJsonConverter.java:78)\r\n\tat com.google.common.collect.Iterators$8.transform(Iterators.java:794)\r\n\tat com.google.common.collect.TransformedIterator.next(TransformedIterator.java:48)\r\n\tat com.google.common.collect.Iterators.addAll(Iterators.java:357)\r\n\tat com.google.common.collect.Lists.newArrayList(Lists.java:147)\r\n\tat com.google.common.collect.Lists.newArrayList(Lists.java:129)\r\n\tat org.openqa.selenium.remote.RemoteWebDriver.executeScript(RemoteWebDriver.java:504)\r\n\tat org.openqa.selenium.remote.RemoteWebDriver$$FastClassBySpringCGLIB$$589f8ff4.invoke(<generated>)\r\n\tat org.springframework.cglib.proxy.MethodProxy.invoke(MethodProxy.java:204)\r\n\tat org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.invokeJoinpoint(CglibAopProxy.java:708)\r\n\tat org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:157)\r\n\tat org.springframework.aop.aspectj.MethodInvocationProceedingJoinPoint.proceed(MethodInvocationProceedingJoinPoint.java:85)\r\n\tat org.arachnidium.core.beans.webdriver.AspectWebDriverEventListener.doAround(AspectWebDriverEventListener.java:455)\r\n\tat sun.reflect.GeneratedMethodAccessor14.invoke(Unknown Source)\r\n\tat sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)\r\n\tat java.lang.reflect.Method.invoke(Unknown Source)\r\n\tat org.springframework.aop.aspectj.AbstractAspectJAdvice.invokeAdviceMethodWithGivenArgs(AbstractAspectJAdvice.java:621)\r\n\tat org.springframework.aop.aspectj.AbstractAspectJAdvice.invokeAdviceMethod(AbstractAspectJAdvice.java:610)\r\n\tat org.springframework.aop.aspectj.AspectJAroundAdvice.invoke(AspectJAroundAdvice.java:68)\r\n\tat org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:179)\r\n\tat org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:92)\r\n\tat org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:179)\r\n\tat org.springframework.aop.framework.CglibAopProxy$DynamicAdvisedInterceptor.intercept(CglibAopProxy.java:644)\r\n\tat io.appium.java_client.AppiumDriver$$EnhancerBySpringCGLIB$$26800e50.executeScript(<generated>)\r\n....\r\n```\r\n\r\nI attempted to execute javaScript (hybrid Android application). \r\n\r\nI fixed an issue that was found by by @prattpratt. See comments here: c912100#commitcomment-7202750 ","created_at":"2014-08-07T19:51:50Z","updated_at":"2014-08-08T06:33:56Z","closed_at":"2014-08-08T06:33:56Z","merged_at":"2014-08-08T06:33:56Z","merge_commit_sha":"a1745a7d3ab5fad72bea30b10679941445c7f10f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/appium/java-client/pulls/84/commits","review_comments_url":"https://api.github.com/repos/appium/java-client/pulls/84/comments","review_comment_url":"https://api.github.com/repos/appium/java-client/pulls/comments/{number}","comments_url":"https://api.github.com/repos/appium/java-client/issues/84/comments","statuses_url":"https://api.github.com/repos/appium/java-client/statuses/fe34ab14160224c50bce1dd427b75cfffd55fdc7","head":{"label":"TikhomirovSergey:master","ref":"master","sha":"fe34ab14160224c50bce1dd427b75cfffd55fdc7","user":{"login":"TikhomirovSergey","id":4927589,"avatar_url":"https://avatars.githubusercontent.com/u/4927589?v=2","gravatar_id":"a4a2c6007fbc3e394667d4387736cf5a","url":"https://api.github.com/users/TikhomirovSergey","html_url":"https://github.com/TikhomirovSergey","followers_url":"https://api.github.com/users/TikhomirovSergey/followers","following_url":"https://api.github.com/users/TikhomirovSergey/following{/other_user}","gists_url":"https://api.github.com/users/TikhomirovSergey/gists{/gist_id}","starred_url":"https://api.github.com/users/TikhomirovSergey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TikhomirovSergey/subscriptions","organizations_url":"https://api.github.com/users/TikhomirovSergey/orgs","repos_url":"https://api.github.com/users/TikhomirovSergey/repos","events_url":"https://api.github.com/users/TikhomirovSergey/events{/privacy}","received_events_url":"https://api.github.com/users/TikhomirovSergey/received_events","type":"User","site_admin":false},"repo":{"id":22731958,"name":"java-client","full_name":"TikhomirovSergey/java-client","owner":{"login":"TikhomirovSergey","id":4927589,"avatar_url":"https://avatars.githubusercontent.com/u/4927589?v=2","gravatar_id":"a4a2c6007fbc3e394667d4387736cf5a","url":"https://api.github.com/users/TikhomirovSergey","html_url":"https://github.com/TikhomirovSergey","followers_url":"https://api.github.com/users/TikhomirovSergey/followers","following_url":"https://api.github.com/users/TikhomirovSergey/following{/other_user}","gists_url":"https://api.github.com/users/TikhomirovSergey/gists{/gist_id}","starred_url":"https://api.github.com/users/TikhomirovSergey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TikhomirovSergey/subscriptions","organizations_url":"https://api.github.com/users/TikhomirovSergey/orgs","repos_url":"https://api.github.com/users/TikhomirovSergey/repos","events_url":"https://api.github.com/users/TikhomirovSergey/events{/privacy}","received_events_url":"https://api.github.com/users/TikhomirovSergey/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TikhomirovSergey/java-client","description":"Java language binding for writing Appium Tests, conforms to Mobile JSON Wire Protocol","fork":true,"url":"https://api.github.com/repos/TikhomirovSergey/java-client","forks_url":"https://api.github.com/repos/TikhomirovSergey/java-client/forks","keys_url":"https://api.github.com/repos/TikhomirovSergey/java-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TikhomirovSergey/java-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TikhomirovSergey/java-client/teams","hooks_url":"https://api.github.com/repos/TikhomirovSergey/java-client/hooks","issue_events_url":"https://api.github.com/repos/TikhomirovSergey/java-client/issues/events{/number}","events_url":"https://api.github.com/repos/TikhomirovSergey/java-client/events","assignees_url":"https://api.github.com/repos/TikhomirovSergey/java-client/assignees{/user}","branches_url":"https://api.github.com/repos/TikhomirovSergey/java-client/branches{/branch}","tags_url":"https://api.github.com/repos/TikhomirovSergey/java-client/tags","blobs_url":"https://api.github.com/repos/TikhomirovSergey/java-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TikhomirovSergey/java-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TikhomirovSergey/java-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/TikhomirovSergey/java-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TikhomirovSergey/java-client/statuses/{sha}","languages_url":"https://api.github.com/repos/TikhomirovSergey/java-client/languages","stargazers_url":"https://api.github.com/repos/TikhomirovSergey/java-client/stargazers","contributors_url":"https://api.github.com/repos/TikhomirovSergey/java-client/contributors","subscribers_url":"https://api.github.com/repos/TikhomirovSergey/java-client/subscribers","subscription_url":"https://api.github.com/repos/TikhomirovSergey/java-client/subscription","commits_url":"https://api.github.com/repos/TikhomirovSergey/java-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/TikhomirovSergey/java-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/TikhomirovSergey/java-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/TikhomirovSergey/java-client/issues/comments/{number}","contents_url":"https://api.github.com/repos/TikhomirovSergey/java-client/contents/{+path}","compare_url":"https://api.github.com/repos/TikhomirovSergey/java-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TikhomirovSergey/java-client/merges","archive_url":"https://api.github.com/repos/TikhomirovSergey/java-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TikhomirovSergey/java-client/downloads","issues_url":"https://api.github.com/repos/TikhomirovSergey/java-client/issues{/number}","pulls_url":"https://api.github.com/repos/TikhomirovSergey/java-client/pulls{/number}","milestones_url":"https://api.github.com/repos/TikhomirovSergey/java-client/milestones{/number}","notifications_url":"https://api.github.com/repos/TikhomirovSergey/java-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TikhomirovSergey/java-client/labels{/name}","releases_url":"https://api.github.com/repos/TikhomirovSergey/java-client/releases{/id}","created_at":"2014-08-07T18:32:06Z","updated_at":"2014-08-07T19:38:55Z","pushed_at":"2014-08-07T19:38:56Z","git_url":"git://github.com/TikhomirovSergey/java-client.git","ssh_url":"git@github.com:TikhomirovSergey/java-client.git","clone_url":"https://github.com/TikhomirovSergey/java-client.git","svn_url":"https://github.com/TikhomirovSergey/java-client","homepage":null,"size":15781,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"appium:master","ref":"master","sha":"fd3cce86f4bb3a4894a53a31753293b54d19da76","user":{"login":"appium","id":3221291,"avatar_url":"https://avatars.githubusercontent.com/u/3221291?v=2","gravatar_id":"7ab26affefa889f08bab500702ec16d8","url":"https://api.github.com/users/appium","html_url":"https://github.com/appium","followers_url":"https://api.github.com/users/appium/followers","following_url":"https://api.github.com/users/appium/following{/other_user}","gists_url":"https://api.github.com/users/appium/gists{/gist_id}","starred_url":"https://api.github.com/users/appium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appium/subscriptions","organizations_url":"https://api.github.com/users/appium/orgs","repos_url":"https://api.github.com/users/appium/repos","events_url":"https://api.github.com/users/appium/events{/privacy}","received_events_url":"https://api.github.com/users/appium/received_events","type":"Organization","site_admin":false},"repo":{"id":18454064,"name":"java-client","full_name":"appium/java-client","owner":{"login":"appium","id":3221291,"avatar_url":"https://avatars.githubusercontent.com/u/3221291?v=2","gravatar_id":"7ab26affefa889f08bab500702ec16d8","url":"https://api.github.com/users/appium","html_url":"https://github.com/appium","followers_url":"https://api.github.com/users/appium/followers","following_url":"https://api.github.com/users/appium/following{/other_user}","gists_url":"https://api.github.com/users/appium/gists{/gist_id}","starred_url":"https://api.github.com/users/appium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appium/subscriptions","organizations_url":"https://api.github.com/users/appium/orgs","repos_url":"https://api.github.com/users/appium/repos","events_url":"https://api.github.com/users/appium/events{/privacy}","received_events_url":"https://api.github.com/users/appium/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/appium/java-client","description":"Java language binding for writing Appium Tests, conforms to Mobile JSON Wire Protocol","fork":false,"url":"https://api.github.com/repos/appium/java-client","forks_url":"https://api.github.com/repos/appium/java-client/forks","keys_url":"https://api.github.com/repos/appium/java-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/appium/java-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/appium/java-client/teams","hooks_url":"https://api.github.com/repos/appium/java-client/hooks","issue_events_url":"https://api.github.com/repos/appium/java-client/issues/events{/number}","events_url":"https://api.github.com/repos/appium/java-client/events","assignees_url":"https://api.github.com/repos/appium/java-client/assignees{/user}","branches_url":"https://api.github.com/repos/appium/java-client/branches{/branch}","tags_url":"https://api.github.com/repos/appium/java-client/tags","blobs_url":"https://api.github.com/repos/appium/java-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/appium/java-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/appium/java-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/appium/java-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/appium/java-client/statuses/{sha}","languages_url":"https://api.github.com/repos/appium/java-client/languages","stargazers_url":"https://api.github.com/repos/appium/java-client/stargazers","contributors_url":"https://api.github.com/repos/appium/java-client/contributors","subscribers_url":"https://api.github.com/repos/appium/java-client/subscribers","subscription_url":"https://api.github.com/repos/appium/java-client/subscription","commits_url":"https://api.github.com/repos/appium/java-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/appium/java-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/appium/java-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/appium/java-client/issues/comments/{number}","contents_url":"https://api.github.com/repos/appium/java-client/contents/{+path}","compare_url":"https://api.github.com/repos/appium/java-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/appium/java-client/merges","archive_url":"https://api.github.com/repos/appium/java-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/appium/java-client/downloads","issues_url":"https://api.github.com/repos/appium/java-client/issues{/number}","pulls_url":"https://api.github.com/repos/appium/java-client/pulls{/number}","milestones_url":"https://api.github.com/repos/appium/java-client/milestones{/number}","notifications_url":"https://api.github.com/repos/appium/java-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/appium/java-client/labels{/name}","releases_url":"https://api.github.com/repos/appium/java-client/releases{/id}","created_at":"2014-04-04T22:05:23Z","updated_at":"2014-08-06T16:32:14Z","pushed_at":"2014-08-08T06:33:56Z","git_url":"git://github.com/appium/java-client.git","ssh_url":"git@github.com:appium/java-client.git","clone_url":"https://github.com/appium/java-client.git","svn_url":"https://github.com/appium/java-client","homepage":null,"size":15781,"stargazers_count":35,"watchers_count":35,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":36,"mirror_url":null,"open_issues_count":15,"forks":36,"open_issues":15,"watchers":35,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/appium/java-client/pulls/84"},"html":{"href":"https://github.com/appium/java-client/pull/84"},"issue":{"href":"https://api.github.com/repos/appium/java-client/issues/84"},"comments":{"href":"https://api.github.com/repos/appium/java-client/issues/84/comments"},"review_comments":{"href":"https://api.github.com/repos/appium/java-client/pulls/84/comments"},"review_comment":{"href":"https://api.github.com/repos/appium/java-client/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/appium/java-client/pulls/84/commits"},"statuses":{"href":"https://api.github.com/repos/appium/java-client/statuses/fe34ab14160224c50bce1dd427b75cfffd55fdc7"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"Jonahss","id":1521841,"avatar_url":"https://avatars.githubusercontent.com/u/1521841?v=2","gravatar_id":"7e7087f7160dbb93badf777a52317f61","url":"https://api.github.com/users/Jonahss","html_url":"https://github.com/Jonahss","followers_url":"https://api.github.com/users/Jonahss/followers","following_url":"https://api.github.com/users/Jonahss/following{/other_user}","gists_url":"https://api.github.com/users/Jonahss/gists{/gist_id}","starred_url":"https://api.github.com/users/Jonahss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jonahss/subscriptions","organizations_url":"https://api.github.com/users/Jonahss/orgs","repos_url":"https://api.github.com/users/Jonahss/repos","events_url":"https://api.github.com/users/Jonahss/events{/privacy}","received_events_url":"https://api.github.com/users/Jonahss/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":6,"deletions":2,"changed_files":2}}