GitHub PullRequestEvent at 2014-06-24 16:07:54
Repository: nette
Actor: dg
Payload: {"action":"closed","number":1440,"pull_request":{"url":"https://api.github.com/repos/nette/nette/pulls/1440","id":13343475,"html_url":"https://github.com/nette/nette/pull/1440","diff_url":"https://github.com/nette/nette/pull/1440.diff","patch_url":"https://github.com/nette/nette/pull/1440.patch","issue_url":"https://api.github.com/repos/nette/nette/issues/1440","number":1440,"state":"closed","title":"[Idea] Route: Powerful filters","user":{"login":"JanTvrdik","id":175109,"avatar_url":"https://avatars.githubusercontent.com/u/175109?","gravatar_id":"1c8e383e734793b09ce16b1b9d0f1dc7","url":"https://api.github.com/users/JanTvrdik","html_url":"https://github.com/JanTvrdik","followers_url":"https://api.github.com/users/JanTvrdik/followers","following_url":"https://api.github.com/users/JanTvrdik/following{/other_user}","gists_url":"https://api.github.com/users/JanTvrdik/gists{/gist_id}","starred_url":"https://api.github.com/users/JanTvrdik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JanTvrdik/subscriptions","organizations_url":"https://api.github.com/users/JanTvrdik/orgs","repos_url":"https://api.github.com/users/JanTvrdik/repos","events_url":"https://api.github.com/users/JanTvrdik/events{/privacy}","received_events_url":"https://api.github.com/users/JanTvrdik/received_events","type":"User","site_admin":false},"body":"Nette 2.1 added the very powerful global filters which allow you to filter one parameter based on a value of another parameter. For example in route `<lang>/<presenter>/<action>` you can filter `<presenter>` and `<action>` based on `<lang>`. I propose to add this power also to normal filters by simple passing the whole `$params` array. Please note that this is still way less powerful than global filters (I should write an article about how powerful they really are). I also decides to pass whole http/app request.\r\n\r\nWhat do you think? I'll obviously write a test if the idea is accepted.","created_at":"2014-03-08T16:57:45Z","updated_at":"2014-06-24T16:07:54Z","closed_at":"2014-06-24T16:07:54Z","merged_at":null,"merge_commit_sha":"c9577d0344753ea8c5a1a6e8b6dbd699def7994e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nette/nette/pulls/1440/commits","review_comments_url":"https://api.github.com/repos/nette/nette/pulls/1440/comments","review_comment_url":"https://api.github.com/repos/nette/nette/pulls/comments/{number}","comments_url":"https://api.github.com/repos/nette/nette/issues/1440/comments","statuses_url":"https://api.github.com/repos/nette/nette/statuses/9d3206de16b2db9b1e7aa416bb5238d5f295c971","head":{"label":"JanTvrdik:route_powerful_filters","ref":"route_powerful_filters","sha":"9d3206de16b2db9b1e7aa416bb5238d5f295c971","user":{"login":"JanTvrdik","id":175109,"avatar_url":"https://avatars.githubusercontent.com/u/175109?","gravatar_id":"1c8e383e734793b09ce16b1b9d0f1dc7","url":"https://api.github.com/users/JanTvrdik","html_url":"https://github.com/JanTvrdik","followers_url":"https://api.github.com/users/JanTvrdik/followers","following_url":"https://api.github.com/users/JanTvrdik/following{/other_user}","gists_url":"https://api.github.com/users/JanTvrdik/gists{/gist_id}","starred_url":"https://api.github.com/users/JanTvrdik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JanTvrdik/subscriptions","organizations_url":"https://api.github.com/users/JanTvrdik/orgs","repos_url":"https://api.github.com/users/JanTvrdik/repos","events_url":"https://api.github.com/users/JanTvrdik/events{/privacy}","received_events_url":"https://api.github.com/users/JanTvrdik/received_events","type":"User","site_admin":false},"repo":{"id":790642,"name":"nette","full_name":"JanTvrdik/nette","owner":{"login":"JanTvrdik","id":175109,"avatar_url":"https://avatars.githubusercontent.com/u/175109?","gravatar_id":"1c8e383e734793b09ce16b1b9d0f1dc7","url":"https://api.github.com/users/JanTvrdik","html_url":"https://github.com/JanTvrdik","followers_url":"https://api.github.com/users/JanTvrdik/followers","following_url":"https://api.github.com/users/JanTvrdik/following{/other_user}","gists_url":"https://api.github.com/users/JanTvrdik/gists{/gist_id}","starred_url":"https://api.github.com/users/JanTvrdik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JanTvrdik/subscriptions","organizations_url":"https://api.github.com/users/JanTvrdik/orgs","repos_url":"https://api.github.com/users/JanTvrdik/repos","events_url":"https://api.github.com/users/JanTvrdik/events{/privacy}","received_events_url":"https://api.github.com/users/JanTvrdik/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JanTvrdik/nette","description":"Nette Framework for PHP 5","fork":true,"url":"https://api.github.com/repos/JanTvrdik/nette","forks_url":"https://api.github.com/repos/JanTvrdik/nette/forks","keys_url":"https://api.github.com/repos/JanTvrdik/nette/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JanTvrdik/nette/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JanTvrdik/nette/teams","hooks_url":"https://api.github.com/repos/JanTvrdik/nette/hooks","issue_events_url":"https://api.github.com/repos/JanTvrdik/nette/issues/events{/number}","events_url":"https://api.github.com/repos/JanTvrdik/nette/events","assignees_url":"https://api.github.com/repos/JanTvrdik/nette/assignees{/user}","branches_url":"https://api.github.com/repos/JanTvrdik/nette/branches{/branch}","tags_url":"https://api.github.com/repos/JanTvrdik/nette/tags","blobs_url":"https://api.github.com/repos/JanTvrdik/nette/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JanTvrdik/nette/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JanTvrdik/nette/git/refs{/sha}","trees_url":"https://api.github.com/repos/JanTvrdik/nette/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JanTvrdik/nette/statuses/{sha}","languages_url":"https://api.github.com/repos/JanTvrdik/nette/languages","stargazers_url":"https://api.github.com/repos/JanTvrdik/nette/stargazers","contributors_url":"https://api.github.com/repos/JanTvrdik/nette/contributors","subscribers_url":"https://api.github.com/repos/JanTvrdik/nette/subscribers","subscription_url":"https://api.github.com/repos/JanTvrdik/nette/subscription","commits_url":"https://api.github.com/repos/JanTvrdik/nette/commits{/sha}","git_commits_url":"https://api.github.com/repos/JanTvrdik/nette/git/commits{/sha}","comments_url":"https://api.github.com/repos/JanTvrdik/nette/comments{/number}","issue_comment_url":"https://api.github.com/repos/JanTvrdik/nette/issues/comments/{number}","contents_url":"https://api.github.com/repos/JanTvrdik/nette/contents/{+path}","compare_url":"https://api.github.com/repos/JanTvrdik/nette/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JanTvrdik/nette/merges","archive_url":"https://api.github.com/repos/JanTvrdik/nette/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JanTvrdik/nette/downloads","issues_url":"https://api.github.com/repos/JanTvrdik/nette/issues{/number}","pulls_url":"https://api.github.com/repos/JanTvrdik/nette/pulls{/number}","milestones_url":"https://api.github.com/repos/JanTvrdik/nette/milestones{/number}","notifications_url":"https://api.github.com/repos/JanTvrdik/nette/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JanTvrdik/nette/labels{/name}","releases_url":"https://api.github.com/repos/JanTvrdik/nette/releases{/id}","created_at":"2010-07-22T11:08:45Z","updated_at":"2014-06-24T16:07:54Z","pushed_at":"2014-04-28T12:12:12Z","git_url":"git://github.com/JanTvrdik/nette.git","ssh_url":"git@github.com:JanTvrdik/nette.git","clone_url":"https://github.com/JanTvrdik/nette.git","svn_url":"https://github.com/JanTvrdik/nette","homepage":"http://nette.org","size":23495,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"nette:master","ref":"master","sha":"78073669995581c857d4b5041f807ccc253a7897","user":{"login":"nette","id":99965,"avatar_url":"https://avatars.githubusercontent.com/u/99965?","gravatar_id":"d43b6ec56fa855e1584810d5abf3453f","url":"https://api.github.com/users/nette","html_url":"https://github.com/nette","followers_url":"https://api.github.com/users/nette/followers","following_url":"https://api.github.com/users/nette/following{/other_user}","gists_url":"https://api.github.com/users/nette/gists{/gist_id}","starred_url":"https://api.github.com/users/nette/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nette/subscriptions","organizations_url":"https://api.github.com/users/nette/orgs","repos_url":"https://api.github.com/users/nette/repos","events_url":"https://api.github.com/users/nette/events{/privacy}","received_events_url":"https://api.github.com/users/nette/received_events","type":"Organization","site_admin":false},"repo":{"id":277292,"name":"nette","full_name":"nette/nette","owner":{"login":"nette","id":99965,"avatar_url":"https://avatars.githubusercontent.com/u/99965?","gravatar_id":"d43b6ec56fa855e1584810d5abf3453f","url":"https://api.github.com/users/nette","html_url":"https://github.com/nette","followers_url":"https://api.github.com/users/nette/followers","following_url":"https://api.github.com/users/nette/following{/other_user}","gists_url":"https://api.github.com/users/nette/gists{/gist_id}","starred_url":"https://api.github.com/users/nette/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nette/subscriptions","organizations_url":"https://api.github.com/users/nette/orgs","repos_url":"https://api.github.com/users/nette/repos","events_url":"https://api.github.com/users/nette/events{/privacy}","received_events_url":"https://api.github.com/users/nette/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nette/nette","description":"Nette Framework","fork":false,"url":"https://api.github.com/repos/nette/nette","forks_url":"https://api.github.com/repos/nette/nette/forks","keys_url":"https://api.github.com/repos/nette/nette/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nette/nette/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nette/nette/teams","hooks_url":"https://api.github.com/repos/nette/nette/hooks","issue_events_url":"https://api.github.com/repos/nette/nette/issues/events{/number}","events_url":"https://api.github.com/repos/nette/nette/events","assignees_url":"https://api.github.com/repos/nette/nette/assignees{/user}","branches_url":"https://api.github.com/repos/nette/nette/branches{/branch}","tags_url":"https://api.github.com/repos/nette/nette/tags","blobs_url":"https://api.github.com/repos/nette/nette/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nette/nette/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nette/nette/git/refs{/sha}","trees_url":"https://api.github.com/repos/nette/nette/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nette/nette/statuses/{sha}","languages_url":"https://api.github.com/repos/nette/nette/languages","stargazers_url":"https://api.github.com/repos/nette/nette/stargazers","contributors_url":"https://api.github.com/repos/nette/nette/contributors","subscribers_url":"https://api.github.com/repos/nette/nette/subscribers","subscription_url":"https://api.github.com/repos/nette/nette/subscription","commits_url":"https://api.github.com/repos/nette/nette/commits{/sha}","git_commits_url":"https://api.github.com/repos/nette/nette/git/commits{/sha}","comments_url":"https://api.github.com/repos/nette/nette/comments{/number}","issue_comment_url":"https://api.github.com/repos/nette/nette/issues/comments/{number}","contents_url":"https://api.github.com/repos/nette/nette/contents/{+path}","compare_url":"https://api.github.com/repos/nette/nette/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nette/nette/merges","archive_url":"https://api.github.com/repos/nette/nette/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nette/nette/downloads","issues_url":"https://api.github.com/repos/nette/nette/issues{/number}","pulls_url":"https://api.github.com/repos/nette/nette/pulls{/number}","milestones_url":"https://api.github.com/repos/nette/nette/milestones{/number}","notifications_url":"https://api.github.com/repos/nette/nette/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nette/nette/labels{/name}","releases_url":"https://api.github.com/repos/nette/nette/releases{/id}","created_at":"2009-08-13T20:14:56Z","updated_at":"2014-06-24T12:52:44Z","pushed_at":"2014-06-24T12:50:46Z","git_url":"git://github.com/nette/nette.git","ssh_url":"git@github.com:nette/nette.git","clone_url":"https://github.com/nette/nette.git","svn_url":"https://github.com/nette/nette","homepage":"http://nette.org","size":38337,"stargazers_count":833,"watchers_count":833,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":271,"mirror_url":null,"open_issues_count":96,"forks":271,"open_issues":96,"watchers":833,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nette/nette/pulls/1440"},"html":{"href":"https://github.com/nette/nette/pull/1440"},"issue":{"href":"https://api.github.com/repos/nette/nette/issues/1440"},"comments":{"href":"https://api.github.com/repos/nette/nette/issues/1440/comments"},"review_comments":{"href":"https://api.github.com/repos/nette/nette/pulls/1440/comments"},"review_comment":{"href":"https://api.github.com/repos/nette/nette/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/nette/nette/pulls/1440/commits"},"statuses":{"href":"https://api.github.com/repos/nette/nette/statuses/9d3206de16b2db9b1e7aa416bb5238d5f295c971"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":8,"review_comments":0,"commits":1,"additions":11,"deletions":5,"changed_files":1}}