GitHub PullRequestReviewCommentEvent at 2014-02-05 18:18:36
Repository: ros_controllers
Actor: wjwwood
Payload: {"comment":{"url":"https://api.github.com/repos/ros-controls/ros_controllers/pulls/comments/9471377","id":9471377,"diff_hunk":"@@ -0,0 +1,140 @@\n+cmake_minimum_required(VERSION 2.8.3)\n+project(joint_trajectory_controller)\n+\n+# rosbuild -----------------------------------------------------------------------------\n+if(USE_ROSBUILD)\n+  include($ENV{ROS_ROOT}/core/rosbuild/rosbuild.cmake)\n+\n+  rosbuild_init()\n+\n+  set(EXECUTABLE_OUTPUT_PATH ${PROJECT_SOURCE_DIR}/bin)\n+  set(LIBRARY_OUTPUT_PATH ${PROJECT_SOURCE_DIR}/lib)\n+\n+  rosbuild_add_library(${PROJECT_NAME}\n+    src/joint_trajectory_controller.cpp\n+    include/joint_trajectory_controller/joint_trajectory_controller.h\n+    include/joint_trajectory_controller/joint_trajectory_controller_impl.h\n+    include/joint_trajectory_controller/joint_trajectory_msg_utils.h\n+    include/joint_trajectory_controller/joint_trajectory_segment.h\n+    include/trajectory_interface/trajectory_interface.h\n+    include/trajectory_interface/quintic_spline_segment.h\n+    include/trajectory_interface/pos_vel_acc_state.h)\n+\n+  rosbuild_add_gtest(quintic_spline_segment_test     test/quintic_spline_segment_test.cpp)\n+  rosbuild_add_gtest(trajectory_interface_test       test/trajectory_interface_test.cpp)\n+  rosbuild_add_gtest(joint_trajectory_segment_test   test/joint_trajectory_segment_test.cpp)\n+  rosbuild_add_gtest(joint_trajectory_msg_utils_test test/joint_trajectory_msg_utils_test.cpp)\n+  rosbuild_add_gtest(init_joint_trajectory_test      test/init_joint_trajectory_test.cpp)\n+\n+  rosbuild_add_executable(tolerances_test test/tolerances_test.cpp)\n+  rosbuild_add_gtest_build_flags(tolerances_test)\n+  rosbuild_add_rostest(test/tolerances.test)\n+\n+  rosbuild_add_executable(rrbot test/rrbot.cpp)\n+\n+  rosbuild_add_executable(joint_trajectory_controller_test test/joint_trajectory_controller_test.cpp)\n+  rosbuild_add_gtest_build_flags(joint_trajectory_controller_test)\n+  rosbuild_add_rostest(test/joint_trajectory_controller.test)\n+\n+  # TODO: why is it explicitly needed???, without it the linker fails.\n+  target_link_libraries(quintic_spline_segment_test     pthread)\n+  target_link_libraries(trajectory_interface_test       pthread)\n+  target_link_libraries(joint_trajectory_segment_test   pthread)\n+  target_link_libraries(joint_trajectory_msg_utils_test pthread)\n+  target_link_libraries(init_joint_trajectory_test      pthread)\n+  target_link_libraries(tolerances_test                 pthread)\n+  target_link_libraries(joint_trajectory_controller     pthread)\n+\n+# catkin -----------------------------------------------------------------------------\n+else()\n+  # Load catkin and all dependencies required for this package\n+  find_package(catkin \n+    REQUIRED COMPONENTS \n+      actionlib\n+      angles\n+      roscpp\n+      urdf\n+      control_toolbox\n+      controller_interface\n+      hardware_interface\n+      realtime_tools\n+      control_msgs\n+      trajectory_msgs\n+      rostest\n+      controller_manager\n+      xacro","path":"joint_trajectory_controller/CMakeLists.txt","position":65,"original_position":65,"commit_id":"62941cdf4282b359131b0e8eef71f9de67dcce5c","original_commit_id":"e25f83169aab453902d31d87675373f0bf8522c2","user":{"login":"wjwwood","id":100427,"avatar_url":"https://gravatar.com/avatar/e9b7130c915ff71c0812d99ff927e929?d=https%3A%2F%2Fidenticons.github.com%2Ffa1f170d31df1d5069af37f35a171700.png&r=x","gravatar_id":"e9b7130c915ff71c0812d99ff927e929","url":"https://api.github.com/users/wjwwood","html_url":"https://github.com/wjwwood","followers_url":"https://api.github.com/users/wjwwood/followers","following_url":"https://api.github.com/users/wjwwood/following{/other_user}","gists_url":"https://api.github.com/users/wjwwood/gists{/gist_id}","starred_url":"https://api.github.com/users/wjwwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wjwwood/subscriptions","organizations_url":"https://api.github.com/users/wjwwood/orgs","repos_url":"https://api.github.com/users/wjwwood/repos","events_url":"https://api.github.com/users/wjwwood/events{/privacy}","received_events_url":"https://api.github.com/users/wjwwood/received_events","type":"User","site_admin":false},"body":"I think if you are having trouble with `xacro` on Groovy you should file an issue against `xacro`, it should work as far as I know.","created_at":"2014-02-05T18:18:36Z","updated_at":"2014-02-05T18:18:36Z","html_url":"https://github.com/ros-controls/ros_controllers/pull/38#discussion_r9471377","pull_request_url":"https://api.github.com/repos/ros-controls/ros_controllers/pulls/38","_links":{"self":{"href":"https://api.github.com/repos/ros-controls/ros_controllers/pulls/comments/9471377"},"html":{"href":"https://github.com/ros-controls/ros_controllers/pull/38#discussion_r9471377"},"pull_request":{"href":"https://api.github.com/repos/ros-controls/ros_controllers/pulls/38"}}}}