GitHub PullRequestReviewCommentEvent at 2014-12-24 01:04:33
Repository: spark
Actor: scwf
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/22242966","id":22242966,"diff_hunk":"@@ -278,7 +278,6 @@ private[hive] class SparkSQLCLIDriver extends CliDriver with Logging {\n \n           ret = rc.getResponseCode\n           if (ret != 0) {\n-            console.printError(rc.getErrorMessage())","path":"sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLCLIDriver.scala","position":4,"original_position":4,"commit_id":"0330e0783d5022020eb330ef02107321c7914c76","original_commit_id":"0330e0783d5022020eb330ef02107321c7914c76","user":{"login":"scwf","id":7018048,"avatar_url":"https://avatars.githubusercontent.com/u/7018048?v=3","gravatar_id":"","url":"https://api.github.com/users/scwf","html_url":"https://github.com/scwf","followers_url":"https://api.github.com/users/scwf/followers","following_url":"https://api.github.com/users/scwf/following{/other_user}","gists_url":"https://api.github.com/users/scwf/gists{/gist_id}","starred_url":"https://api.github.com/users/scwf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scwf/subscriptions","organizations_url":"https://api.github.com/users/scwf/orgs","repos_url":"https://api.github.com/users/scwf/repos","events_url":"https://api.github.com/users/scwf/events{/privacy}","received_events_url":"https://api.github.com/users/scwf/received_events","type":"User","site_admin":false},"body":"Actually before this PR  this line do not executed, seems it does not matter, can you explain why it will silent some error messages.","created_at":"2014-12-24T01:04:33Z","updated_at":"2014-12-24T01:04:33Z","html_url":"https://github.com/apache/spark/pull/3761#discussion_r22242966","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/3761","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/22242966"},"html":{"href":"https://github.com/apache/spark/pull/3761#discussion_r22242966"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/3761"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/3761","id":26445797,"html_url":"https://github.com/apache/spark/pull/3761","diff_url":"https://github.com/apache/spark/pull/3761.diff","patch_url":"https://github.com/apache/spark/pull/3761.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/3761","number":3761,"state":"open","locked":false,"title":"[SPARK-4935][SQL] When hive.cli.print.header configured, spark-sql aborted if passed in a invalid sql","user":{"login":"scwf","id":7018048,"avatar_url":"https://avatars.githubusercontent.com/u/7018048?v=3","gravatar_id":"","url":"https://api.github.com/users/scwf","html_url":"https://github.com/scwf","followers_url":"https://api.github.com/users/scwf/followers","following_url":"https://api.github.com/users/scwf/following{/other_user}","gists_url":"https://api.github.com/users/scwf/gists{/gist_id}","starred_url":"https://api.github.com/users/scwf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scwf/subscriptions","organizations_url":"https://api.github.com/users/scwf/orgs","repos_url":"https://api.github.com/users/scwf/repos","events_url":"https://api.github.com/users/scwf/events{/privacy}","received_events_url":"https://api.github.com/users/scwf/received_events","type":"User","site_admin":false},"body":"If we passed in a wrong sql like ```abdcdfsfs```, the spark-sql script aborted. ","created_at":"2014-12-22T09:14:54Z","updated_at":"2014-12-24T01:04:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"60efb6636c3cb1a22878789c4174bedc4fbec016","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/3761/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/3761/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments/{number}","comments_url":"https://api.github.com/repos/apache/spark/issues/3761/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/0330e0783d5022020eb330ef02107321c7914c76","head":{"label":"scwf:patch-10","ref":"patch-10","sha":"0330e0783d5022020eb330ef02107321c7914c76","user":{"login":"scwf","id":7018048,"avatar_url":"https://avatars.githubusercontent.com/u/7018048?v=3","gravatar_id":"","url":"https://api.github.com/users/scwf","html_url":"https://github.com/scwf","followers_url":"https://api.github.com/users/scwf/followers","following_url":"https://api.github.com/users/scwf/following{/other_user}","gists_url":"https://api.github.com/users/scwf/gists{/gist_id}","starred_url":"https://api.github.com/users/scwf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scwf/subscriptions","organizations_url":"https://api.github.com/users/scwf/orgs","repos_url":"https://api.github.com/users/scwf/repos","events_url":"https://api.github.com/users/scwf/events{/privacy}","received_events_url":"https://api.github.com/users/scwf/received_events","type":"User","site_admin":false},"repo":{"id":18058739,"name":"spark","full_name":"scwf/spark","owner":{"login":"scwf","id":7018048,"avatar_url":"https://avatars.githubusercontent.com/u/7018048?v=3","gravatar_id":"","url":"https://api.github.com/users/scwf","html_url":"https://github.com/scwf","followers_url":"https://api.github.com/users/scwf/followers","following_url":"https://api.github.com/users/scwf/following{/other_user}","gists_url":"https://api.github.com/users/scwf/gists{/gist_id}","starred_url":"https://api.github.com/users/scwf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scwf/subscriptions","organizations_url":"https://api.github.com/users/scwf/orgs","repos_url":"https://api.github.com/users/scwf/repos","events_url":"https://api.github.com/users/scwf/events{/privacy}","received_events_url":"https://api.github.com/users/scwf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/scwf/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/scwf/spark","forks_url":"https://api.github.com/repos/scwf/spark/forks","keys_url":"https://api.github.com/repos/scwf/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scwf/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scwf/spark/teams","hooks_url":"https://api.github.com/repos/scwf/spark/hooks","issue_events_url":"https://api.github.com/repos/scwf/spark/issues/events{/number}","events_url":"https://api.github.com/repos/scwf/spark/events","assignees_url":"https://api.github.com/repos/scwf/spark/assignees{/user}","branches_url":"https://api.github.com/repos/scwf/spark/branches{/branch}","tags_url":"https://api.github.com/repos/scwf/spark/tags","blobs_url":"https://api.github.com/repos/scwf/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scwf/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scwf/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/scwf/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scwf/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/scwf/spark/languages","stargazers_url":"https://api.github.com/repos/scwf/spark/stargazers","contributors_url":"https://api.github.com/repos/scwf/spark/contributors","subscribers_url":"https://api.github.com/repos/scwf/spark/subscribers","subscription_url":"https://api.github.com/repos/scwf/spark/subscription","commits_url":"https://api.github.com/repos/scwf/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/scwf/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/scwf/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/scwf/spark/issues/comments/{number}","contents_url":"https://api.github.com/repos/scwf/spark/contents/{+path}","compare_url":"https://api.github.com/repos/scwf/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scwf/spark/merges","archive_url":"https://api.github.com/repos/scwf/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scwf/spark/downloads","issues_url":"https://api.github.com/repos/scwf/spark/issues{/number}","pulls_url":"https://api.github.com/repos/scwf/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/scwf/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/scwf/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scwf/spark/labels{/name}","releases_url":"https://api.github.com/repos/scwf/spark/releases{/id}","created_at":"2014-03-24T10:24:49Z","updated_at":"2014-12-21T06:50:00Z","pushed_at":"2014-12-23T13:39:03Z","git_url":"git://github.com/scwf/spark.git","ssh_url":"git@github.com:scwf/spark.git","clone_url":"https://github.com/scwf/spark.git","svn_url":"https://github.com/scwf/spark","homepage":null,"size":90972,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"6ee6aa70b7d52408cc66bd1434cbeae3212e3f01","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments/{number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","created_at":"2014-02-25T08:00:08Z","updated_at":"2014-12-24T00:09:08Z","pushed_at":"2014-12-24T00:09:56Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":1065301,"stargazers_count":2411,"watchers_count":2411,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2147,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":264,"forks":2147,"open_issues":264,"watchers":2411,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/3761"},"html":{"href":"https://github.com/apache/spark/pull/3761"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/3761"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/3761/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/3761/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/3761/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/0330e0783d5022020eb330ef02107321c7914c76"}}}}