GitHub PullRequestEvent at 2014-08-05 16:09:09
Repository: acs-aem-commons
Actor: kalyanar
Payload: {"action":"closed","number":265,"pull_request":{"url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/pulls/265","id":18650547,"html_url":"https://github.com/Adobe-Consulting-Services/acs-aem-commons/pull/265","diff_url":"https://github.com/Adobe-Consulting-Services/acs-aem-commons/pull/265.diff","patch_url":"https://github.com/Adobe-Consulting-Services/acs-aem-commons/pull/265.patch","issue_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/issues/265","number":265,"state":"closed","title":"Feature/cors filter","user":{"login":"kalyanar","id":6203088,"avatar_url":"https://avatars.githubusercontent.com/u/6203088?v=2","gravatar_id":"cbe8e7274a5b1354cac743cea2b9de6c","url":"https://api.github.com/users/kalyanar","html_url":"https://github.com/kalyanar","followers_url":"https://api.github.com/users/kalyanar/followers","following_url":"https://api.github.com/users/kalyanar/following{/other_user}","gists_url":"https://api.github.com/users/kalyanar/gists{/gist_id}","starred_url":"https://api.github.com/users/kalyanar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalyanar/subscriptions","organizations_url":"https://api.github.com/users/kalyanar/orgs","repos_url":"https://api.github.com/users/kalyanar/repos","events_url":"https://api.github.com/users/kalyanar/events{/privacy}","received_events_url":"https://api.github.com/users/kalyanar/received_events","type":"User","site_admin":false},"body":"Based on http://www.w3.org/TR/cors/\r\nThe filter is called at the earliest possible point\r\nOnly works on preflight requests.\r\nCreated as a ConfigurationFactory and hence each host will have its own configurations\r\nJunits available for the util class \r\nSince the filter had just string compares , have not created a junit.","created_at":"2014-07-21T12:17:38Z","updated_at":"2014-08-05T16:09:08Z","closed_at":"2014-08-05T16:09:08Z","merged_at":null,"merge_commit_sha":"a7ff7e91c5f4f4d7d66f5fa1c53c16f07ad12c34","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/pulls/265/commits","review_comments_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/pulls/265/comments","review_comment_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/issues/265/comments","statuses_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/statuses/931e0d7f9570a207494ecb647b2b7856f7f41f71","head":{"label":"kalyanar:feature/CORSFilter","ref":"feature/CORSFilter","sha":"931e0d7f9570a207494ecb647b2b7856f7f41f71","user":{"login":"kalyanar","id":6203088,"avatar_url":"https://avatars.githubusercontent.com/u/6203088?v=2","gravatar_id":"cbe8e7274a5b1354cac743cea2b9de6c","url":"https://api.github.com/users/kalyanar","html_url":"https://github.com/kalyanar","followers_url":"https://api.github.com/users/kalyanar/followers","following_url":"https://api.github.com/users/kalyanar/following{/other_user}","gists_url":"https://api.github.com/users/kalyanar/gists{/gist_id}","starred_url":"https://api.github.com/users/kalyanar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalyanar/subscriptions","organizations_url":"https://api.github.com/users/kalyanar/orgs","repos_url":"https://api.github.com/users/kalyanar/repos","events_url":"https://api.github.com/users/kalyanar/events{/privacy}","received_events_url":"https://api.github.com/users/kalyanar/received_events","type":"User","site_admin":false},"repo":{"id":22061795,"name":"acs-aem-commons","full_name":"kalyanar/acs-aem-commons","owner":{"login":"kalyanar","id":6203088,"avatar_url":"https://avatars.githubusercontent.com/u/6203088?v=2","gravatar_id":"cbe8e7274a5b1354cac743cea2b9de6c","url":"https://api.github.com/users/kalyanar","html_url":"https://github.com/kalyanar","followers_url":"https://api.github.com/users/kalyanar/followers","following_url":"https://api.github.com/users/kalyanar/following{/other_user}","gists_url":"https://api.github.com/users/kalyanar/gists{/gist_id}","starred_url":"https://api.github.com/users/kalyanar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalyanar/subscriptions","organizations_url":"https://api.github.com/users/kalyanar/orgs","repos_url":"https://api.github.com/users/kalyanar/repos","events_url":"https://api.github.com/users/kalyanar/events{/privacy}","received_events_url":"https://api.github.com/users/kalyanar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kalyanar/acs-aem-commons","description":"","fork":true,"url":"https://api.github.com/repos/kalyanar/acs-aem-commons","forks_url":"https://api.github.com/repos/kalyanar/acs-aem-commons/forks","keys_url":"https://api.github.com/repos/kalyanar/acs-aem-commons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kalyanar/acs-aem-commons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kalyanar/acs-aem-commons/teams","hooks_url":"https://api.github.com/repos/kalyanar/acs-aem-commons/hooks","issue_events_url":"https://api.github.com/repos/kalyanar/acs-aem-commons/issues/events{/number}","events_url":"https://api.github.com/repos/kalyanar/acs-aem-commons/events","assignees_url":"https://api.github.com/repos/kalyanar/acs-aem-commons/assignees{/user}","branches_url":"https://api.github.com/repos/kalyanar/acs-aem-commons/branches{/branch}","tags_url":"https://api.github.com/repos/kalyanar/acs-aem-commons/tags","blobs_url":"https://api.github.com/repos/kalyanar/acs-aem-commons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kalyanar/acs-aem-commons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kalyanar/acs-aem-commons/git/refs{/sha}","trees_url":"https://api.github.com/repos/kalyanar/acs-aem-commons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kalyanar/acs-aem-commons/statuses/{sha}","languages_url":"https://api.github.com/repos/kalyanar/acs-aem-commons/languages","stargazers_url":"https://api.github.com/repos/kalyanar/acs-aem-commons/stargazers","contributors_url":"https://api.github.com/repos/kalyanar/acs-aem-commons/contributors","subscribers_url":"https://api.github.com/repos/kalyanar/acs-aem-commons/subscribers","subscription_url":"https://api.github.com/repos/kalyanar/acs-aem-commons/subscription","commits_url":"https://api.github.com/repos/kalyanar/acs-aem-commons/commits{/sha}","git_commits_url":"https://api.github.com/repos/kalyanar/acs-aem-commons/git/commits{/sha}","comments_url":"https://api.github.com/repos/kalyanar/acs-aem-commons/comments{/number}","issue_comment_url":"https://api.github.com/repos/kalyanar/acs-aem-commons/issues/comments/{number}","contents_url":"https://api.github.com/repos/kalyanar/acs-aem-commons/contents/{+path}","compare_url":"https://api.github.com/repos/kalyanar/acs-aem-commons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kalyanar/acs-aem-commons/merges","archive_url":"https://api.github.com/repos/kalyanar/acs-aem-commons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kalyanar/acs-aem-commons/downloads","issues_url":"https://api.github.com/repos/kalyanar/acs-aem-commons/issues{/number}","pulls_url":"https://api.github.com/repos/kalyanar/acs-aem-commons/pulls{/number}","milestones_url":"https://api.github.com/repos/kalyanar/acs-aem-commons/milestones{/number}","notifications_url":"https://api.github.com/repos/kalyanar/acs-aem-commons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kalyanar/acs-aem-commons/labels{/name}","releases_url":"https://api.github.com/repos/kalyanar/acs-aem-commons/releases{/id}","created_at":"2014-07-21T11:27:13Z","updated_at":"2014-07-21T10:33:02Z","pushed_at":"2014-08-05T10:48:29Z","git_url":"git://github.com/kalyanar/acs-aem-commons.git","ssh_url":"git@github.com:kalyanar/acs-aem-commons.git","clone_url":"https://github.com/kalyanar/acs-aem-commons.git","svn_url":"https://github.com/kalyanar/acs-aem-commons","homepage":"http://adobe-consulting-services.github.io/acs-aem-commons/","size":12049,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Adobe-Consulting-Services:master","ref":"master","sha":"fba2fbfa42c105691205892a959bb1159b35db26","user":{"login":"Adobe-Consulting-Services","id":5420974,"avatar_url":"https://avatars.githubusercontent.com/u/5420974?v=2","gravatar_id":null,"url":"https://api.github.com/users/Adobe-Consulting-Services","html_url":"https://github.com/Adobe-Consulting-Services","followers_url":"https://api.github.com/users/Adobe-Consulting-Services/followers","following_url":"https://api.github.com/users/Adobe-Consulting-Services/following{/other_user}","gists_url":"https://api.github.com/users/Adobe-Consulting-Services/gists{/gist_id}","starred_url":"https://api.github.com/users/Adobe-Consulting-Services/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Adobe-Consulting-Services/subscriptions","organizations_url":"https://api.github.com/users/Adobe-Consulting-Services/orgs","repos_url":"https://api.github.com/users/Adobe-Consulting-Services/repos","events_url":"https://api.github.com/users/Adobe-Consulting-Services/events{/privacy}","received_events_url":"https://api.github.com/users/Adobe-Consulting-Services/received_events","type":"Organization","site_admin":false},"repo":{"id":13325401,"name":"acs-aem-commons","full_name":"Adobe-Consulting-Services/acs-aem-commons","owner":{"login":"Adobe-Consulting-Services","id":5420974,"avatar_url":"https://avatars.githubusercontent.com/u/5420974?v=2","gravatar_id":null,"url":"https://api.github.com/users/Adobe-Consulting-Services","html_url":"https://github.com/Adobe-Consulting-Services","followers_url":"https://api.github.com/users/Adobe-Consulting-Services/followers","following_url":"https://api.github.com/users/Adobe-Consulting-Services/following{/other_user}","gists_url":"https://api.github.com/users/Adobe-Consulting-Services/gists{/gist_id}","starred_url":"https://api.github.com/users/Adobe-Consulting-Services/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Adobe-Consulting-Services/subscriptions","organizations_url":"https://api.github.com/users/Adobe-Consulting-Services/orgs","repos_url":"https://api.github.com/users/Adobe-Consulting-Services/repos","events_url":"https://api.github.com/users/Adobe-Consulting-Services/events{/privacy}","received_events_url":"https://api.github.com/users/Adobe-Consulting-Services/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Adobe-Consulting-Services/acs-aem-commons","description":"","fork":false,"url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons","forks_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/forks","keys_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/teams","hooks_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/hooks","issue_events_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/issues/events{/number}","events_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/events","assignees_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/assignees{/user}","branches_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/branches{/branch}","tags_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/tags","blobs_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/git/refs{/sha}","trees_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/statuses/{sha}","languages_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/languages","stargazers_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/stargazers","contributors_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/contributors","subscribers_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/subscribers","subscription_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/subscription","commits_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/commits{/sha}","git_commits_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/git/commits{/sha}","comments_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/comments{/number}","issue_comment_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/issues/comments/{number}","contents_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/contents/{+path}","compare_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/merges","archive_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/downloads","issues_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/issues{/number}","pulls_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/pulls{/number}","milestones_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/milestones{/number}","notifications_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/labels{/name}","releases_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/releases{/id}","created_at":"2013-10-04T13:50:05Z","updated_at":"2014-07-30T12:20:27Z","pushed_at":"2014-07-29T19:48:18Z","git_url":"git://github.com/Adobe-Consulting-Services/acs-aem-commons.git","ssh_url":"git@github.com:Adobe-Consulting-Services/acs-aem-commons.git","clone_url":"https://github.com/Adobe-Consulting-Services/acs-aem-commons.git","svn_url":"https://github.com/Adobe-Consulting-Services/acs-aem-commons","homepage":"http://adobe-consulting-services.github.io/acs-aem-commons/","size":17287,"stargazers_count":59,"watchers_count":59,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":63,"mirror_url":null,"open_issues_count":45,"forks":63,"open_issues":45,"watchers":59,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/pulls/265"},"html":{"href":"https://github.com/Adobe-Consulting-Services/acs-aem-commons/pull/265"},"issue":{"href":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/issues/265"},"comments":{"href":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/issues/265/comments"},"review_comments":{"href":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/pulls/265/comments"},"review_comment":{"href":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/pulls/265/commits"},"statuses":{"href":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/statuses/931e0d7f9570a207494ecb647b2b7856f7f41f71"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":2,"review_comments":2,"commits":5,"additions":503,"deletions":0,"changed_files":5}}