GitHub PullRequestEvent at 2014-03-07 23:15:34
Repository: ansible
Actor: gildegoma
Payload: {"action":"opened","number":6337,"pull_request":{"url":"https://api.github.com/repos/ansible/ansible/pulls/6337","id":13334246,"html_url":"https://github.com/ansible/ansible/pull/6337","diff_url":"https://github.com/ansible/ansible/pull/6337.diff","patch_url":"https://github.com/ansible/ansible/pull/6337.patch","issue_url":"https://api.github.com/repos/ansible/ansible/issues/6337","number":6337,"state":"open","title":"Don't remove ControlPersist defaults when custom SSH arguments are provided","user":{"login":"gildegoma","id":434654,"avatar_url":"https://gravatar.com/avatar/a77ea938e04a0ee71a96301b6bfea2b7?d=https%3A%2F%2Fidenticons.github.com%2Fdfe1265e7f07582e64a0ded43830d2ae.png&r=x","gravatar_id":"a77ea938e04a0ee71a96301b6bfea2b7","url":"https://api.github.com/users/gildegoma","html_url":"https://github.com/gildegoma","followers_url":"https://api.github.com/users/gildegoma/followers","following_url":"https://api.github.com/users/gildegoma/following{/other_user}","gists_url":"https://api.github.com/users/gildegoma/gists{/gist_id}","starred_url":"https://api.github.com/users/gildegoma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gildegoma/subscriptions","organizations_url":"https://api.github.com/users/gildegoma/orgs","repos_url":"https://api.github.com/users/gildegoma/repos","events_url":"https://api.github.com/users/gildegoma/events{/privacy}","received_events_url":"https://api.github.com/users/gildegoma/received_events","type":"User","site_admin":false},"body":"##### Issue Type:\r\n\r\nFeature Pull Request\r\n\r\n##### Ansible Version:\r\n\r\n- ansible 1.5\r\n- ansible 1.6 (devel 9a06292a52) last updated 2014/03/07 21:17:55 (GMT +200)\r\n\r\n##### Environment:\r\n\r\nN/A\r\n\r\n##### Summary:\r\n\r\nUse `ANSIBLE_SSH_ARGS` environment variable (or `ssh_args` under `[ssh_connection]` header of an `ansible.cfg` configuration file) to pass a specific set of options to Ansible, *but without removing ControlPersist default settings*.\r\n\r\n##### Steps To Reproduce:\r\n\r\nLet's take an example where we want to additionally enable SSH-agent forwarding (this could be any kind of SSH customization), while keeping Ansible ControlMaster/ControlPersist default settings.\r\n\r\n- `$ export ANSIBLE_SSH_ARGS='-o ForwardAgent=yes'`\r\n- `$ ansible-playbook -i ... testplaybook.yml`\r\n\r\n##### Expected Results:\r\n\r\nCustom ssh_args **should be prepended** to SSH options set by Ansible (`-o ControlMaster=auto -o ControlPersist=60s -o ControlPath=... -o Port=...`)\r\n\r\n```\r\nTASK: [Do something] **********************************************************\r\n<127.0.0.1> ESTABLISH CONNECTION FOR USER: vagrant\r\n<127.0.0.1> EXEC ['ssh', '-C', '-tt', '-vvv', '-o', 'ForwardAgent=yes', '-o', 'ControlMaster=auto', \r\n'-o', 'ControlPersist=60s', '-o', 'ControlPath=/Users/gilles/.ansible/cp/ansible-ssh-%h-%p-%r', \r\n'-o', 'Port=2200', '-o', 'IdentityFile=/Users/gilles/.vagrant.d/insecure_private_key', \r\n'-o', 'KbdInteractiveAuthentication=no', '-o', 'PreferredAuthentications=gssapi-with-mic,gssapi-keyex,hostbased,publickey', '-o', 'PasswordAuthentication=no', '-o', 'User=vagrant', '-o', 'ConnectTimeout=10', '127.0.0.1', \"/bin/sh -c 'mkdir -p /tmp/ansible-tmp-1394230023.77-247682811037099 && chmod a+rx /tmp/ansible-tmp-1394230023.77-247682811037099 && echo /tmp/ansible-tmp-1394230023.77-247682811037099'\"]\r\n```\r\nNote: output partially wrapped in multiple lines for better readability\r\n\r\n##### Actual Results:\r\n\r\nAnsible Defaults (`-o ControlMaster=auto -o ControlPersist=60s -o ControlPath=...`) have been replaced by the custom ssh_args.\r\n\r\n```\r\nTASK: [Do something] **********************************************************\r\n<127.0.0.1> ESTABLISH CONNECTION FOR USER: vagrant\r\n<127.0.0.1> EXEC ['ssh', '-C', '-tt', '-vvv', '-o', 'ForwardAgent=yes', '-o', 'Port=2200', \r\n'-o', 'IdentityFile=/Users/gilles/.vagrant.d/insecure_private_key', \r\n'-o', 'KbdInteractiveAuthentication=no', '-o', 'PreferredAuthentications=gssapi-with-mic,gssapi-keyex,hostbased,publickey', '-o', 'PasswordAuthentication=no', '-o', 'User=vagrant', '-o', 'ConnectTimeout=10', '127.0.0.1', \"/bin/sh -c 'mkdir -p /tmp/ansible-tmp-1394230252.89-11219683818974 && chmod a+rx /tmp/ansible-tmp-1394230252.89-11219683818974 && echo /tmp/ansible-tmp-1394230252.89-11219683818974'\"]\r\n```\r\nNote: output partially wrapped in multiple lines for better readability\r\n\r\n##### Additional Notes:\r\n\r\n- Overriding or Disabling all Ansible default settings is *explicitly* possible via ANSIBLE_SSH_ARGS/ansible.cfg, since the first obtained value for each SSH parameter will be used.\r\n\r\n- This pull request does not include yet any documentation update. Of course, I'm willing to provide it as part of this feature branch, if this change is accepted (and if you're not too afraid of my english).\r\n\r\n- Motivated by mitchellh/vagrant#2952 use cases.","created_at":"2014-03-07T23:15:33Z","updated_at":"2014-03-07T23:15:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ansible/ansible/pulls/6337/commits","review_comments_url":"https://api.github.com/repos/ansible/ansible/pulls/6337/comments","review_comment_url":"https://api.github.com/repos/ansible/ansible/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ansible/ansible/issues/6337/comments","statuses_url":"https://api.github.com/repos/ansible/ansible/statuses/adf4cde778c8f362c6ca3b605bdeffd46661d07e","head":{"label":"gildegoma:keep_controlpersist_defaults","ref":"keep_controlpersist_defaults","sha":"adf4cde778c8f362c6ca3b605bdeffd46661d07e","user":{"login":"gildegoma","id":434654,"avatar_url":"https://gravatar.com/avatar/a77ea938e04a0ee71a96301b6bfea2b7?d=https%3A%2F%2Fidenticons.github.com%2Fdfe1265e7f07582e64a0ded43830d2ae.png&r=x","gravatar_id":"a77ea938e04a0ee71a96301b6bfea2b7","url":"https://api.github.com/users/gildegoma","html_url":"https://github.com/gildegoma","followers_url":"https://api.github.com/users/gildegoma/followers","following_url":"https://api.github.com/users/gildegoma/following{/other_user}","gists_url":"https://api.github.com/users/gildegoma/gists{/gist_id}","starred_url":"https://api.github.com/users/gildegoma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gildegoma/subscriptions","organizations_url":"https://api.github.com/users/gildegoma/orgs","repos_url":"https://api.github.com/users/gildegoma/repos","events_url":"https://api.github.com/users/gildegoma/events{/privacy}","received_events_url":"https://api.github.com/users/gildegoma/received_events","type":"User","site_admin":false},"repo":{"id":9721833,"name":"ansible","full_name":"gildegoma/ansible","owner":{"login":"gildegoma","id":434654,"avatar_url":"https://gravatar.com/avatar/a77ea938e04a0ee71a96301b6bfea2b7?d=https%3A%2F%2Fidenticons.github.com%2Fdfe1265e7f07582e64a0ded43830d2ae.png&r=x","gravatar_id":"a77ea938e04a0ee71a96301b6bfea2b7","url":"https://api.github.com/users/gildegoma","html_url":"https://github.com/gildegoma","followers_url":"https://api.github.com/users/gildegoma/followers","following_url":"https://api.github.com/users/gildegoma/following{/other_user}","gists_url":"https://api.github.com/users/gildegoma/gists{/gist_id}","starred_url":"https://api.github.com/users/gildegoma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gildegoma/subscriptions","organizations_url":"https://api.github.com/users/gildegoma/orgs","repos_url":"https://api.github.com/users/gildegoma/repos","events_url":"https://api.github.com/users/gildegoma/events{/privacy}","received_events_url":"https://api.github.com/users/gildegoma/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gildegoma/ansible","description":"Ansible fork used for patch submission (rarely)","fork":true,"url":"https://api.github.com/repos/gildegoma/ansible","forks_url":"https://api.github.com/repos/gildegoma/ansible/forks","keys_url":"https://api.github.com/repos/gildegoma/ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gildegoma/ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gildegoma/ansible/teams","hooks_url":"https://api.github.com/repos/gildegoma/ansible/hooks","issue_events_url":"https://api.github.com/repos/gildegoma/ansible/issues/events{/number}","events_url":"https://api.github.com/repos/gildegoma/ansible/events","assignees_url":"https://api.github.com/repos/gildegoma/ansible/assignees{/user}","branches_url":"https://api.github.com/repos/gildegoma/ansible/branches{/branch}","tags_url":"https://api.github.com/repos/gildegoma/ansible/tags","blobs_url":"https://api.github.com/repos/gildegoma/ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gildegoma/ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gildegoma/ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/gildegoma/ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gildegoma/ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/gildegoma/ansible/languages","stargazers_url":"https://api.github.com/repos/gildegoma/ansible/stargazers","contributors_url":"https://api.github.com/repos/gildegoma/ansible/contributors","subscribers_url":"https://api.github.com/repos/gildegoma/ansible/subscribers","subscription_url":"https://api.github.com/repos/gildegoma/ansible/subscription","commits_url":"https://api.github.com/repos/gildegoma/ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/gildegoma/ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/gildegoma/ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/gildegoma/ansible/issues/comments/{number}","contents_url":"https://api.github.com/repos/gildegoma/ansible/contents/{+path}","compare_url":"https://api.github.com/repos/gildegoma/ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gildegoma/ansible/merges","archive_url":"https://api.github.com/repos/gildegoma/ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gildegoma/ansible/downloads","issues_url":"https://api.github.com/repos/gildegoma/ansible/issues{/number}","pulls_url":"https://api.github.com/repos/gildegoma/ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/gildegoma/ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/gildegoma/ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gildegoma/ansible/labels{/name}","releases_url":"https://api.github.com/repos/gildegoma/ansible/releases{/id}","created_at":"2013-04-27T22:12:53Z","updated_at":"2014-03-07T23:15:33Z","pushed_at":"2014-03-07T22:47:20Z","git_url":"git://github.com/gildegoma/ansible.git","ssh_url":"git@github.com:gildegoma/ansible.git","clone_url":"https://github.com/gildegoma/ansible.git","svn_url":"https://github.com/gildegoma/ansible","homepage":"","size":11626,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"devel","master_branch":"devel"}},"base":{"label":"ansible:devel","ref":"devel","sha":"4753804ab4b31bae4594e517548e1b392357b76e","user":{"login":"ansible","id":1507452,"avatar_url":"https://gravatar.com/avatar/f9759b728f6026571043dc66cd36edf2?d=https%3A%2F%2Fidenticons.github.com%2Faac0fe7299d592db8973f6f171980b4f.png&r=x","gravatar_id":"f9759b728f6026571043dc66cd36edf2","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"repo":{"id":3638964,"name":"ansible","full_name":"ansible/ansible","owner":{"login":"ansible","id":1507452,"avatar_url":"https://gravatar.com/avatar/f9759b728f6026571043dc66cd36edf2?d=https%3A%2F%2Fidenticons.github.com%2Faac0fe7299d592db8973f6f171980b4f.png&r=x","gravatar_id":"f9759b728f6026571043dc66cd36edf2","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ansible/ansible","description":"Ansible is a radically simple IT automation platform that makes your applications and systems easier to deploy. Avoid writing scripts or custom code to deploy and update your applications— automate in a language that approaches plain English, using SSH, with no agents to install on remote systems.","fork":false,"url":"https://api.github.com/repos/ansible/ansible","forks_url":"https://api.github.com/repos/ansible/ansible/forks","keys_url":"https://api.github.com/repos/ansible/ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ansible/ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ansible/ansible/teams","hooks_url":"https://api.github.com/repos/ansible/ansible/hooks","issue_events_url":"https://api.github.com/repos/ansible/ansible/issues/events{/number}","events_url":"https://api.github.com/repos/ansible/ansible/events","assignees_url":"https://api.github.com/repos/ansible/ansible/assignees{/user}","branches_url":"https://api.github.com/repos/ansible/ansible/branches{/branch}","tags_url":"https://api.github.com/repos/ansible/ansible/tags","blobs_url":"https://api.github.com/repos/ansible/ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ansible/ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ansible/ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/ansible/ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ansible/ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/ansible/ansible/languages","stargazers_url":"https://api.github.com/repos/ansible/ansible/stargazers","contributors_url":"https://api.github.com/repos/ansible/ansible/contributors","subscribers_url":"https://api.github.com/repos/ansible/ansible/subscribers","subscription_url":"https://api.github.com/repos/ansible/ansible/subscription","commits_url":"https://api.github.com/repos/ansible/ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/ansible/ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/ansible/ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/ansible/ansible/issues/comments/{number}","contents_url":"https://api.github.com/repos/ansible/ansible/contents/{+path}","compare_url":"https://api.github.com/repos/ansible/ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ansible/ansible/merges","archive_url":"https://api.github.com/repos/ansible/ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ansible/ansible/downloads","issues_url":"https://api.github.com/repos/ansible/ansible/issues{/number}","pulls_url":"https://api.github.com/repos/ansible/ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/ansible/ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/ansible/ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ansible/ansible/labels{/name}","releases_url":"https://api.github.com/repos/ansible/ansible/releases{/id}","created_at":"2012-03-06T14:58:02Z","updated_at":"2014-03-07T22:38:47Z","pushed_at":"2014-03-07T22:38:48Z","git_url":"git://github.com/ansible/ansible.git","ssh_url":"git@github.com:ansible/ansible.git","clone_url":"https://github.com/ansible/ansible.git","svn_url":"https://github.com/ansible/ansible","homepage":"http://ansible.com/","size":79720,"stargazers_count":4935,"watchers_count":4935,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":1457,"mirror_url":null,"open_issues_count":458,"forks":1457,"open_issues":458,"watchers":4935,"default_branch":"devel","master_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/ansible/ansible/pulls/6337"},"html":{"href":"https://github.com/ansible/ansible/pull/6337"},"issue":{"href":"https://api.github.com/repos/ansible/ansible/issues/6337"},"comments":{"href":"https://api.github.com/repos/ansible/ansible/issues/6337/comments"},"review_comments":{"href":"https://api.github.com/repos/ansible/ansible/pulls/6337/comments"},"review_comment":{"href":"https://api.github.com/repos/ansible/ansible/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ansible/ansible/pulls/6337/commits"},"statuses":{"href":"https://api.github.com/repos/ansible/ansible/statuses/adf4cde778c8f362c6ca3b605bdeffd46661d07e"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":5,"deletions":4,"changed_files":1}}