GitHub PullRequestEvent at 2014-09-18 13:06:57
Repository: AITwitterAuth
Actor: aibrahim16
Payload: {"action":"closed","number":1,"pull_request":{"url":"https://api.github.com/repos/aibrahim16/AITwitterAuth/pulls/1","id":21295615,"html_url":"https://github.com/aibrahim16/AITwitterAuth/pull/1","diff_url":"https://github.com/aibrahim16/AITwitterAuth/pull/1.diff","patch_url":"https://github.com/aibrahim16/AITwitterAuth/pull/1.patch","issue_url":"https://api.github.com/repos/aibrahim16/AITwitterAuth/issues/1","number":1,"state":"closed","locked":false,"title":"Added missing action sheet to choose between multiple twitter accounts","user":{"login":"pablolvillar","id":5367133,"avatar_url":"https://avatars.githubusercontent.com/u/5367133?v=2","gravatar_id":"ee32a7445a63a2f1efdbf649f581fbf3","url":"https://api.github.com/users/pablolvillar","html_url":"https://github.com/pablolvillar","followers_url":"https://api.github.com/users/pablolvillar/followers","following_url":"https://api.github.com/users/pablolvillar/following{/other_user}","gists_url":"https://api.github.com/users/pablolvillar/gists{/gist_id}","starred_url":"https://api.github.com/users/pablolvillar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pablolvillar/subscriptions","organizations_url":"https://api.github.com/users/pablolvillar/orgs","repos_url":"https://api.github.com/users/pablolvillar/repos","events_url":"https://api.github.com/users/pablolvillar/events{/privacy}","received_events_url":"https://api.github.com/users/pablolvillar/received_events","type":"User","site_admin":false},"body":"Hey guys! I came across your code and found out that you were missing showing an action sheet when multiple twitter accounts were configured on device, so that the user is able to pick one of them to authenticate.\r\n\r\nI just added the necessary code in AITwitterAuth.m, and needed to add some category on UIActionSheet to handle callbacks via blocks instead of delegates (as that part was done inside a class method).\r\n\r\nI have no idea why the pod-related files did mess up, all I did was run \"pod install\" in order to be able to compile.\r\n\r\nCheers!","created_at":"2014-09-16T12:53:09Z","updated_at":"2014-09-18T13:06:57Z","closed_at":"2014-09-18T13:06:57Z","merged_at":"2014-09-18T13:06:57Z","merge_commit_sha":"f2103365e41f6eed90d377cb5e69aad48b3a4b5b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/aibrahim16/AITwitterAuth/pulls/1/commits","review_comments_url":"https://api.github.com/repos/aibrahim16/AITwitterAuth/pulls/1/comments","review_comment_url":"https://api.github.com/repos/aibrahim16/AITwitterAuth/pulls/comments/{number}","comments_url":"https://api.github.com/repos/aibrahim16/AITwitterAuth/issues/1/comments","statuses_url":"https://api.github.com/repos/aibrahim16/AITwitterAuth/statuses/a50001270e91909a6f1a79ffd04d80088095186a","head":{"label":"inaka:master","ref":"master","sha":"a50001270e91909a6f1a79ffd04d80088095186a","user":{"login":"inaka","id":867053,"avatar_url":"https://avatars.githubusercontent.com/u/867053?v=2","gravatar_id":"1965362c650bbdd4cbaadf0f1ac45f7e","url":"https://api.github.com/users/inaka","html_url":"https://github.com/inaka","followers_url":"https://api.github.com/users/inaka/followers","following_url":"https://api.github.com/users/inaka/following{/other_user}","gists_url":"https://api.github.com/users/inaka/gists{/gist_id}","starred_url":"https://api.github.com/users/inaka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inaka/subscriptions","organizations_url":"https://api.github.com/users/inaka/orgs","repos_url":"https://api.github.com/users/inaka/repos","events_url":"https://api.github.com/users/inaka/events{/privacy}","received_events_url":"https://api.github.com/users/inaka/received_events","type":"Organization","site_admin":false},"repo":{"id":24072050,"name":"AITwitterAuth","full_name":"inaka/AITwitterAuth","owner":{"login":"inaka","id":867053,"avatar_url":"https://avatars.githubusercontent.com/u/867053?v=2","gravatar_id":"1965362c650bbdd4cbaadf0f1ac45f7e","url":"https://api.github.com/users/inaka","html_url":"https://github.com/inaka","followers_url":"https://api.github.com/users/inaka/followers","following_url":"https://api.github.com/users/inaka/following{/other_user}","gists_url":"https://api.github.com/users/inaka/gists{/gist_id}","starred_url":"https://api.github.com/users/inaka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inaka/subscriptions","organizations_url":"https://api.github.com/users/inaka/orgs","repos_url":"https://api.github.com/users/inaka/repos","events_url":"https://api.github.com/users/inaka/events{/privacy}","received_events_url":"https://api.github.com/users/inaka/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/inaka/AITwitterAuth","description":"","fork":true,"url":"https://api.github.com/repos/inaka/AITwitterAuth","forks_url":"https://api.github.com/repos/inaka/AITwitterAuth/forks","keys_url":"https://api.github.com/repos/inaka/AITwitterAuth/keys{/key_id}","collaborators_url":"https://api.github.com/repos/inaka/AITwitterAuth/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/inaka/AITwitterAuth/teams","hooks_url":"https://api.github.com/repos/inaka/AITwitterAuth/hooks","issue_events_url":"https://api.github.com/repos/inaka/AITwitterAuth/issues/events{/number}","events_url":"https://api.github.com/repos/inaka/AITwitterAuth/events","assignees_url":"https://api.github.com/repos/inaka/AITwitterAuth/assignees{/user}","branches_url":"https://api.github.com/repos/inaka/AITwitterAuth/branches{/branch}","tags_url":"https://api.github.com/repos/inaka/AITwitterAuth/tags","blobs_url":"https://api.github.com/repos/inaka/AITwitterAuth/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/inaka/AITwitterAuth/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/inaka/AITwitterAuth/git/refs{/sha}","trees_url":"https://api.github.com/repos/inaka/AITwitterAuth/git/trees{/sha}","statuses_url":"https://api.github.com/repos/inaka/AITwitterAuth/statuses/{sha}","languages_url":"https://api.github.com/repos/inaka/AITwitterAuth/languages","stargazers_url":"https://api.github.com/repos/inaka/AITwitterAuth/stargazers","contributors_url":"https://api.github.com/repos/inaka/AITwitterAuth/contributors","subscribers_url":"https://api.github.com/repos/inaka/AITwitterAuth/subscribers","subscription_url":"https://api.github.com/repos/inaka/AITwitterAuth/subscription","commits_url":"https://api.github.com/repos/inaka/AITwitterAuth/commits{/sha}","git_commits_url":"https://api.github.com/repos/inaka/AITwitterAuth/git/commits{/sha}","comments_url":"https://api.github.com/repos/inaka/AITwitterAuth/comments{/number}","issue_comment_url":"https://api.github.com/repos/inaka/AITwitterAuth/issues/comments/{number}","contents_url":"https://api.github.com/repos/inaka/AITwitterAuth/contents/{+path}","compare_url":"https://api.github.com/repos/inaka/AITwitterAuth/compare/{base}...{head}","merges_url":"https://api.github.com/repos/inaka/AITwitterAuth/merges","archive_url":"https://api.github.com/repos/inaka/AITwitterAuth/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/inaka/AITwitterAuth/downloads","issues_url":"https://api.github.com/repos/inaka/AITwitterAuth/issues{/number}","pulls_url":"https://api.github.com/repos/inaka/AITwitterAuth/pulls{/number}","milestones_url":"https://api.github.com/repos/inaka/AITwitterAuth/milestones{/number}","notifications_url":"https://api.github.com/repos/inaka/AITwitterAuth/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/inaka/AITwitterAuth/labels{/name}","releases_url":"https://api.github.com/repos/inaka/AITwitterAuth/releases{/id}","created_at":"2014-09-15T20:12:58Z","updated_at":"2014-09-16T12:44:48Z","pushed_at":"2014-09-16T13:17:31Z","git_url":"git://github.com/inaka/AITwitterAuth.git","ssh_url":"git@github.com:inaka/AITwitterAuth.git","clone_url":"https://github.com/inaka/AITwitterAuth.git","svn_url":"https://github.com/inaka/AITwitterAuth","homepage":null,"size":262,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"aibrahim16:master","ref":"master","sha":"9e15865f9951656e81a0d17d699c056fdb439bb2","user":{"login":"aibrahim16","id":7276926,"avatar_url":"https://avatars.githubusercontent.com/u/7276926?v=2","gravatar_id":"ce9bbf1a04338234f972c6ee0e75937d","url":"https://api.github.com/users/aibrahim16","html_url":"https://github.com/aibrahim16","followers_url":"https://api.github.com/users/aibrahim16/followers","following_url":"https://api.github.com/users/aibrahim16/following{/other_user}","gists_url":"https://api.github.com/users/aibrahim16/gists{/gist_id}","starred_url":"https://api.github.com/users/aibrahim16/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aibrahim16/subscriptions","organizations_url":"https://api.github.com/users/aibrahim16/orgs","repos_url":"https://api.github.com/users/aibrahim16/repos","events_url":"https://api.github.com/users/aibrahim16/events{/privacy}","received_events_url":"https://api.github.com/users/aibrahim16/received_events","type":"User","site_admin":false},"repo":{"id":23050678,"name":"AITwitterAuth","full_name":"aibrahim16/AITwitterAuth","owner":{"login":"aibrahim16","id":7276926,"avatar_url":"https://avatars.githubusercontent.com/u/7276926?v=2","gravatar_id":"ce9bbf1a04338234f972c6ee0e75937d","url":"https://api.github.com/users/aibrahim16","html_url":"https://github.com/aibrahim16","followers_url":"https://api.github.com/users/aibrahim16/followers","following_url":"https://api.github.com/users/aibrahim16/following{/other_user}","gists_url":"https://api.github.com/users/aibrahim16/gists{/gist_id}","starred_url":"https://api.github.com/users/aibrahim16/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aibrahim16/subscriptions","organizations_url":"https://api.github.com/users/aibrahim16/orgs","repos_url":"https://api.github.com/users/aibrahim16/repos","events_url":"https://api.github.com/users/aibrahim16/events{/privacy}","received_events_url":"https://api.github.com/users/aibrahim16/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aibrahim16/AITwitterAuth","description":"","fork":false,"url":"https://api.github.com/repos/aibrahim16/AITwitterAuth","forks_url":"https://api.github.com/repos/aibrahim16/AITwitterAuth/forks","keys_url":"https://api.github.com/repos/aibrahim16/AITwitterAuth/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aibrahim16/AITwitterAuth/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aibrahim16/AITwitterAuth/teams","hooks_url":"https://api.github.com/repos/aibrahim16/AITwitterAuth/hooks","issue_events_url":"https://api.github.com/repos/aibrahim16/AITwitterAuth/issues/events{/number}","events_url":"https://api.github.com/repos/aibrahim16/AITwitterAuth/events","assignees_url":"https://api.github.com/repos/aibrahim16/AITwitterAuth/assignees{/user}","branches_url":"https://api.github.com/repos/aibrahim16/AITwitterAuth/branches{/branch}","tags_url":"https://api.github.com/repos/aibrahim16/AITwitterAuth/tags","blobs_url":"https://api.github.com/repos/aibrahim16/AITwitterAuth/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aibrahim16/AITwitterAuth/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aibrahim16/AITwitterAuth/git/refs{/sha}","trees_url":"https://api.github.com/repos/aibrahim16/AITwitterAuth/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aibrahim16/AITwitterAuth/statuses/{sha}","languages_url":"https://api.github.com/repos/aibrahim16/AITwitterAuth/languages","stargazers_url":"https://api.github.com/repos/aibrahim16/AITwitterAuth/stargazers","contributors_url":"https://api.github.com/repos/aibrahim16/AITwitterAuth/contributors","subscribers_url":"https://api.github.com/repos/aibrahim16/AITwitterAuth/subscribers","subscription_url":"https://api.github.com/repos/aibrahim16/AITwitterAuth/subscription","commits_url":"https://api.github.com/repos/aibrahim16/AITwitterAuth/commits{/sha}","git_commits_url":"https://api.github.com/repos/aibrahim16/AITwitterAuth/git/commits{/sha}","comments_url":"https://api.github.com/repos/aibrahim16/AITwitterAuth/comments{/number}","issue_comment_url":"https://api.github.com/repos/aibrahim16/AITwitterAuth/issues/comments/{number}","contents_url":"https://api.github.com/repos/aibrahim16/AITwitterAuth/contents/{+path}","compare_url":"https://api.github.com/repos/aibrahim16/AITwitterAuth/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aibrahim16/AITwitterAuth/merges","archive_url":"https://api.github.com/repos/aibrahim16/AITwitterAuth/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aibrahim16/AITwitterAuth/downloads","issues_url":"https://api.github.com/repos/aibrahim16/AITwitterAuth/issues{/number}","pulls_url":"https://api.github.com/repos/aibrahim16/AITwitterAuth/pulls{/number}","milestones_url":"https://api.github.com/repos/aibrahim16/AITwitterAuth/milestones{/number}","notifications_url":"https://api.github.com/repos/aibrahim16/AITwitterAuth/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aibrahim16/AITwitterAuth/labels{/name}","releases_url":"https://api.github.com/repos/aibrahim16/AITwitterAuth/releases{/id}","created_at":"2014-08-17T21:16:37Z","updated_at":"2014-08-26T19:29:39Z","pushed_at":"2014-09-18T13:06:57Z","git_url":"git://github.com/aibrahim16/AITwitterAuth.git","ssh_url":"git@github.com:aibrahim16/AITwitterAuth.git","clone_url":"https://github.com/aibrahim16/AITwitterAuth.git","svn_url":"https://github.com/aibrahim16/AITwitterAuth","homepage":null,"size":300,"stargazers_count":2,"watchers_count":2,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aibrahim16/AITwitterAuth/pulls/1"},"html":{"href":"https://github.com/aibrahim16/AITwitterAuth/pull/1"},"issue":{"href":"https://api.github.com/repos/aibrahim16/AITwitterAuth/issues/1"},"comments":{"href":"https://api.github.com/repos/aibrahim16/AITwitterAuth/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/aibrahim16/AITwitterAuth/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/aibrahim16/AITwitterAuth/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/aibrahim16/AITwitterAuth/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/aibrahim16/AITwitterAuth/statuses/a50001270e91909a6f1a79ffd04d80088095186a"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"aibrahim16","id":7276926,"avatar_url":"https://avatars.githubusercontent.com/u/7276926?v=2","gravatar_id":"ce9bbf1a04338234f972c6ee0e75937d","url":"https://api.github.com/users/aibrahim16","html_url":"https://github.com/aibrahim16","followers_url":"https://api.github.com/users/aibrahim16/followers","following_url":"https://api.github.com/users/aibrahim16/following{/other_user}","gists_url":"https://api.github.com/users/aibrahim16/gists{/gist_id}","starred_url":"https://api.github.com/users/aibrahim16/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aibrahim16/subscriptions","organizations_url":"https://api.github.com/users/aibrahim16/orgs","repos_url":"https://api.github.com/users/aibrahim16/repos","events_url":"https://api.github.com/users/aibrahim16/events{/privacy}","received_events_url":"https://api.github.com/users/aibrahim16/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":5,"additions":1738,"deletions":988,"changed_files":17}}