GitHub PullRequestEvent at 2014-02-07 15:32:58
Repository: inspircd
Actor: ShutterQuick
Payload: {"action":"opened","number":767,"pull_request":{"url":"https://api.github.com/repos/inspircd/inspircd/pulls/767","id":12316060,"html_url":"https://github.com/inspircd/inspircd/pull/767","diff_url":"https://github.com/inspircd/inspircd/pull/767.diff","patch_url":"https://github.com/inspircd/inspircd/pull/767.patch","issue_url":"https://api.github.com/repos/inspircd/inspircd/issues/767","number":767,"state":"open","title":"[WIP] Simplify hashing","user":{"login":"ShutterQuick","id":2367571,"avatar_url":"https://gravatar.com/avatar/64ff9f981fd5a447d2eb7348eb692ea9?d=https%3A%2F%2Fidenticons.github.com%2F507813dd45b06dadb5f659eb11bbbbc2.png&r=x","gravatar_id":"64ff9f981fd5a447d2eb7348eb692ea9","url":"https://api.github.com/users/ShutterQuick","html_url":"https://github.com/ShutterQuick","followers_url":"https://api.github.com/users/ShutterQuick/followers","following_url":"https://api.github.com/users/ShutterQuick/following{/other_user}","gists_url":"https://api.github.com/users/ShutterQuick/gists{/gist_id}","starred_url":"https://api.github.com/users/ShutterQuick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ShutterQuick/subscriptions","organizations_url":"https://api.github.com/users/ShutterQuick/orgs","repos_url":"https://api.github.com/users/ShutterQuick/repos","events_url":"https://api.github.com/users/ShutterQuick/events{/privacy}","received_events_url":"https://api.github.com/users/ShutterQuick/received_events","type":"User","site_admin":false},"body":"Would be nice to get some comments on this.\r\n\r\n* Kill OnPassCompare() with fire\r\n* Move HMAC and password comparison out of m_password_hash, into the core\r\n* Add a Compare function to hash providers, as == does not do it in the case of e.g. bcrypt\r\n* Add a bcrypt module\r\n* Rename functions to be more intuitive\r\n* Generate() takes a parameter to decide of it returns it's RAW format, e.g. for storage, or it's printable (default param).","created_at":"2014-02-07T15:32:56Z","updated_at":"2014-02-07T15:32:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/inspircd/inspircd/pulls/767/commits","review_comments_url":"https://api.github.com/repos/inspircd/inspircd/pulls/767/comments","review_comment_url":"https://api.github.com/repos/inspircd/inspircd/pulls/comments/{number}","comments_url":"https://api.github.com/repos/inspircd/inspircd/issues/767/comments","statuses_url":"https://api.github.com/repos/inspircd/inspircd/statuses/2e370afc06f8991fa273d45166a4256b31826002","head":{"label":"ShutterQuick:master+nopasscompare","ref":"master+nopasscompare","sha":"2e370afc06f8991fa273d45166a4256b31826002","user":{"login":"ShutterQuick","id":2367571,"avatar_url":"https://gravatar.com/avatar/64ff9f981fd5a447d2eb7348eb692ea9?d=https%3A%2F%2Fidenticons.github.com%2F507813dd45b06dadb5f659eb11bbbbc2.png&r=x","gravatar_id":"64ff9f981fd5a447d2eb7348eb692ea9","url":"https://api.github.com/users/ShutterQuick","html_url":"https://github.com/ShutterQuick","followers_url":"https://api.github.com/users/ShutterQuick/followers","following_url":"https://api.github.com/users/ShutterQuick/following{/other_user}","gists_url":"https://api.github.com/users/ShutterQuick/gists{/gist_id}","starred_url":"https://api.github.com/users/ShutterQuick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ShutterQuick/subscriptions","organizations_url":"https://api.github.com/users/ShutterQuick/orgs","repos_url":"https://api.github.com/users/ShutterQuick/repos","events_url":"https://api.github.com/users/ShutterQuick/events{/privacy}","received_events_url":"https://api.github.com/users/ShutterQuick/received_events","type":"User","site_admin":false},"repo":{"id":6345114,"name":"inspircd","full_name":"ShutterQuick/inspircd","owner":{"login":"ShutterQuick","id":2367571,"avatar_url":"https://gravatar.com/avatar/64ff9f981fd5a447d2eb7348eb692ea9?d=https%3A%2F%2Fidenticons.github.com%2F507813dd45b06dadb5f659eb11bbbbc2.png&r=x","gravatar_id":"64ff9f981fd5a447d2eb7348eb692ea9","url":"https://api.github.com/users/ShutterQuick","html_url":"https://github.com/ShutterQuick","followers_url":"https://api.github.com/users/ShutterQuick/followers","following_url":"https://api.github.com/users/ShutterQuick/following{/other_user}","gists_url":"https://api.github.com/users/ShutterQuick/gists{/gist_id}","starred_url":"https://api.github.com/users/ShutterQuick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ShutterQuick/subscriptions","organizations_url":"https://api.github.com/users/ShutterQuick/orgs","repos_url":"https://api.github.com/users/ShutterQuick/repos","events_url":"https://api.github.com/users/ShutterQuick/events{/privacy}","received_events_url":"https://api.github.com/users/ShutterQuick/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ShutterQuick/inspircd","description":"Main inspircd repository.","fork":true,"url":"https://api.github.com/repos/ShutterQuick/inspircd","forks_url":"https://api.github.com/repos/ShutterQuick/inspircd/forks","keys_url":"https://api.github.com/repos/ShutterQuick/inspircd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ShutterQuick/inspircd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ShutterQuick/inspircd/teams","hooks_url":"https://api.github.com/repos/ShutterQuick/inspircd/hooks","issue_events_url":"https://api.github.com/repos/ShutterQuick/inspircd/issues/events{/number}","events_url":"https://api.github.com/repos/ShutterQuick/inspircd/events","assignees_url":"https://api.github.com/repos/ShutterQuick/inspircd/assignees{/user}","branches_url":"https://api.github.com/repos/ShutterQuick/inspircd/branches{/branch}","tags_url":"https://api.github.com/repos/ShutterQuick/inspircd/tags","blobs_url":"https://api.github.com/repos/ShutterQuick/inspircd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ShutterQuick/inspircd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ShutterQuick/inspircd/git/refs{/sha}","trees_url":"https://api.github.com/repos/ShutterQuick/inspircd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ShutterQuick/inspircd/statuses/{sha}","languages_url":"https://api.github.com/repos/ShutterQuick/inspircd/languages","stargazers_url":"https://api.github.com/repos/ShutterQuick/inspircd/stargazers","contributors_url":"https://api.github.com/repos/ShutterQuick/inspircd/contributors","subscribers_url":"https://api.github.com/repos/ShutterQuick/inspircd/subscribers","subscription_url":"https://api.github.com/repos/ShutterQuick/inspircd/subscription","commits_url":"https://api.github.com/repos/ShutterQuick/inspircd/commits{/sha}","git_commits_url":"https://api.github.com/repos/ShutterQuick/inspircd/git/commits{/sha}","comments_url":"https://api.github.com/repos/ShutterQuick/inspircd/comments{/number}","issue_comment_url":"https://api.github.com/repos/ShutterQuick/inspircd/issues/comments/{number}","contents_url":"https://api.github.com/repos/ShutterQuick/inspircd/contents/{+path}","compare_url":"https://api.github.com/repos/ShutterQuick/inspircd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ShutterQuick/inspircd/merges","archive_url":"https://api.github.com/repos/ShutterQuick/inspircd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ShutterQuick/inspircd/downloads","issues_url":"https://api.github.com/repos/ShutterQuick/inspircd/issues{/number}","pulls_url":"https://api.github.com/repos/ShutterQuick/inspircd/pulls{/number}","milestones_url":"https://api.github.com/repos/ShutterQuick/inspircd/milestones{/number}","notifications_url":"https://api.github.com/repos/ShutterQuick/inspircd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ShutterQuick/inspircd/labels{/name}","releases_url":"https://api.github.com/repos/ShutterQuick/inspircd/releases{/id}","created_at":"2012-10-23T01:30:22Z","updated_at":"2014-02-07T15:32:56Z","pushed_at":"2014-01-30T15:08:29Z","git_url":"git://github.com/ShutterQuick/inspircd.git","ssh_url":"git@github.com:ShutterQuick/inspircd.git","clone_url":"https://github.com/ShutterQuick/inspircd.git","svn_url":"https://github.com/ShutterQuick/inspircd","homepage":"http://inspircd.github.com","size":25534,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"insp20","master_branch":"insp20"}},"base":{"label":"inspircd:master","ref":"master","sha":"a8b986bd785eeef1d3415da8e8bf7e599dad0377","user":{"login":"inspircd","id":1560750,"avatar_url":"https://gravatar.com/avatar/3e2995ddeeb49155df25935d04532f09?d=https%3A%2F%2Fidenticons.github.com%2F589ff7fdf26466bd97fb525aadb90e11.png&r=x","gravatar_id":"3e2995ddeeb49155df25935d04532f09","url":"https://api.github.com/users/inspircd","html_url":"https://github.com/inspircd","followers_url":"https://api.github.com/users/inspircd/followers","following_url":"https://api.github.com/users/inspircd/following{/other_user}","gists_url":"https://api.github.com/users/inspircd/gists{/gist_id}","starred_url":"https://api.github.com/users/inspircd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inspircd/subscriptions","organizations_url":"https://api.github.com/users/inspircd/orgs","repos_url":"https://api.github.com/users/inspircd/repos","events_url":"https://api.github.com/users/inspircd/events{/privacy}","received_events_url":"https://api.github.com/users/inspircd/received_events","type":"Organization","site_admin":false},"repo":{"id":3786218,"name":"inspircd","full_name":"inspircd/inspircd","owner":{"login":"inspircd","id":1560750,"avatar_url":"https://gravatar.com/avatar/3e2995ddeeb49155df25935d04532f09?d=https%3A%2F%2Fidenticons.github.com%2F589ff7fdf26466bd97fb525aadb90e11.png&r=x","gravatar_id":"3e2995ddeeb49155df25935d04532f09","url":"https://api.github.com/users/inspircd","html_url":"https://github.com/inspircd","followers_url":"https://api.github.com/users/inspircd/followers","following_url":"https://api.github.com/users/inspircd/following{/other_user}","gists_url":"https://api.github.com/users/inspircd/gists{/gist_id}","starred_url":"https://api.github.com/users/inspircd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inspircd/subscriptions","organizations_url":"https://api.github.com/users/inspircd/orgs","repos_url":"https://api.github.com/users/inspircd/repos","events_url":"https://api.github.com/users/inspircd/events{/privacy}","received_events_url":"https://api.github.com/users/inspircd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/inspircd/inspircd","description":"Main inspircd repository.","fork":false,"url":"https://api.github.com/repos/inspircd/inspircd","forks_url":"https://api.github.com/repos/inspircd/inspircd/forks","keys_url":"https://api.github.com/repos/inspircd/inspircd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/inspircd/inspircd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/inspircd/inspircd/teams","hooks_url":"https://api.github.com/repos/inspircd/inspircd/hooks","issue_events_url":"https://api.github.com/repos/inspircd/inspircd/issues/events{/number}","events_url":"https://api.github.com/repos/inspircd/inspircd/events","assignees_url":"https://api.github.com/repos/inspircd/inspircd/assignees{/user}","branches_url":"https://api.github.com/repos/inspircd/inspircd/branches{/branch}","tags_url":"https://api.github.com/repos/inspircd/inspircd/tags","blobs_url":"https://api.github.com/repos/inspircd/inspircd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/inspircd/inspircd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/inspircd/inspircd/git/refs{/sha}","trees_url":"https://api.github.com/repos/inspircd/inspircd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/inspircd/inspircd/statuses/{sha}","languages_url":"https://api.github.com/repos/inspircd/inspircd/languages","stargazers_url":"https://api.github.com/repos/inspircd/inspircd/stargazers","contributors_url":"https://api.github.com/repos/inspircd/inspircd/contributors","subscribers_url":"https://api.github.com/repos/inspircd/inspircd/subscribers","subscription_url":"https://api.github.com/repos/inspircd/inspircd/subscription","commits_url":"https://api.github.com/repos/inspircd/inspircd/commits{/sha}","git_commits_url":"https://api.github.com/repos/inspircd/inspircd/git/commits{/sha}","comments_url":"https://api.github.com/repos/inspircd/inspircd/comments{/number}","issue_comment_url":"https://api.github.com/repos/inspircd/inspircd/issues/comments/{number}","contents_url":"https://api.github.com/repos/inspircd/inspircd/contents/{+path}","compare_url":"https://api.github.com/repos/inspircd/inspircd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/inspircd/inspircd/merges","archive_url":"https://api.github.com/repos/inspircd/inspircd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/inspircd/inspircd/downloads","issues_url":"https://api.github.com/repos/inspircd/inspircd/issues{/number}","pulls_url":"https://api.github.com/repos/inspircd/inspircd/pulls{/number}","milestones_url":"https://api.github.com/repos/inspircd/inspircd/milestones{/number}","notifications_url":"https://api.github.com/repos/inspircd/inspircd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/inspircd/inspircd/labels{/name}","releases_url":"https://api.github.com/repos/inspircd/inspircd/releases{/id}","created_at":"2012-03-21T12:22:32Z","updated_at":"2014-02-06T21:57:23Z","pushed_at":"2014-02-06T21:57:22Z","git_url":"git://github.com/inspircd/inspircd.git","ssh_url":"git@github.com:inspircd/inspircd.git","clone_url":"https://github.com/inspircd/inspircd.git","svn_url":"https://github.com/inspircd/inspircd","homepage":"http://inspircd.org","size":31519,"stargazers_count":224,"watchers_count":224,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":89,"mirror_url":null,"open_issues_count":123,"forks":89,"open_issues":123,"watchers":224,"default_branch":"master","master_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/inspircd/inspircd/pulls/767"},"html":{"href":"https://github.com/inspircd/inspircd/pull/767"},"issue":{"href":"https://api.github.com/repos/inspircd/inspircd/issues/767"},"comments":{"href":"https://api.github.com/repos/inspircd/inspircd/issues/767/comments"},"review_comments":{"href":"https://api.github.com/repos/inspircd/inspircd/pulls/767/comments"},"review_comment":{"href":"https://api.github.com/repos/inspircd/inspircd/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/inspircd/inspircd/pulls/767/commits"},"statuses":{"href":"https://api.github.com/repos/inspircd/inspircd/statuses/2e370afc06f8991fa273d45166a4256b31826002"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":207,"deletions":106,"changed_files":13}}