GitHub PullRequestEvent at 2014-08-20 20:38:12
Repository: jruby
Actor: headius
Payload: {"action":"closed","number":1864,"pull_request":{"url":"https://api.github.com/repos/jruby/jruby/pulls/1864","id":18941491,"html_url":"https://github.com/jruby/jruby/pull/1864","diff_url":"https://github.com/jruby/jruby/pull/1864.diff","patch_url":"https://github.com/jruby/jruby/pull/1864.patch","issue_url":"https://api.github.com/repos/jruby/jruby/issues/1864","number":1864,"state":"closed","locked":false,"title":"Avoid creating a throwaway raise exception","user":{"login":"grddev","id":1210048,"avatar_url":"https://avatars.githubusercontent.com/u/1210048?v=2","gravatar_id":"4210e71defcc1f6bc5477af53d792a5f","url":"https://api.github.com/users/grddev","html_url":"https://github.com/grddev","followers_url":"https://api.github.com/users/grddev/followers","following_url":"https://api.github.com/users/grddev/following{/other_user}","gists_url":"https://api.github.com/users/grddev/gists{/gist_id}","starred_url":"https://api.github.com/users/grddev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grddev/subscriptions","organizations_url":"https://api.github.com/users/grddev/orgs","repos_url":"https://api.github.com/users/grddev/repos","events_url":"https://api.github.com/users/grddev/events{/privacy}","received_events_url":"https://api.github.com/users/grddev/received_events","type":"User","site_admin":false},"body":"In particular, a long error message including the java stack trace was being built and then discarded.\r\n\r\nIn general, it is unclear to me why `createNativeRaiseException` calls `buildMessage` (twice), but for the case where we rewrite an existing stack trace, the message is obviously discarded, so I took the safe route and just specialized the rewrite stack trace case.\r\n\r\nOverall, it is unclear to me why exception backtraces are being rewritten from `JavaCallable` and `invokedynamic.InvocationLinker`, whereas in places like `Reflected{Java,Compiled}Method` the exceptions are wrapped in `RaiseException`s.","created_at":"2014-07-27T15:06:26Z","updated_at":"2014-08-20T20:38:12Z","closed_at":"2014-08-20T20:38:12Z","merged_at":"2014-08-20T20:38:12Z","merge_commit_sha":"96d7e89f44edef9661a3446dae2b742ace12c80b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jruby/jruby/pulls/1864/commits","review_comments_url":"https://api.github.com/repos/jruby/jruby/pulls/1864/comments","review_comment_url":"https://api.github.com/repos/jruby/jruby/pulls/comments/{number}","comments_url":"https://api.github.com/repos/jruby/jruby/issues/1864/comments","statuses_url":"https://api.github.com/repos/jruby/jruby/statuses/134754851486f9305daba4184467b48a1e1185c0","head":{"label":"grddev:rewrite-stacktrace-performance","ref":"rewrite-stacktrace-performance","sha":"134754851486f9305daba4184467b48a1e1185c0","user":{"login":"grddev","id":1210048,"avatar_url":"https://avatars.githubusercontent.com/u/1210048?v=2","gravatar_id":"4210e71defcc1f6bc5477af53d792a5f","url":"https://api.github.com/users/grddev","html_url":"https://github.com/grddev","followers_url":"https://api.github.com/users/grddev/followers","following_url":"https://api.github.com/users/grddev/following{/other_user}","gists_url":"https://api.github.com/users/grddev/gists{/gist_id}","starred_url":"https://api.github.com/users/grddev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grddev/subscriptions","organizations_url":"https://api.github.com/users/grddev/orgs","repos_url":"https://api.github.com/users/grddev/repos","events_url":"https://api.github.com/users/grddev/events{/privacy}","received_events_url":"https://api.github.com/users/grddev/received_events","type":"User","site_admin":false},"repo":{"id":10052080,"name":"jruby","full_name":"grddev/jruby","owner":{"login":"grddev","id":1210048,"avatar_url":"https://avatars.githubusercontent.com/u/1210048?v=2","gravatar_id":"4210e71defcc1f6bc5477af53d792a5f","url":"https://api.github.com/users/grddev","html_url":"https://github.com/grddev","followers_url":"https://api.github.com/users/grddev/followers","following_url":"https://api.github.com/users/grddev/following{/other_user}","gists_url":"https://api.github.com/users/grddev/gists{/gist_id}","starred_url":"https://api.github.com/users/grddev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grddev/subscriptions","organizations_url":"https://api.github.com/users/grddev/orgs","repos_url":"https://api.github.com/users/grddev/repos","events_url":"https://api.github.com/users/grddev/events{/privacy}","received_events_url":"https://api.github.com/users/grddev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/grddev/jruby","description":"JRuby, an implementation of Ruby on the JVM","fork":true,"url":"https://api.github.com/repos/grddev/jruby","forks_url":"https://api.github.com/repos/grddev/jruby/forks","keys_url":"https://api.github.com/repos/grddev/jruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grddev/jruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grddev/jruby/teams","hooks_url":"https://api.github.com/repos/grddev/jruby/hooks","issue_events_url":"https://api.github.com/repos/grddev/jruby/issues/events{/number}","events_url":"https://api.github.com/repos/grddev/jruby/events","assignees_url":"https://api.github.com/repos/grddev/jruby/assignees{/user}","branches_url":"https://api.github.com/repos/grddev/jruby/branches{/branch}","tags_url":"https://api.github.com/repos/grddev/jruby/tags","blobs_url":"https://api.github.com/repos/grddev/jruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grddev/jruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grddev/jruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/grddev/jruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grddev/jruby/statuses/{sha}","languages_url":"https://api.github.com/repos/grddev/jruby/languages","stargazers_url":"https://api.github.com/repos/grddev/jruby/stargazers","contributors_url":"https://api.github.com/repos/grddev/jruby/contributors","subscribers_url":"https://api.github.com/repos/grddev/jruby/subscribers","subscription_url":"https://api.github.com/repos/grddev/jruby/subscription","commits_url":"https://api.github.com/repos/grddev/jruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/grddev/jruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/grddev/jruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/grddev/jruby/issues/comments/{number}","contents_url":"https://api.github.com/repos/grddev/jruby/contents/{+path}","compare_url":"https://api.github.com/repos/grddev/jruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grddev/jruby/merges","archive_url":"https://api.github.com/repos/grddev/jruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grddev/jruby/downloads","issues_url":"https://api.github.com/repos/grddev/jruby/issues{/number}","pulls_url":"https://api.github.com/repos/grddev/jruby/pulls{/number}","milestones_url":"https://api.github.com/repos/grddev/jruby/milestones{/number}","notifications_url":"https://api.github.com/repos/grddev/jruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grddev/jruby/labels{/name}","releases_url":"https://api.github.com/repos/grddev/jruby/releases{/id}","created_at":"2013-05-14T09:43:22Z","updated_at":"2014-05-21T15:06:41Z","pushed_at":"2014-07-27T14:56:20Z","git_url":"git://github.com/grddev/jruby.git","ssh_url":"git@github.com:grddev/jruby.git","clone_url":"https://github.com/grddev/jruby.git","svn_url":"https://github.com/grddev/jruby","homepage":"http://www.jruby.org","size":120338,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jruby:jruby-1_7","ref":"jruby-1_7","sha":"c04c50f67ae8c80d52d86ee74100a063bb036c2b","user":{"login":"jruby","id":55687,"avatar_url":"https://avatars.githubusercontent.com/u/55687?v=2","gravatar_id":"1041835545ba2997fad5ca683a91d58d","url":"https://api.github.com/users/jruby","html_url":"https://github.com/jruby","followers_url":"https://api.github.com/users/jruby/followers","following_url":"https://api.github.com/users/jruby/following{/other_user}","gists_url":"https://api.github.com/users/jruby/gists{/gist_id}","starred_url":"https://api.github.com/users/jruby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jruby/subscriptions","organizations_url":"https://api.github.com/users/jruby/orgs","repos_url":"https://api.github.com/users/jruby/repos","events_url":"https://api.github.com/users/jruby/events{/privacy}","received_events_url":"https://api.github.com/users/jruby/received_events","type":"Organization","site_admin":false},"repo":{"id":168370,"name":"jruby","full_name":"jruby/jruby","owner":{"login":"jruby","id":55687,"avatar_url":"https://avatars.githubusercontent.com/u/55687?v=2","gravatar_id":"1041835545ba2997fad5ca683a91d58d","url":"https://api.github.com/users/jruby","html_url":"https://github.com/jruby","followers_url":"https://api.github.com/users/jruby/followers","following_url":"https://api.github.com/users/jruby/following{/other_user}","gists_url":"https://api.github.com/users/jruby/gists{/gist_id}","starred_url":"https://api.github.com/users/jruby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jruby/subscriptions","organizations_url":"https://api.github.com/users/jruby/orgs","repos_url":"https://api.github.com/users/jruby/repos","events_url":"https://api.github.com/users/jruby/events{/privacy}","received_events_url":"https://api.github.com/users/jruby/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jruby/jruby","description":"JRuby, an implementation of Ruby on the JVM","fork":false,"url":"https://api.github.com/repos/jruby/jruby","forks_url":"https://api.github.com/repos/jruby/jruby/forks","keys_url":"https://api.github.com/repos/jruby/jruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jruby/jruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jruby/jruby/teams","hooks_url":"https://api.github.com/repos/jruby/jruby/hooks","issue_events_url":"https://api.github.com/repos/jruby/jruby/issues/events{/number}","events_url":"https://api.github.com/repos/jruby/jruby/events","assignees_url":"https://api.github.com/repos/jruby/jruby/assignees{/user}","branches_url":"https://api.github.com/repos/jruby/jruby/branches{/branch}","tags_url":"https://api.github.com/repos/jruby/jruby/tags","blobs_url":"https://api.github.com/repos/jruby/jruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jruby/jruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jruby/jruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/jruby/jruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jruby/jruby/statuses/{sha}","languages_url":"https://api.github.com/repos/jruby/jruby/languages","stargazers_url":"https://api.github.com/repos/jruby/jruby/stargazers","contributors_url":"https://api.github.com/repos/jruby/jruby/contributors","subscribers_url":"https://api.github.com/repos/jruby/jruby/subscribers","subscription_url":"https://api.github.com/repos/jruby/jruby/subscription","commits_url":"https://api.github.com/repos/jruby/jruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/jruby/jruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/jruby/jruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/jruby/jruby/issues/comments/{number}","contents_url":"https://api.github.com/repos/jruby/jruby/contents/{+path}","compare_url":"https://api.github.com/repos/jruby/jruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jruby/jruby/merges","archive_url":"https://api.github.com/repos/jruby/jruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jruby/jruby/downloads","issues_url":"https://api.github.com/repos/jruby/jruby/issues{/number}","pulls_url":"https://api.github.com/repos/jruby/jruby/pulls{/number}","milestones_url":"https://api.github.com/repos/jruby/jruby/milestones{/number}","notifications_url":"https://api.github.com/repos/jruby/jruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jruby/jruby/labels{/name}","releases_url":"https://api.github.com/repos/jruby/jruby/releases{/id}","created_at":"2009-04-05T03:54:35Z","updated_at":"2014-08-20T19:51:31Z","pushed_at":"2014-08-20T20:38:12Z","git_url":"git://github.com/jruby/jruby.git","ssh_url":"git@github.com:jruby/jruby.git","clone_url":"https://github.com/jruby/jruby.git","svn_url":"https://github.com/jruby/jruby","homepage":"http://www.jruby.org","size":292813,"stargazers_count":1835,"watchers_count":1835,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":490,"mirror_url":null,"open_issues_count":511,"forks":490,"open_issues":511,"watchers":1835,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jruby/jruby/pulls/1864"},"html":{"href":"https://github.com/jruby/jruby/pull/1864"},"issue":{"href":"https://api.github.com/repos/jruby/jruby/issues/1864"},"comments":{"href":"https://api.github.com/repos/jruby/jruby/issues/1864/comments"},"review_comments":{"href":"https://api.github.com/repos/jruby/jruby/pulls/1864/comments"},"review_comment":{"href":"https://api.github.com/repos/jruby/jruby/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/jruby/jruby/pulls/1864/commits"},"statuses":{"href":"https://api.github.com/repos/jruby/jruby/statuses/134754851486f9305daba4184467b48a1e1185c0"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"headius","id":10135,"avatar_url":"https://avatars.githubusercontent.com/u/10135?v=2","gravatar_id":"f1d37642fdaa1662ff46e4c65731e9ab","url":"https://api.github.com/users/headius","html_url":"https://github.com/headius","followers_url":"https://api.github.com/users/headius/followers","following_url":"https://api.github.com/users/headius/following{/other_user}","gists_url":"https://api.github.com/users/headius/gists{/gist_id}","starred_url":"https://api.github.com/users/headius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/headius/subscriptions","organizations_url":"https://api.github.com/users/headius/orgs","repos_url":"https://api.github.com/users/headius/repos","events_url":"https://api.github.com/users/headius/events{/privacy}","received_events_url":"https://api.github.com/users/headius/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":7,"deletions":5,"changed_files":2}}