GitHub PullRequestReviewCommentEvent at 2014-04-04 08:59:24
Repository: hipache
Actor: dmp42
Payload: {"comment":{"url":"https://api.github.com/repos/dotcloud/hipache/pulls/comments/11287175","id":11287175,"diff_hunk":"@@ -48,8 +49,14 @@ MemoryMonitor.prototype.tick = function () {\n         return;\n     }\n     // Limit reached, starting the exit phase\n-    this.log('Memory limit exceeded (' + Math.round(currentMemory / (1024 * 1024)) + 'MB), exiting...');\n-    this.exit();\n+    var msg = 'Memory limit exceeded (' + Math.round(currentMemory / (1024 * 1024)) + 'MB), ';\n+    if (this._exited == false) {","path":"lib/memorymonitor.js","position":22,"original_position":22,"commit_id":"35f7e2830c72532313bfe593f16e29308890bd9c","original_commit_id":"35f7e2830c72532313bfe593f16e29308890bd9c","user":{"login":"dmp42","id":332946,"avatar_url":"https://avatars.githubusercontent.com/u/332946?","gravatar_id":"05e919c31cc2eee4c441e5db21be2df3","url":"https://api.github.com/users/dmp42","html_url":"https://github.com/dmp42","followers_url":"https://api.github.com/users/dmp42/followers","following_url":"https://api.github.com/users/dmp42/following{/other_user}","gists_url":"https://api.github.com/users/dmp42/gists{/gist_id}","starred_url":"https://api.github.com/users/dmp42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmp42/subscriptions","organizations_url":"https://api.github.com/users/dmp42/orgs","repos_url":"https://api.github.com/users/dmp42/repos","events_url":"https://api.github.com/users/dmp42/events{/privacy}","received_events_url":"https://api.github.com/users/dmp42/received_events","type":"User","site_admin":false},"body":"This will make jshint scream anyhow (our settings require strict comparison: ===).","created_at":"2014-04-04T08:59:24Z","updated_at":"2014-04-04T08:59:24Z","html_url":"https://github.com/dotcloud/hipache/pull/101#discussion_r11287175","pull_request_url":"https://api.github.com/repos/dotcloud/hipache/pulls/101","_links":{"self":{"href":"https://api.github.com/repos/dotcloud/hipache/pulls/comments/11287175"},"html":{"href":"https://github.com/dotcloud/hipache/pull/101#discussion_r11287175"},"pull_request":{"href":"https://api.github.com/repos/dotcloud/hipache/pulls/101"}}}}