GitHub PullRequestReviewCommentEvent at 2014-03-31 23:56:29
Repository: compute-appengine-demo-suite-python
Actor: briandorsey
Payload: {"comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/compute-appengine-demo-suite-python/pulls/comments/11142934","id":11142934,"diff_hunk":"@@ -412,24 +412,27 @@ def _get_instance_list(self, gce_project, num_instances, image, disks):\n       disk_mounts = []\n       image_project_id = None\n       image_name = None\n-      kernel = None\n       if disk:\n-        dm = gce.DiskMount(disk=disk, boot=True)\n-        kernel = gce_project.settings['compute']['kernel']\n+        dm = gce.DiskMount(disk=disk, boot=True, auto_delete=False)","path":"demo-suite/demos/fractal/main.py","position":8,"original_position":8,"commit_id":"280e05fb4fd387658c6f340436aa33919d78ce9f","original_commit_id":"b0af428224d9aec178bbe7c95edf67035923274d","user":{"login":"briandorsey","id":122043,"avatar_url":"https://avatars.githubusercontent.com/u/122043?","gravatar_id":"5fa6156d538b59b018b87d9008c61ce9","url":"https://api.github.com/users/briandorsey","html_url":"https://github.com/briandorsey","followers_url":"https://api.github.com/users/briandorsey/followers","following_url":"https://api.github.com/users/briandorsey/following{/other_user}","gists_url":"https://api.github.com/users/briandorsey/gists{/gist_id}","starred_url":"https://api.github.com/users/briandorsey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/briandorsey/subscriptions","organizations_url":"https://api.github.com/users/briandorsey/orgs","repos_url":"https://api.github.com/users/briandorsey/repos","events_url":"https://api.github.com/users/briandorsey/events{/privacy}","received_events_url":"https://api.github.com/users/briandorsey/received_events","type":"User","site_admin":false},"body":"I slightly prefer that it always creates and destroys PDs itself, mostly so that it always works the same way for everyone. PD creation is so fast, I don't think it hurts the demo to do it every time.  ","created_at":"2014-03-31T23:56:29Z","updated_at":"2014-03-31T23:56:29Z","html_url":"https://github.com/GoogleCloudPlatform/compute-appengine-demo-suite-python/pull/17#discussion_r11142934","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/compute-appengine-demo-suite-python/pulls/17","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/compute-appengine-demo-suite-python/pulls/comments/11142934"},"html":{"href":"https://github.com/GoogleCloudPlatform/compute-appengine-demo-suite-python/pull/17#discussion_r11142934"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/compute-appengine-demo-suite-python/pulls/17"}}}}