GitHub PullRequestReviewCommentEvent at 2014-04-11 14:13:54
Repository: edx-platform
Actor: olmar
Payload: {"comment":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/comments/11533641","id":11533641,"diff_hunk":"@@ -87,6 +88,18 @@ def test_handler_name(self):\n         self.assertIn('handler1', self._parsed_path('handler1'))\n         self.assertIn('handler_a', self._parsed_path('handler_a'))\n \n+    def test_thirdparty_fq(self):\n+        \"\"\"Testing the Fully-Qualified URL returned by thirdparty=true\"\"\"\n+        parsed_fq_url = urlparse(self.runtime.handler_url(self.block, 'handler', thirdparty=True))\n+        self.assertEqual(parsed_fq_url.scheme, 'https')\n+        self.assertEqual(parsed_fq_url.hostname, settings.SITE_NAME)\n+\n+    def test_not_thirdparty_rel(self):\n+        \"\"\"Testing the Fully-Qualified URL returned by thirdparty=true\"\"\"","path":"lms/lib/xblock/test/test_runtime.py","position":19,"original_position":19,"commit_id":"39557bc21e82bd5104da73fdbb5a9ad06162cda8","original_commit_id":"39557bc21e82bd5104da73fdbb5a9ad06162cda8","user":{"login":"olmar","id":3625483,"avatar_url":"https://avatars.githubusercontent.com/u/3625483?","gravatar_id":"543e5cc11f8b81fb803ccbfb7a5d39b4","url":"https://api.github.com/users/olmar","html_url":"https://github.com/olmar","followers_url":"https://api.github.com/users/olmar/followers","following_url":"https://api.github.com/users/olmar/following{/other_user}","gists_url":"https://api.github.com/users/olmar/gists{/gist_id}","starred_url":"https://api.github.com/users/olmar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olmar/subscriptions","organizations_url":"https://api.github.com/users/olmar/orgs","repos_url":"https://api.github.com/users/olmar/repos","events_url":"https://api.github.com/users/olmar/events{/privacy}","received_events_url":"https://api.github.com/users/olmar/received_events","type":"User","site_admin":false},"body":"Please update typo in docstring to  `thirdparty=false`","created_at":"2014-04-11T14:13:54Z","updated_at":"2014-04-11T14:13:54Z","html_url":"https://github.com/edx/edx-platform/pull/2685#discussion_r11533641","pull_request_url":"https://api.github.com/repos/edx/edx-platform/pulls/2685","_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments/11533641"},"html":{"href":"https://github.com/edx/edx-platform/pull/2685#discussion_r11533641"},"pull_request":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/2685"}}}}