GitHub PullRequestEvent at 2014-02-03 17:13:20
Repository: angular-file-upload
Actor: nervgh
Payload: {"action":"closed","number":55,"pull_request":{"url":"https://api.github.com/repos/nervgh/angular-file-upload/pulls/55","id":11839918,"html_url":"https://github.com/nervgh/angular-file-upload/pull/55","diff_url":"https://github.com/nervgh/angular-file-upload/pull/55.diff","patch_url":"https://github.com/nervgh/angular-file-upload/pull/55.patch","issue_url":"https://api.github.com/repos/nervgh/angular-file-upload/issues/55","number":55,"state":"closed","title":"Fixes an issue with forEach when using formData.","user":{"login":"brandonaaskov","id":445778,"avatar_url":"https://gravatar.com/avatar/43c12eee99ef76faffe45d87e5118f62?d=https%3A%2F%2Fidenticons.github.com%2Fab70d5e0a1f18b4ba6357e12ebedc10e.png&r=x","gravatar_id":"43c12eee99ef76faffe45d87e5118f62","url":"https://api.github.com/users/brandonaaskov","html_url":"https://github.com/brandonaaskov","followers_url":"https://api.github.com/users/brandonaaskov/followers","following_url":"https://api.github.com/users/brandonaaskov/following{/other_user}","gists_url":"https://api.github.com/users/brandonaaskov/gists{/gist_id}","starred_url":"https://api.github.com/users/brandonaaskov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brandonaaskov/subscriptions","organizations_url":"https://api.github.com/users/brandonaaskov/orgs","repos_url":"https://api.github.com/users/brandonaaskov/repos","events_url":"https://api.github.com/users/brandonaaskov/events{/privacy}","received_events_url":"https://api.github.com/users/brandonaaskov/received_events","type":"User","site_admin":false},"body":"The `forEach` fix is below, but I honestly don't know why the params object is changed. I certainly didn't change that locally, but I'm also in sync with master so I'm not sure what that's all about. ","created_at":"2014-01-24T10:52:31Z","updated_at":"2014-02-03T17:13:20Z","closed_at":"2014-02-03T17:13:20Z","merged_at":null,"merge_commit_sha":"13bdda2652ee7dd2ceb975ad58f8a90690c61e46","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nervgh/angular-file-upload/pulls/55/commits","review_comments_url":"https://api.github.com/repos/nervgh/angular-file-upload/pulls/55/comments","review_comment_url":"https://api.github.com/repos/nervgh/angular-file-upload/pulls/comments/{number}","comments_url":"https://api.github.com/repos/nervgh/angular-file-upload/issues/55/comments","statuses_url":"https://api.github.com/repos/nervgh/angular-file-upload/statuses/2b12f17d11ccf7d22efbf3e5251e6c0c32e8c64e","head":{"label":"brandonaaskov:master","ref":"master","sha":"2b12f17d11ccf7d22efbf3e5251e6c0c32e8c64e","user":{"login":"brandonaaskov","id":445778,"avatar_url":"https://gravatar.com/avatar/43c12eee99ef76faffe45d87e5118f62?d=https%3A%2F%2Fidenticons.github.com%2Fab70d5e0a1f18b4ba6357e12ebedc10e.png&r=x","gravatar_id":"43c12eee99ef76faffe45d87e5118f62","url":"https://api.github.com/users/brandonaaskov","html_url":"https://github.com/brandonaaskov","followers_url":"https://api.github.com/users/brandonaaskov/followers","following_url":"https://api.github.com/users/brandonaaskov/following{/other_user}","gists_url":"https://api.github.com/users/brandonaaskov/gists{/gist_id}","starred_url":"https://api.github.com/users/brandonaaskov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brandonaaskov/subscriptions","organizations_url":"https://api.github.com/users/brandonaaskov/orgs","repos_url":"https://api.github.com/users/brandonaaskov/repos","events_url":"https://api.github.com/users/brandonaaskov/events{/privacy}","received_events_url":"https://api.github.com/users/brandonaaskov/received_events","type":"User","site_admin":false},"repo":{"id":16201493,"name":"angular-file-upload","full_name":"brandonaaskov/angular-file-upload","owner":{"login":"brandonaaskov","id":445778,"avatar_url":"https://gravatar.com/avatar/43c12eee99ef76faffe45d87e5118f62?d=https%3A%2F%2Fidenticons.github.com%2Fab70d5e0a1f18b4ba6357e12ebedc10e.png&r=x","gravatar_id":"43c12eee99ef76faffe45d87e5118f62","url":"https://api.github.com/users/brandonaaskov","html_url":"https://github.com/brandonaaskov","followers_url":"https://api.github.com/users/brandonaaskov/followers","following_url":"https://api.github.com/users/brandonaaskov/following{/other_user}","gists_url":"https://api.github.com/users/brandonaaskov/gists{/gist_id}","starred_url":"https://api.github.com/users/brandonaaskov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brandonaaskov/subscriptions","organizations_url":"https://api.github.com/users/brandonaaskov/orgs","repos_url":"https://api.github.com/users/brandonaaskov/repos","events_url":"https://api.github.com/users/brandonaaskov/events{/privacy}","received_events_url":"https://api.github.com/users/brandonaaskov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brandonaaskov/angular-file-upload","description":"Angular File Upload is a module for the AngularJS framework","fork":true,"url":"https://api.github.com/repos/brandonaaskov/angular-file-upload","forks_url":"https://api.github.com/repos/brandonaaskov/angular-file-upload/forks","keys_url":"https://api.github.com/repos/brandonaaskov/angular-file-upload/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brandonaaskov/angular-file-upload/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brandonaaskov/angular-file-upload/teams","hooks_url":"https://api.github.com/repos/brandonaaskov/angular-file-upload/hooks","issue_events_url":"https://api.github.com/repos/brandonaaskov/angular-file-upload/issues/events{/number}","events_url":"https://api.github.com/repos/brandonaaskov/angular-file-upload/events","assignees_url":"https://api.github.com/repos/brandonaaskov/angular-file-upload/assignees{/user}","branches_url":"https://api.github.com/repos/brandonaaskov/angular-file-upload/branches{/branch}","tags_url":"https://api.github.com/repos/brandonaaskov/angular-file-upload/tags","blobs_url":"https://api.github.com/repos/brandonaaskov/angular-file-upload/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brandonaaskov/angular-file-upload/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brandonaaskov/angular-file-upload/git/refs{/sha}","trees_url":"https://api.github.com/repos/brandonaaskov/angular-file-upload/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brandonaaskov/angular-file-upload/statuses/{sha}","languages_url":"https://api.github.com/repos/brandonaaskov/angular-file-upload/languages","stargazers_url":"https://api.github.com/repos/brandonaaskov/angular-file-upload/stargazers","contributors_url":"https://api.github.com/repos/brandonaaskov/angular-file-upload/contributors","subscribers_url":"https://api.github.com/repos/brandonaaskov/angular-file-upload/subscribers","subscription_url":"https://api.github.com/repos/brandonaaskov/angular-file-upload/subscription","commits_url":"https://api.github.com/repos/brandonaaskov/angular-file-upload/commits{/sha}","git_commits_url":"https://api.github.com/repos/brandonaaskov/angular-file-upload/git/commits{/sha}","comments_url":"https://api.github.com/repos/brandonaaskov/angular-file-upload/comments{/number}","issue_comment_url":"https://api.github.com/repos/brandonaaskov/angular-file-upload/issues/comments/{number}","contents_url":"https://api.github.com/repos/brandonaaskov/angular-file-upload/contents/{+path}","compare_url":"https://api.github.com/repos/brandonaaskov/angular-file-upload/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brandonaaskov/angular-file-upload/merges","archive_url":"https://api.github.com/repos/brandonaaskov/angular-file-upload/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brandonaaskov/angular-file-upload/downloads","issues_url":"https://api.github.com/repos/brandonaaskov/angular-file-upload/issues{/number}","pulls_url":"https://api.github.com/repos/brandonaaskov/angular-file-upload/pulls{/number}","milestones_url":"https://api.github.com/repos/brandonaaskov/angular-file-upload/milestones{/number}","notifications_url":"https://api.github.com/repos/brandonaaskov/angular-file-upload/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brandonaaskov/angular-file-upload/labels{/name}","releases_url":"https://api.github.com/repos/brandonaaskov/angular-file-upload/releases{/id}","created_at":"2014-01-24T10:25:30Z","updated_at":"2014-02-03T17:13:20Z","pushed_at":"2014-01-24T10:49:06Z","git_url":"git://github.com/brandonaaskov/angular-file-upload.git","ssh_url":"git@github.com:brandonaaskov/angular-file-upload.git","clone_url":"https://github.com/brandonaaskov/angular-file-upload.git","svn_url":"https://github.com/brandonaaskov/angular-file-upload","homepage":"","size":405,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master","master_branch":"master"}},"base":{"label":"nervgh:master","ref":"master","sha":"a5118cbcda783ce0a287aea6e29e4f858c81c529","user":{"login":"nervgh","id":2478262,"avatar_url":"https://gravatar.com/avatar/b3ec2ffbaf26c9451fad06ce50b6b30e?d=https%3A%2F%2Fidenticons.github.com%2Fb6bd6366943f8b6a5d2dd3ce201a9ac6.png&r=x","gravatar_id":"b3ec2ffbaf26c9451fad06ce50b6b30e","url":"https://api.github.com/users/nervgh","html_url":"https://github.com/nervgh","followers_url":"https://api.github.com/users/nervgh/followers","following_url":"https://api.github.com/users/nervgh/following{/other_user}","gists_url":"https://api.github.com/users/nervgh/gists{/gist_id}","starred_url":"https://api.github.com/users/nervgh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nervgh/subscriptions","organizations_url":"https://api.github.com/users/nervgh/orgs","repos_url":"https://api.github.com/users/nervgh/repos","events_url":"https://api.github.com/users/nervgh/events{/privacy}","received_events_url":"https://api.github.com/users/nervgh/received_events","type":"User","site_admin":false},"repo":{"id":12043484,"name":"angular-file-upload","full_name":"nervgh/angular-file-upload","owner":{"login":"nervgh","id":2478262,"avatar_url":"https://gravatar.com/avatar/b3ec2ffbaf26c9451fad06ce50b6b30e?d=https%3A%2F%2Fidenticons.github.com%2Fb6bd6366943f8b6a5d2dd3ce201a9ac6.png&r=x","gravatar_id":"b3ec2ffbaf26c9451fad06ce50b6b30e","url":"https://api.github.com/users/nervgh","html_url":"https://github.com/nervgh","followers_url":"https://api.github.com/users/nervgh/followers","following_url":"https://api.github.com/users/nervgh/following{/other_user}","gists_url":"https://api.github.com/users/nervgh/gists{/gist_id}","starred_url":"https://api.github.com/users/nervgh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nervgh/subscriptions","organizations_url":"https://api.github.com/users/nervgh/orgs","repos_url":"https://api.github.com/users/nervgh/repos","events_url":"https://api.github.com/users/nervgh/events{/privacy}","received_events_url":"https://api.github.com/users/nervgh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nervgh/angular-file-upload","description":"Angular File Upload is a module for the AngularJS framework","fork":false,"url":"https://api.github.com/repos/nervgh/angular-file-upload","forks_url":"https://api.github.com/repos/nervgh/angular-file-upload/forks","keys_url":"https://api.github.com/repos/nervgh/angular-file-upload/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nervgh/angular-file-upload/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nervgh/angular-file-upload/teams","hooks_url":"https://api.github.com/repos/nervgh/angular-file-upload/hooks","issue_events_url":"https://api.github.com/repos/nervgh/angular-file-upload/issues/events{/number}","events_url":"https://api.github.com/repos/nervgh/angular-file-upload/events","assignees_url":"https://api.github.com/repos/nervgh/angular-file-upload/assignees{/user}","branches_url":"https://api.github.com/repos/nervgh/angular-file-upload/branches{/branch}","tags_url":"https://api.github.com/repos/nervgh/angular-file-upload/tags","blobs_url":"https://api.github.com/repos/nervgh/angular-file-upload/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nervgh/angular-file-upload/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nervgh/angular-file-upload/git/refs{/sha}","trees_url":"https://api.github.com/repos/nervgh/angular-file-upload/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nervgh/angular-file-upload/statuses/{sha}","languages_url":"https://api.github.com/repos/nervgh/angular-file-upload/languages","stargazers_url":"https://api.github.com/repos/nervgh/angular-file-upload/stargazers","contributors_url":"https://api.github.com/repos/nervgh/angular-file-upload/contributors","subscribers_url":"https://api.github.com/repos/nervgh/angular-file-upload/subscribers","subscription_url":"https://api.github.com/repos/nervgh/angular-file-upload/subscription","commits_url":"https://api.github.com/repos/nervgh/angular-file-upload/commits{/sha}","git_commits_url":"https://api.github.com/repos/nervgh/angular-file-upload/git/commits{/sha}","comments_url":"https://api.github.com/repos/nervgh/angular-file-upload/comments{/number}","issue_comment_url":"https://api.github.com/repos/nervgh/angular-file-upload/issues/comments/{number}","contents_url":"https://api.github.com/repos/nervgh/angular-file-upload/contents/{+path}","compare_url":"https://api.github.com/repos/nervgh/angular-file-upload/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nervgh/angular-file-upload/merges","archive_url":"https://api.github.com/repos/nervgh/angular-file-upload/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nervgh/angular-file-upload/downloads","issues_url":"https://api.github.com/repos/nervgh/angular-file-upload/issues{/number}","pulls_url":"https://api.github.com/repos/nervgh/angular-file-upload/pulls{/number}","milestones_url":"https://api.github.com/repos/nervgh/angular-file-upload/milestones{/number}","notifications_url":"https://api.github.com/repos/nervgh/angular-file-upload/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nervgh/angular-file-upload/labels{/name}","releases_url":"https://api.github.com/repos/nervgh/angular-file-upload/releases{/id}","created_at":"2013-08-11T22:16:39Z","updated_at":"2014-01-27T20:30:19Z","pushed_at":"2014-01-27T20:30:18Z","git_url":"git://github.com/nervgh/angular-file-upload.git","ssh_url":"git@github.com:nervgh/angular-file-upload.git","clone_url":"https://github.com/nervgh/angular-file-upload.git","svn_url":"https://github.com/nervgh/angular-file-upload","homepage":"","size":876,"stargazers_count":195,"watchers_count":195,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":52,"mirror_url":null,"open_issues_count":8,"forks":52,"open_issues":8,"watchers":195,"default_branch":"master","master_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nervgh/angular-file-upload/pulls/55"},"html":{"href":"https://github.com/nervgh/angular-file-upload/pull/55"},"issue":{"href":"https://api.github.com/repos/nervgh/angular-file-upload/issues/55"},"comments":{"href":"https://api.github.com/repos/nervgh/angular-file-upload/issues/55/comments"},"review_comments":{"href":"https://api.github.com/repos/nervgh/angular-file-upload/pulls/55/comments"},"review_comment":{"href":"https://api.github.com/repos/nervgh/angular-file-upload/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/nervgh/angular-file-upload/pulls/55/commits"},"statuses":{"href":"https://api.github.com/repos/nervgh/angular-file-upload/statuses/2b12f17d11ccf7d22efbf3e5251e6c0c32e8c64e"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"commits":1,"additions":11,"deletions":11,"changed_files":4}}