GitHub PullRequestReviewCommentEvent at 2014-09-05 08:25:46
Repository: emscripten
Actor: juj
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/kripken/emscripten/pulls/comments/17161454","id":17161454,"diff_hunk":"@@ -8494,6 +8502,13 @@ LibraryManager.library = {\n     }\n   },\n \n+  emscripten_get_now_monotonic__deps: ['emscripten_get_now'],\n+  emscripten_get_now_monotonic: function() {\n+    // return whether emscripten_get_now is guaranteed monotonic; the Date.now\n+    // implementation is not :(","path":"src/library.js","position":53,"original_position":53,"commit_id":"c8bf0da52aef85442e67a568cd178af0e43d467e","original_commit_id":"c8bf0da52aef85442e67a568cd178af0e43d467e","user":{"login":"juj","id":225351,"avatar_url":"https://avatars.githubusercontent.com/u/225351?v=2","gravatar_id":"6e5c7ba24b50106c443ffdc1886d3641","url":"https://api.github.com/users/juj","html_url":"https://github.com/juj","followers_url":"https://api.github.com/users/juj/followers","following_url":"https://api.github.com/users/juj/following{/other_user}","gists_url":"https://api.github.com/users/juj/gists{/gist_id}","starred_url":"https://api.github.com/users/juj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juj/subscriptions","organizations_url":"https://api.github.com/users/juj/orgs","repos_url":"https://api.github.com/users/juj/repos","events_url":"https://api.github.com/users/juj/events{/privacy}","received_events_url":"https://api.github.com/users/juj/received_events","type":"User","site_admin":false},"body":"Where does it say that Date.now is not monotonic? I searched here and it does not specify such information: http://www.ecma-international.org/ecma-262/5.1/#sec-15.9.4.4 . Is `emscripten_get_now_monotonic` really needed?","created_at":"2014-09-05T08:25:46Z","updated_at":"2014-09-05T08:25:46Z","html_url":"https://github.com/kripken/emscripten/pull/2761#discussion_r17161454","pull_request_url":"https://api.github.com/repos/kripken/emscripten/pulls/2761","_links":{"self":{"href":"https://api.github.com/repos/kripken/emscripten/pulls/comments/17161454"},"html":{"href":"https://github.com/kripken/emscripten/pull/2761#discussion_r17161454"},"pull_request":{"href":"https://api.github.com/repos/kripken/emscripten/pulls/2761"}}},"pull_request":{"url":"https://api.github.com/repos/kripken/emscripten/pulls/2761","id":20756834,"html_url":"https://github.com/kripken/emscripten/pull/2761","diff_url":"https://github.com/kripken/emscripten/pull/2761.diff","patch_url":"https://github.com/kripken/emscripten/pull/2761.patch","issue_url":"https://api.github.com/repos/kripken/emscripten/issues/2761","number":2761,"state":"open","locked":false,"title":"Implement clock_gettime(CLOCK_MONOTONIC) properly","user":{"login":"NWilson","id":363415,"avatar_url":"https://avatars.githubusercontent.com/u/363415?v=2","gravatar_id":"b0322a3a2a6536f4bc123eefb2a099a3","url":"https://api.github.com/users/NWilson","html_url":"https://github.com/NWilson","followers_url":"https://api.github.com/users/NWilson/followers","following_url":"https://api.github.com/users/NWilson/following{/other_user}","gists_url":"https://api.github.com/users/NWilson/gists{/gist_id}","starred_url":"https://api.github.com/users/NWilson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NWilson/subscriptions","organizations_url":"https://api.github.com/users/NWilson/orgs","repos_url":"https://api.github.com/users/NWilson/repos","events_url":"https://api.github.com/users/NWilson/events{/privacy}","received_events_url":"https://api.github.com/users/NWilson/received_events","type":"User","site_admin":false},"body":"It's bad to pretend to support every clock - we should correctly return -1 with EINVAL for the clocks we don't implement. It's also nice to give implementations a way to detect if they have access to a monotonic clock. For comparison, old Linux machines (RHEL 3 for example) don't have CLOCK_MONOTONIC, new ones do.","created_at":"2014-09-04T16:46:53Z","updated_at":"2014-09-05T08:25:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bb5ec7d6296c863a7abb3ac198a03d34021dbca2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/kripken/emscripten/pulls/2761/commits","review_comments_url":"https://api.github.com/repos/kripken/emscripten/pulls/2761/comments","review_comment_url":"https://api.github.com/repos/kripken/emscripten/pulls/comments/{number}","comments_url":"https://api.github.com/repos/kripken/emscripten/issues/2761/comments","statuses_url":"https://api.github.com/repos/kripken/emscripten/statuses/c8bf0da52aef85442e67a568cd178af0e43d467e","head":{"label":"NWilson:monotonicclock","ref":"monotonicclock","sha":"c8bf0da52aef85442e67a568cd178af0e43d467e","user":{"login":"NWilson","id":363415,"avatar_url":"https://avatars.githubusercontent.com/u/363415?v=2","gravatar_id":"b0322a3a2a6536f4bc123eefb2a099a3","url":"https://api.github.com/users/NWilson","html_url":"https://github.com/NWilson","followers_url":"https://api.github.com/users/NWilson/followers","following_url":"https://api.github.com/users/NWilson/following{/other_user}","gists_url":"https://api.github.com/users/NWilson/gists{/gist_id}","starred_url":"https://api.github.com/users/NWilson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NWilson/subscriptions","organizations_url":"https://api.github.com/users/NWilson/orgs","repos_url":"https://api.github.com/users/NWilson/repos","events_url":"https://api.github.com/users/NWilson/events{/privacy}","received_events_url":"https://api.github.com/users/NWilson/received_events","type":"User","site_admin":false},"repo":{"id":23655624,"name":"emscripten","full_name":"NWilson/emscripten","owner":{"login":"NWilson","id":363415,"avatar_url":"https://avatars.githubusercontent.com/u/363415?v=2","gravatar_id":"b0322a3a2a6536f4bc123eefb2a099a3","url":"https://api.github.com/users/NWilson","html_url":"https://github.com/NWilson","followers_url":"https://api.github.com/users/NWilson/followers","following_url":"https://api.github.com/users/NWilson/following{/other_user}","gists_url":"https://api.github.com/users/NWilson/gists{/gist_id}","starred_url":"https://api.github.com/users/NWilson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NWilson/subscriptions","organizations_url":"https://api.github.com/users/NWilson/orgs","repos_url":"https://api.github.com/users/NWilson/repos","events_url":"https://api.github.com/users/NWilson/events{/privacy}","received_events_url":"https://api.github.com/users/NWilson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/NWilson/emscripten","description":"Emscripten: An LLVM-to-JavaScript Compiler","fork":true,"url":"https://api.github.com/repos/NWilson/emscripten","forks_url":"https://api.github.com/repos/NWilson/emscripten/forks","keys_url":"https://api.github.com/repos/NWilson/emscripten/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NWilson/emscripten/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NWilson/emscripten/teams","hooks_url":"https://api.github.com/repos/NWilson/emscripten/hooks","issue_events_url":"https://api.github.com/repos/NWilson/emscripten/issues/events{/number}","events_url":"https://api.github.com/repos/NWilson/emscripten/events","assignees_url":"https://api.github.com/repos/NWilson/emscripten/assignees{/user}","branches_url":"https://api.github.com/repos/NWilson/emscripten/branches{/branch}","tags_url":"https://api.github.com/repos/NWilson/emscripten/tags","blobs_url":"https://api.github.com/repos/NWilson/emscripten/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NWilson/emscripten/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NWilson/emscripten/git/refs{/sha}","trees_url":"https://api.github.com/repos/NWilson/emscripten/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NWilson/emscripten/statuses/{sha}","languages_url":"https://api.github.com/repos/NWilson/emscripten/languages","stargazers_url":"https://api.github.com/repos/NWilson/emscripten/stargazers","contributors_url":"https://api.github.com/repos/NWilson/emscripten/contributors","subscribers_url":"https://api.github.com/repos/NWilson/emscripten/subscribers","subscription_url":"https://api.github.com/repos/NWilson/emscripten/subscription","commits_url":"https://api.github.com/repos/NWilson/emscripten/commits{/sha}","git_commits_url":"https://api.github.com/repos/NWilson/emscripten/git/commits{/sha}","comments_url":"https://api.github.com/repos/NWilson/emscripten/comments{/number}","issue_comment_url":"https://api.github.com/repos/NWilson/emscripten/issues/comments/{number}","contents_url":"https://api.github.com/repos/NWilson/emscripten/contents/{+path}","compare_url":"https://api.github.com/repos/NWilson/emscripten/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NWilson/emscripten/merges","archive_url":"https://api.github.com/repos/NWilson/emscripten/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NWilson/emscripten/downloads","issues_url":"https://api.github.com/repos/NWilson/emscripten/issues{/number}","pulls_url":"https://api.github.com/repos/NWilson/emscripten/pulls{/number}","milestones_url":"https://api.github.com/repos/NWilson/emscripten/milestones{/number}","notifications_url":"https://api.github.com/repos/NWilson/emscripten/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NWilson/emscripten/labels{/name}","releases_url":"https://api.github.com/repos/NWilson/emscripten/releases{/id}","created_at":"2014-09-04T09:04:19Z","updated_at":"2014-09-04T06:53:20Z","pushed_at":"2014-09-04T16:45:27Z","git_url":"git://github.com/NWilson/emscripten.git","ssh_url":"git@github.com:NWilson/emscripten.git","clone_url":"https://github.com/NWilson/emscripten.git","svn_url":"https://github.com/NWilson/emscripten","homepage":"","size":103168,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kripken:incoming","ref":"incoming","sha":"bfd61a02deabfbeb21fb119cef804b6c54b00596","user":{"login":"kripken","id":173661,"avatar_url":"https://avatars.githubusercontent.com/u/173661?v=2","gravatar_id":"cb9f8cd8da97fa3a92e46ebe576e8050","url":"https://api.github.com/users/kripken","html_url":"https://github.com/kripken","followers_url":"https://api.github.com/users/kripken/followers","following_url":"https://api.github.com/users/kripken/following{/other_user}","gists_url":"https://api.github.com/users/kripken/gists{/gist_id}","starred_url":"https://api.github.com/users/kripken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kripken/subscriptions","organizations_url":"https://api.github.com/users/kripken/orgs","repos_url":"https://api.github.com/users/kripken/repos","events_url":"https://api.github.com/users/kripken/events{/privacy}","received_events_url":"https://api.github.com/users/kripken/received_events","type":"User","site_admin":false},"repo":{"id":1357796,"name":"emscripten","full_name":"kripken/emscripten","owner":{"login":"kripken","id":173661,"avatar_url":"https://avatars.githubusercontent.com/u/173661?v=2","gravatar_id":"cb9f8cd8da97fa3a92e46ebe576e8050","url":"https://api.github.com/users/kripken","html_url":"https://github.com/kripken","followers_url":"https://api.github.com/users/kripken/followers","following_url":"https://api.github.com/users/kripken/following{/other_user}","gists_url":"https://api.github.com/users/kripken/gists{/gist_id}","starred_url":"https://api.github.com/users/kripken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kripken/subscriptions","organizations_url":"https://api.github.com/users/kripken/orgs","repos_url":"https://api.github.com/users/kripken/repos","events_url":"https://api.github.com/users/kripken/events{/privacy}","received_events_url":"https://api.github.com/users/kripken/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kripken/emscripten","description":"Emscripten: An LLVM-to-JavaScript Compiler","fork":false,"url":"https://api.github.com/repos/kripken/emscripten","forks_url":"https://api.github.com/repos/kripken/emscripten/forks","keys_url":"https://api.github.com/repos/kripken/emscripten/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kripken/emscripten/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kripken/emscripten/teams","hooks_url":"https://api.github.com/repos/kripken/emscripten/hooks","issue_events_url":"https://api.github.com/repos/kripken/emscripten/issues/events{/number}","events_url":"https://api.github.com/repos/kripken/emscripten/events","assignees_url":"https://api.github.com/repos/kripken/emscripten/assignees{/user}","branches_url":"https://api.github.com/repos/kripken/emscripten/branches{/branch}","tags_url":"https://api.github.com/repos/kripken/emscripten/tags","blobs_url":"https://api.github.com/repos/kripken/emscripten/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kripken/emscripten/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kripken/emscripten/git/refs{/sha}","trees_url":"https://api.github.com/repos/kripken/emscripten/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kripken/emscripten/statuses/{sha}","languages_url":"https://api.github.com/repos/kripken/emscripten/languages","stargazers_url":"https://api.github.com/repos/kripken/emscripten/stargazers","contributors_url":"https://api.github.com/repos/kripken/emscripten/contributors","subscribers_url":"https://api.github.com/repos/kripken/emscripten/subscribers","subscription_url":"https://api.github.com/repos/kripken/emscripten/subscription","commits_url":"https://api.github.com/repos/kripken/emscripten/commits{/sha}","git_commits_url":"https://api.github.com/repos/kripken/emscripten/git/commits{/sha}","comments_url":"https://api.github.com/repos/kripken/emscripten/comments{/number}","issue_comment_url":"https://api.github.com/repos/kripken/emscripten/issues/comments/{number}","contents_url":"https://api.github.com/repos/kripken/emscripten/contents/{+path}","compare_url":"https://api.github.com/repos/kripken/emscripten/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kripken/emscripten/merges","archive_url":"https://api.github.com/repos/kripken/emscripten/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kripken/emscripten/downloads","issues_url":"https://api.github.com/repos/kripken/emscripten/issues{/number}","pulls_url":"https://api.github.com/repos/kripken/emscripten/pulls{/number}","milestones_url":"https://api.github.com/repos/kripken/emscripten/milestones{/number}","notifications_url":"https://api.github.com/repos/kripken/emscripten/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kripken/emscripten/labels{/name}","releases_url":"https://api.github.com/repos/kripken/emscripten/releases{/id}","created_at":"2011-02-12T05:23:30Z","updated_at":"2014-09-05T05:03:09Z","pushed_at":"2014-09-05T00:14:26Z","git_url":"git://github.com/kripken/emscripten.git","ssh_url":"git@github.com:kripken/emscripten.git","clone_url":"https://github.com/kripken/emscripten.git","svn_url":"https://github.com/kripken/emscripten","homepage":"","size":207290,"stargazers_count":7042,"watchers_count":7042,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":777,"mirror_url":null,"open_issues_count":432,"forks":777,"open_issues":432,"watchers":7042,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kripken/emscripten/pulls/2761"},"html":{"href":"https://github.com/kripken/emscripten/pull/2761"},"issue":{"href":"https://api.github.com/repos/kripken/emscripten/issues/2761"},"comments":{"href":"https://api.github.com/repos/kripken/emscripten/issues/2761/comments"},"review_comments":{"href":"https://api.github.com/repos/kripken/emscripten/pulls/2761/comments"},"review_comment":{"href":"https://api.github.com/repos/kripken/emscripten/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/kripken/emscripten/pulls/2761/commits"},"statuses":{"href":"https://api.github.com/repos/kripken/emscripten/statuses/c8bf0da52aef85442e67a568cd178af0e43d467e"}}}}