GitHub PullRequestReviewCommentEvent at 2014-07-21 20:58:05
Repository: repose
Actor: dkowis
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/rackerlabs/repose/pulls/comments/15195881","id":15195881,"diff_hunk":"@@ -72,21 +73,45 @@ public void setServletContext(ServletContext servletContext) {\n \n     @PostConstruct\n     public void afterPropertiesSet() {\n+        //Doing the monitoring for config should always happen\n+        URL xsdURL = getClass().getResource(\"/META-INF/schema/system-model/system-model.xsd\");\n+        configurationManager.subscribeTo(\"system-model.cfg.xml\", xsdURL, systemModelUpdateListener, SystemModel.class);\n+        URL dXsdURL = getClass().getResource(\"/META-INF/schema/config/dist-datastore-configuration.xsd\");\n+        configurationManager.subscribeTo(DEFAULT_CONFIG, dXsdURL, distributedDatastoreConfigurationListener, DistributedDatastoreConfiguration.class);\n+\n+    }\n+\n+    @PreDestroy\n+    public void destroy() {\n+        healthCheckServiceProxy.deregister();","path":"repose-aggregator/core/core-lib/src/main/java/com/rackspace/papi/service/datastore/distributed/impl/distributed/cluster/DistributedDatastoreServiceClusterViewServiceImpl.java","position":38,"original_position":38,"commit_id":"6c992717cf8aee9ca4a3810840674da9c29ca513","original_commit_id":"7f7b6393b28abf9280cbc27601edf5b7abd4e60f","user":{"login":"dkowis","id":28048,"avatar_url":"https://avatars.githubusercontent.com/u/28048?","gravatar_id":"179854cc61f340da20102635928d6079","url":"https://api.github.com/users/dkowis","html_url":"https://github.com/dkowis","followers_url":"https://api.github.com/users/dkowis/followers","following_url":"https://api.github.com/users/dkowis/following{/other_user}","gists_url":"https://api.github.com/users/dkowis/gists{/gist_id}","starred_url":"https://api.github.com/users/dkowis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkowis/subscriptions","organizations_url":"https://api.github.com/users/dkowis/orgs","repos_url":"https://api.github.com/users/dkowis/repos","events_url":"https://api.github.com/users/dkowis/events{/privacy}","received_events_url":"https://api.github.com/users/dkowis/received_events","type":"User","site_admin":false},"body":"Uh, wat?","created_at":"2014-07-21T20:58:05Z","updated_at":"2014-07-21T20:58:05Z","html_url":"https://github.com/rackerlabs/repose/pull/1040#discussion_r15195881","pull_request_url":"https://api.github.com/repos/rackerlabs/repose/pulls/1040","_links":{"self":{"href":"https://api.github.com/repos/rackerlabs/repose/pulls/comments/15195881"},"html":{"href":"https://github.com/rackerlabs/repose/pull/1040#discussion_r15195881"},"pull_request":{"href":"https://api.github.com/repos/rackerlabs/repose/pulls/1040"}}},"pull_request":{"url":"https://api.github.com/repos/rackerlabs/repose/pulls/1040","id":18677399,"html_url":"https://github.com/rackerlabs/repose/pull/1040","diff_url":"https://github.com/rackerlabs/repose/pull/1040.diff","patch_url":"https://github.com/rackerlabs/repose/pull/1040.patch","issue_url":"https://api.github.com/repos/rackerlabs/repose/issues/1040","number":1040,"state":"open","title":"Dist datastore refactor","user":{"login":"dkowis","id":28048,"avatar_url":"https://avatars.githubusercontent.com/u/28048?","gravatar_id":"179854cc61f340da20102635928d6079","url":"https://api.github.com/users/dkowis","html_url":"https://github.com/dkowis","followers_url":"https://api.github.com/users/dkowis/followers","following_url":"https://api.github.com/users/dkowis/following{/other_user}","gists_url":"https://api.github.com/users/dkowis/gists{/gist_id}","starred_url":"https://api.github.com/users/dkowis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkowis/subscriptions","organizations_url":"https://api.github.com/users/dkowis/orgs","repos_url":"https://api.github.com/users/dkowis/repos","events_url":"https://api.github.com/users/dkowis/events{/privacy}","received_events_url":"https://api.github.com/users/dkowis/received_events","type":"User","site_admin":false},"body":"Some changes to the dist-datstore and @Ignoring some tests to get past failures that aren't related, yet.","created_at":"2014-07-21T20:23:15Z","updated_at":"2014-07-21T20:58:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ad4e0dce8878dac2640ba78502c0f851bef153fe","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rackerlabs/repose/pulls/1040/commits","review_comments_url":"https://api.github.com/repos/rackerlabs/repose/pulls/1040/comments","review_comment_url":"https://api.github.com/repos/rackerlabs/repose/pulls/comments/{number}","comments_url":"https://api.github.com/repos/rackerlabs/repose/issues/1040/comments","statuses_url":"https://api.github.com/repos/rackerlabs/repose/statuses/6c992717cf8aee9ca4a3810840674da9c29ca513","head":{"label":"rackerlabs:dist-datastore-refactor","ref":"dist-datastore-refactor","sha":"6c992717cf8aee9ca4a3810840674da9c29ca513","user":{"login":"rackerlabs","id":84293,"avatar_url":"https://avatars.githubusercontent.com/u/84293?","gravatar_id":"cc2ad66c312c32facaf25a69bc6779cb","url":"https://api.github.com/users/rackerlabs","html_url":"https://github.com/rackerlabs","followers_url":"https://api.github.com/users/rackerlabs/followers","following_url":"https://api.github.com/users/rackerlabs/following{/other_user}","gists_url":"https://api.github.com/users/rackerlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/rackerlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rackerlabs/subscriptions","organizations_url":"https://api.github.com/users/rackerlabs/orgs","repos_url":"https://api.github.com/users/rackerlabs/repos","events_url":"https://api.github.com/users/rackerlabs/events{/privacy}","received_events_url":"https://api.github.com/users/rackerlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":1981821,"name":"repose","full_name":"rackerlabs/repose","owner":{"login":"rackerlabs","id":84293,"avatar_url":"https://avatars.githubusercontent.com/u/84293?","gravatar_id":"cc2ad66c312c32facaf25a69bc6779cb","url":"https://api.github.com/users/rackerlabs","html_url":"https://github.com/rackerlabs","followers_url":"https://api.github.com/users/rackerlabs/followers","following_url":"https://api.github.com/users/rackerlabs/following{/other_user}","gists_url":"https://api.github.com/users/rackerlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/rackerlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rackerlabs/subscriptions","organizations_url":"https://api.github.com/users/rackerlabs/orgs","repos_url":"https://api.github.com/users/rackerlabs/repos","events_url":"https://api.github.com/users/rackerlabs/events{/privacy}","received_events_url":"https://api.github.com/users/rackerlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rackerlabs/repose","description":"The powerful, programmable, API Middleware Platform","fork":false,"url":"https://api.github.com/repos/rackerlabs/repose","forks_url":"https://api.github.com/repos/rackerlabs/repose/forks","keys_url":"https://api.github.com/repos/rackerlabs/repose/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rackerlabs/repose/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rackerlabs/repose/teams","hooks_url":"https://api.github.com/repos/rackerlabs/repose/hooks","issue_events_url":"https://api.github.com/repos/rackerlabs/repose/issues/events{/number}","events_url":"https://api.github.com/repos/rackerlabs/repose/events","assignees_url":"https://api.github.com/repos/rackerlabs/repose/assignees{/user}","branches_url":"https://api.github.com/repos/rackerlabs/repose/branches{/branch}","tags_url":"https://api.github.com/repos/rackerlabs/repose/tags","blobs_url":"https://api.github.com/repos/rackerlabs/repose/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rackerlabs/repose/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rackerlabs/repose/git/refs{/sha}","trees_url":"https://api.github.com/repos/rackerlabs/repose/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rackerlabs/repose/statuses/{sha}","languages_url":"https://api.github.com/repos/rackerlabs/repose/languages","stargazers_url":"https://api.github.com/repos/rackerlabs/repose/stargazers","contributors_url":"https://api.github.com/repos/rackerlabs/repose/contributors","subscribers_url":"https://api.github.com/repos/rackerlabs/repose/subscribers","subscription_url":"https://api.github.com/repos/rackerlabs/repose/subscription","commits_url":"https://api.github.com/repos/rackerlabs/repose/commits{/sha}","git_commits_url":"https://api.github.com/repos/rackerlabs/repose/git/commits{/sha}","comments_url":"https://api.github.com/repos/rackerlabs/repose/comments{/number}","issue_comment_url":"https://api.github.com/repos/rackerlabs/repose/issues/comments/{number}","contents_url":"https://api.github.com/repos/rackerlabs/repose/contents/{+path}","compare_url":"https://api.github.com/repos/rackerlabs/repose/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rackerlabs/repose/merges","archive_url":"https://api.github.com/repos/rackerlabs/repose/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rackerlabs/repose/downloads","issues_url":"https://api.github.com/repos/rackerlabs/repose/issues{/number}","pulls_url":"https://api.github.com/repos/rackerlabs/repose/pulls{/number}","milestones_url":"https://api.github.com/repos/rackerlabs/repose/milestones{/number}","notifications_url":"https://api.github.com/repos/rackerlabs/repose/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rackerlabs/repose/labels{/name}","releases_url":"https://api.github.com/repos/rackerlabs/repose/releases{/id}","created_at":"2011-07-01T04:39:34Z","updated_at":"2014-07-18T19:27:31Z","pushed_at":"2014-07-21T20:57:47Z","git_url":"git://github.com/rackerlabs/repose.git","ssh_url":"git@github.com:rackerlabs/repose.git","clone_url":"https://github.com/rackerlabs/repose.git","svn_url":"https://github.com/rackerlabs/repose","homepage":"http://www.openrepose.org/","size":107928,"stargazers_count":146,"watchers_count":146,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":42,"mirror_url":null,"open_issues_count":6,"forks":42,"open_issues":6,"watchers":146,"default_branch":"master"}},"base":{"label":"rackerlabs:REP-282-Spring-Refactor","ref":"REP-282-Spring-Refactor","sha":"1e15951a1b62a18a168d87a08d07a7bf7265953d","user":{"login":"rackerlabs","id":84293,"avatar_url":"https://avatars.githubusercontent.com/u/84293?","gravatar_id":"cc2ad66c312c32facaf25a69bc6779cb","url":"https://api.github.com/users/rackerlabs","html_url":"https://github.com/rackerlabs","followers_url":"https://api.github.com/users/rackerlabs/followers","following_url":"https://api.github.com/users/rackerlabs/following{/other_user}","gists_url":"https://api.github.com/users/rackerlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/rackerlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rackerlabs/subscriptions","organizations_url":"https://api.github.com/users/rackerlabs/orgs","repos_url":"https://api.github.com/users/rackerlabs/repos","events_url":"https://api.github.com/users/rackerlabs/events{/privacy}","received_events_url":"https://api.github.com/users/rackerlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":1981821,"name":"repose","full_name":"rackerlabs/repose","owner":{"login":"rackerlabs","id":84293,"avatar_url":"https://avatars.githubusercontent.com/u/84293?","gravatar_id":"cc2ad66c312c32facaf25a69bc6779cb","url":"https://api.github.com/users/rackerlabs","html_url":"https://github.com/rackerlabs","followers_url":"https://api.github.com/users/rackerlabs/followers","following_url":"https://api.github.com/users/rackerlabs/following{/other_user}","gists_url":"https://api.github.com/users/rackerlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/rackerlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rackerlabs/subscriptions","organizations_url":"https://api.github.com/users/rackerlabs/orgs","repos_url":"https://api.github.com/users/rackerlabs/repos","events_url":"https://api.github.com/users/rackerlabs/events{/privacy}","received_events_url":"https://api.github.com/users/rackerlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rackerlabs/repose","description":"The powerful, programmable, API Middleware Platform","fork":false,"url":"https://api.github.com/repos/rackerlabs/repose","forks_url":"https://api.github.com/repos/rackerlabs/repose/forks","keys_url":"https://api.github.com/repos/rackerlabs/repose/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rackerlabs/repose/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rackerlabs/repose/teams","hooks_url":"https://api.github.com/repos/rackerlabs/repose/hooks","issue_events_url":"https://api.github.com/repos/rackerlabs/repose/issues/events{/number}","events_url":"https://api.github.com/repos/rackerlabs/repose/events","assignees_url":"https://api.github.com/repos/rackerlabs/repose/assignees{/user}","branches_url":"https://api.github.com/repos/rackerlabs/repose/branches{/branch}","tags_url":"https://api.github.com/repos/rackerlabs/repose/tags","blobs_url":"https://api.github.com/repos/rackerlabs/repose/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rackerlabs/repose/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rackerlabs/repose/git/refs{/sha}","trees_url":"https://api.github.com/repos/rackerlabs/repose/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rackerlabs/repose/statuses/{sha}","languages_url":"https://api.github.com/repos/rackerlabs/repose/languages","stargazers_url":"https://api.github.com/repos/rackerlabs/repose/stargazers","contributors_url":"https://api.github.com/repos/rackerlabs/repose/contributors","subscribers_url":"https://api.github.com/repos/rackerlabs/repose/subscribers","subscription_url":"https://api.github.com/repos/rackerlabs/repose/subscription","commits_url":"https://api.github.com/repos/rackerlabs/repose/commits{/sha}","git_commits_url":"https://api.github.com/repos/rackerlabs/repose/git/commits{/sha}","comments_url":"https://api.github.com/repos/rackerlabs/repose/comments{/number}","issue_comment_url":"https://api.github.com/repos/rackerlabs/repose/issues/comments/{number}","contents_url":"https://api.github.com/repos/rackerlabs/repose/contents/{+path}","compare_url":"https://api.github.com/repos/rackerlabs/repose/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rackerlabs/repose/merges","archive_url":"https://api.github.com/repos/rackerlabs/repose/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rackerlabs/repose/downloads","issues_url":"https://api.github.com/repos/rackerlabs/repose/issues{/number}","pulls_url":"https://api.github.com/repos/rackerlabs/repose/pulls{/number}","milestones_url":"https://api.github.com/repos/rackerlabs/repose/milestones{/number}","notifications_url":"https://api.github.com/repos/rackerlabs/repose/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rackerlabs/repose/labels{/name}","releases_url":"https://api.github.com/repos/rackerlabs/repose/releases{/id}","created_at":"2011-07-01T04:39:34Z","updated_at":"2014-07-18T19:27:31Z","pushed_at":"2014-07-21T20:57:47Z","git_url":"git://github.com/rackerlabs/repose.git","ssh_url":"git@github.com:rackerlabs/repose.git","clone_url":"https://github.com/rackerlabs/repose.git","svn_url":"https://github.com/rackerlabs/repose","homepage":"http://www.openrepose.org/","size":107928,"stargazers_count":146,"watchers_count":146,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":42,"mirror_url":null,"open_issues_count":6,"forks":42,"open_issues":6,"watchers":146,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rackerlabs/repose/pulls/1040"},"html":{"href":"https://github.com/rackerlabs/repose/pull/1040"},"issue":{"href":"https://api.github.com/repos/rackerlabs/repose/issues/1040"},"comments":{"href":"https://api.github.com/repos/rackerlabs/repose/issues/1040/comments"},"review_comments":{"href":"https://api.github.com/repos/rackerlabs/repose/pulls/1040/comments"},"review_comment":{"href":"https://api.github.com/repos/rackerlabs/repose/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/rackerlabs/repose/pulls/1040/commits"},"statuses":{"href":"https://api.github.com/repos/rackerlabs/repose/statuses/6c992717cf8aee9ca4a3810840674da9c29ca513"}}}}