GitHub PullRequestEvent at 2014-09-09 07:42:45
Repository: http-errors
Actor: rlidwka
Payload: {"action":"opened","number":3,"pull_request":{"url":"https://api.github.com/repos/jshttp/http-errors/pulls/3","id":20938507,"html_url":"https://github.com/jshttp/http-errors/pull/3","diff_url":"https://github.com/jshttp/http-errors/pull/3.diff","patch_url":"https://github.com/jshttp/http-errors/pull/3.patch","issue_url":"https://api.github.com/repos/jshttp/http-errors/issues/3","number":3,"state":"open","locked":false,"title":"inherit using prototype injection, avoid classes","user":{"login":"rlidwka","id":999113,"avatar_url":"https://avatars.githubusercontent.com/u/999113?v=2","gravatar_id":"0d78a1b90a7c9d6fc7c87d0010bccf53","url":"https://api.github.com/users/rlidwka","html_url":"https://github.com/rlidwka","followers_url":"https://api.github.com/users/rlidwka/followers","following_url":"https://api.github.com/users/rlidwka/following{/other_user}","gists_url":"https://api.github.com/users/rlidwka/gists{/gist_id}","starred_url":"https://api.github.com/users/rlidwka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rlidwka/subscriptions","organizations_url":"https://api.github.com/users/rlidwka/orgs","repos_url":"https://api.github.com/users/rlidwka/repos","events_url":"https://api.github.com/users/rlidwka/events{/privacy}","received_events_url":"https://api.github.com/users/rlidwka/received_events","type":"User","site_admin":false},"body":"```js\r\n// this is good:\r\n> Object.prototype.toString.call(require('http-errors')('x'))\r\n'[object Error]'\r\n\r\n// this is bad:\r\n> Object.prototype.toString.call(new (require('http-errors')[404])('x'))\r\n'[object Object]'\r\n\r\n// this is *very* bad :)\r\n> Object.prototype.toString.call(require('http-errors')[404]('x'))\r\n'[object Undefined]'\r\n```\r\n\r\nref: https://github.com/jshttp/jshttp.github.io/issues/35#issuecomment-54106646","created_at":"2014-09-09T07:42:45Z","updated_at":"2014-09-09T07:42:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jshttp/http-errors/pulls/3/commits","review_comments_url":"https://api.github.com/repos/jshttp/http-errors/pulls/3/comments","review_comment_url":"https://api.github.com/repos/jshttp/http-errors/pulls/comments/{number}","comments_url":"https://api.github.com/repos/jshttp/http-errors/issues/3/comments","statuses_url":"https://api.github.com/repos/jshttp/http-errors/statuses/526fc26abd466b2c5c378f84f77369ab526031c7","head":{"label":"rlidwka:inj","ref":"inj","sha":"526fc26abd466b2c5c378f84f77369ab526031c7","user":{"login":"rlidwka","id":999113,"avatar_url":"https://avatars.githubusercontent.com/u/999113?v=2","gravatar_id":"0d78a1b90a7c9d6fc7c87d0010bccf53","url":"https://api.github.com/users/rlidwka","html_url":"https://github.com/rlidwka","followers_url":"https://api.github.com/users/rlidwka/followers","following_url":"https://api.github.com/users/rlidwka/following{/other_user}","gists_url":"https://api.github.com/users/rlidwka/gists{/gist_id}","starred_url":"https://api.github.com/users/rlidwka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rlidwka/subscriptions","organizations_url":"https://api.github.com/users/rlidwka/orgs","repos_url":"https://api.github.com/users/rlidwka/repos","events_url":"https://api.github.com/users/rlidwka/events{/privacy}","received_events_url":"https://api.github.com/users/rlidwka/received_events","type":"User","site_admin":false},"repo":{"id":23823241,"name":"http-errors","full_name":"rlidwka/http-errors","owner":{"login":"rlidwka","id":999113,"avatar_url":"https://avatars.githubusercontent.com/u/999113?v=2","gravatar_id":"0d78a1b90a7c9d6fc7c87d0010bccf53","url":"https://api.github.com/users/rlidwka","html_url":"https://github.com/rlidwka","followers_url":"https://api.github.com/users/rlidwka/followers","following_url":"https://api.github.com/users/rlidwka/following{/other_user}","gists_url":"https://api.github.com/users/rlidwka/gists{/gist_id}","starred_url":"https://api.github.com/users/rlidwka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rlidwka/subscriptions","organizations_url":"https://api.github.com/users/rlidwka/orgs","repos_url":"https://api.github.com/users/rlidwka/repos","events_url":"https://api.github.com/users/rlidwka/events{/privacy}","received_events_url":"https://api.github.com/users/rlidwka/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rlidwka/http-errors","description":"Create HTTP Errors","fork":true,"url":"https://api.github.com/repos/rlidwka/http-errors","forks_url":"https://api.github.com/repos/rlidwka/http-errors/forks","keys_url":"https://api.github.com/repos/rlidwka/http-errors/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rlidwka/http-errors/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rlidwka/http-errors/teams","hooks_url":"https://api.github.com/repos/rlidwka/http-errors/hooks","issue_events_url":"https://api.github.com/repos/rlidwka/http-errors/issues/events{/number}","events_url":"https://api.github.com/repos/rlidwka/http-errors/events","assignees_url":"https://api.github.com/repos/rlidwka/http-errors/assignees{/user}","branches_url":"https://api.github.com/repos/rlidwka/http-errors/branches{/branch}","tags_url":"https://api.github.com/repos/rlidwka/http-errors/tags","blobs_url":"https://api.github.com/repos/rlidwka/http-errors/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rlidwka/http-errors/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rlidwka/http-errors/git/refs{/sha}","trees_url":"https://api.github.com/repos/rlidwka/http-errors/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rlidwka/http-errors/statuses/{sha}","languages_url":"https://api.github.com/repos/rlidwka/http-errors/languages","stargazers_url":"https://api.github.com/repos/rlidwka/http-errors/stargazers","contributors_url":"https://api.github.com/repos/rlidwka/http-errors/contributors","subscribers_url":"https://api.github.com/repos/rlidwka/http-errors/subscribers","subscription_url":"https://api.github.com/repos/rlidwka/http-errors/subscription","commits_url":"https://api.github.com/repos/rlidwka/http-errors/commits{/sha}","git_commits_url":"https://api.github.com/repos/rlidwka/http-errors/git/commits{/sha}","comments_url":"https://api.github.com/repos/rlidwka/http-errors/comments{/number}","issue_comment_url":"https://api.github.com/repos/rlidwka/http-errors/issues/comments/{number}","contents_url":"https://api.github.com/repos/rlidwka/http-errors/contents/{+path}","compare_url":"https://api.github.com/repos/rlidwka/http-errors/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rlidwka/http-errors/merges","archive_url":"https://api.github.com/repos/rlidwka/http-errors/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rlidwka/http-errors/downloads","issues_url":"https://api.github.com/repos/rlidwka/http-errors/issues{/number}","pulls_url":"https://api.github.com/repos/rlidwka/http-errors/pulls{/number}","milestones_url":"https://api.github.com/repos/rlidwka/http-errors/milestones{/number}","notifications_url":"https://api.github.com/repos/rlidwka/http-errors/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rlidwka/http-errors/labels{/name}","releases_url":"https://api.github.com/repos/rlidwka/http-errors/releases{/id}","created_at":"2014-09-09T07:11:52Z","updated_at":"2014-09-09T07:11:19Z","pushed_at":"2014-09-09T07:35:21Z","git_url":"git://github.com/rlidwka/http-errors.git","ssh_url":"git@github.com:rlidwka/http-errors.git","clone_url":"https://github.com/rlidwka/http-errors.git","svn_url":"https://github.com/rlidwka/http-errors","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jshttp:master","ref":"master","sha":"7b59d5f38857d25e881276c17b4775c7925c611f","user":{"login":"jshttp","id":8325802,"avatar_url":"https://avatars.githubusercontent.com/u/8325802?v=2","gravatar_id":null,"url":"https://api.github.com/users/jshttp","html_url":"https://github.com/jshttp","followers_url":"https://api.github.com/users/jshttp/followers","following_url":"https://api.github.com/users/jshttp/following{/other_user}","gists_url":"https://api.github.com/users/jshttp/gists{/gist_id}","starred_url":"https://api.github.com/users/jshttp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jshttp/subscriptions","organizations_url":"https://api.github.com/users/jshttp/orgs","repos_url":"https://api.github.com/users/jshttp/repos","events_url":"https://api.github.com/users/jshttp/events{/privacy}","received_events_url":"https://api.github.com/users/jshttp/received_events","type":"Organization","site_admin":false},"repo":{"id":23806086,"name":"http-errors","full_name":"jshttp/http-errors","owner":{"login":"jshttp","id":8325802,"avatar_url":"https://avatars.githubusercontent.com/u/8325802?v=2","gravatar_id":null,"url":"https://api.github.com/users/jshttp","html_url":"https://github.com/jshttp","followers_url":"https://api.github.com/users/jshttp/followers","following_url":"https://api.github.com/users/jshttp/following{/other_user}","gists_url":"https://api.github.com/users/jshttp/gists{/gist_id}","starred_url":"https://api.github.com/users/jshttp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jshttp/subscriptions","organizations_url":"https://api.github.com/users/jshttp/orgs","repos_url":"https://api.github.com/users/jshttp/repos","events_url":"https://api.github.com/users/jshttp/events{/privacy}","received_events_url":"https://api.github.com/users/jshttp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jshttp/http-errors","description":"Create HTTP Errors","fork":false,"url":"https://api.github.com/repos/jshttp/http-errors","forks_url":"https://api.github.com/repos/jshttp/http-errors/forks","keys_url":"https://api.github.com/repos/jshttp/http-errors/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jshttp/http-errors/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jshttp/http-errors/teams","hooks_url":"https://api.github.com/repos/jshttp/http-errors/hooks","issue_events_url":"https://api.github.com/repos/jshttp/http-errors/issues/events{/number}","events_url":"https://api.github.com/repos/jshttp/http-errors/events","assignees_url":"https://api.github.com/repos/jshttp/http-errors/assignees{/user}","branches_url":"https://api.github.com/repos/jshttp/http-errors/branches{/branch}","tags_url":"https://api.github.com/repos/jshttp/http-errors/tags","blobs_url":"https://api.github.com/repos/jshttp/http-errors/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jshttp/http-errors/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jshttp/http-errors/git/refs{/sha}","trees_url":"https://api.github.com/repos/jshttp/http-errors/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jshttp/http-errors/statuses/{sha}","languages_url":"https://api.github.com/repos/jshttp/http-errors/languages","stargazers_url":"https://api.github.com/repos/jshttp/http-errors/stargazers","contributors_url":"https://api.github.com/repos/jshttp/http-errors/contributors","subscribers_url":"https://api.github.com/repos/jshttp/http-errors/subscribers","subscription_url":"https://api.github.com/repos/jshttp/http-errors/subscription","commits_url":"https://api.github.com/repos/jshttp/http-errors/commits{/sha}","git_commits_url":"https://api.github.com/repos/jshttp/http-errors/git/commits{/sha}","comments_url":"https://api.github.com/repos/jshttp/http-errors/comments{/number}","issue_comment_url":"https://api.github.com/repos/jshttp/http-errors/issues/comments/{number}","contents_url":"https://api.github.com/repos/jshttp/http-errors/contents/{+path}","compare_url":"https://api.github.com/repos/jshttp/http-errors/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jshttp/http-errors/merges","archive_url":"https://api.github.com/repos/jshttp/http-errors/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jshttp/http-errors/downloads","issues_url":"https://api.github.com/repos/jshttp/http-errors/issues{/number}","pulls_url":"https://api.github.com/repos/jshttp/http-errors/pulls{/number}","milestones_url":"https://api.github.com/repos/jshttp/http-errors/milestones{/number}","notifications_url":"https://api.github.com/repos/jshttp/http-errors/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jshttp/http-errors/labels{/name}","releases_url":"https://api.github.com/repos/jshttp/http-errors/releases{/id}","created_at":"2014-09-08T20:02:20Z","updated_at":"2014-09-09T07:11:19Z","pushed_at":"2014-09-09T05:02:28Z","git_url":"git://github.com/jshttp/http-errors.git","ssh_url":"git@github.com:jshttp/http-errors.git","clone_url":"https://github.com/jshttp/http-errors.git","svn_url":"https://github.com/jshttp/http-errors","homepage":null,"size":0,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jshttp/http-errors/pulls/3"},"html":{"href":"https://github.com/jshttp/http-errors/pull/3"},"issue":{"href":"https://api.github.com/repos/jshttp/http-errors/issues/3"},"comments":{"href":"https://api.github.com/repos/jshttp/http-errors/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/jshttp/http-errors/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/jshttp/http-errors/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/jshttp/http-errors/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/jshttp/http-errors/statuses/526fc26abd466b2c5c378f84f77369ab526031c7"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":19,"deletions":6,"changed_files":2}}