GitHub PullRequestReviewCommentEvent at 2014-11-03 17:07:41
Repository: puppet
Actor: cyberious
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/19747046","id":19747046,"diff_hunk":"@@ -9,7 +9,13 @@ module Puppet::Util::Windows::Process\n   WAIT_TIMEOUT = 0x102\n \n   def execute(command, arguments, stdin, stdout, stderr)\n-    Process.create( :command_line => command, :startup_info => {:stdin => stdin, :stdout => stdout, :stderr => stderr}, :close_handles => false )\n+    begin \n+      Process.create( :command_line => command, :startup_info => {:stdin => stdin, :stdout => stdout, :stderr => stderr}, :close_handles => false )\n+    rescue SystemCallError => detail\n+      msg += \"\\n#{detail}\"\n+      raise Puppet::Util::Windows::Error.new(msg)","path":"lib/puppet/util/windows/process.rb","position":9,"original_position":9,"commit_id":"09e390898f5a850a82c9f7130d4977b32cfb5d4f","original_commit_id":"09e390898f5a850a82c9f7130d4977b32cfb5d4f","user":{"login":"cyberious","id":1703710,"avatar_url":"https://avatars.githubusercontent.com/u/1703710?v=2","gravatar_id":"","url":"https://api.github.com/users/cyberious","html_url":"https://github.com/cyberious","followers_url":"https://api.github.com/users/cyberious/followers","following_url":"https://api.github.com/users/cyberious/following{/other_user}","gists_url":"https://api.github.com/users/cyberious/gists{/gist_id}","starred_url":"https://api.github.com/users/cyberious/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyberious/subscriptions","organizations_url":"https://api.github.com/users/cyberious/orgs","repos_url":"https://api.github.com/users/cyberious/repos","events_url":"https://api.github.com/users/cyberious/events{/privacy}","received_events_url":"https://api.github.com/users/cyberious/received_events","type":"User","site_admin":false},"body":"Are you agreeing with this change or requesting updates?","created_at":"2014-11-03T17:07:41Z","updated_at":"2014-11-03T17:07:41Z","html_url":"https://github.com/puppetlabs/puppet/pull/3253#discussion_r19747046","pull_request_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/3253","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/19747046"},"html":{"href":"https://github.com/puppetlabs/puppet/pull/3253#discussion_r19747046"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/3253"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppet/pulls/3253","id":23507897,"html_url":"https://github.com/puppetlabs/puppet/pull/3253","diff_url":"https://github.com/puppetlabs/puppet/pull/3253.diff","patch_url":"https://github.com/puppetlabs/puppet/pull/3253.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppet/issues/3253","number":3253,"state":"open","locked":false,"title":"PUP-3561 add exception catch and wrapping into known exception type","user":{"login":"cyberious","id":1703710,"avatar_url":"https://avatars.githubusercontent.com/u/1703710?v=2","gravatar_id":"","url":"https://api.github.com/users/cyberious","html_url":"https://github.com/cyberious","followers_url":"https://api.github.com/users/cyberious/followers","following_url":"https://api.github.com/users/cyberious/following{/other_user}","gists_url":"https://api.github.com/users/cyberious/gists{/gist_id}","starred_url":"https://api.github.com/users/cyberious/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyberious/subscriptions","organizations_url":"https://api.github.com/users/cyberious/orgs","repos_url":"https://api.github.com/users/cyberious/repos","events_url":"https://api.github.com/users/cyberious/events{/privacy}","received_events_url":"https://api.github.com/users/cyberious/received_events","type":"User","site_admin":false},"body":null,"created_at":"2014-10-29T04:27:38Z","updated_at":"2014-11-03T17:07:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1f192153fb8e5d54d996861ebfaa03e89bc51a4e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/3253/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/3253/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/{number}","comments_url":"https://api.github.com/repos/puppetlabs/puppet/issues/3253/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppet/statuses/09e390898f5a850a82c9f7130d4977b32cfb5d4f","head":{"label":"cyberious:WrapException","ref":"WrapException","sha":"09e390898f5a850a82c9f7130d4977b32cfb5d4f","user":{"login":"cyberious","id":1703710,"avatar_url":"https://avatars.githubusercontent.com/u/1703710?v=2","gravatar_id":"","url":"https://api.github.com/users/cyberious","html_url":"https://github.com/cyberious","followers_url":"https://api.github.com/users/cyberious/followers","following_url":"https://api.github.com/users/cyberious/following{/other_user}","gists_url":"https://api.github.com/users/cyberious/gists{/gist_id}","starred_url":"https://api.github.com/users/cyberious/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyberious/subscriptions","organizations_url":"https://api.github.com/users/cyberious/orgs","repos_url":"https://api.github.com/users/cyberious/repos","events_url":"https://api.github.com/users/cyberious/events{/privacy}","received_events_url":"https://api.github.com/users/cyberious/received_events","type":"User","site_admin":false},"repo":{"id":20421609,"name":"puppet","full_name":"cyberious/puppet","owner":{"login":"cyberious","id":1703710,"avatar_url":"https://avatars.githubusercontent.com/u/1703710?v=2","gravatar_id":"","url":"https://api.github.com/users/cyberious","html_url":"https://github.com/cyberious","followers_url":"https://api.github.com/users/cyberious/followers","following_url":"https://api.github.com/users/cyberious/following{/other_user}","gists_url":"https://api.github.com/users/cyberious/gists{/gist_id}","starred_url":"https://api.github.com/users/cyberious/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyberious/subscriptions","organizations_url":"https://api.github.com/users/cyberious/orgs","repos_url":"https://api.github.com/users/cyberious/repos","events_url":"https://api.github.com/users/cyberious/events{/privacy}","received_events_url":"https://api.github.com/users/cyberious/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cyberious/puppet","description":"Server automation framework and application","fork":true,"url":"https://api.github.com/repos/cyberious/puppet","forks_url":"https://api.github.com/repos/cyberious/puppet/forks","keys_url":"https://api.github.com/repos/cyberious/puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cyberious/puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cyberious/puppet/teams","hooks_url":"https://api.github.com/repos/cyberious/puppet/hooks","issue_events_url":"https://api.github.com/repos/cyberious/puppet/issues/events{/number}","events_url":"https://api.github.com/repos/cyberious/puppet/events","assignees_url":"https://api.github.com/repos/cyberious/puppet/assignees{/user}","branches_url":"https://api.github.com/repos/cyberious/puppet/branches{/branch}","tags_url":"https://api.github.com/repos/cyberious/puppet/tags","blobs_url":"https://api.github.com/repos/cyberious/puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cyberious/puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cyberious/puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/cyberious/puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cyberious/puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/cyberious/puppet/languages","stargazers_url":"https://api.github.com/repos/cyberious/puppet/stargazers","contributors_url":"https://api.github.com/repos/cyberious/puppet/contributors","subscribers_url":"https://api.github.com/repos/cyberious/puppet/subscribers","subscription_url":"https://api.github.com/repos/cyberious/puppet/subscription","commits_url":"https://api.github.com/repos/cyberious/puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/cyberious/puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/cyberious/puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/cyberious/puppet/issues/comments/{number}","contents_url":"https://api.github.com/repos/cyberious/puppet/contents/{+path}","compare_url":"https://api.github.com/repos/cyberious/puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cyberious/puppet/merges","archive_url":"https://api.github.com/repos/cyberious/puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cyberious/puppet/downloads","issues_url":"https://api.github.com/repos/cyberious/puppet/issues{/number}","pulls_url":"https://api.github.com/repos/cyberious/puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/cyberious/puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/cyberious/puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cyberious/puppet/labels{/name}","releases_url":"https://api.github.com/repos/cyberious/puppet/releases{/id}","created_at":"2014-06-02T22:15:29Z","updated_at":"2014-06-02T22:15:38Z","pushed_at":"2014-10-29T04:27:05Z","git_url":"git://github.com/cyberious/puppet.git","ssh_url":"git@github.com:cyberious/puppet.git","clone_url":"https://github.com/cyberious/puppet.git","svn_url":"https://github.com/cyberious/puppet","homepage":"http://www.puppetlabs.com/puppet/introduction/","size":42469,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"6794115e31401be660a806f1f59251baf2943bfe","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=2","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":910744,"name":"puppet","full_name":"puppetlabs/puppet","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=2","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/puppet","description":"Server automation framework and application","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppet","forks_url":"https://api.github.com/repos/puppetlabs/puppet/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppet/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppet/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppet/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppet/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppet/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppet/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppet/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppet/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppet/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppet/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppet/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppet/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppet/issues/comments/{number}","contents_url":"https://api.github.com/repos/puppetlabs/puppet/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppet/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppet/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppet/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppet/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppet/releases{/id}","created_at":"2010-09-14T19:26:44Z","updated_at":"2014-11-03T02:49:03Z","pushed_at":"2014-11-03T16:14:12Z","git_url":"git://github.com/puppetlabs/puppet.git","ssh_url":"git@github.com:puppetlabs/puppet.git","clone_url":"https://github.com/puppetlabs/puppet.git","svn_url":"https://github.com/puppetlabs/puppet","homepage":"http://www.puppetlabs.com/puppet/introduction/","size":114355,"stargazers_count":2688,"watchers_count":2688,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1186,"mirror_url":null,"open_issues_count":63,"forks":1186,"open_issues":63,"watchers":2688,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/3253"},"html":{"href":"https://github.com/puppetlabs/puppet/pull/3253"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppet/issues/3253"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppet/issues/3253/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/3253/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/3253/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppet/statuses/09e390898f5a850a82c9f7130d4977b32cfb5d4f"}}}}