GitHub PullRequestReviewCommentEvent at 2014-05-06 16:29:22
Repository: js_of_ocaml
Actor: hhugo
Payload: {"comment":{"url":"https://api.github.com/repos/ocsigen/js_of_ocaml/pulls/comments/12333772","id":12333772,"diff_hunk":"@@ -0,0 +1,71 @@\n+#!/usr/bin/env ocaml;;\n+#directory \"pkg\";;\n+#use \"topkg.ml\";;\n+#use \"common.ml\";;\n+let with_deriving = Env.bool \"deriving\"\n+let with_graphics = Env.bool \"graphics\"\n+\n+module ByteExts = struct\n+  let interface = [\".mli\"; \".cmi\"; \".cmti\"]\n+  let library = [\".cma\"]\n+  let module_library = (interface @ library)\n+end\n+\n+let fulllib ?cond ext_lib ext_int name =\n+  let l = read_mllist (name ^ \".mllib\") in\n+  let cma = Pkg.lib ~exts:ext_lib name in\n+  let filelist = List.map (fun f ->\n+      Pkg.lib ?cond ~exts:ByteExts.interface f) l in\n+  cma :: filelist\n+\n+\n+let () =\n+  Pkg.describe \"js_of_ocaml\" ~builder:`OCamlbuild (List.flatten [","path":"pkg/build.ml","position":23,"original_position":23,"commit_id":"58c728e9f0889a85bf49bc8296c34412e652ec45","original_commit_id":"58c728e9f0889a85bf49bc8296c34412e652ec45","user":{"login":"hhugo","id":835209,"avatar_url":"https://avatars.githubusercontent.com/u/835209?","gravatar_id":"7412da9a51cb767e71f5647fb0970e92","url":"https://api.github.com/users/hhugo","html_url":"https://github.com/hhugo","followers_url":"https://api.github.com/users/hhugo/followers","following_url":"https://api.github.com/users/hhugo/following{/other_user}","gists_url":"https://api.github.com/users/hhugo/gists{/gist_id}","starred_url":"https://api.github.com/users/hhugo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hhugo/subscriptions","organizations_url":"https://api.github.com/users/hhugo/orgs","repos_url":"https://api.github.com/users/hhugo/repos","events_url":"https://api.github.com/users/hhugo/events{/privacy}","received_events_url":"https://api.github.com/users/hhugo/received_events","type":"User","site_admin":false},"body":"The list flatten is certainly bad.\r\nIt would require a `Pkg.list : move list -> move`","created_at":"2014-05-06T16:29:22Z","updated_at":"2014-05-06T16:29:22Z","html_url":"https://github.com/ocsigen/js_of_ocaml/pull/156#discussion_r12333772","pull_request_url":"https://api.github.com/repos/ocsigen/js_of_ocaml/pulls/156","_links":{"self":{"href":"https://api.github.com/repos/ocsigen/js_of_ocaml/pulls/comments/12333772"},"html":{"href":"https://github.com/ocsigen/js_of_ocaml/pull/156#discussion_r12333772"},"pull_request":{"href":"https://api.github.com/repos/ocsigen/js_of_ocaml/pulls/156"}}}}