GitHub PullRequestEvent at 2014-12-10 08:11:24
Repository: hapi
Actor: hueniverse
Payload: {"action":"closed","number":2274,"pull_request":{"url":"https://api.github.com/repos/hapijs/hapi/pulls/2274","id":25803003,"html_url":"https://github.com/hapijs/hapi/pull/2274","diff_url":"https://github.com/hapijs/hapi/pull/2274.diff","patch_url":"https://github.com/hapijs/hapi/pull/2274.patch","issue_url":"https://api.github.com/repos/hapijs/hapi/issues/2274","number":2274,"state":"closed","locked":false,"title":"[doc] Server object option property mismatch/typo","user":{"login":"blakmatrix","id":91209,"avatar_url":"https://avatars.githubusercontent.com/u/91209?v=3","gravatar_id":"","url":"https://api.github.com/users/blakmatrix","html_url":"https://github.com/blakmatrix","followers_url":"https://api.github.com/users/blakmatrix/followers","following_url":"https://api.github.com/users/blakmatrix/following{/other_user}","gists_url":"https://api.github.com/users/blakmatrix/gists{/gist_id}","starred_url":"https://api.github.com/users/blakmatrix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blakmatrix/subscriptions","organizations_url":"https://api.github.com/users/blakmatrix/orgs","repos_url":"https://api.github.com/users/blakmatrix/repos","events_url":"https://api.github.com/users/blakmatrix/events{/privacy}","received_events_url":"https://api.github.com/users/blakmatrix/received_events","type":"User","site_admin":false},"body":"In the current docs for `v8.0.x`, it appears that there may be a mismatch in the `Server` object property `load`.\r\nI've simply changed `load.sampleInterface` to `load.sampleInterval`\r\nWhen following documentation one will get an error similar to:\r\n```\r\n/Users/blakmatrix/projects/hapidays/code/node_modules/joi/lib/index.js:121\r\n            throw new Error(message + error.annotate());\r\n                  ^\r\nError: Invalid load monitoring options {\r\n  \"sampleInterval\": 0,\r\n  \"sampleInterface\" [1]: 1\r\n}\r\n\r\n[1] sampleInterface is not allowed\r\n    at root.assert (/Users/blakmatrix/projects/hapidays/code/node_modules/joi/lib/index.js:121:19)\r\n    at new module.exports.internals.Heavy (/Users/blakmatrix/projects/hapidays/code/node_modules/hapi/node_modules/heavy/lib/index.js:41:9)\r\n    at new module.exports.internals.Server (/Users/blakmatrix/projects/hapidays/code/node_modules/hapi/lib/server.js:46:19)\r\n    at Object.<anonymous> (/Users/blakmatrix/projects/hapidays/code/app.js:7:16)\r\n    at Module._compile (module.js:456:26)\r\n    at Object.Module._extensions..js (module.js:474:10)\r\n    at Module.load (module.js:356:32)\r\n    at Function.Module._load (module.js:312:12)\r\n    at Function.Module.runMain (module.js:497:10)\r\n    at startup (node.js:119:16)\r\n```\r\n\r\nI was unable to find any usage of `load.sampleInterface` in the code, I noticed there were a lot of interface changes in `v8.0.0` so I'm thinking perhaps interface was on the brain or perhaps some functionality didn't get shipped--either way, this will prevent others from encountering this error.","created_at":"2014-12-10T07:18:35Z","updated_at":"2014-12-10T08:11:24Z","closed_at":"2014-12-10T08:11:24Z","merged_at":"2014-12-10T08:11:24Z","merge_commit_sha":"c55499d9175bf3ba2d01768740ee6c647d7dd58c","assignee":{"login":"hueniverse","id":56631,"avatar_url":"https://avatars.githubusercontent.com/u/56631?v=3","gravatar_id":"","url":"https://api.github.com/users/hueniverse","html_url":"https://github.com/hueniverse","followers_url":"https://api.github.com/users/hueniverse/followers","following_url":"https://api.github.com/users/hueniverse/following{/other_user}","gists_url":"https://api.github.com/users/hueniverse/gists{/gist_id}","starred_url":"https://api.github.com/users/hueniverse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hueniverse/subscriptions","organizations_url":"https://api.github.com/users/hueniverse/orgs","repos_url":"https://api.github.com/users/hueniverse/repos","events_url":"https://api.github.com/users/hueniverse/events{/privacy}","received_events_url":"https://api.github.com/users/hueniverse/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/hapijs/hapi/pulls/2274/commits","review_comments_url":"https://api.github.com/repos/hapijs/hapi/pulls/2274/comments","review_comment_url":"https://api.github.com/repos/hapijs/hapi/pulls/comments/{number}","comments_url":"https://api.github.com/repos/hapijs/hapi/issues/2274/comments","statuses_url":"https://api.github.com/repos/hapijs/hapi/statuses/2ee17ea20b5f3c0a62bda53f82b3faff1e86a60f","head":{"label":"blakmatrix:patch-1","ref":"patch-1","sha":"2ee17ea20b5f3c0a62bda53f82b3faff1e86a60f","user":{"login":"blakmatrix","id":91209,"avatar_url":"https://avatars.githubusercontent.com/u/91209?v=3","gravatar_id":"","url":"https://api.github.com/users/blakmatrix","html_url":"https://github.com/blakmatrix","followers_url":"https://api.github.com/users/blakmatrix/followers","following_url":"https://api.github.com/users/blakmatrix/following{/other_user}","gists_url":"https://api.github.com/users/blakmatrix/gists{/gist_id}","starred_url":"https://api.github.com/users/blakmatrix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blakmatrix/subscriptions","organizations_url":"https://api.github.com/users/blakmatrix/orgs","repos_url":"https://api.github.com/users/blakmatrix/repos","events_url":"https://api.github.com/users/blakmatrix/events{/privacy}","received_events_url":"https://api.github.com/users/blakmatrix/received_events","type":"User","site_admin":false},"repo":{"id":27806683,"name":"hapi","full_name":"blakmatrix/hapi","owner":{"login":"blakmatrix","id":91209,"avatar_url":"https://avatars.githubusercontent.com/u/91209?v=3","gravatar_id":"","url":"https://api.github.com/users/blakmatrix","html_url":"https://github.com/blakmatrix","followers_url":"https://api.github.com/users/blakmatrix/followers","following_url":"https://api.github.com/users/blakmatrix/following{/other_user}","gists_url":"https://api.github.com/users/blakmatrix/gists{/gist_id}","starred_url":"https://api.github.com/users/blakmatrix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blakmatrix/subscriptions","organizations_url":"https://api.github.com/users/blakmatrix/orgs","repos_url":"https://api.github.com/users/blakmatrix/repos","events_url":"https://api.github.com/users/blakmatrix/events{/privacy}","received_events_url":"https://api.github.com/users/blakmatrix/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/blakmatrix/hapi","description":"Server Framework  for Node.js","fork":true,"url":"https://api.github.com/repos/blakmatrix/hapi","forks_url":"https://api.github.com/repos/blakmatrix/hapi/forks","keys_url":"https://api.github.com/repos/blakmatrix/hapi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/blakmatrix/hapi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/blakmatrix/hapi/teams","hooks_url":"https://api.github.com/repos/blakmatrix/hapi/hooks","issue_events_url":"https://api.github.com/repos/blakmatrix/hapi/issues/events{/number}","events_url":"https://api.github.com/repos/blakmatrix/hapi/events","assignees_url":"https://api.github.com/repos/blakmatrix/hapi/assignees{/user}","branches_url":"https://api.github.com/repos/blakmatrix/hapi/branches{/branch}","tags_url":"https://api.github.com/repos/blakmatrix/hapi/tags","blobs_url":"https://api.github.com/repos/blakmatrix/hapi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/blakmatrix/hapi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/blakmatrix/hapi/git/refs{/sha}","trees_url":"https://api.github.com/repos/blakmatrix/hapi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/blakmatrix/hapi/statuses/{sha}","languages_url":"https://api.github.com/repos/blakmatrix/hapi/languages","stargazers_url":"https://api.github.com/repos/blakmatrix/hapi/stargazers","contributors_url":"https://api.github.com/repos/blakmatrix/hapi/contributors","subscribers_url":"https://api.github.com/repos/blakmatrix/hapi/subscribers","subscription_url":"https://api.github.com/repos/blakmatrix/hapi/subscription","commits_url":"https://api.github.com/repos/blakmatrix/hapi/commits{/sha}","git_commits_url":"https://api.github.com/repos/blakmatrix/hapi/git/commits{/sha}","comments_url":"https://api.github.com/repos/blakmatrix/hapi/comments{/number}","issue_comment_url":"https://api.github.com/repos/blakmatrix/hapi/issues/comments/{number}","contents_url":"https://api.github.com/repos/blakmatrix/hapi/contents/{+path}","compare_url":"https://api.github.com/repos/blakmatrix/hapi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/blakmatrix/hapi/merges","archive_url":"https://api.github.com/repos/blakmatrix/hapi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/blakmatrix/hapi/downloads","issues_url":"https://api.github.com/repos/blakmatrix/hapi/issues{/number}","pulls_url":"https://api.github.com/repos/blakmatrix/hapi/pulls{/number}","milestones_url":"https://api.github.com/repos/blakmatrix/hapi/milestones{/number}","notifications_url":"https://api.github.com/repos/blakmatrix/hapi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/blakmatrix/hapi/labels{/name}","releases_url":"https://api.github.com/repos/blakmatrix/hapi/releases{/id}","created_at":"2014-12-10T07:00:09Z","updated_at":"2014-12-10T07:00:10Z","pushed_at":"2014-12-10T07:08:53Z","git_url":"git://github.com/blakmatrix/hapi.git","ssh_url":"git@github.com:blakmatrix/hapi.git","clone_url":"https://github.com/blakmatrix/hapi.git","svn_url":"https://github.com/blakmatrix/hapi","homepage":"hapijs.com","size":19140,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hapijs:master","ref":"master","sha":"1e47a08c91ab502da5d8092b4ed80c9c3a6e9a43","user":{"login":"hapijs","id":3774533,"avatar_url":"https://avatars.githubusercontent.com/u/3774533?v=3","gravatar_id":"","url":"https://api.github.com/users/hapijs","html_url":"https://github.com/hapijs","followers_url":"https://api.github.com/users/hapijs/followers","following_url":"https://api.github.com/users/hapijs/following{/other_user}","gists_url":"https://api.github.com/users/hapijs/gists{/gist_id}","starred_url":"https://api.github.com/users/hapijs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hapijs/subscriptions","organizations_url":"https://api.github.com/users/hapijs/orgs","repos_url":"https://api.github.com/users/hapijs/repos","events_url":"https://api.github.com/users/hapijs/events{/privacy}","received_events_url":"https://api.github.com/users/hapijs/received_events","type":"Organization","site_admin":false},"repo":{"id":2163263,"name":"hapi","full_name":"hapijs/hapi","owner":{"login":"hapijs","id":3774533,"avatar_url":"https://avatars.githubusercontent.com/u/3774533?v=3","gravatar_id":"","url":"https://api.github.com/users/hapijs","html_url":"https://github.com/hapijs","followers_url":"https://api.github.com/users/hapijs/followers","following_url":"https://api.github.com/users/hapijs/following{/other_user}","gists_url":"https://api.github.com/users/hapijs/gists{/gist_id}","starred_url":"https://api.github.com/users/hapijs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hapijs/subscriptions","organizations_url":"https://api.github.com/users/hapijs/orgs","repos_url":"https://api.github.com/users/hapijs/repos","events_url":"https://api.github.com/users/hapijs/events{/privacy}","received_events_url":"https://api.github.com/users/hapijs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hapijs/hapi","description":"Server Framework  for Node.js","fork":false,"url":"https://api.github.com/repos/hapijs/hapi","forks_url":"https://api.github.com/repos/hapijs/hapi/forks","keys_url":"https://api.github.com/repos/hapijs/hapi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hapijs/hapi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hapijs/hapi/teams","hooks_url":"https://api.github.com/repos/hapijs/hapi/hooks","issue_events_url":"https://api.github.com/repos/hapijs/hapi/issues/events{/number}","events_url":"https://api.github.com/repos/hapijs/hapi/events","assignees_url":"https://api.github.com/repos/hapijs/hapi/assignees{/user}","branches_url":"https://api.github.com/repos/hapijs/hapi/branches{/branch}","tags_url":"https://api.github.com/repos/hapijs/hapi/tags","blobs_url":"https://api.github.com/repos/hapijs/hapi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hapijs/hapi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hapijs/hapi/git/refs{/sha}","trees_url":"https://api.github.com/repos/hapijs/hapi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hapijs/hapi/statuses/{sha}","languages_url":"https://api.github.com/repos/hapijs/hapi/languages","stargazers_url":"https://api.github.com/repos/hapijs/hapi/stargazers","contributors_url":"https://api.github.com/repos/hapijs/hapi/contributors","subscribers_url":"https://api.github.com/repos/hapijs/hapi/subscribers","subscription_url":"https://api.github.com/repos/hapijs/hapi/subscription","commits_url":"https://api.github.com/repos/hapijs/hapi/commits{/sha}","git_commits_url":"https://api.github.com/repos/hapijs/hapi/git/commits{/sha}","comments_url":"https://api.github.com/repos/hapijs/hapi/comments{/number}","issue_comment_url":"https://api.github.com/repos/hapijs/hapi/issues/comments/{number}","contents_url":"https://api.github.com/repos/hapijs/hapi/contents/{+path}","compare_url":"https://api.github.com/repos/hapijs/hapi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hapijs/hapi/merges","archive_url":"https://api.github.com/repos/hapijs/hapi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hapijs/hapi/downloads","issues_url":"https://api.github.com/repos/hapijs/hapi/issues{/number}","pulls_url":"https://api.github.com/repos/hapijs/hapi/pulls{/number}","milestones_url":"https://api.github.com/repos/hapijs/hapi/milestones{/number}","notifications_url":"https://api.github.com/repos/hapijs/hapi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hapijs/hapi/labels{/name}","releases_url":"https://api.github.com/repos/hapijs/hapi/releases{/id}","created_at":"2011-08-06T00:35:39Z","updated_at":"2014-12-10T08:10:19Z","pushed_at":"2014-12-10T08:11:24Z","git_url":"git://github.com/hapijs/hapi.git","ssh_url":"git@github.com:hapijs/hapi.git","clone_url":"https://github.com/hapijs/hapi.git","svn_url":"https://github.com/hapijs/hapi","homepage":"hapijs.com","size":19140,"stargazers_count":3486,"watchers_count":3486,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":396,"mirror_url":null,"open_issues_count":1,"forks":396,"open_issues":1,"watchers":3486,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hapijs/hapi/pulls/2274"},"html":{"href":"https://github.com/hapijs/hapi/pull/2274"},"issue":{"href":"https://api.github.com/repos/hapijs/hapi/issues/2274"},"comments":{"href":"https://api.github.com/repos/hapijs/hapi/issues/2274/comments"},"review_comments":{"href":"https://api.github.com/repos/hapijs/hapi/pulls/2274/comments"},"review_comment":{"href":"https://api.github.com/repos/hapijs/hapi/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/hapijs/hapi/pulls/2274/commits"},"statuses":{"href":"https://api.github.com/repos/hapijs/hapi/statuses/2ee17ea20b5f3c0a62bda53f82b3faff1e86a60f"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"hueniverse","id":56631,"avatar_url":"https://avatars.githubusercontent.com/u/56631?v=3","gravatar_id":"","url":"https://api.github.com/users/hueniverse","html_url":"https://github.com/hueniverse","followers_url":"https://api.github.com/users/hueniverse/followers","following_url":"https://api.github.com/users/hueniverse/following{/other_user}","gists_url":"https://api.github.com/users/hueniverse/gists{/gist_id}","starred_url":"https://api.github.com/users/hueniverse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hueniverse/subscriptions","organizations_url":"https://api.github.com/users/hueniverse/orgs","repos_url":"https://api.github.com/users/hueniverse/repos","events_url":"https://api.github.com/users/hueniverse/events{/privacy}","received_events_url":"https://api.github.com/users/hueniverse/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":2,"deletions":2,"changed_files":1}}