GitHub PullRequestReviewCommentEvent at 2014-10-15 09:00:20
Repository: jquery-mobile
Actor: gabrielschulhof
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/jquery/jquery-mobile/pulls/comments/18881876","id":18881876,"diff_hunk":"@@ -298,11 +298,9 @@ $.widget( \"mobile.popup\", {\n \t\tif ( targetElement !== ui.container[ 0 ] ) {\n \t\t\ttarget = $( targetElement );\n \t\t\tif ( 0 === target.parents().filter( ui.container[ 0 ] ).length ) {\n-\t\t\t\t$( this.document[ 0 ].activeElement ).one( \"focus\", function(/* theEvent */) {\n-\t\t\t\t\tif ( targetElement.nodeName.toLowerCase() !== \"body\" ) {\n-\t\t\t\t            target.blur();\n-\t\t\t\t        }\n-\t\t\t\t});\n+\t\t\t\t$( this.document[ 0 ].activeElement ).one( \"focus\", $.proxy( function(/* theEvent */) {\n+\t\t\t\t\tthis._safelyBlur( this.document[ 0 ].activeElement );","path":"js/widgets/popup.js","position":10,"original_position":10,"commit_id":"cc548fd2aec257bd38a7556f7021dd05f6c7f2e6","original_commit_id":"cc548fd2aec257bd38a7556f7021dd05f6c7f2e6","user":{"login":"gabrielschulhof","id":976081,"avatar_url":"https://avatars.githubusercontent.com/u/976081?v=2","gravatar_id":"","url":"https://api.github.com/users/gabrielschulhof","html_url":"https://github.com/gabrielschulhof","followers_url":"https://api.github.com/users/gabrielschulhof/followers","following_url":"https://api.github.com/users/gabrielschulhof/following{/other_user}","gists_url":"https://api.github.com/users/gabrielschulhof/gists{/gist_id}","starred_url":"https://api.github.com/users/gabrielschulhof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabrielschulhof/subscriptions","organizations_url":"https://api.github.com/users/gabrielschulhof/orgs","repos_url":"https://api.github.com/users/gabrielschulhof/repos","events_url":"https://api.github.com/users/gabrielschulhof/events{/privacy}","received_events_url":"https://api.github.com/users/gabrielschulhof/received_events","type":"User","site_admin":false},"body":"Here we need to pass ```targetElement``` to ```_safelyBlur()```, not the active element, otherwise it breaks the focus chain.\r\n\r\nTry the markup from jsbin.com/huvoraba/170/edit with your local changes. When you open the popup, you will find that pressing Tab has no effect. If you focus the \"Login\" input, tabbing will work for one round, and then it will stop working.\r\n\r\nIf, OTOH, you make the above-mentioned change, tabbing will still not work initially, but once you focus the login input, the focus chain will be intact and you can tab as much as you want, and it will skip the input on the page.","created_at":"2014-10-15T09:00:20Z","updated_at":"2014-10-15T09:00:20Z","html_url":"https://github.com/jquery/jquery-mobile/pull/7757#discussion_r18881876","pull_request_url":"https://api.github.com/repos/jquery/jquery-mobile/pulls/7757","_links":{"self":{"href":"https://api.github.com/repos/jquery/jquery-mobile/pulls/comments/18881876"},"html":{"href":"https://github.com/jquery/jquery-mobile/pull/7757#discussion_r18881876"},"pull_request":{"href":"https://api.github.com/repos/jquery/jquery-mobile/pulls/7757"}}},"pull_request":{"url":"https://api.github.com/repos/jquery/jquery-mobile/pulls/7757","id":22375212,"html_url":"https://github.com/jquery/jquery-mobile/pull/7757","diff_url":"https://github.com/jquery/jquery-mobile/pull/7757.diff","patch_url":"https://github.com/jquery/jquery-mobile/pull/7757.patch","issue_url":"https://api.github.com/repos/jquery/jquery-mobile/issues/7757","number":7757,"state":"open","locked":false,"title":"Popup: blue focus flash on android 4.2","user":{"login":"ldeluca","id":4448698,"avatar_url":"https://avatars.githubusercontent.com/u/4448698?v=2","gravatar_id":"","url":"https://api.github.com/users/ldeluca","html_url":"https://github.com/ldeluca","followers_url":"https://api.github.com/users/ldeluca/followers","following_url":"https://api.github.com/users/ldeluca/following{/other_user}","gists_url":"https://api.github.com/users/ldeluca/gists{/gist_id}","starred_url":"https://api.github.com/users/ldeluca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldeluca/subscriptions","organizations_url":"https://api.github.com/users/ldeluca/orgs","repos_url":"https://api.github.com/users/ldeluca/repos","events_url":"https://api.github.com/users/ldeluca/events{/privacy}","received_events_url":"https://api.github.com/users/ldeluca/received_events","type":"User","site_admin":false},"body":"So I tested this with Browserstack on android 4.2 and it fixed the problem.  However, when I run \"grunt test\" there are a number of test cases failing.  @arschmitz suggested I do a pull request so he can take a look.  So don't merge if it's breaking tests! :)","created_at":"2014-10-07T18:56:57Z","updated_at":"2014-10-15T09:00:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d7f968831700b1e1aaa5b4a16702ff988cba63aa","assignee":{"login":"arschmitz","id":462993,"avatar_url":"https://avatars.githubusercontent.com/u/462993?v=2","gravatar_id":"","url":"https://api.github.com/users/arschmitz","html_url":"https://github.com/arschmitz","followers_url":"https://api.github.com/users/arschmitz/followers","following_url":"https://api.github.com/users/arschmitz/following{/other_user}","gists_url":"https://api.github.com/users/arschmitz/gists{/gist_id}","starred_url":"https://api.github.com/users/arschmitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arschmitz/subscriptions","organizations_url":"https://api.github.com/users/arschmitz/orgs","repos_url":"https://api.github.com/users/arschmitz/repos","events_url":"https://api.github.com/users/arschmitz/events{/privacy}","received_events_url":"https://api.github.com/users/arschmitz/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/jquery/jquery-mobile/milestones/32","labels_url":"https://api.github.com/repos/jquery/jquery-mobile/milestones/32/labels","id":796720,"number":32,"title":"1.4.5","description":"","creator":{"login":"jaspermdegroot","id":1296793,"avatar_url":"https://avatars.githubusercontent.com/u/1296793?v=2","gravatar_id":"","url":"https://api.github.com/users/jaspermdegroot","html_url":"https://github.com/jaspermdegroot","followers_url":"https://api.github.com/users/jaspermdegroot/followers","following_url":"https://api.github.com/users/jaspermdegroot/following{/other_user}","gists_url":"https://api.github.com/users/jaspermdegroot/gists{/gist_id}","starred_url":"https://api.github.com/users/jaspermdegroot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaspermdegroot/subscriptions","organizations_url":"https://api.github.com/users/jaspermdegroot/orgs","repos_url":"https://api.github.com/users/jaspermdegroot/repos","events_url":"https://api.github.com/users/jaspermdegroot/events{/privacy}","received_events_url":"https://api.github.com/users/jaspermdegroot/received_events","type":"User","site_admin":false},"open_issues":23,"closed_issues":2,"state":"open","created_at":"2014-09-20T12:15:25Z","updated_at":"2014-10-13T19:50:14Z","due_on":null},"commits_url":"https://api.github.com/repos/jquery/jquery-mobile/pulls/7757/commits","review_comments_url":"https://api.github.com/repos/jquery/jquery-mobile/pulls/7757/comments","review_comment_url":"https://api.github.com/repos/jquery/jquery-mobile/pulls/comments/{number}","comments_url":"https://api.github.com/repos/jquery/jquery-mobile/issues/7757/comments","statuses_url":"https://api.github.com/repos/jquery/jquery-mobile/statuses/cc548fd2aec257bd38a7556f7021dd05f6c7f2e6","head":{"label":"ldeluca:7533-popup-blue-flash","ref":"7533-popup-blue-flash","sha":"cc548fd2aec257bd38a7556f7021dd05f6c7f2e6","user":{"login":"ldeluca","id":4448698,"avatar_url":"https://avatars.githubusercontent.com/u/4448698?v=2","gravatar_id":"","url":"https://api.github.com/users/ldeluca","html_url":"https://github.com/ldeluca","followers_url":"https://api.github.com/users/ldeluca/followers","following_url":"https://api.github.com/users/ldeluca/following{/other_user}","gists_url":"https://api.github.com/users/ldeluca/gists{/gist_id}","starred_url":"https://api.github.com/users/ldeluca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldeluca/subscriptions","organizations_url":"https://api.github.com/users/ldeluca/orgs","repos_url":"https://api.github.com/users/ldeluca/repos","events_url":"https://api.github.com/users/ldeluca/events{/privacy}","received_events_url":"https://api.github.com/users/ldeluca/received_events","type":"User","site_admin":false},"repo":{"id":24099174,"name":"jquery-mobile","full_name":"ldeluca/jquery-mobile","owner":{"login":"ldeluca","id":4448698,"avatar_url":"https://avatars.githubusercontent.com/u/4448698?v=2","gravatar_id":"","url":"https://api.github.com/users/ldeluca","html_url":"https://github.com/ldeluca","followers_url":"https://api.github.com/users/ldeluca/followers","following_url":"https://api.github.com/users/ldeluca/following{/other_user}","gists_url":"https://api.github.com/users/ldeluca/gists{/gist_id}","starred_url":"https://api.github.com/users/ldeluca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldeluca/subscriptions","organizations_url":"https://api.github.com/users/ldeluca/orgs","repos_url":"https://api.github.com/users/ldeluca/repos","events_url":"https://api.github.com/users/ldeluca/events{/privacy}","received_events_url":"https://api.github.com/users/ldeluca/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ldeluca/jquery-mobile","description":"jQuery Mobile Framework","fork":true,"url":"https://api.github.com/repos/ldeluca/jquery-mobile","forks_url":"https://api.github.com/repos/ldeluca/jquery-mobile/forks","keys_url":"https://api.github.com/repos/ldeluca/jquery-mobile/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ldeluca/jquery-mobile/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ldeluca/jquery-mobile/teams","hooks_url":"https://api.github.com/repos/ldeluca/jquery-mobile/hooks","issue_events_url":"https://api.github.com/repos/ldeluca/jquery-mobile/issues/events{/number}","events_url":"https://api.github.com/repos/ldeluca/jquery-mobile/events","assignees_url":"https://api.github.com/repos/ldeluca/jquery-mobile/assignees{/user}","branches_url":"https://api.github.com/repos/ldeluca/jquery-mobile/branches{/branch}","tags_url":"https://api.github.com/repos/ldeluca/jquery-mobile/tags","blobs_url":"https://api.github.com/repos/ldeluca/jquery-mobile/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ldeluca/jquery-mobile/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ldeluca/jquery-mobile/git/refs{/sha}","trees_url":"https://api.github.com/repos/ldeluca/jquery-mobile/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ldeluca/jquery-mobile/statuses/{sha}","languages_url":"https://api.github.com/repos/ldeluca/jquery-mobile/languages","stargazers_url":"https://api.github.com/repos/ldeluca/jquery-mobile/stargazers","contributors_url":"https://api.github.com/repos/ldeluca/jquery-mobile/contributors","subscribers_url":"https://api.github.com/repos/ldeluca/jquery-mobile/subscribers","subscription_url":"https://api.github.com/repos/ldeluca/jquery-mobile/subscription","commits_url":"https://api.github.com/repos/ldeluca/jquery-mobile/commits{/sha}","git_commits_url":"https://api.github.com/repos/ldeluca/jquery-mobile/git/commits{/sha}","comments_url":"https://api.github.com/repos/ldeluca/jquery-mobile/comments{/number}","issue_comment_url":"https://api.github.com/repos/ldeluca/jquery-mobile/issues/comments/{number}","contents_url":"https://api.github.com/repos/ldeluca/jquery-mobile/contents/{+path}","compare_url":"https://api.github.com/repos/ldeluca/jquery-mobile/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ldeluca/jquery-mobile/merges","archive_url":"https://api.github.com/repos/ldeluca/jquery-mobile/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ldeluca/jquery-mobile/downloads","issues_url":"https://api.github.com/repos/ldeluca/jquery-mobile/issues{/number}","pulls_url":"https://api.github.com/repos/ldeluca/jquery-mobile/pulls{/number}","milestones_url":"https://api.github.com/repos/ldeluca/jquery-mobile/milestones{/number}","notifications_url":"https://api.github.com/repos/ldeluca/jquery-mobile/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ldeluca/jquery-mobile/labels{/name}","releases_url":"https://api.github.com/repos/ldeluca/jquery-mobile/releases{/id}","created_at":"2014-09-16T12:50:21Z","updated_at":"2014-09-16T12:50:15Z","pushed_at":"2014-10-14T18:43:51Z","git_url":"git://github.com/ldeluca/jquery-mobile.git","ssh_url":"git@github.com:ldeluca/jquery-mobile.git","clone_url":"https://github.com/ldeluca/jquery-mobile.git","svn_url":"https://github.com/ldeluca/jquery-mobile","homepage":"http://jquerymobile.com/","size":131518,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jquery:master","ref":"master","sha":"c7cad3d7bf59893932ca5a48a4fa81ae80d1916b","user":{"login":"jquery","id":70142,"avatar_url":"https://avatars.githubusercontent.com/u/70142?v=2","gravatar_id":"","url":"https://api.github.com/users/jquery","html_url":"https://github.com/jquery","followers_url":"https://api.github.com/users/jquery/followers","following_url":"https://api.github.com/users/jquery/following{/other_user}","gists_url":"https://api.github.com/users/jquery/gists{/gist_id}","starred_url":"https://api.github.com/users/jquery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jquery/subscriptions","organizations_url":"https://api.github.com/users/jquery/orgs","repos_url":"https://api.github.com/users/jquery/repos","events_url":"https://api.github.com/users/jquery/events{/privacy}","received_events_url":"https://api.github.com/users/jquery/received_events","type":"Organization","site_admin":false},"repo":{"id":907410,"name":"jquery-mobile","full_name":"jquery/jquery-mobile","owner":{"login":"jquery","id":70142,"avatar_url":"https://avatars.githubusercontent.com/u/70142?v=2","gravatar_id":"","url":"https://api.github.com/users/jquery","html_url":"https://github.com/jquery","followers_url":"https://api.github.com/users/jquery/followers","following_url":"https://api.github.com/users/jquery/following{/other_user}","gists_url":"https://api.github.com/users/jquery/gists{/gist_id}","starred_url":"https://api.github.com/users/jquery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jquery/subscriptions","organizations_url":"https://api.github.com/users/jquery/orgs","repos_url":"https://api.github.com/users/jquery/repos","events_url":"https://api.github.com/users/jquery/events{/privacy}","received_events_url":"https://api.github.com/users/jquery/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jquery/jquery-mobile","description":"jQuery Mobile Framework","fork":false,"url":"https://api.github.com/repos/jquery/jquery-mobile","forks_url":"https://api.github.com/repos/jquery/jquery-mobile/forks","keys_url":"https://api.github.com/repos/jquery/jquery-mobile/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jquery/jquery-mobile/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jquery/jquery-mobile/teams","hooks_url":"https://api.github.com/repos/jquery/jquery-mobile/hooks","issue_events_url":"https://api.github.com/repos/jquery/jquery-mobile/issues/events{/number}","events_url":"https://api.github.com/repos/jquery/jquery-mobile/events","assignees_url":"https://api.github.com/repos/jquery/jquery-mobile/assignees{/user}","branches_url":"https://api.github.com/repos/jquery/jquery-mobile/branches{/branch}","tags_url":"https://api.github.com/repos/jquery/jquery-mobile/tags","blobs_url":"https://api.github.com/repos/jquery/jquery-mobile/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jquery/jquery-mobile/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jquery/jquery-mobile/git/refs{/sha}","trees_url":"https://api.github.com/repos/jquery/jquery-mobile/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jquery/jquery-mobile/statuses/{sha}","languages_url":"https://api.github.com/repos/jquery/jquery-mobile/languages","stargazers_url":"https://api.github.com/repos/jquery/jquery-mobile/stargazers","contributors_url":"https://api.github.com/repos/jquery/jquery-mobile/contributors","subscribers_url":"https://api.github.com/repos/jquery/jquery-mobile/subscribers","subscription_url":"https://api.github.com/repos/jquery/jquery-mobile/subscription","commits_url":"https://api.github.com/repos/jquery/jquery-mobile/commits{/sha}","git_commits_url":"https://api.github.com/repos/jquery/jquery-mobile/git/commits{/sha}","comments_url":"https://api.github.com/repos/jquery/jquery-mobile/comments{/number}","issue_comment_url":"https://api.github.com/repos/jquery/jquery-mobile/issues/comments/{number}","contents_url":"https://api.github.com/repos/jquery/jquery-mobile/contents/{+path}","compare_url":"https://api.github.com/repos/jquery/jquery-mobile/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jquery/jquery-mobile/merges","archive_url":"https://api.github.com/repos/jquery/jquery-mobile/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jquery/jquery-mobile/downloads","issues_url":"https://api.github.com/repos/jquery/jquery-mobile/issues{/number}","pulls_url":"https://api.github.com/repos/jquery/jquery-mobile/pulls{/number}","milestones_url":"https://api.github.com/repos/jquery/jquery-mobile/milestones{/number}","notifications_url":"https://api.github.com/repos/jquery/jquery-mobile/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jquery/jquery-mobile/labels{/name}","releases_url":"https://api.github.com/repos/jquery/jquery-mobile/releases{/id}","created_at":"2010-09-13T15:02:22Z","updated_at":"2014-10-15T02:33:08Z","pushed_at":"2014-10-13T20:53:52Z","git_url":"git://github.com/jquery/jquery-mobile.git","ssh_url":"git@github.com:jquery/jquery-mobile.git","clone_url":"https://github.com/jquery/jquery-mobile.git","svn_url":"https://github.com/jquery/jquery-mobile","homepage":"http://jquerymobile.com/","size":192675,"stargazers_count":9262,"watchers_count":9262,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2443,"mirror_url":null,"open_issues_count":452,"forks":2443,"open_issues":452,"watchers":9262,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jquery/jquery-mobile/pulls/7757"},"html":{"href":"https://github.com/jquery/jquery-mobile/pull/7757"},"issue":{"href":"https://api.github.com/repos/jquery/jquery-mobile/issues/7757"},"comments":{"href":"https://api.github.com/repos/jquery/jquery-mobile/issues/7757/comments"},"review_comments":{"href":"https://api.github.com/repos/jquery/jquery-mobile/pulls/7757/comments"},"review_comment":{"href":"https://api.github.com/repos/jquery/jquery-mobile/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/jquery/jquery-mobile/pulls/7757/commits"},"statuses":{"href":"https://api.github.com/repos/jquery/jquery-mobile/statuses/cc548fd2aec257bd38a7556f7021dd05f6c7f2e6"}}}}