GitHub PullRequestReviewCommentEvent at 2014-05-10 23:16:11
Repository: curator
Actor: eceejcr
Payload: {"comment":{"url":"https://api.github.com/repos/apache/curator/pulls/comments/12506742","id":12506742,"diff_hunk":"@@ -72,6 +74,9 @@\n     private final NamespaceWatcherMap                                   namespaceWatcherMap = new NamespaceWatcherMap(this);\n \n     private volatile ExecutorService                                    executorService;\n+    private final AtomicBoolean                                         logAsErrorConnectionErrors = new AtomicBoolean(false);\n+\n+    private static final boolean                                        LOG_ALL_CONNECTION_ISSUES_AS_ERROR_LEVEL = Boolean.getBoolean(DebugUtils.PROPERTY_LOG_ALL_CONNECTION_ISSUES_AS_ERROR_LEVEL);","path":"curator-framework/src/main/java/org/apache/curator/framework/imps/CuratorFrameworkImpl.java","position":19,"original_position":19,"commit_id":"abe07d4b1190f70ac3f171fd897400c77d0d0de5","original_commit_id":"abe07d4b1190f70ac3f171fd897400c77d0d0de5","user":{"login":"eceejcr","id":3510476,"avatar_url":"https://avatars.githubusercontent.com/u/3510476?","gravatar_id":"9a23f4b3fbafeb6a594c6bbfc207ee86","url":"https://api.github.com/users/eceejcr","html_url":"https://github.com/eceejcr","followers_url":"https://api.github.com/users/eceejcr/followers","following_url":"https://api.github.com/users/eceejcr/following{/other_user}","gists_url":"https://api.github.com/users/eceejcr/gists{/gist_id}","starred_url":"https://api.github.com/users/eceejcr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eceejcr/subscriptions","organizations_url":"https://api.github.com/users/eceejcr/orgs","repos_url":"https://api.github.com/users/eceejcr/repos","events_url":"https://api.github.com/users/eceejcr/events{/privacy}","received_events_url":"https://api.github.com/users/eceejcr/received_events","type":"User","site_admin":false},"body":"Jordan I created it as a constant, but I am not sure if you were thinking to manipulate the property with code and therefore you prefer a more dynamic approach. Anyway looks simple the change. Let me know","created_at":"2014-05-10T23:16:11Z","updated_at":"2014-05-10T23:16:11Z","html_url":"https://github.com/apache/curator/pull/6#discussion_r12506742","pull_request_url":"https://api.github.com/repos/apache/curator/pulls/6","_links":{"self":{"href":"https://api.github.com/repos/apache/curator/pulls/comments/12506742"},"html":{"href":"https://github.com/apache/curator/pull/6#discussion_r12506742"},"pull_request":{"href":"https://api.github.com/repos/apache/curator/pulls/6"}}}}