GitHub PullRequestReviewCommentEvent at 2014-08-05 16:55:12
Repository: mps-encore
Actor: mikeymurph77
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/aslawter/mps-encore/pulls/comments/15825581","id":15825581,"diff_hunk":"@@ -0,0 +1,5 @@\n+class DashboardsController < ApplicationController\n+  def show\n+    @users = User.where(active: false).order(created_at: :desc)","path":"app/controllers/dashboards_controller.rb","position":3,"original_position":3,"commit_id":"470ed9dae6c064b0f3684b10eeb71e9abe045bf3","original_commit_id":"470ed9dae6c064b0f3684b10eeb71e9abe045bf3","user":{"login":"mikeymurph77","id":6640176,"avatar_url":"https://avatars.githubusercontent.com/u/6640176?v=2","gravatar_id":"8c27ce0a109e55da3c741b34781d03f6","url":"https://api.github.com/users/mikeymurph77","html_url":"https://github.com/mikeymurph77","followers_url":"https://api.github.com/users/mikeymurph77/followers","following_url":"https://api.github.com/users/mikeymurph77/following{/other_user}","gists_url":"https://api.github.com/users/mikeymurph77/gists{/gist_id}","starred_url":"https://api.github.com/users/mikeymurph77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikeymurph77/subscriptions","organizations_url":"https://api.github.com/users/mikeymurph77/orgs","repos_url":"https://api.github.com/users/mikeymurph77/repos","events_url":"https://api.github.com/users/mikeymurph77/events{/privacy}","received_events_url":"https://api.github.com/users/mikeymurph77/received_events","type":"User","site_admin":false},"body":"For readability purposes ```order(created_at: :desc)``` can be defined in the user model defined as ``newest_first``` . That way the code can read ```User.where(active: false).newest_first```. ","created_at":"2014-08-05T16:55:12Z","updated_at":"2014-08-05T16:55:12Z","html_url":"https://github.com/aslawter/mps-encore/pull/2#discussion_r15825581","pull_request_url":"https://api.github.com/repos/aslawter/mps-encore/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/aslawter/mps-encore/pulls/comments/15825581"},"html":{"href":"https://github.com/aslawter/mps-encore/pull/2#discussion_r15825581"},"pull_request":{"href":"https://api.github.com/repos/aslawter/mps-encore/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/aslawter/mps-encore/pulls/2","id":19354064,"html_url":"https://github.com/aslawter/mps-encore/pull/2","diff_url":"https://github.com/aslawter/mps-encore/pull/2.diff","patch_url":"https://github.com/aslawter/mps-encore/pull/2.patch","issue_url":"https://api.github.com/repos/aslawter/mps-encore/issues/2","number":2,"state":"open","title":"Admin can create customers, and can approve/reject site access.","user":{"login":"aslawter","id":7561560,"avatar_url":"https://avatars.githubusercontent.com/u/7561560?v=2","gravatar_id":"316a5e34cd1ef61d1f68b739997ae0ac","url":"https://api.github.com/users/aslawter","html_url":"https://github.com/aslawter","followers_url":"https://api.github.com/users/aslawter/followers","following_url":"https://api.github.com/users/aslawter/following{/other_user}","gists_url":"https://api.github.com/users/aslawter/gists{/gist_id}","starred_url":"https://api.github.com/users/aslawter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aslawter/subscriptions","organizations_url":"https://api.github.com/users/aslawter/orgs","repos_url":"https://api.github.com/users/aslawter/repos","events_url":"https://api.github.com/users/aslawter/events{/privacy}","received_events_url":"https://api.github.com/users/aslawter/received_events","type":"User","site_admin":false},"body":"@mikeymurph77, @amZotti - please have a look see.","created_at":"2014-08-05T16:46:13Z","updated_at":"2014-08-05T16:55:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/aslawter/mps-encore/pulls/2/commits","review_comments_url":"https://api.github.com/repos/aslawter/mps-encore/pulls/2/comments","review_comment_url":"https://api.github.com/repos/aslawter/mps-encore/pulls/comments/{number}","comments_url":"https://api.github.com/repos/aslawter/mps-encore/issues/2/comments","statuses_url":"https://api.github.com/repos/aslawter/mps-encore/statuses/470ed9dae6c064b0f3684b10eeb71e9abe045bf3","head":{"label":"aslawter:abs-create-customers","ref":"abs-create-customers","sha":"470ed9dae6c064b0f3684b10eeb71e9abe045bf3","user":{"login":"aslawter","id":7561560,"avatar_url":"https://avatars.githubusercontent.com/u/7561560?v=2","gravatar_id":"316a5e34cd1ef61d1f68b739997ae0ac","url":"https://api.github.com/users/aslawter","html_url":"https://github.com/aslawter","followers_url":"https://api.github.com/users/aslawter/followers","following_url":"https://api.github.com/users/aslawter/following{/other_user}","gists_url":"https://api.github.com/users/aslawter/gists{/gist_id}","starred_url":"https://api.github.com/users/aslawter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aslawter/subscriptions","organizations_url":"https://api.github.com/users/aslawter/orgs","repos_url":"https://api.github.com/users/aslawter/repos","events_url":"https://api.github.com/users/aslawter/events{/privacy}","received_events_url":"https://api.github.com/users/aslawter/received_events","type":"User","site_admin":false},"repo":{"id":22607699,"name":"mps-encore","full_name":"aslawter/mps-encore","owner":{"login":"aslawter","id":7561560,"avatar_url":"https://avatars.githubusercontent.com/u/7561560?v=2","gravatar_id":"316a5e34cd1ef61d1f68b739997ae0ac","url":"https://api.github.com/users/aslawter","html_url":"https://github.com/aslawter","followers_url":"https://api.github.com/users/aslawter/followers","following_url":"https://api.github.com/users/aslawter/following{/other_user}","gists_url":"https://api.github.com/users/aslawter/gists{/gist_id}","starred_url":"https://api.github.com/users/aslawter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aslawter/subscriptions","organizations_url":"https://api.github.com/users/aslawter/orgs","repos_url":"https://api.github.com/users/aslawter/repos","events_url":"https://api.github.com/users/aslawter/events{/privacy}","received_events_url":"https://api.github.com/users/aslawter/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aslawter/mps-encore","description":"Manage, track, and tweak your corporate resume for your next bid and proposal performance.","fork":false,"url":"https://api.github.com/repos/aslawter/mps-encore","forks_url":"https://api.github.com/repos/aslawter/mps-encore/forks","keys_url":"https://api.github.com/repos/aslawter/mps-encore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aslawter/mps-encore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aslawter/mps-encore/teams","hooks_url":"https://api.github.com/repos/aslawter/mps-encore/hooks","issue_events_url":"https://api.github.com/repos/aslawter/mps-encore/issues/events{/number}","events_url":"https://api.github.com/repos/aslawter/mps-encore/events","assignees_url":"https://api.github.com/repos/aslawter/mps-encore/assignees{/user}","branches_url":"https://api.github.com/repos/aslawter/mps-encore/branches{/branch}","tags_url":"https://api.github.com/repos/aslawter/mps-encore/tags","blobs_url":"https://api.github.com/repos/aslawter/mps-encore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aslawter/mps-encore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aslawter/mps-encore/git/refs{/sha}","trees_url":"https://api.github.com/repos/aslawter/mps-encore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aslawter/mps-encore/statuses/{sha}","languages_url":"https://api.github.com/repos/aslawter/mps-encore/languages","stargazers_url":"https://api.github.com/repos/aslawter/mps-encore/stargazers","contributors_url":"https://api.github.com/repos/aslawter/mps-encore/contributors","subscribers_url":"https://api.github.com/repos/aslawter/mps-encore/subscribers","subscription_url":"https://api.github.com/repos/aslawter/mps-encore/subscription","commits_url":"https://api.github.com/repos/aslawter/mps-encore/commits{/sha}","git_commits_url":"https://api.github.com/repos/aslawter/mps-encore/git/commits{/sha}","comments_url":"https://api.github.com/repos/aslawter/mps-encore/comments{/number}","issue_comment_url":"https://api.github.com/repos/aslawter/mps-encore/issues/comments/{number}","contents_url":"https://api.github.com/repos/aslawter/mps-encore/contents/{+path}","compare_url":"https://api.github.com/repos/aslawter/mps-encore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aslawter/mps-encore/merges","archive_url":"https://api.github.com/repos/aslawter/mps-encore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aslawter/mps-encore/downloads","issues_url":"https://api.github.com/repos/aslawter/mps-encore/issues{/number}","pulls_url":"https://api.github.com/repos/aslawter/mps-encore/pulls{/number}","milestones_url":"https://api.github.com/repos/aslawter/mps-encore/milestones{/number}","notifications_url":"https://api.github.com/repos/aslawter/mps-encore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aslawter/mps-encore/labels{/name}","releases_url":"https://api.github.com/repos/aslawter/mps-encore/releases{/id}","created_at":"2014-08-04T14:43:49Z","updated_at":"2014-08-04T15:07:13Z","pushed_at":"2014-08-05T16:42:15Z","git_url":"git://github.com/aslawter/mps-encore.git","ssh_url":"git@github.com:aslawter/mps-encore.git","clone_url":"https://github.com/aslawter/mps-encore.git","svn_url":"https://github.com/aslawter/mps-encore","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"aslawter:master","ref":"master","sha":"7637f0ac9e7535b159b55fdb98439ddd88864bcd","user":{"login":"aslawter","id":7561560,"avatar_url":"https://avatars.githubusercontent.com/u/7561560?v=2","gravatar_id":"316a5e34cd1ef61d1f68b739997ae0ac","url":"https://api.github.com/users/aslawter","html_url":"https://github.com/aslawter","followers_url":"https://api.github.com/users/aslawter/followers","following_url":"https://api.github.com/users/aslawter/following{/other_user}","gists_url":"https://api.github.com/users/aslawter/gists{/gist_id}","starred_url":"https://api.github.com/users/aslawter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aslawter/subscriptions","organizations_url":"https://api.github.com/users/aslawter/orgs","repos_url":"https://api.github.com/users/aslawter/repos","events_url":"https://api.github.com/users/aslawter/events{/privacy}","received_events_url":"https://api.github.com/users/aslawter/received_events","type":"User","site_admin":false},"repo":{"id":22607699,"name":"mps-encore","full_name":"aslawter/mps-encore","owner":{"login":"aslawter","id":7561560,"avatar_url":"https://avatars.githubusercontent.com/u/7561560?v=2","gravatar_id":"316a5e34cd1ef61d1f68b739997ae0ac","url":"https://api.github.com/users/aslawter","html_url":"https://github.com/aslawter","followers_url":"https://api.github.com/users/aslawter/followers","following_url":"https://api.github.com/users/aslawter/following{/other_user}","gists_url":"https://api.github.com/users/aslawter/gists{/gist_id}","starred_url":"https://api.github.com/users/aslawter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aslawter/subscriptions","organizations_url":"https://api.github.com/users/aslawter/orgs","repos_url":"https://api.github.com/users/aslawter/repos","events_url":"https://api.github.com/users/aslawter/events{/privacy}","received_events_url":"https://api.github.com/users/aslawter/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aslawter/mps-encore","description":"Manage, track, and tweak your corporate resume for your next bid and proposal performance.","fork":false,"url":"https://api.github.com/repos/aslawter/mps-encore","forks_url":"https://api.github.com/repos/aslawter/mps-encore/forks","keys_url":"https://api.github.com/repos/aslawter/mps-encore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aslawter/mps-encore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aslawter/mps-encore/teams","hooks_url":"https://api.github.com/repos/aslawter/mps-encore/hooks","issue_events_url":"https://api.github.com/repos/aslawter/mps-encore/issues/events{/number}","events_url":"https://api.github.com/repos/aslawter/mps-encore/events","assignees_url":"https://api.github.com/repos/aslawter/mps-encore/assignees{/user}","branches_url":"https://api.github.com/repos/aslawter/mps-encore/branches{/branch}","tags_url":"https://api.github.com/repos/aslawter/mps-encore/tags","blobs_url":"https://api.github.com/repos/aslawter/mps-encore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aslawter/mps-encore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aslawter/mps-encore/git/refs{/sha}","trees_url":"https://api.github.com/repos/aslawter/mps-encore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aslawter/mps-encore/statuses/{sha}","languages_url":"https://api.github.com/repos/aslawter/mps-encore/languages","stargazers_url":"https://api.github.com/repos/aslawter/mps-encore/stargazers","contributors_url":"https://api.github.com/repos/aslawter/mps-encore/contributors","subscribers_url":"https://api.github.com/repos/aslawter/mps-encore/subscribers","subscription_url":"https://api.github.com/repos/aslawter/mps-encore/subscription","commits_url":"https://api.github.com/repos/aslawter/mps-encore/commits{/sha}","git_commits_url":"https://api.github.com/repos/aslawter/mps-encore/git/commits{/sha}","comments_url":"https://api.github.com/repos/aslawter/mps-encore/comments{/number}","issue_comment_url":"https://api.github.com/repos/aslawter/mps-encore/issues/comments/{number}","contents_url":"https://api.github.com/repos/aslawter/mps-encore/contents/{+path}","compare_url":"https://api.github.com/repos/aslawter/mps-encore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aslawter/mps-encore/merges","archive_url":"https://api.github.com/repos/aslawter/mps-encore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aslawter/mps-encore/downloads","issues_url":"https://api.github.com/repos/aslawter/mps-encore/issues{/number}","pulls_url":"https://api.github.com/repos/aslawter/mps-encore/pulls{/number}","milestones_url":"https://api.github.com/repos/aslawter/mps-encore/milestones{/number}","notifications_url":"https://api.github.com/repos/aslawter/mps-encore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aslawter/mps-encore/labels{/name}","releases_url":"https://api.github.com/repos/aslawter/mps-encore/releases{/id}","created_at":"2014-08-04T14:43:49Z","updated_at":"2014-08-04T15:07:13Z","pushed_at":"2014-08-05T16:42:15Z","git_url":"git://github.com/aslawter/mps-encore.git","ssh_url":"git@github.com:aslawter/mps-encore.git","clone_url":"https://github.com/aslawter/mps-encore.git","svn_url":"https://github.com/aslawter/mps-encore","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aslawter/mps-encore/pulls/2"},"html":{"href":"https://github.com/aslawter/mps-encore/pull/2"},"issue":{"href":"https://api.github.com/repos/aslawter/mps-encore/issues/2"},"comments":{"href":"https://api.github.com/repos/aslawter/mps-encore/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/aslawter/mps-encore/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/aslawter/mps-encore/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/aslawter/mps-encore/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/aslawter/mps-encore/statuses/470ed9dae6c064b0f3684b10eeb71e9abe045bf3"}}}}