GitHub PullRequestReviewCommentEvent at 2014-09-03 18:34:10
Repository: kc
Actor: leoherbie
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/kuali/kc/pulls/comments/17070160","id":17070160,"diff_hunk":"@@ -15,9 +15,11 @@\n  */\n package org.kuali.coeus.common.budget.framework.personnel;\n \n+import org.kuali.coeus.common.budget.api.personnel.BudgetPersonContract;\n import org.kuali.coeus.common.budget.api.personnel.BudgetPersonnelDetailsContract;\n import org.kuali.coeus.common.budget.framework.core.Budget;\n import org.kuali.coeus.propdev.api.person.ProposalPersonContract;\n+import org.kuali.coeus.propdev.impl.person.ProposalPerson;","path":"coeus-impl/src/main/java/org/kuali/coeus/common/budget/framework/personnel/BudgetPersonService.java","position":8,"original_position":8,"commit_id":"f26f6f4cc5942d0e271908a144cfe2c5d885574d","original_commit_id":"f26f6f4cc5942d0e271908a144cfe2c5d885574d","user":{"login":"leoherbie","id":188602,"avatar_url":"https://avatars.githubusercontent.com/u/188602?v=2","gravatar_id":"73607818dbb47aea2b3f9a925084a3a7","url":"https://api.github.com/users/leoherbie","html_url":"https://github.com/leoherbie","followers_url":"https://api.github.com/users/leoherbie/followers","following_url":"https://api.github.com/users/leoherbie/following{/other_user}","gists_url":"https://api.github.com/users/leoherbie/gists{/gist_id}","starred_url":"https://api.github.com/users/leoherbie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leoherbie/subscriptions","organizations_url":"https://api.github.com/users/leoherbie/orgs","repos_url":"https://api.github.com/users/leoherbie/repos","events_url":"https://api.github.com/users/leoherbie/events{/privacy}","received_events_url":"https://api.github.com/users/leoherbie/received_events","type":"User","site_admin":false},"body":"I don't think that the generic BudgetPersonService should depend on ProposalPerson.","created_at":"2014-09-03T18:34:10Z","updated_at":"2014-09-03T18:34:10Z","html_url":"https://github.com/kuali/kc/pull/671#discussion_r17070160","pull_request_url":"https://api.github.com/repos/kuali/kc/pulls/671","_links":{"self":{"href":"https://api.github.com/repos/kuali/kc/pulls/comments/17070160"},"html":{"href":"https://github.com/kuali/kc/pull/671#discussion_r17070160"},"pull_request":{"href":"https://api.github.com/repos/kuali/kc/pulls/671"}}},"pull_request":{"url":"https://api.github.com/repos/kuali/kc/pulls/671","id":20685304,"html_url":"https://github.com/kuali/kc/pull/671","diff_url":"https://github.com/kuali/kc/pull/671.diff","patch_url":"https://github.com/kuali/kc/pull/671.patch","issue_url":"https://api.github.com/repos/kuali/kc/issues/671","number":671,"state":"open","locked":false,"title":"KRACOEUS-7644","user":{"login":"rmancher","id":6453012,"avatar_url":"https://avatars.githubusercontent.com/u/6453012?v=2","gravatar_id":"2e1ab565ebe54c7de7815f994bf4f233","url":"https://api.github.com/users/rmancher","html_url":"https://github.com/rmancher","followers_url":"https://api.github.com/users/rmancher/followers","following_url":"https://api.github.com/users/rmancher/following{/other_user}","gists_url":"https://api.github.com/users/rmancher/gists{/gist_id}","starred_url":"https://api.github.com/users/rmancher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmancher/subscriptions","organizations_url":"https://api.github.com/users/rmancher/orgs","repos_url":"https://api.github.com/users/rmancher/repos","events_url":"https://api.github.com/users/rmancher/events{/privacy}","received_events_url":"https://api.github.com/users/rmancher/received_events","type":"User","site_admin":false},"body":"KRACOEUS-7644\r\nModified search result columns as per JIRA comments. Since the search criteria and results are common for PD and Budget made changes to common search.\r\n\r\nKRACOEUS-7643\r\nFormat budget personnel list\r\nThere is an issue with progressiveRenderAndRefresh in dialog. Created a JIRA.\r\n","created_at":"2014-09-03T15:38:53Z","updated_at":"2014-09-03T18:34:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"38acaf7bfcf5aa5547f3bac0c91c05881123ae47","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/kuali/kc/pulls/671/commits","review_comments_url":"https://api.github.com/repos/kuali/kc/pulls/671/comments","review_comment_url":"https://api.github.com/repos/kuali/kc/pulls/comments/{number}","comments_url":"https://api.github.com/repos/kuali/kc/issues/671/comments","statuses_url":"https://api.github.com/repos/kuali/kc/statuses/f26f6f4cc5942d0e271908a144cfe2c5d885574d","head":{"label":"rmancher:budget-project-personnel-update","ref":"budget-project-personnel-update","sha":"f26f6f4cc5942d0e271908a144cfe2c5d885574d","user":{"login":"rmancher","id":6453012,"avatar_url":"https://avatars.githubusercontent.com/u/6453012?v=2","gravatar_id":"2e1ab565ebe54c7de7815f994bf4f233","url":"https://api.github.com/users/rmancher","html_url":"https://github.com/rmancher","followers_url":"https://api.github.com/users/rmancher/followers","following_url":"https://api.github.com/users/rmancher/following{/other_user}","gists_url":"https://api.github.com/users/rmancher/gists{/gist_id}","starred_url":"https://api.github.com/users/rmancher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmancher/subscriptions","organizations_url":"https://api.github.com/users/rmancher/orgs","repos_url":"https://api.github.com/users/rmancher/repos","events_url":"https://api.github.com/users/rmancher/events{/privacy}","received_events_url":"https://api.github.com/users/rmancher/received_events","type":"User","site_admin":false},"repo":{"id":16319292,"name":"kc","full_name":"rmancher/kc","owner":{"login":"rmancher","id":6453012,"avatar_url":"https://avatars.githubusercontent.com/u/6453012?v=2","gravatar_id":"2e1ab565ebe54c7de7815f994bf4f233","url":"https://api.github.com/users/rmancher","html_url":"https://github.com/rmancher","followers_url":"https://api.github.com/users/rmancher/followers","following_url":"https://api.github.com/users/rmancher/following{/other_user}","gists_url":"https://api.github.com/users/rmancher/gists{/gist_id}","starred_url":"https://api.github.com/users/rmancher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmancher/subscriptions","organizations_url":"https://api.github.com/users/rmancher/orgs","repos_url":"https://api.github.com/users/rmancher/repos","events_url":"https://api.github.com/users/rmancher/events{/privacy}","received_events_url":"https://api.github.com/users/rmancher/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rmancher/kc","description":"Kuali Coeus","fork":true,"url":"https://api.github.com/repos/rmancher/kc","forks_url":"https://api.github.com/repos/rmancher/kc/forks","keys_url":"https://api.github.com/repos/rmancher/kc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rmancher/kc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rmancher/kc/teams","hooks_url":"https://api.github.com/repos/rmancher/kc/hooks","issue_events_url":"https://api.github.com/repos/rmancher/kc/issues/events{/number}","events_url":"https://api.github.com/repos/rmancher/kc/events","assignees_url":"https://api.github.com/repos/rmancher/kc/assignees{/user}","branches_url":"https://api.github.com/repos/rmancher/kc/branches{/branch}","tags_url":"https://api.github.com/repos/rmancher/kc/tags","blobs_url":"https://api.github.com/repos/rmancher/kc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rmancher/kc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rmancher/kc/git/refs{/sha}","trees_url":"https://api.github.com/repos/rmancher/kc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rmancher/kc/statuses/{sha}","languages_url":"https://api.github.com/repos/rmancher/kc/languages","stargazers_url":"https://api.github.com/repos/rmancher/kc/stargazers","contributors_url":"https://api.github.com/repos/rmancher/kc/contributors","subscribers_url":"https://api.github.com/repos/rmancher/kc/subscribers","subscription_url":"https://api.github.com/repos/rmancher/kc/subscription","commits_url":"https://api.github.com/repos/rmancher/kc/commits{/sha}","git_commits_url":"https://api.github.com/repos/rmancher/kc/git/commits{/sha}","comments_url":"https://api.github.com/repos/rmancher/kc/comments{/number}","issue_comment_url":"https://api.github.com/repos/rmancher/kc/issues/comments/{number}","contents_url":"https://api.github.com/repos/rmancher/kc/contents/{+path}","compare_url":"https://api.github.com/repos/rmancher/kc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rmancher/kc/merges","archive_url":"https://api.github.com/repos/rmancher/kc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rmancher/kc/downloads","issues_url":"https://api.github.com/repos/rmancher/kc/issues{/number}","pulls_url":"https://api.github.com/repos/rmancher/kc/pulls{/number}","milestones_url":"https://api.github.com/repos/rmancher/kc/milestones{/number}","notifications_url":"https://api.github.com/repos/rmancher/kc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rmancher/kc/labels{/name}","releases_url":"https://api.github.com/repos/rmancher/kc/releases{/id}","created_at":"2014-01-28T17:21:00Z","updated_at":"2014-06-13T19:04:34Z","pushed_at":"2014-09-03T15:32:33Z","git_url":"git://github.com/rmancher/kc.git","ssh_url":"git@github.com:rmancher/kc.git","clone_url":"https://github.com/rmancher/kc.git","svn_url":"https://github.com/rmancher/kc","homepage":"http://www.kuali.org/kc","size":589879,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kuali:master","ref":"master","sha":"e1fc320be88b6ca9369f2f525b0257290555d4ae","user":{"login":"kuali","id":371097,"avatar_url":"https://avatars.githubusercontent.com/u/371097?v=2","gravatar_id":"c2e9cf7cb10aab4497c85f81a4188869","url":"https://api.github.com/users/kuali","html_url":"https://github.com/kuali","followers_url":"https://api.github.com/users/kuali/followers","following_url":"https://api.github.com/users/kuali/following{/other_user}","gists_url":"https://api.github.com/users/kuali/gists{/gist_id}","starred_url":"https://api.github.com/users/kuali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kuali/subscriptions","organizations_url":"https://api.github.com/users/kuali/orgs","repos_url":"https://api.github.com/users/kuali/repos","events_url":"https://api.github.com/users/kuali/events{/privacy}","received_events_url":"https://api.github.com/users/kuali/received_events","type":"Organization","site_admin":false},"repo":{"id":16106733,"name":"kc","full_name":"kuali/kc","owner":{"login":"kuali","id":371097,"avatar_url":"https://avatars.githubusercontent.com/u/371097?v=2","gravatar_id":"c2e9cf7cb10aab4497c85f81a4188869","url":"https://api.github.com/users/kuali","html_url":"https://github.com/kuali","followers_url":"https://api.github.com/users/kuali/followers","following_url":"https://api.github.com/users/kuali/following{/other_user}","gists_url":"https://api.github.com/users/kuali/gists{/gist_id}","starred_url":"https://api.github.com/users/kuali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kuali/subscriptions","organizations_url":"https://api.github.com/users/kuali/orgs","repos_url":"https://api.github.com/users/kuali/repos","events_url":"https://api.github.com/users/kuali/events{/privacy}","received_events_url":"https://api.github.com/users/kuali/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kuali/kc","description":"Kuali Coeus","fork":false,"url":"https://api.github.com/repos/kuali/kc","forks_url":"https://api.github.com/repos/kuali/kc/forks","keys_url":"https://api.github.com/repos/kuali/kc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kuali/kc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kuali/kc/teams","hooks_url":"https://api.github.com/repos/kuali/kc/hooks","issue_events_url":"https://api.github.com/repos/kuali/kc/issues/events{/number}","events_url":"https://api.github.com/repos/kuali/kc/events","assignees_url":"https://api.github.com/repos/kuali/kc/assignees{/user}","branches_url":"https://api.github.com/repos/kuali/kc/branches{/branch}","tags_url":"https://api.github.com/repos/kuali/kc/tags","blobs_url":"https://api.github.com/repos/kuali/kc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kuali/kc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kuali/kc/git/refs{/sha}","trees_url":"https://api.github.com/repos/kuali/kc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kuali/kc/statuses/{sha}","languages_url":"https://api.github.com/repos/kuali/kc/languages","stargazers_url":"https://api.github.com/repos/kuali/kc/stargazers","contributors_url":"https://api.github.com/repos/kuali/kc/contributors","subscribers_url":"https://api.github.com/repos/kuali/kc/subscribers","subscription_url":"https://api.github.com/repos/kuali/kc/subscription","commits_url":"https://api.github.com/repos/kuali/kc/commits{/sha}","git_commits_url":"https://api.github.com/repos/kuali/kc/git/commits{/sha}","comments_url":"https://api.github.com/repos/kuali/kc/comments{/number}","issue_comment_url":"https://api.github.com/repos/kuali/kc/issues/comments/{number}","contents_url":"https://api.github.com/repos/kuali/kc/contents/{+path}","compare_url":"https://api.github.com/repos/kuali/kc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kuali/kc/merges","archive_url":"https://api.github.com/repos/kuali/kc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kuali/kc/downloads","issues_url":"https://api.github.com/repos/kuali/kc/issues{/number}","pulls_url":"https://api.github.com/repos/kuali/kc/pulls{/number}","milestones_url":"https://api.github.com/repos/kuali/kc/milestones{/number}","notifications_url":"https://api.github.com/repos/kuali/kc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kuali/kc/labels{/name}","releases_url":"https://api.github.com/repos/kuali/kc/releases{/id}","created_at":"2014-01-21T15:32:22Z","updated_at":"2014-09-02T13:27:22Z","pushed_at":"2014-09-03T18:30:52Z","git_url":"git://github.com/kuali/kc.git","ssh_url":"git@github.com:kuali/kc.git","clone_url":"https://github.com/kuali/kc.git","svn_url":"https://github.com/kuali/kc","homepage":"http://www.kuali.org/kc","size":693020,"stargazers_count":7,"watchers_count":7,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":35,"mirror_url":null,"open_issues_count":13,"forks":35,"open_issues":13,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kuali/kc/pulls/671"},"html":{"href":"https://github.com/kuali/kc/pull/671"},"issue":{"href":"https://api.github.com/repos/kuali/kc/issues/671"},"comments":{"href":"https://api.github.com/repos/kuali/kc/issues/671/comments"},"review_comments":{"href":"https://api.github.com/repos/kuali/kc/pulls/671/comments"},"review_comment":{"href":"https://api.github.com/repos/kuali/kc/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/kuali/kc/pulls/671/commits"},"statuses":{"href":"https://api.github.com/repos/kuali/kc/statuses/f26f6f4cc5942d0e271908a144cfe2c5d885574d"}}}}