GitHub PullRequestReviewCommentEvent at 2014-09-15 06:56:39
Repository: summernote
Actor: HackerWins
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/HackerWins/summernote/pulls/comments/17528184","id":17528184,"diff_hunk":"@@ -539,6 +539,8 @@ define([\n             var selection = document.getSelection();\n             if (selection.rangeCount === 0) {\n               return null;\n+            } else if (selection.anchorNode.tagName === 'BODY') {\n+              return null;","path":"src/js/core/range.js","position":5,"original_position":5,"commit_id":"c488609095dfc38d2592b3e96af99cd5a57060ca","original_commit_id":"c488609095dfc38d2592b3e96af99cd5a57060ca","user":{"login":"HackerWins","id":2059311,"avatar_url":"https://avatars.githubusercontent.com/u/2059311?v=2","gravatar_id":"47236e140589881bbadb777a44340140","url":"https://api.github.com/users/HackerWins","html_url":"https://github.com/HackerWins","followers_url":"https://api.github.com/users/HackerWins/followers","following_url":"https://api.github.com/users/HackerWins/following{/other_user}","gists_url":"https://api.github.com/users/HackerWins/gists{/gist_id}","starred_url":"https://api.github.com/users/HackerWins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HackerWins/subscriptions","organizations_url":"https://api.github.com/users/HackerWins/orgs","repos_url":"https://api.github.com/users/HackerWins/repos","events_url":"https://api.github.com/users/HackerWins/events{/privacy}","received_events_url":"https://api.github.com/users/HackerWins/received_events","type":"User","site_admin":false},"body":"```\r\ndom.isBody(selection.anchorNode)\r\n\r\n// dom.js\r\nisBody: makePredByNodeName('BODY')\r\n```","created_at":"2014-09-15T06:56:39Z","updated_at":"2014-09-15T06:56:39Z","html_url":"https://github.com/HackerWins/summernote/pull/600#discussion_r17528184","pull_request_url":"https://api.github.com/repos/HackerWins/summernote/pulls/600","_links":{"self":{"href":"https://api.github.com/repos/HackerWins/summernote/pulls/comments/17528184"},"html":{"href":"https://github.com/HackerWins/summernote/pull/600#discussion_r17528184"},"pull_request":{"href":"https://api.github.com/repos/HackerWins/summernote/pulls/600"}}},"pull_request":{"url":"https://api.github.com/repos/HackerWins/summernote/pulls/600","id":21142666,"html_url":"https://github.com/HackerWins/summernote/pull/600","diff_url":"https://github.com/HackerWins/summernote/pull/600.diff","patch_url":"https://github.com/HackerWins/summernote/pull/600.patch","issue_url":"https://api.github.com/repos/HackerWins/summernote/issues/600","number":600,"state":"open","locked":false,"title":"Feature/history in a line","user":{"login":"lqez","id":579366,"avatar_url":"https://avatars.githubusercontent.com/u/579366?v=2","gravatar_id":"8495265d0f883004d3be2f81a73ad1ce","url":"https://api.github.com/users/lqez","html_url":"https://github.com/lqez","followers_url":"https://api.github.com/users/lqez/followers","following_url":"https://api.github.com/users/lqez/following{/other_user}","gists_url":"https://api.github.com/users/lqez/gists{/gist_id}","starred_url":"https://api.github.com/users/lqez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lqez/subscriptions","organizations_url":"https://api.github.com/users/lqez/orgs","repos_url":"https://api.github.com/users/lqez/repos","events_url":"https://api.github.com/users/lqez/events{/privacy}","received_events_url":"https://api.github.com/users/lqez/received_events","type":"User","site_admin":false},"body":"I reduced dual undo stack into one with stackOffset.\r\nThis patch also fixes wrong bookmark implementation.\r\n\r\nAnd changed recording undo stack timing from 'before modifying text' to 'after modifying text'. The first undo stack is recorded while initiating summernote.","created_at":"2014-09-12T09:47:20Z","updated_at":"2014-09-15T06:56:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"92c57161ca238d686d630f39b4facb1d1231c77e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/HackerWins/summernote/pulls/600/commits","review_comments_url":"https://api.github.com/repos/HackerWins/summernote/pulls/600/comments","review_comment_url":"https://api.github.com/repos/HackerWins/summernote/pulls/comments/{number}","comments_url":"https://api.github.com/repos/HackerWins/summernote/issues/600/comments","statuses_url":"https://api.github.com/repos/HackerWins/summernote/statuses/c488609095dfc38d2592b3e96af99cd5a57060ca","head":{"label":"HackerWins:feature/history-in-a-line","ref":"feature/history-in-a-line","sha":"c488609095dfc38d2592b3e96af99cd5a57060ca","user":{"login":"HackerWins","id":2059311,"avatar_url":"https://avatars.githubusercontent.com/u/2059311?v=2","gravatar_id":"47236e140589881bbadb777a44340140","url":"https://api.github.com/users/HackerWins","html_url":"https://github.com/HackerWins","followers_url":"https://api.github.com/users/HackerWins/followers","following_url":"https://api.github.com/users/HackerWins/following{/other_user}","gists_url":"https://api.github.com/users/HackerWins/gists{/gist_id}","starred_url":"https://api.github.com/users/HackerWins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HackerWins/subscriptions","organizations_url":"https://api.github.com/users/HackerWins/orgs","repos_url":"https://api.github.com/users/HackerWins/repos","events_url":"https://api.github.com/users/HackerWins/events{/privacy}","received_events_url":"https://api.github.com/users/HackerWins/received_events","type":"User","site_admin":false},"repo":{"id":9709563,"name":"summernote","full_name":"HackerWins/summernote","owner":{"login":"HackerWins","id":2059311,"avatar_url":"https://avatars.githubusercontent.com/u/2059311?v=2","gravatar_id":"47236e140589881bbadb777a44340140","url":"https://api.github.com/users/HackerWins","html_url":"https://github.com/HackerWins","followers_url":"https://api.github.com/users/HackerWins/followers","following_url":"https://api.github.com/users/HackerWins/following{/other_user}","gists_url":"https://api.github.com/users/HackerWins/gists{/gist_id}","starred_url":"https://api.github.com/users/HackerWins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HackerWins/subscriptions","organizations_url":"https://api.github.com/users/HackerWins/orgs","repos_url":"https://api.github.com/users/HackerWins/repos","events_url":"https://api.github.com/users/HackerWins/events{/privacy}","received_events_url":"https://api.github.com/users/HackerWins/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/HackerWins/summernote","description":"Super Simple WYSIWYG Editor on Bootstrap","fork":false,"url":"https://api.github.com/repos/HackerWins/summernote","forks_url":"https://api.github.com/repos/HackerWins/summernote/forks","keys_url":"https://api.github.com/repos/HackerWins/summernote/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HackerWins/summernote/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HackerWins/summernote/teams","hooks_url":"https://api.github.com/repos/HackerWins/summernote/hooks","issue_events_url":"https://api.github.com/repos/HackerWins/summernote/issues/events{/number}","events_url":"https://api.github.com/repos/HackerWins/summernote/events","assignees_url":"https://api.github.com/repos/HackerWins/summernote/assignees{/user}","branches_url":"https://api.github.com/repos/HackerWins/summernote/branches{/branch}","tags_url":"https://api.github.com/repos/HackerWins/summernote/tags","blobs_url":"https://api.github.com/repos/HackerWins/summernote/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HackerWins/summernote/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HackerWins/summernote/git/refs{/sha}","trees_url":"https://api.github.com/repos/HackerWins/summernote/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HackerWins/summernote/statuses/{sha}","languages_url":"https://api.github.com/repos/HackerWins/summernote/languages","stargazers_url":"https://api.github.com/repos/HackerWins/summernote/stargazers","contributors_url":"https://api.github.com/repos/HackerWins/summernote/contributors","subscribers_url":"https://api.github.com/repos/HackerWins/summernote/subscribers","subscription_url":"https://api.github.com/repos/HackerWins/summernote/subscription","commits_url":"https://api.github.com/repos/HackerWins/summernote/commits{/sha}","git_commits_url":"https://api.github.com/repos/HackerWins/summernote/git/commits{/sha}","comments_url":"https://api.github.com/repos/HackerWins/summernote/comments{/number}","issue_comment_url":"https://api.github.com/repos/HackerWins/summernote/issues/comments/{number}","contents_url":"https://api.github.com/repos/HackerWins/summernote/contents/{+path}","compare_url":"https://api.github.com/repos/HackerWins/summernote/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HackerWins/summernote/merges","archive_url":"https://api.github.com/repos/HackerWins/summernote/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HackerWins/summernote/downloads","issues_url":"https://api.github.com/repos/HackerWins/summernote/issues{/number}","pulls_url":"https://api.github.com/repos/HackerWins/summernote/pulls{/number}","milestones_url":"https://api.github.com/repos/HackerWins/summernote/milestones{/number}","notifications_url":"https://api.github.com/repos/HackerWins/summernote/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HackerWins/summernote/labels{/name}","releases_url":"https://api.github.com/repos/HackerWins/summernote/releases{/id}","created_at":"2013-04-27T04:59:48Z","updated_at":"2014-09-15T05:44:16Z","pushed_at":"2014-09-14T04:54:56Z","git_url":"git://github.com/HackerWins/summernote.git","ssh_url":"git@github.com:HackerWins/summernote.git","clone_url":"https://github.com/HackerWins/summernote.git","svn_url":"https://github.com/HackerWins/summernote","homepage":"http://hackerwins.github.io/summernote/","size":7321,"stargazers_count":1665,"watchers_count":1665,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":388,"mirror_url":null,"open_issues_count":191,"forks":388,"open_issues":191,"watchers":1665,"default_branch":"master"}},"base":{"label":"HackerWins:develop","ref":"develop","sha":"98d43349d35d08f90e81d9d5b8ba1597ae219d8c","user":{"login":"HackerWins","id":2059311,"avatar_url":"https://avatars.githubusercontent.com/u/2059311?v=2","gravatar_id":"47236e140589881bbadb777a44340140","url":"https://api.github.com/users/HackerWins","html_url":"https://github.com/HackerWins","followers_url":"https://api.github.com/users/HackerWins/followers","following_url":"https://api.github.com/users/HackerWins/following{/other_user}","gists_url":"https://api.github.com/users/HackerWins/gists{/gist_id}","starred_url":"https://api.github.com/users/HackerWins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HackerWins/subscriptions","organizations_url":"https://api.github.com/users/HackerWins/orgs","repos_url":"https://api.github.com/users/HackerWins/repos","events_url":"https://api.github.com/users/HackerWins/events{/privacy}","received_events_url":"https://api.github.com/users/HackerWins/received_events","type":"User","site_admin":false},"repo":{"id":9709563,"name":"summernote","full_name":"HackerWins/summernote","owner":{"login":"HackerWins","id":2059311,"avatar_url":"https://avatars.githubusercontent.com/u/2059311?v=2","gravatar_id":"47236e140589881bbadb777a44340140","url":"https://api.github.com/users/HackerWins","html_url":"https://github.com/HackerWins","followers_url":"https://api.github.com/users/HackerWins/followers","following_url":"https://api.github.com/users/HackerWins/following{/other_user}","gists_url":"https://api.github.com/users/HackerWins/gists{/gist_id}","starred_url":"https://api.github.com/users/HackerWins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HackerWins/subscriptions","organizations_url":"https://api.github.com/users/HackerWins/orgs","repos_url":"https://api.github.com/users/HackerWins/repos","events_url":"https://api.github.com/users/HackerWins/events{/privacy}","received_events_url":"https://api.github.com/users/HackerWins/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/HackerWins/summernote","description":"Super Simple WYSIWYG Editor on Bootstrap","fork":false,"url":"https://api.github.com/repos/HackerWins/summernote","forks_url":"https://api.github.com/repos/HackerWins/summernote/forks","keys_url":"https://api.github.com/repos/HackerWins/summernote/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HackerWins/summernote/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HackerWins/summernote/teams","hooks_url":"https://api.github.com/repos/HackerWins/summernote/hooks","issue_events_url":"https://api.github.com/repos/HackerWins/summernote/issues/events{/number}","events_url":"https://api.github.com/repos/HackerWins/summernote/events","assignees_url":"https://api.github.com/repos/HackerWins/summernote/assignees{/user}","branches_url":"https://api.github.com/repos/HackerWins/summernote/branches{/branch}","tags_url":"https://api.github.com/repos/HackerWins/summernote/tags","blobs_url":"https://api.github.com/repos/HackerWins/summernote/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HackerWins/summernote/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HackerWins/summernote/git/refs{/sha}","trees_url":"https://api.github.com/repos/HackerWins/summernote/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HackerWins/summernote/statuses/{sha}","languages_url":"https://api.github.com/repos/HackerWins/summernote/languages","stargazers_url":"https://api.github.com/repos/HackerWins/summernote/stargazers","contributors_url":"https://api.github.com/repos/HackerWins/summernote/contributors","subscribers_url":"https://api.github.com/repos/HackerWins/summernote/subscribers","subscription_url":"https://api.github.com/repos/HackerWins/summernote/subscription","commits_url":"https://api.github.com/repos/HackerWins/summernote/commits{/sha}","git_commits_url":"https://api.github.com/repos/HackerWins/summernote/git/commits{/sha}","comments_url":"https://api.github.com/repos/HackerWins/summernote/comments{/number}","issue_comment_url":"https://api.github.com/repos/HackerWins/summernote/issues/comments/{number}","contents_url":"https://api.github.com/repos/HackerWins/summernote/contents/{+path}","compare_url":"https://api.github.com/repos/HackerWins/summernote/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HackerWins/summernote/merges","archive_url":"https://api.github.com/repos/HackerWins/summernote/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HackerWins/summernote/downloads","issues_url":"https://api.github.com/repos/HackerWins/summernote/issues{/number}","pulls_url":"https://api.github.com/repos/HackerWins/summernote/pulls{/number}","milestones_url":"https://api.github.com/repos/HackerWins/summernote/milestones{/number}","notifications_url":"https://api.github.com/repos/HackerWins/summernote/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HackerWins/summernote/labels{/name}","releases_url":"https://api.github.com/repos/HackerWins/summernote/releases{/id}","created_at":"2013-04-27T04:59:48Z","updated_at":"2014-09-15T05:44:16Z","pushed_at":"2014-09-14T04:54:56Z","git_url":"git://github.com/HackerWins/summernote.git","ssh_url":"git@github.com:HackerWins/summernote.git","clone_url":"https://github.com/HackerWins/summernote.git","svn_url":"https://github.com/HackerWins/summernote","homepage":"http://hackerwins.github.io/summernote/","size":7321,"stargazers_count":1665,"watchers_count":1665,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":388,"mirror_url":null,"open_issues_count":191,"forks":388,"open_issues":191,"watchers":1665,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/HackerWins/summernote/pulls/600"},"html":{"href":"https://github.com/HackerWins/summernote/pull/600"},"issue":{"href":"https://api.github.com/repos/HackerWins/summernote/issues/600"},"comments":{"href":"https://api.github.com/repos/HackerWins/summernote/issues/600/comments"},"review_comments":{"href":"https://api.github.com/repos/HackerWins/summernote/pulls/600/comments"},"review_comment":{"href":"https://api.github.com/repos/HackerWins/summernote/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/HackerWins/summernote/pulls/600/commits"},"statuses":{"href":"https://api.github.com/repos/HackerWins/summernote/statuses/c488609095dfc38d2592b3e96af99cd5a57060ca"}}}}