GitHub PullRequestEvent at 2014-06-11 06:44:59
Repository: openhab
Actor: teichsta
Payload: {"action":"closed","number":1136,"pull_request":{"url":"https://api.github.com/repos/openhab/openhab/pulls/1136","id":16942387,"html_url":"https://github.com/openhab/openhab/pull/1136","diff_url":"https://github.com/openhab/openhab/pull/1136.diff","patch_url":"https://github.com/openhab/openhab/pull/1136.patch","issue_url":"https://api.github.com/repos/openhab/openhab/issues/1136","number":1136,"state":"closed","title":"EnOcean binding: Fix illumunation value conversion.","user":{"login":"maggu2810","id":204670,"avatar_url":"https://avatars.githubusercontent.com/u/204670?","gravatar_id":"9d59900b1374a8dc11846ea6b8091a32","url":"https://api.github.com/users/maggu2810","html_url":"https://github.com/maggu2810","followers_url":"https://api.github.com/users/maggu2810/followers","following_url":"https://api.github.com/users/maggu2810/following{/other_user}","gists_url":"https://api.github.com/users/maggu2810/gists{/gist_id}","starred_url":"https://api.github.com/users/maggu2810/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maggu2810/subscriptions","organizations_url":"https://api.github.com/users/maggu2810/orgs","repos_url":"https://api.github.com/users/maggu2810/repos","events_url":"https://api.github.com/users/maggu2810/events{/privacy}","received_events_url":"https://api.github.com/users/maggu2810/received_events","type":"User","site_admin":false},"body":"The EEP A5:08:02 uses plain data values to transfer the illumination value,\r\nno percent type is used.\r\nSo we have to fix the internal IlluminationConverter of the EnOcean binding.\r\n\r\nBelow the error, that is raised before.\r\n\r\n15:46:07.863 INFO  org.opencean.core.ESP3Host[:15] - Received RadioPacket with value 536lx\r\n15:46:07.863 DEBUG o.o.b.e.i.bus.EnoceanBinding[:270] - Received new value 536lx for device at EnoceanParameter: {id=\"00:86:50:20\", parameter=\"ILLUMINANCE\"}\r\n15:46:07.863 INFO  runtime.busevents[:26] - MDTemperature state updated to 29\r\n15:46:07.867 ERROR org.opencean.core.ESP3Host[:78] - Error\r\njava.lang.IllegalArgumentException: Value must be between 0 and 100\r\n        at org.openhab.core.library.types.PercentType.validateValue(PercentType.java:48)\r\n        at org.openhab.core.library.types.PercentType.<init>(PercentType.java:43)\r\n        at org.openhab.binding.enocean.internal.converter.IlluminationConverter.convertToImpl(IlluminationConverter.java:34)\r\n        at org.openhab.binding.enocean.internal.converter.IlluminationConverter.convertToImpl(IlluminationConverter.java:1)\r\n        at org.openhab.binding.enocean.internal.converter.StateConverter.convertTo(StateConverter.java:68)\r\n        at org.openhab.binding.enocean.internal.profiles.StandardProfile.valueChanged(StandardProfile.java:75)\r\n        at org.openhab.binding.enocean.internal.bus.EnoceanBinding.valueChanged(EnoceanBinding.java:283)\r\n        at org.opencean.core.ParameterChangeNotifier.receivePacket(ParameterChangeNotifier.java:47)\r\n        at org.opencean.core.ESP3Host.notifyReceivers(ESP3Host.java:52)\r\n        at org.opencean.core.ESP3Host.run(ESP3Host.java:73)","created_at":"2014-06-10T14:19:23Z","updated_at":"2014-06-11T06:44:58Z","closed_at":"2014-06-11T06:44:58Z","merged_at":"2014-06-11T06:44:58Z","merge_commit_sha":"76d06f1a25ec9ba8fb808026b596f14d7a8f9d77","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openhab/openhab/pulls/1136/commits","review_comments_url":"https://api.github.com/repos/openhab/openhab/pulls/1136/comments","review_comment_url":"https://api.github.com/repos/openhab/openhab/pulls/comments/{number}","comments_url":"https://api.github.com/repos/openhab/openhab/issues/1136/comments","statuses_url":"https://api.github.com/repos/openhab/openhab/statuses/879a44f906597c4063040517e34432cd75d6537a","head":{"label":"maggu2810:enocean-illumination-converter-fix","ref":"enocean-illumination-converter-fix","sha":"879a44f906597c4063040517e34432cd75d6537a","user":{"login":"maggu2810","id":204670,"avatar_url":"https://avatars.githubusercontent.com/u/204670?","gravatar_id":"9d59900b1374a8dc11846ea6b8091a32","url":"https://api.github.com/users/maggu2810","html_url":"https://github.com/maggu2810","followers_url":"https://api.github.com/users/maggu2810/followers","following_url":"https://api.github.com/users/maggu2810/following{/other_user}","gists_url":"https://api.github.com/users/maggu2810/gists{/gist_id}","starred_url":"https://api.github.com/users/maggu2810/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maggu2810/subscriptions","organizations_url":"https://api.github.com/users/maggu2810/orgs","repos_url":"https://api.github.com/users/maggu2810/repos","events_url":"https://api.github.com/users/maggu2810/events{/privacy}","received_events_url":"https://api.github.com/users/maggu2810/received_events","type":"User","site_admin":false},"repo":{"id":20552999,"name":"openhab","full_name":"maggu2810/openhab","owner":{"login":"maggu2810","id":204670,"avatar_url":"https://avatars.githubusercontent.com/u/204670?","gravatar_id":"9d59900b1374a8dc11846ea6b8091a32","url":"https://api.github.com/users/maggu2810","html_url":"https://github.com/maggu2810","followers_url":"https://api.github.com/users/maggu2810/followers","following_url":"https://api.github.com/users/maggu2810/following{/other_user}","gists_url":"https://api.github.com/users/maggu2810/gists{/gist_id}","starred_url":"https://api.github.com/users/maggu2810/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maggu2810/subscriptions","organizations_url":"https://api.github.com/users/maggu2810/orgs","repos_url":"https://api.github.com/users/maggu2810/repos","events_url":"https://api.github.com/users/maggu2810/events{/privacy}","received_events_url":"https://api.github.com/users/maggu2810/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/maggu2810/openhab","description":"Source code of the open Home Automation Bus (openHAB)","fork":true,"url":"https://api.github.com/repos/maggu2810/openhab","forks_url":"https://api.github.com/repos/maggu2810/openhab/forks","keys_url":"https://api.github.com/repos/maggu2810/openhab/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maggu2810/openhab/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maggu2810/openhab/teams","hooks_url":"https://api.github.com/repos/maggu2810/openhab/hooks","issue_events_url":"https://api.github.com/repos/maggu2810/openhab/issues/events{/number}","events_url":"https://api.github.com/repos/maggu2810/openhab/events","assignees_url":"https://api.github.com/repos/maggu2810/openhab/assignees{/user}","branches_url":"https://api.github.com/repos/maggu2810/openhab/branches{/branch}","tags_url":"https://api.github.com/repos/maggu2810/openhab/tags","blobs_url":"https://api.github.com/repos/maggu2810/openhab/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maggu2810/openhab/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maggu2810/openhab/git/refs{/sha}","trees_url":"https://api.github.com/repos/maggu2810/openhab/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maggu2810/openhab/statuses/{sha}","languages_url":"https://api.github.com/repos/maggu2810/openhab/languages","stargazers_url":"https://api.github.com/repos/maggu2810/openhab/stargazers","contributors_url":"https://api.github.com/repos/maggu2810/openhab/contributors","subscribers_url":"https://api.github.com/repos/maggu2810/openhab/subscribers","subscription_url":"https://api.github.com/repos/maggu2810/openhab/subscription","commits_url":"https://api.github.com/repos/maggu2810/openhab/commits{/sha}","git_commits_url":"https://api.github.com/repos/maggu2810/openhab/git/commits{/sha}","comments_url":"https://api.github.com/repos/maggu2810/openhab/comments{/number}","issue_comment_url":"https://api.github.com/repos/maggu2810/openhab/issues/comments/{number}","contents_url":"https://api.github.com/repos/maggu2810/openhab/contents/{+path}","compare_url":"https://api.github.com/repos/maggu2810/openhab/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maggu2810/openhab/merges","archive_url":"https://api.github.com/repos/maggu2810/openhab/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maggu2810/openhab/downloads","issues_url":"https://api.github.com/repos/maggu2810/openhab/issues{/number}","pulls_url":"https://api.github.com/repos/maggu2810/openhab/pulls{/number}","milestones_url":"https://api.github.com/repos/maggu2810/openhab/milestones{/number}","notifications_url":"https://api.github.com/repos/maggu2810/openhab/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maggu2810/openhab/labels{/name}","releases_url":"https://api.github.com/repos/maggu2810/openhab/releases{/id}","created_at":"2014-06-06T05:53:39Z","updated_at":"2014-06-11T06:44:58Z","pushed_at":"2014-06-10T14:17:57Z","git_url":"git://github.com/maggu2810/openhab.git","ssh_url":"git@github.com:maggu2810/openhab.git","clone_url":"https://github.com/maggu2810/openhab.git","svn_url":"https://github.com/maggu2810/openhab","homepage":null,"size":121672,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openhab:master","ref":"master","sha":"dec0ef2e74151cfb05007936b83b454e501c1338","user":{"login":"openhab","id":1007353,"avatar_url":"https://avatars.githubusercontent.com/u/1007353?","gravatar_id":"f73240487757584a0d76098e83c40520","url":"https://api.github.com/users/openhab","html_url":"https://github.com/openhab","followers_url":"https://api.github.com/users/openhab/followers","following_url":"https://api.github.com/users/openhab/following{/other_user}","gists_url":"https://api.github.com/users/openhab/gists{/gist_id}","starred_url":"https://api.github.com/users/openhab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openhab/subscriptions","organizations_url":"https://api.github.com/users/openhab/orgs","repos_url":"https://api.github.com/users/openhab/repos","events_url":"https://api.github.com/users/openhab/events{/privacy}","received_events_url":"https://api.github.com/users/openhab/received_events","type":"Organization","site_admin":false},"repo":{"id":12983151,"name":"openhab","full_name":"openhab/openhab","owner":{"login":"openhab","id":1007353,"avatar_url":"https://avatars.githubusercontent.com/u/1007353?","gravatar_id":"f73240487757584a0d76098e83c40520","url":"https://api.github.com/users/openhab","html_url":"https://github.com/openhab","followers_url":"https://api.github.com/users/openhab/followers","following_url":"https://api.github.com/users/openhab/following{/other_user}","gists_url":"https://api.github.com/users/openhab/gists{/gist_id}","starred_url":"https://api.github.com/users/openhab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openhab/subscriptions","organizations_url":"https://api.github.com/users/openhab/orgs","repos_url":"https://api.github.com/users/openhab/repos","events_url":"https://api.github.com/users/openhab/events{/privacy}","received_events_url":"https://api.github.com/users/openhab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openhab/openhab","description":"Source code of the open Home Automation Bus (openHAB)","fork":false,"url":"https://api.github.com/repos/openhab/openhab","forks_url":"https://api.github.com/repos/openhab/openhab/forks","keys_url":"https://api.github.com/repos/openhab/openhab/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openhab/openhab/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openhab/openhab/teams","hooks_url":"https://api.github.com/repos/openhab/openhab/hooks","issue_events_url":"https://api.github.com/repos/openhab/openhab/issues/events{/number}","events_url":"https://api.github.com/repos/openhab/openhab/events","assignees_url":"https://api.github.com/repos/openhab/openhab/assignees{/user}","branches_url":"https://api.github.com/repos/openhab/openhab/branches{/branch}","tags_url":"https://api.github.com/repos/openhab/openhab/tags","blobs_url":"https://api.github.com/repos/openhab/openhab/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openhab/openhab/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openhab/openhab/git/refs{/sha}","trees_url":"https://api.github.com/repos/openhab/openhab/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openhab/openhab/statuses/{sha}","languages_url":"https://api.github.com/repos/openhab/openhab/languages","stargazers_url":"https://api.github.com/repos/openhab/openhab/stargazers","contributors_url":"https://api.github.com/repos/openhab/openhab/contributors","subscribers_url":"https://api.github.com/repos/openhab/openhab/subscribers","subscription_url":"https://api.github.com/repos/openhab/openhab/subscription","commits_url":"https://api.github.com/repos/openhab/openhab/commits{/sha}","git_commits_url":"https://api.github.com/repos/openhab/openhab/git/commits{/sha}","comments_url":"https://api.github.com/repos/openhab/openhab/comments{/number}","issue_comment_url":"https://api.github.com/repos/openhab/openhab/issues/comments/{number}","contents_url":"https://api.github.com/repos/openhab/openhab/contents/{+path}","compare_url":"https://api.github.com/repos/openhab/openhab/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openhab/openhab/merges","archive_url":"https://api.github.com/repos/openhab/openhab/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openhab/openhab/downloads","issues_url":"https://api.github.com/repos/openhab/openhab/issues{/number}","pulls_url":"https://api.github.com/repos/openhab/openhab/pulls{/number}","milestones_url":"https://api.github.com/repos/openhab/openhab/milestones{/number}","notifications_url":"https://api.github.com/repos/openhab/openhab/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openhab/openhab/labels{/name}","releases_url":"https://api.github.com/repos/openhab/openhab/releases{/id}","created_at":"2013-09-20T20:28:43Z","updated_at":"2014-06-11T06:44:58Z","pushed_at":"2014-06-11T06:44:58Z","git_url":"git://github.com/openhab/openhab.git","ssh_url":"git@github.com:openhab/openhab.git","clone_url":"https://github.com/openhab/openhab.git","svn_url":"https://github.com/openhab/openhab","homepage":null,"size":164467,"stargazers_count":469,"watchers_count":469,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":293,"mirror_url":null,"open_issues_count":206,"forks":293,"open_issues":206,"watchers":469,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openhab/openhab/pulls/1136"},"html":{"href":"https://github.com/openhab/openhab/pull/1136"},"issue":{"href":"https://api.github.com/repos/openhab/openhab/issues/1136"},"comments":{"href":"https://api.github.com/repos/openhab/openhab/issues/1136/comments"},"review_comments":{"href":"https://api.github.com/repos/openhab/openhab/pulls/1136/comments"},"review_comment":{"href":"https://api.github.com/repos/openhab/openhab/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/openhab/openhab/pulls/1136/commits"},"statuses":{"href":"https://api.github.com/repos/openhab/openhab/statuses/879a44f906597c4063040517e34432cd75d6537a"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"teichsta","id":2108636,"avatar_url":"https://avatars.githubusercontent.com/u/2108636?","gravatar_id":"ce7d453b04cd4dbd67df77d4cbf564b3","url":"https://api.github.com/users/teichsta","html_url":"https://github.com/teichsta","followers_url":"https://api.github.com/users/teichsta/followers","following_url":"https://api.github.com/users/teichsta/following{/other_user}","gists_url":"https://api.github.com/users/teichsta/gists{/gist_id}","starred_url":"https://api.github.com/users/teichsta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teichsta/subscriptions","organizations_url":"https://api.github.com/users/teichsta/orgs","repos_url":"https://api.github.com/users/teichsta/repos","events_url":"https://api.github.com/users/teichsta/events{/privacy}","received_events_url":"https://api.github.com/users/teichsta/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"commits":1,"additions":1,"deletions":2,"changed_files":1}}