GitHub PullRequestReviewCommentEvent at 2014-01-24 21:59:12
Repository: homebrew
Actor: mikemcquaid
Payload: {"comment":{"url":"https://api.github.com/repos/Homebrew/homebrew/pulls/comments/9164918","id":9164918,"diff_hunk":"@@ -5,15 +5,26 @@ class Qwt < Formula\n   url 'http://downloads.sourceforge.net/project/qwt/qwt/6.1.0/qwt-6.1.0.tar.bz2'\n   sha1 '48a967038f7aa9a9c87c64bcb2eb07c5df375565'\n \n+  option \"without-framework\", \"Build as libs instead of framework\"\n+  option \"with-qwtmathml\", \"Build the qwtmathml library\"\n+\n   depends_on 'qt'\n \n+  # update designer plugin linking back to qwt framework/lib\n+  # this is specific to Homebrew and probably (?) doesn't need patched upstream\n+  def patches\n+    DATA\n+  end\n+\n   def install\n     inreplace 'qwtconfig.pri' do |s|\n       # change_make_var won't work because there are leading spaces\n       s.gsub! /^\\s*QWT_INSTALL_PREFIX\\s*=(.*)$/, \"QWT_INSTALL_PREFIX=#{prefix}\"\n+      s.sub! /#(QWT_CONFIG\\s*\\+= QwtMathML)/, \"\\\\1\" if build.with? \"qwtmathml\"\n+      s << \"\\n\" << \"QWT_CONFIG -= QwtFramework\" if build.without? \"framework\"\n     end\n \n-    args = ['-config', 'release', '-spec']\n+    args = %W[-config release -spec]","path":"Library/Formula/qwt.rb","position":24,"original_position":24,"commit_id":"9ee0c62c4d0f0d3043c8e019177e2be9b117492e","original_commit_id":"9ee0c62c4d0f0d3043c8e019177e2be9b117492e","user":{"login":"mikemcquaid","id":125011,"avatar_url":"https://gravatar.com/avatar/215e0166d4d8265395c5d9076da73c70?d=https%3A%2F%2Fidenticons.github.com%2F19e490b885e34ade007230f7a58dc9a4.png&r=x","gravatar_id":"215e0166d4d8265395c5d9076da73c70","url":"https://api.github.com/users/mikemcquaid","html_url":"https://github.com/mikemcquaid","followers_url":"https://api.github.com/users/mikemcquaid/followers","following_url":"https://api.github.com/users/mikemcquaid/following{/other_user}","gists_url":"https://api.github.com/users/mikemcquaid/gists{/gist_id}","starred_url":"https://api.github.com/users/mikemcquaid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikemcquaid/subscriptions","organizations_url":"https://api.github.com/users/mikemcquaid/orgs","repos_url":"https://api.github.com/users/mikemcquaid/repos","events_url":"https://api.github.com/users/mikemcquaid/events{/privacy}","received_events_url":"https://api.github.com/users/mikemcquaid/received_events","type":"User","site_admin":true},"body":"No need to change stuff like this.","created_at":"2014-01-24T21:59:12Z","updated_at":"2014-01-24T21:59:12Z","html_url":"https://github.com/Homebrew/homebrew/pull/26152#discussion_r9164918","pull_request_url":"https://api.github.com/repos/Homebrew/homebrew/pulls/26152","_links":{"self":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/comments/9164918"},"html":{"href":"https://github.com/Homebrew/homebrew/pull/26152#discussion_r9164918"},"pull_request":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/26152"}}}}