GitHub PullRequestReviewCommentEvent at 2014-03-24 00:28:42
Repository: rails
Actor: sikachu
Payload: {"comment":{"url":"https://api.github.com/repos/rails/rails/pulls/comments/10870332","id":10870332,"diff_hunk":"@@ -350,6 +435,13 @@ def convert_value_to_parameters(value)\n         end\n       end\n \n+      # Attribute that keeps track of converted arrays, if any, to avoid double\n+      # looping in the common use case permit + mass-assignment. Defined in a\n+      # method to instantiate it only if needed.\n+      def converted_arrays\n+        @converted_arrays ||= Set.new\n+      end","path":"actionpack/lib/action_controller/metal/strong_parameters.rb","position":234,"original_position":234,"commit_id":"f9dace28cbbd110f29c020c71c001a36a927c2bf","original_commit_id":"f9dace28cbbd110f29c020c71c001a36a927c2bf","user":{"login":"sikachu","id":4912,"avatar_url":"https://avatars.githubusercontent.com/u/4912?","gravatar_id":"f1c4a3bb1606cc4a61711e61e2fe6146","url":"https://api.github.com/users/sikachu","html_url":"https://github.com/sikachu","followers_url":"https://api.github.com/users/sikachu/followers","following_url":"https://api.github.com/users/sikachu/following{/other_user}","gists_url":"https://api.github.com/users/sikachu/gists{/gist_id}","starred_url":"https://api.github.com/users/sikachu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sikachu/subscriptions","organizations_url":"https://api.github.com/users/sikachu/orgs","repos_url":"https://api.github.com/users/sikachu/repos","events_url":"https://api.github.com/users/sikachu/events{/privacy}","received_events_url":"https://api.github.com/users/sikachu/received_events","type":"User","site_admin":false},"body":"Yes. @tenderlove were curious why it was `public` in the first place, and change it to `private` did not break anything.","created_at":"2014-03-24T00:28:42Z","updated_at":"2014-03-24T00:28:42Z","html_url":"https://github.com/rails/rails/pull/14384#discussion_r10870332","pull_request_url":"https://api.github.com/repos/rails/rails/pulls/14384","_links":{"self":{"href":"https://api.github.com/repos/rails/rails/pulls/comments/10870332"},"html":{"href":"https://github.com/rails/rails/pull/14384#discussion_r10870332"},"pull_request":{"href":"https://api.github.com/repos/rails/rails/pulls/14384"}}}}