GitHub PullRequestReviewCommentEvent at 2014-08-20 13:00:05
Repository: robottelo
Actor: Ichimonji10
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/omaciel/robottelo/pulls/comments/16473628","id":16473628,"diff_hunk":"@@ -75,8 +75,12 @@ def test_create_resource_2(self, test_data):\n             self.assertIsNotNone(search)\n \n     @attr('ui', 'resource', 'implemented')\n-    @data(*generate_strings_list(len1=255))\n-    def test_create_resource_3(self, description):\n+    @data({u'description': generate_string('alphanumeric', 255)},\n+          {u'description': generate_string('alpha', 255)},\n+          {u'description': generate_string('numeric', 255)},\n+          {u'description': generate_string('latin1', 255)},\n+          {u'description': generate_string('utf8', 255)})\n+    def test_create_resource_3(self, test_data):","path":"tests/foreman/ui/test_computeresource.py","position":11,"original_position":11,"commit_id":"e448de1918e909782163a2a84424787c126cd15e","original_commit_id":"e448de1918e909782163a2a84424787c126cd15e","user":{"login":"Ichimonji10","id":1012989,"avatar_url":"https://avatars.githubusercontent.com/u/1012989?v=2","gravatar_id":"0d55b0822baba206e15373fbe457bf70","url":"https://api.github.com/users/Ichimonji10","html_url":"https://github.com/Ichimonji10","followers_url":"https://api.github.com/users/Ichimonji10/followers","following_url":"https://api.github.com/users/Ichimonji10/following{/other_user}","gists_url":"https://api.github.com/users/Ichimonji10/gists{/gist_id}","starred_url":"https://api.github.com/users/Ichimonji10/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ichimonji10/subscriptions","organizations_url":"https://api.github.com/users/Ichimonji10/orgs","repos_url":"https://api.github.com/users/Ichimonji10/repos","events_url":"https://api.github.com/users/Ichimonji10/events{/privacy}","received_events_url":"https://api.github.com/users/Ichimonji10/received_events","type":"User","site_admin":false},"body":"Hmm. I don't understand why a dict is being used here, given that only one one piece of test data is being handed in to the test function. For example, this seems more straightforward to me:\r\n\r\n```python\r\n@data(\r\n    generate_string('alphanumeric', 255),\r\n    generate_string('alpha', 255),\r\n    generate_string('numeric', 255),\r\n    generate_string('latin1', 255),\r\n    generate_string('utf8', 255),\r\n)\r\ndef test_create_resource_3(self, description):\r\n    ...\r\n    make_resource(\r\n        session,\r\n        name=name,\r\n        description=description,\r\n        provider_type=provider_type,\r\n        url=url,\r\n    )\r\n    ...\r\n```\r\n\r\nThoughts?","created_at":"2014-08-20T13:00:05Z","updated_at":"2014-08-20T13:00:05Z","html_url":"https://github.com/omaciel/robottelo/pull/1216#discussion_r16473628","pull_request_url":"https://api.github.com/repos/omaciel/robottelo/pulls/1216","_links":{"self":{"href":"https://api.github.com/repos/omaciel/robottelo/pulls/comments/16473628"},"html":{"href":"https://github.com/omaciel/robottelo/pull/1216#discussion_r16473628"},"pull_request":{"href":"https://api.github.com/repos/omaciel/robottelo/pulls/1216"}}},"pull_request":{"url":"https://api.github.com/repos/omaciel/robottelo/pulls/1216","id":20037867,"html_url":"https://github.com/omaciel/robottelo/pull/1216","diff_url":"https://github.com/omaciel/robottelo/pull/1216.diff","patch_url":"https://github.com/omaciel/robottelo/pull/1216.patch","issue_url":"https://api.github.com/repos/omaciel/robottelo/issues/1216","number":1216,"state":"open","locked":false,"title":"Fixed few more UI tests","user":{"login":"sghai","id":620852,"avatar_url":"https://avatars.githubusercontent.com/u/620852?v=2","gravatar_id":"0405c72200ec01c5d61fcdb6b04329d4","url":"https://api.github.com/users/sghai","html_url":"https://github.com/sghai","followers_url":"https://api.github.com/users/sghai/followers","following_url":"https://api.github.com/users/sghai/following{/other_user}","gists_url":"https://api.github.com/users/sghai/gists{/gist_id}","starred_url":"https://api.github.com/users/sghai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sghai/subscriptions","organizations_url":"https://api.github.com/users/sghai/orgs","repos_url":"https://api.github.com/users/sghai/repos","events_url":"https://api.github.com/users/sghai/events{/privacy}","received_events_url":"https://api.github.com/users/sghai/received_events","type":"User","site_admin":false},"body":"- Fixed following repo tests:\r\n  - `test_remove_repo` : updated locator for remove repository button\r\n  - `test_positive_update_1` added wait_for_ajax()\r\n- Fixed compute resource, media tests.. updated data for these tests\r\n- Blocked sync plan tests and a architecture test with bz ID\r\n\r\n","created_at":"2014-08-20T10:55:12Z","updated_at":"2014-08-20T13:00:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f74af27d8d4cf2168b403a9a2ed296c9af7a295c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/omaciel/robottelo/pulls/1216/commits","review_comments_url":"https://api.github.com/repos/omaciel/robottelo/pulls/1216/comments","review_comment_url":"https://api.github.com/repos/omaciel/robottelo/pulls/comments/{number}","comments_url":"https://api.github.com/repos/omaciel/robottelo/issues/1216/comments","statuses_url":"https://api.github.com/repos/omaciel/robottelo/statuses/e448de1918e909782163a2a84424787c126cd15e","head":{"label":"sghai:fix-test","ref":"fix-test","sha":"e448de1918e909782163a2a84424787c126cd15e","user":{"login":"sghai","id":620852,"avatar_url":"https://avatars.githubusercontent.com/u/620852?v=2","gravatar_id":"0405c72200ec01c5d61fcdb6b04329d4","url":"https://api.github.com/users/sghai","html_url":"https://github.com/sghai","followers_url":"https://api.github.com/users/sghai/followers","following_url":"https://api.github.com/users/sghai/following{/other_user}","gists_url":"https://api.github.com/users/sghai/gists{/gist_id}","starred_url":"https://api.github.com/users/sghai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sghai/subscriptions","organizations_url":"https://api.github.com/users/sghai/orgs","repos_url":"https://api.github.com/users/sghai/repos","events_url":"https://api.github.com/users/sghai/events{/privacy}","received_events_url":"https://api.github.com/users/sghai/received_events","type":"User","site_admin":false},"repo":{"id":14514487,"name":"robottelo","full_name":"sghai/robottelo","owner":{"login":"sghai","id":620852,"avatar_url":"https://avatars.githubusercontent.com/u/620852?v=2","gravatar_id":"0405c72200ec01c5d61fcdb6b04329d4","url":"https://api.github.com/users/sghai","html_url":"https://github.com/sghai","followers_url":"https://api.github.com/users/sghai/followers","following_url":"https://api.github.com/users/sghai/following{/other_user}","gists_url":"https://api.github.com/users/sghai/gists{/gist_id}","starred_url":"https://api.github.com/users/sghai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sghai/subscriptions","organizations_url":"https://api.github.com/users/sghai/orgs","repos_url":"https://api.github.com/users/sghai/repos","events_url":"https://api.github.com/users/sghai/events{/privacy}","received_events_url":"https://api.github.com/users/sghai/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sghai/robottelo","description":"An automation testing framework for the Katello project.","fork":true,"url":"https://api.github.com/repos/sghai/robottelo","forks_url":"https://api.github.com/repos/sghai/robottelo/forks","keys_url":"https://api.github.com/repos/sghai/robottelo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sghai/robottelo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sghai/robottelo/teams","hooks_url":"https://api.github.com/repos/sghai/robottelo/hooks","issue_events_url":"https://api.github.com/repos/sghai/robottelo/issues/events{/number}","events_url":"https://api.github.com/repos/sghai/robottelo/events","assignees_url":"https://api.github.com/repos/sghai/robottelo/assignees{/user}","branches_url":"https://api.github.com/repos/sghai/robottelo/branches{/branch}","tags_url":"https://api.github.com/repos/sghai/robottelo/tags","blobs_url":"https://api.github.com/repos/sghai/robottelo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sghai/robottelo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sghai/robottelo/git/refs{/sha}","trees_url":"https://api.github.com/repos/sghai/robottelo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sghai/robottelo/statuses/{sha}","languages_url":"https://api.github.com/repos/sghai/robottelo/languages","stargazers_url":"https://api.github.com/repos/sghai/robottelo/stargazers","contributors_url":"https://api.github.com/repos/sghai/robottelo/contributors","subscribers_url":"https://api.github.com/repos/sghai/robottelo/subscribers","subscription_url":"https://api.github.com/repos/sghai/robottelo/subscription","commits_url":"https://api.github.com/repos/sghai/robottelo/commits{/sha}","git_commits_url":"https://api.github.com/repos/sghai/robottelo/git/commits{/sha}","comments_url":"https://api.github.com/repos/sghai/robottelo/comments{/number}","issue_comment_url":"https://api.github.com/repos/sghai/robottelo/issues/comments/{number}","contents_url":"https://api.github.com/repos/sghai/robottelo/contents/{+path}","compare_url":"https://api.github.com/repos/sghai/robottelo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sghai/robottelo/merges","archive_url":"https://api.github.com/repos/sghai/robottelo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sghai/robottelo/downloads","issues_url":"https://api.github.com/repos/sghai/robottelo/issues{/number}","pulls_url":"https://api.github.com/repos/sghai/robottelo/pulls{/number}","milestones_url":"https://api.github.com/repos/sghai/robottelo/milestones{/number}","notifications_url":"https://api.github.com/repos/sghai/robottelo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sghai/robottelo/labels{/name}","releases_url":"https://api.github.com/repos/sghai/robottelo/releases{/id}","created_at":"2013-11-19T04:46:42Z","updated_at":"2014-07-08T08:41:11Z","pushed_at":"2014-08-20T10:56:20Z","git_url":"git://github.com/sghai/robottelo.git","ssh_url":"git@github.com:sghai/robottelo.git","clone_url":"https://github.com/sghai/robottelo.git","svn_url":"https://github.com/sghai/robottelo","homepage":null,"size":7400,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"omaciel:master","ref":"master","sha":"36a46360a00a6d7c924afd07666b0f3b8601fa9d","user":{"login":"omaciel","id":53362,"avatar_url":"https://avatars.githubusercontent.com/u/53362?v=2","gravatar_id":"5be9b08cd178f87cca6de19f00a9992c","url":"https://api.github.com/users/omaciel","html_url":"https://github.com/omaciel","followers_url":"https://api.github.com/users/omaciel/followers","following_url":"https://api.github.com/users/omaciel/following{/other_user}","gists_url":"https://api.github.com/users/omaciel/gists{/gist_id}","starred_url":"https://api.github.com/users/omaciel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omaciel/subscriptions","organizations_url":"https://api.github.com/users/omaciel/orgs","repos_url":"https://api.github.com/users/omaciel/repos","events_url":"https://api.github.com/users/omaciel/events{/privacy}","received_events_url":"https://api.github.com/users/omaciel/received_events","type":"User","site_admin":false},"repo":{"id":4000279,"name":"robottelo","full_name":"omaciel/robottelo","owner":{"login":"omaciel","id":53362,"avatar_url":"https://avatars.githubusercontent.com/u/53362?v=2","gravatar_id":"5be9b08cd178f87cca6de19f00a9992c","url":"https://api.github.com/users/omaciel","html_url":"https://github.com/omaciel","followers_url":"https://api.github.com/users/omaciel/followers","following_url":"https://api.github.com/users/omaciel/following{/other_user}","gists_url":"https://api.github.com/users/omaciel/gists{/gist_id}","starred_url":"https://api.github.com/users/omaciel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omaciel/subscriptions","organizations_url":"https://api.github.com/users/omaciel/orgs","repos_url":"https://api.github.com/users/omaciel/repos","events_url":"https://api.github.com/users/omaciel/events{/privacy}","received_events_url":"https://api.github.com/users/omaciel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/omaciel/robottelo","description":"An automation testing framework for the Katello project.","fork":false,"url":"https://api.github.com/repos/omaciel/robottelo","forks_url":"https://api.github.com/repos/omaciel/robottelo/forks","keys_url":"https://api.github.com/repos/omaciel/robottelo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/omaciel/robottelo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/omaciel/robottelo/teams","hooks_url":"https://api.github.com/repos/omaciel/robottelo/hooks","issue_events_url":"https://api.github.com/repos/omaciel/robottelo/issues/events{/number}","events_url":"https://api.github.com/repos/omaciel/robottelo/events","assignees_url":"https://api.github.com/repos/omaciel/robottelo/assignees{/user}","branches_url":"https://api.github.com/repos/omaciel/robottelo/branches{/branch}","tags_url":"https://api.github.com/repos/omaciel/robottelo/tags","blobs_url":"https://api.github.com/repos/omaciel/robottelo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/omaciel/robottelo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/omaciel/robottelo/git/refs{/sha}","trees_url":"https://api.github.com/repos/omaciel/robottelo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/omaciel/robottelo/statuses/{sha}","languages_url":"https://api.github.com/repos/omaciel/robottelo/languages","stargazers_url":"https://api.github.com/repos/omaciel/robottelo/stargazers","contributors_url":"https://api.github.com/repos/omaciel/robottelo/contributors","subscribers_url":"https://api.github.com/repos/omaciel/robottelo/subscribers","subscription_url":"https://api.github.com/repos/omaciel/robottelo/subscription","commits_url":"https://api.github.com/repos/omaciel/robottelo/commits{/sha}","git_commits_url":"https://api.github.com/repos/omaciel/robottelo/git/commits{/sha}","comments_url":"https://api.github.com/repos/omaciel/robottelo/comments{/number}","issue_comment_url":"https://api.github.com/repos/omaciel/robottelo/issues/comments/{number}","contents_url":"https://api.github.com/repos/omaciel/robottelo/contents/{+path}","compare_url":"https://api.github.com/repos/omaciel/robottelo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/omaciel/robottelo/merges","archive_url":"https://api.github.com/repos/omaciel/robottelo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/omaciel/robottelo/downloads","issues_url":"https://api.github.com/repos/omaciel/robottelo/issues{/number}","pulls_url":"https://api.github.com/repos/omaciel/robottelo/pulls{/number}","milestones_url":"https://api.github.com/repos/omaciel/robottelo/milestones{/number}","notifications_url":"https://api.github.com/repos/omaciel/robottelo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/omaciel/robottelo/labels{/name}","releases_url":"https://api.github.com/repos/omaciel/robottelo/releases{/id}","created_at":"2012-04-12T01:36:39Z","updated_at":"2014-06-27T23:03:18Z","pushed_at":"2014-08-19T22:20:30Z","git_url":"git://github.com/omaciel/robottelo.git","ssh_url":"git@github.com:omaciel/robottelo.git","clone_url":"https://github.com/omaciel/robottelo.git","svn_url":"https://github.com/omaciel/robottelo","homepage":null,"size":19543,"stargazers_count":16,"watchers_count":16,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":18,"mirror_url":null,"open_issues_count":103,"forks":18,"open_issues":103,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/omaciel/robottelo/pulls/1216"},"html":{"href":"https://github.com/omaciel/robottelo/pull/1216"},"issue":{"href":"https://api.github.com/repos/omaciel/robottelo/issues/1216"},"comments":{"href":"https://api.github.com/repos/omaciel/robottelo/issues/1216/comments"},"review_comments":{"href":"https://api.github.com/repos/omaciel/robottelo/pulls/1216/comments"},"review_comment":{"href":"https://api.github.com/repos/omaciel/robottelo/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/omaciel/robottelo/pulls/1216/commits"},"statuses":{"href":"https://api.github.com/repos/omaciel/robottelo/statuses/e448de1918e909782163a2a84424787c126cd15e"}}}}