GitHub PullRequestReviewCommentEvent at 2014-02-03 16:58:56
Repository: VivaldiGSI
Actor: callicles
Payload: {"comment":{"url":"https://api.github.com/repos/BeyondTheClouds/VivaldiGSI/pulls/comments/9389869","id":9389869,"diff_hunk":"@@ -63,18 +76,70 @@ class Main(name : String,id:Int) extends Actor {\n     case DeleteCloseNode(toDelete) => deleteCloseNode(toDelete)\n     case p: Ping => network forward p\n     case f:FirstContact => network forward f\n-    case unknownMessage => log.info(\"Unkown Message \"+unknownMessage)\n+    case a: AreYouAwake => sender ! IAmAwake(closeNodes)\n+    case unknownMessage => log.info(\"Unknown Message \"+unknownMessage)\n+  }\n+\n+  /**\n+   * Check is a node is responding and if so retrieve its closeNodes table have more information\n+   * @param info Node to contact\n+   * @return true if the node is responding and false otherwise\n+   */\n+  def isAwake(info: nodeInfo): Boolean = {\n+    implicit val timeout = Timeout(5 seconds)","path":"src/main/scala/org/discovery/vivaldi/system/Main.scala","position":56,"original_position":56,"commit_id":"0285f258f74f1c38a4c60a3182b8e13037a6b210","original_commit_id":"0285f258f74f1c38a4c60a3182b8e13037a6b210","user":{"login":"callicles","id":4429209,"avatar_url":"https://gravatar.com/avatar/7a1da6a1f31d9b02d0947593f4361b55?d=https%3A%2F%2Fidenticons.github.com%2F9fed512da81c14095a707cf62c5159c9.png&r=x","gravatar_id":"7a1da6a1f31d9b02d0947593f4361b55","url":"https://api.github.com/users/callicles","html_url":"https://github.com/callicles","followers_url":"https://api.github.com/users/callicles/followers","following_url":"https://api.github.com/users/callicles/following{/other_user}","gists_url":"https://api.github.com/users/callicles/gists{/gist_id}","starred_url":"https://api.github.com/users/callicles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/callicles/subscriptions","organizations_url":"https://api.github.com/users/callicles/orgs","repos_url":"https://api.github.com/users/callicles/repos","events_url":"https://api.github.com/users/callicles/events{/privacy}","received_events_url":"https://api.github.com/users/callicles/received_events","type":"User","site_admin":false},"body":"laisser le timeout hardcodé ? --> Fichier de conf non ?","created_at":"2014-02-03T16:58:56Z","updated_at":"2014-02-03T16:58:56Z","html_url":"https://github.com/BeyondTheClouds/VivaldiGSI/pull/36#discussion_r9389869","pull_request_url":"https://api.github.com/repos/BeyondTheClouds/VivaldiGSI/pulls/36","_links":{"self":{"href":"https://api.github.com/repos/BeyondTheClouds/VivaldiGSI/pulls/comments/9389869"},"html":{"href":"https://github.com/BeyondTheClouds/VivaldiGSI/pull/36#discussion_r9389869"},"pull_request":{"href":"https://api.github.com/repos/BeyondTheClouds/VivaldiGSI/pulls/36"}}}}