GitHub PullRequestReviewCommentEvent at 2014-11-07 14:50:53
Repository: wp-amazon-s3-and-cloudfront
Actor: polevaultweb
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/deliciousbrains/wp-amazon-s3-and-cloudfront/pulls/comments/20013628","id":20013628,"diff_hunk":"@@ -20,8 +24,12 @@ function __construct( $plugin_file_path, $aws ) {\n \n \t\tadd_action( 'wp_ajax_as3cf-create-bucket', array( $this, 'ajax_create_bucket' ) );\n \n+\t\tif ( $this->get_setting( 'serve-from-s3' ) ) {\n+\t\t\tadd_filter( 'wp_get_attachment_url', array( $this, 'wp_get_attachment_url' ), 99, 2 );\n+\t\t\tadd_filter( 'image_downsize', array( $this, 'image_downsize' ), 10, 3 );\n+\t\t}\n+","path":"classes/amazon-s3-and-cloudfront.php","position":null,"original_position":19,"commit_id":"81f202d1df75696d4e599bb3a997a8aeb0936592","original_commit_id":"e8d55c5e8ed96a9597b8c77c0a013a6de9175f0b","user":{"login":"polevaultweb","id":1770201,"avatar_url":"https://avatars.githubusercontent.com/u/1770201?v=3","gravatar_id":"","url":"https://api.github.com/users/polevaultweb","html_url":"https://github.com/polevaultweb","followers_url":"https://api.github.com/users/polevaultweb/followers","following_url":"https://api.github.com/users/polevaultweb/following{/other_user}","gists_url":"https://api.github.com/users/polevaultweb/gists{/gist_id}","starred_url":"https://api.github.com/users/polevaultweb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/polevaultweb/subscriptions","organizations_url":"https://api.github.com/users/polevaultweb/orgs","repos_url":"https://api.github.com/users/polevaultweb/repos","events_url":"https://api.github.com/users/polevaultweb/events{/privacy}","received_events_url":"https://api.github.com/users/polevaultweb/received_events","type":"User","site_admin":false},"body":"Yep agreed, pushed fix","created_at":"2014-11-07T14:50:53Z","updated_at":"2014-11-07T14:50:53Z","html_url":"https://github.com/deliciousbrains/wp-amazon-s3-and-cloudfront/pull/147#discussion_r20013628","pull_request_url":"https://api.github.com/repos/deliciousbrains/wp-amazon-s3-and-cloudfront/pulls/147","_links":{"self":{"href":"https://api.github.com/repos/deliciousbrains/wp-amazon-s3-and-cloudfront/pulls/comments/20013628"},"html":{"href":"https://github.com/deliciousbrains/wp-amazon-s3-and-cloudfront/pull/147#discussion_r20013628"},"pull_request":{"href":"https://api.github.com/repos/deliciousbrains/wp-amazon-s3-and-cloudfront/pulls/147"}}},"pull_request":{"url":"https://api.github.com/repos/deliciousbrains/wp-amazon-s3-and-cloudfront/pulls/147","id":24009807,"html_url":"https://github.com/deliciousbrains/wp-amazon-s3-and-cloudfront/pull/147","diff_url":"https://github.com/deliciousbrains/wp-amazon-s3-and-cloudfront/pull/147.diff","patch_url":"https://github.com/deliciousbrains/wp-amazon-s3-and-cloudfront/pull/147.patch","issue_url":"https://api.github.com/repos/deliciousbrains/wp-amazon-s3-and-cloudfront/issues/147","number":147,"state":"open","locked":false,"title":"Private acl object support","user":{"login":"polevaultweb","id":1770201,"avatar_url":"https://avatars.githubusercontent.com/u/1770201?v=3","gravatar_id":"","url":"https://api.github.com/users/polevaultweb","html_url":"https://github.com/polevaultweb","followers_url":"https://api.github.com/users/polevaultweb/followers","following_url":"https://api.github.com/users/polevaultweb/following{/other_user}","gists_url":"https://api.github.com/users/polevaultweb/gists{/gist_id}","starred_url":"https://api.github.com/users/polevaultweb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/polevaultweb/subscriptions","organizations_url":"https://api.github.com/users/polevaultweb/orgs","repos_url":"https://api.github.com/users/polevaultweb/repos","events_url":"https://api.github.com/users/polevaultweb/events{/privacy}","received_events_url":"https://api.github.com/users/polevaultweb/received_events","type":"User","site_admin":false},"body":"Resolves #146 ","created_at":"2014-11-06T20:25:44Z","updated_at":"2014-11-07T14:50:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"16eb10188a1f73ac35159e5921f5bb5df6255c9e","assignee":null,"milestone":{"url":"https://api.github.com/repos/deliciousbrains/wp-amazon-s3-and-cloudfront/milestones/2","labels_url":"https://api.github.com/repos/deliciousbrains/wp-amazon-s3-and-cloudfront/milestones/2/labels","id":445840,"number":2,"title":"0.6.2 (develop branch)","description":"","creator":{"login":"bradt","id":190095,"avatar_url":"https://avatars.githubusercontent.com/u/190095?v=3","gravatar_id":"","url":"https://api.github.com/users/bradt","html_url":"https://github.com/bradt","followers_url":"https://api.github.com/users/bradt/followers","following_url":"https://api.github.com/users/bradt/following{/other_user}","gists_url":"https://api.github.com/users/bradt/gists{/gist_id}","starred_url":"https://api.github.com/users/bradt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradt/subscriptions","organizations_url":"https://api.github.com/users/bradt/orgs","repos_url":"https://api.github.com/users/bradt/repos","events_url":"https://api.github.com/users/bradt/events{/privacy}","received_events_url":"https://api.github.com/users/bradt/received_events","type":"User","site_admin":false},"open_issues":12,"closed_issues":62,"state":"open","created_at":"2013-10-04T17:27:03Z","updated_at":"2014-11-07T12:52:17Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/deliciousbrains/wp-amazon-s3-and-cloudfront/pulls/147/commits","review_comments_url":"https://api.github.com/repos/deliciousbrains/wp-amazon-s3-and-cloudfront/pulls/147/comments","review_comment_url":"https://api.github.com/repos/deliciousbrains/wp-amazon-s3-and-cloudfront/pulls/comments/{number}","comments_url":"https://api.github.com/repos/deliciousbrains/wp-amazon-s3-and-cloudfront/issues/147/comments","statuses_url":"https://api.github.com/repos/deliciousbrains/wp-amazon-s3-and-cloudfront/statuses/81f202d1df75696d4e599bb3a997a8aeb0936592","head":{"label":"deliciousbrains:private-acl-object-support","ref":"private-acl-object-support","sha":"81f202d1df75696d4e599bb3a997a8aeb0936592","user":{"login":"deliciousbrains","id":3844035,"avatar_url":"https://avatars.githubusercontent.com/u/3844035?v=3","gravatar_id":"","url":"https://api.github.com/users/deliciousbrains","html_url":"https://github.com/deliciousbrains","followers_url":"https://api.github.com/users/deliciousbrains/followers","following_url":"https://api.github.com/users/deliciousbrains/following{/other_user}","gists_url":"https://api.github.com/users/deliciousbrains/gists{/gist_id}","starred_url":"https://api.github.com/users/deliciousbrains/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deliciousbrains/subscriptions","organizations_url":"https://api.github.com/users/deliciousbrains/orgs","repos_url":"https://api.github.com/users/deliciousbrains/repos","events_url":"https://api.github.com/users/deliciousbrains/events{/privacy}","received_events_url":"https://api.github.com/users/deliciousbrains/received_events","type":"Organization","site_admin":false},"repo":{"id":5677202,"name":"wp-amazon-s3-and-cloudfront","full_name":"deliciousbrains/wp-amazon-s3-and-cloudfront","owner":{"login":"deliciousbrains","id":3844035,"avatar_url":"https://avatars.githubusercontent.com/u/3844035?v=3","gravatar_id":"","url":"https://api.github.com/users/deliciousbrains","html_url":"https://github.com/deliciousbrains","followers_url":"https://api.github.com/users/deliciousbrains/followers","following_url":"https://api.github.com/users/deliciousbrains/following{/other_user}","gists_url":"https://api.github.com/users/deliciousbrains/gists{/gist_id}","starred_url":"https://api.github.com/users/deliciousbrains/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deliciousbrains/subscriptions","organizations_url":"https://api.github.com/users/deliciousbrains/orgs","repos_url":"https://api.github.com/users/deliciousbrains/repos","events_url":"https://api.github.com/users/deliciousbrains/events{/privacy}","received_events_url":"https://api.github.com/users/deliciousbrains/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/deliciousbrains/wp-amazon-s3-and-cloudfront","description":"Automatically copies media uploads to Amazon S3 for delivery. Optionally configure Amazon CloudFront for even faster delivery.","fork":false,"url":"https://api.github.com/repos/deliciousbrains/wp-amazon-s3-and-cloudfront","forks_url":"https://api.github.com/repos/deliciousbrains/wp-amazon-s3-and-cloudfront/forks","keys_url":"https://api.github.com/repos/deliciousbrains/wp-amazon-s3-and-cloudfront/keys{/key_id}","collaborators_url":"https://api.github.com/repos/deliciousbrains/wp-amazon-s3-and-cloudfront/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/deliciousbrains/wp-amazon-s3-and-cloudfront/teams","hooks_url":"https://api.github.com/repos/deliciousbrains/wp-amazon-s3-and-cloudfront/hooks","issue_events_url":"https://api.github.com/repos/deliciousbrains/wp-amazon-s3-and-cloudfront/issues/events{/number}","events_url":"https://api.github.com/repos/deliciousbrains/wp-amazon-s3-and-cloudfront/events","assignees_url":"https://api.github.com/repos/deliciousbrains/wp-amazon-s3-and-cloudfront/assignees{/user}","branches_url":"https://api.github.com/repos/deliciousbrains/wp-amazon-s3-and-cloudfront/branches{/branch}","tags_url":"https://api.github.com/repos/deliciousbrains/wp-amazon-s3-and-cloudfront/tags","blobs_url":"https://api.github.com/repos/deliciousbrains/wp-amazon-s3-and-cloudfront/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/deliciousbrains/wp-amazon-s3-and-cloudfront/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/deliciousbrains/wp-amazon-s3-and-cloudfront/git/refs{/sha}","trees_url":"https://api.github.com/repos/deliciousbrains/wp-amazon-s3-and-cloudfront/git/trees{/sha}","statuses_url":"https://api.github.com/repos/deliciousbrains/wp-amazon-s3-and-cloudfront/statuses/{sha}","languages_url":"https://api.github.com/repos/deliciousbrains/wp-amazon-s3-and-cloudfront/languages","stargazers_url":"https://api.github.com/repos/deliciousbrains/wp-amazon-s3-and-cloudfront/stargazers","contributors_url":"https://api.github.com/repos/deliciousbrains/wp-amazon-s3-and-cloudfront/contributors","subscribers_url":"https://api.github.com/repos/deliciousbrains/wp-amazon-s3-and-cloudfront/subscribers","subscription_url":"https://api.github.com/repos/deliciousbrains/wp-amazon-s3-and-cloudfront/subscription","commits_url":"https://api.github.com/repos/deliciousbrains/wp-amazon-s3-and-cloudfront/commits{/sha}","git_commits_url":"https://api.github.com/repos/deliciousbrains/wp-amazon-s3-and-cloudfront/git/commits{/sha}","comments_url":"https://api.github.com/repos/deliciousbrains/wp-amazon-s3-and-cloudfront/comments{/number}","issue_comment_url":"https://api.github.com/repos/deliciousbrains/wp-amazon-s3-and-cloudfront/issues/comments/{number}","contents_url":"https://api.github.com/repos/deliciousbrains/wp-amazon-s3-and-cloudfront/contents/{+path}","compare_url":"https://api.github.com/repos/deliciousbrains/wp-amazon-s3-and-cloudfront/compare/{base}...{head}","merges_url":"https://api.github.com/repos/deliciousbrains/wp-amazon-s3-and-cloudfront/merges","archive_url":"https://api.github.com/repos/deliciousbrains/wp-amazon-s3-and-cloudfront/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/deliciousbrains/wp-amazon-s3-and-cloudfront/downloads","issues_url":"https://api.github.com/repos/deliciousbrains/wp-amazon-s3-and-cloudfront/issues{/number}","pulls_url":"https://api.github.com/repos/deliciousbrains/wp-amazon-s3-and-cloudfront/pulls{/number}","milestones_url":"https://api.github.com/repos/deliciousbrains/wp-amazon-s3-and-cloudfront/milestones{/number}","notifications_url":"https://api.github.com/repos/deliciousbrains/wp-amazon-s3-and-cloudfront/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/deliciousbrains/wp-amazon-s3-and-cloudfront/labels{/name}","releases_url":"https://api.github.com/repos/deliciousbrains/wp-amazon-s3-and-cloudfront/releases{/id}","created_at":"2012-09-04T19:11:26Z","updated_at":"2014-11-06T22:31:03Z","pushed_at":"2014-11-07T14:50:27Z","git_url":"git://github.com/deliciousbrains/wp-amazon-s3-and-cloudfront.git","ssh_url":"git@github.com:deliciousbrains/wp-amazon-s3-and-cloudfront.git","clone_url":"https://github.com/deliciousbrains/wp-amazon-s3-and-cloudfront.git","svn_url":"https://github.com/deliciousbrains/wp-amazon-s3-and-cloudfront","homepage":"","size":1547,"stargazers_count":108,"watchers_count":108,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":38,"mirror_url":null,"open_issues_count":30,"forks":38,"open_issues":30,"watchers":108,"default_branch":"master"}},"base":{"label":"deliciousbrains:develop","ref":"develop","sha":"f30325e7b79351c13d109746feb900f9d5442280","user":{"login":"deliciousbrains","id":3844035,"avatar_url":"https://avatars.githubusercontent.com/u/3844035?v=3","gravatar_id":"","url":"https://api.github.com/users/deliciousbrains","html_url":"https://github.com/deliciousbrains","followers_url":"https://api.github.com/users/deliciousbrains/followers","following_url":"https://api.github.com/users/deliciousbrains/following{/other_user}","gists_url":"https://api.github.com/users/deliciousbrains/gists{/gist_id}","starred_url":"https://api.github.com/users/deliciousbrains/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deliciousbrains/subscriptions","organizations_url":"https://api.github.com/users/deliciousbrains/orgs","repos_url":"https://api.github.com/users/deliciousbrains/repos","events_url":"https://api.github.com/users/deliciousbrains/events{/privacy}","received_events_url":"https://api.github.com/users/deliciousbrains/received_events","type":"Organization","site_admin":false},"repo":{"id":5677202,"name":"wp-amazon-s3-and-cloudfront","full_name":"deliciousbrains/wp-amazon-s3-and-cloudfront","owner":{"login":"deliciousbrains","id":3844035,"avatar_url":"https://avatars.githubusercontent.com/u/3844035?v=3","gravatar_id":"","url":"https://api.github.com/users/deliciousbrains","html_url":"https://github.com/deliciousbrains","followers_url":"https://api.github.com/users/deliciousbrains/followers","following_url":"https://api.github.com/users/deliciousbrains/following{/other_user}","gists_url":"https://api.github.com/users/deliciousbrains/gists{/gist_id}","starred_url":"https://api.github.com/users/deliciousbrains/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deliciousbrains/subscriptions","organizations_url":"https://api.github.com/users/deliciousbrains/orgs","repos_url":"https://api.github.com/users/deliciousbrains/repos","events_url":"https://api.github.com/users/deliciousbrains/events{/privacy}","received_events_url":"https://api.github.com/users/deliciousbrains/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/deliciousbrains/wp-amazon-s3-and-cloudfront","description":"Automatically copies media uploads to Amazon S3 for delivery. Optionally configure Amazon CloudFront for even faster delivery.","fork":false,"url":"https://api.github.com/repos/deliciousbrains/wp-amazon-s3-and-cloudfront","forks_url":"https://api.github.com/repos/deliciousbrains/wp-amazon-s3-and-cloudfront/forks","keys_url":"https://api.github.com/repos/deliciousbrains/wp-amazon-s3-and-cloudfront/keys{/key_id}","collaborators_url":"https://api.github.com/repos/deliciousbrains/wp-amazon-s3-and-cloudfront/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/deliciousbrains/wp-amazon-s3-and-cloudfront/teams","hooks_url":"https://api.github.com/repos/deliciousbrains/wp-amazon-s3-and-cloudfront/hooks","issue_events_url":"https://api.github.com/repos/deliciousbrains/wp-amazon-s3-and-cloudfront/issues/events{/number}","events_url":"https://api.github.com/repos/deliciousbrains/wp-amazon-s3-and-cloudfront/events","assignees_url":"https://api.github.com/repos/deliciousbrains/wp-amazon-s3-and-cloudfront/assignees{/user}","branches_url":"https://api.github.com/repos/deliciousbrains/wp-amazon-s3-and-cloudfront/branches{/branch}","tags_url":"https://api.github.com/repos/deliciousbrains/wp-amazon-s3-and-cloudfront/tags","blobs_url":"https://api.github.com/repos/deliciousbrains/wp-amazon-s3-and-cloudfront/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/deliciousbrains/wp-amazon-s3-and-cloudfront/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/deliciousbrains/wp-amazon-s3-and-cloudfront/git/refs{/sha}","trees_url":"https://api.github.com/repos/deliciousbrains/wp-amazon-s3-and-cloudfront/git/trees{/sha}","statuses_url":"https://api.github.com/repos/deliciousbrains/wp-amazon-s3-and-cloudfront/statuses/{sha}","languages_url":"https://api.github.com/repos/deliciousbrains/wp-amazon-s3-and-cloudfront/languages","stargazers_url":"https://api.github.com/repos/deliciousbrains/wp-amazon-s3-and-cloudfront/stargazers","contributors_url":"https://api.github.com/repos/deliciousbrains/wp-amazon-s3-and-cloudfront/contributors","subscribers_url":"https://api.github.com/repos/deliciousbrains/wp-amazon-s3-and-cloudfront/subscribers","subscription_url":"https://api.github.com/repos/deliciousbrains/wp-amazon-s3-and-cloudfront/subscription","commits_url":"https://api.github.com/repos/deliciousbrains/wp-amazon-s3-and-cloudfront/commits{/sha}","git_commits_url":"https://api.github.com/repos/deliciousbrains/wp-amazon-s3-and-cloudfront/git/commits{/sha}","comments_url":"https://api.github.com/repos/deliciousbrains/wp-amazon-s3-and-cloudfront/comments{/number}","issue_comment_url":"https://api.github.com/repos/deliciousbrains/wp-amazon-s3-and-cloudfront/issues/comments/{number}","contents_url":"https://api.github.com/repos/deliciousbrains/wp-amazon-s3-and-cloudfront/contents/{+path}","compare_url":"https://api.github.com/repos/deliciousbrains/wp-amazon-s3-and-cloudfront/compare/{base}...{head}","merges_url":"https://api.github.com/repos/deliciousbrains/wp-amazon-s3-and-cloudfront/merges","archive_url":"https://api.github.com/repos/deliciousbrains/wp-amazon-s3-and-cloudfront/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/deliciousbrains/wp-amazon-s3-and-cloudfront/downloads","issues_url":"https://api.github.com/repos/deliciousbrains/wp-amazon-s3-and-cloudfront/issues{/number}","pulls_url":"https://api.github.com/repos/deliciousbrains/wp-amazon-s3-and-cloudfront/pulls{/number}","milestones_url":"https://api.github.com/repos/deliciousbrains/wp-amazon-s3-and-cloudfront/milestones{/number}","notifications_url":"https://api.github.com/repos/deliciousbrains/wp-amazon-s3-and-cloudfront/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/deliciousbrains/wp-amazon-s3-and-cloudfront/labels{/name}","releases_url":"https://api.github.com/repos/deliciousbrains/wp-amazon-s3-and-cloudfront/releases{/id}","created_at":"2012-09-04T19:11:26Z","updated_at":"2014-11-06T22:31:03Z","pushed_at":"2014-11-07T14:50:27Z","git_url":"git://github.com/deliciousbrains/wp-amazon-s3-and-cloudfront.git","ssh_url":"git@github.com:deliciousbrains/wp-amazon-s3-and-cloudfront.git","clone_url":"https://github.com/deliciousbrains/wp-amazon-s3-and-cloudfront.git","svn_url":"https://github.com/deliciousbrains/wp-amazon-s3-and-cloudfront","homepage":"","size":1547,"stargazers_count":108,"watchers_count":108,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":38,"mirror_url":null,"open_issues_count":30,"forks":38,"open_issues":30,"watchers":108,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/deliciousbrains/wp-amazon-s3-and-cloudfront/pulls/147"},"html":{"href":"https://github.com/deliciousbrains/wp-amazon-s3-and-cloudfront/pull/147"},"issue":{"href":"https://api.github.com/repos/deliciousbrains/wp-amazon-s3-and-cloudfront/issues/147"},"comments":{"href":"https://api.github.com/repos/deliciousbrains/wp-amazon-s3-and-cloudfront/issues/147/comments"},"review_comments":{"href":"https://api.github.com/repos/deliciousbrains/wp-amazon-s3-and-cloudfront/pulls/147/comments"},"review_comment":{"href":"https://api.github.com/repos/deliciousbrains/wp-amazon-s3-and-cloudfront/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/deliciousbrains/wp-amazon-s3-and-cloudfront/pulls/147/commits"},"statuses":{"href":"https://api.github.com/repos/deliciousbrains/wp-amazon-s3-and-cloudfront/statuses/81f202d1df75696d4e599bb3a997a8aeb0936592"}}}}