GitHub PullRequestReviewCommentEvent at 2014-10-16 02:52:42
Repository: localdata-tiles
Actor: hampelm
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/LocalData/localdata-tiles/pulls/comments/18935939","id":18935939,"diff_hunk":"@@ -128,22 +126,47 @@ module.exports = function setup(options) {\n         };\n         headers[S3_CUSTOM_CACHE_HEADER] = res.getHeader(S3_CUSTOM_CACHE_HEADER);\n         var buffer = new Buffer(body);\n+\n+        handleS3Error = function handleS3Error(error) {\n+          console.log('warning at=s3_cache issue=save_failure name=' + name);\n+          console.log(error);\n+          saveMetric.miss();\n+        };\n+\n         s3client.putBuffer(buffer, name, headers, function (error, res) {","path":"lib/s3-cache.js","position":49,"original_position":49,"commit_id":"155ed1a07c6a08601063f2eb8a0fc6d82b4bb2f2","original_commit_id":"155ed1a07c6a08601063f2eb8a0fc6d82b4bb2f2","user":{"login":"hampelm","id":86435,"avatar_url":"https://avatars.githubusercontent.com/u/86435?v=2","gravatar_id":"","url":"https://api.github.com/users/hampelm","html_url":"https://github.com/hampelm","followers_url":"https://api.github.com/users/hampelm/followers","following_url":"https://api.github.com/users/hampelm/following{/other_user}","gists_url":"https://api.github.com/users/hampelm/gists{/gist_id}","starred_url":"https://api.github.com/users/hampelm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hampelm/subscriptions","organizations_url":"https://api.github.com/users/hampelm/orgs","repos_url":"https://api.github.com/users/hampelm/repos","events_url":"https://api.github.com/users/hampelm/events{/privacy}","received_events_url":"https://api.github.com/users/hampelm/received_events","type":"User","site_admin":false},"body":"For readability, would it make sense to define in the callback for `putBuffer` outside of `handleRender`? `handleRender` is not overly large yet, but it's starting to grow. ","created_at":"2014-10-16T02:52:42Z","updated_at":"2014-10-16T02:52:42Z","html_url":"https://github.com/LocalData/localdata-tiles/pull/116#discussion_r18935939","pull_request_url":"https://api.github.com/repos/LocalData/localdata-tiles/pulls/116","_links":{"self":{"href":"https://api.github.com/repos/LocalData/localdata-tiles/pulls/comments/18935939"},"html":{"href":"https://github.com/LocalData/localdata-tiles/pull/116#discussion_r18935939"},"pull_request":{"href":"https://api.github.com/repos/LocalData/localdata-tiles/pulls/116"}}},"pull_request":{"url":"https://api.github.com/repos/LocalData/localdata-tiles/pulls/116","id":22827558,"html_url":"https://github.com/LocalData/localdata-tiles/pull/116","diff_url":"https://github.com/LocalData/localdata-tiles/pull/116.diff","patch_url":"https://github.com/LocalData/localdata-tiles/pull/116.patch","issue_url":"https://api.github.com/repos/LocalData/localdata-tiles/issues/116","number":116,"state":"open","locked":false,"title":"Interpret S3 response details properly","user":{"login":"prashtx","id":1307783,"avatar_url":"https://avatars.githubusercontent.com/u/1307783?v=2","gravatar_id":"","url":"https://api.github.com/users/prashtx","html_url":"https://github.com/prashtx","followers_url":"https://api.github.com/users/prashtx/followers","following_url":"https://api.github.com/users/prashtx/following{/other_user}","gists_url":"https://api.github.com/users/prashtx/gists{/gist_id}","starred_url":"https://api.github.com/users/prashtx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prashtx/subscriptions","organizations_url":"https://api.github.com/users/prashtx/orgs","repos_url":"https://api.github.com/users/prashtx/repos","events_url":"https://api.github.com/users/prashtx/events{/privacy}","received_events_url":"https://api.github.com/users/prashtx/received_events","type":"User","site_admin":false},"body":"If we get a response with a non-200 status code, interpret it as a failed save and log something useful. Also use heroku-style key=value logging.\r\n\r\n/cc @hampelm \r\n","created_at":"2014-10-16T01:36:43Z","updated_at":"2014-10-16T02:52:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e61ea289c874e6a11ab29712a1b150a70f5525b1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/LocalData/localdata-tiles/pulls/116/commits","review_comments_url":"https://api.github.com/repos/LocalData/localdata-tiles/pulls/116/comments","review_comment_url":"https://api.github.com/repos/LocalData/localdata-tiles/pulls/comments/{number}","comments_url":"https://api.github.com/repos/LocalData/localdata-tiles/issues/116/comments","statuses_url":"https://api.github.com/repos/LocalData/localdata-tiles/statuses/155ed1a07c6a08601063f2eb8a0fc6d82b4bb2f2","head":{"label":"LocalData:cache-response","ref":"cache-response","sha":"155ed1a07c6a08601063f2eb8a0fc6d82b4bb2f2","user":{"login":"LocalData","id":2413672,"avatar_url":"https://avatars.githubusercontent.com/u/2413672?v=2","gravatar_id":"","url":"https://api.github.com/users/LocalData","html_url":"https://github.com/LocalData","followers_url":"https://api.github.com/users/LocalData/followers","following_url":"https://api.github.com/users/LocalData/following{/other_user}","gists_url":"https://api.github.com/users/LocalData/gists{/gist_id}","starred_url":"https://api.github.com/users/LocalData/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LocalData/subscriptions","organizations_url":"https://api.github.com/users/LocalData/orgs","repos_url":"https://api.github.com/users/LocalData/repos","events_url":"https://api.github.com/users/LocalData/events{/privacy}","received_events_url":"https://api.github.com/users/LocalData/received_events","type":"Organization","site_admin":false},"repo":{"id":8112143,"name":"localdata-tiles","full_name":"LocalData/localdata-tiles","owner":{"login":"LocalData","id":2413672,"avatar_url":"https://avatars.githubusercontent.com/u/2413672?v=2","gravatar_id":"","url":"https://api.github.com/users/LocalData","html_url":"https://github.com/LocalData","followers_url":"https://api.github.com/users/LocalData/followers","following_url":"https://api.github.com/users/LocalData/following{/other_user}","gists_url":"https://api.github.com/users/LocalData/gists{/gist_id}","starred_url":"https://api.github.com/users/LocalData/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LocalData/subscriptions","organizations_url":"https://api.github.com/users/LocalData/orgs","repos_url":"https://api.github.com/users/LocalData/repos","events_url":"https://api.github.com/users/LocalData/events{/privacy}","received_events_url":"https://api.github.com/users/LocalData/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LocalData/localdata-tiles","description":"A tileserver for LocalData","fork":false,"url":"https://api.github.com/repos/LocalData/localdata-tiles","forks_url":"https://api.github.com/repos/LocalData/localdata-tiles/forks","keys_url":"https://api.github.com/repos/LocalData/localdata-tiles/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LocalData/localdata-tiles/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LocalData/localdata-tiles/teams","hooks_url":"https://api.github.com/repos/LocalData/localdata-tiles/hooks","issue_events_url":"https://api.github.com/repos/LocalData/localdata-tiles/issues/events{/number}","events_url":"https://api.github.com/repos/LocalData/localdata-tiles/events","assignees_url":"https://api.github.com/repos/LocalData/localdata-tiles/assignees{/user}","branches_url":"https://api.github.com/repos/LocalData/localdata-tiles/branches{/branch}","tags_url":"https://api.github.com/repos/LocalData/localdata-tiles/tags","blobs_url":"https://api.github.com/repos/LocalData/localdata-tiles/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LocalData/localdata-tiles/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LocalData/localdata-tiles/git/refs{/sha}","trees_url":"https://api.github.com/repos/LocalData/localdata-tiles/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LocalData/localdata-tiles/statuses/{sha}","languages_url":"https://api.github.com/repos/LocalData/localdata-tiles/languages","stargazers_url":"https://api.github.com/repos/LocalData/localdata-tiles/stargazers","contributors_url":"https://api.github.com/repos/LocalData/localdata-tiles/contributors","subscribers_url":"https://api.github.com/repos/LocalData/localdata-tiles/subscribers","subscription_url":"https://api.github.com/repos/LocalData/localdata-tiles/subscription","commits_url":"https://api.github.com/repos/LocalData/localdata-tiles/commits{/sha}","git_commits_url":"https://api.github.com/repos/LocalData/localdata-tiles/git/commits{/sha}","comments_url":"https://api.github.com/repos/LocalData/localdata-tiles/comments{/number}","issue_comment_url":"https://api.github.com/repos/LocalData/localdata-tiles/issues/comments/{number}","contents_url":"https://api.github.com/repos/LocalData/localdata-tiles/contents/{+path}","compare_url":"https://api.github.com/repos/LocalData/localdata-tiles/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LocalData/localdata-tiles/merges","archive_url":"https://api.github.com/repos/LocalData/localdata-tiles/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LocalData/localdata-tiles/downloads","issues_url":"https://api.github.com/repos/LocalData/localdata-tiles/issues{/number}","pulls_url":"https://api.github.com/repos/LocalData/localdata-tiles/pulls{/number}","milestones_url":"https://api.github.com/repos/LocalData/localdata-tiles/milestones{/number}","notifications_url":"https://api.github.com/repos/LocalData/localdata-tiles/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LocalData/localdata-tiles/labels{/name}","releases_url":"https://api.github.com/repos/LocalData/localdata-tiles/releases{/id}","created_at":"2013-02-09T17:13:15Z","updated_at":"2014-09-06T01:04:21Z","pushed_at":"2014-10-16T01:35:24Z","git_url":"git://github.com/LocalData/localdata-tiles.git","ssh_url":"git@github.com:LocalData/localdata-tiles.git","clone_url":"https://github.com/LocalData/localdata-tiles.git","svn_url":"https://github.com/LocalData/localdata-tiles","homepage":"","size":2692,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":38,"forks":2,"open_issues":38,"watchers":4,"default_branch":"master"}},"base":{"label":"LocalData:master","ref":"master","sha":"8ff7d31d4b010c5b0cc851c23ee9bfd5c2d42e2d","user":{"login":"LocalData","id":2413672,"avatar_url":"https://avatars.githubusercontent.com/u/2413672?v=2","gravatar_id":"","url":"https://api.github.com/users/LocalData","html_url":"https://github.com/LocalData","followers_url":"https://api.github.com/users/LocalData/followers","following_url":"https://api.github.com/users/LocalData/following{/other_user}","gists_url":"https://api.github.com/users/LocalData/gists{/gist_id}","starred_url":"https://api.github.com/users/LocalData/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LocalData/subscriptions","organizations_url":"https://api.github.com/users/LocalData/orgs","repos_url":"https://api.github.com/users/LocalData/repos","events_url":"https://api.github.com/users/LocalData/events{/privacy}","received_events_url":"https://api.github.com/users/LocalData/received_events","type":"Organization","site_admin":false},"repo":{"id":8112143,"name":"localdata-tiles","full_name":"LocalData/localdata-tiles","owner":{"login":"LocalData","id":2413672,"avatar_url":"https://avatars.githubusercontent.com/u/2413672?v=2","gravatar_id":"","url":"https://api.github.com/users/LocalData","html_url":"https://github.com/LocalData","followers_url":"https://api.github.com/users/LocalData/followers","following_url":"https://api.github.com/users/LocalData/following{/other_user}","gists_url":"https://api.github.com/users/LocalData/gists{/gist_id}","starred_url":"https://api.github.com/users/LocalData/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LocalData/subscriptions","organizations_url":"https://api.github.com/users/LocalData/orgs","repos_url":"https://api.github.com/users/LocalData/repos","events_url":"https://api.github.com/users/LocalData/events{/privacy}","received_events_url":"https://api.github.com/users/LocalData/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LocalData/localdata-tiles","description":"A tileserver for LocalData","fork":false,"url":"https://api.github.com/repos/LocalData/localdata-tiles","forks_url":"https://api.github.com/repos/LocalData/localdata-tiles/forks","keys_url":"https://api.github.com/repos/LocalData/localdata-tiles/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LocalData/localdata-tiles/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LocalData/localdata-tiles/teams","hooks_url":"https://api.github.com/repos/LocalData/localdata-tiles/hooks","issue_events_url":"https://api.github.com/repos/LocalData/localdata-tiles/issues/events{/number}","events_url":"https://api.github.com/repos/LocalData/localdata-tiles/events","assignees_url":"https://api.github.com/repos/LocalData/localdata-tiles/assignees{/user}","branches_url":"https://api.github.com/repos/LocalData/localdata-tiles/branches{/branch}","tags_url":"https://api.github.com/repos/LocalData/localdata-tiles/tags","blobs_url":"https://api.github.com/repos/LocalData/localdata-tiles/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LocalData/localdata-tiles/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LocalData/localdata-tiles/git/refs{/sha}","trees_url":"https://api.github.com/repos/LocalData/localdata-tiles/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LocalData/localdata-tiles/statuses/{sha}","languages_url":"https://api.github.com/repos/LocalData/localdata-tiles/languages","stargazers_url":"https://api.github.com/repos/LocalData/localdata-tiles/stargazers","contributors_url":"https://api.github.com/repos/LocalData/localdata-tiles/contributors","subscribers_url":"https://api.github.com/repos/LocalData/localdata-tiles/subscribers","subscription_url":"https://api.github.com/repos/LocalData/localdata-tiles/subscription","commits_url":"https://api.github.com/repos/LocalData/localdata-tiles/commits{/sha}","git_commits_url":"https://api.github.com/repos/LocalData/localdata-tiles/git/commits{/sha}","comments_url":"https://api.github.com/repos/LocalData/localdata-tiles/comments{/number}","issue_comment_url":"https://api.github.com/repos/LocalData/localdata-tiles/issues/comments/{number}","contents_url":"https://api.github.com/repos/LocalData/localdata-tiles/contents/{+path}","compare_url":"https://api.github.com/repos/LocalData/localdata-tiles/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LocalData/localdata-tiles/merges","archive_url":"https://api.github.com/repos/LocalData/localdata-tiles/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LocalData/localdata-tiles/downloads","issues_url":"https://api.github.com/repos/LocalData/localdata-tiles/issues{/number}","pulls_url":"https://api.github.com/repos/LocalData/localdata-tiles/pulls{/number}","milestones_url":"https://api.github.com/repos/LocalData/localdata-tiles/milestones{/number}","notifications_url":"https://api.github.com/repos/LocalData/localdata-tiles/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LocalData/localdata-tiles/labels{/name}","releases_url":"https://api.github.com/repos/LocalData/localdata-tiles/releases{/id}","created_at":"2013-02-09T17:13:15Z","updated_at":"2014-09-06T01:04:21Z","pushed_at":"2014-10-16T01:35:24Z","git_url":"git://github.com/LocalData/localdata-tiles.git","ssh_url":"git@github.com:LocalData/localdata-tiles.git","clone_url":"https://github.com/LocalData/localdata-tiles.git","svn_url":"https://github.com/LocalData/localdata-tiles","homepage":"","size":2692,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":38,"forks":2,"open_issues":38,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/LocalData/localdata-tiles/pulls/116"},"html":{"href":"https://github.com/LocalData/localdata-tiles/pull/116"},"issue":{"href":"https://api.github.com/repos/LocalData/localdata-tiles/issues/116"},"comments":{"href":"https://api.github.com/repos/LocalData/localdata-tiles/issues/116/comments"},"review_comments":{"href":"https://api.github.com/repos/LocalData/localdata-tiles/pulls/116/comments"},"review_comment":{"href":"https://api.github.com/repos/LocalData/localdata-tiles/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/LocalData/localdata-tiles/pulls/116/commits"},"statuses":{"href":"https://api.github.com/repos/LocalData/localdata-tiles/statuses/155ed1a07c6a08601063f2eb8a0fc6d82b4bb2f2"}}}}