GitHub PullRequestReviewCommentEvent at 2014-07-21 16:49:16
Repository: rhq
Actor: Jiri-Kremser
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/rhq-project/rhq/pulls/comments/15180153","id":15180153,"diff_hunk":"@@ -331,6 +331,8 @@\n         + \"                 ) \" //\n         + \"     ) \" //\n         + \"  ) \";\n+    \n+    public static final String ADHOC_SEPARATOR = \"@@stImprobable@@\";","path":"modules/core/domain/src/main/java/org/rhq/core/domain/alert/AlertCondition.java","position":5,"original_position":5,"commit_id":"2cf72473047a8c0f8088313bbfb41c043bdd9f02","original_commit_id":"2cf72473047a8c0f8088313bbfb41c043bdd9f02","user":{"login":"Jiri-Kremser","id":535866,"avatar_url":"https://avatars.githubusercontent.com/u/535866?","gravatar_id":"d8b0d9cdd77d0b6b9765d45fdf80632c","url":"https://api.github.com/users/Jiri-Kremser","html_url":"https://github.com/Jiri-Kremser","followers_url":"https://api.github.com/users/Jiri-Kremser/followers","following_url":"https://api.github.com/users/Jiri-Kremser/following{/other_user}","gists_url":"https://api.github.com/users/Jiri-Kremser/gists{/gist_id}","starred_url":"https://api.github.com/users/Jiri-Kremser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jiri-Kremser/subscriptions","organizations_url":"https://api.github.com/users/Jiri-Kremser/orgs","repos_url":"https://api.github.com/users/Jiri-Kremser/repos","events_url":"https://api.github.com/users/Jiri-Kremser/events{/privacy}","received_events_url":"https://api.github.com/users/Jiri-Kremser/received_events","type":"User","site_admin":false},"body":"I admit this is quite hacky. But the `AlertCondition` class is a general container for all types of alert conditions and there was no additional String field (same in the db layer). This way we are exploiting the `option` field to carry two pieces of information a) regexp for event details b) regexp for event source location","created_at":"2014-07-21T16:49:16Z","updated_at":"2014-07-21T16:49:16Z","html_url":"https://github.com/rhq-project/rhq/pull/94#discussion_r15180153","pull_request_url":"https://api.github.com/repos/rhq-project/rhq/pulls/94","_links":{"self":{"href":"https://api.github.com/repos/rhq-project/rhq/pulls/comments/15180153"},"html":{"href":"https://github.com/rhq-project/rhq/pull/94#discussion_r15180153"},"pull_request":{"href":"https://api.github.com/repos/rhq-project/rhq/pulls/94"}}},"pull_request":{"url":"https://api.github.com/repos/rhq-project/rhq/pulls/94","id":18665154,"html_url":"https://github.com/rhq-project/rhq/pull/94","diff_url":"https://github.com/rhq-project/rhq/pull/94.diff","patch_url":"https://github.com/rhq-project/rhq/pull/94.patch","issue_url":"https://api.github.com/repos/rhq-project/rhq/issues/94","number":94,"state":"open","title":"BZ911432 + BZ1070257","user":{"login":"Jiri-Kremser","id":535866,"avatar_url":"https://avatars.githubusercontent.com/u/535866?","gravatar_id":"d8b0d9cdd77d0b6b9765d45fdf80632c","url":"https://api.github.com/users/Jiri-Kremser","html_url":"https://github.com/Jiri-Kremser","followers_url":"https://api.github.com/users/Jiri-Kremser/followers","following_url":"https://api.github.com/users/Jiri-Kremser/following{/other_user}","gists_url":"https://api.github.com/users/Jiri-Kremser/gists{/gist_id}","starred_url":"https://api.github.com/users/Jiri-Kremser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jiri-Kremser/subscriptions","organizations_url":"https://api.github.com/users/Jiri-Kremser/orgs","repos_url":"https://api.github.com/users/Jiri-Kremser/repos","events_url":"https://api.github.com/users/Jiri-Kremser/events{/privacy}","received_events_url":"https://api.github.com/users/Jiri-Kremser/received_events","type":"User","site_admin":false},"body":"Adding a way to fire an alert condition only on those events whose source location match some regular expression. Because a managed resource can have multiple log files, this way we can distinguish among them.\r\n\r\nAs a side effect I had to increase the size of the `RHQ_ALERT_CONDITION_LOG` db column which is what the `BZ1070257` wants.","created_at":"2014-07-21T16:45:52Z","updated_at":"2014-07-21T16:49:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"11b26d31a0947e2f4d8abdfc06b40e6702a73d3e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rhq-project/rhq/pulls/94/commits","review_comments_url":"https://api.github.com/repos/rhq-project/rhq/pulls/94/comments","review_comment_url":"https://api.github.com/repos/rhq-project/rhq/pulls/comments/{number}","comments_url":"https://api.github.com/repos/rhq-project/rhq/issues/94/comments","statuses_url":"https://api.github.com/repos/rhq-project/rhq/statuses/2cf72473047a8c0f8088313bbfb41c043bdd9f02","head":{"label":"Jiri-Kremser:BZ911432+BZ1070257","ref":"BZ911432+BZ1070257","sha":"2cf72473047a8c0f8088313bbfb41c043bdd9f02","user":{"login":"Jiri-Kremser","id":535866,"avatar_url":"https://avatars.githubusercontent.com/u/535866?","gravatar_id":"d8b0d9cdd77d0b6b9765d45fdf80632c","url":"https://api.github.com/users/Jiri-Kremser","html_url":"https://github.com/Jiri-Kremser","followers_url":"https://api.github.com/users/Jiri-Kremser/followers","following_url":"https://api.github.com/users/Jiri-Kremser/following{/other_user}","gists_url":"https://api.github.com/users/Jiri-Kremser/gists{/gist_id}","starred_url":"https://api.github.com/users/Jiri-Kremser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jiri-Kremser/subscriptions","organizations_url":"https://api.github.com/users/Jiri-Kremser/orgs","repos_url":"https://api.github.com/users/Jiri-Kremser/repos","events_url":"https://api.github.com/users/Jiri-Kremser/events{/privacy}","received_events_url":"https://api.github.com/users/Jiri-Kremser/received_events","type":"User","site_admin":false},"repo":{"id":17287477,"name":"rhq","full_name":"Jiri-Kremser/rhq","owner":{"login":"Jiri-Kremser","id":535866,"avatar_url":"https://avatars.githubusercontent.com/u/535866?","gravatar_id":"d8b0d9cdd77d0b6b9765d45fdf80632c","url":"https://api.github.com/users/Jiri-Kremser","html_url":"https://github.com/Jiri-Kremser","followers_url":"https://api.github.com/users/Jiri-Kremser/followers","following_url":"https://api.github.com/users/Jiri-Kremser/following{/other_user}","gists_url":"https://api.github.com/users/Jiri-Kremser/gists{/gist_id}","starred_url":"https://api.github.com/users/Jiri-Kremser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jiri-Kremser/subscriptions","organizations_url":"https://api.github.com/users/Jiri-Kremser/orgs","repos_url":"https://api.github.com/users/Jiri-Kremser/repos","events_url":"https://api.github.com/users/Jiri-Kremser/events{/privacy}","received_events_url":"https://api.github.com/users/Jiri-Kremser/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Jiri-Kremser/rhq","description":"RHQ system management and monitoring framework","fork":true,"url":"https://api.github.com/repos/Jiri-Kremser/rhq","forks_url":"https://api.github.com/repos/Jiri-Kremser/rhq/forks","keys_url":"https://api.github.com/repos/Jiri-Kremser/rhq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Jiri-Kremser/rhq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Jiri-Kremser/rhq/teams","hooks_url":"https://api.github.com/repos/Jiri-Kremser/rhq/hooks","issue_events_url":"https://api.github.com/repos/Jiri-Kremser/rhq/issues/events{/number}","events_url":"https://api.github.com/repos/Jiri-Kremser/rhq/events","assignees_url":"https://api.github.com/repos/Jiri-Kremser/rhq/assignees{/user}","branches_url":"https://api.github.com/repos/Jiri-Kremser/rhq/branches{/branch}","tags_url":"https://api.github.com/repos/Jiri-Kremser/rhq/tags","blobs_url":"https://api.github.com/repos/Jiri-Kremser/rhq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Jiri-Kremser/rhq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Jiri-Kremser/rhq/git/refs{/sha}","trees_url":"https://api.github.com/repos/Jiri-Kremser/rhq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Jiri-Kremser/rhq/statuses/{sha}","languages_url":"https://api.github.com/repos/Jiri-Kremser/rhq/languages","stargazers_url":"https://api.github.com/repos/Jiri-Kremser/rhq/stargazers","contributors_url":"https://api.github.com/repos/Jiri-Kremser/rhq/contributors","subscribers_url":"https://api.github.com/repos/Jiri-Kremser/rhq/subscribers","subscription_url":"https://api.github.com/repos/Jiri-Kremser/rhq/subscription","commits_url":"https://api.github.com/repos/Jiri-Kremser/rhq/commits{/sha}","git_commits_url":"https://api.github.com/repos/Jiri-Kremser/rhq/git/commits{/sha}","comments_url":"https://api.github.com/repos/Jiri-Kremser/rhq/comments{/number}","issue_comment_url":"https://api.github.com/repos/Jiri-Kremser/rhq/issues/comments/{number}","contents_url":"https://api.github.com/repos/Jiri-Kremser/rhq/contents/{+path}","compare_url":"https://api.github.com/repos/Jiri-Kremser/rhq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Jiri-Kremser/rhq/merges","archive_url":"https://api.github.com/repos/Jiri-Kremser/rhq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Jiri-Kremser/rhq/downloads","issues_url":"https://api.github.com/repos/Jiri-Kremser/rhq/issues{/number}","pulls_url":"https://api.github.com/repos/Jiri-Kremser/rhq/pulls{/number}","milestones_url":"https://api.github.com/repos/Jiri-Kremser/rhq/milestones{/number}","notifications_url":"https://api.github.com/repos/Jiri-Kremser/rhq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Jiri-Kremser/rhq/labels{/name}","releases_url":"https://api.github.com/repos/Jiri-Kremser/rhq/releases{/id}","created_at":"2014-02-28T13:51:29Z","updated_at":"2014-06-26T22:42:00Z","pushed_at":"2014-07-21T16:36:30Z","git_url":"git://github.com/Jiri-Kremser/rhq.git","ssh_url":"git@github.com:Jiri-Kremser/rhq.git","clone_url":"https://github.com/Jiri-Kremser/rhq.git","svn_url":"https://github.com/Jiri-Kremser/rhq","homepage":"http://jboss.org/rhq","size":115537,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rhq-project:master","ref":"master","sha":"25f82ba15e979ff2b60e7a23b0bbd3583138c2a9","user":{"login":"rhq-project","id":1080166,"avatar_url":"https://avatars.githubusercontent.com/u/1080166?","gravatar_id":"257936c84696897147a945bb59fee2bf","url":"https://api.github.com/users/rhq-project","html_url":"https://github.com/rhq-project","followers_url":"https://api.github.com/users/rhq-project/followers","following_url":"https://api.github.com/users/rhq-project/following{/other_user}","gists_url":"https://api.github.com/users/rhq-project/gists{/gist_id}","starred_url":"https://api.github.com/users/rhq-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhq-project/subscriptions","organizations_url":"https://api.github.com/users/rhq-project/orgs","repos_url":"https://api.github.com/users/rhq-project/repos","events_url":"https://api.github.com/users/rhq-project/events{/privacy}","received_events_url":"https://api.github.com/users/rhq-project/received_events","type":"Organization","site_admin":false},"repo":{"id":17278009,"name":"rhq","full_name":"rhq-project/rhq","owner":{"login":"rhq-project","id":1080166,"avatar_url":"https://avatars.githubusercontent.com/u/1080166?","gravatar_id":"257936c84696897147a945bb59fee2bf","url":"https://api.github.com/users/rhq-project","html_url":"https://github.com/rhq-project","followers_url":"https://api.github.com/users/rhq-project/followers","following_url":"https://api.github.com/users/rhq-project/following{/other_user}","gists_url":"https://api.github.com/users/rhq-project/gists{/gist_id}","starred_url":"https://api.github.com/users/rhq-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhq-project/subscriptions","organizations_url":"https://api.github.com/users/rhq-project/orgs","repos_url":"https://api.github.com/users/rhq-project/repos","events_url":"https://api.github.com/users/rhq-project/events{/privacy}","received_events_url":"https://api.github.com/users/rhq-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rhq-project/rhq","description":"RHQ system management and monitoring framework","fork":false,"url":"https://api.github.com/repos/rhq-project/rhq","forks_url":"https://api.github.com/repos/rhq-project/rhq/forks","keys_url":"https://api.github.com/repos/rhq-project/rhq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rhq-project/rhq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rhq-project/rhq/teams","hooks_url":"https://api.github.com/repos/rhq-project/rhq/hooks","issue_events_url":"https://api.github.com/repos/rhq-project/rhq/issues/events{/number}","events_url":"https://api.github.com/repos/rhq-project/rhq/events","assignees_url":"https://api.github.com/repos/rhq-project/rhq/assignees{/user}","branches_url":"https://api.github.com/repos/rhq-project/rhq/branches{/branch}","tags_url":"https://api.github.com/repos/rhq-project/rhq/tags","blobs_url":"https://api.github.com/repos/rhq-project/rhq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rhq-project/rhq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rhq-project/rhq/git/refs{/sha}","trees_url":"https://api.github.com/repos/rhq-project/rhq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rhq-project/rhq/statuses/{sha}","languages_url":"https://api.github.com/repos/rhq-project/rhq/languages","stargazers_url":"https://api.github.com/repos/rhq-project/rhq/stargazers","contributors_url":"https://api.github.com/repos/rhq-project/rhq/contributors","subscribers_url":"https://api.github.com/repos/rhq-project/rhq/subscribers","subscription_url":"https://api.github.com/repos/rhq-project/rhq/subscription","commits_url":"https://api.github.com/repos/rhq-project/rhq/commits{/sha}","git_commits_url":"https://api.github.com/repos/rhq-project/rhq/git/commits{/sha}","comments_url":"https://api.github.com/repos/rhq-project/rhq/comments{/number}","issue_comment_url":"https://api.github.com/repos/rhq-project/rhq/issues/comments/{number}","contents_url":"https://api.github.com/repos/rhq-project/rhq/contents/{+path}","compare_url":"https://api.github.com/repos/rhq-project/rhq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rhq-project/rhq/merges","archive_url":"https://api.github.com/repos/rhq-project/rhq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rhq-project/rhq/downloads","issues_url":"https://api.github.com/repos/rhq-project/rhq/issues{/number}","pulls_url":"https://api.github.com/repos/rhq-project/rhq/pulls{/number}","milestones_url":"https://api.github.com/repos/rhq-project/rhq/milestones{/number}","notifications_url":"https://api.github.com/repos/rhq-project/rhq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rhq-project/rhq/labels{/name}","releases_url":"https://api.github.com/repos/rhq-project/rhq/releases{/id}","created_at":"2014-02-28T06:54:47Z","updated_at":"2014-06-25T12:29:23Z","pushed_at":"2014-07-19T19:59:33Z","git_url":"git://github.com/rhq-project/rhq.git","ssh_url":"git@github.com:rhq-project/rhq.git","clone_url":"https://github.com/rhq-project/rhq.git","svn_url":"https://github.com/rhq-project/rhq","homepage":"http://jboss.org/rhq","size":411730,"stargazers_count":19,"watchers_count":19,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":25,"mirror_url":null,"open_issues_count":17,"forks":25,"open_issues":17,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rhq-project/rhq/pulls/94"},"html":{"href":"https://github.com/rhq-project/rhq/pull/94"},"issue":{"href":"https://api.github.com/repos/rhq-project/rhq/issues/94"},"comments":{"href":"https://api.github.com/repos/rhq-project/rhq/issues/94/comments"},"review_comments":{"href":"https://api.github.com/repos/rhq-project/rhq/pulls/94/comments"},"review_comment":{"href":"https://api.github.com/repos/rhq-project/rhq/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/rhq-project/rhq/pulls/94/commits"},"statuses":{"href":"https://api.github.com/repos/rhq-project/rhq/statuses/2cf72473047a8c0f8088313bbfb41c043bdd9f02"}}}}