GitHub PullRequestReviewCommentEvent at 2014-10-09 12:22:57
Repository: akka
Actor: bantonsson
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/akka/akka/pulls/comments/18641246","id":18641246,"diff_hunk":"@@ -0,0 +1,283 @@\n+/**\n+ * Copyright (C) 2009-2014 Typesafe Inc. <http://www.typesafe.com>\n+ */\n+package akka.stream.scaladsl2\n+\n+import akka.stream.MaterializerSettings\n+import akka.stream.testkit.StreamTestKit.SubscriberProbe\n+import akka.stream.testkit.{ StreamTestKit, AkkaSpec }\n+\n+object GraphFlowSpec {\n+  val tap1 = Source((0 to 3).toList)\n+  val inMerge = Merge[Int](\"m1\")\n+  val outMerge = Merge[String](\"m3\")\n+\n+  val partialGraph = PartialFlowGraph { implicit b ⇒\n+    import FlowGraphImplicits._\n+    val tap2 = Source((4 to 9).toList)\n+    val tap3 = Source(List.empty[Int])\n+    val tap4 = Source(List.empty[String])\n+    val m2 = Merge[Int](\"m2\")\n+\n+    inMerge ~> Flow[Int].map(_ * 2) ~> m2 ~> Flow[Int].map(_ / 2).map(i ⇒ (i + 1).toString) ~> outMerge\n+    tap2 ~> inMerge\n+    tap3 ~> m2\n+    tap4 ~> outMerge\n+  }\n+\n+  val stdRequests = 10\n+  val stdResult = Set(1, 2, 3, 4, 5, 6, 7, 8, 9, 10)\n+}\n+\n+class GraphFlowSpec extends AkkaSpec {\n+\n+  import GraphFlowSpec._\n+\n+  val settings = MaterializerSettings(system)\n+    .withInputBuffer(initialSize = 2, maxSize = 16)\n+    .withFanOutBuffer(initialSize = 1, maxSize = 16)\n+\n+  implicit val materializer = FlowMaterializer(settings)\n+\n+  def validateProbe(probe: SubscriberProbe[Int], requests: Int, result: Set[Int]): Unit = {\n+    val subscription = probe.expectSubscription()\n+\n+    var collected = Set.empty[Int]\n+    for (_ ← 1 to requests) {\n+      subscription.request(1)\n+      collected += probe.expectNext()\n+    }","path":"akka-stream-tests/src/test/scala/akka/stream/scaladsl2/GraphFlowSpec.scala","position":49,"original_position":49,"commit_id":"94f81f642fea08250a5fd8541d00cb18c5487f32","original_commit_id":"94f81f642fea08250a5fd8541d00cb18c5487f32","user":{"login":"bantonsson","id":805830,"avatar_url":"https://avatars.githubusercontent.com/u/805830?v=2","gravatar_id":"","url":"https://api.github.com/users/bantonsson","html_url":"https://github.com/bantonsson","followers_url":"https://api.github.com/users/bantonsson/followers","following_url":"https://api.github.com/users/bantonsson/following{/other_user}","gists_url":"https://api.github.com/users/bantonsson/gists{/gist_id}","starred_url":"https://api.github.com/users/bantonsson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bantonsson/subscriptions","organizations_url":"https://api.github.com/users/bantonsson/orgs","repos_url":"https://api.github.com/users/bantonsson/repos","events_url":"https://api.github.com/users/bantonsson/events{/privacy}","received_events_url":"https://api.github.com/users/bantonsson/received_events","type":"User","site_admin":false},"body":"Thanks","created_at":"2014-10-09T12:22:57Z","updated_at":"2014-10-09T12:22:57Z","html_url":"https://github.com/akka/akka/pull/16061#discussion_r18641246","pull_request_url":"https://api.github.com/repos/akka/akka/pulls/16061","_links":{"self":{"href":"https://api.github.com/repos/akka/akka/pulls/comments/18641246"},"html":{"href":"https://github.com/akka/akka/pull/16061#discussion_r18641246"},"pull_request":{"href":"https://api.github.com/repos/akka/akka/pulls/16061"}}},"pull_request":{"url":"https://api.github.com/repos/akka/akka/pulls/16061","id":22484012,"html_url":"https://github.com/akka/akka/pull/16061","diff_url":"https://github.com/akka/akka/pull/16061.diff","patch_url":"https://github.com/akka/akka/pull/16061.patch","issue_url":"https://api.github.com/repos/akka/akka/issues/16061","number":16061,"state":"open","locked":false,"title":"+str #16038 Create Source/Flow/Sink from partial flow graphs","user":{"login":"bantonsson","id":805830,"avatar_url":"https://avatars.githubusercontent.com/u/805830?v=2","gravatar_id":"","url":"https://api.github.com/users/bantonsson","html_url":"https://github.com/bantonsson","followers_url":"https://api.github.com/users/bantonsson/followers","following_url":"https://api.github.com/users/bantonsson/following{/other_user}","gists_url":"https://api.github.com/users/bantonsson/gists{/gist_id}","starred_url":"https://api.github.com/users/bantonsson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bantonsson/subscriptions","organizations_url":"https://api.github.com/users/bantonsson/orgs","repos_url":"https://api.github.com/users/bantonsson/repos","events_url":"https://api.github.com/users/bantonsson/events{/privacy}","received_events_url":"https://api.github.com/users/bantonsson/received_events","type":"User","site_admin":false},"body":"Fixes #16038","created_at":"2014-10-09T10:32:03Z","updated_at":"2014-10-09T12:22:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e37349b10f35a78b30d01d67890bdb4f7c54f561","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/akka/akka/pulls/16061/commits","review_comments_url":"https://api.github.com/repos/akka/akka/pulls/16061/comments","review_comment_url":"https://api.github.com/repos/akka/akka/pulls/comments/{number}","comments_url":"https://api.github.com/repos/akka/akka/issues/16061/comments","statuses_url":"https://api.github.com/repos/akka/akka/statuses/94f81f642fea08250a5fd8541d00cb18c5487f32","head":{"label":"akka:wip-graphs-as-source-flow-sink-ban","ref":"wip-graphs-as-source-flow-sink-ban","sha":"94f81f642fea08250a5fd8541d00cb18c5487f32","user":{"login":"akka","id":1496237,"avatar_url":"https://avatars.githubusercontent.com/u/1496237?v=2","gravatar_id":"","url":"https://api.github.com/users/akka","html_url":"https://github.com/akka","followers_url":"https://api.github.com/users/akka/followers","following_url":"https://api.github.com/users/akka/following{/other_user}","gists_url":"https://api.github.com/users/akka/gists{/gist_id}","starred_url":"https://api.github.com/users/akka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akka/subscriptions","organizations_url":"https://api.github.com/users/akka/orgs","repos_url":"https://api.github.com/users/akka/repos","events_url":"https://api.github.com/users/akka/events{/privacy}","received_events_url":"https://api.github.com/users/akka/received_events","type":"Organization","site_admin":false},"repo":{"id":130013,"name":"akka","full_name":"akka/akka","owner":{"login":"akka","id":1496237,"avatar_url":"https://avatars.githubusercontent.com/u/1496237?v=2","gravatar_id":"","url":"https://api.github.com/users/akka","html_url":"https://github.com/akka","followers_url":"https://api.github.com/users/akka/followers","following_url":"https://api.github.com/users/akka/following{/other_user}","gists_url":"https://api.github.com/users/akka/gists{/gist_id}","starred_url":"https://api.github.com/users/akka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akka/subscriptions","organizations_url":"https://api.github.com/users/akka/orgs","repos_url":"https://api.github.com/users/akka/repos","events_url":"https://api.github.com/users/akka/events{/privacy}","received_events_url":"https://api.github.com/users/akka/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/akka/akka","description":"Akka Project","fork":false,"url":"https://api.github.com/repos/akka/akka","forks_url":"https://api.github.com/repos/akka/akka/forks","keys_url":"https://api.github.com/repos/akka/akka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akka/akka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akka/akka/teams","hooks_url":"https://api.github.com/repos/akka/akka/hooks","issue_events_url":"https://api.github.com/repos/akka/akka/issues/events{/number}","events_url":"https://api.github.com/repos/akka/akka/events","assignees_url":"https://api.github.com/repos/akka/akka/assignees{/user}","branches_url":"https://api.github.com/repos/akka/akka/branches{/branch}","tags_url":"https://api.github.com/repos/akka/akka/tags","blobs_url":"https://api.github.com/repos/akka/akka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akka/akka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akka/akka/git/refs{/sha}","trees_url":"https://api.github.com/repos/akka/akka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akka/akka/statuses/{sha}","languages_url":"https://api.github.com/repos/akka/akka/languages","stargazers_url":"https://api.github.com/repos/akka/akka/stargazers","contributors_url":"https://api.github.com/repos/akka/akka/contributors","subscribers_url":"https://api.github.com/repos/akka/akka/subscribers","subscription_url":"https://api.github.com/repos/akka/akka/subscription","commits_url":"https://api.github.com/repos/akka/akka/commits{/sha}","git_commits_url":"https://api.github.com/repos/akka/akka/git/commits{/sha}","comments_url":"https://api.github.com/repos/akka/akka/comments{/number}","issue_comment_url":"https://api.github.com/repos/akka/akka/issues/comments/{number}","contents_url":"https://api.github.com/repos/akka/akka/contents/{+path}","compare_url":"https://api.github.com/repos/akka/akka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akka/akka/merges","archive_url":"https://api.github.com/repos/akka/akka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akka/akka/downloads","issues_url":"https://api.github.com/repos/akka/akka/issues{/number}","pulls_url":"https://api.github.com/repos/akka/akka/pulls{/number}","milestones_url":"https://api.github.com/repos/akka/akka/milestones{/number}","notifications_url":"https://api.github.com/repos/akka/akka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akka/akka/labels{/name}","releases_url":"https://api.github.com/repos/akka/akka/releases{/id}","created_at":"2009-02-16T12:51:54Z","updated_at":"2014-10-09T11:42:11Z","pushed_at":"2014-10-09T11:46:50Z","git_url":"git://github.com/akka/akka.git","ssh_url":"git@github.com:akka/akka.git","clone_url":"https://github.com/akka/akka.git","svn_url":"https://github.com/akka/akka","homepage":"http://akka.io","size":233292,"stargazers_count":3052,"watchers_count":3052,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":832,"mirror_url":null,"open_issues_count":464,"forks":832,"open_issues":464,"watchers":3052,"default_branch":"master"}},"base":{"label":"akka:release-2.3-dev","ref":"release-2.3-dev","sha":"4a76dd579668e5eb61ba5c6421b9e7ecc74ffc6b","user":{"login":"akka","id":1496237,"avatar_url":"https://avatars.githubusercontent.com/u/1496237?v=2","gravatar_id":"","url":"https://api.github.com/users/akka","html_url":"https://github.com/akka","followers_url":"https://api.github.com/users/akka/followers","following_url":"https://api.github.com/users/akka/following{/other_user}","gists_url":"https://api.github.com/users/akka/gists{/gist_id}","starred_url":"https://api.github.com/users/akka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akka/subscriptions","organizations_url":"https://api.github.com/users/akka/orgs","repos_url":"https://api.github.com/users/akka/repos","events_url":"https://api.github.com/users/akka/events{/privacy}","received_events_url":"https://api.github.com/users/akka/received_events","type":"Organization","site_admin":false},"repo":{"id":130013,"name":"akka","full_name":"akka/akka","owner":{"login":"akka","id":1496237,"avatar_url":"https://avatars.githubusercontent.com/u/1496237?v=2","gravatar_id":"","url":"https://api.github.com/users/akka","html_url":"https://github.com/akka","followers_url":"https://api.github.com/users/akka/followers","following_url":"https://api.github.com/users/akka/following{/other_user}","gists_url":"https://api.github.com/users/akka/gists{/gist_id}","starred_url":"https://api.github.com/users/akka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akka/subscriptions","organizations_url":"https://api.github.com/users/akka/orgs","repos_url":"https://api.github.com/users/akka/repos","events_url":"https://api.github.com/users/akka/events{/privacy}","received_events_url":"https://api.github.com/users/akka/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/akka/akka","description":"Akka Project","fork":false,"url":"https://api.github.com/repos/akka/akka","forks_url":"https://api.github.com/repos/akka/akka/forks","keys_url":"https://api.github.com/repos/akka/akka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akka/akka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akka/akka/teams","hooks_url":"https://api.github.com/repos/akka/akka/hooks","issue_events_url":"https://api.github.com/repos/akka/akka/issues/events{/number}","events_url":"https://api.github.com/repos/akka/akka/events","assignees_url":"https://api.github.com/repos/akka/akka/assignees{/user}","branches_url":"https://api.github.com/repos/akka/akka/branches{/branch}","tags_url":"https://api.github.com/repos/akka/akka/tags","blobs_url":"https://api.github.com/repos/akka/akka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akka/akka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akka/akka/git/refs{/sha}","trees_url":"https://api.github.com/repos/akka/akka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akka/akka/statuses/{sha}","languages_url":"https://api.github.com/repos/akka/akka/languages","stargazers_url":"https://api.github.com/repos/akka/akka/stargazers","contributors_url":"https://api.github.com/repos/akka/akka/contributors","subscribers_url":"https://api.github.com/repos/akka/akka/subscribers","subscription_url":"https://api.github.com/repos/akka/akka/subscription","commits_url":"https://api.github.com/repos/akka/akka/commits{/sha}","git_commits_url":"https://api.github.com/repos/akka/akka/git/commits{/sha}","comments_url":"https://api.github.com/repos/akka/akka/comments{/number}","issue_comment_url":"https://api.github.com/repos/akka/akka/issues/comments/{number}","contents_url":"https://api.github.com/repos/akka/akka/contents/{+path}","compare_url":"https://api.github.com/repos/akka/akka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akka/akka/merges","archive_url":"https://api.github.com/repos/akka/akka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akka/akka/downloads","issues_url":"https://api.github.com/repos/akka/akka/issues{/number}","pulls_url":"https://api.github.com/repos/akka/akka/pulls{/number}","milestones_url":"https://api.github.com/repos/akka/akka/milestones{/number}","notifications_url":"https://api.github.com/repos/akka/akka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akka/akka/labels{/name}","releases_url":"https://api.github.com/repos/akka/akka/releases{/id}","created_at":"2009-02-16T12:51:54Z","updated_at":"2014-10-09T11:42:11Z","pushed_at":"2014-10-09T11:46:50Z","git_url":"git://github.com/akka/akka.git","ssh_url":"git@github.com:akka/akka.git","clone_url":"https://github.com/akka/akka.git","svn_url":"https://github.com/akka/akka","homepage":"http://akka.io","size":233292,"stargazers_count":3052,"watchers_count":3052,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":832,"mirror_url":null,"open_issues_count":464,"forks":832,"open_issues":464,"watchers":3052,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/akka/akka/pulls/16061"},"html":{"href":"https://github.com/akka/akka/pull/16061"},"issue":{"href":"https://api.github.com/repos/akka/akka/issues/16061"},"comments":{"href":"https://api.github.com/repos/akka/akka/issues/16061/comments"},"review_comments":{"href":"https://api.github.com/repos/akka/akka/pulls/16061/comments"},"review_comment":{"href":"https://api.github.com/repos/akka/akka/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/akka/akka/pulls/16061/commits"},"statuses":{"href":"https://api.github.com/repos/akka/akka/statuses/94f81f642fea08250a5fd8541d00cb18c5487f32"}}}}