GitHub PullRequestReviewCommentEvent at 2014-10-20 19:12:40
Repository: etcd
Actor: philips
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/coreos/etcd/pulls/comments/19106458","id":19106458,"diff_hunk":"@@ -40,7 +41,8 @@ func newMember(name string, peerURLs types.URLs, now *time.Time) *Member {\n \t\tAttributes:     Attributes{Name: name},\n \t}\n \n-\tb := []byte(m.Name)\n+\tvar b []byte\n+\tsort.Strings(m.PeerURLs)","path":"etcdserver/member.go","position":14,"original_position":14,"commit_id":"fe8fac97ecdc0dd36450f1f42ca917d3617d81c1","original_commit_id":"4818d2d6f676a29ebcfcfb844385406e0d98a858","user":{"login":"philips","id":33544,"avatar_url":"https://avatars.githubusercontent.com/u/33544?v=2","gravatar_id":"","url":"https://api.github.com/users/philips","html_url":"https://github.com/philips","followers_url":"https://api.github.com/users/philips/followers","following_url":"https://api.github.com/users/philips/following{/other_user}","gists_url":"https://api.github.com/users/philips/gists{/gist_id}","starred_url":"https://api.github.com/users/philips/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philips/subscriptions","organizations_url":"https://api.github.com/users/philips/orgs","repos_url":"https://api.github.com/users/philips/repos","events_url":"https://api.github.com/users/philips/events{/privacy}","received_events_url":"https://api.github.com/users/philips/received_events","type":"User","site_admin":false},"body":"@barakmich +1, yes.","created_at":"2014-10-20T19:12:40Z","updated_at":"2014-10-20T19:12:40Z","html_url":"https://github.com/coreos/etcd/pull/1284#discussion_r19106458","pull_request_url":"https://api.github.com/repos/coreos/etcd/pulls/1284","_links":{"self":{"href":"https://api.github.com/repos/coreos/etcd/pulls/comments/19106458"},"html":{"href":"https://github.com/coreos/etcd/pull/1284#discussion_r19106458"},"pull_request":{"href":"https://api.github.com/repos/coreos/etcd/pulls/1284"}}},"pull_request":{"url":"https://api.github.com/repos/coreos/etcd/pulls/1284","id":22594699,"html_url":"https://github.com/coreos/etcd/pull/1284","diff_url":"https://github.com/coreos/etcd/pull/1284.diff","patch_url":"https://github.com/coreos/etcd/pull/1284.patch","issue_url":"https://api.github.com/repos/coreos/etcd/issues/1284","number":1284,"state":"open","locked":false,"title":"etcdserver: Calculate IDs for nodes solely on PeerURLs","user":{"login":"barakmich","id":98356,"avatar_url":"https://avatars.githubusercontent.com/u/98356?v=2","gravatar_id":"","url":"https://api.github.com/users/barakmich","html_url":"https://github.com/barakmich","followers_url":"https://api.github.com/users/barakmich/followers","following_url":"https://api.github.com/users/barakmich/following{/other_user}","gists_url":"https://api.github.com/users/barakmich/gists{/gist_id}","starred_url":"https://api.github.com/users/barakmich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/barakmich/subscriptions","organizations_url":"https://api.github.com/users/barakmich/orgs","repos_url":"https://api.github.com/users/barakmich/repos","events_url":"https://api.github.com/users/barakmich/events{/privacy}","received_events_url":"https://api.github.com/users/barakmich/received_events","type":"User","site_admin":false},"body":"Removes the notion of name being anything more than advisory or\r\ncommand-line grouping, and adds checks for bootstrapping the command\r\nline. IDs are consistent if the URLs are consistent.","created_at":"2014-10-10T23:23:54Z","updated_at":"2014-10-20T19:12:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"53d0ca8db1177dc9772106ce3fa00b104fc07ec5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/coreos/etcd/pulls/1284/commits","review_comments_url":"https://api.github.com/repos/coreos/etcd/pulls/1284/comments","review_comment_url":"https://api.github.com/repos/coreos/etcd/pulls/comments/{number}","comments_url":"https://api.github.com/repos/coreos/etcd/issues/1284/comments","statuses_url":"https://api.github.com/repos/coreos/etcd/statuses/fe8fac97ecdc0dd36450f1f42ca917d3617d81c1","head":{"label":"barakmich:better_ids","ref":"better_ids","sha":"fe8fac97ecdc0dd36450f1f42ca917d3617d81c1","user":{"login":"barakmich","id":98356,"avatar_url":"https://avatars.githubusercontent.com/u/98356?v=2","gravatar_id":"","url":"https://api.github.com/users/barakmich","html_url":"https://github.com/barakmich","followers_url":"https://api.github.com/users/barakmich/followers","following_url":"https://api.github.com/users/barakmich/following{/other_user}","gists_url":"https://api.github.com/users/barakmich/gists{/gist_id}","starred_url":"https://api.github.com/users/barakmich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/barakmich/subscriptions","organizations_url":"https://api.github.com/users/barakmich/orgs","repos_url":"https://api.github.com/users/barakmich/repos","events_url":"https://api.github.com/users/barakmich/events{/privacy}","received_events_url":"https://api.github.com/users/barakmich/received_events","type":"User","site_admin":false},"repo":{"id":24866595,"name":"etcd","full_name":"barakmich/etcd","owner":{"login":"barakmich","id":98356,"avatar_url":"https://avatars.githubusercontent.com/u/98356?v=2","gravatar_id":"","url":"https://api.github.com/users/barakmich","html_url":"https://github.com/barakmich","followers_url":"https://api.github.com/users/barakmich/followers","following_url":"https://api.github.com/users/barakmich/following{/other_user}","gists_url":"https://api.github.com/users/barakmich/gists{/gist_id}","starred_url":"https://api.github.com/users/barakmich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/barakmich/subscriptions","organizations_url":"https://api.github.com/users/barakmich/orgs","repos_url":"https://api.github.com/users/barakmich/repos","events_url":"https://api.github.com/users/barakmich/events{/privacy}","received_events_url":"https://api.github.com/users/barakmich/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/barakmich/etcd","description":"A highly-available key value store for shared configuration and service discovery","fork":true,"url":"https://api.github.com/repos/barakmich/etcd","forks_url":"https://api.github.com/repos/barakmich/etcd/forks","keys_url":"https://api.github.com/repos/barakmich/etcd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/barakmich/etcd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/barakmich/etcd/teams","hooks_url":"https://api.github.com/repos/barakmich/etcd/hooks","issue_events_url":"https://api.github.com/repos/barakmich/etcd/issues/events{/number}","events_url":"https://api.github.com/repos/barakmich/etcd/events","assignees_url":"https://api.github.com/repos/barakmich/etcd/assignees{/user}","branches_url":"https://api.github.com/repos/barakmich/etcd/branches{/branch}","tags_url":"https://api.github.com/repos/barakmich/etcd/tags","blobs_url":"https://api.github.com/repos/barakmich/etcd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/barakmich/etcd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/barakmich/etcd/git/refs{/sha}","trees_url":"https://api.github.com/repos/barakmich/etcd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/barakmich/etcd/statuses/{sha}","languages_url":"https://api.github.com/repos/barakmich/etcd/languages","stargazers_url":"https://api.github.com/repos/barakmich/etcd/stargazers","contributors_url":"https://api.github.com/repos/barakmich/etcd/contributors","subscribers_url":"https://api.github.com/repos/barakmich/etcd/subscribers","subscription_url":"https://api.github.com/repos/barakmich/etcd/subscription","commits_url":"https://api.github.com/repos/barakmich/etcd/commits{/sha}","git_commits_url":"https://api.github.com/repos/barakmich/etcd/git/commits{/sha}","comments_url":"https://api.github.com/repos/barakmich/etcd/comments{/number}","issue_comment_url":"https://api.github.com/repos/barakmich/etcd/issues/comments/{number}","contents_url":"https://api.github.com/repos/barakmich/etcd/contents/{+path}","compare_url":"https://api.github.com/repos/barakmich/etcd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/barakmich/etcd/merges","archive_url":"https://api.github.com/repos/barakmich/etcd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/barakmich/etcd/downloads","issues_url":"https://api.github.com/repos/barakmich/etcd/issues{/number}","pulls_url":"https://api.github.com/repos/barakmich/etcd/pulls{/number}","milestones_url":"https://api.github.com/repos/barakmich/etcd/milestones{/number}","notifications_url":"https://api.github.com/repos/barakmich/etcd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/barakmich/etcd/labels{/name}","releases_url":"https://api.github.com/repos/barakmich/etcd/releases{/id}","created_at":"2014-10-06T21:58:23Z","updated_at":"2014-10-06T22:30:18Z","pushed_at":"2014-10-15T19:55:18Z","git_url":"git://github.com/barakmich/etcd.git","ssh_url":"git@github.com:barakmich/etcd.git","clone_url":"https://github.com/barakmich/etcd.git","svn_url":"https://github.com/barakmich/etcd","homepage":"","size":11636,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"coreos:master","ref":"master","sha":"f16a272898321522c73c7c2ee535e3f4ef14b1c1","user":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=2","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"repo":{"id":11225014,"name":"etcd","full_name":"coreos/etcd","owner":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=2","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coreos/etcd","description":"A highly-available key value store for shared configuration and service discovery","fork":false,"url":"https://api.github.com/repos/coreos/etcd","forks_url":"https://api.github.com/repos/coreos/etcd/forks","keys_url":"https://api.github.com/repos/coreos/etcd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coreos/etcd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coreos/etcd/teams","hooks_url":"https://api.github.com/repos/coreos/etcd/hooks","issue_events_url":"https://api.github.com/repos/coreos/etcd/issues/events{/number}","events_url":"https://api.github.com/repos/coreos/etcd/events","assignees_url":"https://api.github.com/repos/coreos/etcd/assignees{/user}","branches_url":"https://api.github.com/repos/coreos/etcd/branches{/branch}","tags_url":"https://api.github.com/repos/coreos/etcd/tags","blobs_url":"https://api.github.com/repos/coreos/etcd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coreos/etcd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coreos/etcd/git/refs{/sha}","trees_url":"https://api.github.com/repos/coreos/etcd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coreos/etcd/statuses/{sha}","languages_url":"https://api.github.com/repos/coreos/etcd/languages","stargazers_url":"https://api.github.com/repos/coreos/etcd/stargazers","contributors_url":"https://api.github.com/repos/coreos/etcd/contributors","subscribers_url":"https://api.github.com/repos/coreos/etcd/subscribers","subscription_url":"https://api.github.com/repos/coreos/etcd/subscription","commits_url":"https://api.github.com/repos/coreos/etcd/commits{/sha}","git_commits_url":"https://api.github.com/repos/coreos/etcd/git/commits{/sha}","comments_url":"https://api.github.com/repos/coreos/etcd/comments{/number}","issue_comment_url":"https://api.github.com/repos/coreos/etcd/issues/comments/{number}","contents_url":"https://api.github.com/repos/coreos/etcd/contents/{+path}","compare_url":"https://api.github.com/repos/coreos/etcd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coreos/etcd/merges","archive_url":"https://api.github.com/repos/coreos/etcd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coreos/etcd/downloads","issues_url":"https://api.github.com/repos/coreos/etcd/issues{/number}","pulls_url":"https://api.github.com/repos/coreos/etcd/pulls{/number}","milestones_url":"https://api.github.com/repos/coreos/etcd/milestones{/number}","notifications_url":"https://api.github.com/repos/coreos/etcd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coreos/etcd/labels{/name}","releases_url":"https://api.github.com/repos/coreos/etcd/releases{/id}","created_at":"2013-07-06T21:57:21Z","updated_at":"2014-10-20T16:52:23Z","pushed_at":"2014-10-20T17:49:52Z","git_url":"git://github.com/coreos/etcd.git","ssh_url":"git@github.com:coreos/etcd.git","clone_url":"https://github.com/coreos/etcd.git","svn_url":"https://github.com/coreos/etcd","homepage":"","size":26233,"stargazers_count":4443,"watchers_count":4443,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":446,"mirror_url":null,"open_issues_count":112,"forks":446,"open_issues":112,"watchers":4443,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coreos/etcd/pulls/1284"},"html":{"href":"https://github.com/coreos/etcd/pull/1284"},"issue":{"href":"https://api.github.com/repos/coreos/etcd/issues/1284"},"comments":{"href":"https://api.github.com/repos/coreos/etcd/issues/1284/comments"},"review_comments":{"href":"https://api.github.com/repos/coreos/etcd/pulls/1284/comments"},"review_comment":{"href":"https://api.github.com/repos/coreos/etcd/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/coreos/etcd/pulls/1284/commits"},"statuses":{"href":"https://api.github.com/repos/coreos/etcd/statuses/fe8fac97ecdc0dd36450f1f42ca917d3617d81c1"}}}}