GitHub PullRequestReviewCommentEvent at 2014-07-09 06:44:53
Repository: chalk
Actor: seanmonstar
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/sindresorhus/chalk/pulls/comments/14695489","id":14695489,"diff_hunk":"@@ -26,15 +34,25 @@ var styles = (function () {\n \treturn ret;\n })();\n \n+var proto = defineProps(function chalk() {}, styles);\n+\n function applyStyle() {\n \t// support varags, but simply cast to string in case there's only one arg\n-\tvar str = arguments.length === 1 ? String(arguments[0]) : [].slice.call(arguments).join(' ');\n+\tvar args = arguments;\n+\tvar argsLen = args.length;\n+\tvar str = argsLen !== 0 && String(arguments[0]);\n+\tif (argsLen > 1) {\n+\t\tfor (var a = 0; a < argsLen; a++) {","path":"index.js","position":39,"original_position":39,"commit_id":"bed1fe8d535d8e562e355c549e315385cba1d928","original_commit_id":"bed1fe8d535d8e562e355c549e315385cba1d928","user":{"login":"seanmonstar","id":51479,"avatar_url":"https://avatars.githubusercontent.com/u/51479?","gravatar_id":"dfb248d98bc7c238fccd5aad53624eab","url":"https://api.github.com/users/seanmonstar","html_url":"https://github.com/seanmonstar","followers_url":"https://api.github.com/users/seanmonstar/followers","following_url":"https://api.github.com/users/seanmonstar/following{/other_user}","gists_url":"https://api.github.com/users/seanmonstar/gists{/gist_id}","starred_url":"https://api.github.com/users/seanmonstar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanmonstar/subscriptions","organizations_url":"https://api.github.com/users/seanmonstar/orgs","repos_url":"https://api.github.com/users/seanmonstar/repos","events_url":"https://api.github.com/users/seanmonstar/events{/privacy}","received_events_url":"https://api.github.com/users/seanmonstar/received_events","type":"User","site_admin":false},"body":"Woops, I had this originally, and a must have lost it in a clean up. ","created_at":"2014-07-09T06:44:53Z","updated_at":"2014-07-09T06:44:53Z","html_url":"https://github.com/sindresorhus/chalk/pull/33#discussion_r14695489","pull_request_url":"https://api.github.com/repos/sindresorhus/chalk/pulls/33","_links":{"self":{"href":"https://api.github.com/repos/sindresorhus/chalk/pulls/comments/14695489"},"html":{"href":"https://github.com/sindresorhus/chalk/pull/33#discussion_r14695489"},"pull_request":{"href":"https://api.github.com/repos/sindresorhus/chalk/pulls/33"}}},"pull_request":{"url":"https://api.github.com/repos/sindresorhus/chalk/pulls/33","id":18141238,"html_url":"https://github.com/sindresorhus/chalk/pull/33","diff_url":"https://github.com/sindresorhus/chalk/pull/33.diff","patch_url":"https://github.com/sindresorhus/chalk/pull/33.patch","issue_url":"https://api.github.com/repos/sindresorhus/chalk/issues/33","number":33,"state":"open","title":"fix caching of styles","user":{"login":"seanmonstar","id":51479,"avatar_url":"https://avatars.githubusercontent.com/u/51479?","gravatar_id":"dfb248d98bc7c238fccd5aad53624eab","url":"https://api.github.com/users/seanmonstar","html_url":"https://github.com/seanmonstar","followers_url":"https://api.github.com/users/seanmonstar/followers","following_url":"https://api.github.com/users/seanmonstar/following{/other_user}","gists_url":"https://api.github.com/users/seanmonstar/gists{/gist_id}","starred_url":"https://api.github.com/users/seanmonstar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanmonstar/subscriptions","organizations_url":"https://api.github.com/users/seanmonstar/orgs","repos_url":"https://api.github.com/users/seanmonstar/repos","events_url":"https://api.github.com/users/seanmonstar/events{/privacy}","received_events_url":"https://api.github.com/users/seanmonstar/received_events","type":"User","site_admin":false},"body":"If you choose to go with option 2 that I listed in #32, this is the PR.","created_at":"2014-07-09T04:12:11Z","updated_at":"2014-07-09T06:44:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b4829b9488f4cc212f561d756927080aa84ced2f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sindresorhus/chalk/pulls/33/commits","review_comments_url":"https://api.github.com/repos/sindresorhus/chalk/pulls/33/comments","review_comment_url":"https://api.github.com/repos/sindresorhus/chalk/pulls/comments/{number}","comments_url":"https://api.github.com/repos/sindresorhus/chalk/issues/33/comments","statuses_url":"https://api.github.com/repos/sindresorhus/chalk/statuses/bed1fe8d535d8e562e355c549e315385cba1d928","head":{"label":"seanmonstar:_styles","ref":"_styles","sha":"bed1fe8d535d8e562e355c549e315385cba1d928","user":{"login":"seanmonstar","id":51479,"avatar_url":"https://avatars.githubusercontent.com/u/51479?","gravatar_id":"dfb248d98bc7c238fccd5aad53624eab","url":"https://api.github.com/users/seanmonstar","html_url":"https://github.com/seanmonstar","followers_url":"https://api.github.com/users/seanmonstar/followers","following_url":"https://api.github.com/users/seanmonstar/following{/other_user}","gists_url":"https://api.github.com/users/seanmonstar/gists{/gist_id}","starred_url":"https://api.github.com/users/seanmonstar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanmonstar/subscriptions","organizations_url":"https://api.github.com/users/seanmonstar/orgs","repos_url":"https://api.github.com/users/seanmonstar/repos","events_url":"https://api.github.com/users/seanmonstar/events{/privacy}","received_events_url":"https://api.github.com/users/seanmonstar/received_events","type":"User","site_admin":false},"repo":{"id":21635450,"name":"chalk","full_name":"seanmonstar/chalk","owner":{"login":"seanmonstar","id":51479,"avatar_url":"https://avatars.githubusercontent.com/u/51479?","gravatar_id":"dfb248d98bc7c238fccd5aad53624eab","url":"https://api.github.com/users/seanmonstar","html_url":"https://github.com/seanmonstar","followers_url":"https://api.github.com/users/seanmonstar/followers","following_url":"https://api.github.com/users/seanmonstar/following{/other_user}","gists_url":"https://api.github.com/users/seanmonstar/gists{/gist_id}","starred_url":"https://api.github.com/users/seanmonstar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanmonstar/subscriptions","organizations_url":"https://api.github.com/users/seanmonstar/orgs","repos_url":"https://api.github.com/users/seanmonstar/repos","events_url":"https://api.github.com/users/seanmonstar/events{/privacy}","received_events_url":"https://api.github.com/users/seanmonstar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/seanmonstar/chalk","description":"Terminal string styling done right","fork":true,"url":"https://api.github.com/repos/seanmonstar/chalk","forks_url":"https://api.github.com/repos/seanmonstar/chalk/forks","keys_url":"https://api.github.com/repos/seanmonstar/chalk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/seanmonstar/chalk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/seanmonstar/chalk/teams","hooks_url":"https://api.github.com/repos/seanmonstar/chalk/hooks","issue_events_url":"https://api.github.com/repos/seanmonstar/chalk/issues/events{/number}","events_url":"https://api.github.com/repos/seanmonstar/chalk/events","assignees_url":"https://api.github.com/repos/seanmonstar/chalk/assignees{/user}","branches_url":"https://api.github.com/repos/seanmonstar/chalk/branches{/branch}","tags_url":"https://api.github.com/repos/seanmonstar/chalk/tags","blobs_url":"https://api.github.com/repos/seanmonstar/chalk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/seanmonstar/chalk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/seanmonstar/chalk/git/refs{/sha}","trees_url":"https://api.github.com/repos/seanmonstar/chalk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/seanmonstar/chalk/statuses/{sha}","languages_url":"https://api.github.com/repos/seanmonstar/chalk/languages","stargazers_url":"https://api.github.com/repos/seanmonstar/chalk/stargazers","contributors_url":"https://api.github.com/repos/seanmonstar/chalk/contributors","subscribers_url":"https://api.github.com/repos/seanmonstar/chalk/subscribers","subscription_url":"https://api.github.com/repos/seanmonstar/chalk/subscription","commits_url":"https://api.github.com/repos/seanmonstar/chalk/commits{/sha}","git_commits_url":"https://api.github.com/repos/seanmonstar/chalk/git/commits{/sha}","comments_url":"https://api.github.com/repos/seanmonstar/chalk/comments{/number}","issue_comment_url":"https://api.github.com/repos/seanmonstar/chalk/issues/comments/{number}","contents_url":"https://api.github.com/repos/seanmonstar/chalk/contents/{+path}","compare_url":"https://api.github.com/repos/seanmonstar/chalk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/seanmonstar/chalk/merges","archive_url":"https://api.github.com/repos/seanmonstar/chalk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/seanmonstar/chalk/downloads","issues_url":"https://api.github.com/repos/seanmonstar/chalk/issues{/number}","pulls_url":"https://api.github.com/repos/seanmonstar/chalk/pulls{/number}","milestones_url":"https://api.github.com/repos/seanmonstar/chalk/milestones{/number}","notifications_url":"https://api.github.com/repos/seanmonstar/chalk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/seanmonstar/chalk/labels{/name}","releases_url":"https://api.github.com/repos/seanmonstar/chalk/releases{/id}","created_at":"2014-07-09T01:50:27Z","updated_at":"2014-07-08T23:52:01Z","pushed_at":"2014-07-09T04:10:18Z","git_url":"git://github.com/seanmonstar/chalk.git","ssh_url":"git@github.com:seanmonstar/chalk.git","clone_url":"https://github.com/seanmonstar/chalk.git","svn_url":"https://github.com/seanmonstar/chalk","homepage":"","size":1005,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sindresorhus:master","ref":"master","sha":"3073fa3110134e840ee79eaffb61866182b4b7fa","user":{"login":"sindresorhus","id":170270,"avatar_url":"https://avatars.githubusercontent.com/u/170270?","gravatar_id":"d36a92237c75c5337c17b60d90686bf9","url":"https://api.github.com/users/sindresorhus","html_url":"https://github.com/sindresorhus","followers_url":"https://api.github.com/users/sindresorhus/followers","following_url":"https://api.github.com/users/sindresorhus/following{/other_user}","gists_url":"https://api.github.com/users/sindresorhus/gists{/gist_id}","starred_url":"https://api.github.com/users/sindresorhus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sindresorhus/subscriptions","organizations_url":"https://api.github.com/users/sindresorhus/orgs","repos_url":"https://api.github.com/users/sindresorhus/repos","events_url":"https://api.github.com/users/sindresorhus/events{/privacy}","received_events_url":"https://api.github.com/users/sindresorhus/received_events","type":"User","site_admin":false},"repo":{"id":11855195,"name":"chalk","full_name":"sindresorhus/chalk","owner":{"login":"sindresorhus","id":170270,"avatar_url":"https://avatars.githubusercontent.com/u/170270?","gravatar_id":"d36a92237c75c5337c17b60d90686bf9","url":"https://api.github.com/users/sindresorhus","html_url":"https://github.com/sindresorhus","followers_url":"https://api.github.com/users/sindresorhus/followers","following_url":"https://api.github.com/users/sindresorhus/following{/other_user}","gists_url":"https://api.github.com/users/sindresorhus/gists{/gist_id}","starred_url":"https://api.github.com/users/sindresorhus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sindresorhus/subscriptions","organizations_url":"https://api.github.com/users/sindresorhus/orgs","repos_url":"https://api.github.com/users/sindresorhus/repos","events_url":"https://api.github.com/users/sindresorhus/events{/privacy}","received_events_url":"https://api.github.com/users/sindresorhus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sindresorhus/chalk","description":"Terminal string styling done right","fork":false,"url":"https://api.github.com/repos/sindresorhus/chalk","forks_url":"https://api.github.com/repos/sindresorhus/chalk/forks","keys_url":"https://api.github.com/repos/sindresorhus/chalk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sindresorhus/chalk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sindresorhus/chalk/teams","hooks_url":"https://api.github.com/repos/sindresorhus/chalk/hooks","issue_events_url":"https://api.github.com/repos/sindresorhus/chalk/issues/events{/number}","events_url":"https://api.github.com/repos/sindresorhus/chalk/events","assignees_url":"https://api.github.com/repos/sindresorhus/chalk/assignees{/user}","branches_url":"https://api.github.com/repos/sindresorhus/chalk/branches{/branch}","tags_url":"https://api.github.com/repos/sindresorhus/chalk/tags","blobs_url":"https://api.github.com/repos/sindresorhus/chalk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sindresorhus/chalk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sindresorhus/chalk/git/refs{/sha}","trees_url":"https://api.github.com/repos/sindresorhus/chalk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sindresorhus/chalk/statuses/{sha}","languages_url":"https://api.github.com/repos/sindresorhus/chalk/languages","stargazers_url":"https://api.github.com/repos/sindresorhus/chalk/stargazers","contributors_url":"https://api.github.com/repos/sindresorhus/chalk/contributors","subscribers_url":"https://api.github.com/repos/sindresorhus/chalk/subscribers","subscription_url":"https://api.github.com/repos/sindresorhus/chalk/subscription","commits_url":"https://api.github.com/repos/sindresorhus/chalk/commits{/sha}","git_commits_url":"https://api.github.com/repos/sindresorhus/chalk/git/commits{/sha}","comments_url":"https://api.github.com/repos/sindresorhus/chalk/comments{/number}","issue_comment_url":"https://api.github.com/repos/sindresorhus/chalk/issues/comments/{number}","contents_url":"https://api.github.com/repos/sindresorhus/chalk/contents/{+path}","compare_url":"https://api.github.com/repos/sindresorhus/chalk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sindresorhus/chalk/merges","archive_url":"https://api.github.com/repos/sindresorhus/chalk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sindresorhus/chalk/downloads","issues_url":"https://api.github.com/repos/sindresorhus/chalk/issues{/number}","pulls_url":"https://api.github.com/repos/sindresorhus/chalk/pulls{/number}","milestones_url":"https://api.github.com/repos/sindresorhus/chalk/milestones{/number}","notifications_url":"https://api.github.com/repos/sindresorhus/chalk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sindresorhus/chalk/labels{/name}","releases_url":"https://api.github.com/repos/sindresorhus/chalk/releases{/id}","created_at":"2013-08-03T00:20:12Z","updated_at":"2014-07-09T04:50:54Z","pushed_at":"2014-07-04T21:24:21Z","git_url":"git://github.com/sindresorhus/chalk.git","ssh_url":"git@github.com:sindresorhus/chalk.git","clone_url":"https://github.com/sindresorhus/chalk.git","svn_url":"https://github.com/sindresorhus/chalk","homepage":"","size":1005,"stargazers_count":505,"watchers_count":505,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":17,"mirror_url":null,"open_issues_count":3,"forks":17,"open_issues":3,"watchers":505,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sindresorhus/chalk/pulls/33"},"html":{"href":"https://github.com/sindresorhus/chalk/pull/33"},"issue":{"href":"https://api.github.com/repos/sindresorhus/chalk/issues/33"},"comments":{"href":"https://api.github.com/repos/sindresorhus/chalk/issues/33/comments"},"review_comments":{"href":"https://api.github.com/repos/sindresorhus/chalk/pulls/33/comments"},"review_comment":{"href":"https://api.github.com/repos/sindresorhus/chalk/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/sindresorhus/chalk/pulls/33/commits"},"statuses":{"href":"https://api.github.com/repos/sindresorhus/chalk/statuses/bed1fe8d535d8e562e355c549e315385cba1d928"}}}}