GitHub PullRequestReviewCommentEvent at 2014-05-22 13:43:53
Repository: cotton
Actor: ashb
Payload: {"comment":{"url":"https://api.github.com/repos/ministryofjustice/cotton/pulls/comments/12950050","id":12950050,"diff_hunk":"@@ -139,37 +140,24 @@ def _reconfig_minion(salt_server):\n     sudo(\"/bin/chown root:root /etc/salt/minion\")\n \n \n-def _bootstrap_salt(salt_server=None, flags='', install_type=''):\n-    if salt_server is None:\n-\n-        (master,) = [x for x in get_provider_zone_config()['hosts'] if x['name'] == 'master']\n-        salt_server = master['ip']\n+def _bootstrap_salt(master=None, flags='', install_type='', roles=None):","path":"cotton/salt.py","position":40,"original_position":40,"commit_id":"5cddd2aa3cd9729bc6ebe73749998e865d7af094","original_commit_id":"5cddd2aa3cd9729bc6ebe73749998e865d7af094","user":{"login":"ashb","id":34150,"avatar_url":"https://avatars.githubusercontent.com/u/34150?","gravatar_id":"a37ac47f749d07e74b36ecb1866a8265","url":"https://api.github.com/users/ashb","html_url":"https://github.com/ashb","followers_url":"https://api.github.com/users/ashb/followers","following_url":"https://api.github.com/users/ashb/following{/other_user}","gists_url":"https://api.github.com/users/ashb/gists{/gist_id}","starred_url":"https://api.github.com/users/ashb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashb/subscriptions","organizations_url":"https://api.github.com/users/ashb/orgs","repos_url":"https://api.github.com/users/ashb/repos","events_url":"https://api.github.com/users/ashb/events{/privacy}","received_events_url":"https://api.github.com/users/ashb/received_events","type":"User","site_admin":false},"body":"Oh I think I understand what you mean - use `env.provider.filter` instead? Good idea. We might need to make those objects returned by each driver share a common interface. Will test if I have a net connection in this meeting","created_at":"2014-05-22T13:43:53Z","updated_at":"2014-05-22T13:43:53Z","html_url":"https://github.com/ministryofjustice/cotton/pull/17#discussion_r12950050","pull_request_url":"https://api.github.com/repos/ministryofjustice/cotton/pulls/17","_links":{"self":{"href":"https://api.github.com/repos/ministryofjustice/cotton/pulls/comments/12950050"},"html":{"href":"https://github.com/ministryofjustice/cotton/pull/17#discussion_r12950050"},"pull_request":{"href":"https://api.github.com/repos/ministryofjustice/cotton/pulls/17"}}}}