GitHub PullRequestEvent at 2014-11-11 04:17:07
Repository: DefinitelyTyped
Actor: chbrown
Payload: {"action":"opened","number":3118,"pull_request":{"url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/pulls/3118","id":24197617,"html_url":"https://github.com/borisyankov/DefinitelyTyped/pull/3118","diff_url":"https://github.com/borisyankov/DefinitelyTyped/pull/3118.diff","patch_url":"https://github.com/borisyankov/DefinitelyTyped/pull/3118.patch","issue_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/issues/3118","number":3118,"state":"open","locked":false,"title":"Fix async.d.ts each* signatures","user":{"login":"chbrown","id":360279,"avatar_url":"https://avatars.githubusercontent.com/u/360279?v=3","gravatar_id":"","url":"https://api.github.com/users/chbrown","html_url":"https://github.com/chbrown","followers_url":"https://api.github.com/users/chbrown/followers","following_url":"https://api.github.com/users/chbrown/following{/other_user}","gists_url":"https://api.github.com/users/chbrown/gists{/gist_id}","starred_url":"https://api.github.com/users/chbrown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chbrown/subscriptions","organizations_url":"https://api.github.com/users/chbrown/orgs","repos_url":"https://api.github.com/users/chbrown/repos","events_url":"https://api.github.com/users/chbrown/events{/privacy}","received_events_url":"https://api.github.com/users/chbrown/received_events","type":"User","site_admin":false},"body":"Sub-tasks:\r\n\r\n1. Add generic ErrorCallback type\r\n2. Rename AsyncIterator -> AsyncResultIterator\r\n3. Add AsyncIterator as resultless iterator type\r\n4. Change each, eachSeries, and eachLimit to use AsyncIterator, since the iterator callback returns nothing but an optional error (I tested this and no, they do not behave like map/mapSeries/mapLimit, even if you call them like that, which is what Ruby's Array does, e.g., `results = [1, 2, 3].each { |x| return x * 2 }`)\r\n5. Rename AsyncMultipleResultsCallback -> AsyncResultsCallback\r\n6. Rename AsyncSingleResultCallback -> AsyncResultCallback\r\n\r\n5 and 6 are not bugfixes, as is 4, but they save space (and caolan's own async documentation doesn't suggest one wording over the other).","created_at":"2014-11-11T04:17:07Z","updated_at":"2014-11-11T04:17:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/pulls/3118/commits","review_comments_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/pulls/3118/comments","review_comment_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/pulls/comments/{number}","comments_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/issues/3118/comments","statuses_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/statuses/cc534e611972a126324f8af40dc026c80fdddb1d","head":{"label":"chbrown:master","ref":"master","sha":"cc534e611972a126324f8af40dc026c80fdddb1d","user":{"login":"chbrown","id":360279,"avatar_url":"https://avatars.githubusercontent.com/u/360279?v=3","gravatar_id":"","url":"https://api.github.com/users/chbrown","html_url":"https://github.com/chbrown","followers_url":"https://api.github.com/users/chbrown/followers","following_url":"https://api.github.com/users/chbrown/following{/other_user}","gists_url":"https://api.github.com/users/chbrown/gists{/gist_id}","starred_url":"https://api.github.com/users/chbrown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chbrown/subscriptions","organizations_url":"https://api.github.com/users/chbrown/orgs","repos_url":"https://api.github.com/users/chbrown/repos","events_url":"https://api.github.com/users/chbrown/events{/privacy}","received_events_url":"https://api.github.com/users/chbrown/received_events","type":"User","site_admin":false},"repo":{"id":25948796,"name":"DefinitelyTyped","full_name":"chbrown/DefinitelyTyped","owner":{"login":"chbrown","id":360279,"avatar_url":"https://avatars.githubusercontent.com/u/360279?v=3","gravatar_id":"","url":"https://api.github.com/users/chbrown","html_url":"https://github.com/chbrown","followers_url":"https://api.github.com/users/chbrown/followers","following_url":"https://api.github.com/users/chbrown/following{/other_user}","gists_url":"https://api.github.com/users/chbrown/gists{/gist_id}","starred_url":"https://api.github.com/users/chbrown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chbrown/subscriptions","organizations_url":"https://api.github.com/users/chbrown/orgs","repos_url":"https://api.github.com/users/chbrown/repos","events_url":"https://api.github.com/users/chbrown/events{/privacy}","received_events_url":"https://api.github.com/users/chbrown/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chbrown/DefinitelyTyped","description":"The repository for high quality TypeScript type definitions.","fork":true,"url":"https://api.github.com/repos/chbrown/DefinitelyTyped","forks_url":"https://api.github.com/repos/chbrown/DefinitelyTyped/forks","keys_url":"https://api.github.com/repos/chbrown/DefinitelyTyped/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chbrown/DefinitelyTyped/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chbrown/DefinitelyTyped/teams","hooks_url":"https://api.github.com/repos/chbrown/DefinitelyTyped/hooks","issue_events_url":"https://api.github.com/repos/chbrown/DefinitelyTyped/issues/events{/number}","events_url":"https://api.github.com/repos/chbrown/DefinitelyTyped/events","assignees_url":"https://api.github.com/repos/chbrown/DefinitelyTyped/assignees{/user}","branches_url":"https://api.github.com/repos/chbrown/DefinitelyTyped/branches{/branch}","tags_url":"https://api.github.com/repos/chbrown/DefinitelyTyped/tags","blobs_url":"https://api.github.com/repos/chbrown/DefinitelyTyped/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chbrown/DefinitelyTyped/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chbrown/DefinitelyTyped/git/refs{/sha}","trees_url":"https://api.github.com/repos/chbrown/DefinitelyTyped/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chbrown/DefinitelyTyped/statuses/{sha}","languages_url":"https://api.github.com/repos/chbrown/DefinitelyTyped/languages","stargazers_url":"https://api.github.com/repos/chbrown/DefinitelyTyped/stargazers","contributors_url":"https://api.github.com/repos/chbrown/DefinitelyTyped/contributors","subscribers_url":"https://api.github.com/repos/chbrown/DefinitelyTyped/subscribers","subscription_url":"https://api.github.com/repos/chbrown/DefinitelyTyped/subscription","commits_url":"https://api.github.com/repos/chbrown/DefinitelyTyped/commits{/sha}","git_commits_url":"https://api.github.com/repos/chbrown/DefinitelyTyped/git/commits{/sha}","comments_url":"https://api.github.com/repos/chbrown/DefinitelyTyped/comments{/number}","issue_comment_url":"https://api.github.com/repos/chbrown/DefinitelyTyped/issues/comments/{number}","contents_url":"https://api.github.com/repos/chbrown/DefinitelyTyped/contents/{+path}","compare_url":"https://api.github.com/repos/chbrown/DefinitelyTyped/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chbrown/DefinitelyTyped/merges","archive_url":"https://api.github.com/repos/chbrown/DefinitelyTyped/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chbrown/DefinitelyTyped/downloads","issues_url":"https://api.github.com/repos/chbrown/DefinitelyTyped/issues{/number}","pulls_url":"https://api.github.com/repos/chbrown/DefinitelyTyped/pulls{/number}","milestones_url":"https://api.github.com/repos/chbrown/DefinitelyTyped/milestones{/number}","notifications_url":"https://api.github.com/repos/chbrown/DefinitelyTyped/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chbrown/DefinitelyTyped/labels{/name}","releases_url":"https://api.github.com/repos/chbrown/DefinitelyTyped/releases{/id}","created_at":"2014-10-30T01:11:22Z","updated_at":"2014-10-30T01:18:35Z","pushed_at":"2014-11-11T04:04:14Z","git_url":"git://github.com/chbrown/DefinitelyTyped.git","ssh_url":"git@github.com:chbrown/DefinitelyTyped.git","clone_url":"https://github.com/chbrown/DefinitelyTyped.git","svn_url":"https://github.com/chbrown/DefinitelyTyped","homepage":"http://definitelytyped.org/","size":19892,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"borisyankov:master","ref":"master","sha":"39531c32fe899cada2cc7e615610644fb6508416","user":{"login":"borisyankov","id":867242,"avatar_url":"https://avatars.githubusercontent.com/u/867242?v=3","gravatar_id":"","url":"https://api.github.com/users/borisyankov","html_url":"https://github.com/borisyankov","followers_url":"https://api.github.com/users/borisyankov/followers","following_url":"https://api.github.com/users/borisyankov/following{/other_user}","gists_url":"https://api.github.com/users/borisyankov/gists{/gist_id}","starred_url":"https://api.github.com/users/borisyankov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/borisyankov/subscriptions","organizations_url":"https://api.github.com/users/borisyankov/orgs","repos_url":"https://api.github.com/users/borisyankov/repos","events_url":"https://api.github.com/users/borisyankov/events{/privacy}","received_events_url":"https://api.github.com/users/borisyankov/received_events","type":"User","site_admin":false},"repo":{"id":6093316,"name":"DefinitelyTyped","full_name":"borisyankov/DefinitelyTyped","owner":{"login":"borisyankov","id":867242,"avatar_url":"https://avatars.githubusercontent.com/u/867242?v=3","gravatar_id":"","url":"https://api.github.com/users/borisyankov","html_url":"https://github.com/borisyankov","followers_url":"https://api.github.com/users/borisyankov/followers","following_url":"https://api.github.com/users/borisyankov/following{/other_user}","gists_url":"https://api.github.com/users/borisyankov/gists{/gist_id}","starred_url":"https://api.github.com/users/borisyankov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/borisyankov/subscriptions","organizations_url":"https://api.github.com/users/borisyankov/orgs","repos_url":"https://api.github.com/users/borisyankov/repos","events_url":"https://api.github.com/users/borisyankov/events{/privacy}","received_events_url":"https://api.github.com/users/borisyankov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/borisyankov/DefinitelyTyped","description":"The repository for high quality TypeScript type definitions.","fork":false,"url":"https://api.github.com/repos/borisyankov/DefinitelyTyped","forks_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/forks","keys_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/keys{/key_id}","collaborators_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/teams","hooks_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/hooks","issue_events_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/issues/events{/number}","events_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/events","assignees_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/assignees{/user}","branches_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/branches{/branch}","tags_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/tags","blobs_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/git/refs{/sha}","trees_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/git/trees{/sha}","statuses_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/statuses/{sha}","languages_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/languages","stargazers_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/stargazers","contributors_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/contributors","subscribers_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/subscribers","subscription_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/subscription","commits_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/commits{/sha}","git_commits_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/git/commits{/sha}","comments_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/comments{/number}","issue_comment_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/issues/comments/{number}","contents_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/contents/{+path}","compare_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/compare/{base}...{head}","merges_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/merges","archive_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/downloads","issues_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/issues{/number}","pulls_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/pulls{/number}","milestones_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/milestones{/number}","notifications_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/labels{/name}","releases_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/releases{/id}","created_at":"2012-10-05T16:39:45Z","updated_at":"2014-11-10T20:14:10Z","pushed_at":"2014-11-10T05:20:26Z","git_url":"git://github.com/borisyankov/DefinitelyTyped.git","ssh_url":"git@github.com:borisyankov/DefinitelyTyped.git","clone_url":"https://github.com/borisyankov/DefinitelyTyped.git","svn_url":"https://github.com/borisyankov/DefinitelyTyped","homepage":"http://definitelytyped.org/","size":56272,"stargazers_count":2761,"watchers_count":2761,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1774,"mirror_url":null,"open_issues_count":354,"forks":1774,"open_issues":354,"watchers":2761,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/borisyankov/DefinitelyTyped/pulls/3118"},"html":{"href":"https://github.com/borisyankov/DefinitelyTyped/pull/3118"},"issue":{"href":"https://api.github.com/repos/borisyankov/DefinitelyTyped/issues/3118"},"comments":{"href":"https://api.github.com/repos/borisyankov/DefinitelyTyped/issues/3118/comments"},"review_comments":{"href":"https://api.github.com/repos/borisyankov/DefinitelyTyped/pulls/3118/comments"},"review_comment":{"href":"https://api.github.com/repos/borisyankov/DefinitelyTyped/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/borisyankov/DefinitelyTyped/pulls/3118/commits"},"statuses":{"href":"https://api.github.com/repos/borisyankov/DefinitelyTyped/statuses/cc534e611972a126324f8af40dc026c80fdddb1d"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":49,"deletions":46,"changed_files":1}}