GitHub PullRequestEvent at 2014-11-19 12:50:03
Repository: go.rice
Actor: xogeny
Payload: {"action":"opened","number":30,"pull_request":{"url":"https://api.github.com/repos/GeertJohan/go.rice/pulls/30","id":24685780,"html_url":"https://github.com/GeertJohan/go.rice/pull/30","diff_url":"https://github.com/GeertJohan/go.rice/pull/30.diff","patch_url":"https://github.com/GeertJohan/go.rice/pull/30.patch","issue_url":"https://api.github.com/repos/GeertJohan/go.rice/issues/30","number":30,"state":"open","locked":false,"title":"Improved diagnostics for cases where FindBox is called without a literal","user":{"login":"xogeny","id":1498808,"avatar_url":"https://avatars.githubusercontent.com/u/1498808?v=3","gravatar_id":"","url":"https://api.github.com/users/xogeny","html_url":"https://github.com/xogeny","followers_url":"https://api.github.com/users/xogeny/followers","following_url":"https://api.github.com/users/xogeny/following{/other_user}","gists_url":"https://api.github.com/users/xogeny/gists{/gist_id}","starred_url":"https://api.github.com/users/xogeny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xogeny/subscriptions","organizations_url":"https://api.github.com/users/xogeny/orgs","repos_url":"https://api.github.com/users/xogeny/repos","events_url":"https://api.github.com/users/xogeny/events{/privacy}","received_events_url":"https://api.github.com/users/xogeny/received_events","type":"User","site_admin":false},"body":"I was pulling my hair out trying to figure out why `rice` wasn't working for me.  It turned out that it was silently ignoring calls to `FindBox` because the argument wasn't a literal.  So I added some output when the verbose flag was set to hint at the problem.  Frankly, I think this should actually be a call to `fmt.Printf` because if somebody is doing this, it is absolutely wrong.  But I wanted to be more conservative about it for now and let you decide.","created_at":"2014-11-19T12:50:03Z","updated_at":"2014-11-19T12:50:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2c385e3dbccd1ea0932160a56473a109c5f83aca","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/GeertJohan/go.rice/pulls/30/commits","review_comments_url":"https://api.github.com/repos/GeertJohan/go.rice/pulls/30/comments","review_comment_url":"https://api.github.com/repos/GeertJohan/go.rice/pulls/comments/{number}","comments_url":"https://api.github.com/repos/GeertJohan/go.rice/issues/30/comments","statuses_url":"https://api.github.com/repos/GeertJohan/go.rice/statuses/c3e11e5e3097a4379a1defb6cce360d010f2c591","head":{"label":"xogeny:master","ref":"master","sha":"c3e11e5e3097a4379a1defb6cce360d010f2c591","user":{"login":"xogeny","id":1498808,"avatar_url":"https://avatars.githubusercontent.com/u/1498808?v=3","gravatar_id":"","url":"https://api.github.com/users/xogeny","html_url":"https://github.com/xogeny","followers_url":"https://api.github.com/users/xogeny/followers","following_url":"https://api.github.com/users/xogeny/following{/other_user}","gists_url":"https://api.github.com/users/xogeny/gists{/gist_id}","starred_url":"https://api.github.com/users/xogeny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xogeny/subscriptions","organizations_url":"https://api.github.com/users/xogeny/orgs","repos_url":"https://api.github.com/users/xogeny/repos","events_url":"https://api.github.com/users/xogeny/events{/privacy}","received_events_url":"https://api.github.com/users/xogeny/received_events","type":"User","site_admin":false},"repo":{"id":26859565,"name":"go.rice","full_name":"xogeny/go.rice","owner":{"login":"xogeny","id":1498808,"avatar_url":"https://avatars.githubusercontent.com/u/1498808?v=3","gravatar_id":"","url":"https://api.github.com/users/xogeny","html_url":"https://github.com/xogeny","followers_url":"https://api.github.com/users/xogeny/followers","following_url":"https://api.github.com/users/xogeny/following{/other_user}","gists_url":"https://api.github.com/users/xogeny/gists{/gist_id}","starred_url":"https://api.github.com/users/xogeny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xogeny/subscriptions","organizations_url":"https://api.github.com/users/xogeny/orgs","repos_url":"https://api.github.com/users/xogeny/repos","events_url":"https://api.github.com/users/xogeny/events{/privacy}","received_events_url":"https://api.github.com/users/xogeny/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xogeny/go.rice","description":"go.rice is a Go package that makes working with resources such as html,js,css,images,templates, etc very easy.","fork":true,"url":"https://api.github.com/repos/xogeny/go.rice","forks_url":"https://api.github.com/repos/xogeny/go.rice/forks","keys_url":"https://api.github.com/repos/xogeny/go.rice/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xogeny/go.rice/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xogeny/go.rice/teams","hooks_url":"https://api.github.com/repos/xogeny/go.rice/hooks","issue_events_url":"https://api.github.com/repos/xogeny/go.rice/issues/events{/number}","events_url":"https://api.github.com/repos/xogeny/go.rice/events","assignees_url":"https://api.github.com/repos/xogeny/go.rice/assignees{/user}","branches_url":"https://api.github.com/repos/xogeny/go.rice/branches{/branch}","tags_url":"https://api.github.com/repos/xogeny/go.rice/tags","blobs_url":"https://api.github.com/repos/xogeny/go.rice/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xogeny/go.rice/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xogeny/go.rice/git/refs{/sha}","trees_url":"https://api.github.com/repos/xogeny/go.rice/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xogeny/go.rice/statuses/{sha}","languages_url":"https://api.github.com/repos/xogeny/go.rice/languages","stargazers_url":"https://api.github.com/repos/xogeny/go.rice/stargazers","contributors_url":"https://api.github.com/repos/xogeny/go.rice/contributors","subscribers_url":"https://api.github.com/repos/xogeny/go.rice/subscribers","subscription_url":"https://api.github.com/repos/xogeny/go.rice/subscription","commits_url":"https://api.github.com/repos/xogeny/go.rice/commits{/sha}","git_commits_url":"https://api.github.com/repos/xogeny/go.rice/git/commits{/sha}","comments_url":"https://api.github.com/repos/xogeny/go.rice/comments{/number}","issue_comment_url":"https://api.github.com/repos/xogeny/go.rice/issues/comments/{number}","contents_url":"https://api.github.com/repos/xogeny/go.rice/contents/{+path}","compare_url":"https://api.github.com/repos/xogeny/go.rice/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xogeny/go.rice/merges","archive_url":"https://api.github.com/repos/xogeny/go.rice/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xogeny/go.rice/downloads","issues_url":"https://api.github.com/repos/xogeny/go.rice/issues{/number}","pulls_url":"https://api.github.com/repos/xogeny/go.rice/pulls{/number}","milestones_url":"https://api.github.com/repos/xogeny/go.rice/milestones{/number}","notifications_url":"https://api.github.com/repos/xogeny/go.rice/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xogeny/go.rice/labels{/name}","releases_url":"https://api.github.com/repos/xogeny/go.rice/releases{/id}","created_at":"2014-11-19T12:04:35Z","updated_at":"2014-11-19T12:48:07Z","pushed_at":"2014-11-19T12:48:06Z","git_url":"git://github.com/xogeny/go.rice.git","ssh_url":"git@github.com:xogeny/go.rice.git","clone_url":"https://github.com/xogeny/go.rice.git","svn_url":"https://github.com/xogeny/go.rice","homepage":"","size":910,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GeertJohan:master","ref":"master","sha":"39f86d7b1005dfe34c336f529ecc464e0da55676","user":{"login":"GeertJohan","id":564501,"avatar_url":"https://avatars.githubusercontent.com/u/564501?v=3","gravatar_id":"","url":"https://api.github.com/users/GeertJohan","html_url":"https://github.com/GeertJohan","followers_url":"https://api.github.com/users/GeertJohan/followers","following_url":"https://api.github.com/users/GeertJohan/following{/other_user}","gists_url":"https://api.github.com/users/GeertJohan/gists{/gist_id}","starred_url":"https://api.github.com/users/GeertJohan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GeertJohan/subscriptions","organizations_url":"https://api.github.com/users/GeertJohan/orgs","repos_url":"https://api.github.com/users/GeertJohan/repos","events_url":"https://api.github.com/users/GeertJohan/events{/privacy}","received_events_url":"https://api.github.com/users/GeertJohan/received_events","type":"User","site_admin":false},"repo":{"id":13815417,"name":"go.rice","full_name":"GeertJohan/go.rice","owner":{"login":"GeertJohan","id":564501,"avatar_url":"https://avatars.githubusercontent.com/u/564501?v=3","gravatar_id":"","url":"https://api.github.com/users/GeertJohan","html_url":"https://github.com/GeertJohan","followers_url":"https://api.github.com/users/GeertJohan/followers","following_url":"https://api.github.com/users/GeertJohan/following{/other_user}","gists_url":"https://api.github.com/users/GeertJohan/gists{/gist_id}","starred_url":"https://api.github.com/users/GeertJohan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GeertJohan/subscriptions","organizations_url":"https://api.github.com/users/GeertJohan/orgs","repos_url":"https://api.github.com/users/GeertJohan/repos","events_url":"https://api.github.com/users/GeertJohan/events{/privacy}","received_events_url":"https://api.github.com/users/GeertJohan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/GeertJohan/go.rice","description":"go.rice is a Go package that makes working with resources such as html,js,css,images,templates, etc very easy.","fork":false,"url":"https://api.github.com/repos/GeertJohan/go.rice","forks_url":"https://api.github.com/repos/GeertJohan/go.rice/forks","keys_url":"https://api.github.com/repos/GeertJohan/go.rice/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GeertJohan/go.rice/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GeertJohan/go.rice/teams","hooks_url":"https://api.github.com/repos/GeertJohan/go.rice/hooks","issue_events_url":"https://api.github.com/repos/GeertJohan/go.rice/issues/events{/number}","events_url":"https://api.github.com/repos/GeertJohan/go.rice/events","assignees_url":"https://api.github.com/repos/GeertJohan/go.rice/assignees{/user}","branches_url":"https://api.github.com/repos/GeertJohan/go.rice/branches{/branch}","tags_url":"https://api.github.com/repos/GeertJohan/go.rice/tags","blobs_url":"https://api.github.com/repos/GeertJohan/go.rice/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GeertJohan/go.rice/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GeertJohan/go.rice/git/refs{/sha}","trees_url":"https://api.github.com/repos/GeertJohan/go.rice/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GeertJohan/go.rice/statuses/{sha}","languages_url":"https://api.github.com/repos/GeertJohan/go.rice/languages","stargazers_url":"https://api.github.com/repos/GeertJohan/go.rice/stargazers","contributors_url":"https://api.github.com/repos/GeertJohan/go.rice/contributors","subscribers_url":"https://api.github.com/repos/GeertJohan/go.rice/subscribers","subscription_url":"https://api.github.com/repos/GeertJohan/go.rice/subscription","commits_url":"https://api.github.com/repos/GeertJohan/go.rice/commits{/sha}","git_commits_url":"https://api.github.com/repos/GeertJohan/go.rice/git/commits{/sha}","comments_url":"https://api.github.com/repos/GeertJohan/go.rice/comments{/number}","issue_comment_url":"https://api.github.com/repos/GeertJohan/go.rice/issues/comments/{number}","contents_url":"https://api.github.com/repos/GeertJohan/go.rice/contents/{+path}","compare_url":"https://api.github.com/repos/GeertJohan/go.rice/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GeertJohan/go.rice/merges","archive_url":"https://api.github.com/repos/GeertJohan/go.rice/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GeertJohan/go.rice/downloads","issues_url":"https://api.github.com/repos/GeertJohan/go.rice/issues{/number}","pulls_url":"https://api.github.com/repos/GeertJohan/go.rice/pulls{/number}","milestones_url":"https://api.github.com/repos/GeertJohan/go.rice/milestones{/number}","notifications_url":"https://api.github.com/repos/GeertJohan/go.rice/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GeertJohan/go.rice/labels{/name}","releases_url":"https://api.github.com/repos/GeertJohan/go.rice/releases{/id}","created_at":"2013-10-23T21:29:34Z","updated_at":"2014-11-15T23:11:08Z","pushed_at":"2014-11-04T15:37:58Z","git_url":"git://github.com/GeertJohan/go.rice.git","ssh_url":"git@github.com:GeertJohan/go.rice.git","clone_url":"https://github.com/GeertJohan/go.rice.git","svn_url":"https://github.com/GeertJohan/go.rice","homepage":"","size":910,"stargazers_count":282,"watchers_count":282,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":5,"forks":16,"open_issues":5,"watchers":282,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GeertJohan/go.rice/pulls/30"},"html":{"href":"https://github.com/GeertJohan/go.rice/pull/30"},"issue":{"href":"https://api.github.com/repos/GeertJohan/go.rice/issues/30"},"comments":{"href":"https://api.github.com/repos/GeertJohan/go.rice/issues/30/comments"},"review_comments":{"href":"https://api.github.com/repos/GeertJohan/go.rice/pulls/30/comments"},"review_comment":{"href":"https://api.github.com/repos/GeertJohan/go.rice/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/GeertJohan/go.rice/pulls/30/commits"},"statuses":{"href":"https://api.github.com/repos/GeertJohan/go.rice/statuses/c3e11e5e3097a4379a1defb6cce360d010f2c591"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":11,"deletions":6,"changed_files":1}}