GitHub PullRequestReviewCommentEvent at 2014-10-27 23:14:20
Repository: docker
Actor: thaJeztah
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/docker/docker/pulls/comments/19444373","id":19444373,"diff_hunk":"@@ -104,6 +104,46 @@ be treated as an argument. This allows statements like:\n Here is the set of instructions you can use in a `Dockerfile` for building\n images.\n \n+### Environment Replacement\n+\n+**Note:** prior to 1.3, `Dockerfile` environment variables were handled\n+similarly, in that they would be replaced as described below. However, there\n+was no formal definition on what instructions handled environment replacement\n+at the time. After 1.3 this behavior will be preserved and canonical.\n+\n+Environment variables (declared with the `ENV` statement) can also be used in\n+certain instructions as variables to be interpreted by the `Dockerfile`. Escapes\n+are also handled for including variable-like syntax into a statement literally.\n+\n+Environment variables are notated in the `Dockerfile` either with\n+`$variable_name` or `${variable_name}`. They are treated equivalently and the\n+brace syntax is typically used to address issues with variable names with no\n+whitespace, like `${foo}_bar`.\n+\n+Escaping is possible by adding a `\\` before the variable: `\\$foo` or `\\${foo}`,\n+for example, will translate to `$foo` and `${foo}` literals respectively.\n+ \n+Example (parsed representation is displayed after the `#`):\n+\n+    FROM busybox\n+    ENV foo /bar\n+    WORKDIR ${foo}   # WORKDIR /bar\n+    ADD . $foo       # ADD . /bar\n+    COPY \\$foo /quux # COPY $foo /quux\n+\n+The instructions that handle environment variables in the `Dockerfile` are:\n+\n+* `ENV`\n+* `ADD`\n+* `COPY`\n+* `WORKDIR`\n+* `EXPOSE`\n+* `VOLUME`\n+* `USER`\n+\n+`ONBUILD` instructions are **NOT** supported for environment replacement, even\n+the instructions above.","path":"docs/sources/reference/builder.md","position":42,"original_position":42,"commit_id":"9258e4f737a548c3affba1f06197254468ec173c","original_commit_id":"9258e4f737a548c3affba1f06197254468ec173c","user":{"login":"thaJeztah","id":1804568,"avatar_url":"https://avatars.githubusercontent.com/u/1804568?v=2","gravatar_id":"","url":"https://api.github.com/users/thaJeztah","html_url":"https://github.com/thaJeztah","followers_url":"https://api.github.com/users/thaJeztah/followers","following_url":"https://api.github.com/users/thaJeztah/following{/other_user}","gists_url":"https://api.github.com/users/thaJeztah/gists{/gist_id}","starred_url":"https://api.github.com/users/thaJeztah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thaJeztah/subscriptions","organizations_url":"https://api.github.com/users/thaJeztah/orgs","repos_url":"https://api.github.com/users/thaJeztah/repos","events_url":"https://api.github.com/users/thaJeztah/events{/privacy}","received_events_url":"https://api.github.com/users/thaJeztah/received_events","type":"User","site_admin":false},"body":"Nothing to stop this from being merged, but reading this, I wonder *why* and perhaps this needs some extra clarification; is this by design? Not implemented (yet)? Not supported because of possible security implications?\r\n\r\nA bit of explanation may prevent needless support tickets and/or discussions.","created_at":"2014-10-27T23:14:20Z","updated_at":"2014-10-27T23:14:20Z","html_url":"https://github.com/docker/docker/pull/8807#discussion_r19444373","pull_request_url":"https://api.github.com/repos/docker/docker/pulls/8807","_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/comments/19444373"},"html":{"href":"https://github.com/docker/docker/pull/8807#discussion_r19444373"},"pull_request":{"href":"https://api.github.com/repos/docker/docker/pulls/8807"}}},"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/8807","id":23411827,"html_url":"https://github.com/docker/docker/pull/8807","diff_url":"https://github.com/docker/docker/pull/8807.diff","patch_url":"https://github.com/docker/docker/pull/8807.patch","issue_url":"https://api.github.com/repos/docker/docker/issues/8807","number":8807,"state":"open","locked":false,"title":"builder: Update documentation WRT environment replacement","user":{"login":"erikh","id":18923,"avatar_url":"https://avatars.githubusercontent.com/u/18923?v=2","gravatar_id":"","url":"https://api.github.com/users/erikh","html_url":"https://github.com/erikh","followers_url":"https://api.github.com/users/erikh/followers","following_url":"https://api.github.com/users/erikh/following{/other_user}","gists_url":"https://api.github.com/users/erikh/gists{/gist_id}","starred_url":"https://api.github.com/users/erikh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikh/subscriptions","organizations_url":"https://api.github.com/users/erikh/orgs","repos_url":"https://api.github.com/users/erikh/repos","events_url":"https://api.github.com/users/erikh/events{/privacy}","received_events_url":"https://api.github.com/users/erikh/received_events","type":"User","site_admin":false},"body":"@fredlf @SvenDowideit @jamtur01 @tiborvass ","created_at":"2014-10-27T20:09:04Z","updated_at":"2014-10-27T23:14:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"606abee512d92edeed461667ba825ac286dfd47c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/docker/docker/pulls/8807/commits","review_comments_url":"https://api.github.com/repos/docker/docker/pulls/8807/comments","review_comment_url":"https://api.github.com/repos/docker/docker/pulls/comments/{number}","comments_url":"https://api.github.com/repos/docker/docker/issues/8807/comments","statuses_url":"https://api.github.com/repos/docker/docker/statuses/9258e4f737a548c3affba1f06197254468ec173c","head":{"label":"erikh:builder_docs","ref":"builder_docs","sha":"9258e4f737a548c3affba1f06197254468ec173c","user":{"login":"erikh","id":18923,"avatar_url":"https://avatars.githubusercontent.com/u/18923?v=2","gravatar_id":"","url":"https://api.github.com/users/erikh","html_url":"https://github.com/erikh","followers_url":"https://api.github.com/users/erikh/followers","following_url":"https://api.github.com/users/erikh/following{/other_user}","gists_url":"https://api.github.com/users/erikh/gists{/gist_id}","starred_url":"https://api.github.com/users/erikh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikh/subscriptions","organizations_url":"https://api.github.com/users/erikh/orgs","repos_url":"https://api.github.com/users/erikh/repos","events_url":"https://api.github.com/users/erikh/events{/privacy}","received_events_url":"https://api.github.com/users/erikh/received_events","type":"User","site_admin":false},"repo":{"id":17471699,"name":"docker","full_name":"erikh/docker","owner":{"login":"erikh","id":18923,"avatar_url":"https://avatars.githubusercontent.com/u/18923?v=2","gravatar_id":"","url":"https://api.github.com/users/erikh","html_url":"https://github.com/erikh","followers_url":"https://api.github.com/users/erikh/followers","following_url":"https://api.github.com/users/erikh/following{/other_user}","gists_url":"https://api.github.com/users/erikh/gists{/gist_id}","starred_url":"https://api.github.com/users/erikh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikh/subscriptions","organizations_url":"https://api.github.com/users/erikh/orgs","repos_url":"https://api.github.com/users/erikh/repos","events_url":"https://api.github.com/users/erikh/events{/privacy}","received_events_url":"https://api.github.com/users/erikh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/erikh/docker","description":"Docker - the open-source application container engine","fork":true,"url":"https://api.github.com/repos/erikh/docker","forks_url":"https://api.github.com/repos/erikh/docker/forks","keys_url":"https://api.github.com/repos/erikh/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/erikh/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/erikh/docker/teams","hooks_url":"https://api.github.com/repos/erikh/docker/hooks","issue_events_url":"https://api.github.com/repos/erikh/docker/issues/events{/number}","events_url":"https://api.github.com/repos/erikh/docker/events","assignees_url":"https://api.github.com/repos/erikh/docker/assignees{/user}","branches_url":"https://api.github.com/repos/erikh/docker/branches{/branch}","tags_url":"https://api.github.com/repos/erikh/docker/tags","blobs_url":"https://api.github.com/repos/erikh/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/erikh/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/erikh/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/erikh/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/erikh/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/erikh/docker/languages","stargazers_url":"https://api.github.com/repos/erikh/docker/stargazers","contributors_url":"https://api.github.com/repos/erikh/docker/contributors","subscribers_url":"https://api.github.com/repos/erikh/docker/subscribers","subscription_url":"https://api.github.com/repos/erikh/docker/subscription","commits_url":"https://api.github.com/repos/erikh/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/erikh/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/erikh/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/erikh/docker/issues/comments/{number}","contents_url":"https://api.github.com/repos/erikh/docker/contents/{+path}","compare_url":"https://api.github.com/repos/erikh/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/erikh/docker/merges","archive_url":"https://api.github.com/repos/erikh/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/erikh/docker/downloads","issues_url":"https://api.github.com/repos/erikh/docker/issues{/number}","pulls_url":"https://api.github.com/repos/erikh/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/erikh/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/erikh/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/erikh/docker/labels{/name}","releases_url":"https://api.github.com/repos/erikh/docker/releases{/id}","created_at":"2014-03-06T08:54:07Z","updated_at":"2014-07-03T07:21:47Z","pushed_at":"2014-10-27T22:57:22Z","git_url":"git://github.com/erikh/docker.git","ssh_url":"git@github.com:erikh/docker.git","clone_url":"https://github.com/erikh/docker.git","svn_url":"https://github.com/erikh/docker","homepage":"http://www.docker.io","size":38464,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"039f2257680f31834aca655dca4ec93a25c2451c","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=2","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":7691631,"name":"docker","full_name":"docker/docker","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=2","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/docker","description":"Docker - the open-source application container engine","fork":false,"url":"https://api.github.com/repos/docker/docker","forks_url":"https://api.github.com/repos/docker/docker/forks","keys_url":"https://api.github.com/repos/docker/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/docker/teams","hooks_url":"https://api.github.com/repos/docker/docker/hooks","issue_events_url":"https://api.github.com/repos/docker/docker/issues/events{/number}","events_url":"https://api.github.com/repos/docker/docker/events","assignees_url":"https://api.github.com/repos/docker/docker/assignees{/user}","branches_url":"https://api.github.com/repos/docker/docker/branches{/branch}","tags_url":"https://api.github.com/repos/docker/docker/tags","blobs_url":"https://api.github.com/repos/docker/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/docker/languages","stargazers_url":"https://api.github.com/repos/docker/docker/stargazers","contributors_url":"https://api.github.com/repos/docker/docker/contributors","subscribers_url":"https://api.github.com/repos/docker/docker/subscribers","subscription_url":"https://api.github.com/repos/docker/docker/subscription","commits_url":"https://api.github.com/repos/docker/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/docker/issues/comments/{number}","contents_url":"https://api.github.com/repos/docker/docker/contents/{+path}","compare_url":"https://api.github.com/repos/docker/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/docker/merges","archive_url":"https://api.github.com/repos/docker/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/docker/downloads","issues_url":"https://api.github.com/repos/docker/docker/issues{/number}","pulls_url":"https://api.github.com/repos/docker/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/docker/labels{/name}","releases_url":"https://api.github.com/repos/docker/docker/releases{/id}","created_at":"2013-01-18T18:10:57Z","updated_at":"2014-10-27T22:13:56Z","pushed_at":"2014-10-27T22:08:45Z","git_url":"git://github.com/docker/docker.git","ssh_url":"git@github.com:docker/docker.git","clone_url":"https://github.com/docker/docker.git","svn_url":"https://github.com/docker/docker","homepage":"http://www.docker.com","size":152702,"stargazers_count":16082,"watchers_count":16082,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3131,"mirror_url":null,"open_issues_count":837,"forks":3131,"open_issues":837,"watchers":16082,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/8807"},"html":{"href":"https://github.com/docker/docker/pull/8807"},"issue":{"href":"https://api.github.com/repos/docker/docker/issues/8807"},"comments":{"href":"https://api.github.com/repos/docker/docker/issues/8807/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/docker/pulls/8807/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/docker/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/docker/docker/pulls/8807/commits"},"statuses":{"href":"https://api.github.com/repos/docker/docker/statuses/9258e4f737a548c3affba1f06197254468ec173c"}}}}