GitHub PullRequestEvent at 2014-05-22 06:28:31
Repository: zucchini
Actor: vaskas
Payload: {"action":"closed","number":54,"pull_request":{"url":"https://api.github.com/repos/zucchini-src/zucchini/pulls/54","id":15622434,"html_url":"https://github.com/zucchini-src/zucchini/pull/54","diff_url":"https://github.com/zucchini-src/zucchini/pull/54.diff","patch_url":"https://github.com/zucchini-src/zucchini/pull/54.patch","issue_url":"https://api.github.com/repos/zucchini-src/zucchini/issues/54","number":54,"state":"closed","title":"Image comparison fixes","user":{"login":"ncolton","id":2752720,"avatar_url":"https://avatars.githubusercontent.com/u/2752720?","gravatar_id":"25b80456d434e6fe3d1a965aa83fdea3","url":"https://api.github.com/users/ncolton","html_url":"https://github.com/ncolton","followers_url":"https://api.github.com/users/ncolton/followers","following_url":"https://api.github.com/users/ncolton/following{/other_user}","gists_url":"https://api.github.com/users/ncolton/gists{/gist_id}","starred_url":"https://api.github.com/users/ncolton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncolton/subscriptions","organizations_url":"https://api.github.com/users/ncolton/orgs","repos_url":"https://api.github.com/users/ncolton/repos","events_url":"https://api.github.com/users/ncolton/events{/privacy}","received_events_url":"https://api.github.com/users/ncolton/received_events","type":"User","site_admin":false},"body":"Version 6.8.8-9 of ImageMagick's compare returns 2 on error, 0 if the images are similar, and 1 if they are dissimilar. Rather than using the output of compare, this changes the code to use the actual return code.\r\n\r\nWhen using compare, the actual output of the command is \"0 @ 0,0\" if the images are similar. I'm presuming, based on the previous code, that \"0\" was output to STDOUT (or STDERR) if the images were similar.\r\n\r\nUnfortunately I don't really understand the purpose that `-subimage-search` was serving in the code, but on removal, these tests go from:\r\n```\r\nZucchini::Screenshot\r\n  general\r\n    compare\r\n      images are different\r\n        should have a failed indicator in the diff (FAILED - 1)\r\n        should have a failed indicator in the diff with no screen mask (FAILED - 2)\r\n```\r\nto passing on my system.","created_at":"2014-05-07T21:52:15Z","updated_at":"2014-05-22T06:28:31Z","closed_at":"2014-05-22T06:28:31Z","merged_at":"2014-05-22T06:28:31Z","merge_commit_sha":"d43bf3eb6ef9f0d2774b7a9dfa24fd0b35612238","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/zucchini-src/zucchini/pulls/54/commits","review_comments_url":"https://api.github.com/repos/zucchini-src/zucchini/pulls/54/comments","review_comment_url":"https://api.github.com/repos/zucchini-src/zucchini/pulls/comments/{number}","comments_url":"https://api.github.com/repos/zucchini-src/zucchini/issues/54/comments","statuses_url":"https://api.github.com/repos/zucchini-src/zucchini/statuses/73a65806f402c9f6ac8f88afa89478b784e17d5d","head":{"label":"ncolton:image_comparison_fixes","ref":"image_comparison_fixes","sha":"73a65806f402c9f6ac8f88afa89478b784e17d5d","user":{"login":"ncolton","id":2752720,"avatar_url":"https://avatars.githubusercontent.com/u/2752720?","gravatar_id":"25b80456d434e6fe3d1a965aa83fdea3","url":"https://api.github.com/users/ncolton","html_url":"https://github.com/ncolton","followers_url":"https://api.github.com/users/ncolton/followers","following_url":"https://api.github.com/users/ncolton/following{/other_user}","gists_url":"https://api.github.com/users/ncolton/gists{/gist_id}","starred_url":"https://api.github.com/users/ncolton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncolton/subscriptions","organizations_url":"https://api.github.com/users/ncolton/orgs","repos_url":"https://api.github.com/users/ncolton/repos","events_url":"https://api.github.com/users/ncolton/events{/privacy}","received_events_url":"https://api.github.com/users/ncolton/received_events","type":"User","site_admin":false},"repo":{"id":19381339,"name":"zucchini","full_name":"ncolton/zucchini","owner":{"login":"ncolton","id":2752720,"avatar_url":"https://avatars.githubusercontent.com/u/2752720?","gravatar_id":"25b80456d434e6fe3d1a965aa83fdea3","url":"https://api.github.com/users/ncolton","html_url":"https://github.com/ncolton","followers_url":"https://api.github.com/users/ncolton/followers","following_url":"https://api.github.com/users/ncolton/following{/other_user}","gists_url":"https://api.github.com/users/ncolton/gists{/gist_id}","starred_url":"https://api.github.com/users/ncolton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncolton/subscriptions","organizations_url":"https://api.github.com/users/ncolton/orgs","repos_url":"https://api.github.com/users/ncolton/repos","events_url":"https://api.github.com/users/ncolton/events{/privacy}","received_events_url":"https://api.github.com/users/ncolton/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ncolton/zucchini","description":"A visual iOS testing framework","fork":true,"url":"https://api.github.com/repos/ncolton/zucchini","forks_url":"https://api.github.com/repos/ncolton/zucchini/forks","keys_url":"https://api.github.com/repos/ncolton/zucchini/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ncolton/zucchini/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ncolton/zucchini/teams","hooks_url":"https://api.github.com/repos/ncolton/zucchini/hooks","issue_events_url":"https://api.github.com/repos/ncolton/zucchini/issues/events{/number}","events_url":"https://api.github.com/repos/ncolton/zucchini/events","assignees_url":"https://api.github.com/repos/ncolton/zucchini/assignees{/user}","branches_url":"https://api.github.com/repos/ncolton/zucchini/branches{/branch}","tags_url":"https://api.github.com/repos/ncolton/zucchini/tags","blobs_url":"https://api.github.com/repos/ncolton/zucchini/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ncolton/zucchini/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ncolton/zucchini/git/refs{/sha}","trees_url":"https://api.github.com/repos/ncolton/zucchini/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ncolton/zucchini/statuses/{sha}","languages_url":"https://api.github.com/repos/ncolton/zucchini/languages","stargazers_url":"https://api.github.com/repos/ncolton/zucchini/stargazers","contributors_url":"https://api.github.com/repos/ncolton/zucchini/contributors","subscribers_url":"https://api.github.com/repos/ncolton/zucchini/subscribers","subscription_url":"https://api.github.com/repos/ncolton/zucchini/subscription","commits_url":"https://api.github.com/repos/ncolton/zucchini/commits{/sha}","git_commits_url":"https://api.github.com/repos/ncolton/zucchini/git/commits{/sha}","comments_url":"https://api.github.com/repos/ncolton/zucchini/comments{/number}","issue_comment_url":"https://api.github.com/repos/ncolton/zucchini/issues/comments/{number}","contents_url":"https://api.github.com/repos/ncolton/zucchini/contents/{+path}","compare_url":"https://api.github.com/repos/ncolton/zucchini/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ncolton/zucchini/merges","archive_url":"https://api.github.com/repos/ncolton/zucchini/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ncolton/zucchini/downloads","issues_url":"https://api.github.com/repos/ncolton/zucchini/issues{/number}","pulls_url":"https://api.github.com/repos/ncolton/zucchini/pulls{/number}","milestones_url":"https://api.github.com/repos/ncolton/zucchini/milestones{/number}","notifications_url":"https://api.github.com/repos/ncolton/zucchini/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ncolton/zucchini/labels{/name}","releases_url":"https://api.github.com/repos/ncolton/zucchini/releases{/id}","created_at":"2014-05-02T16:38:59Z","updated_at":"2014-05-22T06:28:31Z","pushed_at":"2014-05-22T04:21:19Z","git_url":"git://github.com/ncolton/zucchini.git","ssh_url":"git@github.com:ncolton/zucchini.git","clone_url":"https://github.com/ncolton/zucchini.git","svn_url":"https://github.com/ncolton/zucchini","homepage":"zucchiniframework.org","size":2397,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zucchini-src:master","ref":"master","sha":"878928625426f7ed180611ce68cef66a2139caf3","user":{"login":"zucchini-src","id":3008616,"avatar_url":"https://avatars.githubusercontent.com/u/3008616?","gravatar_id":"3b50c6606f0ec340ef47f87ab4bfc89b","url":"https://api.github.com/users/zucchini-src","html_url":"https://github.com/zucchini-src","followers_url":"https://api.github.com/users/zucchini-src/followers","following_url":"https://api.github.com/users/zucchini-src/following{/other_user}","gists_url":"https://api.github.com/users/zucchini-src/gists{/gist_id}","starred_url":"https://api.github.com/users/zucchini-src/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zucchini-src/subscriptions","organizations_url":"https://api.github.com/users/zucchini-src/orgs","repos_url":"https://api.github.com/users/zucchini-src/repos","events_url":"https://api.github.com/users/zucchini-src/events{/privacy}","received_events_url":"https://api.github.com/users/zucchini-src/received_events","type":"Organization","site_admin":false},"repo":{"id":7095874,"name":"zucchini","full_name":"zucchini-src/zucchini","owner":{"login":"zucchini-src","id":3008616,"avatar_url":"https://avatars.githubusercontent.com/u/3008616?","gravatar_id":"3b50c6606f0ec340ef47f87ab4bfc89b","url":"https://api.github.com/users/zucchini-src","html_url":"https://github.com/zucchini-src","followers_url":"https://api.github.com/users/zucchini-src/followers","following_url":"https://api.github.com/users/zucchini-src/following{/other_user}","gists_url":"https://api.github.com/users/zucchini-src/gists{/gist_id}","starred_url":"https://api.github.com/users/zucchini-src/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zucchini-src/subscriptions","organizations_url":"https://api.github.com/users/zucchini-src/orgs","repos_url":"https://api.github.com/users/zucchini-src/repos","events_url":"https://api.github.com/users/zucchini-src/events{/privacy}","received_events_url":"https://api.github.com/users/zucchini-src/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zucchini-src/zucchini","description":"A visual iOS testing framework","fork":true,"url":"https://api.github.com/repos/zucchini-src/zucchini","forks_url":"https://api.github.com/repos/zucchini-src/zucchini/forks","keys_url":"https://api.github.com/repos/zucchini-src/zucchini/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zucchini-src/zucchini/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zucchini-src/zucchini/teams","hooks_url":"https://api.github.com/repos/zucchini-src/zucchini/hooks","issue_events_url":"https://api.github.com/repos/zucchini-src/zucchini/issues/events{/number}","events_url":"https://api.github.com/repos/zucchini-src/zucchini/events","assignees_url":"https://api.github.com/repos/zucchini-src/zucchini/assignees{/user}","branches_url":"https://api.github.com/repos/zucchini-src/zucchini/branches{/branch}","tags_url":"https://api.github.com/repos/zucchini-src/zucchini/tags","blobs_url":"https://api.github.com/repos/zucchini-src/zucchini/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zucchini-src/zucchini/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zucchini-src/zucchini/git/refs{/sha}","trees_url":"https://api.github.com/repos/zucchini-src/zucchini/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zucchini-src/zucchini/statuses/{sha}","languages_url":"https://api.github.com/repos/zucchini-src/zucchini/languages","stargazers_url":"https://api.github.com/repos/zucchini-src/zucchini/stargazers","contributors_url":"https://api.github.com/repos/zucchini-src/zucchini/contributors","subscribers_url":"https://api.github.com/repos/zucchini-src/zucchini/subscribers","subscription_url":"https://api.github.com/repos/zucchini-src/zucchini/subscription","commits_url":"https://api.github.com/repos/zucchini-src/zucchini/commits{/sha}","git_commits_url":"https://api.github.com/repos/zucchini-src/zucchini/git/commits{/sha}","comments_url":"https://api.github.com/repos/zucchini-src/zucchini/comments{/number}","issue_comment_url":"https://api.github.com/repos/zucchini-src/zucchini/issues/comments/{number}","contents_url":"https://api.github.com/repos/zucchini-src/zucchini/contents/{+path}","compare_url":"https://api.github.com/repos/zucchini-src/zucchini/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zucchini-src/zucchini/merges","archive_url":"https://api.github.com/repos/zucchini-src/zucchini/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zucchini-src/zucchini/downloads","issues_url":"https://api.github.com/repos/zucchini-src/zucchini/issues{/number}","pulls_url":"https://api.github.com/repos/zucchini-src/zucchini/pulls{/number}","milestones_url":"https://api.github.com/repos/zucchini-src/zucchini/milestones{/number}","notifications_url":"https://api.github.com/repos/zucchini-src/zucchini/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zucchini-src/zucchini/labels{/name}","releases_url":"https://api.github.com/repos/zucchini-src/zucchini/releases{/id}","created_at":"2012-12-10T15:41:46Z","updated_at":"2014-05-22T06:28:31Z","pushed_at":"2014-05-22T06:28:31Z","git_url":"git://github.com/zucchini-src/zucchini.git","ssh_url":"git@github.com:zucchini-src/zucchini.git","clone_url":"https://github.com/zucchini-src/zucchini.git","svn_url":"https://github.com/zucchini-src/zucchini","homepage":"zucchiniframework.org","size":3240,"stargazers_count":133,"watchers_count":133,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":20,"mirror_url":null,"open_issues_count":14,"forks":20,"open_issues":14,"watchers":133,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zucchini-src/zucchini/pulls/54"},"html":{"href":"https://github.com/zucchini-src/zucchini/pull/54"},"issue":{"href":"https://api.github.com/repos/zucchini-src/zucchini/issues/54"},"comments":{"href":"https://api.github.com/repos/zucchini-src/zucchini/issues/54/comments"},"review_comments":{"href":"https://api.github.com/repos/zucchini-src/zucchini/pulls/54/comments"},"review_comment":{"href":"https://api.github.com/repos/zucchini-src/zucchini/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/zucchini-src/zucchini/pulls/54/commits"},"statuses":{"href":"https://api.github.com/repos/zucchini-src/zucchini/statuses/73a65806f402c9f6ac8f88afa89478b784e17d5d"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"vaskas","id":67034,"avatar_url":"https://avatars.githubusercontent.com/u/67034?","gravatar_id":"7b5ca106c142285cc5cda879ed474bef","url":"https://api.github.com/users/vaskas","html_url":"https://github.com/vaskas","followers_url":"https://api.github.com/users/vaskas/followers","following_url":"https://api.github.com/users/vaskas/following{/other_user}","gists_url":"https://api.github.com/users/vaskas/gists{/gist_id}","starred_url":"https://api.github.com/users/vaskas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vaskas/subscriptions","organizations_url":"https://api.github.com/users/vaskas/orgs","repos_url":"https://api.github.com/users/vaskas/repos","events_url":"https://api.github.com/users/vaskas/events{/privacy}","received_events_url":"https://api.github.com/users/vaskas/received_events","type":"User","site_admin":false},"comments":7,"review_comments":0,"commits":4,"additions":16,"deletions":2,"changed_files":1}}