GitHub PullRequestReviewCommentEvent at 2014-01-10 23:18:10
Repository: cc65
Actor: groessler
Payload: {"comment":{"url":"https://api.github.com/repos/oliverschmidt/cc65/pulls/comments/8806068","id":8806068,"diff_hunk":"@@ -0,0 +1,22 @@\n+;\n+; Address of the static standard mouse driver\n+;\n+; Christian Groessler, 2014-01-02\n+;\n+; const void mouse_static_stddrv[];\n+;\n+\n+        .export _mouse_static_stddrv\n+        .ifdef  __ATARIXL__\n+        .import _atrxjoy_mou\n+        .else\n+        .import _atrjoy_mou\n+        .endif\n+\n+.rodata\n+\n+        .ifdef  __ATARIXL__\n+_mouse_static_stddrv := _atrxjoy_mou","path":"libsrc/atari/mouse_stat_stddrv.s","position":19,"original_position":19,"commit_id":"a86133bb5720380c75e6a1e11625ac83908fc028","original_commit_id":"a86133bb5720380c75e6a1e11625ac83908fc028","user":{"login":"groessler","id":4138182,"avatar_url":"https://gravatar.com/avatar/8f86af292d33fd92ffdbfb8d21c60214?d=https%3A%2F%2Fidenticons.github.com%2F89e2dc97bccceba095c0130ffa98ca46.png&r=x","gravatar_id":"8f86af292d33fd92ffdbfb8d21c60214","url":"https://api.github.com/users/groessler","html_url":"https://github.com/groessler","followers_url":"https://api.github.com/users/groessler/followers","following_url":"https://api.github.com/users/groessler/following{/other_user}","gists_url":"https://api.github.com/users/groessler/gists{/gist_id}","starred_url":"https://api.github.com/users/groessler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/groessler/subscriptions","organizations_url":"https://api.github.com/users/groessler/orgs","repos_url":"https://api.github.com/users/groessler/repos","events_url":"https://api.github.com/users/groessler/events{/privacy}","received_events_url":"https://api.github.com/users/groessler/received_events","type":"User","site_admin":false},"body":"On 01/10/14 23:24, Oliver Schmidt wrote:\n>\n> In libsrc/atari/mouse_stat_stddrv.s:\n>\n> > +; Christian Groessler, 2014-01-02\n> > +;\n> > +; const void mouse_static_stddrv[];\n> > +;\n> > +\n> > +        .export _mouse_static_stddrv\n> > +        .ifdef  __ATARIXL__\n> > +        .import _atrxjoy_mou\n> > +        .else\n> > +        .import _atrjoy_mou\n> > +        .endif\n> > +\n> > +.rodata\n> > +\n> > +        .ifdef  __ATARIXL__\n> > +_mouse_static_stddrv := _atrxjoy_mou\n>\n> When I get things right then you defined the Amiga mouse as standard \n> mouse for dynamic drivers. So it doesn't seem to make sense to me to \n> define the \"Joystick mouse\" as standard mouse for static drivers.\n>\n\nYes, stupid, isn't it :-)\n\n\"joystick mouse\" was my first driver to implement, and I had adapted \neverything for it.\nThen, when changing the default driver I forgot about the static driver.\n\nBut:\n\nHow do I compile a program to use the static driver? I've looked at the \ndocumentation\nand didn't find a hint. Maybe I haven't looked hard enough?","created_at":"2014-01-10T23:18:10Z","updated_at":"2014-01-10T23:18:10Z","html_url":"https://github.com/oliverschmidt/cc65/pull/69#discussion_r8806068","pull_request_url":"https://api.github.com/repos/oliverschmidt/cc65/pulls/69","_links":{"self":{"href":"https://api.github.com/repos/oliverschmidt/cc65/pulls/comments/8806068"},"html":{"href":"https://github.com/oliverschmidt/cc65/pull/69#discussion_r8806068"},"pull_request":{"href":"https://api.github.com/repos/oliverschmidt/cc65/pulls/69"}}}}