GitHub PullRequestReviewCommentEvent at 2014-07-31 20:51:09
Repository: gulp-recess
Actor: sindresorhus
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/sindresorhus/gulp-recess/pulls/comments/15668903","id":15668903,"diff_hunk":"@@ -25,6 +28,7 @@ module.exports = function (options) {\n \t\t\treturn cb();\n \t\t}\n \n+\t\toptions = rcLoader.for(file.path, options);","path":"index.js","position":21,"original_position":21,"commit_id":"574b58c0391f12d75df2543b147e75e0a10e6b48","original_commit_id":"574b58c0391f12d75df2543b147e75e0a10e6b48","user":{"login":"sindresorhus","id":170270,"avatar_url":"https://avatars.githubusercontent.com/u/170270?v=1","gravatar_id":"d36a92237c75c5337c17b60d90686bf9","url":"https://api.github.com/users/sindresorhus","html_url":"https://github.com/sindresorhus","followers_url":"https://api.github.com/users/sindresorhus/followers","following_url":"https://api.github.com/users/sindresorhus/following{/other_user}","gists_url":"https://api.github.com/users/sindresorhus/gists{/gist_id}","starred_url":"https://api.github.com/users/sindresorhus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sindresorhus/subscriptions","organizations_url":"https://api.github.com/users/sindresorhus/orgs","repos_url":"https://api.github.com/users/sindresorhus/repos","events_url":"https://api.github.com/users/sindresorhus/events{/privacy}","received_events_url":"https://api.github.com/users/sindresorhus/received_events","type":"User","site_admin":false},"body":"I'm not contending the options merging. That can actually be useful. Rather, you're passing in options in both the constructor and the `for` method, which seems a bit weird.","created_at":"2014-07-31T20:51:09Z","updated_at":"2014-07-31T20:51:09Z","html_url":"https://github.com/sindresorhus/gulp-recess/pull/8#discussion_r15668903","pull_request_url":"https://api.github.com/repos/sindresorhus/gulp-recess/pulls/8","_links":{"self":{"href":"https://api.github.com/repos/sindresorhus/gulp-recess/pulls/comments/15668903"},"html":{"href":"https://github.com/sindresorhus/gulp-recess/pull/8#discussion_r15668903"},"pull_request":{"href":"https://api.github.com/repos/sindresorhus/gulp-recess/pulls/8"}}},"pull_request":{"url":"https://api.github.com/repos/sindresorhus/gulp-recess/pulls/8","id":18577349,"html_url":"https://github.com/sindresorhus/gulp-recess/pull/8","diff_url":"https://github.com/sindresorhus/gulp-recess/pull/8.diff","patch_url":"https://github.com/sindresorhus/gulp-recess/pull/8.patch","issue_url":"https://api.github.com/repos/sindresorhus/gulp-recess/issues/8","number":8,"state":"open","title":"Support for .recessrc file","user":{"login":"TomSeldonBoxUK","id":4609343,"avatar_url":"https://avatars.githubusercontent.com/u/4609343?v=1","gravatar_id":"f0559be7d02835782e42b41294d520f0","url":"https://api.github.com/users/TomSeldonBoxUK","html_url":"https://github.com/TomSeldonBoxUK","followers_url":"https://api.github.com/users/TomSeldonBoxUK/followers","following_url":"https://api.github.com/users/TomSeldonBoxUK/following{/other_user}","gists_url":"https://api.github.com/users/TomSeldonBoxUK/gists{/gist_id}","starred_url":"https://api.github.com/users/TomSeldonBoxUK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomSeldonBoxUK/subscriptions","organizations_url":"https://api.github.com/users/TomSeldonBoxUK/orgs","repos_url":"https://api.github.com/users/TomSeldonBoxUK/repos","events_url":"https://api.github.com/users/TomSeldonBoxUK/events{/privacy}","received_events_url":"https://api.github.com/users/TomSeldonBoxUK/received_events","type":"User","site_admin":false},"body":"This PR adds support for reading options from a `.recessrc` file, as you would expect from similar plugins such as `gulp-jshint`, etc.\r\n\r\nAlso happy to do the equivalent for the `grunt-recess` plugin if you're happy with the implementation here.","created_at":"2014-07-18T10:06:47Z","updated_at":"2014-07-31T20:51:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a755fe4349498647fea6af2337b97adabc45f6ff","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sindresorhus/gulp-recess/pulls/8/commits","review_comments_url":"https://api.github.com/repos/sindresorhus/gulp-recess/pulls/8/comments","review_comment_url":"https://api.github.com/repos/sindresorhus/gulp-recess/pulls/comments/{number}","comments_url":"https://api.github.com/repos/sindresorhus/gulp-recess/issues/8/comments","statuses_url":"https://api.github.com/repos/sindresorhus/gulp-recess/statuses/574b58c0391f12d75df2543b147e75e0a10e6b48","head":{"label":"TomSeldonBoxUK:recessrc","ref":"recessrc","sha":"574b58c0391f12d75df2543b147e75e0a10e6b48","user":{"login":"TomSeldonBoxUK","id":4609343,"avatar_url":"https://avatars.githubusercontent.com/u/4609343?v=1","gravatar_id":"f0559be7d02835782e42b41294d520f0","url":"https://api.github.com/users/TomSeldonBoxUK","html_url":"https://github.com/TomSeldonBoxUK","followers_url":"https://api.github.com/users/TomSeldonBoxUK/followers","following_url":"https://api.github.com/users/TomSeldonBoxUK/following{/other_user}","gists_url":"https://api.github.com/users/TomSeldonBoxUK/gists{/gist_id}","starred_url":"https://api.github.com/users/TomSeldonBoxUK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomSeldonBoxUK/subscriptions","organizations_url":"https://api.github.com/users/TomSeldonBoxUK/orgs","repos_url":"https://api.github.com/users/TomSeldonBoxUK/repos","events_url":"https://api.github.com/users/TomSeldonBoxUK/events{/privacy}","received_events_url":"https://api.github.com/users/TomSeldonBoxUK/received_events","type":"User","site_admin":false},"repo":{"id":21950073,"name":"gulp-recess","full_name":"TomSeldonBoxUK/gulp-recess","owner":{"login":"TomSeldonBoxUK","id":4609343,"avatar_url":"https://avatars.githubusercontent.com/u/4609343?v=1","gravatar_id":"f0559be7d02835782e42b41294d520f0","url":"https://api.github.com/users/TomSeldonBoxUK","html_url":"https://github.com/TomSeldonBoxUK","followers_url":"https://api.github.com/users/TomSeldonBoxUK/followers","following_url":"https://api.github.com/users/TomSeldonBoxUK/following{/other_user}","gists_url":"https://api.github.com/users/TomSeldonBoxUK/gists{/gist_id}","starred_url":"https://api.github.com/users/TomSeldonBoxUK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomSeldonBoxUK/subscriptions","organizations_url":"https://api.github.com/users/TomSeldonBoxUK/orgs","repos_url":"https://api.github.com/users/TomSeldonBoxUK/repos","events_url":"https://api.github.com/users/TomSeldonBoxUK/events{/privacy}","received_events_url":"https://api.github.com/users/TomSeldonBoxUK/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TomSeldonBoxUK/gulp-recess","description":"Lint CSS and LESS with RECESS","fork":true,"url":"https://api.github.com/repos/TomSeldonBoxUK/gulp-recess","forks_url":"https://api.github.com/repos/TomSeldonBoxUK/gulp-recess/forks","keys_url":"https://api.github.com/repos/TomSeldonBoxUK/gulp-recess/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TomSeldonBoxUK/gulp-recess/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TomSeldonBoxUK/gulp-recess/teams","hooks_url":"https://api.github.com/repos/TomSeldonBoxUK/gulp-recess/hooks","issue_events_url":"https://api.github.com/repos/TomSeldonBoxUK/gulp-recess/issues/events{/number}","events_url":"https://api.github.com/repos/TomSeldonBoxUK/gulp-recess/events","assignees_url":"https://api.github.com/repos/TomSeldonBoxUK/gulp-recess/assignees{/user}","branches_url":"https://api.github.com/repos/TomSeldonBoxUK/gulp-recess/branches{/branch}","tags_url":"https://api.github.com/repos/TomSeldonBoxUK/gulp-recess/tags","blobs_url":"https://api.github.com/repos/TomSeldonBoxUK/gulp-recess/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TomSeldonBoxUK/gulp-recess/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TomSeldonBoxUK/gulp-recess/git/refs{/sha}","trees_url":"https://api.github.com/repos/TomSeldonBoxUK/gulp-recess/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TomSeldonBoxUK/gulp-recess/statuses/{sha}","languages_url":"https://api.github.com/repos/TomSeldonBoxUK/gulp-recess/languages","stargazers_url":"https://api.github.com/repos/TomSeldonBoxUK/gulp-recess/stargazers","contributors_url":"https://api.github.com/repos/TomSeldonBoxUK/gulp-recess/contributors","subscribers_url":"https://api.github.com/repos/TomSeldonBoxUK/gulp-recess/subscribers","subscription_url":"https://api.github.com/repos/TomSeldonBoxUK/gulp-recess/subscription","commits_url":"https://api.github.com/repos/TomSeldonBoxUK/gulp-recess/commits{/sha}","git_commits_url":"https://api.github.com/repos/TomSeldonBoxUK/gulp-recess/git/commits{/sha}","comments_url":"https://api.github.com/repos/TomSeldonBoxUK/gulp-recess/comments{/number}","issue_comment_url":"https://api.github.com/repos/TomSeldonBoxUK/gulp-recess/issues/comments/{number}","contents_url":"https://api.github.com/repos/TomSeldonBoxUK/gulp-recess/contents/{+path}","compare_url":"https://api.github.com/repos/TomSeldonBoxUK/gulp-recess/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TomSeldonBoxUK/gulp-recess/merges","archive_url":"https://api.github.com/repos/TomSeldonBoxUK/gulp-recess/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TomSeldonBoxUK/gulp-recess/downloads","issues_url":"https://api.github.com/repos/TomSeldonBoxUK/gulp-recess/issues{/number}","pulls_url":"https://api.github.com/repos/TomSeldonBoxUK/gulp-recess/pulls{/number}","milestones_url":"https://api.github.com/repos/TomSeldonBoxUK/gulp-recess/milestones{/number}","notifications_url":"https://api.github.com/repos/TomSeldonBoxUK/gulp-recess/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TomSeldonBoxUK/gulp-recess/labels{/name}","releases_url":"https://api.github.com/repos/TomSeldonBoxUK/gulp-recess/releases{/id}","created_at":"2014-07-17T16:55:45Z","updated_at":"2014-06-29T00:13:21Z","pushed_at":"2014-07-18T10:04:45Z","git_url":"git://github.com/TomSeldonBoxUK/gulp-recess.git","ssh_url":"git@github.com:TomSeldonBoxUK/gulp-recess.git","clone_url":"https://github.com/TomSeldonBoxUK/gulp-recess.git","svn_url":"https://github.com/TomSeldonBoxUK/gulp-recess","homepage":null,"size":134,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sindresorhus:master","ref":"master","sha":"13f1b54a7cdc77812af8086dd1bccf20729071ad","user":{"login":"sindresorhus","id":170270,"avatar_url":"https://avatars.githubusercontent.com/u/170270?v=1","gravatar_id":"d36a92237c75c5337c17b60d90686bf9","url":"https://api.github.com/users/sindresorhus","html_url":"https://github.com/sindresorhus","followers_url":"https://api.github.com/users/sindresorhus/followers","following_url":"https://api.github.com/users/sindresorhus/following{/other_user}","gists_url":"https://api.github.com/users/sindresorhus/gists{/gist_id}","starred_url":"https://api.github.com/users/sindresorhus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sindresorhus/subscriptions","organizations_url":"https://api.github.com/users/sindresorhus/orgs","repos_url":"https://api.github.com/users/sindresorhus/repos","events_url":"https://api.github.com/users/sindresorhus/events{/privacy}","received_events_url":"https://api.github.com/users/sindresorhus/received_events","type":"User","site_admin":false},"repo":{"id":15455505,"name":"gulp-recess","full_name":"sindresorhus/gulp-recess","owner":{"login":"sindresorhus","id":170270,"avatar_url":"https://avatars.githubusercontent.com/u/170270?v=1","gravatar_id":"d36a92237c75c5337c17b60d90686bf9","url":"https://api.github.com/users/sindresorhus","html_url":"https://github.com/sindresorhus","followers_url":"https://api.github.com/users/sindresorhus/followers","following_url":"https://api.github.com/users/sindresorhus/following{/other_user}","gists_url":"https://api.github.com/users/sindresorhus/gists{/gist_id}","starred_url":"https://api.github.com/users/sindresorhus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sindresorhus/subscriptions","organizations_url":"https://api.github.com/users/sindresorhus/orgs","repos_url":"https://api.github.com/users/sindresorhus/repos","events_url":"https://api.github.com/users/sindresorhus/events{/privacy}","received_events_url":"https://api.github.com/users/sindresorhus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sindresorhus/gulp-recess","description":"Lint CSS and LESS with RECESS","fork":false,"url":"https://api.github.com/repos/sindresorhus/gulp-recess","forks_url":"https://api.github.com/repos/sindresorhus/gulp-recess/forks","keys_url":"https://api.github.com/repos/sindresorhus/gulp-recess/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sindresorhus/gulp-recess/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sindresorhus/gulp-recess/teams","hooks_url":"https://api.github.com/repos/sindresorhus/gulp-recess/hooks","issue_events_url":"https://api.github.com/repos/sindresorhus/gulp-recess/issues/events{/number}","events_url":"https://api.github.com/repos/sindresorhus/gulp-recess/events","assignees_url":"https://api.github.com/repos/sindresorhus/gulp-recess/assignees{/user}","branches_url":"https://api.github.com/repos/sindresorhus/gulp-recess/branches{/branch}","tags_url":"https://api.github.com/repos/sindresorhus/gulp-recess/tags","blobs_url":"https://api.github.com/repos/sindresorhus/gulp-recess/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sindresorhus/gulp-recess/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sindresorhus/gulp-recess/git/refs{/sha}","trees_url":"https://api.github.com/repos/sindresorhus/gulp-recess/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sindresorhus/gulp-recess/statuses/{sha}","languages_url":"https://api.github.com/repos/sindresorhus/gulp-recess/languages","stargazers_url":"https://api.github.com/repos/sindresorhus/gulp-recess/stargazers","contributors_url":"https://api.github.com/repos/sindresorhus/gulp-recess/contributors","subscribers_url":"https://api.github.com/repos/sindresorhus/gulp-recess/subscribers","subscription_url":"https://api.github.com/repos/sindresorhus/gulp-recess/subscription","commits_url":"https://api.github.com/repos/sindresorhus/gulp-recess/commits{/sha}","git_commits_url":"https://api.github.com/repos/sindresorhus/gulp-recess/git/commits{/sha}","comments_url":"https://api.github.com/repos/sindresorhus/gulp-recess/comments{/number}","issue_comment_url":"https://api.github.com/repos/sindresorhus/gulp-recess/issues/comments/{number}","contents_url":"https://api.github.com/repos/sindresorhus/gulp-recess/contents/{+path}","compare_url":"https://api.github.com/repos/sindresorhus/gulp-recess/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sindresorhus/gulp-recess/merges","archive_url":"https://api.github.com/repos/sindresorhus/gulp-recess/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sindresorhus/gulp-recess/downloads","issues_url":"https://api.github.com/repos/sindresorhus/gulp-recess/issues{/number}","pulls_url":"https://api.github.com/repos/sindresorhus/gulp-recess/pulls{/number}","milestones_url":"https://api.github.com/repos/sindresorhus/gulp-recess/milestones{/number}","notifications_url":"https://api.github.com/repos/sindresorhus/gulp-recess/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sindresorhus/gulp-recess/labels{/name}","releases_url":"https://api.github.com/repos/sindresorhus/gulp-recess/releases{/id}","created_at":"2013-12-26T15:48:11Z","updated_at":"2014-07-23T14:05:32Z","pushed_at":"2014-07-25T23:49:01Z","git_url":"git://github.com/sindresorhus/gulp-recess.git","ssh_url":"git@github.com:sindresorhus/gulp-recess.git","clone_url":"https://github.com/sindresorhus/gulp-recess.git","svn_url":"https://github.com/sindresorhus/gulp-recess","homepage":null,"size":347,"stargazers_count":20,"watchers_count":20,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":6,"mirror_url":null,"open_issues_count":1,"forks":6,"open_issues":1,"watchers":20,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sindresorhus/gulp-recess/pulls/8"},"html":{"href":"https://github.com/sindresorhus/gulp-recess/pull/8"},"issue":{"href":"https://api.github.com/repos/sindresorhus/gulp-recess/issues/8"},"comments":{"href":"https://api.github.com/repos/sindresorhus/gulp-recess/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/sindresorhus/gulp-recess/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/sindresorhus/gulp-recess/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/sindresorhus/gulp-recess/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/sindresorhus/gulp-recess/statuses/574b58c0391f12d75df2543b147e75e0a10e6b48"}}}}