GitHub PullRequestReviewCommentEvent at 2014-08-19 01:48:26
Repository: the-blue-alliance
Actor: phil-lopreiato
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/the-blue-alliance/the-blue-alliance/pulls/comments/16393261","id":16393261,"diff_hunk":"@@ -81,4 +82,8 @@ def updateMerge(self, new_match, old_match, auto_union=True):\n                 setattr(old_match, attr, list(unioned))\n                 old_match.dirty = True\n \n+        if old_match.dirty:\n+            # Only send updates if a match property changed\n+            GCMMessageHelper.send_match_score_update(old_match)","path":"helpers/match_manipulator.py","position":14,"original_position":14,"commit_id":"9e508664a18aaf7218eae2595169c0f6a0d73d48","original_commit_id":"9e508664a18aaf7218eae2595169c0f6a0d73d48","user":{"login":"phil-lopreiato","id":2754863,"avatar_url":"https://avatars.githubusercontent.com/u/2754863?v=2","gravatar_id":"d52404a862da0beeade8ca565cd7fd0d","url":"https://api.github.com/users/phil-lopreiato","html_url":"https://github.com/phil-lopreiato","followers_url":"https://api.github.com/users/phil-lopreiato/followers","following_url":"https://api.github.com/users/phil-lopreiato/following{/other_user}","gists_url":"https://api.github.com/users/phil-lopreiato/gists{/gist_id}","starred_url":"https://api.github.com/users/phil-lopreiato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phil-lopreiato/subscriptions","organizations_url":"https://api.github.com/users/phil-lopreiato/orgs","repos_url":"https://api.github.com/users/phil-lopreiato/repos","events_url":"https://api.github.com/users/phil-lopreiato/events{/privacy}","received_events_url":"https://api.github.com/users/phil-lopreiato/received_events","type":"User","site_admin":false},"body":"Yeah, we went over it. I'll move it over to a task queue tomorrow. ","created_at":"2014-08-19T01:48:26Z","updated_at":"2014-08-19T01:48:26Z","html_url":"https://github.com/the-blue-alliance/the-blue-alliance/pull/1072#discussion_r16393261","pull_request_url":"https://api.github.com/repos/the-blue-alliance/the-blue-alliance/pulls/1072","_links":{"self":{"href":"https://api.github.com/repos/the-blue-alliance/the-blue-alliance/pulls/comments/16393261"},"html":{"href":"https://github.com/the-blue-alliance/the-blue-alliance/pull/1072#discussion_r16393261"},"pull_request":{"href":"https://api.github.com/repos/the-blue-alliance/the-blue-alliance/pulls/1072"}}},"pull_request":{"url":"https://api.github.com/repos/the-blue-alliance/the-blue-alliance/pulls/1072","id":19819782,"html_url":"https://github.com/the-blue-alliance/the-blue-alliance/pull/1072","diff_url":"https://github.com/the-blue-alliance/the-blue-alliance/pull/1072.diff","patch_url":"https://github.com/the-blue-alliance/the-blue-alliance/pull/1072.patch","issue_url":"https://api.github.com/repos/the-blue-alliance/the-blue-alliance/issues/1072","number":1072,"state":"open","locked":false,"title":"Android Push Notifications","user":{"login":"phil-lopreiato","id":2754863,"avatar_url":"https://avatars.githubusercontent.com/u/2754863?v=2","gravatar_id":"d52404a862da0beeade8ca565cd7fd0d","url":"https://api.github.com/users/phil-lopreiato","html_url":"https://github.com/phil-lopreiato","followers_url":"https://api.github.com/users/phil-lopreiato/followers","following_url":"https://api.github.com/users/phil-lopreiato/following{/other_user}","gists_url":"https://api.github.com/users/phil-lopreiato/gists{/gist_id}","starred_url":"https://api.github.com/users/phil-lopreiato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phil-lopreiato/subscriptions","organizations_url":"https://api.github.com/users/phil-lopreiato/orgs","repos_url":"https://api.github.com/users/phil-lopreiato/repos","events_url":"https://api.github.com/users/phil-lopreiato/events{/privacy}","received_events_url":"https://api.github.com/users/phil-lopreiato/received_events","type":"User","site_admin":false},"body":"Support for sending push notifications (for now, only Android) to registered mobile users. Notifications are sent to users who have 'subscribed' to a model relevant to the data being sent. This PR depends on #1071, pairs with https://github.com/the-blue-alliance/the-blue-alliance-android/pull/237, and is a work in progress...","created_at":"2014-08-14T22:32:16Z","updated_at":"2014-08-19T01:48:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fff86a56290d131ca7c226f1d6c2b8d6f11b7679","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/the-blue-alliance/the-blue-alliance/pulls/1072/commits","review_comments_url":"https://api.github.com/repos/the-blue-alliance/the-blue-alliance/pulls/1072/comments","review_comment_url":"https://api.github.com/repos/the-blue-alliance/the-blue-alliance/pulls/comments/{number}","comments_url":"https://api.github.com/repos/the-blue-alliance/the-blue-alliance/issues/1072/comments","statuses_url":"https://api.github.com/repos/the-blue-alliance/the-blue-alliance/statuses/9e508664a18aaf7218eae2595169c0f6a0d73d48","head":{"label":"phil-lopreiato:push-notifications","ref":"push-notifications","sha":"9e508664a18aaf7218eae2595169c0f6a0d73d48","user":{"login":"phil-lopreiato","id":2754863,"avatar_url":"https://avatars.githubusercontent.com/u/2754863?v=2","gravatar_id":"d52404a862da0beeade8ca565cd7fd0d","url":"https://api.github.com/users/phil-lopreiato","html_url":"https://github.com/phil-lopreiato","followers_url":"https://api.github.com/users/phil-lopreiato/followers","following_url":"https://api.github.com/users/phil-lopreiato/following{/other_user}","gists_url":"https://api.github.com/users/phil-lopreiato/gists{/gist_id}","starred_url":"https://api.github.com/users/phil-lopreiato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phil-lopreiato/subscriptions","organizations_url":"https://api.github.com/users/phil-lopreiato/orgs","repos_url":"https://api.github.com/users/phil-lopreiato/repos","events_url":"https://api.github.com/users/phil-lopreiato/events{/privacy}","received_events_url":"https://api.github.com/users/phil-lopreiato/received_events","type":"User","site_admin":false},"repo":{"id":18301544,"name":"the-blue-alliance","full_name":"phil-lopreiato/the-blue-alliance","owner":{"login":"phil-lopreiato","id":2754863,"avatar_url":"https://avatars.githubusercontent.com/u/2754863?v=2","gravatar_id":"d52404a862da0beeade8ca565cd7fd0d","url":"https://api.github.com/users/phil-lopreiato","html_url":"https://github.com/phil-lopreiato","followers_url":"https://api.github.com/users/phil-lopreiato/followers","following_url":"https://api.github.com/users/phil-lopreiato/following{/other_user}","gists_url":"https://api.github.com/users/phil-lopreiato/gists{/gist_id}","starred_url":"https://api.github.com/users/phil-lopreiato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phil-lopreiato/subscriptions","organizations_url":"https://api.github.com/users/phil-lopreiato/orgs","repos_url":"https://api.github.com/users/phil-lopreiato/repos","events_url":"https://api.github.com/users/phil-lopreiato/events{/privacy}","received_events_url":"https://api.github.com/users/phil-lopreiato/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/phil-lopreiato/the-blue-alliance","description":"FIRST Robotics match video archive website","fork":true,"url":"https://api.github.com/repos/phil-lopreiato/the-blue-alliance","forks_url":"https://api.github.com/repos/phil-lopreiato/the-blue-alliance/forks","keys_url":"https://api.github.com/repos/phil-lopreiato/the-blue-alliance/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phil-lopreiato/the-blue-alliance/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phil-lopreiato/the-blue-alliance/teams","hooks_url":"https://api.github.com/repos/phil-lopreiato/the-blue-alliance/hooks","issue_events_url":"https://api.github.com/repos/phil-lopreiato/the-blue-alliance/issues/events{/number}","events_url":"https://api.github.com/repos/phil-lopreiato/the-blue-alliance/events","assignees_url":"https://api.github.com/repos/phil-lopreiato/the-blue-alliance/assignees{/user}","branches_url":"https://api.github.com/repos/phil-lopreiato/the-blue-alliance/branches{/branch}","tags_url":"https://api.github.com/repos/phil-lopreiato/the-blue-alliance/tags","blobs_url":"https://api.github.com/repos/phil-lopreiato/the-blue-alliance/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phil-lopreiato/the-blue-alliance/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phil-lopreiato/the-blue-alliance/git/refs{/sha}","trees_url":"https://api.github.com/repos/phil-lopreiato/the-blue-alliance/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phil-lopreiato/the-blue-alliance/statuses/{sha}","languages_url":"https://api.github.com/repos/phil-lopreiato/the-blue-alliance/languages","stargazers_url":"https://api.github.com/repos/phil-lopreiato/the-blue-alliance/stargazers","contributors_url":"https://api.github.com/repos/phil-lopreiato/the-blue-alliance/contributors","subscribers_url":"https://api.github.com/repos/phil-lopreiato/the-blue-alliance/subscribers","subscription_url":"https://api.github.com/repos/phil-lopreiato/the-blue-alliance/subscription","commits_url":"https://api.github.com/repos/phil-lopreiato/the-blue-alliance/commits{/sha}","git_commits_url":"https://api.github.com/repos/phil-lopreiato/the-blue-alliance/git/commits{/sha}","comments_url":"https://api.github.com/repos/phil-lopreiato/the-blue-alliance/comments{/number}","issue_comment_url":"https://api.github.com/repos/phil-lopreiato/the-blue-alliance/issues/comments/{number}","contents_url":"https://api.github.com/repos/phil-lopreiato/the-blue-alliance/contents/{+path}","compare_url":"https://api.github.com/repos/phil-lopreiato/the-blue-alliance/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phil-lopreiato/the-blue-alliance/merges","archive_url":"https://api.github.com/repos/phil-lopreiato/the-blue-alliance/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phil-lopreiato/the-blue-alliance/downloads","issues_url":"https://api.github.com/repos/phil-lopreiato/the-blue-alliance/issues{/number}","pulls_url":"https://api.github.com/repos/phil-lopreiato/the-blue-alliance/pulls{/number}","milestones_url":"https://api.github.com/repos/phil-lopreiato/the-blue-alliance/milestones{/number}","notifications_url":"https://api.github.com/repos/phil-lopreiato/the-blue-alliance/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phil-lopreiato/the-blue-alliance/labels{/name}","releases_url":"https://api.github.com/repos/phil-lopreiato/the-blue-alliance/releases{/id}","created_at":"2014-03-31T17:22:46Z","updated_at":"2014-07-14T15:46:44Z","pushed_at":"2014-08-18T04:10:27Z","git_url":"git://github.com/phil-lopreiato/the-blue-alliance.git","ssh_url":"git@github.com:phil-lopreiato/the-blue-alliance.git","clone_url":"https://github.com/phil-lopreiato/the-blue-alliance.git","svn_url":"https://github.com/phil-lopreiato/the-blue-alliance","homepage":"thebluealliance.com","size":13930,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"the-blue-alliance:master","ref":"master","sha":"d7a0db19a3a836f6b0874ea87025b7261b81e681","user":{"login":"the-blue-alliance","id":7354965,"avatar_url":"https://avatars.githubusercontent.com/u/7354965?v=2","gravatar_id":null,"url":"https://api.github.com/users/the-blue-alliance","html_url":"https://github.com/the-blue-alliance","followers_url":"https://api.github.com/users/the-blue-alliance/followers","following_url":"https://api.github.com/users/the-blue-alliance/following{/other_user}","gists_url":"https://api.github.com/users/the-blue-alliance/gists{/gist_id}","starred_url":"https://api.github.com/users/the-blue-alliance/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/the-blue-alliance/subscriptions","organizations_url":"https://api.github.com/users/the-blue-alliance/orgs","repos_url":"https://api.github.com/users/the-blue-alliance/repos","events_url":"https://api.github.com/users/the-blue-alliance/events{/privacy}","received_events_url":"https://api.github.com/users/the-blue-alliance/received_events","type":"Organization","site_admin":false},"repo":{"id":888427,"name":"the-blue-alliance","full_name":"the-blue-alliance/the-blue-alliance","owner":{"login":"the-blue-alliance","id":7354965,"avatar_url":"https://avatars.githubusercontent.com/u/7354965?v=2","gravatar_id":null,"url":"https://api.github.com/users/the-blue-alliance","html_url":"https://github.com/the-blue-alliance","followers_url":"https://api.github.com/users/the-blue-alliance/followers","following_url":"https://api.github.com/users/the-blue-alliance/following{/other_user}","gists_url":"https://api.github.com/users/the-blue-alliance/gists{/gist_id}","starred_url":"https://api.github.com/users/the-blue-alliance/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/the-blue-alliance/subscriptions","organizations_url":"https://api.github.com/users/the-blue-alliance/orgs","repos_url":"https://api.github.com/users/the-blue-alliance/repos","events_url":"https://api.github.com/users/the-blue-alliance/events{/privacy}","received_events_url":"https://api.github.com/users/the-blue-alliance/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/the-blue-alliance/the-blue-alliance","description":"A webapp for accessing information about the FIRST Robotics Competition.","fork":false,"url":"https://api.github.com/repos/the-blue-alliance/the-blue-alliance","forks_url":"https://api.github.com/repos/the-blue-alliance/the-blue-alliance/forks","keys_url":"https://api.github.com/repos/the-blue-alliance/the-blue-alliance/keys{/key_id}","collaborators_url":"https://api.github.com/repos/the-blue-alliance/the-blue-alliance/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/the-blue-alliance/the-blue-alliance/teams","hooks_url":"https://api.github.com/repos/the-blue-alliance/the-blue-alliance/hooks","issue_events_url":"https://api.github.com/repos/the-blue-alliance/the-blue-alliance/issues/events{/number}","events_url":"https://api.github.com/repos/the-blue-alliance/the-blue-alliance/events","assignees_url":"https://api.github.com/repos/the-blue-alliance/the-blue-alliance/assignees{/user}","branches_url":"https://api.github.com/repos/the-blue-alliance/the-blue-alliance/branches{/branch}","tags_url":"https://api.github.com/repos/the-blue-alliance/the-blue-alliance/tags","blobs_url":"https://api.github.com/repos/the-blue-alliance/the-blue-alliance/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/the-blue-alliance/the-blue-alliance/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/the-blue-alliance/the-blue-alliance/git/refs{/sha}","trees_url":"https://api.github.com/repos/the-blue-alliance/the-blue-alliance/git/trees{/sha}","statuses_url":"https://api.github.com/repos/the-blue-alliance/the-blue-alliance/statuses/{sha}","languages_url":"https://api.github.com/repos/the-blue-alliance/the-blue-alliance/languages","stargazers_url":"https://api.github.com/repos/the-blue-alliance/the-blue-alliance/stargazers","contributors_url":"https://api.github.com/repos/the-blue-alliance/the-blue-alliance/contributors","subscribers_url":"https://api.github.com/repos/the-blue-alliance/the-blue-alliance/subscribers","subscription_url":"https://api.github.com/repos/the-blue-alliance/the-blue-alliance/subscription","commits_url":"https://api.github.com/repos/the-blue-alliance/the-blue-alliance/commits{/sha}","git_commits_url":"https://api.github.com/repos/the-blue-alliance/the-blue-alliance/git/commits{/sha}","comments_url":"https://api.github.com/repos/the-blue-alliance/the-blue-alliance/comments{/number}","issue_comment_url":"https://api.github.com/repos/the-blue-alliance/the-blue-alliance/issues/comments/{number}","contents_url":"https://api.github.com/repos/the-blue-alliance/the-blue-alliance/contents/{+path}","compare_url":"https://api.github.com/repos/the-blue-alliance/the-blue-alliance/compare/{base}...{head}","merges_url":"https://api.github.com/repos/the-blue-alliance/the-blue-alliance/merges","archive_url":"https://api.github.com/repos/the-blue-alliance/the-blue-alliance/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/the-blue-alliance/the-blue-alliance/downloads","issues_url":"https://api.github.com/repos/the-blue-alliance/the-blue-alliance/issues{/number}","pulls_url":"https://api.github.com/repos/the-blue-alliance/the-blue-alliance/pulls{/number}","milestones_url":"https://api.github.com/repos/the-blue-alliance/the-blue-alliance/milestones{/number}","notifications_url":"https://api.github.com/repos/the-blue-alliance/the-blue-alliance/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/the-blue-alliance/the-blue-alliance/labels{/name}","releases_url":"https://api.github.com/repos/the-blue-alliance/the-blue-alliance/releases{/id}","created_at":"2010-09-04T20:34:11Z","updated_at":"2014-07-30T16:37:05Z","pushed_at":"2014-08-18T04:11:18Z","git_url":"git://github.com/the-blue-alliance/the-blue-alliance.git","ssh_url":"git@github.com:the-blue-alliance/the-blue-alliance.git","clone_url":"https://github.com/the-blue-alliance/the-blue-alliance.git","svn_url":"https://github.com/the-blue-alliance/the-blue-alliance","homepage":"thebluealliance.com","size":21547,"stargazers_count":80,"watchers_count":80,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":35,"mirror_url":null,"open_issues_count":118,"forks":35,"open_issues":118,"watchers":80,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/the-blue-alliance/the-blue-alliance/pulls/1072"},"html":{"href":"https://github.com/the-blue-alliance/the-blue-alliance/pull/1072"},"issue":{"href":"https://api.github.com/repos/the-blue-alliance/the-blue-alliance/issues/1072"},"comments":{"href":"https://api.github.com/repos/the-blue-alliance/the-blue-alliance/issues/1072/comments"},"review_comments":{"href":"https://api.github.com/repos/the-blue-alliance/the-blue-alliance/pulls/1072/comments"},"review_comment":{"href":"https://api.github.com/repos/the-blue-alliance/the-blue-alliance/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/the-blue-alliance/the-blue-alliance/pulls/1072/commits"},"statuses":{"href":"https://api.github.com/repos/the-blue-alliance/the-blue-alliance/statuses/9e508664a18aaf7218eae2595169c0f6a0d73d48"}}}}