GitHub PullRequestReviewCommentEvent at 2014-10-08 16:01:20
Repository: configuration
Actor: feanil
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/edx/configuration/pulls/comments/18592651","id":18592651,"diff_hunk":"@@ -4,14 +4,28 @@ cd configuration\n pip install -r requirements.txt\n env\n \n-ip=$(python playbooks/ec2.py | jq -r '.\"tag_Name_prod-edx-worker\"[0] | strings')\n-ssh=\"ssh -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no\"\n-manage=\"cd /edx/app/edxapp/edx-platform && sudo -u www-data /edx/bin/python.edxapp ./manage.py\"\n+if [[ \"$cluster\" = \"prod\" ]]; then","path":"util/jenkins/certificate-whitelist.sh","position":7,"original_position":7,"commit_id":"2ece95b7293aa261f0088a01fa90432ff1d3d283","original_commit_id":"2ece95b7293aa261f0088a01fa90432ff1d3d283","user":{"login":"feanil","id":781561,"avatar_url":"https://avatars.githubusercontent.com/u/781561?v=2","gravatar_id":"","url":"https://api.github.com/users/feanil","html_url":"https://github.com/feanil","followers_url":"https://api.github.com/users/feanil/followers","following_url":"https://api.github.com/users/feanil/following{/other_user}","gists_url":"https://api.github.com/users/feanil/gists{/gist_id}","starred_url":"https://api.github.com/users/feanil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feanil/subscriptions","organizations_url":"https://api.github.com/users/feanil/orgs","repos_url":"https://api.github.com/users/feanil/repos","events_url":"https://api.github.com/users/feanil/events{/privacy}","received_events_url":"https://api.github.com/users/feanil/received_events","type":"User","site_admin":false},"body":"This conditional can be simplified to just putting the cluster var in the string `first_in_tag_name_${environment}-${deployment}-worker`","created_at":"2014-10-08T16:01:20Z","updated_at":"2014-10-08T16:01:20Z","html_url":"https://github.com/edx/configuration/pull/1620#discussion_r18592651","pull_request_url":"https://api.github.com/repos/edx/configuration/pulls/1620","_links":{"self":{"href":"https://api.github.com/repos/edx/configuration/pulls/comments/18592651"},"html":{"href":"https://github.com/edx/configuration/pull/1620#discussion_r18592651"},"pull_request":{"href":"https://api.github.com/repos/edx/configuration/pulls/1620"}}},"pull_request":{"url":"https://api.github.com/repos/edx/configuration/pulls/1620","id":22430529,"html_url":"https://github.com/edx/configuration/pull/1620","diff_url":"https://github.com/edx/configuration/pull/1620.diff","patch_url":"https://github.com/edx/configuration/pull/1620.patch","issue_url":"https://api.github.com/repos/edx/configuration/issues/1620","number":1620,"state":"open","locked":false,"title":"Using ansible instead of ssh for jenkins scripts","user":{"login":"hkim823","id":1074229,"avatar_url":"https://avatars.githubusercontent.com/u/1074229?v=2","gravatar_id":"","url":"https://api.github.com/users/hkim823","html_url":"https://github.com/hkim823","followers_url":"https://api.github.com/users/hkim823/followers","following_url":"https://api.github.com/users/hkim823/following{/other_user}","gists_url":"https://api.github.com/users/hkim823/gists{/gist_id}","starred_url":"https://api.github.com/users/hkim823/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hkim823/subscriptions","organizations_url":"https://api.github.com/users/hkim823/orgs","repos_url":"https://api.github.com/users/hkim823/repos","events_url":"https://api.github.com/users/hkim823/events{/privacy}","received_events_url":"https://api.github.com/users/hkim823/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-10-08T15:15:42Z","updated_at":"2014-10-08T16:01:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fb59bd2d6c45abd6abfe85897a0fc6ffa66a0ed3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/edx/configuration/pulls/1620/commits","review_comments_url":"https://api.github.com/repos/edx/configuration/pulls/1620/comments","review_comment_url":"https://api.github.com/repos/edx/configuration/pulls/comments/{number}","comments_url":"https://api.github.com/repos/edx/configuration/issues/1620/comments","statuses_url":"https://api.github.com/repos/edx/configuration/statuses/2ece95b7293aa261f0088a01fa90432ff1d3d283","head":{"label":"edx:han/jenkins-certs","ref":"han/jenkins-certs","sha":"2ece95b7293aa261f0088a01fa90432ff1d3d283","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=2","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":9478219,"name":"configuration","full_name":"edx/configuration","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=2","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/configuration","description":"a simple, but flexible, way for anyone to stand up an instance of the edX platform that is fully configured and ready-to-go","fork":false,"url":"https://api.github.com/repos/edx/configuration","forks_url":"https://api.github.com/repos/edx/configuration/forks","keys_url":"https://api.github.com/repos/edx/configuration/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/configuration/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/configuration/teams","hooks_url":"https://api.github.com/repos/edx/configuration/hooks","issue_events_url":"https://api.github.com/repos/edx/configuration/issues/events{/number}","events_url":"https://api.github.com/repos/edx/configuration/events","assignees_url":"https://api.github.com/repos/edx/configuration/assignees{/user}","branches_url":"https://api.github.com/repos/edx/configuration/branches{/branch}","tags_url":"https://api.github.com/repos/edx/configuration/tags","blobs_url":"https://api.github.com/repos/edx/configuration/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/configuration/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/configuration/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/configuration/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/configuration/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/configuration/languages","stargazers_url":"https://api.github.com/repos/edx/configuration/stargazers","contributors_url":"https://api.github.com/repos/edx/configuration/contributors","subscribers_url":"https://api.github.com/repos/edx/configuration/subscribers","subscription_url":"https://api.github.com/repos/edx/configuration/subscription","commits_url":"https://api.github.com/repos/edx/configuration/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/configuration/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/configuration/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/configuration/issues/comments/{number}","contents_url":"https://api.github.com/repos/edx/configuration/contents/{+path}","compare_url":"https://api.github.com/repos/edx/configuration/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/configuration/merges","archive_url":"https://api.github.com/repos/edx/configuration/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/configuration/downloads","issues_url":"https://api.github.com/repos/edx/configuration/issues{/number}","pulls_url":"https://api.github.com/repos/edx/configuration/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/configuration/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/configuration/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/configuration/labels{/name}","releases_url":"https://api.github.com/repos/edx/configuration/releases{/id}","created_at":"2013-04-16T17:23:42Z","updated_at":"2014-10-05T06:42:48Z","pushed_at":"2014-10-08T15:09:56Z","git_url":"git://github.com/edx/configuration.git","ssh_url":"git@github.com:edx/configuration.git","clone_url":"https://github.com/edx/configuration.git","svn_url":"https://github.com/edx/configuration","homepage":"","size":58147,"stargazers_count":265,"watchers_count":265,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":227,"mirror_url":null,"open_issues_count":13,"forks":227,"open_issues":13,"watchers":265,"default_branch":"master"}},"base":{"label":"edx:master","ref":"master","sha":"23b99bc2800d9a2a5b255df4c5d79bd5fa16788f","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=2","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":9478219,"name":"configuration","full_name":"edx/configuration","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=2","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/configuration","description":"a simple, but flexible, way for anyone to stand up an instance of the edX platform that is fully configured and ready-to-go","fork":false,"url":"https://api.github.com/repos/edx/configuration","forks_url":"https://api.github.com/repos/edx/configuration/forks","keys_url":"https://api.github.com/repos/edx/configuration/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/configuration/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/configuration/teams","hooks_url":"https://api.github.com/repos/edx/configuration/hooks","issue_events_url":"https://api.github.com/repos/edx/configuration/issues/events{/number}","events_url":"https://api.github.com/repos/edx/configuration/events","assignees_url":"https://api.github.com/repos/edx/configuration/assignees{/user}","branches_url":"https://api.github.com/repos/edx/configuration/branches{/branch}","tags_url":"https://api.github.com/repos/edx/configuration/tags","blobs_url":"https://api.github.com/repos/edx/configuration/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/configuration/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/configuration/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/configuration/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/configuration/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/configuration/languages","stargazers_url":"https://api.github.com/repos/edx/configuration/stargazers","contributors_url":"https://api.github.com/repos/edx/configuration/contributors","subscribers_url":"https://api.github.com/repos/edx/configuration/subscribers","subscription_url":"https://api.github.com/repos/edx/configuration/subscription","commits_url":"https://api.github.com/repos/edx/configuration/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/configuration/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/configuration/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/configuration/issues/comments/{number}","contents_url":"https://api.github.com/repos/edx/configuration/contents/{+path}","compare_url":"https://api.github.com/repos/edx/configuration/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/configuration/merges","archive_url":"https://api.github.com/repos/edx/configuration/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/configuration/downloads","issues_url":"https://api.github.com/repos/edx/configuration/issues{/number}","pulls_url":"https://api.github.com/repos/edx/configuration/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/configuration/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/configuration/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/configuration/labels{/name}","releases_url":"https://api.github.com/repos/edx/configuration/releases{/id}","created_at":"2013-04-16T17:23:42Z","updated_at":"2014-10-05T06:42:48Z","pushed_at":"2014-10-08T15:09:56Z","git_url":"git://github.com/edx/configuration.git","ssh_url":"git@github.com:edx/configuration.git","clone_url":"https://github.com/edx/configuration.git","svn_url":"https://github.com/edx/configuration","homepage":"","size":58147,"stargazers_count":265,"watchers_count":265,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":227,"mirror_url":null,"open_issues_count":13,"forks":227,"open_issues":13,"watchers":265,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx/configuration/pulls/1620"},"html":{"href":"https://github.com/edx/configuration/pull/1620"},"issue":{"href":"https://api.github.com/repos/edx/configuration/issues/1620"},"comments":{"href":"https://api.github.com/repos/edx/configuration/issues/1620/comments"},"review_comments":{"href":"https://api.github.com/repos/edx/configuration/pulls/1620/comments"},"review_comment":{"href":"https://api.github.com/repos/edx/configuration/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/edx/configuration/pulls/1620/commits"},"statuses":{"href":"https://api.github.com/repos/edx/configuration/statuses/2ece95b7293aa261f0088a01fa90432ff1d3d283"}}}}