GitHub PullRequestReviewCommentEvent at 2014-12-23 17:26:12
Repository: level_up_exercises
Actor: sshao
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/comments/22224606","id":22224606,"diff_hunk":"@@ -0,0 +1,28 @@\n+Then(/^I should see \"(.*?)\"$/) do |arg1|\n+  # I want this to be flashed only the first\n+  # time a bomb is created...How to test?\n+  expect(page).to have_content(arg1)\n+end\n+\n+Given(/^a bomb has been created and activated$/) do\n+  visit('/')\n+  fill_in(\"create_activation_code\", with: 1234)\n+  fill_in(\"create_deactivation_code\", with: 0000)\n+  click_button('Create!')\n+  fill_in \"activation_code\", with: 1234\n+  click_button('Activate!')\n+  # expect(current_path).to eq(\"/bomb/active\")\n+end\n+\n+When(/^I wait (\\d+) seconds to do something$/) do |arg1|\n+  # Make timer an arg to Bomb\n+  # Mock?\n+  sleep(arg1.to_i)\n+  click_button('Deactivate!')\n+end\n+\n+Then(/^the bomb should have exploded$/) do\n+  # Should we be checking paths?","path":"overlord/features/step_definitions/general_steps.rb","position":25,"original_position":25,"commit_id":"6fed895f8bc56a741e9edc80b12a8f0405588edc","original_commit_id":"6fed895f8bc56a741e9edc80b12a8f0405588edc","user":{"login":"sshao","id":1361309,"avatar_url":"https://avatars.githubusercontent.com/u/1361309?v=3","gravatar_id":"","url":"https://api.github.com/users/sshao","html_url":"https://github.com/sshao","followers_url":"https://api.github.com/users/sshao/followers","following_url":"https://api.github.com/users/sshao/following{/other_user}","gists_url":"https://api.github.com/users/sshao/gists{/gist_id}","starred_url":"https://api.github.com/users/sshao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sshao/subscriptions","organizations_url":"https://api.github.com/users/sshao/orgs","repos_url":"https://api.github.com/users/sshao/repos","events_url":"https://api.github.com/users/sshao/events{/privacy}","received_events_url":"https://api.github.com/users/sshao/received_events","type":"User","site_admin":false},"body":"checking paths seems fine to me. if you deleted line 26 and if \"Everyone's dead\" a flash error message, then there's a possible scenario in which the app *doesn't* redirect to \"/exploded\", but \"Everyone's dead\" is still displayed as a flash. in that case, this cuke would pass, even though your app hasn't actually done what you expected it to.","created_at":"2014-12-23T17:26:12Z","updated_at":"2014-12-23T17:26:12Z","html_url":"https://github.com/jmmastey/level_up_exercises/pull/354#discussion_r22224606","pull_request_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/354","_links":{"self":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/comments/22224606"},"html":{"href":"https://github.com/jmmastey/level_up_exercises/pull/354#discussion_r22224606"},"pull_request":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/354"}}},"pull_request":{"url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/354","id":26269166,"html_url":"https://github.com/jmmastey/level_up_exercises/pull/354","diff_url":"https://github.com/jmmastey/level_up_exercises/pull/354.diff","patch_url":"https://github.com/jmmastey/level_up_exercises/pull/354.patch","issue_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/354","number":354,"state":"open","locked":false,"title":"Overlord2/mabdeljalil Version 1","user":{"login":"msabdeljalil","id":5350720,"avatar_url":"https://avatars.githubusercontent.com/u/5350720?v=3","gravatar_id":"","url":"https://api.github.com/users/msabdeljalil","html_url":"https://github.com/msabdeljalil","followers_url":"https://api.github.com/users/msabdeljalil/followers","following_url":"https://api.github.com/users/msabdeljalil/following{/other_user}","gists_url":"https://api.github.com/users/msabdeljalil/gists{/gist_id}","starred_url":"https://api.github.com/users/msabdeljalil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msabdeljalil/subscriptions","organizations_url":"https://api.github.com/users/msabdeljalil/orgs","repos_url":"https://api.github.com/users/msabdeljalil/repos","events_url":"https://api.github.com/users/msabdeljalil/events{/privacy}","received_events_url":"https://api.github.com/users/msabdeljalil/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-12-18T00:32:20Z","updated_at":"2014-12-23T17:26:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0664425b6b3bc329c075ee47f8b740eb8b7929db","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/354/commits","review_comments_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/354/comments","review_comment_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/comments/{number}","comments_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/354/comments","statuses_url":"https://api.github.com/repos/jmmastey/level_up_exercises/statuses/6fed895f8bc56a741e9edc80b12a8f0405588edc","head":{"label":"msabdeljalil:overlord2/mabdeljalil","ref":"overlord2/mabdeljalil","sha":"6fed895f8bc56a741e9edc80b12a8f0405588edc","user":{"login":"msabdeljalil","id":5350720,"avatar_url":"https://avatars.githubusercontent.com/u/5350720?v=3","gravatar_id":"","url":"https://api.github.com/users/msabdeljalil","html_url":"https://github.com/msabdeljalil","followers_url":"https://api.github.com/users/msabdeljalil/followers","following_url":"https://api.github.com/users/msabdeljalil/following{/other_user}","gists_url":"https://api.github.com/users/msabdeljalil/gists{/gist_id}","starred_url":"https://api.github.com/users/msabdeljalil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msabdeljalil/subscriptions","organizations_url":"https://api.github.com/users/msabdeljalil/orgs","repos_url":"https://api.github.com/users/msabdeljalil/repos","events_url":"https://api.github.com/users/msabdeljalil/events{/privacy}","received_events_url":"https://api.github.com/users/msabdeljalil/received_events","type":"User","site_admin":false},"repo":{"id":25488411,"name":"level_up_exercises","full_name":"msabdeljalil/level_up_exercises","owner":{"login":"msabdeljalil","id":5350720,"avatar_url":"https://avatars.githubusercontent.com/u/5350720?v=3","gravatar_id":"","url":"https://api.github.com/users/msabdeljalil","html_url":"https://github.com/msabdeljalil","followers_url":"https://api.github.com/users/msabdeljalil/followers","following_url":"https://api.github.com/users/msabdeljalil/following{/other_user}","gists_url":"https://api.github.com/users/msabdeljalil/gists{/gist_id}","starred_url":"https://api.github.com/users/msabdeljalil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msabdeljalil/subscriptions","organizations_url":"https://api.github.com/users/msabdeljalil/orgs","repos_url":"https://api.github.com/users/msabdeljalil/repos","events_url":"https://api.github.com/users/msabdeljalil/events{/privacy}","received_events_url":"https://api.github.com/users/msabdeljalil/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/msabdeljalil/level_up_exercises","description":"A series of code-related assignments to challenge starting engineers","fork":true,"url":"https://api.github.com/repos/msabdeljalil/level_up_exercises","forks_url":"https://api.github.com/repos/msabdeljalil/level_up_exercises/forks","keys_url":"https://api.github.com/repos/msabdeljalil/level_up_exercises/keys{/key_id}","collaborators_url":"https://api.github.com/repos/msabdeljalil/level_up_exercises/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/msabdeljalil/level_up_exercises/teams","hooks_url":"https://api.github.com/repos/msabdeljalil/level_up_exercises/hooks","issue_events_url":"https://api.github.com/repos/msabdeljalil/level_up_exercises/issues/events{/number}","events_url":"https://api.github.com/repos/msabdeljalil/level_up_exercises/events","assignees_url":"https://api.github.com/repos/msabdeljalil/level_up_exercises/assignees{/user}","branches_url":"https://api.github.com/repos/msabdeljalil/level_up_exercises/branches{/branch}","tags_url":"https://api.github.com/repos/msabdeljalil/level_up_exercises/tags","blobs_url":"https://api.github.com/repos/msabdeljalil/level_up_exercises/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/msabdeljalil/level_up_exercises/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/msabdeljalil/level_up_exercises/git/refs{/sha}","trees_url":"https://api.github.com/repos/msabdeljalil/level_up_exercises/git/trees{/sha}","statuses_url":"https://api.github.com/repos/msabdeljalil/level_up_exercises/statuses/{sha}","languages_url":"https://api.github.com/repos/msabdeljalil/level_up_exercises/languages","stargazers_url":"https://api.github.com/repos/msabdeljalil/level_up_exercises/stargazers","contributors_url":"https://api.github.com/repos/msabdeljalil/level_up_exercises/contributors","subscribers_url":"https://api.github.com/repos/msabdeljalil/level_up_exercises/subscribers","subscription_url":"https://api.github.com/repos/msabdeljalil/level_up_exercises/subscription","commits_url":"https://api.github.com/repos/msabdeljalil/level_up_exercises/commits{/sha}","git_commits_url":"https://api.github.com/repos/msabdeljalil/level_up_exercises/git/commits{/sha}","comments_url":"https://api.github.com/repos/msabdeljalil/level_up_exercises/comments{/number}","issue_comment_url":"https://api.github.com/repos/msabdeljalil/level_up_exercises/issues/comments/{number}","contents_url":"https://api.github.com/repos/msabdeljalil/level_up_exercises/contents/{+path}","compare_url":"https://api.github.com/repos/msabdeljalil/level_up_exercises/compare/{base}...{head}","merges_url":"https://api.github.com/repos/msabdeljalil/level_up_exercises/merges","archive_url":"https://api.github.com/repos/msabdeljalil/level_up_exercises/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/msabdeljalil/level_up_exercises/downloads","issues_url":"https://api.github.com/repos/msabdeljalil/level_up_exercises/issues{/number}","pulls_url":"https://api.github.com/repos/msabdeljalil/level_up_exercises/pulls{/number}","milestones_url":"https://api.github.com/repos/msabdeljalil/level_up_exercises/milestones{/number}","notifications_url":"https://api.github.com/repos/msabdeljalil/level_up_exercises/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/msabdeljalil/level_up_exercises/labels{/name}","releases_url":"https://api.github.com/repos/msabdeljalil/level_up_exercises/releases{/id}","created_at":"2014-10-20T21:57:02Z","updated_at":"2014-10-09T06:13:13Z","pushed_at":"2014-12-22T18:50:36Z","git_url":"git://github.com/msabdeljalil/level_up_exercises.git","ssh_url":"git@github.com:msabdeljalil/level_up_exercises.git","clone_url":"https://github.com/msabdeljalil/level_up_exercises.git","svn_url":"https://github.com/msabdeljalil/level_up_exercises","homepage":"http://leveluprails.herokuapp.com","size":505,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jmmastey:master","ref":"master","sha":"d6fb3782079429bc5629858bbd6c76ee3d4906b0","user":{"login":"jmmastey","id":302011,"avatar_url":"https://avatars.githubusercontent.com/u/302011?v=3","gravatar_id":"","url":"https://api.github.com/users/jmmastey","html_url":"https://github.com/jmmastey","followers_url":"https://api.github.com/users/jmmastey/followers","following_url":"https://api.github.com/users/jmmastey/following{/other_user}","gists_url":"https://api.github.com/users/jmmastey/gists{/gist_id}","starred_url":"https://api.github.com/users/jmmastey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmmastey/subscriptions","organizations_url":"https://api.github.com/users/jmmastey/orgs","repos_url":"https://api.github.com/users/jmmastey/repos","events_url":"https://api.github.com/users/jmmastey/events{/privacy}","received_events_url":"https://api.github.com/users/jmmastey/received_events","type":"User","site_admin":false},"repo":{"id":20705648,"name":"level_up_exercises","full_name":"jmmastey/level_up_exercises","owner":{"login":"jmmastey","id":302011,"avatar_url":"https://avatars.githubusercontent.com/u/302011?v=3","gravatar_id":"","url":"https://api.github.com/users/jmmastey","html_url":"https://github.com/jmmastey","followers_url":"https://api.github.com/users/jmmastey/followers","following_url":"https://api.github.com/users/jmmastey/following{/other_user}","gists_url":"https://api.github.com/users/jmmastey/gists{/gist_id}","starred_url":"https://api.github.com/users/jmmastey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmmastey/subscriptions","organizations_url":"https://api.github.com/users/jmmastey/orgs","repos_url":"https://api.github.com/users/jmmastey/repos","events_url":"https://api.github.com/users/jmmastey/events{/privacy}","received_events_url":"https://api.github.com/users/jmmastey/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jmmastey/level_up_exercises","description":"A series of code-related assignments to challenge starting engineers","fork":false,"url":"https://api.github.com/repos/jmmastey/level_up_exercises","forks_url":"https://api.github.com/repos/jmmastey/level_up_exercises/forks","keys_url":"https://api.github.com/repos/jmmastey/level_up_exercises/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jmmastey/level_up_exercises/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jmmastey/level_up_exercises/teams","hooks_url":"https://api.github.com/repos/jmmastey/level_up_exercises/hooks","issue_events_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/events{/number}","events_url":"https://api.github.com/repos/jmmastey/level_up_exercises/events","assignees_url":"https://api.github.com/repos/jmmastey/level_up_exercises/assignees{/user}","branches_url":"https://api.github.com/repos/jmmastey/level_up_exercises/branches{/branch}","tags_url":"https://api.github.com/repos/jmmastey/level_up_exercises/tags","blobs_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/refs{/sha}","trees_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jmmastey/level_up_exercises/statuses/{sha}","languages_url":"https://api.github.com/repos/jmmastey/level_up_exercises/languages","stargazers_url":"https://api.github.com/repos/jmmastey/level_up_exercises/stargazers","contributors_url":"https://api.github.com/repos/jmmastey/level_up_exercises/contributors","subscribers_url":"https://api.github.com/repos/jmmastey/level_up_exercises/subscribers","subscription_url":"https://api.github.com/repos/jmmastey/level_up_exercises/subscription","commits_url":"https://api.github.com/repos/jmmastey/level_up_exercises/commits{/sha}","git_commits_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/commits{/sha}","comments_url":"https://api.github.com/repos/jmmastey/level_up_exercises/comments{/number}","issue_comment_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/comments/{number}","contents_url":"https://api.github.com/repos/jmmastey/level_up_exercises/contents/{+path}","compare_url":"https://api.github.com/repos/jmmastey/level_up_exercises/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jmmastey/level_up_exercises/merges","archive_url":"https://api.github.com/repos/jmmastey/level_up_exercises/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jmmastey/level_up_exercises/downloads","issues_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues{/number}","pulls_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls{/number}","milestones_url":"https://api.github.com/repos/jmmastey/level_up_exercises/milestones{/number}","notifications_url":"https://api.github.com/repos/jmmastey/level_up_exercises/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jmmastey/level_up_exercises/labels{/name}","releases_url":"https://api.github.com/repos/jmmastey/level_up_exercises/releases{/id}","created_at":"2014-06-10T23:42:24Z","updated_at":"2014-12-23T16:31:14Z","pushed_at":"2014-12-23T16:31:14Z","git_url":"git://github.com/jmmastey/level_up_exercises.git","ssh_url":"git@github.com:jmmastey/level_up_exercises.git","clone_url":"https://github.com/jmmastey/level_up_exercises.git","svn_url":"https://github.com/jmmastey/level_up_exercises","homepage":"http://leveluprails.herokuapp.com","size":39009,"stargazers_count":13,"watchers_count":13,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":52,"mirror_url":null,"open_issues_count":7,"forks":52,"open_issues":7,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/354"},"html":{"href":"https://github.com/jmmastey/level_up_exercises/pull/354"},"issue":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/354"},"comments":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/354/comments"},"review_comments":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/354/comments"},"review_comment":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/354/commits"},"statuses":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/statuses/6fed895f8bc56a741e9edc80b12a8f0405588edc"}}}}