GitHub PullRequestReviewCommentEvent at 2014-08-04 08:26:44
Repository: TestStack.BDDfy
Actor: OmerRaviv
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/TestStack/TestStack.BDDfy/pulls/comments/15744879","id":15744879,"diff_hunk":"@@ -52,7 +53,7 @@ public Result ExecuteStep(Step step)\n         {\n             try\n             {\n-                step.Execute(_scenario.TestObject);\n+                AsyncTestRunner.Run(() => Configurator.StepExecutor.Execute(step, _scenario.TestObject));","path":"TestStack.BDDfy/Processors/ScenarioExecutor.cs","position":13,"original_position":13,"commit_id":"b771f4cc3e8d5522a97e88a3610282847e874733","original_commit_id":"b771f4cc3e8d5522a97e88a3610282847e874733","user":{"login":"OmerRaviv","id":641292,"avatar_url":"https://avatars.githubusercontent.com/u/641292?v=1","gravatar_id":"1cc4dd1557e9546feb177bd947285f5d","url":"https://api.github.com/users/OmerRaviv","html_url":"https://github.com/OmerRaviv","followers_url":"https://api.github.com/users/OmerRaviv/followers","following_url":"https://api.github.com/users/OmerRaviv/following{/other_user}","gists_url":"https://api.github.com/users/OmerRaviv/gists{/gist_id}","starred_url":"https://api.github.com/users/OmerRaviv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OmerRaviv/subscriptions","organizations_url":"https://api.github.com/users/OmerRaviv/orgs","repos_url":"https://api.github.com/users/OmerRaviv/repos","events_url":"https://api.github.com/users/OmerRaviv/events{/privacy}","received_events_url":"https://api.github.com/users/OmerRaviv/received_events","type":"User","site_admin":false},"body":"@JakeGinnivan  No actually, it's the reverse - the deadlock only happens if we were to call the AsyncTestRunner from the UI thread (meaning, if it was called from within the StepExecutor itself). This way, the StepExecutor can choose to marshal the actual execution to whatever thread they like, and the AsyncTestRunner successfully waits for it to finish.","created_at":"2014-08-04T08:26:44Z","updated_at":"2014-08-04T08:26:44Z","html_url":"https://github.com/TestStack/TestStack.BDDfy/pull/169#discussion_r15744879","pull_request_url":"https://api.github.com/repos/TestStack/TestStack.BDDfy/pulls/169","_links":{"self":{"href":"https://api.github.com/repos/TestStack/TestStack.BDDfy/pulls/comments/15744879"},"html":{"href":"https://github.com/TestStack/TestStack.BDDfy/pull/169#discussion_r15744879"},"pull_request":{"href":"https://api.github.com/repos/TestStack/TestStack.BDDfy/pulls/169"}}},"pull_request":{"url":"https://api.github.com/repos/TestStack/TestStack.BDDfy/pulls/169","id":19258149,"html_url":"https://github.com/TestStack/TestStack.BDDfy/pull/169","diff_url":"https://github.com/TestStack/TestStack.BDDfy/pull/169.diff","patch_url":"https://github.com/TestStack/TestStack.BDDfy/pull/169.patch","issue_url":"https://api.github.com/repos/TestStack/TestStack.BDDfy/issues/169","number":169,"state":"open","title":"Added StepExecutor class to allow users to add custom logic before/after each step.","user":{"login":"OmerRaviv","id":641292,"avatar_url":"https://avatars.githubusercontent.com/u/641292?v=1","gravatar_id":"1cc4dd1557e9546feb177bd947285f5d","url":"https://api.github.com/users/OmerRaviv","html_url":"https://github.com/OmerRaviv","followers_url":"https://api.github.com/users/OmerRaviv/followers","following_url":"https://api.github.com/users/OmerRaviv/following{/other_user}","gists_url":"https://api.github.com/users/OmerRaviv/gists{/gist_id}","starred_url":"https://api.github.com/users/OmerRaviv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OmerRaviv/subscriptions","organizations_url":"https://api.github.com/users/OmerRaviv/orgs","repos_url":"https://api.github.com/users/OmerRaviv/repos","events_url":"https://api.github.com/users/OmerRaviv/events{/privacy}","received_events_url":"https://api.github.com/users/OmerRaviv/received_events","type":"User","site_admin":false},"body":"See discussion in pull request #164 .","created_at":"2014-08-03T18:49:04Z","updated_at":"2014-08-04T08:26:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"65357f4862497db5d840bfe5291348227b3a3f9b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/TestStack/TestStack.BDDfy/pulls/169/commits","review_comments_url":"https://api.github.com/repos/TestStack/TestStack.BDDfy/pulls/169/comments","review_comment_url":"https://api.github.com/repos/TestStack/TestStack.BDDfy/pulls/comments/{number}","comments_url":"https://api.github.com/repos/TestStack/TestStack.BDDfy/issues/169/comments","statuses_url":"https://api.github.com/repos/TestStack/TestStack.BDDfy/statuses/b771f4cc3e8d5522a97e88a3610282847e874733","head":{"label":"OmerRaviv:aspects","ref":"aspects","sha":"b771f4cc3e8d5522a97e88a3610282847e874733","user":{"login":"OmerRaviv","id":641292,"avatar_url":"https://avatars.githubusercontent.com/u/641292?v=1","gravatar_id":"1cc4dd1557e9546feb177bd947285f5d","url":"https://api.github.com/users/OmerRaviv","html_url":"https://github.com/OmerRaviv","followers_url":"https://api.github.com/users/OmerRaviv/followers","following_url":"https://api.github.com/users/OmerRaviv/following{/other_user}","gists_url":"https://api.github.com/users/OmerRaviv/gists{/gist_id}","starred_url":"https://api.github.com/users/OmerRaviv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OmerRaviv/subscriptions","organizations_url":"https://api.github.com/users/OmerRaviv/orgs","repos_url":"https://api.github.com/users/OmerRaviv/repos","events_url":"https://api.github.com/users/OmerRaviv/events{/privacy}","received_events_url":"https://api.github.com/users/OmerRaviv/received_events","type":"User","site_admin":false},"repo":{"id":22137470,"name":"TestStack.BDDfy","full_name":"OmerRaviv/TestStack.BDDfy","owner":{"login":"OmerRaviv","id":641292,"avatar_url":"https://avatars.githubusercontent.com/u/641292?v=1","gravatar_id":"1cc4dd1557e9546feb177bd947285f5d","url":"https://api.github.com/users/OmerRaviv","html_url":"https://github.com/OmerRaviv","followers_url":"https://api.github.com/users/OmerRaviv/followers","following_url":"https://api.github.com/users/OmerRaviv/following{/other_user}","gists_url":"https://api.github.com/users/OmerRaviv/gists{/gist_id}","starred_url":"https://api.github.com/users/OmerRaviv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OmerRaviv/subscriptions","organizations_url":"https://api.github.com/users/OmerRaviv/orgs","repos_url":"https://api.github.com/users/OmerRaviv/repos","events_url":"https://api.github.com/users/OmerRaviv/events{/privacy}","received_events_url":"https://api.github.com/users/OmerRaviv/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/OmerRaviv/TestStack.BDDfy","description":"BDDfy is the simplest BDD framework EVER!","fork":true,"url":"https://api.github.com/repos/OmerRaviv/TestStack.BDDfy","forks_url":"https://api.github.com/repos/OmerRaviv/TestStack.BDDfy/forks","keys_url":"https://api.github.com/repos/OmerRaviv/TestStack.BDDfy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OmerRaviv/TestStack.BDDfy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OmerRaviv/TestStack.BDDfy/teams","hooks_url":"https://api.github.com/repos/OmerRaviv/TestStack.BDDfy/hooks","issue_events_url":"https://api.github.com/repos/OmerRaviv/TestStack.BDDfy/issues/events{/number}","events_url":"https://api.github.com/repos/OmerRaviv/TestStack.BDDfy/events","assignees_url":"https://api.github.com/repos/OmerRaviv/TestStack.BDDfy/assignees{/user}","branches_url":"https://api.github.com/repos/OmerRaviv/TestStack.BDDfy/branches{/branch}","tags_url":"https://api.github.com/repos/OmerRaviv/TestStack.BDDfy/tags","blobs_url":"https://api.github.com/repos/OmerRaviv/TestStack.BDDfy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OmerRaviv/TestStack.BDDfy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OmerRaviv/TestStack.BDDfy/git/refs{/sha}","trees_url":"https://api.github.com/repos/OmerRaviv/TestStack.BDDfy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OmerRaviv/TestStack.BDDfy/statuses/{sha}","languages_url":"https://api.github.com/repos/OmerRaviv/TestStack.BDDfy/languages","stargazers_url":"https://api.github.com/repos/OmerRaviv/TestStack.BDDfy/stargazers","contributors_url":"https://api.github.com/repos/OmerRaviv/TestStack.BDDfy/contributors","subscribers_url":"https://api.github.com/repos/OmerRaviv/TestStack.BDDfy/subscribers","subscription_url":"https://api.github.com/repos/OmerRaviv/TestStack.BDDfy/subscription","commits_url":"https://api.github.com/repos/OmerRaviv/TestStack.BDDfy/commits{/sha}","git_commits_url":"https://api.github.com/repos/OmerRaviv/TestStack.BDDfy/git/commits{/sha}","comments_url":"https://api.github.com/repos/OmerRaviv/TestStack.BDDfy/comments{/number}","issue_comment_url":"https://api.github.com/repos/OmerRaviv/TestStack.BDDfy/issues/comments/{number}","contents_url":"https://api.github.com/repos/OmerRaviv/TestStack.BDDfy/contents/{+path}","compare_url":"https://api.github.com/repos/OmerRaviv/TestStack.BDDfy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OmerRaviv/TestStack.BDDfy/merges","archive_url":"https://api.github.com/repos/OmerRaviv/TestStack.BDDfy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OmerRaviv/TestStack.BDDfy/downloads","issues_url":"https://api.github.com/repos/OmerRaviv/TestStack.BDDfy/issues{/number}","pulls_url":"https://api.github.com/repos/OmerRaviv/TestStack.BDDfy/pulls{/number}","milestones_url":"https://api.github.com/repos/OmerRaviv/TestStack.BDDfy/milestones{/number}","notifications_url":"https://api.github.com/repos/OmerRaviv/TestStack.BDDfy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OmerRaviv/TestStack.BDDfy/labels{/name}","releases_url":"https://api.github.com/repos/OmerRaviv/TestStack.BDDfy/releases{/id}","created_at":"2014-07-23T08:03:21Z","updated_at":"2014-07-24T10:51:33Z","pushed_at":"2014-07-29T10:17:19Z","git_url":"git://github.com/OmerRaviv/TestStack.BDDfy.git","ssh_url":"git@github.com:OmerRaviv/TestStack.BDDfy.git","clone_url":"https://github.com/OmerRaviv/TestStack.BDDfy.git","svn_url":"https://github.com/OmerRaviv/TestStack.BDDfy","homepage":"","size":7878,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"TestStack:master","ref":"master","sha":"a5bb6440f803bcaa9209abf489035c6508cf78b0","user":{"login":"TestStack","id":1782385,"avatar_url":"https://avatars.githubusercontent.com/u/1782385?v=1","gravatar_id":"60f39ca1495a93e142174ccbbe4e4812","url":"https://api.github.com/users/TestStack","html_url":"https://github.com/TestStack","followers_url":"https://api.github.com/users/TestStack/followers","following_url":"https://api.github.com/users/TestStack/following{/other_user}","gists_url":"https://api.github.com/users/TestStack/gists{/gist_id}","starred_url":"https://api.github.com/users/TestStack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TestStack/subscriptions","organizations_url":"https://api.github.com/users/TestStack/orgs","repos_url":"https://api.github.com/users/TestStack/repos","events_url":"https://api.github.com/users/TestStack/events{/privacy}","received_events_url":"https://api.github.com/users/TestStack/received_events","type":"Organization","site_admin":false},"repo":{"id":4481712,"name":"TestStack.BDDfy","full_name":"TestStack/TestStack.BDDfy","owner":{"login":"TestStack","id":1782385,"avatar_url":"https://avatars.githubusercontent.com/u/1782385?v=1","gravatar_id":"60f39ca1495a93e142174ccbbe4e4812","url":"https://api.github.com/users/TestStack","html_url":"https://github.com/TestStack","followers_url":"https://api.github.com/users/TestStack/followers","following_url":"https://api.github.com/users/TestStack/following{/other_user}","gists_url":"https://api.github.com/users/TestStack/gists{/gist_id}","starred_url":"https://api.github.com/users/TestStack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TestStack/subscriptions","organizations_url":"https://api.github.com/users/TestStack/orgs","repos_url":"https://api.github.com/users/TestStack/repos","events_url":"https://api.github.com/users/TestStack/events{/privacy}","received_events_url":"https://api.github.com/users/TestStack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TestStack/TestStack.BDDfy","description":"BDDfy is the simplest BDD framework EVER!","fork":false,"url":"https://api.github.com/repos/TestStack/TestStack.BDDfy","forks_url":"https://api.github.com/repos/TestStack/TestStack.BDDfy/forks","keys_url":"https://api.github.com/repos/TestStack/TestStack.BDDfy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TestStack/TestStack.BDDfy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TestStack/TestStack.BDDfy/teams","hooks_url":"https://api.github.com/repos/TestStack/TestStack.BDDfy/hooks","issue_events_url":"https://api.github.com/repos/TestStack/TestStack.BDDfy/issues/events{/number}","events_url":"https://api.github.com/repos/TestStack/TestStack.BDDfy/events","assignees_url":"https://api.github.com/repos/TestStack/TestStack.BDDfy/assignees{/user}","branches_url":"https://api.github.com/repos/TestStack/TestStack.BDDfy/branches{/branch}","tags_url":"https://api.github.com/repos/TestStack/TestStack.BDDfy/tags","blobs_url":"https://api.github.com/repos/TestStack/TestStack.BDDfy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TestStack/TestStack.BDDfy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TestStack/TestStack.BDDfy/git/refs{/sha}","trees_url":"https://api.github.com/repos/TestStack/TestStack.BDDfy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TestStack/TestStack.BDDfy/statuses/{sha}","languages_url":"https://api.github.com/repos/TestStack/TestStack.BDDfy/languages","stargazers_url":"https://api.github.com/repos/TestStack/TestStack.BDDfy/stargazers","contributors_url":"https://api.github.com/repos/TestStack/TestStack.BDDfy/contributors","subscribers_url":"https://api.github.com/repos/TestStack/TestStack.BDDfy/subscribers","subscription_url":"https://api.github.com/repos/TestStack/TestStack.BDDfy/subscription","commits_url":"https://api.github.com/repos/TestStack/TestStack.BDDfy/commits{/sha}","git_commits_url":"https://api.github.com/repos/TestStack/TestStack.BDDfy/git/commits{/sha}","comments_url":"https://api.github.com/repos/TestStack/TestStack.BDDfy/comments{/number}","issue_comment_url":"https://api.github.com/repos/TestStack/TestStack.BDDfy/issues/comments/{number}","contents_url":"https://api.github.com/repos/TestStack/TestStack.BDDfy/contents/{+path}","compare_url":"https://api.github.com/repos/TestStack/TestStack.BDDfy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TestStack/TestStack.BDDfy/merges","archive_url":"https://api.github.com/repos/TestStack/TestStack.BDDfy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TestStack/TestStack.BDDfy/downloads","issues_url":"https://api.github.com/repos/TestStack/TestStack.BDDfy/issues{/number}","pulls_url":"https://api.github.com/repos/TestStack/TestStack.BDDfy/pulls{/number}","milestones_url":"https://api.github.com/repos/TestStack/TestStack.BDDfy/milestones{/number}","notifications_url":"https://api.github.com/repos/TestStack/TestStack.BDDfy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TestStack/TestStack.BDDfy/labels{/name}","releases_url":"https://api.github.com/repos/TestStack/TestStack.BDDfy/releases{/id}","created_at":"2012-05-29T12:19:29Z","updated_at":"2014-08-02T21:09:22Z","pushed_at":"2014-07-27T15:45:23Z","git_url":"git://github.com/TestStack/TestStack.BDDfy.git","ssh_url":"git@github.com:TestStack/TestStack.BDDfy.git","clone_url":"https://github.com/TestStack/TestStack.BDDfy.git","svn_url":"https://github.com/TestStack/TestStack.BDDfy","homepage":"","size":9804,"stargazers_count":85,"watchers_count":85,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":25,"mirror_url":null,"open_issues_count":20,"forks":25,"open_issues":20,"watchers":85,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TestStack/TestStack.BDDfy/pulls/169"},"html":{"href":"https://github.com/TestStack/TestStack.BDDfy/pull/169"},"issue":{"href":"https://api.github.com/repos/TestStack/TestStack.BDDfy/issues/169"},"comments":{"href":"https://api.github.com/repos/TestStack/TestStack.BDDfy/issues/169/comments"},"review_comments":{"href":"https://api.github.com/repos/TestStack/TestStack.BDDfy/pulls/169/comments"},"review_comment":{"href":"https://api.github.com/repos/TestStack/TestStack.BDDfy/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/TestStack/TestStack.BDDfy/pulls/169/commits"},"statuses":{"href":"https://api.github.com/repos/TestStack/TestStack.BDDfy/statuses/b771f4cc3e8d5522a97e88a3610282847e874733"}}}}