GitHub PullRequestReviewCommentEvent at 2014-12-11 22:46:05
Repository: eventlet
Actor: haypo
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/eventlet/eventlet/pulls/comments/21716455","id":21716455,"diff_hunk":"@@ -283,6 +283,12 @@ def monkey_patch(**on):\n     finally:\n         imp.release_lock()\n \n+    if sys.version_info >= (3, 3):\n+        import importlib._bootstrap\n+        thread = original('_thread')\n+        # importlib must use real thread locks, not eventlet.Semaphore","path":"eventlet/patcher.py","position":7,"original_position":7,"commit_id":"fddf1a109d615130011ba893ff5df96b764643ca","original_commit_id":"fddf1a109d615130011ba893ff5df96b764643ca","user":{"login":"haypo","id":194129,"avatar_url":"https://avatars.githubusercontent.com/u/194129?v=3","gravatar_id":"","url":"https://api.github.com/users/haypo","html_url":"https://github.com/haypo","followers_url":"https://api.github.com/users/haypo/followers","following_url":"https://api.github.com/users/haypo/following{/other_user}","gists_url":"https://api.github.com/users/haypo/gists{/gist_id}","starred_url":"https://api.github.com/users/haypo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haypo/subscriptions","organizations_url":"https://api.github.com/users/haypo/orgs","repos_url":"https://api.github.com/users/haypo/repos","events_url":"https://api.github.com/users/haypo/events{/privacy}","received_events_url":"https://api.github.com/users/haypo/received_events","type":"User","site_admin":false},"body":"I added a long explanation in the pull request, did you see it?","created_at":"2014-12-11T22:46:05Z","updated_at":"2014-12-11T22:46:05Z","html_url":"https://github.com/eventlet/eventlet/pull/168#discussion_r21716455","pull_request_url":"https://api.github.com/repos/eventlet/eventlet/pulls/168","_links":{"self":{"href":"https://api.github.com/repos/eventlet/eventlet/pulls/comments/21716455"},"html":{"href":"https://github.com/eventlet/eventlet/pull/168#discussion_r21716455"},"pull_request":{"href":"https://api.github.com/repos/eventlet/eventlet/pulls/168"}}},"pull_request":{"url":"https://api.github.com/repos/eventlet/eventlet/pulls/168","id":24774773,"html_url":"https://github.com/eventlet/eventlet/pull/168","diff_url":"https://github.com/eventlet/eventlet/pull/168.diff","patch_url":"https://github.com/eventlet/eventlet/pull/168.patch","issue_url":"https://api.github.com/repos/eventlet/eventlet/issues/168","number":168,"state":"open","locked":false,"title":"Fix monkey_patch() on Python 3","user":{"login":"haypo","id":194129,"avatar_url":"https://avatars.githubusercontent.com/u/194129?v=3","gravatar_id":"","url":"https://api.github.com/users/haypo","html_url":"https://github.com/haypo","followers_url":"https://api.github.com/users/haypo/followers","following_url":"https://api.github.com/users/haypo/following{/other_user}","gists_url":"https://api.github.com/users/haypo/gists{/gist_id}","starred_url":"https://api.github.com/users/haypo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haypo/subscriptions","organizations_url":"https://api.github.com/users/haypo/orgs","repos_url":"https://api.github.com/users/haypo/repos","events_url":"https://api.github.com/users/haypo/events{/privacy}","received_events_url":"https://api.github.com/users/haypo/received_events","type":"User","site_admin":false},"body":"The importlib module must use real thread locks, not eventlet.Semaphore.\r\n\r\nThe added unit test hangs on Python 3 without the fix.","created_at":"2014-11-20T15:52:05Z","updated_at":"2014-12-11T22:46:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5feec43d1357c639b23e339d56625f82f6a64f76","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/eventlet/eventlet/pulls/168/commits","review_comments_url":"https://api.github.com/repos/eventlet/eventlet/pulls/168/comments","review_comment_url":"https://api.github.com/repos/eventlet/eventlet/pulls/comments/{number}","comments_url":"https://api.github.com/repos/eventlet/eventlet/issues/168/comments","statuses_url":"https://api.github.com/repos/eventlet/eventlet/statuses/fddf1a109d615130011ba893ff5df96b764643ca","head":{"label":"haypo:py3_importlib","ref":"py3_importlib","sha":"fddf1a109d615130011ba893ff5df96b764643ca","user":{"login":"haypo","id":194129,"avatar_url":"https://avatars.githubusercontent.com/u/194129?v=3","gravatar_id":"","url":"https://api.github.com/users/haypo","html_url":"https://github.com/haypo","followers_url":"https://api.github.com/users/haypo/followers","following_url":"https://api.github.com/users/haypo/following{/other_user}","gists_url":"https://api.github.com/users/haypo/gists{/gist_id}","starred_url":"https://api.github.com/users/haypo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haypo/subscriptions","organizations_url":"https://api.github.com/users/haypo/orgs","repos_url":"https://api.github.com/users/haypo/repos","events_url":"https://api.github.com/users/haypo/events{/privacy}","received_events_url":"https://api.github.com/users/haypo/received_events","type":"User","site_admin":false},"repo":{"id":26885447,"name":"eventlet","full_name":"haypo/eventlet","owner":{"login":"haypo","id":194129,"avatar_url":"https://avatars.githubusercontent.com/u/194129?v=3","gravatar_id":"","url":"https://api.github.com/users/haypo","html_url":"https://github.com/haypo","followers_url":"https://api.github.com/users/haypo/followers","following_url":"https://api.github.com/users/haypo/following{/other_user}","gists_url":"https://api.github.com/users/haypo/gists{/gist_id}","starred_url":"https://api.github.com/users/haypo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haypo/subscriptions","organizations_url":"https://api.github.com/users/haypo/orgs","repos_url":"https://api.github.com/users/haypo/repos","events_url":"https://api.github.com/users/haypo/events{/privacy}","received_events_url":"https://api.github.com/users/haypo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/haypo/eventlet","description":"Concurrent networking library for Python (official mirror)","fork":true,"url":"https://api.github.com/repos/haypo/eventlet","forks_url":"https://api.github.com/repos/haypo/eventlet/forks","keys_url":"https://api.github.com/repos/haypo/eventlet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/haypo/eventlet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/haypo/eventlet/teams","hooks_url":"https://api.github.com/repos/haypo/eventlet/hooks","issue_events_url":"https://api.github.com/repos/haypo/eventlet/issues/events{/number}","events_url":"https://api.github.com/repos/haypo/eventlet/events","assignees_url":"https://api.github.com/repos/haypo/eventlet/assignees{/user}","branches_url":"https://api.github.com/repos/haypo/eventlet/branches{/branch}","tags_url":"https://api.github.com/repos/haypo/eventlet/tags","blobs_url":"https://api.github.com/repos/haypo/eventlet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/haypo/eventlet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/haypo/eventlet/git/refs{/sha}","trees_url":"https://api.github.com/repos/haypo/eventlet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/haypo/eventlet/statuses/{sha}","languages_url":"https://api.github.com/repos/haypo/eventlet/languages","stargazers_url":"https://api.github.com/repos/haypo/eventlet/stargazers","contributors_url":"https://api.github.com/repos/haypo/eventlet/contributors","subscribers_url":"https://api.github.com/repos/haypo/eventlet/subscribers","subscription_url":"https://api.github.com/repos/haypo/eventlet/subscription","commits_url":"https://api.github.com/repos/haypo/eventlet/commits{/sha}","git_commits_url":"https://api.github.com/repos/haypo/eventlet/git/commits{/sha}","comments_url":"https://api.github.com/repos/haypo/eventlet/comments{/number}","issue_comment_url":"https://api.github.com/repos/haypo/eventlet/issues/comments/{number}","contents_url":"https://api.github.com/repos/haypo/eventlet/contents/{+path}","compare_url":"https://api.github.com/repos/haypo/eventlet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/haypo/eventlet/merges","archive_url":"https://api.github.com/repos/haypo/eventlet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/haypo/eventlet/downloads","issues_url":"https://api.github.com/repos/haypo/eventlet/issues{/number}","pulls_url":"https://api.github.com/repos/haypo/eventlet/pulls{/number}","milestones_url":"https://api.github.com/repos/haypo/eventlet/milestones{/number}","notifications_url":"https://api.github.com/repos/haypo/eventlet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/haypo/eventlet/labels{/name}","releases_url":"https://api.github.com/repos/haypo/eventlet/releases{/id}","created_at":"2014-11-19T22:49:38Z","updated_at":"2014-11-27T14:07:33Z","pushed_at":"2014-11-27T14:08:33Z","git_url":"git://github.com/haypo/eventlet.git","ssh_url":"git@github.com:haypo/eventlet.git","clone_url":"https://github.com/haypo/eventlet.git","svn_url":"https://github.com/haypo/eventlet","homepage":"eventlet.net","size":6810,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eventlet:master","ref":"master","sha":"8931e9f794356f4d4772344b26dc09ae5e5e8f2f","user":{"login":"eventlet","id":3017635,"avatar_url":"https://avatars.githubusercontent.com/u/3017635?v=3","gravatar_id":"","url":"https://api.github.com/users/eventlet","html_url":"https://github.com/eventlet","followers_url":"https://api.github.com/users/eventlet/followers","following_url":"https://api.github.com/users/eventlet/following{/other_user}","gists_url":"https://api.github.com/users/eventlet/gists{/gist_id}","starred_url":"https://api.github.com/users/eventlet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eventlet/subscriptions","organizations_url":"https://api.github.com/users/eventlet/orgs","repos_url":"https://api.github.com/users/eventlet/repos","events_url":"https://api.github.com/users/eventlet/events{/privacy}","received_events_url":"https://api.github.com/users/eventlet/received_events","type":"Organization","site_admin":false},"repo":{"id":7115259,"name":"eventlet","full_name":"eventlet/eventlet","owner":{"login":"eventlet","id":3017635,"avatar_url":"https://avatars.githubusercontent.com/u/3017635?v=3","gravatar_id":"","url":"https://api.github.com/users/eventlet","html_url":"https://github.com/eventlet","followers_url":"https://api.github.com/users/eventlet/followers","following_url":"https://api.github.com/users/eventlet/following{/other_user}","gists_url":"https://api.github.com/users/eventlet/gists{/gist_id}","starred_url":"https://api.github.com/users/eventlet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eventlet/subscriptions","organizations_url":"https://api.github.com/users/eventlet/orgs","repos_url":"https://api.github.com/users/eventlet/repos","events_url":"https://api.github.com/users/eventlet/events{/privacy}","received_events_url":"https://api.github.com/users/eventlet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eventlet/eventlet","description":"Concurrent networking library for Python (official mirror)","fork":false,"url":"https://api.github.com/repos/eventlet/eventlet","forks_url":"https://api.github.com/repos/eventlet/eventlet/forks","keys_url":"https://api.github.com/repos/eventlet/eventlet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eventlet/eventlet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eventlet/eventlet/teams","hooks_url":"https://api.github.com/repos/eventlet/eventlet/hooks","issue_events_url":"https://api.github.com/repos/eventlet/eventlet/issues/events{/number}","events_url":"https://api.github.com/repos/eventlet/eventlet/events","assignees_url":"https://api.github.com/repos/eventlet/eventlet/assignees{/user}","branches_url":"https://api.github.com/repos/eventlet/eventlet/branches{/branch}","tags_url":"https://api.github.com/repos/eventlet/eventlet/tags","blobs_url":"https://api.github.com/repos/eventlet/eventlet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eventlet/eventlet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eventlet/eventlet/git/refs{/sha}","trees_url":"https://api.github.com/repos/eventlet/eventlet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eventlet/eventlet/statuses/{sha}","languages_url":"https://api.github.com/repos/eventlet/eventlet/languages","stargazers_url":"https://api.github.com/repos/eventlet/eventlet/stargazers","contributors_url":"https://api.github.com/repos/eventlet/eventlet/contributors","subscribers_url":"https://api.github.com/repos/eventlet/eventlet/subscribers","subscription_url":"https://api.github.com/repos/eventlet/eventlet/subscription","commits_url":"https://api.github.com/repos/eventlet/eventlet/commits{/sha}","git_commits_url":"https://api.github.com/repos/eventlet/eventlet/git/commits{/sha}","comments_url":"https://api.github.com/repos/eventlet/eventlet/comments{/number}","issue_comment_url":"https://api.github.com/repos/eventlet/eventlet/issues/comments/{number}","contents_url":"https://api.github.com/repos/eventlet/eventlet/contents/{+path}","compare_url":"https://api.github.com/repos/eventlet/eventlet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eventlet/eventlet/merges","archive_url":"https://api.github.com/repos/eventlet/eventlet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eventlet/eventlet/downloads","issues_url":"https://api.github.com/repos/eventlet/eventlet/issues{/number}","pulls_url":"https://api.github.com/repos/eventlet/eventlet/pulls{/number}","milestones_url":"https://api.github.com/repos/eventlet/eventlet/milestones{/number}","notifications_url":"https://api.github.com/repos/eventlet/eventlet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eventlet/eventlet/labels{/name}","releases_url":"https://api.github.com/repos/eventlet/eventlet/releases{/id}","created_at":"2012-12-11T16:33:20Z","updated_at":"2014-12-11T03:10:26Z","pushed_at":"2014-12-01T00:28:33Z","git_url":"git://github.com/eventlet/eventlet.git","ssh_url":"git@github.com:eventlet/eventlet.git","clone_url":"https://github.com/eventlet/eventlet.git","svn_url":"https://github.com/eventlet/eventlet","homepage":"eventlet.net","size":8655,"stargazers_count":156,"watchers_count":156,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":70,"mirror_url":null,"open_issues_count":60,"forks":70,"open_issues":60,"watchers":156,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eventlet/eventlet/pulls/168"},"html":{"href":"https://github.com/eventlet/eventlet/pull/168"},"issue":{"href":"https://api.github.com/repos/eventlet/eventlet/issues/168"},"comments":{"href":"https://api.github.com/repos/eventlet/eventlet/issues/168/comments"},"review_comments":{"href":"https://api.github.com/repos/eventlet/eventlet/pulls/168/comments"},"review_comment":{"href":"https://api.github.com/repos/eventlet/eventlet/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/eventlet/eventlet/pulls/168/commits"},"statuses":{"href":"https://api.github.com/repos/eventlet/eventlet/statuses/fddf1a109d615130011ba893ff5df96b764643ca"}}}}