GitHub PullRequestEvent at 2014-04-13 16:24:42
Repository: zfs
Actor: ilovezfs
Payload: {"action":"closed","number":145,"pull_request":{"url":"https://api.github.com/repos/openzfsonosx/zfs/pulls/145","id":14695493,"html_url":"https://github.com/openzfsonosx/zfs/pull/145","diff_url":"https://github.com/openzfsonosx/zfs/pull/145.diff","patch_url":"https://github.com/openzfsonosx/zfs/pull/145.patch","issue_url":"https://api.github.com/repos/openzfsonosx/zfs/issues/145","number":145,"state":"closed","title":"Tautological Compare warning fixes","user":{"login":"cbreak-black","id":227017,"avatar_url":"https://avatars.githubusercontent.com/u/227017?","gravatar_id":"c48d5d760df103803bdf32b0f59e8157","url":"https://api.github.com/users/cbreak-black","html_url":"https://github.com/cbreak-black","followers_url":"https://api.github.com/users/cbreak-black/followers","following_url":"https://api.github.com/users/cbreak-black/following{/other_user}","gists_url":"https://api.github.com/users/cbreak-black/gists{/gist_id}","starred_url":"https://api.github.com/users/cbreak-black/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbreak-black/subscriptions","organizations_url":"https://api.github.com/users/cbreak-black/orgs","repos_url":"https://api.github.com/users/cbreak-black/repos","events_url":"https://api.github.com/users/cbreak-black/events{/privacy}","received_events_url":"https://api.github.com/users/cbreak-black/received_events","type":"User","site_admin":false},"body":"Since unsigned integers can never be negative, some code can never be\r\nreached and can safely be removed as dead code.\r\n\r\nThe underlying function zvolIO_kit_read/zvolIO_kit_write is using IOMemoryDescriptor::writeBytes/IOMemoryDescriptor::readBytes respective, which also have an unsigned return value. It is also documented to never return a negative number.\r\n\r\nhttps://developer.apple.com/library/mac/documentation/Kernel/Reference/IOMemoryDescriptor_reference/translated_content/IOMemoryDescriptor.html#//apple_ref/cpp/instm/IOMemoryDescriptor/writeBytes/IOByteCount","created_at":"2014-04-13T16:21:26Z","updated_at":"2014-04-13T16:24:42Z","closed_at":"2014-04-13T16:24:42Z","merged_at":"2014-04-13T16:24:42Z","merge_commit_sha":"cfa16f7431efd43f08e71f79fd384dc58a92357a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openzfsonosx/zfs/pulls/145/commits","review_comments_url":"https://api.github.com/repos/openzfsonosx/zfs/pulls/145/comments","review_comment_url":"https://api.github.com/repos/openzfsonosx/zfs/pulls/comments/{number}","comments_url":"https://api.github.com/repos/openzfsonosx/zfs/issues/145/comments","statuses_url":"https://api.github.com/repos/openzfsonosx/zfs/statuses/4447ccdc4ca77eece5f002ff1bcfc024042c3af9","head":{"label":"cbreak-black:tautological","ref":"tautological","sha":"4447ccdc4ca77eece5f002ff1bcfc024042c3af9","user":{"login":"cbreak-black","id":227017,"avatar_url":"https://avatars.githubusercontent.com/u/227017?","gravatar_id":"c48d5d760df103803bdf32b0f59e8157","url":"https://api.github.com/users/cbreak-black","html_url":"https://github.com/cbreak-black","followers_url":"https://api.github.com/users/cbreak-black/followers","following_url":"https://api.github.com/users/cbreak-black/following{/other_user}","gists_url":"https://api.github.com/users/cbreak-black/gists{/gist_id}","starred_url":"https://api.github.com/users/cbreak-black/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbreak-black/subscriptions","organizations_url":"https://api.github.com/users/cbreak-black/orgs","repos_url":"https://api.github.com/users/cbreak-black/repos","events_url":"https://api.github.com/users/cbreak-black/events{/privacy}","received_events_url":"https://api.github.com/users/cbreak-black/received_events","type":"User","site_admin":false},"repo":{"id":18032273,"name":"zfs","full_name":"cbreak-black/zfs","owner":{"login":"cbreak-black","id":227017,"avatar_url":"https://avatars.githubusercontent.com/u/227017?","gravatar_id":"c48d5d760df103803bdf32b0f59e8157","url":"https://api.github.com/users/cbreak-black","html_url":"https://github.com/cbreak-black","followers_url":"https://api.github.com/users/cbreak-black/followers","following_url":"https://api.github.com/users/cbreak-black/following{/other_user}","gists_url":"https://api.github.com/users/cbreak-black/gists{/gist_id}","starred_url":"https://api.github.com/users/cbreak-black/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbreak-black/subscriptions","organizations_url":"https://api.github.com/users/cbreak-black/orgs","repos_url":"https://api.github.com/users/cbreak-black/repos","events_url":"https://api.github.com/users/cbreak-black/events{/privacy}","received_events_url":"https://api.github.com/users/cbreak-black/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cbreak-black/zfs","description":"ZFS for Apple OS X, beta testing.","fork":true,"url":"https://api.github.com/repos/cbreak-black/zfs","forks_url":"https://api.github.com/repos/cbreak-black/zfs/forks","keys_url":"https://api.github.com/repos/cbreak-black/zfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cbreak-black/zfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cbreak-black/zfs/teams","hooks_url":"https://api.github.com/repos/cbreak-black/zfs/hooks","issue_events_url":"https://api.github.com/repos/cbreak-black/zfs/issues/events{/number}","events_url":"https://api.github.com/repos/cbreak-black/zfs/events","assignees_url":"https://api.github.com/repos/cbreak-black/zfs/assignees{/user}","branches_url":"https://api.github.com/repos/cbreak-black/zfs/branches{/branch}","tags_url":"https://api.github.com/repos/cbreak-black/zfs/tags","blobs_url":"https://api.github.com/repos/cbreak-black/zfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cbreak-black/zfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cbreak-black/zfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/cbreak-black/zfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cbreak-black/zfs/statuses/{sha}","languages_url":"https://api.github.com/repos/cbreak-black/zfs/languages","stargazers_url":"https://api.github.com/repos/cbreak-black/zfs/stargazers","contributors_url":"https://api.github.com/repos/cbreak-black/zfs/contributors","subscribers_url":"https://api.github.com/repos/cbreak-black/zfs/subscribers","subscription_url":"https://api.github.com/repos/cbreak-black/zfs/subscription","commits_url":"https://api.github.com/repos/cbreak-black/zfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/cbreak-black/zfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/cbreak-black/zfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/cbreak-black/zfs/issues/comments/{number}","contents_url":"https://api.github.com/repos/cbreak-black/zfs/contents/{+path}","compare_url":"https://api.github.com/repos/cbreak-black/zfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cbreak-black/zfs/merges","archive_url":"https://api.github.com/repos/cbreak-black/zfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cbreak-black/zfs/downloads","issues_url":"https://api.github.com/repos/cbreak-black/zfs/issues{/number}","pulls_url":"https://api.github.com/repos/cbreak-black/zfs/pulls{/number}","milestones_url":"https://api.github.com/repos/cbreak-black/zfs/milestones{/number}","notifications_url":"https://api.github.com/repos/cbreak-black/zfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cbreak-black/zfs/labels{/name}","releases_url":"https://api.github.com/repos/cbreak-black/zfs/releases{/id}","created_at":"2014-03-23T11:56:13Z","updated_at":"2014-04-13T16:24:42Z","pushed_at":"2014-04-13T16:04:38Z","git_url":"git://github.com/cbreak-black/zfs.git","ssh_url":"git@github.com:cbreak-black/zfs.git","clone_url":"https://github.com/cbreak-black/zfs.git","svn_url":"https://github.com/cbreak-black/zfs","homepage":"","size":21637,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master","master_branch":"master"}},"base":{"label":"openzfsonosx:master","ref":"master","sha":"eda0927af2ae1c7b4ad87efc7e89743045dd529f","user":{"login":"openzfsonosx","id":6936109,"avatar_url":"https://avatars.githubusercontent.com/u/6936109?","gravatar_id":"e831b65fedff0d8b33659a9cfdd349e2","url":"https://api.github.com/users/openzfsonosx","html_url":"https://github.com/openzfsonosx","followers_url":"https://api.github.com/users/openzfsonosx/followers","following_url":"https://api.github.com/users/openzfsonosx/following{/other_user}","gists_url":"https://api.github.com/users/openzfsonosx/gists{/gist_id}","starred_url":"https://api.github.com/users/openzfsonosx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openzfsonosx/subscriptions","organizations_url":"https://api.github.com/users/openzfsonosx/orgs","repos_url":"https://api.github.com/users/openzfsonosx/repos","events_url":"https://api.github.com/users/openzfsonosx/events{/privacy}","received_events_url":"https://api.github.com/users/openzfsonosx/received_events","type":"Organization","site_admin":false},"repo":{"id":8347276,"name":"zfs","full_name":"openzfsonosx/zfs","owner":{"login":"openzfsonosx","id":6936109,"avatar_url":"https://avatars.githubusercontent.com/u/6936109?","gravatar_id":"e831b65fedff0d8b33659a9cfdd349e2","url":"https://api.github.com/users/openzfsonosx","html_url":"https://github.com/openzfsonosx","followers_url":"https://api.github.com/users/openzfsonosx/followers","following_url":"https://api.github.com/users/openzfsonosx/following{/other_user}","gists_url":"https://api.github.com/users/openzfsonosx/gists{/gist_id}","starred_url":"https://api.github.com/users/openzfsonosx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openzfsonosx/subscriptions","organizations_url":"https://api.github.com/users/openzfsonosx/orgs","repos_url":"https://api.github.com/users/openzfsonosx/repos","events_url":"https://api.github.com/users/openzfsonosx/events{/privacy}","received_events_url":"https://api.github.com/users/openzfsonosx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openzfsonosx/zfs","description":"OpenZFS on OS X","fork":false,"url":"https://api.github.com/repos/openzfsonosx/zfs","forks_url":"https://api.github.com/repos/openzfsonosx/zfs/forks","keys_url":"https://api.github.com/repos/openzfsonosx/zfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openzfsonosx/zfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openzfsonosx/zfs/teams","hooks_url":"https://api.github.com/repos/openzfsonosx/zfs/hooks","issue_events_url":"https://api.github.com/repos/openzfsonosx/zfs/issues/events{/number}","events_url":"https://api.github.com/repos/openzfsonosx/zfs/events","assignees_url":"https://api.github.com/repos/openzfsonosx/zfs/assignees{/user}","branches_url":"https://api.github.com/repos/openzfsonosx/zfs/branches{/branch}","tags_url":"https://api.github.com/repos/openzfsonosx/zfs/tags","blobs_url":"https://api.github.com/repos/openzfsonosx/zfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openzfsonosx/zfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openzfsonosx/zfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/openzfsonosx/zfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openzfsonosx/zfs/statuses/{sha}","languages_url":"https://api.github.com/repos/openzfsonosx/zfs/languages","stargazers_url":"https://api.github.com/repos/openzfsonosx/zfs/stargazers","contributors_url":"https://api.github.com/repos/openzfsonosx/zfs/contributors","subscribers_url":"https://api.github.com/repos/openzfsonosx/zfs/subscribers","subscription_url":"https://api.github.com/repos/openzfsonosx/zfs/subscription","commits_url":"https://api.github.com/repos/openzfsonosx/zfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/openzfsonosx/zfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/openzfsonosx/zfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/openzfsonosx/zfs/issues/comments/{number}","contents_url":"https://api.github.com/repos/openzfsonosx/zfs/contents/{+path}","compare_url":"https://api.github.com/repos/openzfsonosx/zfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openzfsonosx/zfs/merges","archive_url":"https://api.github.com/repos/openzfsonosx/zfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openzfsonosx/zfs/downloads","issues_url":"https://api.github.com/repos/openzfsonosx/zfs/issues{/number}","pulls_url":"https://api.github.com/repos/openzfsonosx/zfs/pulls{/number}","milestones_url":"https://api.github.com/repos/openzfsonosx/zfs/milestones{/number}","notifications_url":"https://api.github.com/repos/openzfsonosx/zfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openzfsonosx/zfs/labels{/name}","releases_url":"https://api.github.com/repos/openzfsonosx/zfs/releases{/id}","created_at":"2013-02-22T00:34:52Z","updated_at":"2014-04-13T16:24:42Z","pushed_at":"2014-04-13T16:24:42Z","git_url":"git://github.com/openzfsonosx/zfs.git","ssh_url":"git@github.com:openzfsonosx/zfs.git","clone_url":"https://github.com/openzfsonosx/zfs.git","svn_url":"https://github.com/openzfsonosx/zfs","homepage":"http://openzfsonosx.org/","size":26758,"stargazers_count":287,"watchers_count":287,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":23,"mirror_url":null,"open_issues_count":45,"forks":23,"open_issues":45,"watchers":287,"default_branch":"master","master_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openzfsonosx/zfs/pulls/145"},"html":{"href":"https://github.com/openzfsonosx/zfs/pull/145"},"issue":{"href":"https://api.github.com/repos/openzfsonosx/zfs/issues/145"},"comments":{"href":"https://api.github.com/repos/openzfsonosx/zfs/issues/145/comments"},"review_comments":{"href":"https://api.github.com/repos/openzfsonosx/zfs/pulls/145/comments"},"review_comment":{"href":"https://api.github.com/repos/openzfsonosx/zfs/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/openzfsonosx/zfs/pulls/145/commits"},"statuses":{"href":"https://api.github.com/repos/openzfsonosx/zfs/statuses/4447ccdc4ca77eece5f002ff1bcfc024042c3af9"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"ilovezfs","id":5268928,"avatar_url":"https://avatars.githubusercontent.com/u/5268928?","gravatar_id":"8dfa95a54b2cd3861dcee5f30816e851","url":"https://api.github.com/users/ilovezfs","html_url":"https://github.com/ilovezfs","followers_url":"https://api.github.com/users/ilovezfs/followers","following_url":"https://api.github.com/users/ilovezfs/following{/other_user}","gists_url":"https://api.github.com/users/ilovezfs/gists{/gist_id}","starred_url":"https://api.github.com/users/ilovezfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilovezfs/subscriptions","organizations_url":"https://api.github.com/users/ilovezfs/orgs","repos_url":"https://api.github.com/users/ilovezfs/repos","events_url":"https://api.github.com/users/ilovezfs/events{/privacy}","received_events_url":"https://api.github.com/users/ilovezfs/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":0,"deletions":10,"changed_files":1}}