GitHub PullRequestReviewCommentEvent at 2014-08-25 19:48:40
Repository: tachyon
Actor: rootfs
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/amplab/tachyon/pulls/comments/16676217","id":16676217,"diff_hunk":"@@ -65,15 +67,9 @@ private UnderFileSystemHdfs(String fsDefaultName, Object conf) {\n     } else {\n       tConf = new Configuration();\n     }\n-    tConf.set(\"fs.defaultFS\", fsDefaultName);\n-    String glusterfsPrefix = \"glusterfs:///\";\n-    if (fsDefaultName.startsWith(glusterfsPrefix)) {\n-      tConf.set(\"fs.glusterfs.impl\", CommonConf.get().UNDERFS_GLUSTERFS_IMPL);\n-      tConf.set(\"mapred.system.dir\", CommonConf.get().UNDERFS_GLUSTERFS_MR_DIR);\n-      tConf.set(\"fs.glusterfs.volumes\", CommonConf.get().UNDERFS_GLUSTERFS_VOLUMES);\n-      tConf.set(\"fs.glusterfs.volume.fuse.\" + CommonConf.get().UNDERFS_GLUSTERFS_VOLUMES,\n-          CommonConf.get().UNDERFS_GLUSTERFS_MOUNTS);\n-    } else {\n+   // tConf.set(\"fs.defaultFS\", fsDefaultName);","path":"core/src/main/java/tachyon/UnderFileSystemHdfs.java","position":22,"original_position":22,"commit_id":"8bcaa46686aea06836d518f84ca9dc27e39cf133","original_commit_id":"8bcaa46686aea06836d518f84ca9dc27e39cf133","user":{"login":"rootfs","id":7062400,"avatar_url":"https://avatars.githubusercontent.com/u/7062400?v=2","gravatar_id":"69e28607756a391ace4eb63296b4e3e2","url":"https://api.github.com/users/rootfs","html_url":"https://github.com/rootfs","followers_url":"https://api.github.com/users/rootfs/followers","following_url":"https://api.github.com/users/rootfs/following{/other_user}","gists_url":"https://api.github.com/users/rootfs/gists{/gist_id}","starred_url":"https://api.github.com/users/rootfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rootfs/subscriptions","organizations_url":"https://api.github.com/users/rootfs/orgs","repos_url":"https://api.github.com/users/rootfs/repos","events_url":"https://api.github.com/users/rootfs/events{/privacy}","received_events_url":"https://api.github.com/users/rootfs/received_events","type":"User","site_admin":false},"body":"cleaning up glusterfs specific uri looks good to me. @childsb there are some cleanup to do on the template and doc on glusterfs configuration. ","created_at":"2014-08-25T19:48:40Z","updated_at":"2014-08-25T19:48:40Z","html_url":"https://github.com/amplab/tachyon/pull/376#discussion_r16676217","pull_request_url":"https://api.github.com/repos/amplab/tachyon/pulls/376","_links":{"self":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/comments/16676217"},"html":{"href":"https://github.com/amplab/tachyon/pull/376#discussion_r16676217"},"pull_request":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/376"}}},"pull_request":{"url":"https://api.github.com/repos/amplab/tachyon/pulls/376","id":20116539,"html_url":"https://github.com/amplab/tachyon/pull/376","diff_url":"https://github.com/amplab/tachyon/pull/376.diff","patch_url":"https://github.com/amplab/tachyon/pull/376.patch","issue_url":"https://api.github.com/repos/amplab/tachyon/issues/376","number":376,"state":"open","locked":false,"title":"Fixes to enable latest glusterfs plugin w/tachyon.","user":{"login":"childsb","id":722782,"avatar_url":"https://avatars.githubusercontent.com/u/722782?v=2","gravatar_id":"65bd781d3a9cd9ca27f8d32d3fa4018e","url":"https://api.github.com/users/childsb","html_url":"https://github.com/childsb","followers_url":"https://api.github.com/users/childsb/followers","following_url":"https://api.github.com/users/childsb/following{/other_user}","gists_url":"https://api.github.com/users/childsb/gists{/gist_id}","starred_url":"https://api.github.com/users/childsb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/childsb/subscriptions","organizations_url":"https://api.github.com/users/childsb/orgs","repos_url":"https://api.github.com/users/childsb/repos","events_url":"https://api.github.com/users/childsb/events{/privacy}","received_events_url":"https://api.github.com/users/childsb/received_events","type":"User","site_admin":false},"body":"This patch includes changes for the latest glusterfs-hadoop plugin support and some fixes around URI handling/parsing.","created_at":"2014-08-21T15:21:10Z","updated_at":"2014-08-25T19:48:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"435704d3f7b3d4897c55644ac896434eb8c1a7ef","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/amplab/tachyon/pulls/376/commits","review_comments_url":"https://api.github.com/repos/amplab/tachyon/pulls/376/comments","review_comment_url":"https://api.github.com/repos/amplab/tachyon/pulls/comments/{number}","comments_url":"https://api.github.com/repos/amplab/tachyon/issues/376/comments","statuses_url":"https://api.github.com/repos/amplab/tachyon/statuses/8bcaa46686aea06836d518f84ca9dc27e39cf133","head":{"label":"childsb:gluster_fixes","ref":"gluster_fixes","sha":"8bcaa46686aea06836d518f84ca9dc27e39cf133","user":{"login":"childsb","id":722782,"avatar_url":"https://avatars.githubusercontent.com/u/722782?v=2","gravatar_id":"65bd781d3a9cd9ca27f8d32d3fa4018e","url":"https://api.github.com/users/childsb","html_url":"https://github.com/childsb","followers_url":"https://api.github.com/users/childsb/followers","following_url":"https://api.github.com/users/childsb/following{/other_user}","gists_url":"https://api.github.com/users/childsb/gists{/gist_id}","starred_url":"https://api.github.com/users/childsb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/childsb/subscriptions","organizations_url":"https://api.github.com/users/childsb/orgs","repos_url":"https://api.github.com/users/childsb/repos","events_url":"https://api.github.com/users/childsb/events{/privacy}","received_events_url":"https://api.github.com/users/childsb/received_events","type":"User","site_admin":false},"repo":{"id":21616974,"name":"tachyon","full_name":"childsb/tachyon","owner":{"login":"childsb","id":722782,"avatar_url":"https://avatars.githubusercontent.com/u/722782?v=2","gravatar_id":"65bd781d3a9cd9ca27f8d32d3fa4018e","url":"https://api.github.com/users/childsb","html_url":"https://github.com/childsb","followers_url":"https://api.github.com/users/childsb/followers","following_url":"https://api.github.com/users/childsb/following{/other_user}","gists_url":"https://api.github.com/users/childsb/gists{/gist_id}","starred_url":"https://api.github.com/users/childsb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/childsb/subscriptions","organizations_url":"https://api.github.com/users/childsb/orgs","repos_url":"https://api.github.com/users/childsb/repos","events_url":"https://api.github.com/users/childsb/events{/privacy}","received_events_url":"https://api.github.com/users/childsb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/childsb/tachyon","description":"Memory-centric Storage System for Big Data Analytics","fork":true,"url":"https://api.github.com/repos/childsb/tachyon","forks_url":"https://api.github.com/repos/childsb/tachyon/forks","keys_url":"https://api.github.com/repos/childsb/tachyon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/childsb/tachyon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/childsb/tachyon/teams","hooks_url":"https://api.github.com/repos/childsb/tachyon/hooks","issue_events_url":"https://api.github.com/repos/childsb/tachyon/issues/events{/number}","events_url":"https://api.github.com/repos/childsb/tachyon/events","assignees_url":"https://api.github.com/repos/childsb/tachyon/assignees{/user}","branches_url":"https://api.github.com/repos/childsb/tachyon/branches{/branch}","tags_url":"https://api.github.com/repos/childsb/tachyon/tags","blobs_url":"https://api.github.com/repos/childsb/tachyon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/childsb/tachyon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/childsb/tachyon/git/refs{/sha}","trees_url":"https://api.github.com/repos/childsb/tachyon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/childsb/tachyon/statuses/{sha}","languages_url":"https://api.github.com/repos/childsb/tachyon/languages","stargazers_url":"https://api.github.com/repos/childsb/tachyon/stargazers","contributors_url":"https://api.github.com/repos/childsb/tachyon/contributors","subscribers_url":"https://api.github.com/repos/childsb/tachyon/subscribers","subscription_url":"https://api.github.com/repos/childsb/tachyon/subscription","commits_url":"https://api.github.com/repos/childsb/tachyon/commits{/sha}","git_commits_url":"https://api.github.com/repos/childsb/tachyon/git/commits{/sha}","comments_url":"https://api.github.com/repos/childsb/tachyon/comments{/number}","issue_comment_url":"https://api.github.com/repos/childsb/tachyon/issues/comments/{number}","contents_url":"https://api.github.com/repos/childsb/tachyon/contents/{+path}","compare_url":"https://api.github.com/repos/childsb/tachyon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/childsb/tachyon/merges","archive_url":"https://api.github.com/repos/childsb/tachyon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/childsb/tachyon/downloads","issues_url":"https://api.github.com/repos/childsb/tachyon/issues{/number}","pulls_url":"https://api.github.com/repos/childsb/tachyon/pulls{/number}","milestones_url":"https://api.github.com/repos/childsb/tachyon/milestones{/number}","notifications_url":"https://api.github.com/repos/childsb/tachyon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/childsb/tachyon/labels{/name}","releases_url":"https://api.github.com/repos/childsb/tachyon/releases{/id}","created_at":"2014-07-08T14:58:37Z","updated_at":"2014-07-15T02:46:47Z","pushed_at":"2014-08-21T15:17:43Z","git_url":"git://github.com/childsb/tachyon.git","ssh_url":"git@github.com:childsb/tachyon.git","clone_url":"https://github.com/childsb/tachyon.git","svn_url":"https://github.com/childsb/tachyon","homepage":"http://tachyon-project.org","size":6690,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"amplab:master","ref":"master","sha":"8e6d6dc8dbeb0338e8edb06f9a77c320caee6e6d","user":{"login":"amplab","id":1438454,"avatar_url":"https://avatars.githubusercontent.com/u/1438454?v=2","gravatar_id":"c0783723b006eb46526c04fa47ba2cd7","url":"https://api.github.com/users/amplab","html_url":"https://github.com/amplab","followers_url":"https://api.github.com/users/amplab/followers","following_url":"https://api.github.com/users/amplab/following{/other_user}","gists_url":"https://api.github.com/users/amplab/gists{/gist_id}","starred_url":"https://api.github.com/users/amplab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amplab/subscriptions","organizations_url":"https://api.github.com/users/amplab/orgs","repos_url":"https://api.github.com/users/amplab/repos","events_url":"https://api.github.com/users/amplab/events{/privacy}","received_events_url":"https://api.github.com/users/amplab/received_events","type":"Organization","site_admin":false},"repo":{"id":7276954,"name":"tachyon","full_name":"amplab/tachyon","owner":{"login":"amplab","id":1438454,"avatar_url":"https://avatars.githubusercontent.com/u/1438454?v=2","gravatar_id":"c0783723b006eb46526c04fa47ba2cd7","url":"https://api.github.com/users/amplab","html_url":"https://github.com/amplab","followers_url":"https://api.github.com/users/amplab/followers","following_url":"https://api.github.com/users/amplab/following{/other_user}","gists_url":"https://api.github.com/users/amplab/gists{/gist_id}","starred_url":"https://api.github.com/users/amplab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amplab/subscriptions","organizations_url":"https://api.github.com/users/amplab/orgs","repos_url":"https://api.github.com/users/amplab/repos","events_url":"https://api.github.com/users/amplab/events{/privacy}","received_events_url":"https://api.github.com/users/amplab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/amplab/tachyon","description":" A Reliable Memory Centric Distributed Storage System","fork":false,"url":"https://api.github.com/repos/amplab/tachyon","forks_url":"https://api.github.com/repos/amplab/tachyon/forks","keys_url":"https://api.github.com/repos/amplab/tachyon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amplab/tachyon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amplab/tachyon/teams","hooks_url":"https://api.github.com/repos/amplab/tachyon/hooks","issue_events_url":"https://api.github.com/repos/amplab/tachyon/issues/events{/number}","events_url":"https://api.github.com/repos/amplab/tachyon/events","assignees_url":"https://api.github.com/repos/amplab/tachyon/assignees{/user}","branches_url":"https://api.github.com/repos/amplab/tachyon/branches{/branch}","tags_url":"https://api.github.com/repos/amplab/tachyon/tags","blobs_url":"https://api.github.com/repos/amplab/tachyon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amplab/tachyon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amplab/tachyon/git/refs{/sha}","trees_url":"https://api.github.com/repos/amplab/tachyon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amplab/tachyon/statuses/{sha}","languages_url":"https://api.github.com/repos/amplab/tachyon/languages","stargazers_url":"https://api.github.com/repos/amplab/tachyon/stargazers","contributors_url":"https://api.github.com/repos/amplab/tachyon/contributors","subscribers_url":"https://api.github.com/repos/amplab/tachyon/subscribers","subscription_url":"https://api.github.com/repos/amplab/tachyon/subscription","commits_url":"https://api.github.com/repos/amplab/tachyon/commits{/sha}","git_commits_url":"https://api.github.com/repos/amplab/tachyon/git/commits{/sha}","comments_url":"https://api.github.com/repos/amplab/tachyon/comments{/number}","issue_comment_url":"https://api.github.com/repos/amplab/tachyon/issues/comments/{number}","contents_url":"https://api.github.com/repos/amplab/tachyon/contents/{+path}","compare_url":"https://api.github.com/repos/amplab/tachyon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amplab/tachyon/merges","archive_url":"https://api.github.com/repos/amplab/tachyon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amplab/tachyon/downloads","issues_url":"https://api.github.com/repos/amplab/tachyon/issues{/number}","pulls_url":"https://api.github.com/repos/amplab/tachyon/pulls{/number}","milestones_url":"https://api.github.com/repos/amplab/tachyon/milestones{/number}","notifications_url":"https://api.github.com/repos/amplab/tachyon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amplab/tachyon/labels{/name}","releases_url":"https://api.github.com/repos/amplab/tachyon/releases{/id}","created_at":"2012-12-21T17:43:46Z","updated_at":"2014-08-25T11:03:55Z","pushed_at":"2014-08-25T01:16:26Z","git_url":"git://github.com/amplab/tachyon.git","ssh_url":"git@github.com:amplab/tachyon.git","clone_url":"https://github.com/amplab/tachyon.git","svn_url":"https://github.com/amplab/tachyon","homepage":"http://tachyon-project.org","size":27668,"stargazers_count":906,"watchers_count":906,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":251,"mirror_url":null,"open_issues_count":23,"forks":251,"open_issues":23,"watchers":906,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/376"},"html":{"href":"https://github.com/amplab/tachyon/pull/376"},"issue":{"href":"https://api.github.com/repos/amplab/tachyon/issues/376"},"comments":{"href":"https://api.github.com/repos/amplab/tachyon/issues/376/comments"},"review_comments":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/376/comments"},"review_comment":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/376/commits"},"statuses":{"href":"https://api.github.com/repos/amplab/tachyon/statuses/8bcaa46686aea06836d518f84ca9dc27e39cf133"}}}}