GitHub PullRequestReviewCommentEvent at 2014-12-22 10:56:05
Repository: zf2
Actor: samsonasik
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/zendframework/zf2/pulls/comments/22161845","id":22161845,"diff_hunk":"@@ -121,4 +122,54 @@ public function testElementWithBothAttributesAndAStringValueIsProcessedCorrectly\n         $this->assertArrayHasKey('_', $arrayXml['one'][1]);\n         $this->assertEquals('bazbat', $arrayXml['one'][1]['_']);\n     }\n+\n+    /**\n+     * @group 6761\n+     * @group 6730\n+     */\n+    public function testCloseWhenCallFromFileReaderGetInvalid()\n+    {\n+        $configReader = new Xml();\n+        $configReader->getReader()->open($this->getTestAssetPath('attributes'));\n+        $configReader->getReader()->setParserProperty(XMLReader::VALIDATE, true);\n+        $this->assertTrue($configReader->getReader()->isValid());\n+\n+        $configReader->fromFile($this->getTestAssetPath('attributes'));\n+        $this->setExpectedException('PHPUnit_Framework_Error_Warning');","path":"tests/ZendTest/Config/Reader/XmlTest.php","position":25,"original_position":25,"commit_id":"d52d337c5fb9bd24cb59cc15a21c13a7077b2ef4","original_commit_id":"907b5fc4ef9145ff3747b444f1915768f3c34b14","user":{"login":"samsonasik","id":459648,"avatar_url":"https://avatars.githubusercontent.com/u/459648?v=3","gravatar_id":"","url":"https://api.github.com/users/samsonasik","html_url":"https://github.com/samsonasik","followers_url":"https://api.github.com/users/samsonasik/followers","following_url":"https://api.github.com/users/samsonasik/following{/other_user}","gists_url":"https://api.github.com/users/samsonasik/gists{/gist_id}","starred_url":"https://api.github.com/users/samsonasik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samsonasik/subscriptions","organizations_url":"https://api.github.com/users/samsonasik/orgs","repos_url":"https://api.github.com/users/samsonasik/repos","events_url":"https://api.github.com/users/samsonasik/events{/privacy}","received_events_url":"https://api.github.com/users/samsonasik/received_events","type":"User","site_admin":false},"body":"because after close(), the reader can't be validated, no ?","created_at":"2014-12-22T10:56:05Z","updated_at":"2014-12-22T10:56:05Z","html_url":"https://github.com/zendframework/zf2/pull/6761#discussion_r22161845","pull_request_url":"https://api.github.com/repos/zendframework/zf2/pulls/6761","_links":{"self":{"href":"https://api.github.com/repos/zendframework/zf2/pulls/comments/22161845"},"html":{"href":"https://github.com/zendframework/zf2/pull/6761#discussion_r22161845"},"pull_request":{"href":"https://api.github.com/repos/zendframework/zf2/pulls/6761"}}},"pull_request":{"url":"https://api.github.com/repos/zendframework/zf2/pulls/6761","id":22693703,"html_url":"https://github.com/zendframework/zf2/pull/6761","diff_url":"https://github.com/zendframework/zf2/pull/6761.diff","patch_url":"https://github.com/zendframework/zf2/pull/6761.patch","issue_url":"https://api.github.com/repos/zendframework/zf2/issues/6761","number":6761,"state":"open","locked":false,"title":"Fixes #6730 : close() xml reader on fromFile() and fromString()","user":{"login":"samsonasik","id":459648,"avatar_url":"https://avatars.githubusercontent.com/u/459648?v=3","gravatar_id":"","url":"https://api.github.com/users/samsonasik","html_url":"https://github.com/samsonasik","followers_url":"https://api.github.com/users/samsonasik/followers","following_url":"https://api.github.com/users/samsonasik/following{/other_user}","gists_url":"https://api.github.com/users/samsonasik/gists{/gist_id}","starred_url":"https://api.github.com/users/samsonasik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samsonasik/subscriptions","organizations_url":"https://api.github.com/users/samsonasik/orgs","repos_url":"https://api.github.com/users/samsonasik/repos","events_url":"https://api.github.com/users/samsonasik/events{/privacy}","received_events_url":"https://api.github.com/users/samsonasik/received_events","type":"User","site_admin":false},"body":"Fixes #6730","created_at":"2014-10-14T07:59:27Z","updated_at":"2014-12-22T10:56:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e5cc4e9419ef6fc6362bdab9c7c0fa1df14df9d7","assignee":{"login":"Ocramius","id":154256,"avatar_url":"https://avatars.githubusercontent.com/u/154256?v=3","gravatar_id":"","url":"https://api.github.com/users/Ocramius","html_url":"https://github.com/Ocramius","followers_url":"https://api.github.com/users/Ocramius/followers","following_url":"https://api.github.com/users/Ocramius/following{/other_user}","gists_url":"https://api.github.com/users/Ocramius/gists{/gist_id}","starred_url":"https://api.github.com/users/Ocramius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ocramius/subscriptions","organizations_url":"https://api.github.com/users/Ocramius/orgs","repos_url":"https://api.github.com/users/Ocramius/repos","events_url":"https://api.github.com/users/Ocramius/events{/privacy}","received_events_url":"https://api.github.com/users/Ocramius/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/zendframework/zf2/milestones/30","labels_url":"https://api.github.com/repos/zendframework/zf2/milestones/30/labels","id":801637,"number":30,"title":"2.3.4","description":"","creator":{"login":"Ocramius","id":154256,"avatar_url":"https://avatars.githubusercontent.com/u/154256?v=3","gravatar_id":"","url":"https://api.github.com/users/Ocramius","html_url":"https://github.com/Ocramius","followers_url":"https://api.github.com/users/Ocramius/followers","following_url":"https://api.github.com/users/Ocramius/following{/other_user}","gists_url":"https://api.github.com/users/Ocramius/gists{/gist_id}","starred_url":"https://api.github.com/users/Ocramius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ocramius/subscriptions","organizations_url":"https://api.github.com/users/Ocramius/orgs","repos_url":"https://api.github.com/users/Ocramius/repos","events_url":"https://api.github.com/users/Ocramius/events{/privacy}","received_events_url":"https://api.github.com/users/Ocramius/received_events","type":"User","site_admin":false},"open_issues":14,"closed_issues":164,"state":"open","created_at":"2014-09-24T19:35:29Z","updated_at":"2014-12-22T10:47:28Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/zendframework/zf2/pulls/6761/commits","review_comments_url":"https://api.github.com/repos/zendframework/zf2/pulls/6761/comments","review_comment_url":"https://api.github.com/repos/zendframework/zf2/pulls/comments/{number}","comments_url":"https://api.github.com/repos/zendframework/zf2/issues/6761/comments","statuses_url":"https://api.github.com/repos/zendframework/zf2/statuses/d52d337c5fb9bd24cb59cc15a21c13a7077b2ef4","head":{"label":"samsonasik:hotfix/xml-close","ref":"hotfix/xml-close","sha":"d52d337c5fb9bd24cb59cc15a21c13a7077b2ef4","user":{"login":"samsonasik","id":459648,"avatar_url":"https://avatars.githubusercontent.com/u/459648?v=3","gravatar_id":"","url":"https://api.github.com/users/samsonasik","html_url":"https://github.com/samsonasik","followers_url":"https://api.github.com/users/samsonasik/followers","following_url":"https://api.github.com/users/samsonasik/following{/other_user}","gists_url":"https://api.github.com/users/samsonasik/gists{/gist_id}","starred_url":"https://api.github.com/users/samsonasik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samsonasik/subscriptions","organizations_url":"https://api.github.com/users/samsonasik/orgs","repos_url":"https://api.github.com/users/samsonasik/repos","events_url":"https://api.github.com/users/samsonasik/events{/privacy}","received_events_url":"https://api.github.com/users/samsonasik/received_events","type":"User","site_admin":false},"repo":{"id":5946915,"name":"zf2","full_name":"samsonasik/zf2","owner":{"login":"samsonasik","id":459648,"avatar_url":"https://avatars.githubusercontent.com/u/459648?v=3","gravatar_id":"","url":"https://api.github.com/users/samsonasik","html_url":"https://github.com/samsonasik","followers_url":"https://api.github.com/users/samsonasik/followers","following_url":"https://api.github.com/users/samsonasik/following{/other_user}","gists_url":"https://api.github.com/users/samsonasik/gists{/gist_id}","starred_url":"https://api.github.com/users/samsonasik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samsonasik/subscriptions","organizations_url":"https://api.github.com/users/samsonasik/orgs","repos_url":"https://api.github.com/users/samsonasik/repos","events_url":"https://api.github.com/users/samsonasik/events{/privacy}","received_events_url":"https://api.github.com/users/samsonasik/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/samsonasik/zf2","description":"Official Zend Framework 2.0 git repository","fork":true,"url":"https://api.github.com/repos/samsonasik/zf2","forks_url":"https://api.github.com/repos/samsonasik/zf2/forks","keys_url":"https://api.github.com/repos/samsonasik/zf2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/samsonasik/zf2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/samsonasik/zf2/teams","hooks_url":"https://api.github.com/repos/samsonasik/zf2/hooks","issue_events_url":"https://api.github.com/repos/samsonasik/zf2/issues/events{/number}","events_url":"https://api.github.com/repos/samsonasik/zf2/events","assignees_url":"https://api.github.com/repos/samsonasik/zf2/assignees{/user}","branches_url":"https://api.github.com/repos/samsonasik/zf2/branches{/branch}","tags_url":"https://api.github.com/repos/samsonasik/zf2/tags","blobs_url":"https://api.github.com/repos/samsonasik/zf2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/samsonasik/zf2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/samsonasik/zf2/git/refs{/sha}","trees_url":"https://api.github.com/repos/samsonasik/zf2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/samsonasik/zf2/statuses/{sha}","languages_url":"https://api.github.com/repos/samsonasik/zf2/languages","stargazers_url":"https://api.github.com/repos/samsonasik/zf2/stargazers","contributors_url":"https://api.github.com/repos/samsonasik/zf2/contributors","subscribers_url":"https://api.github.com/repos/samsonasik/zf2/subscribers","subscription_url":"https://api.github.com/repos/samsonasik/zf2/subscription","commits_url":"https://api.github.com/repos/samsonasik/zf2/commits{/sha}","git_commits_url":"https://api.github.com/repos/samsonasik/zf2/git/commits{/sha}","comments_url":"https://api.github.com/repos/samsonasik/zf2/comments{/number}","issue_comment_url":"https://api.github.com/repos/samsonasik/zf2/issues/comments/{number}","contents_url":"https://api.github.com/repos/samsonasik/zf2/contents/{+path}","compare_url":"https://api.github.com/repos/samsonasik/zf2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/samsonasik/zf2/merges","archive_url":"https://api.github.com/repos/samsonasik/zf2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/samsonasik/zf2/downloads","issues_url":"https://api.github.com/repos/samsonasik/zf2/issues{/number}","pulls_url":"https://api.github.com/repos/samsonasik/zf2/pulls{/number}","milestones_url":"https://api.github.com/repos/samsonasik/zf2/milestones{/number}","notifications_url":"https://api.github.com/repos/samsonasik/zf2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/samsonasik/zf2/labels{/name}","releases_url":"https://api.github.com/repos/samsonasik/zf2/releases{/id}","created_at":"2012-09-25T08:19:09Z","updated_at":"2014-12-13T21:54:40Z","pushed_at":"2014-12-22T10:49:25Z","git_url":"git://github.com/samsonasik/zf2.git","ssh_url":"git@github.com:samsonasik/zf2.git","clone_url":"https://github.com/samsonasik/zf2.git","svn_url":"https://github.com/samsonasik/zf2","homepage":"http://framework.zend.com/zf2","size":96087,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zendframework:master","ref":"master","sha":"27bb93c39607b0cede1b4955747d01dc81a6091c","user":{"login":"zendframework","id":296074,"avatar_url":"https://avatars.githubusercontent.com/u/296074?v=3","gravatar_id":"","url":"https://api.github.com/users/zendframework","html_url":"https://github.com/zendframework","followers_url":"https://api.github.com/users/zendframework/followers","following_url":"https://api.github.com/users/zendframework/following{/other_user}","gists_url":"https://api.github.com/users/zendframework/gists{/gist_id}","starred_url":"https://api.github.com/users/zendframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendframework/subscriptions","organizations_url":"https://api.github.com/users/zendframework/orgs","repos_url":"https://api.github.com/users/zendframework/repos","events_url":"https://api.github.com/users/zendframework/events{/privacy}","received_events_url":"https://api.github.com/users/zendframework/received_events","type":"Organization","site_admin":false},"repo":{"id":702550,"name":"zf2","full_name":"zendframework/zf2","owner":{"login":"zendframework","id":296074,"avatar_url":"https://avatars.githubusercontent.com/u/296074?v=3","gravatar_id":"","url":"https://api.github.com/users/zendframework","html_url":"https://github.com/zendframework","followers_url":"https://api.github.com/users/zendframework/followers","following_url":"https://api.github.com/users/zendframework/following{/other_user}","gists_url":"https://api.github.com/users/zendframework/gists{/gist_id}","starred_url":"https://api.github.com/users/zendframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendframework/subscriptions","organizations_url":"https://api.github.com/users/zendframework/orgs","repos_url":"https://api.github.com/users/zendframework/repos","events_url":"https://api.github.com/users/zendframework/events{/privacy}","received_events_url":"https://api.github.com/users/zendframework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zendframework/zf2","description":"Official Zend Framework 2 git repository","fork":false,"url":"https://api.github.com/repos/zendframework/zf2","forks_url":"https://api.github.com/repos/zendframework/zf2/forks","keys_url":"https://api.github.com/repos/zendframework/zf2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zendframework/zf2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zendframework/zf2/teams","hooks_url":"https://api.github.com/repos/zendframework/zf2/hooks","issue_events_url":"https://api.github.com/repos/zendframework/zf2/issues/events{/number}","events_url":"https://api.github.com/repos/zendframework/zf2/events","assignees_url":"https://api.github.com/repos/zendframework/zf2/assignees{/user}","branches_url":"https://api.github.com/repos/zendframework/zf2/branches{/branch}","tags_url":"https://api.github.com/repos/zendframework/zf2/tags","blobs_url":"https://api.github.com/repos/zendframework/zf2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zendframework/zf2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zendframework/zf2/git/refs{/sha}","trees_url":"https://api.github.com/repos/zendframework/zf2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zendframework/zf2/statuses/{sha}","languages_url":"https://api.github.com/repos/zendframework/zf2/languages","stargazers_url":"https://api.github.com/repos/zendframework/zf2/stargazers","contributors_url":"https://api.github.com/repos/zendframework/zf2/contributors","subscribers_url":"https://api.github.com/repos/zendframework/zf2/subscribers","subscription_url":"https://api.github.com/repos/zendframework/zf2/subscription","commits_url":"https://api.github.com/repos/zendframework/zf2/commits{/sha}","git_commits_url":"https://api.github.com/repos/zendframework/zf2/git/commits{/sha}","comments_url":"https://api.github.com/repos/zendframework/zf2/comments{/number}","issue_comment_url":"https://api.github.com/repos/zendframework/zf2/issues/comments/{number}","contents_url":"https://api.github.com/repos/zendframework/zf2/contents/{+path}","compare_url":"https://api.github.com/repos/zendframework/zf2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zendframework/zf2/merges","archive_url":"https://api.github.com/repos/zendframework/zf2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zendframework/zf2/downloads","issues_url":"https://api.github.com/repos/zendframework/zf2/issues{/number}","pulls_url":"https://api.github.com/repos/zendframework/zf2/pulls{/number}","milestones_url":"https://api.github.com/repos/zendframework/zf2/milestones{/number}","notifications_url":"https://api.github.com/repos/zendframework/zf2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zendframework/zf2/labels{/name}","releases_url":"https://api.github.com/repos/zendframework/zf2/releases{/id}","created_at":"2010-06-04T02:42:05Z","updated_at":"2014-12-21T14:39:57Z","pushed_at":"2014-12-17T12:49:55Z","git_url":"git://github.com/zendframework/zf2.git","ssh_url":"git@github.com:zendframework/zf2.git","clone_url":"https://github.com/zendframework/zf2.git","svn_url":"https://github.com/zendframework/zf2","homepage":"http://framework.zend.com/","size":212876,"stargazers_count":4959,"watchers_count":4959,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3011,"mirror_url":null,"open_issues_count":624,"forks":3011,"open_issues":624,"watchers":4959,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zendframework/zf2/pulls/6761"},"html":{"href":"https://github.com/zendframework/zf2/pull/6761"},"issue":{"href":"https://api.github.com/repos/zendframework/zf2/issues/6761"},"comments":{"href":"https://api.github.com/repos/zendframework/zf2/issues/6761/comments"},"review_comments":{"href":"https://api.github.com/repos/zendframework/zf2/pulls/6761/comments"},"review_comment":{"href":"https://api.github.com/repos/zendframework/zf2/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/zendframework/zf2/pulls/6761/commits"},"statuses":{"href":"https://api.github.com/repos/zendframework/zf2/statuses/d52d337c5fb9bd24cb59cc15a21c13a7077b2ef4"}}}}