GitHub PullRequestEvent at 2014-10-03 17:19:44
Repository: doaj
Actor: Steven-Eardley
Payload: {"action":"opened","number":336,"pull_request":{"url":"https://api.github.com/repos/DOAJ/doaj/pulls/336","id":22216726,"html_url":"https://github.com/DOAJ/doaj/pull/336","diff_url":"https://github.com/DOAJ/doaj/pull/336.diff","patch_url":"https://github.com/DOAJ/doaj/pull/336.patch","issue_url":"https://api.github.com/repos/DOAJ/doaj/issues/336","number":336,"state":"open","locked":false,"title":"315 csv wrapper","user":{"login":"Steven-Eardley","id":1446355,"avatar_url":"https://avatars.githubusercontent.com/u/1446355?v=2","gravatar_id":"","url":"https://api.github.com/users/Steven-Eardley","html_url":"https://github.com/Steven-Eardley","followers_url":"https://api.github.com/users/Steven-Eardley/followers","following_url":"https://api.github.com/users/Steven-Eardley/following{/other_user}","gists_url":"https://api.github.com/users/Steven-Eardley/gists{/gist_id}","starred_url":"https://api.github.com/users/Steven-Eardley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Steven-Eardley/subscriptions","organizations_url":"https://api.github.com/users/Steven-Eardley/orgs","repos_url":"https://api.github.com/users/Steven-Eardley/repos","events_url":"https://api.github.com/users/Steven-Eardley/events{/privacy}","received_events_url":"https://api.github.com/users/Steven-Eardley/received_events","type":"User","site_admin":false},"body":"Issue #315 - This works fine, but I feel that it might be better to not expose the file mode, and let the underlying ClCsv class handle it all. This is because it is very sensitive to which mode it is in.\r\n\r\nFor example, for updating a column in the CSV (see b_test_write_02), it *must* use mode ```'r+b'```, because it first needs to read the current data, then write to the file. It just may not be clear as could be desired which mode should be chosen. In fact, ```'r+b'``` should be used in almost all cases since anything with ```w``` in it will erase the current data in the file.","created_at":"2014-10-03T17:19:44Z","updated_at":"2014-10-03T17:19:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/DOAJ/doaj/pulls/336/commits","review_comments_url":"https://api.github.com/repos/DOAJ/doaj/pulls/336/comments","review_comment_url":"https://api.github.com/repos/DOAJ/doaj/pulls/comments/{number}","comments_url":"https://api.github.com/repos/DOAJ/doaj/issues/336/comments","statuses_url":"https://api.github.com/repos/DOAJ/doaj/statuses/7855805f78204540937631e42783fc006d183bde","head":{"label":"DOAJ:315_csv_wrapper","ref":"315_csv_wrapper","sha":"7855805f78204540937631e42783fc006d183bde","user":{"login":"DOAJ","id":5971926,"avatar_url":"https://avatars.githubusercontent.com/u/5971926?v=2","gravatar_id":"","url":"https://api.github.com/users/DOAJ","html_url":"https://github.com/DOAJ","followers_url":"https://api.github.com/users/DOAJ/followers","following_url":"https://api.github.com/users/DOAJ/following{/other_user}","gists_url":"https://api.github.com/users/DOAJ/gists{/gist_id}","starred_url":"https://api.github.com/users/DOAJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DOAJ/subscriptions","organizations_url":"https://api.github.com/users/DOAJ/orgs","repos_url":"https://api.github.com/users/DOAJ/repos","events_url":"https://api.github.com/users/DOAJ/events{/privacy}","received_events_url":"https://api.github.com/users/DOAJ/received_events","type":"Organization","site_admin":false},"repo":{"id":14500626,"name":"doaj","full_name":"DOAJ/doaj","owner":{"login":"DOAJ","id":5971926,"avatar_url":"https://avatars.githubusercontent.com/u/5971926?v=2","gravatar_id":"","url":"https://api.github.com/users/DOAJ","html_url":"https://github.com/DOAJ","followers_url":"https://api.github.com/users/DOAJ/followers","following_url":"https://api.github.com/users/DOAJ/following{/other_user}","gists_url":"https://api.github.com/users/DOAJ/gists{/gist_id}","starred_url":"https://api.github.com/users/DOAJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DOAJ/subscriptions","organizations_url":"https://api.github.com/users/DOAJ/orgs","repos_url":"https://api.github.com/users/DOAJ/repos","events_url":"https://api.github.com/users/DOAJ/events{/privacy}","received_events_url":"https://api.github.com/users/DOAJ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DOAJ/doaj","description":"The Directory of Open Access Journals - website and directory software","fork":false,"url":"https://api.github.com/repos/DOAJ/doaj","forks_url":"https://api.github.com/repos/DOAJ/doaj/forks","keys_url":"https://api.github.com/repos/DOAJ/doaj/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DOAJ/doaj/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DOAJ/doaj/teams","hooks_url":"https://api.github.com/repos/DOAJ/doaj/hooks","issue_events_url":"https://api.github.com/repos/DOAJ/doaj/issues/events{/number}","events_url":"https://api.github.com/repos/DOAJ/doaj/events","assignees_url":"https://api.github.com/repos/DOAJ/doaj/assignees{/user}","branches_url":"https://api.github.com/repos/DOAJ/doaj/branches{/branch}","tags_url":"https://api.github.com/repos/DOAJ/doaj/tags","blobs_url":"https://api.github.com/repos/DOAJ/doaj/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DOAJ/doaj/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DOAJ/doaj/git/refs{/sha}","trees_url":"https://api.github.com/repos/DOAJ/doaj/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DOAJ/doaj/statuses/{sha}","languages_url":"https://api.github.com/repos/DOAJ/doaj/languages","stargazers_url":"https://api.github.com/repos/DOAJ/doaj/stargazers","contributors_url":"https://api.github.com/repos/DOAJ/doaj/contributors","subscribers_url":"https://api.github.com/repos/DOAJ/doaj/subscribers","subscription_url":"https://api.github.com/repos/DOAJ/doaj/subscription","commits_url":"https://api.github.com/repos/DOAJ/doaj/commits{/sha}","git_commits_url":"https://api.github.com/repos/DOAJ/doaj/git/commits{/sha}","comments_url":"https://api.github.com/repos/DOAJ/doaj/comments{/number}","issue_comment_url":"https://api.github.com/repos/DOAJ/doaj/issues/comments/{number}","contents_url":"https://api.github.com/repos/DOAJ/doaj/contents/{+path}","compare_url":"https://api.github.com/repos/DOAJ/doaj/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DOAJ/doaj/merges","archive_url":"https://api.github.com/repos/DOAJ/doaj/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DOAJ/doaj/downloads","issues_url":"https://api.github.com/repos/DOAJ/doaj/issues{/number}","pulls_url":"https://api.github.com/repos/DOAJ/doaj/pulls{/number}","milestones_url":"https://api.github.com/repos/DOAJ/doaj/milestones{/number}","notifications_url":"https://api.github.com/repos/DOAJ/doaj/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DOAJ/doaj/labels{/name}","releases_url":"https://api.github.com/repos/DOAJ/doaj/releases{/id}","created_at":"2013-11-18T18:07:31Z","updated_at":"2014-09-09T01:27:25Z","pushed_at":"2014-10-03T17:11:19Z","git_url":"git://github.com/DOAJ/doaj.git","ssh_url":"git@github.com:DOAJ/doaj.git","clone_url":"https://github.com/DOAJ/doaj.git","svn_url":"https://github.com/DOAJ/doaj","homepage":null,"size":9518,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":87,"forks":1,"open_issues":87,"watchers":2,"default_branch":"develop"}},"base":{"label":"DOAJ:develop","ref":"develop","sha":"7c2ca3985deb6491695e2d94befb30652186407b","user":{"login":"DOAJ","id":5971926,"avatar_url":"https://avatars.githubusercontent.com/u/5971926?v=2","gravatar_id":"","url":"https://api.github.com/users/DOAJ","html_url":"https://github.com/DOAJ","followers_url":"https://api.github.com/users/DOAJ/followers","following_url":"https://api.github.com/users/DOAJ/following{/other_user}","gists_url":"https://api.github.com/users/DOAJ/gists{/gist_id}","starred_url":"https://api.github.com/users/DOAJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DOAJ/subscriptions","organizations_url":"https://api.github.com/users/DOAJ/orgs","repos_url":"https://api.github.com/users/DOAJ/repos","events_url":"https://api.github.com/users/DOAJ/events{/privacy}","received_events_url":"https://api.github.com/users/DOAJ/received_events","type":"Organization","site_admin":false},"repo":{"id":14500626,"name":"doaj","full_name":"DOAJ/doaj","owner":{"login":"DOAJ","id":5971926,"avatar_url":"https://avatars.githubusercontent.com/u/5971926?v=2","gravatar_id":"","url":"https://api.github.com/users/DOAJ","html_url":"https://github.com/DOAJ","followers_url":"https://api.github.com/users/DOAJ/followers","following_url":"https://api.github.com/users/DOAJ/following{/other_user}","gists_url":"https://api.github.com/users/DOAJ/gists{/gist_id}","starred_url":"https://api.github.com/users/DOAJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DOAJ/subscriptions","organizations_url":"https://api.github.com/users/DOAJ/orgs","repos_url":"https://api.github.com/users/DOAJ/repos","events_url":"https://api.github.com/users/DOAJ/events{/privacy}","received_events_url":"https://api.github.com/users/DOAJ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DOAJ/doaj","description":"The Directory of Open Access Journals - website and directory software","fork":false,"url":"https://api.github.com/repos/DOAJ/doaj","forks_url":"https://api.github.com/repos/DOAJ/doaj/forks","keys_url":"https://api.github.com/repos/DOAJ/doaj/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DOAJ/doaj/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DOAJ/doaj/teams","hooks_url":"https://api.github.com/repos/DOAJ/doaj/hooks","issue_events_url":"https://api.github.com/repos/DOAJ/doaj/issues/events{/number}","events_url":"https://api.github.com/repos/DOAJ/doaj/events","assignees_url":"https://api.github.com/repos/DOAJ/doaj/assignees{/user}","branches_url":"https://api.github.com/repos/DOAJ/doaj/branches{/branch}","tags_url":"https://api.github.com/repos/DOAJ/doaj/tags","blobs_url":"https://api.github.com/repos/DOAJ/doaj/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DOAJ/doaj/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DOAJ/doaj/git/refs{/sha}","trees_url":"https://api.github.com/repos/DOAJ/doaj/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DOAJ/doaj/statuses/{sha}","languages_url":"https://api.github.com/repos/DOAJ/doaj/languages","stargazers_url":"https://api.github.com/repos/DOAJ/doaj/stargazers","contributors_url":"https://api.github.com/repos/DOAJ/doaj/contributors","subscribers_url":"https://api.github.com/repos/DOAJ/doaj/subscribers","subscription_url":"https://api.github.com/repos/DOAJ/doaj/subscription","commits_url":"https://api.github.com/repos/DOAJ/doaj/commits{/sha}","git_commits_url":"https://api.github.com/repos/DOAJ/doaj/git/commits{/sha}","comments_url":"https://api.github.com/repos/DOAJ/doaj/comments{/number}","issue_comment_url":"https://api.github.com/repos/DOAJ/doaj/issues/comments/{number}","contents_url":"https://api.github.com/repos/DOAJ/doaj/contents/{+path}","compare_url":"https://api.github.com/repos/DOAJ/doaj/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DOAJ/doaj/merges","archive_url":"https://api.github.com/repos/DOAJ/doaj/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DOAJ/doaj/downloads","issues_url":"https://api.github.com/repos/DOAJ/doaj/issues{/number}","pulls_url":"https://api.github.com/repos/DOAJ/doaj/pulls{/number}","milestones_url":"https://api.github.com/repos/DOAJ/doaj/milestones{/number}","notifications_url":"https://api.github.com/repos/DOAJ/doaj/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DOAJ/doaj/labels{/name}","releases_url":"https://api.github.com/repos/DOAJ/doaj/releases{/id}","created_at":"2013-11-18T18:07:31Z","updated_at":"2014-09-09T01:27:25Z","pushed_at":"2014-10-03T17:11:19Z","git_url":"git://github.com/DOAJ/doaj.git","ssh_url":"git@github.com:DOAJ/doaj.git","clone_url":"https://github.com/DOAJ/doaj.git","svn_url":"https://github.com/DOAJ/doaj","homepage":null,"size":9518,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":87,"forks":1,"open_issues":87,"watchers":2,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/DOAJ/doaj/pulls/336"},"html":{"href":"https://github.com/DOAJ/doaj/pull/336"},"issue":{"href":"https://api.github.com/repos/DOAJ/doaj/issues/336"},"comments":{"href":"https://api.github.com/repos/DOAJ/doaj/issues/336/comments"},"review_comments":{"href":"https://api.github.com/repos/DOAJ/doaj/pulls/336/comments"},"review_comment":{"href":"https://api.github.com/repos/DOAJ/doaj/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/DOAJ/doaj/pulls/336/commits"},"statuses":{"href":"https://api.github.com/repos/DOAJ/doaj/statuses/7855805f78204540937631e42783fc006d183bde"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":3,"additions":245,"deletions":0,"changed_files":2}}