GitHub PullRequestReviewCommentEvent at 2014-11-03 10:53:57
Repository: transition
Actor: issyl0
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/alphagov/transition/pulls/comments/19726715","id":19726715,"diff_hunk":"@@ -48,6 +48,20 @@\n         site.hosts.pluck(:hostname).sort.should eql(hosts.sort)\n       end\n \n+      describe '#import! lowercases uppercased hosts' do","path":"spec/lib/transition/import/site_yaml_file_spec.rb","position":4,"original_position":4,"commit_id":"ce5c8aa005b03f10e3c7161623bcd68cff248570","original_commit_id":"bd4607a0e85a67d4cb62d626cf24f7d745a48972","user":{"login":"issyl0","id":355033,"avatar_url":"https://avatars.githubusercontent.com/u/355033?v=2","gravatar_id":"","url":"https://api.github.com/users/issyl0","html_url":"https://github.com/issyl0","followers_url":"https://api.github.com/users/issyl0/followers","following_url":"https://api.github.com/users/issyl0/following{/other_user}","gists_url":"https://api.github.com/users/issyl0/gists{/gist_id}","starred_url":"https://api.github.com/users/issyl0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/issyl0/subscriptions","organizations_url":"https://api.github.com/users/issyl0/orgs","repos_url":"https://api.github.com/users/issyl0/repos","events_url":"https://api.github.com/users/issyl0/events{/privacy}","received_events_url":"https://api.github.com/users/issyl0/received_events","type":"User","site_admin":false},"body":"I remember I tried to do this in redirector on Wednesday and then got totally confused and was told that it would be better done in Transition.","created_at":"2014-11-03T10:53:57Z","updated_at":"2014-11-03T10:53:57Z","html_url":"https://github.com/alphagov/transition/pull/445#discussion_r19726715","pull_request_url":"https://api.github.com/repos/alphagov/transition/pulls/445","_links":{"self":{"href":"https://api.github.com/repos/alphagov/transition/pulls/comments/19726715"},"html":{"href":"https://github.com/alphagov/transition/pull/445#discussion_r19726715"},"pull_request":{"href":"https://api.github.com/repos/alphagov/transition/pulls/445"}}},"pull_request":{"url":"https://api.github.com/repos/alphagov/transition/pulls/445","id":23747105,"html_url":"https://github.com/alphagov/transition/pull/445","diff_url":"https://github.com/alphagov/transition/pull/445.diff","patch_url":"https://github.com/alphagov/transition/pull/445.patch","issue_url":"https://api.github.com/repos/alphagov/transition/issues/445","number":445,"state":"open","locked":false,"title":"Lowercase hosts on import and reject uppercase hosts for the whitelist","user":{"login":"issyl0","id":355033,"avatar_url":"https://avatars.githubusercontent.com/u/355033?v=2","gravatar_id":"","url":"https://api.github.com/users/issyl0","html_url":"https://github.com/issyl0","followers_url":"https://api.github.com/users/issyl0/followers","following_url":"https://api.github.com/users/issyl0/following{/other_user}","gists_url":"https://api.github.com/users/issyl0/gists{/gist_id}","starred_url":"https://api.github.com/users/issyl0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/issyl0/subscriptions","organizations_url":"https://api.github.com/users/issyl0/orgs","repos_url":"https://api.github.com/users/issyl0/repos","events_url":"https://api.github.com/users/issyl0/events{/privacy}","received_events_url":"https://api.github.com/users/issyl0/received_events","type":"User","site_admin":false},"body":"- Lowercase hosts when importing from site YAML files, so we don't potentially add uppercase hosts that Bouncer can't handle.\r\n- Explicitly reject adding an uppercase host to the whitelist.","created_at":"2014-11-03T08:21:19Z","updated_at":"2014-11-03T10:53:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5cf1c26b1ef9f402f45602b470090585d1cd3395","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/transition/pulls/445/commits","review_comments_url":"https://api.github.com/repos/alphagov/transition/pulls/445/comments","review_comment_url":"https://api.github.com/repos/alphagov/transition/pulls/comments/{number}","comments_url":"https://api.github.com/repos/alphagov/transition/issues/445/comments","statuses_url":"https://api.github.com/repos/alphagov/transition/statuses/ce5c8aa005b03f10e3c7161623bcd68cff248570","head":{"label":"alphagov:lowercase_hosts_in_import_and_whitelist","ref":"lowercase_hosts_in_import_and_whitelist","sha":"ce5c8aa005b03f10e3c7161623bcd68cff248570","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=2","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":12729833,"name":"transition","full_name":"alphagov/transition","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=2","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/transition","description":"Managing mappings (eg redirects) for sites moving to GOV.UK.","fork":false,"url":"https://api.github.com/repos/alphagov/transition","forks_url":"https://api.github.com/repos/alphagov/transition/forks","keys_url":"https://api.github.com/repos/alphagov/transition/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/transition/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/transition/teams","hooks_url":"https://api.github.com/repos/alphagov/transition/hooks","issue_events_url":"https://api.github.com/repos/alphagov/transition/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/transition/events","assignees_url":"https://api.github.com/repos/alphagov/transition/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/transition/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/transition/tags","blobs_url":"https://api.github.com/repos/alphagov/transition/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/transition/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/transition/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/transition/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/transition/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/transition/languages","stargazers_url":"https://api.github.com/repos/alphagov/transition/stargazers","contributors_url":"https://api.github.com/repos/alphagov/transition/contributors","subscribers_url":"https://api.github.com/repos/alphagov/transition/subscribers","subscription_url":"https://api.github.com/repos/alphagov/transition/subscription","commits_url":"https://api.github.com/repos/alphagov/transition/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/transition/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/transition/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/transition/issues/comments/{number}","contents_url":"https://api.github.com/repos/alphagov/transition/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/transition/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/transition/merges","archive_url":"https://api.github.com/repos/alphagov/transition/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/transition/downloads","issues_url":"https://api.github.com/repos/alphagov/transition/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/transition/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/transition/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/transition/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/transition/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/transition/releases{/id}","created_at":"2013-09-10T13:11:17Z","updated_at":"2014-09-23T14:30:59Z","pushed_at":"2014-11-03T10:12:38Z","git_url":"git://github.com/alphagov/transition.git","ssh_url":"git@github.com:alphagov/transition.git","clone_url":"https://github.com/alphagov/transition.git","svn_url":"https://github.com/alphagov/transition","homepage":null,"size":26308,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":2,"forks":6,"open_issues":2,"watchers":2,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"a56190a6e474d553bc8a687b5af767cf340b0b76","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=2","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":12729833,"name":"transition","full_name":"alphagov/transition","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=2","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/transition","description":"Managing mappings (eg redirects) for sites moving to GOV.UK.","fork":false,"url":"https://api.github.com/repos/alphagov/transition","forks_url":"https://api.github.com/repos/alphagov/transition/forks","keys_url":"https://api.github.com/repos/alphagov/transition/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/transition/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/transition/teams","hooks_url":"https://api.github.com/repos/alphagov/transition/hooks","issue_events_url":"https://api.github.com/repos/alphagov/transition/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/transition/events","assignees_url":"https://api.github.com/repos/alphagov/transition/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/transition/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/transition/tags","blobs_url":"https://api.github.com/repos/alphagov/transition/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/transition/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/transition/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/transition/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/transition/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/transition/languages","stargazers_url":"https://api.github.com/repos/alphagov/transition/stargazers","contributors_url":"https://api.github.com/repos/alphagov/transition/contributors","subscribers_url":"https://api.github.com/repos/alphagov/transition/subscribers","subscription_url":"https://api.github.com/repos/alphagov/transition/subscription","commits_url":"https://api.github.com/repos/alphagov/transition/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/transition/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/transition/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/transition/issues/comments/{number}","contents_url":"https://api.github.com/repos/alphagov/transition/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/transition/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/transition/merges","archive_url":"https://api.github.com/repos/alphagov/transition/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/transition/downloads","issues_url":"https://api.github.com/repos/alphagov/transition/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/transition/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/transition/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/transition/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/transition/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/transition/releases{/id}","created_at":"2013-09-10T13:11:17Z","updated_at":"2014-09-23T14:30:59Z","pushed_at":"2014-11-03T10:12:38Z","git_url":"git://github.com/alphagov/transition.git","ssh_url":"git@github.com:alphagov/transition.git","clone_url":"https://github.com/alphagov/transition.git","svn_url":"https://github.com/alphagov/transition","homepage":null,"size":26308,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":2,"forks":6,"open_issues":2,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/transition/pulls/445"},"html":{"href":"https://github.com/alphagov/transition/pull/445"},"issue":{"href":"https://api.github.com/repos/alphagov/transition/issues/445"},"comments":{"href":"https://api.github.com/repos/alphagov/transition/issues/445/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/transition/pulls/445/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/transition/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/alphagov/transition/pulls/445/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/transition/statuses/ce5c8aa005b03f10e3c7161623bcd68cff248570"}}}}