GitHub PullRequestReviewCommentEvent at 2014-03-25 09:11:55
Repository: elasticsearch
Actor: martijnvg
Payload: {"comment":{"url":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/comments/10921643","id":10921643,"diff_hunk":"@@ -348,7 +361,7 @@ public void version(Field version) {\n     }\n \n     public boolean includeInAll(Boolean includeInAll, FieldMapper mapper) {\n-        return includeInAll(includeInAll, mapper.fieldType().indexed());\n+        return !isWithinMultiFields() && includeInAll(includeInAll, mapper.fieldType().indexed());","path":"src/main/java/org/elasticsearch/index/mapper/ParseContext.java","position":32,"original_position":32,"commit_id":"520a7be1a85890281725920d81c08c4cd635860f","original_commit_id":"520a7be1a85890281725920d81c08c4cd635860f","user":{"login":"martijnvg","id":580421,"avatar_url":"https://avatars.githubusercontent.com/u/580421?","gravatar_id":"c572e98b0d86d9f26d5e9cd9ddd99fc7","url":"https://api.github.com/users/martijnvg","html_url":"https://github.com/martijnvg","followers_url":"https://api.github.com/users/martijnvg/followers","following_url":"https://api.github.com/users/martijnvg/following{/other_user}","gists_url":"https://api.github.com/users/martijnvg/gists{/gist_id}","starred_url":"https://api.github.com/users/martijnvg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martijnvg/subscriptions","organizations_url":"https://api.github.com/users/martijnvg/orgs","repos_url":"https://api.github.com/users/martijnvg/repos","events_url":"https://api.github.com/users/martijnvg/events{/privacy}","received_events_url":"https://api.github.com/users/martijnvg/received_events","type":"User","site_admin":false},"body":"Instead of this line can add the following to the method being (includeInAll with the two booleans) invoked here?\r\n\r\n```java\r\nif (withinMultiFields) {\r\n   return false;\r\n}\r\n```\r\n\r\nThen it will be consistent with `withinCopyTo`.","created_at":"2014-03-25T09:11:55Z","updated_at":"2014-03-25T09:11:55Z","html_url":"https://github.com/elasticsearch/elasticsearch/pull/5522#discussion_r10921643","pull_request_url":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/5522","_links":{"self":{"href":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/comments/10921643"},"html":{"href":"https://github.com/elasticsearch/elasticsearch/pull/5522#discussion_r10921643"},"pull_request":{"href":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/5522"}}}}