GitHub PullRequestReviewCommentEvent at 2014-03-10 13:25:53
Repository: cakephp
Actor: mikegibson
Payload: {"comment":{"url":"https://api.github.com/repos/cakephp/cakephp/pulls/comments/10428577","id":10428577,"diff_hunk":"@@ -518,7 +518,12 @@ protected function _writeUrl($params) {\n \t\t$out = $this->template;\n \n \t\t$search = $replace = array();\n-\t\tforeach ($this->keys as $key) {\n+\t\t$keys = $this->keys;\n+\n+\t\t// Sort the keys in reverse order by length to prevent mismatches\n+\t\tuasort($keys, array($this, '_sortKeys'));","path":"lib/Cake/Routing/Route/CakeRoute.php","position":null,"original_position":8,"commit_id":"17652575f33a9b1494eb99de3b95a25bdf2e7e37","original_commit_id":"12026583960409d6ff8447e60f293dcab07ca56c","user":{"login":"mikegibson","id":1511645,"avatar_url":"https://gravatar.com/avatar/43f03ab236b6acb480f044833e51b928?d=https%3A%2F%2Fidenticons.github.com%2F55cba294738fbb2b0d39e3fff38c1481.png&r=x","gravatar_id":"43f03ab236b6acb480f044833e51b928","url":"https://api.github.com/users/mikegibson","html_url":"https://github.com/mikegibson","followers_url":"https://api.github.com/users/mikegibson/followers","following_url":"https://api.github.com/users/mikegibson/following{/other_user}","gists_url":"https://api.github.com/users/mikegibson/gists{/gist_id}","starred_url":"https://api.github.com/users/mikegibson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikegibson/subscriptions","organizations_url":"https://api.github.com/users/mikegibson/orgs","repos_url":"https://api.github.com/users/mikegibson/repos","events_url":"https://api.github.com/users/mikegibson/events{/privacy}","received_events_url":"https://api.github.com/users/mikegibson/received_events","type":"User","site_admin":false},"body":"AFAIK strlen returns the length of the string where uasort expects either 0, 1 or -1 in return? All examples I've found with strlen have to use a separate comparison function. I've pushed a new commit using an alternate sorting method.","created_at":"2014-03-10T13:25:53Z","updated_at":"2014-03-10T13:25:53Z","html_url":"https://github.com/cakephp/cakephp/pull/2991#discussion_r10428577","pull_request_url":"https://api.github.com/repos/cakephp/cakephp/pulls/2991","_links":{"self":{"href":"https://api.github.com/repos/cakephp/cakephp/pulls/comments/10428577"},"html":{"href":"https://github.com/cakephp/cakephp/pull/2991#discussion_r10428577"},"pull_request":{"href":"https://api.github.com/repos/cakephp/cakephp/pulls/2991"}}}}