GitHub PullRequestReviewCommentEvent at 2014-06-02 20:59:33
Repository: scikit-learn
Actor: ndawe
Payload: {"comment":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/13306954","id":13306954,"diff_hunk":"@@ -1170,6 +1175,13 @@ cdef class BestSplitter(Splitter):\n                                 continue\n \n                             self.criterion.update(current_pos)\n+                             \n+                            if self.min_weight_fraction_leaf > 0:\n+                                # Reject if min_weight_fraction_leaf is not satisfied\n+                                if ((self.criterion.weighted_n_left / self.weighted_n_samples < self.min_weight_fraction_leaf) or\n+                                        (self.criterion.weighted_n_right / self.weighted_n_samples < self.min_weight_fraction_leaf)):","path":"sklearn/tree/_tree.pyx","position":43,"original_position":43,"commit_id":"9cde976122714d0caa01e612c29a7390efd84d27","original_commit_id":"9cde976122714d0caa01e612c29a7390efd84d27","user":{"login":"ndawe","id":202816,"avatar_url":"https://avatars.githubusercontent.com/u/202816?","gravatar_id":"8dc4b5785fce46ddc44dbe959d896792","url":"https://api.github.com/users/ndawe","html_url":"https://github.com/ndawe","followers_url":"https://api.github.com/users/ndawe/followers","following_url":"https://api.github.com/users/ndawe/following{/other_user}","gists_url":"https://api.github.com/users/ndawe/gists{/gist_id}","starred_url":"https://api.github.com/users/ndawe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndawe/subscriptions","organizations_url":"https://api.github.com/users/ndawe/orgs","repos_url":"https://api.github.com/users/ndawe/repos","events_url":"https://api.github.com/users/ndawe/events{/privacy}","received_events_url":"https://api.github.com/users/ndawe/received_events","type":"User","site_admin":false},"body":"Done.","created_at":"2014-06-02T20:59:33Z","updated_at":"2014-06-02T20:59:33Z","html_url":"https://github.com/scikit-learn/scikit-learn/pull/3207#discussion_r13306954","pull_request_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/3207","_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/13306954"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/3207#discussion_r13306954"},"pull_request":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/3207"}}}}