GitHub PullRequestReviewCommentEvent at 2014-11-21 00:42:50
Repository: concourse
Actor: jtnelson
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/cinchapi/concourse/pulls/comments/20690143","id":20690143,"diff_hunk":"@@ -109,6 +112,23 @@ else if(object instanceof Tag) {\n         bytes.rewind();\n         return new TObject(bytes, type);\n     }\n+    \n+    /**\n+     * Convert Java objects into a JSON formatted string.\n+     * The Java objects is a mapping of key to values of the data of each of the records.\n+     * The records have a structure of Map<Record ID, Map<Key, Values>> when true\n+     * The records have a structure of Map<Key, Values> when false.\n+     * @param <K> \n+     * @param <V>\n+     * \n+     * @param data\n+     * @return the JSON string\n+     */\n+    public static <K, V> String javaToJson(Map<K, V> data) {","path":"concourse/src/main/java/org/cinchapi/concourse/util/Convert.java","position":34,"original_position":34,"commit_id":"de221f6acd3db736ee6511bbc895d75bcf67fae5","original_commit_id":"de221f6acd3db736ee6511bbc895d75bcf67fae5","user":{"login":"jtnelson","id":1495450,"avatar_url":"https://avatars.githubusercontent.com/u/1495450?v=3","gravatar_id":"","url":"https://api.github.com/users/jtnelson","html_url":"https://github.com/jtnelson","followers_url":"https://api.github.com/users/jtnelson/followers","following_url":"https://api.github.com/users/jtnelson/following{/other_user}","gists_url":"https://api.github.com/users/jtnelson/gists{/gist_id}","starred_url":"https://api.github.com/users/jtnelson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtnelson/subscriptions","organizations_url":"https://api.github.com/users/jtnelson/orgs","repos_url":"https://api.github.com/users/jtnelson/repos","events_url":"https://api.github.com/users/jtnelson/events{/privacy}","received_events_url":"https://api.github.com/users/jtnelson/received_events","type":"User","site_admin":false},"body":"You can replace the current one with one that takes Object.\r\n\r\nOn Thu, Nov 20, 2014 at 7:24 PM, airconditioner <notifications@github.com>\r\nwrote:\r\n\r\n> In concourse/src/main/java/org/cinchapi/concourse/util/Convert.java:\r\n>\r\n> > @@ -109,6 +112,23 @@ else if(object instanceof Tag) {\r\n> >          bytes.rewind();\r\n> >          return new TObject(bytes, type);\r\n> >      }\r\n> > +\r\n> > +    /**\r\n> > +     * Convert Java objects into a JSON formatted string.\r\n> > +     * The Java objects is a mapping of key to values of the data of each of the records.\r\n> > +     * The records have a structure of Map<Record ID, Map<Key, Values>> when true\r\n> > +     * The records have a structure of Map<Key, Values> when false.\r\n> > +     * @param <K>\r\n> > +     * @param <V>\r\n> > +     *\r\n> > +     * @param data\r\n> > +     * @return the JSON string\r\n> > +     */\r\n> > +    public static <K, V> String javaToJson(Map<K, V> data) {\r\n>\r\n> Do I add another method that takes in Object or do I replace the current\r\n> one?\r\n>\r\n> —\r\n> Reply to this email directly or view it on GitHub\r\n> <https://github.com/cinchapi/concourse/pull/35/files#r20689262>.\r\n>","created_at":"2014-11-21T00:42:50Z","updated_at":"2014-11-21T00:42:50Z","html_url":"https://github.com/cinchapi/concourse/pull/35#discussion_r20690143","pull_request_url":"https://api.github.com/repos/cinchapi/concourse/pulls/35","_links":{"self":{"href":"https://api.github.com/repos/cinchapi/concourse/pulls/comments/20690143"},"html":{"href":"https://github.com/cinchapi/concourse/pull/35#discussion_r20690143"},"pull_request":{"href":"https://api.github.com/repos/cinchapi/concourse/pulls/35"}}},"pull_request":{"url":"https://api.github.com/repos/cinchapi/concourse/pulls/35","id":24666665,"html_url":"https://github.com/cinchapi/concourse/pull/35","diff_url":"https://github.com/cinchapi/concourse/pull/35.diff","patch_url":"https://github.com/cinchapi/concourse/pull/35.patch","issue_url":"https://api.github.com/repos/cinchapi/concourse/issues/35","number":35,"state":"open","locked":false,"title":"Add jsonify method","user":{"login":"airconditioner","id":6268279,"avatar_url":"https://avatars.githubusercontent.com/u/6268279?v=3","gravatar_id":"","url":"https://api.github.com/users/airconditioner","html_url":"https://github.com/airconditioner","followers_url":"https://api.github.com/users/airconditioner/followers","following_url":"https://api.github.com/users/airconditioner/following{/other_user}","gists_url":"https://api.github.com/users/airconditioner/gists{/gist_id}","starred_url":"https://api.github.com/users/airconditioner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/airconditioner/subscriptions","organizations_url":"https://api.github.com/users/airconditioner/orgs","repos_url":"https://api.github.com/users/airconditioner/repos","events_url":"https://api.github.com/users/airconditioner/events{/privacy}","received_events_url":"https://api.github.com/users/airconditioner/received_events","type":"User","site_admin":false},"body":"I think I accidentally deleted the two Start/Stop launch files from my repository. It shows in the diff. I downloaded it back into the launch folder but the .gitignore file suggested not to add it back on. I don't know what to do.\r\n\r\n","created_at":"2014-11-19T05:26:18Z","updated_at":"2014-11-21T00:42:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b8dade923dc95e4849667f0dac7ba4ca70c5dcea","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cinchapi/concourse/pulls/35/commits","review_comments_url":"https://api.github.com/repos/cinchapi/concourse/pulls/35/comments","review_comment_url":"https://api.github.com/repos/cinchapi/concourse/pulls/comments/{number}","comments_url":"https://api.github.com/repos/cinchapi/concourse/issues/35/comments","statuses_url":"https://api.github.com/repos/cinchapi/concourse/statuses/de221f6acd3db736ee6511bbc895d75bcf67fae5","head":{"label":"airconditioner:develop","ref":"develop","sha":"de221f6acd3db736ee6511bbc895d75bcf67fae5","user":{"login":"airconditioner","id":6268279,"avatar_url":"https://avatars.githubusercontent.com/u/6268279?v=3","gravatar_id":"","url":"https://api.github.com/users/airconditioner","html_url":"https://github.com/airconditioner","followers_url":"https://api.github.com/users/airconditioner/followers","following_url":"https://api.github.com/users/airconditioner/following{/other_user}","gists_url":"https://api.github.com/users/airconditioner/gists{/gist_id}","starred_url":"https://api.github.com/users/airconditioner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/airconditioner/subscriptions","organizations_url":"https://api.github.com/users/airconditioner/orgs","repos_url":"https://api.github.com/users/airconditioner/repos","events_url":"https://api.github.com/users/airconditioner/events{/privacy}","received_events_url":"https://api.github.com/users/airconditioner/received_events","type":"User","site_admin":false},"repo":{"id":26675428,"name":"concourse","full_name":"airconditioner/concourse","owner":{"login":"airconditioner","id":6268279,"avatar_url":"https://avatars.githubusercontent.com/u/6268279?v=3","gravatar_id":"","url":"https://api.github.com/users/airconditioner","html_url":"https://github.com/airconditioner","followers_url":"https://api.github.com/users/airconditioner/followers","following_url":"https://api.github.com/users/airconditioner/following{/other_user}","gists_url":"https://api.github.com/users/airconditioner/gists{/gist_id}","starred_url":"https://api.github.com/users/airconditioner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/airconditioner/subscriptions","organizations_url":"https://api.github.com/users/airconditioner/orgs","repos_url":"https://api.github.com/users/airconditioner/repos","events_url":"https://api.github.com/users/airconditioner/events{/privacy}","received_events_url":"https://api.github.com/users/airconditioner/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/airconditioner/concourse","description":"Concourse is a schemaless and distributed version control database with automatic indexing, acid transactions and full-text search. Concourse provides a more intuitive approach to data management that is easy to deploy, access and scale with minimal tuning while also maintaining the referential integrity and ACID characteristics of traditional database systems.","fork":true,"url":"https://api.github.com/repos/airconditioner/concourse","forks_url":"https://api.github.com/repos/airconditioner/concourse/forks","keys_url":"https://api.github.com/repos/airconditioner/concourse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/airconditioner/concourse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/airconditioner/concourse/teams","hooks_url":"https://api.github.com/repos/airconditioner/concourse/hooks","issue_events_url":"https://api.github.com/repos/airconditioner/concourse/issues/events{/number}","events_url":"https://api.github.com/repos/airconditioner/concourse/events","assignees_url":"https://api.github.com/repos/airconditioner/concourse/assignees{/user}","branches_url":"https://api.github.com/repos/airconditioner/concourse/branches{/branch}","tags_url":"https://api.github.com/repos/airconditioner/concourse/tags","blobs_url":"https://api.github.com/repos/airconditioner/concourse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/airconditioner/concourse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/airconditioner/concourse/git/refs{/sha}","trees_url":"https://api.github.com/repos/airconditioner/concourse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/airconditioner/concourse/statuses/{sha}","languages_url":"https://api.github.com/repos/airconditioner/concourse/languages","stargazers_url":"https://api.github.com/repos/airconditioner/concourse/stargazers","contributors_url":"https://api.github.com/repos/airconditioner/concourse/contributors","subscribers_url":"https://api.github.com/repos/airconditioner/concourse/subscribers","subscription_url":"https://api.github.com/repos/airconditioner/concourse/subscription","commits_url":"https://api.github.com/repos/airconditioner/concourse/commits{/sha}","git_commits_url":"https://api.github.com/repos/airconditioner/concourse/git/commits{/sha}","comments_url":"https://api.github.com/repos/airconditioner/concourse/comments{/number}","issue_comment_url":"https://api.github.com/repos/airconditioner/concourse/issues/comments/{number}","contents_url":"https://api.github.com/repos/airconditioner/concourse/contents/{+path}","compare_url":"https://api.github.com/repos/airconditioner/concourse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/airconditioner/concourse/merges","archive_url":"https://api.github.com/repos/airconditioner/concourse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/airconditioner/concourse/downloads","issues_url":"https://api.github.com/repos/airconditioner/concourse/issues{/number}","pulls_url":"https://api.github.com/repos/airconditioner/concourse/pulls{/number}","milestones_url":"https://api.github.com/repos/airconditioner/concourse/milestones{/number}","notifications_url":"https://api.github.com/repos/airconditioner/concourse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/airconditioner/concourse/labels{/name}","releases_url":"https://api.github.com/repos/airconditioner/concourse/releases{/id}","created_at":"2014-11-15T09:34:10Z","updated_at":"2014-11-20T12:23:35Z","pushed_at":"2014-11-20T12:23:35Z","git_url":"git://github.com/airconditioner/concourse.git","ssh_url":"git@github.com:airconditioner/concourse.git","clone_url":"https://github.com/airconditioner/concourse.git","svn_url":"https://github.com/airconditioner/concourse","homepage":"concourseDB.com","size":14280,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"cinchapi:develop","ref":"develop","sha":"96f8b11b31709ddfe3ef1dd3672bbdaf29a6440c","user":{"login":"cinchapi","id":5642441,"avatar_url":"https://avatars.githubusercontent.com/u/5642441?v=3","gravatar_id":"","url":"https://api.github.com/users/cinchapi","html_url":"https://github.com/cinchapi","followers_url":"https://api.github.com/users/cinchapi/followers","following_url":"https://api.github.com/users/cinchapi/following{/other_user}","gists_url":"https://api.github.com/users/cinchapi/gists{/gist_id}","starred_url":"https://api.github.com/users/cinchapi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cinchapi/subscriptions","organizations_url":"https://api.github.com/users/cinchapi/orgs","repos_url":"https://api.github.com/users/cinchapi/repos","events_url":"https://api.github.com/users/cinchapi/events{/privacy}","received_events_url":"https://api.github.com/users/cinchapi/received_events","type":"Organization","site_admin":false},"repo":{"id":13353426,"name":"concourse","full_name":"cinchapi/concourse","owner":{"login":"cinchapi","id":5642441,"avatar_url":"https://avatars.githubusercontent.com/u/5642441?v=3","gravatar_id":"","url":"https://api.github.com/users/cinchapi","html_url":"https://github.com/cinchapi","followers_url":"https://api.github.com/users/cinchapi/followers","following_url":"https://api.github.com/users/cinchapi/following{/other_user}","gists_url":"https://api.github.com/users/cinchapi/gists{/gist_id}","starred_url":"https://api.github.com/users/cinchapi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cinchapi/subscriptions","organizations_url":"https://api.github.com/users/cinchapi/orgs","repos_url":"https://api.github.com/users/cinchapi/repos","events_url":"https://api.github.com/users/cinchapi/events{/privacy}","received_events_url":"https://api.github.com/users/cinchapi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cinchapi/concourse","description":"Concourse is a schemaless and distributed version control database with automatic indexing, acid transactions and full-text search. Concourse provides a more intuitive approach to data management that is easy to deploy, access and scale with minimal tuning while also maintaining the referential integrity and ACID characteristics of traditional database systems.","fork":false,"url":"https://api.github.com/repos/cinchapi/concourse","forks_url":"https://api.github.com/repos/cinchapi/concourse/forks","keys_url":"https://api.github.com/repos/cinchapi/concourse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cinchapi/concourse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cinchapi/concourse/teams","hooks_url":"https://api.github.com/repos/cinchapi/concourse/hooks","issue_events_url":"https://api.github.com/repos/cinchapi/concourse/issues/events{/number}","events_url":"https://api.github.com/repos/cinchapi/concourse/events","assignees_url":"https://api.github.com/repos/cinchapi/concourse/assignees{/user}","branches_url":"https://api.github.com/repos/cinchapi/concourse/branches{/branch}","tags_url":"https://api.github.com/repos/cinchapi/concourse/tags","blobs_url":"https://api.github.com/repos/cinchapi/concourse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cinchapi/concourse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cinchapi/concourse/git/refs{/sha}","trees_url":"https://api.github.com/repos/cinchapi/concourse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cinchapi/concourse/statuses/{sha}","languages_url":"https://api.github.com/repos/cinchapi/concourse/languages","stargazers_url":"https://api.github.com/repos/cinchapi/concourse/stargazers","contributors_url":"https://api.github.com/repos/cinchapi/concourse/contributors","subscribers_url":"https://api.github.com/repos/cinchapi/concourse/subscribers","subscription_url":"https://api.github.com/repos/cinchapi/concourse/subscription","commits_url":"https://api.github.com/repos/cinchapi/concourse/commits{/sha}","git_commits_url":"https://api.github.com/repos/cinchapi/concourse/git/commits{/sha}","comments_url":"https://api.github.com/repos/cinchapi/concourse/comments{/number}","issue_comment_url":"https://api.github.com/repos/cinchapi/concourse/issues/comments/{number}","contents_url":"https://api.github.com/repos/cinchapi/concourse/contents/{+path}","compare_url":"https://api.github.com/repos/cinchapi/concourse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cinchapi/concourse/merges","archive_url":"https://api.github.com/repos/cinchapi/concourse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cinchapi/concourse/downloads","issues_url":"https://api.github.com/repos/cinchapi/concourse/issues{/number}","pulls_url":"https://api.github.com/repos/cinchapi/concourse/pulls{/number}","milestones_url":"https://api.github.com/repos/cinchapi/concourse/milestones{/number}","notifications_url":"https://api.github.com/repos/cinchapi/concourse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cinchapi/concourse/labels{/name}","releases_url":"https://api.github.com/repos/cinchapi/concourse/releases{/id}","created_at":"2013-10-05T22:12:00Z","updated_at":"2014-11-20T23:43:02Z","pushed_at":"2014-11-20T23:43:02Z","git_url":"git://github.com/cinchapi/concourse.git","ssh_url":"git@github.com:cinchapi/concourse.git","clone_url":"https://github.com/cinchapi/concourse.git","svn_url":"https://github.com/cinchapi/concourse","homepage":"concourseDB.com","size":20144,"stargazers_count":26,"watchers_count":26,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":42,"mirror_url":null,"open_issues_count":1,"forks":42,"open_issues":1,"watchers":26,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/cinchapi/concourse/pulls/35"},"html":{"href":"https://github.com/cinchapi/concourse/pull/35"},"issue":{"href":"https://api.github.com/repos/cinchapi/concourse/issues/35"},"comments":{"href":"https://api.github.com/repos/cinchapi/concourse/issues/35/comments"},"review_comments":{"href":"https://api.github.com/repos/cinchapi/concourse/pulls/35/comments"},"review_comment":{"href":"https://api.github.com/repos/cinchapi/concourse/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/cinchapi/concourse/pulls/35/commits"},"statuses":{"href":"https://api.github.com/repos/cinchapi/concourse/statuses/de221f6acd3db736ee6511bbc895d75bcf67fae5"}}}}