GitHub PullRequestReviewCommentEvent at 2014-06-18 04:41:23
Repository: traceur-compiler
Actor: giltayar
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/google/traceur-compiler/pulls/comments/13899233","id":13899233,"diff_hunk":"@@ -110,7 +116,7 @@ export class WebPageTranscoder {\n   }\n \n   selectAndProcessScripts(done) {\n-    var selector = 'script[type=\"module\"]';\n+    var selector = 'script[type=\"module\"],script[type=\"text/traceur\"]';","path":"src/WebPageTranscoder.js","position":38,"original_position":38,"commit_id":"21f0722cf60ced3ac0935e14dbb8deb294defe56","original_commit_id":"21f0722cf60ced3ac0935e14dbb8deb294defe56","user":{"login":"giltayar","id":403268,"avatar_url":"https://avatars.githubusercontent.com/u/403268?","gravatar_id":"d10c5b1b250c186522f69f9c39154439","url":"https://api.github.com/users/giltayar","html_url":"https://github.com/giltayar","followers_url":"https://api.github.com/users/giltayar/followers","following_url":"https://api.github.com/users/giltayar/following{/other_user}","gists_url":"https://api.github.com/users/giltayar/gists{/gist_id}","starred_url":"https://api.github.com/users/giltayar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giltayar/subscriptions","organizations_url":"https://api.github.com/users/giltayar/orgs","repos_url":"https://api.github.com/users/giltayar/repos","events_url":"https://api.github.com/users/giltayar/events{/privacy}","received_events_url":"https://api.github.com/users/giltayar/received_events","type":"User","site_admin":false},"body":"This will mean that 'addFilesFromScriptElements' will need to ignore scripts that are not of this or that type. I prefer doing that in the 'selectAndProcessScripts', which, as it name says, *selects* the scripts to process","created_at":"2014-06-18T04:41:23Z","updated_at":"2014-06-18T04:41:23Z","html_url":"https://github.com/google/traceur-compiler/pull/1033#discussion_r13899233","pull_request_url":"https://api.github.com/repos/google/traceur-compiler/pulls/1033","_links":{"self":{"href":"https://api.github.com/repos/google/traceur-compiler/pulls/comments/13899233"},"html":{"href":"https://github.com/google/traceur-compiler/pull/1033#discussion_r13899233"},"pull_request":{"href":"https://api.github.com/repos/google/traceur-compiler/pulls/1033"}}},"pull_request":{"url":"https://api.github.com/repos/google/traceur-compiler/pulls/1033","id":16145108,"html_url":"https://github.com/google/traceur-compiler/pull/1033","diff_url":"https://github.com/google/traceur-compiler/pull/1033.diff","patch_url":"https://github.com/google/traceur-compiler/pull/1033.patch","issue_url":"https://api.github.com/repos/google/traceur-compiler/issues/1033","number":1033,"state":"open","title":"Re-support type=\"text/traceur\" to enable global semantics for scripts","user":{"login":"giltayar","id":403268,"avatar_url":"https://avatars.githubusercontent.com/u/403268?","gravatar_id":"d10c5b1b250c186522f69f9c39154439","url":"https://api.github.com/users/giltayar","html_url":"https://github.com/giltayar","followers_url":"https://api.github.com/users/giltayar/followers","following_url":"https://api.github.com/users/giltayar/following{/other_user}","gists_url":"https://api.github.com/users/giltayar/gists{/gist_id}","starred_url":"https://api.github.com/users/giltayar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giltayar/subscriptions","organizations_url":"https://api.github.com/users/giltayar/orgs","repos_url":"https://api.github.com/users/giltayar/repos","events_url":"https://api.github.com/users/giltayar/events{/privacy}","received_events_url":"https://api.github.com/users/giltayar/received_events","type":"User","site_admin":false},"body":"...tics for scripts\r\n\r\n\tFixes #822\r\n\r\n\tThe difference between scripts with type=\"module\" and \"text/traceur\" is that the \"text/traceur\" script's globals will be global to all the other scripts, just like regular es5 script tags.","created_at":"2014-05-21T04:31:06Z","updated_at":"2014-06-18T04:41:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0438a6f6cdec3e33ca2effab920338527f88c16b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/google/traceur-compiler/pulls/1033/commits","review_comments_url":"https://api.github.com/repos/google/traceur-compiler/pulls/1033/comments","review_comment_url":"https://api.github.com/repos/google/traceur-compiler/pulls/comments/{number}","comments_url":"https://api.github.com/repos/google/traceur-compiler/issues/1033/comments","statuses_url":"https://api.github.com/repos/google/traceur-compiler/statuses/21f0722cf60ced3ac0935e14dbb8deb294defe56","head":{"label":"wix:master","ref":"master","sha":"21f0722cf60ced3ac0935e14dbb8deb294defe56","user":{"login":"wix","id":686511,"avatar_url":"https://avatars.githubusercontent.com/u/686511?","gravatar_id":"e4f86992eeddff62f5ed2be1fa6a111e","url":"https://api.github.com/users/wix","html_url":"https://github.com/wix","followers_url":"https://api.github.com/users/wix/followers","following_url":"https://api.github.com/users/wix/following{/other_user}","gists_url":"https://api.github.com/users/wix/gists{/gist_id}","starred_url":"https://api.github.com/users/wix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wix/subscriptions","organizations_url":"https://api.github.com/users/wix/orgs","repos_url":"https://api.github.com/users/wix/repos","events_url":"https://api.github.com/users/wix/events{/privacy}","received_events_url":"https://api.github.com/users/wix/received_events","type":"Organization","site_admin":false},"repo":{"id":20006292,"name":"traceur-compiler","full_name":"wix/traceur-compiler","owner":{"login":"wix","id":686511,"avatar_url":"https://avatars.githubusercontent.com/u/686511?","gravatar_id":"e4f86992eeddff62f5ed2be1fa6a111e","url":"https://api.github.com/users/wix","html_url":"https://github.com/wix","followers_url":"https://api.github.com/users/wix/followers","following_url":"https://api.github.com/users/wix/following{/other_user}","gists_url":"https://api.github.com/users/wix/gists{/gist_id}","starred_url":"https://api.github.com/users/wix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wix/subscriptions","organizations_url":"https://api.github.com/users/wix/orgs","repos_url":"https://api.github.com/users/wix/repos","events_url":"https://api.github.com/users/wix/events{/privacy}","received_events_url":"https://api.github.com/users/wix/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wix/traceur-compiler","description":"Traceur is a JavaScript.next-to-JavaScript-of-today compiler","fork":true,"url":"https://api.github.com/repos/wix/traceur-compiler","forks_url":"https://api.github.com/repos/wix/traceur-compiler/forks","keys_url":"https://api.github.com/repos/wix/traceur-compiler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wix/traceur-compiler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wix/traceur-compiler/teams","hooks_url":"https://api.github.com/repos/wix/traceur-compiler/hooks","issue_events_url":"https://api.github.com/repos/wix/traceur-compiler/issues/events{/number}","events_url":"https://api.github.com/repos/wix/traceur-compiler/events","assignees_url":"https://api.github.com/repos/wix/traceur-compiler/assignees{/user}","branches_url":"https://api.github.com/repos/wix/traceur-compiler/branches{/branch}","tags_url":"https://api.github.com/repos/wix/traceur-compiler/tags","blobs_url":"https://api.github.com/repos/wix/traceur-compiler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wix/traceur-compiler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wix/traceur-compiler/git/refs{/sha}","trees_url":"https://api.github.com/repos/wix/traceur-compiler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wix/traceur-compiler/statuses/{sha}","languages_url":"https://api.github.com/repos/wix/traceur-compiler/languages","stargazers_url":"https://api.github.com/repos/wix/traceur-compiler/stargazers","contributors_url":"https://api.github.com/repos/wix/traceur-compiler/contributors","subscribers_url":"https://api.github.com/repos/wix/traceur-compiler/subscribers","subscription_url":"https://api.github.com/repos/wix/traceur-compiler/subscription","commits_url":"https://api.github.com/repos/wix/traceur-compiler/commits{/sha}","git_commits_url":"https://api.github.com/repos/wix/traceur-compiler/git/commits{/sha}","comments_url":"https://api.github.com/repos/wix/traceur-compiler/comments{/number}","issue_comment_url":"https://api.github.com/repos/wix/traceur-compiler/issues/comments/{number}","contents_url":"https://api.github.com/repos/wix/traceur-compiler/contents/{+path}","compare_url":"https://api.github.com/repos/wix/traceur-compiler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wix/traceur-compiler/merges","archive_url":"https://api.github.com/repos/wix/traceur-compiler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wix/traceur-compiler/downloads","issues_url":"https://api.github.com/repos/wix/traceur-compiler/issues{/number}","pulls_url":"https://api.github.com/repos/wix/traceur-compiler/pulls{/number}","milestones_url":"https://api.github.com/repos/wix/traceur-compiler/milestones{/number}","notifications_url":"https://api.github.com/repos/wix/traceur-compiler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wix/traceur-compiler/labels{/name}","releases_url":"https://api.github.com/repos/wix/traceur-compiler/releases{/id}","created_at":"2014-05-21T03:12:56Z","updated_at":"2014-06-01T11:27:23Z","pushed_at":"2014-06-01T11:27:24Z","git_url":"git://github.com/wix/traceur-compiler.git","ssh_url":"git@github.com:wix/traceur-compiler.git","clone_url":"https://github.com/wix/traceur-compiler.git","svn_url":"https://github.com/wix/traceur-compiler","homepage":"","size":18710,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"9d9e3dc8d39e0fd4ef00da6ec397f32ea5199c58","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?","gravatar_id":"24ba30616d2a20673f54c2aee36d159e","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":9060347,"name":"traceur-compiler","full_name":"google/traceur-compiler","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?","gravatar_id":"24ba30616d2a20673f54c2aee36d159e","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/traceur-compiler","description":"Traceur is a JavaScript.next-to-JavaScript-of-today compiler","fork":false,"url":"https://api.github.com/repos/google/traceur-compiler","forks_url":"https://api.github.com/repos/google/traceur-compiler/forks","keys_url":"https://api.github.com/repos/google/traceur-compiler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/traceur-compiler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/traceur-compiler/teams","hooks_url":"https://api.github.com/repos/google/traceur-compiler/hooks","issue_events_url":"https://api.github.com/repos/google/traceur-compiler/issues/events{/number}","events_url":"https://api.github.com/repos/google/traceur-compiler/events","assignees_url":"https://api.github.com/repos/google/traceur-compiler/assignees{/user}","branches_url":"https://api.github.com/repos/google/traceur-compiler/branches{/branch}","tags_url":"https://api.github.com/repos/google/traceur-compiler/tags","blobs_url":"https://api.github.com/repos/google/traceur-compiler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/traceur-compiler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/traceur-compiler/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/traceur-compiler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/traceur-compiler/statuses/{sha}","languages_url":"https://api.github.com/repos/google/traceur-compiler/languages","stargazers_url":"https://api.github.com/repos/google/traceur-compiler/stargazers","contributors_url":"https://api.github.com/repos/google/traceur-compiler/contributors","subscribers_url":"https://api.github.com/repos/google/traceur-compiler/subscribers","subscription_url":"https://api.github.com/repos/google/traceur-compiler/subscription","commits_url":"https://api.github.com/repos/google/traceur-compiler/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/traceur-compiler/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/traceur-compiler/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/traceur-compiler/issues/comments/{number}","contents_url":"https://api.github.com/repos/google/traceur-compiler/contents/{+path}","compare_url":"https://api.github.com/repos/google/traceur-compiler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/traceur-compiler/merges","archive_url":"https://api.github.com/repos/google/traceur-compiler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/traceur-compiler/downloads","issues_url":"https://api.github.com/repos/google/traceur-compiler/issues{/number}","pulls_url":"https://api.github.com/repos/google/traceur-compiler/pulls{/number}","milestones_url":"https://api.github.com/repos/google/traceur-compiler/milestones{/number}","notifications_url":"https://api.github.com/repos/google/traceur-compiler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/traceur-compiler/labels{/name}","releases_url":"https://api.github.com/repos/google/traceur-compiler/releases{/id}","created_at":"2013-03-27T18:05:40Z","updated_at":"2014-06-18T03:29:30Z","pushed_at":"2014-06-17T14:26:31Z","git_url":"git://github.com/google/traceur-compiler.git","ssh_url":"git@github.com:google/traceur-compiler.git","clone_url":"https://github.com/google/traceur-compiler.git","svn_url":"https://github.com/google/traceur-compiler","homepage":"","size":35825,"stargazers_count":2386,"watchers_count":2386,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":153,"mirror_url":null,"open_issues_count":187,"forks":153,"open_issues":187,"watchers":2386,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/traceur-compiler/pulls/1033"},"html":{"href":"https://github.com/google/traceur-compiler/pull/1033"},"issue":{"href":"https://api.github.com/repos/google/traceur-compiler/issues/1033"},"comments":{"href":"https://api.github.com/repos/google/traceur-compiler/issues/1033/comments"},"review_comments":{"href":"https://api.github.com/repos/google/traceur-compiler/pulls/1033/comments"},"review_comment":{"href":"https://api.github.com/repos/google/traceur-compiler/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/google/traceur-compiler/pulls/1033/commits"},"statuses":{"href":"https://api.github.com/repos/google/traceur-compiler/statuses/21f0722cf60ced3ac0935e14dbb8deb294defe56"}}}}