GitHub PullRequestReviewCommentEvent at 2014-10-22 09:14:58
Repository: hibernate-validator
Actor: gunnarmorling
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/hibernate/hibernate-validator/pulls/comments/19201972","id":19201972,"diff_hunk":"@@ -0,0 +1,50 @@\n+/*\n+ * Hibernate Validator, declare and validate application constraints\n+ *\n+ * License: Apache License, Version 2.0\n+ * See the license.txt file in the root directory or <http://www.apache.org/licenses/LICENSE-2.0>.\n+ */\n+package org.hibernate.validator.constraintvalidators;","path":"engine/src/main/java/org/hibernate/validator/constraintvalidators/RegexpURLValidator.java","position":7,"original_position":7,"commit_id":"4b68bc7ea9acdd14c5ff3ecfd98233f7b70618c2","original_commit_id":"4b68bc7ea9acdd14c5ff3ecfd98233f7b70618c2","user":{"login":"gunnarmorling","id":28612,"avatar_url":"https://avatars.githubusercontent.com/u/28612?v=2","gravatar_id":"","url":"https://api.github.com/users/gunnarmorling","html_url":"https://github.com/gunnarmorling","followers_url":"https://api.github.com/users/gunnarmorling/followers","following_url":"https://api.github.com/users/gunnarmorling/following{/other_user}","gists_url":"https://api.github.com/users/gunnarmorling/gists{/gist_id}","starred_url":"https://api.github.com/users/gunnarmorling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gunnarmorling/subscriptions","organizations_url":"https://api.github.com/users/gunnarmorling/orgs","repos_url":"https://api.github.com/users/gunnarmorling/repos","events_url":"https://api.github.com/users/gunnarmorling/events{/privacy}","received_events_url":"https://api.github.com/users/gunnarmorling/received_events","type":"User","site_admin":false},"body":"> Why?\r\n\r\nAll the other validators are internal parts, so it feels a bit \"irregular\". But I guess there is no way around it (except for \"hiding\" this implementation class via a more abstract means of configuration for controlling which impl to use).\r\n\r\n> Why not? Conceptually I see no problem here, but on second thought there might be a problem with OSGi. \r\n\r\nIt is a conceptual problem, just as it's a problem to expose internal types as method parameters of public APIs. In both ways, an internal API leaks through. Consequently, it is an issue in OSGi as well (which reminds me that the new public package should be added to the generated manifest?).","created_at":"2014-10-22T09:14:58Z","updated_at":"2014-10-22T09:14:58Z","html_url":"https://github.com/hibernate/hibernate-validator/pull/355#discussion_r19201972","pull_request_url":"https://api.github.com/repos/hibernate/hibernate-validator/pulls/355","_links":{"self":{"href":"https://api.github.com/repos/hibernate/hibernate-validator/pulls/comments/19201972"},"html":{"href":"https://github.com/hibernate/hibernate-validator/pull/355#discussion_r19201972"},"pull_request":{"href":"https://api.github.com/repos/hibernate/hibernate-validator/pulls/355"}}},"pull_request":{"url":"https://api.github.com/repos/hibernate/hibernate-validator/pulls/355","id":23034925,"html_url":"https://github.com/hibernate/hibernate-validator/pull/355","diff_url":"https://github.com/hibernate/hibernate-validator/pull/355.diff","patch_url":"https://github.com/hibernate/hibernate-validator/pull/355.patch","issue_url":"https://api.github.com/repos/hibernate/hibernate-validator/issues/355","number":355,"state":"open","locked":false,"title":"HV-920 Adding a regular expression based URL constraint validator which ...","user":{"login":"hferentschik","id":296354,"avatar_url":"https://avatars.githubusercontent.com/u/296354?v=2","gravatar_id":"","url":"https://api.github.com/users/hferentschik","html_url":"https://github.com/hferentschik","followers_url":"https://api.github.com/users/hferentschik/followers","following_url":"https://api.github.com/users/hferentschik/following{/other_user}","gists_url":"https://api.github.com/users/hferentschik/gists{/gist_id}","starred_url":"https://api.github.com/users/hferentschik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hferentschik/subscriptions","organizations_url":"https://api.github.com/users/hferentschik/orgs","repos_url":"https://api.github.com/users/hferentschik/repos","events_url":"https://api.github.com/users/hferentschik/events{/privacy}","received_events_url":"https://api.github.com/users/hferentschik/received_events","type":"User","site_admin":false},"body":"...needs to be configured via XML or via a ConstraintDefinitionContributor","created_at":"2014-10-20T18:34:42Z","updated_at":"2014-10-22T09:14:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"227e793d0649ef7d475ee29c47cb50804d3566d0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hibernate/hibernate-validator/pulls/355/commits","review_comments_url":"https://api.github.com/repos/hibernate/hibernate-validator/pulls/355/comments","review_comment_url":"https://api.github.com/repos/hibernate/hibernate-validator/pulls/comments/{number}","comments_url":"https://api.github.com/repos/hibernate/hibernate-validator/issues/355/comments","statuses_url":"https://api.github.com/repos/hibernate/hibernate-validator/statuses/4b68bc7ea9acdd14c5ff3ecfd98233f7b70618c2","head":{"label":"hferentschik:HV-920","ref":"HV-920","sha":"4b68bc7ea9acdd14c5ff3ecfd98233f7b70618c2","user":{"login":"hferentschik","id":296354,"avatar_url":"https://avatars.githubusercontent.com/u/296354?v=2","gravatar_id":"","url":"https://api.github.com/users/hferentschik","html_url":"https://github.com/hferentschik","followers_url":"https://api.github.com/users/hferentschik/followers","following_url":"https://api.github.com/users/hferentschik/following{/other_user}","gists_url":"https://api.github.com/users/hferentschik/gists{/gist_id}","starred_url":"https://api.github.com/users/hferentschik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hferentschik/subscriptions","organizations_url":"https://api.github.com/users/hferentschik/orgs","repos_url":"https://api.github.com/users/hferentschik/repos","events_url":"https://api.github.com/users/hferentschik/events{/privacy}","received_events_url":"https://api.github.com/users/hferentschik/received_events","type":"User","site_admin":false},"repo":{"id":1091354,"name":"hibernate-validator","full_name":"hferentschik/hibernate-validator","owner":{"login":"hferentschik","id":296354,"avatar_url":"https://avatars.githubusercontent.com/u/296354?v=2","gravatar_id":"","url":"https://api.github.com/users/hferentschik","html_url":"https://github.com/hferentschik","followers_url":"https://api.github.com/users/hferentschik/followers","following_url":"https://api.github.com/users/hferentschik/following{/other_user}","gists_url":"https://api.github.com/users/hferentschik/gists{/gist_id}","starred_url":"https://api.github.com/users/hferentschik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hferentschik/subscriptions","organizations_url":"https://api.github.com/users/hferentschik/orgs","repos_url":"https://api.github.com/users/hferentschik/repos","events_url":"https://api.github.com/users/hferentschik/events{/privacy}","received_events_url":"https://api.github.com/users/hferentschik/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hferentschik/hibernate-validator","description":"Hibernate Validator - Bean Validation (JSR 303) Reference Implementation","fork":true,"url":"https://api.github.com/repos/hferentschik/hibernate-validator","forks_url":"https://api.github.com/repos/hferentschik/hibernate-validator/forks","keys_url":"https://api.github.com/repos/hferentschik/hibernate-validator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hferentschik/hibernate-validator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hferentschik/hibernate-validator/teams","hooks_url":"https://api.github.com/repos/hferentschik/hibernate-validator/hooks","issue_events_url":"https://api.github.com/repos/hferentschik/hibernate-validator/issues/events{/number}","events_url":"https://api.github.com/repos/hferentschik/hibernate-validator/events","assignees_url":"https://api.github.com/repos/hferentschik/hibernate-validator/assignees{/user}","branches_url":"https://api.github.com/repos/hferentschik/hibernate-validator/branches{/branch}","tags_url":"https://api.github.com/repos/hferentschik/hibernate-validator/tags","blobs_url":"https://api.github.com/repos/hferentschik/hibernate-validator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hferentschik/hibernate-validator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hferentschik/hibernate-validator/git/refs{/sha}","trees_url":"https://api.github.com/repos/hferentschik/hibernate-validator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hferentschik/hibernate-validator/statuses/{sha}","languages_url":"https://api.github.com/repos/hferentschik/hibernate-validator/languages","stargazers_url":"https://api.github.com/repos/hferentschik/hibernate-validator/stargazers","contributors_url":"https://api.github.com/repos/hferentschik/hibernate-validator/contributors","subscribers_url":"https://api.github.com/repos/hferentschik/hibernate-validator/subscribers","subscription_url":"https://api.github.com/repos/hferentschik/hibernate-validator/subscription","commits_url":"https://api.github.com/repos/hferentschik/hibernate-validator/commits{/sha}","git_commits_url":"https://api.github.com/repos/hferentschik/hibernate-validator/git/commits{/sha}","comments_url":"https://api.github.com/repos/hferentschik/hibernate-validator/comments{/number}","issue_comment_url":"https://api.github.com/repos/hferentschik/hibernate-validator/issues/comments/{number}","contents_url":"https://api.github.com/repos/hferentschik/hibernate-validator/contents/{+path}","compare_url":"https://api.github.com/repos/hferentschik/hibernate-validator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hferentschik/hibernate-validator/merges","archive_url":"https://api.github.com/repos/hferentschik/hibernate-validator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hferentschik/hibernate-validator/downloads","issues_url":"https://api.github.com/repos/hferentschik/hibernate-validator/issues{/number}","pulls_url":"https://api.github.com/repos/hferentschik/hibernate-validator/pulls{/number}","milestones_url":"https://api.github.com/repos/hferentschik/hibernate-validator/milestones{/number}","notifications_url":"https://api.github.com/repos/hferentschik/hibernate-validator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hferentschik/hibernate-validator/labels{/name}","releases_url":"https://api.github.com/repos/hferentschik/hibernate-validator/releases{/id}","created_at":"2010-11-18T11:13:49Z","updated_at":"2014-06-30T11:22:15Z","pushed_at":"2014-10-21T19:32:11Z","git_url":"git://github.com/hferentschik/hibernate-validator.git","ssh_url":"git@github.com:hferentschik/hibernate-validator.git","clone_url":"https://github.com/hferentschik/hibernate-validator.git","svn_url":"https://github.com/hferentschik/hibernate-validator","homepage":"http://validator.hibernate.org/","size":20836,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":3,"default_branch":"master"}},"base":{"label":"hibernate:master","ref":"master","sha":"dfa65141d63cbfbb33f79522f6ba40a6d2b29b5c","user":{"login":"hibernate","id":348262,"avatar_url":"https://avatars.githubusercontent.com/u/348262?v=2","gravatar_id":"","url":"https://api.github.com/users/hibernate","html_url":"https://github.com/hibernate","followers_url":"https://api.github.com/users/hibernate/followers","following_url":"https://api.github.com/users/hibernate/following{/other_user}","gists_url":"https://api.github.com/users/hibernate/gists{/gist_id}","starred_url":"https://api.github.com/users/hibernate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hibernate/subscriptions","organizations_url":"https://api.github.com/users/hibernate/orgs","repos_url":"https://api.github.com/users/hibernate/repos","events_url":"https://api.github.com/users/hibernate/events{/privacy}","received_events_url":"https://api.github.com/users/hibernate/received_events","type":"Organization","site_admin":false},"repo":{"id":972205,"name":"hibernate-validator","full_name":"hibernate/hibernate-validator","owner":{"login":"hibernate","id":348262,"avatar_url":"https://avatars.githubusercontent.com/u/348262?v=2","gravatar_id":"","url":"https://api.github.com/users/hibernate","html_url":"https://github.com/hibernate","followers_url":"https://api.github.com/users/hibernate/followers","following_url":"https://api.github.com/users/hibernate/following{/other_user}","gists_url":"https://api.github.com/users/hibernate/gists{/gist_id}","starred_url":"https://api.github.com/users/hibernate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hibernate/subscriptions","organizations_url":"https://api.github.com/users/hibernate/orgs","repos_url":"https://api.github.com/users/hibernate/repos","events_url":"https://api.github.com/users/hibernate/events{/privacy}","received_events_url":"https://api.github.com/users/hibernate/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hibernate/hibernate-validator","description":"Hibernate Validator - Bean Validation 1.1 (JSR 349) Reference Implementation","fork":false,"url":"https://api.github.com/repos/hibernate/hibernate-validator","forks_url":"https://api.github.com/repos/hibernate/hibernate-validator/forks","keys_url":"https://api.github.com/repos/hibernate/hibernate-validator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hibernate/hibernate-validator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hibernate/hibernate-validator/teams","hooks_url":"https://api.github.com/repos/hibernate/hibernate-validator/hooks","issue_events_url":"https://api.github.com/repos/hibernate/hibernate-validator/issues/events{/number}","events_url":"https://api.github.com/repos/hibernate/hibernate-validator/events","assignees_url":"https://api.github.com/repos/hibernate/hibernate-validator/assignees{/user}","branches_url":"https://api.github.com/repos/hibernate/hibernate-validator/branches{/branch}","tags_url":"https://api.github.com/repos/hibernate/hibernate-validator/tags","blobs_url":"https://api.github.com/repos/hibernate/hibernate-validator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hibernate/hibernate-validator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hibernate/hibernate-validator/git/refs{/sha}","trees_url":"https://api.github.com/repos/hibernate/hibernate-validator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hibernate/hibernate-validator/statuses/{sha}","languages_url":"https://api.github.com/repos/hibernate/hibernate-validator/languages","stargazers_url":"https://api.github.com/repos/hibernate/hibernate-validator/stargazers","contributors_url":"https://api.github.com/repos/hibernate/hibernate-validator/contributors","subscribers_url":"https://api.github.com/repos/hibernate/hibernate-validator/subscribers","subscription_url":"https://api.github.com/repos/hibernate/hibernate-validator/subscription","commits_url":"https://api.github.com/repos/hibernate/hibernate-validator/commits{/sha}","git_commits_url":"https://api.github.com/repos/hibernate/hibernate-validator/git/commits{/sha}","comments_url":"https://api.github.com/repos/hibernate/hibernate-validator/comments{/number}","issue_comment_url":"https://api.github.com/repos/hibernate/hibernate-validator/issues/comments/{number}","contents_url":"https://api.github.com/repos/hibernate/hibernate-validator/contents/{+path}","compare_url":"https://api.github.com/repos/hibernate/hibernate-validator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hibernate/hibernate-validator/merges","archive_url":"https://api.github.com/repos/hibernate/hibernate-validator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hibernate/hibernate-validator/downloads","issues_url":"https://api.github.com/repos/hibernate/hibernate-validator/issues{/number}","pulls_url":"https://api.github.com/repos/hibernate/hibernate-validator/pulls{/number}","milestones_url":"https://api.github.com/repos/hibernate/hibernate-validator/milestones{/number}","notifications_url":"https://api.github.com/repos/hibernate/hibernate-validator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hibernate/hibernate-validator/labels{/name}","releases_url":"https://api.github.com/repos/hibernate/hibernate-validator/releases{/id}","created_at":"2010-10-08T13:25:07Z","updated_at":"2014-09-26T12:41:16Z","pushed_at":"2014-10-22T07:20:46Z","git_url":"git://github.com/hibernate/hibernate-validator.git","ssh_url":"git@github.com:hibernate/hibernate-validator.git","clone_url":"https://github.com/hibernate/hibernate-validator.git","svn_url":"https://github.com/hibernate/hibernate-validator","homepage":"http://validator.hibernate.org/","size":27672,"stargazers_count":123,"watchers_count":123,"language":"Java","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":83,"mirror_url":null,"open_issues_count":1,"forks":83,"open_issues":1,"watchers":123,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hibernate/hibernate-validator/pulls/355"},"html":{"href":"https://github.com/hibernate/hibernate-validator/pull/355"},"issue":{"href":"https://api.github.com/repos/hibernate/hibernate-validator/issues/355"},"comments":{"href":"https://api.github.com/repos/hibernate/hibernate-validator/issues/355/comments"},"review_comments":{"href":"https://api.github.com/repos/hibernate/hibernate-validator/pulls/355/comments"},"review_comment":{"href":"https://api.github.com/repos/hibernate/hibernate-validator/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/hibernate/hibernate-validator/pulls/355/commits"},"statuses":{"href":"https://api.github.com/repos/hibernate/hibernate-validator/statuses/4b68bc7ea9acdd14c5ff3ecfd98233f7b70618c2"}}}}