GitHub PullRequestEvent at 2014-10-10 14:09:08
Repository: wp-super-cache
Actor: kraftbj
Payload: {"action":"closed","number":15,"pull_request":{"url":"https://api.github.com/repos/Automattic/wp-super-cache/pulls/15","id":21478831,"html_url":"https://github.com/Automattic/wp-super-cache/pull/15","diff_url":"https://github.com/Automattic/wp-super-cache/pull/15.diff","patch_url":"https://github.com/Automattic/wp-super-cache/pull/15.patch","issue_url":"https://api.github.com/repos/Automattic/wp-super-cache/issues/15","number":15,"state":"closed","locked":false,"title":"Refactoring wp_cache_debug ","user":{"login":"jenheilemann","id":819242,"avatar_url":"https://avatars.githubusercontent.com/u/819242?v=2","gravatar_id":"","url":"https://api.github.com/users/jenheilemann","html_url":"https://github.com/jenheilemann","followers_url":"https://api.github.com/users/jenheilemann/followers","following_url":"https://api.github.com/users/jenheilemann/following{/other_user}","gists_url":"https://api.github.com/users/jenheilemann/gists{/gist_id}","starred_url":"https://api.github.com/users/jenheilemann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenheilemann/subscriptions","organizations_url":"https://api.github.com/users/jenheilemann/orgs","repos_url":"https://api.github.com/users/jenheilemann/repos","events_url":"https://api.github.com/users/jenheilemann/events{/privacy}","received_events_url":"https://api.github.com/users/jenheilemann/received_events","type":"User","site_admin":false},"body":"Hi Brandon and related peeps!\r\n\r\nI was poking around in the code for this project today and noticed that there are a ton of places where the wp_cache_debug function is wrapped in checks against the global array, when the function itself checks whether debugging is enabled. \r\n\r\nTell me if this is a horrible PR, this is my first! :sweat: ","created_at":"2014-09-19T05:35:17Z","updated_at":"2014-10-10T14:09:08Z","closed_at":"2014-10-10T14:09:08Z","merged_at":null,"merge_commit_sha":"85a218d63fae02791d01fc839cca54f386524b3f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Automattic/wp-super-cache/pulls/15/commits","review_comments_url":"https://api.github.com/repos/Automattic/wp-super-cache/pulls/15/comments","review_comment_url":"https://api.github.com/repos/Automattic/wp-super-cache/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Automattic/wp-super-cache/issues/15/comments","statuses_url":"https://api.github.com/repos/Automattic/wp-super-cache/statuses/cc1526e653bc87bedfbd7bc6bd653f5b7d02c328","head":{"label":"jenheilemann:master","ref":"master","sha":"cc1526e653bc87bedfbd7bc6bd653f5b7d02c328","user":{"login":"jenheilemann","id":819242,"avatar_url":"https://avatars.githubusercontent.com/u/819242?v=2","gravatar_id":"","url":"https://api.github.com/users/jenheilemann","html_url":"https://github.com/jenheilemann","followers_url":"https://api.github.com/users/jenheilemann/followers","following_url":"https://api.github.com/users/jenheilemann/following{/other_user}","gists_url":"https://api.github.com/users/jenheilemann/gists{/gist_id}","starred_url":"https://api.github.com/users/jenheilemann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenheilemann/subscriptions","organizations_url":"https://api.github.com/users/jenheilemann/orgs","repos_url":"https://api.github.com/users/jenheilemann/repos","events_url":"https://api.github.com/users/jenheilemann/events{/privacy}","received_events_url":"https://api.github.com/users/jenheilemann/received_events","type":"User","site_admin":false},"repo":{"id":24210765,"name":"wp-super-cache","full_name":"jenheilemann/wp-super-cache","owner":{"login":"jenheilemann","id":819242,"avatar_url":"https://avatars.githubusercontent.com/u/819242?v=2","gravatar_id":"","url":"https://api.github.com/users/jenheilemann","html_url":"https://github.com/jenheilemann","followers_url":"https://api.github.com/users/jenheilemann/followers","following_url":"https://api.github.com/users/jenheilemann/following{/other_user}","gists_url":"https://api.github.com/users/jenheilemann/gists{/gist_id}","starred_url":"https://api.github.com/users/jenheilemann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenheilemann/subscriptions","organizations_url":"https://api.github.com/users/jenheilemann/orgs","repos_url":"https://api.github.com/users/jenheilemann/repos","events_url":"https://api.github.com/users/jenheilemann/events{/privacy}","received_events_url":"https://api.github.com/users/jenheilemann/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jenheilemann/wp-super-cache","description":"http://wordpress.org/plugins/wp-super-cache/","fork":true,"url":"https://api.github.com/repos/jenheilemann/wp-super-cache","forks_url":"https://api.github.com/repos/jenheilemann/wp-super-cache/forks","keys_url":"https://api.github.com/repos/jenheilemann/wp-super-cache/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenheilemann/wp-super-cache/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenheilemann/wp-super-cache/teams","hooks_url":"https://api.github.com/repos/jenheilemann/wp-super-cache/hooks","issue_events_url":"https://api.github.com/repos/jenheilemann/wp-super-cache/issues/events{/number}","events_url":"https://api.github.com/repos/jenheilemann/wp-super-cache/events","assignees_url":"https://api.github.com/repos/jenheilemann/wp-super-cache/assignees{/user}","branches_url":"https://api.github.com/repos/jenheilemann/wp-super-cache/branches{/branch}","tags_url":"https://api.github.com/repos/jenheilemann/wp-super-cache/tags","blobs_url":"https://api.github.com/repos/jenheilemann/wp-super-cache/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenheilemann/wp-super-cache/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenheilemann/wp-super-cache/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenheilemann/wp-super-cache/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenheilemann/wp-super-cache/statuses/{sha}","languages_url":"https://api.github.com/repos/jenheilemann/wp-super-cache/languages","stargazers_url":"https://api.github.com/repos/jenheilemann/wp-super-cache/stargazers","contributors_url":"https://api.github.com/repos/jenheilemann/wp-super-cache/contributors","subscribers_url":"https://api.github.com/repos/jenheilemann/wp-super-cache/subscribers","subscription_url":"https://api.github.com/repos/jenheilemann/wp-super-cache/subscription","commits_url":"https://api.github.com/repos/jenheilemann/wp-super-cache/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenheilemann/wp-super-cache/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenheilemann/wp-super-cache/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenheilemann/wp-super-cache/issues/comments/{number}","contents_url":"https://api.github.com/repos/jenheilemann/wp-super-cache/contents/{+path}","compare_url":"https://api.github.com/repos/jenheilemann/wp-super-cache/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenheilemann/wp-super-cache/merges","archive_url":"https://api.github.com/repos/jenheilemann/wp-super-cache/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenheilemann/wp-super-cache/downloads","issues_url":"https://api.github.com/repos/jenheilemann/wp-super-cache/issues{/number}","pulls_url":"https://api.github.com/repos/jenheilemann/wp-super-cache/pulls{/number}","milestones_url":"https://api.github.com/repos/jenheilemann/wp-super-cache/milestones{/number}","notifications_url":"https://api.github.com/repos/jenheilemann/wp-super-cache/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenheilemann/wp-super-cache/labels{/name}","releases_url":"https://api.github.com/repos/jenheilemann/wp-super-cache/releases{/id}","created_at":"2014-09-19T00:56:12Z","updated_at":"2014-09-19T04:51:41Z","pushed_at":"2014-09-19T05:27:41Z","git_url":"git://github.com/jenheilemann/wp-super-cache.git","ssh_url":"git@github.com:jenheilemann/wp-super-cache.git","clone_url":"https://github.com/jenheilemann/wp-super-cache.git","svn_url":"https://github.com/jenheilemann/wp-super-cache","homepage":null,"size":1865,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Automattic:master","ref":"master","sha":"28365c62c24815f8a7fd5485cf2545019ee26c5d","user":{"login":"Automattic","id":887802,"avatar_url":"https://avatars.githubusercontent.com/u/887802?v=2","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"repo":{"id":21128555,"name":"wp-super-cache","full_name":"Automattic/wp-super-cache","owner":{"login":"Automattic","id":887802,"avatar_url":"https://avatars.githubusercontent.com/u/887802?v=2","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Automattic/wp-super-cache","description":"http://wordpress.org/plugins/wp-super-cache/","fork":false,"url":"https://api.github.com/repos/Automattic/wp-super-cache","forks_url":"https://api.github.com/repos/Automattic/wp-super-cache/forks","keys_url":"https://api.github.com/repos/Automattic/wp-super-cache/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Automattic/wp-super-cache/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Automattic/wp-super-cache/teams","hooks_url":"https://api.github.com/repos/Automattic/wp-super-cache/hooks","issue_events_url":"https://api.github.com/repos/Automattic/wp-super-cache/issues/events{/number}","events_url":"https://api.github.com/repos/Automattic/wp-super-cache/events","assignees_url":"https://api.github.com/repos/Automattic/wp-super-cache/assignees{/user}","branches_url":"https://api.github.com/repos/Automattic/wp-super-cache/branches{/branch}","tags_url":"https://api.github.com/repos/Automattic/wp-super-cache/tags","blobs_url":"https://api.github.com/repos/Automattic/wp-super-cache/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Automattic/wp-super-cache/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Automattic/wp-super-cache/git/refs{/sha}","trees_url":"https://api.github.com/repos/Automattic/wp-super-cache/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Automattic/wp-super-cache/statuses/{sha}","languages_url":"https://api.github.com/repos/Automattic/wp-super-cache/languages","stargazers_url":"https://api.github.com/repos/Automattic/wp-super-cache/stargazers","contributors_url":"https://api.github.com/repos/Automattic/wp-super-cache/contributors","subscribers_url":"https://api.github.com/repos/Automattic/wp-super-cache/subscribers","subscription_url":"https://api.github.com/repos/Automattic/wp-super-cache/subscription","commits_url":"https://api.github.com/repos/Automattic/wp-super-cache/commits{/sha}","git_commits_url":"https://api.github.com/repos/Automattic/wp-super-cache/git/commits{/sha}","comments_url":"https://api.github.com/repos/Automattic/wp-super-cache/comments{/number}","issue_comment_url":"https://api.github.com/repos/Automattic/wp-super-cache/issues/comments/{number}","contents_url":"https://api.github.com/repos/Automattic/wp-super-cache/contents/{+path}","compare_url":"https://api.github.com/repos/Automattic/wp-super-cache/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Automattic/wp-super-cache/merges","archive_url":"https://api.github.com/repos/Automattic/wp-super-cache/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Automattic/wp-super-cache/downloads","issues_url":"https://api.github.com/repos/Automattic/wp-super-cache/issues{/number}","pulls_url":"https://api.github.com/repos/Automattic/wp-super-cache/pulls{/number}","milestones_url":"https://api.github.com/repos/Automattic/wp-super-cache/milestones{/number}","notifications_url":"https://api.github.com/repos/Automattic/wp-super-cache/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Automattic/wp-super-cache/labels{/name}","releases_url":"https://api.github.com/repos/Automattic/wp-super-cache/releases{/id}","created_at":"2014-06-23T14:08:58Z","updated_at":"2014-09-25T04:29:45Z","pushed_at":"2014-10-10T14:07:54Z","git_url":"git://github.com/Automattic/wp-super-cache.git","ssh_url":"git@github.com:Automattic/wp-super-cache.git","clone_url":"https://github.com/Automattic/wp-super-cache.git","svn_url":"https://github.com/Automattic/wp-super-cache","homepage":null,"size":2693,"stargazers_count":11,"watchers_count":11,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":12,"forks":4,"open_issues":12,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Automattic/wp-super-cache/pulls/15"},"html":{"href":"https://github.com/Automattic/wp-super-cache/pull/15"},"issue":{"href":"https://api.github.com/repos/Automattic/wp-super-cache/issues/15"},"comments":{"href":"https://api.github.com/repos/Automattic/wp-super-cache/issues/15/comments"},"review_comments":{"href":"https://api.github.com/repos/Automattic/wp-super-cache/pulls/15/comments"},"review_comment":{"href":"https://api.github.com/repos/Automattic/wp-super-cache/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Automattic/wp-super-cache/pulls/15/commits"},"statuses":{"href":"https://api.github.com/repos/Automattic/wp-super-cache/statuses/cc1526e653bc87bedfbd7bc6bd653f5b7d02c328"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":2,"review_comments":0,"commits":18,"additions":248,"deletions":234,"changed_files":9}}