GitHub PullRequestReviewCommentEvent at 2014-11-18 21:45:47
Repository: ocaml-benchmark
Actor: Chris00
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/Chris00/ocaml-benchmark/pulls/comments/20540898","id":20540898,"diff_hunk":"@@ -228,3 +228,103 @@ val tabulate : ?no_parent:bool -> ?confidence:float -> samples -> unit\n     @param confidence is used to determine the confidence interval for\n     the Student's test.  (default: [0.95]).  *)\n \n+(** {2 Benchmark Tree}\n+\n+Naming benchmarks within a hierarchy that allows to run them all, or\n+filter them so that only a subset is run *)\n+\n+module Tree : sig\n+  type t\n+  (** A tree of benchmarks. Leaves are individual benchmarks (calls\n+      to {!throughputN}, {!latencyN}, etc. wrapped\n+      with {!(>:)}), nodes are annotated with strings,\n+      and paths (see {!path}) are used to select subtrees. *)\n+\n+  val (>:) : string -> (unit -> samples) Lazy.t -> t","path":"benchmark.mli","position":16,"original_position":16,"commit_id":"8ebd4d5e91f7cd5ea2eddfb770e12ca8cf63172c","original_commit_id":"8ebd4d5e91f7cd5ea2eddfb770e12ca8cf63172c","user":{"login":"Chris00","id":1255665,"avatar_url":"https://avatars.githubusercontent.com/u/1255665?v=3","gravatar_id":"","url":"https://api.github.com/users/Chris00","html_url":"https://github.com/Chris00","followers_url":"https://api.github.com/users/Chris00/followers","following_url":"https://api.github.com/users/Chris00/following{/other_user}","gists_url":"https://api.github.com/users/Chris00/gists{/gist_id}","starred_url":"https://api.github.com/users/Chris00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Chris00/subscriptions","organizations_url":"https://api.github.com/users/Chris00/orgs","repos_url":"https://api.github.com/users/Chris00/repos","events_url":"https://api.github.com/users/Chris00/events{/privacy}","received_events_url":"https://api.github.com/users/Chris00/received_events","type":"User","site_admin":false},"body":"Could you please explain why `(unit -> samples) Lazy.t` and not `samples Lazy.t`?  Is it because you want to rerun the same test several times?  If so, `unit -> samples` is enough (and once run, it is the job of the functions of `Tree` to keep the `samples` as needed).","created_at":"2014-11-18T21:45:47Z","updated_at":"2014-11-18T21:45:47Z","html_url":"https://github.com/Chris00/ocaml-benchmark/pull/5#discussion_r20540898","pull_request_url":"https://api.github.com/repos/Chris00/ocaml-benchmark/pulls/5","_links":{"self":{"href":"https://api.github.com/repos/Chris00/ocaml-benchmark/pulls/comments/20540898"},"html":{"href":"https://github.com/Chris00/ocaml-benchmark/pull/5#discussion_r20540898"},"pull_request":{"href":"https://api.github.com/repos/Chris00/ocaml-benchmark/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/Chris00/ocaml-benchmark/pulls/5","id":24405924,"html_url":"https://github.com/Chris00/ocaml-benchmark/pull/5","diff_url":"https://github.com/Chris00/ocaml-benchmark/pull/5.diff","patch_url":"https://github.com/Chris00/ocaml-benchmark/pull/5.patch","issue_url":"https://api.github.com/repos/Chris00/ocaml-benchmark/issues/5","number":5,"state":"open","locked":false,"title":"add a tree-like system to run sets of benchmarks","user":{"login":"c-cube","id":1274291,"avatar_url":"https://avatars.githubusercontent.com/u/1274291?v=3","gravatar_id":"","url":"https://api.github.com/users/c-cube","html_url":"https://github.com/c-cube","followers_url":"https://api.github.com/users/c-cube/followers","following_url":"https://api.github.com/users/c-cube/following{/other_user}","gists_url":"https://api.github.com/users/c-cube/gists{/gist_id}","starred_url":"https://api.github.com/users/c-cube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/c-cube/subscriptions","organizations_url":"https://api.github.com/users/c-cube/orgs","repos_url":"https://api.github.com/users/c-cube/repos","events_url":"https://api.github.com/users/c-cube/events{/privacy}","received_events_url":"https://api.github.com/users/c-cube/received_events","type":"User","site_admin":false},"body":"A system a bit similar to `OUnit`, with the ability to select only a subset of the benchmarks to run them. As each benchmark can take a significant time, it is convenient to be able to run only the ones that are relevant to some function, say, if we are trying to improve this function's performance.\r\n\r\nThere is also a small patch to `_oasis` because it wouldn't compile with a recent version of `oasis` otherwise. ","created_at":"2014-11-13T22:26:52Z","updated_at":"2014-11-18T21:45:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e1fa8a760616283788a370be6093d2b94bf54f02","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Chris00/ocaml-benchmark/pulls/5/commits","review_comments_url":"https://api.github.com/repos/Chris00/ocaml-benchmark/pulls/5/comments","review_comment_url":"https://api.github.com/repos/Chris00/ocaml-benchmark/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Chris00/ocaml-benchmark/issues/5/comments","statuses_url":"https://api.github.com/repos/Chris00/ocaml-benchmark/statuses/8ebd4d5e91f7cd5ea2eddfb770e12ca8cf63172c","head":{"label":"c-cube:master","ref":"master","sha":"8ebd4d5e91f7cd5ea2eddfb770e12ca8cf63172c","user":{"login":"c-cube","id":1274291,"avatar_url":"https://avatars.githubusercontent.com/u/1274291?v=3","gravatar_id":"","url":"https://api.github.com/users/c-cube","html_url":"https://github.com/c-cube","followers_url":"https://api.github.com/users/c-cube/followers","following_url":"https://api.github.com/users/c-cube/following{/other_user}","gists_url":"https://api.github.com/users/c-cube/gists{/gist_id}","starred_url":"https://api.github.com/users/c-cube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/c-cube/subscriptions","organizations_url":"https://api.github.com/users/c-cube/orgs","repos_url":"https://api.github.com/users/c-cube/repos","events_url":"https://api.github.com/users/c-cube/events{/privacy}","received_events_url":"https://api.github.com/users/c-cube/received_events","type":"User","site_admin":false},"repo":{"id":26609223,"name":"ocaml-benchmark","full_name":"c-cube/ocaml-benchmark","owner":{"login":"c-cube","id":1274291,"avatar_url":"https://avatars.githubusercontent.com/u/1274291?v=3","gravatar_id":"","url":"https://api.github.com/users/c-cube","html_url":"https://github.com/c-cube","followers_url":"https://api.github.com/users/c-cube/followers","following_url":"https://api.github.com/users/c-cube/following{/other_user}","gists_url":"https://api.github.com/users/c-cube/gists{/gist_id}","starred_url":"https://api.github.com/users/c-cube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/c-cube/subscriptions","organizations_url":"https://api.github.com/users/c-cube/orgs","repos_url":"https://api.github.com/users/c-cube/repos","events_url":"https://api.github.com/users/c-cube/events{/privacy}","received_events_url":"https://api.github.com/users/c-cube/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/c-cube/ocaml-benchmark","description":"Benchmarking module for OCaml","fork":true,"url":"https://api.github.com/repos/c-cube/ocaml-benchmark","forks_url":"https://api.github.com/repos/c-cube/ocaml-benchmark/forks","keys_url":"https://api.github.com/repos/c-cube/ocaml-benchmark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/c-cube/ocaml-benchmark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/c-cube/ocaml-benchmark/teams","hooks_url":"https://api.github.com/repos/c-cube/ocaml-benchmark/hooks","issue_events_url":"https://api.github.com/repos/c-cube/ocaml-benchmark/issues/events{/number}","events_url":"https://api.github.com/repos/c-cube/ocaml-benchmark/events","assignees_url":"https://api.github.com/repos/c-cube/ocaml-benchmark/assignees{/user}","branches_url":"https://api.github.com/repos/c-cube/ocaml-benchmark/branches{/branch}","tags_url":"https://api.github.com/repos/c-cube/ocaml-benchmark/tags","blobs_url":"https://api.github.com/repos/c-cube/ocaml-benchmark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/c-cube/ocaml-benchmark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/c-cube/ocaml-benchmark/git/refs{/sha}","trees_url":"https://api.github.com/repos/c-cube/ocaml-benchmark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/c-cube/ocaml-benchmark/statuses/{sha}","languages_url":"https://api.github.com/repos/c-cube/ocaml-benchmark/languages","stargazers_url":"https://api.github.com/repos/c-cube/ocaml-benchmark/stargazers","contributors_url":"https://api.github.com/repos/c-cube/ocaml-benchmark/contributors","subscribers_url":"https://api.github.com/repos/c-cube/ocaml-benchmark/subscribers","subscription_url":"https://api.github.com/repos/c-cube/ocaml-benchmark/subscription","commits_url":"https://api.github.com/repos/c-cube/ocaml-benchmark/commits{/sha}","git_commits_url":"https://api.github.com/repos/c-cube/ocaml-benchmark/git/commits{/sha}","comments_url":"https://api.github.com/repos/c-cube/ocaml-benchmark/comments{/number}","issue_comment_url":"https://api.github.com/repos/c-cube/ocaml-benchmark/issues/comments/{number}","contents_url":"https://api.github.com/repos/c-cube/ocaml-benchmark/contents/{+path}","compare_url":"https://api.github.com/repos/c-cube/ocaml-benchmark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/c-cube/ocaml-benchmark/merges","archive_url":"https://api.github.com/repos/c-cube/ocaml-benchmark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/c-cube/ocaml-benchmark/downloads","issues_url":"https://api.github.com/repos/c-cube/ocaml-benchmark/issues{/number}","pulls_url":"https://api.github.com/repos/c-cube/ocaml-benchmark/pulls{/number}","milestones_url":"https://api.github.com/repos/c-cube/ocaml-benchmark/milestones{/number}","notifications_url":"https://api.github.com/repos/c-cube/ocaml-benchmark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/c-cube/ocaml-benchmark/labels{/name}","releases_url":"https://api.github.com/repos/c-cube/ocaml-benchmark/releases{/id}","created_at":"2014-11-13T21:36:47Z","updated_at":"2014-11-18T20:40:19Z","pushed_at":"2014-11-18T20:40:19Z","git_url":"git://github.com/c-cube/ocaml-benchmark.git","ssh_url":"git@github.com:c-cube/ocaml-benchmark.git","clone_url":"https://github.com/c-cube/ocaml-benchmark.git","svn_url":"https://github.com/c-cube/ocaml-benchmark","homepage":null,"size":211,"stargazers_count":0,"watchers_count":0,"language":"OCaml","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Chris00:master","ref":"master","sha":"ef2e48f1e9f74bb9a085cc7c22a873bf1e62d1d8","user":{"login":"Chris00","id":1255665,"avatar_url":"https://avatars.githubusercontent.com/u/1255665?v=3","gravatar_id":"","url":"https://api.github.com/users/Chris00","html_url":"https://github.com/Chris00","followers_url":"https://api.github.com/users/Chris00/followers","following_url":"https://api.github.com/users/Chris00/following{/other_user}","gists_url":"https://api.github.com/users/Chris00/gists{/gist_id}","starred_url":"https://api.github.com/users/Chris00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Chris00/subscriptions","organizations_url":"https://api.github.com/users/Chris00/orgs","repos_url":"https://api.github.com/users/Chris00/repos","events_url":"https://api.github.com/users/Chris00/events{/privacy}","received_events_url":"https://api.github.com/users/Chris00/received_events","type":"User","site_admin":false},"repo":{"id":5859706,"name":"ocaml-benchmark","full_name":"Chris00/ocaml-benchmark","owner":{"login":"Chris00","id":1255665,"avatar_url":"https://avatars.githubusercontent.com/u/1255665?v=3","gravatar_id":"","url":"https://api.github.com/users/Chris00","html_url":"https://github.com/Chris00","followers_url":"https://api.github.com/users/Chris00/followers","following_url":"https://api.github.com/users/Chris00/following{/other_user}","gists_url":"https://api.github.com/users/Chris00/gists{/gist_id}","starred_url":"https://api.github.com/users/Chris00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Chris00/subscriptions","organizations_url":"https://api.github.com/users/Chris00/orgs","repos_url":"https://api.github.com/users/Chris00/repos","events_url":"https://api.github.com/users/Chris00/events{/privacy}","received_events_url":"https://api.github.com/users/Chris00/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Chris00/ocaml-benchmark","description":"Benchmarking module for OCaml","fork":false,"url":"https://api.github.com/repos/Chris00/ocaml-benchmark","forks_url":"https://api.github.com/repos/Chris00/ocaml-benchmark/forks","keys_url":"https://api.github.com/repos/Chris00/ocaml-benchmark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Chris00/ocaml-benchmark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Chris00/ocaml-benchmark/teams","hooks_url":"https://api.github.com/repos/Chris00/ocaml-benchmark/hooks","issue_events_url":"https://api.github.com/repos/Chris00/ocaml-benchmark/issues/events{/number}","events_url":"https://api.github.com/repos/Chris00/ocaml-benchmark/events","assignees_url":"https://api.github.com/repos/Chris00/ocaml-benchmark/assignees{/user}","branches_url":"https://api.github.com/repos/Chris00/ocaml-benchmark/branches{/branch}","tags_url":"https://api.github.com/repos/Chris00/ocaml-benchmark/tags","blobs_url":"https://api.github.com/repos/Chris00/ocaml-benchmark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Chris00/ocaml-benchmark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Chris00/ocaml-benchmark/git/refs{/sha}","trees_url":"https://api.github.com/repos/Chris00/ocaml-benchmark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Chris00/ocaml-benchmark/statuses/{sha}","languages_url":"https://api.github.com/repos/Chris00/ocaml-benchmark/languages","stargazers_url":"https://api.github.com/repos/Chris00/ocaml-benchmark/stargazers","contributors_url":"https://api.github.com/repos/Chris00/ocaml-benchmark/contributors","subscribers_url":"https://api.github.com/repos/Chris00/ocaml-benchmark/subscribers","subscription_url":"https://api.github.com/repos/Chris00/ocaml-benchmark/subscription","commits_url":"https://api.github.com/repos/Chris00/ocaml-benchmark/commits{/sha}","git_commits_url":"https://api.github.com/repos/Chris00/ocaml-benchmark/git/commits{/sha}","comments_url":"https://api.github.com/repos/Chris00/ocaml-benchmark/comments{/number}","issue_comment_url":"https://api.github.com/repos/Chris00/ocaml-benchmark/issues/comments/{number}","contents_url":"https://api.github.com/repos/Chris00/ocaml-benchmark/contents/{+path}","compare_url":"https://api.github.com/repos/Chris00/ocaml-benchmark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Chris00/ocaml-benchmark/merges","archive_url":"https://api.github.com/repos/Chris00/ocaml-benchmark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Chris00/ocaml-benchmark/downloads","issues_url":"https://api.github.com/repos/Chris00/ocaml-benchmark/issues{/number}","pulls_url":"https://api.github.com/repos/Chris00/ocaml-benchmark/pulls{/number}","milestones_url":"https://api.github.com/repos/Chris00/ocaml-benchmark/milestones{/number}","notifications_url":"https://api.github.com/repos/Chris00/ocaml-benchmark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Chris00/ocaml-benchmark/labels{/name}","releases_url":"https://api.github.com/repos/Chris00/ocaml-benchmark/releases{/id}","created_at":"2012-09-18T16:59:12Z","updated_at":"2014-11-18T16:57:00Z","pushed_at":"2014-09-08T10:44:15Z","git_url":"git://github.com/Chris00/ocaml-benchmark.git","ssh_url":"git@github.com:Chris00/ocaml-benchmark.git","clone_url":"https://github.com/Chris00/ocaml-benchmark.git","svn_url":"https://github.com/Chris00/ocaml-benchmark","homepage":null,"size":257,"stargazers_count":12,"watchers_count":12,"language":"OCaml","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":1,"forks":4,"open_issues":1,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Chris00/ocaml-benchmark/pulls/5"},"html":{"href":"https://github.com/Chris00/ocaml-benchmark/pull/5"},"issue":{"href":"https://api.github.com/repos/Chris00/ocaml-benchmark/issues/5"},"comments":{"href":"https://api.github.com/repos/Chris00/ocaml-benchmark/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/Chris00/ocaml-benchmark/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/Chris00/ocaml-benchmark/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Chris00/ocaml-benchmark/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/Chris00/ocaml-benchmark/statuses/8ebd4d5e91f7cd5ea2eddfb770e12ca8cf63172c"}}}}