GitHub PullRequestReviewCommentEvent at 2014-04-02 17:18:32
Repository: spark
Actor: velvia
Payload: {"comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/11216177","id":11216177,"diff_hunk":"@@ -767,6 +781,20 @@ class SparkContext(\n           case _ =>\n             path\n         }\n+\n+        // Add jar to driver class loader so it is available for driver,\n+        // even if it is not on the classpath\n+        uri.getScheme match {\n+          case null | \"file\" | \"local\" =>\n+            // Assume file exists on current (driver) node as well.  Unlike executors, driver\n+            // doesn't need to download the jar since it's local.\n+            addUrlToDriverLoader(new URL(\"file:\" + uri.getPath))\n+          case \"http\" | \"https\" | \"ftp\" =>\n+            // Should be handled by the URLClassLoader, pass along entire URL\n+            addUrlToDriverLoader(new URL(path))\n+          case other =>\n+            logWarning(s\"This URI scheme for URI $path is not supported by the driver class loader\")","path":"core/src/main/scala/org/apache/spark/SparkContext.scala","position":62,"original_position":62,"commit_id":"9637d2110b4566e6f5db1ee67feb8c8ce3837e7a","original_commit_id":"9637d2110b4566e6f5db1ee67feb8c8ce3837e7a","user":{"login":"velvia","id":1062875,"avatar_url":"https://avatars.githubusercontent.com/u/1062875?","gravatar_id":"ff98cf6f84857684c813d81c7a40b12a","url":"https://api.github.com/users/velvia","html_url":"https://github.com/velvia","followers_url":"https://api.github.com/users/velvia/followers","following_url":"https://api.github.com/users/velvia/following{/other_user}","gists_url":"https://api.github.com/users/velvia/gists{/gist_id}","starred_url":"https://api.github.com/users/velvia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/velvia/subscriptions","organizations_url":"https://api.github.com/users/velvia/orgs","repos_url":"https://api.github.com/users/velvia/repos","events_url":"https://api.github.com/users/velvia/events{/privacy}","received_events_url":"https://api.github.com/users/velvia/received_events","type":"User","site_admin":false},"body":"Yes true.  At the minimum will replace with an exception.","created_at":"2014-04-02T17:18:32Z","updated_at":"2014-04-02T17:18:32Z","html_url":"https://github.com/apache/spark/pull/119#discussion_r11216177","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/119","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/11216177"},"html":{"href":"https://github.com/apache/spark/pull/119#discussion_r11216177"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/119"}}}}