GitHub PullRequestReviewCommentEvent at 2014-12-14 20:43:59
Repository: mapstruct
Actor: sjaakd
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/mapstruct/mapstruct/pulls/comments/21799217","id":21799217,"diff_hunk":"@@ -0,0 +1,29 @@\n+/**\n+ *  Copyright 2012-2014 Gunnar Morling (http://www.gunnarmorling.de/)\n+ *  and/or other contributors as indicated by the @authors tag. See the\n+ *  copyright.txt file in the distribution for a full listing of all\n+ *  contributors.\n+ *\n+ *  Licensed under the Apache License, Version 2.0 (the \"License\");\n+ *  you may not use this file except in compliance with the License.\n+ *  You may obtain a copy of the License at\n+ *\n+ *      http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ *  Unless required by applicable law or agreed to in writing, software\n+ *  distributed under the License is distributed on an \"AS IS\" BASIS,\n+ *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ *  See the License for the specific language governing permissions and\n+ *  limitations under the License.\n+ */\n+package org.mapstruct.ap.test.inheretedmappingmethod;","path":"processor/src/test/java/org/mapstruct/ap/test/inheretedmappingmethod/BoundMappable.java","position":19,"original_position":19,"commit_id":"1fc4a0f20cd42c392b28d80b1ca3784775f33ddd","original_commit_id":"1fc4a0f20cd42c392b28d80b1ca3784775f33ddd","user":{"login":"sjaakd","id":6173283,"avatar_url":"https://avatars.githubusercontent.com/u/6173283?v=3","gravatar_id":"","url":"https://api.github.com/users/sjaakd","html_url":"https://github.com/sjaakd","followers_url":"https://api.github.com/users/sjaakd/followers","following_url":"https://api.github.com/users/sjaakd/following{/other_user}","gists_url":"https://api.github.com/users/sjaakd/gists{/gist_id}","starred_url":"https://api.github.com/users/sjaakd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjaakd/subscriptions","organizations_url":"https://api.github.com/users/sjaakd/orgs","repos_url":"https://api.github.com/users/sjaakd/repos","events_url":"https://api.github.com/users/sjaakd/events{/privacy}","received_events_url":"https://api.github.com/users/sjaakd/received_events","type":"User","site_admin":false},"body":"> I will make my corrections, squash my commits and provide a new pull request, right?\r\n\r\nYou only have one commit? right? You can always amend to the last commit (if you do did not create a new one yet). Otherwise, you can indeed squash your commits into one and push again.\r\n\r\n---\r\n\r\nNote: normally you create  a new branch, for instance with the issue number (without the hash). You can then update your master branch (so: git pull upstream master), checkout you issue branch and rebase to the master.\r\n\r\nThis Git stuff is a bit daunting in the beginning. I'm also using it since only about a year. But I started to appreciate it.\r\n\r\n","created_at":"2014-12-14T20:43:59Z","updated_at":"2014-12-14T20:43:59Z","html_url":"https://github.com/mapstruct/mapstruct/pull/379#discussion_r21799217","pull_request_url":"https://api.github.com/repos/mapstruct/mapstruct/pulls/379","_links":{"self":{"href":"https://api.github.com/repos/mapstruct/mapstruct/pulls/comments/21799217"},"html":{"href":"https://github.com/mapstruct/mapstruct/pull/379#discussion_r21799217"},"pull_request":{"href":"https://api.github.com/repos/mapstruct/mapstruct/pulls/379"}}},"pull_request":{"url":"https://api.github.com/repos/mapstruct/mapstruct/pulls/379","id":25702989,"html_url":"https://github.com/mapstruct/mapstruct/pull/379","diff_url":"https://github.com/mapstruct/mapstruct/pull/379.diff","patch_url":"https://github.com/mapstruct/mapstruct/pull/379.patch","issue_url":"https://api.github.com/repos/mapstruct/mapstruct/issues/379","number":379,"state":"open","locked":false,"title":"#274 Evaluate explicite types of method parameters and return types using...","user":{"login":"eforest","id":6786326,"avatar_url":"https://avatars.githubusercontent.com/u/6786326?v=3","gravatar_id":"","url":"https://api.github.com/users/eforest","html_url":"https://github.com/eforest","followers_url":"https://api.github.com/users/eforest/followers","following_url":"https://api.github.com/users/eforest/following{/other_user}","gists_url":"https://api.github.com/users/eforest/gists{/gist_id}","starred_url":"https://api.github.com/users/eforest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eforest/subscriptions","organizations_url":"https://api.github.com/users/eforest/orgs","repos_url":"https://api.github.com/users/eforest/repos","events_url":"https://api.github.com/users/eforest/events{/privacy}","received_events_url":"https://api.github.com/users/eforest/received_events","type":"User","site_admin":false},"body":"#274 Evaluate explicite types of method parameters and return types using Types#asMemberOf","created_at":"2014-12-08T22:28:05Z","updated_at":"2014-12-14T20:43:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7440836583d14b414cbdf88699dcd8fcd5372358","assignee":{"login":"agudian","id":2737102,"avatar_url":"https://avatars.githubusercontent.com/u/2737102?v=3","gravatar_id":"","url":"https://api.github.com/users/agudian","html_url":"https://github.com/agudian","followers_url":"https://api.github.com/users/agudian/followers","following_url":"https://api.github.com/users/agudian/following{/other_user}","gists_url":"https://api.github.com/users/agudian/gists{/gist_id}","starred_url":"https://api.github.com/users/agudian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agudian/subscriptions","organizations_url":"https://api.github.com/users/agudian/orgs","repos_url":"https://api.github.com/users/agudian/repos","events_url":"https://api.github.com/users/agudian/events{/privacy}","received_events_url":"https://api.github.com/users/agudian/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/mapstruct/mapstruct/pulls/379/commits","review_comments_url":"https://api.github.com/repos/mapstruct/mapstruct/pulls/379/comments","review_comment_url":"https://api.github.com/repos/mapstruct/mapstruct/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mapstruct/mapstruct/issues/379/comments","statuses_url":"https://api.github.com/repos/mapstruct/mapstruct/statuses/1fc4a0f20cd42c392b28d80b1ca3784775f33ddd","head":{"label":"eforest:master","ref":"master","sha":"1fc4a0f20cd42c392b28d80b1ca3784775f33ddd","user":{"login":"eforest","id":6786326,"avatar_url":"https://avatars.githubusercontent.com/u/6786326?v=3","gravatar_id":"","url":"https://api.github.com/users/eforest","html_url":"https://github.com/eforest","followers_url":"https://api.github.com/users/eforest/followers","following_url":"https://api.github.com/users/eforest/following{/other_user}","gists_url":"https://api.github.com/users/eforest/gists{/gist_id}","starred_url":"https://api.github.com/users/eforest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eforest/subscriptions","organizations_url":"https://api.github.com/users/eforest/orgs","repos_url":"https://api.github.com/users/eforest/repos","events_url":"https://api.github.com/users/eforest/events{/privacy}","received_events_url":"https://api.github.com/users/eforest/received_events","type":"User","site_admin":false},"repo":{"id":26326615,"name":"mapstruct","full_name":"eforest/mapstruct","owner":{"login":"eforest","id":6786326,"avatar_url":"https://avatars.githubusercontent.com/u/6786326?v=3","gravatar_id":"","url":"https://api.github.com/users/eforest","html_url":"https://github.com/eforest","followers_url":"https://api.github.com/users/eforest/followers","following_url":"https://api.github.com/users/eforest/following{/other_user}","gists_url":"https://api.github.com/users/eforest/gists{/gist_id}","starred_url":"https://api.github.com/users/eforest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eforest/subscriptions","organizations_url":"https://api.github.com/users/eforest/orgs","repos_url":"https://api.github.com/users/eforest/repos","events_url":"https://api.github.com/users/eforest/events{/privacy}","received_events_url":"https://api.github.com/users/eforest/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eforest/mapstruct","description":"An annotation processor for generating type-safe bean mappers","fork":true,"url":"https://api.github.com/repos/eforest/mapstruct","forks_url":"https://api.github.com/repos/eforest/mapstruct/forks","keys_url":"https://api.github.com/repos/eforest/mapstruct/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eforest/mapstruct/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eforest/mapstruct/teams","hooks_url":"https://api.github.com/repos/eforest/mapstruct/hooks","issue_events_url":"https://api.github.com/repos/eforest/mapstruct/issues/events{/number}","events_url":"https://api.github.com/repos/eforest/mapstruct/events","assignees_url":"https://api.github.com/repos/eforest/mapstruct/assignees{/user}","branches_url":"https://api.github.com/repos/eforest/mapstruct/branches{/branch}","tags_url":"https://api.github.com/repos/eforest/mapstruct/tags","blobs_url":"https://api.github.com/repos/eforest/mapstruct/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eforest/mapstruct/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eforest/mapstruct/git/refs{/sha}","trees_url":"https://api.github.com/repos/eforest/mapstruct/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eforest/mapstruct/statuses/{sha}","languages_url":"https://api.github.com/repos/eforest/mapstruct/languages","stargazers_url":"https://api.github.com/repos/eforest/mapstruct/stargazers","contributors_url":"https://api.github.com/repos/eforest/mapstruct/contributors","subscribers_url":"https://api.github.com/repos/eforest/mapstruct/subscribers","subscription_url":"https://api.github.com/repos/eforest/mapstruct/subscription","commits_url":"https://api.github.com/repos/eforest/mapstruct/commits{/sha}","git_commits_url":"https://api.github.com/repos/eforest/mapstruct/git/commits{/sha}","comments_url":"https://api.github.com/repos/eforest/mapstruct/comments{/number}","issue_comment_url":"https://api.github.com/repos/eforest/mapstruct/issues/comments/{number}","contents_url":"https://api.github.com/repos/eforest/mapstruct/contents/{+path}","compare_url":"https://api.github.com/repos/eforest/mapstruct/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eforest/mapstruct/merges","archive_url":"https://api.github.com/repos/eforest/mapstruct/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eforest/mapstruct/downloads","issues_url":"https://api.github.com/repos/eforest/mapstruct/issues{/number}","pulls_url":"https://api.github.com/repos/eforest/mapstruct/pulls{/number}","milestones_url":"https://api.github.com/repos/eforest/mapstruct/milestones{/number}","notifications_url":"https://api.github.com/repos/eforest/mapstruct/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eforest/mapstruct/labels{/name}","releases_url":"https://api.github.com/repos/eforest/mapstruct/releases{/id}","created_at":"2014-11-07T16:00:16Z","updated_at":"2014-12-08T22:14:50Z","pushed_at":"2014-12-08T22:14:49Z","git_url":"git://github.com/eforest/mapstruct.git","ssh_url":"git@github.com:eforest/mapstruct.git","clone_url":"https://github.com/eforest/mapstruct.git","svn_url":"https://github.com/eforest/mapstruct","homepage":"http://mapstruct.org/","size":2343,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mapstruct:master","ref":"master","sha":"e4de6419113cd20a97ee1cdcf5bf8a86fe8ebd28","user":{"login":"mapstruct","id":4086779,"avatar_url":"https://avatars.githubusercontent.com/u/4086779?v=3","gravatar_id":"","url":"https://api.github.com/users/mapstruct","html_url":"https://github.com/mapstruct","followers_url":"https://api.github.com/users/mapstruct/followers","following_url":"https://api.github.com/users/mapstruct/following{/other_user}","gists_url":"https://api.github.com/users/mapstruct/gists{/gist_id}","starred_url":"https://api.github.com/users/mapstruct/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapstruct/subscriptions","organizations_url":"https://api.github.com/users/mapstruct/orgs","repos_url":"https://api.github.com/users/mapstruct/repos","events_url":"https://api.github.com/users/mapstruct/events{/privacy}","received_events_url":"https://api.github.com/users/mapstruct/received_events","type":"Organization","site_admin":false},"repo":{"id":4470435,"name":"mapstruct","full_name":"mapstruct/mapstruct","owner":{"login":"mapstruct","id":4086779,"avatar_url":"https://avatars.githubusercontent.com/u/4086779?v=3","gravatar_id":"","url":"https://api.github.com/users/mapstruct","html_url":"https://github.com/mapstruct","followers_url":"https://api.github.com/users/mapstruct/followers","following_url":"https://api.github.com/users/mapstruct/following{/other_user}","gists_url":"https://api.github.com/users/mapstruct/gists{/gist_id}","starred_url":"https://api.github.com/users/mapstruct/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapstruct/subscriptions","organizations_url":"https://api.github.com/users/mapstruct/orgs","repos_url":"https://api.github.com/users/mapstruct/repos","events_url":"https://api.github.com/users/mapstruct/events{/privacy}","received_events_url":"https://api.github.com/users/mapstruct/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mapstruct/mapstruct","description":"An annotation processor for generating type-safe bean mappers","fork":false,"url":"https://api.github.com/repos/mapstruct/mapstruct","forks_url":"https://api.github.com/repos/mapstruct/mapstruct/forks","keys_url":"https://api.github.com/repos/mapstruct/mapstruct/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapstruct/mapstruct/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapstruct/mapstruct/teams","hooks_url":"https://api.github.com/repos/mapstruct/mapstruct/hooks","issue_events_url":"https://api.github.com/repos/mapstruct/mapstruct/issues/events{/number}","events_url":"https://api.github.com/repos/mapstruct/mapstruct/events","assignees_url":"https://api.github.com/repos/mapstruct/mapstruct/assignees{/user}","branches_url":"https://api.github.com/repos/mapstruct/mapstruct/branches{/branch}","tags_url":"https://api.github.com/repos/mapstruct/mapstruct/tags","blobs_url":"https://api.github.com/repos/mapstruct/mapstruct/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapstruct/mapstruct/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapstruct/mapstruct/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapstruct/mapstruct/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapstruct/mapstruct/statuses/{sha}","languages_url":"https://api.github.com/repos/mapstruct/mapstruct/languages","stargazers_url":"https://api.github.com/repos/mapstruct/mapstruct/stargazers","contributors_url":"https://api.github.com/repos/mapstruct/mapstruct/contributors","subscribers_url":"https://api.github.com/repos/mapstruct/mapstruct/subscribers","subscription_url":"https://api.github.com/repos/mapstruct/mapstruct/subscription","commits_url":"https://api.github.com/repos/mapstruct/mapstruct/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapstruct/mapstruct/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapstruct/mapstruct/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapstruct/mapstruct/issues/comments/{number}","contents_url":"https://api.github.com/repos/mapstruct/mapstruct/contents/{+path}","compare_url":"https://api.github.com/repos/mapstruct/mapstruct/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapstruct/mapstruct/merges","archive_url":"https://api.github.com/repos/mapstruct/mapstruct/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapstruct/mapstruct/downloads","issues_url":"https://api.github.com/repos/mapstruct/mapstruct/issues{/number}","pulls_url":"https://api.github.com/repos/mapstruct/mapstruct/pulls{/number}","milestones_url":"https://api.github.com/repos/mapstruct/mapstruct/milestones{/number}","notifications_url":"https://api.github.com/repos/mapstruct/mapstruct/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapstruct/mapstruct/labels{/name}","releases_url":"https://api.github.com/repos/mapstruct/mapstruct/releases{/id}","created_at":"2012-05-28T12:42:42Z","updated_at":"2014-12-13T17:00:12Z","pushed_at":"2014-12-13T17:00:12Z","git_url":"git://github.com/mapstruct/mapstruct.git","ssh_url":"git@github.com:mapstruct/mapstruct.git","clone_url":"https://github.com/mapstruct/mapstruct.git","svn_url":"https://github.com/mapstruct/mapstruct","homepage":"http://mapstruct.org/","size":4136,"stargazers_count":66,"watchers_count":66,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"open_issues_count":74,"forks":23,"open_issues":74,"watchers":66,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mapstruct/mapstruct/pulls/379"},"html":{"href":"https://github.com/mapstruct/mapstruct/pull/379"},"issue":{"href":"https://api.github.com/repos/mapstruct/mapstruct/issues/379"},"comments":{"href":"https://api.github.com/repos/mapstruct/mapstruct/issues/379/comments"},"review_comments":{"href":"https://api.github.com/repos/mapstruct/mapstruct/pulls/379/comments"},"review_comment":{"href":"https://api.github.com/repos/mapstruct/mapstruct/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mapstruct/mapstruct/pulls/379/commits"},"statuses":{"href":"https://api.github.com/repos/mapstruct/mapstruct/statuses/1fc4a0f20cd42c392b28d80b1ca3784775f33ddd"}}}}