GitHub PushEvent at 2014-08-28 15:39:44
Repository: atom
Actor: RobberPhex
Payload: {"shas":[["32e59ce23847204a8a3ac4997b4a49a6afe82b38","46f1a0bd5592a2f9244ca321b129902a06b53e03@mschuessler.org","Cleanup code according to coffeelint","Maximilian Schüßler",false],["cbe5593381f7c1582c8b8b511bc22ab3b6b5c0f7","46f1a0bd5592a2f9244ca321b129902a06b53e03@mschuessler.org","Do not use \"-> return\" to mark empty function","Maximilian Schüßler",false],["cda8382902df6082e60e04ed94d29a2fc59b94f8","30504a0281c5863c121b2f87b878cc03d3557279@google.com",":penguin: Set file mode to 755 to directories created for mkdeb.","Alessandro Bahgat",false],["5873a0314569dd43b1eb7dd8d4b66ab40134a7c2","ffb4761cba839470133bee36aeb139f58d7dbaa9@github.com","Prepare 0.124","Kevin Sawicki",false],["0eaec57f7b41dc2bf421814b4f5c8bf63f8445b8","ffb4761cba839470133bee36aeb139f58d7dbaa9@github.com","Merge pull request #3116 from maschs/ms-srcLint\n\ncoffeelint!","Kevin Sawicki",false],["0a07e862c2de31e6643f3089f025af0082883abe","ffb4761cba839470133bee36aeb139f58d7dbaa9@github.com","Upgrade to language-html@0.25","Kevin Sawicki",false],["c989557b5e2f0a5164f975ee5fa4ec48b93dd795","715cc99f7ac69e9945bb96fc7eadf48566d4518a@gmail.com","Run benchmarks passes specDir","Ben Ogle",false],["34f96b2ea2368b03752cd678a733bfed6ec0f97f","715cc99f7ac69e9945bb96fc7eadf48566d4518a@gmail.com","Correctly bootstrap the benchmarks","Ben Ogle",false],["881c21829b820a797cd44be69f627124a9a370c9","715cc99f7ac69e9945bb96fc7eadf48566d4518a@gmail.com","Fix benchmark requires","Ben Ogle",false],["590bfa0c86170057f8ab8927aef3b9cd5185f411","3b93fdc117466dbd3665bf4c0f6437f68698083c@desmondbrand.com",":lipstick: Tighten lint rules\n\ncoffeelint.json had some rules set to ignore, but since #3116 was merged there\nare no violations of these rules in the code anymore. Tighten up the rules to\nprevent those kinds of errors from creeping back in.\n\nTest Plan:\n\nLint executes without finding any errors\n\n```\n$ ./script/grunt coffeelint\nRunning \"coffeelint:src\" (coffeelint) task\n>> 80 files lint free.\n\nRunning \"coffeelint:build\" (coffeelint) task\n>> 23 files lint free.\n\nRunning \"coffeelint:test\" (coffeelint) task\n>> 40 files lint free.\nDone, without errors.\n```","Desmond Brand",false],["237d71417d352f97c9987d2fbdc11ca763e888f6","ffb4761cba839470133bee36aeb139f58d7dbaa9@github.com","Upgrade to language-coffee-script@0.30","Kevin Sawicki",false],["6b5d16173b7e82a10836af17ff925917e9741535","3b93fdc117466dbd3665bf4c0f6437f68698083c@desmondbrand.com",":lipstick: more lint rules","Desmond Brand",false],["ccd32cd08411dbac0dab2abe1607e541e06ab013","3b93fdc117466dbd3665bf4c0f6437f68698083c@desmondbrand.com",":lipstick: arrow spacing warn -> error","Desmond Brand",false],["b46e03437cdf41552d7eea0b6a3daff8fc3d22a5","ffb4761cba839470133bee36aeb139f58d7dbaa9@github.com","Upgrade to styleguide@0.30","Kevin Sawicki",false],["a20f04149cd8819c4902f248750a5ac7ae1768c1","3b93fdc117466dbd3665bf4c0f6437f68698083c@desmondbrand.com","remove line_endings rule","Desmond Brand",false],["ebbea64b3de1c41336b386d76a7f0dad70a7af88","ffb4761cba839470133bee36aeb139f58d7dbaa9@github.com","Merge pull request #3295 from dmnd/tighten-lint-rules\n\nTighten lint rules","Kevin Sawicki",false],["a1d8ee86f942f9a1f6d14a7fe424688a861beccc","3b93fdc117466dbd3665bf4c0f6437f68698083c@desmondbrand.com","Fix error when running `checkout-head-revision`\n\nI got the following error when running `checkout-head-revision`:\n\n```\nUncaught TypeError: undefined is not a function /Applications/Atom.app/Contents/Resources/app/src/editor-component.js:804\naddCommandListeners.editor:checkout-head-revision /Applications/Atom.app/Contents/Resources/app/src/editor-component.js:804\n(anonymous function) /Applications/Atom.app/Contents/Resources/app/src/editor-component.js:840\njQuery.event.dispatch /Applications/Atom.app/Contents/Resources/app/node_modules/space-pen/vendor/jquery.js:4676\nelemData.handle /Applications/Atom.app/Contents/Resources/app/node_modules/space-pen/vendor/jquery.js:4360\nmodule.exports.KeymapManager.dispatchCommandEvent /Applications/Atom.app/Contents/Resources/app/node_modules/atom-keymap/lib/keymap-manager.js:400\nmodule.exports.KeymapManager.handleKeyboardEvent /Applications/Atom.app/Contents/Resources/app/node_modules/atom-keymap/lib/keymap-manager.js:181\nmodule.exports.WindowEventHandler.onKeydown\n```\n\nIt looks like it was caused by a bad merge conflict resolution in 0eaec57.\n\nTest Plan:\n\nBuilt new Atom and pressed `cmd-alt-z` and didn't get an error.\n\nLooked at a side-by-side diff to check for any other merge issues:\n\n```\ngit difftool -t opendiff 32e59ce..32e59ce^ src/editor-component.coffee\n```","Desmond Brand",false],["3190c0c517b52040f6853de8eb67d099c297f08b","bedccee303893728210df61409d3dc544e3be3a6@gmail.com","Upgrade to atom-shell@0.15.8","Cheng Zhao",false],["2b87f4bcb575bf1e47620bfdbc8abf17dae516a5","ffb4761cba839470133bee36aeb139f58d7dbaa9@github.com","Merge pull request #3315 from dmnd/fix-checkout-head\n\nFix error when running `checkout-head-revision`","Kevin Sawicki",false],["e1ff6ab32755ceb221d918a42b465cd70f2c44ea","ffb4761cba839470133bee36aeb139f58d7dbaa9@github.com","Upgrade to setings-view@0.140","Kevin Sawicki",false]],"size":114,"ref":"refs/heads/upstream","head":"48f161b63ad495a79e46f8ac3253bf9bf45d39d6"}