GitHub PullRequestEvent at 2014-09-10 20:44:46
Repository: webwallet
Actor: conejoninja
Payload: {"action":"opened","number":9,"pull_request":{"url":"https://api.github.com/repos/trezor/webwallet/pulls/9","id":21048805,"html_url":"https://github.com/trezor/webwallet/pull/9","diff_url":"https://github.com/trezor/webwallet/pull/9.diff","patch_url":"https://github.com/trezor/webwallet/pull/9.patch","issue_url":"https://api.github.com/repos/trezor/webwallet/issues/9","number":9,"state":"open","locked":false,"title":"Very basic sign & verify message implementation","user":{"login":"conejoninja","id":475423,"avatar_url":"https://avatars.githubusercontent.com/u/475423?v=2","gravatar_id":"9a3dad7dee673587fc28ff52ed8222ab","url":"https://api.github.com/users/conejoninja","html_url":"https://github.com/conejoninja","followers_url":"https://api.github.com/users/conejoninja/followers","following_url":"https://api.github.com/users/conejoninja/following{/other_user}","gists_url":"https://api.github.com/users/conejoninja/gists{/gist_id}","starred_url":"https://api.github.com/users/conejoninja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conejoninja/subscriptions","organizations_url":"https://api.github.com/users/conejoninja/orgs","repos_url":"https://api.github.com/users/conejoninja/repos","events_url":"https://api.github.com/users/conejoninja/events{/privacy}","received_events_url":"https://api.github.com/users/conejoninja/received_events","type":"User","site_admin":false},"body":"Needs some (a lot of) work on UI/UX, as probably you have your own idea that suits better for the whole wallet. There're some details yet to be done, like maximum length of message or the way the addresses are displayed to sign a message (copied it from the receive screen, but you might want to add a label to frequent addresses for example, to not mix them up)\r\n\r\nI also thought about combining both actions under the same menu option, as it's now it occupy a lot of space in the menu and they're not so frequent actions.\r\n\r\n\r\n![trezor_sign_cancel](https://cloud.githubusercontent.com/assets/475423/4224987/34d6c1bc-392a-11e4-8118-939b0bfbe5b3.png)\r\n![trezor_sign_success](https://cloud.githubusercontent.com/assets/475423/4224986/34d2f21c-392a-11e4-8ac6-6e34efc00438.png)\r\n![trezor_verify_error](https://cloud.githubusercontent.com/assets/475423/4224988/34d8410e-392a-11e4-9fe6-53e8e5d37e75.png)\r\n![trezor_verify_success](https://cloud.githubusercontent.com/assets/475423/4224989/34db6b7c-392a-11e4-9bfe-7268e7f6d23e.png)\r\n\r\n\r\nAny advice is welcome, while this works, I do not feel it's ready to be release/merged yet.\r\n\r\n","created_at":"2014-09-10T20:44:46Z","updated_at":"2014-09-10T20:44:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/trezor/webwallet/pulls/9/commits","review_comments_url":"https://api.github.com/repos/trezor/webwallet/pulls/9/comments","review_comment_url":"https://api.github.com/repos/trezor/webwallet/pulls/comments/{number}","comments_url":"https://api.github.com/repos/trezor/webwallet/issues/9/comments","statuses_url":"https://api.github.com/repos/trezor/webwallet/statuses/4aa9ca2c59f321ac4d6e72902564a8ee6e1d418f","head":{"label":"conejoninja:sign-verify-msg","ref":"sign-verify-msg","sha":"4aa9ca2c59f321ac4d6e72902564a8ee6e1d418f","user":{"login":"conejoninja","id":475423,"avatar_url":"https://avatars.githubusercontent.com/u/475423?v=2","gravatar_id":"9a3dad7dee673587fc28ff52ed8222ab","url":"https://api.github.com/users/conejoninja","html_url":"https://github.com/conejoninja","followers_url":"https://api.github.com/users/conejoninja/followers","following_url":"https://api.github.com/users/conejoninja/following{/other_user}","gists_url":"https://api.github.com/users/conejoninja/gists{/gist_id}","starred_url":"https://api.github.com/users/conejoninja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conejoninja/subscriptions","organizations_url":"https://api.github.com/users/conejoninja/orgs","repos_url":"https://api.github.com/users/conejoninja/repos","events_url":"https://api.github.com/users/conejoninja/events{/privacy}","received_events_url":"https://api.github.com/users/conejoninja/received_events","type":"User","site_admin":false},"repo":{"id":23178045,"name":"webwallet","full_name":"conejoninja/webwallet","owner":{"login":"conejoninja","id":475423,"avatar_url":"https://avatars.githubusercontent.com/u/475423?v=2","gravatar_id":"9a3dad7dee673587fc28ff52ed8222ab","url":"https://api.github.com/users/conejoninja","html_url":"https://github.com/conejoninja","followers_url":"https://api.github.com/users/conejoninja/followers","following_url":"https://api.github.com/users/conejoninja/following{/other_user}","gists_url":"https://api.github.com/users/conejoninja/gists{/gist_id}","starred_url":"https://api.github.com/users/conejoninja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conejoninja/subscriptions","organizations_url":"https://api.github.com/users/conejoninja/orgs","repos_url":"https://api.github.com/users/conejoninja/repos","events_url":"https://api.github.com/users/conejoninja/events{/privacy}","received_events_url":"https://api.github.com/users/conejoninja/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/conejoninja/webwallet","description":"myTREZOR: A simple webwallet using TREZOR as a private key storage","fork":true,"url":"https://api.github.com/repos/conejoninja/webwallet","forks_url":"https://api.github.com/repos/conejoninja/webwallet/forks","keys_url":"https://api.github.com/repos/conejoninja/webwallet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/conejoninja/webwallet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/conejoninja/webwallet/teams","hooks_url":"https://api.github.com/repos/conejoninja/webwallet/hooks","issue_events_url":"https://api.github.com/repos/conejoninja/webwallet/issues/events{/number}","events_url":"https://api.github.com/repos/conejoninja/webwallet/events","assignees_url":"https://api.github.com/repos/conejoninja/webwallet/assignees{/user}","branches_url":"https://api.github.com/repos/conejoninja/webwallet/branches{/branch}","tags_url":"https://api.github.com/repos/conejoninja/webwallet/tags","blobs_url":"https://api.github.com/repos/conejoninja/webwallet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/conejoninja/webwallet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/conejoninja/webwallet/git/refs{/sha}","trees_url":"https://api.github.com/repos/conejoninja/webwallet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/conejoninja/webwallet/statuses/{sha}","languages_url":"https://api.github.com/repos/conejoninja/webwallet/languages","stargazers_url":"https://api.github.com/repos/conejoninja/webwallet/stargazers","contributors_url":"https://api.github.com/repos/conejoninja/webwallet/contributors","subscribers_url":"https://api.github.com/repos/conejoninja/webwallet/subscribers","subscription_url":"https://api.github.com/repos/conejoninja/webwallet/subscription","commits_url":"https://api.github.com/repos/conejoninja/webwallet/commits{/sha}","git_commits_url":"https://api.github.com/repos/conejoninja/webwallet/git/commits{/sha}","comments_url":"https://api.github.com/repos/conejoninja/webwallet/comments{/number}","issue_comment_url":"https://api.github.com/repos/conejoninja/webwallet/issues/comments/{number}","contents_url":"https://api.github.com/repos/conejoninja/webwallet/contents/{+path}","compare_url":"https://api.github.com/repos/conejoninja/webwallet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/conejoninja/webwallet/merges","archive_url":"https://api.github.com/repos/conejoninja/webwallet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/conejoninja/webwallet/downloads","issues_url":"https://api.github.com/repos/conejoninja/webwallet/issues{/number}","pulls_url":"https://api.github.com/repos/conejoninja/webwallet/pulls{/number}","milestones_url":"https://api.github.com/repos/conejoninja/webwallet/milestones{/number}","notifications_url":"https://api.github.com/repos/conejoninja/webwallet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/conejoninja/webwallet/labels{/name}","releases_url":"https://api.github.com/repos/conejoninja/webwallet/releases{/id}","created_at":"2014-08-21T07:24:32Z","updated_at":"2014-08-13T01:22:39Z","pushed_at":"2014-09-10T20:36:17Z","git_url":"git://github.com/conejoninja/webwallet.git","ssh_url":"git@github.com:conejoninja/webwallet.git","clone_url":"https://github.com/conejoninja/webwallet.git","svn_url":"https://github.com/conejoninja/webwallet","homepage":"","size":2899,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"trezor:master","ref":"master","sha":"9fc5ee6d9a227cef4ad3db760e37115e139d4e1f","user":{"login":"trezor","id":4146447,"avatar_url":"https://avatars.githubusercontent.com/u/4146447?v=2","gravatar_id":"fa2ae25abc2445cf1618b9d5f127ce7b","url":"https://api.github.com/users/trezor","html_url":"https://github.com/trezor","followers_url":"https://api.github.com/users/trezor/followers","following_url":"https://api.github.com/users/trezor/following{/other_user}","gists_url":"https://api.github.com/users/trezor/gists{/gist_id}","starred_url":"https://api.github.com/users/trezor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trezor/subscriptions","organizations_url":"https://api.github.com/users/trezor/orgs","repos_url":"https://api.github.com/users/trezor/repos","events_url":"https://api.github.com/users/trezor/events{/privacy}","received_events_url":"https://api.github.com/users/trezor/received_events","type":"Organization","site_admin":false},"repo":{"id":13600693,"name":"webwallet","full_name":"trezor/webwallet","owner":{"login":"trezor","id":4146447,"avatar_url":"https://avatars.githubusercontent.com/u/4146447?v=2","gravatar_id":"fa2ae25abc2445cf1618b9d5f127ce7b","url":"https://api.github.com/users/trezor","html_url":"https://github.com/trezor","followers_url":"https://api.github.com/users/trezor/followers","following_url":"https://api.github.com/users/trezor/following{/other_user}","gists_url":"https://api.github.com/users/trezor/gists{/gist_id}","starred_url":"https://api.github.com/users/trezor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trezor/subscriptions","organizations_url":"https://api.github.com/users/trezor/orgs","repos_url":"https://api.github.com/users/trezor/repos","events_url":"https://api.github.com/users/trezor/events{/privacy}","received_events_url":"https://api.github.com/users/trezor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/trezor/webwallet","description":"myTREZOR: A simple webwallet using TREZOR as a private key storage","fork":false,"url":"https://api.github.com/repos/trezor/webwallet","forks_url":"https://api.github.com/repos/trezor/webwallet/forks","keys_url":"https://api.github.com/repos/trezor/webwallet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trezor/webwallet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trezor/webwallet/teams","hooks_url":"https://api.github.com/repos/trezor/webwallet/hooks","issue_events_url":"https://api.github.com/repos/trezor/webwallet/issues/events{/number}","events_url":"https://api.github.com/repos/trezor/webwallet/events","assignees_url":"https://api.github.com/repos/trezor/webwallet/assignees{/user}","branches_url":"https://api.github.com/repos/trezor/webwallet/branches{/branch}","tags_url":"https://api.github.com/repos/trezor/webwallet/tags","blobs_url":"https://api.github.com/repos/trezor/webwallet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trezor/webwallet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trezor/webwallet/git/refs{/sha}","trees_url":"https://api.github.com/repos/trezor/webwallet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trezor/webwallet/statuses/{sha}","languages_url":"https://api.github.com/repos/trezor/webwallet/languages","stargazers_url":"https://api.github.com/repos/trezor/webwallet/stargazers","contributors_url":"https://api.github.com/repos/trezor/webwallet/contributors","subscribers_url":"https://api.github.com/repos/trezor/webwallet/subscribers","subscription_url":"https://api.github.com/repos/trezor/webwallet/subscription","commits_url":"https://api.github.com/repos/trezor/webwallet/commits{/sha}","git_commits_url":"https://api.github.com/repos/trezor/webwallet/git/commits{/sha}","comments_url":"https://api.github.com/repos/trezor/webwallet/comments{/number}","issue_comment_url":"https://api.github.com/repos/trezor/webwallet/issues/comments/{number}","contents_url":"https://api.github.com/repos/trezor/webwallet/contents/{+path}","compare_url":"https://api.github.com/repos/trezor/webwallet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trezor/webwallet/merges","archive_url":"https://api.github.com/repos/trezor/webwallet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trezor/webwallet/downloads","issues_url":"https://api.github.com/repos/trezor/webwallet/issues{/number}","pulls_url":"https://api.github.com/repos/trezor/webwallet/pulls{/number}","milestones_url":"https://api.github.com/repos/trezor/webwallet/milestones{/number}","notifications_url":"https://api.github.com/repos/trezor/webwallet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trezor/webwallet/labels{/name}","releases_url":"https://api.github.com/repos/trezor/webwallet/releases{/id}","created_at":"2013-10-15T20:02:48Z","updated_at":"2014-09-02T13:27:33Z","pushed_at":"2014-09-10T11:45:50Z","git_url":"git://github.com/trezor/webwallet.git","ssh_url":"git@github.com:trezor/webwallet.git","clone_url":"https://github.com/trezor/webwallet.git","svn_url":"https://github.com/trezor/webwallet","homepage":"","size":5941,"stargazers_count":9,"watchers_count":9,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":11,"mirror_url":null,"open_issues_count":1,"forks":11,"open_issues":1,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/trezor/webwallet/pulls/9"},"html":{"href":"https://github.com/trezor/webwallet/pull/9"},"issue":{"href":"https://api.github.com/repos/trezor/webwallet/issues/9"},"comments":{"href":"https://api.github.com/repos/trezor/webwallet/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/trezor/webwallet/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/trezor/webwallet/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/trezor/webwallet/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/trezor/webwallet/statuses/4aa9ca2c59f321ac4d6e72902564a8ee6e1d418f"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":244,"deletions":6,"changed_files":8}}