GitHub PullRequestReviewCommentEvent at 2014-10-09 19:48:28
Repository: carbon-business-messaging
Actor: suhothayan
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/wso2-dev/carbon-business-messaging/pulls/comments/18669502","id":18669502,"diff_hunk":"@@ -19,36 +19,44 @@\n \n import org.apache.commons.logging.Log;\n import org.apache.commons.logging.LogFactory;\n-import org.wso2.carbon.andes.admin.internal.Exception.QueueManagerAdminException;\n-import org.wso2.carbon.andes.admin.util.AndesQueueManagerAdminServiceDSHolder;\n+import org.wso2.carbon.andes.admin.internal.Exception.BrokerManagerAdminException;\n+import org.wso2.carbon.andes.admin.internal.Message;\n+import org.wso2.carbon.andes.admin.internal.Queue;\n+import org.wso2.carbon.andes.admin.internal.QueueRolePermission;\n+import org.wso2.carbon.andes.admin.internal.Subscription;\n+import org.wso2.carbon.andes.admin.util.AndesBrokerManagerAdminServiceDSHolder;\n import org.wso2.carbon.andes.core.QueueManagerException;\n import org.wso2.carbon.andes.core.QueueManagerService;\n+import org.wso2.carbon.andes.core.SubscriptionManagerException;\n+import org.wso2.carbon.andes.core.SubscriptionManagerService;\n+import org.wso2.carbon.context.CarbonContext;\n import org.wso2.carbon.core.AbstractAdmin;\n \n import java.util.ArrayList;\n+import java.util.Collections;\n+import java.util.Comparator;\n import java.util.List;\n \n public class AndesAdminService extends AbstractAdmin {\n     private static Log log = LogFactory.getLog(AndesAdminService.class);\n \n \n-    public void createQueue(String queueName) throws QueueManagerAdminException {\n-        QueueManagerService queueManagerService = AndesQueueManagerAdminServiceDSHolder.getInstance().getQueueManagerService();\n+    public void createQueue(String queueName) throws BrokerManagerAdminException {//done","path":"components/andes/org.wso2.carbon.andes.admin/src/main/java/org/wso2/carbon/andes/admin/AndesAdminService.java","position":30,"original_position":30,"commit_id":"517b15f49014699f7862f30c4e253b4bc6035a42","original_commit_id":"517b15f49014699f7862f30c4e253b4bc6035a42","user":{"login":"suhothayan","id":3785208,"avatar_url":"https://avatars.githubusercontent.com/u/3785208?v=2","gravatar_id":"","url":"https://api.github.com/users/suhothayan","html_url":"https://github.com/suhothayan","followers_url":"https://api.github.com/users/suhothayan/followers","following_url":"https://api.github.com/users/suhothayan/following{/other_user}","gists_url":"https://api.github.com/users/suhothayan/gists{/gist_id}","starred_url":"https://api.github.com/users/suhothayan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/suhothayan/subscriptions","organizations_url":"https://api.github.com/users/suhothayan/orgs","repos_url":"https://api.github.com/users/suhothayan/repos","events_url":"https://api.github.com/users/suhothayan/events{/privacy}","received_events_url":"https://api.github.com/users/suhothayan/received_events","type":"User","site_admin":false},"body":"Why you have //done in all the methods ?","created_at":"2014-10-09T19:48:28Z","updated_at":"2014-10-09T19:48:28Z","html_url":"https://github.com/wso2-dev/carbon-business-messaging/pull/1#discussion_r18669502","pull_request_url":"https://api.github.com/repos/wso2-dev/carbon-business-messaging/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/wso2-dev/carbon-business-messaging/pulls/comments/18669502"},"html":{"href":"https://github.com/wso2-dev/carbon-business-messaging/pull/1#discussion_r18669502"},"pull_request":{"href":"https://api.github.com/repos/wso2-dev/carbon-business-messaging/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/wso2-dev/carbon-business-messaging/pulls/1","id":17643264,"html_url":"https://github.com/wso2-dev/carbon-business-messaging/pull/1","diff_url":"https://github.com/wso2-dev/carbon-business-messaging/pull/1.diff","patch_url":"https://github.com/wso2-dev/carbon-business-messaging/pull/1.patch","issue_url":"https://api.github.com/repos/wso2-dev/carbon-business-messaging/issues/1","number":1,"state":"closed","locked":false,"title":"Business Messaging Repo Update","user":{"login":"Asitha","id":919462,"avatar_url":"https://avatars.githubusercontent.com/u/919462?v=2","gravatar_id":"","url":"https://api.github.com/users/Asitha","html_url":"https://github.com/Asitha","followers_url":"https://api.github.com/users/Asitha/followers","following_url":"https://api.github.com/users/Asitha/following{/other_user}","gists_url":"https://api.github.com/users/Asitha/gists{/gist_id}","starred_url":"https://api.github.com/users/Asitha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Asitha/subscriptions","organizations_url":"https://api.github.com/users/Asitha/orgs","repos_url":"https://api.github.com/users/Asitha/repos","events_url":"https://api.github.com/users/Asitha/events{/privacy}","received_events_url":"https://api.github.com/users/Asitha/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-06-26T11:46:07Z","updated_at":"2014-10-09T19:48:28Z","closed_at":"2014-06-26T11:51:13Z","merged_at":"2014-06-26T11:51:13Z","merge_commit_sha":"9a6c639002142703644fa1276f413a39b4f08df1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/wso2-dev/carbon-business-messaging/pulls/1/commits","review_comments_url":"https://api.github.com/repos/wso2-dev/carbon-business-messaging/pulls/1/comments","review_comment_url":"https://api.github.com/repos/wso2-dev/carbon-business-messaging/pulls/comments/{number}","comments_url":"https://api.github.com/repos/wso2-dev/carbon-business-messaging/issues/1/comments","statuses_url":"https://api.github.com/repos/wso2-dev/carbon-business-messaging/statuses/517b15f49014699f7862f30c4e253b4bc6035a42","head":{"label":"Asitha:master","ref":"master","sha":"517b15f49014699f7862f30c4e253b4bc6035a42","user":{"login":"Asitha","id":919462,"avatar_url":"https://avatars.githubusercontent.com/u/919462?v=2","gravatar_id":"","url":"https://api.github.com/users/Asitha","html_url":"https://github.com/Asitha","followers_url":"https://api.github.com/users/Asitha/followers","following_url":"https://api.github.com/users/Asitha/following{/other_user}","gists_url":"https://api.github.com/users/Asitha/gists{/gist_id}","starred_url":"https://api.github.com/users/Asitha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Asitha/subscriptions","organizations_url":"https://api.github.com/users/Asitha/orgs","repos_url":"https://api.github.com/users/Asitha/repos","events_url":"https://api.github.com/users/Asitha/events{/privacy}","received_events_url":"https://api.github.com/users/Asitha/received_events","type":"User","site_admin":false},"repo":{"id":21228173,"name":"carbon-business-messaging","full_name":"Asitha/carbon-business-messaging","owner":{"login":"Asitha","id":919462,"avatar_url":"https://avatars.githubusercontent.com/u/919462?v=2","gravatar_id":"","url":"https://api.github.com/users/Asitha","html_url":"https://github.com/Asitha","followers_url":"https://api.github.com/users/Asitha/followers","following_url":"https://api.github.com/users/Asitha/following{/other_user}","gists_url":"https://api.github.com/users/Asitha/gists{/gist_id}","starred_url":"https://api.github.com/users/Asitha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Asitha/subscriptions","organizations_url":"https://api.github.com/users/Asitha/orgs","repos_url":"https://api.github.com/users/Asitha/repos","events_url":"https://api.github.com/users/Asitha/events{/privacy}","received_events_url":"https://api.github.com/users/Asitha/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Asitha/carbon-business-messaging","description":"","fork":true,"url":"https://api.github.com/repos/Asitha/carbon-business-messaging","forks_url":"https://api.github.com/repos/Asitha/carbon-business-messaging/forks","keys_url":"https://api.github.com/repos/Asitha/carbon-business-messaging/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Asitha/carbon-business-messaging/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Asitha/carbon-business-messaging/teams","hooks_url":"https://api.github.com/repos/Asitha/carbon-business-messaging/hooks","issue_events_url":"https://api.github.com/repos/Asitha/carbon-business-messaging/issues/events{/number}","events_url":"https://api.github.com/repos/Asitha/carbon-business-messaging/events","assignees_url":"https://api.github.com/repos/Asitha/carbon-business-messaging/assignees{/user}","branches_url":"https://api.github.com/repos/Asitha/carbon-business-messaging/branches{/branch}","tags_url":"https://api.github.com/repos/Asitha/carbon-business-messaging/tags","blobs_url":"https://api.github.com/repos/Asitha/carbon-business-messaging/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Asitha/carbon-business-messaging/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Asitha/carbon-business-messaging/git/refs{/sha}","trees_url":"https://api.github.com/repos/Asitha/carbon-business-messaging/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Asitha/carbon-business-messaging/statuses/{sha}","languages_url":"https://api.github.com/repos/Asitha/carbon-business-messaging/languages","stargazers_url":"https://api.github.com/repos/Asitha/carbon-business-messaging/stargazers","contributors_url":"https://api.github.com/repos/Asitha/carbon-business-messaging/contributors","subscribers_url":"https://api.github.com/repos/Asitha/carbon-business-messaging/subscribers","subscription_url":"https://api.github.com/repos/Asitha/carbon-business-messaging/subscription","commits_url":"https://api.github.com/repos/Asitha/carbon-business-messaging/commits{/sha}","git_commits_url":"https://api.github.com/repos/Asitha/carbon-business-messaging/git/commits{/sha}","comments_url":"https://api.github.com/repos/Asitha/carbon-business-messaging/comments{/number}","issue_comment_url":"https://api.github.com/repos/Asitha/carbon-business-messaging/issues/comments/{number}","contents_url":"https://api.github.com/repos/Asitha/carbon-business-messaging/contents/{+path}","compare_url":"https://api.github.com/repos/Asitha/carbon-business-messaging/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Asitha/carbon-business-messaging/merges","archive_url":"https://api.github.com/repos/Asitha/carbon-business-messaging/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Asitha/carbon-business-messaging/downloads","issues_url":"https://api.github.com/repos/Asitha/carbon-business-messaging/issues{/number}","pulls_url":"https://api.github.com/repos/Asitha/carbon-business-messaging/pulls{/number}","milestones_url":"https://api.github.com/repos/Asitha/carbon-business-messaging/milestones{/number}","notifications_url":"https://api.github.com/repos/Asitha/carbon-business-messaging/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Asitha/carbon-business-messaging/labels{/name}","releases_url":"https://api.github.com/repos/Asitha/carbon-business-messaging/releases{/id}","created_at":"2014-06-26T04:38:08Z","updated_at":"2014-06-03T09:59:19Z","pushed_at":"2014-10-03T12:55:29Z","git_url":"git://github.com/Asitha/carbon-business-messaging.git","ssh_url":"git@github.com:Asitha/carbon-business-messaging.git","clone_url":"https://github.com/Asitha/carbon-business-messaging.git","svn_url":"https://github.com/Asitha/carbon-business-messaging","homepage":null,"size":811,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wso2-dev:master","ref":"master","sha":"e13d0aae5647bc247ecde5b6bbd2339eadaf6343","user":{"login":"wso2-dev","id":6744733,"avatar_url":"https://avatars.githubusercontent.com/u/6744733?v=2","gravatar_id":"","url":"https://api.github.com/users/wso2-dev","html_url":"https://github.com/wso2-dev","followers_url":"https://api.github.com/users/wso2-dev/followers","following_url":"https://api.github.com/users/wso2-dev/following{/other_user}","gists_url":"https://api.github.com/users/wso2-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/wso2-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wso2-dev/subscriptions","organizations_url":"https://api.github.com/users/wso2-dev/orgs","repos_url":"https://api.github.com/users/wso2-dev/repos","events_url":"https://api.github.com/users/wso2-dev/events{/privacy}","received_events_url":"https://api.github.com/users/wso2-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":20437850,"name":"carbon-business-messaging","full_name":"wso2-dev/carbon-business-messaging","owner":{"login":"wso2-dev","id":6744733,"avatar_url":"https://avatars.githubusercontent.com/u/6744733?v=2","gravatar_id":"","url":"https://api.github.com/users/wso2-dev","html_url":"https://github.com/wso2-dev","followers_url":"https://api.github.com/users/wso2-dev/followers","following_url":"https://api.github.com/users/wso2-dev/following{/other_user}","gists_url":"https://api.github.com/users/wso2-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/wso2-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wso2-dev/subscriptions","organizations_url":"https://api.github.com/users/wso2-dev/orgs","repos_url":"https://api.github.com/users/wso2-dev/repos","events_url":"https://api.github.com/users/wso2-dev/events{/privacy}","received_events_url":"https://api.github.com/users/wso2-dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wso2-dev/carbon-business-messaging","description":"","fork":true,"url":"https://api.github.com/repos/wso2-dev/carbon-business-messaging","forks_url":"https://api.github.com/repos/wso2-dev/carbon-business-messaging/forks","keys_url":"https://api.github.com/repos/wso2-dev/carbon-business-messaging/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wso2-dev/carbon-business-messaging/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wso2-dev/carbon-business-messaging/teams","hooks_url":"https://api.github.com/repos/wso2-dev/carbon-business-messaging/hooks","issue_events_url":"https://api.github.com/repos/wso2-dev/carbon-business-messaging/issues/events{/number}","events_url":"https://api.github.com/repos/wso2-dev/carbon-business-messaging/events","assignees_url":"https://api.github.com/repos/wso2-dev/carbon-business-messaging/assignees{/user}","branches_url":"https://api.github.com/repos/wso2-dev/carbon-business-messaging/branches{/branch}","tags_url":"https://api.github.com/repos/wso2-dev/carbon-business-messaging/tags","blobs_url":"https://api.github.com/repos/wso2-dev/carbon-business-messaging/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wso2-dev/carbon-business-messaging/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wso2-dev/carbon-business-messaging/git/refs{/sha}","trees_url":"https://api.github.com/repos/wso2-dev/carbon-business-messaging/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wso2-dev/carbon-business-messaging/statuses/{sha}","languages_url":"https://api.github.com/repos/wso2-dev/carbon-business-messaging/languages","stargazers_url":"https://api.github.com/repos/wso2-dev/carbon-business-messaging/stargazers","contributors_url":"https://api.github.com/repos/wso2-dev/carbon-business-messaging/contributors","subscribers_url":"https://api.github.com/repos/wso2-dev/carbon-business-messaging/subscribers","subscription_url":"https://api.github.com/repos/wso2-dev/carbon-business-messaging/subscription","commits_url":"https://api.github.com/repos/wso2-dev/carbon-business-messaging/commits{/sha}","git_commits_url":"https://api.github.com/repos/wso2-dev/carbon-business-messaging/git/commits{/sha}","comments_url":"https://api.github.com/repos/wso2-dev/carbon-business-messaging/comments{/number}","issue_comment_url":"https://api.github.com/repos/wso2-dev/carbon-business-messaging/issues/comments/{number}","contents_url":"https://api.github.com/repos/wso2-dev/carbon-business-messaging/contents/{+path}","compare_url":"https://api.github.com/repos/wso2-dev/carbon-business-messaging/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wso2-dev/carbon-business-messaging/merges","archive_url":"https://api.github.com/repos/wso2-dev/carbon-business-messaging/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wso2-dev/carbon-business-messaging/downloads","issues_url":"https://api.github.com/repos/wso2-dev/carbon-business-messaging/issues{/number}","pulls_url":"https://api.github.com/repos/wso2-dev/carbon-business-messaging/pulls{/number}","milestones_url":"https://api.github.com/repos/wso2-dev/carbon-business-messaging/milestones{/number}","notifications_url":"https://api.github.com/repos/wso2-dev/carbon-business-messaging/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wso2-dev/carbon-business-messaging/labels{/name}","releases_url":"https://api.github.com/repos/wso2-dev/carbon-business-messaging/releases{/id}","created_at":"2014-06-03T09:59:19Z","updated_at":"2014-06-26T11:51:15Z","pushed_at":"2014-10-03T14:14:26Z","git_url":"git://github.com/wso2-dev/carbon-business-messaging.git","ssh_url":"git@github.com:wso2-dev/carbon-business-messaging.git","clone_url":"https://github.com/wso2-dev/carbon-business-messaging.git","svn_url":"https://github.com/wso2-dev/carbon-business-messaging","homepage":null,"size":2302,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":2,"forks":16,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wso2-dev/carbon-business-messaging/pulls/1"},"html":{"href":"https://github.com/wso2-dev/carbon-business-messaging/pull/1"},"issue":{"href":"https://api.github.com/repos/wso2-dev/carbon-business-messaging/issues/1"},"comments":{"href":"https://api.github.com/repos/wso2-dev/carbon-business-messaging/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/wso2-dev/carbon-business-messaging/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/wso2-dev/carbon-business-messaging/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/wso2-dev/carbon-business-messaging/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/wso2-dev/carbon-business-messaging/statuses/517b15f49014699f7862f30c4e253b4bc6035a42"}}}}