GitHub PullRequestReviewCommentEvent at 2014-07-14 08:56:36
Repository: parallel_tests
Actor: sponte
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/grosser/parallel_tests/pulls/comments/14868995","id":14868995,"diff_hunk":"@@ -7,7 +7,22 @@ class Runner < ParallelTests::Test::Runner\n \n       class << self\n         def run_tests(test_files, process_number, num_processes, options)\n-          sanitized_test_files = test_files.map { |val| WINDOWS ? \"\\\"#{val}\\\"\" : Shellwords.escape(val) }\n+          features = {}\n+          combined_scenarios = test_files\n+\n+          if options[:group_by] == :scenarios\n+            test_files.each do |f|\n+              scenario_components = f.split(':')\n+              features[scenario_components.first] ||= []\n+              features[scenario_components.first] << scenario_components.last\n+            end\n+","path":"lib/parallel_tests/gherkin/runner.rb","position":14,"original_position":14,"commit_id":"822c84920161be83a3214c177437f5dc685a66b2","original_commit_id":"822c84920161be83a3214c177437f5dc685a66b2","user":{"login":"sponte","id":47468,"avatar_url":"https://avatars.githubusercontent.com/u/47468?","gravatar_id":"36bb3d34936645673a87e6732d3281ca","url":"https://api.github.com/users/sponte","html_url":"https://github.com/sponte","followers_url":"https://api.github.com/users/sponte/followers","following_url":"https://api.github.com/users/sponte/following{/other_user}","gists_url":"https://api.github.com/users/sponte/gists{/gist_id}","starred_url":"https://api.github.com/users/sponte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sponte/subscriptions","organizations_url":"https://api.github.com/users/sponte/orgs","repos_url":"https://api.github.com/users/sponte/repos","events_url":"https://api.github.com/users/sponte/events{/privacy}","received_events_url":"https://api.github.com/users/sponte/received_events","type":"User","site_admin":false},"body":"Yes, this is better ;)","created_at":"2014-07-14T08:56:36Z","updated_at":"2014-07-14T08:56:36Z","html_url":"https://github.com/grosser/parallel_tests/pull/325#discussion_r14868995","pull_request_url":"https://api.github.com/repos/grosser/parallel_tests/pulls/325","_links":{"self":{"href":"https://api.github.com/repos/grosser/parallel_tests/pulls/comments/14868995"},"html":{"href":"https://github.com/grosser/parallel_tests/pull/325#discussion_r14868995"},"pull_request":{"href":"https://api.github.com/repos/grosser/parallel_tests/pulls/325"}}},"pull_request":{"url":"https://api.github.com/repos/grosser/parallel_tests/pulls/325","id":18273363,"html_url":"https://github.com/grosser/parallel_tests/pull/325","diff_url":"https://github.com/grosser/parallel_tests/pull/325.diff","patch_url":"https://github.com/grosser/parallel_tests/pull/325.patch","issue_url":"https://api.github.com/repos/grosser/parallel_tests/issues/325","number":325,"state":"open","title":"Updating cucumber / gherkin runner","user":{"login":"sponte","id":47468,"avatar_url":"https://avatars.githubusercontent.com/u/47468?","gravatar_id":"36bb3d34936645673a87e6732d3281ca","url":"https://api.github.com/users/sponte","html_url":"https://github.com/sponte","followers_url":"https://api.github.com/users/sponte/followers","following_url":"https://api.github.com/users/sponte/following{/other_user}","gists_url":"https://api.github.com/users/sponte/gists{/gist_id}","starred_url":"https://api.github.com/users/sponte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sponte/subscriptions","organizations_url":"https://api.github.com/users/sponte/orgs","repos_url":"https://api.github.com/users/sponte/repos","events_url":"https://api.github.com/users/sponte/events{/privacy}","received_events_url":"https://api.github.com/users/sponte/received_events","type":"User","site_admin":false},"body":"Currently when using --group_by scenarios option gherkin runner generates command which outputs same feature files multiple times for instance:\r\n\r\n*cucumber features/feature1:10 features/feature1:14 features:feature2:13*\r\n\r\nThis causes cucumber to call before_feature multiple times on the same feature within one thread. This is not desirable and a knock on effect is that junit reporter is broken as it overwrites feature files with the last execution.\r\n\r\nThis change fixes this by combining same features:\r\n\r\n*cucumber features/feature1:10:14 features:feature2:13*","created_at":"2014-07-11T11:27:52Z","updated_at":"2014-07-14T08:56:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b17f433fde7cdca6d38182aba61ece3239bf4e46","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/grosser/parallel_tests/pulls/325/commits","review_comments_url":"https://api.github.com/repos/grosser/parallel_tests/pulls/325/comments","review_comment_url":"https://api.github.com/repos/grosser/parallel_tests/pulls/comments/{number}","comments_url":"https://api.github.com/repos/grosser/parallel_tests/issues/325/comments","statuses_url":"https://api.github.com/repos/grosser/parallel_tests/statuses/822c84920161be83a3214c177437f5dc685a66b2","head":{"label":"sponte:master","ref":"master","sha":"822c84920161be83a3214c177437f5dc685a66b2","user":{"login":"sponte","id":47468,"avatar_url":"https://avatars.githubusercontent.com/u/47468?","gravatar_id":"36bb3d34936645673a87e6732d3281ca","url":"https://api.github.com/users/sponte","html_url":"https://github.com/sponte","followers_url":"https://api.github.com/users/sponte/followers","following_url":"https://api.github.com/users/sponte/following{/other_user}","gists_url":"https://api.github.com/users/sponte/gists{/gist_id}","starred_url":"https://api.github.com/users/sponte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sponte/subscriptions","organizations_url":"https://api.github.com/users/sponte/orgs","repos_url":"https://api.github.com/users/sponte/repos","events_url":"https://api.github.com/users/sponte/events{/privacy}","received_events_url":"https://api.github.com/users/sponte/received_events","type":"User","site_admin":false},"repo":{"id":21733788,"name":"parallel_tests","full_name":"sponte/parallel_tests","owner":{"login":"sponte","id":47468,"avatar_url":"https://avatars.githubusercontent.com/u/47468?","gravatar_id":"36bb3d34936645673a87e6732d3281ca","url":"https://api.github.com/users/sponte","html_url":"https://github.com/sponte","followers_url":"https://api.github.com/users/sponte/followers","following_url":"https://api.github.com/users/sponte/following{/other_user}","gists_url":"https://api.github.com/users/sponte/gists{/gist_id}","starred_url":"https://api.github.com/users/sponte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sponte/subscriptions","organizations_url":"https://api.github.com/users/sponte/orgs","repos_url":"https://api.github.com/users/sponte/repos","events_url":"https://api.github.com/users/sponte/events{/privacy}","received_events_url":"https://api.github.com/users/sponte/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sponte/parallel_tests","description":"Rails: 2 CPUs = 2x Testing Speed for RSpec, Test::Unit and Cucumber","fork":true,"url":"https://api.github.com/repos/sponte/parallel_tests","forks_url":"https://api.github.com/repos/sponte/parallel_tests/forks","keys_url":"https://api.github.com/repos/sponte/parallel_tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sponte/parallel_tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sponte/parallel_tests/teams","hooks_url":"https://api.github.com/repos/sponte/parallel_tests/hooks","issue_events_url":"https://api.github.com/repos/sponte/parallel_tests/issues/events{/number}","events_url":"https://api.github.com/repos/sponte/parallel_tests/events","assignees_url":"https://api.github.com/repos/sponte/parallel_tests/assignees{/user}","branches_url":"https://api.github.com/repos/sponte/parallel_tests/branches{/branch}","tags_url":"https://api.github.com/repos/sponte/parallel_tests/tags","blobs_url":"https://api.github.com/repos/sponte/parallel_tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sponte/parallel_tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sponte/parallel_tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/sponte/parallel_tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sponte/parallel_tests/statuses/{sha}","languages_url":"https://api.github.com/repos/sponte/parallel_tests/languages","stargazers_url":"https://api.github.com/repos/sponte/parallel_tests/stargazers","contributors_url":"https://api.github.com/repos/sponte/parallel_tests/contributors","subscribers_url":"https://api.github.com/repos/sponte/parallel_tests/subscribers","subscription_url":"https://api.github.com/repos/sponte/parallel_tests/subscription","commits_url":"https://api.github.com/repos/sponte/parallel_tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/sponte/parallel_tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/sponte/parallel_tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/sponte/parallel_tests/issues/comments/{number}","contents_url":"https://api.github.com/repos/sponte/parallel_tests/contents/{+path}","compare_url":"https://api.github.com/repos/sponte/parallel_tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sponte/parallel_tests/merges","archive_url":"https://api.github.com/repos/sponte/parallel_tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sponte/parallel_tests/downloads","issues_url":"https://api.github.com/repos/sponte/parallel_tests/issues{/number}","pulls_url":"https://api.github.com/repos/sponte/parallel_tests/pulls{/number}","milestones_url":"https://api.github.com/repos/sponte/parallel_tests/milestones{/number}","notifications_url":"https://api.github.com/repos/sponte/parallel_tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sponte/parallel_tests/labels{/name}","releases_url":"https://api.github.com/repos/sponte/parallel_tests/releases{/id}","created_at":"2014-07-11T11:22:52Z","updated_at":"2014-07-11T11:25:59Z","pushed_at":"2014-07-11T12:05:02Z","git_url":"git://github.com/sponte/parallel_tests.git","ssh_url":"git@github.com:sponte/parallel_tests.git","clone_url":"https://github.com/sponte/parallel_tests.git","svn_url":"https://github.com/sponte/parallel_tests","homepage":"","size":3744,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"grosser:master","ref":"master","sha":"bf7b54fa272928e298b6c3575ddc6b9a2f9e5e6b","user":{"login":"grosser","id":11367,"avatar_url":"https://avatars.githubusercontent.com/u/11367?","gravatar_id":"59436ecd4fe6ad7c34f67654d839f05f","url":"https://api.github.com/users/grosser","html_url":"https://github.com/grosser","followers_url":"https://api.github.com/users/grosser/followers","following_url":"https://api.github.com/users/grosser/following{/other_user}","gists_url":"https://api.github.com/users/grosser/gists{/gist_id}","starred_url":"https://api.github.com/users/grosser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grosser/subscriptions","organizations_url":"https://api.github.com/users/grosser/orgs","repos_url":"https://api.github.com/users/grosser/repos","events_url":"https://api.github.com/users/grosser/events{/privacy}","received_events_url":"https://api.github.com/users/grosser/received_events","type":"User","site_admin":false},"repo":{"id":203076,"name":"parallel_tests","full_name":"grosser/parallel_tests","owner":{"login":"grosser","id":11367,"avatar_url":"https://avatars.githubusercontent.com/u/11367?","gravatar_id":"59436ecd4fe6ad7c34f67654d839f05f","url":"https://api.github.com/users/grosser","html_url":"https://github.com/grosser","followers_url":"https://api.github.com/users/grosser/followers","following_url":"https://api.github.com/users/grosser/following{/other_user}","gists_url":"https://api.github.com/users/grosser/gists{/gist_id}","starred_url":"https://api.github.com/users/grosser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grosser/subscriptions","organizations_url":"https://api.github.com/users/grosser/orgs","repos_url":"https://api.github.com/users/grosser/repos","events_url":"https://api.github.com/users/grosser/events{/privacy}","received_events_url":"https://api.github.com/users/grosser/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/grosser/parallel_tests","description":"Rails: 2 CPUs = 2x Testing Speed for RSpec, Test::Unit and Cucumber","fork":false,"url":"https://api.github.com/repos/grosser/parallel_tests","forks_url":"https://api.github.com/repos/grosser/parallel_tests/forks","keys_url":"https://api.github.com/repos/grosser/parallel_tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grosser/parallel_tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grosser/parallel_tests/teams","hooks_url":"https://api.github.com/repos/grosser/parallel_tests/hooks","issue_events_url":"https://api.github.com/repos/grosser/parallel_tests/issues/events{/number}","events_url":"https://api.github.com/repos/grosser/parallel_tests/events","assignees_url":"https://api.github.com/repos/grosser/parallel_tests/assignees{/user}","branches_url":"https://api.github.com/repos/grosser/parallel_tests/branches{/branch}","tags_url":"https://api.github.com/repos/grosser/parallel_tests/tags","blobs_url":"https://api.github.com/repos/grosser/parallel_tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grosser/parallel_tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grosser/parallel_tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/grosser/parallel_tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grosser/parallel_tests/statuses/{sha}","languages_url":"https://api.github.com/repos/grosser/parallel_tests/languages","stargazers_url":"https://api.github.com/repos/grosser/parallel_tests/stargazers","contributors_url":"https://api.github.com/repos/grosser/parallel_tests/contributors","subscribers_url":"https://api.github.com/repos/grosser/parallel_tests/subscribers","subscription_url":"https://api.github.com/repos/grosser/parallel_tests/subscription","commits_url":"https://api.github.com/repos/grosser/parallel_tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/grosser/parallel_tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/grosser/parallel_tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/grosser/parallel_tests/issues/comments/{number}","contents_url":"https://api.github.com/repos/grosser/parallel_tests/contents/{+path}","compare_url":"https://api.github.com/repos/grosser/parallel_tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grosser/parallel_tests/merges","archive_url":"https://api.github.com/repos/grosser/parallel_tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grosser/parallel_tests/downloads","issues_url":"https://api.github.com/repos/grosser/parallel_tests/issues{/number}","pulls_url":"https://api.github.com/repos/grosser/parallel_tests/pulls{/number}","milestones_url":"https://api.github.com/repos/grosser/parallel_tests/milestones{/number}","notifications_url":"https://api.github.com/repos/grosser/parallel_tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grosser/parallel_tests/labels{/name}","releases_url":"https://api.github.com/repos/grosser/parallel_tests/releases{/id}","created_at":"2009-05-17T10:54:32Z","updated_at":"2014-07-14T01:22:52Z","pushed_at":"2014-07-13T19:41:39Z","git_url":"git://github.com/grosser/parallel_tests.git","ssh_url":"git@github.com:grosser/parallel_tests.git","clone_url":"https://github.com/grosser/parallel_tests.git","svn_url":"https://github.com/grosser/parallel_tests","homepage":"","size":3744,"stargazers_count":1189,"watchers_count":1189,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":240,"mirror_url":null,"open_issues_count":37,"forks":240,"open_issues":37,"watchers":1189,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grosser/parallel_tests/pulls/325"},"html":{"href":"https://github.com/grosser/parallel_tests/pull/325"},"issue":{"href":"https://api.github.com/repos/grosser/parallel_tests/issues/325"},"comments":{"href":"https://api.github.com/repos/grosser/parallel_tests/issues/325/comments"},"review_comments":{"href":"https://api.github.com/repos/grosser/parallel_tests/pulls/325/comments"},"review_comment":{"href":"https://api.github.com/repos/grosser/parallel_tests/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/grosser/parallel_tests/pulls/325/commits"},"statuses":{"href":"https://api.github.com/repos/grosser/parallel_tests/statuses/822c84920161be83a3214c177437f5dc685a66b2"}}}}