GitHub PullRequestReviewCommentEvent at 2014-08-08 10:03:34
Repository: homebrew
Actor: mikemcquaid
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/Homebrew/homebrew/pulls/comments/15985733","id":15985733,"diff_hunk":"@@ -11,7 +15,7 @@ class PerconaToolkit < Formula\n     sha1 \"bd1a9e82f25683742be022bed19a611c0b669a54\" => :lion\n   end\n \n-  depends_on :mysql\n+  depends_on :mysql => :recommended unless mysql_installed?","path":"Library/Formula/percona-toolkit.rb","position":15,"original_position":15,"commit_id":"a8f7df1915aafb4f03af9d0052eb2e99ec7dbf5d","original_commit_id":"a8f7df1915aafb4f03af9d0052eb2e99ec7dbf5d","user":{"login":"mikemcquaid","id":125011,"avatar_url":"https://avatars.githubusercontent.com/u/125011?v=2","gravatar_id":"215e0166d4d8265395c5d9076da73c70","url":"https://api.github.com/users/mikemcquaid","html_url":"https://github.com/mikemcquaid","followers_url":"https://api.github.com/users/mikemcquaid/followers","following_url":"https://api.github.com/users/mikemcquaid/following{/other_user}","gists_url":"https://api.github.com/users/mikemcquaid/gists{/gist_id}","starred_url":"https://api.github.com/users/mikemcquaid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikemcquaid/subscriptions","organizations_url":"https://api.github.com/users/mikemcquaid/orgs","repos_url":"https://api.github.com/users/mikemcquaid/repos","events_url":"https://api.github.com/users/mikemcquaid/events{/privacy}","received_events_url":"https://api.github.com/users/mikemcquaid/received_events","type":"User","site_admin":true},"body":"Hmm, in that case if it's trying to force installation of `mysql` it seems to be a bug.","created_at":"2014-08-08T10:03:34Z","updated_at":"2014-08-08T10:03:34Z","html_url":"https://github.com/Homebrew/homebrew/pull/31444#discussion_r15985733","pull_request_url":"https://api.github.com/repos/Homebrew/homebrew/pulls/31444","_links":{"self":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/comments/15985733"},"html":{"href":"https://github.com/Homebrew/homebrew/pull/31444#discussion_r15985733"},"pull_request":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/31444"}}},"pull_request":{"url":"https://api.github.com/repos/Homebrew/homebrew/pulls/31444","id":19517048,"html_url":"https://github.com/Homebrew/homebrew/pull/31444","diff_url":"https://github.com/Homebrew/homebrew/pull/31444.diff","patch_url":"https://github.com/Homebrew/homebrew/pull/31444.patch","issue_url":"https://api.github.com/repos/Homebrew/homebrew/issues/31444","number":31444,"state":"open","title":"Better MySQL dependency detection in percona-toolkit","user":{"login":"andreausu","id":623986,"avatar_url":"https://avatars.githubusercontent.com/u/623986?v=2","gravatar_id":"e224b77cce9168c6a1e0ccc8b7329562","url":"https://api.github.com/users/andreausu","html_url":"https://github.com/andreausu","followers_url":"https://api.github.com/users/andreausu/followers","following_url":"https://api.github.com/users/andreausu/following{/other_user}","gists_url":"https://api.github.com/users/andreausu/gists{/gist_id}","starred_url":"https://api.github.com/users/andreausu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreausu/subscriptions","organizations_url":"https://api.github.com/users/andreausu/orgs","repos_url":"https://api.github.com/users/andreausu/repos","events_url":"https://api.github.com/users/andreausu/events{/privacy}","received_events_url":"https://api.github.com/users/andreausu/received_events","type":"User","site_admin":false},"body":"The percona-toolkit formula was stricly depending on mysql making it impossible to install when a user had maridb or percona-server installed instead of the standard mysql.\r\n\r\nIt now detects whatever mysql executable exists on the system before requiring the mysql dependency.","created_at":"2014-08-08T09:21:33Z","updated_at":"2014-08-08T10:03:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"841fa30c84a40f1416c67e93b1fe91e0357b5591","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Homebrew/homebrew/pulls/31444/commits","review_comments_url":"https://api.github.com/repos/Homebrew/homebrew/pulls/31444/comments","review_comment_url":"https://api.github.com/repos/Homebrew/homebrew/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Homebrew/homebrew/issues/31444/comments","statuses_url":"https://api.github.com/repos/Homebrew/homebrew/statuses/a8f7df1915aafb4f03af9d0052eb2e99ec7dbf5d","head":{"label":"andreausu:percona-toolkit-mysql-detection","ref":"percona-toolkit-mysql-detection","sha":"a8f7df1915aafb4f03af9d0052eb2e99ec7dbf5d","user":{"login":"andreausu","id":623986,"avatar_url":"https://avatars.githubusercontent.com/u/623986?v=2","gravatar_id":"e224b77cce9168c6a1e0ccc8b7329562","url":"https://api.github.com/users/andreausu","html_url":"https://github.com/andreausu","followers_url":"https://api.github.com/users/andreausu/followers","following_url":"https://api.github.com/users/andreausu/following{/other_user}","gists_url":"https://api.github.com/users/andreausu/gists{/gist_id}","starred_url":"https://api.github.com/users/andreausu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreausu/subscriptions","organizations_url":"https://api.github.com/users/andreausu/orgs","repos_url":"https://api.github.com/users/andreausu/repos","events_url":"https://api.github.com/users/andreausu/events{/privacy}","received_events_url":"https://api.github.com/users/andreausu/received_events","type":"User","site_admin":false},"repo":{"id":22752153,"name":"homebrew","full_name":"andreausu/homebrew","owner":{"login":"andreausu","id":623986,"avatar_url":"https://avatars.githubusercontent.com/u/623986?v=2","gravatar_id":"e224b77cce9168c6a1e0ccc8b7329562","url":"https://api.github.com/users/andreausu","html_url":"https://github.com/andreausu","followers_url":"https://api.github.com/users/andreausu/followers","following_url":"https://api.github.com/users/andreausu/following{/other_user}","gists_url":"https://api.github.com/users/andreausu/gists{/gist_id}","starred_url":"https://api.github.com/users/andreausu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreausu/subscriptions","organizations_url":"https://api.github.com/users/andreausu/orgs","repos_url":"https://api.github.com/users/andreausu/repos","events_url":"https://api.github.com/users/andreausu/events{/privacy}","received_events_url":"https://api.github.com/users/andreausu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andreausu/homebrew","description":"The missing package manager for OS X.","fork":true,"url":"https://api.github.com/repos/andreausu/homebrew","forks_url":"https://api.github.com/repos/andreausu/homebrew/forks","keys_url":"https://api.github.com/repos/andreausu/homebrew/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andreausu/homebrew/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andreausu/homebrew/teams","hooks_url":"https://api.github.com/repos/andreausu/homebrew/hooks","issue_events_url":"https://api.github.com/repos/andreausu/homebrew/issues/events{/number}","events_url":"https://api.github.com/repos/andreausu/homebrew/events","assignees_url":"https://api.github.com/repos/andreausu/homebrew/assignees{/user}","branches_url":"https://api.github.com/repos/andreausu/homebrew/branches{/branch}","tags_url":"https://api.github.com/repos/andreausu/homebrew/tags","blobs_url":"https://api.github.com/repos/andreausu/homebrew/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andreausu/homebrew/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andreausu/homebrew/git/refs{/sha}","trees_url":"https://api.github.com/repos/andreausu/homebrew/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andreausu/homebrew/statuses/{sha}","languages_url":"https://api.github.com/repos/andreausu/homebrew/languages","stargazers_url":"https://api.github.com/repos/andreausu/homebrew/stargazers","contributors_url":"https://api.github.com/repos/andreausu/homebrew/contributors","subscribers_url":"https://api.github.com/repos/andreausu/homebrew/subscribers","subscription_url":"https://api.github.com/repos/andreausu/homebrew/subscription","commits_url":"https://api.github.com/repos/andreausu/homebrew/commits{/sha}","git_commits_url":"https://api.github.com/repos/andreausu/homebrew/git/commits{/sha}","comments_url":"https://api.github.com/repos/andreausu/homebrew/comments{/number}","issue_comment_url":"https://api.github.com/repos/andreausu/homebrew/issues/comments/{number}","contents_url":"https://api.github.com/repos/andreausu/homebrew/contents/{+path}","compare_url":"https://api.github.com/repos/andreausu/homebrew/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andreausu/homebrew/merges","archive_url":"https://api.github.com/repos/andreausu/homebrew/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andreausu/homebrew/downloads","issues_url":"https://api.github.com/repos/andreausu/homebrew/issues{/number}","pulls_url":"https://api.github.com/repos/andreausu/homebrew/pulls{/number}","milestones_url":"https://api.github.com/repos/andreausu/homebrew/milestones{/number}","notifications_url":"https://api.github.com/repos/andreausu/homebrew/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andreausu/homebrew/labels{/name}","releases_url":"https://api.github.com/repos/andreausu/homebrew/releases{/id}","created_at":"2014-08-08T09:04:49Z","updated_at":"2014-08-08T08:50:35Z","pushed_at":"2014-08-08T09:17:58Z","git_url":"git://github.com/andreausu/homebrew.git","ssh_url":"git@github.com:andreausu/homebrew.git","clone_url":"https://github.com/andreausu/homebrew.git","svn_url":"https://github.com/andreausu/homebrew","homepage":"http://brew.sh","size":39902,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":false,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Homebrew:master","ref":"master","sha":"6b41844e8010d11be31cf9449cce1cd19d70db90","user":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars.githubusercontent.com/u/1503512?v=2","gravatar_id":"53b099dabcf41f2b4395513ddfd68fc6","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"repo":{"id":206084,"name":"homebrew","full_name":"Homebrew/homebrew","owner":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars.githubusercontent.com/u/1503512?v=2","gravatar_id":"53b099dabcf41f2b4395513ddfd68fc6","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Homebrew/homebrew","description":"The missing package manager for OS X.","fork":false,"url":"https://api.github.com/repos/Homebrew/homebrew","forks_url":"https://api.github.com/repos/Homebrew/homebrew/forks","keys_url":"https://api.github.com/repos/Homebrew/homebrew/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Homebrew/homebrew/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Homebrew/homebrew/teams","hooks_url":"https://api.github.com/repos/Homebrew/homebrew/hooks","issue_events_url":"https://api.github.com/repos/Homebrew/homebrew/issues/events{/number}","events_url":"https://api.github.com/repos/Homebrew/homebrew/events","assignees_url":"https://api.github.com/repos/Homebrew/homebrew/assignees{/user}","branches_url":"https://api.github.com/repos/Homebrew/homebrew/branches{/branch}","tags_url":"https://api.github.com/repos/Homebrew/homebrew/tags","blobs_url":"https://api.github.com/repos/Homebrew/homebrew/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Homebrew/homebrew/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Homebrew/homebrew/git/refs{/sha}","trees_url":"https://api.github.com/repos/Homebrew/homebrew/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Homebrew/homebrew/statuses/{sha}","languages_url":"https://api.github.com/repos/Homebrew/homebrew/languages","stargazers_url":"https://api.github.com/repos/Homebrew/homebrew/stargazers","contributors_url":"https://api.github.com/repos/Homebrew/homebrew/contributors","subscribers_url":"https://api.github.com/repos/Homebrew/homebrew/subscribers","subscription_url":"https://api.github.com/repos/Homebrew/homebrew/subscription","commits_url":"https://api.github.com/repos/Homebrew/homebrew/commits{/sha}","git_commits_url":"https://api.github.com/repos/Homebrew/homebrew/git/commits{/sha}","comments_url":"https://api.github.com/repos/Homebrew/homebrew/comments{/number}","issue_comment_url":"https://api.github.com/repos/Homebrew/homebrew/issues/comments/{number}","contents_url":"https://api.github.com/repos/Homebrew/homebrew/contents/{+path}","compare_url":"https://api.github.com/repos/Homebrew/homebrew/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Homebrew/homebrew/merges","archive_url":"https://api.github.com/repos/Homebrew/homebrew/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Homebrew/homebrew/downloads","issues_url":"https://api.github.com/repos/Homebrew/homebrew/issues{/number}","pulls_url":"https://api.github.com/repos/Homebrew/homebrew/pulls{/number}","milestones_url":"https://api.github.com/repos/Homebrew/homebrew/milestones{/number}","notifications_url":"https://api.github.com/repos/Homebrew/homebrew/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Homebrew/homebrew/labels{/name}","releases_url":"https://api.github.com/repos/Homebrew/homebrew/releases{/id}","created_at":"2009-05-20T19:38:37Z","updated_at":"2014-08-08T08:50:35Z","pushed_at":"2014-08-08T09:54:10Z","git_url":"git://github.com/Homebrew/homebrew.git","ssh_url":"git@github.com:Homebrew/homebrew.git","clone_url":"https://github.com/Homebrew/homebrew.git","svn_url":"https://github.com/Homebrew/homebrew","homepage":"http://brew.sh","size":1177002,"stargazers_count":18746,"watchers_count":18746,"language":"Ruby","has_issues":true,"has_downloads":false,"has_wiki":true,"forks_count":9207,"mirror_url":null,"open_issues_count":229,"forks":9207,"open_issues":229,"watchers":18746,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/31444"},"html":{"href":"https://github.com/Homebrew/homebrew/pull/31444"},"issue":{"href":"https://api.github.com/repos/Homebrew/homebrew/issues/31444"},"comments":{"href":"https://api.github.com/repos/Homebrew/homebrew/issues/31444/comments"},"review_comments":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/31444/comments"},"review_comment":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/31444/commits"},"statuses":{"href":"https://api.github.com/repos/Homebrew/homebrew/statuses/a8f7df1915aafb4f03af9d0052eb2e99ec7dbf5d"}}}}