GitHub PullRequestReviewCommentEvent at 2014-08-14 02:03:03
Repository: tajo
Actor: jihoonson
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/apache/tajo/pulls/comments/16218127","id":16218127,"diff_hunk":"@@ -628,6 +633,31 @@ public void close() {\n     }\n   }\n \n+  // In TajoMaster HA mode, if TajoCli can't connect existing active master,\n+  // this should try to connect new active master.\n+  private void checkMasterStatus() {\n+    try {\n+      if (conf.getBoolVar(TajoConf.ConfVars.TAJO_MASTER_HA_ENABLE)) {\n+        if (!HAServiceUtil.isMasterAlive(conf.get(TajoConf.ConfVars.TAJO_MASTER_CLIENT_RPC_ADDRESS","path":"tajo-client/src/main/java/org/apache/tajo/cli/TajoCli.java","position":51,"original_position":51,"commit_id":"8806e1096a2bbc9f193963a675c150fa1369bd7b","original_commit_id":"8806e1096a2bbc9f193963a675c150fa1369bd7b","user":{"login":"jihoonson","id":2322288,"avatar_url":"https://avatars.githubusercontent.com/u/2322288?v=2","gravatar_id":"e8b4d49fa87dfaf4af6e5afc5ac4920a","url":"https://api.github.com/users/jihoonson","html_url":"https://github.com/jihoonson","followers_url":"https://api.github.com/users/jihoonson/followers","following_url":"https://api.github.com/users/jihoonson/following{/other_user}","gists_url":"https://api.github.com/users/jihoonson/gists{/gist_id}","starred_url":"https://api.github.com/users/jihoonson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jihoonson/subscriptions","organizations_url":"https://api.github.com/users/jihoonson/orgs","repos_url":"https://api.github.com/users/jihoonson/repos","events_url":"https://api.github.com/users/jihoonson/events{/privacy}","received_events_url":"https://api.github.com/users/jihoonson/received_events","type":"User","site_admin":false},"body":"It would be better to use conf.getVar() instead of conf.get().","created_at":"2014-08-14T02:03:03Z","updated_at":"2014-08-14T02:03:03Z","html_url":"https://github.com/apache/tajo/pull/77#discussion_r16218127","pull_request_url":"https://api.github.com/repos/apache/tajo/pulls/77","_links":{"self":{"href":"https://api.github.com/repos/apache/tajo/pulls/comments/16218127"},"html":{"href":"https://github.com/apache/tajo/pull/77#discussion_r16218127"},"pull_request":{"href":"https://api.github.com/repos/apache/tajo/pulls/77"}}},"pull_request":{"url":"https://api.github.com/repos/apache/tajo/pulls/77","id":18420460,"html_url":"https://github.com/apache/tajo/pull/77","diff_url":"https://github.com/apache/tajo/pull/77.diff","patch_url":"https://github.com/apache/tajo/pull/77.patch","issue_url":"https://api.github.com/repos/apache/tajo/issues/77","number":77,"state":"open","locked":false,"title":"TAJO-704: TajoMaster HA","user":{"login":"blrunner","id":3724310,"avatar_url":"https://avatars.githubusercontent.com/u/3724310?v=2","gravatar_id":"77f875e9dfedd07e9a19f9f88480366c","url":"https://api.github.com/users/blrunner","html_url":"https://github.com/blrunner","followers_url":"https://api.github.com/users/blrunner/followers","following_url":"https://api.github.com/users/blrunner/following{/other_user}","gists_url":"https://api.github.com/users/blrunner/gists{/gist_id}","starred_url":"https://api.github.com/users/blrunner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blrunner/subscriptions","organizations_url":"https://api.github.com/users/blrunner/orgs","repos_url":"https://api.github.com/users/blrunner/repos","events_url":"https://api.github.com/users/blrunner/events{/privacy}","received_events_url":"https://api.github.com/users/blrunner/received_events","type":"User","site_admin":false},"body":"I implemented TajoMaster HA Manager utilizing HDFS Cluster. I defined a interface named HAManager, and I implemented HAManagerWithHDFS with the interface. \r\n\r\nTo use TajoMaster HA, you have to set tajo.master.ha.enable=true at tajo-site.xml. And then, you just run standby master. All master informations will record to hdfs cluster, and all tajo service will refer master service address using hdfs cluster.\r\n\r\nFor reference, this patch includes a few issues as follows:\r\n\r\n- It just implemented one unit test case because of TAJO-942. \r\n- If you kill current master and you already ran tsql, you have to restart tsql. because new master doesn't know existing session ids. We need to handle this issue at another ticket.\r\n","created_at":"2014-07-15T16:55:49Z","updated_at":"2014-08-14T02:03:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d8397e949563e7f6af468dffd0c881f0d6d3cb94","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/tajo/pulls/77/commits","review_comments_url":"https://api.github.com/repos/apache/tajo/pulls/77/comments","review_comment_url":"https://api.github.com/repos/apache/tajo/pulls/comments/{number}","comments_url":"https://api.github.com/repos/apache/tajo/issues/77/comments","statuses_url":"https://api.github.com/repos/apache/tajo/statuses/8806e1096a2bbc9f193963a675c150fa1369bd7b","head":{"label":"blrunner:TAJO-704","ref":"TAJO-704","sha":"8806e1096a2bbc9f193963a675c150fa1369bd7b","user":{"login":"blrunner","id":3724310,"avatar_url":"https://avatars.githubusercontent.com/u/3724310?v=2","gravatar_id":"77f875e9dfedd07e9a19f9f88480366c","url":"https://api.github.com/users/blrunner","html_url":"https://github.com/blrunner","followers_url":"https://api.github.com/users/blrunner/followers","following_url":"https://api.github.com/users/blrunner/following{/other_user}","gists_url":"https://api.github.com/users/blrunner/gists{/gist_id}","starred_url":"https://api.github.com/users/blrunner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blrunner/subscriptions","organizations_url":"https://api.github.com/users/blrunner/orgs","repos_url":"https://api.github.com/users/blrunner/repos","events_url":"https://api.github.com/users/blrunner/events{/privacy}","received_events_url":"https://api.github.com/users/blrunner/received_events","type":"User","site_admin":false},"repo":{"id":20245441,"name":"tajo","full_name":"blrunner/tajo","owner":{"login":"blrunner","id":3724310,"avatar_url":"https://avatars.githubusercontent.com/u/3724310?v=2","gravatar_id":"77f875e9dfedd07e9a19f9f88480366c","url":"https://api.github.com/users/blrunner","html_url":"https://github.com/blrunner","followers_url":"https://api.github.com/users/blrunner/followers","following_url":"https://api.github.com/users/blrunner/following{/other_user}","gists_url":"https://api.github.com/users/blrunner/gists{/gist_id}","starred_url":"https://api.github.com/users/blrunner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blrunner/subscriptions","organizations_url":"https://api.github.com/users/blrunner/orgs","repos_url":"https://api.github.com/users/blrunner/repos","events_url":"https://api.github.com/users/blrunner/events{/privacy}","received_events_url":"https://api.github.com/users/blrunner/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/blrunner/tajo","description":"Mirror of Apache Tajo","fork":true,"url":"https://api.github.com/repos/blrunner/tajo","forks_url":"https://api.github.com/repos/blrunner/tajo/forks","keys_url":"https://api.github.com/repos/blrunner/tajo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/blrunner/tajo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/blrunner/tajo/teams","hooks_url":"https://api.github.com/repos/blrunner/tajo/hooks","issue_events_url":"https://api.github.com/repos/blrunner/tajo/issues/events{/number}","events_url":"https://api.github.com/repos/blrunner/tajo/events","assignees_url":"https://api.github.com/repos/blrunner/tajo/assignees{/user}","branches_url":"https://api.github.com/repos/blrunner/tajo/branches{/branch}","tags_url":"https://api.github.com/repos/blrunner/tajo/tags","blobs_url":"https://api.github.com/repos/blrunner/tajo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/blrunner/tajo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/blrunner/tajo/git/refs{/sha}","trees_url":"https://api.github.com/repos/blrunner/tajo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/blrunner/tajo/statuses/{sha}","languages_url":"https://api.github.com/repos/blrunner/tajo/languages","stargazers_url":"https://api.github.com/repos/blrunner/tajo/stargazers","contributors_url":"https://api.github.com/repos/blrunner/tajo/contributors","subscribers_url":"https://api.github.com/repos/blrunner/tajo/subscribers","subscription_url":"https://api.github.com/repos/blrunner/tajo/subscription","commits_url":"https://api.github.com/repos/blrunner/tajo/commits{/sha}","git_commits_url":"https://api.github.com/repos/blrunner/tajo/git/commits{/sha}","comments_url":"https://api.github.com/repos/blrunner/tajo/comments{/number}","issue_comment_url":"https://api.github.com/repos/blrunner/tajo/issues/comments/{number}","contents_url":"https://api.github.com/repos/blrunner/tajo/contents/{+path}","compare_url":"https://api.github.com/repos/blrunner/tajo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/blrunner/tajo/merges","archive_url":"https://api.github.com/repos/blrunner/tajo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/blrunner/tajo/downloads","issues_url":"https://api.github.com/repos/blrunner/tajo/issues{/number}","pulls_url":"https://api.github.com/repos/blrunner/tajo/pulls{/number}","milestones_url":"https://api.github.com/repos/blrunner/tajo/milestones{/number}","notifications_url":"https://api.github.com/repos/blrunner/tajo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/blrunner/tajo/labels{/name}","releases_url":"https://api.github.com/repos/blrunner/tajo/releases{/id}","created_at":"2014-05-28T04:49:19Z","updated_at":"2014-07-22T01:27:38Z","pushed_at":"2014-08-12T15:23:55Z","git_url":"git://github.com/blrunner/tajo.git","ssh_url":"git@github.com:blrunner/tajo.git","clone_url":"https://github.com/blrunner/tajo.git","svn_url":"https://github.com/blrunner/tajo","homepage":"tajo.apache.org","size":9917,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"fbf7166897b3b25d8319198216dc4ca529e677ce","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=2","gravatar_id":"a676c0bf448fcd49f588249ead719b4c","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17971138,"name":"tajo","full_name":"apache/tajo","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=2","gravatar_id":"a676c0bf448fcd49f588249ead719b4c","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/tajo","description":"Mirror of Apache Tajo","fork":false,"url":"https://api.github.com/repos/apache/tajo","forks_url":"https://api.github.com/repos/apache/tajo/forks","keys_url":"https://api.github.com/repos/apache/tajo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/tajo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/tajo/teams","hooks_url":"https://api.github.com/repos/apache/tajo/hooks","issue_events_url":"https://api.github.com/repos/apache/tajo/issues/events{/number}","events_url":"https://api.github.com/repos/apache/tajo/events","assignees_url":"https://api.github.com/repos/apache/tajo/assignees{/user}","branches_url":"https://api.github.com/repos/apache/tajo/branches{/branch}","tags_url":"https://api.github.com/repos/apache/tajo/tags","blobs_url":"https://api.github.com/repos/apache/tajo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/tajo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/tajo/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/tajo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/tajo/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/tajo/languages","stargazers_url":"https://api.github.com/repos/apache/tajo/stargazers","contributors_url":"https://api.github.com/repos/apache/tajo/contributors","subscribers_url":"https://api.github.com/repos/apache/tajo/subscribers","subscription_url":"https://api.github.com/repos/apache/tajo/subscription","commits_url":"https://api.github.com/repos/apache/tajo/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/tajo/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/tajo/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/tajo/issues/comments/{number}","contents_url":"https://api.github.com/repos/apache/tajo/contents/{+path}","compare_url":"https://api.github.com/repos/apache/tajo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/tajo/merges","archive_url":"https://api.github.com/repos/apache/tajo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/tajo/downloads","issues_url":"https://api.github.com/repos/apache/tajo/issues{/number}","pulls_url":"https://api.github.com/repos/apache/tajo/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/tajo/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/tajo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/tajo/labels{/name}","releases_url":"https://api.github.com/repos/apache/tajo/releases{/id}","created_at":"2014-03-21T07:00:07Z","updated_at":"2014-08-06T04:17:41Z","pushed_at":"2014-08-13T06:05:26Z","git_url":"git://github.com/apache/tajo.git","ssh_url":"git@github.com:apache/tajo.git","clone_url":"https://github.com/apache/tajo.git","svn_url":"https://github.com/apache/tajo","homepage":null,"size":19878,"stargazers_count":19,"watchers_count":19,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":24,"mirror_url":"git://git.apache.org/tajo.git","open_issues_count":9,"forks":24,"open_issues":9,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/tajo/pulls/77"},"html":{"href":"https://github.com/apache/tajo/pull/77"},"issue":{"href":"https://api.github.com/repos/apache/tajo/issues/77"},"comments":{"href":"https://api.github.com/repos/apache/tajo/issues/77/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/tajo/pulls/77/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/tajo/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/apache/tajo/pulls/77/commits"},"statuses":{"href":"https://api.github.com/repos/apache/tajo/statuses/8806e1096a2bbc9f193963a675c150fa1369bd7b"}}}}