GitHub PullRequestReviewCommentEvent at 2014-11-10 05:36:38
Repository: nobrainer
Actor: nviennot
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/nviennot/nobrainer/pulls/comments/20067363","id":20067363,"diff_hunk":"@@ -0,0 +1,13 @@\n+require 'spec_helper'\n+\n+describe 'NoBrainer geospatial' do\n+  before { load_geospatial_example }\n+\n+  let!(:city) { City.create(:name => 'Boston', :location => NoBrainer::GeoPoint.new(71.0636, 42.3581)) }\n+\n+  context 'when doing geospatial queries' do\n+    it 'finds by location' do\n+      City.nearest(NoBrainer::GeoPoint.new(71.0636, 42.3581), :index => 'location').count.should == 1","path":"spec/integration/geospatial_spec.rb","position":10,"original_position":10,"commit_id":"3fdd4b65008941c71662884982466938404fed28","original_commit_id":"892f854966efb4c0504835cd8b1ac55374140b36","user":{"login":"nviennot","id":297060,"avatar_url":"https://avatars.githubusercontent.com/u/297060?v=3","gravatar_id":"","url":"https://api.github.com/users/nviennot","html_url":"https://github.com/nviennot","followers_url":"https://api.github.com/users/nviennot/followers","following_url":"https://api.github.com/users/nviennot/following{/other_user}","gists_url":"https://api.github.com/users/nviennot/gists{/gist_id}","starred_url":"https://api.github.com/users/nviennot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nviennot/subscriptions","organizations_url":"https://api.github.com/users/nviennot/orgs","repos_url":"https://api.github.com/users/nviennot/repos","events_url":"https://api.github.com/users/nviennot/events{/privacy}","received_events_url":"https://api.github.com/users/nviennot/received_events","type":"User","site_admin":false},"body":"Don't test for this. The query language I want is with `where()`.\r\nIf you plan to implement just the type system for now, just do that, without taking care of the querying.","created_at":"2014-11-10T05:36:38Z","updated_at":"2014-11-10T05:36:38Z","html_url":"https://github.com/nviennot/nobrainer/pull/102#discussion_r20067363","pull_request_url":"https://api.github.com/repos/nviennot/nobrainer/pulls/102","_links":{"self":{"href":"https://api.github.com/repos/nviennot/nobrainer/pulls/comments/20067363"},"html":{"href":"https://github.com/nviennot/nobrainer/pull/102#discussion_r20067363"},"pull_request":{"href":"https://api.github.com/repos/nviennot/nobrainer/pulls/102"}}},"pull_request":{"url":"https://api.github.com/repos/nviennot/nobrainer/pulls/102","id":24121911,"html_url":"https://github.com/nviennot/nobrainer/pull/102","diff_url":"https://github.com/nviennot/nobrainer/pull/102.diff","patch_url":"https://github.com/nviennot/nobrainer/pull/102.patch","issue_url":"https://api.github.com/repos/nviennot/nobrainer/issues/102","number":102,"state":"open","locked":false,"title":"Initial geospatial support for NoBrainer","user":{"login":"jhstatewide","id":49839,"avatar_url":"https://avatars.githubusercontent.com/u/49839?v=3","gravatar_id":"","url":"https://api.github.com/users/jhstatewide","html_url":"https://github.com/jhstatewide","followers_url":"https://api.github.com/users/jhstatewide/followers","following_url":"https://api.github.com/users/jhstatewide/following{/other_user}","gists_url":"https://api.github.com/users/jhstatewide/gists{/gist_id}","starred_url":"https://api.github.com/users/jhstatewide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhstatewide/subscriptions","organizations_url":"https://api.github.com/users/jhstatewide/orgs","repos_url":"https://api.github.com/users/jhstatewide/repos","events_url":"https://api.github.com/users/jhstatewide/events{/privacy}","received_events_url":"https://api.github.com/users/jhstatewide/received_events","type":"User","site_admin":false},"body":"only Point / getNearest are implemented... Polygons and getIntersecting still need implementation... however this is useful on its own already.","created_at":"2014-11-10T00:29:51Z","updated_at":"2014-11-10T05:36:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3e75dda4e81e6ec40607b8358825002dfa10bca9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nviennot/nobrainer/pulls/102/commits","review_comments_url":"https://api.github.com/repos/nviennot/nobrainer/pulls/102/comments","review_comment_url":"https://api.github.com/repos/nviennot/nobrainer/pulls/comments/{number}","comments_url":"https://api.github.com/repos/nviennot/nobrainer/issues/102/comments","statuses_url":"https://api.github.com/repos/nviennot/nobrainer/statuses/3fdd4b65008941c71662884982466938404fed28","head":{"label":"jhstatewide:master","ref":"master","sha":"3fdd4b65008941c71662884982466938404fed28","user":{"login":"jhstatewide","id":49839,"avatar_url":"https://avatars.githubusercontent.com/u/49839?v=3","gravatar_id":"","url":"https://api.github.com/users/jhstatewide","html_url":"https://github.com/jhstatewide","followers_url":"https://api.github.com/users/jhstatewide/followers","following_url":"https://api.github.com/users/jhstatewide/following{/other_user}","gists_url":"https://api.github.com/users/jhstatewide/gists{/gist_id}","starred_url":"https://api.github.com/users/jhstatewide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhstatewide/subscriptions","organizations_url":"https://api.github.com/users/jhstatewide/orgs","repos_url":"https://api.github.com/users/jhstatewide/repos","events_url":"https://api.github.com/users/jhstatewide/events{/privacy}","received_events_url":"https://api.github.com/users/jhstatewide/received_events","type":"User","site_admin":false},"repo":{"id":26403423,"name":"nobrainer","full_name":"jhstatewide/nobrainer","owner":{"login":"jhstatewide","id":49839,"avatar_url":"https://avatars.githubusercontent.com/u/49839?v=3","gravatar_id":"","url":"https://api.github.com/users/jhstatewide","html_url":"https://github.com/jhstatewide","followers_url":"https://api.github.com/users/jhstatewide/followers","following_url":"https://api.github.com/users/jhstatewide/following{/other_user}","gists_url":"https://api.github.com/users/jhstatewide/gists{/gist_id}","starred_url":"https://api.github.com/users/jhstatewide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhstatewide/subscriptions","organizations_url":"https://api.github.com/users/jhstatewide/orgs","repos_url":"https://api.github.com/users/jhstatewide/repos","events_url":"https://api.github.com/users/jhstatewide/events{/privacy}","received_events_url":"https://api.github.com/users/jhstatewide/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jhstatewide/nobrainer","description":"Ruby ORM for RethinkDB","fork":true,"url":"https://api.github.com/repos/jhstatewide/nobrainer","forks_url":"https://api.github.com/repos/jhstatewide/nobrainer/forks","keys_url":"https://api.github.com/repos/jhstatewide/nobrainer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jhstatewide/nobrainer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jhstatewide/nobrainer/teams","hooks_url":"https://api.github.com/repos/jhstatewide/nobrainer/hooks","issue_events_url":"https://api.github.com/repos/jhstatewide/nobrainer/issues/events{/number}","events_url":"https://api.github.com/repos/jhstatewide/nobrainer/events","assignees_url":"https://api.github.com/repos/jhstatewide/nobrainer/assignees{/user}","branches_url":"https://api.github.com/repos/jhstatewide/nobrainer/branches{/branch}","tags_url":"https://api.github.com/repos/jhstatewide/nobrainer/tags","blobs_url":"https://api.github.com/repos/jhstatewide/nobrainer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jhstatewide/nobrainer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jhstatewide/nobrainer/git/refs{/sha}","trees_url":"https://api.github.com/repos/jhstatewide/nobrainer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jhstatewide/nobrainer/statuses/{sha}","languages_url":"https://api.github.com/repos/jhstatewide/nobrainer/languages","stargazers_url":"https://api.github.com/repos/jhstatewide/nobrainer/stargazers","contributors_url":"https://api.github.com/repos/jhstatewide/nobrainer/contributors","subscribers_url":"https://api.github.com/repos/jhstatewide/nobrainer/subscribers","subscription_url":"https://api.github.com/repos/jhstatewide/nobrainer/subscription","commits_url":"https://api.github.com/repos/jhstatewide/nobrainer/commits{/sha}","git_commits_url":"https://api.github.com/repos/jhstatewide/nobrainer/git/commits{/sha}","comments_url":"https://api.github.com/repos/jhstatewide/nobrainer/comments{/number}","issue_comment_url":"https://api.github.com/repos/jhstatewide/nobrainer/issues/comments/{number}","contents_url":"https://api.github.com/repos/jhstatewide/nobrainer/contents/{+path}","compare_url":"https://api.github.com/repos/jhstatewide/nobrainer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jhstatewide/nobrainer/merges","archive_url":"https://api.github.com/repos/jhstatewide/nobrainer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jhstatewide/nobrainer/downloads","issues_url":"https://api.github.com/repos/jhstatewide/nobrainer/issues{/number}","pulls_url":"https://api.github.com/repos/jhstatewide/nobrainer/pulls{/number}","milestones_url":"https://api.github.com/repos/jhstatewide/nobrainer/milestones{/number}","notifications_url":"https://api.github.com/repos/jhstatewide/nobrainer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jhstatewide/nobrainer/labels{/name}","releases_url":"https://api.github.com/repos/jhstatewide/nobrainer/releases{/id}","created_at":"2014-11-09T17:39:29Z","updated_at":"2014-11-09T23:51:25Z","pushed_at":"2014-11-10T05:33:23Z","git_url":"git://github.com/jhstatewide/nobrainer.git","ssh_url":"git@github.com:jhstatewide/nobrainer.git","clone_url":"https://github.com/jhstatewide/nobrainer.git","svn_url":"https://github.com/jhstatewide/nobrainer","homepage":"http://nobrainer.io/","size":2231,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nviennot:master","ref":"master","sha":"38d2fd12bd6d61375acfd4aeb8264c59c3fcc421","user":{"login":"nviennot","id":297060,"avatar_url":"https://avatars.githubusercontent.com/u/297060?v=3","gravatar_id":"","url":"https://api.github.com/users/nviennot","html_url":"https://github.com/nviennot","followers_url":"https://api.github.com/users/nviennot/followers","following_url":"https://api.github.com/users/nviennot/following{/other_user}","gists_url":"https://api.github.com/users/nviennot/gists{/gist_id}","starred_url":"https://api.github.com/users/nviennot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nviennot/subscriptions","organizations_url":"https://api.github.com/users/nviennot/orgs","repos_url":"https://api.github.com/users/nviennot/repos","events_url":"https://api.github.com/users/nviennot/events{/privacy}","received_events_url":"https://api.github.com/users/nviennot/received_events","type":"User","site_admin":false},"repo":{"id":7284265,"name":"nobrainer","full_name":"nviennot/nobrainer","owner":{"login":"nviennot","id":297060,"avatar_url":"https://avatars.githubusercontent.com/u/297060?v=3","gravatar_id":"","url":"https://api.github.com/users/nviennot","html_url":"https://github.com/nviennot","followers_url":"https://api.github.com/users/nviennot/followers","following_url":"https://api.github.com/users/nviennot/following{/other_user}","gists_url":"https://api.github.com/users/nviennot/gists{/gist_id}","starred_url":"https://api.github.com/users/nviennot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nviennot/subscriptions","organizations_url":"https://api.github.com/users/nviennot/orgs","repos_url":"https://api.github.com/users/nviennot/repos","events_url":"https://api.github.com/users/nviennot/events{/privacy}","received_events_url":"https://api.github.com/users/nviennot/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nviennot/nobrainer","description":"Ruby ORM for RethinkDB","fork":false,"url":"https://api.github.com/repos/nviennot/nobrainer","forks_url":"https://api.github.com/repos/nviennot/nobrainer/forks","keys_url":"https://api.github.com/repos/nviennot/nobrainer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nviennot/nobrainer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nviennot/nobrainer/teams","hooks_url":"https://api.github.com/repos/nviennot/nobrainer/hooks","issue_events_url":"https://api.github.com/repos/nviennot/nobrainer/issues/events{/number}","events_url":"https://api.github.com/repos/nviennot/nobrainer/events","assignees_url":"https://api.github.com/repos/nviennot/nobrainer/assignees{/user}","branches_url":"https://api.github.com/repos/nviennot/nobrainer/branches{/branch}","tags_url":"https://api.github.com/repos/nviennot/nobrainer/tags","blobs_url":"https://api.github.com/repos/nviennot/nobrainer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nviennot/nobrainer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nviennot/nobrainer/git/refs{/sha}","trees_url":"https://api.github.com/repos/nviennot/nobrainer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nviennot/nobrainer/statuses/{sha}","languages_url":"https://api.github.com/repos/nviennot/nobrainer/languages","stargazers_url":"https://api.github.com/repos/nviennot/nobrainer/stargazers","contributors_url":"https://api.github.com/repos/nviennot/nobrainer/contributors","subscribers_url":"https://api.github.com/repos/nviennot/nobrainer/subscribers","subscription_url":"https://api.github.com/repos/nviennot/nobrainer/subscription","commits_url":"https://api.github.com/repos/nviennot/nobrainer/commits{/sha}","git_commits_url":"https://api.github.com/repos/nviennot/nobrainer/git/commits{/sha}","comments_url":"https://api.github.com/repos/nviennot/nobrainer/comments{/number}","issue_comment_url":"https://api.github.com/repos/nviennot/nobrainer/issues/comments/{number}","contents_url":"https://api.github.com/repos/nviennot/nobrainer/contents/{+path}","compare_url":"https://api.github.com/repos/nviennot/nobrainer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nviennot/nobrainer/merges","archive_url":"https://api.github.com/repos/nviennot/nobrainer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nviennot/nobrainer/downloads","issues_url":"https://api.github.com/repos/nviennot/nobrainer/issues{/number}","pulls_url":"https://api.github.com/repos/nviennot/nobrainer/pulls{/number}","milestones_url":"https://api.github.com/repos/nviennot/nobrainer/milestones{/number}","notifications_url":"https://api.github.com/repos/nviennot/nobrainer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nviennot/nobrainer/labels{/name}","releases_url":"https://api.github.com/repos/nviennot/nobrainer/releases{/id}","created_at":"2012-12-22T09:12:52Z","updated_at":"2014-11-08T03:22:20Z","pushed_at":"2014-11-09T21:10:20Z","git_url":"git://github.com/nviennot/nobrainer.git","ssh_url":"git@github.com:nviennot/nobrainer.git","clone_url":"https://github.com/nviennot/nobrainer.git","svn_url":"https://github.com/nviennot/nobrainer","homepage":"http://nobrainer.io/","size":2231,"stargazers_count":168,"watchers_count":168,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":24,"mirror_url":null,"open_issues_count":3,"forks":24,"open_issues":3,"watchers":168,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nviennot/nobrainer/pulls/102"},"html":{"href":"https://github.com/nviennot/nobrainer/pull/102"},"issue":{"href":"https://api.github.com/repos/nviennot/nobrainer/issues/102"},"comments":{"href":"https://api.github.com/repos/nviennot/nobrainer/issues/102/comments"},"review_comments":{"href":"https://api.github.com/repos/nviennot/nobrainer/pulls/102/comments"},"review_comment":{"href":"https://api.github.com/repos/nviennot/nobrainer/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/nviennot/nobrainer/pulls/102/commits"},"statuses":{"href":"https://api.github.com/repos/nviennot/nobrainer/statuses/3fdd4b65008941c71662884982466938404fed28"}}}}