GitHub PullRequestReviewCommentEvent at 2014-11-07 16:02:49
Repository: ffi-aspell
Actor: YorickPeterse
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/YorickPeterse/ffi-aspell/pulls/comments/20018330","id":20018330,"diff_hunk":"@@ -413,7 +434,29 @@ def update_speller\n           self,\n           self.class.finalizer(@config, @speller)\n         )\n+        check_dictionary\n       end\n+\n+      ## \n+      # Get all availbale aspell dictionary codes\n+      #\n+      # @return [Array]\n+      #\n+      def available_dictionaries\n+        config = Aspell.config_new\n+        list = Aspell.dict_info_list(config)\n+        elements = Aspell.dict_info_list_elements(list)\n+\n+        dicts = []\n+        while element = Aspell.dict_info_enumeration_next(elements)","path":"lib/ffi/aspell/speller.rb","position":53,"original_position":53,"commit_id":"6231571a751bbee586ffa3161409d78ee747c24c","original_commit_id":"6231571a751bbee586ffa3161409d78ee747c24c","user":{"login":"YorickPeterse","id":86065,"avatar_url":"https://avatars.githubusercontent.com/u/86065?v=3","gravatar_id":"","url":"https://api.github.com/users/YorickPeterse","html_url":"https://github.com/YorickPeterse","followers_url":"https://api.github.com/users/YorickPeterse/followers","following_url":"https://api.github.com/users/YorickPeterse/following{/other_user}","gists_url":"https://api.github.com/users/YorickPeterse/gists{/gist_id}","starred_url":"https://api.github.com/users/YorickPeterse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YorickPeterse/subscriptions","organizations_url":"https://api.github.com/users/YorickPeterse/orgs","repos_url":"https://api.github.com/users/YorickPeterse/repos","events_url":"https://api.github.com/users/YorickPeterse/events{/privacy}","received_events_url":"https://api.github.com/users/YorickPeterse/received_events","type":"User","site_admin":false},"body":"Please add an empty line above the `while` statement.","created_at":"2014-11-07T16:02:49Z","updated_at":"2014-11-07T16:02:49Z","html_url":"https://github.com/YorickPeterse/ffi-aspell/pull/20#discussion_r20018330","pull_request_url":"https://api.github.com/repos/YorickPeterse/ffi-aspell/pulls/20","_links":{"self":{"href":"https://api.github.com/repos/YorickPeterse/ffi-aspell/pulls/comments/20018330"},"html":{"href":"https://github.com/YorickPeterse/ffi-aspell/pull/20#discussion_r20018330"},"pull_request":{"href":"https://api.github.com/repos/YorickPeterse/ffi-aspell/pulls/20"}}},"pull_request":{"url":"https://api.github.com/repos/YorickPeterse/ffi-aspell/pulls/20","id":24057621,"html_url":"https://github.com/YorickPeterse/ffi-aspell/pull/20","diff_url":"https://github.com/YorickPeterse/ffi-aspell/pull/20.diff","patch_url":"https://github.com/YorickPeterse/ffi-aspell/pull/20.patch","issue_url":"https://api.github.com/repos/YorickPeterse/ffi-aspell/issues/20","number":20,"state":"open","locked":false,"title":"checking dictionaries after speller is created","user":{"login":"stetro","id":805263,"avatar_url":"https://avatars.githubusercontent.com/u/805263?v=3","gravatar_id":"","url":"https://api.github.com/users/stetro","html_url":"https://github.com/stetro","followers_url":"https://api.github.com/users/stetro/followers","following_url":"https://api.github.com/users/stetro/following{/other_user}","gists_url":"https://api.github.com/users/stetro/gists{/gist_id}","starred_url":"https://api.github.com/users/stetro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stetro/subscriptions","organizations_url":"https://api.github.com/users/stetro/orgs","repos_url":"https://api.github.com/users/stetro/repos","events_url":"https://api.github.com/users/stetro/events{/privacy}","received_events_url":"https://api.github.com/users/stetro/received_events","type":"User","site_admin":false},"body":"When a aspell dictionary is not installed, this library normaly does a core dump. \r\nThese changes are comparing the available dictionaries with the selected one. \r\nIt now raises an error when a dictionary is not availbale.","created_at":"2014-11-07T14:56:21Z","updated_at":"2014-11-07T16:02:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"57b5acc7299de6d374616afdfd88e3962901c693","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/YorickPeterse/ffi-aspell/pulls/20/commits","review_comments_url":"https://api.github.com/repos/YorickPeterse/ffi-aspell/pulls/20/comments","review_comment_url":"https://api.github.com/repos/YorickPeterse/ffi-aspell/pulls/comments/{number}","comments_url":"https://api.github.com/repos/YorickPeterse/ffi-aspell/issues/20/comments","statuses_url":"https://api.github.com/repos/YorickPeterse/ffi-aspell/statuses/6231571a751bbee586ffa3161409d78ee747c24c","head":{"label":"stetro:master","ref":"master","sha":"6231571a751bbee586ffa3161409d78ee747c24c","user":{"login":"stetro","id":805263,"avatar_url":"https://avatars.githubusercontent.com/u/805263?v=3","gravatar_id":"","url":"https://api.github.com/users/stetro","html_url":"https://github.com/stetro","followers_url":"https://api.github.com/users/stetro/followers","following_url":"https://api.github.com/users/stetro/following{/other_user}","gists_url":"https://api.github.com/users/stetro/gists{/gist_id}","starred_url":"https://api.github.com/users/stetro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stetro/subscriptions","organizations_url":"https://api.github.com/users/stetro/orgs","repos_url":"https://api.github.com/users/stetro/repos","events_url":"https://api.github.com/users/stetro/events{/privacy}","received_events_url":"https://api.github.com/users/stetro/received_events","type":"User","site_admin":false},"repo":{"id":26319465,"name":"ffi-aspell","full_name":"stetro/ffi-aspell","owner":{"login":"stetro","id":805263,"avatar_url":"https://avatars.githubusercontent.com/u/805263?v=3","gravatar_id":"","url":"https://api.github.com/users/stetro","html_url":"https://github.com/stetro","followers_url":"https://api.github.com/users/stetro/followers","following_url":"https://api.github.com/users/stetro/following{/other_user}","gists_url":"https://api.github.com/users/stetro/gists{/gist_id}","starred_url":"https://api.github.com/users/stetro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stetro/subscriptions","organizations_url":"https://api.github.com/users/stetro/orgs","repos_url":"https://api.github.com/users/stetro/repos","events_url":"https://api.github.com/users/stetro/events{/privacy}","received_events_url":"https://api.github.com/users/stetro/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stetro/ffi-aspell","description":"FFI binding for Aspell","fork":true,"url":"https://api.github.com/repos/stetro/ffi-aspell","forks_url":"https://api.github.com/repos/stetro/ffi-aspell/forks","keys_url":"https://api.github.com/repos/stetro/ffi-aspell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stetro/ffi-aspell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stetro/ffi-aspell/teams","hooks_url":"https://api.github.com/repos/stetro/ffi-aspell/hooks","issue_events_url":"https://api.github.com/repos/stetro/ffi-aspell/issues/events{/number}","events_url":"https://api.github.com/repos/stetro/ffi-aspell/events","assignees_url":"https://api.github.com/repos/stetro/ffi-aspell/assignees{/user}","branches_url":"https://api.github.com/repos/stetro/ffi-aspell/branches{/branch}","tags_url":"https://api.github.com/repos/stetro/ffi-aspell/tags","blobs_url":"https://api.github.com/repos/stetro/ffi-aspell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stetro/ffi-aspell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stetro/ffi-aspell/git/refs{/sha}","trees_url":"https://api.github.com/repos/stetro/ffi-aspell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stetro/ffi-aspell/statuses/{sha}","languages_url":"https://api.github.com/repos/stetro/ffi-aspell/languages","stargazers_url":"https://api.github.com/repos/stetro/ffi-aspell/stargazers","contributors_url":"https://api.github.com/repos/stetro/ffi-aspell/contributors","subscribers_url":"https://api.github.com/repos/stetro/ffi-aspell/subscribers","subscription_url":"https://api.github.com/repos/stetro/ffi-aspell/subscription","commits_url":"https://api.github.com/repos/stetro/ffi-aspell/commits{/sha}","git_commits_url":"https://api.github.com/repos/stetro/ffi-aspell/git/commits{/sha}","comments_url":"https://api.github.com/repos/stetro/ffi-aspell/comments{/number}","issue_comment_url":"https://api.github.com/repos/stetro/ffi-aspell/issues/comments/{number}","contents_url":"https://api.github.com/repos/stetro/ffi-aspell/contents/{+path}","compare_url":"https://api.github.com/repos/stetro/ffi-aspell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stetro/ffi-aspell/merges","archive_url":"https://api.github.com/repos/stetro/ffi-aspell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stetro/ffi-aspell/downloads","issues_url":"https://api.github.com/repos/stetro/ffi-aspell/issues{/number}","pulls_url":"https://api.github.com/repos/stetro/ffi-aspell/pulls{/number}","milestones_url":"https://api.github.com/repos/stetro/ffi-aspell/milestones{/number}","notifications_url":"https://api.github.com/repos/stetro/ffi-aspell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stetro/ffi-aspell/labels{/name}","releases_url":"https://api.github.com/repos/stetro/ffi-aspell/releases{/id}","created_at":"2014-11-07T12:48:07Z","updated_at":"2014-11-07T14:28:40Z","pushed_at":"2014-11-07T14:48:55Z","git_url":"git://github.com/stetro/ffi-aspell.git","ssh_url":"git@github.com:stetro/ffi-aspell.git","clone_url":"https://github.com/stetro/ffi-aspell.git","svn_url":"https://github.com/stetro/ffi-aspell","homepage":"http://rubydoc.info/gems/ffi-aspell/","size":286,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"YorickPeterse:master","ref":"master","sha":"7f9517992b05857862b573776c3ea9ff1eb2d212","user":{"login":"YorickPeterse","id":86065,"avatar_url":"https://avatars.githubusercontent.com/u/86065?v=3","gravatar_id":"","url":"https://api.github.com/users/YorickPeterse","html_url":"https://github.com/YorickPeterse","followers_url":"https://api.github.com/users/YorickPeterse/followers","following_url":"https://api.github.com/users/YorickPeterse/following{/other_user}","gists_url":"https://api.github.com/users/YorickPeterse/gists{/gist_id}","starred_url":"https://api.github.com/users/YorickPeterse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YorickPeterse/subscriptions","organizations_url":"https://api.github.com/users/YorickPeterse/orgs","repos_url":"https://api.github.com/users/YorickPeterse/repos","events_url":"https://api.github.com/users/YorickPeterse/events{/privacy}","received_events_url":"https://api.github.com/users/YorickPeterse/received_events","type":"User","site_admin":false},"repo":{"id":4018338,"name":"ffi-aspell","full_name":"YorickPeterse/ffi-aspell","owner":{"login":"YorickPeterse","id":86065,"avatar_url":"https://avatars.githubusercontent.com/u/86065?v=3","gravatar_id":"","url":"https://api.github.com/users/YorickPeterse","html_url":"https://github.com/YorickPeterse","followers_url":"https://api.github.com/users/YorickPeterse/followers","following_url":"https://api.github.com/users/YorickPeterse/following{/other_user}","gists_url":"https://api.github.com/users/YorickPeterse/gists{/gist_id}","starred_url":"https://api.github.com/users/YorickPeterse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YorickPeterse/subscriptions","organizations_url":"https://api.github.com/users/YorickPeterse/orgs","repos_url":"https://api.github.com/users/YorickPeterse/repos","events_url":"https://api.github.com/users/YorickPeterse/events{/privacy}","received_events_url":"https://api.github.com/users/YorickPeterse/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/YorickPeterse/ffi-aspell","description":"FFI binding for Aspell","fork":false,"url":"https://api.github.com/repos/YorickPeterse/ffi-aspell","forks_url":"https://api.github.com/repos/YorickPeterse/ffi-aspell/forks","keys_url":"https://api.github.com/repos/YorickPeterse/ffi-aspell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/YorickPeterse/ffi-aspell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/YorickPeterse/ffi-aspell/teams","hooks_url":"https://api.github.com/repos/YorickPeterse/ffi-aspell/hooks","issue_events_url":"https://api.github.com/repos/YorickPeterse/ffi-aspell/issues/events{/number}","events_url":"https://api.github.com/repos/YorickPeterse/ffi-aspell/events","assignees_url":"https://api.github.com/repos/YorickPeterse/ffi-aspell/assignees{/user}","branches_url":"https://api.github.com/repos/YorickPeterse/ffi-aspell/branches{/branch}","tags_url":"https://api.github.com/repos/YorickPeterse/ffi-aspell/tags","blobs_url":"https://api.github.com/repos/YorickPeterse/ffi-aspell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/YorickPeterse/ffi-aspell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/YorickPeterse/ffi-aspell/git/refs{/sha}","trees_url":"https://api.github.com/repos/YorickPeterse/ffi-aspell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/YorickPeterse/ffi-aspell/statuses/{sha}","languages_url":"https://api.github.com/repos/YorickPeterse/ffi-aspell/languages","stargazers_url":"https://api.github.com/repos/YorickPeterse/ffi-aspell/stargazers","contributors_url":"https://api.github.com/repos/YorickPeterse/ffi-aspell/contributors","subscribers_url":"https://api.github.com/repos/YorickPeterse/ffi-aspell/subscribers","subscription_url":"https://api.github.com/repos/YorickPeterse/ffi-aspell/subscription","commits_url":"https://api.github.com/repos/YorickPeterse/ffi-aspell/commits{/sha}","git_commits_url":"https://api.github.com/repos/YorickPeterse/ffi-aspell/git/commits{/sha}","comments_url":"https://api.github.com/repos/YorickPeterse/ffi-aspell/comments{/number}","issue_comment_url":"https://api.github.com/repos/YorickPeterse/ffi-aspell/issues/comments/{number}","contents_url":"https://api.github.com/repos/YorickPeterse/ffi-aspell/contents/{+path}","compare_url":"https://api.github.com/repos/YorickPeterse/ffi-aspell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/YorickPeterse/ffi-aspell/merges","archive_url":"https://api.github.com/repos/YorickPeterse/ffi-aspell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/YorickPeterse/ffi-aspell/downloads","issues_url":"https://api.github.com/repos/YorickPeterse/ffi-aspell/issues{/number}","pulls_url":"https://api.github.com/repos/YorickPeterse/ffi-aspell/pulls{/number}","milestones_url":"https://api.github.com/repos/YorickPeterse/ffi-aspell/milestones{/number}","notifications_url":"https://api.github.com/repos/YorickPeterse/ffi-aspell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/YorickPeterse/ffi-aspell/labels{/name}","releases_url":"https://api.github.com/repos/YorickPeterse/ffi-aspell/releases{/id}","created_at":"2012-04-13T17:14:34Z","updated_at":"2014-10-30T22:44:10Z","pushed_at":"2014-11-05T14:33:58Z","git_url":"git://github.com/YorickPeterse/ffi-aspell.git","ssh_url":"git@github.com:YorickPeterse/ffi-aspell.git","clone_url":"https://github.com/YorickPeterse/ffi-aspell.git","svn_url":"https://github.com/YorickPeterse/ffi-aspell","homepage":"http://rubydoc.info/gems/ffi-aspell/","size":286,"stargazers_count":41,"watchers_count":41,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":2,"forks":13,"open_issues":2,"watchers":41,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/YorickPeterse/ffi-aspell/pulls/20"},"html":{"href":"https://github.com/YorickPeterse/ffi-aspell/pull/20"},"issue":{"href":"https://api.github.com/repos/YorickPeterse/ffi-aspell/issues/20"},"comments":{"href":"https://api.github.com/repos/YorickPeterse/ffi-aspell/issues/20/comments"},"review_comments":{"href":"https://api.github.com/repos/YorickPeterse/ffi-aspell/pulls/20/comments"},"review_comment":{"href":"https://api.github.com/repos/YorickPeterse/ffi-aspell/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/YorickPeterse/ffi-aspell/pulls/20/commits"},"statuses":{"href":"https://api.github.com/repos/YorickPeterse/ffi-aspell/statuses/6231571a751bbee586ffa3161409d78ee747c24c"}}}}