GitHub PullRequestReviewCommentEvent at 2014-08-14 15:06:15
Repository: edx-platform
Actor: jmclaus
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/comments/16243353","id":16243353,"diff_hunk":"@@ -21,17 +21,17 @@ define([\"jquery\", \"js/spec_helpers/create_sinon\", \"js/spec_helpers/view_helpers\"\n                     edited_on: 'Jul 02, 2014 at 20:56 UTC',\n                     edited_by: 'MockUser',\n                     child_info: {\n-                        display_name: 'Section',\n                         category: 'chapter',\n-                        children: children\n+                        display_name: 'Section',\n+                        children: []\n                     }\n-                };\n+                }, options, {child_info: {children: children}});\n             };","path":"cms/static/js/spec/views/pages/course_outline_spec.js","position":33,"original_position":33,"commit_id":"82dacc09984cf7bdeb7cf786ab114ae05c8fd80f","original_commit_id":"82dacc09984cf7bdeb7cf786ab114ae05c8fd80f","user":{"login":"jmclaus","id":1427382,"avatar_url":"https://avatars.githubusercontent.com/u/1427382?v=2","gravatar_id":"3d5a5b850789d1ed61841d46f54635bb","url":"https://api.github.com/users/jmclaus","html_url":"https://github.com/jmclaus","followers_url":"https://api.github.com/users/jmclaus/followers","following_url":"https://api.github.com/users/jmclaus/following{/other_user}","gists_url":"https://api.github.com/users/jmclaus/gists{/gist_id}","starred_url":"https://api.github.com/users/jmclaus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmclaus/subscriptions","organizations_url":"https://api.github.com/users/jmclaus/orgs","repos_url":"https://api.github.com/users/jmclaus/repos","events_url":"https://api.github.com/users/jmclaus/events{/privacy}","received_events_url":"https://api.github.com/users/jmclaus/received_events","type":"User","site_admin":false},"body":"@tymofij Please add space between function definitions.","created_at":"2014-08-14T15:06:15Z","updated_at":"2014-08-14T15:06:15Z","html_url":"https://github.com/edx/edx-platform/pull/4750#discussion_r16243353","pull_request_url":"https://api.github.com/repos/edx/edx-platform/pulls/4750","_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments/16243353"},"html":{"href":"https://github.com/edx/edx-platform/pull/4750#discussion_r16243353"},"pull_request":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/4750"}}},"pull_request":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/4750","id":19521216,"html_url":"https://github.com/edx/edx-platform/pull/4750","diff_url":"https://github.com/edx/edx-platform/pull/4750.diff","patch_url":"https://github.com/edx/edx-platform/pull/4750.patch","issue_url":"https://api.github.com/repos/edx/edx-platform/issues/4750","number":4750,"state":"open","locked":false,"title":"Publish sections/subsections/units from course outline. ","user":{"login":"polesye","id":1247491,"avatar_url":"https://avatars.githubusercontent.com/u/1247491?v=2","gravatar_id":"d1c0cb415bb2b43f91a79ae310c8770a","url":"https://api.github.com/users/polesye","html_url":"https://github.com/polesye","followers_url":"https://api.github.com/users/polesye/followers","following_url":"https://api.github.com/users/polesye/following{/other_user}","gists_url":"https://api.github.com/users/polesye/gists{/gist_id}","starred_url":"https://api.github.com/users/polesye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/polesye/subscriptions","organizations_url":"https://api.github.com/users/polesye/orgs","repos_url":"https://api.github.com/users/polesye/repos","events_url":"https://api.github.com/users/polesye/events{/privacy}","received_events_url":"https://api.github.com/users/polesye/received_events","type":"User","site_admin":false},"body":"**Tickets:** [STUD-1911](https://openedx.atlassian.net/browse/STUD-1911), [STUD-1932](https://openedx.atlassian.net/browse/STUD-1932)\r\n\r\n**Acceptance criteria:**\r\n* Selecting the Publish option from the course outline should bring up a pop-up confirming the publication of all unpublished changes for the section/subsection/unit, with options to publish or cancel publishing. \r\n* All course content in that unit should be immediately be set to “Public” and be visible to students if the release date is in the past. \r\n* The course outline should update to reflect the published status after the bulk publish action.\r\n\r\nSandbox: http://tymofij.m.sandbox.edx.org/\r\nPerformance is not affected. It was measured as execution time for \r\n\r\n        course_module = _get_course_module(course_key, user, depth=None)\r\n        _course_outline_json(request, course_module)\r\n","created_at":"2014-08-08T11:06:23Z","updated_at":"2014-08-14T15:06:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"327baf4ecb1a192534e2df9a418b0327c026a3fc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/edx/edx-platform/pulls/4750/commits","review_comments_url":"https://api.github.com/repos/edx/edx-platform/pulls/4750/comments","review_comment_url":"https://api.github.com/repos/edx/edx-platform/pulls/comments/{number}","comments_url":"https://api.github.com/repos/edx/edx-platform/issues/4750/comments","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/82dacc09984cf7bdeb7cf786ab114ae05c8fd80f","head":{"label":"edx:anton/publish-unit-from-course-outline","ref":"anton/publish-unit-from-course-outline","sha":"82dacc09984cf7bdeb7cf786ab114ae05c8fd80f","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=2","gravatar_id":"e1f6c6dc8772c47c0261cd5df2ed2814","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"name":"edx-platform","full_name":"edx/edx-platform","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=2","gravatar_id":"e1f6c6dc8772c47c0261cd5df2ed2814","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-platform","description":"Open edX, the edX platform that powers http://edx.org","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments/{number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","created_at":"2013-05-30T20:20:38Z","updated_at":"2014-08-14T09:30:21Z","pushed_at":"2014-08-14T15:00:26Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"git@github.com:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://openedx.org/","size":1546497,"stargazers_count":1365,"watchers_count":1365,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":761,"mirror_url":null,"open_issues_count":104,"forks":761,"open_issues":104,"watchers":1365,"default_branch":"master"}},"base":{"label":"edx:master","ref":"master","sha":"681438f09366e64edf8ee6517a810df1fdfcd81a","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=2","gravatar_id":"e1f6c6dc8772c47c0261cd5df2ed2814","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"name":"edx-platform","full_name":"edx/edx-platform","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=2","gravatar_id":"e1f6c6dc8772c47c0261cd5df2ed2814","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-platform","description":"Open edX, the edX platform that powers http://edx.org","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments/{number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","created_at":"2013-05-30T20:20:38Z","updated_at":"2014-08-14T09:30:21Z","pushed_at":"2014-08-14T15:00:26Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"git@github.com:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://openedx.org/","size":1546497,"stargazers_count":1365,"watchers_count":1365,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":761,"mirror_url":null,"open_issues_count":104,"forks":761,"open_issues":104,"watchers":1365,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/4750"},"html":{"href":"https://github.com/edx/edx-platform/pull/4750"},"issue":{"href":"https://api.github.com/repos/edx/edx-platform/issues/4750"},"comments":{"href":"https://api.github.com/repos/edx/edx-platform/issues/4750/comments"},"review_comments":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/4750/comments"},"review_comment":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/4750/commits"},"statuses":{"href":"https://api.github.com/repos/edx/edx-platform/statuses/82dacc09984cf7bdeb7cf786ab114ae05c8fd80f"}}}}