GitHub PullRequestReviewCommentEvent at 2014-10-20 19:40:13
Repository: genome
Actor: nnutter
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/genome/genome/pulls/comments/19108203","id":19108203,"diff_hunk":"@@ -63,8 +63,10 @@ sub resolve_plan_attributes {\n     }\n     my $translations;\n     eval { $translations = $self->provider->get_attribute('translations') };\n-    if (my $error = Exception::Class->caught('NoTranslationsException')) {\n-        die $error;\n+    if (my $error = Exception::Class->caught()) {\n+        unless ($error->isa('NonexistentAttributeException')) {\n+            die $error;","path":"lib/perl/Genome/VariantReporting/Framework/Component/Adaptor.pm","position":8,"original_position":8,"commit_id":"151df3ff26a285451b0c755c5d405bb8a75e93ac","original_commit_id":"151df3ff26a285451b0c755c5d405bb8a75e93ac","user":{"login":"nnutter","id":207011,"avatar_url":"https://avatars.githubusercontent.com/u/207011?v=2","gravatar_id":"","url":"https://api.github.com/users/nnutter","html_url":"https://github.com/nnutter","followers_url":"https://api.github.com/users/nnutter/followers","following_url":"https://api.github.com/users/nnutter/following{/other_user}","gists_url":"https://api.github.com/users/nnutter/gists{/gist_id}","starred_url":"https://api.github.com/users/nnutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nnutter/subscriptions","organizations_url":"https://api.github.com/users/nnutter/orgs","repos_url":"https://api.github.com/users/nnutter/repos","events_url":"https://api.github.com/users/nnutter/events{/privacy}","received_events_url":"https://api.github.com/users/nnutter/received_events","type":"User","site_admin":false},"body":"There are three states though; if a `NonexistentAttributeException` is caught then the function should essentially return (as previously written).  Also, global variables like `$@` scare me so I always capture `$@` immediately after `eval`.","created_at":"2014-10-20T19:40:13Z","updated_at":"2014-10-20T19:40:13Z","html_url":"https://github.com/genome/genome/pull/119#discussion_r19108203","pull_request_url":"https://api.github.com/repos/genome/genome/pulls/119","_links":{"self":{"href":"https://api.github.com/repos/genome/genome/pulls/comments/19108203"},"html":{"href":"https://github.com/genome/genome/pull/119#discussion_r19108203"},"pull_request":{"href":"https://api.github.com/repos/genome/genome/pulls/119"}}},"pull_request":{"url":"https://api.github.com/repos/genome/genome/pulls/119","id":23014656,"html_url":"https://github.com/genome/genome/pull/119","diff_url":"https://github.com/genome/genome/pull/119.diff","patch_url":"https://github.com/genome/genome/pull/119.patch","issue_url":"https://api.github.com/repos/genome/genome/issues/119","number":119,"state":"open","locked":false,"title":"Catch the correct type of translation error","user":{"login":"susannasiebert","id":6617192,"avatar_url":"https://avatars.githubusercontent.com/u/6617192?v=2","gravatar_id":"","url":"https://api.github.com/users/susannasiebert","html_url":"https://github.com/susannasiebert","followers_url":"https://api.github.com/users/susannasiebert/followers","following_url":"https://api.github.com/users/susannasiebert/following{/other_user}","gists_url":"https://api.github.com/users/susannasiebert/gists{/gist_id}","starred_url":"https://api.github.com/users/susannasiebert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/susannasiebert/subscriptions","organizations_url":"https://api.github.com/users/susannasiebert/orgs","repos_url":"https://api.github.com/users/susannasiebert/repos","events_url":"https://api.github.com/users/susannasiebert/events{/privacy}","received_events_url":"https://api.github.com/users/susannasiebert/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-10-20T13:36:26Z","updated_at":"2014-10-20T19:40:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dde420393e26314ac9d4f069cf03f78b0cf55c36","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/genome/genome/pulls/119/commits","review_comments_url":"https://api.github.com/repos/genome/genome/pulls/119/comments","review_comment_url":"https://api.github.com/repos/genome/genome/pulls/comments/{number}","comments_url":"https://api.github.com/repos/genome/genome/issues/119/comments","statuses_url":"https://api.github.com/repos/genome/genome/statuses/151df3ff26a285451b0c755c5d405bb8a75e93ac","head":{"label":"susannasiebert:translation_errors","ref":"translation_errors","sha":"151df3ff26a285451b0c755c5d405bb8a75e93ac","user":{"login":"susannasiebert","id":6617192,"avatar_url":"https://avatars.githubusercontent.com/u/6617192?v=2","gravatar_id":"","url":"https://api.github.com/users/susannasiebert","html_url":"https://github.com/susannasiebert","followers_url":"https://api.github.com/users/susannasiebert/followers","following_url":"https://api.github.com/users/susannasiebert/following{/other_user}","gists_url":"https://api.github.com/users/susannasiebert/gists{/gist_id}","starred_url":"https://api.github.com/users/susannasiebert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/susannasiebert/subscriptions","organizations_url":"https://api.github.com/users/susannasiebert/orgs","repos_url":"https://api.github.com/users/susannasiebert/repos","events_url":"https://api.github.com/users/susannasiebert/events{/privacy}","received_events_url":"https://api.github.com/users/susannasiebert/received_events","type":"User","site_admin":false},"repo":{"id":23836901,"name":"genome","full_name":"susannasiebert/genome","owner":{"login":"susannasiebert","id":6617192,"avatar_url":"https://avatars.githubusercontent.com/u/6617192?v=2","gravatar_id":"","url":"https://api.github.com/users/susannasiebert","html_url":"https://github.com/susannasiebert","followers_url":"https://api.github.com/users/susannasiebert/followers","following_url":"https://api.github.com/users/susannasiebert/following{/other_user}","gists_url":"https://api.github.com/users/susannasiebert/gists{/gist_id}","starred_url":"https://api.github.com/users/susannasiebert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/susannasiebert/subscriptions","organizations_url":"https://api.github.com/users/susannasiebert/orgs","repos_url":"https://api.github.com/users/susannasiebert/repos","events_url":"https://api.github.com/users/susannasiebert/events{/privacy}","received_events_url":"https://api.github.com/users/susannasiebert/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/susannasiebert/genome","description":"","fork":true,"url":"https://api.github.com/repos/susannasiebert/genome","forks_url":"https://api.github.com/repos/susannasiebert/genome/forks","keys_url":"https://api.github.com/repos/susannasiebert/genome/keys{/key_id}","collaborators_url":"https://api.github.com/repos/susannasiebert/genome/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/susannasiebert/genome/teams","hooks_url":"https://api.github.com/repos/susannasiebert/genome/hooks","issue_events_url":"https://api.github.com/repos/susannasiebert/genome/issues/events{/number}","events_url":"https://api.github.com/repos/susannasiebert/genome/events","assignees_url":"https://api.github.com/repos/susannasiebert/genome/assignees{/user}","branches_url":"https://api.github.com/repos/susannasiebert/genome/branches{/branch}","tags_url":"https://api.github.com/repos/susannasiebert/genome/tags","blobs_url":"https://api.github.com/repos/susannasiebert/genome/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/susannasiebert/genome/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/susannasiebert/genome/git/refs{/sha}","trees_url":"https://api.github.com/repos/susannasiebert/genome/git/trees{/sha}","statuses_url":"https://api.github.com/repos/susannasiebert/genome/statuses/{sha}","languages_url":"https://api.github.com/repos/susannasiebert/genome/languages","stargazers_url":"https://api.github.com/repos/susannasiebert/genome/stargazers","contributors_url":"https://api.github.com/repos/susannasiebert/genome/contributors","subscribers_url":"https://api.github.com/repos/susannasiebert/genome/subscribers","subscription_url":"https://api.github.com/repos/susannasiebert/genome/subscription","commits_url":"https://api.github.com/repos/susannasiebert/genome/commits{/sha}","git_commits_url":"https://api.github.com/repos/susannasiebert/genome/git/commits{/sha}","comments_url":"https://api.github.com/repos/susannasiebert/genome/comments{/number}","issue_comment_url":"https://api.github.com/repos/susannasiebert/genome/issues/comments/{number}","contents_url":"https://api.github.com/repos/susannasiebert/genome/contents/{+path}","compare_url":"https://api.github.com/repos/susannasiebert/genome/compare/{base}...{head}","merges_url":"https://api.github.com/repos/susannasiebert/genome/merges","archive_url":"https://api.github.com/repos/susannasiebert/genome/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/susannasiebert/genome/downloads","issues_url":"https://api.github.com/repos/susannasiebert/genome/issues{/number}","pulls_url":"https://api.github.com/repos/susannasiebert/genome/pulls{/number}","milestones_url":"https://api.github.com/repos/susannasiebert/genome/milestones{/number}","notifications_url":"https://api.github.com/repos/susannasiebert/genome/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/susannasiebert/genome/labels{/name}","releases_url":"https://api.github.com/repos/susannasiebert/genome/releases{/id}","created_at":"2014-09-09T14:30:47Z","updated_at":"2014-09-10T06:51:41Z","pushed_at":"2014-10-20T14:22:31Z","git_url":"git://github.com/susannasiebert/genome.git","ssh_url":"git@github.com:susannasiebert/genome.git","clone_url":"https://github.com/susannasiebert/genome.git","svn_url":"https://github.com/susannasiebert/genome","homepage":"","size":102250,"stargazers_count":0,"watchers_count":0,"language":"Perl","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"genome:master","ref":"master","sha":"39cf10cf2d0d348066142d40ddcabf165e8185dd","user":{"login":"genome","id":318108,"avatar_url":"https://avatars.githubusercontent.com/u/318108?v=2","gravatar_id":"","url":"https://api.github.com/users/genome","html_url":"https://github.com/genome","followers_url":"https://api.github.com/users/genome/followers","following_url":"https://api.github.com/users/genome/following{/other_user}","gists_url":"https://api.github.com/users/genome/gists{/gist_id}","starred_url":"https://api.github.com/users/genome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/genome/subscriptions","organizations_url":"https://api.github.com/users/genome/orgs","repos_url":"https://api.github.com/users/genome/repos","events_url":"https://api.github.com/users/genome/events{/privacy}","received_events_url":"https://api.github.com/users/genome/received_events","type":"Organization","site_admin":false},"repo":{"id":23442737,"name":"genome","full_name":"genome/genome","owner":{"login":"genome","id":318108,"avatar_url":"https://avatars.githubusercontent.com/u/318108?v=2","gravatar_id":"","url":"https://api.github.com/users/genome","html_url":"https://github.com/genome","followers_url":"https://api.github.com/users/genome/followers","following_url":"https://api.github.com/users/genome/following{/other_user}","gists_url":"https://api.github.com/users/genome/gists{/gist_id}","starred_url":"https://api.github.com/users/genome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/genome/subscriptions","organizations_url":"https://api.github.com/users/genome/orgs","repos_url":"https://api.github.com/users/genome/repos","events_url":"https://api.github.com/users/genome/events{/privacy}","received_events_url":"https://api.github.com/users/genome/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/genome/genome","description":"Core modules used by the GMS","fork":false,"url":"https://api.github.com/repos/genome/genome","forks_url":"https://api.github.com/repos/genome/genome/forks","keys_url":"https://api.github.com/repos/genome/genome/keys{/key_id}","collaborators_url":"https://api.github.com/repos/genome/genome/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/genome/genome/teams","hooks_url":"https://api.github.com/repos/genome/genome/hooks","issue_events_url":"https://api.github.com/repos/genome/genome/issues/events{/number}","events_url":"https://api.github.com/repos/genome/genome/events","assignees_url":"https://api.github.com/repos/genome/genome/assignees{/user}","branches_url":"https://api.github.com/repos/genome/genome/branches{/branch}","tags_url":"https://api.github.com/repos/genome/genome/tags","blobs_url":"https://api.github.com/repos/genome/genome/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/genome/genome/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/genome/genome/git/refs{/sha}","trees_url":"https://api.github.com/repos/genome/genome/git/trees{/sha}","statuses_url":"https://api.github.com/repos/genome/genome/statuses/{sha}","languages_url":"https://api.github.com/repos/genome/genome/languages","stargazers_url":"https://api.github.com/repos/genome/genome/stargazers","contributors_url":"https://api.github.com/repos/genome/genome/contributors","subscribers_url":"https://api.github.com/repos/genome/genome/subscribers","subscription_url":"https://api.github.com/repos/genome/genome/subscription","commits_url":"https://api.github.com/repos/genome/genome/commits{/sha}","git_commits_url":"https://api.github.com/repos/genome/genome/git/commits{/sha}","comments_url":"https://api.github.com/repos/genome/genome/comments{/number}","issue_comment_url":"https://api.github.com/repos/genome/genome/issues/comments/{number}","contents_url":"https://api.github.com/repos/genome/genome/contents/{+path}","compare_url":"https://api.github.com/repos/genome/genome/compare/{base}...{head}","merges_url":"https://api.github.com/repos/genome/genome/merges","archive_url":"https://api.github.com/repos/genome/genome/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/genome/genome/downloads","issues_url":"https://api.github.com/repos/genome/genome/issues{/number}","pulls_url":"https://api.github.com/repos/genome/genome/pulls{/number}","milestones_url":"https://api.github.com/repos/genome/genome/milestones{/number}","notifications_url":"https://api.github.com/repos/genome/genome/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/genome/genome/labels{/name}","releases_url":"https://api.github.com/repos/genome/genome/releases{/id}","created_at":"2014-08-28T20:59:19Z","updated_at":"2014-10-01T00:28:03Z","pushed_at":"2014-10-20T19:27:30Z","git_url":"git://github.com/genome/genome.git","ssh_url":"git@github.com:genome/genome.git","clone_url":"https://github.com/genome/genome.git","svn_url":"https://github.com/genome/genome","homepage":"","size":107117,"stargazers_count":0,"watchers_count":0,"language":"Perl","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":4,"forks":25,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/genome/genome/pulls/119"},"html":{"href":"https://github.com/genome/genome/pull/119"},"issue":{"href":"https://api.github.com/repos/genome/genome/issues/119"},"comments":{"href":"https://api.github.com/repos/genome/genome/issues/119/comments"},"review_comments":{"href":"https://api.github.com/repos/genome/genome/pulls/119/comments"},"review_comment":{"href":"https://api.github.com/repos/genome/genome/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/genome/genome/pulls/119/commits"},"statuses":{"href":"https://api.github.com/repos/genome/genome/statuses/151df3ff26a285451b0c755c5d405bb8a75e93ac"}}}}