GitHub PullRequestReviewCommentEvent at 2014-11-23 02:14:53
Repository: core
Actor: jboning
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/bravecollective/core/pulls/comments/20761523","id":20761523,"diff_hunk":"@@ -45,11 +45,18 @@ def run(self):\n     @staticmethod\n     def update_key(k):\n         key = EVECredential.objects(key=k).first()\n+        if not key:\n+            print \"Key {} not found\".format(k)\n+            return\n+        key_result = None\n         try:\n             print \"Pulling key ID {0}\".format(k)\n             key_result = key.pull()\n         except HTTPError as e:\n             print(\"Error {}: {}\".format(e.response.status_code, e.response.text))\n+        except Exception as ex:","path":"brave/core/scripts/update_keys.py","position":13,"original_position":13,"commit_id":"f08c0deb51e9637640d430007a3f40d242198075","original_commit_id":"f08c0deb51e9637640d430007a3f40d242198075","user":{"login":"jboning","id":376107,"avatar_url":"https://avatars.githubusercontent.com/u/376107?v=3","gravatar_id":"","url":"https://api.github.com/users/jboning","html_url":"https://github.com/jboning","followers_url":"https://api.github.com/users/jboning/followers","following_url":"https://api.github.com/users/jboning/following{/other_user}","gists_url":"https://api.github.com/users/jboning/gists{/gist_id}","starred_url":"https://api.github.com/users/jboning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jboning/subscriptions","organizations_url":"https://api.github.com/users/jboning/orgs","repos_url":"https://api.github.com/users/jboning/repos","events_url":"https://api.github.com/users/jboning/events{/privacy}","received_events_url":"https://api.github.com/users/jboning/received_events","type":"User","site_admin":false},"body":"I'm really not convinced that any exception should trigger key removal. We definitely don't want to wipe everyone's keys over a typo making its way into pull() (though of course that should be impossible, right, with out test coverage, oh wait)","created_at":"2014-11-23T02:14:53Z","updated_at":"2014-11-23T02:14:53Z","html_url":"https://github.com/bravecollective/core/pull/357#discussion_r20761523","pull_request_url":"https://api.github.com/repos/bravecollective/core/pulls/357","_links":{"self":{"href":"https://api.github.com/repos/bravecollective/core/pulls/comments/20761523"},"html":{"href":"https://github.com/bravecollective/core/pull/357#discussion_r20761523"},"pull_request":{"href":"https://api.github.com/repos/bravecollective/core/pulls/357"}}},"pull_request":{"url":"https://api.github.com/repos/bravecollective/core/pulls/357","id":24881406,"html_url":"https://github.com/bravecollective/core/pull/357","diff_url":"https://github.com/bravecollective/core/pull/357.diff","patch_url":"https://github.com/bravecollective/core/pull/357.patch","issue_url":"https://api.github.com/repos/bravecollective/core/issues/357","number":357,"state":"open","locked":false,"title":"Make the update script more resiliant to errors.","user":{"login":"Acidity","id":2623497,"avatar_url":"https://avatars.githubusercontent.com/u/2623497?v=3","gravatar_id":"","url":"https://api.github.com/users/Acidity","html_url":"https://github.com/Acidity","followers_url":"https://api.github.com/users/Acidity/followers","following_url":"https://api.github.com/users/Acidity/following{/other_user}","gists_url":"https://api.github.com/users/Acidity/gists{/gist_id}","starred_url":"https://api.github.com/users/Acidity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Acidity/subscriptions","organizations_url":"https://api.github.com/users/Acidity/orgs","repos_url":"https://api.github.com/users/Acidity/repos","events_url":"https://api.github.com/users/Acidity/events{/privacy}","received_events_url":"https://api.github.com/users/Acidity/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Tyler O'Meara <Tyler@TylerOMeara.com>","created_at":"2014-11-22T01:29:33Z","updated_at":"2014-11-23T02:14:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"60aa7ecda637fd4b6e383a5e15eff4bd389cfcaf","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bravecollective/core/pulls/357/commits","review_comments_url":"https://api.github.com/repos/bravecollective/core/pulls/357/comments","review_comment_url":"https://api.github.com/repos/bravecollective/core/pulls/comments/{number}","comments_url":"https://api.github.com/repos/bravecollective/core/issues/357/comments","statuses_url":"https://api.github.com/repos/bravecollective/core/statuses/f08c0deb51e9637640d430007a3f40d242198075","head":{"label":"Acidity:feature/UpdateKeys","ref":"feature/UpdateKeys","sha":"f08c0deb51e9637640d430007a3f40d242198075","user":{"login":"Acidity","id":2623497,"avatar_url":"https://avatars.githubusercontent.com/u/2623497?v=3","gravatar_id":"","url":"https://api.github.com/users/Acidity","html_url":"https://github.com/Acidity","followers_url":"https://api.github.com/users/Acidity/followers","following_url":"https://api.github.com/users/Acidity/following{/other_user}","gists_url":"https://api.github.com/users/Acidity/gists{/gist_id}","starred_url":"https://api.github.com/users/Acidity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Acidity/subscriptions","organizations_url":"https://api.github.com/users/Acidity/orgs","repos_url":"https://api.github.com/users/Acidity/repos","events_url":"https://api.github.com/users/Acidity/events{/privacy}","received_events_url":"https://api.github.com/users/Acidity/received_events","type":"User","site_admin":false},"repo":{"id":18019510,"name":"core","full_name":"Acidity/core","owner":{"login":"Acidity","id":2623497,"avatar_url":"https://avatars.githubusercontent.com/u/2623497?v=3","gravatar_id":"","url":"https://api.github.com/users/Acidity","html_url":"https://github.com/Acidity","followers_url":"https://api.github.com/users/Acidity/followers","following_url":"https://api.github.com/users/Acidity/following{/other_user}","gists_url":"https://api.github.com/users/Acidity/gists{/gist_id}","starred_url":"https://api.github.com/users/Acidity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Acidity/subscriptions","organizations_url":"https://api.github.com/users/Acidity/orgs","repos_url":"https://api.github.com/users/Acidity/repos","events_url":"https://api.github.com/users/Acidity/events{/privacy}","received_events_url":"https://api.github.com/users/Acidity/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Acidity/core","description":"Authentication, Authorization, and API Proxy Service","fork":true,"url":"https://api.github.com/repos/Acidity/core","forks_url":"https://api.github.com/repos/Acidity/core/forks","keys_url":"https://api.github.com/repos/Acidity/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Acidity/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Acidity/core/teams","hooks_url":"https://api.github.com/repos/Acidity/core/hooks","issue_events_url":"https://api.github.com/repos/Acidity/core/issues/events{/number}","events_url":"https://api.github.com/repos/Acidity/core/events","assignees_url":"https://api.github.com/repos/Acidity/core/assignees{/user}","branches_url":"https://api.github.com/repos/Acidity/core/branches{/branch}","tags_url":"https://api.github.com/repos/Acidity/core/tags","blobs_url":"https://api.github.com/repos/Acidity/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Acidity/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Acidity/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/Acidity/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Acidity/core/statuses/{sha}","languages_url":"https://api.github.com/repos/Acidity/core/languages","stargazers_url":"https://api.github.com/repos/Acidity/core/stargazers","contributors_url":"https://api.github.com/repos/Acidity/core/contributors","subscribers_url":"https://api.github.com/repos/Acidity/core/subscribers","subscription_url":"https://api.github.com/repos/Acidity/core/subscription","commits_url":"https://api.github.com/repos/Acidity/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/Acidity/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/Acidity/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/Acidity/core/issues/comments/{number}","contents_url":"https://api.github.com/repos/Acidity/core/contents/{+path}","compare_url":"https://api.github.com/repos/Acidity/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Acidity/core/merges","archive_url":"https://api.github.com/repos/Acidity/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Acidity/core/downloads","issues_url":"https://api.github.com/repos/Acidity/core/issues{/number}","pulls_url":"https://api.github.com/repos/Acidity/core/pulls{/number}","milestones_url":"https://api.github.com/repos/Acidity/core/milestones{/number}","notifications_url":"https://api.github.com/repos/Acidity/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Acidity/core/labels{/name}","releases_url":"https://api.github.com/repos/Acidity/core/releases{/id}","created_at":"2014-03-22T20:50:09Z","updated_at":"2014-10-16T03:19:06Z","pushed_at":"2014-11-22T16:49:05Z","git_url":"git://github.com/Acidity/core.git","ssh_url":"git@github.com:Acidity/core.git","clone_url":"https://github.com/Acidity/core.git","svn_url":"https://github.com/Acidity/core","homepage":"","size":15457,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"bravecollective:develop","ref":"develop","sha":"035a4819b43df9186701747216832d34b6d23640","user":{"login":"bravecollective","id":5108976,"avatar_url":"https://avatars.githubusercontent.com/u/5108976?v=3","gravatar_id":"","url":"https://api.github.com/users/bravecollective","html_url":"https://github.com/bravecollective","followers_url":"https://api.github.com/users/bravecollective/followers","following_url":"https://api.github.com/users/bravecollective/following{/other_user}","gists_url":"https://api.github.com/users/bravecollective/gists{/gist_id}","starred_url":"https://api.github.com/users/bravecollective/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bravecollective/subscriptions","organizations_url":"https://api.github.com/users/bravecollective/orgs","repos_url":"https://api.github.com/users/bravecollective/repos","events_url":"https://api.github.com/users/bravecollective/events{/privacy}","received_events_url":"https://api.github.com/users/bravecollective/received_events","type":"Organization","site_admin":false},"repo":{"id":9990402,"name":"core","full_name":"bravecollective/core","owner":{"login":"bravecollective","id":5108976,"avatar_url":"https://avatars.githubusercontent.com/u/5108976?v=3","gravatar_id":"","url":"https://api.github.com/users/bravecollective","html_url":"https://github.com/bravecollective","followers_url":"https://api.github.com/users/bravecollective/followers","following_url":"https://api.github.com/users/bravecollective/following{/other_user}","gists_url":"https://api.github.com/users/bravecollective/gists{/gist_id}","starred_url":"https://api.github.com/users/bravecollective/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bravecollective/subscriptions","organizations_url":"https://api.github.com/users/bravecollective/orgs","repos_url":"https://api.github.com/users/bravecollective/repos","events_url":"https://api.github.com/users/bravecollective/events{/privacy}","received_events_url":"https://api.github.com/users/bravecollective/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bravecollective/core","description":"Authentication, Authorization, and API Proxy Service","fork":false,"url":"https://api.github.com/repos/bravecollective/core","forks_url":"https://api.github.com/repos/bravecollective/core/forks","keys_url":"https://api.github.com/repos/bravecollective/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bravecollective/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bravecollective/core/teams","hooks_url":"https://api.github.com/repos/bravecollective/core/hooks","issue_events_url":"https://api.github.com/repos/bravecollective/core/issues/events{/number}","events_url":"https://api.github.com/repos/bravecollective/core/events","assignees_url":"https://api.github.com/repos/bravecollective/core/assignees{/user}","branches_url":"https://api.github.com/repos/bravecollective/core/branches{/branch}","tags_url":"https://api.github.com/repos/bravecollective/core/tags","blobs_url":"https://api.github.com/repos/bravecollective/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bravecollective/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bravecollective/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/bravecollective/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bravecollective/core/statuses/{sha}","languages_url":"https://api.github.com/repos/bravecollective/core/languages","stargazers_url":"https://api.github.com/repos/bravecollective/core/stargazers","contributors_url":"https://api.github.com/repos/bravecollective/core/contributors","subscribers_url":"https://api.github.com/repos/bravecollective/core/subscribers","subscription_url":"https://api.github.com/repos/bravecollective/core/subscription","commits_url":"https://api.github.com/repos/bravecollective/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/bravecollective/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/bravecollective/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/bravecollective/core/issues/comments/{number}","contents_url":"https://api.github.com/repos/bravecollective/core/contents/{+path}","compare_url":"https://api.github.com/repos/bravecollective/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bravecollective/core/merges","archive_url":"https://api.github.com/repos/bravecollective/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bravecollective/core/downloads","issues_url":"https://api.github.com/repos/bravecollective/core/issues{/number}","pulls_url":"https://api.github.com/repos/bravecollective/core/pulls{/number}","milestones_url":"https://api.github.com/repos/bravecollective/core/milestones{/number}","notifications_url":"https://api.github.com/repos/bravecollective/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bravecollective/core/labels{/name}","releases_url":"https://api.github.com/repos/bravecollective/core/releases{/id}","created_at":"2013-05-10T21:05:37Z","updated_at":"2014-11-05T01:12:43Z","pushed_at":"2014-11-19T02:28:02Z","git_url":"git://github.com/bravecollective/core.git","ssh_url":"git@github.com:bravecollective/core.git","clone_url":"https://github.com/bravecollective/core.git","svn_url":"https://github.com/bravecollective/core","homepage":"https://core.braveineve.com/","size":20421,"stargazers_count":32,"watchers_count":32,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":43,"mirror_url":null,"open_issues_count":57,"forks":43,"open_issues":57,"watchers":32,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/bravecollective/core/pulls/357"},"html":{"href":"https://github.com/bravecollective/core/pull/357"},"issue":{"href":"https://api.github.com/repos/bravecollective/core/issues/357"},"comments":{"href":"https://api.github.com/repos/bravecollective/core/issues/357/comments"},"review_comments":{"href":"https://api.github.com/repos/bravecollective/core/pulls/357/comments"},"review_comment":{"href":"https://api.github.com/repos/bravecollective/core/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/bravecollective/core/pulls/357/commits"},"statuses":{"href":"https://api.github.com/repos/bravecollective/core/statuses/f08c0deb51e9637640d430007a3f40d242198075"}}}}