GitHub PullRequestReviewCommentEvent at 2014-05-08 17:57:17
Repository: mongo-cxx-driver
Actor: acmorrow
Payload: {"comment":{"url":"https://api.github.com/repos/mongodb/mongo-cxx-driver/pulls/comments/12442552","id":12442552,"diff_hunk":"@@ -213,10 +216,17 @@ namespace mongo {\n     private:\n         friend class DBClientBase;\n         friend class DBClientConnection;\n+        friend class DBClientCursorShimCursorID;\n+        friend class DBClientCursorShimArray;\n \n         int nextBatchSize();\n         void _finishConsInit();\n \n+        BSONObj _next();","path":"src/mongo/client/dbclientcursor.h","position":20,"original_position":20,"commit_id":"a67f431a33028290b9ca066dd5478fa30e7c07f9","original_commit_id":"a67f431a33028290b9ca066dd5478fa30e7c07f9","user":{"login":"acmorrow","id":268253,"avatar_url":"https://avatars.githubusercontent.com/u/268253?","gravatar_id":"dbfcfc0e3c4b2b0baef2383fbc97f687","url":"https://api.github.com/users/acmorrow","html_url":"https://github.com/acmorrow","followers_url":"https://api.github.com/users/acmorrow/followers","following_url":"https://api.github.com/users/acmorrow/following{/other_user}","gists_url":"https://api.github.com/users/acmorrow/gists{/gist_id}","starred_url":"https://api.github.com/users/acmorrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acmorrow/subscriptions","organizations_url":"https://api.github.com/users/acmorrow/orgs","repos_url":"https://api.github.com/users/acmorrow/repos","events_url":"https://api.github.com/users/acmorrow/events{/privacy}","received_events_url":"https://api.github.com/users/acmorrow/received_events","type":"User","site_admin":false},"body":"I think the next/_next and more/_more connection makes it a little hard to read. You need to keep the public methods the same, but maybe call the private ones one of:\r\n\r\n{raw, base, internal} X { More, Next }\r\n","created_at":"2014-05-08T17:57:17Z","updated_at":"2014-05-08T17:57:17Z","html_url":"https://github.com/mongodb/mongo-cxx-driver/pull/72#discussion_r12442552","pull_request_url":"https://api.github.com/repos/mongodb/mongo-cxx-driver/pulls/72","_links":{"self":{"href":"https://api.github.com/repos/mongodb/mongo-cxx-driver/pulls/comments/12442552"},"html":{"href":"https://github.com/mongodb/mongo-cxx-driver/pull/72#discussion_r12442552"},"pull_request":{"href":"https://api.github.com/repos/mongodb/mongo-cxx-driver/pulls/72"}}}}