GitHub PullRequestReviewCommentEvent at 2014-08-13 16:23:15
Repository: makedrive
Actor: gideonthomas
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/makedrive/pulls/comments/16186744","id":16186744,"diff_hunk":"@@ -49,7 +49,8 @@ var activeSyncs = (function() {\n   return {\n     setActive: setActive,\n     removeActive: removeActive,\n-    byUsername: byUsername\n+    byUsername: byUsername,\n+    get containsSyncs() { return !!Object.keys(syncs).length; }","path":"server/lib/sync.js","position":6,"original_position":6,"commit_id":"5b7555e3826a3b0694de91198df3881b3b6bd291","original_commit_id":"5b7555e3826a3b0694de91198df3881b3b6bd291","user":{"login":"gideonthomas","id":5816130,"avatar_url":"https://avatars.githubusercontent.com/u/5816130?v=2","gravatar_id":"b258eac8f9bbbd1cc58948ed37ef4f55","url":"https://api.github.com/users/gideonthomas","html_url":"https://github.com/gideonthomas","followers_url":"https://api.github.com/users/gideonthomas/followers","following_url":"https://api.github.com/users/gideonthomas/following{/other_user}","gists_url":"https://api.github.com/users/gideonthomas/gists{/gist_id}","starred_url":"https://api.github.com/users/gideonthomas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gideonthomas/subscriptions","organizations_url":"https://api.github.com/users/gideonthomas/orgs","repos_url":"https://api.github.com/users/gideonthomas/repos","events_url":"https://api.github.com/users/gideonthomas/events{/privacy}","received_events_url":"https://api.github.com/users/gideonthomas/received_events","type":"User","site_admin":false},"body":"again, why force a boolean? shouldn't Object.keys(syncs).length be enough?","created_at":"2014-08-13T16:23:15Z","updated_at":"2014-08-13T16:23:15Z","html_url":"https://github.com/mozilla/makedrive/pull/258#discussion_r16186744","pull_request_url":"https://api.github.com/repos/mozilla/makedrive/pulls/258","_links":{"self":{"href":"https://api.github.com/repos/mozilla/makedrive/pulls/comments/16186744"},"html":{"href":"https://github.com/mozilla/makedrive/pull/258#discussion_r16186744"},"pull_request":{"href":"https://api.github.com/repos/mozilla/makedrive/pulls/258"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/makedrive/pulls/258","id":19682976,"html_url":"https://github.com/mozilla/makedrive/pull/258","diff_url":"https://github.com/mozilla/makedrive/pull/258.diff","patch_url":"https://github.com/mozilla/makedrive/pull/258.patch","issue_url":"https://api.github.com/repos/mozilla/makedrive/issues/258","number":258,"state":"open","title":"[WIP] Fixed #253 - Prevent patch step from being interrupted","user":{"login":"sedge","id":1616860,"avatar_url":"https://avatars.githubusercontent.com/u/1616860?v=2","gravatar_id":"92e900674f4c9e7fad7e60809f32c83b","url":"https://api.github.com/users/sedge","html_url":"https://github.com/sedge","followers_url":"https://api.github.com/users/sedge/followers","following_url":"https://api.github.com/users/sedge/following{/other_user}","gists_url":"https://api.github.com/users/sedge/gists{/gist_id}","starred_url":"https://api.github.com/users/sedge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sedge/subscriptions","organizations_url":"https://api.github.com/users/sedge/orgs","repos_url":"https://api.github.com/users/sedge/repos","events_url":"https://api.github.com/users/sedge/events{/privacy}","received_events_url":"https://api.github.com/users/sedge/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-08-12T19:12:58Z","updated_at":"2014-08-13T16:23:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"10c5bcf693e5be109fc8468b81c9244b4ae39d24","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/makedrive/pulls/258/commits","review_comments_url":"https://api.github.com/repos/mozilla/makedrive/pulls/258/comments","review_comment_url":"https://api.github.com/repos/mozilla/makedrive/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mozilla/makedrive/issues/258/comments","statuses_url":"https://api.github.com/repos/mozilla/makedrive/statuses/5b7555e3826a3b0694de91198df3881b3b6bd291","head":{"label":"sedge:issue253-patchInterruptions","ref":"issue253-patchInterruptions","sha":"5b7555e3826a3b0694de91198df3881b3b6bd291","user":{"login":"sedge","id":1616860,"avatar_url":"https://avatars.githubusercontent.com/u/1616860?v=2","gravatar_id":"92e900674f4c9e7fad7e60809f32c83b","url":"https://api.github.com/users/sedge","html_url":"https://github.com/sedge","followers_url":"https://api.github.com/users/sedge/followers","following_url":"https://api.github.com/users/sedge/following{/other_user}","gists_url":"https://api.github.com/users/sedge/gists{/gist_id}","starred_url":"https://api.github.com/users/sedge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sedge/subscriptions","organizations_url":"https://api.github.com/users/sedge/orgs","repos_url":"https://api.github.com/users/sedge/repos","events_url":"https://api.github.com/users/sedge/events{/privacy}","received_events_url":"https://api.github.com/users/sedge/received_events","type":"User","site_admin":false},"repo":{"id":20232183,"name":"makedrive","full_name":"sedge/makedrive","owner":{"login":"sedge","id":1616860,"avatar_url":"https://avatars.githubusercontent.com/u/1616860?v=2","gravatar_id":"92e900674f4c9e7fad7e60809f32c83b","url":"https://api.github.com/users/sedge","html_url":"https://github.com/sedge","followers_url":"https://api.github.com/users/sedge/followers","following_url":"https://api.github.com/users/sedge/following{/other_user}","gists_url":"https://api.github.com/users/sedge/gists{/gist_id}","starred_url":"https://api.github.com/users/sedge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sedge/subscriptions","organizations_url":"https://api.github.com/users/sedge/orgs","repos_url":"https://api.github.com/users/sedge/repos","events_url":"https://api.github.com/users/sedge/events{/privacy}","received_events_url":"https://api.github.com/users/sedge/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sedge/makedrive","description":"Webmaker Filesystem","fork":true,"url":"https://api.github.com/repos/sedge/makedrive","forks_url":"https://api.github.com/repos/sedge/makedrive/forks","keys_url":"https://api.github.com/repos/sedge/makedrive/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sedge/makedrive/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sedge/makedrive/teams","hooks_url":"https://api.github.com/repos/sedge/makedrive/hooks","issue_events_url":"https://api.github.com/repos/sedge/makedrive/issues/events{/number}","events_url":"https://api.github.com/repos/sedge/makedrive/events","assignees_url":"https://api.github.com/repos/sedge/makedrive/assignees{/user}","branches_url":"https://api.github.com/repos/sedge/makedrive/branches{/branch}","tags_url":"https://api.github.com/repos/sedge/makedrive/tags","blobs_url":"https://api.github.com/repos/sedge/makedrive/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sedge/makedrive/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sedge/makedrive/git/refs{/sha}","trees_url":"https://api.github.com/repos/sedge/makedrive/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sedge/makedrive/statuses/{sha}","languages_url":"https://api.github.com/repos/sedge/makedrive/languages","stargazers_url":"https://api.github.com/repos/sedge/makedrive/stargazers","contributors_url":"https://api.github.com/repos/sedge/makedrive/contributors","subscribers_url":"https://api.github.com/repos/sedge/makedrive/subscribers","subscription_url":"https://api.github.com/repos/sedge/makedrive/subscription","commits_url":"https://api.github.com/repos/sedge/makedrive/commits{/sha}","git_commits_url":"https://api.github.com/repos/sedge/makedrive/git/commits{/sha}","comments_url":"https://api.github.com/repos/sedge/makedrive/comments{/number}","issue_comment_url":"https://api.github.com/repos/sedge/makedrive/issues/comments/{number}","contents_url":"https://api.github.com/repos/sedge/makedrive/contents/{+path}","compare_url":"https://api.github.com/repos/sedge/makedrive/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sedge/makedrive/merges","archive_url":"https://api.github.com/repos/sedge/makedrive/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sedge/makedrive/downloads","issues_url":"https://api.github.com/repos/sedge/makedrive/issues{/number}","pulls_url":"https://api.github.com/repos/sedge/makedrive/pulls{/number}","milestones_url":"https://api.github.com/repos/sedge/makedrive/milestones{/number}","notifications_url":"https://api.github.com/repos/sedge/makedrive/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sedge/makedrive/labels{/name}","releases_url":"https://api.github.com/repos/sedge/makedrive/releases{/id}","created_at":"2014-05-27T19:15:50Z","updated_at":"2014-07-01T15:56:15Z","pushed_at":"2014-08-13T16:16:54Z","git_url":"git://github.com/sedge/makedrive.git","ssh_url":"git@github.com:sedge/makedrive.git","clone_url":"https://github.com/sedge/makedrive.git","svn_url":"https://github.com/sedge/makedrive","homepage":null,"size":4466,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"2f387e833355e8705bf0986411237643939592f4","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=2","gravatar_id":"9ba739c8f3288e256b13553e4d257b5e","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":18801832,"name":"makedrive","full_name":"mozilla/makedrive","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=2","gravatar_id":"9ba739c8f3288e256b13553e4d257b5e","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/makedrive","description":"Webmaker Filesystem","fork":false,"url":"https://api.github.com/repos/mozilla/makedrive","forks_url":"https://api.github.com/repos/mozilla/makedrive/forks","keys_url":"https://api.github.com/repos/mozilla/makedrive/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/makedrive/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/makedrive/teams","hooks_url":"https://api.github.com/repos/mozilla/makedrive/hooks","issue_events_url":"https://api.github.com/repos/mozilla/makedrive/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/makedrive/events","assignees_url":"https://api.github.com/repos/mozilla/makedrive/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/makedrive/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/makedrive/tags","blobs_url":"https://api.github.com/repos/mozilla/makedrive/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/makedrive/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/makedrive/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/makedrive/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/makedrive/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/makedrive/languages","stargazers_url":"https://api.github.com/repos/mozilla/makedrive/stargazers","contributors_url":"https://api.github.com/repos/mozilla/makedrive/contributors","subscribers_url":"https://api.github.com/repos/mozilla/makedrive/subscribers","subscription_url":"https://api.github.com/repos/mozilla/makedrive/subscription","commits_url":"https://api.github.com/repos/mozilla/makedrive/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/makedrive/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/makedrive/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/makedrive/issues/comments/{number}","contents_url":"https://api.github.com/repos/mozilla/makedrive/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/makedrive/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/makedrive/merges","archive_url":"https://api.github.com/repos/mozilla/makedrive/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/makedrive/downloads","issues_url":"https://api.github.com/repos/mozilla/makedrive/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/makedrive/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/makedrive/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/makedrive/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/makedrive/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/makedrive/releases{/id}","created_at":"2014-04-15T13:53:43Z","updated_at":"2014-08-13T15:24:56Z","pushed_at":"2014-08-13T15:29:53Z","git_url":"git://github.com/mozilla/makedrive.git","ssh_url":"git@github.com:mozilla/makedrive.git","clone_url":"https://github.com/mozilla/makedrive.git","svn_url":"https://github.com/mozilla/makedrive","homepage":null,"size":5870,"stargazers_count":10,"watchers_count":10,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":9,"mirror_url":null,"open_issues_count":42,"forks":9,"open_issues":42,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/makedrive/pulls/258"},"html":{"href":"https://github.com/mozilla/makedrive/pull/258"},"issue":{"href":"https://api.github.com/repos/mozilla/makedrive/issues/258"},"comments":{"href":"https://api.github.com/repos/mozilla/makedrive/issues/258/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/makedrive/pulls/258/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/makedrive/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mozilla/makedrive/pulls/258/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/makedrive/statuses/5b7555e3826a3b0694de91198df3881b3b6bd291"}}}}