GitHub PullRequestReviewCommentEvent at 2014-09-18 20:53:51
Repository: mb-logging-api
Actor: tongxiang
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/DoSomething/mb-logging-api/pulls/comments/17754005","id":17754005,"diff_hunk":"@@ -70,11 +70,55 @@ UserImportSummary.prototype.post = function(req, res) {\n     // Added log entry to db\n     dslogger.log('Save executed on: ' + addArgs + '. Raw response from mongo:');\n     dslogger.log(addArgs);\n-    return console.log(\"Created summary log entry using UserImportSummary POST method.\");\n+    console.log(\"Created summary log entry using UserImportSummary POST method.\");\n+    res.send(201, addArgs);\n   });\n+};\n+\n+/**\n+ * Retrieve summary log documents. Example request:\n+ * /api/v1/imports/summary/2014-09-01/2014-10-01?type=user&exists=1&source=niche.com\n+ *\n+ * @param req\n+ *   The request object in the GET callback.\n+ * @param res\n+ *   The response object in the GET callback.\n+ */\n+UserImportSummary.prototype.get = function(req, res) {\n+\n+  if (req.param(\"start_date\") == 0) {","path":"lib/user-import-summary.js","position":37,"original_position":37,"commit_id":"28f55ca8a1b331f0d363f20d6d7e686607953fe1","original_commit_id":"28f55ca8a1b331f0d363f20d6d7e686607953fe1","user":{"login":"tongxiang","id":5678066,"avatar_url":"https://avatars.githubusercontent.com/u/5678066?v=2","gravatar_id":"dd35d51a02afd53d3e8e6d79100d0f62","url":"https://api.github.com/users/tongxiang","html_url":"https://github.com/tongxiang","followers_url":"https://api.github.com/users/tongxiang/followers","following_url":"https://api.github.com/users/tongxiang/following{/other_user}","gists_url":"https://api.github.com/users/tongxiang/gists{/gist_id}","starred_url":"https://api.github.com/users/tongxiang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tongxiang/subscriptions","organizations_url":"https://api.github.com/users/tongxiang/orgs","repos_url":"https://api.github.com/users/tongxiang/repos","events_url":"https://api.github.com/users/tongxiang/events{/privacy}","received_events_url":"https://api.github.com/users/tongxiang/received_events","type":"User","site_admin":false},"body":"are you trying to check to see if this param is *unspecified* or expressed directly as **0**?\r\n\r\nOr will there be a check earlier in the logic to see if the user leaves these fields blank?","created_at":"2014-09-18T20:53:51Z","updated_at":"2014-09-18T20:53:51Z","html_url":"https://github.com/DoSomething/mb-logging-api/pull/10#discussion_r17754005","pull_request_url":"https://api.github.com/repos/DoSomething/mb-logging-api/pulls/10","_links":{"self":{"href":"https://api.github.com/repos/DoSomething/mb-logging-api/pulls/comments/17754005"},"html":{"href":"https://github.com/DoSomething/mb-logging-api/pull/10#discussion_r17754005"},"pull_request":{"href":"https://api.github.com/repos/DoSomething/mb-logging-api/pulls/10"}}},"pull_request":{"url":"https://api.github.com/repos/DoSomething/mb-logging-api/pulls/10","id":21407232,"html_url":"https://github.com/DoSomething/mb-logging-api/pull/10","diff_url":"https://github.com/DoSomething/mb-logging-api/pull/10.diff","patch_url":"https://github.com/DoSomething/mb-logging-api/pull/10.patch","issue_url":"https://api.github.com/repos/DoSomething/mb-logging-api/issues/10","number":10,"state":"open","locked":false,"title":"Issue3 add GET routes","user":{"login":"DeeZone","id":2119264,"avatar_url":"https://avatars.githubusercontent.com/u/2119264?v=2","gravatar_id":"d5c1ab48637b4d5e78e4a2c3547dafaf","url":"https://api.github.com/users/DeeZone","html_url":"https://github.com/DeeZone","followers_url":"https://api.github.com/users/DeeZone/followers","following_url":"https://api.github.com/users/DeeZone/following{/other_user}","gists_url":"https://api.github.com/users/DeeZone/gists{/gist_id}","starred_url":"https://api.github.com/users/DeeZone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DeeZone/subscriptions","organizations_url":"https://api.github.com/users/DeeZone/orgs","repos_url":"https://api.github.com/users/DeeZone/repos","events_url":"https://api.github.com/users/DeeZone/events{/privacy}","received_events_url":"https://api.github.com/users/DeeZone/received_events","type":"User","site_admin":false},"body":"Fixes #3\r\n\r\nCompletes function GET endpoints based documented details in wiki:\r\nhttps://github.com/DoSomething/mb-logging-api/wiki\r\n\r\n- GET /api\r\n- GET /api/v1\r\n- GET /api/v1/imports/:start date/:end date\r\n- GET /api/v1/imports/summaries/:start_date/:end_date","created_at":"2014-09-18T01:23:53Z","updated_at":"2014-09-18T20:53:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"da49aa43a07f14d7e2de0ef102d69996c1a80ffa","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/DoSomething/mb-logging-api/pulls/10/commits","review_comments_url":"https://api.github.com/repos/DoSomething/mb-logging-api/pulls/10/comments","review_comment_url":"https://api.github.com/repos/DoSomething/mb-logging-api/pulls/comments/{number}","comments_url":"https://api.github.com/repos/DoSomething/mb-logging-api/issues/10/comments","statuses_url":"https://api.github.com/repos/DoSomething/mb-logging-api/statuses/28f55ca8a1b331f0d363f20d6d7e686607953fe1","head":{"label":"DoSomething:Issue3-Add_GET_route","ref":"Issue3-Add_GET_route","sha":"28f55ca8a1b331f0d363f20d6d7e686607953fe1","user":{"login":"DoSomething","id":731685,"avatar_url":"https://avatars.githubusercontent.com/u/731685?v=2","gravatar_id":"e457352193b1425960ed9606ce6e3bad","url":"https://api.github.com/users/DoSomething","html_url":"https://github.com/DoSomething","followers_url":"https://api.github.com/users/DoSomething/followers","following_url":"https://api.github.com/users/DoSomething/following{/other_user}","gists_url":"https://api.github.com/users/DoSomething/gists{/gist_id}","starred_url":"https://api.github.com/users/DoSomething/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DoSomething/subscriptions","organizations_url":"https://api.github.com/users/DoSomething/orgs","repos_url":"https://api.github.com/users/DoSomething/repos","events_url":"https://api.github.com/users/DoSomething/events{/privacy}","received_events_url":"https://api.github.com/users/DoSomething/received_events","type":"Organization","site_admin":false},"repo":{"id":23592265,"name":"mb-logging-api","full_name":"DoSomething/mb-logging-api","owner":{"login":"DoSomething","id":731685,"avatar_url":"https://avatars.githubusercontent.com/u/731685?v=2","gravatar_id":"e457352193b1425960ed9606ce6e3bad","url":"https://api.github.com/users/DoSomething","html_url":"https://github.com/DoSomething","followers_url":"https://api.github.com/users/DoSomething/followers","following_url":"https://api.github.com/users/DoSomething/following{/other_user}","gists_url":"https://api.github.com/users/DoSomething/gists{/gist_id}","starred_url":"https://api.github.com/users/DoSomething/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DoSomething/subscriptions","organizations_url":"https://api.github.com/users/DoSomething/orgs","repos_url":"https://api.github.com/users/DoSomething/repos","events_url":"https://api.github.com/users/DoSomething/events{/privacy}","received_events_url":"https://api.github.com/users/DoSomething/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DoSomething/mb-logging-api","description":"An API for sending logging data to. The API will take care of the persistent data storage details.","fork":false,"url":"https://api.github.com/repos/DoSomething/mb-logging-api","forks_url":"https://api.github.com/repos/DoSomething/mb-logging-api/forks","keys_url":"https://api.github.com/repos/DoSomething/mb-logging-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DoSomething/mb-logging-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DoSomething/mb-logging-api/teams","hooks_url":"https://api.github.com/repos/DoSomething/mb-logging-api/hooks","issue_events_url":"https://api.github.com/repos/DoSomething/mb-logging-api/issues/events{/number}","events_url":"https://api.github.com/repos/DoSomething/mb-logging-api/events","assignees_url":"https://api.github.com/repos/DoSomething/mb-logging-api/assignees{/user}","branches_url":"https://api.github.com/repos/DoSomething/mb-logging-api/branches{/branch}","tags_url":"https://api.github.com/repos/DoSomething/mb-logging-api/tags","blobs_url":"https://api.github.com/repos/DoSomething/mb-logging-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DoSomething/mb-logging-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DoSomething/mb-logging-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/DoSomething/mb-logging-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DoSomething/mb-logging-api/statuses/{sha}","languages_url":"https://api.github.com/repos/DoSomething/mb-logging-api/languages","stargazers_url":"https://api.github.com/repos/DoSomething/mb-logging-api/stargazers","contributors_url":"https://api.github.com/repos/DoSomething/mb-logging-api/contributors","subscribers_url":"https://api.github.com/repos/DoSomething/mb-logging-api/subscribers","subscription_url":"https://api.github.com/repos/DoSomething/mb-logging-api/subscription","commits_url":"https://api.github.com/repos/DoSomething/mb-logging-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/DoSomething/mb-logging-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/DoSomething/mb-logging-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/DoSomething/mb-logging-api/issues/comments/{number}","contents_url":"https://api.github.com/repos/DoSomething/mb-logging-api/contents/{+path}","compare_url":"https://api.github.com/repos/DoSomething/mb-logging-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DoSomething/mb-logging-api/merges","archive_url":"https://api.github.com/repos/DoSomething/mb-logging-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DoSomething/mb-logging-api/downloads","issues_url":"https://api.github.com/repos/DoSomething/mb-logging-api/issues{/number}","pulls_url":"https://api.github.com/repos/DoSomething/mb-logging-api/pulls{/number}","milestones_url":"https://api.github.com/repos/DoSomething/mb-logging-api/milestones{/number}","notifications_url":"https://api.github.com/repos/DoSomething/mb-logging-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DoSomething/mb-logging-api/labels{/name}","releases_url":"https://api.github.com/repos/DoSomething/mb-logging-api/releases{/id}","created_at":"2014-09-02T19:22:30Z","updated_at":"2014-09-04T00:38:44Z","pushed_at":"2014-09-18T14:24:02Z","git_url":"git://github.com/DoSomething/mb-logging-api.git","ssh_url":"git@github.com:DoSomething/mb-logging-api.git","clone_url":"https://github.com/DoSomething/mb-logging-api.git","svn_url":"https://github.com/DoSomething/mb-logging-api","homepage":null,"size":316,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"DoSomething:master","ref":"master","sha":"3f983ef1b3515473356e58f5864e9105aa0e56b0","user":{"login":"DoSomething","id":731685,"avatar_url":"https://avatars.githubusercontent.com/u/731685?v=2","gravatar_id":"e457352193b1425960ed9606ce6e3bad","url":"https://api.github.com/users/DoSomething","html_url":"https://github.com/DoSomething","followers_url":"https://api.github.com/users/DoSomething/followers","following_url":"https://api.github.com/users/DoSomething/following{/other_user}","gists_url":"https://api.github.com/users/DoSomething/gists{/gist_id}","starred_url":"https://api.github.com/users/DoSomething/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DoSomething/subscriptions","organizations_url":"https://api.github.com/users/DoSomething/orgs","repos_url":"https://api.github.com/users/DoSomething/repos","events_url":"https://api.github.com/users/DoSomething/events{/privacy}","received_events_url":"https://api.github.com/users/DoSomething/received_events","type":"Organization","site_admin":false},"repo":{"id":23592265,"name":"mb-logging-api","full_name":"DoSomething/mb-logging-api","owner":{"login":"DoSomething","id":731685,"avatar_url":"https://avatars.githubusercontent.com/u/731685?v=2","gravatar_id":"e457352193b1425960ed9606ce6e3bad","url":"https://api.github.com/users/DoSomething","html_url":"https://github.com/DoSomething","followers_url":"https://api.github.com/users/DoSomething/followers","following_url":"https://api.github.com/users/DoSomething/following{/other_user}","gists_url":"https://api.github.com/users/DoSomething/gists{/gist_id}","starred_url":"https://api.github.com/users/DoSomething/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DoSomething/subscriptions","organizations_url":"https://api.github.com/users/DoSomething/orgs","repos_url":"https://api.github.com/users/DoSomething/repos","events_url":"https://api.github.com/users/DoSomething/events{/privacy}","received_events_url":"https://api.github.com/users/DoSomething/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DoSomething/mb-logging-api","description":"An API for sending logging data to. The API will take care of the persistent data storage details.","fork":false,"url":"https://api.github.com/repos/DoSomething/mb-logging-api","forks_url":"https://api.github.com/repos/DoSomething/mb-logging-api/forks","keys_url":"https://api.github.com/repos/DoSomething/mb-logging-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DoSomething/mb-logging-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DoSomething/mb-logging-api/teams","hooks_url":"https://api.github.com/repos/DoSomething/mb-logging-api/hooks","issue_events_url":"https://api.github.com/repos/DoSomething/mb-logging-api/issues/events{/number}","events_url":"https://api.github.com/repos/DoSomething/mb-logging-api/events","assignees_url":"https://api.github.com/repos/DoSomething/mb-logging-api/assignees{/user}","branches_url":"https://api.github.com/repos/DoSomething/mb-logging-api/branches{/branch}","tags_url":"https://api.github.com/repos/DoSomething/mb-logging-api/tags","blobs_url":"https://api.github.com/repos/DoSomething/mb-logging-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DoSomething/mb-logging-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DoSomething/mb-logging-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/DoSomething/mb-logging-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DoSomething/mb-logging-api/statuses/{sha}","languages_url":"https://api.github.com/repos/DoSomething/mb-logging-api/languages","stargazers_url":"https://api.github.com/repos/DoSomething/mb-logging-api/stargazers","contributors_url":"https://api.github.com/repos/DoSomething/mb-logging-api/contributors","subscribers_url":"https://api.github.com/repos/DoSomething/mb-logging-api/subscribers","subscription_url":"https://api.github.com/repos/DoSomething/mb-logging-api/subscription","commits_url":"https://api.github.com/repos/DoSomething/mb-logging-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/DoSomething/mb-logging-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/DoSomething/mb-logging-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/DoSomething/mb-logging-api/issues/comments/{number}","contents_url":"https://api.github.com/repos/DoSomething/mb-logging-api/contents/{+path}","compare_url":"https://api.github.com/repos/DoSomething/mb-logging-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DoSomething/mb-logging-api/merges","archive_url":"https://api.github.com/repos/DoSomething/mb-logging-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DoSomething/mb-logging-api/downloads","issues_url":"https://api.github.com/repos/DoSomething/mb-logging-api/issues{/number}","pulls_url":"https://api.github.com/repos/DoSomething/mb-logging-api/pulls{/number}","milestones_url":"https://api.github.com/repos/DoSomething/mb-logging-api/milestones{/number}","notifications_url":"https://api.github.com/repos/DoSomething/mb-logging-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DoSomething/mb-logging-api/labels{/name}","releases_url":"https://api.github.com/repos/DoSomething/mb-logging-api/releases{/id}","created_at":"2014-09-02T19:22:30Z","updated_at":"2014-09-04T00:38:44Z","pushed_at":"2014-09-18T14:24:02Z","git_url":"git://github.com/DoSomething/mb-logging-api.git","ssh_url":"git@github.com:DoSomething/mb-logging-api.git","clone_url":"https://github.com/DoSomething/mb-logging-api.git","svn_url":"https://github.com/DoSomething/mb-logging-api","homepage":null,"size":316,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DoSomething/mb-logging-api/pulls/10"},"html":{"href":"https://github.com/DoSomething/mb-logging-api/pull/10"},"issue":{"href":"https://api.github.com/repos/DoSomething/mb-logging-api/issues/10"},"comments":{"href":"https://api.github.com/repos/DoSomething/mb-logging-api/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/DoSomething/mb-logging-api/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/DoSomething/mb-logging-api/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/DoSomething/mb-logging-api/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/DoSomething/mb-logging-api/statuses/28f55ca8a1b331f0d363f20d6d7e686607953fe1"}}}}