GitHub PullRequestReviewCommentEvent at 2014-12-05 17:05:19
Repository: strong-arc
Actor: anthonyettinger
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/strongloop/strong-arc/pulls/comments/21384359","id":21384359,"diff_hunk":"@@ -0,0 +1,86 @@\n+Metrics.directive('slMetricsTitle', [\n+  function() {\n+    return {\n+      templateUrl: './scripts/modules/metrics/templates/metrics.title.html'\n+    }\n+  }\n+]);\n+Metrics.directive('slMetricsInstrumentation', [\n+  function() {\n+    return {\n+      link: function(scope, el, attrs) {\n+\n+        window.setUI();\n+\n+        scope.$watch('sysTime', function(newVal) {\n+          React.renderComponent(MetricsUpdateCounter({scope:scope}), el[0]);\n+        }, true);\n+      }\n+    }\n+  }\n+]);\n+Metrics.directive('slMetricsSettings', [\n+  function() {\n+    return {\n+      templateUrl: './scripts/modules/metrics/templates/metrics.settings.html'\n+    }\n+  }\n+]);\n+Metrics.directive('slMetricsChartControls', [\n+  'MetricsService',\n+  'ChartConfigService',\n+  function(MetricsService, ChartConfigService) {\n+    return {\n+      templateUrl: './scripts/modules/metrics/templates/metrics.chart.controls.html',\n+      link: function(scope, el, attrs) {\n+        /*\n+         *\n+         * HTML\n+         *\n+         * CHART CONTROL\n+         *\n+         *\n+         * */\n+        scope.toggleChartMetric = function(chartMetricName) {\n+\n+          var chartName = chartMetricName.split('.')[0];\n+          var chartConfigs = ChartConfigService.getChartConfigs();\n+          chartConfigs[chartName].metrics.map(function(metric) {\n+            if (metric.name === chartMetricName) {\n+              metric.active = !metric.active;\n+              scope.reRenderChart(chartName);\n+            }\n+          });\n+        }\n+\n+        /*\n+         *\n+         * CHART CONTROLS - ACTIVE INDICATOR CIRCLE\n+         *\n+         * */\n+        scope.getChartControlItemColor = function(item) {\n+          var x  = item;\n+          var styleString = '';\n+          if (item.active) {\n+            styleString = 'border:1px solid  '+ item.color + ';background-color: '+ item.color;\n+            return styleString;\n+          }\n+          else {\n+            styleString = 'border:1px solid #aaaaaa;background-color: #555555;';\n+            return styleString;\n+          }\n+        };","path":"client/www/scripts/modules/metrics/metrics.directives.js","position":72,"original_position":72,"commit_id":"68b3ee00cc8c721edb8e25a38059d75d4555908e","original_commit_id":"68b3ee00cc8c721edb8e25a38059d75d4555908e","user":{"login":"anthonyettinger","id":8658514,"avatar_url":"https://avatars.githubusercontent.com/u/8658514?v=3","gravatar_id":"","url":"https://api.github.com/users/anthonyettinger","html_url":"https://github.com/anthonyettinger","followers_url":"https://api.github.com/users/anthonyettinger/followers","following_url":"https://api.github.com/users/anthonyettinger/following{/other_user}","gists_url":"https://api.github.com/users/anthonyettinger/gists{/gist_id}","starred_url":"https://api.github.com/users/anthonyettinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthonyettinger/subscriptions","organizations_url":"https://api.github.com/users/anthonyettinger/orgs","repos_url":"https://api.github.com/users/anthonyettinger/repos","events_url":"https://api.github.com/users/anthonyettinger/events{/privacy}","received_events_url":"https://api.github.com/users/anthonyettinger/received_events","type":"User","site_admin":false},"body":"I'm sure you had a good reason, but did you mean to use inline css here instead of a class?","created_at":"2014-12-05T17:05:19Z","updated_at":"2014-12-05T17:05:19Z","html_url":"https://github.com/strongloop/strong-arc/pull/623#discussion_r21384359","pull_request_url":"https://api.github.com/repos/strongloop/strong-arc/pulls/623","_links":{"self":{"href":"https://api.github.com/repos/strongloop/strong-arc/pulls/comments/21384359"},"html":{"href":"https://github.com/strongloop/strong-arc/pull/623#discussion_r21384359"},"pull_request":{"href":"https://api.github.com/repos/strongloop/strong-arc/pulls/623"}}},"pull_request":{"url":"https://api.github.com/repos/strongloop/strong-arc/pulls/623","id":25558097,"html_url":"https://github.com/strongloop/strong-arc/pull/623","diff_url":"https://github.com/strongloop/strong-arc/pull/623.diff","patch_url":"https://github.com/strongloop/strong-arc/pull/623.patch","issue_url":"https://api.github.com/repos/strongloop/strong-arc/issues/623","number":623,"state":"open","locked":false,"title":"metrics visualization initial module implementation","user":{"login":"seanbrookes","id":1751524,"avatar_url":"https://avatars.githubusercontent.com/u/1751524?v=3","gravatar_id":"","url":"https://api.github.com/users/seanbrookes","html_url":"https://github.com/seanbrookes","followers_url":"https://api.github.com/users/seanbrookes/followers","following_url":"https://api.github.com/users/seanbrookes/following{/other_user}","gists_url":"https://api.github.com/users/seanbrookes/gists{/gist_id}","starred_url":"https://api.github.com/users/seanbrookes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanbrookes/subscriptions","organizations_url":"https://api.github.com/users/seanbrookes/orgs","repos_url":"https://api.github.com/users/seanbrookes/repos","events_url":"https://api.github.com/users/seanbrookes/events{/privacy}","received_events_url":"https://api.github.com/users/seanbrookes/received_events","type":"User","site_admin":false},"body":"- establish metrics module\r\n\r\nThis PR is primarily for the initial implementation of the metrics arc module but also contains some enhancements for the PID selector which is shared by the profiler.\r\n\r\nthe PID selector changes are mostly arround remembering references to previous pm servers for convenience\r\n\r\nFixes #578 \r\nFixes #594 \r\nFixes #479 \r\nFixes #482 \r\nFixes #502\r\n\r\n/to @bajtos @anthonyettinger ","created_at":"2014-12-05T09:24:56Z","updated_at":"2014-12-05T17:05:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"205ee7d7963e76f4015fcf8e623c6678235d3679","assignee":{"login":"anthonyettinger","id":8658514,"avatar_url":"https://avatars.githubusercontent.com/u/8658514?v=3","gravatar_id":"","url":"https://api.github.com/users/anthonyettinger","html_url":"https://github.com/anthonyettinger","followers_url":"https://api.github.com/users/anthonyettinger/followers","following_url":"https://api.github.com/users/anthonyettinger/following{/other_user}","gists_url":"https://api.github.com/users/anthonyettinger/gists{/gist_id}","starred_url":"https://api.github.com/users/anthonyettinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthonyettinger/subscriptions","organizations_url":"https://api.github.com/users/anthonyettinger/orgs","repos_url":"https://api.github.com/users/anthonyettinger/repos","events_url":"https://api.github.com/users/anthonyettinger/events{/privacy}","received_events_url":"https://api.github.com/users/anthonyettinger/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/strongloop/strong-arc/pulls/623/commits","review_comments_url":"https://api.github.com/repos/strongloop/strong-arc/pulls/623/comments","review_comment_url":"https://api.github.com/repos/strongloop/strong-arc/pulls/comments/{number}","comments_url":"https://api.github.com/repos/strongloop/strong-arc/issues/623/comments","statuses_url":"https://api.github.com/repos/strongloop/strong-arc/statuses/68b3ee00cc8c721edb8e25a38059d75d4555908e","head":{"label":"strongloop:feature/426-metrics-module-v.0.0.1","ref":"feature/426-metrics-module-v.0.0.1","sha":"68b3ee00cc8c721edb8e25a38059d75d4555908e","user":{"login":"strongloop","id":3020012,"avatar_url":"https://avatars.githubusercontent.com/u/3020012?v=3","gravatar_id":"","url":"https://api.github.com/users/strongloop","html_url":"https://github.com/strongloop","followers_url":"https://api.github.com/users/strongloop/followers","following_url":"https://api.github.com/users/strongloop/following{/other_user}","gists_url":"https://api.github.com/users/strongloop/gists{/gist_id}","starred_url":"https://api.github.com/users/strongloop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strongloop/subscriptions","organizations_url":"https://api.github.com/users/strongloop/orgs","repos_url":"https://api.github.com/users/strongloop/repos","events_url":"https://api.github.com/users/strongloop/events{/privacy}","received_events_url":"https://api.github.com/users/strongloop/received_events","type":"Organization","site_admin":false},"repo":{"id":19257170,"name":"strong-arc","full_name":"strongloop/strong-arc","owner":{"login":"strongloop","id":3020012,"avatar_url":"https://avatars.githubusercontent.com/u/3020012?v=3","gravatar_id":"","url":"https://api.github.com/users/strongloop","html_url":"https://github.com/strongloop","followers_url":"https://api.github.com/users/strongloop/followers","following_url":"https://api.github.com/users/strongloop/following{/other_user}","gists_url":"https://api.github.com/users/strongloop/gists{/gist_id}","starred_url":"https://api.github.com/users/strongloop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strongloop/subscriptions","organizations_url":"https://api.github.com/users/strongloop/orgs","repos_url":"https://api.github.com/users/strongloop/repos","events_url":"https://api.github.com/users/strongloop/events{/privacy}","received_events_url":"https://api.github.com/users/strongloop/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/strongloop/strong-arc","description":"StrongLoop Arc (formerly known as Studio) is the GUI front end to StrongLoop products including LoopBack and our upcoming NodeOps features.  StrongLoop Arc makes developing APIs and managing Node.js applications easier for all developers and devops engineers","fork":false,"url":"https://api.github.com/repos/strongloop/strong-arc","forks_url":"https://api.github.com/repos/strongloop/strong-arc/forks","keys_url":"https://api.github.com/repos/strongloop/strong-arc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/strongloop/strong-arc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/strongloop/strong-arc/teams","hooks_url":"https://api.github.com/repos/strongloop/strong-arc/hooks","issue_events_url":"https://api.github.com/repos/strongloop/strong-arc/issues/events{/number}","events_url":"https://api.github.com/repos/strongloop/strong-arc/events","assignees_url":"https://api.github.com/repos/strongloop/strong-arc/assignees{/user}","branches_url":"https://api.github.com/repos/strongloop/strong-arc/branches{/branch}","tags_url":"https://api.github.com/repos/strongloop/strong-arc/tags","blobs_url":"https://api.github.com/repos/strongloop/strong-arc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/strongloop/strong-arc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/strongloop/strong-arc/git/refs{/sha}","trees_url":"https://api.github.com/repos/strongloop/strong-arc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/strongloop/strong-arc/statuses/{sha}","languages_url":"https://api.github.com/repos/strongloop/strong-arc/languages","stargazers_url":"https://api.github.com/repos/strongloop/strong-arc/stargazers","contributors_url":"https://api.github.com/repos/strongloop/strong-arc/contributors","subscribers_url":"https://api.github.com/repos/strongloop/strong-arc/subscribers","subscription_url":"https://api.github.com/repos/strongloop/strong-arc/subscription","commits_url":"https://api.github.com/repos/strongloop/strong-arc/commits{/sha}","git_commits_url":"https://api.github.com/repos/strongloop/strong-arc/git/commits{/sha}","comments_url":"https://api.github.com/repos/strongloop/strong-arc/comments{/number}","issue_comment_url":"https://api.github.com/repos/strongloop/strong-arc/issues/comments/{number}","contents_url":"https://api.github.com/repos/strongloop/strong-arc/contents/{+path}","compare_url":"https://api.github.com/repos/strongloop/strong-arc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/strongloop/strong-arc/merges","archive_url":"https://api.github.com/repos/strongloop/strong-arc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/strongloop/strong-arc/downloads","issues_url":"https://api.github.com/repos/strongloop/strong-arc/issues{/number}","pulls_url":"https://api.github.com/repos/strongloop/strong-arc/pulls{/number}","milestones_url":"https://api.github.com/repos/strongloop/strong-arc/milestones{/number}","notifications_url":"https://api.github.com/repos/strongloop/strong-arc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/strongloop/strong-arc/labels{/name}","releases_url":"https://api.github.com/repos/strongloop/strong-arc/releases{/id}","created_at":"2014-04-28T23:15:53Z","updated_at":"2014-12-04T06:58:41Z","pushed_at":"2014-12-05T15:41:19Z","git_url":"git://github.com/strongloop/strong-arc.git","ssh_url":"git@github.com:strongloop/strong-arc.git","clone_url":"https://github.com/strongloop/strong-arc.git","svn_url":"https://github.com/strongloop/strong-arc","homepage":"","size":10014,"stargazers_count":21,"watchers_count":21,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":171,"forks":1,"open_issues":171,"watchers":21,"default_branch":"master"}},"base":{"label":"strongloop:master","ref":"master","sha":"dec5ab7538933f68ca57a978ae6528e9918467b3","user":{"login":"strongloop","id":3020012,"avatar_url":"https://avatars.githubusercontent.com/u/3020012?v=3","gravatar_id":"","url":"https://api.github.com/users/strongloop","html_url":"https://github.com/strongloop","followers_url":"https://api.github.com/users/strongloop/followers","following_url":"https://api.github.com/users/strongloop/following{/other_user}","gists_url":"https://api.github.com/users/strongloop/gists{/gist_id}","starred_url":"https://api.github.com/users/strongloop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strongloop/subscriptions","organizations_url":"https://api.github.com/users/strongloop/orgs","repos_url":"https://api.github.com/users/strongloop/repos","events_url":"https://api.github.com/users/strongloop/events{/privacy}","received_events_url":"https://api.github.com/users/strongloop/received_events","type":"Organization","site_admin":false},"repo":{"id":19257170,"name":"strong-arc","full_name":"strongloop/strong-arc","owner":{"login":"strongloop","id":3020012,"avatar_url":"https://avatars.githubusercontent.com/u/3020012?v=3","gravatar_id":"","url":"https://api.github.com/users/strongloop","html_url":"https://github.com/strongloop","followers_url":"https://api.github.com/users/strongloop/followers","following_url":"https://api.github.com/users/strongloop/following{/other_user}","gists_url":"https://api.github.com/users/strongloop/gists{/gist_id}","starred_url":"https://api.github.com/users/strongloop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strongloop/subscriptions","organizations_url":"https://api.github.com/users/strongloop/orgs","repos_url":"https://api.github.com/users/strongloop/repos","events_url":"https://api.github.com/users/strongloop/events{/privacy}","received_events_url":"https://api.github.com/users/strongloop/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/strongloop/strong-arc","description":"StrongLoop Arc (formerly known as Studio) is the GUI front end to StrongLoop products including LoopBack and our upcoming NodeOps features.  StrongLoop Arc makes developing APIs and managing Node.js applications easier for all developers and devops engineers","fork":false,"url":"https://api.github.com/repos/strongloop/strong-arc","forks_url":"https://api.github.com/repos/strongloop/strong-arc/forks","keys_url":"https://api.github.com/repos/strongloop/strong-arc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/strongloop/strong-arc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/strongloop/strong-arc/teams","hooks_url":"https://api.github.com/repos/strongloop/strong-arc/hooks","issue_events_url":"https://api.github.com/repos/strongloop/strong-arc/issues/events{/number}","events_url":"https://api.github.com/repos/strongloop/strong-arc/events","assignees_url":"https://api.github.com/repos/strongloop/strong-arc/assignees{/user}","branches_url":"https://api.github.com/repos/strongloop/strong-arc/branches{/branch}","tags_url":"https://api.github.com/repos/strongloop/strong-arc/tags","blobs_url":"https://api.github.com/repos/strongloop/strong-arc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/strongloop/strong-arc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/strongloop/strong-arc/git/refs{/sha}","trees_url":"https://api.github.com/repos/strongloop/strong-arc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/strongloop/strong-arc/statuses/{sha}","languages_url":"https://api.github.com/repos/strongloop/strong-arc/languages","stargazers_url":"https://api.github.com/repos/strongloop/strong-arc/stargazers","contributors_url":"https://api.github.com/repos/strongloop/strong-arc/contributors","subscribers_url":"https://api.github.com/repos/strongloop/strong-arc/subscribers","subscription_url":"https://api.github.com/repos/strongloop/strong-arc/subscription","commits_url":"https://api.github.com/repos/strongloop/strong-arc/commits{/sha}","git_commits_url":"https://api.github.com/repos/strongloop/strong-arc/git/commits{/sha}","comments_url":"https://api.github.com/repos/strongloop/strong-arc/comments{/number}","issue_comment_url":"https://api.github.com/repos/strongloop/strong-arc/issues/comments/{number}","contents_url":"https://api.github.com/repos/strongloop/strong-arc/contents/{+path}","compare_url":"https://api.github.com/repos/strongloop/strong-arc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/strongloop/strong-arc/merges","archive_url":"https://api.github.com/repos/strongloop/strong-arc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/strongloop/strong-arc/downloads","issues_url":"https://api.github.com/repos/strongloop/strong-arc/issues{/number}","pulls_url":"https://api.github.com/repos/strongloop/strong-arc/pulls{/number}","milestones_url":"https://api.github.com/repos/strongloop/strong-arc/milestones{/number}","notifications_url":"https://api.github.com/repos/strongloop/strong-arc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/strongloop/strong-arc/labels{/name}","releases_url":"https://api.github.com/repos/strongloop/strong-arc/releases{/id}","created_at":"2014-04-28T23:15:53Z","updated_at":"2014-12-04T06:58:41Z","pushed_at":"2014-12-05T15:41:19Z","git_url":"git://github.com/strongloop/strong-arc.git","ssh_url":"git@github.com:strongloop/strong-arc.git","clone_url":"https://github.com/strongloop/strong-arc.git","svn_url":"https://github.com/strongloop/strong-arc","homepage":"","size":10014,"stargazers_count":21,"watchers_count":21,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":171,"forks":1,"open_issues":171,"watchers":21,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/strongloop/strong-arc/pulls/623"},"html":{"href":"https://github.com/strongloop/strong-arc/pull/623"},"issue":{"href":"https://api.github.com/repos/strongloop/strong-arc/issues/623"},"comments":{"href":"https://api.github.com/repos/strongloop/strong-arc/issues/623/comments"},"review_comments":{"href":"https://api.github.com/repos/strongloop/strong-arc/pulls/623/comments"},"review_comment":{"href":"https://api.github.com/repos/strongloop/strong-arc/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/strongloop/strong-arc/pulls/623/commits"},"statuses":{"href":"https://api.github.com/repos/strongloop/strong-arc/statuses/68b3ee00cc8c721edb8e25a38059d75d4555908e"}}}}