GitHub PullRequestReviewCommentEvent at 2014-09-29 17:43:04
Repository: harpoon
Actor: peterbourgon
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/soundcloud/harpoon/pulls/comments/18170170","id":18170170,"diff_hunk":"@@ -17,3 +17,12 @@ archive:\n \tGOOS=$(GOOS) GOARCH=$(GOARCH) go build -o $(DISTDIR)/harpoon-container ./harpoon-container\n \tGOOS=$(GOOS) GOARCH=$(GOARCH) go build -o $(DISTDIR)/harpoon-scheduler ./harpoon-scheduler\n \ttar -C $(DISTDIR) -czvf dist/$(ARCHIVE) .\n+\n+.PHONY: get-deps\n+get-deps:\n+\tGOOS=$(GOOS) GOARCH=$(GOARCH) go get github.com/tools/godep\n+\tGOOS=$(GOOS) GOARCH=$(GOARCH) go build github.com/tools/godep\n+\tGOOS=$(GOOS) GOARCH=$(GOARCH) go install github.com/tools/godep\n+\tGOOS=$(GOOS) GOARCH=$(GOARCH) ./godep restore\n+\tGOOS=$(GOOS) GOARCH=$(GOARCH) rm godep","path":"Makefile","position":11,"original_position":11,"commit_id":"7a940aee5e4b8eede785e2e82a1bf5be5b35e9a8","original_commit_id":"7a940aee5e4b8eede785e2e82a1bf5be5b35e9a8","user":{"login":"peterbourgon","id":114509,"avatar_url":"https://avatars.githubusercontent.com/u/114509?v=2","gravatar_id":"","url":"https://api.github.com/users/peterbourgon","html_url":"https://github.com/peterbourgon","followers_url":"https://api.github.com/users/peterbourgon/followers","following_url":"https://api.github.com/users/peterbourgon/following{/other_user}","gists_url":"https://api.github.com/users/peterbourgon/gists{/gist_id}","starred_url":"https://api.github.com/users/peterbourgon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterbourgon/subscriptions","organizations_url":"https://api.github.com/users/peterbourgon/orgs","repos_url":"https://api.github.com/users/peterbourgon/repos","events_url":"https://api.github.com/users/peterbourgon/events{/privacy}","received_events_url":"https://api.github.com/users/peterbourgon/received_events","type":"User","site_admin":false},"body":"Ah, shoot. Well, then I'd hope that a plain `godep` should work, as I'd hope the base `$GOPATH/bin` is added to the $PATH...","created_at":"2014-09-29T17:43:04Z","updated_at":"2014-09-29T17:43:04Z","html_url":"https://github.com/soundcloud/harpoon/pull/76#discussion_r18170170","pull_request_url":"https://api.github.com/repos/soundcloud/harpoon/pulls/76","_links":{"self":{"href":"https://api.github.com/repos/soundcloud/harpoon/pulls/comments/18170170"},"html":{"href":"https://github.com/soundcloud/harpoon/pull/76#discussion_r18170170"},"pull_request":{"href":"https://api.github.com/repos/soundcloud/harpoon/pulls/76"}}},"pull_request":{"url":"https://api.github.com/repos/soundcloud/harpoon/pulls/76","id":21939221,"html_url":"https://github.com/soundcloud/harpoon/pull/76","diff_url":"https://github.com/soundcloud/harpoon/pull/76.diff","patch_url":"https://github.com/soundcloud/harpoon/pull/76.patch","issue_url":"https://api.github.com/repos/soundcloud/harpoon/issues/76","number":76,"state":"open","locked":false,"title":"Explicitly manage dependencies","user":{"login":"jmyounker","id":882634,"avatar_url":"https://avatars.githubusercontent.com/u/882634?v=2","gravatar_id":"","url":"https://api.github.com/users/jmyounker","html_url":"https://github.com/jmyounker","followers_url":"https://api.github.com/users/jmyounker/followers","following_url":"https://api.github.com/users/jmyounker/following{/other_user}","gists_url":"https://api.github.com/users/jmyounker/gists{/gist_id}","starred_url":"https://api.github.com/users/jmyounker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmyounker/subscriptions","organizations_url":"https://api.github.com/users/jmyounker/orgs","repos_url":"https://api.github.com/users/jmyounker/repos","events_url":"https://api.github.com/users/jmyounker/events{/privacy}","received_events_url":"https://api.github.com/users/jmyounker/received_events","type":"User","site_admin":false},"body":"A working example of how to manage our dependencies with godep.  @pb @ohm @elenadeneva92 ","created_at":"2014-09-29T14:46:25Z","updated_at":"2014-09-29T17:43:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"708ccd5c2685a0cfa360eef34d7161e2e898f5a0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/soundcloud/harpoon/pulls/76/commits","review_comments_url":"https://api.github.com/repos/soundcloud/harpoon/pulls/76/comments","review_comment_url":"https://api.github.com/repos/soundcloud/harpoon/pulls/comments/{number}","comments_url":"https://api.github.com/repos/soundcloud/harpoon/issues/76/comments","statuses_url":"https://api.github.com/repos/soundcloud/harpoon/statuses/7a940aee5e4b8eede785e2e82a1bf5be5b35e9a8","head":{"label":"soundcloud:bug_issue_74","ref":"bug_issue_74","sha":"7a940aee5e4b8eede785e2e82a1bf5be5b35e9a8","user":{"login":"soundcloud","id":21021,"avatar_url":"https://avatars.githubusercontent.com/u/21021?v=2","gravatar_id":"","url":"https://api.github.com/users/soundcloud","html_url":"https://github.com/soundcloud","followers_url":"https://api.github.com/users/soundcloud/followers","following_url":"https://api.github.com/users/soundcloud/following{/other_user}","gists_url":"https://api.github.com/users/soundcloud/gists{/gist_id}","starred_url":"https://api.github.com/users/soundcloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soundcloud/subscriptions","organizations_url":"https://api.github.com/users/soundcloud/orgs","repos_url":"https://api.github.com/users/soundcloud/repos","events_url":"https://api.github.com/users/soundcloud/events{/privacy}","received_events_url":"https://api.github.com/users/soundcloud/received_events","type":"Organization","site_admin":false},"repo":{"id":21981956,"name":"harpoon","full_name":"soundcloud/harpoon","owner":{"login":"soundcloud","id":21021,"avatar_url":"https://avatars.githubusercontent.com/u/21021?v=2","gravatar_id":"","url":"https://api.github.com/users/soundcloud","html_url":"https://github.com/soundcloud","followers_url":"https://api.github.com/users/soundcloud/followers","following_url":"https://api.github.com/users/soundcloud/following{/other_user}","gists_url":"https://api.github.com/users/soundcloud/gists{/gist_id}","starred_url":"https://api.github.com/users/soundcloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soundcloud/subscriptions","organizations_url":"https://api.github.com/users/soundcloud/orgs","repos_url":"https://api.github.com/users/soundcloud/repos","events_url":"https://api.github.com/users/soundcloud/events{/privacy}","received_events_url":"https://api.github.com/users/soundcloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/soundcloud/harpoon","description":"A comprehensive application platform.","fork":false,"url":"https://api.github.com/repos/soundcloud/harpoon","forks_url":"https://api.github.com/repos/soundcloud/harpoon/forks","keys_url":"https://api.github.com/repos/soundcloud/harpoon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/soundcloud/harpoon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/soundcloud/harpoon/teams","hooks_url":"https://api.github.com/repos/soundcloud/harpoon/hooks","issue_events_url":"https://api.github.com/repos/soundcloud/harpoon/issues/events{/number}","events_url":"https://api.github.com/repos/soundcloud/harpoon/events","assignees_url":"https://api.github.com/repos/soundcloud/harpoon/assignees{/user}","branches_url":"https://api.github.com/repos/soundcloud/harpoon/branches{/branch}","tags_url":"https://api.github.com/repos/soundcloud/harpoon/tags","blobs_url":"https://api.github.com/repos/soundcloud/harpoon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/soundcloud/harpoon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/soundcloud/harpoon/git/refs{/sha}","trees_url":"https://api.github.com/repos/soundcloud/harpoon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/soundcloud/harpoon/statuses/{sha}","languages_url":"https://api.github.com/repos/soundcloud/harpoon/languages","stargazers_url":"https://api.github.com/repos/soundcloud/harpoon/stargazers","contributors_url":"https://api.github.com/repos/soundcloud/harpoon/contributors","subscribers_url":"https://api.github.com/repos/soundcloud/harpoon/subscribers","subscription_url":"https://api.github.com/repos/soundcloud/harpoon/subscription","commits_url":"https://api.github.com/repos/soundcloud/harpoon/commits{/sha}","git_commits_url":"https://api.github.com/repos/soundcloud/harpoon/git/commits{/sha}","comments_url":"https://api.github.com/repos/soundcloud/harpoon/comments{/number}","issue_comment_url":"https://api.github.com/repos/soundcloud/harpoon/issues/comments/{number}","contents_url":"https://api.github.com/repos/soundcloud/harpoon/contents/{+path}","compare_url":"https://api.github.com/repos/soundcloud/harpoon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/soundcloud/harpoon/merges","archive_url":"https://api.github.com/repos/soundcloud/harpoon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/soundcloud/harpoon/downloads","issues_url":"https://api.github.com/repos/soundcloud/harpoon/issues{/number}","pulls_url":"https://api.github.com/repos/soundcloud/harpoon/pulls{/number}","milestones_url":"https://api.github.com/repos/soundcloud/harpoon/milestones{/number}","notifications_url":"https://api.github.com/repos/soundcloud/harpoon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/soundcloud/harpoon/labels{/name}","releases_url":"https://api.github.com/repos/soundcloud/harpoon/releases{/id}","created_at":"2014-07-18T13:54:47Z","updated_at":"2014-09-22T15:57:32Z","pushed_at":"2014-09-29T16:28:24Z","git_url":"git://github.com/soundcloud/harpoon.git","ssh_url":"git@github.com:soundcloud/harpoon.git","clone_url":"https://github.com/soundcloud/harpoon.git","svn_url":"https://github.com/soundcloud/harpoon","homepage":null,"size":3004,"stargazers_count":43,"watchers_count":43,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":19,"forks":1,"open_issues":19,"watchers":43,"default_branch":"master"}},"base":{"label":"soundcloud:master","ref":"master","sha":"f6f7d37726f45f237b446f26b07a579fb08b3817","user":{"login":"soundcloud","id":21021,"avatar_url":"https://avatars.githubusercontent.com/u/21021?v=2","gravatar_id":"","url":"https://api.github.com/users/soundcloud","html_url":"https://github.com/soundcloud","followers_url":"https://api.github.com/users/soundcloud/followers","following_url":"https://api.github.com/users/soundcloud/following{/other_user}","gists_url":"https://api.github.com/users/soundcloud/gists{/gist_id}","starred_url":"https://api.github.com/users/soundcloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soundcloud/subscriptions","organizations_url":"https://api.github.com/users/soundcloud/orgs","repos_url":"https://api.github.com/users/soundcloud/repos","events_url":"https://api.github.com/users/soundcloud/events{/privacy}","received_events_url":"https://api.github.com/users/soundcloud/received_events","type":"Organization","site_admin":false},"repo":{"id":21981956,"name":"harpoon","full_name":"soundcloud/harpoon","owner":{"login":"soundcloud","id":21021,"avatar_url":"https://avatars.githubusercontent.com/u/21021?v=2","gravatar_id":"","url":"https://api.github.com/users/soundcloud","html_url":"https://github.com/soundcloud","followers_url":"https://api.github.com/users/soundcloud/followers","following_url":"https://api.github.com/users/soundcloud/following{/other_user}","gists_url":"https://api.github.com/users/soundcloud/gists{/gist_id}","starred_url":"https://api.github.com/users/soundcloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soundcloud/subscriptions","organizations_url":"https://api.github.com/users/soundcloud/orgs","repos_url":"https://api.github.com/users/soundcloud/repos","events_url":"https://api.github.com/users/soundcloud/events{/privacy}","received_events_url":"https://api.github.com/users/soundcloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/soundcloud/harpoon","description":"A comprehensive application platform.","fork":false,"url":"https://api.github.com/repos/soundcloud/harpoon","forks_url":"https://api.github.com/repos/soundcloud/harpoon/forks","keys_url":"https://api.github.com/repos/soundcloud/harpoon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/soundcloud/harpoon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/soundcloud/harpoon/teams","hooks_url":"https://api.github.com/repos/soundcloud/harpoon/hooks","issue_events_url":"https://api.github.com/repos/soundcloud/harpoon/issues/events{/number}","events_url":"https://api.github.com/repos/soundcloud/harpoon/events","assignees_url":"https://api.github.com/repos/soundcloud/harpoon/assignees{/user}","branches_url":"https://api.github.com/repos/soundcloud/harpoon/branches{/branch}","tags_url":"https://api.github.com/repos/soundcloud/harpoon/tags","blobs_url":"https://api.github.com/repos/soundcloud/harpoon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/soundcloud/harpoon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/soundcloud/harpoon/git/refs{/sha}","trees_url":"https://api.github.com/repos/soundcloud/harpoon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/soundcloud/harpoon/statuses/{sha}","languages_url":"https://api.github.com/repos/soundcloud/harpoon/languages","stargazers_url":"https://api.github.com/repos/soundcloud/harpoon/stargazers","contributors_url":"https://api.github.com/repos/soundcloud/harpoon/contributors","subscribers_url":"https://api.github.com/repos/soundcloud/harpoon/subscribers","subscription_url":"https://api.github.com/repos/soundcloud/harpoon/subscription","commits_url":"https://api.github.com/repos/soundcloud/harpoon/commits{/sha}","git_commits_url":"https://api.github.com/repos/soundcloud/harpoon/git/commits{/sha}","comments_url":"https://api.github.com/repos/soundcloud/harpoon/comments{/number}","issue_comment_url":"https://api.github.com/repos/soundcloud/harpoon/issues/comments/{number}","contents_url":"https://api.github.com/repos/soundcloud/harpoon/contents/{+path}","compare_url":"https://api.github.com/repos/soundcloud/harpoon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/soundcloud/harpoon/merges","archive_url":"https://api.github.com/repos/soundcloud/harpoon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/soundcloud/harpoon/downloads","issues_url":"https://api.github.com/repos/soundcloud/harpoon/issues{/number}","pulls_url":"https://api.github.com/repos/soundcloud/harpoon/pulls{/number}","milestones_url":"https://api.github.com/repos/soundcloud/harpoon/milestones{/number}","notifications_url":"https://api.github.com/repos/soundcloud/harpoon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/soundcloud/harpoon/labels{/name}","releases_url":"https://api.github.com/repos/soundcloud/harpoon/releases{/id}","created_at":"2014-07-18T13:54:47Z","updated_at":"2014-09-22T15:57:32Z","pushed_at":"2014-09-29T16:28:24Z","git_url":"git://github.com/soundcloud/harpoon.git","ssh_url":"git@github.com:soundcloud/harpoon.git","clone_url":"https://github.com/soundcloud/harpoon.git","svn_url":"https://github.com/soundcloud/harpoon","homepage":null,"size":3004,"stargazers_count":43,"watchers_count":43,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":19,"forks":1,"open_issues":19,"watchers":43,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/soundcloud/harpoon/pulls/76"},"html":{"href":"https://github.com/soundcloud/harpoon/pull/76"},"issue":{"href":"https://api.github.com/repos/soundcloud/harpoon/issues/76"},"comments":{"href":"https://api.github.com/repos/soundcloud/harpoon/issues/76/comments"},"review_comments":{"href":"https://api.github.com/repos/soundcloud/harpoon/pulls/76/comments"},"review_comment":{"href":"https://api.github.com/repos/soundcloud/harpoon/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/soundcloud/harpoon/pulls/76/commits"},"statuses":{"href":"https://api.github.com/repos/soundcloud/harpoon/statuses/7a940aee5e4b8eede785e2e82a1bf5be5b35e9a8"}}}}