GitHub PullRequestReviewCommentEvent at 2014-08-04 23:15:16
Repository: etcdctl
Actor: bmizerany
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/coreos/etcdctl/pulls/comments/15787524","id":15787524,"diff_hunk":"@@ -102,6 +103,19 @@ func handlePrint(c *cli.Context, fn handlerFunc, pFn printFunc) {\n \t}\n }\n \n+// Just like handlePrint but also passed the context of the command\n+func handleContextualPrint(c *cli.Context, fn handlerFunc, pFn contextualPrintFunc) {","path":"command/handle.go","position":13,"original_position":13,"commit_id":"5eaa0b00eb2e667946ddb3585576714a98cfe613","original_commit_id":"5eaa0b00eb2e667946ddb3585576714a98cfe613","user":{"login":"bmizerany","id":46,"avatar_url":"https://avatars.githubusercontent.com/u/46?v=2","gravatar_id":"1a250566b475961b9b36abf359950c76","url":"https://api.github.com/users/bmizerany","html_url":"https://github.com/bmizerany","followers_url":"https://api.github.com/users/bmizerany/followers","following_url":"https://api.github.com/users/bmizerany/following{/other_user}","gists_url":"https://api.github.com/users/bmizerany/gists{/gist_id}","starred_url":"https://api.github.com/users/bmizerany/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmizerany/subscriptions","organizations_url":"https://api.github.com/users/bmizerany/orgs","repos_url":"https://api.github.com/users/bmizerany/repos","events_url":"https://api.github.com/users/bmizerany/events{/privacy}","received_events_url":"https://api.github.com/users/bmizerany/received_events","type":"User","site_admin":false},"body":"Why the capital F in `pFn`?","created_at":"2014-08-04T23:15:16Z","updated_at":"2014-08-04T23:15:16Z","html_url":"https://github.com/coreos/etcdctl/pull/96#discussion_r15787524","pull_request_url":"https://api.github.com/repos/coreos/etcdctl/pulls/96","_links":{"self":{"href":"https://api.github.com/repos/coreos/etcdctl/pulls/comments/15787524"},"html":{"href":"https://github.com/coreos/etcdctl/pull/96#discussion_r15787524"},"pull_request":{"href":"https://api.github.com/repos/coreos/etcdctl/pulls/96"}}},"pull_request":{"url":"https://api.github.com/repos/coreos/etcdctl/pulls/96","id":18081690,"html_url":"https://github.com/coreos/etcdctl/pull/96","diff_url":"https://github.com/coreos/etcdctl/pull/96.diff","patch_url":"https://github.com/coreos/etcdctl/pull/96.patch","issue_url":"https://api.github.com/repos/coreos/etcdctl/issues/96","number":96,"state":"open","title":"`ls -p` for trailing slashes on directories","user":{"login":"mitbra","id":1271940,"avatar_url":"https://avatars.githubusercontent.com/u/1271940?v=2","gravatar_id":"9274969ba00b0d42d502f7d236457cfc","url":"https://api.github.com/users/mitbra","html_url":"https://github.com/mitbra","followers_url":"https://api.github.com/users/mitbra/followers","following_url":"https://api.github.com/users/mitbra/following{/other_user}","gists_url":"https://api.github.com/users/mitbra/gists{/gist_id}","starred_url":"https://api.github.com/users/mitbra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitbra/subscriptions","organizations_url":"https://api.github.com/users/mitbra/orgs","repos_url":"https://api.github.com/users/mitbra/repos","events_url":"https://api.github.com/users/mitbra/events{/privacy}","received_events_url":"https://api.github.com/users/mitbra/received_events","type":"User","site_admin":false},"body":"As discussed in [this pull request](https://github.com/coreos/etcdctl/pull/93) I'm opting for matching the `ls -p` to append directories with a trailing slash.\r\n\r\nUse case would look like the following:\r\n\r\n```bash\r\n$ etcdctl ls /\r\n/akey\r\n/adir\r\n$ etcdctl ls -p / | grep -v \"/$\"\r\n/akey\r\n```\r\n","created_at":"2014-07-08T03:34:54Z","updated_at":"2014-08-04T23:15:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"249e7d0e371cd1e40ebc7066e84ffcde75bee5d6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/coreos/etcdctl/pulls/96/commits","review_comments_url":"https://api.github.com/repos/coreos/etcdctl/pulls/96/comments","review_comment_url":"https://api.github.com/repos/coreos/etcdctl/pulls/comments/{number}","comments_url":"https://api.github.com/repos/coreos/etcdctl/issues/96/comments","statuses_url":"https://api.github.com/repos/coreos/etcdctl/statuses/5eaa0b00eb2e667946ddb3585576714a98cfe613","head":{"label":"mitbra:ls-p","ref":"ls-p","sha":"5eaa0b00eb2e667946ddb3585576714a98cfe613","user":{"login":"mitbra","id":1271940,"avatar_url":"https://avatars.githubusercontent.com/u/1271940?v=2","gravatar_id":"9274969ba00b0d42d502f7d236457cfc","url":"https://api.github.com/users/mitbra","html_url":"https://github.com/mitbra","followers_url":"https://api.github.com/users/mitbra/followers","following_url":"https://api.github.com/users/mitbra/following{/other_user}","gists_url":"https://api.github.com/users/mitbra/gists{/gist_id}","starred_url":"https://api.github.com/users/mitbra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitbra/subscriptions","organizations_url":"https://api.github.com/users/mitbra/orgs","repos_url":"https://api.github.com/users/mitbra/repos","events_url":"https://api.github.com/users/mitbra/events{/privacy}","received_events_url":"https://api.github.com/users/mitbra/received_events","type":"User","site_admin":false},"repo":{"id":21259258,"name":"etcdctl","full_name":"mitbra/etcdctl","owner":{"login":"mitbra","id":1271940,"avatar_url":"https://avatars.githubusercontent.com/u/1271940?v=2","gravatar_id":"9274969ba00b0d42d502f7d236457cfc","url":"https://api.github.com/users/mitbra","html_url":"https://github.com/mitbra","followers_url":"https://api.github.com/users/mitbra/followers","following_url":"https://api.github.com/users/mitbra/following{/other_user}","gists_url":"https://api.github.com/users/mitbra/gists{/gist_id}","starred_url":"https://api.github.com/users/mitbra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitbra/subscriptions","organizations_url":"https://api.github.com/users/mitbra/orgs","repos_url":"https://api.github.com/users/mitbra/repos","events_url":"https://api.github.com/users/mitbra/events{/privacy}","received_events_url":"https://api.github.com/users/mitbra/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mitbra/etcdctl","description":"A simple command line client for etcd","fork":true,"url":"https://api.github.com/repos/mitbra/etcdctl","forks_url":"https://api.github.com/repos/mitbra/etcdctl/forks","keys_url":"https://api.github.com/repos/mitbra/etcdctl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mitbra/etcdctl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mitbra/etcdctl/teams","hooks_url":"https://api.github.com/repos/mitbra/etcdctl/hooks","issue_events_url":"https://api.github.com/repos/mitbra/etcdctl/issues/events{/number}","events_url":"https://api.github.com/repos/mitbra/etcdctl/events","assignees_url":"https://api.github.com/repos/mitbra/etcdctl/assignees{/user}","branches_url":"https://api.github.com/repos/mitbra/etcdctl/branches{/branch}","tags_url":"https://api.github.com/repos/mitbra/etcdctl/tags","blobs_url":"https://api.github.com/repos/mitbra/etcdctl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mitbra/etcdctl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mitbra/etcdctl/git/refs{/sha}","trees_url":"https://api.github.com/repos/mitbra/etcdctl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mitbra/etcdctl/statuses/{sha}","languages_url":"https://api.github.com/repos/mitbra/etcdctl/languages","stargazers_url":"https://api.github.com/repos/mitbra/etcdctl/stargazers","contributors_url":"https://api.github.com/repos/mitbra/etcdctl/contributors","subscribers_url":"https://api.github.com/repos/mitbra/etcdctl/subscribers","subscription_url":"https://api.github.com/repos/mitbra/etcdctl/subscription","commits_url":"https://api.github.com/repos/mitbra/etcdctl/commits{/sha}","git_commits_url":"https://api.github.com/repos/mitbra/etcdctl/git/commits{/sha}","comments_url":"https://api.github.com/repos/mitbra/etcdctl/comments{/number}","issue_comment_url":"https://api.github.com/repos/mitbra/etcdctl/issues/comments/{number}","contents_url":"https://api.github.com/repos/mitbra/etcdctl/contents/{+path}","compare_url":"https://api.github.com/repos/mitbra/etcdctl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mitbra/etcdctl/merges","archive_url":"https://api.github.com/repos/mitbra/etcdctl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mitbra/etcdctl/downloads","issues_url":"https://api.github.com/repos/mitbra/etcdctl/issues{/number}","pulls_url":"https://api.github.com/repos/mitbra/etcdctl/pulls{/number}","milestones_url":"https://api.github.com/repos/mitbra/etcdctl/milestones{/number}","notifications_url":"https://api.github.com/repos/mitbra/etcdctl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mitbra/etcdctl/labels{/name}","releases_url":"https://api.github.com/repos/mitbra/etcdctl/releases{/id}","created_at":"2014-06-27T00:34:50Z","updated_at":"2014-06-25T17:16:03Z","pushed_at":"2014-07-08T03:26:28Z","git_url":"git://github.com/mitbra/etcdctl.git","ssh_url":"git@github.com:mitbra/etcdctl.git","clone_url":"https://github.com/mitbra/etcdctl.git","svn_url":"https://github.com/mitbra/etcdctl","homepage":"","size":524,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"coreos:master","ref":"master","sha":"6dcd7c2e57669c8eaf06e12458b3bdeab39e7a56","user":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=2","gravatar_id":"f477564b23efc2dd243407e926976125","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"repo":{"id":11881707,"name":"etcdctl","full_name":"coreos/etcdctl","owner":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=2","gravatar_id":"f477564b23efc2dd243407e926976125","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coreos/etcdctl","description":"A simple command line client for etcd","fork":false,"url":"https://api.github.com/repos/coreos/etcdctl","forks_url":"https://api.github.com/repos/coreos/etcdctl/forks","keys_url":"https://api.github.com/repos/coreos/etcdctl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coreos/etcdctl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coreos/etcdctl/teams","hooks_url":"https://api.github.com/repos/coreos/etcdctl/hooks","issue_events_url":"https://api.github.com/repos/coreos/etcdctl/issues/events{/number}","events_url":"https://api.github.com/repos/coreos/etcdctl/events","assignees_url":"https://api.github.com/repos/coreos/etcdctl/assignees{/user}","branches_url":"https://api.github.com/repos/coreos/etcdctl/branches{/branch}","tags_url":"https://api.github.com/repos/coreos/etcdctl/tags","blobs_url":"https://api.github.com/repos/coreos/etcdctl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coreos/etcdctl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coreos/etcdctl/git/refs{/sha}","trees_url":"https://api.github.com/repos/coreos/etcdctl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coreos/etcdctl/statuses/{sha}","languages_url":"https://api.github.com/repos/coreos/etcdctl/languages","stargazers_url":"https://api.github.com/repos/coreos/etcdctl/stargazers","contributors_url":"https://api.github.com/repos/coreos/etcdctl/contributors","subscribers_url":"https://api.github.com/repos/coreos/etcdctl/subscribers","subscription_url":"https://api.github.com/repos/coreos/etcdctl/subscription","commits_url":"https://api.github.com/repos/coreos/etcdctl/commits{/sha}","git_commits_url":"https://api.github.com/repos/coreos/etcdctl/git/commits{/sha}","comments_url":"https://api.github.com/repos/coreos/etcdctl/comments{/number}","issue_comment_url":"https://api.github.com/repos/coreos/etcdctl/issues/comments/{number}","contents_url":"https://api.github.com/repos/coreos/etcdctl/contents/{+path}","compare_url":"https://api.github.com/repos/coreos/etcdctl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coreos/etcdctl/merges","archive_url":"https://api.github.com/repos/coreos/etcdctl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coreos/etcdctl/downloads","issues_url":"https://api.github.com/repos/coreos/etcdctl/issues{/number}","pulls_url":"https://api.github.com/repos/coreos/etcdctl/pulls{/number}","milestones_url":"https://api.github.com/repos/coreos/etcdctl/milestones{/number}","notifications_url":"https://api.github.com/repos/coreos/etcdctl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coreos/etcdctl/labels{/name}","releases_url":"https://api.github.com/repos/coreos/etcdctl/releases{/id}","created_at":"2013-08-04T16:53:49Z","updated_at":"2014-08-02T07:19:29Z","pushed_at":"2014-07-29T22:02:00Z","git_url":"git://github.com/coreos/etcdctl.git","ssh_url":"git@github.com:coreos/etcdctl.git","clone_url":"https://github.com/coreos/etcdctl.git","svn_url":"https://github.com/coreos/etcdctl","homepage":"","size":1465,"stargazers_count":113,"watchers_count":113,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":30,"mirror_url":null,"open_issues_count":21,"forks":30,"open_issues":21,"watchers":113,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coreos/etcdctl/pulls/96"},"html":{"href":"https://github.com/coreos/etcdctl/pull/96"},"issue":{"href":"https://api.github.com/repos/coreos/etcdctl/issues/96"},"comments":{"href":"https://api.github.com/repos/coreos/etcdctl/issues/96/comments"},"review_comments":{"href":"https://api.github.com/repos/coreos/etcdctl/pulls/96/comments"},"review_comment":{"href":"https://api.github.com/repos/coreos/etcdctl/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/coreos/etcdctl/pulls/96/commits"},"statuses":{"href":"https://api.github.com/repos/coreos/etcdctl/statuses/5eaa0b00eb2e667946ddb3585576714a98cfe613"}}}}