GitHub PullRequestReviewCommentEvent at 2014-12-16 01:26:08
Repository: uproxy
Actor: dborkan
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/uProxy/uproxy/pulls/comments/21872469","id":21872469,"diff_hunk":"@@ -29,7 +29,7 @@ Rule.symlink = (dir, dest='') =>\n     expand: true,\n     overwrite: true,\n     cwd: dir,\n-    src: ['**/*.ts'],\n+    src: ['**/*.ts', '**/*.html'],","path":"Gruntfile.coffee","position":5,"original_position":5,"commit_id":"24f1449e8370f928d923841e2eea400865d1d499","original_commit_id":"24f1449e8370f928d923841e2eea400865d1d499","user":{"login":"dborkan","id":6494307,"avatar_url":"https://avatars.githubusercontent.com/u/6494307?v=3","gravatar_id":"","url":"https://api.github.com/users/dborkan","html_url":"https://github.com/dborkan","followers_url":"https://api.github.com/users/dborkan/followers","following_url":"https://api.github.com/users/dborkan/following{/other_user}","gists_url":"https://api.github.com/users/dborkan/gists{/gist_id}","starred_url":"https://api.github.com/users/dborkan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dborkan/subscriptions","organizations_url":"https://api.github.com/users/dborkan/orgs","repos_url":"https://api.github.com/users/dborkan/repos","events_url":"https://api.github.com/users/dborkan/events{/privacy}","received_events_url":"https://api.github.com/users/dborkan/received_events","type":"User","site_admin":false},"body":"Can you add a comment explain that html files need to be symlinked because they will be \"compiled\" by vulcanize?  Normally we only think of typescript as getting compiled.","created_at":"2014-12-16T01:26:08Z","updated_at":"2014-12-16T01:26:08Z","html_url":"https://github.com/uProxy/uproxy/pull/689#discussion_r21872469","pull_request_url":"https://api.github.com/repos/uProxy/uproxy/pulls/689","_links":{"self":{"href":"https://api.github.com/repos/uProxy/uproxy/pulls/comments/21872469"},"html":{"href":"https://github.com/uProxy/uproxy/pull/689#discussion_r21872469"},"pull_request":{"href":"https://api.github.com/repos/uProxy/uproxy/pulls/689"}}},"pull_request":{"url":"https://api.github.com/repos/uProxy/uproxy/pulls/689","id":26091787,"html_url":"https://github.com/uProxy/uproxy/pull/689","diff_url":"https://github.com/uProxy/uproxy/pull/689.diff","patch_url":"https://github.com/uProxy/uproxy/pull/689.patch","issue_url":"https://api.github.com/repos/uProxy/uproxy/issues/689","number":689,"state":"open","locked":false,"title":"Vulcanize!","user":{"login":"ryscheng","id":566890,"avatar_url":"https://avatars.githubusercontent.com/u/566890?v=3","gravatar_id":"","url":"https://api.github.com/users/ryscheng","html_url":"https://github.com/ryscheng","followers_url":"https://api.github.com/users/ryscheng/followers","following_url":"https://api.github.com/users/ryscheng/following{/other_user}","gists_url":"https://api.github.com/users/ryscheng/gists{/gist_id}","starred_url":"https://api.github.com/users/ryscheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryscheng/subscriptions","organizations_url":"https://api.github.com/users/ryscheng/orgs","repos_url":"https://api.github.com/users/ryscheng/repos","events_url":"https://api.github.com/users/ryscheng/events{/privacy}","received_events_url":"https://api.github.com/users/ryscheng/received_events","type":"User","site_admin":false},"body":"Replacing the polymerPaperCompile custom task with grunt-vulcanize\r\nhttps://github.com/uProxy/uproxy/issues/686\r\n\r\nThe one part that may seem confusing is that we have to call vulcanize twice.\r\nOnce to inline everything into the HTML\r\nthen once to extract all inline JavaScript into a separate vulcanized.js\r\n\r\nIt seems to be a bug with vulcanize that it doesn't know how to deal with merging JavaScript files that are already separate from the component HTML.","created_at":"2014-12-15T18:51:11Z","updated_at":"2014-12-16T01:26:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6233b0bce6c624dc5fed3c078f3f204080d54245","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/uProxy/uproxy/pulls/689/commits","review_comments_url":"https://api.github.com/repos/uProxy/uproxy/pulls/689/comments","review_comment_url":"https://api.github.com/repos/uProxy/uproxy/pulls/comments/{number}","comments_url":"https://api.github.com/repos/uProxy/uproxy/issues/689/comments","statuses_url":"https://api.github.com/repos/uProxy/uproxy/statuses/24f1449e8370f928d923841e2eea400865d1d499","head":{"label":"uProxy:ryscheng-vulcanize","ref":"ryscheng-vulcanize","sha":"24f1449e8370f928d923841e2eea400865d1d499","user":{"login":"uProxy","id":6548286,"avatar_url":"https://avatars.githubusercontent.com/u/6548286?v=3","gravatar_id":"","url":"https://api.github.com/users/uProxy","html_url":"https://github.com/uProxy","followers_url":"https://api.github.com/users/uProxy/followers","following_url":"https://api.github.com/users/uProxy/following{/other_user}","gists_url":"https://api.github.com/users/uProxy/gists{/gist_id}","starred_url":"https://api.github.com/users/uProxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uProxy/subscriptions","organizations_url":"https://api.github.com/users/uProxy/orgs","repos_url":"https://api.github.com/users/uProxy/repos","events_url":"https://api.github.com/users/uProxy/events{/privacy}","received_events_url":"https://api.github.com/users/uProxy/received_events","type":"Organization","site_admin":false},"repo":{"id":18533350,"name":"uproxy","full_name":"uProxy/uproxy","owner":{"login":"uProxy","id":6548286,"avatar_url":"https://avatars.githubusercontent.com/u/6548286?v=3","gravatar_id":"","url":"https://api.github.com/users/uProxy","html_url":"https://github.com/uProxy","followers_url":"https://api.github.com/users/uProxy/followers","following_url":"https://api.github.com/users/uProxy/following{/other_user}","gists_url":"https://api.github.com/users/uProxy/gists{/gist_id}","starred_url":"https://api.github.com/users/uProxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uProxy/subscriptions","organizations_url":"https://api.github.com/users/uProxy/orgs","repos_url":"https://api.github.com/users/uProxy/repos","events_url":"https://api.github.com/users/uProxy/events{/privacy}","received_events_url":"https://api.github.com/users/uProxy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uProxy/uproxy","description":"Share your pathway to the Internet","fork":false,"url":"https://api.github.com/repos/uProxy/uproxy","forks_url":"https://api.github.com/repos/uProxy/uproxy/forks","keys_url":"https://api.github.com/repos/uProxy/uproxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uProxy/uproxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uProxy/uproxy/teams","hooks_url":"https://api.github.com/repos/uProxy/uproxy/hooks","issue_events_url":"https://api.github.com/repos/uProxy/uproxy/issues/events{/number}","events_url":"https://api.github.com/repos/uProxy/uproxy/events","assignees_url":"https://api.github.com/repos/uProxy/uproxy/assignees{/user}","branches_url":"https://api.github.com/repos/uProxy/uproxy/branches{/branch}","tags_url":"https://api.github.com/repos/uProxy/uproxy/tags","blobs_url":"https://api.github.com/repos/uProxy/uproxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uProxy/uproxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uProxy/uproxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/uProxy/uproxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uProxy/uproxy/statuses/{sha}","languages_url":"https://api.github.com/repos/uProxy/uproxy/languages","stargazers_url":"https://api.github.com/repos/uProxy/uproxy/stargazers","contributors_url":"https://api.github.com/repos/uProxy/uproxy/contributors","subscribers_url":"https://api.github.com/repos/uProxy/uproxy/subscribers","subscription_url":"https://api.github.com/repos/uProxy/uproxy/subscription","commits_url":"https://api.github.com/repos/uProxy/uproxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/uProxy/uproxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/uProxy/uproxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/uProxy/uproxy/issues/comments/{number}","contents_url":"https://api.github.com/repos/uProxy/uproxy/contents/{+path}","compare_url":"https://api.github.com/repos/uProxy/uproxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uProxy/uproxy/merges","archive_url":"https://api.github.com/repos/uProxy/uproxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uProxy/uproxy/downloads","issues_url":"https://api.github.com/repos/uProxy/uproxy/issues{/number}","pulls_url":"https://api.github.com/repos/uProxy/uproxy/pulls{/number}","milestones_url":"https://api.github.com/repos/uProxy/uproxy/milestones{/number}","notifications_url":"https://api.github.com/repos/uProxy/uproxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uProxy/uproxy/labels{/name}","releases_url":"https://api.github.com/repos/uProxy/uproxy/releases{/id}","created_at":"2014-04-07T20:34:40Z","updated_at":"2014-12-16T00:19:29Z","pushed_at":"2014-12-16T00:52:13Z","git_url":"git://github.com/uProxy/uproxy.git","ssh_url":"git@github.com:uProxy/uproxy.git","clone_url":"https://github.com/uProxy/uproxy.git","svn_url":"https://github.com/uProxy/uproxy","homepage":"https://www.uproxy.org/","size":15213,"stargazers_count":25,"watchers_count":25,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":244,"forks":5,"open_issues":244,"watchers":25,"default_branch":"dev"}},"base":{"label":"uProxy:dev","ref":"dev","sha":"49b15e0b9110e2c596e8f94e5f076ce5f0a3c60c","user":{"login":"uProxy","id":6548286,"avatar_url":"https://avatars.githubusercontent.com/u/6548286?v=3","gravatar_id":"","url":"https://api.github.com/users/uProxy","html_url":"https://github.com/uProxy","followers_url":"https://api.github.com/users/uProxy/followers","following_url":"https://api.github.com/users/uProxy/following{/other_user}","gists_url":"https://api.github.com/users/uProxy/gists{/gist_id}","starred_url":"https://api.github.com/users/uProxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uProxy/subscriptions","organizations_url":"https://api.github.com/users/uProxy/orgs","repos_url":"https://api.github.com/users/uProxy/repos","events_url":"https://api.github.com/users/uProxy/events{/privacy}","received_events_url":"https://api.github.com/users/uProxy/received_events","type":"Organization","site_admin":false},"repo":{"id":18533350,"name":"uproxy","full_name":"uProxy/uproxy","owner":{"login":"uProxy","id":6548286,"avatar_url":"https://avatars.githubusercontent.com/u/6548286?v=3","gravatar_id":"","url":"https://api.github.com/users/uProxy","html_url":"https://github.com/uProxy","followers_url":"https://api.github.com/users/uProxy/followers","following_url":"https://api.github.com/users/uProxy/following{/other_user}","gists_url":"https://api.github.com/users/uProxy/gists{/gist_id}","starred_url":"https://api.github.com/users/uProxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uProxy/subscriptions","organizations_url":"https://api.github.com/users/uProxy/orgs","repos_url":"https://api.github.com/users/uProxy/repos","events_url":"https://api.github.com/users/uProxy/events{/privacy}","received_events_url":"https://api.github.com/users/uProxy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uProxy/uproxy","description":"Share your pathway to the Internet","fork":false,"url":"https://api.github.com/repos/uProxy/uproxy","forks_url":"https://api.github.com/repos/uProxy/uproxy/forks","keys_url":"https://api.github.com/repos/uProxy/uproxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uProxy/uproxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uProxy/uproxy/teams","hooks_url":"https://api.github.com/repos/uProxy/uproxy/hooks","issue_events_url":"https://api.github.com/repos/uProxy/uproxy/issues/events{/number}","events_url":"https://api.github.com/repos/uProxy/uproxy/events","assignees_url":"https://api.github.com/repos/uProxy/uproxy/assignees{/user}","branches_url":"https://api.github.com/repos/uProxy/uproxy/branches{/branch}","tags_url":"https://api.github.com/repos/uProxy/uproxy/tags","blobs_url":"https://api.github.com/repos/uProxy/uproxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uProxy/uproxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uProxy/uproxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/uProxy/uproxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uProxy/uproxy/statuses/{sha}","languages_url":"https://api.github.com/repos/uProxy/uproxy/languages","stargazers_url":"https://api.github.com/repos/uProxy/uproxy/stargazers","contributors_url":"https://api.github.com/repos/uProxy/uproxy/contributors","subscribers_url":"https://api.github.com/repos/uProxy/uproxy/subscribers","subscription_url":"https://api.github.com/repos/uProxy/uproxy/subscription","commits_url":"https://api.github.com/repos/uProxy/uproxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/uProxy/uproxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/uProxy/uproxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/uProxy/uproxy/issues/comments/{number}","contents_url":"https://api.github.com/repos/uProxy/uproxy/contents/{+path}","compare_url":"https://api.github.com/repos/uProxy/uproxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uProxy/uproxy/merges","archive_url":"https://api.github.com/repos/uProxy/uproxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uProxy/uproxy/downloads","issues_url":"https://api.github.com/repos/uProxy/uproxy/issues{/number}","pulls_url":"https://api.github.com/repos/uProxy/uproxy/pulls{/number}","milestones_url":"https://api.github.com/repos/uProxy/uproxy/milestones{/number}","notifications_url":"https://api.github.com/repos/uProxy/uproxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uProxy/uproxy/labels{/name}","releases_url":"https://api.github.com/repos/uProxy/uproxy/releases{/id}","created_at":"2014-04-07T20:34:40Z","updated_at":"2014-12-16T00:19:29Z","pushed_at":"2014-12-16T00:52:13Z","git_url":"git://github.com/uProxy/uproxy.git","ssh_url":"git@github.com:uProxy/uproxy.git","clone_url":"https://github.com/uProxy/uproxy.git","svn_url":"https://github.com/uProxy/uproxy","homepage":"https://www.uproxy.org/","size":15213,"stargazers_count":25,"watchers_count":25,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":244,"forks":5,"open_issues":244,"watchers":25,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/uProxy/uproxy/pulls/689"},"html":{"href":"https://github.com/uProxy/uproxy/pull/689"},"issue":{"href":"https://api.github.com/repos/uProxy/uproxy/issues/689"},"comments":{"href":"https://api.github.com/repos/uProxy/uproxy/issues/689/comments"},"review_comments":{"href":"https://api.github.com/repos/uProxy/uproxy/pulls/689/comments"},"review_comment":{"href":"https://api.github.com/repos/uProxy/uproxy/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/uProxy/uproxy/pulls/689/commits"},"statuses":{"href":"https://api.github.com/repos/uProxy/uproxy/statuses/24f1449e8370f928d923841e2eea400865d1d499"}}}}