GitHub PullRequestEvent at 2014-07-07 17:50:01
Repository: zds-site
Actor: poulp
Payload: {"action":"opened","number":1082,"pull_request":{"url":"https://api.github.com/repos/zestedesavoir/zds-site/pulls/1082","id":18058445,"html_url":"https://github.com/zestedesavoir/zds-site/pull/1082","diff_url":"https://github.com/zestedesavoir/zds-site/pull/1082.diff","patch_url":"https://github.com/zestedesavoir/zds-site/pull/1082.patch","issue_url":"https://api.github.com/repos/zestedesavoir/zds-site/issues/1082","number":1082,"state":"open","title":"Ajout de tests pour les mp et correction de bugs","user":{"login":"poulp","id":819246,"avatar_url":"https://avatars.githubusercontent.com/u/819246?","gravatar_id":"05326d279bcb5743dabd0f911123a654","url":"https://api.github.com/users/poulp","html_url":"https://github.com/poulp","followers_url":"https://api.github.com/users/poulp/followers","following_url":"https://api.github.com/users/poulp/following{/other_user}","gists_url":"https://api.github.com/users/poulp/gists{/gist_id}","starred_url":"https://api.github.com/users/poulp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poulp/subscriptions","organizations_url":"https://api.github.com/users/poulp/orgs","repos_url":"https://api.github.com/users/poulp/repos","events_url":"https://api.github.com/users/poulp/events{/privacy}","received_events_url":"https://api.github.com/users/poulp/received_events","type":"User","site_admin":false},"body":"| Q                         | R\r\n| ------------------------- | -------------------------------------------\r\n| Correction de bugs ?      | oui\r\n| Nouvelle Fonctionnalité ? | non\r\n| Tickets concernés         | -\r\n\r\nMême architecture de tests que les galeries, quelques remarques (corrigées): \r\n\r\n * Dans les modèles : l'utilisation de la fonction `get_current_user` pose problème dans les tests, du coup je l'ai mise en paramètre optionel dans les méthodes concernées (pour pas poser de problème dans le code en général). Mais j'aimerais bien discuter de cette fonction, car je ne vois pas ce qu'elle apporte par rapport à un `request.user`.\r\n * Petit correction dans la méthode `first_unread_post`, un attribut qui n'existe pas ça fait pas du bien ;)\r\n * Il manque des vérifications de droits dans les contrôleurs : \r\n  * Suppression de n'importe quel mp\r\n  * On peut s'ajouter à une conversation privée\r\n  * Pas de vérification sur les droits de réponses (bon la on tombe sur une erreur 500)\r\n * Un utilisateur peut s'envoyer un mp tout seul\r\n\r\nVoila voila :)","created_at":"2014-07-07T17:50:00Z","updated_at":"2014-07-07T17:50:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/zestedesavoir/zds-site/pulls/1082/commits","review_comments_url":"https://api.github.com/repos/zestedesavoir/zds-site/pulls/1082/comments","review_comment_url":"https://api.github.com/repos/zestedesavoir/zds-site/pulls/comments/{number}","comments_url":"https://api.github.com/repos/zestedesavoir/zds-site/issues/1082/comments","statuses_url":"https://api.github.com/repos/zestedesavoir/zds-site/statuses/95a16b82654d9d076d8224b2fd9861b12b61f34b","head":{"label":"poulp:tests-mp","ref":"tests-mp","sha":"95a16b82654d9d076d8224b2fd9861b12b61f34b","user":{"login":"poulp","id":819246,"avatar_url":"https://avatars.githubusercontent.com/u/819246?","gravatar_id":"05326d279bcb5743dabd0f911123a654","url":"https://api.github.com/users/poulp","html_url":"https://github.com/poulp","followers_url":"https://api.github.com/users/poulp/followers","following_url":"https://api.github.com/users/poulp/following{/other_user}","gists_url":"https://api.github.com/users/poulp/gists{/gist_id}","starred_url":"https://api.github.com/users/poulp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poulp/subscriptions","organizations_url":"https://api.github.com/users/poulp/orgs","repos_url":"https://api.github.com/users/poulp/repos","events_url":"https://api.github.com/users/poulp/events{/privacy}","received_events_url":"https://api.github.com/users/poulp/received_events","type":"User","site_admin":false},"repo":{"id":20320659,"name":"zds-site","full_name":"poulp/zds-site","owner":{"login":"poulp","id":819246,"avatar_url":"https://avatars.githubusercontent.com/u/819246?","gravatar_id":"05326d279bcb5743dabd0f911123a654","url":"https://api.github.com/users/poulp","html_url":"https://github.com/poulp","followers_url":"https://api.github.com/users/poulp/followers","following_url":"https://api.github.com/users/poulp/following{/other_user}","gists_url":"https://api.github.com/users/poulp/gists{/gist_id}","starred_url":"https://api.github.com/users/poulp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poulp/subscriptions","organizations_url":"https://api.github.com/users/poulp/orgs","repos_url":"https://api.github.com/users/poulp/repos","events_url":"https://api.github.com/users/poulp/events{/privacy}","received_events_url":"https://api.github.com/users/poulp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/poulp/zds-site","description":"Dépot ZDS","fork":true,"url":"https://api.github.com/repos/poulp/zds-site","forks_url":"https://api.github.com/repos/poulp/zds-site/forks","keys_url":"https://api.github.com/repos/poulp/zds-site/keys{/key_id}","collaborators_url":"https://api.github.com/repos/poulp/zds-site/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/poulp/zds-site/teams","hooks_url":"https://api.github.com/repos/poulp/zds-site/hooks","issue_events_url":"https://api.github.com/repos/poulp/zds-site/issues/events{/number}","events_url":"https://api.github.com/repos/poulp/zds-site/events","assignees_url":"https://api.github.com/repos/poulp/zds-site/assignees{/user}","branches_url":"https://api.github.com/repos/poulp/zds-site/branches{/branch}","tags_url":"https://api.github.com/repos/poulp/zds-site/tags","blobs_url":"https://api.github.com/repos/poulp/zds-site/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/poulp/zds-site/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/poulp/zds-site/git/refs{/sha}","trees_url":"https://api.github.com/repos/poulp/zds-site/git/trees{/sha}","statuses_url":"https://api.github.com/repos/poulp/zds-site/statuses/{sha}","languages_url":"https://api.github.com/repos/poulp/zds-site/languages","stargazers_url":"https://api.github.com/repos/poulp/zds-site/stargazers","contributors_url":"https://api.github.com/repos/poulp/zds-site/contributors","subscribers_url":"https://api.github.com/repos/poulp/zds-site/subscribers","subscription_url":"https://api.github.com/repos/poulp/zds-site/subscription","commits_url":"https://api.github.com/repos/poulp/zds-site/commits{/sha}","git_commits_url":"https://api.github.com/repos/poulp/zds-site/git/commits{/sha}","comments_url":"https://api.github.com/repos/poulp/zds-site/comments{/number}","issue_comment_url":"https://api.github.com/repos/poulp/zds-site/issues/comments/{number}","contents_url":"https://api.github.com/repos/poulp/zds-site/contents/{+path}","compare_url":"https://api.github.com/repos/poulp/zds-site/compare/{base}...{head}","merges_url":"https://api.github.com/repos/poulp/zds-site/merges","archive_url":"https://api.github.com/repos/poulp/zds-site/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/poulp/zds-site/downloads","issues_url":"https://api.github.com/repos/poulp/zds-site/issues{/number}","pulls_url":"https://api.github.com/repos/poulp/zds-site/pulls{/number}","milestones_url":"https://api.github.com/repos/poulp/zds-site/milestones{/number}","notifications_url":"https://api.github.com/repos/poulp/zds-site/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/poulp/zds-site/labels{/name}","releases_url":"https://api.github.com/repos/poulp/zds-site/releases{/id}","created_at":"2014-05-30T07:25:11Z","updated_at":"2014-06-13T14:31:43Z","pushed_at":"2014-07-07T17:34:00Z","git_url":"git://github.com/poulp/zds-site.git","ssh_url":"git@github.com:poulp/zds-site.git","clone_url":"https://github.com/poulp/zds-site.git","svn_url":"https://github.com/poulp/zds-site","homepage":null,"size":37991,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"zestedesavoir:dev","ref":"dev","sha":"034ceaba6047fa5ac5bba066e1e482dd0802c967","user":{"login":"zestedesavoir","id":7406239,"avatar_url":"https://avatars.githubusercontent.com/u/7406239?","gravatar_id":null,"url":"https://api.github.com/users/zestedesavoir","html_url":"https://github.com/zestedesavoir","followers_url":"https://api.github.com/users/zestedesavoir/followers","following_url":"https://api.github.com/users/zestedesavoir/following{/other_user}","gists_url":"https://api.github.com/users/zestedesavoir/gists{/gist_id}","starred_url":"https://api.github.com/users/zestedesavoir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zestedesavoir/subscriptions","organizations_url":"https://api.github.com/users/zestedesavoir/orgs","repos_url":"https://api.github.com/users/zestedesavoir/repos","events_url":"https://api.github.com/users/zestedesavoir/events{/privacy}","received_events_url":"https://api.github.com/users/zestedesavoir/received_events","type":"Organization","site_admin":false},"repo":{"id":14778920,"name":"zds-site","full_name":"zestedesavoir/zds-site","owner":{"login":"zestedesavoir","id":7406239,"avatar_url":"https://avatars.githubusercontent.com/u/7406239?","gravatar_id":null,"url":"https://api.github.com/users/zestedesavoir","html_url":"https://github.com/zestedesavoir","followers_url":"https://api.github.com/users/zestedesavoir/followers","following_url":"https://api.github.com/users/zestedesavoir/following{/other_user}","gists_url":"https://api.github.com/users/zestedesavoir/gists{/gist_id}","starred_url":"https://api.github.com/users/zestedesavoir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zestedesavoir/subscriptions","organizations_url":"https://api.github.com/users/zestedesavoir/orgs","repos_url":"https://api.github.com/users/zestedesavoir/repos","events_url":"https://api.github.com/users/zestedesavoir/events{/privacy}","received_events_url":"https://api.github.com/users/zestedesavoir/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zestedesavoir/zds-site","description":"Dépot ZDS","fork":false,"url":"https://api.github.com/repos/zestedesavoir/zds-site","forks_url":"https://api.github.com/repos/zestedesavoir/zds-site/forks","keys_url":"https://api.github.com/repos/zestedesavoir/zds-site/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zestedesavoir/zds-site/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zestedesavoir/zds-site/teams","hooks_url":"https://api.github.com/repos/zestedesavoir/zds-site/hooks","issue_events_url":"https://api.github.com/repos/zestedesavoir/zds-site/issues/events{/number}","events_url":"https://api.github.com/repos/zestedesavoir/zds-site/events","assignees_url":"https://api.github.com/repos/zestedesavoir/zds-site/assignees{/user}","branches_url":"https://api.github.com/repos/zestedesavoir/zds-site/branches{/branch}","tags_url":"https://api.github.com/repos/zestedesavoir/zds-site/tags","blobs_url":"https://api.github.com/repos/zestedesavoir/zds-site/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zestedesavoir/zds-site/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zestedesavoir/zds-site/git/refs{/sha}","trees_url":"https://api.github.com/repos/zestedesavoir/zds-site/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zestedesavoir/zds-site/statuses/{sha}","languages_url":"https://api.github.com/repos/zestedesavoir/zds-site/languages","stargazers_url":"https://api.github.com/repos/zestedesavoir/zds-site/stargazers","contributors_url":"https://api.github.com/repos/zestedesavoir/zds-site/contributors","subscribers_url":"https://api.github.com/repos/zestedesavoir/zds-site/subscribers","subscription_url":"https://api.github.com/repos/zestedesavoir/zds-site/subscription","commits_url":"https://api.github.com/repos/zestedesavoir/zds-site/commits{/sha}","git_commits_url":"https://api.github.com/repos/zestedesavoir/zds-site/git/commits{/sha}","comments_url":"https://api.github.com/repos/zestedesavoir/zds-site/comments{/number}","issue_comment_url":"https://api.github.com/repos/zestedesavoir/zds-site/issues/comments/{number}","contents_url":"https://api.github.com/repos/zestedesavoir/zds-site/contents/{+path}","compare_url":"https://api.github.com/repos/zestedesavoir/zds-site/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zestedesavoir/zds-site/merges","archive_url":"https://api.github.com/repos/zestedesavoir/zds-site/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zestedesavoir/zds-site/downloads","issues_url":"https://api.github.com/repos/zestedesavoir/zds-site/issues{/number}","pulls_url":"https://api.github.com/repos/zestedesavoir/zds-site/pulls{/number}","milestones_url":"https://api.github.com/repos/zestedesavoir/zds-site/milestones{/number}","notifications_url":"https://api.github.com/repos/zestedesavoir/zds-site/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zestedesavoir/zds-site/labels{/name}","releases_url":"https://api.github.com/repos/zestedesavoir/zds-site/releases{/id}","created_at":"2013-11-28T14:23:48Z","updated_at":"2014-06-25T20:47:52Z","pushed_at":"2014-07-07T16:55:26Z","git_url":"git://github.com/zestedesavoir/zds-site.git","ssh_url":"git@github.com:zestedesavoir/zds-site.git","clone_url":"https://github.com/zestedesavoir/zds-site.git","svn_url":"https://github.com/zestedesavoir/zds-site","homepage":null,"size":120690,"stargazers_count":31,"watchers_count":31,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":30,"mirror_url":null,"open_issues_count":109,"forks":30,"open_issues":109,"watchers":31,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/zestedesavoir/zds-site/pulls/1082"},"html":{"href":"https://github.com/zestedesavoir/zds-site/pull/1082"},"issue":{"href":"https://api.github.com/repos/zestedesavoir/zds-site/issues/1082"},"comments":{"href":"https://api.github.com/repos/zestedesavoir/zds-site/issues/1082/comments"},"review_comments":{"href":"https://api.github.com/repos/zestedesavoir/zds-site/pulls/1082/comments"},"review_comment":{"href":"https://api.github.com/repos/zestedesavoir/zds-site/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/zestedesavoir/zds-site/pulls/1082/commits"},"statuses":{"href":"https://api.github.com/repos/zestedesavoir/zds-site/statuses/95a16b82654d9d076d8224b2fd9861b12b61f34b"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":11,"additions":1403,"deletions":320,"changed_files":7}}