GitHub PullRequestReviewCommentEvent at 2014-09-23 21:13:01
Repository: evans
Actor: skanev
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/skanev/evans/pulls/comments/17939763","id":17939763,"diff_hunk":"@@ -0,0 +1,62 @@\n+require 'spec_helper'\n+\n+describe ChallengeMailer do\n+  let(:challenge) { double 'challenge' }\n+\n+  describe '#new_challenge' do\n+    let(:mailer_delay) { double 'ChallengeMailer.delay' }\n+\n+    before do\n+      ChallengeMailer.stub(:delay) { mailer_delay }\n+    end\n+\n+    it 'sends multiple emails' do\n+      users = [\n+        create(:user, challenge_notification: true),\n+        create(:user, challenge_notification: true),\n+      ]\n+\n+      users.each do |user|","path":"spec/mailers/challenge_mailer_spec.rb","position":19,"original_position":19,"commit_id":"20a284f797a03b9057d29408ef023ddbff17435a","original_commit_id":"20a284f797a03b9057d29408ef023ddbff17435a","user":{"login":"skanev","id":10382,"avatar_url":"https://avatars.githubusercontent.com/u/10382?v=2","gravatar_id":"","url":"https://api.github.com/users/skanev","html_url":"https://github.com/skanev","followers_url":"https://api.github.com/users/skanev/followers","following_url":"https://api.github.com/users/skanev/following{/other_user}","gists_url":"https://api.github.com/users/skanev/gists{/gist_id}","starred_url":"https://api.github.com/users/skanev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skanev/subscriptions","organizations_url":"https://api.github.com/users/skanev/orgs","repos_url":"https://api.github.com/users/skanev/repos","events_url":"https://api.github.com/users/skanev/events{/privacy}","received_events_url":"https://api.github.com/users/skanev/received_events","type":"User","site_admin":false},"body":"Далеч не е същото, но:\r\n\r\nhttp://xunitpatterns.com/Conditional%20Test%20Logic.html\r\n\r\nАко прочетеш това и разбереш защо `if`-овете правят тестовете по-зле, ще разбереш и защо предпочитам (в този случай) праволинеен код пред цикли.","created_at":"2014-09-23T21:13:01Z","updated_at":"2014-09-23T21:13:01Z","html_url":"https://github.com/skanev/evans/pull/148#discussion_r17939763","pull_request_url":"https://api.github.com/repos/skanev/evans/pulls/148","_links":{"self":{"href":"https://api.github.com/repos/skanev/evans/pulls/comments/17939763"},"html":{"href":"https://github.com/skanev/evans/pull/148#discussion_r17939763"},"pull_request":{"href":"https://api.github.com/repos/skanev/evans/pulls/148"}}},"pull_request":{"url":"https://api.github.com/repos/skanev/evans/pulls/148","id":21668438,"html_url":"https://github.com/skanev/evans/pull/148","diff_url":"https://github.com/skanev/evans/pull/148.diff","patch_url":"https://github.com/skanev/evans/pull/148.patch","issue_url":"https://api.github.com/repos/skanev/evans/issues/148","number":148,"state":"open","locked":false,"title":"Add email notifications for tasks and challenges","user":{"login":"stormbreakerbg","id":756418,"avatar_url":"https://avatars.githubusercontent.com/u/756418?v=2","gravatar_id":"","url":"https://api.github.com/users/stormbreakerbg","html_url":"https://github.com/stormbreakerbg","followers_url":"https://api.github.com/users/stormbreakerbg/followers","following_url":"https://api.github.com/users/stormbreakerbg/following{/other_user}","gists_url":"https://api.github.com/users/stormbreakerbg/gists{/gist_id}","starred_url":"https://api.github.com/users/stormbreakerbg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stormbreakerbg/subscriptions","organizations_url":"https://api.github.com/users/stormbreakerbg/orgs","repos_url":"https://api.github.com/users/stormbreakerbg/repos","events_url":"https://api.github.com/users/stormbreakerbg/events{/privacy}","received_events_url":"https://api.github.com/users/stormbreakerbg/received_events","type":"User","site_admin":false},"body":"PR към #140 \r\n\r\nОчаквам коментари :)","created_at":"2014-09-23T19:06:41Z","updated_at":"2014-09-23T21:13:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"46b98671adf8387867e25be36b78608c76c21127","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/skanev/evans/pulls/148/commits","review_comments_url":"https://api.github.com/repos/skanev/evans/pulls/148/comments","review_comment_url":"https://api.github.com/repos/skanev/evans/pulls/comments/{number}","comments_url":"https://api.github.com/repos/skanev/evans/issues/148/comments","statuses_url":"https://api.github.com/repos/skanev/evans/statuses/20a284f797a03b9057d29408ef023ddbff17435a","head":{"label":"stormbreakerbg:email-notifications","ref":"email-notifications","sha":"20a284f797a03b9057d29408ef023ddbff17435a","user":{"login":"stormbreakerbg","id":756418,"avatar_url":"https://avatars.githubusercontent.com/u/756418?v=2","gravatar_id":"","url":"https://api.github.com/users/stormbreakerbg","html_url":"https://github.com/stormbreakerbg","followers_url":"https://api.github.com/users/stormbreakerbg/followers","following_url":"https://api.github.com/users/stormbreakerbg/following{/other_user}","gists_url":"https://api.github.com/users/stormbreakerbg/gists{/gist_id}","starred_url":"https://api.github.com/users/stormbreakerbg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stormbreakerbg/subscriptions","organizations_url":"https://api.github.com/users/stormbreakerbg/orgs","repos_url":"https://api.github.com/users/stormbreakerbg/repos","events_url":"https://api.github.com/users/stormbreakerbg/events{/privacy}","received_events_url":"https://api.github.com/users/stormbreakerbg/received_events","type":"User","site_admin":false},"repo":{"id":24385140,"name":"evans","full_name":"stormbreakerbg/evans","owner":{"login":"stormbreakerbg","id":756418,"avatar_url":"https://avatars.githubusercontent.com/u/756418?v=2","gravatar_id":"","url":"https://api.github.com/users/stormbreakerbg","html_url":"https://github.com/stormbreakerbg","followers_url":"https://api.github.com/users/stormbreakerbg/followers","following_url":"https://api.github.com/users/stormbreakerbg/following{/other_user}","gists_url":"https://api.github.com/users/stormbreakerbg/gists{/gist_id}","starred_url":"https://api.github.com/users/stormbreakerbg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stormbreakerbg/subscriptions","organizations_url":"https://api.github.com/users/stormbreakerbg/orgs","repos_url":"https://api.github.com/users/stormbreakerbg/repos","events_url":"https://api.github.com/users/stormbreakerbg/events{/privacy}","received_events_url":"https://api.github.com/users/stormbreakerbg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stormbreakerbg/evans","description":"The website of a bunch of courses in FMI","fork":true,"url":"https://api.github.com/repos/stormbreakerbg/evans","forks_url":"https://api.github.com/repos/stormbreakerbg/evans/forks","keys_url":"https://api.github.com/repos/stormbreakerbg/evans/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stormbreakerbg/evans/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stormbreakerbg/evans/teams","hooks_url":"https://api.github.com/repos/stormbreakerbg/evans/hooks","issue_events_url":"https://api.github.com/repos/stormbreakerbg/evans/issues/events{/number}","events_url":"https://api.github.com/repos/stormbreakerbg/evans/events","assignees_url":"https://api.github.com/repos/stormbreakerbg/evans/assignees{/user}","branches_url":"https://api.github.com/repos/stormbreakerbg/evans/branches{/branch}","tags_url":"https://api.github.com/repos/stormbreakerbg/evans/tags","blobs_url":"https://api.github.com/repos/stormbreakerbg/evans/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stormbreakerbg/evans/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stormbreakerbg/evans/git/refs{/sha}","trees_url":"https://api.github.com/repos/stormbreakerbg/evans/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stormbreakerbg/evans/statuses/{sha}","languages_url":"https://api.github.com/repos/stormbreakerbg/evans/languages","stargazers_url":"https://api.github.com/repos/stormbreakerbg/evans/stargazers","contributors_url":"https://api.github.com/repos/stormbreakerbg/evans/contributors","subscribers_url":"https://api.github.com/repos/stormbreakerbg/evans/subscribers","subscription_url":"https://api.github.com/repos/stormbreakerbg/evans/subscription","commits_url":"https://api.github.com/repos/stormbreakerbg/evans/commits{/sha}","git_commits_url":"https://api.github.com/repos/stormbreakerbg/evans/git/commits{/sha}","comments_url":"https://api.github.com/repos/stormbreakerbg/evans/comments{/number}","issue_comment_url":"https://api.github.com/repos/stormbreakerbg/evans/issues/comments/{number}","contents_url":"https://api.github.com/repos/stormbreakerbg/evans/contents/{+path}","compare_url":"https://api.github.com/repos/stormbreakerbg/evans/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stormbreakerbg/evans/merges","archive_url":"https://api.github.com/repos/stormbreakerbg/evans/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stormbreakerbg/evans/downloads","issues_url":"https://api.github.com/repos/stormbreakerbg/evans/issues{/number}","pulls_url":"https://api.github.com/repos/stormbreakerbg/evans/pulls{/number}","milestones_url":"https://api.github.com/repos/stormbreakerbg/evans/milestones{/number}","notifications_url":"https://api.github.com/repos/stormbreakerbg/evans/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stormbreakerbg/evans/labels{/name}","releases_url":"https://api.github.com/repos/stormbreakerbg/evans/releases{/id}","created_at":"2014-09-23T18:57:08Z","updated_at":"2014-05-19T22:09:03Z","pushed_at":"2014-09-23T19:11:30Z","git_url":"git://github.com/stormbreakerbg/evans.git","ssh_url":"git@github.com:stormbreakerbg/evans.git","clone_url":"https://github.com/stormbreakerbg/evans.git","svn_url":"https://github.com/stormbreakerbg/evans","homepage":"","size":6658,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"skanev:master","ref":"master","sha":"7d363210cd2117f50e60f82562e2e3addf1f79b8","user":{"login":"skanev","id":10382,"avatar_url":"https://avatars.githubusercontent.com/u/10382?v=2","gravatar_id":"","url":"https://api.github.com/users/skanev","html_url":"https://github.com/skanev","followers_url":"https://api.github.com/users/skanev/followers","following_url":"https://api.github.com/users/skanev/following{/other_user}","gists_url":"https://api.github.com/users/skanev/gists{/gist_id}","starred_url":"https://api.github.com/users/skanev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skanev/subscriptions","organizations_url":"https://api.github.com/users/skanev/orgs","repos_url":"https://api.github.com/users/skanev/repos","events_url":"https://api.github.com/users/skanev/events{/privacy}","received_events_url":"https://api.github.com/users/skanev/received_events","type":"User","site_admin":false},"repo":{"id":2505875,"name":"evans","full_name":"skanev/evans","owner":{"login":"skanev","id":10382,"avatar_url":"https://avatars.githubusercontent.com/u/10382?v=2","gravatar_id":"","url":"https://api.github.com/users/skanev","html_url":"https://github.com/skanev","followers_url":"https://api.github.com/users/skanev/followers","following_url":"https://api.github.com/users/skanev/following{/other_user}","gists_url":"https://api.github.com/users/skanev/gists{/gist_id}","starred_url":"https://api.github.com/users/skanev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skanev/subscriptions","organizations_url":"https://api.github.com/users/skanev/orgs","repos_url":"https://api.github.com/users/skanev/repos","events_url":"https://api.github.com/users/skanev/events{/privacy}","received_events_url":"https://api.github.com/users/skanev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/skanev/evans","description":"The website of a bunch of courses in FMI","fork":false,"url":"https://api.github.com/repos/skanev/evans","forks_url":"https://api.github.com/repos/skanev/evans/forks","keys_url":"https://api.github.com/repos/skanev/evans/keys{/key_id}","collaborators_url":"https://api.github.com/repos/skanev/evans/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/skanev/evans/teams","hooks_url":"https://api.github.com/repos/skanev/evans/hooks","issue_events_url":"https://api.github.com/repos/skanev/evans/issues/events{/number}","events_url":"https://api.github.com/repos/skanev/evans/events","assignees_url":"https://api.github.com/repos/skanev/evans/assignees{/user}","branches_url":"https://api.github.com/repos/skanev/evans/branches{/branch}","tags_url":"https://api.github.com/repos/skanev/evans/tags","blobs_url":"https://api.github.com/repos/skanev/evans/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/skanev/evans/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/skanev/evans/git/refs{/sha}","trees_url":"https://api.github.com/repos/skanev/evans/git/trees{/sha}","statuses_url":"https://api.github.com/repos/skanev/evans/statuses/{sha}","languages_url":"https://api.github.com/repos/skanev/evans/languages","stargazers_url":"https://api.github.com/repos/skanev/evans/stargazers","contributors_url":"https://api.github.com/repos/skanev/evans/contributors","subscribers_url":"https://api.github.com/repos/skanev/evans/subscribers","subscription_url":"https://api.github.com/repos/skanev/evans/subscription","commits_url":"https://api.github.com/repos/skanev/evans/commits{/sha}","git_commits_url":"https://api.github.com/repos/skanev/evans/git/commits{/sha}","comments_url":"https://api.github.com/repos/skanev/evans/comments{/number}","issue_comment_url":"https://api.github.com/repos/skanev/evans/issues/comments/{number}","contents_url":"https://api.github.com/repos/skanev/evans/contents/{+path}","compare_url":"https://api.github.com/repos/skanev/evans/compare/{base}...{head}","merges_url":"https://api.github.com/repos/skanev/evans/merges","archive_url":"https://api.github.com/repos/skanev/evans/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/skanev/evans/downloads","issues_url":"https://api.github.com/repos/skanev/evans/issues{/number}","pulls_url":"https://api.github.com/repos/skanev/evans/pulls{/number}","milestones_url":"https://api.github.com/repos/skanev/evans/milestones{/number}","notifications_url":"https://api.github.com/repos/skanev/evans/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/skanev/evans/labels{/name}","releases_url":"https://api.github.com/repos/skanev/evans/releases{/id}","created_at":"2011-10-03T16:28:26Z","updated_at":"2014-05-19T22:09:03Z","pushed_at":"2014-04-25T19:16:43Z","git_url":"git://github.com/skanev/evans.git","ssh_url":"git@github.com:skanev/evans.git","clone_url":"https://github.com/skanev/evans.git","svn_url":"https://github.com/skanev/evans","homepage":"","size":6658,"stargazers_count":32,"watchers_count":32,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"open_issues_count":42,"forks":23,"open_issues":42,"watchers":32,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/skanev/evans/pulls/148"},"html":{"href":"https://github.com/skanev/evans/pull/148"},"issue":{"href":"https://api.github.com/repos/skanev/evans/issues/148"},"comments":{"href":"https://api.github.com/repos/skanev/evans/issues/148/comments"},"review_comments":{"href":"https://api.github.com/repos/skanev/evans/pulls/148/comments"},"review_comment":{"href":"https://api.github.com/repos/skanev/evans/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/skanev/evans/pulls/148/commits"},"statuses":{"href":"https://api.github.com/repos/skanev/evans/statuses/20a284f797a03b9057d29408ef023ddbff17435a"}}}}