GitHub PullRequestReviewCommentEvent at 2014-10-06 17:42:10
Repository: Archimedes
Actor: jspahrsummers
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/github/Archimedes/pulls/comments/18471792","id":18471792,"diff_hunk":"@@ -553,294 +582,245 @@\n /* Begin XCBuildConfiguration section */\n \t\tD02FAEFD1635DDC1008D42D9 /* Debug */ = {\n \t\t\tisa = XCBuildConfiguration;\n-\t\t\tbaseConfigurationReference = D02FAF0C1635DE46008D42D9 /* Debug.xcconfig */;\n+\t\t\tbaseConfigurationReference = D038E04219DDC74A00ABCE67 /* Debug.xcconfig */;\n \t\t\tbuildSettings = {\n-\t\t\t\tIPHONEOS_DEPLOYMENT_TARGET = 5.1;\n-\t\t\t\tMACOSX_DEPLOYMENT_TARGET = 10.7;\n-\t\t\t\tOTHER_LDFLAGS = \"-ObjC\";\n+\t\t\t\tIPHONEOS_DEPLOYMENT_TARGET = 8.0;","path":"Archimedes.xcodeproj/project.pbxproj","position":785,"original_position":785,"commit_id":"1d04afb4c897a12b607eec4f94d4946f99da2c40","original_commit_id":"1d04afb4c897a12b607eec4f94d4946f99da2c40","user":{"login":"jspahrsummers","id":432536,"avatar_url":"https://avatars.githubusercontent.com/u/432536?v=2","gravatar_id":"","url":"https://api.github.com/users/jspahrsummers","html_url":"https://github.com/jspahrsummers","followers_url":"https://api.github.com/users/jspahrsummers/followers","following_url":"https://api.github.com/users/jspahrsummers/following{/other_user}","gists_url":"https://api.github.com/users/jspahrsummers/gists{/gist_id}","starred_url":"https://api.github.com/users/jspahrsummers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jspahrsummers/subscriptions","organizations_url":"https://api.github.com/users/jspahrsummers/orgs","repos_url":"https://api.github.com/users/jspahrsummers/repos","events_url":"https://api.github.com/users/jspahrsummers/events{/privacy}","received_events_url":"https://api.github.com/users/jspahrsummers/received_events","type":"User","site_admin":true},"body":"There's a lot of shittiness with dylibs and iOS 7 right now—mostly to do with Swift support, but I expect that most iOS developers just target the latest major version these days anyways, with how easy OTA updates are.","created_at":"2014-10-06T17:42:10Z","updated_at":"2014-10-06T17:42:10Z","html_url":"https://github.com/github/Archimedes/pull/33#discussion_r18471792","pull_request_url":"https://api.github.com/repos/github/Archimedes/pulls/33","_links":{"self":{"href":"https://api.github.com/repos/github/Archimedes/pulls/comments/18471792"},"html":{"href":"https://github.com/github/Archimedes/pull/33#discussion_r18471792"},"pull_request":{"href":"https://api.github.com/repos/github/Archimedes/pulls/33"}}},"pull_request":{"url":"https://api.github.com/repos/github/Archimedes/pulls/33","id":18484199,"html_url":"https://github.com/github/Archimedes/pull/33","diff_url":"https://github.com/github/Archimedes/pull/33.diff","patch_url":"https://github.com/github/Archimedes/pull/33.patch","issue_url":"https://api.github.com/repos/github/Archimedes/issues/33","number":33,"state":"open","locked":false,"title":"Xcode 6.1 support","user":{"login":"jspahrsummers","id":432536,"avatar_url":"https://avatars.githubusercontent.com/u/432536?v=2","gravatar_id":"","url":"https://api.github.com/users/jspahrsummers","html_url":"https://github.com/jspahrsummers","followers_url":"https://api.github.com/users/jspahrsummers/followers","following_url":"https://api.github.com/users/jspahrsummers/following{/other_user}","gists_url":"https://api.github.com/users/jspahrsummers/gists{/gist_id}","starred_url":"https://api.github.com/users/jspahrsummers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jspahrsummers/subscriptions","organizations_url":"https://api.github.com/users/jspahrsummers/orgs","repos_url":"https://api.github.com/users/jspahrsummers/repos","events_url":"https://api.github.com/users/jspahrsummers/events{/privacy}","received_events_url":"https://api.github.com/users/jspahrsummers/received_events","type":"User","site_admin":true},"body":"~~The unit tests don't currently build, because Specta/Expecta haven't yet been updated for Xcode 6.~~","created_at":"2014-07-16T18:01:09Z","updated_at":"2014-10-06T17:42:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9bd780333424ae5e701f94c2f0cc98683a9a1734","assignee":{"login":"alanjrogers","id":22635,"avatar_url":"https://avatars.githubusercontent.com/u/22635?v=2","gravatar_id":"","url":"https://api.github.com/users/alanjrogers","html_url":"https://github.com/alanjrogers","followers_url":"https://api.github.com/users/alanjrogers/followers","following_url":"https://api.github.com/users/alanjrogers/following{/other_user}","gists_url":"https://api.github.com/users/alanjrogers/gists{/gist_id}","starred_url":"https://api.github.com/users/alanjrogers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alanjrogers/subscriptions","organizations_url":"https://api.github.com/users/alanjrogers/orgs","repos_url":"https://api.github.com/users/alanjrogers/repos","events_url":"https://api.github.com/users/alanjrogers/events{/privacy}","received_events_url":"https://api.github.com/users/alanjrogers/received_events","type":"User","site_admin":true},"milestone":null,"commits_url":"https://api.github.com/repos/github/Archimedes/pulls/33/commits","review_comments_url":"https://api.github.com/repos/github/Archimedes/pulls/33/comments","review_comment_url":"https://api.github.com/repos/github/Archimedes/pulls/comments/{number}","comments_url":"https://api.github.com/repos/github/Archimedes/issues/33/comments","statuses_url":"https://api.github.com/repos/github/Archimedes/statuses/1d04afb4c897a12b607eec4f94d4946f99da2c40","head":{"label":"github:xcode6","ref":"xcode6","sha":"1d04afb4c897a12b607eec4f94d4946f99da2c40","user":{"login":"github","id":9919,"avatar_url":"https://avatars.githubusercontent.com/u/9919?v=2","gravatar_id":"","url":"https://api.github.com/users/github","html_url":"https://github.com/github","followers_url":"https://api.github.com/users/github/followers","following_url":"https://api.github.com/users/github/following{/other_user}","gists_url":"https://api.github.com/users/github/gists{/gist_id}","starred_url":"https://api.github.com/users/github/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/github/subscriptions","organizations_url":"https://api.github.com/users/github/orgs","repos_url":"https://api.github.com/users/github/repos","events_url":"https://api.github.com/users/github/events{/privacy}","received_events_url":"https://api.github.com/users/github/received_events","type":"Organization","site_admin":false},"repo":{"id":6341383,"name":"Archimedes","full_name":"github/Archimedes","owner":{"login":"github","id":9919,"avatar_url":"https://avatars.githubusercontent.com/u/9919?v=2","gravatar_id":"","url":"https://api.github.com/users/github","html_url":"https://github.com/github","followers_url":"https://api.github.com/users/github/followers","following_url":"https://api.github.com/users/github/following{/other_user}","gists_url":"https://api.github.com/users/github/gists{/gist_id}","starred_url":"https://api.github.com/users/github/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/github/subscriptions","organizations_url":"https://api.github.com/users/github/orgs","repos_url":"https://api.github.com/users/github/repos","events_url":"https://api.github.com/users/github/events{/privacy}","received_events_url":"https://api.github.com/users/github/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/github/Archimedes","description":"Geometry functions for Cocoa and Cocoa Touch","fork":false,"url":"https://api.github.com/repos/github/Archimedes","forks_url":"https://api.github.com/repos/github/Archimedes/forks","keys_url":"https://api.github.com/repos/github/Archimedes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/github/Archimedes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/github/Archimedes/teams","hooks_url":"https://api.github.com/repos/github/Archimedes/hooks","issue_events_url":"https://api.github.com/repos/github/Archimedes/issues/events{/number}","events_url":"https://api.github.com/repos/github/Archimedes/events","assignees_url":"https://api.github.com/repos/github/Archimedes/assignees{/user}","branches_url":"https://api.github.com/repos/github/Archimedes/branches{/branch}","tags_url":"https://api.github.com/repos/github/Archimedes/tags","blobs_url":"https://api.github.com/repos/github/Archimedes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/github/Archimedes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/github/Archimedes/git/refs{/sha}","trees_url":"https://api.github.com/repos/github/Archimedes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/github/Archimedes/statuses/{sha}","languages_url":"https://api.github.com/repos/github/Archimedes/languages","stargazers_url":"https://api.github.com/repos/github/Archimedes/stargazers","contributors_url":"https://api.github.com/repos/github/Archimedes/contributors","subscribers_url":"https://api.github.com/repos/github/Archimedes/subscribers","subscription_url":"https://api.github.com/repos/github/Archimedes/subscription","commits_url":"https://api.github.com/repos/github/Archimedes/commits{/sha}","git_commits_url":"https://api.github.com/repos/github/Archimedes/git/commits{/sha}","comments_url":"https://api.github.com/repos/github/Archimedes/comments{/number}","issue_comment_url":"https://api.github.com/repos/github/Archimedes/issues/comments/{number}","contents_url":"https://api.github.com/repos/github/Archimedes/contents/{+path}","compare_url":"https://api.github.com/repos/github/Archimedes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/github/Archimedes/merges","archive_url":"https://api.github.com/repos/github/Archimedes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/github/Archimedes/downloads","issues_url":"https://api.github.com/repos/github/Archimedes/issues{/number}","pulls_url":"https://api.github.com/repos/github/Archimedes/pulls{/number}","milestones_url":"https://api.github.com/repos/github/Archimedes/milestones{/number}","notifications_url":"https://api.github.com/repos/github/Archimedes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/github/Archimedes/labels{/name}","releases_url":"https://api.github.com/repos/github/Archimedes/releases{/id}","created_at":"2012-10-22T19:55:55Z","updated_at":"2014-10-05T23:15:01Z","pushed_at":"2014-10-03T21:05:46Z","git_url":"git://github.com/github/Archimedes.git","ssh_url":"git@github.com:github/Archimedes.git","clone_url":"https://github.com/github/Archimedes.git","svn_url":"https://github.com/github/Archimedes","homepage":null,"size":937,"stargazers_count":352,"watchers_count":352,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"open_issues_count":1,"forks":23,"open_issues":1,"watchers":352,"default_branch":"master"}},"base":{"label":"github:master","ref":"master","sha":"c79153cfecbe36cc42c6da9c651306995492a7a3","user":{"login":"github","id":9919,"avatar_url":"https://avatars.githubusercontent.com/u/9919?v=2","gravatar_id":"","url":"https://api.github.com/users/github","html_url":"https://github.com/github","followers_url":"https://api.github.com/users/github/followers","following_url":"https://api.github.com/users/github/following{/other_user}","gists_url":"https://api.github.com/users/github/gists{/gist_id}","starred_url":"https://api.github.com/users/github/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/github/subscriptions","organizations_url":"https://api.github.com/users/github/orgs","repos_url":"https://api.github.com/users/github/repos","events_url":"https://api.github.com/users/github/events{/privacy}","received_events_url":"https://api.github.com/users/github/received_events","type":"Organization","site_admin":false},"repo":{"id":6341383,"name":"Archimedes","full_name":"github/Archimedes","owner":{"login":"github","id":9919,"avatar_url":"https://avatars.githubusercontent.com/u/9919?v=2","gravatar_id":"","url":"https://api.github.com/users/github","html_url":"https://github.com/github","followers_url":"https://api.github.com/users/github/followers","following_url":"https://api.github.com/users/github/following{/other_user}","gists_url":"https://api.github.com/users/github/gists{/gist_id}","starred_url":"https://api.github.com/users/github/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/github/subscriptions","organizations_url":"https://api.github.com/users/github/orgs","repos_url":"https://api.github.com/users/github/repos","events_url":"https://api.github.com/users/github/events{/privacy}","received_events_url":"https://api.github.com/users/github/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/github/Archimedes","description":"Geometry functions for Cocoa and Cocoa Touch","fork":false,"url":"https://api.github.com/repos/github/Archimedes","forks_url":"https://api.github.com/repos/github/Archimedes/forks","keys_url":"https://api.github.com/repos/github/Archimedes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/github/Archimedes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/github/Archimedes/teams","hooks_url":"https://api.github.com/repos/github/Archimedes/hooks","issue_events_url":"https://api.github.com/repos/github/Archimedes/issues/events{/number}","events_url":"https://api.github.com/repos/github/Archimedes/events","assignees_url":"https://api.github.com/repos/github/Archimedes/assignees{/user}","branches_url":"https://api.github.com/repos/github/Archimedes/branches{/branch}","tags_url":"https://api.github.com/repos/github/Archimedes/tags","blobs_url":"https://api.github.com/repos/github/Archimedes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/github/Archimedes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/github/Archimedes/git/refs{/sha}","trees_url":"https://api.github.com/repos/github/Archimedes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/github/Archimedes/statuses/{sha}","languages_url":"https://api.github.com/repos/github/Archimedes/languages","stargazers_url":"https://api.github.com/repos/github/Archimedes/stargazers","contributors_url":"https://api.github.com/repos/github/Archimedes/contributors","subscribers_url":"https://api.github.com/repos/github/Archimedes/subscribers","subscription_url":"https://api.github.com/repos/github/Archimedes/subscription","commits_url":"https://api.github.com/repos/github/Archimedes/commits{/sha}","git_commits_url":"https://api.github.com/repos/github/Archimedes/git/commits{/sha}","comments_url":"https://api.github.com/repos/github/Archimedes/comments{/number}","issue_comment_url":"https://api.github.com/repos/github/Archimedes/issues/comments/{number}","contents_url":"https://api.github.com/repos/github/Archimedes/contents/{+path}","compare_url":"https://api.github.com/repos/github/Archimedes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/github/Archimedes/merges","archive_url":"https://api.github.com/repos/github/Archimedes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/github/Archimedes/downloads","issues_url":"https://api.github.com/repos/github/Archimedes/issues{/number}","pulls_url":"https://api.github.com/repos/github/Archimedes/pulls{/number}","milestones_url":"https://api.github.com/repos/github/Archimedes/milestones{/number}","notifications_url":"https://api.github.com/repos/github/Archimedes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/github/Archimedes/labels{/name}","releases_url":"https://api.github.com/repos/github/Archimedes/releases{/id}","created_at":"2012-10-22T19:55:55Z","updated_at":"2014-10-05T23:15:01Z","pushed_at":"2014-10-03T21:05:46Z","git_url":"git://github.com/github/Archimedes.git","ssh_url":"git@github.com:github/Archimedes.git","clone_url":"https://github.com/github/Archimedes.git","svn_url":"https://github.com/github/Archimedes","homepage":null,"size":937,"stargazers_count":352,"watchers_count":352,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"open_issues_count":1,"forks":23,"open_issues":1,"watchers":352,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/github/Archimedes/pulls/33"},"html":{"href":"https://github.com/github/Archimedes/pull/33"},"issue":{"href":"https://api.github.com/repos/github/Archimedes/issues/33"},"comments":{"href":"https://api.github.com/repos/github/Archimedes/issues/33/comments"},"review_comments":{"href":"https://api.github.com/repos/github/Archimedes/pulls/33/comments"},"review_comment":{"href":"https://api.github.com/repos/github/Archimedes/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/github/Archimedes/pulls/33/commits"},"statuses":{"href":"https://api.github.com/repos/github/Archimedes/statuses/1d04afb4c897a12b607eec4f94d4946f99da2c40"}}}}