GitHub PullRequestReviewCommentEvent at 2014-09-17 17:47:54
Repository: level_up_exercises
Actor: houndci
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/comments/17680790","id":17680790,"diff_hunk":"@@ -0,0 +1,93 @@\n+require 'csv'\n+require './dinosaur'\n+require './details'\n+require './alert'\n+\n+module DinosaurCSVParser\n+\n+  # Normalized Headers\n+  NORM_HEADERS = {\n+\n+    # File-Type I\n+    \"NAME\"          => \"Name\",\n+    \"PERIOD\"        => \"Period\",\n+    \"CONTINENT\"     => \"Continent\",\n+    \"DIET\"          => \"Diet\",\n+    \"WEIGHT_IN_LBS\" => \"Weight\",\n+    \"WALKING\"       => \"Walking\",\n+    \"DESCRIPTION\"   => \"Description\",\n+\n+    # File-Type II\n+    \"Genus\"     => \"Name\",\n+    \"Period\"    => \"Period\",\n+    \"Carnivore\" => \"Diet\",\n+    \"Weight\"    => \"Weight\",\n+    \"Walking\"   => \"Walking\",\n+  }\n+\n+  # Normalized Values\n+  NORM_VALUES = {\n+    [\"Diet\", \"Yes\"] => \"Carnivore\",\n+    [\"Diet\", \"No\" ] => \"Herbivore\",\n+  }\n+\n+  def DinosaurCSVParser.is_valid_file? filename\n+    File.exist?(filename) && File.file?(filename)\n+  end\n+\n+  def DinosaurCSVParser.is_valid_value? value","path":"dino_catalog/dinosaur_csv_parser.rb","position":38,"original_position":38,"commit_id":"f2ecdf4431f8d1774c27eb4900410c49876829bc","original_commit_id":"f2ecdf4431f8d1774c27eb4900410c49876829bc","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=2","gravatar_id":"38d9cefd9971a05bf447f07c6cd332cc","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Use `self.is_valid_value?` instead of `DinosaurCSVParser.is_valid_value?`.<br>Use def with parentheses when there are parameters.<br>Rename `is_valid_value?` to `valid_value?`.","created_at":"2014-09-17T17:47:54Z","updated_at":"2014-09-17T17:47:54Z","html_url":"https://github.com/jmmastey/level_up_exercises/pull/68#discussion_r17680790","pull_request_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/68","_links":{"self":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/comments/17680790"},"html":{"href":"https://github.com/jmmastey/level_up_exercises/pull/68#discussion_r17680790"},"pull_request":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/68"}}},"pull_request":{"url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/68","id":21383337,"html_url":"https://github.com/jmmastey/level_up_exercises/pull/68","diff_url":"https://github.com/jmmastey/level_up_exercises/pull/68.diff","patch_url":"https://github.com/jmmastey/level_up_exercises/pull/68.patch","issue_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/68","number":68,"state":"open","locked":false,"title":"Data-Science Code Review","user":{"login":"zsyed1","id":8593056,"avatar_url":"https://avatars.githubusercontent.com/u/8593056?v=2","gravatar_id":"f127d87c158266f599eea74d3151daac","url":"https://api.github.com/users/zsyed1","html_url":"https://github.com/zsyed1","followers_url":"https://api.github.com/users/zsyed1/followers","following_url":"https://api.github.com/users/zsyed1/following{/other_user}","gists_url":"https://api.github.com/users/zsyed1/gists{/gist_id}","starred_url":"https://api.github.com/users/zsyed1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zsyed1/subscriptions","organizations_url":"https://api.github.com/users/zsyed1/orgs","repos_url":"https://api.github.com/users/zsyed1/repos","events_url":"https://api.github.com/users/zsyed1/events{/privacy}","received_events_url":"https://api.github.com/users/zsyed1/received_events","type":"User","site_admin":false},"body":"Joe,\r\nI forked level_up_exercises and imported solutions that I had been placing in a different project. Going forward I will use this fork to submit pull-requests.\r\n\r\nZamir","created_at":"2014-09-17T17:47:37Z","updated_at":"2014-09-17T17:47:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"06901bd54ffda1d46a027d6a5ec8d7e1d377c89a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/68/commits","review_comments_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/68/comments","review_comment_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/comments/{number}","comments_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/68/comments","statuses_url":"https://api.github.com/repos/jmmastey/level_up_exercises/statuses/f2ecdf4431f8d1774c27eb4900410c49876829bc","head":{"label":"zsyed1:master","ref":"master","sha":"f2ecdf4431f8d1774c27eb4900410c49876829bc","user":{"login":"zsyed1","id":8593056,"avatar_url":"https://avatars.githubusercontent.com/u/8593056?v=2","gravatar_id":"f127d87c158266f599eea74d3151daac","url":"https://api.github.com/users/zsyed1","html_url":"https://github.com/zsyed1","followers_url":"https://api.github.com/users/zsyed1/followers","following_url":"https://api.github.com/users/zsyed1/following{/other_user}","gists_url":"https://api.github.com/users/zsyed1/gists{/gist_id}","starred_url":"https://api.github.com/users/zsyed1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zsyed1/subscriptions","organizations_url":"https://api.github.com/users/zsyed1/orgs","repos_url":"https://api.github.com/users/zsyed1/repos","events_url":"https://api.github.com/users/zsyed1/events{/privacy}","received_events_url":"https://api.github.com/users/zsyed1/received_events","type":"User","site_admin":false},"repo":{"id":24152202,"name":"level_up_exercises","full_name":"zsyed1/level_up_exercises","owner":{"login":"zsyed1","id":8593056,"avatar_url":"https://avatars.githubusercontent.com/u/8593056?v=2","gravatar_id":"f127d87c158266f599eea74d3151daac","url":"https://api.github.com/users/zsyed1","html_url":"https://github.com/zsyed1","followers_url":"https://api.github.com/users/zsyed1/followers","following_url":"https://api.github.com/users/zsyed1/following{/other_user}","gists_url":"https://api.github.com/users/zsyed1/gists{/gist_id}","starred_url":"https://api.github.com/users/zsyed1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zsyed1/subscriptions","organizations_url":"https://api.github.com/users/zsyed1/orgs","repos_url":"https://api.github.com/users/zsyed1/repos","events_url":"https://api.github.com/users/zsyed1/events{/privacy}","received_events_url":"https://api.github.com/users/zsyed1/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zsyed1/level_up_exercises","description":"A long series of code-related assignments to challenge starting engineers","fork":true,"url":"https://api.github.com/repos/zsyed1/level_up_exercises","forks_url":"https://api.github.com/repos/zsyed1/level_up_exercises/forks","keys_url":"https://api.github.com/repos/zsyed1/level_up_exercises/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zsyed1/level_up_exercises/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zsyed1/level_up_exercises/teams","hooks_url":"https://api.github.com/repos/zsyed1/level_up_exercises/hooks","issue_events_url":"https://api.github.com/repos/zsyed1/level_up_exercises/issues/events{/number}","events_url":"https://api.github.com/repos/zsyed1/level_up_exercises/events","assignees_url":"https://api.github.com/repos/zsyed1/level_up_exercises/assignees{/user}","branches_url":"https://api.github.com/repos/zsyed1/level_up_exercises/branches{/branch}","tags_url":"https://api.github.com/repos/zsyed1/level_up_exercises/tags","blobs_url":"https://api.github.com/repos/zsyed1/level_up_exercises/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zsyed1/level_up_exercises/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zsyed1/level_up_exercises/git/refs{/sha}","trees_url":"https://api.github.com/repos/zsyed1/level_up_exercises/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zsyed1/level_up_exercises/statuses/{sha}","languages_url":"https://api.github.com/repos/zsyed1/level_up_exercises/languages","stargazers_url":"https://api.github.com/repos/zsyed1/level_up_exercises/stargazers","contributors_url":"https://api.github.com/repos/zsyed1/level_up_exercises/contributors","subscribers_url":"https://api.github.com/repos/zsyed1/level_up_exercises/subscribers","subscription_url":"https://api.github.com/repos/zsyed1/level_up_exercises/subscription","commits_url":"https://api.github.com/repos/zsyed1/level_up_exercises/commits{/sha}","git_commits_url":"https://api.github.com/repos/zsyed1/level_up_exercises/git/commits{/sha}","comments_url":"https://api.github.com/repos/zsyed1/level_up_exercises/comments{/number}","issue_comment_url":"https://api.github.com/repos/zsyed1/level_up_exercises/issues/comments/{number}","contents_url":"https://api.github.com/repos/zsyed1/level_up_exercises/contents/{+path}","compare_url":"https://api.github.com/repos/zsyed1/level_up_exercises/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zsyed1/level_up_exercises/merges","archive_url":"https://api.github.com/repos/zsyed1/level_up_exercises/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zsyed1/level_up_exercises/downloads","issues_url":"https://api.github.com/repos/zsyed1/level_up_exercises/issues{/number}","pulls_url":"https://api.github.com/repos/zsyed1/level_up_exercises/pulls{/number}","milestones_url":"https://api.github.com/repos/zsyed1/level_up_exercises/milestones{/number}","notifications_url":"https://api.github.com/repos/zsyed1/level_up_exercises/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zsyed1/level_up_exercises/labels{/name}","releases_url":"https://api.github.com/repos/zsyed1/level_up_exercises/releases{/id}","created_at":"2014-09-17T16:09:35Z","updated_at":"2014-09-17T17:08:21Z","pushed_at":"2014-09-17T17:42:35Z","git_url":"git://github.com/zsyed1/level_up_exercises.git","ssh_url":"git@github.com:zsyed1/level_up_exercises.git","clone_url":"https://github.com/zsyed1/level_up_exercises.git","svn_url":"https://github.com/zsyed1/level_up_exercises","homepage":null,"size":4894,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jmmastey:master","ref":"master","sha":"c4d212ddf1ae69a2c0b0e6c2c9293281cd829000","user":{"login":"jmmastey","id":302011,"avatar_url":"https://avatars.githubusercontent.com/u/302011?v=2","gravatar_id":"a9704266587836f7e784235e5073b93e","url":"https://api.github.com/users/jmmastey","html_url":"https://github.com/jmmastey","followers_url":"https://api.github.com/users/jmmastey/followers","following_url":"https://api.github.com/users/jmmastey/following{/other_user}","gists_url":"https://api.github.com/users/jmmastey/gists{/gist_id}","starred_url":"https://api.github.com/users/jmmastey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmmastey/subscriptions","organizations_url":"https://api.github.com/users/jmmastey/orgs","repos_url":"https://api.github.com/users/jmmastey/repos","events_url":"https://api.github.com/users/jmmastey/events{/privacy}","received_events_url":"https://api.github.com/users/jmmastey/received_events","type":"User","site_admin":false},"repo":{"id":20705648,"name":"level_up_exercises","full_name":"jmmastey/level_up_exercises","owner":{"login":"jmmastey","id":302011,"avatar_url":"https://avatars.githubusercontent.com/u/302011?v=2","gravatar_id":"a9704266587836f7e784235e5073b93e","url":"https://api.github.com/users/jmmastey","html_url":"https://github.com/jmmastey","followers_url":"https://api.github.com/users/jmmastey/followers","following_url":"https://api.github.com/users/jmmastey/following{/other_user}","gists_url":"https://api.github.com/users/jmmastey/gists{/gist_id}","starred_url":"https://api.github.com/users/jmmastey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmmastey/subscriptions","organizations_url":"https://api.github.com/users/jmmastey/orgs","repos_url":"https://api.github.com/users/jmmastey/repos","events_url":"https://api.github.com/users/jmmastey/events{/privacy}","received_events_url":"https://api.github.com/users/jmmastey/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jmmastey/level_up_exercises","description":"A long series of code-related assignments to challenge starting engineers","fork":false,"url":"https://api.github.com/repos/jmmastey/level_up_exercises","forks_url":"https://api.github.com/repos/jmmastey/level_up_exercises/forks","keys_url":"https://api.github.com/repos/jmmastey/level_up_exercises/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jmmastey/level_up_exercises/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jmmastey/level_up_exercises/teams","hooks_url":"https://api.github.com/repos/jmmastey/level_up_exercises/hooks","issue_events_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/events{/number}","events_url":"https://api.github.com/repos/jmmastey/level_up_exercises/events","assignees_url":"https://api.github.com/repos/jmmastey/level_up_exercises/assignees{/user}","branches_url":"https://api.github.com/repos/jmmastey/level_up_exercises/branches{/branch}","tags_url":"https://api.github.com/repos/jmmastey/level_up_exercises/tags","blobs_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/refs{/sha}","trees_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jmmastey/level_up_exercises/statuses/{sha}","languages_url":"https://api.github.com/repos/jmmastey/level_up_exercises/languages","stargazers_url":"https://api.github.com/repos/jmmastey/level_up_exercises/stargazers","contributors_url":"https://api.github.com/repos/jmmastey/level_up_exercises/contributors","subscribers_url":"https://api.github.com/repos/jmmastey/level_up_exercises/subscribers","subscription_url":"https://api.github.com/repos/jmmastey/level_up_exercises/subscription","commits_url":"https://api.github.com/repos/jmmastey/level_up_exercises/commits{/sha}","git_commits_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/commits{/sha}","comments_url":"https://api.github.com/repos/jmmastey/level_up_exercises/comments{/number}","issue_comment_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/comments/{number}","contents_url":"https://api.github.com/repos/jmmastey/level_up_exercises/contents/{+path}","compare_url":"https://api.github.com/repos/jmmastey/level_up_exercises/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jmmastey/level_up_exercises/merges","archive_url":"https://api.github.com/repos/jmmastey/level_up_exercises/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jmmastey/level_up_exercises/downloads","issues_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues{/number}","pulls_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls{/number}","milestones_url":"https://api.github.com/repos/jmmastey/level_up_exercises/milestones{/number}","notifications_url":"https://api.github.com/repos/jmmastey/level_up_exercises/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jmmastey/level_up_exercises/labels{/name}","releases_url":"https://api.github.com/repos/jmmastey/level_up_exercises/releases{/id}","created_at":"2014-06-10T23:42:24Z","updated_at":"2014-09-02T21:41:48Z","pushed_at":"2014-09-13T15:01:49Z","git_url":"git://github.com/jmmastey/level_up_exercises.git","ssh_url":"git@github.com:jmmastey/level_up_exercises.git","clone_url":"https://github.com/jmmastey/level_up_exercises.git","svn_url":"https://github.com/jmmastey/level_up_exercises","homepage":null,"size":4894,"stargazers_count":7,"watchers_count":7,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":6,"forks":25,"open_issues":6,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/68"},"html":{"href":"https://github.com/jmmastey/level_up_exercises/pull/68"},"issue":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/68"},"comments":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/68/comments"},"review_comments":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/68/comments"},"review_comment":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/68/commits"},"statuses":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/statuses/f2ecdf4431f8d1774c27eb4900410c49876829bc"}}}}