GitHub PullRequestReviewCommentEvent at 2014-03-26 18:19:50
Repository: telemetry-dashboard
Actor: mreid-moz
Payload: {"comment":{"url":"https://api.github.com/repos/mozilla/telemetry-dashboard/pulls/comments/10990799","id":10990799,"diff_hunk":"@@ -257,12 +257,29 @@ function update(hgramEvo) {\n       hgramEvo.each(function(date, hgram) {\n         date = date.getTime();\n         if (!sanitizeData || hgram.submissions() >= submissionsCutoff) {\n-          means.push({x: date, y: hgram.mean()});\n-          p5.push({x: date, y: hgram.percentile(5)});\n-          p25.push({x: date, y: hgram.percentile(25)});\n-          p50.push({x: date, y: hgram.percentile(50)});\n-          p75.push({x: date, y: hgram.percentile(75)});\n-          p95.push({x: date, y: hgram.percentile(95)});\n+          var mean = hgram.mean();\n+          if (mean > 0)\n+            means.push({x: date, y: mean});","path":"src/dashboard.js","position":12,"original_position":12,"commit_id":"6d3c22d3bcc119671c3802f0a5c0051692e6027f","original_commit_id":"6d3c22d3bcc119671c3802f0a5c0051692e6027f","user":{"login":"mreid-moz","id":969479,"avatar_url":"https://avatars.githubusercontent.com/u/969479?","gravatar_id":"1f1f289cc67584d881d546354ee043b4","url":"https://api.github.com/users/mreid-moz","html_url":"https://github.com/mreid-moz","followers_url":"https://api.github.com/users/mreid-moz/followers","following_url":"https://api.github.com/users/mreid-moz/following{/other_user}","gists_url":"https://api.github.com/users/mreid-moz/gists{/gist_id}","starred_url":"https://api.github.com/users/mreid-moz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mreid-moz/subscriptions","organizations_url":"https://api.github.com/users/mreid-moz/orgs","repos_url":"https://api.github.com/users/mreid-moz/repos","events_url":"https://api.github.com/users/mreid-moz/events{/privacy}","received_events_url":"https://api.github.com/users/mreid-moz/received_events","type":"User","site_admin":false},"body":"Should make a function for this so we can call\r\npush_value(means, date, hgram.mean());\r\nInstead of repeating the logic for each item.\r\n\r\nOther than that, this seems like a reasonable way to handle negative values (though it should probably check for \">= 0\", since zero itself is acceptable, right?)","created_at":"2014-03-26T18:19:50Z","updated_at":"2014-03-26T18:19:50Z","html_url":"https://github.com/mozilla/telemetry-dashboard/pull/27#discussion_r10990799","pull_request_url":"https://api.github.com/repos/mozilla/telemetry-dashboard/pulls/27","_links":{"self":{"href":"https://api.github.com/repos/mozilla/telemetry-dashboard/pulls/comments/10990799"},"html":{"href":"https://github.com/mozilla/telemetry-dashboard/pull/27#discussion_r10990799"},"pull_request":{"href":"https://api.github.com/repos/mozilla/telemetry-dashboard/pulls/27"}}}}