GitHub PullRequestReviewCommentEvent at 2014-02-20 17:10:35
Repository: sbt-remote-control
Actor: jsuereth
Payload: {"comment":{"url":"https://api.github.com/repos/sbt/sbt-remote-control/pulls/comments/9914374","id":9914374,"diff_hunk":"@@ -74,6 +51,9 @@ abstract class ServerEngine {\n   // TODO - Maybe this should be its own command...\n   // TODO - Maybe this should be called cleanupLastCommand?\n   def postCommandCleanup(state: State): State = {\n+    // Make sure we update the reference to state for read-only\n+    // stuffs before handling our next request.\n+    nextStateRef.lazySet(state)","path":"server/src/main/scala/sbt/server/ServerEngine.scala","position":79,"original_position":79,"commit_id":"767262287a205c00cfa08fcec12adde5a16a9e98","original_commit_id":"38bb55b84364a0e28d3d317aebce48c5f1235fa6","user":{"login":"jsuereth","id":29006,"avatar_url":"https://gravatar.com/avatar/5ed293320c06809a24812f56861201ad?d=https%3A%2F%2Fidenticons.github.com%2F11a5b5ef81cff76a0a1f3d042f635df3.png&r=x","gravatar_id":"5ed293320c06809a24812f56861201ad","url":"https://api.github.com/users/jsuereth","html_url":"https://github.com/jsuereth","followers_url":"https://api.github.com/users/jsuereth/followers","following_url":"https://api.github.com/users/jsuereth/following{/other_user}","gists_url":"https://api.github.com/users/jsuereth/gists{/gist_id}","starred_url":"https://api.github.com/users/jsuereth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsuereth/subscriptions","organizations_url":"https://api.github.com/users/jsuereth/orgs","repos_url":"https://api.github.com/users/jsuereth/repos","events_url":"https://api.github.com/users/jsuereth/events{/privacy}","received_events_url":"https://api.github.com/users/jsuereth/received_events","type":"User","site_admin":false},"body":"No, `get`, by nature, forces the synchronization.  `lazySet` means I don't force synchronization on write.  Since i don't really care about synched writes (Always take latest), I let the `get` synchronize when it needs to.","created_at":"2014-02-20T17:10:35Z","updated_at":"2014-02-20T17:10:35Z","html_url":"https://github.com/sbt/sbt-remote-control/pull/69#discussion_r9914374","pull_request_url":"https://api.github.com/repos/sbt/sbt-remote-control/pulls/69","_links":{"self":{"href":"https://api.github.com/repos/sbt/sbt-remote-control/pulls/comments/9914374"},"html":{"href":"https://github.com/sbt/sbt-remote-control/pull/69#discussion_r9914374"},"pull_request":{"href":"https://api.github.com/repos/sbt/sbt-remote-control/pulls/69"}}}}