GitHub PullRequestReviewCommentEvent at 2014-07-07 11:28:20
Repository: scribe
Actor: theefer
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/guardian/scribe/pulls/comments/14591259","id":14591259,"diff_hunk":"@@ -4,7 +4,7 @@ BASE_DIR=$(dirname $0)\n \n if [ $# -ne 1 ];\n then\n-    echo \"Missing version argument\"\n+    echo \"Usage: ./release.sh [version-number]\"","path":"release.sh","position":5,"original_position":5,"commit_id":"9a33c0461adb04a2a47c9cd21e54b16bbb2fc5d3","original_commit_id":"9a33c0461adb04a2a47c9cd21e54b16bbb2fc5d3","user":{"login":"theefer","id":36964,"avatar_url":"https://avatars.githubusercontent.com/u/36964?","gravatar_id":"beea6c2e011b426ce59b6a0910f4354f","url":"https://api.github.com/users/theefer","html_url":"https://github.com/theefer","followers_url":"https://api.github.com/users/theefer/followers","following_url":"https://api.github.com/users/theefer/following{/other_user}","gists_url":"https://api.github.com/users/theefer/gists{/gist_id}","starred_url":"https://api.github.com/users/theefer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theefer/subscriptions","organizations_url":"https://api.github.com/users/theefer/orgs","repos_url":"https://api.github.com/users/theefer/repos","events_url":"https://api.github.com/users/theefer/events{/privacy}","received_events_url":"https://api.github.com/users/theefer/received_events","type":"User","site_admin":false},"body":"yep, usually `command <required-arg> [optional-arg]`","created_at":"2014-07-07T11:28:20Z","updated_at":"2014-07-07T11:28:20Z","html_url":"https://github.com/guardian/scribe/pull/226#discussion_r14591259","pull_request_url":"https://api.github.com/repos/guardian/scribe/pulls/226","_links":{"self":{"href":"https://api.github.com/repos/guardian/scribe/pulls/comments/14591259"},"html":{"href":"https://github.com/guardian/scribe/pull/226#discussion_r14591259"},"pull_request":{"href":"https://api.github.com/repos/guardian/scribe/pulls/226"}}},"pull_request":{"url":"https://api.github.com/repos/guardian/scribe/pulls/226","id":18036877,"html_url":"https://github.com/guardian/scribe/pull/226","diff_url":"https://github.com/guardian/scribe/pull/226.diff","patch_url":"https://github.com/guardian/scribe/pull/226.patch","issue_url":"https://api.github.com/repos/guardian/scribe/issues/226","number":226,"state":"closed","title":"Hg fix release script","user":{"login":"hmgibson23","id":1932367,"avatar_url":"https://avatars.githubusercontent.com/u/1932367?","gravatar_id":"4ae397ee422cb63a2a23cc61046ed0e7","url":"https://api.github.com/users/hmgibson23","html_url":"https://github.com/hmgibson23","followers_url":"https://api.github.com/users/hmgibson23/followers","following_url":"https://api.github.com/users/hmgibson23/following{/other_user}","gists_url":"https://api.github.com/users/hmgibson23/gists{/gist_id}","starred_url":"https://api.github.com/users/hmgibson23/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmgibson23/subscriptions","organizations_url":"https://api.github.com/users/hmgibson23/orgs","repos_url":"https://api.github.com/users/hmgibson23/repos","events_url":"https://api.github.com/users/hmgibson23/events{/privacy}","received_events_url":"https://api.github.com/users/hmgibson23/received_events","type":"User","site_admin":false},"body":"The release scrip should take exactly two arguments. I also rewrote the error message, personally I prefer a program just to print its usage if it's used incorrectly.","created_at":"2014-07-07T10:32:25Z","updated_at":"2014-07-07T11:28:20Z","closed_at":"2014-07-07T11:23:42Z","merged_at":"2014-07-07T11:23:42Z","merge_commit_sha":"28fbe3fc9d95145b4cf7a9cfaa592bcf7832d983","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/guardian/scribe/pulls/226/commits","review_comments_url":"https://api.github.com/repos/guardian/scribe/pulls/226/comments","review_comment_url":"https://api.github.com/repos/guardian/scribe/pulls/comments/{number}","comments_url":"https://api.github.com/repos/guardian/scribe/issues/226/comments","statuses_url":"https://api.github.com/repos/guardian/scribe/statuses/9a33c0461adb04a2a47c9cd21e54b16bbb2fc5d3","head":{"label":"guardian:hg-fix-release-script","ref":"hg-fix-release-script","sha":"9a33c0461adb04a2a47c9cd21e54b16bbb2fc5d3","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?","gravatar_id":"2ddf2e74b78084fcf451b3cdeb075e73","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":14298729,"name":"scribe","full_name":"guardian/scribe","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?","gravatar_id":"2ddf2e74b78084fcf451b3cdeb075e73","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/scribe","description":"A rich text editor framework for the web platform","fork":false,"url":"https://api.github.com/repos/guardian/scribe","forks_url":"https://api.github.com/repos/guardian/scribe/forks","keys_url":"https://api.github.com/repos/guardian/scribe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/scribe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/scribe/teams","hooks_url":"https://api.github.com/repos/guardian/scribe/hooks","issue_events_url":"https://api.github.com/repos/guardian/scribe/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/scribe/events","assignees_url":"https://api.github.com/repos/guardian/scribe/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/scribe/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/scribe/tags","blobs_url":"https://api.github.com/repos/guardian/scribe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/scribe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/scribe/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/scribe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/scribe/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/scribe/languages","stargazers_url":"https://api.github.com/repos/guardian/scribe/stargazers","contributors_url":"https://api.github.com/repos/guardian/scribe/contributors","subscribers_url":"https://api.github.com/repos/guardian/scribe/subscribers","subscription_url":"https://api.github.com/repos/guardian/scribe/subscription","commits_url":"https://api.github.com/repos/guardian/scribe/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/scribe/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/scribe/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/scribe/issues/comments/{number}","contents_url":"https://api.github.com/repos/guardian/scribe/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/scribe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/scribe/merges","archive_url":"https://api.github.com/repos/guardian/scribe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/scribe/downloads","issues_url":"https://api.github.com/repos/guardian/scribe/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/scribe/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/scribe/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/scribe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/scribe/labels{/name}","releases_url":"https://api.github.com/repos/guardian/scribe/releases{/id}","created_at":"2013-11-11T11:13:38Z","updated_at":"2014-07-07T04:09:38Z","pushed_at":"2014-07-07T11:23:42Z","git_url":"git://github.com/guardian/scribe.git","ssh_url":"git@github.com:guardian/scribe.git","clone_url":"https://github.com/guardian/scribe.git","svn_url":"https://github.com/guardian/scribe","homepage":"http://guardian.github.io/scribe/","size":7780,"stargazers_count":2663,"watchers_count":2663,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":120,"mirror_url":null,"open_issues_count":52,"forks":120,"open_issues":52,"watchers":2663,"default_branch":"master"}},"base":{"label":"guardian:master","ref":"master","sha":"e80c14b60eb80bd491e50a0dc57f7912bcf387e8","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?","gravatar_id":"2ddf2e74b78084fcf451b3cdeb075e73","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":14298729,"name":"scribe","full_name":"guardian/scribe","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?","gravatar_id":"2ddf2e74b78084fcf451b3cdeb075e73","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/scribe","description":"A rich text editor framework for the web platform","fork":false,"url":"https://api.github.com/repos/guardian/scribe","forks_url":"https://api.github.com/repos/guardian/scribe/forks","keys_url":"https://api.github.com/repos/guardian/scribe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/scribe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/scribe/teams","hooks_url":"https://api.github.com/repos/guardian/scribe/hooks","issue_events_url":"https://api.github.com/repos/guardian/scribe/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/scribe/events","assignees_url":"https://api.github.com/repos/guardian/scribe/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/scribe/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/scribe/tags","blobs_url":"https://api.github.com/repos/guardian/scribe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/scribe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/scribe/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/scribe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/scribe/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/scribe/languages","stargazers_url":"https://api.github.com/repos/guardian/scribe/stargazers","contributors_url":"https://api.github.com/repos/guardian/scribe/contributors","subscribers_url":"https://api.github.com/repos/guardian/scribe/subscribers","subscription_url":"https://api.github.com/repos/guardian/scribe/subscription","commits_url":"https://api.github.com/repos/guardian/scribe/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/scribe/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/scribe/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/scribe/issues/comments/{number}","contents_url":"https://api.github.com/repos/guardian/scribe/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/scribe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/scribe/merges","archive_url":"https://api.github.com/repos/guardian/scribe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/scribe/downloads","issues_url":"https://api.github.com/repos/guardian/scribe/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/scribe/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/scribe/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/scribe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/scribe/labels{/name}","releases_url":"https://api.github.com/repos/guardian/scribe/releases{/id}","created_at":"2013-11-11T11:13:38Z","updated_at":"2014-07-07T04:09:38Z","pushed_at":"2014-07-07T11:23:42Z","git_url":"git://github.com/guardian/scribe.git","ssh_url":"git@github.com:guardian/scribe.git","clone_url":"https://github.com/guardian/scribe.git","svn_url":"https://github.com/guardian/scribe","homepage":"http://guardian.github.io/scribe/","size":7780,"stargazers_count":2663,"watchers_count":2663,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":120,"mirror_url":null,"open_issues_count":52,"forks":120,"open_issues":52,"watchers":2663,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/guardian/scribe/pulls/226"},"html":{"href":"https://github.com/guardian/scribe/pull/226"},"issue":{"href":"https://api.github.com/repos/guardian/scribe/issues/226"},"comments":{"href":"https://api.github.com/repos/guardian/scribe/issues/226/comments"},"review_comments":{"href":"https://api.github.com/repos/guardian/scribe/pulls/226/comments"},"review_comment":{"href":"https://api.github.com/repos/guardian/scribe/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/guardian/scribe/pulls/226/commits"},"statuses":{"href":"https://api.github.com/repos/guardian/scribe/statuses/9a33c0461adb04a2a47c9cd21e54b16bbb2fc5d3"}}}}