GitHub PullRequestReviewCommentEvent at 2014-10-15 21:29:17
Repository: level_up_exercises
Actor: danvayn
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/comments/18924244","id":18924244,"diff_hunk":"@@ -0,0 +1,121 @@\n+require_relative 'json_loader'\n+require_relative 'dataset'\n+\n+describe \"BadDataset\" do\n+  let(:json) { JSONLoader.new('test_bad_data.json') }\n+  subject(:dataset) { Dataset.new(json.fetch_data) }","path":"data_science/dataset_spec.rb","position":6,"original_position":6,"commit_id":"8f98831429b06a93d04ba60dae5ea0ccfc2a7a87","original_commit_id":"8f98831429b06a93d04ba60dae5ea0ccfc2a7a87","user":{"login":"danvayn","id":4827548,"avatar_url":"https://avatars.githubusercontent.com/u/4827548?v=2","gravatar_id":"","url":"https://api.github.com/users/danvayn","html_url":"https://github.com/danvayn","followers_url":"https://api.github.com/users/danvayn/followers","following_url":"https://api.github.com/users/danvayn/following{/other_user}","gists_url":"https://api.github.com/users/danvayn/gists{/gist_id}","starred_url":"https://api.github.com/users/danvayn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danvayn/subscriptions","organizations_url":"https://api.github.com/users/danvayn/orgs","repos_url":"https://api.github.com/users/danvayn/repos","events_url":"https://api.github.com/users/danvayn/events{/privacy}","received_events_url":"https://api.github.com/users/danvayn/received_events","type":"User","site_admin":false},"body":"you might be misusing subject here. subject allows you to write more readable tests\r\n\r\nsee https://www.relishapp.com/rspec/rspec-core/v/2-8/docs/subject/explicit-subject\r\n\r\ni'd rather you use let instead and define subjects during your tests to keep your lines from going too far (and instead using expect(subject))","created_at":"2014-10-15T21:29:17Z","updated_at":"2014-10-15T21:29:17Z","html_url":"https://github.com/jmmastey/level_up_exercises/pull/153#discussion_r18924244","pull_request_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/153","_links":{"self":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/comments/18924244"},"html":{"href":"https://github.com/jmmastey/level_up_exercises/pull/153#discussion_r18924244"},"pull_request":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/153"}}},"pull_request":{"url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/153","id":22787967,"html_url":"https://github.com/jmmastey/level_up_exercises/pull/153","diff_url":"https://github.com/jmmastey/level_up_exercises/pull/153.diff","patch_url":"https://github.com/jmmastey/level_up_exercises/pull/153.patch","issue_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/153","number":153,"state":"open","locked":false,"title":"Data science 20141007 rc","user":{"login":"ryancowan","id":1890590,"avatar_url":"https://avatars.githubusercontent.com/u/1890590?v=2","gravatar_id":"","url":"https://api.github.com/users/ryancowan","html_url":"https://github.com/ryancowan","followers_url":"https://api.github.com/users/ryancowan/followers","following_url":"https://api.github.com/users/ryancowan/following{/other_user}","gists_url":"https://api.github.com/users/ryancowan/gists{/gist_id}","starred_url":"https://api.github.com/users/ryancowan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryancowan/subscriptions","organizations_url":"https://api.github.com/users/ryancowan/orgs","repos_url":"https://api.github.com/users/ryancowan/repos","events_url":"https://api.github.com/users/ryancowan/events{/privacy}","received_events_url":"https://api.github.com/users/ryancowan/received_events","type":"User","site_admin":false},"body":"Revisions based on Pull Request: https://github.com/jmmastey/level_up_exercises/pull/150\r\n\r\n-clean up errors with main file\r\n-add test_no_winner json data and tests\r\n-convert main.rb into a Results class which takes the calculations from Dataset and wraps in some nice output\r\n-using Hirb gem to format the console output","created_at":"2014-10-15T14:39:34Z","updated_at":"2014-10-15T21:29:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e18756b0a601bfdbb59fdb058969e8c52fb38bcf","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/153/commits","review_comments_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/153/comments","review_comment_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/comments/{number}","comments_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/153/comments","statuses_url":"https://api.github.com/repos/jmmastey/level_up_exercises/statuses/8f98831429b06a93d04ba60dae5ea0ccfc2a7a87","head":{"label":"ryancowan:data_science_20141007_rc","ref":"data_science_20141007_rc","sha":"8f98831429b06a93d04ba60dae5ea0ccfc2a7a87","user":{"login":"ryancowan","id":1890590,"avatar_url":"https://avatars.githubusercontent.com/u/1890590?v=2","gravatar_id":"","url":"https://api.github.com/users/ryancowan","html_url":"https://github.com/ryancowan","followers_url":"https://api.github.com/users/ryancowan/followers","following_url":"https://api.github.com/users/ryancowan/following{/other_user}","gists_url":"https://api.github.com/users/ryancowan/gists{/gist_id}","starred_url":"https://api.github.com/users/ryancowan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryancowan/subscriptions","organizations_url":"https://api.github.com/users/ryancowan/orgs","repos_url":"https://api.github.com/users/ryancowan/repos","events_url":"https://api.github.com/users/ryancowan/events{/privacy}","received_events_url":"https://api.github.com/users/ryancowan/received_events","type":"User","site_admin":false},"repo":{"id":24423001,"name":"level_up_exercises","full_name":"ryancowan/level_up_exercises","owner":{"login":"ryancowan","id":1890590,"avatar_url":"https://avatars.githubusercontent.com/u/1890590?v=2","gravatar_id":"","url":"https://api.github.com/users/ryancowan","html_url":"https://github.com/ryancowan","followers_url":"https://api.github.com/users/ryancowan/followers","following_url":"https://api.github.com/users/ryancowan/following{/other_user}","gists_url":"https://api.github.com/users/ryancowan/gists{/gist_id}","starred_url":"https://api.github.com/users/ryancowan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryancowan/subscriptions","organizations_url":"https://api.github.com/users/ryancowan/orgs","repos_url":"https://api.github.com/users/ryancowan/repos","events_url":"https://api.github.com/users/ryancowan/events{/privacy}","received_events_url":"https://api.github.com/users/ryancowan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ryancowan/level_up_exercises","description":"A long series of code-related assignments to challenge starting engineers","fork":true,"url":"https://api.github.com/repos/ryancowan/level_up_exercises","forks_url":"https://api.github.com/repos/ryancowan/level_up_exercises/forks","keys_url":"https://api.github.com/repos/ryancowan/level_up_exercises/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ryancowan/level_up_exercises/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ryancowan/level_up_exercises/teams","hooks_url":"https://api.github.com/repos/ryancowan/level_up_exercises/hooks","issue_events_url":"https://api.github.com/repos/ryancowan/level_up_exercises/issues/events{/number}","events_url":"https://api.github.com/repos/ryancowan/level_up_exercises/events","assignees_url":"https://api.github.com/repos/ryancowan/level_up_exercises/assignees{/user}","branches_url":"https://api.github.com/repos/ryancowan/level_up_exercises/branches{/branch}","tags_url":"https://api.github.com/repos/ryancowan/level_up_exercises/tags","blobs_url":"https://api.github.com/repos/ryancowan/level_up_exercises/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ryancowan/level_up_exercises/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ryancowan/level_up_exercises/git/refs{/sha}","trees_url":"https://api.github.com/repos/ryancowan/level_up_exercises/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ryancowan/level_up_exercises/statuses/{sha}","languages_url":"https://api.github.com/repos/ryancowan/level_up_exercises/languages","stargazers_url":"https://api.github.com/repos/ryancowan/level_up_exercises/stargazers","contributors_url":"https://api.github.com/repos/ryancowan/level_up_exercises/contributors","subscribers_url":"https://api.github.com/repos/ryancowan/level_up_exercises/subscribers","subscription_url":"https://api.github.com/repos/ryancowan/level_up_exercises/subscription","commits_url":"https://api.github.com/repos/ryancowan/level_up_exercises/commits{/sha}","git_commits_url":"https://api.github.com/repos/ryancowan/level_up_exercises/git/commits{/sha}","comments_url":"https://api.github.com/repos/ryancowan/level_up_exercises/comments{/number}","issue_comment_url":"https://api.github.com/repos/ryancowan/level_up_exercises/issues/comments/{number}","contents_url":"https://api.github.com/repos/ryancowan/level_up_exercises/contents/{+path}","compare_url":"https://api.github.com/repos/ryancowan/level_up_exercises/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ryancowan/level_up_exercises/merges","archive_url":"https://api.github.com/repos/ryancowan/level_up_exercises/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ryancowan/level_up_exercises/downloads","issues_url":"https://api.github.com/repos/ryancowan/level_up_exercises/issues{/number}","pulls_url":"https://api.github.com/repos/ryancowan/level_up_exercises/pulls{/number}","milestones_url":"https://api.github.com/repos/ryancowan/level_up_exercises/milestones{/number}","notifications_url":"https://api.github.com/repos/ryancowan/level_up_exercises/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ryancowan/level_up_exercises/labels{/name}","releases_url":"https://api.github.com/repos/ryancowan/level_up_exercises/releases{/id}","created_at":"2014-09-24T16:30:44Z","updated_at":"2014-09-02T21:41:48Z","pushed_at":"2014-10-15T21:07:37Z","git_url":"git://github.com/ryancowan/level_up_exercises.git","ssh_url":"git@github.com:ryancowan/level_up_exercises.git","clone_url":"https://github.com/ryancowan/level_up_exercises.git","svn_url":"https://github.com/ryancowan/level_up_exercises","homepage":null,"size":684,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jmmastey:master","ref":"master","sha":"512a604443c0f6ec75a3205e144bb2114a07308d","user":{"login":"jmmastey","id":302011,"avatar_url":"https://avatars.githubusercontent.com/u/302011?v=2","gravatar_id":"","url":"https://api.github.com/users/jmmastey","html_url":"https://github.com/jmmastey","followers_url":"https://api.github.com/users/jmmastey/followers","following_url":"https://api.github.com/users/jmmastey/following{/other_user}","gists_url":"https://api.github.com/users/jmmastey/gists{/gist_id}","starred_url":"https://api.github.com/users/jmmastey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmmastey/subscriptions","organizations_url":"https://api.github.com/users/jmmastey/orgs","repos_url":"https://api.github.com/users/jmmastey/repos","events_url":"https://api.github.com/users/jmmastey/events{/privacy}","received_events_url":"https://api.github.com/users/jmmastey/received_events","type":"User","site_admin":false},"repo":{"id":20705648,"name":"level_up_exercises","full_name":"jmmastey/level_up_exercises","owner":{"login":"jmmastey","id":302011,"avatar_url":"https://avatars.githubusercontent.com/u/302011?v=2","gravatar_id":"","url":"https://api.github.com/users/jmmastey","html_url":"https://github.com/jmmastey","followers_url":"https://api.github.com/users/jmmastey/followers","following_url":"https://api.github.com/users/jmmastey/following{/other_user}","gists_url":"https://api.github.com/users/jmmastey/gists{/gist_id}","starred_url":"https://api.github.com/users/jmmastey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmmastey/subscriptions","organizations_url":"https://api.github.com/users/jmmastey/orgs","repos_url":"https://api.github.com/users/jmmastey/repos","events_url":"https://api.github.com/users/jmmastey/events{/privacy}","received_events_url":"https://api.github.com/users/jmmastey/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jmmastey/level_up_exercises","description":"A series of code-related assignments to challenge starting engineers","fork":false,"url":"https://api.github.com/repos/jmmastey/level_up_exercises","forks_url":"https://api.github.com/repos/jmmastey/level_up_exercises/forks","keys_url":"https://api.github.com/repos/jmmastey/level_up_exercises/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jmmastey/level_up_exercises/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jmmastey/level_up_exercises/teams","hooks_url":"https://api.github.com/repos/jmmastey/level_up_exercises/hooks","issue_events_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/events{/number}","events_url":"https://api.github.com/repos/jmmastey/level_up_exercises/events","assignees_url":"https://api.github.com/repos/jmmastey/level_up_exercises/assignees{/user}","branches_url":"https://api.github.com/repos/jmmastey/level_up_exercises/branches{/branch}","tags_url":"https://api.github.com/repos/jmmastey/level_up_exercises/tags","blobs_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/refs{/sha}","trees_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jmmastey/level_up_exercises/statuses/{sha}","languages_url":"https://api.github.com/repos/jmmastey/level_up_exercises/languages","stargazers_url":"https://api.github.com/repos/jmmastey/level_up_exercises/stargazers","contributors_url":"https://api.github.com/repos/jmmastey/level_up_exercises/contributors","subscribers_url":"https://api.github.com/repos/jmmastey/level_up_exercises/subscribers","subscription_url":"https://api.github.com/repos/jmmastey/level_up_exercises/subscription","commits_url":"https://api.github.com/repos/jmmastey/level_up_exercises/commits{/sha}","git_commits_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/commits{/sha}","comments_url":"https://api.github.com/repos/jmmastey/level_up_exercises/comments{/number}","issue_comment_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/comments/{number}","contents_url":"https://api.github.com/repos/jmmastey/level_up_exercises/contents/{+path}","compare_url":"https://api.github.com/repos/jmmastey/level_up_exercises/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jmmastey/level_up_exercises/merges","archive_url":"https://api.github.com/repos/jmmastey/level_up_exercises/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jmmastey/level_up_exercises/downloads","issues_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues{/number}","pulls_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls{/number}","milestones_url":"https://api.github.com/repos/jmmastey/level_up_exercises/milestones{/number}","notifications_url":"https://api.github.com/repos/jmmastey/level_up_exercises/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jmmastey/level_up_exercises/labels{/name}","releases_url":"https://api.github.com/repos/jmmastey/level_up_exercises/releases{/id}","created_at":"2014-06-10T23:42:24Z","updated_at":"2014-10-09T06:13:13Z","pushed_at":"2014-10-06T15:43:40Z","git_url":"git://github.com/jmmastey/level_up_exercises.git","ssh_url":"git@github.com:jmmastey/level_up_exercises.git","clone_url":"https://github.com/jmmastey/level_up_exercises.git","svn_url":"https://github.com/jmmastey/level_up_exercises","homepage":"http://leveluprails.herokuapp.com","size":9006,"stargazers_count":9,"watchers_count":9,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":37,"mirror_url":null,"open_issues_count":8,"forks":37,"open_issues":8,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/153"},"html":{"href":"https://github.com/jmmastey/level_up_exercises/pull/153"},"issue":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/153"},"comments":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/153/comments"},"review_comments":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/153/comments"},"review_comment":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/153/commits"},"statuses":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/statuses/8f98831429b06a93d04ba60dae5ea0ccfc2a7a87"}}}}