GitHub PullRequestReviewCommentEvent at 2014-11-12 22:17:45
Repository: timesketch
Actor: 2xyo
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/google/timesketch/pulls/comments/20256532","id":20256532,"diff_hunk":"@@ -18,7 +18,8 @@\n \n \n def generate_secret_key():\n-    allowed_chars = string.letters + string.digits + string.punctuation\n+    allowed_chars = string.letters + string.digits + \\\n+        string.punctuation.replace(\"'\", \"\")","path":"utils/gen_secret_key.py","position":6,"original_position":6,"commit_id":"73ee92871ab085c41bf9418f146696a20a46c4cc","original_commit_id":"73ee92871ab085c41bf9418f146696a20a46c4cc","user":{"login":"2xyo","id":31675,"avatar_url":"https://avatars.githubusercontent.com/u/31675?v=3","gravatar_id":"","url":"https://api.github.com/users/2xyo","html_url":"https://github.com/2xyo","followers_url":"https://api.github.com/users/2xyo/followers","following_url":"https://api.github.com/users/2xyo/following{/other_user}","gists_url":"https://api.github.com/users/2xyo/gists{/gist_id}","starred_url":"https://api.github.com/users/2xyo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/2xyo/subscriptions","organizations_url":"https://api.github.com/users/2xyo/orgs","repos_url":"https://api.github.com/users/2xyo/repos","events_url":"https://api.github.com/users/2xyo/events{/privacy}","received_events_url":"https://api.github.com/users/2xyo/received_events","type":"User","site_admin":false},"body":"No, I really want to remove the [apostrophe](http://en.wikipedia.org/wiki/Apostrophe) ('). \r\n\r\n```\r\n>>> SECRET_KEY = 'backtick(`)'\r\nSECRET_KEY works fine with backtick :)\r\n\r\n>>> SECRET_KEY = 'apostrophe(')'\r\n  File \"<stdin>\", line 1\r\n    SECRET_KEY = 'apostrophe(')'\r\n                              ^\r\nSyntaxError: invalid syntax\r\n```","created_at":"2014-11-12T22:17:45Z","updated_at":"2014-11-12T22:17:45Z","html_url":"https://github.com/google/timesketch/pull/32#discussion_r20256532","pull_request_url":"https://api.github.com/repos/google/timesketch/pulls/32","_links":{"self":{"href":"https://api.github.com/repos/google/timesketch/pulls/comments/20256532"},"html":{"href":"https://github.com/google/timesketch/pull/32#discussion_r20256532"},"pull_request":{"href":"https://api.github.com/repos/google/timesketch/pulls/32"}}},"pull_request":{"url":"https://api.github.com/repos/google/timesketch/pulls/32","id":24227357,"html_url":"https://github.com/google/timesketch/pull/32","diff_url":"https://github.com/google/timesketch/pull/32.diff","patch_url":"https://github.com/google/timesketch/pull/32.patch","issue_url":"https://api.github.com/repos/google/timesketch/issues/32","number":32,"state":"open","locked":false,"title":"Remove apostrophe from random chars","user":{"login":"2xyo","id":31675,"avatar_url":"https://avatars.githubusercontent.com/u/31675?v=3","gravatar_id":"","url":"https://api.github.com/users/2xyo","html_url":"https://github.com/2xyo","followers_url":"https://api.github.com/users/2xyo/followers","following_url":"https://api.github.com/users/2xyo/following{/other_user}","gists_url":"https://api.github.com/users/2xyo/gists{/gist_id}","starred_url":"https://api.github.com/users/2xyo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/2xyo/subscriptions","organizations_url":"https://api.github.com/users/2xyo/orgs","repos_url":"https://api.github.com/users/2xyo/repos","events_url":"https://api.github.com/users/2xyo/events{/privacy}","received_events_url":"https://api.github.com/users/2xyo/received_events","type":"User","site_admin":false},"body":"A naive copy/paste of the random string can generate a syntax error because of the apostrophe. \r\n```\r\nTraceback (most recent call last):\r\n  File \"manage.py\", line 24, in <module>\r\n...\r\n  File \"/opt/apps/timesketch/timesketch/settings.py\", line 102\r\n    SECRET_KEY = 'Kqg'1Z%v`_(J(cMw7?^B+6.IUGY=G>:D9kG;DZwL2-7BH5qwo'\r\n\r\nSyntaxError: invalid syntax\r\n```","created_at":"2014-11-11T15:41:23Z","updated_at":"2014-11-12T22:17:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4d1c018f309f34150eac2aad62b5c181b182b499","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/google/timesketch/pulls/32/commits","review_comments_url":"https://api.github.com/repos/google/timesketch/pulls/32/comments","review_comment_url":"https://api.github.com/repos/google/timesketch/pulls/comments/{number}","comments_url":"https://api.github.com/repos/google/timesketch/issues/32/comments","statuses_url":"https://api.github.com/repos/google/timesketch/statuses/73ee92871ab085c41bf9418f146696a20a46c4cc","head":{"label":"2xyo:random","ref":"random","sha":"73ee92871ab085c41bf9418f146696a20a46c4cc","user":{"login":"2xyo","id":31675,"avatar_url":"https://avatars.githubusercontent.com/u/31675?v=3","gravatar_id":"","url":"https://api.github.com/users/2xyo","html_url":"https://github.com/2xyo","followers_url":"https://api.github.com/users/2xyo/followers","following_url":"https://api.github.com/users/2xyo/following{/other_user}","gists_url":"https://api.github.com/users/2xyo/gists{/gist_id}","starred_url":"https://api.github.com/users/2xyo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/2xyo/subscriptions","organizations_url":"https://api.github.com/users/2xyo/orgs","repos_url":"https://api.github.com/users/2xyo/repos","events_url":"https://api.github.com/users/2xyo/events{/privacy}","received_events_url":"https://api.github.com/users/2xyo/received_events","type":"User","site_admin":false},"repo":{"id":26488275,"name":"timesketch","full_name":"2xyo/timesketch","owner":{"login":"2xyo","id":31675,"avatar_url":"https://avatars.githubusercontent.com/u/31675?v=3","gravatar_id":"","url":"https://api.github.com/users/2xyo","html_url":"https://github.com/2xyo","followers_url":"https://api.github.com/users/2xyo/followers","following_url":"https://api.github.com/users/2xyo/following{/other_user}","gists_url":"https://api.github.com/users/2xyo/gists{/gist_id}","starred_url":"https://api.github.com/users/2xyo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/2xyo/subscriptions","organizations_url":"https://api.github.com/users/2xyo/orgs","repos_url":"https://api.github.com/users/2xyo/repos","events_url":"https://api.github.com/users/2xyo/events{/privacy}","received_events_url":"https://api.github.com/users/2xyo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/2xyo/timesketch","description":"Collaborative forensics timeline analysis","fork":true,"url":"https://api.github.com/repos/2xyo/timesketch","forks_url":"https://api.github.com/repos/2xyo/timesketch/forks","keys_url":"https://api.github.com/repos/2xyo/timesketch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/2xyo/timesketch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/2xyo/timesketch/teams","hooks_url":"https://api.github.com/repos/2xyo/timesketch/hooks","issue_events_url":"https://api.github.com/repos/2xyo/timesketch/issues/events{/number}","events_url":"https://api.github.com/repos/2xyo/timesketch/events","assignees_url":"https://api.github.com/repos/2xyo/timesketch/assignees{/user}","branches_url":"https://api.github.com/repos/2xyo/timesketch/branches{/branch}","tags_url":"https://api.github.com/repos/2xyo/timesketch/tags","blobs_url":"https://api.github.com/repos/2xyo/timesketch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/2xyo/timesketch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/2xyo/timesketch/git/refs{/sha}","trees_url":"https://api.github.com/repos/2xyo/timesketch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/2xyo/timesketch/statuses/{sha}","languages_url":"https://api.github.com/repos/2xyo/timesketch/languages","stargazers_url":"https://api.github.com/repos/2xyo/timesketch/stargazers","contributors_url":"https://api.github.com/repos/2xyo/timesketch/contributors","subscribers_url":"https://api.github.com/repos/2xyo/timesketch/subscribers","subscription_url":"https://api.github.com/repos/2xyo/timesketch/subscription","commits_url":"https://api.github.com/repos/2xyo/timesketch/commits{/sha}","git_commits_url":"https://api.github.com/repos/2xyo/timesketch/git/commits{/sha}","comments_url":"https://api.github.com/repos/2xyo/timesketch/comments{/number}","issue_comment_url":"https://api.github.com/repos/2xyo/timesketch/issues/comments/{number}","contents_url":"https://api.github.com/repos/2xyo/timesketch/contents/{+path}","compare_url":"https://api.github.com/repos/2xyo/timesketch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/2xyo/timesketch/merges","archive_url":"https://api.github.com/repos/2xyo/timesketch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/2xyo/timesketch/downloads","issues_url":"https://api.github.com/repos/2xyo/timesketch/issues{/number}","pulls_url":"https://api.github.com/repos/2xyo/timesketch/pulls{/number}","milestones_url":"https://api.github.com/repos/2xyo/timesketch/milestones{/number}","notifications_url":"https://api.github.com/repos/2xyo/timesketch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/2xyo/timesketch/labels{/name}","releases_url":"https://api.github.com/repos/2xyo/timesketch/releases{/id}","created_at":"2014-11-11T14:24:21Z","updated_at":"2014-11-11T14:38:51Z","pushed_at":"2014-11-11T15:35:32Z","git_url":"git://github.com/2xyo/timesketch.git","ssh_url":"git@github.com:2xyo/timesketch.git","clone_url":"https://github.com/2xyo/timesketch.git","svn_url":"https://github.com/2xyo/timesketch","homepage":"http://www.timesketch.org/","size":2431,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"8fd8e92463e4db4a135c6458e9a74eeb86328e9d","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":21009909,"name":"timesketch","full_name":"google/timesketch","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/timesketch","description":"Collaborative forensics timeline analysis","fork":false,"url":"https://api.github.com/repos/google/timesketch","forks_url":"https://api.github.com/repos/google/timesketch/forks","keys_url":"https://api.github.com/repos/google/timesketch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/timesketch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/timesketch/teams","hooks_url":"https://api.github.com/repos/google/timesketch/hooks","issue_events_url":"https://api.github.com/repos/google/timesketch/issues/events{/number}","events_url":"https://api.github.com/repos/google/timesketch/events","assignees_url":"https://api.github.com/repos/google/timesketch/assignees{/user}","branches_url":"https://api.github.com/repos/google/timesketch/branches{/branch}","tags_url":"https://api.github.com/repos/google/timesketch/tags","blobs_url":"https://api.github.com/repos/google/timesketch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/timesketch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/timesketch/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/timesketch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/timesketch/statuses/{sha}","languages_url":"https://api.github.com/repos/google/timesketch/languages","stargazers_url":"https://api.github.com/repos/google/timesketch/stargazers","contributors_url":"https://api.github.com/repos/google/timesketch/contributors","subscribers_url":"https://api.github.com/repos/google/timesketch/subscribers","subscription_url":"https://api.github.com/repos/google/timesketch/subscription","commits_url":"https://api.github.com/repos/google/timesketch/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/timesketch/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/timesketch/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/timesketch/issues/comments/{number}","contents_url":"https://api.github.com/repos/google/timesketch/contents/{+path}","compare_url":"https://api.github.com/repos/google/timesketch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/timesketch/merges","archive_url":"https://api.github.com/repos/google/timesketch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/timesketch/downloads","issues_url":"https://api.github.com/repos/google/timesketch/issues{/number}","pulls_url":"https://api.github.com/repos/google/timesketch/pulls{/number}","milestones_url":"https://api.github.com/repos/google/timesketch/milestones{/number}","notifications_url":"https://api.github.com/repos/google/timesketch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/timesketch/labels{/name}","releases_url":"https://api.github.com/repos/google/timesketch/releases{/id}","created_at":"2014-06-19T17:49:45Z","updated_at":"2014-11-11T17:38:39Z","pushed_at":"2014-11-12T21:49:42Z","git_url":"git://github.com/google/timesketch.git","ssh_url":"git@github.com:google/timesketch.git","clone_url":"https://github.com/google/timesketch.git","svn_url":"https://github.com/google/timesketch","homepage":"http://www.timesketch.org/","size":2431,"stargazers_count":69,"watchers_count":69,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":12,"forks":9,"open_issues":12,"watchers":69,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/timesketch/pulls/32"},"html":{"href":"https://github.com/google/timesketch/pull/32"},"issue":{"href":"https://api.github.com/repos/google/timesketch/issues/32"},"comments":{"href":"https://api.github.com/repos/google/timesketch/issues/32/comments"},"review_comments":{"href":"https://api.github.com/repos/google/timesketch/pulls/32/comments"},"review_comment":{"href":"https://api.github.com/repos/google/timesketch/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/google/timesketch/pulls/32/commits"},"statuses":{"href":"https://api.github.com/repos/google/timesketch/statuses/73ee92871ab085c41bf9418f146696a20a46c4cc"}}}}