GitHub PullRequestReviewCommentEvent at 2014-09-05 09:21:27
Repository: horizon
Actor: kevinbenton
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/bigswitch/horizon/pulls/comments/17163328","id":17163328,"diff_hunk":"@@ -168,141 +133,104 @@ def update_cleaned_data(key, value):\n \treturn cleaned_data\n \n     def handle(self, request, data):\n-\tif data['connection_source_type'] == 'instance':\n-\t\tsource = data['instance_source'].encode('ascii','ignore')\n-\t\tsource_type = data['connection_source_type'].encode('ascii','ignore')\n-\telif data['connection_source_type'] == 'ip':\n-                source = data['ip_source'].encode('ascii','ignore')\n-\t\tsource_type = data['connection_source_type'].encode('ascii','ignore')\n-\telif data['connection_source_type'] == 'mac':\n-                source = data['mac_source'].encode('ascii','ignore')\n-\t\tsource_type = data['connection_source_type'].encode('ascii','ignore')\n-\n-\tif data['connection_destination_type'] == 'instance':\n-                dest = data['instance_destination'].encode('ascii','ignore')\n-\t\tdest_type = data['connection_destination_type'].encode('ascii','ignore')\n-        elif data['connection_destination_type'] == 'ip':\n-                dest = data['ip_destination'].encode('ascii','ignore')\n-\t\tdest_type = data['connection_destination_type'].encode('ascii','ignore')\n-        elif data['connection_destination_type'] == 'mac':\n-                dest = data['mac_destination'].encode('ascii','ignore')\n-\t\tdest_type = data['connection_destination_type'].encode('ascii','ignore')\n-","path":"openstack_dashboard/dashboards/project/connections/reachability_tests/forms.py","position":209,"original_position":209,"commit_id":"e2f949e3a1122195f34ae7c410c1bd7fcf0c06f8","original_commit_id":"e2f949e3a1122195f34ae7c410c1bd7fcf0c06f8","user":{"login":"kevinbenton","id":1017708,"avatar_url":"https://avatars.githubusercontent.com/u/1017708?v=2","gravatar_id":"2951a97be66f3521bd096e5b7521f1a1","url":"https://api.github.com/users/kevinbenton","html_url":"https://github.com/kevinbenton","followers_url":"https://api.github.com/users/kevinbenton/followers","following_url":"https://api.github.com/users/kevinbenton/following{/other_user}","gists_url":"https://api.github.com/users/kevinbenton/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinbenton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinbenton/subscriptions","organizations_url":"https://api.github.com/users/kevinbenton/orgs","repos_url":"https://api.github.com/users/kevinbenton/repos","events_url":"https://api.github.com/users/kevinbenton/events{/privacy}","received_events_url":"https://api.github.com/users/kevinbenton/received_events","type":"User","site_admin":false},"body":"This could replace L136-L159","created_at":"2014-09-05T09:21:27Z","updated_at":"2014-09-05T09:21:27Z","html_url":"https://github.com/bigswitch/horizon/pull/1#discussion_r17163328","pull_request_url":"https://api.github.com/repos/bigswitch/horizon/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/bigswitch/horizon/pulls/comments/17163328"},"html":{"href":"https://github.com/bigswitch/horizon/pull/1#discussion_r17163328"},"pull_request":{"href":"https://api.github.com/repos/bigswitch/horizon/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/bigswitch/horizon/pulls/1","id":20784682,"html_url":"https://github.com/bigswitch/horizon/pull/1","diff_url":"https://github.com/bigswitch/horizon/pull/1.diff","patch_url":"https://github.com/bigswitch/horizon/pull/1.patch","issue_url":"https://api.github.com/repos/bigswitch/horizon/issues/1","number":1,"state":"open","locked":false,"title":"BVS-1981 test path integration with horizon","user":{"login":"xinwu","id":4129505,"avatar_url":"https://avatars.githubusercontent.com/u/4129505?v=2","gravatar_id":"1b3d397b7d7470c465fee3e71164883b","url":"https://api.github.com/users/xinwu","html_url":"https://github.com/xinwu","followers_url":"https://api.github.com/users/xinwu/followers","following_url":"https://api.github.com/users/xinwu/following{/other_user}","gists_url":"https://api.github.com/users/xinwu/gists{/gist_id}","starred_url":"https://api.github.com/users/xinwu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xinwu/subscriptions","organizations_url":"https://api.github.com/users/xinwu/orgs","repos_url":"https://api.github.com/users/xinwu/repos","events_url":"https://api.github.com/users/xinwu/events{/privacy}","received_events_url":"https://api.github.com/users/xinwu/received_events","type":"User","site_admin":false},"body":"Reviewer: @kevinbenton  @kjiang \r\nCC @kyleforster  \r\ntables are created in neutron db.\r\nrest client is nsapp rest/rest_lib\r\nall configuration is hardcoded at const.py ","created_at":"2014-09-05T02:16:48Z","updated_at":"2014-09-05T09:21:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"00233a06ba718508c271e29a6b9973025a7e7fa8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bigswitch/horizon/pulls/1/commits","review_comments_url":"https://api.github.com/repos/bigswitch/horizon/pulls/1/comments","review_comment_url":"https://api.github.com/repos/bigswitch/horizon/pulls/comments/{number}","comments_url":"https://api.github.com/repos/bigswitch/horizon/issues/1/comments","statuses_url":"https://api.github.com/repos/bigswitch/horizon/statuses/e2f949e3a1122195f34ae7c410c1bd7fcf0c06f8","head":{"label":"xinwu:master","ref":"master","sha":"e2f949e3a1122195f34ae7c410c1bd7fcf0c06f8","user":{"login":"xinwu","id":4129505,"avatar_url":"https://avatars.githubusercontent.com/u/4129505?v=2","gravatar_id":"1b3d397b7d7470c465fee3e71164883b","url":"https://api.github.com/users/xinwu","html_url":"https://github.com/xinwu","followers_url":"https://api.github.com/users/xinwu/followers","following_url":"https://api.github.com/users/xinwu/following{/other_user}","gists_url":"https://api.github.com/users/xinwu/gists{/gist_id}","starred_url":"https://api.github.com/users/xinwu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xinwu/subscriptions","organizations_url":"https://api.github.com/users/xinwu/orgs","repos_url":"https://api.github.com/users/xinwu/repos","events_url":"https://api.github.com/users/xinwu/events{/privacy}","received_events_url":"https://api.github.com/users/xinwu/received_events","type":"User","site_admin":false},"repo":{"id":23442294,"name":"horizon","full_name":"xinwu/horizon","owner":{"login":"xinwu","id":4129505,"avatar_url":"https://avatars.githubusercontent.com/u/4129505?v=2","gravatar_id":"1b3d397b7d7470c465fee3e71164883b","url":"https://api.github.com/users/xinwu","html_url":"https://github.com/xinwu","followers_url":"https://api.github.com/users/xinwu/followers","following_url":"https://api.github.com/users/xinwu/following{/other_user}","gists_url":"https://api.github.com/users/xinwu/gists{/gist_id}","starred_url":"https://api.github.com/users/xinwu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xinwu/subscriptions","organizations_url":"https://api.github.com/users/xinwu/orgs","repos_url":"https://api.github.com/users/xinwu/repos","events_url":"https://api.github.com/users/xinwu/events{/privacy}","received_events_url":"https://api.github.com/users/xinwu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xinwu/horizon","description":"Horizon is a Django-based project aimed at providing a complete OpenStack Dashboard along with an extensible framework for building new dashboards from reusable components.","fork":true,"url":"https://api.github.com/repos/xinwu/horizon","forks_url":"https://api.github.com/repos/xinwu/horizon/forks","keys_url":"https://api.github.com/repos/xinwu/horizon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xinwu/horizon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xinwu/horizon/teams","hooks_url":"https://api.github.com/repos/xinwu/horizon/hooks","issue_events_url":"https://api.github.com/repos/xinwu/horizon/issues/events{/number}","events_url":"https://api.github.com/repos/xinwu/horizon/events","assignees_url":"https://api.github.com/repos/xinwu/horizon/assignees{/user}","branches_url":"https://api.github.com/repos/xinwu/horizon/branches{/branch}","tags_url":"https://api.github.com/repos/xinwu/horizon/tags","blobs_url":"https://api.github.com/repos/xinwu/horizon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xinwu/horizon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xinwu/horizon/git/refs{/sha}","trees_url":"https://api.github.com/repos/xinwu/horizon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xinwu/horizon/statuses/{sha}","languages_url":"https://api.github.com/repos/xinwu/horizon/languages","stargazers_url":"https://api.github.com/repos/xinwu/horizon/stargazers","contributors_url":"https://api.github.com/repos/xinwu/horizon/contributors","subscribers_url":"https://api.github.com/repos/xinwu/horizon/subscribers","subscription_url":"https://api.github.com/repos/xinwu/horizon/subscription","commits_url":"https://api.github.com/repos/xinwu/horizon/commits{/sha}","git_commits_url":"https://api.github.com/repos/xinwu/horizon/git/commits{/sha}","comments_url":"https://api.github.com/repos/xinwu/horizon/comments{/number}","issue_comment_url":"https://api.github.com/repos/xinwu/horizon/issues/comments/{number}","contents_url":"https://api.github.com/repos/xinwu/horizon/contents/{+path}","compare_url":"https://api.github.com/repos/xinwu/horizon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xinwu/horizon/merges","archive_url":"https://api.github.com/repos/xinwu/horizon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xinwu/horizon/downloads","issues_url":"https://api.github.com/repos/xinwu/horizon/issues{/number}","pulls_url":"https://api.github.com/repos/xinwu/horizon/pulls{/number}","milestones_url":"https://api.github.com/repos/xinwu/horizon/milestones{/number}","notifications_url":"https://api.github.com/repos/xinwu/horizon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xinwu/horizon/labels{/name}","releases_url":"https://api.github.com/repos/xinwu/horizon/releases{/id}","created_at":"2014-08-28T20:43:21Z","updated_at":"2014-09-02T23:24:38Z","pushed_at":"2014-09-05T02:18:26Z","git_url":"git://github.com/xinwu/horizon.git","ssh_url":"git@github.com:xinwu/horizon.git","clone_url":"https://github.com/xinwu/horizon.git","svn_url":"https://github.com/xinwu/horizon","homepage":"http://openstack.org","size":41578,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":false,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bigswitch:master","ref":"master","sha":"2d8a3777a71201a0ba6dfe0494a1958565091c41","user":{"login":"bigswitch","id":286009,"avatar_url":"https://avatars.githubusercontent.com/u/286009?v=2","gravatar_id":"d2e2f24a98211887379cd3c46827f789","url":"https://api.github.com/users/bigswitch","html_url":"https://github.com/bigswitch","followers_url":"https://api.github.com/users/bigswitch/followers","following_url":"https://api.github.com/users/bigswitch/following{/other_user}","gists_url":"https://api.github.com/users/bigswitch/gists{/gist_id}","starred_url":"https://api.github.com/users/bigswitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bigswitch/subscriptions","organizations_url":"https://api.github.com/users/bigswitch/orgs","repos_url":"https://api.github.com/users/bigswitch/repos","events_url":"https://api.github.com/users/bigswitch/events{/privacy}","received_events_url":"https://api.github.com/users/bigswitch/received_events","type":"Organization","site_admin":false},"repo":{"id":10559993,"name":"horizon","full_name":"bigswitch/horizon","owner":{"login":"bigswitch","id":286009,"avatar_url":"https://avatars.githubusercontent.com/u/286009?v=2","gravatar_id":"d2e2f24a98211887379cd3c46827f789","url":"https://api.github.com/users/bigswitch","html_url":"https://github.com/bigswitch","followers_url":"https://api.github.com/users/bigswitch/followers","following_url":"https://api.github.com/users/bigswitch/following{/other_user}","gists_url":"https://api.github.com/users/bigswitch/gists{/gist_id}","starred_url":"https://api.github.com/users/bigswitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bigswitch/subscriptions","organizations_url":"https://api.github.com/users/bigswitch/orgs","repos_url":"https://api.github.com/users/bigswitch/repos","events_url":"https://api.github.com/users/bigswitch/events{/privacy}","received_events_url":"https://api.github.com/users/bigswitch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bigswitch/horizon","description":"Horizon is a Django-based project aimed at providing a complete OpenStack Dashboard along with an extensible framework for building new dashboards from reusable components.","fork":true,"url":"https://api.github.com/repos/bigswitch/horizon","forks_url":"https://api.github.com/repos/bigswitch/horizon/forks","keys_url":"https://api.github.com/repos/bigswitch/horizon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bigswitch/horizon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bigswitch/horizon/teams","hooks_url":"https://api.github.com/repos/bigswitch/horizon/hooks","issue_events_url":"https://api.github.com/repos/bigswitch/horizon/issues/events{/number}","events_url":"https://api.github.com/repos/bigswitch/horizon/events","assignees_url":"https://api.github.com/repos/bigswitch/horizon/assignees{/user}","branches_url":"https://api.github.com/repos/bigswitch/horizon/branches{/branch}","tags_url":"https://api.github.com/repos/bigswitch/horizon/tags","blobs_url":"https://api.github.com/repos/bigswitch/horizon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bigswitch/horizon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bigswitch/horizon/git/refs{/sha}","trees_url":"https://api.github.com/repos/bigswitch/horizon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bigswitch/horizon/statuses/{sha}","languages_url":"https://api.github.com/repos/bigswitch/horizon/languages","stargazers_url":"https://api.github.com/repos/bigswitch/horizon/stargazers","contributors_url":"https://api.github.com/repos/bigswitch/horizon/contributors","subscribers_url":"https://api.github.com/repos/bigswitch/horizon/subscribers","subscription_url":"https://api.github.com/repos/bigswitch/horizon/subscription","commits_url":"https://api.github.com/repos/bigswitch/horizon/commits{/sha}","git_commits_url":"https://api.github.com/repos/bigswitch/horizon/git/commits{/sha}","comments_url":"https://api.github.com/repos/bigswitch/horizon/comments{/number}","issue_comment_url":"https://api.github.com/repos/bigswitch/horizon/issues/comments/{number}","contents_url":"https://api.github.com/repos/bigswitch/horizon/contents/{+path}","compare_url":"https://api.github.com/repos/bigswitch/horizon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bigswitch/horizon/merges","archive_url":"https://api.github.com/repos/bigswitch/horizon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bigswitch/horizon/downloads","issues_url":"https://api.github.com/repos/bigswitch/horizon/issues{/number}","pulls_url":"https://api.github.com/repos/bigswitch/horizon/pulls{/number}","milestones_url":"https://api.github.com/repos/bigswitch/horizon/milestones{/number}","notifications_url":"https://api.github.com/repos/bigswitch/horizon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bigswitch/horizon/labels{/name}","releases_url":"https://api.github.com/repos/bigswitch/horizon/releases{/id}","created_at":"2013-06-07T22:25:42Z","updated_at":"2014-06-25T19:01:41Z","pushed_at":"2014-09-05T07:01:19Z","git_url":"git://github.com/bigswitch/horizon.git","ssh_url":"git@github.com:bigswitch/horizon.git","clone_url":"https://github.com/bigswitch/horizon.git","svn_url":"https://github.com/bigswitch/horizon","homepage":"http://openstack.org","size":45598,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":false,"has_wiki":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bigswitch/horizon/pulls/1"},"html":{"href":"https://github.com/bigswitch/horizon/pull/1"},"issue":{"href":"https://api.github.com/repos/bigswitch/horizon/issues/1"},"comments":{"href":"https://api.github.com/repos/bigswitch/horizon/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/bigswitch/horizon/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/bigswitch/horizon/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/bigswitch/horizon/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/bigswitch/horizon/statuses/e2f949e3a1122195f34ae7c410c1bd7fcf0c06f8"}}}}