GitHub PullRequestReviewCommentEvent at 2014-09-19 13:16:29
Repository: scikit-learn
Actor: arjoly
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/17783396","id":17783396,"diff_hunk":"@@ -343,14 +350,18 @@ def fit(self, X, y, n_jobs=1):\n             Training data\n         y : numpy array of shape [n_samples, n_targets]\n             Target values\n-        n_jobs : The number of jobs to use for the computation.\n-            If -1 all CPUs are used. This will only provide speedup for\n-            n_targets > 1 and sufficient large problems\n \n         Returns\n         -------\n         self : returns an instance of self.\n         \"\"\"\n+        warnings.warn(\"The n_jobs parameter has been moved from the fit\"\n+                      \" method to the LinearRegression class constructor\",\n+                      DeprecationWarning, stacklevel=2)\n+        if n_jobs != 1:\n+            self.n_jobs = n_jobs","path":"sklearn/linear_model/base.py","position":49,"original_position":49,"commit_id":"ef7169afd74c13f8edae62242daa097e9f58be3d","original_commit_id":"ef7169afd74c13f8edae62242daa097e9f58be3d","user":{"login":"arjoly","id":1274722,"avatar_url":"https://avatars.githubusercontent.com/u/1274722?v=2","gravatar_id":"9fb38ab677ea6f73bb07faa43b0677f9","url":"https://api.github.com/users/arjoly","html_url":"https://github.com/arjoly","followers_url":"https://api.github.com/users/arjoly/followers","following_url":"https://api.github.com/users/arjoly/following{/other_user}","gists_url":"https://api.github.com/users/arjoly/gists{/gist_id}","starred_url":"https://api.github.com/users/arjoly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arjoly/subscriptions","organizations_url":"https://api.github.com/users/arjoly/orgs","repos_url":"https://api.github.com/users/arjoly/repos","events_url":"https://api.github.com/users/arjoly/events{/privacy}","received_events_url":"https://api.github.com/users/arjoly/received_events","type":"User","site_admin":false},"body":"+1 for @MechCoder  suggestion","created_at":"2014-09-19T13:16:29Z","updated_at":"2014-09-19T13:16:29Z","html_url":"https://github.com/scikit-learn/scikit-learn/pull/3678#discussion_r17783396","pull_request_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/3678","_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/17783396"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/3678#discussion_r17783396"},"pull_request":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/3678"}}},"pull_request":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/3678","id":21476406,"html_url":"https://github.com/scikit-learn/scikit-learn/pull/3678","diff_url":"https://github.com/scikit-learn/scikit-learn/pull/3678.diff","patch_url":"https://github.com/scikit-learn/scikit-learn/pull/3678.patch","issue_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/3678","number":3678,"state":"open","locked":false,"title":"Removed n_jobs parameter from the fit method and added it to constructor","user":{"login":"akshayah3","id":4225167,"avatar_url":"https://avatars.githubusercontent.com/u/4225167?v=2","gravatar_id":"7291c40a33ff353d02d58e0e78d93669","url":"https://api.github.com/users/akshayah3","html_url":"https://github.com/akshayah3","followers_url":"https://api.github.com/users/akshayah3/followers","following_url":"https://api.github.com/users/akshayah3/following{/other_user}","gists_url":"https://api.github.com/users/akshayah3/gists{/gist_id}","starred_url":"https://api.github.com/users/akshayah3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akshayah3/subscriptions","organizations_url":"https://api.github.com/users/akshayah3/orgs","repos_url":"https://api.github.com/users/akshayah3/repos","events_url":"https://api.github.com/users/akshayah3/events{/privacy}","received_events_url":"https://api.github.com/users/akshayah3/received_events","type":"User","site_admin":false},"body":"Fixes #3672 \r\n@arjoly I have deprecated the n_jobs parameter from the `fit` method and added it to the constructor. I was not certain as to how to add the deprecation warning though as i am new to this community, could you please tell me how to add that? I will patch that up in the new commit along with the tests if needed Thank you!","created_at":"2014-09-19T03:39:09Z","updated_at":"2014-09-19T13:16:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9240ea05bdcba85203077a06735bfd066acfd9b6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/3678/commits","review_comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/3678/comments","review_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/{number}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/3678/comments","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/ef7169afd74c13f8edae62242daa097e9f58be3d","head":{"label":"akshayah3:LinearReg","ref":"LinearReg","sha":"ef7169afd74c13f8edae62242daa097e9f58be3d","user":{"login":"akshayah3","id":4225167,"avatar_url":"https://avatars.githubusercontent.com/u/4225167?v=2","gravatar_id":"7291c40a33ff353d02d58e0e78d93669","url":"https://api.github.com/users/akshayah3","html_url":"https://github.com/akshayah3","followers_url":"https://api.github.com/users/akshayah3/followers","following_url":"https://api.github.com/users/akshayah3/following{/other_user}","gists_url":"https://api.github.com/users/akshayah3/gists{/gist_id}","starred_url":"https://api.github.com/users/akshayah3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akshayah3/subscriptions","organizations_url":"https://api.github.com/users/akshayah3/orgs","repos_url":"https://api.github.com/users/akshayah3/repos","events_url":"https://api.github.com/users/akshayah3/events{/privacy}","received_events_url":"https://api.github.com/users/akshayah3/received_events","type":"User","site_admin":false},"repo":{"id":24214868,"name":"scikit-learn","full_name":"akshayah3/scikit-learn","owner":{"login":"akshayah3","id":4225167,"avatar_url":"https://avatars.githubusercontent.com/u/4225167?v=2","gravatar_id":"7291c40a33ff353d02d58e0e78d93669","url":"https://api.github.com/users/akshayah3","html_url":"https://github.com/akshayah3","followers_url":"https://api.github.com/users/akshayah3/followers","following_url":"https://api.github.com/users/akshayah3/following{/other_user}","gists_url":"https://api.github.com/users/akshayah3/gists{/gist_id}","starred_url":"https://api.github.com/users/akshayah3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akshayah3/subscriptions","organizations_url":"https://api.github.com/users/akshayah3/orgs","repos_url":"https://api.github.com/users/akshayah3/repos","events_url":"https://api.github.com/users/akshayah3/events{/privacy}","received_events_url":"https://api.github.com/users/akshayah3/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/akshayah3/scikit-learn","description":"scikit-learn: machine learning in Python","fork":true,"url":"https://api.github.com/repos/akshayah3/scikit-learn","forks_url":"https://api.github.com/repos/akshayah3/scikit-learn/forks","keys_url":"https://api.github.com/repos/akshayah3/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akshayah3/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akshayah3/scikit-learn/teams","hooks_url":"https://api.github.com/repos/akshayah3/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/akshayah3/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/akshayah3/scikit-learn/events","assignees_url":"https://api.github.com/repos/akshayah3/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/akshayah3/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/akshayah3/scikit-learn/tags","blobs_url":"https://api.github.com/repos/akshayah3/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akshayah3/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akshayah3/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/akshayah3/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akshayah3/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/akshayah3/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/akshayah3/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/akshayah3/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/akshayah3/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/akshayah3/scikit-learn/subscription","commits_url":"https://api.github.com/repos/akshayah3/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/akshayah3/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/akshayah3/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/akshayah3/scikit-learn/issues/comments/{number}","contents_url":"https://api.github.com/repos/akshayah3/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/akshayah3/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akshayah3/scikit-learn/merges","archive_url":"https://api.github.com/repos/akshayah3/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akshayah3/scikit-learn/downloads","issues_url":"https://api.github.com/repos/akshayah3/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/akshayah3/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/akshayah3/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/akshayah3/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akshayah3/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/akshayah3/scikit-learn/releases{/id}","created_at":"2014-09-19T03:34:14Z","updated_at":"2014-09-19T03:03:34Z","pushed_at":"2014-09-19T11:29:21Z","git_url":"git://github.com/akshayah3/scikit-learn.git","ssh_url":"git@github.com:akshayah3/scikit-learn.git","clone_url":"https://github.com/akshayah3/scikit-learn.git","svn_url":"https://github.com/akshayah3/scikit-learn","homepage":"http://scikit-learn.org","size":118383,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scikit-learn:master","ref":"master","sha":"04ee8971eaead6d4611b14f6f7e7db9fb95f79b2","user":{"login":"scikit-learn","id":365630,"avatar_url":"https://avatars.githubusercontent.com/u/365630?v=2","gravatar_id":"8a6ecb57b119c5a5b3d882d08a909278","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"repo":{"id":843222,"name":"scikit-learn","full_name":"scikit-learn/scikit-learn","owner":{"login":"scikit-learn","id":365630,"avatar_url":"https://avatars.githubusercontent.com/u/365630?v=2","gravatar_id":"8a6ecb57b119c5a5b3d882d08a909278","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scikit-learn/scikit-learn","description":"scikit-learn: machine learning in Python","fork":false,"url":"https://api.github.com/repos/scikit-learn/scikit-learn","forks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/forks","keys_url":"https://api.github.com/repos/scikit-learn/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scikit-learn/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scikit-learn/scikit-learn/teams","hooks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/events","assignees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/scikit-learn/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/tags","blobs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/scikit-learn/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscription","commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/comments/{number}","contents_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/scikit-learn/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scikit-learn/scikit-learn/merges","archive_url":"https://api.github.com/repos/scikit-learn/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scikit-learn/scikit-learn/downloads","issues_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/scikit-learn/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/scikit-learn/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/scikit-learn/scikit-learn/releases{/id}","created_at":"2010-08-17T09:43:38Z","updated_at":"2014-09-19T08:43:47Z","pushed_at":"2014-09-19T07:33:12Z","git_url":"git://github.com/scikit-learn/scikit-learn.git","ssh_url":"git@github.com:scikit-learn/scikit-learn.git","clone_url":"https://github.com/scikit-learn/scikit-learn.git","svn_url":"https://github.com/scikit-learn/scikit-learn","homepage":"http://scikit-learn.org","size":118383,"stargazers_count":4103,"watchers_count":4103,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2204,"mirror_url":null,"open_issues_count":498,"forks":2204,"open_issues":498,"watchers":4103,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/3678"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/3678"},"issue":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/3678"},"comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/3678/comments"},"review_comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/3678/comments"},"review_comment":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/3678/commits"},"statuses":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/ef7169afd74c13f8edae62242daa097e9f58be3d"}}}}