GitHub PullRequestReviewCommentEvent at 2014-09-25 00:03:01
Repository: js-test-agent
Actor: gaye
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/mozilla-b2g/js-test-agent/pulls/comments/18008466","id":18008466,"diff_hunk":"@@ -134,13 +124,13 @@\n      * @param {String} callback callback when script loading is complete.\n      */\n     require: function(url, callback, options) {\n-      this._queue.push(\n-        this._require.bind(this, url, callback, options)\n-      );\n-\n-      if (this._queue.length === 1) {\n-        this._begin();\n-      }\n+      this._queue++;\n+      var next = this._next.bind(this);\n+      return this._require(url, options)\n+      .then(() => callback && callback())\n+      .catch(() => console.error('Error while loading: ', url))\n+      .then(next)\n+      .catch(next);","path":"lib/test-agent/loader.js","position":84,"original_position":84,"commit_id":"429da43eef71c1221027661911c0b6deddeb90f6","original_commit_id":"429da43eef71c1221027661911c0b6deddeb90f6","user":{"login":"gaye","id":535859,"avatar_url":"https://avatars.githubusercontent.com/u/535859?v=2","gravatar_id":"","url":"https://api.github.com/users/gaye","html_url":"https://github.com/gaye","followers_url":"https://api.github.com/users/gaye/followers","following_url":"https://api.github.com/users/gaye/following{/other_user}","gists_url":"https://api.github.com/users/gaye/gists{/gist_id}","starred_url":"https://api.github.com/users/gaye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaye/subscriptions","organizations_url":"https://api.github.com/users/gaye/orgs","repos_url":"https://api.github.com/users/gaye/repos","events_url":"https://api.github.com/users/gaye/events{/privacy}","received_events_url":"https://api.github.com/users/gaye/received_events","type":"User","site_admin":false},"body":"Sounds good to me... and yeah good catch .then(next).catch(next) is very weird :+1: ","created_at":"2014-09-25T00:03:01Z","updated_at":"2014-09-25T00:03:01Z","html_url":"https://github.com/mozilla-b2g/js-test-agent/pull/82#discussion_r18008466","pull_request_url":"https://api.github.com/repos/mozilla-b2g/js-test-agent/pulls/82","_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/js-test-agent/pulls/comments/18008466"},"html":{"href":"https://github.com/mozilla-b2g/js-test-agent/pull/82#discussion_r18008466"},"pull_request":{"href":"https://api.github.com/repos/mozilla-b2g/js-test-agent/pulls/82"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla-b2g/js-test-agent/pulls/82","id":21260245,"html_url":"https://github.com/mozilla-b2g/js-test-agent/pull/82","diff_url":"https://github.com/mozilla-b2g/js-test-agent/pull/82.diff","patch_url":"https://github.com/mozilla-b2g/js-test-agent/pull/82.patch","issue_url":"https://api.github.com/repos/mozilla-b2g/js-test-agent/issues/82","number":82,"state":"open","locked":false,"title":"Bug 1068236 - Support 3p module loaders as first-class citizens in test-agent r=julienw","user":{"login":"gaye","id":535859,"avatar_url":"https://avatars.githubusercontent.com/u/535859?v=2","gravatar_id":"","url":"https://api.github.com/users/gaye","html_url":"https://github.com/gaye","followers_url":"https://api.github.com/users/gaye/followers","following_url":"https://api.github.com/users/gaye/following{/other_user}","gists_url":"https://api.github.com/users/gaye/gists{/gist_id}","starred_url":"https://api.github.com/users/gaye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaye/subscriptions","organizations_url":"https://api.github.com/users/gaye/orgs","repos_url":"https://api.github.com/users/gaye/repos","events_url":"https://api.github.com/users/gaye/events{/privacy}","received_events_url":"https://api.github.com/users/gaye/received_events","type":"User","site_admin":false},"body":"A @lightsofapollo patch to allow test writers to overwrite test-agent's test loader","created_at":"2014-09-15T20:56:05Z","updated_at":"2014-09-25T00:03:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8802fd18b26d38bd8579d9157b74fca8efc6e959","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-b2g/js-test-agent/pulls/82/commits","review_comments_url":"https://api.github.com/repos/mozilla-b2g/js-test-agent/pulls/82/comments","review_comment_url":"https://api.github.com/repos/mozilla-b2g/js-test-agent/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mozilla-b2g/js-test-agent/issues/82/comments","statuses_url":"https://api.github.com/repos/mozilla-b2g/js-test-agent/statuses/429da43eef71c1221027661911c0b6deddeb90f6","head":{"label":"gaye:amd","ref":"amd","sha":"429da43eef71c1221027661911c0b6deddeb90f6","user":{"login":"gaye","id":535859,"avatar_url":"https://avatars.githubusercontent.com/u/535859?v=2","gravatar_id":"","url":"https://api.github.com/users/gaye","html_url":"https://github.com/gaye","followers_url":"https://api.github.com/users/gaye/followers","following_url":"https://api.github.com/users/gaye/following{/other_user}","gists_url":"https://api.github.com/users/gaye/gists{/gist_id}","starred_url":"https://api.github.com/users/gaye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaye/subscriptions","organizations_url":"https://api.github.com/users/gaye/orgs","repos_url":"https://api.github.com/users/gaye/repos","events_url":"https://api.github.com/users/gaye/events{/privacy}","received_events_url":"https://api.github.com/users/gaye/received_events","type":"User","site_admin":false},"repo":{"id":24072949,"name":"js-test-agent","full_name":"gaye/js-test-agent","owner":{"login":"gaye","id":535859,"avatar_url":"https://avatars.githubusercontent.com/u/535859?v=2","gravatar_id":"","url":"https://api.github.com/users/gaye","html_url":"https://github.com/gaye","followers_url":"https://api.github.com/users/gaye/followers","following_url":"https://api.github.com/users/gaye/following{/other_user}","gists_url":"https://api.github.com/users/gaye/gists{/gist_id}","starred_url":"https://api.github.com/users/gaye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaye/subscriptions","organizations_url":"https://api.github.com/users/gaye/orgs","repos_url":"https://api.github.com/users/gaye/repos","events_url":"https://api.github.com/users/gaye/events{/privacy}","received_events_url":"https://api.github.com/users/gaye/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gaye/js-test-agent","description":"Client Side javascript test executor","fork":true,"url":"https://api.github.com/repos/gaye/js-test-agent","forks_url":"https://api.github.com/repos/gaye/js-test-agent/forks","keys_url":"https://api.github.com/repos/gaye/js-test-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gaye/js-test-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gaye/js-test-agent/teams","hooks_url":"https://api.github.com/repos/gaye/js-test-agent/hooks","issue_events_url":"https://api.github.com/repos/gaye/js-test-agent/issues/events{/number}","events_url":"https://api.github.com/repos/gaye/js-test-agent/events","assignees_url":"https://api.github.com/repos/gaye/js-test-agent/assignees{/user}","branches_url":"https://api.github.com/repos/gaye/js-test-agent/branches{/branch}","tags_url":"https://api.github.com/repos/gaye/js-test-agent/tags","blobs_url":"https://api.github.com/repos/gaye/js-test-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gaye/js-test-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gaye/js-test-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/gaye/js-test-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gaye/js-test-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/gaye/js-test-agent/languages","stargazers_url":"https://api.github.com/repos/gaye/js-test-agent/stargazers","contributors_url":"https://api.github.com/repos/gaye/js-test-agent/contributors","subscribers_url":"https://api.github.com/repos/gaye/js-test-agent/subscribers","subscription_url":"https://api.github.com/repos/gaye/js-test-agent/subscription","commits_url":"https://api.github.com/repos/gaye/js-test-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/gaye/js-test-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/gaye/js-test-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/gaye/js-test-agent/issues/comments/{number}","contents_url":"https://api.github.com/repos/gaye/js-test-agent/contents/{+path}","compare_url":"https://api.github.com/repos/gaye/js-test-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gaye/js-test-agent/merges","archive_url":"https://api.github.com/repos/gaye/js-test-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gaye/js-test-agent/downloads","issues_url":"https://api.github.com/repos/gaye/js-test-agent/issues{/number}","pulls_url":"https://api.github.com/repos/gaye/js-test-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/gaye/js-test-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/gaye/js-test-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gaye/js-test-agent/labels{/name}","releases_url":"https://api.github.com/repos/gaye/js-test-agent/releases{/id}","created_at":"2014-09-15T20:37:29Z","updated_at":"2014-07-15T05:37:54Z","pushed_at":"2014-09-23T19:22:16Z","git_url":"git://github.com/gaye/js-test-agent.git","ssh_url":"git@github.com:gaye/js-test-agent.git","clone_url":"https://github.com/gaye/js-test-agent.git","svn_url":"https://github.com/gaye/js-test-agent","homepage":"","size":782,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla-b2g:master","ref":"master","sha":"9dfa3cee3abe838665b04b13101b8aa1a7d9bbfa","user":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=2","gravatar_id":"","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"repo":{"id":3914039,"name":"js-test-agent","full_name":"mozilla-b2g/js-test-agent","owner":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=2","gravatar_id":"","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-b2g/js-test-agent","description":"Client Side javascript test executor","fork":false,"url":"https://api.github.com/repos/mozilla-b2g/js-test-agent","forks_url":"https://api.github.com/repos/mozilla-b2g/js-test-agent/forks","keys_url":"https://api.github.com/repos/mozilla-b2g/js-test-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-b2g/js-test-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-b2g/js-test-agent/teams","hooks_url":"https://api.github.com/repos/mozilla-b2g/js-test-agent/hooks","issue_events_url":"https://api.github.com/repos/mozilla-b2g/js-test-agent/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-b2g/js-test-agent/events","assignees_url":"https://api.github.com/repos/mozilla-b2g/js-test-agent/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-b2g/js-test-agent/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-b2g/js-test-agent/tags","blobs_url":"https://api.github.com/repos/mozilla-b2g/js-test-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-b2g/js-test-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-b2g/js-test-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-b2g/js-test-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-b2g/js-test-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-b2g/js-test-agent/languages","stargazers_url":"https://api.github.com/repos/mozilla-b2g/js-test-agent/stargazers","contributors_url":"https://api.github.com/repos/mozilla-b2g/js-test-agent/contributors","subscribers_url":"https://api.github.com/repos/mozilla-b2g/js-test-agent/subscribers","subscription_url":"https://api.github.com/repos/mozilla-b2g/js-test-agent/subscription","commits_url":"https://api.github.com/repos/mozilla-b2g/js-test-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-b2g/js-test-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-b2g/js-test-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-b2g/js-test-agent/issues/comments/{number}","contents_url":"https://api.github.com/repos/mozilla-b2g/js-test-agent/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-b2g/js-test-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-b2g/js-test-agent/merges","archive_url":"https://api.github.com/repos/mozilla-b2g/js-test-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-b2g/js-test-agent/downloads","issues_url":"https://api.github.com/repos/mozilla-b2g/js-test-agent/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-b2g/js-test-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-b2g/js-test-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-b2g/js-test-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-b2g/js-test-agent/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-b2g/js-test-agent/releases{/id}","created_at":"2012-04-03T02:45:25Z","updated_at":"2014-07-15T05:37:54Z","pushed_at":"2014-09-05T19:11:45Z","git_url":"git://github.com/mozilla-b2g/js-test-agent.git","ssh_url":"git@github.com:mozilla-b2g/js-test-agent.git","clone_url":"https://github.com/mozilla-b2g/js-test-agent.git","svn_url":"https://github.com/mozilla-b2g/js-test-agent","homepage":"","size":1776,"stargazers_count":9,"watchers_count":9,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":19,"forks":12,"open_issues":19,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/js-test-agent/pulls/82"},"html":{"href":"https://github.com/mozilla-b2g/js-test-agent/pull/82"},"issue":{"href":"https://api.github.com/repos/mozilla-b2g/js-test-agent/issues/82"},"comments":{"href":"https://api.github.com/repos/mozilla-b2g/js-test-agent/issues/82/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-b2g/js-test-agent/pulls/82/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-b2g/js-test-agent/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mozilla-b2g/js-test-agent/pulls/82/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-b2g/js-test-agent/statuses/429da43eef71c1221027661911c0b6deddeb90f6"}}}}