GitHub PullRequestReviewCommentEvent at 2014-11-23 22:02:15
Repository: homebrew
Actor: DomT4
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/Homebrew/homebrew/pulls/comments/20768327","id":20768327,"diff_hunk":"@@ -2,30 +2,55 @@\n \n class Clamav < Formula\n   homepage \"http://www.clamav.net/\"\n-  head \"https://github.com/vrtadmin/clamav-devel\"\n-  url \"https://downloads.sourceforge.net/clamav/clamav-0.98.4.tar.gz\"\n-  sha1 \"f1003d04f34efb0aede05395d3c7cc22c944e4ef\"\n+  url \"https://downloads.sourceforge.net/clamav/clamav-0.98.5.tar.gz\"\n+  sha1 \"5f5e45735819e3ca61610899b779172a5639f70f\"\n \n   bottle do\n-    revision 1\n     sha1 \"3cec3e85844d54a629a735a4cd035475af1a62b4\" => :mavericks\n     sha1 \"2f7e1f591e956369eae6446e4a5aeb4ee79940e4\" => :mountain_lion\n     sha1 \"07e9159ecbf0aa90dd56a7ee9d728b7bb77d5b6b\" => :lion\n   end\n \n+  head do\n+    url \"https://github.com/vrtadmin/clamav-devel.git\"\n+\n+    depends_on \"automake\" => :build\n+    depends_on \"autoconf\" => :build\n+    depends_on \"libtool\" => :build\n+  end\n+\n   depends_on \"openssl\"\n+  depends_on \"json-c\" => :recommended\n \n   skip_clean \"share/clamav\"\n \n   def install\n+    args = [ \"--disable-dependency-tracking\",\n+             \"--disable-silent-rules\",\n+             \"--prefix=#{prefix}\",\n+             \"--libdir=#{lib}\",\n+             \"--sysconfdir=#{etc}/clamav\",\n+             \"--disable-zlib-vcheck\",\n+             \"--with-zlib=#{MacOS.sdk_path}/usr\",\n+             \"--with-openssl=#{Formula[\"openssl\"].opt_prefix}\"\n+    ]\n+\n+    args << \"--with-libjson=#{Formula[\"json-c\"].opt_prefix}\" if build.with? \"json-c\"\n+\n     (share/\"clamav\").mkpath\n-    system \"./configure\", \"--disable-dependency-tracking\",\n-                          \"--prefix=#{prefix}\",\n-                          \"--libdir=#{lib}\",\n-                          \"--sysconfdir=#{etc}\",\n-                          \"--disable-zlib-vcheck\",\n-                          \"--with-zlib=#{MacOS.sdk_path}/usr\",\n-                          \"--with-openssl=#{Formula[\"openssl\"].opt_prefix}\"\n+    system \"autoreconf\", \"-i\" if build.head?\n+    system \"./configure\", *args\n     system \"make\", \"install\"\n   end\n+\n+  def caveats; <<-EOS.undent\n+    To finish installation & run clamav you need to edit the conf files at:\n+      #{etc}/clamav/\n+    Note you will also need to remove the .sample file endings after editing.","path":"Library/Formula/clamav.rb","position":59,"original_position":59,"commit_id":"0f6c24f5984b2144b23c6732456e81c4acd9d1cf","original_commit_id":"0f6c24f5984b2144b23c6732456e81c4acd9d1cf","user":{"login":"DomT4","id":6998367,"avatar_url":"https://avatars.githubusercontent.com/u/6998367?v=3","gravatar_id":"","url":"https://api.github.com/users/DomT4","html_url":"https://github.com/DomT4","followers_url":"https://api.github.com/users/DomT4/followers","following_url":"https://api.github.com/users/DomT4/following{/other_user}","gists_url":"https://api.github.com/users/DomT4/gists{/gist_id}","starred_url":"https://api.github.com/users/DomT4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DomT4/subscriptions","organizations_url":"https://api.github.com/users/DomT4/orgs","repos_url":"https://api.github.com/users/DomT4/repos","events_url":"https://api.github.com/users/DomT4/events{/privacy}","received_events_url":"https://api.github.com/users/DomT4/received_events","type":"User","site_admin":false},"body":"Is it worth pointing people to the Apple example defaults or just leaving it as:\r\n\r\n```\r\n    To finish installation & run clamav you will need to edit\r\n    the example conf files at:\r\n      #{etc}/clamav/\r\n```","created_at":"2014-11-23T22:02:15Z","updated_at":"2014-11-23T22:02:15Z","html_url":"https://github.com/Homebrew/homebrew/pull/34403#discussion_r20768327","pull_request_url":"https://api.github.com/repos/Homebrew/homebrew/pulls/34403","_links":{"self":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/comments/20768327"},"html":{"href":"https://github.com/Homebrew/homebrew/pull/34403#discussion_r20768327"},"pull_request":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/34403"}}},"pull_request":{"url":"https://api.github.com/repos/Homebrew/homebrew/pulls/34403","id":24904946,"html_url":"https://github.com/Homebrew/homebrew/pull/34403","diff_url":"https://github.com/Homebrew/homebrew/pull/34403.diff","patch_url":"https://github.com/Homebrew/homebrew/pull/34403.patch","issue_url":"https://api.github.com/repos/Homebrew/homebrew/issues/34403","number":34403,"state":"open","locked":false,"title":"clamav 0.98.5","user":{"login":"DomT4","id":6998367,"avatar_url":"https://avatars.githubusercontent.com/u/6998367?v=3","gravatar_id":"","url":"https://api.github.com/users/DomT4","html_url":"https://github.com/DomT4","followers_url":"https://api.github.com/users/DomT4/followers","following_url":"https://api.github.com/users/DomT4/following{/other_user}","gists_url":"https://api.github.com/users/DomT4/gists{/gist_id}","starred_url":"https://api.github.com/users/DomT4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DomT4/subscriptions","organizations_url":"https://api.github.com/users/DomT4/orgs","repos_url":"https://api.github.com/users/DomT4/repos","events_url":"https://api.github.com/users/DomT4/events{/privacy}","received_events_url":"https://api.github.com/users/DomT4/received_events","type":"User","site_admin":false},"body":"* Version bump. \r\n* Fixed head.\r\n* New recommend dependency *(It’s actually an old recommended dependency that we haven’t been building).* \r\n* Moves the sysconf dir to a directory inside HOMEBREW_PREFIX/etc to make it a little tidier.\r\n* Adds some caveats to explain clamav’s confusing error messages on initial run.\r\n* Adds a test.","created_at":"2014-11-23T19:06:02Z","updated_at":"2014-11-23T22:02:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1d9334e7f9bd2e97466ab7959d8217b1d9477a76","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Homebrew/homebrew/pulls/34403/commits","review_comments_url":"https://api.github.com/repos/Homebrew/homebrew/pulls/34403/comments","review_comment_url":"https://api.github.com/repos/Homebrew/homebrew/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Homebrew/homebrew/issues/34403/comments","statuses_url":"https://api.github.com/repos/Homebrew/homebrew/statuses/0f6c24f5984b2144b23c6732456e81c4acd9d1cf","head":{"label":"DomT4:clam","ref":"clam","sha":"0f6c24f5984b2144b23c6732456e81c4acd9d1cf","user":{"login":"DomT4","id":6998367,"avatar_url":"https://avatars.githubusercontent.com/u/6998367?v=3","gravatar_id":"","url":"https://api.github.com/users/DomT4","html_url":"https://github.com/DomT4","followers_url":"https://api.github.com/users/DomT4/followers","following_url":"https://api.github.com/users/DomT4/following{/other_user}","gists_url":"https://api.github.com/users/DomT4/gists{/gist_id}","starred_url":"https://api.github.com/users/DomT4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DomT4/subscriptions","organizations_url":"https://api.github.com/users/DomT4/orgs","repos_url":"https://api.github.com/users/DomT4/repos","events_url":"https://api.github.com/users/DomT4/events{/privacy}","received_events_url":"https://api.github.com/users/DomT4/received_events","type":"User","site_admin":false},"repo":{"id":23289808,"name":"homebrew","full_name":"DomT4/homebrew","owner":{"login":"DomT4","id":6998367,"avatar_url":"https://avatars.githubusercontent.com/u/6998367?v=3","gravatar_id":"","url":"https://api.github.com/users/DomT4","html_url":"https://github.com/DomT4","followers_url":"https://api.github.com/users/DomT4/followers","following_url":"https://api.github.com/users/DomT4/following{/other_user}","gists_url":"https://api.github.com/users/DomT4/gists{/gist_id}","starred_url":"https://api.github.com/users/DomT4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DomT4/subscriptions","organizations_url":"https://api.github.com/users/DomT4/orgs","repos_url":"https://api.github.com/users/DomT4/repos","events_url":"https://api.github.com/users/DomT4/events{/privacy}","received_events_url":"https://api.github.com/users/DomT4/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DomT4/homebrew","description":"The missing package manager for OS X.","fork":true,"url":"https://api.github.com/repos/DomT4/homebrew","forks_url":"https://api.github.com/repos/DomT4/homebrew/forks","keys_url":"https://api.github.com/repos/DomT4/homebrew/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DomT4/homebrew/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DomT4/homebrew/teams","hooks_url":"https://api.github.com/repos/DomT4/homebrew/hooks","issue_events_url":"https://api.github.com/repos/DomT4/homebrew/issues/events{/number}","events_url":"https://api.github.com/repos/DomT4/homebrew/events","assignees_url":"https://api.github.com/repos/DomT4/homebrew/assignees{/user}","branches_url":"https://api.github.com/repos/DomT4/homebrew/branches{/branch}","tags_url":"https://api.github.com/repos/DomT4/homebrew/tags","blobs_url":"https://api.github.com/repos/DomT4/homebrew/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DomT4/homebrew/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DomT4/homebrew/git/refs{/sha}","trees_url":"https://api.github.com/repos/DomT4/homebrew/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DomT4/homebrew/statuses/{sha}","languages_url":"https://api.github.com/repos/DomT4/homebrew/languages","stargazers_url":"https://api.github.com/repos/DomT4/homebrew/stargazers","contributors_url":"https://api.github.com/repos/DomT4/homebrew/contributors","subscribers_url":"https://api.github.com/repos/DomT4/homebrew/subscribers","subscription_url":"https://api.github.com/repos/DomT4/homebrew/subscription","commits_url":"https://api.github.com/repos/DomT4/homebrew/commits{/sha}","git_commits_url":"https://api.github.com/repos/DomT4/homebrew/git/commits{/sha}","comments_url":"https://api.github.com/repos/DomT4/homebrew/comments{/number}","issue_comment_url":"https://api.github.com/repos/DomT4/homebrew/issues/comments/{number}","contents_url":"https://api.github.com/repos/DomT4/homebrew/contents/{+path}","compare_url":"https://api.github.com/repos/DomT4/homebrew/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DomT4/homebrew/merges","archive_url":"https://api.github.com/repos/DomT4/homebrew/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DomT4/homebrew/downloads","issues_url":"https://api.github.com/repos/DomT4/homebrew/issues{/number}","pulls_url":"https://api.github.com/repos/DomT4/homebrew/pulls{/number}","milestones_url":"https://api.github.com/repos/DomT4/homebrew/milestones{/number}","notifications_url":"https://api.github.com/repos/DomT4/homebrew/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DomT4/homebrew/labels{/name}","releases_url":"https://api.github.com/repos/DomT4/homebrew/releases{/id}","created_at":"2014-08-24T19:01:40Z","updated_at":"2014-11-22T22:22:04Z","pushed_at":"2014-11-23T19:50:21Z","git_url":"git://github.com/DomT4/homebrew.git","ssh_url":"git@github.com:DomT4/homebrew.git","clone_url":"https://github.com/DomT4/homebrew.git","svn_url":"https://github.com/DomT4/homebrew","homepage":"http://brew.sh","size":51254,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Homebrew:master","ref":"master","sha":"ee8c1dcaf5456537d9f36cde5254ab205276fc8f","user":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars.githubusercontent.com/u/1503512?v=3","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"repo":{"id":206084,"name":"homebrew","full_name":"Homebrew/homebrew","owner":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars.githubusercontent.com/u/1503512?v=3","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Homebrew/homebrew","description":"The missing package manager for OS X.","fork":false,"url":"https://api.github.com/repos/Homebrew/homebrew","forks_url":"https://api.github.com/repos/Homebrew/homebrew/forks","keys_url":"https://api.github.com/repos/Homebrew/homebrew/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Homebrew/homebrew/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Homebrew/homebrew/teams","hooks_url":"https://api.github.com/repos/Homebrew/homebrew/hooks","issue_events_url":"https://api.github.com/repos/Homebrew/homebrew/issues/events{/number}","events_url":"https://api.github.com/repos/Homebrew/homebrew/events","assignees_url":"https://api.github.com/repos/Homebrew/homebrew/assignees{/user}","branches_url":"https://api.github.com/repos/Homebrew/homebrew/branches{/branch}","tags_url":"https://api.github.com/repos/Homebrew/homebrew/tags","blobs_url":"https://api.github.com/repos/Homebrew/homebrew/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Homebrew/homebrew/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Homebrew/homebrew/git/refs{/sha}","trees_url":"https://api.github.com/repos/Homebrew/homebrew/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Homebrew/homebrew/statuses/{sha}","languages_url":"https://api.github.com/repos/Homebrew/homebrew/languages","stargazers_url":"https://api.github.com/repos/Homebrew/homebrew/stargazers","contributors_url":"https://api.github.com/repos/Homebrew/homebrew/contributors","subscribers_url":"https://api.github.com/repos/Homebrew/homebrew/subscribers","subscription_url":"https://api.github.com/repos/Homebrew/homebrew/subscription","commits_url":"https://api.github.com/repos/Homebrew/homebrew/commits{/sha}","git_commits_url":"https://api.github.com/repos/Homebrew/homebrew/git/commits{/sha}","comments_url":"https://api.github.com/repos/Homebrew/homebrew/comments{/number}","issue_comment_url":"https://api.github.com/repos/Homebrew/homebrew/issues/comments/{number}","contents_url":"https://api.github.com/repos/Homebrew/homebrew/contents/{+path}","compare_url":"https://api.github.com/repos/Homebrew/homebrew/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Homebrew/homebrew/merges","archive_url":"https://api.github.com/repos/Homebrew/homebrew/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Homebrew/homebrew/downloads","issues_url":"https://api.github.com/repos/Homebrew/homebrew/issues{/number}","pulls_url":"https://api.github.com/repos/Homebrew/homebrew/pulls{/number}","milestones_url":"https://api.github.com/repos/Homebrew/homebrew/milestones{/number}","notifications_url":"https://api.github.com/repos/Homebrew/homebrew/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Homebrew/homebrew/labels{/name}","releases_url":"https://api.github.com/repos/Homebrew/homebrew/releases{/id}","created_at":"2009-05-20T19:38:37Z","updated_at":"2014-11-23T21:36:15Z","pushed_at":"2014-11-23T21:28:40Z","git_url":"git://github.com/Homebrew/homebrew.git","ssh_url":"git@github.com:Homebrew/homebrew.git","clone_url":"https://github.com/Homebrew/homebrew.git","svn_url":"https://github.com/Homebrew/homebrew","homepage":"http://brew.sh","size":1248324,"stargazers_count":20218,"watchers_count":20218,"language":"Ruby","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":10144,"mirror_url":null,"open_issues_count":256,"forks":10144,"open_issues":256,"watchers":20218,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/34403"},"html":{"href":"https://github.com/Homebrew/homebrew/pull/34403"},"issue":{"href":"https://api.github.com/repos/Homebrew/homebrew/issues/34403"},"comments":{"href":"https://api.github.com/repos/Homebrew/homebrew/issues/34403/comments"},"review_comments":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/34403/comments"},"review_comment":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/34403/commits"},"statuses":{"href":"https://api.github.com/repos/Homebrew/homebrew/statuses/0f6c24f5984b2144b23c6732456e81c4acd9d1cf"}}}}