GitHub PullRequestReviewCommentEvent at 2014-12-19 11:25:37
Repository: symfony
Actor: csarrazi
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/symfony/symfony/pulls/comments/22100126","id":22100126,"diff_hunk":"@@ -1,168 +0,0 @@\n-<?php\n-\n-/*\n- * This file is part of the Symfony package.\n- *\n- * (c) Fabien Potencier <fabien@symfony.com>\n- *\n- * For the full copyright and license information, please view the LICENSE\n- * file that was distributed with this source code.\n- */\n-\n-namespace Symfony\\Component\\Security\\Core\\Tests\\Validator\\Constraints;\n-\n-use Symfony\\Component\\Security\\Core\\Encoder\\EncoderFactoryInterface;\n-use Symfony\\Component\\Security\\Core\\Encoder\\PasswordEncoderInterface;\n-use Symfony\\Component\\Security\\Core\\SecurityContextInterface;\n-use Symfony\\Component\\Security\\Core\\Validator\\Constraints\\UserPassword;\n-use Symfony\\Component\\Security\\Core\\Validator\\Constraints\\UserPasswordValidator;\n-use Symfony\\Component\\Validator\\Tests\\Constraints\\AbstractConstraintValidatorTest;\n-\n-/**\n- * @author Bernhard Schussek <bschussek@gmail.com>\n- */\n-class UserPasswordValidatorTest extends AbstractConstraintValidatorTest","path":"src/Symfony/Component/Security/Core/Tests/Validator/Constraints/UserPasswordValidatorTest.php","position":24,"original_position":24,"commit_id":"ef4ae63e8a8200d1f3929a2c57415943ede8bd7e","original_commit_id":"ef4ae63e8a8200d1f3929a2c57415943ede8bd7e","user":{"login":"csarrazi","id":465798,"avatar_url":"https://avatars.githubusercontent.com/u/465798?v=3","gravatar_id":"","url":"https://api.github.com/users/csarrazi","html_url":"https://github.com/csarrazi","followers_url":"https://api.github.com/users/csarrazi/followers","following_url":"https://api.github.com/users/csarrazi/following{/other_user}","gists_url":"https://api.github.com/users/csarrazi/gists{/gist_id}","starred_url":"https://api.github.com/users/csarrazi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csarrazi/subscriptions","organizations_url":"https://api.github.com/users/csarrazi/orgs","repos_url":"https://api.github.com/users/csarrazi/repos","events_url":"https://api.github.com/users/csarrazi/events{/privacy}","received_events_url":"https://api.github.com/users/csarrazi/received_events","type":"User","site_admin":false},"body":"Indeed, this test is in the wrong path, and there is actually already a UserPasswordValidatorTest in `Symfony\\Component\\Security\\Tests\\Core\\Validator\\Constraints`.","created_at":"2014-12-19T11:25:37Z","updated_at":"2014-12-19T11:25:37Z","html_url":"https://github.com/symfony/symfony/pull/13033#discussion_r22100126","pull_request_url":"https://api.github.com/repos/symfony/symfony/pulls/13033","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/22100126"},"html":{"href":"https://github.com/symfony/symfony/pull/13033#discussion_r22100126"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony/pulls/13033"}}},"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/13033","id":26323425,"html_url":"https://github.com/symfony/symfony/pull/13033","diff_url":"https://github.com/symfony/symfony/pull/13033.diff","patch_url":"https://github.com/symfony/symfony/pull/13033.patch","issue_url":"https://api.github.com/repos/symfony/symfony/issues/13033","number":13033,"state":"open","locked":false,"title":"[Tests] Silenced all deprecations in tests for 2.3","user":{"login":"saro0h","id":667519,"avatar_url":"https://avatars.githubusercontent.com/u/667519?v=3","gravatar_id":"","url":"https://api.github.com/users/saro0h","html_url":"https://github.com/saro0h","followers_url":"https://api.github.com/users/saro0h/followers","following_url":"https://api.github.com/users/saro0h/following{/other_user}","gists_url":"https://api.github.com/users/saro0h/gists{/gist_id}","starred_url":"https://api.github.com/users/saro0h/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saro0h/subscriptions","organizations_url":"https://api.github.com/users/saro0h/orgs","repos_url":"https://api.github.com/users/saro0h/repos","events_url":"https://api.github.com/users/saro0h/events{/privacy}","received_events_url":"https://api.github.com/users/saro0h/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Bug fix?      | yes\r\n| New feature?  | no\r\n| BC breaks?    | no\r\n| Deprecations? | no\r\n| Tests pass?   | yes\r\n| Fixed tickets | ~\r\n| License       | MIT\r\n| Doc PR        | ~\r\n\r\nAlso removed src/Symfony/Component/Security/Core/Tests/Validator/Constraints/UserPasswordValidatorTest.php as it was not running at all.\r\n","created_at":"2014-12-18T19:02:07Z","updated_at":"2014-12-19T11:25:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f719d27b12653de6b4c1dac45ec3372a272e7008","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/symfony/symfony/pulls/13033/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony/pulls/13033/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony/pulls/comments/{number}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/13033/comments","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/ef4ae63e8a8200d1f3929a2c57415943ede8bd7e","head":{"label":"saro0h:fix-deprecation","ref":"fix-deprecation","sha":"ef4ae63e8a8200d1f3929a2c57415943ede8bd7e","user":{"login":"saro0h","id":667519,"avatar_url":"https://avatars.githubusercontent.com/u/667519?v=3","gravatar_id":"","url":"https://api.github.com/users/saro0h","html_url":"https://github.com/saro0h","followers_url":"https://api.github.com/users/saro0h/followers","following_url":"https://api.github.com/users/saro0h/following{/other_user}","gists_url":"https://api.github.com/users/saro0h/gists{/gist_id}","starred_url":"https://api.github.com/users/saro0h/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saro0h/subscriptions","organizations_url":"https://api.github.com/users/saro0h/orgs","repos_url":"https://api.github.com/users/saro0h/repos","events_url":"https://api.github.com/users/saro0h/events{/privacy}","received_events_url":"https://api.github.com/users/saro0h/received_events","type":"User","site_admin":false},"repo":{"id":8801686,"name":"symfony","full_name":"saro0h/symfony","owner":{"login":"saro0h","id":667519,"avatar_url":"https://avatars.githubusercontent.com/u/667519?v=3","gravatar_id":"","url":"https://api.github.com/users/saro0h","html_url":"https://github.com/saro0h","followers_url":"https://api.github.com/users/saro0h/followers","following_url":"https://api.github.com/users/saro0h/following{/other_user}","gists_url":"https://api.github.com/users/saro0h/gists{/gist_id}","starred_url":"https://api.github.com/users/saro0h/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saro0h/subscriptions","organizations_url":"https://api.github.com/users/saro0h/orgs","repos_url":"https://api.github.com/users/saro0h/repos","events_url":"https://api.github.com/users/saro0h/events{/privacy}","received_events_url":"https://api.github.com/users/saro0h/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/saro0h/symfony","description":"The Symfony PHP framework","fork":true,"url":"https://api.github.com/repos/saro0h/symfony","forks_url":"https://api.github.com/repos/saro0h/symfony/forks","keys_url":"https://api.github.com/repos/saro0h/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saro0h/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saro0h/symfony/teams","hooks_url":"https://api.github.com/repos/saro0h/symfony/hooks","issue_events_url":"https://api.github.com/repos/saro0h/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/saro0h/symfony/events","assignees_url":"https://api.github.com/repos/saro0h/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/saro0h/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/saro0h/symfony/tags","blobs_url":"https://api.github.com/repos/saro0h/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saro0h/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saro0h/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/saro0h/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saro0h/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/saro0h/symfony/languages","stargazers_url":"https://api.github.com/repos/saro0h/symfony/stargazers","contributors_url":"https://api.github.com/repos/saro0h/symfony/contributors","subscribers_url":"https://api.github.com/repos/saro0h/symfony/subscribers","subscription_url":"https://api.github.com/repos/saro0h/symfony/subscription","commits_url":"https://api.github.com/repos/saro0h/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/saro0h/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/saro0h/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/saro0h/symfony/issues/comments/{number}","contents_url":"https://api.github.com/repos/saro0h/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/saro0h/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saro0h/symfony/merges","archive_url":"https://api.github.com/repos/saro0h/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saro0h/symfony/downloads","issues_url":"https://api.github.com/repos/saro0h/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/saro0h/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/saro0h/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/saro0h/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saro0h/symfony/labels{/name}","releases_url":"https://api.github.com/repos/saro0h/symfony/releases{/id}","created_at":"2013-03-15T14:54:10Z","updated_at":"2014-12-06T00:47:21Z","pushed_at":"2014-12-18T19:00:32Z","git_url":"git://github.com/saro0h/symfony.git","ssh_url":"git@github.com:saro0h/symfony.git","clone_url":"https://github.com/saro0h/symfony.git","svn_url":"https://github.com/saro0h/symfony","homepage":"symfony.com","size":48451,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"symfony:2.3","ref":"2.3","sha":"2f53d69fa4e0e26b7565fe349a42ed383c9b3c6e","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":458058,"name":"symfony","full_name":"symfony/symfony","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony","description":"The Symfony PHP framework","fork":false,"url":"https://api.github.com/repos/symfony/symfony","forks_url":"https://api.github.com/repos/symfony/symfony/forks","keys_url":"https://api.github.com/repos/symfony/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony/teams","hooks_url":"https://api.github.com/repos/symfony/symfony/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony/events","assignees_url":"https://api.github.com/repos/symfony/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony/tags","blobs_url":"https://api.github.com/repos/symfony/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony/subscription","commits_url":"https://api.github.com/repos/symfony/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony/issues/comments/{number}","contents_url":"https://api.github.com/repos/symfony/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony/merges","archive_url":"https://api.github.com/repos/symfony/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony/downloads","issues_url":"https://api.github.com/repos/symfony/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony/releases{/id}","created_at":"2010-01-04T14:21:21Z","updated_at":"2014-12-19T10:50:57Z","pushed_at":"2014-12-18T18:09:39Z","git_url":"git://github.com/symfony/symfony.git","ssh_url":"git@github.com:symfony/symfony.git","clone_url":"https://github.com/symfony/symfony.git","svn_url":"https://github.com/symfony/symfony","homepage":"symfony.com","size":175051,"stargazers_count":9393,"watchers_count":9393,"language":"PHP","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":3667,"mirror_url":null,"open_issues_count":950,"forks":3667,"open_issues":950,"watchers":9393,"default_branch":"2.7"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/13033"},"html":{"href":"https://github.com/symfony/symfony/pull/13033"},"issue":{"href":"https://api.github.com/repos/symfony/symfony/issues/13033"},"comments":{"href":"https://api.github.com/repos/symfony/symfony/issues/13033/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony/pulls/13033/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony/pulls/13033/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony/statuses/ef4ae63e8a8200d1f3929a2c57415943ede8bd7e"}}}}