GitHub PullRequestReviewCommentEvent at 2014-08-28 23:30:00
Repository: spree
Actor: isaacfreeman
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/isaacfreeman/spree/pulls/comments/16874615","id":16874615,"diff_hunk":"@@ -0,0 +1,13 @@\n+<div data-hook=\"admin_product_form_meta_keywords\">","path":"backend/app/views/spree/admin/products/_seo_fields.html.erb","position":1,"original_position":1,"commit_id":"9d338d7999f4ce3901aa07eebf85f80a15497804","original_commit_id":"9d338d7999f4ce3901aa07eebf85f80a15497804","user":{"login":"isaacfreeman","id":342659,"avatar_url":"https://avatars.githubusercontent.com/u/342659?v=2","gravatar_id":"778bf608de535803bd5d708e724b9c04","url":"https://api.github.com/users/isaacfreeman","html_url":"https://github.com/isaacfreeman","followers_url":"https://api.github.com/users/isaacfreeman/followers","following_url":"https://api.github.com/users/isaacfreeman/following{/other_user}","gists_url":"https://api.github.com/users/isaacfreeman/gists{/gist_id}","starred_url":"https://api.github.com/users/isaacfreeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isaacfreeman/subscriptions","organizations_url":"https://api.github.com/users/isaacfreeman/orgs","repos_url":"https://api.github.com/users/isaacfreeman/repos","events_url":"https://api.github.com/users/isaacfreeman/events{/privacy}","received_events_url":"https://api.github.com/users/isaacfreeman/received_events","type":"User","site_admin":false},"body":"Disagree on this one. Having two separate groups with data-hooks makes it much easier to use Deface to modify the form. Having just had to deal with using Deface on views that didn't account for this in spree_static_content, this seems more important to me than being DRY.","created_at":"2014-08-28T23:30:00Z","updated_at":"2014-08-28T23:30:00Z","html_url":"https://github.com/isaacfreeman/spree/pull/2#discussion_r16874615","pull_request_url":"https://api.github.com/repos/isaacfreeman/spree/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/isaacfreeman/spree/pulls/comments/16874615"},"html":{"href":"https://github.com/isaacfreeman/spree/pull/2#discussion_r16874615"},"pull_request":{"href":"https://api.github.com/repos/isaacfreeman/spree/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/isaacfreeman/spree/pulls/2","id":20351754,"html_url":"https://github.com/isaacfreeman/spree/pull/2","diff_url":"https://github.com/isaacfreeman/spree/pull/2.diff","patch_url":"https://github.com/isaacfreeman/spree/pull/2.patch","issue_url":"https://api.github.com/repos/isaacfreeman/spree/issues/2","number":2,"state":"open","locked":false,"title":"5010 redesign product form","user":{"login":"isaacfreeman","id":342659,"avatar_url":"https://avatars.githubusercontent.com/u/342659?v=2","gravatar_id":"778bf608de535803bd5d708e724b9c04","url":"https://api.github.com/users/isaacfreeman","html_url":"https://github.com/isaacfreeman","followers_url":"https://api.github.com/users/isaacfreeman/followers","following_url":"https://api.github.com/users/isaacfreeman/following{/other_user}","gists_url":"https://api.github.com/users/isaacfreeman/gists{/gist_id}","starred_url":"https://api.github.com/users/isaacfreeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isaacfreeman/subscriptions","organizations_url":"https://api.github.com/users/isaacfreeman/orgs","repos_url":"https://api.github.com/users/isaacfreeman/repos","events_url":"https://api.github.com/users/isaacfreeman/events{/privacy}","received_events_url":"https://api.github.com/users/isaacfreeman/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-08-27T04:03:08Z","updated_at":"2014-08-28T23:30:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"de7e8a2be8de0208d96b74c2e4b08f0067167fe9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/isaacfreeman/spree/pulls/2/commits","review_comments_url":"https://api.github.com/repos/isaacfreeman/spree/pulls/2/comments","review_comment_url":"https://api.github.com/repos/isaacfreeman/spree/pulls/comments/{number}","comments_url":"https://api.github.com/repos/isaacfreeman/spree/issues/2/comments","statuses_url":"https://api.github.com/repos/isaacfreeman/spree/statuses/9d338d7999f4ce3901aa07eebf85f80a15497804","head":{"label":"isaacfreeman:5010-redesign-product-form","ref":"5010-redesign-product-form","sha":"9d338d7999f4ce3901aa07eebf85f80a15497804","user":{"login":"isaacfreeman","id":342659,"avatar_url":"https://avatars.githubusercontent.com/u/342659?v=2","gravatar_id":"778bf608de535803bd5d708e724b9c04","url":"https://api.github.com/users/isaacfreeman","html_url":"https://github.com/isaacfreeman","followers_url":"https://api.github.com/users/isaacfreeman/followers","following_url":"https://api.github.com/users/isaacfreeman/following{/other_user}","gists_url":"https://api.github.com/users/isaacfreeman/gists{/gist_id}","starred_url":"https://api.github.com/users/isaacfreeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isaacfreeman/subscriptions","organizations_url":"https://api.github.com/users/isaacfreeman/orgs","repos_url":"https://api.github.com/users/isaacfreeman/repos","events_url":"https://api.github.com/users/isaacfreeman/events{/privacy}","received_events_url":"https://api.github.com/users/isaacfreeman/received_events","type":"User","site_admin":false},"repo":{"id":19924246,"name":"spree","full_name":"isaacfreeman/spree","owner":{"login":"isaacfreeman","id":342659,"avatar_url":"https://avatars.githubusercontent.com/u/342659?v=2","gravatar_id":"778bf608de535803bd5d708e724b9c04","url":"https://api.github.com/users/isaacfreeman","html_url":"https://github.com/isaacfreeman","followers_url":"https://api.github.com/users/isaacfreeman/followers","following_url":"https://api.github.com/users/isaacfreeman/following{/other_user}","gists_url":"https://api.github.com/users/isaacfreeman/gists{/gist_id}","starred_url":"https://api.github.com/users/isaacfreeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isaacfreeman/subscriptions","organizations_url":"https://api.github.com/users/isaacfreeman/orgs","repos_url":"https://api.github.com/users/isaacfreeman/repos","events_url":"https://api.github.com/users/isaacfreeman/events{/privacy}","received_events_url":"https://api.github.com/users/isaacfreeman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/isaacfreeman/spree","description":"Spree is a complete open source e-commerce solution for Ruby on Rails.","fork":true,"url":"https://api.github.com/repos/isaacfreeman/spree","forks_url":"https://api.github.com/repos/isaacfreeman/spree/forks","keys_url":"https://api.github.com/repos/isaacfreeman/spree/keys{/key_id}","collaborators_url":"https://api.github.com/repos/isaacfreeman/spree/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/isaacfreeman/spree/teams","hooks_url":"https://api.github.com/repos/isaacfreeman/spree/hooks","issue_events_url":"https://api.github.com/repos/isaacfreeman/spree/issues/events{/number}","events_url":"https://api.github.com/repos/isaacfreeman/spree/events","assignees_url":"https://api.github.com/repos/isaacfreeman/spree/assignees{/user}","branches_url":"https://api.github.com/repos/isaacfreeman/spree/branches{/branch}","tags_url":"https://api.github.com/repos/isaacfreeman/spree/tags","blobs_url":"https://api.github.com/repos/isaacfreeman/spree/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/isaacfreeman/spree/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/isaacfreeman/spree/git/refs{/sha}","trees_url":"https://api.github.com/repos/isaacfreeman/spree/git/trees{/sha}","statuses_url":"https://api.github.com/repos/isaacfreeman/spree/statuses/{sha}","languages_url":"https://api.github.com/repos/isaacfreeman/spree/languages","stargazers_url":"https://api.github.com/repos/isaacfreeman/spree/stargazers","contributors_url":"https://api.github.com/repos/isaacfreeman/spree/contributors","subscribers_url":"https://api.github.com/repos/isaacfreeman/spree/subscribers","subscription_url":"https://api.github.com/repos/isaacfreeman/spree/subscription","commits_url":"https://api.github.com/repos/isaacfreeman/spree/commits{/sha}","git_commits_url":"https://api.github.com/repos/isaacfreeman/spree/git/commits{/sha}","comments_url":"https://api.github.com/repos/isaacfreeman/spree/comments{/number}","issue_comment_url":"https://api.github.com/repos/isaacfreeman/spree/issues/comments/{number}","contents_url":"https://api.github.com/repos/isaacfreeman/spree/contents/{+path}","compare_url":"https://api.github.com/repos/isaacfreeman/spree/compare/{base}...{head}","merges_url":"https://api.github.com/repos/isaacfreeman/spree/merges","archive_url":"https://api.github.com/repos/isaacfreeman/spree/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/isaacfreeman/spree/downloads","issues_url":"https://api.github.com/repos/isaacfreeman/spree/issues{/number}","pulls_url":"https://api.github.com/repos/isaacfreeman/spree/pulls{/number}","milestones_url":"https://api.github.com/repos/isaacfreeman/spree/milestones{/number}","notifications_url":"https://api.github.com/repos/isaacfreeman/spree/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/isaacfreeman/spree/labels{/name}","releases_url":"https://api.github.com/repos/isaacfreeman/spree/releases{/id}","created_at":"2014-05-19T00:09:28Z","updated_at":"2014-08-27T02:39:43Z","pushed_at":"2014-08-27T03:53:17Z","git_url":"git://github.com/isaacfreeman/spree.git","ssh_url":"git@github.com:isaacfreeman/spree.git","clone_url":"https://github.com/isaacfreeman/spree.git","svn_url":"https://github.com/isaacfreeman/spree","homepage":"http://spreecommerce.com","size":42082,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"isaacfreeman:master","ref":"master","sha":"9ac1faf0e22b3ea33ae2df60250cb8fee46cb5d6","user":{"login":"isaacfreeman","id":342659,"avatar_url":"https://avatars.githubusercontent.com/u/342659?v=2","gravatar_id":"778bf608de535803bd5d708e724b9c04","url":"https://api.github.com/users/isaacfreeman","html_url":"https://github.com/isaacfreeman","followers_url":"https://api.github.com/users/isaacfreeman/followers","following_url":"https://api.github.com/users/isaacfreeman/following{/other_user}","gists_url":"https://api.github.com/users/isaacfreeman/gists{/gist_id}","starred_url":"https://api.github.com/users/isaacfreeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isaacfreeman/subscriptions","organizations_url":"https://api.github.com/users/isaacfreeman/orgs","repos_url":"https://api.github.com/users/isaacfreeman/repos","events_url":"https://api.github.com/users/isaacfreeman/events{/privacy}","received_events_url":"https://api.github.com/users/isaacfreeman/received_events","type":"User","site_admin":false},"repo":{"id":19924246,"name":"spree","full_name":"isaacfreeman/spree","owner":{"login":"isaacfreeman","id":342659,"avatar_url":"https://avatars.githubusercontent.com/u/342659?v=2","gravatar_id":"778bf608de535803bd5d708e724b9c04","url":"https://api.github.com/users/isaacfreeman","html_url":"https://github.com/isaacfreeman","followers_url":"https://api.github.com/users/isaacfreeman/followers","following_url":"https://api.github.com/users/isaacfreeman/following{/other_user}","gists_url":"https://api.github.com/users/isaacfreeman/gists{/gist_id}","starred_url":"https://api.github.com/users/isaacfreeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isaacfreeman/subscriptions","organizations_url":"https://api.github.com/users/isaacfreeman/orgs","repos_url":"https://api.github.com/users/isaacfreeman/repos","events_url":"https://api.github.com/users/isaacfreeman/events{/privacy}","received_events_url":"https://api.github.com/users/isaacfreeman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/isaacfreeman/spree","description":"Spree is a complete open source e-commerce solution for Ruby on Rails.","fork":true,"url":"https://api.github.com/repos/isaacfreeman/spree","forks_url":"https://api.github.com/repos/isaacfreeman/spree/forks","keys_url":"https://api.github.com/repos/isaacfreeman/spree/keys{/key_id}","collaborators_url":"https://api.github.com/repos/isaacfreeman/spree/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/isaacfreeman/spree/teams","hooks_url":"https://api.github.com/repos/isaacfreeman/spree/hooks","issue_events_url":"https://api.github.com/repos/isaacfreeman/spree/issues/events{/number}","events_url":"https://api.github.com/repos/isaacfreeman/spree/events","assignees_url":"https://api.github.com/repos/isaacfreeman/spree/assignees{/user}","branches_url":"https://api.github.com/repos/isaacfreeman/spree/branches{/branch}","tags_url":"https://api.github.com/repos/isaacfreeman/spree/tags","blobs_url":"https://api.github.com/repos/isaacfreeman/spree/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/isaacfreeman/spree/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/isaacfreeman/spree/git/refs{/sha}","trees_url":"https://api.github.com/repos/isaacfreeman/spree/git/trees{/sha}","statuses_url":"https://api.github.com/repos/isaacfreeman/spree/statuses/{sha}","languages_url":"https://api.github.com/repos/isaacfreeman/spree/languages","stargazers_url":"https://api.github.com/repos/isaacfreeman/spree/stargazers","contributors_url":"https://api.github.com/repos/isaacfreeman/spree/contributors","subscribers_url":"https://api.github.com/repos/isaacfreeman/spree/subscribers","subscription_url":"https://api.github.com/repos/isaacfreeman/spree/subscription","commits_url":"https://api.github.com/repos/isaacfreeman/spree/commits{/sha}","git_commits_url":"https://api.github.com/repos/isaacfreeman/spree/git/commits{/sha}","comments_url":"https://api.github.com/repos/isaacfreeman/spree/comments{/number}","issue_comment_url":"https://api.github.com/repos/isaacfreeman/spree/issues/comments/{number}","contents_url":"https://api.github.com/repos/isaacfreeman/spree/contents/{+path}","compare_url":"https://api.github.com/repos/isaacfreeman/spree/compare/{base}...{head}","merges_url":"https://api.github.com/repos/isaacfreeman/spree/merges","archive_url":"https://api.github.com/repos/isaacfreeman/spree/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/isaacfreeman/spree/downloads","issues_url":"https://api.github.com/repos/isaacfreeman/spree/issues{/number}","pulls_url":"https://api.github.com/repos/isaacfreeman/spree/pulls{/number}","milestones_url":"https://api.github.com/repos/isaacfreeman/spree/milestones{/number}","notifications_url":"https://api.github.com/repos/isaacfreeman/spree/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/isaacfreeman/spree/labels{/name}","releases_url":"https://api.github.com/repos/isaacfreeman/spree/releases{/id}","created_at":"2014-05-19T00:09:28Z","updated_at":"2014-08-27T02:39:43Z","pushed_at":"2014-08-27T03:53:17Z","git_url":"git://github.com/isaacfreeman/spree.git","ssh_url":"git@github.com:isaacfreeman/spree.git","clone_url":"https://github.com/isaacfreeman/spree.git","svn_url":"https://github.com/isaacfreeman/spree","homepage":"http://spreecommerce.com","size":42082,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/isaacfreeman/spree/pulls/2"},"html":{"href":"https://github.com/isaacfreeman/spree/pull/2"},"issue":{"href":"https://api.github.com/repos/isaacfreeman/spree/issues/2"},"comments":{"href":"https://api.github.com/repos/isaacfreeman/spree/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/isaacfreeman/spree/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/isaacfreeman/spree/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/isaacfreeman/spree/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/isaacfreeman/spree/statuses/9d338d7999f4ce3901aa07eebf85f80a15497804"}}}}