GitHub PullRequestReviewCommentEvent at 2014-08-08 21:00:13
Repository: juju-gui
Actor: hatched
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/juju/juju-gui/pulls/comments/16016185","id":16016185,"diff_hunk":"@@ -634,11 +636,20 @@ YUI.add('deployer-bar', function(Y) {\n           case '_add_unit':\n             // This can be either a ghost or a real deployed service.\n             service = this._getServiceByUnitId(command.options.modelId);\n-            changes.addUnits.push({\n-              icon: service.get('icon'),\n-              serviceName: service.get('name'),\n-              numUnits: args[1]\n-            });\n+            // XXX kadams54 2014-08-08: this is a temporary hack right now\n+            // because the ECS doesn't batch operations. Add 10 units and\n+            // you'll get 10 log entries with numUnits set to 1. Once\n+            // numUnits reflects the actual number being added, we can\n+            // remove this hack.\n+            name = service.get('name');\n+            unitCount[name] = unitCount[name] ? unitCount[name] + 1 : 1;\n+            if (unitCount[name] === 1) {\n+              changes.addUnits.push({\n+                icon: service.get('icon'),\n+                serviceName: name,\n+                numUnits: args[1]\n+              });","path":"app/widgets/deployer-bar.js","position":39,"original_position":39,"commit_id":"f9e2b92b094f46ff6f432e9ea56bb87f53587ed6","original_commit_id":"f9e2b92b094f46ff6f432e9ea56bb87f53587ed6","user":{"login":"hatched","id":532033,"avatar_url":"https://avatars.githubusercontent.com/u/532033?v=2","gravatar_id":"e95b5dccab0d75eadaccfe04bfd7ad59","url":"https://api.github.com/users/hatched","html_url":"https://github.com/hatched","followers_url":"https://api.github.com/users/hatched/followers","following_url":"https://api.github.com/users/hatched/following{/other_user}","gists_url":"https://api.github.com/users/hatched/gists{/gist_id}","starred_url":"https://api.github.com/users/hatched/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hatched/subscriptions","organizations_url":"https://api.github.com/users/hatched/orgs","repos_url":"https://api.github.com/users/hatched/repos","events_url":"https://api.github.com/users/hatched/events{/privacy}","received_events_url":"https://api.github.com/users/hatched/received_events","type":"User","site_admin":false},"body":"using my suggested approach you'd also need to modify the template so feel free to leave your code as is :) The hacks are at least now contained to a single method.","created_at":"2014-08-08T21:00:13Z","updated_at":"2014-08-08T21:00:13Z","html_url":"https://github.com/juju/juju-gui/pull/485#discussion_r16016185","pull_request_url":"https://api.github.com/repos/juju/juju-gui/pulls/485","_links":{"self":{"href":"https://api.github.com/repos/juju/juju-gui/pulls/comments/16016185"},"html":{"href":"https://github.com/juju/juju-gui/pull/485#discussion_r16016185"},"pull_request":{"href":"https://api.github.com/repos/juju/juju-gui/pulls/485"}}},"pull_request":{"url":"https://api.github.com/repos/juju/juju-gui/pulls/485","id":19545984,"html_url":"https://github.com/juju/juju-gui/pull/485","diff_url":"https://github.com/juju/juju-gui/pull/485.diff","patch_url":"https://github.com/juju/juju-gui/pull/485.patch","issue_url":"https://api.github.com/repos/juju/juju-gui/issues/485","number":485,"state":"open","title":"Consolidate added units in deploy summary.","user":{"login":"kadams54","id":378036,"avatar_url":"https://avatars.githubusercontent.com/u/378036?v=2","gravatar_id":"0e91f44f19b85a9193e5ec61f4fcb5f8","url":"https://api.github.com/users/kadams54","html_url":"https://github.com/kadams54","followers_url":"https://api.github.com/users/kadams54/followers","following_url":"https://api.github.com/users/kadams54/following{/other_user}","gists_url":"https://api.github.com/users/kadams54/gists{/gist_id}","starred_url":"https://api.github.com/users/kadams54/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kadams54/subscriptions","organizations_url":"https://api.github.com/users/kadams54/orgs","repos_url":"https://api.github.com/users/kadams54/repos","events_url":"https://api.github.com/users/kadams54/events{/privacy}","received_events_url":"https://api.github.com/users/kadams54/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-08-08T19:12:59Z","updated_at":"2014-08-08T21:00:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"09c0527d2d5ffe9586477f292f16d859d5804f44","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/juju/juju-gui/pulls/485/commits","review_comments_url":"https://api.github.com/repos/juju/juju-gui/pulls/485/comments","review_comment_url":"https://api.github.com/repos/juju/juju-gui/pulls/comments/{number}","comments_url":"https://api.github.com/repos/juju/juju-gui/issues/485/comments","statuses_url":"https://api.github.com/repos/juju/juju-gui/statuses/f9e2b92b094f46ff6f432e9ea56bb87f53587ed6","head":{"label":"kadams54:debounce-deployer-bar","ref":"debounce-deployer-bar","sha":"f9e2b92b094f46ff6f432e9ea56bb87f53587ed6","user":{"login":"kadams54","id":378036,"avatar_url":"https://avatars.githubusercontent.com/u/378036?v=2","gravatar_id":"0e91f44f19b85a9193e5ec61f4fcb5f8","url":"https://api.github.com/users/kadams54","html_url":"https://github.com/kadams54","followers_url":"https://api.github.com/users/kadams54/followers","following_url":"https://api.github.com/users/kadams54/following{/other_user}","gists_url":"https://api.github.com/users/kadams54/gists{/gist_id}","starred_url":"https://api.github.com/users/kadams54/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kadams54/subscriptions","organizations_url":"https://api.github.com/users/kadams54/orgs","repos_url":"https://api.github.com/users/kadams54/repos","events_url":"https://api.github.com/users/kadams54/events{/privacy}","received_events_url":"https://api.github.com/users/kadams54/received_events","type":"User","site_admin":false},"repo":{"id":17426336,"name":"juju-gui","full_name":"kadams54/juju-gui","owner":{"login":"kadams54","id":378036,"avatar_url":"https://avatars.githubusercontent.com/u/378036?v=2","gravatar_id":"0e91f44f19b85a9193e5ec61f4fcb5f8","url":"https://api.github.com/users/kadams54","html_url":"https://github.com/kadams54","followers_url":"https://api.github.com/users/kadams54/followers","following_url":"https://api.github.com/users/kadams54/following{/other_user}","gists_url":"https://api.github.com/users/kadams54/gists{/gist_id}","starred_url":"https://api.github.com/users/kadams54/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kadams54/subscriptions","organizations_url":"https://api.github.com/users/kadams54/orgs","repos_url":"https://api.github.com/users/kadams54/repos","events_url":"https://api.github.com/users/kadams54/events{/privacy}","received_events_url":"https://api.github.com/users/kadams54/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kadams54/juju-gui","description":"Juju-GUI is a web-based GUI for Juju <https://juju.ubuntu.com/>.","fork":true,"url":"https://api.github.com/repos/kadams54/juju-gui","forks_url":"https://api.github.com/repos/kadams54/juju-gui/forks","keys_url":"https://api.github.com/repos/kadams54/juju-gui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kadams54/juju-gui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kadams54/juju-gui/teams","hooks_url":"https://api.github.com/repos/kadams54/juju-gui/hooks","issue_events_url":"https://api.github.com/repos/kadams54/juju-gui/issues/events{/number}","events_url":"https://api.github.com/repos/kadams54/juju-gui/events","assignees_url":"https://api.github.com/repos/kadams54/juju-gui/assignees{/user}","branches_url":"https://api.github.com/repos/kadams54/juju-gui/branches{/branch}","tags_url":"https://api.github.com/repos/kadams54/juju-gui/tags","blobs_url":"https://api.github.com/repos/kadams54/juju-gui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kadams54/juju-gui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kadams54/juju-gui/git/refs{/sha}","trees_url":"https://api.github.com/repos/kadams54/juju-gui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kadams54/juju-gui/statuses/{sha}","languages_url":"https://api.github.com/repos/kadams54/juju-gui/languages","stargazers_url":"https://api.github.com/repos/kadams54/juju-gui/stargazers","contributors_url":"https://api.github.com/repos/kadams54/juju-gui/contributors","subscribers_url":"https://api.github.com/repos/kadams54/juju-gui/subscribers","subscription_url":"https://api.github.com/repos/kadams54/juju-gui/subscription","commits_url":"https://api.github.com/repos/kadams54/juju-gui/commits{/sha}","git_commits_url":"https://api.github.com/repos/kadams54/juju-gui/git/commits{/sha}","comments_url":"https://api.github.com/repos/kadams54/juju-gui/comments{/number}","issue_comment_url":"https://api.github.com/repos/kadams54/juju-gui/issues/comments/{number}","contents_url":"https://api.github.com/repos/kadams54/juju-gui/contents/{+path}","compare_url":"https://api.github.com/repos/kadams54/juju-gui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kadams54/juju-gui/merges","archive_url":"https://api.github.com/repos/kadams54/juju-gui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kadams54/juju-gui/downloads","issues_url":"https://api.github.com/repos/kadams54/juju-gui/issues{/number}","pulls_url":"https://api.github.com/repos/kadams54/juju-gui/pulls{/number}","milestones_url":"https://api.github.com/repos/kadams54/juju-gui/milestones{/number}","notifications_url":"https://api.github.com/repos/kadams54/juju-gui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kadams54/juju-gui/labels{/name}","releases_url":"https://api.github.com/repos/kadams54/juju-gui/releases{/id}","created_at":"2014-03-05T03:12:51Z","updated_at":"2014-06-25T17:51:45Z","pushed_at":"2014-08-08T20:44:41Z","git_url":"git://github.com/kadams54/juju-gui.git","ssh_url":"git@github.com:kadams54/juju-gui.git","clone_url":"https://github.com/kadams54/juju-gui.git","svn_url":"https://github.com/kadams54/juju-gui","homepage":null,"size":100460,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"juju:develop","ref":"develop","sha":"d98763a18ee5798338c4778c0c3bfa6aa9afc7de","user":{"login":"juju","id":4604548,"avatar_url":"https://avatars.githubusercontent.com/u/4604548?v=2","gravatar_id":"b095d1e26e5705abe0ad2de7d87aac2e","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"repo":{"id":14960387,"name":"juju-gui","full_name":"juju/juju-gui","owner":{"login":"juju","id":4604548,"avatar_url":"https://avatars.githubusercontent.com/u/4604548?v=2","gravatar_id":"b095d1e26e5705abe0ad2de7d87aac2e","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/juju/juju-gui","description":"Juju-GUI is a web-based GUI for Juju <https://juju.ubuntu.com/>.","fork":false,"url":"https://api.github.com/repos/juju/juju-gui","forks_url":"https://api.github.com/repos/juju/juju-gui/forks","keys_url":"https://api.github.com/repos/juju/juju-gui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juju/juju-gui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juju/juju-gui/teams","hooks_url":"https://api.github.com/repos/juju/juju-gui/hooks","issue_events_url":"https://api.github.com/repos/juju/juju-gui/issues/events{/number}","events_url":"https://api.github.com/repos/juju/juju-gui/events","assignees_url":"https://api.github.com/repos/juju/juju-gui/assignees{/user}","branches_url":"https://api.github.com/repos/juju/juju-gui/branches{/branch}","tags_url":"https://api.github.com/repos/juju/juju-gui/tags","blobs_url":"https://api.github.com/repos/juju/juju-gui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juju/juju-gui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juju/juju-gui/git/refs{/sha}","trees_url":"https://api.github.com/repos/juju/juju-gui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juju/juju-gui/statuses/{sha}","languages_url":"https://api.github.com/repos/juju/juju-gui/languages","stargazers_url":"https://api.github.com/repos/juju/juju-gui/stargazers","contributors_url":"https://api.github.com/repos/juju/juju-gui/contributors","subscribers_url":"https://api.github.com/repos/juju/juju-gui/subscribers","subscription_url":"https://api.github.com/repos/juju/juju-gui/subscription","commits_url":"https://api.github.com/repos/juju/juju-gui/commits{/sha}","git_commits_url":"https://api.github.com/repos/juju/juju-gui/git/commits{/sha}","comments_url":"https://api.github.com/repos/juju/juju-gui/comments{/number}","issue_comment_url":"https://api.github.com/repos/juju/juju-gui/issues/comments/{number}","contents_url":"https://api.github.com/repos/juju/juju-gui/contents/{+path}","compare_url":"https://api.github.com/repos/juju/juju-gui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juju/juju-gui/merges","archive_url":"https://api.github.com/repos/juju/juju-gui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juju/juju-gui/downloads","issues_url":"https://api.github.com/repos/juju/juju-gui/issues{/number}","pulls_url":"https://api.github.com/repos/juju/juju-gui/pulls{/number}","milestones_url":"https://api.github.com/repos/juju/juju-gui/milestones{/number}","notifications_url":"https://api.github.com/repos/juju/juju-gui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juju/juju-gui/labels{/name}","releases_url":"https://api.github.com/repos/juju/juju-gui/releases{/id}","created_at":"2013-12-05T17:15:48Z","updated_at":"2014-07-16T19:37:12Z","pushed_at":"2014-08-08T15:17:51Z","git_url":"git://github.com/juju/juju-gui.git","ssh_url":"git@github.com:juju/juju-gui.git","clone_url":"https://github.com/juju/juju-gui.git","svn_url":"https://github.com/juju/juju-gui","homepage":null,"size":108804,"stargazers_count":31,"watchers_count":31,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":30,"mirror_url":null,"open_issues_count":1,"forks":30,"open_issues":1,"watchers":31,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/juju/juju-gui/pulls/485"},"html":{"href":"https://github.com/juju/juju-gui/pull/485"},"issue":{"href":"https://api.github.com/repos/juju/juju-gui/issues/485"},"comments":{"href":"https://api.github.com/repos/juju/juju-gui/issues/485/comments"},"review_comments":{"href":"https://api.github.com/repos/juju/juju-gui/pulls/485/comments"},"review_comment":{"href":"https://api.github.com/repos/juju/juju-gui/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/juju/juju-gui/pulls/485/commits"},"statuses":{"href":"https://api.github.com/repos/juju/juju-gui/statuses/f9e2b92b094f46ff6f432e9ea56bb87f53587ed6"}}}}