GitHub PullRequestReviewCommentEvent at 2014-08-06 20:07:33
Repository: puppet
Actor: peterhuene
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/15899923","id":15899923,"diff_hunk":"@@ -81,6 +81,7 @@\n       resource[:ensure] = :installed\n       resource[:install_options] = ['-t', {'-x' => 'expackage'}]\n \n+      provider.expects(:yum).with('-d', '0', '-e', '0', '-y', ['-t', '-x=expackage'], :list, name)","path":"spec/unit/provider/package/yum_spec.rb","position":4,"original_position":4,"commit_id":"d35f408ff8a42a0062ff4c41fedc8a517aca9581","original_commit_id":"d35f408ff8a42a0062ff4c41fedc8a517aca9581","user":{"login":"peterhuene","id":509666,"avatar_url":"https://avatars.githubusercontent.com/u/509666?v=2","gravatar_id":"31a910d347dac0a0b6a433e192cf3aab","url":"https://api.github.com/users/peterhuene","html_url":"https://github.com/peterhuene","followers_url":"https://api.github.com/users/peterhuene/followers","following_url":"https://api.github.com/users/peterhuene/following{/other_user}","gists_url":"https://api.github.com/users/peterhuene/gists{/gist_id}","starred_url":"https://api.github.com/users/peterhuene/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterhuene/subscriptions","organizations_url":"https://api.github.com/users/peterhuene/orgs","repos_url":"https://api.github.com/users/peterhuene/repos","events_url":"https://api.github.com/users/peterhuene/events{/privacy}","received_events_url":"https://api.github.com/users/peterhuene/received_events","type":"User","site_admin":false},"body":"Confirmed that execution of a command will properly flatten (and to_s) if given an array.  I don't prefer one or the other, but I think `:list` should be consistent with `:install`.  Thoughts?","created_at":"2014-08-06T20:07:33Z","updated_at":"2014-08-06T20:07:33Z","html_url":"https://github.com/puppetlabs/puppet/pull/2934#discussion_r15899923","pull_request_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/2934","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/15899923"},"html":{"href":"https://github.com/puppetlabs/puppet/pull/2934#discussion_r15899923"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/2934"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppet/pulls/2934","id":19297636,"html_url":"https://github.com/puppetlabs/puppet/pull/2934","diff_url":"https://github.com/puppetlabs/puppet/pull/2934.diff","patch_url":"https://github.com/puppetlabs/puppet/pull/2934.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppet/issues/2934","number":2934,"state":"open","title":"(PUP-2971) Fix yum package provider missing install_options for list.","user":{"login":"peterhuene","id":509666,"avatar_url":"https://avatars.githubusercontent.com/u/509666?v=2","gravatar_id":"31a910d347dac0a0b6a433e192cf3aab","url":"https://api.github.com/users/peterhuene","html_url":"https://github.com/peterhuene","followers_url":"https://api.github.com/users/peterhuene/followers","following_url":"https://api.github.com/users/peterhuene/following{/other_user}","gists_url":"https://api.github.com/users/peterhuene/gists{/gist_id}","starred_url":"https://api.github.com/users/peterhuene/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterhuene/subscriptions","organizations_url":"https://api.github.com/users/peterhuene/orgs","repos_url":"https://api.github.com/users/peterhuene/repos","events_url":"https://api.github.com/users/peterhuene/events{/privacy}","received_events_url":"https://api.github.com/users/peterhuene/received_events","type":"User","site_admin":false},"body":"When executing the list command to filter virtual packages (when\r\nallow_virtual is false or nil), the yum package provider was not passing\r\ndown the install options to the list command.  For users passing options\r\nlike --enablerepo, this prevents the packages from being discovered and\r\nthe list command fails.\r\n\r\nThe fix is to properly pass down the install options when executing the\r\nlist command.","created_at":"2014-08-04T18:09:55Z","updated_at":"2014-08-06T20:07:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e84ceed8ae5bdfcfc5e6510ec4752d53844e727a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/2934/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/2934/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/{number}","comments_url":"https://api.github.com/repos/puppetlabs/puppet/issues/2934/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppet/statuses/d35f408ff8a42a0062ff4c41fedc8a517aca9581","head":{"label":"peterhuene:pup/2971","ref":"pup/2971","sha":"d35f408ff8a42a0062ff4c41fedc8a517aca9581","user":{"login":"peterhuene","id":509666,"avatar_url":"https://avatars.githubusercontent.com/u/509666?v=2","gravatar_id":"31a910d347dac0a0b6a433e192cf3aab","url":"https://api.github.com/users/peterhuene","html_url":"https://github.com/peterhuene","followers_url":"https://api.github.com/users/peterhuene/followers","following_url":"https://api.github.com/users/peterhuene/following{/other_user}","gists_url":"https://api.github.com/users/peterhuene/gists{/gist_id}","starred_url":"https://api.github.com/users/peterhuene/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterhuene/subscriptions","organizations_url":"https://api.github.com/users/peterhuene/orgs","repos_url":"https://api.github.com/users/peterhuene/repos","events_url":"https://api.github.com/users/peterhuene/events{/privacy}","received_events_url":"https://api.github.com/users/peterhuene/received_events","type":"User","site_admin":false},"repo":{"id":14322742,"name":"puppet","full_name":"peterhuene/puppet","owner":{"login":"peterhuene","id":509666,"avatar_url":"https://avatars.githubusercontent.com/u/509666?v=2","gravatar_id":"31a910d347dac0a0b6a433e192cf3aab","url":"https://api.github.com/users/peterhuene","html_url":"https://github.com/peterhuene","followers_url":"https://api.github.com/users/peterhuene/followers","following_url":"https://api.github.com/users/peterhuene/following{/other_user}","gists_url":"https://api.github.com/users/peterhuene/gists{/gist_id}","starred_url":"https://api.github.com/users/peterhuene/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterhuene/subscriptions","organizations_url":"https://api.github.com/users/peterhuene/orgs","repos_url":"https://api.github.com/users/peterhuene/repos","events_url":"https://api.github.com/users/peterhuene/events{/privacy}","received_events_url":"https://api.github.com/users/peterhuene/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/peterhuene/puppet","description":"Server automation framework and application","fork":true,"url":"https://api.github.com/repos/peterhuene/puppet","forks_url":"https://api.github.com/repos/peterhuene/puppet/forks","keys_url":"https://api.github.com/repos/peterhuene/puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/peterhuene/puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/peterhuene/puppet/teams","hooks_url":"https://api.github.com/repos/peterhuene/puppet/hooks","issue_events_url":"https://api.github.com/repos/peterhuene/puppet/issues/events{/number}","events_url":"https://api.github.com/repos/peterhuene/puppet/events","assignees_url":"https://api.github.com/repos/peterhuene/puppet/assignees{/user}","branches_url":"https://api.github.com/repos/peterhuene/puppet/branches{/branch}","tags_url":"https://api.github.com/repos/peterhuene/puppet/tags","blobs_url":"https://api.github.com/repos/peterhuene/puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/peterhuene/puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/peterhuene/puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/peterhuene/puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/peterhuene/puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/peterhuene/puppet/languages","stargazers_url":"https://api.github.com/repos/peterhuene/puppet/stargazers","contributors_url":"https://api.github.com/repos/peterhuene/puppet/contributors","subscribers_url":"https://api.github.com/repos/peterhuene/puppet/subscribers","subscription_url":"https://api.github.com/repos/peterhuene/puppet/subscription","commits_url":"https://api.github.com/repos/peterhuene/puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/peterhuene/puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/peterhuene/puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/peterhuene/puppet/issues/comments/{number}","contents_url":"https://api.github.com/repos/peterhuene/puppet/contents/{+path}","compare_url":"https://api.github.com/repos/peterhuene/puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/peterhuene/puppet/merges","archive_url":"https://api.github.com/repos/peterhuene/puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/peterhuene/puppet/downloads","issues_url":"https://api.github.com/repos/peterhuene/puppet/issues{/number}","pulls_url":"https://api.github.com/repos/peterhuene/puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/peterhuene/puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/peterhuene/puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/peterhuene/puppet/labels{/name}","releases_url":"https://api.github.com/repos/peterhuene/puppet/releases{/id}","created_at":"2013-11-12T04:55:07Z","updated_at":"2014-07-24T18:36:20Z","pushed_at":"2014-08-04T18:09:02Z","git_url":"git://github.com/peterhuene/puppet.git","ssh_url":"git@github.com:peterhuene/puppet.git","clone_url":"https://github.com/peterhuene/puppet.git","svn_url":"https://github.com/peterhuene/puppet","homepage":"http://www.puppetlabs.com/puppet/introduction/","size":41724,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"b7ce5e6e4d90b84b45479d656af569ab7bdcaf7a","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=2","gravatar_id":"eb454c2139c156db7c8266a875519a1f","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":910744,"name":"puppet","full_name":"puppetlabs/puppet","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=2","gravatar_id":"eb454c2139c156db7c8266a875519a1f","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/puppet","description":"Server automation framework and application","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppet","forks_url":"https://api.github.com/repos/puppetlabs/puppet/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppet/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppet/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppet/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppet/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppet/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppet/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppet/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppet/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppet/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppet/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppet/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppet/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppet/issues/comments/{number}","contents_url":"https://api.github.com/repos/puppetlabs/puppet/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppet/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppet/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppet/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppet/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppet/releases{/id}","created_at":"2010-09-14T19:26:44Z","updated_at":"2014-08-06T16:46:27Z","pushed_at":"2014-08-06T17:38:09Z","git_url":"git://github.com/puppetlabs/puppet.git","ssh_url":"git@github.com:puppetlabs/puppet.git","clone_url":"https://github.com/puppetlabs/puppet.git","svn_url":"https://github.com/puppetlabs/puppet","homepage":"http://www.puppetlabs.com/puppet/introduction/","size":106413,"stargazers_count":2507,"watchers_count":2507,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":1085,"mirror_url":null,"open_issues_count":28,"forks":1085,"open_issues":28,"watchers":2507,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/2934"},"html":{"href":"https://github.com/puppetlabs/puppet/pull/2934"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppet/issues/2934"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppet/issues/2934/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/2934/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/2934/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppet/statuses/d35f408ff8a42a0062ff4c41fedc8a517aca9581"}}}}