GitHub PullRequestReviewCommentEvent at 2014-02-10 07:46:18
Repository: mixxx
Actor: daschuer
Payload: {"comment":{"url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments/9575875","id":9575875,"diff_hunk":"@@ -84,36 +94,62 @@\n #endif\n \n     // Crossfader\n-    m_pCrossfader = new ControlPotmeter(ConfigKey(group, \"crossfader\"), -1., 1.);\n+    m_pCrossfader = new ControlPotmeter(ConfigKey(m_sGroup, \"crossfader\"), -1., 1.);\n \n     // Balance\n-    m_pBalance = new ControlPotmeter(ConfigKey(group, \"balance\"), -1., 1.);\n+    m_pBalance = new ControlPotmeter(ConfigKey(m_sGroup, \"balance\"), -1., 1.);\n \n     // Master volume\n-    m_pMasterVolume = new ControlLogpotmeter(ConfigKey(group, \"volume\"), 5.);\n+    m_pMasterVolume = new ControlLogpotmeter(ConfigKey(m_sGroup, \"volume\"), 5.);\n \n     // Clipping\n-    m_pClipping = new EngineClipping(group);\n+    m_pClipping = new EngineClipping(m_sGroup);\n \n     // VU meter:\n-    m_pVumeter = new EngineVuMeter(group);\n+    m_pVumeter = new EngineVuMeter(m_sGroup);\n \n     // Headphone volume\n-    m_pHeadVolume = new ControlLogpotmeter(ConfigKey(group, \"headVolume\"), 5.);\n+    m_pHeadVolume = new ControlLogpotmeter(ConfigKey(m_sGroup, \"headVolume\"), 5.);\n \n     // Headphone mix (left/right)\n-    m_pHeadMix = new ControlPotmeter(ConfigKey(group, \"headMix\"),-1.,1.);\n+    m_pHeadMix = new ControlPotmeter(ConfigKey(m_sGroup, \"headMix\"),-1.,1.);\n     m_pHeadMix->setDefaultValue(-1.);\n     m_pHeadMix->set(-1.);\n \n+    // Channels set with the bypass flag should not be mixed with the headphone\n+    // signal.\n+    m_headphoneGain.setBypassGain(0.0);\n+\n     // Master / Headphone split-out mode (for devices with only one output).\n-    m_pHeadSplitEnabled = new ControlPushButton(ConfigKey(group, \"headSplit\"));\n+    m_pHeadSplitEnabled = new ControlPushButton(ConfigKey(m_sGroup, \"headSplit\"));\n     m_pHeadSplitEnabled->setButtonMode(ControlPushButton::TOGGLE);\n     m_pHeadSplitEnabled->set(0.0);\n \n     // Headphone Clipping\n     m_pHeadClipping = new EngineClipping(\"\");\n \n+    m_pSideChainCompressor = new EngineSideChainCompressor(m_pConfig, m_sGroup);\n+    // Set compressor threshold to .5 of full volume, strength .75, and .1\n+    // second attack and 1 sec decay.\n+    m_pDuckStrength = new ControlPotmeter(ConfigKey(m_sGroup, \"duckStrength\"), 0.0, 1.0);","path":"src/engine/enginemaster.cpp","position":114,"original_position":114,"commit_id":"fd7a13f1aa0333083d0a3fbe4abf83f0a7227749","original_commit_id":"fd7a13f1aa0333083d0a3fbe4abf83f0a7227749","user":{"login":"daschuer","id":1777442,"avatar_url":"https://gravatar.com/avatar/4ad11d074e0bd254af763102c6824efc?d=https%3A%2F%2Fidenticons.github.com%2Ff06c1247c50a2d28103ecc47640c475b.png&r=x","gravatar_id":"4ad11d074e0bd254af763102c6824efc","url":"https://api.github.com/users/daschuer","html_url":"https://github.com/daschuer","followers_url":"https://api.github.com/users/daschuer/followers","following_url":"https://api.github.com/users/daschuer/following{/other_user}","gists_url":"https://api.github.com/users/daschuer/gists{/gist_id}","starred_url":"https://api.github.com/users/daschuer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daschuer/subscriptions","organizations_url":"https://api.github.com/users/daschuer/orgs","repos_url":"https://api.github.com/users/daschuer/repos","events_url":"https://api.github.com/users/daschuer/events{/privacy}","received_events_url":"https://api.github.com/users/daschuer/received_events","type":"User","site_admin":false},"body":"Ah sorry, now I got the problem, you have made a universal EngineSideChainCompressor. \r\nWhat about subclass it to EngineMicDucking and collect the related COs there. ","created_at":"2014-02-10T07:46:18Z","updated_at":"2014-02-10T07:46:18Z","html_url":"https://github.com/mixxxdj/mixxx/pull/172#discussion_r9575875","pull_request_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/172","_links":{"self":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments/9575875"},"html":{"href":"https://github.com/mixxxdj/mixxx/pull/172#discussion_r9575875"},"pull_request":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/172"}}}}