GitHub PullRequestReviewCommentEvent at 2014-12-13 22:14:09
Repository: ffi-gdbm
Actor: presidentbeef
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/presidentbeef/ffi-gdbm/pulls/comments/21791835","id":21791835,"diff_hunk":"@@ -149,11 +149,17 @@ def self.each_pair(file)\n \n   #Iterates over each key in the _file_.\n   def self.each_key(file)\n+    keys = []","path":"lib/gdbm.rb","position":4,"original_position":4,"commit_id":"2797aecb31c4b71436d0439d8770c8176254516f","original_commit_id":"2797aecb31c4b71436d0439d8770c8176254516f","user":{"login":"presidentbeef","id":75613,"avatar_url":"https://avatars.githubusercontent.com/u/75613?v=3","gravatar_id":"","url":"https://api.github.com/users/presidentbeef","html_url":"https://github.com/presidentbeef","followers_url":"https://api.github.com/users/presidentbeef/followers","following_url":"https://api.github.com/users/presidentbeef/following{/other_user}","gists_url":"https://api.github.com/users/presidentbeef/gists{/gist_id}","starred_url":"https://api.github.com/users/presidentbeef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/presidentbeef/subscriptions","organizations_url":"https://api.github.com/users/presidentbeef/orgs","repos_url":"https://api.github.com/users/presidentbeef/repos","events_url":"https://api.github.com/users/presidentbeef/events{/privacy}","received_events_url":"https://api.github.com/users/presidentbeef/received_events","type":"User","site_admin":false},"body":"Any reason to not check `block_given?` at the beginning and return `self.keys.each`? Seems simpler.","created_at":"2014-12-13T22:14:09Z","updated_at":"2014-12-13T22:14:09Z","html_url":"https://github.com/presidentbeef/ffi-gdbm/pull/2#discussion_r21791835","pull_request_url":"https://api.github.com/repos/presidentbeef/ffi-gdbm/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/presidentbeef/ffi-gdbm/pulls/comments/21791835"},"html":{"href":"https://github.com/presidentbeef/ffi-gdbm/pull/2#discussion_r21791835"},"pull_request":{"href":"https://api.github.com/repos/presidentbeef/ffi-gdbm/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/presidentbeef/ffi-gdbm/pulls/2","id":26020007,"html_url":"https://github.com/presidentbeef/ffi-gdbm/pull/2","diff_url":"https://github.com/presidentbeef/ffi-gdbm/pull/2.diff","patch_url":"https://github.com/presidentbeef/ffi-gdbm/pull/2.patch","issue_url":"https://api.github.com/repos/presidentbeef/ffi-gdbm/issues/2","number":2,"state":"open","locked":false,"title":"Return an Enumerator for #each_key without a block","user":{"login":"joeyates","id":137838,"avatar_url":"https://avatars.githubusercontent.com/u/137838?v=3","gravatar_id":"","url":"https://api.github.com/users/joeyates","html_url":"https://github.com/joeyates","followers_url":"https://api.github.com/users/joeyates/followers","following_url":"https://api.github.com/users/joeyates/following{/other_user}","gists_url":"https://api.github.com/users/joeyates/gists{/gist_id}","starred_url":"https://api.github.com/users/joeyates/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joeyates/subscriptions","organizations_url":"https://api.github.com/users/joeyates/orgs","repos_url":"https://api.github.com/users/joeyates/repos","events_url":"https://api.github.com/users/joeyates/events{/privacy}","received_events_url":"https://api.github.com/users/joeyates/received_events","type":"User","site_admin":false},"body":"* Makes the implementation more conformant with MRI,\r\n* I've made a Pull Request to MRI Ruby (ruby/ruby#783) adding a test for the same case,\r\n* With Ruby >= 2 it would be etter to return a lazy enumerator.","created_at":"2014-12-13T10:39:43Z","updated_at":"2014-12-13T22:14:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"29f9de078f8ef577aaf27014ddcd937c97f84a08","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/presidentbeef/ffi-gdbm/pulls/2/commits","review_comments_url":"https://api.github.com/repos/presidentbeef/ffi-gdbm/pulls/2/comments","review_comment_url":"https://api.github.com/repos/presidentbeef/ffi-gdbm/pulls/comments/{number}","comments_url":"https://api.github.com/repos/presidentbeef/ffi-gdbm/issues/2/comments","statuses_url":"https://api.github.com/repos/presidentbeef/ffi-gdbm/statuses/2797aecb31c4b71436d0439d8770c8176254516f","head":{"label":"joeyates:return_enumerator_for_each_key_without_block","ref":"return_enumerator_for_each_key_without_block","sha":"2797aecb31c4b71436d0439d8770c8176254516f","user":{"login":"joeyates","id":137838,"avatar_url":"https://avatars.githubusercontent.com/u/137838?v=3","gravatar_id":"","url":"https://api.github.com/users/joeyates","html_url":"https://github.com/joeyates","followers_url":"https://api.github.com/users/joeyates/followers","following_url":"https://api.github.com/users/joeyates/following{/other_user}","gists_url":"https://api.github.com/users/joeyates/gists{/gist_id}","starred_url":"https://api.github.com/users/joeyates/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joeyates/subscriptions","organizations_url":"https://api.github.com/users/joeyates/orgs","repos_url":"https://api.github.com/users/joeyates/repos","events_url":"https://api.github.com/users/joeyates/events{/privacy}","received_events_url":"https://api.github.com/users/joeyates/received_events","type":"User","site_admin":false},"repo":{"id":27955213,"name":"ffi-gdbm","full_name":"joeyates/ffi-gdbm","owner":{"login":"joeyates","id":137838,"avatar_url":"https://avatars.githubusercontent.com/u/137838?v=3","gravatar_id":"","url":"https://api.github.com/users/joeyates","html_url":"https://github.com/joeyates","followers_url":"https://api.github.com/users/joeyates/followers","following_url":"https://api.github.com/users/joeyates/following{/other_user}","gists_url":"https://api.github.com/users/joeyates/gists{/gist_id}","starred_url":"https://api.github.com/users/joeyates/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joeyates/subscriptions","organizations_url":"https://api.github.com/users/joeyates/orgs","repos_url":"https://api.github.com/users/joeyates/repos","events_url":"https://api.github.com/users/joeyates/events{/privacy}","received_events_url":"https://api.github.com/users/joeyates/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/joeyates/ffi-gdbm","description":"gdbm library using Ruby-FFI, particularly for JRuby","fork":true,"url":"https://api.github.com/repos/joeyates/ffi-gdbm","forks_url":"https://api.github.com/repos/joeyates/ffi-gdbm/forks","keys_url":"https://api.github.com/repos/joeyates/ffi-gdbm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joeyates/ffi-gdbm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joeyates/ffi-gdbm/teams","hooks_url":"https://api.github.com/repos/joeyates/ffi-gdbm/hooks","issue_events_url":"https://api.github.com/repos/joeyates/ffi-gdbm/issues/events{/number}","events_url":"https://api.github.com/repos/joeyates/ffi-gdbm/events","assignees_url":"https://api.github.com/repos/joeyates/ffi-gdbm/assignees{/user}","branches_url":"https://api.github.com/repos/joeyates/ffi-gdbm/branches{/branch}","tags_url":"https://api.github.com/repos/joeyates/ffi-gdbm/tags","blobs_url":"https://api.github.com/repos/joeyates/ffi-gdbm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joeyates/ffi-gdbm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joeyates/ffi-gdbm/git/refs{/sha}","trees_url":"https://api.github.com/repos/joeyates/ffi-gdbm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joeyates/ffi-gdbm/statuses/{sha}","languages_url":"https://api.github.com/repos/joeyates/ffi-gdbm/languages","stargazers_url":"https://api.github.com/repos/joeyates/ffi-gdbm/stargazers","contributors_url":"https://api.github.com/repos/joeyates/ffi-gdbm/contributors","subscribers_url":"https://api.github.com/repos/joeyates/ffi-gdbm/subscribers","subscription_url":"https://api.github.com/repos/joeyates/ffi-gdbm/subscription","commits_url":"https://api.github.com/repos/joeyates/ffi-gdbm/commits{/sha}","git_commits_url":"https://api.github.com/repos/joeyates/ffi-gdbm/git/commits{/sha}","comments_url":"https://api.github.com/repos/joeyates/ffi-gdbm/comments{/number}","issue_comment_url":"https://api.github.com/repos/joeyates/ffi-gdbm/issues/comments/{number}","contents_url":"https://api.github.com/repos/joeyates/ffi-gdbm/contents/{+path}","compare_url":"https://api.github.com/repos/joeyates/ffi-gdbm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joeyates/ffi-gdbm/merges","archive_url":"https://api.github.com/repos/joeyates/ffi-gdbm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joeyates/ffi-gdbm/downloads","issues_url":"https://api.github.com/repos/joeyates/ffi-gdbm/issues{/number}","pulls_url":"https://api.github.com/repos/joeyates/ffi-gdbm/pulls{/number}","milestones_url":"https://api.github.com/repos/joeyates/ffi-gdbm/milestones{/number}","notifications_url":"https://api.github.com/repos/joeyates/ffi-gdbm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joeyates/ffi-gdbm/labels{/name}","releases_url":"https://api.github.com/repos/joeyates/ffi-gdbm/releases{/id}","created_at":"2014-12-13T08:57:12Z","updated_at":"2014-12-13T08:57:12Z","pushed_at":"2014-12-13T10:36:29Z","git_url":"git://github.com/joeyates/ffi-gdbm.git","ssh_url":"git@github.com:joeyates/ffi-gdbm.git","clone_url":"https://github.com/joeyates/ffi-gdbm.git","svn_url":"https://github.com/joeyates/ffi-gdbm","homepage":"","size":139,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"presidentbeef:master","ref":"master","sha":"4780bd5b3fa750f5efe3a71bd9845c78d0beb3e4","user":{"login":"presidentbeef","id":75613,"avatar_url":"https://avatars.githubusercontent.com/u/75613?v=3","gravatar_id":"","url":"https://api.github.com/users/presidentbeef","html_url":"https://github.com/presidentbeef","followers_url":"https://api.github.com/users/presidentbeef/followers","following_url":"https://api.github.com/users/presidentbeef/following{/other_user}","gists_url":"https://api.github.com/users/presidentbeef/gists{/gist_id}","starred_url":"https://api.github.com/users/presidentbeef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/presidentbeef/subscriptions","organizations_url":"https://api.github.com/users/presidentbeef/orgs","repos_url":"https://api.github.com/users/presidentbeef/repos","events_url":"https://api.github.com/users/presidentbeef/events{/privacy}","received_events_url":"https://api.github.com/users/presidentbeef/received_events","type":"User","site_admin":false},"repo":{"id":315160,"name":"ffi-gdbm","full_name":"presidentbeef/ffi-gdbm","owner":{"login":"presidentbeef","id":75613,"avatar_url":"https://avatars.githubusercontent.com/u/75613?v=3","gravatar_id":"","url":"https://api.github.com/users/presidentbeef","html_url":"https://github.com/presidentbeef","followers_url":"https://api.github.com/users/presidentbeef/followers","following_url":"https://api.github.com/users/presidentbeef/following{/other_user}","gists_url":"https://api.github.com/users/presidentbeef/gists{/gist_id}","starred_url":"https://api.github.com/users/presidentbeef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/presidentbeef/subscriptions","organizations_url":"https://api.github.com/users/presidentbeef/orgs","repos_url":"https://api.github.com/users/presidentbeef/repos","events_url":"https://api.github.com/users/presidentbeef/events{/privacy}","received_events_url":"https://api.github.com/users/presidentbeef/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/presidentbeef/ffi-gdbm","description":"gdbm library using Ruby-FFI, particularly for JRuby","fork":false,"url":"https://api.github.com/repos/presidentbeef/ffi-gdbm","forks_url":"https://api.github.com/repos/presidentbeef/ffi-gdbm/forks","keys_url":"https://api.github.com/repos/presidentbeef/ffi-gdbm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/presidentbeef/ffi-gdbm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/presidentbeef/ffi-gdbm/teams","hooks_url":"https://api.github.com/repos/presidentbeef/ffi-gdbm/hooks","issue_events_url":"https://api.github.com/repos/presidentbeef/ffi-gdbm/issues/events{/number}","events_url":"https://api.github.com/repos/presidentbeef/ffi-gdbm/events","assignees_url":"https://api.github.com/repos/presidentbeef/ffi-gdbm/assignees{/user}","branches_url":"https://api.github.com/repos/presidentbeef/ffi-gdbm/branches{/branch}","tags_url":"https://api.github.com/repos/presidentbeef/ffi-gdbm/tags","blobs_url":"https://api.github.com/repos/presidentbeef/ffi-gdbm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/presidentbeef/ffi-gdbm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/presidentbeef/ffi-gdbm/git/refs{/sha}","trees_url":"https://api.github.com/repos/presidentbeef/ffi-gdbm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/presidentbeef/ffi-gdbm/statuses/{sha}","languages_url":"https://api.github.com/repos/presidentbeef/ffi-gdbm/languages","stargazers_url":"https://api.github.com/repos/presidentbeef/ffi-gdbm/stargazers","contributors_url":"https://api.github.com/repos/presidentbeef/ffi-gdbm/contributors","subscribers_url":"https://api.github.com/repos/presidentbeef/ffi-gdbm/subscribers","subscription_url":"https://api.github.com/repos/presidentbeef/ffi-gdbm/subscription","commits_url":"https://api.github.com/repos/presidentbeef/ffi-gdbm/commits{/sha}","git_commits_url":"https://api.github.com/repos/presidentbeef/ffi-gdbm/git/commits{/sha}","comments_url":"https://api.github.com/repos/presidentbeef/ffi-gdbm/comments{/number}","issue_comment_url":"https://api.github.com/repos/presidentbeef/ffi-gdbm/issues/comments/{number}","contents_url":"https://api.github.com/repos/presidentbeef/ffi-gdbm/contents/{+path}","compare_url":"https://api.github.com/repos/presidentbeef/ffi-gdbm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/presidentbeef/ffi-gdbm/merges","archive_url":"https://api.github.com/repos/presidentbeef/ffi-gdbm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/presidentbeef/ffi-gdbm/downloads","issues_url":"https://api.github.com/repos/presidentbeef/ffi-gdbm/issues{/number}","pulls_url":"https://api.github.com/repos/presidentbeef/ffi-gdbm/pulls{/number}","milestones_url":"https://api.github.com/repos/presidentbeef/ffi-gdbm/milestones{/number}","notifications_url":"https://api.github.com/repos/presidentbeef/ffi-gdbm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/presidentbeef/ffi-gdbm/labels{/name}","releases_url":"https://api.github.com/repos/presidentbeef/ffi-gdbm/releases{/id}","created_at":"2009-09-23T08:28:56Z","updated_at":"2014-12-12T20:09:06Z","pushed_at":"2011-03-16T06:42:30Z","git_url":"git://github.com/presidentbeef/ffi-gdbm.git","ssh_url":"git@github.com:presidentbeef/ffi-gdbm.git","clone_url":"https://github.com/presidentbeef/ffi-gdbm.git","svn_url":"https://github.com/presidentbeef/ffi-gdbm","homepage":"","size":148,"stargazers_count":4,"watchers_count":4,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/presidentbeef/ffi-gdbm/pulls/2"},"html":{"href":"https://github.com/presidentbeef/ffi-gdbm/pull/2"},"issue":{"href":"https://api.github.com/repos/presidentbeef/ffi-gdbm/issues/2"},"comments":{"href":"https://api.github.com/repos/presidentbeef/ffi-gdbm/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/presidentbeef/ffi-gdbm/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/presidentbeef/ffi-gdbm/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/presidentbeef/ffi-gdbm/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/presidentbeef/ffi-gdbm/statuses/2797aecb31c4b71436d0439d8770c8176254516f"}}}}