GitHub PullRequestReviewCommentEvent at 2014-09-30 20:39:59
Repository: sympy
Actor: cbm755
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/sympy/sympy/pulls/comments/18245498","id":18245498,"diff_hunk":"@@ -372,53 +262,78 @@ class InputArgument(Argument):\n \n \n class ResultBase(object):\n-    \"\"\"Base class for all ``outgoing'' information from a routine\n+    \"\"\"Base class for all \"outgoing\" information from a routine.\n \n-       Objects of this class stores a sympy expression, and a sympy object\n-       representing a result variable that will be used in the generated code\n-       only if necessary.\n-   \"\"\"\n+    Objects of this class stores a sympy expression, and a sympy object\n+    representing a result variable that will be used in the generated code\n+    only if necessary.\n+\n+    \"\"\"\n     def __init__(self, expr, result_var):\n         self.expr = expr\n         self.result_var = result_var\n \n \n class OutputArgument(Argument, ResultBase):\n-    \"\"\"OutputArgument are always initialized in the routine\n-    \"\"\"\n+    \"\"\"OutputArgument are always initialized in the routine.\"\"\"\n+\n     def __init__(self, name, result_var, expr, datatype=None, dimensions=None, precision=None):\n-        \"\"\" See docstring of Variable.__init__\n+        \"\"\"Return a new variable.\n+\n+        name : Symbol or MatrixSymbol\n+\n+        result_var : Symbol\n+            Used for output.\n+            FIXME: check if this can be a string.\n+            FIXME: document the difference/reason for having name and result_var.","path":"sympy/utilities/codegen.py","position":322,"original_position":322,"commit_id":"a7e66b3149178f95a48d33f6ebd049ab0e4645a6","original_commit_id":"5b5b843efd2d2b1c4a63b9e4a640623ec4b60519","user":{"login":"cbm755","id":818622,"avatar_url":"https://avatars.githubusercontent.com/u/818622?v=2","gravatar_id":"","url":"https://api.github.com/users/cbm755","html_url":"https://github.com/cbm755","followers_url":"https://api.github.com/users/cbm755/followers","following_url":"https://api.github.com/users/cbm755/following{/other_user}","gists_url":"https://api.github.com/users/cbm755/gists{/gist_id}","starred_url":"https://api.github.com/users/cbm755/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbm755/subscriptions","organizations_url":"https://api.github.com/users/cbm755/orgs","repos_url":"https://api.github.com/users/cbm755/repos","events_url":"https://api.github.com/users/cbm755/events{/privacy}","received_events_url":"https://api.github.com/users/cbm755/received_events","type":"User","site_admin":false},"body":"> I'm not actually sure why there's a name and a result_var.\r\n\r\nThey are used differently for instances of `Indexed`, but I'm not sure they *need* to be.  see e.g., https://github.com/sympy/sympy/pull/8082/files#diff-8799ec735d733a733f390a622a762ef3R403","created_at":"2014-09-30T20:39:59Z","updated_at":"2014-09-30T20:39:59Z","html_url":"https://github.com/sympy/sympy/pull/8082#discussion_r18245498","pull_request_url":"https://api.github.com/repos/sympy/sympy/pulls/8082","_links":{"self":{"href":"https://api.github.com/repos/sympy/sympy/pulls/comments/18245498"},"html":{"href":"https://github.com/sympy/sympy/pull/8082#discussion_r18245498"},"pull_request":{"href":"https://api.github.com/repos/sympy/sympy/pulls/8082"}}},"pull_request":{"url":"https://api.github.com/repos/sympy/sympy/pulls/8082","id":21639527,"html_url":"https://github.com/sympy/sympy/pull/8082","diff_url":"https://github.com/sympy/sympy/pull/8082.diff","patch_url":"https://github.com/sympy/sympy/pull/8082.patch","issue_url":"https://api.github.com/repos/sympy/sympy/issues/8082","number":8082,"state":"open","locked":false,"title":"refactor for Codegen Routine","user":{"login":"cbm755","id":818622,"avatar_url":"https://avatars.githubusercontent.com/u/818622?v=2","gravatar_id":"","url":"https://api.github.com/users/cbm755","html_url":"https://github.com/cbm755","followers_url":"https://api.github.com/users/cbm755/followers","following_url":"https://api.github.com/users/cbm755/following{/other_user}","gists_url":"https://api.github.com/users/cbm755/gists{/gist_id}","starred_url":"https://api.github.com/users/cbm755/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbm755/subscriptions","organizations_url":"https://api.github.com/users/cbm755/orgs","repos_url":"https://api.github.com/users/cbm755/repos","events_url":"https://api.github.com/users/cbm755/events{/privacy}","received_events_url":"https://api.github.com/users/cbm755/received_events","type":"User","site_admin":false},"body":"For OctaveCodeGen (pr #7824), I need some refactoring of `Routine`.\r\n\r\n- [x] add Fortran matrix tests\r\n- [x] add C matrix tests\r\n- [x] move language specific stuff out of `Routine.__new__`\r\n- [x] rework docstrings\r\n- [ ] clear-up FIXMEs on name versus result_var in docstrings.\r\n\r\nsee this comment https://github.com/sympy/sympy/pull/7824#discussion_r17892414\r\n","created_at":"2014-09-23T11:43:04Z","updated_at":"2014-09-30T20:39:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2d910ad9c553ce78089bcbfebefc4179f5f0cad6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sympy/sympy/pulls/8082/commits","review_comments_url":"https://api.github.com/repos/sympy/sympy/pulls/8082/comments","review_comment_url":"https://api.github.com/repos/sympy/sympy/pulls/comments/{number}","comments_url":"https://api.github.com/repos/sympy/sympy/issues/8082/comments","statuses_url":"https://api.github.com/repos/sympy/sympy/statuses/a7e66b3149178f95a48d33f6ebd049ab0e4645a6","head":{"label":"cbm755:routine_refactor","ref":"routine_refactor","sha":"a7e66b3149178f95a48d33f6ebd049ab0e4645a6","user":{"login":"cbm755","id":818622,"avatar_url":"https://avatars.githubusercontent.com/u/818622?v=2","gravatar_id":"","url":"https://api.github.com/users/cbm755","html_url":"https://github.com/cbm755","followers_url":"https://api.github.com/users/cbm755/followers","following_url":"https://api.github.com/users/cbm755/following{/other_user}","gists_url":"https://api.github.com/users/cbm755/gists{/gist_id}","starred_url":"https://api.github.com/users/cbm755/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbm755/subscriptions","organizations_url":"https://api.github.com/users/cbm755/orgs","repos_url":"https://api.github.com/users/cbm755/repos","events_url":"https://api.github.com/users/cbm755/events{/privacy}","received_events_url":"https://api.github.com/users/cbm755/received_events","type":"User","site_admin":false},"repo":{"id":21549863,"name":"sympy","full_name":"cbm755/sympy","owner":{"login":"cbm755","id":818622,"avatar_url":"https://avatars.githubusercontent.com/u/818622?v=2","gravatar_id":"","url":"https://api.github.com/users/cbm755","html_url":"https://github.com/cbm755","followers_url":"https://api.github.com/users/cbm755/followers","following_url":"https://api.github.com/users/cbm755/following{/other_user}","gists_url":"https://api.github.com/users/cbm755/gists{/gist_id}","starred_url":"https://api.github.com/users/cbm755/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbm755/subscriptions","organizations_url":"https://api.github.com/users/cbm755/orgs","repos_url":"https://api.github.com/users/cbm755/repos","events_url":"https://api.github.com/users/cbm755/events{/privacy}","received_events_url":"https://api.github.com/users/cbm755/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cbm755/sympy","description":"A computer algebra system written in pure Python","fork":true,"url":"https://api.github.com/repos/cbm755/sympy","forks_url":"https://api.github.com/repos/cbm755/sympy/forks","keys_url":"https://api.github.com/repos/cbm755/sympy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cbm755/sympy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cbm755/sympy/teams","hooks_url":"https://api.github.com/repos/cbm755/sympy/hooks","issue_events_url":"https://api.github.com/repos/cbm755/sympy/issues/events{/number}","events_url":"https://api.github.com/repos/cbm755/sympy/events","assignees_url":"https://api.github.com/repos/cbm755/sympy/assignees{/user}","branches_url":"https://api.github.com/repos/cbm755/sympy/branches{/branch}","tags_url":"https://api.github.com/repos/cbm755/sympy/tags","blobs_url":"https://api.github.com/repos/cbm755/sympy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cbm755/sympy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cbm755/sympy/git/refs{/sha}","trees_url":"https://api.github.com/repos/cbm755/sympy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cbm755/sympy/statuses/{sha}","languages_url":"https://api.github.com/repos/cbm755/sympy/languages","stargazers_url":"https://api.github.com/repos/cbm755/sympy/stargazers","contributors_url":"https://api.github.com/repos/cbm755/sympy/contributors","subscribers_url":"https://api.github.com/repos/cbm755/sympy/subscribers","subscription_url":"https://api.github.com/repos/cbm755/sympy/subscription","commits_url":"https://api.github.com/repos/cbm755/sympy/commits{/sha}","git_commits_url":"https://api.github.com/repos/cbm755/sympy/git/commits{/sha}","comments_url":"https://api.github.com/repos/cbm755/sympy/comments{/number}","issue_comment_url":"https://api.github.com/repos/cbm755/sympy/issues/comments/{number}","contents_url":"https://api.github.com/repos/cbm755/sympy/contents/{+path}","compare_url":"https://api.github.com/repos/cbm755/sympy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cbm755/sympy/merges","archive_url":"https://api.github.com/repos/cbm755/sympy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cbm755/sympy/downloads","issues_url":"https://api.github.com/repos/cbm755/sympy/issues{/number}","pulls_url":"https://api.github.com/repos/cbm755/sympy/pulls{/number}","milestones_url":"https://api.github.com/repos/cbm755/sympy/milestones{/number}","notifications_url":"https://api.github.com/repos/cbm755/sympy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cbm755/sympy/labels{/name}","releases_url":"https://api.github.com/repos/cbm755/sympy/releases{/id}","created_at":"2014-07-06T22:25:47Z","updated_at":"2014-08-07T09:18:31Z","pushed_at":"2014-09-30T20:07:54Z","git_url":"git://github.com/cbm755/sympy.git","ssh_url":"git@github.com:cbm755/sympy.git","clone_url":"https://github.com/cbm755/sympy.git","svn_url":"https://github.com/cbm755/sympy","homepage":"http://sympy.org/","size":64753,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sympy:master","ref":"master","sha":"913c384e9b74f037ea2e1b5c61e4cb572de720d4","user":{"login":"sympy","id":260832,"avatar_url":"https://avatars.githubusercontent.com/u/260832?v=2","gravatar_id":"","url":"https://api.github.com/users/sympy","html_url":"https://github.com/sympy","followers_url":"https://api.github.com/users/sympy/followers","following_url":"https://api.github.com/users/sympy/following{/other_user}","gists_url":"https://api.github.com/users/sympy/gists{/gist_id}","starred_url":"https://api.github.com/users/sympy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sympy/subscriptions","organizations_url":"https://api.github.com/users/sympy/orgs","repos_url":"https://api.github.com/users/sympy/repos","events_url":"https://api.github.com/users/sympy/events{/privacy}","received_events_url":"https://api.github.com/users/sympy/received_events","type":"Organization","site_admin":false},"repo":{"id":640534,"name":"sympy","full_name":"sympy/sympy","owner":{"login":"sympy","id":260832,"avatar_url":"https://avatars.githubusercontent.com/u/260832?v=2","gravatar_id":"","url":"https://api.github.com/users/sympy","html_url":"https://github.com/sympy","followers_url":"https://api.github.com/users/sympy/followers","following_url":"https://api.github.com/users/sympy/following{/other_user}","gists_url":"https://api.github.com/users/sympy/gists{/gist_id}","starred_url":"https://api.github.com/users/sympy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sympy/subscriptions","organizations_url":"https://api.github.com/users/sympy/orgs","repos_url":"https://api.github.com/users/sympy/repos","events_url":"https://api.github.com/users/sympy/events{/privacy}","received_events_url":"https://api.github.com/users/sympy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sympy/sympy","description":"A computer algebra system written in pure Python","fork":false,"url":"https://api.github.com/repos/sympy/sympy","forks_url":"https://api.github.com/repos/sympy/sympy/forks","keys_url":"https://api.github.com/repos/sympy/sympy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sympy/sympy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sympy/sympy/teams","hooks_url":"https://api.github.com/repos/sympy/sympy/hooks","issue_events_url":"https://api.github.com/repos/sympy/sympy/issues/events{/number}","events_url":"https://api.github.com/repos/sympy/sympy/events","assignees_url":"https://api.github.com/repos/sympy/sympy/assignees{/user}","branches_url":"https://api.github.com/repos/sympy/sympy/branches{/branch}","tags_url":"https://api.github.com/repos/sympy/sympy/tags","blobs_url":"https://api.github.com/repos/sympy/sympy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sympy/sympy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sympy/sympy/git/refs{/sha}","trees_url":"https://api.github.com/repos/sympy/sympy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sympy/sympy/statuses/{sha}","languages_url":"https://api.github.com/repos/sympy/sympy/languages","stargazers_url":"https://api.github.com/repos/sympy/sympy/stargazers","contributors_url":"https://api.github.com/repos/sympy/sympy/contributors","subscribers_url":"https://api.github.com/repos/sympy/sympy/subscribers","subscription_url":"https://api.github.com/repos/sympy/sympy/subscription","commits_url":"https://api.github.com/repos/sympy/sympy/commits{/sha}","git_commits_url":"https://api.github.com/repos/sympy/sympy/git/commits{/sha}","comments_url":"https://api.github.com/repos/sympy/sympy/comments{/number}","issue_comment_url":"https://api.github.com/repos/sympy/sympy/issues/comments/{number}","contents_url":"https://api.github.com/repos/sympy/sympy/contents/{+path}","compare_url":"https://api.github.com/repos/sympy/sympy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sympy/sympy/merges","archive_url":"https://api.github.com/repos/sympy/sympy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sympy/sympy/downloads","issues_url":"https://api.github.com/repos/sympy/sympy/issues{/number}","pulls_url":"https://api.github.com/repos/sympy/sympy/pulls{/number}","milestones_url":"https://api.github.com/repos/sympy/sympy/milestones{/number}","notifications_url":"https://api.github.com/repos/sympy/sympy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sympy/sympy/labels{/name}","releases_url":"https://api.github.com/repos/sympy/sympy/releases{/id}","created_at":"2010-04-30T20:37:14Z","updated_at":"2014-09-30T14:34:19Z","pushed_at":"2014-09-30T10:23:10Z","git_url":"git://github.com/sympy/sympy.git","ssh_url":"git@github.com:sympy/sympy.git","clone_url":"https://github.com/sympy/sympy.git","svn_url":"https://github.com/sympy/sympy","homepage":"http://sympy.org/","size":221156,"stargazers_count":1631,"watchers_count":1631,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":751,"mirror_url":null,"open_issues_count":1582,"forks":751,"open_issues":1582,"watchers":1631,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sympy/sympy/pulls/8082"},"html":{"href":"https://github.com/sympy/sympy/pull/8082"},"issue":{"href":"https://api.github.com/repos/sympy/sympy/issues/8082"},"comments":{"href":"https://api.github.com/repos/sympy/sympy/issues/8082/comments"},"review_comments":{"href":"https://api.github.com/repos/sympy/sympy/pulls/8082/comments"},"review_comment":{"href":"https://api.github.com/repos/sympy/sympy/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/sympy/sympy/pulls/8082/commits"},"statuses":{"href":"https://api.github.com/repos/sympy/sympy/statuses/a7e66b3149178f95a48d33f6ebd049ab0e4645a6"}}}}