GitHub PullRequestReviewCommentEvent at 2014-06-07 04:54:00
Repository: MonoGame
Actor: danzel
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/mono/MonoGame/pulls/comments/13517976","id":13517976,"diff_hunk":"@@ -0,0 +1,92 @@\n+// MonoGame - Copyright (C) The MonoGame Team\n+// This file is subject to the terms and conditions defined in\n+// file 'LICENSE.txt', which is part of this source code package.\n+﻿\n+using System;\n+using System.IO;\n+using Android.Content;\n+using Android.Content.Res;\n+using Android.Media;\n+using Android.Util;\n+using Stream = System.IO.Stream;\n+\n+namespace Microsoft.Xna.Framework.Audio\n+{\n+    public sealed partial class SoundEffect : IDisposable\n+    {\n+        internal byte[] _data;\n+\n+\t\tinternal float Rate { get; set; }\n+\n+        internal int Size { get; set; }\n+\n+\t\tprivate int _soundID = -1;\n+\n+        #region Public Constructors\n+\n+        private void PlatformLoadAudioStream(Stream s)\n+        {\n+\t\t\t// Creating a soundeffect from a stream\n+\t\t\t// doesn't seem to be supported in Android","path":"MonoGame.Framework/Audio/SoundEffect.Android.cs","position":30,"original_position":30,"commit_id":"90d97406d9f8f286d8453c2c60a92e3ad3f8628f","original_commit_id":"90d97406d9f8f286d8453c2c60a92e3ad3f8628f","user":{"login":"danzel","id":393086,"avatar_url":"https://avatars.githubusercontent.com/u/393086?","gravatar_id":"798717b399b786a8fa7d1a94db8dc0a2","url":"https://api.github.com/users/danzel","html_url":"https://github.com/danzel","followers_url":"https://api.github.com/users/danzel/followers","following_url":"https://api.github.com/users/danzel/following{/other_user}","gists_url":"https://api.github.com/users/danzel/gists{/gist_id}","starred_url":"https://api.github.com/users/danzel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danzel/subscriptions","organizations_url":"https://api.github.com/users/danzel/orgs","repos_url":"https://api.github.com/users/danzel/repos","events_url":"https://api.github.com/users/danzel/events{/privacy}","received_events_url":"https://api.github.com/users/danzel/received_events","type":"User","site_admin":false},"body":"I know this is the same as before, but maybe we should throw an exception here rather than doing nothing?","created_at":"2014-06-07T04:54:00Z","updated_at":"2014-06-07T04:54:00Z","html_url":"https://github.com/mono/MonoGame/pull/2677#discussion_r13517976","pull_request_url":"https://api.github.com/repos/mono/MonoGame/pulls/2677","_links":{"self":{"href":"https://api.github.com/repos/mono/MonoGame/pulls/comments/13517976"},"html":{"href":"https://github.com/mono/MonoGame/pull/2677#discussion_r13517976"},"pull_request":{"href":"https://api.github.com/repos/mono/MonoGame/pulls/2677"}}},"pull_request":{"url":"https://api.github.com/repos/mono/MonoGame/pulls/2677","id":16827022,"html_url":"https://github.com/mono/MonoGame/pull/2677","diff_url":"https://github.com/mono/MonoGame/pull/2677.diff","patch_url":"https://github.com/mono/MonoGame/pull/2677.patch","issue_url":"https://api.github.com/repos/mono/MonoGame/issues/2677","number":2677,"state":"open","title":"Add Android SoundEffect classes and Dispose pattern","user":{"login":"KonajuGames","id":694943,"avatar_url":"https://avatars.githubusercontent.com/u/694943?","gravatar_id":"82f234eb541549955d3775b43aebefbd","url":"https://api.github.com/users/KonajuGames","html_url":"https://github.com/KonajuGames","followers_url":"https://api.github.com/users/KonajuGames/followers","following_url":"https://api.github.com/users/KonajuGames/following{/other_user}","gists_url":"https://api.github.com/users/KonajuGames/gists{/gist_id}","starred_url":"https://api.github.com/users/KonajuGames/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KonajuGames/subscriptions","organizations_url":"https://api.github.com/users/KonajuGames/orgs","repos_url":"https://api.github.com/users/KonajuGames/repos","events_url":"https://api.github.com/users/KonajuGames/events{/privacy}","received_events_url":"https://api.github.com/users/KonajuGames/received_events","type":"User","site_admin":false},"body":"Separated Android SoundPool implementation into its own partial classes.\r\nImplemented proper Dispose pattern on SoundEffect, SoundEffectInstance and OALBuffer.\r\nOpenAL throws NoAudioHardwareException if OpenAL drivers could not be loaded.","created_at":"2014-06-06T15:39:34Z","updated_at":"2014-06-07T04:54:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c1796f11c08f570e044c25486237cd927215d42d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mono/MonoGame/pulls/2677/commits","review_comments_url":"https://api.github.com/repos/mono/MonoGame/pulls/2677/comments","review_comment_url":"https://api.github.com/repos/mono/MonoGame/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mono/MonoGame/issues/2677/comments","statuses_url":"https://api.github.com/repos/mono/MonoGame/statuses/90d97406d9f8f286d8453c2c60a92e3ad3f8628f","head":{"label":"KonajuGames:audio-android-dispose","ref":"audio-android-dispose","sha":"90d97406d9f8f286d8453c2c60a92e3ad3f8628f","user":{"login":"KonajuGames","id":694943,"avatar_url":"https://avatars.githubusercontent.com/u/694943?","gravatar_id":"82f234eb541549955d3775b43aebefbd","url":"https://api.github.com/users/KonajuGames","html_url":"https://github.com/KonajuGames","followers_url":"https://api.github.com/users/KonajuGames/followers","following_url":"https://api.github.com/users/KonajuGames/following{/other_user}","gists_url":"https://api.github.com/users/KonajuGames/gists{/gist_id}","starred_url":"https://api.github.com/users/KonajuGames/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KonajuGames/subscriptions","organizations_url":"https://api.github.com/users/KonajuGames/orgs","repos_url":"https://api.github.com/users/KonajuGames/repos","events_url":"https://api.github.com/users/KonajuGames/events{/privacy}","received_events_url":"https://api.github.com/users/KonajuGames/received_events","type":"User","site_admin":false},"repo":{"id":2882670,"name":"MonoGame","full_name":"KonajuGames/MonoGame","owner":{"login":"KonajuGames","id":694943,"avatar_url":"https://avatars.githubusercontent.com/u/694943?","gravatar_id":"82f234eb541549955d3775b43aebefbd","url":"https://api.github.com/users/KonajuGames","html_url":"https://github.com/KonajuGames","followers_url":"https://api.github.com/users/KonajuGames/followers","following_url":"https://api.github.com/users/KonajuGames/following{/other_user}","gists_url":"https://api.github.com/users/KonajuGames/gists{/gist_id}","starred_url":"https://api.github.com/users/KonajuGames/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KonajuGames/subscriptions","organizations_url":"https://api.github.com/users/KonajuGames/orgs","repos_url":"https://api.github.com/users/KonajuGames/repos","events_url":"https://api.github.com/users/KonajuGames/events{/privacy}","received_events_url":"https://api.github.com/users/KonajuGames/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/KonajuGames/MonoGame","description":"XNA Implementation for Mono based platforms","fork":true,"url":"https://api.github.com/repos/KonajuGames/MonoGame","forks_url":"https://api.github.com/repos/KonajuGames/MonoGame/forks","keys_url":"https://api.github.com/repos/KonajuGames/MonoGame/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KonajuGames/MonoGame/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KonajuGames/MonoGame/teams","hooks_url":"https://api.github.com/repos/KonajuGames/MonoGame/hooks","issue_events_url":"https://api.github.com/repos/KonajuGames/MonoGame/issues/events{/number}","events_url":"https://api.github.com/repos/KonajuGames/MonoGame/events","assignees_url":"https://api.github.com/repos/KonajuGames/MonoGame/assignees{/user}","branches_url":"https://api.github.com/repos/KonajuGames/MonoGame/branches{/branch}","tags_url":"https://api.github.com/repos/KonajuGames/MonoGame/tags","blobs_url":"https://api.github.com/repos/KonajuGames/MonoGame/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KonajuGames/MonoGame/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KonajuGames/MonoGame/git/refs{/sha}","trees_url":"https://api.github.com/repos/KonajuGames/MonoGame/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KonajuGames/MonoGame/statuses/{sha}","languages_url":"https://api.github.com/repos/KonajuGames/MonoGame/languages","stargazers_url":"https://api.github.com/repos/KonajuGames/MonoGame/stargazers","contributors_url":"https://api.github.com/repos/KonajuGames/MonoGame/contributors","subscribers_url":"https://api.github.com/repos/KonajuGames/MonoGame/subscribers","subscription_url":"https://api.github.com/repos/KonajuGames/MonoGame/subscription","commits_url":"https://api.github.com/repos/KonajuGames/MonoGame/commits{/sha}","git_commits_url":"https://api.github.com/repos/KonajuGames/MonoGame/git/commits{/sha}","comments_url":"https://api.github.com/repos/KonajuGames/MonoGame/comments{/number}","issue_comment_url":"https://api.github.com/repos/KonajuGames/MonoGame/issues/comments/{number}","contents_url":"https://api.github.com/repos/KonajuGames/MonoGame/contents/{+path}","compare_url":"https://api.github.com/repos/KonajuGames/MonoGame/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KonajuGames/MonoGame/merges","archive_url":"https://api.github.com/repos/KonajuGames/MonoGame/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KonajuGames/MonoGame/downloads","issues_url":"https://api.github.com/repos/KonajuGames/MonoGame/issues{/number}","pulls_url":"https://api.github.com/repos/KonajuGames/MonoGame/pulls{/number}","milestones_url":"https://api.github.com/repos/KonajuGames/MonoGame/milestones{/number}","notifications_url":"https://api.github.com/repos/KonajuGames/MonoGame/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KonajuGames/MonoGame/labels{/name}","releases_url":"https://api.github.com/repos/KonajuGames/MonoGame/releases{/id}","created_at":"2011-11-30T11:54:43Z","updated_at":"2014-06-07T03:09:21Z","pushed_at":"2014-06-07T03:09:20Z","git_url":"git://github.com/KonajuGames/MonoGame.git","ssh_url":"git@github.com:KonajuGames/MonoGame.git","clone_url":"https://github.com/KonajuGames/MonoGame.git","svn_url":"https://github.com/KonajuGames/MonoGame","homepage":"http://monogame.codeplex.com","size":46240,"stargazers_count":2,"watchers_count":2,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":2,"default_branch":"develop"}},"base":{"label":"mono:develop","ref":"develop","sha":"0c34166ea0cb5e9d98a0ef0894ef2bbde1e90de5","user":{"login":"mono","id":53395,"avatar_url":"https://avatars.githubusercontent.com/u/53395?","gravatar_id":"f275a99c0b4e6044d3e81daf445f8174","url":"https://api.github.com/users/mono","html_url":"https://github.com/mono","followers_url":"https://api.github.com/users/mono/followers","following_url":"https://api.github.com/users/mono/following{/other_user}","gists_url":"https://api.github.com/users/mono/gists{/gist_id}","starred_url":"https://api.github.com/users/mono/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mono/subscriptions","organizations_url":"https://api.github.com/users/mono/orgs","repos_url":"https://api.github.com/users/mono/repos","events_url":"https://api.github.com/users/mono/events{/privacy}","received_events_url":"https://api.github.com/users/mono/received_events","type":"Organization","site_admin":false},"repo":{"id":1579990,"name":"MonoGame","full_name":"mono/MonoGame","owner":{"login":"mono","id":53395,"avatar_url":"https://avatars.githubusercontent.com/u/53395?","gravatar_id":"f275a99c0b4e6044d3e81daf445f8174","url":"https://api.github.com/users/mono","html_url":"https://github.com/mono","followers_url":"https://api.github.com/users/mono/followers","following_url":"https://api.github.com/users/mono/following{/other_user}","gists_url":"https://api.github.com/users/mono/gists{/gist_id}","starred_url":"https://api.github.com/users/mono/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mono/subscriptions","organizations_url":"https://api.github.com/users/mono/orgs","repos_url":"https://api.github.com/users/mono/repos","events_url":"https://api.github.com/users/mono/events{/privacy}","received_events_url":"https://api.github.com/users/mono/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mono/MonoGame","description":"One framework for creating powerful cross-platform games.","fork":false,"url":"https://api.github.com/repos/mono/MonoGame","forks_url":"https://api.github.com/repos/mono/MonoGame/forks","keys_url":"https://api.github.com/repos/mono/MonoGame/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mono/MonoGame/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mono/MonoGame/teams","hooks_url":"https://api.github.com/repos/mono/MonoGame/hooks","issue_events_url":"https://api.github.com/repos/mono/MonoGame/issues/events{/number}","events_url":"https://api.github.com/repos/mono/MonoGame/events","assignees_url":"https://api.github.com/repos/mono/MonoGame/assignees{/user}","branches_url":"https://api.github.com/repos/mono/MonoGame/branches{/branch}","tags_url":"https://api.github.com/repos/mono/MonoGame/tags","blobs_url":"https://api.github.com/repos/mono/MonoGame/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mono/MonoGame/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mono/MonoGame/git/refs{/sha}","trees_url":"https://api.github.com/repos/mono/MonoGame/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mono/MonoGame/statuses/{sha}","languages_url":"https://api.github.com/repos/mono/MonoGame/languages","stargazers_url":"https://api.github.com/repos/mono/MonoGame/stargazers","contributors_url":"https://api.github.com/repos/mono/MonoGame/contributors","subscribers_url":"https://api.github.com/repos/mono/MonoGame/subscribers","subscription_url":"https://api.github.com/repos/mono/MonoGame/subscription","commits_url":"https://api.github.com/repos/mono/MonoGame/commits{/sha}","git_commits_url":"https://api.github.com/repos/mono/MonoGame/git/commits{/sha}","comments_url":"https://api.github.com/repos/mono/MonoGame/comments{/number}","issue_comment_url":"https://api.github.com/repos/mono/MonoGame/issues/comments/{number}","contents_url":"https://api.github.com/repos/mono/MonoGame/contents/{+path}","compare_url":"https://api.github.com/repos/mono/MonoGame/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mono/MonoGame/merges","archive_url":"https://api.github.com/repos/mono/MonoGame/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mono/MonoGame/downloads","issues_url":"https://api.github.com/repos/mono/MonoGame/issues{/number}","pulls_url":"https://api.github.com/repos/mono/MonoGame/pulls{/number}","milestones_url":"https://api.github.com/repos/mono/MonoGame/milestones{/number}","notifications_url":"https://api.github.com/repos/mono/MonoGame/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mono/MonoGame/labels{/name}","releases_url":"https://api.github.com/repos/mono/MonoGame/releases{/id}","created_at":"2011-04-07T00:23:40Z","updated_at":"2014-06-07T02:20:01Z","pushed_at":"2014-06-07T02:20:00Z","git_url":"git://github.com/mono/MonoGame.git","ssh_url":"git@github.com:mono/MonoGame.git","clone_url":"https://github.com/mono/MonoGame.git","svn_url":"https://github.com/mono/MonoGame","homepage":"http://www.monogame.net","size":311887,"stargazers_count":2083,"watchers_count":2083,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":1178,"mirror_url":null,"open_issues_count":425,"forks":1178,"open_issues":425,"watchers":2083,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/mono/MonoGame/pulls/2677"},"html":{"href":"https://github.com/mono/MonoGame/pull/2677"},"issue":{"href":"https://api.github.com/repos/mono/MonoGame/issues/2677"},"comments":{"href":"https://api.github.com/repos/mono/MonoGame/issues/2677/comments"},"review_comments":{"href":"https://api.github.com/repos/mono/MonoGame/pulls/2677/comments"},"review_comment":{"href":"https://api.github.com/repos/mono/MonoGame/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mono/MonoGame/pulls/2677/commits"},"statuses":{"href":"https://api.github.com/repos/mono/MonoGame/statuses/90d97406d9f8f286d8453c2c60a92e3ad3f8628f"}}}}