GitHub PullRequestReviewCommentEvent at 2014-07-20 00:33:36
Repository: jekyll
Actor: parkr
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/jekyll/jekyll/pulls/comments/15146923","id":15146923,"diff_hunk":"@@ -32,7 +34,13 @@ def relative_path\n     #\n     # Returns destination file path.\n     def destination(dest)\n-      File.join(*[dest, @dir, @name].compact)\n+      # File.join(*[dest, @dir, @name].compact)\n+      # File.join(dest, @dir.gsub(/^\\_/, ''), @name)\n+      if @collection\n+        File.join(dest, @dir.gsub(/^\\_/, ''), @name)\n+      else\n+        File.join(*[dest, @dir, @name].compact)\n+      end","path":"lib/jekyll/static_file.rb","position":34,"original_position":34,"commit_id":"3456373b32c66a3d5ca419334e14fe2b108bffd0","original_commit_id":"3456373b32c66a3d5ca419334e14fe2b108bffd0","user":{"login":"parkr","id":237985,"avatar_url":"https://avatars.githubusercontent.com/u/237985?","gravatar_id":"3b05198379f4b275d304fd27e6cb09ae","url":"https://api.github.com/users/parkr","html_url":"https://github.com/parkr","followers_url":"https://api.github.com/users/parkr/followers","following_url":"https://api.github.com/users/parkr/following{/other_user}","gists_url":"https://api.github.com/users/parkr/gists{/gist_id}","starred_url":"https://api.github.com/users/parkr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parkr/subscriptions","organizations_url":"https://api.github.com/users/parkr/orgs","repos_url":"https://api.github.com/users/parkr/repos","events_url":"https://api.github.com/users/parkr/events{/privacy}","received_events_url":"https://api.github.com/users/parkr/received_events","type":"User","site_admin":false},"body":"No, like `@dir`, `@collection` and `@name` should have `attr_reader`s.\r\n\r\nOr maybe just\r\n\r\n```ruby\r\nattr_reader :collection\r\ndef relative_path\r\n  File.join(*[@dir, @name].compact)\r\nend\r\n```","created_at":"2014-07-20T00:33:36Z","updated_at":"2014-07-20T00:33:36Z","html_url":"https://github.com/jekyll/jekyll/pull/2615#discussion_r15146923","pull_request_url":"https://api.github.com/repos/jekyll/jekyll/pulls/2615","_links":{"self":{"href":"https://api.github.com/repos/jekyll/jekyll/pulls/comments/15146923"},"html":{"href":"https://github.com/jekyll/jekyll/pull/2615#discussion_r15146923"},"pull_request":{"href":"https://api.github.com/repos/jekyll/jekyll/pulls/2615"}}},"pull_request":{"url":"https://api.github.com/repos/jekyll/jekyll/pulls/2615","id":18540317,"html_url":"https://github.com/jekyll/jekyll/pull/2615","diff_url":"https://github.com/jekyll/jekyll/pull/2615.diff","patch_url":"https://github.com/jekyll/jekyll/pull/2615.patch","issue_url":"https://api.github.com/repos/jekyll/jekyll/issues/2615","number":2615,"state":"open","title":"Allow static files in Collections","user":{"login":"alfredxing","id":2704010,"avatar_url":"https://avatars.githubusercontent.com/u/2704010?","gravatar_id":"3d33ed08f4366f2516382334b8038563","url":"https://api.github.com/users/alfredxing","html_url":"https://github.com/alfredxing","followers_url":"https://api.github.com/users/alfredxing/followers","following_url":"https://api.github.com/users/alfredxing/following{/other_user}","gists_url":"https://api.github.com/users/alfredxing/gists{/gist_id}","starred_url":"https://api.github.com/users/alfredxing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alfredxing/subscriptions","organizations_url":"https://api.github.com/users/alfredxing/orgs","repos_url":"https://api.github.com/users/alfredxing/repos","events_url":"https://api.github.com/users/alfredxing/events{/privacy}","received_events_url":"https://api.github.com/users/alfredxing/received_events","type":"User","site_admin":false},"body":"Allow StaticFiles in Collections alongside Documents. Attempts to fix #2555, #2598. Can also be modified a bit to accommodate #2592. Builds on #2603.\r\n\r\nPlease test!","created_at":"2014-07-17T16:53:03Z","updated_at":"2014-07-20T00:33:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"45b323d7b4924eb75f3986a64a3ebc2a1cd06070","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jekyll/jekyll/pulls/2615/commits","review_comments_url":"https://api.github.com/repos/jekyll/jekyll/pulls/2615/comments","review_comment_url":"https://api.github.com/repos/jekyll/jekyll/pulls/comments/{number}","comments_url":"https://api.github.com/repos/jekyll/jekyll/issues/2615/comments","statuses_url":"https://api.github.com/repos/jekyll/jekyll/statuses/3456373b32c66a3d5ca419334e14fe2b108bffd0","head":{"label":"alfredxing:collections-static-files","ref":"collections-static-files","sha":"3456373b32c66a3d5ca419334e14fe2b108bffd0","user":{"login":"alfredxing","id":2704010,"avatar_url":"https://avatars.githubusercontent.com/u/2704010?","gravatar_id":"3d33ed08f4366f2516382334b8038563","url":"https://api.github.com/users/alfredxing","html_url":"https://github.com/alfredxing","followers_url":"https://api.github.com/users/alfredxing/followers","following_url":"https://api.github.com/users/alfredxing/following{/other_user}","gists_url":"https://api.github.com/users/alfredxing/gists{/gist_id}","starred_url":"https://api.github.com/users/alfredxing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alfredxing/subscriptions","organizations_url":"https://api.github.com/users/alfredxing/orgs","repos_url":"https://api.github.com/users/alfredxing/repos","events_url":"https://api.github.com/users/alfredxing/events{/privacy}","received_events_url":"https://api.github.com/users/alfredxing/received_events","type":"User","site_admin":false},"repo":{"id":21312458,"name":"jekyll","full_name":"alfredxing/jekyll","owner":{"login":"alfredxing","id":2704010,"avatar_url":"https://avatars.githubusercontent.com/u/2704010?","gravatar_id":"3d33ed08f4366f2516382334b8038563","url":"https://api.github.com/users/alfredxing","html_url":"https://github.com/alfredxing","followers_url":"https://api.github.com/users/alfredxing/followers","following_url":"https://api.github.com/users/alfredxing/following{/other_user}","gists_url":"https://api.github.com/users/alfredxing/gists{/gist_id}","starred_url":"https://api.github.com/users/alfredxing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alfredxing/subscriptions","organizations_url":"https://api.github.com/users/alfredxing/orgs","repos_url":"https://api.github.com/users/alfredxing/repos","events_url":"https://api.github.com/users/alfredxing/events{/privacy}","received_events_url":"https://api.github.com/users/alfredxing/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alfredxing/jekyll","description":"Jekyll is a blog-aware, static site generator in Ruby","fork":true,"url":"https://api.github.com/repos/alfredxing/jekyll","forks_url":"https://api.github.com/repos/alfredxing/jekyll/forks","keys_url":"https://api.github.com/repos/alfredxing/jekyll/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alfredxing/jekyll/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alfredxing/jekyll/teams","hooks_url":"https://api.github.com/repos/alfredxing/jekyll/hooks","issue_events_url":"https://api.github.com/repos/alfredxing/jekyll/issues/events{/number}","events_url":"https://api.github.com/repos/alfredxing/jekyll/events","assignees_url":"https://api.github.com/repos/alfredxing/jekyll/assignees{/user}","branches_url":"https://api.github.com/repos/alfredxing/jekyll/branches{/branch}","tags_url":"https://api.github.com/repos/alfredxing/jekyll/tags","blobs_url":"https://api.github.com/repos/alfredxing/jekyll/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alfredxing/jekyll/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alfredxing/jekyll/git/refs{/sha}","trees_url":"https://api.github.com/repos/alfredxing/jekyll/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alfredxing/jekyll/statuses/{sha}","languages_url":"https://api.github.com/repos/alfredxing/jekyll/languages","stargazers_url":"https://api.github.com/repos/alfredxing/jekyll/stargazers","contributors_url":"https://api.github.com/repos/alfredxing/jekyll/contributors","subscribers_url":"https://api.github.com/repos/alfredxing/jekyll/subscribers","subscription_url":"https://api.github.com/repos/alfredxing/jekyll/subscription","commits_url":"https://api.github.com/repos/alfredxing/jekyll/commits{/sha}","git_commits_url":"https://api.github.com/repos/alfredxing/jekyll/git/commits{/sha}","comments_url":"https://api.github.com/repos/alfredxing/jekyll/comments{/number}","issue_comment_url":"https://api.github.com/repos/alfredxing/jekyll/issues/comments/{number}","contents_url":"https://api.github.com/repos/alfredxing/jekyll/contents/{+path}","compare_url":"https://api.github.com/repos/alfredxing/jekyll/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alfredxing/jekyll/merges","archive_url":"https://api.github.com/repos/alfredxing/jekyll/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alfredxing/jekyll/downloads","issues_url":"https://api.github.com/repos/alfredxing/jekyll/issues{/number}","pulls_url":"https://api.github.com/repos/alfredxing/jekyll/pulls{/number}","milestones_url":"https://api.github.com/repos/alfredxing/jekyll/milestones{/number}","notifications_url":"https://api.github.com/repos/alfredxing/jekyll/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alfredxing/jekyll/labels{/name}","releases_url":"https://api.github.com/repos/alfredxing/jekyll/releases{/id}","created_at":"2014-06-28T22:49:32Z","updated_at":"2014-06-28T18:54:14Z","pushed_at":"2014-07-17T18:43:24Z","git_url":"git://github.com/alfredxing/jekyll.git","ssh_url":"git@github.com:alfredxing/jekyll.git","clone_url":"https://github.com/alfredxing/jekyll.git","svn_url":"https://github.com/alfredxing/jekyll","homepage":"http://jekyllrb.com","size":5990,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jekyll:master","ref":"master","sha":"a262ea02d9e08754a5431847eba77210403fee55","user":{"login":"jekyll","id":3083652,"avatar_url":"https://avatars.githubusercontent.com/u/3083652?","gravatar_id":"74a33d48da0490ba1266c4bac8c12eeb","url":"https://api.github.com/users/jekyll","html_url":"https://github.com/jekyll","followers_url":"https://api.github.com/users/jekyll/followers","following_url":"https://api.github.com/users/jekyll/following{/other_user}","gists_url":"https://api.github.com/users/jekyll/gists{/gist_id}","starred_url":"https://api.github.com/users/jekyll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jekyll/subscriptions","organizations_url":"https://api.github.com/users/jekyll/orgs","repos_url":"https://api.github.com/users/jekyll/repos","events_url":"https://api.github.com/users/jekyll/events{/privacy}","received_events_url":"https://api.github.com/users/jekyll/received_events","type":"Organization","site_admin":false},"repo":{"id":65252,"name":"jekyll","full_name":"jekyll/jekyll","owner":{"login":"jekyll","id":3083652,"avatar_url":"https://avatars.githubusercontent.com/u/3083652?","gravatar_id":"74a33d48da0490ba1266c4bac8c12eeb","url":"https://api.github.com/users/jekyll","html_url":"https://github.com/jekyll","followers_url":"https://api.github.com/users/jekyll/followers","following_url":"https://api.github.com/users/jekyll/following{/other_user}","gists_url":"https://api.github.com/users/jekyll/gists{/gist_id}","starred_url":"https://api.github.com/users/jekyll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jekyll/subscriptions","organizations_url":"https://api.github.com/users/jekyll/orgs","repos_url":"https://api.github.com/users/jekyll/repos","events_url":"https://api.github.com/users/jekyll/events{/privacy}","received_events_url":"https://api.github.com/users/jekyll/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jekyll/jekyll","description":"Jekyll is a blog-aware, static site generator in Ruby","fork":false,"url":"https://api.github.com/repos/jekyll/jekyll","forks_url":"https://api.github.com/repos/jekyll/jekyll/forks","keys_url":"https://api.github.com/repos/jekyll/jekyll/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jekyll/jekyll/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jekyll/jekyll/teams","hooks_url":"https://api.github.com/repos/jekyll/jekyll/hooks","issue_events_url":"https://api.github.com/repos/jekyll/jekyll/issues/events{/number}","events_url":"https://api.github.com/repos/jekyll/jekyll/events","assignees_url":"https://api.github.com/repos/jekyll/jekyll/assignees{/user}","branches_url":"https://api.github.com/repos/jekyll/jekyll/branches{/branch}","tags_url":"https://api.github.com/repos/jekyll/jekyll/tags","blobs_url":"https://api.github.com/repos/jekyll/jekyll/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jekyll/jekyll/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jekyll/jekyll/git/refs{/sha}","trees_url":"https://api.github.com/repos/jekyll/jekyll/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jekyll/jekyll/statuses/{sha}","languages_url":"https://api.github.com/repos/jekyll/jekyll/languages","stargazers_url":"https://api.github.com/repos/jekyll/jekyll/stargazers","contributors_url":"https://api.github.com/repos/jekyll/jekyll/contributors","subscribers_url":"https://api.github.com/repos/jekyll/jekyll/subscribers","subscription_url":"https://api.github.com/repos/jekyll/jekyll/subscription","commits_url":"https://api.github.com/repos/jekyll/jekyll/commits{/sha}","git_commits_url":"https://api.github.com/repos/jekyll/jekyll/git/commits{/sha}","comments_url":"https://api.github.com/repos/jekyll/jekyll/comments{/number}","issue_comment_url":"https://api.github.com/repos/jekyll/jekyll/issues/comments/{number}","contents_url":"https://api.github.com/repos/jekyll/jekyll/contents/{+path}","compare_url":"https://api.github.com/repos/jekyll/jekyll/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jekyll/jekyll/merges","archive_url":"https://api.github.com/repos/jekyll/jekyll/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jekyll/jekyll/downloads","issues_url":"https://api.github.com/repos/jekyll/jekyll/issues{/number}","pulls_url":"https://api.github.com/repos/jekyll/jekyll/pulls{/number}","milestones_url":"https://api.github.com/repos/jekyll/jekyll/milestones{/number}","notifications_url":"https://api.github.com/repos/jekyll/jekyll/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jekyll/jekyll/labels{/name}","releases_url":"https://api.github.com/repos/jekyll/jekyll/releases{/id}","created_at":"2008-10-20T06:29:03Z","updated_at":"2014-07-19T23:28:49Z","pushed_at":"2014-07-18T18:18:49Z","git_url":"git://github.com/jekyll/jekyll.git","ssh_url":"git@github.com:jekyll/jekyll.git","clone_url":"https://github.com/jekyll/jekyll.git","svn_url":"https://github.com/jekyll/jekyll","homepage":"http://jekyllrb.com","size":78812,"stargazers_count":15957,"watchers_count":15957,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":3235,"mirror_url":null,"open_issues_count":132,"forks":3235,"open_issues":132,"watchers":15957,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jekyll/jekyll/pulls/2615"},"html":{"href":"https://github.com/jekyll/jekyll/pull/2615"},"issue":{"href":"https://api.github.com/repos/jekyll/jekyll/issues/2615"},"comments":{"href":"https://api.github.com/repos/jekyll/jekyll/issues/2615/comments"},"review_comments":{"href":"https://api.github.com/repos/jekyll/jekyll/pulls/2615/comments"},"review_comment":{"href":"https://api.github.com/repos/jekyll/jekyll/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/jekyll/jekyll/pulls/2615/commits"},"statuses":{"href":"https://api.github.com/repos/jekyll/jekyll/statuses/3456373b32c66a3d5ca419334e14fe2b108bffd0"}}}}