GitHub PullRequestReviewCommentEvent at 2014-12-15 11:28:09
Repository: GeneratorBundle
Actor: loostro
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/symfony2admingenerator/GeneratorBundle/pulls/comments/21818232","id":21818232,"diff_hunk":"@@ -21,6 +22,8 @@\n         }\n \n         if (isset($filters)) {\n+            // Remove activated scopes","path":"Resources/templates/CommonAdmin/ListAction/filters.php.twig","position":12,"original_position":12,"commit_id":"a928c119f24e352792a6a4471807d84b77697169","original_commit_id":"a928c119f24e352792a6a4471807d84b77697169","user":{"login":"loostro","id":1419884,"avatar_url":"https://avatars.githubusercontent.com/u/1419884?v=3","gravatar_id":"","url":"https://api.github.com/users/loostro","html_url":"https://github.com/loostro","followers_url":"https://api.github.com/users/loostro/followers","following_url":"https://api.github.com/users/loostro/following{/other_user}","gists_url":"https://api.github.com/users/loostro/gists{/gist_id}","starred_url":"https://api.github.com/users/loostro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loostro/subscriptions","organizations_url":"https://api.github.com/users/loostro/orgs","repos_url":"https://api.github.com/users/loostro/repos","events_url":"https://api.github.com/users/loostro/events{/privacy}","received_events_url":"https://api.github.com/users/loostro/received_events","type":"User","site_admin":false},"body":"OK, this is a very simple solution. Though I am wondering,, what happens if:\r\na) user selects scopeA\r\nb) scopeA pre-fills filterA and filterB\r\nc) user clicks \"submit filter\" (without changeing anything)\r\n\r\nShouldn't then \"scopeA\" stay \"active\"? The current implementation (if I understand correct) will remove \"scopeA\" in this case.\r\n\r\nThis is just something to discuss. It's not merge-blocking.","created_at":"2014-12-15T11:28:09Z","updated_at":"2014-12-15T11:28:09Z","html_url":"https://github.com/symfony2admingenerator/GeneratorBundle/pull/64#discussion_r21818232","pull_request_url":"https://api.github.com/repos/symfony2admingenerator/GeneratorBundle/pulls/64","_links":{"self":{"href":"https://api.github.com/repos/symfony2admingenerator/GeneratorBundle/pulls/comments/21818232"},"html":{"href":"https://github.com/symfony2admingenerator/GeneratorBundle/pull/64#discussion_r21818232"},"pull_request":{"href":"https://api.github.com/repos/symfony2admingenerator/GeneratorBundle/pulls/64"}}},"pull_request":{"url":"https://api.github.com/repos/symfony2admingenerator/GeneratorBundle/pulls/64","id":26040798,"html_url":"https://github.com/symfony2admingenerator/GeneratorBundle/pull/64","diff_url":"https://github.com/symfony2admingenerator/GeneratorBundle/pull/64.diff","patch_url":"https://github.com/symfony2admingenerator/GeneratorBundle/pull/64.patch","issue_url":"https://api.github.com/repos/symfony2admingenerator/GeneratorBundle/issues/64","number":64,"state":"open","locked":false,"title":"[Scopes] Synchronize scopes and filters (fix issue60)","user":{"login":"sescandell","id":1559970,"avatar_url":"https://avatars.githubusercontent.com/u/1559970?v=3","gravatar_id":"","url":"https://api.github.com/users/sescandell","html_url":"https://github.com/sescandell","followers_url":"https://api.github.com/users/sescandell/followers","following_url":"https://api.github.com/users/sescandell/following{/other_user}","gists_url":"https://api.github.com/users/sescandell/gists{/gist_id}","starred_url":"https://api.github.com/users/sescandell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sescandell/subscriptions","organizations_url":"https://api.github.com/users/sescandell/orgs","repos_url":"https://api.github.com/users/sescandell/repos","events_url":"https://api.github.com/users/sescandell/events{/privacy}","received_events_url":"https://api.github.com/users/sescandell/received_events","type":"User","site_admin":false},"body":"3 main changes in this PR:\r\n 1. Move `processScopes` to `commonAdmin` directory\r\n 1. Synchronize filters and scopes (fix issue #60 )\r\n 1. Fix multi-group scopes management (especially for generated views)\r\n\r\nDemo repository updated to test this behavior.\r\n\r\nPR ready to merge, waiting for your feedbacks\r\n\r\n/cc @loostro ","created_at":"2014-12-14T23:10:17Z","updated_at":"2014-12-15T11:28:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"33ed92dae2f00b93c05202cf4ee6830db1e09dce","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/symfony2admingenerator/GeneratorBundle/pulls/64/commits","review_comments_url":"https://api.github.com/repos/symfony2admingenerator/GeneratorBundle/pulls/64/comments","review_comment_url":"https://api.github.com/repos/symfony2admingenerator/GeneratorBundle/pulls/comments/{number}","comments_url":"https://api.github.com/repos/symfony2admingenerator/GeneratorBundle/issues/64/comments","statuses_url":"https://api.github.com/repos/symfony2admingenerator/GeneratorBundle/statuses/a928c119f24e352792a6a4471807d84b77697169","head":{"label":"symfony2admingenerator:fix-issue60","ref":"fix-issue60","sha":"a928c119f24e352792a6a4471807d84b77697169","user":{"login":"symfony2admingenerator","id":2056793,"avatar_url":"https://avatars.githubusercontent.com/u/2056793?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony2admingenerator","html_url":"https://github.com/symfony2admingenerator","followers_url":"https://api.github.com/users/symfony2admingenerator/followers","following_url":"https://api.github.com/users/symfony2admingenerator/following{/other_user}","gists_url":"https://api.github.com/users/symfony2admingenerator/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony2admingenerator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony2admingenerator/subscriptions","organizations_url":"https://api.github.com/users/symfony2admingenerator/orgs","repos_url":"https://api.github.com/users/symfony2admingenerator/repos","events_url":"https://api.github.com/users/symfony2admingenerator/events{/privacy}","received_events_url":"https://api.github.com/users/symfony2admingenerator/received_events","type":"Organization","site_admin":false},"repo":{"id":22714539,"name":"GeneratorBundle","full_name":"symfony2admingenerator/GeneratorBundle","owner":{"login":"symfony2admingenerator","id":2056793,"avatar_url":"https://avatars.githubusercontent.com/u/2056793?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony2admingenerator","html_url":"https://github.com/symfony2admingenerator","followers_url":"https://api.github.com/users/symfony2admingenerator/followers","following_url":"https://api.github.com/users/symfony2admingenerator/following{/other_user}","gists_url":"https://api.github.com/users/symfony2admingenerator/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony2admingenerator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony2admingenerator/subscriptions","organizations_url":"https://api.github.com/users/symfony2admingenerator/orgs","repos_url":"https://api.github.com/users/symfony2admingenerator/repos","events_url":"https://api.github.com/users/symfony2admingenerator/events{/privacy}","received_events_url":"https://api.github.com/users/symfony2admingenerator/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony2admingenerator/GeneratorBundle","description":"(new-unstable) Admingenerator for Symfony2. Parse YAML files to build customized backend.","fork":false,"url":"https://api.github.com/repos/symfony2admingenerator/GeneratorBundle","forks_url":"https://api.github.com/repos/symfony2admingenerator/GeneratorBundle/forks","keys_url":"https://api.github.com/repos/symfony2admingenerator/GeneratorBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony2admingenerator/GeneratorBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony2admingenerator/GeneratorBundle/teams","hooks_url":"https://api.github.com/repos/symfony2admingenerator/GeneratorBundle/hooks","issue_events_url":"https://api.github.com/repos/symfony2admingenerator/GeneratorBundle/issues/events{/number}","events_url":"https://api.github.com/repos/symfony2admingenerator/GeneratorBundle/events","assignees_url":"https://api.github.com/repos/symfony2admingenerator/GeneratorBundle/assignees{/user}","branches_url":"https://api.github.com/repos/symfony2admingenerator/GeneratorBundle/branches{/branch}","tags_url":"https://api.github.com/repos/symfony2admingenerator/GeneratorBundle/tags","blobs_url":"https://api.github.com/repos/symfony2admingenerator/GeneratorBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony2admingenerator/GeneratorBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony2admingenerator/GeneratorBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony2admingenerator/GeneratorBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony2admingenerator/GeneratorBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony2admingenerator/GeneratorBundle/languages","stargazers_url":"https://api.github.com/repos/symfony2admingenerator/GeneratorBundle/stargazers","contributors_url":"https://api.github.com/repos/symfony2admingenerator/GeneratorBundle/contributors","subscribers_url":"https://api.github.com/repos/symfony2admingenerator/GeneratorBundle/subscribers","subscription_url":"https://api.github.com/repos/symfony2admingenerator/GeneratorBundle/subscription","commits_url":"https://api.github.com/repos/symfony2admingenerator/GeneratorBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony2admingenerator/GeneratorBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony2admingenerator/GeneratorBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony2admingenerator/GeneratorBundle/issues/comments/{number}","contents_url":"https://api.github.com/repos/symfony2admingenerator/GeneratorBundle/contents/{+path}","compare_url":"https://api.github.com/repos/symfony2admingenerator/GeneratorBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony2admingenerator/GeneratorBundle/merges","archive_url":"https://api.github.com/repos/symfony2admingenerator/GeneratorBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony2admingenerator/GeneratorBundle/downloads","issues_url":"https://api.github.com/repos/symfony2admingenerator/GeneratorBundle/issues{/number}","pulls_url":"https://api.github.com/repos/symfony2admingenerator/GeneratorBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony2admingenerator/GeneratorBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony2admingenerator/GeneratorBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony2admingenerator/GeneratorBundle/labels{/name}","releases_url":"https://api.github.com/repos/symfony2admingenerator/GeneratorBundle/releases{/id}","created_at":"2014-08-07T08:46:32Z","updated_at":"2014-12-15T11:20:20Z","pushed_at":"2014-12-15T11:23:07Z","git_url":"git://github.com/symfony2admingenerator/GeneratorBundle.git","ssh_url":"git@github.com:symfony2admingenerator/GeneratorBundle.git","clone_url":"https://github.com/symfony2admingenerator/GeneratorBundle.git","svn_url":"https://github.com/symfony2admingenerator/GeneratorBundle","homepage":"","size":2837,"stargazers_count":8,"watchers_count":8,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":26,"forks":7,"open_issues":26,"watchers":8,"default_branch":"master"}},"base":{"label":"symfony2admingenerator:master","ref":"master","sha":"01b1193673df1e54373603abf517adbd8c28deae","user":{"login":"symfony2admingenerator","id":2056793,"avatar_url":"https://avatars.githubusercontent.com/u/2056793?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony2admingenerator","html_url":"https://github.com/symfony2admingenerator","followers_url":"https://api.github.com/users/symfony2admingenerator/followers","following_url":"https://api.github.com/users/symfony2admingenerator/following{/other_user}","gists_url":"https://api.github.com/users/symfony2admingenerator/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony2admingenerator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony2admingenerator/subscriptions","organizations_url":"https://api.github.com/users/symfony2admingenerator/orgs","repos_url":"https://api.github.com/users/symfony2admingenerator/repos","events_url":"https://api.github.com/users/symfony2admingenerator/events{/privacy}","received_events_url":"https://api.github.com/users/symfony2admingenerator/received_events","type":"Organization","site_admin":false},"repo":{"id":22714539,"name":"GeneratorBundle","full_name":"symfony2admingenerator/GeneratorBundle","owner":{"login":"symfony2admingenerator","id":2056793,"avatar_url":"https://avatars.githubusercontent.com/u/2056793?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony2admingenerator","html_url":"https://github.com/symfony2admingenerator","followers_url":"https://api.github.com/users/symfony2admingenerator/followers","following_url":"https://api.github.com/users/symfony2admingenerator/following{/other_user}","gists_url":"https://api.github.com/users/symfony2admingenerator/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony2admingenerator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony2admingenerator/subscriptions","organizations_url":"https://api.github.com/users/symfony2admingenerator/orgs","repos_url":"https://api.github.com/users/symfony2admingenerator/repos","events_url":"https://api.github.com/users/symfony2admingenerator/events{/privacy}","received_events_url":"https://api.github.com/users/symfony2admingenerator/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony2admingenerator/GeneratorBundle","description":"(new-unstable) Admingenerator for Symfony2. Parse YAML files to build customized backend.","fork":false,"url":"https://api.github.com/repos/symfony2admingenerator/GeneratorBundle","forks_url":"https://api.github.com/repos/symfony2admingenerator/GeneratorBundle/forks","keys_url":"https://api.github.com/repos/symfony2admingenerator/GeneratorBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony2admingenerator/GeneratorBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony2admingenerator/GeneratorBundle/teams","hooks_url":"https://api.github.com/repos/symfony2admingenerator/GeneratorBundle/hooks","issue_events_url":"https://api.github.com/repos/symfony2admingenerator/GeneratorBundle/issues/events{/number}","events_url":"https://api.github.com/repos/symfony2admingenerator/GeneratorBundle/events","assignees_url":"https://api.github.com/repos/symfony2admingenerator/GeneratorBundle/assignees{/user}","branches_url":"https://api.github.com/repos/symfony2admingenerator/GeneratorBundle/branches{/branch}","tags_url":"https://api.github.com/repos/symfony2admingenerator/GeneratorBundle/tags","blobs_url":"https://api.github.com/repos/symfony2admingenerator/GeneratorBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony2admingenerator/GeneratorBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony2admingenerator/GeneratorBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony2admingenerator/GeneratorBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony2admingenerator/GeneratorBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony2admingenerator/GeneratorBundle/languages","stargazers_url":"https://api.github.com/repos/symfony2admingenerator/GeneratorBundle/stargazers","contributors_url":"https://api.github.com/repos/symfony2admingenerator/GeneratorBundle/contributors","subscribers_url":"https://api.github.com/repos/symfony2admingenerator/GeneratorBundle/subscribers","subscription_url":"https://api.github.com/repos/symfony2admingenerator/GeneratorBundle/subscription","commits_url":"https://api.github.com/repos/symfony2admingenerator/GeneratorBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony2admingenerator/GeneratorBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony2admingenerator/GeneratorBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony2admingenerator/GeneratorBundle/issues/comments/{number}","contents_url":"https://api.github.com/repos/symfony2admingenerator/GeneratorBundle/contents/{+path}","compare_url":"https://api.github.com/repos/symfony2admingenerator/GeneratorBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony2admingenerator/GeneratorBundle/merges","archive_url":"https://api.github.com/repos/symfony2admingenerator/GeneratorBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony2admingenerator/GeneratorBundle/downloads","issues_url":"https://api.github.com/repos/symfony2admingenerator/GeneratorBundle/issues{/number}","pulls_url":"https://api.github.com/repos/symfony2admingenerator/GeneratorBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony2admingenerator/GeneratorBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony2admingenerator/GeneratorBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony2admingenerator/GeneratorBundle/labels{/name}","releases_url":"https://api.github.com/repos/symfony2admingenerator/GeneratorBundle/releases{/id}","created_at":"2014-08-07T08:46:32Z","updated_at":"2014-12-15T11:20:20Z","pushed_at":"2014-12-15T11:23:07Z","git_url":"git://github.com/symfony2admingenerator/GeneratorBundle.git","ssh_url":"git@github.com:symfony2admingenerator/GeneratorBundle.git","clone_url":"https://github.com/symfony2admingenerator/GeneratorBundle.git","svn_url":"https://github.com/symfony2admingenerator/GeneratorBundle","homepage":"","size":2837,"stargazers_count":8,"watchers_count":8,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":26,"forks":7,"open_issues":26,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony2admingenerator/GeneratorBundle/pulls/64"},"html":{"href":"https://github.com/symfony2admingenerator/GeneratorBundle/pull/64"},"issue":{"href":"https://api.github.com/repos/symfony2admingenerator/GeneratorBundle/issues/64"},"comments":{"href":"https://api.github.com/repos/symfony2admingenerator/GeneratorBundle/issues/64/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony2admingenerator/GeneratorBundle/pulls/64/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony2admingenerator/GeneratorBundle/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/symfony2admingenerator/GeneratorBundle/pulls/64/commits"},"statuses":{"href":"https://api.github.com/repos/symfony2admingenerator/GeneratorBundle/statuses/a928c119f24e352792a6a4471807d84b77697169"}}}}