GitHub PullRequestReviewCommentEvent at 2014-11-22 12:57:05
Repository: cesium
Actor: pjcozzi
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/comments/20757002","id":20757002,"diff_hunk":"@@ -185,8 +186,11 @@ define([\n                 that._credit = new Credit(data.attribution);\n             }\n \n-            if (defined(data.extensions) && data.extensions.indexOf('vertexnormals') !== -1) {\n+            if (defined(data.extensions) && data.extensions.indexOf('octvertexnormals') !== -1) {","path":"Source/Core/CesiumTerrainProvider.js","position":13,"original_position":13,"commit_id":"6340a15acef44e7220750a0f20df4672b4556c07","original_commit_id":"6340a15acef44e7220750a0f20df4672b4556c07","user":{"login":"pjcozzi","id":782098,"avatar_url":"https://avatars.githubusercontent.com/u/782098?v=3","gravatar_id":"","url":"https://api.github.com/users/pjcozzi","html_url":"https://github.com/pjcozzi","followers_url":"https://api.github.com/users/pjcozzi/followers","following_url":"https://api.github.com/users/pjcozzi/following{/other_user}","gists_url":"https://api.github.com/users/pjcozzi/gists{/gist_id}","starred_url":"https://api.github.com/users/pjcozzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pjcozzi/subscriptions","organizations_url":"https://api.github.com/users/pjcozzi/orgs","repos_url":"https://api.github.com/users/pjcozzi/repos","events_url":"https://api.github.com/users/pjcozzi/events{/privacy}","received_events_url":"https://api.github.com/users/pjcozzi/received_events","type":"User","site_admin":false},"body":"Can we add a comment about the workaround so it is clear why we are doing this?","created_at":"2014-11-22T12:57:05Z","updated_at":"2014-11-22T12:57:05Z","html_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/2291#discussion_r20757002","pull_request_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/2291","_links":{"self":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/comments/20757002"},"html":{"href":"https://github.com/AnalyticalGraphicsInc/cesium/pull/2291#discussion_r20757002"},"pull_request":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/2291"}}},"pull_request":{"url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/2291","id":24842614,"html_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/2291","diff_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/2291.diff","patch_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/2291.patch","issue_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/2291","number":2291,"state":"open","locked":false,"title":"Quantized mesh extensions fix","user":{"login":"abwood","id":3868547,"avatar_url":"https://avatars.githubusercontent.com/u/3868547?v=3","gravatar_id":"","url":"https://api.github.com/users/abwood","html_url":"https://github.com/abwood","followers_url":"https://api.github.com/users/abwood/followers","following_url":"https://api.github.com/users/abwood/following{/other_user}","gists_url":"https://api.github.com/users/abwood/gists{/gist_id}","starred_url":"https://api.github.com/users/abwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abwood/subscriptions","organizations_url":"https://api.github.com/users/abwood/orgs","repos_url":"https://api.github.com/users/abwood/repos","events_url":"https://api.github.com/users/abwood/events{/privacy}","received_events_url":"https://api.github.com/users/abwood/received_events","type":"User","site_admin":false},"body":"This pull request fixes the handling of Quantized-Mesh extensions, where extension size is now extracted in little endian.  This error went unnoticed, because the actual error was on the Terrain Server where the extension size was serialized in big endian.\r\n\r\nWith this pull request, the following cases are handled:\r\nCesium 1.0 client requesting vertex normals from Terrain Server 1.0\r\nCesium 1.0 client requesting vertex normals from the patched Terrain Server 1.1\r\nCesium master requesting vertex normals from Terrain Server 1.0\r\nCesium master requesting vertex normals from patched Terrain Server 1.1\r\n\r\nThe patched Terrain Server 1.1 publishes the vertex normal extension under the new name, \"octvertexnormals\".  Requesting the former \"vertexnormals\" extension will return the extension with the extension size uint32 still in big endian.\r\n\r\nTo test, I've updated the unit tests request the octvertexnormal extension in addition to the former \"vertexnormal\" extension. The patched Terrain Server 1.1 has also been deployed on assets.agi.com for test (//assets.agi.com/stk-terrain-new).  For example, in sand castle you can access the new terrain server instance as follows:\r\n```\r\nvar viewer = new Cesium.Viewer('cesiumContainer');\r\nviewer.scene.globe.enableLighting = true;\r\nviewer.scene.terrainProvider = new Cesium.CesiumTerrainProvider({\r\n    url: '//assets.agi.com/stk-terrain-new/v1/tilesets/world/tiles',\r\n    requestVertexNormals : true\r\n});\r\n```\r\n//assets.agi.com/terrain is still live for testing Cesium compatibility with Terrain Server v1.0.  Once merged we'll go live with the patched Terrain Server v1.1","created_at":"2014-11-21T14:24:29Z","updated_at":"2014-11-22T12:57:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6f08240249715ecb848013e9a1b71316ba113f83","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/2291/commits","review_comments_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/2291/comments","review_comment_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/comments/{number}","comments_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/2291/comments","statuses_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/statuses/6340a15acef44e7220750a0f20df4672b4556c07","head":{"label":"abwood:quantizedMeshExtensionsFix","ref":"quantizedMeshExtensionsFix","sha":"6340a15acef44e7220750a0f20df4672b4556c07","user":{"login":"abwood","id":3868547,"avatar_url":"https://avatars.githubusercontent.com/u/3868547?v=3","gravatar_id":"","url":"https://api.github.com/users/abwood","html_url":"https://github.com/abwood","followers_url":"https://api.github.com/users/abwood/followers","following_url":"https://api.github.com/users/abwood/following{/other_user}","gists_url":"https://api.github.com/users/abwood/gists{/gist_id}","starred_url":"https://api.github.com/users/abwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abwood/subscriptions","organizations_url":"https://api.github.com/users/abwood/orgs","repos_url":"https://api.github.com/users/abwood/repos","events_url":"https://api.github.com/users/abwood/events{/privacy}","received_events_url":"https://api.github.com/users/abwood/received_events","type":"User","site_admin":false},"repo":{"id":8785187,"name":"cesium","full_name":"abwood/cesium","owner":{"login":"abwood","id":3868547,"avatar_url":"https://avatars.githubusercontent.com/u/3868547?v=3","gravatar_id":"","url":"https://api.github.com/users/abwood","html_url":"https://github.com/abwood","followers_url":"https://api.github.com/users/abwood/followers","following_url":"https://api.github.com/users/abwood/following{/other_user}","gists_url":"https://api.github.com/users/abwood/gists{/gist_id}","starred_url":"https://api.github.com/users/abwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abwood/subscriptions","organizations_url":"https://api.github.com/users/abwood/orgs","repos_url":"https://api.github.com/users/abwood/repos","events_url":"https://api.github.com/users/abwood/events{/privacy}","received_events_url":"https://api.github.com/users/abwood/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/abwood/cesium","description":"WebGL virtual globe and map engine","fork":true,"url":"https://api.github.com/repos/abwood/cesium","forks_url":"https://api.github.com/repos/abwood/cesium/forks","keys_url":"https://api.github.com/repos/abwood/cesium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/abwood/cesium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/abwood/cesium/teams","hooks_url":"https://api.github.com/repos/abwood/cesium/hooks","issue_events_url":"https://api.github.com/repos/abwood/cesium/issues/events{/number}","events_url":"https://api.github.com/repos/abwood/cesium/events","assignees_url":"https://api.github.com/repos/abwood/cesium/assignees{/user}","branches_url":"https://api.github.com/repos/abwood/cesium/branches{/branch}","tags_url":"https://api.github.com/repos/abwood/cesium/tags","blobs_url":"https://api.github.com/repos/abwood/cesium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/abwood/cesium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/abwood/cesium/git/refs{/sha}","trees_url":"https://api.github.com/repos/abwood/cesium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/abwood/cesium/statuses/{sha}","languages_url":"https://api.github.com/repos/abwood/cesium/languages","stargazers_url":"https://api.github.com/repos/abwood/cesium/stargazers","contributors_url":"https://api.github.com/repos/abwood/cesium/contributors","subscribers_url":"https://api.github.com/repos/abwood/cesium/subscribers","subscription_url":"https://api.github.com/repos/abwood/cesium/subscription","commits_url":"https://api.github.com/repos/abwood/cesium/commits{/sha}","git_commits_url":"https://api.github.com/repos/abwood/cesium/git/commits{/sha}","comments_url":"https://api.github.com/repos/abwood/cesium/comments{/number}","issue_comment_url":"https://api.github.com/repos/abwood/cesium/issues/comments/{number}","contents_url":"https://api.github.com/repos/abwood/cesium/contents/{+path}","compare_url":"https://api.github.com/repos/abwood/cesium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/abwood/cesium/merges","archive_url":"https://api.github.com/repos/abwood/cesium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/abwood/cesium/downloads","issues_url":"https://api.github.com/repos/abwood/cesium/issues{/number}","pulls_url":"https://api.github.com/repos/abwood/cesium/pulls{/number}","milestones_url":"https://api.github.com/repos/abwood/cesium/milestones{/number}","notifications_url":"https://api.github.com/repos/abwood/cesium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/abwood/cesium/labels{/name}","releases_url":"https://api.github.com/repos/abwood/cesium/releases{/id}","created_at":"2013-03-14T20:54:36Z","updated_at":"2014-11-20T15:08:54Z","pushed_at":"2014-11-20T22:19:18Z","git_url":"git://github.com/abwood/cesium.git","ssh_url":"git@github.com:abwood/cesium.git","clone_url":"https://github.com/abwood/cesium.git","svn_url":"https://github.com/abwood/cesium","homepage":"http://cesium.agi.com/","size":236864,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"AnalyticalGraphicsInc:master","ref":"master","sha":"71f3535c9fb9866c2f3148931c89cf88bd5c808f","user":{"login":"AnalyticalGraphicsInc","id":1490220,"avatar_url":"https://avatars.githubusercontent.com/u/1490220?v=3","gravatar_id":"","url":"https://api.github.com/users/AnalyticalGraphicsInc","html_url":"https://github.com/AnalyticalGraphicsInc","followers_url":"https://api.github.com/users/AnalyticalGraphicsInc/followers","following_url":"https://api.github.com/users/AnalyticalGraphicsInc/following{/other_user}","gists_url":"https://api.github.com/users/AnalyticalGraphicsInc/gists{/gist_id}","starred_url":"https://api.github.com/users/AnalyticalGraphicsInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnalyticalGraphicsInc/subscriptions","organizations_url":"https://api.github.com/users/AnalyticalGraphicsInc/orgs","repos_url":"https://api.github.com/users/AnalyticalGraphicsInc/repos","events_url":"https://api.github.com/users/AnalyticalGraphicsInc/events{/privacy}","received_events_url":"https://api.github.com/users/AnalyticalGraphicsInc/received_events","type":"Organization","site_admin":false},"repo":{"id":3606738,"name":"cesium","full_name":"AnalyticalGraphicsInc/cesium","owner":{"login":"AnalyticalGraphicsInc","id":1490220,"avatar_url":"https://avatars.githubusercontent.com/u/1490220?v=3","gravatar_id":"","url":"https://api.github.com/users/AnalyticalGraphicsInc","html_url":"https://github.com/AnalyticalGraphicsInc","followers_url":"https://api.github.com/users/AnalyticalGraphicsInc/followers","following_url":"https://api.github.com/users/AnalyticalGraphicsInc/following{/other_user}","gists_url":"https://api.github.com/users/AnalyticalGraphicsInc/gists{/gist_id}","starred_url":"https://api.github.com/users/AnalyticalGraphicsInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnalyticalGraphicsInc/subscriptions","organizations_url":"https://api.github.com/users/AnalyticalGraphicsInc/orgs","repos_url":"https://api.github.com/users/AnalyticalGraphicsInc/repos","events_url":"https://api.github.com/users/AnalyticalGraphicsInc/events{/privacy}","received_events_url":"https://api.github.com/users/AnalyticalGraphicsInc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AnalyticalGraphicsInc/cesium","description":"WebGL virtual globe and map engine","fork":false,"url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium","forks_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/forks","keys_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/teams","hooks_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/hooks","issue_events_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/events{/number}","events_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/events","assignees_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/assignees{/user}","branches_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/branches{/branch}","tags_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/tags","blobs_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/git/refs{/sha}","trees_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/statuses/{sha}","languages_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/languages","stargazers_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/stargazers","contributors_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/contributors","subscribers_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/subscribers","subscription_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/subscription","commits_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/commits{/sha}","git_commits_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/git/commits{/sha}","comments_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/comments{/number}","issue_comment_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/comments/{number}","contents_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/contents/{+path}","compare_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/merges","archive_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/downloads","issues_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues{/number}","pulls_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls{/number}","milestones_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/milestones{/number}","notifications_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/labels{/name}","releases_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/releases{/id}","created_at":"2012-03-02T22:27:14Z","updated_at":"2014-11-21T13:41:49Z","pushed_at":"2014-11-21T18:47:10Z","git_url":"git://github.com/AnalyticalGraphicsInc/cesium.git","ssh_url":"git@github.com:AnalyticalGraphicsInc/cesium.git","clone_url":"https://github.com/AnalyticalGraphicsInc/cesium.git","svn_url":"https://github.com/AnalyticalGraphicsInc/cesium","homepage":"cesiumjs.org","size":462564,"stargazers_count":588,"watchers_count":588,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":349,"mirror_url":null,"open_issues_count":254,"forks":349,"open_issues":254,"watchers":588,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/2291"},"html":{"href":"https://github.com/AnalyticalGraphicsInc/cesium/pull/2291"},"issue":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/2291"},"comments":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/2291/comments"},"review_comments":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/2291/comments"},"review_comment":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/2291/commits"},"statuses":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/statuses/6340a15acef44e7220750a0f20df4672b4556c07"}}}}