GitHub PullRequestReviewCommentEvent at 2014-02-03 13:07:07
Repository: FrameworkBenchmarks
Actor: Dith3r
Payload: {"comment":{"url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/pulls/comments/9381777","id":9381777,"diff_hunk":"@@ -9,15 +9,15 @@ public function index() {\n \t\t$this->layout = 'benchmark';\n \t\t$this->set('title_for_layout', 'Fortunes');\n \n-\t\t// using prepared query as encouraged by test rules\n-\t\t$db      = $this->Fortune->getDataSource();\n-\t\t$results = $db->fetchAll('SELECT * FROM Fortune');\n+\t\t// using ORM instead of raw SQL\n+\t\t$this->loadModel('Fortune');\n+\t\t$results = $this->Fortune->find('all');\n \n \t\t// stuffing in the dynamic data\n-\t\t$results[]['Fortune'] = [","path":"cake/app/Controller/FortunesController.php","position":12,"original_position":12,"commit_id":"f3d407da4ffbd10f2d2094f3baa0fe5800a317b0","original_commit_id":"f3d407da4ffbd10f2d2094f3baa0fe5800a317b0","user":{"login":"Dith3r","id":6515994,"avatar_url":"https://gravatar.com/avatar/b8b1433b96ff917526304e27e1c58afb?d=https%3A%2F%2Fidenticons.github.com%2F93b5eaadaf3c9a08ca83f7a626720f01.png&r=x","gravatar_id":"b8b1433b96ff917526304e27e1c58afb","url":"https://api.github.com/users/Dith3r","html_url":"https://github.com/Dith3r","followers_url":"https://api.github.com/users/Dith3r/followers","following_url":"https://api.github.com/users/Dith3r/following{/other_user}","gists_url":"https://api.github.com/users/Dith3r/gists{/gist_id}","starred_url":"https://api.github.com/users/Dith3r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dith3r/subscriptions","organizations_url":"https://api.github.com/users/Dith3r/orgs","repos_url":"https://api.github.com/users/Dith3r/repos","events_url":"https://api.github.com/users/Dith3r/events{/privacy}","received_events_url":"https://api.github.com/users/Dith3r/received_events","type":"User","site_admin":false},"body":"this syntax is ok in php 5.4 which should be used in tests.","created_at":"2014-02-03T13:07:07Z","updated_at":"2014-02-03T13:07:07Z","html_url":"https://github.com/TechEmpower/FrameworkBenchmarks/pull/682#discussion_r9381777","pull_request_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/pulls/682","_links":{"self":{"href":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/pulls/comments/9381777"},"html":{"href":"https://github.com/TechEmpower/FrameworkBenchmarks/pull/682#discussion_r9381777"},"pull_request":{"href":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/pulls/682"}}}}