GitHub PullRequestReviewCommentEvent at 2014-08-10 10:30:32
Repository: finagle
Actor: mosesn
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/twitter/finagle/pulls/comments/16030597","id":16030597,"diff_hunk":"@@ -73,7 +73,7 @@ class EndToEndTest extends FunSuite with ThriftTest with Eventually with BeforeA\n     }\n   }\n \n-  testThrift(\"propagate Dtab\") { (client, tracer) =>\n+  skipTestThrift(\"propagate Dtab\") { (client, tracer) =>","path":"finagle-thrift/src/test/scala/com/twitter/finagle/thrift/EndToEndTest.scala","position":5,"original_position":5,"commit_id":"255983d5fbbc95880d77c60340ece7d0521eb9aa","original_commit_id":"1531023e44d86200522c2aeb56e9252c992e9acb","user":{"login":"mosesn","id":156562,"avatar_url":"https://avatars.githubusercontent.com/u/156562?v=2","gravatar_id":"7ead26d6d4d0eeaece9e66ce021871a1","url":"https://api.github.com/users/mosesn","html_url":"https://github.com/mosesn","followers_url":"https://api.github.com/users/mosesn/followers","following_url":"https://api.github.com/users/mosesn/following{/other_user}","gists_url":"https://api.github.com/users/mosesn/gists{/gist_id}","starred_url":"https://api.github.com/users/mosesn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mosesn/subscriptions","organizations_url":"https://api.github.com/users/mosesn/orgs","repos_url":"https://api.github.com/users/mosesn/repos","events_url":"https://api.github.com/users/mosesn/events{/privacy}","received_events_url":"https://api.github.com/users/mosesn/received_events","type":"User","site_admin":false},"body":"Weird, it works for me.  Does it work for you from master?  Which sbt are you using, the provided one?  How are you running the test?","created_at":"2014-08-10T10:30:32Z","updated_at":"2014-08-10T10:30:32Z","html_url":"https://github.com/twitter/finagle/pull/291#discussion_r16030597","pull_request_url":"https://api.github.com/repos/twitter/finagle/pulls/291","_links":{"self":{"href":"https://api.github.com/repos/twitter/finagle/pulls/comments/16030597"},"html":{"href":"https://github.com/twitter/finagle/pull/291#discussion_r16030597"},"pull_request":{"href":"https://api.github.com/repos/twitter/finagle/pulls/291"}}},"pull_request":{"url":"https://api.github.com/repos/twitter/finagle/pulls/291","id":18008324,"html_url":"https://github.com/twitter/finagle/pull/291","diff_url":"https://github.com/twitter/finagle/pull/291.diff","patch_url":"https://github.com/twitter/finagle/pull/291.patch","issue_url":"https://api.github.com/repos/twitter/finagle/issues/291","number":291,"state":"open","title":"Migrate finagle-thrift/finagle-stream tests to ScalaTest","user":{"login":"bajohns","id":333607,"avatar_url":"https://avatars.githubusercontent.com/u/333607?v=2","gravatar_id":"60ca65f0ea998d50a5d9ec9536c00381","url":"https://api.github.com/users/bajohns","html_url":"https://github.com/bajohns","followers_url":"https://api.github.com/users/bajohns/followers","following_url":"https://api.github.com/users/bajohns/following{/other_user}","gists_url":"https://api.github.com/users/bajohns/gists{/gist_id}","starred_url":"https://api.github.com/users/bajohns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bajohns/subscriptions","organizations_url":"https://api.github.com/users/bajohns/orgs","repos_url":"https://api.github.com/users/bajohns/repos","events_url":"https://api.github.com/users/bajohns/events{/privacy}","received_events_url":"https://api.github.com/users/bajohns/received_events","type":"User","site_admin":false},"body":"In preparation for 2.11.x finagle-thrift tests will migrate to ScalaTest\r\n\r\n\r\nRemaining Work:\r\n1) Finagle-Streams\r\n2) 2.11.x testing\r\n3) Conversation about FinagleClientThriftServerSpec structure\r\n4) Renaming tests from *Spec -> *Test\r\n5) Clean up commit history and conform to commit message standards","created_at":"2014-07-05T07:17:13Z","updated_at":"2014-08-10T10:30:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"19b76ab67ff678cda4b7a5113b485a0999605300","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/twitter/finagle/pulls/291/commits","review_comments_url":"https://api.github.com/repos/twitter/finagle/pulls/291/comments","review_comment_url":"https://api.github.com/repos/twitter/finagle/pulls/comments/{number}","comments_url":"https://api.github.com/repos/twitter/finagle/issues/291/comments","statuses_url":"https://api.github.com/repos/twitter/finagle/statuses/255983d5fbbc95880d77c60340ece7d0521eb9aa","head":{"label":"bajohns:thrift-to-scala-test","ref":"thrift-to-scala-test","sha":"255983d5fbbc95880d77c60340ece7d0521eb9aa","user":{"login":"bajohns","id":333607,"avatar_url":"https://avatars.githubusercontent.com/u/333607?v=2","gravatar_id":"60ca65f0ea998d50a5d9ec9536c00381","url":"https://api.github.com/users/bajohns","html_url":"https://github.com/bajohns","followers_url":"https://api.github.com/users/bajohns/followers","following_url":"https://api.github.com/users/bajohns/following{/other_user}","gists_url":"https://api.github.com/users/bajohns/gists{/gist_id}","starred_url":"https://api.github.com/users/bajohns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bajohns/subscriptions","organizations_url":"https://api.github.com/users/bajohns/orgs","repos_url":"https://api.github.com/users/bajohns/repos","events_url":"https://api.github.com/users/bajohns/events{/privacy}","received_events_url":"https://api.github.com/users/bajohns/received_events","type":"User","site_admin":false},"repo":{"id":21514990,"name":"finagle","full_name":"bajohns/finagle","owner":{"login":"bajohns","id":333607,"avatar_url":"https://avatars.githubusercontent.com/u/333607?v=2","gravatar_id":"60ca65f0ea998d50a5d9ec9536c00381","url":"https://api.github.com/users/bajohns","html_url":"https://github.com/bajohns","followers_url":"https://api.github.com/users/bajohns/followers","following_url":"https://api.github.com/users/bajohns/following{/other_user}","gists_url":"https://api.github.com/users/bajohns/gists{/gist_id}","starred_url":"https://api.github.com/users/bajohns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bajohns/subscriptions","organizations_url":"https://api.github.com/users/bajohns/orgs","repos_url":"https://api.github.com/users/bajohns/repos","events_url":"https://api.github.com/users/bajohns/events{/privacy}","received_events_url":"https://api.github.com/users/bajohns/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bajohns/finagle","description":"A fault tolerant, protocol-agnostic RPC system","fork":true,"url":"https://api.github.com/repos/bajohns/finagle","forks_url":"https://api.github.com/repos/bajohns/finagle/forks","keys_url":"https://api.github.com/repos/bajohns/finagle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bajohns/finagle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bajohns/finagle/teams","hooks_url":"https://api.github.com/repos/bajohns/finagle/hooks","issue_events_url":"https://api.github.com/repos/bajohns/finagle/issues/events{/number}","events_url":"https://api.github.com/repos/bajohns/finagle/events","assignees_url":"https://api.github.com/repos/bajohns/finagle/assignees{/user}","branches_url":"https://api.github.com/repos/bajohns/finagle/branches{/branch}","tags_url":"https://api.github.com/repos/bajohns/finagle/tags","blobs_url":"https://api.github.com/repos/bajohns/finagle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bajohns/finagle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bajohns/finagle/git/refs{/sha}","trees_url":"https://api.github.com/repos/bajohns/finagle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bajohns/finagle/statuses/{sha}","languages_url":"https://api.github.com/repos/bajohns/finagle/languages","stargazers_url":"https://api.github.com/repos/bajohns/finagle/stargazers","contributors_url":"https://api.github.com/repos/bajohns/finagle/contributors","subscribers_url":"https://api.github.com/repos/bajohns/finagle/subscribers","subscription_url":"https://api.github.com/repos/bajohns/finagle/subscription","commits_url":"https://api.github.com/repos/bajohns/finagle/commits{/sha}","git_commits_url":"https://api.github.com/repos/bajohns/finagle/git/commits{/sha}","comments_url":"https://api.github.com/repos/bajohns/finagle/comments{/number}","issue_comment_url":"https://api.github.com/repos/bajohns/finagle/issues/comments/{number}","contents_url":"https://api.github.com/repos/bajohns/finagle/contents/{+path}","compare_url":"https://api.github.com/repos/bajohns/finagle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bajohns/finagle/merges","archive_url":"https://api.github.com/repos/bajohns/finagle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bajohns/finagle/downloads","issues_url":"https://api.github.com/repos/bajohns/finagle/issues{/number}","pulls_url":"https://api.github.com/repos/bajohns/finagle/pulls{/number}","milestones_url":"https://api.github.com/repos/bajohns/finagle/milestones{/number}","notifications_url":"https://api.github.com/repos/bajohns/finagle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bajohns/finagle/labels{/name}","releases_url":"https://api.github.com/repos/bajohns/finagle/releases{/id}","created_at":"2014-07-05T07:04:24Z","updated_at":"2014-07-05T02:14:24Z","pushed_at":"2014-08-04T01:59:35Z","git_url":"git://github.com/bajohns/finagle.git","ssh_url":"git@github.com:bajohns/finagle.git","clone_url":"https://github.com/bajohns/finagle.git","svn_url":"https://github.com/bajohns/finagle","homepage":"http://twitter.github.io/finagle","size":19837,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"twitter:master","ref":"master","sha":"84e36f37a76f488d16e18ae827d6b8fa2a8be8ef","user":{"login":"twitter","id":50278,"avatar_url":"https://avatars.githubusercontent.com/u/50278?v=2","gravatar_id":"2f4a8254d032a8ec5e4c48d461e54fcc","url":"https://api.github.com/users/twitter","html_url":"https://github.com/twitter","followers_url":"https://api.github.com/users/twitter/followers","following_url":"https://api.github.com/users/twitter/following{/other_user}","gists_url":"https://api.github.com/users/twitter/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter/subscriptions","organizations_url":"https://api.github.com/users/twitter/orgs","repos_url":"https://api.github.com/users/twitter/repos","events_url":"https://api.github.com/users/twitter/events{/privacy}","received_events_url":"https://api.github.com/users/twitter/received_events","type":"Organization","site_admin":false},"repo":{"id":1007362,"name":"finagle","full_name":"twitter/finagle","owner":{"login":"twitter","id":50278,"avatar_url":"https://avatars.githubusercontent.com/u/50278?v=2","gravatar_id":"2f4a8254d032a8ec5e4c48d461e54fcc","url":"https://api.github.com/users/twitter","html_url":"https://github.com/twitter","followers_url":"https://api.github.com/users/twitter/followers","following_url":"https://api.github.com/users/twitter/following{/other_user}","gists_url":"https://api.github.com/users/twitter/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter/subscriptions","organizations_url":"https://api.github.com/users/twitter/orgs","repos_url":"https://api.github.com/users/twitter/repos","events_url":"https://api.github.com/users/twitter/events{/privacy}","received_events_url":"https://api.github.com/users/twitter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/twitter/finagle","description":"A fault tolerant, protocol-agnostic RPC system","fork":false,"url":"https://api.github.com/repos/twitter/finagle","forks_url":"https://api.github.com/repos/twitter/finagle/forks","keys_url":"https://api.github.com/repos/twitter/finagle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twitter/finagle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twitter/finagle/teams","hooks_url":"https://api.github.com/repos/twitter/finagle/hooks","issue_events_url":"https://api.github.com/repos/twitter/finagle/issues/events{/number}","events_url":"https://api.github.com/repos/twitter/finagle/events","assignees_url":"https://api.github.com/repos/twitter/finagle/assignees{/user}","branches_url":"https://api.github.com/repos/twitter/finagle/branches{/branch}","tags_url":"https://api.github.com/repos/twitter/finagle/tags","blobs_url":"https://api.github.com/repos/twitter/finagle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twitter/finagle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twitter/finagle/git/refs{/sha}","trees_url":"https://api.github.com/repos/twitter/finagle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twitter/finagle/statuses/{sha}","languages_url":"https://api.github.com/repos/twitter/finagle/languages","stargazers_url":"https://api.github.com/repos/twitter/finagle/stargazers","contributors_url":"https://api.github.com/repos/twitter/finagle/contributors","subscribers_url":"https://api.github.com/repos/twitter/finagle/subscribers","subscription_url":"https://api.github.com/repos/twitter/finagle/subscription","commits_url":"https://api.github.com/repos/twitter/finagle/commits{/sha}","git_commits_url":"https://api.github.com/repos/twitter/finagle/git/commits{/sha}","comments_url":"https://api.github.com/repos/twitter/finagle/comments{/number}","issue_comment_url":"https://api.github.com/repos/twitter/finagle/issues/comments/{number}","contents_url":"https://api.github.com/repos/twitter/finagle/contents/{+path}","compare_url":"https://api.github.com/repos/twitter/finagle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twitter/finagle/merges","archive_url":"https://api.github.com/repos/twitter/finagle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twitter/finagle/downloads","issues_url":"https://api.github.com/repos/twitter/finagle/issues{/number}","pulls_url":"https://api.github.com/repos/twitter/finagle/pulls{/number}","milestones_url":"https://api.github.com/repos/twitter/finagle/milestones{/number}","notifications_url":"https://api.github.com/repos/twitter/finagle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twitter/finagle/labels{/name}","releases_url":"https://api.github.com/repos/twitter/finagle/releases{/id}","created_at":"2010-10-19T22:10:09Z","updated_at":"2014-08-10T10:20:16Z","pushed_at":"2014-08-06T15:26:45Z","git_url":"git://github.com/twitter/finagle.git","ssh_url":"git@github.com:twitter/finagle.git","clone_url":"https://github.com/twitter/finagle.git","svn_url":"https://github.com/twitter/finagle","homepage":"http://twitter.github.io/finagle","size":26409,"stargazers_count":2744,"watchers_count":2744,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":472,"mirror_url":null,"open_issues_count":40,"forks":472,"open_issues":40,"watchers":2744,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/twitter/finagle/pulls/291"},"html":{"href":"https://github.com/twitter/finagle/pull/291"},"issue":{"href":"https://api.github.com/repos/twitter/finagle/issues/291"},"comments":{"href":"https://api.github.com/repos/twitter/finagle/issues/291/comments"},"review_comments":{"href":"https://api.github.com/repos/twitter/finagle/pulls/291/comments"},"review_comment":{"href":"https://api.github.com/repos/twitter/finagle/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/twitter/finagle/pulls/291/commits"},"statuses":{"href":"https://api.github.com/repos/twitter/finagle/statuses/255983d5fbbc95880d77c60340ece7d0521eb9aa"}}}}