GitHub PullRequestReviewCommentEvent at 2014-08-18 20:45:30
Repository: pushgo
Actor: bbangert
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/mozilla-services/pushgo/pulls/comments/16380517","id":16380517,"diff_hunk":"@@ -11,134 +11,256 @@ import (\n \t\"net/http\"\n )\n \n-type PropPing struct {\n-\tconnect JsMap\n-\tlogger  *SimpleLogger\n-\tstore   *Storage\n-\tmetrics *Metrics\n+type IPropPing interface {","path":"src/mozilla.org/simplepush/proprietary_ping.go","position":9,"original_position":9,"commit_id":"f4825465bb2eeb18dae0a1c0da9efbcabfe20966","original_commit_id":"f4825465bb2eeb18dae0a1c0da9efbcabfe20966","user":{"login":"bbangert","id":100193,"avatar_url":"https://avatars.githubusercontent.com/u/100193?v=2","gravatar_id":"1e59eddcbc19e7d424686e0644db65de","url":"https://api.github.com/users/bbangert","html_url":"https://github.com/bbangert","followers_url":"https://api.github.com/users/bbangert/followers","following_url":"https://api.github.com/users/bbangert/following{/other_user}","gists_url":"https://api.github.com/users/bbangert/gists{/gist_id}","starred_url":"https://api.github.com/users/bbangert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbangert/subscriptions","organizations_url":"https://api.github.com/users/bbangert/orgs","repos_url":"https://api.github.com/users/bbangert/repos","events_url":"https://api.github.com/users/bbangert/events{/privacy}","received_events_url":"https://api.github.com/users/bbangert/received_events","type":"User","site_admin":false},"body":"Just  change it to PropPing?","created_at":"2014-08-18T20:45:30Z","updated_at":"2014-08-18T20:45:30Z","html_url":"https://github.com/mozilla-services/pushgo/pull/43#discussion_r16380517","pull_request_url":"https://api.github.com/repos/mozilla-services/pushgo/pulls/43","_links":{"self":{"href":"https://api.github.com/repos/mozilla-services/pushgo/pulls/comments/16380517"},"html":{"href":"https://github.com/mozilla-services/pushgo/pull/43#discussion_r16380517"},"pull_request":{"href":"https://api.github.com/repos/mozilla-services/pushgo/pulls/43"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla-services/pushgo/pulls/43","id":19875121,"html_url":"https://github.com/mozilla-services/pushgo/pull/43","diff_url":"https://github.com/mozilla-services/pushgo/pull/43.diff","patch_url":"https://github.com/mozilla-services/pushgo/pull/43.patch","issue_url":"https://api.github.com/repos/mozilla-services/pushgo/issues/43","number":43,"state":"open","locked":false,"title":"Issue38 - break proprietary ping into proper component","user":{"login":"jrconlin","id":35755,"avatar_url":"https://avatars.githubusercontent.com/u/35755?v=2","gravatar_id":"b0ad88743c34ae5c1a3ac93aff088102","url":"https://api.github.com/users/jrconlin","html_url":"https://github.com/jrconlin","followers_url":"https://api.github.com/users/jrconlin/followers","following_url":"https://api.github.com/users/jrconlin/following{/other_user}","gists_url":"https://api.github.com/users/jrconlin/gists{/gist_id}","starred_url":"https://api.github.com/users/jrconlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrconlin/subscriptions","organizations_url":"https://api.github.com/users/jrconlin/orgs","repos_url":"https://api.github.com/users/jrconlin/repos","events_url":"https://api.github.com/users/jrconlin/events{/privacy}","received_events_url":"https://api.github.com/users/jrconlin/received_events","type":"User","site_admin":false},"body":"* removed gcm cruft from app\r\n* added \"default\" for LoadExtensibleSection to allow for less app preconfig\r\n\r\n@bbangert I think I grok what you've done. r?","created_at":"2014-08-16T01:10:32Z","updated_at":"2014-08-18T20:45:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fbc1ce617674051872115a68549ccf5c8e235e0b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-services/pushgo/pulls/43/commits","review_comments_url":"https://api.github.com/repos/mozilla-services/pushgo/pulls/43/comments","review_comment_url":"https://api.github.com/repos/mozilla-services/pushgo/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mozilla-services/pushgo/issues/43/comments","statuses_url":"https://api.github.com/repos/mozilla-services/pushgo/statuses/f4825465bb2eeb18dae0a1c0da9efbcabfe20966","head":{"label":"jrconlin:issue38","ref":"issue38","sha":"f4825465bb2eeb18dae0a1c0da9efbcabfe20966","user":{"login":"jrconlin","id":35755,"avatar_url":"https://avatars.githubusercontent.com/u/35755?v=2","gravatar_id":"b0ad88743c34ae5c1a3ac93aff088102","url":"https://api.github.com/users/jrconlin","html_url":"https://github.com/jrconlin","followers_url":"https://api.github.com/users/jrconlin/followers","following_url":"https://api.github.com/users/jrconlin/following{/other_user}","gists_url":"https://api.github.com/users/jrconlin/gists{/gist_id}","starred_url":"https://api.github.com/users/jrconlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrconlin/subscriptions","organizations_url":"https://api.github.com/users/jrconlin/orgs","repos_url":"https://api.github.com/users/jrconlin/repos","events_url":"https://api.github.com/users/jrconlin/events{/privacy}","received_events_url":"https://api.github.com/users/jrconlin/received_events","type":"User","site_admin":false},"repo":{"id":9796726,"name":"pushgo","full_name":"jrconlin/pushgo","owner":{"login":"jrconlin","id":35755,"avatar_url":"https://avatars.githubusercontent.com/u/35755?v=2","gravatar_id":"b0ad88743c34ae5c1a3ac93aff088102","url":"https://api.github.com/users/jrconlin","html_url":"https://github.com/jrconlin","followers_url":"https://api.github.com/users/jrconlin/followers","following_url":"https://api.github.com/users/jrconlin/following{/other_user}","gists_url":"https://api.github.com/users/jrconlin/gists{/gist_id}","starred_url":"https://api.github.com/users/jrconlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrconlin/subscriptions","organizations_url":"https://api.github.com/users/jrconlin/orgs","repos_url":"https://api.github.com/users/jrconlin/repos","events_url":"https://api.github.com/users/jrconlin/events{/privacy}","received_events_url":"https://api.github.com/users/jrconlin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jrconlin/pushgo","description":"Go based SimplePush server","fork":false,"url":"https://api.github.com/repos/jrconlin/pushgo","forks_url":"https://api.github.com/repos/jrconlin/pushgo/forks","keys_url":"https://api.github.com/repos/jrconlin/pushgo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jrconlin/pushgo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jrconlin/pushgo/teams","hooks_url":"https://api.github.com/repos/jrconlin/pushgo/hooks","issue_events_url":"https://api.github.com/repos/jrconlin/pushgo/issues/events{/number}","events_url":"https://api.github.com/repos/jrconlin/pushgo/events","assignees_url":"https://api.github.com/repos/jrconlin/pushgo/assignees{/user}","branches_url":"https://api.github.com/repos/jrconlin/pushgo/branches{/branch}","tags_url":"https://api.github.com/repos/jrconlin/pushgo/tags","blobs_url":"https://api.github.com/repos/jrconlin/pushgo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jrconlin/pushgo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jrconlin/pushgo/git/refs{/sha}","trees_url":"https://api.github.com/repos/jrconlin/pushgo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jrconlin/pushgo/statuses/{sha}","languages_url":"https://api.github.com/repos/jrconlin/pushgo/languages","stargazers_url":"https://api.github.com/repos/jrconlin/pushgo/stargazers","contributors_url":"https://api.github.com/repos/jrconlin/pushgo/contributors","subscribers_url":"https://api.github.com/repos/jrconlin/pushgo/subscribers","subscription_url":"https://api.github.com/repos/jrconlin/pushgo/subscription","commits_url":"https://api.github.com/repos/jrconlin/pushgo/commits{/sha}","git_commits_url":"https://api.github.com/repos/jrconlin/pushgo/git/commits{/sha}","comments_url":"https://api.github.com/repos/jrconlin/pushgo/comments{/number}","issue_comment_url":"https://api.github.com/repos/jrconlin/pushgo/issues/comments/{number}","contents_url":"https://api.github.com/repos/jrconlin/pushgo/contents/{+path}","compare_url":"https://api.github.com/repos/jrconlin/pushgo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jrconlin/pushgo/merges","archive_url":"https://api.github.com/repos/jrconlin/pushgo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jrconlin/pushgo/downloads","issues_url":"https://api.github.com/repos/jrconlin/pushgo/issues{/number}","pulls_url":"https://api.github.com/repos/jrconlin/pushgo/pulls{/number}","milestones_url":"https://api.github.com/repos/jrconlin/pushgo/milestones{/number}","notifications_url":"https://api.github.com/repos/jrconlin/pushgo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jrconlin/pushgo/labels{/name}","releases_url":"https://api.github.com/repos/jrconlin/pushgo/releases{/id}","created_at":"2013-05-01T17:59:14Z","updated_at":"2014-07-08T04:42:39Z","pushed_at":"2014-08-18T20:36:18Z","git_url":"git://github.com/jrconlin/pushgo.git","ssh_url":"git@github.com:jrconlin/pushgo.git","clone_url":"https://github.com/jrconlin/pushgo.git","svn_url":"https://github.com/jrconlin/pushgo","homepage":null,"size":2391,"stargazers_count":15,"watchers_count":15,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":15,"mirror_url":null,"open_issues_count":2,"forks":15,"open_issues":2,"watchers":15,"default_branch":"master"}},"base":{"label":"mozilla-services:feature/config_to_toml","ref":"feature/config_to_toml","sha":"7bfde9f21567ba05bb8ea9c5987b34505c7d9371","user":{"login":"mozilla-services","id":1066228,"avatar_url":"https://avatars.githubusercontent.com/u/1066228?v=2","gravatar_id":"a41a81f9188770933a4b54382c29cae4","url":"https://api.github.com/users/mozilla-services","html_url":"https://github.com/mozilla-services","followers_url":"https://api.github.com/users/mozilla-services/followers","following_url":"https://api.github.com/users/mozilla-services/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-services/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-services/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-services/subscriptions","organizations_url":"https://api.github.com/users/mozilla-services/orgs","repos_url":"https://api.github.com/users/mozilla-services/repos","events_url":"https://api.github.com/users/mozilla-services/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-services/received_events","type":"Organization","site_admin":false},"repo":{"id":11289838,"name":"pushgo","full_name":"mozilla-services/pushgo","owner":{"login":"mozilla-services","id":1066228,"avatar_url":"https://avatars.githubusercontent.com/u/1066228?v=2","gravatar_id":"a41a81f9188770933a4b54382c29cae4","url":"https://api.github.com/users/mozilla-services","html_url":"https://github.com/mozilla-services","followers_url":"https://api.github.com/users/mozilla-services/followers","following_url":"https://api.github.com/users/mozilla-services/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-services/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-services/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-services/subscriptions","organizations_url":"https://api.github.com/users/mozilla-services/orgs","repos_url":"https://api.github.com/users/mozilla-services/repos","events_url":"https://api.github.com/users/mozilla-services/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-services/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-services/pushgo","description":"Go based SimplePush server","fork":true,"url":"https://api.github.com/repos/mozilla-services/pushgo","forks_url":"https://api.github.com/repos/mozilla-services/pushgo/forks","keys_url":"https://api.github.com/repos/mozilla-services/pushgo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-services/pushgo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-services/pushgo/teams","hooks_url":"https://api.github.com/repos/mozilla-services/pushgo/hooks","issue_events_url":"https://api.github.com/repos/mozilla-services/pushgo/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-services/pushgo/events","assignees_url":"https://api.github.com/repos/mozilla-services/pushgo/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-services/pushgo/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-services/pushgo/tags","blobs_url":"https://api.github.com/repos/mozilla-services/pushgo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-services/pushgo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-services/pushgo/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-services/pushgo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-services/pushgo/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-services/pushgo/languages","stargazers_url":"https://api.github.com/repos/mozilla-services/pushgo/stargazers","contributors_url":"https://api.github.com/repos/mozilla-services/pushgo/contributors","subscribers_url":"https://api.github.com/repos/mozilla-services/pushgo/subscribers","subscription_url":"https://api.github.com/repos/mozilla-services/pushgo/subscription","commits_url":"https://api.github.com/repos/mozilla-services/pushgo/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-services/pushgo/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-services/pushgo/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-services/pushgo/issues/comments/{number}","contents_url":"https://api.github.com/repos/mozilla-services/pushgo/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-services/pushgo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-services/pushgo/merges","archive_url":"https://api.github.com/repos/mozilla-services/pushgo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-services/pushgo/downloads","issues_url":"https://api.github.com/repos/mozilla-services/pushgo/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-services/pushgo/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-services/pushgo/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-services/pushgo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-services/pushgo/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-services/pushgo/releases{/id}","created_at":"2013-07-09T18:06:52Z","updated_at":"2014-08-14T14:21:44Z","pushed_at":"2014-08-15T23:28:05Z","git_url":"git://github.com/mozilla-services/pushgo.git","ssh_url":"git@github.com:mozilla-services/pushgo.git","clone_url":"https://github.com/mozilla-services/pushgo.git","svn_url":"https://github.com/mozilla-services/pushgo","homepage":null,"size":2127,"stargazers_count":11,"watchers_count":11,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":3,"mirror_url":null,"open_issues_count":13,"forks":3,"open_issues":13,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-services/pushgo/pulls/43"},"html":{"href":"https://github.com/mozilla-services/pushgo/pull/43"},"issue":{"href":"https://api.github.com/repos/mozilla-services/pushgo/issues/43"},"comments":{"href":"https://api.github.com/repos/mozilla-services/pushgo/issues/43/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-services/pushgo/pulls/43/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-services/pushgo/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mozilla-services/pushgo/pulls/43/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-services/pushgo/statuses/f4825465bb2eeb18dae0a1c0da9efbcabfe20966"}}}}