GitHub PullRequestReviewCommentEvent at 2014-06-13 18:36:44
Repository: coreos-vagrant
Actor: sander6
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/shopkeep/coreos-vagrant/pulls/comments/13765453","id":13765453,"diff_hunk":"@@ -0,0 +1,15 @@\n+class ForwardPort\n+\tdef initialize(host, guest, increment=false)\n+\t\t@host = host\n+\t\t@guest = guest\n+\t\t@increment = !!increment\n+\tend\n+\n+\tdef host(index=0)\n+\t\t@increment ? @host + index : @host\n+\tend\n+\n+\tdef guest\n+\t\t@guest\n+\tend\n+end","path":"lib/forward_port.rb","position":15,"original_position":15,"commit_id":"b1ef68f0bc727dee438126a7c9bf4bfbe80be72d","original_commit_id":"b1ef68f0bc727dee438126a7c9bf4bfbe80be72d","user":{"login":"sander6","id":16924,"avatar_url":"https://avatars.githubusercontent.com/u/16924?","gravatar_id":"8aac75ff3890dc1e545a76030e204521","url":"https://api.github.com/users/sander6","html_url":"https://github.com/sander6","followers_url":"https://api.github.com/users/sander6/followers","following_url":"https://api.github.com/users/sander6/following{/other_user}","gists_url":"https://api.github.com/users/sander6/gists{/gist_id}","starred_url":"https://api.github.com/users/sander6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sander6/subscriptions","organizations_url":"https://api.github.com/users/sander6/orgs","repos_url":"https://api.github.com/users/sander6/repos","events_url":"https://api.github.com/users/sander6/events{/privacy}","received_events_url":"https://api.github.com/users/sander6/received_events","type":"User","site_admin":false},"body":"Also, looks like you've still got your editor set in Go mode with the hard tabs.","created_at":"2014-06-13T18:36:44Z","updated_at":"2014-06-13T18:36:44Z","html_url":"https://github.com/shopkeep/coreos-vagrant/pull/1#discussion_r13765453","pull_request_url":"https://api.github.com/repos/shopkeep/coreos-vagrant/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/shopkeep/coreos-vagrant/pulls/comments/13765453"},"html":{"href":"https://github.com/shopkeep/coreos-vagrant/pull/1#discussion_r13765453"},"pull_request":{"href":"https://api.github.com/repos/shopkeep/coreos-vagrant/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/shopkeep/coreos-vagrant/pulls/1","id":17035884,"html_url":"https://github.com/shopkeep/coreos-vagrant/pull/1","diff_url":"https://github.com/shopkeep/coreos-vagrant/pull/1.diff","patch_url":"https://github.com/shopkeep/coreos-vagrant/pull/1.patch","issue_url":"https://api.github.com/repos/shopkeep/coreos-vagrant/issues/1","number":1,"state":"open","title":"Allow for building of multiple Dockerfiles at provision time","user":{"login":"pguelpa","id":566864,"avatar_url":"https://avatars.githubusercontent.com/u/566864?","gravatar_id":"ed39ebee0cfc54d12d2fbca5e230ddcb","url":"https://api.github.com/users/pguelpa","html_url":"https://github.com/pguelpa","followers_url":"https://api.github.com/users/pguelpa/followers","following_url":"https://api.github.com/users/pguelpa/following{/other_user}","gists_url":"https://api.github.com/users/pguelpa/gists{/gist_id}","starred_url":"https://api.github.com/users/pguelpa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pguelpa/subscriptions","organizations_url":"https://api.github.com/users/pguelpa/orgs","repos_url":"https://api.github.com/users/pguelpa/repos","events_url":"https://api.github.com/users/pguelpa/events{/privacy}","received_events_url":"https://api.github.com/users/pguelpa/received_events","type":"User","site_admin":false},"body":"Our current method of a Vagrantfile in each repo doesn't allow us to test our deployment locally. I believe this is a useable solution that will build all the images we want and have them available on the CoreOS box such that we can deploy to it using fleetctl like we normally would in staging / production.\r\n\r\nThe basic idea is to define the projects in the `config.rb` file, each project can have multiple Dockerfiles it needs to build. For Go it's nice because all the source for our projects live in the same base directory so we can set them all up as one project with multiple Dockerfiles.\r\n\r\ne.g.\r\n\r\n```ruby\r\n# config.rb\r\n\r\ngo_projects = Project.new(\"#{ENV['GOPATH']}/src/github.com/shopkeep\", \"/home/core/share/src/github.com/shopkeep\")\r\ngo_projects.build_image('authentication', 'authsrv')\r\ngo_projects.build_image('authentication-migrations', 'authsrv/db')\r\ngo_projects.build_image('core-api', 'platform-api')\r\ngo_projects.build_image('transaction', 'transaction-service')\r\n\r\n$projects = [go_projects]\r\n```\r\n\r\nThis will cause all these Dockerfiles to be built at provision time. We can also do a quick \"re-provision\" if we update the code via:\r\n\r\n`vagrant provision --provision-with \"docker\"`\r\n\r\nThis is actually very fast since Docker does it's own caching and knows if it needs to update an image or not.\r\n\r\nComments extremely welcome","created_at":"2014-06-12T03:21:09Z","updated_at":"2014-06-13T18:36:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"456a6328bd8d2afb06c7a7c4b42436af79279f1d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/shopkeep/coreos-vagrant/pulls/1/commits","review_comments_url":"https://api.github.com/repos/shopkeep/coreos-vagrant/pulls/1/comments","review_comment_url":"https://api.github.com/repos/shopkeep/coreos-vagrant/pulls/comments/{number}","comments_url":"https://api.github.com/repos/shopkeep/coreos-vagrant/issues/1/comments","statuses_url":"https://api.github.com/repos/shopkeep/coreos-vagrant/statuses/b1ef68f0bc727dee438126a7c9bf4bfbe80be72d","head":{"label":"shopkeep:no-ticket-build-project-dockerfiles-on-provision","ref":"no-ticket-build-project-dockerfiles-on-provision","sha":"b1ef68f0bc727dee438126a7c9bf4bfbe80be72d","user":{"login":"shopkeep","id":632257,"avatar_url":"https://avatars.githubusercontent.com/u/632257?","gravatar_id":"6d7272ceeab6ad27f58249d1f2a38af0","url":"https://api.github.com/users/shopkeep","html_url":"https://github.com/shopkeep","followers_url":"https://api.github.com/users/shopkeep/followers","following_url":"https://api.github.com/users/shopkeep/following{/other_user}","gists_url":"https://api.github.com/users/shopkeep/gists{/gist_id}","starred_url":"https://api.github.com/users/shopkeep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shopkeep/subscriptions","organizations_url":"https://api.github.com/users/shopkeep/orgs","repos_url":"https://api.github.com/users/shopkeep/repos","events_url":"https://api.github.com/users/shopkeep/events{/privacy}","received_events_url":"https://api.github.com/users/shopkeep/received_events","type":"Organization","site_admin":false},"repo":{"id":20041447,"name":"coreos-vagrant","full_name":"shopkeep/coreos-vagrant","owner":{"login":"shopkeep","id":632257,"avatar_url":"https://avatars.githubusercontent.com/u/632257?","gravatar_id":"6d7272ceeab6ad27f58249d1f2a38af0","url":"https://api.github.com/users/shopkeep","html_url":"https://github.com/shopkeep","followers_url":"https://api.github.com/users/shopkeep/followers","following_url":"https://api.github.com/users/shopkeep/following{/other_user}","gists_url":"https://api.github.com/users/shopkeep/gists{/gist_id}","starred_url":"https://api.github.com/users/shopkeep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shopkeep/subscriptions","organizations_url":"https://api.github.com/users/shopkeep/orgs","repos_url":"https://api.github.com/users/shopkeep/repos","events_url":"https://api.github.com/users/shopkeep/events{/privacy}","received_events_url":"https://api.github.com/users/shopkeep/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/shopkeep/coreos-vagrant","description":"Minimal Vagrantfile for CoreOS","fork":true,"url":"https://api.github.com/repos/shopkeep/coreos-vagrant","forks_url":"https://api.github.com/repos/shopkeep/coreos-vagrant/forks","keys_url":"https://api.github.com/repos/shopkeep/coreos-vagrant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shopkeep/coreos-vagrant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shopkeep/coreos-vagrant/teams","hooks_url":"https://api.github.com/repos/shopkeep/coreos-vagrant/hooks","issue_events_url":"https://api.github.com/repos/shopkeep/coreos-vagrant/issues/events{/number}","events_url":"https://api.github.com/repos/shopkeep/coreos-vagrant/events","assignees_url":"https://api.github.com/repos/shopkeep/coreos-vagrant/assignees{/user}","branches_url":"https://api.github.com/repos/shopkeep/coreos-vagrant/branches{/branch}","tags_url":"https://api.github.com/repos/shopkeep/coreos-vagrant/tags","blobs_url":"https://api.github.com/repos/shopkeep/coreos-vagrant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shopkeep/coreos-vagrant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shopkeep/coreos-vagrant/git/refs{/sha}","trees_url":"https://api.github.com/repos/shopkeep/coreos-vagrant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shopkeep/coreos-vagrant/statuses/{sha}","languages_url":"https://api.github.com/repos/shopkeep/coreos-vagrant/languages","stargazers_url":"https://api.github.com/repos/shopkeep/coreos-vagrant/stargazers","contributors_url":"https://api.github.com/repos/shopkeep/coreos-vagrant/contributors","subscribers_url":"https://api.github.com/repos/shopkeep/coreos-vagrant/subscribers","subscription_url":"https://api.github.com/repos/shopkeep/coreos-vagrant/subscription","commits_url":"https://api.github.com/repos/shopkeep/coreos-vagrant/commits{/sha}","git_commits_url":"https://api.github.com/repos/shopkeep/coreos-vagrant/git/commits{/sha}","comments_url":"https://api.github.com/repos/shopkeep/coreos-vagrant/comments{/number}","issue_comment_url":"https://api.github.com/repos/shopkeep/coreos-vagrant/issues/comments/{number}","contents_url":"https://api.github.com/repos/shopkeep/coreos-vagrant/contents/{+path}","compare_url":"https://api.github.com/repos/shopkeep/coreos-vagrant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shopkeep/coreos-vagrant/merges","archive_url":"https://api.github.com/repos/shopkeep/coreos-vagrant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shopkeep/coreos-vagrant/downloads","issues_url":"https://api.github.com/repos/shopkeep/coreos-vagrant/issues{/number}","pulls_url":"https://api.github.com/repos/shopkeep/coreos-vagrant/pulls{/number}","milestones_url":"https://api.github.com/repos/shopkeep/coreos-vagrant/milestones{/number}","notifications_url":"https://api.github.com/repos/shopkeep/coreos-vagrant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shopkeep/coreos-vagrant/labels{/name}","releases_url":"https://api.github.com/repos/shopkeep/coreos-vagrant/releases{/id}","created_at":"2014-05-21T23:55:53Z","updated_at":"2014-06-12T03:22:24Z","pushed_at":"2014-06-12T03:22:24Z","git_url":"git://github.com/shopkeep/coreos-vagrant.git","ssh_url":"git@github.com:shopkeep/coreos-vagrant.git","clone_url":"https://github.com/shopkeep/coreos-vagrant.git","svn_url":"https://github.com/shopkeep/coreos-vagrant","homepage":"","size":193,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"shopkeep:master","ref":"master","sha":"dfb8c8b3cabe4f0f30d787f4cfa8f9cc8de5c17a","user":{"login":"shopkeep","id":632257,"avatar_url":"https://avatars.githubusercontent.com/u/632257?","gravatar_id":"6d7272ceeab6ad27f58249d1f2a38af0","url":"https://api.github.com/users/shopkeep","html_url":"https://github.com/shopkeep","followers_url":"https://api.github.com/users/shopkeep/followers","following_url":"https://api.github.com/users/shopkeep/following{/other_user}","gists_url":"https://api.github.com/users/shopkeep/gists{/gist_id}","starred_url":"https://api.github.com/users/shopkeep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shopkeep/subscriptions","organizations_url":"https://api.github.com/users/shopkeep/orgs","repos_url":"https://api.github.com/users/shopkeep/repos","events_url":"https://api.github.com/users/shopkeep/events{/privacy}","received_events_url":"https://api.github.com/users/shopkeep/received_events","type":"Organization","site_admin":false},"repo":{"id":20041447,"name":"coreos-vagrant","full_name":"shopkeep/coreos-vagrant","owner":{"login":"shopkeep","id":632257,"avatar_url":"https://avatars.githubusercontent.com/u/632257?","gravatar_id":"6d7272ceeab6ad27f58249d1f2a38af0","url":"https://api.github.com/users/shopkeep","html_url":"https://github.com/shopkeep","followers_url":"https://api.github.com/users/shopkeep/followers","following_url":"https://api.github.com/users/shopkeep/following{/other_user}","gists_url":"https://api.github.com/users/shopkeep/gists{/gist_id}","starred_url":"https://api.github.com/users/shopkeep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shopkeep/subscriptions","organizations_url":"https://api.github.com/users/shopkeep/orgs","repos_url":"https://api.github.com/users/shopkeep/repos","events_url":"https://api.github.com/users/shopkeep/events{/privacy}","received_events_url":"https://api.github.com/users/shopkeep/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/shopkeep/coreos-vagrant","description":"Minimal Vagrantfile for CoreOS","fork":true,"url":"https://api.github.com/repos/shopkeep/coreos-vagrant","forks_url":"https://api.github.com/repos/shopkeep/coreos-vagrant/forks","keys_url":"https://api.github.com/repos/shopkeep/coreos-vagrant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shopkeep/coreos-vagrant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shopkeep/coreos-vagrant/teams","hooks_url":"https://api.github.com/repos/shopkeep/coreos-vagrant/hooks","issue_events_url":"https://api.github.com/repos/shopkeep/coreos-vagrant/issues/events{/number}","events_url":"https://api.github.com/repos/shopkeep/coreos-vagrant/events","assignees_url":"https://api.github.com/repos/shopkeep/coreos-vagrant/assignees{/user}","branches_url":"https://api.github.com/repos/shopkeep/coreos-vagrant/branches{/branch}","tags_url":"https://api.github.com/repos/shopkeep/coreos-vagrant/tags","blobs_url":"https://api.github.com/repos/shopkeep/coreos-vagrant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shopkeep/coreos-vagrant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shopkeep/coreos-vagrant/git/refs{/sha}","trees_url":"https://api.github.com/repos/shopkeep/coreos-vagrant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shopkeep/coreos-vagrant/statuses/{sha}","languages_url":"https://api.github.com/repos/shopkeep/coreos-vagrant/languages","stargazers_url":"https://api.github.com/repos/shopkeep/coreos-vagrant/stargazers","contributors_url":"https://api.github.com/repos/shopkeep/coreos-vagrant/contributors","subscribers_url":"https://api.github.com/repos/shopkeep/coreos-vagrant/subscribers","subscription_url":"https://api.github.com/repos/shopkeep/coreos-vagrant/subscription","commits_url":"https://api.github.com/repos/shopkeep/coreos-vagrant/commits{/sha}","git_commits_url":"https://api.github.com/repos/shopkeep/coreos-vagrant/git/commits{/sha}","comments_url":"https://api.github.com/repos/shopkeep/coreos-vagrant/comments{/number}","issue_comment_url":"https://api.github.com/repos/shopkeep/coreos-vagrant/issues/comments/{number}","contents_url":"https://api.github.com/repos/shopkeep/coreos-vagrant/contents/{+path}","compare_url":"https://api.github.com/repos/shopkeep/coreos-vagrant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shopkeep/coreos-vagrant/merges","archive_url":"https://api.github.com/repos/shopkeep/coreos-vagrant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shopkeep/coreos-vagrant/downloads","issues_url":"https://api.github.com/repos/shopkeep/coreos-vagrant/issues{/number}","pulls_url":"https://api.github.com/repos/shopkeep/coreos-vagrant/pulls{/number}","milestones_url":"https://api.github.com/repos/shopkeep/coreos-vagrant/milestones{/number}","notifications_url":"https://api.github.com/repos/shopkeep/coreos-vagrant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shopkeep/coreos-vagrant/labels{/name}","releases_url":"https://api.github.com/repos/shopkeep/coreos-vagrant/releases{/id}","created_at":"2014-05-21T23:55:53Z","updated_at":"2014-06-12T03:22:24Z","pushed_at":"2014-06-12T03:22:24Z","git_url":"git://github.com/shopkeep/coreos-vagrant.git","ssh_url":"git@github.com:shopkeep/coreos-vagrant.git","clone_url":"https://github.com/shopkeep/coreos-vagrant.git","svn_url":"https://github.com/shopkeep/coreos-vagrant","homepage":"","size":193,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/shopkeep/coreos-vagrant/pulls/1"},"html":{"href":"https://github.com/shopkeep/coreos-vagrant/pull/1"},"issue":{"href":"https://api.github.com/repos/shopkeep/coreos-vagrant/issues/1"},"comments":{"href":"https://api.github.com/repos/shopkeep/coreos-vagrant/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/shopkeep/coreos-vagrant/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/shopkeep/coreos-vagrant/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/shopkeep/coreos-vagrant/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/shopkeep/coreos-vagrant/statuses/b1ef68f0bc727dee438126a7c9bf4bfbe80be72d"}}}}