GitHub PushEvent at 2014-10-01 21:27:55
Repository: pants
Actor: lahosken
Payload: {"shas":[["da26f89b4398a6719764d5bd3325e9b78ace83de","040cff05bd320eb0560246813fe142b421636f09@gmail.com","Allow a task type know its own options scope.\n\nE.g., JavaCompile should know that its options are under compile.java.\n\nAlso fix some stale comments from the goal->task terminology change.\n\nTesting Done:\nRan all the tests. Tested that this works when registering options in the new style (will be sent for review in a future change).\n\nReviewed at https://rbcommons.com/s/twitter/r/1095/","Benjy Weinberger",false],["e03352dbaf1726232b58e6a47db3d5085ed837f8","040cff05bd320eb0560246813fe142b421636f09@gmail.com","Hook new-style registration up to the goal runner.\n\nProvides appropriate special-casing for GroupTask.\n\nNote: relies on https://rbcommons.com/s/twitter/r/1095/.\n\nTesting Done:\nRan all tests. Manually tested new-style registration on top of this.\n\nReviewed at https://rbcommons.com/s/twitter/r/1096/","Benjy Weinberger",false],["747708b180e8ae181118f264c4efbf4765a8b277","2e951f4de4089b8fc584f3a65157d85fa8514ef1@foursquare.com","Add missing BUILD dep.","Benjy",false],["f9c7cecbb22a6630c38807b4a05b018ff3e1d123","040cff05bd320eb0560246813fe142b421636f09@gmail.com","Switch a handful of flags over to the new registration style.\n\nThis includes a superclass-subclass scenario (ConsoleTask-ListGoals)\nand a GroupTask scenario (JvmCompile).\n\nNote that the code that reads and uses the flags needn't change yet.\nThe legacy flags layer places the values in the existing destinations.\n\nNote: Relies on https://rbcommons.com/s/twitter/r/1096/.\n\nOnce this is in I will write up a quick guide to porting flags,\nand then we can set ourselves loose on them!\n\nTesting Done:\nRan all tests. Manually ran the relevant pants goals with various flag settings.\n\nReviewed at https://rbcommons.com/s/twitter/r/1097/","Benjy Weinberger",false],["88e1aea1d206af1cfb8d0c0eea6918910fbcca6b","2e951f4de4089b8fc584f3a65157d85fa8514ef1@foursquare.com","Patch code review comment fixes back in.\n\nThey got lost due to my misuse of ./rbt.","Benjy",false]],"size":5,"ref":"refs/heads/master","head":"88e1aea1d206af1cfb8d0c0eea6918910fbcca6b"}