GitHub PullRequestEvent at 2014-07-15 14:52:32
Repository: refinerycms
Actor: parndt
Payload: {"action":"closed","number":2476,"pull_request":{"url":"https://api.github.com/repos/refinery/refinerycms/pulls/2476","id":10358722,"html_url":"https://github.com/refinery/refinerycms/pull/2476","diff_url":"https://github.com/refinery/refinerycms/pull/2476.diff","patch_url":"https://github.com/refinery/refinerycms/pull/2476.patch","issue_url":"https://api.github.com/repos/refinery/refinerycms/issues/2476","number":2476,"state":"closed","title":"Page Finder","user":{"login":"awagener","id":189705,"avatar_url":"https://avatars.githubusercontent.com/u/189705?","gravatar_id":"0b3b8c8c0c2192ae51919687963a45c9","url":"https://api.github.com/users/awagener","html_url":"https://github.com/awagener","followers_url":"https://api.github.com/users/awagener/followers","following_url":"https://api.github.com/users/awagener/following{/other_user}","gists_url":"https://api.github.com/users/awagener/gists{/gist_id}","starred_url":"https://api.github.com/users/awagener/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awagener/subscriptions","organizations_url":"https://api.github.com/users/awagener/orgs","repos_url":"https://api.github.com/users/awagener/repos","events_url":"https://api.github.com/users/awagener/events{/privacy}","received_events_url":"https://api.github.com/users/awagener/received_events","type":"User","site_admin":false},"body":"Pulling out the logic from class methods in Page into instance methods (eventually at least) in finding classes.\r\n\r\nNaming things is hard.\r\n\r\nThis is mostly a Request for Comment, still some cleaning up to do.  Although all the tests pass for me, and it's pure refactoring (all existing method calls should work) so feel free to merge if desired.\r\n\r\n/cc @parndt","created_at":"2013-11-28T00:49:26Z","updated_at":"2014-07-15T14:52:32Z","closed_at":"2014-07-15T14:52:32Z","merged_at":"2014-07-15T14:52:32Z","merge_commit_sha":"f38dbc11ec7ea494b6a87660526d5308b048eb24","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/refinery/refinerycms/pulls/2476/commits","review_comments_url":"https://api.github.com/repos/refinery/refinerycms/pulls/2476/comments","review_comment_url":"https://api.github.com/repos/refinery/refinerycms/pulls/comments/{number}","comments_url":"https://api.github.com/repos/refinery/refinerycms/issues/2476/comments","statuses_url":"https://api.github.com/repos/refinery/refinerycms/statuses/ee92bc4a54f014d422a8ae20854cb803da6e9a9c","head":{"label":"awagener:page_finder","ref":"page_finder","sha":"ee92bc4a54f014d422a8ae20854cb803da6e9a9c","user":{"login":"awagener","id":189705,"avatar_url":"https://avatars.githubusercontent.com/u/189705?","gravatar_id":"0b3b8c8c0c2192ae51919687963a45c9","url":"https://api.github.com/users/awagener","html_url":"https://github.com/awagener","followers_url":"https://api.github.com/users/awagener/followers","following_url":"https://api.github.com/users/awagener/following{/other_user}","gists_url":"https://api.github.com/users/awagener/gists{/gist_id}","starred_url":"https://api.github.com/users/awagener/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awagener/subscriptions","organizations_url":"https://api.github.com/users/awagener/orgs","repos_url":"https://api.github.com/users/awagener/repos","events_url":"https://api.github.com/users/awagener/events{/privacy}","received_events_url":"https://api.github.com/users/awagener/received_events","type":"User","site_admin":false},"repo":{"id":11198354,"name":"refinerycms","full_name":"awagener/refinerycms","owner":{"login":"awagener","id":189705,"avatar_url":"https://avatars.githubusercontent.com/u/189705?","gravatar_id":"0b3b8c8c0c2192ae51919687963a45c9","url":"https://api.github.com/users/awagener","html_url":"https://github.com/awagener","followers_url":"https://api.github.com/users/awagener/followers","following_url":"https://api.github.com/users/awagener/following{/other_user}","gists_url":"https://api.github.com/users/awagener/gists{/gist_id}","starred_url":"https://api.github.com/users/awagener/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awagener/subscriptions","organizations_url":"https://api.github.com/users/awagener/orgs","repos_url":"https://api.github.com/users/awagener/repos","events_url":"https://api.github.com/users/awagener/events{/privacy}","received_events_url":"https://api.github.com/users/awagener/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/awagener/refinerycms","description":"An extendable Ruby on Rails CMS that supports Rails 3.2","fork":true,"url":"https://api.github.com/repos/awagener/refinerycms","forks_url":"https://api.github.com/repos/awagener/refinerycms/forks","keys_url":"https://api.github.com/repos/awagener/refinerycms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/awagener/refinerycms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/awagener/refinerycms/teams","hooks_url":"https://api.github.com/repos/awagener/refinerycms/hooks","issue_events_url":"https://api.github.com/repos/awagener/refinerycms/issues/events{/number}","events_url":"https://api.github.com/repos/awagener/refinerycms/events","assignees_url":"https://api.github.com/repos/awagener/refinerycms/assignees{/user}","branches_url":"https://api.github.com/repos/awagener/refinerycms/branches{/branch}","tags_url":"https://api.github.com/repos/awagener/refinerycms/tags","blobs_url":"https://api.github.com/repos/awagener/refinerycms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/awagener/refinerycms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/awagener/refinerycms/git/refs{/sha}","trees_url":"https://api.github.com/repos/awagener/refinerycms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/awagener/refinerycms/statuses/{sha}","languages_url":"https://api.github.com/repos/awagener/refinerycms/languages","stargazers_url":"https://api.github.com/repos/awagener/refinerycms/stargazers","contributors_url":"https://api.github.com/repos/awagener/refinerycms/contributors","subscribers_url":"https://api.github.com/repos/awagener/refinerycms/subscribers","subscription_url":"https://api.github.com/repos/awagener/refinerycms/subscription","commits_url":"https://api.github.com/repos/awagener/refinerycms/commits{/sha}","git_commits_url":"https://api.github.com/repos/awagener/refinerycms/git/commits{/sha}","comments_url":"https://api.github.com/repos/awagener/refinerycms/comments{/number}","issue_comment_url":"https://api.github.com/repos/awagener/refinerycms/issues/comments/{number}","contents_url":"https://api.github.com/repos/awagener/refinerycms/contents/{+path}","compare_url":"https://api.github.com/repos/awagener/refinerycms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/awagener/refinerycms/merges","archive_url":"https://api.github.com/repos/awagener/refinerycms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/awagener/refinerycms/downloads","issues_url":"https://api.github.com/repos/awagener/refinerycms/issues{/number}","pulls_url":"https://api.github.com/repos/awagener/refinerycms/pulls{/number}","milestones_url":"https://api.github.com/repos/awagener/refinerycms/milestones{/number}","notifications_url":"https://api.github.com/repos/awagener/refinerycms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/awagener/refinerycms/labels{/name}","releases_url":"https://api.github.com/repos/awagener/refinerycms/releases{/id}","created_at":"2013-07-05T11:44:18Z","updated_at":"2014-05-13T15:55:09Z","pushed_at":"2014-05-11T11:20:44Z","git_url":"git://github.com/awagener/refinerycms.git","ssh_url":"git@github.com:awagener/refinerycms.git","clone_url":"https://github.com/awagener/refinerycms.git","svn_url":"https://github.com/awagener/refinerycms","homepage":"http://refinerycms.com/guides/","size":25015,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":false,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"refinery:master","ref":"master","sha":"f0f43e973e5c9735a262156bb08e438c3ba53398","user":{"login":"refinery","id":339098,"avatar_url":"https://avatars.githubusercontent.com/u/339098?","gravatar_id":"fa8eb6800ed040d905e1493a154f3eef","url":"https://api.github.com/users/refinery","html_url":"https://github.com/refinery","followers_url":"https://api.github.com/users/refinery/followers","following_url":"https://api.github.com/users/refinery/following{/other_user}","gists_url":"https://api.github.com/users/refinery/gists{/gist_id}","starred_url":"https://api.github.com/users/refinery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/refinery/subscriptions","organizations_url":"https://api.github.com/users/refinery/orgs","repos_url":"https://api.github.com/users/refinery/repos","events_url":"https://api.github.com/users/refinery/events{/privacy}","received_events_url":"https://api.github.com/users/refinery/received_events","type":"Organization","site_admin":false},"repo":{"id":212862,"name":"refinerycms","full_name":"refinery/refinerycms","owner":{"login":"refinery","id":339098,"avatar_url":"https://avatars.githubusercontent.com/u/339098?","gravatar_id":"fa8eb6800ed040d905e1493a154f3eef","url":"https://api.github.com/users/refinery","html_url":"https://github.com/refinery","followers_url":"https://api.github.com/users/refinery/followers","following_url":"https://api.github.com/users/refinery/following{/other_user}","gists_url":"https://api.github.com/users/refinery/gists{/gist_id}","starred_url":"https://api.github.com/users/refinery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/refinery/subscriptions","organizations_url":"https://api.github.com/users/refinery/orgs","repos_url":"https://api.github.com/users/refinery/repos","events_url":"https://api.github.com/users/refinery/events{/privacy}","received_events_url":"https://api.github.com/users/refinery/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/refinery/refinerycms","description":"An extendable Ruby on Rails CMS that supports Rails 3.2 and 4.0","fork":false,"url":"https://api.github.com/repos/refinery/refinerycms","forks_url":"https://api.github.com/repos/refinery/refinerycms/forks","keys_url":"https://api.github.com/repos/refinery/refinerycms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/refinery/refinerycms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/refinery/refinerycms/teams","hooks_url":"https://api.github.com/repos/refinery/refinerycms/hooks","issue_events_url":"https://api.github.com/repos/refinery/refinerycms/issues/events{/number}","events_url":"https://api.github.com/repos/refinery/refinerycms/events","assignees_url":"https://api.github.com/repos/refinery/refinerycms/assignees{/user}","branches_url":"https://api.github.com/repos/refinery/refinerycms/branches{/branch}","tags_url":"https://api.github.com/repos/refinery/refinerycms/tags","blobs_url":"https://api.github.com/repos/refinery/refinerycms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/refinery/refinerycms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/refinery/refinerycms/git/refs{/sha}","trees_url":"https://api.github.com/repos/refinery/refinerycms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/refinery/refinerycms/statuses/{sha}","languages_url":"https://api.github.com/repos/refinery/refinerycms/languages","stargazers_url":"https://api.github.com/repos/refinery/refinerycms/stargazers","contributors_url":"https://api.github.com/repos/refinery/refinerycms/contributors","subscribers_url":"https://api.github.com/repos/refinery/refinerycms/subscribers","subscription_url":"https://api.github.com/repos/refinery/refinerycms/subscription","commits_url":"https://api.github.com/repos/refinery/refinerycms/commits{/sha}","git_commits_url":"https://api.github.com/repos/refinery/refinerycms/git/commits{/sha}","comments_url":"https://api.github.com/repos/refinery/refinerycms/comments{/number}","issue_comment_url":"https://api.github.com/repos/refinery/refinerycms/issues/comments/{number}","contents_url":"https://api.github.com/repos/refinery/refinerycms/contents/{+path}","compare_url":"https://api.github.com/repos/refinery/refinerycms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/refinery/refinerycms/merges","archive_url":"https://api.github.com/repos/refinery/refinerycms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/refinery/refinerycms/downloads","issues_url":"https://api.github.com/repos/refinery/refinerycms/issues{/number}","pulls_url":"https://api.github.com/repos/refinery/refinerycms/pulls{/number}","milestones_url":"https://api.github.com/repos/refinery/refinerycms/milestones{/number}","notifications_url":"https://api.github.com/repos/refinery/refinerycms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/refinery/refinerycms/labels{/name}","releases_url":"https://api.github.com/repos/refinery/refinerycms/releases{/id}","created_at":"2009-05-28T20:13:21Z","updated_at":"2014-07-15T06:37:10Z","pushed_at":"2014-07-15T14:52:31Z","git_url":"git://github.com/refinery/refinerycms.git","ssh_url":"git@github.com:refinery/refinerycms.git","clone_url":"https://github.com/refinery/refinerycms.git","svn_url":"https://github.com/refinery/refinerycms","homepage":"http://refinerycms.com/guides/","size":47847,"stargazers_count":2901,"watchers_count":2901,"language":"Ruby","has_issues":true,"has_downloads":false,"has_wiki":true,"forks_count":1121,"mirror_url":null,"open_issues_count":25,"forks":1121,"open_issues":25,"watchers":2901,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/refinery/refinerycms/pulls/2476"},"html":{"href":"https://github.com/refinery/refinerycms/pull/2476"},"issue":{"href":"https://api.github.com/repos/refinery/refinerycms/issues/2476"},"comments":{"href":"https://api.github.com/repos/refinery/refinerycms/issues/2476/comments"},"review_comments":{"href":"https://api.github.com/repos/refinery/refinerycms/pulls/2476/comments"},"review_comment":{"href":"https://api.github.com/repos/refinery/refinerycms/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/refinery/refinerycms/pulls/2476/commits"},"statuses":{"href":"https://api.github.com/repos/refinery/refinerycms/statuses/ee92bc4a54f014d422a8ae20854cb803da6e9a9c"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"parndt","id":10128,"avatar_url":"https://avatars.githubusercontent.com/u/10128?","gravatar_id":"fe9ccfa856aa05ff2d534fcf87cc74f5","url":"https://api.github.com/users/parndt","html_url":"https://github.com/parndt","followers_url":"https://api.github.com/users/parndt/followers","following_url":"https://api.github.com/users/parndt/following{/other_user}","gists_url":"https://api.github.com/users/parndt/gists{/gist_id}","starred_url":"https://api.github.com/users/parndt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parndt/subscriptions","organizations_url":"https://api.github.com/users/parndt/orgs","repos_url":"https://api.github.com/users/parndt/repos","events_url":"https://api.github.com/users/parndt/events{/privacy}","received_events_url":"https://api.github.com/users/parndt/received_events","type":"User","site_admin":false},"comments":17,"review_comments":4,"commits":16,"additions":0,"deletions":0,"changed_files":0}}