GitHub PullRequestEvent at 2014-07-25 02:08:35
Repository: Mediator.js
Actor: kanuck
Payload: {"action":"opened","number":28,"pull_request":{"url":"https://api.github.com/repos/ajacksified/Mediator.js/pulls/28","id":18875032,"html_url":"https://github.com/ajacksified/Mediator.js/pull/28","diff_url":"https://github.com/ajacksified/Mediator.js/pull/28.diff","patch_url":"https://github.com/ajacksified/Mediator.js/pull/28.patch","issue_url":"https://api.github.com/repos/ajacksified/Mediator.js/issues/28","number":28,"state":"open","title":"Fix bug with removing subscribers w/ predicates","user":{"login":"kanuck","id":5522115,"avatar_url":"https://avatars.githubusercontent.com/u/5522115?","gravatar_id":"23602579e61dfdb47a4f64a332d337a2","url":"https://api.github.com/users/kanuck","html_url":"https://github.com/kanuck","followers_url":"https://api.github.com/users/kanuck/followers","following_url":"https://api.github.com/users/kanuck/following{/other_user}","gists_url":"https://api.github.com/users/kanuck/gists{/gist_id}","starred_url":"https://api.github.com/users/kanuck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kanuck/subscriptions","organizations_url":"https://api.github.com/users/kanuck/orgs","repos_url":"https://api.github.com/users/kanuck/repos","events_url":"https://api.github.com/users/kanuck/events{/privacy}","received_events_url":"https://api.github.com/users/kanuck/received_events","type":"User","site_admin":false},"body":"I've added a test case that currently fails with:\r\n\r\n    TypeError: Cannot read property 'options' of undefined\r\n      at Object.Channel.publish (lib/mediator.js:211:24)\r\n\r\nThe issue is that the \"subsAfter/subsBefore\" logic to handle a subscriber removing itself is only happening when the subscriber doesn't have a predicate.\r\n\r\n(seems there might also be another issue if a subscriber removes >1 subscriber, but I haven't tried to build a test case for that, one thing at a time..)\r\n","created_at":"2014-07-25T02:08:35Z","updated_at":"2014-07-25T02:08:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ajacksified/Mediator.js/pulls/28/commits","review_comments_url":"https://api.github.com/repos/ajacksified/Mediator.js/pulls/28/comments","review_comment_url":"https://api.github.com/repos/ajacksified/Mediator.js/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ajacksified/Mediator.js/issues/28/comments","statuses_url":"https://api.github.com/repos/ajacksified/Mediator.js/statuses/96eb9968d5809d6c7a09da546deb250bf07db209","head":{"label":"kanuck:master","ref":"master","sha":"96eb9968d5809d6c7a09da546deb250bf07db209","user":{"login":"kanuck","id":5522115,"avatar_url":"https://avatars.githubusercontent.com/u/5522115?","gravatar_id":"23602579e61dfdb47a4f64a332d337a2","url":"https://api.github.com/users/kanuck","html_url":"https://github.com/kanuck","followers_url":"https://api.github.com/users/kanuck/followers","following_url":"https://api.github.com/users/kanuck/following{/other_user}","gists_url":"https://api.github.com/users/kanuck/gists{/gist_id}","starred_url":"https://api.github.com/users/kanuck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kanuck/subscriptions","organizations_url":"https://api.github.com/users/kanuck/orgs","repos_url":"https://api.github.com/users/kanuck/repos","events_url":"https://api.github.com/users/kanuck/events{/privacy}","received_events_url":"https://api.github.com/users/kanuck/received_events","type":"User","site_admin":false},"repo":{"id":22221202,"name":"Mediator.js","full_name":"kanuck/Mediator.js","owner":{"login":"kanuck","id":5522115,"avatar_url":"https://avatars.githubusercontent.com/u/5522115?","gravatar_id":"23602579e61dfdb47a4f64a332d337a2","url":"https://api.github.com/users/kanuck","html_url":"https://github.com/kanuck","followers_url":"https://api.github.com/users/kanuck/followers","following_url":"https://api.github.com/users/kanuck/following{/other_user}","gists_url":"https://api.github.com/users/kanuck/gists{/gist_id}","starred_url":"https://api.github.com/users/kanuck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kanuck/subscriptions","organizations_url":"https://api.github.com/users/kanuck/orgs","repos_url":"https://api.github.com/users/kanuck/repos","events_url":"https://api.github.com/users/kanuck/events{/privacy}","received_events_url":"https://api.github.com/users/kanuck/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kanuck/Mediator.js","description":"An implementation of the mediator pattern for asynchronous events in Javascript","fork":true,"url":"https://api.github.com/repos/kanuck/Mediator.js","forks_url":"https://api.github.com/repos/kanuck/Mediator.js/forks","keys_url":"https://api.github.com/repos/kanuck/Mediator.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kanuck/Mediator.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kanuck/Mediator.js/teams","hooks_url":"https://api.github.com/repos/kanuck/Mediator.js/hooks","issue_events_url":"https://api.github.com/repos/kanuck/Mediator.js/issues/events{/number}","events_url":"https://api.github.com/repos/kanuck/Mediator.js/events","assignees_url":"https://api.github.com/repos/kanuck/Mediator.js/assignees{/user}","branches_url":"https://api.github.com/repos/kanuck/Mediator.js/branches{/branch}","tags_url":"https://api.github.com/repos/kanuck/Mediator.js/tags","blobs_url":"https://api.github.com/repos/kanuck/Mediator.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kanuck/Mediator.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kanuck/Mediator.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/kanuck/Mediator.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kanuck/Mediator.js/statuses/{sha}","languages_url":"https://api.github.com/repos/kanuck/Mediator.js/languages","stargazers_url":"https://api.github.com/repos/kanuck/Mediator.js/stargazers","contributors_url":"https://api.github.com/repos/kanuck/Mediator.js/contributors","subscribers_url":"https://api.github.com/repos/kanuck/Mediator.js/subscribers","subscription_url":"https://api.github.com/repos/kanuck/Mediator.js/subscription","commits_url":"https://api.github.com/repos/kanuck/Mediator.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/kanuck/Mediator.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/kanuck/Mediator.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/kanuck/Mediator.js/issues/comments/{number}","contents_url":"https://api.github.com/repos/kanuck/Mediator.js/contents/{+path}","compare_url":"https://api.github.com/repos/kanuck/Mediator.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kanuck/Mediator.js/merges","archive_url":"https://api.github.com/repos/kanuck/Mediator.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kanuck/Mediator.js/downloads","issues_url":"https://api.github.com/repos/kanuck/Mediator.js/issues{/number}","pulls_url":"https://api.github.com/repos/kanuck/Mediator.js/pulls{/number}","milestones_url":"https://api.github.com/repos/kanuck/Mediator.js/milestones{/number}","notifications_url":"https://api.github.com/repos/kanuck/Mediator.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kanuck/Mediator.js/labels{/name}","releases_url":"https://api.github.com/repos/kanuck/Mediator.js/releases{/id}","created_at":"2014-07-24T16:46:16Z","updated_at":"2014-07-25T01:49:35Z","pushed_at":"2014-07-25T01:49:36Z","git_url":"git://github.com/kanuck/Mediator.js.git","ssh_url":"git@github.com:kanuck/Mediator.js.git","clone_url":"https://github.com/kanuck/Mediator.js.git","svn_url":"https://github.com/kanuck/Mediator.js","homepage":"thejacklawson.com/Mediator.js/","size":1246,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ajacksified:master","ref":"master","sha":"05c10f529fa5efb38ca081db87002d295e6a7c24","user":{"login":"ajacksified","id":175515,"avatar_url":"https://avatars.githubusercontent.com/u/175515?","gravatar_id":"a29db26f9fdc4d5a689d894507c84edc","url":"https://api.github.com/users/ajacksified","html_url":"https://github.com/ajacksified","followers_url":"https://api.github.com/users/ajacksified/followers","following_url":"https://api.github.com/users/ajacksified/following{/other_user}","gists_url":"https://api.github.com/users/ajacksified/gists{/gist_id}","starred_url":"https://api.github.com/users/ajacksified/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajacksified/subscriptions","organizations_url":"https://api.github.com/users/ajacksified/orgs","repos_url":"https://api.github.com/users/ajacksified/repos","events_url":"https://api.github.com/users/ajacksified/events{/privacy}","received_events_url":"https://api.github.com/users/ajacksified/received_events","type":"User","site_admin":false},"repo":{"id":1846947,"name":"Mediator.js","full_name":"ajacksified/Mediator.js","owner":{"login":"ajacksified","id":175515,"avatar_url":"https://avatars.githubusercontent.com/u/175515?","gravatar_id":"a29db26f9fdc4d5a689d894507c84edc","url":"https://api.github.com/users/ajacksified","html_url":"https://github.com/ajacksified","followers_url":"https://api.github.com/users/ajacksified/followers","following_url":"https://api.github.com/users/ajacksified/following{/other_user}","gists_url":"https://api.github.com/users/ajacksified/gists{/gist_id}","starred_url":"https://api.github.com/users/ajacksified/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajacksified/subscriptions","organizations_url":"https://api.github.com/users/ajacksified/orgs","repos_url":"https://api.github.com/users/ajacksified/repos","events_url":"https://api.github.com/users/ajacksified/events{/privacy}","received_events_url":"https://api.github.com/users/ajacksified/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ajacksified/Mediator.js","description":"An implementation of the mediator pattern for asynchronous events in Javascript","fork":false,"url":"https://api.github.com/repos/ajacksified/Mediator.js","forks_url":"https://api.github.com/repos/ajacksified/Mediator.js/forks","keys_url":"https://api.github.com/repos/ajacksified/Mediator.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ajacksified/Mediator.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ajacksified/Mediator.js/teams","hooks_url":"https://api.github.com/repos/ajacksified/Mediator.js/hooks","issue_events_url":"https://api.github.com/repos/ajacksified/Mediator.js/issues/events{/number}","events_url":"https://api.github.com/repos/ajacksified/Mediator.js/events","assignees_url":"https://api.github.com/repos/ajacksified/Mediator.js/assignees{/user}","branches_url":"https://api.github.com/repos/ajacksified/Mediator.js/branches{/branch}","tags_url":"https://api.github.com/repos/ajacksified/Mediator.js/tags","blobs_url":"https://api.github.com/repos/ajacksified/Mediator.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ajacksified/Mediator.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ajacksified/Mediator.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/ajacksified/Mediator.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ajacksified/Mediator.js/statuses/{sha}","languages_url":"https://api.github.com/repos/ajacksified/Mediator.js/languages","stargazers_url":"https://api.github.com/repos/ajacksified/Mediator.js/stargazers","contributors_url":"https://api.github.com/repos/ajacksified/Mediator.js/contributors","subscribers_url":"https://api.github.com/repos/ajacksified/Mediator.js/subscribers","subscription_url":"https://api.github.com/repos/ajacksified/Mediator.js/subscription","commits_url":"https://api.github.com/repos/ajacksified/Mediator.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/ajacksified/Mediator.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/ajacksified/Mediator.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/ajacksified/Mediator.js/issues/comments/{number}","contents_url":"https://api.github.com/repos/ajacksified/Mediator.js/contents/{+path}","compare_url":"https://api.github.com/repos/ajacksified/Mediator.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ajacksified/Mediator.js/merges","archive_url":"https://api.github.com/repos/ajacksified/Mediator.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ajacksified/Mediator.js/downloads","issues_url":"https://api.github.com/repos/ajacksified/Mediator.js/issues{/number}","pulls_url":"https://api.github.com/repos/ajacksified/Mediator.js/pulls{/number}","milestones_url":"https://api.github.com/repos/ajacksified/Mediator.js/milestones{/number}","notifications_url":"https://api.github.com/repos/ajacksified/Mediator.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ajacksified/Mediator.js/labels{/name}","releases_url":"https://api.github.com/repos/ajacksified/Mediator.js/releases{/id}","created_at":"2011-06-04T14:36:19Z","updated_at":"2014-07-21T09:44:03Z","pushed_at":"2014-04-17T22:58:37Z","git_url":"git://github.com/ajacksified/Mediator.js.git","ssh_url":"git@github.com:ajacksified/Mediator.js.git","clone_url":"https://github.com/ajacksified/Mediator.js.git","svn_url":"https://github.com/ajacksified/Mediator.js","homepage":"thejacklawson.com/Mediator.js/","size":1477,"stargazers_count":259,"watchers_count":259,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":48,"mirror_url":null,"open_issues_count":10,"forks":48,"open_issues":10,"watchers":259,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ajacksified/Mediator.js/pulls/28"},"html":{"href":"https://github.com/ajacksified/Mediator.js/pull/28"},"issue":{"href":"https://api.github.com/repos/ajacksified/Mediator.js/issues/28"},"comments":{"href":"https://api.github.com/repos/ajacksified/Mediator.js/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/ajacksified/Mediator.js/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/ajacksified/Mediator.js/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ajacksified/Mediator.js/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/ajacksified/Mediator.js/statuses/96eb9968d5809d6c7a09da546deb250bf07db209"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":27,"deletions":6,"changed_files":2}}