GitHub PullRequestReviewCommentEvent at 2014-02-22 18:31:53
Repository: phobos
Actor: blackwhale
Payload: {"comment":{"url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/comments/9972351","id":9972351,"diff_hunk":"@@ -356,15 +358,18 @@ template adjoin(F...) if (F.length)\n         }\n         else static if (F.length == 2)\n         {\n+            import std.typecons : Tuple, tuple;\n             return tuple(F[0](a), F[1](a));\n         }\n         else\n         {\n+            import std.typecons : Tuple, tuple;\n+            import std.conv : emplaceRef;\n             alias Head = typeof(F[0](a));\n             Tuple!(Head, typeof(.adjoin!(F[1..$])(a)).Types) result = void;\n             foreach (i, Unused; result.Types)\n             {\n-                emplace(&result[i], F[i](a));\n+                emplaceRef(result[i], F[i](a));","path":"std/functional.d","position":45,"original_position":45,"commit_id":"b1f798f844becd77722a452ec449d5751f7db4c7","original_commit_id":"b1f798f844becd77722a452ec449d5751f7db4c7","user":{"login":"blackwhale","id":281770,"avatar_url":"https://gravatar.com/avatar/16611904eabb61195a73f8444976979f?d=https%3A%2F%2Fidenticons.github.com%2Fd541c7f4e9b0b3207cfbe90e0c0fca1c.png&r=x","gravatar_id":"16611904eabb61195a73f8444976979f","url":"https://api.github.com/users/blackwhale","html_url":"https://github.com/blackwhale","followers_url":"https://api.github.com/users/blackwhale/followers","following_url":"https://api.github.com/users/blackwhale/following{/other_user}","gists_url":"https://api.github.com/users/blackwhale/gists{/gist_id}","starred_url":"https://api.github.com/users/blackwhale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blackwhale/subscriptions","organizations_url":"https://api.github.com/users/blackwhale/orgs","repos_url":"https://api.github.com/users/blackwhale/repos","events_url":"https://api.github.com/users/blackwhale/events{/privacy}","received_events_url":"https://api.github.com/users/blackwhale/received_events","type":"User","site_admin":false},"body":"Ehm?\r\nIt's like I see a new  shabby Phobos primitive every week. In particular emplaceRef is not documented.","created_at":"2014-02-22T18:31:53Z","updated_at":"2014-02-22T18:31:53Z","html_url":"https://github.com/D-Programming-Language/phobos/pull/1956#discussion_r9972351","pull_request_url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/1956","_links":{"self":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/comments/9972351"},"html":{"href":"https://github.com/D-Programming-Language/phobos/pull/1956#discussion_r9972351"},"pull_request":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/1956"}}}}