GitHub PullRequestReviewCommentEvent at 2014-11-04 01:04:18
Repository: OpenBazaar
Actor: Renelvon
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/OpenBazaar/OpenBazaar/pulls/comments/19779700","id":19779700,"diff_hunk":"@@ -292,43 +292,6 @@ def add_trusted_notary(self, guid, nickname=\"\"):\n             {'market_id': self.transport.market_id}\n         )\n \n-    def _decode_list(self, data):","path":"node/market.py","position":4,"original_position":4,"commit_id":"7dc72880bf9504f002c2a98622f854ae3d2855e6","original_commit_id":"7dc72880bf9504f002c2a98622f854ae3d2855e6","user":{"login":"Renelvon","id":860034,"avatar_url":"https://avatars.githubusercontent.com/u/860034?v=2","gravatar_id":"","url":"https://api.github.com/users/Renelvon","html_url":"https://github.com/Renelvon","followers_url":"https://api.github.com/users/Renelvon/followers","following_url":"https://api.github.com/users/Renelvon/following{/other_user}","gists_url":"https://api.github.com/users/Renelvon/gists{/gist_id}","starred_url":"https://api.github.com/users/Renelvon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Renelvon/subscriptions","organizations_url":"https://api.github.com/users/Renelvon/orgs","repos_url":"https://api.github.com/users/Renelvon/repos","events_url":"https://api.github.com/users/Renelvon/events{/privacy}","received_events_url":"https://api.github.com/users/Renelvon/received_events","type":"User","site_admin":false},"body":"Unused since https://github.com/OpenBazaar/OpenBazaar/commit/75a7901d8e48d4bd403b4fa6bae9b536ac43cf83","created_at":"2014-11-04T01:04:18Z","updated_at":"2014-11-04T01:04:18Z","html_url":"https://github.com/OpenBazaar/OpenBazaar/pull/914#discussion_r19779700","pull_request_url":"https://api.github.com/repos/OpenBazaar/OpenBazaar/pulls/914","_links":{"self":{"href":"https://api.github.com/repos/OpenBazaar/OpenBazaar/pulls/comments/19779700"},"html":{"href":"https://github.com/OpenBazaar/OpenBazaar/pull/914#discussion_r19779700"},"pull_request":{"href":"https://api.github.com/repos/OpenBazaar/OpenBazaar/pulls/914"}}},"pull_request":{"url":"https://api.github.com/repos/OpenBazaar/OpenBazaar/pulls/914","id":23740043,"html_url":"https://github.com/OpenBazaar/OpenBazaar/pull/914","diff_url":"https://github.com/OpenBazaar/OpenBazaar/pull/914.diff","patch_url":"https://github.com/OpenBazaar/OpenBazaar/pull/914.patch","issue_url":"https://api.github.com/repos/OpenBazaar/OpenBazaar/issues/914","number":914,"state":"open","locked":false,"title":"[Do not merge, WIP] Remove dead code","user":{"login":"Renelvon","id":860034,"avatar_url":"https://avatars.githubusercontent.com/u/860034?v=2","gravatar_id":"","url":"https://api.github.com/users/Renelvon","html_url":"https://github.com/Renelvon","followers_url":"https://api.github.com/users/Renelvon/followers","following_url":"https://api.github.com/users/Renelvon/following{/other_user}","gists_url":"https://api.github.com/users/Renelvon/gists{/gist_id}","starred_url":"https://api.github.com/users/Renelvon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Renelvon/subscriptions","organizations_url":"https://api.github.com/users/Renelvon/orgs","repos_url":"https://api.github.com/users/Renelvon/repos","events_url":"https://api.github.com/users/Renelvon/events{/privacy}","received_events_url":"https://api.github.com/users/Renelvon/received_events","type":"User","site_admin":false},"body":"### Motivation\r\nYesterday I discovered [vulture](https://pypi.python.org/pypi/vulture), a static analysis tool that detects unused code. I decided to run it on our codebase; this PR is a conservative interpretation of the output, which contains many false positives.\r\n\r\n### Changelog\r\n* Remove unused code from various modules.\r\n* (TODO) Remove unused variables and attributes.\r\n\r\n### Problem\r\nIt bothers me that some of the removed code (especially in the `dht` and `orders` modules) looks like it should be part of the **core** functionality. There is something amiss here, so I am posting this for thorough review. If critical code is indeed unused, this should be fixed right away.","created_at":"2014-11-03T01:41:16Z","updated_at":"2014-11-04T01:04:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"611939d0ee512834910c58ead82f47c9d7bc3da1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/OpenBazaar/OpenBazaar/pulls/914/commits","review_comments_url":"https://api.github.com/repos/OpenBazaar/OpenBazaar/pulls/914/comments","review_comment_url":"https://api.github.com/repos/OpenBazaar/OpenBazaar/pulls/comments/{number}","comments_url":"https://api.github.com/repos/OpenBazaar/OpenBazaar/issues/914/comments","statuses_url":"https://api.github.com/repos/OpenBazaar/OpenBazaar/statuses/7dc72880bf9504f002c2a98622f854ae3d2855e6","head":{"label":"Renelvon:remove_dead_code","ref":"remove_dead_code","sha":"7dc72880bf9504f002c2a98622f854ae3d2855e6","user":{"login":"Renelvon","id":860034,"avatar_url":"https://avatars.githubusercontent.com/u/860034?v=2","gravatar_id":"","url":"https://api.github.com/users/Renelvon","html_url":"https://github.com/Renelvon","followers_url":"https://api.github.com/users/Renelvon/followers","following_url":"https://api.github.com/users/Renelvon/following{/other_user}","gists_url":"https://api.github.com/users/Renelvon/gists{/gist_id}","starred_url":"https://api.github.com/users/Renelvon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Renelvon/subscriptions","organizations_url":"https://api.github.com/users/Renelvon/orgs","repos_url":"https://api.github.com/users/Renelvon/repos","events_url":"https://api.github.com/users/Renelvon/events{/privacy}","received_events_url":"https://api.github.com/users/Renelvon/received_events","type":"User","site_admin":false},"repo":{"id":23919364,"name":"OpenBazaar","full_name":"Renelvon/OpenBazaar","owner":{"login":"Renelvon","id":860034,"avatar_url":"https://avatars.githubusercontent.com/u/860034?v=2","gravatar_id":"","url":"https://api.github.com/users/Renelvon","html_url":"https://github.com/Renelvon","followers_url":"https://api.github.com/users/Renelvon/followers","following_url":"https://api.github.com/users/Renelvon/following{/other_user}","gists_url":"https://api.github.com/users/Renelvon/gists{/gist_id}","starred_url":"https://api.github.com/users/Renelvon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Renelvon/subscriptions","organizations_url":"https://api.github.com/users/Renelvon/orgs","repos_url":"https://api.github.com/users/Renelvon/repos","events_url":"https://api.github.com/users/Renelvon/events{/privacy}","received_events_url":"https://api.github.com/users/Renelvon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Renelvon/OpenBazaar","description":"A decentralized marketplace","fork":true,"url":"https://api.github.com/repos/Renelvon/OpenBazaar","forks_url":"https://api.github.com/repos/Renelvon/OpenBazaar/forks","keys_url":"https://api.github.com/repos/Renelvon/OpenBazaar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Renelvon/OpenBazaar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Renelvon/OpenBazaar/teams","hooks_url":"https://api.github.com/repos/Renelvon/OpenBazaar/hooks","issue_events_url":"https://api.github.com/repos/Renelvon/OpenBazaar/issues/events{/number}","events_url":"https://api.github.com/repos/Renelvon/OpenBazaar/events","assignees_url":"https://api.github.com/repos/Renelvon/OpenBazaar/assignees{/user}","branches_url":"https://api.github.com/repos/Renelvon/OpenBazaar/branches{/branch}","tags_url":"https://api.github.com/repos/Renelvon/OpenBazaar/tags","blobs_url":"https://api.github.com/repos/Renelvon/OpenBazaar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Renelvon/OpenBazaar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Renelvon/OpenBazaar/git/refs{/sha}","trees_url":"https://api.github.com/repos/Renelvon/OpenBazaar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Renelvon/OpenBazaar/statuses/{sha}","languages_url":"https://api.github.com/repos/Renelvon/OpenBazaar/languages","stargazers_url":"https://api.github.com/repos/Renelvon/OpenBazaar/stargazers","contributors_url":"https://api.github.com/repos/Renelvon/OpenBazaar/contributors","subscribers_url":"https://api.github.com/repos/Renelvon/OpenBazaar/subscribers","subscription_url":"https://api.github.com/repos/Renelvon/OpenBazaar/subscription","commits_url":"https://api.github.com/repos/Renelvon/OpenBazaar/commits{/sha}","git_commits_url":"https://api.github.com/repos/Renelvon/OpenBazaar/git/commits{/sha}","comments_url":"https://api.github.com/repos/Renelvon/OpenBazaar/comments{/number}","issue_comment_url":"https://api.github.com/repos/Renelvon/OpenBazaar/issues/comments/{number}","contents_url":"https://api.github.com/repos/Renelvon/OpenBazaar/contents/{+path}","compare_url":"https://api.github.com/repos/Renelvon/OpenBazaar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Renelvon/OpenBazaar/merges","archive_url":"https://api.github.com/repos/Renelvon/OpenBazaar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Renelvon/OpenBazaar/downloads","issues_url":"https://api.github.com/repos/Renelvon/OpenBazaar/issues{/number}","pulls_url":"https://api.github.com/repos/Renelvon/OpenBazaar/pulls{/number}","milestones_url":"https://api.github.com/repos/Renelvon/OpenBazaar/milestones{/number}","notifications_url":"https://api.github.com/repos/Renelvon/OpenBazaar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Renelvon/OpenBazaar/labels{/name}","releases_url":"https://api.github.com/repos/Renelvon/OpenBazaar/releases{/id}","created_at":"2014-09-11T13:29:10Z","updated_at":"2014-09-11T17:16:28Z","pushed_at":"2014-11-04T01:03:25Z","git_url":"git://github.com/Renelvon/OpenBazaar.git","ssh_url":"git@github.com:Renelvon/OpenBazaar.git","clone_url":"https://github.com/Renelvon/OpenBazaar.git","svn_url":"https://github.com/Renelvon/OpenBazaar","homepage":"http://forum.openbazaar.org","size":18841,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OpenBazaar:develop","ref":"develop","sha":"94dfe2ebe496ea27cbaa03538f275a874af58779","user":{"login":"OpenBazaar","id":7438770,"avatar_url":"https://avatars.githubusercontent.com/u/7438770?v=2","gravatar_id":"","url":"https://api.github.com/users/OpenBazaar","html_url":"https://github.com/OpenBazaar","followers_url":"https://api.github.com/users/OpenBazaar/followers","following_url":"https://api.github.com/users/OpenBazaar/following{/other_user}","gists_url":"https://api.github.com/users/OpenBazaar/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenBazaar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenBazaar/subscriptions","organizations_url":"https://api.github.com/users/OpenBazaar/orgs","repos_url":"https://api.github.com/users/OpenBazaar/repos","events_url":"https://api.github.com/users/OpenBazaar/events{/privacy}","received_events_url":"https://api.github.com/users/OpenBazaar/received_events","type":"Organization","site_admin":false},"repo":{"id":19147609,"name":"OpenBazaar","full_name":"OpenBazaar/OpenBazaar","owner":{"login":"OpenBazaar","id":7438770,"avatar_url":"https://avatars.githubusercontent.com/u/7438770?v=2","gravatar_id":"","url":"https://api.github.com/users/OpenBazaar","html_url":"https://github.com/OpenBazaar","followers_url":"https://api.github.com/users/OpenBazaar/followers","following_url":"https://api.github.com/users/OpenBazaar/following{/other_user}","gists_url":"https://api.github.com/users/OpenBazaar/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenBazaar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenBazaar/subscriptions","organizations_url":"https://api.github.com/users/OpenBazaar/orgs","repos_url":"https://api.github.com/users/OpenBazaar/repos","events_url":"https://api.github.com/users/OpenBazaar/events{/privacy}","received_events_url":"https://api.github.com/users/OpenBazaar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenBazaar/OpenBazaar","description":"A decentralized marketplace","fork":false,"url":"https://api.github.com/repos/OpenBazaar/OpenBazaar","forks_url":"https://api.github.com/repos/OpenBazaar/OpenBazaar/forks","keys_url":"https://api.github.com/repos/OpenBazaar/OpenBazaar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenBazaar/OpenBazaar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenBazaar/OpenBazaar/teams","hooks_url":"https://api.github.com/repos/OpenBazaar/OpenBazaar/hooks","issue_events_url":"https://api.github.com/repos/OpenBazaar/OpenBazaar/issues/events{/number}","events_url":"https://api.github.com/repos/OpenBazaar/OpenBazaar/events","assignees_url":"https://api.github.com/repos/OpenBazaar/OpenBazaar/assignees{/user}","branches_url":"https://api.github.com/repos/OpenBazaar/OpenBazaar/branches{/branch}","tags_url":"https://api.github.com/repos/OpenBazaar/OpenBazaar/tags","blobs_url":"https://api.github.com/repos/OpenBazaar/OpenBazaar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenBazaar/OpenBazaar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenBazaar/OpenBazaar/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenBazaar/OpenBazaar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenBazaar/OpenBazaar/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenBazaar/OpenBazaar/languages","stargazers_url":"https://api.github.com/repos/OpenBazaar/OpenBazaar/stargazers","contributors_url":"https://api.github.com/repos/OpenBazaar/OpenBazaar/contributors","subscribers_url":"https://api.github.com/repos/OpenBazaar/OpenBazaar/subscribers","subscription_url":"https://api.github.com/repos/OpenBazaar/OpenBazaar/subscription","commits_url":"https://api.github.com/repos/OpenBazaar/OpenBazaar/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenBazaar/OpenBazaar/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenBazaar/OpenBazaar/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenBazaar/OpenBazaar/issues/comments/{number}","contents_url":"https://api.github.com/repos/OpenBazaar/OpenBazaar/contents/{+path}","compare_url":"https://api.github.com/repos/OpenBazaar/OpenBazaar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenBazaar/OpenBazaar/merges","archive_url":"https://api.github.com/repos/OpenBazaar/OpenBazaar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenBazaar/OpenBazaar/downloads","issues_url":"https://api.github.com/repos/OpenBazaar/OpenBazaar/issues{/number}","pulls_url":"https://api.github.com/repos/OpenBazaar/OpenBazaar/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenBazaar/OpenBazaar/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenBazaar/OpenBazaar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenBazaar/OpenBazaar/labels{/name}","releases_url":"https://api.github.com/repos/OpenBazaar/OpenBazaar/releases{/id}","created_at":"2014-04-25T13:49:36Z","updated_at":"2014-11-03T19:52:29Z","pushed_at":"2014-11-02T18:24:43Z","git_url":"git://github.com/OpenBazaar/OpenBazaar.git","ssh_url":"git@github.com:OpenBazaar/OpenBazaar.git","clone_url":"https://github.com/OpenBazaar/OpenBazaar.git","svn_url":"https://github.com/OpenBazaar/OpenBazaar","homepage":"http://forum.openbazaar.org","size":39803,"stargazers_count":736,"watchers_count":736,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":214,"mirror_url":null,"open_issues_count":200,"forks":214,"open_issues":200,"watchers":736,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenBazaar/OpenBazaar/pulls/914"},"html":{"href":"https://github.com/OpenBazaar/OpenBazaar/pull/914"},"issue":{"href":"https://api.github.com/repos/OpenBazaar/OpenBazaar/issues/914"},"comments":{"href":"https://api.github.com/repos/OpenBazaar/OpenBazaar/issues/914/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenBazaar/OpenBazaar/pulls/914/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenBazaar/OpenBazaar/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/OpenBazaar/OpenBazaar/pulls/914/commits"},"statuses":{"href":"https://api.github.com/repos/OpenBazaar/OpenBazaar/statuses/7dc72880bf9504f002c2a98622f854ae3d2855e6"}}}}