GitHub PullRequestReviewCommentEvent at 2014-11-27 15:52:55
Repository: jclouds-labs-google
Actor: demobox
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/jclouds/jclouds-labs-google/pulls/comments/21002644","id":21002644,"diff_hunk":"@@ -129,4 +130,21 @@ public void forwardingRules() {\n       }\n       assertEquals(count, 2);\n    }\n+\n+   public void targetInstances() {\n+      Iterator<ListPage<TargetInstance>> pageIterator = api().targetInstances(maxResults(1));\n+      // make sure that in spite of having only one result per page we get at\n+      // least two results\n+      int count = 0;\n+      for (; count < 2 && pageIterator.hasNext();) {\n+         ListPage<TargetInstance> result = pageIterator.next();\n+         if (!result.isEmpty()) {\n+            count++;\n+         }\n+      }\n+      if (count < 2) {\n+         throw new SkipException(\"Not enough target instances\");","path":"google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/AggregatedListApiLiveTest.java","position":25,"original_position":25,"commit_id":"0b37b7b520fb62fe22fb63e2f75f372e91c3a20e","original_commit_id":"0b37b7b520fb62fe22fb63e2f75f372e91c3a20e","user":{"login":"demobox","id":223702,"avatar_url":"https://avatars.githubusercontent.com/u/223702?v=3","gravatar_id":"","url":"https://api.github.com/users/demobox","html_url":"https://github.com/demobox","followers_url":"https://api.github.com/users/demobox/followers","following_url":"https://api.github.com/users/demobox/following{/other_user}","gists_url":"https://api.github.com/users/demobox/gists{/gist_id}","starred_url":"https://api.github.com/users/demobox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/demobox/subscriptions","organizations_url":"https://api.github.com/users/demobox/orgs","repos_url":"https://api.github.com/users/demobox/repos","events_url":"https://api.github.com/users/demobox/events{/privacy}","received_events_url":"https://api.github.com/users/demobox/received_events","type":"User","site_admin":false},"body":"> it just didn't have enough data to say if it works or not.\r\n\r\nOK. Thanks for clarifying!","created_at":"2014-11-27T15:52:55Z","updated_at":"2014-11-27T15:52:55Z","html_url":"https://github.com/jclouds/jclouds-labs-google/pull/100#discussion_r21002644","pull_request_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/pulls/100","_links":{"self":{"href":"https://api.github.com/repos/jclouds/jclouds-labs-google/pulls/comments/21002644"},"html":{"href":"https://github.com/jclouds/jclouds-labs-google/pull/100#discussion_r21002644"},"pull_request":{"href":"https://api.github.com/repos/jclouds/jclouds-labs-google/pulls/100"}}},"pull_request":{"url":"https://api.github.com/repos/jclouds/jclouds-labs-google/pulls/100","id":25034001,"html_url":"https://github.com/jclouds/jclouds-labs-google/pull/100","diff_url":"https://github.com/jclouds/jclouds-labs-google/pull/100.diff","patch_url":"https://github.com/jclouds/jclouds-labs-google/pull/100.patch","issue_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/issues/100","number":100,"state":"closed","locked":false,"title":"Added TargetInstanceApi","user":{"login":"danbroudy","id":8703125,"avatar_url":"https://avatars.githubusercontent.com/u/8703125?v=3","gravatar_id":"","url":"https://api.github.com/users/danbroudy","html_url":"https://github.com/danbroudy","followers_url":"https://api.github.com/users/danbroudy/followers","following_url":"https://api.github.com/users/danbroudy/following{/other_user}","gists_url":"https://api.github.com/users/danbroudy/gists{/gist_id}","starred_url":"https://api.github.com/users/danbroudy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danbroudy/subscriptions","organizations_url":"https://api.github.com/users/danbroudy/orgs","repos_url":"https://api.github.com/users/danbroudy/repos","events_url":"https://api.github.com/users/danbroudy/events{/privacy}","received_events_url":"https://api.github.com/users/danbroudy/received_events","type":"User","site_admin":false},"body":"adds to AggregatedListApi and adds relevant tests. ","created_at":"2014-11-25T19:34:20Z","updated_at":"2014-11-27T15:52:55Z","closed_at":"2014-11-27T01:45:37Z","merged_at":null,"merge_commit_sha":"dd00d553f5ef0db5a857dd2c1932ea00b7e9cd76","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/pulls/100/commits","review_comments_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/pulls/100/comments","review_comment_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/pulls/comments/{number}","comments_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/issues/100/comments","statuses_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/statuses/0b37b7b520fb62fe22fb63e2f75f372e91c3a20e","head":{"label":"GoogleCloudPlatform:targetInstances","ref":"targetInstances","sha":"0b37b7b520fb62fe22fb63e2f75f372e91c3a20e","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":22730419,"name":"jclouds-labs-google","full_name":"GoogleCloudPlatform/jclouds-labs-google","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/jclouds-labs-google","description":"Read-only mirror of ASF Git Repo for jclouds labs-google","fork":true,"url":"https://api.github.com/repos/GoogleCloudPlatform/jclouds-labs-google","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/jclouds-labs-google/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/jclouds-labs-google/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/jclouds-labs-google/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/jclouds-labs-google/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/jclouds-labs-google/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/jclouds-labs-google/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/jclouds-labs-google/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/jclouds-labs-google/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/jclouds-labs-google/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/jclouds-labs-google/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/jclouds-labs-google/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/jclouds-labs-google/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/jclouds-labs-google/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/jclouds-labs-google/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/jclouds-labs-google/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/jclouds-labs-google/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/jclouds-labs-google/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/jclouds-labs-google/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/jclouds-labs-google/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/jclouds-labs-google/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/jclouds-labs-google/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/jclouds-labs-google/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/jclouds-labs-google/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/jclouds-labs-google/issues/comments/{number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/jclouds-labs-google/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/jclouds-labs-google/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/jclouds-labs-google/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/jclouds-labs-google/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/jclouds-labs-google/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/jclouds-labs-google/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/jclouds-labs-google/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/jclouds-labs-google/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/jclouds-labs-google/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/jclouds-labs-google/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/jclouds-labs-google/releases{/id}","created_at":"2014-08-07T17:36:54Z","updated_at":"2014-11-25T19:03:35Z","pushed_at":"2014-11-27T01:23:17Z","git_url":"git://github.com/GoogleCloudPlatform/jclouds-labs-google.git","ssh_url":"git@github.com:GoogleCloudPlatform/jclouds-labs-google.git","clone_url":"https://github.com/GoogleCloudPlatform/jclouds-labs-google.git","svn_url":"https://github.com/GoogleCloudPlatform/jclouds-labs-google","homepage":null,"size":2895,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jclouds:master","ref":"master","sha":"f41d49ceab60ff017b00348e95e0589a5cb5cc62","user":{"login":"jclouds","id":108982,"avatar_url":"https://avatars.githubusercontent.com/u/108982?v=3","gravatar_id":"","url":"https://api.github.com/users/jclouds","html_url":"https://github.com/jclouds","followers_url":"https://api.github.com/users/jclouds/followers","following_url":"https://api.github.com/users/jclouds/following{/other_user}","gists_url":"https://api.github.com/users/jclouds/gists{/gist_id}","starred_url":"https://api.github.com/users/jclouds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jclouds/subscriptions","organizations_url":"https://api.github.com/users/jclouds/orgs","repos_url":"https://api.github.com/users/jclouds/repos","events_url":"https://api.github.com/users/jclouds/events{/privacy}","received_events_url":"https://api.github.com/users/jclouds/received_events","type":"Organization","site_admin":false},"repo":{"id":10040995,"name":"jclouds-labs-google","full_name":"jclouds/jclouds-labs-google","owner":{"login":"jclouds","id":108982,"avatar_url":"https://avatars.githubusercontent.com/u/108982?v=3","gravatar_id":"","url":"https://api.github.com/users/jclouds","html_url":"https://github.com/jclouds","followers_url":"https://api.github.com/users/jclouds/followers","following_url":"https://api.github.com/users/jclouds/following{/other_user}","gists_url":"https://api.github.com/users/jclouds/gists{/gist_id}","starred_url":"https://api.github.com/users/jclouds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jclouds/subscriptions","organizations_url":"https://api.github.com/users/jclouds/orgs","repos_url":"https://api.github.com/users/jclouds/repos","events_url":"https://api.github.com/users/jclouds/events{/privacy}","received_events_url":"https://api.github.com/users/jclouds/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jclouds/jclouds-labs-google","description":"Read-only mirror of ASF Git Repo for jclouds labs-google","fork":false,"url":"https://api.github.com/repos/jclouds/jclouds-labs-google","forks_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/forks","keys_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/teams","hooks_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/hooks","issue_events_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/issues/events{/number}","events_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/events","assignees_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/assignees{/user}","branches_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/branches{/branch}","tags_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/tags","blobs_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/git/refs{/sha}","trees_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/statuses/{sha}","languages_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/languages","stargazers_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/stargazers","contributors_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/contributors","subscribers_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/subscribers","subscription_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/subscription","commits_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/commits{/sha}","git_commits_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/git/commits{/sha}","comments_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/comments{/number}","issue_comment_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/issues/comments/{number}","contents_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/contents/{+path}","compare_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/merges","archive_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/downloads","issues_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/issues{/number}","pulls_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/pulls{/number}","milestones_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/milestones{/number}","notifications_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/labels{/name}","releases_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/releases{/id}","created_at":"2013-05-13T20:48:38Z","updated_at":"2014-11-27T01:48:05Z","pushed_at":"2014-11-27T01:48:05Z","git_url":"git://github.com/jclouds/jclouds-labs-google.git","ssh_url":"git@github.com:jclouds/jclouds-labs-google.git","clone_url":"https://github.com/jclouds/jclouds-labs-google.git","svn_url":"https://github.com/jclouds/jclouds-labs-google","homepage":null,"size":4869,"stargazers_count":12,"watchers_count":12,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":32,"mirror_url":null,"open_issues_count":0,"forks":32,"open_issues":0,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jclouds/jclouds-labs-google/pulls/100"},"html":{"href":"https://github.com/jclouds/jclouds-labs-google/pull/100"},"issue":{"href":"https://api.github.com/repos/jclouds/jclouds-labs-google/issues/100"},"comments":{"href":"https://api.github.com/repos/jclouds/jclouds-labs-google/issues/100/comments"},"review_comments":{"href":"https://api.github.com/repos/jclouds/jclouds-labs-google/pulls/100/comments"},"review_comment":{"href":"https://api.github.com/repos/jclouds/jclouds-labs-google/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/jclouds/jclouds-labs-google/pulls/100/commits"},"statuses":{"href":"https://api.github.com/repos/jclouds/jclouds-labs-google/statuses/0b37b7b520fb62fe22fb63e2f75f372e91c3a20e"}}}}