GitHub PullRequestEvent at 2014-10-15 02:55:45
Repository: opendisclosure
Actor: tdooner
Payload: {"action":"closed","number":329,"pull_request":{"url":"https://api.github.com/repos/openoakland/opendisclosure/pulls/329","id":22611960,"html_url":"https://github.com/openoakland/opendisclosure/pull/329","diff_url":"https://github.com/openoakland/opendisclosure/pull/329.diff","patch_url":"https://github.com/openoakland/opendisclosure/pull/329.patch","issue_url":"https://api.github.com/repos/openoakland/opendisclosure/issues/329","number":329,"state":"closed","locked":false,"title":"Fix #326. Fix #327","user":{"login":"mikeubell","id":6759416,"avatar_url":"https://avatars.githubusercontent.com/u/6759416?v=2","gravatar_id":"","url":"https://api.github.com/users/mikeubell","html_url":"https://github.com/mikeubell","followers_url":"https://api.github.com/users/mikeubell/followers","following_url":"https://api.github.com/users/mikeubell/following{/other_user}","gists_url":"https://api.github.com/users/mikeubell/gists{/gist_id}","starred_url":"https://api.github.com/users/mikeubell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikeubell/subscriptions","organizations_url":"https://api.github.com/users/mikeubell/orgs","repos_url":"https://api.github.com/users/mikeubell/repos","events_url":"https://api.github.com/users/mikeubell/events{/privacy}","received_events_url":"https://api.github.com/users/mikeubell/received_events","type":"User","site_admin":false},"body":"327: The problem with wrong data in the committee view is that if a committee files a contribution with a pending (0) committee_id we will then link that committee with all following contributions to other committees with pending ids.  \r\nWe cannot be sure that trans_id is unique even within recipients.  Look for complete matches instead.  The transaction id will disambiguate if the same contributor gives two contributions on the same day.\r\n\r\n326: I think what was intended was slice(0, half-1) and slice(half-1) not slice(half, -1) but changing them to half balances things better.  e.g. for 6 elements half == 3 so the first column would have 2 elements and the second would have 4 if we use half-1.","created_at":"2014-10-12T04:29:08Z","updated_at":"2014-10-15T02:55:43Z","closed_at":"2014-10-15T02:55:43Z","merged_at":"2014-10-15T02:55:43Z","merge_commit_sha":"fb6526cb25d87c704f91ce3fd372591075f1222e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openoakland/opendisclosure/pulls/329/commits","review_comments_url":"https://api.github.com/repos/openoakland/opendisclosure/pulls/329/comments","review_comment_url":"https://api.github.com/repos/openoakland/opendisclosure/pulls/comments/{number}","comments_url":"https://api.github.com/repos/openoakland/opendisclosure/issues/329/comments","statuses_url":"https://api.github.com/repos/openoakland/opendisclosure/statuses/eaf346785d861839ea475c1ce4934b9f63657858","head":{"label":"mikeubell:master","ref":"master","sha":"eaf346785d861839ea475c1ce4934b9f63657858","user":{"login":"mikeubell","id":6759416,"avatar_url":"https://avatars.githubusercontent.com/u/6759416?v=2","gravatar_id":"","url":"https://api.github.com/users/mikeubell","html_url":"https://github.com/mikeubell","followers_url":"https://api.github.com/users/mikeubell/followers","following_url":"https://api.github.com/users/mikeubell/following{/other_user}","gists_url":"https://api.github.com/users/mikeubell/gists{/gist_id}","starred_url":"https://api.github.com/users/mikeubell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikeubell/subscriptions","organizations_url":"https://api.github.com/users/mikeubell/orgs","repos_url":"https://api.github.com/users/mikeubell/repos","events_url":"https://api.github.com/users/mikeubell/events{/privacy}","received_events_url":"https://api.github.com/users/mikeubell/received_events","type":"User","site_admin":false},"repo":{"id":20076445,"name":"opendisclosure","full_name":"mikeubell/opendisclosure","owner":{"login":"mikeubell","id":6759416,"avatar_url":"https://avatars.githubusercontent.com/u/6759416?v=2","gravatar_id":"","url":"https://api.github.com/users/mikeubell","html_url":"https://github.com/mikeubell","followers_url":"https://api.github.com/users/mikeubell/followers","following_url":"https://api.github.com/users/mikeubell/following{/other_user}","gists_url":"https://api.github.com/users/mikeubell/gists{/gist_id}","starred_url":"https://api.github.com/users/mikeubell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikeubell/subscriptions","organizations_url":"https://api.github.com/users/mikeubell/orgs","repos_url":"https://api.github.com/users/mikeubell/repos","events_url":"https://api.github.com/users/mikeubell/events{/privacy}","received_events_url":"https://api.github.com/users/mikeubell/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mikeubell/opendisclosure","description":"We are creating a campaign finance data tool that clearly shows the flow of money into and out of campaigns. We hope to ensure government integrity and transparency in campaign activities by opening up campaign finance data to the public.","fork":true,"url":"https://api.github.com/repos/mikeubell/opendisclosure","forks_url":"https://api.github.com/repos/mikeubell/opendisclosure/forks","keys_url":"https://api.github.com/repos/mikeubell/opendisclosure/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mikeubell/opendisclosure/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mikeubell/opendisclosure/teams","hooks_url":"https://api.github.com/repos/mikeubell/opendisclosure/hooks","issue_events_url":"https://api.github.com/repos/mikeubell/opendisclosure/issues/events{/number}","events_url":"https://api.github.com/repos/mikeubell/opendisclosure/events","assignees_url":"https://api.github.com/repos/mikeubell/opendisclosure/assignees{/user}","branches_url":"https://api.github.com/repos/mikeubell/opendisclosure/branches{/branch}","tags_url":"https://api.github.com/repos/mikeubell/opendisclosure/tags","blobs_url":"https://api.github.com/repos/mikeubell/opendisclosure/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mikeubell/opendisclosure/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mikeubell/opendisclosure/git/refs{/sha}","trees_url":"https://api.github.com/repos/mikeubell/opendisclosure/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mikeubell/opendisclosure/statuses/{sha}","languages_url":"https://api.github.com/repos/mikeubell/opendisclosure/languages","stargazers_url":"https://api.github.com/repos/mikeubell/opendisclosure/stargazers","contributors_url":"https://api.github.com/repos/mikeubell/opendisclosure/contributors","subscribers_url":"https://api.github.com/repos/mikeubell/opendisclosure/subscribers","subscription_url":"https://api.github.com/repos/mikeubell/opendisclosure/subscription","commits_url":"https://api.github.com/repos/mikeubell/opendisclosure/commits{/sha}","git_commits_url":"https://api.github.com/repos/mikeubell/opendisclosure/git/commits{/sha}","comments_url":"https://api.github.com/repos/mikeubell/opendisclosure/comments{/number}","issue_comment_url":"https://api.github.com/repos/mikeubell/opendisclosure/issues/comments/{number}","contents_url":"https://api.github.com/repos/mikeubell/opendisclosure/contents/{+path}","compare_url":"https://api.github.com/repos/mikeubell/opendisclosure/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mikeubell/opendisclosure/merges","archive_url":"https://api.github.com/repos/mikeubell/opendisclosure/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mikeubell/opendisclosure/downloads","issues_url":"https://api.github.com/repos/mikeubell/opendisclosure/issues{/number}","pulls_url":"https://api.github.com/repos/mikeubell/opendisclosure/pulls{/number}","milestones_url":"https://api.github.com/repos/mikeubell/opendisclosure/milestones{/number}","notifications_url":"https://api.github.com/repos/mikeubell/opendisclosure/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mikeubell/opendisclosure/labels{/name}","releases_url":"https://api.github.com/repos/mikeubell/opendisclosure/releases{/id}","created_at":"2014-05-22T20:47:09Z","updated_at":"2014-09-10T22:50:41Z","pushed_at":"2014-10-15T00:22:41Z","git_url":"git://github.com/mikeubell/opendisclosure.git","ssh_url":"git@github.com:mikeubell/opendisclosure.git","clone_url":"https://github.com/mikeubell/opendisclosure.git","svn_url":"https://github.com/mikeubell/opendisclosure","homepage":"http://opendisclosure.io/","size":8986,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openoakland:master","ref":"master","sha":"e1afd05b3171cd11dc1dbd41c23a650b132d5950","user":{"login":"openoakland","id":2238933,"avatar_url":"https://avatars.githubusercontent.com/u/2238933?v=2","gravatar_id":"","url":"https://api.github.com/users/openoakland","html_url":"https://github.com/openoakland","followers_url":"https://api.github.com/users/openoakland/followers","following_url":"https://api.github.com/users/openoakland/following{/other_user}","gists_url":"https://api.github.com/users/openoakland/gists{/gist_id}","starred_url":"https://api.github.com/users/openoakland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openoakland/subscriptions","organizations_url":"https://api.github.com/users/openoakland/orgs","repos_url":"https://api.github.com/users/openoakland/repos","events_url":"https://api.github.com/users/openoakland/events{/privacy}","received_events_url":"https://api.github.com/users/openoakland/received_events","type":"Organization","site_admin":false},"repo":{"id":12423939,"name":"opendisclosure","full_name":"openoakland/opendisclosure","owner":{"login":"openoakland","id":2238933,"avatar_url":"https://avatars.githubusercontent.com/u/2238933?v=2","gravatar_id":"","url":"https://api.github.com/users/openoakland","html_url":"https://github.com/openoakland","followers_url":"https://api.github.com/users/openoakland/followers","following_url":"https://api.github.com/users/openoakland/following{/other_user}","gists_url":"https://api.github.com/users/openoakland/gists{/gist_id}","starred_url":"https://api.github.com/users/openoakland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openoakland/subscriptions","organizations_url":"https://api.github.com/users/openoakland/orgs","repos_url":"https://api.github.com/users/openoakland/repos","events_url":"https://api.github.com/users/openoakland/events{/privacy}","received_events_url":"https://api.github.com/users/openoakland/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openoakland/opendisclosure","description":"A campaign finance framework that shows the flow of money into Oakland mayoral campaigns. And soon, other campaigns!","fork":false,"url":"https://api.github.com/repos/openoakland/opendisclosure","forks_url":"https://api.github.com/repos/openoakland/opendisclosure/forks","keys_url":"https://api.github.com/repos/openoakland/opendisclosure/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openoakland/opendisclosure/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openoakland/opendisclosure/teams","hooks_url":"https://api.github.com/repos/openoakland/opendisclosure/hooks","issue_events_url":"https://api.github.com/repos/openoakland/opendisclosure/issues/events{/number}","events_url":"https://api.github.com/repos/openoakland/opendisclosure/events","assignees_url":"https://api.github.com/repos/openoakland/opendisclosure/assignees{/user}","branches_url":"https://api.github.com/repos/openoakland/opendisclosure/branches{/branch}","tags_url":"https://api.github.com/repos/openoakland/opendisclosure/tags","blobs_url":"https://api.github.com/repos/openoakland/opendisclosure/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openoakland/opendisclosure/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openoakland/opendisclosure/git/refs{/sha}","trees_url":"https://api.github.com/repos/openoakland/opendisclosure/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openoakland/opendisclosure/statuses/{sha}","languages_url":"https://api.github.com/repos/openoakland/opendisclosure/languages","stargazers_url":"https://api.github.com/repos/openoakland/opendisclosure/stargazers","contributors_url":"https://api.github.com/repos/openoakland/opendisclosure/contributors","subscribers_url":"https://api.github.com/repos/openoakland/opendisclosure/subscribers","subscription_url":"https://api.github.com/repos/openoakland/opendisclosure/subscription","commits_url":"https://api.github.com/repos/openoakland/opendisclosure/commits{/sha}","git_commits_url":"https://api.github.com/repos/openoakland/opendisclosure/git/commits{/sha}","comments_url":"https://api.github.com/repos/openoakland/opendisclosure/comments{/number}","issue_comment_url":"https://api.github.com/repos/openoakland/opendisclosure/issues/comments/{number}","contents_url":"https://api.github.com/repos/openoakland/opendisclosure/contents/{+path}","compare_url":"https://api.github.com/repos/openoakland/opendisclosure/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openoakland/opendisclosure/merges","archive_url":"https://api.github.com/repos/openoakland/opendisclosure/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openoakland/opendisclosure/downloads","issues_url":"https://api.github.com/repos/openoakland/opendisclosure/issues{/number}","pulls_url":"https://api.github.com/repos/openoakland/opendisclosure/pulls{/number}","milestones_url":"https://api.github.com/repos/openoakland/opendisclosure/milestones{/number}","notifications_url":"https://api.github.com/repos/openoakland/opendisclosure/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openoakland/opendisclosure/labels{/name}","releases_url":"https://api.github.com/repos/openoakland/opendisclosure/releases{/id}","created_at":"2013-08-28T03:42:35Z","updated_at":"2014-10-01T04:12:32Z","pushed_at":"2014-10-15T02:55:43Z","git_url":"git://github.com/openoakland/opendisclosure.git","ssh_url":"git@github.com:openoakland/opendisclosure.git","clone_url":"https://github.com/openoakland/opendisclosure.git","svn_url":"https://github.com/openoakland/opendisclosure","homepage":"http://opendisclosure.io/","size":10511,"stargazers_count":32,"watchers_count":32,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":30,"mirror_url":null,"open_issues_count":53,"forks":30,"open_issues":53,"watchers":32,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openoakland/opendisclosure/pulls/329"},"html":{"href":"https://github.com/openoakland/opendisclosure/pull/329"},"issue":{"href":"https://api.github.com/repos/openoakland/opendisclosure/issues/329"},"comments":{"href":"https://api.github.com/repos/openoakland/opendisclosure/issues/329/comments"},"review_comments":{"href":"https://api.github.com/repos/openoakland/opendisclosure/pulls/329/comments"},"review_comment":{"href":"https://api.github.com/repos/openoakland/opendisclosure/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/openoakland/opendisclosure/pulls/329/commits"},"statuses":{"href":"https://api.github.com/repos/openoakland/opendisclosure/statuses/eaf346785d861839ea475c1ce4934b9f63657858"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"tdooner","id":129120,"avatar_url":"https://avatars.githubusercontent.com/u/129120?v=2","gravatar_id":"","url":"https://api.github.com/users/tdooner","html_url":"https://github.com/tdooner","followers_url":"https://api.github.com/users/tdooner/followers","following_url":"https://api.github.com/users/tdooner/following{/other_user}","gists_url":"https://api.github.com/users/tdooner/gists{/gist_id}","starred_url":"https://api.github.com/users/tdooner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tdooner/subscriptions","organizations_url":"https://api.github.com/users/tdooner/orgs","repos_url":"https://api.github.com/users/tdooner/repos","events_url":"https://api.github.com/users/tdooner/events{/privacy}","received_events_url":"https://api.github.com/users/tdooner/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":4,"additions":66,"deletions":27,"changed_files":6}}