GitHub PullRequestReviewCommentEvent at 2014-09-16 15:08:36
Repository: kc
Actor: leoherbie
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/kuali/kc/pulls/comments/17607189","id":17607189,"diff_hunk":"@@ -139,9 +139,9 @@\n     @OneToOne(mappedBy = \"proposalDocument\", cascade = CascadeType.ALL)\n     private DevelopmentProposal developmentProposal;\n \n-    @OneToMany(orphanRemoval = true, cascade = { CascadeType.ALL })\n-    @JoinColumn(name = \"PARENT_DOCUMENT_KEY\", referencedColumnName = \"DOCUMENT_NUMBER\")\n-    private List<BudgetDocumentVersion> budgetDocumentVersions;\n+//    @OneToMany(orphanRemoval = true, cascade = { CascadeType.ALL })","path":"coeus-impl/src/main/java/org/kuali/coeus/propdev/impl/core/ProposalDevelopmentDocument.java","position":23,"original_position":23,"commit_id":"1a240dcb46eed3ba03871d25dfd1b2fffe62b678","original_commit_id":"1a240dcb46eed3ba03871d25dfd1b2fffe62b678","user":{"login":"leoherbie","id":188602,"avatar_url":"https://avatars.githubusercontent.com/u/188602?v=2","gravatar_id":"73607818dbb47aea2b3f9a925084a3a7","url":"https://api.github.com/users/leoherbie","html_url":"https://github.com/leoherbie","followers_url":"https://api.github.com/users/leoherbie/followers","following_url":"https://api.github.com/users/leoherbie/following{/other_user}","gists_url":"https://api.github.com/users/leoherbie/gists{/gist_id}","starred_url":"https://api.github.com/users/leoherbie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leoherbie/subscriptions","organizations_url":"https://api.github.com/users/leoherbie/orgs","repos_url":"https://api.github.com/users/leoherbie/repos","events_url":"https://api.github.com/users/leoherbie/events{/privacy}","received_events_url":"https://api.github.com/users/leoherbie/received_events","type":"User","site_admin":false},"body":"remove this please","created_at":"2014-09-16T15:08:36Z","updated_at":"2014-09-16T15:08:36Z","html_url":"https://github.com/kuali/kc/pull/733#discussion_r17607189","pull_request_url":"https://api.github.com/repos/kuali/kc/pulls/733","_links":{"self":{"href":"https://api.github.com/repos/kuali/kc/pulls/comments/17607189"},"html":{"href":"https://github.com/kuali/kc/pull/733#discussion_r17607189"},"pull_request":{"href":"https://api.github.com/repos/kuali/kc/pulls/733"}}},"pull_request":{"url":"https://api.github.com/repos/kuali/kc/pulls/733","id":21278222,"html_url":"https://github.com/kuali/kc/pull/733","diff_url":"https://github.com/kuali/kc/pull/733.diff","patch_url":"https://github.com/kuali/kc/pull/733.patch","issue_url":"https://api.github.com/repos/kuali/kc/issues/733","number":733,"state":"open","locked":false,"title":"Budget Document Refactor","user":{"login":"blackcathacker","id":3145921,"avatar_url":"https://avatars.githubusercontent.com/u/3145921?v=2","gravatar_id":"49b4427bf232addddf27a4e4e5dae134","url":"https://api.github.com/users/blackcathacker","html_url":"https://github.com/blackcathacker","followers_url":"https://api.github.com/users/blackcathacker/followers","following_url":"https://api.github.com/users/blackcathacker/following{/other_user}","gists_url":"https://api.github.com/users/blackcathacker/gists{/gist_id}","starred_url":"https://api.github.com/users/blackcathacker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blackcathacker/subscriptions","organizations_url":"https://api.github.com/users/blackcathacker/orgs","repos_url":"https://api.github.com/users/blackcathacker/repos","events_url":"https://api.github.com/users/blackcathacker/events{/privacy}","received_events_url":"https://api.github.com/users/blackcathacker/received_events","type":"User","site_admin":false},"body":"Budget Document Refactor. There are still some problems with this work. Specifically BudgetDocument still exists and is required in a few places that still need work. Specifically a handful of values finders and action class. Values finders still need to be fixed and the action class references changed to AwardBudgetDocument. I believe there also some packaging issues with some of the modified budget events and rules that will need to be resolved. Lastly about 23 integration tests need to be fixed...but I wanted this out there so it can start being review so hopefully Award budget regression testing can begin this week.","created_at":"2014-09-16T06:11:29Z","updated_at":"2014-09-16T15:08:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fc8efebd1aba5287e27200d7e2825e29c646580d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/kuali/kc/pulls/733/commits","review_comments_url":"https://api.github.com/repos/kuali/kc/pulls/733/comments","review_comment_url":"https://api.github.com/repos/kuali/kc/pulls/comments/{number}","comments_url":"https://api.github.com/repos/kuali/kc/issues/733/comments","statuses_url":"https://api.github.com/repos/kuali/kc/statuses/1a240dcb46eed3ba03871d25dfd1b2fffe62b678","head":{"label":"blackcathacker:remove_budget_doc_overview","ref":"remove_budget_doc_overview","sha":"1a240dcb46eed3ba03871d25dfd1b2fffe62b678","user":{"login":"blackcathacker","id":3145921,"avatar_url":"https://avatars.githubusercontent.com/u/3145921?v=2","gravatar_id":"49b4427bf232addddf27a4e4e5dae134","url":"https://api.github.com/users/blackcathacker","html_url":"https://github.com/blackcathacker","followers_url":"https://api.github.com/users/blackcathacker/followers","following_url":"https://api.github.com/users/blackcathacker/following{/other_user}","gists_url":"https://api.github.com/users/blackcathacker/gists{/gist_id}","starred_url":"https://api.github.com/users/blackcathacker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blackcathacker/subscriptions","organizations_url":"https://api.github.com/users/blackcathacker/orgs","repos_url":"https://api.github.com/users/blackcathacker/repos","events_url":"https://api.github.com/users/blackcathacker/events{/privacy}","received_events_url":"https://api.github.com/users/blackcathacker/received_events","type":"User","site_admin":false},"repo":{"id":16320118,"name":"kc","full_name":"blackcathacker/kc","owner":{"login":"blackcathacker","id":3145921,"avatar_url":"https://avatars.githubusercontent.com/u/3145921?v=2","gravatar_id":"49b4427bf232addddf27a4e4e5dae134","url":"https://api.github.com/users/blackcathacker","html_url":"https://github.com/blackcathacker","followers_url":"https://api.github.com/users/blackcathacker/followers","following_url":"https://api.github.com/users/blackcathacker/following{/other_user}","gists_url":"https://api.github.com/users/blackcathacker/gists{/gist_id}","starred_url":"https://api.github.com/users/blackcathacker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blackcathacker/subscriptions","organizations_url":"https://api.github.com/users/blackcathacker/orgs","repos_url":"https://api.github.com/users/blackcathacker/repos","events_url":"https://api.github.com/users/blackcathacker/events{/privacy}","received_events_url":"https://api.github.com/users/blackcathacker/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/blackcathacker/kc","description":"Kuali Coeus","fork":true,"url":"https://api.github.com/repos/blackcathacker/kc","forks_url":"https://api.github.com/repos/blackcathacker/kc/forks","keys_url":"https://api.github.com/repos/blackcathacker/kc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/blackcathacker/kc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/blackcathacker/kc/teams","hooks_url":"https://api.github.com/repos/blackcathacker/kc/hooks","issue_events_url":"https://api.github.com/repos/blackcathacker/kc/issues/events{/number}","events_url":"https://api.github.com/repos/blackcathacker/kc/events","assignees_url":"https://api.github.com/repos/blackcathacker/kc/assignees{/user}","branches_url":"https://api.github.com/repos/blackcathacker/kc/branches{/branch}","tags_url":"https://api.github.com/repos/blackcathacker/kc/tags","blobs_url":"https://api.github.com/repos/blackcathacker/kc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/blackcathacker/kc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/blackcathacker/kc/git/refs{/sha}","trees_url":"https://api.github.com/repos/blackcathacker/kc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/blackcathacker/kc/statuses/{sha}","languages_url":"https://api.github.com/repos/blackcathacker/kc/languages","stargazers_url":"https://api.github.com/repos/blackcathacker/kc/stargazers","contributors_url":"https://api.github.com/repos/blackcathacker/kc/contributors","subscribers_url":"https://api.github.com/repos/blackcathacker/kc/subscribers","subscription_url":"https://api.github.com/repos/blackcathacker/kc/subscription","commits_url":"https://api.github.com/repos/blackcathacker/kc/commits{/sha}","git_commits_url":"https://api.github.com/repos/blackcathacker/kc/git/commits{/sha}","comments_url":"https://api.github.com/repos/blackcathacker/kc/comments{/number}","issue_comment_url":"https://api.github.com/repos/blackcathacker/kc/issues/comments/{number}","contents_url":"https://api.github.com/repos/blackcathacker/kc/contents/{+path}","compare_url":"https://api.github.com/repos/blackcathacker/kc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/blackcathacker/kc/merges","archive_url":"https://api.github.com/repos/blackcathacker/kc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/blackcathacker/kc/downloads","issues_url":"https://api.github.com/repos/blackcathacker/kc/issues{/number}","pulls_url":"https://api.github.com/repos/blackcathacker/kc/pulls{/number}","milestones_url":"https://api.github.com/repos/blackcathacker/kc/milestones{/number}","notifications_url":"https://api.github.com/repos/blackcathacker/kc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/blackcathacker/kc/labels{/name}","releases_url":"https://api.github.com/repos/blackcathacker/kc/releases{/id}","created_at":"2014-01-28T17:50:39Z","updated_at":"2014-06-25T23:41:10Z","pushed_at":"2014-09-16T06:08:29Z","git_url":"git://github.com/blackcathacker/kc.git","ssh_url":"git@github.com:blackcathacker/kc.git","clone_url":"https://github.com/blackcathacker/kc.git","svn_url":"https://github.com/blackcathacker/kc","homepage":"http://www.kuali.org/kc","size":596636,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"kuali:master","ref":"master","sha":"432d43e8772a037ba780c0dc5445c9eebd11759f","user":{"login":"kuali","id":371097,"avatar_url":"https://avatars.githubusercontent.com/u/371097?v=2","gravatar_id":"c2e9cf7cb10aab4497c85f81a4188869","url":"https://api.github.com/users/kuali","html_url":"https://github.com/kuali","followers_url":"https://api.github.com/users/kuali/followers","following_url":"https://api.github.com/users/kuali/following{/other_user}","gists_url":"https://api.github.com/users/kuali/gists{/gist_id}","starred_url":"https://api.github.com/users/kuali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kuali/subscriptions","organizations_url":"https://api.github.com/users/kuali/orgs","repos_url":"https://api.github.com/users/kuali/repos","events_url":"https://api.github.com/users/kuali/events{/privacy}","received_events_url":"https://api.github.com/users/kuali/received_events","type":"Organization","site_admin":false},"repo":{"id":16106733,"name":"kc","full_name":"kuali/kc","owner":{"login":"kuali","id":371097,"avatar_url":"https://avatars.githubusercontent.com/u/371097?v=2","gravatar_id":"c2e9cf7cb10aab4497c85f81a4188869","url":"https://api.github.com/users/kuali","html_url":"https://github.com/kuali","followers_url":"https://api.github.com/users/kuali/followers","following_url":"https://api.github.com/users/kuali/following{/other_user}","gists_url":"https://api.github.com/users/kuali/gists{/gist_id}","starred_url":"https://api.github.com/users/kuali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kuali/subscriptions","organizations_url":"https://api.github.com/users/kuali/orgs","repos_url":"https://api.github.com/users/kuali/repos","events_url":"https://api.github.com/users/kuali/events{/privacy}","received_events_url":"https://api.github.com/users/kuali/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kuali/kc","description":"Kuali Coeus","fork":false,"url":"https://api.github.com/repos/kuali/kc","forks_url":"https://api.github.com/repos/kuali/kc/forks","keys_url":"https://api.github.com/repos/kuali/kc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kuali/kc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kuali/kc/teams","hooks_url":"https://api.github.com/repos/kuali/kc/hooks","issue_events_url":"https://api.github.com/repos/kuali/kc/issues/events{/number}","events_url":"https://api.github.com/repos/kuali/kc/events","assignees_url":"https://api.github.com/repos/kuali/kc/assignees{/user}","branches_url":"https://api.github.com/repos/kuali/kc/branches{/branch}","tags_url":"https://api.github.com/repos/kuali/kc/tags","blobs_url":"https://api.github.com/repos/kuali/kc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kuali/kc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kuali/kc/git/refs{/sha}","trees_url":"https://api.github.com/repos/kuali/kc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kuali/kc/statuses/{sha}","languages_url":"https://api.github.com/repos/kuali/kc/languages","stargazers_url":"https://api.github.com/repos/kuali/kc/stargazers","contributors_url":"https://api.github.com/repos/kuali/kc/contributors","subscribers_url":"https://api.github.com/repos/kuali/kc/subscribers","subscription_url":"https://api.github.com/repos/kuali/kc/subscription","commits_url":"https://api.github.com/repos/kuali/kc/commits{/sha}","git_commits_url":"https://api.github.com/repos/kuali/kc/git/commits{/sha}","comments_url":"https://api.github.com/repos/kuali/kc/comments{/number}","issue_comment_url":"https://api.github.com/repos/kuali/kc/issues/comments/{number}","contents_url":"https://api.github.com/repos/kuali/kc/contents/{+path}","compare_url":"https://api.github.com/repos/kuali/kc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kuali/kc/merges","archive_url":"https://api.github.com/repos/kuali/kc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kuali/kc/downloads","issues_url":"https://api.github.com/repos/kuali/kc/issues{/number}","pulls_url":"https://api.github.com/repos/kuali/kc/pulls{/number}","milestones_url":"https://api.github.com/repos/kuali/kc/milestones{/number}","notifications_url":"https://api.github.com/repos/kuali/kc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kuali/kc/labels{/name}","releases_url":"https://api.github.com/repos/kuali/kc/releases{/id}","created_at":"2014-01-21T15:32:22Z","updated_at":"2014-09-02T13:27:22Z","pushed_at":"2014-09-15T23:05:45Z","git_url":"git://github.com/kuali/kc.git","ssh_url":"git@github.com:kuali/kc.git","clone_url":"https://github.com/kuali/kc.git","svn_url":"https://github.com/kuali/kc","homepage":"http://www.kuali.org/kc","size":694881,"stargazers_count":7,"watchers_count":7,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":35,"mirror_url":null,"open_issues_count":19,"forks":35,"open_issues":19,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kuali/kc/pulls/733"},"html":{"href":"https://github.com/kuali/kc/pull/733"},"issue":{"href":"https://api.github.com/repos/kuali/kc/issues/733"},"comments":{"href":"https://api.github.com/repos/kuali/kc/issues/733/comments"},"review_comments":{"href":"https://api.github.com/repos/kuali/kc/pulls/733/comments"},"review_comment":{"href":"https://api.github.com/repos/kuali/kc/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/kuali/kc/pulls/733/commits"},"statuses":{"href":"https://api.github.com/repos/kuali/kc/statuses/1a240dcb46eed3ba03871d25dfd1b2fffe62b678"}}}}