GitHub PullRequestReviewCommentEvent at 2014-02-27 22:14:10
Repository: dolphin
Actor: delroth
Payload: {"comment":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/10145076","id":10145076,"diff_hunk":"@@ -57,9 +53,9 @@\n \t//if (LoadOAL10Library(NULL, &ALFunction) == TRUE) {\n \t\tif (alcIsExtensionPresent(NULL, \"ALC_ENUMERATION_EXT\"))\n \t\t{\n-\t\t\tdevices = (char *)alcGetString(NULL, ALC_DEVICE_SPECIFIER);\n-\t\t\tdefaultDeviceName = (char *)alcGetString(NULL, ALC_DEFAULT_DEVICE_SPECIFIER);\n-\t\t\tindex = 0;\n+\t\t\tchar *devices = (char *)alcGetString(NULL, ALC_DEVICE_SPECIFIER);","path":"Source/Core/AudioCommon/aldlist.cpp","position":18,"original_position":18,"commit_id":"2b83db80132c1742ef16adc37b80a712f34b5ccb","original_commit_id":"2b83db80132c1742ef16adc37b80a712f34b5ccb","user":{"login":"delroth","id":202798,"avatar_url":"https://avatars.githubusercontent.com/u/202798","gravatar_id":"a7c333ee5d59519be7b757f917a950ba","url":"https://api.github.com/users/delroth","html_url":"https://github.com/delroth","followers_url":"https://api.github.com/users/delroth/followers","following_url":"https://api.github.com/users/delroth/following{/other_user}","gists_url":"https://api.github.com/users/delroth/gists{/gist_id}","starred_url":"https://api.github.com/users/delroth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/delroth/subscriptions","organizations_url":"https://api.github.com/users/delroth/orgs","repos_url":"https://api.github.com/users/delroth/repos","events_url":"https://api.github.com/users/delroth/events{/privacy}","received_events_url":"https://api.github.com/users/delroth/received_events","type":"User","site_admin":false},"body":"Why are we not using const char* for this and the next one?","created_at":"2014-02-27T22:14:10Z","updated_at":"2014-02-27T22:14:10Z","html_url":"https://github.com/dolphin-emu/dolphin/pull/100#discussion_r10145076","pull_request_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/100","_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/10145076"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/100#discussion_r10145076"},"pull_request":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/100"}}}}