GitHub PullRequestReviewCommentEvent at 2014-03-16 00:59:40
Repository: logstash-contrib
Actor: jordansissel
Payload: {"comment":{"url":"https://api.github.com/repos/elasticsearch/logstash-contrib/pulls/comments/10637493","id":10637493,"diff_hunk":"@@ -0,0 +1,299 @@\n+# encoding: utf-8\n+require \"logstash/inputs/base\"\n+require \"logstash/inputs/threadable\"\n+require \"logstash/namespace\"\n+#require \"jruby-jms\"\n+\n+# Read events from a Jms Broker. Supports both Jms Queues and Topics.\n+#\n+# For more information about Jms, see <http://docs.oracle.com/javaee/6/tutorial/doc/bncdq.html>\n+# For more information about the Ruby Gem used, see <http://github.com/reidmorrison/jruby-jms>\n+# Here is a config example :\n+#\t jms {\n+#\t\t\tinclude_header => false\n+#\t\t\tinclude_properties => false\n+#\t\t\tinclude_body => true\n+#\t\t\tuse_jms_timestamp => false\n+#\t\t\tinterval => 10\n+#\t\t\tqueue_name => \"myqueue\"\n+#\t\t\tyaml_file => \"~/jms.yml\"\n+#\t\t\tyaml_section => \"mybroker\"\n+#\t\t}\n+#\n+#\n+class LogStash::Inputs::Jms < LogStash::Inputs::Threadable\n+\tconfig_name \"jms\"\n+\tmilestone 1\n+\n+\tdefault :config, \"plain\"\n+\n+\t# A JMS message has three parts :\n+\t#\t Message Headers (required)\n+\t#\t Message Properties (optional)\n+\t#\t Message Bodies (optional)\n+\t# You can tell the input plugin which parts should be included in the event produced by Logstash\n+\t#\n+\t# Include JMS Message Header Field values in the event\n+\tconfig :include_header, :validate => :boolean, :default => true\n+\t# Include JMS Message Properties Field values in the event\n+\tconfig :include_properties, :validate => :boolean, :default => true\n+\t# Include JMS Message Body in the event\n+\t# Supports TextMessage and MapMessage\n+\t# If the JMS Message is a TextMessage, then the value will be in the \"message\" field of the event\n+\t# If the JMS Message is a MapMessage, then all the key/value pairs will be added in the Hashmap of the event\n+\t# BytesMessage, StreamMessage and ObjectMessage are not supported\n+\tconfig :include_body, :validate => :boolean, :default => true\n+\t# Convert the JMSTimestamp header field to the @timestamp value of the event\n+\t# Don't use it for now, it is buggy\n+\tconfig :use_jms_timestamp, :validate => :boolean, :default => false\n+\n+\t# Choose an implementation of the run block. Value can be either consumer, async or thread\n+\tconfig :runner, :validate => :string, :required => true, :default => \"consumer\"\n+\n+\t# Set the selector to use to get messages off the queue or topic\n+\tconfig :selector, :validate => :string\n+\n+\t# Initial connection timeout in seconds.\n+\tconfig :timeout, :validate => :number, :default => 1000\n+\n+\t# Polling interval.\n+\t# This is the time sleeping between asks to a consumed Queue.\n+\t# This parameter has non influence in the case of a subcribed Topic.\n+\tconfig :interval, :validate => :number, :default => 10\n+\n+\t# Name of the Queue to consume.\n+\t# Mandatory unless :topic_name is supplied\n+\tconfig :queue_name, :validate => :string\n+\t# Name of the Topic to subscribe to.\n+\t# Mandatory unless :queue_name is supplied\n+\tconfig :topic_name, :validate => :string\n+\n+\t# Yaml config file\n+\tconfig :yaml_file, :validate => :string\n+\t# Yaml config file section name\n+\t# For some known examples, see: [Example jms.yml](https://github.com/reidmorrison/jruby-jms/blob/master/examples/jms.yml)\n+\tconfig :yaml_section, :validate => :string\n+\n+\n+\n+\t# TODO(claveau): here is the the problem to deal with ...\n+\t# Each JMS broker comes with its own API, libraries and config parameters.\n+\t# The jruby-jms expects an array of properties where some are normalized, and some are specific.\n+\n+\t# So, for this plugin, can we just expect a Yaml config file,\n+\t# or should we expose all the properties like the following ...\n+\n+\t# An optional array of Jar file names to load for the specified\n+\t# JMS provider. By using this option it is not necessary\n+\t# to put all the JMS Provider specific jar files into the\n+\t# environment variable CLASSPATH prior to starting Logstash\n+\tconfig :require_jars, :validate => :array","path":"lib/logstash/inputs/jms.rb","position":90,"original_position":90,"commit_id":"e01fcaf006b11510f73dd578a33729c9c180c471","original_commit_id":"e01fcaf006b11510f73dd578a33729c9c180c471","user":{"login":"jordansissel","id":131818,"avatar_url":"https://gravatar.com/avatar/75fdd336ae5f818276f1cf79e0468b2d?d=https%3A%2F%2Fidenticons.github.com%2F983c25e4d13d98f06c505afe2a937b4d.png&r=x","gravatar_id":"75fdd336ae5f818276f1cf79e0468b2d","url":"https://api.github.com/users/jordansissel","html_url":"https://github.com/jordansissel","followers_url":"https://api.github.com/users/jordansissel/followers","following_url":"https://api.github.com/users/jordansissel/following{/other_user}","gists_url":"https://api.github.com/users/jordansissel/gists{/gist_id}","starred_url":"https://api.github.com/users/jordansissel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jordansissel/subscriptions","organizations_url":"https://api.github.com/users/jordansissel/orgs","repos_url":"https://api.github.com/users/jordansissel/repos","events_url":"https://api.github.com/users/jordansissel/events{/privacy}","received_events_url":"https://api.github.com/users/jordansissel/received_events","type":"User","site_admin":false},"body":"What do other JMS users do? Would they expect to set CLASSPATH? Should we call it 'classpath' ?","created_at":"2014-03-16T00:59:40Z","updated_at":"2014-03-16T00:59:40Z","html_url":"https://github.com/elasticsearch/logstash-contrib/pull/26#discussion_r10637493","pull_request_url":"https://api.github.com/repos/elasticsearch/logstash-contrib/pulls/26","_links":{"self":{"href":"https://api.github.com/repos/elasticsearch/logstash-contrib/pulls/comments/10637493"},"html":{"href":"https://github.com/elasticsearch/logstash-contrib/pull/26#discussion_r10637493"},"pull_request":{"href":"https://api.github.com/repos/elasticsearch/logstash-contrib/pulls/26"}}}}