GitHub PullRequestReviewCommentEvent at 2014-10-27 14:58:14
Repository: mocha-nock-fixtures
Actor: jakecraige
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/poetic/mocha-nock-fixtures/pulls/comments/19409881","id":19409881,"diff_hunk":"@@ -1,8 +1,16 @@\n \n var record = require('./recorder');\n+var assert = require('assert');\n+\n+function describeFixture(name, callback, options) {\n+  assert(name, 'name should be defined');\n+  assert(callback, 'callback should be defined');\n \n-function describeFixture(name, callback, filter) {\n   var describeFn = describe;\n+\n+  var options = options || {};\n+  var filter = (options.hasOwnProperty('filter')) ? options.filter : false;","path":"lib/describe-fixture.js","position":13,"original_position":13,"commit_id":"cfcab6cbde5062134ba07f3c1b3bb53a8e870a1e","original_commit_id":"cfcab6cbde5062134ba07f3c1b3bb53a8e870a1e","user":{"login":"jakecraige","id":3799709,"avatar_url":"https://avatars.githubusercontent.com/u/3799709?v=2","gravatar_id":"","url":"https://api.github.com/users/jakecraige","html_url":"https://github.com/jakecraige","followers_url":"https://api.github.com/users/jakecraige/followers","following_url":"https://api.github.com/users/jakecraige/following{/other_user}","gists_url":"https://api.github.com/users/jakecraige/gists{/gist_id}","starred_url":"https://api.github.com/users/jakecraige/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakecraige/subscriptions","organizations_url":"https://api.github.com/users/jakecraige/orgs","repos_url":"https://api.github.com/users/jakecraige/repos","events_url":"https://api.github.com/users/jakecraige/events{/privacy}","received_events_url":"https://api.github.com/users/jakecraige/received_events","type":"User","site_admin":false},"body":"What does this add that simple `if (filter)` doesn't handle? ","created_at":"2014-10-27T14:58:14Z","updated_at":"2014-10-27T14:58:14Z","html_url":"https://github.com/poetic/mocha-nock-fixtures/pull/7#discussion_r19409881","pull_request_url":"https://api.github.com/repos/poetic/mocha-nock-fixtures/pulls/7","_links":{"self":{"href":"https://api.github.com/repos/poetic/mocha-nock-fixtures/pulls/comments/19409881"},"html":{"href":"https://github.com/poetic/mocha-nock-fixtures/pull/7#discussion_r19409881"},"pull_request":{"href":"https://api.github.com/repos/poetic/mocha-nock-fixtures/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/poetic/mocha-nock-fixtures/pulls/7","id":23385800,"html_url":"https://github.com/poetic/mocha-nock-fixtures/pull/7","diff_url":"https://github.com/poetic/mocha-nock-fixtures/pull/7.diff","patch_url":"https://github.com/poetic/mocha-nock-fixtures/pull/7.patch","issue_url":"https://api.github.com/repos/poetic/mocha-nock-fixtures/issues/7","number":7,"state":"open","locked":false,"title":"Nock options support","user":{"login":"ariskemper","id":4061891,"avatar_url":"https://avatars.githubusercontent.com/u/4061891?v=2","gravatar_id":"","url":"https://api.github.com/users/ariskemper","html_url":"https://github.com/ariskemper","followers_url":"https://api.github.com/users/ariskemper/followers","following_url":"https://api.github.com/users/ariskemper/following{/other_user}","gists_url":"https://api.github.com/users/ariskemper/gists{/gist_id}","starred_url":"https://api.github.com/users/ariskemper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ariskemper/subscriptions","organizations_url":"https://api.github.com/users/ariskemper/orgs","repos_url":"https://api.github.com/users/ariskemper/repos","events_url":"https://api.github.com/users/ariskemper/events{/privacy}","received_events_url":"https://api.github.com/users/ariskemper/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-10-27T14:17:45Z","updated_at":"2014-10-27T14:58:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aca641f557e9922e6087f64ee9850be15d239935","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/poetic/mocha-nock-fixtures/pulls/7/commits","review_comments_url":"https://api.github.com/repos/poetic/mocha-nock-fixtures/pulls/7/comments","review_comment_url":"https://api.github.com/repos/poetic/mocha-nock-fixtures/pulls/comments/{number}","comments_url":"https://api.github.com/repos/poetic/mocha-nock-fixtures/issues/7/comments","statuses_url":"https://api.github.com/repos/poetic/mocha-nock-fixtures/statuses/cfcab6cbde5062134ba07f3c1b3bb53a8e870a1e","head":{"label":"ariskemper:nock_options_support","ref":"nock_options_support","sha":"cfcab6cbde5062134ba07f3c1b3bb53a8e870a1e","user":{"login":"ariskemper","id":4061891,"avatar_url":"https://avatars.githubusercontent.com/u/4061891?v=2","gravatar_id":"","url":"https://api.github.com/users/ariskemper","html_url":"https://github.com/ariskemper","followers_url":"https://api.github.com/users/ariskemper/followers","following_url":"https://api.github.com/users/ariskemper/following{/other_user}","gists_url":"https://api.github.com/users/ariskemper/gists{/gist_id}","starred_url":"https://api.github.com/users/ariskemper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ariskemper/subscriptions","organizations_url":"https://api.github.com/users/ariskemper/orgs","repos_url":"https://api.github.com/users/ariskemper/repos","events_url":"https://api.github.com/users/ariskemper/events{/privacy}","received_events_url":"https://api.github.com/users/ariskemper/received_events","type":"User","site_admin":false},"repo":{"id":25819745,"name":"mocha-nock-fixtures","full_name":"ariskemper/mocha-nock-fixtures","owner":{"login":"ariskemper","id":4061891,"avatar_url":"https://avatars.githubusercontent.com/u/4061891?v=2","gravatar_id":"","url":"https://api.github.com/users/ariskemper","html_url":"https://github.com/ariskemper","followers_url":"https://api.github.com/users/ariskemper/followers","following_url":"https://api.github.com/users/ariskemper/following{/other_user}","gists_url":"https://api.github.com/users/ariskemper/gists{/gist_id}","starred_url":"https://api.github.com/users/ariskemper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ariskemper/subscriptions","organizations_url":"https://api.github.com/users/ariskemper/orgs","repos_url":"https://api.github.com/users/ariskemper/repos","events_url":"https://api.github.com/users/ariskemper/events{/privacy}","received_events_url":"https://api.github.com/users/ariskemper/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ariskemper/mocha-nock-fixtures","description":"A simple library that makes saving fixtures with nock and mocha easy.","fork":true,"url":"https://api.github.com/repos/ariskemper/mocha-nock-fixtures","forks_url":"https://api.github.com/repos/ariskemper/mocha-nock-fixtures/forks","keys_url":"https://api.github.com/repos/ariskemper/mocha-nock-fixtures/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ariskemper/mocha-nock-fixtures/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ariskemper/mocha-nock-fixtures/teams","hooks_url":"https://api.github.com/repos/ariskemper/mocha-nock-fixtures/hooks","issue_events_url":"https://api.github.com/repos/ariskemper/mocha-nock-fixtures/issues/events{/number}","events_url":"https://api.github.com/repos/ariskemper/mocha-nock-fixtures/events","assignees_url":"https://api.github.com/repos/ariskemper/mocha-nock-fixtures/assignees{/user}","branches_url":"https://api.github.com/repos/ariskemper/mocha-nock-fixtures/branches{/branch}","tags_url":"https://api.github.com/repos/ariskemper/mocha-nock-fixtures/tags","blobs_url":"https://api.github.com/repos/ariskemper/mocha-nock-fixtures/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ariskemper/mocha-nock-fixtures/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ariskemper/mocha-nock-fixtures/git/refs{/sha}","trees_url":"https://api.github.com/repos/ariskemper/mocha-nock-fixtures/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ariskemper/mocha-nock-fixtures/statuses/{sha}","languages_url":"https://api.github.com/repos/ariskemper/mocha-nock-fixtures/languages","stargazers_url":"https://api.github.com/repos/ariskemper/mocha-nock-fixtures/stargazers","contributors_url":"https://api.github.com/repos/ariskemper/mocha-nock-fixtures/contributors","subscribers_url":"https://api.github.com/repos/ariskemper/mocha-nock-fixtures/subscribers","subscription_url":"https://api.github.com/repos/ariskemper/mocha-nock-fixtures/subscription","commits_url":"https://api.github.com/repos/ariskemper/mocha-nock-fixtures/commits{/sha}","git_commits_url":"https://api.github.com/repos/ariskemper/mocha-nock-fixtures/git/commits{/sha}","comments_url":"https://api.github.com/repos/ariskemper/mocha-nock-fixtures/comments{/number}","issue_comment_url":"https://api.github.com/repos/ariskemper/mocha-nock-fixtures/issues/comments/{number}","contents_url":"https://api.github.com/repos/ariskemper/mocha-nock-fixtures/contents/{+path}","compare_url":"https://api.github.com/repos/ariskemper/mocha-nock-fixtures/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ariskemper/mocha-nock-fixtures/merges","archive_url":"https://api.github.com/repos/ariskemper/mocha-nock-fixtures/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ariskemper/mocha-nock-fixtures/downloads","issues_url":"https://api.github.com/repos/ariskemper/mocha-nock-fixtures/issues{/number}","pulls_url":"https://api.github.com/repos/ariskemper/mocha-nock-fixtures/pulls{/number}","milestones_url":"https://api.github.com/repos/ariskemper/mocha-nock-fixtures/milestones{/number}","notifications_url":"https://api.github.com/repos/ariskemper/mocha-nock-fixtures/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ariskemper/mocha-nock-fixtures/labels{/name}","releases_url":"https://api.github.com/repos/ariskemper/mocha-nock-fixtures/releases{/id}","created_at":"2014-10-27T13:14:38Z","updated_at":"2014-10-17T23:35:07Z","pushed_at":"2014-10-27T14:15:54Z","git_url":"git://github.com/ariskemper/mocha-nock-fixtures.git","ssh_url":"git@github.com:ariskemper/mocha-nock-fixtures.git","clone_url":"https://github.com/ariskemper/mocha-nock-fixtures.git","svn_url":"https://github.com/ariskemper/mocha-nock-fixtures","homepage":null,"size":212,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"poetic:master","ref":"master","sha":"d200eabc3457e403304271429abd14cdfeb6350b","user":{"login":"poetic","id":102288,"avatar_url":"https://avatars.githubusercontent.com/u/102288?v=2","gravatar_id":"","url":"https://api.github.com/users/poetic","html_url":"https://github.com/poetic","followers_url":"https://api.github.com/users/poetic/followers","following_url":"https://api.github.com/users/poetic/following{/other_user}","gists_url":"https://api.github.com/users/poetic/gists{/gist_id}","starred_url":"https://api.github.com/users/poetic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poetic/subscriptions","organizations_url":"https://api.github.com/users/poetic/orgs","repos_url":"https://api.github.com/users/poetic/repos","events_url":"https://api.github.com/users/poetic/events{/privacy}","received_events_url":"https://api.github.com/users/poetic/received_events","type":"Organization","site_admin":false},"repo":{"id":25380777,"name":"mocha-nock-fixtures","full_name":"poetic/mocha-nock-fixtures","owner":{"login":"poetic","id":102288,"avatar_url":"https://avatars.githubusercontent.com/u/102288?v=2","gravatar_id":"","url":"https://api.github.com/users/poetic","html_url":"https://github.com/poetic","followers_url":"https://api.github.com/users/poetic/followers","following_url":"https://api.github.com/users/poetic/following{/other_user}","gists_url":"https://api.github.com/users/poetic/gists{/gist_id}","starred_url":"https://api.github.com/users/poetic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poetic/subscriptions","organizations_url":"https://api.github.com/users/poetic/orgs","repos_url":"https://api.github.com/users/poetic/repos","events_url":"https://api.github.com/users/poetic/events{/privacy}","received_events_url":"https://api.github.com/users/poetic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/poetic/mocha-nock-fixtures","description":"A simple library that makes saving fixtures with nock and mocha easy.","fork":false,"url":"https://api.github.com/repos/poetic/mocha-nock-fixtures","forks_url":"https://api.github.com/repos/poetic/mocha-nock-fixtures/forks","keys_url":"https://api.github.com/repos/poetic/mocha-nock-fixtures/keys{/key_id}","collaborators_url":"https://api.github.com/repos/poetic/mocha-nock-fixtures/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/poetic/mocha-nock-fixtures/teams","hooks_url":"https://api.github.com/repos/poetic/mocha-nock-fixtures/hooks","issue_events_url":"https://api.github.com/repos/poetic/mocha-nock-fixtures/issues/events{/number}","events_url":"https://api.github.com/repos/poetic/mocha-nock-fixtures/events","assignees_url":"https://api.github.com/repos/poetic/mocha-nock-fixtures/assignees{/user}","branches_url":"https://api.github.com/repos/poetic/mocha-nock-fixtures/branches{/branch}","tags_url":"https://api.github.com/repos/poetic/mocha-nock-fixtures/tags","blobs_url":"https://api.github.com/repos/poetic/mocha-nock-fixtures/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/poetic/mocha-nock-fixtures/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/poetic/mocha-nock-fixtures/git/refs{/sha}","trees_url":"https://api.github.com/repos/poetic/mocha-nock-fixtures/git/trees{/sha}","statuses_url":"https://api.github.com/repos/poetic/mocha-nock-fixtures/statuses/{sha}","languages_url":"https://api.github.com/repos/poetic/mocha-nock-fixtures/languages","stargazers_url":"https://api.github.com/repos/poetic/mocha-nock-fixtures/stargazers","contributors_url":"https://api.github.com/repos/poetic/mocha-nock-fixtures/contributors","subscribers_url":"https://api.github.com/repos/poetic/mocha-nock-fixtures/subscribers","subscription_url":"https://api.github.com/repos/poetic/mocha-nock-fixtures/subscription","commits_url":"https://api.github.com/repos/poetic/mocha-nock-fixtures/commits{/sha}","git_commits_url":"https://api.github.com/repos/poetic/mocha-nock-fixtures/git/commits{/sha}","comments_url":"https://api.github.com/repos/poetic/mocha-nock-fixtures/comments{/number}","issue_comment_url":"https://api.github.com/repos/poetic/mocha-nock-fixtures/issues/comments/{number}","contents_url":"https://api.github.com/repos/poetic/mocha-nock-fixtures/contents/{+path}","compare_url":"https://api.github.com/repos/poetic/mocha-nock-fixtures/compare/{base}...{head}","merges_url":"https://api.github.com/repos/poetic/mocha-nock-fixtures/merges","archive_url":"https://api.github.com/repos/poetic/mocha-nock-fixtures/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/poetic/mocha-nock-fixtures/downloads","issues_url":"https://api.github.com/repos/poetic/mocha-nock-fixtures/issues{/number}","pulls_url":"https://api.github.com/repos/poetic/mocha-nock-fixtures/pulls{/number}","milestones_url":"https://api.github.com/repos/poetic/mocha-nock-fixtures/milestones{/number}","notifications_url":"https://api.github.com/repos/poetic/mocha-nock-fixtures/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/poetic/mocha-nock-fixtures/labels{/name}","releases_url":"https://api.github.com/repos/poetic/mocha-nock-fixtures/releases{/id}","created_at":"2014-10-17T23:13:30Z","updated_at":"2014-10-17T23:35:07Z","pushed_at":"2014-10-23T14:58:44Z","git_url":"git://github.com/poetic/mocha-nock-fixtures.git","ssh_url":"git@github.com:poetic/mocha-nock-fixtures.git","clone_url":"https://github.com/poetic/mocha-nock-fixtures.git","svn_url":"https://github.com/poetic/mocha-nock-fixtures","homepage":null,"size":212,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":4,"forks":1,"open_issues":4,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/poetic/mocha-nock-fixtures/pulls/7"},"html":{"href":"https://github.com/poetic/mocha-nock-fixtures/pull/7"},"issue":{"href":"https://api.github.com/repos/poetic/mocha-nock-fixtures/issues/7"},"comments":{"href":"https://api.github.com/repos/poetic/mocha-nock-fixtures/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/poetic/mocha-nock-fixtures/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/poetic/mocha-nock-fixtures/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/poetic/mocha-nock-fixtures/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/poetic/mocha-nock-fixtures/statuses/cfcab6cbde5062134ba07f3c1b3bb53a8e870a1e"}}}}