GitHub PullRequestReviewCommentEvent at 2014-01-06 21:03:57
Repository: pysb
Actor: jmuhlich
Payload: {"comment":{"url":"https://api.github.com/repos/pysb/pysb/pulls/comments/8677358","id":8677358,"diff_hunk":"@@ -416,6 +428,12 @@ def __pow__(self, other):\n         else:\n             return NotImplemented\n \n+    def __eq__(self, other):\n+        return type(self)           == type(other)           and \\\n+               self.monomer         == other.monomer         and \\\n+               self.site_conditions == other.site_conditions and \\","path":"pysb/core.py","position":44,"original_position":44,"commit_id":"b1faec28e488757ef7496319512ee3db00695a25","original_commit_id":"b1faec28e488757ef7496319512ee3db00695a25","user":{"login":"jmuhlich","id":277154,"avatar_url":"https://gravatar.com/avatar/b82d0853344db1e179dd36ed035879db?d=https%3A%2F%2Fidenticons.github.com%2F6588d2dab3705f14663f3ae93028e60c.png&r=x","gravatar_id":"b82d0853344db1e179dd36ed035879db","url":"https://api.github.com/users/jmuhlich","html_url":"https://github.com/jmuhlich","followers_url":"https://api.github.com/users/jmuhlich/followers","following_url":"https://api.github.com/users/jmuhlich/following{/other_user}","gists_url":"https://api.github.com/users/jmuhlich/gists{/gist_id}","starred_url":"https://api.github.com/users/jmuhlich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmuhlich/subscriptions","organizations_url":"https://api.github.com/users/jmuhlich/orgs","repos_url":"https://api.github.com/users/jmuhlich/repos","events_url":"https://api.github.com/users/jmuhlich/events{/privacy}","received_events_url":"https://api.github.com/users/jmuhlich/received_events","type":"User","site_admin":false},"body":"Requiring `site_conditions` to be literally identical seems overly strict. If there are half-bonds involved, I can't see why the bond numbers would have to be equal to consider the MonomerPatterns equal. For example `A(b='x', c=1)` should probably be equal to `A(b='x', c=2)`.","created_at":"2014-01-06T21:03:57Z","updated_at":"2014-01-06T21:03:57Z","html_url":"https://github.com/pysb/pysb/pull/87#discussion_r8677358","pull_request_url":"https://api.github.com/repos/pysb/pysb/pulls/87","_links":{"self":{"href":"https://api.github.com/repos/pysb/pysb/pulls/comments/8677358"},"html":{"href":"https://github.com/pysb/pysb/pull/87#discussion_r8677358"},"pull_request":{"href":"https://api.github.com/repos/pysb/pysb/pulls/87"}}}}