GitHub PullRequestEvent at 2014-12-05 20:01:52
Repository: MuseScore
Actor: MarcSabatella
Payload: {"action":"opened","number":1508,"pull_request":{"url":"https://api.github.com/repos/musescore/MuseScore/pulls/1508","id":25596022,"html_url":"https://github.com/musescore/MuseScore/pull/1508","diff_url":"https://github.com/musescore/MuseScore/pull/1508.diff","patch_url":"https://github.com/musescore/MuseScore/pull/1508.patch","issue_url":"https://api.github.com/repos/musescore/MuseScore/issues/1508","number":1508,"state":"open","locked":false,"title":"fix #40641: incorrect import/export of relative-x","user":{"login":"MarcSabatella","id":1799936,"avatar_url":"https://avatars.githubusercontent.com/u/1799936?v=3","gravatar_id":"","url":"https://api.github.com/users/MarcSabatella","html_url":"https://github.com/MarcSabatella","followers_url":"https://api.github.com/users/MarcSabatella/followers","following_url":"https://api.github.com/users/MarcSabatella/following{/other_user}","gists_url":"https://api.github.com/users/MarcSabatella/gists{/gist_id}","starred_url":"https://api.github.com/users/MarcSabatella/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarcSabatella/subscriptions","organizations_url":"https://api.github.com/users/MarcSabatella/orgs","repos_url":"https://api.github.com/users/MarcSabatella/repos","events_url":"https://api.github.com/users/MarcSabatella/events{/privacy}","received_events_url":"https://api.github.com/users/MarcSabatella/received_events","type":"User","site_admin":false},"body":"As discussed in issue, I think it makes sense for now to simply not import or export relative-x for chord symbols, since we don't do it for any other elements.  There is an existing \"todo\" note regarding support of offsets and relative-x.  I left the relative-x in but commented it out to have for reference if/wehn the time comes to revisit any of this.  It seems that is also the approach taken for various other places where relative-x was being used or considered for use at one time.","created_at":"2014-12-05T20:01:51Z","updated_at":"2014-12-05T20:01:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/musescore/MuseScore/pulls/1508/commits","review_comments_url":"https://api.github.com/repos/musescore/MuseScore/pulls/1508/comments","review_comment_url":"https://api.github.com/repos/musescore/MuseScore/pulls/comments/{number}","comments_url":"https://api.github.com/repos/musescore/MuseScore/issues/1508/comments","statuses_url":"https://api.github.com/repos/musescore/MuseScore/statuses/4c547729d8b32066d05be506ff6f25f59f3e91b2","head":{"label":"MarcSabatella:40641-relative-x","ref":"40641-relative-x","sha":"4c547729d8b32066d05be506ff6f25f59f3e91b2","user":{"login":"MarcSabatella","id":1799936,"avatar_url":"https://avatars.githubusercontent.com/u/1799936?v=3","gravatar_id":"","url":"https://api.github.com/users/MarcSabatella","html_url":"https://github.com/MarcSabatella","followers_url":"https://api.github.com/users/MarcSabatella/followers","following_url":"https://api.github.com/users/MarcSabatella/following{/other_user}","gists_url":"https://api.github.com/users/MarcSabatella/gists{/gist_id}","starred_url":"https://api.github.com/users/MarcSabatella/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarcSabatella/subscriptions","organizations_url":"https://api.github.com/users/MarcSabatella/orgs","repos_url":"https://api.github.com/users/MarcSabatella/repos","events_url":"https://api.github.com/users/MarcSabatella/events{/privacy}","received_events_url":"https://api.github.com/users/MarcSabatella/received_events","type":"User","site_admin":false},"repo":{"id":14895853,"name":"MuseScore","full_name":"MarcSabatella/MuseScore","owner":{"login":"MarcSabatella","id":1799936,"avatar_url":"https://avatars.githubusercontent.com/u/1799936?v=3","gravatar_id":"","url":"https://api.github.com/users/MarcSabatella","html_url":"https://github.com/MarcSabatella","followers_url":"https://api.github.com/users/MarcSabatella/followers","following_url":"https://api.github.com/users/MarcSabatella/following{/other_user}","gists_url":"https://api.github.com/users/MarcSabatella/gists{/gist_id}","starred_url":"https://api.github.com/users/MarcSabatella/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarcSabatella/subscriptions","organizations_url":"https://api.github.com/users/MarcSabatella/orgs","repos_url":"https://api.github.com/users/MarcSabatella/repos","events_url":"https://api.github.com/users/MarcSabatella/events{/privacy}","received_events_url":"https://api.github.com/users/MarcSabatella/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MarcSabatella/MuseScore","description":"MuseScore is a open source and free music notation software. For support, contribution, bug reports, visit MuseScore.org. Fork and make pull requests!","fork":true,"url":"https://api.github.com/repos/MarcSabatella/MuseScore","forks_url":"https://api.github.com/repos/MarcSabatella/MuseScore/forks","keys_url":"https://api.github.com/repos/MarcSabatella/MuseScore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MarcSabatella/MuseScore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MarcSabatella/MuseScore/teams","hooks_url":"https://api.github.com/repos/MarcSabatella/MuseScore/hooks","issue_events_url":"https://api.github.com/repos/MarcSabatella/MuseScore/issues/events{/number}","events_url":"https://api.github.com/repos/MarcSabatella/MuseScore/events","assignees_url":"https://api.github.com/repos/MarcSabatella/MuseScore/assignees{/user}","branches_url":"https://api.github.com/repos/MarcSabatella/MuseScore/branches{/branch}","tags_url":"https://api.github.com/repos/MarcSabatella/MuseScore/tags","blobs_url":"https://api.github.com/repos/MarcSabatella/MuseScore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MarcSabatella/MuseScore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MarcSabatella/MuseScore/git/refs{/sha}","trees_url":"https://api.github.com/repos/MarcSabatella/MuseScore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MarcSabatella/MuseScore/statuses/{sha}","languages_url":"https://api.github.com/repos/MarcSabatella/MuseScore/languages","stargazers_url":"https://api.github.com/repos/MarcSabatella/MuseScore/stargazers","contributors_url":"https://api.github.com/repos/MarcSabatella/MuseScore/contributors","subscribers_url":"https://api.github.com/repos/MarcSabatella/MuseScore/subscribers","subscription_url":"https://api.github.com/repos/MarcSabatella/MuseScore/subscription","commits_url":"https://api.github.com/repos/MarcSabatella/MuseScore/commits{/sha}","git_commits_url":"https://api.github.com/repos/MarcSabatella/MuseScore/git/commits{/sha}","comments_url":"https://api.github.com/repos/MarcSabatella/MuseScore/comments{/number}","issue_comment_url":"https://api.github.com/repos/MarcSabatella/MuseScore/issues/comments/{number}","contents_url":"https://api.github.com/repos/MarcSabatella/MuseScore/contents/{+path}","compare_url":"https://api.github.com/repos/MarcSabatella/MuseScore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MarcSabatella/MuseScore/merges","archive_url":"https://api.github.com/repos/MarcSabatella/MuseScore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MarcSabatella/MuseScore/downloads","issues_url":"https://api.github.com/repos/MarcSabatella/MuseScore/issues{/number}","pulls_url":"https://api.github.com/repos/MarcSabatella/MuseScore/pulls{/number}","milestones_url":"https://api.github.com/repos/MarcSabatella/MuseScore/milestones{/number}","notifications_url":"https://api.github.com/repos/MarcSabatella/MuseScore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MarcSabatella/MuseScore/labels{/name}","releases_url":"https://api.github.com/repos/MarcSabatella/MuseScore/releases{/id}","created_at":"2013-12-03T14:25:39Z","updated_at":"2014-11-29T06:02:30Z","pushed_at":"2014-12-05T19:58:24Z","git_url":"git://github.com/MarcSabatella/MuseScore.git","ssh_url":"git@github.com:MarcSabatella/MuseScore.git","clone_url":"https://github.com/MarcSabatella/MuseScore.git","svn_url":"https://github.com/MarcSabatella/MuseScore","homepage":"http://musescore.org","size":156251,"stargazers_count":1,"watchers_count":1,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"musescore:master","ref":"master","sha":"a25a40bfd09bb4eaf9e22b49d3fb98721c8dc33e","user":{"login":"musescore","id":380563,"avatar_url":"https://avatars.githubusercontent.com/u/380563?v=3","gravatar_id":"","url":"https://api.github.com/users/musescore","html_url":"https://github.com/musescore","followers_url":"https://api.github.com/users/musescore/followers","following_url":"https://api.github.com/users/musescore/following{/other_user}","gists_url":"https://api.github.com/users/musescore/gists{/gist_id}","starred_url":"https://api.github.com/users/musescore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/musescore/subscriptions","organizations_url":"https://api.github.com/users/musescore/orgs","repos_url":"https://api.github.com/users/musescore/repos","events_url":"https://api.github.com/users/musescore/events{/privacy}","received_events_url":"https://api.github.com/users/musescore/received_events","type":"Organization","site_admin":false},"repo":{"id":4454793,"name":"MuseScore","full_name":"musescore/MuseScore","owner":{"login":"musescore","id":380563,"avatar_url":"https://avatars.githubusercontent.com/u/380563?v=3","gravatar_id":"","url":"https://api.github.com/users/musescore","html_url":"https://github.com/musescore","followers_url":"https://api.github.com/users/musescore/followers","following_url":"https://api.github.com/users/musescore/following{/other_user}","gists_url":"https://api.github.com/users/musescore/gists{/gist_id}","starred_url":"https://api.github.com/users/musescore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/musescore/subscriptions","organizations_url":"https://api.github.com/users/musescore/orgs","repos_url":"https://api.github.com/users/musescore/repos","events_url":"https://api.github.com/users/musescore/events{/privacy}","received_events_url":"https://api.github.com/users/musescore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/musescore/MuseScore","description":"MuseScore is an open source and free music notation software. For support, contribution, bug reports, visit MuseScore.org. Fork and make pull requests!","fork":false,"url":"https://api.github.com/repos/musescore/MuseScore","forks_url":"https://api.github.com/repos/musescore/MuseScore/forks","keys_url":"https://api.github.com/repos/musescore/MuseScore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/musescore/MuseScore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/musescore/MuseScore/teams","hooks_url":"https://api.github.com/repos/musescore/MuseScore/hooks","issue_events_url":"https://api.github.com/repos/musescore/MuseScore/issues/events{/number}","events_url":"https://api.github.com/repos/musescore/MuseScore/events","assignees_url":"https://api.github.com/repos/musescore/MuseScore/assignees{/user}","branches_url":"https://api.github.com/repos/musescore/MuseScore/branches{/branch}","tags_url":"https://api.github.com/repos/musescore/MuseScore/tags","blobs_url":"https://api.github.com/repos/musescore/MuseScore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/musescore/MuseScore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/musescore/MuseScore/git/refs{/sha}","trees_url":"https://api.github.com/repos/musescore/MuseScore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/musescore/MuseScore/statuses/{sha}","languages_url":"https://api.github.com/repos/musescore/MuseScore/languages","stargazers_url":"https://api.github.com/repos/musescore/MuseScore/stargazers","contributors_url":"https://api.github.com/repos/musescore/MuseScore/contributors","subscribers_url":"https://api.github.com/repos/musescore/MuseScore/subscribers","subscription_url":"https://api.github.com/repos/musescore/MuseScore/subscription","commits_url":"https://api.github.com/repos/musescore/MuseScore/commits{/sha}","git_commits_url":"https://api.github.com/repos/musescore/MuseScore/git/commits{/sha}","comments_url":"https://api.github.com/repos/musescore/MuseScore/comments{/number}","issue_comment_url":"https://api.github.com/repos/musescore/MuseScore/issues/comments/{number}","contents_url":"https://api.github.com/repos/musescore/MuseScore/contents/{+path}","compare_url":"https://api.github.com/repos/musescore/MuseScore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/musescore/MuseScore/merges","archive_url":"https://api.github.com/repos/musescore/MuseScore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/musescore/MuseScore/downloads","issues_url":"https://api.github.com/repos/musescore/MuseScore/issues{/number}","pulls_url":"https://api.github.com/repos/musescore/MuseScore/pulls{/number}","milestones_url":"https://api.github.com/repos/musescore/MuseScore/milestones{/number}","notifications_url":"https://api.github.com/repos/musescore/MuseScore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/musescore/MuseScore/labels{/name}","releases_url":"https://api.github.com/repos/musescore/MuseScore/releases{/id}","created_at":"2012-05-26T12:46:33Z","updated_at":"2014-12-05T12:56:23Z","pushed_at":"2014-12-05T12:56:21Z","git_url":"git://github.com/musescore/MuseScore.git","ssh_url":"git@github.com:musescore/MuseScore.git","clone_url":"https://github.com/musescore/MuseScore.git","svn_url":"https://github.com/musescore/MuseScore","homepage":"http://musescore.org","size":310954,"stargazers_count":459,"watchers_count":459,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":310,"mirror_url":null,"open_issues_count":32,"forks":310,"open_issues":32,"watchers":459,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/musescore/MuseScore/pulls/1508"},"html":{"href":"https://github.com/musescore/MuseScore/pull/1508"},"issue":{"href":"https://api.github.com/repos/musescore/MuseScore/issues/1508"},"comments":{"href":"https://api.github.com/repos/musescore/MuseScore/issues/1508/comments"},"review_comments":{"href":"https://api.github.com/repos/musescore/MuseScore/pulls/1508/comments"},"review_comment":{"href":"https://api.github.com/repos/musescore/MuseScore/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/musescore/MuseScore/pulls/1508/commits"},"statuses":{"href":"https://api.github.com/repos/musescore/MuseScore/statuses/4c547729d8b32066d05be506ff6f25f59f3e91b2"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":20,"deletions":11,"changed_files":2}}