GitHub PullRequestEvent at 2014-09-06 13:00:33
Repository: qgroundcontrol
Actor: LorenzMeier
Payload: {"action":"closed","number":855,"pull_request":{"url":"https://api.github.com/repos/mavlink/qgroundcontrol/pulls/855","id":20548358,"html_url":"https://github.com/mavlink/qgroundcontrol/pull/855","diff_url":"https://github.com/mavlink/qgroundcontrol/pull/855.diff","patch_url":"https://github.com/mavlink/qgroundcontrol/pull/855.patch","issue_url":"https://api.github.com/repos/mavlink/qgroundcontrol/issues/855","number":855,"state":"closed","locked":false,"title":"Finish removal of APM mode selection","user":{"login":"DonLakeFlyer","id":5876851,"avatar_url":"https://avatars.githubusercontent.com/u/5876851?v=2","gravatar_id":"7f4bc837ac969430f8212c85dbf88270","url":"https://api.github.com/users/DonLakeFlyer","html_url":"https://github.com/DonLakeFlyer","followers_url":"https://api.github.com/users/DonLakeFlyer/followers","following_url":"https://api.github.com/users/DonLakeFlyer/following{/other_user}","gists_url":"https://api.github.com/users/DonLakeFlyer/gists{/gist_id}","starred_url":"https://api.github.com/users/DonLakeFlyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DonLakeFlyer/subscriptions","organizations_url":"https://api.github.com/users/DonLakeFlyer/orgs","repos_url":"https://api.github.com/users/DonLakeFlyer/repos","events_url":"https://api.github.com/users/DonLakeFlyer/events{/privacy}","received_events_url":"https://api.github.com/users/DonLakeFlyer/received_events","type":"User","site_admin":false},"body":"Just cleaning up the rest of this. The UI was a little weird because the button was gone, but the text was still there.\r\n\r\n@LorenzMeier I spoke with the APM Planner folks. They are not doing any sort of big merges across any more. They only cherry pick once and a while. Also the APM Planner branch has diverged quite a bit so trying to keep the two in sync is very difficult and not going to happen. Given the discussion I think we're ok to start disconnecting the APM specific UI and leave APM to be a mavlink only case. Although I still think there are some problems there as well. But those might be fixable.","created_at":"2014-08-31T18:52:46Z","updated_at":"2014-09-06T13:00:32Z","closed_at":"2014-09-06T13:00:32Z","merged_at":"2014-09-06T13:00:32Z","merge_commit_sha":"5a115ae72664fa05203e95e57decacc9fa197200","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mavlink/qgroundcontrol/pulls/855/commits","review_comments_url":"https://api.github.com/repos/mavlink/qgroundcontrol/pulls/855/comments","review_comment_url":"https://api.github.com/repos/mavlink/qgroundcontrol/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mavlink/qgroundcontrol/issues/855/comments","statuses_url":"https://api.github.com/repos/mavlink/qgroundcontrol/statuses/f5f57c0503a22aff774e855c4419b63bfff1981f","head":{"label":"DonLakeFlyer:APMSelectFix","ref":"APMSelectFix","sha":"f5f57c0503a22aff774e855c4419b63bfff1981f","user":{"login":"DonLakeFlyer","id":5876851,"avatar_url":"https://avatars.githubusercontent.com/u/5876851?v=2","gravatar_id":"7f4bc837ac969430f8212c85dbf88270","url":"https://api.github.com/users/DonLakeFlyer","html_url":"https://github.com/DonLakeFlyer","followers_url":"https://api.github.com/users/DonLakeFlyer/followers","following_url":"https://api.github.com/users/DonLakeFlyer/following{/other_user}","gists_url":"https://api.github.com/users/DonLakeFlyer/gists{/gist_id}","starred_url":"https://api.github.com/users/DonLakeFlyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DonLakeFlyer/subscriptions","organizations_url":"https://api.github.com/users/DonLakeFlyer/orgs","repos_url":"https://api.github.com/users/DonLakeFlyer/repos","events_url":"https://api.github.com/users/DonLakeFlyer/events{/privacy}","received_events_url":"https://api.github.com/users/DonLakeFlyer/received_events","type":"User","site_admin":false},"repo":{"id":14323257,"name":"qgroundcontrol","full_name":"DonLakeFlyer/qgroundcontrol","owner":{"login":"DonLakeFlyer","id":5876851,"avatar_url":"https://avatars.githubusercontent.com/u/5876851?v=2","gravatar_id":"7f4bc837ac969430f8212c85dbf88270","url":"https://api.github.com/users/DonLakeFlyer","html_url":"https://github.com/DonLakeFlyer","followers_url":"https://api.github.com/users/DonLakeFlyer/followers","following_url":"https://api.github.com/users/DonLakeFlyer/following{/other_user}","gists_url":"https://api.github.com/users/DonLakeFlyer/gists{/gist_id}","starred_url":"https://api.github.com/users/DonLakeFlyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DonLakeFlyer/subscriptions","organizations_url":"https://api.github.com/users/DonLakeFlyer/orgs","repos_url":"https://api.github.com/users/DonLakeFlyer/repos","events_url":"https://api.github.com/users/DonLakeFlyer/events{/privacy}","received_events_url":"https://api.github.com/users/DonLakeFlyer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DonLakeFlyer/qgroundcontrol","description":"QGroundControl Ground Control Station","fork":true,"url":"https://api.github.com/repos/DonLakeFlyer/qgroundcontrol","forks_url":"https://api.github.com/repos/DonLakeFlyer/qgroundcontrol/forks","keys_url":"https://api.github.com/repos/DonLakeFlyer/qgroundcontrol/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DonLakeFlyer/qgroundcontrol/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DonLakeFlyer/qgroundcontrol/teams","hooks_url":"https://api.github.com/repos/DonLakeFlyer/qgroundcontrol/hooks","issue_events_url":"https://api.github.com/repos/DonLakeFlyer/qgroundcontrol/issues/events{/number}","events_url":"https://api.github.com/repos/DonLakeFlyer/qgroundcontrol/events","assignees_url":"https://api.github.com/repos/DonLakeFlyer/qgroundcontrol/assignees{/user}","branches_url":"https://api.github.com/repos/DonLakeFlyer/qgroundcontrol/branches{/branch}","tags_url":"https://api.github.com/repos/DonLakeFlyer/qgroundcontrol/tags","blobs_url":"https://api.github.com/repos/DonLakeFlyer/qgroundcontrol/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DonLakeFlyer/qgroundcontrol/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DonLakeFlyer/qgroundcontrol/git/refs{/sha}","trees_url":"https://api.github.com/repos/DonLakeFlyer/qgroundcontrol/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DonLakeFlyer/qgroundcontrol/statuses/{sha}","languages_url":"https://api.github.com/repos/DonLakeFlyer/qgroundcontrol/languages","stargazers_url":"https://api.github.com/repos/DonLakeFlyer/qgroundcontrol/stargazers","contributors_url":"https://api.github.com/repos/DonLakeFlyer/qgroundcontrol/contributors","subscribers_url":"https://api.github.com/repos/DonLakeFlyer/qgroundcontrol/subscribers","subscription_url":"https://api.github.com/repos/DonLakeFlyer/qgroundcontrol/subscription","commits_url":"https://api.github.com/repos/DonLakeFlyer/qgroundcontrol/commits{/sha}","git_commits_url":"https://api.github.com/repos/DonLakeFlyer/qgroundcontrol/git/commits{/sha}","comments_url":"https://api.github.com/repos/DonLakeFlyer/qgroundcontrol/comments{/number}","issue_comment_url":"https://api.github.com/repos/DonLakeFlyer/qgroundcontrol/issues/comments/{number}","contents_url":"https://api.github.com/repos/DonLakeFlyer/qgroundcontrol/contents/{+path}","compare_url":"https://api.github.com/repos/DonLakeFlyer/qgroundcontrol/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DonLakeFlyer/qgroundcontrol/merges","archive_url":"https://api.github.com/repos/DonLakeFlyer/qgroundcontrol/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DonLakeFlyer/qgroundcontrol/downloads","issues_url":"https://api.github.com/repos/DonLakeFlyer/qgroundcontrol/issues{/number}","pulls_url":"https://api.github.com/repos/DonLakeFlyer/qgroundcontrol/pulls{/number}","milestones_url":"https://api.github.com/repos/DonLakeFlyer/qgroundcontrol/milestones{/number}","notifications_url":"https://api.github.com/repos/DonLakeFlyer/qgroundcontrol/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DonLakeFlyer/qgroundcontrol/labels{/name}","releases_url":"https://api.github.com/repos/DonLakeFlyer/qgroundcontrol/releases{/id}","created_at":"2013-11-12T05:24:25Z","updated_at":"2014-06-27T02:34:20Z","pushed_at":"2014-09-02T22:28:10Z","git_url":"git://github.com/DonLakeFlyer/qgroundcontrol.git","ssh_url":"git@github.com:DonLakeFlyer/qgroundcontrol.git","clone_url":"https://github.com/DonLakeFlyer/qgroundcontrol.git","svn_url":"https://github.com/DonLakeFlyer/qgroundcontrol","homepage":"http://qgroundcontrol.org","size":159216,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mavlink:master","ref":"master","sha":"20ac1f34c3fdd3bdeb29a3184be1ea5108ed26d5","user":{"login":"mavlink","id":961247,"avatar_url":"https://avatars.githubusercontent.com/u/961247?v=2","gravatar_id":"2588b33d7b5ed5161ad0630b814e9e80","url":"https://api.github.com/users/mavlink","html_url":"https://github.com/mavlink","followers_url":"https://api.github.com/users/mavlink/followers","following_url":"https://api.github.com/users/mavlink/following{/other_user}","gists_url":"https://api.github.com/users/mavlink/gists{/gist_id}","starred_url":"https://api.github.com/users/mavlink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mavlink/subscriptions","organizations_url":"https://api.github.com/users/mavlink/orgs","repos_url":"https://api.github.com/users/mavlink/repos","events_url":"https://api.github.com/users/mavlink/events{/privacy}","received_events_url":"https://api.github.com/users/mavlink/received_events","type":"Organization","site_admin":false},"repo":{"id":2567844,"name":"qgroundcontrol","full_name":"mavlink/qgroundcontrol","owner":{"login":"mavlink","id":961247,"avatar_url":"https://avatars.githubusercontent.com/u/961247?v=2","gravatar_id":"2588b33d7b5ed5161ad0630b814e9e80","url":"https://api.github.com/users/mavlink","html_url":"https://github.com/mavlink","followers_url":"https://api.github.com/users/mavlink/followers","following_url":"https://api.github.com/users/mavlink/following{/other_user}","gists_url":"https://api.github.com/users/mavlink/gists{/gist_id}","starred_url":"https://api.github.com/users/mavlink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mavlink/subscriptions","organizations_url":"https://api.github.com/users/mavlink/orgs","repos_url":"https://api.github.com/users/mavlink/repos","events_url":"https://api.github.com/users/mavlink/events{/privacy}","received_events_url":"https://api.github.com/users/mavlink/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mavlink/qgroundcontrol","description":"QGroundControl Ground Control Station","fork":false,"url":"https://api.github.com/repos/mavlink/qgroundcontrol","forks_url":"https://api.github.com/repos/mavlink/qgroundcontrol/forks","keys_url":"https://api.github.com/repos/mavlink/qgroundcontrol/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mavlink/qgroundcontrol/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mavlink/qgroundcontrol/teams","hooks_url":"https://api.github.com/repos/mavlink/qgroundcontrol/hooks","issue_events_url":"https://api.github.com/repos/mavlink/qgroundcontrol/issues/events{/number}","events_url":"https://api.github.com/repos/mavlink/qgroundcontrol/events","assignees_url":"https://api.github.com/repos/mavlink/qgroundcontrol/assignees{/user}","branches_url":"https://api.github.com/repos/mavlink/qgroundcontrol/branches{/branch}","tags_url":"https://api.github.com/repos/mavlink/qgroundcontrol/tags","blobs_url":"https://api.github.com/repos/mavlink/qgroundcontrol/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mavlink/qgroundcontrol/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mavlink/qgroundcontrol/git/refs{/sha}","trees_url":"https://api.github.com/repos/mavlink/qgroundcontrol/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mavlink/qgroundcontrol/statuses/{sha}","languages_url":"https://api.github.com/repos/mavlink/qgroundcontrol/languages","stargazers_url":"https://api.github.com/repos/mavlink/qgroundcontrol/stargazers","contributors_url":"https://api.github.com/repos/mavlink/qgroundcontrol/contributors","subscribers_url":"https://api.github.com/repos/mavlink/qgroundcontrol/subscribers","subscription_url":"https://api.github.com/repos/mavlink/qgroundcontrol/subscription","commits_url":"https://api.github.com/repos/mavlink/qgroundcontrol/commits{/sha}","git_commits_url":"https://api.github.com/repos/mavlink/qgroundcontrol/git/commits{/sha}","comments_url":"https://api.github.com/repos/mavlink/qgroundcontrol/comments{/number}","issue_comment_url":"https://api.github.com/repos/mavlink/qgroundcontrol/issues/comments/{number}","contents_url":"https://api.github.com/repos/mavlink/qgroundcontrol/contents/{+path}","compare_url":"https://api.github.com/repos/mavlink/qgroundcontrol/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mavlink/qgroundcontrol/merges","archive_url":"https://api.github.com/repos/mavlink/qgroundcontrol/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mavlink/qgroundcontrol/downloads","issues_url":"https://api.github.com/repos/mavlink/qgroundcontrol/issues{/number}","pulls_url":"https://api.github.com/repos/mavlink/qgroundcontrol/pulls{/number}","milestones_url":"https://api.github.com/repos/mavlink/qgroundcontrol/milestones{/number}","notifications_url":"https://api.github.com/repos/mavlink/qgroundcontrol/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mavlink/qgroundcontrol/labels{/name}","releases_url":"https://api.github.com/repos/mavlink/qgroundcontrol/releases{/id}","created_at":"2011-10-13T07:31:07Z","updated_at":"2014-09-06T10:01:33Z","pushed_at":"2014-09-06T13:00:32Z","git_url":"git://github.com/mavlink/qgroundcontrol.git","ssh_url":"git@github.com:mavlink/qgroundcontrol.git","clone_url":"https://github.com/mavlink/qgroundcontrol.git","svn_url":"https://github.com/mavlink/qgroundcontrol","homepage":"http://qgroundcontrol.org","size":175407,"stargazers_count":143,"watchers_count":143,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":199,"mirror_url":null,"open_issues_count":216,"forks":199,"open_issues":216,"watchers":143,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mavlink/qgroundcontrol/pulls/855"},"html":{"href":"https://github.com/mavlink/qgroundcontrol/pull/855"},"issue":{"href":"https://api.github.com/repos/mavlink/qgroundcontrol/issues/855"},"comments":{"href":"https://api.github.com/repos/mavlink/qgroundcontrol/issues/855/comments"},"review_comments":{"href":"https://api.github.com/repos/mavlink/qgroundcontrol/pulls/855/comments"},"review_comment":{"href":"https://api.github.com/repos/mavlink/qgroundcontrol/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mavlink/qgroundcontrol/pulls/855/commits"},"statuses":{"href":"https://api.github.com/repos/mavlink/qgroundcontrol/statuses/f5f57c0503a22aff774e855c4419b63bfff1981f"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"LorenzMeier","id":1208119,"avatar_url":"https://avatars.githubusercontent.com/u/1208119?v=2","gravatar_id":"a158a179a58e6abfabd5cb8fbeeec641","url":"https://api.github.com/users/LorenzMeier","html_url":"https://github.com/LorenzMeier","followers_url":"https://api.github.com/users/LorenzMeier/followers","following_url":"https://api.github.com/users/LorenzMeier/following{/other_user}","gists_url":"https://api.github.com/users/LorenzMeier/gists{/gist_id}","starred_url":"https://api.github.com/users/LorenzMeier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LorenzMeier/subscriptions","organizations_url":"https://api.github.com/users/LorenzMeier/orgs","repos_url":"https://api.github.com/users/LorenzMeier/repos","events_url":"https://api.github.com/users/LorenzMeier/events{/privacy}","received_events_url":"https://api.github.com/users/LorenzMeier/received_events","type":"User","site_admin":false},"comments":0,"review_comments":2,"commits":2,"additions":0,"deletions":35,"changed_files":3}}