GitHub PullRequestReviewCommentEvent at 2014-10-06 07:39:56
Repository: glfw-rs
Actor: bjz
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/bjz/glfw-rs/pulls/comments/18443777","id":18443777,"diff_hunk":"@@ -21,9 +21,13 @@ authors = [\n         \"zofrex\",\n ]\n \n+[features]\n+default = [\"glfw-sys\"]","path":"Cargo.toml","position":5,"original_position":5,"commit_id":"b62babe8f799bdce8cf8def12f50c8f3a8959581","original_commit_id":"b62babe8f799bdce8cf8def12f50c8f3a8959581","user":{"login":"bjz","id":695077,"avatar_url":"https://avatars.githubusercontent.com/u/695077?v=2","gravatar_id":"","url":"https://api.github.com/users/bjz","html_url":"https://github.com/bjz","followers_url":"https://api.github.com/users/bjz/followers","following_url":"https://api.github.com/users/bjz/following{/other_user}","gists_url":"https://api.github.com/users/bjz/gists{/gist_id}","starred_url":"https://api.github.com/users/bjz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjz/subscriptions","organizations_url":"https://api.github.com/users/bjz/orgs","repos_url":"https://api.github.com/users/bjz/repos","events_url":"https://api.github.com/users/bjz/events{/privacy}","received_events_url":"https://api.github.com/users/bjz/received_events","type":"User","site_admin":false},"body":"Oh, so would this be better called `bundled-glfw` or something?","created_at":"2014-10-06T07:39:56Z","updated_at":"2014-10-06T07:39:56Z","html_url":"https://github.com/bjz/glfw-rs/pull/231#discussion_r18443777","pull_request_url":"https://api.github.com/repos/bjz/glfw-rs/pulls/231","_links":{"self":{"href":"https://api.github.com/repos/bjz/glfw-rs/pulls/comments/18443777"},"html":{"href":"https://github.com/bjz/glfw-rs/pull/231#discussion_r18443777"},"pull_request":{"href":"https://api.github.com/repos/bjz/glfw-rs/pulls/231"}}},"pull_request":{"url":"https://api.github.com/repos/bjz/glfw-rs/pulls/231","id":22199411,"html_url":"https://github.com/bjz/glfw-rs/pull/231","diff_url":"https://github.com/bjz/glfw-rs/pull/231.diff","patch_url":"https://github.com/bjz/glfw-rs/pull/231.patch","issue_url":"https://api.github.com/repos/bjz/glfw-rs/issues/231","number":231,"state":"open","locked":false,"title":"Use Cargo features to restore Windows compatibility","user":{"login":"tomaka","id":1412254,"avatar_url":"https://avatars.githubusercontent.com/u/1412254?v=2","gravatar_id":"","url":"https://api.github.com/users/tomaka","html_url":"https://github.com/tomaka","followers_url":"https://api.github.com/users/tomaka/followers","following_url":"https://api.github.com/users/tomaka/following{/other_user}","gists_url":"https://api.github.com/users/tomaka/gists{/gist_id}","starred_url":"https://api.github.com/users/tomaka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomaka/subscriptions","organizations_url":"https://api.github.com/users/tomaka/orgs","repos_url":"https://api.github.com/users/tomaka/repos","events_url":"https://api.github.com/users/tomaka/events{/privacy}","received_events_url":"https://api.github.com/users/tomaka/received_events","type":"User","site_admin":false},"body":"See this: http://crates.io/manifest.html#the-[features]-section\r\n\r\nUsing `glfw-rs` on windows:\r\n```toml\r\n[dependencies.glfw-rs]\r\ngit = \"https://github.com/bjz/glfw-rs\"\r\ndefault-features = false\r\n```\r\n\r\nBuilding `glfw-rs` on Windows: `cargo build --no-default-feature`\r\n\r\nThis will prevent the `glfw-sys` dependency from being compiled.\r\n\r\nOn any other platform, it stays the same.\r\n","created_at":"2014-10-03T11:58:17Z","updated_at":"2014-10-06T07:39:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a29a8e34742f04eabe72e1e67c65976c814fa6ce","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bjz/glfw-rs/pulls/231/commits","review_comments_url":"https://api.github.com/repos/bjz/glfw-rs/pulls/231/comments","review_comment_url":"https://api.github.com/repos/bjz/glfw-rs/pulls/comments/{number}","comments_url":"https://api.github.com/repos/bjz/glfw-rs/issues/231/comments","statuses_url":"https://api.github.com/repos/bjz/glfw-rs/statuses/b62babe8f799bdce8cf8def12f50c8f3a8959581","head":{"label":"tomaka:master","ref":"master","sha":"b62babe8f799bdce8cf8def12f50c8f3a8959581","user":{"login":"tomaka","id":1412254,"avatar_url":"https://avatars.githubusercontent.com/u/1412254?v=2","gravatar_id":"","url":"https://api.github.com/users/tomaka","html_url":"https://github.com/tomaka","followers_url":"https://api.github.com/users/tomaka/followers","following_url":"https://api.github.com/users/tomaka/following{/other_user}","gists_url":"https://api.github.com/users/tomaka/gists{/gist_id}","starred_url":"https://api.github.com/users/tomaka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomaka/subscriptions","organizations_url":"https://api.github.com/users/tomaka/orgs","repos_url":"https://api.github.com/users/tomaka/repos","events_url":"https://api.github.com/users/tomaka/events{/privacy}","received_events_url":"https://api.github.com/users/tomaka/received_events","type":"User","site_admin":false},"repo":{"id":24756504,"name":"glfw-rs","full_name":"tomaka/glfw-rs","owner":{"login":"tomaka","id":1412254,"avatar_url":"https://avatars.githubusercontent.com/u/1412254?v=2","gravatar_id":"","url":"https://api.github.com/users/tomaka","html_url":"https://github.com/tomaka","followers_url":"https://api.github.com/users/tomaka/followers","following_url":"https://api.github.com/users/tomaka/following{/other_user}","gists_url":"https://api.github.com/users/tomaka/gists{/gist_id}","starred_url":"https://api.github.com/users/tomaka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomaka/subscriptions","organizations_url":"https://api.github.com/users/tomaka/orgs","repos_url":"https://api.github.com/users/tomaka/repos","events_url":"https://api.github.com/users/tomaka/events{/privacy}","received_events_url":"https://api.github.com/users/tomaka/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tomaka/glfw-rs","description":"GLFW3 bindings and idiomatic wrapper for Rust.","fork":true,"url":"https://api.github.com/repos/tomaka/glfw-rs","forks_url":"https://api.github.com/repos/tomaka/glfw-rs/forks","keys_url":"https://api.github.com/repos/tomaka/glfw-rs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tomaka/glfw-rs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tomaka/glfw-rs/teams","hooks_url":"https://api.github.com/repos/tomaka/glfw-rs/hooks","issue_events_url":"https://api.github.com/repos/tomaka/glfw-rs/issues/events{/number}","events_url":"https://api.github.com/repos/tomaka/glfw-rs/events","assignees_url":"https://api.github.com/repos/tomaka/glfw-rs/assignees{/user}","branches_url":"https://api.github.com/repos/tomaka/glfw-rs/branches{/branch}","tags_url":"https://api.github.com/repos/tomaka/glfw-rs/tags","blobs_url":"https://api.github.com/repos/tomaka/glfw-rs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tomaka/glfw-rs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tomaka/glfw-rs/git/refs{/sha}","trees_url":"https://api.github.com/repos/tomaka/glfw-rs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tomaka/glfw-rs/statuses/{sha}","languages_url":"https://api.github.com/repos/tomaka/glfw-rs/languages","stargazers_url":"https://api.github.com/repos/tomaka/glfw-rs/stargazers","contributors_url":"https://api.github.com/repos/tomaka/glfw-rs/contributors","subscribers_url":"https://api.github.com/repos/tomaka/glfw-rs/subscribers","subscription_url":"https://api.github.com/repos/tomaka/glfw-rs/subscription","commits_url":"https://api.github.com/repos/tomaka/glfw-rs/commits{/sha}","git_commits_url":"https://api.github.com/repos/tomaka/glfw-rs/git/commits{/sha}","comments_url":"https://api.github.com/repos/tomaka/glfw-rs/comments{/number}","issue_comment_url":"https://api.github.com/repos/tomaka/glfw-rs/issues/comments/{number}","contents_url":"https://api.github.com/repos/tomaka/glfw-rs/contents/{+path}","compare_url":"https://api.github.com/repos/tomaka/glfw-rs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tomaka/glfw-rs/merges","archive_url":"https://api.github.com/repos/tomaka/glfw-rs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tomaka/glfw-rs/downloads","issues_url":"https://api.github.com/repos/tomaka/glfw-rs/issues{/number}","pulls_url":"https://api.github.com/repos/tomaka/glfw-rs/pulls{/number}","milestones_url":"https://api.github.com/repos/tomaka/glfw-rs/milestones{/number}","notifications_url":"https://api.github.com/repos/tomaka/glfw-rs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tomaka/glfw-rs/labels{/name}","releases_url":"https://api.github.com/repos/tomaka/glfw-rs/releases{/id}","created_at":"2014-10-03T11:50:02Z","updated_at":"2014-10-03T11:56:00Z","pushed_at":"2014-10-03T12:01:47Z","git_url":"git://github.com/tomaka/glfw-rs.git","ssh_url":"git@github.com:tomaka/glfw-rs.git","clone_url":"https://github.com/tomaka/glfw-rs.git","svn_url":"https://github.com/tomaka/glfw-rs","homepage":"","size":1109,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bjz:master","ref":"master","sha":"16f8b1c725e153bc4ff11e0a210e8896ceee4710","user":{"login":"bjz","id":695077,"avatar_url":"https://avatars.githubusercontent.com/u/695077?v=2","gravatar_id":"","url":"https://api.github.com/users/bjz","html_url":"https://github.com/bjz","followers_url":"https://api.github.com/users/bjz/followers","following_url":"https://api.github.com/users/bjz/following{/other_user}","gists_url":"https://api.github.com/users/bjz/gists{/gist_id}","starred_url":"https://api.github.com/users/bjz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjz/subscriptions","organizations_url":"https://api.github.com/users/bjz/orgs","repos_url":"https://api.github.com/users/bjz/repos","events_url":"https://api.github.com/users/bjz/events{/privacy}","received_events_url":"https://api.github.com/users/bjz/received_events","type":"User","site_admin":false},"repo":{"id":5817736,"name":"glfw-rs","full_name":"bjz/glfw-rs","owner":{"login":"bjz","id":695077,"avatar_url":"https://avatars.githubusercontent.com/u/695077?v=2","gravatar_id":"","url":"https://api.github.com/users/bjz","html_url":"https://github.com/bjz","followers_url":"https://api.github.com/users/bjz/followers","following_url":"https://api.github.com/users/bjz/following{/other_user}","gists_url":"https://api.github.com/users/bjz/gists{/gist_id}","starred_url":"https://api.github.com/users/bjz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjz/subscriptions","organizations_url":"https://api.github.com/users/bjz/orgs","repos_url":"https://api.github.com/users/bjz/repos","events_url":"https://api.github.com/users/bjz/events{/privacy}","received_events_url":"https://api.github.com/users/bjz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bjz/glfw-rs","description":"GLFW3 bindings and idiomatic wrapper for Rust.","fork":false,"url":"https://api.github.com/repos/bjz/glfw-rs","forks_url":"https://api.github.com/repos/bjz/glfw-rs/forks","keys_url":"https://api.github.com/repos/bjz/glfw-rs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bjz/glfw-rs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bjz/glfw-rs/teams","hooks_url":"https://api.github.com/repos/bjz/glfw-rs/hooks","issue_events_url":"https://api.github.com/repos/bjz/glfw-rs/issues/events{/number}","events_url":"https://api.github.com/repos/bjz/glfw-rs/events","assignees_url":"https://api.github.com/repos/bjz/glfw-rs/assignees{/user}","branches_url":"https://api.github.com/repos/bjz/glfw-rs/branches{/branch}","tags_url":"https://api.github.com/repos/bjz/glfw-rs/tags","blobs_url":"https://api.github.com/repos/bjz/glfw-rs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bjz/glfw-rs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bjz/glfw-rs/git/refs{/sha}","trees_url":"https://api.github.com/repos/bjz/glfw-rs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bjz/glfw-rs/statuses/{sha}","languages_url":"https://api.github.com/repos/bjz/glfw-rs/languages","stargazers_url":"https://api.github.com/repos/bjz/glfw-rs/stargazers","contributors_url":"https://api.github.com/repos/bjz/glfw-rs/contributors","subscribers_url":"https://api.github.com/repos/bjz/glfw-rs/subscribers","subscription_url":"https://api.github.com/repos/bjz/glfw-rs/subscription","commits_url":"https://api.github.com/repos/bjz/glfw-rs/commits{/sha}","git_commits_url":"https://api.github.com/repos/bjz/glfw-rs/git/commits{/sha}","comments_url":"https://api.github.com/repos/bjz/glfw-rs/comments{/number}","issue_comment_url":"https://api.github.com/repos/bjz/glfw-rs/issues/comments/{number}","contents_url":"https://api.github.com/repos/bjz/glfw-rs/contents/{+path}","compare_url":"https://api.github.com/repos/bjz/glfw-rs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bjz/glfw-rs/merges","archive_url":"https://api.github.com/repos/bjz/glfw-rs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bjz/glfw-rs/downloads","issues_url":"https://api.github.com/repos/bjz/glfw-rs/issues{/number}","pulls_url":"https://api.github.com/repos/bjz/glfw-rs/pulls{/number}","milestones_url":"https://api.github.com/repos/bjz/glfw-rs/milestones{/number}","notifications_url":"https://api.github.com/repos/bjz/glfw-rs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bjz/glfw-rs/labels{/name}","releases_url":"https://api.github.com/repos/bjz/glfw-rs/releases{/id}","created_at":"2012-09-15T05:09:59Z","updated_at":"2014-10-04T23:16:40Z","pushed_at":"2014-10-03T06:45:27Z","git_url":"git://github.com/bjz/glfw-rs.git","ssh_url":"git@github.com:bjz/glfw-rs.git","clone_url":"https://github.com/bjz/glfw-rs.git","svn_url":"https://github.com/bjz/glfw-rs","homepage":"","size":5252,"stargazers_count":138,"watchers_count":138,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":64,"mirror_url":null,"open_issues_count":10,"forks":64,"open_issues":10,"watchers":138,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bjz/glfw-rs/pulls/231"},"html":{"href":"https://github.com/bjz/glfw-rs/pull/231"},"issue":{"href":"https://api.github.com/repos/bjz/glfw-rs/issues/231"},"comments":{"href":"https://api.github.com/repos/bjz/glfw-rs/issues/231/comments"},"review_comments":{"href":"https://api.github.com/repos/bjz/glfw-rs/pulls/231/comments"},"review_comment":{"href":"https://api.github.com/repos/bjz/glfw-rs/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/bjz/glfw-rs/pulls/231/commits"},"statuses":{"href":"https://api.github.com/repos/bjz/glfw-rs/statuses/b62babe8f799bdce8cf8def12f50c8f3a8959581"}}}}