GitHub PullRequestReviewCommentEvent at 2014-07-10 21:01:15
Repository: rippled
Actor: scottschurr
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/ripple/rippled/pulls/comments/14793055","id":14793055,"diff_hunk":"@@ -261,7 +261,7 @@ bool SHAMapTreeNode::updateHash ()\n             s.add32 (HashPrefix::innerNode);\n \n             for (int i = 0; i < 16; ++i)\n-                s.add256 (mHashes[i]);\n+                s.add (mHashes[i]);","path":"src/ripple/module/app/shamap/SHAMapTreeNode.cpp","position":68,"original_position":68,"commit_id":"ed3224929a099548e5b7b1b7831f2c13f781691e","original_commit_id":"ed3224929a099548e5b7b1b7831f2c13f781691e","user":{"login":"scottschurr","id":7840379,"avatar_url":"https://avatars.githubusercontent.com/u/7840379?","gravatar_id":"560ff346d6cfe36314a7468a1672111f","url":"https://api.github.com/users/scottschurr","html_url":"https://github.com/scottschurr","followers_url":"https://api.github.com/users/scottschurr/followers","following_url":"https://api.github.com/users/scottschurr/following{/other_user}","gists_url":"https://api.github.com/users/scottschurr/gists{/gist_id}","starred_url":"https://api.github.com/users/scottschurr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scottschurr/subscriptions","organizations_url":"https://api.github.com/users/scottschurr/orgs","repos_url":"https://api.github.com/users/scottschurr/repos","events_url":"https://api.github.com/users/scottschurr/events{/privacy}","received_events_url":"https://api.github.com/users/scottschurr/received_events","type":"User","site_admin":false},"body":"Very minor quibble.  I assume the <256> is not necessary here because its inferred by the size of an mHashes element.  Still, everywhere else in the file we use explicit chevrons.  My inclination would be to write s.add<256>.","created_at":"2014-07-10T21:01:15Z","updated_at":"2014-07-10T21:01:15Z","html_url":"https://github.com/ripple/rippled/pull/444#discussion_r14793055","pull_request_url":"https://api.github.com/repos/ripple/rippled/pulls/444","_links":{"self":{"href":"https://api.github.com/repos/ripple/rippled/pulls/comments/14793055"},"html":{"href":"https://github.com/ripple/rippled/pull/444#discussion_r14793055"},"pull_request":{"href":"https://api.github.com/repos/ripple/rippled/pulls/444"}}},"pull_request":{"url":"https://api.github.com/repos/ripple/rippled/pulls/444","id":18243127,"html_url":"https://github.com/ripple/rippled/pull/444","diff_url":"https://github.com/ripple/rippled/pull/444.diff","patch_url":"https://github.com/ripple/rippled/pull/444.patch","issue_url":"https://api.github.com/repos/ripple/rippled/issues/444","number":444,"state":"open","title":" Remove duplication in STHash by using generics.","user":{"login":"rec","id":253362,"avatar_url":"https://avatars.githubusercontent.com/u/253362?","gravatar_id":"753ef975f85896eabdb64d9aa6ad4cbe","url":"https://api.github.com/users/rec","html_url":"https://github.com/rec","followers_url":"https://api.github.com/users/rec/followers","following_url":"https://api.github.com/users/rec/following{/other_user}","gists_url":"https://api.github.com/users/rec/gists{/gist_id}","starred_url":"https://api.github.com/users/rec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rec/subscriptions","organizations_url":"https://api.github.com/users/rec/orgs","repos_url":"https://api.github.com/users/rec/repos","events_url":"https://api.github.com/users/rec/events{/privacy}","received_events_url":"https://api.github.com/users/rec/received_events","type":"User","site_admin":false},"body":"* STHash256, STHash160, STHash128 replaced by STHash<256>, STHash<160>, STHash<128>. \r\n* STUInt8, STUInt16, STUInt32, STUInt64 are now instances of the same generic class.\r\n* New generic accessors for Serializer.\r\n* Net hundreds of near-duplicate lines of code deleted.","created_at":"2014-07-10T20:07:25Z","updated_at":"2014-07-10T21:01:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"78f0828d73aa93e3feebc45f31c4fa43c0257dcb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ripple/rippled/pulls/444/commits","review_comments_url":"https://api.github.com/repos/ripple/rippled/pulls/444/comments","review_comment_url":"https://api.github.com/repos/ripple/rippled/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ripple/rippled/issues/444/comments","statuses_url":"https://api.github.com/repos/ripple/rippled/statuses/ed3224929a099548e5b7b1b7831f2c13f781691e","head":{"label":"rec:STHash","ref":"STHash","sha":"ed3224929a099548e5b7b1b7831f2c13f781691e","user":{"login":"rec","id":253362,"avatar_url":"https://avatars.githubusercontent.com/u/253362?","gravatar_id":"753ef975f85896eabdb64d9aa6ad4cbe","url":"https://api.github.com/users/rec","html_url":"https://github.com/rec","followers_url":"https://api.github.com/users/rec/followers","following_url":"https://api.github.com/users/rec/following{/other_user}","gists_url":"https://api.github.com/users/rec/gists{/gist_id}","starred_url":"https://api.github.com/users/rec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rec/subscriptions","organizations_url":"https://api.github.com/users/rec/orgs","repos_url":"https://api.github.com/users/rec/repos","events_url":"https://api.github.com/users/rec/events{/privacy}","received_events_url":"https://api.github.com/users/rec/received_events","type":"User","site_admin":false},"repo":{"id":18302070,"name":"rippled","full_name":"rec/rippled","owner":{"login":"rec","id":253362,"avatar_url":"https://avatars.githubusercontent.com/u/253362?","gravatar_id":"753ef975f85896eabdb64d9aa6ad4cbe","url":"https://api.github.com/users/rec","html_url":"https://github.com/rec","followers_url":"https://api.github.com/users/rec/followers","following_url":"https://api.github.com/users/rec/following{/other_user}","gists_url":"https://api.github.com/users/rec/gists{/gist_id}","starred_url":"https://api.github.com/users/rec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rec/subscriptions","organizations_url":"https://api.github.com/users/rec/orgs","repos_url":"https://api.github.com/users/rec/repos","events_url":"https://api.github.com/users/rec/events{/privacy}","received_events_url":"https://api.github.com/users/rec/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rec/rippled","description":"Ripple peer-to-peer network daemon","fork":true,"url":"https://api.github.com/repos/rec/rippled","forks_url":"https://api.github.com/repos/rec/rippled/forks","keys_url":"https://api.github.com/repos/rec/rippled/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rec/rippled/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rec/rippled/teams","hooks_url":"https://api.github.com/repos/rec/rippled/hooks","issue_events_url":"https://api.github.com/repos/rec/rippled/issues/events{/number}","events_url":"https://api.github.com/repos/rec/rippled/events","assignees_url":"https://api.github.com/repos/rec/rippled/assignees{/user}","branches_url":"https://api.github.com/repos/rec/rippled/branches{/branch}","tags_url":"https://api.github.com/repos/rec/rippled/tags","blobs_url":"https://api.github.com/repos/rec/rippled/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rec/rippled/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rec/rippled/git/refs{/sha}","trees_url":"https://api.github.com/repos/rec/rippled/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rec/rippled/statuses/{sha}","languages_url":"https://api.github.com/repos/rec/rippled/languages","stargazers_url":"https://api.github.com/repos/rec/rippled/stargazers","contributors_url":"https://api.github.com/repos/rec/rippled/contributors","subscribers_url":"https://api.github.com/repos/rec/rippled/subscribers","subscription_url":"https://api.github.com/repos/rec/rippled/subscription","commits_url":"https://api.github.com/repos/rec/rippled/commits{/sha}","git_commits_url":"https://api.github.com/repos/rec/rippled/git/commits{/sha}","comments_url":"https://api.github.com/repos/rec/rippled/comments{/number}","issue_comment_url":"https://api.github.com/repos/rec/rippled/issues/comments/{number}","contents_url":"https://api.github.com/repos/rec/rippled/contents/{+path}","compare_url":"https://api.github.com/repos/rec/rippled/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rec/rippled/merges","archive_url":"https://api.github.com/repos/rec/rippled/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rec/rippled/downloads","issues_url":"https://api.github.com/repos/rec/rippled/issues{/number}","pulls_url":"https://api.github.com/repos/rec/rippled/pulls{/number}","milestones_url":"https://api.github.com/repos/rec/rippled/milestones{/number}","notifications_url":"https://api.github.com/repos/rec/rippled/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rec/rippled/labels{/name}","releases_url":"https://api.github.com/repos/rec/rippled/releases{/id}","created_at":"2014-03-31T17:41:21Z","updated_at":"2014-07-07T18:31:42Z","pushed_at":"2014-07-10T20:20:53Z","git_url":"git://github.com/rec/rippled.git","ssh_url":"git@github.com:rec/rippled.git","clone_url":"https://github.com/rec/rippled.git","svn_url":"https://github.com/rec/rippled","homepage":"https://ripple.com","size":40909,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"develop"}},"base":{"label":"ripple:develop","ref":"develop","sha":"10150a73526587d90d1f0659ca84778b633d7f8d","user":{"login":"ripple","id":3165523,"avatar_url":"https://avatars.githubusercontent.com/u/3165523?","gravatar_id":"f6d67405ba8fc12a2d73e2131501a571","url":"https://api.github.com/users/ripple","html_url":"https://github.com/ripple","followers_url":"https://api.github.com/users/ripple/followers","following_url":"https://api.github.com/users/ripple/following{/other_user}","gists_url":"https://api.github.com/users/ripple/gists{/gist_id}","starred_url":"https://api.github.com/users/ripple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ripple/subscriptions","organizations_url":"https://api.github.com/users/ripple/orgs","repos_url":"https://api.github.com/users/ripple/repos","events_url":"https://api.github.com/users/ripple/events{/privacy}","received_events_url":"https://api.github.com/users/ripple/received_events","type":"Organization","site_admin":false},"repo":{"id":2724167,"name":"rippled","full_name":"ripple/rippled","owner":{"login":"ripple","id":3165523,"avatar_url":"https://avatars.githubusercontent.com/u/3165523?","gravatar_id":"f6d67405ba8fc12a2d73e2131501a571","url":"https://api.github.com/users/ripple","html_url":"https://github.com/ripple","followers_url":"https://api.github.com/users/ripple/followers","following_url":"https://api.github.com/users/ripple/following{/other_user}","gists_url":"https://api.github.com/users/ripple/gists{/gist_id}","starred_url":"https://api.github.com/users/ripple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ripple/subscriptions","organizations_url":"https://api.github.com/users/ripple/orgs","repos_url":"https://api.github.com/users/ripple/repos","events_url":"https://api.github.com/users/ripple/events{/privacy}","received_events_url":"https://api.github.com/users/ripple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ripple/rippled","description":"Ripple peer-to-peer network daemon","fork":false,"url":"https://api.github.com/repos/ripple/rippled","forks_url":"https://api.github.com/repos/ripple/rippled/forks","keys_url":"https://api.github.com/repos/ripple/rippled/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ripple/rippled/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ripple/rippled/teams","hooks_url":"https://api.github.com/repos/ripple/rippled/hooks","issue_events_url":"https://api.github.com/repos/ripple/rippled/issues/events{/number}","events_url":"https://api.github.com/repos/ripple/rippled/events","assignees_url":"https://api.github.com/repos/ripple/rippled/assignees{/user}","branches_url":"https://api.github.com/repos/ripple/rippled/branches{/branch}","tags_url":"https://api.github.com/repos/ripple/rippled/tags","blobs_url":"https://api.github.com/repos/ripple/rippled/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ripple/rippled/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ripple/rippled/git/refs{/sha}","trees_url":"https://api.github.com/repos/ripple/rippled/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ripple/rippled/statuses/{sha}","languages_url":"https://api.github.com/repos/ripple/rippled/languages","stargazers_url":"https://api.github.com/repos/ripple/rippled/stargazers","contributors_url":"https://api.github.com/repos/ripple/rippled/contributors","subscribers_url":"https://api.github.com/repos/ripple/rippled/subscribers","subscription_url":"https://api.github.com/repos/ripple/rippled/subscription","commits_url":"https://api.github.com/repos/ripple/rippled/commits{/sha}","git_commits_url":"https://api.github.com/repos/ripple/rippled/git/commits{/sha}","comments_url":"https://api.github.com/repos/ripple/rippled/comments{/number}","issue_comment_url":"https://api.github.com/repos/ripple/rippled/issues/comments/{number}","contents_url":"https://api.github.com/repos/ripple/rippled/contents/{+path}","compare_url":"https://api.github.com/repos/ripple/rippled/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ripple/rippled/merges","archive_url":"https://api.github.com/repos/ripple/rippled/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ripple/rippled/downloads","issues_url":"https://api.github.com/repos/ripple/rippled/issues{/number}","pulls_url":"https://api.github.com/repos/ripple/rippled/pulls{/number}","milestones_url":"https://api.github.com/repos/ripple/rippled/milestones{/number}","notifications_url":"https://api.github.com/repos/ripple/rippled/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ripple/rippled/labels{/name}","releases_url":"https://api.github.com/repos/ripple/rippled/releases{/id}","created_at":"2011-11-07T04:40:15Z","updated_at":"2014-07-05T09:57:05Z","pushed_at":"2014-07-08T23:38:11Z","git_url":"git://github.com/ripple/rippled.git","ssh_url":"git@github.com:ripple/rippled.git","clone_url":"https://github.com/ripple/rippled.git","svn_url":"https://github.com/ripple/rippled","homepage":"https://ripple.com","size":59489,"stargazers_count":838,"watchers_count":838,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":200,"mirror_url":null,"open_issues_count":129,"forks":200,"open_issues":129,"watchers":838,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ripple/rippled/pulls/444"},"html":{"href":"https://github.com/ripple/rippled/pull/444"},"issue":{"href":"https://api.github.com/repos/ripple/rippled/issues/444"},"comments":{"href":"https://api.github.com/repos/ripple/rippled/issues/444/comments"},"review_comments":{"href":"https://api.github.com/repos/ripple/rippled/pulls/444/comments"},"review_comment":{"href":"https://api.github.com/repos/ripple/rippled/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ripple/rippled/pulls/444/commits"},"statuses":{"href":"https://api.github.com/repos/ripple/rippled/statuses/ed3224929a099548e5b7b1b7831f2c13f781691e"}}}}