GitHub PullRequestReviewCommentEvent at 2014-12-02 21:05:12
Repository: ant-ivy
Actor: dturner-tw
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/twitter-forks/ant-ivy/pulls/comments/21191193","id":21191193,"diff_hunk":"@@ -50,8 +50,10 @@ private HttpStatus() {\n         }\n     }\n \n+    private int defaultTimeout = 0;","path":"src/java/org/apache/ivy/util/url/BasicURLHandler.java","position":4,"original_position":4,"commit_id":"780cbbc226422fadc9965fc6b45a4d1a3a69dad7","original_commit_id":"780cbbc226422fadc9965fc6b45a4d1a3a69dad7","user":{"login":"dturner-tw","id":6484012,"avatar_url":"https://avatars.githubusercontent.com/u/6484012?v=3","gravatar_id":"","url":"https://api.github.com/users/dturner-tw","html_url":"https://github.com/dturner-tw","followers_url":"https://api.github.com/users/dturner-tw/followers","following_url":"https://api.github.com/users/dturner-tw/following{/other_user}","gists_url":"https://api.github.com/users/dturner-tw/gists{/gist_id}","starred_url":"https://api.github.com/users/dturner-tw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dturner-tw/subscriptions","organizations_url":"https://api.github.com/users/dturner-tw/orgs","repos_url":"https://api.github.com/users/dturner-tw/repos","events_url":"https://api.github.com/users/dturner-tw/events{/privacy}","received_events_url":"https://api.github.com/users/dturner-tw/received_events","type":"User","site_admin":false},"body":"It's a default since we already have a param called timeout in getURLInfo(URL url, int timeout).  We don't want to override that.  We can't declare this as final because it gets set from a config file.\r\n","created_at":"2014-12-02T21:05:12Z","updated_at":"2014-12-02T21:05:12Z","html_url":"https://github.com/twitter-forks/ant-ivy/pull/1#discussion_r21191193","pull_request_url":"https://api.github.com/repos/twitter-forks/ant-ivy/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/twitter-forks/ant-ivy/pulls/comments/21191193"},"html":{"href":"https://github.com/twitter-forks/ant-ivy/pull/1#discussion_r21191193"},"pull_request":{"href":"https://api.github.com/repos/twitter-forks/ant-ivy/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/twitter-forks/ant-ivy/pulls/1","id":25366591,"html_url":"https://github.com/twitter-forks/ant-ivy/pull/1","diff_url":"https://github.com/twitter-forks/ant-ivy/pull/1.diff","patch_url":"https://github.com/twitter-forks/ant-ivy/pull/1.patch","issue_url":"https://api.github.com/repos/twitter-forks/ant-ivy/issues/1","number":1,"state":"open","locked":false,"title":"Add timeout support for HTTP requests","user":{"login":"dturner-tw","id":6484012,"avatar_url":"https://avatars.githubusercontent.com/u/6484012?v=3","gravatar_id":"","url":"https://api.github.com/users/dturner-tw","html_url":"https://github.com/dturner-tw","followers_url":"https://api.github.com/users/dturner-tw/followers","following_url":"https://api.github.com/users/dturner-tw/following{/other_user}","gists_url":"https://api.github.com/users/dturner-tw/gists{/gist_id}","starred_url":"https://api.github.com/users/dturner-tw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dturner-tw/subscriptions","organizations_url":"https://api.github.com/users/dturner-tw/orgs","repos_url":"https://api.github.com/users/dturner-tw/repos","events_url":"https://api.github.com/users/dturner-tw/events{/privacy}","received_events_url":"https://api.github.com/users/dturner-tw/received_events","type":"User","site_admin":false},"body":"Adds a new settings parameter, defaultTimeout, an integer number of\r\nmilliseconds.  This timeout is used for both connect, and during the\r\ndownload.  So if, during the download, more than defaultTimeout\r\nmilliseconds have passed between packets, the download will\r\nfail. Fixes IVY-735.\r\n\r\nSigned-off-by: David Turner <dturner@twitter.com>","created_at":"2014-12-02T19:17:03Z","updated_at":"2014-12-02T21:05:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c42ddf8d3b7e2ac43bc6060b0844652e8e6c5f01","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/twitter-forks/ant-ivy/pulls/1/commits","review_comments_url":"https://api.github.com/repos/twitter-forks/ant-ivy/pulls/1/comments","review_comment_url":"https://api.github.com/repos/twitter-forks/ant-ivy/pulls/comments/{number}","comments_url":"https://api.github.com/repos/twitter-forks/ant-ivy/issues/1/comments","statuses_url":"https://api.github.com/repos/twitter-forks/ant-ivy/statuses/780cbbc226422fadc9965fc6b45a4d1a3a69dad7","head":{"label":"dturner-tw:dturner/timeout","ref":"dturner/timeout","sha":"780cbbc226422fadc9965fc6b45a4d1a3a69dad7","user":{"login":"dturner-tw","id":6484012,"avatar_url":"https://avatars.githubusercontent.com/u/6484012?v=3","gravatar_id":"","url":"https://api.github.com/users/dturner-tw","html_url":"https://github.com/dturner-tw","followers_url":"https://api.github.com/users/dturner-tw/followers","following_url":"https://api.github.com/users/dturner-tw/following{/other_user}","gists_url":"https://api.github.com/users/dturner-tw/gists{/gist_id}","starred_url":"https://api.github.com/users/dturner-tw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dturner-tw/subscriptions","organizations_url":"https://api.github.com/users/dturner-tw/orgs","repos_url":"https://api.github.com/users/dturner-tw/repos","events_url":"https://api.github.com/users/dturner-tw/events{/privacy}","received_events_url":"https://api.github.com/users/dturner-tw/received_events","type":"User","site_admin":false},"repo":{"id":27448550,"name":"ant-ivy","full_name":"dturner-tw/ant-ivy","owner":{"login":"dturner-tw","id":6484012,"avatar_url":"https://avatars.githubusercontent.com/u/6484012?v=3","gravatar_id":"","url":"https://api.github.com/users/dturner-tw","html_url":"https://github.com/dturner-tw","followers_url":"https://api.github.com/users/dturner-tw/followers","following_url":"https://api.github.com/users/dturner-tw/following{/other_user}","gists_url":"https://api.github.com/users/dturner-tw/gists{/gist_id}","starred_url":"https://api.github.com/users/dturner-tw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dturner-tw/subscriptions","organizations_url":"https://api.github.com/users/dturner-tw/orgs","repos_url":"https://api.github.com/users/dturner-tw/repos","events_url":"https://api.github.com/users/dturner-tw/events{/privacy}","received_events_url":"https://api.github.com/users/dturner-tw/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dturner-tw/ant-ivy","description":"Mirror of Apache Ant Ivy","fork":true,"url":"https://api.github.com/repos/dturner-tw/ant-ivy","forks_url":"https://api.github.com/repos/dturner-tw/ant-ivy/forks","keys_url":"https://api.github.com/repos/dturner-tw/ant-ivy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dturner-tw/ant-ivy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dturner-tw/ant-ivy/teams","hooks_url":"https://api.github.com/repos/dturner-tw/ant-ivy/hooks","issue_events_url":"https://api.github.com/repos/dturner-tw/ant-ivy/issues/events{/number}","events_url":"https://api.github.com/repos/dturner-tw/ant-ivy/events","assignees_url":"https://api.github.com/repos/dturner-tw/ant-ivy/assignees{/user}","branches_url":"https://api.github.com/repos/dturner-tw/ant-ivy/branches{/branch}","tags_url":"https://api.github.com/repos/dturner-tw/ant-ivy/tags","blobs_url":"https://api.github.com/repos/dturner-tw/ant-ivy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dturner-tw/ant-ivy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dturner-tw/ant-ivy/git/refs{/sha}","trees_url":"https://api.github.com/repos/dturner-tw/ant-ivy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dturner-tw/ant-ivy/statuses/{sha}","languages_url":"https://api.github.com/repos/dturner-tw/ant-ivy/languages","stargazers_url":"https://api.github.com/repos/dturner-tw/ant-ivy/stargazers","contributors_url":"https://api.github.com/repos/dturner-tw/ant-ivy/contributors","subscribers_url":"https://api.github.com/repos/dturner-tw/ant-ivy/subscribers","subscription_url":"https://api.github.com/repos/dturner-tw/ant-ivy/subscription","commits_url":"https://api.github.com/repos/dturner-tw/ant-ivy/commits{/sha}","git_commits_url":"https://api.github.com/repos/dturner-tw/ant-ivy/git/commits{/sha}","comments_url":"https://api.github.com/repos/dturner-tw/ant-ivy/comments{/number}","issue_comment_url":"https://api.github.com/repos/dturner-tw/ant-ivy/issues/comments/{number}","contents_url":"https://api.github.com/repos/dturner-tw/ant-ivy/contents/{+path}","compare_url":"https://api.github.com/repos/dturner-tw/ant-ivy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dturner-tw/ant-ivy/merges","archive_url":"https://api.github.com/repos/dturner-tw/ant-ivy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dturner-tw/ant-ivy/downloads","issues_url":"https://api.github.com/repos/dturner-tw/ant-ivy/issues{/number}","pulls_url":"https://api.github.com/repos/dturner-tw/ant-ivy/pulls{/number}","milestones_url":"https://api.github.com/repos/dturner-tw/ant-ivy/milestones{/number}","notifications_url":"https://api.github.com/repos/dturner-tw/ant-ivy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dturner-tw/ant-ivy/labels{/name}","releases_url":"https://api.github.com/repos/dturner-tw/ant-ivy/releases{/id}","created_at":"2014-12-02T19:06:48Z","updated_at":"2014-12-02T19:06:49Z","pushed_at":"2014-12-02T19:16:42Z","git_url":"git://github.com/dturner-tw/ant-ivy.git","ssh_url":"git@github.com:dturner-tw/ant-ivy.git","clone_url":"https://github.com/dturner-tw/ant-ivy.git","svn_url":"https://github.com/dturner-tw/ant-ivy","homepage":null,"size":8831,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"1.4.x"}},"base":{"label":"twitter-forks:master","ref":"master","sha":"4d04df25bb6d700436249df76f33e4378484ecf6","user":{"login":"twitter-forks","id":5349157,"avatar_url":"https://avatars.githubusercontent.com/u/5349157?v=3","gravatar_id":"","url":"https://api.github.com/users/twitter-forks","html_url":"https://github.com/twitter-forks","followers_url":"https://api.github.com/users/twitter-forks/followers","following_url":"https://api.github.com/users/twitter-forks/following{/other_user}","gists_url":"https://api.github.com/users/twitter-forks/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter-forks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter-forks/subscriptions","organizations_url":"https://api.github.com/users/twitter-forks/orgs","repos_url":"https://api.github.com/users/twitter-forks/repos","events_url":"https://api.github.com/users/twitter-forks/events{/privacy}","received_events_url":"https://api.github.com/users/twitter-forks/received_events","type":"Organization","site_admin":false},"repo":{"id":27164050,"name":"ant-ivy","full_name":"twitter-forks/ant-ivy","owner":{"login":"twitter-forks","id":5349157,"avatar_url":"https://avatars.githubusercontent.com/u/5349157?v=3","gravatar_id":"","url":"https://api.github.com/users/twitter-forks","html_url":"https://github.com/twitter-forks","followers_url":"https://api.github.com/users/twitter-forks/followers","following_url":"https://api.github.com/users/twitter-forks/following{/other_user}","gists_url":"https://api.github.com/users/twitter-forks/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter-forks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter-forks/subscriptions","organizations_url":"https://api.github.com/users/twitter-forks/orgs","repos_url":"https://api.github.com/users/twitter-forks/repos","events_url":"https://api.github.com/users/twitter-forks/events{/privacy}","received_events_url":"https://api.github.com/users/twitter-forks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/twitter-forks/ant-ivy","description":"Mirror of Apache Ant Ivy","fork":true,"url":"https://api.github.com/repos/twitter-forks/ant-ivy","forks_url":"https://api.github.com/repos/twitter-forks/ant-ivy/forks","keys_url":"https://api.github.com/repos/twitter-forks/ant-ivy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twitter-forks/ant-ivy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twitter-forks/ant-ivy/teams","hooks_url":"https://api.github.com/repos/twitter-forks/ant-ivy/hooks","issue_events_url":"https://api.github.com/repos/twitter-forks/ant-ivy/issues/events{/number}","events_url":"https://api.github.com/repos/twitter-forks/ant-ivy/events","assignees_url":"https://api.github.com/repos/twitter-forks/ant-ivy/assignees{/user}","branches_url":"https://api.github.com/repos/twitter-forks/ant-ivy/branches{/branch}","tags_url":"https://api.github.com/repos/twitter-forks/ant-ivy/tags","blobs_url":"https://api.github.com/repos/twitter-forks/ant-ivy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twitter-forks/ant-ivy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twitter-forks/ant-ivy/git/refs{/sha}","trees_url":"https://api.github.com/repos/twitter-forks/ant-ivy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twitter-forks/ant-ivy/statuses/{sha}","languages_url":"https://api.github.com/repos/twitter-forks/ant-ivy/languages","stargazers_url":"https://api.github.com/repos/twitter-forks/ant-ivy/stargazers","contributors_url":"https://api.github.com/repos/twitter-forks/ant-ivy/contributors","subscribers_url":"https://api.github.com/repos/twitter-forks/ant-ivy/subscribers","subscription_url":"https://api.github.com/repos/twitter-forks/ant-ivy/subscription","commits_url":"https://api.github.com/repos/twitter-forks/ant-ivy/commits{/sha}","git_commits_url":"https://api.github.com/repos/twitter-forks/ant-ivy/git/commits{/sha}","comments_url":"https://api.github.com/repos/twitter-forks/ant-ivy/comments{/number}","issue_comment_url":"https://api.github.com/repos/twitter-forks/ant-ivy/issues/comments/{number}","contents_url":"https://api.github.com/repos/twitter-forks/ant-ivy/contents/{+path}","compare_url":"https://api.github.com/repos/twitter-forks/ant-ivy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twitter-forks/ant-ivy/merges","archive_url":"https://api.github.com/repos/twitter-forks/ant-ivy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twitter-forks/ant-ivy/downloads","issues_url":"https://api.github.com/repos/twitter-forks/ant-ivy/issues{/number}","pulls_url":"https://api.github.com/repos/twitter-forks/ant-ivy/pulls{/number}","milestones_url":"https://api.github.com/repos/twitter-forks/ant-ivy/milestones{/number}","notifications_url":"https://api.github.com/repos/twitter-forks/ant-ivy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twitter-forks/ant-ivy/labels{/name}","releases_url":"https://api.github.com/repos/twitter-forks/ant-ivy/releases{/id}","created_at":"2014-11-26T07:04:33Z","updated_at":"2014-11-26T07:04:34Z","pushed_at":"2014-11-22T11:07:04Z","git_url":"git://github.com/twitter-forks/ant-ivy.git","ssh_url":"git@github.com:twitter-forks/ant-ivy.git","clone_url":"https://github.com/twitter-forks/ant-ivy.git","svn_url":"https://github.com/twitter-forks/ant-ivy","homepage":null,"size":8831,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"1.4.x"}},"_links":{"self":{"href":"https://api.github.com/repos/twitter-forks/ant-ivy/pulls/1"},"html":{"href":"https://github.com/twitter-forks/ant-ivy/pull/1"},"issue":{"href":"https://api.github.com/repos/twitter-forks/ant-ivy/issues/1"},"comments":{"href":"https://api.github.com/repos/twitter-forks/ant-ivy/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/twitter-forks/ant-ivy/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/twitter-forks/ant-ivy/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/twitter-forks/ant-ivy/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/twitter-forks/ant-ivy/statuses/780cbbc226422fadc9965fc6b45a4d1a3a69dad7"}}}}