GitHub PullRequestReviewCommentEvent at 2014-05-08 22:45:25
Repository: django
Actor: shaib
Payload: {"comment":{"url":"https://api.github.com/repos/django/django/pulls/comments/12456906","id":12456906,"diff_hunk":"@@ -156,7 +176,7 @@ def test_special_column_name_introspection(self):\n         out = StringIO()\n         call_command('inspectdb', stdout=out)\n         output = out.getvalue()\n-        base_name = 'Field' if connection.vendor != 'oracle' else 'field'\n+        base_name = 'field' if connection.features.lowercases_column_names else 'Field'","path":"tests/inspectdb/tests.py","position":141,"original_position":141,"commit_id":"99d9fa329a9da87933ac9eff6c5f9c7514bc9f9a","original_commit_id":"99d9fa329a9da87933ac9eff6c5f9c7514bc9f9a","user":{"login":"shaib","id":129187,"avatar_url":"https://avatars.githubusercontent.com/u/129187?","gravatar_id":"fcf248b0e7f1ededc6f83477ec76a2b6","url":"https://api.github.com/users/shaib","html_url":"https://github.com/shaib","followers_url":"https://api.github.com/users/shaib/followers","following_url":"https://api.github.com/users/shaib/following{/other_user}","gists_url":"https://api.github.com/users/shaib/gists{/gist_id}","starred_url":"https://api.github.com/users/shaib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shaib/subscriptions","organizations_url":"https://api.github.com/users/shaib/orgs","repos_url":"https://api.github.com/users/shaib/repos","events_url":"https://api.github.com/users/shaib/events{/privacy}","received_events_url":"https://api.github.com/users/shaib/received_events","type":"User","site_admin":false},"body":"Consider \r\n```python\r\nbase_name = 'Field' if not connection.features.lowercases_column_names else 'field'\r\n```\r\nfor the general rule that in if expressions, the \"iftrue\" part should be the more common, reflecting the default.","created_at":"2014-05-08T22:45:25Z","updated_at":"2014-05-08T22:45:25Z","html_url":"https://github.com/django/django/pull/2640#discussion_r12456906","pull_request_url":"https://api.github.com/repos/django/django/pulls/2640","_links":{"self":{"href":"https://api.github.com/repos/django/django/pulls/comments/12456906"},"html":{"href":"https://github.com/django/django/pull/2640#discussion_r12456906"},"pull_request":{"href":"https://api.github.com/repos/django/django/pulls/2640"}}}}