GitHub PullRequestReviewCommentEvent at 2014-09-05 08:24:28
Repository: Joker
Actor: ThomasAy
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/Phonations/Joker/pulls/comments/17161412","id":17161412,"diff_hunk":"@@ -85,6 +87,12 @@ class JokerSettings : PhGenericSettings,\n \t// Midi settings:\n \tPH_SETTING_STRING2(setMidiTimeCodePortName, midiTimeCodePortName, \"Joker\")\n \n+\t// LTC settings :\n+\tPH_SETTING_BOOL(setLtcAutoDetectTimeCodeType, ltcAutoDetectTimeCodeType)\n+//\tPH_SETTING_STRING(setLtcInputDevice, ltcInputDevice)","path":"app/Joker/JokerSettings.h","position":24,"original_position":24,"commit_id":"0062b7e2ce4dcf13d63c7ac2ea3b682332b5790e","original_commit_id":"0062b7e2ce4dcf13d63c7ac2ea3b682332b5790e","user":{"login":"ThomasAy","id":4160526,"avatar_url":"https://avatars.githubusercontent.com/u/4160526?v=2","gravatar_id":"9644b7288228a438b61f0c23d336c9ea","url":"https://api.github.com/users/ThomasAy","html_url":"https://github.com/ThomasAy","followers_url":"https://api.github.com/users/ThomasAy/followers","following_url":"https://api.github.com/users/ThomasAy/following{/other_user}","gists_url":"https://api.github.com/users/ThomasAy/gists{/gist_id}","starred_url":"https://api.github.com/users/ThomasAy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThomasAy/subscriptions","organizations_url":"https://api.github.com/users/ThomasAy/orgs","repos_url":"https://api.github.com/users/ThomasAy/repos","events_url":"https://api.github.com/users/ThomasAy/events{/privacy}","received_events_url":"https://api.github.com/users/ThomasAy/received_events","type":"User","site_admin":false},"body":"See line 105, the same setting already exist... That was not the best thing to do (comment it) but I didn't know how to handle it in a good way.","created_at":"2014-09-05T08:24:28Z","updated_at":"2014-09-05T08:24:28Z","html_url":"https://github.com/Phonations/Joker/pull/250#discussion_r17161412","pull_request_url":"https://api.github.com/repos/Phonations/Joker/pulls/250","_links":{"self":{"href":"https://api.github.com/repos/Phonations/Joker/pulls/comments/17161412"},"html":{"href":"https://github.com/Phonations/Joker/pull/250#discussion_r17161412"},"pull_request":{"href":"https://api.github.com/repos/Phonations/Joker/pulls/250"}}},"pull_request":{"url":"https://api.github.com/repos/Phonations/Joker/pulls/250","id":20741515,"html_url":"https://github.com/Phonations/Joker/pull/250","diff_url":"https://github.com/Phonations/Joker/pull/250.diff","patch_url":"https://github.com/Phonations/Joker/pull/250.patch","issue_url":"https://api.github.com/repos/Phonations/Joker/issues/250","number":250,"state":"open","locked":false,"title":"Ta ltc detect fps","user":{"login":"ThomasAy","id":4160526,"avatar_url":"https://avatars.githubusercontent.com/u/4160526?v=2","gravatar_id":"9644b7288228a438b61f0c23d336c9ea","url":"https://api.github.com/users/ThomasAy","html_url":"https://github.com/ThomasAy","followers_url":"https://api.github.com/users/ThomasAy/followers","following_url":"https://api.github.com/users/ThomasAy/following{/other_user}","gists_url":"https://api.github.com/users/ThomasAy/gists{/gist_id}","starred_url":"https://api.github.com/users/ThomasAy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThomasAy/subscriptions","organizations_url":"https://api.github.com/users/ThomasAy/orgs","repos_url":"https://api.github.com/users/ThomasAy/repos","events_url":"https://api.github.com/users/ThomasAy/events{/privacy}","received_events_url":"https://api.github.com/users/ThomasAy/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-09-04T13:01:15Z","updated_at":"2014-09-05T08:24:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f6ab9013df17736f340e80b5b691b5e010bd9514","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Phonations/Joker/pulls/250/commits","review_comments_url":"https://api.github.com/repos/Phonations/Joker/pulls/250/comments","review_comment_url":"https://api.github.com/repos/Phonations/Joker/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Phonations/Joker/issues/250/comments","statuses_url":"https://api.github.com/repos/Phonations/Joker/statuses/0062b7e2ce4dcf13d63c7ac2ea3b682332b5790e","head":{"label":"Phonations:ta-LTC-detect-fps","ref":"ta-LTC-detect-fps","sha":"0062b7e2ce4dcf13d63c7ac2ea3b682332b5790e","user":{"login":"Phonations","id":4180112,"avatar_url":"https://avatars.githubusercontent.com/u/4180112?v=2","gravatar_id":"67e7eea729f5dac59544e6d989cb2b8a","url":"https://api.github.com/users/Phonations","html_url":"https://github.com/Phonations","followers_url":"https://api.github.com/users/Phonations/followers","following_url":"https://api.github.com/users/Phonations/following{/other_user}","gists_url":"https://api.github.com/users/Phonations/gists{/gist_id}","starred_url":"https://api.github.com/users/Phonations/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Phonations/subscriptions","organizations_url":"https://api.github.com/users/Phonations/orgs","repos_url":"https://api.github.com/users/Phonations/repos","events_url":"https://api.github.com/users/Phonations/events{/privacy}","received_events_url":"https://api.github.com/users/Phonations/received_events","type":"Organization","site_admin":false},"repo":{"id":9836733,"name":"Joker","full_name":"Phonations/Joker","owner":{"login":"Phonations","id":4180112,"avatar_url":"https://avatars.githubusercontent.com/u/4180112?v=2","gravatar_id":"67e7eea729f5dac59544e6d989cb2b8a","url":"https://api.github.com/users/Phonations","html_url":"https://github.com/Phonations","followers_url":"https://api.github.com/users/Phonations/followers","following_url":"https://api.github.com/users/Phonations/following{/other_user}","gists_url":"https://api.github.com/users/Phonations/gists{/gist_id}","starred_url":"https://api.github.com/users/Phonations/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Phonations/subscriptions","organizations_url":"https://api.github.com/users/Phonations/orgs","repos_url":"https://api.github.com/users/Phonations/repos","events_url":"https://api.github.com/users/Phonations/events{/privacy}","received_events_url":"https://api.github.com/users/Phonations/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Phonations/Joker","description":"Digital rythmo band system for dubbing and postsynchronisation purposes.","fork":false,"url":"https://api.github.com/repos/Phonations/Joker","forks_url":"https://api.github.com/repos/Phonations/Joker/forks","keys_url":"https://api.github.com/repos/Phonations/Joker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Phonations/Joker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Phonations/Joker/teams","hooks_url":"https://api.github.com/repos/Phonations/Joker/hooks","issue_events_url":"https://api.github.com/repos/Phonations/Joker/issues/events{/number}","events_url":"https://api.github.com/repos/Phonations/Joker/events","assignees_url":"https://api.github.com/repos/Phonations/Joker/assignees{/user}","branches_url":"https://api.github.com/repos/Phonations/Joker/branches{/branch}","tags_url":"https://api.github.com/repos/Phonations/Joker/tags","blobs_url":"https://api.github.com/repos/Phonations/Joker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Phonations/Joker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Phonations/Joker/git/refs{/sha}","trees_url":"https://api.github.com/repos/Phonations/Joker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Phonations/Joker/statuses/{sha}","languages_url":"https://api.github.com/repos/Phonations/Joker/languages","stargazers_url":"https://api.github.com/repos/Phonations/Joker/stargazers","contributors_url":"https://api.github.com/repos/Phonations/Joker/contributors","subscribers_url":"https://api.github.com/repos/Phonations/Joker/subscribers","subscription_url":"https://api.github.com/repos/Phonations/Joker/subscription","commits_url":"https://api.github.com/repos/Phonations/Joker/commits{/sha}","git_commits_url":"https://api.github.com/repos/Phonations/Joker/git/commits{/sha}","comments_url":"https://api.github.com/repos/Phonations/Joker/comments{/number}","issue_comment_url":"https://api.github.com/repos/Phonations/Joker/issues/comments/{number}","contents_url":"https://api.github.com/repos/Phonations/Joker/contents/{+path}","compare_url":"https://api.github.com/repos/Phonations/Joker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Phonations/Joker/merges","archive_url":"https://api.github.com/repos/Phonations/Joker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Phonations/Joker/downloads","issues_url":"https://api.github.com/repos/Phonations/Joker/issues{/number}","pulls_url":"https://api.github.com/repos/Phonations/Joker/pulls{/number}","milestones_url":"https://api.github.com/repos/Phonations/Joker/milestones{/number}","notifications_url":"https://api.github.com/repos/Phonations/Joker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Phonations/Joker/labels{/name}","releases_url":"https://api.github.com/repos/Phonations/Joker/releases{/id}","created_at":"2013-05-03T13:44:50Z","updated_at":"2014-09-02T15:50:08Z","pushed_at":"2014-09-04T15:51:16Z","git_url":"git://github.com/Phonations/Joker.git","ssh_url":"git@github.com:Phonations/Joker.git","clone_url":"https://github.com/Phonations/Joker.git","svn_url":"https://github.com/Phonations/Joker","homepage":"http://www.phonations.com","size":19553,"stargazers_count":15,"watchers_count":15,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":3,"mirror_url":null,"open_issues_count":35,"forks":3,"open_issues":35,"watchers":15,"default_branch":"master"}},"base":{"label":"Phonations:master","ref":"master","sha":"c210cabb94a183ab8b70cd0550d08ec724484692","user":{"login":"Phonations","id":4180112,"avatar_url":"https://avatars.githubusercontent.com/u/4180112?v=2","gravatar_id":"67e7eea729f5dac59544e6d989cb2b8a","url":"https://api.github.com/users/Phonations","html_url":"https://github.com/Phonations","followers_url":"https://api.github.com/users/Phonations/followers","following_url":"https://api.github.com/users/Phonations/following{/other_user}","gists_url":"https://api.github.com/users/Phonations/gists{/gist_id}","starred_url":"https://api.github.com/users/Phonations/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Phonations/subscriptions","organizations_url":"https://api.github.com/users/Phonations/orgs","repos_url":"https://api.github.com/users/Phonations/repos","events_url":"https://api.github.com/users/Phonations/events{/privacy}","received_events_url":"https://api.github.com/users/Phonations/received_events","type":"Organization","site_admin":false},"repo":{"id":9836733,"name":"Joker","full_name":"Phonations/Joker","owner":{"login":"Phonations","id":4180112,"avatar_url":"https://avatars.githubusercontent.com/u/4180112?v=2","gravatar_id":"67e7eea729f5dac59544e6d989cb2b8a","url":"https://api.github.com/users/Phonations","html_url":"https://github.com/Phonations","followers_url":"https://api.github.com/users/Phonations/followers","following_url":"https://api.github.com/users/Phonations/following{/other_user}","gists_url":"https://api.github.com/users/Phonations/gists{/gist_id}","starred_url":"https://api.github.com/users/Phonations/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Phonations/subscriptions","organizations_url":"https://api.github.com/users/Phonations/orgs","repos_url":"https://api.github.com/users/Phonations/repos","events_url":"https://api.github.com/users/Phonations/events{/privacy}","received_events_url":"https://api.github.com/users/Phonations/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Phonations/Joker","description":"Digital rythmo band system for dubbing and postsynchronisation purposes.","fork":false,"url":"https://api.github.com/repos/Phonations/Joker","forks_url":"https://api.github.com/repos/Phonations/Joker/forks","keys_url":"https://api.github.com/repos/Phonations/Joker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Phonations/Joker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Phonations/Joker/teams","hooks_url":"https://api.github.com/repos/Phonations/Joker/hooks","issue_events_url":"https://api.github.com/repos/Phonations/Joker/issues/events{/number}","events_url":"https://api.github.com/repos/Phonations/Joker/events","assignees_url":"https://api.github.com/repos/Phonations/Joker/assignees{/user}","branches_url":"https://api.github.com/repos/Phonations/Joker/branches{/branch}","tags_url":"https://api.github.com/repos/Phonations/Joker/tags","blobs_url":"https://api.github.com/repos/Phonations/Joker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Phonations/Joker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Phonations/Joker/git/refs{/sha}","trees_url":"https://api.github.com/repos/Phonations/Joker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Phonations/Joker/statuses/{sha}","languages_url":"https://api.github.com/repos/Phonations/Joker/languages","stargazers_url":"https://api.github.com/repos/Phonations/Joker/stargazers","contributors_url":"https://api.github.com/repos/Phonations/Joker/contributors","subscribers_url":"https://api.github.com/repos/Phonations/Joker/subscribers","subscription_url":"https://api.github.com/repos/Phonations/Joker/subscription","commits_url":"https://api.github.com/repos/Phonations/Joker/commits{/sha}","git_commits_url":"https://api.github.com/repos/Phonations/Joker/git/commits{/sha}","comments_url":"https://api.github.com/repos/Phonations/Joker/comments{/number}","issue_comment_url":"https://api.github.com/repos/Phonations/Joker/issues/comments/{number}","contents_url":"https://api.github.com/repos/Phonations/Joker/contents/{+path}","compare_url":"https://api.github.com/repos/Phonations/Joker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Phonations/Joker/merges","archive_url":"https://api.github.com/repos/Phonations/Joker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Phonations/Joker/downloads","issues_url":"https://api.github.com/repos/Phonations/Joker/issues{/number}","pulls_url":"https://api.github.com/repos/Phonations/Joker/pulls{/number}","milestones_url":"https://api.github.com/repos/Phonations/Joker/milestones{/number}","notifications_url":"https://api.github.com/repos/Phonations/Joker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Phonations/Joker/labels{/name}","releases_url":"https://api.github.com/repos/Phonations/Joker/releases{/id}","created_at":"2013-05-03T13:44:50Z","updated_at":"2014-09-02T15:50:08Z","pushed_at":"2014-09-04T15:51:16Z","git_url":"git://github.com/Phonations/Joker.git","ssh_url":"git@github.com:Phonations/Joker.git","clone_url":"https://github.com/Phonations/Joker.git","svn_url":"https://github.com/Phonations/Joker","homepage":"http://www.phonations.com","size":19553,"stargazers_count":15,"watchers_count":15,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":3,"mirror_url":null,"open_issues_count":35,"forks":3,"open_issues":35,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Phonations/Joker/pulls/250"},"html":{"href":"https://github.com/Phonations/Joker/pull/250"},"issue":{"href":"https://api.github.com/repos/Phonations/Joker/issues/250"},"comments":{"href":"https://api.github.com/repos/Phonations/Joker/issues/250/comments"},"review_comments":{"href":"https://api.github.com/repos/Phonations/Joker/pulls/250/comments"},"review_comment":{"href":"https://api.github.com/repos/Phonations/Joker/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Phonations/Joker/pulls/250/commits"},"statuses":{"href":"https://api.github.com/repos/Phonations/Joker/statuses/0062b7e2ce4dcf13d63c7ac2ea3b682332b5790e"}}}}