GitHub PullRequestReviewCommentEvent at 2014-09-16 21:16:37
Repository: exabgp
Actor: thomas-mangin
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/Exa-Networks/exabgp/pulls/comments/17631087","id":17631087,"diff_hunk":"@@ -102,3 +102,22 @@ def unpack (data):\n \t\treturn OriginASN4Number(ASN(asn),number,False,data[:8])\n \n OriginASN4Number.register_extended()\n+\n+# ======================================================== OriginASN4Number32\n+# \n+\n+class OriginASN4Number32 (OriginASN4Number):\n+\tCOMMUNITY_TYPE = 0x02\n+\tCOMMUNITY_SUBTYPE = 0x03","path":"lib/exabgp/bgp/message/update/attribute/community/extended/origin.py","position":10,"original_position":10,"commit_id":"6b326b8557ae9e22a86bd900422aef04d0beaafa","original_commit_id":"6b326b8557ae9e22a86bd900422aef04d0beaafa","user":{"login":"thomas-mangin","id":1227755,"avatar_url":"https://avatars.githubusercontent.com/u/1227755?v=2","gravatar_id":"21ce9c7fcf414948690c3a025d1dcce3","url":"https://api.github.com/users/thomas-mangin","html_url":"https://github.com/thomas-mangin","followers_url":"https://api.github.com/users/thomas-mangin/followers","following_url":"https://api.github.com/users/thomas-mangin/following{/other_user}","gists_url":"https://api.github.com/users/thomas-mangin/gists{/gist_id}","starred_url":"https://api.github.com/users/thomas-mangin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomas-mangin/subscriptions","organizations_url":"https://api.github.com/users/thomas-mangin/orgs","repos_url":"https://api.github.com/users/thomas-mangin/repos","events_url":"https://api.github.com/users/thomas-mangin/events{/privacy}","received_events_url":"https://api.github.com/users/thomas-mangin/received_events","type":"User","site_admin":false},"body":"This inherit from RouteTarget which has a subtype of 2, should we not really redefine this but instead have a new base class for 0x3 ..","created_at":"2014-09-16T21:16:37Z","updated_at":"2014-09-16T21:16:37Z","html_url":"https://github.com/Exa-Networks/exabgp/pull/170#discussion_r17631087","pull_request_url":"https://api.github.com/repos/Exa-Networks/exabgp/pulls/170","_links":{"self":{"href":"https://api.github.com/repos/Exa-Networks/exabgp/pulls/comments/17631087"},"html":{"href":"https://github.com/Exa-Networks/exabgp/pull/170#discussion_r17631087"},"pull_request":{"href":"https://api.github.com/repos/Exa-Networks/exabgp/pulls/170"}}},"pull_request":{"url":"https://api.github.com/repos/Exa-Networks/exabgp/pulls/170","id":21300165,"html_url":"https://github.com/Exa-Networks/exabgp/pull/170","diff_url":"https://github.com/Exa-Networks/exabgp/pull/170.diff","patch_url":"https://github.com/Exa-Networks/exabgp/pull/170.patch","issue_url":"https://api.github.com/repos/Exa-Networks/exabgp/issues/170","number":170,"state":"open","locked":false,"title":"4byte community","user":{"login":"lazy404","id":2153045,"avatar_url":"https://avatars.githubusercontent.com/u/2153045?v=2","gravatar_id":"4d45b30f046b9ebd58ab4477cfb7b954","url":"https://api.github.com/users/lazy404","html_url":"https://github.com/lazy404","followers_url":"https://api.github.com/users/lazy404/followers","following_url":"https://api.github.com/users/lazy404/following{/other_user}","gists_url":"https://api.github.com/users/lazy404/gists{/gist_id}","starred_url":"https://api.github.com/users/lazy404/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lazy404/subscriptions","organizations_url":"https://api.github.com/users/lazy404/orgs","repos_url":"https://api.github.com/users/lazy404/repos","events_url":"https://api.github.com/users/lazy404/events{/privacy}","received_events_url":"https://api.github.com/users/lazy404/received_events","type":"User","site_admin":false},"body":"the example config is in\r\n\r\netc/exabgp/ebgp4-32bit-community.txt\r\n\r\nSorry I wasn't able to get the expected values to complete the testcase","created_at":"2014-09-16T14:07:38Z","updated_at":"2014-09-16T21:16:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1ceb4107ae9ee85c63818983ca2438d31e500583","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Exa-Networks/exabgp/pulls/170/commits","review_comments_url":"https://api.github.com/repos/Exa-Networks/exabgp/pulls/170/comments","review_comment_url":"https://api.github.com/repos/Exa-Networks/exabgp/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Exa-Networks/exabgp/issues/170/comments","statuses_url":"https://api.github.com/repos/Exa-Networks/exabgp/statuses/6b326b8557ae9e22a86bd900422aef04d0beaafa","head":{"label":"lazy404:4byteCommunity","ref":"4byteCommunity","sha":"6b326b8557ae9e22a86bd900422aef04d0beaafa","user":{"login":"lazy404","id":2153045,"avatar_url":"https://avatars.githubusercontent.com/u/2153045?v=2","gravatar_id":"4d45b30f046b9ebd58ab4477cfb7b954","url":"https://api.github.com/users/lazy404","html_url":"https://github.com/lazy404","followers_url":"https://api.github.com/users/lazy404/followers","following_url":"https://api.github.com/users/lazy404/following{/other_user}","gists_url":"https://api.github.com/users/lazy404/gists{/gist_id}","starred_url":"https://api.github.com/users/lazy404/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lazy404/subscriptions","organizations_url":"https://api.github.com/users/lazy404/orgs","repos_url":"https://api.github.com/users/lazy404/repos","events_url":"https://api.github.com/users/lazy404/events{/privacy}","received_events_url":"https://api.github.com/users/lazy404/received_events","type":"User","site_admin":false},"repo":{"id":23975424,"name":"exabgp","full_name":"lazy404/exabgp","owner":{"login":"lazy404","id":2153045,"avatar_url":"https://avatars.githubusercontent.com/u/2153045?v=2","gravatar_id":"4d45b30f046b9ebd58ab4477cfb7b954","url":"https://api.github.com/users/lazy404","html_url":"https://github.com/lazy404","followers_url":"https://api.github.com/users/lazy404/followers","following_url":"https://api.github.com/users/lazy404/following{/other_user}","gists_url":"https://api.github.com/users/lazy404/gists{/gist_id}","starred_url":"https://api.github.com/users/lazy404/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lazy404/subscriptions","organizations_url":"https://api.github.com/users/lazy404/orgs","repos_url":"https://api.github.com/users/lazy404/repos","events_url":"https://api.github.com/users/lazy404/events{/privacy}","received_events_url":"https://api.github.com/users/lazy404/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lazy404/exabgp","description":"The BGP swiss army knife of networking","fork":true,"url":"https://api.github.com/repos/lazy404/exabgp","forks_url":"https://api.github.com/repos/lazy404/exabgp/forks","keys_url":"https://api.github.com/repos/lazy404/exabgp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lazy404/exabgp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lazy404/exabgp/teams","hooks_url":"https://api.github.com/repos/lazy404/exabgp/hooks","issue_events_url":"https://api.github.com/repos/lazy404/exabgp/issues/events{/number}","events_url":"https://api.github.com/repos/lazy404/exabgp/events","assignees_url":"https://api.github.com/repos/lazy404/exabgp/assignees{/user}","branches_url":"https://api.github.com/repos/lazy404/exabgp/branches{/branch}","tags_url":"https://api.github.com/repos/lazy404/exabgp/tags","blobs_url":"https://api.github.com/repos/lazy404/exabgp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lazy404/exabgp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lazy404/exabgp/git/refs{/sha}","trees_url":"https://api.github.com/repos/lazy404/exabgp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lazy404/exabgp/statuses/{sha}","languages_url":"https://api.github.com/repos/lazy404/exabgp/languages","stargazers_url":"https://api.github.com/repos/lazy404/exabgp/stargazers","contributors_url":"https://api.github.com/repos/lazy404/exabgp/contributors","subscribers_url":"https://api.github.com/repos/lazy404/exabgp/subscribers","subscription_url":"https://api.github.com/repos/lazy404/exabgp/subscription","commits_url":"https://api.github.com/repos/lazy404/exabgp/commits{/sha}","git_commits_url":"https://api.github.com/repos/lazy404/exabgp/git/commits{/sha}","comments_url":"https://api.github.com/repos/lazy404/exabgp/comments{/number}","issue_comment_url":"https://api.github.com/repos/lazy404/exabgp/issues/comments/{number}","contents_url":"https://api.github.com/repos/lazy404/exabgp/contents/{+path}","compare_url":"https://api.github.com/repos/lazy404/exabgp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lazy404/exabgp/merges","archive_url":"https://api.github.com/repos/lazy404/exabgp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lazy404/exabgp/downloads","issues_url":"https://api.github.com/repos/lazy404/exabgp/issues{/number}","pulls_url":"https://api.github.com/repos/lazy404/exabgp/pulls{/number}","milestones_url":"https://api.github.com/repos/lazy404/exabgp/milestones{/number}","notifications_url":"https://api.github.com/repos/lazy404/exabgp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lazy404/exabgp/labels{/name}","releases_url":"https://api.github.com/repos/lazy404/exabgp/releases{/id}","created_at":"2014-09-12T20:18:07Z","updated_at":"2014-09-12T21:11:23Z","pushed_at":"2014-09-16T14:02:51Z","git_url":"git://github.com/lazy404/exabgp.git","ssh_url":"git@github.com:lazy404/exabgp.git","clone_url":"https://github.com/lazy404/exabgp.git","svn_url":"https://github.com/lazy404/exabgp","homepage":null,"size":12774,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Exa-Networks:master","ref":"master","sha":"27a3e00c264121a6db94839f330582974cf72561","user":{"login":"Exa-Networks","id":5339170,"avatar_url":"https://avatars.githubusercontent.com/u/5339170?v=2","gravatar_id":"aadb127e483a6e92716c510c77745880","url":"https://api.github.com/users/Exa-Networks","html_url":"https://github.com/Exa-Networks","followers_url":"https://api.github.com/users/Exa-Networks/followers","following_url":"https://api.github.com/users/Exa-Networks/following{/other_user}","gists_url":"https://api.github.com/users/Exa-Networks/gists{/gist_id}","starred_url":"https://api.github.com/users/Exa-Networks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Exa-Networks/subscriptions","organizations_url":"https://api.github.com/users/Exa-Networks/orgs","repos_url":"https://api.github.com/users/Exa-Networks/repos","events_url":"https://api.github.com/users/Exa-Networks/events{/privacy}","received_events_url":"https://api.github.com/users/Exa-Networks/received_events","type":"Organization","site_admin":false},"repo":{"id":12407457,"name":"exabgp","full_name":"Exa-Networks/exabgp","owner":{"login":"Exa-Networks","id":5339170,"avatar_url":"https://avatars.githubusercontent.com/u/5339170?v=2","gravatar_id":"aadb127e483a6e92716c510c77745880","url":"https://api.github.com/users/Exa-Networks","html_url":"https://github.com/Exa-Networks","followers_url":"https://api.github.com/users/Exa-Networks/followers","following_url":"https://api.github.com/users/Exa-Networks/following{/other_user}","gists_url":"https://api.github.com/users/Exa-Networks/gists{/gist_id}","starred_url":"https://api.github.com/users/Exa-Networks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Exa-Networks/subscriptions","organizations_url":"https://api.github.com/users/Exa-Networks/orgs","repos_url":"https://api.github.com/users/Exa-Networks/repos","events_url":"https://api.github.com/users/Exa-Networks/events{/privacy}","received_events_url":"https://api.github.com/users/Exa-Networks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Exa-Networks/exabgp","description":"The BGP swiss army knife of networking","fork":false,"url":"https://api.github.com/repos/Exa-Networks/exabgp","forks_url":"https://api.github.com/repos/Exa-Networks/exabgp/forks","keys_url":"https://api.github.com/repos/Exa-Networks/exabgp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Exa-Networks/exabgp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Exa-Networks/exabgp/teams","hooks_url":"https://api.github.com/repos/Exa-Networks/exabgp/hooks","issue_events_url":"https://api.github.com/repos/Exa-Networks/exabgp/issues/events{/number}","events_url":"https://api.github.com/repos/Exa-Networks/exabgp/events","assignees_url":"https://api.github.com/repos/Exa-Networks/exabgp/assignees{/user}","branches_url":"https://api.github.com/repos/Exa-Networks/exabgp/branches{/branch}","tags_url":"https://api.github.com/repos/Exa-Networks/exabgp/tags","blobs_url":"https://api.github.com/repos/Exa-Networks/exabgp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Exa-Networks/exabgp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Exa-Networks/exabgp/git/refs{/sha}","trees_url":"https://api.github.com/repos/Exa-Networks/exabgp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Exa-Networks/exabgp/statuses/{sha}","languages_url":"https://api.github.com/repos/Exa-Networks/exabgp/languages","stargazers_url":"https://api.github.com/repos/Exa-Networks/exabgp/stargazers","contributors_url":"https://api.github.com/repos/Exa-Networks/exabgp/contributors","subscribers_url":"https://api.github.com/repos/Exa-Networks/exabgp/subscribers","subscription_url":"https://api.github.com/repos/Exa-Networks/exabgp/subscription","commits_url":"https://api.github.com/repos/Exa-Networks/exabgp/commits{/sha}","git_commits_url":"https://api.github.com/repos/Exa-Networks/exabgp/git/commits{/sha}","comments_url":"https://api.github.com/repos/Exa-Networks/exabgp/comments{/number}","issue_comment_url":"https://api.github.com/repos/Exa-Networks/exabgp/issues/comments/{number}","contents_url":"https://api.github.com/repos/Exa-Networks/exabgp/contents/{+path}","compare_url":"https://api.github.com/repos/Exa-Networks/exabgp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Exa-Networks/exabgp/merges","archive_url":"https://api.github.com/repos/Exa-Networks/exabgp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Exa-Networks/exabgp/downloads","issues_url":"https://api.github.com/repos/Exa-Networks/exabgp/issues{/number}","pulls_url":"https://api.github.com/repos/Exa-Networks/exabgp/pulls{/number}","milestones_url":"https://api.github.com/repos/Exa-Networks/exabgp/milestones{/number}","notifications_url":"https://api.github.com/repos/Exa-Networks/exabgp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Exa-Networks/exabgp/labels{/name}","releases_url":"https://api.github.com/repos/Exa-Networks/exabgp/releases{/id}","created_at":"2013-08-27T13:56:08Z","updated_at":"2014-09-11T16:39:15Z","pushed_at":"2014-09-12T23:13:05Z","git_url":"git://github.com/Exa-Networks/exabgp.git","ssh_url":"git@github.com:Exa-Networks/exabgp.git","clone_url":"https://github.com/Exa-Networks/exabgp.git","svn_url":"https://github.com/Exa-Networks/exabgp","homepage":null,"size":12774,"stargazers_count":221,"watchers_count":221,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":42,"mirror_url":null,"open_issues_count":26,"forks":42,"open_issues":26,"watchers":221,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Exa-Networks/exabgp/pulls/170"},"html":{"href":"https://github.com/Exa-Networks/exabgp/pull/170"},"issue":{"href":"https://api.github.com/repos/Exa-Networks/exabgp/issues/170"},"comments":{"href":"https://api.github.com/repos/Exa-Networks/exabgp/issues/170/comments"},"review_comments":{"href":"https://api.github.com/repos/Exa-Networks/exabgp/pulls/170/comments"},"review_comment":{"href":"https://api.github.com/repos/Exa-Networks/exabgp/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Exa-Networks/exabgp/pulls/170/commits"},"statuses":{"href":"https://api.github.com/repos/Exa-Networks/exabgp/statuses/6b326b8557ae9e22a86bd900422aef04d0beaafa"}}}}