GitHub PullRequestReviewCommentEvent at 2014-12-06 16:45:48
Repository: periscope
Actor: doktoric
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/sequenceiq/periscope/pulls/comments/21417500","id":21417500,"diff_hunk":"@@ -373,32 +331,44 @@ Also a `threshold` can be configured, which specifies the variance applied by th\n \n + Response 200 (application/json)\n \n-        {\n-          \"alarms\": [\n-            {\n-              \"notifications\": [],\n-              \"scalingPolicyId\": null,\n-              \"period\": 10,\n-              \"comparisonOperator\": \"GREATER_THAN\",\n-              \"threshold\": 10,\n-              \"metric\": \"PENDING_CONTAINERS\",\n-              \"description\": \"Number of pending containers is high\",\n-              \"alarmName\": \"pendingContainerHigh\",\n-              \"id\": 50\n-            },\n-            {\n-              \"notifications\": [],\n-              \"scalingPolicyId\": null,\n-              \"period\": 10,\n-              \"comparisonOperator\": \"EQUALS\",\n-              \"threshold\": 1,\n-              \"metric\": \"GLOBAL_RESOURCES\",\n-              \"description\": \"Low free global resource rate\",\n-              \"alarmName\": \"freeGlobalResourcesRateLow\",\n-              \"id\": 51\n-            }\n-          ]\n-        }\n+        [\n+          {\n+            \"id\": 150,\n+            \"alarmName\": \"freeGlobalResourcesRateLow\",\n+            \"description\": \"Low free global resource rate\",\n+            \"scalingPolicyId\": null,\n+            \"notifications\": [\n+              {\n+                \"target\": [\n+                  \"tamas.bihari@sequenceiq.com\"\n+                ],\n+                \"notificationType\": \"EMAIL\"\n+              }\n+            ],\n+            \"metric\": \"GLOBAL_RESOURCES\",\n+            \"comparisonOperator\": \"EQUALS\",\n+            \"threshold\": 0.3,\n+            \"period\": 2\n+          },\n+          {\n+            \"id\": 151,\n+            \"alarmName\": \"freeGlobalResourcesRateLow\",\n+            \"description\": \"Low free global resource rate\",\n+            \"scalingPolicyId\": null,\n+            \"notifications\": [\n+              {\n+                \"target\": [\n+                  \"krisztian.horvath@sequenceiq.com\"","path":"apiary.apib","position":267,"original_position":267,"commit_id":"4d77a7b52b24d130e158dab8ecfc60971d5b5340","original_commit_id":"4d77a7b52b24d130e158dab8ecfc60971d5b5340","user":{"login":"doktoric","id":1117088,"avatar_url":"https://avatars.githubusercontent.com/u/1117088?v=3","gravatar_id":"","url":"https://api.github.com/users/doktoric","html_url":"https://github.com/doktoric","followers_url":"https://api.github.com/users/doktoric/followers","following_url":"https://api.github.com/users/doktoric/following{/other_user}","gists_url":"https://api.github.com/users/doktoric/gists{/gist_id}","starred_url":"https://api.github.com/users/doktoric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doktoric/subscriptions","organizations_url":"https://api.github.com/users/doktoric/orgs","repos_url":"https://api.github.com/users/doktoric/repos","events_url":"https://api.github.com/users/doktoric/events{/privacy}","received_events_url":"https://api.github.com/users/doktoric/received_events","type":"User","site_admin":false},"body":"do you realy want to use your mail here?","created_at":"2014-12-06T16:45:48Z","updated_at":"2014-12-06T16:45:48Z","html_url":"https://github.com/sequenceiq/periscope/pull/12#discussion_r21417500","pull_request_url":"https://api.github.com/repos/sequenceiq/periscope/pulls/12","_links":{"self":{"href":"https://api.github.com/repos/sequenceiq/periscope/pulls/comments/21417500"},"html":{"href":"https://github.com/sequenceiq/periscope/pull/12#discussion_r21417500"},"pull_request":{"href":"https://api.github.com/repos/sequenceiq/periscope/pulls/12"}}},"pull_request":{"url":"https://api.github.com/repos/sequenceiq/periscope/pulls/12","id":25593675,"html_url":"https://github.com/sequenceiq/periscope/pull/12","diff_url":"https://github.com/sequenceiq/periscope/pull/12.diff","patch_url":"https://github.com/sequenceiq/periscope/pull/12.patch","issue_url":"https://api.github.com/repos/sequenceiq/periscope/issues/12","number":12,"state":"open","locked":false,"title":"PERI-2 update documentation","user":{"login":"keyki","id":2330520,"avatar_url":"https://avatars.githubusercontent.com/u/2330520?v=3","gravatar_id":"","url":"https://api.github.com/users/keyki","html_url":"https://github.com/keyki","followers_url":"https://api.github.com/users/keyki/followers","following_url":"https://api.github.com/users/keyki/following{/other_user}","gists_url":"https://api.github.com/users/keyki/gists{/gist_id}","starred_url":"https://api.github.com/users/keyki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keyki/subscriptions","organizations_url":"https://api.github.com/users/keyki/orgs","repos_url":"https://api.github.com/users/keyki/repos","events_url":"https://api.github.com/users/keyki/events{/privacy}","received_events_url":"https://api.github.com/users/keyki/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-12-05T19:27:34Z","updated_at":"2014-12-06T16:45:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aee6e14fa9bf24fcbd68cab397fbdf81da2c0921","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sequenceiq/periscope/pulls/12/commits","review_comments_url":"https://api.github.com/repos/sequenceiq/periscope/pulls/12/comments","review_comment_url":"https://api.github.com/repos/sequenceiq/periscope/pulls/comments/{number}","comments_url":"https://api.github.com/repos/sequenceiq/periscope/issues/12/comments","statuses_url":"https://api.github.com/repos/sequenceiq/periscope/statuses/4d77a7b52b24d130e158dab8ecfc60971d5b5340","head":{"label":"sequenceiq:doc","ref":"doc","sha":"4d77a7b52b24d130e158dab8ecfc60971d5b5340","user":{"login":"sequenceiq","id":6003133,"avatar_url":"https://avatars.githubusercontent.com/u/6003133?v=3","gravatar_id":"","url":"https://api.github.com/users/sequenceiq","html_url":"https://github.com/sequenceiq","followers_url":"https://api.github.com/users/sequenceiq/followers","following_url":"https://api.github.com/users/sequenceiq/following{/other_user}","gists_url":"https://api.github.com/users/sequenceiq/gists{/gist_id}","starred_url":"https://api.github.com/users/sequenceiq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sequenceiq/subscriptions","organizations_url":"https://api.github.com/users/sequenceiq/orgs","repos_url":"https://api.github.com/users/sequenceiq/repos","events_url":"https://api.github.com/users/sequenceiq/events{/privacy}","received_events_url":"https://api.github.com/users/sequenceiq/received_events","type":"Organization","site_admin":false},"repo":{"id":21616789,"name":"periscope","full_name":"sequenceiq/periscope","owner":{"login":"sequenceiq","id":6003133,"avatar_url":"https://avatars.githubusercontent.com/u/6003133?v=3","gravatar_id":"","url":"https://api.github.com/users/sequenceiq","html_url":"https://github.com/sequenceiq","followers_url":"https://api.github.com/users/sequenceiq/followers","following_url":"https://api.github.com/users/sequenceiq/following{/other_user}","gists_url":"https://api.github.com/users/sequenceiq/gists{/gist_id}","starred_url":"https://api.github.com/users/sequenceiq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sequenceiq/subscriptions","organizations_url":"https://api.github.com/users/sequenceiq/orgs","repos_url":"https://api.github.com/users/sequenceiq/repos","events_url":"https://api.github.com/users/sequenceiq/events{/privacy}","received_events_url":"https://api.github.com/users/sequenceiq/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sequenceiq/periscope","description":"Periscope brings SLA policy based autoscaling to Hadoop YARN ","fork":false,"url":"https://api.github.com/repos/sequenceiq/periscope","forks_url":"https://api.github.com/repos/sequenceiq/periscope/forks","keys_url":"https://api.github.com/repos/sequenceiq/periscope/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sequenceiq/periscope/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sequenceiq/periscope/teams","hooks_url":"https://api.github.com/repos/sequenceiq/periscope/hooks","issue_events_url":"https://api.github.com/repos/sequenceiq/periscope/issues/events{/number}","events_url":"https://api.github.com/repos/sequenceiq/periscope/events","assignees_url":"https://api.github.com/repos/sequenceiq/periscope/assignees{/user}","branches_url":"https://api.github.com/repos/sequenceiq/periscope/branches{/branch}","tags_url":"https://api.github.com/repos/sequenceiq/periscope/tags","blobs_url":"https://api.github.com/repos/sequenceiq/periscope/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sequenceiq/periscope/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sequenceiq/periscope/git/refs{/sha}","trees_url":"https://api.github.com/repos/sequenceiq/periscope/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sequenceiq/periscope/statuses/{sha}","languages_url":"https://api.github.com/repos/sequenceiq/periscope/languages","stargazers_url":"https://api.github.com/repos/sequenceiq/periscope/stargazers","contributors_url":"https://api.github.com/repos/sequenceiq/periscope/contributors","subscribers_url":"https://api.github.com/repos/sequenceiq/periscope/subscribers","subscription_url":"https://api.github.com/repos/sequenceiq/periscope/subscription","commits_url":"https://api.github.com/repos/sequenceiq/periscope/commits{/sha}","git_commits_url":"https://api.github.com/repos/sequenceiq/periscope/git/commits{/sha}","comments_url":"https://api.github.com/repos/sequenceiq/periscope/comments{/number}","issue_comment_url":"https://api.github.com/repos/sequenceiq/periscope/issues/comments/{number}","contents_url":"https://api.github.com/repos/sequenceiq/periscope/contents/{+path}","compare_url":"https://api.github.com/repos/sequenceiq/periscope/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sequenceiq/periscope/merges","archive_url":"https://api.github.com/repos/sequenceiq/periscope/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sequenceiq/periscope/downloads","issues_url":"https://api.github.com/repos/sequenceiq/periscope/issues{/number}","pulls_url":"https://api.github.com/repos/sequenceiq/periscope/pulls{/number}","milestones_url":"https://api.github.com/repos/sequenceiq/periscope/milestones{/number}","notifications_url":"https://api.github.com/repos/sequenceiq/periscope/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sequenceiq/periscope/labels{/name}","releases_url":"https://api.github.com/repos/sequenceiq/periscope/releases{/id}","created_at":"2014-07-08T14:54:10Z","updated_at":"2014-12-05T18:52:22Z","pushed_at":"2014-12-05T19:27:11Z","git_url":"git://github.com/sequenceiq/periscope.git","ssh_url":"git@github.com:sequenceiq/periscope.git","clone_url":"https://github.com/sequenceiq/periscope.git","svn_url":"https://github.com/sequenceiq/periscope","homepage":"","size":3282,"stargazers_count":14,"watchers_count":14,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":14,"default_branch":"master"}},"base":{"label":"sequenceiq:master","ref":"master","sha":"b06ce8155597a7c6e367a6cc71679973e1351c15","user":{"login":"sequenceiq","id":6003133,"avatar_url":"https://avatars.githubusercontent.com/u/6003133?v=3","gravatar_id":"","url":"https://api.github.com/users/sequenceiq","html_url":"https://github.com/sequenceiq","followers_url":"https://api.github.com/users/sequenceiq/followers","following_url":"https://api.github.com/users/sequenceiq/following{/other_user}","gists_url":"https://api.github.com/users/sequenceiq/gists{/gist_id}","starred_url":"https://api.github.com/users/sequenceiq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sequenceiq/subscriptions","organizations_url":"https://api.github.com/users/sequenceiq/orgs","repos_url":"https://api.github.com/users/sequenceiq/repos","events_url":"https://api.github.com/users/sequenceiq/events{/privacy}","received_events_url":"https://api.github.com/users/sequenceiq/received_events","type":"Organization","site_admin":false},"repo":{"id":21616789,"name":"periscope","full_name":"sequenceiq/periscope","owner":{"login":"sequenceiq","id":6003133,"avatar_url":"https://avatars.githubusercontent.com/u/6003133?v=3","gravatar_id":"","url":"https://api.github.com/users/sequenceiq","html_url":"https://github.com/sequenceiq","followers_url":"https://api.github.com/users/sequenceiq/followers","following_url":"https://api.github.com/users/sequenceiq/following{/other_user}","gists_url":"https://api.github.com/users/sequenceiq/gists{/gist_id}","starred_url":"https://api.github.com/users/sequenceiq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sequenceiq/subscriptions","organizations_url":"https://api.github.com/users/sequenceiq/orgs","repos_url":"https://api.github.com/users/sequenceiq/repos","events_url":"https://api.github.com/users/sequenceiq/events{/privacy}","received_events_url":"https://api.github.com/users/sequenceiq/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sequenceiq/periscope","description":"Periscope brings SLA policy based autoscaling to Hadoop YARN ","fork":false,"url":"https://api.github.com/repos/sequenceiq/periscope","forks_url":"https://api.github.com/repos/sequenceiq/periscope/forks","keys_url":"https://api.github.com/repos/sequenceiq/periscope/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sequenceiq/periscope/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sequenceiq/periscope/teams","hooks_url":"https://api.github.com/repos/sequenceiq/periscope/hooks","issue_events_url":"https://api.github.com/repos/sequenceiq/periscope/issues/events{/number}","events_url":"https://api.github.com/repos/sequenceiq/periscope/events","assignees_url":"https://api.github.com/repos/sequenceiq/periscope/assignees{/user}","branches_url":"https://api.github.com/repos/sequenceiq/periscope/branches{/branch}","tags_url":"https://api.github.com/repos/sequenceiq/periscope/tags","blobs_url":"https://api.github.com/repos/sequenceiq/periscope/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sequenceiq/periscope/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sequenceiq/periscope/git/refs{/sha}","trees_url":"https://api.github.com/repos/sequenceiq/periscope/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sequenceiq/periscope/statuses/{sha}","languages_url":"https://api.github.com/repos/sequenceiq/periscope/languages","stargazers_url":"https://api.github.com/repos/sequenceiq/periscope/stargazers","contributors_url":"https://api.github.com/repos/sequenceiq/periscope/contributors","subscribers_url":"https://api.github.com/repos/sequenceiq/periscope/subscribers","subscription_url":"https://api.github.com/repos/sequenceiq/periscope/subscription","commits_url":"https://api.github.com/repos/sequenceiq/periscope/commits{/sha}","git_commits_url":"https://api.github.com/repos/sequenceiq/periscope/git/commits{/sha}","comments_url":"https://api.github.com/repos/sequenceiq/periscope/comments{/number}","issue_comment_url":"https://api.github.com/repos/sequenceiq/periscope/issues/comments/{number}","contents_url":"https://api.github.com/repos/sequenceiq/periscope/contents/{+path}","compare_url":"https://api.github.com/repos/sequenceiq/periscope/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sequenceiq/periscope/merges","archive_url":"https://api.github.com/repos/sequenceiq/periscope/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sequenceiq/periscope/downloads","issues_url":"https://api.github.com/repos/sequenceiq/periscope/issues{/number}","pulls_url":"https://api.github.com/repos/sequenceiq/periscope/pulls{/number}","milestones_url":"https://api.github.com/repos/sequenceiq/periscope/milestones{/number}","notifications_url":"https://api.github.com/repos/sequenceiq/periscope/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sequenceiq/periscope/labels{/name}","releases_url":"https://api.github.com/repos/sequenceiq/periscope/releases{/id}","created_at":"2014-07-08T14:54:10Z","updated_at":"2014-12-05T18:52:22Z","pushed_at":"2014-12-05T19:27:11Z","git_url":"git://github.com/sequenceiq/periscope.git","ssh_url":"git@github.com:sequenceiq/periscope.git","clone_url":"https://github.com/sequenceiq/periscope.git","svn_url":"https://github.com/sequenceiq/periscope","homepage":"","size":3282,"stargazers_count":14,"watchers_count":14,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sequenceiq/periscope/pulls/12"},"html":{"href":"https://github.com/sequenceiq/periscope/pull/12"},"issue":{"href":"https://api.github.com/repos/sequenceiq/periscope/issues/12"},"comments":{"href":"https://api.github.com/repos/sequenceiq/periscope/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/sequenceiq/periscope/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/sequenceiq/periscope/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/sequenceiq/periscope/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/sequenceiq/periscope/statuses/4d77a7b52b24d130e158dab8ecfc60971d5b5340"}}}}