GitHub PullRequestReviewCommentEvent at 2014-11-25 16:53:07
Repository: hifi
Actor: ZappoMan
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/comments/20876382","id":20876382,"diff_hunk":"@@ -300,30 +342,39 @@ void OverlayPropertyResultFromScriptValue(const QScriptValue& value, OverlayProp\n }\n \n RayToOverlayIntersectionResult Overlays::findRayIntersection(const PickRay& ray) {\n+    QMap<unsigned int, Overlay*>* overlayMaps[] = { &_overlays3DFront, &_overlays3D };\n+\n     float bestDistance = std::numeric_limits<float>::max();\n     RayToOverlayIntersectionResult result;\n-    QMapIterator<unsigned int, Overlay*> i(_overlays3D);\n-    i.toBack();\n-    while (i.hasPrevious()) {\n-        i.previous();\n-        unsigned int thisID = i.key();\n-        Base3DOverlay* thisOverlay = static_cast<Base3DOverlay*>(i.value());\n-        if (thisOverlay->getVisible() && !thisOverlay->getIgnoreRayIntersection() && thisOverlay->isLoaded()) {\n-            float thisDistance;\n-            BoxFace thisFace;\n-            QString thisExtraInfo;\n-            if (thisOverlay->findRayIntersectionExtraInfo(ray.origin, ray.direction, thisDistance, thisFace, thisExtraInfo)) {\n-                if (thisDistance < bestDistance) {\n-                    bestDistance = thisDistance;\n-                    result.intersects = true;\n-                    result.distance = thisDistance;\n-                    result.face = thisFace;\n-                    result.overlayID = thisID;\n-                    result.intersection = ray.origin + (ray.direction * thisDistance);\n-                    result.extraInfo = thisExtraInfo;\n+    for (int idx = 0; idx < 2; idx++) {","path":"interface/src/ui/overlays/Overlays.cpp","position":141,"original_position":141,"commit_id":"4febc45b6a04d2e9cd2fe3fc7091802de8f30666","original_commit_id":"4febc45b6a04d2e9cd2fe3fc7091802de8f30666","user":{"login":"ZappoMan","id":2093195,"avatar_url":"https://avatars.githubusercontent.com/u/2093195?v=3","gravatar_id":"","url":"https://api.github.com/users/ZappoMan","html_url":"https://github.com/ZappoMan","followers_url":"https://api.github.com/users/ZappoMan/followers","following_url":"https://api.github.com/users/ZappoMan/following{/other_user}","gists_url":"https://api.github.com/users/ZappoMan/gists{/gist_id}","starred_url":"https://api.github.com/users/ZappoMan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZappoMan/subscriptions","organizations_url":"https://api.github.com/users/ZappoMan/orgs","repos_url":"https://api.github.com/users/ZappoMan/repos","events_url":"https://api.github.com/users/ZappoMan/events{/privacy}","received_events_url":"https://api.github.com/users/ZappoMan/received_events","type":"User","site_admin":false},"body":"I'm definitely not a fan of this approach. I think this would be a lot cleaner with a single list.","created_at":"2014-11-25T16:53:07Z","updated_at":"2014-11-25T16:53:07Z","html_url":"https://github.com/highfidelity/hifi/pull/3863#discussion_r20876382","pull_request_url":"https://api.github.com/repos/highfidelity/hifi/pulls/3863","_links":{"self":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/comments/20876382"},"html":{"href":"https://github.com/highfidelity/hifi/pull/3863#discussion_r20876382"},"pull_request":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/3863"}}},"pull_request":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/3863","id":25020655,"html_url":"https://github.com/highfidelity/hifi/pull/3863","diff_url":"https://github.com/highfidelity/hifi/pull/3863.diff","patch_url":"https://github.com/highfidelity/hifi/pull/3863.patch","issue_url":"https://api.github.com/repos/highfidelity/hifi/issues/3863","number":3863,"state":"open","locked":false,"title":"Overlay Front Draw","user":{"login":"huffman","id":167747,"avatar_url":"https://avatars.githubusercontent.com/u/167747?v=3","gravatar_id":"","url":"https://api.github.com/users/huffman","html_url":"https://github.com/huffman","followers_url":"https://api.github.com/users/huffman/followers","following_url":"https://api.github.com/users/huffman/following{/other_user}","gists_url":"https://api.github.com/users/huffman/gists{/gist_id}","starred_url":"https://api.github.com/users/huffman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huffman/subscriptions","organizations_url":"https://api.github.com/users/huffman/orgs","repos_url":"https://api.github.com/users/huffman/repos","events_url":"https://api.github.com/users/huffman/events{/privacy}","received_events_url":"https://api.github.com/users/huffman/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-11-25T16:28:33Z","updated_at":"2014-11-25T16:53:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"31f986042780d1481f827b4391713e50f05e2f83","assignee":{"login":"ZappoMan","id":2093195,"avatar_url":"https://avatars.githubusercontent.com/u/2093195?v=3","gravatar_id":"","url":"https://api.github.com/users/ZappoMan","html_url":"https://github.com/ZappoMan","followers_url":"https://api.github.com/users/ZappoMan/followers","following_url":"https://api.github.com/users/ZappoMan/following{/other_user}","gists_url":"https://api.github.com/users/ZappoMan/gists{/gist_id}","starred_url":"https://api.github.com/users/ZappoMan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZappoMan/subscriptions","organizations_url":"https://api.github.com/users/ZappoMan/orgs","repos_url":"https://api.github.com/users/ZappoMan/repos","events_url":"https://api.github.com/users/ZappoMan/events{/privacy}","received_events_url":"https://api.github.com/users/ZappoMan/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/highfidelity/hifi/pulls/3863/commits","review_comments_url":"https://api.github.com/repos/highfidelity/hifi/pulls/3863/comments","review_comment_url":"https://api.github.com/repos/highfidelity/hifi/pulls/comments/{number}","comments_url":"https://api.github.com/repos/highfidelity/hifi/issues/3863/comments","statuses_url":"https://api.github.com/repos/highfidelity/hifi/statuses/4febc45b6a04d2e9cd2fe3fc7091802de8f30666","head":{"label":"huffman:overlay-front-draw","ref":"overlay-front-draw","sha":"4febc45b6a04d2e9cd2fe3fc7091802de8f30666","user":{"login":"huffman","id":167747,"avatar_url":"https://avatars.githubusercontent.com/u/167747?v=3","gravatar_id":"","url":"https://api.github.com/users/huffman","html_url":"https://github.com/huffman","followers_url":"https://api.github.com/users/huffman/followers","following_url":"https://api.github.com/users/huffman/following{/other_user}","gists_url":"https://api.github.com/users/huffman/gists{/gist_id}","starred_url":"https://api.github.com/users/huffman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huffman/subscriptions","organizations_url":"https://api.github.com/users/huffman/orgs","repos_url":"https://api.github.com/users/huffman/repos","events_url":"https://api.github.com/users/huffman/events{/privacy}","received_events_url":"https://api.github.com/users/huffman/received_events","type":"User","site_admin":false},"repo":{"id":16237479,"name":"hifi","full_name":"huffman/hifi","owner":{"login":"huffman","id":167747,"avatar_url":"https://avatars.githubusercontent.com/u/167747?v=3","gravatar_id":"","url":"https://api.github.com/users/huffman","html_url":"https://github.com/huffman","followers_url":"https://api.github.com/users/huffman/followers","following_url":"https://api.github.com/users/huffman/following{/other_user}","gists_url":"https://api.github.com/users/huffman/gists{/gist_id}","starred_url":"https://api.github.com/users/huffman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huffman/subscriptions","organizations_url":"https://api.github.com/users/huffman/orgs","repos_url":"https://api.github.com/users/huffman/repos","events_url":"https://api.github.com/users/huffman/events{/privacy}","received_events_url":"https://api.github.com/users/huffman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/huffman/hifi","description":"Open, decentralized virtual world using sensors to control avatars and dynamically assigned devices as servers.  San Francisco based startup, we are hiring: http://highfidelity.io/jobs  You can also contribute by doing jobs listed at http://worklist.net/worklist.php","fork":true,"url":"https://api.github.com/repos/huffman/hifi","forks_url":"https://api.github.com/repos/huffman/hifi/forks","keys_url":"https://api.github.com/repos/huffman/hifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/huffman/hifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/huffman/hifi/teams","hooks_url":"https://api.github.com/repos/huffman/hifi/hooks","issue_events_url":"https://api.github.com/repos/huffman/hifi/issues/events{/number}","events_url":"https://api.github.com/repos/huffman/hifi/events","assignees_url":"https://api.github.com/repos/huffman/hifi/assignees{/user}","branches_url":"https://api.github.com/repos/huffman/hifi/branches{/branch}","tags_url":"https://api.github.com/repos/huffman/hifi/tags","blobs_url":"https://api.github.com/repos/huffman/hifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/huffman/hifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/huffman/hifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/huffman/hifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/huffman/hifi/statuses/{sha}","languages_url":"https://api.github.com/repos/huffman/hifi/languages","stargazers_url":"https://api.github.com/repos/huffman/hifi/stargazers","contributors_url":"https://api.github.com/repos/huffman/hifi/contributors","subscribers_url":"https://api.github.com/repos/huffman/hifi/subscribers","subscription_url":"https://api.github.com/repos/huffman/hifi/subscription","commits_url":"https://api.github.com/repos/huffman/hifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/huffman/hifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/huffman/hifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/huffman/hifi/issues/comments/{number}","contents_url":"https://api.github.com/repos/huffman/hifi/contents/{+path}","compare_url":"https://api.github.com/repos/huffman/hifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/huffman/hifi/merges","archive_url":"https://api.github.com/repos/huffman/hifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/huffman/hifi/downloads","issues_url":"https://api.github.com/repos/huffman/hifi/issues{/number}","pulls_url":"https://api.github.com/repos/huffman/hifi/pulls{/number}","milestones_url":"https://api.github.com/repos/huffman/hifi/milestones{/number}","notifications_url":"https://api.github.com/repos/huffman/hifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/huffman/hifi/labels{/name}","releases_url":"https://api.github.com/repos/huffman/hifi/releases{/id}","created_at":"2014-01-25T18:54:32Z","updated_at":"2014-06-25T03:53:28Z","pushed_at":"2014-11-25T16:44:44Z","git_url":"git://github.com/huffman/hifi.git","ssh_url":"git@github.com:huffman/hifi.git","clone_url":"https://github.com/huffman/hifi.git","svn_url":"https://github.com/huffman/hifi","homepage":"http://highfidelity.io","size":124029,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"highfidelity:master","ref":"master","sha":"c5e923f09146aeb8859948835fe0730367414f44","user":{"login":"highfidelity","id":1565370,"avatar_url":"https://avatars.githubusercontent.com/u/1565370?v=3","gravatar_id":"","url":"https://api.github.com/users/highfidelity","html_url":"https://github.com/highfidelity","followers_url":"https://api.github.com/users/highfidelity/followers","following_url":"https://api.github.com/users/highfidelity/following{/other_user}","gists_url":"https://api.github.com/users/highfidelity/gists{/gist_id}","starred_url":"https://api.github.com/users/highfidelity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highfidelity/subscriptions","organizations_url":"https://api.github.com/users/highfidelity/orgs","repos_url":"https://api.github.com/users/highfidelity/repos","events_url":"https://api.github.com/users/highfidelity/events{/privacy}","received_events_url":"https://api.github.com/users/highfidelity/received_events","type":"Organization","site_admin":false},"repo":{"id":5372872,"name":"hifi","full_name":"highfidelity/hifi","owner":{"login":"highfidelity","id":1565370,"avatar_url":"https://avatars.githubusercontent.com/u/1565370?v=3","gravatar_id":"","url":"https://api.github.com/users/highfidelity","html_url":"https://github.com/highfidelity","followers_url":"https://api.github.com/users/highfidelity/followers","following_url":"https://api.github.com/users/highfidelity/following{/other_user}","gists_url":"https://api.github.com/users/highfidelity/gists{/gist_id}","starred_url":"https://api.github.com/users/highfidelity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highfidelity/subscriptions","organizations_url":"https://api.github.com/users/highfidelity/orgs","repos_url":"https://api.github.com/users/highfidelity/repos","events_url":"https://api.github.com/users/highfidelity/events{/privacy}","received_events_url":"https://api.github.com/users/highfidelity/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/highfidelity/hifi","description":"Open, decentralized virtual worlds using sensors to control avatars and dynamically assigned devices as servers.  San Francisco based startup, we are hiring: http://highfidelity.io/jobs  Documentation at http://docs.highfidelity.io  Contribute by reporting bugs & doing jobs on http://worklist.net","fork":false,"url":"https://api.github.com/repos/highfidelity/hifi","forks_url":"https://api.github.com/repos/highfidelity/hifi/forks","keys_url":"https://api.github.com/repos/highfidelity/hifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/highfidelity/hifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/highfidelity/hifi/teams","hooks_url":"https://api.github.com/repos/highfidelity/hifi/hooks","issue_events_url":"https://api.github.com/repos/highfidelity/hifi/issues/events{/number}","events_url":"https://api.github.com/repos/highfidelity/hifi/events","assignees_url":"https://api.github.com/repos/highfidelity/hifi/assignees{/user}","branches_url":"https://api.github.com/repos/highfidelity/hifi/branches{/branch}","tags_url":"https://api.github.com/repos/highfidelity/hifi/tags","blobs_url":"https://api.github.com/repos/highfidelity/hifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/highfidelity/hifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/highfidelity/hifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/highfidelity/hifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/highfidelity/hifi/statuses/{sha}","languages_url":"https://api.github.com/repos/highfidelity/hifi/languages","stargazers_url":"https://api.github.com/repos/highfidelity/hifi/stargazers","contributors_url":"https://api.github.com/repos/highfidelity/hifi/contributors","subscribers_url":"https://api.github.com/repos/highfidelity/hifi/subscribers","subscription_url":"https://api.github.com/repos/highfidelity/hifi/subscription","commits_url":"https://api.github.com/repos/highfidelity/hifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/highfidelity/hifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/highfidelity/hifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/highfidelity/hifi/issues/comments/{number}","contents_url":"https://api.github.com/repos/highfidelity/hifi/contents/{+path}","compare_url":"https://api.github.com/repos/highfidelity/hifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/highfidelity/hifi/merges","archive_url":"https://api.github.com/repos/highfidelity/hifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/highfidelity/hifi/downloads","issues_url":"https://api.github.com/repos/highfidelity/hifi/issues{/number}","pulls_url":"https://api.github.com/repos/highfidelity/hifi/pulls{/number}","milestones_url":"https://api.github.com/repos/highfidelity/hifi/milestones{/number}","notifications_url":"https://api.github.com/repos/highfidelity/hifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/highfidelity/hifi/labels{/name}","releases_url":"https://api.github.com/repos/highfidelity/hifi/releases{/id}","created_at":"2012-08-10T18:26:22Z","updated_at":"2014-11-24T23:42:50Z","pushed_at":"2014-11-24T23:42:50Z","git_url":"git://github.com/highfidelity/hifi.git","ssh_url":"git@github.com:highfidelity/hifi.git","clone_url":"https://github.com/highfidelity/hifi.git","svn_url":"https://github.com/highfidelity/hifi","homepage":"","size":192511,"stargazers_count":214,"watchers_count":214,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":127,"mirror_url":null,"open_issues_count":49,"forks":127,"open_issues":49,"watchers":214,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/3863"},"html":{"href":"https://github.com/highfidelity/hifi/pull/3863"},"issue":{"href":"https://api.github.com/repos/highfidelity/hifi/issues/3863"},"comments":{"href":"https://api.github.com/repos/highfidelity/hifi/issues/3863/comments"},"review_comments":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/3863/comments"},"review_comment":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/3863/commits"},"statuses":{"href":"https://api.github.com/repos/highfidelity/hifi/statuses/4febc45b6a04d2e9cd2fe3fc7091802de8f30666"}}}}