GitHub PullRequestReviewCommentEvent at 2014-10-06 11:47:09
Repository: wagn
Actor: xithan
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/wagn/wagn/pulls/comments/18452177","id":18452177,"diff_hunk":"@@ -24,6 +24,13 @@ def up\n       t.integer :field\n       t.text    :value \n     end\n+    \n+    add_index :card_acts, :card_id, :name=>'card_id_index'\n+    add_index :card_actions, :card_id, :name=>'card_id_index'\n+    add_index :card_actions, [:card_id, :draft], :name=>'card_id_and_draft_index'\n+    add_index :card_actions, :card_act_id, :name=>'card_act_id_index'\n+    add_index :card_changes, :card_action_id, :name=>'card_action_id_index'\n+    add_index :card_changes, [:card_action_id, :field], :name=>'card_action_id_and_field_index'","path":"db/migrate/20140822073704_create_new_revision_tables.rb","position":10,"original_position":10,"commit_id":"c9146694ba25755bffff8e6cdb25875b01142ba9","original_commit_id":"c9146694ba25755bffff8e6cdb25875b01142ba9","user":{"login":"xithan","id":13584,"avatar_url":"https://avatars.githubusercontent.com/u/13584?v=2","gravatar_id":"","url":"https://api.github.com/users/xithan","html_url":"https://github.com/xithan","followers_url":"https://api.github.com/users/xithan/followers","following_url":"https://api.github.com/users/xithan/following{/other_user}","gists_url":"https://api.github.com/users/xithan/gists{/gist_id}","starred_url":"https://api.github.com/users/xithan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xithan/subscriptions","organizations_url":"https://api.github.com/users/xithan/orgs","repos_url":"https://api.github.com/users/xithan/repos","events_url":"https://api.github.com/users/xithan/events{/privacy}","received_events_url":"https://api.github.com/users/xithan/received_events","type":"User","site_admin":false},"body":"Re multiple-column indeces:  \r\nFor almost every action lookup we use the draft column to exclude drafts (see card.rb:19)\r\nThe combination of card_action_id and field in changes is used to get the value of a field at any given state (last_change_on method in action.rb) We need this for diffs in the history view and notifications.\r\n\r\nRe actor_id: At the moment we don't have lookups that search for all actions of a user.","created_at":"2014-10-06T11:47:09Z","updated_at":"2014-10-06T11:47:09Z","html_url":"https://github.com/wagn/wagn/pull/220#discussion_r18452177","pull_request_url":"https://api.github.com/repos/wagn/wagn/pulls/220","_links":{"self":{"href":"https://api.github.com/repos/wagn/wagn/pulls/comments/18452177"},"html":{"href":"https://github.com/wagn/wagn/pull/220#discussion_r18452177"},"pull_request":{"href":"https://api.github.com/repos/wagn/wagn/pulls/220"}}},"pull_request":{"url":"https://api.github.com/repos/wagn/wagn/pulls/220","id":22259294,"html_url":"https://github.com/wagn/wagn/pull/220","diff_url":"https://github.com/wagn/wagn/pull/220.diff","patch_url":"https://github.com/wagn/wagn/pull/220.patch","issue_url":"https://api.github.com/repos/wagn/wagn/issues/220","number":220,"state":"open","locked":false,"title":"added indices and cleaned up notification","user":{"login":"xithan","id":13584,"avatar_url":"https://avatars.githubusercontent.com/u/13584?v=2","gravatar_id":"","url":"https://api.github.com/users/xithan","html_url":"https://github.com/xithan","followers_url":"https://api.github.com/users/xithan/followers","following_url":"https://api.github.com/users/xithan/following{/other_user}","gists_url":"https://api.github.com/users/xithan/gists{/gist_id}","starred_url":"https://api.github.com/users/xithan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xithan/subscriptions","organizations_url":"https://api.github.com/users/xithan/orgs","repos_url":"https://api.github.com/users/xithan/repos","events_url":"https://api.github.com/users/xithan/events{/privacy}","received_events_url":"https://api.github.com/users/xithan/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-10-05T21:29:14Z","updated_at":"2014-10-06T11:47:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e1119041920ef041cba873c91d6074707cd46667","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/wagn/wagn/pulls/220/commits","review_comments_url":"https://api.github.com/repos/wagn/wagn/pulls/220/comments","review_comment_url":"https://api.github.com/repos/wagn/wagn/pulls/comments/{number}","comments_url":"https://api.github.com/repos/wagn/wagn/issues/220/comments","statuses_url":"https://api.github.com/repos/wagn/wagn/statuses/c9146694ba25755bffff8e6cdb25875b01142ba9","head":{"label":"xithan:develop","ref":"develop","sha":"c9146694ba25755bffff8e6cdb25875b01142ba9","user":{"login":"xithan","id":13584,"avatar_url":"https://avatars.githubusercontent.com/u/13584?v=2","gravatar_id":"","url":"https://api.github.com/users/xithan","html_url":"https://github.com/xithan","followers_url":"https://api.github.com/users/xithan/followers","following_url":"https://api.github.com/users/xithan/following{/other_user}","gists_url":"https://api.github.com/users/xithan/gists{/gist_id}","starred_url":"https://api.github.com/users/xithan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xithan/subscriptions","organizations_url":"https://api.github.com/users/xithan/orgs","repos_url":"https://api.github.com/users/xithan/repos","events_url":"https://api.github.com/users/xithan/events{/privacy}","received_events_url":"https://api.github.com/users/xithan/received_events","type":"User","site_admin":false},"repo":{"id":19449327,"name":"wagn","full_name":"xithan/wagn","owner":{"login":"xithan","id":13584,"avatar_url":"https://avatars.githubusercontent.com/u/13584?v=2","gravatar_id":"","url":"https://api.github.com/users/xithan","html_url":"https://github.com/xithan","followers_url":"https://api.github.com/users/xithan/followers","following_url":"https://api.github.com/users/xithan/following{/other_user}","gists_url":"https://api.github.com/users/xithan/gists{/gist_id}","starred_url":"https://api.github.com/users/xithan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xithan/subscriptions","organizations_url":"https://api.github.com/users/xithan/orgs","repos_url":"https://api.github.com/users/xithan/repos","events_url":"https://api.github.com/users/xithan/events{/privacy}","received_events_url":"https://api.github.com/users/xithan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xithan/wagn","description":"Ruby on rails wiki platform for collaborating to build custom web systems","fork":true,"url":"https://api.github.com/repos/xithan/wagn","forks_url":"https://api.github.com/repos/xithan/wagn/forks","keys_url":"https://api.github.com/repos/xithan/wagn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xithan/wagn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xithan/wagn/teams","hooks_url":"https://api.github.com/repos/xithan/wagn/hooks","issue_events_url":"https://api.github.com/repos/xithan/wagn/issues/events{/number}","events_url":"https://api.github.com/repos/xithan/wagn/events","assignees_url":"https://api.github.com/repos/xithan/wagn/assignees{/user}","branches_url":"https://api.github.com/repos/xithan/wagn/branches{/branch}","tags_url":"https://api.github.com/repos/xithan/wagn/tags","blobs_url":"https://api.github.com/repos/xithan/wagn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xithan/wagn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xithan/wagn/git/refs{/sha}","trees_url":"https://api.github.com/repos/xithan/wagn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xithan/wagn/statuses/{sha}","languages_url":"https://api.github.com/repos/xithan/wagn/languages","stargazers_url":"https://api.github.com/repos/xithan/wagn/stargazers","contributors_url":"https://api.github.com/repos/xithan/wagn/contributors","subscribers_url":"https://api.github.com/repos/xithan/wagn/subscribers","subscription_url":"https://api.github.com/repos/xithan/wagn/subscription","commits_url":"https://api.github.com/repos/xithan/wagn/commits{/sha}","git_commits_url":"https://api.github.com/repos/xithan/wagn/git/commits{/sha}","comments_url":"https://api.github.com/repos/xithan/wagn/comments{/number}","issue_comment_url":"https://api.github.com/repos/xithan/wagn/issues/comments/{number}","contents_url":"https://api.github.com/repos/xithan/wagn/contents/{+path}","compare_url":"https://api.github.com/repos/xithan/wagn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xithan/wagn/merges","archive_url":"https://api.github.com/repos/xithan/wagn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xithan/wagn/downloads","issues_url":"https://api.github.com/repos/xithan/wagn/issues{/number}","pulls_url":"https://api.github.com/repos/xithan/wagn/pulls{/number}","milestones_url":"https://api.github.com/repos/xithan/wagn/milestones{/number}","notifications_url":"https://api.github.com/repos/xithan/wagn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xithan/wagn/labels{/name}","releases_url":"https://api.github.com/repos/xithan/wagn/releases{/id}","created_at":"2014-05-05T08:31:06Z","updated_at":"2014-08-26T16:41:50Z","pushed_at":"2014-10-05T21:29:16Z","git_url":"git://github.com/xithan/wagn.git","ssh_url":"git@github.com:xithan/wagn.git","clone_url":"https://github.com/xithan/wagn.git","svn_url":"https://github.com/xithan/wagn","homepage":"http://www.wagn.org","size":46641,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"develop"}},"base":{"label":"wagn:develop","ref":"develop","sha":"a7a3f149e2d491403151ae5556d1bc15e999cae5","user":{"login":"wagn","id":20722,"avatar_url":"https://avatars.githubusercontent.com/u/20722?v=2","gravatar_id":"","url":"https://api.github.com/users/wagn","html_url":"https://github.com/wagn","followers_url":"https://api.github.com/users/wagn/followers","following_url":"https://api.github.com/users/wagn/following{/other_user}","gists_url":"https://api.github.com/users/wagn/gists{/gist_id}","starred_url":"https://api.github.com/users/wagn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wagn/subscriptions","organizations_url":"https://api.github.com/users/wagn/orgs","repos_url":"https://api.github.com/users/wagn/repos","events_url":"https://api.github.com/users/wagn/events{/privacy}","received_events_url":"https://api.github.com/users/wagn/received_events","type":"User","site_admin":false},"repo":{"id":44462,"name":"wagn","full_name":"wagn/wagn","owner":{"login":"wagn","id":20722,"avatar_url":"https://avatars.githubusercontent.com/u/20722?v=2","gravatar_id":"","url":"https://api.github.com/users/wagn","html_url":"https://github.com/wagn","followers_url":"https://api.github.com/users/wagn/followers","following_url":"https://api.github.com/users/wagn/following{/other_user}","gists_url":"https://api.github.com/users/wagn/gists{/gist_id}","starred_url":"https://api.github.com/users/wagn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wagn/subscriptions","organizations_url":"https://api.github.com/users/wagn/orgs","repos_url":"https://api.github.com/users/wagn/repos","events_url":"https://api.github.com/users/wagn/events{/privacy}","received_events_url":"https://api.github.com/users/wagn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wagn/wagn","description":"Ruby on rails wiki platform for collaborating to build custom web systems","fork":false,"url":"https://api.github.com/repos/wagn/wagn","forks_url":"https://api.github.com/repos/wagn/wagn/forks","keys_url":"https://api.github.com/repos/wagn/wagn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wagn/wagn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wagn/wagn/teams","hooks_url":"https://api.github.com/repos/wagn/wagn/hooks","issue_events_url":"https://api.github.com/repos/wagn/wagn/issues/events{/number}","events_url":"https://api.github.com/repos/wagn/wagn/events","assignees_url":"https://api.github.com/repos/wagn/wagn/assignees{/user}","branches_url":"https://api.github.com/repos/wagn/wagn/branches{/branch}","tags_url":"https://api.github.com/repos/wagn/wagn/tags","blobs_url":"https://api.github.com/repos/wagn/wagn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wagn/wagn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wagn/wagn/git/refs{/sha}","trees_url":"https://api.github.com/repos/wagn/wagn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wagn/wagn/statuses/{sha}","languages_url":"https://api.github.com/repos/wagn/wagn/languages","stargazers_url":"https://api.github.com/repos/wagn/wagn/stargazers","contributors_url":"https://api.github.com/repos/wagn/wagn/contributors","subscribers_url":"https://api.github.com/repos/wagn/wagn/subscribers","subscription_url":"https://api.github.com/repos/wagn/wagn/subscription","commits_url":"https://api.github.com/repos/wagn/wagn/commits{/sha}","git_commits_url":"https://api.github.com/repos/wagn/wagn/git/commits{/sha}","comments_url":"https://api.github.com/repos/wagn/wagn/comments{/number}","issue_comment_url":"https://api.github.com/repos/wagn/wagn/issues/comments/{number}","contents_url":"https://api.github.com/repos/wagn/wagn/contents/{+path}","compare_url":"https://api.github.com/repos/wagn/wagn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wagn/wagn/merges","archive_url":"https://api.github.com/repos/wagn/wagn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wagn/wagn/downloads","issues_url":"https://api.github.com/repos/wagn/wagn/issues{/number}","pulls_url":"https://api.github.com/repos/wagn/wagn/pulls{/number}","milestones_url":"https://api.github.com/repos/wagn/wagn/milestones{/number}","notifications_url":"https://api.github.com/repos/wagn/wagn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wagn/wagn/labels{/name}","releases_url":"https://api.github.com/repos/wagn/wagn/releases{/id}","created_at":"2008-08-21T00:36:11Z","updated_at":"2014-10-05T22:43:59Z","pushed_at":"2014-10-02T21:17:31Z","git_url":"git://github.com/wagn/wagn.git","ssh_url":"git@github.com:wagn/wagn.git","clone_url":"https://github.com/wagn/wagn.git","svn_url":"https://github.com/wagn/wagn","homepage":"http://www.wagn.org","size":50697,"stargazers_count":234,"watchers_count":234,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":51,"mirror_url":null,"open_issues_count":5,"forks":51,"open_issues":5,"watchers":234,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wagn/wagn/pulls/220"},"html":{"href":"https://github.com/wagn/wagn/pull/220"},"issue":{"href":"https://api.github.com/repos/wagn/wagn/issues/220"},"comments":{"href":"https://api.github.com/repos/wagn/wagn/issues/220/comments"},"review_comments":{"href":"https://api.github.com/repos/wagn/wagn/pulls/220/comments"},"review_comment":{"href":"https://api.github.com/repos/wagn/wagn/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/wagn/wagn/pulls/220/commits"},"statuses":{"href":"https://api.github.com/repos/wagn/wagn/statuses/c9146694ba25755bffff8e6cdb25875b01142ba9"}}}}