GitHub PullRequestReviewCommentEvent at 2014-02-05 14:54:54
Repository: opm-core
Actor: andlaus
Payload: {"comment":{"url":"https://api.github.com/repos/OPM/opm-core/pulls/comments/9462767","id":9462767,"diff_hunk":"@@ -152,6 +173,71 @@\n         }\n     }\n \n+    // Construct corner-point grid from deck.\n+    void GridManager::initFromDeckCornerpoint(Opm::DeckConstPtr newParserDeck)\n+    {\n+        // Extract data from deck.\n+        // Collect in input struct for preprocessing.\n+        struct grdecl grdecl;\n+        createGrDecl(newParserDeck, grdecl);\n+\n+        // Process grid.\n+        ug_ = create_grid_cornerpoint(&grdecl, 0.0);\n+        if (!ug_) {\n+            OPM_THROW(std::runtime_error, \"Failed to construct grid.\");\n+        }\n+    }\n+\n+    void GridManager::createGrDecl(Opm::DeckConstPtr newParserDeck, struct grdecl &grdecl)","path":"opm/core/grid/GridManager.cpp","position":69,"original_position":69,"commit_id":"55eedd185be3d30a6d5499e82f7b5132f9c01323","original_commit_id":"55eedd185be3d30a6d5499e82f7b5132f9c01323","user":{"login":"andlaus","id":1837735,"avatar_url":"https://gravatar.com/avatar/66363bd380194c65c745a2fd0f1e85ce?d=https%3A%2F%2Fidenticons.github.com%2Fa679b9695e887f8038d15284734a0505.png&r=x","gravatar_id":"66363bd380194c65c745a2fd0f1e85ce","url":"https://api.github.com/users/andlaus","html_url":"https://github.com/andlaus","followers_url":"https://api.github.com/users/andlaus/followers","following_url":"https://api.github.com/users/andlaus/following{/other_user}","gists_url":"https://api.github.com/users/andlaus/gists{/gist_id}","starred_url":"https://api.github.com/users/andlaus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andlaus/subscriptions","organizations_url":"https://api.github.com/users/andlaus/orgs","repos_url":"https://api.github.com/users/andlaus/repos","events_url":"https://api.github.com/users/andlaus/events{/privacy}","received_events_url":"https://api.github.com/users/andlaus/received_events","type":"User","site_admin":false},"body":"I'm a bit indifferent about that capital 'D', but the current standard in opm-parser is to regard all eclipse keywords as a single word. @joakim-hove what do you think?","created_at":"2014-02-05T14:54:54Z","updated_at":"2014-02-05T14:54:54Z","html_url":"https://github.com/OPM/opm-core/pull/471#discussion_r9462767","pull_request_url":"https://api.github.com/repos/OPM/opm-core/pulls/471","_links":{"self":{"href":"https://api.github.com/repos/OPM/opm-core/pulls/comments/9462767"},"html":{"href":"https://github.com/OPM/opm-core/pull/471#discussion_r9462767"},"pull_request":{"href":"https://api.github.com/repos/OPM/opm-core/pulls/471"}}}}