GitHub PullRequestReviewCommentEvent at 2014-09-18 14:37:13
Repository: xtuple
Actor: shackbarth
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/xtuple/xtuple/pulls/comments/17730430","id":17730430,"diff_hunk":"@@ -1,4 +1,8 @@\n create or replace function xt.trylock(oid integer, id integer) returns boolean as $$\n+  var sql = \"select public.trylock($1, $2) as result;\";","path":"enyo-client/database/source/xt/functions/trylock.sql","position":2,"original_position":2,"commit_id":"6f3e82ba3f1b8ec449de7b2d7154eddb55a0be6b","original_commit_id":"878495eac6191e6ebefdcbb3fa7b3377c9637fc1","user":{"login":"shackbarth","id":1056617,"avatar_url":"https://avatars.githubusercontent.com/u/1056617?v=2","gravatar_id":"fd02953a3d31d71dd3a9a4e6ff24137a","url":"https://api.github.com/users/shackbarth","html_url":"https://github.com/shackbarth","followers_url":"https://api.github.com/users/shackbarth/followers","following_url":"https://api.github.com/users/shackbarth/following{/other_user}","gists_url":"https://api.github.com/users/shackbarth/gists{/gist_id}","starred_url":"https://api.github.com/users/shackbarth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shackbarth/subscriptions","organizations_url":"https://api.github.com/users/shackbarth/orgs","repos_url":"https://api.github.com/users/shackbarth/repos","events_url":"https://api.github.com/users/shackbarth/events{/privacy}","received_events_url":"https://api.github.com/users/shackbarth/received_events","type":"User","site_admin":false},"body":"Makes sense, and we can keep this in. Although, `drop_deprecated.sql` has served this purpose pretty well on the web project.","created_at":"2014-09-18T14:37:13Z","updated_at":"2014-09-18T14:37:13Z","html_url":"https://github.com/xtuple/xtuple/pull/1848#discussion_r17730430","pull_request_url":"https://api.github.com/repos/xtuple/xtuple/pulls/1848","_links":{"self":{"href":"https://api.github.com/repos/xtuple/xtuple/pulls/comments/17730430"},"html":{"href":"https://github.com/xtuple/xtuple/pull/1848#discussion_r17730430"},"pull_request":{"href":"https://api.github.com/repos/xtuple/xtuple/pulls/1848"}}},"pull_request":{"url":"https://api.github.com/repos/xtuple/xtuple/pulls/1848","id":21376446,"html_url":"https://github.com/xtuple/xtuple/pull/1848","diff_url":"https://github.com/xtuple/xtuple/pull/1848.diff","patch_url":"https://github.com/xtuple/xtuple/pull/1848.patch","issue_url":"https://api.github.com/repos/xtuple/xtuple/issues/1848","number":1848,"state":"open","locked":false,"title":"issue #24559 - locking with pg 9.3 and web vs qt clients","user":{"login":"gilmoskowitz","id":704111,"avatar_url":"https://avatars.githubusercontent.com/u/704111?v=2","gravatar_id":"cc47324499eafb8470bd77a19366b0c1","url":"https://api.github.com/users/gilmoskowitz","html_url":"https://github.com/gilmoskowitz","followers_url":"https://api.github.com/users/gilmoskowitz/followers","following_url":"https://api.github.com/users/gilmoskowitz/following{/other_user}","gists_url":"https://api.github.com/users/gilmoskowitz/gists{/gist_id}","starred_url":"https://api.github.com/users/gilmoskowitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gilmoskowitz/subscriptions","organizations_url":"https://api.github.com/users/gilmoskowitz/orgs","repos_url":"https://api.github.com/users/gilmoskowitz/repos","events_url":"https://api.github.com/users/gilmoskowitz/events{/privacy}","received_events_url":"https://api.github.com/users/gilmoskowitz/received_events","type":"User","site_admin":false},"body":"This set of commits does several things:\r\n- fix our lock/unlock code to handle changes in the system catalogs for Postgres 9.2\r\n- temporarily short-circuit application locks so the desktop client uses advisory locks while the web client uses the xt.lock table\r\n- make loading a different version of Postgres easier\r\n- address #1846 (install of npm vs npm modules) (required to get a functional vm)\r\n- possibly fix the \"missing plv8\" error (required to get a functional db)\r\n\r\ntested with Postgres 9.1 and 9.3 using a combination of qt and web clients","created_at":"2014-09-17T15:58:14Z","updated_at":"2014-09-18T14:37:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5d326bff46f446689c23a61c5d54ecc6db4a2fbf","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/xtuple/xtuple/pulls/1848/commits","review_comments_url":"https://api.github.com/repos/xtuple/xtuple/pulls/1848/comments","review_comment_url":"https://api.github.com/repos/xtuple/xtuple/pulls/comments/{number}","comments_url":"https://api.github.com/repos/xtuple/xtuple/issues/1848/comments","statuses_url":"https://api.github.com/repos/xtuple/xtuple/statuses/6f3e82ba3f1b8ec449de7b2d7154eddb55a0be6b","head":{"label":"gilmoskowitz:i24559_xtlocks","ref":"i24559_xtlocks","sha":"6f3e82ba3f1b8ec449de7b2d7154eddb55a0be6b","user":{"login":"gilmoskowitz","id":704111,"avatar_url":"https://avatars.githubusercontent.com/u/704111?v=2","gravatar_id":"cc47324499eafb8470bd77a19366b0c1","url":"https://api.github.com/users/gilmoskowitz","html_url":"https://github.com/gilmoskowitz","followers_url":"https://api.github.com/users/gilmoskowitz/followers","following_url":"https://api.github.com/users/gilmoskowitz/following{/other_user}","gists_url":"https://api.github.com/users/gilmoskowitz/gists{/gist_id}","starred_url":"https://api.github.com/users/gilmoskowitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gilmoskowitz/subscriptions","organizations_url":"https://api.github.com/users/gilmoskowitz/orgs","repos_url":"https://api.github.com/users/gilmoskowitz/repos","events_url":"https://api.github.com/users/gilmoskowitz/events{/privacy}","received_events_url":"https://api.github.com/users/gilmoskowitz/received_events","type":"User","site_admin":false},"repo":{"id":19326642,"name":"xtuple","full_name":"gilmoskowitz/xtuple","owner":{"login":"gilmoskowitz","id":704111,"avatar_url":"https://avatars.githubusercontent.com/u/704111?v=2","gravatar_id":"cc47324499eafb8470bd77a19366b0c1","url":"https://api.github.com/users/gilmoskowitz","html_url":"https://github.com/gilmoskowitz","followers_url":"https://api.github.com/users/gilmoskowitz/followers","following_url":"https://api.github.com/users/gilmoskowitz/following{/other_user}","gists_url":"https://api.github.com/users/gilmoskowitz/gists{/gist_id}","starred_url":"https://api.github.com/users/gilmoskowitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gilmoskowitz/subscriptions","organizations_url":"https://api.github.com/users/gilmoskowitz/orgs","repos_url":"https://api.github.com/users/gilmoskowitz/repos","events_url":"https://api.github.com/users/gilmoskowitz/events{/privacy}","received_events_url":"https://api.github.com/users/gilmoskowitz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gilmoskowitz/xtuple","description":"xTuple Web Services and Client","fork":true,"url":"https://api.github.com/repos/gilmoskowitz/xtuple","forks_url":"https://api.github.com/repos/gilmoskowitz/xtuple/forks","keys_url":"https://api.github.com/repos/gilmoskowitz/xtuple/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gilmoskowitz/xtuple/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gilmoskowitz/xtuple/teams","hooks_url":"https://api.github.com/repos/gilmoskowitz/xtuple/hooks","issue_events_url":"https://api.github.com/repos/gilmoskowitz/xtuple/issues/events{/number}","events_url":"https://api.github.com/repos/gilmoskowitz/xtuple/events","assignees_url":"https://api.github.com/repos/gilmoskowitz/xtuple/assignees{/user}","branches_url":"https://api.github.com/repos/gilmoskowitz/xtuple/branches{/branch}","tags_url":"https://api.github.com/repos/gilmoskowitz/xtuple/tags","blobs_url":"https://api.github.com/repos/gilmoskowitz/xtuple/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gilmoskowitz/xtuple/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gilmoskowitz/xtuple/git/refs{/sha}","trees_url":"https://api.github.com/repos/gilmoskowitz/xtuple/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gilmoskowitz/xtuple/statuses/{sha}","languages_url":"https://api.github.com/repos/gilmoskowitz/xtuple/languages","stargazers_url":"https://api.github.com/repos/gilmoskowitz/xtuple/stargazers","contributors_url":"https://api.github.com/repos/gilmoskowitz/xtuple/contributors","subscribers_url":"https://api.github.com/repos/gilmoskowitz/xtuple/subscribers","subscription_url":"https://api.github.com/repos/gilmoskowitz/xtuple/subscription","commits_url":"https://api.github.com/repos/gilmoskowitz/xtuple/commits{/sha}","git_commits_url":"https://api.github.com/repos/gilmoskowitz/xtuple/git/commits{/sha}","comments_url":"https://api.github.com/repos/gilmoskowitz/xtuple/comments{/number}","issue_comment_url":"https://api.github.com/repos/gilmoskowitz/xtuple/issues/comments/{number}","contents_url":"https://api.github.com/repos/gilmoskowitz/xtuple/contents/{+path}","compare_url":"https://api.github.com/repos/gilmoskowitz/xtuple/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gilmoskowitz/xtuple/merges","archive_url":"https://api.github.com/repos/gilmoskowitz/xtuple/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gilmoskowitz/xtuple/downloads","issues_url":"https://api.github.com/repos/gilmoskowitz/xtuple/issues{/number}","pulls_url":"https://api.github.com/repos/gilmoskowitz/xtuple/pulls{/number}","milestones_url":"https://api.github.com/repos/gilmoskowitz/xtuple/milestones{/number}","notifications_url":"https://api.github.com/repos/gilmoskowitz/xtuple/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gilmoskowitz/xtuple/labels{/name}","releases_url":"https://api.github.com/repos/gilmoskowitz/xtuple/releases{/id}","created_at":"2014-04-30T20:42:25Z","updated_at":"2014-07-07T17:30:10Z","pushed_at":"2014-09-18T13:38:49Z","git_url":"git://github.com/gilmoskowitz/xtuple.git","ssh_url":"git@github.com:gilmoskowitz/xtuple.git","clone_url":"https://github.com/gilmoskowitz/xtuple.git","svn_url":"https://github.com/gilmoskowitz/xtuple","homepage":"","size":66360,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xtuple:4_7_x","ref":"4_7_x","sha":"8c5b966332a20878a9f3a63711f35da1dfe5a5a3","user":{"login":"xtuple","id":703922,"avatar_url":"https://avatars.githubusercontent.com/u/703922?v=2","gravatar_id":"50375c477e5e16ff431a203c64fc9c38","url":"https://api.github.com/users/xtuple","html_url":"https://github.com/xtuple","followers_url":"https://api.github.com/users/xtuple/followers","following_url":"https://api.github.com/users/xtuple/following{/other_user}","gists_url":"https://api.github.com/users/xtuple/gists{/gist_id}","starred_url":"https://api.github.com/users/xtuple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xtuple/subscriptions","organizations_url":"https://api.github.com/users/xtuple/orgs","repos_url":"https://api.github.com/users/xtuple/repos","events_url":"https://api.github.com/users/xtuple/events{/privacy}","received_events_url":"https://api.github.com/users/xtuple/received_events","type":"Organization","site_admin":false},"repo":{"id":8138568,"name":"xtuple","full_name":"xtuple/xtuple","owner":{"login":"xtuple","id":703922,"avatar_url":"https://avatars.githubusercontent.com/u/703922?v=2","gravatar_id":"50375c477e5e16ff431a203c64fc9c38","url":"https://api.github.com/users/xtuple","html_url":"https://github.com/xtuple","followers_url":"https://api.github.com/users/xtuple/followers","following_url":"https://api.github.com/users/xtuple/following{/other_user}","gists_url":"https://api.github.com/users/xtuple/gists{/gist_id}","starred_url":"https://api.github.com/users/xtuple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xtuple/subscriptions","organizations_url":"https://api.github.com/users/xtuple/orgs","repos_url":"https://api.github.com/users/xtuple/repos","events_url":"https://api.github.com/users/xtuple/events{/privacy}","received_events_url":"https://api.github.com/users/xtuple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xtuple/xtuple","description":"xTuple is open-source business management software to power your entire company with one system ― accounting, time & expense, CRM, sales, purchasing, manufacturing, inventory and distribution.","fork":false,"url":"https://api.github.com/repos/xtuple/xtuple","forks_url":"https://api.github.com/repos/xtuple/xtuple/forks","keys_url":"https://api.github.com/repos/xtuple/xtuple/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xtuple/xtuple/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xtuple/xtuple/teams","hooks_url":"https://api.github.com/repos/xtuple/xtuple/hooks","issue_events_url":"https://api.github.com/repos/xtuple/xtuple/issues/events{/number}","events_url":"https://api.github.com/repos/xtuple/xtuple/events","assignees_url":"https://api.github.com/repos/xtuple/xtuple/assignees{/user}","branches_url":"https://api.github.com/repos/xtuple/xtuple/branches{/branch}","tags_url":"https://api.github.com/repos/xtuple/xtuple/tags","blobs_url":"https://api.github.com/repos/xtuple/xtuple/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xtuple/xtuple/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xtuple/xtuple/git/refs{/sha}","trees_url":"https://api.github.com/repos/xtuple/xtuple/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xtuple/xtuple/statuses/{sha}","languages_url":"https://api.github.com/repos/xtuple/xtuple/languages","stargazers_url":"https://api.github.com/repos/xtuple/xtuple/stargazers","contributors_url":"https://api.github.com/repos/xtuple/xtuple/contributors","subscribers_url":"https://api.github.com/repos/xtuple/xtuple/subscribers","subscription_url":"https://api.github.com/repos/xtuple/xtuple/subscription","commits_url":"https://api.github.com/repos/xtuple/xtuple/commits{/sha}","git_commits_url":"https://api.github.com/repos/xtuple/xtuple/git/commits{/sha}","comments_url":"https://api.github.com/repos/xtuple/xtuple/comments{/number}","issue_comment_url":"https://api.github.com/repos/xtuple/xtuple/issues/comments/{number}","contents_url":"https://api.github.com/repos/xtuple/xtuple/contents/{+path}","compare_url":"https://api.github.com/repos/xtuple/xtuple/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xtuple/xtuple/merges","archive_url":"https://api.github.com/repos/xtuple/xtuple/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xtuple/xtuple/downloads","issues_url":"https://api.github.com/repos/xtuple/xtuple/issues{/number}","pulls_url":"https://api.github.com/repos/xtuple/xtuple/pulls{/number}","milestones_url":"https://api.github.com/repos/xtuple/xtuple/milestones{/number}","notifications_url":"https://api.github.com/repos/xtuple/xtuple/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xtuple/xtuple/labels{/name}","releases_url":"https://api.github.com/repos/xtuple/xtuple/releases{/id}","created_at":"2013-02-11T13:33:14Z","updated_at":"2014-09-17T05:03:40Z","pushed_at":"2014-09-18T13:55:54Z","git_url":"git://github.com/xtuple/xtuple.git","ssh_url":"git@github.com:xtuple/xtuple.git","clone_url":"https://github.com/xtuple/xtuple.git","svn_url":"https://github.com/xtuple/xtuple","homepage":"http://www.xtuple.com","size":101073,"stargazers_count":47,"watchers_count":47,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":147,"mirror_url":null,"open_issues_count":63,"forks":147,"open_issues":63,"watchers":47,"default_branch":"4_7_x"}},"_links":{"self":{"href":"https://api.github.com/repos/xtuple/xtuple/pulls/1848"},"html":{"href":"https://github.com/xtuple/xtuple/pull/1848"},"issue":{"href":"https://api.github.com/repos/xtuple/xtuple/issues/1848"},"comments":{"href":"https://api.github.com/repos/xtuple/xtuple/issues/1848/comments"},"review_comments":{"href":"https://api.github.com/repos/xtuple/xtuple/pulls/1848/comments"},"review_comment":{"href":"https://api.github.com/repos/xtuple/xtuple/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/xtuple/xtuple/pulls/1848/commits"},"statuses":{"href":"https://api.github.com/repos/xtuple/xtuple/statuses/6f3e82ba3f1b8ec449de7b2d7154eddb55a0be6b"}}}}