GitHub PullRequestReviewCommentEvent at 2014-02-07 11:24:58
Repository: WebODF
Actor: adityab
Payload: {"comment":{"url":"https://api.github.com/repos/kogmbh/WebODF/pulls/comments/9535884","id":9535884,"diff_hunk":"@@ -262,22 +252,29 @@ runtime.loadClass(\"ops.OdtCursor\");\n             lastCompositionData = undefined;\n         }\n \n+        function repositionTrap(cursor) {\n+            var caret = cursor.getNode().firstChild,\n+                doc = cursor.getDocument(),\n+                zoomLevel = doc.getCanvas().getZoomLevel(),\n+                rootRect = domUtils.getBoundingClientRect(doc.getRootNode().parentNode.parentNode.parentNode),\n+                caretRect = domUtils.getBoundingClientRect(caret);\n+\n+            eventTrap.style.top = domUtils.adaptRangeDifferenceToZoomLevel(caretRect.top - rootRect.top, zoomLevel) + 'px';\n+            eventTrap.style.left = domUtils.adaptRangeDifferenceToZoomLevel(caretRect.right - rootRect.left, zoomLevel) + 'px';","path":"webodf/lib/gui/InputMethodEditor.js","position":29,"original_position":29,"commit_id":"5892764e060a1cbc7a8111fd384fe62010c94fb4","original_commit_id":"5892764e060a1cbc7a8111fd384fe62010c94fb4","user":{"login":"adityab","id":591038,"avatar_url":"https://gravatar.com/avatar/61118f801bb9fa9e5643d0f7cc0e8892?d=https%3A%2F%2Fidenticons.github.com%2F3dde0882955b2e920b6dd74cdf26370d.png&r=x","gravatar_id":"61118f801bb9fa9e5643d0f7cc0e8892","url":"https://api.github.com/users/adityab","html_url":"https://github.com/adityab","followers_url":"https://api.github.com/users/adityab/followers","following_url":"https://api.github.com/users/adityab/following{/other_user}","gists_url":"https://api.github.com/users/adityab/gists{/gist_id}","starred_url":"https://api.github.com/users/adityab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adityab/subscriptions","organizations_url":"https://api.github.com/users/adityab/orgs","repos_url":"https://api.github.com/users/adityab/repos","events_url":"https://api.github.com/users/adityab/events{/privacy}","received_events_url":"https://api.github.com/users/adityab/received_events","type":"User","site_admin":false},"body":"I agree 100%, will move the placement logic into CaretManager.","created_at":"2014-02-07T11:24:58Z","updated_at":"2014-02-07T11:24:58Z","html_url":"https://github.com/kogmbh/WebODF/pull/372#discussion_r9535884","pull_request_url":"https://api.github.com/repos/kogmbh/WebODF/pulls/372","_links":{"self":{"href":"https://api.github.com/repos/kogmbh/WebODF/pulls/comments/9535884"},"html":{"href":"https://github.com/kogmbh/WebODF/pull/372#discussion_r9535884"},"pull_request":{"href":"https://api.github.com/repos/kogmbh/WebODF/pulls/372"}}}}