GitHub PullRequestEvent at 2014-09-12 07:50:41
Repository: arethusa
Actor: LFDM
Payload: {"action":"closed","number":392,"pull_request":{"url":"https://api.github.com/repos/latin-language-toolkit/arethusa/pulls/392","id":21137521,"html_url":"https://github.com/latin-language-toolkit/arethusa/pull/392","diff_url":"https://github.com/latin-language-toolkit/arethusa/pull/392.diff","patch_url":"https://github.com/latin-language-toolkit/arethusa/pull/392.patch","issue_url":"https://api.github.com/repos/latin-language-toolkit/arethusa/issues/392","number":392,"state":"closed","locked":false,"title":"Grid layout - layout changes on the fly - refactor general settings handling","user":{"login":"LFDM","id":2204549,"avatar_url":"https://avatars.githubusercontent.com/u/2204549?v=2","gravatar_id":"7a003b461b887f255440d8032f459993","url":"https://api.github.com/users/LFDM","html_url":"https://github.com/LFDM","followers_url":"https://api.github.com/users/LFDM/followers","following_url":"https://api.github.com/users/LFDM/following{/other_user}","gists_url":"https://api.github.com/users/LFDM/gists{/gist_id}","starred_url":"https://api.github.com/users/LFDM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LFDM/subscriptions","organizations_url":"https://api.github.com/users/LFDM/orgs","repos_url":"https://api.github.com/users/LFDM/repos","events_url":"https://api.github.com/users/LFDM/events{/privacy}","received_events_url":"https://api.github.com/users/LFDM/received_events","type":"User","site_admin":false},"body":"We are finally making a step towards a grid layout.\r\n\r\nWe using `angular-gridster` for this, a forked version to be exact to keep our dependencies limited (fe9a202).\r\n\r\nThis is still very much in an experimental phase - a follow-up issue will deal with what has to be done to make  it really effective.\r\n\r\nWork on it also lead to a couple of refactors regarding layouts in general and the `globalSettings` service.\r\n\r\n- Layouts are fully animated now, which just looks awesome when the application starts.\r\n- `globalSettings` can be dynamically defined now and are also streamlined a bit. When the grid is active, additional settings are present for example.\r\n- Settings handling on a plugin level is also much nicer now and handling through a couple of distinct directives (`pluginSettings`, `pluginSetting`). The `plugin` directive can specify if settings should be included in a plugin template (through the attribute `with-setting`) or if a user wants to customize their position and look. The regular sidepanel layout for example still shows them at the top of their respective tab, while the grid layout hides them in a specific section which is also used to drag grid items around. As settings are now passed programmatically it's theoretically also possible that the presence of a plugin A adds a setting to a plugin B.\r\n- Settings objects are generated by a new global helper variable `arethusaClasses` (aliased to `aC`, similar to `arethusaUtil` and `aU`). We've had to deal with small helper classes that we wanted to use across angular modules before. While this breaks the general dependency injection pattern it's probably OK to have a couple of `Arethusa` specific global variables around. This will eventually lead to some refactors in already existing code, where we had to duplicate our helper classes up until now.\r\n\r\n\r\nOne additional important thing is the an event that is fired when all plugins are loaded called `pluginsLoaded`. This makes it easier for us to keep track of when we are done pulling in additional dependencies.","created_at":"2014-09-12T07:50:26Z","updated_at":"2014-09-12T07:50:41Z","closed_at":"2014-09-12T07:50:41Z","merged_at":"2014-09-12T07:50:41Z","merge_commit_sha":"a5a0f931beee94923baba837f76440d8c6d6354a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/latin-language-toolkit/arethusa/pulls/392/commits","review_comments_url":"https://api.github.com/repos/latin-language-toolkit/arethusa/pulls/392/comments","review_comment_url":"https://api.github.com/repos/latin-language-toolkit/arethusa/pulls/comments/{number}","comments_url":"https://api.github.com/repos/latin-language-toolkit/arethusa/issues/392/comments","statuses_url":"https://api.github.com/repos/latin-language-toolkit/arethusa/statuses/d5fd8f67dc64e1799705065facd44096f779daf9","head":{"label":"latin-language-toolkit:unlimited_freedom","ref":"unlimited_freedom","sha":"d5fd8f67dc64e1799705065facd44096f779daf9","user":{"login":"latin-language-toolkit","id":5925061,"avatar_url":"https://avatars.githubusercontent.com/u/5925061?v=2","gravatar_id":"7a003b461b887f255440d8032f459993","url":"https://api.github.com/users/latin-language-toolkit","html_url":"https://github.com/latin-language-toolkit","followers_url":"https://api.github.com/users/latin-language-toolkit/followers","following_url":"https://api.github.com/users/latin-language-toolkit/following{/other_user}","gists_url":"https://api.github.com/users/latin-language-toolkit/gists{/gist_id}","starred_url":"https://api.github.com/users/latin-language-toolkit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/latin-language-toolkit/subscriptions","organizations_url":"https://api.github.com/users/latin-language-toolkit/orgs","repos_url":"https://api.github.com/users/latin-language-toolkit/repos","events_url":"https://api.github.com/users/latin-language-toolkit/events{/privacy}","received_events_url":"https://api.github.com/users/latin-language-toolkit/received_events","type":"Organization","site_admin":false},"repo":{"id":18834513,"name":"arethusa","full_name":"latin-language-toolkit/arethusa","owner":{"login":"latin-language-toolkit","id":5925061,"avatar_url":"https://avatars.githubusercontent.com/u/5925061?v=2","gravatar_id":"7a003b461b887f255440d8032f459993","url":"https://api.github.com/users/latin-language-toolkit","html_url":"https://github.com/latin-language-toolkit","followers_url":"https://api.github.com/users/latin-language-toolkit/followers","following_url":"https://api.github.com/users/latin-language-toolkit/following{/other_user}","gists_url":"https://api.github.com/users/latin-language-toolkit/gists{/gist_id}","starred_url":"https://api.github.com/users/latin-language-toolkit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/latin-language-toolkit/subscriptions","organizations_url":"https://api.github.com/users/latin-language-toolkit/orgs","repos_url":"https://api.github.com/users/latin-language-toolkit/repos","events_url":"https://api.github.com/users/latin-language-toolkit/events{/privacy}","received_events_url":"https://api.github.com/users/latin-language-toolkit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/latin-language-toolkit/arethusa","description":"Arethusa: Annotation Environment","fork":false,"url":"https://api.github.com/repos/latin-language-toolkit/arethusa","forks_url":"https://api.github.com/repos/latin-language-toolkit/arethusa/forks","keys_url":"https://api.github.com/repos/latin-language-toolkit/arethusa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/latin-language-toolkit/arethusa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/latin-language-toolkit/arethusa/teams","hooks_url":"https://api.github.com/repos/latin-language-toolkit/arethusa/hooks","issue_events_url":"https://api.github.com/repos/latin-language-toolkit/arethusa/issues/events{/number}","events_url":"https://api.github.com/repos/latin-language-toolkit/arethusa/events","assignees_url":"https://api.github.com/repos/latin-language-toolkit/arethusa/assignees{/user}","branches_url":"https://api.github.com/repos/latin-language-toolkit/arethusa/branches{/branch}","tags_url":"https://api.github.com/repos/latin-language-toolkit/arethusa/tags","blobs_url":"https://api.github.com/repos/latin-language-toolkit/arethusa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/latin-language-toolkit/arethusa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/latin-language-toolkit/arethusa/git/refs{/sha}","trees_url":"https://api.github.com/repos/latin-language-toolkit/arethusa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/latin-language-toolkit/arethusa/statuses/{sha}","languages_url":"https://api.github.com/repos/latin-language-toolkit/arethusa/languages","stargazers_url":"https://api.github.com/repos/latin-language-toolkit/arethusa/stargazers","contributors_url":"https://api.github.com/repos/latin-language-toolkit/arethusa/contributors","subscribers_url":"https://api.github.com/repos/latin-language-toolkit/arethusa/subscribers","subscription_url":"https://api.github.com/repos/latin-language-toolkit/arethusa/subscription","commits_url":"https://api.github.com/repos/latin-language-toolkit/arethusa/commits{/sha}","git_commits_url":"https://api.github.com/repos/latin-language-toolkit/arethusa/git/commits{/sha}","comments_url":"https://api.github.com/repos/latin-language-toolkit/arethusa/comments{/number}","issue_comment_url":"https://api.github.com/repos/latin-language-toolkit/arethusa/issues/comments/{number}","contents_url":"https://api.github.com/repos/latin-language-toolkit/arethusa/contents/{+path}","compare_url":"https://api.github.com/repos/latin-language-toolkit/arethusa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/latin-language-toolkit/arethusa/merges","archive_url":"https://api.github.com/repos/latin-language-toolkit/arethusa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/latin-language-toolkit/arethusa/downloads","issues_url":"https://api.github.com/repos/latin-language-toolkit/arethusa/issues{/number}","pulls_url":"https://api.github.com/repos/latin-language-toolkit/arethusa/pulls{/number}","milestones_url":"https://api.github.com/repos/latin-language-toolkit/arethusa/milestones{/number}","notifications_url":"https://api.github.com/repos/latin-language-toolkit/arethusa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/latin-language-toolkit/arethusa/labels{/name}","releases_url":"https://api.github.com/repos/latin-language-toolkit/arethusa/releases{/id}","created_at":"2014-04-16T09:40:20Z","updated_at":"2014-09-04T16:30:42Z","pushed_at":"2014-09-12T07:50:41Z","git_url":"git://github.com/latin-language-toolkit/arethusa.git","ssh_url":"git@github.com:latin-language-toolkit/arethusa.git","clone_url":"https://github.com/latin-language-toolkit/arethusa.git","svn_url":"https://github.com/latin-language-toolkit/arethusa","homepage":"","size":14137,"stargazers_count":6,"watchers_count":6,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":2,"mirror_url":null,"open_issues_count":66,"forks":2,"open_issues":66,"watchers":6,"default_branch":"master"}},"base":{"label":"latin-language-toolkit:master","ref":"master","sha":"196496c23d1981cd7d44bf2ef9608d23ee0fc503","user":{"login":"latin-language-toolkit","id":5925061,"avatar_url":"https://avatars.githubusercontent.com/u/5925061?v=2","gravatar_id":"7a003b461b887f255440d8032f459993","url":"https://api.github.com/users/latin-language-toolkit","html_url":"https://github.com/latin-language-toolkit","followers_url":"https://api.github.com/users/latin-language-toolkit/followers","following_url":"https://api.github.com/users/latin-language-toolkit/following{/other_user}","gists_url":"https://api.github.com/users/latin-language-toolkit/gists{/gist_id}","starred_url":"https://api.github.com/users/latin-language-toolkit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/latin-language-toolkit/subscriptions","organizations_url":"https://api.github.com/users/latin-language-toolkit/orgs","repos_url":"https://api.github.com/users/latin-language-toolkit/repos","events_url":"https://api.github.com/users/latin-language-toolkit/events{/privacy}","received_events_url":"https://api.github.com/users/latin-language-toolkit/received_events","type":"Organization","site_admin":false},"repo":{"id":18834513,"name":"arethusa","full_name":"latin-language-toolkit/arethusa","owner":{"login":"latin-language-toolkit","id":5925061,"avatar_url":"https://avatars.githubusercontent.com/u/5925061?v=2","gravatar_id":"7a003b461b887f255440d8032f459993","url":"https://api.github.com/users/latin-language-toolkit","html_url":"https://github.com/latin-language-toolkit","followers_url":"https://api.github.com/users/latin-language-toolkit/followers","following_url":"https://api.github.com/users/latin-language-toolkit/following{/other_user}","gists_url":"https://api.github.com/users/latin-language-toolkit/gists{/gist_id}","starred_url":"https://api.github.com/users/latin-language-toolkit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/latin-language-toolkit/subscriptions","organizations_url":"https://api.github.com/users/latin-language-toolkit/orgs","repos_url":"https://api.github.com/users/latin-language-toolkit/repos","events_url":"https://api.github.com/users/latin-language-toolkit/events{/privacy}","received_events_url":"https://api.github.com/users/latin-language-toolkit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/latin-language-toolkit/arethusa","description":"Arethusa: Annotation Environment","fork":false,"url":"https://api.github.com/repos/latin-language-toolkit/arethusa","forks_url":"https://api.github.com/repos/latin-language-toolkit/arethusa/forks","keys_url":"https://api.github.com/repos/latin-language-toolkit/arethusa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/latin-language-toolkit/arethusa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/latin-language-toolkit/arethusa/teams","hooks_url":"https://api.github.com/repos/latin-language-toolkit/arethusa/hooks","issue_events_url":"https://api.github.com/repos/latin-language-toolkit/arethusa/issues/events{/number}","events_url":"https://api.github.com/repos/latin-language-toolkit/arethusa/events","assignees_url":"https://api.github.com/repos/latin-language-toolkit/arethusa/assignees{/user}","branches_url":"https://api.github.com/repos/latin-language-toolkit/arethusa/branches{/branch}","tags_url":"https://api.github.com/repos/latin-language-toolkit/arethusa/tags","blobs_url":"https://api.github.com/repos/latin-language-toolkit/arethusa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/latin-language-toolkit/arethusa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/latin-language-toolkit/arethusa/git/refs{/sha}","trees_url":"https://api.github.com/repos/latin-language-toolkit/arethusa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/latin-language-toolkit/arethusa/statuses/{sha}","languages_url":"https://api.github.com/repos/latin-language-toolkit/arethusa/languages","stargazers_url":"https://api.github.com/repos/latin-language-toolkit/arethusa/stargazers","contributors_url":"https://api.github.com/repos/latin-language-toolkit/arethusa/contributors","subscribers_url":"https://api.github.com/repos/latin-language-toolkit/arethusa/subscribers","subscription_url":"https://api.github.com/repos/latin-language-toolkit/arethusa/subscription","commits_url":"https://api.github.com/repos/latin-language-toolkit/arethusa/commits{/sha}","git_commits_url":"https://api.github.com/repos/latin-language-toolkit/arethusa/git/commits{/sha}","comments_url":"https://api.github.com/repos/latin-language-toolkit/arethusa/comments{/number}","issue_comment_url":"https://api.github.com/repos/latin-language-toolkit/arethusa/issues/comments/{number}","contents_url":"https://api.github.com/repos/latin-language-toolkit/arethusa/contents/{+path}","compare_url":"https://api.github.com/repos/latin-language-toolkit/arethusa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/latin-language-toolkit/arethusa/merges","archive_url":"https://api.github.com/repos/latin-language-toolkit/arethusa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/latin-language-toolkit/arethusa/downloads","issues_url":"https://api.github.com/repos/latin-language-toolkit/arethusa/issues{/number}","pulls_url":"https://api.github.com/repos/latin-language-toolkit/arethusa/pulls{/number}","milestones_url":"https://api.github.com/repos/latin-language-toolkit/arethusa/milestones{/number}","notifications_url":"https://api.github.com/repos/latin-language-toolkit/arethusa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/latin-language-toolkit/arethusa/labels{/name}","releases_url":"https://api.github.com/repos/latin-language-toolkit/arethusa/releases{/id}","created_at":"2014-04-16T09:40:20Z","updated_at":"2014-09-04T16:30:42Z","pushed_at":"2014-09-12T07:50:41Z","git_url":"git://github.com/latin-language-toolkit/arethusa.git","ssh_url":"git@github.com:latin-language-toolkit/arethusa.git","clone_url":"https://github.com/latin-language-toolkit/arethusa.git","svn_url":"https://github.com/latin-language-toolkit/arethusa","homepage":"","size":14137,"stargazers_count":6,"watchers_count":6,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":2,"mirror_url":null,"open_issues_count":66,"forks":2,"open_issues":66,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/latin-language-toolkit/arethusa/pulls/392"},"html":{"href":"https://github.com/latin-language-toolkit/arethusa/pull/392"},"issue":{"href":"https://api.github.com/repos/latin-language-toolkit/arethusa/issues/392"},"comments":{"href":"https://api.github.com/repos/latin-language-toolkit/arethusa/issues/392/comments"},"review_comments":{"href":"https://api.github.com/repos/latin-language-toolkit/arethusa/pulls/392/comments"},"review_comment":{"href":"https://api.github.com/repos/latin-language-toolkit/arethusa/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/latin-language-toolkit/arethusa/pulls/392/commits"},"statuses":{"href":"https://api.github.com/repos/latin-language-toolkit/arethusa/statuses/d5fd8f67dc64e1799705065facd44096f779daf9"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"LFDM","id":2204549,"avatar_url":"https://avatars.githubusercontent.com/u/2204549?v=2","gravatar_id":"7a003b461b887f255440d8032f459993","url":"https://api.github.com/users/LFDM","html_url":"https://github.com/LFDM","followers_url":"https://api.github.com/users/LFDM/followers","following_url":"https://api.github.com/users/LFDM/following{/other_user}","gists_url":"https://api.github.com/users/LFDM/gists{/gist_id}","starred_url":"https://api.github.com/users/LFDM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LFDM/subscriptions","organizations_url":"https://api.github.com/users/LFDM/orgs","repos_url":"https://api.github.com/users/LFDM/repos","events_url":"https://api.github.com/users/LFDM/events{/privacy}","received_events_url":"https://api.github.com/users/LFDM/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":97,"additions":726,"deletions":112,"changed_files":53}}