GitHub PullRequestReviewCommentEvent at 2014-08-29 18:32:06
Repository: bijection
Actor: ianoc
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/twitter/bijection/pulls/comments/16913373","id":16913373,"diff_hunk":"@@ -66,19 +78,26 @@ object StringBijectionLaws extends Properties(\"StringBijections\")\n   }\n \n   // This is trivially a bijection if it injective\n-  property(\"URL -> String\") = isInjection[URL, String]\n+  property(\"URL -> String\") {\n+    isInjection[URL, String]\n+  }\n \n-  property(\"rts through StringJoinBijection\") =\n+  property(\"rts through StringJoinBijection\") {\n     forAll { (sep: String, xs: List[String]) =>\n       val sjBij = StringJoinBijection(sep)\n       val iter = xs.toIterable\n-      (!iter.exists(_.contains(sep))) ==> (iter == rt(iter)(sjBij))\n+      whenever(!iter.exists(_.contains(sep))) {\n+        assert(iter == rt(iter)(sjBij))\n+      }\n     }\n+  }\n \n   //implicit val listOpt = StringJoinBijection.viaContainer[Int, List[Int]]()\n   //property(\"viaCollection List[Int] -> Option[String]\") =\n   //roundTrips[List[Int], Option[String @@ Rep[List[Int]]]]()\n   // implicit val listStr = StringJoinBijection.nonEmptyValues[Int, List[Int]]()","path":"bijection-core/src/test/scala/com/twitter/bijection/StringBijectionLaws.scala","position":78,"original_position":78,"commit_id":"bdda5b6b95e7d3eb25ddffed636a737aa20b858b","original_commit_id":"397a97bd6988393a905e3706c2452aa9855b6e43","user":{"login":"ianoc","id":446652,"avatar_url":"https://avatars.githubusercontent.com/u/446652?v=2","gravatar_id":"36ce3c50fa3c11de597342acef7d93af","url":"https://api.github.com/users/ianoc","html_url":"https://github.com/ianoc","followers_url":"https://api.github.com/users/ianoc/followers","following_url":"https://api.github.com/users/ianoc/following{/other_user}","gists_url":"https://api.github.com/users/ianoc/gists{/gist_id}","starred_url":"https://api.github.com/users/ianoc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianoc/subscriptions","organizations_url":"https://api.github.com/users/ianoc/orgs","repos_url":"https://api.github.com/users/ianoc/repos","events_url":"https://api.github.com/users/ianoc/events{/privacy}","received_events_url":"https://api.github.com/users/ianoc/received_events","type":"User","site_admin":false},"body":"Yeah don't really know. We could file some issues against these to re-activate or delete?","created_at":"2014-08-29T18:32:06Z","updated_at":"2014-08-29T18:32:06Z","html_url":"https://github.com/twitter/bijection/pull/176#discussion_r16913373","pull_request_url":"https://api.github.com/repos/twitter/bijection/pulls/176","_links":{"self":{"href":"https://api.github.com/repos/twitter/bijection/pulls/comments/16913373"},"html":{"href":"https://github.com/twitter/bijection/pull/176#discussion_r16913373"},"pull_request":{"href":"https://api.github.com/repos/twitter/bijection/pulls/176"}}},"pull_request":{"url":"https://api.github.com/repos/twitter/bijection/pulls/176","id":20476233,"html_url":"https://github.com/twitter/bijection/pull/176","diff_url":"https://github.com/twitter/bijection/pull/176.diff","patch_url":"https://github.com/twitter/bijection/pull/176.patch","issue_url":"https://api.github.com/repos/twitter/bijection/issues/176","number":176,"state":"open","locked":false,"title":"Moves to 2.10.x as the default and to scalatest","user":{"login":"ianoc","id":446652,"avatar_url":"https://avatars.githubusercontent.com/u/446652?v=2","gravatar_id":"36ce3c50fa3c11de597342acef7d93af","url":"https://api.github.com/users/ianoc","html_url":"https://github.com/ianoc","followers_url":"https://api.github.com/users/ianoc/followers","following_url":"https://api.github.com/users/ianoc/following{/other_user}","gists_url":"https://api.github.com/users/ianoc/gists{/gist_id}","starred_url":"https://api.github.com/users/ianoc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianoc/subscriptions","organizations_url":"https://api.github.com/users/ianoc/orgs","repos_url":"https://api.github.com/users/ianoc/repos","events_url":"https://api.github.com/users/ianoc/events{/privacy}","received_events_url":"https://api.github.com/users/ianoc/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-08-29T00:42:25Z","updated_at":"2014-08-29T18:32:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"41eb9e1a9c3e0d742fb8fa58a63bfd730842e628","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/twitter/bijection/pulls/176/commits","review_comments_url":"https://api.github.com/repos/twitter/bijection/pulls/176/comments","review_comment_url":"https://api.github.com/repos/twitter/bijection/pulls/comments/{number}","comments_url":"https://api.github.com/repos/twitter/bijection/issues/176/comments","statuses_url":"https://api.github.com/repos/twitter/bijection/statuses/bdda5b6b95e7d3eb25ddffed636a737aa20b858b","head":{"label":"twitter:bijection-scalatest_2.10","ref":"bijection-scalatest_2.10","sha":"bdda5b6b95e7d3eb25ddffed636a737aa20b858b","user":{"login":"twitter","id":50278,"avatar_url":"https://avatars.githubusercontent.com/u/50278?v=2","gravatar_id":"2f4a8254d032a8ec5e4c48d461e54fcc","url":"https://api.github.com/users/twitter","html_url":"https://github.com/twitter","followers_url":"https://api.github.com/users/twitter/followers","following_url":"https://api.github.com/users/twitter/following{/other_user}","gists_url":"https://api.github.com/users/twitter/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter/subscriptions","organizations_url":"https://api.github.com/users/twitter/orgs","repos_url":"https://api.github.com/users/twitter/repos","events_url":"https://api.github.com/users/twitter/events{/privacy}","received_events_url":"https://api.github.com/users/twitter/received_events","type":"Organization","site_admin":false},"repo":{"id":7380994,"name":"bijection","full_name":"twitter/bijection","owner":{"login":"twitter","id":50278,"avatar_url":"https://avatars.githubusercontent.com/u/50278?v=2","gravatar_id":"2f4a8254d032a8ec5e4c48d461e54fcc","url":"https://api.github.com/users/twitter","html_url":"https://github.com/twitter","followers_url":"https://api.github.com/users/twitter/followers","following_url":"https://api.github.com/users/twitter/following{/other_user}","gists_url":"https://api.github.com/users/twitter/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter/subscriptions","organizations_url":"https://api.github.com/users/twitter/orgs","repos_url":"https://api.github.com/users/twitter/repos","events_url":"https://api.github.com/users/twitter/events{/privacy}","received_events_url":"https://api.github.com/users/twitter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/twitter/bijection","description":"Reversible conversions between types","fork":false,"url":"https://api.github.com/repos/twitter/bijection","forks_url":"https://api.github.com/repos/twitter/bijection/forks","keys_url":"https://api.github.com/repos/twitter/bijection/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twitter/bijection/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twitter/bijection/teams","hooks_url":"https://api.github.com/repos/twitter/bijection/hooks","issue_events_url":"https://api.github.com/repos/twitter/bijection/issues/events{/number}","events_url":"https://api.github.com/repos/twitter/bijection/events","assignees_url":"https://api.github.com/repos/twitter/bijection/assignees{/user}","branches_url":"https://api.github.com/repos/twitter/bijection/branches{/branch}","tags_url":"https://api.github.com/repos/twitter/bijection/tags","blobs_url":"https://api.github.com/repos/twitter/bijection/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twitter/bijection/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twitter/bijection/git/refs{/sha}","trees_url":"https://api.github.com/repos/twitter/bijection/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twitter/bijection/statuses/{sha}","languages_url":"https://api.github.com/repos/twitter/bijection/languages","stargazers_url":"https://api.github.com/repos/twitter/bijection/stargazers","contributors_url":"https://api.github.com/repos/twitter/bijection/contributors","subscribers_url":"https://api.github.com/repos/twitter/bijection/subscribers","subscription_url":"https://api.github.com/repos/twitter/bijection/subscription","commits_url":"https://api.github.com/repos/twitter/bijection/commits{/sha}","git_commits_url":"https://api.github.com/repos/twitter/bijection/git/commits{/sha}","comments_url":"https://api.github.com/repos/twitter/bijection/comments{/number}","issue_comment_url":"https://api.github.com/repos/twitter/bijection/issues/comments/{number}","contents_url":"https://api.github.com/repos/twitter/bijection/contents/{+path}","compare_url":"https://api.github.com/repos/twitter/bijection/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twitter/bijection/merges","archive_url":"https://api.github.com/repos/twitter/bijection/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twitter/bijection/downloads","issues_url":"https://api.github.com/repos/twitter/bijection/issues{/number}","pulls_url":"https://api.github.com/repos/twitter/bijection/pulls{/number}","milestones_url":"https://api.github.com/repos/twitter/bijection/milestones{/number}","notifications_url":"https://api.github.com/repos/twitter/bijection/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twitter/bijection/labels{/name}","releases_url":"https://api.github.com/repos/twitter/bijection/releases{/id}","created_at":"2012-12-30T22:22:25Z","updated_at":"2014-08-29T00:04:52Z","pushed_at":"2014-08-29T18:09:49Z","git_url":"git://github.com/twitter/bijection.git","ssh_url":"git@github.com:twitter/bijection.git","clone_url":"https://github.com/twitter/bijection.git","svn_url":"https://github.com/twitter/bijection","homepage":"","size":3183,"stargazers_count":190,"watchers_count":190,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":34,"mirror_url":null,"open_issues_count":22,"forks":34,"open_issues":22,"watchers":190,"default_branch":"develop"}},"base":{"label":"twitter:develop","ref":"develop","sha":"b68c56635e57bb8daf189237394e49071c2a0316","user":{"login":"twitter","id":50278,"avatar_url":"https://avatars.githubusercontent.com/u/50278?v=2","gravatar_id":"2f4a8254d032a8ec5e4c48d461e54fcc","url":"https://api.github.com/users/twitter","html_url":"https://github.com/twitter","followers_url":"https://api.github.com/users/twitter/followers","following_url":"https://api.github.com/users/twitter/following{/other_user}","gists_url":"https://api.github.com/users/twitter/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter/subscriptions","organizations_url":"https://api.github.com/users/twitter/orgs","repos_url":"https://api.github.com/users/twitter/repos","events_url":"https://api.github.com/users/twitter/events{/privacy}","received_events_url":"https://api.github.com/users/twitter/received_events","type":"Organization","site_admin":false},"repo":{"id":7380994,"name":"bijection","full_name":"twitter/bijection","owner":{"login":"twitter","id":50278,"avatar_url":"https://avatars.githubusercontent.com/u/50278?v=2","gravatar_id":"2f4a8254d032a8ec5e4c48d461e54fcc","url":"https://api.github.com/users/twitter","html_url":"https://github.com/twitter","followers_url":"https://api.github.com/users/twitter/followers","following_url":"https://api.github.com/users/twitter/following{/other_user}","gists_url":"https://api.github.com/users/twitter/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter/subscriptions","organizations_url":"https://api.github.com/users/twitter/orgs","repos_url":"https://api.github.com/users/twitter/repos","events_url":"https://api.github.com/users/twitter/events{/privacy}","received_events_url":"https://api.github.com/users/twitter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/twitter/bijection","description":"Reversible conversions between types","fork":false,"url":"https://api.github.com/repos/twitter/bijection","forks_url":"https://api.github.com/repos/twitter/bijection/forks","keys_url":"https://api.github.com/repos/twitter/bijection/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twitter/bijection/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twitter/bijection/teams","hooks_url":"https://api.github.com/repos/twitter/bijection/hooks","issue_events_url":"https://api.github.com/repos/twitter/bijection/issues/events{/number}","events_url":"https://api.github.com/repos/twitter/bijection/events","assignees_url":"https://api.github.com/repos/twitter/bijection/assignees{/user}","branches_url":"https://api.github.com/repos/twitter/bijection/branches{/branch}","tags_url":"https://api.github.com/repos/twitter/bijection/tags","blobs_url":"https://api.github.com/repos/twitter/bijection/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twitter/bijection/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twitter/bijection/git/refs{/sha}","trees_url":"https://api.github.com/repos/twitter/bijection/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twitter/bijection/statuses/{sha}","languages_url":"https://api.github.com/repos/twitter/bijection/languages","stargazers_url":"https://api.github.com/repos/twitter/bijection/stargazers","contributors_url":"https://api.github.com/repos/twitter/bijection/contributors","subscribers_url":"https://api.github.com/repos/twitter/bijection/subscribers","subscription_url":"https://api.github.com/repos/twitter/bijection/subscription","commits_url":"https://api.github.com/repos/twitter/bijection/commits{/sha}","git_commits_url":"https://api.github.com/repos/twitter/bijection/git/commits{/sha}","comments_url":"https://api.github.com/repos/twitter/bijection/comments{/number}","issue_comment_url":"https://api.github.com/repos/twitter/bijection/issues/comments/{number}","contents_url":"https://api.github.com/repos/twitter/bijection/contents/{+path}","compare_url":"https://api.github.com/repos/twitter/bijection/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twitter/bijection/merges","archive_url":"https://api.github.com/repos/twitter/bijection/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twitter/bijection/downloads","issues_url":"https://api.github.com/repos/twitter/bijection/issues{/number}","pulls_url":"https://api.github.com/repos/twitter/bijection/pulls{/number}","milestones_url":"https://api.github.com/repos/twitter/bijection/milestones{/number}","notifications_url":"https://api.github.com/repos/twitter/bijection/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twitter/bijection/labels{/name}","releases_url":"https://api.github.com/repos/twitter/bijection/releases{/id}","created_at":"2012-12-30T22:22:25Z","updated_at":"2014-08-29T00:04:52Z","pushed_at":"2014-08-29T18:09:49Z","git_url":"git://github.com/twitter/bijection.git","ssh_url":"git@github.com:twitter/bijection.git","clone_url":"https://github.com/twitter/bijection.git","svn_url":"https://github.com/twitter/bijection","homepage":"","size":3183,"stargazers_count":190,"watchers_count":190,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":34,"mirror_url":null,"open_issues_count":22,"forks":34,"open_issues":22,"watchers":190,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/twitter/bijection/pulls/176"},"html":{"href":"https://github.com/twitter/bijection/pull/176"},"issue":{"href":"https://api.github.com/repos/twitter/bijection/issues/176"},"comments":{"href":"https://api.github.com/repos/twitter/bijection/issues/176/comments"},"review_comments":{"href":"https://api.github.com/repos/twitter/bijection/pulls/176/comments"},"review_comment":{"href":"https://api.github.com/repos/twitter/bijection/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/twitter/bijection/pulls/176/commits"},"statuses":{"href":"https://api.github.com/repos/twitter/bijection/statuses/bdda5b6b95e7d3eb25ddffed636a737aa20b858b"}}}}