GitHub PullRequestReviewCommentEvent at 2014-08-12 22:15:08
Repository: katello
Actor: jlsherrill
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/Katello/katello/pulls/comments/16146545","id":16146545,"diff_hunk":"@@ -0,0 +1,64 @@\n+#\n+# Copyright 2014 Red Hat, Inc.\n+#\n+# This software is licensed to you under the GNU General Public\n+# License as published by the Free Software Foundation; either version\n+# 2 of the License (GPLv2) or (at your option) any later version.\n+# There is NO WARRANTY for this software, express or implied,\n+# including the implied warranties of MERCHANTABILITY,\n+# NON-INFRINGEMENT, or FITNESS FOR A PARTICULAR PURPOSE. You should\n+# have received a copy of GPLv2 along with this software; if not, see\n+# http://www.gnu.org/licenses/old-licenses/gpl-2.0.txt.\n+\n+module Actions\n+  module Katello\n+    module Repository\n+      class Update < Actions::EntryAction\n+\n+        def plan(repository, repo_params)\n+          repository.disable_auto_reindex!\n+          action_subject repository\n+          repository.update_attributes!(repo_params)\n+          if (::Katello.config.use_cp && ::Katello.config.use_pulp)\n+            plan_action(::Actions::Candlepin::Product::ContentUpdate,\n+                        :content_id => repository.content_id,\n+                        :name => repository.name,\n+                        :content_url => ::Katello::Glue::Pulp::Repos.custom_content_path(repository.product, repository.label),\n+                        :gpg_url => repository.yum_gpg_key_url,\n+                        :label => repository.custom_content_label,\n+                        :type => repository.content_type,\n+                        :vendor => ::Katello::Provider::CUSTOM)","path":"app/lib/actions/katello/repository/update.rb","position":30,"original_position":30,"commit_id":"d6f0fe56ea8478018e68e719c22d5739bbdee62e","original_commit_id":"d6f0fe56ea8478018e68e719c22d5739bbdee62e","user":{"login":"jlsherrill","id":395077,"avatar_url":"https://avatars.githubusercontent.com/u/395077?v=2","gravatar_id":"a27ea9bdeb657a47afc54313238e93d3","url":"https://api.github.com/users/jlsherrill","html_url":"https://github.com/jlsherrill","followers_url":"https://api.github.com/users/jlsherrill/followers","following_url":"https://api.github.com/users/jlsherrill/following{/other_user}","gists_url":"https://api.github.com/users/jlsherrill/gists{/gist_id}","starred_url":"https://api.github.com/users/jlsherrill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlsherrill/subscriptions","organizations_url":"https://api.github.com/users/jlsherrill/orgs","repos_url":"https://api.github.com/users/jlsherrill/repos","events_url":"https://api.github.com/users/jlsherrill/events{/privacy}","received_events_url":"https://api.github.com/users/jlsherrill/received_events","type":"User","site_admin":false},"body":"Also the ContentUpdate action doesn't look like it takes a vendor input","created_at":"2014-08-12T22:15:08Z","updated_at":"2014-08-12T22:15:08Z","html_url":"https://github.com/Katello/katello/pull/4564#discussion_r16146545","pull_request_url":"https://api.github.com/repos/Katello/katello/pulls/4564","_links":{"self":{"href":"https://api.github.com/repos/Katello/katello/pulls/comments/16146545"},"html":{"href":"https://github.com/Katello/katello/pull/4564#discussion_r16146545"},"pull_request":{"href":"https://api.github.com/repos/Katello/katello/pulls/4564"}}},"pull_request":{"url":"https://api.github.com/repos/Katello/katello/pulls/4564","id":19623780,"html_url":"https://github.com/Katello/katello/pull/4564","diff_url":"https://github.com/Katello/katello/pull/4564.diff","patch_url":"https://github.com/Katello/katello/pull/4564.patch","issue_url":"https://api.github.com/repos/Katello/katello/issues/4564","number":4564,"state":"open","title":"Fixes #6297 - delayed jobs is dead, long live foreman-tasks","user":{"login":"iNecas","id":190443,"avatar_url":"https://avatars.githubusercontent.com/u/190443?v=2","gravatar_id":"08cb45efffe7995a6bcbb904e9066f79","url":"https://api.github.com/users/iNecas","html_url":"https://github.com/iNecas","followers_url":"https://api.github.com/users/iNecas/followers","following_url":"https://api.github.com/users/iNecas/following{/other_user}","gists_url":"https://api.github.com/users/iNecas/gists{/gist_id}","starred_url":"https://api.github.com/users/iNecas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iNecas/subscriptions","organizations_url":"https://api.github.com/users/iNecas/orgs","repos_url":"https://api.github.com/users/iNecas/repos","events_url":"https://api.github.com/users/iNecas/events{/privacy}","received_events_url":"https://api.github.com/users/iNecas/received_events","type":"User","site_admin":false},"body":"This pull request finishes the conversion of the async tasks based on delayed\njobs to the foreman tasks. The changes include:\n\n* #6296 - dynflowize auto-attach\n* #6304 - remove apply default info feature from the code for now\n* #6182 - dynflowize repository update (thanks @aruzicka)\n* #6297 - dynflowize content upload and after-sync callbacks\n* #6297 - remove unused code around delayed jobs\n* #6297 - updating the gemspec and rpm spec files to not use katello-jobs\n          and use foreman-tasks service instead (already available\n          in the foreman-tasks gem)\n* #6283 - use dynflow API to figure out if the foreman tasks is running or not\n\nSorry for the longish pull-request but since the changes need some testing, it\nmight be easier to test all at once, than everything separately, when all we\nneed at the end is not having to use delayed jobs.\n\nThere should not be any changes in the behavior of the app, except\nforeman-tasks service instead of katello-jobs, the ping returning\n'foreman_tasks' instead of 'katello_jobs  and repo synchronizations and\npackage uploads tracked in foreman tasks.","created_at":"2014-08-11T20:01:08Z","updated_at":"2014-08-12T22:15:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"34c87f537d18ffdf7888115eff583000dbd4cbf8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Katello/katello/pulls/4564/commits","review_comments_url":"https://api.github.com/repos/Katello/katello/pulls/4564/comments","review_comment_url":"https://api.github.com/repos/Katello/katello/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Katello/katello/issues/4564/comments","statuses_url":"https://api.github.com/repos/Katello/katello/statuses/d6f0fe56ea8478018e68e719c22d5739bbdee62e","head":{"label":"iNecas:issue/6297","ref":"issue/6297","sha":"d6f0fe56ea8478018e68e719c22d5739bbdee62e","user":{"login":"iNecas","id":190443,"avatar_url":"https://avatars.githubusercontent.com/u/190443?v=2","gravatar_id":"08cb45efffe7995a6bcbb904e9066f79","url":"https://api.github.com/users/iNecas","html_url":"https://github.com/iNecas","followers_url":"https://api.github.com/users/iNecas/followers","following_url":"https://api.github.com/users/iNecas/following{/other_user}","gists_url":"https://api.github.com/users/iNecas/gists{/gist_id}","starred_url":"https://api.github.com/users/iNecas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iNecas/subscriptions","organizations_url":"https://api.github.com/users/iNecas/orgs","repos_url":"https://api.github.com/users/iNecas/repos","events_url":"https://api.github.com/users/iNecas/events{/privacy}","received_events_url":"https://api.github.com/users/iNecas/received_events","type":"User","site_admin":false},"repo":{"id":4063892,"name":"katello","full_name":"iNecas/katello","owner":{"login":"iNecas","id":190443,"avatar_url":"https://avatars.githubusercontent.com/u/190443?v=2","gravatar_id":"08cb45efffe7995a6bcbb904e9066f79","url":"https://api.github.com/users/iNecas","html_url":"https://github.com/iNecas","followers_url":"https://api.github.com/users/iNecas/followers","following_url":"https://api.github.com/users/iNecas/following{/other_user}","gists_url":"https://api.github.com/users/iNecas/gists{/gist_id}","starred_url":"https://api.github.com/users/iNecas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iNecas/subscriptions","organizations_url":"https://api.github.com/users/iNecas/orgs","repos_url":"https://api.github.com/users/iNecas/repos","events_url":"https://api.github.com/users/iNecas/events{/privacy}","received_events_url":"https://api.github.com/users/iNecas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/iNecas/katello","description":"Katello integrates open source systems management tools into a single solution for controlling the lifecycle of your machines.","fork":true,"url":"https://api.github.com/repos/iNecas/katello","forks_url":"https://api.github.com/repos/iNecas/katello/forks","keys_url":"https://api.github.com/repos/iNecas/katello/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iNecas/katello/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iNecas/katello/teams","hooks_url":"https://api.github.com/repos/iNecas/katello/hooks","issue_events_url":"https://api.github.com/repos/iNecas/katello/issues/events{/number}","events_url":"https://api.github.com/repos/iNecas/katello/events","assignees_url":"https://api.github.com/repos/iNecas/katello/assignees{/user}","branches_url":"https://api.github.com/repos/iNecas/katello/branches{/branch}","tags_url":"https://api.github.com/repos/iNecas/katello/tags","blobs_url":"https://api.github.com/repos/iNecas/katello/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iNecas/katello/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iNecas/katello/git/refs{/sha}","trees_url":"https://api.github.com/repos/iNecas/katello/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iNecas/katello/statuses/{sha}","languages_url":"https://api.github.com/repos/iNecas/katello/languages","stargazers_url":"https://api.github.com/repos/iNecas/katello/stargazers","contributors_url":"https://api.github.com/repos/iNecas/katello/contributors","subscribers_url":"https://api.github.com/repos/iNecas/katello/subscribers","subscription_url":"https://api.github.com/repos/iNecas/katello/subscription","commits_url":"https://api.github.com/repos/iNecas/katello/commits{/sha}","git_commits_url":"https://api.github.com/repos/iNecas/katello/git/commits{/sha}","comments_url":"https://api.github.com/repos/iNecas/katello/comments{/number}","issue_comment_url":"https://api.github.com/repos/iNecas/katello/issues/comments/{number}","contents_url":"https://api.github.com/repos/iNecas/katello/contents/{+path}","compare_url":"https://api.github.com/repos/iNecas/katello/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iNecas/katello/merges","archive_url":"https://api.github.com/repos/iNecas/katello/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iNecas/katello/downloads","issues_url":"https://api.github.com/repos/iNecas/katello/issues{/number}","pulls_url":"https://api.github.com/repos/iNecas/katello/pulls{/number}","milestones_url":"https://api.github.com/repos/iNecas/katello/milestones{/number}","notifications_url":"https://api.github.com/repos/iNecas/katello/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iNecas/katello/labels{/name}","releases_url":"https://api.github.com/repos/iNecas/katello/releases{/id}","created_at":"2012-04-18T13:19:11Z","updated_at":"2014-06-19T07:00:12Z","pushed_at":"2014-08-12T14:56:29Z","git_url":"git://github.com/iNecas/katello.git","ssh_url":"git@github.com:iNecas/katello.git","clone_url":"https://github.com/iNecas/katello.git","svn_url":"https://github.com/iNecas/katello","homepage":"katello.org","size":68665,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"Katello:master","ref":"master","sha":"590388270fabb76bbfaa28fe059894b2ca197182","user":{"login":"Katello","id":1316386,"avatar_url":"https://avatars.githubusercontent.com/u/1316386?v=2","gravatar_id":"e9275d7a67c7ce8d173df524050b724c","url":"https://api.github.com/users/Katello","html_url":"https://github.com/Katello","followers_url":"https://api.github.com/users/Katello/followers","following_url":"https://api.github.com/users/Katello/following{/other_user}","gists_url":"https://api.github.com/users/Katello/gists{/gist_id}","starred_url":"https://api.github.com/users/Katello/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Katello/subscriptions","organizations_url":"https://api.github.com/users/Katello/orgs","repos_url":"https://api.github.com/users/Katello/repos","events_url":"https://api.github.com/users/Katello/events{/privacy}","received_events_url":"https://api.github.com/users/Katello/received_events","type":"Organization","site_admin":false},"repo":{"id":4007018,"name":"katello","full_name":"Katello/katello","owner":{"login":"Katello","id":1316386,"avatar_url":"https://avatars.githubusercontent.com/u/1316386?v=2","gravatar_id":"e9275d7a67c7ce8d173df524050b724c","url":"https://api.github.com/users/Katello","html_url":"https://github.com/Katello","followers_url":"https://api.github.com/users/Katello/followers","following_url":"https://api.github.com/users/Katello/following{/other_user}","gists_url":"https://api.github.com/users/Katello/gists{/gist_id}","starred_url":"https://api.github.com/users/Katello/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Katello/subscriptions","organizations_url":"https://api.github.com/users/Katello/orgs","repos_url":"https://api.github.com/users/Katello/repos","events_url":"https://api.github.com/users/Katello/events{/privacy}","received_events_url":"https://api.github.com/users/Katello/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Katello/katello","description":"Katello integrates open source systems management tools into a single solution for controlling the lifecycle of your machines.","fork":false,"url":"https://api.github.com/repos/Katello/katello","forks_url":"https://api.github.com/repos/Katello/katello/forks","keys_url":"https://api.github.com/repos/Katello/katello/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Katello/katello/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Katello/katello/teams","hooks_url":"https://api.github.com/repos/Katello/katello/hooks","issue_events_url":"https://api.github.com/repos/Katello/katello/issues/events{/number}","events_url":"https://api.github.com/repos/Katello/katello/events","assignees_url":"https://api.github.com/repos/Katello/katello/assignees{/user}","branches_url":"https://api.github.com/repos/Katello/katello/branches{/branch}","tags_url":"https://api.github.com/repos/Katello/katello/tags","blobs_url":"https://api.github.com/repos/Katello/katello/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Katello/katello/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Katello/katello/git/refs{/sha}","trees_url":"https://api.github.com/repos/Katello/katello/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Katello/katello/statuses/{sha}","languages_url":"https://api.github.com/repos/Katello/katello/languages","stargazers_url":"https://api.github.com/repos/Katello/katello/stargazers","contributors_url":"https://api.github.com/repos/Katello/katello/contributors","subscribers_url":"https://api.github.com/repos/Katello/katello/subscribers","subscription_url":"https://api.github.com/repos/Katello/katello/subscription","commits_url":"https://api.github.com/repos/Katello/katello/commits{/sha}","git_commits_url":"https://api.github.com/repos/Katello/katello/git/commits{/sha}","comments_url":"https://api.github.com/repos/Katello/katello/comments{/number}","issue_comment_url":"https://api.github.com/repos/Katello/katello/issues/comments/{number}","contents_url":"https://api.github.com/repos/Katello/katello/contents/{+path}","compare_url":"https://api.github.com/repos/Katello/katello/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Katello/katello/merges","archive_url":"https://api.github.com/repos/Katello/katello/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Katello/katello/downloads","issues_url":"https://api.github.com/repos/Katello/katello/issues{/number}","pulls_url":"https://api.github.com/repos/Katello/katello/pulls{/number}","milestones_url":"https://api.github.com/repos/Katello/katello/milestones{/number}","notifications_url":"https://api.github.com/repos/Katello/katello/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Katello/katello/labels{/name}","releases_url":"https://api.github.com/repos/Katello/katello/releases{/id}","created_at":"2012-04-12T16:59:08Z","updated_at":"2014-08-03T22:35:52Z","pushed_at":"2014-08-12T20:55:27Z","git_url":"git://github.com/Katello/katello.git","ssh_url":"git@github.com:Katello/katello.git","clone_url":"https://github.com/Katello/katello.git","svn_url":"https://github.com/Katello/katello","homepage":"katello.org","size":242598,"stargazers_count":133,"watchers_count":133,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":90,"mirror_url":null,"open_issues_count":108,"forks":90,"open_issues":108,"watchers":133,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Katello/katello/pulls/4564"},"html":{"href":"https://github.com/Katello/katello/pull/4564"},"issue":{"href":"https://api.github.com/repos/Katello/katello/issues/4564"},"comments":{"href":"https://api.github.com/repos/Katello/katello/issues/4564/comments"},"review_comments":{"href":"https://api.github.com/repos/Katello/katello/pulls/4564/comments"},"review_comment":{"href":"https://api.github.com/repos/Katello/katello/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Katello/katello/pulls/4564/commits"},"statuses":{"href":"https://api.github.com/repos/Katello/katello/statuses/d6f0fe56ea8478018e68e719c22d5739bbdee62e"}}}}