GitHub PushEvent at 2014-07-31 03:18:06
Repository: rspec-core
Actor: myronmarston
Payload: {"shas":[["7e11746c9105c7470c47f6cfda87cdfef027e63b","52209c90f35d73dd46a1c7f0ffd9de57ec10a9e5@gmail.com","Refactors the ordering mechanism to use strategy objects","Andy Lindeman",false],["a755aa6c00363aca3d8777b71535feb902c6b5ca","52209c90f35d73dd46a1c7f0ffd9de57ec10a9e5@gmail.com","Example groups can override the default ordering.\n\nAlso OrderingRegistry needs docs.","Andy Lindeman",false],["e177c1dde3ab5a81639780210a703e4266c0bb62","aaf4c61ddcc5e8a2dabede0f3b482cd9aea9434d@jonrowe.co.uk","1.8.7 doesnt have define_singleton_method","Jon Rowe",false],["24c2889909ac90ffd13cddb64e2f7c4aa62fa300","fd109d70772fe3df3ddfb042c9ca965a43dc0441@gmail.com","Combine ordering logic into one file.\n\n- There's no need for so many tiny files.\n- 1.9 has known perf issues with require,\n  so doing one require instead of 4\n  should speed up pert a bit.\n- This keeps the ordering logic all in one\n  small (< 100 LOC) file.","Myron Marston",false],["4564d1135f99c50537d0ce7977c25d60bda1f2f6","fd109d70772fe3df3ddfb042c9ca965a43dc0441@gmail.com","Extract srand allowance.","Myron Marston",false],["7e74b946a6a3346a101058eb0c12e89161498e15","fd109d70772fe3df3ddfb042c9ca965a43dc0441@gmail.com","Remove unneeded code that came from Sam's earlier PR.","Myron Marston",false],["f88f3c24c12bc65a3417b97bf54086ec2258d3e0","fd109d70772fe3df3ddfb042c9ca965a43dc0441@gmail.com","Remove stray, confusing comments.","Myron Marston",false],["54691e8f6e6a462598416d9da7d4298000f4d86f","fd109d70772fe3df3ddfb042c9ca965a43dc0441@gmail.com","2.0 shuffles differently.\n\nThis spec failed on 2.0. This change makes it\nmore resilient.","Myron Marston",false],["87760bd43f95b331c25c85378b504b3dcdebb5c5","fd109d70772fe3df3ddfb042c9ca965a43dc0441@gmail.com","Refactor ordering registry.\n\n- Use two of them (one for examples, one for groups),\n  rather than having a single one with separate,\n  duplicated methods for examples vs groups.\n- Rename `resolve_example_ordering` to `#[]`. It has the\n  semantics of a hash lookup, after all.\n- Add `global_ordering` for the case where that is\n  explicitly needed.","Myron Marston",false],["60263d666747d182cf17eae280a084f62fb78661","fd109d70772fe3df3ddfb042c9ca965a43dc0441@gmail.com","Change dependency injection of configuration.\n\nTo me, it makes more sense to pass it to `Random.new`\nand to retain it as instance state on that object.\nInjecting it in the `order` method is a little odd,\nas it complicates the `#order` interface for all the\nother strategies, even those that don't use the\nconfiguration at all.","Myron Marston",false],["cc318d0aad541a34c748206c594ea1a15013dfa9","fd109d70772fe3df3ddfb042c9ca965a43dc0441@gmail.com","Improve expectation.","Myron Marston",false],["65b735ef9291f686c97eb7ffb83b809e1bf7267f","fd109d70772fe3df3ddfb042c9ca965a43dc0441@gmail.com","Improve isolation of order specs.\n\n* Cleanup extra files created by individual specs.\n* Change to the aruba tmp dir before running the\n  command.  This is important so that it doesn't\n  pick up options in our `.rspec` file.","Myron Marston",false],["fd994ab3163852b0b5da543fe0fcd9ce6d2b7029","fd109d70772fe3df3ddfb042c9ca965a43dc0441@gmail.com","Remove inconsistent #order and #randomize? config methods.\n\n* Examples and groups can be ordered differently.\n* Individual groups can be ordered differently.\n\nAs such, a global `order` reader method doesn't\nmake a lot of sense (although, assigning the global\ndefault via `#order=` still does, I think).\n\nAlso:\n\n* This exposed that the ordering force logic\n  (e.g. to ensure CLI `--order rand` takes\n  precedence over `RSpec.configure`) didn't\n  work properly since it simply ensured `order`\n  returned the forced option but did not ensure\n  the global ordering was set properly.  I've\n  fixed this.\n* Don't clear the seed when setting the order to\n  default. An individual example group may still\n  be run in random order and will need the seed.\n  There's really no reason to clear it.\n* Base our decision of whether or not to print\n  the seed at the end of the run on whether or\n  not the random strategy ever got used, rather\n  than whether or not `random` is the global\n  strategy. If only one example group used the\n  random strategy we would want it to print,\n  but the old logic would not have done so.","Myron Marston",false],["a1fb7e3085e3f1fe6bda3d8d028cd937c4b43798","fd109d70772fe3df3ddfb042c9ca965a43dc0441@gmail.com","Refactor: extract Ordering::ConfigurationManager.\n\nThere's enough ordering config options that\nthey should be grouped into their own object.","Myron Marston",false],["d4e05fdd66bed8795459a63c7ca67b4f1a3d3564","fd109d70772fe3df3ddfb042c9ca965a43dc0441@gmail.com","Refactor: refine how we pass config state to Reporter.\n\nIt's more natural to just pass the config instance in\nthe initializer, rather than passing the seed to\n`report` and referencing `RSpec.configuration`.","Myron Marston",false],["7e94b8161ed8f9c1f9e2602fd74cf757124306d2","fd109d70772fe3df3ddfb042c9ca965a43dc0441@gmail.com","Allow custom orderings to be registered.","Myron Marston",false],["537bfdd1458ba8a000851c6858122d10b0eecf80","fd109d70772fe3df3ddfb042c9ca965a43dc0441@gmail.com","Use doc formatter when running individual files.","Myron Marston",false],["06049c217fa44f024349ca7d9a81f138207521f7","fd109d70772fe3df3ddfb042c9ca965a43dc0441@gmail.com","Use groups vs example strategy for groups vs examples.\n\nWe were wrongly always using the example strategy\nfor both groups and examples.","Myron Marston",false],["a500b52a77499772b150df331463b02b01c5510c","fd109d70772fe3df3ddfb042c9ca965a43dc0441@gmail.com","Improve formatting.","Myron Marston",false],["6e6f57bc1a5426907f93b2679e33fea8615e27a2","fd109d70772fe3df3ddfb042c9ca965a43dc0441@gmail.com","Change #[] to #fetch.\n\nFor the case of an unrecognized order symbol,\nI want to have it take a fallback block\n(like the semantics of Hash#fetch), but #[]\ncan't accept a block so we have to change the API.","Myron Marston",false]],"size":1000,"ref":"refs/heads/1589-fixed-up","head":"37f169aa85b8cf77debc357960fb66f1936be369"}