GitHub PullRequestEvent at 2014-06-14 05:40:29
Repository: openmrs-contrib-modulus-ui
Actor: elliottwilliams
Payload: {"action":"opened","number":6,"pull_request":{"url":"https://api.github.com/repos/openmrs/openmrs-contrib-modulus-ui/pulls/6","id":17140559,"html_url":"https://github.com/openmrs/openmrs-contrib-modulus-ui/pull/6","diff_url":"https://github.com/openmrs/openmrs-contrib-modulus-ui/pull/6.diff","patch_url":"https://github.com/openmrs/openmrs-contrib-modulus-ui/pull/6.patch","issue_url":"https://api.github.com/repos/openmrs/openmrs-contrib-modulus-ui/issues/6","number":6,"state":"open","title":"MOD-56: Authentication and Authorization UI","user":{"login":"elliottwilliams","id":910198,"avatar_url":"https://avatars.githubusercontent.com/u/910198?","gravatar_id":"9671c7e02ed9235482bc758105e37a21","url":"https://api.github.com/users/elliottwilliams","html_url":"https://github.com/elliottwilliams","followers_url":"https://api.github.com/users/elliottwilliams/followers","following_url":"https://api.github.com/users/elliottwilliams/following{/other_user}","gists_url":"https://api.github.com/users/elliottwilliams/gists{/gist_id}","starred_url":"https://api.github.com/users/elliottwilliams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elliottwilliams/subscriptions","organizations_url":"https://api.github.com/users/elliottwilliams/orgs","repos_url":"https://api.github.com/users/elliottwilliams/repos","events_url":"https://api.github.com/users/elliottwilliams/events{/privacy}","received_events_url":"https://api.github.com/users/elliottwilliams/received_events","type":"User","site_admin":false},"body":"The result of a lot work. Key components include:\r\n\r\n- AuthCtrl and AuthService, which handle interacting with the login system and managing login state, respectively.\r\n- AuthSuccessEndpointCtrl and auth-success.html, a popup window that receives the \"success\" callback from an OAuth provider, extracts the token, and passes it to AuthService.\r\n- Login button and dropdown in application nav.\r\n- A switch to ui-router instead of ng-route, which occurred because it was proving impossible to restrict access to protected resources using ng-route (and because the internet tells me ui-router is better for large projects)\r\n- Unit tests for the controllers and services in this code\r\n\r\n","created_at":"2014-06-14T05:40:29Z","updated_at":"2014-06-14T05:40:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openmrs/openmrs-contrib-modulus-ui/pulls/6/commits","review_comments_url":"https://api.github.com/repos/openmrs/openmrs-contrib-modulus-ui/pulls/6/comments","review_comment_url":"https://api.github.com/repos/openmrs/openmrs-contrib-modulus-ui/pulls/comments/{number}","comments_url":"https://api.github.com/repos/openmrs/openmrs-contrib-modulus-ui/issues/6/comments","statuses_url":"https://api.github.com/repos/openmrs/openmrs-contrib-modulus-ui/statuses/4a153268c78c0780e815cd43e482079f51496834","head":{"label":"openmrs:MOD-56","ref":"MOD-56","sha":"4a153268c78c0780e815cd43e482079f51496834","user":{"login":"openmrs","id":860776,"avatar_url":"https://avatars.githubusercontent.com/u/860776?","gravatar_id":"69dec0e05ef979a50cf839fad032afe0","url":"https://api.github.com/users/openmrs","html_url":"https://github.com/openmrs","followers_url":"https://api.github.com/users/openmrs/followers","following_url":"https://api.github.com/users/openmrs/following{/other_user}","gists_url":"https://api.github.com/users/openmrs/gists{/gist_id}","starred_url":"https://api.github.com/users/openmrs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openmrs/subscriptions","organizations_url":"https://api.github.com/users/openmrs/orgs","repos_url":"https://api.github.com/users/openmrs/repos","events_url":"https://api.github.com/users/openmrs/events{/privacy}","received_events_url":"https://api.github.com/users/openmrs/received_events","type":"Organization","site_admin":false},"repo":{"id":17212549,"name":"openmrs-contrib-modulus-ui","full_name":"openmrs/openmrs-contrib-modulus-ui","owner":{"login":"openmrs","id":860776,"avatar_url":"https://avatars.githubusercontent.com/u/860776?","gravatar_id":"69dec0e05ef979a50cf839fad032afe0","url":"https://api.github.com/users/openmrs","html_url":"https://github.com/openmrs","followers_url":"https://api.github.com/users/openmrs/followers","following_url":"https://api.github.com/users/openmrs/following{/other_user}","gists_url":"https://api.github.com/users/openmrs/gists{/gist_id}","starred_url":"https://api.github.com/users/openmrs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openmrs/subscriptions","organizations_url":"https://api.github.com/users/openmrs/orgs","repos_url":"https://api.github.com/users/openmrs/repos","events_url":"https://api.github.com/users/openmrs/events{/privacy}","received_events_url":"https://api.github.com/users/openmrs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openmrs/openmrs-contrib-modulus-ui","description":"Web app & user interface for Modulus","fork":false,"url":"https://api.github.com/repos/openmrs/openmrs-contrib-modulus-ui","forks_url":"https://api.github.com/repos/openmrs/openmrs-contrib-modulus-ui/forks","keys_url":"https://api.github.com/repos/openmrs/openmrs-contrib-modulus-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openmrs/openmrs-contrib-modulus-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openmrs/openmrs-contrib-modulus-ui/teams","hooks_url":"https://api.github.com/repos/openmrs/openmrs-contrib-modulus-ui/hooks","issue_events_url":"https://api.github.com/repos/openmrs/openmrs-contrib-modulus-ui/issues/events{/number}","events_url":"https://api.github.com/repos/openmrs/openmrs-contrib-modulus-ui/events","assignees_url":"https://api.github.com/repos/openmrs/openmrs-contrib-modulus-ui/assignees{/user}","branches_url":"https://api.github.com/repos/openmrs/openmrs-contrib-modulus-ui/branches{/branch}","tags_url":"https://api.github.com/repos/openmrs/openmrs-contrib-modulus-ui/tags","blobs_url":"https://api.github.com/repos/openmrs/openmrs-contrib-modulus-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openmrs/openmrs-contrib-modulus-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openmrs/openmrs-contrib-modulus-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/openmrs/openmrs-contrib-modulus-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openmrs/openmrs-contrib-modulus-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/openmrs/openmrs-contrib-modulus-ui/languages","stargazers_url":"https://api.github.com/repos/openmrs/openmrs-contrib-modulus-ui/stargazers","contributors_url":"https://api.github.com/repos/openmrs/openmrs-contrib-modulus-ui/contributors","subscribers_url":"https://api.github.com/repos/openmrs/openmrs-contrib-modulus-ui/subscribers","subscription_url":"https://api.github.com/repos/openmrs/openmrs-contrib-modulus-ui/subscription","commits_url":"https://api.github.com/repos/openmrs/openmrs-contrib-modulus-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/openmrs/openmrs-contrib-modulus-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/openmrs/openmrs-contrib-modulus-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/openmrs/openmrs-contrib-modulus-ui/issues/comments/{number}","contents_url":"https://api.github.com/repos/openmrs/openmrs-contrib-modulus-ui/contents/{+path}","compare_url":"https://api.github.com/repos/openmrs/openmrs-contrib-modulus-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openmrs/openmrs-contrib-modulus-ui/merges","archive_url":"https://api.github.com/repos/openmrs/openmrs-contrib-modulus-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openmrs/openmrs-contrib-modulus-ui/downloads","issues_url":"https://api.github.com/repos/openmrs/openmrs-contrib-modulus-ui/issues{/number}","pulls_url":"https://api.github.com/repos/openmrs/openmrs-contrib-modulus-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/openmrs/openmrs-contrib-modulus-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/openmrs/openmrs-contrib-modulus-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openmrs/openmrs-contrib-modulus-ui/labels{/name}","releases_url":"https://api.github.com/repos/openmrs/openmrs-contrib-modulus-ui/releases{/id}","created_at":"2014-02-26T14:09:58Z","updated_at":"2014-06-14T05:40:29Z","pushed_at":"2014-06-14T05:34:36Z","git_url":"git://github.com/openmrs/openmrs-contrib-modulus-ui.git","ssh_url":"git@github.com:openmrs/openmrs-contrib-modulus-ui.git","clone_url":"https://github.com/openmrs/openmrs-contrib-modulus-ui.git","svn_url":"https://github.com/openmrs/openmrs-contrib-modulus-ui","homepage":"http://modules.openmrs.org","size":31166,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":3,"mirror_url":null,"open_issues_count":1,"forks":3,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"openmrs:master","ref":"master","sha":"e7ed1145e122883b3e263fbdebca9d399a72a9cd","user":{"login":"openmrs","id":860776,"avatar_url":"https://avatars.githubusercontent.com/u/860776?","gravatar_id":"69dec0e05ef979a50cf839fad032afe0","url":"https://api.github.com/users/openmrs","html_url":"https://github.com/openmrs","followers_url":"https://api.github.com/users/openmrs/followers","following_url":"https://api.github.com/users/openmrs/following{/other_user}","gists_url":"https://api.github.com/users/openmrs/gists{/gist_id}","starred_url":"https://api.github.com/users/openmrs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openmrs/subscriptions","organizations_url":"https://api.github.com/users/openmrs/orgs","repos_url":"https://api.github.com/users/openmrs/repos","events_url":"https://api.github.com/users/openmrs/events{/privacy}","received_events_url":"https://api.github.com/users/openmrs/received_events","type":"Organization","site_admin":false},"repo":{"id":17212549,"name":"openmrs-contrib-modulus-ui","full_name":"openmrs/openmrs-contrib-modulus-ui","owner":{"login":"openmrs","id":860776,"avatar_url":"https://avatars.githubusercontent.com/u/860776?","gravatar_id":"69dec0e05ef979a50cf839fad032afe0","url":"https://api.github.com/users/openmrs","html_url":"https://github.com/openmrs","followers_url":"https://api.github.com/users/openmrs/followers","following_url":"https://api.github.com/users/openmrs/following{/other_user}","gists_url":"https://api.github.com/users/openmrs/gists{/gist_id}","starred_url":"https://api.github.com/users/openmrs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openmrs/subscriptions","organizations_url":"https://api.github.com/users/openmrs/orgs","repos_url":"https://api.github.com/users/openmrs/repos","events_url":"https://api.github.com/users/openmrs/events{/privacy}","received_events_url":"https://api.github.com/users/openmrs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openmrs/openmrs-contrib-modulus-ui","description":"Web app & user interface for Modulus","fork":false,"url":"https://api.github.com/repos/openmrs/openmrs-contrib-modulus-ui","forks_url":"https://api.github.com/repos/openmrs/openmrs-contrib-modulus-ui/forks","keys_url":"https://api.github.com/repos/openmrs/openmrs-contrib-modulus-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openmrs/openmrs-contrib-modulus-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openmrs/openmrs-contrib-modulus-ui/teams","hooks_url":"https://api.github.com/repos/openmrs/openmrs-contrib-modulus-ui/hooks","issue_events_url":"https://api.github.com/repos/openmrs/openmrs-contrib-modulus-ui/issues/events{/number}","events_url":"https://api.github.com/repos/openmrs/openmrs-contrib-modulus-ui/events","assignees_url":"https://api.github.com/repos/openmrs/openmrs-contrib-modulus-ui/assignees{/user}","branches_url":"https://api.github.com/repos/openmrs/openmrs-contrib-modulus-ui/branches{/branch}","tags_url":"https://api.github.com/repos/openmrs/openmrs-contrib-modulus-ui/tags","blobs_url":"https://api.github.com/repos/openmrs/openmrs-contrib-modulus-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openmrs/openmrs-contrib-modulus-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openmrs/openmrs-contrib-modulus-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/openmrs/openmrs-contrib-modulus-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openmrs/openmrs-contrib-modulus-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/openmrs/openmrs-contrib-modulus-ui/languages","stargazers_url":"https://api.github.com/repos/openmrs/openmrs-contrib-modulus-ui/stargazers","contributors_url":"https://api.github.com/repos/openmrs/openmrs-contrib-modulus-ui/contributors","subscribers_url":"https://api.github.com/repos/openmrs/openmrs-contrib-modulus-ui/subscribers","subscription_url":"https://api.github.com/repos/openmrs/openmrs-contrib-modulus-ui/subscription","commits_url":"https://api.github.com/repos/openmrs/openmrs-contrib-modulus-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/openmrs/openmrs-contrib-modulus-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/openmrs/openmrs-contrib-modulus-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/openmrs/openmrs-contrib-modulus-ui/issues/comments/{number}","contents_url":"https://api.github.com/repos/openmrs/openmrs-contrib-modulus-ui/contents/{+path}","compare_url":"https://api.github.com/repos/openmrs/openmrs-contrib-modulus-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openmrs/openmrs-contrib-modulus-ui/merges","archive_url":"https://api.github.com/repos/openmrs/openmrs-contrib-modulus-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openmrs/openmrs-contrib-modulus-ui/downloads","issues_url":"https://api.github.com/repos/openmrs/openmrs-contrib-modulus-ui/issues{/number}","pulls_url":"https://api.github.com/repos/openmrs/openmrs-contrib-modulus-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/openmrs/openmrs-contrib-modulus-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/openmrs/openmrs-contrib-modulus-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openmrs/openmrs-contrib-modulus-ui/labels{/name}","releases_url":"https://api.github.com/repos/openmrs/openmrs-contrib-modulus-ui/releases{/id}","created_at":"2014-02-26T14:09:58Z","updated_at":"2014-06-14T05:40:29Z","pushed_at":"2014-06-14T05:34:36Z","git_url":"git://github.com/openmrs/openmrs-contrib-modulus-ui.git","ssh_url":"git@github.com:openmrs/openmrs-contrib-modulus-ui.git","clone_url":"https://github.com/openmrs/openmrs-contrib-modulus-ui.git","svn_url":"https://github.com/openmrs/openmrs-contrib-modulus-ui","homepage":"http://modules.openmrs.org","size":31166,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":3,"mirror_url":null,"open_issues_count":1,"forks":3,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openmrs/openmrs-contrib-modulus-ui/pulls/6"},"html":{"href":"https://github.com/openmrs/openmrs-contrib-modulus-ui/pull/6"},"issue":{"href":"https://api.github.com/repos/openmrs/openmrs-contrib-modulus-ui/issues/6"},"comments":{"href":"https://api.github.com/repos/openmrs/openmrs-contrib-modulus-ui/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/openmrs/openmrs-contrib-modulus-ui/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/openmrs/openmrs-contrib-modulus-ui/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/openmrs/openmrs-contrib-modulus-ui/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/openmrs/openmrs-contrib-modulus-ui/statuses/4a153268c78c0780e815cd43e482079f51496834"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":14,"additions":11495,"deletions":3481,"changed_files":113}}