GitHub PullRequestReviewCommentEvent at 2014-06-13 12:44:39
Repository: barclamp-keystone
Actor: mapleoin
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/crowbar/barclamp-keystone/pulls/comments/13748516","id":13748516,"diff_hunk":"@@ -0,0 +1,6 @@\n+case node[\"platform\"]","path":"chef/cookbooks/keystone/attributes/services.rb","position":1,"original_position":1,"commit_id":"bd179cf58e260ed80cd98cf2227e371c315f0260","original_commit_id":"bd179cf58e260ed80cd98cf2227e371c315f0260","user":{"login":"mapleoin","id":35473,"avatar_url":"https://avatars.githubusercontent.com/u/35473?","gravatar_id":"68546566350063c9017dfeae5000f6b1","url":"https://api.github.com/users/mapleoin","html_url":"https://github.com/mapleoin","followers_url":"https://api.github.com/users/mapleoin/followers","following_url":"https://api.github.com/users/mapleoin/following{/other_user}","gists_url":"https://api.github.com/users/mapleoin/gists{/gist_id}","starred_url":"https://api.github.com/users/mapleoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapleoin/subscriptions","organizations_url":"https://api.github.com/users/mapleoin/orgs","repos_url":"https://api.github.com/users/mapleoin/repos","events_url":"https://api.github.com/users/mapleoin/events{/privacy}","received_events_url":"https://api.github.com/users/mapleoin/received_events","type":"User","site_admin":false},"body":"I'd prefer we stick with one attributes file.","created_at":"2014-06-13T12:44:39Z","updated_at":"2014-06-13T12:44:39Z","html_url":"https://github.com/crowbar/barclamp-keystone/pull/224#discussion_r13748516","pull_request_url":"https://api.github.com/repos/crowbar/barclamp-keystone/pulls/224","_links":{"self":{"href":"https://api.github.com/repos/crowbar/barclamp-keystone/pulls/comments/13748516"},"html":{"href":"https://github.com/crowbar/barclamp-keystone/pull/224#discussion_r13748516"},"pull_request":{"href":"https://api.github.com/repos/crowbar/barclamp-keystone/pulls/224"}}},"pull_request":{"url":"https://api.github.com/repos/crowbar/barclamp-keystone/pulls/224","id":17107111,"html_url":"https://github.com/crowbar/barclamp-keystone/pull/224","diff_url":"https://github.com/crowbar/barclamp-keystone/pull/224.diff","patch_url":"https://github.com/crowbar/barclamp-keystone/pull/224.patch","issue_url":"https://api.github.com/repos/crowbar/barclamp-keystone/issues/224","number":224,"state":"open","title":"[Ready for Review] after role deactivation stop services and remove HA resources","user":{"login":"MaximilianMeister","id":5364817,"avatar_url":"https://avatars.githubusercontent.com/u/5364817?","gravatar_id":"489c991a0a27dfeee337c67c0c6f412e","url":"https://api.github.com/users/MaximilianMeister","html_url":"https://github.com/MaximilianMeister","followers_url":"https://api.github.com/users/MaximilianMeister/followers","following_url":"https://api.github.com/users/MaximilianMeister/following{/other_user}","gists_url":"https://api.github.com/users/MaximilianMeister/gists{/gist_id}","starred_url":"https://api.github.com/users/MaximilianMeister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaximilianMeister/subscriptions","organizations_url":"https://api.github.com/users/MaximilianMeister/orgs","repos_url":"https://api.github.com/users/MaximilianMeister/repos","events_url":"https://api.github.com/users/MaximilianMeister/events{/privacy}","received_events_url":"https://api.github.com/users/MaximilianMeister/received_events","type":"User","site_admin":false},"body":"Once that PR is reviewed and accepted, I can start to finish the feature for the other barclamps as well. \r\nSo please have a look at this one, as it will be similar to the other barclamps.","created_at":"2014-06-13T12:43:20Z","updated_at":"2014-06-13T12:44:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9bb1842483d632fe94fdd06daddd302cf2a4d87e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/crowbar/barclamp-keystone/pulls/224/commits","review_comments_url":"https://api.github.com/repos/crowbar/barclamp-keystone/pulls/224/comments","review_comment_url":"https://api.github.com/repos/crowbar/barclamp-keystone/pulls/comments/{number}","comments_url":"https://api.github.com/repos/crowbar/barclamp-keystone/issues/224/comments","statuses_url":"https://api.github.com/repos/crowbar/barclamp-keystone/statuses/bd179cf58e260ed80cd98cf2227e371c315f0260","head":{"label":"MaximilianMeister:feature/deactivate-services","ref":"feature/deactivate-services","sha":"bd179cf58e260ed80cd98cf2227e371c315f0260","user":{"login":"MaximilianMeister","id":5364817,"avatar_url":"https://avatars.githubusercontent.com/u/5364817?","gravatar_id":"489c991a0a27dfeee337c67c0c6f412e","url":"https://api.github.com/users/MaximilianMeister","html_url":"https://github.com/MaximilianMeister","followers_url":"https://api.github.com/users/MaximilianMeister/followers","following_url":"https://api.github.com/users/MaximilianMeister/following{/other_user}","gists_url":"https://api.github.com/users/MaximilianMeister/gists{/gist_id}","starred_url":"https://api.github.com/users/MaximilianMeister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaximilianMeister/subscriptions","organizations_url":"https://api.github.com/users/MaximilianMeister/orgs","repos_url":"https://api.github.com/users/MaximilianMeister/repos","events_url":"https://api.github.com/users/MaximilianMeister/events{/privacy}","received_events_url":"https://api.github.com/users/MaximilianMeister/received_events","type":"User","site_admin":false},"repo":{"id":18557305,"name":"barclamp-keystone","full_name":"MaximilianMeister/barclamp-keystone","owner":{"login":"MaximilianMeister","id":5364817,"avatar_url":"https://avatars.githubusercontent.com/u/5364817?","gravatar_id":"489c991a0a27dfeee337c67c0c6f412e","url":"https://api.github.com/users/MaximilianMeister","html_url":"https://github.com/MaximilianMeister","followers_url":"https://api.github.com/users/MaximilianMeister/followers","following_url":"https://api.github.com/users/MaximilianMeister/following{/other_user}","gists_url":"https://api.github.com/users/MaximilianMeister/gists{/gist_id}","starred_url":"https://api.github.com/users/MaximilianMeister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaximilianMeister/subscriptions","organizations_url":"https://api.github.com/users/MaximilianMeister/orgs","repos_url":"https://api.github.com/users/MaximilianMeister/repos","events_url":"https://api.github.com/users/MaximilianMeister/events{/privacy}","received_events_url":"https://api.github.com/users/MaximilianMeister/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MaximilianMeister/barclamp-keystone","description":"OpenStack Keystone: Identity component","fork":true,"url":"https://api.github.com/repos/MaximilianMeister/barclamp-keystone","forks_url":"https://api.github.com/repos/MaximilianMeister/barclamp-keystone/forks","keys_url":"https://api.github.com/repos/MaximilianMeister/barclamp-keystone/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MaximilianMeister/barclamp-keystone/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MaximilianMeister/barclamp-keystone/teams","hooks_url":"https://api.github.com/repos/MaximilianMeister/barclamp-keystone/hooks","issue_events_url":"https://api.github.com/repos/MaximilianMeister/barclamp-keystone/issues/events{/number}","events_url":"https://api.github.com/repos/MaximilianMeister/barclamp-keystone/events","assignees_url":"https://api.github.com/repos/MaximilianMeister/barclamp-keystone/assignees{/user}","branches_url":"https://api.github.com/repos/MaximilianMeister/barclamp-keystone/branches{/branch}","tags_url":"https://api.github.com/repos/MaximilianMeister/barclamp-keystone/tags","blobs_url":"https://api.github.com/repos/MaximilianMeister/barclamp-keystone/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MaximilianMeister/barclamp-keystone/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MaximilianMeister/barclamp-keystone/git/refs{/sha}","trees_url":"https://api.github.com/repos/MaximilianMeister/barclamp-keystone/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MaximilianMeister/barclamp-keystone/statuses/{sha}","languages_url":"https://api.github.com/repos/MaximilianMeister/barclamp-keystone/languages","stargazers_url":"https://api.github.com/repos/MaximilianMeister/barclamp-keystone/stargazers","contributors_url":"https://api.github.com/repos/MaximilianMeister/barclamp-keystone/contributors","subscribers_url":"https://api.github.com/repos/MaximilianMeister/barclamp-keystone/subscribers","subscription_url":"https://api.github.com/repos/MaximilianMeister/barclamp-keystone/subscription","commits_url":"https://api.github.com/repos/MaximilianMeister/barclamp-keystone/commits{/sha}","git_commits_url":"https://api.github.com/repos/MaximilianMeister/barclamp-keystone/git/commits{/sha}","comments_url":"https://api.github.com/repos/MaximilianMeister/barclamp-keystone/comments{/number}","issue_comment_url":"https://api.github.com/repos/MaximilianMeister/barclamp-keystone/issues/comments/{number}","contents_url":"https://api.github.com/repos/MaximilianMeister/barclamp-keystone/contents/{+path}","compare_url":"https://api.github.com/repos/MaximilianMeister/barclamp-keystone/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MaximilianMeister/barclamp-keystone/merges","archive_url":"https://api.github.com/repos/MaximilianMeister/barclamp-keystone/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MaximilianMeister/barclamp-keystone/downloads","issues_url":"https://api.github.com/repos/MaximilianMeister/barclamp-keystone/issues{/number}","pulls_url":"https://api.github.com/repos/MaximilianMeister/barclamp-keystone/pulls{/number}","milestones_url":"https://api.github.com/repos/MaximilianMeister/barclamp-keystone/milestones{/number}","notifications_url":"https://api.github.com/repos/MaximilianMeister/barclamp-keystone/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MaximilianMeister/barclamp-keystone/labels{/name}","releases_url":"https://api.github.com/repos/MaximilianMeister/barclamp-keystone/releases{/id}","created_at":"2014-04-08T12:28:19Z","updated_at":"2014-06-13T12:43:20Z","pushed_at":"2014-06-13T12:20:50Z","git_url":"git://github.com/MaximilianMeister/barclamp-keystone.git","ssh_url":"git@github.com:MaximilianMeister/barclamp-keystone.git","clone_url":"https://github.com/MaximilianMeister/barclamp-keystone.git","svn_url":"https://github.com/MaximilianMeister/barclamp-keystone","homepage":"https://github.com/crowbar/crowbar","size":943,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crowbar:master","ref":"master","sha":"72410a44ba5ba9943219b5ee86558ce4639d7cc4","user":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars.githubusercontent.com/u/2910205?","gravatar_id":"36825f9798aaf5d8795156f057fcf4a4","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"repo":{"id":2434085,"name":"barclamp-keystone","full_name":"crowbar/barclamp-keystone","owner":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars.githubusercontent.com/u/2910205?","gravatar_id":"36825f9798aaf5d8795156f057fcf4a4","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crowbar/barclamp-keystone","description":"OpenStack Keystone: Identity component","fork":false,"url":"https://api.github.com/repos/crowbar/barclamp-keystone","forks_url":"https://api.github.com/repos/crowbar/barclamp-keystone/forks","keys_url":"https://api.github.com/repos/crowbar/barclamp-keystone/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crowbar/barclamp-keystone/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crowbar/barclamp-keystone/teams","hooks_url":"https://api.github.com/repos/crowbar/barclamp-keystone/hooks","issue_events_url":"https://api.github.com/repos/crowbar/barclamp-keystone/issues/events{/number}","events_url":"https://api.github.com/repos/crowbar/barclamp-keystone/events","assignees_url":"https://api.github.com/repos/crowbar/barclamp-keystone/assignees{/user}","branches_url":"https://api.github.com/repos/crowbar/barclamp-keystone/branches{/branch}","tags_url":"https://api.github.com/repos/crowbar/barclamp-keystone/tags","blobs_url":"https://api.github.com/repos/crowbar/barclamp-keystone/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crowbar/barclamp-keystone/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crowbar/barclamp-keystone/git/refs{/sha}","trees_url":"https://api.github.com/repos/crowbar/barclamp-keystone/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crowbar/barclamp-keystone/statuses/{sha}","languages_url":"https://api.github.com/repos/crowbar/barclamp-keystone/languages","stargazers_url":"https://api.github.com/repos/crowbar/barclamp-keystone/stargazers","contributors_url":"https://api.github.com/repos/crowbar/barclamp-keystone/contributors","subscribers_url":"https://api.github.com/repos/crowbar/barclamp-keystone/subscribers","subscription_url":"https://api.github.com/repos/crowbar/barclamp-keystone/subscription","commits_url":"https://api.github.com/repos/crowbar/barclamp-keystone/commits{/sha}","git_commits_url":"https://api.github.com/repos/crowbar/barclamp-keystone/git/commits{/sha}","comments_url":"https://api.github.com/repos/crowbar/barclamp-keystone/comments{/number}","issue_comment_url":"https://api.github.com/repos/crowbar/barclamp-keystone/issues/comments/{number}","contents_url":"https://api.github.com/repos/crowbar/barclamp-keystone/contents/{+path}","compare_url":"https://api.github.com/repos/crowbar/barclamp-keystone/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crowbar/barclamp-keystone/merges","archive_url":"https://api.github.com/repos/crowbar/barclamp-keystone/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crowbar/barclamp-keystone/downloads","issues_url":"https://api.github.com/repos/crowbar/barclamp-keystone/issues{/number}","pulls_url":"https://api.github.com/repos/crowbar/barclamp-keystone/pulls{/number}","milestones_url":"https://api.github.com/repos/crowbar/barclamp-keystone/milestones{/number}","notifications_url":"https://api.github.com/repos/crowbar/barclamp-keystone/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crowbar/barclamp-keystone/labels{/name}","releases_url":"https://api.github.com/repos/crowbar/barclamp-keystone/releases{/id}","created_at":"2011-09-22T01:17:10Z","updated_at":"2014-06-11T11:53:45Z","pushed_at":"2014-06-11T11:53:46Z","git_url":"git://github.com/crowbar/barclamp-keystone.git","ssh_url":"git@github.com:crowbar/barclamp-keystone.git","clone_url":"https://github.com/crowbar/barclamp-keystone.git","svn_url":"https://github.com/crowbar/barclamp-keystone","homepage":"https://github.com/crowbar/crowbar","size":3152,"stargazers_count":56,"watchers_count":56,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":187,"mirror_url":null,"open_issues_count":2,"forks":187,"open_issues":2,"watchers":56,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crowbar/barclamp-keystone/pulls/224"},"html":{"href":"https://github.com/crowbar/barclamp-keystone/pull/224"},"issue":{"href":"https://api.github.com/repos/crowbar/barclamp-keystone/issues/224"},"comments":{"href":"https://api.github.com/repos/crowbar/barclamp-keystone/issues/224/comments"},"review_comments":{"href":"https://api.github.com/repos/crowbar/barclamp-keystone/pulls/224/comments"},"review_comment":{"href":"https://api.github.com/repos/crowbar/barclamp-keystone/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/crowbar/barclamp-keystone/pulls/224/commits"},"statuses":{"href":"https://api.github.com/repos/crowbar/barclamp-keystone/statuses/bd179cf58e260ed80cd98cf2227e371c315f0260"}}}}