GitHub PullRequestEvent at 2014-04-25 13:04:06
Repository: phpseclib
Actor: bantu
Payload: {"action":"closed","number":332,"pull_request":{"url":"https://api.github.com/repos/phpseclib/phpseclib/pulls/332","id":15165336,"html_url":"https://github.com/phpseclib/phpseclib/pull/332","diff_url":"https://github.com/phpseclib/phpseclib/pull/332.diff","patch_url":"https://github.com/phpseclib/phpseclib/pull/332.patch","issue_url":"https://api.github.com/repos/phpseclib/phpseclib/issues/332","number":332,"state":"closed","title":"Add mcrypt extension to require-dev in composer.json","user":{"login":"mbfisher","id":1162326,"avatar_url":"https://avatars.githubusercontent.com/u/1162326?","gravatar_id":"3cec7764e69f16c6cb881b51f25ce536","url":"https://api.github.com/users/mbfisher","html_url":"https://github.com/mbfisher","followers_url":"https://api.github.com/users/mbfisher/followers","following_url":"https://api.github.com/users/mbfisher/following{/other_user}","gists_url":"https://api.github.com/users/mbfisher/gists{/gist_id}","starred_url":"https://api.github.com/users/mbfisher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbfisher/subscriptions","organizations_url":"https://api.github.com/users/mbfisher/orgs","repos_url":"https://api.github.com/users/mbfisher/repos","events_url":"https://api.github.com/users/mbfisher/events{/privacy}","received_events_url":"https://api.github.com/users/mbfisher/received_events","type":"User","site_admin":false},"body":"If you run the test suite without the `mcrypt` extension installed you get the following failure:\r\n```bash\r\n$> ./vendor/bin/phpunit \r\nPHPUnit 4.0.14 by Sebastian Bergmann.\r\n\r\nConfiguration read from /home/mbfisher/git-projects/phpseclib/phpunit.xml.dist\r\n\r\n...............................................................  63 / 217 ( 29%)\r\n................................................SSSSSSSSSSSSSSS 126 / 217 ( 58%)\r\nSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS 189 / 217 ( 87%)\r\nSSSSSSSSSS.SSS.SS.SSF.....\r\n\r\nTime: 237 ms, Memory: 14.00Mb\r\n\r\nThere was 1 failure:\r\n\r\n1) Net_SSH2Test::testGenerateIdentifier with data set #5 ('SSH-2.0-phpseclib_0.3 (mcrypt, bcmath)', array('mcrypt', 'bcmath'))\r\nFailed asserting that two strings are equal.\r\n--- Expected\r\n+++ Actual\r\n@@ @@\r\n-'SSH-2.0-phpseclib_0.3 (mcrypt, bcmath)'\r\n+'SSH-2.0-phpseclib_0.3 (bcmath)'\r\n\r\n/home/mbfisher/git-projects/phpseclib/tests/Net/SSH2Test.php:70\r\n                                                      \r\nFAILURES!                                             \r\nTests: 128, Assertions: 151, Failures: 1, Skipped: 95.\r\n```\r\nThis commit adds `ext-mcrypt` to the `require-dev` section of `composer.json`, so that composer prompts you to install it.\r\n\r\nCould this be the case for other extensions I happen to have installed?\r\n\r\nM","created_at":"2014-04-25T11:37:20Z","updated_at":"2014-04-25T13:04:06Z","closed_at":"2014-04-25T13:04:06Z","merged_at":null,"merge_commit_sha":"8297d1303dd7fe400419fc68321235901a899928","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/phpseclib/phpseclib/pulls/332/commits","review_comments_url":"https://api.github.com/repos/phpseclib/phpseclib/pulls/332/comments","review_comment_url":"https://api.github.com/repos/phpseclib/phpseclib/pulls/comments/{number}","comments_url":"https://api.github.com/repos/phpseclib/phpseclib/issues/332/comments","statuses_url":"https://api.github.com/repos/phpseclib/phpseclib/statuses/6dfd8c480d9c22e7c734dd6d0f02d8628632fb60","head":{"label":"mbfisher:feature/dev-deps","ref":"feature/dev-deps","sha":"6dfd8c480d9c22e7c734dd6d0f02d8628632fb60","user":{"login":"mbfisher","id":1162326,"avatar_url":"https://avatars.githubusercontent.com/u/1162326?","gravatar_id":"3cec7764e69f16c6cb881b51f25ce536","url":"https://api.github.com/users/mbfisher","html_url":"https://github.com/mbfisher","followers_url":"https://api.github.com/users/mbfisher/followers","following_url":"https://api.github.com/users/mbfisher/following{/other_user}","gists_url":"https://api.github.com/users/mbfisher/gists{/gist_id}","starred_url":"https://api.github.com/users/mbfisher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbfisher/subscriptions","organizations_url":"https://api.github.com/users/mbfisher/orgs","repos_url":"https://api.github.com/users/mbfisher/repos","events_url":"https://api.github.com/users/mbfisher/events{/privacy}","received_events_url":"https://api.github.com/users/mbfisher/received_events","type":"User","site_admin":false},"repo":{"id":19143764,"name":"phpseclib","full_name":"mbfisher/phpseclib","owner":{"login":"mbfisher","id":1162326,"avatar_url":"https://avatars.githubusercontent.com/u/1162326?","gravatar_id":"3cec7764e69f16c6cb881b51f25ce536","url":"https://api.github.com/users/mbfisher","html_url":"https://github.com/mbfisher","followers_url":"https://api.github.com/users/mbfisher/followers","following_url":"https://api.github.com/users/mbfisher/following{/other_user}","gists_url":"https://api.github.com/users/mbfisher/gists{/gist_id}","starred_url":"https://api.github.com/users/mbfisher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbfisher/subscriptions","organizations_url":"https://api.github.com/users/mbfisher/orgs","repos_url":"https://api.github.com/users/mbfisher/repos","events_url":"https://api.github.com/users/mbfisher/events{/privacy}","received_events_url":"https://api.github.com/users/mbfisher/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mbfisher/phpseclib","description":"PHP Secure Communications Library","fork":true,"url":"https://api.github.com/repos/mbfisher/phpseclib","forks_url":"https://api.github.com/repos/mbfisher/phpseclib/forks","keys_url":"https://api.github.com/repos/mbfisher/phpseclib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mbfisher/phpseclib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mbfisher/phpseclib/teams","hooks_url":"https://api.github.com/repos/mbfisher/phpseclib/hooks","issue_events_url":"https://api.github.com/repos/mbfisher/phpseclib/issues/events{/number}","events_url":"https://api.github.com/repos/mbfisher/phpseclib/events","assignees_url":"https://api.github.com/repos/mbfisher/phpseclib/assignees{/user}","branches_url":"https://api.github.com/repos/mbfisher/phpseclib/branches{/branch}","tags_url":"https://api.github.com/repos/mbfisher/phpseclib/tags","blobs_url":"https://api.github.com/repos/mbfisher/phpseclib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mbfisher/phpseclib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mbfisher/phpseclib/git/refs{/sha}","trees_url":"https://api.github.com/repos/mbfisher/phpseclib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mbfisher/phpseclib/statuses/{sha}","languages_url":"https://api.github.com/repos/mbfisher/phpseclib/languages","stargazers_url":"https://api.github.com/repos/mbfisher/phpseclib/stargazers","contributors_url":"https://api.github.com/repos/mbfisher/phpseclib/contributors","subscribers_url":"https://api.github.com/repos/mbfisher/phpseclib/subscribers","subscription_url":"https://api.github.com/repos/mbfisher/phpseclib/subscription","commits_url":"https://api.github.com/repos/mbfisher/phpseclib/commits{/sha}","git_commits_url":"https://api.github.com/repos/mbfisher/phpseclib/git/commits{/sha}","comments_url":"https://api.github.com/repos/mbfisher/phpseclib/comments{/number}","issue_comment_url":"https://api.github.com/repos/mbfisher/phpseclib/issues/comments/{number}","contents_url":"https://api.github.com/repos/mbfisher/phpseclib/contents/{+path}","compare_url":"https://api.github.com/repos/mbfisher/phpseclib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mbfisher/phpseclib/merges","archive_url":"https://api.github.com/repos/mbfisher/phpseclib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mbfisher/phpseclib/downloads","issues_url":"https://api.github.com/repos/mbfisher/phpseclib/issues{/number}","pulls_url":"https://api.github.com/repos/mbfisher/phpseclib/pulls{/number}","milestones_url":"https://api.github.com/repos/mbfisher/phpseclib/milestones{/number}","notifications_url":"https://api.github.com/repos/mbfisher/phpseclib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mbfisher/phpseclib/labels{/name}","releases_url":"https://api.github.com/repos/mbfisher/phpseclib/releases{/id}","created_at":"2014-04-25T11:26:08Z","updated_at":"2014-04-25T11:52:04Z","pushed_at":"2014-04-25T11:51:54Z","git_url":"git://github.com/mbfisher/phpseclib.git","ssh_url":"git@github.com:mbfisher/phpseclib.git","clone_url":"https://github.com/mbfisher/phpseclib.git","svn_url":"https://github.com/mbfisher/phpseclib","homepage":"http://phpseclib.sourceforge.net/","size":6340,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"phpseclib:master","ref":"master","sha":"60a9631219ff799e96b2b529db6a796d58f8ce77","user":{"login":"phpseclib","id":1820952,"avatar_url":"https://avatars.githubusercontent.com/u/1820952?","gravatar_id":"9cf3e9b05eb22f80d5be4b7c380fcf44","url":"https://api.github.com/users/phpseclib","html_url":"https://github.com/phpseclib","followers_url":"https://api.github.com/users/phpseclib/followers","following_url":"https://api.github.com/users/phpseclib/following{/other_user}","gists_url":"https://api.github.com/users/phpseclib/gists{/gist_id}","starred_url":"https://api.github.com/users/phpseclib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phpseclib/subscriptions","organizations_url":"https://api.github.com/users/phpseclib/orgs","repos_url":"https://api.github.com/users/phpseclib/repos","events_url":"https://api.github.com/users/phpseclib/events{/privacy}","received_events_url":"https://api.github.com/users/phpseclib/received_events","type":"Organization","site_admin":false},"repo":{"id":4565995,"name":"phpseclib","full_name":"phpseclib/phpseclib","owner":{"login":"phpseclib","id":1820952,"avatar_url":"https://avatars.githubusercontent.com/u/1820952?","gravatar_id":"9cf3e9b05eb22f80d5be4b7c380fcf44","url":"https://api.github.com/users/phpseclib","html_url":"https://github.com/phpseclib","followers_url":"https://api.github.com/users/phpseclib/followers","following_url":"https://api.github.com/users/phpseclib/following{/other_user}","gists_url":"https://api.github.com/users/phpseclib/gists{/gist_id}","starred_url":"https://api.github.com/users/phpseclib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phpseclib/subscriptions","organizations_url":"https://api.github.com/users/phpseclib/orgs","repos_url":"https://api.github.com/users/phpseclib/repos","events_url":"https://api.github.com/users/phpseclib/events{/privacy}","received_events_url":"https://api.github.com/users/phpseclib/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/phpseclib/phpseclib","description":"PHP Secure Communications Library","fork":false,"url":"https://api.github.com/repos/phpseclib/phpseclib","forks_url":"https://api.github.com/repos/phpseclib/phpseclib/forks","keys_url":"https://api.github.com/repos/phpseclib/phpseclib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phpseclib/phpseclib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phpseclib/phpseclib/teams","hooks_url":"https://api.github.com/repos/phpseclib/phpseclib/hooks","issue_events_url":"https://api.github.com/repos/phpseclib/phpseclib/issues/events{/number}","events_url":"https://api.github.com/repos/phpseclib/phpseclib/events","assignees_url":"https://api.github.com/repos/phpseclib/phpseclib/assignees{/user}","branches_url":"https://api.github.com/repos/phpseclib/phpseclib/branches{/branch}","tags_url":"https://api.github.com/repos/phpseclib/phpseclib/tags","blobs_url":"https://api.github.com/repos/phpseclib/phpseclib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phpseclib/phpseclib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phpseclib/phpseclib/git/refs{/sha}","trees_url":"https://api.github.com/repos/phpseclib/phpseclib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phpseclib/phpseclib/statuses/{sha}","languages_url":"https://api.github.com/repos/phpseclib/phpseclib/languages","stargazers_url":"https://api.github.com/repos/phpseclib/phpseclib/stargazers","contributors_url":"https://api.github.com/repos/phpseclib/phpseclib/contributors","subscribers_url":"https://api.github.com/repos/phpseclib/phpseclib/subscribers","subscription_url":"https://api.github.com/repos/phpseclib/phpseclib/subscription","commits_url":"https://api.github.com/repos/phpseclib/phpseclib/commits{/sha}","git_commits_url":"https://api.github.com/repos/phpseclib/phpseclib/git/commits{/sha}","comments_url":"https://api.github.com/repos/phpseclib/phpseclib/comments{/number}","issue_comment_url":"https://api.github.com/repos/phpseclib/phpseclib/issues/comments/{number}","contents_url":"https://api.github.com/repos/phpseclib/phpseclib/contents/{+path}","compare_url":"https://api.github.com/repos/phpseclib/phpseclib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phpseclib/phpseclib/merges","archive_url":"https://api.github.com/repos/phpseclib/phpseclib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phpseclib/phpseclib/downloads","issues_url":"https://api.github.com/repos/phpseclib/phpseclib/issues{/number}","pulls_url":"https://api.github.com/repos/phpseclib/phpseclib/pulls{/number}","milestones_url":"https://api.github.com/repos/phpseclib/phpseclib/milestones{/number}","notifications_url":"https://api.github.com/repos/phpseclib/phpseclib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phpseclib/phpseclib/labels{/name}","releases_url":"https://api.github.com/repos/phpseclib/phpseclib/releases{/id}","created_at":"2012-06-05T21:55:28Z","updated_at":"2014-04-23T22:41:54Z","pushed_at":"2014-04-23T22:41:54Z","git_url":"git://github.com/phpseclib/phpseclib.git","ssh_url":"git@github.com:phpseclib/phpseclib.git","clone_url":"https://github.com/phpseclib/phpseclib.git","svn_url":"https://github.com/phpseclib/phpseclib","homepage":"http://phpseclib.sourceforge.net/","size":6340,"stargazers_count":393,"watchers_count":393,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":129,"mirror_url":null,"open_issues_count":46,"forks":129,"open_issues":46,"watchers":393,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/phpseclib/phpseclib/pulls/332"},"html":{"href":"https://github.com/phpseclib/phpseclib/pull/332"},"issue":{"href":"https://api.github.com/repos/phpseclib/phpseclib/issues/332"},"comments":{"href":"https://api.github.com/repos/phpseclib/phpseclib/issues/332/comments"},"review_comments":{"href":"https://api.github.com/repos/phpseclib/phpseclib/pulls/332/comments"},"review_comment":{"href":"https://api.github.com/repos/phpseclib/phpseclib/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/phpseclib/phpseclib/pulls/332/commits"},"statuses":{"href":"https://api.github.com/repos/phpseclib/phpseclib/statuses/6dfd8c480d9c22e7c734dd6d0f02d8628632fb60"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"commits":1,"additions":4,"deletions":1,"changed_files":2}}