GitHub PullRequestEvent at 2014-06-11 19:57:36
Repository: AllGoTrading
Actor: NeoSephiroth
Payload: {"action":"opened","number":95,"pull_request":{"url":"https://api.github.com/repos/yatsdev/AllGoTrading/pulls/95","id":17019693,"html_url":"https://github.com/yatsdev/AllGoTrading/pull/95","diff_url":"https://github.com/yatsdev/AllGoTrading/pull/95.diff","patch_url":"https://github.com/yatsdev/AllGoTrading/pull/95.patch","issue_url":"https://api.github.com/repos/yatsdev/AllGoTrading/issues/95","number":95,"state":"open","title":"Update RateConverter.java","user":{"login":"NeoSephiroth","id":7432127,"avatar_url":"https://avatars.githubusercontent.com/u/7432127?","gravatar_id":"7fa71e05fcccc1547d6a95e2004a9362","url":"https://api.github.com/users/NeoSephiroth","html_url":"https://github.com/NeoSephiroth","followers_url":"https://api.github.com/users/NeoSephiroth/followers","following_url":"https://api.github.com/users/NeoSephiroth/following{/other_user}","gists_url":"https://api.github.com/users/NeoSephiroth/gists{/gist_id}","starred_url":"https://api.github.com/users/NeoSephiroth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NeoSephiroth/subscriptions","organizations_url":"https://api.github.com/users/NeoSephiroth/orgs","repos_url":"https://api.github.com/users/NeoSephiroth/repos","events_url":"https://api.github.com/users/NeoSephiroth/events{/privacy}","received_events_url":"https://api.github.com/users/NeoSephiroth/received_events","type":"User","site_admin":false},"body":"Is this a good way? Anyway I still can't pass the first test in RateConverterTest\r\nin your test you have 2 SAP at 85 euro each, totaling 170 euro\r\n\r\nIn implementation I find the euro at 1.35 and I multiply it for the number of shares we have, making 2.7.\r\n\r\nWhat I don't get it's how do I find, in the body of method \"convert\", the value 85 for a SAP share?\r\nThanks","created_at":"2014-06-11T19:57:35Z","updated_at":"2014-06-11T19:57:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/yatsdev/AllGoTrading/pulls/95/commits","review_comments_url":"https://api.github.com/repos/yatsdev/AllGoTrading/pulls/95/comments","review_comment_url":"https://api.github.com/repos/yatsdev/AllGoTrading/pulls/comments/{number}","comments_url":"https://api.github.com/repos/yatsdev/AllGoTrading/issues/95/comments","statuses_url":"https://api.github.com/repos/yatsdev/AllGoTrading/statuses/4a03a6c375ff32542d9d145928d5419f0e807e83","head":{"label":"NeoSephiroth:patch-1","ref":"patch-1","sha":"4a03a6c375ff32542d9d145928d5419f0e807e83","user":{"login":"NeoSephiroth","id":7432127,"avatar_url":"https://avatars.githubusercontent.com/u/7432127?","gravatar_id":"7fa71e05fcccc1547d6a95e2004a9362","url":"https://api.github.com/users/NeoSephiroth","html_url":"https://github.com/NeoSephiroth","followers_url":"https://api.github.com/users/NeoSephiroth/followers","following_url":"https://api.github.com/users/NeoSephiroth/following{/other_user}","gists_url":"https://api.github.com/users/NeoSephiroth/gists{/gist_id}","starred_url":"https://api.github.com/users/NeoSephiroth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NeoSephiroth/subscriptions","organizations_url":"https://api.github.com/users/NeoSephiroth/orgs","repos_url":"https://api.github.com/users/NeoSephiroth/repos","events_url":"https://api.github.com/users/NeoSephiroth/events{/privacy}","received_events_url":"https://api.github.com/users/NeoSephiroth/received_events","type":"User","site_admin":false},"repo":{"id":20677432,"name":"AllGoTrading","full_name":"NeoSephiroth/AllGoTrading","owner":{"login":"NeoSephiroth","id":7432127,"avatar_url":"https://avatars.githubusercontent.com/u/7432127?","gravatar_id":"7fa71e05fcccc1547d6a95e2004a9362","url":"https://api.github.com/users/NeoSephiroth","html_url":"https://github.com/NeoSephiroth","followers_url":"https://api.github.com/users/NeoSephiroth/followers","following_url":"https://api.github.com/users/NeoSephiroth/following{/other_user}","gists_url":"https://api.github.com/users/NeoSephiroth/gists{/gist_id}","starred_url":"https://api.github.com/users/NeoSephiroth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NeoSephiroth/subscriptions","organizations_url":"https://api.github.com/users/NeoSephiroth/orgs","repos_url":"https://api.github.com/users/NeoSephiroth/repos","events_url":"https://api.github.com/users/NeoSephiroth/events{/privacy}","received_events_url":"https://api.github.com/users/NeoSephiroth/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/NeoSephiroth/AllGoTrading","description":"","fork":true,"url":"https://api.github.com/repos/NeoSephiroth/AllGoTrading","forks_url":"https://api.github.com/repos/NeoSephiroth/AllGoTrading/forks","keys_url":"https://api.github.com/repos/NeoSephiroth/AllGoTrading/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NeoSephiroth/AllGoTrading/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NeoSephiroth/AllGoTrading/teams","hooks_url":"https://api.github.com/repos/NeoSephiroth/AllGoTrading/hooks","issue_events_url":"https://api.github.com/repos/NeoSephiroth/AllGoTrading/issues/events{/number}","events_url":"https://api.github.com/repos/NeoSephiroth/AllGoTrading/events","assignees_url":"https://api.github.com/repos/NeoSephiroth/AllGoTrading/assignees{/user}","branches_url":"https://api.github.com/repos/NeoSephiroth/AllGoTrading/branches{/branch}","tags_url":"https://api.github.com/repos/NeoSephiroth/AllGoTrading/tags","blobs_url":"https://api.github.com/repos/NeoSephiroth/AllGoTrading/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NeoSephiroth/AllGoTrading/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NeoSephiroth/AllGoTrading/git/refs{/sha}","trees_url":"https://api.github.com/repos/NeoSephiroth/AllGoTrading/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NeoSephiroth/AllGoTrading/statuses/{sha}","languages_url":"https://api.github.com/repos/NeoSephiroth/AllGoTrading/languages","stargazers_url":"https://api.github.com/repos/NeoSephiroth/AllGoTrading/stargazers","contributors_url":"https://api.github.com/repos/NeoSephiroth/AllGoTrading/contributors","subscribers_url":"https://api.github.com/repos/NeoSephiroth/AllGoTrading/subscribers","subscription_url":"https://api.github.com/repos/NeoSephiroth/AllGoTrading/subscription","commits_url":"https://api.github.com/repos/NeoSephiroth/AllGoTrading/commits{/sha}","git_commits_url":"https://api.github.com/repos/NeoSephiroth/AllGoTrading/git/commits{/sha}","comments_url":"https://api.github.com/repos/NeoSephiroth/AllGoTrading/comments{/number}","issue_comment_url":"https://api.github.com/repos/NeoSephiroth/AllGoTrading/issues/comments/{number}","contents_url":"https://api.github.com/repos/NeoSephiroth/AllGoTrading/contents/{+path}","compare_url":"https://api.github.com/repos/NeoSephiroth/AllGoTrading/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NeoSephiroth/AllGoTrading/merges","archive_url":"https://api.github.com/repos/NeoSephiroth/AllGoTrading/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NeoSephiroth/AllGoTrading/downloads","issues_url":"https://api.github.com/repos/NeoSephiroth/AllGoTrading/issues{/number}","pulls_url":"https://api.github.com/repos/NeoSephiroth/AllGoTrading/pulls{/number}","milestones_url":"https://api.github.com/repos/NeoSephiroth/AllGoTrading/milestones{/number}","notifications_url":"https://api.github.com/repos/NeoSephiroth/AllGoTrading/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NeoSephiroth/AllGoTrading/labels{/name}","releases_url":"https://api.github.com/repos/NeoSephiroth/AllGoTrading/releases{/id}","created_at":"2014-06-10T08:09:16Z","updated_at":"2014-06-11T19:57:35Z","pushed_at":"2014-06-11T19:57:32Z","git_url":"git://github.com/NeoSephiroth/AllGoTrading.git","ssh_url":"git@github.com:NeoSephiroth/AllGoTrading.git","clone_url":"https://github.com/NeoSephiroth/AllGoTrading.git","svn_url":"https://github.com/NeoSephiroth/AllGoTrading","homepage":null,"size":11884,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"yatsdev:master","ref":"master","sha":"8c886f04e2df54ab6f6e3b9694f35d71812f6a00","user":{"login":"yatsdev","id":7396418,"avatar_url":"https://avatars.githubusercontent.com/u/7396418?","gravatar_id":"1f1b5fa00d75e9dda5250237ffe15f50","url":"https://api.github.com/users/yatsdev","html_url":"https://github.com/yatsdev","followers_url":"https://api.github.com/users/yatsdev/followers","following_url":"https://api.github.com/users/yatsdev/following{/other_user}","gists_url":"https://api.github.com/users/yatsdev/gists{/gist_id}","starred_url":"https://api.github.com/users/yatsdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yatsdev/subscriptions","organizations_url":"https://api.github.com/users/yatsdev/orgs","repos_url":"https://api.github.com/users/yatsdev/repos","events_url":"https://api.github.com/users/yatsdev/events{/privacy}","received_events_url":"https://api.github.com/users/yatsdev/received_events","type":"User","site_admin":false},"repo":{"id":19277824,"name":"AllGoTrading","full_name":"yatsdev/AllGoTrading","owner":{"login":"yatsdev","id":7396418,"avatar_url":"https://avatars.githubusercontent.com/u/7396418?","gravatar_id":"1f1b5fa00d75e9dda5250237ffe15f50","url":"https://api.github.com/users/yatsdev","html_url":"https://github.com/yatsdev","followers_url":"https://api.github.com/users/yatsdev/followers","following_url":"https://api.github.com/users/yatsdev/following{/other_user}","gists_url":"https://api.github.com/users/yatsdev/gists{/gist_id}","starred_url":"https://api.github.com/users/yatsdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yatsdev/subscriptions","organizations_url":"https://api.github.com/users/yatsdev/orgs","repos_url":"https://api.github.com/users/yatsdev/repos","events_url":"https://api.github.com/users/yatsdev/events{/privacy}","received_events_url":"https://api.github.com/users/yatsdev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yatsdev/AllGoTrading","description":"","fork":false,"url":"https://api.github.com/repos/yatsdev/AllGoTrading","forks_url":"https://api.github.com/repos/yatsdev/AllGoTrading/forks","keys_url":"https://api.github.com/repos/yatsdev/AllGoTrading/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yatsdev/AllGoTrading/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yatsdev/AllGoTrading/teams","hooks_url":"https://api.github.com/repos/yatsdev/AllGoTrading/hooks","issue_events_url":"https://api.github.com/repos/yatsdev/AllGoTrading/issues/events{/number}","events_url":"https://api.github.com/repos/yatsdev/AllGoTrading/events","assignees_url":"https://api.github.com/repos/yatsdev/AllGoTrading/assignees{/user}","branches_url":"https://api.github.com/repos/yatsdev/AllGoTrading/branches{/branch}","tags_url":"https://api.github.com/repos/yatsdev/AllGoTrading/tags","blobs_url":"https://api.github.com/repos/yatsdev/AllGoTrading/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yatsdev/AllGoTrading/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yatsdev/AllGoTrading/git/refs{/sha}","trees_url":"https://api.github.com/repos/yatsdev/AllGoTrading/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yatsdev/AllGoTrading/statuses/{sha}","languages_url":"https://api.github.com/repos/yatsdev/AllGoTrading/languages","stargazers_url":"https://api.github.com/repos/yatsdev/AllGoTrading/stargazers","contributors_url":"https://api.github.com/repos/yatsdev/AllGoTrading/contributors","subscribers_url":"https://api.github.com/repos/yatsdev/AllGoTrading/subscribers","subscription_url":"https://api.github.com/repos/yatsdev/AllGoTrading/subscription","commits_url":"https://api.github.com/repos/yatsdev/AllGoTrading/commits{/sha}","git_commits_url":"https://api.github.com/repos/yatsdev/AllGoTrading/git/commits{/sha}","comments_url":"https://api.github.com/repos/yatsdev/AllGoTrading/comments{/number}","issue_comment_url":"https://api.github.com/repos/yatsdev/AllGoTrading/issues/comments/{number}","contents_url":"https://api.github.com/repos/yatsdev/AllGoTrading/contents/{+path}","compare_url":"https://api.github.com/repos/yatsdev/AllGoTrading/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yatsdev/AllGoTrading/merges","archive_url":"https://api.github.com/repos/yatsdev/AllGoTrading/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yatsdev/AllGoTrading/downloads","issues_url":"https://api.github.com/repos/yatsdev/AllGoTrading/issues{/number}","pulls_url":"https://api.github.com/repos/yatsdev/AllGoTrading/pulls{/number}","milestones_url":"https://api.github.com/repos/yatsdev/AllGoTrading/milestones{/number}","notifications_url":"https://api.github.com/repos/yatsdev/AllGoTrading/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yatsdev/AllGoTrading/labels{/name}","releases_url":"https://api.github.com/repos/yatsdev/AllGoTrading/releases{/id}","created_at":"2014-04-29T13:41:53Z","updated_at":"2014-06-11T13:15:09Z","pushed_at":"2014-06-11T13:15:12Z","git_url":"git://github.com/yatsdev/AllGoTrading.git","ssh_url":"git@github.com:yatsdev/AllGoTrading.git","clone_url":"https://github.com/yatsdev/AllGoTrading.git","svn_url":"https://github.com/yatsdev/AllGoTrading","homepage":null,"size":11884,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yatsdev/AllGoTrading/pulls/95"},"html":{"href":"https://github.com/yatsdev/AllGoTrading/pull/95"},"issue":{"href":"https://api.github.com/repos/yatsdev/AllGoTrading/issues/95"},"comments":{"href":"https://api.github.com/repos/yatsdev/AllGoTrading/issues/95/comments"},"review_comments":{"href":"https://api.github.com/repos/yatsdev/AllGoTrading/pulls/95/comments"},"review_comment":{"href":"https://api.github.com/repos/yatsdev/AllGoTrading/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/yatsdev/AllGoTrading/pulls/95/commits"},"statuses":{"href":"https://api.github.com/repos/yatsdev/AllGoTrading/statuses/4a03a6c375ff32542d9d145928d5419f0e807e83"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":13,"deletions":2,"changed_files":1}}