GitHub PullRequestReviewCommentEvent at 2014-03-03 10:03:33
Repository: core
Actor: ediosyncratic
Payload: {"comment":{"url":"https://api.github.com/repos/cfengine/core/pulls/comments/10205359","id":10205359,"diff_hunk":"@@ -1,55 +1,62 @@\n body classes if_failed(x)\n {\n-  repair_failed => { \"$(x)\" };\n+      repair_failed => { \"$(x)\" };\n }\n \n body contain run_under_shell\n {\n-  useshell => \"useshell\";\n+      useshell => \"useshell\";\n }\n \n \n bundle agent generate_key\n {\n-commands:\n-  \"$(sys.cf_key)\";\n+  commands:\n+      \"$(sys.cf_key)\";\n }\n \n \n bundle agent start_server(server_name)\n {\n-vars:\n-  \"cwd\" string => dirname(\"$(this.promise_filename)\");\n-\n-commands:\n-  \"$(sys.cf_serverd) -Kf $(cwd)/$(server_name).srv\"\n-    classes => if_failed(\"server_failed\");\n+  vars:\n+      \"cwd\" string => dirname(\"$(this.promise_filename)\");\n+      \"dlog\" string => \"$(sys.workdir)/server-debug.$(server_name).log\";\n+      \"conf\" string => \"$(cwd)/$(server_name).srv\";\n+\n+  commands:\n+    !DEBUG::\n+      \"$(sys.cf_serverd) -Kf $(conf)\"\n+      classes => if_failed(\"server_failed\");\n+\n+    DEBUG::\n+      # Sleep 3 seconds since cf-serverd takes some time to start in debug mode.","path":"tests/acceptance/16_cf-serverd/01_start/run_with_server.cf.sub","position":42,"original_position":42,"commit_id":"18981f235c0bfc57aab3e028d4abd16516fcbb3f","original_commit_id":"18981f235c0bfc57aab3e028d4abd16516fcbb3f","user":{"login":"ediosyncratic","id":2255042,"avatar_url":"https://avatars.githubusercontent.com/u/2255042","gravatar_id":"bbe766bb0c7aee798888f5de85063c8c","url":"https://api.github.com/users/ediosyncratic","html_url":"https://github.com/ediosyncratic","followers_url":"https://api.github.com/users/ediosyncratic/followers","following_url":"https://api.github.com/users/ediosyncratic/following{/other_user}","gists_url":"https://api.github.com/users/ediosyncratic/gists{/gist_id}","starred_url":"https://api.github.com/users/ediosyncratic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ediosyncratic/subscriptions","organizations_url":"https://api.github.com/users/ediosyncratic/orgs","repos_url":"https://api.github.com/users/ediosyncratic/repos","events_url":"https://api.github.com/users/ediosyncratic/events{/privacy}","received_events_url":"https://api.github.com/users/ediosyncratic/received_events","type":"User","site_admin":false},"body":"The comment's phrasing worked better when the sleep was part of this command, but it's now separate.\r\nI'd rephrase or move adjacent to the next command ...","created_at":"2014-03-03T10:03:33Z","updated_at":"2014-03-03T10:03:33Z","html_url":"https://github.com/cfengine/core/pull/1508#discussion_r10205359","pull_request_url":"https://api.github.com/repos/cfengine/core/pulls/1508","_links":{"self":{"href":"https://api.github.com/repos/cfengine/core/pulls/comments/10205359"},"html":{"href":"https://github.com/cfengine/core/pull/1508#discussion_r10205359"},"pull_request":{"href":"https://api.github.com/repos/cfengine/core/pulls/1508"}}}}