GitHub PullRequestReviewCommentEvent at 2014-12-18 07:21:07
Repository: abstractit-puppet
Actor: wolfspyre
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/abstractitptyltd/abstractit-puppet/pulls/comments/22026582","id":22026582,"diff_hunk":"@@ -0,0 +1,33 @@\n+# == Class: puppet::master::env","path":"manifests/master/env.pp","position":1,"original_position":1,"commit_id":"953ca09aa1dc3e15c71f5f40fbf090ab25dc2f24","original_commit_id":"953ca09aa1dc3e15c71f5f40fbf090ab25dc2f24","user":{"login":"wolfspyre","id":1680659,"avatar_url":"https://avatars.githubusercontent.com/u/1680659?v=3","gravatar_id":"","url":"https://api.github.com/users/wolfspyre","html_url":"https://github.com/wolfspyre","followers_url":"https://api.github.com/users/wolfspyre/followers","following_url":"https://api.github.com/users/wolfspyre/following{/other_user}","gists_url":"https://api.github.com/users/wolfspyre/gists{/gist_id}","starred_url":"https://api.github.com/users/wolfspyre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wolfspyre/subscriptions","organizations_url":"https://api.github.com/users/wolfspyre/orgs","repos_url":"https://api.github.com/users/wolfspyre/repos","events_url":"https://api.github.com/users/wolfspyre/events{/privacy}","received_events_url":"https://api.github.com/users/wolfspyre/received_events","type":"User","site_admin":false},"body":"I'm not opposed to the abstraction of default variables into its own subclass, but I question its' merit. What benefit do you feel this provides?","created_at":"2014-12-18T07:21:07Z","updated_at":"2014-12-18T07:21:07Z","html_url":"https://github.com/abstractitptyltd/abstractit-puppet/pull/36#discussion_r22026582","pull_request_url":"https://api.github.com/repos/abstractitptyltd/abstractit-puppet/pulls/36","_links":{"self":{"href":"https://api.github.com/repos/abstractitptyltd/abstractit-puppet/pulls/comments/22026582"},"html":{"href":"https://github.com/abstractitptyltd/abstractit-puppet/pull/36#discussion_r22026582"},"pull_request":{"href":"https://api.github.com/repos/abstractitptyltd/abstractit-puppet/pulls/36"}}},"pull_request":{"url":"https://api.github.com/repos/abstractitptyltd/abstractit-puppet/pulls/36","id":26264288,"html_url":"https://github.com/abstractitptyltd/abstractit-puppet/pull/36","diff_url":"https://github.com/abstractitptyltd/abstractit-puppet/pull/36.diff","patch_url":"https://github.com/abstractitptyltd/abstractit-puppet/pull/36.patch","issue_url":"https://api.github.com/repos/abstractitptyltd/abstractit-puppet/issues/36","number":36,"state":"open","locked":false,"title":"Support running Puppet masters from raw gems rather than apt packages.","user":{"login":"diranged","id":768067,"avatar_url":"https://avatars.githubusercontent.com/u/768067?v=3","gravatar_id":"","url":"https://api.github.com/users/diranged","html_url":"https://github.com/diranged","followers_url":"https://api.github.com/users/diranged/followers","following_url":"https://api.github.com/users/diranged/following{/other_user}","gists_url":"https://api.github.com/users/diranged/gists{/gist_id}","starred_url":"https://api.github.com/users/diranged/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diranged/subscriptions","organizations_url":"https://api.github.com/users/diranged/orgs","repos_url":"https://api.github.com/users/diranged/repos","events_url":"https://api.github.com/users/diranged/events{/privacy}","received_events_url":"https://api.github.com/users/diranged/received_events","type":"User","site_admin":false},"body":"Ok guys, this is a total work in progress... I'll likely make 30 more commits before its ready, so don't treat this as a merge-able PR. Instead, I'm looking for your feedback on my re-structuring of the classes into parameterized classes. I strongly suggest this model because its far more easily unit testable (see how much simpler the unit tests get). Additionally, it makes things a bit more explicit (rather than doing class-to-class private variable sharing, which is pretty dangerous).","created_at":"2014-12-17T22:57:52Z","updated_at":"2014-12-18T07:21:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"306a71dc8f460016949a164a0e92250303e2e411","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/abstractitptyltd/abstractit-puppet/pulls/36/commits","review_comments_url":"https://api.github.com/repos/abstractitptyltd/abstractit-puppet/pulls/36/comments","review_comment_url":"https://api.github.com/repos/abstractitptyltd/abstractit-puppet/pulls/comments/{number}","comments_url":"https://api.github.com/repos/abstractitptyltd/abstractit-puppet/issues/36/comments","statuses_url":"https://api.github.com/repos/abstractitptyltd/abstractit-puppet/statuses/953ca09aa1dc3e15c71f5f40fbf090ab25dc2f24","head":{"label":"diranged:gem_puppet_master","ref":"gem_puppet_master","sha":"953ca09aa1dc3e15c71f5f40fbf090ab25dc2f24","user":{"login":"diranged","id":768067,"avatar_url":"https://avatars.githubusercontent.com/u/768067?v=3","gravatar_id":"","url":"https://api.github.com/users/diranged","html_url":"https://github.com/diranged","followers_url":"https://api.github.com/users/diranged/followers","following_url":"https://api.github.com/users/diranged/following{/other_user}","gists_url":"https://api.github.com/users/diranged/gists{/gist_id}","starred_url":"https://api.github.com/users/diranged/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diranged/subscriptions","organizations_url":"https://api.github.com/users/diranged/orgs","repos_url":"https://api.github.com/users/diranged/repos","events_url":"https://api.github.com/users/diranged/events{/privacy}","received_events_url":"https://api.github.com/users/diranged/received_events","type":"User","site_admin":false},"repo":{"id":27935211,"name":"abstractit-puppet","full_name":"diranged/abstractit-puppet","owner":{"login":"diranged","id":768067,"avatar_url":"https://avatars.githubusercontent.com/u/768067?v=3","gravatar_id":"","url":"https://api.github.com/users/diranged","html_url":"https://github.com/diranged","followers_url":"https://api.github.com/users/diranged/followers","following_url":"https://api.github.com/users/diranged/following{/other_user}","gists_url":"https://api.github.com/users/diranged/gists{/gist_id}","starred_url":"https://api.github.com/users/diranged/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diranged/subscriptions","organizations_url":"https://api.github.com/users/diranged/orgs","repos_url":"https://api.github.com/users/diranged/repos","events_url":"https://api.github.com/users/diranged/events{/privacy}","received_events_url":"https://api.github.com/users/diranged/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/diranged/abstractit-puppet","description":"Manage puppet agent, master, modules and hiera with puppet","fork":true,"url":"https://api.github.com/repos/diranged/abstractit-puppet","forks_url":"https://api.github.com/repos/diranged/abstractit-puppet/forks","keys_url":"https://api.github.com/repos/diranged/abstractit-puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/diranged/abstractit-puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/diranged/abstractit-puppet/teams","hooks_url":"https://api.github.com/repos/diranged/abstractit-puppet/hooks","issue_events_url":"https://api.github.com/repos/diranged/abstractit-puppet/issues/events{/number}","events_url":"https://api.github.com/repos/diranged/abstractit-puppet/events","assignees_url":"https://api.github.com/repos/diranged/abstractit-puppet/assignees{/user}","branches_url":"https://api.github.com/repos/diranged/abstractit-puppet/branches{/branch}","tags_url":"https://api.github.com/repos/diranged/abstractit-puppet/tags","blobs_url":"https://api.github.com/repos/diranged/abstractit-puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/diranged/abstractit-puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/diranged/abstractit-puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/diranged/abstractit-puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/diranged/abstractit-puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/diranged/abstractit-puppet/languages","stargazers_url":"https://api.github.com/repos/diranged/abstractit-puppet/stargazers","contributors_url":"https://api.github.com/repos/diranged/abstractit-puppet/contributors","subscribers_url":"https://api.github.com/repos/diranged/abstractit-puppet/subscribers","subscription_url":"https://api.github.com/repos/diranged/abstractit-puppet/subscription","commits_url":"https://api.github.com/repos/diranged/abstractit-puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/diranged/abstractit-puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/diranged/abstractit-puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/diranged/abstractit-puppet/issues/comments/{number}","contents_url":"https://api.github.com/repos/diranged/abstractit-puppet/contents/{+path}","compare_url":"https://api.github.com/repos/diranged/abstractit-puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/diranged/abstractit-puppet/merges","archive_url":"https://api.github.com/repos/diranged/abstractit-puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/diranged/abstractit-puppet/downloads","issues_url":"https://api.github.com/repos/diranged/abstractit-puppet/issues{/number}","pulls_url":"https://api.github.com/repos/diranged/abstractit-puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/diranged/abstractit-puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/diranged/abstractit-puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/diranged/abstractit-puppet/labels{/name}","releases_url":"https://api.github.com/repos/diranged/abstractit-puppet/releases{/id}","created_at":"2014-12-12T19:38:36Z","updated_at":"2014-12-12T19:38:37Z","pushed_at":"2014-12-17T23:20:34Z","git_url":"git://github.com/diranged/abstractit-puppet.git","ssh_url":"git@github.com:diranged/abstractit-puppet.git","clone_url":"https://github.com/diranged/abstractit-puppet.git","svn_url":"https://github.com/diranged/abstractit-puppet","homepage":"https://forge.puppetlabs.com/abstractit/puppet","size":280,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"production"}},"base":{"label":"abstractitptyltd:production","ref":"production","sha":"dd3519d068e8ee5b937df05e5e09103868447ada","user":{"login":"abstractitptyltd","id":5934760,"avatar_url":"https://avatars.githubusercontent.com/u/5934760?v=3","gravatar_id":"","url":"https://api.github.com/users/abstractitptyltd","html_url":"https://github.com/abstractitptyltd","followers_url":"https://api.github.com/users/abstractitptyltd/followers","following_url":"https://api.github.com/users/abstractitptyltd/following{/other_user}","gists_url":"https://api.github.com/users/abstractitptyltd/gists{/gist_id}","starred_url":"https://api.github.com/users/abstractitptyltd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abstractitptyltd/subscriptions","organizations_url":"https://api.github.com/users/abstractitptyltd/orgs","repos_url":"https://api.github.com/users/abstractitptyltd/repos","events_url":"https://api.github.com/users/abstractitptyltd/events{/privacy}","received_events_url":"https://api.github.com/users/abstractitptyltd/received_events","type":"Organization","site_admin":false},"repo":{"id":20823942,"name":"abstractit-puppet","full_name":"abstractitptyltd/abstractit-puppet","owner":{"login":"abstractitptyltd","id":5934760,"avatar_url":"https://avatars.githubusercontent.com/u/5934760?v=3","gravatar_id":"","url":"https://api.github.com/users/abstractitptyltd","html_url":"https://github.com/abstractitptyltd","followers_url":"https://api.github.com/users/abstractitptyltd/followers","following_url":"https://api.github.com/users/abstractitptyltd/following{/other_user}","gists_url":"https://api.github.com/users/abstractitptyltd/gists{/gist_id}","starred_url":"https://api.github.com/users/abstractitptyltd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abstractitptyltd/subscriptions","organizations_url":"https://api.github.com/users/abstractitptyltd/orgs","repos_url":"https://api.github.com/users/abstractitptyltd/repos","events_url":"https://api.github.com/users/abstractitptyltd/events{/privacy}","received_events_url":"https://api.github.com/users/abstractitptyltd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/abstractitptyltd/abstractit-puppet","description":"Manage puppet agent, master, modules and hiera with puppet","fork":false,"url":"https://api.github.com/repos/abstractitptyltd/abstractit-puppet","forks_url":"https://api.github.com/repos/abstractitptyltd/abstractit-puppet/forks","keys_url":"https://api.github.com/repos/abstractitptyltd/abstractit-puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/abstractitptyltd/abstractit-puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/abstractitptyltd/abstractit-puppet/teams","hooks_url":"https://api.github.com/repos/abstractitptyltd/abstractit-puppet/hooks","issue_events_url":"https://api.github.com/repos/abstractitptyltd/abstractit-puppet/issues/events{/number}","events_url":"https://api.github.com/repos/abstractitptyltd/abstractit-puppet/events","assignees_url":"https://api.github.com/repos/abstractitptyltd/abstractit-puppet/assignees{/user}","branches_url":"https://api.github.com/repos/abstractitptyltd/abstractit-puppet/branches{/branch}","tags_url":"https://api.github.com/repos/abstractitptyltd/abstractit-puppet/tags","blobs_url":"https://api.github.com/repos/abstractitptyltd/abstractit-puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/abstractitptyltd/abstractit-puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/abstractitptyltd/abstractit-puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/abstractitptyltd/abstractit-puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/abstractitptyltd/abstractit-puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/abstractitptyltd/abstractit-puppet/languages","stargazers_url":"https://api.github.com/repos/abstractitptyltd/abstractit-puppet/stargazers","contributors_url":"https://api.github.com/repos/abstractitptyltd/abstractit-puppet/contributors","subscribers_url":"https://api.github.com/repos/abstractitptyltd/abstractit-puppet/subscribers","subscription_url":"https://api.github.com/repos/abstractitptyltd/abstractit-puppet/subscription","commits_url":"https://api.github.com/repos/abstractitptyltd/abstractit-puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/abstractitptyltd/abstractit-puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/abstractitptyltd/abstractit-puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/abstractitptyltd/abstractit-puppet/issues/comments/{number}","contents_url":"https://api.github.com/repos/abstractitptyltd/abstractit-puppet/contents/{+path}","compare_url":"https://api.github.com/repos/abstractitptyltd/abstractit-puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/abstractitptyltd/abstractit-puppet/merges","archive_url":"https://api.github.com/repos/abstractitptyltd/abstractit-puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/abstractitptyltd/abstractit-puppet/downloads","issues_url":"https://api.github.com/repos/abstractitptyltd/abstractit-puppet/issues{/number}","pulls_url":"https://api.github.com/repos/abstractitptyltd/abstractit-puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/abstractitptyltd/abstractit-puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/abstractitptyltd/abstractit-puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/abstractitptyltd/abstractit-puppet/labels{/name}","releases_url":"https://api.github.com/repos/abstractitptyltd/abstractit-puppet/releases{/id}","created_at":"2014-06-14T03:12:12Z","updated_at":"2014-10-15T11:02:16Z","pushed_at":"2014-12-14T04:54:24Z","git_url":"git://github.com/abstractitptyltd/abstractit-puppet.git","ssh_url":"git@github.com:abstractitptyltd/abstractit-puppet.git","clone_url":"https://github.com/abstractitptyltd/abstractit-puppet.git","svn_url":"https://github.com/abstractitptyltd/abstractit-puppet","homepage":"https://forge.puppetlabs.com/abstractit/puppet","size":927,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":25,"forks":2,"open_issues":25,"watchers":1,"default_branch":"production"}},"_links":{"self":{"href":"https://api.github.com/repos/abstractitptyltd/abstractit-puppet/pulls/36"},"html":{"href":"https://github.com/abstractitptyltd/abstractit-puppet/pull/36"},"issue":{"href":"https://api.github.com/repos/abstractitptyltd/abstractit-puppet/issues/36"},"comments":{"href":"https://api.github.com/repos/abstractitptyltd/abstractit-puppet/issues/36/comments"},"review_comments":{"href":"https://api.github.com/repos/abstractitptyltd/abstractit-puppet/pulls/36/comments"},"review_comment":{"href":"https://api.github.com/repos/abstractitptyltd/abstractit-puppet/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/abstractitptyltd/abstractit-puppet/pulls/36/commits"},"statuses":{"href":"https://api.github.com/repos/abstractitptyltd/abstractit-puppet/statuses/953ca09aa1dc3e15c71f5f40fbf090ab25dc2f24"}}}}