GitHub PullRequestReviewCommentEvent at 2014-08-19 21:09:48
Repository: grunt-jquery-content
Actor: scottgonzalez
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/jquery/grunt-jquery-content/pulls/comments/16443840","id":16443840,"diff_hunk":"@@ -25,6 +26,12 @@ grunt.registerHelper( \"wordpress-parse-post-flex\", function( path ) {\n \t\tpost = {},\n \t\tcontent = grunt.file.read( path );\n \n+\t//normalize line endings so later search for YAML works cross platform\n+\tif ( os.EOL != \"\\n\" ){\n+\t\tvar re = new RegExp(require('os').EOL, 'g');","path":"tasks/build.js","position":16,"original_position":16,"commit_id":"9daf5c951ef707863bb4cbc7d322eb19e90e7691","original_commit_id":"9daf5c951ef707863bb4cbc7d322eb19e90e7691","user":{"login":"scottgonzalez","id":141167,"avatar_url":"https://avatars.githubusercontent.com/u/141167?v=2","gravatar_id":"35da631954825179143c86fa42a10954","url":"https://api.github.com/users/scottgonzalez","html_url":"https://github.com/scottgonzalez","followers_url":"https://api.github.com/users/scottgonzalez/followers","following_url":"https://api.github.com/users/scottgonzalez/following{/other_user}","gists_url":"https://api.github.com/users/scottgonzalez/gists{/gist_id}","starred_url":"https://api.github.com/users/scottgonzalez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scottgonzalez/subscriptions","organizations_url":"https://api.github.com/users/scottgonzalez/orgs","repos_url":"https://api.github.com/users/scottgonzalez/repos","events_url":"https://api.github.com/users/scottgonzalez/events{/privacy}","received_events_url":"https://api.github.com/users/scottgonzalez/received_events","type":"User","site_admin":false},"body":"Too many `var` statements. Just inline the regex in the replacement.","created_at":"2014-08-19T21:09:48Z","updated_at":"2014-08-19T21:09:48Z","html_url":"https://github.com/jquery/grunt-jquery-content/pull/58#discussion_r16443840","pull_request_url":"https://api.github.com/repos/jquery/grunt-jquery-content/pulls/58","_links":{"self":{"href":"https://api.github.com/repos/jquery/grunt-jquery-content/pulls/comments/16443840"},"html":{"href":"https://github.com/jquery/grunt-jquery-content/pull/58#discussion_r16443840"},"pull_request":{"href":"https://api.github.com/repos/jquery/grunt-jquery-content/pulls/58"}}},"pull_request":{"url":"https://api.github.com/repos/jquery/grunt-jquery-content/pulls/58","id":19610670,"html_url":"https://github.com/jquery/grunt-jquery-content/pull/58","diff_url":"https://github.com/jquery/grunt-jquery-content/pull/58.diff","patch_url":"https://github.com/jquery/grunt-jquery-content/pull/58.patch","issue_url":"https://api.github.com/repos/jquery/grunt-jquery-content/issues/58","number":58,"state":"open","locked":false,"title":"Line ending parsing is not cross platform","user":{"login":"garywu","id":38446,"avatar_url":"https://avatars.githubusercontent.com/u/38446?v=2","gravatar_id":"c4e4756f820ba3e227b8fb64de8d9318","url":"https://api.github.com/users/garywu","html_url":"https://github.com/garywu","followers_url":"https://api.github.com/users/garywu/followers","following_url":"https://api.github.com/users/garywu/following{/other_user}","gists_url":"https://api.github.com/users/garywu/gists{/gist_id}","starred_url":"https://api.github.com/users/garywu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garywu/subscriptions","organizations_url":"https://api.github.com/users/garywu/orgs","repos_url":"https://api.github.com/users/garywu/repos","events_url":"https://api.github.com/users/garywu/events{/privacy}","received_events_url":"https://api.github.com/users/garywu/received_events","type":"User","site_admin":false},"body":"When following [Contributing to jQuery Foundation Web Sites](http://contribute.jquery.org/web-sites/) on Windows. grunt deploy fails with following message:\r\n```\r\nC:\\code\\jquery\\contribute.jquery.org>grunt deploy\r\nRunning \"clean:wordpress\" (clean) task\r\nFolder \"dist/\" contents removed.\r\n\r\nRunning \"lint:grunt\" (lint) task\r\nLint free.\r\n\r\nRunning \"build-pages:all\" (build-pages) task\r\nBuilt 18 pages.\r\n\r\nRunning \"build-resources:all\" (build-resources) task\r\nBuilt 5 resources.\r\n\r\nRunning \"wordpress-validate\" task\r\nValidated 0 terms.\r\n>> Error: dist/wordpress/posts/page/bug-reports.html is missing required data: t\r\nitle\r\n>> Error: dist/wordpress/posts/page/bug-reports.html is missing required data: t\r\nitle\r\n<WARN> Task \"wordpress-validate\" failed. Use --force to continue. </WARN>\r\n\r\nAborted due to warnings.\r\n```\r\nThe cause is that grunt-jquery-content failed to parse out YAML headers because UNIX line ending is hard-coded.\r\n\r\nThe fix is to normalize file content by replacing platform specific line ending defined by os.EOL with '\\n' before the YAML parsing.","created_at":"2014-08-11T16:15:29Z","updated_at":"2014-08-19T21:09:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c3cba3b9cca66cefe7fc6b997be026c2b3b5b477","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jquery/grunt-jquery-content/pulls/58/commits","review_comments_url":"https://api.github.com/repos/jquery/grunt-jquery-content/pulls/58/comments","review_comment_url":"https://api.github.com/repos/jquery/grunt-jquery-content/pulls/comments/{number}","comments_url":"https://api.github.com/repos/jquery/grunt-jquery-content/issues/58/comments","statuses_url":"https://api.github.com/repos/jquery/grunt-jquery-content/statuses/9daf5c951ef707863bb4cbc7d322eb19e90e7691","head":{"label":"garywu:master","ref":"master","sha":"9daf5c951ef707863bb4cbc7d322eb19e90e7691","user":{"login":"garywu","id":38446,"avatar_url":"https://avatars.githubusercontent.com/u/38446?v=2","gravatar_id":"c4e4756f820ba3e227b8fb64de8d9318","url":"https://api.github.com/users/garywu","html_url":"https://github.com/garywu","followers_url":"https://api.github.com/users/garywu/followers","following_url":"https://api.github.com/users/garywu/following{/other_user}","gists_url":"https://api.github.com/users/garywu/gists{/gist_id}","starred_url":"https://api.github.com/users/garywu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garywu/subscriptions","organizations_url":"https://api.github.com/users/garywu/orgs","repos_url":"https://api.github.com/users/garywu/repos","events_url":"https://api.github.com/users/garywu/events{/privacy}","received_events_url":"https://api.github.com/users/garywu/received_events","type":"User","site_admin":false},"repo":{"id":22845113,"name":"grunt-jquery-content","full_name":"garywu/grunt-jquery-content","owner":{"login":"garywu","id":38446,"avatar_url":"https://avatars.githubusercontent.com/u/38446?v=2","gravatar_id":"c4e4756f820ba3e227b8fb64de8d9318","url":"https://api.github.com/users/garywu","html_url":"https://github.com/garywu","followers_url":"https://api.github.com/users/garywu/followers","following_url":"https://api.github.com/users/garywu/following{/other_user}","gists_url":"https://api.github.com/users/garywu/gists{/gist_id}","starred_url":"https://api.github.com/users/garywu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garywu/subscriptions","organizations_url":"https://api.github.com/users/garywu/orgs","repos_url":"https://api.github.com/users/garywu/repos","events_url":"https://api.github.com/users/garywu/events{/privacy}","received_events_url":"https://api.github.com/users/garywu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/garywu/grunt-jquery-content","description":"","fork":true,"url":"https://api.github.com/repos/garywu/grunt-jquery-content","forks_url":"https://api.github.com/repos/garywu/grunt-jquery-content/forks","keys_url":"https://api.github.com/repos/garywu/grunt-jquery-content/keys{/key_id}","collaborators_url":"https://api.github.com/repos/garywu/grunt-jquery-content/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/garywu/grunt-jquery-content/teams","hooks_url":"https://api.github.com/repos/garywu/grunt-jquery-content/hooks","issue_events_url":"https://api.github.com/repos/garywu/grunt-jquery-content/issues/events{/number}","events_url":"https://api.github.com/repos/garywu/grunt-jquery-content/events","assignees_url":"https://api.github.com/repos/garywu/grunt-jquery-content/assignees{/user}","branches_url":"https://api.github.com/repos/garywu/grunt-jquery-content/branches{/branch}","tags_url":"https://api.github.com/repos/garywu/grunt-jquery-content/tags","blobs_url":"https://api.github.com/repos/garywu/grunt-jquery-content/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/garywu/grunt-jquery-content/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/garywu/grunt-jquery-content/git/refs{/sha}","trees_url":"https://api.github.com/repos/garywu/grunt-jquery-content/git/trees{/sha}","statuses_url":"https://api.github.com/repos/garywu/grunt-jquery-content/statuses/{sha}","languages_url":"https://api.github.com/repos/garywu/grunt-jquery-content/languages","stargazers_url":"https://api.github.com/repos/garywu/grunt-jquery-content/stargazers","contributors_url":"https://api.github.com/repos/garywu/grunt-jquery-content/contributors","subscribers_url":"https://api.github.com/repos/garywu/grunt-jquery-content/subscribers","subscription_url":"https://api.github.com/repos/garywu/grunt-jquery-content/subscription","commits_url":"https://api.github.com/repos/garywu/grunt-jquery-content/commits{/sha}","git_commits_url":"https://api.github.com/repos/garywu/grunt-jquery-content/git/commits{/sha}","comments_url":"https://api.github.com/repos/garywu/grunt-jquery-content/comments{/number}","issue_comment_url":"https://api.github.com/repos/garywu/grunt-jquery-content/issues/comments/{number}","contents_url":"https://api.github.com/repos/garywu/grunt-jquery-content/contents/{+path}","compare_url":"https://api.github.com/repos/garywu/grunt-jquery-content/compare/{base}...{head}","merges_url":"https://api.github.com/repos/garywu/grunt-jquery-content/merges","archive_url":"https://api.github.com/repos/garywu/grunt-jquery-content/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/garywu/grunt-jquery-content/downloads","issues_url":"https://api.github.com/repos/garywu/grunt-jquery-content/issues{/number}","pulls_url":"https://api.github.com/repos/garywu/grunt-jquery-content/pulls{/number}","milestones_url":"https://api.github.com/repos/garywu/grunt-jquery-content/milestones{/number}","notifications_url":"https://api.github.com/repos/garywu/grunt-jquery-content/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/garywu/grunt-jquery-content/labels{/name}","releases_url":"https://api.github.com/repos/garywu/grunt-jquery-content/releases{/id}","created_at":"2014-08-11T15:59:05Z","updated_at":"2014-08-11T16:01:16Z","pushed_at":"2014-08-13T15:44:07Z","git_url":"git://github.com/garywu/grunt-jquery-content.git","ssh_url":"git@github.com:garywu/grunt-jquery-content.git","clone_url":"https://github.com/garywu/grunt-jquery-content.git","svn_url":"https://github.com/garywu/grunt-jquery-content","homepage":null,"size":263,"stargazers_count":0,"watchers_count":0,"language":"XSLT","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jquery:master","ref":"master","sha":"949c8c3c11c33b1104bb2f123b3bab94239a382a","user":{"login":"jquery","id":70142,"avatar_url":"https://avatars.githubusercontent.com/u/70142?v=2","gravatar_id":"6906f317a4733f4379b06c32229ef02f","url":"https://api.github.com/users/jquery","html_url":"https://github.com/jquery","followers_url":"https://api.github.com/users/jquery/followers","following_url":"https://api.github.com/users/jquery/following{/other_user}","gists_url":"https://api.github.com/users/jquery/gists{/gist_id}","starred_url":"https://api.github.com/users/jquery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jquery/subscriptions","organizations_url":"https://api.github.com/users/jquery/orgs","repos_url":"https://api.github.com/users/jquery/repos","events_url":"https://api.github.com/users/jquery/events{/privacy}","received_events_url":"https://api.github.com/users/jquery/received_events","type":"Organization","site_admin":false},"repo":{"id":4702006,"name":"grunt-jquery-content","full_name":"jquery/grunt-jquery-content","owner":{"login":"jquery","id":70142,"avatar_url":"https://avatars.githubusercontent.com/u/70142?v=2","gravatar_id":"6906f317a4733f4379b06c32229ef02f","url":"https://api.github.com/users/jquery","html_url":"https://github.com/jquery","followers_url":"https://api.github.com/users/jquery/followers","following_url":"https://api.github.com/users/jquery/following{/other_user}","gists_url":"https://api.github.com/users/jquery/gists{/gist_id}","starred_url":"https://api.github.com/users/jquery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jquery/subscriptions","organizations_url":"https://api.github.com/users/jquery/orgs","repos_url":"https://api.github.com/users/jquery/repos","events_url":"https://api.github.com/users/jquery/events{/privacy}","received_events_url":"https://api.github.com/users/jquery/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jquery/grunt-jquery-content","description":"","fork":false,"url":"https://api.github.com/repos/jquery/grunt-jquery-content","forks_url":"https://api.github.com/repos/jquery/grunt-jquery-content/forks","keys_url":"https://api.github.com/repos/jquery/grunt-jquery-content/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jquery/grunt-jquery-content/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jquery/grunt-jquery-content/teams","hooks_url":"https://api.github.com/repos/jquery/grunt-jquery-content/hooks","issue_events_url":"https://api.github.com/repos/jquery/grunt-jquery-content/issues/events{/number}","events_url":"https://api.github.com/repos/jquery/grunt-jquery-content/events","assignees_url":"https://api.github.com/repos/jquery/grunt-jquery-content/assignees{/user}","branches_url":"https://api.github.com/repos/jquery/grunt-jquery-content/branches{/branch}","tags_url":"https://api.github.com/repos/jquery/grunt-jquery-content/tags","blobs_url":"https://api.github.com/repos/jquery/grunt-jquery-content/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jquery/grunt-jquery-content/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jquery/grunt-jquery-content/git/refs{/sha}","trees_url":"https://api.github.com/repos/jquery/grunt-jquery-content/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jquery/grunt-jquery-content/statuses/{sha}","languages_url":"https://api.github.com/repos/jquery/grunt-jquery-content/languages","stargazers_url":"https://api.github.com/repos/jquery/grunt-jquery-content/stargazers","contributors_url":"https://api.github.com/repos/jquery/grunt-jquery-content/contributors","subscribers_url":"https://api.github.com/repos/jquery/grunt-jquery-content/subscribers","subscription_url":"https://api.github.com/repos/jquery/grunt-jquery-content/subscription","commits_url":"https://api.github.com/repos/jquery/grunt-jquery-content/commits{/sha}","git_commits_url":"https://api.github.com/repos/jquery/grunt-jquery-content/git/commits{/sha}","comments_url":"https://api.github.com/repos/jquery/grunt-jquery-content/comments{/number}","issue_comment_url":"https://api.github.com/repos/jquery/grunt-jquery-content/issues/comments/{number}","contents_url":"https://api.github.com/repos/jquery/grunt-jquery-content/contents/{+path}","compare_url":"https://api.github.com/repos/jquery/grunt-jquery-content/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jquery/grunt-jquery-content/merges","archive_url":"https://api.github.com/repos/jquery/grunt-jquery-content/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jquery/grunt-jquery-content/downloads","issues_url":"https://api.github.com/repos/jquery/grunt-jquery-content/issues{/number}","pulls_url":"https://api.github.com/repos/jquery/grunt-jquery-content/pulls{/number}","milestones_url":"https://api.github.com/repos/jquery/grunt-jquery-content/milestones{/number}","notifications_url":"https://api.github.com/repos/jquery/grunt-jquery-content/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jquery/grunt-jquery-content/labels{/name}","releases_url":"https://api.github.com/repos/jquery/grunt-jquery-content/releases{/id}","created_at":"2012-06-18T14:42:47Z","updated_at":"2014-07-18T16:24:08Z","pushed_at":"2014-08-19T20:26:05Z","git_url":"git://github.com/jquery/grunt-jquery-content.git","ssh_url":"git@github.com:jquery/grunt-jquery-content.git","clone_url":"https://github.com/jquery/grunt-jquery-content.git","svn_url":"https://github.com/jquery/grunt-jquery-content","homepage":null,"size":797,"stargazers_count":26,"watchers_count":26,"language":"XSLT","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":22,"mirror_url":null,"open_issues_count":11,"forks":22,"open_issues":11,"watchers":26,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jquery/grunt-jquery-content/pulls/58"},"html":{"href":"https://github.com/jquery/grunt-jquery-content/pull/58"},"issue":{"href":"https://api.github.com/repos/jquery/grunt-jquery-content/issues/58"},"comments":{"href":"https://api.github.com/repos/jquery/grunt-jquery-content/issues/58/comments"},"review_comments":{"href":"https://api.github.com/repos/jquery/grunt-jquery-content/pulls/58/comments"},"review_comment":{"href":"https://api.github.com/repos/jquery/grunt-jquery-content/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/jquery/grunt-jquery-content/pulls/58/commits"},"statuses":{"href":"https://api.github.com/repos/jquery/grunt-jquery-content/statuses/9daf5c951ef707863bb4cbc7d322eb19e90e7691"}}}}