GitHub PullRequestReviewCommentEvent at 2014-06-06 13:32:54
Repository: connect
Actor: jreidinger
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/SUSE/connect/pulls/comments/13489394","id":13489394,"diff_hunk":"@@ -0,0 +1,63 @@\n+require 'spec_helper'\n+\n+describe SUSE::Connect::RegServerProduct do\n+\n+  subject do\n+    extension = {\n+      'id' => 700,\n+      'name' => 'SLEEK',\n+      'long_name' => 'SUSE LINUX ENTERPRISE EXTENSION KDE',\n+      'description' => 'SLEEK puts the modern yet familiar GUI back into SLE that you love',\n+      'zypper_name' => 'SLEEK-12',\n+      'zypper_version' => '12',\n+      'arch' => 'x86_64',\n+      'free' => true,\n+      'eula_url' => 'https://nu.novell.com/SUSE:/Products:/SLE-12/images/' \\\n+      'repo/SLE-12-module-sleek-POOL-x86_64-Media.license/'\n+    }\n+    described_class.new(extension)\n+  end\n+\n+  it_behaves_like 'server driven model'\n+\n+  describe '#==' do\n+\n+    context :zypper_product do\n+\n+      it 'equal with other product if product_ident, version and arch are equal' do\n+        zypper_product = Product.new('zypper_name' => 'SLEEK-12', 'zypper_version' => '12', 'arch' => 'x86_64')\n+        expect(subject == zypper_product).to be true\n+      end\n+\n+      it 'is not equal with other product if product_ident or version or arch are different' do\n+        zypper_product = Product.new('zypper_name' => 'SLEEK-12', 'zypper_version' => '13', 'arch' => 'x86_64')\n+        expect(subject == zypper_product).to be false\n+      end\n+\n+      it 'is not equal with other product if product_ident or version or arch are different' do\n+        zypper_product = Product.new('zypper_name' => 'PLEEK-12', 'zypper_version' => '12', 'arch' => 'x86_64')\n+        expect(subject == zypper_product).to be false\n+      end\n+\n+      it 'is not equal with other product if product_ident or version or arch are different' do\n+        zypper_product = Product.new('zypper_name' => 'SLEEK-12', 'zypper_version' => '12', 'arch' => 'ia64')\n+        expect(subject == zypper_product).to be false\n+      end\n+\n+      it 'is not equal with other product if product_ident or version or arch are nil' do","path":"spec/connect/reg_server_product_spec.rb","position":47,"original_position":47,"commit_id":"3e8eea98e1ec399f143edb3c03b5dc3081fcc671","original_commit_id":"3e8eea98e1ec399f143edb3c03b5dc3081fcc671","user":{"login":"jreidinger","id":478871,"avatar_url":"https://avatars.githubusercontent.com/u/478871?","gravatar_id":"f9a9cf77af20d925b328ee8c95c0068c","url":"https://api.github.com/users/jreidinger","html_url":"https://github.com/jreidinger","followers_url":"https://api.github.com/users/jreidinger/followers","following_url":"https://api.github.com/users/jreidinger/following{/other_user}","gists_url":"https://api.github.com/users/jreidinger/gists{/gist_id}","starred_url":"https://api.github.com/users/jreidinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jreidinger/subscriptions","organizations_url":"https://api.github.com/users/jreidinger/orgs","repos_url":"https://api.github.com/users/jreidinger/repos","events_url":"https://api.github.com/users/jreidinger/events{/privacy}","received_events_url":"https://api.github.com/users/jreidinger/received_events","type":"User","site_admin":false},"body":"this is not true. Code simply compare it, so if both source and other product have nil, then it is `true`","created_at":"2014-06-06T13:32:54Z","updated_at":"2014-06-06T13:32:54Z","html_url":"https://github.com/SUSE/connect/pull/93#discussion_r13489394","pull_request_url":"https://api.github.com/repos/SUSE/connect/pulls/93","_links":{"self":{"href":"https://api.github.com/repos/SUSE/connect/pulls/comments/13489394"},"html":{"href":"https://github.com/SUSE/connect/pull/93#discussion_r13489394"},"pull_request":{"href":"https://api.github.com/repos/SUSE/connect/pulls/93"}}},"pull_request":{"url":"https://api.github.com/repos/SUSE/connect/pulls/93","id":16588183,"html_url":"https://github.com/SUSE/connect/pull/93","diff_url":"https://github.com/SUSE/connect/pull/93.diff","patch_url":"https://github.com/SUSE/connect/pull/93.patch","issue_url":"https://api.github.com/repos/SUSE/connect/issues/93","number":93,"state":"open","title":"[Review] Request from 'KalabiYau' @ 'SUSE/connect/review_140602_add_status_model'","user":{"login":"kalabiyau","id":294998,"avatar_url":"https://avatars.githubusercontent.com/u/294998?","gravatar_id":"abc326a22518dfaa478dd9a1240d2898","url":"https://api.github.com/users/kalabiyau","html_url":"https://github.com/kalabiyau","followers_url":"https://api.github.com/users/kalabiyau/followers","following_url":"https://api.github.com/users/kalabiyau/following{/other_user}","gists_url":"https://api.github.com/users/kalabiyau/gists{/gist_id}","starred_url":"https://api.github.com/users/kalabiyau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalabiyau/subscriptions","organizations_url":"https://api.github.com/users/kalabiyau/orgs","repos_url":"https://api.github.com/users/kalabiyau/repos","events_url":"https://api.github.com/users/kalabiyau/events{/privacy}","received_events_url":"https://api.github.com/users/kalabiyau/received_events","type":"User","site_admin":false},"body":"Please review the following changes:\n  * d706f06 Implement status key\n  * 39af21f Remove commented debugger\n  * 7c1d52d Added specs for new functionality\n","created_at":"2014-06-02T08:38:08Z","updated_at":"2014-06-06T13:32:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8dd02fdcd1a1e98a165c85a8aa9761afa9f9d484","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/SUSE/connect/pulls/93/commits","review_comments_url":"https://api.github.com/repos/SUSE/connect/pulls/93/comments","review_comment_url":"https://api.github.com/repos/SUSE/connect/pulls/comments/{number}","comments_url":"https://api.github.com/repos/SUSE/connect/issues/93/comments","statuses_url":"https://api.github.com/repos/SUSE/connect/statuses/3e8eea98e1ec399f143edb3c03b5dc3081fcc671","head":{"label":"SUSE:review_140602_add_status_model","ref":"review_140602_add_status_model","sha":"3e8eea98e1ec399f143edb3c03b5dc3081fcc671","user":{"login":"SUSE","id":1067733,"avatar_url":"https://avatars.githubusercontent.com/u/1067733?","gravatar_id":"5a3b77ef77146dde2115a5b03ab61201","url":"https://api.github.com/users/SUSE","html_url":"https://github.com/SUSE","followers_url":"https://api.github.com/users/SUSE/followers","following_url":"https://api.github.com/users/SUSE/following{/other_user}","gists_url":"https://api.github.com/users/SUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE/subscriptions","organizations_url":"https://api.github.com/users/SUSE/orgs","repos_url":"https://api.github.com/users/SUSE/repos","events_url":"https://api.github.com/users/SUSE/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE/received_events","type":"Organization","site_admin":false},"repo":{"id":16274443,"name":"connect","full_name":"SUSE/connect","owner":{"login":"SUSE","id":1067733,"avatar_url":"https://avatars.githubusercontent.com/u/1067733?","gravatar_id":"5a3b77ef77146dde2115a5b03ab61201","url":"https://api.github.com/users/SUSE","html_url":"https://github.com/SUSE","followers_url":"https://api.github.com/users/SUSE/followers","following_url":"https://api.github.com/users/SUSE/following{/other_user}","gists_url":"https://api.github.com/users/SUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE/subscriptions","organizations_url":"https://api.github.com/users/SUSE/orgs","repos_url":"https://api.github.com/users/SUSE/repos","events_url":"https://api.github.com/users/SUSE/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SUSE/connect","description":"SUSEConnect Client","fork":false,"url":"https://api.github.com/repos/SUSE/connect","forks_url":"https://api.github.com/repos/SUSE/connect/forks","keys_url":"https://api.github.com/repos/SUSE/connect/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SUSE/connect/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SUSE/connect/teams","hooks_url":"https://api.github.com/repos/SUSE/connect/hooks","issue_events_url":"https://api.github.com/repos/SUSE/connect/issues/events{/number}","events_url":"https://api.github.com/repos/SUSE/connect/events","assignees_url":"https://api.github.com/repos/SUSE/connect/assignees{/user}","branches_url":"https://api.github.com/repos/SUSE/connect/branches{/branch}","tags_url":"https://api.github.com/repos/SUSE/connect/tags","blobs_url":"https://api.github.com/repos/SUSE/connect/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SUSE/connect/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SUSE/connect/git/refs{/sha}","trees_url":"https://api.github.com/repos/SUSE/connect/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SUSE/connect/statuses/{sha}","languages_url":"https://api.github.com/repos/SUSE/connect/languages","stargazers_url":"https://api.github.com/repos/SUSE/connect/stargazers","contributors_url":"https://api.github.com/repos/SUSE/connect/contributors","subscribers_url":"https://api.github.com/repos/SUSE/connect/subscribers","subscription_url":"https://api.github.com/repos/SUSE/connect/subscription","commits_url":"https://api.github.com/repos/SUSE/connect/commits{/sha}","git_commits_url":"https://api.github.com/repos/SUSE/connect/git/commits{/sha}","comments_url":"https://api.github.com/repos/SUSE/connect/comments{/number}","issue_comment_url":"https://api.github.com/repos/SUSE/connect/issues/comments/{number}","contents_url":"https://api.github.com/repos/SUSE/connect/contents/{+path}","compare_url":"https://api.github.com/repos/SUSE/connect/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SUSE/connect/merges","archive_url":"https://api.github.com/repos/SUSE/connect/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SUSE/connect/downloads","issues_url":"https://api.github.com/repos/SUSE/connect/issues{/number}","pulls_url":"https://api.github.com/repos/SUSE/connect/pulls{/number}","milestones_url":"https://api.github.com/repos/SUSE/connect/milestones{/number}","notifications_url":"https://api.github.com/repos/SUSE/connect/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SUSE/connect/labels{/name}","releases_url":"https://api.github.com/repos/SUSE/connect/releases{/id}","created_at":"2014-01-27T09:21:26Z","updated_at":"2014-06-06T12:59:09Z","pushed_at":"2014-06-06T12:59:08Z","git_url":"git://github.com/SUSE/connect.git","ssh_url":"git@github.com:SUSE/connect.git","clone_url":"https://github.com/SUSE/connect.git","svn_url":"https://github.com/SUSE/connect","homepage":"https://scc.suse.com","size":6027,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":4,"mirror_url":null,"open_issues_count":5,"forks":4,"open_issues":5,"watchers":3,"default_branch":"master"}},"base":{"label":"SUSE:master","ref":"master","sha":"6707ebe33f8e712ccbb790f75cb0dfa0b7d55683","user":{"login":"SUSE","id":1067733,"avatar_url":"https://avatars.githubusercontent.com/u/1067733?","gravatar_id":"5a3b77ef77146dde2115a5b03ab61201","url":"https://api.github.com/users/SUSE","html_url":"https://github.com/SUSE","followers_url":"https://api.github.com/users/SUSE/followers","following_url":"https://api.github.com/users/SUSE/following{/other_user}","gists_url":"https://api.github.com/users/SUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE/subscriptions","organizations_url":"https://api.github.com/users/SUSE/orgs","repos_url":"https://api.github.com/users/SUSE/repos","events_url":"https://api.github.com/users/SUSE/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE/received_events","type":"Organization","site_admin":false},"repo":{"id":16274443,"name":"connect","full_name":"SUSE/connect","owner":{"login":"SUSE","id":1067733,"avatar_url":"https://avatars.githubusercontent.com/u/1067733?","gravatar_id":"5a3b77ef77146dde2115a5b03ab61201","url":"https://api.github.com/users/SUSE","html_url":"https://github.com/SUSE","followers_url":"https://api.github.com/users/SUSE/followers","following_url":"https://api.github.com/users/SUSE/following{/other_user}","gists_url":"https://api.github.com/users/SUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE/subscriptions","organizations_url":"https://api.github.com/users/SUSE/orgs","repos_url":"https://api.github.com/users/SUSE/repos","events_url":"https://api.github.com/users/SUSE/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SUSE/connect","description":"SUSEConnect Client","fork":false,"url":"https://api.github.com/repos/SUSE/connect","forks_url":"https://api.github.com/repos/SUSE/connect/forks","keys_url":"https://api.github.com/repos/SUSE/connect/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SUSE/connect/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SUSE/connect/teams","hooks_url":"https://api.github.com/repos/SUSE/connect/hooks","issue_events_url":"https://api.github.com/repos/SUSE/connect/issues/events{/number}","events_url":"https://api.github.com/repos/SUSE/connect/events","assignees_url":"https://api.github.com/repos/SUSE/connect/assignees{/user}","branches_url":"https://api.github.com/repos/SUSE/connect/branches{/branch}","tags_url":"https://api.github.com/repos/SUSE/connect/tags","blobs_url":"https://api.github.com/repos/SUSE/connect/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SUSE/connect/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SUSE/connect/git/refs{/sha}","trees_url":"https://api.github.com/repos/SUSE/connect/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SUSE/connect/statuses/{sha}","languages_url":"https://api.github.com/repos/SUSE/connect/languages","stargazers_url":"https://api.github.com/repos/SUSE/connect/stargazers","contributors_url":"https://api.github.com/repos/SUSE/connect/contributors","subscribers_url":"https://api.github.com/repos/SUSE/connect/subscribers","subscription_url":"https://api.github.com/repos/SUSE/connect/subscription","commits_url":"https://api.github.com/repos/SUSE/connect/commits{/sha}","git_commits_url":"https://api.github.com/repos/SUSE/connect/git/commits{/sha}","comments_url":"https://api.github.com/repos/SUSE/connect/comments{/number}","issue_comment_url":"https://api.github.com/repos/SUSE/connect/issues/comments/{number}","contents_url":"https://api.github.com/repos/SUSE/connect/contents/{+path}","compare_url":"https://api.github.com/repos/SUSE/connect/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SUSE/connect/merges","archive_url":"https://api.github.com/repos/SUSE/connect/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SUSE/connect/downloads","issues_url":"https://api.github.com/repos/SUSE/connect/issues{/number}","pulls_url":"https://api.github.com/repos/SUSE/connect/pulls{/number}","milestones_url":"https://api.github.com/repos/SUSE/connect/milestones{/number}","notifications_url":"https://api.github.com/repos/SUSE/connect/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SUSE/connect/labels{/name}","releases_url":"https://api.github.com/repos/SUSE/connect/releases{/id}","created_at":"2014-01-27T09:21:26Z","updated_at":"2014-06-06T12:59:09Z","pushed_at":"2014-06-06T12:59:08Z","git_url":"git://github.com/SUSE/connect.git","ssh_url":"git@github.com:SUSE/connect.git","clone_url":"https://github.com/SUSE/connect.git","svn_url":"https://github.com/SUSE/connect","homepage":"https://scc.suse.com","size":6027,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":4,"mirror_url":null,"open_issues_count":5,"forks":4,"open_issues":5,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SUSE/connect/pulls/93"},"html":{"href":"https://github.com/SUSE/connect/pull/93"},"issue":{"href":"https://api.github.com/repos/SUSE/connect/issues/93"},"comments":{"href":"https://api.github.com/repos/SUSE/connect/issues/93/comments"},"review_comments":{"href":"https://api.github.com/repos/SUSE/connect/pulls/93/comments"},"review_comment":{"href":"https://api.github.com/repos/SUSE/connect/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/SUSE/connect/pulls/93/commits"},"statuses":{"href":"https://api.github.com/repos/SUSE/connect/statuses/3e8eea98e1ec399f143edb3c03b5dc3081fcc671"}}}}