GitHub PullRequestReviewCommentEvent at 2014-11-25 17:14:32
Repository: strong-pm
Actor: kraman
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/strongloop/strong-pm/pulls/comments/20877950","id":20877950,"diff_hunk":"@@ -0,0 +1,22 @@\n+FROM nodesource/node:trusty\n+\n+RUN apt-get install -yq git && apt-get clean\n+# RUN node-gyp install\n+\n+# Create \"strongloop\" user\n+RUN useradd -ms /bin/bash strongloop\n+# && chown -R strongloop /usr/local\n+# Let everyone run sudo without a password (dangerous!)\n+RUN echo \"ALL\tALL = (ALL) NOPASSWD: ALL\" >> /etc/sudoers\n+\n+# Set up some semblance of an environment\n+WORKDIR /home/strongloop\n+ENV HOME /home/strongloop\n+USER strongloop\n+RUN node-gyp install && npm cache clear\n+\n+# actual work..\n+COPY strong-pm.tgz /home/strongloop/\n+RUN sudo npm install --registry NPM_CONFIG_REGISTRY --global strong-pm.tgz","path":"test/Dockerfile.in","position":20,"original_position":20,"commit_id":"50be273e3f6b4fb592b55534d1e63dbfc9d572d6","original_commit_id":"50be273e3f6b4fb592b55534d1e63dbfc9d572d6","user":{"login":"kraman","id":449065,"avatar_url":"https://avatars.githubusercontent.com/u/449065?v=3","gravatar_id":"","url":"https://api.github.com/users/kraman","html_url":"https://github.com/kraman","followers_url":"https://api.github.com/users/kraman/followers","following_url":"https://api.github.com/users/kraman/following{/other_user}","gists_url":"https://api.github.com/users/kraman/gists{/gist_id}","starred_url":"https://api.github.com/users/kraman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kraman/subscriptions","organizations_url":"https://api.github.com/users/kraman/orgs","repos_url":"https://api.github.com/users/kraman/repos","events_url":"https://api.github.com/users/kraman/events{/privacy}","received_events_url":"https://api.github.com/users/kraman/received_events","type":"User","site_admin":false},"body":"Ah ok. If this is just for testing then there is no need to optimize","created_at":"2014-11-25T17:14:32Z","updated_at":"2014-11-25T17:14:32Z","html_url":"https://github.com/strongloop/strong-pm/pull/74#discussion_r20877950","pull_request_url":"https://api.github.com/repos/strongloop/strong-pm/pulls/74","_links":{"self":{"href":"https://api.github.com/repos/strongloop/strong-pm/pulls/comments/20877950"},"html":{"href":"https://github.com/strongloop/strong-pm/pull/74#discussion_r20877950"},"pull_request":{"href":"https://api.github.com/repos/strongloop/strong-pm/pulls/74"}}},"pull_request":{"url":"https://api.github.com/repos/strongloop/strong-pm/pulls/74","id":24882504,"html_url":"https://github.com/strongloop/strong-pm/pull/74","diff_url":"https://github.com/strongloop/strong-pm/pull/74.diff","patch_url":"https://github.com/strongloop/strong-pm/pull/74.patch","issue_url":"https://api.github.com/repos/strongloop/strong-pm/issues/74","number":74,"state":"open","locked":false,"title":"Fix git receive","user":{"login":"rmg","id":17978,"avatar_url":"https://avatars.githubusercontent.com/u/17978?v=3","gravatar_id":"","url":"https://api.github.com/users/rmg","html_url":"https://github.com/rmg","followers_url":"https://api.github.com/users/rmg/followers","following_url":"https://api.github.com/users/rmg/following{/other_user}","gists_url":"https://api.github.com/users/rmg/gists{/gist_id}","starred_url":"https://api.github.com/users/rmg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmg/subscriptions","organizations_url":"https://api.github.com/users/rmg/orgs","repos_url":"https://api.github.com/users/rmg/repos","events_url":"https://api.github.com/users/rmg/events{/privacy}","received_events_url":"https://api.github.com/users/rmg/received_events","type":"User","site_admin":false},"body":"The first commit adds some additional e2e tests that I found useful for rapidly testing git deployments. They are very similar to the Vagrant tests, except they don't cover sl-pm-install. As a bonus, they will actually run on our CI.\r\n\r\nThe second commit is the real fix, and I need some feedback on it. @kraman @sam-github  I'm reasonably happy with the User-Agent based git push detection, but I'm not sure about the tarball one. I left the existing `req.method === 'PUT'` check in place, but that seems highly likely to overlap with a REST style API that makes use of HTTP verbs.\r\n\r\nRefs: #71 ","created_at":"2014-11-22T02:26:03Z","updated_at":"2014-11-25T17:14:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"184c461d1464256ea65510aa48cca8bb64147b7d","assignee":{"login":"rmg","id":17978,"avatar_url":"https://avatars.githubusercontent.com/u/17978?v=3","gravatar_id":"","url":"https://api.github.com/users/rmg","html_url":"https://github.com/rmg","followers_url":"https://api.github.com/users/rmg/followers","following_url":"https://api.github.com/users/rmg/following{/other_user}","gists_url":"https://api.github.com/users/rmg/gists{/gist_id}","starred_url":"https://api.github.com/users/rmg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmg/subscriptions","organizations_url":"https://api.github.com/users/rmg/orgs","repos_url":"https://api.github.com/users/rmg/repos","events_url":"https://api.github.com/users/rmg/events{/privacy}","received_events_url":"https://api.github.com/users/rmg/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/strongloop/strong-pm/pulls/74/commits","review_comments_url":"https://api.github.com/repos/strongloop/strong-pm/pulls/74/comments","review_comment_url":"https://api.github.com/repos/strongloop/strong-pm/pulls/comments/{number}","comments_url":"https://api.github.com/repos/strongloop/strong-pm/issues/74/comments","statuses_url":"https://api.github.com/repos/strongloop/strong-pm/statuses/50be273e3f6b4fb592b55534d1e63dbfc9d572d6","head":{"label":"strongloop:fix/git-receive","ref":"fix/git-receive","sha":"50be273e3f6b4fb592b55534d1e63dbfc9d572d6","user":{"login":"strongloop","id":3020012,"avatar_url":"https://avatars.githubusercontent.com/u/3020012?v=3","gravatar_id":"","url":"https://api.github.com/users/strongloop","html_url":"https://github.com/strongloop","followers_url":"https://api.github.com/users/strongloop/followers","following_url":"https://api.github.com/users/strongloop/following{/other_user}","gists_url":"https://api.github.com/users/strongloop/gists{/gist_id}","starred_url":"https://api.github.com/users/strongloop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strongloop/subscriptions","organizations_url":"https://api.github.com/users/strongloop/orgs","repos_url":"https://api.github.com/users/strongloop/repos","events_url":"https://api.github.com/users/strongloop/events{/privacy}","received_events_url":"https://api.github.com/users/strongloop/received_events","type":"Organization","site_admin":false},"repo":{"id":20460946,"name":"strong-pm","full_name":"strongloop/strong-pm","owner":{"login":"strongloop","id":3020012,"avatar_url":"https://avatars.githubusercontent.com/u/3020012?v=3","gravatar_id":"","url":"https://api.github.com/users/strongloop","html_url":"https://github.com/strongloop","followers_url":"https://api.github.com/users/strongloop/followers","following_url":"https://api.github.com/users/strongloop/following{/other_user}","gists_url":"https://api.github.com/users/strongloop/gists{/gist_id}","starred_url":"https://api.github.com/users/strongloop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strongloop/subscriptions","organizations_url":"https://api.github.com/users/strongloop/orgs","repos_url":"https://api.github.com/users/strongloop/repos","events_url":"https://api.github.com/users/strongloop/events{/privacy}","received_events_url":"https://api.github.com/users/strongloop/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/strongloop/strong-pm","description":"deployer for node applications","fork":false,"url":"https://api.github.com/repos/strongloop/strong-pm","forks_url":"https://api.github.com/repos/strongloop/strong-pm/forks","keys_url":"https://api.github.com/repos/strongloop/strong-pm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/strongloop/strong-pm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/strongloop/strong-pm/teams","hooks_url":"https://api.github.com/repos/strongloop/strong-pm/hooks","issue_events_url":"https://api.github.com/repos/strongloop/strong-pm/issues/events{/number}","events_url":"https://api.github.com/repos/strongloop/strong-pm/events","assignees_url":"https://api.github.com/repos/strongloop/strong-pm/assignees{/user}","branches_url":"https://api.github.com/repos/strongloop/strong-pm/branches{/branch}","tags_url":"https://api.github.com/repos/strongloop/strong-pm/tags","blobs_url":"https://api.github.com/repos/strongloop/strong-pm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/strongloop/strong-pm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/strongloop/strong-pm/git/refs{/sha}","trees_url":"https://api.github.com/repos/strongloop/strong-pm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/strongloop/strong-pm/statuses/{sha}","languages_url":"https://api.github.com/repos/strongloop/strong-pm/languages","stargazers_url":"https://api.github.com/repos/strongloop/strong-pm/stargazers","contributors_url":"https://api.github.com/repos/strongloop/strong-pm/contributors","subscribers_url":"https://api.github.com/repos/strongloop/strong-pm/subscribers","subscription_url":"https://api.github.com/repos/strongloop/strong-pm/subscription","commits_url":"https://api.github.com/repos/strongloop/strong-pm/commits{/sha}","git_commits_url":"https://api.github.com/repos/strongloop/strong-pm/git/commits{/sha}","comments_url":"https://api.github.com/repos/strongloop/strong-pm/comments{/number}","issue_comment_url":"https://api.github.com/repos/strongloop/strong-pm/issues/comments/{number}","contents_url":"https://api.github.com/repos/strongloop/strong-pm/contents/{+path}","compare_url":"https://api.github.com/repos/strongloop/strong-pm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/strongloop/strong-pm/merges","archive_url":"https://api.github.com/repos/strongloop/strong-pm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/strongloop/strong-pm/downloads","issues_url":"https://api.github.com/repos/strongloop/strong-pm/issues{/number}","pulls_url":"https://api.github.com/repos/strongloop/strong-pm/pulls{/number}","milestones_url":"https://api.github.com/repos/strongloop/strong-pm/milestones{/number}","notifications_url":"https://api.github.com/repos/strongloop/strong-pm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/strongloop/strong-pm/labels{/name}","releases_url":"https://api.github.com/repos/strongloop/strong-pm/releases{/id}","created_at":"2014-06-03T21:48:54Z","updated_at":"2014-11-19T01:09:28Z","pushed_at":"2014-11-24T18:13:04Z","git_url":"git://github.com/strongloop/strong-pm.git","ssh_url":"git@github.com:strongloop/strong-pm.git","clone_url":"https://github.com/strongloop/strong-pm.git","svn_url":"https://github.com/strongloop/strong-pm","homepage":null,"size":3140,"stargazers_count":9,"watchers_count":9,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":14,"forks":2,"open_issues":14,"watchers":9,"default_branch":"master"}},"base":{"label":"strongloop:master","ref":"master","sha":"4fbdff2253d417c95fd778988b8bf85e8a13c383","user":{"login":"strongloop","id":3020012,"avatar_url":"https://avatars.githubusercontent.com/u/3020012?v=3","gravatar_id":"","url":"https://api.github.com/users/strongloop","html_url":"https://github.com/strongloop","followers_url":"https://api.github.com/users/strongloop/followers","following_url":"https://api.github.com/users/strongloop/following{/other_user}","gists_url":"https://api.github.com/users/strongloop/gists{/gist_id}","starred_url":"https://api.github.com/users/strongloop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strongloop/subscriptions","organizations_url":"https://api.github.com/users/strongloop/orgs","repos_url":"https://api.github.com/users/strongloop/repos","events_url":"https://api.github.com/users/strongloop/events{/privacy}","received_events_url":"https://api.github.com/users/strongloop/received_events","type":"Organization","site_admin":false},"repo":{"id":20460946,"name":"strong-pm","full_name":"strongloop/strong-pm","owner":{"login":"strongloop","id":3020012,"avatar_url":"https://avatars.githubusercontent.com/u/3020012?v=3","gravatar_id":"","url":"https://api.github.com/users/strongloop","html_url":"https://github.com/strongloop","followers_url":"https://api.github.com/users/strongloop/followers","following_url":"https://api.github.com/users/strongloop/following{/other_user}","gists_url":"https://api.github.com/users/strongloop/gists{/gist_id}","starred_url":"https://api.github.com/users/strongloop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strongloop/subscriptions","organizations_url":"https://api.github.com/users/strongloop/orgs","repos_url":"https://api.github.com/users/strongloop/repos","events_url":"https://api.github.com/users/strongloop/events{/privacy}","received_events_url":"https://api.github.com/users/strongloop/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/strongloop/strong-pm","description":"deployer for node applications","fork":false,"url":"https://api.github.com/repos/strongloop/strong-pm","forks_url":"https://api.github.com/repos/strongloop/strong-pm/forks","keys_url":"https://api.github.com/repos/strongloop/strong-pm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/strongloop/strong-pm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/strongloop/strong-pm/teams","hooks_url":"https://api.github.com/repos/strongloop/strong-pm/hooks","issue_events_url":"https://api.github.com/repos/strongloop/strong-pm/issues/events{/number}","events_url":"https://api.github.com/repos/strongloop/strong-pm/events","assignees_url":"https://api.github.com/repos/strongloop/strong-pm/assignees{/user}","branches_url":"https://api.github.com/repos/strongloop/strong-pm/branches{/branch}","tags_url":"https://api.github.com/repos/strongloop/strong-pm/tags","blobs_url":"https://api.github.com/repos/strongloop/strong-pm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/strongloop/strong-pm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/strongloop/strong-pm/git/refs{/sha}","trees_url":"https://api.github.com/repos/strongloop/strong-pm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/strongloop/strong-pm/statuses/{sha}","languages_url":"https://api.github.com/repos/strongloop/strong-pm/languages","stargazers_url":"https://api.github.com/repos/strongloop/strong-pm/stargazers","contributors_url":"https://api.github.com/repos/strongloop/strong-pm/contributors","subscribers_url":"https://api.github.com/repos/strongloop/strong-pm/subscribers","subscription_url":"https://api.github.com/repos/strongloop/strong-pm/subscription","commits_url":"https://api.github.com/repos/strongloop/strong-pm/commits{/sha}","git_commits_url":"https://api.github.com/repos/strongloop/strong-pm/git/commits{/sha}","comments_url":"https://api.github.com/repos/strongloop/strong-pm/comments{/number}","issue_comment_url":"https://api.github.com/repos/strongloop/strong-pm/issues/comments/{number}","contents_url":"https://api.github.com/repos/strongloop/strong-pm/contents/{+path}","compare_url":"https://api.github.com/repos/strongloop/strong-pm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/strongloop/strong-pm/merges","archive_url":"https://api.github.com/repos/strongloop/strong-pm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/strongloop/strong-pm/downloads","issues_url":"https://api.github.com/repos/strongloop/strong-pm/issues{/number}","pulls_url":"https://api.github.com/repos/strongloop/strong-pm/pulls{/number}","milestones_url":"https://api.github.com/repos/strongloop/strong-pm/milestones{/number}","notifications_url":"https://api.github.com/repos/strongloop/strong-pm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/strongloop/strong-pm/labels{/name}","releases_url":"https://api.github.com/repos/strongloop/strong-pm/releases{/id}","created_at":"2014-06-03T21:48:54Z","updated_at":"2014-11-19T01:09:28Z","pushed_at":"2014-11-24T18:13:04Z","git_url":"git://github.com/strongloop/strong-pm.git","ssh_url":"git@github.com:strongloop/strong-pm.git","clone_url":"https://github.com/strongloop/strong-pm.git","svn_url":"https://github.com/strongloop/strong-pm","homepage":null,"size":3140,"stargazers_count":9,"watchers_count":9,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":14,"forks":2,"open_issues":14,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/strongloop/strong-pm/pulls/74"},"html":{"href":"https://github.com/strongloop/strong-pm/pull/74"},"issue":{"href":"https://api.github.com/repos/strongloop/strong-pm/issues/74"},"comments":{"href":"https://api.github.com/repos/strongloop/strong-pm/issues/74/comments"},"review_comments":{"href":"https://api.github.com/repos/strongloop/strong-pm/pulls/74/comments"},"review_comment":{"href":"https://api.github.com/repos/strongloop/strong-pm/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/strongloop/strong-pm/pulls/74/commits"},"statuses":{"href":"https://api.github.com/repos/strongloop/strong-pm/statuses/50be273e3f6b4fb592b55534d1e63dbfc9d572d6"}}}}