GitHub PullRequestReviewCommentEvent at 2014-11-21 05:53:14
Repository: kibana
Actor: spenceralger
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/elasticsearch/kibana/pulls/comments/20699785","id":20699785,"diff_hunk":"@@ -264,6 +264,8 @@ define(function (require) {\n               'match_all': {}\n             };\n           }\n+          flatState.body.fields = ['*', '_source'];","path":"src/kibana/components/courier/data_source/_abstract.js","position":4,"original_position":4,"commit_id":"b1c562efca3a04c97fcc8ada515fc20cd4f4ed2e","original_commit_id":"b1c562efca3a04c97fcc8ada515fc20cd4f4ed2e","user":{"login":"spenceralger","id":1329312,"avatar_url":"https://avatars.githubusercontent.com/u/1329312?v=3","gravatar_id":"","url":"https://api.github.com/users/spenceralger","html_url":"https://github.com/spenceralger","followers_url":"https://api.github.com/users/spenceralger/followers","following_url":"https://api.github.com/users/spenceralger/following{/other_user}","gists_url":"https://api.github.com/users/spenceralger/gists{/gist_id}","starred_url":"https://api.github.com/users/spenceralger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spenceralger/subscriptions","organizations_url":"https://api.github.com/users/spenceralger/orgs","repos_url":"https://api.github.com/users/spenceralger/repos","events_url":"https://api.github.com/users/spenceralger/events{/privacy}","received_events_url":"https://api.github.com/users/spenceralger/received_events","type":"User","site_admin":false},"body":"I'm curious why this doesn't return a lot more data than it is. By including _source here does it prevent fields that are already in source from being sent as fields?","created_at":"2014-11-21T05:53:14Z","updated_at":"2014-11-21T05:53:14Z","html_url":"https://github.com/elasticsearch/kibana/pull/1998#discussion_r20699785","pull_request_url":"https://api.github.com/repos/elasticsearch/kibana/pulls/1998","_links":{"self":{"href":"https://api.github.com/repos/elasticsearch/kibana/pulls/comments/20699785"},"html":{"href":"https://github.com/elasticsearch/kibana/pull/1998#discussion_r20699785"},"pull_request":{"href":"https://api.github.com/repos/elasticsearch/kibana/pulls/1998"}}},"pull_request":{"url":"https://api.github.com/repos/elasticsearch/kibana/pulls/1998","id":24806872,"html_url":"https://github.com/elasticsearch/kibana/pull/1998","diff_url":"https://github.com/elasticsearch/kibana/pull/1998.diff","patch_url":"https://github.com/elasticsearch/kibana/pull/1998.patch","issue_url":"https://api.github.com/repos/elasticsearch/kibana/issues/1998","number":1998,"state":"open","locked":false,"title":"Merge stored/index fields into _formatted","user":{"login":"rashidkpc","id":1250387,"avatar_url":"https://avatars.githubusercontent.com/u/1250387?v=3","gravatar_id":"","url":"https://api.github.com/users/rashidkpc","html_url":"https://github.com/rashidkpc","followers_url":"https://api.github.com/users/rashidkpc/followers","following_url":"https://api.github.com/users/rashidkpc/following{/other_user}","gists_url":"https://api.github.com/users/rashidkpc/gists{/gist_id}","starred_url":"https://api.github.com/users/rashidkpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rashidkpc/subscriptions","organizations_url":"https://api.github.com/users/rashidkpc/orgs","repos_url":"https://api.github.com/users/rashidkpc/repos","events_url":"https://api.github.com/users/rashidkpc/events{/privacy}","received_events_url":"https://api.github.com/users/rashidkpc/received_events","type":"User","site_admin":false},"body":"The goal of this was to close #1766 in which `_timestamp` was not working. The reason `_timestamp` doesn't work is because it is never returned, unless it is `store: true` and you explicitly ask for it. The pull does the following to resolve the issue:\r\n\r\n- Always requests all stored fields\r\n- Merges stored field values into _formatted for display in discover. This is also useful for scripted fields. (#1537)\r\n- Breaks out the field mapper for testing\r\n- Overrides the mapping of `_timestamp` to be `date`, since it always is and must be. This makes sure it is formatted as a date and is available for date_histogram aggs.\r\n\r\n![screen shot 2014-11-20 at 4 18 38 pm](https://cloud.githubusercontent.com/assets/1250387/5135029/1c8a7e44-70d1-11e4-936c-3075831fda31.png)\r\n","created_at":"2014-11-20T23:20:20Z","updated_at":"2014-11-21T05:53:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b222aee0ab47ccf4af7af803034bd0c54ecbc546","assignee":{"login":"spenceralger","id":1329312,"avatar_url":"https://avatars.githubusercontent.com/u/1329312?v=3","gravatar_id":"","url":"https://api.github.com/users/spenceralger","html_url":"https://github.com/spenceralger","followers_url":"https://api.github.com/users/spenceralger/followers","following_url":"https://api.github.com/users/spenceralger/following{/other_user}","gists_url":"https://api.github.com/users/spenceralger/gists{/gist_id}","starred_url":"https://api.github.com/users/spenceralger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spenceralger/subscriptions","organizations_url":"https://api.github.com/users/spenceralger/orgs","repos_url":"https://api.github.com/users/spenceralger/repos","events_url":"https://api.github.com/users/spenceralger/events{/privacy}","received_events_url":"https://api.github.com/users/spenceralger/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/elasticsearch/kibana/milestones/2","labels_url":"https://api.github.com/repos/elasticsearch/kibana/milestones/2/labels","id":815681,"number":2,"title":"4.0.0-BETA3","description":"","creator":{"login":"spenceralger","id":1329312,"avatar_url":"https://avatars.githubusercontent.com/u/1329312?v=3","gravatar_id":"","url":"https://api.github.com/users/spenceralger","html_url":"https://github.com/spenceralger","followers_url":"https://api.github.com/users/spenceralger/followers","following_url":"https://api.github.com/users/spenceralger/following{/other_user}","gists_url":"https://api.github.com/users/spenceralger/gists{/gist_id}","starred_url":"https://api.github.com/users/spenceralger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spenceralger/subscriptions","organizations_url":"https://api.github.com/users/spenceralger/orgs","repos_url":"https://api.github.com/users/spenceralger/repos","events_url":"https://api.github.com/users/spenceralger/events{/privacy}","received_events_url":"https://api.github.com/users/spenceralger/received_events","type":"User","site_admin":false},"open_issues":28,"closed_issues":19,"state":"open","created_at":"2014-10-06T19:50:52Z","updated_at":"2014-11-20T23:27:31Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/elasticsearch/kibana/pulls/1998/commits","review_comments_url":"https://api.github.com/repos/elasticsearch/kibana/pulls/1998/comments","review_comment_url":"https://api.github.com/repos/elasticsearch/kibana/pulls/comments/{number}","comments_url":"https://api.github.com/repos/elasticsearch/kibana/issues/1998/comments","statuses_url":"https://api.github.com/repos/elasticsearch/kibana/statuses/b1c562efca3a04c97fcc8ada515fc20cd4f4ed2e","head":{"label":"rashidkpc:feature/field-merge","ref":"feature/field-merge","sha":"b1c562efca3a04c97fcc8ada515fc20cd4f4ed2e","user":{"login":"rashidkpc","id":1250387,"avatar_url":"https://avatars.githubusercontent.com/u/1250387?v=3","gravatar_id":"","url":"https://api.github.com/users/rashidkpc","html_url":"https://github.com/rashidkpc","followers_url":"https://api.github.com/users/rashidkpc/followers","following_url":"https://api.github.com/users/rashidkpc/following{/other_user}","gists_url":"https://api.github.com/users/rashidkpc/gists{/gist_id}","starred_url":"https://api.github.com/users/rashidkpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rashidkpc/subscriptions","organizations_url":"https://api.github.com/users/rashidkpc/orgs","repos_url":"https://api.github.com/users/rashidkpc/repos","events_url":"https://api.github.com/users/rashidkpc/events{/privacy}","received_events_url":"https://api.github.com/users/rashidkpc/received_events","type":"User","site_admin":false},"repo":{"id":9221861,"name":"kibana","full_name":"rashidkpc/kibana","owner":{"login":"rashidkpc","id":1250387,"avatar_url":"https://avatars.githubusercontent.com/u/1250387?v=3","gravatar_id":"","url":"https://api.github.com/users/rashidkpc","html_url":"https://github.com/rashidkpc","followers_url":"https://api.github.com/users/rashidkpc/followers","following_url":"https://api.github.com/users/rashidkpc/following{/other_user}","gists_url":"https://api.github.com/users/rashidkpc/gists{/gist_id}","starred_url":"https://api.github.com/users/rashidkpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rashidkpc/subscriptions","organizations_url":"https://api.github.com/users/rashidkpc/orgs","repos_url":"https://api.github.com/users/rashidkpc/repos","events_url":"https://api.github.com/users/rashidkpc/events{/privacy}","received_events_url":"https://api.github.com/users/rashidkpc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rashidkpc/kibana","description":"Kibana Dashboard Preview","fork":true,"url":"https://api.github.com/repos/rashidkpc/kibana","forks_url":"https://api.github.com/repos/rashidkpc/kibana/forks","keys_url":"https://api.github.com/repos/rashidkpc/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rashidkpc/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rashidkpc/kibana/teams","hooks_url":"https://api.github.com/repos/rashidkpc/kibana/hooks","issue_events_url":"https://api.github.com/repos/rashidkpc/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/rashidkpc/kibana/events","assignees_url":"https://api.github.com/repos/rashidkpc/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/rashidkpc/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/rashidkpc/kibana/tags","blobs_url":"https://api.github.com/repos/rashidkpc/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rashidkpc/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rashidkpc/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/rashidkpc/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rashidkpc/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/rashidkpc/kibana/languages","stargazers_url":"https://api.github.com/repos/rashidkpc/kibana/stargazers","contributors_url":"https://api.github.com/repos/rashidkpc/kibana/contributors","subscribers_url":"https://api.github.com/repos/rashidkpc/kibana/subscribers","subscription_url":"https://api.github.com/repos/rashidkpc/kibana/subscription","commits_url":"https://api.github.com/repos/rashidkpc/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/rashidkpc/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/rashidkpc/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/rashidkpc/kibana/issues/comments/{number}","contents_url":"https://api.github.com/repos/rashidkpc/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/rashidkpc/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rashidkpc/kibana/merges","archive_url":"https://api.github.com/repos/rashidkpc/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rashidkpc/kibana/downloads","issues_url":"https://api.github.com/repos/rashidkpc/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/rashidkpc/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/rashidkpc/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/rashidkpc/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rashidkpc/kibana/labels{/name}","releases_url":"https://api.github.com/repos/rashidkpc/kibana/releases{/id}","created_at":"2013-04-04T15:56:09Z","updated_at":"2014-11-20T15:48:09Z","pushed_at":"2014-11-20T23:13:44Z","git_url":"git://github.com/rashidkpc/kibana.git","ssh_url":"git@github.com:rashidkpc/kibana.git","clone_url":"https://github.com/rashidkpc/kibana.git","svn_url":"https://github.com/rashidkpc/kibana","homepage":null,"size":43048,"stargazers_count":17,"watchers_count":17,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":0,"forks":5,"open_issues":0,"watchers":17,"default_branch":"master"}},"base":{"label":"elasticsearch:master","ref":"master","sha":"634b2405ce5f17c0b59f8726896b75aa2df503fb","user":{"login":"elasticsearch","id":141304,"avatar_url":"https://avatars.githubusercontent.com/u/141304?v=3","gravatar_id":"","url":"https://api.github.com/users/elasticsearch","html_url":"https://github.com/elasticsearch","followers_url":"https://api.github.com/users/elasticsearch/followers","following_url":"https://api.github.com/users/elasticsearch/following{/other_user}","gists_url":"https://api.github.com/users/elasticsearch/gists{/gist_id}","starred_url":"https://api.github.com/users/elasticsearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elasticsearch/subscriptions","organizations_url":"https://api.github.com/users/elasticsearch/orgs","repos_url":"https://api.github.com/users/elasticsearch/repos","events_url":"https://api.github.com/users/elasticsearch/events{/privacy}","received_events_url":"https://api.github.com/users/elasticsearch/received_events","type":"Organization","site_admin":false},"repo":{"id":7833168,"name":"kibana","full_name":"elasticsearch/kibana","owner":{"login":"elasticsearch","id":141304,"avatar_url":"https://avatars.githubusercontent.com/u/141304?v=3","gravatar_id":"","url":"https://api.github.com/users/elasticsearch","html_url":"https://github.com/elasticsearch","followers_url":"https://api.github.com/users/elasticsearch/followers","following_url":"https://api.github.com/users/elasticsearch/following{/other_user}","gists_url":"https://api.github.com/users/elasticsearch/gists{/gist_id}","starred_url":"https://api.github.com/users/elasticsearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elasticsearch/subscriptions","organizations_url":"https://api.github.com/users/elasticsearch/orgs","repos_url":"https://api.github.com/users/elasticsearch/repos","events_url":"https://api.github.com/users/elasticsearch/events{/privacy}","received_events_url":"https://api.github.com/users/elasticsearch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elasticsearch/kibana","description":"Kibana","fork":false,"url":"https://api.github.com/repos/elasticsearch/kibana","forks_url":"https://api.github.com/repos/elasticsearch/kibana/forks","keys_url":"https://api.github.com/repos/elasticsearch/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elasticsearch/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elasticsearch/kibana/teams","hooks_url":"https://api.github.com/repos/elasticsearch/kibana/hooks","issue_events_url":"https://api.github.com/repos/elasticsearch/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/elasticsearch/kibana/events","assignees_url":"https://api.github.com/repos/elasticsearch/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/elasticsearch/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/elasticsearch/kibana/tags","blobs_url":"https://api.github.com/repos/elasticsearch/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elasticsearch/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elasticsearch/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/elasticsearch/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elasticsearch/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/elasticsearch/kibana/languages","stargazers_url":"https://api.github.com/repos/elasticsearch/kibana/stargazers","contributors_url":"https://api.github.com/repos/elasticsearch/kibana/contributors","subscribers_url":"https://api.github.com/repos/elasticsearch/kibana/subscribers","subscription_url":"https://api.github.com/repos/elasticsearch/kibana/subscription","commits_url":"https://api.github.com/repos/elasticsearch/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/elasticsearch/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/elasticsearch/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/elasticsearch/kibana/issues/comments/{number}","contents_url":"https://api.github.com/repos/elasticsearch/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/elasticsearch/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elasticsearch/kibana/merges","archive_url":"https://api.github.com/repos/elasticsearch/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elasticsearch/kibana/downloads","issues_url":"https://api.github.com/repos/elasticsearch/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/elasticsearch/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/elasticsearch/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/elasticsearch/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elasticsearch/kibana/labels{/name}","releases_url":"https://api.github.com/repos/elasticsearch/kibana/releases{/id}","created_at":"2013-01-26T04:00:59Z","updated_at":"2014-11-21T04:33:55Z","pushed_at":"2014-11-20T23:39:42Z","git_url":"git://github.com/elasticsearch/kibana.git","ssh_url":"git@github.com:elasticsearch/kibana.git","clone_url":"https://github.com/elasticsearch/kibana.git","svn_url":"https://github.com/elasticsearch/kibana","homepage":"http://www.elasticsearch.org/overview/kibana/","size":55371,"stargazers_count":2573,"watchers_count":2573,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":997,"mirror_url":null,"open_issues_count":201,"forks":997,"open_issues":201,"watchers":2573,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elasticsearch/kibana/pulls/1998"},"html":{"href":"https://github.com/elasticsearch/kibana/pull/1998"},"issue":{"href":"https://api.github.com/repos/elasticsearch/kibana/issues/1998"},"comments":{"href":"https://api.github.com/repos/elasticsearch/kibana/issues/1998/comments"},"review_comments":{"href":"https://api.github.com/repos/elasticsearch/kibana/pulls/1998/comments"},"review_comment":{"href":"https://api.github.com/repos/elasticsearch/kibana/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/elasticsearch/kibana/pulls/1998/commits"},"statuses":{"href":"https://api.github.com/repos/elasticsearch/kibana/statuses/b1c562efca3a04c97fcc8ada515fc20cd4f4ed2e"}}}}