GitHub PullRequestReviewCommentEvent at 2014-06-02 16:21:23
Repository: libneubot
Actor: alessandro40
Payload: {"comment":{"url":"https://api.github.com/repos/bassosimone/libneubot/pulls/comments/13293015","id":13293015,"diff_hunk":"@@ -1,3 +1,28 @@\n+LibNeubot 3.1.0 [2014-06-01]\n+\t* Add the NeubotConnection module, that provides an abstraction,\n+\t  representing a stream-like network connection. This module provides\n+\t  various static constructors, which allow the user to establish a\n+\t  connection providing different parameters: connect(), \n+\t  connect_hostname() and attach(). This module provides also different\n+\t  methods to read and write data over the connection.\n+\t* Related to the previous change: add the StringVector module, useful\n+\t  to implement connect_hostname() static constructor.\n+\t* Related to the previous change: the protocol family of the connection\n+\t  can be either IPv4 or IPv6 and, if unspecified, the priority can be\n+\t  given to both of them.\n+\t* Rewrite the C++-to-C glue code: the wrapper struct inherits from a\n+\t  another struct (with some private methods and attributes), instead of \n+\t  a class.\n+\t* Improvements in gen_python, which now supports static constructors\n+\t  (which have to be explicitly declared in libneubot.json).\n+\t  Additionally, if a class has a getter method of an object passed as a\n+\t  parameter to the constructor, the getter returns it, instead of\n+\t  calling the wrapper function.","path":"ChangeLog","position":20,"original_position":20,"commit_id":"554192e08f2aff50bdab6456aa5fd549eb4953ec","original_commit_id":"554192e08f2aff50bdab6456aa5fd549eb4953ec","user":{"login":"alessandro40","id":6865949,"avatar_url":"https://avatars.githubusercontent.com/u/6865949?","gravatar_id":"b7c6ea9583e57beacf53dac95d9db888","url":"https://api.github.com/users/alessandro40","html_url":"https://github.com/alessandro40","followers_url":"https://api.github.com/users/alessandro40/followers","following_url":"https://api.github.com/users/alessandro40/following{/other_user}","gists_url":"https://api.github.com/users/alessandro40/gists{/gist_id}","starred_url":"https://api.github.com/users/alessandro40/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alessandro40/subscriptions","organizations_url":"https://api.github.com/users/alessandro40/orgs","repos_url":"https://api.github.com/users/alessandro40/repos","events_url":"https://api.github.com/users/alessandro40/events{/privacy}","received_events_url":"https://api.github.com/users/alessandro40/received_events","type":"User","site_admin":false},"body":"Yes, it is. I see that the period is a bit long and intricate. I could try to make it clearer in this way: \"if a wrapper class has a get_foo() method and foo is passed as a parameter to the class constructor, than get_foo() returns foo, rather than calling the inner function\". Is it better?","created_at":"2014-06-02T16:21:23Z","updated_at":"2014-06-02T16:21:23Z","html_url":"https://github.com/bassosimone/libneubot/pull/11#discussion_r13293015","pull_request_url":"https://api.github.com/repos/bassosimone/libneubot/pulls/11","_links":{"self":{"href":"https://api.github.com/repos/bassosimone/libneubot/pulls/comments/13293015"},"html":{"href":"https://github.com/bassosimone/libneubot/pull/11#discussion_r13293015"},"pull_request":{"href":"https://api.github.com/repos/bassosimone/libneubot/pulls/11"}}}}