GitHub PullRequestEvent at 2014-05-17 21:49:31
Repository: jReject
Actor: BluSyn
Payload: {"action":"closed","number":46,"pull_request":{"url":"https://api.github.com/repos/TurnWheel/jReject/pulls/46","id":15563888,"html_url":"https://github.com/TurnWheel/jReject/pull/46","diff_url":"https://github.com/TurnWheel/jReject/pull/46.diff","patch_url":"https://github.com/TurnWheel/jReject/pull/46.patch","issue_url":"https://api.github.com/repos/TurnWheel/jReject/issues/46","number":46,"state":"closed","title":"Allow blacklisting all versions older than a given number + Remove Chrome Frame","user":{"login":"chrisbarmonde","id":378336,"avatar_url":"https://avatars.githubusercontent.com/u/378336?","gravatar_id":"f5d88c3a927b955a820daffaf424a657","url":"https://api.github.com/users/chrisbarmonde","html_url":"https://github.com/chrisbarmonde","followers_url":"https://api.github.com/users/chrisbarmonde/followers","following_url":"https://api.github.com/users/chrisbarmonde/following{/other_user}","gists_url":"https://api.github.com/users/chrisbarmonde/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisbarmonde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisbarmonde/subscriptions","organizations_url":"https://api.github.com/users/chrisbarmonde/orgs","repos_url":"https://api.github.com/users/chrisbarmonde/repos","events_url":"https://api.github.com/users/chrisbarmonde/events{/privacy}","received_events_url":"https://api.github.com/users/chrisbarmonde/received_events","type":"User","site_admin":false},"body":"I found it a little tedious to have to specify each individual revision, so I added in an option to specify a major revision number instead of `true` to blacklist anything older than the given number. So instead of\r\n```javascript\r\n{msie5: true, msie6: true, msie7: true, msie8: true}\r\n```\r\nYou can just do\r\n```javascript\r\n{msie: 8}\r\n```\r\n\r\nIt's still fully backwards compatible, however!\r\n\r\nI also removed any mention of specific revisions for the modal since now that browsers update more often, it's probably going to be annoying to keep it up-to-date.\r\n\r\nI also removed the option for Google Chrome Frame as they've retired it: http://blog.chromium.org/2013/06/retiring-chrome-frame.html","created_at":"2014-05-06T20:43:13Z","updated_at":"2014-05-17T21:49:30Z","closed_at":"2014-05-17T21:49:30Z","merged_at":"2014-05-17T21:49:30Z","merge_commit_sha":"6de70f9cd799e94ca88ee275f229a8843f5dc96e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/TurnWheel/jReject/pulls/46/commits","review_comments_url":"https://api.github.com/repos/TurnWheel/jReject/pulls/46/comments","review_comment_url":"https://api.github.com/repos/TurnWheel/jReject/pulls/comments/{number}","comments_url":"https://api.github.com/repos/TurnWheel/jReject/issues/46/comments","statuses_url":"https://api.github.com/repos/TurnWheel/jReject/statuses/af8b76e25daa7b85f307448bd9dd61e29a446339","head":{"label":"chrisbarmonde:previous-versions","ref":"previous-versions","sha":"af8b76e25daa7b85f307448bd9dd61e29a446339","user":{"login":"chrisbarmonde","id":378336,"avatar_url":"https://avatars.githubusercontent.com/u/378336?","gravatar_id":"f5d88c3a927b955a820daffaf424a657","url":"https://api.github.com/users/chrisbarmonde","html_url":"https://github.com/chrisbarmonde","followers_url":"https://api.github.com/users/chrisbarmonde/followers","following_url":"https://api.github.com/users/chrisbarmonde/following{/other_user}","gists_url":"https://api.github.com/users/chrisbarmonde/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisbarmonde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisbarmonde/subscriptions","organizations_url":"https://api.github.com/users/chrisbarmonde/orgs","repos_url":"https://api.github.com/users/chrisbarmonde/repos","events_url":"https://api.github.com/users/chrisbarmonde/events{/privacy}","received_events_url":"https://api.github.com/users/chrisbarmonde/received_events","type":"User","site_admin":false},"repo":{"id":19508482,"name":"jReject","full_name":"chrisbarmonde/jReject","owner":{"login":"chrisbarmonde","id":378336,"avatar_url":"https://avatars.githubusercontent.com/u/378336?","gravatar_id":"f5d88c3a927b955a820daffaf424a657","url":"https://api.github.com/users/chrisbarmonde","html_url":"https://github.com/chrisbarmonde","followers_url":"https://api.github.com/users/chrisbarmonde/followers","following_url":"https://api.github.com/users/chrisbarmonde/following{/other_user}","gists_url":"https://api.github.com/users/chrisbarmonde/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisbarmonde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisbarmonde/subscriptions","organizations_url":"https://api.github.com/users/chrisbarmonde/orgs","repos_url":"https://api.github.com/users/chrisbarmonde/repos","events_url":"https://api.github.com/users/chrisbarmonde/events{/privacy}","received_events_url":"https://api.github.com/users/chrisbarmonde/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chrisbarmonde/jReject","description":"jQuery Browser Rejection Plugin","fork":true,"url":"https://api.github.com/repos/chrisbarmonde/jReject","forks_url":"https://api.github.com/repos/chrisbarmonde/jReject/forks","keys_url":"https://api.github.com/repos/chrisbarmonde/jReject/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chrisbarmonde/jReject/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chrisbarmonde/jReject/teams","hooks_url":"https://api.github.com/repos/chrisbarmonde/jReject/hooks","issue_events_url":"https://api.github.com/repos/chrisbarmonde/jReject/issues/events{/number}","events_url":"https://api.github.com/repos/chrisbarmonde/jReject/events","assignees_url":"https://api.github.com/repos/chrisbarmonde/jReject/assignees{/user}","branches_url":"https://api.github.com/repos/chrisbarmonde/jReject/branches{/branch}","tags_url":"https://api.github.com/repos/chrisbarmonde/jReject/tags","blobs_url":"https://api.github.com/repos/chrisbarmonde/jReject/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chrisbarmonde/jReject/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chrisbarmonde/jReject/git/refs{/sha}","trees_url":"https://api.github.com/repos/chrisbarmonde/jReject/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chrisbarmonde/jReject/statuses/{sha}","languages_url":"https://api.github.com/repos/chrisbarmonde/jReject/languages","stargazers_url":"https://api.github.com/repos/chrisbarmonde/jReject/stargazers","contributors_url":"https://api.github.com/repos/chrisbarmonde/jReject/contributors","subscribers_url":"https://api.github.com/repos/chrisbarmonde/jReject/subscribers","subscription_url":"https://api.github.com/repos/chrisbarmonde/jReject/subscription","commits_url":"https://api.github.com/repos/chrisbarmonde/jReject/commits{/sha}","git_commits_url":"https://api.github.com/repos/chrisbarmonde/jReject/git/commits{/sha}","comments_url":"https://api.github.com/repos/chrisbarmonde/jReject/comments{/number}","issue_comment_url":"https://api.github.com/repos/chrisbarmonde/jReject/issues/comments/{number}","contents_url":"https://api.github.com/repos/chrisbarmonde/jReject/contents/{+path}","compare_url":"https://api.github.com/repos/chrisbarmonde/jReject/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chrisbarmonde/jReject/merges","archive_url":"https://api.github.com/repos/chrisbarmonde/jReject/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chrisbarmonde/jReject/downloads","issues_url":"https://api.github.com/repos/chrisbarmonde/jReject/issues{/number}","pulls_url":"https://api.github.com/repos/chrisbarmonde/jReject/pulls{/number}","milestones_url":"https://api.github.com/repos/chrisbarmonde/jReject/milestones{/number}","notifications_url":"https://api.github.com/repos/chrisbarmonde/jReject/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chrisbarmonde/jReject/labels{/name}","releases_url":"https://api.github.com/repos/chrisbarmonde/jReject/releases{/id}","created_at":"2014-05-06T19:52:47Z","updated_at":"2014-05-17T21:49:30Z","pushed_at":"2014-05-06T20:38:08Z","git_url":"git://github.com/chrisbarmonde/jReject.git","ssh_url":"git@github.com:chrisbarmonde/jReject.git","clone_url":"https://github.com/chrisbarmonde/jReject.git","svn_url":"https://github.com/chrisbarmonde/jReject","homepage":"http://jreject.turnwheel.com/","size":305,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"TurnWheel:master","ref":"master","sha":"679a5ec8346aa20f393dc646ab666022596088ad","user":{"login":"TurnWheel","id":438773,"avatar_url":"https://avatars.githubusercontent.com/u/438773?","gravatar_id":"fc5d568d4d870addfc85707b6297e3bf","url":"https://api.github.com/users/TurnWheel","html_url":"https://github.com/TurnWheel","followers_url":"https://api.github.com/users/TurnWheel/followers","following_url":"https://api.github.com/users/TurnWheel/following{/other_user}","gists_url":"https://api.github.com/users/TurnWheel/gists{/gist_id}","starred_url":"https://api.github.com/users/TurnWheel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TurnWheel/subscriptions","organizations_url":"https://api.github.com/users/TurnWheel/orgs","repos_url":"https://api.github.com/users/TurnWheel/repos","events_url":"https://api.github.com/users/TurnWheel/events{/privacy}","received_events_url":"https://api.github.com/users/TurnWheel/received_events","type":"Organization","site_admin":false},"repo":{"id":1201936,"name":"jReject","full_name":"TurnWheel/jReject","owner":{"login":"TurnWheel","id":438773,"avatar_url":"https://avatars.githubusercontent.com/u/438773?","gravatar_id":"fc5d568d4d870addfc85707b6297e3bf","url":"https://api.github.com/users/TurnWheel","html_url":"https://github.com/TurnWheel","followers_url":"https://api.github.com/users/TurnWheel/followers","following_url":"https://api.github.com/users/TurnWheel/following{/other_user}","gists_url":"https://api.github.com/users/TurnWheel/gists{/gist_id}","starred_url":"https://api.github.com/users/TurnWheel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TurnWheel/subscriptions","organizations_url":"https://api.github.com/users/TurnWheel/orgs","repos_url":"https://api.github.com/users/TurnWheel/repos","events_url":"https://api.github.com/users/TurnWheel/events{/privacy}","received_events_url":"https://api.github.com/users/TurnWheel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TurnWheel/jReject","description":"jQuery Browser Rejection Plugin","fork":false,"url":"https://api.github.com/repos/TurnWheel/jReject","forks_url":"https://api.github.com/repos/TurnWheel/jReject/forks","keys_url":"https://api.github.com/repos/TurnWheel/jReject/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TurnWheel/jReject/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TurnWheel/jReject/teams","hooks_url":"https://api.github.com/repos/TurnWheel/jReject/hooks","issue_events_url":"https://api.github.com/repos/TurnWheel/jReject/issues/events{/number}","events_url":"https://api.github.com/repos/TurnWheel/jReject/events","assignees_url":"https://api.github.com/repos/TurnWheel/jReject/assignees{/user}","branches_url":"https://api.github.com/repos/TurnWheel/jReject/branches{/branch}","tags_url":"https://api.github.com/repos/TurnWheel/jReject/tags","blobs_url":"https://api.github.com/repos/TurnWheel/jReject/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TurnWheel/jReject/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TurnWheel/jReject/git/refs{/sha}","trees_url":"https://api.github.com/repos/TurnWheel/jReject/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TurnWheel/jReject/statuses/{sha}","languages_url":"https://api.github.com/repos/TurnWheel/jReject/languages","stargazers_url":"https://api.github.com/repos/TurnWheel/jReject/stargazers","contributors_url":"https://api.github.com/repos/TurnWheel/jReject/contributors","subscribers_url":"https://api.github.com/repos/TurnWheel/jReject/subscribers","subscription_url":"https://api.github.com/repos/TurnWheel/jReject/subscription","commits_url":"https://api.github.com/repos/TurnWheel/jReject/commits{/sha}","git_commits_url":"https://api.github.com/repos/TurnWheel/jReject/git/commits{/sha}","comments_url":"https://api.github.com/repos/TurnWheel/jReject/comments{/number}","issue_comment_url":"https://api.github.com/repos/TurnWheel/jReject/issues/comments/{number}","contents_url":"https://api.github.com/repos/TurnWheel/jReject/contents/{+path}","compare_url":"https://api.github.com/repos/TurnWheel/jReject/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TurnWheel/jReject/merges","archive_url":"https://api.github.com/repos/TurnWheel/jReject/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TurnWheel/jReject/downloads","issues_url":"https://api.github.com/repos/TurnWheel/jReject/issues{/number}","pulls_url":"https://api.github.com/repos/TurnWheel/jReject/pulls{/number}","milestones_url":"https://api.github.com/repos/TurnWheel/jReject/milestones{/number}","notifications_url":"https://api.github.com/repos/TurnWheel/jReject/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TurnWheel/jReject/labels{/name}","releases_url":"https://api.github.com/repos/TurnWheel/jReject/releases{/id}","created_at":"2010-12-28T01:39:26Z","updated_at":"2014-05-17T21:49:30Z","pushed_at":"2014-05-17T21:49:30Z","git_url":"git://github.com/TurnWheel/jReject.git","ssh_url":"git@github.com:TurnWheel/jReject.git","clone_url":"https://github.com/TurnWheel/jReject.git","svn_url":"https://github.com/TurnWheel/jReject","homepage":"http://jreject.turnwheel.com/","size":588,"stargazers_count":181,"watchers_count":181,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":56,"mirror_url":null,"open_issues_count":12,"forks":56,"open_issues":12,"watchers":181,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TurnWheel/jReject/pulls/46"},"html":{"href":"https://github.com/TurnWheel/jReject/pull/46"},"issue":{"href":"https://api.github.com/repos/TurnWheel/jReject/issues/46"},"comments":{"href":"https://api.github.com/repos/TurnWheel/jReject/issues/46/comments"},"review_comments":{"href":"https://api.github.com/repos/TurnWheel/jReject/pulls/46/comments"},"review_comment":{"href":"https://api.github.com/repos/TurnWheel/jReject/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/TurnWheel/jReject/pulls/46/commits"},"statuses":{"href":"https://api.github.com/repos/TurnWheel/jReject/statuses/af8b76e25daa7b85f307448bd9dd61e29a446339"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"BluSyn","id":535381,"avatar_url":"https://avatars.githubusercontent.com/u/535381?","gravatar_id":"83eb66ee8f537bb5324d79f8d9878b20","url":"https://api.github.com/users/BluSyn","html_url":"https://github.com/BluSyn","followers_url":"https://api.github.com/users/BluSyn/followers","following_url":"https://api.github.com/users/BluSyn/following{/other_user}","gists_url":"https://api.github.com/users/BluSyn/gists{/gist_id}","starred_url":"https://api.github.com/users/BluSyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BluSyn/subscriptions","organizations_url":"https://api.github.com/users/BluSyn/orgs","repos_url":"https://api.github.com/users/BluSyn/repos","events_url":"https://api.github.com/users/BluSyn/events{/privacy}","received_events_url":"https://api.github.com/users/BluSyn/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":16,"deletions":20,"changed_files":1}}