GitHub PullRequestReviewCommentEvent at 2014-07-14 18:39:28
Repository: nix
Actor: gicmo
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/G-Node/nix/pulls/comments/14895291","id":14895291,"diff_hunk":"@@ -131,7 +133,12 @@ include_directories(${CPPUNIT_INCLUDE_DIR})\n file(GLOB Tests_SOURCES \"test/Test*.cpp\")\n \n add_executable(TestRunner test/Runner.cpp ${Tests_SOURCES})\n-set_target_properties(TestRunner PROPERTIES COMPILE_FLAGS \"-Wno-deprecated-declarations\")\n+if(NOT WIN32)\n+  set_target_properties(TestRunner PROPERTIES COMPILE_FLAGS \"-Wno-deprecated-declarations\")\n+endif()\n+if(WIN32)\n+  set_target_properties(TestRunner PROPERTIES COMPILE_FLAGS -DNIXEXPORT)","path":"CMakeLists.txt","position":22,"original_position":22,"commit_id":"02ba2cd62218a4ae481717304edcd29ff577330c","original_commit_id":"02ba2cd62218a4ae481717304edcd29ff577330c","user":{"login":"gicmo","id":2040,"avatar_url":"https://avatars.githubusercontent.com/u/2040?","gravatar_id":"1001d9aac474dac34f38c2251117ab3e","url":"https://api.github.com/users/gicmo","html_url":"https://github.com/gicmo","followers_url":"https://api.github.com/users/gicmo/followers","following_url":"https://api.github.com/users/gicmo/following{/other_user}","gists_url":"https://api.github.com/users/gicmo/gists{/gist_id}","starred_url":"https://api.github.com/users/gicmo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gicmo/subscriptions","organizations_url":"https://api.github.com/users/gicmo/orgs","repos_url":"https://api.github.com/users/gicmo/repos","events_url":"https://api.github.com/users/gicmo/events{/privacy}","received_events_url":"https://api.github.com/users/gicmo/received_events","type":"User","site_admin":false},"body":"TestRunner is a binary and not a library and should therefore *import* the symbols, not export it. What exactly did not work so that you had to add that under win8?","created_at":"2014-07-14T18:39:28Z","updated_at":"2014-07-14T18:39:28Z","html_url":"https://github.com/G-Node/nix/pull/275#discussion_r14895291","pull_request_url":"https://api.github.com/repos/G-Node/nix/pulls/275","_links":{"self":{"href":"https://api.github.com/repos/G-Node/nix/pulls/comments/14895291"},"html":{"href":"https://github.com/G-Node/nix/pull/275#discussion_r14895291"},"pull_request":{"href":"https://api.github.com/repos/G-Node/nix/pulls/275"}}},"pull_request":{"url":"https://api.github.com/repos/G-Node/nix/pulls/275","id":18018754,"html_url":"https://github.com/G-Node/nix/pull/275","diff_url":"https://github.com/G-Node/nix/pull/275.diff","patch_url":"https://github.com/G-Node/nix/pull/275.patch","issue_url":"https://api.github.com/repos/G-Node/nix/issues/275","number":275,"state":"open","title":"Modifications towards making code compile on win","user":{"login":"balint42","id":5834462,"avatar_url":"https://avatars.githubusercontent.com/u/5834462?","gravatar_id":"0329819d1cfd8d00c4bddc535abe1c94","url":"https://api.github.com/users/balint42","html_url":"https://github.com/balint42","followers_url":"https://api.github.com/users/balint42/followers","following_url":"https://api.github.com/users/balint42/following{/other_user}","gists_url":"https://api.github.com/users/balint42/gists{/gist_id}","starred_url":"https://api.github.com/users/balint42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balint42/subscriptions","organizations_url":"https://api.github.com/users/balint42/orgs","repos_url":"https://api.github.com/users/balint42/repos","events_url":"https://api.github.com/users/balint42/events{/privacy}","received_events_url":"https://api.github.com/users/balint42/received_events","type":"User","site_admin":false},"body":"Modifications to make code compile on windows\r\n\r\nIt should compile with win32, but for several reasons does not yet work on my 64bit win8: I did not yet manage to get cppunit build 64bit code and also we are triggering a VC++ compiler bug in \"Realse\" mode. In \"Debug\" mode things should build as the bug is related to optimization routines.\r\n\r\nFurther changes following","created_at":"2014-07-06T14:39:52Z","updated_at":"2014-07-14T18:39:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ffef69817332d8cbee80bad2152887b181260a19","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/G-Node/nix/pulls/275/commits","review_comments_url":"https://api.github.com/repos/G-Node/nix/pulls/275/comments","review_comment_url":"https://api.github.com/repos/G-Node/nix/pulls/comments/{number}","comments_url":"https://api.github.com/repos/G-Node/nix/issues/275/comments","statuses_url":"https://api.github.com/repos/G-Node/nix/statuses/02ba2cd62218a4ae481717304edcd29ff577330c","head":{"label":"balint42:win32","ref":"win32","sha":"02ba2cd62218a4ae481717304edcd29ff577330c","user":{"login":"balint42","id":5834462,"avatar_url":"https://avatars.githubusercontent.com/u/5834462?","gravatar_id":"0329819d1cfd8d00c4bddc535abe1c94","url":"https://api.github.com/users/balint42","html_url":"https://github.com/balint42","followers_url":"https://api.github.com/users/balint42/followers","following_url":"https://api.github.com/users/balint42/following{/other_user}","gists_url":"https://api.github.com/users/balint42/gists{/gist_id}","starred_url":"https://api.github.com/users/balint42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balint42/subscriptions","organizations_url":"https://api.github.com/users/balint42/orgs","repos_url":"https://api.github.com/users/balint42/repos","events_url":"https://api.github.com/users/balint42/events{/privacy}","received_events_url":"https://api.github.com/users/balint42/received_events","type":"User","site_admin":false},"repo":{"id":16733311,"name":"nix","full_name":"balint42/nix","owner":{"login":"balint42","id":5834462,"avatar_url":"https://avatars.githubusercontent.com/u/5834462?","gravatar_id":"0329819d1cfd8d00c4bddc535abe1c94","url":"https://api.github.com/users/balint42","html_url":"https://github.com/balint42","followers_url":"https://api.github.com/users/balint42/followers","following_url":"https://api.github.com/users/balint42/following{/other_user}","gists_url":"https://api.github.com/users/balint42/gists{/gist_id}","starred_url":"https://api.github.com/users/balint42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balint42/subscriptions","organizations_url":"https://api.github.com/users/balint42/orgs","repos_url":"https://api.github.com/users/balint42/repos","events_url":"https://api.github.com/users/balint42/events{/privacy}","received_events_url":"https://api.github.com/users/balint42/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/balint42/nix","description":"Pandora is an annotated neuroscience data storage","fork":true,"url":"https://api.github.com/repos/balint42/nix","forks_url":"https://api.github.com/repos/balint42/nix/forks","keys_url":"https://api.github.com/repos/balint42/nix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/balint42/nix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/balint42/nix/teams","hooks_url":"https://api.github.com/repos/balint42/nix/hooks","issue_events_url":"https://api.github.com/repos/balint42/nix/issues/events{/number}","events_url":"https://api.github.com/repos/balint42/nix/events","assignees_url":"https://api.github.com/repos/balint42/nix/assignees{/user}","branches_url":"https://api.github.com/repos/balint42/nix/branches{/branch}","tags_url":"https://api.github.com/repos/balint42/nix/tags","blobs_url":"https://api.github.com/repos/balint42/nix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/balint42/nix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/balint42/nix/git/refs{/sha}","trees_url":"https://api.github.com/repos/balint42/nix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/balint42/nix/statuses/{sha}","languages_url":"https://api.github.com/repos/balint42/nix/languages","stargazers_url":"https://api.github.com/repos/balint42/nix/stargazers","contributors_url":"https://api.github.com/repos/balint42/nix/contributors","subscribers_url":"https://api.github.com/repos/balint42/nix/subscribers","subscription_url":"https://api.github.com/repos/balint42/nix/subscription","commits_url":"https://api.github.com/repos/balint42/nix/commits{/sha}","git_commits_url":"https://api.github.com/repos/balint42/nix/git/commits{/sha}","comments_url":"https://api.github.com/repos/balint42/nix/comments{/number}","issue_comment_url":"https://api.github.com/repos/balint42/nix/issues/comments/{number}","contents_url":"https://api.github.com/repos/balint42/nix/contents/{+path}","compare_url":"https://api.github.com/repos/balint42/nix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/balint42/nix/merges","archive_url":"https://api.github.com/repos/balint42/nix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/balint42/nix/downloads","issues_url":"https://api.github.com/repos/balint42/nix/issues{/number}","pulls_url":"https://api.github.com/repos/balint42/nix/pulls{/number}","milestones_url":"https://api.github.com/repos/balint42/nix/milestones{/number}","notifications_url":"https://api.github.com/repos/balint42/nix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/balint42/nix/labels{/name}","releases_url":"https://api.github.com/repos/balint42/nix/releases{/id}","created_at":"2014-02-11T14:31:11Z","updated_at":"2014-06-25T13:17:25Z","pushed_at":"2014-07-14T16:34:26Z","git_url":"git://github.com/balint42/nix.git","ssh_url":"git@github.com:balint42/nix.git","clone_url":"https://github.com/balint42/nix.git","svn_url":"https://github.com/balint42/nix","homepage":null,"size":3807,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"G-Node:master","ref":"master","sha":"372d657c10bb0e1f9beeb9befe21828910355296","user":{"login":"G-Node","id":574778,"avatar_url":"https://avatars.githubusercontent.com/u/574778?","gravatar_id":"bca3b1f9c5dc79798c4d0d6be2b572f0","url":"https://api.github.com/users/G-Node","html_url":"https://github.com/G-Node","followers_url":"https://api.github.com/users/G-Node/followers","following_url":"https://api.github.com/users/G-Node/following{/other_user}","gists_url":"https://api.github.com/users/G-Node/gists{/gist_id}","starred_url":"https://api.github.com/users/G-Node/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/G-Node/subscriptions","organizations_url":"https://api.github.com/users/G-Node/orgs","repos_url":"https://api.github.com/users/G-Node/repos","events_url":"https://api.github.com/users/G-Node/events{/privacy}","received_events_url":"https://api.github.com/users/G-Node/received_events","type":"Organization","site_admin":false},"repo":{"id":8537623,"name":"nix","full_name":"G-Node/nix","owner":{"login":"G-Node","id":574778,"avatar_url":"https://avatars.githubusercontent.com/u/574778?","gravatar_id":"bca3b1f9c5dc79798c4d0d6be2b572f0","url":"https://api.github.com/users/G-Node","html_url":"https://github.com/G-Node","followers_url":"https://api.github.com/users/G-Node/followers","following_url":"https://api.github.com/users/G-Node/following{/other_user}","gists_url":"https://api.github.com/users/G-Node/gists{/gist_id}","starred_url":"https://api.github.com/users/G-Node/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/G-Node/subscriptions","organizations_url":"https://api.github.com/users/G-Node/orgs","repos_url":"https://api.github.com/users/G-Node/repos","events_url":"https://api.github.com/users/G-Node/events{/privacy}","received_events_url":"https://api.github.com/users/G-Node/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/G-Node/nix","description":"Neuroscience information exchange format","fork":false,"url":"https://api.github.com/repos/G-Node/nix","forks_url":"https://api.github.com/repos/G-Node/nix/forks","keys_url":"https://api.github.com/repos/G-Node/nix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/G-Node/nix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/G-Node/nix/teams","hooks_url":"https://api.github.com/repos/G-Node/nix/hooks","issue_events_url":"https://api.github.com/repos/G-Node/nix/issues/events{/number}","events_url":"https://api.github.com/repos/G-Node/nix/events","assignees_url":"https://api.github.com/repos/G-Node/nix/assignees{/user}","branches_url":"https://api.github.com/repos/G-Node/nix/branches{/branch}","tags_url":"https://api.github.com/repos/G-Node/nix/tags","blobs_url":"https://api.github.com/repos/G-Node/nix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/G-Node/nix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/G-Node/nix/git/refs{/sha}","trees_url":"https://api.github.com/repos/G-Node/nix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/G-Node/nix/statuses/{sha}","languages_url":"https://api.github.com/repos/G-Node/nix/languages","stargazers_url":"https://api.github.com/repos/G-Node/nix/stargazers","contributors_url":"https://api.github.com/repos/G-Node/nix/contributors","subscribers_url":"https://api.github.com/repos/G-Node/nix/subscribers","subscription_url":"https://api.github.com/repos/G-Node/nix/subscription","commits_url":"https://api.github.com/repos/G-Node/nix/commits{/sha}","git_commits_url":"https://api.github.com/repos/G-Node/nix/git/commits{/sha}","comments_url":"https://api.github.com/repos/G-Node/nix/comments{/number}","issue_comment_url":"https://api.github.com/repos/G-Node/nix/issues/comments/{number}","contents_url":"https://api.github.com/repos/G-Node/nix/contents/{+path}","compare_url":"https://api.github.com/repos/G-Node/nix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/G-Node/nix/merges","archive_url":"https://api.github.com/repos/G-Node/nix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/G-Node/nix/downloads","issues_url":"https://api.github.com/repos/G-Node/nix/issues{/number}","pulls_url":"https://api.github.com/repos/G-Node/nix/pulls{/number}","milestones_url":"https://api.github.com/repos/G-Node/nix/milestones{/number}","notifications_url":"https://api.github.com/repos/G-Node/nix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/G-Node/nix/labels{/name}","releases_url":"https://api.github.com/repos/G-Node/nix/releases{/id}","created_at":"2013-03-03T14:52:06Z","updated_at":"2014-06-27T07:30:50Z","pushed_at":"2014-07-13T13:51:28Z","git_url":"git://github.com/G-Node/nix.git","ssh_url":"git@github.com:G-Node/nix.git","clone_url":"https://github.com/G-Node/nix.git","svn_url":"https://github.com/G-Node/nix","homepage":"","size":10367,"stargazers_count":11,"watchers_count":11,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":5,"mirror_url":null,"open_issues_count":28,"forks":5,"open_issues":28,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/G-Node/nix/pulls/275"},"html":{"href":"https://github.com/G-Node/nix/pull/275"},"issue":{"href":"https://api.github.com/repos/G-Node/nix/issues/275"},"comments":{"href":"https://api.github.com/repos/G-Node/nix/issues/275/comments"},"review_comments":{"href":"https://api.github.com/repos/G-Node/nix/pulls/275/comments"},"review_comment":{"href":"https://api.github.com/repos/G-Node/nix/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/G-Node/nix/pulls/275/commits"},"statuses":{"href":"https://api.github.com/repos/G-Node/nix/statuses/02ba2cd62218a4ae481717304edcd29ff577330c"}}}}