GitHub PullRequestReviewCommentEvent at 2014-02-09 16:19:28
Repository: dns
Actor: majek
Payload: {"comment":{"url":"https://api.github.com/repos/miekg/dns/pulls/comments/9569339","id":9569339,"diff_hunk":"@@ -1526,44 +1526,55 @@ func (dns *Msg) Len() int {\n \t}\n \n \tfor i := 0; i < len(dns.Question); i++ {\n-\t\tl += dns.Question[i].len()\n+\t\tf := dns.Question[i]","path":"msg.go","position":5,"original_position":5,"commit_id":"fc0ac4ea64dec8354d5b58d70d3da277f3a2c0e5","original_commit_id":"fc0ac4ea64dec8354d5b58d70d3da277f3a2c0e5","user":{"login":"majek","id":63387,"avatar_url":"https://gravatar.com/avatar/d4e1d473a995ef37b3e03e9e6006c3e3?d=https%3A%2F%2Fidenticons.github.com%2F3abdac2a6a3f5ce1ad1af69a4625fa3a.png&r=x","gravatar_id":"d4e1d473a995ef37b3e03e9e6006c3e3","url":"https://api.github.com/users/majek","html_url":"https://github.com/majek","followers_url":"https://api.github.com/users/majek/followers","following_url":"https://api.github.com/users/majek/following{/other_user}","gists_url":"https://api.github.com/users/majek/gists{/gist_id}","starred_url":"https://api.github.com/users/majek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/majek/subscriptions","organizations_url":"https://api.github.com/users/majek/orgs","repos_url":"https://api.github.com/users/majek/repos","events_url":"https://api.github.com/users/majek/events{/privacy}","received_events_url":"https://api.github.com/users/majek/received_events","type":"User","site_admin":false},"body":"as a matter of fact `f` could be assigned in the loop if we used `i, f := range dns.Questions`. Is there a reason why you dislike `range`?","created_at":"2014-02-09T16:19:28Z","updated_at":"2014-02-09T16:19:28Z","html_url":"https://github.com/miekg/dns/pull/81#discussion_r9569339","pull_request_url":"https://api.github.com/repos/miekg/dns/pulls/81","_links":{"self":{"href":"https://api.github.com/repos/miekg/dns/pulls/comments/9569339"},"html":{"href":"https://github.com/miekg/dns/pull/81#discussion_r9569339"},"pull_request":{"href":"https://api.github.com/repos/miekg/dns/pulls/81"}}}}