GitHub PullRequestReviewCommentEvent at 2014-12-13 16:04:02
Repository: waysome
Actor: matthiasbeyer
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/waysome/waysome/pulls/comments/21789039","id":21789039,"diff_hunk":"@@ -159,8 +161,15 @@ ws_action_manager_process(\n         }\n \n         if (flags & WS_TRANSACTION_FLAGS_EXEC) {\n+            struct ws_value* vctx = NULL;\n+            struct ws_value_object_id ctx;\n+            ws_value_object_id_init(&ctx);\n+            if (opt_ctx) {\n+                ws_value_object_id_set(&ctx, opt_ctx);\n+                vctx = &ctx.val;\n+            }","path":"src/action/manager.c","position":30,"original_position":30,"commit_id":"3ed27991459eaf7e607f561ac30eb7f1cd7d7b3e","original_commit_id":"3ed27991459eaf7e607f561ac30eb7f1cd7d7b3e","user":{"login":"matthiasbeyer","id":427866,"avatar_url":"https://avatars.githubusercontent.com/u/427866?v=3","gravatar_id":"","url":"https://api.github.com/users/matthiasbeyer","html_url":"https://github.com/matthiasbeyer","followers_url":"https://api.github.com/users/matthiasbeyer/followers","following_url":"https://api.github.com/users/matthiasbeyer/following{/other_user}","gists_url":"https://api.github.com/users/matthiasbeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/matthiasbeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthiasbeyer/subscriptions","organizations_url":"https://api.github.com/users/matthiasbeyer/orgs","repos_url":"https://api.github.com/users/matthiasbeyer/repos","events_url":"https://api.github.com/users/matthiasbeyer/events{/privacy}","received_events_url":"https://api.github.com/users/matthiasbeyer/received_events","type":"User","site_admin":false},"body":"I know. I think it would be more sufficient to keep them but split this function, as it is already over 100 loc. (without the doubled code nearly 100loc) and it is literally a `if() { /* do much stuff */ } else { /* do other stuff */ }`, which could be easily splitted...","created_at":"2014-12-13T16:04:02Z","updated_at":"2014-12-13T16:04:02Z","html_url":"https://github.com/waysome/waysome/pull/578#discussion_r21789039","pull_request_url":"https://api.github.com/repos/waysome/waysome/pulls/578","_links":{"self":{"href":"https://api.github.com/repos/waysome/waysome/pulls/comments/21789039"},"html":{"href":"https://github.com/waysome/waysome/pull/578#discussion_r21789039"},"pull_request":{"href":"https://api.github.com/repos/waysome/waysome/pulls/578"}}},"pull_request":{"url":"https://api.github.com/repos/waysome/waysome/pulls/578","id":25823015,"html_url":"https://github.com/waysome/waysome/pull/578","diff_url":"https://github.com/waysome/waysome/pull/578.diff","patch_url":"https://github.com/waysome/waysome/pull/578.patch","issue_url":"https://api.github.com/repos/waysome/waysome/issues/578","number":578,"state":"open","locked":false,"title":"Pass connection context to transaction execution","user":{"login":"matthiasbeyer","id":427866,"avatar_url":"https://avatars.githubusercontent.com/u/427866?v=3","gravatar_id":"","url":"https://api.github.com/users/matthiasbeyer","html_url":"https://github.com/matthiasbeyer","followers_url":"https://api.github.com/users/matthiasbeyer/followers","following_url":"https://api.github.com/users/matthiasbeyer/following{/other_user}","gists_url":"https://api.github.com/users/matthiasbeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/matthiasbeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthiasbeyer/subscriptions","organizations_url":"https://api.github.com/users/matthiasbeyer/orgs","repos_url":"https://api.github.com/users/matthiasbeyer/repos","events_url":"https://api.github.com/users/matthiasbeyer/events{/privacy}","received_events_url":"https://api.github.com/users/matthiasbeyer/received_events","type":"User","site_admin":false},"body":"My approach on/Targets #563.","created_at":"2014-12-10T13:52:57Z","updated_at":"2014-12-13T16:04:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c79572cf3dbc807e068a81a6bf37cede8b40e857","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/waysome/waysome/pulls/578/commits","review_comments_url":"https://api.github.com/repos/waysome/waysome/pulls/578/comments","review_comment_url":"https://api.github.com/repos/waysome/waysome/pulls/comments/{number}","comments_url":"https://api.github.com/repos/waysome/waysome/issues/578/comments","statuses_url":"https://api.github.com/repos/waysome/waysome/statuses/3ed27991459eaf7e607f561ac30eb7f1cd7d7b3e","head":{"label":"matthiasbeyer:add-connection_context","ref":"add-connection_context","sha":"3ed27991459eaf7e607f561ac30eb7f1cd7d7b3e","user":{"login":"matthiasbeyer","id":427866,"avatar_url":"https://avatars.githubusercontent.com/u/427866?v=3","gravatar_id":"","url":"https://api.github.com/users/matthiasbeyer","html_url":"https://github.com/matthiasbeyer","followers_url":"https://api.github.com/users/matthiasbeyer/followers","following_url":"https://api.github.com/users/matthiasbeyer/following{/other_user}","gists_url":"https://api.github.com/users/matthiasbeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/matthiasbeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthiasbeyer/subscriptions","organizations_url":"https://api.github.com/users/matthiasbeyer/orgs","repos_url":"https://api.github.com/users/matthiasbeyer/repos","events_url":"https://api.github.com/users/matthiasbeyer/events{/privacy}","received_events_url":"https://api.github.com/users/matthiasbeyer/received_events","type":"User","site_admin":false},"repo":{"id":24571706,"name":"waysome","full_name":"matthiasbeyer/waysome","owner":{"login":"matthiasbeyer","id":427866,"avatar_url":"https://avatars.githubusercontent.com/u/427866?v=3","gravatar_id":"","url":"https://api.github.com/users/matthiasbeyer","html_url":"https://github.com/matthiasbeyer","followers_url":"https://api.github.com/users/matthiasbeyer/followers","following_url":"https://api.github.com/users/matthiasbeyer/following{/other_user}","gists_url":"https://api.github.com/users/matthiasbeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/matthiasbeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthiasbeyer/subscriptions","organizations_url":"https://api.github.com/users/matthiasbeyer/orgs","repos_url":"https://api.github.com/users/matthiasbeyer/repos","events_url":"https://api.github.com/users/matthiasbeyer/events{/privacy}","received_events_url":"https://api.github.com/users/matthiasbeyer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/matthiasbeyer/waysome","description":"Windowmanager for wayland","fork":true,"url":"https://api.github.com/repos/matthiasbeyer/waysome","forks_url":"https://api.github.com/repos/matthiasbeyer/waysome/forks","keys_url":"https://api.github.com/repos/matthiasbeyer/waysome/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matthiasbeyer/waysome/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matthiasbeyer/waysome/teams","hooks_url":"https://api.github.com/repos/matthiasbeyer/waysome/hooks","issue_events_url":"https://api.github.com/repos/matthiasbeyer/waysome/issues/events{/number}","events_url":"https://api.github.com/repos/matthiasbeyer/waysome/events","assignees_url":"https://api.github.com/repos/matthiasbeyer/waysome/assignees{/user}","branches_url":"https://api.github.com/repos/matthiasbeyer/waysome/branches{/branch}","tags_url":"https://api.github.com/repos/matthiasbeyer/waysome/tags","blobs_url":"https://api.github.com/repos/matthiasbeyer/waysome/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matthiasbeyer/waysome/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matthiasbeyer/waysome/git/refs{/sha}","trees_url":"https://api.github.com/repos/matthiasbeyer/waysome/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matthiasbeyer/waysome/statuses/{sha}","languages_url":"https://api.github.com/repos/matthiasbeyer/waysome/languages","stargazers_url":"https://api.github.com/repos/matthiasbeyer/waysome/stargazers","contributors_url":"https://api.github.com/repos/matthiasbeyer/waysome/contributors","subscribers_url":"https://api.github.com/repos/matthiasbeyer/waysome/subscribers","subscription_url":"https://api.github.com/repos/matthiasbeyer/waysome/subscription","commits_url":"https://api.github.com/repos/matthiasbeyer/waysome/commits{/sha}","git_commits_url":"https://api.github.com/repos/matthiasbeyer/waysome/git/commits{/sha}","comments_url":"https://api.github.com/repos/matthiasbeyer/waysome/comments{/number}","issue_comment_url":"https://api.github.com/repos/matthiasbeyer/waysome/issues/comments/{number}","contents_url":"https://api.github.com/repos/matthiasbeyer/waysome/contents/{+path}","compare_url":"https://api.github.com/repos/matthiasbeyer/waysome/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matthiasbeyer/waysome/merges","archive_url":"https://api.github.com/repos/matthiasbeyer/waysome/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matthiasbeyer/waysome/downloads","issues_url":"https://api.github.com/repos/matthiasbeyer/waysome/issues{/number}","pulls_url":"https://api.github.com/repos/matthiasbeyer/waysome/pulls{/number}","milestones_url":"https://api.github.com/repos/matthiasbeyer/waysome/milestones{/number}","notifications_url":"https://api.github.com/repos/matthiasbeyer/waysome/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matthiasbeyer/waysome/labels{/name}","releases_url":"https://api.github.com/repos/matthiasbeyer/waysome/releases{/id}","created_at":"2014-09-28T22:13:03Z","updated_at":"2014-12-11T23:58:49Z","pushed_at":"2014-12-13T15:58:53Z","git_url":"git://github.com/matthiasbeyer/waysome.git","ssh_url":"git@github.com:matthiasbeyer/waysome.git","clone_url":"https://github.com/matthiasbeyer/waysome.git","svn_url":"https://github.com/matthiasbeyer/waysome","homepage":null,"size":3209,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"waysome:develop","ref":"develop","sha":"dedbcd6f1f6f254afeb4c3e4043099f6d217121a","user":{"login":"waysome","id":8951090,"avatar_url":"https://avatars.githubusercontent.com/u/8951090?v=3","gravatar_id":"","url":"https://api.github.com/users/waysome","html_url":"https://github.com/waysome","followers_url":"https://api.github.com/users/waysome/followers","following_url":"https://api.github.com/users/waysome/following{/other_user}","gists_url":"https://api.github.com/users/waysome/gists{/gist_id}","starred_url":"https://api.github.com/users/waysome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/waysome/subscriptions","organizations_url":"https://api.github.com/users/waysome/orgs","repos_url":"https://api.github.com/users/waysome/repos","events_url":"https://api.github.com/users/waysome/events{/privacy}","received_events_url":"https://api.github.com/users/waysome/received_events","type":"Organization","site_admin":false},"repo":{"id":24571650,"name":"waysome","full_name":"waysome/waysome","owner":{"login":"waysome","id":8951090,"avatar_url":"https://avatars.githubusercontent.com/u/8951090?v=3","gravatar_id":"","url":"https://api.github.com/users/waysome","html_url":"https://github.com/waysome","followers_url":"https://api.github.com/users/waysome/followers","following_url":"https://api.github.com/users/waysome/following{/other_user}","gists_url":"https://api.github.com/users/waysome/gists{/gist_id}","starred_url":"https://api.github.com/users/waysome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/waysome/subscriptions","organizations_url":"https://api.github.com/users/waysome/orgs","repos_url":"https://api.github.com/users/waysome/repos","events_url":"https://api.github.com/users/waysome/events{/privacy}","received_events_url":"https://api.github.com/users/waysome/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/waysome/waysome","description":"Windowmanager for wayland","fork":false,"url":"https://api.github.com/repos/waysome/waysome","forks_url":"https://api.github.com/repos/waysome/waysome/forks","keys_url":"https://api.github.com/repos/waysome/waysome/keys{/key_id}","collaborators_url":"https://api.github.com/repos/waysome/waysome/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/waysome/waysome/teams","hooks_url":"https://api.github.com/repos/waysome/waysome/hooks","issue_events_url":"https://api.github.com/repos/waysome/waysome/issues/events{/number}","events_url":"https://api.github.com/repos/waysome/waysome/events","assignees_url":"https://api.github.com/repos/waysome/waysome/assignees{/user}","branches_url":"https://api.github.com/repos/waysome/waysome/branches{/branch}","tags_url":"https://api.github.com/repos/waysome/waysome/tags","blobs_url":"https://api.github.com/repos/waysome/waysome/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/waysome/waysome/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/waysome/waysome/git/refs{/sha}","trees_url":"https://api.github.com/repos/waysome/waysome/git/trees{/sha}","statuses_url":"https://api.github.com/repos/waysome/waysome/statuses/{sha}","languages_url":"https://api.github.com/repos/waysome/waysome/languages","stargazers_url":"https://api.github.com/repos/waysome/waysome/stargazers","contributors_url":"https://api.github.com/repos/waysome/waysome/contributors","subscribers_url":"https://api.github.com/repos/waysome/waysome/subscribers","subscription_url":"https://api.github.com/repos/waysome/waysome/subscription","commits_url":"https://api.github.com/repos/waysome/waysome/commits{/sha}","git_commits_url":"https://api.github.com/repos/waysome/waysome/git/commits{/sha}","comments_url":"https://api.github.com/repos/waysome/waysome/comments{/number}","issue_comment_url":"https://api.github.com/repos/waysome/waysome/issues/comments/{number}","contents_url":"https://api.github.com/repos/waysome/waysome/contents/{+path}","compare_url":"https://api.github.com/repos/waysome/waysome/compare/{base}...{head}","merges_url":"https://api.github.com/repos/waysome/waysome/merges","archive_url":"https://api.github.com/repos/waysome/waysome/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/waysome/waysome/downloads","issues_url":"https://api.github.com/repos/waysome/waysome/issues{/number}","pulls_url":"https://api.github.com/repos/waysome/waysome/pulls{/number}","milestones_url":"https://api.github.com/repos/waysome/waysome/milestones{/number}","notifications_url":"https://api.github.com/repos/waysome/waysome/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/waysome/waysome/labels{/name}","releases_url":"https://api.github.com/repos/waysome/waysome/releases{/id}","created_at":"2014-09-28T22:08:58Z","updated_at":"2014-12-13T15:18:24Z","pushed_at":"2014-12-13T15:18:24Z","git_url":"git://github.com/waysome/waysome.git","ssh_url":"git@github.com:waysome/waysome.git","clone_url":"https://github.com/waysome/waysome.git","svn_url":"https://github.com/waysome/waysome","homepage":null,"size":5199,"stargazers_count":7,"watchers_count":7,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":39,"forks":7,"open_issues":39,"watchers":7,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/waysome/waysome/pulls/578"},"html":{"href":"https://github.com/waysome/waysome/pull/578"},"issue":{"href":"https://api.github.com/repos/waysome/waysome/issues/578"},"comments":{"href":"https://api.github.com/repos/waysome/waysome/issues/578/comments"},"review_comments":{"href":"https://api.github.com/repos/waysome/waysome/pulls/578/comments"},"review_comment":{"href":"https://api.github.com/repos/waysome/waysome/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/waysome/waysome/pulls/578/commits"},"statuses":{"href":"https://api.github.com/repos/waysome/waysome/statuses/3ed27991459eaf7e607f561ac30eb7f1cd7d7b3e"}}}}