GitHub PullRequestReviewCommentEvent at 2014-09-06 01:16:11
Repository: spirit_x3
Actor: djowel
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/djowel/spirit_x3/pulls/comments/17205856","id":17205856,"diff_hunk":"@@ -35,67 +35,67 @@ namespace boost { namespace spirit { namespace char_encoding\n         {\n             // uses all 8 bits\n             // we have to watch out for sign extensions\n-            return (0 == (ch & ~0xff) || ~0 == (ch | 0xff)) ? true : false;\n+            return (0 == (ch & ~0xff) || ~0 == (ch | 0xff));\n         }\n \n         static bool\n         isalnum(int ch)\n         {\n-            return std::isalnum(ch) ? true : false;\n+            return std::isalnum((unsigned char)ch);","path":"include/boost/spirit/home/support/char_encoding/standard.hpp","position":12,"original_position":12,"commit_id":"821b4c6761ee7188965a7e4144bc647362ce3e50","original_commit_id":"821b4c6761ee7188965a7e4144bc647362ce3e50","user":{"login":"djowel","id":568094,"avatar_url":"https://avatars.githubusercontent.com/u/568094?v=2","gravatar_id":"b40a53e56b1a1ed8ad87c31c70c8a5c6","url":"https://api.github.com/users/djowel","html_url":"https://github.com/djowel","followers_url":"https://api.github.com/users/djowel/followers","following_url":"https://api.github.com/users/djowel/following{/other_user}","gists_url":"https://api.github.com/users/djowel/gists{/gist_id}","starred_url":"https://api.github.com/users/djowel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djowel/subscriptions","organizations_url":"https://api.github.com/users/djowel/orgs","repos_url":"https://api.github.com/users/djowel/repos","events_url":"https://api.github.com/users/djowel/events{/privacy}","received_events_url":"https://api.github.com/users/djowel/received_events","type":"User","site_admin":false},"body":"is cast to (unsigned char) is needed, at least use c++ casts.","created_at":"2014-09-06T01:16:11Z","updated_at":"2014-09-06T01:16:11Z","html_url":"https://github.com/djowel/spirit_x3/pull/12#discussion_r17205856","pull_request_url":"https://api.github.com/repos/djowel/spirit_x3/pulls/12","_links":{"self":{"href":"https://api.github.com/repos/djowel/spirit_x3/pulls/comments/17205856"},"html":{"href":"https://github.com/djowel/spirit_x3/pull/12#discussion_r17205856"},"pull_request":{"href":"https://api.github.com/repos/djowel/spirit_x3/pulls/12"}}},"pull_request":{"url":"https://api.github.com/repos/djowel/spirit_x3/pulls/12","id":20650308,"html_url":"https://github.com/djowel/spirit_x3/pull/12","diff_url":"https://github.com/djowel/spirit_x3/pull/12.diff","patch_url":"https://github.com/djowel/spirit_x3/pull/12.patch","issue_url":"https://api.github.com/repos/djowel/spirit_x3/issues/12","number":12,"state":"open","locked":false,"title":"Modernize Unicode","user":{"login":"chipdude","id":97894,"avatar_url":"https://avatars.githubusercontent.com/u/97894?v=2","gravatar_id":"8e4ab5d1af01a1afef35882d6bb47bc3","url":"https://api.github.com/users/chipdude","html_url":"https://github.com/chipdude","followers_url":"https://api.github.com/users/chipdude/followers","following_url":"https://api.github.com/users/chipdude/following{/other_user}","gists_url":"https://api.github.com/users/chipdude/gists{/gist_id}","starred_url":"https://api.github.com/users/chipdude/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chipdude/subscriptions","organizations_url":"https://api.github.com/users/chipdude/orgs","repos_url":"https://api.github.com/users/chipdude/repos","events_url":"https://api.github.com/users/chipdude/events{/privacy}","received_events_url":"https://api.github.com/users/chipdude/received_events","type":"User","site_admin":false},"body":"C++11 types char16_t and char32_t are designed for overloading by Unicode encoding style; they are productively quite useful in Spirit.  So convert to using them as the fundamental types for UTF-16 and UTF-32.\r\n\r\nNote that ischar() for 8-bit and 16-bit values just detects whether the value will fit into 8/16 bits, so I changed the one for UTF-32 to do the same; so it is always true.  As it was, you'll end up checking every character for <= 0x10FFFF before redundantly testing it for e.g. equality with 'x'.  Is this change Not Good for some reason?\r\n\r\nAlso fix high-bit characters being possibly sign-extended before being passed to std::isxxx() which is Very Bad.\r\nAlso remove names from unused parameters, so we can use -Wunused to find the really unused ones.\r\nAlso a few other minor things.\r\n(updated to mask wchar_t properly)","created_at":"2014-09-03T00:55:11Z","updated_at":"2014-09-06T01:16:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"409af684e2af27295f5c07b6e37ab64762c0df07","assignee":{"login":"djowel","id":568094,"avatar_url":"https://avatars.githubusercontent.com/u/568094?v=2","gravatar_id":"b40a53e56b1a1ed8ad87c31c70c8a5c6","url":"https://api.github.com/users/djowel","html_url":"https://github.com/djowel","followers_url":"https://api.github.com/users/djowel/followers","following_url":"https://api.github.com/users/djowel/following{/other_user}","gists_url":"https://api.github.com/users/djowel/gists{/gist_id}","starred_url":"https://api.github.com/users/djowel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djowel/subscriptions","organizations_url":"https://api.github.com/users/djowel/orgs","repos_url":"https://api.github.com/users/djowel/repos","events_url":"https://api.github.com/users/djowel/events{/privacy}","received_events_url":"https://api.github.com/users/djowel/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/djowel/spirit_x3/pulls/12/commits","review_comments_url":"https://api.github.com/repos/djowel/spirit_x3/pulls/12/comments","review_comment_url":"https://api.github.com/repos/djowel/spirit_x3/pulls/comments/{number}","comments_url":"https://api.github.com/repos/djowel/spirit_x3/issues/12/comments","statuses_url":"https://api.github.com/repos/djowel/spirit_x3/statuses/821b4c6761ee7188965a7e4144bc647362ce3e50","head":{"label":"chipdude:modern","ref":"modern","sha":"821b4c6761ee7188965a7e4144bc647362ce3e50","user":{"login":"chipdude","id":97894,"avatar_url":"https://avatars.githubusercontent.com/u/97894?v=2","gravatar_id":"8e4ab5d1af01a1afef35882d6bb47bc3","url":"https://api.github.com/users/chipdude","html_url":"https://github.com/chipdude","followers_url":"https://api.github.com/users/chipdude/followers","following_url":"https://api.github.com/users/chipdude/following{/other_user}","gists_url":"https://api.github.com/users/chipdude/gists{/gist_id}","starred_url":"https://api.github.com/users/chipdude/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chipdude/subscriptions","organizations_url":"https://api.github.com/users/chipdude/orgs","repos_url":"https://api.github.com/users/chipdude/repos","events_url":"https://api.github.com/users/chipdude/events{/privacy}","received_events_url":"https://api.github.com/users/chipdude/received_events","type":"User","site_admin":false},"repo":{"id":23600986,"name":"spirit_x3","full_name":"chipdude/spirit_x3","owner":{"login":"chipdude","id":97894,"avatar_url":"https://avatars.githubusercontent.com/u/97894?v=2","gravatar_id":"8e4ab5d1af01a1afef35882d6bb47bc3","url":"https://api.github.com/users/chipdude","html_url":"https://github.com/chipdude","followers_url":"https://api.github.com/users/chipdude/followers","following_url":"https://api.github.com/users/chipdude/following{/other_user}","gists_url":"https://api.github.com/users/chipdude/gists{/gist_id}","starred_url":"https://api.github.com/users/chipdude/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chipdude/subscriptions","organizations_url":"https://api.github.com/users/chipdude/orgs","repos_url":"https://api.github.com/users/chipdude/repos","events_url":"https://api.github.com/users/chipdude/events{/privacy}","received_events_url":"https://api.github.com/users/chipdude/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chipdude/spirit_x3","description":"Spirit X3 Experimental","fork":true,"url":"https://api.github.com/repos/chipdude/spirit_x3","forks_url":"https://api.github.com/repos/chipdude/spirit_x3/forks","keys_url":"https://api.github.com/repos/chipdude/spirit_x3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chipdude/spirit_x3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chipdude/spirit_x3/teams","hooks_url":"https://api.github.com/repos/chipdude/spirit_x3/hooks","issue_events_url":"https://api.github.com/repos/chipdude/spirit_x3/issues/events{/number}","events_url":"https://api.github.com/repos/chipdude/spirit_x3/events","assignees_url":"https://api.github.com/repos/chipdude/spirit_x3/assignees{/user}","branches_url":"https://api.github.com/repos/chipdude/spirit_x3/branches{/branch}","tags_url":"https://api.github.com/repos/chipdude/spirit_x3/tags","blobs_url":"https://api.github.com/repos/chipdude/spirit_x3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chipdude/spirit_x3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chipdude/spirit_x3/git/refs{/sha}","trees_url":"https://api.github.com/repos/chipdude/spirit_x3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chipdude/spirit_x3/statuses/{sha}","languages_url":"https://api.github.com/repos/chipdude/spirit_x3/languages","stargazers_url":"https://api.github.com/repos/chipdude/spirit_x3/stargazers","contributors_url":"https://api.github.com/repos/chipdude/spirit_x3/contributors","subscribers_url":"https://api.github.com/repos/chipdude/spirit_x3/subscribers","subscription_url":"https://api.github.com/repos/chipdude/spirit_x3/subscription","commits_url":"https://api.github.com/repos/chipdude/spirit_x3/commits{/sha}","git_commits_url":"https://api.github.com/repos/chipdude/spirit_x3/git/commits{/sha}","comments_url":"https://api.github.com/repos/chipdude/spirit_x3/comments{/number}","issue_comment_url":"https://api.github.com/repos/chipdude/spirit_x3/issues/comments/{number}","contents_url":"https://api.github.com/repos/chipdude/spirit_x3/contents/{+path}","compare_url":"https://api.github.com/repos/chipdude/spirit_x3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chipdude/spirit_x3/merges","archive_url":"https://api.github.com/repos/chipdude/spirit_x3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chipdude/spirit_x3/downloads","issues_url":"https://api.github.com/repos/chipdude/spirit_x3/issues{/number}","pulls_url":"https://api.github.com/repos/chipdude/spirit_x3/pulls{/number}","milestones_url":"https://api.github.com/repos/chipdude/spirit_x3/milestones{/number}","notifications_url":"https://api.github.com/repos/chipdude/spirit_x3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chipdude/spirit_x3/labels{/name}","releases_url":"https://api.github.com/repos/chipdude/spirit_x3/releases{/id}","created_at":"2014-09-03T00:46:15Z","updated_at":"2014-09-02T22:06:24Z","pushed_at":"2014-09-04T07:24:24Z","git_url":"git://github.com/chipdude/spirit_x3.git","ssh_url":"git@github.com:chipdude/spirit_x3.git","clone_url":"https://github.com/chipdude/spirit_x3.git","svn_url":"https://github.com/chipdude/spirit_x3","homepage":null,"size":19147,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"djowel:master","ref":"master","sha":"e95d80d682916779c88599c7f3ce197e5877cdaf","user":{"login":"djowel","id":568094,"avatar_url":"https://avatars.githubusercontent.com/u/568094?v=2","gravatar_id":"b40a53e56b1a1ed8ad87c31c70c8a5c6","url":"https://api.github.com/users/djowel","html_url":"https://github.com/djowel","followers_url":"https://api.github.com/users/djowel/followers","following_url":"https://api.github.com/users/djowel/following{/other_user}","gists_url":"https://api.github.com/users/djowel/gists{/gist_id}","starred_url":"https://api.github.com/users/djowel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djowel/subscriptions","organizations_url":"https://api.github.com/users/djowel/orgs","repos_url":"https://api.github.com/users/djowel/repos","events_url":"https://api.github.com/users/djowel/events{/privacy}","received_events_url":"https://api.github.com/users/djowel/received_events","type":"User","site_admin":false},"repo":{"id":7936940,"name":"spirit_x3","full_name":"djowel/spirit_x3","owner":{"login":"djowel","id":568094,"avatar_url":"https://avatars.githubusercontent.com/u/568094?v=2","gravatar_id":"b40a53e56b1a1ed8ad87c31c70c8a5c6","url":"https://api.github.com/users/djowel","html_url":"https://github.com/djowel","followers_url":"https://api.github.com/users/djowel/followers","following_url":"https://api.github.com/users/djowel/following{/other_user}","gists_url":"https://api.github.com/users/djowel/gists{/gist_id}","starred_url":"https://api.github.com/users/djowel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djowel/subscriptions","organizations_url":"https://api.github.com/users/djowel/orgs","repos_url":"https://api.github.com/users/djowel/repos","events_url":"https://api.github.com/users/djowel/events{/privacy}","received_events_url":"https://api.github.com/users/djowel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/djowel/spirit_x3","description":"Spirit X3 Experimental","fork":false,"url":"https://api.github.com/repos/djowel/spirit_x3","forks_url":"https://api.github.com/repos/djowel/spirit_x3/forks","keys_url":"https://api.github.com/repos/djowel/spirit_x3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/djowel/spirit_x3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/djowel/spirit_x3/teams","hooks_url":"https://api.github.com/repos/djowel/spirit_x3/hooks","issue_events_url":"https://api.github.com/repos/djowel/spirit_x3/issues/events{/number}","events_url":"https://api.github.com/repos/djowel/spirit_x3/events","assignees_url":"https://api.github.com/repos/djowel/spirit_x3/assignees{/user}","branches_url":"https://api.github.com/repos/djowel/spirit_x3/branches{/branch}","tags_url":"https://api.github.com/repos/djowel/spirit_x3/tags","blobs_url":"https://api.github.com/repos/djowel/spirit_x3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/djowel/spirit_x3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/djowel/spirit_x3/git/refs{/sha}","trees_url":"https://api.github.com/repos/djowel/spirit_x3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/djowel/spirit_x3/statuses/{sha}","languages_url":"https://api.github.com/repos/djowel/spirit_x3/languages","stargazers_url":"https://api.github.com/repos/djowel/spirit_x3/stargazers","contributors_url":"https://api.github.com/repos/djowel/spirit_x3/contributors","subscribers_url":"https://api.github.com/repos/djowel/spirit_x3/subscribers","subscription_url":"https://api.github.com/repos/djowel/spirit_x3/subscription","commits_url":"https://api.github.com/repos/djowel/spirit_x3/commits{/sha}","git_commits_url":"https://api.github.com/repos/djowel/spirit_x3/git/commits{/sha}","comments_url":"https://api.github.com/repos/djowel/spirit_x3/comments{/number}","issue_comment_url":"https://api.github.com/repos/djowel/spirit_x3/issues/comments/{number}","contents_url":"https://api.github.com/repos/djowel/spirit_x3/contents/{+path}","compare_url":"https://api.github.com/repos/djowel/spirit_x3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/djowel/spirit_x3/merges","archive_url":"https://api.github.com/repos/djowel/spirit_x3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/djowel/spirit_x3/downloads","issues_url":"https://api.github.com/repos/djowel/spirit_x3/issues{/number}","pulls_url":"https://api.github.com/repos/djowel/spirit_x3/pulls{/number}","milestones_url":"https://api.github.com/repos/djowel/spirit_x3/milestones{/number}","notifications_url":"https://api.github.com/repos/djowel/spirit_x3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/djowel/spirit_x3/labels{/name}","releases_url":"https://api.github.com/repos/djowel/spirit_x3/releases{/id}","created_at":"2013-01-31T13:09:01Z","updated_at":"2014-09-02T22:06:24Z","pushed_at":"2014-06-07T00:27:50Z","git_url":"git://github.com/djowel/spirit_x3.git","ssh_url":"git@github.com:djowel/spirit_x3.git","clone_url":"https://github.com/djowel/spirit_x3.git","svn_url":"https://github.com/djowel/spirit_x3","homepage":null,"size":20258,"stargazers_count":75,"watchers_count":75,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":20,"mirror_url":null,"open_issues_count":5,"forks":20,"open_issues":5,"watchers":75,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/djowel/spirit_x3/pulls/12"},"html":{"href":"https://github.com/djowel/spirit_x3/pull/12"},"issue":{"href":"https://api.github.com/repos/djowel/spirit_x3/issues/12"},"comments":{"href":"https://api.github.com/repos/djowel/spirit_x3/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/djowel/spirit_x3/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/djowel/spirit_x3/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/djowel/spirit_x3/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/djowel/spirit_x3/statuses/821b4c6761ee7188965a7e4144bc647362ce3e50"}}}}