GitHub PullRequestReviewCommentEvent at 2014-03-20 17:50:15
Repository: stagecraft
Actor: paulfurley
Payload: {"comment":{"url":"https://api.github.com/repos/alphagov/stagecraft/pulls/comments/10807103","id":10807103,"diff_hunk":"@@ -31,7 +34,18 @@ def _wrapped_view(request, *args, **kwargs):\n     return decorator\n \n \n+def long_cache(a_view):\n+    @wraps(a_view)\n+    @vary_on_headers('Authorization')","path":"stagecraft/apps/datasets/views/data_set.py","position":19,"original_position":19,"commit_id":"83a360c0f1e21c292d35224fc314e9f23f1acaae","original_commit_id":"83a360c0f1e21c292d35224fc314e9f23f1acaae","user":{"login":"paulfurley","id":254290,"avatar_url":"https://avatars.githubusercontent.com/u/254290?","gravatar_id":"fcd1fd8a749c9c90894fffa48020223a","url":"https://api.github.com/users/paulfurley","html_url":"https://github.com/paulfurley","followers_url":"https://api.github.com/users/paulfurley/followers","following_url":"https://api.github.com/users/paulfurley/following{/other_user}","gists_url":"https://api.github.com/users/paulfurley/gists{/gist_id}","starred_url":"https://api.github.com/users/paulfurley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulfurley/subscriptions","organizations_url":"https://api.github.com/users/paulfurley/orgs","repos_url":"https://api.github.com/users/paulfurley/repos","events_url":"https://api.github.com/users/paulfurley/events{/privacy}","received_events_url":"https://api.github.com/users/paulfurley/received_events","type":"User","site_admin":false},"body":"I think my preference would be to put the `vary_on_headers(..)` decorator on each view, as it's a bit magical that `long_cache` does more than just a long cache.","created_at":"2014-03-20T17:50:15Z","updated_at":"2014-03-20T17:50:15Z","html_url":"https://github.com/alphagov/stagecraft/pull/83#discussion_r10807103","pull_request_url":"https://api.github.com/repos/alphagov/stagecraft/pulls/83","_links":{"self":{"href":"https://api.github.com/repos/alphagov/stagecraft/pulls/comments/10807103"},"html":{"href":"https://github.com/alphagov/stagecraft/pull/83#discussion_r10807103"},"pull_request":{"href":"https://api.github.com/repos/alphagov/stagecraft/pulls/83"}}}}