GitHub PullRequestEvent at 2014-07-23 21:13:58
Repository: bolt
Actor: benbjohnson
Payload: {"action":"opened","number":228,"pull_request":{"url":"https://api.github.com/repos/boltdb/bolt/pulls/228","id":18803476,"html_url":"https://github.com/boltdb/bolt/pull/228","diff_url":"https://github.com/boltdb/bolt/pull/228.diff","patch_url":"https://github.com/boltdb/bolt/pull/228.patch","issue_url":"https://api.github.com/repos/boltdb/bolt/issues/228","number":228,"state":"open","title":"Fix root split on very large append.","user":{"login":"benbjohnson","id":118015,"avatar_url":"https://avatars.githubusercontent.com/u/118015?","gravatar_id":"6c76488dff9b5d9a872dff88f008f88e","url":"https://api.github.com/users/benbjohnson","html_url":"https://github.com/benbjohnson","followers_url":"https://api.github.com/users/benbjohnson/followers","following_url":"https://api.github.com/users/benbjohnson/following{/other_user}","gists_url":"https://api.github.com/users/benbjohnson/gists{/gist_id}","starred_url":"https://api.github.com/users/benbjohnson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benbjohnson/subscriptions","organizations_url":"https://api.github.com/users/benbjohnson/orgs","repos_url":"https://api.github.com/users/benbjohnson/repos","events_url":"https://api.github.com/users/benbjohnson/events{/privacy}","received_events_url":"https://api.github.com/users/benbjohnson/received_events","type":"User","site_admin":false},"body":"This commit fixes a bug where a root split on a very large insert would cause an overflow of the root node. The problem was that the new root was not split when it was created so a new root with more than 64K child nodes would overflow the `page.count` (uint16).\r\n\r\nThis problem would occur when appending ~200,000 500 byte key/value pairs into a single bucket in a single transaction. This issue was previously prevented because the freelist overflow error and the double spill would rollback this kind of transaction.\r\n\r\nSee line notes for more info.\r\n\r\n/cc @mkobetic @snormore","created_at":"2014-07-23T21:13:58Z","updated_at":"2014-07-23T21:13:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/boltdb/bolt/pulls/228/commits","review_comments_url":"https://api.github.com/repos/boltdb/bolt/pulls/228/comments","review_comment_url":"https://api.github.com/repos/boltdb/bolt/pulls/comments/{number}","comments_url":"https://api.github.com/repos/boltdb/bolt/issues/228/comments","statuses_url":"https://api.github.com/repos/boltdb/bolt/statuses/aa66291b9b1e91773afc9c7d2081e570de742521","head":{"label":"benbjohnson:fix-large-append","ref":"fix-large-append","sha":"aa66291b9b1e91773afc9c7d2081e570de742521","user":{"login":"benbjohnson","id":118015,"avatar_url":"https://avatars.githubusercontent.com/u/118015?","gravatar_id":"6c76488dff9b5d9a872dff88f008f88e","url":"https://api.github.com/users/benbjohnson","html_url":"https://github.com/benbjohnson","followers_url":"https://api.github.com/users/benbjohnson/followers","following_url":"https://api.github.com/users/benbjohnson/following{/other_user}","gists_url":"https://api.github.com/users/benbjohnson/gists{/gist_id}","starred_url":"https://api.github.com/users/benbjohnson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benbjohnson/subscriptions","organizations_url":"https://api.github.com/users/benbjohnson/orgs","repos_url":"https://api.github.com/users/benbjohnson/repos","events_url":"https://api.github.com/users/benbjohnson/events{/privacy}","received_events_url":"https://api.github.com/users/benbjohnson/received_events","type":"User","site_admin":false},"repo":{"id":16391700,"name":"bolt","full_name":"benbjohnson/bolt","owner":{"login":"benbjohnson","id":118015,"avatar_url":"https://avatars.githubusercontent.com/u/118015?","gravatar_id":"6c76488dff9b5d9a872dff88f008f88e","url":"https://api.github.com/users/benbjohnson","html_url":"https://github.com/benbjohnson","followers_url":"https://api.github.com/users/benbjohnson/followers","following_url":"https://api.github.com/users/benbjohnson/following{/other_user}","gists_url":"https://api.github.com/users/benbjohnson/gists{/gist_id}","starred_url":"https://api.github.com/users/benbjohnson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benbjohnson/subscriptions","organizations_url":"https://api.github.com/users/benbjohnson/orgs","repos_url":"https://api.github.com/users/benbjohnson/repos","events_url":"https://api.github.com/users/benbjohnson/events{/privacy}","received_events_url":"https://api.github.com/users/benbjohnson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/benbjohnson/bolt","description":"A low-level key/value database for Go.","fork":true,"url":"https://api.github.com/repos/benbjohnson/bolt","forks_url":"https://api.github.com/repos/benbjohnson/bolt/forks","keys_url":"https://api.github.com/repos/benbjohnson/bolt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/benbjohnson/bolt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/benbjohnson/bolt/teams","hooks_url":"https://api.github.com/repos/benbjohnson/bolt/hooks","issue_events_url":"https://api.github.com/repos/benbjohnson/bolt/issues/events{/number}","events_url":"https://api.github.com/repos/benbjohnson/bolt/events","assignees_url":"https://api.github.com/repos/benbjohnson/bolt/assignees{/user}","branches_url":"https://api.github.com/repos/benbjohnson/bolt/branches{/branch}","tags_url":"https://api.github.com/repos/benbjohnson/bolt/tags","blobs_url":"https://api.github.com/repos/benbjohnson/bolt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/benbjohnson/bolt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/benbjohnson/bolt/git/refs{/sha}","trees_url":"https://api.github.com/repos/benbjohnson/bolt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/benbjohnson/bolt/statuses/{sha}","languages_url":"https://api.github.com/repos/benbjohnson/bolt/languages","stargazers_url":"https://api.github.com/repos/benbjohnson/bolt/stargazers","contributors_url":"https://api.github.com/repos/benbjohnson/bolt/contributors","subscribers_url":"https://api.github.com/repos/benbjohnson/bolt/subscribers","subscription_url":"https://api.github.com/repos/benbjohnson/bolt/subscription","commits_url":"https://api.github.com/repos/benbjohnson/bolt/commits{/sha}","git_commits_url":"https://api.github.com/repos/benbjohnson/bolt/git/commits{/sha}","comments_url":"https://api.github.com/repos/benbjohnson/bolt/comments{/number}","issue_comment_url":"https://api.github.com/repos/benbjohnson/bolt/issues/comments/{number}","contents_url":"https://api.github.com/repos/benbjohnson/bolt/contents/{+path}","compare_url":"https://api.github.com/repos/benbjohnson/bolt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/benbjohnson/bolt/merges","archive_url":"https://api.github.com/repos/benbjohnson/bolt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/benbjohnson/bolt/downloads","issues_url":"https://api.github.com/repos/benbjohnson/bolt/issues{/number}","pulls_url":"https://api.github.com/repos/benbjohnson/bolt/pulls{/number}","milestones_url":"https://api.github.com/repos/benbjohnson/bolt/milestones{/number}","notifications_url":"https://api.github.com/repos/benbjohnson/bolt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/benbjohnson/bolt/labels{/name}","releases_url":"https://api.github.com/repos/benbjohnson/bolt/releases{/id}","created_at":"2014-01-30T21:35:57Z","updated_at":"2014-06-28T03:46:10Z","pushed_at":"2014-07-23T21:11:17Z","git_url":"git://github.com/benbjohnson/bolt.git","ssh_url":"git@github.com:benbjohnson/bolt.git","clone_url":"https://github.com/benbjohnson/bolt.git","svn_url":"https://github.com/benbjohnson/bolt","homepage":null,"size":3593,"stargazers_count":7,"watchers_count":7,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":7,"default_branch":"master"}},"base":{"label":"boltdb:master","ref":"master","sha":"40adaef94e7096d0be75a80dee99492b0f563242","user":{"login":"boltdb","id":6539737,"avatar_url":"https://avatars.githubusercontent.com/u/6539737?","gravatar_id":"d4a5f1571cb895e1858d271d33a17290","url":"https://api.github.com/users/boltdb","html_url":"https://github.com/boltdb","followers_url":"https://api.github.com/users/boltdb/followers","following_url":"https://api.github.com/users/boltdb/following{/other_user}","gists_url":"https://api.github.com/users/boltdb/gists{/gist_id}","starred_url":"https://api.github.com/users/boltdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boltdb/subscriptions","organizations_url":"https://api.github.com/users/boltdb/orgs","repos_url":"https://api.github.com/users/boltdb/repos","events_url":"https://api.github.com/users/boltdb/events{/privacy}","received_events_url":"https://api.github.com/users/boltdb/received_events","type":"Organization","site_admin":false},"repo":{"id":15345331,"name":"bolt","full_name":"boltdb/bolt","owner":{"login":"boltdb","id":6539737,"avatar_url":"https://avatars.githubusercontent.com/u/6539737?","gravatar_id":"d4a5f1571cb895e1858d271d33a17290","url":"https://api.github.com/users/boltdb","html_url":"https://github.com/boltdb","followers_url":"https://api.github.com/users/boltdb/followers","following_url":"https://api.github.com/users/boltdb/following{/other_user}","gists_url":"https://api.github.com/users/boltdb/gists{/gist_id}","starred_url":"https://api.github.com/users/boltdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boltdb/subscriptions","organizations_url":"https://api.github.com/users/boltdb/orgs","repos_url":"https://api.github.com/users/boltdb/repos","events_url":"https://api.github.com/users/boltdb/events{/privacy}","received_events_url":"https://api.github.com/users/boltdb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/boltdb/bolt","description":"A low-level key/value database for Go.","fork":false,"url":"https://api.github.com/repos/boltdb/bolt","forks_url":"https://api.github.com/repos/boltdb/bolt/forks","keys_url":"https://api.github.com/repos/boltdb/bolt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/boltdb/bolt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/boltdb/bolt/teams","hooks_url":"https://api.github.com/repos/boltdb/bolt/hooks","issue_events_url":"https://api.github.com/repos/boltdb/bolt/issues/events{/number}","events_url":"https://api.github.com/repos/boltdb/bolt/events","assignees_url":"https://api.github.com/repos/boltdb/bolt/assignees{/user}","branches_url":"https://api.github.com/repos/boltdb/bolt/branches{/branch}","tags_url":"https://api.github.com/repos/boltdb/bolt/tags","blobs_url":"https://api.github.com/repos/boltdb/bolt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/boltdb/bolt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/boltdb/bolt/git/refs{/sha}","trees_url":"https://api.github.com/repos/boltdb/bolt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/boltdb/bolt/statuses/{sha}","languages_url":"https://api.github.com/repos/boltdb/bolt/languages","stargazers_url":"https://api.github.com/repos/boltdb/bolt/stargazers","contributors_url":"https://api.github.com/repos/boltdb/bolt/contributors","subscribers_url":"https://api.github.com/repos/boltdb/bolt/subscribers","subscription_url":"https://api.github.com/repos/boltdb/bolt/subscription","commits_url":"https://api.github.com/repos/boltdb/bolt/commits{/sha}","git_commits_url":"https://api.github.com/repos/boltdb/bolt/git/commits{/sha}","comments_url":"https://api.github.com/repos/boltdb/bolt/comments{/number}","issue_comment_url":"https://api.github.com/repos/boltdb/bolt/issues/comments/{number}","contents_url":"https://api.github.com/repos/boltdb/bolt/contents/{+path}","compare_url":"https://api.github.com/repos/boltdb/bolt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/boltdb/bolt/merges","archive_url":"https://api.github.com/repos/boltdb/bolt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/boltdb/bolt/downloads","issues_url":"https://api.github.com/repos/boltdb/bolt/issues{/number}","pulls_url":"https://api.github.com/repos/boltdb/bolt/pulls{/number}","milestones_url":"https://api.github.com/repos/boltdb/bolt/milestones{/number}","notifications_url":"https://api.github.com/repos/boltdb/bolt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/boltdb/bolt/labels{/name}","releases_url":"https://api.github.com/repos/boltdb/bolt/releases{/id}","created_at":"2013-12-20T18:26:14Z","updated_at":"2014-07-23T19:37:03Z","pushed_at":"2014-07-23T20:35:53Z","git_url":"git://github.com/boltdb/bolt.git","ssh_url":"git@github.com:boltdb/bolt.git","clone_url":"https://github.com/boltdb/bolt.git","svn_url":"https://github.com/boltdb/bolt","homepage":null,"size":3703,"stargazers_count":675,"watchers_count":675,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":30,"mirror_url":null,"open_issues_count":16,"forks":30,"open_issues":16,"watchers":675,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/boltdb/bolt/pulls/228"},"html":{"href":"https://github.com/boltdb/bolt/pull/228"},"issue":{"href":"https://api.github.com/repos/boltdb/bolt/issues/228"},"comments":{"href":"https://api.github.com/repos/boltdb/bolt/issues/228/comments"},"review_comments":{"href":"https://api.github.com/repos/boltdb/bolt/pulls/228/comments"},"review_comment":{"href":"https://api.github.com/repos/boltdb/bolt/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/boltdb/bolt/pulls/228/commits"},"statuses":{"href":"https://api.github.com/repos/boltdb/bolt/statuses/aa66291b9b1e91773afc9c7d2081e570de742521"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":61,"deletions":22,"changed_files":3}}