GitHub PullRequestEvent at 2014-10-14 20:08:37
Repository: Squirrel.Windows
Actor: paulcbetts
Payload: {"action":"closed","number":92,"pull_request":{"url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/pulls/92","id":22737062,"html_url":"https://github.com/Squirrel/Squirrel.Windows/pull/92","diff_url":"https://github.com/Squirrel/Squirrel.Windows/pull/92.diff","patch_url":"https://github.com/Squirrel/Squirrel.Windows/pull/92.patch","issue_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/issues/92","number":92,"state":"closed","locked":false,"title":"Restart app redux","user":{"login":"paulcbetts","id":1396,"avatar_url":"https://avatars.githubusercontent.com/u/1396?v=2","gravatar_id":"","url":"https://api.github.com/users/paulcbetts","html_url":"https://github.com/paulcbetts","followers_url":"https://api.github.com/users/paulcbetts/followers","following_url":"https://api.github.com/users/paulcbetts/following{/other_user}","gists_url":"https://api.github.com/users/paulcbetts/gists{/gist_id}","starred_url":"https://api.github.com/users/paulcbetts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulcbetts/subscriptions","organizations_url":"https://api.github.com/users/paulcbetts/orgs","repos_url":"https://api.github.com/users/paulcbetts/repos","events_url":"https://api.github.com/users/paulcbetts/events{/privacy}","received_events_url":"https://api.github.com/users/paulcbetts/received_events","type":"User","site_admin":true},"body":"This PR is a continuation of #81 that fixes up a few things:\r\n\r\n* The API on the client side is now simply `UpdateManager.RestartApp`\r\n* We now do some trickery to close the current app *before* we launch the new one - this enables Single Instance Apps to use `RestartApp` without DoS'ing themselves\r\n* We now take the EXE name instead of a full path - we do this because it Feels Bad from a security perspective to allow an open redirect, and it has the advantage of always launching the latest version (since this method will frequently be called after we run the updates and we're probably now the old version)\r\n\r\n## TODO:\r\n\r\n- [x] Make sure it works","created_at":"2014-10-14T19:37:16Z","updated_at":"2014-10-14T20:08:37Z","closed_at":"2014-10-14T20:08:37Z","merged_at":"2014-10-14T20:08:37Z","merge_commit_sha":"4f915896b597048532840624fd6796701f16c822","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/pulls/92/commits","review_comments_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/pulls/92/comments","review_comment_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/issues/92/comments","statuses_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/statuses/9481c116bbdb4b5d4190ec98d10b4a1ab2e98f46","head":{"label":"Squirrel:restart-app-redux","ref":"restart-app-redux","sha":"9481c116bbdb4b5d4190ec98d10b4a1ab2e98f46","user":{"login":"Squirrel","id":5743792,"avatar_url":"https://avatars.githubusercontent.com/u/5743792?v=2","gravatar_id":"","url":"https://api.github.com/users/Squirrel","html_url":"https://github.com/Squirrel","followers_url":"https://api.github.com/users/Squirrel/followers","following_url":"https://api.github.com/users/Squirrel/following{/other_user}","gists_url":"https://api.github.com/users/Squirrel/gists{/gist_id}","starred_url":"https://api.github.com/users/Squirrel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Squirrel/subscriptions","organizations_url":"https://api.github.com/users/Squirrel/orgs","repos_url":"https://api.github.com/users/Squirrel/repos","events_url":"https://api.github.com/users/Squirrel/events{/privacy}","received_events_url":"https://api.github.com/users/Squirrel/received_events","type":"Organization","site_admin":false},"repo":{"id":22338518,"name":"Squirrel.Windows","full_name":"Squirrel/Squirrel.Windows","owner":{"login":"Squirrel","id":5743792,"avatar_url":"https://avatars.githubusercontent.com/u/5743792?v=2","gravatar_id":"","url":"https://api.github.com/users/Squirrel","html_url":"https://github.com/Squirrel","followers_url":"https://api.github.com/users/Squirrel/followers","following_url":"https://api.github.com/users/Squirrel/following{/other_user}","gists_url":"https://api.github.com/users/Squirrel/gists{/gist_id}","starred_url":"https://api.github.com/users/Squirrel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Squirrel/subscriptions","organizations_url":"https://api.github.com/users/Squirrel/orgs","repos_url":"https://api.github.com/users/Squirrel/repos","events_url":"https://api.github.com/users/Squirrel/events{/privacy}","received_events_url":"https://api.github.com/users/Squirrel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Squirrel/Squirrel.Windows","description":"An installation and update framework for Windows desktop apps","fork":false,"url":"https://api.github.com/repos/Squirrel/Squirrel.Windows","forks_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/forks","keys_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/teams","hooks_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/hooks","issue_events_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/issues/events{/number}","events_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/events","assignees_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/assignees{/user}","branches_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/branches{/branch}","tags_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/tags","blobs_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/git/refs{/sha}","trees_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/statuses/{sha}","languages_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/languages","stargazers_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/stargazers","contributors_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/contributors","subscribers_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/subscribers","subscription_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/subscription","commits_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/commits{/sha}","git_commits_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/git/commits{/sha}","comments_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/comments{/number}","issue_comment_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/issues/comments/{number}","contents_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/contents/{+path}","compare_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/merges","archive_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/downloads","issues_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/issues{/number}","pulls_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/pulls{/number}","milestones_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/milestones{/number}","notifications_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/labels{/name}","releases_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/releases{/id}","created_at":"2014-07-28T10:10:39Z","updated_at":"2014-10-14T09:27:10Z","pushed_at":"2014-10-14T20:08:37Z","git_url":"git://github.com/Squirrel/Squirrel.Windows.git","ssh_url":"git@github.com:Squirrel/Squirrel.Windows.git","clone_url":"https://github.com/Squirrel/Squirrel.Windows.git","svn_url":"https://github.com/Squirrel/Squirrel.Windows","homepage":"","size":16587,"stargazers_count":264,"watchers_count":264,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":29,"forks":21,"open_issues":29,"watchers":264,"default_branch":"master"}},"base":{"label":"Squirrel:master","ref":"master","sha":"42c7618db935a31708608113f87e064a2a4d1359","user":{"login":"Squirrel","id":5743792,"avatar_url":"https://avatars.githubusercontent.com/u/5743792?v=2","gravatar_id":"","url":"https://api.github.com/users/Squirrel","html_url":"https://github.com/Squirrel","followers_url":"https://api.github.com/users/Squirrel/followers","following_url":"https://api.github.com/users/Squirrel/following{/other_user}","gists_url":"https://api.github.com/users/Squirrel/gists{/gist_id}","starred_url":"https://api.github.com/users/Squirrel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Squirrel/subscriptions","organizations_url":"https://api.github.com/users/Squirrel/orgs","repos_url":"https://api.github.com/users/Squirrel/repos","events_url":"https://api.github.com/users/Squirrel/events{/privacy}","received_events_url":"https://api.github.com/users/Squirrel/received_events","type":"Organization","site_admin":false},"repo":{"id":22338518,"name":"Squirrel.Windows","full_name":"Squirrel/Squirrel.Windows","owner":{"login":"Squirrel","id":5743792,"avatar_url":"https://avatars.githubusercontent.com/u/5743792?v=2","gravatar_id":"","url":"https://api.github.com/users/Squirrel","html_url":"https://github.com/Squirrel","followers_url":"https://api.github.com/users/Squirrel/followers","following_url":"https://api.github.com/users/Squirrel/following{/other_user}","gists_url":"https://api.github.com/users/Squirrel/gists{/gist_id}","starred_url":"https://api.github.com/users/Squirrel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Squirrel/subscriptions","organizations_url":"https://api.github.com/users/Squirrel/orgs","repos_url":"https://api.github.com/users/Squirrel/repos","events_url":"https://api.github.com/users/Squirrel/events{/privacy}","received_events_url":"https://api.github.com/users/Squirrel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Squirrel/Squirrel.Windows","description":"An installation and update framework for Windows desktop apps","fork":false,"url":"https://api.github.com/repos/Squirrel/Squirrel.Windows","forks_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/forks","keys_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/teams","hooks_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/hooks","issue_events_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/issues/events{/number}","events_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/events","assignees_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/assignees{/user}","branches_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/branches{/branch}","tags_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/tags","blobs_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/git/refs{/sha}","trees_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/statuses/{sha}","languages_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/languages","stargazers_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/stargazers","contributors_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/contributors","subscribers_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/subscribers","subscription_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/subscription","commits_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/commits{/sha}","git_commits_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/git/commits{/sha}","comments_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/comments{/number}","issue_comment_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/issues/comments/{number}","contents_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/contents/{+path}","compare_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/merges","archive_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/downloads","issues_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/issues{/number}","pulls_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/pulls{/number}","milestones_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/milestones{/number}","notifications_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/labels{/name}","releases_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/releases{/id}","created_at":"2014-07-28T10:10:39Z","updated_at":"2014-10-14T09:27:10Z","pushed_at":"2014-10-14T20:08:37Z","git_url":"git://github.com/Squirrel/Squirrel.Windows.git","ssh_url":"git@github.com:Squirrel/Squirrel.Windows.git","clone_url":"https://github.com/Squirrel/Squirrel.Windows.git","svn_url":"https://github.com/Squirrel/Squirrel.Windows","homepage":"","size":16587,"stargazers_count":264,"watchers_count":264,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":29,"forks":21,"open_issues":29,"watchers":264,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Squirrel/Squirrel.Windows/pulls/92"},"html":{"href":"https://github.com/Squirrel/Squirrel.Windows/pull/92"},"issue":{"href":"https://api.github.com/repos/Squirrel/Squirrel.Windows/issues/92"},"comments":{"href":"https://api.github.com/repos/Squirrel/Squirrel.Windows/issues/92/comments"},"review_comments":{"href":"https://api.github.com/repos/Squirrel/Squirrel.Windows/pulls/92/comments"},"review_comment":{"href":"https://api.github.com/repos/Squirrel/Squirrel.Windows/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Squirrel/Squirrel.Windows/pulls/92/commits"},"statuses":{"href":"https://api.github.com/repos/Squirrel/Squirrel.Windows/statuses/9481c116bbdb4b5d4190ec98d10b4a1ab2e98f46"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"paulcbetts","id":1396,"avatar_url":"https://avatars.githubusercontent.com/u/1396?v=2","gravatar_id":"","url":"https://api.github.com/users/paulcbetts","html_url":"https://github.com/paulcbetts","followers_url":"https://api.github.com/users/paulcbetts/followers","following_url":"https://api.github.com/users/paulcbetts/following{/other_user}","gists_url":"https://api.github.com/users/paulcbetts/gists{/gist_id}","starred_url":"https://api.github.com/users/paulcbetts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulcbetts/subscriptions","organizations_url":"https://api.github.com/users/paulcbetts/orgs","repos_url":"https://api.github.com/users/paulcbetts/repos","events_url":"https://api.github.com/users/paulcbetts/events{/privacy}","received_events_url":"https://api.github.com/users/paulcbetts/received_events","type":"User","site_admin":true},"comments":0,"review_comments":0,"commits":21,"additions":267,"deletions":31,"changed_files":4}}