GitHub PushEvent at 2014-11-12 16:33:43
Repository: rust
Actor: alexcrichton
Payload: {"shas":[["e15a3903e00a3fdb5c2071ac4e72c2e8d5965def","5fc431c1e0f17b94f8fc43fe754260d1ed487491@gmail.com","Rename deprecated EnumSet methods in unit tests.","Joseph Crail",true],["3d9a346aa3ed6fc30e34bd7124e20e77c66cbcb0","a373aebbb196978f07557ccd68fbf6621f66ef98@gmail.com","As of 4.9.2, gcc started passing -fno-lto to collect2, or to ld if collect2 cannot be found.  The latter is the case for our bundles, because we don't include collect2.  Unfortunately, ld does not understand this option and errors out.\nOn the bright side, -fno-use-linker-plugin still works to suppress gcc's LTO, so we can drop -fno-lto.","Vadim Chugunov",true],["5cd4862c69fe6c27010c792aef6cfa053e56c137","a373aebbb196978f07557ccd68fbf6621f66ef98@gmail.com","Move gcc back to rustlib\\<triple>\\bin","Vadim Chugunov",true],["ad777778d4074a48dbd9fcbcbf6eecce7344db1a","a373aebbb196978f07557ccd68fbf6621f66ef98@gmail.com","Prefer bundled linker.","Vadim Chugunov",true],["cb2328f839d3338629ea25e9585074ca2fe2e856","a373aebbb196978f07557ccd68fbf6621f66ef98@gmail.com","Include some of the more popular Windows import libs into the bundle.","Vadim Chugunov",true],["fb4e618c33789da31614d1d92b7c760df5db426b","4391d9f43454342dfea80b23a3abbf3dfbd0293e@gmail.com","Fix upvars sometimes not being marked as used mutably\n\nDrill down the loan path for McDeclared references as well since\nit might lead to an upvar.  Closes #18769","Brian Koropoff",true],["c0a7d557dbea830ae581ecb3f77f08b7e4daad4a","4391d9f43454342dfea80b23a3abbf3dfbd0293e@gmail.com","Update test to cover #18769","Brian Koropoff",true],["477155e638d0a2bddf951ca4a2e24f797ba304bf","673994c30c82a04f471d07d919952b8432272893@gmail.com","Add Encodable and Decodable for VecMap","Colin Sherratt",true],["85f1262c180c86e24cc957e4e9e337baa45b581a","d8304a100f9eb6d8398a1b27f47b5aa4c1c0b0be@gmail.com","Use FnvHashMap instead of HashMap in rustc","Ariel Ben-Yehuda",true],["2df9a085bd904dae7786a6c5d30e4a4057a16f22","894717d2ac2648d0110a2992283706676eed355a@gmail.com","Rogue 'panic' -> 'fail' in guide.\n\nShould refer to handling panicking tasks like any other computation\r\nthat may _fail_, not any other computation that may _panic_.","Jeff Parsons",true],["37afc528eacf4a0a874f8e97f6e7d4d7b63e8ac6","903817dace3a69d815606c577db89775e2c7670b@gmail.com","Document ast::Ty_","Manish Goregaokar",true],["a30b72bb1420620d5b36dbd221a81374d3668271","3a2c29237f73c7cf88424b80e427b1884f346b35@rust-lang.org","auto merge of #18802 : bkoropoff/rust/issue-18769, r=luqmana\n\nDrill down the loan path for `McDeclared` references as well since it might lead to an upvar.  Closes #18769","bors",true],["f54f8b3c29c8e49da095c741e9f89297b24ec09d","191be3715bae070c2198402843567588417de697@ebfe.org","Fix 'renamed lint' warnings","Michael Gehring",true],["f52e2bd32fee91aab56ed44abac3719ece3d69fd","f973abbf0a19f8166c601c53f9d7a897742d9b94@gmail.com","Implement collection views API for TrieMap.","Michael Sproul",true],["f89e975685a3a9f258c996865cdd144a0f30f83c","3a2c29237f73c7cf88424b80e427b1884f346b35@rust-lang.org","auto merge of #18287 : michaelsproul/rust/triemap-collection-views, r=bstrie\n\nI've implemented the new collection views API for TrieMap. I more or less followed the approach set out by @Gankro in BTreeMap, by using a `SearchStack`. There's quite a bit of unsafe code, but I've wrapped it safely where I think is appropriate. I've added tests to ensure everything works, and performance seems quite good.\r\n\r\n```\r\ntest trie::bench_map::bench_find                           ... bench:     67879 ns/iter (+/- 4192)\r\ntest trie::bench_map::bench_find_entry                     ... bench:    186814 ns/iter (+/- 18748)\r\ntest trie::bench_map::bench_insert_large                   ... bench:    716612 ns/iter (+/- 160121)\r\ntest trie::bench_map::bench_insert_large_entry             ... bench:    851219 ns/iter (+/- 20331)\r\ntest trie::bench_map::bench_remove                         ... bench:    838856 ns/iter (+/- 27998)\r\ntest trie::bench_map::bench_remove_entry                   ... bench:    981711 ns/iter (+/- 53046)\r\n```\r\n\r\nUsing an entry is slow compared to a plain find, but is only ~15% slower for inserts and removes, which is where this API is most useful. I'm tempted to remove the standalone `remove` function in favour of an entry-based approach (to cut down on complexity).\r\n\r\nI've added some more comments to the general part of the code-base, which will hopefully help the next person looking over this. I moved the three key structures to the top of the file so that the nesting structure is clearly visible, and renamed `Child<T>` to `TrieNode<T>` and `TrieNode<T>` to `InternalNode<T>` to improve clarity. If these changes are creeping, I'm happy to revert them.\r\n\r\nLet me know if my use of `fail!` is ok, I was a little unsure of how specific to be. Some of the data-structures have various invariants that shouldn't be broken, so using `fail!` seemed appropriate.\r\n\r\n## Still to do\r\n\r\n* Modernise iterators (make them double-ended).\r\n* Make the keys generic, or rename this data-structure (see: https://github.com/rust-lang/rust/issues/14902).\r\n* Possibly move this code out of libcollections. [Searching Github for TrieMap turns up very few real results.][triemap-search]\r\n\r\nRelated issues: https://github.com/rust-lang/rust/issues/18009 and https://github.com/rust-lang/rust/issues/17320\r\n\r\n[triemap-search]: https://github.com/search?utf8=%E2%9C%93&q=TrieMap+language%3ARust&type=Code&ref=searchresults","bors",true],["c254957078207047a224d6e16c46ff53299bfd78","1679cd7cc913b595943ed55f23d09b1d36a05d70@gmail.com","Attempt to fix the problem with failing distcheck.","Vitali Haravy",true],["e94912aa853caff4b61bc08b7e3f574660673adc","b088574b93e687e020c008c16a9e3c994038e27d@gmail.com","vim: move 'move' to rustStorage","Josh Stone",true],["cd17ba4c1236af71594291646b586b1bc0b415d9","28efa798da98745d6a98078b320edd33f229eda6@gmail.com","note the intent of reforming task spawning","Daniel Micay",true],["7c36336c6f94d49bdfdf5cbf0c09e353c79534a4","a6cc2cef7d25f27847876bdb81651755fcebacf0@mozilla.com","mk: Fix configuration of version commit information\n\nCommit bec2ee77f78b4bb8a503101091272a634a273a1c started quoting paths\ndiscovered as part of the `probe` function, which includes git.  The\n`make` `wildcard` function appears to be incompatible with quoted\npaths so this check in the makefile now fails. Employing `wildcard`\nhere appears to only re-verify that git actually exists, which the\nconfigure script already did, so I've just removed it.\n\nAdditionally, with the quoted paths the `subst` function should no\nlonger be needed, so I've removed it as well.\n\nCloses #18771","Brian Anderson",true],["40fb87d40f681f5356af42175fc7b85da387f037","3a2c29237f73c7cf88424b80e427b1884f346b35@rust-lang.org","auto merge of #18857 : brson/rust/winescapefixes, r=alexcrichton","bors",true]],"size":36,"ref":"refs/heads/remove-time","head":"4f63687571b325931d7143abb4964db2874603f6"}