GitHub PullRequestReviewCommentEvent at 2014-09-08 20:40:26
Repository: kubernetes
Actor: erictune
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/17265354","id":17265354,"diff_hunk":"@@ -19,68 +22,59 @@ name\n [rfc4122](http://www.ietf.org/rfc/rfc4122.txt) universally unique identifier (UUID)\n : A 128 bit generated value that is extremely unlikely to collide across time and space and requires no central coordination\n \n+\n ## Objectives for names and identifiers\n \n-1) Uniquely identify an instance of a pod on the apiserver and on the kubelet\n+1) Uniquely identify an instance of a pod\n \n-2) Uniquely identify an instance of a container within a pod on the apiserver and on the kubelet\n+2) Uniquely identify a container within a pod\n \n-3) Uniquely identify a single execution of a container in time for logging or reporting\n+3) Uniquely identify a single execution of a container\n \n 4) The structure of a pod specification should stay largely the same throughout the entire system\n \n-5) Provide human-friendly, memorable, semantically meaningful, short-ish references in container and pod operations\n+5) Provide human-friendly, memorable, semantically meaningful, names in the API\n \n-6) Provide predictable container and pod references in operations and/or configuration files\n+6) Provide predictable container and pod names in operations and/or configuration files\n \n 7) Allow idempotent creation of API resources (#148)\n \n-8) Allow DNS names to be automatically generated for individual containers or pods (#146)\n-\n \n ## Design\n \n-1) Each apiserver has a Namespace string (a DNS_SUBDOMAIN) that is unique across all apiservers that share its configured minions.\n+1) Each apiserver must be assigned a Namespace string (a DNS_SUBDOMAIN).\n+   1) must be non-empty and unique across all apiservers that share minions\n    Example: \"k8s.example.com\"\n \n-2) Each pod instance on an apiserver has a PodName string (a DNS_SUBDOMAIN) which is and unique within the Namespace.\n-   1) If not specified by the client, the apiserver will assign this identifier\n+2) When a pod is created on an apiserver, a Name string (a DNS_SUBDOMAIN) must be provided.\n+   1) must be non-empty and unique within the apiserver's Namespace\n+   2) provides idempotent creation","path":"docs/identifiers.md","position":59,"original_position":59,"commit_id":"cee117b161af25cccf42b19619b58c7bb98553fa","original_commit_id":"4fbc45457c9a9696020a73ba2c82d64f65dfca5a","user":{"login":"erictune","id":8105590,"avatar_url":"https://avatars.githubusercontent.com/u/8105590?v=2","gravatar_id":"dc5a6e8761e435823171e2d7654a349c","url":"https://api.github.com/users/erictune","html_url":"https://github.com/erictune","followers_url":"https://api.github.com/users/erictune/followers","following_url":"https://api.github.com/users/erictune/following{/other_user}","gists_url":"https://api.github.com/users/erictune/gists{/gist_id}","starred_url":"https://api.github.com/users/erictune/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erictune/subscriptions","organizations_url":"https://api.github.com/users/erictune/orgs","repos_url":"https://api.github.com/users/erictune/repos","events_url":"https://api.github.com/users/erictune/events{/privacy}","received_events_url":"https://api.github.com/users/erictune/received_events","type":"User","site_admin":false},"body":"Clarify that idempotence requires client cooperation, and is thus \"optional\".  Also call out two different cases? \r\n\r\n2) Server-enforced uniqueness property may be used by clients to avoid duplicate object creation in the presence of:\r\na)  multiple uncoordinated clients,\r\nb) a single client which crashes before receiving confirmation of object creation.\r\n ","created_at":"2014-09-08T20:40:26Z","updated_at":"2014-09-08T20:40:26Z","html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/1213#discussion_r17265354","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/1213","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/17265354"},"html":{"href":"https://github.com/GoogleCloudPlatform/kubernetes/pull/1213#discussion_r17265354"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/1213"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/1213","id":20913738,"html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/1213","diff_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/1213.diff","patch_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/1213.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/1213","number":1213,"state":"open","locked":false,"title":"Revisit identifiers spec","user":{"login":"thockin","id":5595220,"avatar_url":"https://avatars.githubusercontent.com/u/5595220?v=2","gravatar_id":"6ae5ac8e0b7147021a4eaa2b9535f58d","url":"https://api.github.com/users/thockin","html_url":"https://github.com/thockin","followers_url":"https://api.github.com/users/thockin/followers","following_url":"https://api.github.com/users/thockin/following{/other_user}","gists_url":"https://api.github.com/users/thockin/gists{/gist_id}","starred_url":"https://api.github.com/users/thockin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thockin/subscriptions","organizations_url":"https://api.github.com/users/thockin/orgs","repos_url":"https://api.github.com/users/thockin/repos","events_url":"https://api.github.com/users/thockin/events{/privacy}","received_events_url":"https://api.github.com/users/thockin/received_events","type":"User","site_admin":false},"body":"Partially addresses #1135.\r\n\r\nThis is the result of discussions in the past few days about imprecision and confusion.  Hopefully simpler.  There are a few FIXME comments in the doc - discuss.","created_at":"2014-09-08T20:00:24Z","updated_at":"2014-09-08T20:40:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"82b2e69300f84267dd5f0ba2fc13a5a5509a7358","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/1213/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/1213/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/{number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/1213/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/cee117b161af25cccf42b19619b58c7bb98553fa","head":{"label":"thockin:ident","ref":"ident","sha":"cee117b161af25cccf42b19619b58c7bb98553fa","user":{"login":"thockin","id":5595220,"avatar_url":"https://avatars.githubusercontent.com/u/5595220?v=2","gravatar_id":"6ae5ac8e0b7147021a4eaa2b9535f58d","url":"https://api.github.com/users/thockin","html_url":"https://github.com/thockin","followers_url":"https://api.github.com/users/thockin/followers","following_url":"https://api.github.com/users/thockin/following{/other_user}","gists_url":"https://api.github.com/users/thockin/gists{/gist_id}","starred_url":"https://api.github.com/users/thockin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thockin/subscriptions","organizations_url":"https://api.github.com/users/thockin/orgs","repos_url":"https://api.github.com/users/thockin/repos","events_url":"https://api.github.com/users/thockin/events{/privacy}","received_events_url":"https://api.github.com/users/thockin/received_events","type":"User","site_admin":false},"repo":{"id":21042716,"name":"kubernetes","full_name":"thockin/kubernetes","owner":{"login":"thockin","id":5595220,"avatar_url":"https://avatars.githubusercontent.com/u/5595220?v=2","gravatar_id":"6ae5ac8e0b7147021a4eaa2b9535f58d","url":"https://api.github.com/users/thockin","html_url":"https://github.com/thockin","followers_url":"https://api.github.com/users/thockin/followers","following_url":"https://api.github.com/users/thockin/following{/other_user}","gists_url":"https://api.github.com/users/thockin/gists{/gist_id}","starred_url":"https://api.github.com/users/thockin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thockin/subscriptions","organizations_url":"https://api.github.com/users/thockin/orgs","repos_url":"https://api.github.com/users/thockin/repos","events_url":"https://api.github.com/users/thockin/events{/privacy}","received_events_url":"https://api.github.com/users/thockin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/thockin/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/thockin/kubernetes","forks_url":"https://api.github.com/repos/thockin/kubernetes/forks","keys_url":"https://api.github.com/repos/thockin/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thockin/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thockin/kubernetes/teams","hooks_url":"https://api.github.com/repos/thockin/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/thockin/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/thockin/kubernetes/events","assignees_url":"https://api.github.com/repos/thockin/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/thockin/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/thockin/kubernetes/tags","blobs_url":"https://api.github.com/repos/thockin/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thockin/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thockin/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/thockin/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thockin/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/thockin/kubernetes/languages","stargazers_url":"https://api.github.com/repos/thockin/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/thockin/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/thockin/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/thockin/kubernetes/subscription","commits_url":"https://api.github.com/repos/thockin/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/thockin/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/thockin/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/thockin/kubernetes/issues/comments/{number}","contents_url":"https://api.github.com/repos/thockin/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/thockin/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thockin/kubernetes/merges","archive_url":"https://api.github.com/repos/thockin/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thockin/kubernetes/downloads","issues_url":"https://api.github.com/repos/thockin/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/thockin/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/thockin/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/thockin/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thockin/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/thockin/kubernetes/releases{/id}","created_at":"2014-06-20T15:30:28Z","updated_at":"2014-08-12T04:29:18Z","pushed_at":"2014-09-08T20:29:18Z","git_url":"git://github.com/thockin/kubernetes.git","ssh_url":"git@github.com:thockin/kubernetes.git","clone_url":"https://github.com/thockin/kubernetes.git","svn_url":"https://github.com/thockin/kubernetes","homepage":null,"size":10479,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"2221d33de1cf1be96e068913002f3350d84c0bd6","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=2","gravatar_id":"3db02c6238c8b1fb844871330744ec5d","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"GoogleCloudPlatform/kubernetes","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=2","gravatar_id":"3db02c6238c8b1fb844871330744ec5d","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/kubernetes","description":"Container Cluster Manager","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/comments/{number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/releases{/id}","created_at":"2014-06-06T22:56:04Z","updated_at":"2014-09-08T20:33:14Z","pushed_at":"2014-09-08T20:05:59Z","git_url":"git://github.com/GoogleCloudPlatform/kubernetes.git","ssh_url":"git@github.com:GoogleCloudPlatform/kubernetes.git","clone_url":"https://github.com/GoogleCloudPlatform/kubernetes.git","svn_url":"https://github.com/GoogleCloudPlatform/kubernetes","homepage":null,"size":27892,"stargazers_count":3446,"watchers_count":3446,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":461,"mirror_url":null,"open_issues_count":182,"forks":461,"open_issues":182,"watchers":3446,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/1213"},"html":{"href":"https://github.com/GoogleCloudPlatform/kubernetes/pull/1213"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/1213"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/1213/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/1213/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/1213/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/cee117b161af25cccf42b19619b58c7bb98553fa"}}}}