GitHub PullRequestReviewCommentEvent at 2014-12-29 21:51:24
Repository: graph_reference
Actor: mkcor
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/plotly/graph_reference/pulls/comments/22330403","id":22330403,"diff_hunk":"@@ -3288,6 +3288,15 @@\n                 \"examples\": [], \n                 \"description\": \"Sets the camera position with respect to the scene. The first entry (a generic vector (list) or atomic vector of length 4) sets the angular position of the camera. The second entry (a generic vector (list) or atomic vector of length 3) sets the (x,y,z) translation of the camera. The third entry (a scalar) sets zoom of the camera.\"\n             }, \n+            \"domain\": {\n+                \"key_type\": \"plot_info\", \n+                \"val_types\": \"domain list\", \n+                \"required\": false, \n+                \"examples\": [\n+                    \"list(x = c(0, 0.4), y = c(0.6, 1))\"","path":"graph_objs/r/graph_objs_meta.json","position":9,"original_position":9,"commit_id":"92f15bdbcee9b96cf3b8789bb0a14fbb1f4cf10e","original_commit_id":"92f15bdbcee9b96cf3b8789bb0a14fbb1f4cf10e","user":{"login":"mkcor","id":2227806,"avatar_url":"https://avatars.githubusercontent.com/u/2227806?v=3","gravatar_id":"","url":"https://api.github.com/users/mkcor","html_url":"https://github.com/mkcor","followers_url":"https://api.github.com/users/mkcor/followers","following_url":"https://api.github.com/users/mkcor/following{/other_user}","gists_url":"https://api.github.com/users/mkcor/gists{/gist_id}","starred_url":"https://api.github.com/users/mkcor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkcor/subscriptions","organizations_url":"https://api.github.com/users/mkcor/orgs","repos_url":"https://api.github.com/users/mkcor/repos","events_url":"https://api.github.com/users/mkcor/events{/privacy}","received_events_url":"https://api.github.com/users/mkcor/received_events","type":"User","site_admin":false},"body":"@etpinard Yes, it is! :)","created_at":"2014-12-29T21:51:24Z","updated_at":"2014-12-29T21:51:24Z","html_url":"https://github.com/plotly/graph_reference/pull/31#discussion_r22330403","pull_request_url":"https://api.github.com/repos/plotly/graph_reference/pulls/31","_links":{"self":{"href":"https://api.github.com/repos/plotly/graph_reference/pulls/comments/22330403"},"html":{"href":"https://github.com/plotly/graph_reference/pull/31#discussion_r22330403"},"pull_request":{"href":"https://api.github.com/repos/plotly/graph_reference/pulls/31"}}},"pull_request":{"url":"https://api.github.com/repos/plotly/graph_reference/pulls/31","id":26662220,"html_url":"https://github.com/plotly/graph_reference/pull/31","diff_url":"https://github.com/plotly/graph_reference/pull/31.diff","patch_url":"https://github.com/plotly/graph_reference/pull/31.patch","issue_url":"https://api.github.com/repos/plotly/graph_reference/issues/31","number":31,"state":"open","locked":false,"title":"Add scene domain","user":{"login":"etpinard","id":6675409,"avatar_url":"https://avatars.githubusercontent.com/u/6675409?v=3","gravatar_id":"","url":"https://api.github.com/users/etpinard","html_url":"https://github.com/etpinard","followers_url":"https://api.github.com/users/etpinard/followers","following_url":"https://api.github.com/users/etpinard/following{/other_user}","gists_url":"https://api.github.com/users/etpinard/gists{/gist_id}","starred_url":"https://api.github.com/users/etpinard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etpinard/subscriptions","organizations_url":"https://api.github.com/users/etpinard/orgs","repos_url":"https://api.github.com/users/etpinard/repos","events_url":"https://api.github.com/users/etpinard/events{/privacy}","received_events_url":"https://api.github.com/users/etpinard/received_events","type":"User","site_admin":false},"body":"cc @theengineear @chriddyp \r\n\r\n`'scene.domain'` wasn't in graph ref for some reason.\r\n\r\n","created_at":"2014-12-29T21:18:39Z","updated_at":"2014-12-29T21:51:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3793b465265c2be930262fb79d34ab8e59e6f0eb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/plotly/graph_reference/pulls/31/commits","review_comments_url":"https://api.github.com/repos/plotly/graph_reference/pulls/31/comments","review_comment_url":"https://api.github.com/repos/plotly/graph_reference/pulls/comments/{number}","comments_url":"https://api.github.com/repos/plotly/graph_reference/issues/31/comments","statuses_url":"https://api.github.com/repos/plotly/graph_reference/statuses/92f15bdbcee9b96cf3b8789bb0a14fbb1f4cf10e","head":{"label":"plotly:add-scene-domain","ref":"add-scene-domain","sha":"92f15bdbcee9b96cf3b8789bb0a14fbb1f4cf10e","user":{"login":"plotly","id":5997976,"avatar_url":"https://avatars.githubusercontent.com/u/5997976?v=3","gravatar_id":"","url":"https://api.github.com/users/plotly","html_url":"https://github.com/plotly","followers_url":"https://api.github.com/users/plotly/followers","following_url":"https://api.github.com/users/plotly/following{/other_user}","gists_url":"https://api.github.com/users/plotly/gists{/gist_id}","starred_url":"https://api.github.com/users/plotly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plotly/subscriptions","organizations_url":"https://api.github.com/users/plotly/orgs","repos_url":"https://api.github.com/users/plotly/repos","events_url":"https://api.github.com/users/plotly/events{/privacy}","received_events_url":"https://api.github.com/users/plotly/received_events","type":"Organization","site_admin":false},"repo":{"id":18475785,"name":"graph_reference","full_name":"plotly/graph_reference","owner":{"login":"plotly","id":5997976,"avatar_url":"https://avatars.githubusercontent.com/u/5997976?v=3","gravatar_id":"","url":"https://api.github.com/users/plotly","html_url":"https://github.com/plotly","followers_url":"https://api.github.com/users/plotly/followers","following_url":"https://api.github.com/users/plotly/following{/other_user}","gists_url":"https://api.github.com/users/plotly/gists{/gist_id}","starred_url":"https://api.github.com/users/plotly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plotly/subscriptions","organizations_url":"https://api.github.com/users/plotly/orgs","repos_url":"https://api.github.com/users/plotly/repos","events_url":"https://api.github.com/users/plotly/events{/privacy}","received_events_url":"https://api.github.com/users/plotly/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/plotly/graph_reference","description":"","fork":false,"url":"https://api.github.com/repos/plotly/graph_reference","forks_url":"https://api.github.com/repos/plotly/graph_reference/forks","keys_url":"https://api.github.com/repos/plotly/graph_reference/keys{/key_id}","collaborators_url":"https://api.github.com/repos/plotly/graph_reference/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/plotly/graph_reference/teams","hooks_url":"https://api.github.com/repos/plotly/graph_reference/hooks","issue_events_url":"https://api.github.com/repos/plotly/graph_reference/issues/events{/number}","events_url":"https://api.github.com/repos/plotly/graph_reference/events","assignees_url":"https://api.github.com/repos/plotly/graph_reference/assignees{/user}","branches_url":"https://api.github.com/repos/plotly/graph_reference/branches{/branch}","tags_url":"https://api.github.com/repos/plotly/graph_reference/tags","blobs_url":"https://api.github.com/repos/plotly/graph_reference/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/plotly/graph_reference/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/plotly/graph_reference/git/refs{/sha}","trees_url":"https://api.github.com/repos/plotly/graph_reference/git/trees{/sha}","statuses_url":"https://api.github.com/repos/plotly/graph_reference/statuses/{sha}","languages_url":"https://api.github.com/repos/plotly/graph_reference/languages","stargazers_url":"https://api.github.com/repos/plotly/graph_reference/stargazers","contributors_url":"https://api.github.com/repos/plotly/graph_reference/contributors","subscribers_url":"https://api.github.com/repos/plotly/graph_reference/subscribers","subscription_url":"https://api.github.com/repos/plotly/graph_reference/subscription","commits_url":"https://api.github.com/repos/plotly/graph_reference/commits{/sha}","git_commits_url":"https://api.github.com/repos/plotly/graph_reference/git/commits{/sha}","comments_url":"https://api.github.com/repos/plotly/graph_reference/comments{/number}","issue_comment_url":"https://api.github.com/repos/plotly/graph_reference/issues/comments/{number}","contents_url":"https://api.github.com/repos/plotly/graph_reference/contents/{+path}","compare_url":"https://api.github.com/repos/plotly/graph_reference/compare/{base}...{head}","merges_url":"https://api.github.com/repos/plotly/graph_reference/merges","archive_url":"https://api.github.com/repos/plotly/graph_reference/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/plotly/graph_reference/downloads","issues_url":"https://api.github.com/repos/plotly/graph_reference/issues{/number}","pulls_url":"https://api.github.com/repos/plotly/graph_reference/pulls{/number}","milestones_url":"https://api.github.com/repos/plotly/graph_reference/milestones{/number}","notifications_url":"https://api.github.com/repos/plotly/graph_reference/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/plotly/graph_reference/labels{/name}","releases_url":"https://api.github.com/repos/plotly/graph_reference/releases{/id}","created_at":"2014-04-05T20:21:05Z","updated_at":"2014-12-22T17:33:10Z","pushed_at":"2014-12-29T21:17:42Z","git_url":"git://github.com/plotly/graph_reference.git","ssh_url":"git@github.com:plotly/graph_reference.git","clone_url":"https://github.com/plotly/graph_reference.git","svn_url":"https://github.com/plotly/graph_reference","homepage":null,"size":3040,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":2,"default_branch":"master"}},"base":{"label":"plotly:master","ref":"master","sha":"9d31f815edc59bbf1a9533e241cc4f41ed859fdc","user":{"login":"plotly","id":5997976,"avatar_url":"https://avatars.githubusercontent.com/u/5997976?v=3","gravatar_id":"","url":"https://api.github.com/users/plotly","html_url":"https://github.com/plotly","followers_url":"https://api.github.com/users/plotly/followers","following_url":"https://api.github.com/users/plotly/following{/other_user}","gists_url":"https://api.github.com/users/plotly/gists{/gist_id}","starred_url":"https://api.github.com/users/plotly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plotly/subscriptions","organizations_url":"https://api.github.com/users/plotly/orgs","repos_url":"https://api.github.com/users/plotly/repos","events_url":"https://api.github.com/users/plotly/events{/privacy}","received_events_url":"https://api.github.com/users/plotly/received_events","type":"Organization","site_admin":false},"repo":{"id":18475785,"name":"graph_reference","full_name":"plotly/graph_reference","owner":{"login":"plotly","id":5997976,"avatar_url":"https://avatars.githubusercontent.com/u/5997976?v=3","gravatar_id":"","url":"https://api.github.com/users/plotly","html_url":"https://github.com/plotly","followers_url":"https://api.github.com/users/plotly/followers","following_url":"https://api.github.com/users/plotly/following{/other_user}","gists_url":"https://api.github.com/users/plotly/gists{/gist_id}","starred_url":"https://api.github.com/users/plotly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plotly/subscriptions","organizations_url":"https://api.github.com/users/plotly/orgs","repos_url":"https://api.github.com/users/plotly/repos","events_url":"https://api.github.com/users/plotly/events{/privacy}","received_events_url":"https://api.github.com/users/plotly/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/plotly/graph_reference","description":"","fork":false,"url":"https://api.github.com/repos/plotly/graph_reference","forks_url":"https://api.github.com/repos/plotly/graph_reference/forks","keys_url":"https://api.github.com/repos/plotly/graph_reference/keys{/key_id}","collaborators_url":"https://api.github.com/repos/plotly/graph_reference/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/plotly/graph_reference/teams","hooks_url":"https://api.github.com/repos/plotly/graph_reference/hooks","issue_events_url":"https://api.github.com/repos/plotly/graph_reference/issues/events{/number}","events_url":"https://api.github.com/repos/plotly/graph_reference/events","assignees_url":"https://api.github.com/repos/plotly/graph_reference/assignees{/user}","branches_url":"https://api.github.com/repos/plotly/graph_reference/branches{/branch}","tags_url":"https://api.github.com/repos/plotly/graph_reference/tags","blobs_url":"https://api.github.com/repos/plotly/graph_reference/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/plotly/graph_reference/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/plotly/graph_reference/git/refs{/sha}","trees_url":"https://api.github.com/repos/plotly/graph_reference/git/trees{/sha}","statuses_url":"https://api.github.com/repos/plotly/graph_reference/statuses/{sha}","languages_url":"https://api.github.com/repos/plotly/graph_reference/languages","stargazers_url":"https://api.github.com/repos/plotly/graph_reference/stargazers","contributors_url":"https://api.github.com/repos/plotly/graph_reference/contributors","subscribers_url":"https://api.github.com/repos/plotly/graph_reference/subscribers","subscription_url":"https://api.github.com/repos/plotly/graph_reference/subscription","commits_url":"https://api.github.com/repos/plotly/graph_reference/commits{/sha}","git_commits_url":"https://api.github.com/repos/plotly/graph_reference/git/commits{/sha}","comments_url":"https://api.github.com/repos/plotly/graph_reference/comments{/number}","issue_comment_url":"https://api.github.com/repos/plotly/graph_reference/issues/comments/{number}","contents_url":"https://api.github.com/repos/plotly/graph_reference/contents/{+path}","compare_url":"https://api.github.com/repos/plotly/graph_reference/compare/{base}...{head}","merges_url":"https://api.github.com/repos/plotly/graph_reference/merges","archive_url":"https://api.github.com/repos/plotly/graph_reference/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/plotly/graph_reference/downloads","issues_url":"https://api.github.com/repos/plotly/graph_reference/issues{/number}","pulls_url":"https://api.github.com/repos/plotly/graph_reference/pulls{/number}","milestones_url":"https://api.github.com/repos/plotly/graph_reference/milestones{/number}","notifications_url":"https://api.github.com/repos/plotly/graph_reference/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/plotly/graph_reference/labels{/name}","releases_url":"https://api.github.com/repos/plotly/graph_reference/releases{/id}","created_at":"2014-04-05T20:21:05Z","updated_at":"2014-12-22T17:33:10Z","pushed_at":"2014-12-29T21:17:42Z","git_url":"git://github.com/plotly/graph_reference.git","ssh_url":"git@github.com:plotly/graph_reference.git","clone_url":"https://github.com/plotly/graph_reference.git","svn_url":"https://github.com/plotly/graph_reference","homepage":null,"size":3040,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/plotly/graph_reference/pulls/31"},"html":{"href":"https://github.com/plotly/graph_reference/pull/31"},"issue":{"href":"https://api.github.com/repos/plotly/graph_reference/issues/31"},"comments":{"href":"https://api.github.com/repos/plotly/graph_reference/issues/31/comments"},"review_comments":{"href":"https://api.github.com/repos/plotly/graph_reference/pulls/31/comments"},"review_comment":{"href":"https://api.github.com/repos/plotly/graph_reference/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/plotly/graph_reference/pulls/31/commits"},"statuses":{"href":"https://api.github.com/repos/plotly/graph_reference/statuses/92f15bdbcee9b96cf3b8789bb0a14fbb1f4cf10e"}}}}