GitHub PullRequestReviewCommentEvent at 2014-03-17 17:26:17
Repository: gaia
Actor: davidflanagan
Payload: {"comment":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/10667582","id":10667582,"diff_hunk":"@@ -171,29 +213,41 @@ module.exports = {\n     ],\n     persistent: true\n   },\n-\n+  \n   timer: {\n     icon: 'icon-self-timer',\n     options: [\n       {\n         key: 'off',\n-        title: 'Off',\n-        value: 0\n+        value: 0,\n+        l10n: {\n+          title: 'off',\n+          notificationID: 'timer-set-off'","path":"apps/camera/js/config/app.js","position":65,"original_position":65,"commit_id":"ef94af37ad60464d4328503cc89e7430aaa5e05d","original_commit_id":"ef94af37ad60464d4328503cc89e7430aaa5e05d","user":{"login":"davidflanagan","id":516914,"avatar_url":"https://gravatar.com/avatar/a7cc58f54d25826ac0568490237b959d?d=https%3A%2F%2Fidenticons.github.com%2Ffc33a4fde85f61d1824a28eafc9ba13c.png&r=x","gravatar_id":"a7cc58f54d25826ac0568490237b959d","url":"https://api.github.com/users/davidflanagan","html_url":"https://github.com/davidflanagan","followers_url":"https://api.github.com/users/davidflanagan/followers","following_url":"https://api.github.com/users/davidflanagan/following{/other_user}","gists_url":"https://api.github.com/users/davidflanagan/gists{/gist_id}","starred_url":"https://api.github.com/users/davidflanagan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidflanagan/subscriptions","organizations_url":"https://api.github.com/users/davidflanagan/orgs","repos_url":"https://api.github.com/users/davidflanagan/repos","events_url":"https://api.github.com/users/davidflanagan/events{/privacy}","received_events_url":"https://api.github.com/users/davidflanagan/received_events","type":"User","site_admin":false},"body":"@wilsonpage I asked Ashish to use notificationID. \r\nAll of the notification code is in a separate PR on a separate bug, and I have reviewed it there.\r\nIn that other review I've pointed out that notificationID should not be in the l10n object since localization is being handled in the notification view.","created_at":"2014-03-17T17:26:17Z","updated_at":"2014-03-17T17:26:17Z","html_url":"https://github.com/mozilla-b2g/gaia/pull/17077#discussion_r10667582","pull_request_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/17077","_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/10667582"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/17077#discussion_r10667582"},"pull_request":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/17077"}}}}