GitHub PullRequestReviewCommentEvent at 2014-05-30 14:26:23
Repository: U1DB-ZeroMQ-Transport
Actor: andrejb
Payload: {"comment":{"url":"https://api.github.com/repos/andrejb/U1DB-ZeroMQ-Transport/pulls/comments/13230890","id":13230890,"diff_hunk":"@@ -3,44 +3,118 @@\n \n # Local Imports\n import settings\n+from keyvaluemsg import KeyValueMsg\n+\n+\n+class ClientSocket(object):\n+    \"\"\"\n+    Base class for sockets at the client.\n+    \"\"\"\n+    def __init__(self, socket, endpoint):\n+        self.socket = socket\n+        self.socket.setsockopt(zmq.RCVTIMEO, 10)","path":"src/client.py","position":13,"original_position":13,"commit_id":"75c4f8327aa4a758161ecc7b73d9268c1822075e","original_commit_id":"75c4f8327aa4a758161ecc7b73d9268c1822075e","user":{"login":"andrejb","id":79672,"avatar_url":"https://avatars.githubusercontent.com/u/79672?","gravatar_id":"9ad5f9cdfcb6ca5721c8b890ac459428","url":"https://api.github.com/users/andrejb","html_url":"https://github.com/andrejb","followers_url":"https://api.github.com/users/andrejb/followers","following_url":"https://api.github.com/users/andrejb/following{/other_user}","gists_url":"https://api.github.com/users/andrejb/gists{/gist_id}","starred_url":"https://api.github.com/users/andrejb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrejb/subscriptions","organizations_url":"https://api.github.com/users/andrejb/orgs","repos_url":"https://api.github.com/users/andrejb/repos","events_url":"https://api.github.com/users/andrejb/events{/privacy}","received_events_url":"https://api.github.com/users/andrejb/received_events","type":"User","site_admin":false},"body":"I think this will depend on distinct network setups. Maybe we can leave as is and perform some tests afterwards to determine best values?","created_at":"2014-05-30T14:26:23Z","updated_at":"2014-05-30T14:26:23Z","html_url":"https://github.com/andrejb/U1DB-ZeroMQ-Transport/pull/1#discussion_r13230890","pull_request_url":"https://api.github.com/repos/andrejb/U1DB-ZeroMQ-Transport/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/andrejb/U1DB-ZeroMQ-Transport/pulls/comments/13230890"},"html":{"href":"https://github.com/andrejb/U1DB-ZeroMQ-Transport/pull/1#discussion_r13230890"},"pull_request":{"href":"https://api.github.com/repos/andrejb/U1DB-ZeroMQ-Transport/pulls/1"}}}}