GitHub PullRequestReviewCommentEvent at 2014-12-27 18:31:57
Repository: Behat
Actor: everzet
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/Behat/Behat/pulls/comments/22293880","id":22293880,"diff_hunk":"@@ -39,21 +39,31 @@\n     /**\n      * Initializes event.\n      *\n-     * @param Environment $env\n-     * @param FeatureNode $feature\n-     * @param TestResult  $result\n-     * @param Teardown    $teardown\n+     * @param SpecificationContext $context\n+     * @param TestResult           $result\n+     * @param Teardown             $teardown\n      */\n-    public function __construct(Environment $env, FeatureNode $feature, TestResult $result, Teardown $teardown)\n-    {\n-        parent::__construct($env);\n+    public function __construct(\n+        SpecificationContext $context,\n+        TestResult $result,\n+        Teardown $teardown","path":"src/Behat/Behat/EventDispatcher/Event/AfterFeatureTested.php","position":28,"original_position":28,"commit_id":"1b05fbd93789492453fd4ed664e98c85170ac2de","original_commit_id":"1b05fbd93789492453fd4ed664e98c85170ac2de","user":{"login":"everzet","id":30813,"avatar_url":"https://avatars.githubusercontent.com/u/30813?v=3","gravatar_id":"","url":"https://api.github.com/users/everzet","html_url":"https://github.com/everzet","followers_url":"https://api.github.com/users/everzet/followers","following_url":"https://api.github.com/users/everzet/following{/other_user}","gists_url":"https://api.github.com/users/everzet/gists{/gist_id}","starred_url":"https://api.github.com/users/everzet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/everzet/subscriptions","organizations_url":"https://api.github.com/users/everzet/orgs","repos_url":"https://api.github.com/users/everzet/repos","events_url":"https://api.github.com/users/everzet/events{/privacy}","received_events_url":"https://api.github.com/users/everzet/received_events","type":"User","site_admin":false},"body":"Agreed.","created_at":"2014-12-27T18:31:57Z","updated_at":"2014-12-27T18:31:57Z","html_url":"https://github.com/Behat/Behat/pull/656#discussion_r22293880","pull_request_url":"https://api.github.com/repos/Behat/Behat/pulls/656","_links":{"self":{"href":"https://api.github.com/repos/Behat/Behat/pulls/comments/22293880"},"html":{"href":"https://github.com/Behat/Behat/pull/656#discussion_r22293880"},"pull_request":{"href":"https://api.github.com/repos/Behat/Behat/pulls/656"}}},"pull_request":{"url":"https://api.github.com/repos/Behat/Behat/pulls/656","id":25213151,"html_url":"https://github.com/Behat/Behat/pull/656","diff_url":"https://github.com/Behat/Behat/pull/656.diff","patch_url":"https://github.com/Behat/Behat/pull/656.patch","issue_url":"https://api.github.com/repos/Behat/Behat/issues/656","number":656,"state":"open","locked":false,"title":"[WIP] Testers refactoring","user":{"login":"everzet","id":30813,"avatar_url":"https://avatars.githubusercontent.com/u/30813?v=3","gravatar_id":"","url":"https://api.github.com/users/everzet","html_url":"https://github.com/everzet","followers_url":"https://api.github.com/users/everzet/followers","following_url":"https://api.github.com/users/everzet/following{/other_user}","gists_url":"https://api.github.com/users/everzet/gists{/gist_id}","starred_url":"https://api.github.com/users/everzet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/everzet/subscriptions","organizations_url":"https://api.github.com/users/everzet/orgs","repos_url":"https://api.github.com/users/everzet/repos","events_url":"https://api.github.com/users/everzet/events{/privacy}","received_events_url":"https://api.github.com/users/everzet/received_events","type":"User","site_admin":false},"body":"This is a big refactoring of testers towards a singular interface. This should be the last piece of puzzle for 3.1.\r\n\r\nThis refactoring abstracts all interfaces into two - `Tester` and `ArrangingTester`. In order to support singular interface, `TestContext` and `RunControl` interfaces were introduced to properly encapsulate tester arguments. This refactoring allowed to do a great simplification of hooked and event-dispatching testers.\r\n\r\n### Motivation\r\n\r\n1. This refactoring should enable very easy fix of #650, #653 \r\n2. It also fixes unnoticed bug in outline examples isolation (they aren't really isolated in 3.0)\r\n3. Much simplified code of all testers, including decorators\r\n4. Preparation for Testwork extraction and release\r\n\r\n### BC Breaks\r\n\r\nThis refactoring effectively removes old tester interfaces, which obviously breaks backwards compatibility. Hence, this PR is in *WIP* state. There will be an additional BC-layer for extensions created prior to 3.1. If all goes well, we will fully support old interfaces for extensions that used them, meaning if you created one for 3.0, in 3.1 it should just work.","created_at":"2014-11-28T20:41:46Z","updated_at":"2014-12-27T18:31:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"845a99e6174ca498a2ac68266d53df1b379270ff","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Behat/Behat/pulls/656/commits","review_comments_url":"https://api.github.com/repos/Behat/Behat/pulls/656/comments","review_comment_url":"https://api.github.com/repos/Behat/Behat/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Behat/Behat/issues/656/comments","statuses_url":"https://api.github.com/repos/Behat/Behat/statuses/1b05fbd93789492453fd4ed664e98c85170ac2de","head":{"label":"Behat:feature/testers-refactoring","ref":"feature/testers-refactoring","sha":"1b05fbd93789492453fd4ed664e98c85170ac2de","user":{"login":"Behat","id":547869,"avatar_url":"https://avatars.githubusercontent.com/u/547869?v=3","gravatar_id":"","url":"https://api.github.com/users/Behat","html_url":"https://github.com/Behat","followers_url":"https://api.github.com/users/Behat/followers","following_url":"https://api.github.com/users/Behat/following{/other_user}","gists_url":"https://api.github.com/users/Behat/gists{/gist_id}","starred_url":"https://api.github.com/users/Behat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Behat/subscriptions","organizations_url":"https://api.github.com/users/Behat/orgs","repos_url":"https://api.github.com/users/Behat/repos","events_url":"https://api.github.com/users/Behat/events{/privacy}","received_events_url":"https://api.github.com/users/Behat/received_events","type":"Organization","site_admin":false},"repo":{"id":1367484,"name":"Behat","full_name":"Behat/Behat","owner":{"login":"Behat","id":547869,"avatar_url":"https://avatars.githubusercontent.com/u/547869?v=3","gravatar_id":"","url":"https://api.github.com/users/Behat","html_url":"https://github.com/Behat","followers_url":"https://api.github.com/users/Behat/followers","following_url":"https://api.github.com/users/Behat/following{/other_user}","gists_url":"https://api.github.com/users/Behat/gists{/gist_id}","starred_url":"https://api.github.com/users/Behat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Behat/subscriptions","organizations_url":"https://api.github.com/users/Behat/orgs","repos_url":"https://api.github.com/users/Behat/repos","events_url":"https://api.github.com/users/Behat/events{/privacy}","received_events_url":"https://api.github.com/users/Behat/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Behat/Behat","description":"BDD framework for PHP 5.3+","fork":false,"url":"https://api.github.com/repos/Behat/Behat","forks_url":"https://api.github.com/repos/Behat/Behat/forks","keys_url":"https://api.github.com/repos/Behat/Behat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Behat/Behat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Behat/Behat/teams","hooks_url":"https://api.github.com/repos/Behat/Behat/hooks","issue_events_url":"https://api.github.com/repos/Behat/Behat/issues/events{/number}","events_url":"https://api.github.com/repos/Behat/Behat/events","assignees_url":"https://api.github.com/repos/Behat/Behat/assignees{/user}","branches_url":"https://api.github.com/repos/Behat/Behat/branches{/branch}","tags_url":"https://api.github.com/repos/Behat/Behat/tags","blobs_url":"https://api.github.com/repos/Behat/Behat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Behat/Behat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Behat/Behat/git/refs{/sha}","trees_url":"https://api.github.com/repos/Behat/Behat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Behat/Behat/statuses/{sha}","languages_url":"https://api.github.com/repos/Behat/Behat/languages","stargazers_url":"https://api.github.com/repos/Behat/Behat/stargazers","contributors_url":"https://api.github.com/repos/Behat/Behat/contributors","subscribers_url":"https://api.github.com/repos/Behat/Behat/subscribers","subscription_url":"https://api.github.com/repos/Behat/Behat/subscription","commits_url":"https://api.github.com/repos/Behat/Behat/commits{/sha}","git_commits_url":"https://api.github.com/repos/Behat/Behat/git/commits{/sha}","comments_url":"https://api.github.com/repos/Behat/Behat/comments{/number}","issue_comment_url":"https://api.github.com/repos/Behat/Behat/issues/comments/{number}","contents_url":"https://api.github.com/repos/Behat/Behat/contents/{+path}","compare_url":"https://api.github.com/repos/Behat/Behat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Behat/Behat/merges","archive_url":"https://api.github.com/repos/Behat/Behat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Behat/Behat/downloads","issues_url":"https://api.github.com/repos/Behat/Behat/issues{/number}","pulls_url":"https://api.github.com/repos/Behat/Behat/pulls{/number}","milestones_url":"https://api.github.com/repos/Behat/Behat/milestones{/number}","notifications_url":"https://api.github.com/repos/Behat/Behat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Behat/Behat/labels{/name}","releases_url":"https://api.github.com/repos/Behat/Behat/releases{/id}","created_at":"2011-02-15T00:02:39Z","updated_at":"2014-12-27T14:09:05Z","pushed_at":"2014-12-16T13:41:40Z","git_url":"git://github.com/Behat/Behat.git","ssh_url":"git@github.com:Behat/Behat.git","clone_url":"https://github.com/Behat/Behat.git","svn_url":"https://github.com/Behat/Behat","homepage":"http://behat.org","size":7918,"stargazers_count":1286,"watchers_count":1286,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":279,"mirror_url":null,"open_issues_count":53,"forks":279,"open_issues":53,"watchers":1286,"default_branch":"master"}},"base":{"label":"Behat:master","ref":"master","sha":"33f400055af66ef1e24c0ca9404f7d14cf9a7c95","user":{"login":"Behat","id":547869,"avatar_url":"https://avatars.githubusercontent.com/u/547869?v=3","gravatar_id":"","url":"https://api.github.com/users/Behat","html_url":"https://github.com/Behat","followers_url":"https://api.github.com/users/Behat/followers","following_url":"https://api.github.com/users/Behat/following{/other_user}","gists_url":"https://api.github.com/users/Behat/gists{/gist_id}","starred_url":"https://api.github.com/users/Behat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Behat/subscriptions","organizations_url":"https://api.github.com/users/Behat/orgs","repos_url":"https://api.github.com/users/Behat/repos","events_url":"https://api.github.com/users/Behat/events{/privacy}","received_events_url":"https://api.github.com/users/Behat/received_events","type":"Organization","site_admin":false},"repo":{"id":1367484,"name":"Behat","full_name":"Behat/Behat","owner":{"login":"Behat","id":547869,"avatar_url":"https://avatars.githubusercontent.com/u/547869?v=3","gravatar_id":"","url":"https://api.github.com/users/Behat","html_url":"https://github.com/Behat","followers_url":"https://api.github.com/users/Behat/followers","following_url":"https://api.github.com/users/Behat/following{/other_user}","gists_url":"https://api.github.com/users/Behat/gists{/gist_id}","starred_url":"https://api.github.com/users/Behat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Behat/subscriptions","organizations_url":"https://api.github.com/users/Behat/orgs","repos_url":"https://api.github.com/users/Behat/repos","events_url":"https://api.github.com/users/Behat/events{/privacy}","received_events_url":"https://api.github.com/users/Behat/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Behat/Behat","description":"BDD framework for PHP 5.3+","fork":false,"url":"https://api.github.com/repos/Behat/Behat","forks_url":"https://api.github.com/repos/Behat/Behat/forks","keys_url":"https://api.github.com/repos/Behat/Behat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Behat/Behat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Behat/Behat/teams","hooks_url":"https://api.github.com/repos/Behat/Behat/hooks","issue_events_url":"https://api.github.com/repos/Behat/Behat/issues/events{/number}","events_url":"https://api.github.com/repos/Behat/Behat/events","assignees_url":"https://api.github.com/repos/Behat/Behat/assignees{/user}","branches_url":"https://api.github.com/repos/Behat/Behat/branches{/branch}","tags_url":"https://api.github.com/repos/Behat/Behat/tags","blobs_url":"https://api.github.com/repos/Behat/Behat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Behat/Behat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Behat/Behat/git/refs{/sha}","trees_url":"https://api.github.com/repos/Behat/Behat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Behat/Behat/statuses/{sha}","languages_url":"https://api.github.com/repos/Behat/Behat/languages","stargazers_url":"https://api.github.com/repos/Behat/Behat/stargazers","contributors_url":"https://api.github.com/repos/Behat/Behat/contributors","subscribers_url":"https://api.github.com/repos/Behat/Behat/subscribers","subscription_url":"https://api.github.com/repos/Behat/Behat/subscription","commits_url":"https://api.github.com/repos/Behat/Behat/commits{/sha}","git_commits_url":"https://api.github.com/repos/Behat/Behat/git/commits{/sha}","comments_url":"https://api.github.com/repos/Behat/Behat/comments{/number}","issue_comment_url":"https://api.github.com/repos/Behat/Behat/issues/comments/{number}","contents_url":"https://api.github.com/repos/Behat/Behat/contents/{+path}","compare_url":"https://api.github.com/repos/Behat/Behat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Behat/Behat/merges","archive_url":"https://api.github.com/repos/Behat/Behat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Behat/Behat/downloads","issues_url":"https://api.github.com/repos/Behat/Behat/issues{/number}","pulls_url":"https://api.github.com/repos/Behat/Behat/pulls{/number}","milestones_url":"https://api.github.com/repos/Behat/Behat/milestones{/number}","notifications_url":"https://api.github.com/repos/Behat/Behat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Behat/Behat/labels{/name}","releases_url":"https://api.github.com/repos/Behat/Behat/releases{/id}","created_at":"2011-02-15T00:02:39Z","updated_at":"2014-12-27T14:09:05Z","pushed_at":"2014-12-16T13:41:40Z","git_url":"git://github.com/Behat/Behat.git","ssh_url":"git@github.com:Behat/Behat.git","clone_url":"https://github.com/Behat/Behat.git","svn_url":"https://github.com/Behat/Behat","homepage":"http://behat.org","size":7918,"stargazers_count":1286,"watchers_count":1286,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":279,"mirror_url":null,"open_issues_count":53,"forks":279,"open_issues":53,"watchers":1286,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Behat/Behat/pulls/656"},"html":{"href":"https://github.com/Behat/Behat/pull/656"},"issue":{"href":"https://api.github.com/repos/Behat/Behat/issues/656"},"comments":{"href":"https://api.github.com/repos/Behat/Behat/issues/656/comments"},"review_comments":{"href":"https://api.github.com/repos/Behat/Behat/pulls/656/comments"},"review_comment":{"href":"https://api.github.com/repos/Behat/Behat/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Behat/Behat/pulls/656/commits"},"statuses":{"href":"https://api.github.com/repos/Behat/Behat/statuses/1b05fbd93789492453fd4ed664e98c85170ac2de"}}}}