GitHub PullRequestReviewCommentEvent at 2014-06-27 16:22:20
Repository: slamengine
Actor: mossprescott
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/slamdata/slamengine/pulls/comments/14301325","id":14301325,"diff_hunk":"@@ -2,10 +2,20 @@ package slamdata.engine\n \n import scalaz._\n \n-sealed trait RenderedNode\n+sealed trait RenderedNode {\n+  def label: Cord\n+}\n case class Terminal(label: Cord) extends RenderedNode\n case class NonTerminal(label: Cord, children: List[RenderedNode]) extends RenderedNode\n \n+object RenderedNode {\n+  def relabel(node: RenderedNode, label: Cord) = node match {\n+    case Terminal(_)                     => Terminal(label)\n+    case NonTerminal(oldLabel, children) => NonTerminal(label, children)\n+  }\n+}\n+\n+\n trait NodeRenderer[A] {","path":"src/main/scala/slamdata/engine/debug.scala","position":19,"original_position":19,"commit_id":"a6930420b142be21e602137b4cfa36bb42dc48f7","original_commit_id":"a6930420b142be21e602137b4cfa36bb42dc48f7","user":{"login":"mossprescott","id":6147371,"avatar_url":"https://avatars.githubusercontent.com/u/6147371?","gravatar_id":"8efbcab730ad4274206c593a1a907dfb","url":"https://api.github.com/users/mossprescott","html_url":"https://github.com/mossprescott","followers_url":"https://api.github.com/users/mossprescott/followers","following_url":"https://api.github.com/users/mossprescott/following{/other_user}","gists_url":"https://api.github.com/users/mossprescott/gists{/gist_id}","starred_url":"https://api.github.com/users/mossprescott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mossprescott/subscriptions","organizations_url":"https://api.github.com/users/mossprescott/orgs","repos_url":"https://api.github.com/users/mossprescott/repos","events_url":"https://api.github.com/users/mossprescott/events{/privacy}","received_events_url":"https://api.github.com/users/mossprescott/received_events","type":"User","site_admin":false},"body":"`RenderTree` sounds good, and I can't think of anything better than `RenderedTree`.\r\n\r\nI'll make the switch.","created_at":"2014-06-27T16:22:20Z","updated_at":"2014-06-27T16:22:20Z","html_url":"https://github.com/slamdata/slamengine/pull/79#discussion_r14301325","pull_request_url":"https://api.github.com/repos/slamdata/slamengine/pulls/79","_links":{"self":{"href":"https://api.github.com/repos/slamdata/slamengine/pulls/comments/14301325"},"html":{"href":"https://github.com/slamdata/slamengine/pull/79#discussion_r14301325"},"pull_request":{"href":"https://api.github.com/repos/slamdata/slamengine/pulls/79"}}},"pull_request":{"url":"https://api.github.com/repos/slamdata/slamengine/pulls/79","id":17680583,"html_url":"https://github.com/slamdata/slamengine/pull/79","diff_url":"https://github.com/slamdata/slamengine/pull/79.diff","patch_url":"https://github.com/slamdata/slamengine/pull/79.patch","issue_url":"https://api.github.com/repos/slamdata/slamengine/issues/79","number":79,"state":"open","title":"Everything has a NodeRenderer now","user":{"login":"mossprescott","id":6147371,"avatar_url":"https://avatars.githubusercontent.com/u/6147371?","gravatar_id":"8efbcab730ad4274206c593a1a907dfb","url":"https://api.github.com/users/mossprescott","html_url":"https://github.com/mossprescott","followers_url":"https://api.github.com/users/mossprescott/followers","following_url":"https://api.github.com/users/mossprescott/following{/other_user}","gists_url":"https://api.github.com/users/mossprescott/gists{/gist_id}","starred_url":"https://api.github.com/users/mossprescott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mossprescott/subscriptions","organizations_url":"https://api.github.com/users/mossprescott/orgs","repos_url":"https://api.github.com/users/mossprescott/repos","events_url":"https://api.github.com/users/mossprescott/events{/privacy}","received_events_url":"https://api.github.com/users/mossprescott/received_events","type":"User","site_admin":false},"body":"I think this covers all the interesting cases, but there are a couple of remaining questions. See the comments.","created_at":"2014-06-27T00:11:33Z","updated_at":"2014-06-27T16:22:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9ad77f960d47931c1e08477ecee0881005857250","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/slamdata/slamengine/pulls/79/commits","review_comments_url":"https://api.github.com/repos/slamdata/slamengine/pulls/79/comments","review_comment_url":"https://api.github.com/repos/slamdata/slamengine/pulls/comments/{number}","comments_url":"https://api.github.com/repos/slamdata/slamengine/issues/79/comments","statuses_url":"https://api.github.com/repos/slamdata/slamengine/statuses/a6930420b142be21e602137b4cfa36bb42dc48f7","head":{"label":"mossprescott:prettify","ref":"prettify","sha":"a6930420b142be21e602137b4cfa36bb42dc48f7","user":{"login":"mossprescott","id":6147371,"avatar_url":"https://avatars.githubusercontent.com/u/6147371?","gravatar_id":"8efbcab730ad4274206c593a1a907dfb","url":"https://api.github.com/users/mossprescott","html_url":"https://github.com/mossprescott","followers_url":"https://api.github.com/users/mossprescott/followers","following_url":"https://api.github.com/users/mossprescott/following{/other_user}","gists_url":"https://api.github.com/users/mossprescott/gists{/gist_id}","starred_url":"https://api.github.com/users/mossprescott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mossprescott/subscriptions","organizations_url":"https://api.github.com/users/mossprescott/orgs","repos_url":"https://api.github.com/users/mossprescott/repos","events_url":"https://api.github.com/users/mossprescott/events{/privacy}","received_events_url":"https://api.github.com/users/mossprescott/received_events","type":"User","site_admin":false},"repo":{"id":21178367,"name":"slamengine-1","full_name":"mossprescott/slamengine-1","owner":{"login":"mossprescott","id":6147371,"avatar_url":"https://avatars.githubusercontent.com/u/6147371?","gravatar_id":"8efbcab730ad4274206c593a1a907dfb","url":"https://api.github.com/users/mossprescott","html_url":"https://github.com/mossprescott","followers_url":"https://api.github.com/users/mossprescott/followers","following_url":"https://api.github.com/users/mossprescott/following{/other_user}","gists_url":"https://api.github.com/users/mossprescott/gists{/gist_id}","starred_url":"https://api.github.com/users/mossprescott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mossprescott/subscriptions","organizations_url":"https://api.github.com/users/mossprescott/orgs","repos_url":"https://api.github.com/users/mossprescott/repos","events_url":"https://api.github.com/users/mossprescott/events{/privacy}","received_events_url":"https://api.github.com/users/mossprescott/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mossprescott/slamengine-1","description":"The engine for SlamData","fork":true,"url":"https://api.github.com/repos/mossprescott/slamengine-1","forks_url":"https://api.github.com/repos/mossprescott/slamengine-1/forks","keys_url":"https://api.github.com/repos/mossprescott/slamengine-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mossprescott/slamengine-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mossprescott/slamengine-1/teams","hooks_url":"https://api.github.com/repos/mossprescott/slamengine-1/hooks","issue_events_url":"https://api.github.com/repos/mossprescott/slamengine-1/issues/events{/number}","events_url":"https://api.github.com/repos/mossprescott/slamengine-1/events","assignees_url":"https://api.github.com/repos/mossprescott/slamengine-1/assignees{/user}","branches_url":"https://api.github.com/repos/mossprescott/slamengine-1/branches{/branch}","tags_url":"https://api.github.com/repos/mossprescott/slamengine-1/tags","blobs_url":"https://api.github.com/repos/mossprescott/slamengine-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mossprescott/slamengine-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mossprescott/slamengine-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/mossprescott/slamengine-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mossprescott/slamengine-1/statuses/{sha}","languages_url":"https://api.github.com/repos/mossprescott/slamengine-1/languages","stargazers_url":"https://api.github.com/repos/mossprescott/slamengine-1/stargazers","contributors_url":"https://api.github.com/repos/mossprescott/slamengine-1/contributors","subscribers_url":"https://api.github.com/repos/mossprescott/slamengine-1/subscribers","subscription_url":"https://api.github.com/repos/mossprescott/slamengine-1/subscription","commits_url":"https://api.github.com/repos/mossprescott/slamengine-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/mossprescott/slamengine-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/mossprescott/slamengine-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/mossprescott/slamengine-1/issues/comments/{number}","contents_url":"https://api.github.com/repos/mossprescott/slamengine-1/contents/{+path}","compare_url":"https://api.github.com/repos/mossprescott/slamengine-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mossprescott/slamengine-1/merges","archive_url":"https://api.github.com/repos/mossprescott/slamengine-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mossprescott/slamengine-1/downloads","issues_url":"https://api.github.com/repos/mossprescott/slamengine-1/issues{/number}","pulls_url":"https://api.github.com/repos/mossprescott/slamengine-1/pulls{/number}","milestones_url":"https://api.github.com/repos/mossprescott/slamengine-1/milestones{/number}","notifications_url":"https://api.github.com/repos/mossprescott/slamengine-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mossprescott/slamengine-1/labels{/name}","releases_url":"https://api.github.com/repos/mossprescott/slamengine-1/releases{/id}","created_at":"2014-06-24T19:43:22Z","updated_at":"2014-06-25T00:53:06Z","pushed_at":"2014-06-27T00:10:06Z","git_url":"git://github.com/mossprescott/slamengine-1.git","ssh_url":"git@github.com:mossprescott/slamengine-1.git","clone_url":"https://github.com/mossprescott/slamengine-1.git","svn_url":"https://github.com/mossprescott/slamengine-1","homepage":null,"size":3822,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"slamdata:master","ref":"master","sha":"3354bb12ba0e1e2857726517df57c3923506161d","user":{"login":"slamdata","id":5385602,"avatar_url":"https://avatars.githubusercontent.com/u/5385602?","gravatar_id":"432a134a22bd5f9d9fd3c00d5c750405","url":"https://api.github.com/users/slamdata","html_url":"https://github.com/slamdata","followers_url":"https://api.github.com/users/slamdata/followers","following_url":"https://api.github.com/users/slamdata/following{/other_user}","gists_url":"https://api.github.com/users/slamdata/gists{/gist_id}","starred_url":"https://api.github.com/users/slamdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slamdata/subscriptions","organizations_url":"https://api.github.com/users/slamdata/orgs","repos_url":"https://api.github.com/users/slamdata/repos","events_url":"https://api.github.com/users/slamdata/events{/privacy}","received_events_url":"https://api.github.com/users/slamdata/received_events","type":"Organization","site_admin":false},"repo":{"id":16515058,"name":"slamengine","full_name":"slamdata/slamengine","owner":{"login":"slamdata","id":5385602,"avatar_url":"https://avatars.githubusercontent.com/u/5385602?","gravatar_id":"432a134a22bd5f9d9fd3c00d5c750405","url":"https://api.github.com/users/slamdata","html_url":"https://github.com/slamdata","followers_url":"https://api.github.com/users/slamdata/followers","following_url":"https://api.github.com/users/slamdata/following{/other_user}","gists_url":"https://api.github.com/users/slamdata/gists{/gist_id}","starred_url":"https://api.github.com/users/slamdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slamdata/subscriptions","organizations_url":"https://api.github.com/users/slamdata/orgs","repos_url":"https://api.github.com/users/slamdata/repos","events_url":"https://api.github.com/users/slamdata/events{/privacy}","received_events_url":"https://api.github.com/users/slamdata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/slamdata/slamengine","description":"The engine for SlamData","fork":false,"url":"https://api.github.com/repos/slamdata/slamengine","forks_url":"https://api.github.com/repos/slamdata/slamengine/forks","keys_url":"https://api.github.com/repos/slamdata/slamengine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/slamdata/slamengine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/slamdata/slamengine/teams","hooks_url":"https://api.github.com/repos/slamdata/slamengine/hooks","issue_events_url":"https://api.github.com/repos/slamdata/slamengine/issues/events{/number}","events_url":"https://api.github.com/repos/slamdata/slamengine/events","assignees_url":"https://api.github.com/repos/slamdata/slamengine/assignees{/user}","branches_url":"https://api.github.com/repos/slamdata/slamengine/branches{/branch}","tags_url":"https://api.github.com/repos/slamdata/slamengine/tags","blobs_url":"https://api.github.com/repos/slamdata/slamengine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/slamdata/slamengine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/slamdata/slamengine/git/refs{/sha}","trees_url":"https://api.github.com/repos/slamdata/slamengine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/slamdata/slamengine/statuses/{sha}","languages_url":"https://api.github.com/repos/slamdata/slamengine/languages","stargazers_url":"https://api.github.com/repos/slamdata/slamengine/stargazers","contributors_url":"https://api.github.com/repos/slamdata/slamengine/contributors","subscribers_url":"https://api.github.com/repos/slamdata/slamengine/subscribers","subscription_url":"https://api.github.com/repos/slamdata/slamengine/subscription","commits_url":"https://api.github.com/repos/slamdata/slamengine/commits{/sha}","git_commits_url":"https://api.github.com/repos/slamdata/slamengine/git/commits{/sha}","comments_url":"https://api.github.com/repos/slamdata/slamengine/comments{/number}","issue_comment_url":"https://api.github.com/repos/slamdata/slamengine/issues/comments/{number}","contents_url":"https://api.github.com/repos/slamdata/slamengine/contents/{+path}","compare_url":"https://api.github.com/repos/slamdata/slamengine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/slamdata/slamengine/merges","archive_url":"https://api.github.com/repos/slamdata/slamengine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/slamdata/slamengine/downloads","issues_url":"https://api.github.com/repos/slamdata/slamengine/issues{/number}","pulls_url":"https://api.github.com/repos/slamdata/slamengine/pulls{/number}","milestones_url":"https://api.github.com/repos/slamdata/slamengine/milestones{/number}","notifications_url":"https://api.github.com/repos/slamdata/slamengine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/slamdata/slamengine/labels{/name}","releases_url":"https://api.github.com/repos/slamdata/slamengine/releases{/id}","created_at":"2014-02-04T15:01:27Z","updated_at":"2014-06-26T15:27:20Z","pushed_at":"2014-06-26T13:51:28Z","git_url":"git://github.com/slamdata/slamengine.git","ssh_url":"git@github.com:slamdata/slamengine.git","clone_url":"https://github.com/slamdata/slamengine.git","svn_url":"https://github.com/slamdata/slamengine","homepage":null,"size":3822,"stargazers_count":7,"watchers_count":7,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":3,"mirror_url":null,"open_issues_count":34,"forks":3,"open_issues":34,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/slamdata/slamengine/pulls/79"},"html":{"href":"https://github.com/slamdata/slamengine/pull/79"},"issue":{"href":"https://api.github.com/repos/slamdata/slamengine/issues/79"},"comments":{"href":"https://api.github.com/repos/slamdata/slamengine/issues/79/comments"},"review_comments":{"href":"https://api.github.com/repos/slamdata/slamengine/pulls/79/comments"},"review_comment":{"href":"https://api.github.com/repos/slamdata/slamengine/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/slamdata/slamengine/pulls/79/commits"},"statuses":{"href":"https://api.github.com/repos/slamdata/slamengine/statuses/a6930420b142be21e602137b4cfa36bb42dc48f7"}}}}