GitHub PullRequestReviewCommentEvent at 2014-09-14 13:53:35
Repository: akka-persistence-cassandra
Actor: krasserm
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/pulls/comments/17519733","id":17519733,"diff_hunk":"@@ -71,8 +73,31 @@ class CassandraSnapshotStore extends CassandraSnapshotStoreEndpoint with Cassand\n   val cluster = clusterBuilder.build\n   val session = cluster.connect()\n \n-  session.execute(createKeyspace(replicationFactor))\n-  session.execute(createTable)\n+   if(configureKeyspace == \"true\"){\n+    if(keyspaceStrategyClass == \"NetworkTopologyStrategy\"){\n+      try {\n+          session.execute(createKeyspaceWithNetworkTopologyStrategy(keyspaceStrategyClassDC1Name,keyspaceStrategyClassDC1RepFactor,keyspaceStrategyClassDC2Name,\n+                          keyspaceStrategyClassDC2RepFactor))\n+      }catch {\n+          case e: Exception => println(\"Keyspace not created as it already exists or an unknown error: \" + e);","path":"src/main/scala/akka/persistence/cassandra/snapshot/CassandraSnapshotStore.scala","position":57,"original_position":57,"commit_id":"a55275c73945b7c9c49251ea02c849ea9820c2d1","original_commit_id":"a55275c73945b7c9c49251ea02c849ea9820c2d1","user":{"login":"krasserm","id":202907,"avatar_url":"https://avatars.githubusercontent.com/u/202907?v=2","gravatar_id":"9fa46b50abc760dc7ad2a4c4a3d44136","url":"https://api.github.com/users/krasserm","html_url":"https://github.com/krasserm","followers_url":"https://api.github.com/users/krasserm/followers","following_url":"https://api.github.com/users/krasserm/following{/other_user}","gists_url":"https://api.github.com/users/krasserm/gists{/gist_id}","starred_url":"https://api.github.com/users/krasserm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krasserm/subscriptions","organizations_url":"https://api.github.com/users/krasserm/orgs","repos_url":"https://api.github.com/users/krasserm/repos","events_url":"https://api.github.com/users/krasserm/events{/privacy}","received_events_url":"https://api.github.com/users/krasserm/received_events","type":"User","site_admin":false},"body":"Same as for `CassandraJournal.scala`. Also significant amount of code duplication. Refactor?","created_at":"2014-09-14T13:53:35Z","updated_at":"2014-09-14T13:53:35Z","html_url":"https://github.com/krasserm/akka-persistence-cassandra/pull/22#discussion_r17519733","pull_request_url":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/pulls/22","_links":{"self":{"href":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/pulls/comments/17519733"},"html":{"href":"https://github.com/krasserm/akka-persistence-cassandra/pull/22#discussion_r17519733"},"pull_request":{"href":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/pulls/22"}}},"pull_request":{"url":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/pulls/22","id":20889317,"html_url":"https://github.com/krasserm/akka-persistence-cassandra/pull/22","diff_url":"https://github.com/krasserm/akka-persistence-cassandra/pull/22.diff","patch_url":"https://github.com/krasserm/akka-persistence-cassandra/pull/22.patch","issue_url":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/issues/22","number":22,"state":"open","locked":false,"title":"Cassandra 1.2","user":{"login":"ratika19","id":8498766,"avatar_url":"https://avatars.githubusercontent.com/u/8498766?v=2","gravatar_id":"a0adea9d50554cd4473088ddce685617","url":"https://api.github.com/users/ratika19","html_url":"https://github.com/ratika19","followers_url":"https://api.github.com/users/ratika19/followers","following_url":"https://api.github.com/users/ratika19/following{/other_user}","gists_url":"https://api.github.com/users/ratika19/gists{/gist_id}","starred_url":"https://api.github.com/users/ratika19/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ratika19/subscriptions","organizations_url":"https://api.github.com/users/ratika19/orgs","repos_url":"https://api.github.com/users/ratika19/repos","events_url":"https://api.github.com/users/ratika19/events{/privacy}","received_events_url":"https://api.github.com/users/ratika19/received_events","type":"User","site_admin":false},"body":"Hi Martin,\r\n\r\nI have made the changes to make this plugin usable with lower version of cassandra 1.2/1.2.x, changes on a high level are captured below, also the changes passes all testcases. Request you to review and let me know your comments.\r\n\r\n1. Datastax cassandra driver downgraded from 2.0.3 to 2.0.1(support cassandra version 1.2)\r\n2. Cassandra-unit downgraded\r\n3. Support added to create Keyspace with NeyworkTopologyStrategy also\r\n4. BatchStatements replaces with CQL query batch wrapped in prepared statements\r\n5. Parameterized Statements replaces with Prepared and Bound statements\r\n6. Updated Readme.md\r\n\r\nThanks\r\nRatika","created_at":"2014-09-08T13:33:29Z","updated_at":"2014-09-14T13:53:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dd19367477a57ef17a935313057857331252571c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/pulls/22/commits","review_comments_url":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/pulls/22/comments","review_comment_url":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/pulls/comments/{number}","comments_url":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/issues/22/comments","statuses_url":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/statuses/a55275c73945b7c9c49251ea02c849ea9820c2d1","head":{"label":"ratika19:cassandra-1.2","ref":"cassandra-1.2","sha":"a55275c73945b7c9c49251ea02c849ea9820c2d1","user":{"login":"ratika19","id":8498766,"avatar_url":"https://avatars.githubusercontent.com/u/8498766?v=2","gravatar_id":"a0adea9d50554cd4473088ddce685617","url":"https://api.github.com/users/ratika19","html_url":"https://github.com/ratika19","followers_url":"https://api.github.com/users/ratika19/followers","following_url":"https://api.github.com/users/ratika19/following{/other_user}","gists_url":"https://api.github.com/users/ratika19/gists{/gist_id}","starred_url":"https://api.github.com/users/ratika19/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ratika19/subscriptions","organizations_url":"https://api.github.com/users/ratika19/orgs","repos_url":"https://api.github.com/users/ratika19/repos","events_url":"https://api.github.com/users/ratika19/events{/privacy}","received_events_url":"https://api.github.com/users/ratika19/received_events","type":"User","site_admin":false},"repo":{"id":23140312,"name":"akka-persistence-cassandra","full_name":"ratika19/akka-persistence-cassandra","owner":{"login":"ratika19","id":8498766,"avatar_url":"https://avatars.githubusercontent.com/u/8498766?v=2","gravatar_id":"a0adea9d50554cd4473088ddce685617","url":"https://api.github.com/users/ratika19","html_url":"https://github.com/ratika19","followers_url":"https://api.github.com/users/ratika19/followers","following_url":"https://api.github.com/users/ratika19/following{/other_user}","gists_url":"https://api.github.com/users/ratika19/gists{/gist_id}","starred_url":"https://api.github.com/users/ratika19/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ratika19/subscriptions","organizations_url":"https://api.github.com/users/ratika19/orgs","repos_url":"https://api.github.com/users/ratika19/repos","events_url":"https://api.github.com/users/ratika19/events{/privacy}","received_events_url":"https://api.github.com/users/ratika19/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ratika19/akka-persistence-cassandra","description":"A replicated Akka Persistence journal backed by Apache Cassandra","fork":true,"url":"https://api.github.com/repos/ratika19/akka-persistence-cassandra","forks_url":"https://api.github.com/repos/ratika19/akka-persistence-cassandra/forks","keys_url":"https://api.github.com/repos/ratika19/akka-persistence-cassandra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ratika19/akka-persistence-cassandra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ratika19/akka-persistence-cassandra/teams","hooks_url":"https://api.github.com/repos/ratika19/akka-persistence-cassandra/hooks","issue_events_url":"https://api.github.com/repos/ratika19/akka-persistence-cassandra/issues/events{/number}","events_url":"https://api.github.com/repos/ratika19/akka-persistence-cassandra/events","assignees_url":"https://api.github.com/repos/ratika19/akka-persistence-cassandra/assignees{/user}","branches_url":"https://api.github.com/repos/ratika19/akka-persistence-cassandra/branches{/branch}","tags_url":"https://api.github.com/repos/ratika19/akka-persistence-cassandra/tags","blobs_url":"https://api.github.com/repos/ratika19/akka-persistence-cassandra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ratika19/akka-persistence-cassandra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ratika19/akka-persistence-cassandra/git/refs{/sha}","trees_url":"https://api.github.com/repos/ratika19/akka-persistence-cassandra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ratika19/akka-persistence-cassandra/statuses/{sha}","languages_url":"https://api.github.com/repos/ratika19/akka-persistence-cassandra/languages","stargazers_url":"https://api.github.com/repos/ratika19/akka-persistence-cassandra/stargazers","contributors_url":"https://api.github.com/repos/ratika19/akka-persistence-cassandra/contributors","subscribers_url":"https://api.github.com/repos/ratika19/akka-persistence-cassandra/subscribers","subscription_url":"https://api.github.com/repos/ratika19/akka-persistence-cassandra/subscription","commits_url":"https://api.github.com/repos/ratika19/akka-persistence-cassandra/commits{/sha}","git_commits_url":"https://api.github.com/repos/ratika19/akka-persistence-cassandra/git/commits{/sha}","comments_url":"https://api.github.com/repos/ratika19/akka-persistence-cassandra/comments{/number}","issue_comment_url":"https://api.github.com/repos/ratika19/akka-persistence-cassandra/issues/comments/{number}","contents_url":"https://api.github.com/repos/ratika19/akka-persistence-cassandra/contents/{+path}","compare_url":"https://api.github.com/repos/ratika19/akka-persistence-cassandra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ratika19/akka-persistence-cassandra/merges","archive_url":"https://api.github.com/repos/ratika19/akka-persistence-cassandra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ratika19/akka-persistence-cassandra/downloads","issues_url":"https://api.github.com/repos/ratika19/akka-persistence-cassandra/issues{/number}","pulls_url":"https://api.github.com/repos/ratika19/akka-persistence-cassandra/pulls{/number}","milestones_url":"https://api.github.com/repos/ratika19/akka-persistence-cassandra/milestones{/number}","notifications_url":"https://api.github.com/repos/ratika19/akka-persistence-cassandra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ratika19/akka-persistence-cassandra/labels{/name}","releases_url":"https://api.github.com/repos/ratika19/akka-persistence-cassandra/releases{/id}","created_at":"2014-08-20T07:43:25Z","updated_at":"2014-08-03T15:21:38Z","pushed_at":"2014-09-09T12:03:53Z","git_url":"git://github.com/ratika19/akka-persistence-cassandra.git","ssh_url":"git@github.com:ratika19/akka-persistence-cassandra.git","clone_url":"https://github.com/ratika19/akka-persistence-cassandra.git","svn_url":"https://github.com/ratika19/akka-persistence-cassandra","homepage":"","size":217,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"krasserm:cassandra-1.2","ref":"cassandra-1.2","sha":"f27c09c7746989f45bb6bb2e6022d3aa574fcd76","user":{"login":"krasserm","id":202907,"avatar_url":"https://avatars.githubusercontent.com/u/202907?v=2","gravatar_id":"9fa46b50abc760dc7ad2a4c4a3d44136","url":"https://api.github.com/users/krasserm","html_url":"https://github.com/krasserm","followers_url":"https://api.github.com/users/krasserm/followers","following_url":"https://api.github.com/users/krasserm/following{/other_user}","gists_url":"https://api.github.com/users/krasserm/gists{/gist_id}","starred_url":"https://api.github.com/users/krasserm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krasserm/subscriptions","organizations_url":"https://api.github.com/users/krasserm/orgs","repos_url":"https://api.github.com/users/krasserm/repos","events_url":"https://api.github.com/users/krasserm/events{/privacy}","received_events_url":"https://api.github.com/users/krasserm/received_events","type":"User","site_admin":false},"repo":{"id":15447419,"name":"akka-persistence-cassandra","full_name":"krasserm/akka-persistence-cassandra","owner":{"login":"krasserm","id":202907,"avatar_url":"https://avatars.githubusercontent.com/u/202907?v=2","gravatar_id":"9fa46b50abc760dc7ad2a4c4a3d44136","url":"https://api.github.com/users/krasserm","html_url":"https://github.com/krasserm","followers_url":"https://api.github.com/users/krasserm/followers","following_url":"https://api.github.com/users/krasserm/following{/other_user}","gists_url":"https://api.github.com/users/krasserm/gists{/gist_id}","starred_url":"https://api.github.com/users/krasserm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krasserm/subscriptions","organizations_url":"https://api.github.com/users/krasserm/orgs","repos_url":"https://api.github.com/users/krasserm/repos","events_url":"https://api.github.com/users/krasserm/events{/privacy}","received_events_url":"https://api.github.com/users/krasserm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/krasserm/akka-persistence-cassandra","description":"A replicated Akka Persistence journal backed by Apache Cassandra","fork":false,"url":"https://api.github.com/repos/krasserm/akka-persistence-cassandra","forks_url":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/forks","keys_url":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/teams","hooks_url":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/hooks","issue_events_url":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/issues/events{/number}","events_url":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/events","assignees_url":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/assignees{/user}","branches_url":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/branches{/branch}","tags_url":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/tags","blobs_url":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/git/refs{/sha}","trees_url":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/statuses/{sha}","languages_url":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/languages","stargazers_url":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/stargazers","contributors_url":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/contributors","subscribers_url":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/subscribers","subscription_url":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/subscription","commits_url":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/commits{/sha}","git_commits_url":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/git/commits{/sha}","comments_url":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/comments{/number}","issue_comment_url":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/issues/comments/{number}","contents_url":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/contents/{+path}","compare_url":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/merges","archive_url":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/downloads","issues_url":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/issues{/number}","pulls_url":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/pulls{/number}","milestones_url":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/milestones{/number}","notifications_url":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/labels{/name}","releases_url":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/releases{/id}","created_at":"2013-12-26T06:47:08Z","updated_at":"2014-09-14T08:35:03Z","pushed_at":"2014-09-04T06:14:24Z","git_url":"git://github.com/krasserm/akka-persistence-cassandra.git","ssh_url":"git@github.com:krasserm/akka-persistence-cassandra.git","clone_url":"https://github.com/krasserm/akka-persistence-cassandra.git","svn_url":"https://github.com/krasserm/akka-persistence-cassandra","homepage":"","size":1259,"stargazers_count":79,"watchers_count":79,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":16,"mirror_url":null,"open_issues_count":4,"forks":16,"open_issues":4,"watchers":79,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/pulls/22"},"html":{"href":"https://github.com/krasserm/akka-persistence-cassandra/pull/22"},"issue":{"href":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/issues/22"},"comments":{"href":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/statuses/a55275c73945b7c9c49251ea02c849ea9820c2d1"}}}}