GitHub PullRequestReviewCommentEvent at 2014-06-27 14:53:09
Repository: scrapy
Actor: dangra
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/scrapy/scrapy/pulls/comments/14296329","id":14296329,"diff_hunk":"@@ -84,6 +84,6 @@ class ScrapesContract(Contract):\n     def post_process(self, output):\n         for x in output:\n             if isinstance(x, BaseItem):\n-                for arg in self.args:\n-                    if not arg in x:\n-                        raise ContractFail(\"'%s' field is missing\" % arg)\n+                missing = [arg for arg in self.args if arg not in x]\n+                if missing:\n+                    raise ContractFail(\"'%s' field is missing\" % \" \".join(missing))","path":"scrapy/contracts/default.py","position":9,"original_position":9,"commit_id":"e0b0f64cf427e462b3230c7dab75aeb93774f78d","original_commit_id":"e0b0f64cf427e462b3230c7dab75aeb93774f78d","user":{"login":"dangra","id":37369,"avatar_url":"https://avatars.githubusercontent.com/u/37369?","gravatar_id":"17c261e65c5d049157a7d38a6a2665f2","url":"https://api.github.com/users/dangra","html_url":"https://github.com/dangra","followers_url":"https://api.github.com/users/dangra/followers","following_url":"https://api.github.com/users/dangra/following{/other_user}","gists_url":"https://api.github.com/users/dangra/gists{/gist_id}","starred_url":"https://api.github.com/users/dangra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dangra/subscriptions","organizations_url":"https://api.github.com/users/dangra/orgs","repos_url":"https://api.github.com/users/dangra/repos","events_url":"https://api.github.com/users/dangra/events{/privacy}","received_events_url":"https://api.github.com/users/dangra/received_events","type":"User","site_admin":false},"body":"and a new/updated test case.\r\n\r\notherwise +1.","created_at":"2014-06-27T14:53:09Z","updated_at":"2014-06-27T14:53:09Z","html_url":"https://github.com/scrapy/scrapy/pull/766#discussion_r14296329","pull_request_url":"https://api.github.com/repos/scrapy/scrapy/pulls/766","_links":{"self":{"href":"https://api.github.com/repos/scrapy/scrapy/pulls/comments/14296329"},"html":{"href":"https://github.com/scrapy/scrapy/pull/766#discussion_r14296329"},"pull_request":{"href":"https://api.github.com/repos/scrapy/scrapy/pulls/766"}}},"pull_request":{"url":"https://api.github.com/repos/scrapy/scrapy/pulls/766","id":17637808,"html_url":"https://github.com/scrapy/scrapy/pull/766","diff_url":"https://github.com/scrapy/scrapy/pull/766.diff","patch_url":"https://github.com/scrapy/scrapy/pull/766.patch","issue_url":"https://api.github.com/repos/scrapy/scrapy/issues/766","number":766,"state":"open","title":"show all the missing field when scrapes contract fails","user":{"login":"tpeng","id":380234,"avatar_url":"https://avatars.githubusercontent.com/u/380234?","gravatar_id":"697235aa5dd54522567a0e63ce1d113b","url":"https://api.github.com/users/tpeng","html_url":"https://github.com/tpeng","followers_url":"https://api.github.com/users/tpeng/followers","following_url":"https://api.github.com/users/tpeng/following{/other_user}","gists_url":"https://api.github.com/users/tpeng/gists{/gist_id}","starred_url":"https://api.github.com/users/tpeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tpeng/subscriptions","organizations_url":"https://api.github.com/users/tpeng/orgs","repos_url":"https://api.github.com/users/tpeng/repos","events_url":"https://api.github.com/users/tpeng/events{/privacy}","received_events_url":"https://api.github.com/users/tpeng/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-06-26T09:29:03Z","updated_at":"2014-06-27T14:53:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c8897fbe3f28508667b1a47b69f839bdd945756b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/scrapy/scrapy/pulls/766/commits","review_comments_url":"https://api.github.com/repos/scrapy/scrapy/pulls/766/comments","review_comment_url":"https://api.github.com/repos/scrapy/scrapy/pulls/comments/{number}","comments_url":"https://api.github.com/repos/scrapy/scrapy/issues/766/comments","statuses_url":"https://api.github.com/repos/scrapy/scrapy/statuses/e0b0f64cf427e462b3230c7dab75aeb93774f78d","head":{"label":"tpeng:improve-scrapes-contract","ref":"improve-scrapes-contract","sha":"e0b0f64cf427e462b3230c7dab75aeb93774f78d","user":{"login":"tpeng","id":380234,"avatar_url":"https://avatars.githubusercontent.com/u/380234?","gravatar_id":"697235aa5dd54522567a0e63ce1d113b","url":"https://api.github.com/users/tpeng","html_url":"https://github.com/tpeng","followers_url":"https://api.github.com/users/tpeng/followers","following_url":"https://api.github.com/users/tpeng/following{/other_user}","gists_url":"https://api.github.com/users/tpeng/gists{/gist_id}","starred_url":"https://api.github.com/users/tpeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tpeng/subscriptions","organizations_url":"https://api.github.com/users/tpeng/orgs","repos_url":"https://api.github.com/users/tpeng/repos","events_url":"https://api.github.com/users/tpeng/events{/privacy}","received_events_url":"https://api.github.com/users/tpeng/received_events","type":"User","site_admin":false},"repo":{"id":9927389,"name":"scrapy","full_name":"tpeng/scrapy","owner":{"login":"tpeng","id":380234,"avatar_url":"https://avatars.githubusercontent.com/u/380234?","gravatar_id":"697235aa5dd54522567a0e63ce1d113b","url":"https://api.github.com/users/tpeng","html_url":"https://github.com/tpeng","followers_url":"https://api.github.com/users/tpeng/followers","following_url":"https://api.github.com/users/tpeng/following{/other_user}","gists_url":"https://api.github.com/users/tpeng/gists{/gist_id}","starred_url":"https://api.github.com/users/tpeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tpeng/subscriptions","organizations_url":"https://api.github.com/users/tpeng/orgs","repos_url":"https://api.github.com/users/tpeng/repos","events_url":"https://api.github.com/users/tpeng/events{/privacy}","received_events_url":"https://api.github.com/users/tpeng/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tpeng/scrapy","description":"Scrapy, a fast high-level screen scraping and web crawling framework for Python.","fork":true,"url":"https://api.github.com/repos/tpeng/scrapy","forks_url":"https://api.github.com/repos/tpeng/scrapy/forks","keys_url":"https://api.github.com/repos/tpeng/scrapy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tpeng/scrapy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tpeng/scrapy/teams","hooks_url":"https://api.github.com/repos/tpeng/scrapy/hooks","issue_events_url":"https://api.github.com/repos/tpeng/scrapy/issues/events{/number}","events_url":"https://api.github.com/repos/tpeng/scrapy/events","assignees_url":"https://api.github.com/repos/tpeng/scrapy/assignees{/user}","branches_url":"https://api.github.com/repos/tpeng/scrapy/branches{/branch}","tags_url":"https://api.github.com/repos/tpeng/scrapy/tags","blobs_url":"https://api.github.com/repos/tpeng/scrapy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tpeng/scrapy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tpeng/scrapy/git/refs{/sha}","trees_url":"https://api.github.com/repos/tpeng/scrapy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tpeng/scrapy/statuses/{sha}","languages_url":"https://api.github.com/repos/tpeng/scrapy/languages","stargazers_url":"https://api.github.com/repos/tpeng/scrapy/stargazers","contributors_url":"https://api.github.com/repos/tpeng/scrapy/contributors","subscribers_url":"https://api.github.com/repos/tpeng/scrapy/subscribers","subscription_url":"https://api.github.com/repos/tpeng/scrapy/subscription","commits_url":"https://api.github.com/repos/tpeng/scrapy/commits{/sha}","git_commits_url":"https://api.github.com/repos/tpeng/scrapy/git/commits{/sha}","comments_url":"https://api.github.com/repos/tpeng/scrapy/comments{/number}","issue_comment_url":"https://api.github.com/repos/tpeng/scrapy/issues/comments/{number}","contents_url":"https://api.github.com/repos/tpeng/scrapy/contents/{+path}","compare_url":"https://api.github.com/repos/tpeng/scrapy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tpeng/scrapy/merges","archive_url":"https://api.github.com/repos/tpeng/scrapy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tpeng/scrapy/downloads","issues_url":"https://api.github.com/repos/tpeng/scrapy/issues{/number}","pulls_url":"https://api.github.com/repos/tpeng/scrapy/pulls{/number}","milestones_url":"https://api.github.com/repos/tpeng/scrapy/milestones{/number}","notifications_url":"https://api.github.com/repos/tpeng/scrapy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tpeng/scrapy/labels{/name}","releases_url":"https://api.github.com/repos/tpeng/scrapy/releases{/id}","created_at":"2013-05-08T03:16:17Z","updated_at":"2014-06-18T06:38:28Z","pushed_at":"2014-06-26T09:28:36Z","git_url":"git://github.com/tpeng/scrapy.git","ssh_url":"git@github.com:tpeng/scrapy.git","clone_url":"https://github.com/tpeng/scrapy.git","svn_url":"https://github.com/tpeng/scrapy","homepage":"http://scrapy.org","size":12937,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":false,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scrapy:master","ref":"master","sha":"eb97d257f0b3c32edbadd974679bd64f0989e372","user":{"login":"scrapy","id":733635,"avatar_url":"https://avatars.githubusercontent.com/u/733635?","gravatar_id":"4b1f68760dddf81c5cf5da23b592ffe2","url":"https://api.github.com/users/scrapy","html_url":"https://github.com/scrapy","followers_url":"https://api.github.com/users/scrapy/followers","following_url":"https://api.github.com/users/scrapy/following{/other_user}","gists_url":"https://api.github.com/users/scrapy/gists{/gist_id}","starred_url":"https://api.github.com/users/scrapy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scrapy/subscriptions","organizations_url":"https://api.github.com/users/scrapy/orgs","repos_url":"https://api.github.com/users/scrapy/repos","events_url":"https://api.github.com/users/scrapy/events{/privacy}","received_events_url":"https://api.github.com/users/scrapy/received_events","type":"Organization","site_admin":false},"repo":{"id":529502,"name":"scrapy","full_name":"scrapy/scrapy","owner":{"login":"scrapy","id":733635,"avatar_url":"https://avatars.githubusercontent.com/u/733635?","gravatar_id":"4b1f68760dddf81c5cf5da23b592ffe2","url":"https://api.github.com/users/scrapy","html_url":"https://github.com/scrapy","followers_url":"https://api.github.com/users/scrapy/followers","following_url":"https://api.github.com/users/scrapy/following{/other_user}","gists_url":"https://api.github.com/users/scrapy/gists{/gist_id}","starred_url":"https://api.github.com/users/scrapy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scrapy/subscriptions","organizations_url":"https://api.github.com/users/scrapy/orgs","repos_url":"https://api.github.com/users/scrapy/repos","events_url":"https://api.github.com/users/scrapy/events{/privacy}","received_events_url":"https://api.github.com/users/scrapy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scrapy/scrapy","description":"Scrapy, a fast high-level screen scraping and web crawling framework for Python.","fork":false,"url":"https://api.github.com/repos/scrapy/scrapy","forks_url":"https://api.github.com/repos/scrapy/scrapy/forks","keys_url":"https://api.github.com/repos/scrapy/scrapy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scrapy/scrapy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scrapy/scrapy/teams","hooks_url":"https://api.github.com/repos/scrapy/scrapy/hooks","issue_events_url":"https://api.github.com/repos/scrapy/scrapy/issues/events{/number}","events_url":"https://api.github.com/repos/scrapy/scrapy/events","assignees_url":"https://api.github.com/repos/scrapy/scrapy/assignees{/user}","branches_url":"https://api.github.com/repos/scrapy/scrapy/branches{/branch}","tags_url":"https://api.github.com/repos/scrapy/scrapy/tags","blobs_url":"https://api.github.com/repos/scrapy/scrapy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scrapy/scrapy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scrapy/scrapy/git/refs{/sha}","trees_url":"https://api.github.com/repos/scrapy/scrapy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scrapy/scrapy/statuses/{sha}","languages_url":"https://api.github.com/repos/scrapy/scrapy/languages","stargazers_url":"https://api.github.com/repos/scrapy/scrapy/stargazers","contributors_url":"https://api.github.com/repos/scrapy/scrapy/contributors","subscribers_url":"https://api.github.com/repos/scrapy/scrapy/subscribers","subscription_url":"https://api.github.com/repos/scrapy/scrapy/subscription","commits_url":"https://api.github.com/repos/scrapy/scrapy/commits{/sha}","git_commits_url":"https://api.github.com/repos/scrapy/scrapy/git/commits{/sha}","comments_url":"https://api.github.com/repos/scrapy/scrapy/comments{/number}","issue_comment_url":"https://api.github.com/repos/scrapy/scrapy/issues/comments/{number}","contents_url":"https://api.github.com/repos/scrapy/scrapy/contents/{+path}","compare_url":"https://api.github.com/repos/scrapy/scrapy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scrapy/scrapy/merges","archive_url":"https://api.github.com/repos/scrapy/scrapy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scrapy/scrapy/downloads","issues_url":"https://api.github.com/repos/scrapy/scrapy/issues{/number}","pulls_url":"https://api.github.com/repos/scrapy/scrapy/pulls{/number}","milestones_url":"https://api.github.com/repos/scrapy/scrapy/milestones{/number}","notifications_url":"https://api.github.com/repos/scrapy/scrapy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scrapy/scrapy/labels{/name}","releases_url":"https://api.github.com/repos/scrapy/scrapy/releases{/id}","created_at":"2010-02-22T02:01:14Z","updated_at":"2014-06-27T14:09:42Z","pushed_at":"2014-06-26T15:00:09Z","git_url":"git://github.com/scrapy/scrapy.git","ssh_url":"git@github.com:scrapy/scrapy.git","clone_url":"https://github.com/scrapy/scrapy.git","svn_url":"https://github.com/scrapy/scrapy","homepage":"http://scrapy.org","size":26191,"stargazers_count":5097,"watchers_count":5097,"language":"Python","has_issues":true,"has_downloads":false,"has_wiki":true,"forks_count":1346,"mirror_url":null,"open_issues_count":145,"forks":1346,"open_issues":145,"watchers":5097,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scrapy/scrapy/pulls/766"},"html":{"href":"https://github.com/scrapy/scrapy/pull/766"},"issue":{"href":"https://api.github.com/repos/scrapy/scrapy/issues/766"},"comments":{"href":"https://api.github.com/repos/scrapy/scrapy/issues/766/comments"},"review_comments":{"href":"https://api.github.com/repos/scrapy/scrapy/pulls/766/comments"},"review_comment":{"href":"https://api.github.com/repos/scrapy/scrapy/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/scrapy/scrapy/pulls/766/commits"},"statuses":{"href":"https://api.github.com/repos/scrapy/scrapy/statuses/e0b0f64cf427e462b3230c7dab75aeb93774f78d"}}}}