GitHub PullRequestReviewCommentEvent at 2014-06-24 20:13:44
Repository: neighborhoods
Actor: houndci
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/LaunchAcademy/neighborhoods/pulls/comments/14152122","id":14152122,"diff_hunk":"@@ -0,0 +1,78 @@\n+require 'rails_helper'\n+\n+  feature 'user signs up or registers', %Q{\n+    As a user\n+    I want to sign up\n+    So that I can review some neighborhoods\n+\n+  } do\n+\n+    # Acceptance Criteria\n+\n+    # I must provide my username/email and password\n+    # I can optionally provide my first name, last name, city, and state\n+    # I am presented with a success message if I sign up successfully\n+\n+\n+    scenario 'user signs up successfully' do\n+      attrs = {\n+        email: \"dog@face.com\",\n+        password: \"Secret12345\",\n+        password_confirmation: \"Secret12345\"\n+      }\n+\n+      user = User.new(attrs)\n+\n+      visit new_user_registration_path\n+      fill_in 'Email', with: user.email\n+      fill_in 'Password', with: user.password\n+      fill_in 'Password confirmation', with: user.password_confirmation\n+      click_on 'Sign up'\n+\n+      expect(page).to have_content 'Welcome! You have signed up successfully.'\n+\n+    end\n+\n+    scenario 'user gets error message if email missing' do\n+\n+      attrs = {\n+        email: \"\",\n+        password: \"Secret12345\",\n+        password_confirmation: \"Secret12345\"\n+      }\n+\n+      user = User.new(attrs)\n+\n+      visit new_user_registration_path\n+      fill_in 'Email', with: user.email\n+      fill_in 'Password', with: user.password\n+      fill_in 'Password confirmation', with: user.password_confirmation\n+      click_on 'Sign up'\n+\n+      expect(page).not_to have_content 'Welcome! You have signed up successfully.'\n+      expect(page).to have_content 'Email can\\'t be blank'\n+    end\n+\n+    scenario 'user gets error message if password missing' do\n+      attrs = {\n+        email: \"Dogface@gmail.com\",\n+        password: \"\",\n+        password_confirmation: \"\"\n+      }\n+\n+      user = User.new(attrs)\n+\n+      visit new_user_registration_path\n+      fill_in 'Email', with: user.email\n+      fill_in 'Password', with: user.password\n+      fill_in 'Password confirmation', with: user.password_confirmation\n+      click_on 'Sign up'\n+\n+      expect(page).not_to have_content 'Welcome! You have signed up successfully.'\n+      expect(page).to have_content 'Password can\\'t be blank'\n+    end\n+\n+","path":"spec/features/sign_in_test_spec.rb","position":75,"original_position":75,"commit_id":"cf5205a2c6261b958ee1cc4bc430bca99c5bfa02","original_commit_id":"cf5205a2c6261b958ee1cc4bc430bca99c5bfa02","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?","gravatar_id":"38d9cefd9971a05bf447f07c6cd332cc","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Extra blank line detected.","created_at":"2014-06-24T20:13:44Z","updated_at":"2014-06-24T20:13:44Z","html_url":"https://github.com/LaunchAcademy/neighborhoods/pull/22#discussion_r14152122","pull_request_url":"https://api.github.com/repos/LaunchAcademy/neighborhoods/pulls/22","_links":{"self":{"href":"https://api.github.com/repos/LaunchAcademy/neighborhoods/pulls/comments/14152122"},"html":{"href":"https://github.com/LaunchAcademy/neighborhoods/pull/22#discussion_r14152122"},"pull_request":{"href":"https://api.github.com/repos/LaunchAcademy/neighborhoods/pulls/22"}}},"pull_request":{"url":"https://api.github.com/repos/LaunchAcademy/neighborhoods/pulls/22","id":17554391,"html_url":"https://github.com/LaunchAcademy/neighborhoods/pull/22","diff_url":"https://github.com/LaunchAcademy/neighborhoods/pull/22.diff","patch_url":"https://github.com/LaunchAcademy/neighborhoods/pull/22.patch","issue_url":"https://api.github.com/repos/LaunchAcademy/neighborhoods/issues/22","number":22,"state":"open","title":"User Authentication with Devise","user":{"login":"ooofinooo","id":5788358,"avatar_url":"https://avatars.githubusercontent.com/u/5788358?","gravatar_id":"3cda973a1afc9daea842ba5425080ae2","url":"https://api.github.com/users/ooofinooo","html_url":"https://github.com/ooofinooo","followers_url":"https://api.github.com/users/ooofinooo/followers","following_url":"https://api.github.com/users/ooofinooo/following{/other_user}","gists_url":"https://api.github.com/users/ooofinooo/gists{/gist_id}","starred_url":"https://api.github.com/users/ooofinooo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ooofinooo/subscriptions","organizations_url":"https://api.github.com/users/ooofinooo/orgs","repos_url":"https://api.github.com/users/ooofinooo/repos","events_url":"https://api.github.com/users/ooofinooo/events{/privacy}","received_events_url":"https://api.github.com/users/ooofinooo/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-06-24T20:08:20Z","updated_at":"2014-06-24T20:13:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b5d3ba5ca6496ada99d7a223abb6973a3468fd03","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/LaunchAcademy/neighborhoods/pulls/22/commits","review_comments_url":"https://api.github.com/repos/LaunchAcademy/neighborhoods/pulls/22/comments","review_comment_url":"https://api.github.com/repos/LaunchAcademy/neighborhoods/pulls/comments/{number}","comments_url":"https://api.github.com/repos/LaunchAcademy/neighborhoods/issues/22/comments","statuses_url":"https://api.github.com/repos/LaunchAcademy/neighborhoods/statuses/cf5205a2c6261b958ee1cc4bc430bca99c5bfa02","head":{"label":"LaunchAcademy:devise","ref":"devise","sha":"cf5205a2c6261b958ee1cc4bc430bca99c5bfa02","user":{"login":"LaunchAcademy","id":3612691,"avatar_url":"https://avatars.githubusercontent.com/u/3612691?","gravatar_id":"3996dda93bb2ce2013929378c9ecff8d","url":"https://api.github.com/users/LaunchAcademy","html_url":"https://github.com/LaunchAcademy","followers_url":"https://api.github.com/users/LaunchAcademy/followers","following_url":"https://api.github.com/users/LaunchAcademy/following{/other_user}","gists_url":"https://api.github.com/users/LaunchAcademy/gists{/gist_id}","starred_url":"https://api.github.com/users/LaunchAcademy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LaunchAcademy/subscriptions","organizations_url":"https://api.github.com/users/LaunchAcademy/orgs","repos_url":"https://api.github.com/users/LaunchAcademy/repos","events_url":"https://api.github.com/users/LaunchAcademy/events{/privacy}","received_events_url":"https://api.github.com/users/LaunchAcademy/received_events","type":"Organization","site_admin":false},"repo":{"id":21136834,"name":"neighborhoods","full_name":"LaunchAcademy/neighborhoods","owner":{"login":"LaunchAcademy","id":3612691,"avatar_url":"https://avatars.githubusercontent.com/u/3612691?","gravatar_id":"3996dda93bb2ce2013929378c9ecff8d","url":"https://api.github.com/users/LaunchAcademy","html_url":"https://github.com/LaunchAcademy","followers_url":"https://api.github.com/users/LaunchAcademy/followers","following_url":"https://api.github.com/users/LaunchAcademy/following{/other_user}","gists_url":"https://api.github.com/users/LaunchAcademy/gists{/gist_id}","starred_url":"https://api.github.com/users/LaunchAcademy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LaunchAcademy/subscriptions","organizations_url":"https://api.github.com/users/LaunchAcademy/orgs","repos_url":"https://api.github.com/users/LaunchAcademy/repos","events_url":"https://api.github.com/users/LaunchAcademy/events{/privacy}","received_events_url":"https://api.github.com/users/LaunchAcademy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LaunchAcademy/neighborhoods","description":"","fork":false,"url":"https://api.github.com/repos/LaunchAcademy/neighborhoods","forks_url":"https://api.github.com/repos/LaunchAcademy/neighborhoods/forks","keys_url":"https://api.github.com/repos/LaunchAcademy/neighborhoods/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LaunchAcademy/neighborhoods/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LaunchAcademy/neighborhoods/teams","hooks_url":"https://api.github.com/repos/LaunchAcademy/neighborhoods/hooks","issue_events_url":"https://api.github.com/repos/LaunchAcademy/neighborhoods/issues/events{/number}","events_url":"https://api.github.com/repos/LaunchAcademy/neighborhoods/events","assignees_url":"https://api.github.com/repos/LaunchAcademy/neighborhoods/assignees{/user}","branches_url":"https://api.github.com/repos/LaunchAcademy/neighborhoods/branches{/branch}","tags_url":"https://api.github.com/repos/LaunchAcademy/neighborhoods/tags","blobs_url":"https://api.github.com/repos/LaunchAcademy/neighborhoods/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LaunchAcademy/neighborhoods/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LaunchAcademy/neighborhoods/git/refs{/sha}","trees_url":"https://api.github.com/repos/LaunchAcademy/neighborhoods/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LaunchAcademy/neighborhoods/statuses/{sha}","languages_url":"https://api.github.com/repos/LaunchAcademy/neighborhoods/languages","stargazers_url":"https://api.github.com/repos/LaunchAcademy/neighborhoods/stargazers","contributors_url":"https://api.github.com/repos/LaunchAcademy/neighborhoods/contributors","subscribers_url":"https://api.github.com/repos/LaunchAcademy/neighborhoods/subscribers","subscription_url":"https://api.github.com/repos/LaunchAcademy/neighborhoods/subscription","commits_url":"https://api.github.com/repos/LaunchAcademy/neighborhoods/commits{/sha}","git_commits_url":"https://api.github.com/repos/LaunchAcademy/neighborhoods/git/commits{/sha}","comments_url":"https://api.github.com/repos/LaunchAcademy/neighborhoods/comments{/number}","issue_comment_url":"https://api.github.com/repos/LaunchAcademy/neighborhoods/issues/comments/{number}","contents_url":"https://api.github.com/repos/LaunchAcademy/neighborhoods/contents/{+path}","compare_url":"https://api.github.com/repos/LaunchAcademy/neighborhoods/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LaunchAcademy/neighborhoods/merges","archive_url":"https://api.github.com/repos/LaunchAcademy/neighborhoods/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LaunchAcademy/neighborhoods/downloads","issues_url":"https://api.github.com/repos/LaunchAcademy/neighborhoods/issues{/number}","pulls_url":"https://api.github.com/repos/LaunchAcademy/neighborhoods/pulls{/number}","milestones_url":"https://api.github.com/repos/LaunchAcademy/neighborhoods/milestones{/number}","notifications_url":"https://api.github.com/repos/LaunchAcademy/neighborhoods/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LaunchAcademy/neighborhoods/labels{/name}","releases_url":"https://api.github.com/repos/LaunchAcademy/neighborhoods/releases{/id}","created_at":"2014-06-23T18:08:21Z","updated_at":"2014-06-24T20:13:34Z","pushed_at":"2014-06-24T20:13:34Z","git_url":"git://github.com/LaunchAcademy/neighborhoods.git","ssh_url":"git@github.com:LaunchAcademy/neighborhoods.git","clone_url":"https://github.com/LaunchAcademy/neighborhoods.git","svn_url":"https://github.com/LaunchAcademy/neighborhoods","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":17,"forks":0,"open_issues":17,"watchers":0,"default_branch":"master"}},"base":{"label":"LaunchAcademy:master","ref":"master","sha":"10f5de667c7e4ddad33b96215951df513cdb1661","user":{"login":"LaunchAcademy","id":3612691,"avatar_url":"https://avatars.githubusercontent.com/u/3612691?","gravatar_id":"3996dda93bb2ce2013929378c9ecff8d","url":"https://api.github.com/users/LaunchAcademy","html_url":"https://github.com/LaunchAcademy","followers_url":"https://api.github.com/users/LaunchAcademy/followers","following_url":"https://api.github.com/users/LaunchAcademy/following{/other_user}","gists_url":"https://api.github.com/users/LaunchAcademy/gists{/gist_id}","starred_url":"https://api.github.com/users/LaunchAcademy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LaunchAcademy/subscriptions","organizations_url":"https://api.github.com/users/LaunchAcademy/orgs","repos_url":"https://api.github.com/users/LaunchAcademy/repos","events_url":"https://api.github.com/users/LaunchAcademy/events{/privacy}","received_events_url":"https://api.github.com/users/LaunchAcademy/received_events","type":"Organization","site_admin":false},"repo":{"id":21136834,"name":"neighborhoods","full_name":"LaunchAcademy/neighborhoods","owner":{"login":"LaunchAcademy","id":3612691,"avatar_url":"https://avatars.githubusercontent.com/u/3612691?","gravatar_id":"3996dda93bb2ce2013929378c9ecff8d","url":"https://api.github.com/users/LaunchAcademy","html_url":"https://github.com/LaunchAcademy","followers_url":"https://api.github.com/users/LaunchAcademy/followers","following_url":"https://api.github.com/users/LaunchAcademy/following{/other_user}","gists_url":"https://api.github.com/users/LaunchAcademy/gists{/gist_id}","starred_url":"https://api.github.com/users/LaunchAcademy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LaunchAcademy/subscriptions","organizations_url":"https://api.github.com/users/LaunchAcademy/orgs","repos_url":"https://api.github.com/users/LaunchAcademy/repos","events_url":"https://api.github.com/users/LaunchAcademy/events{/privacy}","received_events_url":"https://api.github.com/users/LaunchAcademy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LaunchAcademy/neighborhoods","description":"","fork":false,"url":"https://api.github.com/repos/LaunchAcademy/neighborhoods","forks_url":"https://api.github.com/repos/LaunchAcademy/neighborhoods/forks","keys_url":"https://api.github.com/repos/LaunchAcademy/neighborhoods/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LaunchAcademy/neighborhoods/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LaunchAcademy/neighborhoods/teams","hooks_url":"https://api.github.com/repos/LaunchAcademy/neighborhoods/hooks","issue_events_url":"https://api.github.com/repos/LaunchAcademy/neighborhoods/issues/events{/number}","events_url":"https://api.github.com/repos/LaunchAcademy/neighborhoods/events","assignees_url":"https://api.github.com/repos/LaunchAcademy/neighborhoods/assignees{/user}","branches_url":"https://api.github.com/repos/LaunchAcademy/neighborhoods/branches{/branch}","tags_url":"https://api.github.com/repos/LaunchAcademy/neighborhoods/tags","blobs_url":"https://api.github.com/repos/LaunchAcademy/neighborhoods/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LaunchAcademy/neighborhoods/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LaunchAcademy/neighborhoods/git/refs{/sha}","trees_url":"https://api.github.com/repos/LaunchAcademy/neighborhoods/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LaunchAcademy/neighborhoods/statuses/{sha}","languages_url":"https://api.github.com/repos/LaunchAcademy/neighborhoods/languages","stargazers_url":"https://api.github.com/repos/LaunchAcademy/neighborhoods/stargazers","contributors_url":"https://api.github.com/repos/LaunchAcademy/neighborhoods/contributors","subscribers_url":"https://api.github.com/repos/LaunchAcademy/neighborhoods/subscribers","subscription_url":"https://api.github.com/repos/LaunchAcademy/neighborhoods/subscription","commits_url":"https://api.github.com/repos/LaunchAcademy/neighborhoods/commits{/sha}","git_commits_url":"https://api.github.com/repos/LaunchAcademy/neighborhoods/git/commits{/sha}","comments_url":"https://api.github.com/repos/LaunchAcademy/neighborhoods/comments{/number}","issue_comment_url":"https://api.github.com/repos/LaunchAcademy/neighborhoods/issues/comments/{number}","contents_url":"https://api.github.com/repos/LaunchAcademy/neighborhoods/contents/{+path}","compare_url":"https://api.github.com/repos/LaunchAcademy/neighborhoods/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LaunchAcademy/neighborhoods/merges","archive_url":"https://api.github.com/repos/LaunchAcademy/neighborhoods/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LaunchAcademy/neighborhoods/downloads","issues_url":"https://api.github.com/repos/LaunchAcademy/neighborhoods/issues{/number}","pulls_url":"https://api.github.com/repos/LaunchAcademy/neighborhoods/pulls{/number}","milestones_url":"https://api.github.com/repos/LaunchAcademy/neighborhoods/milestones{/number}","notifications_url":"https://api.github.com/repos/LaunchAcademy/neighborhoods/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LaunchAcademy/neighborhoods/labels{/name}","releases_url":"https://api.github.com/repos/LaunchAcademy/neighborhoods/releases{/id}","created_at":"2014-06-23T18:08:21Z","updated_at":"2014-06-24T20:13:34Z","pushed_at":"2014-06-24T20:13:34Z","git_url":"git://github.com/LaunchAcademy/neighborhoods.git","ssh_url":"git@github.com:LaunchAcademy/neighborhoods.git","clone_url":"https://github.com/LaunchAcademy/neighborhoods.git","svn_url":"https://github.com/LaunchAcademy/neighborhoods","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":17,"forks":0,"open_issues":17,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/LaunchAcademy/neighborhoods/pulls/22"},"html":{"href":"https://github.com/LaunchAcademy/neighborhoods/pull/22"},"issue":{"href":"https://api.github.com/repos/LaunchAcademy/neighborhoods/issues/22"},"comments":{"href":"https://api.github.com/repos/LaunchAcademy/neighborhoods/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/LaunchAcademy/neighborhoods/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/LaunchAcademy/neighborhoods/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/LaunchAcademy/neighborhoods/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/LaunchAcademy/neighborhoods/statuses/cf5205a2c6261b958ee1cc4bc430bca99c5bfa02"}}}}