GitHub PullRequestReviewCommentEvent at 2014-04-30 08:41:32
Repository: NelmioApiDocBundle
Actor: stof
Payload: {"comment":{"url":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/pulls/comments/12133483","id":12133483,"diff_hunk":"@@ -206,23 +206,45 @@ protected function parseConstraint(Constraint $constraint, $vparams, $className,\n                 foreach ($constraint->constraints as $childConstraint) {\n                     if ($childConstraint instanceof Type) {\n                         $nestedType = $childConstraint->type;\n-                        $exp = explode(\"\\\\\", $nestedType);\n-                        if (!class_exists($nestedType)) {\n-                            $nestedType = substr($className, 0, strrpos($className, '\\\\') + 1).$nestedType;\n \n+                        $type = strtolower($nestedType);\n+                        $type = $type == 'boolean' ? 'bool' : $nestedType;\n+                        $isFunction = 'is_'.$type;\n+                        $ctypeFunction = 'ctype_'.$type;\n+\n+                        if (function_exists($isFunction) or function_exists($ctypeFunction)) {","path":"Parser/ValidationParser.php","position":13,"original_position":13,"commit_id":"9f56191793293b07ce7afadf3b6eff8495d8bcd9","original_commit_id":"9f56191793293b07ce7afadf3b6eff8495d8bcd9","user":{"login":"stof","id":439401,"avatar_url":"https://avatars.githubusercontent.com/u/439401?","gravatar_id":"7894bbdf1c05b18a1444ad8c76c9d583","url":"https://api.github.com/users/stof","html_url":"https://github.com/stof","followers_url":"https://api.github.com/users/stof/followers","following_url":"https://api.github.com/users/stof/following{/other_user}","gists_url":"https://api.github.com/users/stof/gists{/gist_id}","starred_url":"https://api.github.com/users/stof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stof/subscriptions","organizations_url":"https://api.github.com/users/stof/orgs","repos_url":"https://api.github.com/users/stof/repos","events_url":"https://api.github.com/users/stof/events{/privacy}","received_events_url":"https://api.github.com/users/stof/received_events","type":"User","site_admin":false},"body":"should be ``||``, not ``or``","created_at":"2014-04-30T08:41:32Z","updated_at":"2014-04-30T08:41:32Z","html_url":"https://github.com/nelmio/NelmioApiDocBundle/pull/374#discussion_r12133483","pull_request_url":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/pulls/374","_links":{"self":{"href":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/pulls/comments/12133483"},"html":{"href":"https://github.com/nelmio/NelmioApiDocBundle/pull/374#discussion_r12133483"},"pull_request":{"href":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/pulls/374"}}}}