GitHub PullRequestEvent at 2014-04-22 12:46:09
Repository: ClanLib
Actor: punkkeks
Payload: {"action":"opened","number":14,"pull_request":{"url":"https://api.github.com/repos/sphair/ClanLib/pulls/14","id":15010645,"html_url":"https://github.com/sphair/ClanLib/pull/14","diff_url":"https://github.com/sphair/ClanLib/pull/14.diff","patch_url":"https://github.com/sphair/ClanLib/pull/14.patch","issue_url":"https://api.github.com/repos/sphair/ClanLib/issues/14","number":14,"state":"open","title":"Signal.callback","user":{"login":"punkkeks","id":921462,"avatar_url":"https://avatars.githubusercontent.com/u/921462?","gravatar_id":"8a0334a3e4ee5149b54e95504afe5239","url":"https://api.github.com/users/punkkeks","html_url":"https://github.com/punkkeks","followers_url":"https://api.github.com/users/punkkeks/followers","following_url":"https://api.github.com/users/punkkeks/following{/other_user}","gists_url":"https://api.github.com/users/punkkeks/gists{/gist_id}","starred_url":"https://api.github.com/users/punkkeks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/punkkeks/subscriptions","organizations_url":"https://api.github.com/users/punkkeks/orgs","repos_url":"https://api.github.com/users/punkkeks/repos","events_url":"https://api.github.com/users/punkkeks/events{/privacy}","received_events_url":"https://api.github.com/users/punkkeks/received_events","type":"User","site_admin":false},"body":"\r\nI used some c++11 magic and renewed the signal and callback classes. They are now classes with variadic templates and accept as many arguments as possible.\r\nAlso removed the Slot(-container) class, because it's useless in my opinion.\r\nMaybe some documentation could be made.\r\n\r\nI know that this is a big cut, because I removed the Slot class, but really, you don't need it. I understand if you don't accept the new signal class, but at least the callback thing - commit 6e9a8e2, a8cdc7f, f5d02b3, d060716, 9ec1533 - aren't breaking any API (at least it shouldn't).\r\nLet me hear your doubt about it.\r\n","created_at":"2014-04-22T12:46:09Z","updated_at":"2014-04-22T12:46:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sphair/ClanLib/pulls/14/commits","review_comments_url":"https://api.github.com/repos/sphair/ClanLib/pulls/14/comments","review_comment_url":"https://api.github.com/repos/sphair/ClanLib/pulls/comments/{number}","comments_url":"https://api.github.com/repos/sphair/ClanLib/issues/14/comments","statuses_url":"https://api.github.com/repos/sphair/ClanLib/statuses/1a466f0a071ec92d370f49fb69f783c187c87dd6","head":{"label":"punkkeks:signal.callback","ref":"signal.callback","sha":"1a466f0a071ec92d370f49fb69f783c187c87dd6","user":{"login":"punkkeks","id":921462,"avatar_url":"https://avatars.githubusercontent.com/u/921462?","gravatar_id":"8a0334a3e4ee5149b54e95504afe5239","url":"https://api.github.com/users/punkkeks","html_url":"https://github.com/punkkeks","followers_url":"https://api.github.com/users/punkkeks/followers","following_url":"https://api.github.com/users/punkkeks/following{/other_user}","gists_url":"https://api.github.com/users/punkkeks/gists{/gist_id}","starred_url":"https://api.github.com/users/punkkeks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/punkkeks/subscriptions","organizations_url":"https://api.github.com/users/punkkeks/orgs","repos_url":"https://api.github.com/users/punkkeks/repos","events_url":"https://api.github.com/users/punkkeks/events{/privacy}","received_events_url":"https://api.github.com/users/punkkeks/received_events","type":"User","site_admin":false},"repo":{"id":18965578,"name":"ClanLib","full_name":"punkkeks/ClanLib","owner":{"login":"punkkeks","id":921462,"avatar_url":"https://avatars.githubusercontent.com/u/921462?","gravatar_id":"8a0334a3e4ee5149b54e95504afe5239","url":"https://api.github.com/users/punkkeks","html_url":"https://github.com/punkkeks","followers_url":"https://api.github.com/users/punkkeks/followers","following_url":"https://api.github.com/users/punkkeks/following{/other_user}","gists_url":"https://api.github.com/users/punkkeks/gists{/gist_id}","starred_url":"https://api.github.com/users/punkkeks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/punkkeks/subscriptions","organizations_url":"https://api.github.com/users/punkkeks/orgs","repos_url":"https://api.github.com/users/punkkeks/repos","events_url":"https://api.github.com/users/punkkeks/events{/privacy}","received_events_url":"https://api.github.com/users/punkkeks/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/punkkeks/ClanLib","description":"ClanLib is a cross platform C++ toolkit library.","fork":true,"url":"https://api.github.com/repos/punkkeks/ClanLib","forks_url":"https://api.github.com/repos/punkkeks/ClanLib/forks","keys_url":"https://api.github.com/repos/punkkeks/ClanLib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/punkkeks/ClanLib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/punkkeks/ClanLib/teams","hooks_url":"https://api.github.com/repos/punkkeks/ClanLib/hooks","issue_events_url":"https://api.github.com/repos/punkkeks/ClanLib/issues/events{/number}","events_url":"https://api.github.com/repos/punkkeks/ClanLib/events","assignees_url":"https://api.github.com/repos/punkkeks/ClanLib/assignees{/user}","branches_url":"https://api.github.com/repos/punkkeks/ClanLib/branches{/branch}","tags_url":"https://api.github.com/repos/punkkeks/ClanLib/tags","blobs_url":"https://api.github.com/repos/punkkeks/ClanLib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/punkkeks/ClanLib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/punkkeks/ClanLib/git/refs{/sha}","trees_url":"https://api.github.com/repos/punkkeks/ClanLib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/punkkeks/ClanLib/statuses/{sha}","languages_url":"https://api.github.com/repos/punkkeks/ClanLib/languages","stargazers_url":"https://api.github.com/repos/punkkeks/ClanLib/stargazers","contributors_url":"https://api.github.com/repos/punkkeks/ClanLib/contributors","subscribers_url":"https://api.github.com/repos/punkkeks/ClanLib/subscribers","subscription_url":"https://api.github.com/repos/punkkeks/ClanLib/subscription","commits_url":"https://api.github.com/repos/punkkeks/ClanLib/commits{/sha}","git_commits_url":"https://api.github.com/repos/punkkeks/ClanLib/git/commits{/sha}","comments_url":"https://api.github.com/repos/punkkeks/ClanLib/comments{/number}","issue_comment_url":"https://api.github.com/repos/punkkeks/ClanLib/issues/comments/{number}","contents_url":"https://api.github.com/repos/punkkeks/ClanLib/contents/{+path}","compare_url":"https://api.github.com/repos/punkkeks/ClanLib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/punkkeks/ClanLib/merges","archive_url":"https://api.github.com/repos/punkkeks/ClanLib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/punkkeks/ClanLib/downloads","issues_url":"https://api.github.com/repos/punkkeks/ClanLib/issues{/number}","pulls_url":"https://api.github.com/repos/punkkeks/ClanLib/pulls{/number}","milestones_url":"https://api.github.com/repos/punkkeks/ClanLib/milestones{/number}","notifications_url":"https://api.github.com/repos/punkkeks/ClanLib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/punkkeks/ClanLib/labels{/name}","releases_url":"https://api.github.com/repos/punkkeks/ClanLib/releases{/id}","created_at":"2014-04-20T14:05:21Z","updated_at":"2014-04-22T12:46:09Z","pushed_at":"2014-04-22T12:44:52Z","git_url":"git://github.com/punkkeks/ClanLib.git","ssh_url":"git@github.com:punkkeks/ClanLib.git","clone_url":"https://github.com/punkkeks/ClanLib.git","svn_url":"https://github.com/punkkeks/ClanLib","homepage":"http://www.clanlib.org","size":58485,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sphair:master","ref":"master","sha":"ec7ba0c42ba37fad6cca5c9ea274abf8c4cf6dad","user":{"login":"sphair","id":139314,"avatar_url":"https://avatars.githubusercontent.com/u/139314?","gravatar_id":"9dbfff9fdd1f33c48cecc41085a27016","url":"https://api.github.com/users/sphair","html_url":"https://github.com/sphair","followers_url":"https://api.github.com/users/sphair/followers","following_url":"https://api.github.com/users/sphair/following{/other_user}","gists_url":"https://api.github.com/users/sphair/gists{/gist_id}","starred_url":"https://api.github.com/users/sphair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sphair/subscriptions","organizations_url":"https://api.github.com/users/sphair/orgs","repos_url":"https://api.github.com/users/sphair/repos","events_url":"https://api.github.com/users/sphair/events{/privacy}","received_events_url":"https://api.github.com/users/sphair/received_events","type":"User","site_admin":false},"repo":{"id":10379062,"name":"ClanLib","full_name":"sphair/ClanLib","owner":{"login":"sphair","id":139314,"avatar_url":"https://avatars.githubusercontent.com/u/139314?","gravatar_id":"9dbfff9fdd1f33c48cecc41085a27016","url":"https://api.github.com/users/sphair","html_url":"https://github.com/sphair","followers_url":"https://api.github.com/users/sphair/followers","following_url":"https://api.github.com/users/sphair/following{/other_user}","gists_url":"https://api.github.com/users/sphair/gists{/gist_id}","starred_url":"https://api.github.com/users/sphair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sphair/subscriptions","organizations_url":"https://api.github.com/users/sphair/orgs","repos_url":"https://api.github.com/users/sphair/repos","events_url":"https://api.github.com/users/sphair/events{/privacy}","received_events_url":"https://api.github.com/users/sphair/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sphair/ClanLib","description":"ClanLib is a cross platform C++ toolkit library.","fork":false,"url":"https://api.github.com/repos/sphair/ClanLib","forks_url":"https://api.github.com/repos/sphair/ClanLib/forks","keys_url":"https://api.github.com/repos/sphair/ClanLib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sphair/ClanLib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sphair/ClanLib/teams","hooks_url":"https://api.github.com/repos/sphair/ClanLib/hooks","issue_events_url":"https://api.github.com/repos/sphair/ClanLib/issues/events{/number}","events_url":"https://api.github.com/repos/sphair/ClanLib/events","assignees_url":"https://api.github.com/repos/sphair/ClanLib/assignees{/user}","branches_url":"https://api.github.com/repos/sphair/ClanLib/branches{/branch}","tags_url":"https://api.github.com/repos/sphair/ClanLib/tags","blobs_url":"https://api.github.com/repos/sphair/ClanLib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sphair/ClanLib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sphair/ClanLib/git/refs{/sha}","trees_url":"https://api.github.com/repos/sphair/ClanLib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sphair/ClanLib/statuses/{sha}","languages_url":"https://api.github.com/repos/sphair/ClanLib/languages","stargazers_url":"https://api.github.com/repos/sphair/ClanLib/stargazers","contributors_url":"https://api.github.com/repos/sphair/ClanLib/contributors","subscribers_url":"https://api.github.com/repos/sphair/ClanLib/subscribers","subscription_url":"https://api.github.com/repos/sphair/ClanLib/subscription","commits_url":"https://api.github.com/repos/sphair/ClanLib/commits{/sha}","git_commits_url":"https://api.github.com/repos/sphair/ClanLib/git/commits{/sha}","comments_url":"https://api.github.com/repos/sphair/ClanLib/comments{/number}","issue_comment_url":"https://api.github.com/repos/sphair/ClanLib/issues/comments/{number}","contents_url":"https://api.github.com/repos/sphair/ClanLib/contents/{+path}","compare_url":"https://api.github.com/repos/sphair/ClanLib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sphair/ClanLib/merges","archive_url":"https://api.github.com/repos/sphair/ClanLib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sphair/ClanLib/downloads","issues_url":"https://api.github.com/repos/sphair/ClanLib/issues{/number}","pulls_url":"https://api.github.com/repos/sphair/ClanLib/pulls{/number}","milestones_url":"https://api.github.com/repos/sphair/ClanLib/milestones{/number}","notifications_url":"https://api.github.com/repos/sphair/ClanLib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sphair/ClanLib/labels{/name}","releases_url":"https://api.github.com/repos/sphair/ClanLib/releases{/id}","created_at":"2013-05-30T08:52:36Z","updated_at":"2014-04-22T07:21:29Z","pushed_at":"2014-04-22T07:21:28Z","git_url":"git://github.com/sphair/ClanLib.git","ssh_url":"git@github.com:sphair/ClanLib.git","clone_url":"https://github.com/sphair/ClanLib.git","svn_url":"https://github.com/sphair/ClanLib","homepage":"http://www.clanlib.org","size":62765,"stargazers_count":59,"watchers_count":59,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":17,"mirror_url":null,"open_issues_count":1,"forks":17,"open_issues":1,"watchers":59,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sphair/ClanLib/pulls/14"},"html":{"href":"https://github.com/sphair/ClanLib/pull/14"},"issue":{"href":"https://api.github.com/repos/sphair/ClanLib/issues/14"},"comments":{"href":"https://api.github.com/repos/sphair/ClanLib/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/sphair/ClanLib/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/sphair/ClanLib/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/sphair/ClanLib/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/sphair/ClanLib/statuses/1a466f0a071ec92d370f49fb69f783c187c87dd6"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":14,"additions":507,"deletions":5123,"changed_files":111}}