GitHub PullRequestReviewCommentEvent at 2014-11-12 17:52:11
Repository: openshift-origin-cartridge-aerogear-push
Actor: bparees
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/aerogear/openshift-origin-cartridge-aerogear-push/pulls/comments/20236309","id":20236309,"diff_hunk":"@@ -553,7 +553,7 @@\n     </interfaces>\n \n     <socket-binding-group name=\"standard-sockets\" default-interface=\"public\" port-offset=\"0\">\n-        <socket-binding name=\"http\" port=\"8080\"/>\n+        <socket-binding name=\"https\" port=\"${jboss.https.port:8443}\"/>","path":"versions/1.0.2/standalone/configuration/standalone.xml","position":5,"original_position":5,"commit_id":"84e7f0f174939dabe264e022b44402626f5e35c9","original_commit_id":"84e7f0f174939dabe264e022b44402626f5e35c9","user":{"login":"bparees","id":4974046,"avatar_url":"https://avatars.githubusercontent.com/u/4974046?v=3","gravatar_id":"","url":"https://api.github.com/users/bparees","html_url":"https://github.com/bparees","followers_url":"https://api.github.com/users/bparees/followers","following_url":"https://api.github.com/users/bparees/following{/other_user}","gists_url":"https://api.github.com/users/bparees/gists{/gist_id}","starred_url":"https://api.github.com/users/bparees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bparees/subscriptions","organizations_url":"https://api.github.com/users/bparees/orgs","repos_url":"https://api.github.com/users/bparees/repos","events_url":"https://api.github.com/users/bparees/events{/privacy}","received_events_url":"https://api.github.com/users/bparees/received_events","type":"User","site_admin":false},"body":"I don't think this really matters since we terminate SSL at the proxy.\r\n","created_at":"2014-11-12T17:52:11Z","updated_at":"2014-11-12T17:52:11Z","html_url":"https://github.com/aerogear/openshift-origin-cartridge-aerogear-push/pull/27#discussion_r20236309","pull_request_url":"https://api.github.com/repos/aerogear/openshift-origin-cartridge-aerogear-push/pulls/27","_links":{"self":{"href":"https://api.github.com/repos/aerogear/openshift-origin-cartridge-aerogear-push/pulls/comments/20236309"},"html":{"href":"https://github.com/aerogear/openshift-origin-cartridge-aerogear-push/pull/27#discussion_r20236309"},"pull_request":{"href":"https://api.github.com/repos/aerogear/openshift-origin-cartridge-aerogear-push/pulls/27"}}},"pull_request":{"url":"https://api.github.com/repos/aerogear/openshift-origin-cartridge-aerogear-push/pulls/27","id":24304691,"html_url":"https://github.com/aerogear/openshift-origin-cartridge-aerogear-push/pull/27","diff_url":"https://github.com/aerogear/openshift-origin-cartridge-aerogear-push/pull/27.diff","patch_url":"https://github.com/aerogear/openshift-origin-cartridge-aerogear-push/pull/27.patch","issue_url":"https://api.github.com/repos/aerogear/openshift-origin-cartridge-aerogear-push/issues/27","number":27,"state":"open","locked":false,"title":"Https enforcement","user":{"login":"vibe13","id":6085861,"avatar_url":"https://avatars.githubusercontent.com/u/6085861?v=3","gravatar_id":"","url":"https://api.github.com/users/vibe13","html_url":"https://github.com/vibe13","followers_url":"https://api.github.com/users/vibe13/followers","following_url":"https://api.github.com/users/vibe13/following{/other_user}","gists_url":"https://api.github.com/users/vibe13/gists{/gist_id}","starred_url":"https://api.github.com/users/vibe13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vibe13/subscriptions","organizations_url":"https://api.github.com/users/vibe13/orgs","repos_url":"https://api.github.com/users/vibe13/repos","events_url":"https://api.github.com/users/vibe13/events{/privacy}","received_events_url":"https://api.github.com/users/vibe13/received_events","type":"User","site_admin":false},"body":"Added enforcement of https. \r\n@lfryc @abstractj @matzew @bparees  mind to check? Thanks!","created_at":"2014-11-12T16:25:38Z","updated_at":"2014-11-12T17:52:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"09ad7c1eaecc97a81a8dedb4ce320f37fc85872c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/aerogear/openshift-origin-cartridge-aerogear-push/pulls/27/commits","review_comments_url":"https://api.github.com/repos/aerogear/openshift-origin-cartridge-aerogear-push/pulls/27/comments","review_comment_url":"https://api.github.com/repos/aerogear/openshift-origin-cartridge-aerogear-push/pulls/comments/{number}","comments_url":"https://api.github.com/repos/aerogear/openshift-origin-cartridge-aerogear-push/issues/27/comments","statuses_url":"https://api.github.com/repos/aerogear/openshift-origin-cartridge-aerogear-push/statuses/84e7f0f174939dabe264e022b44402626f5e35c9","head":{"label":"vibe13:https_enforcement","ref":"https_enforcement","sha":"84e7f0f174939dabe264e022b44402626f5e35c9","user":{"login":"vibe13","id":6085861,"avatar_url":"https://avatars.githubusercontent.com/u/6085861?v=3","gravatar_id":"","url":"https://api.github.com/users/vibe13","html_url":"https://github.com/vibe13","followers_url":"https://api.github.com/users/vibe13/followers","following_url":"https://api.github.com/users/vibe13/following{/other_user}","gists_url":"https://api.github.com/users/vibe13/gists{/gist_id}","starred_url":"https://api.github.com/users/vibe13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vibe13/subscriptions","organizations_url":"https://api.github.com/users/vibe13/orgs","repos_url":"https://api.github.com/users/vibe13/repos","events_url":"https://api.github.com/users/vibe13/events{/privacy}","received_events_url":"https://api.github.com/users/vibe13/received_events","type":"User","site_admin":false},"repo":{"id":26544737,"name":"openshift-origin-cartridge-aerogear-push","full_name":"vibe13/openshift-origin-cartridge-aerogear-push","owner":{"login":"vibe13","id":6085861,"avatar_url":"https://avatars.githubusercontent.com/u/6085861?v=3","gravatar_id":"","url":"https://api.github.com/users/vibe13","html_url":"https://github.com/vibe13","followers_url":"https://api.github.com/users/vibe13/followers","following_url":"https://api.github.com/users/vibe13/following{/other_user}","gists_url":"https://api.github.com/users/vibe13/gists{/gist_id}","starred_url":"https://api.github.com/users/vibe13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vibe13/subscriptions","organizations_url":"https://api.github.com/users/vibe13/orgs","repos_url":"https://api.github.com/users/vibe13/repos","events_url":"https://api.github.com/users/vibe13/events{/privacy}","received_events_url":"https://api.github.com/users/vibe13/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vibe13/openshift-origin-cartridge-aerogear-push","description":"","fork":true,"url":"https://api.github.com/repos/vibe13/openshift-origin-cartridge-aerogear-push","forks_url":"https://api.github.com/repos/vibe13/openshift-origin-cartridge-aerogear-push/forks","keys_url":"https://api.github.com/repos/vibe13/openshift-origin-cartridge-aerogear-push/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vibe13/openshift-origin-cartridge-aerogear-push/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vibe13/openshift-origin-cartridge-aerogear-push/teams","hooks_url":"https://api.github.com/repos/vibe13/openshift-origin-cartridge-aerogear-push/hooks","issue_events_url":"https://api.github.com/repos/vibe13/openshift-origin-cartridge-aerogear-push/issues/events{/number}","events_url":"https://api.github.com/repos/vibe13/openshift-origin-cartridge-aerogear-push/events","assignees_url":"https://api.github.com/repos/vibe13/openshift-origin-cartridge-aerogear-push/assignees{/user}","branches_url":"https://api.github.com/repos/vibe13/openshift-origin-cartridge-aerogear-push/branches{/branch}","tags_url":"https://api.github.com/repos/vibe13/openshift-origin-cartridge-aerogear-push/tags","blobs_url":"https://api.github.com/repos/vibe13/openshift-origin-cartridge-aerogear-push/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vibe13/openshift-origin-cartridge-aerogear-push/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vibe13/openshift-origin-cartridge-aerogear-push/git/refs{/sha}","trees_url":"https://api.github.com/repos/vibe13/openshift-origin-cartridge-aerogear-push/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vibe13/openshift-origin-cartridge-aerogear-push/statuses/{sha}","languages_url":"https://api.github.com/repos/vibe13/openshift-origin-cartridge-aerogear-push/languages","stargazers_url":"https://api.github.com/repos/vibe13/openshift-origin-cartridge-aerogear-push/stargazers","contributors_url":"https://api.github.com/repos/vibe13/openshift-origin-cartridge-aerogear-push/contributors","subscribers_url":"https://api.github.com/repos/vibe13/openshift-origin-cartridge-aerogear-push/subscribers","subscription_url":"https://api.github.com/repos/vibe13/openshift-origin-cartridge-aerogear-push/subscription","commits_url":"https://api.github.com/repos/vibe13/openshift-origin-cartridge-aerogear-push/commits{/sha}","git_commits_url":"https://api.github.com/repos/vibe13/openshift-origin-cartridge-aerogear-push/git/commits{/sha}","comments_url":"https://api.github.com/repos/vibe13/openshift-origin-cartridge-aerogear-push/comments{/number}","issue_comment_url":"https://api.github.com/repos/vibe13/openshift-origin-cartridge-aerogear-push/issues/comments/{number}","contents_url":"https://api.github.com/repos/vibe13/openshift-origin-cartridge-aerogear-push/contents/{+path}","compare_url":"https://api.github.com/repos/vibe13/openshift-origin-cartridge-aerogear-push/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vibe13/openshift-origin-cartridge-aerogear-push/merges","archive_url":"https://api.github.com/repos/vibe13/openshift-origin-cartridge-aerogear-push/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vibe13/openshift-origin-cartridge-aerogear-push/downloads","issues_url":"https://api.github.com/repos/vibe13/openshift-origin-cartridge-aerogear-push/issues{/number}","pulls_url":"https://api.github.com/repos/vibe13/openshift-origin-cartridge-aerogear-push/pulls{/number}","milestones_url":"https://api.github.com/repos/vibe13/openshift-origin-cartridge-aerogear-push/milestones{/number}","notifications_url":"https://api.github.com/repos/vibe13/openshift-origin-cartridge-aerogear-push/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vibe13/openshift-origin-cartridge-aerogear-push/labels{/name}","releases_url":"https://api.github.com/repos/vibe13/openshift-origin-cartridge-aerogear-push/releases{/id}","created_at":"2014-11-12T16:23:23Z","updated_at":"2014-11-12T08:47:36Z","pushed_at":"2014-11-12T16:24:05Z","git_url":"git://github.com/vibe13/openshift-origin-cartridge-aerogear-push.git","ssh_url":"git@github.com:vibe13/openshift-origin-cartridge-aerogear-push.git","clone_url":"https://github.com/vibe13/openshift-origin-cartridge-aerogear-push.git","svn_url":"https://github.com/vibe13/openshift-origin-cartridge-aerogear-push","homepage":null,"size":85694,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"aerogear:master","ref":"master","sha":"d238ed10544cbc6227b3753b8e9e35659ae2a23d","user":{"login":"aerogear","id":954205,"avatar_url":"https://avatars.githubusercontent.com/u/954205?v=3","gravatar_id":"","url":"https://api.github.com/users/aerogear","html_url":"https://github.com/aerogear","followers_url":"https://api.github.com/users/aerogear/followers","following_url":"https://api.github.com/users/aerogear/following{/other_user}","gists_url":"https://api.github.com/users/aerogear/gists{/gist_id}","starred_url":"https://api.github.com/users/aerogear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aerogear/subscriptions","organizations_url":"https://api.github.com/users/aerogear/orgs","repos_url":"https://api.github.com/users/aerogear/repos","events_url":"https://api.github.com/users/aerogear/events{/privacy}","received_events_url":"https://api.github.com/users/aerogear/received_events","type":"Organization","site_admin":false},"repo":{"id":12071330,"name":"openshift-origin-cartridge-aerogear-push","full_name":"aerogear/openshift-origin-cartridge-aerogear-push","owner":{"login":"aerogear","id":954205,"avatar_url":"https://avatars.githubusercontent.com/u/954205?v=3","gravatar_id":"","url":"https://api.github.com/users/aerogear","html_url":"https://github.com/aerogear","followers_url":"https://api.github.com/users/aerogear/followers","following_url":"https://api.github.com/users/aerogear/following{/other_user}","gists_url":"https://api.github.com/users/aerogear/gists{/gist_id}","starred_url":"https://api.github.com/users/aerogear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aerogear/subscriptions","organizations_url":"https://api.github.com/users/aerogear/orgs","repos_url":"https://api.github.com/users/aerogear/repos","events_url":"https://api.github.com/users/aerogear/events{/privacy}","received_events_url":"https://api.github.com/users/aerogear/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aerogear/openshift-origin-cartridge-aerogear-push","description":"","fork":false,"url":"https://api.github.com/repos/aerogear/openshift-origin-cartridge-aerogear-push","forks_url":"https://api.github.com/repos/aerogear/openshift-origin-cartridge-aerogear-push/forks","keys_url":"https://api.github.com/repos/aerogear/openshift-origin-cartridge-aerogear-push/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aerogear/openshift-origin-cartridge-aerogear-push/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aerogear/openshift-origin-cartridge-aerogear-push/teams","hooks_url":"https://api.github.com/repos/aerogear/openshift-origin-cartridge-aerogear-push/hooks","issue_events_url":"https://api.github.com/repos/aerogear/openshift-origin-cartridge-aerogear-push/issues/events{/number}","events_url":"https://api.github.com/repos/aerogear/openshift-origin-cartridge-aerogear-push/events","assignees_url":"https://api.github.com/repos/aerogear/openshift-origin-cartridge-aerogear-push/assignees{/user}","branches_url":"https://api.github.com/repos/aerogear/openshift-origin-cartridge-aerogear-push/branches{/branch}","tags_url":"https://api.github.com/repos/aerogear/openshift-origin-cartridge-aerogear-push/tags","blobs_url":"https://api.github.com/repos/aerogear/openshift-origin-cartridge-aerogear-push/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aerogear/openshift-origin-cartridge-aerogear-push/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aerogear/openshift-origin-cartridge-aerogear-push/git/refs{/sha}","trees_url":"https://api.github.com/repos/aerogear/openshift-origin-cartridge-aerogear-push/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aerogear/openshift-origin-cartridge-aerogear-push/statuses/{sha}","languages_url":"https://api.github.com/repos/aerogear/openshift-origin-cartridge-aerogear-push/languages","stargazers_url":"https://api.github.com/repos/aerogear/openshift-origin-cartridge-aerogear-push/stargazers","contributors_url":"https://api.github.com/repos/aerogear/openshift-origin-cartridge-aerogear-push/contributors","subscribers_url":"https://api.github.com/repos/aerogear/openshift-origin-cartridge-aerogear-push/subscribers","subscription_url":"https://api.github.com/repos/aerogear/openshift-origin-cartridge-aerogear-push/subscription","commits_url":"https://api.github.com/repos/aerogear/openshift-origin-cartridge-aerogear-push/commits{/sha}","git_commits_url":"https://api.github.com/repos/aerogear/openshift-origin-cartridge-aerogear-push/git/commits{/sha}","comments_url":"https://api.github.com/repos/aerogear/openshift-origin-cartridge-aerogear-push/comments{/number}","issue_comment_url":"https://api.github.com/repos/aerogear/openshift-origin-cartridge-aerogear-push/issues/comments/{number}","contents_url":"https://api.github.com/repos/aerogear/openshift-origin-cartridge-aerogear-push/contents/{+path}","compare_url":"https://api.github.com/repos/aerogear/openshift-origin-cartridge-aerogear-push/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aerogear/openshift-origin-cartridge-aerogear-push/merges","archive_url":"https://api.github.com/repos/aerogear/openshift-origin-cartridge-aerogear-push/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aerogear/openshift-origin-cartridge-aerogear-push/downloads","issues_url":"https://api.github.com/repos/aerogear/openshift-origin-cartridge-aerogear-push/issues{/number}","pulls_url":"https://api.github.com/repos/aerogear/openshift-origin-cartridge-aerogear-push/pulls{/number}","milestones_url":"https://api.github.com/repos/aerogear/openshift-origin-cartridge-aerogear-push/milestones{/number}","notifications_url":"https://api.github.com/repos/aerogear/openshift-origin-cartridge-aerogear-push/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aerogear/openshift-origin-cartridge-aerogear-push/labels{/name}","releases_url":"https://api.github.com/repos/aerogear/openshift-origin-cartridge-aerogear-push/releases{/id}","created_at":"2013-08-13T02:31:59Z","updated_at":"2014-11-12T08:47:36Z","pushed_at":"2014-11-12T08:48:50Z","git_url":"git://github.com/aerogear/openshift-origin-cartridge-aerogear-push.git","ssh_url":"git@github.com:aerogear/openshift-origin-cartridge-aerogear-push.git","clone_url":"https://github.com/aerogear/openshift-origin-cartridge-aerogear-push.git","svn_url":"https://github.com/aerogear/openshift-origin-cartridge-aerogear-push","homepage":null,"size":85694,"stargazers_count":7,"watchers_count":7,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":2,"forks":19,"open_issues":2,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aerogear/openshift-origin-cartridge-aerogear-push/pulls/27"},"html":{"href":"https://github.com/aerogear/openshift-origin-cartridge-aerogear-push/pull/27"},"issue":{"href":"https://api.github.com/repos/aerogear/openshift-origin-cartridge-aerogear-push/issues/27"},"comments":{"href":"https://api.github.com/repos/aerogear/openshift-origin-cartridge-aerogear-push/issues/27/comments"},"review_comments":{"href":"https://api.github.com/repos/aerogear/openshift-origin-cartridge-aerogear-push/pulls/27/comments"},"review_comment":{"href":"https://api.github.com/repos/aerogear/openshift-origin-cartridge-aerogear-push/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/aerogear/openshift-origin-cartridge-aerogear-push/pulls/27/commits"},"statuses":{"href":"https://api.github.com/repos/aerogear/openshift-origin-cartridge-aerogear-push/statuses/84e7f0f174939dabe264e022b44402626f5e35c9"}}}}