GitHub PullRequestEvent at 2014-11-30 14:45:12
Repository: Quick
Actor: modocache
Payload: {"action":"opened","number":211,"pull_request":{"url":"https://api.github.com/repos/Quick/Quick/pulls/211","id":25235457,"html_url":"https://github.com/Quick/Quick/pull/211","diff_url":"https://github.com/Quick/Quick/pull/211.diff","patch_url":"https://github.com/Quick/Quick/pull/211.patch","issue_url":"https://api.github.com/repos/Quick/Quick/issues/211","number":211,"state":"open","locked":false,"title":"Fix beforeEach execution order","user":{"login":"modocache","id":552921,"avatar_url":"https://avatars.githubusercontent.com/u/552921?v=3","gravatar_id":"","url":"https://api.github.com/users/modocache","html_url":"https://github.com/modocache","followers_url":"https://api.github.com/users/modocache/followers","following_url":"https://api.github.com/users/modocache/following{/other_user}","gists_url":"https://api.github.com/users/modocache/gists{/gist_id}","starred_url":"https://api.github.com/users/modocache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/modocache/subscriptions","organizations_url":"https://api.github.com/users/modocache/orgs","repos_url":"https://api.github.com/users/modocache/repos","events_url":"https://api.github.com/users/modocache/events{/privacy}","received_events_url":"https://api.github.com/users/modocache/received_events","type":"User","site_admin":false},"body":"Fixes #196.\r\n\r\nAlso, this modifies the functional tests for `beforeEach` and `afterEach`--previous tests tested the total number of times closures were called, but not the order in which they were called. This pull request introduces tests for the order as well.\r\n\r\nThis is brittle in that these tests may break when test order shuffling is introduced (see #152)--but when that time comes, shuffling should simply be disabled when running these order-based tests.","created_at":"2014-11-30T14:45:11Z","updated_at":"2014-11-30T14:45:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Quick/Quick/pulls/211/commits","review_comments_url":"https://api.github.com/repos/Quick/Quick/pulls/211/comments","review_comment_url":"https://api.github.com/repos/Quick/Quick/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Quick/Quick/issues/211/comments","statuses_url":"https://api.github.com/repos/Quick/Quick/statuses/64f0b2db1ac98f8dc73fb7c860bf721a37ecd8c1","head":{"label":"modocache:196-correct-xEach-order","ref":"196-correct-xEach-order","sha":"64f0b2db1ac98f8dc73fb7c860bf721a37ecd8c1","user":{"login":"modocache","id":552921,"avatar_url":"https://avatars.githubusercontent.com/u/552921?v=3","gravatar_id":"","url":"https://api.github.com/users/modocache","html_url":"https://github.com/modocache","followers_url":"https://api.github.com/users/modocache/followers","following_url":"https://api.github.com/users/modocache/following{/other_user}","gists_url":"https://api.github.com/users/modocache/gists{/gist_id}","starred_url":"https://api.github.com/users/modocache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/modocache/subscriptions","organizations_url":"https://api.github.com/users/modocache/orgs","repos_url":"https://api.github.com/users/modocache/repos","events_url":"https://api.github.com/users/modocache/events{/privacy}","received_events_url":"https://api.github.com/users/modocache/received_events","type":"User","site_admin":false},"repo":{"id":21603571,"name":"personal-fork-of-Quick","full_name":"modocache/personal-fork-of-Quick","owner":{"login":"modocache","id":552921,"avatar_url":"https://avatars.githubusercontent.com/u/552921?v=3","gravatar_id":"","url":"https://api.github.com/users/modocache","html_url":"https://github.com/modocache","followers_url":"https://api.github.com/users/modocache/followers","following_url":"https://api.github.com/users/modocache/following{/other_user}","gists_url":"https://api.github.com/users/modocache/gists{/gist_id}","starred_url":"https://api.github.com/users/modocache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/modocache/subscriptions","organizations_url":"https://api.github.com/users/modocache/orgs","repos_url":"https://api.github.com/users/modocache/repos","events_url":"https://api.github.com/users/modocache/events{/privacy}","received_events_url":"https://api.github.com/users/modocache/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/modocache/personal-fork-of-Quick","description":"This is a personal fork. Follow the canonical repo at Quick/Quick!","fork":true,"url":"https://api.github.com/repos/modocache/personal-fork-of-Quick","forks_url":"https://api.github.com/repos/modocache/personal-fork-of-Quick/forks","keys_url":"https://api.github.com/repos/modocache/personal-fork-of-Quick/keys{/key_id}","collaborators_url":"https://api.github.com/repos/modocache/personal-fork-of-Quick/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/modocache/personal-fork-of-Quick/teams","hooks_url":"https://api.github.com/repos/modocache/personal-fork-of-Quick/hooks","issue_events_url":"https://api.github.com/repos/modocache/personal-fork-of-Quick/issues/events{/number}","events_url":"https://api.github.com/repos/modocache/personal-fork-of-Quick/events","assignees_url":"https://api.github.com/repos/modocache/personal-fork-of-Quick/assignees{/user}","branches_url":"https://api.github.com/repos/modocache/personal-fork-of-Quick/branches{/branch}","tags_url":"https://api.github.com/repos/modocache/personal-fork-of-Quick/tags","blobs_url":"https://api.github.com/repos/modocache/personal-fork-of-Quick/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/modocache/personal-fork-of-Quick/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/modocache/personal-fork-of-Quick/git/refs{/sha}","trees_url":"https://api.github.com/repos/modocache/personal-fork-of-Quick/git/trees{/sha}","statuses_url":"https://api.github.com/repos/modocache/personal-fork-of-Quick/statuses/{sha}","languages_url":"https://api.github.com/repos/modocache/personal-fork-of-Quick/languages","stargazers_url":"https://api.github.com/repos/modocache/personal-fork-of-Quick/stargazers","contributors_url":"https://api.github.com/repos/modocache/personal-fork-of-Quick/contributors","subscribers_url":"https://api.github.com/repos/modocache/personal-fork-of-Quick/subscribers","subscription_url":"https://api.github.com/repos/modocache/personal-fork-of-Quick/subscription","commits_url":"https://api.github.com/repos/modocache/personal-fork-of-Quick/commits{/sha}","git_commits_url":"https://api.github.com/repos/modocache/personal-fork-of-Quick/git/commits{/sha}","comments_url":"https://api.github.com/repos/modocache/personal-fork-of-Quick/comments{/number}","issue_comment_url":"https://api.github.com/repos/modocache/personal-fork-of-Quick/issues/comments/{number}","contents_url":"https://api.github.com/repos/modocache/personal-fork-of-Quick/contents/{+path}","compare_url":"https://api.github.com/repos/modocache/personal-fork-of-Quick/compare/{base}...{head}","merges_url":"https://api.github.com/repos/modocache/personal-fork-of-Quick/merges","archive_url":"https://api.github.com/repos/modocache/personal-fork-of-Quick/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/modocache/personal-fork-of-Quick/downloads","issues_url":"https://api.github.com/repos/modocache/personal-fork-of-Quick/issues{/number}","pulls_url":"https://api.github.com/repos/modocache/personal-fork-of-Quick/pulls{/number}","milestones_url":"https://api.github.com/repos/modocache/personal-fork-of-Quick/milestones{/number}","notifications_url":"https://api.github.com/repos/modocache/personal-fork-of-Quick/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/modocache/personal-fork-of-Quick/labels{/name}","releases_url":"https://api.github.com/repos/modocache/personal-fork-of-Quick/releases{/id}","created_at":"2014-07-08T07:42:48Z","updated_at":"2014-11-25T01:41:47Z","pushed_at":"2014-11-30T14:43:36Z","git_url":"git://github.com/modocache/personal-fork-of-Quick.git","ssh_url":"git@github.com:modocache/personal-fork-of-Quick.git","clone_url":"https://github.com/modocache/personal-fork-of-Quick.git","svn_url":"https://github.com/modocache/personal-fork-of-Quick","homepage":"https://github.com/Quick/Quick","size":1441,"stargazers_count":44,"watchers_count":44,"language":"Swift","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":0,"forks":7,"open_issues":0,"watchers":44,"default_branch":"master"}},"base":{"label":"Quick:master","ref":"master","sha":"28a2edbf7d04d14b2de67fb12ffa844640ef635e","user":{"login":"Quick","id":8083968,"avatar_url":"https://avatars.githubusercontent.com/u/8083968?v=3","gravatar_id":"","url":"https://api.github.com/users/Quick","html_url":"https://github.com/Quick","followers_url":"https://api.github.com/users/Quick/followers","following_url":"https://api.github.com/users/Quick/following{/other_user}","gists_url":"https://api.github.com/users/Quick/gists{/gist_id}","starred_url":"https://api.github.com/users/Quick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Quick/subscriptions","organizations_url":"https://api.github.com/users/Quick/orgs","repos_url":"https://api.github.com/users/Quick/repos","events_url":"https://api.github.com/users/Quick/events{/privacy}","received_events_url":"https://api.github.com/users/Quick/received_events","type":"Organization","site_admin":false},"repo":{"id":20506004,"name":"Quick","full_name":"Quick/Quick","owner":{"login":"Quick","id":8083968,"avatar_url":"https://avatars.githubusercontent.com/u/8083968?v=3","gravatar_id":"","url":"https://api.github.com/users/Quick","html_url":"https://github.com/Quick","followers_url":"https://api.github.com/users/Quick/followers","following_url":"https://api.github.com/users/Quick/following{/other_user}","gists_url":"https://api.github.com/users/Quick/gists{/gist_id}","starred_url":"https://api.github.com/users/Quick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Quick/subscriptions","organizations_url":"https://api.github.com/users/Quick/orgs","repos_url":"https://api.github.com/users/Quick/repos","events_url":"https://api.github.com/users/Quick/events{/privacy}","received_events_url":"https://api.github.com/users/Quick/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Quick/Quick","description":"The Swift (and Objective-C) testing framework.","fork":false,"url":"https://api.github.com/repos/Quick/Quick","forks_url":"https://api.github.com/repos/Quick/Quick/forks","keys_url":"https://api.github.com/repos/Quick/Quick/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Quick/Quick/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Quick/Quick/teams","hooks_url":"https://api.github.com/repos/Quick/Quick/hooks","issue_events_url":"https://api.github.com/repos/Quick/Quick/issues/events{/number}","events_url":"https://api.github.com/repos/Quick/Quick/events","assignees_url":"https://api.github.com/repos/Quick/Quick/assignees{/user}","branches_url":"https://api.github.com/repos/Quick/Quick/branches{/branch}","tags_url":"https://api.github.com/repos/Quick/Quick/tags","blobs_url":"https://api.github.com/repos/Quick/Quick/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Quick/Quick/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Quick/Quick/git/refs{/sha}","trees_url":"https://api.github.com/repos/Quick/Quick/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Quick/Quick/statuses/{sha}","languages_url":"https://api.github.com/repos/Quick/Quick/languages","stargazers_url":"https://api.github.com/repos/Quick/Quick/stargazers","contributors_url":"https://api.github.com/repos/Quick/Quick/contributors","subscribers_url":"https://api.github.com/repos/Quick/Quick/subscribers","subscription_url":"https://api.github.com/repos/Quick/Quick/subscription","commits_url":"https://api.github.com/repos/Quick/Quick/commits{/sha}","git_commits_url":"https://api.github.com/repos/Quick/Quick/git/commits{/sha}","comments_url":"https://api.github.com/repos/Quick/Quick/comments{/number}","issue_comment_url":"https://api.github.com/repos/Quick/Quick/issues/comments/{number}","contents_url":"https://api.github.com/repos/Quick/Quick/contents/{+path}","compare_url":"https://api.github.com/repos/Quick/Quick/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Quick/Quick/merges","archive_url":"https://api.github.com/repos/Quick/Quick/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Quick/Quick/downloads","issues_url":"https://api.github.com/repos/Quick/Quick/issues{/number}","pulls_url":"https://api.github.com/repos/Quick/Quick/pulls{/number}","milestones_url":"https://api.github.com/repos/Quick/Quick/milestones{/number}","notifications_url":"https://api.github.com/repos/Quick/Quick/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Quick/Quick/labels{/name}","releases_url":"https://api.github.com/repos/Quick/Quick/releases{/id}","created_at":"2014-06-05T00:29:53Z","updated_at":"2014-11-30T04:22:23Z","pushed_at":"2014-11-26T13:50:43Z","git_url":"git://github.com/Quick/Quick.git","ssh_url":"git@github.com:Quick/Quick.git","clone_url":"https://github.com/Quick/Quick.git","svn_url":"https://github.com/Quick/Quick","homepage":"","size":4027,"stargazers_count":1595,"watchers_count":1595,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":125,"mirror_url":null,"open_issues_count":31,"forks":125,"open_issues":31,"watchers":1595,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Quick/Quick/pulls/211"},"html":{"href":"https://github.com/Quick/Quick/pull/211"},"issue":{"href":"https://api.github.com/repos/Quick/Quick/issues/211"},"comments":{"href":"https://api.github.com/repos/Quick/Quick/issues/211/comments"},"review_comments":{"href":"https://api.github.com/repos/Quick/Quick/pulls/211/comments"},"review_comment":{"href":"https://api.github.com/repos/Quick/Quick/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Quick/Quick/pulls/211/commits"},"statuses":{"href":"https://api.github.com/repos/Quick/Quick/statuses/64f0b2db1ac98f8dc73fb7c860bf721a37ecd8c1"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":89,"deletions":57,"changed_files":3}}