GitHub PullRequestReviewCommentEvent at 2014-01-15 18:42:47
Repository: goon
Actor: mjibson
Payload: {"comment":{"url":"https://api.github.com/repos/mjibson/goon/pulls/comments/8906689","id":8906689,"diff_hunk":"@@ -258,18 +268,33 @@ func (g *Goon) putMemcache(srcs []interface{}) error {\n \t\t\treturn err\n \t\t}\n \t\tkey, err := g.getStructKey(src)\n-\n+\t\tif err != nil {\n+\t\t\treturn err\n+\t\t}\n \t\titems[i] = &memcache.Item{\n \t\t\tKey:   memkey(key),\n \t\t\tValue: gob,\n \t\t}\n \t}\n-\n-\tmemcache.SetMulti(g.context, items)\n+\terrc := make(chan error, 1) // need to buffer so as to not leak a goroutine\n+\tgo func() {\n+\t\terrc <- memcache.SetMulti(g.context, items)\n+\t}()\n \tg.putMemoryMulti(srcs)\n+\tselect {\n+\tcase err := <-errc:\n+\t\tg.error(err)","path":"goon.go","position":81,"original_position":81,"commit_id":"8198a45370c34d37130e8cec4d2759da5f349718","original_commit_id":"8198a45370c34d37130e8cec4d2759da5f349718","user":{"login":"mjibson","id":41181,"avatar_url":"https://gravatar.com/avatar/cf2143f14e4018a342ce93aa0fad00c6?d=https%3A%2F%2Fidenticons.github.com%2F0c43763b1515136b7ab5a8974a58b6b1.png&r=x","gravatar_id":"cf2143f14e4018a342ce93aa0fad00c6","url":"https://api.github.com/users/mjibson","html_url":"https://github.com/mjibson","followers_url":"https://api.github.com/users/mjibson/followers","following_url":"https://api.github.com/users/mjibson/following{/other_user}","gists_url":"https://api.github.com/users/mjibson/gists{/gist_id}","starred_url":"https://api.github.com/users/mjibson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjibson/subscriptions","organizations_url":"https://api.github.com/users/mjibson/orgs","repos_url":"https://api.github.com/users/mjibson/repos","events_url":"https://api.github.com/users/mjibson/events{/privacy}","received_events_url":"https://api.github.com/users/mjibson/received_events","type":"User","site_admin":false},"body":"Actually, I think we should return an error here if there is one instead of always returning nil.","created_at":"2014-01-15T18:42:47Z","updated_at":"2014-01-15T18:42:47Z","html_url":"https://github.com/mjibson/goon/pull/17#discussion_r8906689","pull_request_url":"https://api.github.com/repos/mjibson/goon/pulls/17","_links":{"self":{"href":"https://api.github.com/repos/mjibson/goon/pulls/comments/8906689"},"html":{"href":"https://github.com/mjibson/goon/pull/17#discussion_r8906689"},"pull_request":{"href":"https://api.github.com/repos/mjibson/goon/pulls/17"}}}}