GitHub PullRequestReviewCommentEvent at 2014-11-10 16:28:38
Repository: doorkeeper
Actor: houndci
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/pulls/comments/20092466","id":20092466,"diff_hunk":"@@ -1,5 +1,6 @@\n module Doorkeeper\n   class TokensController < Doorkeeper::ApplicationMetalController\n+","path":"app/controllers/doorkeeper/tokens_controller.rb","position":3,"original_position":3,"commit_id":"0ec6bede20152095bfc63bf11d5ee00adb9d4e1a","original_commit_id":"0ec6bede20152095bfc63bf11d5ee00adb9d4e1a","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Extra empty line detected at body beginning.","created_at":"2014-11-10T16:28:38Z","updated_at":"2014-11-10T16:28:38Z","html_url":"https://github.com/doorkeeper-gem/doorkeeper/pull/506#discussion_r20092466","pull_request_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/pulls/506","_links":{"self":{"href":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/pulls/comments/20092466"},"html":{"href":"https://github.com/doorkeeper-gem/doorkeeper/pull/506#discussion_r20092466"},"pull_request":{"href":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/pulls/506"}}},"pull_request":{"url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/pulls/506","id":24124765,"html_url":"https://github.com/doorkeeper-gem/doorkeeper/pull/506","diff_url":"https://github.com/doorkeeper-gem/doorkeeper/pull/506.diff","patch_url":"https://github.com/doorkeeper-gem/doorkeeper/pull/506.patch","issue_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/issues/506","number":506,"state":"open","locked":false,"title":"Throw a 401 on revoke if no auth header is found","user":{"login":"ryanjones","id":350391,"avatar_url":"https://avatars.githubusercontent.com/u/350391?v=3","gravatar_id":"","url":"https://api.github.com/users/ryanjones","html_url":"https://github.com/ryanjones","followers_url":"https://api.github.com/users/ryanjones/followers","following_url":"https://api.github.com/users/ryanjones/following{/other_user}","gists_url":"https://api.github.com/users/ryanjones/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanjones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanjones/subscriptions","organizations_url":"https://api.github.com/users/ryanjones/orgs","repos_url":"https://api.github.com/users/ryanjones/repos","events_url":"https://api.github.com/users/ryanjones/events{/privacy}","received_events_url":"https://api.github.com/users/ryanjones/received_events","type":"User","site_admin":false},"body":"This should fix #505\r\n\r\n@tute I wasn't sure the best way to raise a 401 in doorkeeper. I did come across ```Doorkeeper::OAuth::ErrorResponse```, but I wasn't sure if you wanted me to do something like...\r\n```render json: {}, status: Doorkeeper::OAuth::ErrorResponse.new.status and return unless doorkeeper_token```\r\n\r\nLet me know if you have a better idea/way to do this.","created_at":"2014-11-10T03:11:32Z","updated_at":"2014-11-10T16:28:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dd8ff310a4656f6feef09091e17beda04d090adb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/pulls/506/commits","review_comments_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/pulls/506/comments","review_comment_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/pulls/comments/{number}","comments_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/issues/506/comments","statuses_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/statuses/0ec6bede20152095bfc63bf11d5ee00adb9d4e1a","head":{"label":"ryanjones:fix_revoke_200_401","ref":"fix_revoke_200_401","sha":"0ec6bede20152095bfc63bf11d5ee00adb9d4e1a","user":{"login":"ryanjones","id":350391,"avatar_url":"https://avatars.githubusercontent.com/u/350391?v=3","gravatar_id":"","url":"https://api.github.com/users/ryanjones","html_url":"https://github.com/ryanjones","followers_url":"https://api.github.com/users/ryanjones/followers","following_url":"https://api.github.com/users/ryanjones/following{/other_user}","gists_url":"https://api.github.com/users/ryanjones/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanjones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanjones/subscriptions","organizations_url":"https://api.github.com/users/ryanjones/orgs","repos_url":"https://api.github.com/users/ryanjones/repos","events_url":"https://api.github.com/users/ryanjones/events{/privacy}","received_events_url":"https://api.github.com/users/ryanjones/received_events","type":"User","site_admin":false},"repo":{"id":15536421,"name":"doorkeeper","full_name":"ryanjones/doorkeeper","owner":{"login":"ryanjones","id":350391,"avatar_url":"https://avatars.githubusercontent.com/u/350391?v=3","gravatar_id":"","url":"https://api.github.com/users/ryanjones","html_url":"https://github.com/ryanjones","followers_url":"https://api.github.com/users/ryanjones/followers","following_url":"https://api.github.com/users/ryanjones/following{/other_user}","gists_url":"https://api.github.com/users/ryanjones/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanjones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanjones/subscriptions","organizations_url":"https://api.github.com/users/ryanjones/orgs","repos_url":"https://api.github.com/users/ryanjones/repos","events_url":"https://api.github.com/users/ryanjones/events{/privacy}","received_events_url":"https://api.github.com/users/ryanjones/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ryanjones/doorkeeper","description":"Doorkeeper is an OAuth 2 provider for Rails.","fork":true,"url":"https://api.github.com/repos/ryanjones/doorkeeper","forks_url":"https://api.github.com/repos/ryanjones/doorkeeper/forks","keys_url":"https://api.github.com/repos/ryanjones/doorkeeper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ryanjones/doorkeeper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ryanjones/doorkeeper/teams","hooks_url":"https://api.github.com/repos/ryanjones/doorkeeper/hooks","issue_events_url":"https://api.github.com/repos/ryanjones/doorkeeper/issues/events{/number}","events_url":"https://api.github.com/repos/ryanjones/doorkeeper/events","assignees_url":"https://api.github.com/repos/ryanjones/doorkeeper/assignees{/user}","branches_url":"https://api.github.com/repos/ryanjones/doorkeeper/branches{/branch}","tags_url":"https://api.github.com/repos/ryanjones/doorkeeper/tags","blobs_url":"https://api.github.com/repos/ryanjones/doorkeeper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ryanjones/doorkeeper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ryanjones/doorkeeper/git/refs{/sha}","trees_url":"https://api.github.com/repos/ryanjones/doorkeeper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ryanjones/doorkeeper/statuses/{sha}","languages_url":"https://api.github.com/repos/ryanjones/doorkeeper/languages","stargazers_url":"https://api.github.com/repos/ryanjones/doorkeeper/stargazers","contributors_url":"https://api.github.com/repos/ryanjones/doorkeeper/contributors","subscribers_url":"https://api.github.com/repos/ryanjones/doorkeeper/subscribers","subscription_url":"https://api.github.com/repos/ryanjones/doorkeeper/subscription","commits_url":"https://api.github.com/repos/ryanjones/doorkeeper/commits{/sha}","git_commits_url":"https://api.github.com/repos/ryanjones/doorkeeper/git/commits{/sha}","comments_url":"https://api.github.com/repos/ryanjones/doorkeeper/comments{/number}","issue_comment_url":"https://api.github.com/repos/ryanjones/doorkeeper/issues/comments/{number}","contents_url":"https://api.github.com/repos/ryanjones/doorkeeper/contents/{+path}","compare_url":"https://api.github.com/repos/ryanjones/doorkeeper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ryanjones/doorkeeper/merges","archive_url":"https://api.github.com/repos/ryanjones/doorkeeper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ryanjones/doorkeeper/downloads","issues_url":"https://api.github.com/repos/ryanjones/doorkeeper/issues{/number}","pulls_url":"https://api.github.com/repos/ryanjones/doorkeeper/pulls{/number}","milestones_url":"https://api.github.com/repos/ryanjones/doorkeeper/milestones{/number}","notifications_url":"https://api.github.com/repos/ryanjones/doorkeeper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ryanjones/doorkeeper/labels{/name}","releases_url":"https://api.github.com/repos/ryanjones/doorkeeper/releases{/id}","created_at":"2013-12-30T20:55:46Z","updated_at":"2014-11-09T02:58:06Z","pushed_at":"2014-11-10T03:06:55Z","git_url":"git://github.com/ryanjones/doorkeeper.git","ssh_url":"git@github.com:ryanjones/doorkeeper.git","clone_url":"https://github.com/ryanjones/doorkeeper.git","svn_url":"https://github.com/ryanjones/doorkeeper","homepage":"https://github.com/applicake/doorkeeper","size":2017,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"doorkeeper-gem:master","ref":"master","sha":"d909d6b6cf5318a385f33bc6838f5dbc661d47a7","user":{"login":"doorkeeper-gem","id":7275750,"avatar_url":"https://avatars.githubusercontent.com/u/7275750?v=3","gravatar_id":"","url":"https://api.github.com/users/doorkeeper-gem","html_url":"https://github.com/doorkeeper-gem","followers_url":"https://api.github.com/users/doorkeeper-gem/followers","following_url":"https://api.github.com/users/doorkeeper-gem/following{/other_user}","gists_url":"https://api.github.com/users/doorkeeper-gem/gists{/gist_id}","starred_url":"https://api.github.com/users/doorkeeper-gem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doorkeeper-gem/subscriptions","organizations_url":"https://api.github.com/users/doorkeeper-gem/orgs","repos_url":"https://api.github.com/users/doorkeeper-gem/repos","events_url":"https://api.github.com/users/doorkeeper-gem/events{/privacy}","received_events_url":"https://api.github.com/users/doorkeeper-gem/received_events","type":"Organization","site_admin":false},"repo":{"id":2802565,"name":"doorkeeper","full_name":"doorkeeper-gem/doorkeeper","owner":{"login":"doorkeeper-gem","id":7275750,"avatar_url":"https://avatars.githubusercontent.com/u/7275750?v=3","gravatar_id":"","url":"https://api.github.com/users/doorkeeper-gem","html_url":"https://github.com/doorkeeper-gem","followers_url":"https://api.github.com/users/doorkeeper-gem/followers","following_url":"https://api.github.com/users/doorkeeper-gem/following{/other_user}","gists_url":"https://api.github.com/users/doorkeeper-gem/gists{/gist_id}","starred_url":"https://api.github.com/users/doorkeeper-gem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doorkeeper-gem/subscriptions","organizations_url":"https://api.github.com/users/doorkeeper-gem/orgs","repos_url":"https://api.github.com/users/doorkeeper-gem/repos","events_url":"https://api.github.com/users/doorkeeper-gem/events{/privacy}","received_events_url":"https://api.github.com/users/doorkeeper-gem/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/doorkeeper-gem/doorkeeper","description":"Doorkeeper is an OAuth 2 provider for Rails.","fork":false,"url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper","forks_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/forks","keys_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/teams","hooks_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/hooks","issue_events_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/issues/events{/number}","events_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/events","assignees_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/assignees{/user}","branches_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/branches{/branch}","tags_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/tags","blobs_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/git/refs{/sha}","trees_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/statuses/{sha}","languages_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/languages","stargazers_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/stargazers","contributors_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/contributors","subscribers_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/subscribers","subscription_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/subscription","commits_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/commits{/sha}","git_commits_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/git/commits{/sha}","comments_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/comments{/number}","issue_comment_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/issues/comments/{number}","contents_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/contents/{+path}","compare_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/merges","archive_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/downloads","issues_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/issues{/number}","pulls_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/pulls{/number}","milestones_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/milestones{/number}","notifications_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/labels{/name}","releases_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/releases{/id}","created_at":"2011-11-18T13:02:01Z","updated_at":"2014-11-10T12:49:50Z","pushed_at":"2014-11-09T17:03:13Z","git_url":"git://github.com/doorkeeper-gem/doorkeeper.git","ssh_url":"git@github.com:doorkeeper-gem/doorkeeper.git","clone_url":"https://github.com/doorkeeper-gem/doorkeeper.git","svn_url":"https://github.com/doorkeeper-gem/doorkeeper","homepage":"https://github.com/doorkeeper-gem/doorkeeper","size":8304,"stargazers_count":1800,"watchers_count":1800,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":392,"mirror_url":null,"open_issues_count":16,"forks":392,"open_issues":16,"watchers":1800,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/pulls/506"},"html":{"href":"https://github.com/doorkeeper-gem/doorkeeper/pull/506"},"issue":{"href":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/issues/506"},"comments":{"href":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/issues/506/comments"},"review_comments":{"href":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/pulls/506/comments"},"review_comment":{"href":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/pulls/506/commits"},"statuses":{"href":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/statuses/0ec6bede20152095bfc63bf11d5ee00adb9d4e1a"}}}}