GitHub PullRequestReviewCommentEvent at 2014-04-09 12:37:02
Repository: Collage
Actor: hernando
Payload: {"comment":{"url":"https://api.github.com/repos/Eyescale/Collage/pulls/comments/11433091","id":11433091,"diff_hunk":"@@ -395,9 +397,10 @@ uint32_t ObjectStore::mapNB( Object* object, const UUID& id,\n     object->notifyAttach();\n     master->send( CMD_NODE_MAP_OBJECT )\n         << version << minCachedVersion << maxCachedVersion << id\n-        << object->getMaxVersions() << requestID << _genNextID( _instanceIDs )\n+        << object->getMaxVersions() << request << _genNextID( _instanceIDs )\n         << masterInstanceID << useCache;\n-    return requestID;\n+    request.relinquish();\n+    return request.getID();","path":"co/objectStore.cpp","position":87,"original_position":87,"commit_id":"c7997deca0afb2b76e4ca239c649acb3820531aa","original_commit_id":"c7997deca0afb2b76e4ca239c649acb3820531aa","user":{"login":"hernando","id":791427,"avatar_url":"https://avatars.githubusercontent.com/u/791427?","gravatar_id":"b5cf99ec59e30d519b8b535525c599e1","url":"https://api.github.com/users/hernando","html_url":"https://github.com/hernando","followers_url":"https://api.github.com/users/hernando/followers","following_url":"https://api.github.com/users/hernando/following{/other_user}","gists_url":"https://api.github.com/users/hernando/gists{/gist_id}","starred_url":"https://api.github.com/users/hernando/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hernando/subscriptions","organizations_url":"https://api.github.com/users/hernando/orgs","repos_url":"https://api.github.com/users/hernando/repos","events_url":"https://api.github.com/users/hernando/events{/privacy}","received_events_url":"https://api.github.com/users/hernando/received_events","type":"User","site_admin":false},"body":"Are futures supposed to be copy constructible? If we follow the lock/mutex analogy they shouldn't, so I don't know how suitable is to return a future (with move semantics it's a different story).\r\n\r\nTo not break the API at compile time it can return a proxy object which is implicitly convertible into a Request<void> and a uint32_t.\r\nAnother option is to deprecate this function and add a new one that returns the future.","created_at":"2014-04-09T12:37:02Z","updated_at":"2014-04-09T12:37:02Z","html_url":"https://github.com/Eyescale/Collage/pull/97#discussion_r11433091","pull_request_url":"https://api.github.com/repos/Eyescale/Collage/pulls/97","_links":{"self":{"href":"https://api.github.com/repos/Eyescale/Collage/pulls/comments/11433091"},"html":{"href":"https://github.com/Eyescale/Collage/pull/97#discussion_r11433091"},"pull_request":{"href":"https://api.github.com/repos/Eyescale/Collage/pulls/97"}}}}