GitHub PushEvent at 2014-08-30 11:30:43
Repository: valgrind
Actor: svn2github
Payload: {"shas":[["9f1afceee5200adf16ba07e8d9365b02068a9f2a","442bd8eb7b6ea1a04e35059cba7a2e80eb32ed1d@a5019735-40e9-0310-863c-91ae7b9d1cf9","Hook up allexec tests for arm64.\n\ngit-svn-id: svn://svn.valgrind.org/valgrind/trunk@14382 a5019735-40e9-0310-863c-91ae7b9d1cf9","mjw",true],["07301076d52cd4368ab743630551b548b70d1f7e","442bd8eb7b6ea1a04e35059cba7a2e80eb32ed1d@a5019735-40e9-0310-863c-91ae7b9d1cf9","include/vki/vki-scnums-arm64-linux.h use correct __NR_lseek define.\n\nThis caused memcheck/tests/linux/proc-auxv.vgtest to fail because\nour internal VG(lseek) would return ENOSYS.\n\ngit-svn-id: svn://svn.valgrind.org/valgrind/trunk@14383 a5019735-40e9-0310-863c-91ae7b9d1cf9","mjw",true],["43f5789e63e1d863c5ea01c6f71e1a5d945c99ae","442bd8eb7b6ea1a04e35059cba7a2e80eb32ed1d@a5019735-40e9-0310-863c-91ae7b9d1cf9","Use getdents64 syscall on linux.\n\ngetdents has been deprecated since linux 2.4 and newer arches (arm64)\nmight no longer provide the getdents syscall. Use getdents64 for reading\nthe /proc/self/fd/ dir so --track-fds=yes works reliable on all arches.\nWithout this the none/tests/fdleak*vgtest might fail.\n\ngit-svn-id: svn://svn.valgrind.org/valgrind/trunk@14384 a5019735-40e9-0310-863c-91ae7b9d1cf9","mjw",true],["24d1f5542dd45dc47279b0bcc5d157e9209d9019","442bd8eb7b6ea1a04e35059cba7a2e80eb32ed1d@a5019735-40e9-0310-863c-91ae7b9d1cf9","none/tests/res_search.vgtest: Add prereq that domain can be resolved.\n\nSome autobuilders/testers don't allow network access.\n\ngit-svn-id: svn://svn.valgrind.org/valgrind/trunk@14385 a5019735-40e9-0310-863c-91ae7b9d1cf9","mjw",true],["0acb03bd640ee33f652742dcf2884bd4f303e6f8","c1ef41834a9fde814d74180f707866d24e883999@a5019735-40e9-0310-863c-91ae7b9d1cf9","run_thread_for_a_while: Make the computation of done_this_time less\nbogus, and in particular ensure that it can't be zero if in fact the\nthread did do some useful work.  Fix up a couple of associated\nassertions.  Fixes #336435.\n\n\ngit-svn-id: svn://svn.valgrind.org/valgrind/trunk@14386 a5019735-40e9-0310-863c-91ae7b9d1cf9","sewardj",true],["0e991bd3b7c4492f6ac76dc8ca29845ea90ea153","c1ef41834a9fde814d74180f707866d24e883999@a5019735-40e9-0310-863c-91ae7b9d1cf9","Update.\n\n\ngit-svn-id: svn://svn.valgrind.org/valgrind/trunk@14387 a5019735-40e9-0310-863c-91ae7b9d1cf9","sewardj",true],["f7356b2f8848809d875cf68592e1261309608260","442bd8eb7b6ea1a04e35059cba7a2e80eb32ed1d@a5019735-40e9-0310-863c-91ae7b9d1cf9","With gcc 4.9.1 exp-sgcheck/tests/globalerr sees array \"a\", not unknown.\n\ngit-svn-id: svn://svn.valgrind.org/valgrind/trunk@14388 a5019735-40e9-0310-863c-91ae7b9d1cf9","mjw",true],["26e327e26b9726c08fa5b19880b1589ddca42f9b","c1ef41834a9fde814d74180f707866d24e883999@a5019735-40e9-0310-863c-91ae7b9d1cf9","arm64: record the use of x8 as of vex r2938.\n\n\ngit-svn-id: svn://svn.valgrind.org/valgrind/trunk@14389 a5019735-40e9-0310-863c-91ae7b9d1cf9","sewardj",true],["71e891c982e7b05302a410368c04b502f165051d","bbbdd9057189c4ee422bb93be7625c8769f590ab@a5019735-40e9-0310-863c-91ae7b9d1cf9","Add missing file in EXTRA_DIST\n\n\ngit-svn-id: svn://svn.valgrind.org/valgrind/trunk@14390 a5019735-40e9-0310-863c-91ae7b9d1cf9","philippe",true],["5e53be94d2dca9fe6f7c2115ee4ae7f7e744a20e","bbbdd9057189c4ee422bb93be7625c8769f590ab@a5019735-40e9-0310-863c-91ae7b9d1cf9","make prereq fail with 1 if host command not installed\nas prereq must return 0 or 1. Any other return value aborts the regtests.\n\n\n\ngit-svn-id: svn://svn.valgrind.org/valgrind/trunk@14391 a5019735-40e9-0310-863c-91ae7b9d1cf9","philippe",true],["23be2ef6d618df284e7d2a26e64d5c26b9114308","bbbdd9057189c4ee422bb93be7625c8769f590ab@a5019735-40e9-0310-863c-91ae7b9d1cf9","The semantic of the stack bounds is not consistent or is not described.\nAt various places, there were either some assumption that the 'end'\nboundary (highest address) was either not included, included,\nor was the highest addressable word, or the highest addressable byte.\nThis e.g. was very visible when doing:\n  ./vg-in-place -d -d ./helgrind/tests/tc01_simple_race|&grep regi\ngiving\n  --24040:2:stacks     register 0xBEDB4000-0xBEDB4FFF as stack 0\n  --24040:2:stacks     register 0x402C000-0x4A2C000 as stack 1\nshowing that the main stack end was (on x86) not the highest word\nbut the highest byte, while for the thread 1, the registered end\nwas a byte not part of the stack.\n\nThe attached patch ensures that stack bounds semantic are documented and\nconsistent. Also, some of the stack handling code is factorised.\n\nThe convention that the patch ensures and documents is:\nstart is the lowest addressable byte, end is the highest addressable byte.\n(the words 'min' and 'max' have been kept when already used, as this wording is \nconsistent with the new semantic of start/end).\n\nIn various debug log, used brackets [ and ] to make clear that\nboth bounds are included.\n\nThe code to guess and register the client stack was duplicated\nin all the platform specific syswrap-<plat>-<os>.c files.\nCode has been factorised in syswrap-generic.c\n\nThe patch has been regression tested on\n   x86, amd64, ppc32/64, s390x.\nIt has been compiled and one test run on arm64.\nNot compiled/not tested on darwin, android, mips32/64, arm\n\n\nMore in details, the patch does the following:\n\ncoregrind/pub_core_aspacemgr.h\ninclude/valgrind.h\ninclude/pub_tool_machine.h\ncoregrind/pub_core_scheduler.h\ncoregrind/pub_core_stacks.h\n  - document start/end semantic in various functions\n also in pub_tool_machine.h:\n  - replaces unclear 'bottommost address' by 'lowest address'\n    (unclear as stack bottom is or at least can be interpreted as\n     the 'functional' bottom of the stack, which is the highest\n      address for 'stack growing downwards').\ncoregrind/pub_core_initimg.h\n  replace unclear clstack_top by clstack_end\ncoregrind/m_main.c\n  updated to clstack_end\n\ncoregrind/pub_core_threadstate.h\n  renamed client_stack_highest_word to client_stack_highest_byte\ncoregrind/m_scheduler/scheduler.c\n  computes client_stack_highest_byte as the highest addressable byte\n  Update comments in call to VG_(show_sched_status)\ncoregrind/m_machine.c\ncoregrind/m_stacktrace.c\n  updated to client_stack_highest_byte, and switched \n    stack_lowest/highest_word to stack_lowest/highest_byte accordingly\n\ncoregrind/m_stacks.c\n  clarify semantic of start/end,\n  added a comment to indicate why we invert start/end in register call\n  (note that the code find_stack_by_addr was already assuming that\n  end was included as the checks were doing e.g.\n    sp >= i->start && sp <= i->end\n\ncoregrind/pub_core_clientstate.h\ncoregrind/m_clientstate.c\n  renames Addr  VG_(clstk_base) to Addr  VG_(clstk_start_base)\n    (start to indicate it is the lowest address, base suffix kept\n     to indicate it is the initial lowest address).\n\ncoregrind/m_initimg/initimg-darwin.c\n   updated to  VG_(clstk_start_base)\n   replace unclear iicii.clstack_top by iicii.clstack_end\n   updated clstack_max_size computation according to both bounds included.\n\ncoregrind/m_initimg/initimg-linux.c\n   updated to  VG_(clstk_start_base)\n   updated VG_(clstk_end) computation according to both bounds included.\n   replace unclear iicii.clstack_top by iicii.clstack_end\n\ncoregrind/pub_core_aspacemgr.h\n  extern Addr VG_(am_startup) : clarify semantic of the returned value\ncoregrind/m_aspacemgr/aspacemgr-linux.c\n   removed a copy of a comment that was already in pub_core_aspacemgr.h\n     (avoid double maintenance)\n   renamed unclear suggested_clstack_top to suggested_clstack_end\n    (note that here, it looks like suggested_clstack_top was already\n     the last addressable byte)\n\n* factorisation of the stack guessing and registration causes\n  mechanical changes in the following files:\n      coregrind/m_syswrap/syswrap-ppc64-linux.c\n      coregrind/m_syswrap/syswrap-x86-darwin.c\n      coregrind/m_syswrap/syswrap-amd64-linux.c\n      coregrind/m_syswrap/syswrap-arm-linux.c\n      coregrind/m_syswrap/syswrap-generic.c\n      coregrind/m_syswrap/syswrap-mips64-linux.c\n      coregrind/m_syswrap/syswrap-ppc32-linux.c\n      coregrind/m_syswrap/syswrap-amd64-darwin.c\n      coregrind/m_syswrap/syswrap-mips32-linux.c\n      coregrind/m_syswrap/priv_syswrap-generic.h\n      coregrind/m_syswrap/syswrap-x86-linux.c\n      coregrind/m_syswrap/syswrap-s390x-linux.c\n      coregrind/m_syswrap/syswrap-darwin.c\n      coregrind/m_syswrap/syswrap-arm64-linux.c\n Some files to look at more in details:\n  syswrap-darwin.c : the handling of sysctl(kern.usrstack) looked\n    buggy to me, and has probably be made correct by the fact that\n     VG_(clstk_end) is now the last addressable byte. However,unsure\n    about this, as I could not find any documentation about \n    sysctl(kern.usrstack). I only find several occurences on the web,\n    showing that the result of this is page aligned, which I guess\n    means it must be 1+ the last addressable byte.\n  syswrap-x86-darwin.c and syswrap-amd64-darwin.c\n   I suspect the code that was computing client_stack_highest_word\n   was wrong, and the patch makes it correct.\n  syswrap-mips64-linux.c\n    not sure what to do for this code. This is the only code\n    that was guessing the stack differently from others.\n    Kept (almost) untouched. To be discussed with mips maintainers.\n\ncoregrind/pub_core_libcassert.h\ncoregrind/m_libcassert.c\n  * void VG_(show_sched_status):\n     renamed Bool valgrind_stack_usage to Bool stack_usage\n     if stack_usage, shows both the valgrind stack usage and\n     the client stack boundaries\ncoregrind/m_scheduler/scheduler.c\ncoregrind/m_gdbserver/server.c\ncoregrind/m_gdbserver/remote-utils.c\n   Updated comments in callers to VG_(show_sched_status)\n\n\n\ngit-svn-id: svn://svn.valgrind.org/valgrind/trunk@14392 a5019735-40e9-0310-863c-91ae7b9d1cf9","philippe",true],["66eedb7de51996c0ccf9d20c5626c7388bfb6378","bbbdd9057189c4ee422bb93be7625c8769f590ab@a5019735-40e9-0310-863c-91ae7b9d1cf9","document in NEWS the fact that stack registration start/end boundaries\nare the lowest/highest addressable bytes\n\n\ngit-svn-id: svn://svn.valgrind.org/valgrind/trunk@14393 a5019735-40e9-0310-863c-91ae7b9d1cf9","philippe",true],["1a8a4a4d4e2d216d12b3af8b88949fb640fbf4c1","2ece23298f06d9fb45772fdb1d38086918c80f44@a5019735-40e9-0310-863c-91ae7b9d1cf9","drd/tests/pth_create_chain: Reduce stack usage\n\ngit-svn-id: svn://svn.valgrind.org/valgrind/trunk@14394 a5019735-40e9-0310-863c-91ae7b9d1cf9","bart",true],["766709ec1709bff25d1e2eda671aab37bd0bb98f","c1ef41834a9fde814d74180f707866d24e883999@a5019735-40e9-0310-863c-91ae7b9d1cf9","Initial triage pass for all remaining newly opened bugs.\n\n\ngit-svn-id: svn://svn.valgrind.org/valgrind/trunk@14395 a5019735-40e9-0310-863c-91ae7b9d1cf9","sewardj",true]],"size":14,"ref":"refs/heads/master","head":"766709ec1709bff25d1e2eda671aab37bd0bb98f"}