GitHub PullRequestReviewCommentEvent at 2014-10-09 19:11:16
Repository: spree_marketplace
Actor: houndci
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/JDutil/spree_marketplace/pulls/comments/18667096","id":18667096,"diff_hunk":"@@ -13,9 +13,9 @@\n   private\n \n   def assign_name\n-    self.address = Spree::Address.default unless self.address.present?\n-    self.address.first_name = self.first_name\n-    self.address.last_name = self.last_name\n+    self.address = Spree::Address.default     unless self.address.present?\n+    self.address.first_name = self.first_name unless self.address.first_name.present?","path":"app/models/spree/supplier_decorator.rb","position":8,"original_position":8,"commit_id":"b02b0c9e85108f800eb97d2ec185829121f9632b","original_commit_id":"b02b0c9e85108f800eb97d2ec185829121f9632b","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=2","gravatar_id":"","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Redundant `self` detected.","created_at":"2014-10-09T19:11:16Z","updated_at":"2014-10-09T19:11:16Z","html_url":"https://github.com/JDutil/spree_marketplace/pull/10#discussion_r18667096","pull_request_url":"https://api.github.com/repos/JDutil/spree_marketplace/pulls/10","_links":{"self":{"href":"https://api.github.com/repos/JDutil/spree_marketplace/pulls/comments/18667096"},"html":{"href":"https://github.com/JDutil/spree_marketplace/pull/10#discussion_r18667096"},"pull_request":{"href":"https://api.github.com/repos/JDutil/spree_marketplace/pulls/10"}}},"pull_request":{"url":"https://api.github.com/repos/JDutil/spree_marketplace/pulls/10","id":22516205,"html_url":"https://github.com/JDutil/spree_marketplace/pull/10","diff_url":"https://github.com/JDutil/spree_marketplace/pull/10.diff","patch_url":"https://github.com/JDutil/spree_marketplace/pull/10.patch","issue_url":"https://api.github.com/repos/JDutil/spree_marketplace/issues/10","number":10,"state":"open","locked":false,"title":"Fix Stripe::Recipient.create validation for name","user":{"login":"StupidCodeFactory","id":100796,"avatar_url":"https://avatars.githubusercontent.com/u/100796?v=2","gravatar_id":"","url":"https://api.github.com/users/StupidCodeFactory","html_url":"https://github.com/StupidCodeFactory","followers_url":"https://api.github.com/users/StupidCodeFactory/followers","following_url":"https://api.github.com/users/StupidCodeFactory/following{/other_user}","gists_url":"https://api.github.com/users/StupidCodeFactory/gists{/gist_id}","starred_url":"https://api.github.com/users/StupidCodeFactory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StupidCodeFactory/subscriptions","organizations_url":"https://api.github.com/users/StupidCodeFactory/orgs","repos_url":"https://api.github.com/users/StupidCodeFactory/repos","events_url":"https://api.github.com/users/StupidCodeFactory/events{/privacy}","received_events_url":"https://api.github.com/users/StupidCodeFactory/received_events","type":"User","site_admin":false},"body":"When creating a supplier #assign_name would reset in some case values set in the form for first_name and last_name\r\n\r\n**CHANGES:**\r\nDon't override with potential nil values when the address already has a first name\r\nand last name","created_at":"2014-10-09T19:11:13Z","updated_at":"2014-10-09T19:11:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4a16bdfbc67346a988569220e5237c7a50ba2550","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/JDutil/spree_marketplace/pulls/10/commits","review_comments_url":"https://api.github.com/repos/JDutil/spree_marketplace/pulls/10/comments","review_comment_url":"https://api.github.com/repos/JDutil/spree_marketplace/pulls/comments/{number}","comments_url":"https://api.github.com/repos/JDutil/spree_marketplace/issues/10/comments","statuses_url":"https://api.github.com/repos/JDutil/spree_marketplace/statuses/b02b0c9e85108f800eb97d2ec185829121f9632b","head":{"label":"StupidCodeFactory:fix_stripe_name_validation","ref":"fix_stripe_name_validation","sha":"b02b0c9e85108f800eb97d2ec185829121f9632b","user":{"login":"StupidCodeFactory","id":100796,"avatar_url":"https://avatars.githubusercontent.com/u/100796?v=2","gravatar_id":"","url":"https://api.github.com/users/StupidCodeFactory","html_url":"https://github.com/StupidCodeFactory","followers_url":"https://api.github.com/users/StupidCodeFactory/followers","following_url":"https://api.github.com/users/StupidCodeFactory/following{/other_user}","gists_url":"https://api.github.com/users/StupidCodeFactory/gists{/gist_id}","starred_url":"https://api.github.com/users/StupidCodeFactory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StupidCodeFactory/subscriptions","organizations_url":"https://api.github.com/users/StupidCodeFactory/orgs","repos_url":"https://api.github.com/users/StupidCodeFactory/repos","events_url":"https://api.github.com/users/StupidCodeFactory/events{/privacy}","received_events_url":"https://api.github.com/users/StupidCodeFactory/received_events","type":"User","site_admin":false},"repo":{"id":24936151,"name":"spree_marketplace","full_name":"StupidCodeFactory/spree_marketplace","owner":{"login":"StupidCodeFactory","id":100796,"avatar_url":"https://avatars.githubusercontent.com/u/100796?v=2","gravatar_id":"","url":"https://api.github.com/users/StupidCodeFactory","html_url":"https://github.com/StupidCodeFactory","followers_url":"https://api.github.com/users/StupidCodeFactory/followers","following_url":"https://api.github.com/users/StupidCodeFactory/following{/other_user}","gists_url":"https://api.github.com/users/StupidCodeFactory/gists{/gist_id}","starred_url":"https://api.github.com/users/StupidCodeFactory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StupidCodeFactory/subscriptions","organizations_url":"https://api.github.com/users/StupidCodeFactory/orgs","repos_url":"https://api.github.com/users/StupidCodeFactory/repos","events_url":"https://api.github.com/users/StupidCodeFactory/events{/privacy}","received_events_url":"https://api.github.com/users/StupidCodeFactory/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/StupidCodeFactory/spree_marketplace","description":"Turn Spree into a marketplace by extending spree drop ship.","fork":true,"url":"https://api.github.com/repos/StupidCodeFactory/spree_marketplace","forks_url":"https://api.github.com/repos/StupidCodeFactory/spree_marketplace/forks","keys_url":"https://api.github.com/repos/StupidCodeFactory/spree_marketplace/keys{/key_id}","collaborators_url":"https://api.github.com/repos/StupidCodeFactory/spree_marketplace/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/StupidCodeFactory/spree_marketplace/teams","hooks_url":"https://api.github.com/repos/StupidCodeFactory/spree_marketplace/hooks","issue_events_url":"https://api.github.com/repos/StupidCodeFactory/spree_marketplace/issues/events{/number}","events_url":"https://api.github.com/repos/StupidCodeFactory/spree_marketplace/events","assignees_url":"https://api.github.com/repos/StupidCodeFactory/spree_marketplace/assignees{/user}","branches_url":"https://api.github.com/repos/StupidCodeFactory/spree_marketplace/branches{/branch}","tags_url":"https://api.github.com/repos/StupidCodeFactory/spree_marketplace/tags","blobs_url":"https://api.github.com/repos/StupidCodeFactory/spree_marketplace/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/StupidCodeFactory/spree_marketplace/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/StupidCodeFactory/spree_marketplace/git/refs{/sha}","trees_url":"https://api.github.com/repos/StupidCodeFactory/spree_marketplace/git/trees{/sha}","statuses_url":"https://api.github.com/repos/StupidCodeFactory/spree_marketplace/statuses/{sha}","languages_url":"https://api.github.com/repos/StupidCodeFactory/spree_marketplace/languages","stargazers_url":"https://api.github.com/repos/StupidCodeFactory/spree_marketplace/stargazers","contributors_url":"https://api.github.com/repos/StupidCodeFactory/spree_marketplace/contributors","subscribers_url":"https://api.github.com/repos/StupidCodeFactory/spree_marketplace/subscribers","subscription_url":"https://api.github.com/repos/StupidCodeFactory/spree_marketplace/subscription","commits_url":"https://api.github.com/repos/StupidCodeFactory/spree_marketplace/commits{/sha}","git_commits_url":"https://api.github.com/repos/StupidCodeFactory/spree_marketplace/git/commits{/sha}","comments_url":"https://api.github.com/repos/StupidCodeFactory/spree_marketplace/comments{/number}","issue_comment_url":"https://api.github.com/repos/StupidCodeFactory/spree_marketplace/issues/comments/{number}","contents_url":"https://api.github.com/repos/StupidCodeFactory/spree_marketplace/contents/{+path}","compare_url":"https://api.github.com/repos/StupidCodeFactory/spree_marketplace/compare/{base}...{head}","merges_url":"https://api.github.com/repos/StupidCodeFactory/spree_marketplace/merges","archive_url":"https://api.github.com/repos/StupidCodeFactory/spree_marketplace/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/StupidCodeFactory/spree_marketplace/downloads","issues_url":"https://api.github.com/repos/StupidCodeFactory/spree_marketplace/issues{/number}","pulls_url":"https://api.github.com/repos/StupidCodeFactory/spree_marketplace/pulls{/number}","milestones_url":"https://api.github.com/repos/StupidCodeFactory/spree_marketplace/milestones{/number}","notifications_url":"https://api.github.com/repos/StupidCodeFactory/spree_marketplace/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/StupidCodeFactory/spree_marketplace/labels{/name}","releases_url":"https://api.github.com/repos/StupidCodeFactory/spree_marketplace/releases{/id}","created_at":"2014-10-08T10:41:38Z","updated_at":"2014-09-26T10:12:37Z","pushed_at":"2014-10-09T19:09:12Z","git_url":"git://github.com/StupidCodeFactory/spree_marketplace.git","ssh_url":"git@github.com:StupidCodeFactory/spree_marketplace.git","clone_url":"https://github.com/StupidCodeFactory/spree_marketplace.git","svn_url":"https://github.com/StupidCodeFactory/spree_marketplace","homepage":null,"size":449,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JDutil:master","ref":"master","sha":"465c1458db21410a6e21c3b1c69d2a80fbacb3cc","user":{"login":"JDutil","id":25104,"avatar_url":"https://avatars.githubusercontent.com/u/25104?v=2","gravatar_id":"","url":"https://api.github.com/users/JDutil","html_url":"https://github.com/JDutil","followers_url":"https://api.github.com/users/JDutil/followers","following_url":"https://api.github.com/users/JDutil/following{/other_user}","gists_url":"https://api.github.com/users/JDutil/gists{/gist_id}","starred_url":"https://api.github.com/users/JDutil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JDutil/subscriptions","organizations_url":"https://api.github.com/users/JDutil/orgs","repos_url":"https://api.github.com/users/JDutil/repos","events_url":"https://api.github.com/users/JDutil/events{/privacy}","received_events_url":"https://api.github.com/users/JDutil/received_events","type":"User","site_admin":false},"repo":{"id":10612943,"name":"spree_marketplace","full_name":"JDutil/spree_marketplace","owner":{"login":"JDutil","id":25104,"avatar_url":"https://avatars.githubusercontent.com/u/25104?v=2","gravatar_id":"","url":"https://api.github.com/users/JDutil","html_url":"https://github.com/JDutil","followers_url":"https://api.github.com/users/JDutil/followers","following_url":"https://api.github.com/users/JDutil/following{/other_user}","gists_url":"https://api.github.com/users/JDutil/gists{/gist_id}","starred_url":"https://api.github.com/users/JDutil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JDutil/subscriptions","organizations_url":"https://api.github.com/users/JDutil/orgs","repos_url":"https://api.github.com/users/JDutil/repos","events_url":"https://api.github.com/users/JDutil/events{/privacy}","received_events_url":"https://api.github.com/users/JDutil/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JDutil/spree_marketplace","description":"Turn Spree into a marketplace by extending spree drop ship.","fork":false,"url":"https://api.github.com/repos/JDutil/spree_marketplace","forks_url":"https://api.github.com/repos/JDutil/spree_marketplace/forks","keys_url":"https://api.github.com/repos/JDutil/spree_marketplace/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JDutil/spree_marketplace/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JDutil/spree_marketplace/teams","hooks_url":"https://api.github.com/repos/JDutil/spree_marketplace/hooks","issue_events_url":"https://api.github.com/repos/JDutil/spree_marketplace/issues/events{/number}","events_url":"https://api.github.com/repos/JDutil/spree_marketplace/events","assignees_url":"https://api.github.com/repos/JDutil/spree_marketplace/assignees{/user}","branches_url":"https://api.github.com/repos/JDutil/spree_marketplace/branches{/branch}","tags_url":"https://api.github.com/repos/JDutil/spree_marketplace/tags","blobs_url":"https://api.github.com/repos/JDutil/spree_marketplace/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JDutil/spree_marketplace/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JDutil/spree_marketplace/git/refs{/sha}","trees_url":"https://api.github.com/repos/JDutil/spree_marketplace/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JDutil/spree_marketplace/statuses/{sha}","languages_url":"https://api.github.com/repos/JDutil/spree_marketplace/languages","stargazers_url":"https://api.github.com/repos/JDutil/spree_marketplace/stargazers","contributors_url":"https://api.github.com/repos/JDutil/spree_marketplace/contributors","subscribers_url":"https://api.github.com/repos/JDutil/spree_marketplace/subscribers","subscription_url":"https://api.github.com/repos/JDutil/spree_marketplace/subscription","commits_url":"https://api.github.com/repos/JDutil/spree_marketplace/commits{/sha}","git_commits_url":"https://api.github.com/repos/JDutil/spree_marketplace/git/commits{/sha}","comments_url":"https://api.github.com/repos/JDutil/spree_marketplace/comments{/number}","issue_comment_url":"https://api.github.com/repos/JDutil/spree_marketplace/issues/comments/{number}","contents_url":"https://api.github.com/repos/JDutil/spree_marketplace/contents/{+path}","compare_url":"https://api.github.com/repos/JDutil/spree_marketplace/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JDutil/spree_marketplace/merges","archive_url":"https://api.github.com/repos/JDutil/spree_marketplace/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JDutil/spree_marketplace/downloads","issues_url":"https://api.github.com/repos/JDutil/spree_marketplace/issues{/number}","pulls_url":"https://api.github.com/repos/JDutil/spree_marketplace/pulls{/number}","milestones_url":"https://api.github.com/repos/JDutil/spree_marketplace/milestones{/number}","notifications_url":"https://api.github.com/repos/JDutil/spree_marketplace/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JDutil/spree_marketplace/labels{/name}","releases_url":"https://api.github.com/repos/JDutil/spree_marketplace/releases{/id}","created_at":"2013-06-11T01:34:29Z","updated_at":"2014-09-26T10:12:37Z","pushed_at":"2014-09-30T19:21:20Z","git_url":"git://github.com/JDutil/spree_marketplace.git","ssh_url":"git@github.com:JDutil/spree_marketplace.git","clone_url":"https://github.com/JDutil/spree_marketplace.git","svn_url":"https://github.com/JDutil/spree_marketplace","homepage":null,"size":449,"stargazers_count":30,"watchers_count":30,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"open_issues_count":1,"forks":22,"open_issues":1,"watchers":30,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JDutil/spree_marketplace/pulls/10"},"html":{"href":"https://github.com/JDutil/spree_marketplace/pull/10"},"issue":{"href":"https://api.github.com/repos/JDutil/spree_marketplace/issues/10"},"comments":{"href":"https://api.github.com/repos/JDutil/spree_marketplace/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/JDutil/spree_marketplace/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/JDutil/spree_marketplace/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/JDutil/spree_marketplace/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/JDutil/spree_marketplace/statuses/b02b0c9e85108f800eb97d2ec185829121f9632b"}}}}