GitHub PullRequestReviewCommentEvent at 2014-07-24 22:55:06
Repository: FirefoxSearch
Actor: ericedens
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/ericedens/FirefoxSearch/pulls/comments/15378055","id":15378055,"diff_hunk":"@@ -145,13 +152,45 @@ public void onSubmit(String text) {\n         suggestionDropdown.setOnItemClickListener(new AdapterView.OnItemClickListener() {\n             @Override\n             public void onItemClick(AdapterView<?> parent, View view, int position, long id) {\n+                final int[] location = new int[2];\n+                view.getLocationOnScreen(location);\n+                animationText.setTranslationY(location[1]);\n+\n                 final Suggestion suggestion = (Suggestion) suggestionDropdown.getItemAtPosition(position);\n+                animationText.setText(suggestion.value);\n+                animationText.setVisibility(View.VISIBLE);\n+\n+                final int translationY = getResources().getDimensionPixelSize(R.dimen.animation_text_translation_y);\n+                animationText.animate().translationY(translationY).setListener(new Animator.AnimatorListener() {\n+                    @Override\n+                    public void onAnimationStart(Animator animation) {\n+\n+                    }\n+\n+                    @Override\n+                    public void onAnimationEnd(Animator animation) {\n+                        setSearchTerm(suggestion.value);\n+                        animationText.setVisibility(View.GONE);\n+                    }\n+\n+                    @Override\n+                    public void onAnimationCancel(Animator animation) {\n+\n+                    }\n+\n+                    @Override\n+                    public void onAnimationRepeat(Animator animation) {\n+\n+                    }\n+                });\n \n                 transitionToWaiting();\n                 searchListener.onSearch(suggestion.value);\n             }\n         });\n \n+        animationText = (TextView) mainView.findViewById(R.id.animation_text);","path":"app/src/main/java/org/mozilla/search/autocomplete/SearchFragment.java","position":null,"original_position":76,"commit_id":"f8e7f19b788f345ebc31f8bad4224e19a686224b","original_commit_id":"f57d6c28420abfebf29cd7cd5902639490fe8bb9","user":{"login":"ericedens","id":575626,"avatar_url":"https://avatars.githubusercontent.com/u/575626?","gravatar_id":"4e7070546880542bc03567cdfe2dfed4","url":"https://api.github.com/users/ericedens","html_url":"https://github.com/ericedens","followers_url":"https://api.github.com/users/ericedens/followers","following_url":"https://api.github.com/users/ericedens/following{/other_user}","gists_url":"https://api.github.com/users/ericedens/gists{/gist_id}","starred_url":"https://api.github.com/users/ericedens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericedens/subscriptions","organizations_url":"https://api.github.com/users/ericedens/orgs","repos_url":"https://api.github.com/users/ericedens/repos","events_url":"https://api.github.com/users/ericedens/events{/privacy}","received_events_url":"https://api.github.com/users/ericedens/received_events","type":"User","site_admin":false},"body":"Since this gets used in the above click listener, it would help the reader if this went above the setOnItemClickListener ","created_at":"2014-07-24T22:55:06Z","updated_at":"2014-07-24T22:55:06Z","html_url":"https://github.com/ericedens/FirefoxSearch/pull/32#discussion_r15378055","pull_request_url":"https://api.github.com/repos/ericedens/FirefoxSearch/pulls/32","_links":{"self":{"href":"https://api.github.com/repos/ericedens/FirefoxSearch/pulls/comments/15378055"},"html":{"href":"https://github.com/ericedens/FirefoxSearch/pull/32#discussion_r15378055"},"pull_request":{"href":"https://api.github.com/repos/ericedens/FirefoxSearch/pulls/32"}}},"pull_request":{"url":"https://api.github.com/repos/ericedens/FirefoxSearch/pulls/32","id":18867102,"html_url":"https://github.com/ericedens/FirefoxSearch/pull/32","diff_url":"https://github.com/ericedens/FirefoxSearch/pull/32.diff","patch_url":"https://github.com/ericedens/FirefoxSearch/pull/32.patch","issue_url":"https://api.github.com/repos/ericedens/FirefoxSearch/issues/32","number":32,"state":"open","title":"Bug 1042189 - Implement interaction designs for selecting a suggestion/history item","user":{"login":"leibovic","id":163176,"avatar_url":"https://avatars.githubusercontent.com/u/163176?","gravatar_id":"9878b2a2629e131ec58a9760e2733b2f","url":"https://api.github.com/users/leibovic","html_url":"https://github.com/leibovic","followers_url":"https://api.github.com/users/leibovic/followers","following_url":"https://api.github.com/users/leibovic/following{/other_user}","gists_url":"https://api.github.com/users/leibovic/gists{/gist_id}","starred_url":"https://api.github.com/users/leibovic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leibovic/subscriptions","organizations_url":"https://api.github.com/users/leibovic/orgs","repos_url":"https://api.github.com/users/leibovic/repos","events_url":"https://api.github.com/users/leibovic/events{/privacy}","received_events_url":"https://api.github.com/users/leibovic/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-07-24T22:00:40Z","updated_at":"2014-07-24T22:55:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f1f14dfcce5f2fd4bf95b8b7a8f1eb98b2208ea5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ericedens/FirefoxSearch/pulls/32/commits","review_comments_url":"https://api.github.com/repos/ericedens/FirefoxSearch/pulls/32/comments","review_comment_url":"https://api.github.com/repos/ericedens/FirefoxSearch/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ericedens/FirefoxSearch/issues/32/comments","statuses_url":"https://api.github.com/repos/ericedens/FirefoxSearch/statuses/f8e7f19b788f345ebc31f8bad4224e19a686224b","head":{"label":"leibovic:animations","ref":"animations","sha":"f8e7f19b788f345ebc31f8bad4224e19a686224b","user":{"login":"leibovic","id":163176,"avatar_url":"https://avatars.githubusercontent.com/u/163176?","gravatar_id":"9878b2a2629e131ec58a9760e2733b2f","url":"https://api.github.com/users/leibovic","html_url":"https://github.com/leibovic","followers_url":"https://api.github.com/users/leibovic/followers","following_url":"https://api.github.com/users/leibovic/following{/other_user}","gists_url":"https://api.github.com/users/leibovic/gists{/gist_id}","starred_url":"https://api.github.com/users/leibovic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leibovic/subscriptions","organizations_url":"https://api.github.com/users/leibovic/orgs","repos_url":"https://api.github.com/users/leibovic/repos","events_url":"https://api.github.com/users/leibovic/events{/privacy}","received_events_url":"https://api.github.com/users/leibovic/received_events","type":"User","site_admin":false},"repo":{"id":20811916,"name":"FirefoxSearch","full_name":"leibovic/FirefoxSearch","owner":{"login":"leibovic","id":163176,"avatar_url":"https://avatars.githubusercontent.com/u/163176?","gravatar_id":"9878b2a2629e131ec58a9760e2733b2f","url":"https://api.github.com/users/leibovic","html_url":"https://github.com/leibovic","followers_url":"https://api.github.com/users/leibovic/followers","following_url":"https://api.github.com/users/leibovic/following{/other_user}","gists_url":"https://api.github.com/users/leibovic/gists{/gist_id}","starred_url":"https://api.github.com/users/leibovic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leibovic/subscriptions","organizations_url":"https://api.github.com/users/leibovic/orgs","repos_url":"https://api.github.com/users/leibovic/repos","events_url":"https://api.github.com/users/leibovic/events{/privacy}","received_events_url":"https://api.github.com/users/leibovic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/leibovic/FirefoxSearch","description":"","fork":true,"url":"https://api.github.com/repos/leibovic/FirefoxSearch","forks_url":"https://api.github.com/repos/leibovic/FirefoxSearch/forks","keys_url":"https://api.github.com/repos/leibovic/FirefoxSearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/leibovic/FirefoxSearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/leibovic/FirefoxSearch/teams","hooks_url":"https://api.github.com/repos/leibovic/FirefoxSearch/hooks","issue_events_url":"https://api.github.com/repos/leibovic/FirefoxSearch/issues/events{/number}","events_url":"https://api.github.com/repos/leibovic/FirefoxSearch/events","assignees_url":"https://api.github.com/repos/leibovic/FirefoxSearch/assignees{/user}","branches_url":"https://api.github.com/repos/leibovic/FirefoxSearch/branches{/branch}","tags_url":"https://api.github.com/repos/leibovic/FirefoxSearch/tags","blobs_url":"https://api.github.com/repos/leibovic/FirefoxSearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/leibovic/FirefoxSearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/leibovic/FirefoxSearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/leibovic/FirefoxSearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/leibovic/FirefoxSearch/statuses/{sha}","languages_url":"https://api.github.com/repos/leibovic/FirefoxSearch/languages","stargazers_url":"https://api.github.com/repos/leibovic/FirefoxSearch/stargazers","contributors_url":"https://api.github.com/repos/leibovic/FirefoxSearch/contributors","subscribers_url":"https://api.github.com/repos/leibovic/FirefoxSearch/subscribers","subscription_url":"https://api.github.com/repos/leibovic/FirefoxSearch/subscription","commits_url":"https://api.github.com/repos/leibovic/FirefoxSearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/leibovic/FirefoxSearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/leibovic/FirefoxSearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/leibovic/FirefoxSearch/issues/comments/{number}","contents_url":"https://api.github.com/repos/leibovic/FirefoxSearch/contents/{+path}","compare_url":"https://api.github.com/repos/leibovic/FirefoxSearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/leibovic/FirefoxSearch/merges","archive_url":"https://api.github.com/repos/leibovic/FirefoxSearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/leibovic/FirefoxSearch/downloads","issues_url":"https://api.github.com/repos/leibovic/FirefoxSearch/issues{/number}","pulls_url":"https://api.github.com/repos/leibovic/FirefoxSearch/pulls{/number}","milestones_url":"https://api.github.com/repos/leibovic/FirefoxSearch/milestones{/number}","notifications_url":"https://api.github.com/repos/leibovic/FirefoxSearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/leibovic/FirefoxSearch/labels{/name}","releases_url":"https://api.github.com/repos/leibovic/FirefoxSearch/releases{/id}","created_at":"2014-06-13T17:22:19Z","updated_at":"2014-07-14T15:47:09Z","pushed_at":"2014-07-24T22:53:05Z","git_url":"git://github.com/leibovic/FirefoxSearch.git","ssh_url":"git@github.com:leibovic/FirefoxSearch.git","clone_url":"https://github.com/leibovic/FirefoxSearch.git","svn_url":"https://github.com/leibovic/FirefoxSearch","homepage":null,"size":53553,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"ericedens:master","ref":"master","sha":"3c1a5ff09689e1fb3d48efa95cfab3884ca7e6bb","user":{"login":"ericedens","id":575626,"avatar_url":"https://avatars.githubusercontent.com/u/575626?","gravatar_id":"4e7070546880542bc03567cdfe2dfed4","url":"https://api.github.com/users/ericedens","html_url":"https://github.com/ericedens","followers_url":"https://api.github.com/users/ericedens/followers","following_url":"https://api.github.com/users/ericedens/following{/other_user}","gists_url":"https://api.github.com/users/ericedens/gists{/gist_id}","starred_url":"https://api.github.com/users/ericedens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericedens/subscriptions","organizations_url":"https://api.github.com/users/ericedens/orgs","repos_url":"https://api.github.com/users/ericedens/repos","events_url":"https://api.github.com/users/ericedens/events{/privacy}","received_events_url":"https://api.github.com/users/ericedens/received_events","type":"User","site_admin":false},"repo":{"id":20545863,"name":"FirefoxSearch","full_name":"ericedens/FirefoxSearch","owner":{"login":"ericedens","id":575626,"avatar_url":"https://avatars.githubusercontent.com/u/575626?","gravatar_id":"4e7070546880542bc03567cdfe2dfed4","url":"https://api.github.com/users/ericedens","html_url":"https://github.com/ericedens","followers_url":"https://api.github.com/users/ericedens/followers","following_url":"https://api.github.com/users/ericedens/following{/other_user}","gists_url":"https://api.github.com/users/ericedens/gists{/gist_id}","starred_url":"https://api.github.com/users/ericedens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericedens/subscriptions","organizations_url":"https://api.github.com/users/ericedens/orgs","repos_url":"https://api.github.com/users/ericedens/repos","events_url":"https://api.github.com/users/ericedens/events{/privacy}","received_events_url":"https://api.github.com/users/ericedens/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ericedens/FirefoxSearch","description":"","fork":false,"url":"https://api.github.com/repos/ericedens/FirefoxSearch","forks_url":"https://api.github.com/repos/ericedens/FirefoxSearch/forks","keys_url":"https://api.github.com/repos/ericedens/FirefoxSearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ericedens/FirefoxSearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ericedens/FirefoxSearch/teams","hooks_url":"https://api.github.com/repos/ericedens/FirefoxSearch/hooks","issue_events_url":"https://api.github.com/repos/ericedens/FirefoxSearch/issues/events{/number}","events_url":"https://api.github.com/repos/ericedens/FirefoxSearch/events","assignees_url":"https://api.github.com/repos/ericedens/FirefoxSearch/assignees{/user}","branches_url":"https://api.github.com/repos/ericedens/FirefoxSearch/branches{/branch}","tags_url":"https://api.github.com/repos/ericedens/FirefoxSearch/tags","blobs_url":"https://api.github.com/repos/ericedens/FirefoxSearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ericedens/FirefoxSearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ericedens/FirefoxSearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/ericedens/FirefoxSearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ericedens/FirefoxSearch/statuses/{sha}","languages_url":"https://api.github.com/repos/ericedens/FirefoxSearch/languages","stargazers_url":"https://api.github.com/repos/ericedens/FirefoxSearch/stargazers","contributors_url":"https://api.github.com/repos/ericedens/FirefoxSearch/contributors","subscribers_url":"https://api.github.com/repos/ericedens/FirefoxSearch/subscribers","subscription_url":"https://api.github.com/repos/ericedens/FirefoxSearch/subscription","commits_url":"https://api.github.com/repos/ericedens/FirefoxSearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/ericedens/FirefoxSearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/ericedens/FirefoxSearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/ericedens/FirefoxSearch/issues/comments/{number}","contents_url":"https://api.github.com/repos/ericedens/FirefoxSearch/contents/{+path}","compare_url":"https://api.github.com/repos/ericedens/FirefoxSearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ericedens/FirefoxSearch/merges","archive_url":"https://api.github.com/repos/ericedens/FirefoxSearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ericedens/FirefoxSearch/downloads","issues_url":"https://api.github.com/repos/ericedens/FirefoxSearch/issues{/number}","pulls_url":"https://api.github.com/repos/ericedens/FirefoxSearch/pulls{/number}","milestones_url":"https://api.github.com/repos/ericedens/FirefoxSearch/milestones{/number}","notifications_url":"https://api.github.com/repos/ericedens/FirefoxSearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ericedens/FirefoxSearch/labels{/name}","releases_url":"https://api.github.com/repos/ericedens/FirefoxSearch/releases{/id}","created_at":"2014-06-06T00:11:40Z","updated_at":"2014-06-27T00:01:51Z","pushed_at":"2014-07-24T18:47:07Z","git_url":"git://github.com/ericedens/FirefoxSearch.git","ssh_url":"git@github.com:ericedens/FirefoxSearch.git","clone_url":"https://github.com/ericedens/FirefoxSearch.git","svn_url":"https://github.com/ericedens/FirefoxSearch","homepage":"https://wiki.mozilla.org/Mobile/Projects/Search_activity","size":54713,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":3,"mirror_url":null,"open_issues_count":3,"forks":3,"open_issues":3,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ericedens/FirefoxSearch/pulls/32"},"html":{"href":"https://github.com/ericedens/FirefoxSearch/pull/32"},"issue":{"href":"https://api.github.com/repos/ericedens/FirefoxSearch/issues/32"},"comments":{"href":"https://api.github.com/repos/ericedens/FirefoxSearch/issues/32/comments"},"review_comments":{"href":"https://api.github.com/repos/ericedens/FirefoxSearch/pulls/32/comments"},"review_comment":{"href":"https://api.github.com/repos/ericedens/FirefoxSearch/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ericedens/FirefoxSearch/pulls/32/commits"},"statuses":{"href":"https://api.github.com/repos/ericedens/FirefoxSearch/statuses/f8e7f19b788f345ebc31f8bad4224e19a686224b"}}}}