GitHub PullRequestReviewCommentEvent at 2014-07-24 21:37:43
Repository: etcd
Actor: bmizerany
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/etcd-team/etcd/pulls/comments/15374675","id":15374675,"diff_hunk":"@@ -151,6 +157,8 @@ type stateMachine struct {\n \tpendingConf bool\n \n \tsnapshoter Snapshoter\n+\n+\tunstableState *State","path":"raft/raft.go","position":18,"original_position":18,"commit_id":"d1e8caa76c1ca0e45c62d83d8e81849e94043923","original_commit_id":"d1e8caa76c1ca0e45c62d83d8e81849e94043923","user":{"login":"bmizerany","id":46,"avatar_url":"https://avatars.githubusercontent.com/u/46?","gravatar_id":"1a250566b475961b9b36abf359950c76","url":"https://api.github.com/users/bmizerany","html_url":"https://github.com/bmizerany","followers_url":"https://api.github.com/users/bmizerany/followers","following_url":"https://api.github.com/users/bmizerany/following{/other_user}","gists_url":"https://api.github.com/users/bmizerany/gists{/gist_id}","starred_url":"https://api.github.com/users/bmizerany/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmizerany/subscriptions","organizations_url":"https://api.github.com/users/bmizerany/orgs","repos_url":"https://api.github.com/users/bmizerany/repos","events_url":"https://api.github.com/users/bmizerany/events{/privacy}","received_events_url":"https://api.github.com/users/bmizerany/received_events","type":"User","site_admin":false},"body":"this doesn't need to be a pointer, does it?","created_at":"2014-07-24T21:37:43Z","updated_at":"2014-07-24T21:37:43Z","html_url":"https://github.com/etcd-team/etcd/pull/11#discussion_r15374675","pull_request_url":"https://api.github.com/repos/etcd-team/etcd/pulls/11","_links":{"self":{"href":"https://api.github.com/repos/etcd-team/etcd/pulls/comments/15374675"},"html":{"href":"https://github.com/etcd-team/etcd/pull/11#discussion_r15374675"},"pull_request":{"href":"https://api.github.com/repos/etcd-team/etcd/pulls/11"}}},"pull_request":{"url":"https://api.github.com/repos/etcd-team/etcd/pulls/11","id":18865649,"html_url":"https://github.com/etcd-team/etcd/pull/11","diff_url":"https://github.com/etcd-team/etcd/pull/11.diff","patch_url":"https://github.com/etcd-team/etcd/pull/11.patch","issue_url":"https://api.github.com/repos/etcd-team/etcd/issues/11","number":11,"state":"open","title":"Raft log","user":{"login":"xiangli-cmu","id":4479947,"avatar_url":"https://avatars.githubusercontent.com/u/4479947?","gravatar_id":"6e8c5245322d3c3a0a523683800a784c","url":"https://api.github.com/users/xiangli-cmu","html_url":"https://github.com/xiangli-cmu","followers_url":"https://api.github.com/users/xiangli-cmu/followers","following_url":"https://api.github.com/users/xiangli-cmu/following{/other_user}","gists_url":"https://api.github.com/users/xiangli-cmu/gists{/gist_id}","starred_url":"https://api.github.com/users/xiangli-cmu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiangli-cmu/subscriptions","organizations_url":"https://api.github.com/users/xiangli-cmu/orgs","repos_url":"https://api.github.com/users/xiangli-cmu/repos","events_url":"https://api.github.com/users/xiangli-cmu/events{/privacy}","received_events_url":"https://api.github.com/users/xiangli-cmu/received_events","type":"User","site_admin":false},"body":"Prepare for persistency. \r\nWe need to persist:\r\n1. new log entries\r\n2. term change\r\n3. vote change\r\n4. configuration change (via persist commitIndex)\r\nbefore send out any reply message after Node.Step. \r\n\r\nThe workflow will be \r\n```go\r\nn.Step(m)\r\nwal.SaveEnts(n.UnstableEnts())\r\nwal.SaveState(n.UnstableState())\r\npeerHub.Send(n.Msgs())\r\n```\r\n@bmizerany @unihorn \r\n","created_at":"2014-07-24T21:33:44Z","updated_at":"2014-07-24T21:37:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1098985a68c429af40d71a51b21922d1736f8e4d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/etcd-team/etcd/pulls/11/commits","review_comments_url":"https://api.github.com/repos/etcd-team/etcd/pulls/11/comments","review_comment_url":"https://api.github.com/repos/etcd-team/etcd/pulls/comments/{number}","comments_url":"https://api.github.com/repos/etcd-team/etcd/issues/11/comments","statuses_url":"https://api.github.com/repos/etcd-team/etcd/statuses/d1e8caa76c1ca0e45c62d83d8e81849e94043923","head":{"label":"etcd-team:raft_log","ref":"raft_log","sha":"d1e8caa76c1ca0e45c62d83d8e81849e94043923","user":{"login":"etcd-team","id":8051688,"avatar_url":"https://avatars.githubusercontent.com/u/8051688?","gravatar_id":"f13feb2b979ec588a3f68701106cebac","url":"https://api.github.com/users/etcd-team","html_url":"https://github.com/etcd-team","followers_url":"https://api.github.com/users/etcd-team/followers","following_url":"https://api.github.com/users/etcd-team/following{/other_user}","gists_url":"https://api.github.com/users/etcd-team/gists{/gist_id}","starred_url":"https://api.github.com/users/etcd-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etcd-team/subscriptions","organizations_url":"https://api.github.com/users/etcd-team/orgs","repos_url":"https://api.github.com/users/etcd-team/repos","events_url":"https://api.github.com/users/etcd-team/events{/privacy}","received_events_url":"https://api.github.com/users/etcd-team/received_events","type":"Organization","site_admin":false},"repo":{"id":21439350,"name":"etcd","full_name":"etcd-team/etcd","owner":{"login":"etcd-team","id":8051688,"avatar_url":"https://avatars.githubusercontent.com/u/8051688?","gravatar_id":"f13feb2b979ec588a3f68701106cebac","url":"https://api.github.com/users/etcd-team","html_url":"https://github.com/etcd-team","followers_url":"https://api.github.com/users/etcd-team/followers","following_url":"https://api.github.com/users/etcd-team/following{/other_user}","gists_url":"https://api.github.com/users/etcd-team/gists{/gist_id}","starred_url":"https://api.github.com/users/etcd-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etcd-team/subscriptions","organizations_url":"https://api.github.com/users/etcd-team/orgs","repos_url":"https://api.github.com/users/etcd-team/repos","events_url":"https://api.github.com/users/etcd-team/events{/privacy}","received_events_url":"https://api.github.com/users/etcd-team/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/etcd-team/etcd","description":"A highly-available key value store for shared configuration and service discovery","fork":true,"url":"https://api.github.com/repos/etcd-team/etcd","forks_url":"https://api.github.com/repos/etcd-team/etcd/forks","keys_url":"https://api.github.com/repos/etcd-team/etcd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/etcd-team/etcd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/etcd-team/etcd/teams","hooks_url":"https://api.github.com/repos/etcd-team/etcd/hooks","issue_events_url":"https://api.github.com/repos/etcd-team/etcd/issues/events{/number}","events_url":"https://api.github.com/repos/etcd-team/etcd/events","assignees_url":"https://api.github.com/repos/etcd-team/etcd/assignees{/user}","branches_url":"https://api.github.com/repos/etcd-team/etcd/branches{/branch}","tags_url":"https://api.github.com/repos/etcd-team/etcd/tags","blobs_url":"https://api.github.com/repos/etcd-team/etcd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/etcd-team/etcd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/etcd-team/etcd/git/refs{/sha}","trees_url":"https://api.github.com/repos/etcd-team/etcd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/etcd-team/etcd/statuses/{sha}","languages_url":"https://api.github.com/repos/etcd-team/etcd/languages","stargazers_url":"https://api.github.com/repos/etcd-team/etcd/stargazers","contributors_url":"https://api.github.com/repos/etcd-team/etcd/contributors","subscribers_url":"https://api.github.com/repos/etcd-team/etcd/subscribers","subscription_url":"https://api.github.com/repos/etcd-team/etcd/subscription","commits_url":"https://api.github.com/repos/etcd-team/etcd/commits{/sha}","git_commits_url":"https://api.github.com/repos/etcd-team/etcd/git/commits{/sha}","comments_url":"https://api.github.com/repos/etcd-team/etcd/comments{/number}","issue_comment_url":"https://api.github.com/repos/etcd-team/etcd/issues/comments/{number}","contents_url":"https://api.github.com/repos/etcd-team/etcd/contents/{+path}","compare_url":"https://api.github.com/repos/etcd-team/etcd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/etcd-team/etcd/merges","archive_url":"https://api.github.com/repos/etcd-team/etcd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/etcd-team/etcd/downloads","issues_url":"https://api.github.com/repos/etcd-team/etcd/issues{/number}","pulls_url":"https://api.github.com/repos/etcd-team/etcd/pulls{/number}","milestones_url":"https://api.github.com/repos/etcd-team/etcd/milestones{/number}","notifications_url":"https://api.github.com/repos/etcd-team/etcd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/etcd-team/etcd/labels{/name}","releases_url":"https://api.github.com/repos/etcd-team/etcd/releases{/id}","created_at":"2014-07-02T20:28:29Z","updated_at":"2014-07-08T21:57:58Z","pushed_at":"2014-07-24T21:29:39Z","git_url":"git://github.com/etcd-team/etcd.git","ssh_url":"git@github.com:etcd-team/etcd.git","clone_url":"https://github.com/etcd-team/etcd.git","svn_url":"https://github.com/etcd-team/etcd","homepage":"","size":12703,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"etcd-team:raft","ref":"raft","sha":"11609f16c6fccf192d03be84a5c1bc09237015b0","user":{"login":"etcd-team","id":8051688,"avatar_url":"https://avatars.githubusercontent.com/u/8051688?","gravatar_id":"f13feb2b979ec588a3f68701106cebac","url":"https://api.github.com/users/etcd-team","html_url":"https://github.com/etcd-team","followers_url":"https://api.github.com/users/etcd-team/followers","following_url":"https://api.github.com/users/etcd-team/following{/other_user}","gists_url":"https://api.github.com/users/etcd-team/gists{/gist_id}","starred_url":"https://api.github.com/users/etcd-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etcd-team/subscriptions","organizations_url":"https://api.github.com/users/etcd-team/orgs","repos_url":"https://api.github.com/users/etcd-team/repos","events_url":"https://api.github.com/users/etcd-team/events{/privacy}","received_events_url":"https://api.github.com/users/etcd-team/received_events","type":"Organization","site_admin":false},"repo":{"id":21439350,"name":"etcd","full_name":"etcd-team/etcd","owner":{"login":"etcd-team","id":8051688,"avatar_url":"https://avatars.githubusercontent.com/u/8051688?","gravatar_id":"f13feb2b979ec588a3f68701106cebac","url":"https://api.github.com/users/etcd-team","html_url":"https://github.com/etcd-team","followers_url":"https://api.github.com/users/etcd-team/followers","following_url":"https://api.github.com/users/etcd-team/following{/other_user}","gists_url":"https://api.github.com/users/etcd-team/gists{/gist_id}","starred_url":"https://api.github.com/users/etcd-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etcd-team/subscriptions","organizations_url":"https://api.github.com/users/etcd-team/orgs","repos_url":"https://api.github.com/users/etcd-team/repos","events_url":"https://api.github.com/users/etcd-team/events{/privacy}","received_events_url":"https://api.github.com/users/etcd-team/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/etcd-team/etcd","description":"A highly-available key value store for shared configuration and service discovery","fork":true,"url":"https://api.github.com/repos/etcd-team/etcd","forks_url":"https://api.github.com/repos/etcd-team/etcd/forks","keys_url":"https://api.github.com/repos/etcd-team/etcd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/etcd-team/etcd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/etcd-team/etcd/teams","hooks_url":"https://api.github.com/repos/etcd-team/etcd/hooks","issue_events_url":"https://api.github.com/repos/etcd-team/etcd/issues/events{/number}","events_url":"https://api.github.com/repos/etcd-team/etcd/events","assignees_url":"https://api.github.com/repos/etcd-team/etcd/assignees{/user}","branches_url":"https://api.github.com/repos/etcd-team/etcd/branches{/branch}","tags_url":"https://api.github.com/repos/etcd-team/etcd/tags","blobs_url":"https://api.github.com/repos/etcd-team/etcd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/etcd-team/etcd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/etcd-team/etcd/git/refs{/sha}","trees_url":"https://api.github.com/repos/etcd-team/etcd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/etcd-team/etcd/statuses/{sha}","languages_url":"https://api.github.com/repos/etcd-team/etcd/languages","stargazers_url":"https://api.github.com/repos/etcd-team/etcd/stargazers","contributors_url":"https://api.github.com/repos/etcd-team/etcd/contributors","subscribers_url":"https://api.github.com/repos/etcd-team/etcd/subscribers","subscription_url":"https://api.github.com/repos/etcd-team/etcd/subscription","commits_url":"https://api.github.com/repos/etcd-team/etcd/commits{/sha}","git_commits_url":"https://api.github.com/repos/etcd-team/etcd/git/commits{/sha}","comments_url":"https://api.github.com/repos/etcd-team/etcd/comments{/number}","issue_comment_url":"https://api.github.com/repos/etcd-team/etcd/issues/comments/{number}","contents_url":"https://api.github.com/repos/etcd-team/etcd/contents/{+path}","compare_url":"https://api.github.com/repos/etcd-team/etcd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/etcd-team/etcd/merges","archive_url":"https://api.github.com/repos/etcd-team/etcd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/etcd-team/etcd/downloads","issues_url":"https://api.github.com/repos/etcd-team/etcd/issues{/number}","pulls_url":"https://api.github.com/repos/etcd-team/etcd/pulls{/number}","milestones_url":"https://api.github.com/repos/etcd-team/etcd/milestones{/number}","notifications_url":"https://api.github.com/repos/etcd-team/etcd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/etcd-team/etcd/labels{/name}","releases_url":"https://api.github.com/repos/etcd-team/etcd/releases{/id}","created_at":"2014-07-02T20:28:29Z","updated_at":"2014-07-08T21:57:58Z","pushed_at":"2014-07-24T21:29:39Z","git_url":"git://github.com/etcd-team/etcd.git","ssh_url":"git@github.com:etcd-team/etcd.git","clone_url":"https://github.com/etcd-team/etcd.git","svn_url":"https://github.com/etcd-team/etcd","homepage":"","size":12703,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/etcd-team/etcd/pulls/11"},"html":{"href":"https://github.com/etcd-team/etcd/pull/11"},"issue":{"href":"https://api.github.com/repos/etcd-team/etcd/issues/11"},"comments":{"href":"https://api.github.com/repos/etcd-team/etcd/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/etcd-team/etcd/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/etcd-team/etcd/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/etcd-team/etcd/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/etcd-team/etcd/statuses/d1e8caa76c1ca0e45c62d83d8e81849e94043923"}}}}