GitHub PullRequestReviewCommentEvent at 2014-11-07 18:10:46
Repository: ohanzee-helpers
Actor: shadowhand
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/kohana/ohanzee-helpers/pulls/comments/20026342","id":20026342,"diff_hunk":"@@ -45,6 +45,128 @@\n class File\n {\n     /**\n+     * Version of [Kohana::find_files()](http://kohanaframework.org/)\n+     *\n+     * Recursively finds all of the files in the directory at any\n+     * location, and returns an array of all the files found,\n+     * sorted alphabetically.\n+     *\n+     *     // Find all view files.\n+     *     $views = File::list_files('views');\n+     *\n+     * @param   string $directory directory path\n+     * @throws \\Exception Directory not exist or not readable\n+     * @return  array\n+     */\n+    public static function listFiles($directory)\n+    {\n+        if ( ! is_readable($directory))\n+            throw new \\Exception('Directory `'.$directory.'` not exist or not readable');","path":"src/File.php","position":20,"original_position":20,"commit_id":"dfcf319feed7a48f6a0e168e013fa648d8d13a8e","original_commit_id":"dfcf319feed7a48f6a0e168e013fa648d8d13a8e","user":{"login":"shadowhand","id":38203,"avatar_url":"https://avatars.githubusercontent.com/u/38203?v=3","gravatar_id":"","url":"https://api.github.com/users/shadowhand","html_url":"https://github.com/shadowhand","followers_url":"https://api.github.com/users/shadowhand/followers","following_url":"https://api.github.com/users/shadowhand/following{/other_user}","gists_url":"https://api.github.com/users/shadowhand/gists{/gist_id}","starred_url":"https://api.github.com/users/shadowhand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shadowhand/subscriptions","organizations_url":"https://api.github.com/users/shadowhand/orgs","repos_url":"https://api.github.com/users/shadowhand/repos","events_url":"https://api.github.com/users/shadowhand/events{/privacy}","received_events_url":"https://api.github.com/users/shadowhand/received_events","type":"User","site_admin":false},"body":"would like to see this use `sprintf` for ease of readability. and using a `InvalidArgumentException` would probably be more appropriate than generic `Exception`.","created_at":"2014-11-07T18:10:46Z","updated_at":"2014-11-07T18:10:46Z","html_url":"https://github.com/kohana/ohanzee-helpers/pull/10#discussion_r20026342","pull_request_url":"https://api.github.com/repos/kohana/ohanzee-helpers/pulls/10","_links":{"self":{"href":"https://api.github.com/repos/kohana/ohanzee-helpers/pulls/comments/20026342"},"html":{"href":"https://github.com/kohana/ohanzee-helpers/pull/10#discussion_r20026342"},"pull_request":{"href":"https://api.github.com/repos/kohana/ohanzee-helpers/pulls/10"}}},"pull_request":{"url":"https://api.github.com/repos/kohana/ohanzee-helpers/pulls/10","id":17653899,"html_url":"https://github.com/kohana/ohanzee-helpers/pull/10","diff_url":"https://github.com/kohana/ohanzee-helpers/pull/10.diff","patch_url":"https://github.com/kohana/ohanzee-helpers/pull/10.patch","issue_url":"https://api.github.com/repos/kohana/ohanzee-helpers/issues/10","number":10,"state":"open","locked":false,"title":"feature: add method arrayKeys with an additional support for ArrayObject","user":{"login":"serieznyi","id":2323142,"avatar_url":"https://avatars.githubusercontent.com/u/2323142?v=3","gravatar_id":"","url":"https://api.github.com/users/serieznyi","html_url":"https://github.com/serieznyi","followers_url":"https://api.github.com/users/serieznyi/followers","following_url":"https://api.github.com/users/serieznyi/following{/other_user}","gists_url":"https://api.github.com/users/serieznyi/gists{/gist_id}","starred_url":"https://api.github.com/users/serieznyi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serieznyi/subscriptions","organizations_url":"https://api.github.com/users/serieznyi/orgs","repos_url":"https://api.github.com/users/serieznyi/repos","events_url":"https://api.github.com/users/serieznyi/events{/privacy}","received_events_url":"https://api.github.com/users/serieznyi/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-06-26T15:13:57Z","updated_at":"2014-11-07T18:10:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4befff2bd030feba0f134f92ece55b49f94a0178","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/kohana/ohanzee-helpers/pulls/10/commits","review_comments_url":"https://api.github.com/repos/kohana/ohanzee-helpers/pulls/10/comments","review_comment_url":"https://api.github.com/repos/kohana/ohanzee-helpers/pulls/comments/{number}","comments_url":"https://api.github.com/repos/kohana/ohanzee-helpers/issues/10/comments","statuses_url":"https://api.github.com/repos/kohana/ohanzee-helpers/statuses/dfcf319feed7a48f6a0e168e013fa648d8d13a8e","head":{"label":"serieznyi:develop","ref":"develop","sha":"dfcf319feed7a48f6a0e168e013fa648d8d13a8e","user":{"login":"serieznyi","id":2323142,"avatar_url":"https://avatars.githubusercontent.com/u/2323142?v=3","gravatar_id":"","url":"https://api.github.com/users/serieznyi","html_url":"https://github.com/serieznyi","followers_url":"https://api.github.com/users/serieznyi/followers","following_url":"https://api.github.com/users/serieznyi/following{/other_user}","gists_url":"https://api.github.com/users/serieznyi/gists{/gist_id}","starred_url":"https://api.github.com/users/serieznyi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serieznyi/subscriptions","organizations_url":"https://api.github.com/users/serieznyi/orgs","repos_url":"https://api.github.com/users/serieznyi/repos","events_url":"https://api.github.com/users/serieznyi/events{/privacy}","received_events_url":"https://api.github.com/users/serieznyi/received_events","type":"User","site_admin":false},"repo":{"id":21235623,"name":"ohanzee-helpers","full_name":"serieznyi/ohanzee-helpers","owner":{"login":"serieznyi","id":2323142,"avatar_url":"https://avatars.githubusercontent.com/u/2323142?v=3","gravatar_id":"","url":"https://api.github.com/users/serieznyi","html_url":"https://github.com/serieznyi","followers_url":"https://api.github.com/users/serieznyi/followers","following_url":"https://api.github.com/users/serieznyi/following{/other_user}","gists_url":"https://api.github.com/users/serieznyi/gists{/gist_id}","starred_url":"https://api.github.com/users/serieznyi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serieznyi/subscriptions","organizations_url":"https://api.github.com/users/serieznyi/orgs","repos_url":"https://api.github.com/users/serieznyi/repos","events_url":"https://api.github.com/users/serieznyi/events{/privacy}","received_events_url":"https://api.github.com/users/serieznyi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/serieznyi/ohanzee-helpers","description":"PHP extend library","fork":true,"url":"https://api.github.com/repos/serieznyi/ohanzee-helpers","forks_url":"https://api.github.com/repos/serieznyi/ohanzee-helpers/forks","keys_url":"https://api.github.com/repos/serieznyi/ohanzee-helpers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/serieznyi/ohanzee-helpers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/serieznyi/ohanzee-helpers/teams","hooks_url":"https://api.github.com/repos/serieznyi/ohanzee-helpers/hooks","issue_events_url":"https://api.github.com/repos/serieznyi/ohanzee-helpers/issues/events{/number}","events_url":"https://api.github.com/repos/serieznyi/ohanzee-helpers/events","assignees_url":"https://api.github.com/repos/serieznyi/ohanzee-helpers/assignees{/user}","branches_url":"https://api.github.com/repos/serieznyi/ohanzee-helpers/branches{/branch}","tags_url":"https://api.github.com/repos/serieznyi/ohanzee-helpers/tags","blobs_url":"https://api.github.com/repos/serieznyi/ohanzee-helpers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/serieznyi/ohanzee-helpers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/serieznyi/ohanzee-helpers/git/refs{/sha}","trees_url":"https://api.github.com/repos/serieznyi/ohanzee-helpers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/serieznyi/ohanzee-helpers/statuses/{sha}","languages_url":"https://api.github.com/repos/serieznyi/ohanzee-helpers/languages","stargazers_url":"https://api.github.com/repos/serieznyi/ohanzee-helpers/stargazers","contributors_url":"https://api.github.com/repos/serieznyi/ohanzee-helpers/contributors","subscribers_url":"https://api.github.com/repos/serieznyi/ohanzee-helpers/subscribers","subscription_url":"https://api.github.com/repos/serieznyi/ohanzee-helpers/subscription","commits_url":"https://api.github.com/repos/serieznyi/ohanzee-helpers/commits{/sha}","git_commits_url":"https://api.github.com/repos/serieznyi/ohanzee-helpers/git/commits{/sha}","comments_url":"https://api.github.com/repos/serieznyi/ohanzee-helpers/comments{/number}","issue_comment_url":"https://api.github.com/repos/serieznyi/ohanzee-helpers/issues/comments/{number}","contents_url":"https://api.github.com/repos/serieznyi/ohanzee-helpers/contents/{+path}","compare_url":"https://api.github.com/repos/serieznyi/ohanzee-helpers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/serieznyi/ohanzee-helpers/merges","archive_url":"https://api.github.com/repos/serieznyi/ohanzee-helpers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/serieznyi/ohanzee-helpers/downloads","issues_url":"https://api.github.com/repos/serieznyi/ohanzee-helpers/issues{/number}","pulls_url":"https://api.github.com/repos/serieznyi/ohanzee-helpers/pulls{/number}","milestones_url":"https://api.github.com/repos/serieznyi/ohanzee-helpers/milestones{/number}","notifications_url":"https://api.github.com/repos/serieznyi/ohanzee-helpers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/serieznyi/ohanzee-helpers/labels{/name}","releases_url":"https://api.github.com/repos/serieznyi/ohanzee-helpers/releases{/id}","created_at":"2014-06-26T09:38:02Z","updated_at":"2014-06-26T22:48:12Z","pushed_at":"2014-10-03T19:00:16Z","git_url":"git://github.com/serieznyi/ohanzee-helpers.git","ssh_url":"git@github.com:serieznyi/ohanzee-helpers.git","clone_url":"https://github.com/serieznyi/ohanzee-helpers.git","svn_url":"https://github.com/serieznyi/ohanzee-helpers","homepage":"","size":213,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"base":{"label":"kohana:master","ref":"master","sha":"0b7cf7038abb09a0ff48101c1e151e37c252297a","user":{"login":"kohana","id":39584,"avatar_url":"https://avatars.githubusercontent.com/u/39584?v=3","gravatar_id":"","url":"https://api.github.com/users/kohana","html_url":"https://github.com/kohana","followers_url":"https://api.github.com/users/kohana/followers","following_url":"https://api.github.com/users/kohana/following{/other_user}","gists_url":"https://api.github.com/users/kohana/gists{/gist_id}","starred_url":"https://api.github.com/users/kohana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kohana/subscriptions","organizations_url":"https://api.github.com/users/kohana/orgs","repos_url":"https://api.github.com/users/kohana/repos","events_url":"https://api.github.com/users/kohana/events{/privacy}","received_events_url":"https://api.github.com/users/kohana/received_events","type":"Organization","site_admin":false},"repo":{"id":16844972,"name":"ohanzee-helpers","full_name":"kohana/ohanzee-helpers","owner":{"login":"kohana","id":39584,"avatar_url":"https://avatars.githubusercontent.com/u/39584?v=3","gravatar_id":"","url":"https://api.github.com/users/kohana","html_url":"https://github.com/kohana","followers_url":"https://api.github.com/users/kohana/followers","following_url":"https://api.github.com/users/kohana/following{/other_user}","gists_url":"https://api.github.com/users/kohana/gists{/gist_id}","starred_url":"https://api.github.com/users/kohana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kohana/subscriptions","organizations_url":"https://api.github.com/users/kohana/orgs","repos_url":"https://api.github.com/users/kohana/repos","events_url":"https://api.github.com/users/kohana/events{/privacy}","received_events_url":"https://api.github.com/users/kohana/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kohana/ohanzee-helpers","description":null,"fork":false,"url":"https://api.github.com/repos/kohana/ohanzee-helpers","forks_url":"https://api.github.com/repos/kohana/ohanzee-helpers/forks","keys_url":"https://api.github.com/repos/kohana/ohanzee-helpers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kohana/ohanzee-helpers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kohana/ohanzee-helpers/teams","hooks_url":"https://api.github.com/repos/kohana/ohanzee-helpers/hooks","issue_events_url":"https://api.github.com/repos/kohana/ohanzee-helpers/issues/events{/number}","events_url":"https://api.github.com/repos/kohana/ohanzee-helpers/events","assignees_url":"https://api.github.com/repos/kohana/ohanzee-helpers/assignees{/user}","branches_url":"https://api.github.com/repos/kohana/ohanzee-helpers/branches{/branch}","tags_url":"https://api.github.com/repos/kohana/ohanzee-helpers/tags","blobs_url":"https://api.github.com/repos/kohana/ohanzee-helpers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kohana/ohanzee-helpers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kohana/ohanzee-helpers/git/refs{/sha}","trees_url":"https://api.github.com/repos/kohana/ohanzee-helpers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kohana/ohanzee-helpers/statuses/{sha}","languages_url":"https://api.github.com/repos/kohana/ohanzee-helpers/languages","stargazers_url":"https://api.github.com/repos/kohana/ohanzee-helpers/stargazers","contributors_url":"https://api.github.com/repos/kohana/ohanzee-helpers/contributors","subscribers_url":"https://api.github.com/repos/kohana/ohanzee-helpers/subscribers","subscription_url":"https://api.github.com/repos/kohana/ohanzee-helpers/subscription","commits_url":"https://api.github.com/repos/kohana/ohanzee-helpers/commits{/sha}","git_commits_url":"https://api.github.com/repos/kohana/ohanzee-helpers/git/commits{/sha}","comments_url":"https://api.github.com/repos/kohana/ohanzee-helpers/comments{/number}","issue_comment_url":"https://api.github.com/repos/kohana/ohanzee-helpers/issues/comments/{number}","contents_url":"https://api.github.com/repos/kohana/ohanzee-helpers/contents/{+path}","compare_url":"https://api.github.com/repos/kohana/ohanzee-helpers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kohana/ohanzee-helpers/merges","archive_url":"https://api.github.com/repos/kohana/ohanzee-helpers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kohana/ohanzee-helpers/downloads","issues_url":"https://api.github.com/repos/kohana/ohanzee-helpers/issues{/number}","pulls_url":"https://api.github.com/repos/kohana/ohanzee-helpers/pulls{/number}","milestones_url":"https://api.github.com/repos/kohana/ohanzee-helpers/milestones{/number}","notifications_url":"https://api.github.com/repos/kohana/ohanzee-helpers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kohana/ohanzee-helpers/labels{/name}","releases_url":"https://api.github.com/repos/kohana/ohanzee-helpers/releases{/id}","created_at":"2014-02-14T17:56:30Z","updated_at":"2014-10-07T17:11:28Z","pushed_at":"2014-04-20T19:25:11Z","git_url":"git://github.com/kohana/ohanzee-helpers.git","ssh_url":"git@github.com:kohana/ohanzee-helpers.git","clone_url":"https://github.com/kohana/ohanzee-helpers.git","svn_url":"https://github.com/kohana/ohanzee-helpers","homepage":null,"size":304,"stargazers_count":51,"watchers_count":51,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":8,"forks":10,"open_issues":8,"watchers":51,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kohana/ohanzee-helpers/pulls/10"},"html":{"href":"https://github.com/kohana/ohanzee-helpers/pull/10"},"issue":{"href":"https://api.github.com/repos/kohana/ohanzee-helpers/issues/10"},"comments":{"href":"https://api.github.com/repos/kohana/ohanzee-helpers/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/kohana/ohanzee-helpers/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/kohana/ohanzee-helpers/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/kohana/ohanzee-helpers/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/kohana/ohanzee-helpers/statuses/dfcf319feed7a48f6a0e168e013fa648d8d13a8e"}}}}