GitHub PullRequestReviewCommentEvent at 2014-10-16 12:11:50
Repository: javaServer
Actor: ericmeyer
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/bspatafora/javaServer/pulls/comments/18951345","id":18951345,"diff_hunk":"@@ -50,4 +51,30 @@ void not_allowed() {\n         response.setStatus(Status.NOT_ALLOWED);\n         response.addHeader(Header.ALLOW + HTTP.allowedMethods(FileHandler.class));\n     }\n+\n+    private Boolean requestIsPartial() {","path":"src/com/bspatafora/cobspec/handlers/FileHandler.java","position":53,"original_position":53,"commit_id":"9d4740939aa1e1b0a826fd74fac0aa207b61db4f","original_commit_id":"9d4740939aa1e1b0a826fd74fac0aa207b61db4f","user":{"login":"ericmeyer","id":34542,"avatar_url":"https://avatars.githubusercontent.com/u/34542?v=2","gravatar_id":"","url":"https://api.github.com/users/ericmeyer","html_url":"https://github.com/ericmeyer","followers_url":"https://api.github.com/users/ericmeyer/followers","following_url":"https://api.github.com/users/ericmeyer/following{/other_user}","gists_url":"https://api.github.com/users/ericmeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/ericmeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericmeyer/subscriptions","organizations_url":"https://api.github.com/users/ericmeyer/orgs","repos_url":"https://api.github.com/users/ericmeyer/repos","events_url":"https://api.github.com/users/ericmeyer/events{/privacy}","received_events_url":"https://api.github.com/users/ericmeyer/received_events","type":"User","site_admin":false},"body":"Anytime that I see something like this where the method name is `nounVerb()`, I always wonder if `verb()` should be a method on the `Noun` class (`noun.verb()`). So in this case, you would have `request.isPartial()`.\r\n\r\nI don't know that this particular example is a candidate for that refactoring, but in general this pattern is a \"code-smell\" that I try to be on the lookout for.","created_at":"2014-10-16T12:11:50Z","updated_at":"2014-10-16T12:11:50Z","html_url":"https://github.com/bspatafora/javaServer/pull/3#discussion_r18951345","pull_request_url":"https://api.github.com/repos/bspatafora/javaServer/pulls/3","_links":{"self":{"href":"https://api.github.com/repos/bspatafora/javaServer/pulls/comments/18951345"},"html":{"href":"https://github.com/bspatafora/javaServer/pull/3#discussion_r18951345"},"pull_request":{"href":"https://api.github.com/repos/bspatafora/javaServer/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/bspatafora/javaServer/pulls/3","id":22454867,"html_url":"https://github.com/bspatafora/javaServer/pull/3","diff_url":"https://github.com/bspatafora/javaServer/pull/3.diff","patch_url":"https://github.com/bspatafora/javaServer/pull/3.patch","issue_url":"https://api.github.com/repos/bspatafora/javaServer/issues/3","number":3,"state":"closed","locked":false,"title":"Handle partial GET requests to /partial_content.txt","user":{"login":"bspatafora","id":3577655,"avatar_url":"https://avatars.githubusercontent.com/u/3577655?v=2","gravatar_id":"","url":"https://api.github.com/users/bspatafora","html_url":"https://github.com/bspatafora","followers_url":"https://api.github.com/users/bspatafora/followers","following_url":"https://api.github.com/users/bspatafora/following{/other_user}","gists_url":"https://api.github.com/users/bspatafora/gists{/gist_id}","starred_url":"https://api.github.com/users/bspatafora/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bspatafora/subscriptions","organizations_url":"https://api.github.com/users/bspatafora/orgs","repos_url":"https://api.github.com/users/bspatafora/repos","events_url":"https://api.github.com/users/bspatafora/events{/privacy}","received_events_url":"https://api.github.com/users/bspatafora/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-10-08T21:07:54Z","updated_at":"2014-10-16T12:11:50Z","closed_at":"2014-10-08T21:07:59Z","merged_at":"2014-10-08T21:07:59Z","merge_commit_sha":"23f79349c85be2400531f1d6025a703aadf4b433","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bspatafora/javaServer/pulls/3/commits","review_comments_url":"https://api.github.com/repos/bspatafora/javaServer/pulls/3/comments","review_comment_url":"https://api.github.com/repos/bspatafora/javaServer/pulls/comments/{number}","comments_url":"https://api.github.com/repos/bspatafora/javaServer/issues/3/comments","statuses_url":"https://api.github.com/repos/bspatafora/javaServer/statuses/9d4740939aa1e1b0a826fd74fac0aa207b61db4f","head":{"label":"bspatafora:partial-content","ref":"partial-content","sha":"9d4740939aa1e1b0a826fd74fac0aa207b61db4f","user":{"login":"bspatafora","id":3577655,"avatar_url":"https://avatars.githubusercontent.com/u/3577655?v=2","gravatar_id":"","url":"https://api.github.com/users/bspatafora","html_url":"https://github.com/bspatafora","followers_url":"https://api.github.com/users/bspatafora/followers","following_url":"https://api.github.com/users/bspatafora/following{/other_user}","gists_url":"https://api.github.com/users/bspatafora/gists{/gist_id}","starred_url":"https://api.github.com/users/bspatafora/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bspatafora/subscriptions","organizations_url":"https://api.github.com/users/bspatafora/orgs","repos_url":"https://api.github.com/users/bspatafora/repos","events_url":"https://api.github.com/users/bspatafora/events{/privacy}","received_events_url":"https://api.github.com/users/bspatafora/received_events","type":"User","site_admin":false},"repo":{"id":23597349,"name":"javaServer","full_name":"bspatafora/javaServer","owner":{"login":"bspatafora","id":3577655,"avatar_url":"https://avatars.githubusercontent.com/u/3577655?v=2","gravatar_id":"","url":"https://api.github.com/users/bspatafora","html_url":"https://github.com/bspatafora","followers_url":"https://api.github.com/users/bspatafora/followers","following_url":"https://api.github.com/users/bspatafora/following{/other_user}","gists_url":"https://api.github.com/users/bspatafora/gists{/gist_id}","starred_url":"https://api.github.com/users/bspatafora/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bspatafora/subscriptions","organizations_url":"https://api.github.com/users/bspatafora/orgs","repos_url":"https://api.github.com/users/bspatafora/repos","events_url":"https://api.github.com/users/bspatafora/events{/privacy}","received_events_url":"https://api.github.com/users/bspatafora/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bspatafora/javaServer","description":"","fork":false,"url":"https://api.github.com/repos/bspatafora/javaServer","forks_url":"https://api.github.com/repos/bspatafora/javaServer/forks","keys_url":"https://api.github.com/repos/bspatafora/javaServer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bspatafora/javaServer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bspatafora/javaServer/teams","hooks_url":"https://api.github.com/repos/bspatafora/javaServer/hooks","issue_events_url":"https://api.github.com/repos/bspatafora/javaServer/issues/events{/number}","events_url":"https://api.github.com/repos/bspatafora/javaServer/events","assignees_url":"https://api.github.com/repos/bspatafora/javaServer/assignees{/user}","branches_url":"https://api.github.com/repos/bspatafora/javaServer/branches{/branch}","tags_url":"https://api.github.com/repos/bspatafora/javaServer/tags","blobs_url":"https://api.github.com/repos/bspatafora/javaServer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bspatafora/javaServer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bspatafora/javaServer/git/refs{/sha}","trees_url":"https://api.github.com/repos/bspatafora/javaServer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bspatafora/javaServer/statuses/{sha}","languages_url":"https://api.github.com/repos/bspatafora/javaServer/languages","stargazers_url":"https://api.github.com/repos/bspatafora/javaServer/stargazers","contributors_url":"https://api.github.com/repos/bspatafora/javaServer/contributors","subscribers_url":"https://api.github.com/repos/bspatafora/javaServer/subscribers","subscription_url":"https://api.github.com/repos/bspatafora/javaServer/subscription","commits_url":"https://api.github.com/repos/bspatafora/javaServer/commits{/sha}","git_commits_url":"https://api.github.com/repos/bspatafora/javaServer/git/commits{/sha}","comments_url":"https://api.github.com/repos/bspatafora/javaServer/comments{/number}","issue_comment_url":"https://api.github.com/repos/bspatafora/javaServer/issues/comments/{number}","contents_url":"https://api.github.com/repos/bspatafora/javaServer/contents/{+path}","compare_url":"https://api.github.com/repos/bspatafora/javaServer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bspatafora/javaServer/merges","archive_url":"https://api.github.com/repos/bspatafora/javaServer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bspatafora/javaServer/downloads","issues_url":"https://api.github.com/repos/bspatafora/javaServer/issues{/number}","pulls_url":"https://api.github.com/repos/bspatafora/javaServer/pulls{/number}","milestones_url":"https://api.github.com/repos/bspatafora/javaServer/milestones{/number}","notifications_url":"https://api.github.com/repos/bspatafora/javaServer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bspatafora/javaServer/labels{/name}","releases_url":"https://api.github.com/repos/bspatafora/javaServer/releases{/id}","created_at":"2014-09-02T22:06:52Z","updated_at":"2014-10-13T21:02:32Z","pushed_at":"2014-10-13T21:34:54Z","git_url":"git://github.com/bspatafora/javaServer.git","ssh_url":"git@github.com:bspatafora/javaServer.git","clone_url":"https://github.com/bspatafora/javaServer.git","svn_url":"https://github.com/bspatafora/javaServer","homepage":null,"size":2596,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bspatafora:master","ref":"master","sha":"86184ee55b42680cc531d795e07a9715935d5c1c","user":{"login":"bspatafora","id":3577655,"avatar_url":"https://avatars.githubusercontent.com/u/3577655?v=2","gravatar_id":"","url":"https://api.github.com/users/bspatafora","html_url":"https://github.com/bspatafora","followers_url":"https://api.github.com/users/bspatafora/followers","following_url":"https://api.github.com/users/bspatafora/following{/other_user}","gists_url":"https://api.github.com/users/bspatafora/gists{/gist_id}","starred_url":"https://api.github.com/users/bspatafora/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bspatafora/subscriptions","organizations_url":"https://api.github.com/users/bspatafora/orgs","repos_url":"https://api.github.com/users/bspatafora/repos","events_url":"https://api.github.com/users/bspatafora/events{/privacy}","received_events_url":"https://api.github.com/users/bspatafora/received_events","type":"User","site_admin":false},"repo":{"id":23597349,"name":"javaServer","full_name":"bspatafora/javaServer","owner":{"login":"bspatafora","id":3577655,"avatar_url":"https://avatars.githubusercontent.com/u/3577655?v=2","gravatar_id":"","url":"https://api.github.com/users/bspatafora","html_url":"https://github.com/bspatafora","followers_url":"https://api.github.com/users/bspatafora/followers","following_url":"https://api.github.com/users/bspatafora/following{/other_user}","gists_url":"https://api.github.com/users/bspatafora/gists{/gist_id}","starred_url":"https://api.github.com/users/bspatafora/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bspatafora/subscriptions","organizations_url":"https://api.github.com/users/bspatafora/orgs","repos_url":"https://api.github.com/users/bspatafora/repos","events_url":"https://api.github.com/users/bspatafora/events{/privacy}","received_events_url":"https://api.github.com/users/bspatafora/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bspatafora/javaServer","description":"","fork":false,"url":"https://api.github.com/repos/bspatafora/javaServer","forks_url":"https://api.github.com/repos/bspatafora/javaServer/forks","keys_url":"https://api.github.com/repos/bspatafora/javaServer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bspatafora/javaServer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bspatafora/javaServer/teams","hooks_url":"https://api.github.com/repos/bspatafora/javaServer/hooks","issue_events_url":"https://api.github.com/repos/bspatafora/javaServer/issues/events{/number}","events_url":"https://api.github.com/repos/bspatafora/javaServer/events","assignees_url":"https://api.github.com/repos/bspatafora/javaServer/assignees{/user}","branches_url":"https://api.github.com/repos/bspatafora/javaServer/branches{/branch}","tags_url":"https://api.github.com/repos/bspatafora/javaServer/tags","blobs_url":"https://api.github.com/repos/bspatafora/javaServer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bspatafora/javaServer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bspatafora/javaServer/git/refs{/sha}","trees_url":"https://api.github.com/repos/bspatafora/javaServer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bspatafora/javaServer/statuses/{sha}","languages_url":"https://api.github.com/repos/bspatafora/javaServer/languages","stargazers_url":"https://api.github.com/repos/bspatafora/javaServer/stargazers","contributors_url":"https://api.github.com/repos/bspatafora/javaServer/contributors","subscribers_url":"https://api.github.com/repos/bspatafora/javaServer/subscribers","subscription_url":"https://api.github.com/repos/bspatafora/javaServer/subscription","commits_url":"https://api.github.com/repos/bspatafora/javaServer/commits{/sha}","git_commits_url":"https://api.github.com/repos/bspatafora/javaServer/git/commits{/sha}","comments_url":"https://api.github.com/repos/bspatafora/javaServer/comments{/number}","issue_comment_url":"https://api.github.com/repos/bspatafora/javaServer/issues/comments/{number}","contents_url":"https://api.github.com/repos/bspatafora/javaServer/contents/{+path}","compare_url":"https://api.github.com/repos/bspatafora/javaServer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bspatafora/javaServer/merges","archive_url":"https://api.github.com/repos/bspatafora/javaServer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bspatafora/javaServer/downloads","issues_url":"https://api.github.com/repos/bspatafora/javaServer/issues{/number}","pulls_url":"https://api.github.com/repos/bspatafora/javaServer/pulls{/number}","milestones_url":"https://api.github.com/repos/bspatafora/javaServer/milestones{/number}","notifications_url":"https://api.github.com/repos/bspatafora/javaServer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bspatafora/javaServer/labels{/name}","releases_url":"https://api.github.com/repos/bspatafora/javaServer/releases{/id}","created_at":"2014-09-02T22:06:52Z","updated_at":"2014-10-13T21:02:32Z","pushed_at":"2014-10-13T21:34:54Z","git_url":"git://github.com/bspatafora/javaServer.git","ssh_url":"git@github.com:bspatafora/javaServer.git","clone_url":"https://github.com/bspatafora/javaServer.git","svn_url":"https://github.com/bspatafora/javaServer","homepage":null,"size":2596,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bspatafora/javaServer/pulls/3"},"html":{"href":"https://github.com/bspatafora/javaServer/pull/3"},"issue":{"href":"https://api.github.com/repos/bspatafora/javaServer/issues/3"},"comments":{"href":"https://api.github.com/repos/bspatafora/javaServer/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/bspatafora/javaServer/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/bspatafora/javaServer/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/bspatafora/javaServer/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/bspatafora/javaServer/statuses/9d4740939aa1e1b0a826fd74fac0aa207b61db4f"}}}}