GitHub PushEvent at 2014-09-19 13:48:20
Repository: kombu
Actor: beav
Payload: {"shas":[["eb7e5083ac65aeeb4177339e9436c37b09861610","03e21a0d39faa13c55059cac4154dae3101e7499@redhat.com","1124589 - Support both ANONYMOUS and PLAIN sasl_mechanisms\n\nPreviously, Kombu only supported the `PLAIN` sasl_mechanism by default.\nHowever, qpidd only supports `ANONYMOUS` by default. This change sets the\ndefault mechanisms to both `ANONYMOUS` and `PLAIN`, and also removes the\ndefault password of \"guest\" since qpid does not ship with a default SASL db[1].\nThe password is now set to '' by default[2].\n\nWhile working on this issue, we discovered that qpid.messaging exhibits\ndifferent sasl_mechanism selection behavior depending on whether or not\n**saslwrapper** is installed. If it is not installed and both `PLAIN` and\n`ANONYMOUS` are listed as mechs, `PLAIN` is used first if a username and\npassword are defined for the connection. However, if **saslwrapper** is\ninstalled on the client, `sasl_client_start()` is called to determine the mech.\nThis function treats `PLAIN` and `ANONYMOUS` as the same strength. This can\nresult in surprising behavior for the user in circumstances where they were\nusing `PLAIN`, then installed **saslwrapper** and started getting the\n`ANONYMOUS` mech.\n\nTo normalize the sasl_mechanism selection behavior, first sort the mechs so\nthat `ANONYMOUS` is last, and then attempt a connection with each mech\nindividually. If it fails, we move on to the next mech.\n\n**NOTE**: This patch also resolves an unrelated issue where `qpid_patches.py` would\nattempt to import the qpid system library but instead get `qpid.py` that lived\nin the same dir. This only occurred in Python 2.6. See [3] for more detail.\n\n[1] https://issues.apache.org/jira/browse/QPID-6091\n[2] https://issues.apache.org/jira/browse/QPID-6109\n[3] http://legacy.python.org/dev/peps/pep-0328/#rationale-for-absolute-imports","Chris Duryee",true]],"size":1,"ref":"refs/heads/mech-select","head":"eb7e5083ac65aeeb4177339e9436c37b09861610"}