GitHub PullRequestEvent at 2014-04-24 15:15:26
Repository: bitshares_toolkit
Actor: nmushegian
Payload: {"action":"closed","number":35,"pull_request":{"url":"https://api.github.com/repos/BitShares/bitshares_toolkit/pulls/35","id":15030319,"html_url":"https://github.com/BitShares/bitshares_toolkit/pull/35","diff_url":"https://github.com/BitShares/bitshares_toolkit/pull/35.diff","patch_url":"https://github.com/BitShares/bitshares_toolkit/pull/35.patch","issue_url":"https://api.github.com/repos/BitShares/bitshares_toolkit/issues/35","number":35,"state":"closed","title":"Disable echo of password in btsx client (Issue #29)","user":{"login":"valzav","id":28658,"avatar_url":"https://avatars.githubusercontent.com/u/28658?","gravatar_id":"4cc8ae9a163daaf0c7534a82aa1021ec","url":"https://api.github.com/users/valzav","html_url":"https://github.com/valzav","followers_url":"https://api.github.com/users/valzav/followers","following_url":"https://api.github.com/users/valzav/following{/other_user}","gists_url":"https://api.github.com/users/valzav/gists{/gist_id}","starred_url":"https://api.github.com/users/valzav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/valzav/subscriptions","organizations_url":"https://api.github.com/users/valzav/orgs","repos_url":"https://api.github.com/users/valzav/repos","events_url":"https://api.github.com/users/valzav/events{/privacy}","received_events_url":"https://api.github.com/users/valzav/received_events","type":"User","site_admin":false},"body":"I added bool _no_echo_ argument to get_line with default value of false to make it compatible with single argument calls.\r\nPlease let me know if you want me to rename it to just _echo_ so it wouldn't sound double negative (no_echo = false), so it would be get_line( const std::string& prompt = \">>> \", bool echo = true ).\r\n\r\nI've tested it on Os X and Linux - works fine, I can test a Windows version as well but it will take me a little while to setup Windows environment.","created_at":"2014-04-22T19:10:23Z","updated_at":"2014-04-24T15:15:26Z","closed_at":"2014-04-24T15:15:26Z","merged_at":"2014-04-24T15:15:26Z","merge_commit_sha":"8c94b78656cf3930bd69d7af9efede4bd986c0b6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/BitShares/bitshares_toolkit/pulls/35/commits","review_comments_url":"https://api.github.com/repos/BitShares/bitshares_toolkit/pulls/35/comments","review_comment_url":"https://api.github.com/repos/BitShares/bitshares_toolkit/pulls/comments/{number}","comments_url":"https://api.github.com/repos/BitShares/bitshares_toolkit/issues/35/comments","statuses_url":"https://api.github.com/repos/BitShares/bitshares_toolkit/statuses/12a9af193e6bb00da6ab93cb96608be990c8ab36","head":{"label":"valzav:master","ref":"master","sha":"12a9af193e6bb00da6ab93cb96608be990c8ab36","user":{"login":"valzav","id":28658,"avatar_url":"https://avatars.githubusercontent.com/u/28658?","gravatar_id":"4cc8ae9a163daaf0c7534a82aa1021ec","url":"https://api.github.com/users/valzav","html_url":"https://github.com/valzav","followers_url":"https://api.github.com/users/valzav/followers","following_url":"https://api.github.com/users/valzav/following{/other_user}","gists_url":"https://api.github.com/users/valzav/gists{/gist_id}","starred_url":"https://api.github.com/users/valzav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/valzav/subscriptions","organizations_url":"https://api.github.com/users/valzav/orgs","repos_url":"https://api.github.com/users/valzav/repos","events_url":"https://api.github.com/users/valzav/events{/privacy}","received_events_url":"https://api.github.com/users/valzav/received_events","type":"User","site_admin":false},"repo":{"id":18888283,"name":"bitshares_toolkit","full_name":"valzav/bitshares_toolkit","owner":{"login":"valzav","id":28658,"avatar_url":"https://avatars.githubusercontent.com/u/28658?","gravatar_id":"4cc8ae9a163daaf0c7534a82aa1021ec","url":"https://api.github.com/users/valzav","html_url":"https://github.com/valzav","followers_url":"https://api.github.com/users/valzav/followers","following_url":"https://api.github.com/users/valzav/following{/other_user}","gists_url":"https://api.github.com/users/valzav/gists{/gist_id}","starred_url":"https://api.github.com/users/valzav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/valzav/subscriptions","organizations_url":"https://api.github.com/users/valzav/orgs","repos_url":"https://api.github.com/users/valzav/repos","events_url":"https://api.github.com/users/valzav/events{/privacy}","received_events_url":"https://api.github.com/users/valzav/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/valzav/bitshares_toolkit","description":"Libraries and Utilities for building DACs","fork":true,"url":"https://api.github.com/repos/valzav/bitshares_toolkit","forks_url":"https://api.github.com/repos/valzav/bitshares_toolkit/forks","keys_url":"https://api.github.com/repos/valzav/bitshares_toolkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/valzav/bitshares_toolkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/valzav/bitshares_toolkit/teams","hooks_url":"https://api.github.com/repos/valzav/bitshares_toolkit/hooks","issue_events_url":"https://api.github.com/repos/valzav/bitshares_toolkit/issues/events{/number}","events_url":"https://api.github.com/repos/valzav/bitshares_toolkit/events","assignees_url":"https://api.github.com/repos/valzav/bitshares_toolkit/assignees{/user}","branches_url":"https://api.github.com/repos/valzav/bitshares_toolkit/branches{/branch}","tags_url":"https://api.github.com/repos/valzav/bitshares_toolkit/tags","blobs_url":"https://api.github.com/repos/valzav/bitshares_toolkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/valzav/bitshares_toolkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/valzav/bitshares_toolkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/valzav/bitshares_toolkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/valzav/bitshares_toolkit/statuses/{sha}","languages_url":"https://api.github.com/repos/valzav/bitshares_toolkit/languages","stargazers_url":"https://api.github.com/repos/valzav/bitshares_toolkit/stargazers","contributors_url":"https://api.github.com/repos/valzav/bitshares_toolkit/contributors","subscribers_url":"https://api.github.com/repos/valzav/bitshares_toolkit/subscribers","subscription_url":"https://api.github.com/repos/valzav/bitshares_toolkit/subscription","commits_url":"https://api.github.com/repos/valzav/bitshares_toolkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/valzav/bitshares_toolkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/valzav/bitshares_toolkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/valzav/bitshares_toolkit/issues/comments/{number}","contents_url":"https://api.github.com/repos/valzav/bitshares_toolkit/contents/{+path}","compare_url":"https://api.github.com/repos/valzav/bitshares_toolkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/valzav/bitshares_toolkit/merges","archive_url":"https://api.github.com/repos/valzav/bitshares_toolkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/valzav/bitshares_toolkit/downloads","issues_url":"https://api.github.com/repos/valzav/bitshares_toolkit/issues{/number}","pulls_url":"https://api.github.com/repos/valzav/bitshares_toolkit/pulls{/number}","milestones_url":"https://api.github.com/repos/valzav/bitshares_toolkit/milestones{/number}","notifications_url":"https://api.github.com/repos/valzav/bitshares_toolkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/valzav/bitshares_toolkit/labels{/name}","releases_url":"https://api.github.com/repos/valzav/bitshares_toolkit/releases{/id}","created_at":"2014-04-17T18:07:09Z","updated_at":"2014-04-24T15:15:26Z","pushed_at":"2014-04-22T18:50:50Z","git_url":"git://github.com/valzav/bitshares_toolkit.git","ssh_url":"git@github.com:valzav/bitshares_toolkit.git","clone_url":"https://github.com/valzav/bitshares_toolkit.git","svn_url":"https://github.com/valzav/bitshares_toolkit","homepage":null,"size":634,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"BitShares:master","ref":"master","sha":"5e9870a967daadc8a9ad6f447ce2d41dd18bee36","user":{"login":"BitShares","id":6914094,"avatar_url":"https://avatars.githubusercontent.com/u/6914094?","gravatar_id":null,"url":"https://api.github.com/users/BitShares","html_url":"https://github.com/BitShares","followers_url":"https://api.github.com/users/BitShares/followers","following_url":"https://api.github.com/users/BitShares/following{/other_user}","gists_url":"https://api.github.com/users/BitShares/gists{/gist_id}","starred_url":"https://api.github.com/users/BitShares/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BitShares/subscriptions","organizations_url":"https://api.github.com/users/BitShares/orgs","repos_url":"https://api.github.com/users/BitShares/repos","events_url":"https://api.github.com/users/BitShares/events{/privacy}","received_events_url":"https://api.github.com/users/BitShares/received_events","type":"Organization","site_admin":false},"repo":{"id":17615687,"name":"bitshares_toolkit","full_name":"BitShares/bitshares_toolkit","owner":{"login":"BitShares","id":6914094,"avatar_url":"https://avatars.githubusercontent.com/u/6914094?","gravatar_id":null,"url":"https://api.github.com/users/BitShares","html_url":"https://github.com/BitShares","followers_url":"https://api.github.com/users/BitShares/followers","following_url":"https://api.github.com/users/BitShares/following{/other_user}","gists_url":"https://api.github.com/users/BitShares/gists{/gist_id}","starred_url":"https://api.github.com/users/BitShares/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BitShares/subscriptions","organizations_url":"https://api.github.com/users/BitShares/orgs","repos_url":"https://api.github.com/users/BitShares/repos","events_url":"https://api.github.com/users/BitShares/events{/privacy}","received_events_url":"https://api.github.com/users/BitShares/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/BitShares/bitshares_toolkit","description":"Libraries and Utilities for building DACs","fork":false,"url":"https://api.github.com/repos/BitShares/bitshares_toolkit","forks_url":"https://api.github.com/repos/BitShares/bitshares_toolkit/forks","keys_url":"https://api.github.com/repos/BitShares/bitshares_toolkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BitShares/bitshares_toolkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BitShares/bitshares_toolkit/teams","hooks_url":"https://api.github.com/repos/BitShares/bitshares_toolkit/hooks","issue_events_url":"https://api.github.com/repos/BitShares/bitshares_toolkit/issues/events{/number}","events_url":"https://api.github.com/repos/BitShares/bitshares_toolkit/events","assignees_url":"https://api.github.com/repos/BitShares/bitshares_toolkit/assignees{/user}","branches_url":"https://api.github.com/repos/BitShares/bitshares_toolkit/branches{/branch}","tags_url":"https://api.github.com/repos/BitShares/bitshares_toolkit/tags","blobs_url":"https://api.github.com/repos/BitShares/bitshares_toolkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BitShares/bitshares_toolkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BitShares/bitshares_toolkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/BitShares/bitshares_toolkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BitShares/bitshares_toolkit/statuses/{sha}","languages_url":"https://api.github.com/repos/BitShares/bitshares_toolkit/languages","stargazers_url":"https://api.github.com/repos/BitShares/bitshares_toolkit/stargazers","contributors_url":"https://api.github.com/repos/BitShares/bitshares_toolkit/contributors","subscribers_url":"https://api.github.com/repos/BitShares/bitshares_toolkit/subscribers","subscription_url":"https://api.github.com/repos/BitShares/bitshares_toolkit/subscription","commits_url":"https://api.github.com/repos/BitShares/bitshares_toolkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/BitShares/bitshares_toolkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/BitShares/bitshares_toolkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/BitShares/bitshares_toolkit/issues/comments/{number}","contents_url":"https://api.github.com/repos/BitShares/bitshares_toolkit/contents/{+path}","compare_url":"https://api.github.com/repos/BitShares/bitshares_toolkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BitShares/bitshares_toolkit/merges","archive_url":"https://api.github.com/repos/BitShares/bitshares_toolkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BitShares/bitshares_toolkit/downloads","issues_url":"https://api.github.com/repos/BitShares/bitshares_toolkit/issues{/number}","pulls_url":"https://api.github.com/repos/BitShares/bitshares_toolkit/pulls{/number}","milestones_url":"https://api.github.com/repos/BitShares/bitshares_toolkit/milestones{/number}","notifications_url":"https://api.github.com/repos/BitShares/bitshares_toolkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BitShares/bitshares_toolkit/labels{/name}","releases_url":"https://api.github.com/repos/BitShares/bitshares_toolkit/releases{/id}","created_at":"2014-03-11T02:21:45Z","updated_at":"2014-04-24T15:15:26Z","pushed_at":"2014-04-24T15:15:26Z","git_url":"git://github.com/BitShares/bitshares_toolkit.git","ssh_url":"git@github.com:BitShares/bitshares_toolkit.git","clone_url":"https://github.com/BitShares/bitshares_toolkit.git","svn_url":"https://github.com/BitShares/bitshares_toolkit","homepage":null,"size":4224,"stargazers_count":14,"watchers_count":14,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":20,"mirror_url":null,"open_issues_count":10,"forks":20,"open_issues":10,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/BitShares/bitshares_toolkit/pulls/35"},"html":{"href":"https://github.com/BitShares/bitshares_toolkit/pull/35"},"issue":{"href":"https://api.github.com/repos/BitShares/bitshares_toolkit/issues/35"},"comments":{"href":"https://api.github.com/repos/BitShares/bitshares_toolkit/issues/35/comments"},"review_comments":{"href":"https://api.github.com/repos/BitShares/bitshares_toolkit/pulls/35/comments"},"review_comment":{"href":"https://api.github.com/repos/BitShares/bitshares_toolkit/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/BitShares/bitshares_toolkit/pulls/35/commits"},"statuses":{"href":"https://api.github.com/repos/BitShares/bitshares_toolkit/statuses/12a9af193e6bb00da6ab93cb96608be990c8ab36"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"nmushegian","id":924397,"avatar_url":"https://avatars.githubusercontent.com/u/924397?","gravatar_id":"ac577b82e002d743e69d93ed0c7e982d","url":"https://api.github.com/users/nmushegian","html_url":"https://github.com/nmushegian","followers_url":"https://api.github.com/users/nmushegian/followers","following_url":"https://api.github.com/users/nmushegian/following{/other_user}","gists_url":"https://api.github.com/users/nmushegian/gists{/gist_id}","starred_url":"https://api.github.com/users/nmushegian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmushegian/subscriptions","organizations_url":"https://api.github.com/users/nmushegian/orgs","repos_url":"https://api.github.com/users/nmushegian/repos","events_url":"https://api.github.com/users/nmushegian/events{/privacy}","received_events_url":"https://api.github.com/users/nmushegian/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":1,"additions":25,"deletions":12,"changed_files":2}}