GitHub PullRequestEvent at 2014-09-21 17:51:00
Repository: pexpect
Actor: takluyver
Payload: {"action":"closed","number":114,"pull_request":{"url":"https://api.github.com/repos/pexpect/pexpect/pulls/114","id":21545982,"html_url":"https://github.com/pexpect/pexpect/pull/114","diff_url":"https://github.com/pexpect/pexpect/pull/114.diff","patch_url":"https://github.com/pexpect/pexpect/pull/114.patch","issue_url":"https://api.github.com/repos/pexpect/pexpect/issues/114","number":114,"state":"closed","locked":false,"title":"enable echo deactivation in pxssh","user":{"login":"erikb85","id":84987,"avatar_url":"https://avatars.githubusercontent.com/u/84987?v=2","gravatar_id":"25d4b4c3c7b8fbabbdc539d2d0167db7","url":"https://api.github.com/users/erikb85","html_url":"https://github.com/erikb85","followers_url":"https://api.github.com/users/erikb85/followers","following_url":"https://api.github.com/users/erikb85/following{/other_user}","gists_url":"https://api.github.com/users/erikb85/gists{/gist_id}","starred_url":"https://api.github.com/users/erikb85/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikb85/subscriptions","organizations_url":"https://api.github.com/users/erikb85/orgs","repos_url":"https://api.github.com/users/erikb85/repos","events_url":"https://api.github.com/users/erikb85/events{/privacy}","received_events_url":"https://api.github.com/users/erikb85/received_events","type":"User","site_admin":false},"body":"I've learned from #112 that you can deactivate echoing of the input via\r\nconstructer parameter. This patch enables pxssh to do the same.\r\n\r\nIn spawn there is an alternative to the constructor parameter, which is\r\n`set_echo(False)`. Sadly that doesn't work, at least in my experiments with\r\nlocalhost.\r\n\r\nSigned-off-by: Erik Bernoth <erik.bernoth@gmail.com>","created_at":"2014-09-21T08:17:17Z","updated_at":"2014-09-21T17:51:00Z","closed_at":"2014-09-21T17:51:00Z","merged_at":"2014-09-21T17:51:00Z","merge_commit_sha":"3ecd089091d7f120853690a943905a5b71f65d6d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/pexpect/pexpect/pulls/114/commits","review_comments_url":"https://api.github.com/repos/pexpect/pexpect/pulls/114/comments","review_comment_url":"https://api.github.com/repos/pexpect/pexpect/pulls/comments/{number}","comments_url":"https://api.github.com/repos/pexpect/pexpect/issues/114/comments","statuses_url":"https://api.github.com/repos/pexpect/pexpect/statuses/00a50fd2a3db40d51ef1a004b20c253993e7eec4","head":{"label":"erikb85:master","ref":"master","sha":"00a50fd2a3db40d51ef1a004b20c253993e7eec4","user":{"login":"erikb85","id":84987,"avatar_url":"https://avatars.githubusercontent.com/u/84987?v=2","gravatar_id":"25d4b4c3c7b8fbabbdc539d2d0167db7","url":"https://api.github.com/users/erikb85","html_url":"https://github.com/erikb85","followers_url":"https://api.github.com/users/erikb85/followers","following_url":"https://api.github.com/users/erikb85/following{/other_user}","gists_url":"https://api.github.com/users/erikb85/gists{/gist_id}","starred_url":"https://api.github.com/users/erikb85/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikb85/subscriptions","organizations_url":"https://api.github.com/users/erikb85/orgs","repos_url":"https://api.github.com/users/erikb85/repos","events_url":"https://api.github.com/users/erikb85/events{/privacy}","received_events_url":"https://api.github.com/users/erikb85/received_events","type":"User","site_admin":false},"repo":{"id":24285785,"name":"pexpect","full_name":"erikb85/pexpect","owner":{"login":"erikb85","id":84987,"avatar_url":"https://avatars.githubusercontent.com/u/84987?v=2","gravatar_id":"25d4b4c3c7b8fbabbdc539d2d0167db7","url":"https://api.github.com/users/erikb85","html_url":"https://github.com/erikb85","followers_url":"https://api.github.com/users/erikb85/followers","following_url":"https://api.github.com/users/erikb85/following{/other_user}","gists_url":"https://api.github.com/users/erikb85/gists{/gist_id}","starred_url":"https://api.github.com/users/erikb85/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikb85/subscriptions","organizations_url":"https://api.github.com/users/erikb85/orgs","repos_url":"https://api.github.com/users/erikb85/repos","events_url":"https://api.github.com/users/erikb85/events{/privacy}","received_events_url":"https://api.github.com/users/erikb85/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/erikb85/pexpect","description":"A Python module for controlling interactive programs in a pseudo-terminal","fork":true,"url":"https://api.github.com/repos/erikb85/pexpect","forks_url":"https://api.github.com/repos/erikb85/pexpect/forks","keys_url":"https://api.github.com/repos/erikb85/pexpect/keys{/key_id}","collaborators_url":"https://api.github.com/repos/erikb85/pexpect/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/erikb85/pexpect/teams","hooks_url":"https://api.github.com/repos/erikb85/pexpect/hooks","issue_events_url":"https://api.github.com/repos/erikb85/pexpect/issues/events{/number}","events_url":"https://api.github.com/repos/erikb85/pexpect/events","assignees_url":"https://api.github.com/repos/erikb85/pexpect/assignees{/user}","branches_url":"https://api.github.com/repos/erikb85/pexpect/branches{/branch}","tags_url":"https://api.github.com/repos/erikb85/pexpect/tags","blobs_url":"https://api.github.com/repos/erikb85/pexpect/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/erikb85/pexpect/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/erikb85/pexpect/git/refs{/sha}","trees_url":"https://api.github.com/repos/erikb85/pexpect/git/trees{/sha}","statuses_url":"https://api.github.com/repos/erikb85/pexpect/statuses/{sha}","languages_url":"https://api.github.com/repos/erikb85/pexpect/languages","stargazers_url":"https://api.github.com/repos/erikb85/pexpect/stargazers","contributors_url":"https://api.github.com/repos/erikb85/pexpect/contributors","subscribers_url":"https://api.github.com/repos/erikb85/pexpect/subscribers","subscription_url":"https://api.github.com/repos/erikb85/pexpect/subscription","commits_url":"https://api.github.com/repos/erikb85/pexpect/commits{/sha}","git_commits_url":"https://api.github.com/repos/erikb85/pexpect/git/commits{/sha}","comments_url":"https://api.github.com/repos/erikb85/pexpect/comments{/number}","issue_comment_url":"https://api.github.com/repos/erikb85/pexpect/issues/comments/{number}","contents_url":"https://api.github.com/repos/erikb85/pexpect/contents/{+path}","compare_url":"https://api.github.com/repos/erikb85/pexpect/compare/{base}...{head}","merges_url":"https://api.github.com/repos/erikb85/pexpect/merges","archive_url":"https://api.github.com/repos/erikb85/pexpect/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/erikb85/pexpect/downloads","issues_url":"https://api.github.com/repos/erikb85/pexpect/issues{/number}","pulls_url":"https://api.github.com/repos/erikb85/pexpect/pulls{/number}","milestones_url":"https://api.github.com/repos/erikb85/pexpect/milestones{/number}","notifications_url":"https://api.github.com/repos/erikb85/pexpect/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/erikb85/pexpect/labels{/name}","releases_url":"https://api.github.com/repos/erikb85/pexpect/releases{/id}","created_at":"2014-09-21T08:14:18Z","updated_at":"2014-09-21T08:14:27Z","pushed_at":"2014-09-21T08:14:28Z","git_url":"git://github.com/erikb85/pexpect.git","ssh_url":"git@github.com:erikb85/pexpect.git","clone_url":"https://github.com/erikb85/pexpect.git","svn_url":"https://github.com/erikb85/pexpect","homepage":"http://pexpect.readthedocs.org/","size":8518,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pexpect:master","ref":"master","sha":"ae950f0b759f5ecb5237c7366e866225373afebc","user":{"login":"pexpect","id":5480175,"avatar_url":"https://avatars.githubusercontent.com/u/5480175?v=2","gravatar_id":null,"url":"https://api.github.com/users/pexpect","html_url":"https://github.com/pexpect","followers_url":"https://api.github.com/users/pexpect/followers","following_url":"https://api.github.com/users/pexpect/following{/other_user}","gists_url":"https://api.github.com/users/pexpect/gists{/gist_id}","starred_url":"https://api.github.com/users/pexpect/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pexpect/subscriptions","organizations_url":"https://api.github.com/users/pexpect/orgs","repos_url":"https://api.github.com/users/pexpect/repos","events_url":"https://api.github.com/users/pexpect/events{/privacy}","received_events_url":"https://api.github.com/users/pexpect/received_events","type":"Organization","site_admin":false},"repo":{"id":12902206,"name":"pexpect","full_name":"pexpect/pexpect","owner":{"login":"pexpect","id":5480175,"avatar_url":"https://avatars.githubusercontent.com/u/5480175?v=2","gravatar_id":null,"url":"https://api.github.com/users/pexpect","html_url":"https://github.com/pexpect","followers_url":"https://api.github.com/users/pexpect/followers","following_url":"https://api.github.com/users/pexpect/following{/other_user}","gists_url":"https://api.github.com/users/pexpect/gists{/gist_id}","starred_url":"https://api.github.com/users/pexpect/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pexpect/subscriptions","organizations_url":"https://api.github.com/users/pexpect/orgs","repos_url":"https://api.github.com/users/pexpect/repos","events_url":"https://api.github.com/users/pexpect/events{/privacy}","received_events_url":"https://api.github.com/users/pexpect/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pexpect/pexpect","description":"A Python module for controlling interactive programs in a pseudo-terminal","fork":false,"url":"https://api.github.com/repos/pexpect/pexpect","forks_url":"https://api.github.com/repos/pexpect/pexpect/forks","keys_url":"https://api.github.com/repos/pexpect/pexpect/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pexpect/pexpect/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pexpect/pexpect/teams","hooks_url":"https://api.github.com/repos/pexpect/pexpect/hooks","issue_events_url":"https://api.github.com/repos/pexpect/pexpect/issues/events{/number}","events_url":"https://api.github.com/repos/pexpect/pexpect/events","assignees_url":"https://api.github.com/repos/pexpect/pexpect/assignees{/user}","branches_url":"https://api.github.com/repos/pexpect/pexpect/branches{/branch}","tags_url":"https://api.github.com/repos/pexpect/pexpect/tags","blobs_url":"https://api.github.com/repos/pexpect/pexpect/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pexpect/pexpect/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pexpect/pexpect/git/refs{/sha}","trees_url":"https://api.github.com/repos/pexpect/pexpect/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pexpect/pexpect/statuses/{sha}","languages_url":"https://api.github.com/repos/pexpect/pexpect/languages","stargazers_url":"https://api.github.com/repos/pexpect/pexpect/stargazers","contributors_url":"https://api.github.com/repos/pexpect/pexpect/contributors","subscribers_url":"https://api.github.com/repos/pexpect/pexpect/subscribers","subscription_url":"https://api.github.com/repos/pexpect/pexpect/subscription","commits_url":"https://api.github.com/repos/pexpect/pexpect/commits{/sha}","git_commits_url":"https://api.github.com/repos/pexpect/pexpect/git/commits{/sha}","comments_url":"https://api.github.com/repos/pexpect/pexpect/comments{/number}","issue_comment_url":"https://api.github.com/repos/pexpect/pexpect/issues/comments/{number}","contents_url":"https://api.github.com/repos/pexpect/pexpect/contents/{+path}","compare_url":"https://api.github.com/repos/pexpect/pexpect/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pexpect/pexpect/merges","archive_url":"https://api.github.com/repos/pexpect/pexpect/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pexpect/pexpect/downloads","issues_url":"https://api.github.com/repos/pexpect/pexpect/issues{/number}","pulls_url":"https://api.github.com/repos/pexpect/pexpect/pulls{/number}","milestones_url":"https://api.github.com/repos/pexpect/pexpect/milestones{/number}","notifications_url":"https://api.github.com/repos/pexpect/pexpect/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pexpect/pexpect/labels{/name}","releases_url":"https://api.github.com/repos/pexpect/pexpect/releases{/id}","created_at":"2013-09-17T17:36:44Z","updated_at":"2014-09-19T11:30:22Z","pushed_at":"2014-09-21T17:51:00Z","git_url":"git://github.com/pexpect/pexpect.git","ssh_url":"git@github.com:pexpect/pexpect.git","clone_url":"https://github.com/pexpect/pexpect.git","svn_url":"https://github.com/pexpect/pexpect","homepage":"http://pexpect.readthedocs.org/","size":11273,"stargazers_count":151,"watchers_count":151,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":44,"mirror_url":null,"open_issues_count":37,"forks":44,"open_issues":37,"watchers":151,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pexpect/pexpect/pulls/114"},"html":{"href":"https://github.com/pexpect/pexpect/pull/114"},"issue":{"href":"https://api.github.com/repos/pexpect/pexpect/issues/114"},"comments":{"href":"https://api.github.com/repos/pexpect/pexpect/issues/114/comments"},"review_comments":{"href":"https://api.github.com/repos/pexpect/pexpect/pulls/114/comments"},"review_comment":{"href":"https://api.github.com/repos/pexpect/pexpect/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/pexpect/pexpect/pulls/114/commits"},"statuses":{"href":"https://api.github.com/repos/pexpect/pexpect/statuses/00a50fd2a3db40d51ef1a004b20c253993e7eec4"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"takluyver","id":327925,"avatar_url":"https://avatars.githubusercontent.com/u/327925?v=2","gravatar_id":"7f1ae3f14fd5b87c2c3f7b36014e185c","url":"https://api.github.com/users/takluyver","html_url":"https://github.com/takluyver","followers_url":"https://api.github.com/users/takluyver/followers","following_url":"https://api.github.com/users/takluyver/following{/other_user}","gists_url":"https://api.github.com/users/takluyver/gists{/gist_id}","starred_url":"https://api.github.com/users/takluyver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/takluyver/subscriptions","organizations_url":"https://api.github.com/users/takluyver/orgs","repos_url":"https://api.github.com/users/takluyver/repos","events_url":"https://api.github.com/users/takluyver/events{/privacy}","received_events_url":"https://api.github.com/users/takluyver/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":2,"deletions":2,"changed_files":1}}