GitHub PullRequestReviewCommentEvent at 2014-10-02 22:56:56
Repository: designax
Actor: adorechic
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/root04/designax/pulls/comments/18373255","id":18373255,"diff_hunk":"@@ -26,8 +26,8 @@ def order_set_params\n     params.require(:order_set).permit(:title, :project_id)\n   end\n \n-  def validate_project_ownership\n-    unless @order_set.project && current_user.member_of?(@order_set.project.organization)\n+  def validate_project_membership\n+    unless @order_set.project && current_user.member_of?(@order_set.project)","path":"app/controllers/order_sets_controller.rb","position":22,"original_position":22,"commit_id":"98c90eee742910a384d8d8653468df4305937c30","original_commit_id":"98c90eee742910a384d8d8653468df4305937c30","user":{"login":"adorechic","id":1140583,"avatar_url":"https://avatars.githubusercontent.com/u/1140583?v=2","gravatar_id":"","url":"https://api.github.com/users/adorechic","html_url":"https://github.com/adorechic","followers_url":"https://api.github.com/users/adorechic/followers","following_url":"https://api.github.com/users/adorechic/following{/other_user}","gists_url":"https://api.github.com/users/adorechic/gists{/gist_id}","starred_url":"https://api.github.com/users/adorechic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adorechic/subscriptions","organizations_url":"https://api.github.com/users/adorechic/orgs","repos_url":"https://api.github.com/users/adorechic/repos","events_url":"https://api.github.com/users/adorechic/events{/privacy}","received_events_url":"https://api.github.com/users/adorechic/received_events","type":"User","site_admin":false},"body":"インスタンス変数なのでオブジェクト（ここではコントローラーのインスタンス）が生きてる間はアクセスできる感じですね。ってそういう話ですか？","created_at":"2014-10-02T22:56:56Z","updated_at":"2014-10-02T22:56:56Z","html_url":"https://github.com/root04/designax/pull/51#discussion_r18373255","pull_request_url":"https://api.github.com/repos/root04/designax/pulls/51","_links":{"self":{"href":"https://api.github.com/repos/root04/designax/pulls/comments/18373255"},"html":{"href":"https://github.com/root04/designax/pull/51#discussion_r18373255"},"pull_request":{"href":"https://api.github.com/repos/root04/designax/pulls/51"}}},"pull_request":{"url":"https://api.github.com/repos/root04/designax/pulls/51","id":22006569,"html_url":"https://github.com/root04/designax/pull/51","diff_url":"https://github.com/root04/designax/pull/51.diff","patch_url":"https://github.com/root04/designax/pull/51.patch","issue_url":"https://api.github.com/repos/root04/designax/issues/51","number":51,"state":"open","locked":false,"title":"Project membership","user":{"login":"adorechic","id":1140583,"avatar_url":"https://avatars.githubusercontent.com/u/1140583?v=2","gravatar_id":"","url":"https://api.github.com/users/adorechic","html_url":"https://github.com/adorechic","followers_url":"https://api.github.com/users/adorechic/followers","following_url":"https://api.github.com/users/adorechic/following{/other_user}","gists_url":"https://api.github.com/users/adorechic/gists{/gist_id}","starred_url":"https://api.github.com/users/adorechic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adorechic/subscriptions","organizations_url":"https://api.github.com/users/adorechic/orgs","repos_url":"https://api.github.com/users/adorechic/repos","events_url":"https://api.github.com/users/adorechic/events{/privacy}","received_events_url":"https://api.github.com/users/adorechic/received_events","type":"User","site_admin":false},"body":"組織メンバー管理と同様に、user - projects間のrelationを作成しプロジェクトのメンバー管理ができるようにします。\r\nImplemented https://github.com/root04/designax/issues/45\r\n\r\nproject作成したユーザーはデフォルトでadmin権限でメンバーに入ります。\r\n\r\nあわせてprojectの表示、およびorder_setの作成・表示もproject メンバーに限定しました。\r\n","created_at":"2014-09-30T14:12:40Z","updated_at":"2014-10-02T22:56:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b76392ab777cc6ca5c8e93e10d441c25d29eea7b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/root04/designax/pulls/51/commits","review_comments_url":"https://api.github.com/repos/root04/designax/pulls/51/comments","review_comment_url":"https://api.github.com/repos/root04/designax/pulls/comments/{number}","comments_url":"https://api.github.com/repos/root04/designax/issues/51/comments","statuses_url":"https://api.github.com/repos/root04/designax/statuses/98c90eee742910a384d8d8653468df4305937c30","head":{"label":"root04:adorechic/project_member","ref":"adorechic/project_member","sha":"98c90eee742910a384d8d8653468df4305937c30","user":{"login":"root04","id":7391114,"avatar_url":"https://avatars.githubusercontent.com/u/7391114?v=2","gravatar_id":"","url":"https://api.github.com/users/root04","html_url":"https://github.com/root04","followers_url":"https://api.github.com/users/root04/followers","following_url":"https://api.github.com/users/root04/following{/other_user}","gists_url":"https://api.github.com/users/root04/gists{/gist_id}","starred_url":"https://api.github.com/users/root04/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/root04/subscriptions","organizations_url":"https://api.github.com/users/root04/orgs","repos_url":"https://api.github.com/users/root04/repos","events_url":"https://api.github.com/users/root04/events{/privacy}","received_events_url":"https://api.github.com/users/root04/received_events","type":"Organization","site_admin":false},"repo":{"id":20357623,"name":"designax","full_name":"root04/designax","owner":{"login":"root04","id":7391114,"avatar_url":"https://avatars.githubusercontent.com/u/7391114?v=2","gravatar_id":"","url":"https://api.github.com/users/root04","html_url":"https://github.com/root04","followers_url":"https://api.github.com/users/root04/followers","following_url":"https://api.github.com/users/root04/following{/other_user}","gists_url":"https://api.github.com/users/root04/gists{/gist_id}","starred_url":"https://api.github.com/users/root04/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/root04/subscriptions","organizations_url":"https://api.github.com/users/root04/orgs","repos_url":"https://api.github.com/users/root04/repos","events_url":"https://api.github.com/users/root04/events{/privacy}","received_events_url":"https://api.github.com/users/root04/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/root04/designax","description":"","fork":false,"url":"https://api.github.com/repos/root04/designax","forks_url":"https://api.github.com/repos/root04/designax/forks","keys_url":"https://api.github.com/repos/root04/designax/keys{/key_id}","collaborators_url":"https://api.github.com/repos/root04/designax/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/root04/designax/teams","hooks_url":"https://api.github.com/repos/root04/designax/hooks","issue_events_url":"https://api.github.com/repos/root04/designax/issues/events{/number}","events_url":"https://api.github.com/repos/root04/designax/events","assignees_url":"https://api.github.com/repos/root04/designax/assignees{/user}","branches_url":"https://api.github.com/repos/root04/designax/branches{/branch}","tags_url":"https://api.github.com/repos/root04/designax/tags","blobs_url":"https://api.github.com/repos/root04/designax/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/root04/designax/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/root04/designax/git/refs{/sha}","trees_url":"https://api.github.com/repos/root04/designax/git/trees{/sha}","statuses_url":"https://api.github.com/repos/root04/designax/statuses/{sha}","languages_url":"https://api.github.com/repos/root04/designax/languages","stargazers_url":"https://api.github.com/repos/root04/designax/stargazers","contributors_url":"https://api.github.com/repos/root04/designax/contributors","subscribers_url":"https://api.github.com/repos/root04/designax/subscribers","subscription_url":"https://api.github.com/repos/root04/designax/subscription","commits_url":"https://api.github.com/repos/root04/designax/commits{/sha}","git_commits_url":"https://api.github.com/repos/root04/designax/git/commits{/sha}","comments_url":"https://api.github.com/repos/root04/designax/comments{/number}","issue_comment_url":"https://api.github.com/repos/root04/designax/issues/comments/{number}","contents_url":"https://api.github.com/repos/root04/designax/contents/{+path}","compare_url":"https://api.github.com/repos/root04/designax/compare/{base}...{head}","merges_url":"https://api.github.com/repos/root04/designax/merges","archive_url":"https://api.github.com/repos/root04/designax/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/root04/designax/downloads","issues_url":"https://api.github.com/repos/root04/designax/issues{/number}","pulls_url":"https://api.github.com/repos/root04/designax/pulls{/number}","milestones_url":"https://api.github.com/repos/root04/designax/milestones{/number}","notifications_url":"https://api.github.com/repos/root04/designax/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/root04/designax/labels{/name}","releases_url":"https://api.github.com/repos/root04/designax/releases{/id}","created_at":"2014-05-31T14:42:49Z","updated_at":"2014-09-17T06:57:45Z","pushed_at":"2014-10-02T17:26:31Z","git_url":"git://github.com/root04/designax.git","ssh_url":"git@github.com:root04/designax.git","clone_url":"https://github.com/root04/designax.git","svn_url":"https://github.com/root04/designax","homepage":null,"size":1720,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":21,"forks":0,"open_issues":21,"watchers":3,"default_branch":"master"}},"base":{"label":"root04:master","ref":"master","sha":"43e5342b8e988de3807cb5dae93f2c0cd50ba34b","user":{"login":"root04","id":7391114,"avatar_url":"https://avatars.githubusercontent.com/u/7391114?v=2","gravatar_id":"","url":"https://api.github.com/users/root04","html_url":"https://github.com/root04","followers_url":"https://api.github.com/users/root04/followers","following_url":"https://api.github.com/users/root04/following{/other_user}","gists_url":"https://api.github.com/users/root04/gists{/gist_id}","starred_url":"https://api.github.com/users/root04/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/root04/subscriptions","organizations_url":"https://api.github.com/users/root04/orgs","repos_url":"https://api.github.com/users/root04/repos","events_url":"https://api.github.com/users/root04/events{/privacy}","received_events_url":"https://api.github.com/users/root04/received_events","type":"Organization","site_admin":false},"repo":{"id":20357623,"name":"designax","full_name":"root04/designax","owner":{"login":"root04","id":7391114,"avatar_url":"https://avatars.githubusercontent.com/u/7391114?v=2","gravatar_id":"","url":"https://api.github.com/users/root04","html_url":"https://github.com/root04","followers_url":"https://api.github.com/users/root04/followers","following_url":"https://api.github.com/users/root04/following{/other_user}","gists_url":"https://api.github.com/users/root04/gists{/gist_id}","starred_url":"https://api.github.com/users/root04/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/root04/subscriptions","organizations_url":"https://api.github.com/users/root04/orgs","repos_url":"https://api.github.com/users/root04/repos","events_url":"https://api.github.com/users/root04/events{/privacy}","received_events_url":"https://api.github.com/users/root04/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/root04/designax","description":"","fork":false,"url":"https://api.github.com/repos/root04/designax","forks_url":"https://api.github.com/repos/root04/designax/forks","keys_url":"https://api.github.com/repos/root04/designax/keys{/key_id}","collaborators_url":"https://api.github.com/repos/root04/designax/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/root04/designax/teams","hooks_url":"https://api.github.com/repos/root04/designax/hooks","issue_events_url":"https://api.github.com/repos/root04/designax/issues/events{/number}","events_url":"https://api.github.com/repos/root04/designax/events","assignees_url":"https://api.github.com/repos/root04/designax/assignees{/user}","branches_url":"https://api.github.com/repos/root04/designax/branches{/branch}","tags_url":"https://api.github.com/repos/root04/designax/tags","blobs_url":"https://api.github.com/repos/root04/designax/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/root04/designax/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/root04/designax/git/refs{/sha}","trees_url":"https://api.github.com/repos/root04/designax/git/trees{/sha}","statuses_url":"https://api.github.com/repos/root04/designax/statuses/{sha}","languages_url":"https://api.github.com/repos/root04/designax/languages","stargazers_url":"https://api.github.com/repos/root04/designax/stargazers","contributors_url":"https://api.github.com/repos/root04/designax/contributors","subscribers_url":"https://api.github.com/repos/root04/designax/subscribers","subscription_url":"https://api.github.com/repos/root04/designax/subscription","commits_url":"https://api.github.com/repos/root04/designax/commits{/sha}","git_commits_url":"https://api.github.com/repos/root04/designax/git/commits{/sha}","comments_url":"https://api.github.com/repos/root04/designax/comments{/number}","issue_comment_url":"https://api.github.com/repos/root04/designax/issues/comments/{number}","contents_url":"https://api.github.com/repos/root04/designax/contents/{+path}","compare_url":"https://api.github.com/repos/root04/designax/compare/{base}...{head}","merges_url":"https://api.github.com/repos/root04/designax/merges","archive_url":"https://api.github.com/repos/root04/designax/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/root04/designax/downloads","issues_url":"https://api.github.com/repos/root04/designax/issues{/number}","pulls_url":"https://api.github.com/repos/root04/designax/pulls{/number}","milestones_url":"https://api.github.com/repos/root04/designax/milestones{/number}","notifications_url":"https://api.github.com/repos/root04/designax/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/root04/designax/labels{/name}","releases_url":"https://api.github.com/repos/root04/designax/releases{/id}","created_at":"2014-05-31T14:42:49Z","updated_at":"2014-09-17T06:57:45Z","pushed_at":"2014-10-02T17:26:31Z","git_url":"git://github.com/root04/designax.git","ssh_url":"git@github.com:root04/designax.git","clone_url":"https://github.com/root04/designax.git","svn_url":"https://github.com/root04/designax","homepage":null,"size":1720,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":21,"forks":0,"open_issues":21,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/root04/designax/pulls/51"},"html":{"href":"https://github.com/root04/designax/pull/51"},"issue":{"href":"https://api.github.com/repos/root04/designax/issues/51"},"comments":{"href":"https://api.github.com/repos/root04/designax/issues/51/comments"},"review_comments":{"href":"https://api.github.com/repos/root04/designax/pulls/51/comments"},"review_comment":{"href":"https://api.github.com/repos/root04/designax/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/root04/designax/pulls/51/commits"},"statuses":{"href":"https://api.github.com/repos/root04/designax/statuses/98c90eee742910a384d8d8653468df4305937c30"}}}}