GitHub PullRequestReviewCommentEvent at 2014-12-23 07:50:43
Repository: ooyala-spark
Actor: theel
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/ooyala/ooyala-spark/pulls/comments/22206075","id":22206075,"diff_hunk":"@@ -200,7 +200,7 @@ class DAGScheduler(\n     listenerBus.addListener(listener)\n   }\n \n-  private def getCacheLocs(rdd: RDD[_]): Array[Seq[TaskLocation]] = {\n+  private def getCacheLocs(rdd: RDD[_]): Array[Seq[TaskLocation]] = synchronized {","path":"core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala","position":5,"original_position":5,"commit_id":"93cb7abc8e7f7f038c206bdfff2e22e88775a48e","original_commit_id":"93cb7abc8e7f7f038c206bdfff2e22e88775a48e","user":{"login":"theel","id":3960639,"avatar_url":"https://avatars.githubusercontent.com/u/3960639?v=3","gravatar_id":"","url":"https://api.github.com/users/theel","html_url":"https://github.com/theel","followers_url":"https://api.github.com/users/theel/followers","following_url":"https://api.github.com/users/theel/following{/other_user}","gists_url":"https://api.github.com/users/theel/gists{/gist_id}","starred_url":"https://api.github.com/users/theel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theel/subscriptions","organizations_url":"https://api.github.com/users/theel/orgs","repos_url":"https://api.github.com/users/theel/repos","events_url":"https://api.github.com/users/theel/events{/privacy}","received_events_url":"https://api.github.com/users/theel/received_events","type":"User","site_admin":false},"body":"probably use cacheLocs.synchronized, which is strictly better for performance. same as the line below.","created_at":"2014-12-23T07:50:43Z","updated_at":"2014-12-23T07:50:43Z","html_url":"https://github.com/ooyala/ooyala-spark/pull/1#discussion_r22206075","pull_request_url":"https://api.github.com/repos/ooyala/ooyala-spark/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/ooyala/ooyala-spark/pulls/comments/22206075"},"html":{"href":"https://github.com/ooyala/ooyala-spark/pull/1#discussion_r22206075"},"pull_request":{"href":"https://api.github.com/repos/ooyala/ooyala-spark/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/ooyala/ooyala-spark/pulls/1","id":26498728,"html_url":"https://github.com/ooyala/ooyala-spark/pull/1","diff_url":"https://github.com/ooyala/ooyala-spark/pull/1.diff","patch_url":"https://github.com/ooyala/ooyala-spark/pull/1.patch","issue_url":"https://api.github.com/repos/ooyala/ooyala-spark/issues/1","number":1,"state":"open","locked":false,"title":"fixed race condition issue on cacheLocs","user":{"login":"theel","id":3960639,"avatar_url":"https://avatars.githubusercontent.com/u/3960639?v=3","gravatar_id":"","url":"https://api.github.com/users/theel","html_url":"https://github.com/theel","followers_url":"https://api.github.com/users/theel/followers","following_url":"https://api.github.com/users/theel/following{/other_user}","gists_url":"https://api.github.com/users/theel/gists{/gist_id}","starred_url":"https://api.github.com/users/theel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theel/subscriptions","organizations_url":"https://api.github.com/users/theel/orgs","repos_url":"https://api.github.com/users/theel/repos","events_url":"https://api.github.com/users/theel/events{/privacy}","received_events_url":"https://api.github.com/users/theel/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-12-23T07:47:59Z","updated_at":"2014-12-23T07:50:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ooyala/ooyala-spark/pulls/1/commits","review_comments_url":"https://api.github.com/repos/ooyala/ooyala-spark/pulls/1/comments","review_comment_url":"https://api.github.com/repos/ooyala/ooyala-spark/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ooyala/ooyala-spark/issues/1/comments","statuses_url":"https://api.github.com/repos/ooyala/ooyala-spark/statuses/93cb7abc8e7f7f038c206bdfff2e22e88775a48e","head":{"label":"ooyala:v0.9.1-ooyala","ref":"v0.9.1-ooyala","sha":"93cb7abc8e7f7f038c206bdfff2e22e88775a48e","user":{"login":"ooyala","id":365274,"avatar_url":"https://avatars.githubusercontent.com/u/365274?v=3","gravatar_id":"","url":"https://api.github.com/users/ooyala","html_url":"https://github.com/ooyala","followers_url":"https://api.github.com/users/ooyala/followers","following_url":"https://api.github.com/users/ooyala/following{/other_user}","gists_url":"https://api.github.com/users/ooyala/gists{/gist_id}","starred_url":"https://api.github.com/users/ooyala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ooyala/subscriptions","organizations_url":"https://api.github.com/users/ooyala/orgs","repos_url":"https://api.github.com/users/ooyala/repos","events_url":"https://api.github.com/users/ooyala/events{/privacy}","received_events_url":"https://api.github.com/users/ooyala/received_events","type":"Organization","site_admin":false},"repo":{"id":28102497,"name":"ooyala-spark","full_name":"ooyala/ooyala-spark","owner":{"login":"ooyala","id":365274,"avatar_url":"https://avatars.githubusercontent.com/u/365274?v=3","gravatar_id":"","url":"https://api.github.com/users/ooyala","html_url":"https://github.com/ooyala","followers_url":"https://api.github.com/users/ooyala/followers","following_url":"https://api.github.com/users/ooyala/following{/other_user}","gists_url":"https://api.github.com/users/ooyala/gists{/gist_id}","starred_url":"https://api.github.com/users/ooyala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ooyala/subscriptions","organizations_url":"https://api.github.com/users/ooyala/orgs","repos_url":"https://api.github.com/users/ooyala/repos","events_url":"https://api.github.com/users/ooyala/events{/privacy}","received_events_url":"https://api.github.com/users/ooyala/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ooyala/ooyala-spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/ooyala/ooyala-spark","forks_url":"https://api.github.com/repos/ooyala/ooyala-spark/forks","keys_url":"https://api.github.com/repos/ooyala/ooyala-spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ooyala/ooyala-spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ooyala/ooyala-spark/teams","hooks_url":"https://api.github.com/repos/ooyala/ooyala-spark/hooks","issue_events_url":"https://api.github.com/repos/ooyala/ooyala-spark/issues/events{/number}","events_url":"https://api.github.com/repos/ooyala/ooyala-spark/events","assignees_url":"https://api.github.com/repos/ooyala/ooyala-spark/assignees{/user}","branches_url":"https://api.github.com/repos/ooyala/ooyala-spark/branches{/branch}","tags_url":"https://api.github.com/repos/ooyala/ooyala-spark/tags","blobs_url":"https://api.github.com/repos/ooyala/ooyala-spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ooyala/ooyala-spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ooyala/ooyala-spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/ooyala/ooyala-spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ooyala/ooyala-spark/statuses/{sha}","languages_url":"https://api.github.com/repos/ooyala/ooyala-spark/languages","stargazers_url":"https://api.github.com/repos/ooyala/ooyala-spark/stargazers","contributors_url":"https://api.github.com/repos/ooyala/ooyala-spark/contributors","subscribers_url":"https://api.github.com/repos/ooyala/ooyala-spark/subscribers","subscription_url":"https://api.github.com/repos/ooyala/ooyala-spark/subscription","commits_url":"https://api.github.com/repos/ooyala/ooyala-spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/ooyala/ooyala-spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/ooyala/ooyala-spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/ooyala/ooyala-spark/issues/comments/{number}","contents_url":"https://api.github.com/repos/ooyala/ooyala-spark/contents/{+path}","compare_url":"https://api.github.com/repos/ooyala/ooyala-spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ooyala/ooyala-spark/merges","archive_url":"https://api.github.com/repos/ooyala/ooyala-spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ooyala/ooyala-spark/downloads","issues_url":"https://api.github.com/repos/ooyala/ooyala-spark/issues{/number}","pulls_url":"https://api.github.com/repos/ooyala/ooyala-spark/pulls{/number}","milestones_url":"https://api.github.com/repos/ooyala/ooyala-spark/milestones{/number}","notifications_url":"https://api.github.com/repos/ooyala/ooyala-spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ooyala/ooyala-spark/labels{/name}","releases_url":"https://api.github.com/repos/ooyala/ooyala-spark/releases{/id}","created_at":"2014-12-16T19:24:02Z","updated_at":"2014-12-16T19:47:12Z","pushed_at":"2014-12-23T00:38:14Z","git_url":"git://github.com/ooyala/ooyala-spark.git","ssh_url":"git@github.com:ooyala/ooyala-spark.git","clone_url":"https://github.com/ooyala/ooyala-spark.git","svn_url":"https://github.com/ooyala/ooyala-spark","homepage":null,"size":86660,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"ooyala:branch-0.9","ref":"branch-0.9","sha":"63c0ff9923e2e7dccee320c1d907fb323a84cf73","user":{"login":"ooyala","id":365274,"avatar_url":"https://avatars.githubusercontent.com/u/365274?v=3","gravatar_id":"","url":"https://api.github.com/users/ooyala","html_url":"https://github.com/ooyala","followers_url":"https://api.github.com/users/ooyala/followers","following_url":"https://api.github.com/users/ooyala/following{/other_user}","gists_url":"https://api.github.com/users/ooyala/gists{/gist_id}","starred_url":"https://api.github.com/users/ooyala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ooyala/subscriptions","organizations_url":"https://api.github.com/users/ooyala/orgs","repos_url":"https://api.github.com/users/ooyala/repos","events_url":"https://api.github.com/users/ooyala/events{/privacy}","received_events_url":"https://api.github.com/users/ooyala/received_events","type":"Organization","site_admin":false},"repo":{"id":28102497,"name":"ooyala-spark","full_name":"ooyala/ooyala-spark","owner":{"login":"ooyala","id":365274,"avatar_url":"https://avatars.githubusercontent.com/u/365274?v=3","gravatar_id":"","url":"https://api.github.com/users/ooyala","html_url":"https://github.com/ooyala","followers_url":"https://api.github.com/users/ooyala/followers","following_url":"https://api.github.com/users/ooyala/following{/other_user}","gists_url":"https://api.github.com/users/ooyala/gists{/gist_id}","starred_url":"https://api.github.com/users/ooyala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ooyala/subscriptions","organizations_url":"https://api.github.com/users/ooyala/orgs","repos_url":"https://api.github.com/users/ooyala/repos","events_url":"https://api.github.com/users/ooyala/events{/privacy}","received_events_url":"https://api.github.com/users/ooyala/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ooyala/ooyala-spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/ooyala/ooyala-spark","forks_url":"https://api.github.com/repos/ooyala/ooyala-spark/forks","keys_url":"https://api.github.com/repos/ooyala/ooyala-spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ooyala/ooyala-spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ooyala/ooyala-spark/teams","hooks_url":"https://api.github.com/repos/ooyala/ooyala-spark/hooks","issue_events_url":"https://api.github.com/repos/ooyala/ooyala-spark/issues/events{/number}","events_url":"https://api.github.com/repos/ooyala/ooyala-spark/events","assignees_url":"https://api.github.com/repos/ooyala/ooyala-spark/assignees{/user}","branches_url":"https://api.github.com/repos/ooyala/ooyala-spark/branches{/branch}","tags_url":"https://api.github.com/repos/ooyala/ooyala-spark/tags","blobs_url":"https://api.github.com/repos/ooyala/ooyala-spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ooyala/ooyala-spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ooyala/ooyala-spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/ooyala/ooyala-spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ooyala/ooyala-spark/statuses/{sha}","languages_url":"https://api.github.com/repos/ooyala/ooyala-spark/languages","stargazers_url":"https://api.github.com/repos/ooyala/ooyala-spark/stargazers","contributors_url":"https://api.github.com/repos/ooyala/ooyala-spark/contributors","subscribers_url":"https://api.github.com/repos/ooyala/ooyala-spark/subscribers","subscription_url":"https://api.github.com/repos/ooyala/ooyala-spark/subscription","commits_url":"https://api.github.com/repos/ooyala/ooyala-spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/ooyala/ooyala-spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/ooyala/ooyala-spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/ooyala/ooyala-spark/issues/comments/{number}","contents_url":"https://api.github.com/repos/ooyala/ooyala-spark/contents/{+path}","compare_url":"https://api.github.com/repos/ooyala/ooyala-spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ooyala/ooyala-spark/merges","archive_url":"https://api.github.com/repos/ooyala/ooyala-spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ooyala/ooyala-spark/downloads","issues_url":"https://api.github.com/repos/ooyala/ooyala-spark/issues{/number}","pulls_url":"https://api.github.com/repos/ooyala/ooyala-spark/pulls{/number}","milestones_url":"https://api.github.com/repos/ooyala/ooyala-spark/milestones{/number}","notifications_url":"https://api.github.com/repos/ooyala/ooyala-spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ooyala/ooyala-spark/labels{/name}","releases_url":"https://api.github.com/repos/ooyala/ooyala-spark/releases{/id}","created_at":"2014-12-16T19:24:02Z","updated_at":"2014-12-16T19:47:12Z","pushed_at":"2014-12-23T00:38:14Z","git_url":"git://github.com/ooyala/ooyala-spark.git","ssh_url":"git@github.com:ooyala/ooyala-spark.git","clone_url":"https://github.com/ooyala/ooyala-spark.git","svn_url":"https://github.com/ooyala/ooyala-spark","homepage":null,"size":86660,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ooyala/ooyala-spark/pulls/1"},"html":{"href":"https://github.com/ooyala/ooyala-spark/pull/1"},"issue":{"href":"https://api.github.com/repos/ooyala/ooyala-spark/issues/1"},"comments":{"href":"https://api.github.com/repos/ooyala/ooyala-spark/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/ooyala/ooyala-spark/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/ooyala/ooyala-spark/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ooyala/ooyala-spark/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/ooyala/ooyala-spark/statuses/93cb7abc8e7f7f038c206bdfff2e22e88775a48e"}}}}