GitHub PullRequestReviewCommentEvent at 2014-06-21 10:25:06
Repository: Smoothieware
Actor: wolfmanjm
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/Smoothieware/Smoothieware/pulls/comments/14049178","id":14049178,"diff_hunk":"@@ -107,75 +91,105 @@ void init() {\n     // Create and add main modules\n     kernel->add_module( new SimpleShell() );\n     kernel->add_module( new Configurator() );\n+\n+\n+    // initialize usb/dfu/etc. first to allow flashing when a module loops endless","path":"src/main.cpp","position":58,"original_position":58,"commit_id":"0f0bdfe1a267cdbe937879c477d3f029ab6be44f","original_commit_id":"0f0bdfe1a267cdbe937879c477d3f029ab6be44f","user":{"login":"wolfmanjm","id":22263,"avatar_url":"https://avatars.githubusercontent.com/u/22263?","gravatar_id":"c31c7255fa4488dfc5d766403b497a36","url":"https://api.github.com/users/wolfmanjm","html_url":"https://github.com/wolfmanjm","followers_url":"https://api.github.com/users/wolfmanjm/followers","following_url":"https://api.github.com/users/wolfmanjm/following{/other_user}","gists_url":"https://api.github.com/users/wolfmanjm/gists{/gist_id}","starred_url":"https://api.github.com/users/wolfmanjm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wolfmanjm/subscriptions","organizations_url":"https://api.github.com/users/wolfmanjm/orgs","repos_url":"https://api.github.com/users/wolfmanjm/repos","events_url":"https://api.github.com/users/wolfmanjm/events{/privacy}","received_events_url":"https://api.github.com/users/wolfmanjm/received_events","type":"User","site_admin":false},"body":"You cannot change the order in which this happens, so this will not be excepted. There is a critical timing issue which will cause MSD to hang if you change the order in any way.","created_at":"2014-06-21T10:25:06Z","updated_at":"2014-06-21T10:25:06Z","html_url":"https://github.com/Smoothieware/Smoothieware/pull/436#discussion_r14049178","pull_request_url":"https://api.github.com/repos/Smoothieware/Smoothieware/pulls/436","_links":{"self":{"href":"https://api.github.com/repos/Smoothieware/Smoothieware/pulls/comments/14049178"},"html":{"href":"https://github.com/Smoothieware/Smoothieware/pull/436#discussion_r14049178"},"pull_request":{"href":"https://api.github.com/repos/Smoothieware/Smoothieware/pulls/436"}}},"pull_request":{"url":"https://api.github.com/repos/Smoothieware/Smoothieware/pulls/436","id":17389384,"html_url":"https://github.com/Smoothieware/Smoothieware/pull/436","diff_url":"https://github.com/Smoothieware/Smoothieware/pull/436.diff","patch_url":"https://github.com/Smoothieware/Smoothieware/pull/436.patch","issue_url":"https://api.github.com/repos/Smoothieware/Smoothieware/issues/436","number":436,"state":"open","title":"add Leds module for central management of leds, add post codes to main","user":{"login":"hg42","id":4707597,"avatar_url":"https://avatars.githubusercontent.com/u/4707597?","gravatar_id":"aaaef47b7731549589813ab61a2a04d4","url":"https://api.github.com/users/hg42","html_url":"https://github.com/hg42","followers_url":"https://api.github.com/users/hg42/followers","following_url":"https://api.github.com/users/hg42/following{/other_user}","gists_url":"https://api.github.com/users/hg42/gists{/gist_id}","starred_url":"https://api.github.com/users/hg42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hg42/subscriptions","organizations_url":"https://api.github.com/users/hg42/orgs","repos_url":"https://api.github.com/users/hg42/repos","events_url":"https://api.github.com/users/hg42/events{/privacy}","received_events_url":"https://api.github.com/users/hg42/received_events","type":"User","site_admin":false},"body":"completely redesigned leds module as discussed in #424\r\n- replaces led code (and gpio) in main.cpp and SlowTicker.cpp\r\n- adds POST codes to main.cpp\r\n- POST leds can be configured separately\r\n  via space separated pin descriptions\r\n- uses Pin to have maximum flexibility\r\n- manages the four standard leds and play led\r\n- dimmed mode shows that events are running without distraction\r\n  (otherwise led is bright or off, kind of blinks while activities)\r\n- also respects leds_disable setting\r\n- free form pin configuration\r\n    e.g. leds.pin_idle  4.28! blink\r\n    or   leds.pin_idle  blink 4.28!\r\n\r\nconfig like current led behaviour:\r\n\r\n    leds.enable        true                       # can be omitted\r\n    leds.pin_main      blink                      # main loop\r\n    leds.pin_idle      blink                      # idle event\r\n    leds.pin_gcode     off                        # no gcode led\r\n    leds.pin_play      off                        # no play led\r\n\r\nexample config:\r\n\r\n    leds.enable        true                       #\r\n    leds.pin_main      dimmed                     #\r\n    leds.pin_idle      blink                      #\r\n    leds.pin_gcode     4.28!                      # use play led for gcodes\r\n    leds.pin_play      off                        #\r\n    leds.pin_sdok                                 # default\r\n    leds.pins_post     1.21 1.20 1.19 1.18 4.28!  # POST leds reversed + play led for highest bit\r\n    play_led_disable   true                       # PlayLed is replaced by Leds\r\n\r\n","created_at":"2014-06-20T04:58:18Z","updated_at":"2014-06-21T10:25:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7b2beaf64e8dab648aaa780e38f6a84e890ca4dd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Smoothieware/Smoothieware/pulls/436/commits","review_comments_url":"https://api.github.com/repos/Smoothieware/Smoothieware/pulls/436/comments","review_comment_url":"https://api.github.com/repos/Smoothieware/Smoothieware/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Smoothieware/Smoothieware/issues/436/comments","statuses_url":"https://api.github.com/repos/Smoothieware/Smoothieware/statuses/0f0bdfe1a267cdbe937879c477d3f029ab6be44f","head":{"label":"hg42:leds-module","ref":"leds-module","sha":"0f0bdfe1a267cdbe937879c477d3f029ab6be44f","user":{"login":"hg42","id":4707597,"avatar_url":"https://avatars.githubusercontent.com/u/4707597?","gravatar_id":"aaaef47b7731549589813ab61a2a04d4","url":"https://api.github.com/users/hg42","html_url":"https://github.com/hg42","followers_url":"https://api.github.com/users/hg42/followers","following_url":"https://api.github.com/users/hg42/following{/other_user}","gists_url":"https://api.github.com/users/hg42/gists{/gist_id}","starred_url":"https://api.github.com/users/hg42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hg42/subscriptions","organizations_url":"https://api.github.com/users/hg42/orgs","repos_url":"https://api.github.com/users/hg42/repos","events_url":"https://api.github.com/users/hg42/events{/privacy}","received_events_url":"https://api.github.com/users/hg42/received_events","type":"User","site_admin":false},"repo":{"id":19849236,"name":"Smoothieware","full_name":"hg42/Smoothieware","owner":{"login":"hg42","id":4707597,"avatar_url":"https://avatars.githubusercontent.com/u/4707597?","gravatar_id":"aaaef47b7731549589813ab61a2a04d4","url":"https://api.github.com/users/hg42","html_url":"https://github.com/hg42","followers_url":"https://api.github.com/users/hg42/followers","following_url":"https://api.github.com/users/hg42/following{/other_user}","gists_url":"https://api.github.com/users/hg42/gists{/gist_id}","starred_url":"https://api.github.com/users/hg42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hg42/subscriptions","organizations_url":"https://api.github.com/users/hg42/orgs","repos_url":"https://api.github.com/users/hg42/repos","events_url":"https://api.github.com/users/hg42/events{/privacy}","received_events_url":"https://api.github.com/users/hg42/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hg42/Smoothieware","description":"Modular, opensource, high performance G-code interpreter and CNC controller written in Object-Oriented C++","fork":true,"url":"https://api.github.com/repos/hg42/Smoothieware","forks_url":"https://api.github.com/repos/hg42/Smoothieware/forks","keys_url":"https://api.github.com/repos/hg42/Smoothieware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hg42/Smoothieware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hg42/Smoothieware/teams","hooks_url":"https://api.github.com/repos/hg42/Smoothieware/hooks","issue_events_url":"https://api.github.com/repos/hg42/Smoothieware/issues/events{/number}","events_url":"https://api.github.com/repos/hg42/Smoothieware/events","assignees_url":"https://api.github.com/repos/hg42/Smoothieware/assignees{/user}","branches_url":"https://api.github.com/repos/hg42/Smoothieware/branches{/branch}","tags_url":"https://api.github.com/repos/hg42/Smoothieware/tags","blobs_url":"https://api.github.com/repos/hg42/Smoothieware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hg42/Smoothieware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hg42/Smoothieware/git/refs{/sha}","trees_url":"https://api.github.com/repos/hg42/Smoothieware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hg42/Smoothieware/statuses/{sha}","languages_url":"https://api.github.com/repos/hg42/Smoothieware/languages","stargazers_url":"https://api.github.com/repos/hg42/Smoothieware/stargazers","contributors_url":"https://api.github.com/repos/hg42/Smoothieware/contributors","subscribers_url":"https://api.github.com/repos/hg42/Smoothieware/subscribers","subscription_url":"https://api.github.com/repos/hg42/Smoothieware/subscription","commits_url":"https://api.github.com/repos/hg42/Smoothieware/commits{/sha}","git_commits_url":"https://api.github.com/repos/hg42/Smoothieware/git/commits{/sha}","comments_url":"https://api.github.com/repos/hg42/Smoothieware/comments{/number}","issue_comment_url":"https://api.github.com/repos/hg42/Smoothieware/issues/comments/{number}","contents_url":"https://api.github.com/repos/hg42/Smoothieware/contents/{+path}","compare_url":"https://api.github.com/repos/hg42/Smoothieware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hg42/Smoothieware/merges","archive_url":"https://api.github.com/repos/hg42/Smoothieware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hg42/Smoothieware/downloads","issues_url":"https://api.github.com/repos/hg42/Smoothieware/issues{/number}","pulls_url":"https://api.github.com/repos/hg42/Smoothieware/pulls{/number}","milestones_url":"https://api.github.com/repos/hg42/Smoothieware/milestones{/number}","notifications_url":"https://api.github.com/repos/hg42/Smoothieware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hg42/Smoothieware/labels{/name}","releases_url":"https://api.github.com/repos/hg42/Smoothieware/releases{/id}","created_at":"2014-05-16T08:11:51Z","updated_at":"2014-06-21T10:09:41Z","pushed_at":"2014-06-20T12:56:22Z","git_url":"git://github.com/hg42/Smoothieware.git","ssh_url":"git@github.com:hg42/Smoothieware.git","clone_url":"https://github.com/hg42/Smoothieware.git","svn_url":"https://github.com/hg42/Smoothieware","homepage":"http://smoothieware.org/","size":23501,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"edge"}},"base":{"label":"Smoothieware:edge","ref":"edge","sha":"27b08186b3ff0a4953bb4d362c7dc36623f6dd93","user":{"login":"Smoothieware","id":4834224,"avatar_url":"https://avatars.githubusercontent.com/u/4834224?","gravatar_id":null,"url":"https://api.github.com/users/Smoothieware","html_url":"https://github.com/Smoothieware","followers_url":"https://api.github.com/users/Smoothieware/followers","following_url":"https://api.github.com/users/Smoothieware/following{/other_user}","gists_url":"https://api.github.com/users/Smoothieware/gists{/gist_id}","starred_url":"https://api.github.com/users/Smoothieware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Smoothieware/subscriptions","organizations_url":"https://api.github.com/users/Smoothieware/orgs","repos_url":"https://api.github.com/users/Smoothieware/repos","events_url":"https://api.github.com/users/Smoothieware/events{/privacy}","received_events_url":"https://api.github.com/users/Smoothieware/received_events","type":"Organization","site_admin":false},"repo":{"id":2418744,"name":"Smoothieware","full_name":"Smoothieware/Smoothieware","owner":{"login":"Smoothieware","id":4834224,"avatar_url":"https://avatars.githubusercontent.com/u/4834224?","gravatar_id":null,"url":"https://api.github.com/users/Smoothieware","html_url":"https://github.com/Smoothieware","followers_url":"https://api.github.com/users/Smoothieware/followers","following_url":"https://api.github.com/users/Smoothieware/following{/other_user}","gists_url":"https://api.github.com/users/Smoothieware/gists{/gist_id}","starred_url":"https://api.github.com/users/Smoothieware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Smoothieware/subscriptions","organizations_url":"https://api.github.com/users/Smoothieware/orgs","repos_url":"https://api.github.com/users/Smoothieware/repos","events_url":"https://api.github.com/users/Smoothieware/events{/privacy}","received_events_url":"https://api.github.com/users/Smoothieware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Smoothieware/Smoothieware","description":"Modular, opensource, high performance G-code interpreter and CNC controller written in Object-Oriented C++","fork":false,"url":"https://api.github.com/repos/Smoothieware/Smoothieware","forks_url":"https://api.github.com/repos/Smoothieware/Smoothieware/forks","keys_url":"https://api.github.com/repos/Smoothieware/Smoothieware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Smoothieware/Smoothieware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Smoothieware/Smoothieware/teams","hooks_url":"https://api.github.com/repos/Smoothieware/Smoothieware/hooks","issue_events_url":"https://api.github.com/repos/Smoothieware/Smoothieware/issues/events{/number}","events_url":"https://api.github.com/repos/Smoothieware/Smoothieware/events","assignees_url":"https://api.github.com/repos/Smoothieware/Smoothieware/assignees{/user}","branches_url":"https://api.github.com/repos/Smoothieware/Smoothieware/branches{/branch}","tags_url":"https://api.github.com/repos/Smoothieware/Smoothieware/tags","blobs_url":"https://api.github.com/repos/Smoothieware/Smoothieware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Smoothieware/Smoothieware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Smoothieware/Smoothieware/git/refs{/sha}","trees_url":"https://api.github.com/repos/Smoothieware/Smoothieware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Smoothieware/Smoothieware/statuses/{sha}","languages_url":"https://api.github.com/repos/Smoothieware/Smoothieware/languages","stargazers_url":"https://api.github.com/repos/Smoothieware/Smoothieware/stargazers","contributors_url":"https://api.github.com/repos/Smoothieware/Smoothieware/contributors","subscribers_url":"https://api.github.com/repos/Smoothieware/Smoothieware/subscribers","subscription_url":"https://api.github.com/repos/Smoothieware/Smoothieware/subscription","commits_url":"https://api.github.com/repos/Smoothieware/Smoothieware/commits{/sha}","git_commits_url":"https://api.github.com/repos/Smoothieware/Smoothieware/git/commits{/sha}","comments_url":"https://api.github.com/repos/Smoothieware/Smoothieware/comments{/number}","issue_comment_url":"https://api.github.com/repos/Smoothieware/Smoothieware/issues/comments/{number}","contents_url":"https://api.github.com/repos/Smoothieware/Smoothieware/contents/{+path}","compare_url":"https://api.github.com/repos/Smoothieware/Smoothieware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Smoothieware/Smoothieware/merges","archive_url":"https://api.github.com/repos/Smoothieware/Smoothieware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Smoothieware/Smoothieware/downloads","issues_url":"https://api.github.com/repos/Smoothieware/Smoothieware/issues{/number}","pulls_url":"https://api.github.com/repos/Smoothieware/Smoothieware/pulls{/number}","milestones_url":"https://api.github.com/repos/Smoothieware/Smoothieware/milestones{/number}","notifications_url":"https://api.github.com/repos/Smoothieware/Smoothieware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Smoothieware/Smoothieware/labels{/name}","releases_url":"https://api.github.com/repos/Smoothieware/Smoothieware/releases{/id}","created_at":"2011-09-19T22:21:05Z","updated_at":"2014-06-21T07:58:32Z","pushed_at":"2014-06-20T06:12:21Z","git_url":"git://github.com/Smoothieware/Smoothieware.git","ssh_url":"git@github.com:Smoothieware/Smoothieware.git","clone_url":"https://github.com/Smoothieware/Smoothieware.git","svn_url":"https://github.com/Smoothieware/Smoothieware","homepage":"http://smoothieware.org/","size":29804,"stargazers_count":136,"watchers_count":136,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":107,"mirror_url":null,"open_issues_count":36,"forks":107,"open_issues":36,"watchers":136,"default_branch":"edge"}},"_links":{"self":{"href":"https://api.github.com/repos/Smoothieware/Smoothieware/pulls/436"},"html":{"href":"https://github.com/Smoothieware/Smoothieware/pull/436"},"issue":{"href":"https://api.github.com/repos/Smoothieware/Smoothieware/issues/436"},"comments":{"href":"https://api.github.com/repos/Smoothieware/Smoothieware/issues/436/comments"},"review_comments":{"href":"https://api.github.com/repos/Smoothieware/Smoothieware/pulls/436/comments"},"review_comment":{"href":"https://api.github.com/repos/Smoothieware/Smoothieware/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Smoothieware/Smoothieware/pulls/436/commits"},"statuses":{"href":"https://api.github.com/repos/Smoothieware/Smoothieware/statuses/0f0bdfe1a267cdbe937879c477d3f029ab6be44f"}}}}