GitHub PullRequestEvent at 2014-12-26 04:47:11
Repository: Cataclysm-DDA
Actor: KA101
Payload: {"action":"closed","number":10601,"pull_request":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/10601","id":26487653,"html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/10601","diff_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/10601.diff","patch_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/10601.patch","issue_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/10601","number":10601,"state":"closed","locked":false,"title":"Automatic aim ai rework","user":{"login":"Coolthulhu","id":1878860,"avatar_url":"https://avatars.githubusercontent.com/u/1878860?v=3","gravatar_id":"","url":"https://api.github.com/users/Coolthulhu","html_url":"https://github.com/Coolthulhu","followers_url":"https://api.github.com/users/Coolthulhu/followers","following_url":"https://api.github.com/users/Coolthulhu/following{/other_user}","gists_url":"https://api.github.com/users/Coolthulhu/gists{/gist_id}","starred_url":"https://api.github.com/users/Coolthulhu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Coolthulhu/subscriptions","organizations_url":"https://api.github.com/users/Coolthulhu/orgs","repos_url":"https://api.github.com/users/Coolthulhu/repos","events_url":"https://api.github.com/users/Coolthulhu/events{/privacy}","received_events_url":"https://api.github.com/users/Coolthulhu/received_events","type":"User","site_admin":false},"body":"Changes quite significantly the behavior of some hacked bots (tested on tanks, chickens and skitterbots) and turrets with area of effect attacks.\r\n\r\nHacked bots will no longer depend on distance from player to pick an attack and will not skip turns if they can't see the player. Before, they'd attack zombies with the same attack they'd use to attack the player.\r\n\r\nBots (skitters, tanks and chickens) can now zap enemies when hacked. Currently this is always successful when attempted (because player can only dodge tazing with uncanny_dodge). Stun times and damage copied from iuse::tazer.\r\n\r\nMade mutant-ignoring turrets attack mutants driving vehicles, because weird animals don't drive vehicles.\r\n\r\nMoved range setting of turrets from hardcoded to a json member.\r\n\r\nMade turrets consider area of effect of their projectiles. They will ignore any target too close to attack without risking including self in the area of effect.\r\n\r\nDuring my testing it worked nicely, so it's probably fully or at least mostly functional.\r\nI changed the structure of monattack.cpp quite significantly. I moved aiming from functions like frag_tur up to the functions that use them, like multi_robot and chickenbot (otherwise hacked chickens and tanks would aim twice per attack).\r\n\r\nI sent a conflicting PR yesterday (manual turrets - conflicting on incredibly minor things, but still), so this is more for a review right now.","created_at":"2014-12-22T23:24:45Z","updated_at":"2014-12-26T04:47:11Z","closed_at":"2014-12-26T04:47:11Z","merged_at":"2014-12-26T04:47:11Z","merge_commit_sha":"a0fe6946541048327627073f9f18fa5219cba1f0","assignee":{"login":"KA101","id":4195632,"avatar_url":"https://avatars.githubusercontent.com/u/4195632?v=3","gravatar_id":"","url":"https://api.github.com/users/KA101","html_url":"https://github.com/KA101","followers_url":"https://api.github.com/users/KA101/followers","following_url":"https://api.github.com/users/KA101/following{/other_user}","gists_url":"https://api.github.com/users/KA101/gists{/gist_id}","starred_url":"https://api.github.com/users/KA101/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KA101/subscriptions","organizations_url":"https://api.github.com/users/KA101/orgs","repos_url":"https://api.github.com/users/KA101/repos","events_url":"https://api.github.com/users/KA101/events{/privacy}","received_events_url":"https://api.github.com/users/KA101/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/10601/commits","review_comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/10601/comments","review_comment_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments/{number}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/10601/comments","statuses_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/56a7392bbef41ca570d365be24be5def5e946bf5","head":{"label":"Coolthulhu:automatic-aim-ai","ref":"automatic-aim-ai","sha":"56a7392bbef41ca570d365be24be5def5e946bf5","user":{"login":"Coolthulhu","id":1878860,"avatar_url":"https://avatars.githubusercontent.com/u/1878860?v=3","gravatar_id":"","url":"https://api.github.com/users/Coolthulhu","html_url":"https://github.com/Coolthulhu","followers_url":"https://api.github.com/users/Coolthulhu/followers","following_url":"https://api.github.com/users/Coolthulhu/following{/other_user}","gists_url":"https://api.github.com/users/Coolthulhu/gists{/gist_id}","starred_url":"https://api.github.com/users/Coolthulhu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Coolthulhu/subscriptions","organizations_url":"https://api.github.com/users/Coolthulhu/orgs","repos_url":"https://api.github.com/users/Coolthulhu/repos","events_url":"https://api.github.com/users/Coolthulhu/events{/privacy}","received_events_url":"https://api.github.com/users/Coolthulhu/received_events","type":"User","site_admin":false},"repo":{"id":23649904,"name":"Cataclysm-DDA","full_name":"Coolthulhu/Cataclysm-DDA","owner":{"login":"Coolthulhu","id":1878860,"avatar_url":"https://avatars.githubusercontent.com/u/1878860?v=3","gravatar_id":"","url":"https://api.github.com/users/Coolthulhu","html_url":"https://github.com/Coolthulhu","followers_url":"https://api.github.com/users/Coolthulhu/followers","following_url":"https://api.github.com/users/Coolthulhu/following{/other_user}","gists_url":"https://api.github.com/users/Coolthulhu/gists{/gist_id}","starred_url":"https://api.github.com/users/Coolthulhu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Coolthulhu/subscriptions","organizations_url":"https://api.github.com/users/Coolthulhu/orgs","repos_url":"https://api.github.com/users/Coolthulhu/repos","events_url":"https://api.github.com/users/Coolthulhu/events{/privacy}","received_events_url":"https://api.github.com/users/Coolthulhu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Coolthulhu/Cataclysm-DDA","description":"Cataclysm - Dark Days Ahead. A fork/variant of Cataclysm Roguelike by Whales.","fork":true,"url":"https://api.github.com/repos/Coolthulhu/Cataclysm-DDA","forks_url":"https://api.github.com/repos/Coolthulhu/Cataclysm-DDA/forks","keys_url":"https://api.github.com/repos/Coolthulhu/Cataclysm-DDA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Coolthulhu/Cataclysm-DDA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Coolthulhu/Cataclysm-DDA/teams","hooks_url":"https://api.github.com/repos/Coolthulhu/Cataclysm-DDA/hooks","issue_events_url":"https://api.github.com/repos/Coolthulhu/Cataclysm-DDA/issues/events{/number}","events_url":"https://api.github.com/repos/Coolthulhu/Cataclysm-DDA/events","assignees_url":"https://api.github.com/repos/Coolthulhu/Cataclysm-DDA/assignees{/user}","branches_url":"https://api.github.com/repos/Coolthulhu/Cataclysm-DDA/branches{/branch}","tags_url":"https://api.github.com/repos/Coolthulhu/Cataclysm-DDA/tags","blobs_url":"https://api.github.com/repos/Coolthulhu/Cataclysm-DDA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Coolthulhu/Cataclysm-DDA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Coolthulhu/Cataclysm-DDA/git/refs{/sha}","trees_url":"https://api.github.com/repos/Coolthulhu/Cataclysm-DDA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Coolthulhu/Cataclysm-DDA/statuses/{sha}","languages_url":"https://api.github.com/repos/Coolthulhu/Cataclysm-DDA/languages","stargazers_url":"https://api.github.com/repos/Coolthulhu/Cataclysm-DDA/stargazers","contributors_url":"https://api.github.com/repos/Coolthulhu/Cataclysm-DDA/contributors","subscribers_url":"https://api.github.com/repos/Coolthulhu/Cataclysm-DDA/subscribers","subscription_url":"https://api.github.com/repos/Coolthulhu/Cataclysm-DDA/subscription","commits_url":"https://api.github.com/repos/Coolthulhu/Cataclysm-DDA/commits{/sha}","git_commits_url":"https://api.github.com/repos/Coolthulhu/Cataclysm-DDA/git/commits{/sha}","comments_url":"https://api.github.com/repos/Coolthulhu/Cataclysm-DDA/comments{/number}","issue_comment_url":"https://api.github.com/repos/Coolthulhu/Cataclysm-DDA/issues/comments/{number}","contents_url":"https://api.github.com/repos/Coolthulhu/Cataclysm-DDA/contents/{+path}","compare_url":"https://api.github.com/repos/Coolthulhu/Cataclysm-DDA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Coolthulhu/Cataclysm-DDA/merges","archive_url":"https://api.github.com/repos/Coolthulhu/Cataclysm-DDA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Coolthulhu/Cataclysm-DDA/downloads","issues_url":"https://api.github.com/repos/Coolthulhu/Cataclysm-DDA/issues{/number}","pulls_url":"https://api.github.com/repos/Coolthulhu/Cataclysm-DDA/pulls{/number}","milestones_url":"https://api.github.com/repos/Coolthulhu/Cataclysm-DDA/milestones{/number}","notifications_url":"https://api.github.com/repos/Coolthulhu/Cataclysm-DDA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Coolthulhu/Cataclysm-DDA/labels{/name}","releases_url":"https://api.github.com/repos/Coolthulhu/Cataclysm-DDA/releases{/id}","created_at":"2014-09-04T05:39:34Z","updated_at":"2014-12-25T20:57:58Z","pushed_at":"2014-12-26T04:31:43Z","git_url":"git://github.com/Coolthulhu/Cataclysm-DDA.git","ssh_url":"git@github.com:Coolthulhu/Cataclysm-DDA.git","clone_url":"https://github.com/Coolthulhu/Cataclysm-DDA.git","svn_url":"https://github.com/Coolthulhu/Cataclysm-DDA","homepage":"http://en.cataclysmdda.com/","size":329154,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CleverRaven:master","ref":"master","sha":"fd457cb6f0a5a57ac0a16cdee1f64e84fba9d449","user":{"login":"CleverRaven","id":4367009,"avatar_url":"https://avatars.githubusercontent.com/u/4367009?v=3","gravatar_id":"","url":"https://api.github.com/users/CleverRaven","html_url":"https://github.com/CleverRaven","followers_url":"https://api.github.com/users/CleverRaven/followers","following_url":"https://api.github.com/users/CleverRaven/following{/other_user}","gists_url":"https://api.github.com/users/CleverRaven/gists{/gist_id}","starred_url":"https://api.github.com/users/CleverRaven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CleverRaven/subscriptions","organizations_url":"https://api.github.com/users/CleverRaven/orgs","repos_url":"https://api.github.com/users/CleverRaven/repos","events_url":"https://api.github.com/users/CleverRaven/events{/privacy}","received_events_url":"https://api.github.com/users/CleverRaven/received_events","type":"Organization","site_admin":false},"repo":{"id":5973855,"name":"Cataclysm-DDA","full_name":"CleverRaven/Cataclysm-DDA","owner":{"login":"CleverRaven","id":4367009,"avatar_url":"https://avatars.githubusercontent.com/u/4367009?v=3","gravatar_id":"","url":"https://api.github.com/users/CleverRaven","html_url":"https://github.com/CleverRaven","followers_url":"https://api.github.com/users/CleverRaven/followers","following_url":"https://api.github.com/users/CleverRaven/following{/other_user}","gists_url":"https://api.github.com/users/CleverRaven/gists{/gist_id}","starred_url":"https://api.github.com/users/CleverRaven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CleverRaven/subscriptions","organizations_url":"https://api.github.com/users/CleverRaven/orgs","repos_url":"https://api.github.com/users/CleverRaven/repos","events_url":"https://api.github.com/users/CleverRaven/events{/privacy}","received_events_url":"https://api.github.com/users/CleverRaven/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CleverRaven/Cataclysm-DDA","description":"Cataclysm - Dark Days Ahead. A fork/variant of Cataclysm Roguelike by Whales.","fork":false,"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA","forks_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/forks","keys_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/teams","hooks_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/hooks","issue_events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/events{/number}","events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/events","assignees_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/assignees{/user}","branches_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/branches{/branch}","tags_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/tags","blobs_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/refs{/sha}","trees_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/{sha}","languages_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/languages","stargazers_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/stargazers","contributors_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/contributors","subscribers_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/subscribers","subscription_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/subscription","commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/commits{/sha}","git_commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/commits{/sha}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/comments{/number}","issue_comment_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/comments/{number}","contents_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/contents/{+path}","compare_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/merges","archive_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/downloads","issues_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues{/number}","pulls_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls{/number}","milestones_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/milestones{/number}","notifications_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/labels{/name}","releases_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/releases{/id}","created_at":"2012-09-26T22:57:43Z","updated_at":"2014-12-26T04:47:03Z","pushed_at":"2014-12-26T04:47:02Z","git_url":"git://github.com/CleverRaven/Cataclysm-DDA.git","ssh_url":"git@github.com:CleverRaven/Cataclysm-DDA.git","clone_url":"https://github.com/CleverRaven/Cataclysm-DDA.git","svn_url":"https://github.com/CleverRaven/Cataclysm-DDA","homepage":"http://en.cataclysmdda.com/","size":395614,"stargazers_count":552,"watchers_count":552,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":615,"mirror_url":null,"open_issues_count":784,"forks":615,"open_issues":784,"watchers":552,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/10601"},"html":{"href":"https://github.com/CleverRaven/Cataclysm-DDA/pull/10601"},"issue":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/10601"},"comments":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/10601/comments"},"review_comments":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/10601/comments"},"review_comment":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/10601/commits"},"statuses":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/56a7392bbef41ca570d365be24be5def5e946bf5"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"KA101","id":4195632,"avatar_url":"https://avatars.githubusercontent.com/u/4195632?v=3","gravatar_id":"","url":"https://api.github.com/users/KA101","html_url":"https://github.com/KA101","followers_url":"https://api.github.com/users/KA101/followers","following_url":"https://api.github.com/users/KA101/following{/other_user}","gists_url":"https://api.github.com/users/KA101/gists{/gist_id}","starred_url":"https://api.github.com/users/KA101/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KA101/subscriptions","organizations_url":"https://api.github.com/users/KA101/orgs","repos_url":"https://api.github.com/users/KA101/repos","events_url":"https://api.github.com/users/KA101/events{/privacy}","received_events_url":"https://api.github.com/users/KA101/received_events","type":"User","site_admin":false},"comments":13,"review_comments":10,"commits":11,"additions":409,"deletions":250,"changed_files":12}}