GitHub PullRequestReviewCommentEvent at 2014-11-06 20:41:36
Repository: bla
Actor: lemmy-
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/baby-loris/bla/pulls/comments/19973378","id":19973378,"diff_hunk":"@@ -4,25 +4,29 @@ var ApiError = require('../api-error');\n  * Normalizes value by passed type.\n  *\n  * @param {String} value Parameter value.\n- * @param {String} type Parameter type.\n+ * @param {String} [type=asis] Parameter type.\n  * @param {String} [name] Parameter name showing in a error message.\n  * @returns {*}\n  * @throws HTTP error\n  */\n module.exports = function (value, type, name) {\n     name = name || '';\n-    switch (type) {\n-        case 'Number':\n+    type = type || 'asis';","path":"lib/utils/normalize.js","position":14,"original_position":14,"commit_id":"0ecf5743dbd431a4761f097e8031023f90e542eb","original_commit_id":"0ecf5743dbd431a4761f097e8031023f90e542eb","user":{"login":"lemmy-","id":5200135,"avatar_url":"https://avatars.githubusercontent.com/u/5200135?v=2","gravatar_id":"","url":"https://api.github.com/users/lemmy-","html_url":"https://github.com/lemmy-","followers_url":"https://api.github.com/users/lemmy-/followers","following_url":"https://api.github.com/users/lemmy-/following{/other_user}","gists_url":"https://api.github.com/users/lemmy-/gists{/gist_id}","starred_url":"https://api.github.com/users/lemmy-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lemmy-/subscriptions","organizations_url":"https://api.github.com/users/lemmy-/orgs","repos_url":"https://api.github.com/users/lemmy-/repos","events_url":"https://api.github.com/users/lemmy-/events{/privacy}","received_events_url":"https://api.github.com/users/lemmy-/received_events","type":"User","site_admin":false},"body":"I think we could do without `asis`. Maybe just `if (!type) return value;` ?","created_at":"2014-11-06T20:41:36Z","updated_at":"2014-11-06T20:41:36Z","html_url":"https://github.com/baby-loris/bla/pull/58#discussion_r19973378","pull_request_url":"https://api.github.com/repos/baby-loris/bla/pulls/58","_links":{"self":{"href":"https://api.github.com/repos/baby-loris/bla/pulls/comments/19973378"},"html":{"href":"https://github.com/baby-loris/bla/pull/58#discussion_r19973378"},"pull_request":{"href":"https://api.github.com/repos/baby-loris/bla/pulls/58"}}},"pull_request":{"url":"https://api.github.com/repos/baby-loris/bla/pulls/58","id":24007586,"html_url":"https://github.com/baby-loris/bla/pull/58","diff_url":"https://github.com/baby-loris/bla/pull/58.diff","patch_url":"https://github.com/baby-loris/bla/pull/58.patch","issue_url":"https://api.github.com/repos/baby-loris/bla/issues/58","number":58,"state":"open","locked":false,"title":"Ignore register in normalize and add string support","user":{"login":"tarmolov","id":366419,"avatar_url":"https://avatars.githubusercontent.com/u/366419?v=2","gravatar_id":"","url":"https://api.github.com/users/tarmolov","html_url":"https://github.com/tarmolov","followers_url":"https://api.github.com/users/tarmolov/followers","following_url":"https://api.github.com/users/tarmolov/following{/other_user}","gists_url":"https://api.github.com/users/tarmolov/gists{/gist_id}","starred_url":"https://api.github.com/users/tarmolov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tarmolov/subscriptions","organizations_url":"https://api.github.com/users/tarmolov/orgs","repos_url":"https://api.github.com/users/tarmolov/repos","events_url":"https://api.github.com/users/tarmolov/events{/privacy}","received_events_url":"https://api.github.com/users/tarmolov/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-11-06T19:54:30Z","updated_at":"2014-11-06T20:41:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d2ce2bab7067858c115b780df23f3c6c79c4bdba","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/baby-loris/bla/pulls/58/commits","review_comments_url":"https://api.github.com/repos/baby-loris/bla/pulls/58/comments","review_comment_url":"https://api.github.com/repos/baby-loris/bla/pulls/comments/{number}","comments_url":"https://api.github.com/repos/baby-loris/bla/issues/58/comments","statuses_url":"https://api.github.com/repos/baby-loris/bla/statuses/0ecf5743dbd431a4761f097e8031023f90e542eb","head":{"label":"baby-loris:normalize","ref":"normalize","sha":"0ecf5743dbd431a4761f097e8031023f90e542eb","user":{"login":"baby-loris","id":8769889,"avatar_url":"https://avatars.githubusercontent.com/u/8769889?v=2","gravatar_id":"","url":"https://api.github.com/users/baby-loris","html_url":"https://github.com/baby-loris","followers_url":"https://api.github.com/users/baby-loris/followers","following_url":"https://api.github.com/users/baby-loris/following{/other_user}","gists_url":"https://api.github.com/users/baby-loris/gists{/gist_id}","starred_url":"https://api.github.com/users/baby-loris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baby-loris/subscriptions","organizations_url":"https://api.github.com/users/baby-loris/orgs","repos_url":"https://api.github.com/users/baby-loris/repos","events_url":"https://api.github.com/users/baby-loris/events{/privacy}","received_events_url":"https://api.github.com/users/baby-loris/received_events","type":"Organization","site_admin":false},"repo":{"id":21876007,"name":"bla","full_name":"baby-loris/bla","owner":{"login":"baby-loris","id":8769889,"avatar_url":"https://avatars.githubusercontent.com/u/8769889?v=2","gravatar_id":"","url":"https://api.github.com/users/baby-loris","html_url":"https://github.com/baby-loris","followers_url":"https://api.github.com/users/baby-loris/followers","following_url":"https://api.github.com/users/baby-loris/following{/other_user}","gists_url":"https://api.github.com/users/baby-loris/gists{/gist_id}","starred_url":"https://api.github.com/users/baby-loris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baby-loris/subscriptions","organizations_url":"https://api.github.com/users/baby-loris/orgs","repos_url":"https://api.github.com/users/baby-loris/repos","events_url":"https://api.github.com/users/baby-loris/events{/privacy}","received_events_url":"https://api.github.com/users/baby-loris/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/baby-loris/bla","description":"Easy way to create your own API methods for server and client sides","fork":false,"url":"https://api.github.com/repos/baby-loris/bla","forks_url":"https://api.github.com/repos/baby-loris/bla/forks","keys_url":"https://api.github.com/repos/baby-loris/bla/keys{/key_id}","collaborators_url":"https://api.github.com/repos/baby-loris/bla/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/baby-loris/bla/teams","hooks_url":"https://api.github.com/repos/baby-loris/bla/hooks","issue_events_url":"https://api.github.com/repos/baby-loris/bla/issues/events{/number}","events_url":"https://api.github.com/repos/baby-loris/bla/events","assignees_url":"https://api.github.com/repos/baby-loris/bla/assignees{/user}","branches_url":"https://api.github.com/repos/baby-loris/bla/branches{/branch}","tags_url":"https://api.github.com/repos/baby-loris/bla/tags","blobs_url":"https://api.github.com/repos/baby-loris/bla/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/baby-loris/bla/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/baby-loris/bla/git/refs{/sha}","trees_url":"https://api.github.com/repos/baby-loris/bla/git/trees{/sha}","statuses_url":"https://api.github.com/repos/baby-loris/bla/statuses/{sha}","languages_url":"https://api.github.com/repos/baby-loris/bla/languages","stargazers_url":"https://api.github.com/repos/baby-loris/bla/stargazers","contributors_url":"https://api.github.com/repos/baby-loris/bla/contributors","subscribers_url":"https://api.github.com/repos/baby-loris/bla/subscribers","subscription_url":"https://api.github.com/repos/baby-loris/bla/subscription","commits_url":"https://api.github.com/repos/baby-loris/bla/commits{/sha}","git_commits_url":"https://api.github.com/repos/baby-loris/bla/git/commits{/sha}","comments_url":"https://api.github.com/repos/baby-loris/bla/comments{/number}","issue_comment_url":"https://api.github.com/repos/baby-loris/bla/issues/comments/{number}","contents_url":"https://api.github.com/repos/baby-loris/bla/contents/{+path}","compare_url":"https://api.github.com/repos/baby-loris/bla/compare/{base}...{head}","merges_url":"https://api.github.com/repos/baby-loris/bla/merges","archive_url":"https://api.github.com/repos/baby-loris/bla/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/baby-loris/bla/downloads","issues_url":"https://api.github.com/repos/baby-loris/bla/issues{/number}","pulls_url":"https://api.github.com/repos/baby-loris/bla/pulls{/number}","milestones_url":"https://api.github.com/repos/baby-loris/bla/milestones{/number}","notifications_url":"https://api.github.com/repos/baby-loris/bla/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/baby-loris/bla/labels{/name}","releases_url":"https://api.github.com/repos/baby-loris/bla/releases{/id}","created_at":"2014-07-15T21:09:57Z","updated_at":"2014-10-23T18:09:44Z","pushed_at":"2014-11-06T20:10:52Z","git_url":"git://github.com/baby-loris/bla.git","ssh_url":"git@github.com:baby-loris/bla.git","clone_url":"https://github.com/baby-loris/bla.git","svn_url":"https://github.com/baby-loris/bla","homepage":null,"size":1613,"stargazers_count":12,"watchers_count":12,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":5,"forks":2,"open_issues":5,"watchers":12,"default_branch":"master"}},"base":{"label":"baby-loris:master","ref":"master","sha":"da0abce3e226535cf7825299dfa5ed783f8867e9","user":{"login":"baby-loris","id":8769889,"avatar_url":"https://avatars.githubusercontent.com/u/8769889?v=2","gravatar_id":"","url":"https://api.github.com/users/baby-loris","html_url":"https://github.com/baby-loris","followers_url":"https://api.github.com/users/baby-loris/followers","following_url":"https://api.github.com/users/baby-loris/following{/other_user}","gists_url":"https://api.github.com/users/baby-loris/gists{/gist_id}","starred_url":"https://api.github.com/users/baby-loris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baby-loris/subscriptions","organizations_url":"https://api.github.com/users/baby-loris/orgs","repos_url":"https://api.github.com/users/baby-loris/repos","events_url":"https://api.github.com/users/baby-loris/events{/privacy}","received_events_url":"https://api.github.com/users/baby-loris/received_events","type":"Organization","site_admin":false},"repo":{"id":21876007,"name":"bla","full_name":"baby-loris/bla","owner":{"login":"baby-loris","id":8769889,"avatar_url":"https://avatars.githubusercontent.com/u/8769889?v=2","gravatar_id":"","url":"https://api.github.com/users/baby-loris","html_url":"https://github.com/baby-loris","followers_url":"https://api.github.com/users/baby-loris/followers","following_url":"https://api.github.com/users/baby-loris/following{/other_user}","gists_url":"https://api.github.com/users/baby-loris/gists{/gist_id}","starred_url":"https://api.github.com/users/baby-loris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baby-loris/subscriptions","organizations_url":"https://api.github.com/users/baby-loris/orgs","repos_url":"https://api.github.com/users/baby-loris/repos","events_url":"https://api.github.com/users/baby-loris/events{/privacy}","received_events_url":"https://api.github.com/users/baby-loris/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/baby-loris/bla","description":"Easy way to create your own API methods for server and client sides","fork":false,"url":"https://api.github.com/repos/baby-loris/bla","forks_url":"https://api.github.com/repos/baby-loris/bla/forks","keys_url":"https://api.github.com/repos/baby-loris/bla/keys{/key_id}","collaborators_url":"https://api.github.com/repos/baby-loris/bla/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/baby-loris/bla/teams","hooks_url":"https://api.github.com/repos/baby-loris/bla/hooks","issue_events_url":"https://api.github.com/repos/baby-loris/bla/issues/events{/number}","events_url":"https://api.github.com/repos/baby-loris/bla/events","assignees_url":"https://api.github.com/repos/baby-loris/bla/assignees{/user}","branches_url":"https://api.github.com/repos/baby-loris/bla/branches{/branch}","tags_url":"https://api.github.com/repos/baby-loris/bla/tags","blobs_url":"https://api.github.com/repos/baby-loris/bla/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/baby-loris/bla/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/baby-loris/bla/git/refs{/sha}","trees_url":"https://api.github.com/repos/baby-loris/bla/git/trees{/sha}","statuses_url":"https://api.github.com/repos/baby-loris/bla/statuses/{sha}","languages_url":"https://api.github.com/repos/baby-loris/bla/languages","stargazers_url":"https://api.github.com/repos/baby-loris/bla/stargazers","contributors_url":"https://api.github.com/repos/baby-loris/bla/contributors","subscribers_url":"https://api.github.com/repos/baby-loris/bla/subscribers","subscription_url":"https://api.github.com/repos/baby-loris/bla/subscription","commits_url":"https://api.github.com/repos/baby-loris/bla/commits{/sha}","git_commits_url":"https://api.github.com/repos/baby-loris/bla/git/commits{/sha}","comments_url":"https://api.github.com/repos/baby-loris/bla/comments{/number}","issue_comment_url":"https://api.github.com/repos/baby-loris/bla/issues/comments/{number}","contents_url":"https://api.github.com/repos/baby-loris/bla/contents/{+path}","compare_url":"https://api.github.com/repos/baby-loris/bla/compare/{base}...{head}","merges_url":"https://api.github.com/repos/baby-loris/bla/merges","archive_url":"https://api.github.com/repos/baby-loris/bla/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/baby-loris/bla/downloads","issues_url":"https://api.github.com/repos/baby-loris/bla/issues{/number}","pulls_url":"https://api.github.com/repos/baby-loris/bla/pulls{/number}","milestones_url":"https://api.github.com/repos/baby-loris/bla/milestones{/number}","notifications_url":"https://api.github.com/repos/baby-loris/bla/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/baby-loris/bla/labels{/name}","releases_url":"https://api.github.com/repos/baby-loris/bla/releases{/id}","created_at":"2014-07-15T21:09:57Z","updated_at":"2014-10-23T18:09:44Z","pushed_at":"2014-11-06T20:10:52Z","git_url":"git://github.com/baby-loris/bla.git","ssh_url":"git@github.com:baby-loris/bla.git","clone_url":"https://github.com/baby-loris/bla.git","svn_url":"https://github.com/baby-loris/bla","homepage":null,"size":1613,"stargazers_count":12,"watchers_count":12,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":5,"forks":2,"open_issues":5,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/baby-loris/bla/pulls/58"},"html":{"href":"https://github.com/baby-loris/bla/pull/58"},"issue":{"href":"https://api.github.com/repos/baby-loris/bla/issues/58"},"comments":{"href":"https://api.github.com/repos/baby-loris/bla/issues/58/comments"},"review_comments":{"href":"https://api.github.com/repos/baby-loris/bla/pulls/58/comments"},"review_comment":{"href":"https://api.github.com/repos/baby-loris/bla/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/baby-loris/bla/pulls/58/commits"},"statuses":{"href":"https://api.github.com/repos/baby-loris/bla/statuses/0ecf5743dbd431a4761f097e8031023f90e542eb"}}}}