GitHub PullRequestReviewCommentEvent at 2014-11-07 10:56:32
Repository: ezpublish-community
Actor: bdunogier
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/ezsystems/ezpublish-community/pulls/comments/20004563","id":20004563,"diff_hunk":"@@ -58,11 +52,21 @@\n {\n     $useHttpCache = $environment !== \"dev\";\n }\n+\n // Load HTTP Cache ...\n if ( $useHttpCache )\n {\n-    require_once __DIR__ . '/../ezpublish/EzPublishCache.php';\n-    $kernel = new EzPublishCache( $kernel );\n+    // The standard HttpCache implementation can be overridden by setting the HTTP_CACHE_CLASS environment variable.\n+    // Make sure to setup composer config so it is *autoloadable*, or fallback to use \"CUSTOM_CLASSLOADER_FILE\"\n+    if ( ( $httpCacheClass = getenv( \"HTTP_CACHE_CLASS\" ) ) !== false )\n+    {\n+        $kernel = new $httpCacheClass( $kernel );\n+    }\n+    else\n+    {\n+        require_once __DIR__ . '/../ezpublish/EzPublishCache.php';\n+        $kernel = new EzPublishCache($kernel);","path":"web/index.php","position":58,"original_position":58,"commit_id":"339225ff4c83b9fa1984fd3aab5abc94fe5a89b1","original_commit_id":"339225ff4c83b9fa1984fd3aab5abc94fe5a89b1","user":{"login":"bdunogier","id":235928,"avatar_url":"https://avatars.githubusercontent.com/u/235928?v=2","gravatar_id":"","url":"https://api.github.com/users/bdunogier","html_url":"https://github.com/bdunogier","followers_url":"https://api.github.com/users/bdunogier/followers","following_url":"https://api.github.com/users/bdunogier/following{/other_user}","gists_url":"https://api.github.com/users/bdunogier/gists{/gist_id}","starred_url":"https://api.github.com/users/bdunogier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdunogier/subscriptions","organizations_url":"https://api.github.com/users/bdunogier/orgs","repos_url":"https://api.github.com/users/bdunogier/repos","events_url":"https://api.github.com/users/bdunogier/events{/privacy}","received_events_url":"https://api.github.com/users/bdunogier/received_events","type":"User","site_admin":false},"body":"CS `( $kernel )`","created_at":"2014-11-07T10:56:32Z","updated_at":"2014-11-07T10:56:32Z","html_url":"https://github.com/ezsystems/ezpublish-community/pull/202#discussion_r20004563","pull_request_url":"https://api.github.com/repos/ezsystems/ezpublish-community/pulls/202","_links":{"self":{"href":"https://api.github.com/repos/ezsystems/ezpublish-community/pulls/comments/20004563"},"html":{"href":"https://github.com/ezsystems/ezpublish-community/pull/202#discussion_r20004563"},"pull_request":{"href":"https://api.github.com/repos/ezsystems/ezpublish-community/pulls/202"}}},"pull_request":{"url":"https://api.github.com/repos/ezsystems/ezpublish-community/pulls/202","id":24045163,"html_url":"https://github.com/ezsystems/ezpublish-community/pull/202","diff_url":"https://github.com/ezsystems/ezpublish-community/pull/202.diff","patch_url":"https://github.com/ezsystems/ezpublish-community/pull/202.patch","issue_url":"https://api.github.com/repos/ezsystems/ezpublish-community/issues/202","number":202,"state":"open","locked":false,"title":"Implement support for custom http cache & class loader","user":{"login":"andrerom","id":289757,"avatar_url":"https://avatars.githubusercontent.com/u/289757?v=2","gravatar_id":"","url":"https://api.github.com/users/andrerom","html_url":"https://github.com/andrerom","followers_url":"https://api.github.com/users/andrerom/followers","following_url":"https://api.github.com/users/andrerom/following{/other_user}","gists_url":"https://api.github.com/users/andrerom/gists{/gist_id}","starred_url":"https://api.github.com/users/andrerom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrerom/subscriptions","organizations_url":"https://api.github.com/users/andrerom/orgs","repos_url":"https://api.github.com/users/andrerom/repos","events_url":"https://api.github.com/users/andrerom/events{/privacy}","received_events_url":"https://api.github.com/users/andrerom/received_events","type":"User","site_admin":false},"body":"Closes #53\r\n\r\nBased on work by @patrickallaert, but adapted for the comments in #53 to\r\nsupport custom class loader, and also added in the new apache/nginx vhost doc.\r\n\r\nOh, and removed Apc stuff as this can be archived with the new variables instead now.\r\n\r\nping @lolautruche @dpobel @bdunogier ","created_at":"2014-11-07T10:41:55Z","updated_at":"2014-11-07T10:56:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fd4cf5ccb7a59ffce8078a45682a4f4dbb0a92f0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ezsystems/ezpublish-community/pulls/202/commits","review_comments_url":"https://api.github.com/repos/ezsystems/ezpublish-community/pulls/202/comments","review_comment_url":"https://api.github.com/repos/ezsystems/ezpublish-community/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ezsystems/ezpublish-community/issues/202/comments","statuses_url":"https://api.github.com/repos/ezsystems/ezpublish-community/statuses/339225ff4c83b9fa1984fd3aab5abc94fe5a89b1","head":{"label":"ezsystems:custom_cache_n_classloader_env","ref":"custom_cache_n_classloader_env","sha":"339225ff4c83b9fa1984fd3aab5abc94fe5a89b1","user":{"login":"ezsystems","id":295311,"avatar_url":"https://avatars.githubusercontent.com/u/295311?v=2","gravatar_id":"","url":"https://api.github.com/users/ezsystems","html_url":"https://github.com/ezsystems","followers_url":"https://api.github.com/users/ezsystems/followers","following_url":"https://api.github.com/users/ezsystems/following{/other_user}","gists_url":"https://api.github.com/users/ezsystems/gists{/gist_id}","starred_url":"https://api.github.com/users/ezsystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezsystems/subscriptions","organizations_url":"https://api.github.com/users/ezsystems/orgs","repos_url":"https://api.github.com/users/ezsystems/repos","events_url":"https://api.github.com/users/ezsystems/events{/privacy}","received_events_url":"https://api.github.com/users/ezsystems/received_events","type":"Organization","site_admin":false},"repo":{"id":4265959,"name":"ezpublish-community","full_name":"ezsystems/ezpublish-community","owner":{"login":"ezsystems","id":295311,"avatar_url":"https://avatars.githubusercontent.com/u/295311?v=2","gravatar_id":"","url":"https://api.github.com/users/ezsystems","html_url":"https://github.com/ezsystems","followers_url":"https://api.github.com/users/ezsystems/followers","following_url":"https://api.github.com/users/ezsystems/following{/other_user}","gists_url":"https://api.github.com/users/ezsystems/gists{/gist_id}","starred_url":"https://api.github.com/users/ezsystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezsystems/subscriptions","organizations_url":"https://api.github.com/users/ezsystems/orgs","repos_url":"https://api.github.com/users/ezsystems/repos","events_url":"https://api.github.com/users/ezsystems/events{/privacy}","received_events_url":"https://api.github.com/users/ezsystems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ezsystems/ezpublish-community","description":"This is eZ Publish 5 Community edition, it is a meta repository that pulls in all dependencies for full 5.x community build.","fork":false,"url":"https://api.github.com/repos/ezsystems/ezpublish-community","forks_url":"https://api.github.com/repos/ezsystems/ezpublish-community/forks","keys_url":"https://api.github.com/repos/ezsystems/ezpublish-community/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ezsystems/ezpublish-community/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ezsystems/ezpublish-community/teams","hooks_url":"https://api.github.com/repos/ezsystems/ezpublish-community/hooks","issue_events_url":"https://api.github.com/repos/ezsystems/ezpublish-community/issues/events{/number}","events_url":"https://api.github.com/repos/ezsystems/ezpublish-community/events","assignees_url":"https://api.github.com/repos/ezsystems/ezpublish-community/assignees{/user}","branches_url":"https://api.github.com/repos/ezsystems/ezpublish-community/branches{/branch}","tags_url":"https://api.github.com/repos/ezsystems/ezpublish-community/tags","blobs_url":"https://api.github.com/repos/ezsystems/ezpublish-community/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ezsystems/ezpublish-community/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ezsystems/ezpublish-community/git/refs{/sha}","trees_url":"https://api.github.com/repos/ezsystems/ezpublish-community/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ezsystems/ezpublish-community/statuses/{sha}","languages_url":"https://api.github.com/repos/ezsystems/ezpublish-community/languages","stargazers_url":"https://api.github.com/repos/ezsystems/ezpublish-community/stargazers","contributors_url":"https://api.github.com/repos/ezsystems/ezpublish-community/contributors","subscribers_url":"https://api.github.com/repos/ezsystems/ezpublish-community/subscribers","subscription_url":"https://api.github.com/repos/ezsystems/ezpublish-community/subscription","commits_url":"https://api.github.com/repos/ezsystems/ezpublish-community/commits{/sha}","git_commits_url":"https://api.github.com/repos/ezsystems/ezpublish-community/git/commits{/sha}","comments_url":"https://api.github.com/repos/ezsystems/ezpublish-community/comments{/number}","issue_comment_url":"https://api.github.com/repos/ezsystems/ezpublish-community/issues/comments/{number}","contents_url":"https://api.github.com/repos/ezsystems/ezpublish-community/contents/{+path}","compare_url":"https://api.github.com/repos/ezsystems/ezpublish-community/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ezsystems/ezpublish-community/merges","archive_url":"https://api.github.com/repos/ezsystems/ezpublish-community/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ezsystems/ezpublish-community/downloads","issues_url":"https://api.github.com/repos/ezsystems/ezpublish-community/issues{/number}","pulls_url":"https://api.github.com/repos/ezsystems/ezpublish-community/pulls{/number}","milestones_url":"https://api.github.com/repos/ezsystems/ezpublish-community/milestones{/number}","notifications_url":"https://api.github.com/repos/ezsystems/ezpublish-community/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ezsystems/ezpublish-community/labels{/name}","releases_url":"https://api.github.com/repos/ezsystems/ezpublish-community/releases{/id}","created_at":"2012-05-08T22:02:13Z","updated_at":"2014-11-04T18:17:28Z","pushed_at":"2014-11-07T10:41:35Z","git_url":"git://github.com/ezsystems/ezpublish-community.git","ssh_url":"git@github.com:ezsystems/ezpublish-community.git","clone_url":"https://github.com/ezsystems/ezpublish-community.git","svn_url":"https://github.com/ezsystems/ezpublish-community","homepage":"http://share.ez.no","size":13108,"stargazers_count":231,"watchers_count":231,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":112,"mirror_url":null,"open_issues_count":6,"forks":112,"open_issues":6,"watchers":231,"default_branch":"master"}},"base":{"label":"ezsystems:master","ref":"master","sha":"b48ab70c4afa1aab19024156ad8df628465da6c3","user":{"login":"ezsystems","id":295311,"avatar_url":"https://avatars.githubusercontent.com/u/295311?v=2","gravatar_id":"","url":"https://api.github.com/users/ezsystems","html_url":"https://github.com/ezsystems","followers_url":"https://api.github.com/users/ezsystems/followers","following_url":"https://api.github.com/users/ezsystems/following{/other_user}","gists_url":"https://api.github.com/users/ezsystems/gists{/gist_id}","starred_url":"https://api.github.com/users/ezsystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezsystems/subscriptions","organizations_url":"https://api.github.com/users/ezsystems/orgs","repos_url":"https://api.github.com/users/ezsystems/repos","events_url":"https://api.github.com/users/ezsystems/events{/privacy}","received_events_url":"https://api.github.com/users/ezsystems/received_events","type":"Organization","site_admin":false},"repo":{"id":4265959,"name":"ezpublish-community","full_name":"ezsystems/ezpublish-community","owner":{"login":"ezsystems","id":295311,"avatar_url":"https://avatars.githubusercontent.com/u/295311?v=2","gravatar_id":"","url":"https://api.github.com/users/ezsystems","html_url":"https://github.com/ezsystems","followers_url":"https://api.github.com/users/ezsystems/followers","following_url":"https://api.github.com/users/ezsystems/following{/other_user}","gists_url":"https://api.github.com/users/ezsystems/gists{/gist_id}","starred_url":"https://api.github.com/users/ezsystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezsystems/subscriptions","organizations_url":"https://api.github.com/users/ezsystems/orgs","repos_url":"https://api.github.com/users/ezsystems/repos","events_url":"https://api.github.com/users/ezsystems/events{/privacy}","received_events_url":"https://api.github.com/users/ezsystems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ezsystems/ezpublish-community","description":"This is eZ Publish 5 Community edition, it is a meta repository that pulls in all dependencies for full 5.x community build.","fork":false,"url":"https://api.github.com/repos/ezsystems/ezpublish-community","forks_url":"https://api.github.com/repos/ezsystems/ezpublish-community/forks","keys_url":"https://api.github.com/repos/ezsystems/ezpublish-community/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ezsystems/ezpublish-community/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ezsystems/ezpublish-community/teams","hooks_url":"https://api.github.com/repos/ezsystems/ezpublish-community/hooks","issue_events_url":"https://api.github.com/repos/ezsystems/ezpublish-community/issues/events{/number}","events_url":"https://api.github.com/repos/ezsystems/ezpublish-community/events","assignees_url":"https://api.github.com/repos/ezsystems/ezpublish-community/assignees{/user}","branches_url":"https://api.github.com/repos/ezsystems/ezpublish-community/branches{/branch}","tags_url":"https://api.github.com/repos/ezsystems/ezpublish-community/tags","blobs_url":"https://api.github.com/repos/ezsystems/ezpublish-community/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ezsystems/ezpublish-community/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ezsystems/ezpublish-community/git/refs{/sha}","trees_url":"https://api.github.com/repos/ezsystems/ezpublish-community/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ezsystems/ezpublish-community/statuses/{sha}","languages_url":"https://api.github.com/repos/ezsystems/ezpublish-community/languages","stargazers_url":"https://api.github.com/repos/ezsystems/ezpublish-community/stargazers","contributors_url":"https://api.github.com/repos/ezsystems/ezpublish-community/contributors","subscribers_url":"https://api.github.com/repos/ezsystems/ezpublish-community/subscribers","subscription_url":"https://api.github.com/repos/ezsystems/ezpublish-community/subscription","commits_url":"https://api.github.com/repos/ezsystems/ezpublish-community/commits{/sha}","git_commits_url":"https://api.github.com/repos/ezsystems/ezpublish-community/git/commits{/sha}","comments_url":"https://api.github.com/repos/ezsystems/ezpublish-community/comments{/number}","issue_comment_url":"https://api.github.com/repos/ezsystems/ezpublish-community/issues/comments/{number}","contents_url":"https://api.github.com/repos/ezsystems/ezpublish-community/contents/{+path}","compare_url":"https://api.github.com/repos/ezsystems/ezpublish-community/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ezsystems/ezpublish-community/merges","archive_url":"https://api.github.com/repos/ezsystems/ezpublish-community/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ezsystems/ezpublish-community/downloads","issues_url":"https://api.github.com/repos/ezsystems/ezpublish-community/issues{/number}","pulls_url":"https://api.github.com/repos/ezsystems/ezpublish-community/pulls{/number}","milestones_url":"https://api.github.com/repos/ezsystems/ezpublish-community/milestones{/number}","notifications_url":"https://api.github.com/repos/ezsystems/ezpublish-community/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ezsystems/ezpublish-community/labels{/name}","releases_url":"https://api.github.com/repos/ezsystems/ezpublish-community/releases{/id}","created_at":"2012-05-08T22:02:13Z","updated_at":"2014-11-04T18:17:28Z","pushed_at":"2014-11-07T10:41:35Z","git_url":"git://github.com/ezsystems/ezpublish-community.git","ssh_url":"git@github.com:ezsystems/ezpublish-community.git","clone_url":"https://github.com/ezsystems/ezpublish-community.git","svn_url":"https://github.com/ezsystems/ezpublish-community","homepage":"http://share.ez.no","size":13108,"stargazers_count":231,"watchers_count":231,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":112,"mirror_url":null,"open_issues_count":6,"forks":112,"open_issues":6,"watchers":231,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ezsystems/ezpublish-community/pulls/202"},"html":{"href":"https://github.com/ezsystems/ezpublish-community/pull/202"},"issue":{"href":"https://api.github.com/repos/ezsystems/ezpublish-community/issues/202"},"comments":{"href":"https://api.github.com/repos/ezsystems/ezpublish-community/issues/202/comments"},"review_comments":{"href":"https://api.github.com/repos/ezsystems/ezpublish-community/pulls/202/comments"},"review_comment":{"href":"https://api.github.com/repos/ezsystems/ezpublish-community/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ezsystems/ezpublish-community/pulls/202/commits"},"statuses":{"href":"https://api.github.com/repos/ezsystems/ezpublish-community/statuses/339225ff4c83b9fa1984fd3aab5abc94fe5a89b1"}}}}