GitHub PullRequestReviewCommentEvent at 2014-04-17 16:47:25
Repository: read-only-certificate-code
Actor: jarv
Payload: {"comment":{"url":"https://api.github.com/repos/edx/read-only-certificate-code/pulls/comments/11741631","id":11741631,"diff_hunk":"@@ -222,29 +226,34 @@ def create_and_upload(self, name, upload=True, cleanup=True,\n                     verify_dir=verify_path)\n \n         # upload generated certificate and verification files to S3\n-        if upload:\n-            base_url = 'http://{0}.s3.amazonaws.com'.format(BUCKET)\n-            s3 = S3Bucket(BUCKET,\n-                    access_key=str(self.aws_id),\n-                    secret_key=str(self.aws_key),\n-                    base_url=base_url)\n-\n-            for dirpath, dirnames, filenames in os.walk(self.dir_prefix):\n-                for filename in filenames:\n-                    aws_path = os.path.relpath(os.path.join(dirpath, filename),\n-                                                    start=self.dir_prefix)\n-                    local_path = os.path.join(dirpath, filename)\n+        for dirpath, dirnames, filenames in os.walk(self.dir_prefix):\n+            for filename in filenames:\n+                local_path = os.path.join(dirpath, filename)\n+                dest_path = os.path.relpath(os.path.join(dirpath, filename),\n+                                            start=self.dir_prefix)\n+                if upload:\n+                    from boto.s3.key import Key","path":"gen_cert.py","position":null,"original_position":74,"commit_id":"3a53c273f513799a32f209db61d8cad711abcaad","original_commit_id":"7d19b9f0cd0415def9b8c56daebf27cd54cf2a46","user":{"login":"jarv","id":749175,"avatar_url":"https://avatars.githubusercontent.com/u/749175?","gravatar_id":"979f5e9f6b44db629337930a10388507","url":"https://api.github.com/users/jarv","html_url":"https://github.com/jarv","followers_url":"https://api.github.com/users/jarv/followers","following_url":"https://api.github.com/users/jarv/following{/other_user}","gists_url":"https://api.github.com/users/jarv/gists{/gist_id}","starred_url":"https://api.github.com/users/jarv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jarv/subscriptions","organizations_url":"https://api.github.com/users/jarv/orgs","repos_url":"https://api.github.com/users/jarv/repos","events_url":"https://api.github.com/users/jarv/events{/privacy}","received_events_url":"https://api.github.com/users/jarv/received_events","type":"User","site_admin":false},"body":"no reason, moved.","created_at":"2014-04-17T16:47:25Z","updated_at":"2014-04-17T16:47:25Z","html_url":"https://github.com/edx/read-only-certificate-code/pull/1#discussion_r11741631","pull_request_url":"https://api.github.com/repos/edx/read-only-certificate-code/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/edx/read-only-certificate-code/pulls/comments/11741631"},"html":{"href":"https://github.com/edx/read-only-certificate-code/pull/1#discussion_r11741631"},"pull_request":{"href":"https://api.github.com/repos/edx/read-only-certificate-code/pulls/1"}}}}