GitHub PullRequestReviewCommentEvent at 2014-11-05 04:13:46
Repository: eventum
Actor: danrschlosser
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/danrschlosser/eventum/pulls/comments/19854570","id":19854570,"diff_hunk":"@@ -399,6 +875,16 @@ def event_data_from_form(klass, form, creator=None):\n \n     @classmethod\n     def date_data_from_form(klass, form):\n+        \"\"\"Translate a :class:`~app.forms.CreateEventForm` or a subclass into a\n+        dictionary of date data.\n+\n+        :param form: The form to translate.\n+        :type form: :class:`~app.forms.CreateEventForm` or a subclasss\n+\n+        :returns: Date data.\n+        :rtype: dict\n+        \"\"\"\n+\n         if not form:\n             return {}","path":"app/lib/events.py","position":815,"original_position":815,"commit_id":"5143763887e89f4ed7876300287804d5cca0d50b","original_commit_id":"5143763887e89f4ed7876300287804d5cca0d50b","user":{"login":"danrschlosser","id":2433509,"avatar_url":"https://avatars.githubusercontent.com/u/2433509?v=2","gravatar_id":"","url":"https://api.github.com/users/danrschlosser","html_url":"https://github.com/danrschlosser","followers_url":"https://api.github.com/users/danrschlosser/followers","following_url":"https://api.github.com/users/danrschlosser/following{/other_user}","gists_url":"https://api.github.com/users/danrschlosser/gists{/gist_id}","starred_url":"https://api.github.com/users/danrschlosser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danrschlosser/subscriptions","organizations_url":"https://api.github.com/users/danrschlosser/orgs","repos_url":"https://api.github.com/users/danrschlosser/repos","events_url":"https://api.github.com/users/danrschlosser/events{/privacy}","received_events_url":"https://api.github.com/users/danrschlosser/received_events","type":"User","site_admin":false},"body":"I like `{}` because it's similar to `[]`. My rule is that dicts should always be declared using literals, and sets should never be declared using literals.  If you're using a set, it should be for a good reason, and so seeing `set([elem, elem, elem])` is good IMO. ","created_at":"2014-11-05T04:13:46Z","updated_at":"2014-11-05T04:13:46Z","html_url":"https://github.com/danrschlosser/eventum/pull/85#discussion_r19854570","pull_request_url":"https://api.github.com/repos/danrschlosser/eventum/pulls/85","_links":{"self":{"href":"https://api.github.com/repos/danrschlosser/eventum/pulls/comments/19854570"},"html":{"href":"https://github.com/danrschlosser/eventum/pull/85#discussion_r19854570"},"pull_request":{"href":"https://api.github.com/repos/danrschlosser/eventum/pulls/85"}}},"pull_request":{"url":"https://api.github.com/repos/danrschlosser/eventum/pulls/85","id":22577341,"html_url":"https://github.com/danrschlosser/eventum/pull/85","diff_url":"https://github.com/danrschlosser/eventum/pull/85.diff","patch_url":"https://github.com/danrschlosser/eventum/pull/85.patch","issue_url":"https://api.github.com/repos/danrschlosser/eventum/issues/85","number":85,"state":"open","locked":false,"title":"Docstring and Sphinx support","user":{"login":"danrschlosser","id":2433509,"avatar_url":"https://avatars.githubusercontent.com/u/2433509?v=2","gravatar_id":"","url":"https://api.github.com/users/danrschlosser","html_url":"https://github.com/danrschlosser","followers_url":"https://api.github.com/users/danrschlosser/followers","following_url":"https://api.github.com/users/danrschlosser/following{/other_user}","gists_url":"https://api.github.com/users/danrschlosser/gists{/gist_id}","starred_url":"https://api.github.com/users/danrschlosser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danrschlosser/subscriptions","organizations_url":"https://api.github.com/users/danrschlosser/orgs","repos_url":"https://api.github.com/users/danrschlosser/repos","events_url":"https://api.github.com/users/danrschlosser/events{/privacy}","received_events_url":"https://api.github.com/users/danrschlosser/received_events","type":"User","site_admin":false},"body":"closes #3 \r\n\r\nThis adds a ton of documentation, as well as support for Sphinx, which compiles documentation to an HTML website.\r\n\r\n![screen shot 2014-10-10 at 1 56 49 pm](https://cloud.githubusercontent.com/assets/2433509/4596762/d5e8f1ae-50a6-11e4-9ef5-64fa7fe367f8.png)\r\n","created_at":"2014-10-10T17:57:51Z","updated_at":"2014-11-05T04:13:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"50e080fa16643d1632ba57ed19dc0d510f2b4090","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/danrschlosser/eventum/pulls/85/commits","review_comments_url":"https://api.github.com/repos/danrschlosser/eventum/pulls/85/comments","review_comment_url":"https://api.github.com/repos/danrschlosser/eventum/pulls/comments/{number}","comments_url":"https://api.github.com/repos/danrschlosser/eventum/issues/85/comments","statuses_url":"https://api.github.com/repos/danrschlosser/eventum/statuses/5143763887e89f4ed7876300287804d5cca0d50b","head":{"label":"danrschlosser:docstrings","ref":"docstrings","sha":"5143763887e89f4ed7876300287804d5cca0d50b","user":{"login":"danrschlosser","id":2433509,"avatar_url":"https://avatars.githubusercontent.com/u/2433509?v=2","gravatar_id":"","url":"https://api.github.com/users/danrschlosser","html_url":"https://github.com/danrschlosser","followers_url":"https://api.github.com/users/danrschlosser/followers","following_url":"https://api.github.com/users/danrschlosser/following{/other_user}","gists_url":"https://api.github.com/users/danrschlosser/gists{/gist_id}","starred_url":"https://api.github.com/users/danrschlosser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danrschlosser/subscriptions","organizations_url":"https://api.github.com/users/danrschlosser/orgs","repos_url":"https://api.github.com/users/danrschlosser/repos","events_url":"https://api.github.com/users/danrschlosser/events{/privacy}","received_events_url":"https://api.github.com/users/danrschlosser/received_events","type":"User","site_admin":false},"repo":{"id":18424395,"name":"eventum","full_name":"danrschlosser/eventum","owner":{"login":"danrschlosser","id":2433509,"avatar_url":"https://avatars.githubusercontent.com/u/2433509?v=2","gravatar_id":"","url":"https://api.github.com/users/danrschlosser","html_url":"https://github.com/danrschlosser","followers_url":"https://api.github.com/users/danrschlosser/followers","following_url":"https://api.github.com/users/danrschlosser/following{/other_user}","gists_url":"https://api.github.com/users/danrschlosser/gists{/gist_id}","starred_url":"https://api.github.com/users/danrschlosser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danrschlosser/subscriptions","organizations_url":"https://api.github.com/users/danrschlosser/orgs","repos_url":"https://api.github.com/users/danrschlosser/repos","events_url":"https://api.github.com/users/danrschlosser/events{/privacy}","received_events_url":"https://api.github.com/users/danrschlosser/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/danrschlosser/eventum","description":"An event-driven CMS that syncs with Google Apps","fork":false,"url":"https://api.github.com/repos/danrschlosser/eventum","forks_url":"https://api.github.com/repos/danrschlosser/eventum/forks","keys_url":"https://api.github.com/repos/danrschlosser/eventum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danrschlosser/eventum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danrschlosser/eventum/teams","hooks_url":"https://api.github.com/repos/danrschlosser/eventum/hooks","issue_events_url":"https://api.github.com/repos/danrschlosser/eventum/issues/events{/number}","events_url":"https://api.github.com/repos/danrschlosser/eventum/events","assignees_url":"https://api.github.com/repos/danrschlosser/eventum/assignees{/user}","branches_url":"https://api.github.com/repos/danrschlosser/eventum/branches{/branch}","tags_url":"https://api.github.com/repos/danrschlosser/eventum/tags","blobs_url":"https://api.github.com/repos/danrschlosser/eventum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danrschlosser/eventum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danrschlosser/eventum/git/refs{/sha}","trees_url":"https://api.github.com/repos/danrschlosser/eventum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danrschlosser/eventum/statuses/{sha}","languages_url":"https://api.github.com/repos/danrschlosser/eventum/languages","stargazers_url":"https://api.github.com/repos/danrschlosser/eventum/stargazers","contributors_url":"https://api.github.com/repos/danrschlosser/eventum/contributors","subscribers_url":"https://api.github.com/repos/danrschlosser/eventum/subscribers","subscription_url":"https://api.github.com/repos/danrschlosser/eventum/subscription","commits_url":"https://api.github.com/repos/danrschlosser/eventum/commits{/sha}","git_commits_url":"https://api.github.com/repos/danrschlosser/eventum/git/commits{/sha}","comments_url":"https://api.github.com/repos/danrschlosser/eventum/comments{/number}","issue_comment_url":"https://api.github.com/repos/danrschlosser/eventum/issues/comments/{number}","contents_url":"https://api.github.com/repos/danrschlosser/eventum/contents/{+path}","compare_url":"https://api.github.com/repos/danrschlosser/eventum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danrschlosser/eventum/merges","archive_url":"https://api.github.com/repos/danrschlosser/eventum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danrschlosser/eventum/downloads","issues_url":"https://api.github.com/repos/danrschlosser/eventum/issues{/number}","pulls_url":"https://api.github.com/repos/danrschlosser/eventum/pulls{/number}","milestones_url":"https://api.github.com/repos/danrschlosser/eventum/milestones{/number}","notifications_url":"https://api.github.com/repos/danrschlosser/eventum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danrschlosser/eventum/labels{/name}","releases_url":"https://api.github.com/repos/danrschlosser/eventum/releases{/id}","created_at":"2014-04-04T01:54:28Z","updated_at":"2014-10-26T23:07:52Z","pushed_at":"2014-10-27T01:13:37Z","git_url":"git://github.com/danrschlosser/eventum.git","ssh_url":"git@github.com:danrschlosser/eventum.git","clone_url":"https://github.com/danrschlosser/eventum.git","svn_url":"https://github.com/danrschlosser/eventum","homepage":"","size":41087,"stargazers_count":7,"watchers_count":7,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":32,"forks":10,"open_issues":32,"watchers":7,"default_branch":"master"}},"base":{"label":"danrschlosser:master","ref":"master","sha":"a67743d46147146efff3a2c570bc5bc82f44f403","user":{"login":"danrschlosser","id":2433509,"avatar_url":"https://avatars.githubusercontent.com/u/2433509?v=2","gravatar_id":"","url":"https://api.github.com/users/danrschlosser","html_url":"https://github.com/danrschlosser","followers_url":"https://api.github.com/users/danrschlosser/followers","following_url":"https://api.github.com/users/danrschlosser/following{/other_user}","gists_url":"https://api.github.com/users/danrschlosser/gists{/gist_id}","starred_url":"https://api.github.com/users/danrschlosser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danrschlosser/subscriptions","organizations_url":"https://api.github.com/users/danrschlosser/orgs","repos_url":"https://api.github.com/users/danrschlosser/repos","events_url":"https://api.github.com/users/danrschlosser/events{/privacy}","received_events_url":"https://api.github.com/users/danrschlosser/received_events","type":"User","site_admin":false},"repo":{"id":18424395,"name":"eventum","full_name":"danrschlosser/eventum","owner":{"login":"danrschlosser","id":2433509,"avatar_url":"https://avatars.githubusercontent.com/u/2433509?v=2","gravatar_id":"","url":"https://api.github.com/users/danrschlosser","html_url":"https://github.com/danrschlosser","followers_url":"https://api.github.com/users/danrschlosser/followers","following_url":"https://api.github.com/users/danrschlosser/following{/other_user}","gists_url":"https://api.github.com/users/danrschlosser/gists{/gist_id}","starred_url":"https://api.github.com/users/danrschlosser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danrschlosser/subscriptions","organizations_url":"https://api.github.com/users/danrschlosser/orgs","repos_url":"https://api.github.com/users/danrschlosser/repos","events_url":"https://api.github.com/users/danrschlosser/events{/privacy}","received_events_url":"https://api.github.com/users/danrschlosser/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/danrschlosser/eventum","description":"An event-driven CMS that syncs with Google Apps","fork":false,"url":"https://api.github.com/repos/danrschlosser/eventum","forks_url":"https://api.github.com/repos/danrschlosser/eventum/forks","keys_url":"https://api.github.com/repos/danrschlosser/eventum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danrschlosser/eventum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danrschlosser/eventum/teams","hooks_url":"https://api.github.com/repos/danrschlosser/eventum/hooks","issue_events_url":"https://api.github.com/repos/danrschlosser/eventum/issues/events{/number}","events_url":"https://api.github.com/repos/danrschlosser/eventum/events","assignees_url":"https://api.github.com/repos/danrschlosser/eventum/assignees{/user}","branches_url":"https://api.github.com/repos/danrschlosser/eventum/branches{/branch}","tags_url":"https://api.github.com/repos/danrschlosser/eventum/tags","blobs_url":"https://api.github.com/repos/danrschlosser/eventum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danrschlosser/eventum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danrschlosser/eventum/git/refs{/sha}","trees_url":"https://api.github.com/repos/danrschlosser/eventum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danrschlosser/eventum/statuses/{sha}","languages_url":"https://api.github.com/repos/danrschlosser/eventum/languages","stargazers_url":"https://api.github.com/repos/danrschlosser/eventum/stargazers","contributors_url":"https://api.github.com/repos/danrschlosser/eventum/contributors","subscribers_url":"https://api.github.com/repos/danrschlosser/eventum/subscribers","subscription_url":"https://api.github.com/repos/danrschlosser/eventum/subscription","commits_url":"https://api.github.com/repos/danrschlosser/eventum/commits{/sha}","git_commits_url":"https://api.github.com/repos/danrschlosser/eventum/git/commits{/sha}","comments_url":"https://api.github.com/repos/danrschlosser/eventum/comments{/number}","issue_comment_url":"https://api.github.com/repos/danrschlosser/eventum/issues/comments/{number}","contents_url":"https://api.github.com/repos/danrschlosser/eventum/contents/{+path}","compare_url":"https://api.github.com/repos/danrschlosser/eventum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danrschlosser/eventum/merges","archive_url":"https://api.github.com/repos/danrschlosser/eventum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danrschlosser/eventum/downloads","issues_url":"https://api.github.com/repos/danrschlosser/eventum/issues{/number}","pulls_url":"https://api.github.com/repos/danrschlosser/eventum/pulls{/number}","milestones_url":"https://api.github.com/repos/danrschlosser/eventum/milestones{/number}","notifications_url":"https://api.github.com/repos/danrschlosser/eventum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danrschlosser/eventum/labels{/name}","releases_url":"https://api.github.com/repos/danrschlosser/eventum/releases{/id}","created_at":"2014-04-04T01:54:28Z","updated_at":"2014-10-26T23:07:52Z","pushed_at":"2014-10-27T01:13:37Z","git_url":"git://github.com/danrschlosser/eventum.git","ssh_url":"git@github.com:danrschlosser/eventum.git","clone_url":"https://github.com/danrschlosser/eventum.git","svn_url":"https://github.com/danrschlosser/eventum","homepage":"","size":41087,"stargazers_count":7,"watchers_count":7,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":32,"forks":10,"open_issues":32,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/danrschlosser/eventum/pulls/85"},"html":{"href":"https://github.com/danrschlosser/eventum/pull/85"},"issue":{"href":"https://api.github.com/repos/danrschlosser/eventum/issues/85"},"comments":{"href":"https://api.github.com/repos/danrschlosser/eventum/issues/85/comments"},"review_comments":{"href":"https://api.github.com/repos/danrschlosser/eventum/pulls/85/comments"},"review_comment":{"href":"https://api.github.com/repos/danrschlosser/eventum/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/danrschlosser/eventum/pulls/85/commits"},"statuses":{"href":"https://api.github.com/repos/danrschlosser/eventum/statuses/5143763887e89f4ed7876300287804d5cca0d50b"}}}}