GitHub PullRequestReviewCommentEvent at 2014-11-21 20:33:32
Repository: TrinityCore
Actor: Nyeriah
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments/20739974","id":20739974,"diff_hunk":"@@ -39,360 +43,395 @@ enum Spells\n     SPELL_TELEPORT              = 68988,\n     SPELL_FEAR                  = 68950,\n     SPELL_SOULSTORM             = 68872,\n-    SPELL_SOULSTORM_CHANNEL     = 69008,    // pre-fight\n-    SPELL_SOULSTORM_VISUAL      = 68870,    // pre-cast soulstorm\n+    SPELL_SOULSTORM_CHANNEL     = 69008,    // Pre-fight\n+    SPELL_SOULSTORM_VISUAL      = 68870,    // Pre-cast Soulstorm\n     SPELL_PURPLE_BANISH_VISUAL  = 68862     // Used by Soul Fragment (Aura)\n };\n \n-enum Events\n+enum Text\n {\n-    EVENT_MAGIC_BANE    = 1,\n-    EVENT_SHADOW_BOLT   = 2,\n-    EVENT_CORRUPT_SOUL  = 3,\n-    EVENT_SOULSTORM     = 4,\n-    EVENT_FEAR          = 5,\n+\tSAY_AGGRO\t\t            = 0,\n+\tSAY_KILL\t\t            = 1,\n+\tSAY_SOUL_STORM\t\t        = 2,\n+\tSAY_CORRUPT_SOUL\t        = 3\n };\n \n-enum CombatPhases\n+enum Phases\n {\n-    PHASE_1 = 1,\n-    PHASE_2 = 2\n+    PHASE_1\t\t\t            = 1,\n+    PHASE_2\t\t\t            = 2\n };\n \n class boss_bronjahm : public CreatureScript\n {\n-    public:\n-        boss_bronjahm() : CreatureScript(\"boss_bronjahm\") { }\n+public:\n+    boss_bronjahm() : CreatureScript(\"boss_bronjahm\") { }\n \n-        struct boss_bronjahmAI : public BossAI\n+    struct boss_bronjahmAI : public BossAI\n+    {\n+        boss_bronjahmAI(Creature* creature) : BossAI(creature, DATA_BRONJAHM)\n         {\n-            boss_bronjahmAI(Creature* creature) : BossAI(creature, DATA_BRONJAHM)\n-            {\n-                DoCast(me, SPELL_SOULSTORM_CHANNEL, true);\n-            }\n+            DoCast(me, SPELL_SOULSTORM_CHANNEL, true);\n+        }\n \n-            void Reset() override\n-            {\n-                events.Reset();\n-                events.SetPhase(PHASE_1);\n-                events.ScheduleEvent(EVENT_SHADOW_BOLT, 2000);\n-                events.ScheduleEvent(EVENT_MAGIC_BANE, urand(8000, 20000));\n-                events.ScheduleEvent(EVENT_CORRUPT_SOUL, urand(25000, 35000), 0, PHASE_1);\n+        void Reset() override\n+        {\n+            _Reset();\n+            events.Reset();\n+            events.SetPhase(PHASE_1);\n+            events.ScheduleEvent(EVENT_SHADOW_BOLT, 2000);\n+            events.ScheduleEvent(EVENT_MAGIC_BANE, urand(8000, 20000), 0, PHASE_1);\n+            events.ScheduleEvent(EVENT_CORRUPT_SOUL, urand(25000, 35000), 0, PHASE_1);\n+            _soulFragmentsSpawned = 0;\n+        }\n \n-                instance->SetBossState(DATA_BRONJAHM, NOT_STARTED);\n-            }\n+\t    void EnterCombat(Unit* /*who*/) override\n+\t    {\n+\t\t    _EnterCombat();\n+\t\t    me->RemoveAurasDueToSpell(SPELL_SOULSTORM_CHANNEL);\n+\t\t    Talk(SAY_AGGRO);\n+\t    }\n \n-           void JustReachedHome() override\n-           {\n-               DoCast(me, SPELL_SOULSTORM_CHANNEL, true);\n-           }\n+\t    void JustDied(Unit* /*killer*/) override\n+\t    {\n+\t\t    _JustDied();\n+\t\t    sCreatureTextMgr->SendSound(me, SOUND_DEATH, CHAT_MSG_MONSTER_YELL, 0, TEXT_RANGE_NORMAL, TEAM_OTHER, false);\n+\t    }\n \n-            void EnterCombat(Unit* /*who*/) override\n-            {\n-                Talk(SAY_AGGRO);\n-                me->RemoveAurasDueToSpell(SPELL_SOULSTORM_CHANNEL);\n+        void JustReachedHome() override\n+        {\n+\t\t    _JustReachedHome();","path":"src/server/scripts/Northrend/FrozenHalls/ForgeOfSouls/boss_bronjahm.cpp","position":122,"original_position":122,"commit_id":"0da6913d333eebf001b90ad86773197d2c1e88fb","original_commit_id":"0da6913d333eebf001b90ad86773197d2c1e88fb","user":{"login":"Nyeriah","id":2879479,"avatar_url":"https://avatars.githubusercontent.com/u/2879479?v=3","gravatar_id":"","url":"https://api.github.com/users/Nyeriah","html_url":"https://github.com/Nyeriah","followers_url":"https://api.github.com/users/Nyeriah/followers","following_url":"https://api.github.com/users/Nyeriah/following{/other_user}","gists_url":"https://api.github.com/users/Nyeriah/gists{/gist_id}","starred_url":"https://api.github.com/users/Nyeriah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nyeriah/subscriptions","organizations_url":"https://api.github.com/users/Nyeriah/orgs","repos_url":"https://api.github.com/users/Nyeriah/repos","events_url":"https://api.github.com/users/Nyeriah/events{/privacy}","received_events_url":"https://api.github.com/users/Nyeriah/received_events","type":"User","site_admin":false},"body":"This line has both spaces and tabs","created_at":"2014-11-21T20:33:32Z","updated_at":"2014-11-21T20:33:32Z","html_url":"https://github.com/TrinityCore/TrinityCore/pull/13606#discussion_r20739974","pull_request_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/13606","_links":{"self":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments/20739974"},"html":{"href":"https://github.com/TrinityCore/TrinityCore/pull/13606#discussion_r20739974"},"pull_request":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/13606"}}},"pull_request":{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/13606","id":24859891,"html_url":"https://github.com/TrinityCore/TrinityCore/pull/13606","diff_url":"https://github.com/TrinityCore/TrinityCore/pull/13606.diff","patch_url":"https://github.com/TrinityCore/TrinityCore/pull/13606.patch","issue_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/13606","number":13606,"state":"open","locked":false,"title":"fixed bronjahm and fixed Soul Power achievement","user":{"login":"Grimton1337","id":9355210,"avatar_url":"https://avatars.githubusercontent.com/u/9355210?v=3","gravatar_id":"","url":"https://api.github.com/users/Grimton1337","html_url":"https://github.com/Grimton1337","followers_url":"https://api.github.com/users/Grimton1337/followers","following_url":"https://api.github.com/users/Grimton1337/following{/other_user}","gists_url":"https://api.github.com/users/Grimton1337/gists{/gist_id}","starred_url":"https://api.github.com/users/Grimton1337/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Grimton1337/subscriptions","organizations_url":"https://api.github.com/users/Grimton1337/orgs","repos_url":"https://api.github.com/users/Grimton1337/repos","events_url":"https://api.github.com/users/Grimton1337/events{/privacy}","received_events_url":"https://api.github.com/users/Grimton1337/received_events","type":"User","site_admin":false},"body":"Did it correctly now, sorry for earlier.","created_at":"2014-11-21T18:42:48Z","updated_at":"2014-11-21T20:33:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e3bd1ddebf76a4af293b888bae25ee761cb41d2d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/13606/commits","review_comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/13606/comments","review_comment_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments/{number}","comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/13606/comments","statuses_url":"https://api.github.com/repos/TrinityCore/TrinityCore/statuses/0da6913d333eebf001b90ad86773197d2c1e88fb","head":{"label":"Grimton1337:fixes","ref":"fixes","sha":"0da6913d333eebf001b90ad86773197d2c1e88fb","user":{"login":"Grimton1337","id":9355210,"avatar_url":"https://avatars.githubusercontent.com/u/9355210?v=3","gravatar_id":"","url":"https://api.github.com/users/Grimton1337","html_url":"https://github.com/Grimton1337","followers_url":"https://api.github.com/users/Grimton1337/followers","following_url":"https://api.github.com/users/Grimton1337/following{/other_user}","gists_url":"https://api.github.com/users/Grimton1337/gists{/gist_id}","starred_url":"https://api.github.com/users/Grimton1337/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Grimton1337/subscriptions","organizations_url":"https://api.github.com/users/Grimton1337/orgs","repos_url":"https://api.github.com/users/Grimton1337/repos","events_url":"https://api.github.com/users/Grimton1337/events{/privacy}","received_events_url":"https://api.github.com/users/Grimton1337/received_events","type":"User","site_admin":false},"repo":{"id":26933286,"name":"TrinityCore","full_name":"Grimton1337/TrinityCore","owner":{"login":"Grimton1337","id":9355210,"avatar_url":"https://avatars.githubusercontent.com/u/9355210?v=3","gravatar_id":"","url":"https://api.github.com/users/Grimton1337","html_url":"https://github.com/Grimton1337","followers_url":"https://api.github.com/users/Grimton1337/followers","following_url":"https://api.github.com/users/Grimton1337/following{/other_user}","gists_url":"https://api.github.com/users/Grimton1337/gists{/gist_id}","starred_url":"https://api.github.com/users/Grimton1337/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Grimton1337/subscriptions","organizations_url":"https://api.github.com/users/Grimton1337/orgs","repos_url":"https://api.github.com/users/Grimton1337/repos","events_url":"https://api.github.com/users/Grimton1337/events{/privacy}","received_events_url":"https://api.github.com/users/Grimton1337/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Grimton1337/TrinityCore","description":"TrinityCore Open Source MMO Framework","fork":true,"url":"https://api.github.com/repos/Grimton1337/TrinityCore","forks_url":"https://api.github.com/repos/Grimton1337/TrinityCore/forks","keys_url":"https://api.github.com/repos/Grimton1337/TrinityCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Grimton1337/TrinityCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Grimton1337/TrinityCore/teams","hooks_url":"https://api.github.com/repos/Grimton1337/TrinityCore/hooks","issue_events_url":"https://api.github.com/repos/Grimton1337/TrinityCore/issues/events{/number}","events_url":"https://api.github.com/repos/Grimton1337/TrinityCore/events","assignees_url":"https://api.github.com/repos/Grimton1337/TrinityCore/assignees{/user}","branches_url":"https://api.github.com/repos/Grimton1337/TrinityCore/branches{/branch}","tags_url":"https://api.github.com/repos/Grimton1337/TrinityCore/tags","blobs_url":"https://api.github.com/repos/Grimton1337/TrinityCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Grimton1337/TrinityCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Grimton1337/TrinityCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/Grimton1337/TrinityCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Grimton1337/TrinityCore/statuses/{sha}","languages_url":"https://api.github.com/repos/Grimton1337/TrinityCore/languages","stargazers_url":"https://api.github.com/repos/Grimton1337/TrinityCore/stargazers","contributors_url":"https://api.github.com/repos/Grimton1337/TrinityCore/contributors","subscribers_url":"https://api.github.com/repos/Grimton1337/TrinityCore/subscribers","subscription_url":"https://api.github.com/repos/Grimton1337/TrinityCore/subscription","commits_url":"https://api.github.com/repos/Grimton1337/TrinityCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/Grimton1337/TrinityCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/Grimton1337/TrinityCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/Grimton1337/TrinityCore/issues/comments/{number}","contents_url":"https://api.github.com/repos/Grimton1337/TrinityCore/contents/{+path}","compare_url":"https://api.github.com/repos/Grimton1337/TrinityCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Grimton1337/TrinityCore/merges","archive_url":"https://api.github.com/repos/Grimton1337/TrinityCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Grimton1337/TrinityCore/downloads","issues_url":"https://api.github.com/repos/Grimton1337/TrinityCore/issues{/number}","pulls_url":"https://api.github.com/repos/Grimton1337/TrinityCore/pulls{/number}","milestones_url":"https://api.github.com/repos/Grimton1337/TrinityCore/milestones{/number}","notifications_url":"https://api.github.com/repos/Grimton1337/TrinityCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Grimton1337/TrinityCore/labels{/name}","releases_url":"https://api.github.com/repos/Grimton1337/TrinityCore/releases{/id}","created_at":"2014-11-20T21:43:05Z","updated_at":"2014-11-20T21:43:30Z","pushed_at":"2014-11-21T19:42:34Z","git_url":"git://github.com/Grimton1337/TrinityCore.git","ssh_url":"git@github.com:Grimton1337/TrinityCore.git","clone_url":"https://github.com/Grimton1337/TrinityCore.git","svn_url":"https://github.com/Grimton1337/TrinityCore","homepage":"http://www.trinitycore.org","size":722144,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"6.x"}},"base":{"label":"TrinityCore:3.3.5","ref":"3.3.5","sha":"e778ee14163a4989b90025f4d83f897a03ae183d","user":{"login":"TrinityCore","id":539602,"avatar_url":"https://avatars.githubusercontent.com/u/539602?v=3","gravatar_id":"","url":"https://api.github.com/users/TrinityCore","html_url":"https://github.com/TrinityCore","followers_url":"https://api.github.com/users/TrinityCore/followers","following_url":"https://api.github.com/users/TrinityCore/following{/other_user}","gists_url":"https://api.github.com/users/TrinityCore/gists{/gist_id}","starred_url":"https://api.github.com/users/TrinityCore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TrinityCore/subscriptions","organizations_url":"https://api.github.com/users/TrinityCore/orgs","repos_url":"https://api.github.com/users/TrinityCore/repos","events_url":"https://api.github.com/users/TrinityCore/events{/privacy}","received_events_url":"https://api.github.com/users/TrinityCore/received_events","type":"Organization","site_admin":false},"repo":{"id":1204412,"name":"TrinityCore","full_name":"TrinityCore/TrinityCore","owner":{"login":"TrinityCore","id":539602,"avatar_url":"https://avatars.githubusercontent.com/u/539602?v=3","gravatar_id":"","url":"https://api.github.com/users/TrinityCore","html_url":"https://github.com/TrinityCore","followers_url":"https://api.github.com/users/TrinityCore/followers","following_url":"https://api.github.com/users/TrinityCore/following{/other_user}","gists_url":"https://api.github.com/users/TrinityCore/gists{/gist_id}","starred_url":"https://api.github.com/users/TrinityCore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TrinityCore/subscriptions","organizations_url":"https://api.github.com/users/TrinityCore/orgs","repos_url":"https://api.github.com/users/TrinityCore/repos","events_url":"https://api.github.com/users/TrinityCore/events{/privacy}","received_events_url":"https://api.github.com/users/TrinityCore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TrinityCore/TrinityCore","description":"TrinityCore Open Source MMO Framework","fork":false,"url":"https://api.github.com/repos/TrinityCore/TrinityCore","forks_url":"https://api.github.com/repos/TrinityCore/TrinityCore/forks","keys_url":"https://api.github.com/repos/TrinityCore/TrinityCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TrinityCore/TrinityCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TrinityCore/TrinityCore/teams","hooks_url":"https://api.github.com/repos/TrinityCore/TrinityCore/hooks","issue_events_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/events{/number}","events_url":"https://api.github.com/repos/TrinityCore/TrinityCore/events","assignees_url":"https://api.github.com/repos/TrinityCore/TrinityCore/assignees{/user}","branches_url":"https://api.github.com/repos/TrinityCore/TrinityCore/branches{/branch}","tags_url":"https://api.github.com/repos/TrinityCore/TrinityCore/tags","blobs_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TrinityCore/TrinityCore/statuses/{sha}","languages_url":"https://api.github.com/repos/TrinityCore/TrinityCore/languages","stargazers_url":"https://api.github.com/repos/TrinityCore/TrinityCore/stargazers","contributors_url":"https://api.github.com/repos/TrinityCore/TrinityCore/contributors","subscribers_url":"https://api.github.com/repos/TrinityCore/TrinityCore/subscribers","subscription_url":"https://api.github.com/repos/TrinityCore/TrinityCore/subscription","commits_url":"https://api.github.com/repos/TrinityCore/TrinityCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/comments/{number}","contents_url":"https://api.github.com/repos/TrinityCore/TrinityCore/contents/{+path}","compare_url":"https://api.github.com/repos/TrinityCore/TrinityCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TrinityCore/TrinityCore/merges","archive_url":"https://api.github.com/repos/TrinityCore/TrinityCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TrinityCore/TrinityCore/downloads","issues_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues{/number}","pulls_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls{/number}","milestones_url":"https://api.github.com/repos/TrinityCore/TrinityCore/milestones{/number}","notifications_url":"https://api.github.com/repos/TrinityCore/TrinityCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TrinityCore/TrinityCore/labels{/name}","releases_url":"https://api.github.com/repos/TrinityCore/TrinityCore/releases{/id}","created_at":"2010-12-28T23:40:07Z","updated_at":"2014-11-21T17:57:36Z","pushed_at":"2014-11-21T17:57:36Z","git_url":"git://github.com/TrinityCore/TrinityCore.git","ssh_url":"git@github.com:TrinityCore/TrinityCore.git","clone_url":"https://github.com/TrinityCore/TrinityCore.git","svn_url":"https://github.com/TrinityCore/TrinityCore","homepage":"http://www.trinitycore.org","size":722144,"stargazers_count":2624,"watchers_count":2624,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2664,"mirror_url":null,"open_issues_count":1286,"forks":2664,"open_issues":1286,"watchers":2624,"default_branch":"6.x"}},"_links":{"self":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/13606"},"html":{"href":"https://github.com/TrinityCore/TrinityCore/pull/13606"},"issue":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/13606"},"comments":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/13606/comments"},"review_comments":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/13606/comments"},"review_comment":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/13606/commits"},"statuses":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/statuses/0da6913d333eebf001b90ad86773197d2c1e88fb"}}}}