GitHub PullRequestReviewCommentEvent at 2014-01-20 22:42:30
Repository: easybuild-framework
Actor: boegel
Payload: {"comment":{"url":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls/comments/9021216","id":9021216,"diff_hunk":"@@ -103,33 +109,50 @@ def get_config_dict(self, version=None, toolchain_name=None, toolchain_version=N\n             # check for default version\n             if 'default_version' in cov.default:\n                 version = cov.default['default_version']\n-                self.log.warning('get_config_dict: no version specified, using default version %s' % version)\n+                self.log.info(\"no software version specified, using default version '%s'\" % version)\n             else:\n-                self.log.error('get_config_dict: no version specified, no default version found')\n+                self.log.error(\"no software version specified, no default version found\")\n+        else:\n+            self.log.debug(\"Using specified software version %s\" % version)\n \n         if toolchain_name is None:\n             # check for default toolchain\n             if 'default_toolchain' in cov.default:\n                 toolchain = cov.default['default_toolchain']\n                 toolchain_name = toolchain.tc_name\n-                self.log.warning('get_config_dict: no toolchain_name specified, using default %s' % toolchain_name)\n+                self.log.info(\"no toolchain name specified, using default '%s'\" % toolchain_name)\n+                if toolchain_version is None:\n+                    toolchain_version = toolchain.get_version_str()\n+                    self.log.info(\"no toolchain version specified, using default '%s'\" % toolchain_version)\n             else:\n-                self.log.error('get_config_dict: no toolchain_name specified, no default toolchain found')\n+                self.log.error(\"no toolchain name specified, no default toolchain found\")\n+        else:\n+            self.log.debug(\"Using specified toolchain name %s\" % toolchain_name)\n+            if toolchain_version is None:\n+                self.log.error(\"Toolchain specification incomplete: name %s provided, but no version\" % toolchain_name)\n+\n+        # add version/toolchain specifications to config dict\n+        if isinstance(version, VersionOperator):\n+            version = version.get_version_str()\n+        if isinstance(toolchain_version, ToolchainVersionOperator):\n+            toolchain_version = toolchain_version.get_version_str()\n+\n+        cfg.update({\n+            'version': version,\n+            'toolchain': {'name': toolchain_name, 'version': toolchain_version},\n+        })\n+        self.log.debug(\"Config dict including version/toolchain specs: %s\" % cfg)\n \n         # toolchain name is known, remove all others toolchains from parsed easyconfig before we continue\n         # this also performs some validation, and checks for conflicts between section markers\n-        self.log.debug(\"full parsed configobj (before filtering): %s\" % cov.sections)\n+        self.log.debug(\"sections for full parsed configobj: %s\" % cov.sections)\n+        #toolchain_name = 'goolf'","path":"easybuild/framework/easyconfig/format/two.py","position":81,"original_position":81,"commit_id":"fff443e397d1058fe8791294b2ed912c80069d85","original_commit_id":"fff443e397d1058fe8791294b2ed912c80069d85","user":{"login":"boegel","id":620876,"avatar_url":"https://gravatar.com/avatar/93efe8c67147791f743923763ff6197d?d=https%3A%2F%2Fidenticons.github.com%2F424deccd27782ad35ea941ab2a0c04bc.png&r=x","gravatar_id":"93efe8c67147791f743923763ff6197d","url":"https://api.github.com/users/boegel","html_url":"https://github.com/boegel","followers_url":"https://api.github.com/users/boegel/followers","following_url":"https://api.github.com/users/boegel/following{/other_user}","gists_url":"https://api.github.com/users/boegel/gists{/gist_id}","starred_url":"https://api.github.com/users/boegel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boegel/subscriptions","organizations_url":"https://api.github.com/users/boegel/orgs","repos_url":"https://api.github.com/users/boegel/repos","events_url":"https://api.github.com/users/boegel/events{/privacy}","received_events_url":"https://api.github.com/users/boegel/received_events","type":"User","site_admin":false},"body":"ok","created_at":"2014-01-20T22:42:30Z","updated_at":"2014-01-20T22:42:30Z","html_url":"https://github.com/hpcugent/easybuild-framework/pull/810#discussion_r9021216","pull_request_url":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls/810","_links":{"self":{"href":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls/comments/9021216"},"html":{"href":"https://github.com/hpcugent/easybuild-framework/pull/810#discussion_r9021216"},"pull_request":{"href":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls/810"}}}}