GitHub PullRequestReviewCommentEvent at 2014-09-03 16:59:02
Repository: infinispan
Actor: tristantarrant
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/infinispan/infinispan/pulls/comments/17063181","id":17063181,"diff_hunk":"@@ -0,0 +1,242 @@\n+package org.infinispan.query.indexmanager;\n+\n+import java.util.List;\n+import java.util.concurrent.atomic.AtomicInteger;\n+\n+import net.jcip.annotations.GuardedBy;\n+\n+import org.infinispan.factories.ComponentRegistry;\n+import org.infinispan.notifications.Listener;\n+import org.infinispan.notifications.cachemanagerlistener.annotation.ViewChanged;\n+import org.infinispan.notifications.cachemanagerlistener.event.ViewChangedEvent;\n+import org.infinispan.query.logging.Log;\n+import org.infinispan.remoting.rpc.RpcManager;\n+import org.infinispan.remoting.transport.Address;\n+import org.infinispan.util.logging.LogFactory;\n+\n+/**\n+ * Manages the current state of being a \"master\" node or a node delegating index\n+ * update operations to other nodes.\n+ * In a static cluster this would have been a boolean state, but a state machine\n+ * is modelled here to cope with transitions between:\n+ *\n+ * Initialization of a node - still not having enough information on the cluster\n+ * Becoming a master because of previous master failure / shutdown\n+ * Forfaiting the master role (useful for cluster merges)\n+ *\n+ * The transition to become a master goes via differen phases, and at each state\n+ * the process is reversible. So for example if operations have been put on hold\n+ * while the node is being upgraded, but then the master election is moved to a\n+ * different node quickly (cluster startup scenario), the buffered operations\n+ * will be forwarded to the last backend.\n+ * A node being forwarded update operations but not being the master anymore,\n+ * will re-forward the payload to the new master: stability by induction.\n+ *\n+ * The solution is rather poor at managing cluster Merge operations, but we\n+ * need to build on upcoming functionality from Infinispan core for that; for\n+ * example the index content wouldn't be consistent either so one would likely\n+ * need to wipe the index and rebuild it.\n+ * Also we're dealing with the inherent limitation of a \"cluster wide lock\"\n+ * concept not being compatible with sub-groups of nodes in which a new lead\n+ * might be elected and a lock per group might have been created.\n+ *\n+ * A lock cleanup is not too aggressive: in case a stale lock is detected,\n+ * scheduled work is postponed. This implies that in such situations in which\n+ * a stale lock needs to be cleaned up, index operations might not be visible\n+ * to the transaction committer.\n+ * I've chosen for this option as the lesser evil vs. blocking incoming RPCs,\n+ * although if the buffer for postponed operations gets filled too quickly,\n+ * we'll both speed up the lock acquisition and apply backpressure to the clients.\n+ *\n+ * @author Sanne Grinovero <sanne@hibernate.org> (C) 2014 Red Hat Inc.\n+ * @since 7.0\n+ */\n+@Listener\n+final class ClusteredSwitchingBackend implements LazyInitializableBackend {\n+\n+   private static final Log log = LogFactory.getLog(ClusteredSwitchingBackend.class, Log.class);\n+\n+   /**\n+    * Each attempt introduces approximately 10 seconds delay, and waiting\n+    * more should never be reasonable as it means we're handling a cluster merge.\n+    * Infinispan doesn't currently handle merges, so in that case the index\n+    * is probably corrupted: no point in keeping the lock either.\n+    * The only reason to wait for it is to handle very brief merges caused by\n+    * occasional high load, or in case users are writing directly to the index.\n+    * Sustained direct writes to the index should not be done either, at least\n+    * not without disabling index exclusivity which implies the lock will be\n+    * available in a shorter time.\n+    */\n+   private static final int MAX_LOCK_ACQUISITION_ATTEMPTS = 2;\n+\n+   private final Address localAddress;\n+   private final RpcManager rpcManager;\n+   private final LocalBackendFactory factory;\n+   private final IndexLockController indexlock;\n+\n+   private final String indexName;\n+   private final String cacheName;\n+\n+   /**\n+    * Monotonically increasing view identification sequence:\n+    * we use it to ignore stale events.\n+    * FIXME: why are ids just an int? Is that going to be enough?\n+    */\n+   private final AtomicInteger lastSeenViewId = new AtomicInteger(-1);\n+\n+   private volatile Address currentMaster;\n+   private volatile IndexingBackend currentBackend;\n+\n+   @GuardedBy(\"this\")\n+   private boolean initialized = false;\n+\n+   @GuardedBy(\"this\")\n+   private int masterLockAcquisitionAttempts = 0;\n+\n+   ClusteredSwitchingBackend(ComponentRegistry componentsRegistry, String indexName, LocalBackendFactory factory, IndexLockController indexlock) {\n+      this.indexName = indexName;\n+      this.factory = factory;\n+      this.indexlock = indexlock;\n+      this.rpcManager = componentsRegistry.getComponent(RpcManager.class);\n+      this.cacheName = componentsRegistry.getCacheName();\n+      if (rpcManager == null) {\n+         throw new IllegalStateException(\"This Cache is not clustered! The switching backend should not be used for local caches\");\n+      }\n+      this.localAddress = rpcManager.getAddress();\n+      this.currentBackend = new LazyInitializingBackend(this);\n+   }\n+\n+   @ViewChanged\n+   public void viewChanged(final ViewChangedEvent e) {\n+      final int currentViewId = lastSeenViewId.get();\n+      final int viewId = e.getViewId();\n+      if (viewId > currentViewId) {\n+         if (lastSeenViewId.compareAndSet(currentViewId, viewId)) {\n+            applyViewChangedEvent(e);\n+         }\n+      }\n+   }\n+\n+   @Override\n+   public void initialize() {\n+      // we use lazyInitialize() to postpone operations to last minute:\n+      // avoids unnecessary elections while the initial cluster is formed.\n+   }\n+\n+   @Override\n+   public synchronized void lazyInitialize() {\n+      if (initialized) {\n+         return;\n+      }\n+      this.initialized = true;\n+      final List<Address> members = rpcManager.getMembers();\n+      assert members != null;\n+      assert members.size() > 0;\n+      assert members.get(0) != null;\n+      final Address initialMaster = members.get(0);\n+      lastSeenViewId.set(rpcManager.getTransport().getViewId());\n+      if (thisIsNewMaster(initialMaster)) {\n+         acquireControlStart();\n+      }\n+      else {\n+         updateRoutingToNewRemote(initialMaster);\n+      }\n+   }\n+\n+   private synchronized void applyViewChangedEvent(ViewChangedEvent e) {\n+      assert e != null;\n+      assert e.getNewMembers().size() > 0;\n+      assert e.getNewMembers().get(0) != null;\n+      final Address newmaster = e.getNewMembers().get(0);\n+      if (masterDidChange(newmaster)) {\n+         if (thisIsMaster()) {\n+            forfeitControl(newmaster);\n+         }\n+         else if (thisIsNewMaster(newmaster)) {\n+            acquireControlStart();\n+         }\n+         else {\n+            updateRoutingToNewRemote(newmaster);\n+         }\n+      }\n+   }\n+\n+   private boolean thisIsNewMaster(Address newmaster) {\n+      return localAddress.equals(newmaster);\n+   }\n+\n+   private boolean thisIsMaster() {\n+      return localAddress.equals(currentMaster);\n+   }\n+\n+   private boolean masterDidChange(final Address newmaster) {\n+      if (newmaster == null) {\n+         return false;\n+      }\n+      else {\n+         return ! newmaster.equals(currentMaster);\n+      }\n+   }\n+\n+   private void updateRoutingToNewRemote(final Address newMaster) {\n+      final IndexingBackend newBackend = new RemoteIndexingBackend(cacheName, rpcManager, indexName, newMaster);\n+      swapNewBackendIn(newBackend, newMaster);\n+   }\n+\n+   private void acquireControlStart() {\n+      final IndexingBackend backend = new LockAcquiringBackend(this);\n+      this.masterLockAcquisitionAttempts = 0;\n+      swapNewBackendIn(backend, localAddress);\n+   }\n+\n+   private void forfeitControl(Address newMasterAddress) {\n+      final IndexingBackend newBackend = new RemoteIndexingBackend(cacheName, rpcManager, indexName, newMasterAddress);\n+      swapNewBackendIn(newBackend, newMasterAddress);\n+   }\n+\n+   private void swapNewBackendIn(IndexingBackend newBackend, Address newMasterAddress) {\n+      final IndexingBackend oldBackend = currentBackend;\n+      log.tracev(\"Swapping from backend {0} to {1}'\", oldBackend, newBackend);\n+      this.currentBackend = newBackend;\n+      this.currentMaster = newMasterAddress;\n+      closeBackend(oldBackend, currentBackend);\n+   }\n+\n+   @Override\n+   public void shutdown() {\n+      closeBackend(currentBackend, null);\n+      this.currentBackend = null;\n+   }\n+\n+   @Override\n+   public IndexingBackend getCurrentIndexingBackend() {\n+      return currentBackend;\n+   }\n+\n+   private static void closeBackend(final IndexingBackend oldOne, final IndexingBackend replacement) {\n+      if (oldOne != null) {\n+         oldOne.flushAndClose(replacement);\n+      }\n+   }\n+\n+   @Override\n+   public synchronized boolean attemptUpgrade() {\n+      if (masterLockAcquisitionAttempts >= MAX_LOCK_ACQUISITION_ATTEMPTS) {\n+         indexlock.forceLockClear();\n+         swapNewBackendIn(factory.createLocalIndexingBackend(), localAddress);\n+         return true;\n+      }\n+      else {\n+         masterLockAcquisitionAttempts++;\n+      }\n+      if (indexlock.waitForAvailability()) {\n+         swapNewBackendIn(factory.createLocalIndexingBackend(), localAddress);\n+         return true;\n+      }\n+      else {","path":"query/src/main/java/org/infinispan/query/indexmanager/ClusteredSwitchingBackend.java","position":236,"original_position":236,"commit_id":"c8887ae4d5bff9409c072337be3bcecf0b1f11e4","original_commit_id":"c8887ae4d5bff9409c072337be3bcecf0b1f11e4","user":{"login":"tristantarrant","id":392478,"avatar_url":"https://avatars.githubusercontent.com/u/392478?v=2","gravatar_id":"a0bbac2ddda65366d24691b7d3daa735","url":"https://api.github.com/users/tristantarrant","html_url":"https://github.com/tristantarrant","followers_url":"https://api.github.com/users/tristantarrant/followers","following_url":"https://api.github.com/users/tristantarrant/following{/other_user}","gists_url":"https://api.github.com/users/tristantarrant/gists{/gist_id}","starred_url":"https://api.github.com/users/tristantarrant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tristantarrant/subscriptions","organizations_url":"https://api.github.com/users/tristantarrant/orgs","repos_url":"https://api.github.com/users/tristantarrant/repos","events_url":"https://api.github.com/users/tristantarrant/events{/privacy}","received_events_url":"https://api.github.com/users/tristantarrant/received_events","type":"User","site_admin":false},"body":"all of our code seems to use the else/catch/finally on the same line as the closing brace\r\n\r\n} else {\r\n\r\ninstead of\r\n}\r\nelse {","created_at":"2014-09-03T16:59:02Z","updated_at":"2014-09-03T16:59:02Z","html_url":"https://github.com/infinispan/infinispan/pull/2839#discussion_r17063181","pull_request_url":"https://api.github.com/repos/infinispan/infinispan/pulls/2839","_links":{"self":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/comments/17063181"},"html":{"href":"https://github.com/infinispan/infinispan/pull/2839#discussion_r17063181"},"pull_request":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/2839"}}},"pull_request":{"url":"https://api.github.com/repos/infinispan/infinispan/pulls/2839","id":20674996,"html_url":"https://github.com/infinispan/infinispan/pull/2839","diff_url":"https://github.com/infinispan/infinispan/pull/2839.diff","patch_url":"https://github.com/infinispan/infinispan/pull/2839.patch","issue_url":"https://api.github.com/repos/infinispan/infinispan/issues/2839","number":2839,"state":"open","locked":false,"title":"Ispn 4599","user":{"login":"Sanne","id":42573,"avatar_url":"https://avatars.githubusercontent.com/u/42573?v=2","gravatar_id":"6886c741845f42bd459dc5dade7b1fc2","url":"https://api.github.com/users/Sanne","html_url":"https://github.com/Sanne","followers_url":"https://api.github.com/users/Sanne/followers","following_url":"https://api.github.com/users/Sanne/following{/other_user}","gists_url":"https://api.github.com/users/Sanne/gists{/gist_id}","starred_url":"https://api.github.com/users/Sanne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sanne/subscriptions","organizations_url":"https://api.github.com/users/Sanne/orgs","repos_url":"https://api.github.com/users/Sanne/repos","events_url":"https://api.github.com/users/Sanne/events{/privacy}","received_events_url":"https://api.github.com/users/Sanne/received_events","type":"User","site_admin":false},"body":"Contains fixes for:\r\n - https://issues.jboss.org/browse/ISPN-2727\r\n - https://issues.jboss.org/browse/ISPN-4048\r\n - https://issues.jboss.org/browse/ISPN-4165\r\n - https://issues.jboss.org/browse/ISPN-4186\r\n - https://issues.jboss.org/browse/ISPN-4599\r\n\r\n(Ultimately all caused by ISPN-4599)","created_at":"2014-09-03T13:05:21Z","updated_at":"2014-09-03T16:59:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"be91d4fd3c457c10ac186ee037d70d5c5657822e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/infinispan/infinispan/pulls/2839/commits","review_comments_url":"https://api.github.com/repos/infinispan/infinispan/pulls/2839/comments","review_comment_url":"https://api.github.com/repos/infinispan/infinispan/pulls/comments/{number}","comments_url":"https://api.github.com/repos/infinispan/infinispan/issues/2839/comments","statuses_url":"https://api.github.com/repos/infinispan/infinispan/statuses/c8887ae4d5bff9409c072337be3bcecf0b1f11e4","head":{"label":"Sanne:ISPN-4599","ref":"ISPN-4599","sha":"c8887ae4d5bff9409c072337be3bcecf0b1f11e4","user":{"login":"Sanne","id":42573,"avatar_url":"https://avatars.githubusercontent.com/u/42573?v=2","gravatar_id":"6886c741845f42bd459dc5dade7b1fc2","url":"https://api.github.com/users/Sanne","html_url":"https://github.com/Sanne","followers_url":"https://api.github.com/users/Sanne/followers","following_url":"https://api.github.com/users/Sanne/following{/other_user}","gists_url":"https://api.github.com/users/Sanne/gists{/gist_id}","starred_url":"https://api.github.com/users/Sanne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sanne/subscriptions","organizations_url":"https://api.github.com/users/Sanne/orgs","repos_url":"https://api.github.com/users/Sanne/repos","events_url":"https://api.github.com/users/Sanne/events{/privacy}","received_events_url":"https://api.github.com/users/Sanne/received_events","type":"User","site_admin":false},"repo":{"id":1091951,"name":"infinispan","full_name":"Sanne/infinispan","owner":{"login":"Sanne","id":42573,"avatar_url":"https://avatars.githubusercontent.com/u/42573?v=2","gravatar_id":"6886c741845f42bd459dc5dade7b1fc2","url":"https://api.github.com/users/Sanne","html_url":"https://github.com/Sanne","followers_url":"https://api.github.com/users/Sanne/followers","following_url":"https://api.github.com/users/Sanne/following{/other_user}","gists_url":"https://api.github.com/users/Sanne/gists{/gist_id}","starred_url":"https://api.github.com/users/Sanne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sanne/subscriptions","organizations_url":"https://api.github.com/users/Sanne/orgs","repos_url":"https://api.github.com/users/Sanne/repos","events_url":"https://api.github.com/users/Sanne/events{/privacy}","received_events_url":"https://api.github.com/users/Sanne/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Sanne/infinispan","description":"Infinispan is an open source data grid platform and highly scalable NoSQL cloud data store.","fork":true,"url":"https://api.github.com/repos/Sanne/infinispan","forks_url":"https://api.github.com/repos/Sanne/infinispan/forks","keys_url":"https://api.github.com/repos/Sanne/infinispan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Sanne/infinispan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Sanne/infinispan/teams","hooks_url":"https://api.github.com/repos/Sanne/infinispan/hooks","issue_events_url":"https://api.github.com/repos/Sanne/infinispan/issues/events{/number}","events_url":"https://api.github.com/repos/Sanne/infinispan/events","assignees_url":"https://api.github.com/repos/Sanne/infinispan/assignees{/user}","branches_url":"https://api.github.com/repos/Sanne/infinispan/branches{/branch}","tags_url":"https://api.github.com/repos/Sanne/infinispan/tags","blobs_url":"https://api.github.com/repos/Sanne/infinispan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Sanne/infinispan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Sanne/infinispan/git/refs{/sha}","trees_url":"https://api.github.com/repos/Sanne/infinispan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Sanne/infinispan/statuses/{sha}","languages_url":"https://api.github.com/repos/Sanne/infinispan/languages","stargazers_url":"https://api.github.com/repos/Sanne/infinispan/stargazers","contributors_url":"https://api.github.com/repos/Sanne/infinispan/contributors","subscribers_url":"https://api.github.com/repos/Sanne/infinispan/subscribers","subscription_url":"https://api.github.com/repos/Sanne/infinispan/subscription","commits_url":"https://api.github.com/repos/Sanne/infinispan/commits{/sha}","git_commits_url":"https://api.github.com/repos/Sanne/infinispan/git/commits{/sha}","comments_url":"https://api.github.com/repos/Sanne/infinispan/comments{/number}","issue_comment_url":"https://api.github.com/repos/Sanne/infinispan/issues/comments/{number}","contents_url":"https://api.github.com/repos/Sanne/infinispan/contents/{+path}","compare_url":"https://api.github.com/repos/Sanne/infinispan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Sanne/infinispan/merges","archive_url":"https://api.github.com/repos/Sanne/infinispan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Sanne/infinispan/downloads","issues_url":"https://api.github.com/repos/Sanne/infinispan/issues{/number}","pulls_url":"https://api.github.com/repos/Sanne/infinispan/pulls{/number}","milestones_url":"https://api.github.com/repos/Sanne/infinispan/milestones{/number}","notifications_url":"https://api.github.com/repos/Sanne/infinispan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Sanne/infinispan/labels{/name}","releases_url":"https://api.github.com/repos/Sanne/infinispan/releases{/id}","created_at":"2010-11-18T15:34:38Z","updated_at":"2014-06-25T15:03:42Z","pushed_at":"2014-09-03T15:07:49Z","git_url":"git://github.com/Sanne/infinispan.git","ssh_url":"git@github.com:Sanne/infinispan.git","clone_url":"https://github.com/Sanne/infinispan.git","svn_url":"https://github.com/Sanne/infinispan","homepage":"http://www.infinispan.org","size":62412,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":3,"default_branch":"master"}},"base":{"label":"infinispan:master","ref":"master","sha":"36b7a80f6a8973bb5f0ea7b9873b3004da77daaa","user":{"login":"infinispan","id":458093,"avatar_url":"https://avatars.githubusercontent.com/u/458093?v=2","gravatar_id":"0fb77c892345331382006ea0b2c8a020","url":"https://api.github.com/users/infinispan","html_url":"https://github.com/infinispan","followers_url":"https://api.github.com/users/infinispan/followers","following_url":"https://api.github.com/users/infinispan/following{/other_user}","gists_url":"https://api.github.com/users/infinispan/gists{/gist_id}","starred_url":"https://api.github.com/users/infinispan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infinispan/subscriptions","organizations_url":"https://api.github.com/users/infinispan/orgs","repos_url":"https://api.github.com/users/infinispan/repos","events_url":"https://api.github.com/users/infinispan/events{/privacy}","received_events_url":"https://api.github.com/users/infinispan/received_events","type":"Organization","site_admin":false},"repo":{"id":1050944,"name":"infinispan","full_name":"infinispan/infinispan","owner":{"login":"infinispan","id":458093,"avatar_url":"https://avatars.githubusercontent.com/u/458093?v=2","gravatar_id":"0fb77c892345331382006ea0b2c8a020","url":"https://api.github.com/users/infinispan","html_url":"https://github.com/infinispan","followers_url":"https://api.github.com/users/infinispan/followers","following_url":"https://api.github.com/users/infinispan/following{/other_user}","gists_url":"https://api.github.com/users/infinispan/gists{/gist_id}","starred_url":"https://api.github.com/users/infinispan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infinispan/subscriptions","organizations_url":"https://api.github.com/users/infinispan/orgs","repos_url":"https://api.github.com/users/infinispan/repos","events_url":"https://api.github.com/users/infinispan/events{/privacy}","received_events_url":"https://api.github.com/users/infinispan/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/infinispan/infinispan","description":"Infinispan is an open source data grid platform and highly scalable NoSQL cloud data store.","fork":false,"url":"https://api.github.com/repos/infinispan/infinispan","forks_url":"https://api.github.com/repos/infinispan/infinispan/forks","keys_url":"https://api.github.com/repos/infinispan/infinispan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/infinispan/infinispan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/infinispan/infinispan/teams","hooks_url":"https://api.github.com/repos/infinispan/infinispan/hooks","issue_events_url":"https://api.github.com/repos/infinispan/infinispan/issues/events{/number}","events_url":"https://api.github.com/repos/infinispan/infinispan/events","assignees_url":"https://api.github.com/repos/infinispan/infinispan/assignees{/user}","branches_url":"https://api.github.com/repos/infinispan/infinispan/branches{/branch}","tags_url":"https://api.github.com/repos/infinispan/infinispan/tags","blobs_url":"https://api.github.com/repos/infinispan/infinispan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/infinispan/infinispan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/infinispan/infinispan/git/refs{/sha}","trees_url":"https://api.github.com/repos/infinispan/infinispan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/infinispan/infinispan/statuses/{sha}","languages_url":"https://api.github.com/repos/infinispan/infinispan/languages","stargazers_url":"https://api.github.com/repos/infinispan/infinispan/stargazers","contributors_url":"https://api.github.com/repos/infinispan/infinispan/contributors","subscribers_url":"https://api.github.com/repos/infinispan/infinispan/subscribers","subscription_url":"https://api.github.com/repos/infinispan/infinispan/subscription","commits_url":"https://api.github.com/repos/infinispan/infinispan/commits{/sha}","git_commits_url":"https://api.github.com/repos/infinispan/infinispan/git/commits{/sha}","comments_url":"https://api.github.com/repos/infinispan/infinispan/comments{/number}","issue_comment_url":"https://api.github.com/repos/infinispan/infinispan/issues/comments/{number}","contents_url":"https://api.github.com/repos/infinispan/infinispan/contents/{+path}","compare_url":"https://api.github.com/repos/infinispan/infinispan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/infinispan/infinispan/merges","archive_url":"https://api.github.com/repos/infinispan/infinispan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/infinispan/infinispan/downloads","issues_url":"https://api.github.com/repos/infinispan/infinispan/issues{/number}","pulls_url":"https://api.github.com/repos/infinispan/infinispan/pulls{/number}","milestones_url":"https://api.github.com/repos/infinispan/infinispan/milestones{/number}","notifications_url":"https://api.github.com/repos/infinispan/infinispan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/infinispan/infinispan/labels{/name}","releases_url":"https://api.github.com/repos/infinispan/infinispan/releases{/id}","created_at":"2010-11-04T12:33:19Z","updated_at":"2014-09-02T20:11:24Z","pushed_at":"2014-09-03T14:39:16Z","git_url":"git://github.com/infinispan/infinispan.git","ssh_url":"git@github.com:infinispan/infinispan.git","clone_url":"https://github.com/infinispan/infinispan.git","svn_url":"https://github.com/infinispan/infinispan","homepage":"http://www.infinispan.org","size":124323,"stargazers_count":311,"watchers_count":311,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":251,"mirror_url":null,"open_issues_count":25,"forks":251,"open_issues":25,"watchers":311,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/2839"},"html":{"href":"https://github.com/infinispan/infinispan/pull/2839"},"issue":{"href":"https://api.github.com/repos/infinispan/infinispan/issues/2839"},"comments":{"href":"https://api.github.com/repos/infinispan/infinispan/issues/2839/comments"},"review_comments":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/2839/comments"},"review_comment":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/2839/commits"},"statuses":{"href":"https://api.github.com/repos/infinispan/infinispan/statuses/c8887ae4d5bff9409c072337be3bcecf0b1f11e4"}}}}