GitHub PullRequestReviewCommentEvent at 2014-10-07 11:59:10
Repository: Glowstone
Actor: JeromSar
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/GlowstoneMC/Glowstone/pulls/comments/18513806","id":18513806,"diff_hunk":"@@ -43,11 +44,19 @@ public void run() {\n             for (StackTraceElement trace : stack) {\n                 GlowServer.logger.warning(\"\\tat \" + trace);\n             }\n-\n-            // really get it out of there\n+            // ask nicely to kill them\n             thread.interrupt();\n-            thread.stop();\n+            // wait for them to die on their own\n+            if(thread.isAlive()){\n+                try {\n+                    thread.join(1000);\n+                } catch (InterruptedException ex) {\n+                    GlowServer.logger.severe(ex.toString());","path":"src/main/java/net/glowstone/util/ShutdownMonitorThread.java","position":31,"original_position":31,"commit_id":"e711128753f5e1a7d163425019564315cbad03c0","original_commit_id":"e711128753f5e1a7d163425019564315cbad03c0","user":{"login":"JeromSar","id":1307863,"avatar_url":"https://avatars.githubusercontent.com/u/1307863?v=2","gravatar_id":"","url":"https://api.github.com/users/JeromSar","html_url":"https://github.com/JeromSar","followers_url":"https://api.github.com/users/JeromSar/followers","following_url":"https://api.github.com/users/JeromSar/following{/other_user}","gists_url":"https://api.github.com/users/JeromSar/gists{/gist_id}","starred_url":"https://api.github.com/users/JeromSar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JeromSar/subscriptions","organizations_url":"https://api.github.com/users/JeromSar/orgs","repos_url":"https://api.github.com/users/JeromSar/repos","events_url":"https://api.github.com/users/JeromSar/events{/privacy}","received_events_url":"https://api.github.com/users/JeromSar/received_events","type":"User","site_admin":false},"body":"Probably should handle this better:\r\n\r\n```java\r\nGlowServer.logger.log(Level.SEVERE, ex.getMessage(), ex);\r\n```","created_at":"2014-10-07T11:59:10Z","updated_at":"2014-10-07T11:59:10Z","html_url":"https://github.com/GlowstoneMC/Glowstone/pull/207#discussion_r18513806","pull_request_url":"https://api.github.com/repos/GlowstoneMC/Glowstone/pulls/207","_links":{"self":{"href":"https://api.github.com/repos/GlowstoneMC/Glowstone/pulls/comments/18513806"},"html":{"href":"https://github.com/GlowstoneMC/Glowstone/pull/207#discussion_r18513806"},"pull_request":{"href":"https://api.github.com/repos/GlowstoneMC/Glowstone/pulls/207"}}},"pull_request":{"url":"https://api.github.com/repos/GlowstoneMC/Glowstone/pulls/207","id":20863165,"html_url":"https://github.com/GlowstoneMC/Glowstone/pull/207","diff_url":"https://github.com/GlowstoneMC/Glowstone/pull/207.diff","patch_url":"https://github.com/GlowstoneMC/Glowstone/pull/207.patch","issue_url":"https://api.github.com/repos/GlowstoneMC/Glowstone/issues/207","number":207,"state":"open","locked":false,"title":"Rogue threads are completely obliterated now","user":{"login":"mastercoms","id":2672245,"avatar_url":"https://avatars.githubusercontent.com/u/2672245?v=2","gravatar_id":"","url":"https://api.github.com/users/mastercoms","html_url":"https://github.com/mastercoms","followers_url":"https://api.github.com/users/mastercoms/followers","following_url":"https://api.github.com/users/mastercoms/following{/other_user}","gists_url":"https://api.github.com/users/mastercoms/gists{/gist_id}","starred_url":"https://api.github.com/users/mastercoms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mastercoms/subscriptions","organizations_url":"https://api.github.com/users/mastercoms/orgs","repos_url":"https://api.github.com/users/mastercoms/repos","events_url":"https://api.github.com/users/mastercoms/events{/privacy}","received_events_url":"https://api.github.com/users/mastercoms/received_events","type":"User","site_admin":false},"body":"Added better logic for thread sleeping, better rogue thread stopping, and finally, the shutdown thread stops the scheduler and any remaining tasks. Planning to add a graceful shutdown for scheduling later. (where it stops any new tasks from being created, then waits for any current tasks to be completed for a second or two, and then forcefully shuts down now)\r\nFixes #179 ","created_at":"2014-09-07T19:04:11Z","updated_at":"2014-10-07T11:59:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f0d02ac5ce174305a7714ddc9f5144bd67a745a9","assignee":{"login":"turt2live","id":1190097,"avatar_url":"https://avatars.githubusercontent.com/u/1190097?v=2","gravatar_id":"","url":"https://api.github.com/users/turt2live","html_url":"https://github.com/turt2live","followers_url":"https://api.github.com/users/turt2live/followers","following_url":"https://api.github.com/users/turt2live/following{/other_user}","gists_url":"https://api.github.com/users/turt2live/gists{/gist_id}","starred_url":"https://api.github.com/users/turt2live/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/turt2live/subscriptions","organizations_url":"https://api.github.com/users/turt2live/orgs","repos_url":"https://api.github.com/users/turt2live/repos","events_url":"https://api.github.com/users/turt2live/events{/privacy}","received_events_url":"https://api.github.com/users/turt2live/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/GlowstoneMC/Glowstone/pulls/207/commits","review_comments_url":"https://api.github.com/repos/GlowstoneMC/Glowstone/pulls/207/comments","review_comment_url":"https://api.github.com/repos/GlowstoneMC/Glowstone/pulls/comments/{number}","comments_url":"https://api.github.com/repos/GlowstoneMC/Glowstone/issues/207/comments","statuses_url":"https://api.github.com/repos/GlowstoneMC/Glowstone/statuses/e711128753f5e1a7d163425019564315cbad03c0","head":{"label":"CircuitSoftGroup:master","ref":"master","sha":"e711128753f5e1a7d163425019564315cbad03c0","user":{"login":"CircuitSoftGroup","id":2672082,"avatar_url":"https://avatars.githubusercontent.com/u/2672082?v=2","gravatar_id":"","url":"https://api.github.com/users/CircuitSoftGroup","html_url":"https://github.com/CircuitSoftGroup","followers_url":"https://api.github.com/users/CircuitSoftGroup/followers","following_url":"https://api.github.com/users/CircuitSoftGroup/following{/other_user}","gists_url":"https://api.github.com/users/CircuitSoftGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/CircuitSoftGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CircuitSoftGroup/subscriptions","organizations_url":"https://api.github.com/users/CircuitSoftGroup/orgs","repos_url":"https://api.github.com/users/CircuitSoftGroup/repos","events_url":"https://api.github.com/users/CircuitSoftGroup/events{/privacy}","received_events_url":"https://api.github.com/users/CircuitSoftGroup/received_events","type":"Organization","site_admin":false},"repo":{"id":23750385,"name":"Glowstone","full_name":"CircuitSoftGroup/Glowstone","owner":{"login":"CircuitSoftGroup","id":2672082,"avatar_url":"https://avatars.githubusercontent.com/u/2672082?v=2","gravatar_id":"","url":"https://api.github.com/users/CircuitSoftGroup","html_url":"https://github.com/CircuitSoftGroup","followers_url":"https://api.github.com/users/CircuitSoftGroup/followers","following_url":"https://api.github.com/users/CircuitSoftGroup/following{/other_user}","gists_url":"https://api.github.com/users/CircuitSoftGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/CircuitSoftGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CircuitSoftGroup/subscriptions","organizations_url":"https://api.github.com/users/CircuitSoftGroup/orgs","repos_url":"https://api.github.com/users/CircuitSoftGroup/repos","events_url":"https://api.github.com/users/CircuitSoftGroup/events{/privacy}","received_events_url":"https://api.github.com/users/CircuitSoftGroup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CircuitSoftGroup/Glowstone","description":"An open-source server for the Bukkit Minecraft modding interface.","fork":true,"url":"https://api.github.com/repos/CircuitSoftGroup/Glowstone","forks_url":"https://api.github.com/repos/CircuitSoftGroup/Glowstone/forks","keys_url":"https://api.github.com/repos/CircuitSoftGroup/Glowstone/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CircuitSoftGroup/Glowstone/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CircuitSoftGroup/Glowstone/teams","hooks_url":"https://api.github.com/repos/CircuitSoftGroup/Glowstone/hooks","issue_events_url":"https://api.github.com/repos/CircuitSoftGroup/Glowstone/issues/events{/number}","events_url":"https://api.github.com/repos/CircuitSoftGroup/Glowstone/events","assignees_url":"https://api.github.com/repos/CircuitSoftGroup/Glowstone/assignees{/user}","branches_url":"https://api.github.com/repos/CircuitSoftGroup/Glowstone/branches{/branch}","tags_url":"https://api.github.com/repos/CircuitSoftGroup/Glowstone/tags","blobs_url":"https://api.github.com/repos/CircuitSoftGroup/Glowstone/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CircuitSoftGroup/Glowstone/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CircuitSoftGroup/Glowstone/git/refs{/sha}","trees_url":"https://api.github.com/repos/CircuitSoftGroup/Glowstone/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CircuitSoftGroup/Glowstone/statuses/{sha}","languages_url":"https://api.github.com/repos/CircuitSoftGroup/Glowstone/languages","stargazers_url":"https://api.github.com/repos/CircuitSoftGroup/Glowstone/stargazers","contributors_url":"https://api.github.com/repos/CircuitSoftGroup/Glowstone/contributors","subscribers_url":"https://api.github.com/repos/CircuitSoftGroup/Glowstone/subscribers","subscription_url":"https://api.github.com/repos/CircuitSoftGroup/Glowstone/subscription","commits_url":"https://api.github.com/repos/CircuitSoftGroup/Glowstone/commits{/sha}","git_commits_url":"https://api.github.com/repos/CircuitSoftGroup/Glowstone/git/commits{/sha}","comments_url":"https://api.github.com/repos/CircuitSoftGroup/Glowstone/comments{/number}","issue_comment_url":"https://api.github.com/repos/CircuitSoftGroup/Glowstone/issues/comments/{number}","contents_url":"https://api.github.com/repos/CircuitSoftGroup/Glowstone/contents/{+path}","compare_url":"https://api.github.com/repos/CircuitSoftGroup/Glowstone/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CircuitSoftGroup/Glowstone/merges","archive_url":"https://api.github.com/repos/CircuitSoftGroup/Glowstone/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CircuitSoftGroup/Glowstone/downloads","issues_url":"https://api.github.com/repos/CircuitSoftGroup/Glowstone/issues{/number}","pulls_url":"https://api.github.com/repos/CircuitSoftGroup/Glowstone/pulls{/number}","milestones_url":"https://api.github.com/repos/CircuitSoftGroup/Glowstone/milestones{/number}","notifications_url":"https://api.github.com/repos/CircuitSoftGroup/Glowstone/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CircuitSoftGroup/Glowstone/labels{/name}","releases_url":"https://api.github.com/repos/CircuitSoftGroup/Glowstone/releases{/id}","created_at":"2014-09-07T02:06:10Z","updated_at":"2014-09-07T19:02:56Z","pushed_at":"2014-09-11T07:26:20Z","git_url":"git://github.com/CircuitSoftGroup/Glowstone.git","ssh_url":"git@github.com:CircuitSoftGroup/Glowstone.git","clone_url":"https://github.com/CircuitSoftGroup/Glowstone.git","svn_url":"https://github.com/CircuitSoftGroup/Glowstone","homepage":"http://www.glowstone.net/","size":4333,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GlowstoneMC:master","ref":"master","sha":"62590b77810c8ba0c3fc1d02c5aa2f8bd2dcab50","user":{"login":"GlowstoneMC","id":8682517,"avatar_url":"https://avatars.githubusercontent.com/u/8682517?v=2","gravatar_id":"","url":"https://api.github.com/users/GlowstoneMC","html_url":"https://github.com/GlowstoneMC","followers_url":"https://api.github.com/users/GlowstoneMC/followers","following_url":"https://api.github.com/users/GlowstoneMC/following{/other_user}","gists_url":"https://api.github.com/users/GlowstoneMC/gists{/gist_id}","starred_url":"https://api.github.com/users/GlowstoneMC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GlowstoneMC/subscriptions","organizations_url":"https://api.github.com/users/GlowstoneMC/orgs","repos_url":"https://api.github.com/users/GlowstoneMC/repos","events_url":"https://api.github.com/users/GlowstoneMC/events{/privacy}","received_events_url":"https://api.github.com/users/GlowstoneMC/received_events","type":"Organization","site_admin":false},"repo":{"id":1501888,"name":"Glowstone","full_name":"GlowstoneMC/Glowstone","owner":{"login":"GlowstoneMC","id":8682517,"avatar_url":"https://avatars.githubusercontent.com/u/8682517?v=2","gravatar_id":"","url":"https://api.github.com/users/GlowstoneMC","html_url":"https://github.com/GlowstoneMC","followers_url":"https://api.github.com/users/GlowstoneMC/followers","following_url":"https://api.github.com/users/GlowstoneMC/following{/other_user}","gists_url":"https://api.github.com/users/GlowstoneMC/gists{/gist_id}","starred_url":"https://api.github.com/users/GlowstoneMC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GlowstoneMC/subscriptions","organizations_url":"https://api.github.com/users/GlowstoneMC/orgs","repos_url":"https://api.github.com/users/GlowstoneMC/repos","events_url":"https://api.github.com/users/GlowstoneMC/events{/privacy}","received_events_url":"https://api.github.com/users/GlowstoneMC/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GlowstoneMC/Glowstone","description":"An open-source server for the Bukkit Minecraft modding interface.","fork":false,"url":"https://api.github.com/repos/GlowstoneMC/Glowstone","forks_url":"https://api.github.com/repos/GlowstoneMC/Glowstone/forks","keys_url":"https://api.github.com/repos/GlowstoneMC/Glowstone/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GlowstoneMC/Glowstone/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GlowstoneMC/Glowstone/teams","hooks_url":"https://api.github.com/repos/GlowstoneMC/Glowstone/hooks","issue_events_url":"https://api.github.com/repos/GlowstoneMC/Glowstone/issues/events{/number}","events_url":"https://api.github.com/repos/GlowstoneMC/Glowstone/events","assignees_url":"https://api.github.com/repos/GlowstoneMC/Glowstone/assignees{/user}","branches_url":"https://api.github.com/repos/GlowstoneMC/Glowstone/branches{/branch}","tags_url":"https://api.github.com/repos/GlowstoneMC/Glowstone/tags","blobs_url":"https://api.github.com/repos/GlowstoneMC/Glowstone/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GlowstoneMC/Glowstone/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GlowstoneMC/Glowstone/git/refs{/sha}","trees_url":"https://api.github.com/repos/GlowstoneMC/Glowstone/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GlowstoneMC/Glowstone/statuses/{sha}","languages_url":"https://api.github.com/repos/GlowstoneMC/Glowstone/languages","stargazers_url":"https://api.github.com/repos/GlowstoneMC/Glowstone/stargazers","contributors_url":"https://api.github.com/repos/GlowstoneMC/Glowstone/contributors","subscribers_url":"https://api.github.com/repos/GlowstoneMC/Glowstone/subscribers","subscription_url":"https://api.github.com/repos/GlowstoneMC/Glowstone/subscription","commits_url":"https://api.github.com/repos/GlowstoneMC/Glowstone/commits{/sha}","git_commits_url":"https://api.github.com/repos/GlowstoneMC/Glowstone/git/commits{/sha}","comments_url":"https://api.github.com/repos/GlowstoneMC/Glowstone/comments{/number}","issue_comment_url":"https://api.github.com/repos/GlowstoneMC/Glowstone/issues/comments/{number}","contents_url":"https://api.github.com/repos/GlowstoneMC/Glowstone/contents/{+path}","compare_url":"https://api.github.com/repos/GlowstoneMC/Glowstone/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GlowstoneMC/Glowstone/merges","archive_url":"https://api.github.com/repos/GlowstoneMC/Glowstone/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GlowstoneMC/Glowstone/downloads","issues_url":"https://api.github.com/repos/GlowstoneMC/Glowstone/issues{/number}","pulls_url":"https://api.github.com/repos/GlowstoneMC/Glowstone/pulls{/number}","milestones_url":"https://api.github.com/repos/GlowstoneMC/Glowstone/milestones{/number}","notifications_url":"https://api.github.com/repos/GlowstoneMC/Glowstone/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GlowstoneMC/Glowstone/labels{/name}","releases_url":"https://api.github.com/repos/GlowstoneMC/Glowstone/releases{/id}","created_at":"2011-03-20T01:40:35Z","updated_at":"2014-10-07T04:46:35Z","pushed_at":"2014-10-07T05:36:49Z","git_url":"git://github.com/GlowstoneMC/Glowstone.git","ssh_url":"git@github.com:GlowstoneMC/Glowstone.git","clone_url":"https://github.com/GlowstoneMC/Glowstone.git","svn_url":"https://github.com/GlowstoneMC/Glowstone","homepage":"http://www.glowstone.net/","size":18154,"stargazers_count":284,"watchers_count":284,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":142,"mirror_url":null,"open_issues_count":100,"forks":142,"open_issues":100,"watchers":284,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GlowstoneMC/Glowstone/pulls/207"},"html":{"href":"https://github.com/GlowstoneMC/Glowstone/pull/207"},"issue":{"href":"https://api.github.com/repos/GlowstoneMC/Glowstone/issues/207"},"comments":{"href":"https://api.github.com/repos/GlowstoneMC/Glowstone/issues/207/comments"},"review_comments":{"href":"https://api.github.com/repos/GlowstoneMC/Glowstone/pulls/207/comments"},"review_comment":{"href":"https://api.github.com/repos/GlowstoneMC/Glowstone/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/GlowstoneMC/Glowstone/pulls/207/commits"},"statuses":{"href":"https://api.github.com/repos/GlowstoneMC/Glowstone/statuses/e711128753f5e1a7d163425019564315cbad03c0"}}}}