GitHub PullRequestReviewCommentEvent at 2014-10-28 21:30:46
Repository: voltdb
Actor: mikeismert
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/VoltDB/voltdb/pulls/comments/19505532","id":19505532,"diff_hunk":"@@ -305,6 +302,26 @@ public void testReadOnlyProcs() throws Exception {\n         assertEquals(ClientResponse.SUCCESS, result);\n     }\n \n+    public void testAdmin() throws Exception {\n+        m_username = \"user4\";\n+        m_password = \"password\";\n+        Client client = getClient();\n+\n+        // adhoc\n+        VoltTable modCount = client.callProcedure(\"@AdHoc\", \"INSERT INTO NEW_ORDER VALUES (4, 4, 4);\").getResults()[0];\n+        assertTrue(modCount.getRowCount() == 1);\n+        assertTrue(modCount.asScalarLong() == 1);\n+\n+        // sysproc\n+        assertEquals(ClientResponse.SUCCESS, client.callProcedure(\"@Quiesce\").getStatus());\n+\n+        // default proc\n+        assertEquals(ClientResponse.SUCCESS, client.callProcedure(\"NEW_ORDER.insert\", 100, 100, 100).getStatus());\n+\n+        // user proc\n+        assertEquals(ClientResponse.SUCCESS, client.callProcedure(\"DoNothing3\", 1).getStatus());\n+    }\n+","path":"tests/frontend/org/voltdb/regressionsuites/TestSecuritySuite.java","position":40,"original_position":40,"commit_id":"797d5af6e4481f9500026e8af98c4b363ccb6507","original_commit_id":"797d5af6e4481f9500026e8af98c4b363ccb6507","user":{"login":"mikeismert","id":482828,"avatar_url":"https://avatars.githubusercontent.com/u/482828?v=2","gravatar_id":"","url":"https://api.github.com/users/mikeismert","html_url":"https://github.com/mikeismert","followers_url":"https://api.github.com/users/mikeismert/followers","following_url":"https://api.github.com/users/mikeismert/following{/other_user}","gists_url":"https://api.github.com/users/mikeismert/gists{/gist_id}","starred_url":"https://api.github.com/users/mikeismert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikeismert/subscriptions","organizations_url":"https://api.github.com/users/mikeismert/orgs","repos_url":"https://api.github.com/users/mikeismert/repos","events_url":"https://api.github.com/users/mikeismert/events{/privacy}","received_events_url":"https://api.github.com/users/mikeismert/received_events","type":"User","site_admin":false},"body":"It seems like we could use some tests of permissions against live DDL too?  Dunno who is going to draw the short straw on that one...","created_at":"2014-10-28T21:30:46Z","updated_at":"2014-10-28T21:30:46Z","html_url":"https://github.com/VoltDB/voltdb/pull/1737#discussion_r19505532","pull_request_url":"https://api.github.com/repos/VoltDB/voltdb/pulls/1737","_links":{"self":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/comments/19505532"},"html":{"href":"https://github.com/VoltDB/voltdb/pull/1737#discussion_r19505532"},"pull_request":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/1737"}}},"pull_request":{"url":"https://api.github.com/repos/VoltDB/voltdb/pulls/1737","id":23486652,"html_url":"https://github.com/VoltDB/voltdb/pull/1737","diff_url":"https://github.com/VoltDB/voltdb/pull/1737.diff","patch_url":"https://github.com/VoltDB/voltdb/pull/1737.patch","issue_url":"https://api.github.com/repos/VoltDB/voltdb/issues/1737","number":1737,"state":"open","locked":false,"title":"ENG-6854: Add ADMIN permission.","user":{"login":"nshi","id":10992,"avatar_url":"https://avatars.githubusercontent.com/u/10992?v=2","gravatar_id":"","url":"https://api.github.com/users/nshi","html_url":"https://github.com/nshi","followers_url":"https://api.github.com/users/nshi/followers","following_url":"https://api.github.com/users/nshi/following{/other_user}","gists_url":"https://api.github.com/users/nshi/gists{/gist_id}","starred_url":"https://api.github.com/users/nshi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nshi/subscriptions","organizations_url":"https://api.github.com/users/nshi/orgs","repos_url":"https://api.github.com/users/nshi/repos","events_url":"https://api.github.com/users/nshi/events{/privacy}","received_events_url":"https://api.github.com/users/nshi/received_events","type":"User","site_admin":false},"body":"For backward compatibility, the SYSPROC permission is now an alias of the ADMIN permission.","created_at":"2014-10-28T20:14:28Z","updated_at":"2014-10-28T21:30:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dc7d52b9303643e0ad65a006e7e9bb855a9ba0de","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/VoltDB/voltdb/pulls/1737/commits","review_comments_url":"https://api.github.com/repos/VoltDB/voltdb/pulls/1737/comments","review_comment_url":"https://api.github.com/repos/VoltDB/voltdb/pulls/comments/{number}","comments_url":"https://api.github.com/repos/VoltDB/voltdb/issues/1737/comments","statuses_url":"https://api.github.com/repos/VoltDB/voltdb/statuses/797d5af6e4481f9500026e8af98c4b363ccb6507","head":{"label":"VoltDB:ENG-6854","ref":"ENG-6854","sha":"797d5af6e4481f9500026e8af98c4b363ccb6507","user":{"login":"VoltDB","id":703910,"avatar_url":"https://avatars.githubusercontent.com/u/703910?v=2","gravatar_id":"","url":"https://api.github.com/users/VoltDB","html_url":"https://github.com/VoltDB","followers_url":"https://api.github.com/users/VoltDB/followers","following_url":"https://api.github.com/users/VoltDB/following{/other_user}","gists_url":"https://api.github.com/users/VoltDB/gists{/gist_id}","starred_url":"https://api.github.com/users/VoltDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VoltDB/subscriptions","organizations_url":"https://api.github.com/users/VoltDB/orgs","repos_url":"https://api.github.com/users/VoltDB/repos","events_url":"https://api.github.com/users/VoltDB/events{/privacy}","received_events_url":"https://api.github.com/users/VoltDB/received_events","type":"Organization","site_admin":false},"repo":{"id":2445970,"name":"voltdb","full_name":"VoltDB/voltdb","owner":{"login":"VoltDB","id":703910,"avatar_url":"https://avatars.githubusercontent.com/u/703910?v=2","gravatar_id":"","url":"https://api.github.com/users/VoltDB","html_url":"https://github.com/VoltDB","followers_url":"https://api.github.com/users/VoltDB/followers","following_url":"https://api.github.com/users/VoltDB/following{/other_user}","gists_url":"https://api.github.com/users/VoltDB/gists{/gist_id}","starred_url":"https://api.github.com/users/VoltDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VoltDB/subscriptions","organizations_url":"https://api.github.com/users/VoltDB/orgs","repos_url":"https://api.github.com/users/VoltDB/repos","events_url":"https://api.github.com/users/VoltDB/events{/privacy}","received_events_url":"https://api.github.com/users/VoltDB/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/VoltDB/voltdb","description":"VoltDB","fork":false,"url":"https://api.github.com/repos/VoltDB/voltdb","forks_url":"https://api.github.com/repos/VoltDB/voltdb/forks","keys_url":"https://api.github.com/repos/VoltDB/voltdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VoltDB/voltdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VoltDB/voltdb/teams","hooks_url":"https://api.github.com/repos/VoltDB/voltdb/hooks","issue_events_url":"https://api.github.com/repos/VoltDB/voltdb/issues/events{/number}","events_url":"https://api.github.com/repos/VoltDB/voltdb/events","assignees_url":"https://api.github.com/repos/VoltDB/voltdb/assignees{/user}","branches_url":"https://api.github.com/repos/VoltDB/voltdb/branches{/branch}","tags_url":"https://api.github.com/repos/VoltDB/voltdb/tags","blobs_url":"https://api.github.com/repos/VoltDB/voltdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VoltDB/voltdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VoltDB/voltdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/VoltDB/voltdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VoltDB/voltdb/statuses/{sha}","languages_url":"https://api.github.com/repos/VoltDB/voltdb/languages","stargazers_url":"https://api.github.com/repos/VoltDB/voltdb/stargazers","contributors_url":"https://api.github.com/repos/VoltDB/voltdb/contributors","subscribers_url":"https://api.github.com/repos/VoltDB/voltdb/subscribers","subscription_url":"https://api.github.com/repos/VoltDB/voltdb/subscription","commits_url":"https://api.github.com/repos/VoltDB/voltdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/VoltDB/voltdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/VoltDB/voltdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/VoltDB/voltdb/issues/comments/{number}","contents_url":"https://api.github.com/repos/VoltDB/voltdb/contents/{+path}","compare_url":"https://api.github.com/repos/VoltDB/voltdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VoltDB/voltdb/merges","archive_url":"https://api.github.com/repos/VoltDB/voltdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VoltDB/voltdb/downloads","issues_url":"https://api.github.com/repos/VoltDB/voltdb/issues{/number}","pulls_url":"https://api.github.com/repos/VoltDB/voltdb/pulls{/number}","milestones_url":"https://api.github.com/repos/VoltDB/voltdb/milestones{/number}","notifications_url":"https://api.github.com/repos/VoltDB/voltdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VoltDB/voltdb/labels{/name}","releases_url":"https://api.github.com/repos/VoltDB/voltdb/releases{/id}","created_at":"2011-09-23T18:46:12Z","updated_at":"2014-10-28T02:12:12Z","pushed_at":"2014-10-28T21:27:42Z","git_url":"git://github.com/VoltDB/voltdb.git","ssh_url":"git@github.com:VoltDB/voltdb.git","clone_url":"https://github.com/VoltDB/voltdb.git","svn_url":"https://github.com/VoltDB/voltdb","homepage":"http://community.voltdb.com/","size":526692,"stargazers_count":382,"watchers_count":382,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":110,"mirror_url":null,"open_issues_count":19,"forks":110,"open_issues":19,"watchers":382,"default_branch":"master"}},"base":{"label":"VoltDB:master","ref":"master","sha":"7c7f8723538e5c891bd2fbcbd6179d0be7c1e0ee","user":{"login":"VoltDB","id":703910,"avatar_url":"https://avatars.githubusercontent.com/u/703910?v=2","gravatar_id":"","url":"https://api.github.com/users/VoltDB","html_url":"https://github.com/VoltDB","followers_url":"https://api.github.com/users/VoltDB/followers","following_url":"https://api.github.com/users/VoltDB/following{/other_user}","gists_url":"https://api.github.com/users/VoltDB/gists{/gist_id}","starred_url":"https://api.github.com/users/VoltDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VoltDB/subscriptions","organizations_url":"https://api.github.com/users/VoltDB/orgs","repos_url":"https://api.github.com/users/VoltDB/repos","events_url":"https://api.github.com/users/VoltDB/events{/privacy}","received_events_url":"https://api.github.com/users/VoltDB/received_events","type":"Organization","site_admin":false},"repo":{"id":2445970,"name":"voltdb","full_name":"VoltDB/voltdb","owner":{"login":"VoltDB","id":703910,"avatar_url":"https://avatars.githubusercontent.com/u/703910?v=2","gravatar_id":"","url":"https://api.github.com/users/VoltDB","html_url":"https://github.com/VoltDB","followers_url":"https://api.github.com/users/VoltDB/followers","following_url":"https://api.github.com/users/VoltDB/following{/other_user}","gists_url":"https://api.github.com/users/VoltDB/gists{/gist_id}","starred_url":"https://api.github.com/users/VoltDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VoltDB/subscriptions","organizations_url":"https://api.github.com/users/VoltDB/orgs","repos_url":"https://api.github.com/users/VoltDB/repos","events_url":"https://api.github.com/users/VoltDB/events{/privacy}","received_events_url":"https://api.github.com/users/VoltDB/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/VoltDB/voltdb","description":"VoltDB","fork":false,"url":"https://api.github.com/repos/VoltDB/voltdb","forks_url":"https://api.github.com/repos/VoltDB/voltdb/forks","keys_url":"https://api.github.com/repos/VoltDB/voltdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VoltDB/voltdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VoltDB/voltdb/teams","hooks_url":"https://api.github.com/repos/VoltDB/voltdb/hooks","issue_events_url":"https://api.github.com/repos/VoltDB/voltdb/issues/events{/number}","events_url":"https://api.github.com/repos/VoltDB/voltdb/events","assignees_url":"https://api.github.com/repos/VoltDB/voltdb/assignees{/user}","branches_url":"https://api.github.com/repos/VoltDB/voltdb/branches{/branch}","tags_url":"https://api.github.com/repos/VoltDB/voltdb/tags","blobs_url":"https://api.github.com/repos/VoltDB/voltdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VoltDB/voltdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VoltDB/voltdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/VoltDB/voltdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VoltDB/voltdb/statuses/{sha}","languages_url":"https://api.github.com/repos/VoltDB/voltdb/languages","stargazers_url":"https://api.github.com/repos/VoltDB/voltdb/stargazers","contributors_url":"https://api.github.com/repos/VoltDB/voltdb/contributors","subscribers_url":"https://api.github.com/repos/VoltDB/voltdb/subscribers","subscription_url":"https://api.github.com/repos/VoltDB/voltdb/subscription","commits_url":"https://api.github.com/repos/VoltDB/voltdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/VoltDB/voltdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/VoltDB/voltdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/VoltDB/voltdb/issues/comments/{number}","contents_url":"https://api.github.com/repos/VoltDB/voltdb/contents/{+path}","compare_url":"https://api.github.com/repos/VoltDB/voltdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VoltDB/voltdb/merges","archive_url":"https://api.github.com/repos/VoltDB/voltdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VoltDB/voltdb/downloads","issues_url":"https://api.github.com/repos/VoltDB/voltdb/issues{/number}","pulls_url":"https://api.github.com/repos/VoltDB/voltdb/pulls{/number}","milestones_url":"https://api.github.com/repos/VoltDB/voltdb/milestones{/number}","notifications_url":"https://api.github.com/repos/VoltDB/voltdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VoltDB/voltdb/labels{/name}","releases_url":"https://api.github.com/repos/VoltDB/voltdb/releases{/id}","created_at":"2011-09-23T18:46:12Z","updated_at":"2014-10-28T02:12:12Z","pushed_at":"2014-10-28T21:27:42Z","git_url":"git://github.com/VoltDB/voltdb.git","ssh_url":"git@github.com:VoltDB/voltdb.git","clone_url":"https://github.com/VoltDB/voltdb.git","svn_url":"https://github.com/VoltDB/voltdb","homepage":"http://community.voltdb.com/","size":526692,"stargazers_count":382,"watchers_count":382,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":110,"mirror_url":null,"open_issues_count":19,"forks":110,"open_issues":19,"watchers":382,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/1737"},"html":{"href":"https://github.com/VoltDB/voltdb/pull/1737"},"issue":{"href":"https://api.github.com/repos/VoltDB/voltdb/issues/1737"},"comments":{"href":"https://api.github.com/repos/VoltDB/voltdb/issues/1737/comments"},"review_comments":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/1737/comments"},"review_comment":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/1737/commits"},"statuses":{"href":"https://api.github.com/repos/VoltDB/voltdb/statuses/797d5af6e4481f9500026e8af98c4b363ccb6507"}}}}