GitHub PullRequestReviewCommentEvent at 2014-12-23 12:41:59
Repository: stereogram
Actor: sgharms
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/raccoons-2014/stereogram/pulls/comments/22213543","id":22213543,"diff_hunk":"@@ -26,5 +26,11 @@ class Application < Rails::Application\n     # The default locale is :en and all translations from config/locales/*.rb,yml are auto loaded.\n     # config.i18n.load_path += Dir[Rails.root.join('my', 'locales', '*.{rb,yml}').to_s]\n     # config.i18n.default_locale = :de\n+\n+    AWS::S3::Base.establish_connection!(","path":"config/application.rb","position":5,"original_position":5,"commit_id":"f24c017eca61c16806f763ab7f0b4f5e24cfab83","original_commit_id":"f24c017eca61c16806f763ab7f0b4f5e24cfab83","user":{"login":"sgharms","id":50019,"avatar_url":"https://avatars.githubusercontent.com/u/50019?v=3","gravatar_id":"","url":"https://api.github.com/users/sgharms","html_url":"https://github.com/sgharms","followers_url":"https://api.github.com/users/sgharms/followers","following_url":"https://api.github.com/users/sgharms/following{/other_user}","gists_url":"https://api.github.com/users/sgharms/gists{/gist_id}","starred_url":"https://api.github.com/users/sgharms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgharms/subscriptions","organizations_url":"https://api.github.com/users/sgharms/orgs","repos_url":"https://api.github.com/users/sgharms/repos","events_url":"https://api.github.com/users/sgharms/events{/privacy}","received_events_url":"https://api.github.com/users/sgharms/received_events","type":"User","site_admin":false},"body":"Indentation bad, using ENV vars correctly **AWESOMEAH**","created_at":"2014-12-23T12:41:59Z","updated_at":"2014-12-23T12:41:59Z","html_url":"https://github.com/raccoons-2014/stereogram/pull/13#discussion_r22213543","pull_request_url":"https://api.github.com/repos/raccoons-2014/stereogram/pulls/13","_links":{"self":{"href":"https://api.github.com/repos/raccoons-2014/stereogram/pulls/comments/22213543"},"html":{"href":"https://github.com/raccoons-2014/stereogram/pull/13#discussion_r22213543"},"pull_request":{"href":"https://api.github.com/repos/raccoons-2014/stereogram/pulls/13"}}},"pull_request":{"url":"https://api.github.com/repos/raccoons-2014/stereogram/pulls/13","id":26508062,"html_url":"https://github.com/raccoons-2014/stereogram/pull/13","diff_url":"https://github.com/raccoons-2014/stereogram/pull/13.diff","patch_url":"https://github.com/raccoons-2014/stereogram/pull/13.patch","issue_url":"https://api.github.com/repos/raccoons-2014/stereogram/issues/13","number":13,"state":"open","locked":false,"title":"Jplayer inquiry","user":{"login":"zahidkarim","id":8495756,"avatar_url":"https://avatars.githubusercontent.com/u/8495756?v=3","gravatar_id":"","url":"https://api.github.com/users/zahidkarim","html_url":"https://github.com/zahidkarim","followers_url":"https://api.github.com/users/zahidkarim/followers","following_url":"https://api.github.com/users/zahidkarim/following{/other_user}","gists_url":"https://api.github.com/users/zahidkarim/gists{/gist_id}","starred_url":"https://api.github.com/users/zahidkarim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zahidkarim/subscriptions","organizations_url":"https://api.github.com/users/zahidkarim/orgs","repos_url":"https://api.github.com/users/zahidkarim/repos","events_url":"https://api.github.com/users/zahidkarim/events{/privacy}","received_events_url":"https://api.github.com/users/zahidkarim/received_events","type":"User","site_admin":false},"body":"@liammccartney @chrisrcoles @torpeyp @AlexSYanai \r\n\r\nHey Guys, (DO NOT MERGE THIS REQUEST::JUST LOOK THROUGH PLEASE)\r\n\r\nSo I spent some time on the player this morning. I think I figured out how to manipulate all parts of the player. Chris I moved your player into a partial. I am not sure why there are so many divs.Not sure if they are needed. Question: what are all the divs for and are they needed?\r\n\r\nThe look is obvs not what we want but once we come to a consensus then we can style accordingly. Super easy now to do that.\r\n\r\nAs for playing the files through AWS. We need to create a JS class that can do something like this: http://stackoverflow.com/questions/8206608/changing-songs-on-jplayer-by-clicking-a-link-hosted-on-amazon-s3\r\n\r\nLet me know if we are going down the right path and / or to change.","created_at":"2014-12-23T12:25:37Z","updated_at":"2014-12-23T12:41:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dcc144e7e8250c8d013d32c025755be6632a10b4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/raccoons-2014/stereogram/pulls/13/commits","review_comments_url":"https://api.github.com/repos/raccoons-2014/stereogram/pulls/13/comments","review_comment_url":"https://api.github.com/repos/raccoons-2014/stereogram/pulls/comments/{number}","comments_url":"https://api.github.com/repos/raccoons-2014/stereogram/issues/13/comments","statuses_url":"https://api.github.com/repos/raccoons-2014/stereogram/statuses/f24c017eca61c16806f763ab7f0b4f5e24cfab83","head":{"label":"raccoons-2014:jplayer-inquiry","ref":"jplayer-inquiry","sha":"f24c017eca61c16806f763ab7f0b4f5e24cfab83","user":{"login":"raccoons-2014","id":6732839,"avatar_url":"https://avatars.githubusercontent.com/u/6732839?v=3","gravatar_id":"","url":"https://api.github.com/users/raccoons-2014","html_url":"https://github.com/raccoons-2014","followers_url":"https://api.github.com/users/raccoons-2014/followers","following_url":"https://api.github.com/users/raccoons-2014/following{/other_user}","gists_url":"https://api.github.com/users/raccoons-2014/gists{/gist_id}","starred_url":"https://api.github.com/users/raccoons-2014/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raccoons-2014/subscriptions","organizations_url":"https://api.github.com/users/raccoons-2014/orgs","repos_url":"https://api.github.com/users/raccoons-2014/repos","events_url":"https://api.github.com/users/raccoons-2014/events{/privacy}","received_events_url":"https://api.github.com/users/raccoons-2014/received_events","type":"Organization","site_admin":false},"repo":{"id":28159789,"name":"stereogram","full_name":"raccoons-2014/stereogram","owner":{"login":"raccoons-2014","id":6732839,"avatar_url":"https://avatars.githubusercontent.com/u/6732839?v=3","gravatar_id":"","url":"https://api.github.com/users/raccoons-2014","html_url":"https://github.com/raccoons-2014","followers_url":"https://api.github.com/users/raccoons-2014/followers","following_url":"https://api.github.com/users/raccoons-2014/following{/other_user}","gists_url":"https://api.github.com/users/raccoons-2014/gists{/gist_id}","starred_url":"https://api.github.com/users/raccoons-2014/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raccoons-2014/subscriptions","organizations_url":"https://api.github.com/users/raccoons-2014/orgs","repos_url":"https://api.github.com/users/raccoons-2014/repos","events_url":"https://api.github.com/users/raccoons-2014/events{/privacy}","received_events_url":"https://api.github.com/users/raccoons-2014/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/raccoons-2014/stereogram","description":"Raccoons - Phase 3 Final Project","fork":false,"url":"https://api.github.com/repos/raccoons-2014/stereogram","forks_url":"https://api.github.com/repos/raccoons-2014/stereogram/forks","keys_url":"https://api.github.com/repos/raccoons-2014/stereogram/keys{/key_id}","collaborators_url":"https://api.github.com/repos/raccoons-2014/stereogram/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/raccoons-2014/stereogram/teams","hooks_url":"https://api.github.com/repos/raccoons-2014/stereogram/hooks","issue_events_url":"https://api.github.com/repos/raccoons-2014/stereogram/issues/events{/number}","events_url":"https://api.github.com/repos/raccoons-2014/stereogram/events","assignees_url":"https://api.github.com/repos/raccoons-2014/stereogram/assignees{/user}","branches_url":"https://api.github.com/repos/raccoons-2014/stereogram/branches{/branch}","tags_url":"https://api.github.com/repos/raccoons-2014/stereogram/tags","blobs_url":"https://api.github.com/repos/raccoons-2014/stereogram/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/raccoons-2014/stereogram/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/raccoons-2014/stereogram/git/refs{/sha}","trees_url":"https://api.github.com/repos/raccoons-2014/stereogram/git/trees{/sha}","statuses_url":"https://api.github.com/repos/raccoons-2014/stereogram/statuses/{sha}","languages_url":"https://api.github.com/repos/raccoons-2014/stereogram/languages","stargazers_url":"https://api.github.com/repos/raccoons-2014/stereogram/stargazers","contributors_url":"https://api.github.com/repos/raccoons-2014/stereogram/contributors","subscribers_url":"https://api.github.com/repos/raccoons-2014/stereogram/subscribers","subscription_url":"https://api.github.com/repos/raccoons-2014/stereogram/subscription","commits_url":"https://api.github.com/repos/raccoons-2014/stereogram/commits{/sha}","git_commits_url":"https://api.github.com/repos/raccoons-2014/stereogram/git/commits{/sha}","comments_url":"https://api.github.com/repos/raccoons-2014/stereogram/comments{/number}","issue_comment_url":"https://api.github.com/repos/raccoons-2014/stereogram/issues/comments/{number}","contents_url":"https://api.github.com/repos/raccoons-2014/stereogram/contents/{+path}","compare_url":"https://api.github.com/repos/raccoons-2014/stereogram/compare/{base}...{head}","merges_url":"https://api.github.com/repos/raccoons-2014/stereogram/merges","archive_url":"https://api.github.com/repos/raccoons-2014/stereogram/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/raccoons-2014/stereogram/downloads","issues_url":"https://api.github.com/repos/raccoons-2014/stereogram/issues{/number}","pulls_url":"https://api.github.com/repos/raccoons-2014/stereogram/pulls{/number}","milestones_url":"https://api.github.com/repos/raccoons-2014/stereogram/milestones{/number}","notifications_url":"https://api.github.com/repos/raccoons-2014/stereogram/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/raccoons-2014/stereogram/labels{/name}","releases_url":"https://api.github.com/repos/raccoons-2014/stereogram/releases{/id}","created_at":"2014-12-17T23:16:33Z","updated_at":"2014-12-17T23:16:33Z","pushed_at":"2014-12-23T12:20:07Z","git_url":"git://github.com/raccoons-2014/stereogram.git","ssh_url":"git@github.com:raccoons-2014/stereogram.git","clone_url":"https://github.com/raccoons-2014/stereogram.git","svn_url":"https://github.com/raccoons-2014/stereogram","homepage":null,"size":496,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"raccoons-2014:mvp_development","ref":"mvp_development","sha":"902b4fccff7349b1b69ad017a9a3d6e49d619309","user":{"login":"raccoons-2014","id":6732839,"avatar_url":"https://avatars.githubusercontent.com/u/6732839?v=3","gravatar_id":"","url":"https://api.github.com/users/raccoons-2014","html_url":"https://github.com/raccoons-2014","followers_url":"https://api.github.com/users/raccoons-2014/followers","following_url":"https://api.github.com/users/raccoons-2014/following{/other_user}","gists_url":"https://api.github.com/users/raccoons-2014/gists{/gist_id}","starred_url":"https://api.github.com/users/raccoons-2014/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raccoons-2014/subscriptions","organizations_url":"https://api.github.com/users/raccoons-2014/orgs","repos_url":"https://api.github.com/users/raccoons-2014/repos","events_url":"https://api.github.com/users/raccoons-2014/events{/privacy}","received_events_url":"https://api.github.com/users/raccoons-2014/received_events","type":"Organization","site_admin":false},"repo":{"id":28159789,"name":"stereogram","full_name":"raccoons-2014/stereogram","owner":{"login":"raccoons-2014","id":6732839,"avatar_url":"https://avatars.githubusercontent.com/u/6732839?v=3","gravatar_id":"","url":"https://api.github.com/users/raccoons-2014","html_url":"https://github.com/raccoons-2014","followers_url":"https://api.github.com/users/raccoons-2014/followers","following_url":"https://api.github.com/users/raccoons-2014/following{/other_user}","gists_url":"https://api.github.com/users/raccoons-2014/gists{/gist_id}","starred_url":"https://api.github.com/users/raccoons-2014/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raccoons-2014/subscriptions","organizations_url":"https://api.github.com/users/raccoons-2014/orgs","repos_url":"https://api.github.com/users/raccoons-2014/repos","events_url":"https://api.github.com/users/raccoons-2014/events{/privacy}","received_events_url":"https://api.github.com/users/raccoons-2014/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/raccoons-2014/stereogram","description":"Raccoons - Phase 3 Final Project","fork":false,"url":"https://api.github.com/repos/raccoons-2014/stereogram","forks_url":"https://api.github.com/repos/raccoons-2014/stereogram/forks","keys_url":"https://api.github.com/repos/raccoons-2014/stereogram/keys{/key_id}","collaborators_url":"https://api.github.com/repos/raccoons-2014/stereogram/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/raccoons-2014/stereogram/teams","hooks_url":"https://api.github.com/repos/raccoons-2014/stereogram/hooks","issue_events_url":"https://api.github.com/repos/raccoons-2014/stereogram/issues/events{/number}","events_url":"https://api.github.com/repos/raccoons-2014/stereogram/events","assignees_url":"https://api.github.com/repos/raccoons-2014/stereogram/assignees{/user}","branches_url":"https://api.github.com/repos/raccoons-2014/stereogram/branches{/branch}","tags_url":"https://api.github.com/repos/raccoons-2014/stereogram/tags","blobs_url":"https://api.github.com/repos/raccoons-2014/stereogram/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/raccoons-2014/stereogram/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/raccoons-2014/stereogram/git/refs{/sha}","trees_url":"https://api.github.com/repos/raccoons-2014/stereogram/git/trees{/sha}","statuses_url":"https://api.github.com/repos/raccoons-2014/stereogram/statuses/{sha}","languages_url":"https://api.github.com/repos/raccoons-2014/stereogram/languages","stargazers_url":"https://api.github.com/repos/raccoons-2014/stereogram/stargazers","contributors_url":"https://api.github.com/repos/raccoons-2014/stereogram/contributors","subscribers_url":"https://api.github.com/repos/raccoons-2014/stereogram/subscribers","subscription_url":"https://api.github.com/repos/raccoons-2014/stereogram/subscription","commits_url":"https://api.github.com/repos/raccoons-2014/stereogram/commits{/sha}","git_commits_url":"https://api.github.com/repos/raccoons-2014/stereogram/git/commits{/sha}","comments_url":"https://api.github.com/repos/raccoons-2014/stereogram/comments{/number}","issue_comment_url":"https://api.github.com/repos/raccoons-2014/stereogram/issues/comments/{number}","contents_url":"https://api.github.com/repos/raccoons-2014/stereogram/contents/{+path}","compare_url":"https://api.github.com/repos/raccoons-2014/stereogram/compare/{base}...{head}","merges_url":"https://api.github.com/repos/raccoons-2014/stereogram/merges","archive_url":"https://api.github.com/repos/raccoons-2014/stereogram/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/raccoons-2014/stereogram/downloads","issues_url":"https://api.github.com/repos/raccoons-2014/stereogram/issues{/number}","pulls_url":"https://api.github.com/repos/raccoons-2014/stereogram/pulls{/number}","milestones_url":"https://api.github.com/repos/raccoons-2014/stereogram/milestones{/number}","notifications_url":"https://api.github.com/repos/raccoons-2014/stereogram/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/raccoons-2014/stereogram/labels{/name}","releases_url":"https://api.github.com/repos/raccoons-2014/stereogram/releases{/id}","created_at":"2014-12-17T23:16:33Z","updated_at":"2014-12-17T23:16:33Z","pushed_at":"2014-12-23T12:20:07Z","git_url":"git://github.com/raccoons-2014/stereogram.git","ssh_url":"git@github.com:raccoons-2014/stereogram.git","clone_url":"https://github.com/raccoons-2014/stereogram.git","svn_url":"https://github.com/raccoons-2014/stereogram","homepage":null,"size":496,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/raccoons-2014/stereogram/pulls/13"},"html":{"href":"https://github.com/raccoons-2014/stereogram/pull/13"},"issue":{"href":"https://api.github.com/repos/raccoons-2014/stereogram/issues/13"},"comments":{"href":"https://api.github.com/repos/raccoons-2014/stereogram/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/raccoons-2014/stereogram/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/raccoons-2014/stereogram/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/raccoons-2014/stereogram/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/raccoons-2014/stereogram/statuses/f24c017eca61c16806f763ab7f0b4f5e24cfab83"}}}}