GitHub PullRequestEvent at 2014-01-26 12:49:45
Repository: sjcl
Actor: Nilos
Payload: {"action":"closed","number":143,"pull_request":{"url":"https://api.github.com/repos/bitwiseshiftleft/sjcl/pulls/143","id":10434117,"html_url":"https://github.com/bitwiseshiftleft/sjcl/pull/143","diff_url":"https://github.com/bitwiseshiftleft/sjcl/pull/143.diff","patch_url":"https://github.com/bitwiseshiftleft/sjcl/pull/143.patch","issue_url":"https://api.github.com/repos/bitwiseshiftleft/sjcl/issues/143","number":143,"state":"closed","title":"CommonJS environment handling","user":{"login":"fluidblue","id":3339416,"avatar_url":"https://gravatar.com/avatar/dc14b6d614e75131fc300c591069da61?d=https%3A%2F%2Fidenticons.github.com%2F19ad1155dbe2db2696419c3908afb7ee.png&r=x","gravatar_id":"dc14b6d614e75131fc300c591069da61","url":"https://api.github.com/users/fluidblue","html_url":"https://github.com/fluidblue","followers_url":"https://api.github.com/users/fluidblue/followers","following_url":"https://api.github.com/users/fluidblue/following{/other_user}","gists_url":"https://api.github.com/users/fluidblue/gists{/gist_id}","starred_url":"https://api.github.com/users/fluidblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fluidblue/subscriptions","organizations_url":"https://api.github.com/users/fluidblue/orgs","repos_url":"https://api.github.com/users/fluidblue/repos","events_url":"https://api.github.com/users/fluidblue/events{/privacy}","received_events_url":"https://api.github.com/users/fluidblue/received_events","type":"User","site_admin":false},"body":"If you are in an environment (*), which uses CommonJS but is not node, the `require('crypto')` call could throw an exception due to the crypto module not being found.\r\n\r\nBy catching (and ignoring) this error, SJCL can proceed to check if it runs in a browser, and use the browser specific functions. (Commits: 9cf239f and 3a2dc35)\r\n\r\n~~Also, handling for node's SlowBuffer byte array has been added. A SlowBuffer byte array is returned from randomBytes function of node's crypto module. Without handling SlowBuffer byte arrays, sjcl cannot use node's randomBytes function. (Commit: 2196f9c)~~\r\n\r\n(*) An example for such an environment is https://github.com/medikoo/modules-webmake/","created_at":"2013-12-02T14:35:29Z","updated_at":"2014-01-26T12:49:45Z","closed_at":"2014-01-26T12:49:45Z","merged_at":"2014-01-26T12:49:45Z","merge_commit_sha":"7b6e65666326502a0089bd55c85b51d71f344270","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bitwiseshiftleft/sjcl/pulls/143/commits","review_comments_url":"https://api.github.com/repos/bitwiseshiftleft/sjcl/pulls/143/comments","review_comment_url":"/repos/bitwiseshiftleft/sjcl/pulls/comments/{number}","comments_url":"https://api.github.com/repos/bitwiseshiftleft/sjcl/issues/143/comments","statuses_url":"https://api.github.com/repos/bitwiseshiftleft/sjcl/statuses/05ccf9c04310a9af5ddd1e4ec4568980243a3dcb","head":{"label":"fluidblue:master","ref":"master","sha":"05ccf9c04310a9af5ddd1e4ec4568980243a3dcb","user":{"login":"fluidblue","id":3339416,"avatar_url":"https://gravatar.com/avatar/dc14b6d614e75131fc300c591069da61?d=https%3A%2F%2Fidenticons.github.com%2F19ad1155dbe2db2696419c3908afb7ee.png&r=x","gravatar_id":"dc14b6d614e75131fc300c591069da61","url":"https://api.github.com/users/fluidblue","html_url":"https://github.com/fluidblue","followers_url":"https://api.github.com/users/fluidblue/followers","following_url":"https://api.github.com/users/fluidblue/following{/other_user}","gists_url":"https://api.github.com/users/fluidblue/gists{/gist_id}","starred_url":"https://api.github.com/users/fluidblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fluidblue/subscriptions","organizations_url":"https://api.github.com/users/fluidblue/orgs","repos_url":"https://api.github.com/users/fluidblue/repos","events_url":"https://api.github.com/users/fluidblue/events{/privacy}","received_events_url":"https://api.github.com/users/fluidblue/received_events","type":"User","site_admin":false},"repo":{"id":14784840,"name":"sjcl","full_name":"fluidblue/sjcl","owner":{"login":"fluidblue","id":3339416,"avatar_url":"https://gravatar.com/avatar/dc14b6d614e75131fc300c591069da61?d=https%3A%2F%2Fidenticons.github.com%2F19ad1155dbe2db2696419c3908afb7ee.png&r=x","gravatar_id":"dc14b6d614e75131fc300c591069da61","url":"https://api.github.com/users/fluidblue","html_url":"https://github.com/fluidblue","followers_url":"https://api.github.com/users/fluidblue/followers","following_url":"https://api.github.com/users/fluidblue/following{/other_user}","gists_url":"https://api.github.com/users/fluidblue/gists{/gist_id}","starred_url":"https://api.github.com/users/fluidblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fluidblue/subscriptions","organizations_url":"https://api.github.com/users/fluidblue/orgs","repos_url":"https://api.github.com/users/fluidblue/repos","events_url":"https://api.github.com/users/fluidblue/events{/privacy}","received_events_url":"https://api.github.com/users/fluidblue/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fluidblue/sjcl","description":"Stanford Javascript Crypto Library","fork":true,"url":"https://api.github.com/repos/fluidblue/sjcl","forks_url":"https://api.github.com/repos/fluidblue/sjcl/forks","keys_url":"https://api.github.com/repos/fluidblue/sjcl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fluidblue/sjcl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fluidblue/sjcl/teams","hooks_url":"https://api.github.com/repos/fluidblue/sjcl/hooks","issue_events_url":"https://api.github.com/repos/fluidblue/sjcl/issues/events{/number}","events_url":"https://api.github.com/repos/fluidblue/sjcl/events","assignees_url":"https://api.github.com/repos/fluidblue/sjcl/assignees{/user}","branches_url":"https://api.github.com/repos/fluidblue/sjcl/branches{/branch}","tags_url":"https://api.github.com/repos/fluidblue/sjcl/tags","blobs_url":"https://api.github.com/repos/fluidblue/sjcl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fluidblue/sjcl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fluidblue/sjcl/git/refs{/sha}","trees_url":"https://api.github.com/repos/fluidblue/sjcl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fluidblue/sjcl/statuses/{sha}","languages_url":"https://api.github.com/repos/fluidblue/sjcl/languages","stargazers_url":"https://api.github.com/repos/fluidblue/sjcl/stargazers","contributors_url":"https://api.github.com/repos/fluidblue/sjcl/contributors","subscribers_url":"https://api.github.com/repos/fluidblue/sjcl/subscribers","subscription_url":"https://api.github.com/repos/fluidblue/sjcl/subscription","commits_url":"https://api.github.com/repos/fluidblue/sjcl/commits{/sha}","git_commits_url":"https://api.github.com/repos/fluidblue/sjcl/git/commits{/sha}","comments_url":"https://api.github.com/repos/fluidblue/sjcl/comments{/number}","issue_comment_url":"https://api.github.com/repos/fluidblue/sjcl/issues/comments/{number}","contents_url":"https://api.github.com/repos/fluidblue/sjcl/contents/{+path}","compare_url":"https://api.github.com/repos/fluidblue/sjcl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fluidblue/sjcl/merges","archive_url":"https://api.github.com/repos/fluidblue/sjcl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fluidblue/sjcl/downloads","issues_url":"https://api.github.com/repos/fluidblue/sjcl/issues{/number}","pulls_url":"https://api.github.com/repos/fluidblue/sjcl/pulls{/number}","milestones_url":"https://api.github.com/repos/fluidblue/sjcl/milestones{/number}","notifications_url":"https://api.github.com/repos/fluidblue/sjcl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fluidblue/sjcl/labels{/name}","releases_url":"https://api.github.com/repos/fluidblue/sjcl/releases{/id}","created_at":"2013-11-28T19:24:20Z","updated_at":"2014-01-26T12:49:45Z","pushed_at":"2014-01-02T23:39:26Z","git_url":"git://github.com/fluidblue/sjcl.git","ssh_url":"git@github.com:fluidblue/sjcl.git","clone_url":"https://github.com/fluidblue/sjcl.git","svn_url":"https://github.com/fluidblue/sjcl","homepage":"http://bitwiseshiftleft.github.com/sjcl/","size":12677,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master","master_branch":"master"}},"base":{"label":"bitwiseshiftleft:master","ref":"master","sha":"84cf149df1769296c75551847e8dbd914c8eeef2","user":{"login":"bitwiseshiftleft","id":288092,"avatar_url":"https://gravatar.com/avatar/68264b9a65f13b3e88b34de0d5f75536?d=https%3A%2F%2Fidenticons.github.com%2F0aaa42aaf56c6c9195baeb6db5929532.png&r=x","gravatar_id":"68264b9a65f13b3e88b34de0d5f75536","url":"https://api.github.com/users/bitwiseshiftleft","html_url":"https://github.com/bitwiseshiftleft","followers_url":"https://api.github.com/users/bitwiseshiftleft/followers","following_url":"https://api.github.com/users/bitwiseshiftleft/following{/other_user}","gists_url":"https://api.github.com/users/bitwiseshiftleft/gists{/gist_id}","starred_url":"https://api.github.com/users/bitwiseshiftleft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitwiseshiftleft/subscriptions","organizations_url":"https://api.github.com/users/bitwiseshiftleft/orgs","repos_url":"https://api.github.com/users/bitwiseshiftleft/repos","events_url":"https://api.github.com/users/bitwiseshiftleft/events{/privacy}","received_events_url":"https://api.github.com/users/bitwiseshiftleft/received_events","type":"User","site_admin":false},"repo":{"id":688208,"name":"sjcl","full_name":"bitwiseshiftleft/sjcl","owner":{"login":"bitwiseshiftleft","id":288092,"avatar_url":"https://gravatar.com/avatar/68264b9a65f13b3e88b34de0d5f75536?d=https%3A%2F%2Fidenticons.github.com%2F0aaa42aaf56c6c9195baeb6db5929532.png&r=x","gravatar_id":"68264b9a65f13b3e88b34de0d5f75536","url":"https://api.github.com/users/bitwiseshiftleft","html_url":"https://github.com/bitwiseshiftleft","followers_url":"https://api.github.com/users/bitwiseshiftleft/followers","following_url":"https://api.github.com/users/bitwiseshiftleft/following{/other_user}","gists_url":"https://api.github.com/users/bitwiseshiftleft/gists{/gist_id}","starred_url":"https://api.github.com/users/bitwiseshiftleft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitwiseshiftleft/subscriptions","organizations_url":"https://api.github.com/users/bitwiseshiftleft/orgs","repos_url":"https://api.github.com/users/bitwiseshiftleft/repos","events_url":"https://api.github.com/users/bitwiseshiftleft/events{/privacy}","received_events_url":"https://api.github.com/users/bitwiseshiftleft/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bitwiseshiftleft/sjcl","description":"Stanford Javascript Crypto Library","fork":false,"url":"https://api.github.com/repos/bitwiseshiftleft/sjcl","forks_url":"https://api.github.com/repos/bitwiseshiftleft/sjcl/forks","keys_url":"https://api.github.com/repos/bitwiseshiftleft/sjcl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitwiseshiftleft/sjcl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitwiseshiftleft/sjcl/teams","hooks_url":"https://api.github.com/repos/bitwiseshiftleft/sjcl/hooks","issue_events_url":"https://api.github.com/repos/bitwiseshiftleft/sjcl/issues/events{/number}","events_url":"https://api.github.com/repos/bitwiseshiftleft/sjcl/events","assignees_url":"https://api.github.com/repos/bitwiseshiftleft/sjcl/assignees{/user}","branches_url":"https://api.github.com/repos/bitwiseshiftleft/sjcl/branches{/branch}","tags_url":"https://api.github.com/repos/bitwiseshiftleft/sjcl/tags","blobs_url":"https://api.github.com/repos/bitwiseshiftleft/sjcl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitwiseshiftleft/sjcl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitwiseshiftleft/sjcl/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitwiseshiftleft/sjcl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitwiseshiftleft/sjcl/statuses/{sha}","languages_url":"https://api.github.com/repos/bitwiseshiftleft/sjcl/languages","stargazers_url":"https://api.github.com/repos/bitwiseshiftleft/sjcl/stargazers","contributors_url":"https://api.github.com/repos/bitwiseshiftleft/sjcl/contributors","subscribers_url":"https://api.github.com/repos/bitwiseshiftleft/sjcl/subscribers","subscription_url":"https://api.github.com/repos/bitwiseshiftleft/sjcl/subscription","commits_url":"https://api.github.com/repos/bitwiseshiftleft/sjcl/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitwiseshiftleft/sjcl/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitwiseshiftleft/sjcl/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitwiseshiftleft/sjcl/issues/comments/{number}","contents_url":"https://api.github.com/repos/bitwiseshiftleft/sjcl/contents/{+path}","compare_url":"https://api.github.com/repos/bitwiseshiftleft/sjcl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitwiseshiftleft/sjcl/merges","archive_url":"https://api.github.com/repos/bitwiseshiftleft/sjcl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitwiseshiftleft/sjcl/downloads","issues_url":"https://api.github.com/repos/bitwiseshiftleft/sjcl/issues{/number}","pulls_url":"https://api.github.com/repos/bitwiseshiftleft/sjcl/pulls{/number}","milestones_url":"https://api.github.com/repos/bitwiseshiftleft/sjcl/milestones{/number}","notifications_url":"https://api.github.com/repos/bitwiseshiftleft/sjcl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitwiseshiftleft/sjcl/labels{/name}","releases_url":"https://api.github.com/repos/bitwiseshiftleft/sjcl/releases{/id}","created_at":"2010-05-26T22:12:06Z","updated_at":"2014-01-26T12:49:45Z","pushed_at":"2014-01-26T12:49:45Z","git_url":"git://github.com/bitwiseshiftleft/sjcl.git","ssh_url":"git@github.com:bitwiseshiftleft/sjcl.git","clone_url":"https://github.com/bitwiseshiftleft/sjcl.git","svn_url":"https://github.com/bitwiseshiftleft/sjcl","homepage":"http://bitwiseshiftleft.github.com/sjcl/","size":14173,"stargazers_count":1916,"watchers_count":1916,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":243,"mirror_url":null,"open_issues_count":36,"forks":243,"open_issues":36,"watchers":1916,"default_branch":"master","master_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitwiseshiftleft/sjcl/pulls/143"},"html":{"href":"https://github.com/bitwiseshiftleft/sjcl/pull/143"},"issue":{"href":"https://api.github.com/repos/bitwiseshiftleft/sjcl/issues/143"},"comments":{"href":"https://api.github.com/repos/bitwiseshiftleft/sjcl/issues/143/comments"},"review_comments":{"href":"https://api.github.com/repos/bitwiseshiftleft/sjcl/pulls/143/comments"},"commits":{"href":"https://api.github.com/repos/bitwiseshiftleft/sjcl/pulls/143/commits"},"statuses":{"href":"https://api.github.com/repos/bitwiseshiftleft/sjcl/statuses/05ccf9c04310a9af5ddd1e4ec4568980243a3dcb"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"Nilos","id":1300836,"avatar_url":"https://gravatar.com/avatar/f878718dad1ea1b62e58de0b29f3aba6?d=https%3A%2F%2Fidenticons.github.com%2Fdaa7218cb1ac1d2d6c25610c0cb5814d.png&r=x","gravatar_id":"f878718dad1ea1b62e58de0b29f3aba6","url":"https://api.github.com/users/Nilos","html_url":"https://github.com/Nilos","followers_url":"https://api.github.com/users/Nilos/followers","following_url":"https://api.github.com/users/Nilos/following{/other_user}","gists_url":"https://api.github.com/users/Nilos/gists{/gist_id}","starred_url":"https://api.github.com/users/Nilos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nilos/subscriptions","organizations_url":"https://api.github.com/users/Nilos/orgs","repos_url":"https://api.github.com/users/Nilos/repos","events_url":"https://api.github.com/users/Nilos/events{/privacy}","received_events_url":"https://api.github.com/users/Nilos/received_events","type":"User","site_admin":false},"comments":8,"review_comments":1,"commits":7,"additions":12,"deletions":55,"changed_files":2}}