GitHub PullRequestReviewCommentEvent at 2014-06-11 08:56:53
Repository: rails
Actor: senny
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/rails/rails/pulls/comments/13639488","id":13639488,"diff_hunk":"@@ -32,6 +32,15 @@ def register_template_handler(*extensions, handler)\n         @@template_extensions = nil\n       end\n \n+      # Opposite to register_template_handler.\n+      def unregister_template_handler(*extensions)","path":"actionview/lib/action_view/template/handlers.rb","position":5,"original_position":5,"commit_id":"8ea2ef9bb6191989537e08bbff82beafd458f120","original_commit_id":"56276347ab5465c76e651c9abf0b9a9b9d8324f1","user":{"login":"senny","id":5402,"avatar_url":"https://avatars.githubusercontent.com/u/5402?","gravatar_id":"3d698e2872c07061a455d9e250861235","url":"https://api.github.com/users/senny","html_url":"https://github.com/senny","followers_url":"https://api.github.com/users/senny/followers","following_url":"https://api.github.com/users/senny/following{/other_user}","gists_url":"https://api.github.com/users/senny/gists{/gist_id}","starred_url":"https://api.github.com/users/senny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/senny/subscriptions","organizations_url":"https://api.github.com/users/senny/orgs","repos_url":"https://api.github.com/users/senny/repos","events_url":"https://api.github.com/users/senny/events{/privacy}","received_events_url":"https://api.github.com/users/senny/received_events","type":"User","site_admin":false},"body":"I think we can make this public.","created_at":"2014-06-11T08:56:53Z","updated_at":"2014-06-11T08:56:53Z","html_url":"https://github.com/rails/rails/pull/15590#discussion_r13639488","pull_request_url":"https://api.github.com/repos/rails/rails/pulls/15590","_links":{"self":{"href":"https://api.github.com/repos/rails/rails/pulls/comments/13639488"},"html":{"href":"https://github.com/rails/rails/pull/15590#discussion_r13639488"},"pull_request":{"href":"https://api.github.com/repos/rails/rails/pulls/15590"}}},"pull_request":{"url":"https://api.github.com/repos/rails/rails/pulls/15590","id":16888787,"html_url":"https://github.com/rails/rails/pull/15590","diff_url":"https://github.com/rails/rails/pull/15590.diff","patch_url":"https://github.com/rails/rails/pull/15590.patch","issue_url":"https://api.github.com/repos/rails/rails/issues/15590","number":15590,"state":"open","title":"Add unregister_template_handler to prevent leaks.","user":{"login":"zuhao","id":681699,"avatar_url":"https://avatars.githubusercontent.com/u/681699?","gravatar_id":"e4c12368045d04c273abd28c4d54fb0e","url":"https://api.github.com/users/zuhao","html_url":"https://github.com/zuhao","followers_url":"https://api.github.com/users/zuhao/followers","following_url":"https://api.github.com/users/zuhao/following{/other_user}","gists_url":"https://api.github.com/users/zuhao/gists{/gist_id}","starred_url":"https://api.github.com/users/zuhao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zuhao/subscriptions","organizations_url":"https://api.github.com/users/zuhao/orgs","repos_url":"https://api.github.com/users/zuhao/repos","events_url":"https://api.github.com/users/zuhao/events{/privacy}","received_events_url":"https://api.github.com/users/zuhao/received_events","type":"User","site_admin":false},"body":"A few places in the test codebase had `ActionView::Template.register_template_handler`, but the handlers were not removed after the tests.\r\n\r\nThis patch adds a new method `unregister_template_handler` to `ActionView::Template::Handlers`, and makes sure related tests are cleaned up properly.\r\n\r\ncc @senny","created_at":"2014-06-09T14:53:15Z","updated_at":"2014-06-11T08:56:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ddc7820f20dfbf57004c8ee8155850bfe9c037fd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rails/rails/pulls/15590/commits","review_comments_url":"https://api.github.com/repos/rails/rails/pulls/15590/comments","review_comment_url":"https://api.github.com/repos/rails/rails/pulls/comments/{number}","comments_url":"https://api.github.com/repos/rails/rails/issues/15590/comments","statuses_url":"https://api.github.com/repos/rails/rails/statuses/8ea2ef9bb6191989537e08bbff82beafd458f120","head":{"label":"zuhao:refactor_actionview_register_template_handler","ref":"refactor_actionview_register_template_handler","sha":"8ea2ef9bb6191989537e08bbff82beafd458f120","user":{"login":"zuhao","id":681699,"avatar_url":"https://avatars.githubusercontent.com/u/681699?","gravatar_id":"e4c12368045d04c273abd28c4d54fb0e","url":"https://api.github.com/users/zuhao","html_url":"https://github.com/zuhao","followers_url":"https://api.github.com/users/zuhao/followers","following_url":"https://api.github.com/users/zuhao/following{/other_user}","gists_url":"https://api.github.com/users/zuhao/gists{/gist_id}","starred_url":"https://api.github.com/users/zuhao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zuhao/subscriptions","organizations_url":"https://api.github.com/users/zuhao/orgs","repos_url":"https://api.github.com/users/zuhao/repos","events_url":"https://api.github.com/users/zuhao/events{/privacy}","received_events_url":"https://api.github.com/users/zuhao/received_events","type":"User","site_admin":false},"repo":{"id":17522436,"name":"rails","full_name":"zuhao/rails","owner":{"login":"zuhao","id":681699,"avatar_url":"https://avatars.githubusercontent.com/u/681699?","gravatar_id":"e4c12368045d04c273abd28c4d54fb0e","url":"https://api.github.com/users/zuhao","html_url":"https://github.com/zuhao","followers_url":"https://api.github.com/users/zuhao/followers","following_url":"https://api.github.com/users/zuhao/following{/other_user}","gists_url":"https://api.github.com/users/zuhao/gists{/gist_id}","starred_url":"https://api.github.com/users/zuhao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zuhao/subscriptions","organizations_url":"https://api.github.com/users/zuhao/orgs","repos_url":"https://api.github.com/users/zuhao/repos","events_url":"https://api.github.com/users/zuhao/events{/privacy}","received_events_url":"https://api.github.com/users/zuhao/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zuhao/rails","description":"Ruby on Rails","fork":true,"url":"https://api.github.com/repos/zuhao/rails","forks_url":"https://api.github.com/repos/zuhao/rails/forks","keys_url":"https://api.github.com/repos/zuhao/rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zuhao/rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zuhao/rails/teams","hooks_url":"https://api.github.com/repos/zuhao/rails/hooks","issue_events_url":"https://api.github.com/repos/zuhao/rails/issues/events{/number}","events_url":"https://api.github.com/repos/zuhao/rails/events","assignees_url":"https://api.github.com/repos/zuhao/rails/assignees{/user}","branches_url":"https://api.github.com/repos/zuhao/rails/branches{/branch}","tags_url":"https://api.github.com/repos/zuhao/rails/tags","blobs_url":"https://api.github.com/repos/zuhao/rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zuhao/rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zuhao/rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/zuhao/rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zuhao/rails/statuses/{sha}","languages_url":"https://api.github.com/repos/zuhao/rails/languages","stargazers_url":"https://api.github.com/repos/zuhao/rails/stargazers","contributors_url":"https://api.github.com/repos/zuhao/rails/contributors","subscribers_url":"https://api.github.com/repos/zuhao/rails/subscribers","subscription_url":"https://api.github.com/repos/zuhao/rails/subscription","commits_url":"https://api.github.com/repos/zuhao/rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/zuhao/rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/zuhao/rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/zuhao/rails/issues/comments/{number}","contents_url":"https://api.github.com/repos/zuhao/rails/contents/{+path}","compare_url":"https://api.github.com/repos/zuhao/rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zuhao/rails/merges","archive_url":"https://api.github.com/repos/zuhao/rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zuhao/rails/downloads","issues_url":"https://api.github.com/repos/zuhao/rails/issues{/number}","pulls_url":"https://api.github.com/repos/zuhao/rails/pulls{/number}","milestones_url":"https://api.github.com/repos/zuhao/rails/milestones{/number}","notifications_url":"https://api.github.com/repos/zuhao/rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zuhao/rails/labels{/name}","releases_url":"https://api.github.com/repos/zuhao/rails/releases{/id}","created_at":"2014-03-07T17:56:09Z","updated_at":"2014-06-10T12:19:17Z","pushed_at":"2014-06-10T12:19:18Z","git_url":"git://github.com/zuhao/rails.git","ssh_url":"git@github.com:zuhao/rails.git","clone_url":"https://github.com/zuhao/rails.git","svn_url":"https://github.com/zuhao/rails","homepage":"http://rubyonrails.org","size":113153,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rails:master","ref":"master","sha":"4b8d0b803f454058eb363a101b512b98e4ec198d","user":{"login":"rails","id":4223,"avatar_url":"https://avatars.githubusercontent.com/u/4223?","gravatar_id":"30f39a09e233e8369dddf6feb4be0308","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"repo":{"id":8514,"name":"rails","full_name":"rails/rails","owner":{"login":"rails","id":4223,"avatar_url":"https://avatars.githubusercontent.com/u/4223?","gravatar_id":"30f39a09e233e8369dddf6feb4be0308","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rails/rails","description":"Ruby on Rails","fork":false,"url":"https://api.github.com/repos/rails/rails","forks_url":"https://api.github.com/repos/rails/rails/forks","keys_url":"https://api.github.com/repos/rails/rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rails/rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rails/rails/teams","hooks_url":"https://api.github.com/repos/rails/rails/hooks","issue_events_url":"https://api.github.com/repos/rails/rails/issues/events{/number}","events_url":"https://api.github.com/repos/rails/rails/events","assignees_url":"https://api.github.com/repos/rails/rails/assignees{/user}","branches_url":"https://api.github.com/repos/rails/rails/branches{/branch}","tags_url":"https://api.github.com/repos/rails/rails/tags","blobs_url":"https://api.github.com/repos/rails/rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rails/rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rails/rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/rails/rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rails/rails/statuses/{sha}","languages_url":"https://api.github.com/repos/rails/rails/languages","stargazers_url":"https://api.github.com/repos/rails/rails/stargazers","contributors_url":"https://api.github.com/repos/rails/rails/contributors","subscribers_url":"https://api.github.com/repos/rails/rails/subscribers","subscription_url":"https://api.github.com/repos/rails/rails/subscription","commits_url":"https://api.github.com/repos/rails/rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/rails/rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/rails/rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/rails/rails/issues/comments/{number}","contents_url":"https://api.github.com/repos/rails/rails/contents/{+path}","compare_url":"https://api.github.com/repos/rails/rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rails/rails/merges","archive_url":"https://api.github.com/repos/rails/rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rails/rails/downloads","issues_url":"https://api.github.com/repos/rails/rails/issues{/number}","pulls_url":"https://api.github.com/repos/rails/rails/pulls{/number}","milestones_url":"https://api.github.com/repos/rails/rails/milestones{/number}","notifications_url":"https://api.github.com/repos/rails/rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rails/rails/labels{/name}","releases_url":"https://api.github.com/repos/rails/rails/releases{/id}","created_at":"2008-04-11T02:19:47Z","updated_at":"2014-06-11T08:52:30Z","pushed_at":"2014-06-11T07:05:36Z","git_url":"git://github.com/rails/rails.git","ssh_url":"git@github.com:rails/rails.git","clone_url":"https://github.com/rails/rails.git","svn_url":"https://github.com/rails/rails","homepage":"http://rubyonrails.org","size":316603,"stargazers_count":22106,"watchers_count":22106,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":8195,"mirror_url":null,"open_issues_count":620,"forks":8195,"open_issues":620,"watchers":22106,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rails/rails/pulls/15590"},"html":{"href":"https://github.com/rails/rails/pull/15590"},"issue":{"href":"https://api.github.com/repos/rails/rails/issues/15590"},"comments":{"href":"https://api.github.com/repos/rails/rails/issues/15590/comments"},"review_comments":{"href":"https://api.github.com/repos/rails/rails/pulls/15590/comments"},"review_comment":{"href":"https://api.github.com/repos/rails/rails/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/rails/rails/pulls/15590/commits"},"statuses":{"href":"https://api.github.com/repos/rails/rails/statuses/8ea2ef9bb6191989537e08bbff82beafd458f120"}}}}