GitHub PullRequestReviewCommentEvent at 2014-07-21 17:39:20
Repository: montage
Actor: 3on
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/montagejs/montage/pulls/comments/15183112","id":15183112,"diff_hunk":"@@ -762,7 +762,9 @@ var KeyManager = exports.KeyManager = Montage.specialize(/** @lends KeyManager#\n                     if (keyDown) {\n                         // Reset trigger\n                         delete this._triggeredKeys[keyComposer.uuid];\n-                        event.preventDefault();\n+                        if (event.defaultPrevented) {","path":"core/event/key-manager.js","position":5,"original_position":5,"commit_id":"e1087b513d597c296a33de40a8f44d20722e94a3","original_commit_id":"e1087b513d597c296a33de40a8f44d20722e94a3","user":{"login":"3on","id":1082113,"avatar_url":"https://avatars.githubusercontent.com/u/1082113?","gravatar_id":"70e25135551ebe5937a2508b2861c4ef","url":"https://api.github.com/users/3on","html_url":"https://github.com/3on","followers_url":"https://api.github.com/users/3on/followers","following_url":"https://api.github.com/users/3on/following{/other_user}","gists_url":"https://api.github.com/users/3on/gists{/gist_id}","starred_url":"https://api.github.com/users/3on/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/3on/subscriptions","organizations_url":"https://api.github.com/users/3on/orgs","repos_url":"https://api.github.com/users/3on/repos","events_url":"https://api.github.com/users/3on/events{/privacy}","received_events_url":"https://api.github.com/users/3on/received_events","type":"User","site_admin":false},"body":"I was pretty sure is was useless.\r\nWe might never want to `preventDefault()` IMO but we surely DO NOT want to `preventDefault()` buy default.","created_at":"2014-07-21T17:39:20Z","updated_at":"2014-07-21T17:39:20Z","html_url":"https://github.com/montagejs/montage/pull/1481#discussion_r15183112","pull_request_url":"https://api.github.com/repos/montagejs/montage/pulls/1481","_links":{"self":{"href":"https://api.github.com/repos/montagejs/montage/pulls/comments/15183112"},"html":{"href":"https://github.com/montagejs/montage/pull/1481#discussion_r15183112"},"pull_request":{"href":"https://api.github.com/repos/montagejs/montage/pulls/1481"}}},"pull_request":{"url":"https://api.github.com/repos/montagejs/montage/pulls/1481","id":16975386,"html_url":"https://github.com/montagejs/montage/pull/1481","diff_url":"https://github.com/montagejs/montage/pull/1481.diff","patch_url":"https://github.com/montagejs/montage/pull/1481.patch","issue_url":"https://api.github.com/repos/montagejs/montage/issues/1481","number":1481,"state":"open","title":"Prevent preventDefault from always being executed.","user":{"login":"3on","id":1082113,"avatar_url":"https://avatars.githubusercontent.com/u/1082113?","gravatar_id":"70e25135551ebe5937a2508b2861c4ef","url":"https://api.github.com/users/3on","html_url":"https://github.com/3on","followers_url":"https://api.github.com/users/3on/followers","following_url":"https://api.github.com/users/3on/following{/other_user}","gists_url":"https://api.github.com/users/3on/gists{/gist_id}","starred_url":"https://api.github.com/users/3on/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/3on/subscriptions","organizations_url":"https://api.github.com/users/3on/orgs","repos_url":"https://api.github.com/users/3on/repos","events_url":"https://api.github.com/users/3on/events{/privacy}","received_events_url":"https://api.github.com/users/3on/received_events","type":"User","site_admin":false},"body":"I can't find any tests for the `KeyManager`.","created_at":"2014-06-11T01:32:09Z","updated_at":"2014-07-21T17:39:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f058545c4f5a3b1363c93988a00e94693ae9e881","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/montagejs/montage/pulls/1481/commits","review_comments_url":"https://api.github.com/repos/montagejs/montage/pulls/1481/comments","review_comment_url":"https://api.github.com/repos/montagejs/montage/pulls/comments/{number}","comments_url":"https://api.github.com/repos/montagejs/montage/issues/1481/comments","statuses_url":"https://api.github.com/repos/montagejs/montage/statuses/e1087b513d597c296a33de40a8f44d20722e94a3","head":{"label":"3on:key-manager-prevent-default","ref":"key-manager-prevent-default","sha":"e1087b513d597c296a33de40a8f44d20722e94a3","user":{"login":"3on","id":1082113,"avatar_url":"https://avatars.githubusercontent.com/u/1082113?","gravatar_id":"70e25135551ebe5937a2508b2861c4ef","url":"https://api.github.com/users/3on","html_url":"https://github.com/3on","followers_url":"https://api.github.com/users/3on/followers","following_url":"https://api.github.com/users/3on/following{/other_user}","gists_url":"https://api.github.com/users/3on/gists{/gist_id}","starred_url":"https://api.github.com/users/3on/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/3on/subscriptions","organizations_url":"https://api.github.com/users/3on/orgs","repos_url":"https://api.github.com/users/3on/repos","events_url":"https://api.github.com/users/3on/events{/privacy}","received_events_url":"https://api.github.com/users/3on/received_events","type":"User","site_admin":false},"repo":{"id":12465587,"name":"montage","full_name":"3on/montage","owner":{"login":"3on","id":1082113,"avatar_url":"https://avatars.githubusercontent.com/u/1082113?","gravatar_id":"70e25135551ebe5937a2508b2861c4ef","url":"https://api.github.com/users/3on","html_url":"https://github.com/3on","followers_url":"https://api.github.com/users/3on/followers","following_url":"https://api.github.com/users/3on/following{/other_user}","gists_url":"https://api.github.com/users/3on/gists{/gist_id}","starred_url":"https://api.github.com/users/3on/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/3on/subscriptions","organizations_url":"https://api.github.com/users/3on/orgs","repos_url":"https://api.github.com/users/3on/repos","events_url":"https://api.github.com/users/3on/events{/privacy}","received_events_url":"https://api.github.com/users/3on/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/3on/montage","description":"Core framework: Montage simplifies the development of rich HTML5 applications by providing modular components, real-time two-way data binding, CommonJS dependency management, and many more conveniences. Join us on irc.freenode.net#montage or https://groups.google.com/d/forum/montagejs","fork":true,"url":"https://api.github.com/repos/3on/montage","forks_url":"https://api.github.com/repos/3on/montage/forks","keys_url":"https://api.github.com/repos/3on/montage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/3on/montage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/3on/montage/teams","hooks_url":"https://api.github.com/repos/3on/montage/hooks","issue_events_url":"https://api.github.com/repos/3on/montage/issues/events{/number}","events_url":"https://api.github.com/repos/3on/montage/events","assignees_url":"https://api.github.com/repos/3on/montage/assignees{/user}","branches_url":"https://api.github.com/repos/3on/montage/branches{/branch}","tags_url":"https://api.github.com/repos/3on/montage/tags","blobs_url":"https://api.github.com/repos/3on/montage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/3on/montage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/3on/montage/git/refs{/sha}","trees_url":"https://api.github.com/repos/3on/montage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/3on/montage/statuses/{sha}","languages_url":"https://api.github.com/repos/3on/montage/languages","stargazers_url":"https://api.github.com/repos/3on/montage/stargazers","contributors_url":"https://api.github.com/repos/3on/montage/contributors","subscribers_url":"https://api.github.com/repos/3on/montage/subscribers","subscription_url":"https://api.github.com/repos/3on/montage/subscription","commits_url":"https://api.github.com/repos/3on/montage/commits{/sha}","git_commits_url":"https://api.github.com/repos/3on/montage/git/commits{/sha}","comments_url":"https://api.github.com/repos/3on/montage/comments{/number}","issue_comment_url":"https://api.github.com/repos/3on/montage/issues/comments/{number}","contents_url":"https://api.github.com/repos/3on/montage/contents/{+path}","compare_url":"https://api.github.com/repos/3on/montage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/3on/montage/merges","archive_url":"https://api.github.com/repos/3on/montage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/3on/montage/downloads","issues_url":"https://api.github.com/repos/3on/montage/issues{/number}","pulls_url":"https://api.github.com/repos/3on/montage/pulls{/number}","milestones_url":"https://api.github.com/repos/3on/montage/milestones{/number}","notifications_url":"https://api.github.com/repos/3on/montage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/3on/montage/labels{/name}","releases_url":"https://api.github.com/repos/3on/montage/releases{/id}","created_at":"2013-08-29T16:38:51Z","updated_at":"2014-06-11T01:32:09Z","pushed_at":"2014-06-11T01:31:44Z","git_url":"git://github.com/3on/montage.git","ssh_url":"git@github.com:3on/montage.git","clone_url":"https://github.com/3on/montage.git","svn_url":"https://github.com/3on/montage","homepage":"http://montagejs.org","size":24543,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"montagejs:master","ref":"master","sha":"4b9823ad05ad21db9f923117729362190f1211d0","user":{"login":"montagejs","id":2008799,"avatar_url":"https://avatars.githubusercontent.com/u/2008799?","gravatar_id":"69659acb737b7f03cf547f8661687c50","url":"https://api.github.com/users/montagejs","html_url":"https://github.com/montagejs","followers_url":"https://api.github.com/users/montagejs/followers","following_url":"https://api.github.com/users/montagejs/following{/other_user}","gists_url":"https://api.github.com/users/montagejs/gists{/gist_id}","starred_url":"https://api.github.com/users/montagejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/montagejs/subscriptions","organizations_url":"https://api.github.com/users/montagejs/orgs","repos_url":"https://api.github.com/users/montagejs/repos","events_url":"https://api.github.com/users/montagejs/events{/privacy}","received_events_url":"https://api.github.com/users/montagejs/received_events","type":"Organization","site_admin":false},"repo":{"id":2943911,"name":"montage","full_name":"montagejs/montage","owner":{"login":"montagejs","id":2008799,"avatar_url":"https://avatars.githubusercontent.com/u/2008799?","gravatar_id":"69659acb737b7f03cf547f8661687c50","url":"https://api.github.com/users/montagejs","html_url":"https://github.com/montagejs","followers_url":"https://api.github.com/users/montagejs/followers","following_url":"https://api.github.com/users/montagejs/following{/other_user}","gists_url":"https://api.github.com/users/montagejs/gists{/gist_id}","starred_url":"https://api.github.com/users/montagejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/montagejs/subscriptions","organizations_url":"https://api.github.com/users/montagejs/orgs","repos_url":"https://api.github.com/users/montagejs/repos","events_url":"https://api.github.com/users/montagejs/events{/privacy}","received_events_url":"https://api.github.com/users/montagejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/montagejs/montage","description":"MontageJS is an elegant, open source HTML5 framework maintained by Montage Studio that rivals native SDKs, yet is easier to learn. It offers modular components, two-way data binding, and much more. Join us on irc.freenode.net#montage. Sign up for our beta to build MontageJS applications in the cloud.","fork":false,"url":"https://api.github.com/repos/montagejs/montage","forks_url":"https://api.github.com/repos/montagejs/montage/forks","keys_url":"https://api.github.com/repos/montagejs/montage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/montagejs/montage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/montagejs/montage/teams","hooks_url":"https://api.github.com/repos/montagejs/montage/hooks","issue_events_url":"https://api.github.com/repos/montagejs/montage/issues/events{/number}","events_url":"https://api.github.com/repos/montagejs/montage/events","assignees_url":"https://api.github.com/repos/montagejs/montage/assignees{/user}","branches_url":"https://api.github.com/repos/montagejs/montage/branches{/branch}","tags_url":"https://api.github.com/repos/montagejs/montage/tags","blobs_url":"https://api.github.com/repos/montagejs/montage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/montagejs/montage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/montagejs/montage/git/refs{/sha}","trees_url":"https://api.github.com/repos/montagejs/montage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/montagejs/montage/statuses/{sha}","languages_url":"https://api.github.com/repos/montagejs/montage/languages","stargazers_url":"https://api.github.com/repos/montagejs/montage/stargazers","contributors_url":"https://api.github.com/repos/montagejs/montage/contributors","subscribers_url":"https://api.github.com/repos/montagejs/montage/subscribers","subscription_url":"https://api.github.com/repos/montagejs/montage/subscription","commits_url":"https://api.github.com/repos/montagejs/montage/commits{/sha}","git_commits_url":"https://api.github.com/repos/montagejs/montage/git/commits{/sha}","comments_url":"https://api.github.com/repos/montagejs/montage/comments{/number}","issue_comment_url":"https://api.github.com/repos/montagejs/montage/issues/comments/{number}","contents_url":"https://api.github.com/repos/montagejs/montage/contents/{+path}","compare_url":"https://api.github.com/repos/montagejs/montage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/montagejs/montage/merges","archive_url":"https://api.github.com/repos/montagejs/montage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/montagejs/montage/downloads","issues_url":"https://api.github.com/repos/montagejs/montage/issues{/number}","pulls_url":"https://api.github.com/repos/montagejs/montage/pulls{/number}","milestones_url":"https://api.github.com/repos/montagejs/montage/milestones{/number}","notifications_url":"https://api.github.com/repos/montagejs/montage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/montagejs/montage/labels{/name}","releases_url":"https://api.github.com/repos/montagejs/montage/releases{/id}","created_at":"2011-12-08T23:18:21Z","updated_at":"2014-07-17T16:03:30Z","pushed_at":"2014-07-18T22:05:16Z","git_url":"git://github.com/montagejs/montage.git","ssh_url":"git@github.com:montagejs/montage.git","clone_url":"https://github.com/montagejs/montage.git","svn_url":"https://github.com/montagejs/montage","homepage":"http://montagestudio.com/montagejs","size":37991,"stargazers_count":1180,"watchers_count":1180,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":157,"mirror_url":null,"open_issues_count":70,"forks":157,"open_issues":70,"watchers":1180,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/montagejs/montage/pulls/1481"},"html":{"href":"https://github.com/montagejs/montage/pull/1481"},"issue":{"href":"https://api.github.com/repos/montagejs/montage/issues/1481"},"comments":{"href":"https://api.github.com/repos/montagejs/montage/issues/1481/comments"},"review_comments":{"href":"https://api.github.com/repos/montagejs/montage/pulls/1481/comments"},"review_comment":{"href":"https://api.github.com/repos/montagejs/montage/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/montagejs/montage/pulls/1481/commits"},"statuses":{"href":"https://api.github.com/repos/montagejs/montage/statuses/e1087b513d597c296a33de40a8f44d20722e94a3"}}}}