GitHub PullRequestReviewCommentEvent at 2014-10-31 16:08:10
Repository: infinispan
Actor: tristantarrant
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/infinispan/infinispan/pulls/comments/19675866","id":19675866,"diff_hunk":"@@ -50,7 +50,11 @@ public boolean needsCredentials() {\n    @Override\n    public void connect(String credentials) throws Exception {\n       JMXServiceURL url = new JMXServiceURL(serviceUrl.getJMXServiceURL());\n-      jmxConnector = JMXConnectorFactory.connect(url, serviceUrl.getConnectionEnvironment(credentials));\n+      try {\n+         jmxConnector = JMXConnectorFactory.connect(url, serviceUrl.getConnectionEnvironment(credentials));\n+      } catch (Throwable t) {","path":"cli/cli-client/src/main/java/org/infinispan/cli/connection/jmx/JMXConnection.java","position":7,"original_position":7,"commit_id":"b54ad5f22cdf964fa10f20253d25e634e690e6b0","original_commit_id":"b54ad5f22cdf964fa10f20253d25e634e690e6b0","user":{"login":"tristantarrant","id":392478,"avatar_url":"https://avatars.githubusercontent.com/u/392478?v=2","gravatar_id":"","url":"https://api.github.com/users/tristantarrant","html_url":"https://github.com/tristantarrant","followers_url":"https://api.github.com/users/tristantarrant/followers","following_url":"https://api.github.com/users/tristantarrant/following{/other_user}","gists_url":"https://api.github.com/users/tristantarrant/gists{/gist_id}","starred_url":"https://api.github.com/users/tristantarrant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tristantarrant/subscriptions","organizations_url":"https://api.github.com/users/tristantarrant/orgs","repos_url":"https://api.github.com/users/tristantarrant/repos","events_url":"https://api.github.com/users/tristantarrant/events{/privacy}","received_events_url":"https://api.github.com/users/tristantarrant/received_events","type":"User","site_admin":false},"body":"Because the stupid JMXConnectorFactory throws Errors in some cases not just Exceptions","created_at":"2014-10-31T16:08:10Z","updated_at":"2014-10-31T16:08:10Z","html_url":"https://github.com/infinispan/infinispan/pull/3029#discussion_r19675866","pull_request_url":"https://api.github.com/repos/infinispan/infinispan/pulls/3029","_links":{"self":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/comments/19675866"},"html":{"href":"https://github.com/infinispan/infinispan/pull/3029#discussion_r19675866"},"pull_request":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/3029"}}},"pull_request":{"url":"https://api.github.com/repos/infinispan/infinispan/pulls/3029","id":23684676,"html_url":"https://github.com/infinispan/infinispan/pull/3029","diff_url":"https://github.com/infinispan/infinispan/pull/3029.diff","patch_url":"https://github.com/infinispan/infinispan/pull/3029.patch","issue_url":"https://api.github.com/repos/infinispan/infinispan/issues/3029","number":3029,"state":"open","locked":false,"title":"ISPN-4442 Package JMX Remoting and XNio libraries in embedded CLI ","user":{"login":"tristantarrant","id":392478,"avatar_url":"https://avatars.githubusercontent.com/u/392478?v=2","gravatar_id":"","url":"https://api.github.com/users/tristantarrant","html_url":"https://github.com/tristantarrant","followers_url":"https://api.github.com/users/tristantarrant/followers","following_url":"https://api.github.com/users/tristantarrant/following{/other_user}","gists_url":"https://api.github.com/users/tristantarrant/gists{/gist_id}","starred_url":"https://api.github.com/users/tristantarrant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tristantarrant/subscriptions","organizations_url":"https://api.github.com/users/tristantarrant/orgs","repos_url":"https://api.github.com/users/tristantarrant/repos","events_url":"https://api.github.com/users/tristantarrant/events{/privacy}","received_events_url":"https://api.github.com/users/tristantarrant/received_events","type":"User","site_admin":false},"body":"ISPN-4442 Package JMX Remoting and XNio libraries in embedded CLI so that it can connect to Infinispan instances running in EAP deployments\r\n\r\nhttps://issues.jboss.org/browse/ISPN-4442","created_at":"2014-10-31T15:39:13Z","updated_at":"2014-10-31T16:08:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"89d02315cb8e3b56356aa5ccea1c66b71bf787e5","assignee":null,"milestone":{"url":"https://api.github.com/repos/infinispan/infinispan/milestones/4","labels_url":"https://api.github.com/repos/infinispan/infinispan/milestones/4/labels","id":743063,"number":4,"title":"7.0.0.Final","description":"","creator":{"login":"tristantarrant","id":392478,"avatar_url":"https://avatars.githubusercontent.com/u/392478?v=2","gravatar_id":"","url":"https://api.github.com/users/tristantarrant","html_url":"https://github.com/tristantarrant","followers_url":"https://api.github.com/users/tristantarrant/followers","following_url":"https://api.github.com/users/tristantarrant/following{/other_user}","gists_url":"https://api.github.com/users/tristantarrant/gists{/gist_id}","starred_url":"https://api.github.com/users/tristantarrant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tristantarrant/subscriptions","organizations_url":"https://api.github.com/users/tristantarrant/orgs","repos_url":"https://api.github.com/users/tristantarrant/repos","events_url":"https://api.github.com/users/tristantarrant/events{/privacy}","received_events_url":"https://api.github.com/users/tristantarrant/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":20,"state":"open","created_at":"2014-08-05T05:36:24Z","updated_at":"2014-10-31T16:05:14Z","due_on":"2014-10-30T07:00:00Z"},"commits_url":"https://api.github.com/repos/infinispan/infinispan/pulls/3029/commits","review_comments_url":"https://api.github.com/repos/infinispan/infinispan/pulls/3029/comments","review_comment_url":"https://api.github.com/repos/infinispan/infinispan/pulls/comments/{number}","comments_url":"https://api.github.com/repos/infinispan/infinispan/issues/3029/comments","statuses_url":"https://api.github.com/repos/infinispan/infinispan/statuses/b54ad5f22cdf964fa10f20253d25e634e690e6b0","head":{"label":"tristantarrant:ISPN-4442/embedded_cli_remoting","ref":"ISPN-4442/embedded_cli_remoting","sha":"b54ad5f22cdf964fa10f20253d25e634e690e6b0","user":{"login":"tristantarrant","id":392478,"avatar_url":"https://avatars.githubusercontent.com/u/392478?v=2","gravatar_id":"","url":"https://api.github.com/users/tristantarrant","html_url":"https://github.com/tristantarrant","followers_url":"https://api.github.com/users/tristantarrant/followers","following_url":"https://api.github.com/users/tristantarrant/following{/other_user}","gists_url":"https://api.github.com/users/tristantarrant/gists{/gist_id}","starred_url":"https://api.github.com/users/tristantarrant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tristantarrant/subscriptions","organizations_url":"https://api.github.com/users/tristantarrant/orgs","repos_url":"https://api.github.com/users/tristantarrant/repos","events_url":"https://api.github.com/users/tristantarrant/events{/privacy}","received_events_url":"https://api.github.com/users/tristantarrant/received_events","type":"User","site_admin":false},"repo":{"id":2035565,"name":"infinispan","full_name":"tristantarrant/infinispan","owner":{"login":"tristantarrant","id":392478,"avatar_url":"https://avatars.githubusercontent.com/u/392478?v=2","gravatar_id":"","url":"https://api.github.com/users/tristantarrant","html_url":"https://github.com/tristantarrant","followers_url":"https://api.github.com/users/tristantarrant/followers","following_url":"https://api.github.com/users/tristantarrant/following{/other_user}","gists_url":"https://api.github.com/users/tristantarrant/gists{/gist_id}","starred_url":"https://api.github.com/users/tristantarrant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tristantarrant/subscriptions","organizations_url":"https://api.github.com/users/tristantarrant/orgs","repos_url":"https://api.github.com/users/tristantarrant/repos","events_url":"https://api.github.com/users/tristantarrant/events{/privacy}","received_events_url":"https://api.github.com/users/tristantarrant/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tristantarrant/infinispan","description":"Infinispan is an open source data grid platform and highly scalable NoSQL cloud data store.","fork":true,"url":"https://api.github.com/repos/tristantarrant/infinispan","forks_url":"https://api.github.com/repos/tristantarrant/infinispan/forks","keys_url":"https://api.github.com/repos/tristantarrant/infinispan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tristantarrant/infinispan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tristantarrant/infinispan/teams","hooks_url":"https://api.github.com/repos/tristantarrant/infinispan/hooks","issue_events_url":"https://api.github.com/repos/tristantarrant/infinispan/issues/events{/number}","events_url":"https://api.github.com/repos/tristantarrant/infinispan/events","assignees_url":"https://api.github.com/repos/tristantarrant/infinispan/assignees{/user}","branches_url":"https://api.github.com/repos/tristantarrant/infinispan/branches{/branch}","tags_url":"https://api.github.com/repos/tristantarrant/infinispan/tags","blobs_url":"https://api.github.com/repos/tristantarrant/infinispan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tristantarrant/infinispan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tristantarrant/infinispan/git/refs{/sha}","trees_url":"https://api.github.com/repos/tristantarrant/infinispan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tristantarrant/infinispan/statuses/{sha}","languages_url":"https://api.github.com/repos/tristantarrant/infinispan/languages","stargazers_url":"https://api.github.com/repos/tristantarrant/infinispan/stargazers","contributors_url":"https://api.github.com/repos/tristantarrant/infinispan/contributors","subscribers_url":"https://api.github.com/repos/tristantarrant/infinispan/subscribers","subscription_url":"https://api.github.com/repos/tristantarrant/infinispan/subscription","commits_url":"https://api.github.com/repos/tristantarrant/infinispan/commits{/sha}","git_commits_url":"https://api.github.com/repos/tristantarrant/infinispan/git/commits{/sha}","comments_url":"https://api.github.com/repos/tristantarrant/infinispan/comments{/number}","issue_comment_url":"https://api.github.com/repos/tristantarrant/infinispan/issues/comments/{number}","contents_url":"https://api.github.com/repos/tristantarrant/infinispan/contents/{+path}","compare_url":"https://api.github.com/repos/tristantarrant/infinispan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tristantarrant/infinispan/merges","archive_url":"https://api.github.com/repos/tristantarrant/infinispan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tristantarrant/infinispan/downloads","issues_url":"https://api.github.com/repos/tristantarrant/infinispan/issues{/number}","pulls_url":"https://api.github.com/repos/tristantarrant/infinispan/pulls{/number}","milestones_url":"https://api.github.com/repos/tristantarrant/infinispan/milestones{/number}","notifications_url":"https://api.github.com/repos/tristantarrant/infinispan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tristantarrant/infinispan/labels{/name}","releases_url":"https://api.github.com/repos/tristantarrant/infinispan/releases{/id}","created_at":"2011-07-12T10:59:18Z","updated_at":"2014-06-25T09:10:17Z","pushed_at":"2014-10-31T16:05:09Z","git_url":"git://github.com/tristantarrant/infinispan.git","ssh_url":"git@github.com:tristantarrant/infinispan.git","clone_url":"https://github.com/tristantarrant/infinispan.git","svn_url":"https://github.com/tristantarrant/infinispan","homepage":"http://www.infinispan.org","size":61831,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"infinispan:master","ref":"master","sha":"1eb0052f10002661b95fe642073200e144bff946","user":{"login":"infinispan","id":458093,"avatar_url":"https://avatars.githubusercontent.com/u/458093?v=2","gravatar_id":"","url":"https://api.github.com/users/infinispan","html_url":"https://github.com/infinispan","followers_url":"https://api.github.com/users/infinispan/followers","following_url":"https://api.github.com/users/infinispan/following{/other_user}","gists_url":"https://api.github.com/users/infinispan/gists{/gist_id}","starred_url":"https://api.github.com/users/infinispan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infinispan/subscriptions","organizations_url":"https://api.github.com/users/infinispan/orgs","repos_url":"https://api.github.com/users/infinispan/repos","events_url":"https://api.github.com/users/infinispan/events{/privacy}","received_events_url":"https://api.github.com/users/infinispan/received_events","type":"Organization","site_admin":false},"repo":{"id":1050944,"name":"infinispan","full_name":"infinispan/infinispan","owner":{"login":"infinispan","id":458093,"avatar_url":"https://avatars.githubusercontent.com/u/458093?v=2","gravatar_id":"","url":"https://api.github.com/users/infinispan","html_url":"https://github.com/infinispan","followers_url":"https://api.github.com/users/infinispan/followers","following_url":"https://api.github.com/users/infinispan/following{/other_user}","gists_url":"https://api.github.com/users/infinispan/gists{/gist_id}","starred_url":"https://api.github.com/users/infinispan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infinispan/subscriptions","organizations_url":"https://api.github.com/users/infinispan/orgs","repos_url":"https://api.github.com/users/infinispan/repos","events_url":"https://api.github.com/users/infinispan/events{/privacy}","received_events_url":"https://api.github.com/users/infinispan/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/infinispan/infinispan","description":"Infinispan is an open source data grid platform and highly scalable NoSQL cloud data store.","fork":false,"url":"https://api.github.com/repos/infinispan/infinispan","forks_url":"https://api.github.com/repos/infinispan/infinispan/forks","keys_url":"https://api.github.com/repos/infinispan/infinispan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/infinispan/infinispan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/infinispan/infinispan/teams","hooks_url":"https://api.github.com/repos/infinispan/infinispan/hooks","issue_events_url":"https://api.github.com/repos/infinispan/infinispan/issues/events{/number}","events_url":"https://api.github.com/repos/infinispan/infinispan/events","assignees_url":"https://api.github.com/repos/infinispan/infinispan/assignees{/user}","branches_url":"https://api.github.com/repos/infinispan/infinispan/branches{/branch}","tags_url":"https://api.github.com/repos/infinispan/infinispan/tags","blobs_url":"https://api.github.com/repos/infinispan/infinispan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/infinispan/infinispan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/infinispan/infinispan/git/refs{/sha}","trees_url":"https://api.github.com/repos/infinispan/infinispan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/infinispan/infinispan/statuses/{sha}","languages_url":"https://api.github.com/repos/infinispan/infinispan/languages","stargazers_url":"https://api.github.com/repos/infinispan/infinispan/stargazers","contributors_url":"https://api.github.com/repos/infinispan/infinispan/contributors","subscribers_url":"https://api.github.com/repos/infinispan/infinispan/subscribers","subscription_url":"https://api.github.com/repos/infinispan/infinispan/subscription","commits_url":"https://api.github.com/repos/infinispan/infinispan/commits{/sha}","git_commits_url":"https://api.github.com/repos/infinispan/infinispan/git/commits{/sha}","comments_url":"https://api.github.com/repos/infinispan/infinispan/comments{/number}","issue_comment_url":"https://api.github.com/repos/infinispan/infinispan/issues/comments/{number}","contents_url":"https://api.github.com/repos/infinispan/infinispan/contents/{+path}","compare_url":"https://api.github.com/repos/infinispan/infinispan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/infinispan/infinispan/merges","archive_url":"https://api.github.com/repos/infinispan/infinispan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/infinispan/infinispan/downloads","issues_url":"https://api.github.com/repos/infinispan/infinispan/issues{/number}","pulls_url":"https://api.github.com/repos/infinispan/infinispan/pulls{/number}","milestones_url":"https://api.github.com/repos/infinispan/infinispan/milestones{/number}","notifications_url":"https://api.github.com/repos/infinispan/infinispan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/infinispan/infinispan/labels{/name}","releases_url":"https://api.github.com/repos/infinispan/infinispan/releases{/id}","created_at":"2010-11-04T12:33:19Z","updated_at":"2014-10-31T13:03:34Z","pushed_at":"2014-10-31T16:06:28Z","git_url":"git://github.com/infinispan/infinispan.git","ssh_url":"git@github.com:infinispan/infinispan.git","clone_url":"https://github.com/infinispan/infinispan.git","svn_url":"https://github.com/infinispan/infinispan","homepage":"http://www.infinispan.org","size":131668,"stargazers_count":322,"watchers_count":322,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":263,"mirror_url":null,"open_issues_count":7,"forks":263,"open_issues":7,"watchers":322,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/3029"},"html":{"href":"https://github.com/infinispan/infinispan/pull/3029"},"issue":{"href":"https://api.github.com/repos/infinispan/infinispan/issues/3029"},"comments":{"href":"https://api.github.com/repos/infinispan/infinispan/issues/3029/comments"},"review_comments":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/3029/comments"},"review_comment":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/3029/commits"},"statuses":{"href":"https://api.github.com/repos/infinispan/infinispan/statuses/b54ad5f22cdf964fa10f20253d25e634e690e6b0"}}}}