GitHub PullRequestReviewCommentEvent at 2014-08-06 07:30:54
Repository: chromedeveditor
Actor: umop
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/dart-lang/chromedeveditor/pulls/comments/15859473","id":15859473,"diff_hunk":"@@ -595,11 +595,27 @@ abstract class Spark\n         ws.Folder folder = resources.first;\n         folder.importFileEntry(entry);\n       }\n+    }).catchError((String e) {\n+      if (_isCancelledException(e)) throw e;\n     });\n   }\n \n-  Future<SparkJobStatus> importFolder(\n-      [List<ws.Resource> resources, chrome.DirectoryEntry entry]) {\n+  Future<SparkJobStatus> importFolder([List<ws.Resource> resources]) {\n+    chrome.ChooseEntryOptions options = new chrome.ChooseEntryOptions(\n+           type: chrome.ChooseEntryType.OPEN_DIRECTORY);\n+    return chrome.fileSystem.chooseEntry(options).then((chrome.ChooseEntryResult res) {\n+      chrome.DirectoryEntry entry = res.entry;\n+      if (entry != null) {\n+        return _startImportFolderJob(resources, entry);\n+      }\n+    }).catchError((e) {\n+      if (_isCancelledException(e)) throw e;\n+    });\n+  }\n+\n+  bool _isCancelledException(String e) => e is String && e != \"User cancelled\";","path":"ide/app/spark.dart","position":null,"original_position":24,"commit_id":"9f2fa5a9808333f3c7b730cc0cf5090ce3d46c00","original_commit_id":"523d688820ef68e227ab6884a4e45d3cdfaebf66","user":{"login":"umop","id":357955,"avatar_url":"https://avatars.githubusercontent.com/u/357955?v=2","gravatar_id":"760a960a97dc4d2ba2cf242b740004cf","url":"https://api.github.com/users/umop","html_url":"https://github.com/umop","followers_url":"https://api.github.com/users/umop/followers","following_url":"https://api.github.com/users/umop/following{/other_user}","gists_url":"https://api.github.com/users/umop/gists{/gist_id}","starred_url":"https://api.github.com/users/umop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/umop/subscriptions","organizations_url":"https://api.github.com/users/umop/orgs","repos_url":"https://api.github.com/users/umop/repos","events_url":"https://api.github.com/users/umop/events{/privacy}","received_events_url":"https://api.github.com/users/umop/received_events","type":"User","site_admin":false},"body":"Thank you.","created_at":"2014-08-06T07:30:54Z","updated_at":"2014-08-06T07:30:54Z","html_url":"https://github.com/dart-lang/chromedeveditor/pull/3074#discussion_r15859473","pull_request_url":"https://api.github.com/repos/dart-lang/chromedeveditor/pulls/3074","_links":{"self":{"href":"https://api.github.com/repos/dart-lang/chromedeveditor/pulls/comments/15859473"},"html":{"href":"https://github.com/dart-lang/chromedeveditor/pull/3074#discussion_r15859473"},"pull_request":{"href":"https://api.github.com/repos/dart-lang/chromedeveditor/pulls/3074"}}},"pull_request":{"url":"https://api.github.com/repos/dart-lang/chromedeveditor/pulls/3074","id":19373518,"html_url":"https://github.com/dart-lang/chromedeveditor/pull/3074","diff_url":"https://github.com/dart-lang/chromedeveditor/pull/3074.diff","patch_url":"https://github.com/dart-lang/chromedeveditor/pull/3074.patch","issue_url":"https://api.github.com/repos/dart-lang/chromedeveditor/issues/3074","number":3074,"state":"open","title":"Fix import dialog errors (on cancel) and fix import folder dialog backdrop","user":{"login":"umop","id":357955,"avatar_url":"https://avatars.githubusercontent.com/u/357955?v=2","gravatar_id":"760a960a97dc4d2ba2cf242b740004cf","url":"https://api.github.com/users/umop","html_url":"https://github.com/umop","followers_url":"https://api.github.com/users/umop/followers","following_url":"https://api.github.com/users/umop/following{/other_user}","gists_url":"https://api.github.com/users/umop/gists{/gist_id}","starred_url":"https://api.github.com/users/umop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/umop/subscriptions","organizations_url":"https://api.github.com/users/umop/orgs","repos_url":"https://api.github.com/users/umop/repos","events_url":"https://api.github.com/users/umop/events{/privacy}","received_events_url":"https://api.github.com/users/umop/received_events","type":"User","site_admin":false},"body":"Fixes #3066\r\n\r\nIgnores an error of cancelation on file import.\r\n\r\nAlso moved the same logic to import folder action which had gotten rearranged so that the backdrop no longer showed up.  Common method now returns the job future and lets the action handle it.\r\n\r\n@devoncarew ","created_at":"2014-08-05T22:11:18Z","updated_at":"2014-08-06T07:30:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1e4430d8f6d5667326f6f97f2d6309c9c1853bf8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dart-lang/chromedeveditor/pulls/3074/commits","review_comments_url":"https://api.github.com/repos/dart-lang/chromedeveditor/pulls/3074/comments","review_comment_url":"https://api.github.com/repos/dart-lang/chromedeveditor/pulls/comments/{number}","comments_url":"https://api.github.com/repos/dart-lang/chromedeveditor/issues/3074/comments","statuses_url":"https://api.github.com/repos/dart-lang/chromedeveditor/statuses/9f2fa5a9808333f3c7b730cc0cf5090ce3d46c00","head":{"label":"dart-lang:umop-fix-import_errors","ref":"umop-fix-import_errors","sha":"9f2fa5a9808333f3c7b730cc0cf5090ce3d46c00","user":{"login":"dart-lang","id":1609975,"avatar_url":"https://avatars.githubusercontent.com/u/1609975?v=2","gravatar_id":"f41fe13f979f2f93cc8b971e1875bdf8","url":"https://api.github.com/users/dart-lang","html_url":"https://github.com/dart-lang","followers_url":"https://api.github.com/users/dart-lang/followers","following_url":"https://api.github.com/users/dart-lang/following{/other_user}","gists_url":"https://api.github.com/users/dart-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dart-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dart-lang/subscriptions","organizations_url":"https://api.github.com/users/dart-lang/orgs","repos_url":"https://api.github.com/users/dart-lang/repos","events_url":"https://api.github.com/users/dart-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dart-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":12931484,"name":"chromedeveditor","full_name":"dart-lang/chromedeveditor","owner":{"login":"dart-lang","id":1609975,"avatar_url":"https://avatars.githubusercontent.com/u/1609975?v=2","gravatar_id":"f41fe13f979f2f93cc8b971e1875bdf8","url":"https://api.github.com/users/dart-lang","html_url":"https://github.com/dart-lang","followers_url":"https://api.github.com/users/dart-lang/followers","following_url":"https://api.github.com/users/dart-lang/following{/other_user}","gists_url":"https://api.github.com/users/dart-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dart-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dart-lang/subscriptions","organizations_url":"https://api.github.com/users/dart-lang/orgs","repos_url":"https://api.github.com/users/dart-lang/repos","events_url":"https://api.github.com/users/dart-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dart-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dart-lang/chromedeveditor","description":"Chrome Dev Editor is a developer tool for building apps on the Chrome platform - Chrome Apps and Web Apps, in JavaScript or Dart.","fork":false,"url":"https://api.github.com/repos/dart-lang/chromedeveditor","forks_url":"https://api.github.com/repos/dart-lang/chromedeveditor/forks","keys_url":"https://api.github.com/repos/dart-lang/chromedeveditor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dart-lang/chromedeveditor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dart-lang/chromedeveditor/teams","hooks_url":"https://api.github.com/repos/dart-lang/chromedeveditor/hooks","issue_events_url":"https://api.github.com/repos/dart-lang/chromedeveditor/issues/events{/number}","events_url":"https://api.github.com/repos/dart-lang/chromedeveditor/events","assignees_url":"https://api.github.com/repos/dart-lang/chromedeveditor/assignees{/user}","branches_url":"https://api.github.com/repos/dart-lang/chromedeveditor/branches{/branch}","tags_url":"https://api.github.com/repos/dart-lang/chromedeveditor/tags","blobs_url":"https://api.github.com/repos/dart-lang/chromedeveditor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dart-lang/chromedeveditor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dart-lang/chromedeveditor/git/refs{/sha}","trees_url":"https://api.github.com/repos/dart-lang/chromedeveditor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dart-lang/chromedeveditor/statuses/{sha}","languages_url":"https://api.github.com/repos/dart-lang/chromedeveditor/languages","stargazers_url":"https://api.github.com/repos/dart-lang/chromedeveditor/stargazers","contributors_url":"https://api.github.com/repos/dart-lang/chromedeveditor/contributors","subscribers_url":"https://api.github.com/repos/dart-lang/chromedeveditor/subscribers","subscription_url":"https://api.github.com/repos/dart-lang/chromedeveditor/subscription","commits_url":"https://api.github.com/repos/dart-lang/chromedeveditor/commits{/sha}","git_commits_url":"https://api.github.com/repos/dart-lang/chromedeveditor/git/commits{/sha}","comments_url":"https://api.github.com/repos/dart-lang/chromedeveditor/comments{/number}","issue_comment_url":"https://api.github.com/repos/dart-lang/chromedeveditor/issues/comments/{number}","contents_url":"https://api.github.com/repos/dart-lang/chromedeveditor/contents/{+path}","compare_url":"https://api.github.com/repos/dart-lang/chromedeveditor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dart-lang/chromedeveditor/merges","archive_url":"https://api.github.com/repos/dart-lang/chromedeveditor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dart-lang/chromedeveditor/downloads","issues_url":"https://api.github.com/repos/dart-lang/chromedeveditor/issues{/number}","pulls_url":"https://api.github.com/repos/dart-lang/chromedeveditor/pulls{/number}","milestones_url":"https://api.github.com/repos/dart-lang/chromedeveditor/milestones{/number}","notifications_url":"https://api.github.com/repos/dart-lang/chromedeveditor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dart-lang/chromedeveditor/labels{/name}","releases_url":"https://api.github.com/repos/dart-lang/chromedeveditor/releases{/id}","created_at":"2013-09-18T18:42:21Z","updated_at":"2014-08-06T02:31:52Z","pushed_at":"2014-08-06T06:50:40Z","git_url":"git://github.com/dart-lang/chromedeveditor.git","ssh_url":"git@github.com:dart-lang/chromedeveditor.git","clone_url":"https://github.com/dart-lang/chromedeveditor.git","svn_url":"https://github.com/dart-lang/chromedeveditor","homepage":"","size":57783,"stargazers_count":1940,"watchers_count":1940,"language":"Dart","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":242,"mirror_url":null,"open_issues_count":460,"forks":242,"open_issues":460,"watchers":1940,"default_branch":"master"}},"base":{"label":"dart-lang:master","ref":"master","sha":"b7fded541df22a0eedb7d7820f357e97b3852936","user":{"login":"dart-lang","id":1609975,"avatar_url":"https://avatars.githubusercontent.com/u/1609975?v=2","gravatar_id":"f41fe13f979f2f93cc8b971e1875bdf8","url":"https://api.github.com/users/dart-lang","html_url":"https://github.com/dart-lang","followers_url":"https://api.github.com/users/dart-lang/followers","following_url":"https://api.github.com/users/dart-lang/following{/other_user}","gists_url":"https://api.github.com/users/dart-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dart-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dart-lang/subscriptions","organizations_url":"https://api.github.com/users/dart-lang/orgs","repos_url":"https://api.github.com/users/dart-lang/repos","events_url":"https://api.github.com/users/dart-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dart-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":12931484,"name":"chromedeveditor","full_name":"dart-lang/chromedeveditor","owner":{"login":"dart-lang","id":1609975,"avatar_url":"https://avatars.githubusercontent.com/u/1609975?v=2","gravatar_id":"f41fe13f979f2f93cc8b971e1875bdf8","url":"https://api.github.com/users/dart-lang","html_url":"https://github.com/dart-lang","followers_url":"https://api.github.com/users/dart-lang/followers","following_url":"https://api.github.com/users/dart-lang/following{/other_user}","gists_url":"https://api.github.com/users/dart-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dart-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dart-lang/subscriptions","organizations_url":"https://api.github.com/users/dart-lang/orgs","repos_url":"https://api.github.com/users/dart-lang/repos","events_url":"https://api.github.com/users/dart-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dart-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dart-lang/chromedeveditor","description":"Chrome Dev Editor is a developer tool for building apps on the Chrome platform - Chrome Apps and Web Apps, in JavaScript or Dart.","fork":false,"url":"https://api.github.com/repos/dart-lang/chromedeveditor","forks_url":"https://api.github.com/repos/dart-lang/chromedeveditor/forks","keys_url":"https://api.github.com/repos/dart-lang/chromedeveditor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dart-lang/chromedeveditor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dart-lang/chromedeveditor/teams","hooks_url":"https://api.github.com/repos/dart-lang/chromedeveditor/hooks","issue_events_url":"https://api.github.com/repos/dart-lang/chromedeveditor/issues/events{/number}","events_url":"https://api.github.com/repos/dart-lang/chromedeveditor/events","assignees_url":"https://api.github.com/repos/dart-lang/chromedeveditor/assignees{/user}","branches_url":"https://api.github.com/repos/dart-lang/chromedeveditor/branches{/branch}","tags_url":"https://api.github.com/repos/dart-lang/chromedeveditor/tags","blobs_url":"https://api.github.com/repos/dart-lang/chromedeveditor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dart-lang/chromedeveditor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dart-lang/chromedeveditor/git/refs{/sha}","trees_url":"https://api.github.com/repos/dart-lang/chromedeveditor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dart-lang/chromedeveditor/statuses/{sha}","languages_url":"https://api.github.com/repos/dart-lang/chromedeveditor/languages","stargazers_url":"https://api.github.com/repos/dart-lang/chromedeveditor/stargazers","contributors_url":"https://api.github.com/repos/dart-lang/chromedeveditor/contributors","subscribers_url":"https://api.github.com/repos/dart-lang/chromedeveditor/subscribers","subscription_url":"https://api.github.com/repos/dart-lang/chromedeveditor/subscription","commits_url":"https://api.github.com/repos/dart-lang/chromedeveditor/commits{/sha}","git_commits_url":"https://api.github.com/repos/dart-lang/chromedeveditor/git/commits{/sha}","comments_url":"https://api.github.com/repos/dart-lang/chromedeveditor/comments{/number}","issue_comment_url":"https://api.github.com/repos/dart-lang/chromedeveditor/issues/comments/{number}","contents_url":"https://api.github.com/repos/dart-lang/chromedeveditor/contents/{+path}","compare_url":"https://api.github.com/repos/dart-lang/chromedeveditor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dart-lang/chromedeveditor/merges","archive_url":"https://api.github.com/repos/dart-lang/chromedeveditor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dart-lang/chromedeveditor/downloads","issues_url":"https://api.github.com/repos/dart-lang/chromedeveditor/issues{/number}","pulls_url":"https://api.github.com/repos/dart-lang/chromedeveditor/pulls{/number}","milestones_url":"https://api.github.com/repos/dart-lang/chromedeveditor/milestones{/number}","notifications_url":"https://api.github.com/repos/dart-lang/chromedeveditor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dart-lang/chromedeveditor/labels{/name}","releases_url":"https://api.github.com/repos/dart-lang/chromedeveditor/releases{/id}","created_at":"2013-09-18T18:42:21Z","updated_at":"2014-08-06T02:31:52Z","pushed_at":"2014-08-06T06:50:40Z","git_url":"git://github.com/dart-lang/chromedeveditor.git","ssh_url":"git@github.com:dart-lang/chromedeveditor.git","clone_url":"https://github.com/dart-lang/chromedeveditor.git","svn_url":"https://github.com/dart-lang/chromedeveditor","homepage":"","size":57783,"stargazers_count":1940,"watchers_count":1940,"language":"Dart","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":242,"mirror_url":null,"open_issues_count":460,"forks":242,"open_issues":460,"watchers":1940,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dart-lang/chromedeveditor/pulls/3074"},"html":{"href":"https://github.com/dart-lang/chromedeveditor/pull/3074"},"issue":{"href":"https://api.github.com/repos/dart-lang/chromedeveditor/issues/3074"},"comments":{"href":"https://api.github.com/repos/dart-lang/chromedeveditor/issues/3074/comments"},"review_comments":{"href":"https://api.github.com/repos/dart-lang/chromedeveditor/pulls/3074/comments"},"review_comment":{"href":"https://api.github.com/repos/dart-lang/chromedeveditor/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/dart-lang/chromedeveditor/pulls/3074/commits"},"statuses":{"href":"https://api.github.com/repos/dart-lang/chromedeveditor/statuses/9f2fa5a9808333f3c7b730cc0cf5090ce3d46c00"}}}}