GitHub PullRequestEvent at 2014-08-21 09:53:25
Repository: symfony
Actor: peter-gribanov
Payload: {"action":"opened","number":11727,"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/11727","id":20099626,"html_url":"https://github.com/symfony/symfony/pull/11727","diff_url":"https://github.com/symfony/symfony/pull/11727.diff","patch_url":"https://github.com/symfony/symfony/pull/11727.patch","issue_url":"https://api.github.com/repos/symfony/symfony/issues/11727","number":11727,"state":"open","locked":false,"title":"[Filesystem] fixed minor bugs","user":{"login":"peter-gribanov","id":1954436,"avatar_url":"https://avatars.githubusercontent.com/u/1954436?v=2","gravatar_id":"438e211c4614dd32a66cd57b33832878","url":"https://api.github.com/users/peter-gribanov","html_url":"https://github.com/peter-gribanov","followers_url":"https://api.github.com/users/peter-gribanov/followers","following_url":"https://api.github.com/users/peter-gribanov/following{/other_user}","gists_url":"https://api.github.com/users/peter-gribanov/gists{/gist_id}","starred_url":"https://api.github.com/users/peter-gribanov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peter-gribanov/subscriptions","organizations_url":"https://api.github.com/users/peter-gribanov/orgs","repos_url":"https://api.github.com/users/peter-gribanov/repos","events_url":"https://api.github.com/users/peter-gribanov/events{/privacy}","received_events_url":"https://api.github.com/users/peter-gribanov/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Fixed tickets | fixed minor bugs\r\n| License       | MIT\r\n\r\nIn the options, expected boolean value. It makes no sense to check for the existence of options, and then check the value.\r\n\r\n```php\r\n(isset($options['delete']) && $options['delete'])) === !empty($options['delete'])\r\n```\r\nMethod `Filesystem::copy()` expects third argument boolean value. In the current implementation, there can get the value of another type. Now this is not terrible, but it can cause problems in the future. ","created_at":"2014-08-21T09:53:23Z","updated_at":"2014-08-21T09:53:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/symfony/symfony/pulls/11727/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony/pulls/11727/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony/pulls/comments/{number}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/11727/comments","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/073b36e3ac9a5fc989a70e6b808ef2daa3bb561a","head":{"label":"peter-gribanov:master","ref":"master","sha":"073b36e3ac9a5fc989a70e6b808ef2daa3bb561a","user":{"login":"peter-gribanov","id":1954436,"avatar_url":"https://avatars.githubusercontent.com/u/1954436?v=2","gravatar_id":"438e211c4614dd32a66cd57b33832878","url":"https://api.github.com/users/peter-gribanov","html_url":"https://github.com/peter-gribanov","followers_url":"https://api.github.com/users/peter-gribanov/followers","following_url":"https://api.github.com/users/peter-gribanov/following{/other_user}","gists_url":"https://api.github.com/users/peter-gribanov/gists{/gist_id}","starred_url":"https://api.github.com/users/peter-gribanov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peter-gribanov/subscriptions","organizations_url":"https://api.github.com/users/peter-gribanov/orgs","repos_url":"https://api.github.com/users/peter-gribanov/repos","events_url":"https://api.github.com/users/peter-gribanov/events{/privacy}","received_events_url":"https://api.github.com/users/peter-gribanov/received_events","type":"User","site_admin":false},"repo":{"id":23181313,"name":"symfony","full_name":"peter-gribanov/symfony","owner":{"login":"peter-gribanov","id":1954436,"avatar_url":"https://avatars.githubusercontent.com/u/1954436?v=2","gravatar_id":"438e211c4614dd32a66cd57b33832878","url":"https://api.github.com/users/peter-gribanov","html_url":"https://github.com/peter-gribanov","followers_url":"https://api.github.com/users/peter-gribanov/followers","following_url":"https://api.github.com/users/peter-gribanov/following{/other_user}","gists_url":"https://api.github.com/users/peter-gribanov/gists{/gist_id}","starred_url":"https://api.github.com/users/peter-gribanov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peter-gribanov/subscriptions","organizations_url":"https://api.github.com/users/peter-gribanov/orgs","repos_url":"https://api.github.com/users/peter-gribanov/repos","events_url":"https://api.github.com/users/peter-gribanov/events{/privacy}","received_events_url":"https://api.github.com/users/peter-gribanov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/peter-gribanov/symfony","description":"The Symfony PHP framework","fork":true,"url":"https://api.github.com/repos/peter-gribanov/symfony","forks_url":"https://api.github.com/repos/peter-gribanov/symfony/forks","keys_url":"https://api.github.com/repos/peter-gribanov/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/peter-gribanov/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/peter-gribanov/symfony/teams","hooks_url":"https://api.github.com/repos/peter-gribanov/symfony/hooks","issue_events_url":"https://api.github.com/repos/peter-gribanov/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/peter-gribanov/symfony/events","assignees_url":"https://api.github.com/repos/peter-gribanov/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/peter-gribanov/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/peter-gribanov/symfony/tags","blobs_url":"https://api.github.com/repos/peter-gribanov/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/peter-gribanov/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/peter-gribanov/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/peter-gribanov/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/peter-gribanov/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/peter-gribanov/symfony/languages","stargazers_url":"https://api.github.com/repos/peter-gribanov/symfony/stargazers","contributors_url":"https://api.github.com/repos/peter-gribanov/symfony/contributors","subscribers_url":"https://api.github.com/repos/peter-gribanov/symfony/subscribers","subscription_url":"https://api.github.com/repos/peter-gribanov/symfony/subscription","commits_url":"https://api.github.com/repos/peter-gribanov/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/peter-gribanov/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/peter-gribanov/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/peter-gribanov/symfony/issues/comments/{number}","contents_url":"https://api.github.com/repos/peter-gribanov/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/peter-gribanov/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/peter-gribanov/symfony/merges","archive_url":"https://api.github.com/repos/peter-gribanov/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/peter-gribanov/symfony/downloads","issues_url":"https://api.github.com/repos/peter-gribanov/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/peter-gribanov/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/peter-gribanov/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/peter-gribanov/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/peter-gribanov/symfony/labels{/name}","releases_url":"https://api.github.com/repos/peter-gribanov/symfony/releases{/id}","created_at":"2014-08-21T09:22:22Z","updated_at":"2014-08-21T09:27:28Z","pushed_at":"2014-08-21T09:30:02Z","git_url":"git://github.com/peter-gribanov/symfony.git","ssh_url":"git@github.com:peter-gribanov/symfony.git","clone_url":"https://github.com/peter-gribanov/symfony.git","svn_url":"https://github.com/peter-gribanov/symfony","homepage":"symfony.com","size":169954,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":false,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"symfony:master","ref":"master","sha":"229355618b0c7650b4122eff764809f4ca466de4","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=2","gravatar_id":"bc6312a5b583c4258c9fad11122c6e31","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":458058,"name":"symfony","full_name":"symfony/symfony","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=2","gravatar_id":"bc6312a5b583c4258c9fad11122c6e31","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony","description":"The Symfony PHP framework","fork":false,"url":"https://api.github.com/repos/symfony/symfony","forks_url":"https://api.github.com/repos/symfony/symfony/forks","keys_url":"https://api.github.com/repos/symfony/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony/teams","hooks_url":"https://api.github.com/repos/symfony/symfony/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony/events","assignees_url":"https://api.github.com/repos/symfony/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony/tags","blobs_url":"https://api.github.com/repos/symfony/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony/subscription","commits_url":"https://api.github.com/repos/symfony/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony/issues/comments/{number}","contents_url":"https://api.github.com/repos/symfony/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony/merges","archive_url":"https://api.github.com/repos/symfony/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony/downloads","issues_url":"https://api.github.com/repos/symfony/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony/releases{/id}","created_at":"2010-01-04T14:21:21Z","updated_at":"2014-08-21T09:33:00Z","pushed_at":"2014-08-21T00:22:39Z","git_url":"git://github.com/symfony/symfony.git","ssh_url":"git@github.com:symfony/symfony.git","clone_url":"https://github.com/symfony/symfony.git","svn_url":"https://github.com/symfony/symfony","homepage":"symfony.com","size":169954,"stargazers_count":8780,"watchers_count":8780,"language":"PHP","has_issues":true,"has_downloads":false,"has_wiki":false,"forks_count":3377,"mirror_url":null,"open_issues_count":858,"forks":3377,"open_issues":858,"watchers":8780,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/11727"},"html":{"href":"https://github.com/symfony/symfony/pull/11727"},"issue":{"href":"https://api.github.com/repos/symfony/symfony/issues/11727"},"comments":{"href":"https://api.github.com/repos/symfony/symfony/issues/11727/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony/pulls/11727/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony/pulls/11727/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony/statuses/073b36e3ac9a5fc989a70e6b808ef2daa3bb561a"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":12,"deletions":18,"changed_files":1}}