GitHub PullRequestReviewCommentEvent at 2014-11-26 01:27:00
Repository: saml-service
Actor: bradleybeddoes
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/ausaccessfed/saml-service/pulls/comments/20910820","id":20910820,"diff_hunk":"@@ -0,0 +1,13 @@\n+FactoryGirl.define do\n+  factory :mdui_keyword_list, class: 'MDUI::KeywordList' do\n+    lang { 'en' }\n+    association :ui_info, factory: :mdui_ui_info\n+\n+    factory :mdui_keyword_list_with_content do\n+      content do\n+        \"#{Faker::Lorem.words(6).join(' ')}\" \\\n+        \"#{Faker::Lorem.words(2).join('+')}\"","path":"spec/factories/mdui_keywords.rb","position":null,"original_position":9,"commit_id":"0eeacaa47bbb191438c2a101474009a632d624d9","original_commit_id":"8a3dccc328789dceb27b1d36f8c186d6d612e128","user":{"login":"bradleybeddoes","id":86558,"avatar_url":"https://avatars.githubusercontent.com/u/86558?v=3","gravatar_id":"","url":"https://api.github.com/users/bradleybeddoes","html_url":"https://github.com/bradleybeddoes","followers_url":"https://api.github.com/users/bradleybeddoes/followers","following_url":"https://api.github.com/users/bradleybeddoes/following{/other_user}","gists_url":"https://api.github.com/users/bradleybeddoes/gists{/gist_id}","starred_url":"https://api.github.com/users/bradleybeddoes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradleybeddoes/subscriptions","organizations_url":"https://api.github.com/users/bradleybeddoes/orgs","repos_url":"https://api.github.com/users/bradleybeddoes/repos","events_url":"https://api.github.com/users/bradleybeddoes/events{/privacy}","received_events_url":"https://api.github.com/users/bradleybeddoes/received_events","type":"User","site_admin":false},"body":"+1 this was a hack, changed but slightly different impl to suggestion.","created_at":"2014-11-26T01:27:00Z","updated_at":"2014-11-26T01:27:00Z","html_url":"https://github.com/ausaccessfed/saml-service/pull/2#discussion_r20910820","pull_request_url":"https://api.github.com/repos/ausaccessfed/saml-service/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/ausaccessfed/saml-service/pulls/comments/20910820"},"html":{"href":"https://github.com/ausaccessfed/saml-service/pull/2#discussion_r20910820"},"pull_request":{"href":"https://api.github.com/repos/ausaccessfed/saml-service/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/ausaccessfed/saml-service/pulls/2","id":25053532,"html_url":"https://github.com/ausaccessfed/saml-service/pull/2","diff_url":"https://github.com/ausaccessfed/saml-service/pull/2.diff","patch_url":"https://github.com/ausaccessfed/saml-service/pull/2.patch","issue_url":"https://api.github.com/repos/ausaccessfed/saml-service/issues/2","number":2,"state":"open","locked":false,"title":"Feature/support metadata extension mdui","user":{"login":"bradleybeddoes","id":86558,"avatar_url":"https://avatars.githubusercontent.com/u/86558?v=3","gravatar_id":"","url":"https://api.github.com/users/bradleybeddoes","html_url":"https://github.com/bradleybeddoes","followers_url":"https://api.github.com/users/bradleybeddoes/followers","following_url":"https://api.github.com/users/bradleybeddoes/following{/other_user}","gists_url":"https://api.github.com/users/bradleybeddoes/gists{/gist_id}","starred_url":"https://api.github.com/users/bradleybeddoes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradleybeddoes/subscriptions","organizations_url":"https://api.github.com/users/bradleybeddoes/orgs","repos_url":"https://api.github.com/users/bradleybeddoes/repos","events_url":"https://api.github.com/users/bradleybeddoes/events{/privacy}","received_events_url":"https://api.github.com/users/bradleybeddoes/received_events","type":"User","site_admin":false},"body":"Add models to handle SAML MDUI specification per http://docs.oasis-open.org/security/saml/Post2.0/sstc-saml-metadata-ui/v1.0/sstc-saml-metadata-ui-v1.0.pdf","created_at":"2014-11-26T00:55:06Z","updated_at":"2014-11-26T01:27:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fd740ceb06da702e8044c07bf7191c758f25b97c","assignee":{"login":"smangelsdorf","id":6358,"avatar_url":"https://avatars.githubusercontent.com/u/6358?v=3","gravatar_id":"","url":"https://api.github.com/users/smangelsdorf","html_url":"https://github.com/smangelsdorf","followers_url":"https://api.github.com/users/smangelsdorf/followers","following_url":"https://api.github.com/users/smangelsdorf/following{/other_user}","gists_url":"https://api.github.com/users/smangelsdorf/gists{/gist_id}","starred_url":"https://api.github.com/users/smangelsdorf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smangelsdorf/subscriptions","organizations_url":"https://api.github.com/users/smangelsdorf/orgs","repos_url":"https://api.github.com/users/smangelsdorf/repos","events_url":"https://api.github.com/users/smangelsdorf/events{/privacy}","received_events_url":"https://api.github.com/users/smangelsdorf/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/ausaccessfed/saml-service/pulls/2/commits","review_comments_url":"https://api.github.com/repos/ausaccessfed/saml-service/pulls/2/comments","review_comment_url":"https://api.github.com/repos/ausaccessfed/saml-service/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ausaccessfed/saml-service/issues/2/comments","statuses_url":"https://api.github.com/repos/ausaccessfed/saml-service/statuses/0eeacaa47bbb191438c2a101474009a632d624d9","head":{"label":"ausaccessfed:feature/support-metadata-extension-mdui","ref":"feature/support-metadata-extension-mdui","sha":"0eeacaa47bbb191438c2a101474009a632d624d9","user":{"login":"ausaccessfed","id":149044,"avatar_url":"https://avatars.githubusercontent.com/u/149044?v=3","gravatar_id":"","url":"https://api.github.com/users/ausaccessfed","html_url":"https://github.com/ausaccessfed","followers_url":"https://api.github.com/users/ausaccessfed/followers","following_url":"https://api.github.com/users/ausaccessfed/following{/other_user}","gists_url":"https://api.github.com/users/ausaccessfed/gists{/gist_id}","starred_url":"https://api.github.com/users/ausaccessfed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ausaccessfed/subscriptions","organizations_url":"https://api.github.com/users/ausaccessfed/orgs","repos_url":"https://api.github.com/users/ausaccessfed/repos","events_url":"https://api.github.com/users/ausaccessfed/events{/privacy}","received_events_url":"https://api.github.com/users/ausaccessfed/received_events","type":"Organization","site_admin":false},"repo":{"id":23208847,"name":"saml-service","full_name":"ausaccessfed/saml-service","owner":{"login":"ausaccessfed","id":149044,"avatar_url":"https://avatars.githubusercontent.com/u/149044?v=3","gravatar_id":"","url":"https://api.github.com/users/ausaccessfed","html_url":"https://github.com/ausaccessfed","followers_url":"https://api.github.com/users/ausaccessfed/followers","following_url":"https://api.github.com/users/ausaccessfed/following{/other_user}","gists_url":"https://api.github.com/users/ausaccessfed/gists{/gist_id}","starred_url":"https://api.github.com/users/ausaccessfed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ausaccessfed/subscriptions","organizations_url":"https://api.github.com/users/ausaccessfed/orgs","repos_url":"https://api.github.com/users/ausaccessfed/repos","events_url":"https://api.github.com/users/ausaccessfed/events{/privacy}","received_events_url":"https://api.github.com/users/ausaccessfed/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ausaccessfed/saml-service","description":"AAF service responsible for SAML data storage, metadata generation and inter-federation metadata processing.","fork":false,"url":"https://api.github.com/repos/ausaccessfed/saml-service","forks_url":"https://api.github.com/repos/ausaccessfed/saml-service/forks","keys_url":"https://api.github.com/repos/ausaccessfed/saml-service/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ausaccessfed/saml-service/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ausaccessfed/saml-service/teams","hooks_url":"https://api.github.com/repos/ausaccessfed/saml-service/hooks","issue_events_url":"https://api.github.com/repos/ausaccessfed/saml-service/issues/events{/number}","events_url":"https://api.github.com/repos/ausaccessfed/saml-service/events","assignees_url":"https://api.github.com/repos/ausaccessfed/saml-service/assignees{/user}","branches_url":"https://api.github.com/repos/ausaccessfed/saml-service/branches{/branch}","tags_url":"https://api.github.com/repos/ausaccessfed/saml-service/tags","blobs_url":"https://api.github.com/repos/ausaccessfed/saml-service/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ausaccessfed/saml-service/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ausaccessfed/saml-service/git/refs{/sha}","trees_url":"https://api.github.com/repos/ausaccessfed/saml-service/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ausaccessfed/saml-service/statuses/{sha}","languages_url":"https://api.github.com/repos/ausaccessfed/saml-service/languages","stargazers_url":"https://api.github.com/repos/ausaccessfed/saml-service/stargazers","contributors_url":"https://api.github.com/repos/ausaccessfed/saml-service/contributors","subscribers_url":"https://api.github.com/repos/ausaccessfed/saml-service/subscribers","subscription_url":"https://api.github.com/repos/ausaccessfed/saml-service/subscription","commits_url":"https://api.github.com/repos/ausaccessfed/saml-service/commits{/sha}","git_commits_url":"https://api.github.com/repos/ausaccessfed/saml-service/git/commits{/sha}","comments_url":"https://api.github.com/repos/ausaccessfed/saml-service/comments{/number}","issue_comment_url":"https://api.github.com/repos/ausaccessfed/saml-service/issues/comments/{number}","contents_url":"https://api.github.com/repos/ausaccessfed/saml-service/contents/{+path}","compare_url":"https://api.github.com/repos/ausaccessfed/saml-service/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ausaccessfed/saml-service/merges","archive_url":"https://api.github.com/repos/ausaccessfed/saml-service/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ausaccessfed/saml-service/downloads","issues_url":"https://api.github.com/repos/ausaccessfed/saml-service/issues{/number}","pulls_url":"https://api.github.com/repos/ausaccessfed/saml-service/pulls{/number}","milestones_url":"https://api.github.com/repos/ausaccessfed/saml-service/milestones{/number}","notifications_url":"https://api.github.com/repos/ausaccessfed/saml-service/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ausaccessfed/saml-service/labels{/name}","releases_url":"https://api.github.com/repos/ausaccessfed/saml-service/releases{/id}","created_at":"2014-08-22T01:30:23Z","updated_at":"2014-11-06T07:01:04Z","pushed_at":"2014-11-26T01:26:04Z","git_url":"git://github.com/ausaccessfed/saml-service.git","ssh_url":"git@github.com:ausaccessfed/saml-service.git","clone_url":"https://github.com/ausaccessfed/saml-service.git","svn_url":"https://github.com/ausaccessfed/saml-service","homepage":null,"size":500,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"ausaccessfed:develop","ref":"develop","sha":"992b96d0cd51a1b0b5dfc19e21a4c8917b92ad15","user":{"login":"ausaccessfed","id":149044,"avatar_url":"https://avatars.githubusercontent.com/u/149044?v=3","gravatar_id":"","url":"https://api.github.com/users/ausaccessfed","html_url":"https://github.com/ausaccessfed","followers_url":"https://api.github.com/users/ausaccessfed/followers","following_url":"https://api.github.com/users/ausaccessfed/following{/other_user}","gists_url":"https://api.github.com/users/ausaccessfed/gists{/gist_id}","starred_url":"https://api.github.com/users/ausaccessfed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ausaccessfed/subscriptions","organizations_url":"https://api.github.com/users/ausaccessfed/orgs","repos_url":"https://api.github.com/users/ausaccessfed/repos","events_url":"https://api.github.com/users/ausaccessfed/events{/privacy}","received_events_url":"https://api.github.com/users/ausaccessfed/received_events","type":"Organization","site_admin":false},"repo":{"id":23208847,"name":"saml-service","full_name":"ausaccessfed/saml-service","owner":{"login":"ausaccessfed","id":149044,"avatar_url":"https://avatars.githubusercontent.com/u/149044?v=3","gravatar_id":"","url":"https://api.github.com/users/ausaccessfed","html_url":"https://github.com/ausaccessfed","followers_url":"https://api.github.com/users/ausaccessfed/followers","following_url":"https://api.github.com/users/ausaccessfed/following{/other_user}","gists_url":"https://api.github.com/users/ausaccessfed/gists{/gist_id}","starred_url":"https://api.github.com/users/ausaccessfed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ausaccessfed/subscriptions","organizations_url":"https://api.github.com/users/ausaccessfed/orgs","repos_url":"https://api.github.com/users/ausaccessfed/repos","events_url":"https://api.github.com/users/ausaccessfed/events{/privacy}","received_events_url":"https://api.github.com/users/ausaccessfed/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ausaccessfed/saml-service","description":"AAF service responsible for SAML data storage, metadata generation and inter-federation metadata processing.","fork":false,"url":"https://api.github.com/repos/ausaccessfed/saml-service","forks_url":"https://api.github.com/repos/ausaccessfed/saml-service/forks","keys_url":"https://api.github.com/repos/ausaccessfed/saml-service/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ausaccessfed/saml-service/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ausaccessfed/saml-service/teams","hooks_url":"https://api.github.com/repos/ausaccessfed/saml-service/hooks","issue_events_url":"https://api.github.com/repos/ausaccessfed/saml-service/issues/events{/number}","events_url":"https://api.github.com/repos/ausaccessfed/saml-service/events","assignees_url":"https://api.github.com/repos/ausaccessfed/saml-service/assignees{/user}","branches_url":"https://api.github.com/repos/ausaccessfed/saml-service/branches{/branch}","tags_url":"https://api.github.com/repos/ausaccessfed/saml-service/tags","blobs_url":"https://api.github.com/repos/ausaccessfed/saml-service/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ausaccessfed/saml-service/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ausaccessfed/saml-service/git/refs{/sha}","trees_url":"https://api.github.com/repos/ausaccessfed/saml-service/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ausaccessfed/saml-service/statuses/{sha}","languages_url":"https://api.github.com/repos/ausaccessfed/saml-service/languages","stargazers_url":"https://api.github.com/repos/ausaccessfed/saml-service/stargazers","contributors_url":"https://api.github.com/repos/ausaccessfed/saml-service/contributors","subscribers_url":"https://api.github.com/repos/ausaccessfed/saml-service/subscribers","subscription_url":"https://api.github.com/repos/ausaccessfed/saml-service/subscription","commits_url":"https://api.github.com/repos/ausaccessfed/saml-service/commits{/sha}","git_commits_url":"https://api.github.com/repos/ausaccessfed/saml-service/git/commits{/sha}","comments_url":"https://api.github.com/repos/ausaccessfed/saml-service/comments{/number}","issue_comment_url":"https://api.github.com/repos/ausaccessfed/saml-service/issues/comments/{number}","contents_url":"https://api.github.com/repos/ausaccessfed/saml-service/contents/{+path}","compare_url":"https://api.github.com/repos/ausaccessfed/saml-service/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ausaccessfed/saml-service/merges","archive_url":"https://api.github.com/repos/ausaccessfed/saml-service/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ausaccessfed/saml-service/downloads","issues_url":"https://api.github.com/repos/ausaccessfed/saml-service/issues{/number}","pulls_url":"https://api.github.com/repos/ausaccessfed/saml-service/pulls{/number}","milestones_url":"https://api.github.com/repos/ausaccessfed/saml-service/milestones{/number}","notifications_url":"https://api.github.com/repos/ausaccessfed/saml-service/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ausaccessfed/saml-service/labels{/name}","releases_url":"https://api.github.com/repos/ausaccessfed/saml-service/releases{/id}","created_at":"2014-08-22T01:30:23Z","updated_at":"2014-11-06T07:01:04Z","pushed_at":"2014-11-26T01:26:04Z","git_url":"git://github.com/ausaccessfed/saml-service.git","ssh_url":"git@github.com:ausaccessfed/saml-service.git","clone_url":"https://github.com/ausaccessfed/saml-service.git","svn_url":"https://github.com/ausaccessfed/saml-service","homepage":null,"size":500,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ausaccessfed/saml-service/pulls/2"},"html":{"href":"https://github.com/ausaccessfed/saml-service/pull/2"},"issue":{"href":"https://api.github.com/repos/ausaccessfed/saml-service/issues/2"},"comments":{"href":"https://api.github.com/repos/ausaccessfed/saml-service/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/ausaccessfed/saml-service/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/ausaccessfed/saml-service/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ausaccessfed/saml-service/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/ausaccessfed/saml-service/statuses/0eeacaa47bbb191438c2a101474009a632d624d9"}}}}