GitHub PullRequestEvent at 2014-04-24 12:18:09
Repository: wordpress-seo
Actor: jrfnl
Payload: {"action":"opened","number":1051,"pull_request":{"url":"https://api.github.com/repos/Yoast/wordpress-seo/pulls/1051","id":15115782,"html_url":"https://github.com/Yoast/wordpress-seo/pull/1051","diff_url":"https://github.com/Yoast/wordpress-seo/pull/1051.diff","patch_url":"https://github.com/Yoast/wordpress-seo/pull/1051.patch","issue_url":"https://api.github.com/repos/Yoast/wordpress-seo/issues/1051","number":1051,"state":"open","title":"Issue 1048 file editing","user":{"login":"jrfnl","id":663378,"avatar_url":"https://avatars.githubusercontent.com/u/663378?","gravatar_id":"ed3f04e59a9c05a471285209f9322b0e","url":"https://api.github.com/users/jrfnl","html_url":"https://github.com/jrfnl","followers_url":"https://api.github.com/users/jrfnl/followers","following_url":"https://api.github.com/users/jrfnl/following{/other_user}","gists_url":"https://api.github.com/users/jrfnl/gists{/gist_id}","starred_url":"https://api.github.com/users/jrfnl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrfnl/subscriptions","organizations_url":"https://api.github.com/users/jrfnl/orgs","repos_url":"https://api.github.com/users/jrfnl/repos","events_url":"https://api.github.com/users/jrfnl/events{/privacy}","received_events_url":"https://api.github.com/users/jrfnl/received_events","type":"User","site_admin":false},"body":"Path to file was (re-)defined numerous times as the same. Now set at top of the file and re-used everywhere.\r\n\r\nThis should fix the notices mentioned in #1048 - `file_exists()` check and `fopen()` could have been looking for different files in the old code.\r\n\r\nAlso: added filesize check to prevent notices from empty .htaccess reads.","created_at":"2014-04-24T12:18:08Z","updated_at":"2014-04-24T12:18:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Yoast/wordpress-seo/pulls/1051/commits","review_comments_url":"https://api.github.com/repos/Yoast/wordpress-seo/pulls/1051/comments","review_comment_url":"https://api.github.com/repos/Yoast/wordpress-seo/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Yoast/wordpress-seo/issues/1051/comments","statuses_url":"https://api.github.com/repos/Yoast/wordpress-seo/statuses/a7f09d15fc11aa6788e89485942baa60735474ad","head":{"label":"jrfnl:Issue-1048-file_editing","ref":"Issue-1048-file_editing","sha":"a7f09d15fc11aa6788e89485942baa60735474ad","user":{"login":"jrfnl","id":663378,"avatar_url":"https://avatars.githubusercontent.com/u/663378?","gravatar_id":"ed3f04e59a9c05a471285209f9322b0e","url":"https://api.github.com/users/jrfnl","html_url":"https://github.com/jrfnl","followers_url":"https://api.github.com/users/jrfnl/followers","following_url":"https://api.github.com/users/jrfnl/following{/other_user}","gists_url":"https://api.github.com/users/jrfnl/gists{/gist_id}","starred_url":"https://api.github.com/users/jrfnl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrfnl/subscriptions","organizations_url":"https://api.github.com/users/jrfnl/orgs","repos_url":"https://api.github.com/users/jrfnl/repos","events_url":"https://api.github.com/users/jrfnl/events{/privacy}","received_events_url":"https://api.github.com/users/jrfnl/received_events","type":"User","site_admin":false},"repo":{"id":11129910,"name":"wordpress-seo","full_name":"jrfnl/wordpress-seo","owner":{"login":"jrfnl","id":663378,"avatar_url":"https://avatars.githubusercontent.com/u/663378?","gravatar_id":"ed3f04e59a9c05a471285209f9322b0e","url":"https://api.github.com/users/jrfnl","html_url":"https://github.com/jrfnl","followers_url":"https://api.github.com/users/jrfnl/followers","following_url":"https://api.github.com/users/jrfnl/following{/other_user}","gists_url":"https://api.github.com/users/jrfnl/gists{/gist_id}","starred_url":"https://api.github.com/users/jrfnl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrfnl/subscriptions","organizations_url":"https://api.github.com/users/jrfnl/orgs","repos_url":"https://api.github.com/users/jrfnl/repos","events_url":"https://api.github.com/users/jrfnl/events{/privacy}","received_events_url":"https://api.github.com/users/jrfnl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jrfnl/wordpress-seo","description":"WordPress SEO","fork":true,"url":"https://api.github.com/repos/jrfnl/wordpress-seo","forks_url":"https://api.github.com/repos/jrfnl/wordpress-seo/forks","keys_url":"https://api.github.com/repos/jrfnl/wordpress-seo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jrfnl/wordpress-seo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jrfnl/wordpress-seo/teams","hooks_url":"https://api.github.com/repos/jrfnl/wordpress-seo/hooks","issue_events_url":"https://api.github.com/repos/jrfnl/wordpress-seo/issues/events{/number}","events_url":"https://api.github.com/repos/jrfnl/wordpress-seo/events","assignees_url":"https://api.github.com/repos/jrfnl/wordpress-seo/assignees{/user}","branches_url":"https://api.github.com/repos/jrfnl/wordpress-seo/branches{/branch}","tags_url":"https://api.github.com/repos/jrfnl/wordpress-seo/tags","blobs_url":"https://api.github.com/repos/jrfnl/wordpress-seo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jrfnl/wordpress-seo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jrfnl/wordpress-seo/git/refs{/sha}","trees_url":"https://api.github.com/repos/jrfnl/wordpress-seo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jrfnl/wordpress-seo/statuses/{sha}","languages_url":"https://api.github.com/repos/jrfnl/wordpress-seo/languages","stargazers_url":"https://api.github.com/repos/jrfnl/wordpress-seo/stargazers","contributors_url":"https://api.github.com/repos/jrfnl/wordpress-seo/contributors","subscribers_url":"https://api.github.com/repos/jrfnl/wordpress-seo/subscribers","subscription_url":"https://api.github.com/repos/jrfnl/wordpress-seo/subscription","commits_url":"https://api.github.com/repos/jrfnl/wordpress-seo/commits{/sha}","git_commits_url":"https://api.github.com/repos/jrfnl/wordpress-seo/git/commits{/sha}","comments_url":"https://api.github.com/repos/jrfnl/wordpress-seo/comments{/number}","issue_comment_url":"https://api.github.com/repos/jrfnl/wordpress-seo/issues/comments/{number}","contents_url":"https://api.github.com/repos/jrfnl/wordpress-seo/contents/{+path}","compare_url":"https://api.github.com/repos/jrfnl/wordpress-seo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jrfnl/wordpress-seo/merges","archive_url":"https://api.github.com/repos/jrfnl/wordpress-seo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jrfnl/wordpress-seo/downloads","issues_url":"https://api.github.com/repos/jrfnl/wordpress-seo/issues{/number}","pulls_url":"https://api.github.com/repos/jrfnl/wordpress-seo/pulls{/number}","milestones_url":"https://api.github.com/repos/jrfnl/wordpress-seo/milestones{/number}","notifications_url":"https://api.github.com/repos/jrfnl/wordpress-seo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jrfnl/wordpress-seo/labels{/name}","releases_url":"https://api.github.com/repos/jrfnl/wordpress-seo/releases{/id}","created_at":"2013-07-02T16:52:04Z","updated_at":"2014-04-24T12:18:08Z","pushed_at":"2014-04-24T12:12:22Z","git_url":"git://github.com/jrfnl/wordpress-seo.git","ssh_url":"git@github.com:jrfnl/wordpress-seo.git","clone_url":"https://github.com/jrfnl/wordpress-seo.git","svn_url":"https://github.com/jrfnl/wordpress-seo","homepage":null,"size":6977,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Yoast:master","ref":"master","sha":"1a70a7f2a7327e038c5ae898c42a813f06a8f50a","user":{"login":"Yoast","id":4690436,"avatar_url":"https://avatars.githubusercontent.com/u/4690436?","gravatar_id":"52492092cac9d1433bbadd41d74dd46d","url":"https://api.github.com/users/Yoast","html_url":"https://github.com/Yoast","followers_url":"https://api.github.com/users/Yoast/followers","following_url":"https://api.github.com/users/Yoast/following{/other_user}","gists_url":"https://api.github.com/users/Yoast/gists{/gist_id}","starred_url":"https://api.github.com/users/Yoast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yoast/subscriptions","organizations_url":"https://api.github.com/users/Yoast/orgs","repos_url":"https://api.github.com/users/Yoast/repos","events_url":"https://api.github.com/users/Yoast/events{/privacy}","received_events_url":"https://api.github.com/users/Yoast/received_events","type":"Organization","site_admin":false},"repo":{"id":6723399,"name":"wordpress-seo","full_name":"Yoast/wordpress-seo","owner":{"login":"Yoast","id":4690436,"avatar_url":"https://avatars.githubusercontent.com/u/4690436?","gravatar_id":"52492092cac9d1433bbadd41d74dd46d","url":"https://api.github.com/users/Yoast","html_url":"https://github.com/Yoast","followers_url":"https://api.github.com/users/Yoast/followers","following_url":"https://api.github.com/users/Yoast/following{/other_user}","gists_url":"https://api.github.com/users/Yoast/gists{/gist_id}","starred_url":"https://api.github.com/users/Yoast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yoast/subscriptions","organizations_url":"https://api.github.com/users/Yoast/orgs","repos_url":"https://api.github.com/users/Yoast/repos","events_url":"https://api.github.com/users/Yoast/events{/privacy}","received_events_url":"https://api.github.com/users/Yoast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Yoast/wordpress-seo","description":"WordPress SEO","fork":false,"url":"https://api.github.com/repos/Yoast/wordpress-seo","forks_url":"https://api.github.com/repos/Yoast/wordpress-seo/forks","keys_url":"https://api.github.com/repos/Yoast/wordpress-seo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Yoast/wordpress-seo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Yoast/wordpress-seo/teams","hooks_url":"https://api.github.com/repos/Yoast/wordpress-seo/hooks","issue_events_url":"https://api.github.com/repos/Yoast/wordpress-seo/issues/events{/number}","events_url":"https://api.github.com/repos/Yoast/wordpress-seo/events","assignees_url":"https://api.github.com/repos/Yoast/wordpress-seo/assignees{/user}","branches_url":"https://api.github.com/repos/Yoast/wordpress-seo/branches{/branch}","tags_url":"https://api.github.com/repos/Yoast/wordpress-seo/tags","blobs_url":"https://api.github.com/repos/Yoast/wordpress-seo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Yoast/wordpress-seo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Yoast/wordpress-seo/git/refs{/sha}","trees_url":"https://api.github.com/repos/Yoast/wordpress-seo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Yoast/wordpress-seo/statuses/{sha}","languages_url":"https://api.github.com/repos/Yoast/wordpress-seo/languages","stargazers_url":"https://api.github.com/repos/Yoast/wordpress-seo/stargazers","contributors_url":"https://api.github.com/repos/Yoast/wordpress-seo/contributors","subscribers_url":"https://api.github.com/repos/Yoast/wordpress-seo/subscribers","subscription_url":"https://api.github.com/repos/Yoast/wordpress-seo/subscription","commits_url":"https://api.github.com/repos/Yoast/wordpress-seo/commits{/sha}","git_commits_url":"https://api.github.com/repos/Yoast/wordpress-seo/git/commits{/sha}","comments_url":"https://api.github.com/repos/Yoast/wordpress-seo/comments{/number}","issue_comment_url":"https://api.github.com/repos/Yoast/wordpress-seo/issues/comments/{number}","contents_url":"https://api.github.com/repos/Yoast/wordpress-seo/contents/{+path}","compare_url":"https://api.github.com/repos/Yoast/wordpress-seo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Yoast/wordpress-seo/merges","archive_url":"https://api.github.com/repos/Yoast/wordpress-seo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Yoast/wordpress-seo/downloads","issues_url":"https://api.github.com/repos/Yoast/wordpress-seo/issues{/number}","pulls_url":"https://api.github.com/repos/Yoast/wordpress-seo/pulls{/number}","milestones_url":"https://api.github.com/repos/Yoast/wordpress-seo/milestones{/number}","notifications_url":"https://api.github.com/repos/Yoast/wordpress-seo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Yoast/wordpress-seo/labels{/name}","releases_url":"https://api.github.com/repos/Yoast/wordpress-seo/releases{/id}","created_at":"2012-11-16T15:16:29Z","updated_at":"2014-04-24T12:02:22Z","pushed_at":"2014-04-24T12:02:23Z","git_url":"git://github.com/Yoast/wordpress-seo.git","ssh_url":"git@github.com:Yoast/wordpress-seo.git","clone_url":"https://github.com/Yoast/wordpress-seo.git","svn_url":"https://github.com/Yoast/wordpress-seo","homepage":"http://yoast.com/wordpress/seo/","size":9896,"stargazers_count":272,"watchers_count":272,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":140,"mirror_url":null,"open_issues_count":292,"forks":140,"open_issues":292,"watchers":272,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Yoast/wordpress-seo/pulls/1051"},"html":{"href":"https://github.com/Yoast/wordpress-seo/pull/1051"},"issue":{"href":"https://api.github.com/repos/Yoast/wordpress-seo/issues/1051"},"comments":{"href":"https://api.github.com/repos/Yoast/wordpress-seo/issues/1051/comments"},"review_comments":{"href":"https://api.github.com/repos/Yoast/wordpress-seo/pulls/1051/comments"},"review_comment":{"href":"https://api.github.com/repos/Yoast/wordpress-seo/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Yoast/wordpress-seo/pulls/1051/commits"},"statuses":{"href":"https://api.github.com/repos/Yoast/wordpress-seo/statuses/a7f09d15fc11aa6788e89485942baa60735474ad"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":18,"deletions":18,"changed_files":1}}