GitHub PullRequestReviewCommentEvent at 2014-03-04 08:42:09
Repository: yii2
Actor: loloroboros
Payload: {"comment":{"url":"https://api.github.com/repos/yiisoft/yii2/pulls/comments/10246486","id":10246486,"diff_hunk":"@@ -0,0 +1,152 @@\n+<?php\n+/**\n+ * @link http://www.yiiframework.com/\n+ * @copyright Copyright (c) 2008 Yii Software LLC\n+ * @license http://www.yiiframework.com/license/\n+ */\n+\n+namespace yii\\rest;\n+\n+use Yii;\n+use yii\\base\\Component;\n+use yii\\base\\Model;\n+use yii\\data\\DataProviderInterface;\n+use yii\\data\\Pagination;\n+use yii\\helpers\\ArrayHelper;\n+use yii\\web\\Request;\n+use yii\\web\\Response;\n+\n+/**\n+ *\n+ * @author Qiang Xue <qiang.xue@gmail.com>\n+ * @since 2.0\n+ */\n+class Serializer extends Component\n+{\n+\tpublic $fieldsParam = 'fields';\n+\tpublic $expandParam = 'expand';\n+\tpublic $totalCountHeader = 'X-Pagination-Total-Count';","path":"framework/rest/Serializer.php","position":28,"original_position":28,"commit_id":"c41e389f917efe77acf1d447faad179bec45f5c5","original_commit_id":"c41e389f917efe77acf1d447faad179bec45f5c5","user":{"login":"loloroboros","id":2547585,"avatar_url":"https://avatars.githubusercontent.com/u/2547585","gravatar_id":"dadcfe31ba14436f953d885b958b81e4","url":"https://api.github.com/users/loloroboros","html_url":"https://github.com/loloroboros","followers_url":"https://api.github.com/users/loloroboros/followers","following_url":"https://api.github.com/users/loloroboros/following{/other_user}","gists_url":"https://api.github.com/users/loloroboros/gists{/gist_id}","starred_url":"https://api.github.com/users/loloroboros/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loloroboros/subscriptions","organizations_url":"https://api.github.com/users/loloroboros/orgs","repos_url":"https://api.github.com/users/loloroboros/repos","events_url":"https://api.github.com/users/loloroboros/events{/privacy}","received_events_url":"https://api.github.com/users/loloroboros/received_events","type":"User","site_admin":false},"body":"Not sure this belongs in the fw, but for those reading some JS libraries don't correctly handle HTTP errors, forcing you to push the status code into the response body. This is a practical consideration that's come up before. Maybe a `_meta` on the response body?","created_at":"2014-03-04T08:42:09Z","updated_at":"2014-03-04T08:42:09Z","html_url":"https://github.com/yiisoft/yii2/pull/2599#discussion_r10246486","pull_request_url":"https://api.github.com/repos/yiisoft/yii2/pulls/2599","_links":{"self":{"href":"https://api.github.com/repos/yiisoft/yii2/pulls/comments/10246486"},"html":{"href":"https://github.com/yiisoft/yii2/pull/2599#discussion_r10246486"},"pull_request":{"href":"https://api.github.com/repos/yiisoft/yii2/pulls/2599"}}}}