GitHub PullRequestEvent at 2014-07-07 19:27:56
Repository: pandas
Actor: jreback
Payload: {"action":"closed","number":7234,"pull_request":{"url":"https://api.github.com/repos/pydata/pandas/pulls/7234","id":16309419,"html_url":"https://github.com/pydata/pandas/pull/7234","diff_url":"https://github.com/pydata/pandas/pull/7234.diff","patch_url":"https://github.com/pydata/pandas/pull/7234.patch","issue_url":"https://api.github.com/repos/pydata/pandas/issues/7234","number":7234,"state":"closed","title":"BUG: grouped hist raises AttributeError with single group","user":{"login":"sinhrks","id":1696302,"avatar_url":"https://avatars.githubusercontent.com/u/1696302?","gravatar_id":"22f56e55955b9aa693081ed5dc6400ae","url":"https://api.github.com/users/sinhrks","html_url":"https://github.com/sinhrks","followers_url":"https://api.github.com/users/sinhrks/followers","following_url":"https://api.github.com/users/sinhrks/following{/other_user}","gists_url":"https://api.github.com/users/sinhrks/gists{/gist_id}","starred_url":"https://api.github.com/users/sinhrks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sinhrks/subscriptions","organizations_url":"https://api.github.com/users/sinhrks/orgs","repos_url":"https://api.github.com/users/sinhrks/repos","events_url":"https://api.github.com/users/sinhrks/events{/privacy}","received_events_url":"https://api.github.com/users/sinhrks/received_events","type":"User","site_admin":false},"body":"Includes 3 minor fixes for `hist`.\r\n\r\n+ `DataFrame.hist` raises `AttributeError` when the target column specifiedwith `by` kw only contains a single value.\r\n\r\n```\r\nimport pandas as pd\r\nimport numpy as np\r\nimport matplotlib.pyplot as plt\r\nimport pandas.util.testing as tm\r\n\r\nn=100\r\ngender = tm.choice(['Male', 'Female'], size=n)\r\nclassroom = tm.choice(['A', 'B', 'C'], size=n)\r\nsingle = tm.choice(['S'], size=n)\r\n\r\ndf = pd.DataFrame({'gender': gender,\r\n                   'classroom': classroom,\r\n                   'single': single, \r\n                   'height': np.random.normal(66, 4, size=n),\r\n                   'weight': np.random.normal(161, 32, size=n),\r\n                   'category': np.random.randint(4, size=n)})\r\n\r\ndf.hist(by='single')\r\n# AttributeError: 'AxesSubplot' object has no attribute 'ravel'\r\n```\r\n\r\n\r\n+ `hist` can accept `rot` kw only when `by` is specified, but `rot` actually does nothing. I understand `rot` value should be used for `xticklabels` rotation if `xrot` is not specified?\r\n```\r\ndf.hist(rot=45)\r\n# AttributeError: Unknown property rot\r\n# -> This is OK because we can use xrot kw\r\n\r\ndf.hist(by='classroom', rot=45)\r\n# It raises no error, but ticks are NOT rotated.\r\n```\r\n\r\n+ `hist` always displays `xticklabels` on all axes even if specifying `sharex=True`. Other plots only draws `xticklabels` on bottom axes if `sharex` is True.","created_at":"2014-05-24T22:12:03Z","updated_at":"2014-07-07T19:27:56Z","closed_at":"2014-07-07T19:27:56Z","merged_at":"2014-07-07T19:27:56Z","merge_commit_sha":"17d779a9b36b26f4bcf198323b0a8c31b14804c9","assignee":null,"milestone":{"url":"https://api.github.com/repos/pydata/pandas/milestones/27","labels_url":"https://api.github.com/repos/pydata/pandas/milestones/27/labels","id":641843,"number":27,"title":"0.14.1","description":"bug fixes from 0.14.0","creator":{"login":"jreback","id":953992,"avatar_url":"https://avatars.githubusercontent.com/u/953992?","gravatar_id":"b2833d485728ee2f603802242ebc9826","url":"https://api.github.com/users/jreback","html_url":"https://github.com/jreback","followers_url":"https://api.github.com/users/jreback/followers","following_url":"https://api.github.com/users/jreback/following{/other_user}","gists_url":"https://api.github.com/users/jreback/gists{/gist_id}","starred_url":"https://api.github.com/users/jreback/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jreback/subscriptions","organizations_url":"https://api.github.com/users/jreback/orgs","repos_url":"https://api.github.com/users/jreback/repos","events_url":"https://api.github.com/users/jreback/events{/privacy}","received_events_url":"https://api.github.com/users/jreback/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":292,"state":"open","created_at":"2014-04-27T23:40:28Z","updated_at":"2014-07-07T19:27:56Z","due_on":"2014-07-11T07:00:00Z"},"commits_url":"https://api.github.com/repos/pydata/pandas/pulls/7234/commits","review_comments_url":"https://api.github.com/repos/pydata/pandas/pulls/7234/comments","review_comment_url":"https://api.github.com/repos/pydata/pandas/pulls/comments/{number}","comments_url":"https://api.github.com/repos/pydata/pandas/issues/7234/comments","statuses_url":"https://api.github.com/repos/pydata/pandas/statuses/647a7c40c5cff64e265c7f57bea1b3673e9b4867","head":{"label":"sinhrks:histbug","ref":"histbug","sha":"647a7c40c5cff64e265c7f57bea1b3673e9b4867","user":{"login":"sinhrks","id":1696302,"avatar_url":"https://avatars.githubusercontent.com/u/1696302?","gravatar_id":"22f56e55955b9aa693081ed5dc6400ae","url":"https://api.github.com/users/sinhrks","html_url":"https://github.com/sinhrks","followers_url":"https://api.github.com/users/sinhrks/followers","following_url":"https://api.github.com/users/sinhrks/following{/other_user}","gists_url":"https://api.github.com/users/sinhrks/gists{/gist_id}","starred_url":"https://api.github.com/users/sinhrks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sinhrks/subscriptions","organizations_url":"https://api.github.com/users/sinhrks/orgs","repos_url":"https://api.github.com/users/sinhrks/repos","events_url":"https://api.github.com/users/sinhrks/events{/privacy}","received_events_url":"https://api.github.com/users/sinhrks/received_events","type":"User","site_admin":false},"repo":{"id":17763851,"name":"pandas","full_name":"sinhrks/pandas","owner":{"login":"sinhrks","id":1696302,"avatar_url":"https://avatars.githubusercontent.com/u/1696302?","gravatar_id":"22f56e55955b9aa693081ed5dc6400ae","url":"https://api.github.com/users/sinhrks","html_url":"https://github.com/sinhrks","followers_url":"https://api.github.com/users/sinhrks/followers","following_url":"https://api.github.com/users/sinhrks/following{/other_user}","gists_url":"https://api.github.com/users/sinhrks/gists{/gist_id}","starred_url":"https://api.github.com/users/sinhrks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sinhrks/subscriptions","organizations_url":"https://api.github.com/users/sinhrks/orgs","repos_url":"https://api.github.com/users/sinhrks/repos","events_url":"https://api.github.com/users/sinhrks/events{/privacy}","received_events_url":"https://api.github.com/users/sinhrks/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sinhrks/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":true,"url":"https://api.github.com/repos/sinhrks/pandas","forks_url":"https://api.github.com/repos/sinhrks/pandas/forks","keys_url":"https://api.github.com/repos/sinhrks/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sinhrks/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sinhrks/pandas/teams","hooks_url":"https://api.github.com/repos/sinhrks/pandas/hooks","issue_events_url":"https://api.github.com/repos/sinhrks/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/sinhrks/pandas/events","assignees_url":"https://api.github.com/repos/sinhrks/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/sinhrks/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/sinhrks/pandas/tags","blobs_url":"https://api.github.com/repos/sinhrks/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sinhrks/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sinhrks/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/sinhrks/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sinhrks/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/sinhrks/pandas/languages","stargazers_url":"https://api.github.com/repos/sinhrks/pandas/stargazers","contributors_url":"https://api.github.com/repos/sinhrks/pandas/contributors","subscribers_url":"https://api.github.com/repos/sinhrks/pandas/subscribers","subscription_url":"https://api.github.com/repos/sinhrks/pandas/subscription","commits_url":"https://api.github.com/repos/sinhrks/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/sinhrks/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/sinhrks/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/sinhrks/pandas/issues/comments/{number}","contents_url":"https://api.github.com/repos/sinhrks/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/sinhrks/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sinhrks/pandas/merges","archive_url":"https://api.github.com/repos/sinhrks/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sinhrks/pandas/downloads","issues_url":"https://api.github.com/repos/sinhrks/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/sinhrks/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/sinhrks/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/sinhrks/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sinhrks/pandas/labels{/name}","releases_url":"https://api.github.com/repos/sinhrks/pandas/releases{/id}","created_at":"2014-03-14T23:35:33Z","updated_at":"2014-06-28T10:41:34Z","pushed_at":"2014-07-07T11:04:41Z","git_url":"git://github.com/sinhrks/pandas.git","ssh_url":"git@github.com:sinhrks/pandas.git","clone_url":"https://github.com/sinhrks/pandas.git","svn_url":"https://github.com/sinhrks/pandas","homepage":"http://pandas.pydata.org","size":38817,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pydata:master","ref":"master","sha":"83a7d770b06c863759cd1092ffa74fa02f3ae919","user":{"login":"pydata","id":1284191,"avatar_url":"https://avatars.githubusercontent.com/u/1284191?","gravatar_id":"0b41e491d21e0e2e054d9c1b2d72ad59","url":"https://api.github.com/users/pydata","html_url":"https://github.com/pydata","followers_url":"https://api.github.com/users/pydata/followers","following_url":"https://api.github.com/users/pydata/following{/other_user}","gists_url":"https://api.github.com/users/pydata/gists{/gist_id}","starred_url":"https://api.github.com/users/pydata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pydata/subscriptions","organizations_url":"https://api.github.com/users/pydata/orgs","repos_url":"https://api.github.com/users/pydata/repos","events_url":"https://api.github.com/users/pydata/events{/privacy}","received_events_url":"https://api.github.com/users/pydata/received_events","type":"Organization","site_admin":false},"repo":{"id":858127,"name":"pandas","full_name":"pydata/pandas","owner":{"login":"pydata","id":1284191,"avatar_url":"https://avatars.githubusercontent.com/u/1284191?","gravatar_id":"0b41e491d21e0e2e054d9c1b2d72ad59","url":"https://api.github.com/users/pydata","html_url":"https://github.com/pydata","followers_url":"https://api.github.com/users/pydata/followers","following_url":"https://api.github.com/users/pydata/following{/other_user}","gists_url":"https://api.github.com/users/pydata/gists{/gist_id}","starred_url":"https://api.github.com/users/pydata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pydata/subscriptions","organizations_url":"https://api.github.com/users/pydata/orgs","repos_url":"https://api.github.com/users/pydata/repos","events_url":"https://api.github.com/users/pydata/events{/privacy}","received_events_url":"https://api.github.com/users/pydata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pydata/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":false,"url":"https://api.github.com/repos/pydata/pandas","forks_url":"https://api.github.com/repos/pydata/pandas/forks","keys_url":"https://api.github.com/repos/pydata/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pydata/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pydata/pandas/teams","hooks_url":"https://api.github.com/repos/pydata/pandas/hooks","issue_events_url":"https://api.github.com/repos/pydata/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/pydata/pandas/events","assignees_url":"https://api.github.com/repos/pydata/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/pydata/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/pydata/pandas/tags","blobs_url":"https://api.github.com/repos/pydata/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pydata/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pydata/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/pydata/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pydata/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/pydata/pandas/languages","stargazers_url":"https://api.github.com/repos/pydata/pandas/stargazers","contributors_url":"https://api.github.com/repos/pydata/pandas/contributors","subscribers_url":"https://api.github.com/repos/pydata/pandas/subscribers","subscription_url":"https://api.github.com/repos/pydata/pandas/subscription","commits_url":"https://api.github.com/repos/pydata/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/pydata/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/pydata/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/pydata/pandas/issues/comments/{number}","contents_url":"https://api.github.com/repos/pydata/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/pydata/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pydata/pandas/merges","archive_url":"https://api.github.com/repos/pydata/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pydata/pandas/downloads","issues_url":"https://api.github.com/repos/pydata/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/pydata/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/pydata/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/pydata/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pydata/pandas/labels{/name}","releases_url":"https://api.github.com/repos/pydata/pandas/releases{/id}","created_at":"2010-08-24T01:37:33Z","updated_at":"2014-07-07T18:51:00Z","pushed_at":"2014-07-07T19:27:53Z","git_url":"git://github.com/pydata/pandas.git","ssh_url":"git@github.com:pydata/pandas.git","clone_url":"https://github.com/pydata/pandas.git","svn_url":"https://github.com/pydata/pandas","homepage":"http://pandas.pydata.org","size":78036,"stargazers_count":3157,"watchers_count":3157,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":1004,"mirror_url":null,"open_issues_count":894,"forks":1004,"open_issues":894,"watchers":3157,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pydata/pandas/pulls/7234"},"html":{"href":"https://github.com/pydata/pandas/pull/7234"},"issue":{"href":"https://api.github.com/repos/pydata/pandas/issues/7234"},"comments":{"href":"https://api.github.com/repos/pydata/pandas/issues/7234/comments"},"review_comments":{"href":"https://api.github.com/repos/pydata/pandas/pulls/7234/comments"},"review_comment":{"href":"https://api.github.com/repos/pydata/pandas/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/pydata/pandas/pulls/7234/commits"},"statuses":{"href":"https://api.github.com/repos/pydata/pandas/statuses/647a7c40c5cff64e265c7f57bea1b3673e9b4867"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jreback","id":953992,"avatar_url":"https://avatars.githubusercontent.com/u/953992?","gravatar_id":"b2833d485728ee2f603802242ebc9826","url":"https://api.github.com/users/jreback","html_url":"https://github.com/jreback","followers_url":"https://api.github.com/users/jreback/followers","following_url":"https://api.github.com/users/jreback/following{/other_user}","gists_url":"https://api.github.com/users/jreback/gists{/gist_id}","starred_url":"https://api.github.com/users/jreback/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jreback/subscriptions","organizations_url":"https://api.github.com/users/jreback/orgs","repos_url":"https://api.github.com/users/jreback/repos","events_url":"https://api.github.com/users/jreback/events{/privacy}","received_events_url":"https://api.github.com/users/jreback/received_events","type":"User","site_admin":false},"comments":5,"review_comments":1,"commits":1,"additions":49,"deletions":37,"changed_files":3}}