GitHub PullRequestEvent at 2014-10-13 22:04:19
Repository: positron
Actor: mzikherman
Payload: {"action":"closed","number":24,"pull_request":{"url":"https://api.github.com/repos/artsy/positron/pulls/24","id":22672655,"html_url":"https://github.com/artsy/positron/pull/24","diff_url":"https://github.com/artsy/positron/pull/24.diff","patch_url":"https://github.com/artsy/positron/pull/24.patch","issue_url":"https://api.github.com/repos/artsy/positron/issues/24","number":24,"state":"closed","locked":false,"title":"@mzikherman: Wire up Gemini uploading for thumbnails & scatter brained stuff","user":{"login":"craigspaeth","id":555859,"avatar_url":"https://avatars.githubusercontent.com/u/555859?v=2","gravatar_id":"","url":"https://api.github.com/users/craigspaeth","html_url":"https://github.com/craigspaeth","followers_url":"https://api.github.com/users/craigspaeth/followers","following_url":"https://api.github.com/users/craigspaeth/following{/other_user}","gists_url":"https://api.github.com/users/craigspaeth/gists{/gist_id}","starred_url":"https://api.github.com/users/craigspaeth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craigspaeth/subscriptions","organizations_url":"https://api.github.com/users/craigspaeth/orgs","repos_url":"https://api.github.com/users/craigspaeth/repos","events_url":"https://api.github.com/users/craigspaeth/events{/privacy}","received_events_url":"https://api.github.com/users/craigspaeth/received_events","type":"User","site_admin":false},"body":"Sorry for the large PR (FWIW most of the line number diff is a new shrinkwrap).\r\n\r\nWhat this PR mainly does is use this little [gemup](http://github.com/artsy/gemup) module I wrote for Gemini upload. This module is a lighter alternative to [the artsy-gemini-upload plugin](https://github.com/artsy/artsy-gemini-upload) by allowing interaction with File objects directly & no dependency on existing DOM or the jquery.fileupload plugin (at the cost of rolling your own UI bits/lack of other solved problems you get with jquery.fileupload). In my case I'm going to often want \"lower level\" control of the upload process so I thought it would be nice to provide a smaller wrapper over the ajax parts of uploading through Gemini.\r\n\r\nSorry for the scattered-brained extras here, but also included is:\r\n* API is more flexible about blank values\r\n* Sort articles by \"most recent\" by default `-updated_at`\r\n* Filled out \"thumbnail view\" UI (including gemup-backed thumbnail upload)\r\n* Split up article layout views into EditHeader/EditThumbnail/EditView subviews\r\n\r\n![image](https://cloud.githubusercontent.com/assets/555859/4620250/cf405684-531d-11e4-8d63-dceb6ed664d4.png)","created_at":"2014-10-13T21:14:04Z","updated_at":"2014-10-13T22:04:19Z","closed_at":"2014-10-13T22:04:19Z","merged_at":"2014-10-13T22:04:19Z","merge_commit_sha":"307a1bd0194ce45226610ae0d4387d4196d24522","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/artsy/positron/pulls/24/commits","review_comments_url":"https://api.github.com/repos/artsy/positron/pulls/24/comments","review_comment_url":"https://api.github.com/repos/artsy/positron/pulls/comments/{number}","comments_url":"https://api.github.com/repos/artsy/positron/issues/24/comments","statuses_url":"https://api.github.com/repos/artsy/positron/statuses/bb15ac7c0c5d6076a4516c9a39e424abf3c7093d","head":{"label":"craigspaeth:api-fwd","ref":"api-fwd","sha":"bb15ac7c0c5d6076a4516c9a39e424abf3c7093d","user":{"login":"craigspaeth","id":555859,"avatar_url":"https://avatars.githubusercontent.com/u/555859?v=2","gravatar_id":"","url":"https://api.github.com/users/craigspaeth","html_url":"https://github.com/craigspaeth","followers_url":"https://api.github.com/users/craigspaeth/followers","following_url":"https://api.github.com/users/craigspaeth/following{/other_user}","gists_url":"https://api.github.com/users/craigspaeth/gists{/gist_id}","starred_url":"https://api.github.com/users/craigspaeth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craigspaeth/subscriptions","organizations_url":"https://api.github.com/users/craigspaeth/orgs","repos_url":"https://api.github.com/users/craigspaeth/repos","events_url":"https://api.github.com/users/craigspaeth/events{/privacy}","received_events_url":"https://api.github.com/users/craigspaeth/received_events","type":"User","site_admin":false},"repo":{"id":23811183,"name":"positron","full_name":"craigspaeth/positron","owner":{"login":"craigspaeth","id":555859,"avatar_url":"https://avatars.githubusercontent.com/u/555859?v=2","gravatar_id":"","url":"https://api.github.com/users/craigspaeth","html_url":"https://github.com/craigspaeth","followers_url":"https://api.github.com/users/craigspaeth/followers","following_url":"https://api.github.com/users/craigspaeth/following{/other_user}","gists_url":"https://api.github.com/users/craigspaeth/gists{/gist_id}","starred_url":"https://api.github.com/users/craigspaeth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craigspaeth/subscriptions","organizations_url":"https://api.github.com/users/craigspaeth/orgs","repos_url":"https://api.github.com/users/craigspaeth/repos","events_url":"https://api.github.com/users/craigspaeth/events{/privacy}","received_events_url":"https://api.github.com/users/craigspaeth/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/craigspaeth/positron","description":"Otherwise known as Artsy Writer. The back-end posting tool for publishing on Artsy.","fork":true,"url":"https://api.github.com/repos/craigspaeth/positron","forks_url":"https://api.github.com/repos/craigspaeth/positron/forks","keys_url":"https://api.github.com/repos/craigspaeth/positron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/craigspaeth/positron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/craigspaeth/positron/teams","hooks_url":"https://api.github.com/repos/craigspaeth/positron/hooks","issue_events_url":"https://api.github.com/repos/craigspaeth/positron/issues/events{/number}","events_url":"https://api.github.com/repos/craigspaeth/positron/events","assignees_url":"https://api.github.com/repos/craigspaeth/positron/assignees{/user}","branches_url":"https://api.github.com/repos/craigspaeth/positron/branches{/branch}","tags_url":"https://api.github.com/repos/craigspaeth/positron/tags","blobs_url":"https://api.github.com/repos/craigspaeth/positron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/craigspaeth/positron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/craigspaeth/positron/git/refs{/sha}","trees_url":"https://api.github.com/repos/craigspaeth/positron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/craigspaeth/positron/statuses/{sha}","languages_url":"https://api.github.com/repos/craigspaeth/positron/languages","stargazers_url":"https://api.github.com/repos/craigspaeth/positron/stargazers","contributors_url":"https://api.github.com/repos/craigspaeth/positron/contributors","subscribers_url":"https://api.github.com/repos/craigspaeth/positron/subscribers","subscription_url":"https://api.github.com/repos/craigspaeth/positron/subscription","commits_url":"https://api.github.com/repos/craigspaeth/positron/commits{/sha}","git_commits_url":"https://api.github.com/repos/craigspaeth/positron/git/commits{/sha}","comments_url":"https://api.github.com/repos/craigspaeth/positron/comments{/number}","issue_comment_url":"https://api.github.com/repos/craigspaeth/positron/issues/comments/{number}","contents_url":"https://api.github.com/repos/craigspaeth/positron/contents/{+path}","compare_url":"https://api.github.com/repos/craigspaeth/positron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/craigspaeth/positron/merges","archive_url":"https://api.github.com/repos/craigspaeth/positron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/craigspaeth/positron/downloads","issues_url":"https://api.github.com/repos/craigspaeth/positron/issues{/number}","pulls_url":"https://api.github.com/repos/craigspaeth/positron/pulls{/number}","milestones_url":"https://api.github.com/repos/craigspaeth/positron/milestones{/number}","notifications_url":"https://api.github.com/repos/craigspaeth/positron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/craigspaeth/positron/labels{/name}","releases_url":"https://api.github.com/repos/craigspaeth/positron/releases{/id}","created_at":"2014-09-08T22:43:13Z","updated_at":"2014-09-08T22:44:31Z","pushed_at":"2014-10-13T20:58:31Z","git_url":"git://github.com/craigspaeth/positron.git","ssh_url":"git@github.com:craigspaeth/positron.git","clone_url":"https://github.com/craigspaeth/positron.git","svn_url":"https://github.com/craigspaeth/positron","homepage":null,"size":1325,"stargazers_count":0,"watchers_count":0,"language":"CoffeeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"artsy:master","ref":"master","sha":"13c51862b0f97d9d8c8a9226328bc369abb7d994","user":{"login":"artsy","id":546231,"avatar_url":"https://avatars.githubusercontent.com/u/546231?v=2","gravatar_id":"","url":"https://api.github.com/users/artsy","html_url":"https://github.com/artsy","followers_url":"https://api.github.com/users/artsy/followers","following_url":"https://api.github.com/users/artsy/following{/other_user}","gists_url":"https://api.github.com/users/artsy/gists{/gist_id}","starred_url":"https://api.github.com/users/artsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artsy/subscriptions","organizations_url":"https://api.github.com/users/artsy/orgs","repos_url":"https://api.github.com/users/artsy/repos","events_url":"https://api.github.com/users/artsy/events{/privacy}","received_events_url":"https://api.github.com/users/artsy/received_events","type":"Organization","site_admin":false},"repo":{"id":23808195,"name":"positron","full_name":"artsy/positron","owner":{"login":"artsy","id":546231,"avatar_url":"https://avatars.githubusercontent.com/u/546231?v=2","gravatar_id":"","url":"https://api.github.com/users/artsy","html_url":"https://github.com/artsy","followers_url":"https://api.github.com/users/artsy/followers","following_url":"https://api.github.com/users/artsy/following{/other_user}","gists_url":"https://api.github.com/users/artsy/gists{/gist_id}","starred_url":"https://api.github.com/users/artsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artsy/subscriptions","organizations_url":"https://api.github.com/users/artsy/orgs","repos_url":"https://api.github.com/users/artsy/repos","events_url":"https://api.github.com/users/artsy/events{/privacy}","received_events_url":"https://api.github.com/users/artsy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/artsy/positron","description":"Otherwise known as Artsy Writer. The back-end posting tool for publishing articles on Artsy.","fork":false,"url":"https://api.github.com/repos/artsy/positron","forks_url":"https://api.github.com/repos/artsy/positron/forks","keys_url":"https://api.github.com/repos/artsy/positron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/artsy/positron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/artsy/positron/teams","hooks_url":"https://api.github.com/repos/artsy/positron/hooks","issue_events_url":"https://api.github.com/repos/artsy/positron/issues/events{/number}","events_url":"https://api.github.com/repos/artsy/positron/events","assignees_url":"https://api.github.com/repos/artsy/positron/assignees{/user}","branches_url":"https://api.github.com/repos/artsy/positron/branches{/branch}","tags_url":"https://api.github.com/repos/artsy/positron/tags","blobs_url":"https://api.github.com/repos/artsy/positron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/artsy/positron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/artsy/positron/git/refs{/sha}","trees_url":"https://api.github.com/repos/artsy/positron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/artsy/positron/statuses/{sha}","languages_url":"https://api.github.com/repos/artsy/positron/languages","stargazers_url":"https://api.github.com/repos/artsy/positron/stargazers","contributors_url":"https://api.github.com/repos/artsy/positron/contributors","subscribers_url":"https://api.github.com/repos/artsy/positron/subscribers","subscription_url":"https://api.github.com/repos/artsy/positron/subscription","commits_url":"https://api.github.com/repos/artsy/positron/commits{/sha}","git_commits_url":"https://api.github.com/repos/artsy/positron/git/commits{/sha}","comments_url":"https://api.github.com/repos/artsy/positron/comments{/number}","issue_comment_url":"https://api.github.com/repos/artsy/positron/issues/comments/{number}","contents_url":"https://api.github.com/repos/artsy/positron/contents/{+path}","compare_url":"https://api.github.com/repos/artsy/positron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/artsy/positron/merges","archive_url":"https://api.github.com/repos/artsy/positron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/artsy/positron/downloads","issues_url":"https://api.github.com/repos/artsy/positron/issues{/number}","pulls_url":"https://api.github.com/repos/artsy/positron/pulls{/number}","milestones_url":"https://api.github.com/repos/artsy/positron/milestones{/number}","notifications_url":"https://api.github.com/repos/artsy/positron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/artsy/positron/labels{/name}","releases_url":"https://api.github.com/repos/artsy/positron/releases{/id}","created_at":"2014-09-08T21:02:13Z","updated_at":"2014-10-08T14:36:03Z","pushed_at":"2014-10-13T22:04:19Z","git_url":"git://github.com/artsy/positron.git","ssh_url":"git@github.com:artsy/positron.git","clone_url":"https://github.com/artsy/positron.git","svn_url":"https://github.com/artsy/positron","homepage":"","size":832,"stargazers_count":2,"watchers_count":2,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/artsy/positron/pulls/24"},"html":{"href":"https://github.com/artsy/positron/pull/24"},"issue":{"href":"https://api.github.com/repos/artsy/positron/issues/24"},"comments":{"href":"https://api.github.com/repos/artsy/positron/issues/24/comments"},"review_comments":{"href":"https://api.github.com/repos/artsy/positron/pulls/24/comments"},"review_comment":{"href":"https://api.github.com/repos/artsy/positron/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/artsy/positron/pulls/24/commits"},"statuses":{"href":"https://api.github.com/repos/artsy/positron/statuses/bb15ac7c0c5d6076a4516c9a39e424abf3c7093d"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"mzikherman","id":1457859,"avatar_url":"https://avatars.githubusercontent.com/u/1457859?v=2","gravatar_id":"","url":"https://api.github.com/users/mzikherman","html_url":"https://github.com/mzikherman","followers_url":"https://api.github.com/users/mzikherman/followers","following_url":"https://api.github.com/users/mzikherman/following{/other_user}","gists_url":"https://api.github.com/users/mzikherman/gists{/gist_id}","starred_url":"https://api.github.com/users/mzikherman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mzikherman/subscriptions","organizations_url":"https://api.github.com/users/mzikherman/orgs","repos_url":"https://api.github.com/users/mzikherman/repos","events_url":"https://api.github.com/users/mzikherman/events{/privacy}","received_events_url":"https://api.github.com/users/mzikherman/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":2,"additions":1118,"deletions":665,"changed_files":25}}