GitHub PullRequestEvent at 2014-10-09 09:40:23
Repository: rubocop
Actor: bbatsov
Payload: {"action":"closed","number":1379,"pull_request":{"url":"https://api.github.com/repos/bbatsov/rubocop/pulls/1379","id":22453639,"html_url":"https://github.com/bbatsov/rubocop/pull/1379","diff_url":"https://github.com/bbatsov/rubocop/pull/1379.diff","patch_url":"https://github.com/bbatsov/rubocop/pull/1379.patch","issue_url":"https://api.github.com/repos/bbatsov/rubocop/issues/1379","number":1379,"state":"closed","locked":false,"title":"[Fix #1374] Always auto-correct one cop at a time","user":{"login":"jonas054","id":336720,"avatar_url":"https://avatars.githubusercontent.com/u/336720?v=2","gravatar_id":"","url":"https://api.github.com/users/jonas054","html_url":"https://github.com/jonas054","followers_url":"https://api.github.com/users/jonas054/followers","following_url":"https://api.github.com/users/jonas054/following{/other_user}","gists_url":"https://api.github.com/users/jonas054/gists{/gist_id}","starred_url":"https://api.github.com/users/jonas054/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonas054/subscriptions","organizations_url":"https://api.github.com/users/jonas054/orgs","repos_url":"https://api.github.com/users/jonas054/repos","events_url":"https://api.github.com/users/jonas054/events{/privacy}","received_events_url":"https://api.github.com/users/jonas054/received_events","type":"User","site_admin":false},"body":"The only way to guarantee that two cops don't destroy the code by doing simultaneous changes, is to save the file after letting one cop do its corrections, and then parse it again before doing any more corrections.\r\n\r\nPerformance will suffer a little bit, but I'm not worried about that. Correctness matters much more, of course.\r\n\r\nI think there are some fixes done earlier that are no longer necessary after this change. That's less important, though. We can look at those later.","created_at":"2014-10-08T20:50:56Z","updated_at":"2014-10-09T09:40:22Z","closed_at":"2014-10-09T09:40:22Z","merged_at":"2014-10-09T09:40:22Z","merge_commit_sha":"045880337a3e57d331a2da3d7482aa7f87499fee","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bbatsov/rubocop/pulls/1379/commits","review_comments_url":"https://api.github.com/repos/bbatsov/rubocop/pulls/1379/comments","review_comment_url":"https://api.github.com/repos/bbatsov/rubocop/pulls/comments/{number}","comments_url":"https://api.github.com/repos/bbatsov/rubocop/issues/1379/comments","statuses_url":"https://api.github.com/repos/bbatsov/rubocop/statuses/6e4507e4112f9bba54fc4d02116d7b560ff36a58","head":{"label":"jonas054:1374_autocorrect_problem","ref":"1374_autocorrect_problem","sha":"6e4507e4112f9bba54fc4d02116d7b560ff36a58","user":{"login":"jonas054","id":336720,"avatar_url":"https://avatars.githubusercontent.com/u/336720?v=2","gravatar_id":"","url":"https://api.github.com/users/jonas054","html_url":"https://github.com/jonas054","followers_url":"https://api.github.com/users/jonas054/followers","following_url":"https://api.github.com/users/jonas054/following{/other_user}","gists_url":"https://api.github.com/users/jonas054/gists{/gist_id}","starred_url":"https://api.github.com/users/jonas054/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonas054/subscriptions","organizations_url":"https://api.github.com/users/jonas054/orgs","repos_url":"https://api.github.com/users/jonas054/repos","events_url":"https://api.github.com/users/jonas054/events{/privacy}","received_events_url":"https://api.github.com/users/jonas054/received_events","type":"User","site_admin":false},"repo":{"id":6784696,"name":"rubocop","full_name":"jonas054/rubocop","owner":{"login":"jonas054","id":336720,"avatar_url":"https://avatars.githubusercontent.com/u/336720?v=2","gravatar_id":"","url":"https://api.github.com/users/jonas054","html_url":"https://github.com/jonas054","followers_url":"https://api.github.com/users/jonas054/followers","following_url":"https://api.github.com/users/jonas054/following{/other_user}","gists_url":"https://api.github.com/users/jonas054/gists{/gist_id}","starred_url":"https://api.github.com/users/jonas054/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonas054/subscriptions","organizations_url":"https://api.github.com/users/jonas054/orgs","repos_url":"https://api.github.com/users/jonas054/repos","events_url":"https://api.github.com/users/jonas054/events{/privacy}","received_events_url":"https://api.github.com/users/jonas054/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jonas054/rubocop","description":"A robust Ruby code analyzer, based on the community Ruby style guide.","fork":true,"url":"https://api.github.com/repos/jonas054/rubocop","forks_url":"https://api.github.com/repos/jonas054/rubocop/forks","keys_url":"https://api.github.com/repos/jonas054/rubocop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jonas054/rubocop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jonas054/rubocop/teams","hooks_url":"https://api.github.com/repos/jonas054/rubocop/hooks","issue_events_url":"https://api.github.com/repos/jonas054/rubocop/issues/events{/number}","events_url":"https://api.github.com/repos/jonas054/rubocop/events","assignees_url":"https://api.github.com/repos/jonas054/rubocop/assignees{/user}","branches_url":"https://api.github.com/repos/jonas054/rubocop/branches{/branch}","tags_url":"https://api.github.com/repos/jonas054/rubocop/tags","blobs_url":"https://api.github.com/repos/jonas054/rubocop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jonas054/rubocop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jonas054/rubocop/git/refs{/sha}","trees_url":"https://api.github.com/repos/jonas054/rubocop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jonas054/rubocop/statuses/{sha}","languages_url":"https://api.github.com/repos/jonas054/rubocop/languages","stargazers_url":"https://api.github.com/repos/jonas054/rubocop/stargazers","contributors_url":"https://api.github.com/repos/jonas054/rubocop/contributors","subscribers_url":"https://api.github.com/repos/jonas054/rubocop/subscribers","subscription_url":"https://api.github.com/repos/jonas054/rubocop/subscription","commits_url":"https://api.github.com/repos/jonas054/rubocop/commits{/sha}","git_commits_url":"https://api.github.com/repos/jonas054/rubocop/git/commits{/sha}","comments_url":"https://api.github.com/repos/jonas054/rubocop/comments{/number}","issue_comment_url":"https://api.github.com/repos/jonas054/rubocop/issues/comments/{number}","contents_url":"https://api.github.com/repos/jonas054/rubocop/contents/{+path}","compare_url":"https://api.github.com/repos/jonas054/rubocop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jonas054/rubocop/merges","archive_url":"https://api.github.com/repos/jonas054/rubocop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jonas054/rubocop/downloads","issues_url":"https://api.github.com/repos/jonas054/rubocop/issues{/number}","pulls_url":"https://api.github.com/repos/jonas054/rubocop/pulls{/number}","milestones_url":"https://api.github.com/repos/jonas054/rubocop/milestones{/number}","notifications_url":"https://api.github.com/repos/jonas054/rubocop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jonas054/rubocop/labels{/name}","releases_url":"https://api.github.com/repos/jonas054/rubocop/releases{/id}","created_at":"2012-11-20T20:34:59Z","updated_at":"2014-06-25T04:33:40Z","pushed_at":"2014-10-08T20:58:38Z","git_url":"git://github.com/jonas054/rubocop.git","ssh_url":"git@github.com:jonas054/rubocop.git","clone_url":"https://github.com/jonas054/rubocop.git","svn_url":"https://github.com/jonas054/rubocop","homepage":"","size":10357,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bbatsov:master","ref":"master","sha":"b152eac0620104f5d9ffbe99c7c6cff9d95334b6","user":{"login":"bbatsov","id":103882,"avatar_url":"https://avatars.githubusercontent.com/u/103882?v=2","gravatar_id":"","url":"https://api.github.com/users/bbatsov","html_url":"https://github.com/bbatsov","followers_url":"https://api.github.com/users/bbatsov/followers","following_url":"https://api.github.com/users/bbatsov/following{/other_user}","gists_url":"https://api.github.com/users/bbatsov/gists{/gist_id}","starred_url":"https://api.github.com/users/bbatsov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbatsov/subscriptions","organizations_url":"https://api.github.com/users/bbatsov/orgs","repos_url":"https://api.github.com/users/bbatsov/repos","events_url":"https://api.github.com/users/bbatsov/events{/privacy}","received_events_url":"https://api.github.com/users/bbatsov/received_events","type":"User","site_admin":false},"repo":{"id":4095287,"name":"rubocop","full_name":"bbatsov/rubocop","owner":{"login":"bbatsov","id":103882,"avatar_url":"https://avatars.githubusercontent.com/u/103882?v=2","gravatar_id":"","url":"https://api.github.com/users/bbatsov","html_url":"https://github.com/bbatsov","followers_url":"https://api.github.com/users/bbatsov/followers","following_url":"https://api.github.com/users/bbatsov/following{/other_user}","gists_url":"https://api.github.com/users/bbatsov/gists{/gist_id}","starred_url":"https://api.github.com/users/bbatsov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbatsov/subscriptions","organizations_url":"https://api.github.com/users/bbatsov/orgs","repos_url":"https://api.github.com/users/bbatsov/repos","events_url":"https://api.github.com/users/bbatsov/events{/privacy}","received_events_url":"https://api.github.com/users/bbatsov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bbatsov/rubocop","description":"A Ruby static code analyzer, based on the community Ruby style guide.","fork":false,"url":"https://api.github.com/repos/bbatsov/rubocop","forks_url":"https://api.github.com/repos/bbatsov/rubocop/forks","keys_url":"https://api.github.com/repos/bbatsov/rubocop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bbatsov/rubocop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bbatsov/rubocop/teams","hooks_url":"https://api.github.com/repos/bbatsov/rubocop/hooks","issue_events_url":"https://api.github.com/repos/bbatsov/rubocop/issues/events{/number}","events_url":"https://api.github.com/repos/bbatsov/rubocop/events","assignees_url":"https://api.github.com/repos/bbatsov/rubocop/assignees{/user}","branches_url":"https://api.github.com/repos/bbatsov/rubocop/branches{/branch}","tags_url":"https://api.github.com/repos/bbatsov/rubocop/tags","blobs_url":"https://api.github.com/repos/bbatsov/rubocop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bbatsov/rubocop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bbatsov/rubocop/git/refs{/sha}","trees_url":"https://api.github.com/repos/bbatsov/rubocop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bbatsov/rubocop/statuses/{sha}","languages_url":"https://api.github.com/repos/bbatsov/rubocop/languages","stargazers_url":"https://api.github.com/repos/bbatsov/rubocop/stargazers","contributors_url":"https://api.github.com/repos/bbatsov/rubocop/contributors","subscribers_url":"https://api.github.com/repos/bbatsov/rubocop/subscribers","subscription_url":"https://api.github.com/repos/bbatsov/rubocop/subscription","commits_url":"https://api.github.com/repos/bbatsov/rubocop/commits{/sha}","git_commits_url":"https://api.github.com/repos/bbatsov/rubocop/git/commits{/sha}","comments_url":"https://api.github.com/repos/bbatsov/rubocop/comments{/number}","issue_comment_url":"https://api.github.com/repos/bbatsov/rubocop/issues/comments/{number}","contents_url":"https://api.github.com/repos/bbatsov/rubocop/contents/{+path}","compare_url":"https://api.github.com/repos/bbatsov/rubocop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bbatsov/rubocop/merges","archive_url":"https://api.github.com/repos/bbatsov/rubocop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bbatsov/rubocop/downloads","issues_url":"https://api.github.com/repos/bbatsov/rubocop/issues{/number}","pulls_url":"https://api.github.com/repos/bbatsov/rubocop/pulls{/number}","milestones_url":"https://api.github.com/repos/bbatsov/rubocop/milestones{/number}","notifications_url":"https://api.github.com/repos/bbatsov/rubocop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bbatsov/rubocop/labels{/name}","releases_url":"https://api.github.com/repos/bbatsov/rubocop/releases{/id}","created_at":"2012-04-21T10:09:58Z","updated_at":"2014-10-09T07:33:20Z","pushed_at":"2014-10-09T09:40:22Z","git_url":"git://github.com/bbatsov/rubocop.git","ssh_url":"git@github.com:bbatsov/rubocop.git","clone_url":"https://github.com/bbatsov/rubocop.git","svn_url":"https://github.com/bbatsov/rubocop","homepage":"","size":22458,"stargazers_count":3030,"watchers_count":3030,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":306,"mirror_url":null,"open_issues_count":58,"forks":306,"open_issues":58,"watchers":3030,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bbatsov/rubocop/pulls/1379"},"html":{"href":"https://github.com/bbatsov/rubocop/pull/1379"},"issue":{"href":"https://api.github.com/repos/bbatsov/rubocop/issues/1379"},"comments":{"href":"https://api.github.com/repos/bbatsov/rubocop/issues/1379/comments"},"review_comments":{"href":"https://api.github.com/repos/bbatsov/rubocop/pulls/1379/comments"},"review_comment":{"href":"https://api.github.com/repos/bbatsov/rubocop/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/bbatsov/rubocop/pulls/1379/commits"},"statuses":{"href":"https://api.github.com/repos/bbatsov/rubocop/statuses/6e4507e4112f9bba54fc4d02116d7b560ff36a58"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"bbatsov","id":103882,"avatar_url":"https://avatars.githubusercontent.com/u/103882?v=2","gravatar_id":"","url":"https://api.github.com/users/bbatsov","html_url":"https://github.com/bbatsov","followers_url":"https://api.github.com/users/bbatsov/followers","following_url":"https://api.github.com/users/bbatsov/following{/other_user}","gists_url":"https://api.github.com/users/bbatsov/gists{/gist_id}","starred_url":"https://api.github.com/users/bbatsov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbatsov/subscriptions","organizations_url":"https://api.github.com/users/bbatsov/orgs","repos_url":"https://api.github.com/users/bbatsov/repos","events_url":"https://api.github.com/users/bbatsov/events{/privacy}","received_events_url":"https://api.github.com/users/bbatsov/received_events","type":"User","site_admin":false},"comments":1,"review_comments":2,"commits":1,"additions":37,"deletions":41,"changed_files":3}}