GitHub PullRequestReviewCommentEvent at 2014-12-19 19:23:50
Repository: python-agent
Actor: cjellick
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/rancherio/python-agent/pulls/comments/22123293","id":22123293,"diff_hunk":"@@ -499,6 +538,48 @@ def postFalse(req, resp):\n \n \n @if_docker\n+def test_instance_restart_policy(agent, responses):\n+    _delete_container('/c861f990-4472-4fa1-960f-65171b544c28')\n+    expected_restart_policy = {\"MaximumRetryCount\": 0,\n+                               \"Name\": \"always\"}\n+\n+    def pre(req):\n+        instance = req['data']['instanceHostMap']['instance']\n+        instance['data']['fields']['restartPolicy'] = expected_restart_policy\n+\n+    def post(req, resp):\n+        docker_inspect = resp['data']['instance']['+data']['dockerInspect']\n+        docker_object = docker_inspect['HostConfig']['RestartPolicy']\n+        for x_value, y_value in zip(expected_restart_policy.iteritems(),","path":"tests/test_docker.py","position":62,"original_position":62,"commit_id":"2b4fe30c7911d4df062040e0eeada132b7630f98","original_commit_id":"2d3801a4827c4e12e90ef6f2a886132195ecdea7","user":{"login":"cjellick","id":2473240,"avatar_url":"https://avatars.githubusercontent.com/u/2473240?v=3","gravatar_id":"","url":"https://api.github.com/users/cjellick","html_url":"https://github.com/cjellick","followers_url":"https://api.github.com/users/cjellick/followers","following_url":"https://api.github.com/users/cjellick/following{/other_user}","gists_url":"https://api.github.com/users/cjellick/gists{/gist_id}","starred_url":"https://api.github.com/users/cjellick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjellick/subscriptions","organizations_url":"https://api.github.com/users/cjellick/orgs","repos_url":"https://api.github.com/users/cjellick/repos","events_url":"https://api.github.com/users/cjellick/events{/privacy}","received_events_url":"https://api.github.com/users/cjellick/received_events","type":"User","site_admin":false},"body":"We were holding off on #2 until we made a decision on #3. Since that is now decided (json that matches the docker api exactly). You can address #2. Remove zipping. You should be able to simply do == on the maps.","created_at":"2014-12-19T19:23:50Z","updated_at":"2014-12-19T19:23:50Z","html_url":"https://github.com/rancherio/python-agent/pull/25#discussion_r22123293","pull_request_url":"https://api.github.com/repos/rancherio/python-agent/pulls/25","_links":{"self":{"href":"https://api.github.com/repos/rancherio/python-agent/pulls/comments/22123293"},"html":{"href":"https://github.com/rancherio/python-agent/pull/25#discussion_r22123293"},"pull_request":{"href":"https://api.github.com/repos/rancherio/python-agent/pulls/25"}}},"pull_request":{"url":"https://api.github.com/repos/rancherio/python-agent/pulls/25","id":25876512,"html_url":"https://github.com/rancherio/python-agent/pull/25","diff_url":"https://github.com/rancherio/python-agent/pull/25.diff","patch_url":"https://github.com/rancherio/python-agent/pull/25.patch","issue_url":"https://api.github.com/repos/rancherio/python-agent/issues/25","number":25,"state":"open","locked":false,"title":"Memory test","user":{"login":"pranavs18","id":2172083,"avatar_url":"https://avatars.githubusercontent.com/u/2172083?v=3","gravatar_id":"","url":"https://api.github.com/users/pranavs18","html_url":"https://github.com/pranavs18","followers_url":"https://api.github.com/users/pranavs18/followers","following_url":"https://api.github.com/users/pranavs18/following{/other_user}","gists_url":"https://api.github.com/users/pranavs18/gists{/gist_id}","starred_url":"https://api.github.com/users/pranavs18/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pranavs18/subscriptions","organizations_url":"https://api.github.com/users/pranavs18/orgs","repos_url":"https://api.github.com/users/pranavs18/repos","events_url":"https://api.github.com/users/pranavs18/events{/privacy}","received_events_url":"https://api.github.com/users/pranavs18/received_events","type":"User","site_admin":false},"body":"@ibuildthecloud - I just copy pasted the files from his repo :)","created_at":"2014-12-11T04:44:58Z","updated_at":"2014-12-19T19:23:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2c0cd448c7bab9a1ff2dc70749e3f6dca6eafd74","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rancherio/python-agent/pulls/25/commits","review_comments_url":"https://api.github.com/repos/rancherio/python-agent/pulls/25/comments","review_comment_url":"https://api.github.com/repos/rancherio/python-agent/pulls/comments/{number}","comments_url":"https://api.github.com/repos/rancherio/python-agent/issues/25/comments","statuses_url":"https://api.github.com/repos/rancherio/python-agent/statuses/2b4fe30c7911d4df062040e0eeada132b7630f98","head":{"label":"pranavs18:memory_test","ref":"memory_test","sha":"2b4fe30c7911d4df062040e0eeada132b7630f98","user":{"login":"pranavs18","id":2172083,"avatar_url":"https://avatars.githubusercontent.com/u/2172083?v=3","gravatar_id":"","url":"https://api.github.com/users/pranavs18","html_url":"https://github.com/pranavs18","followers_url":"https://api.github.com/users/pranavs18/followers","following_url":"https://api.github.com/users/pranavs18/following{/other_user}","gists_url":"https://api.github.com/users/pranavs18/gists{/gist_id}","starred_url":"https://api.github.com/users/pranavs18/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pranavs18/subscriptions","organizations_url":"https://api.github.com/users/pranavs18/orgs","repos_url":"https://api.github.com/users/pranavs18/repos","events_url":"https://api.github.com/users/pranavs18/events{/privacy}","received_events_url":"https://api.github.com/users/pranavs18/received_events","type":"User","site_admin":false},"repo":{"id":27853956,"name":"python-agent","full_name":"pranavs18/python-agent","owner":{"login":"pranavs18","id":2172083,"avatar_url":"https://avatars.githubusercontent.com/u/2172083?v=3","gravatar_id":"","url":"https://api.github.com/users/pranavs18","html_url":"https://github.com/pranavs18","followers_url":"https://api.github.com/users/pranavs18/followers","following_url":"https://api.github.com/users/pranavs18/following{/other_user}","gists_url":"https://api.github.com/users/pranavs18/gists{/gist_id}","starred_url":"https://api.github.com/users/pranavs18/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pranavs18/subscriptions","organizations_url":"https://api.github.com/users/pranavs18/orgs","repos_url":"https://api.github.com/users/pranavs18/repos","events_url":"https://api.github.com/users/pranavs18/events{/privacy}","received_events_url":"https://api.github.com/users/pranavs18/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pranavs18/python-agent","description":"Python agent for Rancher","fork":true,"url":"https://api.github.com/repos/pranavs18/python-agent","forks_url":"https://api.github.com/repos/pranavs18/python-agent/forks","keys_url":"https://api.github.com/repos/pranavs18/python-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pranavs18/python-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pranavs18/python-agent/teams","hooks_url":"https://api.github.com/repos/pranavs18/python-agent/hooks","issue_events_url":"https://api.github.com/repos/pranavs18/python-agent/issues/events{/number}","events_url":"https://api.github.com/repos/pranavs18/python-agent/events","assignees_url":"https://api.github.com/repos/pranavs18/python-agent/assignees{/user}","branches_url":"https://api.github.com/repos/pranavs18/python-agent/branches{/branch}","tags_url":"https://api.github.com/repos/pranavs18/python-agent/tags","blobs_url":"https://api.github.com/repos/pranavs18/python-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pranavs18/python-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pranavs18/python-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/pranavs18/python-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pranavs18/python-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/pranavs18/python-agent/languages","stargazers_url":"https://api.github.com/repos/pranavs18/python-agent/stargazers","contributors_url":"https://api.github.com/repos/pranavs18/python-agent/contributors","subscribers_url":"https://api.github.com/repos/pranavs18/python-agent/subscribers","subscription_url":"https://api.github.com/repos/pranavs18/python-agent/subscription","commits_url":"https://api.github.com/repos/pranavs18/python-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/pranavs18/python-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/pranavs18/python-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/pranavs18/python-agent/issues/comments/{number}","contents_url":"https://api.github.com/repos/pranavs18/python-agent/contents/{+path}","compare_url":"https://api.github.com/repos/pranavs18/python-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pranavs18/python-agent/merges","archive_url":"https://api.github.com/repos/pranavs18/python-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pranavs18/python-agent/downloads","issues_url":"https://api.github.com/repos/pranavs18/python-agent/issues{/number}","pulls_url":"https://api.github.com/repos/pranavs18/python-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/pranavs18/python-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/pranavs18/python-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pranavs18/python-agent/labels{/name}","releases_url":"https://api.github.com/repos/pranavs18/python-agent/releases{/id}","created_at":"2014-12-11T04:24:15Z","updated_at":"2014-12-11T04:24:15Z","pushed_at":"2014-12-18T23:32:09Z","git_url":"git://github.com/pranavs18/python-agent.git","ssh_url":"git@github.com:pranavs18/python-agent.git","clone_url":"https://github.com/pranavs18/python-agent.git","svn_url":"https://github.com/pranavs18/python-agent","homepage":null,"size":5276,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rancherio:master","ref":"master","sha":"8bc9cd2335c4f278e65431c80726f2c8b925edaa","user":{"login":"rancherio","id":9343010,"avatar_url":"https://avatars.githubusercontent.com/u/9343010?v=3","gravatar_id":"","url":"https://api.github.com/users/rancherio","html_url":"https://github.com/rancherio","followers_url":"https://api.github.com/users/rancherio/followers","following_url":"https://api.github.com/users/rancherio/following{/other_user}","gists_url":"https://api.github.com/users/rancherio/gists{/gist_id}","starred_url":"https://api.github.com/users/rancherio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rancherio/subscriptions","organizations_url":"https://api.github.com/users/rancherio/orgs","repos_url":"https://api.github.com/users/rancherio/repos","events_url":"https://api.github.com/users/rancherio/events{/privacy}","received_events_url":"https://api.github.com/users/rancherio/received_events","type":"Organization","site_admin":false},"repo":{"id":26792702,"name":"python-agent","full_name":"rancherio/python-agent","owner":{"login":"rancherio","id":9343010,"avatar_url":"https://avatars.githubusercontent.com/u/9343010?v=3","gravatar_id":"","url":"https://api.github.com/users/rancherio","html_url":"https://github.com/rancherio","followers_url":"https://api.github.com/users/rancherio/followers","following_url":"https://api.github.com/users/rancherio/following{/other_user}","gists_url":"https://api.github.com/users/rancherio/gists{/gist_id}","starred_url":"https://api.github.com/users/rancherio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rancherio/subscriptions","organizations_url":"https://api.github.com/users/rancherio/orgs","repos_url":"https://api.github.com/users/rancherio/repos","events_url":"https://api.github.com/users/rancherio/events{/privacy}","received_events_url":"https://api.github.com/users/rancherio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rancherio/python-agent","description":"Python agent for Rancher","fork":false,"url":"https://api.github.com/repos/rancherio/python-agent","forks_url":"https://api.github.com/repos/rancherio/python-agent/forks","keys_url":"https://api.github.com/repos/rancherio/python-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rancherio/python-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rancherio/python-agent/teams","hooks_url":"https://api.github.com/repos/rancherio/python-agent/hooks","issue_events_url":"https://api.github.com/repos/rancherio/python-agent/issues/events{/number}","events_url":"https://api.github.com/repos/rancherio/python-agent/events","assignees_url":"https://api.github.com/repos/rancherio/python-agent/assignees{/user}","branches_url":"https://api.github.com/repos/rancherio/python-agent/branches{/branch}","tags_url":"https://api.github.com/repos/rancherio/python-agent/tags","blobs_url":"https://api.github.com/repos/rancherio/python-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rancherio/python-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rancherio/python-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/rancherio/python-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rancherio/python-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/rancherio/python-agent/languages","stargazers_url":"https://api.github.com/repos/rancherio/python-agent/stargazers","contributors_url":"https://api.github.com/repos/rancherio/python-agent/contributors","subscribers_url":"https://api.github.com/repos/rancherio/python-agent/subscribers","subscription_url":"https://api.github.com/repos/rancherio/python-agent/subscription","commits_url":"https://api.github.com/repos/rancherio/python-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/rancherio/python-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/rancherio/python-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/rancherio/python-agent/issues/comments/{number}","contents_url":"https://api.github.com/repos/rancherio/python-agent/contents/{+path}","compare_url":"https://api.github.com/repos/rancherio/python-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rancherio/python-agent/merges","archive_url":"https://api.github.com/repos/rancherio/python-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rancherio/python-agent/downloads","issues_url":"https://api.github.com/repos/rancherio/python-agent/issues{/number}","pulls_url":"https://api.github.com/repos/rancherio/python-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/rancherio/python-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/rancherio/python-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rancherio/python-agent/labels{/name}","releases_url":"https://api.github.com/repos/rancherio/python-agent/releases{/id}","created_at":"2014-11-18T05:00:53Z","updated_at":"2014-12-18T17:43:59Z","pushed_at":"2014-12-18T17:43:59Z","git_url":"git://github.com/rancherio/python-agent.git","ssh_url":"git@github.com:rancherio/python-agent.git","clone_url":"https://github.com/rancherio/python-agent.git","svn_url":"https://github.com/rancherio/python-agent","homepage":null,"size":6082,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":9,"forks":5,"open_issues":9,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rancherio/python-agent/pulls/25"},"html":{"href":"https://github.com/rancherio/python-agent/pull/25"},"issue":{"href":"https://api.github.com/repos/rancherio/python-agent/issues/25"},"comments":{"href":"https://api.github.com/repos/rancherio/python-agent/issues/25/comments"},"review_comments":{"href":"https://api.github.com/repos/rancherio/python-agent/pulls/25/comments"},"review_comment":{"href":"https://api.github.com/repos/rancherio/python-agent/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/rancherio/python-agent/pulls/25/commits"},"statuses":{"href":"https://api.github.com/repos/rancherio/python-agent/statuses/2b4fe30c7911d4df062040e0eeada132b7630f98"}}}}