GitHub PullRequestReviewCommentEvent at 2014-09-17 19:59:53
Repository: gaia
Actor: gaye
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/17689724","id":17689724,"diff_hunk":"@@ -0,0 +1,10 @@\n+define(function(require, exports) {\n+'use strict';\n+\n+exports.Abstract = require('./abstract');\n+exports.Caldav = require('./caldav');\n+exports.CaldavPullEvents = require('./caldav_pull_events');\n+exports.CaldavVisualLog = require('./caldav_visual_log');\n+exports.Local = require('./local');","path":"apps/calendar/js/provider/provider.js","position":8,"original_position":8,"commit_id":"beb14b051999c5940d913b2814328c58cf6ec9c0","original_commit_id":"39b3c48d57bb6d70ba3d993d16e0c32b8db74794","user":{"login":"gaye","id":535859,"avatar_url":"https://avatars.githubusercontent.com/u/535859?v=2","gravatar_id":"e781ab5c4935bc74643c593608505556","url":"https://api.github.com/users/gaye","html_url":"https://github.com/gaye","followers_url":"https://api.github.com/users/gaye/followers","following_url":"https://api.github.com/users/gaye/following{/other_user}","gists_url":"https://api.github.com/users/gaye/gists{/gist_id}","starred_url":"https://api.github.com/users/gaye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaye/subscriptions","organizations_url":"https://api.github.com/users/gaye/orgs","repos_url":"https://api.github.com/users/gaye/repos","events_url":"https://api.github.com/users/gaye/events{/privacy}","received_events_url":"https://api.github.com/users/gaye/received_events","type":"User","site_admin":false},"body":"This one I kept for `app#provider` but we should do a followup where that gets removed","created_at":"2014-09-17T19:59:53Z","updated_at":"2014-09-17T19:59:53Z","html_url":"https://github.com/mozilla-b2g/gaia/pull/23775#discussion_r17689724","pull_request_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/23775","_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/17689724"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/23775#discussion_r17689724"},"pull_request":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/23775"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/23775","id":20829994,"html_url":"https://github.com/mozilla-b2g/gaia/pull/23775","diff_url":"https://github.com/mozilla-b2g/gaia/pull/23775.diff","patch_url":"https://github.com/mozilla-b2g/gaia/pull/23775.patch","issue_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/23775","number":23775,"state":"open","locked":false,"title":"Bug 1027707 - Replace the existing module loading facilities in calendar r=millermedeiros","user":{"login":"gaye","id":535859,"avatar_url":"https://avatars.githubusercontent.com/u/535859?v=2","gravatar_id":"e781ab5c4935bc74643c593608505556","url":"https://api.github.com/users/gaye","html_url":"https://github.com/gaye","followers_url":"https://api.github.com/users/gaye/followers","following_url":"https://api.github.com/users/gaye/following{/other_user}","gists_url":"https://api.github.com/users/gaye/gists{/gist_id}","starred_url":"https://api.github.com/users/gaye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaye/subscriptions","organizations_url":"https://api.github.com/users/gaye/orgs","repos_url":"https://api.github.com/users/gaye/repos","events_url":"https://api.github.com/users/gaye/events{/privacy}","received_events_url":"https://api.github.com/users/gaye/received_events","type":"User","site_admin":false},"body":"### Change Summary\r\n\r\n+ Move default configuration in build into separate json configuration file\r\n+ Only load `main.js` in `index.html`\r\n+ Get rid of lots of app-specific globals from `.jshintrc`\r\n+ Turn all js files (except for `main.js`, `caldav_worker.js`, `test/unit/setup.js`, and some stuff in `ext/`) into amd modules\r\n+ require `alameda.js@0.2.0` in `package.json`\r\n+ No more `LazyLoader`, `LoadConfig`, and `NotAmd`","created_at":"2014-09-05T19:42:18Z","updated_at":"2014-09-17T19:59:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"596651b01acabadc98d04411645a13871429632e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/23775/commits","review_comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/23775/comments","review_comment_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/23775/comments","statuses_url":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/beb14b051999c5940d913b2814328c58cf6ec9c0","head":{"label":"gaye:calendar-amd","ref":"calendar-amd","sha":"beb14b051999c5940d913b2814328c58cf6ec9c0","user":{"login":"gaye","id":535859,"avatar_url":"https://avatars.githubusercontent.com/u/535859?v=2","gravatar_id":"e781ab5c4935bc74643c593608505556","url":"https://api.github.com/users/gaye","html_url":"https://github.com/gaye","followers_url":"https://api.github.com/users/gaye/followers","following_url":"https://api.github.com/users/gaye/following{/other_user}","gists_url":"https://api.github.com/users/gaye/gists{/gist_id}","starred_url":"https://api.github.com/users/gaye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaye/subscriptions","organizations_url":"https://api.github.com/users/gaye/orgs","repos_url":"https://api.github.com/users/gaye/repos","events_url":"https://api.github.com/users/gaye/events{/privacy}","received_events_url":"https://api.github.com/users/gaye/received_events","type":"User","site_admin":false},"repo":{"id":9064811,"name":"gaia","full_name":"gaye/gaia","owner":{"login":"gaye","id":535859,"avatar_url":"https://avatars.githubusercontent.com/u/535859?v=2","gravatar_id":"e781ab5c4935bc74643c593608505556","url":"https://api.github.com/users/gaye","html_url":"https://github.com/gaye","followers_url":"https://api.github.com/users/gaye/followers","following_url":"https://api.github.com/users/gaye/following{/other_user}","gists_url":"https://api.github.com/users/gaye/gists{/gist_id}","starred_url":"https://api.github.com/users/gaye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaye/subscriptions","organizations_url":"https://api.github.com/users/gaye/orgs","repos_url":"https://api.github.com/users/gaye/repos","events_url":"https://api.github.com/users/gaye/events{/privacy}","received_events_url":"https://api.github.com/users/gaye/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gaye/gaia","description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see https://wiki.mozilla.org/Release_Management/B2G_Landing","fork":true,"url":"https://api.github.com/repos/gaye/gaia","forks_url":"https://api.github.com/repos/gaye/gaia/forks","keys_url":"https://api.github.com/repos/gaye/gaia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gaye/gaia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gaye/gaia/teams","hooks_url":"https://api.github.com/repos/gaye/gaia/hooks","issue_events_url":"https://api.github.com/repos/gaye/gaia/issues/events{/number}","events_url":"https://api.github.com/repos/gaye/gaia/events","assignees_url":"https://api.github.com/repos/gaye/gaia/assignees{/user}","branches_url":"https://api.github.com/repos/gaye/gaia/branches{/branch}","tags_url":"https://api.github.com/repos/gaye/gaia/tags","blobs_url":"https://api.github.com/repos/gaye/gaia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gaye/gaia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gaye/gaia/git/refs{/sha}","trees_url":"https://api.github.com/repos/gaye/gaia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gaye/gaia/statuses/{sha}","languages_url":"https://api.github.com/repos/gaye/gaia/languages","stargazers_url":"https://api.github.com/repos/gaye/gaia/stargazers","contributors_url":"https://api.github.com/repos/gaye/gaia/contributors","subscribers_url":"https://api.github.com/repos/gaye/gaia/subscribers","subscription_url":"https://api.github.com/repos/gaye/gaia/subscription","commits_url":"https://api.github.com/repos/gaye/gaia/commits{/sha}","git_commits_url":"https://api.github.com/repos/gaye/gaia/git/commits{/sha}","comments_url":"https://api.github.com/repos/gaye/gaia/comments{/number}","issue_comment_url":"https://api.github.com/repos/gaye/gaia/issues/comments/{number}","contents_url":"https://api.github.com/repos/gaye/gaia/contents/{+path}","compare_url":"https://api.github.com/repos/gaye/gaia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gaye/gaia/merges","archive_url":"https://api.github.com/repos/gaye/gaia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gaye/gaia/downloads","issues_url":"https://api.github.com/repos/gaye/gaia/issues{/number}","pulls_url":"https://api.github.com/repos/gaye/gaia/pulls{/number}","milestones_url":"https://api.github.com/repos/gaye/gaia/milestones{/number}","notifications_url":"https://api.github.com/repos/gaye/gaia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gaye/gaia/labels{/name}","releases_url":"https://api.github.com/repos/gaye/gaia/releases{/id}","created_at":"2013-03-27T22:12:16Z","updated_at":"2014-07-29T08:27:25Z","pushed_at":"2014-09-17T19:59:03Z","git_url":"git://github.com/gaye/gaia.git","ssh_url":"git@github.com:gaye/gaia.git","clone_url":"https://github.com/gaye/gaia.git","svn_url":"https://github.com/gaye/gaia","homepage":"https://wiki.mozilla.org/B2G","size":816364,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"mozilla-b2g:master","ref":"master","sha":"f33bf136220e1c114aadaf63237be6bbdc834b53","user":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=2","gravatar_id":"b1de11f7d6ddaf7b9d527281297c2ee1","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"repo":{"id":2317369,"name":"gaia","full_name":"mozilla-b2g/gaia","owner":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=2","gravatar_id":"b1de11f7d6ddaf7b9d527281297c2ee1","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-b2g/gaia","description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see","fork":false,"url":"https://api.github.com/repos/mozilla-b2g/gaia","forks_url":"https://api.github.com/repos/mozilla-b2g/gaia/forks","keys_url":"https://api.github.com/repos/mozilla-b2g/gaia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-b2g/gaia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-b2g/gaia/teams","hooks_url":"https://api.github.com/repos/mozilla-b2g/gaia/hooks","issue_events_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-b2g/gaia/events","assignees_url":"https://api.github.com/repos/mozilla-b2g/gaia/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-b2g/gaia/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-b2g/gaia/tags","blobs_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-b2g/gaia/languages","stargazers_url":"https://api.github.com/repos/mozilla-b2g/gaia/stargazers","contributors_url":"https://api.github.com/repos/mozilla-b2g/gaia/contributors","subscribers_url":"https://api.github.com/repos/mozilla-b2g/gaia/subscribers","subscription_url":"https://api.github.com/repos/mozilla-b2g/gaia/subscription","commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/comments/{number}","contents_url":"https://api.github.com/repos/mozilla-b2g/gaia/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-b2g/gaia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-b2g/gaia/merges","archive_url":"https://api.github.com/repos/mozilla-b2g/gaia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-b2g/gaia/downloads","issues_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-b2g/gaia/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-b2g/gaia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-b2g/gaia/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-b2g/gaia/releases{/id}","created_at":"2011-09-03T01:38:46Z","updated_at":"2014-09-17T10:29:00Z","pushed_at":"2014-09-17T19:15:53Z","git_url":"git://github.com/mozilla-b2g/gaia.git","ssh_url":"git@github.com:mozilla-b2g/gaia.git","clone_url":"https://github.com/mozilla-b2g/gaia.git","svn_url":"https://github.com/mozilla-b2g/gaia","homepage":"https://wiki.mozilla.org/B2G","size":1439404,"stargazers_count":1743,"watchers_count":1743,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1914,"mirror_url":null,"open_issues_count":2029,"forks":1914,"open_issues":2029,"watchers":1743,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/23775"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/23775"},"issue":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/issues/23775"},"comments":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/issues/23775/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/23775/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/23775/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/beb14b051999c5940d913b2814328c58cf6ec9c0"}}}}