GitHub PullRequestReviewCommentEvent at 2014-11-01 02:11:55
Repository: stk-code
Actor: sachith500
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/supertuxkart/stk-code/pulls/comments/19701114","id":19701114,"diff_hunk":"@@ -282,4 +297,31 @@ int ScriptEngine::compileScript(asIScriptEngine *engine, std::string scriptName)\n     return 0;\n }\n \n+//-----------------------------------------------------------------------------\n+/** Checks if the script has already been compiled/built before\n+*  \\param string scriptname = name of the script currently under consideration\n+*/\n+bool ScriptEngine::isCacheMiss(std::string scriptname)\n+{\n+    for (int i = 0; i < m_cache_index.size(); i++)\n+    {\n+        if (m_cache_index[i] == scriptname) return false;\n+    }","path":"src/scriptengine/script_engine.cpp","position":158,"original_position":158,"commit_id":"ebb914d0ef2e74058883eab254205d00781a67b8","original_commit_id":"ebb914d0ef2e74058883eab254205d00781a67b8","user":{"login":"sachith500","id":1452526,"avatar_url":"https://avatars.githubusercontent.com/u/1452526?v=2","gravatar_id":"","url":"https://api.github.com/users/sachith500","html_url":"https://github.com/sachith500","followers_url":"https://api.github.com/users/sachith500/followers","following_url":"https://api.github.com/users/sachith500/following{/other_user}","gists_url":"https://api.github.com/users/sachith500/gists{/gist_id}","starred_url":"https://api.github.com/users/sachith500/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sachith500/subscriptions","organizations_url":"https://api.github.com/users/sachith500/orgs","repos_url":"https://api.github.com/users/sachith500/repos","events_url":"https://api.github.com/users/sachith500/events{/privacy}","received_events_url":"https://api.github.com/users/sachith500/received_events","type":"User","site_admin":false},"body":"yeah, a map indexed by the name itself sounds good. will do that.","created_at":"2014-11-01T02:11:55Z","updated_at":"2014-11-01T02:11:55Z","html_url":"https://github.com/supertuxkart/stk-code/pull/1649#discussion_r19701114","pull_request_url":"https://api.github.com/repos/supertuxkart/stk-code/pulls/1649","_links":{"self":{"href":"https://api.github.com/repos/supertuxkart/stk-code/pulls/comments/19701114"},"html":{"href":"https://github.com/supertuxkart/stk-code/pull/1649#discussion_r19701114"},"pull_request":{"href":"https://api.github.com/repos/supertuxkart/stk-code/pulls/1649"}}},"pull_request":{"url":"https://api.github.com/repos/supertuxkart/stk-code/pulls/1649","id":23668759,"html_url":"https://github.com/supertuxkart/stk-code/pull/1649","diff_url":"https://github.com/supertuxkart/stk-code/pull/1649.diff","patch_url":"https://github.com/supertuxkart/stk-code/pull/1649.patch","issue_url":"https://api.github.com/repos/supertuxkart/stk-code/issues/1649","number":1649,"state":"open","locked":false,"title":"Script cache","user":{"login":"sachith500","id":1452526,"avatar_url":"https://avatars.githubusercontent.com/u/1452526?v=2","gravatar_id":"","url":"https://api.github.com/users/sachith500","html_url":"https://github.com/sachith500","followers_url":"https://api.github.com/users/sachith500/followers","following_url":"https://api.github.com/users/sachith500/following{/other_user}","gists_url":"https://api.github.com/users/sachith500/gists{/gist_id}","starred_url":"https://api.github.com/users/sachith500/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sachith500/subscriptions","organizations_url":"https://api.github.com/users/sachith500/orgs","repos_url":"https://api.github.com/users/sachith500/repos","events_url":"https://api.github.com/users/sachith500/events{/privacy}","received_events_url":"https://api.github.com/users/sachith500/received_events","type":"User","site_admin":false},"body":"Added Caching to scripts.","created_at":"2014-10-31T10:58:02Z","updated_at":"2014-11-01T02:11:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"877971cb2400fd2ea7dc0ed697274e76b59410b5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/supertuxkart/stk-code/pulls/1649/commits","review_comments_url":"https://api.github.com/repos/supertuxkart/stk-code/pulls/1649/comments","review_comment_url":"https://api.github.com/repos/supertuxkart/stk-code/pulls/comments/{number}","comments_url":"https://api.github.com/repos/supertuxkart/stk-code/issues/1649/comments","statuses_url":"https://api.github.com/repos/supertuxkart/stk-code/statuses/ebb914d0ef2e74058883eab254205d00781a67b8","head":{"label":"sachith500:ScriptCache","ref":"ScriptCache","sha":"ebb914d0ef2e74058883eab254205d00781a67b8","user":{"login":"sachith500","id":1452526,"avatar_url":"https://avatars.githubusercontent.com/u/1452526?v=2","gravatar_id":"","url":"https://api.github.com/users/sachith500","html_url":"https://github.com/sachith500","followers_url":"https://api.github.com/users/sachith500/followers","following_url":"https://api.github.com/users/sachith500/following{/other_user}","gists_url":"https://api.github.com/users/sachith500/gists{/gist_id}","starred_url":"https://api.github.com/users/sachith500/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sachith500/subscriptions","organizations_url":"https://api.github.com/users/sachith500/orgs","repos_url":"https://api.github.com/users/sachith500/repos","events_url":"https://api.github.com/users/sachith500/events{/privacy}","received_events_url":"https://api.github.com/users/sachith500/received_events","type":"User","site_admin":false},"repo":{"id":16307441,"name":"stk-code","full_name":"sachith500/stk-code","owner":{"login":"sachith500","id":1452526,"avatar_url":"https://avatars.githubusercontent.com/u/1452526?v=2","gravatar_id":"","url":"https://api.github.com/users/sachith500","html_url":"https://github.com/sachith500","followers_url":"https://api.github.com/users/sachith500/followers","following_url":"https://api.github.com/users/sachith500/following{/other_user}","gists_url":"https://api.github.com/users/sachith500/gists{/gist_id}","starred_url":"https://api.github.com/users/sachith500/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sachith500/subscriptions","organizations_url":"https://api.github.com/users/sachith500/orgs","repos_url":"https://api.github.com/users/sachith500/repos","events_url":"https://api.github.com/users/sachith500/events{/privacy}","received_events_url":"https://api.github.com/users/sachith500/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sachith500/stk-code","description":"The code base of supertuxkart","fork":true,"url":"https://api.github.com/repos/sachith500/stk-code","forks_url":"https://api.github.com/repos/sachith500/stk-code/forks","keys_url":"https://api.github.com/repos/sachith500/stk-code/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sachith500/stk-code/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sachith500/stk-code/teams","hooks_url":"https://api.github.com/repos/sachith500/stk-code/hooks","issue_events_url":"https://api.github.com/repos/sachith500/stk-code/issues/events{/number}","events_url":"https://api.github.com/repos/sachith500/stk-code/events","assignees_url":"https://api.github.com/repos/sachith500/stk-code/assignees{/user}","branches_url":"https://api.github.com/repos/sachith500/stk-code/branches{/branch}","tags_url":"https://api.github.com/repos/sachith500/stk-code/tags","blobs_url":"https://api.github.com/repos/sachith500/stk-code/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sachith500/stk-code/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sachith500/stk-code/git/refs{/sha}","trees_url":"https://api.github.com/repos/sachith500/stk-code/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sachith500/stk-code/statuses/{sha}","languages_url":"https://api.github.com/repos/sachith500/stk-code/languages","stargazers_url":"https://api.github.com/repos/sachith500/stk-code/stargazers","contributors_url":"https://api.github.com/repos/sachith500/stk-code/contributors","subscribers_url":"https://api.github.com/repos/sachith500/stk-code/subscribers","subscription_url":"https://api.github.com/repos/sachith500/stk-code/subscription","commits_url":"https://api.github.com/repos/sachith500/stk-code/commits{/sha}","git_commits_url":"https://api.github.com/repos/sachith500/stk-code/git/commits{/sha}","comments_url":"https://api.github.com/repos/sachith500/stk-code/comments{/number}","issue_comment_url":"https://api.github.com/repos/sachith500/stk-code/issues/comments/{number}","contents_url":"https://api.github.com/repos/sachith500/stk-code/contents/{+path}","compare_url":"https://api.github.com/repos/sachith500/stk-code/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sachith500/stk-code/merges","archive_url":"https://api.github.com/repos/sachith500/stk-code/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sachith500/stk-code/downloads","issues_url":"https://api.github.com/repos/sachith500/stk-code/issues{/number}","pulls_url":"https://api.github.com/repos/sachith500/stk-code/pulls{/number}","milestones_url":"https://api.github.com/repos/sachith500/stk-code/milestones{/number}","notifications_url":"https://api.github.com/repos/sachith500/stk-code/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sachith500/stk-code/labels{/name}","releases_url":"https://api.github.com/repos/sachith500/stk-code/releases{/id}","created_at":"2014-01-28T09:31:03Z","updated_at":"2014-06-25T15:13:02Z","pushed_at":"2014-10-31T10:54:51Z","git_url":"git://github.com/sachith500/stk-code.git","ssh_url":"git@github.com:sachith500/stk-code.git","clone_url":"https://github.com/sachith500/stk-code.git","svn_url":"https://github.com/sachith500/stk-code","homepage":null,"size":148185,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"ScriptEngine"}},"base":{"label":"supertuxkart:master","ref":"master","sha":"086705ab3e55eb99c15e41d3896d066e178b39ab","user":{"login":"supertuxkart","id":6138677,"avatar_url":"https://avatars.githubusercontent.com/u/6138677?v=2","gravatar_id":"","url":"https://api.github.com/users/supertuxkart","html_url":"https://github.com/supertuxkart","followers_url":"https://api.github.com/users/supertuxkart/followers","following_url":"https://api.github.com/users/supertuxkart/following{/other_user}","gists_url":"https://api.github.com/users/supertuxkart/gists{/gist_id}","starred_url":"https://api.github.com/users/supertuxkart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/supertuxkart/subscriptions","organizations_url":"https://api.github.com/users/supertuxkart/orgs","repos_url":"https://api.github.com/users/supertuxkart/repos","events_url":"https://api.github.com/users/supertuxkart/events{/privacy}","received_events_url":"https://api.github.com/users/supertuxkart/received_events","type":"Organization","site_admin":false},"repo":{"id":15920273,"name":"stk-code","full_name":"supertuxkart/stk-code","owner":{"login":"supertuxkart","id":6138677,"avatar_url":"https://avatars.githubusercontent.com/u/6138677?v=2","gravatar_id":"","url":"https://api.github.com/users/supertuxkart","html_url":"https://github.com/supertuxkart","followers_url":"https://api.github.com/users/supertuxkart/followers","following_url":"https://api.github.com/users/supertuxkart/following{/other_user}","gists_url":"https://api.github.com/users/supertuxkart/gists{/gist_id}","starred_url":"https://api.github.com/users/supertuxkart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/supertuxkart/subscriptions","organizations_url":"https://api.github.com/users/supertuxkart/orgs","repos_url":"https://api.github.com/users/supertuxkart/repos","events_url":"https://api.github.com/users/supertuxkart/events{/privacy}","received_events_url":"https://api.github.com/users/supertuxkart/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/supertuxkart/stk-code","description":"The code base of supertuxkart","fork":false,"url":"https://api.github.com/repos/supertuxkart/stk-code","forks_url":"https://api.github.com/repos/supertuxkart/stk-code/forks","keys_url":"https://api.github.com/repos/supertuxkart/stk-code/keys{/key_id}","collaborators_url":"https://api.github.com/repos/supertuxkart/stk-code/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/supertuxkart/stk-code/teams","hooks_url":"https://api.github.com/repos/supertuxkart/stk-code/hooks","issue_events_url":"https://api.github.com/repos/supertuxkart/stk-code/issues/events{/number}","events_url":"https://api.github.com/repos/supertuxkart/stk-code/events","assignees_url":"https://api.github.com/repos/supertuxkart/stk-code/assignees{/user}","branches_url":"https://api.github.com/repos/supertuxkart/stk-code/branches{/branch}","tags_url":"https://api.github.com/repos/supertuxkart/stk-code/tags","blobs_url":"https://api.github.com/repos/supertuxkart/stk-code/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/supertuxkart/stk-code/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/supertuxkart/stk-code/git/refs{/sha}","trees_url":"https://api.github.com/repos/supertuxkart/stk-code/git/trees{/sha}","statuses_url":"https://api.github.com/repos/supertuxkart/stk-code/statuses/{sha}","languages_url":"https://api.github.com/repos/supertuxkart/stk-code/languages","stargazers_url":"https://api.github.com/repos/supertuxkart/stk-code/stargazers","contributors_url":"https://api.github.com/repos/supertuxkart/stk-code/contributors","subscribers_url":"https://api.github.com/repos/supertuxkart/stk-code/subscribers","subscription_url":"https://api.github.com/repos/supertuxkart/stk-code/subscription","commits_url":"https://api.github.com/repos/supertuxkart/stk-code/commits{/sha}","git_commits_url":"https://api.github.com/repos/supertuxkart/stk-code/git/commits{/sha}","comments_url":"https://api.github.com/repos/supertuxkart/stk-code/comments{/number}","issue_comment_url":"https://api.github.com/repos/supertuxkart/stk-code/issues/comments/{number}","contents_url":"https://api.github.com/repos/supertuxkart/stk-code/contents/{+path}","compare_url":"https://api.github.com/repos/supertuxkart/stk-code/compare/{base}...{head}","merges_url":"https://api.github.com/repos/supertuxkart/stk-code/merges","archive_url":"https://api.github.com/repos/supertuxkart/stk-code/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/supertuxkart/stk-code/downloads","issues_url":"https://api.github.com/repos/supertuxkart/stk-code/issues{/number}","pulls_url":"https://api.github.com/repos/supertuxkart/stk-code/pulls{/number}","milestones_url":"https://api.github.com/repos/supertuxkart/stk-code/milestones{/number}","notifications_url":"https://api.github.com/repos/supertuxkart/stk-code/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/supertuxkart/stk-code/labels{/name}","releases_url":"https://api.github.com/repos/supertuxkart/stk-code/releases{/id}","created_at":"2014-01-15T00:28:54Z","updated_at":"2014-10-20T18:32:45Z","pushed_at":"2014-11-01T01:27:35Z","git_url":"git://github.com/supertuxkart/stk-code.git","ssh_url":"git@github.com:supertuxkart/stk-code.git","clone_url":"https://github.com/supertuxkart/stk-code.git","svn_url":"https://github.com/supertuxkart/stk-code","homepage":null,"size":171649,"stargazers_count":82,"watchers_count":82,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":76,"mirror_url":null,"open_issues_count":246,"forks":76,"open_issues":246,"watchers":82,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/supertuxkart/stk-code/pulls/1649"},"html":{"href":"https://github.com/supertuxkart/stk-code/pull/1649"},"issue":{"href":"https://api.github.com/repos/supertuxkart/stk-code/issues/1649"},"comments":{"href":"https://api.github.com/repos/supertuxkart/stk-code/issues/1649/comments"},"review_comments":{"href":"https://api.github.com/repos/supertuxkart/stk-code/pulls/1649/comments"},"review_comment":{"href":"https://api.github.com/repos/supertuxkart/stk-code/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/supertuxkart/stk-code/pulls/1649/commits"},"statuses":{"href":"https://api.github.com/repos/supertuxkart/stk-code/statuses/ebb914d0ef2e74058883eab254205d00781a67b8"}}}}