GitHub PullRequestReviewCommentEvent at 2014-02-10 21:56:43
Repository: maktaba
Actor: Soares
Payload: {"comment":{"url":"https://api.github.com/repos/google/maktaba/pulls/comments/9603910","id":9603910,"diff_hunk":"@@ -526,12 +521,13 @@ function! s:CreatePluginObject(name, location, settings) abort\n   \" Then load all instant files in random order.\n   call call('s:SourceDir', ['instant'], l:plugin)\n \n+  let l:sanitized_plugin_name = s:SanitizedName(l:plugin.name)\n   \" g:installed_<plugin> is set to signal that the plugin has been installed\n   \" (though perhaps not loaded). This fills the gap between installation time\n   \" (when the plugin is available on the runtimepath) and load time (when the\n   \" plugin's files are sourced). This new convention is expected to make it much\n   \" easier to build vim dependency managers.\n-  let g:installed_{l:plugin.name} = 1\n+  let g:installed_{l:sanitized_plugin_name} = 1","path":"autoload/maktaba/plugin.vim","position":90,"original_position":90,"commit_id":"175ec91ecb202306f0c8902187feb3f5621e30d6","original_commit_id":"175ec91ecb202306f0c8902187feb3f5621e30d6","user":{"login":"Soares","id":72340,"avatar_url":"https://gravatar.com/avatar/41b56228b2143ab0929e01c258399f99?d=https%3A%2F%2Fidenticons.github.com%2Ff95defe1c77eab830270c1d82f7cac5a.png&r=x","gravatar_id":"41b56228b2143ab0929e01c258399f99","url":"https://api.github.com/users/Soares","html_url":"https://github.com/Soares","followers_url":"https://api.github.com/users/Soares/followers","following_url":"https://api.github.com/users/Soares/following{/other_user}","gists_url":"https://api.github.com/users/Soares/gists{/gist_id}","starred_url":"https://api.github.com/users/Soares/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Soares/subscriptions","organizations_url":"https://api.github.com/users/Soares/orgs","repos_url":"https://api.github.com/users/Soares/repos","events_url":"https://api.github.com/users/Soares/events{/privacy}","received_events_url":"https://api.github.com/users/Soares/received_events","type":"User","site_admin":false},"body":"May as well just do\r\n\r\nlet g:installed_{s:SanitizedName(l:plugin.name)} = 1\r\n\r\nand save yourself a local variable.","created_at":"2014-02-10T21:56:43Z","updated_at":"2014-02-10T21:56:43Z","html_url":"https://github.com/google/maktaba/pull/57#discussion_r9603910","pull_request_url":"https://api.github.com/repos/google/maktaba/pulls/57","_links":{"self":{"href":"https://api.github.com/repos/google/maktaba/pulls/comments/9603910"},"html":{"href":"https://github.com/google/maktaba/pull/57#discussion_r9603910"},"pull_request":{"href":"https://api.github.com/repos/google/maktaba/pulls/57"}}}}