GitHub PullRequestReviewCommentEvent at 2014-09-10 21:40:34
Repository: SpongeAPI
Actor: spaceemotion
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/SpongePowered/SpongeAPI/pulls/comments/17391077","id":17391077,"diff_hunk":"@@ -23,7 +23,12 @@\n  */\n package org.spongepowered.api.item;\n \n-public interface Item {\n+import org.spongepowered.api.entity.Entity;\n+\n+/**\n+ * Represents an Item\n+ */\n+public interface Item extends Entity {","path":"src/main/java/org/spongepowered/api/item/Item.java","position":10,"original_position":10,"commit_id":"89273f1d0021e8eed3f0c74688a41d4253cff00d","original_commit_id":"89273f1d0021e8eed3f0c74688a41d4253cff00d","user":{"login":"spaceemotion","id":429147,"avatar_url":"https://avatars.githubusercontent.com/u/429147?v=2","gravatar_id":"2cb33c0d80c5cbd1b426c30be3b40d30","url":"https://api.github.com/users/spaceemotion","html_url":"https://github.com/spaceemotion","followers_url":"https://api.github.com/users/spaceemotion/followers","following_url":"https://api.github.com/users/spaceemotion/following{/other_user}","gists_url":"https://api.github.com/users/spaceemotion/gists{/gist_id}","starred_url":"https://api.github.com/users/spaceemotion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spaceemotion/subscriptions","organizations_url":"https://api.github.com/users/spaceemotion/orgs","repos_url":"https://api.github.com/users/spaceemotion/repos","events_url":"https://api.github.com/users/spaceemotion/events{/privacy}","received_events_url":"https://api.github.com/users/spaceemotion/received_events","type":"User","site_admin":false},"body":"Uhh, yeah. Just noticed that as well - this is why we need proper documentation even for the class itself ;)","created_at":"2014-09-10T21:40:34Z","updated_at":"2014-09-10T21:40:34Z","html_url":"https://github.com/SpongePowered/SpongeAPI/pull/72#discussion_r17391077","pull_request_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/pulls/72","_links":{"self":{"href":"https://api.github.com/repos/SpongePowered/SpongeAPI/pulls/comments/17391077"},"html":{"href":"https://github.com/SpongePowered/SpongeAPI/pull/72#discussion_r17391077"},"pull_request":{"href":"https://api.github.com/repos/SpongePowered/SpongeAPI/pulls/72"}}},"pull_request":{"url":"https://api.github.com/repos/SpongePowered/SpongeAPI/pulls/72","id":21016919,"html_url":"https://github.com/SpongePowered/SpongeAPI/pull/72","diff_url":"https://github.com/SpongePowered/SpongeAPI/pull/72.diff","patch_url":"https://github.com/SpongePowered/SpongeAPI/pull/72.patch","issue_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/issues/72","number":72,"state":"open","locked":false,"title":"Add OfflinePlayer, Update Player, Entity, Item","user":{"login":"jacklin213","id":1115240,"avatar_url":"https://avatars.githubusercontent.com/u/1115240?v=2","gravatar_id":"676d4f6a2660dea773dfb6bf1ae2872b","url":"https://api.github.com/users/jacklin213","html_url":"https://github.com/jacklin213","followers_url":"https://api.github.com/users/jacklin213/followers","following_url":"https://api.github.com/users/jacklin213/following{/other_user}","gists_url":"https://api.github.com/users/jacklin213/gists{/gist_id}","starred_url":"https://api.github.com/users/jacklin213/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacklin213/subscriptions","organizations_url":"https://api.github.com/users/jacklin213/orgs","repos_url":"https://api.github.com/users/jacklin213/repos","events_url":"https://api.github.com/users/jacklin213/events{/privacy}","received_events_url":"https://api.github.com/users/jacklin213/received_events","type":"User","site_admin":false},"body":"* Updated JavaDocs for classes as well.\r\n* Entity:\r\n * Added methods getPosition(), getWorld(), teleport(vector3i, world), teleport(x, y, z, world)\r\n* OfflinePlayer:\r\n * Created class\r\n * Added methods getName(), getUniqueID(), hasJoinedBefore(), isBanned(). isWhitelisted()\r\n* Player:\r\n * Added methods hasJoinedBefore(), isBanned(), isWhitelisted()\r\n* Item:\r\n * Extends Entity interface","created_at":"2014-09-10T12:24:48Z","updated_at":"2014-09-10T21:40:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8a7c9694f4c09a9e41949c3fa941819b34213889","assignee":{"login":"kitskub","id":475078,"avatar_url":"https://avatars.githubusercontent.com/u/475078?v=2","gravatar_id":"b0431d1c4ed91d098fb547eb31af75fe","url":"https://api.github.com/users/kitskub","html_url":"https://github.com/kitskub","followers_url":"https://api.github.com/users/kitskub/followers","following_url":"https://api.github.com/users/kitskub/following{/other_user}","gists_url":"https://api.github.com/users/kitskub/gists{/gist_id}","starred_url":"https://api.github.com/users/kitskub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kitskub/subscriptions","organizations_url":"https://api.github.com/users/kitskub/orgs","repos_url":"https://api.github.com/users/kitskub/repos","events_url":"https://api.github.com/users/kitskub/events{/privacy}","received_events_url":"https://api.github.com/users/kitskub/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/pulls/72/commits","review_comments_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/pulls/72/comments","review_comment_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/pulls/comments/{number}","comments_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/issues/72/comments","statuses_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/statuses/89273f1d0021e8eed3f0c74688a41d4253cff00d","head":{"label":"jacklin213:main","ref":"main","sha":"89273f1d0021e8eed3f0c74688a41d4253cff00d","user":{"login":"jacklin213","id":1115240,"avatar_url":"https://avatars.githubusercontent.com/u/1115240?v=2","gravatar_id":"676d4f6a2660dea773dfb6bf1ae2872b","url":"https://api.github.com/users/jacklin213","html_url":"https://github.com/jacklin213","followers_url":"https://api.github.com/users/jacklin213/followers","following_url":"https://api.github.com/users/jacklin213/following{/other_user}","gists_url":"https://api.github.com/users/jacklin213/gists{/gist_id}","starred_url":"https://api.github.com/users/jacklin213/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacklin213/subscriptions","organizations_url":"https://api.github.com/users/jacklin213/orgs","repos_url":"https://api.github.com/users/jacklin213/repos","events_url":"https://api.github.com/users/jacklin213/events{/privacy}","received_events_url":"https://api.github.com/users/jacklin213/received_events","type":"User","site_admin":false},"repo":{"id":23854983,"name":"SpongeAPI","full_name":"jacklin213/SpongeAPI","owner":{"login":"jacklin213","id":1115240,"avatar_url":"https://avatars.githubusercontent.com/u/1115240?v=2","gravatar_id":"676d4f6a2660dea773dfb6bf1ae2872b","url":"https://api.github.com/users/jacklin213","html_url":"https://github.com/jacklin213","followers_url":"https://api.github.com/users/jacklin213/followers","following_url":"https://api.github.com/users/jacklin213/following{/other_user}","gists_url":"https://api.github.com/users/jacklin213/gists{/gist_id}","starred_url":"https://api.github.com/users/jacklin213/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacklin213/subscriptions","organizations_url":"https://api.github.com/users/jacklin213/orgs","repos_url":"https://api.github.com/users/jacklin213/repos","events_url":"https://api.github.com/users/jacklin213/events{/privacy}","received_events_url":"https://api.github.com/users/jacklin213/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jacklin213/SpongeAPI","description":"A Minecraft plugin API (not including an implementation)","fork":true,"url":"https://api.github.com/repos/jacklin213/SpongeAPI","forks_url":"https://api.github.com/repos/jacklin213/SpongeAPI/forks","keys_url":"https://api.github.com/repos/jacklin213/SpongeAPI/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jacklin213/SpongeAPI/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jacklin213/SpongeAPI/teams","hooks_url":"https://api.github.com/repos/jacklin213/SpongeAPI/hooks","issue_events_url":"https://api.github.com/repos/jacklin213/SpongeAPI/issues/events{/number}","events_url":"https://api.github.com/repos/jacklin213/SpongeAPI/events","assignees_url":"https://api.github.com/repos/jacklin213/SpongeAPI/assignees{/user}","branches_url":"https://api.github.com/repos/jacklin213/SpongeAPI/branches{/branch}","tags_url":"https://api.github.com/repos/jacklin213/SpongeAPI/tags","blobs_url":"https://api.github.com/repos/jacklin213/SpongeAPI/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jacklin213/SpongeAPI/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jacklin213/SpongeAPI/git/refs{/sha}","trees_url":"https://api.github.com/repos/jacklin213/SpongeAPI/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jacklin213/SpongeAPI/statuses/{sha}","languages_url":"https://api.github.com/repos/jacklin213/SpongeAPI/languages","stargazers_url":"https://api.github.com/repos/jacklin213/SpongeAPI/stargazers","contributors_url":"https://api.github.com/repos/jacklin213/SpongeAPI/contributors","subscribers_url":"https://api.github.com/repos/jacklin213/SpongeAPI/subscribers","subscription_url":"https://api.github.com/repos/jacklin213/SpongeAPI/subscription","commits_url":"https://api.github.com/repos/jacklin213/SpongeAPI/commits{/sha}","git_commits_url":"https://api.github.com/repos/jacklin213/SpongeAPI/git/commits{/sha}","comments_url":"https://api.github.com/repos/jacklin213/SpongeAPI/comments{/number}","issue_comment_url":"https://api.github.com/repos/jacklin213/SpongeAPI/issues/comments/{number}","contents_url":"https://api.github.com/repos/jacklin213/SpongeAPI/contents/{+path}","compare_url":"https://api.github.com/repos/jacklin213/SpongeAPI/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jacklin213/SpongeAPI/merges","archive_url":"https://api.github.com/repos/jacklin213/SpongeAPI/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jacklin213/SpongeAPI/downloads","issues_url":"https://api.github.com/repos/jacklin213/SpongeAPI/issues{/number}","pulls_url":"https://api.github.com/repos/jacklin213/SpongeAPI/pulls{/number}","milestones_url":"https://api.github.com/repos/jacklin213/SpongeAPI/milestones{/number}","notifications_url":"https://api.github.com/repos/jacklin213/SpongeAPI/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jacklin213/SpongeAPI/labels{/name}","releases_url":"https://api.github.com/repos/jacklin213/SpongeAPI/releases{/id}","created_at":"2014-09-10T00:27:26Z","updated_at":"2014-09-10T01:45:01Z","pushed_at":"2014-09-10T21:37:39Z","git_url":"git://github.com/jacklin213/SpongeAPI.git","ssh_url":"git@github.com:jacklin213/SpongeAPI.git","clone_url":"https://github.com/jacklin213/SpongeAPI.git","svn_url":"https://github.com/jacklin213/SpongeAPI","homepage":"http://www.spongepowered.org/","size":372,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SpongePowered:master","ref":"master","sha":"40c07782e68d246d2b7bf2926cdaf88421042fb7","user":{"login":"SpongePowered","id":8683473,"avatar_url":"https://avatars.githubusercontent.com/u/8683473?v=2","gravatar_id":null,"url":"https://api.github.com/users/SpongePowered","html_url":"https://github.com/SpongePowered","followers_url":"https://api.github.com/users/SpongePowered/followers","following_url":"https://api.github.com/users/SpongePowered/following{/other_user}","gists_url":"https://api.github.com/users/SpongePowered/gists{/gist_id}","starred_url":"https://api.github.com/users/SpongePowered/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpongePowered/subscriptions","organizations_url":"https://api.github.com/users/SpongePowered/orgs","repos_url":"https://api.github.com/users/SpongePowered/repos","events_url":"https://api.github.com/users/SpongePowered/events{/privacy}","received_events_url":"https://api.github.com/users/SpongePowered/received_events","type":"Organization","site_admin":false},"repo":{"id":23770421,"name":"SpongeAPI","full_name":"SpongePowered/SpongeAPI","owner":{"login":"SpongePowered","id":8683473,"avatar_url":"https://avatars.githubusercontent.com/u/8683473?v=2","gravatar_id":null,"url":"https://api.github.com/users/SpongePowered","html_url":"https://github.com/SpongePowered","followers_url":"https://api.github.com/users/SpongePowered/followers","following_url":"https://api.github.com/users/SpongePowered/following{/other_user}","gists_url":"https://api.github.com/users/SpongePowered/gists{/gist_id}","starred_url":"https://api.github.com/users/SpongePowered/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpongePowered/subscriptions","organizations_url":"https://api.github.com/users/SpongePowered/orgs","repos_url":"https://api.github.com/users/SpongePowered/repos","events_url":"https://api.github.com/users/SpongePowered/events{/privacy}","received_events_url":"https://api.github.com/users/SpongePowered/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SpongePowered/SpongeAPI","description":"A Minecraft plugin API (not including an implementation)","fork":false,"url":"https://api.github.com/repos/SpongePowered/SpongeAPI","forks_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/forks","keys_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/teams","hooks_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/hooks","issue_events_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/issues/events{/number}","events_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/events","assignees_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/assignees{/user}","branches_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/branches{/branch}","tags_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/tags","blobs_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/git/refs{/sha}","trees_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/statuses/{sha}","languages_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/languages","stargazers_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/stargazers","contributors_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/contributors","subscribers_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/subscribers","subscription_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/subscription","commits_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/commits{/sha}","git_commits_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/git/commits{/sha}","comments_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/comments{/number}","issue_comment_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/issues/comments/{number}","contents_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/contents/{+path}","compare_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/merges","archive_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/downloads","issues_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/issues{/number}","pulls_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/pulls{/number}","milestones_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/milestones{/number}","notifications_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/labels{/name}","releases_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/releases{/id}","created_at":"2014-09-07T20:39:25Z","updated_at":"2014-09-10T21:37:24Z","pushed_at":"2014-09-10T18:19:12Z","git_url":"git://github.com/SpongePowered/SpongeAPI.git","ssh_url":"git@github.com:SpongePowered/SpongeAPI.git","clone_url":"https://github.com/SpongePowered/SpongeAPI.git","svn_url":"https://github.com/SpongePowered/SpongeAPI","homepage":"http://www.spongepowered.org/","size":2142,"stargazers_count":355,"watchers_count":355,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":100,"mirror_url":null,"open_issues_count":32,"forks":100,"open_issues":32,"watchers":355,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SpongePowered/SpongeAPI/pulls/72"},"html":{"href":"https://github.com/SpongePowered/SpongeAPI/pull/72"},"issue":{"href":"https://api.github.com/repos/SpongePowered/SpongeAPI/issues/72"},"comments":{"href":"https://api.github.com/repos/SpongePowered/SpongeAPI/issues/72/comments"},"review_comments":{"href":"https://api.github.com/repos/SpongePowered/SpongeAPI/pulls/72/comments"},"review_comment":{"href":"https://api.github.com/repos/SpongePowered/SpongeAPI/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/SpongePowered/SpongeAPI/pulls/72/commits"},"statuses":{"href":"https://api.github.com/repos/SpongePowered/SpongeAPI/statuses/89273f1d0021e8eed3f0c74688a41d4253cff00d"}}}}