GitHub PushEvent at 2014-11-13 22:20:53
Repository: nova
Actor: openstack-gerrit
Payload: {"shas":[["9c3ec16576e2f7c9d5aff6e4b620d708e6636568","a92fa785717b38508f759cbceb08a0feb47a6e51@emc.com","Clean up iSCSI multipath devices in Post Live Migration\n\nWhen a volume is attached to a VM in the source compute node through\nmultipath, the related files in /dev/disk/by-path/ are like this\n\nstack@ubuntu-server12:~/devstack$ ls /dev/disk/by-path/*24\n/dev/disk/by-path/ip-192.168.3.50:3260-iscsi-iqn.1992-04.com.emc:cx.\nfnm00124500890.a5-lun-24\n/dev/disk/by-path/ip-192.168.4.51:3260-iscsi-iqn.1992-04.com.emc:cx.\nfnm00124500890.b4-lun-24\n\nThe information on its corresponding multipath device is like this\nstack@ubuntu-server12:~/devstack$ sudo multipath -l 3600601602ba034\n00921130967724e411\n3600601602ba03400921130967724e411 dm-3 DGC,VRAID\nsize=1.0G features='1 queue_if_no_path' hwhandler='1 alua' wp=rw\n|-+- policy='round-robin 0' prio=-1 status=active\n| `- 19:0:0:24 sdl 8:176 active undef running\n`-+- policy='round-robin 0' prio=-1 status=enabled\n  `- 18:0:0:24 sdj 8:144 active undef running\n\nBut when the VM is migrated to the destination, the related information is\nlike the following example since we CANNOT guarantee that all nodes are able\nto access the same iSCSI portals and the same target LUN number. And the\ninformation is used to overwrite connection_info in the DB before the post\nlive migration logic is executed.\n\nstack@ubuntu-server13:~/devstack$ ls /dev/disk/by-path/*24\n/dev/disk/by-path/ip-192.168.3.51:3260-iscsi-iqn.1992-04.com.emc:cx.\nfnm00124500890.b5-lun-100\n/dev/disk/by-path/ip-192.168.4.51:3260-iscsi-iqn.1992-04.com.emc:cx.\nfnm00124500890.b4-lun-100\n\nstack@ubuntu-server13:~/devstack$ sudo multipath -l 3600601602ba034\n00921130967724e411\n3600601602ba03400921130967724e411 dm-3 DGC,VRAID\nsize=1.0G features='1 queue_if_no_path' hwhandler='1 alua' wp=rw\n|-+- policy='round-robin 0' prio=-1 status=active\n| `- 19:0:0:100 sdf 8:176 active undef running\n`-+- policy='round-robin 0' prio=-1 status=enabled\n  `- 18:0:0:100 sdg 8:144 active undef running\n\nAs a result, if post live migration in source side uses <IP>, <IQN> and\n<TARGET LUN Number> to find the devices to clean up, it may use 192.168.3.51,\niqn.1992-04.com.emc:cx.fnm00124500890.a5 and 100.\nHowever, the correct one should be 192.168.3.50, iqn.1992-04.com.emc:cx.\nfnm00124500890.a5 and 24.\n\nSimilar philosophy in (https://bugs.launchpad.net/nova/+bug/1327497) can be\nused to fix it: Leverage the unchanged multipath_id to find correct devices\nto delete.\n\nChange-Id: I875293c3ade9423caa2b8afe9eca25a74606d262\nCloses-Bug: #1357368\n(cherry picked from commit aa9104ccedb3ff13cc34a498b11f5e8ff100fd99)","Jeegn Chen",true],["b9f31d2fdd128a234bfb1a1a6062446443771ab8","d95b56ce41a2e1ac4cecdd398defd7414407cc08@review.openstack.org","Merge \"Clean up iSCSI multipath devices in Post Live Migration\" into stable/juno","Jenkins",true]],"size":2,"ref":"refs/heads/stable/juno","head":"b9f31d2fdd128a234bfb1a1a6062446443771ab8"}