GitHub PullRequestEvent at 2014-08-20 20:58:26
Repository: vwf
Actor: scottnc27603
Payload: {"action":"opened","number":313,"pull_request":{"url":"https://api.github.com/repos/virtual-world-framework/vwf/pulls/313","id":20073467,"html_url":"https://github.com/virtual-world-framework/vwf/pull/313","diff_url":"https://github.com/virtual-world-framework/vwf/pull/313.diff","patch_url":"https://github.com/virtual-world-framework/vwf/pull/313.patch","issue_url":"https://api.github.com/repos/virtual-world-framework/vwf/issues/313","number":313,"state":"open","locked":false,"title":"Adds a check for the masterVolume being undefined","user":{"login":"scottnc27603","id":1278173,"avatar_url":"https://avatars.githubusercontent.com/u/1278173?v=2","gravatar_id":"71507090c09a57144de4acf9383a9ca6","url":"https://api.github.com/users/scottnc27603","html_url":"https://github.com/scottnc27603","followers_url":"https://api.github.com/users/scottnc27603/followers","following_url":"https://api.github.com/users/scottnc27603/following{/other_user}","gists_url":"https://api.github.com/users/scottnc27603/gists{/gist_id}","starred_url":"https://api.github.com/users/scottnc27603/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scottnc27603/subscriptions","organizations_url":"https://api.github.com/users/scottnc27603/orgs","repos_url":"https://api.github.com/users/scottnc27603/repos","events_url":"https://api.github.com/users/scottnc27603/events{/privacy}","received_events_url":"https://api.github.com/users/scottnc27603/received_events","type":"User","site_admin":false},"body":"@kadst43 \r\n\r\nmasterVolume was undefined, so I added a check, and then added default value.  In initialize masterVolume is set to this.masterVolume which is probably the real source of the problem.  I'm not sure how this.masterVolume would have a value at that point.  Kevin, thoughts?","created_at":"2014-08-20T20:58:26Z","updated_at":"2014-08-20T20:58:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/virtual-world-framework/vwf/pulls/313/commits","review_comments_url":"https://api.github.com/repos/virtual-world-framework/vwf/pulls/313/comments","review_comment_url":"https://api.github.com/repos/virtual-world-framework/vwf/pulls/comments/{number}","comments_url":"https://api.github.com/repos/virtual-world-framework/vwf/issues/313/comments","statuses_url":"https://api.github.com/repos/virtual-world-framework/vwf/statuses/53574c1340bb13adc819fe689982daeadeda2c30","head":{"label":"virtual-world-framework:branch/sound-fix","ref":"branch/sound-fix","sha":"53574c1340bb13adc819fe689982daeadeda2c30","user":{"login":"virtual-world-framework","id":1552130,"avatar_url":"https://avatars.githubusercontent.com/u/1552130?v=2","gravatar_id":"4030558125d47329a00e5378c95d401b","url":"https://api.github.com/users/virtual-world-framework","html_url":"https://github.com/virtual-world-framework","followers_url":"https://api.github.com/users/virtual-world-framework/followers","following_url":"https://api.github.com/users/virtual-world-framework/following{/other_user}","gists_url":"https://api.github.com/users/virtual-world-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/virtual-world-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/virtual-world-framework/subscriptions","organizations_url":"https://api.github.com/users/virtual-world-framework/orgs","repos_url":"https://api.github.com/users/virtual-world-framework/repos","events_url":"https://api.github.com/users/virtual-world-framework/events{/privacy}","received_events_url":"https://api.github.com/users/virtual-world-framework/received_events","type":"Organization","site_admin":false},"repo":{"id":3857149,"name":"vwf","full_name":"virtual-world-framework/vwf","owner":{"login":"virtual-world-framework","id":1552130,"avatar_url":"https://avatars.githubusercontent.com/u/1552130?v=2","gravatar_id":"4030558125d47329a00e5378c95d401b","url":"https://api.github.com/users/virtual-world-framework","html_url":"https://github.com/virtual-world-framework","followers_url":"https://api.github.com/users/virtual-world-framework/followers","following_url":"https://api.github.com/users/virtual-world-framework/following{/other_user}","gists_url":"https://api.github.com/users/virtual-world-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/virtual-world-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/virtual-world-framework/subscriptions","organizations_url":"https://api.github.com/users/virtual-world-framework/orgs","repos_url":"https://api.github.com/users/virtual-world-framework/repos","events_url":"https://api.github.com/users/virtual-world-framework/events{/privacy}","received_events_url":"https://api.github.com/users/virtual-world-framework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/virtual-world-framework/vwf","description":"Virtual World Framework","fork":false,"url":"https://api.github.com/repos/virtual-world-framework/vwf","forks_url":"https://api.github.com/repos/virtual-world-framework/vwf/forks","keys_url":"https://api.github.com/repos/virtual-world-framework/vwf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/virtual-world-framework/vwf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/virtual-world-framework/vwf/teams","hooks_url":"https://api.github.com/repos/virtual-world-framework/vwf/hooks","issue_events_url":"https://api.github.com/repos/virtual-world-framework/vwf/issues/events{/number}","events_url":"https://api.github.com/repos/virtual-world-framework/vwf/events","assignees_url":"https://api.github.com/repos/virtual-world-framework/vwf/assignees{/user}","branches_url":"https://api.github.com/repos/virtual-world-framework/vwf/branches{/branch}","tags_url":"https://api.github.com/repos/virtual-world-framework/vwf/tags","blobs_url":"https://api.github.com/repos/virtual-world-framework/vwf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/virtual-world-framework/vwf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/virtual-world-framework/vwf/git/refs{/sha}","trees_url":"https://api.github.com/repos/virtual-world-framework/vwf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/virtual-world-framework/vwf/statuses/{sha}","languages_url":"https://api.github.com/repos/virtual-world-framework/vwf/languages","stargazers_url":"https://api.github.com/repos/virtual-world-framework/vwf/stargazers","contributors_url":"https://api.github.com/repos/virtual-world-framework/vwf/contributors","subscribers_url":"https://api.github.com/repos/virtual-world-framework/vwf/subscribers","subscription_url":"https://api.github.com/repos/virtual-world-framework/vwf/subscription","commits_url":"https://api.github.com/repos/virtual-world-framework/vwf/commits{/sha}","git_commits_url":"https://api.github.com/repos/virtual-world-framework/vwf/git/commits{/sha}","comments_url":"https://api.github.com/repos/virtual-world-framework/vwf/comments{/number}","issue_comment_url":"https://api.github.com/repos/virtual-world-framework/vwf/issues/comments/{number}","contents_url":"https://api.github.com/repos/virtual-world-framework/vwf/contents/{+path}","compare_url":"https://api.github.com/repos/virtual-world-framework/vwf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/virtual-world-framework/vwf/merges","archive_url":"https://api.github.com/repos/virtual-world-framework/vwf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/virtual-world-framework/vwf/downloads","issues_url":"https://api.github.com/repos/virtual-world-framework/vwf/issues{/number}","pulls_url":"https://api.github.com/repos/virtual-world-framework/vwf/pulls{/number}","milestones_url":"https://api.github.com/repos/virtual-world-framework/vwf/milestones{/number}","notifications_url":"https://api.github.com/repos/virtual-world-framework/vwf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/virtual-world-framework/vwf/labels{/name}","releases_url":"https://api.github.com/repos/virtual-world-framework/vwf/releases{/id}","created_at":"2012-03-28T16:40:09Z","updated_at":"2014-08-07T10:30:17Z","pushed_at":"2014-08-20T20:53:56Z","git_url":"git://github.com/virtual-world-framework/vwf.git","ssh_url":"git@github.com:virtual-world-framework/vwf.git","clone_url":"https://github.com/virtual-world-framework/vwf.git","svn_url":"https://github.com/virtual-world-framework/vwf","homepage":"http://virtual.wf","size":767260,"stargazers_count":74,"watchers_count":74,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":42,"mirror_url":null,"open_issues_count":20,"forks":42,"open_issues":20,"watchers":74,"default_branch":"master"}},"base":{"label":"virtual-world-framework:mars-game-staging","ref":"mars-game-staging","sha":"30ebff2934166186bc272da410a516f2f0bb4c04","user":{"login":"virtual-world-framework","id":1552130,"avatar_url":"https://avatars.githubusercontent.com/u/1552130?v=2","gravatar_id":"4030558125d47329a00e5378c95d401b","url":"https://api.github.com/users/virtual-world-framework","html_url":"https://github.com/virtual-world-framework","followers_url":"https://api.github.com/users/virtual-world-framework/followers","following_url":"https://api.github.com/users/virtual-world-framework/following{/other_user}","gists_url":"https://api.github.com/users/virtual-world-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/virtual-world-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/virtual-world-framework/subscriptions","organizations_url":"https://api.github.com/users/virtual-world-framework/orgs","repos_url":"https://api.github.com/users/virtual-world-framework/repos","events_url":"https://api.github.com/users/virtual-world-framework/events{/privacy}","received_events_url":"https://api.github.com/users/virtual-world-framework/received_events","type":"Organization","site_admin":false},"repo":{"id":3857149,"name":"vwf","full_name":"virtual-world-framework/vwf","owner":{"login":"virtual-world-framework","id":1552130,"avatar_url":"https://avatars.githubusercontent.com/u/1552130?v=2","gravatar_id":"4030558125d47329a00e5378c95d401b","url":"https://api.github.com/users/virtual-world-framework","html_url":"https://github.com/virtual-world-framework","followers_url":"https://api.github.com/users/virtual-world-framework/followers","following_url":"https://api.github.com/users/virtual-world-framework/following{/other_user}","gists_url":"https://api.github.com/users/virtual-world-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/virtual-world-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/virtual-world-framework/subscriptions","organizations_url":"https://api.github.com/users/virtual-world-framework/orgs","repos_url":"https://api.github.com/users/virtual-world-framework/repos","events_url":"https://api.github.com/users/virtual-world-framework/events{/privacy}","received_events_url":"https://api.github.com/users/virtual-world-framework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/virtual-world-framework/vwf","description":"Virtual World Framework","fork":false,"url":"https://api.github.com/repos/virtual-world-framework/vwf","forks_url":"https://api.github.com/repos/virtual-world-framework/vwf/forks","keys_url":"https://api.github.com/repos/virtual-world-framework/vwf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/virtual-world-framework/vwf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/virtual-world-framework/vwf/teams","hooks_url":"https://api.github.com/repos/virtual-world-framework/vwf/hooks","issue_events_url":"https://api.github.com/repos/virtual-world-framework/vwf/issues/events{/number}","events_url":"https://api.github.com/repos/virtual-world-framework/vwf/events","assignees_url":"https://api.github.com/repos/virtual-world-framework/vwf/assignees{/user}","branches_url":"https://api.github.com/repos/virtual-world-framework/vwf/branches{/branch}","tags_url":"https://api.github.com/repos/virtual-world-framework/vwf/tags","blobs_url":"https://api.github.com/repos/virtual-world-framework/vwf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/virtual-world-framework/vwf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/virtual-world-framework/vwf/git/refs{/sha}","trees_url":"https://api.github.com/repos/virtual-world-framework/vwf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/virtual-world-framework/vwf/statuses/{sha}","languages_url":"https://api.github.com/repos/virtual-world-framework/vwf/languages","stargazers_url":"https://api.github.com/repos/virtual-world-framework/vwf/stargazers","contributors_url":"https://api.github.com/repos/virtual-world-framework/vwf/contributors","subscribers_url":"https://api.github.com/repos/virtual-world-framework/vwf/subscribers","subscription_url":"https://api.github.com/repos/virtual-world-framework/vwf/subscription","commits_url":"https://api.github.com/repos/virtual-world-framework/vwf/commits{/sha}","git_commits_url":"https://api.github.com/repos/virtual-world-framework/vwf/git/commits{/sha}","comments_url":"https://api.github.com/repos/virtual-world-framework/vwf/comments{/number}","issue_comment_url":"https://api.github.com/repos/virtual-world-framework/vwf/issues/comments/{number}","contents_url":"https://api.github.com/repos/virtual-world-framework/vwf/contents/{+path}","compare_url":"https://api.github.com/repos/virtual-world-framework/vwf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/virtual-world-framework/vwf/merges","archive_url":"https://api.github.com/repos/virtual-world-framework/vwf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/virtual-world-framework/vwf/downloads","issues_url":"https://api.github.com/repos/virtual-world-framework/vwf/issues{/number}","pulls_url":"https://api.github.com/repos/virtual-world-framework/vwf/pulls{/number}","milestones_url":"https://api.github.com/repos/virtual-world-framework/vwf/milestones{/number}","notifications_url":"https://api.github.com/repos/virtual-world-framework/vwf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/virtual-world-framework/vwf/labels{/name}","releases_url":"https://api.github.com/repos/virtual-world-framework/vwf/releases{/id}","created_at":"2012-03-28T16:40:09Z","updated_at":"2014-08-07T10:30:17Z","pushed_at":"2014-08-20T20:53:56Z","git_url":"git://github.com/virtual-world-framework/vwf.git","ssh_url":"git@github.com:virtual-world-framework/vwf.git","clone_url":"https://github.com/virtual-world-framework/vwf.git","svn_url":"https://github.com/virtual-world-framework/vwf","homepage":"http://virtual.wf","size":767260,"stargazers_count":74,"watchers_count":74,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":42,"mirror_url":null,"open_issues_count":20,"forks":42,"open_issues":20,"watchers":74,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/virtual-world-framework/vwf/pulls/313"},"html":{"href":"https://github.com/virtual-world-framework/vwf/pull/313"},"issue":{"href":"https://api.github.com/repos/virtual-world-framework/vwf/issues/313"},"comments":{"href":"https://api.github.com/repos/virtual-world-framework/vwf/issues/313/comments"},"review_comments":{"href":"https://api.github.com/repos/virtual-world-framework/vwf/pulls/313/comments"},"review_comment":{"href":"https://api.github.com/repos/virtual-world-framework/vwf/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/virtual-world-framework/vwf/pulls/313/commits"},"statuses":{"href":"https://api.github.com/repos/virtual-world-framework/vwf/statuses/53574c1340bb13adc819fe689982daeadeda2c30"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}