GitHub PullRequestEvent at 2014-04-04 13:10:55
Repository: fsharp
Actor: fsgit
Payload: {"action":"closed","number":274,"pull_request":{"url":"https://api.github.com/repos/fsharp/fsharp/pulls/274","id":12826690,"html_url":"https://github.com/fsharp/fsharp/pull/274","diff_url":"https://github.com/fsharp/fsharp/pull/274.diff","patch_url":"https://github.com/fsharp/fsharp/pull/274.patch","issue_url":"https://api.github.com/repos/fsharp/fsharp/issues/274","number":274,"state":"closed","title":"Proposal: add --version to fsc/fsc  to show version info","user":{"login":"enricosada","id":147243,"avatar_url":"https://avatars.githubusercontent.com/u/147243?","gravatar_id":"a5e44667dbe576b57503caf63d64e500","url":"https://api.github.com/users/enricosada","html_url":"https://github.com/enricosada","followers_url":"https://api.github.com/users/enricosada/followers","following_url":"https://api.github.com/users/enricosada/following{/other_user}","gists_url":"https://api.github.com/users/enricosada/gists{/gist_id}","starred_url":"https://api.github.com/users/enricosada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enricosada/subscriptions","organizations_url":"https://api.github.com/users/enricosada/orgs","repos_url":"https://api.github.com/users/enricosada/repos","events_url":"https://api.github.com/users/enricosada/events{/privacy}","received_events_url":"https://api.github.com/users/enricosada/received_events","type":"User","site_admin":false},"body":"replace the already deprecated --version parameter\r\n\r\n:warning: Work, but dont merge, read below\r\n\r\nthis add a --version to fsc/fsi, like:\r\n```\r\nfsi --version\r\nF# Interactive 4.3.1.0\r\n```\r\n\r\nIs usefull because:\r\n* --version is pretty much standard\r\n* we need a param to call fsi, to get minimal info about version and return code 0 ( so can be used to other program like pkg-config --atleat-version )\r\n\r\nQuestion: now i read Assembly ProductiVersion, there is another attribute? we need to add other info?\r\n* date of build? like 2014-02-22\r\n* git commit identifier? like e914d26\r\n* x86/64/special compile flag really important\r\n* remove `F# Interactive`, print only version?\r\n\r\n\r\n","created_at":"2014-02-22T21:54:06Z","updated_at":"2014-04-04T13:10:55Z","closed_at":"2014-04-04T13:10:55Z","merged_at":null,"merge_commit_sha":"838cfbe9882f9a68633008f9a2d7aadcec935103","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/fsharp/fsharp/pulls/274/commits","review_comments_url":"https://api.github.com/repos/fsharp/fsharp/pulls/274/comments","review_comment_url":"https://api.github.com/repos/fsharp/fsharp/pulls/comments/{number}","comments_url":"https://api.github.com/repos/fsharp/fsharp/issues/274/comments","statuses_url":"https://api.github.com/repos/fsharp/fsharp/statuses/e914d26ec56c151354dafe5091dba33f2f839aef","head":{"label":"enricosada:show_version_from_commandline","ref":"show_version_from_commandline","sha":"e914d26ec56c151354dafe5091dba33f2f839aef","user":{"login":"enricosada","id":147243,"avatar_url":"https://avatars.githubusercontent.com/u/147243?","gravatar_id":"a5e44667dbe576b57503caf63d64e500","url":"https://api.github.com/users/enricosada","html_url":"https://github.com/enricosada","followers_url":"https://api.github.com/users/enricosada/followers","following_url":"https://api.github.com/users/enricosada/following{/other_user}","gists_url":"https://api.github.com/users/enricosada/gists{/gist_id}","starred_url":"https://api.github.com/users/enricosada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enricosada/subscriptions","organizations_url":"https://api.github.com/users/enricosada/orgs","repos_url":"https://api.github.com/users/enricosada/repos","events_url":"https://api.github.com/users/enricosada/events{/privacy}","received_events_url":"https://api.github.com/users/enricosada/received_events","type":"User","site_admin":false},"repo":{"id":15349780,"name":"fsharp","full_name":"enricosada/fsharp","owner":{"login":"enricosada","id":147243,"avatar_url":"https://avatars.githubusercontent.com/u/147243?","gravatar_id":"a5e44667dbe576b57503caf63d64e500","url":"https://api.github.com/users/enricosada","html_url":"https://github.com/enricosada","followers_url":"https://api.github.com/users/enricosada/followers","following_url":"https://api.github.com/users/enricosada/following{/other_user}","gists_url":"https://api.github.com/users/enricosada/gists{/gist_id}","starred_url":"https://api.github.com/users/enricosada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enricosada/subscriptions","organizations_url":"https://api.github.com/users/enricosada/orgs","repos_url":"https://api.github.com/users/enricosada/repos","events_url":"https://api.github.com/users/enricosada/events{/privacy}","received_events_url":"https://api.github.com/users/enricosada/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/enricosada/fsharp","description":"The F# compiler, core library and core tools (open source edition)","fork":true,"url":"https://api.github.com/repos/enricosada/fsharp","forks_url":"https://api.github.com/repos/enricosada/fsharp/forks","keys_url":"https://api.github.com/repos/enricosada/fsharp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/enricosada/fsharp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/enricosada/fsharp/teams","hooks_url":"https://api.github.com/repos/enricosada/fsharp/hooks","issue_events_url":"https://api.github.com/repos/enricosada/fsharp/issues/events{/number}","events_url":"https://api.github.com/repos/enricosada/fsharp/events","assignees_url":"https://api.github.com/repos/enricosada/fsharp/assignees{/user}","branches_url":"https://api.github.com/repos/enricosada/fsharp/branches{/branch}","tags_url":"https://api.github.com/repos/enricosada/fsharp/tags","blobs_url":"https://api.github.com/repos/enricosada/fsharp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/enricosada/fsharp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/enricosada/fsharp/git/refs{/sha}","trees_url":"https://api.github.com/repos/enricosada/fsharp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/enricosada/fsharp/statuses/{sha}","languages_url":"https://api.github.com/repos/enricosada/fsharp/languages","stargazers_url":"https://api.github.com/repos/enricosada/fsharp/stargazers","contributors_url":"https://api.github.com/repos/enricosada/fsharp/contributors","subscribers_url":"https://api.github.com/repos/enricosada/fsharp/subscribers","subscription_url":"https://api.github.com/repos/enricosada/fsharp/subscription","commits_url":"https://api.github.com/repos/enricosada/fsharp/commits{/sha}","git_commits_url":"https://api.github.com/repos/enricosada/fsharp/git/commits{/sha}","comments_url":"https://api.github.com/repos/enricosada/fsharp/comments{/number}","issue_comment_url":"https://api.github.com/repos/enricosada/fsharp/issues/comments/{number}","contents_url":"https://api.github.com/repos/enricosada/fsharp/contents/{+path}","compare_url":"https://api.github.com/repos/enricosada/fsharp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/enricosada/fsharp/merges","archive_url":"https://api.github.com/repos/enricosada/fsharp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/enricosada/fsharp/downloads","issues_url":"https://api.github.com/repos/enricosada/fsharp/issues{/number}","pulls_url":"https://api.github.com/repos/enricosada/fsharp/pulls{/number}","milestones_url":"https://api.github.com/repos/enricosada/fsharp/milestones{/number}","notifications_url":"https://api.github.com/repos/enricosada/fsharp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/enricosada/fsharp/labels{/name}","releases_url":"https://api.github.com/repos/enricosada/fsharp/releases{/id}","created_at":"2013-12-20T22:33:17Z","updated_at":"2014-04-04T13:10:28Z","pushed_at":"2014-03-22T17:55:35Z","git_url":"git://github.com/enricosada/fsharp.git","ssh_url":"git@github.com:enricosada/fsharp.git","clone_url":"https://github.com/enricosada/fsharp.git","svn_url":"https://github.com/enricosada/fsharp","homepage":"http://fsharp.github.com/fsharp","size":54845,"stargazers_count":0,"watchers_count":0,"language":"F#","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master","master_branch":"master"}},"base":{"label":"fsharp:master","ref":"master","sha":"0d2ee58db4967387cf8a7ae5d1c7f00b34137f6b","user":{"login":"fsharp","id":485415,"avatar_url":"https://avatars.githubusercontent.com/u/485415?","gravatar_id":"db0bc7081238324591d7f0d64373f13d","url":"https://api.github.com/users/fsharp","html_url":"https://github.com/fsharp","followers_url":"https://api.github.com/users/fsharp/followers","following_url":"https://api.github.com/users/fsharp/following{/other_user}","gists_url":"https://api.github.com/users/fsharp/gists{/gist_id}","starred_url":"https://api.github.com/users/fsharp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fsharp/subscriptions","organizations_url":"https://api.github.com/users/fsharp/orgs","repos_url":"https://api.github.com/users/fsharp/repos","events_url":"https://api.github.com/users/fsharp/events{/privacy}","received_events_url":"https://api.github.com/users/fsharp/received_events","type":"Organization","site_admin":false},"repo":{"id":1162709,"name":"fsharp","full_name":"fsharp/fsharp","owner":{"login":"fsharp","id":485415,"avatar_url":"https://avatars.githubusercontent.com/u/485415?","gravatar_id":"db0bc7081238324591d7f0d64373f13d","url":"https://api.github.com/users/fsharp","html_url":"https://github.com/fsharp","followers_url":"https://api.github.com/users/fsharp/followers","following_url":"https://api.github.com/users/fsharp/following{/other_user}","gists_url":"https://api.github.com/users/fsharp/gists{/gist_id}","starred_url":"https://api.github.com/users/fsharp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fsharp/subscriptions","organizations_url":"https://api.github.com/users/fsharp/orgs","repos_url":"https://api.github.com/users/fsharp/repos","events_url":"https://api.github.com/users/fsharp/events{/privacy}","received_events_url":"https://api.github.com/users/fsharp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fsharp/fsharp","description":"The F# Software Foundation packaging repository for the open edition of the F# compiler, core library and tools","fork":false,"url":"https://api.github.com/repos/fsharp/fsharp","forks_url":"https://api.github.com/repos/fsharp/fsharp/forks","keys_url":"https://api.github.com/repos/fsharp/fsharp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fsharp/fsharp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fsharp/fsharp/teams","hooks_url":"https://api.github.com/repos/fsharp/fsharp/hooks","issue_events_url":"https://api.github.com/repos/fsharp/fsharp/issues/events{/number}","events_url":"https://api.github.com/repos/fsharp/fsharp/events","assignees_url":"https://api.github.com/repos/fsharp/fsharp/assignees{/user}","branches_url":"https://api.github.com/repos/fsharp/fsharp/branches{/branch}","tags_url":"https://api.github.com/repos/fsharp/fsharp/tags","blobs_url":"https://api.github.com/repos/fsharp/fsharp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fsharp/fsharp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fsharp/fsharp/git/refs{/sha}","trees_url":"https://api.github.com/repos/fsharp/fsharp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fsharp/fsharp/statuses/{sha}","languages_url":"https://api.github.com/repos/fsharp/fsharp/languages","stargazers_url":"https://api.github.com/repos/fsharp/fsharp/stargazers","contributors_url":"https://api.github.com/repos/fsharp/fsharp/contributors","subscribers_url":"https://api.github.com/repos/fsharp/fsharp/subscribers","subscription_url":"https://api.github.com/repos/fsharp/fsharp/subscription","commits_url":"https://api.github.com/repos/fsharp/fsharp/commits{/sha}","git_commits_url":"https://api.github.com/repos/fsharp/fsharp/git/commits{/sha}","comments_url":"https://api.github.com/repos/fsharp/fsharp/comments{/number}","issue_comment_url":"https://api.github.com/repos/fsharp/fsharp/issues/comments/{number}","contents_url":"https://api.github.com/repos/fsharp/fsharp/contents/{+path}","compare_url":"https://api.github.com/repos/fsharp/fsharp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fsharp/fsharp/merges","archive_url":"https://api.github.com/repos/fsharp/fsharp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fsharp/fsharp/downloads","issues_url":"https://api.github.com/repos/fsharp/fsharp/issues{/number}","pulls_url":"https://api.github.com/repos/fsharp/fsharp/pulls{/number}","milestones_url":"https://api.github.com/repos/fsharp/fsharp/milestones{/number}","notifications_url":"https://api.github.com/repos/fsharp/fsharp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fsharp/fsharp/labels{/name}","releases_url":"https://api.github.com/repos/fsharp/fsharp/releases{/id}","created_at":"2010-12-13T00:19:52Z","updated_at":"2014-04-04T12:53:21Z","pushed_at":"2014-04-04T12:53:20Z","git_url":"git://github.com/fsharp/fsharp.git","ssh_url":"git@github.com:fsharp/fsharp.git","clone_url":"https://github.com/fsharp/fsharp.git","svn_url":"https://github.com/fsharp/fsharp","homepage":"http://fsharp.org","size":68281,"stargazers_count":524,"watchers_count":524,"language":"F#","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":135,"mirror_url":null,"open_issues_count":34,"forks":135,"open_issues":34,"watchers":524,"default_branch":"master","master_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fsharp/fsharp/pulls/274"},"html":{"href":"https://github.com/fsharp/fsharp/pull/274"},"issue":{"href":"https://api.github.com/repos/fsharp/fsharp/issues/274"},"comments":{"href":"https://api.github.com/repos/fsharp/fsharp/issues/274/comments"},"review_comments":{"href":"https://api.github.com/repos/fsharp/fsharp/pulls/274/comments"},"review_comment":{"href":"https://api.github.com/repos/fsharp/fsharp/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/fsharp/fsharp/pulls/274/commits"},"statuses":{"href":"https://api.github.com/repos/fsharp/fsharp/statuses/e914d26ec56c151354dafe5091dba33f2f839aef"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"commits":1,"additions":19,"deletions":10,"changed_files":6}}