GitHub PullRequestEvent at 2014-10-20 16:43:54
Repository: devise_token_auth
Actor: booleanbetrayal
Payload: {"action":"opened","number":49,"pull_request":{"url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/pulls/49","id":23028019,"html_url":"https://github.com/lynndylanhurley/devise_token_auth/pull/49","diff_url":"https://github.com/lynndylanhurley/devise_token_auth/pull/49.diff","patch_url":"https://github.com/lynndylanhurley/devise_token_auth/pull/49.patch","issue_url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/issues/49","number":49,"state":"open","locked":false,"title":"fix(expiry): fix an issue where token expiration checks were too permissive","user":{"login":"booleanbetrayal","id":981825,"avatar_url":"https://avatars.githubusercontent.com/u/981825?v=2","gravatar_id":"","url":"https://api.github.com/users/booleanbetrayal","html_url":"https://github.com/booleanbetrayal","followers_url":"https://api.github.com/users/booleanbetrayal/followers","following_url":"https://api.github.com/users/booleanbetrayal/following{/other_user}","gists_url":"https://api.github.com/users/booleanbetrayal/gists{/gist_id}","starred_url":"https://api.github.com/users/booleanbetrayal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/booleanbetrayal/subscriptions","organizations_url":"https://api.github.com/users/booleanbetrayal/orgs","repos_url":"https://api.github.com/users/booleanbetrayal/repos","events_url":"https://api.github.com/users/booleanbetrayal/events{/privacy}","received_events_url":"https://api.github.com/users/booleanbetrayal/received_events","type":"User","site_admin":false},"body":"Looks like the expiration check in `token_is_current?` would have always passed. Let me know if there's something I'm missing here.","created_at":"2014-10-20T16:43:54Z","updated_at":"2014-10-20T16:43:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/pulls/49/commits","review_comments_url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/pulls/49/comments","review_comment_url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/pulls/comments/{number}","comments_url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/issues/49/comments","statuses_url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/statuses/718a4f3b8b659f88e346442220dd00e8fbd7a20e","head":{"label":"booleanbetrayal:expiry_check_too_permissive","ref":"expiry_check_too_permissive","sha":"718a4f3b8b659f88e346442220dd00e8fbd7a20e","user":{"login":"booleanbetrayal","id":981825,"avatar_url":"https://avatars.githubusercontent.com/u/981825?v=2","gravatar_id":"","url":"https://api.github.com/users/booleanbetrayal","html_url":"https://github.com/booleanbetrayal","followers_url":"https://api.github.com/users/booleanbetrayal/followers","following_url":"https://api.github.com/users/booleanbetrayal/following{/other_user}","gists_url":"https://api.github.com/users/booleanbetrayal/gists{/gist_id}","starred_url":"https://api.github.com/users/booleanbetrayal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/booleanbetrayal/subscriptions","organizations_url":"https://api.github.com/users/booleanbetrayal/orgs","repos_url":"https://api.github.com/users/booleanbetrayal/repos","events_url":"https://api.github.com/users/booleanbetrayal/events{/privacy}","received_events_url":"https://api.github.com/users/booleanbetrayal/received_events","type":"User","site_admin":false},"repo":{"id":25472461,"name":"devise_token_auth","full_name":"booleanbetrayal/devise_token_auth","owner":{"login":"booleanbetrayal","id":981825,"avatar_url":"https://avatars.githubusercontent.com/u/981825?v=2","gravatar_id":"","url":"https://api.github.com/users/booleanbetrayal","html_url":"https://github.com/booleanbetrayal","followers_url":"https://api.github.com/users/booleanbetrayal/followers","following_url":"https://api.github.com/users/booleanbetrayal/following{/other_user}","gists_url":"https://api.github.com/users/booleanbetrayal/gists{/gist_id}","starred_url":"https://api.github.com/users/booleanbetrayal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/booleanbetrayal/subscriptions","organizations_url":"https://api.github.com/users/booleanbetrayal/orgs","repos_url":"https://api.github.com/users/booleanbetrayal/repos","events_url":"https://api.github.com/users/booleanbetrayal/events{/privacy}","received_events_url":"https://api.github.com/users/booleanbetrayal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/booleanbetrayal/devise_token_auth","description":"Token based authentication for Rails JSON APIs. Designed to work with http://github.com/lynndylanhurley/ng-token-auth","fork":true,"url":"https://api.github.com/repos/booleanbetrayal/devise_token_auth","forks_url":"https://api.github.com/repos/booleanbetrayal/devise_token_auth/forks","keys_url":"https://api.github.com/repos/booleanbetrayal/devise_token_auth/keys{/key_id}","collaborators_url":"https://api.github.com/repos/booleanbetrayal/devise_token_auth/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/booleanbetrayal/devise_token_auth/teams","hooks_url":"https://api.github.com/repos/booleanbetrayal/devise_token_auth/hooks","issue_events_url":"https://api.github.com/repos/booleanbetrayal/devise_token_auth/issues/events{/number}","events_url":"https://api.github.com/repos/booleanbetrayal/devise_token_auth/events","assignees_url":"https://api.github.com/repos/booleanbetrayal/devise_token_auth/assignees{/user}","branches_url":"https://api.github.com/repos/booleanbetrayal/devise_token_auth/branches{/branch}","tags_url":"https://api.github.com/repos/booleanbetrayal/devise_token_auth/tags","blobs_url":"https://api.github.com/repos/booleanbetrayal/devise_token_auth/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/booleanbetrayal/devise_token_auth/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/booleanbetrayal/devise_token_auth/git/refs{/sha}","trees_url":"https://api.github.com/repos/booleanbetrayal/devise_token_auth/git/trees{/sha}","statuses_url":"https://api.github.com/repos/booleanbetrayal/devise_token_auth/statuses/{sha}","languages_url":"https://api.github.com/repos/booleanbetrayal/devise_token_auth/languages","stargazers_url":"https://api.github.com/repos/booleanbetrayal/devise_token_auth/stargazers","contributors_url":"https://api.github.com/repos/booleanbetrayal/devise_token_auth/contributors","subscribers_url":"https://api.github.com/repos/booleanbetrayal/devise_token_auth/subscribers","subscription_url":"https://api.github.com/repos/booleanbetrayal/devise_token_auth/subscription","commits_url":"https://api.github.com/repos/booleanbetrayal/devise_token_auth/commits{/sha}","git_commits_url":"https://api.github.com/repos/booleanbetrayal/devise_token_auth/git/commits{/sha}","comments_url":"https://api.github.com/repos/booleanbetrayal/devise_token_auth/comments{/number}","issue_comment_url":"https://api.github.com/repos/booleanbetrayal/devise_token_auth/issues/comments/{number}","contents_url":"https://api.github.com/repos/booleanbetrayal/devise_token_auth/contents/{+path}","compare_url":"https://api.github.com/repos/booleanbetrayal/devise_token_auth/compare/{base}...{head}","merges_url":"https://api.github.com/repos/booleanbetrayal/devise_token_auth/merges","archive_url":"https://api.github.com/repos/booleanbetrayal/devise_token_auth/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/booleanbetrayal/devise_token_auth/downloads","issues_url":"https://api.github.com/repos/booleanbetrayal/devise_token_auth/issues{/number}","pulls_url":"https://api.github.com/repos/booleanbetrayal/devise_token_auth/pulls{/number}","milestones_url":"https://api.github.com/repos/booleanbetrayal/devise_token_auth/milestones{/number}","notifications_url":"https://api.github.com/repos/booleanbetrayal/devise_token_auth/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/booleanbetrayal/devise_token_auth/labels{/name}","releases_url":"https://api.github.com/repos/booleanbetrayal/devise_token_auth/releases{/id}","created_at":"2014-10-20T15:20:19Z","updated_at":"2014-10-20T11:27:56Z","pushed_at":"2014-10-20T16:41:01Z","git_url":"git://github.com/booleanbetrayal/devise_token_auth.git","ssh_url":"git@github.com:booleanbetrayal/devise_token_auth.git","clone_url":"https://github.com/booleanbetrayal/devise_token_auth.git","svn_url":"https://github.com/booleanbetrayal/devise_token_auth","homepage":null,"size":8493,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"lynndylanhurley:master","ref":"master","sha":"a118b95833ad32fdb37101c3fa60fa95ac11f1bf","user":{"login":"lynndylanhurley","id":468037,"avatar_url":"https://avatars.githubusercontent.com/u/468037?v=2","gravatar_id":"","url":"https://api.github.com/users/lynndylanhurley","html_url":"https://github.com/lynndylanhurley","followers_url":"https://api.github.com/users/lynndylanhurley/followers","following_url":"https://api.github.com/users/lynndylanhurley/following{/other_user}","gists_url":"https://api.github.com/users/lynndylanhurley/gists{/gist_id}","starred_url":"https://api.github.com/users/lynndylanhurley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lynndylanhurley/subscriptions","organizations_url":"https://api.github.com/users/lynndylanhurley/orgs","repos_url":"https://api.github.com/users/lynndylanhurley/repos","events_url":"https://api.github.com/users/lynndylanhurley/events{/privacy}","received_events_url":"https://api.github.com/users/lynndylanhurley/received_events","type":"User","site_admin":false},"repo":{"id":21333814,"name":"devise_token_auth","full_name":"lynndylanhurley/devise_token_auth","owner":{"login":"lynndylanhurley","id":468037,"avatar_url":"https://avatars.githubusercontent.com/u/468037?v=2","gravatar_id":"","url":"https://api.github.com/users/lynndylanhurley","html_url":"https://github.com/lynndylanhurley","followers_url":"https://api.github.com/users/lynndylanhurley/followers","following_url":"https://api.github.com/users/lynndylanhurley/following{/other_user}","gists_url":"https://api.github.com/users/lynndylanhurley/gists{/gist_id}","starred_url":"https://api.github.com/users/lynndylanhurley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lynndylanhurley/subscriptions","organizations_url":"https://api.github.com/users/lynndylanhurley/orgs","repos_url":"https://api.github.com/users/lynndylanhurley/repos","events_url":"https://api.github.com/users/lynndylanhurley/events{/privacy}","received_events_url":"https://api.github.com/users/lynndylanhurley/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lynndylanhurley/devise_token_auth","description":"Token based authentication for Rails JSON APIs. Designed to work with http://github.com/lynndylanhurley/ng-token-auth","fork":false,"url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth","forks_url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/forks","keys_url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/teams","hooks_url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/hooks","issue_events_url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/issues/events{/number}","events_url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/events","assignees_url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/assignees{/user}","branches_url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/branches{/branch}","tags_url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/tags","blobs_url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/git/refs{/sha}","trees_url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/statuses/{sha}","languages_url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/languages","stargazers_url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/stargazers","contributors_url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/contributors","subscribers_url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/subscribers","subscription_url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/subscription","commits_url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/commits{/sha}","git_commits_url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/git/commits{/sha}","comments_url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/comments{/number}","issue_comment_url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/issues/comments/{number}","contents_url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/contents/{+path}","compare_url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/merges","archive_url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/downloads","issues_url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/issues{/number}","pulls_url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/pulls{/number}","milestones_url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/milestones{/number}","notifications_url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/labels{/name}","releases_url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/releases{/id}","created_at":"2014-06-29T22:43:58Z","updated_at":"2014-10-20T11:27:56Z","pushed_at":"2014-10-09T15:42:13Z","git_url":"git://github.com/lynndylanhurley/devise_token_auth.git","ssh_url":"git@github.com:lynndylanhurley/devise_token_auth.git","clone_url":"https://github.com/lynndylanhurley/devise_token_auth.git","svn_url":"https://github.com/lynndylanhurley/devise_token_auth","homepage":null,"size":8493,"stargazers_count":116,"watchers_count":116,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":8,"forks":17,"open_issues":8,"watchers":116,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/pulls/49"},"html":{"href":"https://github.com/lynndylanhurley/devise_token_auth/pull/49"},"issue":{"href":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/issues/49"},"comments":{"href":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/issues/49/comments"},"review_comments":{"href":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/pulls/49/comments"},"review_comment":{"href":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/pulls/49/commits"},"statuses":{"href":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/statuses/718a4f3b8b659f88e346442220dd00e8fbd7a20e"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":22,"deletions":2,"changed_files":2}}