GitHub PullRequestReviewCommentEvent at 2014-08-06 15:33:53
Repository: opencv
Actor: prattmic
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/Itseez/opencv/pulls/comments/15881805","id":15881805,"diff_hunk":"@@ -0,0 +1,138 @@\n+# This file is included from a subdirectory\n+set(PYTHON_SOURCE_DIR \"${CMAKE_CURRENT_SOURCE_DIR}/../\")\n+\n+set(candidate_deps \"\")\n+foreach(mp ${OPENCV_MODULES_PATH} ${OPENCV_EXTRA_MODULES_PATH})\n+    file(GLOB names \"${mp}/*\")\n+    foreach(m IN LISTS names)\n+        if(IS_DIRECTORY ${m})\n+            get_filename_component(m ${m} NAME)\n+            list(APPEND candidate_deps \"opencv_${m}\")\n+        endif()\n+    endforeach(m)\n+endforeach(mp)\n+\n+# module blacklist\n+ocv_list_filterout(candidate_deps \"^opencv_cud(a|ev)\")\n+ocv_list_filterout(candidate_deps \"^opencv_adas$\")\n+ocv_list_filterout(candidate_deps \"^opencv_tracking$\")\n+\n+\n+ocv_add_module(${MODULE_NAME} BINDINGS OPTIONAL ${candidate_deps})\n+\n+ocv_module_include_directories(\n+    \"${PYTHON_INCLUDE_PATH}\"\n+    ${PYTHON_NUMPY_INCLUDE_DIRS}\n+    \"${PYTHON_SOURCE_DIR}/src2\"\n+    )\n+\n+set(opencv_hdrs \"\")\n+foreach(m IN LISTS OPENCV_MODULE_opencv_${MODULE_NAME}_DEPS)\n+    list(APPEND opencv_hdrs ${OPENCV_MODULE_${m}_HEADERS})\n+endforeach(m)\n+\n+# header blacklist\n+ocv_list_filterout(opencv_hdrs \".h$\")\n+ocv_list_filterout(opencv_hdrs \"cuda\")\n+ocv_list_filterout(opencv_hdrs \"cudev\")\n+ocv_list_filterout(opencv_hdrs \"opencv2/objdetect/detection_based_tracker.hpp\")\n+ocv_list_filterout(opencv_hdrs \"opencv2/optim.hpp\")\n+\n+set(cv2_generated_hdrs\n+    \"${CMAKE_CURRENT_BINARY_DIR}/pyopencv_generated_include.h\"\n+    \"${CMAKE_CURRENT_BINARY_DIR}/pyopencv_generated_funcs.h\"\n+    \"${CMAKE_CURRENT_BINARY_DIR}/pyopencv_generated_func_tab.h\"\n+    \"${CMAKE_CURRENT_BINARY_DIR}/pyopencv_generated_types.h\"\n+    \"${CMAKE_CURRENT_BINARY_DIR}/pyopencv_generated_type_reg.h\"\n+    \"${CMAKE_CURRENT_BINARY_DIR}/pyopencv_generated_const_reg.h\")\n+\n+file(WRITE \"${CMAKE_CURRENT_BINARY_DIR}/headers.txt\" \"${opencv_hdrs}\")\n+add_custom_command(\n+   OUTPUT ${cv2_generated_hdrs}\n+   COMMAND ${PYTHON_EXECUTABLE} \"${PYTHON_SOURCE_DIR}/src2/gen2.py\" ${CMAKE_CURRENT_BINARY_DIR} \"${CMAKE_CURRENT_BINARY_DIR}/headers.txt\"\n+   DEPENDS ${PYTHON_SOURCE_DIR}/src2/gen2.py\n+   DEPENDS ${PYTHON_SOURCE_DIR}/src2/hdr_parser.py\n+   DEPENDS ${CMAKE_CURRENT_BINARY_DIR}/headers.txt\n+   DEPENDS ${opencv_hdrs})\n+\n+add_library(${the_module} SHARED ${PYTHON_SOURCE_DIR}/src2/cv2.cpp ${cv2_generated_hdrs})\n+set_target_properties(${the_module} PROPERTIES COMPILE_DEFINITIONS OPENCV_NOSTL)\n+\n+if(PYTHON_DEBUG_LIBRARIES AND NOT PYTHON_LIBRARIES MATCHES \"optimized.*debug\")\n+  target_link_libraries(${the_module} debug ${PYTHON_DEBUG_LIBRARIES} optimized ${PYTHON_LIBRARIES})\n+else()\n+  target_link_libraries(${the_module} ${PYTHON_LIBRARIES})\n+endif()\n+target_link_libraries(${the_module} ${OPENCV_MODULE_${the_module}_DEPS})\n+\n+execute_process(COMMAND ${PYTHON_EXECUTABLE} -c \"import distutils.sysconfig; print(distutils.sysconfig.get_config_var('SO'))\"\n+                RESULT_VARIABLE PYTHON_CVPY_PROCESS\n+                OUTPUT_VARIABLE CVPY_SUFFIX\n+                OUTPUT_STRIP_TRAILING_WHITESPACE)\n+\n+set_target_properties(${the_module} PROPERTIES\n+                      LIBRARY_OUTPUT_DIRECTORY  \"${LIBRARY_OUTPUT_PATH}/${MODULE_NAME}\"","path":"modules/python/common.cmake","position":74,"original_position":74,"commit_id":"9d9411555fa87321a1e36a39c8993c224f66e2fd","original_commit_id":"9d9411555fa87321a1e36a39c8993c224f66e2fd","user":{"login":"prattmic","id":1293187,"avatar_url":"https://avatars.githubusercontent.com/u/1293187?v=2","gravatar_id":"04517ba4c854fb53dbc14b4cae73717b","url":"https://api.github.com/users/prattmic","html_url":"https://github.com/prattmic","followers_url":"https://api.github.com/users/prattmic/followers","following_url":"https://api.github.com/users/prattmic/following{/other_user}","gists_url":"https://api.github.com/users/prattmic/gists{/gist_id}","starred_url":"https://api.github.com/users/prattmic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prattmic/subscriptions","organizations_url":"https://api.github.com/users/prattmic/orgs","repos_url":"https://api.github.com/users/prattmic/repos","events_url":"https://api.github.com/users/prattmic/events{/privacy}","received_events_url":"https://api.github.com/users/prattmic/received_events","type":"User","site_admin":false},"body":"That would work.  I think a better solution would be to run the test suite with PYTHONPATH set to the library subdirectory.  That way, it would be trivial to run the test suite on Python 3 as well.  It looks like a few trivial changes to Python test.py can make it compatible with Python 2 and 3.\r\n\r\nI have searched and searched to no avail trying to find the rule that runs the Python tests so that I can update it.  I found the actual test script in modules/python/test/, but cannot find the test rules that invoke it.  Is this something built into Buildbot that needs to be updated?","created_at":"2014-08-06T15:33:53Z","updated_at":"2014-08-06T15:33:53Z","html_url":"https://github.com/Itseez/opencv/pull/3047#discussion_r15881805","pull_request_url":"https://api.github.com/repos/Itseez/opencv/pulls/3047","_links":{"self":{"href":"https://api.github.com/repos/Itseez/opencv/pulls/comments/15881805"},"html":{"href":"https://github.com/Itseez/opencv/pull/3047#discussion_r15881805"},"pull_request":{"href":"https://api.github.com/repos/Itseez/opencv/pulls/3047"}}},"pull_request":{"url":"https://api.github.com/repos/Itseez/opencv/pulls/3047","id":19387067,"html_url":"https://github.com/Itseez/opencv/pull/3047","diff_url":"https://github.com/Itseez/opencv/pull/3047.diff","patch_url":"https://github.com/Itseez/opencv/pull/3047.patch","issue_url":"https://api.github.com/repos/Itseez/opencv/issues/3047","number":3047,"state":"open","title":"Build both Python 2 and Python 3 bindings","user":{"login":"prattmic","id":1293187,"avatar_url":"https://avatars.githubusercontent.com/u/1293187?v=2","gravatar_id":"04517ba4c854fb53dbc14b4cae73717b","url":"https://api.github.com/users/prattmic","html_url":"https://github.com/prattmic","followers_url":"https://api.github.com/users/prattmic/followers","following_url":"https://api.github.com/users/prattmic/following{/other_user}","gists_url":"https://api.github.com/users/prattmic/gists{/gist_id}","starred_url":"https://api.github.com/users/prattmic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prattmic/subscriptions","organizations_url":"https://api.github.com/users/prattmic/orgs","repos_url":"https://api.github.com/users/prattmic/repos","events_url":"https://api.github.com/users/prattmic/events{/privacy}","received_events_url":"https://api.github.com/users/prattmic/received_events","type":"User","site_admin":false},"body":"This replaces #2912 and potentially #3040 by @vpisarev.\r\n\r\nI have once again updated my branch with master.  To address @vpisarev's concerns about module naming conflicts, the generated library is placed inside of a dedicated folder inside of lib/.  This way, there can be no naming conflicts.\r\n\r\nAs an aside, it looks like the Buildbot machine needs some upgrades to properly test these changes.  The Linux machine appears to be missing the necessary Python 3 Numpy packages.  The Windows and Mac machine appear to be missing Python 3 altogether.","created_at":"2014-08-06T06:38:24Z","updated_at":"2014-08-06T15:33:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"94c5c197af3b15f216138cdaed6cb53555b0e04b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Itseez/opencv/pulls/3047/commits","review_comments_url":"https://api.github.com/repos/Itseez/opencv/pulls/3047/comments","review_comment_url":"https://api.github.com/repos/Itseez/opencv/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Itseez/opencv/issues/3047/comments","statuses_url":"https://api.github.com/repos/Itseez/opencv/statuses/9d9411555fa87321a1e36a39c8993c224f66e2fd","head":{"label":"prattmic:python2and3","ref":"python2and3","sha":"9d9411555fa87321a1e36a39c8993c224f66e2fd","user":{"login":"prattmic","id":1293187,"avatar_url":"https://avatars.githubusercontent.com/u/1293187?v=2","gravatar_id":"04517ba4c854fb53dbc14b4cae73717b","url":"https://api.github.com/users/prattmic","html_url":"https://github.com/prattmic","followers_url":"https://api.github.com/users/prattmic/followers","following_url":"https://api.github.com/users/prattmic/following{/other_user}","gists_url":"https://api.github.com/users/prattmic/gists{/gist_id}","starred_url":"https://api.github.com/users/prattmic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prattmic/subscriptions","organizations_url":"https://api.github.com/users/prattmic/orgs","repos_url":"https://api.github.com/users/prattmic/repos","events_url":"https://api.github.com/users/prattmic/events{/privacy}","received_events_url":"https://api.github.com/users/prattmic/received_events","type":"User","site_admin":false},"repo":{"id":13758699,"name":"opencv","full_name":"prattmic/opencv","owner":{"login":"prattmic","id":1293187,"avatar_url":"https://avatars.githubusercontent.com/u/1293187?v=2","gravatar_id":"04517ba4c854fb53dbc14b4cae73717b","url":"https://api.github.com/users/prattmic","html_url":"https://github.com/prattmic","followers_url":"https://api.github.com/users/prattmic/followers","following_url":"https://api.github.com/users/prattmic/following{/other_user}","gists_url":"https://api.github.com/users/prattmic/gists{/gist_id}","starred_url":"https://api.github.com/users/prattmic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prattmic/subscriptions","organizations_url":"https://api.github.com/users/prattmic/orgs","repos_url":"https://api.github.com/users/prattmic/repos","events_url":"https://api.github.com/users/prattmic/events{/privacy}","received_events_url":"https://api.github.com/users/prattmic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/prattmic/opencv","description":"Open Source Computer Vision Library","fork":true,"url":"https://api.github.com/repos/prattmic/opencv","forks_url":"https://api.github.com/repos/prattmic/opencv/forks","keys_url":"https://api.github.com/repos/prattmic/opencv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prattmic/opencv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prattmic/opencv/teams","hooks_url":"https://api.github.com/repos/prattmic/opencv/hooks","issue_events_url":"https://api.github.com/repos/prattmic/opencv/issues/events{/number}","events_url":"https://api.github.com/repos/prattmic/opencv/events","assignees_url":"https://api.github.com/repos/prattmic/opencv/assignees{/user}","branches_url":"https://api.github.com/repos/prattmic/opencv/branches{/branch}","tags_url":"https://api.github.com/repos/prattmic/opencv/tags","blobs_url":"https://api.github.com/repos/prattmic/opencv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prattmic/opencv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prattmic/opencv/git/refs{/sha}","trees_url":"https://api.github.com/repos/prattmic/opencv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prattmic/opencv/statuses/{sha}","languages_url":"https://api.github.com/repos/prattmic/opencv/languages","stargazers_url":"https://api.github.com/repos/prattmic/opencv/stargazers","contributors_url":"https://api.github.com/repos/prattmic/opencv/contributors","subscribers_url":"https://api.github.com/repos/prattmic/opencv/subscribers","subscription_url":"https://api.github.com/repos/prattmic/opencv/subscription","commits_url":"https://api.github.com/repos/prattmic/opencv/commits{/sha}","git_commits_url":"https://api.github.com/repos/prattmic/opencv/git/commits{/sha}","comments_url":"https://api.github.com/repos/prattmic/opencv/comments{/number}","issue_comment_url":"https://api.github.com/repos/prattmic/opencv/issues/comments/{number}","contents_url":"https://api.github.com/repos/prattmic/opencv/contents/{+path}","compare_url":"https://api.github.com/repos/prattmic/opencv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prattmic/opencv/merges","archive_url":"https://api.github.com/repos/prattmic/opencv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prattmic/opencv/downloads","issues_url":"https://api.github.com/repos/prattmic/opencv/issues{/number}","pulls_url":"https://api.github.com/repos/prattmic/opencv/pulls{/number}","milestones_url":"https://api.github.com/repos/prattmic/opencv/milestones{/number}","notifications_url":"https://api.github.com/repos/prattmic/opencv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prattmic/opencv/labels{/name}","releases_url":"https://api.github.com/repos/prattmic/opencv/releases{/id}","created_at":"2013-10-22T00:04:36Z","updated_at":"2014-06-30T00:25:18Z","pushed_at":"2014-08-06T06:32:56Z","git_url":"git://github.com/prattmic/opencv.git","ssh_url":"git@github.com:prattmic/opencv.git","clone_url":"https://github.com/prattmic/opencv.git","svn_url":"https://github.com/prattmic/opencv","homepage":"opencv.org","size":418130,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Itseez:master","ref":"master","sha":"d2f1c00719383e9c42a4ff36f99babae910af64b","user":{"login":"Itseez","id":1786446,"avatar_url":"https://avatars.githubusercontent.com/u/1786446?v=2","gravatar_id":"52a9e25d70220a4655783af1fc5f118f","url":"https://api.github.com/users/Itseez","html_url":"https://github.com/Itseez","followers_url":"https://api.github.com/users/Itseez/followers","following_url":"https://api.github.com/users/Itseez/following{/other_user}","gists_url":"https://api.github.com/users/Itseez/gists{/gist_id}","starred_url":"https://api.github.com/users/Itseez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Itseez/subscriptions","organizations_url":"https://api.github.com/users/Itseez/orgs","repos_url":"https://api.github.com/users/Itseez/repos","events_url":"https://api.github.com/users/Itseez/events{/privacy}","received_events_url":"https://api.github.com/users/Itseez/received_events","type":"Organization","site_admin":false},"repo":{"id":5108051,"name":"opencv","full_name":"Itseez/opencv","owner":{"login":"Itseez","id":1786446,"avatar_url":"https://avatars.githubusercontent.com/u/1786446?v=2","gravatar_id":"52a9e25d70220a4655783af1fc5f118f","url":"https://api.github.com/users/Itseez","html_url":"https://github.com/Itseez","followers_url":"https://api.github.com/users/Itseez/followers","following_url":"https://api.github.com/users/Itseez/following{/other_user}","gists_url":"https://api.github.com/users/Itseez/gists{/gist_id}","starred_url":"https://api.github.com/users/Itseez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Itseez/subscriptions","organizations_url":"https://api.github.com/users/Itseez/orgs","repos_url":"https://api.github.com/users/Itseez/repos","events_url":"https://api.github.com/users/Itseez/events{/privacy}","received_events_url":"https://api.github.com/users/Itseez/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Itseez/opencv","description":"Open Source Computer Vision Library","fork":false,"url":"https://api.github.com/repos/Itseez/opencv","forks_url":"https://api.github.com/repos/Itseez/opencv/forks","keys_url":"https://api.github.com/repos/Itseez/opencv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Itseez/opencv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Itseez/opencv/teams","hooks_url":"https://api.github.com/repos/Itseez/opencv/hooks","issue_events_url":"https://api.github.com/repos/Itseez/opencv/issues/events{/number}","events_url":"https://api.github.com/repos/Itseez/opencv/events","assignees_url":"https://api.github.com/repos/Itseez/opencv/assignees{/user}","branches_url":"https://api.github.com/repos/Itseez/opencv/branches{/branch}","tags_url":"https://api.github.com/repos/Itseez/opencv/tags","blobs_url":"https://api.github.com/repos/Itseez/opencv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Itseez/opencv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Itseez/opencv/git/refs{/sha}","trees_url":"https://api.github.com/repos/Itseez/opencv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Itseez/opencv/statuses/{sha}","languages_url":"https://api.github.com/repos/Itseez/opencv/languages","stargazers_url":"https://api.github.com/repos/Itseez/opencv/stargazers","contributors_url":"https://api.github.com/repos/Itseez/opencv/contributors","subscribers_url":"https://api.github.com/repos/Itseez/opencv/subscribers","subscription_url":"https://api.github.com/repos/Itseez/opencv/subscription","commits_url":"https://api.github.com/repos/Itseez/opencv/commits{/sha}","git_commits_url":"https://api.github.com/repos/Itseez/opencv/git/commits{/sha}","comments_url":"https://api.github.com/repos/Itseez/opencv/comments{/number}","issue_comment_url":"https://api.github.com/repos/Itseez/opencv/issues/comments/{number}","contents_url":"https://api.github.com/repos/Itseez/opencv/contents/{+path}","compare_url":"https://api.github.com/repos/Itseez/opencv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Itseez/opencv/merges","archive_url":"https://api.github.com/repos/Itseez/opencv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Itseez/opencv/downloads","issues_url":"https://api.github.com/repos/Itseez/opencv/issues{/number}","pulls_url":"https://api.github.com/repos/Itseez/opencv/pulls{/number}","milestones_url":"https://api.github.com/repos/Itseez/opencv/milestones{/number}","notifications_url":"https://api.github.com/repos/Itseez/opencv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Itseez/opencv/labels{/name}","releases_url":"https://api.github.com/repos/Itseez/opencv/releases{/id}","created_at":"2012-07-19T09:40:17Z","updated_at":"2014-08-06T03:21:24Z","pushed_at":"2014-08-06T14:53:38Z","git_url":"git://github.com/Itseez/opencv.git","ssh_url":"git@github.com:Itseez/opencv.git","clone_url":"https://github.com/Itseez/opencv.git","svn_url":"https://github.com/Itseez/opencv","homepage":"opencv.org","size":1075438,"stargazers_count":3098,"watchers_count":3098,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":2919,"mirror_url":null,"open_issues_count":35,"forks":2919,"open_issues":35,"watchers":3098,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Itseez/opencv/pulls/3047"},"html":{"href":"https://github.com/Itseez/opencv/pull/3047"},"issue":{"href":"https://api.github.com/repos/Itseez/opencv/issues/3047"},"comments":{"href":"https://api.github.com/repos/Itseez/opencv/issues/3047/comments"},"review_comments":{"href":"https://api.github.com/repos/Itseez/opencv/pulls/3047/comments"},"review_comment":{"href":"https://api.github.com/repos/Itseez/opencv/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Itseez/opencv/pulls/3047/commits"},"statuses":{"href":"https://api.github.com/repos/Itseez/opencv/statuses/9d9411555fa87321a1e36a39c8993c224f66e2fd"}}}}