GitHub PullRequestEvent at 2014-09-17 09:58:57
Repository: stagecraft
Actor: jabley
Payload: {"action":"closed","number":228,"pull_request":{"url":"https://api.github.com/repos/alphagov/stagecraft/pulls/228","id":21243391,"html_url":"https://github.com/alphagov/stagecraft/pull/228","diff_url":"https://github.com/alphagov/stagecraft/pull/228.diff","patch_url":"https://github.com/alphagov/stagecraft/pull/228.patch","issue_url":"https://api.github.com/repos/alphagov/stagecraft/issues/228","number":228,"state":"closed","locked":false,"title":"[#78806122] Return 400 on module validation error","user":{"login":"robyoung","id":14287,"avatar_url":"https://avatars.githubusercontent.com/u/14287?v=2","gravatar_id":"09cbeba69993bb82b3fc7b70926dfc4c","url":"https://api.github.com/users/robyoung","html_url":"https://github.com/robyoung","followers_url":"https://api.github.com/users/robyoung/followers","following_url":"https://api.github.com/users/robyoung/following{/other_user}","gists_url":"https://api.github.com/users/robyoung/gists{/gist_id}","starred_url":"https://api.github.com/users/robyoung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robyoung/subscriptions","organizations_url":"https://api.github.com/users/robyoung/orgs","repos_url":"https://api.github.com/users/robyoung/repos","events_url":"https://api.github.com/users/robyoung/events{/privacy}","received_events_url":"https://api.github.com/users/robyoung/received_events","type":"User","site_admin":false},"body":"At the moment we fail with a 500 for what should be a 400.\r\n\r\nThis change required blank=True to be set on a few models. The 'null'\r\nargument only applies to whether the database field can be null. The\r\n'blank' argument applies to the validation.","created_at":"2014-09-15T16:27:38Z","updated_at":"2014-09-17T09:58:57Z","closed_at":"2014-09-17T09:58:57Z","merged_at":"2014-09-17T09:58:57Z","merge_commit_sha":"09c30f0738bd46f0c0c37cfa44ec6342de342900","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/stagecraft/pulls/228/commits","review_comments_url":"https://api.github.com/repos/alphagov/stagecraft/pulls/228/comments","review_comment_url":"https://api.github.com/repos/alphagov/stagecraft/pulls/comments/{number}","comments_url":"https://api.github.com/repos/alphagov/stagecraft/issues/228/comments","statuses_url":"https://api.github.com/repos/alphagov/stagecraft/statuses/e125fef5e5d08f5630a1f3ff1fe2f2505650cac2","head":{"label":"alphagov:fail-module-create-with-error","ref":"fail-module-create-with-error","sha":"e125fef5e5d08f5630a1f3ff1fe2f2505650cac2","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=2","gravatar_id":"5618b843830194a2475a6e48823f7455","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":13295877,"name":"stagecraft","full_name":"alphagov/stagecraft","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=2","gravatar_id":"5618b843830194a2475a6e48823f7455","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/stagecraft","description":"A configuration service for the Performance Platform","fork":false,"url":"https://api.github.com/repos/alphagov/stagecraft","forks_url":"https://api.github.com/repos/alphagov/stagecraft/forks","keys_url":"https://api.github.com/repos/alphagov/stagecraft/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/stagecraft/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/stagecraft/teams","hooks_url":"https://api.github.com/repos/alphagov/stagecraft/hooks","issue_events_url":"https://api.github.com/repos/alphagov/stagecraft/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/stagecraft/events","assignees_url":"https://api.github.com/repos/alphagov/stagecraft/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/stagecraft/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/stagecraft/tags","blobs_url":"https://api.github.com/repos/alphagov/stagecraft/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/stagecraft/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/stagecraft/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/stagecraft/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/stagecraft/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/stagecraft/languages","stargazers_url":"https://api.github.com/repos/alphagov/stagecraft/stargazers","contributors_url":"https://api.github.com/repos/alphagov/stagecraft/contributors","subscribers_url":"https://api.github.com/repos/alphagov/stagecraft/subscribers","subscription_url":"https://api.github.com/repos/alphagov/stagecraft/subscription","commits_url":"https://api.github.com/repos/alphagov/stagecraft/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/stagecraft/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/stagecraft/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/stagecraft/issues/comments/{number}","contents_url":"https://api.github.com/repos/alphagov/stagecraft/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/stagecraft/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/stagecraft/merges","archive_url":"https://api.github.com/repos/alphagov/stagecraft/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/stagecraft/downloads","issues_url":"https://api.github.com/repos/alphagov/stagecraft/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/stagecraft/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/stagecraft/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/stagecraft/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/stagecraft/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/stagecraft/releases{/id}","created_at":"2013-10-03T11:08:32Z","updated_at":"2014-09-02T17:27:05Z","pushed_at":"2014-09-17T09:58:57Z","git_url":"git://github.com/alphagov/stagecraft.git","ssh_url":"git@github.com:alphagov/stagecraft.git","clone_url":"https://github.com/alphagov/stagecraft.git","svn_url":"https://github.com/alphagov/stagecraft","homepage":"","size":10602,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":7,"forks":2,"open_issues":7,"watchers":1,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"cf4e2db15e2c36b06f21c84d919d5d2249c7e06d","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=2","gravatar_id":"5618b843830194a2475a6e48823f7455","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":13295877,"name":"stagecraft","full_name":"alphagov/stagecraft","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=2","gravatar_id":"5618b843830194a2475a6e48823f7455","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/stagecraft","description":"A configuration service for the Performance Platform","fork":false,"url":"https://api.github.com/repos/alphagov/stagecraft","forks_url":"https://api.github.com/repos/alphagov/stagecraft/forks","keys_url":"https://api.github.com/repos/alphagov/stagecraft/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/stagecraft/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/stagecraft/teams","hooks_url":"https://api.github.com/repos/alphagov/stagecraft/hooks","issue_events_url":"https://api.github.com/repos/alphagov/stagecraft/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/stagecraft/events","assignees_url":"https://api.github.com/repos/alphagov/stagecraft/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/stagecraft/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/stagecraft/tags","blobs_url":"https://api.github.com/repos/alphagov/stagecraft/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/stagecraft/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/stagecraft/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/stagecraft/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/stagecraft/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/stagecraft/languages","stargazers_url":"https://api.github.com/repos/alphagov/stagecraft/stargazers","contributors_url":"https://api.github.com/repos/alphagov/stagecraft/contributors","subscribers_url":"https://api.github.com/repos/alphagov/stagecraft/subscribers","subscription_url":"https://api.github.com/repos/alphagov/stagecraft/subscription","commits_url":"https://api.github.com/repos/alphagov/stagecraft/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/stagecraft/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/stagecraft/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/stagecraft/issues/comments/{number}","contents_url":"https://api.github.com/repos/alphagov/stagecraft/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/stagecraft/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/stagecraft/merges","archive_url":"https://api.github.com/repos/alphagov/stagecraft/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/stagecraft/downloads","issues_url":"https://api.github.com/repos/alphagov/stagecraft/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/stagecraft/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/stagecraft/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/stagecraft/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/stagecraft/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/stagecraft/releases{/id}","created_at":"2013-10-03T11:08:32Z","updated_at":"2014-09-02T17:27:05Z","pushed_at":"2014-09-17T09:58:57Z","git_url":"git://github.com/alphagov/stagecraft.git","ssh_url":"git@github.com:alphagov/stagecraft.git","clone_url":"https://github.com/alphagov/stagecraft.git","svn_url":"https://github.com/alphagov/stagecraft","homepage":"","size":10602,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":7,"forks":2,"open_issues":7,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/stagecraft/pulls/228"},"html":{"href":"https://github.com/alphagov/stagecraft/pull/228"},"issue":{"href":"https://api.github.com/repos/alphagov/stagecraft/issues/228"},"comments":{"href":"https://api.github.com/repos/alphagov/stagecraft/issues/228/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/stagecraft/pulls/228/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/stagecraft/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/alphagov/stagecraft/pulls/228/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/stagecraft/statuses/e125fef5e5d08f5630a1f3ff1fe2f2505650cac2"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jabley","id":16205,"avatar_url":"https://avatars.githubusercontent.com/u/16205?v=2","gravatar_id":"82d1ee1e5cd5fa32a7eeee2df0c44c3c","url":"https://api.github.com/users/jabley","html_url":"https://github.com/jabley","followers_url":"https://api.github.com/users/jabley/followers","following_url":"https://api.github.com/users/jabley/following{/other_user}","gists_url":"https://api.github.com/users/jabley/gists{/gist_id}","starred_url":"https://api.github.com/users/jabley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jabley/subscriptions","organizations_url":"https://api.github.com/users/jabley/orgs","repos_url":"https://api.github.com/users/jabley/repos","events_url":"https://api.github.com/users/jabley/events{/privacy}","received_events_url":"https://api.github.com/users/jabley/received_events","type":"User","site_admin":false},"comments":0,"review_comments":2,"commits":1,"additions":68,"deletions":8,"changed_files":5}}