GitHub PullRequestReviewCommentEvent at 2014-07-15 17:48:53
Repository: SocketRocket
Actor: jmkk
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/square/SocketRocket/pulls/comments/14951086","id":14951086,"diff_hunk":"@@ -41,6 +41,11 @@ extern NSString *const SRWebSocketErrorDomain;\n @property (nonatomic, readonly) SRReadyState readyState;\n @property (nonatomic, readonly, retain) NSURL *url;\n \n+// Specifies whether SSL trust chain should NOT be evaluated.\n+// By default this flag is set to NO, meaning only secure SSL connections are allowed.\n+// For DEBUG builds this flag is ignored, and connections are allowed to any root certificates.","path":"SocketRocket/SRWebSocket.h","position":6,"original_position":6,"commit_id":"a1a32d677045140835a20c4422348dac92146224","original_commit_id":"a1a32d677045140835a20c4422348dac92146224","user":{"login":"jmkk","id":3430965,"avatar_url":"https://avatars.githubusercontent.com/u/3430965?","gravatar_id":"1849447d3dddf5c1b45be8bc78123364","url":"https://api.github.com/users/jmkk","html_url":"https://github.com/jmkk","followers_url":"https://api.github.com/users/jmkk/followers","following_url":"https://api.github.com/users/jmkk/following{/other_user}","gists_url":"https://api.github.com/users/jmkk/gists{/gist_id}","starred_url":"https://api.github.com/users/jmkk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmkk/subscriptions","organizations_url":"https://api.github.com/users/jmkk/orgs","repos_url":"https://api.github.com/users/jmkk/repos","events_url":"https://api.github.com/users/jmkk/events{/privacy}","received_events_url":"https://api.github.com/users/jmkk/received_events","type":"User","site_admin":false},"body":"This is not accurate - this flag controls chain trust evaluation, not \"certificate configuration\". Expiration, key usage etc. still is checked.","created_at":"2014-07-15T17:48:53Z","updated_at":"2014-07-15T17:48:53Z","html_url":"https://github.com/square/SocketRocket/pull/137#discussion_r14951086","pull_request_url":"https://api.github.com/repos/square/SocketRocket/pulls/137","_links":{"self":{"href":"https://api.github.com/repos/square/SocketRocket/pulls/comments/14951086"},"html":{"href":"https://github.com/square/SocketRocket/pull/137#discussion_r14951086"},"pull_request":{"href":"https://api.github.com/repos/square/SocketRocket/pulls/137"}}},"pull_request":{"url":"https://api.github.com/repos/square/SocketRocket/pulls/137","id":11123506,"html_url":"https://github.com/square/SocketRocket/pull/137","diff_url":"https://github.com/square/SocketRocket/pull/137.diff","patch_url":"https://github.com/square/SocketRocket/pull/137.patch","issue_url":"https://api.github.com/repos/square/SocketRocket/issues/137","number":137,"state":"open","title":"Allow the clients to decide if validation of SSL certificates should be skipped","user":{"login":"jmkk","id":3430965,"avatar_url":"https://avatars.githubusercontent.com/u/3430965?","gravatar_id":"1849447d3dddf5c1b45be8bc78123364","url":"https://api.github.com/users/jmkk","html_url":"https://github.com/jmkk","followers_url":"https://api.github.com/users/jmkk/followers","following_url":"https://api.github.com/users/jmkk/following{/other_user}","gists_url":"https://api.github.com/users/jmkk/gists{/gist_id}","starred_url":"https://api.github.com/users/jmkk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmkk/subscriptions","organizations_url":"https://api.github.com/users/jmkk/orgs","repos_url":"https://api.github.com/users/jmkk/repos","events_url":"https://api.github.com/users/jmkk/events{/privacy}","received_events_url":"https://api.github.com/users/jmkk/received_events","type":"User","site_admin":false},"body":"Instead of just assuming that in DEBUG root certificates should not be evaluated allow the callers to decide.\r\nIn order to not break existing clients, in DEBUG evaluation still is off, but in release builds you can set the allowUntrustedSSLCertificates flag.","created_at":"2013-12-28T06:18:54Z","updated_at":"2014-07-15T17:48:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"56457f081c16ee0207ea22a9f4f7afc22df01772","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/square/SocketRocket/pulls/137/commits","review_comments_url":"https://api.github.com/repos/square/SocketRocket/pulls/137/comments","review_comment_url":"https://api.github.com/repos/square/SocketRocket/pulls/comments/{number}","comments_url":"https://api.github.com/repos/square/SocketRocket/issues/137/comments","statuses_url":"https://api.github.com/repos/square/SocketRocket/statuses/a1a32d677045140835a20c4422348dac92146224","head":{"label":"jmkk:cert-trust","ref":"cert-trust","sha":"a1a32d677045140835a20c4422348dac92146224","user":{"login":"jmkk","id":3430965,"avatar_url":"https://avatars.githubusercontent.com/u/3430965?","gravatar_id":"1849447d3dddf5c1b45be8bc78123364","url":"https://api.github.com/users/jmkk","html_url":"https://github.com/jmkk","followers_url":"https://api.github.com/users/jmkk/followers","following_url":"https://api.github.com/users/jmkk/following{/other_user}","gists_url":"https://api.github.com/users/jmkk/gists{/gist_id}","starred_url":"https://api.github.com/users/jmkk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmkk/subscriptions","organizations_url":"https://api.github.com/users/jmkk/orgs","repos_url":"https://api.github.com/users/jmkk/repos","events_url":"https://api.github.com/users/jmkk/events{/privacy}","received_events_url":"https://api.github.com/users/jmkk/received_events","type":"User","site_admin":false},"repo":{"id":15383254,"name":"SocketRocket","full_name":"jmkk/SocketRocket","owner":{"login":"jmkk","id":3430965,"avatar_url":"https://avatars.githubusercontent.com/u/3430965?","gravatar_id":"1849447d3dddf5c1b45be8bc78123364","url":"https://api.github.com/users/jmkk","html_url":"https://github.com/jmkk","followers_url":"https://api.github.com/users/jmkk/followers","following_url":"https://api.github.com/users/jmkk/following{/other_user}","gists_url":"https://api.github.com/users/jmkk/gists{/gist_id}","starred_url":"https://api.github.com/users/jmkk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmkk/subscriptions","organizations_url":"https://api.github.com/users/jmkk/orgs","repos_url":"https://api.github.com/users/jmkk/repos","events_url":"https://api.github.com/users/jmkk/events{/privacy}","received_events_url":"https://api.github.com/users/jmkk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jmkk/SocketRocket","description":"A conforming Objective-C WebSocket client library.","fork":true,"url":"https://api.github.com/repos/jmkk/SocketRocket","forks_url":"https://api.github.com/repos/jmkk/SocketRocket/forks","keys_url":"https://api.github.com/repos/jmkk/SocketRocket/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jmkk/SocketRocket/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jmkk/SocketRocket/teams","hooks_url":"https://api.github.com/repos/jmkk/SocketRocket/hooks","issue_events_url":"https://api.github.com/repos/jmkk/SocketRocket/issues/events{/number}","events_url":"https://api.github.com/repos/jmkk/SocketRocket/events","assignees_url":"https://api.github.com/repos/jmkk/SocketRocket/assignees{/user}","branches_url":"https://api.github.com/repos/jmkk/SocketRocket/branches{/branch}","tags_url":"https://api.github.com/repos/jmkk/SocketRocket/tags","blobs_url":"https://api.github.com/repos/jmkk/SocketRocket/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jmkk/SocketRocket/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jmkk/SocketRocket/git/refs{/sha}","trees_url":"https://api.github.com/repos/jmkk/SocketRocket/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jmkk/SocketRocket/statuses/{sha}","languages_url":"https://api.github.com/repos/jmkk/SocketRocket/languages","stargazers_url":"https://api.github.com/repos/jmkk/SocketRocket/stargazers","contributors_url":"https://api.github.com/repos/jmkk/SocketRocket/contributors","subscribers_url":"https://api.github.com/repos/jmkk/SocketRocket/subscribers","subscription_url":"https://api.github.com/repos/jmkk/SocketRocket/subscription","commits_url":"https://api.github.com/repos/jmkk/SocketRocket/commits{/sha}","git_commits_url":"https://api.github.com/repos/jmkk/SocketRocket/git/commits{/sha}","comments_url":"https://api.github.com/repos/jmkk/SocketRocket/comments{/number}","issue_comment_url":"https://api.github.com/repos/jmkk/SocketRocket/issues/comments/{number}","contents_url":"https://api.github.com/repos/jmkk/SocketRocket/contents/{+path}","compare_url":"https://api.github.com/repos/jmkk/SocketRocket/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jmkk/SocketRocket/merges","archive_url":"https://api.github.com/repos/jmkk/SocketRocket/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jmkk/SocketRocket/downloads","issues_url":"https://api.github.com/repos/jmkk/SocketRocket/issues{/number}","pulls_url":"https://api.github.com/repos/jmkk/SocketRocket/pulls{/number}","milestones_url":"https://api.github.com/repos/jmkk/SocketRocket/milestones{/number}","notifications_url":"https://api.github.com/repos/jmkk/SocketRocket/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jmkk/SocketRocket/labels{/name}","releases_url":"https://api.github.com/repos/jmkk/SocketRocket/releases{/id}","created_at":"2013-12-22T22:35:21Z","updated_at":"2013-12-28T06:41:36Z","pushed_at":"2014-07-15T03:07:14Z","git_url":"git://github.com/jmkk/SocketRocket.git","ssh_url":"git@github.com:jmkk/SocketRocket.git","clone_url":"https://github.com/jmkk/SocketRocket.git","svn_url":"https://github.com/jmkk/SocketRocket","homepage":"","size":2111,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"square:master","ref":"master","sha":"5271a326c9d43da83f14170ae205a1d02d613d35","user":{"login":"square","id":82592,"avatar_url":"https://avatars.githubusercontent.com/u/82592?","gravatar_id":"d87fe401b5fc9a4fc9bfd75febcab7c7","url":"https://api.github.com/users/square","html_url":"https://github.com/square","followers_url":"https://api.github.com/users/square/followers","following_url":"https://api.github.com/users/square/following{/other_user}","gists_url":"https://api.github.com/users/square/gists{/gist_id}","starred_url":"https://api.github.com/users/square/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/square/subscriptions","organizations_url":"https://api.github.com/users/square/orgs","repos_url":"https://api.github.com/users/square/repos","events_url":"https://api.github.com/users/square/events{/privacy}","received_events_url":"https://api.github.com/users/square/received_events","type":"Organization","site_admin":false},"repo":{"id":3301046,"name":"SocketRocket","full_name":"square/SocketRocket","owner":{"login":"square","id":82592,"avatar_url":"https://avatars.githubusercontent.com/u/82592?","gravatar_id":"d87fe401b5fc9a4fc9bfd75febcab7c7","url":"https://api.github.com/users/square","html_url":"https://github.com/square","followers_url":"https://api.github.com/users/square/followers","following_url":"https://api.github.com/users/square/following{/other_user}","gists_url":"https://api.github.com/users/square/gists{/gist_id}","starred_url":"https://api.github.com/users/square/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/square/subscriptions","organizations_url":"https://api.github.com/users/square/orgs","repos_url":"https://api.github.com/users/square/repos","events_url":"https://api.github.com/users/square/events{/privacy}","received_events_url":"https://api.github.com/users/square/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/square/SocketRocket","description":"A conforming Objective-C WebSocket client library.","fork":false,"url":"https://api.github.com/repos/square/SocketRocket","forks_url":"https://api.github.com/repos/square/SocketRocket/forks","keys_url":"https://api.github.com/repos/square/SocketRocket/keys{/key_id}","collaborators_url":"https://api.github.com/repos/square/SocketRocket/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/square/SocketRocket/teams","hooks_url":"https://api.github.com/repos/square/SocketRocket/hooks","issue_events_url":"https://api.github.com/repos/square/SocketRocket/issues/events{/number}","events_url":"https://api.github.com/repos/square/SocketRocket/events","assignees_url":"https://api.github.com/repos/square/SocketRocket/assignees{/user}","branches_url":"https://api.github.com/repos/square/SocketRocket/branches{/branch}","tags_url":"https://api.github.com/repos/square/SocketRocket/tags","blobs_url":"https://api.github.com/repos/square/SocketRocket/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/square/SocketRocket/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/square/SocketRocket/git/refs{/sha}","trees_url":"https://api.github.com/repos/square/SocketRocket/git/trees{/sha}","statuses_url":"https://api.github.com/repos/square/SocketRocket/statuses/{sha}","languages_url":"https://api.github.com/repos/square/SocketRocket/languages","stargazers_url":"https://api.github.com/repos/square/SocketRocket/stargazers","contributors_url":"https://api.github.com/repos/square/SocketRocket/contributors","subscribers_url":"https://api.github.com/repos/square/SocketRocket/subscribers","subscription_url":"https://api.github.com/repos/square/SocketRocket/subscription","commits_url":"https://api.github.com/repos/square/SocketRocket/commits{/sha}","git_commits_url":"https://api.github.com/repos/square/SocketRocket/git/commits{/sha}","comments_url":"https://api.github.com/repos/square/SocketRocket/comments{/number}","issue_comment_url":"https://api.github.com/repos/square/SocketRocket/issues/comments/{number}","contents_url":"https://api.github.com/repos/square/SocketRocket/contents/{+path}","compare_url":"https://api.github.com/repos/square/SocketRocket/compare/{base}...{head}","merges_url":"https://api.github.com/repos/square/SocketRocket/merges","archive_url":"https://api.github.com/repos/square/SocketRocket/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/square/SocketRocket/downloads","issues_url":"https://api.github.com/repos/square/SocketRocket/issues{/number}","pulls_url":"https://api.github.com/repos/square/SocketRocket/pulls{/number}","milestones_url":"https://api.github.com/repos/square/SocketRocket/milestones{/number}","notifications_url":"https://api.github.com/repos/square/SocketRocket/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/square/SocketRocket/labels{/name}","releases_url":"https://api.github.com/repos/square/SocketRocket/releases{/id}","created_at":"2012-01-30T00:21:34Z","updated_at":"2014-07-15T12:52:35Z","pushed_at":"2014-07-13T08:11:51Z","git_url":"git://github.com/square/SocketRocket.git","ssh_url":"git@github.com:square/SocketRocket.git","clone_url":"https://github.com/square/SocketRocket.git","svn_url":"https://github.com/square/SocketRocket","homepage":"","size":3421,"stargazers_count":2686,"watchers_count":2686,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":506,"mirror_url":null,"open_issues_count":79,"forks":506,"open_issues":79,"watchers":2686,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/square/SocketRocket/pulls/137"},"html":{"href":"https://github.com/square/SocketRocket/pull/137"},"issue":{"href":"https://api.github.com/repos/square/SocketRocket/issues/137"},"comments":{"href":"https://api.github.com/repos/square/SocketRocket/issues/137/comments"},"review_comments":{"href":"https://api.github.com/repos/square/SocketRocket/pulls/137/comments"},"review_comment":{"href":"https://api.github.com/repos/square/SocketRocket/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/square/SocketRocket/pulls/137/commits"},"statuses":{"href":"https://api.github.com/repos/square/SocketRocket/statuses/a1a32d677045140835a20c4422348dac92146224"}}}}