GitHub PullRequestEvent at 2014-12-18 20:17:18
Repository: nodehun
Actor: jtemplet
Payload: {"action":"opened","number":14,"pull_request":{"url":"https://api.github.com/repos/nathanjsweet/nodehun/pulls/14","id":26328550,"html_url":"https://github.com/nathanjsweet/nodehun/pull/14","diff_url":"https://github.com/nathanjsweet/nodehun/pull/14.diff","patch_url":"https://github.com/nathanjsweet/nodehun/pull/14.patch","issue_url":"https://api.github.com/repos/nathanjsweet/nodehun/issues/14","number":14,"state":"open","locked":false,"title":"Added 'origWord' to callback signature","user":{"login":"jtemplet","id":119441,"avatar_url":"https://avatars.githubusercontent.com/u/119441?v=3","gravatar_id":"","url":"https://api.github.com/users/jtemplet","html_url":"https://github.com/jtemplet","followers_url":"https://api.github.com/users/jtemplet/followers","following_url":"https://api.github.com/users/jtemplet/following{/other_user}","gists_url":"https://api.github.com/users/jtemplet/gists{/gist_id}","starred_url":"https://api.github.com/users/jtemplet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtemplet/subscriptions","organizations_url":"https://api.github.com/users/jtemplet/orgs","repos_url":"https://api.github.com/users/jtemplet/repos","events_url":"https://api.github.com/users/jtemplet/events{/privacy}","received_events_url":"https://api.github.com/users/jtemplet/received_events","type":"User","site_admin":false},"body":"In order to have an efficient way of knowing what word is being spellchecked (without doing closures or recursive functions) I added the \"originalWord\" to the callback signature for further processing.\r\n\r\nI tried to use closures originally but found that this was causing memory leaks. Just adding the \"originalWord\" to the callback made the spellcheck more efficient and performant.","created_at":"2014-12-18T20:17:18Z","updated_at":"2014-12-18T20:17:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nathanjsweet/nodehun/pulls/14/commits","review_comments_url":"https://api.github.com/repos/nathanjsweet/nodehun/pulls/14/comments","review_comment_url":"https://api.github.com/repos/nathanjsweet/nodehun/pulls/comments/{number}","comments_url":"https://api.github.com/repos/nathanjsweet/nodehun/issues/14/comments","statuses_url":"https://api.github.com/repos/nathanjsweet/nodehun/statuses/ac8008b407e5377ac7e1a774dbd8149aea1b94e4","head":{"label":"jtemplet:add_original_word_to_callback","ref":"add_original_word_to_callback","sha":"ac8008b407e5377ac7e1a774dbd8149aea1b94e4","user":{"login":"jtemplet","id":119441,"avatar_url":"https://avatars.githubusercontent.com/u/119441?v=3","gravatar_id":"","url":"https://api.github.com/users/jtemplet","html_url":"https://github.com/jtemplet","followers_url":"https://api.github.com/users/jtemplet/followers","following_url":"https://api.github.com/users/jtemplet/following{/other_user}","gists_url":"https://api.github.com/users/jtemplet/gists{/gist_id}","starred_url":"https://api.github.com/users/jtemplet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtemplet/subscriptions","organizations_url":"https://api.github.com/users/jtemplet/orgs","repos_url":"https://api.github.com/users/jtemplet/repos","events_url":"https://api.github.com/users/jtemplet/events{/privacy}","received_events_url":"https://api.github.com/users/jtemplet/received_events","type":"User","site_admin":false},"repo":{"id":28196778,"name":"nodehun","full_name":"jtemplet/nodehun","owner":{"login":"jtemplet","id":119441,"avatar_url":"https://avatars.githubusercontent.com/u/119441?v=3","gravatar_id":"","url":"https://api.github.com/users/jtemplet","html_url":"https://github.com/jtemplet","followers_url":"https://api.github.com/users/jtemplet/followers","following_url":"https://api.github.com/users/jtemplet/following{/other_user}","gists_url":"https://api.github.com/users/jtemplet/gists{/gist_id}","starred_url":"https://api.github.com/users/jtemplet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtemplet/subscriptions","organizations_url":"https://api.github.com/users/jtemplet/orgs","repos_url":"https://api.github.com/users/jtemplet/repos","events_url":"https://api.github.com/users/jtemplet/events{/privacy}","received_events_url":"https://api.github.com/users/jtemplet/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jtemplet/nodehun","description":"The Hunspell binding for nodejs that exposes as much of hunspell as possible and also adds new features.","fork":true,"url":"https://api.github.com/repos/jtemplet/nodehun","forks_url":"https://api.github.com/repos/jtemplet/nodehun/forks","keys_url":"https://api.github.com/repos/jtemplet/nodehun/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jtemplet/nodehun/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jtemplet/nodehun/teams","hooks_url":"https://api.github.com/repos/jtemplet/nodehun/hooks","issue_events_url":"https://api.github.com/repos/jtemplet/nodehun/issues/events{/number}","events_url":"https://api.github.com/repos/jtemplet/nodehun/events","assignees_url":"https://api.github.com/repos/jtemplet/nodehun/assignees{/user}","branches_url":"https://api.github.com/repos/jtemplet/nodehun/branches{/branch}","tags_url":"https://api.github.com/repos/jtemplet/nodehun/tags","blobs_url":"https://api.github.com/repos/jtemplet/nodehun/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jtemplet/nodehun/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jtemplet/nodehun/git/refs{/sha}","trees_url":"https://api.github.com/repos/jtemplet/nodehun/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jtemplet/nodehun/statuses/{sha}","languages_url":"https://api.github.com/repos/jtemplet/nodehun/languages","stargazers_url":"https://api.github.com/repos/jtemplet/nodehun/stargazers","contributors_url":"https://api.github.com/repos/jtemplet/nodehun/contributors","subscribers_url":"https://api.github.com/repos/jtemplet/nodehun/subscribers","subscription_url":"https://api.github.com/repos/jtemplet/nodehun/subscription","commits_url":"https://api.github.com/repos/jtemplet/nodehun/commits{/sha}","git_commits_url":"https://api.github.com/repos/jtemplet/nodehun/git/commits{/sha}","comments_url":"https://api.github.com/repos/jtemplet/nodehun/comments{/number}","issue_comment_url":"https://api.github.com/repos/jtemplet/nodehun/issues/comments/{number}","contents_url":"https://api.github.com/repos/jtemplet/nodehun/contents/{+path}","compare_url":"https://api.github.com/repos/jtemplet/nodehun/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jtemplet/nodehun/merges","archive_url":"https://api.github.com/repos/jtemplet/nodehun/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jtemplet/nodehun/downloads","issues_url":"https://api.github.com/repos/jtemplet/nodehun/issues{/number}","pulls_url":"https://api.github.com/repos/jtemplet/nodehun/pulls{/number}","milestones_url":"https://api.github.com/repos/jtemplet/nodehun/milestones{/number}","notifications_url":"https://api.github.com/repos/jtemplet/nodehun/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jtemplet/nodehun/labels{/name}","releases_url":"https://api.github.com/repos/jtemplet/nodehun/releases{/id}","created_at":"2014-12-18T18:49:40Z","updated_at":"2014-12-18T18:49:41Z","pushed_at":"2014-12-18T20:12:16Z","git_url":"git://github.com/jtemplet/nodehun.git","ssh_url":"git@github.com:jtemplet/nodehun.git","clone_url":"https://github.com/jtemplet/nodehun.git","svn_url":"https://github.com/jtemplet/nodehun","homepage":null,"size":7621,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nathanjsweet:master","ref":"master","sha":"89c71a23ef1d90ebf93c8934531d599b2420ed50","user":{"login":"nathanjsweet","id":447792,"avatar_url":"https://avatars.githubusercontent.com/u/447792?v=3","gravatar_id":"","url":"https://api.github.com/users/nathanjsweet","html_url":"https://github.com/nathanjsweet","followers_url":"https://api.github.com/users/nathanjsweet/followers","following_url":"https://api.github.com/users/nathanjsweet/following{/other_user}","gists_url":"https://api.github.com/users/nathanjsweet/gists{/gist_id}","starred_url":"https://api.github.com/users/nathanjsweet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathanjsweet/subscriptions","organizations_url":"https://api.github.com/users/nathanjsweet/orgs","repos_url":"https://api.github.com/users/nathanjsweet/repos","events_url":"https://api.github.com/users/nathanjsweet/events{/privacy}","received_events_url":"https://api.github.com/users/nathanjsweet/received_events","type":"User","site_admin":false},"repo":{"id":15714889,"name":"nodehun","full_name":"nathanjsweet/nodehun","owner":{"login":"nathanjsweet","id":447792,"avatar_url":"https://avatars.githubusercontent.com/u/447792?v=3","gravatar_id":"","url":"https://api.github.com/users/nathanjsweet","html_url":"https://github.com/nathanjsweet","followers_url":"https://api.github.com/users/nathanjsweet/followers","following_url":"https://api.github.com/users/nathanjsweet/following{/other_user}","gists_url":"https://api.github.com/users/nathanjsweet/gists{/gist_id}","starred_url":"https://api.github.com/users/nathanjsweet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathanjsweet/subscriptions","organizations_url":"https://api.github.com/users/nathanjsweet/orgs","repos_url":"https://api.github.com/users/nathanjsweet/repos","events_url":"https://api.github.com/users/nathanjsweet/events{/privacy}","received_events_url":"https://api.github.com/users/nathanjsweet/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nathanjsweet/nodehun","description":"The Hunspell binding for nodejs that exposes as much of hunspell as possible and also adds new features.","fork":false,"url":"https://api.github.com/repos/nathanjsweet/nodehun","forks_url":"https://api.github.com/repos/nathanjsweet/nodehun/forks","keys_url":"https://api.github.com/repos/nathanjsweet/nodehun/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nathanjsweet/nodehun/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nathanjsweet/nodehun/teams","hooks_url":"https://api.github.com/repos/nathanjsweet/nodehun/hooks","issue_events_url":"https://api.github.com/repos/nathanjsweet/nodehun/issues/events{/number}","events_url":"https://api.github.com/repos/nathanjsweet/nodehun/events","assignees_url":"https://api.github.com/repos/nathanjsweet/nodehun/assignees{/user}","branches_url":"https://api.github.com/repos/nathanjsweet/nodehun/branches{/branch}","tags_url":"https://api.github.com/repos/nathanjsweet/nodehun/tags","blobs_url":"https://api.github.com/repos/nathanjsweet/nodehun/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nathanjsweet/nodehun/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nathanjsweet/nodehun/git/refs{/sha}","trees_url":"https://api.github.com/repos/nathanjsweet/nodehun/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nathanjsweet/nodehun/statuses/{sha}","languages_url":"https://api.github.com/repos/nathanjsweet/nodehun/languages","stargazers_url":"https://api.github.com/repos/nathanjsweet/nodehun/stargazers","contributors_url":"https://api.github.com/repos/nathanjsweet/nodehun/contributors","subscribers_url":"https://api.github.com/repos/nathanjsweet/nodehun/subscribers","subscription_url":"https://api.github.com/repos/nathanjsweet/nodehun/subscription","commits_url":"https://api.github.com/repos/nathanjsweet/nodehun/commits{/sha}","git_commits_url":"https://api.github.com/repos/nathanjsweet/nodehun/git/commits{/sha}","comments_url":"https://api.github.com/repos/nathanjsweet/nodehun/comments{/number}","issue_comment_url":"https://api.github.com/repos/nathanjsweet/nodehun/issues/comments/{number}","contents_url":"https://api.github.com/repos/nathanjsweet/nodehun/contents/{+path}","compare_url":"https://api.github.com/repos/nathanjsweet/nodehun/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nathanjsweet/nodehun/merges","archive_url":"https://api.github.com/repos/nathanjsweet/nodehun/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nathanjsweet/nodehun/downloads","issues_url":"https://api.github.com/repos/nathanjsweet/nodehun/issues{/number}","pulls_url":"https://api.github.com/repos/nathanjsweet/nodehun/pulls{/number}","milestones_url":"https://api.github.com/repos/nathanjsweet/nodehun/milestones{/number}","notifications_url":"https://api.github.com/repos/nathanjsweet/nodehun/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nathanjsweet/nodehun/labels{/name}","releases_url":"https://api.github.com/repos/nathanjsweet/nodehun/releases{/id}","created_at":"2014-01-07T19:53:24Z","updated_at":"2014-12-08T19:12:14Z","pushed_at":"2014-10-14T03:45:00Z","git_url":"git://github.com/nathanjsweet/nodehun.git","ssh_url":"git@github.com:nathanjsweet/nodehun.git","clone_url":"https://github.com/nathanjsweet/nodehun.git","svn_url":"https://github.com/nathanjsweet/nodehun","homepage":null,"size":8044,"stargazers_count":13,"watchers_count":13,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":2,"forks":9,"open_issues":2,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nathanjsweet/nodehun/pulls/14"},"html":{"href":"https://github.com/nathanjsweet/nodehun/pull/14"},"issue":{"href":"https://api.github.com/repos/nathanjsweet/nodehun/issues/14"},"comments":{"href":"https://api.github.com/repos/nathanjsweet/nodehun/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/nathanjsweet/nodehun/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/nathanjsweet/nodehun/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/nathanjsweet/nodehun/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/nathanjsweet/nodehun/statuses/ac8008b407e5377ac7e1a774dbd8149aea1b94e4"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":73,"deletions":64,"changed_files":5}}