GitHub PushEvent at 2014-09-11 06:06:20
Repository: publisher
Actor: vinayvinay
Payload: {"shas":[["98765bfeda09e6ff607fedfa5cfed73e26ff5ade","56173d9c4ea5b30d6b19800e69d9f1e5ac7ba11f@digital.cabinet-office.gov.uk","Edition updates should have a clean changeset\n\nwww.agileplannerapp.com/boards/173808/cards/5977\n\nThis was causing \"Scheduled editions cannot be edited\"\nwhen trying to publish a scheduled edition now.\n\nThat's because an unclean changeset means we incorrectly\nidentify a change as disallowable:\n\nhttps://github.com/alphagov/govuk_content_models/blob/master/app/models/workflow.rb#L246-L249\n\n2 factors lead to an unclean changeset:\n\n1. in_beta field was unset for certain editions\n   which caused the changeset to have `in_beta_was`\n   as `nil`, and `in_beta` as false. the migration\n   takes care of setting `in_beta` for editions\n   where it is unset.\n\n2. activity attributes are inlined with the edition\n   form, so that we can change an edition and transition\n   it in one form submission. these fields become a part\n   of the changeset. this should not be required as these\n   attributes are not necessary beyond the `EditionController`.","Vinay Patel",true]],"size":1,"ref":"refs/heads/rename-publish-button-when-scheduled","head":"98765bfeda09e6ff607fedfa5cfed73e26ff5ade"}