GitHub PullRequestReviewCommentEvent at 2014-09-12 20:59:39
Repository: rashomon
Actor: hardikj
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/gwicke/rashomon/pulls/comments/17502322","id":17502322,"diff_hunk":"@@ -452,12 +426,22 @@ DB.prototype._get = function (keyspace, req, consistency, table) {\n         // Work around 'order by' bug in cassandra when using *\n         // Trying to change the natural sort order only works with a\n         // projection in 2.0.9\n-        var cachedSchema = this.schemaCache[keyspace];\n         if (cachedSchema) {\n             proj = Object.keys(cachedSchema.attributes).map(cassID).join(',');\n         }\n     }\n+\n+    // fetch  a row from \n     if (req.index) {\n+        if (!cachedSchema.secondaryIndexes[req.index]) {\n+            throw new Error(\"Index attributes is invalid\");\n+        }\n+        var newReq = {\n+            table: table,\n+            attributes: req.attributes\n+        };\n+        var newcql = this.buildGetQuery(keyspace, newReq, consistency, table);\n+        console.log(newcql);","path":"storage/cassandra/db.js","position":68,"original_position":68,"commit_id":"f034e6842fae09b5874825ef2eebb7cb40907702","original_commit_id":"f034e6842fae09b5874825ef2eebb7cb40907702","user":{"login":"hardikj","id":3114839,"avatar_url":"https://avatars.githubusercontent.com/u/3114839?v=2","gravatar_id":"e27830eeacc7287dc50548f0b192631a","url":"https://api.github.com/users/hardikj","html_url":"https://github.com/hardikj","followers_url":"https://api.github.com/users/hardikj/followers","following_url":"https://api.github.com/users/hardikj/following{/other_user}","gists_url":"https://api.github.com/users/hardikj/gists{/gist_id}","starred_url":"https://api.github.com/users/hardikj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hardikj/subscriptions","organizations_url":"https://api.github.com/users/hardikj/orgs","repos_url":"https://api.github.com/users/hardikj/repos","events_url":"https://api.github.com/users/hardikj/events{/privacy}","received_events_url":"https://api.github.com/users/hardikj/received_events","type":"User","site_admin":false},"body":"or maybe I should do thin in _get?","created_at":"2014-09-12T20:59:39Z","updated_at":"2014-09-12T20:59:39Z","html_url":"https://github.com/gwicke/rashomon/pull/9#discussion_r17502322","pull_request_url":"https://api.github.com/repos/gwicke/rashomon/pulls/9","_links":{"self":{"href":"https://api.github.com/repos/gwicke/rashomon/pulls/comments/17502322"},"html":{"href":"https://github.com/gwicke/rashomon/pull/9#discussion_r17502322"},"pull_request":{"href":"https://api.github.com/repos/gwicke/rashomon/pulls/9"}}},"pull_request":{"url":"https://api.github.com/repos/gwicke/rashomon/pulls/9","id":21176791,"html_url":"https://github.com/gwicke/rashomon/pull/9","diff_url":"https://github.com/gwicke/rashomon/pull/9.diff","patch_url":"https://github.com/gwicke/rashomon/pull/9.patch","issue_url":"https://api.github.com/repos/gwicke/rashomon/issues/9","number":9,"state":"open","locked":false,"title":"[WIP] Implement support for secondary index reads","user":{"login":"hardikj","id":3114839,"avatar_url":"https://avatars.githubusercontent.com/u/3114839?v=2","gravatar_id":"e27830eeacc7287dc50548f0b192631a","url":"https://api.github.com/users/hardikj","html_url":"https://github.com/hardikj","followers_url":"https://api.github.com/users/hardikj/followers","following_url":"https://api.github.com/users/hardikj/following{/other_user}","gists_url":"https://api.github.com/users/hardikj/gists{/gist_id}","starred_url":"https://api.github.com/users/hardikj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hardikj/subscriptions","organizations_url":"https://api.github.com/users/hardikj/orgs","repos_url":"https://api.github.com/users/hardikj/repos","events_url":"https://api.github.com/users/hardikj/events{/privacy}","received_events_url":"https://api.github.com/users/hardikj/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-09-12T20:23:14Z","updated_at":"2014-09-12T20:59:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3c6f7028f60acee97e4e45bdc32d7c2b727bc36d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/gwicke/rashomon/pulls/9/commits","review_comments_url":"https://api.github.com/repos/gwicke/rashomon/pulls/9/comments","review_comment_url":"https://api.github.com/repos/gwicke/rashomon/pulls/comments/{number}","comments_url":"https://api.github.com/repos/gwicke/rashomon/issues/9/comments","statuses_url":"https://api.github.com/repos/gwicke/rashomon/statuses/f034e6842fae09b5874825ef2eebb7cb40907702","head":{"label":"hardikj:putUpdates","ref":"putUpdates","sha":"f034e6842fae09b5874825ef2eebb7cb40907702","user":{"login":"hardikj","id":3114839,"avatar_url":"https://avatars.githubusercontent.com/u/3114839?v=2","gravatar_id":"e27830eeacc7287dc50548f0b192631a","url":"https://api.github.com/users/hardikj","html_url":"https://github.com/hardikj","followers_url":"https://api.github.com/users/hardikj/followers","following_url":"https://api.github.com/users/hardikj/following{/other_user}","gists_url":"https://api.github.com/users/hardikj/gists{/gist_id}","starred_url":"https://api.github.com/users/hardikj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hardikj/subscriptions","organizations_url":"https://api.github.com/users/hardikj/orgs","repos_url":"https://api.github.com/users/hardikj/repos","events_url":"https://api.github.com/users/hardikj/events{/privacy}","received_events_url":"https://api.github.com/users/hardikj/received_events","type":"User","site_admin":false},"repo":{"id":22700391,"name":"rashomon","full_name":"hardikj/rashomon","owner":{"login":"hardikj","id":3114839,"avatar_url":"https://avatars.githubusercontent.com/u/3114839?v=2","gravatar_id":"e27830eeacc7287dc50548f0b192631a","url":"https://api.github.com/users/hardikj","html_url":"https://github.com/hardikj","followers_url":"https://api.github.com/users/hardikj/followers","following_url":"https://api.github.com/users/hardikj/following{/other_user}","gists_url":"https://api.github.com/users/hardikj/gists{/gist_id}","starred_url":"https://api.github.com/users/hardikj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hardikj/subscriptions","organizations_url":"https://api.github.com/users/hardikj/orgs","repos_url":"https://api.github.com/users/hardikj/repos","events_url":"https://api.github.com/users/hardikj/events{/privacy}","received_events_url":"https://api.github.com/users/hardikj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hardikj/rashomon","description":"MediaWiki storage service prototype with Cassandra backend","fork":true,"url":"https://api.github.com/repos/hardikj/rashomon","forks_url":"https://api.github.com/repos/hardikj/rashomon/forks","keys_url":"https://api.github.com/repos/hardikj/rashomon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hardikj/rashomon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hardikj/rashomon/teams","hooks_url":"https://api.github.com/repos/hardikj/rashomon/hooks","issue_events_url":"https://api.github.com/repos/hardikj/rashomon/issues/events{/number}","events_url":"https://api.github.com/repos/hardikj/rashomon/events","assignees_url":"https://api.github.com/repos/hardikj/rashomon/assignees{/user}","branches_url":"https://api.github.com/repos/hardikj/rashomon/branches{/branch}","tags_url":"https://api.github.com/repos/hardikj/rashomon/tags","blobs_url":"https://api.github.com/repos/hardikj/rashomon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hardikj/rashomon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hardikj/rashomon/git/refs{/sha}","trees_url":"https://api.github.com/repos/hardikj/rashomon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hardikj/rashomon/statuses/{sha}","languages_url":"https://api.github.com/repos/hardikj/rashomon/languages","stargazers_url":"https://api.github.com/repos/hardikj/rashomon/stargazers","contributors_url":"https://api.github.com/repos/hardikj/rashomon/contributors","subscribers_url":"https://api.github.com/repos/hardikj/rashomon/subscribers","subscription_url":"https://api.github.com/repos/hardikj/rashomon/subscription","commits_url":"https://api.github.com/repos/hardikj/rashomon/commits{/sha}","git_commits_url":"https://api.github.com/repos/hardikj/rashomon/git/commits{/sha}","comments_url":"https://api.github.com/repos/hardikj/rashomon/comments{/number}","issue_comment_url":"https://api.github.com/repos/hardikj/rashomon/issues/comments/{number}","contents_url":"https://api.github.com/repos/hardikj/rashomon/contents/{+path}","compare_url":"https://api.github.com/repos/hardikj/rashomon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hardikj/rashomon/merges","archive_url":"https://api.github.com/repos/hardikj/rashomon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hardikj/rashomon/downloads","issues_url":"https://api.github.com/repos/hardikj/rashomon/issues{/number}","pulls_url":"https://api.github.com/repos/hardikj/rashomon/pulls{/number}","milestones_url":"https://api.github.com/repos/hardikj/rashomon/milestones{/number}","notifications_url":"https://api.github.com/repos/hardikj/rashomon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hardikj/rashomon/labels{/name}","releases_url":"https://api.github.com/repos/hardikj/rashomon/releases{/id}","created_at":"2014-08-06T22:29:11Z","updated_at":"2014-08-26T21:36:11Z","pushed_at":"2014-09-12T20:19:44Z","git_url":"git://github.com/hardikj/rashomon.git","ssh_url":"git@github.com:hardikj/rashomon.git","clone_url":"https://github.com/hardikj/rashomon.git","svn_url":"https://github.com/hardikj/rashomon","homepage":"","size":349,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gwicke:master","ref":"master","sha":"87b675432f796f66be6da3c06d515f6277d4b528","user":{"login":"gwicke","id":1225898,"avatar_url":"https://avatars.githubusercontent.com/u/1225898?v=2","gravatar_id":"ffb9bcad7a682c8317f6533ca61240a4","url":"https://api.github.com/users/gwicke","html_url":"https://github.com/gwicke","followers_url":"https://api.github.com/users/gwicke/followers","following_url":"https://api.github.com/users/gwicke/following{/other_user}","gists_url":"https://api.github.com/users/gwicke/gists{/gist_id}","starred_url":"https://api.github.com/users/gwicke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gwicke/subscriptions","organizations_url":"https://api.github.com/users/gwicke/orgs","repos_url":"https://api.github.com/users/gwicke/repos","events_url":"https://api.github.com/users/gwicke/events{/privacy}","received_events_url":"https://api.github.com/users/gwicke/received_events","type":"User","site_admin":false},"repo":{"id":13256940,"name":"rashomon","full_name":"gwicke/rashomon","owner":{"login":"gwicke","id":1225898,"avatar_url":"https://avatars.githubusercontent.com/u/1225898?v=2","gravatar_id":"ffb9bcad7a682c8317f6533ca61240a4","url":"https://api.github.com/users/gwicke","html_url":"https://github.com/gwicke","followers_url":"https://api.github.com/users/gwicke/followers","following_url":"https://api.github.com/users/gwicke/following{/other_user}","gists_url":"https://api.github.com/users/gwicke/gists{/gist_id}","starred_url":"https://api.github.com/users/gwicke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gwicke/subscriptions","organizations_url":"https://api.github.com/users/gwicke/orgs","repos_url":"https://api.github.com/users/gwicke/repos","events_url":"https://api.github.com/users/gwicke/events{/privacy}","received_events_url":"https://api.github.com/users/gwicke/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gwicke/rashomon","description":"MediaWiki storage service prototype with Cassandra backend","fork":false,"url":"https://api.github.com/repos/gwicke/rashomon","forks_url":"https://api.github.com/repos/gwicke/rashomon/forks","keys_url":"https://api.github.com/repos/gwicke/rashomon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gwicke/rashomon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gwicke/rashomon/teams","hooks_url":"https://api.github.com/repos/gwicke/rashomon/hooks","issue_events_url":"https://api.github.com/repos/gwicke/rashomon/issues/events{/number}","events_url":"https://api.github.com/repos/gwicke/rashomon/events","assignees_url":"https://api.github.com/repos/gwicke/rashomon/assignees{/user}","branches_url":"https://api.github.com/repos/gwicke/rashomon/branches{/branch}","tags_url":"https://api.github.com/repos/gwicke/rashomon/tags","blobs_url":"https://api.github.com/repos/gwicke/rashomon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gwicke/rashomon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gwicke/rashomon/git/refs{/sha}","trees_url":"https://api.github.com/repos/gwicke/rashomon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gwicke/rashomon/statuses/{sha}","languages_url":"https://api.github.com/repos/gwicke/rashomon/languages","stargazers_url":"https://api.github.com/repos/gwicke/rashomon/stargazers","contributors_url":"https://api.github.com/repos/gwicke/rashomon/contributors","subscribers_url":"https://api.github.com/repos/gwicke/rashomon/subscribers","subscription_url":"https://api.github.com/repos/gwicke/rashomon/subscription","commits_url":"https://api.github.com/repos/gwicke/rashomon/commits{/sha}","git_commits_url":"https://api.github.com/repos/gwicke/rashomon/git/commits{/sha}","comments_url":"https://api.github.com/repos/gwicke/rashomon/comments{/number}","issue_comment_url":"https://api.github.com/repos/gwicke/rashomon/issues/comments/{number}","contents_url":"https://api.github.com/repos/gwicke/rashomon/contents/{+path}","compare_url":"https://api.github.com/repos/gwicke/rashomon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gwicke/rashomon/merges","archive_url":"https://api.github.com/repos/gwicke/rashomon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gwicke/rashomon/downloads","issues_url":"https://api.github.com/repos/gwicke/rashomon/issues{/number}","pulls_url":"https://api.github.com/repos/gwicke/rashomon/pulls{/number}","milestones_url":"https://api.github.com/repos/gwicke/rashomon/milestones{/number}","notifications_url":"https://api.github.com/repos/gwicke/rashomon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gwicke/rashomon/labels{/name}","releases_url":"https://api.github.com/repos/gwicke/rashomon/releases{/id}","created_at":"2013-10-01T22:03:02Z","updated_at":"2014-09-02T15:26:52Z","pushed_at":"2014-09-12T19:36:43Z","git_url":"git://github.com/gwicke/rashomon.git","ssh_url":"git@github.com:gwicke/rashomon.git","clone_url":"https://github.com/gwicke/rashomon.git","svn_url":"https://github.com/gwicke/rashomon","homepage":"","size":977,"stargazers_count":6,"watchers_count":6,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":4,"mirror_url":null,"open_issues_count":1,"forks":4,"open_issues":1,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gwicke/rashomon/pulls/9"},"html":{"href":"https://github.com/gwicke/rashomon/pull/9"},"issue":{"href":"https://api.github.com/repos/gwicke/rashomon/issues/9"},"comments":{"href":"https://api.github.com/repos/gwicke/rashomon/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/gwicke/rashomon/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/gwicke/rashomon/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/gwicke/rashomon/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/gwicke/rashomon/statuses/f034e6842fae09b5874825ef2eebb7cb40907702"}}}}