GitHub PullRequestReviewCommentEvent at 2014-05-05 20:27:07
Repository: qa-tools
Actor: aik099
Payload: {"comment":{"url":"https://api.github.com/repos/aik099/qa-tools/pulls/comments/12297785","id":12297785,"diff_hunk":"@@ -102,16 +153,21 @@ public function testOpenIncorrect()\n \t/**\n \t * Tests if params are correctly added to the URL.\n \t *\n-\t * @param string $url      The target url.\n \t * @param string $expected The expected merged url.\n \t * @param array  $params   The GET params.\n \t *\n \t * @dataProvider getAbsoluteUrlWithParamsDataProvider\n \t * @return void\n \t */\n-\tpublic function testGetAbsoluteUrlWithParams($url, $expected, array $params)\n+\tpublic function testGetAbsoluteUrlWithParams($expected, array $params)\n \t{\n-\t\t$this->page->relativeUrl = $url;\n+\t\t/* @var IUrlBuilder $urlBuilder */\n+\t\t$urlBuilder = m::mock(self::URL_BUILDER_CLASS);\n+\n+\t\t$urlBuilder->shouldReceive('build')->with($params)->andReturn($expected);\n+\n+\t\t$this->page->setUrlBuilder($urlBuilder);","path":"tests/aik099/QATools/PageObject/PageTest.php","position":127,"original_position":127,"commit_id":"45f87a9550dcf4509d3faae1abb5c0b7dd6ff5c7","original_commit_id":"45f87a9550dcf4509d3faae1abb5c0b7dd6ff5c7","user":{"login":"aik099","id":1277526,"avatar_url":"https://avatars.githubusercontent.com/u/1277526?","gravatar_id":"027e03406c7dfd1dd54dc944b0745d2f","url":"https://api.github.com/users/aik099","html_url":"https://github.com/aik099","followers_url":"https://api.github.com/users/aik099/followers","following_url":"https://api.github.com/users/aik099/following{/other_user}","gists_url":"https://api.github.com/users/aik099/gists{/gist_id}","starred_url":"https://api.github.com/users/aik099/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aik099/subscriptions","organizations_url":"https://api.github.com/users/aik099/orgs","repos_url":"https://api.github.com/users/aik099/repos","events_url":"https://api.github.com/users/aik099/events{/privacy}","received_events_url":"https://api.github.com/users/aik099/received_events","type":"User","site_admin":false},"body":"The `setUrlBuilder` method return value is never asserted.","created_at":"2014-05-05T20:27:07Z","updated_at":"2014-05-05T20:27:07Z","html_url":"https://github.com/aik099/qa-tools/pull/31#discussion_r12297785","pull_request_url":"https://api.github.com/repos/aik099/qa-tools/pulls/31","_links":{"self":{"href":"https://api.github.com/repos/aik099/qa-tools/pulls/comments/12297785"},"html":{"href":"https://github.com/aik099/qa-tools/pull/31#discussion_r12297785"},"pull_request":{"href":"https://api.github.com/repos/aik099/qa-tools/pulls/31"}}}}