GitHub PullRequestReviewCommentEvent at 2014-08-21 19:46:14
Repository: confluence-publisher-plugin
Actor: jhansche
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/jenkinsci/confluence-publisher-plugin/pulls/comments/16562806","id":16562806,"diff_hunk":"@@ -427,15 +439,17 @@ public boolean perform(AbstractBuild<?, ?> build, Launcher launcher, BuildListen\n      * @return The resulting Page\n      * @throws RemoteException\n      */\n-    private RemotePage createPage(ConfluenceSession confluence, String spaceName, String pageName)\n+    private RemotePage createPage(ConfluenceSession confluence, String spaceName, String pageName, long parentId)\n             throws RemoteException {\n         RemotePage newPage = new RemotePage();\n         newPage.setTitle(pageName);\n         newPage.setSpace(spaceName);\n         newPage.setContent(\"\");\n+        newPage.setParentId(parentId);","path":"src/main/java/com/myyearbook/hudson/plugins/confluence/ConfluencePublisher.java","position":83,"original_position":83,"commit_id":"142e9197962fc012d0ae8c085120c6576160d488","original_commit_id":"142e9197962fc012d0ae8c085120c6576160d488","user":{"login":"jhansche","id":99272,"avatar_url":"https://avatars.githubusercontent.com/u/99272?v=2","gravatar_id":"8ca00674d2c82c799c42cdce136bfd23","url":"https://api.github.com/users/jhansche","html_url":"https://github.com/jhansche","followers_url":"https://api.github.com/users/jhansche/followers","following_url":"https://api.github.com/users/jhansche/following{/other_user}","gists_url":"https://api.github.com/users/jhansche/gists{/gist_id}","starred_url":"https://api.github.com/users/jhansche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhansche/subscriptions","organizations_url":"https://api.github.com/users/jhansche/orgs","repos_url":"https://api.github.com/users/jhansche/repos","events_url":"https://api.github.com/users/jhansche/events{/privacy}","received_events_url":"https://api.github.com/users/jhansche/received_events","type":"User","site_admin":false},"body":"If it is not entered, the configuration will be saved as `0L`.  Need to be sure that `setParentId(0L)` is an acceptable state (i.e., Confluence may accept that and treat it as default:  but we need to be sure that that is truly what happens).  If `setParentId(0L)` raises an error from Confluence, then this line needs to be conditional on `parentId > 0L`.","created_at":"2014-08-21T19:46:14Z","updated_at":"2014-08-21T19:46:14Z","html_url":"https://github.com/jenkinsci/confluence-publisher-plugin/pull/7#discussion_r16562806","pull_request_url":"https://api.github.com/repos/jenkinsci/confluence-publisher-plugin/pulls/7","_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/confluence-publisher-plugin/pulls/comments/16562806"},"html":{"href":"https://github.com/jenkinsci/confluence-publisher-plugin/pull/7#discussion_r16562806"},"pull_request":{"href":"https://api.github.com/repos/jenkinsci/confluence-publisher-plugin/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/jenkinsci/confluence-publisher-plugin/pulls/7","id":20131322,"html_url":"https://github.com/jenkinsci/confluence-publisher-plugin/pull/7","diff_url":"https://github.com/jenkinsci/confluence-publisher-plugin/pull/7.diff","patch_url":"https://github.com/jenkinsci/confluence-publisher-plugin/pull/7.patch","issue_url":"https://api.github.com/repos/jenkinsci/confluence-publisher-plugin/issues/7","number":7,"state":"open","locked":false,"title":"[FIXED JENKINS-15472] Added parentId property","user":{"login":"trevor-hill","id":8516803,"avatar_url":"https://avatars.githubusercontent.com/u/8516803?v=2","gravatar_id":"2e66255ee62aedc17d81f57a65f0cb19","url":"https://api.github.com/users/trevor-hill","html_url":"https://github.com/trevor-hill","followers_url":"https://api.github.com/users/trevor-hill/followers","following_url":"https://api.github.com/users/trevor-hill/following{/other_user}","gists_url":"https://api.github.com/users/trevor-hill/gists{/gist_id}","starred_url":"https://api.github.com/users/trevor-hill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trevor-hill/subscriptions","organizations_url":"https://api.github.com/users/trevor-hill/orgs","repos_url":"https://api.github.com/users/trevor-hill/repos","events_url":"https://api.github.com/users/trevor-hill/events{/privacy}","received_events_url":"https://api.github.com/users/trevor-hill/received_events","type":"User","site_admin":false},"body":"Added a new job-configuration field for parent page ID#.\r\nPlugin verifies that page ID exists and returns an error message if not.","created_at":"2014-08-21T19:20:42Z","updated_at":"2014-08-21T19:46:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"362f4ff27cd88ed42834d821cb1274cc2e21bc30","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jenkinsci/confluence-publisher-plugin/pulls/7/commits","review_comments_url":"https://api.github.com/repos/jenkinsci/confluence-publisher-plugin/pulls/7/comments","review_comment_url":"https://api.github.com/repos/jenkinsci/confluence-publisher-plugin/pulls/comments/{number}","comments_url":"https://api.github.com/repos/jenkinsci/confluence-publisher-plugin/issues/7/comments","statuses_url":"https://api.github.com/repos/jenkinsci/confluence-publisher-plugin/statuses/142e9197962fc012d0ae8c085120c6576160d488","head":{"label":"trevor-hill:master","ref":"master","sha":"142e9197962fc012d0ae8c085120c6576160d488","user":{"login":"trevor-hill","id":8516803,"avatar_url":"https://avatars.githubusercontent.com/u/8516803?v=2","gravatar_id":"2e66255ee62aedc17d81f57a65f0cb19","url":"https://api.github.com/users/trevor-hill","html_url":"https://github.com/trevor-hill","followers_url":"https://api.github.com/users/trevor-hill/followers","following_url":"https://api.github.com/users/trevor-hill/following{/other_user}","gists_url":"https://api.github.com/users/trevor-hill/gists{/gist_id}","starred_url":"https://api.github.com/users/trevor-hill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trevor-hill/subscriptions","organizations_url":"https://api.github.com/users/trevor-hill/orgs","repos_url":"https://api.github.com/users/trevor-hill/repos","events_url":"https://api.github.com/users/trevor-hill/events{/privacy}","received_events_url":"https://api.github.com/users/trevor-hill/received_events","type":"User","site_admin":false},"repo":{"id":23199820,"name":"confluence-publisher-plugin","full_name":"trevor-hill/confluence-publisher-plugin","owner":{"login":"trevor-hill","id":8516803,"avatar_url":"https://avatars.githubusercontent.com/u/8516803?v=2","gravatar_id":"2e66255ee62aedc17d81f57a65f0cb19","url":"https://api.github.com/users/trevor-hill","html_url":"https://github.com/trevor-hill","followers_url":"https://api.github.com/users/trevor-hill/followers","following_url":"https://api.github.com/users/trevor-hill/following{/other_user}","gists_url":"https://api.github.com/users/trevor-hill/gists{/gist_id}","starred_url":"https://api.github.com/users/trevor-hill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trevor-hill/subscriptions","organizations_url":"https://api.github.com/users/trevor-hill/orgs","repos_url":"https://api.github.com/users/trevor-hill/repos","events_url":"https://api.github.com/users/trevor-hill/events{/privacy}","received_events_url":"https://api.github.com/users/trevor-hill/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/trevor-hill/confluence-publisher-plugin","description":"Jenkins Plugin to publish artifacts to Atlassian Confluence","fork":true,"url":"https://api.github.com/repos/trevor-hill/confluence-publisher-plugin","forks_url":"https://api.github.com/repos/trevor-hill/confluence-publisher-plugin/forks","keys_url":"https://api.github.com/repos/trevor-hill/confluence-publisher-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trevor-hill/confluence-publisher-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trevor-hill/confluence-publisher-plugin/teams","hooks_url":"https://api.github.com/repos/trevor-hill/confluence-publisher-plugin/hooks","issue_events_url":"https://api.github.com/repos/trevor-hill/confluence-publisher-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/trevor-hill/confluence-publisher-plugin/events","assignees_url":"https://api.github.com/repos/trevor-hill/confluence-publisher-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/trevor-hill/confluence-publisher-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/trevor-hill/confluence-publisher-plugin/tags","blobs_url":"https://api.github.com/repos/trevor-hill/confluence-publisher-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trevor-hill/confluence-publisher-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trevor-hill/confluence-publisher-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/trevor-hill/confluence-publisher-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trevor-hill/confluence-publisher-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/trevor-hill/confluence-publisher-plugin/languages","stargazers_url":"https://api.github.com/repos/trevor-hill/confluence-publisher-plugin/stargazers","contributors_url":"https://api.github.com/repos/trevor-hill/confluence-publisher-plugin/contributors","subscribers_url":"https://api.github.com/repos/trevor-hill/confluence-publisher-plugin/subscribers","subscription_url":"https://api.github.com/repos/trevor-hill/confluence-publisher-plugin/subscription","commits_url":"https://api.github.com/repos/trevor-hill/confluence-publisher-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/trevor-hill/confluence-publisher-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/trevor-hill/confluence-publisher-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/trevor-hill/confluence-publisher-plugin/issues/comments/{number}","contents_url":"https://api.github.com/repos/trevor-hill/confluence-publisher-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/trevor-hill/confluence-publisher-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trevor-hill/confluence-publisher-plugin/merges","archive_url":"https://api.github.com/repos/trevor-hill/confluence-publisher-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trevor-hill/confluence-publisher-plugin/downloads","issues_url":"https://api.github.com/repos/trevor-hill/confluence-publisher-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/trevor-hill/confluence-publisher-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/trevor-hill/confluence-publisher-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/trevor-hill/confluence-publisher-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trevor-hill/confluence-publisher-plugin/labels{/name}","releases_url":"https://api.github.com/repos/trevor-hill/confluence-publisher-plugin/releases{/id}","created_at":"2014-08-21T19:17:21Z","updated_at":"2014-08-21T19:19:45Z","pushed_at":"2014-08-21T19:19:45Z","git_url":"git://github.com/trevor-hill/confluence-publisher-plugin.git","ssh_url":"git@github.com:trevor-hill/confluence-publisher-plugin.git","clone_url":"https://github.com/trevor-hill/confluence-publisher-plugin.git","svn_url":"https://github.com/trevor-hill/confluence-publisher-plugin","homepage":"","size":468,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jenkinsci:master","ref":"master","sha":"d7e9c4f4a48d396b5c51e0413b8537087dc08860","user":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=2","gravatar_id":"ceb204ad3216b4594ba32364def06deb","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"repo":{"id":1399074,"name":"confluence-publisher-plugin","full_name":"jenkinsci/confluence-publisher-plugin","owner":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=2","gravatar_id":"ceb204ad3216b4594ba32364def06deb","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jenkinsci/confluence-publisher-plugin","description":"Jenkins Plugin to publish artifacts to Atlassian Confluence","fork":true,"url":"https://api.github.com/repos/jenkinsci/confluence-publisher-plugin","forks_url":"https://api.github.com/repos/jenkinsci/confluence-publisher-plugin/forks","keys_url":"https://api.github.com/repos/jenkinsci/confluence-publisher-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenkinsci/confluence-publisher-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenkinsci/confluence-publisher-plugin/teams","hooks_url":"https://api.github.com/repos/jenkinsci/confluence-publisher-plugin/hooks","issue_events_url":"https://api.github.com/repos/jenkinsci/confluence-publisher-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/jenkinsci/confluence-publisher-plugin/events","assignees_url":"https://api.github.com/repos/jenkinsci/confluence-publisher-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/jenkinsci/confluence-publisher-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/jenkinsci/confluence-publisher-plugin/tags","blobs_url":"https://api.github.com/repos/jenkinsci/confluence-publisher-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenkinsci/confluence-publisher-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenkinsci/confluence-publisher-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenkinsci/confluence-publisher-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenkinsci/confluence-publisher-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/jenkinsci/confluence-publisher-plugin/languages","stargazers_url":"https://api.github.com/repos/jenkinsci/confluence-publisher-plugin/stargazers","contributors_url":"https://api.github.com/repos/jenkinsci/confluence-publisher-plugin/contributors","subscribers_url":"https://api.github.com/repos/jenkinsci/confluence-publisher-plugin/subscribers","subscription_url":"https://api.github.com/repos/jenkinsci/confluence-publisher-plugin/subscription","commits_url":"https://api.github.com/repos/jenkinsci/confluence-publisher-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenkinsci/confluence-publisher-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenkinsci/confluence-publisher-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenkinsci/confluence-publisher-plugin/issues/comments/{number}","contents_url":"https://api.github.com/repos/jenkinsci/confluence-publisher-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/jenkinsci/confluence-publisher-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenkinsci/confluence-publisher-plugin/merges","archive_url":"https://api.github.com/repos/jenkinsci/confluence-publisher-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenkinsci/confluence-publisher-plugin/downloads","issues_url":"https://api.github.com/repos/jenkinsci/confluence-publisher-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/jenkinsci/confluence-publisher-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/jenkinsci/confluence-publisher-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/jenkinsci/confluence-publisher-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenkinsci/confluence-publisher-plugin/labels{/name}","releases_url":"https://api.github.com/repos/jenkinsci/confluence-publisher-plugin/releases{/id}","created_at":"2011-02-22T19:47:44Z","updated_at":"2014-02-03T16:03:01Z","pushed_at":"2014-02-03T16:03:00Z","git_url":"git://github.com/jenkinsci/confluence-publisher-plugin.git","ssh_url":"git@github.com:jenkinsci/confluence-publisher-plugin.git","clone_url":"https://github.com/jenkinsci/confluence-publisher-plugin.git","svn_url":"https://github.com/jenkinsci/confluence-publisher-plugin","homepage":"","size":468,"stargazers_count":8,"watchers_count":8,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":15,"mirror_url":null,"open_issues_count":1,"forks":15,"open_issues":1,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/confluence-publisher-plugin/pulls/7"},"html":{"href":"https://github.com/jenkinsci/confluence-publisher-plugin/pull/7"},"issue":{"href":"https://api.github.com/repos/jenkinsci/confluence-publisher-plugin/issues/7"},"comments":{"href":"https://api.github.com/repos/jenkinsci/confluence-publisher-plugin/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/jenkinsci/confluence-publisher-plugin/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/jenkinsci/confluence-publisher-plugin/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/jenkinsci/confluence-publisher-plugin/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/jenkinsci/confluence-publisher-plugin/statuses/142e9197962fc012d0ae8c085120c6576160d488"}}}}