GitHub PullRequestReviewCommentEvent at 2014-06-11 19:31:51
Repository: hubot
Actor: technicalpickles
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/github/hubot/pulls/comments/13669208","id":13669208,"diff_hunk":"@@ -323,7 +323,10 @@ class Robot\n       path = if adapter in HUBOT_DEFAULT_ADAPTERS\n         \"#{path}/#{adapter}\"\n       else\n-        \"hubot-#{adapter}\"\n+        if path.indexOf(\"/\") == 0\n+          \"#{path}/#{adapter}\"","path":"src/robot.coffee","position":6,"original_position":6,"commit_id":"aa209f1c8ef4673d316118cb70b5e6b867b429a1","original_commit_id":"aa209f1c8ef4673d316118cb70b5e6b867b429a1","user":{"login":"technicalpickles","id":159,"avatar_url":"https://avatars.githubusercontent.com/u/159?","gravatar_id":"1c1aabc1abed5cce37b192dd00f0f28c","url":"https://api.github.com/users/technicalpickles","html_url":"https://github.com/technicalpickles","followers_url":"https://api.github.com/users/technicalpickles/followers","following_url":"https://api.github.com/users/technicalpickles/following{/other_user}","gists_url":"https://api.github.com/users/technicalpickles/gists{/gist_id}","starred_url":"https://api.github.com/users/technicalpickles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/technicalpickles/subscriptions","organizations_url":"https://api.github.com/users/technicalpickles/orgs","repos_url":"https://api.github.com/users/technicalpickles/repos","events_url":"https://api.github.com/users/technicalpickles/events{/privacy}","received_events_url":"https://api.github.com/users/technicalpickles/received_events","type":"User","site_admin":true},"body":"Shouldn't this just be `adapter`? If I'm reading it correctly, the `path` here would be https://github.com/github/hubot/blob/master/bin/hubot#L73 (which gets passed to https://github.com/github/hubot/blob/master/bin/hubot#L75 which gets passed to https://github.com/github/hubot/blob/master/src/robot.coffee#L59 which gets passed to this method).\r\n\r\nA better check might be if `adapter` is a directory that exists.","created_at":"2014-06-11T19:31:51Z","updated_at":"2014-06-11T19:31:51Z","html_url":"https://github.com/github/hubot/pull/709#discussion_r13669208","pull_request_url":"https://api.github.com/repos/github/hubot/pulls/709","_links":{"self":{"href":"https://api.github.com/repos/github/hubot/pulls/comments/13669208"},"html":{"href":"https://github.com/github/hubot/pull/709#discussion_r13669208"},"pull_request":{"href":"https://api.github.com/repos/github/hubot/pulls/709"}}},"pull_request":{"url":"https://api.github.com/repos/github/hubot/pulls/709","id":16690681,"html_url":"https://github.com/github/hubot/pull/709","diff_url":"https://github.com/github/hubot/pull/709.diff","patch_url":"https://github.com/github/hubot/pull/709.patch","issue_url":"https://api.github.com/repos/github/hubot/issues/709","number":709,"state":"open","title":"Allow for absolute pathing to adapters for testing","user":{"login":"atmos","id":38,"avatar_url":"https://avatars.githubusercontent.com/u/38?","gravatar_id":"a86224d72ce21cd9f5bee6784d4b06c7","url":"https://api.github.com/users/atmos","html_url":"https://github.com/atmos","followers_url":"https://api.github.com/users/atmos/followers","following_url":"https://api.github.com/users/atmos/following{/other_user}","gists_url":"https://api.github.com/users/atmos/gists{/gist_id}","starred_url":"https://api.github.com/users/atmos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atmos/subscriptions","organizations_url":"https://api.github.com/users/atmos/orgs","repos_url":"https://api.github.com/users/atmos/repos","events_url":"https://api.github.com/users/atmos/events{/privacy}","received_events_url":"https://api.github.com/users/atmos/received_events","type":"User","site_admin":true},"body":"I've been writing my own test adapters in separate hubot-scripts. The only way to bang on an adapter is to make it a separate npm package or drop it in hubot. This allows for full paths to adapters to be loaded.","created_at":"2014-06-04T04:11:50Z","updated_at":"2014-06-11T19:31:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"137e3df524fb0a9ea00b4fa3d4af69f5276783ec","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/github/hubot/pulls/709/commits","review_comments_url":"https://api.github.com/repos/github/hubot/pulls/709/comments","review_comment_url":"https://api.github.com/repos/github/hubot/pulls/comments/{number}","comments_url":"https://api.github.com/repos/github/hubot/issues/709/comments","statuses_url":"https://api.github.com/repos/github/hubot/statuses/aa209f1c8ef4673d316118cb70b5e6b867b429a1","head":{"label":"github:full-path-to-adapters","ref":"full-path-to-adapters","sha":"aa209f1c8ef4673d316118cb70b5e6b867b429a1","user":{"login":"github","id":9919,"avatar_url":"https://avatars.githubusercontent.com/u/9919?","gravatar_id":"61024896f291303615bcd4f7a0dcfb74","url":"https://api.github.com/users/github","html_url":"https://github.com/github","followers_url":"https://api.github.com/users/github/followers","following_url":"https://api.github.com/users/github/following{/other_user}","gists_url":"https://api.github.com/users/github/gists{/gist_id}","starred_url":"https://api.github.com/users/github/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/github/subscriptions","organizations_url":"https://api.github.com/users/github/orgs","repos_url":"https://api.github.com/users/github/repos","events_url":"https://api.github.com/users/github/events{/privacy}","received_events_url":"https://api.github.com/users/github/received_events","type":"Organization","site_admin":false},"repo":{"id":2278524,"name":"hubot","full_name":"github/hubot","owner":{"login":"github","id":9919,"avatar_url":"https://avatars.githubusercontent.com/u/9919?","gravatar_id":"61024896f291303615bcd4f7a0dcfb74","url":"https://api.github.com/users/github","html_url":"https://github.com/github","followers_url":"https://api.github.com/users/github/followers","following_url":"https://api.github.com/users/github/following{/other_user}","gists_url":"https://api.github.com/users/github/gists{/gist_id}","starred_url":"https://api.github.com/users/github/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/github/subscriptions","organizations_url":"https://api.github.com/users/github/orgs","repos_url":"https://api.github.com/users/github/repos","events_url":"https://api.github.com/users/github/events{/privacy}","received_events_url":"https://api.github.com/users/github/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/github/hubot","description":"A customizable, kegerator-powered life embetterment robot.","fork":false,"url":"https://api.github.com/repos/github/hubot","forks_url":"https://api.github.com/repos/github/hubot/forks","keys_url":"https://api.github.com/repos/github/hubot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/github/hubot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/github/hubot/teams","hooks_url":"https://api.github.com/repos/github/hubot/hooks","issue_events_url":"https://api.github.com/repos/github/hubot/issues/events{/number}","events_url":"https://api.github.com/repos/github/hubot/events","assignees_url":"https://api.github.com/repos/github/hubot/assignees{/user}","branches_url":"https://api.github.com/repos/github/hubot/branches{/branch}","tags_url":"https://api.github.com/repos/github/hubot/tags","blobs_url":"https://api.github.com/repos/github/hubot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/github/hubot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/github/hubot/git/refs{/sha}","trees_url":"https://api.github.com/repos/github/hubot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/github/hubot/statuses/{sha}","languages_url":"https://api.github.com/repos/github/hubot/languages","stargazers_url":"https://api.github.com/repos/github/hubot/stargazers","contributors_url":"https://api.github.com/repos/github/hubot/contributors","subscribers_url":"https://api.github.com/repos/github/hubot/subscribers","subscription_url":"https://api.github.com/repos/github/hubot/subscription","commits_url":"https://api.github.com/repos/github/hubot/commits{/sha}","git_commits_url":"https://api.github.com/repos/github/hubot/git/commits{/sha}","comments_url":"https://api.github.com/repos/github/hubot/comments{/number}","issue_comment_url":"https://api.github.com/repos/github/hubot/issues/comments/{number}","contents_url":"https://api.github.com/repos/github/hubot/contents/{+path}","compare_url":"https://api.github.com/repos/github/hubot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/github/hubot/merges","archive_url":"https://api.github.com/repos/github/hubot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/github/hubot/downloads","issues_url":"https://api.github.com/repos/github/hubot/issues{/number}","pulls_url":"https://api.github.com/repos/github/hubot/pulls{/number}","milestones_url":"https://api.github.com/repos/github/hubot/milestones{/number}","notifications_url":"https://api.github.com/repos/github/hubot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/github/hubot/labels{/name}","releases_url":"https://api.github.com/repos/github/hubot/releases{/id}","created_at":"2011-08-27T08:30:59Z","updated_at":"2014-06-11T18:19:38Z","pushed_at":"2014-06-10T18:28:27Z","git_url":"git://github.com/github/hubot.git","ssh_url":"git@github.com:github/hubot.git","clone_url":"https://github.com/github/hubot.git","svn_url":"https://github.com/github/hubot","homepage":"http://hubot.github.com","size":8226,"stargazers_count":5921,"watchers_count":5921,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":1312,"mirror_url":null,"open_issues_count":46,"forks":1312,"open_issues":46,"watchers":5921,"default_branch":"master"}},"base":{"label":"github:master","ref":"master","sha":"2d3a8eee86df27446177a4c4254b71eb109a472c","user":{"login":"github","id":9919,"avatar_url":"https://avatars.githubusercontent.com/u/9919?","gravatar_id":"61024896f291303615bcd4f7a0dcfb74","url":"https://api.github.com/users/github","html_url":"https://github.com/github","followers_url":"https://api.github.com/users/github/followers","following_url":"https://api.github.com/users/github/following{/other_user}","gists_url":"https://api.github.com/users/github/gists{/gist_id}","starred_url":"https://api.github.com/users/github/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/github/subscriptions","organizations_url":"https://api.github.com/users/github/orgs","repos_url":"https://api.github.com/users/github/repos","events_url":"https://api.github.com/users/github/events{/privacy}","received_events_url":"https://api.github.com/users/github/received_events","type":"Organization","site_admin":false},"repo":{"id":2278524,"name":"hubot","full_name":"github/hubot","owner":{"login":"github","id":9919,"avatar_url":"https://avatars.githubusercontent.com/u/9919?","gravatar_id":"61024896f291303615bcd4f7a0dcfb74","url":"https://api.github.com/users/github","html_url":"https://github.com/github","followers_url":"https://api.github.com/users/github/followers","following_url":"https://api.github.com/users/github/following{/other_user}","gists_url":"https://api.github.com/users/github/gists{/gist_id}","starred_url":"https://api.github.com/users/github/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/github/subscriptions","organizations_url":"https://api.github.com/users/github/orgs","repos_url":"https://api.github.com/users/github/repos","events_url":"https://api.github.com/users/github/events{/privacy}","received_events_url":"https://api.github.com/users/github/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/github/hubot","description":"A customizable, kegerator-powered life embetterment robot.","fork":false,"url":"https://api.github.com/repos/github/hubot","forks_url":"https://api.github.com/repos/github/hubot/forks","keys_url":"https://api.github.com/repos/github/hubot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/github/hubot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/github/hubot/teams","hooks_url":"https://api.github.com/repos/github/hubot/hooks","issue_events_url":"https://api.github.com/repos/github/hubot/issues/events{/number}","events_url":"https://api.github.com/repos/github/hubot/events","assignees_url":"https://api.github.com/repos/github/hubot/assignees{/user}","branches_url":"https://api.github.com/repos/github/hubot/branches{/branch}","tags_url":"https://api.github.com/repos/github/hubot/tags","blobs_url":"https://api.github.com/repos/github/hubot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/github/hubot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/github/hubot/git/refs{/sha}","trees_url":"https://api.github.com/repos/github/hubot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/github/hubot/statuses/{sha}","languages_url":"https://api.github.com/repos/github/hubot/languages","stargazers_url":"https://api.github.com/repos/github/hubot/stargazers","contributors_url":"https://api.github.com/repos/github/hubot/contributors","subscribers_url":"https://api.github.com/repos/github/hubot/subscribers","subscription_url":"https://api.github.com/repos/github/hubot/subscription","commits_url":"https://api.github.com/repos/github/hubot/commits{/sha}","git_commits_url":"https://api.github.com/repos/github/hubot/git/commits{/sha}","comments_url":"https://api.github.com/repos/github/hubot/comments{/number}","issue_comment_url":"https://api.github.com/repos/github/hubot/issues/comments/{number}","contents_url":"https://api.github.com/repos/github/hubot/contents/{+path}","compare_url":"https://api.github.com/repos/github/hubot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/github/hubot/merges","archive_url":"https://api.github.com/repos/github/hubot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/github/hubot/downloads","issues_url":"https://api.github.com/repos/github/hubot/issues{/number}","pulls_url":"https://api.github.com/repos/github/hubot/pulls{/number}","milestones_url":"https://api.github.com/repos/github/hubot/milestones{/number}","notifications_url":"https://api.github.com/repos/github/hubot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/github/hubot/labels{/name}","releases_url":"https://api.github.com/repos/github/hubot/releases{/id}","created_at":"2011-08-27T08:30:59Z","updated_at":"2014-06-11T18:19:38Z","pushed_at":"2014-06-10T18:28:27Z","git_url":"git://github.com/github/hubot.git","ssh_url":"git@github.com:github/hubot.git","clone_url":"https://github.com/github/hubot.git","svn_url":"https://github.com/github/hubot","homepage":"http://hubot.github.com","size":8226,"stargazers_count":5921,"watchers_count":5921,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":1312,"mirror_url":null,"open_issues_count":46,"forks":1312,"open_issues":46,"watchers":5921,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/github/hubot/pulls/709"},"html":{"href":"https://github.com/github/hubot/pull/709"},"issue":{"href":"https://api.github.com/repos/github/hubot/issues/709"},"comments":{"href":"https://api.github.com/repos/github/hubot/issues/709/comments"},"review_comments":{"href":"https://api.github.com/repos/github/hubot/pulls/709/comments"},"review_comment":{"href":"https://api.github.com/repos/github/hubot/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/github/hubot/pulls/709/commits"},"statuses":{"href":"https://api.github.com/repos/github/hubot/statuses/aa209f1c8ef4673d316118cb70b5e6b867b429a1"}}}}