GitHub PullRequestEvent at 2014-06-05 15:25:21
Repository: popit
Actor: hecticjeff
Payload: {"action":"closed","number":505,"pull_request":{"url":"https://api.github.com/repos/mysociety/popit/pulls/505","id":16766885,"html_url":"https://github.com/mysociety/popit/pull/505","diff_url":"https://github.com/mysociety/popit/pull/505.diff","patch_url":"https://github.com/mysociety/popit/pull/505.patch","issue_url":"https://api.github.com/repos/mysociety/popit/issues/505","number":505,"state":"closed","title":"Simplify logging","user":{"login":"hecticjeff","id":22996,"avatar_url":"https://avatars.githubusercontent.com/u/22996?","gravatar_id":"40bfcaa9f088ec0439a3d7b8a08eb2bb","url":"https://api.github.com/users/hecticjeff","html_url":"https://github.com/hecticjeff","followers_url":"https://api.github.com/users/hecticjeff/followers","following_url":"https://api.github.com/users/hecticjeff/following{/other_user}","gists_url":"https://api.github.com/users/hecticjeff/gists{/gist_id}","starred_url":"https://api.github.com/users/hecticjeff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hecticjeff/subscriptions","organizations_url":"https://api.github.com/users/hecticjeff/orgs","repos_url":"https://api.github.com/users/hecticjeff/repos","events_url":"https://api.github.com/users/hecticjeff/events{/privacy}","received_events_url":"https://api.github.com/users/hecticjeff/received_events","type":"User","site_admin":false},"body":"Rather than logging to the console, files and loggly depending on the current configuration, we simply log everything to the console. Then in the `popit-daemon-debian.ugly` script we append all output to `$vhost_dir/logs/app_log`.\r\n\r\nThese changes will hopefully make it easier to figure out what's going on with #411. Previously any stacktraces from a crashed node process weren't getting stored anywhere.\r\n\r\nPart of #453 ","created_at":"2014-06-05T13:54:16Z","updated_at":"2014-06-05T15:25:21Z","closed_at":"2014-06-05T15:25:21Z","merged_at":"2014-06-05T15:25:21Z","merge_commit_sha":"7592df60362b6dd3315fc2a869fa978d3152c290","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mysociety/popit/pulls/505/commits","review_comments_url":"https://api.github.com/repos/mysociety/popit/pulls/505/comments","review_comment_url":"https://api.github.com/repos/mysociety/popit/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mysociety/popit/issues/505/comments","statuses_url":"https://api.github.com/repos/mysociety/popit/statuses/efca6216e1a8c6b60c0bab99783d9dae9645d6a1","head":{"label":"mysociety:fix-logging","ref":"fix-logging","sha":"efca6216e1a8c6b60c0bab99783d9dae9645d6a1","user":{"login":"mysociety","id":141338,"avatar_url":"https://avatars.githubusercontent.com/u/141338?","gravatar_id":"cb4e9c9ec6d33ee844baa03bd8f58cd3","url":"https://api.github.com/users/mysociety","html_url":"https://github.com/mysociety","followers_url":"https://api.github.com/users/mysociety/followers","following_url":"https://api.github.com/users/mysociety/following{/other_user}","gists_url":"https://api.github.com/users/mysociety/gists{/gist_id}","starred_url":"https://api.github.com/users/mysociety/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mysociety/subscriptions","organizations_url":"https://api.github.com/users/mysociety/orgs","repos_url":"https://api.github.com/users/mysociety/repos","events_url":"https://api.github.com/users/mysociety/events{/privacy}","received_events_url":"https://api.github.com/users/mysociety/received_events","type":"Organization","site_admin":false},"repo":{"id":2835614,"name":"popit","full_name":"mysociety/popit","owner":{"login":"mysociety","id":141338,"avatar_url":"https://avatars.githubusercontent.com/u/141338?","gravatar_id":"cb4e9c9ec6d33ee844baa03bd8f58cd3","url":"https://api.github.com/users/mysociety","html_url":"https://github.com/mysociety","followers_url":"https://api.github.com/users/mysociety/followers","following_url":"https://api.github.com/users/mysociety/following{/other_user}","gists_url":"https://api.github.com/users/mysociety/gists{/gist_id}","starred_url":"https://api.github.com/users/mysociety/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mysociety/subscriptions","organizations_url":"https://api.github.com/users/mysociety/orgs","repos_url":"https://api.github.com/users/mysociety/repos","events_url":"https://api.github.com/users/mysociety/events{/privacy}","received_events_url":"https://api.github.com/users/mysociety/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mysociety/popit","description":"Create, store and share key facts about people and their career histories","fork":false,"url":"https://api.github.com/repos/mysociety/popit","forks_url":"https://api.github.com/repos/mysociety/popit/forks","keys_url":"https://api.github.com/repos/mysociety/popit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mysociety/popit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mysociety/popit/teams","hooks_url":"https://api.github.com/repos/mysociety/popit/hooks","issue_events_url":"https://api.github.com/repos/mysociety/popit/issues/events{/number}","events_url":"https://api.github.com/repos/mysociety/popit/events","assignees_url":"https://api.github.com/repos/mysociety/popit/assignees{/user}","branches_url":"https://api.github.com/repos/mysociety/popit/branches{/branch}","tags_url":"https://api.github.com/repos/mysociety/popit/tags","blobs_url":"https://api.github.com/repos/mysociety/popit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mysociety/popit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mysociety/popit/git/refs{/sha}","trees_url":"https://api.github.com/repos/mysociety/popit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mysociety/popit/statuses/{sha}","languages_url":"https://api.github.com/repos/mysociety/popit/languages","stargazers_url":"https://api.github.com/repos/mysociety/popit/stargazers","contributors_url":"https://api.github.com/repos/mysociety/popit/contributors","subscribers_url":"https://api.github.com/repos/mysociety/popit/subscribers","subscription_url":"https://api.github.com/repos/mysociety/popit/subscription","commits_url":"https://api.github.com/repos/mysociety/popit/commits{/sha}","git_commits_url":"https://api.github.com/repos/mysociety/popit/git/commits{/sha}","comments_url":"https://api.github.com/repos/mysociety/popit/comments{/number}","issue_comment_url":"https://api.github.com/repos/mysociety/popit/issues/comments/{number}","contents_url":"https://api.github.com/repos/mysociety/popit/contents/{+path}","compare_url":"https://api.github.com/repos/mysociety/popit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mysociety/popit/merges","archive_url":"https://api.github.com/repos/mysociety/popit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mysociety/popit/downloads","issues_url":"https://api.github.com/repos/mysociety/popit/issues{/number}","pulls_url":"https://api.github.com/repos/mysociety/popit/pulls{/number}","milestones_url":"https://api.github.com/repos/mysociety/popit/milestones{/number}","notifications_url":"https://api.github.com/repos/mysociety/popit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mysociety/popit/labels{/name}","releases_url":"https://api.github.com/repos/mysociety/popit/releases{/id}","created_at":"2011-11-23T12:44:54Z","updated_at":"2014-06-05T15:25:21Z","pushed_at":"2014-06-05T15:25:21Z","git_url":"git://github.com/mysociety/popit.git","ssh_url":"git@github.com:mysociety/popit.git","clone_url":"https://github.com/mysociety/popit.git","svn_url":"https://github.com/mysociety/popit","homepage":"http://popit.mysociety.org/","size":11793,"stargazers_count":51,"watchers_count":51,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":24,"mirror_url":null,"open_issues_count":131,"forks":24,"open_issues":131,"watchers":51,"default_branch":"master"}},"base":{"label":"mysociety:master","ref":"master","sha":"0dc02948fb3798e0e8bba80d2fd8dcb8bba6f6e1","user":{"login":"mysociety","id":141338,"avatar_url":"https://avatars.githubusercontent.com/u/141338?","gravatar_id":"cb4e9c9ec6d33ee844baa03bd8f58cd3","url":"https://api.github.com/users/mysociety","html_url":"https://github.com/mysociety","followers_url":"https://api.github.com/users/mysociety/followers","following_url":"https://api.github.com/users/mysociety/following{/other_user}","gists_url":"https://api.github.com/users/mysociety/gists{/gist_id}","starred_url":"https://api.github.com/users/mysociety/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mysociety/subscriptions","organizations_url":"https://api.github.com/users/mysociety/orgs","repos_url":"https://api.github.com/users/mysociety/repos","events_url":"https://api.github.com/users/mysociety/events{/privacy}","received_events_url":"https://api.github.com/users/mysociety/received_events","type":"Organization","site_admin":false},"repo":{"id":2835614,"name":"popit","full_name":"mysociety/popit","owner":{"login":"mysociety","id":141338,"avatar_url":"https://avatars.githubusercontent.com/u/141338?","gravatar_id":"cb4e9c9ec6d33ee844baa03bd8f58cd3","url":"https://api.github.com/users/mysociety","html_url":"https://github.com/mysociety","followers_url":"https://api.github.com/users/mysociety/followers","following_url":"https://api.github.com/users/mysociety/following{/other_user}","gists_url":"https://api.github.com/users/mysociety/gists{/gist_id}","starred_url":"https://api.github.com/users/mysociety/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mysociety/subscriptions","organizations_url":"https://api.github.com/users/mysociety/orgs","repos_url":"https://api.github.com/users/mysociety/repos","events_url":"https://api.github.com/users/mysociety/events{/privacy}","received_events_url":"https://api.github.com/users/mysociety/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mysociety/popit","description":"Create, store and share key facts about people and their career histories","fork":false,"url":"https://api.github.com/repos/mysociety/popit","forks_url":"https://api.github.com/repos/mysociety/popit/forks","keys_url":"https://api.github.com/repos/mysociety/popit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mysociety/popit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mysociety/popit/teams","hooks_url":"https://api.github.com/repos/mysociety/popit/hooks","issue_events_url":"https://api.github.com/repos/mysociety/popit/issues/events{/number}","events_url":"https://api.github.com/repos/mysociety/popit/events","assignees_url":"https://api.github.com/repos/mysociety/popit/assignees{/user}","branches_url":"https://api.github.com/repos/mysociety/popit/branches{/branch}","tags_url":"https://api.github.com/repos/mysociety/popit/tags","blobs_url":"https://api.github.com/repos/mysociety/popit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mysociety/popit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mysociety/popit/git/refs{/sha}","trees_url":"https://api.github.com/repos/mysociety/popit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mysociety/popit/statuses/{sha}","languages_url":"https://api.github.com/repos/mysociety/popit/languages","stargazers_url":"https://api.github.com/repos/mysociety/popit/stargazers","contributors_url":"https://api.github.com/repos/mysociety/popit/contributors","subscribers_url":"https://api.github.com/repos/mysociety/popit/subscribers","subscription_url":"https://api.github.com/repos/mysociety/popit/subscription","commits_url":"https://api.github.com/repos/mysociety/popit/commits{/sha}","git_commits_url":"https://api.github.com/repos/mysociety/popit/git/commits{/sha}","comments_url":"https://api.github.com/repos/mysociety/popit/comments{/number}","issue_comment_url":"https://api.github.com/repos/mysociety/popit/issues/comments/{number}","contents_url":"https://api.github.com/repos/mysociety/popit/contents/{+path}","compare_url":"https://api.github.com/repos/mysociety/popit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mysociety/popit/merges","archive_url":"https://api.github.com/repos/mysociety/popit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mysociety/popit/downloads","issues_url":"https://api.github.com/repos/mysociety/popit/issues{/number}","pulls_url":"https://api.github.com/repos/mysociety/popit/pulls{/number}","milestones_url":"https://api.github.com/repos/mysociety/popit/milestones{/number}","notifications_url":"https://api.github.com/repos/mysociety/popit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mysociety/popit/labels{/name}","releases_url":"https://api.github.com/repos/mysociety/popit/releases{/id}","created_at":"2011-11-23T12:44:54Z","updated_at":"2014-06-05T15:25:21Z","pushed_at":"2014-06-05T15:25:21Z","git_url":"git://github.com/mysociety/popit.git","ssh_url":"git@github.com:mysociety/popit.git","clone_url":"https://github.com/mysociety/popit.git","svn_url":"https://github.com/mysociety/popit","homepage":"http://popit.mysociety.org/","size":11793,"stargazers_count":51,"watchers_count":51,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":24,"mirror_url":null,"open_issues_count":131,"forks":24,"open_issues":131,"watchers":51,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mysociety/popit/pulls/505"},"html":{"href":"https://github.com/mysociety/popit/pull/505"},"issue":{"href":"https://api.github.com/repos/mysociety/popit/issues/505"},"comments":{"href":"https://api.github.com/repos/mysociety/popit/issues/505/comments"},"review_comments":{"href":"https://api.github.com/repos/mysociety/popit/pulls/505/comments"},"review_comment":{"href":"https://api.github.com/repos/mysociety/popit/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mysociety/popit/pulls/505/commits"},"statuses":{"href":"https://api.github.com/repos/mysociety/popit/statuses/efca6216e1a8c6b60c0bab99783d9dae9645d6a1"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"hecticjeff","id":22996,"avatar_url":"https://avatars.githubusercontent.com/u/22996?","gravatar_id":"40bfcaa9f088ec0439a3d7b8a08eb2bb","url":"https://api.github.com/users/hecticjeff","html_url":"https://github.com/hecticjeff","followers_url":"https://api.github.com/users/hecticjeff/followers","following_url":"https://api.github.com/users/hecticjeff/following{/other_user}","gists_url":"https://api.github.com/users/hecticjeff/gists{/gist_id}","starred_url":"https://api.github.com/users/hecticjeff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hecticjeff/subscriptions","organizations_url":"https://api.github.com/users/hecticjeff/orgs","repos_url":"https://api.github.com/users/hecticjeff/repos","events_url":"https://api.github.com/users/hecticjeff/events{/privacy}","received_events_url":"https://api.github.com/users/hecticjeff/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":4,"additions":15,"deletions":66,"changed_files":6}}