GitHub PullRequestEvent at 2014-11-19 20:10:23
Repository: jemplate
Actor: buzzfeedjoe
Payload: {"action":"opened","number":25,"pull_request":{"url":"https://api.github.com/repos/ingydotnet/jemplate/pulls/25","id":24717162,"html_url":"https://github.com/ingydotnet/jemplate/pull/25","diff_url":"https://github.com/ingydotnet/jemplate/pull/25.diff","patch_url":"https://github.com/ingydotnet/jemplate/pull/25.patch","issue_url":"https://api.github.com/repos/ingydotnet/jemplate/issues/25","number":25,"state":"open","locked":false,"title":"Export Jemplate in kernel.js","user":{"login":"buzzfeedjoe","id":3073834,"avatar_url":"https://avatars.githubusercontent.com/u/3073834?v=3","gravatar_id":"","url":"https://api.github.com/users/buzzfeedjoe","html_url":"https://github.com/buzzfeedjoe","followers_url":"https://api.github.com/users/buzzfeedjoe/followers","following_url":"https://api.github.com/users/buzzfeedjoe/following{/other_user}","gists_url":"https://api.github.com/users/buzzfeedjoe/gists{/gist_id}","starred_url":"https://api.github.com/users/buzzfeedjoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buzzfeedjoe/subscriptions","organizations_url":"https://api.github.com/users/buzzfeedjoe/orgs","repos_url":"https://api.github.com/users/buzzfeedjoe/repos","events_url":"https://api.github.com/users/buzzfeedjoe/events{/privacy}","received_events_url":"https://api.github.com/users/buzzfeedjoe/received_events","type":"User","site_admin":false},"body":"* export Jemplate in kernel.js\r\n* update README with development tools and build details\r\n\r\nThis change was necessary to integrate Jemplate with spritesmith-cli, which can take an arbitrary templating engine for generating SCSS code. This specifically happens in the .spritesmith.js file which is documented here:\r\n\r\nhttps://www.npmjs.org/package/spritesmith-cli\r\n\r\nIn order to include Jemplate into this config file, we need to require() it, as well as any templates we need to Jemplate to render. As it stands now, the Jemplate runtime does not export itself, even though the generated template files try to require it if exports is not defined:\r\n\r\nhttps://github.com/ingydotnet/jemplate/blob/master/lib/Jemplate.pm#L401-L403\r\n\r\nOn a related note, I published an npm module for this modified Jemplate runtime (without Ajax or JSON support) so that it can be included as a dependency in our app:\r\n\r\nhttps://www.npmjs.org/package/jemplate\r\n\r\nIf you have any feedback or questions, feel free to email me at joe.stanco@buzzfeed.com\r\n","created_at":"2014-11-19T20:10:22Z","updated_at":"2014-11-19T20:10:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ingydotnet/jemplate/pulls/25/commits","review_comments_url":"https://api.github.com/repos/ingydotnet/jemplate/pulls/25/comments","review_comment_url":"https://api.github.com/repos/ingydotnet/jemplate/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ingydotnet/jemplate/issues/25/comments","statuses_url":"https://api.github.com/repos/ingydotnet/jemplate/statuses/cadc4b2badd03c397b32d16fac3edf012a5cc20f","head":{"label":"buzzfeed:jemplate-with-exported-runtime","ref":"jemplate-with-exported-runtime","sha":"cadc4b2badd03c397b32d16fac3edf012a5cc20f","user":{"login":"buzzfeed","id":1781305,"avatar_url":"https://avatars.githubusercontent.com/u/1781305?v=3","gravatar_id":"","url":"https://api.github.com/users/buzzfeed","html_url":"https://github.com/buzzfeed","followers_url":"https://api.github.com/users/buzzfeed/followers","following_url":"https://api.github.com/users/buzzfeed/following{/other_user}","gists_url":"https://api.github.com/users/buzzfeed/gists{/gist_id}","starred_url":"https://api.github.com/users/buzzfeed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buzzfeed/subscriptions","organizations_url":"https://api.github.com/users/buzzfeed/orgs","repos_url":"https://api.github.com/users/buzzfeed/repos","events_url":"https://api.github.com/users/buzzfeed/events{/privacy}","received_events_url":"https://api.github.com/users/buzzfeed/received_events","type":"Organization","site_admin":false},"repo":{"id":26448689,"name":"jemplate","full_name":"buzzfeed/jemplate","owner":{"login":"buzzfeed","id":1781305,"avatar_url":"https://avatars.githubusercontent.com/u/1781305?v=3","gravatar_id":"","url":"https://api.github.com/users/buzzfeed","html_url":"https://github.com/buzzfeed","followers_url":"https://api.github.com/users/buzzfeed/followers","following_url":"https://api.github.com/users/buzzfeed/following{/other_user}","gists_url":"https://api.github.com/users/buzzfeed/gists{/gist_id}","starred_url":"https://api.github.com/users/buzzfeed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buzzfeed/subscriptions","organizations_url":"https://api.github.com/users/buzzfeed/orgs","repos_url":"https://api.github.com/users/buzzfeed/repos","events_url":"https://api.github.com/users/buzzfeed/events{/privacy}","received_events_url":"https://api.github.com/users/buzzfeed/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/buzzfeed/jemplate","description":"Industrial strength JavaScript template framework","fork":true,"url":"https://api.github.com/repos/buzzfeed/jemplate","forks_url":"https://api.github.com/repos/buzzfeed/jemplate/forks","keys_url":"https://api.github.com/repos/buzzfeed/jemplate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/buzzfeed/jemplate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/buzzfeed/jemplate/teams","hooks_url":"https://api.github.com/repos/buzzfeed/jemplate/hooks","issue_events_url":"https://api.github.com/repos/buzzfeed/jemplate/issues/events{/number}","events_url":"https://api.github.com/repos/buzzfeed/jemplate/events","assignees_url":"https://api.github.com/repos/buzzfeed/jemplate/assignees{/user}","branches_url":"https://api.github.com/repos/buzzfeed/jemplate/branches{/branch}","tags_url":"https://api.github.com/repos/buzzfeed/jemplate/tags","blobs_url":"https://api.github.com/repos/buzzfeed/jemplate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/buzzfeed/jemplate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/buzzfeed/jemplate/git/refs{/sha}","trees_url":"https://api.github.com/repos/buzzfeed/jemplate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/buzzfeed/jemplate/statuses/{sha}","languages_url":"https://api.github.com/repos/buzzfeed/jemplate/languages","stargazers_url":"https://api.github.com/repos/buzzfeed/jemplate/stargazers","contributors_url":"https://api.github.com/repos/buzzfeed/jemplate/contributors","subscribers_url":"https://api.github.com/repos/buzzfeed/jemplate/subscribers","subscription_url":"https://api.github.com/repos/buzzfeed/jemplate/subscription","commits_url":"https://api.github.com/repos/buzzfeed/jemplate/commits{/sha}","git_commits_url":"https://api.github.com/repos/buzzfeed/jemplate/git/commits{/sha}","comments_url":"https://api.github.com/repos/buzzfeed/jemplate/comments{/number}","issue_comment_url":"https://api.github.com/repos/buzzfeed/jemplate/issues/comments/{number}","contents_url":"https://api.github.com/repos/buzzfeed/jemplate/contents/{+path}","compare_url":"https://api.github.com/repos/buzzfeed/jemplate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/buzzfeed/jemplate/merges","archive_url":"https://api.github.com/repos/buzzfeed/jemplate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/buzzfeed/jemplate/downloads","issues_url":"https://api.github.com/repos/buzzfeed/jemplate/issues{/number}","pulls_url":"https://api.github.com/repos/buzzfeed/jemplate/pulls{/number}","milestones_url":"https://api.github.com/repos/buzzfeed/jemplate/milestones{/number}","notifications_url":"https://api.github.com/repos/buzzfeed/jemplate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/buzzfeed/jemplate/labels{/name}","releases_url":"https://api.github.com/repos/buzzfeed/jemplate/releases{/id}","created_at":"2014-11-10T18:10:58Z","updated_at":"2014-11-17T20:04:47Z","pushed_at":"2014-11-19T19:55:56Z","git_url":"git://github.com/buzzfeed/jemplate.git","ssh_url":"git@github.com:buzzfeed/jemplate.git","clone_url":"https://github.com/buzzfeed/jemplate.git","svn_url":"https://github.com/buzzfeed/jemplate","homepage":"http://www.jemplate.net/","size":2128,"stargazers_count":0,"watchers_count":0,"language":"Perl","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ingydotnet:master","ref":"master","sha":"84157199332ea14762c56241e1025d48ae3c0152","user":{"login":"ingydotnet","id":21826,"avatar_url":"https://avatars.githubusercontent.com/u/21826?v=3","gravatar_id":"","url":"https://api.github.com/users/ingydotnet","html_url":"https://github.com/ingydotnet","followers_url":"https://api.github.com/users/ingydotnet/followers","following_url":"https://api.github.com/users/ingydotnet/following{/other_user}","gists_url":"https://api.github.com/users/ingydotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/ingydotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ingydotnet/subscriptions","organizations_url":"https://api.github.com/users/ingydotnet/orgs","repos_url":"https://api.github.com/users/ingydotnet/repos","events_url":"https://api.github.com/users/ingydotnet/events{/privacy}","received_events_url":"https://api.github.com/users/ingydotnet/received_events","type":"User","site_admin":false},"repo":{"id":155737,"name":"jemplate","full_name":"ingydotnet/jemplate","owner":{"login":"ingydotnet","id":21826,"avatar_url":"https://avatars.githubusercontent.com/u/21826?v=3","gravatar_id":"","url":"https://api.github.com/users/ingydotnet","html_url":"https://github.com/ingydotnet","followers_url":"https://api.github.com/users/ingydotnet/followers","following_url":"https://api.github.com/users/ingydotnet/following{/other_user}","gists_url":"https://api.github.com/users/ingydotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/ingydotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ingydotnet/subscriptions","organizations_url":"https://api.github.com/users/ingydotnet/orgs","repos_url":"https://api.github.com/users/ingydotnet/repos","events_url":"https://api.github.com/users/ingydotnet/events{/privacy}","received_events_url":"https://api.github.com/users/ingydotnet/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ingydotnet/jemplate","description":"Industrial strength JavaScript template framework","fork":false,"url":"https://api.github.com/repos/ingydotnet/jemplate","forks_url":"https://api.github.com/repos/ingydotnet/jemplate/forks","keys_url":"https://api.github.com/repos/ingydotnet/jemplate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ingydotnet/jemplate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ingydotnet/jemplate/teams","hooks_url":"https://api.github.com/repos/ingydotnet/jemplate/hooks","issue_events_url":"https://api.github.com/repos/ingydotnet/jemplate/issues/events{/number}","events_url":"https://api.github.com/repos/ingydotnet/jemplate/events","assignees_url":"https://api.github.com/repos/ingydotnet/jemplate/assignees{/user}","branches_url":"https://api.github.com/repos/ingydotnet/jemplate/branches{/branch}","tags_url":"https://api.github.com/repos/ingydotnet/jemplate/tags","blobs_url":"https://api.github.com/repos/ingydotnet/jemplate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ingydotnet/jemplate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ingydotnet/jemplate/git/refs{/sha}","trees_url":"https://api.github.com/repos/ingydotnet/jemplate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ingydotnet/jemplate/statuses/{sha}","languages_url":"https://api.github.com/repos/ingydotnet/jemplate/languages","stargazers_url":"https://api.github.com/repos/ingydotnet/jemplate/stargazers","contributors_url":"https://api.github.com/repos/ingydotnet/jemplate/contributors","subscribers_url":"https://api.github.com/repos/ingydotnet/jemplate/subscribers","subscription_url":"https://api.github.com/repos/ingydotnet/jemplate/subscription","commits_url":"https://api.github.com/repos/ingydotnet/jemplate/commits{/sha}","git_commits_url":"https://api.github.com/repos/ingydotnet/jemplate/git/commits{/sha}","comments_url":"https://api.github.com/repos/ingydotnet/jemplate/comments{/number}","issue_comment_url":"https://api.github.com/repos/ingydotnet/jemplate/issues/comments/{number}","contents_url":"https://api.github.com/repos/ingydotnet/jemplate/contents/{+path}","compare_url":"https://api.github.com/repos/ingydotnet/jemplate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ingydotnet/jemplate/merges","archive_url":"https://api.github.com/repos/ingydotnet/jemplate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ingydotnet/jemplate/downloads","issues_url":"https://api.github.com/repos/ingydotnet/jemplate/issues{/number}","pulls_url":"https://api.github.com/repos/ingydotnet/jemplate/pulls{/number}","milestones_url":"https://api.github.com/repos/ingydotnet/jemplate/milestones{/number}","notifications_url":"https://api.github.com/repos/ingydotnet/jemplate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ingydotnet/jemplate/labels{/name}","releases_url":"https://api.github.com/repos/ingydotnet/jemplate/releases{/id}","created_at":"2009-03-21T13:58:36Z","updated_at":"2014-09-11T19:27:42Z","pushed_at":"2014-05-12T02:37:31Z","git_url":"git://github.com/ingydotnet/jemplate.git","ssh_url":"git@github.com:ingydotnet/jemplate.git","clone_url":"https://github.com/ingydotnet/jemplate.git","svn_url":"https://github.com/ingydotnet/jemplate","homepage":"http://www.jemplate.net/","size":2500,"stargazers_count":45,"watchers_count":45,"language":"Perl","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":21,"mirror_url":null,"open_issues_count":9,"forks":21,"open_issues":9,"watchers":45,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ingydotnet/jemplate/pulls/25"},"html":{"href":"https://github.com/ingydotnet/jemplate/pull/25"},"issue":{"href":"https://api.github.com/repos/ingydotnet/jemplate/issues/25"},"comments":{"href":"https://api.github.com/repos/ingydotnet/jemplate/issues/25/comments"},"review_comments":{"href":"https://api.github.com/repos/ingydotnet/jemplate/pulls/25/comments"},"review_comment":{"href":"https://api.github.com/repos/ingydotnet/jemplate/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ingydotnet/jemplate/pulls/25/commits"},"statuses":{"href":"https://api.github.com/repos/ingydotnet/jemplate/statuses/cadc4b2badd03c397b32d16fac3edf012a5cc20f"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":53,"deletions":0,"changed_files":2}}