GitHub PullRequestReviewCommentEvent at 2014-11-24 06:39:22
Repository: scala-js
Actor: gzm0
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/scala-js/scala-js/pulls/comments/20774547","id":20774547,"diff_hunk":"@@ -0,0 +1,66 @@\n+package scala.scalajs.sbtplugin.testing\n+\n+import sbt._\n+\n+import scala.scalajs.tools.env._\n+import scala.scalajs.tools.classpath._\n+import scala.scalajs.tools.io._\n+import scala.scalajs.tools.json._\n+import scala.scalajs.tools.logging._\n+\n+import scala.scalajs.sbtplugin.JSUtils\n+\n+import scala.collection.mutable\n+\n+final class FrameworkDetector(jsEnv: JSEnv, classpath: CompleteClasspath) {","path":"sbt-plugin/src/main/scala/scala/scalajs/sbtplugin/testing/FrameworkDetector.scala","position":15,"original_position":15,"commit_id":"1d0d885b13040e27e86e6b648393bf4936e9c6a8","original_commit_id":"1d0d885b13040e27e86e6b648393bf4936e9c6a8","user":{"login":"gzm0","id":1140323,"avatar_url":"https://avatars.githubusercontent.com/u/1140323?v=3","gravatar_id":"","url":"https://api.github.com/users/gzm0","html_url":"https://github.com/gzm0","followers_url":"https://api.github.com/users/gzm0/followers","following_url":"https://api.github.com/users/gzm0/following{/other_user}","gists_url":"https://api.github.com/users/gzm0/gists{/gist_id}","starred_url":"https://api.github.com/users/gzm0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gzm0/subscriptions","organizations_url":"https://api.github.com/users/gzm0/orgs","repos_url":"https://api.github.com/users/gzm0/repos","events_url":"https://api.github.com/users/gzm0/events{/privacy}","received_events_url":"https://api.github.com/users/gzm0/received_events","type":"User","site_admin":false},"body":"It seemed neater. `jsEnv` and `classpath` are somewhat configuration of that thing. And it is completely reasonable to reuse a `FrameworkDetector` like that.\r\nBut I can put it on the companion if you like.","created_at":"2014-11-24T06:39:22Z","updated_at":"2014-11-24T06:39:22Z","html_url":"https://github.com/scala-js/scala-js/pull/1289#discussion_r20774547","pull_request_url":"https://api.github.com/repos/scala-js/scala-js/pulls/1289","_links":{"self":{"href":"https://api.github.com/repos/scala-js/scala-js/pulls/comments/20774547"},"html":{"href":"https://github.com/scala-js/scala-js/pull/1289#discussion_r20774547"},"pull_request":{"href":"https://api.github.com/repos/scala-js/scala-js/pulls/1289"}}},"pull_request":{"url":"https://api.github.com/repos/scala-js/scala-js/pulls/1289","id":24837568,"html_url":"https://github.com/scala-js/scala-js/pull/1289","diff_url":"https://github.com/scala-js/scala-js/pull/1289.diff","patch_url":"https://github.com/scala-js/scala-js/pull/1289.patch","issue_url":"https://api.github.com/repos/scala-js/scala-js/issues/1289","number":1289,"state":"open","locked":false,"title":"New test interface","user":{"login":"gzm0","id":1140323,"avatar_url":"https://avatars.githubusercontent.com/u/1140323?v=3","gravatar_id":"","url":"https://api.github.com/users/gzm0","html_url":"https://github.com/gzm0","followers_url":"https://api.github.com/users/gzm0/followers","following_url":"https://api.github.com/users/gzm0/following{/other_user}","gists_url":"https://api.github.com/users/gzm0/gists{/gist_id}","starred_url":"https://api.github.com/users/gzm0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gzm0/subscriptions","organizations_url":"https://api.github.com/users/gzm0/orgs","repos_url":"https://api.github.com/users/gzm0/repos","events_url":"https://api.github.com/users/gzm0/events{/privacy}","received_events_url":"https://api.github.com/users/gzm0/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-11-21T12:48:13Z","updated_at":"2014-11-24T06:39:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"01e0dae8ec465bf08ce3f4d591d242fcab3f032b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/scala-js/scala-js/pulls/1289/commits","review_comments_url":"https://api.github.com/repos/scala-js/scala-js/pulls/1289/comments","review_comment_url":"https://api.github.com/repos/scala-js/scala-js/pulls/comments/{number}","comments_url":"https://api.github.com/repos/scala-js/scala-js/issues/1289/comments","statuses_url":"https://api.github.com/repos/scala-js/scala-js/statuses/1d0d885b13040e27e86e6b648393bf4936e9c6a8","head":{"label":"gzm0:test-interface","ref":"test-interface","sha":"1d0d885b13040e27e86e6b648393bf4936e9c6a8","user":{"login":"gzm0","id":1140323,"avatar_url":"https://avatars.githubusercontent.com/u/1140323?v=3","gravatar_id":"","url":"https://api.github.com/users/gzm0","html_url":"https://github.com/gzm0","followers_url":"https://api.github.com/users/gzm0/followers","following_url":"https://api.github.com/users/gzm0/following{/other_user}","gists_url":"https://api.github.com/users/gzm0/gists{/gist_id}","starred_url":"https://api.github.com/users/gzm0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gzm0/subscriptions","organizations_url":"https://api.github.com/users/gzm0/orgs","repos_url":"https://api.github.com/users/gzm0/repos","events_url":"https://api.github.com/users/gzm0/events{/privacy}","received_events_url":"https://api.github.com/users/gzm0/received_events","type":"User","site_admin":false},"repo":{"id":14925025,"name":"scala-js","full_name":"gzm0/scala-js","owner":{"login":"gzm0","id":1140323,"avatar_url":"https://avatars.githubusercontent.com/u/1140323?v=3","gravatar_id":"","url":"https://api.github.com/users/gzm0","html_url":"https://github.com/gzm0","followers_url":"https://api.github.com/users/gzm0/followers","following_url":"https://api.github.com/users/gzm0/following{/other_user}","gists_url":"https://api.github.com/users/gzm0/gists{/gist_id}","starred_url":"https://api.github.com/users/gzm0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gzm0/subscriptions","organizations_url":"https://api.github.com/users/gzm0/orgs","repos_url":"https://api.github.com/users/gzm0/repos","events_url":"https://api.github.com/users/gzm0/events{/privacy}","received_events_url":"https://api.github.com/users/gzm0/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gzm0/scala-js","description":"Scala.js, a Scala to JavaScript compiler","fork":true,"url":"https://api.github.com/repos/gzm0/scala-js","forks_url":"https://api.github.com/repos/gzm0/scala-js/forks","keys_url":"https://api.github.com/repos/gzm0/scala-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gzm0/scala-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gzm0/scala-js/teams","hooks_url":"https://api.github.com/repos/gzm0/scala-js/hooks","issue_events_url":"https://api.github.com/repos/gzm0/scala-js/issues/events{/number}","events_url":"https://api.github.com/repos/gzm0/scala-js/events","assignees_url":"https://api.github.com/repos/gzm0/scala-js/assignees{/user}","branches_url":"https://api.github.com/repos/gzm0/scala-js/branches{/branch}","tags_url":"https://api.github.com/repos/gzm0/scala-js/tags","blobs_url":"https://api.github.com/repos/gzm0/scala-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gzm0/scala-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gzm0/scala-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/gzm0/scala-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gzm0/scala-js/statuses/{sha}","languages_url":"https://api.github.com/repos/gzm0/scala-js/languages","stargazers_url":"https://api.github.com/repos/gzm0/scala-js/stargazers","contributors_url":"https://api.github.com/repos/gzm0/scala-js/contributors","subscribers_url":"https://api.github.com/repos/gzm0/scala-js/subscribers","subscription_url":"https://api.github.com/repos/gzm0/scala-js/subscription","commits_url":"https://api.github.com/repos/gzm0/scala-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/gzm0/scala-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/gzm0/scala-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/gzm0/scala-js/issues/comments/{number}","contents_url":"https://api.github.com/repos/gzm0/scala-js/contents/{+path}","compare_url":"https://api.github.com/repos/gzm0/scala-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gzm0/scala-js/merges","archive_url":"https://api.github.com/repos/gzm0/scala-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gzm0/scala-js/downloads","issues_url":"https://api.github.com/repos/gzm0/scala-js/issues{/number}","pulls_url":"https://api.github.com/repos/gzm0/scala-js/pulls{/number}","milestones_url":"https://api.github.com/repos/gzm0/scala-js/milestones{/number}","notifications_url":"https://api.github.com/repos/gzm0/scala-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gzm0/scala-js/labels{/name}","releases_url":"https://api.github.com/repos/gzm0/scala-js/releases{/id}","created_at":"2013-12-04T13:51:38Z","updated_at":"2014-11-23T12:09:01Z","pushed_at":"2014-11-23T17:24:48Z","git_url":"git://github.com/gzm0/scala-js.git","ssh_url":"git@github.com:gzm0/scala-js.git","clone_url":"https://github.com/gzm0/scala-js.git","svn_url":"https://github.com/gzm0/scala-js","homepage":"http://www.scala-js.org/","size":16919,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scala-js:master","ref":"master","sha":"6f19664831a2cc47a4a36062f525673d9768147b","user":{"login":"scala-js","id":6039724,"avatar_url":"https://avatars.githubusercontent.com/u/6039724?v=3","gravatar_id":"","url":"https://api.github.com/users/scala-js","html_url":"https://github.com/scala-js","followers_url":"https://api.github.com/users/scala-js/followers","following_url":"https://api.github.com/users/scala-js/following{/other_user}","gists_url":"https://api.github.com/users/scala-js/gists{/gist_id}","starred_url":"https://api.github.com/users/scala-js/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scala-js/subscriptions","organizations_url":"https://api.github.com/users/scala-js/orgs","repos_url":"https://api.github.com/users/scala-js/repos","events_url":"https://api.github.com/users/scala-js/events{/privacy}","received_events_url":"https://api.github.com/users/scala-js/received_events","type":"Organization","site_admin":false},"repo":{"id":8272315,"name":"scala-js","full_name":"scala-js/scala-js","owner":{"login":"scala-js","id":6039724,"avatar_url":"https://avatars.githubusercontent.com/u/6039724?v=3","gravatar_id":"","url":"https://api.github.com/users/scala-js","html_url":"https://github.com/scala-js","followers_url":"https://api.github.com/users/scala-js/followers","following_url":"https://api.github.com/users/scala-js/following{/other_user}","gists_url":"https://api.github.com/users/scala-js/gists{/gist_id}","starred_url":"https://api.github.com/users/scala-js/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scala-js/subscriptions","organizations_url":"https://api.github.com/users/scala-js/orgs","repos_url":"https://api.github.com/users/scala-js/repos","events_url":"https://api.github.com/users/scala-js/events{/privacy}","received_events_url":"https://api.github.com/users/scala-js/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scala-js/scala-js","description":"Scala.js, a Scala to JavaScript compiler","fork":false,"url":"https://api.github.com/repos/scala-js/scala-js","forks_url":"https://api.github.com/repos/scala-js/scala-js/forks","keys_url":"https://api.github.com/repos/scala-js/scala-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scala-js/scala-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scala-js/scala-js/teams","hooks_url":"https://api.github.com/repos/scala-js/scala-js/hooks","issue_events_url":"https://api.github.com/repos/scala-js/scala-js/issues/events{/number}","events_url":"https://api.github.com/repos/scala-js/scala-js/events","assignees_url":"https://api.github.com/repos/scala-js/scala-js/assignees{/user}","branches_url":"https://api.github.com/repos/scala-js/scala-js/branches{/branch}","tags_url":"https://api.github.com/repos/scala-js/scala-js/tags","blobs_url":"https://api.github.com/repos/scala-js/scala-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scala-js/scala-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scala-js/scala-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/scala-js/scala-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scala-js/scala-js/statuses/{sha}","languages_url":"https://api.github.com/repos/scala-js/scala-js/languages","stargazers_url":"https://api.github.com/repos/scala-js/scala-js/stargazers","contributors_url":"https://api.github.com/repos/scala-js/scala-js/contributors","subscribers_url":"https://api.github.com/repos/scala-js/scala-js/subscribers","subscription_url":"https://api.github.com/repos/scala-js/scala-js/subscription","commits_url":"https://api.github.com/repos/scala-js/scala-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/scala-js/scala-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/scala-js/scala-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/scala-js/scala-js/issues/comments/{number}","contents_url":"https://api.github.com/repos/scala-js/scala-js/contents/{+path}","compare_url":"https://api.github.com/repos/scala-js/scala-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scala-js/scala-js/merges","archive_url":"https://api.github.com/repos/scala-js/scala-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scala-js/scala-js/downloads","issues_url":"https://api.github.com/repos/scala-js/scala-js/issues{/number}","pulls_url":"https://api.github.com/repos/scala-js/scala-js/pulls{/number}","milestones_url":"https://api.github.com/repos/scala-js/scala-js/milestones{/number}","notifications_url":"https://api.github.com/repos/scala-js/scala-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scala-js/scala-js/labels{/name}","releases_url":"https://api.github.com/repos/scala-js/scala-js/releases{/id}","created_at":"2013-02-18T16:33:55Z","updated_at":"2014-11-24T02:42:02Z","pushed_at":"2014-11-23T17:03:32Z","git_url":"git://github.com/scala-js/scala-js.git","ssh_url":"git@github.com:scala-js/scala-js.git","clone_url":"https://github.com/scala-js/scala-js.git","svn_url":"https://github.com/scala-js/scala-js","homepage":"http://www.scala-js.org/","size":18672,"stargazers_count":1305,"watchers_count":1305,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":102,"mirror_url":null,"open_issues_count":42,"forks":102,"open_issues":42,"watchers":1305,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scala-js/scala-js/pulls/1289"},"html":{"href":"https://github.com/scala-js/scala-js/pull/1289"},"issue":{"href":"https://api.github.com/repos/scala-js/scala-js/issues/1289"},"comments":{"href":"https://api.github.com/repos/scala-js/scala-js/issues/1289/comments"},"review_comments":{"href":"https://api.github.com/repos/scala-js/scala-js/pulls/1289/comments"},"review_comment":{"href":"https://api.github.com/repos/scala-js/scala-js/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/scala-js/scala-js/pulls/1289/commits"},"statuses":{"href":"https://api.github.com/repos/scala-js/scala-js/statuses/1d0d885b13040e27e86e6b648393bf4936e9c6a8"}}}}