GitHub PullRequestReviewCommentEvent at 2014-11-29 13:08:57
Repository: rails
Actor: wazery
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/rails/rails/pulls/comments/21053758","id":21053758,"diff_hunk":"@@ -205,39 +213,44 @@\n     </script>\n   </head>\n   <body>\n-    <div id=\"page\">\n-      <div id=\"sidebar\">\n-        <ul id=\"sidebar-items\">\n-          <li>\n-            <h3>Browse the documentation</h3>\n-            <ul class=\"links\">\n-              <li><a href=\"http://guides.rubyonrails.org/\">Rails Guides</a></li>\n-              <li><a href=\"http://api.rubyonrails.org/\">Rails API</a></li>\n-              <li><a href=\"http://www.ruby-doc.org/core/\">Ruby core</a></li>\n-              <li><a href=\"http://www.ruby-doc.org/stdlib/\">Ruby standard library</a></li>\n-            </ul>\n-          </li>\n+    <div id=\"topNav\">\n+      <div id=\"wrapper\">\n+        <strong>Browse the documentation:</strong>\n+        <ul id=\"more-info-links\">\n+          <li id=\"more-info\"><a href=\"http://guides.rubyonrails.org/\">Rails Guides</a></li>\n+          <li id=\"more-info\"><a href=\"http://api.rubyonrails.org/\">Rails API</a></li>\n+          <li id=\"more-info\"><a href=\"http://www.ruby-doc.org/core/\">Ruby core</a></li>\n+          <li id=\"more-info\"><a href=\"http://www.ruby-doc.org/stdlib/\">Ruby standard library</a></li>\n         </ul>\n       </div>\n-\n-      <div id=\"content\">\n-        <div id=\"header\">\n+    </div>\n+    <div id=\"header\">\n+      <div id=\"wrapper\">\n+        <div id=\"image\"></div>\n+        <div id=\"header-text\">\n           <h1>Welcome aboard</h1>\n           <h2>You&rsquo;re riding Ruby on Rails!</h2>\n         </div>\n+      </div>\n+    </div>\n \n-        <div id=\"about\">\n-          <h3><a href=\"/rails/info/properties\" onclick=\"about(); return false\">About your application&rsquo;s environment</a></h3>\n-          <div id=\"about-content\" style=\"display: none\"></div>\n+    <div id=\"getting-started\">\n+      <div id=\"wrapper\" class=\"clearfix\">\n+        <h3><a href=\"/rails/info/properties\" onclick=\"about(); return false\">About your application&rsquo;s environment</a></h3>\n+        <div>\n+        <h1>Getting started</h1>\n+        <h2>Here&rsquo;s how to get rolling:</h2>\n         </div>\n+      </div>\n+    </div>\n \n-        <div id=\"getting-started\">\n-          <h1>Getting started</h1>\n-          <h2>Here&rsquo;s how to get rolling:</h2>\n-\n+    <div id=\"content\">\n+      <div id=\"wrapper\">\n+        <div id=\"about-content\" style=\"display: none\"></div>\n+        <div id=\"content-list\">\n           <ol>\n             <li>\n-              <h2>Use <code>bin/rails generate</code> to create your models and controllers</h2>\n+              <h2>Use <code>rails generate</code> to create your models and controllers</h2>","path":"railties/lib/rails/templates/rails/welcome/index.html.erb","position":336,"original_position":336,"commit_id":"e0c982ed5cbbed5fb6870a89efbdb6ceb903a3c5","original_commit_id":"e0c982ed5cbbed5fb6870a89efbdb6ceb903a3c5","user":{"login":"wazery","id":470401,"avatar_url":"https://avatars.githubusercontent.com/u/470401?v=3","gravatar_id":"","url":"https://api.github.com/users/wazery","html_url":"https://github.com/wazery","followers_url":"https://api.github.com/users/wazery/followers","following_url":"https://api.github.com/users/wazery/following{/other_user}","gists_url":"https://api.github.com/users/wazery/gists{/gist_id}","starred_url":"https://api.github.com/users/wazery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wazery/subscriptions","organizations_url":"https://api.github.com/users/wazery/orgs","repos_url":"https://api.github.com/users/wazery/repos","events_url":"https://api.github.com/users/wazery/events{/privacy}","received_events_url":"https://api.github.com/users/wazery/received_events","type":"User","site_admin":false},"body":"So I need to keep the `bin/rails` right?","created_at":"2014-11-29T13:08:57Z","updated_at":"2014-11-29T13:08:57Z","html_url":"https://github.com/rails/rails/pull/17813#discussion_r21053758","pull_request_url":"https://api.github.com/repos/rails/rails/pulls/17813","_links":{"self":{"href":"https://api.github.com/repos/rails/rails/pulls/comments/21053758"},"html":{"href":"https://github.com/rails/rails/pull/17813#discussion_r21053758"},"pull_request":{"href":"https://api.github.com/repos/rails/rails/pulls/17813"}}},"pull_request":{"url":"https://api.github.com/repos/rails/rails/pulls/17813","id":25196985,"html_url":"https://github.com/rails/rails/pull/17813","diff_url":"https://github.com/rails/rails/pull/17813.diff","patch_url":"https://github.com/rails/rails/pull/17813.patch","issue_url":"https://api.github.com/repos/rails/rails/issues/17813","number":17813,"state":"open","locked":false,"title":"Changed welcome#index page overall look and feel","user":{"login":"wazery","id":470401,"avatar_url":"https://avatars.githubusercontent.com/u/470401?v=3","gravatar_id":"","url":"https://api.github.com/users/wazery","html_url":"https://github.com/wazery","followers_url":"https://api.github.com/users/wazery/followers","following_url":"https://api.github.com/users/wazery/following{/other_user}","gists_url":"https://api.github.com/users/wazery/gists{/gist_id}","starred_url":"https://api.github.com/users/wazery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wazery/subscriptions","organizations_url":"https://api.github.com/users/wazery/orgs","repos_url":"https://api.github.com/users/wazery/repos","events_url":"https://api.github.com/users/wazery/events{/privacy}","received_events_url":"https://api.github.com/users/wazery/received_events","type":"User","site_admin":false},"body":"I have posted a suggestion to the RailsCore mailing list about changing the welcome#index page overall look and feel and the feedback I got was accepting my proposal. So I issued this PR, here is how it will look like:\r\n\r\n![Index Page](https://dl.dropboxusercontent.com/u/71605080/index.png)\r\n","created_at":"2014-11-28T13:39:03Z","updated_at":"2014-11-29T13:08:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f6b8c7d7b38235ebf1265f56b9c7d8ae19498031","assignee":null,"milestone":{"url":"https://api.github.com/repos/rails/rails/milestones/34","labels_url":"https://api.github.com/repos/rails/rails/milestones/34/labels","id":665192,"number":34,"title":"5.0.0","description":null,"creator":{"login":"rafaelfranca","id":47848,"avatar_url":"https://avatars.githubusercontent.com/u/47848?v=3","gravatar_id":"","url":"https://api.github.com/users/rafaelfranca","html_url":"https://github.com/rafaelfranca","followers_url":"https://api.github.com/users/rafaelfranca/followers","following_url":"https://api.github.com/users/rafaelfranca/following{/other_user}","gists_url":"https://api.github.com/users/rafaelfranca/gists{/gist_id}","starred_url":"https://api.github.com/users/rafaelfranca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rafaelfranca/subscriptions","organizations_url":"https://api.github.com/users/rafaelfranca/orgs","repos_url":"https://api.github.com/users/rafaelfranca/repos","events_url":"https://api.github.com/users/rafaelfranca/events{/privacy}","received_events_url":"https://api.github.com/users/rafaelfranca/received_events","type":"User","site_admin":false},"open_issues":92,"closed_issues":15,"state":"open","created_at":"2014-05-21T00:58:22Z","updated_at":"2014-11-29T11:04:48Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/rails/rails/pulls/17813/commits","review_comments_url":"https://api.github.com/repos/rails/rails/pulls/17813/comments","review_comment_url":"https://api.github.com/repos/rails/rails/pulls/comments/{number}","comments_url":"https://api.github.com/repos/rails/rails/issues/17813/comments","statuses_url":"https://api.github.com/repos/rails/rails/statuses/e0c982ed5cbbed5fb6870a89efbdb6ceb903a3c5","head":{"label":"wazery:master","ref":"master","sha":"e0c982ed5cbbed5fb6870a89efbdb6ceb903a3c5","user":{"login":"wazery","id":470401,"avatar_url":"https://avatars.githubusercontent.com/u/470401?v=3","gravatar_id":"","url":"https://api.github.com/users/wazery","html_url":"https://github.com/wazery","followers_url":"https://api.github.com/users/wazery/followers","following_url":"https://api.github.com/users/wazery/following{/other_user}","gists_url":"https://api.github.com/users/wazery/gists{/gist_id}","starred_url":"https://api.github.com/users/wazery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wazery/subscriptions","organizations_url":"https://api.github.com/users/wazery/orgs","repos_url":"https://api.github.com/users/wazery/repos","events_url":"https://api.github.com/users/wazery/events{/privacy}","received_events_url":"https://api.github.com/users/wazery/received_events","type":"User","site_admin":false},"repo":{"id":18799923,"name":"rails","full_name":"wazery/rails","owner":{"login":"wazery","id":470401,"avatar_url":"https://avatars.githubusercontent.com/u/470401?v=3","gravatar_id":"","url":"https://api.github.com/users/wazery","html_url":"https://github.com/wazery","followers_url":"https://api.github.com/users/wazery/followers","following_url":"https://api.github.com/users/wazery/following{/other_user}","gists_url":"https://api.github.com/users/wazery/gists{/gist_id}","starred_url":"https://api.github.com/users/wazery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wazery/subscriptions","organizations_url":"https://api.github.com/users/wazery/orgs","repos_url":"https://api.github.com/users/wazery/repos","events_url":"https://api.github.com/users/wazery/events{/privacy}","received_events_url":"https://api.github.com/users/wazery/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wazery/rails","description":"Ruby on Rails","fork":true,"url":"https://api.github.com/repos/wazery/rails","forks_url":"https://api.github.com/repos/wazery/rails/forks","keys_url":"https://api.github.com/repos/wazery/rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wazery/rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wazery/rails/teams","hooks_url":"https://api.github.com/repos/wazery/rails/hooks","issue_events_url":"https://api.github.com/repos/wazery/rails/issues/events{/number}","events_url":"https://api.github.com/repos/wazery/rails/events","assignees_url":"https://api.github.com/repos/wazery/rails/assignees{/user}","branches_url":"https://api.github.com/repos/wazery/rails/branches{/branch}","tags_url":"https://api.github.com/repos/wazery/rails/tags","blobs_url":"https://api.github.com/repos/wazery/rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wazery/rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wazery/rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/wazery/rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wazery/rails/statuses/{sha}","languages_url":"https://api.github.com/repos/wazery/rails/languages","stargazers_url":"https://api.github.com/repos/wazery/rails/stargazers","contributors_url":"https://api.github.com/repos/wazery/rails/contributors","subscribers_url":"https://api.github.com/repos/wazery/rails/subscribers","subscription_url":"https://api.github.com/repos/wazery/rails/subscription","commits_url":"https://api.github.com/repos/wazery/rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/wazery/rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/wazery/rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/wazery/rails/issues/comments/{number}","contents_url":"https://api.github.com/repos/wazery/rails/contents/{+path}","compare_url":"https://api.github.com/repos/wazery/rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wazery/rails/merges","archive_url":"https://api.github.com/repos/wazery/rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wazery/rails/downloads","issues_url":"https://api.github.com/repos/wazery/rails/issues{/number}","pulls_url":"https://api.github.com/repos/wazery/rails/pulls{/number}","milestones_url":"https://api.github.com/repos/wazery/rails/milestones{/number}","notifications_url":"https://api.github.com/repos/wazery/rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wazery/rails/labels{/name}","releases_url":"https://api.github.com/repos/wazery/rails/releases{/id}","created_at":"2014-04-15T12:54:40Z","updated_at":"2014-11-28T14:06:45Z","pushed_at":"2014-11-28T14:06:44Z","git_url":"git://github.com/wazery/rails.git","ssh_url":"git@github.com:wazery/rails.git","clone_url":"https://github.com/wazery/rails.git","svn_url":"https://github.com/wazery/rails","homepage":"http://rubyonrails.org","size":120577,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rails:master","ref":"master","sha":"ee614af6fa6c9e8cac70bcfd7d3583d0b4ff907b","user":{"login":"rails","id":4223,"avatar_url":"https://avatars.githubusercontent.com/u/4223?v=3","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"repo":{"id":8514,"name":"rails","full_name":"rails/rails","owner":{"login":"rails","id":4223,"avatar_url":"https://avatars.githubusercontent.com/u/4223?v=3","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rails/rails","description":"Ruby on Rails","fork":false,"url":"https://api.github.com/repos/rails/rails","forks_url":"https://api.github.com/repos/rails/rails/forks","keys_url":"https://api.github.com/repos/rails/rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rails/rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rails/rails/teams","hooks_url":"https://api.github.com/repos/rails/rails/hooks","issue_events_url":"https://api.github.com/repos/rails/rails/issues/events{/number}","events_url":"https://api.github.com/repos/rails/rails/events","assignees_url":"https://api.github.com/repos/rails/rails/assignees{/user}","branches_url":"https://api.github.com/repos/rails/rails/branches{/branch}","tags_url":"https://api.github.com/repos/rails/rails/tags","blobs_url":"https://api.github.com/repos/rails/rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rails/rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rails/rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/rails/rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rails/rails/statuses/{sha}","languages_url":"https://api.github.com/repos/rails/rails/languages","stargazers_url":"https://api.github.com/repos/rails/rails/stargazers","contributors_url":"https://api.github.com/repos/rails/rails/contributors","subscribers_url":"https://api.github.com/repos/rails/rails/subscribers","subscription_url":"https://api.github.com/repos/rails/rails/subscription","commits_url":"https://api.github.com/repos/rails/rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/rails/rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/rails/rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/rails/rails/issues/comments/{number}","contents_url":"https://api.github.com/repos/rails/rails/contents/{+path}","compare_url":"https://api.github.com/repos/rails/rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rails/rails/merges","archive_url":"https://api.github.com/repos/rails/rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rails/rails/downloads","issues_url":"https://api.github.com/repos/rails/rails/issues{/number}","pulls_url":"https://api.github.com/repos/rails/rails/pulls{/number}","milestones_url":"https://api.github.com/repos/rails/rails/milestones{/number}","notifications_url":"https://api.github.com/repos/rails/rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rails/rails/labels{/name}","releases_url":"https://api.github.com/repos/rails/rails/releases{/id}","created_at":"2008-04-11T02:19:47Z","updated_at":"2014-11-29T13:08:51Z","pushed_at":"2014-11-29T11:04:50Z","git_url":"git://github.com/rails/rails.git","ssh_url":"git@github.com:rails/rails.git","clone_url":"https://github.com/rails/rails.git","svn_url":"https://github.com/rails/rails","homepage":"http://rubyonrails.org","size":413845,"stargazers_count":24079,"watchers_count":24079,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":9237,"mirror_url":null,"open_issues_count":757,"forks":9237,"open_issues":757,"watchers":24079,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rails/rails/pulls/17813"},"html":{"href":"https://github.com/rails/rails/pull/17813"},"issue":{"href":"https://api.github.com/repos/rails/rails/issues/17813"},"comments":{"href":"https://api.github.com/repos/rails/rails/issues/17813/comments"},"review_comments":{"href":"https://api.github.com/repos/rails/rails/pulls/17813/comments"},"review_comment":{"href":"https://api.github.com/repos/rails/rails/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/rails/rails/pulls/17813/commits"},"statuses":{"href":"https://api.github.com/repos/rails/rails/statuses/e0c982ed5cbbed5fb6870a89efbdb6ceb903a3c5"}}}}