GitHub PullRequestReviewCommentEvent at 2014-07-28 04:42:35
Repository: gaia
Actor: DouglasSherk
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/15446312","id":15446312,"diff_hunk":"@@ -101,6 +101,70 @@ suite('telephony helper', function() {\n     sinon.assert.notCalled(navigator.mozTelephony.dial);\n   });\n \n+  suite('<<pause>> DTMF separator', function() {\n+\n+    setup(function() {\n+      this.sinon.useFakeTimers();\n+    });\n+\n+    test('should allow dialing number with DTMF separator', function() {\n+      var dialNumber = '1233241,,123';\n+      subject.call(dialNumber, 0);\n+      sinon.assert.calledWith(navigator.mozTelephony.dial, '1233241');\n+    });\n+\n+    test('a number that starts with pause is invalid', function() {\n+      var dialNumber = ',012023423';\n+      subject.call(dialNumber, 0);\n+      assert.isTrue(spyConfirmShow.calledWith('invalidNumberToDialTitle',\n+                                              'invalidNumberToDialMessage'));\n+    });\n+\n+    test('should send DTMF tones after connection', function(done) {\n+      var clock = this.sinon.clock;\n+      var dialNumber = '1233241,,123';\n+      var startToneSpy = this.sinon.spy(navigator.mozTelephony, 'startTone');\n+      var tone1Spy = startToneSpy.withArgs('1');\n+      var tone2Spy = startToneSpy.withArgs('2');\n+      var tone3Spy = startToneSpy.withArgs('3');\n+\n+      subject.call(dialNumber, 0);\n+      mockPromise.then(function() {\n+        mockCall.state = 'connected';\n+        mockCall.onconnected();\n+        clock.tick(5500);\n+        assert.isFalse(startToneSpy.called);\n+        clock.tick(6500);\n+        assert.isTrue(tone1Spy.called);\n+        assert.isTrue(tone2Spy.calledAfter(tone1Spy));\n+        assert.isTrue(tone3Spy.calledAfter(tone2Spy));\n+      }).then(done, done);\n+    });\n+\n+    test('should wait 3 seconds after each separator', function(done) {\n+      var clock = this.sinon.clock;","path":"apps/communications/dialer/test/unit/telephony_helper_test.js","position":45,"original_position":45,"commit_id":"3b1d5612911ed70d53487b8e7b134af8f527579c","original_commit_id":"3b1d5612911ed70d53487b8e7b134af8f527579c","user":{"login":"DouglasSherk","id":1310914,"avatar_url":"https://avatars.githubusercontent.com/u/1310914?","gravatar_id":"d5256b1b26063b624fb829b898eb9615","url":"https://api.github.com/users/DouglasSherk","html_url":"https://github.com/DouglasSherk","followers_url":"https://api.github.com/users/DouglasSherk/followers","following_url":"https://api.github.com/users/DouglasSherk/following{/other_user}","gists_url":"https://api.github.com/users/DouglasSherk/gists{/gist_id}","starred_url":"https://api.github.com/users/DouglasSherk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DouglasSherk/subscriptions","organizations_url":"https://api.github.com/users/DouglasSherk/orgs","repos_url":"https://api.github.com/users/DouglasSherk/repos","events_url":"https://api.github.com/users/DouglasSherk/events{/privacy}","received_events_url":"https://api.github.com/users/DouglasSherk/received_events","type":"User","site_admin":false},"body":"This var is unnecessary.","created_at":"2014-07-28T04:42:35Z","updated_at":"2014-07-28T04:42:35Z","html_url":"https://github.com/mozilla-b2g/gaia/pull/22094#discussion_r15446312","pull_request_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/22094","_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/15446312"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/22094#discussion_r15446312"},"pull_request":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/22094"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/22094","id":18820359,"html_url":"https://github.com/mozilla-b2g/gaia/pull/22094","diff_url":"https://github.com/mozilla-b2g/gaia/pull/22094.diff","patch_url":"https://github.com/mozilla-b2g/gaia/pull/22094.patch","issue_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/22094","number":22094,"state":"open","title":"Bug 911055 - [zffos1.1][P3][Dailer]DuT doesn allow to dial a <<pause>>","user":{"login":"empoalp","id":379098,"avatar_url":"https://avatars.githubusercontent.com/u/379098?","gravatar_id":"1d460b7ed9815bd9fe68a30ffe4b3d1f","url":"https://api.github.com/users/empoalp","html_url":"https://github.com/empoalp","followers_url":"https://api.github.com/users/empoalp/followers","following_url":"https://api.github.com/users/empoalp/following{/other_user}","gists_url":"https://api.github.com/users/empoalp/gists{/gist_id}","starred_url":"https://api.github.com/users/empoalp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/empoalp/subscriptions","organizations_url":"https://api.github.com/users/empoalp/orgs","repos_url":"https://api.github.com/users/empoalp/repos","events_url":"https://api.github.com/users/empoalp/events{/privacy}","received_events_url":"https://api.github.com/users/empoalp/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-07-24T06:52:35Z","updated_at":"2014-07-28T04:42:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"be4f32919dbb0dabed8adc1c1860919bd10adbc6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/22094/commits","review_comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/22094/comments","review_comment_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/22094/comments","statuses_url":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/3b1d5612911ed70d53487b8e7b134af8f527579c","head":{"label":"empoalp:dial-pause","ref":"dial-pause","sha":"3b1d5612911ed70d53487b8e7b134af8f527579c","user":{"login":"empoalp","id":379098,"avatar_url":"https://avatars.githubusercontent.com/u/379098?","gravatar_id":"1d460b7ed9815bd9fe68a30ffe4b3d1f","url":"https://api.github.com/users/empoalp","html_url":"https://github.com/empoalp","followers_url":"https://api.github.com/users/empoalp/followers","following_url":"https://api.github.com/users/empoalp/following{/other_user}","gists_url":"https://api.github.com/users/empoalp/gists{/gist_id}","starred_url":"https://api.github.com/users/empoalp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/empoalp/subscriptions","organizations_url":"https://api.github.com/users/empoalp/orgs","repos_url":"https://api.github.com/users/empoalp/repos","events_url":"https://api.github.com/users/empoalp/events{/privacy}","received_events_url":"https://api.github.com/users/empoalp/received_events","type":"User","site_admin":false},"repo":{"id":20486649,"name":"gaia","full_name":"empoalp/gaia","owner":{"login":"empoalp","id":379098,"avatar_url":"https://avatars.githubusercontent.com/u/379098?","gravatar_id":"1d460b7ed9815bd9fe68a30ffe4b3d1f","url":"https://api.github.com/users/empoalp","html_url":"https://github.com/empoalp","followers_url":"https://api.github.com/users/empoalp/followers","following_url":"https://api.github.com/users/empoalp/following{/other_user}","gists_url":"https://api.github.com/users/empoalp/gists{/gist_id}","starred_url":"https://api.github.com/users/empoalp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/empoalp/subscriptions","organizations_url":"https://api.github.com/users/empoalp/orgs","repos_url":"https://api.github.com/users/empoalp/repos","events_url":"https://api.github.com/users/empoalp/events{/privacy}","received_events_url":"https://api.github.com/users/empoalp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/empoalp/gaia","description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see https://wiki.mozilla.org/Release_Management/B2G_Landing","fork":true,"url":"https://api.github.com/repos/empoalp/gaia","forks_url":"https://api.github.com/repos/empoalp/gaia/forks","keys_url":"https://api.github.com/repos/empoalp/gaia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/empoalp/gaia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/empoalp/gaia/teams","hooks_url":"https://api.github.com/repos/empoalp/gaia/hooks","issue_events_url":"https://api.github.com/repos/empoalp/gaia/issues/events{/number}","events_url":"https://api.github.com/repos/empoalp/gaia/events","assignees_url":"https://api.github.com/repos/empoalp/gaia/assignees{/user}","branches_url":"https://api.github.com/repos/empoalp/gaia/branches{/branch}","tags_url":"https://api.github.com/repos/empoalp/gaia/tags","blobs_url":"https://api.github.com/repos/empoalp/gaia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/empoalp/gaia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/empoalp/gaia/git/refs{/sha}","trees_url":"https://api.github.com/repos/empoalp/gaia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/empoalp/gaia/statuses/{sha}","languages_url":"https://api.github.com/repos/empoalp/gaia/languages","stargazers_url":"https://api.github.com/repos/empoalp/gaia/stargazers","contributors_url":"https://api.github.com/repos/empoalp/gaia/contributors","subscribers_url":"https://api.github.com/repos/empoalp/gaia/subscribers","subscription_url":"https://api.github.com/repos/empoalp/gaia/subscription","commits_url":"https://api.github.com/repos/empoalp/gaia/commits{/sha}","git_commits_url":"https://api.github.com/repos/empoalp/gaia/git/commits{/sha}","comments_url":"https://api.github.com/repos/empoalp/gaia/comments{/number}","issue_comment_url":"https://api.github.com/repos/empoalp/gaia/issues/comments/{number}","contents_url":"https://api.github.com/repos/empoalp/gaia/contents/{+path}","compare_url":"https://api.github.com/repos/empoalp/gaia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/empoalp/gaia/merges","archive_url":"https://api.github.com/repos/empoalp/gaia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/empoalp/gaia/downloads","issues_url":"https://api.github.com/repos/empoalp/gaia/issues{/number}","pulls_url":"https://api.github.com/repos/empoalp/gaia/pulls{/number}","milestones_url":"https://api.github.com/repos/empoalp/gaia/milestones{/number}","notifications_url":"https://api.github.com/repos/empoalp/gaia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/empoalp/gaia/labels{/name}","releases_url":"https://api.github.com/repos/empoalp/gaia/releases{/id}","created_at":"2014-06-04T14:21:58Z","updated_at":"2014-06-04T14:22:08Z","pushed_at":"2014-07-25T11:55:54Z","git_url":"git://github.com/empoalp/gaia.git","ssh_url":"git@github.com:empoalp/gaia.git","clone_url":"https://github.com/empoalp/gaia.git","svn_url":"https://github.com/empoalp/gaia","homepage":"https://wiki.mozilla.org/B2G","size":803373,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla-b2g:master","ref":"master","sha":"ce38a85582b3fa09021e8c5b37394b543dd39890","user":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?","gravatar_id":"b1de11f7d6ddaf7b9d527281297c2ee1","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"repo":{"id":2317369,"name":"gaia","full_name":"mozilla-b2g/gaia","owner":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?","gravatar_id":"b1de11f7d6ddaf7b9d527281297c2ee1","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-b2g/gaia","description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see","fork":false,"url":"https://api.github.com/repos/mozilla-b2g/gaia","forks_url":"https://api.github.com/repos/mozilla-b2g/gaia/forks","keys_url":"https://api.github.com/repos/mozilla-b2g/gaia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-b2g/gaia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-b2g/gaia/teams","hooks_url":"https://api.github.com/repos/mozilla-b2g/gaia/hooks","issue_events_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-b2g/gaia/events","assignees_url":"https://api.github.com/repos/mozilla-b2g/gaia/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-b2g/gaia/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-b2g/gaia/tags","blobs_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-b2g/gaia/languages","stargazers_url":"https://api.github.com/repos/mozilla-b2g/gaia/stargazers","contributors_url":"https://api.github.com/repos/mozilla-b2g/gaia/contributors","subscribers_url":"https://api.github.com/repos/mozilla-b2g/gaia/subscribers","subscription_url":"https://api.github.com/repos/mozilla-b2g/gaia/subscription","commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/comments/{number}","contents_url":"https://api.github.com/repos/mozilla-b2g/gaia/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-b2g/gaia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-b2g/gaia/merges","archive_url":"https://api.github.com/repos/mozilla-b2g/gaia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-b2g/gaia/downloads","issues_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-b2g/gaia/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-b2g/gaia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-b2g/gaia/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-b2g/gaia/releases{/id}","created_at":"2011-09-03T01:38:46Z","updated_at":"2014-07-25T06:42:07Z","pushed_at":"2014-07-28T03:12:00Z","git_url":"git://github.com/mozilla-b2g/gaia.git","ssh_url":"git@github.com:mozilla-b2g/gaia.git","clone_url":"https://github.com/mozilla-b2g/gaia.git","svn_url":"https://github.com/mozilla-b2g/gaia","homepage":"https://wiki.mozilla.org/B2G","size":1318440,"stargazers_count":1658,"watchers_count":1658,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":1732,"mirror_url":null,"open_issues_count":1805,"forks":1732,"open_issues":1805,"watchers":1658,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/22094"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/22094"},"issue":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/issues/22094"},"comments":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/issues/22094/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/22094/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/22094/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/3b1d5612911ed70d53487b8e7b134af8f527579c"}}}}