GitHub PullRequestEvent at 2014-09-24 23:41:16
Repository: susteq
Actor: opleban
Payload: {"action":"opened","number":9,"pull_request":{"url":"https://api.github.com/repos/DBC-Susteq/susteq/pulls/9","id":21752984,"html_url":"https://github.com/DBC-Susteq/susteq/pull/9","diff_url":"https://github.com/DBC-Susteq/susteq/pull/9.diff","patch_url":"https://github.com/DBC-Susteq/susteq/pull/9.patch","issue_url":"https://api.github.com/repos/DBC-Susteq/susteq/issues/9","number":9,"state":"open","locked":false,"title":"adds uniqueness validations for transactions","user":{"login":"opleban","id":5626206,"avatar_url":"https://avatars.githubusercontent.com/u/5626206?v=2","gravatar_id":"","url":"https://api.github.com/users/opleban","html_url":"https://github.com/opleban","followers_url":"https://api.github.com/users/opleban/followers","following_url":"https://api.github.com/users/opleban/following{/other_user}","gists_url":"https://api.github.com/users/opleban/gists{/gist_id}","starred_url":"https://api.github.com/users/opleban/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opleban/subscriptions","organizations_url":"https://api.github.com/users/opleban/orgs","repos_url":"https://api.github.com/users/opleban/repos","events_url":"https://api.github.com/users/opleban/events{/privacy}","received_events_url":"https://api.github.com/users/opleban/received_events","type":"User","site_admin":false},"body":"Per our conversation with Niels, I added a validation on the Transaction model that checks for uniqueness of new transactions based on the transaction_code scoped to by location_id and transaction_time. This means that any transaction that the validation will only check transactions that have have the same location_id and transaction_time before checking for uniqueness of the transaction_code in the db. I also added model and controller tests to ensure that it is functioning as expected.\r\n@melissa-mccoy ","created_at":"2014-09-24T23:41:15Z","updated_at":"2014-09-24T23:41:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ecb2272b7eb2f99d5958bda3ed513f387956e9ce","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/DBC-Susteq/susteq/pulls/9/commits","review_comments_url":"https://api.github.com/repos/DBC-Susteq/susteq/pulls/9/comments","review_comment_url":"https://api.github.com/repos/DBC-Susteq/susteq/pulls/comments/{number}","comments_url":"https://api.github.com/repos/DBC-Susteq/susteq/issues/9/comments","statuses_url":"https://api.github.com/repos/DBC-Susteq/susteq/statuses/3b978ff27b14a12ddb1ec547242ed4b16759f53c","head":{"label":"DBC-Susteq:op-uniqueness-validations-transactions","ref":"op-uniqueness-validations-transactions","sha":"3b978ff27b14a12ddb1ec547242ed4b16759f53c","user":{"login":"DBC-Susteq","id":8799007,"avatar_url":"https://avatars.githubusercontent.com/u/8799007?v=2","gravatar_id":"","url":"https://api.github.com/users/DBC-Susteq","html_url":"https://github.com/DBC-Susteq","followers_url":"https://api.github.com/users/DBC-Susteq/followers","following_url":"https://api.github.com/users/DBC-Susteq/following{/other_user}","gists_url":"https://api.github.com/users/DBC-Susteq/gists{/gist_id}","starred_url":"https://api.github.com/users/DBC-Susteq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DBC-Susteq/subscriptions","organizations_url":"https://api.github.com/users/DBC-Susteq/orgs","repos_url":"https://api.github.com/users/DBC-Susteq/repos","events_url":"https://api.github.com/users/DBC-Susteq/events{/privacy}","received_events_url":"https://api.github.com/users/DBC-Susteq/received_events","type":"Organization","site_admin":false},"repo":{"id":24122168,"name":"susteq","full_name":"DBC-Susteq/susteq","owner":{"login":"DBC-Susteq","id":8799007,"avatar_url":"https://avatars.githubusercontent.com/u/8799007?v=2","gravatar_id":"","url":"https://api.github.com/users/DBC-Susteq","html_url":"https://github.com/DBC-Susteq","followers_url":"https://api.github.com/users/DBC-Susteq/followers","following_url":"https://api.github.com/users/DBC-Susteq/following{/other_user}","gists_url":"https://api.github.com/users/DBC-Susteq/gists{/gist_id}","starred_url":"https://api.github.com/users/DBC-Susteq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DBC-Susteq/subscriptions","organizations_url":"https://api.github.com/users/DBC-Susteq/orgs","repos_url":"https://api.github.com/users/DBC-Susteq/repos","events_url":"https://api.github.com/users/DBC-Susteq/events{/privacy}","received_events_url":"https://api.github.com/users/DBC-Susteq/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DBC-Susteq/susteq","description":"End-to-End Water Hub Data Management Platform for Susteq Kenya","fork":false,"url":"https://api.github.com/repos/DBC-Susteq/susteq","forks_url":"https://api.github.com/repos/DBC-Susteq/susteq/forks","keys_url":"https://api.github.com/repos/DBC-Susteq/susteq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DBC-Susteq/susteq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DBC-Susteq/susteq/teams","hooks_url":"https://api.github.com/repos/DBC-Susteq/susteq/hooks","issue_events_url":"https://api.github.com/repos/DBC-Susteq/susteq/issues/events{/number}","events_url":"https://api.github.com/repos/DBC-Susteq/susteq/events","assignees_url":"https://api.github.com/repos/DBC-Susteq/susteq/assignees{/user}","branches_url":"https://api.github.com/repos/DBC-Susteq/susteq/branches{/branch}","tags_url":"https://api.github.com/repos/DBC-Susteq/susteq/tags","blobs_url":"https://api.github.com/repos/DBC-Susteq/susteq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DBC-Susteq/susteq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DBC-Susteq/susteq/git/refs{/sha}","trees_url":"https://api.github.com/repos/DBC-Susteq/susteq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DBC-Susteq/susteq/statuses/{sha}","languages_url":"https://api.github.com/repos/DBC-Susteq/susteq/languages","stargazers_url":"https://api.github.com/repos/DBC-Susteq/susteq/stargazers","contributors_url":"https://api.github.com/repos/DBC-Susteq/susteq/contributors","subscribers_url":"https://api.github.com/repos/DBC-Susteq/susteq/subscribers","subscription_url":"https://api.github.com/repos/DBC-Susteq/susteq/subscription","commits_url":"https://api.github.com/repos/DBC-Susteq/susteq/commits{/sha}","git_commits_url":"https://api.github.com/repos/DBC-Susteq/susteq/git/commits{/sha}","comments_url":"https://api.github.com/repos/DBC-Susteq/susteq/comments{/number}","issue_comment_url":"https://api.github.com/repos/DBC-Susteq/susteq/issues/comments/{number}","contents_url":"https://api.github.com/repos/DBC-Susteq/susteq/contents/{+path}","compare_url":"https://api.github.com/repos/DBC-Susteq/susteq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DBC-Susteq/susteq/merges","archive_url":"https://api.github.com/repos/DBC-Susteq/susteq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DBC-Susteq/susteq/downloads","issues_url":"https://api.github.com/repos/DBC-Susteq/susteq/issues{/number}","pulls_url":"https://api.github.com/repos/DBC-Susteq/susteq/pulls{/number}","milestones_url":"https://api.github.com/repos/DBC-Susteq/susteq/milestones{/number}","notifications_url":"https://api.github.com/repos/DBC-Susteq/susteq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DBC-Susteq/susteq/labels{/name}","releases_url":"https://api.github.com/repos/DBC-Susteq/susteq/releases{/id}","created_at":"2014-09-16T23:49:53Z","updated_at":"2014-09-22T14:41:41Z","pushed_at":"2014-09-24T23:38:16Z","git_url":"git://github.com/DBC-Susteq/susteq.git","ssh_url":"git@github.com:DBC-Susteq/susteq.git","clone_url":"https://github.com/DBC-Susteq/susteq.git","svn_url":"https://github.com/DBC-Susteq/susteq","homepage":null,"size":5728,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"DBC-Susteq:master","ref":"master","sha":"747a9851887a0f9ac58e71408cad50e8a34584d1","user":{"login":"DBC-Susteq","id":8799007,"avatar_url":"https://avatars.githubusercontent.com/u/8799007?v=2","gravatar_id":"","url":"https://api.github.com/users/DBC-Susteq","html_url":"https://github.com/DBC-Susteq","followers_url":"https://api.github.com/users/DBC-Susteq/followers","following_url":"https://api.github.com/users/DBC-Susteq/following{/other_user}","gists_url":"https://api.github.com/users/DBC-Susteq/gists{/gist_id}","starred_url":"https://api.github.com/users/DBC-Susteq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DBC-Susteq/subscriptions","organizations_url":"https://api.github.com/users/DBC-Susteq/orgs","repos_url":"https://api.github.com/users/DBC-Susteq/repos","events_url":"https://api.github.com/users/DBC-Susteq/events{/privacy}","received_events_url":"https://api.github.com/users/DBC-Susteq/received_events","type":"Organization","site_admin":false},"repo":{"id":24122168,"name":"susteq","full_name":"DBC-Susteq/susteq","owner":{"login":"DBC-Susteq","id":8799007,"avatar_url":"https://avatars.githubusercontent.com/u/8799007?v=2","gravatar_id":"","url":"https://api.github.com/users/DBC-Susteq","html_url":"https://github.com/DBC-Susteq","followers_url":"https://api.github.com/users/DBC-Susteq/followers","following_url":"https://api.github.com/users/DBC-Susteq/following{/other_user}","gists_url":"https://api.github.com/users/DBC-Susteq/gists{/gist_id}","starred_url":"https://api.github.com/users/DBC-Susteq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DBC-Susteq/subscriptions","organizations_url":"https://api.github.com/users/DBC-Susteq/orgs","repos_url":"https://api.github.com/users/DBC-Susteq/repos","events_url":"https://api.github.com/users/DBC-Susteq/events{/privacy}","received_events_url":"https://api.github.com/users/DBC-Susteq/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DBC-Susteq/susteq","description":"End-to-End Water Hub Data Management Platform for Susteq Kenya","fork":false,"url":"https://api.github.com/repos/DBC-Susteq/susteq","forks_url":"https://api.github.com/repos/DBC-Susteq/susteq/forks","keys_url":"https://api.github.com/repos/DBC-Susteq/susteq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DBC-Susteq/susteq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DBC-Susteq/susteq/teams","hooks_url":"https://api.github.com/repos/DBC-Susteq/susteq/hooks","issue_events_url":"https://api.github.com/repos/DBC-Susteq/susteq/issues/events{/number}","events_url":"https://api.github.com/repos/DBC-Susteq/susteq/events","assignees_url":"https://api.github.com/repos/DBC-Susteq/susteq/assignees{/user}","branches_url":"https://api.github.com/repos/DBC-Susteq/susteq/branches{/branch}","tags_url":"https://api.github.com/repos/DBC-Susteq/susteq/tags","blobs_url":"https://api.github.com/repos/DBC-Susteq/susteq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DBC-Susteq/susteq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DBC-Susteq/susteq/git/refs{/sha}","trees_url":"https://api.github.com/repos/DBC-Susteq/susteq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DBC-Susteq/susteq/statuses/{sha}","languages_url":"https://api.github.com/repos/DBC-Susteq/susteq/languages","stargazers_url":"https://api.github.com/repos/DBC-Susteq/susteq/stargazers","contributors_url":"https://api.github.com/repos/DBC-Susteq/susteq/contributors","subscribers_url":"https://api.github.com/repos/DBC-Susteq/susteq/subscribers","subscription_url":"https://api.github.com/repos/DBC-Susteq/susteq/subscription","commits_url":"https://api.github.com/repos/DBC-Susteq/susteq/commits{/sha}","git_commits_url":"https://api.github.com/repos/DBC-Susteq/susteq/git/commits{/sha}","comments_url":"https://api.github.com/repos/DBC-Susteq/susteq/comments{/number}","issue_comment_url":"https://api.github.com/repos/DBC-Susteq/susteq/issues/comments/{number}","contents_url":"https://api.github.com/repos/DBC-Susteq/susteq/contents/{+path}","compare_url":"https://api.github.com/repos/DBC-Susteq/susteq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DBC-Susteq/susteq/merges","archive_url":"https://api.github.com/repos/DBC-Susteq/susteq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DBC-Susteq/susteq/downloads","issues_url":"https://api.github.com/repos/DBC-Susteq/susteq/issues{/number}","pulls_url":"https://api.github.com/repos/DBC-Susteq/susteq/pulls{/number}","milestones_url":"https://api.github.com/repos/DBC-Susteq/susteq/milestones{/number}","notifications_url":"https://api.github.com/repos/DBC-Susteq/susteq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DBC-Susteq/susteq/labels{/name}","releases_url":"https://api.github.com/repos/DBC-Susteq/susteq/releases{/id}","created_at":"2014-09-16T23:49:53Z","updated_at":"2014-09-22T14:41:41Z","pushed_at":"2014-09-24T23:38:16Z","git_url":"git://github.com/DBC-Susteq/susteq.git","ssh_url":"git@github.com:DBC-Susteq/susteq.git","clone_url":"https://github.com/DBC-Susteq/susteq.git","svn_url":"https://github.com/DBC-Susteq/susteq","homepage":null,"size":5728,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DBC-Susteq/susteq/pulls/9"},"html":{"href":"https://github.com/DBC-Susteq/susteq/pull/9"},"issue":{"href":"https://api.github.com/repos/DBC-Susteq/susteq/issues/9"},"comments":{"href":"https://api.github.com/repos/DBC-Susteq/susteq/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/DBC-Susteq/susteq/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/DBC-Susteq/susteq/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/DBC-Susteq/susteq/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/DBC-Susteq/susteq/statuses/3b978ff27b14a12ddb1ec547242ed4b16759f53c"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":3,"additions":40,"deletions":2,"changed_files":4}}