GitHub PullRequestReviewCommentEvent at 2014-06-26 18:12:42
Repository: mailcore.node
Actor: dinhviethoa
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/MailCore/mailcore.node/pulls/comments/14256265","id":14256265,"diff_hunk":"@@ -0,0 +1,128 @@\n+\"use strict\"\n+\n+var util = require('util');\n+var EE = require('events').EventEmitter;\n+var Constants = require('libetpan').Constants;\n+var IMAPBase = require('./imapbase').IMAPBase;\n+var IMAPSet = require('./imapset').IMAPSet;\n+\n+util.inherits(IMAPSession, EE);","path":"lib/imapsession.js","position":9,"original_position":9,"commit_id":"96e1ff838607923dfa1455e66b0f4bccabbdb2c1","original_commit_id":"96e1ff838607923dfa1455e66b0f4bccabbdb2c1","user":{"login":"dinhviethoa","id":332168,"avatar_url":"https://avatars.githubusercontent.com/u/332168?","gravatar_id":"6b2f37933bf38e2d22949f316e751757","url":"https://api.github.com/users/dinhviethoa","html_url":"https://github.com/dinhviethoa","followers_url":"https://api.github.com/users/dinhviethoa/followers","following_url":"https://api.github.com/users/dinhviethoa/following{/other_user}","gists_url":"https://api.github.com/users/dinhviethoa/gists{/gist_id}","starred_url":"https://api.github.com/users/dinhviethoa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dinhviethoa/subscriptions","organizations_url":"https://api.github.com/users/dinhviethoa/orgs","repos_url":"https://api.github.com/users/dinhviethoa/repos","events_url":"https://api.github.com/users/dinhviethoa/events{/privacy}","received_events_url":"https://api.github.com/users/dinhviethoa/received_events","type":"User","site_admin":false},"body":"Ok. After reading bunch of nodejs code, it sounds like it's a nodejs idiom. Then, what's the convention: an error is emitted when there's an issue and the callback is called when everything went fine, except for connect()?","created_at":"2014-06-26T18:12:42Z","updated_at":"2014-06-26T18:12:42Z","html_url":"https://github.com/MailCore/mailcore.node/pull/1#discussion_r14256265","pull_request_url":"https://api.github.com/repos/MailCore/mailcore.node/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/MailCore/mailcore.node/pulls/comments/14256265"},"html":{"href":"https://github.com/MailCore/mailcore.node/pull/1#discussion_r14256265"},"pull_request":{"href":"https://api.github.com/repos/MailCore/mailcore.node/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/MailCore/mailcore.node/pulls/1","id":17577639,"html_url":"https://github.com/MailCore/mailcore.node/pull/1","diff_url":"https://github.com/MailCore/mailcore.node/pull/1.diff","patch_url":"https://github.com/MailCore/mailcore.node/pull/1.patch","issue_url":"https://api.github.com/repos/MailCore/mailcore.node/issues/1","number":1,"state":"open","title":"Very Basic PR","user":{"login":"yorkie","id":1935767,"avatar_url":"https://avatars.githubusercontent.com/u/1935767?","gravatar_id":"da7785811a5d9844f0bee77c3ef4a045","url":"https://api.github.com/users/yorkie","html_url":"https://github.com/yorkie","followers_url":"https://api.github.com/users/yorkie/followers","following_url":"https://api.github.com/users/yorkie/following{/other_user}","gists_url":"https://api.github.com/users/yorkie/gists{/gist_id}","starred_url":"https://api.github.com/users/yorkie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yorkie/subscriptions","organizations_url":"https://api.github.com/users/yorkie/orgs","repos_url":"https://api.github.com/users/yorkie/repos","events_url":"https://api.github.com/users/yorkie/events{/privacy}","received_events_url":"https://api.github.com/users/yorkie/received_events","type":"User","site_admin":false},"body":"Hi, @dinhviethoa,\r\nI just wrote some basic stuffs(most on structure) and could you please review my source codes, if i make some errors, let me know.\r\n\r\nOtherwise, this PR also is a complete PR but within some TODO for us, So you could run the `example.js` to check the functionality of mine.\r\n\r\nAlso /cc @MailCore's other members :)","created_at":"2014-06-25T08:36:01Z","updated_at":"2014-06-26T18:12:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f5e4a69d887e6a5a938b811c27998589ca1b4d2f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/MailCore/mailcore.node/pulls/1/commits","review_comments_url":"https://api.github.com/repos/MailCore/mailcore.node/pulls/1/comments","review_comment_url":"https://api.github.com/repos/MailCore/mailcore.node/pulls/comments/{number}","comments_url":"https://api.github.com/repos/MailCore/mailcore.node/issues/1/comments","statuses_url":"https://api.github.com/repos/MailCore/mailcore.node/statuses/96e1ff838607923dfa1455e66b0f4bccabbdb2c1","head":{"label":"yorkie:master","ref":"master","sha":"96e1ff838607923dfa1455e66b0f4bccabbdb2c1","user":{"login":"yorkie","id":1935767,"avatar_url":"https://avatars.githubusercontent.com/u/1935767?","gravatar_id":"da7785811a5d9844f0bee77c3ef4a045","url":"https://api.github.com/users/yorkie","html_url":"https://github.com/yorkie","followers_url":"https://api.github.com/users/yorkie/followers","following_url":"https://api.github.com/users/yorkie/following{/other_user}","gists_url":"https://api.github.com/users/yorkie/gists{/gist_id}","starred_url":"https://api.github.com/users/yorkie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yorkie/subscriptions","organizations_url":"https://api.github.com/users/yorkie/orgs","repos_url":"https://api.github.com/users/yorkie/repos","events_url":"https://api.github.com/users/yorkie/events{/privacy}","received_events_url":"https://api.github.com/users/yorkie/received_events","type":"User","site_admin":false},"repo":{"id":21064175,"name":"mailcore.node","full_name":"yorkie/mailcore.node","owner":{"login":"yorkie","id":1935767,"avatar_url":"https://avatars.githubusercontent.com/u/1935767?","gravatar_id":"da7785811a5d9844f0bee77c3ef4a045","url":"https://api.github.com/users/yorkie","html_url":"https://github.com/yorkie","followers_url":"https://api.github.com/users/yorkie/followers","following_url":"https://api.github.com/users/yorkie/following{/other_user}","gists_url":"https://api.github.com/users/yorkie/gists{/gist_id}","starred_url":"https://api.github.com/users/yorkie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yorkie/subscriptions","organizations_url":"https://api.github.com/users/yorkie/orgs","repos_url":"https://api.github.com/users/yorkie/repos","events_url":"https://api.github.com/users/yorkie/events{/privacy}","received_events_url":"https://api.github.com/users/yorkie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yorkie/mailcore.node","description":"MailCore provide a simple API to work with e-mail protocols IMAP, POP and SMTP on NodeJS","fork":true,"url":"https://api.github.com/repos/yorkie/mailcore.node","forks_url":"https://api.github.com/repos/yorkie/mailcore.node/forks","keys_url":"https://api.github.com/repos/yorkie/mailcore.node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yorkie/mailcore.node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yorkie/mailcore.node/teams","hooks_url":"https://api.github.com/repos/yorkie/mailcore.node/hooks","issue_events_url":"https://api.github.com/repos/yorkie/mailcore.node/issues/events{/number}","events_url":"https://api.github.com/repos/yorkie/mailcore.node/events","assignees_url":"https://api.github.com/repos/yorkie/mailcore.node/assignees{/user}","branches_url":"https://api.github.com/repos/yorkie/mailcore.node/branches{/branch}","tags_url":"https://api.github.com/repos/yorkie/mailcore.node/tags","blobs_url":"https://api.github.com/repos/yorkie/mailcore.node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yorkie/mailcore.node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yorkie/mailcore.node/git/refs{/sha}","trees_url":"https://api.github.com/repos/yorkie/mailcore.node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yorkie/mailcore.node/statuses/{sha}","languages_url":"https://api.github.com/repos/yorkie/mailcore.node/languages","stargazers_url":"https://api.github.com/repos/yorkie/mailcore.node/stargazers","contributors_url":"https://api.github.com/repos/yorkie/mailcore.node/contributors","subscribers_url":"https://api.github.com/repos/yorkie/mailcore.node/subscribers","subscription_url":"https://api.github.com/repos/yorkie/mailcore.node/subscription","commits_url":"https://api.github.com/repos/yorkie/mailcore.node/commits{/sha}","git_commits_url":"https://api.github.com/repos/yorkie/mailcore.node/git/commits{/sha}","comments_url":"https://api.github.com/repos/yorkie/mailcore.node/comments{/number}","issue_comment_url":"https://api.github.com/repos/yorkie/mailcore.node/issues/comments/{number}","contents_url":"https://api.github.com/repos/yorkie/mailcore.node/contents/{+path}","compare_url":"https://api.github.com/repos/yorkie/mailcore.node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yorkie/mailcore.node/merges","archive_url":"https://api.github.com/repos/yorkie/mailcore.node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yorkie/mailcore.node/downloads","issues_url":"https://api.github.com/repos/yorkie/mailcore.node/issues{/number}","pulls_url":"https://api.github.com/repos/yorkie/mailcore.node/pulls{/number}","milestones_url":"https://api.github.com/repos/yorkie/mailcore.node/milestones{/number}","notifications_url":"https://api.github.com/repos/yorkie/mailcore.node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yorkie/mailcore.node/labels{/name}","releases_url":"https://api.github.com/repos/yorkie/mailcore.node/releases{/id}","created_at":"2014-06-21T08:39:19Z","updated_at":"2014-06-26T03:34:16Z","pushed_at":"2014-06-26T08:17:41Z","git_url":"git://github.com/yorkie/mailcore.node.git","ssh_url":"git@github.com:yorkie/mailcore.node.git","clone_url":"https://github.com/yorkie/mailcore.node.git","svn_url":"https://github.com/yorkie/mailcore.node","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"MailCore:master","ref":"master","sha":"c220c1fa4569f10b1c76cf3dd344796f19c3ab1e","user":{"login":"MailCore","id":3229324,"avatar_url":"https://avatars.githubusercontent.com/u/3229324?","gravatar_id":"80e361992ec45832a07910224b292da6","url":"https://api.github.com/users/MailCore","html_url":"https://github.com/MailCore","followers_url":"https://api.github.com/users/MailCore/followers","following_url":"https://api.github.com/users/MailCore/following{/other_user}","gists_url":"https://api.github.com/users/MailCore/gists{/gist_id}","starred_url":"https://api.github.com/users/MailCore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MailCore/subscriptions","organizations_url":"https://api.github.com/users/MailCore/orgs","repos_url":"https://api.github.com/users/MailCore/repos","events_url":"https://api.github.com/users/MailCore/events{/privacy}","received_events_url":"https://api.github.com/users/MailCore/received_events","type":"Organization","site_admin":false},"repo":{"id":21045183,"name":"mailcore.node","full_name":"MailCore/mailcore.node","owner":{"login":"MailCore","id":3229324,"avatar_url":"https://avatars.githubusercontent.com/u/3229324?","gravatar_id":"80e361992ec45832a07910224b292da6","url":"https://api.github.com/users/MailCore","html_url":"https://github.com/MailCore","followers_url":"https://api.github.com/users/MailCore/followers","following_url":"https://api.github.com/users/MailCore/following{/other_user}","gists_url":"https://api.github.com/users/MailCore/gists{/gist_id}","starred_url":"https://api.github.com/users/MailCore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MailCore/subscriptions","organizations_url":"https://api.github.com/users/MailCore/orgs","repos_url":"https://api.github.com/users/MailCore/repos","events_url":"https://api.github.com/users/MailCore/events{/privacy}","received_events_url":"https://api.github.com/users/MailCore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MailCore/mailcore.node","description":"MailCore provide a simple API to work with e-mail protocols IMAP, POP and SMTP on NodeJS","fork":false,"url":"https://api.github.com/repos/MailCore/mailcore.node","forks_url":"https://api.github.com/repos/MailCore/mailcore.node/forks","keys_url":"https://api.github.com/repos/MailCore/mailcore.node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MailCore/mailcore.node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MailCore/mailcore.node/teams","hooks_url":"https://api.github.com/repos/MailCore/mailcore.node/hooks","issue_events_url":"https://api.github.com/repos/MailCore/mailcore.node/issues/events{/number}","events_url":"https://api.github.com/repos/MailCore/mailcore.node/events","assignees_url":"https://api.github.com/repos/MailCore/mailcore.node/assignees{/user}","branches_url":"https://api.github.com/repos/MailCore/mailcore.node/branches{/branch}","tags_url":"https://api.github.com/repos/MailCore/mailcore.node/tags","blobs_url":"https://api.github.com/repos/MailCore/mailcore.node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MailCore/mailcore.node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MailCore/mailcore.node/git/refs{/sha}","trees_url":"https://api.github.com/repos/MailCore/mailcore.node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MailCore/mailcore.node/statuses/{sha}","languages_url":"https://api.github.com/repos/MailCore/mailcore.node/languages","stargazers_url":"https://api.github.com/repos/MailCore/mailcore.node/stargazers","contributors_url":"https://api.github.com/repos/MailCore/mailcore.node/contributors","subscribers_url":"https://api.github.com/repos/MailCore/mailcore.node/subscribers","subscription_url":"https://api.github.com/repos/MailCore/mailcore.node/subscription","commits_url":"https://api.github.com/repos/MailCore/mailcore.node/commits{/sha}","git_commits_url":"https://api.github.com/repos/MailCore/mailcore.node/git/commits{/sha}","comments_url":"https://api.github.com/repos/MailCore/mailcore.node/comments{/number}","issue_comment_url":"https://api.github.com/repos/MailCore/mailcore.node/issues/comments/{number}","contents_url":"https://api.github.com/repos/MailCore/mailcore.node/contents/{+path}","compare_url":"https://api.github.com/repos/MailCore/mailcore.node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MailCore/mailcore.node/merges","archive_url":"https://api.github.com/repos/MailCore/mailcore.node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MailCore/mailcore.node/downloads","issues_url":"https://api.github.com/repos/MailCore/mailcore.node/issues{/number}","pulls_url":"https://api.github.com/repos/MailCore/mailcore.node/pulls{/number}","milestones_url":"https://api.github.com/repos/MailCore/mailcore.node/milestones{/number}","notifications_url":"https://api.github.com/repos/MailCore/mailcore.node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MailCore/mailcore.node/labels{/name}","releases_url":"https://api.github.com/repos/MailCore/mailcore.node/releases{/id}","created_at":"2014-06-20T16:49:10Z","updated_at":"2014-06-23T04:21:40Z","pushed_at":"2014-06-20T16:49:11Z","git_url":"git://github.com/MailCore/mailcore.node.git","ssh_url":"git@github.com:MailCore/mailcore.node.git","clone_url":"https://github.com/MailCore/mailcore.node.git","svn_url":"https://github.com/MailCore/mailcore.node","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MailCore/mailcore.node/pulls/1"},"html":{"href":"https://github.com/MailCore/mailcore.node/pull/1"},"issue":{"href":"https://api.github.com/repos/MailCore/mailcore.node/issues/1"},"comments":{"href":"https://api.github.com/repos/MailCore/mailcore.node/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/MailCore/mailcore.node/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/MailCore/mailcore.node/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/MailCore/mailcore.node/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/MailCore/mailcore.node/statuses/96e1ff838607923dfa1455e66b0f4bccabbdb2c1"}}}}