GitHub PullRequestEvent at 2014-03-31 11:06:05
Repository: spark
Actor: darabos
Payload: {"action":"opened","number":276,"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/276","id":14169984,"html_url":"https://github.com/apache/spark/pull/276","diff_url":"https://github.com/apache/spark/pull/276.diff","patch_url":"https://github.com/apache/spark/pull/276.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/276","number":276,"state":"open","title":"Do not re-use objects in the EdgePartition/EdgeTriplet iterators.","user":{"login":"darabos","id":1268018,"avatar_url":"https://avatars.githubusercontent.com/u/1268018?","gravatar_id":"fa52f0ed961993dce0a5c271dca0b4b7","url":"https://api.github.com/users/darabos","html_url":"https://github.com/darabos","followers_url":"https://api.github.com/users/darabos/followers","following_url":"https://api.github.com/users/darabos/following{/other_user}","gists_url":"https://api.github.com/users/darabos/gists{/gist_id}","starred_url":"https://api.github.com/users/darabos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darabos/subscriptions","organizations_url":"https://api.github.com/users/darabos/orgs","repos_url":"https://api.github.com/users/darabos/repos","events_url":"https://api.github.com/users/darabos/events{/privacy}","received_events_url":"https://api.github.com/users/darabos/received_events","type":"User","site_admin":false},"body":"This avoids a silent data corruption issue (https://spark-project.atlassian.net/browse/SPARK-1188) and has no performance impact by my measurements. It also simplifies the code. As far as I can tell the object re-use was nothing but premature optimization.\r\n\r\nI did actual benchmarks for all the included changes, and there is no performance difference. I am not sure where to put the benchmarks. Does Spark not have a benchmark suite?\r\n\r\nThis is an example benchmark I did:\r\n\r\ntest(\"benchmark\") {\r\n  val builder = new EdgePartitionBuilder[Int]\r\n  for (i <- (1 to 10000000)) {\r\n    builder.add(i.toLong, i.toLong, i)\r\n  }\r\n  val p = builder.toEdgePartition\r\n  p.map(_.attr + 1).iterator.toList\r\n}\r\n\r\nIt ran for 10 seconds both before and after this change.","created_at":"2014-03-31T11:06:05Z","updated_at":"2014-03-31T11:06:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/276/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/276/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments/{number}","comments_url":"https://api.github.com/repos/apache/spark/issues/276/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/0182f2b329b2bb6e6ca8c41245f09db83b71908b","head":{"label":"darabos:spark-1188","ref":"spark-1188","sha":"0182f2b329b2bb6e6ca8c41245f09db83b71908b","user":{"login":"darabos","id":1268018,"avatar_url":"https://avatars.githubusercontent.com/u/1268018?","gravatar_id":"fa52f0ed961993dce0a5c271dca0b4b7","url":"https://api.github.com/users/darabos","html_url":"https://github.com/darabos","followers_url":"https://api.github.com/users/darabos/followers","following_url":"https://api.github.com/users/darabos/following{/other_user}","gists_url":"https://api.github.com/users/darabos/gists{/gist_id}","starred_url":"https://api.github.com/users/darabos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darabos/subscriptions","organizations_url":"https://api.github.com/users/darabos/orgs","repos_url":"https://api.github.com/users/darabos/repos","events_url":"https://api.github.com/users/darabos/events{/privacy}","received_events_url":"https://api.github.com/users/darabos/received_events","type":"User","site_admin":false},"repo":{"id":17916058,"name":"spark","full_name":"darabos/spark","owner":{"login":"darabos","id":1268018,"avatar_url":"https://avatars.githubusercontent.com/u/1268018?","gravatar_id":"fa52f0ed961993dce0a5c271dca0b4b7","url":"https://api.github.com/users/darabos","html_url":"https://github.com/darabos","followers_url":"https://api.github.com/users/darabos/followers","following_url":"https://api.github.com/users/darabos/following{/other_user}","gists_url":"https://api.github.com/users/darabos/gists{/gist_id}","starred_url":"https://api.github.com/users/darabos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darabos/subscriptions","organizations_url":"https://api.github.com/users/darabos/orgs","repos_url":"https://api.github.com/users/darabos/repos","events_url":"https://api.github.com/users/darabos/events{/privacy}","received_events_url":"https://api.github.com/users/darabos/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/darabos/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/darabos/spark","forks_url":"https://api.github.com/repos/darabos/spark/forks","keys_url":"https://api.github.com/repos/darabos/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/darabos/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/darabos/spark/teams","hooks_url":"https://api.github.com/repos/darabos/spark/hooks","issue_events_url":"https://api.github.com/repos/darabos/spark/issues/events{/number}","events_url":"https://api.github.com/repos/darabos/spark/events","assignees_url":"https://api.github.com/repos/darabos/spark/assignees{/user}","branches_url":"https://api.github.com/repos/darabos/spark/branches{/branch}","tags_url":"https://api.github.com/repos/darabos/spark/tags","blobs_url":"https://api.github.com/repos/darabos/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/darabos/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/darabos/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/darabos/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/darabos/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/darabos/spark/languages","stargazers_url":"https://api.github.com/repos/darabos/spark/stargazers","contributors_url":"https://api.github.com/repos/darabos/spark/contributors","subscribers_url":"https://api.github.com/repos/darabos/spark/subscribers","subscription_url":"https://api.github.com/repos/darabos/spark/subscription","commits_url":"https://api.github.com/repos/darabos/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/darabos/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/darabos/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/darabos/spark/issues/comments/{number}","contents_url":"https://api.github.com/repos/darabos/spark/contents/{+path}","compare_url":"https://api.github.com/repos/darabos/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/darabos/spark/merges","archive_url":"https://api.github.com/repos/darabos/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/darabos/spark/downloads","issues_url":"https://api.github.com/repos/darabos/spark/issues{/number}","pulls_url":"https://api.github.com/repos/darabos/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/darabos/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/darabos/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/darabos/spark/labels{/name}","releases_url":"https://api.github.com/repos/darabos/spark/releases{/id}","created_at":"2014-03-19T18:42:58Z","updated_at":"2014-03-31T11:06:05Z","pushed_at":"2014-03-31T11:01:13Z","git_url":"git://github.com/darabos/spark.git","ssh_url":"git@github.com:darabos/spark.git","clone_url":"https://github.com/darabos/spark.git","svn_url":"https://github.com/darabos/spark","homepage":null,"size":62477,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master","master_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"d666053679ded5a32088c1758d20101126e23af6","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?","gravatar_id":"a676c0bf448fcd49f588249ead719b4c","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?","gravatar_id":"a676c0bf448fcd49f588249ead719b4c","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments/{number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","created_at":"2014-02-25T08:00:08Z","updated_at":"2014-03-30T17:55:42Z","pushed_at":"2014-03-30T17:55:41Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":309459,"stargazers_count":136,"watchers_count":136,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":194,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":78,"forks":194,"open_issues":78,"watchers":136,"default_branch":"master","master_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/276"},"html":{"href":"https://github.com/apache/spark/pull/276"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/276"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/276/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/276/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/276/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/0182f2b329b2bb6e6ca8c41245f09db83b71908b"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":59,"deletions":43,"changed_files":4}}