GitHub PullRequestReviewCommentEvent at 2014-05-13 13:39:41
Repository: parse-ruby-client
Actor: ericcj
Payload: {"comment":{"url":"https://api.github.com/repos/adelevie/parse-ruby-client/pulls/comments/12582864","id":12582864,"diff_hunk":"@@ -29,27 +26,26 @@ def initialize(data = {})\n       @session_token  = data[:session_token]\n       @max_retries    = data[:max_retries] || 3\n       @logger         = data[:logger] || Logger.new(STDERR).tap{|l| l.level = Logger::INFO}\n-      @session        = data[:http_client] || Parse::DEFAULT_HTTP_CLIENT.new\n \n-      if data[:ironio_project_id] && data[:ironio_token]\n+      options = {:request => {:timeout => 30, :open_timeout => 30}}\n \n-        if data[:max_concurrent_requests]\n-          @max_concurrent_requests = data[:max_concurrent_requests]\n-        else\n-          @max_concurrent_requests = 50\n-        end\n+      @session = Faraday.new(\"https://#{host}\", options) do |c|\n+        c.request :json\n+        c.response :logger, @logger\n \n-        @queue = IronMQ::Client.new({\n-          :project_id => data[:ironio_project_id],\n-          :token => data[:ironio_token]\n-        }).queue(\"concurrent_parse_requests\")\n+        c.use Faraday::GetMethodOverride\n \n-      end\n+        c.use Faraday::BetterRetry,\n+          max: @max_retries,\n+          logger: @logger,\n+          interval: 0.5,","path":"lib/parse/client.rb","position":51,"original_position":51,"commit_id":"a4eb5618c8167e88857b449cd522b23a8b0c02e9","original_commit_id":"a4eb5618c8167e88857b449cd522b23a8b0c02e9","user":{"login":"ericcj","id":53106,"avatar_url":"https://avatars.githubusercontent.com/u/53106?","gravatar_id":"e74cd75b9287ce05435500e97b1dedcd","url":"https://api.github.com/users/ericcj","html_url":"https://github.com/ericcj","followers_url":"https://api.github.com/users/ericcj/followers","following_url":"https://api.github.com/users/ericcj/following{/other_user}","gists_url":"https://api.github.com/users/ericcj/gists{/gist_id}","starred_url":"https://api.github.com/users/ericcj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericcj/subscriptions","organizations_url":"https://api.github.com/users/ericcj/orgs","repos_url":"https://api.github.com/users/ericcj/repos","events_url":"https://api.github.com/users/ericcj/events{/privacy}","received_events_url":"https://api.github.com/users/ericcj/received_events","type":"User","site_admin":false},"body":"this may or may not be desirable, but it's probably best to leave it as it was with no sleep between retries for now","created_at":"2014-05-13T13:39:41Z","updated_at":"2014-05-13T13:39:41Z","html_url":"https://github.com/adelevie/parse-ruby-client/pull/123#discussion_r12582864","pull_request_url":"https://api.github.com/repos/adelevie/parse-ruby-client/pulls/123","_links":{"self":{"href":"https://api.github.com/repos/adelevie/parse-ruby-client/pulls/comments/12582864"},"html":{"href":"https://github.com/adelevie/parse-ruby-client/pull/123#discussion_r12582864"},"pull_request":{"href":"https://api.github.com/repos/adelevie/parse-ruby-client/pulls/123"}}}}