GitHub PullRequestEvent at 2014-06-05 09:40:51
Repository: frontend
Actor: kaelig
Payload: {"action":"closed","number":4519,"pull_request":{"url":"https://api.github.com/repos/guardian/frontend/pulls/4519","id":16591692,"html_url":"https://github.com/guardian/frontend/pull/4519","diff_url":"https://github.com/guardian/frontend/pull/4519.diff","patch_url":"https://github.com/guardian/frontend/pull/4519.patch","issue_url":"https://api.github.com/repos/guardian/frontend/issues/4519","number":4519,"state":"closed","title":"SVG sprite optimisation: urlencoded","user":{"login":"kaelig","id":85783,"avatar_url":"https://avatars.githubusercontent.com/u/85783?","gravatar_id":"f7e7b837bd06d6193f4ac70f17e6f44b","url":"https://api.github.com/users/kaelig","html_url":"https://github.com/kaelig","followers_url":"https://api.github.com/users/kaelig/followers","following_url":"https://api.github.com/users/kaelig/following{/other_user}","gists_url":"https://api.github.com/users/kaelig/gists{/gist_id}","starred_url":"https://api.github.com/users/kaelig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaelig/subscriptions","organizations_url":"https://api.github.com/users/kaelig/orgs","repos_url":"https://api.github.com/users/kaelig/repos","events_url":"https://api.github.com/users/kaelig/events{/privacy}","received_events_url":"https://api.github.com/users/kaelig/received_events","type":"User","site_admin":false},"body":"Take 2 on the #4381 PR\r\n\r\n- Sprites are URLEncoded (should work in all browsers)\r\n- Compiles well on Ruby 1.8.7\r\n\r\n### Gains\r\n\r\n**Before:**_global-icons-svg-base64.scss 107KB\r\n**After:** _global-icons-svg-utf8.scss 100KB\r\n\r\n**Before:**_global-icons-svg-base64.scss.gz 28KB\r\n**After:** _global-icons-svg-utf8.scss.gz 22KB\r\n\r\n**Before:** _commercial-icons-svg-base64.scss 31KB\r\n**After:** _commercial-icons-svg-utf8.scss 26KB\r\n\r\n**Before:**_commercial-icons-svg-base64.scss.gz 10KB\r\n**After:** _commercial-icons-svg-utf8.scss.gz 6KB\r\n\r\nIt would be great to have a cross browser testing session on this branch @mstorijo \r\n\r\n![ ](http://gifs.joelglovier.com/oh-shit/refreshing.gif)","created_at":"2014-06-02T10:18:44Z","updated_at":"2014-06-05T09:40:50Z","closed_at":"2014-06-05T09:40:50Z","merged_at":"2014-06-05T09:40:50Z","merge_commit_sha":"1b797fd41fbe41a6d40bacc6631820be531b6a9c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/guardian/frontend/pulls/4519/commits","review_comments_url":"https://api.github.com/repos/guardian/frontend/pulls/4519/comments","review_comment_url":"https://api.github.com/repos/guardian/frontend/pulls/comments/{number}","comments_url":"https://api.github.com/repos/guardian/frontend/issues/4519/comments","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/8f6ddc4f0dacd915604e1dbad560bde3d99ce047","head":{"label":"guardian:svg-sprite-optimisation-urlencoded","ref":"svg-sprite-optimisation-urlencoded","sha":"8f6ddc4f0dacd915604e1dbad560bde3d99ce047","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?","gravatar_id":"2ddf2e74b78084fcf451b3cdeb075e73","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":4370755,"name":"frontend","full_name":"guardian/frontend","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?","gravatar_id":"2ddf2e74b78084fcf451b3cdeb075e73","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/frontend","description":"Source for the Guardian's responsive site, coming soon to a desktop near you...","fork":false,"url":"https://api.github.com/repos/guardian/frontend","forks_url":"https://api.github.com/repos/guardian/frontend/forks","keys_url":"https://api.github.com/repos/guardian/frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/frontend/teams","hooks_url":"https://api.github.com/repos/guardian/frontend/hooks","issue_events_url":"https://api.github.com/repos/guardian/frontend/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/frontend/events","assignees_url":"https://api.github.com/repos/guardian/frontend/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/frontend/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/frontend/tags","blobs_url":"https://api.github.com/repos/guardian/frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/frontend/languages","stargazers_url":"https://api.github.com/repos/guardian/frontend/stargazers","contributors_url":"https://api.github.com/repos/guardian/frontend/contributors","subscribers_url":"https://api.github.com/repos/guardian/frontend/subscribers","subscription_url":"https://api.github.com/repos/guardian/frontend/subscription","commits_url":"https://api.github.com/repos/guardian/frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/frontend/issues/comments/{number}","contents_url":"https://api.github.com/repos/guardian/frontend/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/frontend/merges","archive_url":"https://api.github.com/repos/guardian/frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/frontend/downloads","issues_url":"https://api.github.com/repos/guardian/frontend/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/frontend/labels{/name}","releases_url":"https://api.github.com/repos/guardian/frontend/releases{/id}","created_at":"2012-05-18T15:39:15Z","updated_at":"2014-06-05T09:40:50Z","pushed_at":"2014-06-05T09:40:50Z","git_url":"git://github.com/guardian/frontend.git","ssh_url":"git@github.com:guardian/frontend.git","clone_url":"https://github.com/guardian/frontend.git","svn_url":"https://github.com/guardian/frontend","homepage":"http://www.theguardian.com/uk?view=mobile","size":369117,"stargazers_count":2099,"watchers_count":2099,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":175,"mirror_url":null,"open_issues_count":79,"forks":175,"open_issues":79,"watchers":2099,"default_branch":"master"}},"base":{"label":"guardian:master","ref":"master","sha":"ba3253bfd2a4a74af2463c1165a6536dae6c35c2","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?","gravatar_id":"2ddf2e74b78084fcf451b3cdeb075e73","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":4370755,"name":"frontend","full_name":"guardian/frontend","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?","gravatar_id":"2ddf2e74b78084fcf451b3cdeb075e73","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/frontend","description":"Source for the Guardian's responsive site, coming soon to a desktop near you...","fork":false,"url":"https://api.github.com/repos/guardian/frontend","forks_url":"https://api.github.com/repos/guardian/frontend/forks","keys_url":"https://api.github.com/repos/guardian/frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/frontend/teams","hooks_url":"https://api.github.com/repos/guardian/frontend/hooks","issue_events_url":"https://api.github.com/repos/guardian/frontend/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/frontend/events","assignees_url":"https://api.github.com/repos/guardian/frontend/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/frontend/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/frontend/tags","blobs_url":"https://api.github.com/repos/guardian/frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/frontend/languages","stargazers_url":"https://api.github.com/repos/guardian/frontend/stargazers","contributors_url":"https://api.github.com/repos/guardian/frontend/contributors","subscribers_url":"https://api.github.com/repos/guardian/frontend/subscribers","subscription_url":"https://api.github.com/repos/guardian/frontend/subscription","commits_url":"https://api.github.com/repos/guardian/frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/frontend/issues/comments/{number}","contents_url":"https://api.github.com/repos/guardian/frontend/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/frontend/merges","archive_url":"https://api.github.com/repos/guardian/frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/frontend/downloads","issues_url":"https://api.github.com/repos/guardian/frontend/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/frontend/labels{/name}","releases_url":"https://api.github.com/repos/guardian/frontend/releases{/id}","created_at":"2012-05-18T15:39:15Z","updated_at":"2014-06-05T09:40:50Z","pushed_at":"2014-06-05T09:40:50Z","git_url":"git://github.com/guardian/frontend.git","ssh_url":"git@github.com:guardian/frontend.git","clone_url":"https://github.com/guardian/frontend.git","svn_url":"https://github.com/guardian/frontend","homepage":"http://www.theguardian.com/uk?view=mobile","size":369117,"stargazers_count":2099,"watchers_count":2099,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":175,"mirror_url":null,"open_issues_count":79,"forks":175,"open_issues":79,"watchers":2099,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/guardian/frontend/pulls/4519"},"html":{"href":"https://github.com/guardian/frontend/pull/4519"},"issue":{"href":"https://api.github.com/repos/guardian/frontend/issues/4519"},"comments":{"href":"https://api.github.com/repos/guardian/frontend/issues/4519/comments"},"review_comments":{"href":"https://api.github.com/repos/guardian/frontend/pulls/4519/comments"},"review_comment":{"href":"https://api.github.com/repos/guardian/frontend/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/guardian/frontend/pulls/4519/commits"},"statuses":{"href":"https://api.github.com/repos/guardian/frontend/statuses/8f6ddc4f0dacd915604e1dbad560bde3d99ce047"}},"merged":true,"mergeable":true,"mergeable_state":"clean","merged_by":{"login":"kaelig","id":85783,"avatar_url":"https://avatars.githubusercontent.com/u/85783?","gravatar_id":"f7e7b837bd06d6193f4ac70f17e6f44b","url":"https://api.github.com/users/kaelig","html_url":"https://github.com/kaelig","followers_url":"https://api.github.com/users/kaelig/followers","following_url":"https://api.github.com/users/kaelig/following{/other_user}","gists_url":"https://api.github.com/users/kaelig/gists{/gist_id}","starred_url":"https://api.github.com/users/kaelig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaelig/subscriptions","organizations_url":"https://api.github.com/users/kaelig/orgs","repos_url":"https://api.github.com/users/kaelig/repos","events_url":"https://api.github.com/users/kaelig/events{/privacy}","received_events_url":"https://api.github.com/users/kaelig/received_events","type":"User","site_admin":false},"comments":5,"review_comments":0,"commits":2,"additions":3,"deletions":5,"changed_files":1}}