GitHub PullRequestReviewCommentEvent at 2014-08-29 04:38:41
Repository: wf-uicomponents
Actor: lancefisher-wf
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/WebFilings/wf-uicomponents/pulls/comments/16881576","id":16881576,"diff_hunk":"@@ -81,6 +81,21 @@ define(function(require) {\n                 expect(items[0].event).toBe(evt);\n                 expect(items[0].done).toBe(done);\n             });\n+\n+            it('should not enqueue mousemove events while processing', function() {\n+                var evt = createEvent(EventTypes.MOUSE_MOVE);\n+                var done = function() {};\n+                var items;\n+\n+                // Create a transformation that does not finish.\n+                var transformation = Transformation.prototype;","path":"test/awesome_map/TransformationQueueSpec.js","position":11,"original_position":11,"commit_id":"7900e5162480bd28b2b4d3212951294bd3f5b1a7","original_commit_id":"7900e5162480bd28b2b4d3212951294bd3f5b1a7","user":{"login":"lancefisher-wf","id":4355135,"avatar_url":"https://avatars.githubusercontent.com/u/4355135?v=2","gravatar_id":"e7dd4643e9f448ef507f6ba926f4d8ec","url":"https://api.github.com/users/lancefisher-wf","html_url":"https://github.com/lancefisher-wf","followers_url":"https://api.github.com/users/lancefisher-wf/followers","following_url":"https://api.github.com/users/lancefisher-wf/following{/other_user}","gists_url":"https://api.github.com/users/lancefisher-wf/gists{/gist_id}","starred_url":"https://api.github.com/users/lancefisher-wf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lancefisher-wf/subscriptions","organizations_url":"https://api.github.com/users/lancefisher-wf/orgs","repos_url":"https://api.github.com/users/lancefisher-wf/repos","events_url":"https://api.github.com/users/lancefisher-wf/events{/privacy}","received_events_url":"https://api.github.com/users/lancefisher-wf/received_events","type":"User","site_admin":false},"body":"Spies are automatically removed after each spec. https://github.com/pivotal/jasmine/wiki/Spies","created_at":"2014-08-29T04:38:41Z","updated_at":"2014-08-29T04:38:41Z","html_url":"https://github.com/WebFilings/wf-uicomponents/pull/87#discussion_r16881576","pull_request_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/pulls/87","_links":{"self":{"href":"https://api.github.com/repos/WebFilings/wf-uicomponents/pulls/comments/16881576"},"html":{"href":"https://github.com/WebFilings/wf-uicomponents/pull/87#discussion_r16881576"},"pull_request":{"href":"https://api.github.com/repos/WebFilings/wf-uicomponents/pulls/87"}}},"pull_request":{"url":"https://api.github.com/repos/WebFilings/wf-uicomponents/pulls/87","id":20464492,"html_url":"https://github.com/WebFilings/wf-uicomponents/pull/87","diff_url":"https://github.com/WebFilings/wf-uicomponents/pull/87.diff","patch_url":"https://github.com/WebFilings/wf-uicomponents/pull/87.patch","issue_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/issues/87","number":87,"state":"open","locked":false,"title":"Fixes placeholders occasionally not rendering","user":{"login":"lancefisher-wf","id":4355135,"avatar_url":"https://avatars.githubusercontent.com/u/4355135?v=2","gravatar_id":"e7dd4643e9f448ef507f6ba926f4d8ec","url":"https://api.github.com/users/lancefisher-wf","html_url":"https://github.com/lancefisher-wf","followers_url":"https://api.github.com/users/lancefisher-wf/followers","following_url":"https://api.github.com/users/lancefisher-wf/following{/other_user}","gists_url":"https://api.github.com/users/lancefisher-wf/gists{/gist_id}","starred_url":"https://api.github.com/users/lancefisher-wf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lancefisher-wf/subscriptions","organizations_url":"https://api.github.com/users/lancefisher-wf/orgs","repos_url":"https://api.github.com/users/lancefisher-wf/repos","events_url":"https://api.github.com/users/lancefisher-wf/events{/privacy}","received_events_url":"https://api.github.com/users/lancefisher-wf/received_events","type":"User","site_admin":false},"body":"Problem\r\n----------------------------\r\nSwiping and causing many pages to scroll, and then moving the mouse\r\nover the content while the content is scrolling would prevent\r\nthe placeholders for the new pages from rendering.\r\n\r\nThis occurred since mousemove events would be added to the\r\nTransfomrationQueue after the dragend event. When the dragend event\r\nwas processed, the queue would not be empty, and so it would wait\r\nto call ScrollList.render. When the mousemove events process they\r\ndo not trigger a render. So we'd end in a state where the\r\nTransformationQueue was drained, but the placeholders in view would\r\nnot be rendered.\r\n\r\nSolution\r\n----------------------------\r\nThe solution is to ignore mousemove events while the Awesomemap is\r\nbeing transformed. There should be no need to handle them at this\r\ntime anyway.\r\n\r\nTesting\r\n----------------------------\r\nAll unit tests should pass\r\n\r\n```\r\ngit fetch\r\ngit checkout master\r\n```\r\n\r\n* Open the example, and make a large swipe or two to scroll past about 10 pages.\r\n* Wiggle your mouse around the viewport until the content stops scrolling.\r\n* The pages should not render.\r\n\r\n```\r\ngit checkout fix_placeholders_occasionally_not_rendering\r\n```\r\n\r\n* Do the same actions.\r\n* This time the content should render.\r\n\r\n\r\n@timmccall-wf @tomconnell-wf @robbecker-wf @patkujawa-wf @todbachman-wf ","created_at":"2014-08-28T20:27:04Z","updated_at":"2014-08-29T04:38:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"33fe1eaf6e75414bd4702627ecd224ef4a239181","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/pulls/87/commits","review_comments_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/pulls/87/comments","review_comment_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/pulls/comments/{number}","comments_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/issues/87/comments","statuses_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/statuses/7900e5162480bd28b2b4d3212951294bd3f5b1a7","head":{"label":"WebFilings:fix_placeholders_occasionally_not_rendering","ref":"fix_placeholders_occasionally_not_rendering","sha":"7900e5162480bd28b2b4d3212951294bd3f5b1a7","user":{"login":"WebFilings","id":1087529,"avatar_url":"https://avatars.githubusercontent.com/u/1087529?v=2","gravatar_id":"81083d3675346193de94e8471a272512","url":"https://api.github.com/users/WebFilings","html_url":"https://github.com/WebFilings","followers_url":"https://api.github.com/users/WebFilings/followers","following_url":"https://api.github.com/users/WebFilings/following{/other_user}","gists_url":"https://api.github.com/users/WebFilings/gists{/gist_id}","starred_url":"https://api.github.com/users/WebFilings/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WebFilings/subscriptions","organizations_url":"https://api.github.com/users/WebFilings/orgs","repos_url":"https://api.github.com/users/WebFilings/repos","events_url":"https://api.github.com/users/WebFilings/events{/privacy}","received_events_url":"https://api.github.com/users/WebFilings/received_events","type":"Organization","site_admin":false},"repo":{"id":15975978,"name":"wf-uicomponents","full_name":"WebFilings/wf-uicomponents","owner":{"login":"WebFilings","id":1087529,"avatar_url":"https://avatars.githubusercontent.com/u/1087529?v=2","gravatar_id":"81083d3675346193de94e8471a272512","url":"https://api.github.com/users/WebFilings","html_url":"https://github.com/WebFilings","followers_url":"https://api.github.com/users/WebFilings/followers","following_url":"https://api.github.com/users/WebFilings/following{/other_user}","gists_url":"https://api.github.com/users/WebFilings/gists{/gist_id}","starred_url":"https://api.github.com/users/WebFilings/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WebFilings/subscriptions","organizations_url":"https://api.github.com/users/WebFilings/orgs","repos_url":"https://api.github.com/users/WebFilings/repos","events_url":"https://api.github.com/users/WebFilings/events{/privacy}","received_events_url":"https://api.github.com/users/WebFilings/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/WebFilings/wf-uicomponents","description":"","fork":false,"url":"https://api.github.com/repos/WebFilings/wf-uicomponents","forks_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/forks","keys_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/teams","hooks_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/hooks","issue_events_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/issues/events{/number}","events_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/events","assignees_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/assignees{/user}","branches_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/branches{/branch}","tags_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/tags","blobs_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/git/refs{/sha}","trees_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/statuses/{sha}","languages_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/languages","stargazers_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/stargazers","contributors_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/contributors","subscribers_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/subscribers","subscription_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/subscription","commits_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/commits{/sha}","git_commits_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/git/commits{/sha}","comments_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/comments{/number}","issue_comment_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/issues/comments/{number}","contents_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/contents/{+path}","compare_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/merges","archive_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/downloads","issues_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/issues{/number}","pulls_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/pulls{/number}","milestones_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/milestones{/number}","notifications_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/labels{/name}","releases_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/releases{/id}","created_at":"2014-01-16T17:54:42Z","updated_at":"2014-07-21T03:36:56Z","pushed_at":"2014-08-28T21:46:49Z","git_url":"git://github.com/WebFilings/wf-uicomponents.git","ssh_url":"git@github.com:WebFilings/wf-uicomponents.git","clone_url":"https://github.com/WebFilings/wf-uicomponents.git","svn_url":"https://github.com/WebFilings/wf-uicomponents","homepage":null,"size":4141,"stargazers_count":10,"watchers_count":10,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":10,"default_branch":"master"}},"base":{"label":"WebFilings:master","ref":"master","sha":"e1c63869111ea9502ab3af68c8b8f840024ddaf6","user":{"login":"WebFilings","id":1087529,"avatar_url":"https://avatars.githubusercontent.com/u/1087529?v=2","gravatar_id":"81083d3675346193de94e8471a272512","url":"https://api.github.com/users/WebFilings","html_url":"https://github.com/WebFilings","followers_url":"https://api.github.com/users/WebFilings/followers","following_url":"https://api.github.com/users/WebFilings/following{/other_user}","gists_url":"https://api.github.com/users/WebFilings/gists{/gist_id}","starred_url":"https://api.github.com/users/WebFilings/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WebFilings/subscriptions","organizations_url":"https://api.github.com/users/WebFilings/orgs","repos_url":"https://api.github.com/users/WebFilings/repos","events_url":"https://api.github.com/users/WebFilings/events{/privacy}","received_events_url":"https://api.github.com/users/WebFilings/received_events","type":"Organization","site_admin":false},"repo":{"id":15975978,"name":"wf-uicomponents","full_name":"WebFilings/wf-uicomponents","owner":{"login":"WebFilings","id":1087529,"avatar_url":"https://avatars.githubusercontent.com/u/1087529?v=2","gravatar_id":"81083d3675346193de94e8471a272512","url":"https://api.github.com/users/WebFilings","html_url":"https://github.com/WebFilings","followers_url":"https://api.github.com/users/WebFilings/followers","following_url":"https://api.github.com/users/WebFilings/following{/other_user}","gists_url":"https://api.github.com/users/WebFilings/gists{/gist_id}","starred_url":"https://api.github.com/users/WebFilings/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WebFilings/subscriptions","organizations_url":"https://api.github.com/users/WebFilings/orgs","repos_url":"https://api.github.com/users/WebFilings/repos","events_url":"https://api.github.com/users/WebFilings/events{/privacy}","received_events_url":"https://api.github.com/users/WebFilings/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/WebFilings/wf-uicomponents","description":"","fork":false,"url":"https://api.github.com/repos/WebFilings/wf-uicomponents","forks_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/forks","keys_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/teams","hooks_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/hooks","issue_events_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/issues/events{/number}","events_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/events","assignees_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/assignees{/user}","branches_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/branches{/branch}","tags_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/tags","blobs_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/git/refs{/sha}","trees_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/statuses/{sha}","languages_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/languages","stargazers_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/stargazers","contributors_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/contributors","subscribers_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/subscribers","subscription_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/subscription","commits_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/commits{/sha}","git_commits_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/git/commits{/sha}","comments_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/comments{/number}","issue_comment_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/issues/comments/{number}","contents_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/contents/{+path}","compare_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/merges","archive_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/downloads","issues_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/issues{/number}","pulls_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/pulls{/number}","milestones_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/milestones{/number}","notifications_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/labels{/name}","releases_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/releases{/id}","created_at":"2014-01-16T17:54:42Z","updated_at":"2014-07-21T03:36:56Z","pushed_at":"2014-08-28T21:46:49Z","git_url":"git://github.com/WebFilings/wf-uicomponents.git","ssh_url":"git@github.com:WebFilings/wf-uicomponents.git","clone_url":"https://github.com/WebFilings/wf-uicomponents.git","svn_url":"https://github.com/WebFilings/wf-uicomponents","homepage":null,"size":4141,"stargazers_count":10,"watchers_count":10,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/WebFilings/wf-uicomponents/pulls/87"},"html":{"href":"https://github.com/WebFilings/wf-uicomponents/pull/87"},"issue":{"href":"https://api.github.com/repos/WebFilings/wf-uicomponents/issues/87"},"comments":{"href":"https://api.github.com/repos/WebFilings/wf-uicomponents/issues/87/comments"},"review_comments":{"href":"https://api.github.com/repos/WebFilings/wf-uicomponents/pulls/87/comments"},"review_comment":{"href":"https://api.github.com/repos/WebFilings/wf-uicomponents/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/WebFilings/wf-uicomponents/pulls/87/commits"},"statuses":{"href":"https://api.github.com/repos/WebFilings/wf-uicomponents/statuses/7900e5162480bd28b2b4d3212951294bd3f5b1a7"}}}}