GitHub PullRequestReviewCommentEvent at 2014-02-04 02:08:40
Repository: vraptor4
Actor: garcia-jj
Payload: {"comment":{"url":"https://api.github.com/repos/caelum/vraptor4/pulls/comments/9408634","id":9408634,"diff_hunk":"@@ -166,11 +172,29 @@ public void isCapableOfDealingWithSetsOfObjects() throws Exception {\n \t\tassertThat(abc.iterator().next().getX(), is(1l));\n \t}\n \n+\t@Test\n+\tpublic void shouldInjectOnlyAttributesWithSameType() throws Exception {\n+\t\tResult result = mock(Result.class);\n+\t\twhen(request.getAttribute(\"result\")).thenReturn(result);\n+\t\twhen(request.getParameterMap()).thenReturn(singletonMap(\"result\", new String[] { \"buggy\" }));\n+\n+\t\tControllerMethod method = DefaultControllerMethod.instanceFor(OtherResource.class, \n+\t\t\t\tOtherResource.class.getDeclaredMethod(\"logic\", String.class));\n+\n+\t\tList<Message> errors = new ArrayList<Message>();\n+\t\tObject[] out = provider.getParametersFor(method, errors);","path":"vraptor-core/src/test/java/br/com/caelum/vraptor/http/iogi/IogiParametersProviderTest.java","position":50,"original_position":50,"commit_id":"40aef05f42ad9c9b2c9a66e0506d31e62988feb1","original_commit_id":"40aef05f42ad9c9b2c9a66e0506d31e62988feb1","user":{"login":"garcia-jj","id":140387,"avatar_url":"https://gravatar.com/avatar/471af576b6918dbd3401168f7a42f098?d=https%3A%2F%2Fidenticons.github.com%2F15d891c8f5c95aa42fc72145a8678760.png&r=x","gravatar_id":"471af576b6918dbd3401168f7a42f098","url":"https://api.github.com/users/garcia-jj","html_url":"https://github.com/garcia-jj","followers_url":"https://api.github.com/users/garcia-jj/followers","following_url":"https://api.github.com/users/garcia-jj/following{/other_user}","gists_url":"https://api.github.com/users/garcia-jj/gists{/gist_id}","starred_url":"https://api.github.com/users/garcia-jj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garcia-jj/subscriptions","organizations_url":"https://api.github.com/users/garcia-jj/orgs","repos_url":"https://api.github.com/users/garcia-jj/repos","events_url":"https://api.github.com/users/garcia-jj/events{/privacy}","received_events_url":"https://api.github.com/users/garcia-jj/received_events","type":"User","site_admin":false},"body":"I've changed the test because I think that we need to check if IOGI got the right parameter too. @lucascs right?","created_at":"2014-02-04T02:08:40Z","updated_at":"2014-02-04T02:08:40Z","html_url":"https://github.com/caelum/vraptor4/pull/355#discussion_r9408634","pull_request_url":"https://api.github.com/repos/caelum/vraptor4/pulls/355","_links":{"self":{"href":"https://api.github.com/repos/caelum/vraptor4/pulls/comments/9408634"},"html":{"href":"https://github.com/caelum/vraptor4/pull/355#discussion_r9408634"},"pull_request":{"href":"https://api.github.com/repos/caelum/vraptor4/pulls/355"}}}}