GitHub PullRequestReviewCommentEvent at 2014-08-01 07:29:56
Repository: android_kktoolkit
Actor: peterzl
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/KKBOX/android_kktoolkit/pulls/comments/15684796","id":15684796,"diff_hunk":"@@ -247,7 +240,18 @@ public void onResume() {\n \t\t\tif (dataFetchedStatus == DataFetchStatus.SUCCESS) {\n \t\t\t\tonLoadUI();\n \t\t\t} else {\n-\t\t\t\tonFetchData();\n+\t\t\t\tif (onFetchData()) {\n+\t\t\t\t\tif (viewMessage != null) {\n+\t\t\t\t\t\tif (customLoadingView != null) {\n+\t\t\t\t\t\t\tviewMessage.setCustomView(customLoadingView);\n+\t\t\t\t\t\t} else {\n+\t\t\t\t\t\t\tviewMessage.setSingleTextView(getString(R.string.loading));\n+\t\t\t\t\t\t}\n+\t\t\t\t\t\tviewMessage.show();\n+\t\t\t\t\t}\n+\t\t\t\t} else {\n+\t\t\t\t\tfinishFetchData();","path":"src/com/kkbox/toolkit/app/KKFragment.java","position":33,"original_position":33,"commit_id":"2439242a3c99ec59e528ae95869d705d24fd9a6e","original_commit_id":"2439242a3c99ec59e528ae95869d705d24fd9a6e","user":{"login":"peterzl","id":18382,"avatar_url":"https://avatars.githubusercontent.com/u/18382?v=1","gravatar_id":"321dd34a24bf5a87d164839b36b68a42","url":"https://api.github.com/users/peterzl","html_url":"https://github.com/peterzl","followers_url":"https://api.github.com/users/peterzl/followers","following_url":"https://api.github.com/users/peterzl/following{/other_user}","gists_url":"https://api.github.com/users/peterzl/gists{/gist_id}","starred_url":"https://api.github.com/users/peterzl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterzl/subscriptions","organizations_url":"https://api.github.com/users/peterzl/orgs","repos_url":"https://api.github.com/users/peterzl/repos","events_url":"https://api.github.com/users/peterzl/events{/privacy}","received_events_url":"https://api.github.com/users/peterzl/received_events","type":"User","site_admin":false},"body":"所以返回false的話就會去跑onLoadUI?","created_at":"2014-08-01T07:29:56Z","updated_at":"2014-08-01T07:29:56Z","html_url":"https://github.com/KKBOX/android_kktoolkit/pull/115#discussion_r15684796","pull_request_url":"https://api.github.com/repos/KKBOX/android_kktoolkit/pulls/115","_links":{"self":{"href":"https://api.github.com/repos/KKBOX/android_kktoolkit/pulls/comments/15684796"},"html":{"href":"https://github.com/KKBOX/android_kktoolkit/pull/115#discussion_r15684796"},"pull_request":{"href":"https://api.github.com/repos/KKBOX/android_kktoolkit/pulls/115"}}},"pull_request":{"url":"https://api.github.com/repos/KKBOX/android_kktoolkit/pulls/115","id":19196285,"html_url":"https://github.com/KKBOX/android_kktoolkit/pull/115","diff_url":"https://github.com/KKBOX/android_kktoolkit/pull/115.diff","patch_url":"https://github.com/KKBOX/android_kktoolkit/pull/115.patch","issue_url":"https://api.github.com/repos/KKBOX/android_kktoolkit/issues/115","number":115,"state":"open","title":"ticket.39741: Refactor toolkit onFetchData","user":{"login":"EthanShen","id":2202018,"avatar_url":"https://avatars.githubusercontent.com/u/2202018?v=1","gravatar_id":"cc5f9440f0899feeeb6f762653512604","url":"https://api.github.com/users/EthanShen","html_url":"https://github.com/EthanShen","followers_url":"https://api.github.com/users/EthanShen/followers","following_url":"https://api.github.com/users/EthanShen/following{/other_user}","gists_url":"https://api.github.com/users/EthanShen/gists{/gist_id}","starred_url":"https://api.github.com/users/EthanShen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EthanShen/subscriptions","organizations_url":"https://api.github.com/users/EthanShen/orgs","repos_url":"https://api.github.com/users/EthanShen/repos","events_url":"https://api.github.com/users/EthanShen/events{/privacy}","received_events_url":"https://api.github.com/users/EthanShen/received_events","type":"User","site_admin":false},"body":"針對自否需要秀 loading view 機制重構\r\n\r\nonFetchData() 預設回傳 false \r\n表示不秀 loding view 並且執行 onLoadUI()\r\n\r\n如果 override onFetchData() 並且回傳 true\r\n表示顯示 loading view \r\n並且在完成取資料動作之後需 call finishFetchData() 或 fetchDataFailed()","created_at":"2014-08-01T07:18:47Z","updated_at":"2014-08-01T07:29:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f90c22f7966d9cc45042c4fe93d181f9196b9df5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/KKBOX/android_kktoolkit/pulls/115/commits","review_comments_url":"https://api.github.com/repos/KKBOX/android_kktoolkit/pulls/115/comments","review_comment_url":"https://api.github.com/repos/KKBOX/android_kktoolkit/pulls/comments/{number}","comments_url":"https://api.github.com/repos/KKBOX/android_kktoolkit/issues/115/comments","statuses_url":"https://api.github.com/repos/KKBOX/android_kktoolkit/statuses/2439242a3c99ec59e528ae95869d705d24fd9a6e","head":{"label":"KKBOX:dev_ethan","ref":"dev_ethan","sha":"2439242a3c99ec59e528ae95869d705d24fd9a6e","user":{"login":"KKBOX","id":443354,"avatar_url":"https://avatars.githubusercontent.com/u/443354?v=1","gravatar_id":"46769ec64946ab7ac4236719fb5d7a78","url":"https://api.github.com/users/KKBOX","html_url":"https://github.com/KKBOX","followers_url":"https://api.github.com/users/KKBOX/followers","following_url":"https://api.github.com/users/KKBOX/following{/other_user}","gists_url":"https://api.github.com/users/KKBOX/gists{/gist_id}","starred_url":"https://api.github.com/users/KKBOX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KKBOX/subscriptions","organizations_url":"https://api.github.com/users/KKBOX/orgs","repos_url":"https://api.github.com/users/KKBOX/repos","events_url":"https://api.github.com/users/KKBOX/events{/privacy}","received_events_url":"https://api.github.com/users/KKBOX/received_events","type":"Organization","site_admin":false},"repo":{"id":11676594,"name":"android_kktoolkit","full_name":"KKBOX/android_kktoolkit","owner":{"login":"KKBOX","id":443354,"avatar_url":"https://avatars.githubusercontent.com/u/443354?v=1","gravatar_id":"46769ec64946ab7ac4236719fb5d7a78","url":"https://api.github.com/users/KKBOX","html_url":"https://github.com/KKBOX","followers_url":"https://api.github.com/users/KKBOX/followers","following_url":"https://api.github.com/users/KKBOX/following{/other_user}","gists_url":"https://api.github.com/users/KKBOX/gists{/gist_id}","starred_url":"https://api.github.com/users/KKBOX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KKBOX/subscriptions","organizations_url":"https://api.github.com/users/KKBOX/orgs","repos_url":"https://api.github.com/users/KKBOX/repos","events_url":"https://api.github.com/users/KKBOX/events{/privacy}","received_events_url":"https://api.github.com/users/KKBOX/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KKBOX/android_kktoolkit","description":"","fork":false,"url":"https://api.github.com/repos/KKBOX/android_kktoolkit","forks_url":"https://api.github.com/repos/KKBOX/android_kktoolkit/forks","keys_url":"https://api.github.com/repos/KKBOX/android_kktoolkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KKBOX/android_kktoolkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KKBOX/android_kktoolkit/teams","hooks_url":"https://api.github.com/repos/KKBOX/android_kktoolkit/hooks","issue_events_url":"https://api.github.com/repos/KKBOX/android_kktoolkit/issues/events{/number}","events_url":"https://api.github.com/repos/KKBOX/android_kktoolkit/events","assignees_url":"https://api.github.com/repos/KKBOX/android_kktoolkit/assignees{/user}","branches_url":"https://api.github.com/repos/KKBOX/android_kktoolkit/branches{/branch}","tags_url":"https://api.github.com/repos/KKBOX/android_kktoolkit/tags","blobs_url":"https://api.github.com/repos/KKBOX/android_kktoolkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KKBOX/android_kktoolkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KKBOX/android_kktoolkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/KKBOX/android_kktoolkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KKBOX/android_kktoolkit/statuses/{sha}","languages_url":"https://api.github.com/repos/KKBOX/android_kktoolkit/languages","stargazers_url":"https://api.github.com/repos/KKBOX/android_kktoolkit/stargazers","contributors_url":"https://api.github.com/repos/KKBOX/android_kktoolkit/contributors","subscribers_url":"https://api.github.com/repos/KKBOX/android_kktoolkit/subscribers","subscription_url":"https://api.github.com/repos/KKBOX/android_kktoolkit/subscription","commits_url":"https://api.github.com/repos/KKBOX/android_kktoolkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/KKBOX/android_kktoolkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/KKBOX/android_kktoolkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/KKBOX/android_kktoolkit/issues/comments/{number}","contents_url":"https://api.github.com/repos/KKBOX/android_kktoolkit/contents/{+path}","compare_url":"https://api.github.com/repos/KKBOX/android_kktoolkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KKBOX/android_kktoolkit/merges","archive_url":"https://api.github.com/repos/KKBOX/android_kktoolkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KKBOX/android_kktoolkit/downloads","issues_url":"https://api.github.com/repos/KKBOX/android_kktoolkit/issues{/number}","pulls_url":"https://api.github.com/repos/KKBOX/android_kktoolkit/pulls{/number}","milestones_url":"https://api.github.com/repos/KKBOX/android_kktoolkit/milestones{/number}","notifications_url":"https://api.github.com/repos/KKBOX/android_kktoolkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KKBOX/android_kktoolkit/labels{/name}","releases_url":"https://api.github.com/repos/KKBOX/android_kktoolkit/releases{/id}","created_at":"2013-07-26T03:11:25Z","updated_at":"2014-06-30T08:48:38Z","pushed_at":"2014-08-01T07:13:51Z","git_url":"git://github.com/KKBOX/android_kktoolkit.git","ssh_url":"git@github.com:KKBOX/android_kktoolkit.git","clone_url":"https://github.com/KKBOX/android_kktoolkit.git","svn_url":"https://github.com/KKBOX/android_kktoolkit","homepage":null,"size":8680,"stargazers_count":33,"watchers_count":33,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":8,"mirror_url":null,"open_issues_count":1,"forks":8,"open_issues":1,"watchers":33,"default_branch":"master"}},"base":{"label":"KKBOX:dev","ref":"dev","sha":"e50dfc4ddb52a9d76563af4c56cb1f00d6a132bb","user":{"login":"KKBOX","id":443354,"avatar_url":"https://avatars.githubusercontent.com/u/443354?v=1","gravatar_id":"46769ec64946ab7ac4236719fb5d7a78","url":"https://api.github.com/users/KKBOX","html_url":"https://github.com/KKBOX","followers_url":"https://api.github.com/users/KKBOX/followers","following_url":"https://api.github.com/users/KKBOX/following{/other_user}","gists_url":"https://api.github.com/users/KKBOX/gists{/gist_id}","starred_url":"https://api.github.com/users/KKBOX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KKBOX/subscriptions","organizations_url":"https://api.github.com/users/KKBOX/orgs","repos_url":"https://api.github.com/users/KKBOX/repos","events_url":"https://api.github.com/users/KKBOX/events{/privacy}","received_events_url":"https://api.github.com/users/KKBOX/received_events","type":"Organization","site_admin":false},"repo":{"id":11676594,"name":"android_kktoolkit","full_name":"KKBOX/android_kktoolkit","owner":{"login":"KKBOX","id":443354,"avatar_url":"https://avatars.githubusercontent.com/u/443354?v=1","gravatar_id":"46769ec64946ab7ac4236719fb5d7a78","url":"https://api.github.com/users/KKBOX","html_url":"https://github.com/KKBOX","followers_url":"https://api.github.com/users/KKBOX/followers","following_url":"https://api.github.com/users/KKBOX/following{/other_user}","gists_url":"https://api.github.com/users/KKBOX/gists{/gist_id}","starred_url":"https://api.github.com/users/KKBOX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KKBOX/subscriptions","organizations_url":"https://api.github.com/users/KKBOX/orgs","repos_url":"https://api.github.com/users/KKBOX/repos","events_url":"https://api.github.com/users/KKBOX/events{/privacy}","received_events_url":"https://api.github.com/users/KKBOX/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KKBOX/android_kktoolkit","description":"","fork":false,"url":"https://api.github.com/repos/KKBOX/android_kktoolkit","forks_url":"https://api.github.com/repos/KKBOX/android_kktoolkit/forks","keys_url":"https://api.github.com/repos/KKBOX/android_kktoolkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KKBOX/android_kktoolkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KKBOX/android_kktoolkit/teams","hooks_url":"https://api.github.com/repos/KKBOX/android_kktoolkit/hooks","issue_events_url":"https://api.github.com/repos/KKBOX/android_kktoolkit/issues/events{/number}","events_url":"https://api.github.com/repos/KKBOX/android_kktoolkit/events","assignees_url":"https://api.github.com/repos/KKBOX/android_kktoolkit/assignees{/user}","branches_url":"https://api.github.com/repos/KKBOX/android_kktoolkit/branches{/branch}","tags_url":"https://api.github.com/repos/KKBOX/android_kktoolkit/tags","blobs_url":"https://api.github.com/repos/KKBOX/android_kktoolkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KKBOX/android_kktoolkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KKBOX/android_kktoolkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/KKBOX/android_kktoolkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KKBOX/android_kktoolkit/statuses/{sha}","languages_url":"https://api.github.com/repos/KKBOX/android_kktoolkit/languages","stargazers_url":"https://api.github.com/repos/KKBOX/android_kktoolkit/stargazers","contributors_url":"https://api.github.com/repos/KKBOX/android_kktoolkit/contributors","subscribers_url":"https://api.github.com/repos/KKBOX/android_kktoolkit/subscribers","subscription_url":"https://api.github.com/repos/KKBOX/android_kktoolkit/subscription","commits_url":"https://api.github.com/repos/KKBOX/android_kktoolkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/KKBOX/android_kktoolkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/KKBOX/android_kktoolkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/KKBOX/android_kktoolkit/issues/comments/{number}","contents_url":"https://api.github.com/repos/KKBOX/android_kktoolkit/contents/{+path}","compare_url":"https://api.github.com/repos/KKBOX/android_kktoolkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KKBOX/android_kktoolkit/merges","archive_url":"https://api.github.com/repos/KKBOX/android_kktoolkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KKBOX/android_kktoolkit/downloads","issues_url":"https://api.github.com/repos/KKBOX/android_kktoolkit/issues{/number}","pulls_url":"https://api.github.com/repos/KKBOX/android_kktoolkit/pulls{/number}","milestones_url":"https://api.github.com/repos/KKBOX/android_kktoolkit/milestones{/number}","notifications_url":"https://api.github.com/repos/KKBOX/android_kktoolkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KKBOX/android_kktoolkit/labels{/name}","releases_url":"https://api.github.com/repos/KKBOX/android_kktoolkit/releases{/id}","created_at":"2013-07-26T03:11:25Z","updated_at":"2014-06-30T08:48:38Z","pushed_at":"2014-08-01T07:13:51Z","git_url":"git://github.com/KKBOX/android_kktoolkit.git","ssh_url":"git@github.com:KKBOX/android_kktoolkit.git","clone_url":"https://github.com/KKBOX/android_kktoolkit.git","svn_url":"https://github.com/KKBOX/android_kktoolkit","homepage":null,"size":8680,"stargazers_count":33,"watchers_count":33,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":8,"mirror_url":null,"open_issues_count":1,"forks":8,"open_issues":1,"watchers":33,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KKBOX/android_kktoolkit/pulls/115"},"html":{"href":"https://github.com/KKBOX/android_kktoolkit/pull/115"},"issue":{"href":"https://api.github.com/repos/KKBOX/android_kktoolkit/issues/115"},"comments":{"href":"https://api.github.com/repos/KKBOX/android_kktoolkit/issues/115/comments"},"review_comments":{"href":"https://api.github.com/repos/KKBOX/android_kktoolkit/pulls/115/comments"},"review_comment":{"href":"https://api.github.com/repos/KKBOX/android_kktoolkit/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/KKBOX/android_kktoolkit/pulls/115/commits"},"statuses":{"href":"https://api.github.com/repos/KKBOX/android_kktoolkit/statuses/2439242a3c99ec59e528ae95869d705d24fd9a6e"}}}}