GitHub PullRequestEvent at 2014-12-26 04:48:35
Repository: PyBitmessage
Actor: arcresu
Payload: {"action":"closed","number":749,"pull_request":{"url":"https://api.github.com/repos/Bitmessage/PyBitmessage/pulls/749","id":26546343,"html_url":"https://github.com/Bitmessage/PyBitmessage/pull/749","diff_url":"https://github.com/Bitmessage/PyBitmessage/pull/749.diff","patch_url":"https://github.com/Bitmessage/PyBitmessage/pull/749.patch","issue_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/issues/749","number":749,"state":"closed","locked":false,"title":"Revert \"Fixed the path in shell executable when DESTDIR isn't empty\"","user":{"login":"arcresu","id":322256,"avatar_url":"https://avatars.githubusercontent.com/u/322256?v=3","gravatar_id":"","url":"https://api.github.com/users/arcresu","html_url":"https://github.com/arcresu","followers_url":"https://api.github.com/users/arcresu/followers","following_url":"https://api.github.com/users/arcresu/following{/other_user}","gists_url":"https://api.github.com/users/arcresu/gists{/gist_id}","starred_url":"https://api.github.com/users/arcresu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arcresu/subscriptions","organizations_url":"https://api.github.com/users/arcresu/orgs","repos_url":"https://api.github.com/users/arcresu/repos","events_url":"https://api.github.com/users/arcresu/events{/privacy}","received_events_url":"https://api.github.com/users/arcresu/received_events","type":"User","site_admin":false},"body":"I'm not sure what the original intention of this change was, but it breaks installation via debian packages. The `$DESTDIR` variable is [intended to facilitate staged installs](http://www.gnu.org/prep/standards/html_node/DESTDIR.html#DESTDIR), where the program is installed to a staging area before reaching its final destination. The staging area is not intended to stay around, and it will be deleted at some point after the files have been moved to their final destination.\r\n\r\nSince the lines affected by this change are copied into the installation, this means that the staging path is left behind in the final shell script. The result is something like:\r\n\r\n```\r\n#!/bin/sh\r\nif [ -d /tmp/tmp.TUTTv2xWvP/pybitmessage-0.4.4/debian/pybitmessage/usr/local/share/pybitmessage ]; then\r\n  cd /tmp/tmp.TUTTv2xWvP/pybitmessage-0.4.4/debian/pybitmessage/usr/local/share/pybitmessage\r\nelse\r\n  cd /tmp/tmp.TUTTv2xWvP/pybitmessage-0.4.4/debian/pybitmessage/usr/share/pybitmessage\r\nfi\r\nLD_LIBRARY_PATH=\"/opt/openssl-compat-bitcoin/lib/\" exec python2 bitmessagemain.py\r\n```\r\n\r\nwhich means that the system-wide executable is actually launching the program from my temporary staging area and ignoring the files which were installed in the `/usr/share/` tree. This is not the intended effect; `$DESTDIR` should never be included anywhere in the files to be installed, by definition.","created_at":"2014-12-24T06:12:51Z","updated_at":"2014-12-26T04:48:35Z","closed_at":"2014-12-26T04:48:35Z","merged_at":null,"merge_commit_sha":"050b1c46438b681b4dda628134546e88bd233fe2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/pulls/749/commits","review_comments_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/pulls/749/comments","review_comment_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/issues/749/comments","statuses_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/statuses/542cf1729c4b5aa2fa24fbaeac288e64fd77d18e","head":{"label":"arcresu:revert-575-install_issues","ref":"revert-575-install_issues","sha":"542cf1729c4b5aa2fa24fbaeac288e64fd77d18e","user":{"login":"arcresu","id":322256,"avatar_url":"https://avatars.githubusercontent.com/u/322256?v=3","gravatar_id":"","url":"https://api.github.com/users/arcresu","html_url":"https://github.com/arcresu","followers_url":"https://api.github.com/users/arcresu/followers","following_url":"https://api.github.com/users/arcresu/following{/other_user}","gists_url":"https://api.github.com/users/arcresu/gists{/gist_id}","starred_url":"https://api.github.com/users/arcresu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arcresu/subscriptions","organizations_url":"https://api.github.com/users/arcresu/orgs","repos_url":"https://api.github.com/users/arcresu/repos","events_url":"https://api.github.com/users/arcresu/events{/privacy}","received_events_url":"https://api.github.com/users/arcresu/received_events","type":"User","site_admin":false},"repo":{"id":28437426,"name":"PyBitmessage","full_name":"arcresu/PyBitmessage","owner":{"login":"arcresu","id":322256,"avatar_url":"https://avatars.githubusercontent.com/u/322256?v=3","gravatar_id":"","url":"https://api.github.com/users/arcresu","html_url":"https://github.com/arcresu","followers_url":"https://api.github.com/users/arcresu/followers","following_url":"https://api.github.com/users/arcresu/following{/other_user}","gists_url":"https://api.github.com/users/arcresu/gists{/gist_id}","starred_url":"https://api.github.com/users/arcresu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arcresu/subscriptions","organizations_url":"https://api.github.com/users/arcresu/orgs","repos_url":"https://api.github.com/users/arcresu/repos","events_url":"https://api.github.com/users/arcresu/events{/privacy}","received_events_url":"https://api.github.com/users/arcresu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/arcresu/PyBitmessage","description":"","fork":true,"url":"https://api.github.com/repos/arcresu/PyBitmessage","forks_url":"https://api.github.com/repos/arcresu/PyBitmessage/forks","keys_url":"https://api.github.com/repos/arcresu/PyBitmessage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arcresu/PyBitmessage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arcresu/PyBitmessage/teams","hooks_url":"https://api.github.com/repos/arcresu/PyBitmessage/hooks","issue_events_url":"https://api.github.com/repos/arcresu/PyBitmessage/issues/events{/number}","events_url":"https://api.github.com/repos/arcresu/PyBitmessage/events","assignees_url":"https://api.github.com/repos/arcresu/PyBitmessage/assignees{/user}","branches_url":"https://api.github.com/repos/arcresu/PyBitmessage/branches{/branch}","tags_url":"https://api.github.com/repos/arcresu/PyBitmessage/tags","blobs_url":"https://api.github.com/repos/arcresu/PyBitmessage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arcresu/PyBitmessage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arcresu/PyBitmessage/git/refs{/sha}","trees_url":"https://api.github.com/repos/arcresu/PyBitmessage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arcresu/PyBitmessage/statuses/{sha}","languages_url":"https://api.github.com/repos/arcresu/PyBitmessage/languages","stargazers_url":"https://api.github.com/repos/arcresu/PyBitmessage/stargazers","contributors_url":"https://api.github.com/repos/arcresu/PyBitmessage/contributors","subscribers_url":"https://api.github.com/repos/arcresu/PyBitmessage/subscribers","subscription_url":"https://api.github.com/repos/arcresu/PyBitmessage/subscription","commits_url":"https://api.github.com/repos/arcresu/PyBitmessage/commits{/sha}","git_commits_url":"https://api.github.com/repos/arcresu/PyBitmessage/git/commits{/sha}","comments_url":"https://api.github.com/repos/arcresu/PyBitmessage/comments{/number}","issue_comment_url":"https://api.github.com/repos/arcresu/PyBitmessage/issues/comments/{number}","contents_url":"https://api.github.com/repos/arcresu/PyBitmessage/contents/{+path}","compare_url":"https://api.github.com/repos/arcresu/PyBitmessage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arcresu/PyBitmessage/merges","archive_url":"https://api.github.com/repos/arcresu/PyBitmessage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arcresu/PyBitmessage/downloads","issues_url":"https://api.github.com/repos/arcresu/PyBitmessage/issues{/number}","pulls_url":"https://api.github.com/repos/arcresu/PyBitmessage/pulls{/number}","milestones_url":"https://api.github.com/repos/arcresu/PyBitmessage/milestones{/number}","notifications_url":"https://api.github.com/repos/arcresu/PyBitmessage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arcresu/PyBitmessage/labels{/name}","releases_url":"https://api.github.com/repos/arcresu/PyBitmessage/releases{/id}","created_at":"2014-12-24T06:04:13Z","updated_at":"2014-12-24T06:04:13Z","pushed_at":"2014-12-24T06:07:01Z","git_url":"git://github.com/arcresu/PyBitmessage.git","ssh_url":"git@github.com:arcresu/PyBitmessage.git","clone_url":"https://github.com/arcresu/PyBitmessage.git","svn_url":"https://github.com/arcresu/PyBitmessage","homepage":null,"size":8351,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Bitmessage:master","ref":"master","sha":"b02a5d31095357eead55feefb4ba09ee7944f813","user":{"login":"Bitmessage","id":2625379,"avatar_url":"https://avatars.githubusercontent.com/u/2625379?v=3","gravatar_id":"","url":"https://api.github.com/users/Bitmessage","html_url":"https://github.com/Bitmessage","followers_url":"https://api.github.com/users/Bitmessage/followers","following_url":"https://api.github.com/users/Bitmessage/following{/other_user}","gists_url":"https://api.github.com/users/Bitmessage/gists{/gist_id}","starred_url":"https://api.github.com/users/Bitmessage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bitmessage/subscriptions","organizations_url":"https://api.github.com/users/Bitmessage/orgs","repos_url":"https://api.github.com/users/Bitmessage/repos","events_url":"https://api.github.com/users/Bitmessage/events{/privacy}","received_events_url":"https://api.github.com/users/Bitmessage/received_events","type":"Organization","site_admin":false},"repo":{"id":6648028,"name":"PyBitmessage","full_name":"Bitmessage/PyBitmessage","owner":{"login":"Bitmessage","id":2625379,"avatar_url":"https://avatars.githubusercontent.com/u/2625379?v=3","gravatar_id":"","url":"https://api.github.com/users/Bitmessage","html_url":"https://github.com/Bitmessage","followers_url":"https://api.github.com/users/Bitmessage/followers","following_url":"https://api.github.com/users/Bitmessage/following{/other_user}","gists_url":"https://api.github.com/users/Bitmessage/gists{/gist_id}","starred_url":"https://api.github.com/users/Bitmessage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bitmessage/subscriptions","organizations_url":"https://api.github.com/users/Bitmessage/orgs","repos_url":"https://api.github.com/users/Bitmessage/repos","events_url":"https://api.github.com/users/Bitmessage/events{/privacy}","received_events_url":"https://api.github.com/users/Bitmessage/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Bitmessage/PyBitmessage","description":"","fork":false,"url":"https://api.github.com/repos/Bitmessage/PyBitmessage","forks_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/forks","keys_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/teams","hooks_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/hooks","issue_events_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/issues/events{/number}","events_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/events","assignees_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/assignees{/user}","branches_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/branches{/branch}","tags_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/tags","blobs_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/git/refs{/sha}","trees_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/statuses/{sha}","languages_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/languages","stargazers_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/stargazers","contributors_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/contributors","subscribers_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/subscribers","subscription_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/subscription","commits_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/commits{/sha}","git_commits_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/git/commits{/sha}","comments_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/comments{/number}","issue_comment_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/issues/comments/{number}","contents_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/contents/{+path}","compare_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/merges","archive_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/downloads","issues_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/issues{/number}","pulls_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/pulls{/number}","milestones_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/milestones{/number}","notifications_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/labels{/name}","releases_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/releases{/id}","created_at":"2012-11-12T03:36:43Z","updated_at":"2014-12-26T04:25:55Z","pushed_at":"2014-12-26T04:25:54Z","git_url":"git://github.com/Bitmessage/PyBitmessage.git","ssh_url":"git@github.com:Bitmessage/PyBitmessage.git","clone_url":"https://github.com/Bitmessage/PyBitmessage.git","svn_url":"https://github.com/Bitmessage/PyBitmessage","homepage":null,"size":8351,"stargazers_count":1443,"watchers_count":1443,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":292,"mirror_url":null,"open_issues_count":118,"forks":292,"open_issues":118,"watchers":1443,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Bitmessage/PyBitmessage/pulls/749"},"html":{"href":"https://github.com/Bitmessage/PyBitmessage/pull/749"},"issue":{"href":"https://api.github.com/repos/Bitmessage/PyBitmessage/issues/749"},"comments":{"href":"https://api.github.com/repos/Bitmessage/PyBitmessage/issues/749/comments"},"review_comments":{"href":"https://api.github.com/repos/Bitmessage/PyBitmessage/pulls/749/comments"},"review_comment":{"href":"https://api.github.com/repos/Bitmessage/PyBitmessage/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Bitmessage/PyBitmessage/pulls/749/commits"},"statuses":{"href":"https://api.github.com/repos/Bitmessage/PyBitmessage/statuses/542cf1729c4b5aa2fa24fbaeac288e64fd77d18e"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":2,"review_comments":0,"commits":1,"additions":3,"deletions":3,"changed_files":1}}