GitHub PushEvent at 2014-01-30 00:20:23
Repository: PyFITS
Actor: embray
Payload: {"shas":[["9d82a8a64020aee5948f0f4acbe2debecb0b20b0","13694847bdacb3ad5c2e2411f328f0f2a0a8420d@gmail.com","Fixed an issue I caught while updating the checksum tests, though it is not specifically related to checksums.  The issue is that if an image contains pseudo-unsigned integers, merely opening the file and then writing a copy of it will remove all the pseudo-unsigned scaling unexpectedly and clearly undesiredly.\n\nImproved several of the checksum tests to check that the checksums being written are *actually* correct (previously we used PyFITS itself to also verify the checksums, but this ensures that the checksums are also validated against CFITSIO (using precomputed values)).  Also fixed an issue found in the process where checksums were needlessly deleted from a header when validating them.  Some of the tests are still partially disabled due to bugs in checksum computation for binary tables and for compressed images, which still need to be addressed.\n\nFixed two bugs:\n\n 1. Writing a binary table HDU with compression left the original HDU's\n    data byteswapped (and hence mildly \"corrupted\").\n\n 2. Compressed image HDUs did not correctly compute the ZHECKSUM and\n    ZDATASUM header keywords for the checksums of the original image.\n\nThis involved a long-needed breaking up of\nBinTableHDU._binary_table_byte_swap into the actual byte swapping\noperations, and the parts that wrote to a file.  Now that method just\ndoes byte-swapping, and the details of writing the raw data to a file\nobject (including the heap) are handled in\nBinTableHDU._writedata_internal where it belongs.\n\nConflicts:\n\n\tlib/pyfits/tests/test_checksum.py\n\ngit-svn-id: http://svn6.assembla.com/svn/pyfits/branches/3.2-stable@2437 ed100bfc-0583-0410-97f2-c26b58777a21","Erik Bray",true],["0a492dcf78e5e390231beba5f5b734a2e0e64faa","13694847bdacb3ad5c2e2411f328f0f2a0a8420d@gmail.com","Some Python 3 specific fixes, the need for which were brought to my attention by the updated tests in a565ebf26610e9eecd0a2603ac428f056ed7afbd\n\ngit-svn-id: http://svn6.assembla.com/svn/pyfits/branches/3.2-stable@2438 ed100bfc-0583-0410-97f2-c26b58777a21","Erik Bray",true],["508adfa022d4a8d04414192027358e7579a1fe8a","13694847bdacb3ad5c2e2411f328f0f2a0a8420d@gmail.com","Fixes the DeprecationWarning reported in https://github.com/spacetelescope/PyFITS/issues/45 The code here for mucking with urllib is, as far as I can tell, just a workaround for http://bugs.python.org/issue1566800 and shouldn't apply to newer Python versions anyways\n\ngit-svn-id: http://svn6.assembla.com/svn/pyfits/branches/3.2-stable@2443 ed100bfc-0583-0410-97f2-c26b58777a21","Erik Bray",true],["b31f324986827d9fb3b77a73bfe2ce124c329ee1","13694847bdacb3ad5c2e2411f328f0f2a0a8420d@gmail.com","Backport the fix for #8 from 30d0333acc8fce4d07ebc4af4a2d6e2a96af897f\n\ngit-svn-id: http://svn6.assembla.com/svn/pyfits/branches/3.2-stable@2453 ed100bfc-0583-0410-97f2-c26b58777a21","Erik Bray",true],["9b925023f4d29eae9a8f6ca7a8ad222cc261e931","13694847bdacb3ad5c2e2411f328f0f2a0a8420d@gmail.com","Fixes #8 from https://github.com/spacetelescope/PyFITS/issues/8 by ensuring that checksums are added on HDUs that did not already have them.\n\n\nConflicts:\n\n\tlib/pyfits/tests/test_checksum.py\n\ngit-svn-id: http://svn6.assembla.com/svn/pyfits/branches/3.2-stable@2467 ed100bfc-0583-0410-97f2-c26b58777a21","Erik Bray",true],["2c592fec5fc3cb6889a0ab979341121208d31a59","13694847bdacb3ad5c2e2411f328f0f2a0a8420d@gmail.com","An initial solution to the basic problem showing up in issue #47.  The more I look into this though the more apparent it becomes how naive the code is for managing the heap, especially when updating existing files.  I'm going to write some more tests to illustrate some of the problems I think are likely to occur with the current code and see if I can cobble together some slightly more sophisticated heap handling.  This might also fix some other VLA-related issues.\n\n\nConflicts:\n\n\tlib/pyfits/tests/test_table.py\n\ngit-svn-id: http://svn6.assembla.com/svn/pyfits/branches/3.2-stable@2468 ed100bfc-0583-0410-97f2-c26b58777a21","Erik Bray",true],["5393d200d178f8b649e6964d7880d5a4715aa4e8","13694847bdacb3ad5c2e2411f328f0f2a0a8420d@gmail.com","Partial fix for #23. This still isn't perfect though--there are several other header manipulations that can be performed on the compressed image header that won't be reflected in the underling table header.  Some of these, such as inserts, could be especially tricky to handle sensibly.  Maybe updates to the compressed images header shouldn't be immediately reflected in the table header after all, opting instead to merge the two before writing. Still need to give it more thought....\n\ngit-svn-id: http://svn6.assembla.com/svn/pyfits/branches/3.2-stable@2469 ed100bfc-0583-0410-97f2-c26b58777a21","Erik Bray",true],["06b94809a6ccb922ac194d09b5b2af32d4507aa7","13694847bdacb3ad5c2e2411f328f0f2a0a8420d@gmail.com","Squashed commit of the following:\n\ncommit e9437408f2ee3c3d36dd65bcc4be37c3198c3060\nAuthor: Erik M. Bray <embray@stsci.edu>\nDate:   Fri Jan 10 16:56:24 2014 -0500\n\n    Implement fix for the header bool/int issue, to be backported to 3.1.x\n\ncommit 3266ffb856b7eecdc87fb1a5fb9be0a2c2d06d2b\nAuthor: Erik M. Bray <embray@stsci.edu>\nDate:   Fri Jan 10 16:45:03 2014 -0500\n\n    Add a regression test for the header int/bool issue.\n\ngit-svn-id: http://svn6.assembla.com/svn/pyfits/branches/3.2-stable@2470 ed100bfc-0583-0410-97f2-c26b58777a21","Erik Bray",true],["247b70d26b5688546d6943719e8aea8b771da3c7","13694847bdacb3ad5c2e2411f328f0f2a0a8420d@gmail.com","Fix determinism of itersubclasses in Python 3.4; see https://github.com/astropy/astropy/pull/1969\n\ngit-svn-id: http://svn6.assembla.com/svn/pyfits/branches/3.2-stable@2480 ed100bfc-0583-0410-97f2-c26b58777a21","Erik Bray",true],["15f92c39ff8e82e18368161488f3faf17658e3f3","13694847bdacb3ad5c2e2411f328f0f2a0a8420d@gmail.com","Fix Numpy format code for Q format descriptors. It should be a 64-bit integer; it so happened that at least on 64-bit systems 2l4 returned 2 64-bit ints as required, but really it doesn't make a lot of sense as a format code and it's lucky it worked at all.\n\ngit-svn-id: http://svn6.assembla.com/svn/pyfits/branches/3.2-stable@2482 ed100bfc-0583-0410-97f2-c26b58777a21","Erik Bray",true],["552f59a1a2b21d244d8a5dfb9ae5cd35907b197b","13694847bdacb3ad5c2e2411f328f0f2a0a8420d@gmail.com","Another Python 3 fix--definitely should be inserting ASCII-encoded bytes here, not unicode strings.  Not sure exactly why this didn't blow up sooner.\n\ngit-svn-id: http://svn6.assembla.com/svn/pyfits/branches/3.2-stable@2484 ed100bfc-0583-0410-97f2-c26b58777a21","Erik Bray",true],["74480038d34bc89f198dd5c401c64f348402928c","13694847bdacb3ad5c2e2411f328f0f2a0a8420d@gmail.com","Add the -Wno-declaration-after-statement flag needed per https://github.com/astropy/astropy/pull/1971\n\ngit-svn-id: http://svn6.assembla.com/svn/pyfits/branches/3.2-stable@2485 ed100bfc-0583-0410-97f2-c26b58777a21","Erik Bray",true],["79635b19633f6f0dea06d60531a450565f9eab71","13694847bdacb3ad5c2e2411f328f0f2a0a8420d@gmail.com","Fix for issue #49\n\ngit-svn-id: http://svn6.assembla.com/svn/pyfits/branches/3.2-stable@2503 ed100bfc-0583-0410-97f2-c26b58777a21","Erik Bray",true],["13c68776413cceb36f76fd1d3149f3f4a55bc56d","13694847bdacb3ad5c2e2411f328f0f2a0a8420d@gmail.com","Record this fix in the changelog for 3.1 as well.\n\ngit-svn-id: http://svn6.assembla.com/svn/pyfits/branches/3.2-stable@2510 ed100bfc-0583-0410-97f2-c26b58777a21","Erik Bray",true],["ec8effb8323ab625794451d36632468409283fb5","13694847bdacb3ad5c2e2411f328f0f2a0a8420d@gmail.com","Regression test and fix for https://trac.assembla.com/pyfits/ticket/217\n\n\nConflicts:\n\n\tlib/pyfits/tests/test_header.py\n\ngit-svn-id: http://svn6.assembla.com/svn/pyfits/branches/3.2-stable@2511 ed100bfc-0583-0410-97f2-c26b58777a21","Erik Bray",true],["66ba24b18f17266d099ab5069cb158d8ab62eab0","13694847bdacb3ad5c2e2411f328f0f2a0a8420d@gmail.com","Fix a TODO item that is necessary for fileobj_is_binary to return the correct result for a StringIO object in Python 3\n\nConflicts:\n\n\tlib/pyfits/util.py\n\n\nConflicts:\n\n\tlib/pyfits/util.py\n\ngit-svn-id: http://svn6.assembla.com/svn/pyfits/branches/3.2-stable@2512 ed100bfc-0583-0410-97f2-c26b58777a21","Erik Bray",true],["792f15c2aee54523ea16b967e175e66bf5838480","13694847bdacb3ad5c2e2411f328f0f2a0a8420d@gmail.com","A couple fixups for Python 3 compatibility\n\ngit-svn-id: http://svn6.assembla.com/svn/pyfits/branches/3.2-stable@2513 ed100bfc-0583-0410-97f2-c26b58777a21","Erik Bray",true],["0f1afb9249ad0cd941de18fc1ed58a56c21349cf","13694847bdacb3ad5c2e2411f328f0f2a0a8420d@gmail.com","Quick fix to a missing feature I noticed in FITS_rec.from_columns; it was supposed to be there.\n\ngit-svn-id: http://svn6.assembla.com/svn/pyfits/branches/3.2-stable@2520 ed100bfc-0583-0410-97f2-c26b58777a21","Erik Bray",true],["af5ed61b5d6fed2616743bdbc3fbbdacff14bd36","13694847bdacb3ad5c2e2411f328f0f2a0a8420d@gmail.com","Merge branch 'doc-fixes'\n\nConflicts:\n\n\tdocs/source/users_guide/users_tutorial.rst\n\ngit-svn-id: http://svn6.assembla.com/svn/pyfits/branches/3.2-stable@2521 ed100bfc-0583-0410-97f2-c26b58777a21","Erik Bray",true]],"size":19,"ref":"refs/heads/3.2-stable","head":"af5ed61b5d6fed2616743bdbc3fbbdacff14bd36"}