GitHub PullRequestReviewCommentEvent at 2014-09-17 13:30:09
Repository: match-constraints
Actor: Neamar
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/AnyFetch/match-constraints/pulls/comments/17663158","id":17663158,"diff_hunk":"@@ -72,6 +72,17 @@ describe(\"Match objects checker\", function() {\n     boolWrapper(constraints, {}).should.be.true;\n   });\n \n+  it(\"should check for $empty\", function() {\n+    var constraints = {\n+      values: {\n+        $empty: true\n+      }\n+    };\n+\n+    boolWrapper(constraints, {values: []}).should.be.true;","path":"test/index.js","position":11,"original_position":11,"commit_id":"4fd02fbf6b7b52b7d989cda04219c2d39986c900","original_commit_id":"4fd02fbf6b7b52b7d989cda04219c2d39986c900","user":{"login":"Neamar","id":536844,"avatar_url":"https://avatars.githubusercontent.com/u/536844?v=2","gravatar_id":"1bd44880100d5a4ce780441e4b54ddfe","url":"https://api.github.com/users/Neamar","html_url":"https://github.com/Neamar","followers_url":"https://api.github.com/users/Neamar/followers","following_url":"https://api.github.com/users/Neamar/following{/other_user}","gists_url":"https://api.github.com/users/Neamar/gists{/gist_id}","starred_url":"https://api.github.com/users/Neamar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Neamar/subscriptions","organizations_url":"https://api.github.com/users/Neamar/orgs","repos_url":"https://api.github.com/users/Neamar/repos","events_url":"https://api.github.com/users/Neamar/events{/privacy}","received_events_url":"https://api.github.com/users/Neamar/received_events","type":"User","site_admin":false},"body":"I don't see what you mean.\r\n\r\nI was saying you need one more test (a third one) to check that a missing field is noted as empty.","created_at":"2014-09-17T13:30:09Z","updated_at":"2014-09-17T13:30:09Z","html_url":"https://github.com/AnyFetch/match-constraints/pull/1#discussion_r17663158","pull_request_url":"https://api.github.com/repos/AnyFetch/match-constraints/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/AnyFetch/match-constraints/pulls/comments/17663158"},"html":{"href":"https://github.com/AnyFetch/match-constraints/pull/1#discussion_r17663158"},"pull_request":{"href":"https://api.github.com/repos/AnyFetch/match-constraints/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/AnyFetch/match-constraints/pulls/1","id":21359632,"html_url":"https://github.com/AnyFetch/match-constraints/pull/1","diff_url":"https://github.com/AnyFetch/match-constraints/pull/1.diff","patch_url":"https://github.com/AnyFetch/match-constraints/pull/1.patch","issue_url":"https://api.github.com/repos/AnyFetch/match-constraints/issues/1","number":1,"state":"open","locked":false,"title":"Added emptiness constraints","user":{"login":"saveman71","id":1615426,"avatar_url":"https://avatars.githubusercontent.com/u/1615426?v=2","gravatar_id":"28f433e87e959108a2967bcf784a1ec0","url":"https://api.github.com/users/saveman71","html_url":"https://github.com/saveman71","followers_url":"https://api.github.com/users/saveman71/followers","following_url":"https://api.github.com/users/saveman71/following{/other_user}","gists_url":"https://api.github.com/users/saveman71/gists{/gist_id}","starred_url":"https://api.github.com/users/saveman71/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saveman71/subscriptions","organizations_url":"https://api.github.com/users/saveman71/orgs","repos_url":"https://api.github.com/users/saveman71/repos","events_url":"https://api.github.com/users/saveman71/events{/privacy}","received_events_url":"https://api.github.com/users/saveman71/received_events","type":"User","site_admin":false},"body":null,"created_at":"2014-09-17T11:22:17Z","updated_at":"2014-09-17T13:30:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a4aab70b50759072c18358117497025b58041ac0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/AnyFetch/match-constraints/pulls/1/commits","review_comments_url":"https://api.github.com/repos/AnyFetch/match-constraints/pulls/1/comments","review_comment_url":"https://api.github.com/repos/AnyFetch/match-constraints/pulls/comments/{number}","comments_url":"https://api.github.com/repos/AnyFetch/match-constraints/issues/1/comments","statuses_url":"https://api.github.com/repos/AnyFetch/match-constraints/statuses/4fd02fbf6b7b52b7d989cda04219c2d39986c900","head":{"label":"AnyFetch:emptiness","ref":"emptiness","sha":"4fd02fbf6b7b52b7d989cda04219c2d39986c900","user":{"login":"AnyFetch","id":3952848,"avatar_url":"https://avatars.githubusercontent.com/u/3952848?v=2","gravatar_id":"38a329820c5eab64decbf95bf7f3ebcb","url":"https://api.github.com/users/AnyFetch","html_url":"https://github.com/AnyFetch","followers_url":"https://api.github.com/users/AnyFetch/followers","following_url":"https://api.github.com/users/AnyFetch/following{/other_user}","gists_url":"https://api.github.com/users/AnyFetch/gists{/gist_id}","starred_url":"https://api.github.com/users/AnyFetch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnyFetch/subscriptions","organizations_url":"https://api.github.com/users/AnyFetch/orgs","repos_url":"https://api.github.com/users/AnyFetch/repos","events_url":"https://api.github.com/users/AnyFetch/events{/privacy}","received_events_url":"https://api.github.com/users/AnyFetch/received_events","type":"Organization","site_admin":false},"repo":{"id":16981328,"name":"match-constraints","full_name":"AnyFetch/match-constraints","owner":{"login":"AnyFetch","id":3952848,"avatar_url":"https://avatars.githubusercontent.com/u/3952848?v=2","gravatar_id":"38a329820c5eab64decbf95bf7f3ebcb","url":"https://api.github.com/users/AnyFetch","html_url":"https://github.com/AnyFetch","followers_url":"https://api.github.com/users/AnyFetch/followers","following_url":"https://api.github.com/users/AnyFetch/following{/other_user}","gists_url":"https://api.github.com/users/AnyFetch/gists{/gist_id}","starred_url":"https://api.github.com/users/AnyFetch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnyFetch/subscriptions","organizations_url":"https://api.github.com/users/AnyFetch/orgs","repos_url":"https://api.github.com/users/AnyFetch/repos","events_url":"https://api.github.com/users/AnyFetch/events{/privacy}","received_events_url":"https://api.github.com/users/AnyFetch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AnyFetch/match-constraints","description":"Check an object match a given set of constraints","fork":false,"url":"https://api.github.com/repos/AnyFetch/match-constraints","forks_url":"https://api.github.com/repos/AnyFetch/match-constraints/forks","keys_url":"https://api.github.com/repos/AnyFetch/match-constraints/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AnyFetch/match-constraints/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AnyFetch/match-constraints/teams","hooks_url":"https://api.github.com/repos/AnyFetch/match-constraints/hooks","issue_events_url":"https://api.github.com/repos/AnyFetch/match-constraints/issues/events{/number}","events_url":"https://api.github.com/repos/AnyFetch/match-constraints/events","assignees_url":"https://api.github.com/repos/AnyFetch/match-constraints/assignees{/user}","branches_url":"https://api.github.com/repos/AnyFetch/match-constraints/branches{/branch}","tags_url":"https://api.github.com/repos/AnyFetch/match-constraints/tags","blobs_url":"https://api.github.com/repos/AnyFetch/match-constraints/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AnyFetch/match-constraints/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AnyFetch/match-constraints/git/refs{/sha}","trees_url":"https://api.github.com/repos/AnyFetch/match-constraints/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AnyFetch/match-constraints/statuses/{sha}","languages_url":"https://api.github.com/repos/AnyFetch/match-constraints/languages","stargazers_url":"https://api.github.com/repos/AnyFetch/match-constraints/stargazers","contributors_url":"https://api.github.com/repos/AnyFetch/match-constraints/contributors","subscribers_url":"https://api.github.com/repos/AnyFetch/match-constraints/subscribers","subscription_url":"https://api.github.com/repos/AnyFetch/match-constraints/subscription","commits_url":"https://api.github.com/repos/AnyFetch/match-constraints/commits{/sha}","git_commits_url":"https://api.github.com/repos/AnyFetch/match-constraints/git/commits{/sha}","comments_url":"https://api.github.com/repos/AnyFetch/match-constraints/comments{/number}","issue_comment_url":"https://api.github.com/repos/AnyFetch/match-constraints/issues/comments/{number}","contents_url":"https://api.github.com/repos/AnyFetch/match-constraints/contents/{+path}","compare_url":"https://api.github.com/repos/AnyFetch/match-constraints/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AnyFetch/match-constraints/merges","archive_url":"https://api.github.com/repos/AnyFetch/match-constraints/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AnyFetch/match-constraints/downloads","issues_url":"https://api.github.com/repos/AnyFetch/match-constraints/issues{/number}","pulls_url":"https://api.github.com/repos/AnyFetch/match-constraints/pulls{/number}","milestones_url":"https://api.github.com/repos/AnyFetch/match-constraints/milestones{/number}","notifications_url":"https://api.github.com/repos/AnyFetch/match-constraints/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AnyFetch/match-constraints/labels{/name}","releases_url":"https://api.github.com/repos/AnyFetch/match-constraints/releases{/id}","created_at":"2014-02-19T10:49:07Z","updated_at":"2014-07-16T15:56:20Z","pushed_at":"2014-09-17T11:22:11Z","git_url":"git://github.com/AnyFetch/match-constraints.git","ssh_url":"git@github.com:AnyFetch/match-constraints.git","clone_url":"https://github.com/AnyFetch/match-constraints.git","svn_url":"https://github.com/AnyFetch/match-constraints","homepage":null,"size":272,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"AnyFetch:master","ref":"master","sha":"f0fd379c3b539c92d508da9bb10cdd09379296f3","user":{"login":"AnyFetch","id":3952848,"avatar_url":"https://avatars.githubusercontent.com/u/3952848?v=2","gravatar_id":"38a329820c5eab64decbf95bf7f3ebcb","url":"https://api.github.com/users/AnyFetch","html_url":"https://github.com/AnyFetch","followers_url":"https://api.github.com/users/AnyFetch/followers","following_url":"https://api.github.com/users/AnyFetch/following{/other_user}","gists_url":"https://api.github.com/users/AnyFetch/gists{/gist_id}","starred_url":"https://api.github.com/users/AnyFetch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnyFetch/subscriptions","organizations_url":"https://api.github.com/users/AnyFetch/orgs","repos_url":"https://api.github.com/users/AnyFetch/repos","events_url":"https://api.github.com/users/AnyFetch/events{/privacy}","received_events_url":"https://api.github.com/users/AnyFetch/received_events","type":"Organization","site_admin":false},"repo":{"id":16981328,"name":"match-constraints","full_name":"AnyFetch/match-constraints","owner":{"login":"AnyFetch","id":3952848,"avatar_url":"https://avatars.githubusercontent.com/u/3952848?v=2","gravatar_id":"38a329820c5eab64decbf95bf7f3ebcb","url":"https://api.github.com/users/AnyFetch","html_url":"https://github.com/AnyFetch","followers_url":"https://api.github.com/users/AnyFetch/followers","following_url":"https://api.github.com/users/AnyFetch/following{/other_user}","gists_url":"https://api.github.com/users/AnyFetch/gists{/gist_id}","starred_url":"https://api.github.com/users/AnyFetch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnyFetch/subscriptions","organizations_url":"https://api.github.com/users/AnyFetch/orgs","repos_url":"https://api.github.com/users/AnyFetch/repos","events_url":"https://api.github.com/users/AnyFetch/events{/privacy}","received_events_url":"https://api.github.com/users/AnyFetch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AnyFetch/match-constraints","description":"Check an object match a given set of constraints","fork":false,"url":"https://api.github.com/repos/AnyFetch/match-constraints","forks_url":"https://api.github.com/repos/AnyFetch/match-constraints/forks","keys_url":"https://api.github.com/repos/AnyFetch/match-constraints/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AnyFetch/match-constraints/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AnyFetch/match-constraints/teams","hooks_url":"https://api.github.com/repos/AnyFetch/match-constraints/hooks","issue_events_url":"https://api.github.com/repos/AnyFetch/match-constraints/issues/events{/number}","events_url":"https://api.github.com/repos/AnyFetch/match-constraints/events","assignees_url":"https://api.github.com/repos/AnyFetch/match-constraints/assignees{/user}","branches_url":"https://api.github.com/repos/AnyFetch/match-constraints/branches{/branch}","tags_url":"https://api.github.com/repos/AnyFetch/match-constraints/tags","blobs_url":"https://api.github.com/repos/AnyFetch/match-constraints/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AnyFetch/match-constraints/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AnyFetch/match-constraints/git/refs{/sha}","trees_url":"https://api.github.com/repos/AnyFetch/match-constraints/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AnyFetch/match-constraints/statuses/{sha}","languages_url":"https://api.github.com/repos/AnyFetch/match-constraints/languages","stargazers_url":"https://api.github.com/repos/AnyFetch/match-constraints/stargazers","contributors_url":"https://api.github.com/repos/AnyFetch/match-constraints/contributors","subscribers_url":"https://api.github.com/repos/AnyFetch/match-constraints/subscribers","subscription_url":"https://api.github.com/repos/AnyFetch/match-constraints/subscription","commits_url":"https://api.github.com/repos/AnyFetch/match-constraints/commits{/sha}","git_commits_url":"https://api.github.com/repos/AnyFetch/match-constraints/git/commits{/sha}","comments_url":"https://api.github.com/repos/AnyFetch/match-constraints/comments{/number}","issue_comment_url":"https://api.github.com/repos/AnyFetch/match-constraints/issues/comments/{number}","contents_url":"https://api.github.com/repos/AnyFetch/match-constraints/contents/{+path}","compare_url":"https://api.github.com/repos/AnyFetch/match-constraints/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AnyFetch/match-constraints/merges","archive_url":"https://api.github.com/repos/AnyFetch/match-constraints/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AnyFetch/match-constraints/downloads","issues_url":"https://api.github.com/repos/AnyFetch/match-constraints/issues{/number}","pulls_url":"https://api.github.com/repos/AnyFetch/match-constraints/pulls{/number}","milestones_url":"https://api.github.com/repos/AnyFetch/match-constraints/milestones{/number}","notifications_url":"https://api.github.com/repos/AnyFetch/match-constraints/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AnyFetch/match-constraints/labels{/name}","releases_url":"https://api.github.com/repos/AnyFetch/match-constraints/releases{/id}","created_at":"2014-02-19T10:49:07Z","updated_at":"2014-07-16T15:56:20Z","pushed_at":"2014-09-17T11:22:11Z","git_url":"git://github.com/AnyFetch/match-constraints.git","ssh_url":"git@github.com:AnyFetch/match-constraints.git","clone_url":"https://github.com/AnyFetch/match-constraints.git","svn_url":"https://github.com/AnyFetch/match-constraints","homepage":null,"size":272,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AnyFetch/match-constraints/pulls/1"},"html":{"href":"https://github.com/AnyFetch/match-constraints/pull/1"},"issue":{"href":"https://api.github.com/repos/AnyFetch/match-constraints/issues/1"},"comments":{"href":"https://api.github.com/repos/AnyFetch/match-constraints/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/AnyFetch/match-constraints/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/AnyFetch/match-constraints/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/AnyFetch/match-constraints/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/AnyFetch/match-constraints/statuses/4fd02fbf6b7b52b7d989cda04219c2d39986c900"}}}}