GitHub PullRequestReviewCommentEvent at 2014-01-19 02:42:18
Repository: okhttp
Actor: swankjesse
Payload: {"comment":{"url":"https://api.github.com/repos/square/okhttp/pulls/comments/8990693","id":8990693,"diff_hunk":"@@ -139,13 +140,45 @@ private HpackDraft05() {\n      */\n     BitArray referencedStaticHeaders = new BitArray();\n     int headerTableByteCount = 0;\n-    int maxHeaderTableByteCount = 4096; // TODO: needs to come from SETTINGS_HEADER_TABLE_SIZE.\n \n-    Reader(boolean client, DataInputStream in) {\n+    Reader(boolean client, int maxHeaderTableByteCount, DataInputStream in) {\n       this.huffmanCodec = client ? Huffman.Codec.RESPONSE : Huffman.Codec.REQUEST;\n+      this.maxHeaderTableByteCount = maxHeaderTableByteCount;\n       this.in = in;\n     }\n \n+    int maxHeaderTableByteCount() {\n+      return maxHeaderTableByteCount;\n+    }\n+\n+    /** Evicts entries as needed. Noop when {@code newMaxHeaderTableByteCount} is negative. */","path":"okhttp-protocols/src/main/java/com/squareup/okhttp/internal/spdy/HpackDraft05.java","position":25,"original_position":25,"commit_id":"7b44c264a0de63df47490ac0b319a3870bf7241a","original_commit_id":"7b44c264a0de63df47490ac0b319a3870bf7241a","user":{"login":"swankjesse","id":133019,"avatar_url":"https://gravatar.com/avatar/92c80ad799d0788de9ec7a4e3a26f98d?d=https%3A%2F%2Fidenticons.github.com%2F3e0b752bcfefa1b78e80d63918ff1834.png&r=x","gravatar_id":"92c80ad799d0788de9ec7a4e3a26f98d","url":"https://api.github.com/users/swankjesse","html_url":"https://github.com/swankjesse","followers_url":"https://api.github.com/users/swankjesse/followers","following_url":"https://api.github.com/users/swankjesse/following{/other_user}","gists_url":"https://api.github.com/users/swankjesse/gists{/gist_id}","starred_url":"https://api.github.com/users/swankjesse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swankjesse/subscriptions","organizations_url":"https://api.github.com/users/swankjesse/orgs","repos_url":"https://api.github.com/users/swankjesse/repos","events_url":"https://api.github.com/users/swankjesse/events{/privacy}","received_events_url":"https://api.github.com/users/swankjesse/received_events","type":"User","site_admin":false},"body":"Just curious: why would it be negative?","created_at":"2014-01-19T02:42:18Z","updated_at":"2014-01-19T02:42:18Z","html_url":"https://github.com/square/okhttp/pull/456#discussion_r8990693","pull_request_url":"https://api.github.com/repos/square/okhttp/pulls/456","_links":{"self":{"href":"https://api.github.com/repos/square/okhttp/pulls/comments/8990693"},"html":{"href":"https://github.com/square/okhttp/pull/456#discussion_r8990693"},"pull_request":{"href":"https://api.github.com/repos/square/okhttp/pulls/456"}}}}