i.e., the pattern of starting with a noContent and morphing it into a 404 is used elsewhere in the codebase and it seemed appropriate here.
Also, the result produced upon examination looked fine.



> On Mar 7, 2014, at 8:00 PM, Jonathan Leonard <johanatan@gmail.com> wrote:
> 
> The point here is to return 404; not noContent.
> 
> 
> 
>> On Mar 7, 2014, at 7:55 PM, Tobi Knaup <notifications@github.com> wrote:
>> 
>> In src/main/scala/mesosphere/marathon/api/v1/TasksResource.scala:
>> 
>> > @@ -42,6 +40,7 @@ class TasksResource @Inject()(
>> >        x.getHost == host || x.getId == id || host == "*"
>> >      )
>> >  
>> > -    service.killTasks(appId, toKill, scale)
>> > +    if (toKill.size == 0) Response.noContent.status(404).build
>> block should go on a new line
>> noContent is actually HTTP 204. Try Response.status(Status.NOT_FOUND).build
>> 
>> —
>> Reply to this email directly or view it on GitHub.