great - thx Lars


2014/1/14 Lars Buitinck <notifications@github.com>

> In sklearn/tree/_tree.pyx:
>
> >
> >              # Evaluate all splits
> >              self.criterion.reset()
> >              p = start
> >
> >              while p < end:
> > -                while ((p + 1 < end) and
> > -                       (X[X_sample_stride * samples[p + 1] + X_fx_stride * current_feature] <=
> > -                        X[X_sample_stride * samples[p] + X_fx_stride * current_feature] + EPSILON_FLT)):
> > +                while p + 1 < end and Xf[p + 1] <= Xf[p] + EPSILON_FLT:
>
> Right, this is it. Will change this bit tonight.
>
> @pprett <https://github.com/pprett> No, this isn't actually the cause of
> the speedup, it was near 50% before I even introduced this bug.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/scikit-learn/scikit-learn/pull/2747/files#r8859593>
> .
>



-- 
Peter Prettenhofer